Tools/ChangeLog

   1 2012-02-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
   2
   3         [EFL][DRT] Implement setValueForUser and setAutofilled.
   4         https://bugs.webkit.org/show_bug.cgi?id=79237
   5
   6         Reviewed by Andreas Kling.
   7
   8         Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
   9         Those implementations are related with input fields and allow to pass following tests:
  10         fast/forms/onchange-setvalueforuser.html
  11         fast/forms/input-autofilled.html
  12         fast/forms/reset-autofilled.html
  13
  14         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  15         (LayoutTestController::setValueForUser):
  16         (LayoutTestController::setAutofilled):
  17
  18 2012-02-24  Zoltan Horvath  <zoltan@webkit.org>
  19
  20         [Qt] Allow to use WebCore imagedecoders
  21         https://bugs.webkit.org/show_bug.cgi?id=32410
  22
  23         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
  24
  25         Reviewed by Simon Hausmann.
  26
  27         * qmake/mkspecs/features/features.prf:
  28
  29 2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>
  30
  31         [Qt] Add Qt5 way to force 96 DPI for tests
  32         https://bugs.webkit.org/show_bug.cgi?id=79364
  33
  34         Reviewed by Simon Hausmann.
  35
  36         * DumpRenderTree/qt/main.cpp:
  37         (main):
  38         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  39         (WTR::activateFonts):
  40
  41 2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
  42
  43         [GTK] MiniBrowser should reload the view then the reload button is clicked
  44         https://bugs.webkit.org/show_bug.cgi?id=79472
  45
  46         Reviewed by Philippe Normand.
  47
  48         * MiniBrowser/gtk/BrowserWindow.c:
  49         (reloadCallback): Call webkit_web_view_reload().
  50         (browser_window_init): Connect reload item clicked even to
  51         reloadCallback instead of activateUriEntryCallback.
  52
  53 2012-02-24  Kentaro Hara  <haraken@chromium.org>
  54
  55         Add performance tests for DOM attribute getters and setters
  56         https://bugs.webkit.org/show_bug.cgi?id=79208
  57
  58         Reviewed by Ryosuke Niwa.
  59
  60         We want to allow perf tests to output info messages
  61         that do not affect the test results. To accomplish this,
  62         this patch modifies perftestsrunner.py so that it ignores
  63         a line that starts from "Info:".
  64
  65         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  66         (PerfTestsRunner):
  67
  68 2012-02-24  Andrew Lo  <anlo@rim.com>
  69
  70         [BlackBerry] Enable requestAnimationFrame
  71         https://bugs.webkit.org/show_bug.cgi?id=79408
  72
  73         Enable requestAnimationFrame for BlackBerry.
  74
  75         Reviewed by Rob Buis.
  76
  77         * Scripts/build-webkit:
  78
  79 2012-02-24  Adam Barth  <abarth@webkit.org>
  80
  81         style-queue tries to apply the patch twice
  82         https://bugs.webkit.org/show_bug.cgi?id=79459
  83
  84         Reviewed by Eric Seidel.
  85
  86         Previously, we applied the patch using both apply-patch and
  87         check-style.  This patch introduces a check-style-local to mirror the
  88         apply-watchlist-local, which operates on the current working diff.
  89
  90         This patch also cleans up some other bugs I found by running the queue
  91         locally for a while.  The queue still prints out a slightly
  92         less-than-ideal message on the bugs when it find an error, but it's ok
  93         for now.  We'll need to iterate a bit.
  94
  95         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
  96         (StyleQueueTask.validate):
  97         (StyleQueueTask._check_style):
  98         * Scripts/webkitpy/tool/commands/download.py:
  99         (CheckStyleLocal):
 100         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
 101         (EarlyWarningSytemTest._default_expected_stderr):
 102         (EarlyWarningSytemTest._test_testing_ews):
 103         * Scripts/webkitpy/tool/commands/queues.py:
 104         (AbstractReviewQueue.handle_script_error):
 105         (StyleQueue.review_patch):
 106         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 107         * Scripts/webkitpy/tool/commands/queuestest.py:
 108         (QueuesTest.assert_queue_outputs):
 109
 110 2012-02-23  Adam Barth  <abarth@webkit.org>
 111
 112         should_proceed_with_work_item is unused and can be removed
 113         https://bugs.webkit.org/show_bug.cgi?id=79416
 114
 115         Reviewed by Eric Seidel.
 116
 117         We used to use this function to check whether the tree is red.  Now, we
 118         don't use external measures of whether to proceed with work items.
 119         Instead, we analyze them with the idea in mind that the tree might be
 120         red.
 121
 122         * Scripts/webkitpy/tool/bot/queueengine.py:
 123         (QueueEngineDelegate.next_work_item):
 124         (QueueEngine.run):
 125         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
 126         (LoggingDelegate):
 127         (LoggingDelegate.next_work_item):
 128         (RaisingDelegate.process_work_item):
 129         (QueueEngineTest.test_terminating_error):
 130         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 131         (AbstractEarlyWarningSystem.__init__):
 132         * Scripts/webkitpy/tool/commands/queues.py:
 133         (AbstractQueue.next_work_item):
 134         (FeederQueue.next_work_item):
 135         (CommitQueue.next_work_item):
 136         (AbstractReviewQueue.next_work_item):
 137         (StyleQueue.__init__):
 138         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 139         (FeederQueueTest.test_feeder_queue):
 140         (CommitQueueTest.test_commit_queue):
 141         (test_commit_queue_failure):
 142         (test_commit_queue_failure_with_failing_tests):
 143         (test_rollout):
 144         (test_rollout_lands):
 145         (StyleQueueTest.test_style_queue_with_style_exception):
 146         (test_style_queue_with_watch_list_exception):
 147         * Scripts/webkitpy/tool/commands/queuestest.py:
 148         (QueuesTest.assert_queue_outputs):
 149         * Scripts/webkitpy/tool/commands/sheriffbot.py:
 150         (SheriffBot.next_work_item):
 151
 152 2012-02-23  Adrienne Walker  <enne@google.com>
 153
 154         Unreviewed, add Stephen Chenney to committers.py as a contributor.
 155
 156         * Scripts/webkitpy/common/config/committers.py:
 157
 158 2012-02-23  Adam Barth  <abarth@webkit.org>
 159
 160         style-queue logs bogus messages to the QueueStatusServer
 161         https://bugs.webkit.org/show_bug.cgi?id=79424
 162
 163         Reviewed by Eric Seidel.
 164
 165         Copy/paste error.
 166
 167         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
 168         (StyleQueueTask._check_style):
 169         (StyleQueueTask._apply_watch_list):
 170         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 171
 172 2012-02-23  Eric Seidel  <eric@webkit.org>
 173
 174         Use self._filesystem in more places in the SCM classes
 175         https://bugs.webkit.org/show_bug.cgi?id=79415
 176
 177         Reviewed by Adam Barth.
 178
 179         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
 180         (SCMDetectorTest.test_detect_scm_system):
 181         * Scripts/webkitpy/common/checkout/scm/git.py:
 182         (Git.find_checkout_root):
 183         (Git.to_object_name):
 184         * Scripts/webkitpy/common/checkout/scm/scm.py:
 185         (SCM.__init__):
 186         (SCM.in_working_directory):
 187         * Scripts/webkitpy/common/checkout/scm/svn.py:
 188         (SVN.find_uuid):
 189         (SVN.find_checkout_root):
 190
 191 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
 192
 193         Unreviewed, rolling out r108685.
 194         http://trac.webkit.org/changeset/108685
 195         https://bugs.webkit.org/show_bug.cgi?id=79414
 196
 197         Broke Chromium builds (Requested by enne on #webkit).
 198
 199         * qmake/mkspecs/features/features.prf:
 200
 201 2012-02-23  Adam Barth  <abarth@webkit.org>
 202
 203         style-queue shouldn't spam bugs if it fails to update its working copy
 204         https://bugs.webkit.org/show_bug.cgi?id=79412
 205
 206         Reviewed by Eric Seidel.
 207
 208         This patch moves style-queue over to the new PatchAnalysisTask
 209         infrastructure, which is smarter about retrying patches when update
 210         fails.
 211
 212         * Scripts/webkitpy/common/system/executive_mock.py:
 213         (MockExecutive.run_and_throw_if_fail):
 214         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
 215         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
 216         (UnableToApplyPatch):
 217         (UnableToApplyPatch.__init__):
 218         (PatchAnalysisTask.__init__):
 219         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
 220         (StyleQueueTaskDelegate):
 221         (StyleQueueTaskDelegate.parent_command):
 222         (StyleQueueTask):
 223         (StyleQueueTask.validate):
 224         (StyleQueueTask._check_style):
 225         (StyleQueueTask._apply_watch_list):
 226         (StyleQueueTask.run):
 227         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 228         * Scripts/webkitpy/tool/commands/queues.py:
 229         (StyleQueue):
 230         (StyleQueue.should_proceed_with_work_item):
 231         (StyleQueue.review_patch):
 232         (StyleQueue.run_command):
 233         (StyleQueue.command_passed):
 234         (StyleQueue.command_failed):
 235         (StyleQueue.expected_failures):
 236         (StyleQueue.refetch_patch):
 237         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 238         (StyleQueueTest.test_style_queue_with_style_exception):
 239         (test_style_queue_with_watch_list_exception):
 240
 241 2012-02-23  Zoltan Horvath  <zoltan@webkit.org>
 242
 243         [Qt] Allow to use WebCore imagedecoders
 244         https://bugs.webkit.org/show_bug.cgi?id=32410
 245
 246         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
 247
 248         Reviewed by Simon Hausmann.
 249
 250         * qmake/mkspecs/features/features.prf:
 251
 252 2012-02-23  Eric Seidel  <eric@webkit.org>
 253
 254         Remove old broken find_checkout_root tests now that find_checkout_root is gone
 255         https://bugs.webkit.org/show_bug.cgi?id=79405
 256
 257         Reviewed by Adam Barth.
 258
 259         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
 260         (SCMDetectorTest):
 261         (SCMDetectorTest.test_find_checkout_root):
 262         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 263         (SVNTestRepository.tear_down):
 264
 265 2012-02-23  Michael Brüning  <michael.bruning@nokia.com>
 266
 267         [Qt][WK2] Implement proxy authentication dialog.
 268         https://bugs.webkit.org/show_bug.cgi?id=79350
 269
 270         Reviewed by Simon Hausmann.
 271
 272         * MiniBrowser/qt/MiniBrowser.qrc:
 273         * MiniBrowser/qt/qml/BrowserWindow.qml:
 274         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
 275
 276 2012-02-23  Kevin Ollivier  <kevino@theolliviers.com>
 277
 278         [wx] Build fix, add recently added source dirs.
 279
 280         * waf/build/settings.py:
 281
 282 2012-02-23  Simon Hausmann  <simon.hausmann@nokia.com>
 283
 284         [Qt] Add support for touch cancellation
 285         https://bugs.webkit.org/show_bug.cgi?id=79348
 286
 287         Reviewed by Kenneth Rohde Christiansen.
 288
 289         Added straight-forward touch cancellation event sending to Qt WK1 DRT
 290         and WK2 WTR.
 291
 292         * DumpRenderTree/qt/EventSenderQt.cpp:
 293         (EventSender::touchCancel):
 294         (EventSender::cancelTouchPoint):
 295         * DumpRenderTree/qt/EventSenderQt.h:
 296         (EventSender):
 297         * WebKitTestRunner/EventSenderProxy.h:
 298         (EventSenderProxy):
 299         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
 300         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
 301         (WTR::EventSendingController::touchCancel):
 302         (WTR):
 303         (WTR::EventSendingController::cancelTouchPoint):
 304         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
 305         (EventSendingController):
 306         * WebKitTestRunner/TestController.cpp:
 307         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
 308         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
 309         (WTR::EventSenderProxy::touchCancel):
 310         (WTR):
 311         (WTR::EventSenderProxy::cancelTouchPoint):
 312
 313 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
 314
 315         Unreviewed, rolling out r108626.
 316         http://trac.webkit.org/changeset/108626
 317         https://bugs.webkit.org/show_bug.cgi?id=79370
 318
 319         broke qt-wk2 bot, somehow the workaround does not work on the
 320         bot (Requested by Ossy on #webkit).
 321
 322         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
 323         (WTR::WrapperWindow::handleStatusChanged):
 324         (WTR::PlatformWebView::resizeTo):
 325
 326 2012-02-23  ChangSeok Oh  <shivamidow@gmail.com>
 327
 328         [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
 329         https://bugs.webkit.org/show_bug.cgi?id=78481
 330
 331         Reviewed by Gustavo Noronha Silva.
 332
 333         Extracted shareable code from keyDownCallback and then added createKeyPressEvent
 334         to create gdk press key event.
 335         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
 336         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
 337
 338         * DumpRenderTree/gtk/EventSender.cpp:
 339         (scheduleAsynchronousClickCallback):
 340         (createKeyPressEvent):
 341         (sendKeyDown):
 342         (keyDownCallback):
 343         (sendAsynchronousKeyDown):
 344         (scheduleAsynchronousKeyDownCallback):
 345
 346 2012-02-23  Balazs Kelemen  <kbalazs@webkit.org>
 347
 348         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
 349         https://bugs.webkit.org/show_bug.cgi?id=76546
 350
 351         Reviewed by Simon Hausmann.
 352
 353         Co-authored with Simon Hausmann.
 354
 355         Revert the workaround introduced in r107868 and reintroduce
 356         the qml binding so we can test the code path that we are more
 357         interested in. The reason that it did not work before is that
 358         we don't have an active platform window which we now workaround
 359         by propagating the resize through QWindowSystemInterface.
 360
 361         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
 362         (WTR::WrapperWindow::handleStatusChanged):
 363         (WTR::PlatformWebView::resizeTo):
 364
 365 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
 366
 367         Unreviewed, rolling out r108577.
 368         http://trac.webkit.org/changeset/108577
 369         https://bugs.webkit.org/show_bug.cgi?id=79359
 370
 371         It doesn't work as expected (Requested by Ossy on #webkit).
 372
 373         * DumpRenderTree/qt/EventSenderQt.cpp:
 374         (EventSender::postEvent):
 375         * DumpRenderTree/qt/EventSenderQt.h:
 376         (EventSender):
 377
 378 2012-02-23  Philippe Normand  <pnormand@igalia.com>
 379
 380         [GTK] FullScreen signals
 381         https://bugs.webkit.org/show_bug.cgi?id=76181
 382
 383         Reviewed by Martin Robinson.
 384
 385         Use the two new entering/leaving fullscreen signals to hide/show
 386         the tool bar, the status bar and ask the user's permission before
 387         entering fullscreen.
 388
 389         * GtkLauncher/main.c:
 390         (webViewFullscreenMessageWindowClose):
 391         (webViewWindowStateEvent):
 392         (hide_widget):
 393         (show_widget):
 394         (webViewEnteringFullScreen):
 395         (webViewLeavingFullScreen):
 396         (createBrowser):
 397         (createWindow):
 398
 399 2012-02-22  Dongwoo Im  <dw.im@samsung.com>
 400
 401         [EFL] Fix to launch the EWebLauncher using the script, run-launcher.
 402         https://bugs.webkit.org/show_bug.cgi?id=79076
 403
 404         Reviewed by Andreas Kling.
 405
 406         * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
 407         (builtDylibPathForName):
 408
 409 2012-02-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
 410
 411         [Qt] Add eventSender.gestureTap
 412         https://bugs.webkit.org/show_bug.cgi?id=66173
 413
 414         Reviewed by Kenneth Rohde Christiansen.
 415
 416         * DumpRenderTree/qt/EventSenderQt.cpp:
 417         (EventSender::gestureTap):
 418         * DumpRenderTree/qt/EventSenderQt.h:
 419
 420 2012-02-22  Brady Eidson  <beidson@apple.com>
 421
 422         <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
 423         Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs
 424
 425         Reviewed by Anders Carlsson.
 426
 427         Update our tools to the new form of the PageLoadClient.
 428
 429         * MiniBrowser/mac/BrowserWindowController.m:
 430         (-[BrowserWindowController awakeFromNib]):
 431
 432         * WebKitTestRunner/TestController.cpp:
 433         (WTR::TestController::initialize):
 434
 435 2012-02-22  Daniel Bates  <dbates@webkit.org>
 436
 437         new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
 438         https://bugs.webkit.org/show_bug.cgi?id=79277
 439
 440         Reviewed by Adam Barth.
 441
 442         Pass command line argument no-saved-state to run-safari to disable Safari
 443         state restoration for the session on OS 10.7.
 444
 445         * Scripts/webkitpy/layout_tests/port/mac.py:
 446         (MacPort.show_results_html_file):
 447         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
 448         (test_show_results_html_file):
 449
 450 2012-02-22  Kalev Lember  <kalevlember@gmail.com>
 451
 452         Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
 453         https://bugs.webkit.org/show_bug.cgi?id=77759
 454
 455         Reviewed by Tony Chang.
 456
 457         Fixes build with gcc 4.7.
 458
 459         r100432 added the include only for ANDROID; this changes the ifdef to
 460         also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
 461         longer implicitly includes unistd.h from standard headers and other
 462         unix platforms are likely to get gcc 4.7 as well in the future.
 463
 464         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
 465
 466 2012-02-22  Philippe Normand  <pnormand@igalia.com>
 467
 468         Unreviewed, rolling out r108522.
 469         http://trac.webkit.org/changeset/108522
 470         https://bugs.webkit.org/show_bug.cgi?id=76181
 471
 472         Broke 4 fullscreen tests on GTK.
 473
 474         * GtkLauncher/main.c:
 475         (createBrowser):
 476         (createWindow):
 477
 478 2012-02-20  Philippe Normand  <pnormand@igalia.com>
 479
 480         [GTK] FullScreen signals
 481         https://bugs.webkit.org/show_bug.cgi?id=76181
 482
 483         Reviewed by Martin Robinson.
 484
 485         Use the two new entering/leaving fullscreen signals to hide/show
 486         the tool bar, the status bar and ask the user's permission before
 487         entering fullscreen.
 488
 489         * GtkLauncher/main.c:
 490         (webViewFullscreenMessageWindowClose):
 491         (webViewWindowStateEvent):
 492         (hide_widget):
 493         (show_widget):
 494         (webViewEnteringFullScreen):
 495         (webViewLeavingFullScreen):
 496         (createBrowser):
 497         (createWindow):
 498
 499 2012-02-22  Rob Flack  <flackr@chromium.org>
 500
 501         Update Linux ChromiumOS builders in flakiness dashboard.
 502         https://bugs.webkit.org/show_bug.cgi?id=79238
 503
 504         Reviewed by Ojan Vafai.
 505
 506         * TestResultServer/static-dashboards/builders.js:
 507
 508 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
 509
 510         webkitpy: test_function_length_check_definition_huge_lines is slow
 511         https://bugs.webkit.org/show_bug.cgi?id=79185
 512
 513         Reviewed by Adam Barth.
 514
 515         This test takes ~3 seconds to run, apparently because we're
 516         running a test on a 10,000 line function :). Dropping the
 517         function length to 640 still exercises the code path and
 518         provides a 10x speedup.
 519
 520         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 521         (CppStyleTest):
 522         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
 523
 524 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
 525
 526         webkitpy: speed up FileLockTest.test_lock_lifecycle
 527         https://bugs.webkit.org/show_bug.cgi?id=79189
 528
 529         Reviewed by Adam Barth.
 530
 531         The unit test had a second lock trying to acquire a
 532         lock already held, and a hard-coded timeout of one second.
 533         I have changed the timeouts to a tenth of a second (which
 534         is probably still fine) and changed the hard-spin on
 535         the lock to a slow-spin every hundredth of a second.
 536
 537         * Scripts/webkitpy/common/system/file_lock.py:
 538         (FileLock.acquire_lock):
 539         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
 540         (FileLockTest.setUp):
 541         (FileLockTest.test_stuck_lock):
 542
 543 2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>
 544
 545         build-webkit should use environment variable at number of CPU
 546         detection on all platform
 547         https://bugs.webkit.org/show_bug.cgi?id=79227
 548
 549         Reviewed by Martin Robinson.
 550
 551         * Scripts/webkitdirs.pm:
 552         (determineNumberOfCPUs):
 553
 554 2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>
 555
 556         [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
 557         https://bugs.webkit.org/show_bug.cgi?id=78960
 558
 559         Reviewed by Csaba Osztrogonác.
 560
 561         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 562         (LayoutTestController::overridePreference):
 563
 564 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
 565
 566         [chromium] Build WebKit with MEDIA_STREAM disabled.
 567         https://bugs.webkit.org/show_bug.cgi?id=79214
 568
 569         Reviewed by Kent Tamura.
 570
 571         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
 572         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
 573         * DumpRenderTree/chromium/WebViewHost.cpp:
 574         (WebViewHost::createMediaPlayer):
 575         * DumpRenderTree/chromium/WebViewHost.h:
 576         (WebViewHost):
 577
 578 2012-02-22  Zeno Albisser  <zeno@webkit.org>
 579
 580         [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
 581         https://bugs.webkit.org/show_bug.cgi?id=79124
 582
 583         WebKitTestRunnerPrefix.h should also be included
 584         when building with clang.
 585
 586         Reviewed by Kenneth Rohde Christiansen.
 587
 588         * WebKitTestRunner/Target.pri:
 589
 590 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
 591
 592         <style scoped>: Add runtime-flag
 593         https://bugs.webkit.org/show_bug.cgi?id=79074
 594
 595         Enable the runtime-flag for DRT.
 596
 597         Reviewed by Dimitri Glazkov.
 598
 599         * DumpRenderTree/chromium/TestShell.cpp:
 600         (TestShell::TestShell):
 601
 602 2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
 603
 604         Unreviewed, rolling out r107351.
 605         http://trac.webkit.org/changeset/107351
 606         https://bugs.webkit.org/show_bug.cgi?id=53600
 607
 608         Several issues introduced in WebKitGTK+ API
 609
 610         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 611         (createWebView):
 612         * GtkLauncher/main.c:
 613         (createWebViewCb):
 614         (createBrowser):
 615         (createWindow):
 616         (main):
 617
 618 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
 619
 620         JSC should be a triple-tier VM
 621         https://bugs.webkit.org/show_bug.cgi?id=75812
 622         <rdar://problem/10079694>
 623
 624         Reviewed by Gavin Barraclough.
 625
 626         Changed EFL's build system to include a new directory in JavaScriptCore.
 627
 628         * DumpRenderTree/efl/CMakeLists.txt:
 629
 630 2012-02-21  Daniel Cheng  <dcheng@chromium.org>
 631
 632         [chromium] Fix image drag out on Chromium
 633         https://bugs.webkit.org/show_bug.cgi?id=79158
 634
 635         Reviewed by Tony Chang.
 636
 637         * DumpRenderTree/chromium/EventSender.cpp:
 638         (EventSender::dumpFilenameBeingDragged):
 639         (EventSender::beginDragWithFiles):
 640         * DumpRenderTree/chromium/WebViewHost.cpp:
 641         (addDRTFakeFileToDataObject):
 642
 643 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
 644
 645         webkitpy: speed up hot filesystem_mock functions
 646         https://bugs.webkit.org/show_bug.cgi?id=79159
 647
 648         Reviewed by Adam Barth.
 649
 650         Profiling run_webkit_tests_integrationtest.py revealed that
 651         isdir(), normpath(), and join() are called a lot and were very
 652         slow.This patch speeds them up substantially, shaving 20 seconds
 653         off of the execution time.
 654
 655         * Scripts/webkitpy/common/system/filesystem_mock.py:
 656         (MockFileSystem.isdir):
 657         (MockFileSystem._slow_but_correct_join):
 658         (MockFileSystem.join):
 659         (MockFileSystem.listdir):
 660         (MockFileSystem._slow_but_correct_normpath):
 661         (MockFileSystem.normpath):
 662         (MockFileSystem.write_binary_file):
 663         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
 664         (MockFileSystemTest.quick_check):
 665         (MockFileSystemTest):
 666         (MockFileSystemTest.test_join):
 667         (MockFileSystemTest.test_normpath):
 668         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
 669         (get_test_config): Call write_binary_file() instead of updating
 670           filesystem.files directly, so that we create directories as
 671           needed.
 672
 673 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
 674
 675         nrwt: make the delay between starting workers configurable per-port
 676         https://bugs.webkit.org/show_bug.cgi?id=79148
 677
 678         Reviewed by Eric Seidel.
 679
 680         Because of bug 79147, we have to sleep a bit in between starting
 681         DRTs; however, doing so across the board slows down the Test
 682         port. Making this configurable shaves 10 seconds off of
 683         run_webkit_tests_integrationtest.py
 684
 685         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 686         (Manager._run_tests):
 687         * Scripts/webkitpy/layout_tests/port/base.py:
 688         (Port.worker_startup_delay_secs):
 689         * Scripts/webkitpy/layout_tests/port/test.py:
 690         (TestPort.worker_startup_delay_secs):
 691
 692 2012-02-21  Jon Lee  <jonlee@apple.com>
 693
 694         Bring notifications support to WK1 mac
 695         https://bugs.webkit.org/show_bug.cgi?id=78783
 696         <rdar://problem/10610578>
 697
 698         Reviewed by Anders Carlsson.
 699
 700         * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
 701         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
 702         (-[UIDelegate timerFired]):
 703
 704 2012-02-21  Kentaro Hara  <haraken@chromium.org>
 705
 706         Enable the IDL attribute checker in run-bindings-tests
 707         https://bugs.webkit.org/show_bug.cgi?id=79091
 708
 709         Reviewed by Adam Barth.
 710
 711         We have enabled the IDL attribute checker in Chromium in r108322.
 712         This patch enables the IDL attribute checker in run-bindings-tests.
 713
 714         No tests. I manually checked that [Custommm], [CallWith=],
 715         [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
 716         run-bindings-tests failures.
 717
 718         * Scripts/webkitpy/bindings/main.py:
 719         (BindingsTests.generate_supplemental_dependency):
 720
 721 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
 722
 723         Add rafaelw as a committer.
 724
 725         Unreviewed.
 726
 727         * Scripts/webkitpy/common/config/committers.py:
 728
 729 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
 730
 731         webkitpy: update names after deleting message_broker
 732         https://bugs.webkit.org/show_bug.cgi?id=79000
 733
 734         Reviewed by Eric Seidel.
 735
 736         Part 3 of 3 in deleting message_broker.py; this change just
 737         adjusts the names for the newly merged symbols so that they are
 738         private as appropriate.
 739
 740         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
 741         (get):
 742         (_Broker):
 743         (_BrokerConnection):
 744         (_BrokerConnection.__init__):
 745         (AbstractWorker.__init__):
 746         (_ManagerConnection):
 747         (_ManagerConnection.__init__):
 748         (_WorkerConnection):
 749         (_WorkerConnection.__init__):
 750
 751 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
 752
 753         webkitpy: merge message_broker.py into manager_worker_broker.py
 754         https://bugs.webkit.org/show_bug.cgi?id=78999
 755
 756         Reviewed by Tony Chang.
 757
 758         This is pretty much a straight cut-and-paste of one file into
 759         another (broken up so that docstrings and imports are in the
 760         right place).
 761
 762         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
 763         (BrokerClient):
 764         (BrokerClient.is_done):
 765         (BrokerClient.name):
 766         (Broker):
 767         (Broker.__init__):
 768         (Broker.add_topic):
 769         (Broker._get_queue_for_topic):
 770         (Broker.post_message):
 771         (Broker.run_message_loop):
 772         (Broker.run_all_pending):
 773         (Broker._run_loop):
 774         (Broker._dispatch_message):
 775         (_Message):
 776         (_Message.loads):
 777         (_Message.__init__):
 778         (_Message.dumps):
 779         (_Message.__repr__):
 780         (BrokerConnection):
 781         (BrokerConnection.__init__):
 782         (BrokerConnection.run_message_loop):
 783         (BrokerConnection.post_message):
 784         (BrokerConnection.raise_exception):
 785         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
 786
 787 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
 788
 789         webkitpy: prepare to delete message_broker.py
 790         https://bugs.webkit.org/show_bug.cgi?id=78997
 791
 792         Reviewed by Eric Seidel.
 793
 794         This is part 1 of 3 changes to fix bug 78187. This change
 795         prepares the code for merging message_broker.py into
 796         manager_worker_broker.py; the tests in message_broker_unittest
 797         are merged into manager_worker_broker_unittest, the symbols
 798         needed by the tests are exported from manager_worker_broker.py,
 799         and manager_worker_broker itself is updated to refer to the
 800         symbols directly (without the module prefix).
 801
 802         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
 803         (get):
 804         (AbstractWorker):
 805         (AbstractWorker.__init__):
 806         (_ManagerConnection):
 807         (_ManagerConnection.__init__):
 808         (_WorkerConnection):
 809         (_WorkerConnection.__init__):
 810         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
 811         (InterfaceTest.test_brokerclient_is_abstract):
 812         (InterfaceTest.test_brokerclient_is_abstract.methods):
 813         (MessageTest):
 814         (MessageTest.test__no_body):
 815         (MessageTest.test__body):
 816         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
 817
 818 2012-02-21  Sam Weinig  <sam@webkit.org>
 819
 820         Attempt to fix the Snow Leopard build.
 821
 822         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 823         * MiniBrowser/Configurations/Base.xcconfig:
 824         * TestWebKitAPI/Configurations/Base.xcconfig:
 825         * WebKitTestRunner/Configurations/Base.xcconfig:
 826
 827 2012-02-21  Sam Weinig  <sam@webkit.org>
 828
 829         Use libc++ when building with Clang on Mac
 830         https://bugs.webkit.org/show_bug.cgi?id=78981
 831
 832         Reviewed by Dan Bernstein.
 833
 834         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 835         * MiniBrowser/Configurations/Base.xcconfig:
 836         * TestWebKitAPI/Configurations/Base.xcconfig:
 837         * WebKitTestRunner/Configurations/Base.xcconfig:
 838
 839 2012-02-21  Adam Roben  <aroben@apple.com>
 840
 841         Roll out r108309, r108323, and r108326
 842
 843         They broke the 32-bit Lion build.
 844
 845         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
 846
 847         * DumpRenderTree/efl/CMakeLists.txt:
 848
 849 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
 850
 851         [Qt][WK2] Get rid of the dependency to QtWidgets
 852         https://bugs.webkit.org/show_bug.cgi?id=76276
 853
 854         Reviewed by Simon Hausmann.
 855
 856         * MiniBrowser/qt/MiniBrowser.pro:
 857         * MiniBrowser/qt/MiniBrowserApplication.cpp:
 858         (MiniBrowserApplication::MiniBrowserApplication):
 859         (MiniBrowserApplication::notify):
 860         (MiniBrowserApplication::sendTouchEvent):
 861         * MiniBrowser/qt/MiniBrowserApplication.h:
 862         (MiniBrowserApplication):
 863         * QtTestBrowser/locationedit.h:
 864         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
 865         (WTR::activateFonts):
 866         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
 867
 868 2012-02-20  Adam Barth  <abarth@webkit.org>
 869
 870         mastercfg_unittest.py fails without simplejson
 871         https://bugs.webkit.org/show_bug.cgi?id=79070
 872
 873         Reviewed by Csaba Osztrogonác.
 874
 875         Now that we require Python 2.6 (and higher) we can import json rather
 876         than simplejson.  We still need to use the simplejson name because
 877         that's what the master.cfg script expects.
 878
 879         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 880         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
 881
 882 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
 883
 884         JSC should be a triple-tier VM
 885         https://bugs.webkit.org/show_bug.cgi?id=75812
 886         <rdar://problem/10079694>
 887
 888         Reviewed by Gavin Barraclough.
 889
 890         Changed EFL's build system to include a new directory in JavaScriptCore.
 891
 892         * DumpRenderTree/efl/CMakeLists.txt:
 893
 894 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
 895
 896         Update pywebsocket to 0.7.2
 897         https://bugs.webkit.org/show_bug.cgi?id=79066
 898
 899         This version includes vendor-prefixed deflate-frame extension support.
 900
 901         Reviewed by Kent Tamura.
 902
 903         * Scripts/webkitpy/thirdparty/__init__.py:
 904         (AutoinstallImportHook._install_pywebsocket):
 905
 906 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
 907
 908         [UNIX] Plugin information fields are not interpreted as UTF-8
 909         https://bugs.webkit.org/show_bug.cgi?id=78635
 910
 911         Reviewed by Gustavo Noronha Silva.
 912
 913         Interpret plugin metadata as UTF8 aways. This matches the behavior
 914         of Chromium and the Totem plugin.
 915
 916         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
 917         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
 918
 919 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
 920
 921         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
 922         https://bugs.webkit.org/show_bug.cgi?id=78935
 923
 924         Reviewed by Gustavo Noronha Silva.
 925
 926         Move the TestNetscapePlugin headers to a more appropriate directory and update
 927         the build files to match.
 928
 929         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
 930         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
 931         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
 932         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
 933         * GNUmakefile.am: Ditto.
 934
 935 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
 936
 937         Add a new API for the Vibration API(W3C).
 938         https://bugs.webkit.org/show_bug.cgi?id=72010
 939
 940         Reviewed by Hajime Morita.
 941
 942         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
 943
 944 2012-02-20  János Badics  <dicska@gmail.com>
 945
 946         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
 947         https://bugs.webkit.org/show_bug.cgi?id=71816
 948
 949         RunQtAPITests will notify if a timeout occurs during testing.
 950         Added unittest to the master.cfg
 951
 952         Reviewed by Csaba Osztrogonác.
 953
 954         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 955         (RunQtAPITests.evaluateCommand):
 956         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 957         (RunQtAPITestsTest):
 958         (RunQtAPITestsTest.assertResults):
 959         (RunQtAPITestsTest.test_timeout):
 960         (test_success):
 961         (test_failure):
 962         (test_timeout_and_failure):
 963
 964 2012-02-20  Andy Wingo  <wingo@igalia.com>
 965
 966         Add wingo as a committer.
 967
 968         Unreviewed.
 969
 970         * Scripts/webkitpy/common/config/committers.py: Add myself to the
 971         committers list.
 972
 973 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
 974
 975         [chromium] check that we're not running multiple modal dialogs at the same time
 976         https://bugs.webkit.org/show_bug.cgi?id=78486
 977
 978         Reviewed by Kent Tamura.
 979
 980         * DumpRenderTree/chromium/TestShell.cpp:
 981         (TestShell::TestShell):
 982         * DumpRenderTree/chromium/TestShell.h:
 983         (TestShell::setIsDisplayingModalDialog):
 984         (TestShell::isDisplayingModalDialog):
 985         (TestShell):
 986         * DumpRenderTree/chromium/WebViewHost.cpp:
 987         (WebViewHost::runModal):
 988
 989 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
 990
 991         Fix WebKit2GTK+ for 'make distcheck'.
 992
 993         Instead of conditionally including WebKit2 GNUmakefiles, always
 994         include them and conditionally activate the final targets.
 995
 996         * MiniBrowser/gtk/GNUmakefile.am:
 997         * WebKitTestRunner/GNUmakefile.am:
 998
 999 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1000
1001         Enable video option for EFL port in build-webkit.
1002         https://bugs.webkit.org/show_bug.cgi?id=79006
1003
1004         Reviewed by Daniel Bates.
1005
1006         * Scripts/build-webkit:
1007
1008 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
1009
1010         [EFL] Use modifier keys to execute pre-rendering.
1011         https://bugs.webkit.org/show_bug.cgi?id=77933
1012
1013         Reviewed by Chang Shu.
1014
1015         Use modifier key to execute pre-rendering instead of using reserved function keys.
1016
1017         * EWebLauncher/main.c:
1018         (on_key_down):
1019
1020 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
1021
1022         Fix one more dangling reference to worker_connection.name, delete unused code.
1023
1024         Unreviewed, build fix.
1025
1026         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1027         (Manager.update):
1028         (_WorkerState.__init__):
1029
1030 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
1031
1032         Add a change that should've been in r108005.
1033
1034         Unreviewed, build fix.
1035
1036         In the refactoring/cleanup in r108005 I should've changed the
1037         implementation of WorkerConnection to make it match BrokerClient
1038         (and everything else) so that objects had a name() method
1039         instead of a name property.
1040
1041         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1042         (Manager._run_tests):
1043         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1044         (_WorkerConnection.__init__):
1045         (_WorkerConnection.name):
1046         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1047         (_TestWorker.__init__):
1048         (_TestsMixin.name):
1049         (_TestsMixin.test_name):
1050         (_TestsMixin.test_cancel):
1051         (_TestsMixin.test_unknown_message):
1052
1053 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
1054
1055         webkitpy: remove webkitpy.common.array_stream
1056         https://bugs.webkit.org/show_bug.cgi?id=78952
1057
1058         Reviewed by Eric Seidel.
1059
1060         Turns out array_stream didn't really do anything that StringIO
1061         didn't do (at least as of Python 2.6). This change removes it
1062         and updates all of the callers. Where possible, I changed the
1063         test assertions in order to capture the intent more clearly,
1064         e.g., instead of calling self.assertTrue('foo' in stream.get()),
1065         we have self.assertContainsLine(stream, 'foo'), and instead of
1066         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
1067         the latter isn't that much more readable, but StringIO doesn't
1068         export an empty() method.
1069
1070         * Scripts/webkitpy/common/array_stream.py: Removed.
1071         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
1072         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1073         (passing_run):
1074         (run_and_capture):
1075         (StreamTestingMixin):
1076         (StreamTestingMixin.assertContains):
1077         (StreamTestingMixin.assertContainsLine):
1078         (StreamTestingMixin.assertEmpty):
1079         (StreamTestingMixin.assertNotEmpty):
1080         (LintTest):
1081         (LintTest.test_lint_test_files):
1082         (LintTest.test_lint_test_files__errors):
1083         (MainTest):
1084         (MainTest.test_child_process_1):
1085         (MainTest.test_child_processes_2):
1086         (MainTest.test_child_processes_min):
1087         (MainTest.test_help_printing):
1088         (MainTest.test_hung_thread):
1089         (MainTest.test_no_tests_found):
1090         (MainTest.test_no_tests_found_2):
1091         (MainTest.test_repeat_each_iterations_num_tests):
1092         (MainTest.test_test_list):
1093         (MainTest.test_unexpected_failures):
1094         (MainTest.test_worker_model__inline_with_child_processes):
1095         (MainTest.test_additional_platform_directory):
1096         (RebaselineTest):
1097         (RebaselineTest.assertBaselines):
1098         (RebaselineTest.test_reset_results):
1099         (RebaselineTest.test_missing_results):
1100         (RebaselineTest.test_new_baseline):
1101         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1102         (MeteredStream.update):
1103         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1104         (TestMeteredStream.test_regular):
1105         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1106         (TestUtilityFunctions.assertEmpty):
1107         (TestUtilityFunctions):
1108         (TestUtilityFunctions.assertNotEmpty):
1109         (TestUtilityFunctions.assertWritten):
1110         (TestUtilityFunctions.test_configure_logging):
1111         (Testprinter.assertEmpty):
1112         (Testprinter):
1113         (Testprinter.assertNotEmpty):
1114         (Testprinter.assertWritten):
1115         (Testprinter.reset):
1116         (Testprinter.get_printer):
1117         (Testprinter.test_help_printer):
1118         (Testprinter.do_switch_tests.do_helper):
1119         (Testprinter.test_print_one_line_summary):
1120         (Testprinter.test_print_test_result):
1121         (Testprinter.test_print_progress):
1122         (Testprinter.test_write_nothing):
1123         (Testprinter.test_write_misc):
1124         (Testprinter.test_write_everything):
1125         (Testprinter.test_write_verbose):
1126         (Testprinter.test_print_unexpected_results):
1127         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1128         (MainTest.assertWritten):
1129         (create_runner):
1130         (test_run_test_set):
1131         (test_run_test_set_kills_drt_per_run):
1132         (test_run_test_set_for_parser_tests):
1133         (test_run_test_set_with_json_output):
1134         (test_run_test_set_with_json_source):
1135         (test_run_test_set_with_multiple_repositories):
1136         (test_upload_json):
1137
1138 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
1139
1140         [wx] Add the WebCore/page/scrolling directory to the build dirs.
1141
1142         * waf/build/settings.py:
1143
1144 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
1145
1146         [wx] Unreviewed build fix. Don't error out or hang if we have
1147         downloaded dependencies but server update check fails.
1148
1149         * waf/build/build_utils.py:
1150         (download_if_newer):
1151
1152 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1153
1154         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
1155         https://bugs.webkit.org/show_bug.cgi?id=69444
1156
1157         Reviewed by Tony Chang.
1158
1159         Currently if a test's image checksum doesn't match the checksum
1160         in the baseline, but the images themselves match according to
1161         ImageDiff, new-run-webkit-tests ignores the problem. This is
1162         probably bad, but it's not yet clear what the right thing to do
1163         is. This patch will log a warning to stderr, at least (but the
1164         test will still pass).
1165
1166         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1167         (SingleTestRunner._compare_image):
1168         (SingleTestRunner._run_reftest):
1169         * Scripts/webkitpy/layout_tests/port/test.py:
1170         (unit_test_list):
1171         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1172
1173 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1174
1175         NRWT does not report failure for a skipped test
1176         https://bugs.webkit.org/show_bug.cgi?id=78750
1177
1178         Reviewed by Eric Seidel.
1179
1180         If a test is listed in a Skipped file and you run it anyway
1181         with --force, and the test fails, currently NRWT will print
1182         "test ran as expected"; this is confusing, because you probably
1183         expect the test to fail and yet this might lead you to think the
1184         test passed. This patch changes the expected behavior to "PASS",
1185         so tests that fail will be reported.
1186
1187         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1188         (result_was_expected):
1189         (TestExpectationParser):
1190         (TestExpectationParser.expectation_for_skipped_test):
1191         (TestExpectations):
1192         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1193         (test_add_skipped_tests):
1194         * Scripts/webkitpy/layout_tests/port/test.py:
1195         (unit_test_list): Add some tests that are expected to be in a Skipped file.
1196         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
1197
1198 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1199
1200         webkitpy: fix test code after bug 78181
1201         https://bugs.webkit.org/show_bug.cgi?id=78870
1202
1203         Reviewed by Adam Barth.
1204
1205         I forgot to update the test code as per Tony's suggestion in
1206         bug 78181 (r108005). This change does that, and in doing so
1207         it revealed a subtle bug in _InlineWorkerConnection.run() that
1208         I am fixing as part of this (_alive would not be cleared if an
1209         exception was thrown).
1210
1211         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1212         (_InlineWorkerConnection.run):
1213         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1214         (_TestWorker.__init__):
1215         (_TestWorker.handle_stop):
1216         (_TestWorker.handle_test):
1217         (_TestWorker.run):
1218         (_TestsMixin.handle_exception):
1219         (_TestsMixin.test_unknown_message):
1220
1221 2012-02-17  Adam Roben  <aroben@apple.com>
1222
1223         Mac build fix after r108119
1224
1225         * DumpRenderTree/mac/DumpRenderTree.mm:
1226         (runThread):
1227         (runPthread):
1228         (testThreadIdentifierMap):
1229         Updated to match current WTF threading APIs.
1230
1231 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1232
1233         revert r107147 - breaks webkit-patch on Mac SL
1234         https://bugs.webkit.org/show_bug.cgi?id=78866
1235
1236         Reviewed by Adam Barth.
1237
1238         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
1239         which is the version that ships on Mac SL. Reverting this
1240         change until we no longer have to worry about that version.
1241
1242         * Scripts/webkitpy/common/system/autoinstall.py:
1243         (AutoInstaller):
1244         (AutoInstaller._extract_all): Added a comment about SL.
1245         (AutoInstaller._unzip):
1246
1247 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
1248
1249         CSS regions enabled by default
1250         https://bugs.webkit.org/show_bug.cgi?id=78525
1251
1252         Reviewed by David Hyatt.
1253
1254         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
1255         CSSRegions are still enabled by default.
1256         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
1257
1258         * DumpRenderTree/chromium/LayoutTestController.cpp:
1259         (LayoutTestController::overridePreference):
1260         * DumpRenderTree/chromium/WebPreferences.cpp:
1261         (WebPreferences::reset):
1262         (WebPreferences::applyTo):
1263         * DumpRenderTree/chromium/WebPreferences.h:
1264         (WebPreferences):
1265         * DumpRenderTree/mac/DumpRenderTree.mm:
1266         (resetDefaultsToConsistentValues):
1267
1268 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
1269
1270         Some API tests erroneously use = instead of == (causing build failures)
1271         https://bugs.webkit.org/show_bug.cgi?id=78915
1272
1273         Reviewed by Sam Weinig.
1274
1275         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1276         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
1277         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
1278
1279 2012-02-17  Peter Beverloo  <peter@chromium.org>
1280
1281         [Chromium] Include TestShellLinux.cpp in the build for Android
1282         https://bugs.webkit.org/show_bug.cgi?id=78865
1283
1284         Reviewed by Eric Seidel.
1285
1286         Android will be re-using the TestShellLinux.cpp file. I already
1287         added this r104033, but it seems to have gotten lost in the
1288         recent refactorings.
1289
1290         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1291
1292 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1293
1294         Unreviewed, disable video build on EFL until it can be
1295         supported by EFL build bot.
1296
1297         * Scripts/build-webkit:
1298
1299 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1300
1301         [GTK] Implement zoom in/out in MiniBrowser
1302         https://bugs.webkit.org/show_bug.cgi?id=75253
1303
1304         Reviewed by Gustavo Noronha Silva.
1305
1306         * MiniBrowser/gtk/BrowserWindow.c:
1307         (browserWindowCanZoomIn):
1308         (browserWindowCanZoomOut):
1309         (browserWindowUpdateZoomActions):
1310         (webViewZoomLevelChanged):
1311         (zoomInCallback):
1312         (zoomOutCallback):
1313         (browser_window_init):
1314         (browserWindowConstructed):
1315
1316 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
1317
1318         layoutTestController.display() is flaky for SVG tests
1319         https://bugs.webkit.org/show_bug.cgi?id=78021
1320
1321         Reviewed by Adam Roben.
1322
1323         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
1324         Size the web view before running the test, not when dumping.
1325         All platforms handle this correctly now.
1326
1327         * DumpRenderTree/win/DumpRenderTree.cpp:
1328         (dump):
1329         (sizeWebViewForCurrentTest):
1330         (runTest):
1331
1332 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1333
1334         [GTK] Make install is broken when building without --enable-gtk-doc
1335         https://bugs.webkit.org/show_bug.cgi?id=78828
1336
1337         Reviewed by Martin Robinson.
1338
1339         * gtk/generate-gtkdoc:
1340         (rebase_installed_docs): Check documentation has been generated
1341         before trying to rebase it.
1342
1343 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
1344
1345         nrwt: simplify worker interface
1346         https://bugs.webkit.org/show_bug.cgi?id=78181
1347
1348         Reviewed by Tony Chang.
1349
1350         This change moves code in name(), is_done(), run(), and cancel()
1351         from Worker to AbstractWorker, since the logic is pretty much
1352         boilerplate code that any implementation would want to use.
1353
1354         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1355         (get.should):
1356         (AbstractWorker.__init__):
1357         (AbstractWorker):
1358         (AbstractWorker.name):
1359         (AbstractWorker.stop_handling_messages):
1360         (AbstractWorker.run):
1361         (AbstractWorker.is_done):
1362         (AbstractWorker.cancel):
1363         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1364         (Worker.__init__):
1365         (Worker.run):
1366         (Worker.handle_stop):
1367
1368 2012-02-16  Michael Saboff  <msaboff@apple.com>
1369
1370         ENH: Add ability to run subset of JavaScript layout tests with JSC
1371         https://bugs.webkit.org/show_bug.cgi?id=78764
1372
1373         Reviewed by Gavin Barraclough.
1374
1375         New simple test drive shell script that runs a defined
1376         list of javascript tests using jsc and the standalone-{pre,post}.js
1377         wrappers.
1378
1379         * Scripts/run-fast-jsc: Added.
1380
1381 2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>
1382
1383         Add new Qt performance tester bot to build.webkit.org
1384         https://bugs.webkit.org/show_bug.cgi?id=78795
1385
1386         Reviewed by Adam Roben.
1387
1388         * BuildSlaveSupport/build.webkit.org-config/config.json:
1389
1390 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
1391
1392         Disable inspector on WinCE.
1393
1394         Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
1395
1396         * Scripts/build-webkit:
1397
1398 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
1399
1400         WinCE build fix after r107656.
1401
1402         Disable FTPDIR on WinCE, since it does not compile there.
1403
1404         * Scripts/build-webkit:
1405
1406 2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>
1407
1408         Build fix after r107863.
1409
1410         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1411
1412 2012-02-15  Tony Chang  <tony@chromium.org>
1413
1414         [chromium] add linux dbg back to garden-o-matic
1415         https://bugs.webkit.org/show_bug.cgi?id=78752
1416
1417         Reviewed by Adam Barth.
1418
1419         This reflects the current linux debug bot name (there's only one bot).
1420         I'm also remove the mac clang builder since it doesn't exist (mac
1421         always uses clang now).
1422
1423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1424         * Scripts/webkitpy/layout_tests/port/builders.py:
1425
1426 2012-02-15  Sam Weinig  <sam@webkit.org>
1427
1428         Add style check for ctype functions that are generally frowned upon in WebKit
1429         https://bugs.webkit.org/show_bug.cgi?id=78748
1430
1431         Reviewed by Anders Carlsson.
1432
1433         Not every platform has DisallowCType.h to check for uses of the ctype.h
1434         functions, so add a style check for them as well.
1435
1436         * Scripts/webkitpy/style/checkers/cpp.py:
1437         (check_ctype_functions):
1438         (check_style):
1439         (CppChecker):
1440         Add check.
1441
1442         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1443         (WebKitStyleTest.test_ctype_fucntion):
1444         Add checker.
1445
1446 2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>
1447
1448         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
1449         https://bugs.webkit.org/show_bug.cgi?id=76546
1450
1451         Reviewed by Simon Hausmann.
1452
1453         Resize the web view programatically because the declarative property binding
1454         does not work. Seems like our qml environment is not initialized fully but it
1455         needs more investigation.
1456
1457         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1458         (WTR::WrapperWindow::handleStatusChanged):
1459         (WTR::PlatformWebView::resizeTo):
1460
1461 2012-02-15  Dirk Pranke  <dpranke@chromium.org>
1462
1463         webkitpy: add a worker_args concept to start_worker()
1464         https://bugs.webkit.org/show_bug.cgi?id=78572
1465
1466         Reviewed by Tony Chang.
1467
1468         This change replaces the three NRWT-specific arguments passed
1469         through the broker to the worker with a generic WorkerArguments
1470         wrapper class and a separate set_inline_arguments() call that can
1471         be used to pass additional data to the worker when it is running
1472         in the same process as the manager (this is needed for testing).
1473         With the addition of set_inline_arguments() we also no longer
1474         need to pass an optional argument to the worker.run() call.
1475
1476         Note that this method is *only* implemented on inline workers,
1477         so calling this on a regular (child process) worker will result
1478         in a runtime error.
1479
1480         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1481         (Manager._run_tests):
1482         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1483         (AbstractWorker.__init__):
1484         (AbstractWorker.run):
1485         (_ManagerConnection.start_worker):
1486         (_InlineManager.start_worker):
1487         (_InlineManager.set_inline_arguments):
1488         (_InlineManager.run_message_loop):
1489         (_MultiProcessManager.start_worker): Reworked signature.
1490         (_WorkerConnection.__init__):
1491         (_InlineWorkerConnection.__init__):
1492         (_InlineWorkerConnection.set_inline_arguments): New method.
1493         (_InlineWorkerConnection):
1494         (_InlineWorkerConnection.run):
1495         (_Process.run):
1496         (_MultiProcessWorkerConnection.__init__):
1497         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1498         (_TestWorker.__init__):
1499         (_TestWorker.set_inline_arguments):
1500         (_TestWorker.handle_test):
1501         (_TestWorker.run):
1502         (_TestsMixin.test_cancel):
1503         (_TestsMixin.test_done):
1504         (_TestsMixin.test_unknown_message):
1505         (InlineBrokerTests): New class for more testing.
1506         (InlineBrokerTests.setUp):
1507         (InlineBrokerTests.test_inline_arguments): New test.
1508         (InterfaceTest.test_managerconnection_is_abstract):
1509         (InterfaceTest.test_workerconnection_is_abstract):
1510         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1511         (WorkerArguments):
1512         (WorkerArguments.__init__):
1513         (Worker.__init__):
1514         (Worker.set_inline_arguments):
1515         (Worker):
1516         (Worker.run):
1517         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
1518         (WorkerTest.test_default_platform_in_worker):
1519
1520 2012-02-15  Adam Klein  <adamk@chromium.org>
1521
1522         Unreviewed, rolling out r107704.
1523         http://trac.webkit.org/changeset/107704
1524         https://bugs.webkit.org/show_bug.cgi?id=78486
1525
1526         Caused layout test crashes in debug builds.
1527
1528         Specific crashing tests:
1529
1530         fast/events/show-modal-dialog-onblur-onfocus.html
1531         fast/harness/show-modal-dialog.html
1532         inspector/console/console-long-eval-crash.html
1533
1534         * DumpRenderTree/chromium/TestShell.cpp:
1535         (TestShell::TestShell):
1536         * DumpRenderTree/chromium/TestShell.h:
1537         (TestShell):
1538         * DumpRenderTree/chromium/WebViewHost.cpp:
1539         (WebViewHost::runModal):
1540
1541 2012-02-15  Michael Brüning  <michael.bruning@nokia.com>
1542
1543         [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
1544         https://bugs.webkit.org/show_bug.cgi?id=76347
1545
1546         Reviewed by Kenneth Rohde Christiansen.
1547
1548         * MiniBrowser/qt/MiniBrowser.qrc:
1549         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added.
1550         * MiniBrowser/qt/qml/BrowserWindow.qml:
1551         * MiniBrowser/qt/qml/DialogLineInput.qml:
1552
1553 2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>
1554
1555         [Qt] Fix WebGL in QtTestBrowser
1556
1557         Reviewed by Tor Arne Vestbø.
1558
1559         * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
1560         the options for enabling GL we also pass them on properly.
1561
1562 2012-02-14  Sam Weinig  <sam@webkit.org>
1563
1564         Add #include of unistd.h on the mac for getcwd.
1565
1566         Reviewed by Anders Carlsson.
1567
1568         This is necessary when building with libc++.
1569
1570         * WebKitTestRunner/TestInvocation.cpp:
1571
1572 2012-02-14  Sam Weinig  <sam@webkit.org>
1573
1574         In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
1575         https://bugs.webkit.org/show_bug.cgi?id=78663
1576
1577         Reviewed by Anders Carlsson.
1578
1579         * DumpRenderTree/DumpRenderTreePrefix.h:
1580         * DumpRenderTree/cg/ImageDiffCG.cpp:
1581
1582 2012-02-14  Adam Barth  <abarth@webkit.org>
1583
1584         Implement an adb-based driver for the ChromiumAndroidPort
1585         https://bugs.webkit.org/show_bug.cgi?id=78627
1586
1587         Reviewed by Eric Seidel.
1588
1589         This driver mostly just wires up the ChromiumDriver through adb.  In
1590         some cases, it translates protocol elements, such as URIs, so that the
1591         rest of webkitpy is insulated from the "remoteness" of the target device.
1592
1593         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1594         (ChromiumAndroidPort.start_helper):
1595         (ChromiumAndroidPort._driver_class):
1596         (ChromiumAndroidPort._update_version):
1597         (ChromiumAndroidPort._get_stderr):
1598         (ChromiumAndroidPort):
1599         (ChromiumAndroidPort._get_last_stacktrace):
1600         (ChromiumAndroidPort._teardown_performance):
1601         (ChromiumAndroidDriver):
1602         (ChromiumAndroidDriver.__init__):
1603         (ChromiumAndroidDriver._start):
1604         (ChromiumAndroidDriver.run_test):
1605         (ChromiumAndroidDriver.stop):
1606         (ChromiumAndroidDriver._test_shell_command):
1607         (ChromiumAndroidDriver._write_command_and_read_line):
1608         (ChromiumAndroidDriver._output_image):
1609         (ChromiumAndroidDriver._has_crash_hint):
1610
1611 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1612
1613         webkitpy: the real_name() method in the Port class is no longer needed
1614         https://bugs.webkit.org/show_bug.cgi?id=78651
1615
1616         Reviewed by Eric Seidel.
1617
1618         The change in bug 78565 / r107718 made it no longer necessary
1619         (we can use options.platform instead).
1620
1621         * Scripts/webkitpy/layout_tests/port/base.py:
1622         (Port.name):
1623         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1624         (MockDRTPort.__init__):
1625
1626 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1627
1628         webkitpy: clean up options, port handling in manager_worker_broker
1629         https://bugs.webkit.org/show_bug.cgi?id=78568
1630
1631         Reviewed by Tony Chang.
1632
1633         manager_worker_broker no longer needs options or port objects
1634         directly, so we make them only be passed in start_worker().
1635
1636         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1637         (Manager._run_tests):
1638         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1639         (get):
1640         (_ManagerConnection.__init__):
1641         (_ManagerConnection.start_worker):
1642         (_InlineManager.__init__):
1643         (_InlineManager.start_worker):
1644         (_InlineManager.run_message_loop):
1645         (_MultiProcessManager.__init__):
1646         (_MultiProcessManager):
1647         (_MultiProcessManager.start_worker):
1648         (_InlineWorkerConnection.__init__):
1649         (_InlineWorkerConnection.run):
1650         (_Process.__init__):
1651         (_MultiProcessWorkerConnection.__init__):
1652         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1653         (make_broker):
1654         (_TestWorker.run):
1655         (_TestsMixin.test_cancel):
1656         (_TestsMixin.test_done):
1657         (_TestsMixin.test_unknown_message):
1658         (MultiProcessBrokerTests.setUp):
1659         (InterfaceTest.test_managerconnection_is_abstract):
1660         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
1661         (Broker.__init__):
1662
1663 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1664
1665         nrwt: add a unit test for regression introduced in bug 78565
1666         https://bugs.webkit.org/show_bug.cgi?id=78646
1667
1668         Reviewed by Tony Chang.
1669
1670         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
1671         (FakeConnection):
1672         (FakeConnection.run_message_loop):
1673         (FakeConnection.post_message):
1674         (WorkerTest):
1675         (WorkerTest.test_default_platform_in_worker):
1676
1677 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1678
1679         NRWT is broken for the default port
1680         https://bugs.webkit.org/show_bug.cgi?id=78640
1681
1682         Reviewed by Tony Chang.
1683
1684         The change in r107718 (bug 78565) broke NRWT if you didn't
1685         specify any sort of --platform flag or equivalent. I didn't
1686         catch this because it's a full integration test (which we don't
1687         have an automated test for) and I missed this command line
1688         variant when testing interactively.
1689
1690         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1691         (Worker.run):
1692
1693 2012-02-14  Ramya Chandrasekaran  <cramya@google.com>
1694
1695         Last character display for passwords in Android.
1696         https://bugs.webkit.org/show_bug.cgi?id=78532
1697
1698         Reviewed by Adam Barth.
1699
1700         * DumpRenderTree/chromium/WebPreferences.cpp:
1701         (WebPreferences::applyTo):
1702
1703 2012-02-14  Adam Barth  <abarth@webkit.org>
1704
1705         Finish implementing start_helper for ChromiumAndroidPort
1706         https://bugs.webkit.org/show_bug.cgi?id=78582
1707
1708         Reviewed by Eric Seidel.
1709
1710         This patch contains the remaining odds and ends for the start_helper function.
1711
1712         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1713         (ChromiumAndroidPort.start_helper):
1714         (ChromiumAndroidPort._synchronize_datetime):
1715         (ChromiumAndroidPort):
1716         (ChromiumAndroidPort._check_version):
1717         (ChromiumAndroidPort._run_adb_command):
1718         (ChromiumAndroidPort._copy_device_file):
1719
1720 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1721
1722         webkitpy: create ports in Workers, not in manager_worker_broker
1723         https://bugs.webkit.org/show_bug.cgi?id=78565
1724
1725         Reviewed by Tony Chang.
1726
1727         We will now create the Port object (if necessary) in the Worker
1728         directly, so that the manager_worker_broker module doesn't need
1729         all of this layout_test-specific logic. Part of the fixes for
1730         bug 78171.
1731
1732         These changes are all well-tested by the existing tests in
1733         run_webkit_tests_integrationtest.py.
1734
1735         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1736         (_Process.run):
1737         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1738         (Worker.__init__):
1739         (Worker.safe_init):
1740         (Worker.run):
1741         (Worker.cleanup):
1742         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1743         (parse_args):
1744         (main): Fix a minor bug where running the 'mock-test' port didn't work right.
1745
1746 2012-02-14  Jochen Eisinger  <jochen@chromium.org>
1747
1748         [chromium] check that we're not running multiple modal dialogs at the same time
1749         https://bugs.webkit.org/show_bug.cgi?id=78486
1750
1751         Reviewed by Kent Tamura.
1752
1753         * DumpRenderTree/chromium/TestShell.cpp:
1754         (TestShell::TestShell):
1755         * DumpRenderTree/chromium/TestShell.h:
1756         (TestShell::setIsDisplayingModalDialog):
1757         (TestShell::isDisplayingModalDialog):
1758         (TestShell):
1759         * DumpRenderTree/chromium/WebViewHost.cpp:
1760         (WebViewHost::runModal):
1761
1762 2012-02-14  Adam Barth  <abarth@webkit.org>
1763
1764         Enable the GPU codepath in the chromium-android port
1765         https://bugs.webkit.org/show_bug.cgi?id=78580
1766
1767         Reviewed by James Robinson.
1768
1769         Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
1770         Android always uses the GPU codepath, so we set the GPU flags on the
1771         main chromium-android port instead.
1772
1773         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1774         (ChromiumAndroidPort.__init__):
1775
1776 2012-02-14  Adam Barth  <abarth@webkit.org>
1777
1778         NRWT should expose --adb-args flag for Android
1779         https://bugs.webkit.org/show_bug.cgi?id=78579
1780
1781         Reviewed by Eric Seidel.
1782
1783         This flag is already wired up to the ChromiumAndroidPort.
1784
1785         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1786         (parse_args):
1787
1788 2012-02-14  Alexey Proskuryakov  <ap@apple.com>
1789
1790         [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
1791         https://bugs.webkit.org/show_bug.cgi?id=78541
1792         <rdar://problem/10036695>
1793
1794         Reviewed by Kent Tamura.
1795
1796         * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
1797         * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
1798         After each test, reset to using new protocol.
1799
1800 2012-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
1801
1802         Convert svg/animations to use SMIL methods for driving the timeline
1803         https://bugs.webkit.org/show_bug.cgi?id=78422
1804
1805         Reviewed by Dirk Schulze.
1806
1807         Remove no longer needed SVG specific animation sampling functionality from DRT.
1808         Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
1809
1810         * DumpRenderTree/LayoutTestController.cpp:
1811         (LayoutTestController::staticFunctions):
1812         * DumpRenderTree/LayoutTestController.h:
1813         (LayoutTestController):
1814         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1815         * DumpRenderTree/chromium/LayoutTestController.cpp:
1816         (LayoutTestController::LayoutTestController):
1817         * DumpRenderTree/chromium/LayoutTestController.h:
1818         (LayoutTestController):
1819         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1820         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1821         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1822         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1823         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1824         (LayoutTestController):
1825         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1826         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1827
1828 2012-02-13  Rob Flack  <flackr@chromium.org>
1829
1830         Add Linux ChromiumOS test results to flakiness dashboard.
1831         https://bugs.webkit.org/show_bug.cgi?id=78495
1832
1833         Reviewed by Ojan Vafai.
1834
1835         * TestResultServer/static-dashboards/builders.js:
1836         * TestResultServer/static-dashboards/dashboard_base.js:
1837
1838 2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
1839
1840         [GTK] Mutation Observers build is broken
1841         https://bugs.webkit.org/show_bug.cgi?id=78433
1842
1843         Reviewed by Martin Robinson.
1844
1845         Enabled mutation observers as a default feature for GTK port, too.
1846
1847         * Scripts/build-webkit:
1848
1849 2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>
1850
1851         Allow to configure ENABLE_FTPDIR in build-webkit
1852         https://bugs.webkit.org/show_bug.cgi?id=65098
1853
1854         Reviewed by Eric Seidel.
1855
1856         Allow to disable ENABLE_FTPDIR by command line.
1857         Remove ENABLE_FTPDIR from --minimal build
1858
1859         * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
1860         * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
1861         as, for Qt platform, build-webkit does not add on command line what it thinks to be default values
1862
1863 2012-02-13  Shinya Kawanaka  <shinyak@chromium.org>
1864
1865         Add shinyak as committer.
1866
1867         Unreviewed.
1868
1869         * Scripts/webkitpy/common/config/committers.py:
1870
1871 2012-02-13  Adam Barth  <abarth@webkit.org>
1872
1873         Implement start/stop_helper for ChromiumAndroidPort
1874         https://bugs.webkit.org/show_bug.cgi?id=78558
1875
1876         Reviewed by Dirk Pranke.
1877
1878         These functions (and their dependencies) set up the Android device for
1879         testing.
1880
1881         This patch also includes a few tweaks on the previous patch recommended
1882         by dpranke.
1883
1884         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1885         (ChromiumAndroidPort.__init__):
1886         (ChromiumAndroidPort.start_helper):
1887         (ChromiumAndroidPort.stop_helper):
1888         (ChromiumAndroidPort._shut_down_http_server):
1889         (ChromiumAndroidPort):
1890         (ChromiumAndroidPort._push_executable):
1891         (ChromiumAndroidPort._push_fonts):
1892         (ChromiumAndroidPort._restore_system_font):
1893         (ChromiumAndroidPort._push_test_resources):
1894         (ChromiumAndroidPort._push_to_device):
1895         (ChromiumAndroidPort._pull_from_device):
1896         (ChromiumAndroidPort._kill_device_process):
1897         (ChromiumAndroidPort._setup_performance):
1898         (ChromiumAndroidPort._teardown_performance):
1899         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1900         (ChromiumAndroidPortTest):
1901         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1902         (PortTestCase):
1903         (PortTestCase.make_port):
1904         (PortTestCase.test_default_worker_model):
1905
1906 2012-02-13  Adam Barth  <abarth@webkit.org>
1907
1908         Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
1909         https://bugs.webkit.org/show_bug.cgi?id=78550
1910
1911         Reviewed by Eric Seidel.
1912
1913         Much of this code just forwards to the "host" port, which seems like a
1914         reasonable thing to do.
1915
1916         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1917         (ChromiumAndroidPort.__init__):
1918         (ChromiumAndroidPort.stop_helper):
1919         (ChromiumAndroidPort):
1920         (ChromiumAndroidPort._build_path):
1921         (ChromiumAndroidPort._path_to_apache):
1922         (ChromiumAndroidPort._path_to_apache_config_file):
1923         (ChromiumAndroidPort._path_to_driver):
1924         (ChromiumAndroidPort._path_to_helper):
1925         (ChromiumAndroidPort._path_to_image_diff):
1926         (ChromiumAndroidPort._path_to_lighttpd):
1927         (ChromiumAndroidPort._path_to_lighttpd_modules):
1928         (ChromiumAndroidPort._path_to_lighttpd_php):
1929         (ChromiumAndroidPort._path_to_wdiff):
1930         (ChromiumAndroidPort._shut_down_http_server):
1931         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1932         (ChromiumAndroidPortTest):
1933         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1934         (PortTestCase):
1935         (PortTestCase.make_port):
1936         (PortTestCase.test_default_worker_model):
1937
1938 2012-02-13  Adam Barth  <abarth@webkit.org>
1939
1940         chromium_android.py should implement "virtual" methods from ChromiumPort
1941         https://bugs.webkit.org/show_bug.cgi?id=78545
1942
1943         Reviewed by Dirk Pranke.
1944
1945         This patch adds basic implementations that specialize a bunch of
1946         functions from ChromiumPort.
1947
1948         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1949         (ChromiumAndroidPort):
1950         (ChromiumAndroidPort.__init__):
1951         (ChromiumAndroidPort.default_child_processes):
1952         (ChromiumAndroidPort.baseline_search_path):
1953         (ChromiumAndroidPort.check_build):
1954         (ChromiumAndroidPort.check_sys_deps):
1955         (ChromiumAndroidPort.default_worker_model):
1956         (ChromiumAndroidPort.test_expectations):
1957         (ChromiumAndroidPort.start_http_server):
1958         (ChromiumAndroidPort.stop_http_server):
1959         (ChromiumAndroidPort.start_helper):
1960         (ChromiumAndroidPort.stop_helper):
1961
1962 2012-02-13  Adam Barth  <abarth@webkit.org>
1963
1964         Add a skeleton ChromiumAndroid port to webkitpy
1965         https://bugs.webkit.org/show_bug.cgi?id=78543
1966
1967         Reviewed by Eric Seidel.
1968
1969         This patch just adds an empty ChromiumAndroid port object to webkitpy
1970         and wires it up to the factory objects.  An actual implementation will
1971         follow.
1972
1973         * Scripts/webkitpy/layout_tests/port/chromium.py:
1974         (ChromiumPort):
1975         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
1976         (ChromiumAndroidPort):
1977         (ChromiumAndroidPort.__init__):
1978         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1979         (ChromiumPortTest.test_all_test_configurations):
1980         * Scripts/webkitpy/layout_tests/port/factory.py:
1981         (PortFactory):
1982
1983 2012-02-13  Adam Barth  <abarth@webkit.org>
1984
1985         NRWT's HTTP servers should support additional directories for resources
1986         https://bugs.webkit.org/show_bug.cgi?id=78528
1987
1988         Reviewed by Eric Seidel.
1989
1990         This functionality will be used by the Chromium-Android port.
1991
1992         * Scripts/webkitpy/layout_tests/port/base.py:
1993         (Port.to.start_http_server):
1994         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1995         (LayoutTestApacheHttpd.__init__):
1996         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1997         (Lighttpd.__init__):
1998         (Lighttpd._prepare_config):
1999
2000 2012-02-13  Ami Fischman  <fischman@chromium.org>
2001
2002         Add fischman as committer.
2003
2004         Unreviewed
2005
2006         * Scripts/webkitpy/common/config/committers.py:
2007
2008 2012-02-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
2009
2010         [EFL] Drop support for the Curl network backend.
2011         https://bugs.webkit.org/show_bug.cgi?id=77874
2012
2013         Reviewed by Eric Seidel.
2014
2015         Nobody seems to be maintaining the Curl backend in WebCore, the
2016         EFL port developers all seem to be using the Soup backend and the
2017         port itself has many features which are only implemented for the
2018         latter.
2019
2020         * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
2021         and always add the required include directories.
2022         * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
2023         include directories and link to them.
2024
2025 2012-02-13  Kenichi Ishibashi  <bashi@chromium.org>
2026
2027         [WebSocket] Update pywebsocket to 0.7.1
2028         https://bugs.webkit.org/show_bug.cgi?id=78484
2029
2030         pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
2031
2032         Reviewed by Kent Tamura.
2033
2034         * Scripts/webkitpy/thirdparty/__init__.py:
2035         (AutoinstallImportHook._install_pywebsocket):
2036
2037 2012-02-12  Kangil Han  <kangil.han@samsung.com>
2038
2039         [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
2040         https://bugs.webkit.org/show_bug.cgi?id=78091
2041
2042         Reviewed by Hajime Morita.
2043
2044         Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
2045         This patch will activate around 1,900 test cases from skipped list in EFL port.
2046
2047         * DumpRenderTree/efl/EventSender.cpp:
2048         (textZoom):
2049         (pageZoom):
2050         (textZoomInCallback):
2051         (textZoomOutCallback):
2052         (zoomPageInCallback):
2053         (zoomPageOutCallback):
2054
2055 2012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
2056
2057         KeywordLookupGenerator.py script fails in some cases
2058         https://bugs.webkit.org/show_bug.cgi?id=77886
2059
2060         Reviewed by Benjamin Poulain.
2061
2062         * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
2063         * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
2064         (GlobalVariablesTest.test_path_rules_specifier):
2065
2066 2012-02-12  Joe Thomas  <joethomas@motorola.com>
2067
2068         Add toText and isTextNode helpers in Text class.
2069         https://bugs.webkit.org/show_bug.cgi?id=78140
2070
2071         Unit test case for the new style checker introduced.
2072
2073         Reviewed by Adam Barth.
2074
2075         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2076         (CppStyleTest):
2077         (CppStyleTest.test_static_cast_readability): Added a unit test case.
2078
2079 2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2080
2081         Enable features supported by EFL port in build-webkit.
2082         https://bugs.webkit.org/show_bug.cgi?id=78348
2083
2084         Reviewed by Ryosuke Niwa.
2085
2086         Sync build-webkit with OptionEfl.cmake, as some features enabled in
2087         OptionEfl.cmake are not enabled in build-webkit.
2088
2089         * Scripts/build-webkit:
2090
2091 2012-02-12  Joe Thomas  <joethomas@motorola.com>
2092
2093         Add toText and isTextNode helpers in Text class.
2094         https://bugs.webkit.org/show_bug.cgi?id=78140
2095
2096         Added a style checker to use toText rather than static_cast<Text*>.
2097
2098         Reviewed by Adam Barth.
2099
2100         * Scripts/webkitpy/style/checkers/cpp.py:
2101         (check_language): Style checker for static_cast<Text*>.
2102
2103 2012-02-12  Philippe Normand  <pnormand@igalia.com>
2104
2105         Unreviewed, disable Mutation observers build on GTK until it can
2106         actually build.
2107
2108         * Scripts/build-webkit:
2109
2110 2012-02-11  Benjamin Poulain  <benjamin@webkit.org>
2111
2112         Add back WTFURL to WebKit
2113         https://bugs.webkit.org/show_bug.cgi?id=77291
2114
2115         Reviewed by Adam Barth.
2116
2117         Add a flag to build-webkit to easily build WebKit with WTFURL.
2118
2119         * Scripts/build-webkit:
2120
2121 2012-02-10  Adam Klein  <adamk@chromium.org>
2122
2123         Enable MUTATION_OBSERVERS by default on all platforms
2124         https://bugs.webkit.org/show_bug.cgi?id=78196
2125
2126         Reviewed by Ojan Vafai.
2127
2128         * Scripts/build-webkit:
2129
2130 2012-02-10  Adam Barth  <abarth@webkit.org>
2131
2132         Move garden-o-matic's All Failures out of experimental
2133         https://bugs.webkit.org/show_bug.cgi?id=78395
2134
2135         Reviewed by Dimitri Glazkov.
2136
2137         Several folks have tried this feature and found it useful.
2138
2139         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2140
2141 2012-02-10  Tim Horton  <timothy_horton@apple.com>
2142
2143         NRWT should categorize options in --help
2144         https://bugs.webkit.org/show_bug.cgi?id=76221
2145
2146         Reviewed by Eric Seidel.
2147
2148         Use optparse's OptionGroup mechanism to logically group NRWT's options,
2149         providing a better experience when scanning all the options.
2150
2151         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2152         (parse_args):
2153
2154 2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2155
2156         [Qt][WK2] Refactor on Qt5 Layout tests' structure
2157         https://bugs.webkit.org/show_bug.cgi?id=77450
2158
2159         Reviewed by Csaba Osztrogonác.
2160
2161         Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
2162         to qt-5.0-wk2 and qt-5.0-wk1.
2163
2164         * Scripts/old-run-webkit-tests:
2165         (buildPlatformResultHierarchy):
2166         (readSkippedFiles):
2167         * Scripts/webkitpy/layout_tests/port/qt.py:
2168         (QtPort._wk2_port_name):
2169         (QtPort._skipped_file_search_paths):
2170         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2171         (QtPortTest.test_baseline_search_path):
2172         * Scripts/webkitpy/layout_tests/port/webkit.py:
2173         (WebKitPort._wk2_port_name):
2174
2175 2012-02-09  Philippe Normand  <pnormand@igalia.com>
2176
2177         [GTK] EWS command-line option to run the tests
2178         https://bugs.webkit.org/show_bug.cgi?id=78211
2179
2180         Reviewed by Adam Barth.
2181
2182         New --run-tests option (defaults to False) for the EWS commands.
2183
2184         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2185         (AbstractEarlyWarningSystem):
2186         (AbstractEarlyWarningSystem.__init__):
2187         (AbstractEarlyWarningSystem.review_patch):
2188         (ChromiumLinuxEWS):
2189         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2190         (EarlyWarningSytemTest._test_builder_ews):
2191
2192 2012-02-09  Eric Seidel  <eric@webkit.org>
2193
2194         Rename compare_text and compare_audio to make it clear that they're !=
2195         https://bugs.webkit.org/show_bug.cgi?id=78301
2196
2197         Reviewed by Adam Barth.
2198
2199         I also removed the maybe_create_directory function which was redundant.
2200
2201         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2202         (Manager.set_up_run):
2203         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2204         (TestResultWriter._make_output_directory):
2205         * Scripts/webkitpy/layout_tests/port/base.py:
2206         (Port.do_text_results_differ):
2207         (Port.do_audio_results_differ):
2208         (Port.diff_text):
2209         (Port.driver_name):
2210         (Port.skips_perf_test):
2211         * Scripts/webkitpy/layout_tests/port/win.py:
2212         (WinPort.do_text_results_differ):
2213         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2214         (WinPortTest.test_do_text_results_differ):
2215         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2216         (LayoutTestApacheHttpd.__init__):
2217         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2218         (HttpServerBase.__init__):
2219         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2220         (Rebaseliner._diff_baselines):
2221
2222 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
2223
2224         [GTK] Add DRT support for modal dialogs
2225         https://bugs.webkit.org/show_bug.cgi?id=53600
2226
2227         Reviewed by Martin Robinson.
2228
2229         Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
2230         Most significantly, when creating a new web view in GtkLauncher, the window
2231         of the web view opener is passed around. In DumpRenderTree, the window of
2232         the main web view is always considered as the opener. This is required so
2233         the modal dialog's toplevel can be made transient for the opener's toplevel.
2234
2235         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2236         (webViewRunModalDialog):
2237         (createWebView):
2238         * GtkLauncher/main.c:
2239         (createWebViewCb):
2240         (runModalDialogCb):
2241         (createBrowser):
2242         (createWindow):
2243         (main):
2244
2245 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
2246
2247         [Gtk] security/set-form-autocomplete-attribute.html fails
2248         https://bugs.webkit.org/show_bug.cgi?id=78261
2249
2250         Reviewed by Martin Robinson.
2251
2252         Use the new helper in DumpRenderTreeSupportGtk to properly
2253         test whether an element performs autocompletion.
2254
2255         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2256         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2257
2258 2012-02-09  James Robinson  <jamesr@chromium.org>
2259
2260         [chromium] Enable mock scrollbars for compositing layout tests
2261         https://bugs.webkit.org/show_bug.cgi?id=78299
2262
2263         Reviewed by Dirk Pranke.
2264
2265         This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
2266         compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
2267         more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
2268
2269         * DumpRenderTree/chromium/TestShell.cpp:
2270         (TestShell::runFileTest):
2271         * DumpRenderTree/chromium/WebPreferences.cpp:
2272         (WebPreferences::reset):
2273         (WebPreferences::applyTo):
2274         * DumpRenderTree/chromium/WebPreferences.h:
2275         (WebPreferences):
2276
2277 2012-02-09  Eric Seidel  <eric@webkit.org>
2278
2279         Remove more uses of "os" from our webkitpy code
2280         https://bugs.webkit.org/show_bug.cgi?id=78292
2281
2282         Reviewed by Adam Barth.
2283
2284         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2285         (MockCheckout.__init__):
2286         (MockCheckout.is_path_to_changelog):
2287         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2288         * Scripts/webkitpy/common/system/filesystem_mock.py:
2289         (MockFileSystem._split):
2290         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
2291         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2292         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2293         * Scripts/webkitpy/layout_tests/port/webkit.py:
2294         * Scripts/webkitpy/tool/bot/queueengine.py:
2295         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2296         * Scripts/webkitpy/tool/commands/download.py:
2297         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2298         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2299         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2300         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2301         * Scripts/webkitpy/tool/commands/upload.py:
2302         (CreateBug.prompt_for_bug_title_and_comment):
2303         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2304         * Scripts/webkitpy/tool/steps/attachtobug.py:
2305         (AttachToBug.run):
2306         * Scripts/webkitpy/tool/steps/checkstyle.py:
2307         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2308         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2309         * Scripts/webkitpy/tool/steps/editchangelog.py:
2310         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2311         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2312         (PrepareChangeLogTest.test_ensure_bug_url):
2313         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2314         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2315         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2316         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2317
2318 2012-02-09  Eric Seidel  <eric@webkit.org>
2319
2320         Remove the cr-mac-ews (it's long been dead)
2321         https://bugs.webkit.org/show_bug.cgi?id=78267
2322
2323         Reviewed by Adam Barth.
2324
2325         * QueueStatusServer/model/queues.py:
2326         (Queue):
2327         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2328         (ChromiumWindowsEWS):
2329         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2330         (EarlyWarningSytemTest._test_builder_ews):
2331         (EarlyWarningSytemTest._test_testing_ews):
2332
2333 2012-02-09  Dirk Pranke  <dpranke@chromium.org>
2334
2335         some tests in webkitpy are being run three times
2336         https://bugs.webkit.org/show_bug.cgi?id=78283
2337
2338         Reviewed by Ryosuke Niwa.
2339
2340         It turns out that if you import a class derived from
2341         unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
2342         the unittest framework treats it as if the class was defined in
2343         the file (as well in the original file). This led us to running
2344         the tests in ChangeLogTest three times.
2345
2346         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2347         (PrepareChangeLogTest):
2348         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2349         (_assert_message_for_revert_output):
2350
2351 2012-02-09  Adam Barth  <abarth@webkit.org>
2352
2353         Remove extraneous line in previous patch.  I forgot to remove this
2354         before landing.
2355
2356         * Scripts/webkitpy/layout_tests/port/driver.py:
2357         (DriverProxy.start):
2358
2359 2012-02-09  Adam Barth  <abarth@webkit.org>
2360
2361         run-perf-tests should have an option to pause before running tests so we can attach Instruments
2362         https://bugs.webkit.org/show_bug.cgi?id=78271
2363
2364         Reviewed by Ryosuke Niwa.
2365
2366         This lets me attach instruments to profile the performance of the test.
2367
2368         * Scripts/webkitpy/layout_tests/port/chromium.py:
2369         (ChromiumDriver.start):
2370         * Scripts/webkitpy/layout_tests/port/driver.py:
2371         (Driver.start):
2372         (DriverProxy.start):
2373         * Scripts/webkitpy/layout_tests/port/server_process.py:
2374         (ServerProcess.start):
2375         * Scripts/webkitpy/layout_tests/port/test.py:
2376         (TestDriver.start):
2377         * Scripts/webkitpy/layout_tests/port/webkit.py:
2378         (WebKitDriver.start):
2379         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2380         (get_tests_run.RecordingTestDriver.start):
2381         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2382         (PerfTestsRunner._parse_args):
2383         (PerfTestsRunner._run_tests_set):
2384         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2385         (start):
2386         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
2387         (test_run_test_set_kills_drt_per_run):
2388         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
2389         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):
2390
2391 2012-02-09  Adam Barth  <abarth@webkit.org>
2392
2393         run-perf-tests --chromium should run the chromium port
2394         https://bugs.webkit.org/show_bug.cgi?id=78266
2395
2396         Reviewed by Ryosuke Niwa.
2397
2398         This patch makes run-perf-tests work more like run-webkit-tests.
2399
2400         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2401         (PerfTestsRunner._parse_args):
2402
2403 2012-02-09  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2404
2405         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
2406         https://bugs.webkit.org/show_bug.cgi?id=77466
2407
2408         Reviewed by Dirk Pranke.
2409
2410         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
2411         is set or if we should raise an error. A unit test was added.
2412
2413         * Scripts/webkitpy/layout_tests/port/qt.py:
2414         (QtPort.operating_system):
2415         (QtPort):
2416         (QtPort.check_sys_deps):
2417         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2418         (QtPortTest.test_operating_system):
2419         (QtPortTest):
2420         (QtPortTest.test_check_sys_deps):
2421
2422 2012-02-09  Eric Seidel  <eric@webkit.org>
2423
2424         Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
2425         https://bugs.webkit.org/show_bug.cgi?id=78263
2426
2427         Reviewed by Adam Barth.
2428
2429         * Scripts/webkitpy/common/config/ports.py:
2430         (DeprecatedPort):
2431         (DeprecatedPort.name):
2432         (DeprecatedPort.flag):
2433         (DeprecatedPort.script_path):
2434         (DeprecatedPort.script_shell_command):
2435         (DeprecatedPort.port):
2436         (DeprecatedPort.makeArgs):
2437         (DeprecatedPort.update_webkit_command):
2438         (DeprecatedPort.check_webkit_style_command):
2439         (DeprecatedPort.prepare_changelog_command):
2440         (DeprecatedPort.build_webkit_command):
2441         (DeprecatedPort.run_javascriptcore_tests_command):
2442         (DeprecatedPort.run_webkit_unit_tests_command):
2443         (DeprecatedPort.run_webkit_tests_command):
2444         (DeprecatedPort.run_python_unittests_command):
2445         (DeprecatedPort.run_perl_unittests_command):
2446         (DeprecatedPort.layout_tests_results_path):
2447         (MacPort):
2448         (WinPort):
2449         (GtkPort):
2450         (GtkPort.build_webkit_command):
2451         (GtkPort.run_webkit_tests_command):
2452         (QtPort):
2453         (QtPort.build_webkit_command):
2454         (EflPort):
2455         (EflPort.build_webkit_command):
2456         (ChromiumPort):
2457         (ChromiumPort.update_webkit_command):
2458         (ChromiumPort.build_webkit_command):
2459         (ChromiumPort.run_webkit_tests_command):
2460         (ChromiumPort.run_javascriptcore_tests_command):
2461         (ChromiumXVFBPort):
2462         (ChromiumXVFBPort.run_webkit_tests_command):
2463         * Scripts/webkitpy/common/config/ports_unittest.py:
2464         (DeprecatedPortTest):
2465         (DeprecatedPortTest.test_mac_port):
2466         (DeprecatedPortTest.test_gtk_port):
2467         (DeprecatedPortTest.test_qt_port):
2468         (DeprecatedPortTest.test_chromium_port):
2469         (DeprecatedPortTest.test_chromium_xvfb_port):
2470         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2471         (AbstractEarlyWarningSystem.__init__):
2472         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2473         * Scripts/webkitpy/tool/main.py:
2474         (WebKitPatch):
2475         (WebKitPatch.handle_global_options):
2476         * Scripts/webkitpy/tool/steps/abstractstep.py:
2477         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2478         (StepsTest.test_runtests_args):
2479
2480 2012-02-09  Jochen Eisinger  <jochen@chromium.org>
2481
2482         [chromium] always initialize makeArgs in buildChromiumNinja
2483         https://bugs.webkit.org/show_bug.cgi?id=78231
2484
2485         Reviewed by Tony Gentilcore.
2486
2487         * Scripts/webkitdirs.pm:
2488         (buildChromiumNinja):
2489
2490 2012-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2491
2492         [GTK] Show url of current hovered link in MiniBrowser
2493         https://bugs.webkit.org/show_bug.cgi?id=78098
2494
2495         Reviewed by Martin Robinson.
2496
2497         * MiniBrowser/gtk/BrowserWindow.c:
2498         (webViewMouseTargetChanged): Check whether hit test result is a
2499         link and use the url to update the status bar text.
2500         (browserWindowConstructed): Connect to
2501         WebKitWebView::mouse-target-changed signal.
2502
2503 2012-02-09  Rob Buis  <rbuis@rim.com>
2504
2505         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2506         https://bugs.webkit.org/show_bug.cgi?id=78042
2507
2508         Reviewed by Antonio Gomes.
2509
2510         Upstream final part of our DRT implementation.
2511
2512         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
2513         * DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
2514         * DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
2515         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
2516         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.
2517
2518 2012-02-09  Ryosuke Niwa  <rniwa@webkit.org>
2519
2520         kill-old-processes should kill gcc and clang
2521         https://bugs.webkit.org/show_bug.cgi?id=78189
2522
2523         Reviewed by Eric Seidel.
2524
2525         Added a bunch of processes names of gcc and clang to the list.
2526
2527         * BuildSlaveSupport/kill-old-processes:
2528
2529 2012-02-07  MORITA Hajime  <morrita@google.com>
2530
2531         Replacement text should be available from the marker.
2532         https://bugs.webkit.org/show_bug.cgi?id=77934
2533
2534         Made the mock requestCheckingOfText() implementation to return
2535         a replacement text for each misspelled word if available.
2536
2537         Reviewed by Kent Tamura.
2538
2539         * DumpRenderTree/chromium/WebViewHost.cpp:
2540         (WebViewHost::finishLastTextCheck):
2541
2542 2012-02-08  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2543
2544         [Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
2545         https://bugs.webkit.org/show_bug.cgi?id=78146
2546
2547         Reviewed by Ryosuke Niwa.
2548
2549         Our DumpRenderTree should support --no-timeout and --timeout options in order
2550         to be able to use run-perf-tests and have a Performance Bot.
2551         This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
2552         and the necessary code to handle such command line arguments to our DumpRenderTree.
2553
2554         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2555         (WebCore::DumpRenderTree::setTimeout):
2556         (WebCore):
2557         (WebCore::DumpRenderTree::setShouldTimeout):
2558         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2559         (DumpRenderTree):
2560         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2561         (LayoutTestController::LayoutTestController):
2562         (LayoutTestController::waitUntilDone):
2563         (LayoutTestController::notifyDone):
2564         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2565         (LayoutTestController::setTimeout):
2566         (LayoutTestController::setShouldTimeout):
2567         (LayoutTestController):
2568         * DumpRenderTree/qt/main.cpp:
2569         (isOption):
2570         (printUsage):
2571         (main):
2572
2573 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2574
2575         Rubber-stamped by Martin Robinson.
2576
2577         * gtk/common.py:
2578         (get_build_path): Move test for current directory being a valid
2579         directory up so it takes precedence over WebKitBuild/Release and
2580         WebKitBuild/Debug when they exist as well.
2581
2582 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2583
2584         [GTK] doc rebasing does not respect DESTDIR
2585         https://bugs.webkit.org/show_bug.cgi?id=78177
2586
2587         Reviewed by Martin Robinson.
2588
2589         * GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when
2590         calling it for rebasing.
2591         * gtk/generate-gtkdoc:
2592         (get_common_options): Handle the new --virtual-root option.
2593         * gtk/gtkdoc.py:
2594         (GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
2595         it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.
2596
2597 2012-02-08  Adam Barth  <abarth@webkit.org>
2598
2599         Remove Python 2.5 support from WebKit
2600         https://bugs.webkit.org/show_bug.cgi?id=71593
2601
2602         Reviewed by Eric Seidel.
2603
2604         This is the last vestige of our Python 2.5 support.
2605
2606         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2607         (AbstractQueueTest.test_log_from_script_error_for_upload):
2608
2609 2012-02-08  Adam Barth  <abarth@webkit.org>
2610
2611         version_check.py should inform users that we don't support Python 2.5 anymore
2612         https://bugs.webkit.org/show_bug.cgi?id=78179
2613
2614         Reviewed by Eric Seidel.
2615
2616         We don't support Python 2.5 anymore.
2617
2618         * Scripts/webkitpy/common/version_check.py:
2619
2620 2012-02-08  Adam Barth  <abarth@webkit.org>
2621
2622         test_configuration.py shouldn't re-implement itertools
2623         https://bugs.webkit.org/show_bug.cgi?id=78178
2624
2625         Reviewed by Eric Seidel.
2626
2627         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2628         (TestConfigurationConverter.to_specifiers_list):
2629         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2630         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2631         (TestConfigurationConverter):
2632
2633 2012-02-08  Adam Barth  <abarth@webkit.org>
2634
2635         webkitpy should reply upon the multiprocessing package existing
2636         https://bugs.webkit.org/show_bug.cgi?id=78176
2637
2638         Reviewed by Eric Seidel.
2639
2640         Now that we don't support Python 2.5, this import can't fail.
2641
2642         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2643         (get):
2644         (_Process):
2645         (_Process.__init__):
2646         (_Process.run):
2647         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2648         (FunctionTests.test_get__processes):
2649         (MultiProcessBrokerTests.setUp):
2650         * Scripts/webkitpy/layout_tests/port/base.py:
2651         (Port.__init__):
2652         (Port.default_worker_model):
2653         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2654         (ChromiumMacPort.check_build):
2655         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2656         (PortTestCase.test_default_worker_model):
2657         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2658
2659 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2660
2661         Unreviewed typo fix that makes docs build again for the gtk2-based
2662         library.
2663
2664         * gtk/generate-gtkdoc:
2665
2666 2012-02-08  Adam Barth  <abarth@webkit.org>
2667
2668         Don't re-implement ZipFile.extractall
2669         https://bugs.webkit.org/show_bug.cgi?id=78173
2670
2671         Reviewed by Eric Seidel.
2672
2673         We can use ZipFile.extractall now that we don't support Python 2.5.
2674
2675         * Scripts/webkitpy/common/system/autoinstall.py:
2676         (AutoInstaller._extract_targz):
2677         (AutoInstaller._unzip):
2678
2679 2012-02-08  Adam Barth  <abarth@webkit.org>
2680
2681         Remove the ospath compat shim from webkitpy
2682         https://bugs.webkit.org/show_bug.cgi?id=78170
2683
2684         Reviewed by Eric Seidel.
2685
2686         We no longer need this compat shim now that we don't support Python 2.5.
2687
2688         * Scripts/webkitpy/common/checkout/scm/git.py:
2689         * Scripts/webkitpy/common/checkout/scm/svn.py:
2690         * Scripts/webkitpy/common/system/filesystem.py:
2691         (FileSystem.relpath):
2692         * Scripts/webkitpy/common/system/filesystem_mock.py:
2693         (MockFileSystem.relpath):
2694         * Scripts/webkitpy/common/system/ospath.py: Removed.
2695         * Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
2696
2697 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
2698
2699         Build fix attempt after r107053.
2700
2701         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2702         (test_collect_tests):
2703
2704 2012-02-08  Adam Barth  <abarth@webkit.org>
2705
2706         Remove simplejson because it's no longer used by webkitpy
2707         https://bugs.webkit.org/show_bug.cgi?id=78164
2708
2709         Reviewed by Eric Seidel.
2710
2711         All the importers of this code were removed in a previous patch.
2712
2713         * Scripts/webkitpy/thirdparty/simplejson: Removed.
2714         * Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
2715         * Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
2716         * Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
2717         * Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
2718         * Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
2719         * Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
2720         * Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
2721         * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
2722         * Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
2723         * Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
2724
2725 2012-02-08  Adam Barth  <abarth@webkit.org>
2726
2727         webkitpy still imports simplejson
2728         https://bugs.webkit.org/show_bug.cgi?id=78161
2729
2730         Reviewed by Eric Seidel.
2731
2732         We no longer support Python 2.5, so we can rely upon Python's built-in
2733         JSON package.
2734
2735         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2736         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2737         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
2738         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2739         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2740         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2741         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2742         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2743         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2744         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2745         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2746
2747 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2748
2749         [GTK] Fails to build docs with non-standard build directories
2750         https://bugs.webkit.org/show_bug.cgi?id=78118
2751
2752         * gtk/common.py:
2753         (get_build_path): add comment to document changes done in r107098,
2754         as requested by the reviewer and forgotten by me.
2755
2756 2012-02-08  Adam Barth  <abarth@webkit.org>
2757
2758         Stop importing with_statement from the mysterious future
2759         https://bugs.webkit.org/show_bug.cgi?id=78156
2760
2761         Reviewed by Eric Seidel.
2762
2763         The future is now!  (Well, at least 2008, when Python 2.6 was released,
2764         is no longer the __future__.)
2765
2766         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2767         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2768         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2769         * Scripts/webkitpy/common/net/credentials_unittest.py:
2770         * Scripts/webkitpy/common/net/file_uploader.py:
2771         * Scripts/webkitpy/common/newstringio_unittest.py:
2772         * Scripts/webkitpy/common/system/autoinstall.py:
2773         * Scripts/webkitpy/common/system/crashlogs.py:
2774         * Scripts/webkitpy/common/system/fileset.py:
2775         * Scripts/webkitpy/common/system/filesystem.py:
2776         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2777         * Scripts/webkitpy/common/system/path.py:
2778         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
2779         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2780         * Scripts/webkitpy/layout_tests/port/base.py:
2781         (of):
2782         * Scripts/webkitpy/layout_tests/port/gtk.py:
2783         * Scripts/webkitpy/layout_tests/port/test.py:
2784         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2785         * Scripts/webkitpy/style/filereader_unittest.py:
2786         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2787         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2788         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
2789         * Scripts/webkitpy/tool/commands/queues.py:
2790         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2791         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2792
2793 2012-02-08  Rob Buis  <rbuis@rim.com>
2794
2795         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2796         https://bugs.webkit.org/show_bug.cgi?id=78042
2797
2798         Reviewed by Antonio Gomes.
2799
2800         Upstream more parts of our DRT implementation.
2801
2802         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
2803         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
2804         * DumpRenderTree/blackberry/EventSender.cpp: Added.
2805         * DumpRenderTree/blackberry/EventSender.h: Added.
2806         * DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
2807         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
2808
2809 2012-02-08  Dirk Pranke  <dpranke@chromium.org>
2810
2811         check-webkit-style failing with "Path does not exist."
2812         https://bugs.webkit.org/show_bug.cgi?id=77873
2813
2814         Reviewed by Ojan Vafai.
2815
2816         This change fixes the way the style checker determines which
2817         Port class to use for a given test_expectations.txt path; the
2818         previous version used a heuristic that didn't really work in the
2819         first place.
2820
2821         * Scripts/webkitpy/style/checkers/test_expectations.py:
2822         (TestExpectationsChecker._determine_port_from_expectations_path):
2823         (TestExpectationsChecker.__init__):
2824         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2825         (TestExpectationsTestCase._expect_port_for_expectations_path):
2826         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2827
2828 2012-02-08  Fehér Zsolt  <feherzs@inf.u-szeged.hu>
2829
2830         nrwt: make --skip-pixel-test-if-no-baseline option
2831         https://bugs.webkit.org/show_bug.cgi?id=70484
2832
2833         Reviewed by Dirk Pranke.
2834
2835         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2836         (SingleTestRunner.__init__):
2837         (SingleTestRunner._should_fetch_expected_checksum):
2838         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2839         (Worker.handle_test_list):
2840         * Scripts/webkitpy/layout_tests/models/test_input.py:
2841         (TestInput.__init__):
2842         * Scripts/webkitpy/layout_tests/port/webkit.py:
2843         (WebKitDriver.cmd_line):
2844         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2845         (_set_up_derived_options):
2846         (parse_args):
2847         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2848         (MainTest.test_skip_pixel_test_if_no_baseline_option):
2849         * WebKitTestRunner/TestController.cpp:
2850         (WTR::TestController::TestController):
2851         (WTR::TestController::initialize):
2852         (WTR::TestController::runTest):
2853         * WebKitTestRunner/TestController.h:
2854         (TestController):
2855         * WebKitTestRunner/TestInvocation.cpp:
2856         (WTR::TestInvocation::TestInvocation):
2857         (WTR::TestInvocation::setIsPixelTest):
2858         * WebKitTestRunner/TestInvocation.h:
2859         (WTR::TestInvocation::setSkipPixelTestOption):
2860         (TestInvocation):
2861
2862 2012-02-08  Rob Buis  <rbuis@rim.com>
2863
2864         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2865         https://bugs.webkit.org/show_bug.cgi?id=78042
2866
2867         Reviewed by Antonio Gomes.
2868
2869         Add implementation for our DumpRenderTree solution.
2870
2871         * DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
2872         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.
2873
2874 2012-02-08  Antti Koivisto  <antti@apple.com>
2875
2876         REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
2877         https://bugs.webkit.org/show_bug.cgi?id=78080
2878
2879         Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
2880
2881         Add API test.
2882
2883         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2884         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
2885         (TestWebKitAPI):
2886         (TestWebKitAPI::TEST):
2887
2888 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2889
2890         [GTK] Fails to build docs with non-standard build directories
2891         https://bugs.webkit.org/show_bug.cgi?id=78118
2892
2893         Reviewed by Martin Robinson.
2894
2895         * gtk/common.py:
2896         (get_build_path): also try the current directory as a valid build
2897         dir, which makes non-standard build directories such as build-2.0
2898         and build-3.0 work
2899
2900 2012-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2901
2902         [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
2903         https://bugs.webkit.org/show_bug.cgi?id=78099
2904
2905         Reviewed by Martin Robinson.
2906
2907         * MiniBrowser/gtk/BrowserWindow.c:
2908         (webViewDecidePolicy): Check whether it's a link clicked with the
2909         middle mouse button and load the request in a new window.
2910         (browserWindowConstructed): Connect to
2911         WebKitWebView::decide-policy signal.
2912
2913 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
2914
2915         Revert a part of the change in r106687 as a build fix.
2916
2917         Since Chromium port doesn't checkout the entire WebKit trunk,
2918         we can't run "svn info" on webkit_base.
2919
2920         * Scripts/webkitpy/layout_tests/port/base.py:
2921         (Port.repository_paths):
2922
2923 2012-02-07  Ryosuke Niwa  <rniwa@webkit.org>
2924
2925         run-perf-tests doesn't recognize paths that start with PerformanceTests
2926         https://bugs.webkit.org/show_bug.cgi?id=78012
2927
2928         Reviewed by Adam Barth.
2929
2930         Use resolve paths using filesystem.relpath before passing it to find_files.find.
2931
2932         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2933         (PerfTestsRunner):
2934         (PerfTestsRunner._collect_tests):
2935         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2936         (test_collect_tests):
2937         (test_collect_tests.add_file):
2938
2939 2012-02-07  Justin Novosad  <junov@chromium.org>
2940
2941         [Chromium] add option for 2d canvas defered rendering to DumpRenderTree
2942         https://bugs.webkit.org/show_bug.cgi?id=78039
2943
2944         Reviewed by Stephen White.
2945
2946         Adding the --enable-deferred-2d-canvas switch to DumpRenderTree
2947
2948         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2949         (main):
2950         * DumpRenderTree/chromium/TestShell.cpp:
2951         (TestShell::TestShell):
2952         (TestShell::resetWebSettings):
2953         (TestShell::runFileTest):
2954         * DumpRenderTree/chromium/TestShell.h:
2955         (TestShell::setDeferred2dCanvasEnabled):
2956         (TestShell):
2957         * DumpRenderTree/chromium/WebPreferences.cpp:
2958         (WebPreferences::reset):
2959         (WebPreferences::applyTo):
2960         * DumpRenderTree/chromium/WebPreferences.h:
2961         (WebPreferences):
2962
2963 2012-02-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2964
2965         [CMAKE] Use *bin* and *lib* directories for executable and libraries.
2966         https://bugs.webkit.org/show_bug.cgi?id=77928
2967
2968         Reviewed by Daniel Bates.
2969
2970         CMake has used *Programs* directory for executable. In addition, shared libraries are being
2971         built in source directory. It is better to set common places in order to maintain executable
2972         and libraries. *bin* is for executable and *lib* is for library.
2973
2974         * DumpRenderTree/efl/CMakeLists.txt:
2975         * EWebLauncher/CMakeLists.txt:
2976         * Scripts/run-launcher:
2977         * Scripts/webkitdirs.pm:
2978         (jscProductDir):
2979         * Scripts/webkitpy/layout_tests/port/efl.py:
2980         (EflPort._path_to_driver):
2981         (EflPort._path_to_image_diff):
2982
2983 2012-02-07  Adam Klein  <adamk@chromium.org>
2984
2985         Add JSC support for delivering mutations when the outermost script context exits
2986         https://bugs.webkit.org/show_bug.cgi?id=70289
2987
2988         Reviewed by Eric Seidel.
2989
2990         * DumpRenderTree/mac/EventSendingController.mm: Add support for
2991         eventSender.scheduleAsynchronousKeyDown.
2992         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2993         (+[EventSendingController webScriptNameForSelector:]):
2994         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
2995         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
2996         * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
2997
2998 2012-02-07  Chris Rogers  <crogers@google.com>
2999
3000         Add Chris Rogers to reviewers section
3001         https://bugs.webkit.org/show_bug.cgi?id=78016
3002
3003         Reviewed by Adam Barth.
3004
3005         * Scripts/webkitpy/common/config/committers.py:
3006
3007 2012-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>
3008
3009         layoutTestController.display() is flaky for SVG tests
3010         https://bugs.webkit.org/show_bug.cgi?id=78021
3011
3012         Reviewed by Dan Bernstein.
3013
3014         Fix race condition in repaint rect tracking. When running a test using the repaint.js
3015         harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
3016         the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
3017         hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
3018         svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
3019         the repaint test already run, thus invalidating the previously tracked repaint rects.
3020
3021         * DumpRenderTree/mac/DumpRenderTree.mm:
3022         (dump):
3023         (runTest):
3024
3025 2012-02-07  Hans Wennborg  <hans@chromium.org>
3026
3027         Chromium: remove WebSpeechInputResult::set
3028         https://bugs.webkit.org/show_bug.cgi?id=77977
3029
3030         Reviewed by Darin Fisher.
3031
3032         It was renamed to assign() in r106475.
3033
3034         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3035         (makeRectResult):
3036
3037 2012-02-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3038
3039         [Qt] Give emulated touch-point a radius
3040         https://bugs.webkit.org/show_bug.cgi?id=77985
3041
3042         Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
3043
3044         Reviewed by Kenneth Rohde Christiansen.
3045
3046         * MiniBrowser/qt/BrowserWindow.cpp:
3047         (BrowserWindow::updateVisualMockTouchPoints):
3048         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3049         (MiniBrowserApplication::notify):
3050         * MiniBrowser/qt/qml/MockTouchPoint.qml:
3051
3052 2012-02-07  Mario Sanchez Prada  <msanchez@igalia.com>
3053
3054         [GTK] Include gdk-pixbuf in the jhbuild modules
3055         https://bugs.webkit.org/show_bug.cgi?id=77980
3056
3057         Reviewed by Gustavo Noronha Silva.
3058
3059         * gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
3060
3061 2012-02-07  Simon Hausmann  <simon.hausmann@nokia.com>
3062
3063         [Qt] Prevent early test termination with newer Qt 5
3064         https://bugs.webkit.org/show_bug.cgi?id=77945
3065
3066         Reviewed by Csaba Osztrogonác.
3067
3068         QTBUG-24120 tracks a regression in Qt that would make layout tests
3069         terminate early. This patch works around it in a Qt 4 + 5 safe manner
3070         by disabling the quitOnLastWindowClosed feature, which we don't want/need
3071         for DRT anyway.
3072
3073         * DumpRenderTree/qt/main.cpp:
3074         (main): Don't quit on last window closed.
3075
3076 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
3077
3078         Fix some miscellaneous 'make dist' error for WebKitGTK+.
3079
3080         * MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated
3081         files should not be distributed.
3082
3083 2012-02-02  Hajime Morrita  <morrita@chromium.org>
3084
3085         [PerformanceTests] Each Dromaeo test needs its landing html.
3086         https://bugs.webkit.org/show_bug.cgi?id=77504
3087
3088         Reviewed by Ryosuke Niwa.
3089
3090         Added an ignorable pattern which happens in some Dromaeo tests.
3091
3092         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3093         (PerfTestsRunner):
3094
3095 2012-02-06  Kalev Lember  <kalevlember@gmail.com>
3096
3097         [GTK] Add missing pango include dir to fix build
3098         https://bugs.webkit.org/show_bug.cgi?id=77832
3099
3100         Reviewed by Martin Robinson.
3101
3102         * GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
3103
3104 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
3105
3106         [GTK] Fix remaining errors in GTK+ WebKit2 API
3107         https://bugs.webkit.org/show_bug.cgi?id=77890
3108
3109         Reviewed by Gustavo Noronha Silva.
3110
3111         Verify that WebKit2 GTK+ test files are not skipped during style checks.
3112         Skip soup_server_new when checking for NULL versus 0 usage.
3113
3114         * Scripts/webkitpy/style/checker_unittest.py:
3115         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
3116         * Scripts/webkitpy/style/checkers/cpp.py:
3117         (check_for_null):
3118
3119 2012-02-06  Eric Seidel  <eric@webkit.org>
3120
3121         webkit-patch apply-from-bug should be able to apply non-reviewed patches
3122         https://bugs.webkit.org/show_bug.cgi?id=77883
3123
3124         Reviewed by Adam Barth.
3125
3126         This is very helpful if you use bugzilla as a replacement for git-stash.
3127         Makes it simpler to re-apply the patch w/o having to look up the patch id.
3128
3129         * Scripts/webkitpy/tool/commands/download.py:
3130         (ProcessBugsMixin._fetch_list_of_patches_to_process):
3131         * Scripts/webkitpy/tool/commands/download_unittest.py:
3132         (DownloadCommandsTest.test_apply_from_bug):
3133
3134 2012-02-06  Philippe Normand  <pnormand@igalia.com>
3135
3136         [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
3137         https://bugs.webkit.org/show_bug.cgi?id=77866
3138
3139         Reviewed by Martin Robinson.
3140
3141         * Scripts/webkitpy/style/checker.py: Ignore readability/naming
3142         errors in some gstreamer source code files defining new GStreamer elements.
3143         * Scripts/webkitpy/style/checker_unittest.py:
3144         (GlobalVariablesTest.test_path_rules_specifier):
3145
3146 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3147
3148         [GTK] Make sure html_dir exists before calling gtkdoc-rebase
3149         https://bugs.webkit.org/show_bug.cgi?id=77869
3150
3151         Reviewed by Philippe Normand.
3152
3153         * gtk/gtkdoc.py:
3154         (GTKDoc.rebase_installed_docs): Check html_dir exists.
3155
3156 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3157
3158         [Qt] Don't version QtWebKit.experimental.
3159         https://bugs.webkit.org/show_bug.cgi?id=77739
3160
3161         Reviewed by Tor Arne Vestbø.
3162
3163         * MiniBrowser/qt/qml/BrowserWindow.qml:
3164
3165 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3166
3167         [GTK] Fix several gtkdoc-fixxref warnings
3168         https://bugs.webkit.org/show_bug.cgi?id=77613
3169
3170         Reviewed by Martin Robinson.
3171
3172         * gtk/generate-gtkdoc:
3173         (get_webkit1_options): Add webkitspellcheckerenchant.* to the list
3174         of ignored files, since it's private.
3175         * gtk/gtkdoc.py:
3176         (GTKDoc._ignored_files_basenames): Helper function that returns a
3177         string with the list of ignored files basenames separated by a
3178         spaces, as expected by several gtkdoc commands.
3179         (GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
3180         --ignore-headers option.
3181         (GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
3182         --ignore-files option.
3183
3184 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3185
3186         [GTK] Fix xrefs after installing API documentation
3187         https://bugs.webkit.org/show_bug.cgi?id=77551
3188
3189         Reviewed by Martin Robinson.
3190
3191         * GNUmakefile.am: Call generate-gtkdoc --rebase after installing
3192         api docs.
3193         * gtk/common.py:
3194         (prefix_of_pkg_config_file): Get the prefix variable of the given
3195         pkg-config file.
3196         (gtk_version_of_pkg_config_file): Get the gtk version required by
3197         the given pkg-config file.
3198         * gtk/generate-gtkdoc: Add --rebase command line option to rebase
3199         installed documentation.
3200         (get_gtkdoc_module_paths): Get paths where API doc is installed
3201         for the dependencies of the given pkg-config file.
3202         (get_common_xref_deps): Get API doc directories of dependencies
3203         common to WebKit1 and WebKit2.
3204         (get_webkit2_options): Add cross_reference_deps option.
3205         (get_webkit1_options): Ditto
3206         (rebase_installed_docs): Helper function to create a generator for
3207         the given pkg-config file and options and call rebase_installed_docs.
3208         * gtk/gtkdoc.py:
3209         (GTKDoc.__init__): Initialize cross_reference_deps.
3210         (GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
3211         dependencies.
3212         (GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
3213         links of installed documentation.
3214         (PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config
3215         file.
3216
3217 2012-02-06  Sergio Villar Senin  <svillar@igalia.com>
3218
3219         Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
3220         https://bugs.webkit.org/show_bug.cgi?id=77672
3221
3222         Reviewed by Dirk Pranke.
3223
3224         Test repetitions must be taken into account when working out
3225         the statistics shown by run-webkit-tests.
3226
3227         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3228         (Manager.prepare_lists_and_print_output):
3229         (Manager._print_result_summary):
3230         * Scripts/webkitpy/layout_tests/models/result_summary.py:
3231         (ResultSummary.__init__):
3232         (ResultSummary.add):
3233         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3234         (MainTest.test_repeat_each_iterations_num_tests):
3235
3236 2012-02-05  Dan Bernstein  <mitz@apple.com>
3237
3238         <rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
3239         https://bugs.webkit.org/show_bug.cgi?id=77823
3240
3241         Reviewed by Anders Carlsson.
3242
3243         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3244         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
3245
3246 2012-02-04  Dan Bernstein  <mitz@apple.com>
3247
3248         <rdar://problem/10660698> Clients cannot prevent caching of individual responses
3249         https://bugs.webkit.org/show_bug.cgi?id=77822
3250
3251         Reviewed by Sam Weinig.
3252
3253         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3254         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
3255
3256 2012-02-04  Sam Weinig  <sam@webkit.org>
3257
3258         Add ability to send WKURLRequests in WebKit2 API user messages
3259         https://bugs.webkit.org/show_bug.cgi?id=77819
3260
3261         Reviewed by Anders Carlsson.
3262
3263         Add testing for round-tripping WKTypes from the UIProcess,
3264         to the WebProcess, and back.
3265
3266         - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
3267           More can easily be added.
3268
3269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3270         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
3271         (TestWebKitAPI):
3272         (WebKit2UserMessageRoundTripTest):
3273         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
3274         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
3275         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
3276         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
3277         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
3278         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
3279         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
3280         (TestWebKitAPI::TEST_F):
3281         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
3282         (TestWebKitAPI):
3283         (UserMessageTest):
3284         (TestWebKitAPI::UserMessageTest::UserMessageTest):
3285         (TestWebKitAPI::UserMessageTest::didReceiveMessage):
3286         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3287         (TestWebKitAPI::PlatformWebView::resizeTo):
3288         (TestWebKitAPI):
3289         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3290         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3291
3292 2012-02-04  Dan Bernstein  <mitz@apple.com>
3293
3294         <rdar://problem/10772406> WKPreferences instances cannot be copied
3295         https://bugs.webkit.org/show_bug.cgi?id=77816
3296
3297         Reviewed by Sam Weinig.
3298
3299         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3300         (TestWebKitAPI::TEST):
3301
3302 2012-02-04  Adam Barth  <abarth@webkit.org>
3303
3304         garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
3305         https://bugs.webkit.org/show_bug.cgi?id=77802
3306
3307         Reviewed by Eric Seidel.
3308
3309         This patch refactors our directory grouping code into base.js where it
3310         can be shared between failures.js and notifications.js.  It then adds
3311         an Examine action to each group of failures that triggers the "results"
3312         view.
3313
3314         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3315         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3316         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3317         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3318         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3319         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
3320
3321 2012-02-04  Ojan Vafai  <ojan@chromium.org>
3322
3323         check-webkit-style is throwing an exception
3324         https://bugs.webkit.org/show_bug.cgi?id=77744
3325
3326         Reviewed by David Levin.
3327
3328         If the test_list is None, then we don't need to check for unsupported
3329         feature tests to skip.
3330
3331         * Scripts/webkitpy/layout_tests/port/webkit.py:
3332         (WebKitPort._has_test_in_directories):
3333         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3334         (test_skipped_tests_for_unsupported_features_empty_test_list):
3335
3336 2012-02-03  Adam Barth  <abarth@webkit.org>
3337
3338         List of all failures in garden-o-matic should actually list all the failures
3339         https://bugs.webkit.org/show_bug.cgi?id=77796
3340
3341         Reviewed by Eric Seidel.
3342
3343         This patch wires a bit more data into the new "All Failures" tab.  I've
3344         also iterated on how we enable this experimental feature.  The tab is
3345         still just a dumb list, but we'll make it smarter.
3346
3347         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3348         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3349         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3350         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3351
3352 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3353
3354         Windows build fix after r106692.
3355
3356         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3357         (PortTest.test_reference_files):
3358
3359 2012-02-03  Beth Dakin  <bdakin@apple.com>
3360
3361         https://bugs.webkit.org/show_bug.cgi?id=77782
3362         WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than
3363         once on some pages with frames
3364         -and corresponding-
3365         <rdar://problem/10798474>
3366
3367         Reviewed by Sam Weinig.
3368
3369         One new test.
3370         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3371         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
3372         (TestWebKitAPI):
3373         (TestWebKitAPI::didForceRepaint):
3374         (TestWebKitAPI::didFinishLoadForFrame):
3375         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3376         (TestWebKitAPI::setPageLoaderClient):
3377         (TestWebKitAPI::TEST):
3378         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
3379         (TestWebKitAPI):
3380         (NewFirstVisuallyNonEmptyLayoutFramesTest):
3381         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
3382         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
3383         * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
3384
3385 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
3386
3387         webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
3388         https://bugs.webkit.org/show_bug.cgi?id=77781
3389
3390         Reviewed by Eric Seidel.
3391
3392         This change fixes a couple of issues discovered while debugging
3393         test-webkitpy; both calling exit() instead of sys.exit() --
3394         which is discouraged in program code instead of the interpreter
3395         -- and a particular usage of outputcapture were stdin to get whacked
3396         and preventing debugging.
3397
3398         This change introduces a couple of common _exit() methods that
3399         will standardize how webkit-patch exit's, in case we need to do
3400         something different in the future.
3401
3402         * Scripts/webkitpy/common/system/deprecated_logging.py:
3403         (error):
3404         * Scripts/webkitpy/common/system/outputcapture.py:
3405         (OutputCapture.assert_outputs):
3406         * Scripts/webkitpy/tool/bot/queueengine.py:
3407         (QueueEngine.exit_after_handled_error):
3408         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3409         (AbstractSequencedCommand.execute):
3410         * Scripts/webkitpy/tool/commands/queues.py:
3411         (StyleQueue.handle_script_error):
3412         * Scripts/webkitpy/tool/commands/upload.py:
3413         (MarkBugFixed.execute):
3414         * Scripts/webkitpy/tool/multicommandtool.py:
3415         (Command._exit):
3416         * Scripts/webkitpy/tool/steps/abstractstep.py:
3417         (AbstractStep._exit):
3418         * Scripts/webkitpy/tool/steps/checkstyle.py:
3419         (CheckStyle.run):
3420         * Scripts/webkitpy/tool/steps/commit.py:
3421         (Commit._check_test_expectations):
3422         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3423         (ConfirmDiff.run):
3424
3425 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3426
3427         Perf bot build fix.
3428
3429         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3430         (PerfTestsRunner._generate_json):
3431
3432 2012-02-03  Adam Barth  <abarth@webkit.org>
3433
3434         Add a blank "Expected Failures" tab to garden-o-matic
3435         https://bugs.webkit.org/show_bug.cgi?id=77793
3436
3437         Reviewed by Eric Seidel.
3438
3439         This tab will help us explore and manage our expected failures.  The
3440         tab is hidden by default via a new "experimental features" flag.
3441
3442         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3443         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3444         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3445         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3446         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
3447         (#unexpected):
3448         (#onebar.partytime #unexpected):
3449
3450 2012-02-03  Lucas Forschler  <lforschler@apple.com>
3451
3452         update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
3453         https://bugs.webkit.org/show_bug.cgi?id=77785
3454
3455         Fix the build bots.
3456
3457         Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
3458
3459         * Scripts/update-webkit-support-libs:
3460         (downloadExpectedVersionNumber):
3461
3462 2012-02-03  Lucas Forschler  <lforschler@apple.com>
3463
3464         Add a Mac Lion Performance bot.
3465         https://bugs.webkit.org/show_bug.cgi?id=77765
3466
3467         Reviewed by Adam Roben.
3468
3469         This will update the master configuration in the following ways:
3470             Add a new performance slave (apple-xseve-11)
3471             Add a new Factory to download a build and run perf tests.
3472
3473         * BuildSlaveSupport/build.webkit.org-config/config.json:
3474         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3475         (DownloadAndPerfTestFactory):
3476         (DownloadAndPerfTestFactory.__init__):
3477
3478 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
3479
3480         Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
3481         https://bugs.webkit.org/show_bug.cgi?id=77752
3482
3483         Reviewed by James Robinson.
3484
3485         Delete unneeded file accidentally checked in in r106481.
3486
3487         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
3488
3489 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3490
3491         Ref Tests should support plain SVG files
3492         https://bugs.webkit.org/show_bug.cgi?id=77685
3493
3494         Reviewed by Tony Chang.
3495
3496         Don't assume reference files always use .html as the extension.
3497         Instead, use the list of supported extension to look for -expected.* and -mismatch.*
3498
3499         Also fix various bugs in MockFileSystem and TestPort.
3500
3501         * Scripts/webkitpy/common/system/filesystem_mock.py:
3502         (MockFileSystem.isdir):
3503         * Scripts/webkitpy/layout_tests/port/base.py:
3504         (Port.reference_files):
3505         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3506         (PortTest.test_is_test_file):
3507         (PortTest.test_reference_files):
3508         * Scripts/webkitpy/layout_tests/port/test.py:
3509         (TestInstance.__init__):
3510
3511 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3512
3513         perf-o-matic should store chromium svn revision
3514         https://bugs.webkit.org/show_bug.cgi?id=77725
3515
3516         Reviewed by Dirk Pranke.
3517
3518         Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
3519         repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
3520         is implemented in terms of newly added svn_revision.
3521
3522         * Scripts/webkitpy/common/checkout/scm/git.py:
3523         (Git.svn_revision):
3524         * Scripts/webkitpy/common/checkout/scm/scm.py:
3525         (SCM.head_svn_revision):
3526         (SCM):
3527         (SCM.svn_revision):
3528         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3529         (MockSCM.svn_revision):
3530         * Scripts/webkitpy/common/checkout/scm/svn.py:
3531         (SVN.svn_revision):
3532         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3533         (JSONLayoutResultsGenerator.__init__):
3534         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3535         (JSONResultsGeneratorBase._insert_generic_metadata):
3536         * Scripts/webkitpy/layout_tests/port/base.py:
3537         (Port.repository_paths):
3538         * Scripts/webkitpy/layout_tests/port/chromium.py:
3539         (ChromiumPort.repository_paths):
3540         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3541         (PerfTestsRunner._generate_json):
3542         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3543         (test_run_test_set_with_json_output):
3544         (test_run_test_set_with_json_source):
3545         (test_run_test_set_with_multiple_repositories):
3546
3547 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3548
3549         [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
3550         https://bugs.webkit.org/show_bug.cgi?id=77632
3551
3552         Reviewed by Kenneth Rohde Christiansen.
3553
3554         * MiniBrowser/qt/BrowserWindow.cpp:
3555         (BrowserWindow::BrowserWindow):
3556         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3557         (MiniBrowserApplication::sendTouchEvent):
3558         (MiniBrowserApplication::handleUserOptions):
3559         * MiniBrowser/qt/MiniBrowserApplication.h:
3560         (WindowOptions):
3561         (WindowOptions::WindowOptions):
3562         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3563         (WTR::PlatformWebView::PlatformWebView):
3564         * WebKitTestRunner/qt/main.cpp:
3565         (main):
3566         * qmake/mkspecs/features/default_post.prf:
3567
3568 2012-02-03  Simon Hausmann  <simon.hausmann@nokia.com>
3569
3570         [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
3571         https://bugs.webkit.org/show_bug.cgi?id=77723
3572
3573         Reviewed by Tor Arne Vestbø.
3574
3575         * Tools.pro: Compile WTR again on all platforms with WK2.
3576
3577 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
3578
3579         Ensure that inspector disabled build works
3580         https://bugs.webkit.org/show_bug.cgi?id=77604
3581
3582         Reviewed by Tor Arne Vestbø.
3583
3584         * qmake/mkspecs/features/features.prf:
3585
3586 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
3587
3588         [chromium] add support for --makeargs to the ninja-based build
3589         https://bugs.webkit.org/show_bug.cgi?id=77688
3590
3591         Reviewed by Adam Barth.
3592
3593         * Scripts/webkitdirs.pm:
3594         (buildChromiumNinja):
3595
3596 2012-02-02  Eric Seidel  <eric@webkit.org>
3597
3598         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
3599         https://bugs.webkit.org/show_bug.cgi?id=75145
3600
3601         Reviewed by Dirk Pranke.
3602
3603         * Scripts/webkitpy/layout_tests/port/mac.py:
3604         (MacPort.default_child_processes):
3605         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3606         (test_operating_system):
3607         (test_default_child_processes):
3608
3609 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
3610
3611        nrwt shouldn't blow up when there are errors in test_expectations.txt
3612        https://bugs.webkit.org/show_bug.cgi?id=73603
3613
3614        Reviewed by Ojan Vafai.
3615
3616        This change removes the distinction between 'errors' and 'warnings'
3617        in the test expectations parser. Now, any problem is a
3618        'warning', and if we are linting the file, warnings become fatal (errors).
3619
3620         This will allow a normal run-webkit-tests run to proceed even if
3621         there are bad lines.
3622
3623         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3624         (ParseError.__init__):
3625         (ParseError.__str__):
3626         (ParseError.__repr__):
3627         (TestExpectationSerializer.to_string):
3628         (TestExpectationParser._parse_modifiers):
3629         (TestExpectationParser._parse_expectations):
3630         (TestExpectationParser._check_modifiers_against_expectations):
3631         (TestExpectationParser._tokenize):
3632         (TestExpectationLine.__init__):
3633         (TestExpectationLine.is_invalid):
3634         (TestExpectationsModel.add_expectation_line):
3635         (TestExpectationsModel._already_seen_better_match):
3636         (TestExpectations.__init__):
3637         (TestExpectations._report_warnings):
3638         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
3639         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3640         (assert_bad_expectations):
3641         (test_parse_warning):
3642         (test_overrides__duplicate):
3643         (ExpectationSyntaxTests.test_missing_expectation):
3644         (ExpectationSyntaxTests.test_missing_colon):
3645         (ExpectationSyntaxTests.test_too_many_colons):
3646         (ExpectationSyntaxTests.test_too_many_equals_signs):
3647         (ExpectationSyntaxTests.test_unrecognized_expectation):
3648         (SemanticTests.test_bug_format):
3649         (SemanticTests.test_bad_bugid):
3650         (SemanticTests.test_slow_and_timeout):
3651         (test_ambiguous):
3652         (test_more_modifiers):
3653         (test_order_in_file):
3654         (test_macro_overrides):
3655         (RebaseliningTest.assertRemove):
3656         (TestExpectationParserTests.test_tokenize_blank):
3657         (TestExpectationParserTests.test_tokenize_missing_colon):
3658         (TestExpectationParserTests.test_tokenize_extra_colon):
3659         (TestExpectationParserTests.test_tokenize_empty_comment):
3660         (TestExpectationParserTests.test_tokenize_comment):
3661         (TestExpectationParserTests.test_tokenize_missing_equal):
3662         (TestExpectationParserTests.test_tokenize_extra_equal):
3663         (TestExpectationParserTests.test_tokenize_valid):
3664         (TestExpectationParserTests.test_tokenize_valid_with_comment):
3665         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
3666         (TestExpectationSerializerTests.test_unparsed_to_string):
3667         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3668         (lint):
3669         * Scripts/webkitpy/style/checkers/test_expectations.py:
3670         (TestExpectationsChecker.check_test_expectations):
3671
3672 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3673
3674         Unreviewed, rolling out r106543.
3675         http://trac.webkit.org/changeset/106543
3676         https://bugs.webkit.org/show_bug.cgi?id=77671
3677
3678         Made tests less stable (Requested by rniwa on #webkit).
3679
3680         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3681         (PerfTestsRunner):
3682         (PerfTestsRunner.__init__):
3683         (PerfTestsRunner._run_tests_set):
3684         (PerfTestsRunner._run_single_test):
3685         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3686         (MainTest.TestDriver.run_test):
3687         (run_test):
3688
3689 2012-02-02  Beth Dakin  <bdakin@apple.com>
3690
3691         https://bugs.webkit.org/show_bug.cgi?id=77664
3692         Add API tests for didNewFirstVisuallyNonEmptyLayout
3693
3694         Reviewed by Darin Adler.
3695
3696         Two new tests.
3697         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3698         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
3699         (TestWebKitAPI):
3700         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3701         (TestWebKitAPI::setPageLoaderClient):
3702         (TestWebKitAPI::TEST):
3703         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
3704         (TestWebKitAPI):
3705         (TestWebKitAPI::didForceRepaint):
3706         (TestWebKitAPI::didFinishLoadForFrame):
3707         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3708         (TestWebKitAPI::setPageLoaderClient):
3709         (TestWebKitAPI::TEST):
3710         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
3711         (TestWebKitAPI):
3712         (NewFirstVisuallyNonEmptyLayoutFailsTest):
3713         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
3714         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
3715         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
3716         (TestWebKitAPI):