Disable ViewportSizeForViewportUnits tests on iOS.
[WebKit-https.git] / Tools / ChangeLog
1 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2
3         Disable ViewportSizeForViewportUnits tests on iOS.
4         https://bugs.webkit.org/show_bug.cgi?id=172872
5
6         Reviewed by Tim Horton.
7
8         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
9
10 2017-06-02  Zalan Bujtas  <zalan@apple.com>
11
12         Allow clients to override viewport size for CSS viewport units.
13         https://bugs.webkit.org/show_bug.cgi?id=172838
14         <rdar://problem/32523441>
15
16         Reviewed by Tim Horton.
17
18         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
20         (TEST):
21
22 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
23
24         Get <chrono> out of StdLibExtras.h
25         https://bugs.webkit.org/show_bug.cgi?id=172744
26
27         Reviewed by Zalan Bujtas.
28
29         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
30
31 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
32
33         [WPE] Enable SUBTLE_CRYPTO
34         https://bugs.webkit.org/show_bug.cgi?id=172756
35
36         Reviewed by Michael Catanzaro.
37
38         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
39         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
40         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
41         exhausting entropy when running the crypto layout tests.
42
43 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
44
45         [GTK] Bump GTK+ and its dependencies in jhbuild
46         https://bugs.webkit.org/show_bug.cgi?id=171918
47
48         Reviewed by Carlos Alberto Lopez Perez.
49
50         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
51         (WTR::initializeGtkSettings):
52         * gtk/jhbuild.modules:
53         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
54         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
55
56 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
57
58         [GTK] Bump wayland and weston in jhbuild
59         https://bugs.webkit.org/show_bug.cgi?id=171921
60
61         Reviewed by Carlos Alberto Lopez Perez.
62
63         * gtk/jhbuild.modules:
64         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
65
66 2017-06-01  Andy Estes  <aestes@apple.com>
67
68         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
69         https://bugs.webkit.org/show_bug.cgi?id=172828
70
71         Reviewed by Beth Dakin.
72
73         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
74
75 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
76
77         webkitpy: Remove unneeded simulator teardown
78         https://bugs.webkit.org/show_bug.cgi?id=171891
79
80         Reviewed by Aakash Jain.
81
82         * Scripts/webkitpy/port/ios_simulator.py:
83         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
84         for communication between Python and WebKitTestRunner/DumpRenderTree.
85
86 2017-06-01  Keith Miller  <keith_miller@apple.com>
87
88         Undo rollout in r217638 with bug fix
89         https://bugs.webkit.org/show_bug.cgi?id=172824
90
91         Unreviewed, reland patch with unused set_state code removed.
92
93         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
94         (runThreadMessageTest):
95         (TEST):
96
97 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
98
99         webkitpy: Do not send 0 or -1 as a pid to kill_process
100         https://bugs.webkit.org/show_bug.cgi?id=172818
101
102         Reviewed by Darin Adler.
103
104         Sending a signal to process 0 will result in all processes in the group receiving 
105         the signal. Sending a signal to process -1 will result in all non-system processes
106         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
107         should consider these cases
108
109         * Scripts/webkitpy/common/system/executive.py:
110         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
111         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
112         never be running, although os.kill may succeed.
113         * Scripts/webkitpy/port/simulator_process.py:
114         (SimulatorProcess.stop): Do not kill process if it is undefined.
115
116 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
117
118         JSC EWS bot does not run on WTF only patches
119         https://bugs.webkit.org/show_bug.cgi?id=172777
120         rdar://problem/32495975
121
122         Reviewed by Aakash Jain.
123
124         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
125         (CheckPatchRelevance): Add a missing comma.
126
127 2017-05-31  Commit Queue  <commit-queue@webkit.org>
128
129         Unreviewed, rolling out r217611 and r217631.
130         https://bugs.webkit.org/show_bug.cgi?id=172785
131
132         "caused wasm-hashset-many.html to become flaky." (Requested by
133         keith_miller on #webkit).
134
135         Reverted changesets:
136
137         "Reland r216808, underlying lldb bug has been fixed."
138         https://bugs.webkit.org/show_bug.cgi?id=172759
139         http://trac.webkit.org/changeset/217611
140
141         "Use dispatch queues for mach exceptions"
142         https://bugs.webkit.org/show_bug.cgi?id=172775
143         http://trac.webkit.org/changeset/217631
144
145 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
146
147         EWS bots should reboot themselves more frequently
148         https://bugs.webkit.org/show_bug.cgi?id=172402
149
150         Reviewed by Alexey Proskuryakov.
151
152         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
153
154         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
155
156 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
157
158         Reallocate hardware for iOS bots.
159         https://bugs.webkit.org/show_bug.cgi?id=172657
160
161         Reviewed by Alexey Proskuryakov.
162
163         * BuildSlaveSupport/build.webkit.org-config/config.json:
164
165 2017-05-31  Andy Estes  <aestes@apple.com>
166
167         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
168         https://bugs.webkit.org/show_bug.cgi?id=172366
169
170         Reviewed by Daniel Bates.
171
172         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
173
174 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
175
176         Unreviewed, add Jiewen Tan as a reviewer
177
178         * Scripts/webkitpy/common/config/contributors.json:
179
180 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
181
182         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
183         https://bugs.webkit.org/show_bug.cgi?id=172770
184
185         Reviewed by Michael Catanzaro.
186
187         * MiniBrowser/gtk/BrowserWindow.c:
188         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
189         which caused the body of the if-clause to be accidentally empty.
190
191 2017-05-31  Keith Miller  <keith_miller@apple.com>
192
193         Reland r216808, underlying lldb bug has been fixed.
194         https://bugs.webkit.org/show_bug.cgi?id=172759
195
196         Unreviewed, relanding old patch. See: rdar://problem/31183352
197
198         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
199         (runThreadMessageTest):
200         (TEST):
201
202 2017-05-31  Matt Lewis  <jlewis3@apple.com>
203
204         Unreviewed, rolling out r217603.
205
206         This patch broke the internal builds.
207
208         Reverted changeset:
209
210         "Get <chrono> out of StdLibExtras.h"
211         https://bugs.webkit.org/show_bug.cgi?id=172744
212         http://trac.webkit.org/changeset/217603
213
214 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
215
216         Make ResourceLoadStatistics testing more reliable
217         https://bugs.webkit.org/show_bug.cgi?id=172730
218         <rdar://problem/32028373>
219
220         Reviewed by Andy Estes.
221
222         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
223         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
224
225         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
226         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
227
228 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
229
230         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
231         https://bugs.webkit.org/show_bug.cgi?id=172757
232
233         Reviewed by Xabier Rodriguez-Calvar.
234
235         When needed, add the jhbuild wrapper at the beginning of the array
236         that will be invoked to execute the run-jsc-stress-test or testapi
237         commands.
238
239         * Scripts/run-javascriptcore-tests:
240         (runJSCStressTests):
241         * Scripts/webkitdirs.pm:
242         (shouldUseJhbuild):
243
244 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
245
246         Get <chrono> out of StdLibExtras.h
247         https://bugs.webkit.org/show_bug.cgi?id=172744
248
249         Reviewed by Saam Barati.
250
251         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
252
253 2017-05-30  Tim Horton  <timothy_horton@apple.com>
254
255         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
256         https://bugs.webkit.org/show_bug.cgi?id=172735
257         <rdar://problem/32015977>
258
259         Reviewed by Enrica Casucci.
260
261         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
262         (WTR::UIScriptController::applyAutocorrection):
263         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
264         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
265         (WTR::UIScriptController::applyAutocorrection):
266         * TestRunnerShared/UIScriptContext/UIScriptController.h:
267         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
268         (WTR::UIScriptController::applyAutocorrection):
269         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
270         because I don't know how to tap the button in the autocorrection bar from a test.
271
272 2017-05-30  Daniel Bates  <dabates@apple.com>
273
274         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
275         https://bugs.webkit.org/show_bug.cgi?id=172671
276
277         Reviewed by Alex Christensen.
278
279         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
280         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
281
282         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
283         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
284         to trigger a navigation to test it.
285         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
286         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
287
288 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
289
290         webkitpy: Start servers before setting-up for testing
291         https://bugs.webkit.org/show_bug.cgi?id=172176
292         <rdar://problem/32225538>
293
294         Reviewed by Alexey Proskuryakov.
295
296         On-device testing requires that servers are started before ports set-up their
297         test environments.
298
299         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
300         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
301         Servers are unconditionally stopped on exit.
302         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
303         Manager now stops servers.
304         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
305         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
306         * Scripts/webkitpy/layout_tests/controllers/manager.py:
307         (Manager.__init__): Delay construction of the test runner until we can determine
308         if servers need to be started.
309         (Manager.run): Determine if servers need to be started and construct the test runner.
310         Shut servers down when the test run is finished.
311         (Manager._run_tests): Move the determination of servers to run into Manager.run.
312         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
313         (is_wpt_server_running): Server is not running if no config is found.
314         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
315         (PyWebSocket.is_running): Check if this WebSocket server is running.
316         * Scripts/webkitpy/port/base.py:
317         (Port.__init__): Define secure WebSocket server.
318         (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
319
320 2017-05-30  Daniel Bates  <dabates@apple.com>
321
322         [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
323         https://bugs.webkit.org/show_bug.cgi?id=172603
324         <rdar://problem/32471306>
325
326         Reviewed by Brady Eidson.
327
328         Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
329         method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
330         unloading is initiated for a page that registered a onbeforeunload handler.
331
332         Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
333         is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
334         when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
335
336         Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
337         for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
338         as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
339         registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
340
341         * MiniBrowser/mac/WK2BrowserWindowController.m:
342         (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
343         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
344         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
345         (sawDialog):
346         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
347         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
348         (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
349
350 2017-05-30  Alex Christensen  <achristensen@webkit.org>
351
352         Update libwebrtc configuration
353         https://bugs.webkit.org/show_bug.cgi?id=172727
354
355         Reviewed by Geoffrey Garen.
356
357         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
358
359 2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
360
361         [WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
362         https://bugs.webkit.org/show_bug.cgi?id=172702
363
364         Reviewed by Alex Christensen.
365
366         EGL PlatformDisplay needs to be shut down before existing a
367         program on Windows.
368
369         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
370         (TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
371         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
372         (TestWebKitAPI::WebViewDestruction::TearDown): Ditto.
373
374 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
375
376         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
377         https://bugs.webkit.org/show_bug.cgi?id=172709
378
379         Reviewed by Brent Fulgham.
380
381         Exit fullscreen mode after a fullscreen test.
382
383         * DumpRenderTree/win/DumpRenderTree.cpp:
384         (resetWebViewToConsistentStateBeforeTesting):
385
386 2017-05-30  Antti Koivisto  <antti@apple.com>
387
388         ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
389         https://bugs.webkit.org/show_bug.cgi?id=172713
390
391         Reviewed by Zalan Bujtas.
392
393         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
394         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
395
396             Remove forced display from plugin resource load delegate. It is testing some long-obsolete
397             Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
398             because on Mac WK1 it may get invoked from middle of a layout.
399
400             Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
401
402 2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
403
404         Add a WPE EWS queue
405         https://bugs.webkit.org/show_bug.cgi?id=172693
406
407         Reviewed by Carlos Garcia Campos.
408
409         * QueueStatusServer/config/queues.py:
410         * QueueStatusServer/model/queues.py: Capitalize the name of the
411         port on the tooltip of the bubbles. Do the same for the GTK port.
412         (Queue.display_name):
413         * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
414         for the GTK+ EWS also. Set for both ports as watcher the alias
415         bugs-noreply@webkitgtk.org that maintainers of both ports follow.
416         * Scripts/webkitpy/common/config/ports.py:
417         (DeprecatedPort.port):
418         (WpePort):
419         (WpePort.build_webkit_command):
420         (WpePort.run_webkit_tests_command):
421         * Scripts/webkitpy/common/config/ports_unittest.py:
422         (DeprecatedPortTest):
423         (DeprecatedPortTest.test_wpe_port):
424         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
425         (test_ews_name):
426
427 2017-05-29  Zan Dobersek  <zdobersek@igalia.com>
428
429         Unreviewed. Bumping the WPEBackend-mesa dependency version.
430
431         * wpe/jhbuild.modules: Use the latest version that uses proper GLib
432         priorities for IPC communication.
433
434 2017-05-27  Yusuke Suzuki  <utatane.tea@gmail.com>
435
436         [JSC] Map and Set constructors should have fast path for cloning
437         https://bugs.webkit.org/show_bug.cgi?id=172413
438
439         Reviewed by Saam Barati.
440
441         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
442         (TestWebKitAPI::TEST):
443
444 2017-05-27  Zalan Bujtas  <zalan@apple.com>
445
446         enclosingIntRect returns a rect with -1 width/height when the input FloatRect overflows integer.
447         https://bugs.webkit.org/show_bug.cgi?id=172676
448
449         Reviewed by Simon Fraser.
450
451         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
452         (TestWebKitAPI::TEST):
453
454 2017-05-26  Zalan Bujtas  <zalan@apple.com>
455
456         TestWebKitAPI: EnclosingIntRect and RoundedIntRect should use EXPECT_EQ.
457         https://bugs.webkit.org/show_bug.cgi?id=172674
458
459         Reviewed by Simon Fraser.
460
461         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
462         (TestWebKitAPI::TEST):
463
464 2017-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
465
466         Add test resources back into TestWebKitAPI Copy Resources phase
467
468         Rubber-stamped by Beth Dakin.
469
470         Add two files back into the Copy Resources phase after they were unintentionally
471         removed in r217447 and r217496.
472
473         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
474
475 2017-05-26  Beth Dakin  <bdakin@apple.com>
476
477         Media documents inside iframes should not get controls in the TouchBar unless the 
478         video is playing
479         https://bugs.webkit.org/show_bug.cgi?id=172620
480         -and corresponding-
481         rdar://problem/32165477
482
483         Reviewed by Jon Lee.
484
485         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
486         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
487         (TestWebKitAPI::TEST):
488         * TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Added.
489
490 2017-05-25  Joseph Pecoraro  <pecoraro@apple.com>
491
492         _WKUserStyleSheet and WKUserScript leak string data
493         https://bugs.webkit.org/show_bug.cgi?id=172583
494         <rdar://problem/32395209>
495
496         Reviewed by Sam Weinig.
497
498         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
499         We should not have been adopting an autoreleased object.
500
501 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
502
503         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
504         https://bugs.webkit.org/show_bug.cgi?id=172554
505         <rdar://problem/31247133>
506
507         Reviewed by Simon Fraser.
508
509         Previously, there was no way to make DumpRenderTree's views layer-backed. Unfortunately,
510         simply setting [WebView setWantsLayer:] is insufficient; turning it on and then off again
511         leaves some state around inside the NSWindow which isn't easily cleaned up. Instead,
512         we should just tear down and rebuild the window whenever we need a layer-backed WebView.
513         We can also use the "webkit-test-runner" header comment to trigger this new layer-backed
514         codepath.
515
516         * DumpRenderTree/TestOptions.h:
517         * DumpRenderTree/TestOptions.mm:
518         (TestOptions::TestOptions):
519         (TestOptions::webViewIsCompatibleWithOptions):
520         * DumpRenderTree/mac/DumpRenderTree.mm:
521         (shouldIgnoreWebCoreNodeLeaks):
522         (allowedFontFamilySet):
523         (-[DRTMockScroller rectForPart:]):
524         (-[DRTMockScroller drawKnob]):
525         (-[DRTMockScroller drawRect:]):
526         (createWebViewAndOffscreenWindow):
527         (initializeGlobalsFromCommandLineOptions):
528         (prepareConsistentTestingEnvironment):
529         (dumpRenderTree):
530         (dumpAudio):
531         (dumpHistoryItem):
532         (dumpBackForwardListForWebView):
533         (resetWebViewToConsistentStateBeforeTesting):
534         (WebThreadLockAfterDelegateCallbacksHaveCompleted):
535         (runTest):
536
537 2017-05-25  Sam Weinig  <sam@webkit.org>
538
539         [WebIDL] Use the term 'operation' more consistently
540         https://bugs.webkit.org/show_bug.cgi?id=172601
541
542         Reviewed by Chris Dumez.
543
544         We were using the term 'operation', a WebIDL term for function-like
545         constructs, inconsistently in the code generator. Now, when we use
546         'operation' when referring to the IDL concept (usually the object the
547         parser produces) and 'function' when referring to code being generated.
548
549         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
550         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
551
552 2017-05-25  Jer Noble  <jer.noble@apple.com>
553
554         Unreviewed build fix after r217447; only run test where JSC's ObjC API is available.
555
556         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
557
558 2017-05-25  Jer Noble  <jer.noble@apple.com>
559
560         System sleeps while playing to wireless target, ending stream.
561         https://bugs.webkit.org/show_bug.cgi?id=172541
562
563         Reviewed by Eric Carlson.
564
565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
566         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.html: Added.
567         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Added.
568         (-[MediaPlaybackSleepAssertionLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
569         (-[MediaPlaybackSleepAssertionPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
570         (TestWebKitAPI::simulateKeyDown):
571         (TestWebKitAPI::hasAssertionType):
572         (TestWebKitAPI::TEST):
573
574 2017-05-25  Commit Queue  <commit-queue@webkit.org>
575
576         Unreviewed, rolling out r217423 and r217424.
577         https://bugs.webkit.org/show_bug.cgi?id=172607
578
579         These caused an api failure on all testers. (Requested by
580         mlewis13 on #webkit).
581
582         Reverted changesets:
583
584         "REGRESSION (r216977): 4 leaks introduced in new
585         WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test"
586         https://bugs.webkit.org/show_bug.cgi?id=172558
587         http://trac.webkit.org/changeset/217423
588
589         "REGRESSION (r217423): Fix last-second typo in 'auto'"
590         http://trac.webkit.org/changeset/217424
591
592 2017-05-25  Joanmarie Diggs  <jdiggs@igalia.com>
593
594         [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
595         https://bugs.webkit.org/show_bug.cgi?id=172355
596
597         Reviewed by Chris Fleizach.
598
599         Add map ATK_ROLE_FOOTNOTE to "AXFootnote" and bump jhbuild minimum
600         versions of atk, at-spi2-core, and at-spi2-atk to 2.25.2 (the earliest
601         releases which support the new platform footnote accessibility role.
602
603         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
604         * gtk/jhbuild.modules:
605
606 2017-05-25  David Kilzer  <ddkilzer@apple.com>
607
608         REGRESSION (r217423): Fix last-second typo in 'auto'
609
610         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
611         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix typo.
612
613 2017-05-24  David Kilzer  <ddkilzer@apple.com>
614
615         REGRESSION (r216977): 4 leaks introduced in new WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test
616         <https://webkit.org/b/172558>
617
618         Reviewed by Sam Weinig.
619
620         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
621         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix the leaks.
622
623 2017-05-24  Don Olmstead  <don.olmstead@am.sony.com>
624
625         [CMake] Consolidate CMake code related to Cairo
626         https://bugs.webkit.org/show_bug.cgi?id=172568
627
628         Reviewed by Alex Christensen.
629
630         * DumpRenderTree/config.h:
631         * TestWebKitAPI/config.h:
632
633 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
634
635         Plumb additional image metadata to item providers when beginning data interaction on an image
636         https://bugs.webkit.org/show_bug.cgi?id=172536
637         <rdar://problem/32371300>
638
639         Reviewed by Beth Dakin.
640
641         Tweak existing image data interaction tests to check for suggested name and estimated size on the generated
642         source item providers.
643
644         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
645         (checkSuggestedNameAndEstimatedSize):
646         (TestWebKitAPI::TEST):
647
648 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
649
650         [Win] Create unique network storage session for each DRT.
651         https://bugs.webkit.org/show_bug.cgi?id=172540
652
653         Reviewed by Brent Fulgham.
654
655         During layout testing, each DRT instance should have its own network storage session.
656
657         * DumpRenderTree/win/DumpRenderTree.cpp:
658         (prepareConsistentTestingEnvironment):
659
660 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
661
662         Respect image UTIs when writing to item providers when beginning data interaction on an image
663         https://bugs.webkit.org/show_bug.cgi?id=172436
664         <rdar://problem/31786569>
665
666         Reviewed by Beth Dakin.
667
668         Tweaks existing unit tests and adds a new test for image data interaction. See WebCore ChangeLog for more
669         details.
670
671         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
672         * TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Added.
673         * TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Added.
674
675         Create a new test page containing a GIF and a file input.
676
677         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
678         (checkTypeIdentifierIsRegisteredAtIndex):
679         (TestWebKitAPI::TEST):
680
681 2017-05-23  Per Arne Vollan  <pvollan@apple.com>
682
683         [Win] Increase test timeout for slow tests.
684         https://bugs.webkit.org/show_bug.cgi?id=172449
685
686         Reviewed by Alexey Proskuryakov.
687
688         Instead of using a fixed timeout of 30 seconds for all tests, we should use the
689         timeout member in the TestRunner class.
690
691         * DumpRenderTree/win/TestRunnerWin.cpp:
692         (TestRunner::setWaitToDump):
693
694 2017-05-15  Matt Rajca  <mrajca@apple.com>
695
696         Replace autoplay events that fire at navigation with a DidAutoplayMediaPastThreshold event.
697         https://bugs.webkit.org/show_bug.cgi?id=172138
698
699         Reviewed by Alex Christensen.
700
701         Added API tests.
702
703         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
704         * TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Added.
705         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
706         (TEST):
707         * TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Added.
708
709 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
710
711         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
712         https://bugs.webkit.org/show_bug.cgi?id=172522
713         rdar://problem/31071812
714
715         Reviewed by Sam Weinig.
716
717         Remove NSWindowStyleMaskFullSizeContentView which is no longer referenced in code.
718         We set this in the .xib file now.
719
720         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
721
722 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
723
724         Snapshotting via -renderInContext: should do synchronous image decodes
725         https://bugs.webkit.org/show_bug.cgi?id=172485
726         rdar://problem/32276146
727
728         Reviewed by Tim Horton.
729
730         New API test.
731
732         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
733         * TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Added.
734         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
735         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
736         (TestWebKitAPI::getPixelIndex):
737         (TestWebKitAPI::TEST):
738
739 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
740
741         Remove dead ENABLE(FONT_LOAD_EVENTS) code
742         https://bugs.webkit.org/show_bug.cgi?id=172517
743
744         Rubber-stamped by Simon Fraser.
745
746         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
747
748 2017-05-23  Wenson Hsieh  <wenson_hsieh@apple.com>
749
750         Multiple links should be inserted separately when performing data interaction
751         https://bugs.webkit.org/show_bug.cgi?id=172489
752         <rdar://problem/31510832>
753
754         Reviewed by Dan Bernstein.
755
756         Adds a new test that performs data interaction in a contenteditable with multiple items containing URLs.
757
758         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
759         (TestWebKitAPI::TEST):
760
761 2017-05-23  Tim Horton  <timothy_horton@apple.com>
762
763         REGRESSION: API test WebKit2.WKObject is failing
764         https://bugs.webkit.org/show_bug.cgi?id=172497
765         <rdar://problem/31694641>
766
767         Reviewed by Geoff Garen.
768
769         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
770         (TestWebKitAPI::TEST):
771         Add a test that ensures that we pretend to at least be *some* kind of
772         NSString, which my first fix would not have passed.
773
774 2017-05-23  youenn fablet  <youenn@apple.com>
775
776         There should be an easy way to run HTTP/WPT served tests on a browser
777         https://bugs.webkit.org/show_bug.cgi?id=172068
778
779         Reviewed by Sam Weinig.
780
781         Adding a new script open-layout-test to open a layout-test in a
782         browser and making sure it is served as done through run-webkit-tests.
783         In case tests should be run using a server, detecting whether the
784         server are running. If not, calling run-webkit-httpd to run the
785         servers and open the URL in a browser.
786         Otherwise, open directly the URL.
787
788         Adding an option in run-webkit-httpd to open an URL after having
789         started the servers.
790
791         Adding the --no-http-servers option in run-webkit-tests to not start any HTTP server.
792         This allows running run-webkit-httpd once and not having to restart
793         servers everytime a test should be served.
794
795         Moving most of run-webkit-httpd logic in its own python file to reuse
796         it in open-layout-test script.
797
798         Adding routines to check whether HTTP and WPT servers are running.
799
800         * Scripts/open-layout-test: Added.
801         (parse_args):
802         (main):
803         * Scripts/run-webkit-httpd:
804         (main):
805         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
806         (LayoutTestFinder.find_tests):
807         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
808         (LayoutTestRunner.run_tests):
809         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
810         (parse_args):
811         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
812         (HttpServerBase._is_server_running_on_all_ports):
813         (HttpServerBase):
814         (HttpServerBase._is_running_on_port):
815         (HttpServerBase._check_that_all_ports_are_available):
816         (is_http_server_running):
817         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py: Copied from Tools/Scripts/run-webkit-httpd.
818         (parse_args):
819         (main):
820         (run_server):
821         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
822         (is_wpt_server_running):
823         * Scripts/webkitpy/port/base.py:
824         (Port.to.is_http_server_running):
825         (Port.to):
826         (Port.to.is_wpt_server_running):
827         (Port.to.start_web_platform_test_server):
828         * Scripts/webkitpy/port/driver.py:
829         (DriverProxy.is_web_platform_test):
830         (DriverProxy):
831         (DriverProxy.is_webkit_specific_web_platform_test):
832
833 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
834
835         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
836         https://bugs.webkit.org/show_bug.cgi?id=171984
837
838         Reviewed by Antti Koivisto.
839
840         * DumpRenderTree/mac/DumpRenderTree.mm:
841         (enableExperimentalFeatures):
842         * WebKitTestRunner/TestController.cpp:
843         (WTR::TestController::resetPreferencesToConsistentValues):
844
845 2017-05-20  Alex Christensen  <achristensen@webkit.org>
846
847         REGRESSION(r215686): O(n^2) algorithm in CachedRawResource::addDataBuffer
848         https://bugs.webkit.org/show_bug.cgi?id=172406
849         <rdar://32109532>
850
851         Reviewed by Brady Eidson.
852
853         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
854         (TestWebKitAPI::checkBuffer):
855         (TestWebKitAPI::TEST_F):
856
857 2017-05-22  Jason Marcell  <jmarcell@apple.com>
858
859         Do not enter Subversion-specific logic when parsing Git-based Trac data.
860         https://bugs.webkit.org/show_bug.cgi?id=172433
861         <rdar://problem/32234188>
862
863         Reviewed by Alexey Proskuryakov.
864
865         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
866         (Trac.prototype._convertCommitInfoElementToObject):
867
868 2017-05-22  Tim Horton  <timothy_horton@apple.com>
869
870         ExplicitSnapshotsChangeUponNavigation API test often fails
871         https://bugs.webkit.org/show_bug.cgi?id=172475
872         <rdar://problem/31688322>
873
874         Reviewed by Simon Fraser.
875
876         * TestWebKitAPI/cocoa/TestWKWebView.mm:
877         (-[TestWKWebView _setUpTestWindow:]):
878         Make TestWKWebView's window layer-backed. This is now the default,
879         and it's also easy to accidentally write a test that depends on it
880         (for example, ExplicitSnapshotsChangeUponNavigation adds an NSBox,
881         which becomes layer backed, just like the WKWebView, but with no
882         common layer-backed ancestor).
883
884 2017-05-22  youenn fablet  <youenn@apple.com>
885
886         Resync web-platform-tests up to 8df7c9c215678328212f232ce0b5270c505a8563
887         https://bugs.webkit.org/show_bug.cgi?id=172426
888
889         Reviewed by Chris Dumez.
890
891         * Scripts/webkitpy/w3c/test_importer.py:
892         (TestImporter.remove_deleted_files): Outputting warning when trying to delete a file that no longer exists.
893
894 2017-05-22  Konstantin Tokarev  <annulen@yandex.ru>
895
896         Unreviewed, change my status to reviewer and fill "expertise" field
897
898         * Scripts/webkitpy/common/config/contributors.json:
899
900 2017-05-22  Tomas Popela  <tpopela@redhat.com>
901
902         Remove some of the EFL port leftovers
903         https://bugs.webkit.org/show_bug.cgi?id=172440
904
905         Reviewed by Carlos Garcia Campos.
906
907         * BuildSlaveSupport/built-product-archive:
908         (archiveBuiltProduct):
909         (extractBuiltProduct):
910         * BuildSlaveSupport/test-result-archive:
911         (archiveTestResults):
912         * ImageDiff/PlatformEfl.cmake: Removed.
913         * Scripts/run-efl-tests: Removed.
914         * Scripts/webkit-build-directory:
915         * Scripts/webkitpy/common/config/contributionareas.py:
916         * Scripts/webkitpy/common/config/watchlist:
917         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
918         (parse_args):
919         (_set_up_derived_options):
920         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
921         (PerfTestsRunner.__init__):
922         * Scripts/webkitpy/style/checker.py:
923         * Scripts/webkitpy/style/checker_unittest.py:
924         (GlobalVariablesTest.test_path_rules_specifier):
925         * gtk/manifest.txt.in:
926         * jhbuild/jhbuild-wrapper:
927
928 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
929
930         Unreviewed. Do not include WPE files in GTK+ tarballs.
931
932         * gtk/manifest.txt.in:
933
934 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
935
936         [GTK] Add webkit_context_menu_item_new_from_gaction
937         https://bugs.webkit.org/show_bug.cgi?id=159631
938
939         Reviewed by Michael Catanzaro.
940
941         Update context menu tests to check the new GAction API.
942
943         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
944         (testContextMenuPopulateMenu):
945
946 2017-05-21  Michael Catanzaro  <mcatanzaro@igalia.com>
947
948         [GTK] Remove Firefox user agent quirk for Google domains
949         https://bugs.webkit.org/show_bug.cgi?id=171941
950
951         Reviewed by Carlos Garcia Campos.
952
953         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
954         (TestWebKitAPI::TEST):
955         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk): Deleted.
956
957 2017-05-20  Ting-Wei Lan  <lantw44@gmail.com>
958
959         [GTK] gtkdoc-fixxref needs --module argument to work
960         https://bugs.webkit.org/show_bug.cgi?id=172415
961
962         Reviewed by Michael Catanzaro.
963
964         * gtk/gtkdoc.py:
965         (GTKDoc._run_gtkdoc_fixxref):
966
967 2017-05-20  Alexey Proskuryakov  <ap@apple.com>
968
969         make-new-script-test should create tests that use js-test.js, not js-test-pre.js
970         https://bugs.webkit.org/show_bug.cgi?id=172416
971
972         Reviewed by Daniel Bates.
973
974         * Scripts/make-new-script-test:
975
976 2017-05-19  Fujii Hironori  <Hironori.Fujii@sony.com>
977
978         [Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib
979         https://bugs.webkit.org/show_bug.cgi?id=172267
980
981         Reviewed by Per Arne Vollan.
982
983         TestWebCoreLib and TestWebKitLib have linked both WebCore and WebKit.
984         TestWebCoreLib should link only with WebCore. And, TestWebKitLib
985         should link only with WebKit.
986
987         Unfortunately, there is a layer violation at the moment.
988         WebCore::Image::loadPlatformResource needs loadResourceIntoBuffer
989         in WebKit. This change contains a stub of loadResourceIntoBuffer
990         in TestWebCoreLib for the workaround.
991
992         * TestWebKitAPI/PlatformWin.cmake: Do not link WebKit to
993         TestWebCoreLib. Do not link WebCore to TestWebKitLib.
994         * TestWebKitAPI/win/TestWebCoreStubs.cpp: Added.
995         (loadResourceIntoBuffer): Added a stub.
996
997 2017-05-19  Simon Fraser  <simon.fraser@apple.com>
998
999         Fix dump-class-layout to handle different file architectures
1000         https://bugs.webkit.org/show_bug.cgi?id=172392
1001
1002         Reviewed by Zalan Bujtas.
1003
1004         Instead of using lldb.LLDB_ARCH_DEFAULT by default, run 'file' on the binary
1005         and use the first architecture reported. Also add a "--architecture" argument
1006         to allow the user to specify an architecture.
1007
1008         * Scripts/dump-class-layout:
1009         (import_lldb):
1010         (verify_type_recursive):
1011         (get_first_file_architecture):
1012         (dump_class):
1013         (main):
1014         (find_build_directory): Deleted.
1015
1016 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
1017
1018         Unreviewed infrastructure fix.
1019
1020         * Scripts/webkitpy/port/ios_simulator.py:
1021         (IOSSimulatorPort._create_devices): Ignore failure to open Simulator.app.
1022
1023 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
1024
1025         webkitpy: Use simctl boot to run multiple simulators at once
1026         https://bugs.webkit.org/show_bug.cgi?id=172374
1027
1028         Reviewed by Alexey Proskuryakov.
1029
1030         * Scripts/webkitpy/common/system/platforminfo.py:
1031         (PlatformInfo.xcode_version): Return the current version of Xcode.
1032         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1033         (MockPlatformInfo.xcode_version): Return version 8.0 for testing.
1034         * Scripts/webkitpy/port/ios_simulator.py:
1035         (IOSSimulatorPort.use_multiple_simulator_apps): Return true if we need to
1036         run multiple Simulator.app instances.
1037         (IOSSimulatorPort._create_simulators): Only copy the simulator app for older
1038         versions of Xcode.
1039         (IOSSimulatorPort._create_devices): Use 'simctl boot' directly unless using
1040         an older version of Xcode.
1041
1042 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1043
1044         Unreviewed, fix the build on the latest internal SDK.
1045
1046         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1047         (TestWebKitAPI::TEST):
1048
1049 2017-05-19  Filip Pizlo  <fpizlo@apple.com>
1050
1051         arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
1052         https://bugs.webkit.org/show_bug.cgi?id=172369
1053
1054         Reviewed by Mark Lam.
1055         
1056         Because I wrote a test that relies on the NoCJIT config scribbling free cells, I thought it
1057         would be a good idea to write this down.
1058
1059         * Scripts/run-jsc-stress-tests:
1060
1061 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
1062
1063         webkitpy: Layout tests which have no output will succeed
1064         https://bugs.webkit.org/show_bug.cgi?id=172322
1065         <rdar://problem/32258350>
1066
1067         Reviewed by David Kilzer.
1068
1069         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1070         (SingleTestRunner._compare_text): Add FailreNotTested to failures if test has no output.
1071         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1072         (determine_result_type): FailureNotTested means that the test could not be loaded. This
1073         is classified as a MISSING failure.
1074         (FailureNotTested): Added.
1075         (FailureNotTested.message):
1076
1077 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1078
1079         Add SixSpeed benchmark to PerformanceTests
1080         https://bugs.webkit.org/show_bug.cgi?id=172326
1081
1082         Reviewed by Sam Weinig.
1083
1084         * Scripts/run-jsc-benchmarks:
1085
1086 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1087
1088         [WK1] MiniBrowser should navigate when handling a dropped URL
1089         https://bugs.webkit.org/show_bug.cgi?id=172350
1090
1091         Reviewed by Tim Horton.
1092
1093         Allow all drop actions, including URL navigation, for WebKit1 MiniBrowser.
1094
1095         * MiniBrowser/mac/WK1BrowserWindowController.m:
1096         (-[WK1BrowserWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
1097
1098 2017-05-18  Ryosuke Niwa  <rniwa@webkit.org>
1099
1100         REGRESSION (r216694 - 216712): Performance test Speedometer/Full.html is failing
1101         https://bugs.webkit.org/show_bug.cgi?id=172077
1102
1103         Reviewed by Chris Dumez.
1104
1105         Fixed perftest.py by updating the lines to ignore in Speedometer.
1106
1107         Also start report the results as "Speedometer" instead of "DoYouEvenBench/Full.html" to perf.webkit.org.
1108
1109         * Scripts/webkitpy/performance_tests/perftest.py:
1110         (PerfTest._lines_to_ignore_in_parser_result): Updated for Speedometer 2.0.
1111         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1112         (PerfTestsRunner._collect_tests): Use "Speedometer" instead of "Speedometer/index.html" as the test name.
1113         (_generate_results_dict): Removed the workaround to keep reporting Speedometer as DoYouEvenBench.
1114         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1115         (MainTest.test_collect_tests_with_index_html_and_resources): Added.
1116
1117 2017-05-18  Andy Estes  <aestes@apple.com>
1118
1119         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
1120         https://bugs.webkit.org/show_bug.cgi?id=172305
1121
1122         Reviewed by Anders Carlsson.
1123
1124         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1125
1126 2017-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1127
1128         Selection around attachment elements should not persist when beginning a drag
1129         https://bugs.webkit.org/show_bug.cgi?id=172319
1130         <rdar://problem/32283008>
1131
1132         Reviewed by Tim Horton.
1133
1134         Tests that temporary selection around an attachment does not persist longer than it needs to.
1135
1136         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1137         (TestWebKitAPI::TEST):
1138
1139 2017-05-18  John Wilander  <wilander@apple.com>
1140
1141         Resource Load Statistics: Grandfather domains for existing data records
1142         https://bugs.webkit.org/show_bug.cgi?id=172155
1143         <rdar://problem/24913532>
1144
1145         Reviewed by Alex Christensen.
1146
1147         Adds test infrastructure needed for the added functionality.
1148
1149         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1150         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1151         (WTR::InjectedBundle::didReceiveMessageToPage):
1152         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1153         (WTR::TestRunner::setStatisticsGrandfathered):
1154         (WTR::TestRunner::isStatisticsGrandfathered):
1155         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1156         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
1157         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1158         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1159         * WebKitTestRunner/TestController.cpp:
1160         (WTR::TestController::setStatisticsGrandfathered):
1161         (WTR::TestController::isStatisticsGrandfathered):
1162         (WTR::TestController::setStatisticsGrandfatheringTime):
1163         * WebKitTestRunner/TestController.h:
1164         * WebKitTestRunner/TestInvocation.cpp:
1165         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1166
1167 2017-05-18  Saam Barati  <sbarati@apple.com>
1168
1169         WebAssembly: perform stack checks
1170         https://bugs.webkit.org/show_bug.cgi?id=165546
1171         <rdar://problem/29760307>
1172
1173         Reviewed by Filip Pizlo.
1174
1175         Add some new testing modes for using and not using fast TLS wasm contexts.
1176
1177         * Scripts/run-jsc-stress-tests:
1178
1179 2017-05-18  Daniel Bates  <dabates@apple.com>
1180
1181         REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent
1182         window CSP when object-src 'none' is set
1183         https://bugs.webkit.org/show_bug.cgi?id=172038
1184         <rdar://problem/32258262>
1185
1186         Reviewed by Andy Estes.
1187
1188         Teach the test Netscape plugin to look for a URL that contains plugin-document-alert-and-notify-done.pl.
1189         When it sees this URL it will show a JavaScript alert and call testRunner.notifyDone().
1190
1191         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1192         (NPP_New):
1193
1194 2017-05-18  Per Arne Vollan  <pvollan@apple.com>
1195
1196         [Win] Many layout tests are failing.
1197         https://bugs.webkit.org/show_bug.cgi?id=172286
1198
1199         Reviewed by Brent Fulgham.
1200
1201         Add a FIXME comment about unimplemented functions, instead of writing this to the test result file.
1202  
1203         * DumpRenderTree/win/TestRunnerWin.cpp:
1204         (TestRunner::grantWebNotificationPermission):
1205         (TestRunner::denyWebNotificationPermission):
1206         (TestRunner::removeAllWebNotificationPermissions):
1207         (TestRunner::simulateWebNotificationClick):
1208
1209 2017-05-18  Don Olmstead  <don.olmstead@am.sony.com>
1210
1211         [Win] Remove usage of _snprintf
1212         https://bugs.webkit.org/show_bug.cgi?id=172251
1213
1214         Reviewed by Per Arne Vollan.
1215
1216         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1217         * MiniBrowser/win/PageLoadTestClient.cpp:
1218         (PageLoadTestClient::dumpRunStatistics):
1219
1220 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
1221
1222         Unreviewed, rolling out r217014.
1223
1224         This change caused mac-wk2 LayoutTests to exit early due to
1225         crashes.
1226
1227         Reverted changeset:
1228
1229         "Resource Load Statistics: Grandfather domains for existing
1230         data records"
1231         https://bugs.webkit.org/show_bug.cgi?id=172155
1232         http://trac.webkit.org/changeset/217014
1233
1234 2017-05-17  John Wilander  <wilander@apple.com>
1235
1236         Resource Load Statistics: Grandfather domains for existing data records
1237         https://bugs.webkit.org/show_bug.cgi?id=172155
1238         <rdar://problem/24913532>
1239
1240         Reviewed by Alex Christensen.
1241
1242         Adds test infrastructure needed for the added functionality.
1243
1244         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1245         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1246         (WTR::InjectedBundle::didReceiveMessageToPage):
1247         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1248         (WTR::TestRunner::setStatisticsGrandfathered):
1249         (WTR::TestRunner::isStatisticsGrandfathered):
1250         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1251         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
1252         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1253         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1254         * WebKitTestRunner/TestController.cpp:
1255         (WTR::TestController::setStatisticsGrandfathered):
1256         (WTR::TestController::isStatisticsGrandfathered):
1257         (WTR::TestController::setStatisticsGrandfatheringTime):
1258         * WebKitTestRunner/TestController.h:
1259         * WebKitTestRunner/TestInvocation.cpp:
1260         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1261
1262 2017-05-17  Alex Christensen  <achristensen@webkit.org>
1263
1264         Fix ios-simulator API test after r216977
1265         https://bugs.webkit.org/show_bug.cgi?id=171987
1266
1267         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1268         (TEST):
1269         <rdar://problem/32260156> covers the investigation of this, but fixing it is 
1270         not as urgent as having the rest of this working. Notably the ephemeral part of the
1271         test works, so something is just wrong with the persistent part.
1272
1273 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
1274
1275         Unreviewed, rolling out r216955.
1276
1277         This change caused strange behavior with web-platform-tests
1278         locally and on EWS.
1279
1280         Reverted changeset:
1281
1282         "webkitpy: Start servers before setting-up for testing"
1283         https://bugs.webkit.org/show_bug.cgi?id=172176
1284         http://trac.webkit.org/changeset/216955
1285
1286 2017-05-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1287
1288         A URL type is vended for a non-URL plain text string when starting data interaction
1289         https://bugs.webkit.org/show_bug.cgi?id=172228
1290         <rdar://problem/32166729>
1291
1292         Reviewed by Andy Estes.
1293
1294         Adds two new data interaction tests, SinglePlainTextWordTypeIdentifiers and SinglePlainTextURLTypeIdentifiers,
1295         to verify that a URL UTI is not vended when beginning a data interaction on a single word, but that a URL is
1296         still vended when beginning data interaction on something that resembles a link.
1297
1298         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1299
1300 2017-05-17  David Kilzer  <ddkilzer@apple.com>
1301
1302         BlobDataFileReference::generateReplacementFile() should use mkstemp()
1303         <https://webkit.org/b/172192>
1304
1305         Reviewed by Brent Fulgham.
1306
1307         * Scripts/webkitpy/style/checkers/cpp.py:
1308         (check_language): Add check for mktemp.
1309         (CppChecker): Add 'security/temp_file' category.
1310         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1311         (CppStyleTest.test_insecure_temp_file): Add test.
1312
1313 2017-05-17  Devin Rousso  <drousso@apple.com>
1314
1315         Unreviewed, change my email.
1316
1317         * Scripts/webkitpy/common/config/contributors.json:
1318
1319 2017-05-17  Matt Lewis  <jlewis3@apple.com>
1320
1321         Unreviewed, rolling out r216974.
1322
1323         Revision caused consistent timeouts on all platforms.
1324
1325         Reverted changeset:
1326
1327         "Add a RuntimeEnabledFeature for display: contents, defaulted
1328         to false."
1329         https://bugs.webkit.org/show_bug.cgi?id=171984
1330         http://trac.webkit.org/changeset/216974
1331
1332 2017-05-17  Alex Christensen  <achristensen@webkit.org>
1333
1334         Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessPools should affect cookies used
1335         https://bugs.webkit.org/show_bug.cgi?id=171987
1336
1337         Reviewed by Brady Eidson.
1338
1339         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1340         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1341         (TEST):
1342
1343 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
1344
1345         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
1346         https://bugs.webkit.org/show_bug.cgi?id=171984
1347
1348         Reviewed by Antti Koivisto.
1349
1350         * DumpRenderTree/mac/DumpRenderTree.mm:
1351         (enableExperimentalFeatures):
1352         * WebKitTestRunner/TestController.cpp:
1353         (WTR::TestController::resetPreferencesToConsistentValues):
1354
1355 2017-05-16  Timothy Horton  <timothy_horton@apple.com>
1356
1357         Fix the build
1358
1359         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1360         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1361
1362 2017-05-16  Tim Horton  <timothy_horton@apple.com>
1363
1364         PageVisibilityStateWithWindowChanges tests sometimes time out
1365         https://bugs.webkit.org/show_bug.cgi?id=172202
1366         <rdar://problem/29653266>
1367
1368         Reviewed by Dean Jackson.
1369
1370         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1371         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1372         Make sure the window is miniaturizable, otherwise, in some cases, miniaturize: will not work.
1373
1374 2017-05-16  Jonathan Bedard  <jbedard@apple.com>
1375
1376         webkitpy: Start servers before setting-up for testing
1377         https://bugs.webkit.org/show_bug.cgi?id=172176
1378         <rdar://problem/32225538>
1379
1380         Reviewed by Alexey Proskuryakov.
1381
1382         On-device testing requires that servers are started before ports set-up their
1383         test environments.
1384
1385         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1386         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
1387         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer.
1388         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1389         (Manager.__init__): Delay construction of the test runner until we can determine
1390         if servers need to be started.
1391         (Manager.run): Determine if servers need to be started and construct the test runner.
1392         (Manager._run_tests): Move the determination of servers to run into Manager.run.
1393
1394 2017-05-16  Adrian Perez de Castro  <aperez@igalia.com>
1395
1396         Unreviewed, adding myself to contributors.json
1397
1398         * Scripts/webkitpy/common/config/contributors.json:
1399
1400 2017-05-16  Claudio Saavedra  <csaavedra@igalia.com>
1401
1402         [GTK] Tests that always pass when run alone, but fail in the bots
1403         https://bugs.webkit.org/show_bug.cgi?id=168572
1404
1405         Reviewed by Michael Catanzaro.
1406
1407         PlatformWebView::viewSupportsOptions() is basically a comparison
1408         that checks that the passed options are the ones supported by the
1409         web view. There is no reason for them to be implemented for each
1410         platform differently. In fact doing so causes issues each time a
1411         new option is added, if the corresponding platform implementation
1412         is not updated accordingly.
1413
1414         A consequence of not updating the viewSupportOptions()
1415         implementations when new options are added is that tests that need
1416         these options might fail if they are executed after a test that
1417         didn't need the option, as the webview will be reused even if the
1418         option is not supported. This cannot be spotted when running the
1419         tests individually. See bug #165133 for other example of the same
1420         problem.
1421
1422         Remove the platform implementations and make the comparison a
1423         method of the TestOptions structure, so that the check is in one
1424         place. For the time being, only include in the comparison the
1425         options that were checked in the mac platform, which seem to be
1426         the only ones relevant this far (unless newer ones have also been
1427         forgotten).
1428
1429         * WebKitTestRunner/PlatformWebView.h:
1430         (WTR::PlatformWebView::viewSupportsOptions): Use the method
1431         defined below.
1432         * WebKitTestRunner/TestOptions.h:
1433         (WTR::TestOptions::hasSameInitializationOptions): Added.
1434         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1435         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
1436         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1437         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
1438         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1439         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
1440         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
1441         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
1442
1443 2017-05-15  Yusuke Suzuki  <utatane.tea@gmail.com>
1444
1445         [JSC] Build testapi in non Apple ports
1446         https://bugs.webkit.org/show_bug.cgi?id=172103
1447
1448         Reviewed by Filip Pizlo.
1449
1450         Now testapi is drived in JSCOnly, GTK and WPE ports too.
1451
1452         * Scripts/build-jsc:
1453         * Scripts/run-javascriptcore-tests:
1454
1455 2017-05-15  Youenn Fablet  <youenn@apple.com>
1456
1457         WPT test importer should not account for slow manual tests
1458         https://bugs.webkit.org/show_bug.cgi?id=172127
1459
1460         Reviewed by Ryosuke Niwa.
1461
1462         Making sure manual tests are not triggering updating tests-options.json file.
1463
1464         * Scripts/webkitpy/w3c/test_importer.py:
1465         (TestImporter.find_importable_tests):
1466         (TestImporter._already_identified_as_resource_file):
1467         (TestImporter.update_tests_options):
1468         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1469         (test_manual_slow_test):
1470
1471 2017-05-15  Jonathan Bedard  <jbedard@apple.com>
1472
1473         webkitpy: Some versions of simctl do not place parenthesis around runtime identifiers
1474         https://bugs.webkit.org/show_bug.cgi?id=172142
1475
1476         Reviewed by Tim Horton.
1477
1478         * Scripts/webkitpy/xcode/simulator.py:
1479         (Simulator._parse_runtimes): Newer versions of simctl output do not put parenthesis
1480         around runtime identifiers.
1481         * Scripts/webkitpy/xcode/simulator_unittest.py: Add tests for new simctl output.
1482
1483 2017-05-15  Ryosuke Niwa  <rniwa@webkit.org>
1484
1485         Update ARES-6 plan file to use the latest version
1486         https://bugs.webkit.org/show_bug.cgi?id=172139
1487
1488         Reviewed by Keith Miller.
1489
1490         Include r216538.
1491
1492         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
1493
1494 2017-05-15  Jeremy Jones  <jeremyj@apple.com>
1495
1496         Disable Picture In Picture API tests on unsupported platforms.
1497         https://bugs.webkit.org/show_bug.cgi?id=172125
1498         rdar://problem/32199477
1499
1500         Reviewed by Simon Fraser.
1501
1502         The callbacks and allowing picture-in-picture require new SPI.
1503
1504         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
1505
1506 2017-05-15  Brady Eidson  <beidson@apple.com>
1507
1508         [ios-simulator] API test WKWebView.ClearAppCache is failing.
1509         https://bugs.webkit.org/show_bug.cgi?id=172120
1510
1511         Unreviewed test gardening.
1512
1513         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1514         (TEST): ios-sim needs explicit deleting of the app cache paths that I'd removed in 216805.
1515           Restoring that code fixes this.
1516
1517 2017-05-15  Timothy Horton  <timothy_horton@apple.com>
1518
1519         Null deref under WebContentReader::readURL when interacting with a file URL
1520         https://bugs.webkit.org/show_bug.cgi?id=172045
1521         <rdar://problem/25880647>
1522
1523         Reviewed by Wenson Hsieh.
1524
1525         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1526         (TestWebKitAPI::TEST):
1527         The text of the file URL is pasted because a textual version of it gets
1528         onto the pasteboard. However, this test would have crashed before. Also
1529         tests that we don't make an <a>.
1530
1531 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
1532
1533         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
1534         https://bugs.webkit.org/show_bug.cgi?id=172071
1535
1536         Reviewed by Alexey Proskuryakov.
1537
1538         * DumpRenderTree/win/DumpRenderTree.cpp:
1539         (resetWebPreferencesToConsistentValues):
1540
1541 2017-05-14  Chris Dumez  <cdumez@apple.com>
1542
1543         Drop PassRefPtr class from WTF
1544         https://bugs.webkit.org/show_bug.cgi?id=172091
1545
1546         Reviewed by Alex Christensen.
1547
1548         Drop API test coverage.
1549
1550         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1551         (TestWebKitAPI::TEST):
1552         (TestWebKitAPI::passWithPassRefPtr): Deleted.
1553
1554 2017-05-13  Eric Carlson  <eric.carlson@apple.com>
1555
1556         [MediaStream] deviceId constraint doesn't work with getUserMedia
1557         https://bugs.webkit.org/show_bug.cgi?id=171877
1558         <rdar://problem/31899730>
1559
1560         Reviewed by Jer Noble.
1561
1562         The device ID hash salt is now required for getUserMedia to check deviceId constraint, so
1563         implement the "checkUserMediaPermission" callback.
1564         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1565         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
1566         (TestWebKitAPI::checkUserMediaPermissionCallback):
1567         (TestWebKitAPI::TEST):
1568
1569         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm:
1570         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1571
1572 2017-05-13  Chris Dumez  <cdumez@apple.com>
1573
1574         Stop using RefPtr::release()
1575         https://bugs.webkit.org/show_bug.cgi?id=172074
1576
1577         Reviewed by Geoffrey Garen.
1578
1579         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1580         (TestWebKitAPI::TEST):
1581
1582 2017-05-13  Commit Queue  <commit-queue@webkit.org>
1583
1584         Unreviewed, rolling out r216808.
1585         https://bugs.webkit.org/show_bug.cgi?id=172075
1586
1587         caused lldb to hang when debugging (Requested by smfr on
1588         #webkit).
1589
1590         Reverted changeset:
1591
1592         "Use Mach exceptions instead of signals where possible"
1593         https://bugs.webkit.org/show_bug.cgi?id=171865
1594         http://trac.webkit.org/changeset/216808
1595
1596 2017-05-12  Alex Christensen  <achristensen@webkit.org>
1597
1598         Rename WKContentExtension to WKContentRuleList
1599         https://bugs.webkit.org/show_bug.cgi?id=172053
1600         <rdar://problem/32141005>
1601
1602         Reviewed by Geoffrey Garen.
1603
1604         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm:
1605         (WKContentRuleListStoreTest::SetUp):
1606         (TEST_F):
1607         (-[ContentRuleListDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1608         (WKContentExtensionStoreTest::SetUp): Deleted.
1609         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
1610
1611 2017-05-12  Keith Miller  <keith_miller@apple.com>
1612
1613         Use Mach exceptions instead of signals where possible
1614         https://bugs.webkit.org/show_bug.cgi?id=171865
1615
1616         Reviewed by Mark Lam.
1617
1618         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
1619         (runThreadMessageTest):
1620         (TEST):
1621
1622 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
1623
1624         Add objc version of WK2 UIPageClient setHasVideoInPictureInPicture and rename it to hasVideoInPictureInPictureDidChange.
1625         https://bugs.webkit.org/show_bug.cgi?id=172048
1626         rdar://problem/32163054
1627
1628         Reviewed by Simon Fraser.
1629
1630         Add a WKWebView test for hasVideoInPictureInPictureDidChange UIDelegate callback.
1631
1632         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html:
1633         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
1634         (hasVideoInPictureInPictureDidChange):
1635         (-[PictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
1636         (-[PictureInPictureUIDelegate userContentController:didReceiveScriptMessage:]):
1637         (TestWebKitAPI::TEST):
1638
1639 2017-05-12  Brady Eidson  <beidson@apple.com>
1640
1641         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
1642         https://bugs.webkit.org/show_bug.cgi?id=172030
1643
1644         Unreviewed - Test gardening
1645
1646         Try to resolve this once and for all by using the WebsiteDataStore API to nuke everything
1647         before the test starts.
1648
1649         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1650         (defaultWebsiteCacheDirectory):
1651         (defaultApplicationCacheDirectory):
1652         (TEST):
1653         (defaultWebsiteDataDirectory): Deleted.
1654
1655 2017-05-12  David Quesada  <david_quesada@apple.com>
1656
1657         Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
1658         https://bugs.webkit.org/show_bug.cgi?id=172000
1659         rdar://problem/32144756
1660
1661         Reviewed by Simon Fraser.
1662
1663         Added API tests to verify that WKWebView provides the expected value for
1664         _visibleContentRect in various configurations. (i.e. not inside a scrollview,
1665         inside a scrollview but not clipped, clipped by an ancestor scrollview,
1666         clipped by the webview's _enclosingViewForExposedRectComputation)
1667
1668         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1669         * TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Added.
1670         (-[TestWKWebViewWithEnclosingView _enclosingViewForExposedRectComputation]):
1671         (TestWebKitAPI::TEST):
1672
1673 2017-05-12  Brady Eidson  <beidson@apple.com>
1674
1675         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
1676         https://bugs.webkit.org/show_bug.cgi?id=172030
1677
1678         Unreviewed - Test gardening, in effect...
1679
1680         More exploration as to why this continues to fail on the bots.
1681         
1682         This change should give us a smoking gun.
1683         
1684         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1685         (TEST):
1686
1687 2017-05-12  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1688
1689         [GTK] Fix compile warnings in PlatformImageCairo.cpp
1690         https://bugs.webkit.org/show_bug.cgi?id=171850
1691
1692         Reviewed by Michael Catanzaro.
1693
1694         * ImageDiff/cairo/PlatformImageCairo.cpp:
1695         (ImageDiff::PlatformImage::createFromStdin):
1696         (ImageDiff::PlatformImage::writeAsPNGToStdout):
1697
1698 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
1699
1700         Add UIClient callback for when picture-in-picture is activated.
1701         https://bugs.webkit.org/show_bug.cgi?id=172023
1702
1703         Reviewed by Simon Fraser.
1704
1705         Added a test for WKPageUIClientV10 setHasVideoInPictureInPicture.
1706
1707         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1708         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Added.
1709         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Added.
1710         (onLoadedCompletedCallback):
1711         (waitUntilOnLoadIsCompleted):
1712         (didFinishLoadForFrame):
1713         (setHasVideoInPictureInPicture):
1714         (TestWebKitAPI::TEST):
1715
1716 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
1717
1718         Unreviewed follow-up to r216776.
1719
1720         * Scripts/webkitpy/port/base.py:
1721         (Port.path_to_crash_logs): Raise not implemented.
1722         * Scripts/webkitpy/port/test.py:
1723         (TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
1724         * Scripts/webkitpy/port/win.py:
1725         (WinPort.path_to_crash_logs): Ditto.
1726
1727 2017-05-12  Alexey Proskuryakov  <ap@apple.com>
1728
1729         Bot watcher's dashboard shows results links twice sometimes
1730         https://bugs.webkit.org/show_bug.cgi?id=172043
1731
1732         Reviewed by Tim Horton.
1733
1734         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1735         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
1736
1737 2017-05-12  Brady Eidson  <beidson@apple.com>
1738
1739         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
1740         https://bugs.webkit.org/show_bug.cgi?id=172030
1741
1742         Unreviewed - Test gardening, in effect...
1743
1744         This failure is only being seen by the bots.
1745         
1746         I believe this test is utterly broken in the first place; when it checks the .wal file's
1747         size that is not actually an indicator that the records were deleted.
1748         
1749         But that isn't what's coming up as failure on the bots.
1750         
1751         This patch is an attempt to:
1752         1 - More forcefully clear the Website data directory of leftovers before the test starts.
1753         2 - Give an earlier indication of the failure that the bots are seeing, to possibly reveal more.
1754
1755         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1756         (defaultWebsiteDataDirectory):
1757         (defaultApplicationCacheDirectory):
1758         (TEST):
1759
1760 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
1761
1762         webkitpy: Pass directory with crash logs into CrashLogs
1763         https://bugs.webkit.org/show_bug.cgi?id=172033
1764         <rdar://problem/32157616>
1765
1766         Reviewed by Daniel Bates.
1767
1768         Refactor CrashLogs and the callers of CrashLogs so that the port object owns
1769         the location of crash logs.
1770
1771         * Scripts/webkitpy/common/system/crashlogs.py:
1772         (CrashLogs.__init__): Pass mandatory crash_log_directory when constructing.
1773         (CrashLogs._find_newest_log_darwin): Use self._crash_log_directory instead of
1774         generating one.
1775         (CrashLogs._find_newest_log_win): Use self._crash_log_directory instead of
1776         self._results_directory.
1777         (CrashLogs._find_all_logs_darwin): Use self._crash_log_directory instead of
1778         generating one.
1779         (CrashLogs._log_directory_darwin): Moved to port.
1780         * Scripts/webkitpy/common/system/crashlogs_unittest.py: Update tests since the path
1781         to the crash log is no longer owned by CrashLogs.
1782         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Use the general
1783         directory for uploading crash logs. Note that crash logs are only supported on Mac
1784         and Windows.
1785         * Scripts/webkitpy/port/apple.py: Remove unneeded CrashLogs import.
1786         * Scripts/webkitpy/port/base.py:
1787         (Port.path_to_crash_logs): Unless ports declare otherwise, crash logs are assumed
1788         to be in the results directory.
1789         * Scripts/webkitpy/port/darwin.py:
1790         (DarwinPort.path_to_crash_logs): Moved from CrashLogs._log_directory_darwin.
1791         (DarwinPort._look_for_all_crash_logs_in_log_dir): Use port specific crash log path.
1792         (DarwinPort._get_crash_log): Ditto.
1793         * Scripts/webkitpy/port/darwin_testcase.py:
1794         (DarwinTest.test_crashlog_path): Test that the Darwin ports are correctly calculating
1795         the path to crash logs.
1796         * Scripts/webkitpy/port/ios_device.py:
1797         (IOSDevicePort.path_to_crash_logs): Currently, crash log retrieval is undefined for iOS.
1798         * Scripts/webkitpy/port/ios_device_unittest.py:
1799         (IOSDeviceTest.test_crashlog_path): Currently, crash log retrieval is undefined for iOS.
1800         * Scripts/webkitpy/port/ios_simulator.py: Remove unneeded CrashLogs import.
1801         * Scripts/webkitpy/port/mac.py: Ditto.
1802         * Scripts/webkitpy/port/test.py:
1803         (TestDriver.run_test): Use port specific crash log path when retrieving crash logs.
1804         * Scripts/webkitpy/port/win.py:
1805         (WinPort._get_crash_log): Ditto.
1806         * Scripts/webkitpy/tool/commands/queries.py:
1807         (execute): Construct a port object since this is the object which owns the path to crash logs.
1808
1809 2017-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1810
1811         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/create-navigation-data after r216615.
1812
1813         In r216615 the custom code for window.open() was removed. The generated code now correctly handles the optional
1814         URL parameter using the default value "about:blank" when not provided.
1815
1816         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1817         (testWebViewCreateNavigationData):
1818
1819 2017-05-11  Youenn Fablet  <youenn@apple.com>
1820
1821         Allow WPT server to serve specific WebKit test
1822         https://bugs.webkit.org/show_bug.cgi?id=171479
1823
1824         Reviewed by Ryosuke Niwa.
1825
1826         Adding a new mount point to WPT server.
1827         It points to LayoutTests/http/wpt folder and is triggered on "/WebKit" urls.
1828
1829         Updating the webkitpy infrastructure to launch WPT server and do test url mapping for LayoutTests/wpt tests.
1830
1831         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1832         (Manager.__init__):
1833         (Manager._is_http_test):
1834         (Manager._needs_web_platform_test):
1835         (Manager._run_tests):
1836         (Manager._is_web_platform_test): Deleted.
1837         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1838         (build_routes):
1839         (main):
1840         * Scripts/webkitpy/port/driver.py:
1841         (Driver):
1842         (Driver.is_webkit_specific_web_platform_test):
1843         (Driver.test_to_uri):
1844         (Driver._command_from_driver_input):
1845
1846 2017-05-11  Brady Eidson  <beidson@apple.com>
1847
1848         [WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path.
1849         <rdar://problem/30612463> and https://bugs.webkit.org/show_bug.cgi?id=171994
1850
1851         Reviewed by Andy Estes.
1852         Informal review by Maureen Daum.
1853
1854         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1855         (TEST):
1856
1857 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
1858
1859         REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change
1860         https://bugs.webkit.org/show_bug.cgi?id=171989
1861
1862         Reviewed by Brian Burg.
1863
1864         * lldb/lldb_webkit.py:
1865         (WTFStringImplProvider.get_data8):
1866         (WTFStringImplProvider.get_data16):
1867         m_data8 and m_data16 are now part of the superclass StringImplShape
1868         instead of directly in StringImpl. So first get the shape by getting
1869         index 0, and the data properties are the same offset within that.
1870
1871 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
1872
1873         Remove Vibration API
1874         https://bugs.webkit.org/show_bug.cgi?id=171766
1875
1876         Rubber-stamped by Alexey Proskuryakov.
1877
1878         * Scripts/webkitperl/FeatureList.pm:
1879
1880 2017-05-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1881
1882         Add WPE release bots
1883         https://bugs.webkit.org/show_bug.cgi?id=171973
1884
1885         Reviewed by Žan Doberšek.
1886
1887         This adds a WPE Release Build bot (64-bit) and a WPE Release Test bot.
1888         It also adds a new WPE buildbot category.
1889
1890         * BuildSlaveSupport/build.webkit.org-config/config.json:
1891         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1892         (InstallWpeDependencies):
1893         (appendCustomBuildFlags):
1894         (Factory.__init__):
1895         (loadBuilderConfig):
1896         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1897         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1898
1899 2017-05-09  Sam Weinig  <sam@webkit.org>
1900
1901         Remove support for legacy Notifications
1902         https://bugs.webkit.org/show_bug.cgi?id=171487
1903
1904         Reviewed by Jon Lee.
1905
1906         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1907         (DRTDesktopNotificationPresenter::checkNotificationPermission):
1908         * Scripts/webkitperl/FeatureList.pm:
1909         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1910         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
1911
1912 2017-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1913
1914         Remove user agent quirk for Slack
1915         https://bugs.webkit.org/show_bug.cgi?id=171869
1916
1917         Reviewed by Carlos Garcia Campos.
1918
1919         Remove the corresponding test.
1920
1921         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1922         (TestWebKitAPI::TEST):
1923
1924 2017-05-10  Commit Queue  <commit-queue@webkit.org>
1925
1926         Unreviewed, rolling out r216578.
1927         https://bugs.webkit.org/show_bug.cgi?id=171920
1928
1929         Broke the GTK+ build with Wayland enabled (Requested by KaL on
1930         #webkit).
1931
1932         Reverted changeset:
1933
1934         "[GTK] Bump GTK+ and its dependencies in jhbuild"
1935         https://bugs.webkit.org/show_bug.cgi?id=171918
1936         http://trac.webkit.org/changeset/216578
1937
1938 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1939
1940         [GTK] Bump GTK+ and its dependencies in jhbuild
1941         https://bugs.webkit.org/show_bug.cgi?id=171918
1942
1943         Reviewed by Carlos Alberto Lopez Perez.
1944
1945         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1946         (WTR::initializeGtkSettings):
1947         * gtk/jhbuild.modules:
1948         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
1949         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
1950
1951 2017-05-10  Don Olmstead  <don.olmstead@am.sony.com>
1952
1953         [Win] Set CMake args in build-webkit
1954         https://bugs.webkit.org/show_bug.cgi?id=171436
1955
1956         Reviewed by Per Arne Vollan.
1957
1958         * Scripts/build-webkit:
1959
1960 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1961
1962         ImageDiff: Add CG implementation for new ImageDiff
1963         https://bugs.webkit.org/show_bug.cgi?id=170608
1964
1965         Reviewed Alex Christensen.
1966
1967         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1968         * DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
1969         * DumpRenderTree/win/ImageDiffWin.cpp: Removed.
1970         * ImageDiff/CMakeLists.txt:
1971         * ImageDiff/Cairo.cmake:
1972         * ImageDiff/ImageDiff.cpp:
1973         (main):
1974         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1975         * ImageDiff/PlatformImage.cpp:
1976         * ImageDiff/PlatformImage.h:
1977         * ImageDiff/cairo/PlatformImageCairo.cpp:
1978         * ImageDiff/cg/ImageDiff.cpp: Removed.
1979         * ImageDiff/cg/PlatformImageCG.cpp: Added.
1980         (ImageDiff::PlatformImage::createFromStdin):
1981         (ImageDiff::PlatformImage::createFromDiffData):
1982         (ImageDiff::PlatformImage::PlatformImage):
1983         (ImageDiff::PlatformImage::~PlatformImage):
1984         (ImageDiff::PlatformImage::width):
1985         (ImageDiff::PlatformImage::height):
1986         (ImageDiff::PlatformImage::rowBytes):
1987         (ImageDiff::PlatformImage::hasAlpha):
1988         (ImageDiff::PlatformImage::pixels):
1989         (ImageDiff::PlatformImage::writeAsPNGToStdout):
1990
1991 2017-05-10  Zan Dobersek  <zdobersek@igalia.com>
1992
1993         Enable FTL JIT by default on AArch64
1994         https://bugs.webkit.org/show_bug.cgi?id=144039
1995
1996         Reviewed by Yusuke Suzuki.
1997
1998         * Scripts/build-jsc: Enable the FTL JIT option by default on ARM64.
1999         * Scripts/run-jsc-stress-tests: Unmark the ARM64 and Linux combination
2000         as an unsupported FTL platform.
2001         * Scripts/webkitdirs.pm:
2002         (isARM64): Returns 1 if the determined architecture is 'arm64'.
2003         * Scripts/webkitperl/FeatureList.pm: Enable FTL_JIT and WEBASSEMBLY on ARM64.
2004
2005 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
2006
2007         webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
2008         https://bugs.webkit.org/show_bug.cgi?id=170857
2009         <rdar://problem/31635373>
2010
2011         Reviewed by Aakash Jain.
2012
2013         Since LayoutTestRelay has been removed, iOS Simulators and Macs can use the same
2014         code to search for crash logs.
2015
2016         * Scripts/webkitpy/port/darwin.py:
2017         (DarwinPort._get_crash_log): Moved from MacPort.
2018         * Scripts/webkitpy/port/darwin_testcase.py:
2019         (DarwinTest.test_get_crash_log): Moved from MacTest.
2020         * Scripts/webkitpy/port/ios_device.py:
2021         (IOSDevicePort._get_crash_log): Implement pass-through for iOS device, since iOS
2022         devices must search for crash-logs remotely.
2023         * Scripts/webkitpy/port/ios_simulator.py:
2024         (IOSSimulatorPort._get_crash_log): Deleted.
2025         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2026         (IOSSimulatorTest.test_get_crash_log): Deleted.
2027         * Scripts/webkitpy/port/mac.py:
2028         (MacPort._get_crash_log): Moved to DarwinPort
2029         * Scripts/webkitpy/port/mac_unittest.py:
2030         (MacTest.test_get_crash_log): Moved to DarwinTest.
2031
2032 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
2033
2034         build ImageDiff with host SDK from Make
2035         https://bugs.webkit.org/show_bug.cgi?id=171835
2036
2037         Reviewed by Alexey Proskuryakov.
2038
2039         ImageDiff should be built for the default SDK and default architecture when
2040         the SDKROOT is set to either iOS device or iOS simulator. Check the
2041         DO_NOT_BUILD_IMAGE_DIFF flag to skip the ImageDiff build.
2042
2043         * ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device.
2044         * Makefile: Do not build ImageDiff if the DO_NOT_BUILD_IMAGE_DIFF flag is set.
2045
2046 2017-05-09  Matt Lewis  <jlewis3@apple.com>
2047
2048         Unreviewed, adding myself to contributors.json
2049
2050         * Scripts/webkitpy/common/config/contributors.json:
2051
2052 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
2053
2054         REGRESSION: ImageDiff not building with make
2055         https://bugs.webkit.org/show_bug.cgi?id=171788
2056
2057         Reviewed by Alex Christensen.
2058
2059         * Makefile: Build ImageDiff for all platforms.
2060
2061 2017-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2062
2063         [Win] ImageDiff isn't built since Bug 168945
2064         https://bugs.webkit.org/show_bug.cgi?id=171847
2065
2066         Reviewed by Alex Christensen.
2067
2068         * CMakeLists.txt: Add 'ImageDiff' sub-directory to build if WIN32.
2069         * ImageDiff/ImageDiff.cpp: Include some header files to fix compilation errors.
2070         * ImageDiff/PlatformWin.cmake: Define USE_CAIRO if WinCairo port.
2071
2072 2017-05-09  Zan Dobersek  <zdobersek@igalia.com>
2073
2074         Upstream the WPE port
2075         https://bugs.webkit.org/show_bug.cgi?id=171110
2076
2077         Reviewed by Alex Christensen.
2078
2079         webkit-dev thread:
2080         https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html
2081
2082         Add WPE support to various tooling scripts, TestWebKitAPI and WebKitTestRunner.
2083         In-file changes removed from this ChangeLog entry for brevity.
2084
2085         * BuildSlaveSupport/built-product-archive:
2086         * BuildSlaveSupport/test-result-archive:
2087         * CMakeLists.txt:
2088         * ImageDiff/PlatformWPE.cmake: Added.
2089         * Scripts/build-dumprendertree:
2090         * Scripts/build-webkit:
2091         * Scripts/build-webkittestrunner:
2092         * Scripts/update-webkit-libs-jhbuild:
2093         * Scripts/update-webkitwpe-libs: Added.
2094         * Scripts/webkitdirs.pm:
2095         * Scripts/webkitperl/FeatureList.pm:
2096         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2097         * Scripts/webkitpy/port/factory.py:
2098         * Scripts/webkitpy/port/wpe.py: Added.
2099         * TestWebKitAPI/PlatformWPE.cmake: Added.
2100         * TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
2101         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp: Added.
2102         * TestWebKitAPI/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
2103         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2104         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2105         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2106         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2107         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2108         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2109         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Added.
2110         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Added.
2111         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp: Added.
2112         * WebKitTestRunner/InjectedBundle/wpe/InjectedBundleWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
2113         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
2114         * WebKitTestRunner/PlatformWPE.cmake: Added.
2115         * WebKitTestRunner/PlatformWebView.h:
2116         * WebKitTestRunner/TestController.cpp:
2117         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: Added.
2118         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp: Added.
2119         * WebKitTestRunner/wpe/HeadlessViewBackend.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
2120         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Added.
2121         * WebKitTestRunner/wpe/TestControllerWPE.cpp: Added.
2122         * WebKitTestRunner/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
2123         * jhbuild/jhbuild-wrapper:
2124         * wpe/generate-inspector-gresource-manifest.py: Added.
2125         * wpe/jhbuild.modules: Added.
2126         * wpe/jhbuildrc: Added.
2127         * wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Added.
2128         * wpe/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2129         * wpe/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added.
2130         * wpe/patches/gdate-suppress-string-format-literal-warning.patch: Added.
2131         * wpe/patches/glib-warning-fix.patch: Added.
2132         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
2133         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
2134         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
2135         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
2136         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Added.
2137
2138 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
2139
2140         Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices
2141         https://bugs.webkit.org/show_bug.cgi?id=169421
2142         <rdar://problem/30950171>
2143
2144         Reviewed by Tim Horton.
2145
2146         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2147         (createBitmapContextFromWebView): Implement for IOSurface.
2148         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2149         (WTR::PlatformWebView::windowSnapshotImage): Use snapshot API for device.
2150
2151 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
2152
2153         buildbot: Cleanup simulators after running tests
2154         https://bugs.webkit.org/show_bug.cgi?id=171679
2155
2156         Reviewed by Aakash Jain.
2157
2158         simctl is partitioned for each user. Since kill-old-processes
2159         is run as root, we need to specify the buildbot user when tearing
2160         down simulators between steps.
2161
2162         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2163         (KillOldProcesses): Pass buildbot user to kill-old-processes.
2164         * BuildSlaveSupport/kill-old-processes:
2165         (main): Specify the user for simctl if one has been provided.
2166
2167 2017-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2168
2169         REGRESSION(r216179): [GTK] Script install-dependencies misses liborc
2170         https://bugs.webkit.org/show_bug.cgi?id=171681
2171
2172         Reviewed by Carlos Garcia Campos.
2173
2174         * gtk/install-dependencies:
2175
2176 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2177
2178         Unreviewed. Fix GTK+ test /webkit2/WebKitConsoleMessage/network-error after r215556.
2179
2180         Glib uses now Unicode quotes in error messages.
2181
2182         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
2183         (testWebKitConsoleMessageNetworkError):
2184
2185 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2186
2187         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r215404.
2188
2189         Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
2190         should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send
2191         characters to the input. Also fix typo in the function name.
2192
2193         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2194         (testWebViewJavaScriptDialogs):
2195
2196 2017-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2197
2198         [GTK] Cannot sign in with new Google sign-in page
2199         https://bugs.webkit.org/show_bug.cgi?id=171770
2200
2201         Unreviewed. This just adds a test.
2202
2203         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2204         (TestWebKitAPI::TEST):
2205
2206 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
2207
2208         [iOS WK2] Make rotation tests more reliable
2209         https://bugs.webkit.org/show_bug.cgi?id=171778
2210
2211         Reviewed by Tim Horton.
2212
2213         Switching between "safari-style" rotation and normal rotation left state on the WKWebView
2214         that would cause later viewport-sensitive tests to fail. The WKWebView would be left
2215         with override layout parameters, and an override orientation, and these caused viewport
2216         size to leak into later tests, and WebCore orientation to not get reset correctly.
2217
2218         Also, WKWebView was unregistering for UIWindowDidRotateNotification notifications when
2219         an override orientation was set, and would never re-register, causing lost orientationchanged
2220         events.
2221
2222         Fix by exposing WKWebView SPI to clear the various bits of overide state. Also don't unregister
2223         from the UIWindowDidRotateNotification notification; it's already ignored anyway if it fires.
2224
2225         Also wait for a visible content rect update after resizing the WKWebVeiw between tests, to make sure
2226         the WebProcess is caught up before proceeding with the test.
2227
2228         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2229         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
2230         * WebKitTestRunner/ios/TestControllerIOS.mm:
2231         (WTR::TestController::platformResetStateToConsistentValues):
2232         (WTR::TestController::platformConfigureViewForTest):
2233
2234 2017-05-06  Csaba Osztrogonác  <ossy@webkit.org>
2235
2236         [Mac][cmake] Buildfix after r216047
2237         https://bugs.webkit.org/show_bug.cgi?id=171769
2238
2239         Unreviewed buildfix.
2240
2241         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2242
2243 2017-05-05  Brady Eidson  <beidson@apple.com>
2244
2245         API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.
2246         <rdar://problem/31977294> and https://bugs.webkit.org/show_bug.cgi?id=171513
2247
2248         Reviewed by Andy Estes.
2249
2250         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2251         (TEST):
2252
2253 2017-05-05  Brian Burg  <bburg@apple.com>
2254
2255         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies
2256         https://bugs.webkit.org/show_bug.cgi?id=171748
2257         <rdar://problem/32027327>
2258
2259         Reviewed by Michael Catanzaro.
2260
2261         Remove temporary workaround now that the assertion failure is fixed.
2262
2263         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2264         (TEST):
2265
2266 2017-05-05  Simon Fraser  <simon.fraser@apple.com>
2267
2268         Make it possible to test rotation in iOS WebKitTestRunner
2269         https://bugs.webkit.org/show_bug.cgi?id=171755
2270
2271         Reviewed by Tim Horton.
2272
2273         Add to UIScriptController:
2274             void simulateRotation(DeviceOrientation orientation, object callback);
2275             void simulateRotationLikeSafari(DeviceOrientation orientation, object callback);
2276
2277         The former just does a view resize, as a simple WKWebView app would do. The second does
2278         animation more like MobileSafari, using _begin/_endAnimatedResize. and associated override
2279         layout size and interface orientation. The two behaviors produce different resize and
2280         orientationchange events and sizes, and both need to be tested.
2281
2282         Rotation is initiated by a call on UIDevice, and responded to by the root view controller,
2283         which is now a custom subclass (PlatformWebViewController).
2284
2285         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2286         (WTR::UIScriptController::simulateRotation):
2287         (WTR::UIScriptController::simulateRotationLikeSafari):
2288         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2289         (WTR::UIScriptController::simulateRotation):
2290         (WTR::UIScriptController::simulateRotationLikeSafari):
2291         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2292         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2293         (WTR::toDeviceOrientation):
2294         (WTR::UIScriptController::simulateRotation):
2295         (WTR::UIScriptController::simulateRotationLikeSafari):
2296         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2297         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2298         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2299         (-[TestRunnerWKWebView dealloc]):
2300         (-[TestRunnerWKWebView _didEndRotation]):
2301         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2302         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
2303         (WTR::PlatformWebView::PlatformWebView):
2304         * WebKitTestRunner/ios/TestControllerIOS.mm:
2305         (WTR::TestController::platformResetStateToConsistentValues):
2306         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2307         (WTR::toUIDeviceOrientation):
2308         (WTR::UIScriptController::simulateRotation):
2309         (WTR::UIScriptController::simulateRotationLikeSafari):
2310         (WTR::UIScriptController::platformClearAllCallbacks):
2311         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2312         (WTR::UIScriptController::simulateRotation):
2313         (WTR::UIScriptController::simulateRotationLikeSafari):
2314
2315 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
2316
2317         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
2318         https://bugs.webkit.org/show_bug.cgi?id=168945
2319         <rdar://problem/30745695>
2320
2321         Reviewed by David Kilzer.
2322
2323         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
2324         target SDK. These two changes must happen simultaneously because some archives will
2325         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
2326
2327         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
2328         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
2329         tools directory still includes ImageDiff.
2330         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
2331         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
2332         * Scripts/webkitpy/port/darwin.py: 
2333         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
2334         locally or when running archives.
2335         * Scripts/webkitpy/port/image_diff.py:
2336         (IOSSimulatorImageDiffer): Deleted.
2337         * Scripts/webkitpy/port/ios_simulator.py:
2338         (IOSSimulatorPort.diff_image): Deleted.
2339
2340 2017-05-05  Brian Burg  <bburg@apple.com>
2341
2342         API test WebKit2.WKHTTPCookieStore fails due to possible issue with handling non-session cookies
2343         https://bugs.webkit.org/show_bug.cgi?id=171748
2344
2345         Unreviewed test gardening.
2346
2347         The assertion failure will be investigated separately in order to avoid rolling out
2348         the fix for "secure" cookies. This assertion fails even without r216258 applied.
2349
2350         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2351         (TEST):
2352
2353 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
2354
2355         Unreviewed, rolling out r216260.
2356
2357         Breaks internal iOS testers
2358
2359         Reverted changeset:
2360
2361         "Use ImageDiff built by host SDK and remove ImageDiff from
2362         DumpRenderTree"
2363         https://bugs.webkit.org/show_bug.cgi?id=168945
2364         http://trac.webkit.org/changeset/216260
2365
2366 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
2367
2368         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
2369         https://bugs.webkit.org/show_bug.cgi?id=168945
2370         <rdar://problem/30745695>
2371
2372         Reviewed by David Kilzer.
2373
2374         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
2375         target SDK. These two changes must happen simultaneously because some archives will
2376         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
2377
2378         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
2379         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
2380         tools directory still includes ImageDiff.
2381         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
2382         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
2383         * Scripts/webkitpy/port/darwin.py: 
2384         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
2385         locally or when running archives.
2386         * Scripts/webkitpy/port/image_diff.py:
2387         (IOSSimulatorImageDiffer): Deleted.
2388         * Scripts/webkitpy/port/ios_simulator.py:
2389         (IOSSimulatorPort.diff_image): Deleted.
2390
2391 2017-05-05  Brian Burg  <bburg@apple.com>
2392
2393         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure
2394         https://bugs.webkit.org/show_bug.cgi?id=171700
2395         <rdar://problem/32017975>
2396
2397         Reviewed by Brady Eidson.
2398
2399         Fix a mistake in the test that should have caught this bug.
2400
2401         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2402         (TEST):
2403         The assertions that were meant to check round-tripping were actually checking
2404         the properties of the original cookie objects, not the round-tripped ones.
2405         This test now fails without the bugfix and passes when it is applied.
2406
2407 2017-05-05  Daniel Bates  <dabates@apple.com>
2408
2409         Use EXPECT_EQ() when comparing strings in TestWebKitAPI tests
2410         https://bugs.webkit.org/show_bug.cgi?id=171698
2411
2412         Reviewed by Darin Adler.
2413
2414         We should use EXPECT_EQ() instead of EXPECT_TRUE() to compare WTF::String() objects
2415         so that we get pretty diff output when the actual string differs from the expected
2416         string as opposed to seeing a boolean result. The former makes makes it straightforward
2417         to diagnose a regression without reading the code for the test or instrumenting it to
2418         determine the actual string that was compared.
2419
2420         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2421         (TestWebKitAPI::TEST):
2422         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
2423         (TestWebKitAPI::TEST_F):
2424         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
2425         (TestWebKitAPI::TEST_F):
2426
2427 2017-05-05  Chris Dumez  <cdumez@apple.com>
2428
2429         Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations
2430         https://bugs.webkit.org/show_bug.cgi?id=171624
2431
2432         Reviewed by Dan Bernstein.
2433
2434         Extend API test coverage to cover crashes in addition to terminations requested by the client.
2435
2436         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2437         * TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp.
2438         (TestWebKitAPI::webProcessWasTerminatedByClient):
2439         (TestWebKitAPI::webProcessCrashed):
2440         (TestWebKitAPI::TEST):
2441
2442 2017-05-04  Mark Lam  <mark.lam@apple.com>
2443
2444         DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
2445         https://bugs.webkit.org/show_bug.cgi?id=171716
2446         <rdar://problem/30878027>
2447
2448         Reviewed by Saam Barati.
2449
2450         setAudioResultCallback() needs to acquire the JSLock before calling toJS() (which
2451         does JS conversion and therefore, potentially JS allocations) and accessing
2452         methods of internal JS data structures (which may do JS invocation, etc).
2453
2454         * DumpRenderTree/TestRunner.cpp:
2455         (setAudioResultCallback):
2456
2457 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
2458
2459         buildbot: Cleanup simulators after running tests
2460         https://bugs.webkit.org/show_bug.cgi?id=171679
2461         <rdar://problem/31994361>
2462
2463         Reviewed by Aakash Jain.
2464
2465         We shutdown the simulator process between tests, but in some cases, this is not
2466         sufficient. Explicitly shutdown every booted simulator.
2467
2468         * BuildSlaveSupport/kill-old-processes:
2469         (main): Shutdown all booted simulators.
2470
2471 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2472
2473         [GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing WebKitWebContext
2474         https://bugs.webkit.org/show_bug.cgi?id=171644
2475
2476         Reviewed by Michael Catanzaro.
2477
2478         Check that only one WebKitWebContext can have automation enabled.
2479
2480         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
2481         (testAutomationSessionRequestSession):
2482
2483 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2484
2485         [GTK] TestController timeout source callback should return G_SOURCE_REMOVE
2486         https://bugs.webkit.org/show_bug.cgi?id=171724
2487
2488         Reviewed by Michael Catanzaro.
2489
2490         It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.
2491
2492         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2493         (WTR::timeoutSource):
2494
2495 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2496
2497         Unreviewed. Fix wrong assert after r215176.
2498
2499         Cairo surface received by computeMD5HashStringForCairoSurface() doesn't need to be ARGB32 since r215176, it
2500         could also be RGB24 when created from a web view snapshot.
2501
2502         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2503         (WTR::computeMD5HashStringForCairoSurface):
2504
2505 2017-05-04  Brian Burg  <bburg@apple.com>
2506
2507         lldb_webkit.py should provide a type summary for WebCore::URL
2508         https://bugs.webkit.org/show_bug.cgi?id=171670
2509
2510         Reviewed by Jer Noble.
2511
2512         Just print out the underlying string using the WTFString provider.
2513
2514         * lldb/lldb_webkit.py:
2515         (__lldb_init_module):
2516         (WebCoreURL_SummaryProvider):
2517         (WebCoreURLProvider):
2518         (WebCoreURLProvider.__init__):
2519         (WebCoreURLProvider.to_string):
2520
2521 2017-05-04  Commit Queue  <commit-queue@webkit.org>
2522
2523         Unreviewed, rolling out r216206.
2524         https://bugs.webkit.org/show_bug.cgi?id=171714
2525
2526         Multiple LayoutTests crashing in Document::page() (Requested
2527         by ap on #webkit).
2528
2529         Reverted changeset:
2530
2531         "Remove support for legacy Notifications"
2532         https://bugs.webkit.org/show_bug.cgi?id=171487
2533         http://trac.webkit.org/changeset/216206
2534
2535 2017-05-04  Mark Lam  <mark.lam@apple.com>
2536
2537         API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
2538         https://bugs.webkit.org/show_bug.cgi?id=171702
2539
2540         Reviewed by Filip Pizlo.
2541
2542         The test was supposed to use the MAKE_STATIC_STRING_IMPL macro.  I had previously
2543         changed it to instantiate an automatic StaticStringImpl (i.e. stack allocated) to
2544         confirm that the test will detect a regression.  Unfortunately, I forgot to
2545         change it back to using MAKE_STATIC_STRING_IMPL before I landed the test.
2546         This patch fixes that.
2547
2548         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2549         (TestWebKitAPI::neverDestroyedString):
2550
2551 2017-05-04  Ryan Haddad  <ryanhaddad@apple.com>
2552
2553         Disable failing API test WebKit2.ResizeWithHiddenContentDoesNotHang.
2554         https://bugs.webkit.org/show_bug.cgi?id=170195
2555
2556         Unreviewed test gardening.
2557
2558         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2559         (TEST):
2560
2561 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
2562
2563         [Win] Remove redundant macros that are set in the CMake config
2564         https://bugs.webkit.org/show_bug.cgi?id=171571
2565
2566         Reviewed by Brent Fulgham.
2567
2568         * DumpRenderTree/config.h:
2569         * MiniBrowser/win/stdafx.h:
2570         * TestWebKitAPI/config.h:
2571
2572 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
2573
2574         Add testRunner.display() to force displaying the web page for testing
2575         https://bugs.webkit.org/show_bug.cgi?id=171694
2576
2577         Reviewed by Simon Fraser.
2578
2579         Unlike testRunner.displayAndTrackRepaints(), this new function forces 
2580         drawing the web page but without track repaints.
2581
2582         * DumpRenderTree/TestRunner.cpp:
2583         (displayCallback):
2584         (TestRunner::staticFunctions):
2585         * DumpRenderTree/TestRunner.h:
2586         * DumpRenderTree/mac/TestRunnerMac.mm:
2587         (TestRunner::display):
2588         * DumpRenderTree/win/TestRunnerWin.cpp:
2589         (TestRunner::display):
2590         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2591         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2592         (WTR::TestRunner::display):
2593         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2594
2595 2017-05-04  Mark Lam  <mark.lam@apple.com>
2596
2597         NeverDestroyed<String>(ASCIILiteral(...)) is not thread safe.
2598         https://bugs.webkit.org/show_bug.cgi?id=171586
2599         <rdar://problem/31873190>
2600
2601         Reviewed by Yusuke Suzuki.
2602
2603         API test for exercising StaticStringImpl and the MAKE_STATIC_STRING_IMPL macro.
2604
2605         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2606         (TestWebKitAPI::neverDestroyedString):
2607         (TestWebKitAPI::getNeverDestroyedStringAtStackDepth):
2608         (TestWebKitAPI::TEST):
2609
2610 2017-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2611
2612         [WK2] Add support for keeping the selection in a focused editable element when dragging begins
2613         https://bugs.webkit.org/show_bug.cgi?id=171585
2614         <rdar://problem/31544320>
2615
2616         Reviewed by Beth Dakin and Zalan Bujtas.
2617
2618         Adds 1 new unit test and tweaks existing tests to check that when first responder status is lost after beginning
2619         a drag while editing, content is still moved (and not copied) when performing data interaction on a different
2620         element. ContentEditableMoveParagraphs checks that content can be shifted within a single element via a move
2621         operation rather than a copy.
2622
2623         See WebCore ChangeLog for more details.
2624
2625         Tests:  DataInteractionSimulator.ContentEditableToContentEditable
2626                 DataInteractionSimulator.ContentEditableToTextarea
2627                 DataInteractionSimulator.ContentEditableMoveParagraphs
2628                 DataInteractionSimulator.TextAreaToInput
2629
2630         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2631         * TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Added.
2632         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2633         (TestWebKitAPI::TEST):
2634         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2635         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2636         (-[DataInteractionSimulator initWithWebView:]):
2637         (-[DataInteractionSimulator dealloc]):
2638         (-[DataInteractionSimulator _advanceProgress]):
2639         (-[DataInteractionSimulator waitForInputSession]):
2640         (-[DataInteractionSimulator _webView:focusShouldStartInputSession:]):
2641         (-[DataInteractionSimulator _webView:didStartInputSession:]):
2642
2643 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
2644
2645         Rename TestRunner.display() to TestRunner::displayAndTrackRepaints()
2646         https://bugs.webkit.org/show_bug.cgi?id=171641
2647
2648         Reviewed by Simon Fraser.
2649
2650         The plan is to add back the TestRunner.display() which does the display
2651         only without track repaints.
2652
2653         * DumpRenderTree/DumpRenderTree.h:
2654         * DumpRenderTree/TestRunner.cpp:
2655         (displayAndTrackRepaintsCallback):
2656         (TestRunner::staticFunctions):
2657         (displayCallback): Deleted.
2658         (displayInvalidatedRegionCallback): Deleted.
2659         * DumpRenderTree/TestRunner.h:
2660         * DumpRenderTree/mac/DumpRenderTree.mm:
2661         (displayWebView):
2662         (displayAndTrackRepaintsWebView):
2663         * DumpRenderTree/mac/TestRunnerMac.mm:
2664         (TestRunner::displayAndTrackRepaints):
2665         (TestRunner::display): Deleted.
2666         * DumpRenderTree/win/TestRunnerWin.cpp:
2667         (TestRunner::displayAndTrackRepaints):
2668         (TestRunner::display): Deleted.
2669         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2670         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2671         (WTR::TestRunner::displayAndTrackRepaints):
2672         (WTR::TestRunner::display): Deleted.
2673         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2674
2675 2017-05-04  Brady Eidson  <beidson@apple.com>
2676
2677         [ios-simulator] API test WebKit2.WebsiteDataStoreCustomPaths is failing.
2678         https://bugs.webkit.org/show_bug.cgi?id=171513
2679
2680         Unreviewed gardening.
2681
2682         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2683         (TEST): Skip the failing parts of the test on iOS for now.
2684
2685 2017-05-03  Jonathan Bedard  <jbedard@apple.com>
2686
2687         Make ImageDiff stand-alone
2688         https://bugs.webkit.org/show_bug.cgi?id=168939
2689
2690         Reviewed by David Kilzer.
2691
2692         Create ImageDiff without dependencies on bmalloc and WTF so that it exists as a
2693         stand-alone project. Note that this change does not eliminate the ImageDiff inside
2694         the DumpRenderTree project.
2695
2696         * ImageDiff/ImageDiff.xcodeproj: Added.
2697         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj: Added.
2698         * ImageDiff/Makefile: Use ImageDiff project.
2699         * ImageDiff/PlatformMac.cmake: Added.
2700         * ImageDiff/PlatformWin.cmake: Added.
2701         * ImageDiff/cg: Added.
2702         * ImageDiff/cg/Configurations: Added.
2703         * ImageDiff/cg/Configurations/Base.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/Base.xcconfig.
2704         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig.
2705         * ImageDiff/cg/Configurations/ImageDiff.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig.
2706         * ImageDiff/cg/ImageDiff.cpp: Copied from Tools/DumpRenderTree/cg/ImageDiffCG.cpp.
2707         (createImageFromStdin): Stop using RetainPtr.
2708         (createDifferenceImage): Ditto.
2709         (main): Ditto.
2710         * Scripts/build-imagediff: Stop building WTF and bmalloc.
2711
2712 2017-05-04  Sam Weinig  <sam@webkit.org>
2713
2714         Remove support for legacy Notifications
2715         https://bugs.webkit.org/show_bug.cgi?id=171487
2716
2717         Reviewed by Jon Lee.
2718
2719         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2720         (DRTDesktopNotificationPresenter::checkNotificationPermission):
2721         * Scripts/webkitperl/FeatureList.pm:
2722         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2723         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
2724
2725 2017-05-04  Andy Estes  <aestes@apple.com>
2726
2727         Give +testwebkitapi_configurationWithTestPlugInClassName: a shorter name
2728         https://bugs.webkit.org/show_bug.cgi?id=171673
2729
2730         Reviewed by Dan Bernstein.
2731
2732         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
2733         (TEST):
2734         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
2735         (TEST):
2736         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
2737         (TEST):
2738         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2739         (TEST):
2740         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
2741         (TEST):
2742         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
2743         (configurationWithContentFilterSettings):
2744         (-[LazilyLoadPlatformFrameworksController init]):
2745         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
2746         (TEST):
2747         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
2748         (runTestWithWidth):
2749         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
2750         (TEST):
2751         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2752         (TestWebKitAPI::TEST):
2753         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
2754         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
2755         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
2756         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Renamed to
2757         +_test_configurationWithTestPlugInClassName:
2758
2759 2017-05-04  Eric Carlson  <eric.carlson@apple.com>
2760
2761         [MediaStream] Allow host application to enable/disable media capture
2762         https://bugs.webkit.org/show_bug.cgi?id=171292
2763         <rdar://problem/31821492>
2764
2765         Reviewed by Jer Noble.
2766
2767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2768         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
2769         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
2770         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2771         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2772         (MediaCaptureDisabledTest::SetUp):
2773         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2774         (TEST_F):
2775         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
2776
2777 2017-05-04  Caio Lima  <ticaiolima@gmail.com>
2778
2779         Unreviewed, Adding self to contributors.json
2780
2781         * Scripts/webkitpy/common/config/contributors.json: Added name.
2782
2783 2017-05-04  Konstantin Tokarev  <annulen@yandex.ru>
2784
2785         Fix compilation with ICU 59.1
2786         https://bugs.webkit.org/show_bug.cgi?id=171612
2787
2788         Reviewed by Mark Lam.
2789
2790         ICU 59.1 has broken source compatibility. Now it defines UChar as
2791         char16_t, which does not allow automatic type conversion from unsigned
2792         short in C++ code.
2793
2794         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2795         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
2796
2797 2017-05-04  Andy Estes  <aestes@apple.com>
2798
2799         [Cocoa] Add an optional width parameter to -[WKWebProcessPlugInNodeHandle renderedImageWithOptions:]
2800         https://bugs.webkit.org/show_bug.cgi?id=171646
2801         <rdar://problem/30306321>
2802
2803         Reviewed by Tim Horton.
2804
2805         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
2806         (runTestWithWidth):
2807         (TEST):
2808         (-[RenderedImageWithOptionsObject didRenderImageWithSize:]): Deleted.
2809         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm:
2810         (-[RenderedImageWithOptionsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2811         (-[RenderedImageWithOptionsPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
2812         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
2813         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h:
2814
2815 2017-05-04  Adrian Perez de Castro  <aperez@igalia.com>
2816
2817         [GTK] Fontconfig 2.11.2 in JHBuild does not build with glibc 2.25+ or gperf 3.1+
2818         https://bugs.webkit.org/show_bug.cgi?id=171649
2819
2820         Reviewed by Carlos Garcia Campos.
2821
2822         Add two patches picked from the upstream repository to fix building of
2823         the Fontconfig module in JHBuild. Additionally, this needed a patch to
2824         add "autogen.sh" as it is not included in release tarballs. Also:
2825         building the module with srcdir!=builddir prevents "fcobjshash.gperf"
2826         being regenerated (which is needed) so this is disabled for the
2827         Fontconfig module.
2828
2829         * gtk/jhbuild.modules:
2830         * gtk/patches/fontconfig-2.11.1-add-autogen.patch: Added.
2831         * gtk/patches/fontconfig-Avoid-conflicts-with-integer-width-macros-from-TS-18661-1-2014.patch: Added.
2832         * gtk/patches/fontconfig-Fix-the-build-issue-with-gperf-3.1.patch: Added.
2833
2834 2017-05-04  Commit Queue  <commit-queue@webkit.org>
2835
2836         Unreviewed, rolling out r216172.
2837         https://bugs.webkit.org/show_bug.cgi?id=171654
2838
2839         FTBFS for iOS due to missing WebPageProxy::stopMediaCapture()
2840         implementation. (Requested by ddkilzer on #webkit).
2841
2842         Reverted changeset:
2843
2844         "[MediaStream] Allow host application to enable/disable media
2845         capture"
2846         https://bugs.webkit.org/show_bug.cgi?id=171292
2847         http://trac.webkit.org/changeset/216172
2848
2849 2017-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2850
2851         [GTK] Bump GStreamer version to 1.10.4 in jhbuild
2852         https://bugs.webkit.org/show_bug.cgi?id=171595
2853
2854         Reviewed by Xabier Rodriguez-Calvar.
2855
2856         * gtk/jhbuild.modules:
2857         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
2858         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
2859         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Removed.
2860         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Removed.
2861         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
2862         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2863         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2864
2865 2017-05-03  Saam Barati  <sbarati@apple.com>
2866
2867         How we build polymorphic cases is wrong when making a call from Wasm
2868         https://bugs.webkit.org/show_bug.cgi?id=171527
2869
2870         Reviewed by JF Bastien.
2871
2872         * Scripts/run-jsc-stress-tests:
2873
2874 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
2875
2876         [MediaStream] Allow host application to enable/disable media capture
2877         https://bugs.webkit.org/show_bug.cgi?id=171292
2878         <rdar://problem/31821492>
2879
2880         Reviewed by Jer Noble.
2881
2882         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2883         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
2884         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
2885         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2886         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2887         (MediaCaptureDisabledTest::SetUp):
2888         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2889         (TEST_F):
2890         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
2891
2892 2017-05-03  John Wilander  <wilander@apple.com>
2893
2894         Resource Load Statistics: Remove all statistics for modifiedSince website data removals
2895         https://bugs.webkit.org/show_bug.cgi?id=171584
2896         <rdar://problem/24702576>
2897
2898         Reviewed by Brent Fulgham.
2899
2900         New function to call the clear function that takes a modifiedSince parameter.
2901
2902         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2903         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2904         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2905         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2906         * WebKitTestRunner/TestController.cpp:
2907         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2908         * WebKitTestRunner/TestController.h:
2909         * WebKitTestRunner/TestInvocation.cpp:
2910         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2911
2912 2017-05-03  Commit Queue  <commit-queue@webkit.org>
2913
2914         Unreviewed, rolling out r216160 and r216161.
2915         https://bugs.webkit.org/show_bug.cgi?id=171640
2916
2917         These changes broke the iOS build. (Requested by mlewis13 on
2918         #webkit).
2919
2920         Reverted changesets:
2921
2922         "[MediaStream] Allow host application to enable/disable media
2923         capture"
2924         https://bugs.webkit.org/show_bug.cgi?id=171292
2925         http://trac.webkit.org/changeset/216160
2926
2927         "[MediaStream] Allow host application to enable/disable media
2928         capture"
2929         https://bugs.webkit.org/show_bug.cgi?id=171292
2930         http://trac.webkit.org/changeset/216161
2931
2932 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
2933
2934         [MediaStream] Allow host application to enable/disable media capture
2935         https://bugs.webkit.org/show_bug.cgi?id=171292
2936         <rdar://problem/31821492>
2937
2938         Reviewed by Jer Noble.
2939
2940         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2941         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
2942         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
2943         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2944         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2945         (MediaCaptureDisabledTest::SetUp):
2946         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2947         (TEST_F):
2948         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
2949
2950 2017-04-26  Jiewen Tan  <jiewen_tan@apple.com>
2951
2952         [WebCrypto] Add an api test for testing wrapping/unwrapping serialized crypto keys
2953         https://bugs.webkit.org/show_bug.cgi?id=171350
2954         <rdar://problem/28600836>
2955
2956         Patched by Brady Eidson.
2957
2958         Reviewed by Brent Fulgham.
2959
2960         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2961         * TestWebKitAPI/Tests/WebKit2/NavigationClientDefaultCrypto.cpp: Added.
2962         (TestWebKitAPI::runJavaScriptAlert):
2963         (TestWebKitAPI::decidePolicyForNavigationAction):
2964         (TestWebKitAPI::decidePolicyForNavigationResponse):
2965         (TestWebKitAPI::TEST):
2966         * TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html: Added.
2967
2968 2017-05-03  Simon Fraser  <simon.fraser@apple.com>
2969
2970         Have WKWebView call _updateVisibleContentRects for the current transaction if possible, rather than always delaying
2971         https://bugs.webkit.org/show_bug.cgi?id=171619
2972         https://bugs.webkit.org/show_bug.cgi?id=170195
2973
2974         Reviewed by Tim Horton.
2975
2976         Re-enable WebKit2.ResizeWithHiddenContentDoesNotHang.
2977
2978         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2979         (TEST):
2980
2981 2017-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2982
2983         YouTube user agent quirk breaks new YouTube
2984         https://bugs.webkit.org/show_bug.cgi?id=171603
2985
2986         Reviewed by Carlos Garcia Campos.
2987
2988         Remove the YouTube quirk test.
2989
2990         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2991         (TestWebKitAPI::TEST):
2992
2993 2017-05-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
2994
2995         Async image decoding should be disabled for snapshots, printing and preview
2996         https://bugs.webkit.org/show_bug.cgi?id=171467
2997
2998         Reviewed by Simon Fraser.
2999
3000         Add a API test for snapshotting with large images. Ensure the images are
3001         drawn correctly which implies they should have been synchronously decoded.
3002
3003         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3004         * TestWebKitAPI/Tests/WebKit2/large-red-square-image.html: Added.
3005         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm:
3006         (TEST):
3007
3008 2017-05-03  Chris Dumez  <cdumez@apple.com>
3009
3010         [WK2] Extend processDidCrash delegate to let the client know the reason for the crash
3011         https://bugs.webkit.org/show_bug.cgi?id=171565
3012         <rdar://problem/31204417>
3013
3014         Reviewed by Sam Weinig.
3015
3016         Add API test coverage.
3017
3018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3019         * TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp: Added.
3020         (TestWebKitAPI::didFinishNavigation):
3021         (TestWebKitAPI::didCrashWithReason):
3022         (TestWebKitAPI::TEST):
3023
3024 2017-05-02  David Kilzer  <ddkilzer@apple.com>
3025
3026         check-webkit-style should also keep js-test-post[-async].js in sync
3027         <https://webkit.org/b/171568>
3028
3029         Reviewed by Joseph Pecoraro.
3030
3031         * Scripts/webkitpy/style/checker.py:
3032         (_NEVER_SKIPPED_JS_FILES): Add new list that just contains
3033         JavaScript files not to be skipped.
3034         (_NEVER_SKIPPED_FILES): Update to use _NEVER_SKIPPED_JS_FILES.
3035         (CheckerDispatcher._create_checker): Update to use
3036         _NEVER_SKIPPED_JS_FILES.
3037
3038         * Scripts/webkitpy/style/checkers/jstest.py:
3039         (ALL_JS_TEST_FUNCTION_FILES): Rename from ALL_JS_TEST_FILES.
3040         This is the list of files containing functions that need to be
3041         kept in sync.
3042         (KEEP_JS_TEST_FILES_IN_SYNC): Change to list-of-lists format so
3043         we can keep more sets of files in sync between
3044         LayoutTests/resources and LayoutTests/http/tests/resources.
3045         (JSTestChecker.check): Update to use KEEP_JS_TEST_FILES_IN_SYNC
3046         as list of lists.  Update for ALL_JS_TEST_FUNCTION_FILES rename.
3047         (JSTestChecker.check_js_test_files): Add 'file_group' argument
3048         for list of files to check instead of using
3049         KEEP_JS_TEST_FILES_IN_SYNC.
3050         (JSTestChecker.check_js_test_functions): Update for
3051         ALL_JS_TEST_FUNCTION_FILES rename.
3052
3053         * Scripts/webkitpy/style/checkers/jstest_unittest.py:
3054         (JSTestCheckerTestCase):
3055         (JSTestCheckerTestCase.test_map_functions_to_dict):
3056         - Add test case for map_functions_to_dict() in jstest.py.
3057
3058 2017-05-02  Aakash Jain  <aakash_jain@apple.com>
3059
3060         ews should indicate in logs when it fails to fetch the attachment
3061         https://bugs.webkit.org/show_bug.cgi?id=171583
3062
3063         Reviewed by Alexey Proskuryakov.
3064
3065         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3066         (Bugzilla.fetch_attachment): Added log statement.
3067
3068 2017-05-02  David Kilzer  <ddkilzer@apple.com>
3069
3070         Rolling out jstest_unittest.py so it can be reviewed
3071
3072         Follow-up fix for:
3073         check-webkit-style should keep JavaScript test functions in sync
3074         <https://webkit.org/b/171424>
3075
3076         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Remove.
3077
3078 2017-05-02  David Kilzer  <ddkilzer@apple.com>
3079
3080         check-webkit-style should keep JavaScript test functions in sync
3081         <https://webkit.org/b/171424>
3082
3083         Reviewed by Joseph Pecoraro.
3084
3085         Add a new JSTestChecker for check-webkit-style that keeps these
3086         two files in sync:
3087
3088             LayoutTests/http/tests/resources/js-test-pre.js
3089             LayoutTests/resources/js-test-pre.js
3090
3091         And keeps implementations of shouldBe(), shouldNotBe(),
3092         shouldNotThrow(), and shouldThrow() in sync across multiple
3093         files (with the ability to add more functions later):
3094
3095             JSTests/stress/resources/standalone-pre.js
3096             LayoutTests/http/tests/resources/js-test-pre.js
3097             LayoutTests/resources/js-test-pre.js
3098             LayoutTests/resources/js-test.js
3099             LayoutTests/resources/standalone-pre.js
3100
3101         * Scripts/webkitpy/style/checker.py: Remove unused import.  Add
3102         import for JSTestChecker.
3103         (_NEVER_SKIPPED_FILES): Add array of file names that are never
3104         skipped regardless of other rules.
3105         (_all_categories): Add JSTestChecker categories.
3106         (CheckerDispatcher.should_skip_without_warning): Use
3107         _NEVER_SKIPPED_FILES.
3108         (CheckerDispatcher._create_checker): Return JSTestChecker for
3109         the files to check.
3110
3111         * Scripts/webkitpy/style/checkers/jstest.py: Add.
3112         (map_functions_to_dict): Parse JavaScript source by splitting on
3113         /^function\s+/ regex.  This is good enough for the sanity checks
3114         to keep function implementations in sync.
3115         (strip_blank_lines_and_comments): Strips blank lines and lines
3116         with comments from the end of a chunk of text representing a
3117         function.
3118         (JSTestChecker): New checker.
3119         (JSTestChecker.__init__):
3120         (JSTestChecker.check):
3121         (JSTestChecker.check_js_test_files): Keeps whole files in sync.
3122         (JSTestChecker.check_js_test_functions): Keeps individual
3123         functions in sync.
3124
3125         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Add test
3126         case.
3127         (JSTestTestCase):
3128         (JSTestTestCase.test_map_functions_to_dict):
3129
3130 2017-05-02  Joanmarie Diggs  <jdiggs@igalia.com>
3131
3132         AX: Update implementation of aria-orientation
3133         https://bugs.webkit.org/show_bug.cgi?id=171166
3134
3135         Reviewed by Chris Fleizach.
3136
3137         Return "AXUnknownOrientation" when ATK_STATE_VERTICAL and ATK_STATE_HORIZONTAL
3138         are both absent from the state set. Before we were returning an empty string
3139         which was not consistent with what the Mac port does, thus making shared tests
3140         harder.
3141
3142         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3143         (WTR::AccessibilityUIElement::orientation):
3144
3145 2017-05-01  David Kilzer  <ddkilzer@apple.com>
3146
3147         Stop using sprintf() in JavaScriptCore debugger
3148         <https://webkit.org/b/171512>
3149
3150         Reviewed by Keith Miller.
3151
3152         * Scripts/webkitpy/style/checker.py:
3153         (_PATH_RULES_SPECIFIER): Ignore some formatting checkers since
3154         Source/JavaScriptCore/disassembler/udis86/ is generated code.
3155
3156 2017-05-01  Timothy Horton  <timothy_horton@apple.com>
3157
3158         Expose viewport-fit instead of clip-to-safe-area
3159         https://bugs.webkit.org/show_bug.cgi?id=171503
3160         <rdar://problem/31918249>
3161
3162         Reviewed by Simon Fraser.
3163
3164         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3165         (WTR::UIScriptController::setSafeAreaInsets):
3166         (WTR::UIScriptController::setObscuredInsets): Deleted.
3167         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3168         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3169         (WTR::UIScriptController::setSafeAreaInsets):
3170         (WTR::UIScriptController::setObscuredInsets): Deleted.
3171         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3172         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3173         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3174         (-[TestRunnerWKWebView setOverrideSafeAreaInsets:]):
3175         (-[TestRunnerWKWebView _safeAreaInsetsForFrame:inSuperview:]):
3176         * WebKitTestRunner/ios/TestControllerIOS.mm:
3177         (WTR::TestController::platformResetStateToConsistentValues):
3178         * WebKitTestRunner/ios/UIKitSPI.h:
3179         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3180         (WTR::UIScriptController::setSafeAreaInsets):
3181         (WTR::UIScriptController::setObscuredInsets): Deleted.
3182         Expose a safe area inset setter instead of obscured insets.
3183
3184 2017-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3185
3186         Unreviewed, fix the build on a new internal SDK
3187
3188         Replace usages of NSItemProviderRepresentationVisibilityAll with
3189         UIItemProviderRepresentationOptionsVisibilityAll.
3190
3191         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3192         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
3193         (TestWebKitAPI::TEST):
3194
3195 2017-05-01  David Kilzer  <ddkilzer@apple.com>
3196
3197         [Cocoa] Replace uses of [get…Class() alloc] in TestWebKitAPI
3198         <https://webkit.org/b/171493>
3199
3200         Reviewed by Dan Bernstein.
3201
3202         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3203         Remove UIKit soft-link since TestWebKitAPI links to
3204         UIKit.framework.
3205         (TestWebKitAPI::WebKit1_AudioSessionCategoryIOS_Test): Use
3206         UIWindow and UIWebView classes directly.
3207         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3208         Remove UIKit soft-link since TestWebKitAPI links to
3209         UIKit.framework.
3210         (RequiresUserActionForPlaybackTest::createWebView): Use UIWindow
3211         class directly.
3212
3213 2017-05-01  Brady Eidson  <beidson@apple.com>
3214
3215         Update names in WKURLSchemeHandler/WKURLSchemeHandlerTask APIs.
3216         <rdar://problem/31824838> and https://bugs.webkit.org/show_bug.cgi?id=171508
3217
3218         Reviewed by Andy Estes.
3219
3220         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3221         (-[SchemeHandler webView:startURLSchemeTask:]):
3222         (-[SchemeHandler webView:stopURLSchemeTask:]):
3223         (-[SchemeHandler webView:startTask:]): Deleted.
3224         (-[SchemeHandler webView:stopTask:]): Deleted.
3225
3226 2017-05-01  Jason Marcell  <jmarcell@apple.com>
3227
3228         Add a new function for getting the Git hash for a pure git directory.
3229         https://bugs.webkit.org/show_bug.cgi?id=171450
3230
3231         Reviewed by David Kilzer.
3232
3233         * Scripts/VCSUtils.pm:
3234         (gitHashForDirectory):
3235
3236 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
3237
3238         [ATK] Expose values of aria-rowcount, aria-colcount, aria-rowindex, aria-colindex, aria-rowspan, and aria-colspan as object attributes
3239         https://bugs.webkit.org/show_bug.cgi?id=171496
3240
3241         Reviewed by Chris Fleizach.
3242
3243         Add new attribute names so that the values of the object attributes can be tested.
3244
3245         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3246         (WTR::AccessibilityUIElement::numberAttributeValue):
3247
3248 2017-05-01  Beth Dakin  <bdakin@apple.com>
3249
3250         On-screen panel for candidate bar is in the wrong place when the caret is at the 
3251         start of a paragraph
3252         https://bugs.webkit.org/show_bug.cgi?id=171453
3253         -and corresponding-
3254         rdar://problem/29779764
3255
3256         Reviewed by Tim Horton.
3257
3258         This test hard-codes the y-coordinate for the expected candidateRect. 
3259         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
3260         (TEST):
3261
3262 2017-05-01  David Kilzer  <ddkilzer@apple.com>
3263
3264         check-webkit-style: Enable sprintf(), strcat(), strcpy() and printf() format checks
3265         <https://webkit.org/b/171494>
3266
3267         Reviewed by Brent Fulgham.
3268
3269         * Scripts/webkitpy/style/checkers/cpp.py:
3270         (check_language): Change categories for certain checkers from
3271         'runtime/printf' to 'security/printf' so they are no longer
3272         filtered.
3273         (CppChecker.categories): Add 'security/printf'.
3274         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3275         (CppStyleTest.test_insecure_string_operations): Add new test for
3276         sprintf(), strcat() and strcpy().
3277         (CppStyleTest.test_format_strings): Update test results for new
3278         'security/printf' category use.
3279
3280 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
3281
3282         AX: [GTK] Add support to query for aria-current
3283         https://bugs.webkit.org/show_bug.cgi?id=149016
3284
3285         Reviewed by Chris Fleizach.
3286
3287         Implement support for "AXARIACurrent" string attribute value.
3288
3289         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3290
3291 2017-05-01  David Kilzer  <ddkilzer@apple.com>
3292
3293         REGRESSION (r216000): test-webkitpy fails after adding new soft-linked class checker
3294
3295         Unreviewed.
3296
3297         Follow-up fix for:
3298         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
3299         https://bugs.webkit.org/show_bug.cgi?id=171486
3300
3301         * Scripts/webkitpy/style/checkers/cpp.py:
3302         (check_soft_link_class_alloc): Use (\w+) instead of ([^\s]+) to
3303         match and capture the function name.  The latter also mistakenly
3304         matches C-preprocessor directives.
3305         (CppChecker.categories): Add 'runtime/soft-linked-alloc', which
3306         is a requirement for the CppChecker class.
3307
3308 2017-05-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3309
3310         [GTK] Add automation session API
3311         https://bugs.webkit.org/show_bug.cgi?id=171428
3312
3313         Reviewed by Carlos Alberto Lopez Perez.
3314
3315         Add an automation mode to MiniBrowser using the new API and add a unit test too.
3316
3317         * MiniBrowser/gtk/BrowserWindow.c:
3318         (webViewTitleChanged):
3319         (webViewDecidePolicy):
3320         (newTabCallback):
3321         (openPrivateWindow):
3322         (browserWindowFinalize):
3323         (browser_window_init):
3324         (browser_window_get_or_create_web_view_for_automation):
3325         * MiniBrowser/gtk/BrowserWindow.h:
3326         * MiniBrowser/gtk/main.c:
3327         (createBrowserTab):
3328         (createWebViewForAutomationCallback):
3329         (automationStartedCallback):
3330         (main):
3331         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3332         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp: Added.
3333         (testAutomationSessionRequestSession):
3334         (beforeAll):
3335         (afterAll):
3336
3337 2017-04-30  Dan Bernstein  <mitz@apple.com>
3338
3339         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
3340         https://bugs.webkit.org/show_bug.cgi?id=171486
3341
3342         Reviewed by Sam Weinig.
3343
3344         * Scripts/webkitpy/style/checkers/cpp.py:
3345         (check_soft_link_class_alloc): Added. Looks for [get…Class() alloc] and suggests
3346           alloc…Instance() instead.
3347         (check_style): Invoke new check.
3348
3349 2017-04-30  Brady Eidson  <beidson@apple.com>
3350
3351         More fixing after r215991
3352         https://bugs.webkit.org/show_bug.cgi?id=171483
3353
3354         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3355         (TEST):
3356
3357 2017-04-30  Brady Eidson  <beidson@apple.com>
3358
3359         Updates to _WKWebsiteDataStoreConfiguration cookie storage location SPI.
3360         <rdar://problem/31906397> and https://bugs.webkit.org/show_bug.cgi?id=171483
3361
3362         Reviewed by Geoff Garen (and kind of Andy Estes).
3363
3364         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3365         (TEST):
3366
3367 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
3368
3369         [ATK] Implement support for aria-autocomplete
3370         https://bugs.webkit.org/show_bug.cgi?id=171167
3371
3372         Reviewed by Chris Fleizach.
3373
3374         Add "AXSupportsAutoCompletion" attribute so the presence of
3375         ATK_STATE_SUPPORTS_AUTOCOMPLETION can be tested.
3376
3377         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3378         (WTR::AccessibilityUIElement::boolAttributeValue):
3379
3380 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
3381
3382         [ATK] ARIA treegrid role should be exposed as ATK_ROLE_TREE_TABLE; not ATK_ROLE_TABLE
3383         https://bugs.webkit.org/show_bug.cgi?id=171170
3384
3385         Reviewed by Chris Fleizach.
3386
3387         Add "AXInterfaceTable" attribute to test which elements implement AtkTable.
3388
3389         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3390         (WTR::AccessibilityUIElement::boolAttributeValue):
3391
3392 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
3393
3394         [ATK] Emit object:state-changed:busy event when aria-busy value changes
3395         https://bugs.webkit.org/show_bug.cgi?id=171181
3396
3397         Reviewed by Chris Fleizach.
3398
3399         Add handler for AXElementBusyChanged notifications.
3400
3401         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3402
3403 2017-04-29  Aakash Jain  <aakash_jain@apple.com>
3404
3405         Use PEP8 style guide for raising exceptions in webkitpy.
3406         https://bugs.webkit.org/show_bug.cgi?id=171439
3407
3408         Reviewed by Daniel Bates.
3409
3410         As per https://www.python.org/dev/peps/pep-0008/
3411         "When raising an exception in Python 2, use raise ValueError('message') 
3412         instead of the older form raise ValueError, 'message'"
3413
3414         * Scripts/webkitpy/common/net/irc/ircbot.py: Using new style for raising exceptions.
3415         * Scripts/webkitpy/common/thread/messagepump.py: Same.
3416         * Scripts/webkitpy/tool/bot/queueengine.py: Same.
3417         * Scripts/webkitpy/tool/commands/queues.py: Same.
3418         * Scripts/webkitpy/tool/commands/stepsequence.py: Same.
3419         * Scripts/webkitpy/tool/multicommandtool.py: Same.
3420         * Scripts/webkitpy/tool/steps/abstractstep.py: Same.
3421
3422 2017-04-28  Simon Fraser  <simon.fraser@apple.com>
3423
3424         Add system trace points for Document::updateTouchEventRegions()
3425         https://bugs.webkit.org/show_bug.cgi?id=171470
3426         rdar://problem/31901239
3427
3428         Reviewed by Tim Horton.
3429
3430         Add trace markers for updateTouchEventRegions.
3431
3432         * Tracing/SystemTracePoints.plist:
3433
3434 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
3435
3436         webkitpy: Add apple_additions to webkitpy to insert Internal tools
3437         https://bugs.webkit.org/show_bug.cgi?id=170461
3438         <rdar://problem/31433077>
3439
3440         Reviewed by Daniel Bates.
3441
3442         Allow a package to be pulled in by run-webkit-tests which provides an interface to
3443         run layout tests on an iOS device.  If this package is not available, throw an
3444         exception when attempting to run layout tests on an iOS device.
3445
3446         * Scripts/webkitpy/port/config.py:
3447         (apple_additions): Import apple_additions package.
3448         * Scripts/webkitpy/port/device.py:
3449         (Device.install_dylibs): Pass a directory with all the frameworks and dylibs to be
3450         installed on a device.
3451         (Device.prepare_for_testing): Pass a list of ports to forward from the device to the
3452         host, the bundle id of the app to be used for testing and a path to the layout test
3453         directory to be mounted on the device.
3454         (Device.finished_testing):
3455         * Scripts/webkitpy/port/factory.py:
3456         (platform_options): Add apple_additions platform options if apple_additions exists.
3457         * Scripts/webkitpy/port/ios.py:
3458         (IOSPort.setup_test_run): Install dylibs and frameworks on the device, pass ports
3459         to forward, the bundle ID of the testing app and the layout tests directory to
3460         each device.
3461         * Scripts/webkitpy/port/ios_device.py:
3462         (IOSDevicePort):
3463         (IOSDevicePort.default_child_processes): Query apple_additions for the number of child
3464         processes to be run.
3465         (IOSDevicePort.using_multiple_devices): Always assume multiple devices are used. When
3466         a single device is used, it is still accessed through an array.
3467         (IOSDevicePort._device_for_worker_number_map): Query apple_additions for the device
3468         for worker number map.
3469         (IOSDevicePort._driver_class): Query apple_additions for the test driver.
3470         (IOSDevicePort.determine_full_port_name): Use class variable over hard-coded string.
3471         (IOSDevicePort.check_for_leaks): No implementation for iOSDevicePort.
3472         (IOSDevicePort.look_for_new_crash_logs): Ditto.
3473         (IOSDevicePort.look_for_new_samples): Ditto.
3474         (IOSDevicePort.sample_process): Ditto.
3475         (IOSDevicePort._build_driver_flags): Use class variable over hard-coded string.
3476         (IOSDevicePort._create_devices): Check that devices are available for testing and check
3477         that we have enough devices for each child process.
3478         (IOSDevicePort.clean_up_test_run): Have apple_additions preform any needed clean up.
3479         * Scripts/webkitpy/port/ios_device_unittest.py:
3480         (IOSDeviceTest.test_operating_system):
3481         (IOSDeviceTest.test_spindump): Override method from DarwinTest.
3482         (IOSDeviceTest.test_sample_process): Ditto.
3483         (IOSDeviceTest.test_sample_process_exception): Ditto.
3484
3485 2017-04-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3486
3487         Fix and re-enable data interaction unit tests
3488         https://bugs.webkit.org/show_bug.cgi?id=171446
3489         <rdar://problem/31820646>
3490
3491         Reviewed by Tim Horton.
3492
3493         Enables all DataInteractionTests, and adjusts file upload tests to no longer write to a temporary file before
3494         registering with the UIItemProvider, and instead just register data directly via
3495         -registerDataRepresentationForTypeIdentifier:visibility:loadHandler:.
3496
3497         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3498         (TestWebKitAPI::TEST):
3499         (temporaryURLForDataInteractionFileLoad): Deleted.
3500         (cleanUpDataInteractionTemporaryPath): Deleted.
3501         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]): Deleted.
3502         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3503         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3504
3505 2017-04-28  Brady Eidson  <beidson@apple.com>
3506
3507         Teach the DatabaseProcess to be fully SessionID aware
3508         https://bugs.webkit.org/show_bug.cgi?id=171451
3509
3510         Reviewed by Geoffrey Garen.
3511
3512         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3513
3514 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
3515
3516         Unreviewed follow-up to r214705.
3517
3518         shut.copytree will fail if given a file as an argument instead of a directory.
3519
3520         * Scripts/webkitpy/common/system/filesystem.py:
3521         (FileSystem.copy_to_base_host): Use copytree when source is a directory and copyfile
3522         when source is a file.
3523         (FileSystem.copy_from_base_host): Ditto.
3524
3525 2017-04-28  Chris Dumez  <cdumez@apple.com>
3526
3527         Update DOMTokenList.replace() to match the latest DOM specification
3528         https://bugs.webkit.org/show_bug.cgi?id=171388
3529
3530         Reviewed by Alex Christensen.
3531
3532         Add API test coverage for new Vector API.
3533
3534         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3535         (TestWebKitAPI::TEST):
3536
3537 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
3538
3539         WebKitTestRunner/DumpRenderTree prevent device from sleeping
3540         https://bugs.webkit.org/show_bug.cgi?id=170731
3541
3542         Reviewed by Alex Christensen.
3543
3544         While running layout tests on a device, the device should not be put asleep.
3545
3546         * DumpRenderTree/mac/DumpRenderTree.mm:
3547         (dumpRenderTree): Disable idle timer.
3548         * WebKitTestRunner/ios/TestControllerIOS.mm:
3549         (WTR::TestController::platformInitialize): Ditto.
3550
3551 2017-04-28  Brady Eidson  <beidson@apple.com>
3552
3553         Start of support for multiple WebsiteDataStore/SessionIDs per process
3554         https://bugs.webkit.org/show_bug.cgi?id=171422
3555
3556         Reviewed by Geoffrey Garen.
3557
3558         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3559         (TEST):
3560
3561 2017-04-28  Youenn Fablet  <youenn@apple.com>
3562
3563         Adding a runtime flag specific to MediaDevices
3564         https://bugs.webkit.org/show_bug.cgi?id=171433
3565
3566         Reviewed by Geoffrey Garen.
3567
3568         Updating WTR and DRT as peer connection and media stream runtime flags are enabled by default.
3569         Setting media devices runtime flag to true for WTR and DRT.
3570
3571         * DumpRenderTree/mac/DumpRenderTree.mm:
3572         (enableExperimentalFeatures):
3573         (resetWebPreferencesToConsistentValues):
3574         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
3575         (TestWebKitAPI::TEST):
3576         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3577         (TestWebKitAPI::TEST):
3578         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3579         (WTR::InjectedBundle::beginTesting):
3580         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3581         (WTR::TestRunner::setMediaDevicesEnabled):
3582         (WTR::TestRunner::setMediaStreamEnabled): Deleted.
3583         (WTR::TestRunner::setPeerConnectionEnabled): Deleted.
3584         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3585         * WebKitTestRunner/TestController.cpp:
3586         (WTR::TestController::resetPreferencesToConsistentValues):
3587
3588 2017-04-28  Dean Jackson  <dino@apple.com>
3589
3590         [WebGPU] Label MTLCommandQueues with a prefix for internal telemetry
3591         https://bugs.webkit.org/show_bug.cgi?id=171441
3592         <rdar://problem/31826915>
3593
3594         Reviewed by Tim Horton.
3595
3596         Add an API test for GPUCommandQueue, exercising creation
3597         and setting the label.
3598
3599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3600         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Added.
3601         (TestWebKitAPI::TEST_F):
3602
3603 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
3604
3605         [ATK] aria-modal="true" should be exposed via ATK_STATE_MODAL
3606         https://bugs.webkit.org/show_bug.cgi?id=171188
3607
3608         Reviewed by Chris Fleizach.
3609
3610         Add "AXModal" attribute string so that we can test the state's exposure.
3611
3612         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3613         (WTR::AccessibilityUIElement::boolAttributeValue):
3614
3615 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
3616
3617         [ATK] GridCellRole should implement AtkTableCell (regression?)
3618         https://bugs.webkit.org/show_bug.cgi?id=171179
3619
3620         Reviewed by Chris Fleizach.
3621
3622         Add new "AXInterfaceTableCell" attribute so that we can test whether or
3623         not there is an implementation of AtkTableCell (i.e. without risking false
3624         negatives from bugs in the interface's implementation).
3625
3626         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3627         (WTR::AccessibilityUIElement::boolAttributeValue):
3628
3629 2017-04-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3630
3631         Move UUID from WebCore/platform to WTF
3632         https://bugs.webkit.org/show_bug.cgi?id=171372
3633
3634         Reviewed by Michael Catanzaro.
3635
3636         * WebKitTestRunner/TestController.cpp:
3637
3638 2017-04-27  Alex Christensen  <achristensen@webkit.org>
3639
3640         Add stub SPI for setting cookie storage path on _WKWebsiteDataStoreConfiguration
3641         https://bugs.webkit.org/show_bug.cgi?id=171399
3642
3643         Reviewed by Brady Eidson.
3644
3645         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.html:
3646         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3647         (TEST):
3648
3649 2017-04-27  Ryan Haddad  <ryanhaddad@apple.com>
3650
3651         Disable flaky API test WKWebView.SetOverrideContentSecurityPolicyWithEmptyStringForPageWithCSP.
3652         https://bugs.webkit.org/show_bug.cgi?id=167914
3653
3654         Unreviewed test gardening.
3655
3656         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm:
3657         (TEST):
3658
3659 2017-04-26  Saam Barati  <sbarati@apple.com>
3660
3661         Add some more testing modes for Wasm tests now that we have tier up
3662         https://bugs.webkit.org/show_bug.cgi?id=171360
3663
3664         Reviewed by Keith Miller.