NoEventDispatchAssertion in ContainerNode::removeChildren is too strict
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-16  Sam Weinig  <sam@webkit.org>
2
3         Make debug-safari --target-web-process work again
4         https://bugs.webkit.org/show_bug.cgi?id=107088
5
6         Reviewed by Anders Carlsson.
7
8         * Scripts/webkitdirs.pm:
9         (execMacWebKitAppForDebugging):
10         The shim is now called SecItemShim.
11
12 2013-01-16  Alan Cutter  <alancutter@chromium.org>
13
14         GCE build scripts don't take working directory into account when calling findzone.sh
15         https://bugs.webkit.org/show_bug.cgi?id=106962
16
17         Reviewed by Adam Barth.
18
19         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
20         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
21         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
22
23 2013-01-16  Alan Cutter  <alancutter@chromium.org>
24
25         start-queue.sh does not pass remaining parameters correctly
26         https://bugs.webkit.org/show_bug.cgi?id=107054
27
28         Reviewed by Adam Barth.
29
30         start-queue.sh now passes all remaining params to the webkit-patch command.
31         Previously only one additional queue parameter could be sent.
32
33         * EWSTools/start-queue.sh:
34
35 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
36
37         check-webkit-style script cannot running in Chinese windows.
38         https://bugs.webkit.org/show_bug.cgi?id=87548
39
40         Reviewed by Darin Adler.
41
42         * Scripts/webkitpy/common/system/platforminfo.py:
43         (PlatformInfo._win_version_tuple_from_cmd):
44
45 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
46
47         Delete an extraneous print statement.
48         https://bugs.webkit.org/show_bug.cgi?id=106562
49
50         Delete the extraneous print statement introduced in r139841.
51
52         * Scripts/webkitpy/layout_tests/views/printing.py:
53         (Printer.print_found):
54
55 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
56
57         Please reinstate --pixel
58         https://bugs.webkit.org/show_bug.cgi?id=101995
59
60         Reviewed by Dirk Pranke.
61
62         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
63         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
64         Some developers are still used to these options that were available in the ORWT.
65
66         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
67         (parse_args):
68
69 2013-01-16  Eric Seidel  <eric@webkit.org>
70
71         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
72         https://bugs.webkit.org/show_bug.cgi?id=99512
73
74         Reviewed by Darin Adler.
75
76         * Scripts/run-sunspider:
77
78 2013-01-16  Eric Seidel  <eric@webkit.org>
79
80         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
81         https://bugs.webkit.org/show_bug.cgi?id=106036
82
83         Reviewed by Darin Adler.
84
85         * Scripts/webkitpy/webkitpy.pyproj: Removed.
86         * Scripts/webkitpy/webkitpy.sln: Removed.
87
88 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
89
90         [Chromium] Remove hardcoded chromium_*.jar in gyp files
91         https://bugs.webkit.org/show_bug.cgi?id=104049
92
93         Reviewed by Eric Seidel.
94
95         Targets with dependencies (direct/indirect) on a java target receive
96         the chromium_*.jar paths in the variable input_jars_paths. Targets
97         should use that rather than hardcoding where they think the jar will
98         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
99         than as --jars to generate_native_test.py.
100
101         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
102         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
103
104 2013-01-16  Dan Carney  <dcarney@google.com>
105
106         [chromium] move setMockDeviceOrientation to TestRunner library
107         https://bugs.webkit.org/show_bug.cgi?id=106895
108
109         Reviewed by Jochen Eisinger.
110
111         * DumpRenderTree/chromium/DRTTestRunner.cpp:
112         (DRTTestRunner::DRTTestRunner):
113         * DumpRenderTree/chromium/DRTTestRunner.h:
114         (DRTTestRunner):
115         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
116         (WebKit):
117         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
118         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
119         (WebTestRunner::TestRunner::TestRunner):
120         (WebTestRunner::TestRunner::setMockDeviceOrientation):
121         (WebTestRunner):
122         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
123         (TestRunner):
124         * DumpRenderTree/chromium/WebViewHost.cpp:
125         (WebViewHost::setDeviceOrientation):
126         * DumpRenderTree/chromium/WebViewHost.h:
127         (WebViewHost):
128
129 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
130
131         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
132         https://bugs.webkit.org/show_bug.cgi?id=106904
133
134         Reviewed by Adam Barth.
135
136         * DumpRenderTree/chromium/DRTTestRunner.cpp:
137         (DRTTestRunner::DRTTestRunner):
138         (DRTTestRunner::notifyDone):
139         (DRTTestRunner::reset):
140         * DumpRenderTree/chromium/DRTTestRunner.h:
141         (DRTTestRunner):
142         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
143         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
144         (WebTestRunner::WebTestDelegate::setFocus):
145         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
146         (WebTestRunner::WebTestDelegate::pathToLocalResource):
147         (WebTestRunner::WebTestDelegate::setLocale):
148         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
149         (WebTestRunner::TestRunner::TestRunner):
150         (WebTestRunner::TestRunner::reset):
151         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
152         (WebTestRunner):
153         (WebTestRunner::TestRunner::setWindowIsKey):
154         (WebTestRunner::TestRunner::pathToLocalResource):
155         (WebTestRunner::TestRunner::setBackingScaleFactor):
156         (WebTestRunner::TestRunner::setPOSIXLocale):
157         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
158         (WebTestRunner::TestRunner::taskList):
159         (TestRunner):
160         * DumpRenderTree/chromium/WebViewHost.cpp:
161         (WebViewHost::setDeviceScaleFactor):
162         (WebViewHost::setFocus):
163         (WebViewHost::setAcceptAllCookies):
164         (WebViewHost::pathToLocalResource):
165         (WebViewHost::setLocale):
166         * DumpRenderTree/chromium/WebViewHost.h:
167         (WebViewHost):
168
169 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
170
171         [GTK] build-webkit fails if the jhbuild wrapper is not used
172         https://bugs.webkit.org/show_bug.cgi?id=106769
173
174         Reviewed by Martin Robinson.
175
176         Return an empty array instead of "" in
177         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
178         will not be recognized as a valid command when the returned array
179         is directly passed to perl's system() call.
180
181         * Scripts/webkitdirs.pm:
182         (jhbuildWrapperPrefixIfNeeded):
183
184 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
185
186         [chromium] add title text direction attribute to TestRunner
187         https://bugs.webkit.org/show_bug.cgi?id=106907
188
189         Reviewed by Adam Barth.
190
191         * DumpRenderTree/chromium/DRTTestRunner.cpp:
192         (DRTTestRunner::DRTTestRunner):
193         (DRTTestRunner::reset):
194         * DumpRenderTree/chromium/DRTTestRunner.h:
195         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
196         (WebTestRunner::WebTestRunner::setTitleTextDirection):
197         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
198         (WebTestRunner::TestRunner::TestRunner):
199         (WebTestRunner::TestRunner::reset):
200         (WebTestRunner::TestRunner::setTitleTextDirection):
201         (WebTestRunner):
202         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
203         (TestRunner):
204         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
205         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
206         * DumpRenderTree/chromium/WebViewHost.cpp:
207         (WebViewHost::didReceiveTitle):
208
209 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
210
211         NRWT still confused about test count with --repeat-each and --iterations
212         https://bugs.webkit.org/show_bug.cgi?id=106562
213
214         Reviewed by Dirk Pranke.
215
216         Fix the printed unique test count and skipped count. This
217         seems to have broken in r127688 ("NRWT lies about the number
218         of tests that it's skipping when used with --repeat-each").
219
220         Also add a test for print_found()
221
222         * Scripts/webkitpy/layout_tests/views/printing.py:
223         (Printer.print_found):
224         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
225         (Testprinter.test_details):
226         (Testprinter):
227         (Testprinter.test_found):
228
229 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
230
231         Unreviewed follow-up to r139769.
232
233         Note that omitting the WebKit1 code from the build now
234         works for GTK as well.
235
236         * Scripts/build-webkit:
237
238 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
239
240         test-webkitpy: truncate output to the terminal width when necessary
241         https://bugs.webkit.org/show_bug.cgi?id=106973
242
243         Reviewed by Ojan Vafai.
244
245         this implements the same logic for test-webkitpy that we have
246         for run-webkit-tests (and ninja).
247
248         No tests written as this is exercised by running test-webkitpy itself.
249
250         * Scripts/webkitpy/test/printer.py:
251         (Printer.configure):
252         (Printer._test_line):
253
254 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
255
256         remove extraneous output in test-webkitpy
257         https://bugs.webkit.org/show_bug.cgi?id=106971
258
259         Reviewed by Ojan Vafai.
260
261         We weren't ignoring or capturing the echoed output from
262         these two tests, and getting noise in the logs as a result.
263
264         * Scripts/webkitpy/common/system/executive_unittest.py:
265         (ExecutiveTest.test_auto_stringify_args):
266         (ExecutiveTest.test_popen_args):
267
268 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
269
270         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
271         https://bugs.webkit.org/show_bug.cgi?id=106974
272
273         Reviewed by Ryosuke Niwa.
274
275         I forgot to stub out the call to check to ensure that the ports were
276         available, so this test could fail if something was listening on 8000 or
277         8443 on the machine.
278
279         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
280         (TestHttpServer.test_win32_start_and_stop):
281
282 2013-01-15  Levi Weintraub  <leviw@chromium.org>
283
284         Unreviewed, rolling out r139792.
285         http://trac.webkit.org/changeset/139792
286         https://bugs.webkit.org/show_bug.cgi?id=106970
287
288         Broke the windows build.
289
290         * DumpRenderTree/chromium/DRTTestRunner.cpp:
291         (DRTTestRunner::DRTTestRunner):
292         (DRTTestRunner::notifyDone):
293         (DRTTestRunner::reset):
294         (DRTTestRunner::setAlwaysAcceptCookies):
295         (DRTTestRunner::setWindowIsKey):
296         (DRTTestRunner::pathToLocalResource):
297         (DRTTestRunner::setPOSIXLocale):
298         (InvokeCallbackTask):
299         (InvokeCallbackTask::InvokeCallbackTask):
300         (InvokeCallbackTask::runIfValid):
301         (DRTTestRunner::setBackingScaleFactor):
302         * DumpRenderTree/chromium/DRTTestRunner.h:
303         (DRTTestRunner):
304         (DRTTestRunner::taskList):
305         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
306         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
307         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
308         (WebTestRunner::TestRunner::TestRunner):
309         (WebTestRunner::TestRunner::reset):
310         (WebTestRunner::TestRunner::setDatabaseQuota):
311         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
312         (TestRunner):
313         * DumpRenderTree/chromium/WebViewHost.cpp:
314         (WebViewHost::setPendingExtraData):
315         (WebViewHost::setDeviceScaleFactor):
316         * DumpRenderTree/chromium/WebViewHost.h:
317         (WebViewHost):
318
319 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
320
321         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
322
323         * Scripts/webkitpy/common/config/ports.py:
324         (MacWK2Port):
325
326 2013-01-15  Alan Cutter  <alancutter@chromium.org>
327
328         Extend sheriffbot's "help" command to be able to get help on individual commands
329         https://bugs.webkit.org/show_bug.cgi?id=106629
330
331         Reviewed by Eric Seidel.
332
333         Added a help command to sheriffbot.
334         Fixed some style issues and ordered the commands alphabetically.
335
336         * Scripts/webkitpy/tool/bot/irc_command.py:
337         (IRCCommand):
338         (IRCCommand.execute):
339         (IRCCommand.usage):
340         (IRCCommand.help):
341         (CreateBug):
342         (CreateBug.execute):
343         (Help):
344         (Help.execute):
345         (Help._post_command_help):
346         (Hi):
347         (Hi.execute):
348         (Restart):
349         (RollChromiumDEPS):
350         (RollChromiumDEPS._parse_args):
351         (RollChromiumDEPS._expand_irc_nickname):
352         (RollChromiumDEPS.execute):
353         (Rollout):
354         (Rollout._extract_revisions):
355         (Rollout.execute):
356         (Sheriffs):
357         (Sheriffs.execute):
358         (Whois):
359         (Whois.execute):
360         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
361         (IRCBotTest.test_help):
362
363 2013-01-15  Enrica Casucci  <enrica@apple.com>
364
365         Add a new set of WebKit2 APIs for text search and
366         search results management.
367         https://bugs.webkit.org/show_bug.cgi?id=106834.
368         <rdar://problem/12597159>
369
370         Added new test for the new WebKit2 API for
371         text search.
372         
373         Reviewed by Simon Fraser.
374
375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
376         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
377
378 2013-01-15  Levi Weintraub  <leviw@chromium.org>
379
380         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
381         https://bugs.webkit.org/show_bug.cgi?id=106904
382
383         Reverting 139794. It broke the build. It appears that a header file,
384         WebTextDirection.h, was left out.
385
386         * DumpRenderTree/chromium/DRTTestRunner.cpp:
387         (DRTTestRunner::DRTTestRunner):
388         (DRTTestRunner::reset):
389         * DumpRenderTree/chromium/DRTTestRunner.h:
390         (DRTTestRunner::setTitleTextDirection):
391         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
392         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
393         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
394         (WebTestRunner::TestRunner::TestRunner):
395         (WebTestRunner::TestRunner::reset):
396         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
397         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
398         (TestRunner):
399         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
400         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
401         * DumpRenderTree/chromium/WebViewHost.cpp:
402         (WebViewHost::didReceiveTitle):
403
404 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
405
406         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
407         https://bugs.webkit.org/show_bug.cgi?id=106904
408
409         Reviewed by Adam Barth.
410
411         * DumpRenderTree/chromium/DRTTestRunner.cpp:
412         (DRTTestRunner::DRTTestRunner):
413         (DRTTestRunner::notifyDone):
414         (DRTTestRunner::reset):
415         * DumpRenderTree/chromium/DRTTestRunner.h:
416         (DRTTestRunner):
417         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
418         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
419         (WebTestRunner::WebTestDelegate::setFocus):
420         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
421         (WebTestRunner::WebTestDelegate::pathToLocalResource):
422         (WebTestRunner::WebTestDelegate::setLocale):
423         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
424         (WebTestRunner::TestRunner::TestRunner):
425         (WebTestRunner::TestRunner::reset):
426         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
427         (WebTestRunner):
428         (WebTestRunner::TestRunner::setWindowIsKey):
429         (WebTestRunner::TestRunner::pathToLocalResource):
430         (WebTestRunner::TestRunner::setBackingScaleFactor):
431         (WebTestRunner::TestRunner::setPOSIXLocale):
432         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
433         (WebTestRunner::TestRunner::taskList):
434         (TestRunner):
435         * DumpRenderTree/chromium/WebViewHost.cpp:
436         (WebViewHost::setDeviceScaleFactor):
437         (WebViewHost::setFocus):
438         (WebViewHost::setAcceptAllCookies):
439         (WebViewHost::pathToLocalResource):
440         (WebViewHost::setLocale):
441         * DumpRenderTree/chromium/WebViewHost.h:
442         (WebViewHost):
443
444 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
445
446         Tests with WontFix expectation are (indirectly) skipped
447         https://bugs.webkit.org/show_bug.cgi?id=105860
448
449         Reviewed by Dirk Pranke.
450
451         Only skip the WontFix expectation if there are no other layout test
452         expectations (like Failure, ImageOnlyFailure) listed for the test.
453         This makes it possible to run an expected failure for which there
454         is no reason or interest to fix. There are some ports that would like
455         to exercise this behavior as well as specific test cases that should use
456         such expectations.
457
458         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
459         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
460         WONTFIX test if there are no expectations listed. The warning is adjusted
461         to reflect the new behavior.
462         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
463         and adjust test cases for these changes.
464         (ExpectationSyntaxTests.test_wontfix):
465         (SemanticTests.test_skip_and_wontfix):
466
467 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
468
469         [chromium] add title text direction attribute to TestRunner
470         https://bugs.webkit.org/show_bug.cgi?id=106907
471
472         Reviewed by Adam Barth.
473
474         * DumpRenderTree/chromium/DRTTestRunner.cpp:
475         (DRTTestRunner::DRTTestRunner):
476         (DRTTestRunner::reset):
477         * DumpRenderTree/chromium/DRTTestRunner.h:
478         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
479         (WebTestRunner::WebTestRunner::setTitleTextDirection):
480         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
481         (WebTestRunner::TestRunner::TestRunner):
482         (WebTestRunner::TestRunner::reset):
483         (WebTestRunner::TestRunner::setTitleTextDirection):
484         (WebTestRunner):
485         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
486         (TestRunner):
487         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
488         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
489         * DumpRenderTree/chromium/WebViewHost.cpp:
490         (WebViewHost::didReceiveTitle):
491
492 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
493
494         nrwt: change the default # of locked shards on chromium_win to 1
495         https://bugs.webkit.org/show_bug.cgi?id=106938
496
497         Reviewed by Eric Seidel.
498
499         It looks like LigHTTPd might be buggy or unstable if we are
500         running multiple http tests in parallel; see
501         http://code.google.com/p/chromium/issues/detail?id=169530 for more
502         context as well. This change will stop running http tests in parallel
503         and we can see if this fixes things.
504
505         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
506         (ChromiumWinPort.default_max_locked_shards):
507         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
508         (ChromiumWinTest.test_path_to_image_diff):
509         (ChromiumWinTest):
510         (ChromiumWinTest.test_default_max_locked_shards):
511
512 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
513
514         [chromium] move WebDatabase related methods to TestRunner library
515         https://bugs.webkit.org/show_bug.cgi?id=106905
516
517         Reviewed by Adam Barth.
518
519         * DumpRenderTree/chromium/DRTTestRunner.cpp:
520         (DRTTestRunner::DRTTestRunner):
521         (DRTTestRunner::reset):
522         * DumpRenderTree/chromium/DRTTestRunner.h:
523         (DRTTestRunner):
524         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
525         (WebTestRunner::WebTestDelegate::clearAllDatabases):
526         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
527         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
528         (WebTestRunner::TestRunner::TestRunner):
529         (WebTestRunner::TestRunner::reset):
530         (WebTestRunner::TestRunner::clearAllDatabases):
531         (WebTestRunner):
532         (WebTestRunner::TestRunner::setDatabaseQuota):
533         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
534         (TestRunner):
535         * DumpRenderTree/chromium/WebViewHost.cpp:
536         (WebViewHost::clearAllDatabases):
537         (WebViewHost::setDatabaseQuota):
538         * DumpRenderTree/chromium/WebViewHost.h:
539         (WebViewHost):
540
541 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
542
543         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
544         functionality match the name.
545         https://bugs.webkit.org/show_bug.cgi?id=106870
546
547         Reviewed by Adam Barth.
548
549         * Scripts/webkitpy/tool/commands/download.py:
550         (Clean):
551         (Update):
552         (Build):
553         (BuildAndTest):
554         (CheckStyle):
555         (BuildAttachment):
556         (BuildAndTestAttachment):
557         (AbstractPatchApplyingCommand):
558         (ApplyWatchList):
559         (AbstractPatchLandingCommand):
560         (CreateRollout):
561         * Scripts/webkitpy/tool/steps/__init__.py:
562         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
563         (CleanWorkingDirectory.options):
564         (CleanWorkingDirectory.run):
565         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
566         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
567         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
568
569 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
570
571         [Autotools] Add support for WebKit2-only builds
572         https://bugs.webkit.org/show_bug.cgi?id=106889
573
574         Reviewed by Gustavo Noronha Silva.
575
576         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
577         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
578         building the GTK port through build-webkit.
579         * Scripts/webkitdirs.pm:
580         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
581         arguments when not building WebKit1.
582         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
583         through the Autotools build system.
584
585 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
586
587         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
588         https://bugs.webkit.org/show_bug.cgi?id=106197
589
590         Reviewed by Martin Robinson.
591
592         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
593         features. Enable them on GTK, meaning they will be enabled in development builds
594         (i.e. when building with build-webkit).
595
596 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
597
598         [GTK] Enable CSS Image Resolution feature
599         https://bugs.webkit.org/show_bug.cgi?id=99038
600
601         Reviewed by Gustavo Noronha Silva.
602
603         Enable the CSS Image Resolution feature for the development
604         builds of the GTK port.
605
606         * Scripts/webkitperl/FeatureList.pm:
607
608 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
609
610         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
611         https://bugs.webkit.org/show_bug.cgi?id=106579
612
613         Reviewed by Gustavo Noronha Silva.
614
615         The --enable-unstable-features flag is not required to be passed anymore
616         to the configure script as it was removed in r138252.
617
618         * Scripts/webkitdirs.pm:
619         (buildAutotoolsProject):
620
621 2013-01-15  Tony Chang  <tony@chromium.org>
622
623         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
624
625         * Scripts/webkitpy/layout_tests/servers/http_server.py:
626         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
627         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
628         (TestHttpServer.test_win32_start_and_stop):
629
630 2013-01-15  Joshua Bell  <jsbell@chromium.org>
631
632         Unreviewed. Adding Michael Pruett as contributor.
633
634         * Scripts/webkitpy/common/config/committers.py:
635
636 2013-01-15  Victor Carbune  <victor@rosedu.org>
637
638         Unreviewed. Update my email addresses.
639
640         * Scripts/webkitpy/common/config/committers.py:
641
642 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
643
644         [GTK] Waiting on the gdb process will lead to deadlock
645         https://bugs.webkit.org/show_bug.cgi?id=106906
646
647         Reviewed by Philippe Normand.
648
649         Use communicate() rather than wait() on the Popen object that's running the gdb
650         command. This avoids the deadlock that occurs on the GTK builders.
651
652         * Scripts/webkitpy/layout_tests/port/gtk.py:
653         (GtkPort._get_gdb_output):
654
655 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
656
657         [GTK] Limit the number of frames printed out when backtracing with gdb
658         https://bugs.webkit.org/show_bug.cgi?id=106901
659
660         Reviewed by Philippe Normand.
661
662         Printing an unlimited number of frames when dumping the gdb backtracing
663         output can cause timeouts in the builders. This patch limits the number
664         of frames that are printed out to 1024.
665
666         * Scripts/webkitpy/layout_tests/port/gtk.py:
667         (GtkPort._get_gdb_output):
668
669 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
670
671         [Qt] Fix ImageDiff's image format conversion
672         https://bugs.webkit.org/show_bug.cgi?id=106880
673
674         Reviewed by Csaba Osztrogonác.
675
676         Besides actually doing the conversion this also silences the suspicious warning:
677         "ignoring return value of function declared with warn_unused_result attribute".
678
679         * ImageDiff/qt/ImageDiff.cpp:
680         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
681         copy of the image in the given format and does not alter the image itself.
682
683 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
684
685         [chromium] move remaining methods that just set a boolean flag to TestRunner library
686         https://bugs.webkit.org/show_bug.cgi?id=106823
687
688         Reviewed by Darin Fisher.
689
690         * DumpRenderTree/chromium/DRTTestRunner.cpp:
691         (DRTTestRunner::DRTTestRunner):
692         (DRTTestRunner::reset):
693         * DumpRenderTree/chromium/DRTTestRunner.h:
694         (DRTTestRunner):
695         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
696         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
697         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
698         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
699         (WebTestRunner::WebTestRunner::testRepaint):
700         (WebTestRunner::WebTestRunner::sweepHorizontally):
701         (WebTestRunner::WebTestRunner::isPrinting):
702         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
703         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
704         (WebTestRunner::TestRunner::TestRunner):
705         (WebTestRunner::TestRunner::reset):
706         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
707         (WebTestRunner):
708         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
709         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
710         (WebTestRunner::TestRunner::testRepaint):
711         (WebTestRunner::TestRunner::sweepHorizontally):
712         (WebTestRunner::TestRunner::isPrinting):
713         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
714         (WebTestRunner::TestRunner::dumpBackForwardList):
715         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
716         (WebTestRunner::TestRunner::dumpSelectionRect):
717         (WebTestRunner::TestRunner::repaintSweepHorizontally):
718         (WebTestRunner::TestRunner::setPrinting):
719         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
720         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
721         (TestRunner):
722
723 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
724
725         nrwt: stub out show_results_html for mock ports
726         https://bugs.webkit.org/show_bug.cgi?id=106848
727
728         Reviewed by Ojan Vafai.
729
730         We were accidentally using the underlying ports'
731         show_results_html_file() implementation, which would, unsurprisingly,
732         fail in many cases (e.g., running mock-efl on the mac).
733
734         No test added since we don't generally add tests for the mock
735         implementation.
736
737         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
738         (MockDRTPort.show_results_html_file):
739
740 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
741
742         Changing clean_working_directory/clean_local_commits and related
743         functions to have consistent naming.
744
745         https://bugs.webkit.org/show_bug.cgi?id=104198
746
747         Reviewed by Adam Barth.
748
749         * Scripts/webkitpy/common/checkout/scm/git.py:
750         * Scripts/webkitpy/common/checkout/scm/scm.py:
751         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
752         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
753         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
754         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
755
756 2013-01-14  Alan Cutter  <alancutter@chromium.org>
757
758         Fix EWS GCE build scripts to detect which zone is available
759         https://bugs.webkit.org/show_bug.cgi?id=106524
760
761         Reviewed by Adam Barth.
762
763         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
764         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
765         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
766         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
767
768 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
769
770         Adding an error string to AmbiguousCommitError.
771         https://bugs.webkit.org/show_bug.cgi?id=106846
772
773         Reviewed by Adam Barth.
774
775         * Scripts/webkitpy/common/checkout/scm/git.py:
776         (AmbiguousCommitError.__init__):
777
778 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
779
780         kill whole lighttpd process tree for chromium win
781         https://bugs.webkit.org/show_bug.cgi?id=106838
782
783         Reviewed by Tony Chang.
784
785         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
786         I think a test is causing a httpd server child process to wedge and
787         killing the parent httpd server process isn't sufficient to ensure
788         that the children are also killed.
789
790         * Scripts/webkitpy/layout_tests/servers/http_server.py:
791         (Lighttpd._check_and_kill):
792         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
793         (TestHttpServer.test_start_cmd):
794         (TestHttpServer):
795         (TestHttpServer.test_win32_start_and_stop):
796         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
797         (TestHttpServer.test_win32_start_and_stop.mock_returns):
798         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
799
800 2013-01-14  Nico Weber  <thakis@chromium.org>
801
802         [chromium] Enable `update-webkit --chromium --ninja` on windows
803         https://bugs.webkit.org/show_bug.cgi?id=106836
804
805         Reviewed by Eric Seidel.
806
807         After running this, build-webkit --chromium will use ninja to build.
808         Apparently there are some minor issues with that still, so it's
809         not quite ready for use yet.
810
811         * Scripts/webkitdirs.pm:
812         (determineIsChromiumNinja):
813         (buildChromium):
814
815 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
816
817         nrwt: use the same search path for baselines and TestExpectations on apple mac
818         https://bugs.webkit.org/show_bug.cgi?id=105599
819
820         Reviewed by Ryosuke Niwa.
821
822         Bug 105583 revealed some confusion due to the fact that the Apple
823         Mac port used a different list of directories to search for baselines
824         and TestExpectations files (actually, pretty much every port does).
825
826         It seems like a good idea to use the same list for both by default, but
827         making this happen will affect every port in slightly different ways, so
828         we'll try this on the Apple Mac port first.
829
830         Note that the effective changes for this are that:
831         1) The apple mac port will look in platform/wk2 for baselines where
832         it didn't before (it will look after looking in mac-wk2 but before
833         the non-wk2 dirs)
834         2) The apple mac-snowleopard port will use the expectations in
835         mac-lion as well as the expectations in mac-snowleopard, although
836         I'm not even sure if mac-snowleopard is still supported ...
837
838         * Scripts/webkitpy/layout_tests/port/mac.py:
839         (MacPort.default_baseline_search_path):
840         (MacPort.expectations_files):
841         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
842         (test_baseline_search_path):
843
844 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
845
846         AX: Need to implement ColorWellRole
847         https://bugs.webkit.org/show_bug.cgi?id=106756
848
849         Reviewed by Chris Fleizach.
850
851         Returns a string representation of the value of a color
852         when the role is Color Well, to make it easy to write layout
853         tests for color controls.
854
855         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
856
857 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
858
859         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
860         https://bugs.webkit.org/show_bug.cgi?id=106682
861
862         Reviewed by Chris Fleizach.
863
864         Modify Chromium's DRT implementation of intValue to return a
865         different value depending on the role.
866
867         There are actually platform-specific differences in what should
868         be returned in the "value" of an object, so Chromium normally keeps
869         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
870         but this is a fine simplification to make cross-platform tests easier.
871
872         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
873         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
874
875 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
876
877         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
878         https://bugs.webkit.org/show_bug.cgi?id=106785
879
880         Reviewed by Adam Barth.
881
882         * DumpRenderTree/chromium/DRTTestRunner.cpp:
883         (DRTTestRunner::DRTTestRunner):
884         (DRTTestRunner::reset):
885         * DumpRenderTree/chromium/DRTTestRunner.h:
886         (DRTTestRunner):
887         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
888         (WebTestProxyBase):
889         (WebTestRunner::WebTestProxy::setStatusText):
890         (WebTestRunner::WebTestProxy::didStopLoading):
891         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
892         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
893         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
894         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
895         (WebTestRunner::TestRunner::TestRunner):
896         (WebTestRunner::TestRunner::reset):
897         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
898         (WebTestRunner):
899         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
900         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
901         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
902         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
903         (TestRunner):
904         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
905         (WebTestRunner::WebTestProxyBase::setStatusText):
906         (WebTestRunner):
907         (WebTestRunner::WebTestProxyBase::didStopLoading):
908         * DumpRenderTree/chromium/WebViewHost.cpp:
909         (WebViewHost::didStopLoading):
910         * DumpRenderTree/chromium/WebViewHost.h:
911         (WebViewHost):
912
913 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
914
915         Web Inspector: devtools front-end doesn't have focus in TestShell
916         https://bugs.webkit.org/show_bug.cgi?id=106778
917
918         Reviewed by Pavel Feldman.
919
920         Focus devTools window after loadURL method.
921
922         * DumpRenderTree/chromium/TestShell.cpp:
923         (TestShell::runFileTest):
924
925 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
926
927         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
928         https://bugs.webkit.org/show_bug.cgi?id=106573
929
930         Reviewed by Philippe Normand.
931
932         Similarly to what's been described in bug 106569, we're building
933         from release tarballs, so there's no reason to regenerate the
934         autoconf-related stuff with autogen.sh, especially since we might
935         run into trouble with automake 1.13 and deprecated macros.
936
937         * efl/jhbuild.modules:
938
939 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
940
941         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
942         https://bugs.webkit.org/show_bug.cgi?id=104909
943
944         Reviewed by Simon Hausmann.
945
946         To be able to build redistribuable binary packages, Qt's configure switches
947         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
948         dynamically link to optional system libraries.
949         QtWebKit is doing its own configure checks for those libraries, thus adding a
950         runtime dependency that might not be fulfilled if the packager's machine had
951         those libraries while the user's machine won't.
952
953         Since in most cases where WebKit will want to use those system libraries, Qt will
954         also be using them, remove these configure tests from WebKit.
955
956         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
957         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
958         * qmake/config.tests/libpng/libpng.cpp: Removed.
959         * qmake/config.tests/libpng/libpng.pro: Removed.
960         * qmake/mkspecs/features/features.prf:
961
962 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
963
964         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
965         https://bugs.webkit.org/show_bug.cgi?id=106574
966
967         Reviewed by Laszlo Gombos.
968
969         Rely on a more recent stable release, which includes support for
970         Lua 5.2 in Edje and other assorted minor fixes.
971
972         While here, also use the "configure" script to build the libraries
973         instead of relying on autogen.sh, which is not really needed with
974         a release tarball and may have problems with automake 1.13.
975
976         * efl/jhbuild.modules:
977
978 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
979
980         Web Inspector: fix DRT to deliver simulated events to devtools front-end
981         https://bugs.webkit.org/show_bug.cgi?id=106650
982
983         Reviewed by Pavel Feldman.
984
985         Add separated m_devToolsTestInterfaces object to testShell which is
986         bind to devTools webview.
987
988         * DumpRenderTree/chromium/TestShell.cpp:
989         (TestShell::initialize):
990         (TestShell::createMainWindow):
991         (TestShell::~TestShell):
992         (TestShell::showDevTools):
993         (TestShell::resetTestController):
994         (TestShell::bindJSObjectsToWindow):
995         (TestShell::createNewWindow):
996         * DumpRenderTree/chromium/TestShell.h:
997         (TestShell):
998
999 2013-01-14  Alan Cutter  <alancutter@chromium.org>
1000
1001         Sheriffbot command aliases need test cases
1002         https://bugs.webkit.org/show_bug.cgi?id=106754
1003
1004         Reviewed by Eric Seidel.
1005
1006         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1007         (SheriffBotTest.test_command_aliases):
1008
1009 2013-01-13  Alan Cutter  <alancutter@chromium.org>
1010
1011         Allow users to misspell the "sheriffs" command in sheriffbot
1012         https://bugs.webkit.org/show_bug.cgi?id=106628
1013
1014         Reviewed by Steve Block.
1015
1016         * Scripts/webkitpy/tool/bot/irc_command.py:
1017
1018 2013-01-13  Alan Cutter  <alancutter@chromium.org>
1019
1020         Make "gardeners" an alias for "sheriffs" in sherrifbot
1021         https://bugs.webkit.org/show_bug.cgi?id=106627
1022
1023         Reviewed by Eric Seidel.
1024
1025         * Scripts/webkitpy/tool/bot/irc_command.py:
1026
1027 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
1028
1029         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
1030         https://bugs.webkit.org/show_bug.cgi?id=105380
1031
1032         Reviewed by Eric Seidel.
1033
1034         Fix a regression introduced in r137692 where we were double-encoding
1035         the arguments to popen(); this was only an issue on windows, where
1036         we would try to encode something to mbcs, then try to encode it
1037         to unicode as if the input as ascii.
1038
1039         * Scripts/webkitpy/common/system/executive.py:
1040         (Executive.run_command):
1041
1042 2013-01-13  Alan Cutter  <alancutter@chromium.org>
1043
1044         State who told sheriffbot to roll the Chromium deps and to what revision
1045         https://bugs.webkit.org/show_bug.cgi?id=106626
1046
1047         Reviewed by Eric Seidel.
1048
1049         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
1050
1051         * Scripts/webkitpy/tool/bot/irc_command.py:
1052         (RollChromiumDEPS._expand_irc_nickname):
1053         (RollChromiumDEPS.execute):
1054         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1055         (IRCCommandTest.test_roll_chromium_deps):
1056         * Scripts/webkitpy/tool/bot/sheriff.py:
1057         (Sheriff.post_chromium_deps_roll):
1058         * Scripts/webkitpy/tool/commands/roll.py:
1059         (RollChromiumDEPS._prepare_state):
1060         (PostChromiumDEPSRoll):
1061         (PostChromiumDEPSRoll._prepare_state):
1062         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1063         (PostRollCommandsTest.test_prepare_state):
1064         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1065         (PrepareChangeLogForDEPSRoll.run):
1066
1067 2013-01-13  Alan Cutter  <alancutter@chromium.org>
1068
1069         Add Alan Cutter as contributor
1070         https://bugs.webkit.org/show_bug.cgi?id=106747
1071
1072         Reviewed by Eric Seidel.
1073
1074         * Scripts/webkitpy/common/config/committers.py:
1075
1076 2013-01-13  Jonathan Liu  <net147@gmail.com>
1077
1078         Fix CONFIG missing link_pkgconfig on Windows
1079         https://bugs.webkit.org/show_bug.cgi?id=106647
1080
1081         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
1082         properly on Windows because they are added to PKGCONFIG but
1083         CONFIG does not contain link_pkgconfig.
1084
1085         This is because link_pkgconfig is added in unix/default_pre.prf
1086         which is only used for UNIX platforms. To fix this, move it to
1087         the general default_pre.prf.
1088
1089         Reviewed by Simon Hausmann.
1090
1091         * qmake/mkspecs/features/default_pre.prf:
1092         * qmake/mkspecs/features/unix/default_pre.prf:
1093
1094 2013-01-12  Nico Weber  <thakis@chromium.org>
1095
1096         nrwt/chromium: Don't prefer chromium over webkit build directories
1097         https://bugs.webkit.org/show_bug.cgi?id=105597
1098
1099         Reviewed by Dirk Pranke.
1100
1101         Rely on the new timestamp logic instead. Requested by dpranke in
1102         https://bugs.webkit.org/show_bug.cgi?id=105498
1103
1104         * Scripts/webkitpy/layout_tests/port/chromium.py:
1105         (ChromiumPort._static_build_path):
1106         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1107         (ChromiumLinuxPortTest.test_build_path):
1108         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1109         (ChromiumMacPortTest.test_build_path):
1110         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1111         (ChromiumWinTest.test_build_path):
1112
1113 2013-01-12  Nico Weber  <thakis@chromium.org>
1114
1115         Use ninja by default on Linux for build-webkit --chromium, bot edition
1116         https://bugs.webkit.org/show_bug.cgi?id=104434
1117
1118         Reviewed by Eric Seidel.
1119
1120         r139557 changed update-webkit to pick ninja by default on linux, but
1121         the bots run update-webkit-chromium directly so they didn't see this.
1122         Move the default for ninja into update-webkit-chromium so that it's
1123         picked up by the bots, and let update-webkit forward non-default
1124         options to there.
1125
1126         This way, the default is in one place only and both developers (who
1127         usually use update-webkit which then shells out to
1128         updat-webkit-chromium) and bots (which use update-webkit-chromium
1129         directly) see the same behavior.
1130
1131         * Scripts/update-webkit:
1132         * Scripts/update-webkit-chromium:
1133
1134 2013-01-12  Nico Weber  <thakis@chromium.org>
1135
1136         Make ninja the default build system on Linux for build-webkit --chromium
1137         https://bugs.webkit.org/show_bug.cgi?id=104434
1138
1139         Reviewed by Eric Seidel.
1140
1141         * Scripts/update-webkit:
1142
1143 2013-01-12  Alan Cutter  <alancutter@chromium.org>
1144
1145         Migrate the remaining bots in EC2 to Google Compute Engine
1146         https://bugs.webkit.org/show_bug.cgi?id=106005
1147
1148         Reviewed by Eric Seidel.
1149
1150         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
1151
1152         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
1153         * EWSTools/boot.sh:
1154         * EWSTools/build-repo.sh:
1155         * EWSTools/start-queue.sh:
1156
1157 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
1158
1159         [chromium] move inspector related methods to TestRunner library
1160         https://bugs.webkit.org/show_bug.cgi?id=106654
1161
1162         Reviewed by Adam Barth.
1163
1164         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1165         (DRTTestRunner::DRTTestRunner):
1166         * DumpRenderTree/chromium/DRTTestRunner.h:
1167         (DRTTestRunner):
1168         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1169         (WebTestRunner::WebTestDelegate::showDevTools):
1170         (WebTestRunner::WebTestDelegate::closeDevTools):
1171         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
1172         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1173         (WebTestRunner::TestRunner::TestRunner):
1174         (WebTestRunner::TestRunner::showWebInspector):
1175         (WebTestRunner):
1176         (WebTestRunner::TestRunner::closeWebInspector):
1177         (WebTestRunner::TestRunner::evaluateInWebInspector):
1178         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1179         (TestRunner):
1180         * DumpRenderTree/chromium/WebViewHost.cpp:
1181         (WebViewHost::showDevTools):
1182         (WebViewHost::closeDevTools):
1183         (WebViewHost::evaluateInWebInspector):
1184         * DumpRenderTree/chromium/WebViewHost.h:
1185         (WebViewHost):
1186
1187 2013-01-11  Julie Parent  <jparent@chromium.org>
1188
1189         Builder should not be a valid parameter for stats dashboard
1190         https://bugs.webkit.org/show_bug.cgi?id=106698
1191
1192         Reviewed by Dirk Pranke.
1193         
1194         Since builder is a dashboard specific parameter, dashboard_base
1195         should not be handling it in handleValidHashParameterWrapper, rather,
1196         each specific dashboard should in its handleValidHashParameter function.
1197     
1198         Note that the FIXME in dashboard_base about this was actually wrong -
1199         we don't want to move it to g_crossDashboardState, because it isn't
1200         actually cross dashboard state.
1201         
1202         In fact, flakiness and treemap have the code in 
1203         handleValidHashParameter, but it is currently dead code because 
1204         dashboard_base gets to it first.
1205         
1206         Added the proper handling to timeline_explorer, since builder is
1207         valid there.
1208
1209         * TestResultServer/static-dashboards/dashboard_base.js:
1210         * TestResultServer/static-dashboards/timeline_explorer.html:
1211
1212 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1213
1214         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
1215         https://bugs.webkit.org/show_bug.cgi?id=106688
1216
1217         Reviewed by Eric Seidel.
1218
1219         Update the regular expression used to strip the garbage at the beginning.
1220
1221         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1222         (RunWebKitTests.nrwt_log_message_regexp):
1223
1224 2013-01-11  Pratik Solanki  <psolanki@apple.com>
1225
1226         TestRunner leaks when running tests
1227         https://bugs.webkit.org/show_bug.cgi?id=106683
1228
1229         Reviewed by Simon Fraser.
1230
1231         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
1232         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
1233         tests.
1234
1235         * DumpRenderTree/TestRunner.cpp:
1236         (TestRunner::makeWindowObject):
1237
1238 2013-01-11  Julie Parent  <jparent@chromium.org>
1239
1240         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
1241         https://bugs.webkit.org/show_bug.cgi?id=106247
1242
1243         Old code nulled out the loader instance when it completed loading and
1244         then later used the fact that it was null to determine if it had loaded
1245         or not.  This is not only unintuitive, but it also prevents using the
1246         loader object later on.
1247         
1248         Added new method, used it, added unit test for it.
1249         
1250         Reviewed by Dirk Pranke.
1251
1252         * TestResultServer/static-dashboards/dashboard_base.js:
1253         (resourceLoadingComplete):
1254         (handleLocationChange):
1255         * TestResultServer/static-dashboards/loader.js:
1256         (.):
1257         * TestResultServer/static-dashboards/loader_unittests.js:
1258
1259 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1260
1261         Try CRLF to LF change in r139407 again.
1262
1263         * BuildSlaveSupport/delete-stale-build-files:
1264         (main):
1265         (webkitBuildDirectory):
1266         * BuildSlaveSupport/kill-old-processes:
1267         (main):
1268
1269 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1270
1271         [GTK] Disable the unit tests timeout when running from make check
1272         https://bugs.webkit.org/show_bug.cgi?id=106670
1273
1274         Reviewed by Philippe Normand.
1275
1276         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
1277
1278 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1279
1280         Yet another unreviewed fix after r139431.
1281
1282         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
1283         the correct order.
1284
1285 2013-01-11  Dan Carney  <dcarney@google.com>
1286
1287         [chromium] move some whitespace and resize related methods to TestRunner library
1288         https://bugs.webkit.org/show_bug.cgi?id=106655
1289
1290         Reviewed by Jochen Eisinger.
1291
1292         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1293         (DRTTestRunner::DRTTestRunner):
1294         * DumpRenderTree/chromium/DRTTestRunner.h:
1295         (DRTTestRunner):
1296         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1297         (WebKit):
1298         (WebTestRunner::WebTestDelegate::setClientWindowRect):
1299         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
1300         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
1301         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1302         (WebTestRunner::TestRunner::TestRunner):
1303         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
1304         (WebTestRunner):
1305         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
1306         (WebTestRunner::TestRunner::enableAutoResizeMode):
1307         (WebTestRunner::TestRunner::disableAutoResizeMode):
1308         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1309         (TestRunner):
1310         * DumpRenderTree/chromium/WebViewHost.cpp:
1311         (WebViewHost::setClientWindowRect):
1312         * DumpRenderTree/chromium/WebViewHost.h:
1313         (WebViewHost):
1314
1315 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
1316
1317         Unreviewed. Update my e-mail addresses.
1318
1319         * Scripts/webkitpy/common/config/committers.py:
1320
1321 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1322
1323         Another unreviewed fix after r139431.
1324
1325         In a way, this is also a generic bug fix, since previously isEfl()
1326         would fail when called from run-efl-tests and we thus did not use
1327         jhbuild to run our tests. This now resulted in us calling
1328         "jhbuild-wrapper run" without specifying a platform.
1329
1330         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
1331         to work.
1332
1333 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1334
1335         [Qt][WK1] Web Audio support
1336         https://bugs.webkit.org/show_bug.cgi?id=106651
1337
1338         Reviewed by Jocelyn Turcotte.
1339
1340         Implements support for dumping audio data in DumpRenderTree.
1341
1342         Adds WebAudio to toggleable features in QtTestBrowser.
1343
1344         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
1345         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
1346
1347         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1348         (WebCore::DumpRenderTree::dump):
1349         * DumpRenderTree/qt/TestRunnerQt.cpp:
1350         (TestRunner::reset):
1351         (TestRunner::overridePreference):
1352         (TestRunner::setAudioData):
1353         * DumpRenderTree/qt/TestRunnerQt.h:
1354         (TestRunner::shouldDumpAsAudio):
1355         (TestRunner::audioData):
1356         (TestRunner):
1357         * QtTestBrowser/launcherwindow.cpp:
1358         (LauncherWindow::applyPrefs):
1359         (LauncherWindow::createChrome):
1360         (LauncherWindow::toggleWebAudio):
1361         * QtTestBrowser/launcherwindow.h:
1362         (WindowOptions::WindowOptions):
1363         (WindowOptions):
1364         (LauncherWindow):
1365         * qmake/mkspecs/features/features.prf:
1366         * qmake/mkspecs/features/features.pri:
1367
1368 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1369
1370         Unreviewed jhbuild-related fix after r139431.
1371
1372         * Scripts/webkitpy/layout_tests/port/efl.py:
1373         (EflPort.__init__): Pass a string to set_option_default(), since
1374         shlex.split() will be called on it later.
1375
1376 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
1377
1378         Unreviewed typo fixes after r139431.
1379
1380         * Scripts/run-javascriptcore-tests:
1381
1382 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1383
1384         [jhbuild] Remove the "run-with-jhbuild" scripts.
1385         https://bugs.webkit.org/show_bug.cgi?id=106572
1386
1387         Reviewed by Martin Robinson.
1388
1389         Both ports which use jhbuild were mostly duplicating the
1390         `run-with-jhbuild' script in their own directories for no clear reason.
1391
1392         The script itself was just a thin wrapper around the `jhbuild-wrapper',
1393         so just start using that directly and get rid of a useless middle man.
1394
1395         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
1396         instead.
1397
1398         * Scripts/run-javascriptcore-tests:
1399         * Scripts/run-launcher:
1400         * Scripts/webkitdirs.pm:
1401         (runAutogenForAutotoolsProjectIfNecessary):
1402         (buildAutotoolsProject):
1403         (jhbuildWrapperPrefixIfNeeded):
1404         (generateBuildSystemFromCMakeProject):
1405         (buildCMakeGeneratedProject):
1406         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1407         (run):
1408         * Scripts/webkitpy/layout_tests/port/efl.py:
1409         (EflPort.__init__):
1410         (EflPort._image_diff_command):
1411         * efl/run-with-jhbuild: Removed.
1412         * gtk/run-with-jhbuild: Removed.
1413
1414 2013-01-11  Alan Cutter  <alancutter@chromium.org>
1415
1416         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
1417         https://bugs.webkit.org/show_bug.cgi?id=106636
1418
1419         Reviewed by Adam Barth.
1420
1421         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
1422
1423         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1424         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1425         * EWSTools/screen-config:
1426         * EWSTools/start-queue.sh:
1427
1428 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1429
1430         kill-old-processes and delete-stale-build-files use CRLF linebreaks
1431         https://bugs.webkit.org/show_bug.cgi?id=106622
1432
1433         Reviewed by Simon Fraser.
1434
1435         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
1436         Also escape clang\+\+ correctly in kill-old-processes.
1437
1438         * BuildSlaveSupport/delete-stale-build-files:
1439         * BuildSlaveSupport/kill-old-processes:
1440
1441 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1442
1443         Build fix after r139357. It was missing a comma.
1444
1445         * QueueStatusServer/model/queues.py:
1446         (Queue):
1447
1448 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1449
1450         Fixing AuthenticationError when running test-webkitpy as a non-committer.
1451         https://bugs.webkit.org/show_bug.cgi?id=106420
1452
1453         Reviewed by Eric Seidel.
1454
1455         * Scripts/webkitpy/common/checkout/scm/git.py:
1456         (Git.push_local_commits_to_server):
1457         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1458         * Scripts/webkitpy/common/checkout/scm/svn.py:
1459         (SVNRepository):
1460         (SVNRepository.has_authorization_for_realm):
1461
1462 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
1463
1464         [EFL][jhbuild] Use tarballs for gstreamer instead of git
1465         https://bugs.webkit.org/show_bug.cgi?id=106552
1466
1467         Reviewed by Laszlo Gombos.
1468
1469         Use tarballs for gstreamer instead of git in EFL's jhbuild
1470         to work around intermittent network issues on our build
1471         bots. Tarballs are fully cached and require no network
1472         operation if their checksum matches.
1473
1474         * efl/jhbuild.modules:
1475
1476 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1477
1478         Add Mac WK2 EWS bots
1479         https://bugs.webkit.org/show_bug.cgi?id=106590
1480
1481         Reviewed by Adam Barth.
1482
1483         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
1484         Also add a deprecated MacWK2Port class.
1485
1486         * QueueStatusServer/model/queues.py:
1487         (Queue):
1488         * Scripts/webkitpy/common/config/ports.py:
1489         (DeprecatedPort.port):
1490         (MacWK2Port):
1491         (MacWK2Port.run_webkit_tests_command):
1492         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1493         (MacEWS):
1494         (MacWK2EWS):
1495         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1496         (_test_ewses):
1497
1498 2013-01-10  Dan Carney  <dcarney@google.com>
1499
1500         [chromium] move webpermissionclient related methods to TestRunner library
1501         https://bugs.webkit.org/show_bug.cgi?id=106548
1502
1503         Reviewed by Jochen Eisinger.
1504
1505         * DumpRenderTree/DumpRenderTree.gypi:
1506         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1507         (DRTTestRunner::DRTTestRunner):
1508         (DRTTestRunner::reset):
1509         * DumpRenderTree/chromium/DRTTestRunner.h:
1510         (DRTTestRunner):
1511         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1512         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
1513         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1514         (WebKit):
1515         (WebTestRunner::WebTestRunner::webPermissions):
1516         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1517         (WebTestRunner::TestRunner::TestRunner):
1518         (WebTestRunner::TestRunner::setDelegate):
1519         (WebTestRunner):
1520         (WebTestRunner::TestRunner::reset):
1521         (WebTestRunner::TestRunner::webPermissions):
1522         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
1523         (WebTestRunner::TestRunner::setImagesAllowed):
1524         (WebTestRunner::TestRunner::setScriptsAllowed):
1525         (WebTestRunner::TestRunner::setStorageAllowed):
1526         (WebTestRunner::TestRunner::setPluginsAllowed):
1527         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
1528         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
1529         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1530         (WebTestRunner):
1531         (TestRunner):
1532         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
1533         (WebTestRunner):
1534         (WebTestRunner::WebPermissions::WebPermissions):
1535         (WebTestRunner::WebPermissions::~WebPermissions):
1536         (WebTestRunner::WebPermissions::allowImage):
1537         (WebTestRunner::WebPermissions::allowScriptFromSource):
1538         (WebTestRunner::WebPermissions::allowStorage):
1539         (WebTestRunner::WebPermissions::allowPlugins):
1540         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
1541         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
1542         (WebTestRunner::WebPermissions::setImagesAllowed):
1543         (WebTestRunner::WebPermissions::setScriptsAllowed):
1544         (WebTestRunner::WebPermissions::setStorageAllowed):
1545         (WebTestRunner::WebPermissions::setPluginsAllowed):
1546         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
1547         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
1548         (WebTestRunner::WebPermissions::setDelegate):
1549         (WebTestRunner::WebPermissions::setDumpCallbacks):
1550         (WebTestRunner::WebPermissions::reset):
1551         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
1552         (WebTestRunner):
1553         (WebPermissions):
1554         * DumpRenderTree/chromium/TestShell.cpp:
1555         (TestShell::initialize):
1556         (TestShell::resetTestController):
1557         (TestShell::createNewWindow):
1558         * DumpRenderTree/chromium/TestShell.h:
1559         (TestShell):
1560         * DumpRenderTree/chromium/WebViewHost.cpp:
1561         (WebViewHost::normalizeLayoutTestURL):
1562         * DumpRenderTree/chromium/WebViewHost.h:
1563         (WebViewHost):
1564
1565 2013-01-10  Alan Cutter  <alancutter@chromium.org>
1566
1567         Split EWS tool cold-boot.sh into modular components
1568         https://bugs.webkit.org/show_bug.cgi?id=106527
1569
1570         Reviewed by Adam Barth.
1571
1572         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
1573         Updated GCE bot build scripts to match.
1574         Unable to test scripts directly as they depend on being in the repository to work!
1575
1576         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1577         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1578         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
1579         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
1580         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
1581
1582 2013-01-10  Julie Parent  <jparent@chromium.org>
1583
1584         Dashboard Cleanup: Do not generate the page if we are about to reload.
1585         https://bugs.webkit.org/show_bug.cgi?id=106584
1586
1587         Reviewed by Dirk Pranke.
1588
1589         Move the logic to determine if we should generate the page into
1590         parseParameters() since that is where we have the knowledge to
1591         determine it, and return that value to handleLocationChange, 
1592         rather than passing the changed parameters back to handleLocationChange
1593         and having it make the decision.
1594         
1595         This is logically equivalent, save one case: when we are about to do
1596         a reload, we know that there is no reason to generate the page.  Old
1597         code was causing an extra page generation in this case.
1598         
1599         * TestResultServer/static-dashboards/dashboard_base.js:
1600         (parseParameters):
1601         (handleLocationChange):
1602
1603 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1604
1605         [jhbuild] Use the "configure" script to build glib
1606         https://bugs.webkit.org/show_bug.cgi?id=106569
1607
1608         Reviewed by Martin Robinson.
1609
1610         So far both EFL and GTK have been using autogen.sh to build glib.
1611         While that does work most of the time, it's not really needed since
1612         we are downloading and building stable releases from tarballs.
1613         Additionally, autogen.sh fails to work with automake 1.13 due to the
1614         usage of some macros that have been removed (this has already been
1615         fixed in glib master).
1616
1617         * efl/jhbuild.modules:
1618         * gtk/jhbuild.modules:
1619
1620 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1621
1622         Changing tests to be consistent and use self.scm rather then recreating the scm object.
1623         (Missed a couple)
1624         https://bugs.webkit.org/show_bug.cgi?id=106536
1625
1626         Reviewed by Eric Seidel.
1627
1628         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1629
1630 2013-01-10  Tony Chang  <tony@chromium.org>
1631
1632         Speed up supplemental dependency computation
1633         https://bugs.webkit.org/show_bug.cgi?id=106503
1634
1635         Reviewed by Adam Barth.
1636
1637         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
1638
1639         * WebKitTestRunner/CMakeLists.txt:
1640
1641 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
1642
1643         Remove the ENABLE_ANIMATION_API feature define occurences
1644         https://bugs.webkit.org/show_bug.cgi?id=106544
1645
1646         Reviewed by Simon Fraser.
1647
1648         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
1649         feature define handling still lingers in various build systems and configurations
1650         but is of no use, so it should be removed.
1651
1652         * Scripts/webkitperl/FeatureList.pm:
1653         * qmake/mkspecs/features/features.pri:
1654
1655 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1656
1657         [GTK] Add support for loading web process extensions
1658         https://bugs.webkit.org/show_bug.cgi?id=105631
1659
1660         Reviewed by Gustavo Noronha Silva.
1661
1662         * MiniBrowser/gtk/GNUmakefile.am:
1663         * MiniBrowser/gtk/main.c:
1664         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
1665         bundle lib from build dir.
1666         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
1667         located in WebProcess/InjectedBundle/API/gtk.
1668         * gtk/generate-gtkdoc:
1669         (get_webkit2_options): Scan also files in
1670         WebProcess/InjectedBundle/API/gtk to generate API docs.
1671         (get_webkit2_options.injected_bundle_src_path): Helper function to
1672         build paths in WebProcess/InjectedBundle/API/gtk.
1673
1674 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1675
1676         [EFL][WK2] Writing immediately to created windows (open) fails
1677         https://bugs.webkit.org/show_bug.cgi?id=105276
1678
1679         Reviewed by Kenneth Rohde Christiansen.
1680
1681         Do not reset 'about:blank' url for the new pages in mini browser.
1682
1683         * MiniBrowser/efl/main.c:
1684         (window_create):
1685
1686 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1687
1688         Changing tests to be consistent and use self.scm rather then recreating the scm object.
1689         https://bugs.webkit.org/show_bug.cgi?id=106536
1690
1691         Reviewed by Eric Seidel.
1692
1693         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1694
1695 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1696
1697         Converting to unittest2 so we can use assertItemsEqual, making tests
1698         not dependent on order of items.
1699         https://bugs.webkit.org/show_bug.cgi?id=106532
1700
1701         Before:
1702         Ran 1733 tests in 38.385s
1703         FAILED (failures=1, errors=22)
1704
1705         After:
1706         Ran 1733 tests in 32.298s
1707         FAILED (failures=0, errors=22)
1708
1709         Reviewed by Eric Seidel.
1710
1711         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1712         * Scripts/webkitpy/thirdparty/__init__.py:
1713         (AutoinstallImportHook._install_unittest2):
1714
1715 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
1716
1717         [EFL] Add gstreamer 1.0.5 to jhbuild
1718         https://bugs.webkit.org/show_bug.cgi?id=106178
1719
1720         Reviewed by Laszlo Gombos.
1721
1722         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
1723
1724         * efl/jhbuild.modules:
1725
1726 2013-01-09  Alan Cutter  <alancutter@chromium.org>
1727
1728         Updated parameters in GCE build scripts so they now work.
1729         https://bugs.webkit.org/show_bug.cgi?id=106523
1730
1731         Reviewed by Adam Barth.
1732
1733         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1734         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1735         * EWSTools/cold-boot.sh:
1736
1737 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
1738
1739         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
1740         https://bugs.webkit.org/show_bug.cgi?id=106520
1741
1742         Reviewed by James Robinson.
1743
1744         Part of a larger refactoring series. See tracking bug 82948.
1745
1746         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1747         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1748
1749 2013-01-09  Julie Parent  <jparent@chromium.org>
1750
1751         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
1752         https://bugs.webkit.org/show_bug.cgi?id=106514
1753
1754         This is old code, as these can no longer get out of sync.
1755         permmaLinkURLHash is generated from currentState, which is set only
1756         from the location.  The commment about how these can get out of sync
1757         refers to a function that no longer exists.
1758         
1759         Reviewed by Dirk Pranke.
1760
1761         * TestResultServer/static-dashboards/dashboard_base.js:
1762         (handleLocationChange):
1763
1764 2013-01-09  Julie Parent  <jparent@chromium.org>
1765
1766         Dashboard Cleanup: Reload the page as soon as we know we need to.
1767         https://bugs.webkit.org/show_bug.cgi?id=106515
1768
1769         No need to continue parsing all of the data once we know that
1770         we need to do a reload.
1771         
1772         Reviewed by Dirk Pranke.
1773
1774         * TestResultServer/static-dashboards/dashboard_base.js:
1775         (parseParameters):
1776
1777 2013-01-09  Eric Seidel  <eric@webkit.org>
1778
1779         run-perf-tests --chromium-android --profile should show symbols for the kernel
1780         https://bugs.webkit.org/show_bug.cgi?id=106498
1781
1782         Reviewed by Adam Barth.
1783
1784         Turns out this was easy, once I finally read the output from "perf report".
1785         It appears there may be a bug in "perf record" on android, as it complains
1786         about not being able to read from /proc/kallsyms even when
1787         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
1788         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
1789         but rather just flip it to 0 long enough to grab the /proc/kallsyms
1790         and then flip it back to whatever the device had.
1791
1792         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
1793         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
1794         to symbol names.  Its world-readable, but will return all 0s if you
1795         don't have permission to see the kernel symbols.  kptr_restrict
1796         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
1797         1 is only a specific group, and 2 is "no one, not even root".
1798         By default kptr_restrict is 2 on Android it seems.
1799         More kptr_restrict docs: http://lwn.net/Articles/420403/
1800
1801         I also took this opportunity to clean up how the perf record command
1802         was built for use/display in AndroidPerf.profile_after_exit and
1803         change to always using long-form names for the arguments (to hopefully help readability).
1804
1805         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1806         (AndroidPerf.__init__):
1807         (profile_after_exit):
1808         (ChromiumAndroidDriver.__init__):
1809         (ChromiumAndroidDriver._update_kallsyms_cache):
1810         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1811
1812 2013-01-09  Julie Parent  <jparent@chromium.org>
1813
1814         Dashboard cleanup: remove dead code.
1815         https://bugs.webkit.org/show_bug.cgi?id=106509
1816
1817         Reviewed by Dirk Pranke.
1818
1819         * TestResultServer/static-dashboards/dashboard_base.js:
1820         (parseParameters):
1821
1822 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
1823
1824         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
1825         https://bugs.webkit.org/show_bug.cgi?id=105638
1826
1827         Reviewed by Martin Robinson.
1828
1829         The test was failing for two reasons:
1830         - AccessibilityRenderObject::correspondingLabelForControlElement() was
1831           not ignoring the ARIA labelled-by property
1832         - AccessibilityController::accessibleElementById() was not implemented
1833
1834         Because getting an element by ID cannot be done in the UIProcess, the
1835         decision was made to expose the element's ID as an accessible attribute
1836         of the object.
1837
1838         In addition, fixing the bug in AccessibilityRenderObject made it possible
1839         to eliminate the Gtk platform-specific expectations for another test.
1840
1841         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1842         (childElementById): Added. Walks the tree looking for the AtkObject
1843         Attribute which exposes the HTML element's ID.
1844         (AccessibilityController::accessibleElementById): Implemented.
1845         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1846         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
1847         when there is no title, as is done with the Mac port.
1848         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1849         (WTR):
1850         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1851         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
1852         Attribute which exposes the HTML element's ID.
1853         (WTR):
1854         (WTR::AccessibilityController::accessibleElementById): Implemented.
1855         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1856         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
1857         even when there is no title, as is done with the Mac port.
1858
1859 2013-01-09  Gregg Tavares  <gman@google.com>
1860
1861         Add Gregg Tavares as a committer
1862         https://bugs.webkit.org/show_bug.cgi?id=106492
1863
1864         Unreviewed.
1865
1866         * Scripts/webkitpy/common/config/committers.py:
1867
1868 2013-01-09  Roger Fong  <roger_fong@apple.com>
1869
1870         Enable seamless iFrames for Windows DRT.
1871         https://bugs.webkit.org/show_bug.cgi?id=106468.
1872
1873         Rubberstamped by Timothy Horton.
1874
1875         * DumpRenderTree/win/DumpRenderTree.cpp:
1876         (resetDefaultsToConsistentValues):
1877
1878 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
1879
1880         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
1881         https://bugs.webkit.org/show_bug.cgi?id=93979
1882
1883         Reviewed by Benjamin Poulain.
1884
1885         Implement eventSender.scheduleAsynchronousKeyDown() in
1886         WebKitTestRunner.
1887
1888         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1889         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1890         (WTR::createKeyDownMessageBody):
1891         (WTR::EventSendingController::keyDown):
1892         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1893         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1894         (EventSendingController):
1895         * WebKitTestRunner/TestController.cpp:
1896         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
1897         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1898         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1899         * WebKitTestRunner/TestController.h:
1900         (TestController):
1901
1902 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
1903
1904         [chromium] move resource load callback dumping to TestRunner library
1905         https://bugs.webkit.org/show_bug.cgi?id=106449
1906
1907         Reviewed by Adam Barth.
1908
1909         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1910         (DRTTestRunner::DRTTestRunner):
1911         (DRTTestRunner::reset):
1912         * DumpRenderTree/chromium/DRTTestRunner.h:
1913         (DRTTestRunner):
1914         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1915         (WebKit):
1916         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
1917         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1918         (WebKit):
1919         (WebTestProxyBase):
1920         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
1921         (WebTestRunner::WebTestProxy::willRequestResource):
1922         (WebTestRunner::WebTestProxy::willSendRequest):
1923         (WebTestRunner::WebTestProxy::didReceiveResponse):
1924         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
1925         (WebTestRunner::WebTestProxy::didFailResourceLoad):
1926         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1927         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
1928         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
1929         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
1930         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1931         (WebTestRunner::TestRunner::TestRunner):
1932         (WebTestRunner::TestRunner::reset):
1933         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
1934         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
1935         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
1936         (WebTestRunner):
1937         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
1938         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
1939         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
1940         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1941         (TestRunner):
1942         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1943         (WebTestRunner::WebTestProxyBase::reset):
1944         (WebTestRunner):
1945         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
1946         (WebTestRunner::WebTestProxyBase::willRequestResource):
1947         (WebTestRunner::WebTestProxyBase::willSendRequest):
1948         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
1949         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
1950         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
1951         * DumpRenderTree/chromium/WebViewHost.cpp:
1952         (WebViewHost::willSendRequest):
1953         (WebViewHost::makeURLErrorDescription):
1954         (WebViewHost::reset):
1955         * DumpRenderTree/chromium/WebViewHost.h:
1956         (WebViewHost):
1957
1958 2013-01-09  Dan Carney  <dcarney@google.com>
1959
1960         [chromium] move dumpcreateview methods to testrunner library
1961         https://bugs.webkit.org/show_bug.cgi?id=106434
1962
1963         Reviewed by Adam Barth.
1964
1965         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1966         (DRTTestRunner::DRTTestRunner):
1967         (DRTTestRunner::reset):
1968         * DumpRenderTree/chromium/DRTTestRunner.h:
1969         (DRTTestRunner):
1970         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1971         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
1972         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1973         (WebTestRunner::TestRunner::TestRunner):
1974         (WebTestRunner::TestRunner::reset):
1975         (WebTestRunner::TestRunner::shouldDumpCreateView):
1976         (WebTestRunner):
1977         (WebTestRunner::TestRunner::dumpCreateView):
1978         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1979         (TestRunner):
1980
1981 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
1982
1983         webkitpy cleanup: Merge additional_comment_text into comment_text
1984         https://bugs.webkit.org/show_bug.cgi?id=106421
1985
1986         Reviewed by Adam Barth.
1987
1988         * Scripts/webkitpy/common/config/committervalidator.py:
1989         (CommitterValidator.reject_patch_from_commit_queue):
1990         (CommitterValidator.reject_patch_from_review_queue):
1991         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1992         (Bugzilla.set_flag_on_attachment):
1993         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1994         (MockBugzilla.set_flag_on_attachment):
1995         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1996         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1997         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
1998         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1999
2000 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
2001
2002         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
2003         https://bugs.webkit.org/show_bug.cgi?id=106464
2004
2005         Reviewed by Martin Robinson.
2006
2007         Current version in jhbuild.modules (2.26.0) is giving trouble to
2008         when trying to build WebKitGTK from scratch, due to a segmentation
2009         fault error in gdk-pixbuf-query-loader during the 'make'
2010         phase. Raising the version to 2.26.5 fixes this issue.
2011
2012         * gtk/jhbuild.modules: Version raised, checksums updated.
2013
2014 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
2015
2016         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
2017         https://bugs.webkit.org/show_bug.cgi?id=90968.
2018
2019         Reviewed by Csaba Osztrogonác.
2020
2021         Added functionality in DRT and WTR to use any timeout value while running
2022         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
2023         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
2024         to indicate whether the current port supports setting timeout value
2025         per test (it's False by default; I enabled it only on Qt).
2026         Also corrected a typo in driver.py
2027
2028         * DumpRenderTree/DumpRenderTree.h:
2029         (TestCommand::TestCommand):
2030         (TestCommand):
2031         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2032         (parseInputLine):
2033         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2034         (WebCore::DumpRenderTree::processLine):
2035         * Scripts/webkitpy/layout_tests/port/base.py:
2036         (Port.supports_per_test_timeout):
2037         * Scripts/webkitpy/layout_tests/port/driver.py:
2038         (Driver.run_test):
2039         (Driver._command_from_driver_input):
2040         * Scripts/webkitpy/layout_tests/port/qt.py:
2041         (QtPort.supports_per_test_timeout):
2042         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2043         (WTR::InjectedBundle::InjectedBundle):
2044         (WTR::InjectedBundle::didReceiveMessage):
2045         (WTR::InjectedBundle::beginTesting):
2046         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2047         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2048         (WTR::TestRunner::setCustomTimeout):
2049         (WTR):
2050         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2051         (TestRunner):
2052         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
2053         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2054         * WebKitTestRunner/TestController.cpp:
2055         (WTR::TestController::TestController):
2056         (WTR::TestController::getCustomTimeout):
2057         (WTR):
2058         (WTR::TestCommand::TestCommand):
2059         (TestCommand):
2060         (WTR::parseInputLine):
2061         (WTR::TestController::runTest):
2062         (WTR::TestController::runUntil):
2063         * WebKitTestRunner/TestController.h:
2064         (TestController):
2065         * WebKitTestRunner/TestInvocation.cpp:
2066         (WTR::TestInvocation::TestInvocation):
2067         (WTR::TestInvocation::setCustomTimeout):
2068         (WTR):
2069         (WTR::TestInvocation::invoke):
2070         * WebKitTestRunner/TestInvocation.h:
2071         (TestInvocation):
2072
2073 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2074
2075         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
2076         https://bugs.webkit.org/show_bug.cgi?id=106290
2077
2078         Reviewed by Martin Robinson.
2079
2080         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
2081         the macro isn't enabled.
2082
2083         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2084
2085 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
2086
2087         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
2088         https://bugs.webkit.org/show_bug.cgi?id=103653
2089
2090         Reviewed by Anders Carlsson.
2091
2092         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
2093         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
2094         client callback.
2095
2096         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
2097         methods to the JavaScript API.
2098         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2099         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
2100         (WTR::TestRunner::setAuthenticationUsername): Ditto.
2101         (WTR::TestRunner::setAuthenticationPassword): Ditto.
2102         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2103         (TestRunner): Added new declarations for the above.
2104         * WebKitTestRunner/TestController.cpp:
2105         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
2106         callback.
2107         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
2108         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
2109         the authentication information passed from the InjectedBundle.
2110         * WebKitTestRunner/TestController.h:
2111         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
2112         to communicate with the TestController.
2113         (WTR::TestController::setAuthenticationUsername): Ditto.
2114         (WTR::TestController::setAuthenticationPassword): Ditto.
2115         (TestController):
2116         * WebKitTestRunner/TestInvocation.cpp:
2117         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
2118         information from the InjectedBundle.
2119         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
2120         text to the TestInvocation text output.
2121         * WebKitTestRunner/TestInvocation.h:
2122         (TestInvocation): Added declaration for new method.
2123
2124 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
2125
2126         Add myself as a watcher for Web Geolocation
2127
2128         Unreviewed.
2129
2130         * Scripts/webkitpy/common/config/watchlist:
2131
2132 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2133
2134         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
2135         https://bugs.webkit.org/show_bug.cgi?id=106364
2136
2137         Reviewed by Eric Seidel.
2138
2139         When the setup_test_run method is called on the subclasses of the base Port
2140         interface, the parent method should also be called via super(), despite the
2141         parent method not doing anything at the moment.
2142
2143         The according calls to super() are required in the ChromiumPort, EflPort
2144         and GtkPort implementations.
2145
2146         * Scripts/webkitpy/layout_tests/port/chromium.py:
2147         (ChromiumPort.setup_test_run):
2148         * Scripts/webkitpy/layout_tests/port/efl.py:
2149         (EflPort.setup_test_run):
2150         * Scripts/webkitpy/layout_tests/port/gtk.py:
2151         (GtkPort.setup_test_run):
2152
2153 2013-01-08  Julie Parent  <jparent@chromium.org>
2154
2155         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
2156         https://bugs.webkit.org/show_bug.cgi?id=106356
2157
2158         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
2159         dashboard_base, assigned by Loader, and used only by dashboard_base to
2160         create error messages.  Moved the variables to be privates on the Loader
2161         object, moved error message creation to _getLoadingErrorMessages on the
2162         Loader object, and now pass the errors back to dashboard base via the
2163         resourceLoadingComplete callback.
2164         
2165         Also removed the now unused clearError function, it was only being used
2166         by unit tests to clean up global state.
2167         
2168         Reviewed by Dirk Pranke.
2169
2170         * TestResultServer/static-dashboards/dashboard_base.js:
2171         (resourceLoadingComplete):
2172         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2173         * TestResultServer/static-dashboards/loader.js:
2174         (.):
2175         * TestResultServer/static-dashboards/loader_unittests.js:
2176
2177 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2178
2179         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
2180         https://bugs.webkit.org/show_bug.cgi?id=106354
2181
2182         Reviewed by Eric Seidel.
2183
2184         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
2185         instead of those two inheriting from it. Also add a mock object of the
2186         sanitizer that's used in unit tests.
2187
2188         * Scripts/webkitpy/layout_tests/port/efl.py:
2189         (EflPort):
2190         (EflPort.__init__):
2191         (EflPort.setup_test_run):
2192         (EflPort.clean_up_test_run):
2193         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
2194         importing order.
2195         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
2196         * Scripts/webkitpy/layout_tests/port/gtk.py:
2197         (GtkPort):
2198         (GtkPort.__init__):
2199         (GtkPort.setup_test_run):
2200         (GtkPort.clean_up_test_run):
2201         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
2202         importing order.
2203         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
2204         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
2205         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
2206         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
2207         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
2208         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
2209         (PulseAudioSanitizerMock.unload_pulseaudio_module):
2210         (PulseAudioSanitizerMock.restore_pulseaudio_module):
2211
2212 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
2213
2214         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
2215         https://bugs.webkit.org/show_bug.cgi?id=106324
2216
2217         Reviewed by Adam Barth.
2218
2219         Since the frame load callbacks are part of the WebFrameClient, the
2220         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
2221         methods.
2222
2223         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2224         (DRTTestRunner::DRTTestRunner):
2225         (DRTTestRunner::reset):
2226         * DumpRenderTree/chromium/DRTTestRunner.h:
2227         (DRTTestRunner):
2228         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2229         (WebTestInterfaces):
2230         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2231         (WebKit):
2232         (WebTestProxyBase):
2233         (WebTestRunner):
2234         (WebTestRunner::WebTestProxy::WebTestProxy):
2235         (WebTestProxy):
2236         (WebTestRunner::WebTestProxy::didInvalidateRect):
2237         (WebTestRunner::WebTestProxy::didScrollRect):
2238         (WebTestRunner::WebTestProxy::scheduleComposite):
2239         (WebTestRunner::WebTestProxy::scheduleAnimation):
2240         (WebTestRunner::WebTestProxy::setWindowRect):
2241         (WebTestRunner::WebTestProxy::show):
2242         (WebTestRunner::WebTestProxy::didAutoResize):
2243         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
2244         (WebTestRunner::WebTestProxy::startDragging):
2245         (WebTestRunner::WebTestProxy::shouldBeginEditing):
2246         (WebTestRunner::WebTestProxy::shouldEndEditing):
2247         (WebTestRunner::WebTestProxy::shouldInsertNode):
2248         (WebTestRunner::WebTestProxy::shouldInsertText):
2249         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
2250         (WebTestRunner::WebTestProxy::shouldDeleteRange):
2251         (WebTestRunner::WebTestProxy::shouldApplyStyle):
2252         (WebTestRunner::WebTestProxy::didBeginEditing):
2253         (WebTestRunner::WebTestProxy::didChangeSelection):
2254         (WebTestRunner::WebTestProxy::didChangeContents):
2255         (WebTestRunner::WebTestProxy::didEndEditing):
2256         (WebTestRunner::WebTestProxy::registerIntentService):
2257         (WebTestRunner::WebTestProxy::dispatchIntent):
2258         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
2259         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
2260         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
2261         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
2262         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
2263         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
2264         (WebTestRunner::WebTestProxy::didReceiveTitle):
2265         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
2266         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
2267         (WebTestRunner::WebTestProxy::didFailLoad):
2268         (WebTestRunner::WebTestProxy::didFinishLoad):
2269         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
2270         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
2271         (WebTestRunner::WebTestProxy::didRunInsecureContent):
2272         (WebTestRunner::WebTestProxy::didDetectXSS):
2273         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2274         (WebTestRunner::WebTestRunner::setTestIsRunning):
2275         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
2276         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
2277         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
2278         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
2279         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
2280         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2281         (WebTestRunner::TestRunner::TestRunner):
2282         (WebTestRunner::TestRunner::reset):
2283         (WebTestRunner::TestRunner::setTestIsRunning):
2284         (WebTestRunner):
2285         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
2286         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
2287         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
2288         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
2289         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
2290         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
2291         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
2292         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
2293         (WebTestRunner::TestRunner::dumpTitleChanges):
2294         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2295         (TestRunner):
2296         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2297         (WebTestInterfaces::Internal):
2298         (WebTestRunner::WebTestInterfaces::Internal::webView):
2299         (WebTestRunner::WebTestInterfaces::Internal::Internal):
2300         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
2301         (WebTestRunner):
2302         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
2303         (WebTestRunner::WebTestInterfaces::setWebView):
2304         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
2305         (WebTestRunner::WebTestInterfaces::webView):
2306         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2307         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
2308         (WebTestRunner):
2309         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
2310         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
2311         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
2312         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
2313         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
2314         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2315         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
2316         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
2317         (WebTestRunner::WebTestProxyBase::didFailLoad):
2318         (WebTestRunner::WebTestProxyBase::didFinishLoad):
2319         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
2320         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
2321         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
2322         (WebTestRunner::WebTestProxyBase::didDetectXSS):
2323         * DumpRenderTree/chromium/TestShell.cpp:
2324         (TestShell::runFileTest):
2325         (TestShell::testFinished):
2326         * DumpRenderTree/chromium/TestShell.h:
2327         (TestShell):
2328         * DumpRenderTree/chromium/WebViewHost.cpp:
2329         (WebViewHost::didStartProvisionalLoad):
2330         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
2331         (WebViewHost::didFailProvisionalLoad):
2332         (WebViewHost::didCommitProvisionalLoad):
2333         (WebViewHost::didReceiveTitle):
2334         (WebViewHost::didFailLoad):
2335         (WebViewHost::didFinishLoad):
2336         * DumpRenderTree/chromium/WebViewHost.h:
2337         (WebViewHost):
2338
2339 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2340
2341         [GTK] Lower the default timeout value for WebKitTestRunner
2342         https://bugs.webkit.org/show_bug.cgi?id=106353
2343
2344         Reviewed by Dirk Pranke.
2345
2346         The default timeout value for WebKitTestRunner should be lowered.
2347         The current value (80 seconds) is irrational and just leads to producing
2348         text failures for layout tests that genuinely time out. This just leads
2349         to more deviation from the GTK WK1 port in terms of test expectations.
2350
2351         The value used is the same as when running the DumpRenderTree, that's
2352         6 seconds in release builds and 12 seconds in debug builds.
2353
2354         * Scripts/webkitpy/layout_tests/port/gtk.py:
2355         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2356         (GtkPortTest.test_default_timeout_ms):
2357
2358 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2359
2360         test-webkitpy shows failure output on my linux box
2361         https://bugs.webkit.org/show_bug.cgi?id=101261
2362
2363         Reviewed by Eric Seidel.
2364
2365         Mock out the PulseAudioSanitizer methods when creating testing instances
2366         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
2367         PulseAudio output when the sanitizer was trying to unload modules which
2368         were already unloaded by another unit test that was being run in parallel.
2369
2370         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2371         (EflPortTest):
2372         (EflPortTest.make_port):
2373         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2374         (GtkPortTest):
2375         (GtkPortTest.make_port):
2376
2377 2013-01-08  Julie Parent  <jparent@chromium.org>
2378
2379         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
2380         https://bugs.webkit.org/show_bug.cgi?id=106254
2381
2382         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
2383         only to figure out if we should call addBuilderLoadErrors during
2384         handleLocationChange, which was called when the loader completed and on
2385         any hash change, but we only ever wanted to call addBuilderLoadErrors
2386         on the initial loader load.  Moved the call of addBuilderLoadErrors to
2387         resourceLoadingComplete rather than handleLocationChange, so now we
2388         only call it when we want to, and the check can go away completely.
2389
2390         Reviewed by Dirk Pranke.
2391
2392         * TestResultServer/static-dashboards/dashboard_base.js:
2393         (addBuilderLoadErrors):
2394         (resourceLoadingComplete):
2395         (handleLocationChange):
2396         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2397
2398 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
2399
2400         Add aboxhall@chromium.org to accessibility watchlist.
2401
2402         Unreviewed.
2403
2404         * Scripts/webkitpy/common/config/watchlist:
2405
2406 2013-01-08  Dan Winship  <danw@gnome.org>
2407
2408         Add Apache 2.4 support for Fedora 18
2409         https://bugs.webkit.org/show_bug.cgi?id=104478
2410
2411         Reviewed by Martin Robinson.
2412
2413         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
2414         need a separate config.
2415
2416         * Scripts/webkitpy/layout_tests/port/base.py:
2417         (Port._apache_version):
2418         (Port._apache_config_file_name_for_platform):
2419         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2420         * Scripts/run-webkit-httpd:
2421         * Scripts/webkitperl/httpd.pm:
2422         (getApacheVersion):
2423         (getDefaultConfigForTestDirectory):
2424         (getHTTPDConfigPathForTestDirectory):
2425
2426 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2427
2428         Make the override-feature-defines script compatible with Python v3
2429         https://bugs.webkit.org/show_bug.cgi?id=105742
2430
2431         Reviewed by Martin Robinson.
2432
2433         Instead of printing output through a statement, use the print function and format
2434         the output using the str.format method. This makes the script runnable with Python v3.
2435
2436         * gtk/override-feature-defines:
2437         (adjust_feature_defines_makefile):
2438
2439 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
2440
2441         [Qt] Fix libxml2 config test
2442         https://bugs.webkit.org/show_bug.cgi?id=106317
2443
2444         Reviewed by Simon Hausmann.
2445
2446         Don't assume standard include/libxml2, libxml-2.0.pc should know
2447         where it's headers are.
2448
2449         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
2450
2451 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2452
2453         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
2454         https://bugs.webkit.org/show_bug.cgi?id=106195
2455
2456         Reviewed by Philippe Normand.
2457
2458         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
2459         to make the Python code compatible with Python 3. This includes modifying
2460         print statements, exception handling, dictionary iteration and
2461         byte-sequence-to-string conversion.
2462
2463         * gtk/common.py:
2464         (get_build_path):
2465         (pkg_config_file_variable):
2466         (gtk_version_of_pkg_config_file):
2467         * gtk/generate-gtkdoc:
2468         (print_missing_api):
2469         * gtk/gtkdoc.py:
2470         (GTKDoc.__init__):
2471         (GTKDoc._run_command):
2472
2473 2013-01-02  Steve Block  <steveblock@chromium.org>
2474
2475         Add chromium.org email address for Steve Block.
2476
2477         Unreviewed.
2478
2479         * Scripts/webkitpy/common/config/committers.py:
2480
2481 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
2482
2483         Rationalize closure call heuristics and profiling
2484         https://bugs.webkit.org/show_bug.cgi?id=106270
2485
2486         Reviewed by Oliver Hunt.
2487         
2488         Add ability to use display-profiler-output via a pipe, and add the ability to dump
2489         all generated code ('display *' or 'd *').
2490
2491         * Scripts/display-profiler-output:
2492
2493 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2494
2495         Sorted more xcodeproj files.
2496
2497         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2499         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2500
2501 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2502
2503         Sorted xcodeproj files.
2504
2505         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2506         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2507
2508 2013-01-07  Dan Bernstein  <mitz@apple.com>
2509
2510         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
2511         https://bugs.webkit.org/show_bug.cgi?id=106261
2512
2513         Reviewed by Simon Fraser.
2514
2515         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
2516
2517         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2518         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
2519         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
2520         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
2521         (TestWebKitAPI):
2522         (TestWebKitAPI::TEST):
2523
2524 2013-01-07  Ojan Vafai  <ojan@chromium.org>
2525
2526         Add the Apple MountainLion bots to garden-o-matic.
2527         Eventually, we really should move away from hardcoding
2528         the list of bots.
2529
2530         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2531
2532 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
2533
2534         [chromium] move web audio related methods to testrunner library
2535         https://bugs.webkit.org/show_bug.cgi?id=106211
2536
2537         Reviewed by Adam Barth.
2538
2539         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2540         (DRTTestRunner::DRTTestRunner):
2541         (DRTTestRunner::reset):
2542         * DumpRenderTree/chromium/DRTTestRunner.h:
2543         (DRTTestRunner):
2544         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2545         (WebKit):
2546         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
2547         (WebTestRunner::WebTestRunner::audioData):
2548         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2549         (WebTestRunner::TestRunner::TestRunner):
2550         (WebTestRunner::TestRunner::reset):
2551         (WebTestRunner::TestRunner::shouldDumpAsAudio):
2552         (WebTestRunner):
2553         (WebTestRunner::TestRunner::audioData):
2554         (WebTestRunner::TestRunner::setAudioData):
2555         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2556         (TestRunner):
2557         * DumpRenderTree/chromium/TestShell.cpp:
2558         (TestShell::dump):
2559
2560 2013-01-07  Mike West  <mkwst@chromium.org>
2561
2562         Make the IFRAME_SEAMLESS flag runtime-enabled.
2563         https://bugs.webkit.org/show_bug.cgi?id=106213
2564
2565         Reviewed by Ojan Vafai.
2566
2567         * DumpRenderTree/chromium/TestShell.cpp:
2568         (TestShell::TestShell):
2569         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2570         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2571         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2572         (resetDefaultsToConsistentValues):
2573         * DumpRenderTree/mac/DumpRenderTree.mm:
2574         (resetDefaultsToConsistentValues):
2575         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2576         (WebCore::WebPage::resetSettings):
2577         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2578         (WTR::InjectedBundle::beginTesting):
2579             Ensure that seamless IFrames are enabled for layout tests in each of
2580             the ports that support seamless IFrames.
2581
2582 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
2583
2584         [chromium] move dumpAsText and friends to the TestRunner library
2585         https://bugs.webkit.org/show_bug.cgi?id=106222
2586
2587         Reviewed by Adam Barth.
2588
2589         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
2590
2591         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2592         (DRTTestRunner::DRTTestRunner):
2593         (DRTTestRunner::reset):
2594         * DumpRenderTree/chromium/DRTTestRunner.h:
2595         (DRTTestRunner):
2596         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2597         (WebTestRunner::WebTestRunner::shouldDumpAsText):
2598         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
2599         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
2600         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
2601         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
2602         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
2603         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2604         (WebTestRunner::TestRunner::TestRunner):
2605         (WebTestRunner::TestRunner::reset):
2606         (WebTestRunner::TestRunner::shouldDumpAsText):
2607         (WebTestRunner):
2608         (WebTestRunner::TestRunner::setShouldDumpAsText):
2609         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
2610         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
2611         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
2612         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
2613         (WebTestRunner::TestRunner::dumpAsText):
2614         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
2615         (WebTestRunner::TestRunner::dumpChildFramesAsText):
2616         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2617         (TestRunner):
2618
2619 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2620
2621         Build fix attempt after r138810.
2622
2623         Apparently python 2.6 is really bad at floating point computation.
2624
2625         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2626         (MainTest.test_run_memory_test):
2627
2628 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2629
2630         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
2631         https://bugs.webkit.org/show_bug.cgi?id=106172
2632
2633         Reviewed by Tony Chang.
2634
2635         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
2636         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
2637         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
2638         test on perf-o-matic and perf. test's results page.
2639
2640         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
2641
2642         * Scripts/webkitpy/performance_tests/perftest.py:
2643         (PerfTestMetric): Added.
2644         (PerfTestMetric.__init__): Added.
2645         (PerfTestMetric.metric): Added.
2646         (PerfTestMetric.has_values): Added.
2647         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
2648         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
2649         conversions to be done on the client side (perf-o-matic and results page).
2650         (PerfTestMetric.append): Added.
2651         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
2652         a result for this metric.
2653         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
2654         (PerfTestMetric.compute_statistics): Moved from PerfTest.
2655
2656         (PerfTest._create_driver): Extracted from PerfTest.run.
2657         (PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
2658         as needed.
2659         (PerfTest._run_with_driver):
2660         (PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
2661         (PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
2662         all keys except "values". We rely on PerfTestMetric to compute the statistics for us.
2663
2664         (ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
2665         from other perf tests, there isn't much point in sharing the code here.
2666
2667         (PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
2668         statistics for the measured values.
2669
2670         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2671         (TestPerfTestMetric): Added.
2672         (TestPerfTestMetric.test_init_set_missing_unit): Added.
2673         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
2674         (TestPerfTestMetric.test_has_values): Added.
2675         (TestPerfTestMetric.test_append): Added.
2676         (TestPerfTestMetric.test_compute_statistics.compute_statistics):
2677         (TestPerfTestMetric.test_compute_statistics): Added a trivial test case.
2678
2679         (TestPerfTest._assert_results_are_correct): Updated as needed.
2680         (TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
2681         in PerfTest.run now after generating the results dictionary.
2682         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.
2683
2684 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
2685
2686         Support size_t multiplication and division operators on LayoutUnit
2687         https://bugs.webkit.org/show_bug.cgi?id=83848
2688
2689         Reviewed by Emil A Eklund.
2690
2691         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2692         Added some simple tests for the new operators using size_t.
2693
2694 2013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2695
2696         [Qt] run-webkit-tests cleanup for parallel NRWT
2697         https://bugs.webkit.org/show_bug.cgi?id=106220
2698
2699         Reviewed by Dirk Pranke.
2700
2701         * Scripts/run-webkit-tests:
2702         (useNewRunWebKitTests):
2703         * Scripts/webkitpy/layout_tests/port/qt.py:
2704         (QtPort):
2705         (QtPort.default_child_processes):
2706
2707 2013-01-07  Philippe Normand  <pnormand@igalia.com>
2708
2709         Create a GStreamerAudio watchlist and add myself to it.
2710
2711         Unreviewed.
2712
2713         * Scripts/webkitpy/common/config/watchlist:
2714
2715 2013-01-05  Ryosuke Niwa  <rniwa@webkit.org>
2716
2717         Add svn:executable to a bunch of scripts in BuildSlaveSupport.
2718         Also removed the empty mac directory.
2719
2720         * BuildSlaveSupport/built-product-archive: Added property svn:executable.
2721         * BuildSlaveSupport/download-built-product: Added property svn:executable.
2722         * BuildSlaveSupport/mac: Removed.
2723         * BuildSlaveSupport/test-result-archive: Added property svn:executable.
2724
2725 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
2726
2727         Add a script to delete stale zero-byte build files
2728         https://bugs.webkit.org/show_bug.cgi?id=106131
2729
2730         Reviewed by Tony Chang.
2731
2732         Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
2733
2734         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2735         (DeleteStaleBuildFiles): Added.
2736         (Factory.__init__): Add DeleteStaleBuildFiles step.
2737         * BuildSlaveSupport/delete-stale-build-files: Added.
2738         (main): Delete zero-byte files except ones intentionally generated by our build process.
2739         (webkitBuildDirectory): Copied from build-product-archive.
2740
2741 2013-01-04  Michael Pruett  <michael@68k.org>
2742
2743         [GTK] Fix build error on GTK due to r138836
2744         https://bugs.webkit.org/show_bug.cgi?id=106154
2745
2746         Reviewed by Kentaro Hara.
2747
2748         * GNUmakefile.am:
2749
2750 2013-01-04  Dan Bernstein  <mitz@apple.com>
2751
2752         [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
2753         https://bugs.webkit.org/show_bug.cgi?id=106121
2754
2755         Reviewed by Adele Peterson.
2756
2757         Added test for -[DOMTHMLTableCellElement _cellAbove].
2758
2759         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2760         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
2761         (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
2762         (TestWebKitAPI):
2763         (TestWebKitAPI::expectCellAboveCell):
2764         (TestWebKitAPI::TEST):
2765         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
2766
2767 2013-01-04  Eric Seidel  <eric@webkit.org>
2768
2769         FlakyTestReporter should be re-enabled and taught how to post patches
2770         https://bugs.webkit.org/show_bug.cgi?id=103839
2771
2772         Reviewed by Adam Barth.
2773
2774         This moves LayoutTestResultsReader off of the DeprecatedPort object.
2775         It also adds a real Port object to the EWS and CommitQueue objects
2776         using a new PatchProcessingQueue superclass.
2777         PatchProcessingQueue doesn't seem to be the cleanest insertion point
2778         but works for this purpose.
2779         I also moved _upload_results_archive_for_patch into PatchProcessingQueue
2780         to resolve a FIXME.
2781
2782         This required some hacks/shiming between the non-specific "old"
2783         port names which the EWS system is currently using, and the new
2784         port objects.  This shimming is done in PatchProcessingQueue._new_port_name_from_old.
2785
2786         Hopefully this will fix the flaky test reporter and results uploading.
2787         Certainly it's another small step towards getting rid of the old ports.py
2788         infrastructure and making the NRWT Port class common webkitpy infrastructure.
2789
2790         Now that DeprecatedPort is no longer used for the results directory
2791         I removed all the explicit results-dir code which webkit-patch was using
2792         in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
2793
2794         * Scripts/webkitpy/common/config/ports.py:
2795         (DeprecatedPort.run_perl_unittests_command):
2796         * Scripts/webkitpy/common/config/ports_mock.py:
2797         (MockPort.name):
2798         * Scripts/webkitpy/common/system/outputcapture.py:
2799         (OutputCapture.assert_outputs):
2800         * Scripts/webkitpy/layout_tests/port/apple.py:
2801         (ApplePort.determine_full_port_name):
2802         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2803         (LayoutTestResultsReader.__init__):
2804         (LayoutTestResultsReader):
2805         (LayoutTestResultsReader._read_file_contents):
2806         (LayoutTestResultsReader._create_layout_test_results):
2807         (LayoutTestResultsReader._create_unit_test_results):
2808         (LayoutTestResultsReader.results):
2809         (LayoutTestResultsReader.archive):
2810         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2811         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
2812         (LayoutTestResultsReaderTest.test_create_unit_test_results):
2813         (test_missing_unit_test_results_path):
2814         (test_layout_test_results):
2815         (test_archive_last_layout_test_results):
2816         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2817         (AbstractEarlyWarningSystem):
2818         (AbstractEarlyWarningSystem.__init__):
2819         (AbstractEarlyWarningSystem.begin_work_queue):
2820         (AbstractEarlyWarningSystem.run_command):
2821         * Scripts/webkitpy/tool/commands/queues.py:
2822         (AbstractPatchQueue.work_item_log_path):
2823         (PatchProcessingQueue):
2824         (PatchProcessingQueue._new_port_name_from_old):
2825         (PatchProcessingQueue.begin_work_queue):
2826         (PatchProcessingQueue._upload_results_archive_for_patch):
2827         (CommitQueue):
2828         (CommitQueue.begin_work_queue):
2829         (CommitQueue.run_command):
2830         (AbstractReviewQueue):
2831         (AbstractReviewQueue.__init__):
2832         (AbstractReviewQueue.begin_work_queue):
2833         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2834         (AbstractPatchQueueTest.test_next_patch):
2835         (PatchProcessingQueueTest):
2836         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
2837         * Scripts/webkitpy/tool/steps/runtests.py:
2838         (RunTests.run):
2839         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2840
2841 2013-01-04  Dana Jansens  <danakj@chromium.org>
2842
2843         [chromium] Remove lost-compositor-context layout tests
2844         https://bugs.webkit.org/show_bug.cgi?id=106089
2845
2846         Reviewed by James Robinson.
2847
2848         Remove the loseCompositorContext() test function.
2849
2850         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2851         (WebTestRunner::TestRunner::TestRunner):
2852         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2853         (TestRunner):
2854
2855 2013-01-04  Adam Klein  <adamk@chromium.org>
2856
2857         Remove ENABLE_MUTATION_OBSERVERS #define
2858         https://bugs.webkit.org/show_bug.cgi?id=105459
2859
2860         Reviewed by Ryosuke Niwa.
2861
2862         * Scripts/webkitperl/FeatureList.pm:
2863         * qmake/mkspecs/features/features.pri:
2864
2865 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
2866
2867         Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
2868         https://bugs.webkit.org/show_bug.cgi?id=106078
2869
2870         Reviewed by Tony Chang.
2871
2872         This patch updates values for individual iterations in dummy performance tests used in
2873         perftest_unittest.py and perftest_integrationtest.py so that they match up with
2874         statistics such as stdev and median reported in those tests. This change is required
2875         to resolve the bug 97510.
2876
2877         This patch also refactors integration tests by extracting *TestData classes that
2878         centralizes the definitions of each dummy performance test's text (DRT output),
2879         runner output, and parsed results (JSON) so that we may share more data between
2880         python tests.
2881
2882         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2883         (MainTest._assert_results_are_correct): Extracted from test_parse_output.
2884         Use self.assertAlmostEqual when comparing the standard deviation.
2885         (MainTest.test_parse_output):
2886         (test_parse_output_with_failing_line):
2887         (test_parse_output_with_description): Use _assert_results_are_correct.
2888         (test_parse_output_with_subtests): Ditto.
2889
2890         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2891         (InspectorPassTestData): Extracted from tests below.
2892         (EventTargetWrapperTestData): Ditto.
2893         (SomeParserTestData): Ditto.
2894         (MemoryTestData): Ditto.
2895         (TestDriver.run_test): Moved test definitions out of the method.
2896         (MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
2897         (MainTest._load_output_json): Extracted from create_runner.
2898         (MainTest.create_runner):
2899         (MainTest.test_run_test_set_for_parser_tests):
2900         (MainTest.test_run_memory_test):
2901         (MainTest._test_run_with_json_output):
2902         (MainTest.test_run_with_json_output):
2903         (MainTest.test_run_with_description):
2904         (MainTest.test_run_generates_json_by_default):
2905         (MainTest.test_run_merges_output_by_default):
2906         (MainTest.test_run_respects_reset_results):
2907         (MainTest.test_run_generates_and_show_results_page):
2908         (MainTest.test_run_with_slave_config_json):
2909         (MainTest.test_run_with_multiple_repositories):
2910
2911 2013-01-04  Martin Robinson  <mrobinson@igalia.com>
2912
2913         [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
2914         https://bugs.webkit.org/show_bug.cgi?id=106045
2915
2916         Reviewed by Carlos Garcia Campos.
2917
2918         Update test results to confirm that compositions without preedits do not trigger
2919         a composition confirmation.
2920
2921         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
2922         (TestWebKitAPI::verifyCanceledComposition):
2923
2924 2013-01-04  Sailesh Agrawal  <sail@chromium.org>
2925
2926         [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
2927         https://bugs.webkit.org/show_bug.cgi?id=105958
2928
2929         Reviewed by Alexey Proskuryakov.
2930
2931         Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
2932
2933         * WebKitTestRunner/mac/EventSenderProxy.mm:
2934         (KeyMappingEntry):
2935         (WTR):
2936         (WTR::EventSenderProxy::keyDown): Added all numpad keys.
2937
2938 2013-01-03  Chris Fleizach  <cfleizach@apple.com>
2939
2940         REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
2941         https://bugs.webkit.org/show_bug.cgi?id=106073
2942
2943         Reviewed by Ryosuke Niwa.
2944
2945         Check that the element being compared to is not nil. 
2946         This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
2947         It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
2948         controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it 
2949         sometimes before on parallel WebKitTestRunner runs.
2950
2951         * DumpRenderTree/AccessibilityUIElement.cpp:
2952         (AccessibilityUIElement::isEqual):
2953         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2954         (WTR::AccessibilityUIElement::isEqual):
2955
2956 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
2957
2958         Downloads can be flaky, so try downloading multiple times.
2959         https://bugs.webkit.org/show_bug.cgi?id=105976
2960
2961         Reviewed by Eric Seidel.
2962
2963         * Scripts/webkitpy/common/system/autoinstall.py:
2964         (AutoInstaller._download_to_stream):
2965
2966 2013-01-03  Eric Seidel  <eric@webkit.org>
2967
2968         Rename Tool.port to deprecated_port in preparation for removing more callers
2969         https://bugs.webkit.org/show_bug.cgi?id=106076
2970
2971         Reviewed by Ryosuke Niwa.
2972
2973         This resolves a long-standing FIXME to rename this method. :)
2974
2975         * Scripts/webkitpy/tool/bot/botinfo.py:
2976         (BotInfo.summary_text):
2977         * Scripts/webkitpy/tool/bot/irc_command.py:
2978         (Rollout._update_working_copy):
2979         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2980         (LayoutTestResultsReader._create_layout_test_results):
2981         (LayoutTestResultsReader._create_unit_test_results):
2982         (LayoutTestResultsReader._results_directory):
2983         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2984         (test_missing_unit_test_results_path):
2985         * Scripts/webkitpy/tool/main.py:
2986         (WebKitPatch.deprecated_port):
2987         * Scripts/webkitpy/tool/mocktool.py:
2988         (MockTool.deprecated_port):
2989         * Scripts/webkitpy/tool/steps/build.py:
2990         (Build.build):
2991         * Scripts/webkitpy/tool/steps/checkstyle.py:
2992         (CheckStyle.run):
2993         * Scripts/webkitpy/tool/steps/commit.py:
2994         (Commit._check_test_expectations):
2995         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2996         (PrepareChangeLog.run):
2997         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2998         (PrepareChangeLogForDEPSRoll.run):
2999         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3000         (PrepareChangeLogForRevert.run):
3001         * Scripts/webkitpy/tool/steps/runtests.py:
3002         (RunTests.run):
3003         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3004         (StepsTest.test_runtests_args):
3005         * Scripts/webkitpy/tool/steps/update.py:
3006         (Update._update_command):
3007
3008 2013-01-03  Eric Seidel  <eric@webkit.org>
3009
3010         Add myself to the webkitpy watchlist.
3011
3012         Unreviewed.
3013
3014         * Scripts/webkitpy/common/config/watchlist:
3015
3016 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3017
3018         Cleanup perftest* tests and add a test for computing statistics
3019         https://bugs.webkit.org/show_bug.cgi?id=105685
3020
3021         Reviewed by Eric Seidel.
3022
3023         Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
3024         extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
3025
3026         Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
3027
3028         * Scripts/webkitpy/performance_tests/perftest.py:
3029         (PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
3030         directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
3031         accurate result for the mean.
3032         (PageLoadingPerfTest.run_single):
3033         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3034         (MainTest.test_compute_statistics):
3035         (MainTest.test_compute_statistics.compute_statistics): Added.
3036         (TestPageLoadingPerfTest.test_run): floatify values.
3037         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
3038         correctly recognizes them as integers.
3039
3040         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
3041         Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
3042         (TestDriver): Moved out of MainTest.
3043         (MainTest): Got rid of assertWritten and all unit tests.
3044         (MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
3045         (MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
3046         (MainTest.test_run_test_set_for_parser_tests):
3047         (MainTest.test_run_memory_test):
3048         (MainTest._test_run_with_json_output):
3049         (MainTest.test_run_generates_json_by_default):
3050         (MainTest.test_run_merges_output_by_default):
3051         (MainTest.test_run_respects_reset_results):
3052         (MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
3053         parsing output JSON files. Just verify that the output path is correct instead.
3054         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3055         (MainTest): Removed all integration tests.
3056         (MainTest.create_runner): Simplified.
3057
3058 2013-01-03  Julie Parent  <jparent@chromium.org>
3059
3060         Dashboard cleanup: remove usage of global g_defaultBuilderName
3061         https://bugs.webkit.org/show_bug.cgi?id=106043
3062
3063         Use now public defaultBuilder() from the BuilderGroup, rather
3064         than global variable.
3065
3066         Also eliminates the setup() and initBuilders() functions since we
3067         no longer need to track the global.
3068
3069         Reviewed by Adam Barth.
3070
3071         * TestResultServer/static-dashboards/builders.js:
3072         (BuilderGroup.prototype.defaultBuilder):
3073         (BuilderGroup.prototype.master):
3074         * TestResultServer/static-dashboards/dashboard_base.js:
3075         (parseParameters):
3076         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3077         (updateDefaultBuilderState):
3078         * TestResultServer/static-dashboards/loader.js:
3079         (.):
3080         * TestResultServer/static-dashboards/loader_unittests.js:
3081
3082 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3083
3084         Disable an intermittently failing unit test for now.
3085         The failure is tracked by the bug 106051.
3086
3087         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
3088         (TestWebKitAPI::TEST):
3089
3090 2013-01-03  Dan Bernstein  <mitz@apple.com>
3091
3092         No way to obtain a DOMNode given a JS wrapper for a Node
3093         https://bugs.webkit.org/show_bug.cgi?id=106033
3094
3095         Added a test for +[DOMNode _nodeFromJSWrapper:].
3096
3097         Reviewed by Sam Weinig.
3098
3099         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3100         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
3101         (TestWebKitAPI):
3102         (TestWebKitAPI::TEST):
3103
3104 2013-01-03  Emil A Eklund  <eae@chromium.org>
3105
3106         Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
3107         https://bugs.webkit.org/show_bug.cgi?id=105961
3108
3109         Reviewed by Levi Weintraub.
3110         
3111         Add tests for LayoutUnit::ceil and floor.
3112
3113         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3114         (TestWebKitAPI::TEST):
3115         (TestWebKitAPI):
3116
3117 2013-01-03  Julie Parent  <jparent@chromium.org>
3118
3119         Add unit test for default builder for the dashboards.
3120         https://bugs.webkit.org/show_bug.cgi?id=105972
3121
3122         Reviewed by Dirk Pranke.
3123
3124         * TestResultServer/static-dashboards/loader_unittests.js:
3125
3126 2013-01-03  Tony Chang  <tony@chromium.org>
3127
3128         Generate internal.settings from Settings.in
3129         https://bugs.webkit.org/show_bug.cgi?id=104740
3130
3131         Reviewed by Adam Barth.
3132
3133         * GNUmakefile.am: Compile new generated files on GTK+.
3134         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
3135         with both extra_sources and add_output_to_sources=false will still
3136         compile the files in extra_sources. This makes it possible to compile
3137         InternalSettingsGenerated.cpp and not be confused by
3138         InternalSettingsGenerated.idl.
3139
3140 2013-01-03  Zan Dobersek  <zandobersek@gmail.com>
3141
3142         [style] WebIDL-reflecting uppercase enums reported as style violation
3143         https://bugs.webkit.org/show_bug.cgi?id=105832
3144
3145         Reviewed by Tony Chang.
3146
3147         Recognize the enum as WebIDL-reflecting one if there's a comment present that
3148         indicates this. In enums spanning over multiple lines, the comment is expected
3149         on the first line. In enums placed in one line, the comment is expected at the
3150         end of that line.
3151
3152         WebIDL-reflecting enum values are required to be written in uppercase and as such
3153         violate the common rule of these values being written in InterCaps. Annotating
3154         enums this way makes it possible to avoid false style violation reports.
3155
3156         The comment is of form '// Web(?:Kit)?IDL enum'.
3157
3158         * Scripts/webkitpy/style/checkers/cpp.py:
3159         (_EnumState.__init__):
3160         (_EnumState.process_clean_line):
3161         (check_enum_casing):
3162         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3163         (NoNonVirtualDestructorsTest.test_enum_casing):
3164
3165 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
3166
3167         Adding favicon.ico to the garden-o-matic.
3168         https://bugs.webkit.org/show_bug.cgi?id=105982
3169
3170         Reviewed by Adam Barth.
3171
3172         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3173         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
3174
3175 2013-01-03  Jonathan Liu  <net147@gmail.com>
3176
3177         [Qt] Fix library linking order
3178         https://bugs.webkit.org/show_bug.cgi?id=105818
3179
3180         Some Qt libraries are linked before the private static libraries
3181         that depend on them which results in QtWebKit failing to link.
3182
3183         Copy Qt module dependencies from QT to QT_PRIVATE when creating
3184         module to ensure the Qt libraries are linked after the private
3185         static libraries that depend on them.
3186
3187         Reviewed by Tor Arne Vestbø.
3188
3189         * qmake/mkspecs/features/default_post.prf:
3190
3191 2013-01-02  Byungwoo Lee  <bw80.lee@samsung.com>
3192
3193         [EFL][WK2] Fix tooltip bugs in MiniBrowser.
3194         https://bugs.webkit.org/show_bug.cgi?id=102209
3195
3196         Reviewed by Gyuyoung Kim.
3197
3198         Set tooltip on the elm_window instead of ewk_view, and add delay to
3199         show the tooltip window.
3200
3201         Setting tooltip on the ewk_view makes elementary error message because
3202         ewk_view is not an elementary widget. To remove the error message,
3203         tooltip should be set on the elm_window.
3204
3205         Most browsers show the tooltip after a mouse pointer stays on an
3206         element object that has tooltip text.
3207         But elm_tooltip widget itself doesn't have delay or handle mouse
3208         events to show/hide.
3209
3210         So additional codes are added to show/hide tooltip widget along with
3211         mouse events.
3212           1) When a mouse pointer stays for a second on an element which has
3213              tooltip text, then tooltip widget is displayed.
3214           2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
3215              widget.
3216
3217         * MiniBrowser/efl/main.c:
3218         (_Tooltip_Information):
3219         (_Browser_Window):
3220         (on_tooltip_show):
3221         (window_tooltip_hide):
3222         (window_tooltip_update):
3223         (on_mouse_in):
3224         (on_mouse_move):
3225         (on_mouse_out):
3226         (window_free):
3227         (on_tooltip_text_set):
3228         (on_tooltip_text_unset):
3229         (window_create):
3230
3231 2013-01-02  Tony Chang  <tony@chromium.org>
3232
3233         Unreviewed, rolling out r138661.
3234         http://trac.webkit.org/changeset/138661
3235         https://bugs.webkit.org/show_bug.cgi?id=104740
3236
3237         Compile problems on EFL
3238
3239         * GNUmakefile.am:
3240         * qmake/mkspecs/features/default_post.prf:
3241
3242 2013-01-02  Tony Chang  <tony@chromium.org>
3243
3244         Generate internal.settings from Settings.in
3245         https://bugs.webkit.org/show_bug.cgi?id=104740
3246
3247         Reviewed by Adam Barth.
3248
3249         * GNUmakefile.am: Compile new generated files on GTK+.
3250         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
3251         with both extra_sources and add_output_to_sources=false will still
3252         compile the files in extra_sources. This makes it possible to compile
3253         InternalSettingsGenerated.cpp and not be confused by
3254         InternalSettingsGenerated.idl.
3255
3256 2013-01-02  Adam Barth  <abarth@webkit.org>
3257
3258         Remove old-run-webkit-tests support from webkitpy
3259         https://bugs.webkit.org/show_bug.cgi?id=105619
3260
3261         Reviewed by Eric Seidel.
3262
3263         This patch removes support for webkitpy parsing the
3264         old-run-webkit-tests results format. There doesn't seem to be any
3265         reason to keep this code around anymore now that most bots have
3266         switched to new-run-webkit-tests.
3267
3268         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3269         (Builder.fetch_layout_test_results):
3270         * Scripts/webkitpy/common/net/layouttestresults.py:
3271         (path_for_layout_test):
3272         (LayoutTestResults.results_from_string):
3273         (LayoutTestResults):
3274         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3275         (LayoutTestResultsTest.test_results_from_string):
3276         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3277         (test_flaky_test_failure):
3278         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3279         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
3280         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3281         (PatchAnalysisTask._test_patch):
3282         * Scripts/webkitpy/tool/commands/queuestest.py:
3283         (QueuesTest.assert_queue_outputs):
3284
3285 2013-01-02  Heikki Paajanen  <heikki.paajanen@palm.com>
3286
3287         [Qt][WK2] Add simple UI to find text from page
3288         https://bugs.webkit.org/show_bug.cgi?id=96481
3289
3290         Reviewed by Jocelyn Turcotte.
3291
3292         Find bar that slides between navigation bar and WebView.
3293
3294         * MiniBrowser/qt/BrowserWindow.cpp:
3295         (BrowserWindow::toggleFind):
3296         * MiniBrowser/qt/BrowserWindow.h:
3297         (BrowserWindow):
3298         * MiniBrowser/qt/MiniBrowser.qrc:
3299         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3300         (MiniBrowserApplication::notify):
3301         * MiniBrowser/qt/icons/find.png: Added.
3302         * MiniBrowser/qt/qml/BrowserWindow.qml:
3303
3304 2013-01-02  Christophe Dumez  <christophe.dumez@intel.com>
3305
3306         Regression(r138603): Caused 2 webkitpy tests to fail
3307         https://bugs.webkit.org/show_bug.cgi?id=105913
3308
3309         Reviewed by Kentaro Hara.
3310
3311         Fix 2 webkitpy tests that started to fail after
3312         r138603.
3313
3314         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3315         (IRCCommandTest._sheriff_test_data_url): Make sure the
3316         returned test file URL is valid no matter what the
3317         current working directory is.
3318         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3319         (IRCBotTest.test_help): Add "sheriffs" command to the
3320         list of available commands.
3321
3322 2013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
3323
3324         [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
3325         https://bugs.webkit.org/show_bug.cgi?id=105897
3326
3327         Reviewed by Alexey Proskuryakov.
3328
3329         Dump in WebKitTestRunner the message that is expected by layout tests
3330         when the missing plugin button is clicked.
3331
3332         * WebKitTestRunner/TestController.cpp:
3333         (WTR::TestController::createWebViewWithOptions):
3334         (WTR::TestController::unavailablePluginButtonClicked):
3335         (WTR):
3336         * WebKitTestRunner/TestController.h:
3337         (TestController):
3338
3339 2013-01-01  KwangYong Choi  <ky0.choi@samsung.com>
3340
3341         [EFL] Enable MHTML feature
3342         https://bugs.webkit.org/show_bug.cgi?id=105815
3343
3344         Reviewed by Laszlo Gombos.
3345
3346         Enable MHTML feature for EFL port by default.
3347
3348         * Scripts/webkitperl/FeatureList.pm:
3349
3350 2013-01-01  Alan Cutter  <alancutter@chromium.org>
3351
3352         sheriff-bot should know who the gardeners/sheriffs are
3353         https://bugs.webkit.org/show_bug.cgi?id=105698
3354
3355         Reviewed by Eric Seidel.
3356
3357         Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
3358
3359         * Scripts/webkitpy/tool/bot/irc_command.py:
3360         (Current):
3361         (Current._retrieve_webkit_sheriffs):
3362         (Current.execute):
3363         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3364         (IRCCommandTest.test_current):
3365         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
3366         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
3367         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
3368         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
3369         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
3370
3371 2012-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3372
3373         [GTK] Move ImageDiff to the Tools directory root
3374         https://bugs.webkit.org/show_bug.cgi?id=105421
3375
3376         Reviewed by Kenneth Rohde Christiansen.
3377
3378         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
3379         * GNUmakefile.am:
3380         * ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
3381
3382 2012-12-30  Mike West  <mkwst@chromium.org>
3383
3384         Add myself to watchlists for CSP and console logs.
3385         https://bugs.webkit.org/show_bug.cgi?id=105874
3386
3387         Reviewed by Dirk Pranke.
3388
3389         Because I really, really, really need more email.
3390
3391         * Scripts/webkitpy/common/config/committers.py:
3392             Add mkwst+watchlist@chromium.org as a contributor.
3393         * Scripts/webkitpy/common/config/watchlist:
3394             Create watchlist categories for 1) the various mechanisms used to
3395             generate console messages, and 2) CSP usage and files.
3396
3397 2012-12-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3398
3399         [EFL] Enable TEMPLATE_ELEMENT feature
3400         https://bugs.webkit.org/show_bug.cgi?id=105865
3401         
3402         Reviewed by Laszlo Gombos.
3403
3404         * Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
3405
3406 2012-12-30  Zan Dobersek  <zandobersek@gmail.com>
3407
3408         Unreviewed GTK gardening of the unit tests.
3409
3410         Skip the TestInspectorServer unit test that's timing out completely.
3411
3412         * Scripts/run-gtk-tests:
3413         (TestRunner):
3414
3415 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
3416
3417         Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
3418         https://bugs.webkit.org/show_bug.cgi?id=105855
3419
3420         Reviewed by Vsevolod Vlasov.
3421
3422         Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
3423         addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.
3424
3425         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3426         (ReportMemoryUsageVisitor):
3427         (clang::AddMemberCallVisitor::VisitCallExpr):
3428         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
3429         (clang::ReportMemoryUsageVisitor::checkMembersCoverage):
3430
3431 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
3432
3433         Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
3434         https://bugs.webkit.org/show_bug.cgi?id=105852
3435
3436         Reviewed by Alexander Pavlov.
3437
3438         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3439         (clang):
3440         (AddMemberCallVisitor):
3441         (ReportMemoryUsageVisitor):
3442         (clang::ReportMemoryUsageAction::ParseArgs):
3443         (clang::AddMemberCallVisitor::VisitCallExpr):
3444         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
3445         (clang::ReportMemoryUsageVisitor::emitWarning):
3446         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
3447         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
3448         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
3449
3450 2012-12-29  Zan Dobersek  <zandobersek@gmail.com>
3451
3452         [webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
3453         https://bugs.webkit.org/show_bug.cgi?id=105835
3454
3455         Reviewed by Dirk Pranke.
3456
3457         The BeautifulSoup module is a third-party import and as such we don't have much control
3458         over its testing. Because of that it should be omitted from code coverage checking.
3459
3460         * Scripts/webkitpy/test/main.py:
3461         (Tester._run_tests):
3462
3463 2012-12-28  Martin Robinson  <mrobinson@igalia.com>
3464
3465         [GTK][WK2] Add support for IME Composition
3466         https://bugs.webkit.org/show_bug.cgi?id=65093
3467
3468         Reviewed by Carlos Garcia Campos.
3469
3470         Update unit tests for GtkInputMethodFilter to note whether or not an event
3471         was a fake event synthesized for composition purposes. This is now used
3472         for WebKit2.
3473
3474         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
3475         (TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
3476         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
3477         (TestWebKitAPI::TEST):
3478         * gtk/generate-gtkdoc:
3479         (get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
3480         generation.
3481
3482 2012-12-27  Ilya Tikhonovsky  <loislo@chromium.org>
3483
3484         Web Inspector: Native Memory Instrumentation. Update clang plugin according to the current state of memory instrumentation code.
3485         https://bugs.webkit.org/show_bug.cgi?id=105800
3486
3487         Reviewed by Yury Semikhatsky.
3488
3489         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3490         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
3491         (clang):
3492
3493 2012-12-27  Zan Dobersek  <zandobersek@gmail.com>
3494
3495         Create a GTK build system watchlist and add myself to it
3496         https://bugs.webkit.org/show_bug.cgi?id=105769
3497
3498         Reviewed by Dirk Pranke.
3499
3500         Add a GTK build system watchlist, watching the configure.ac, GNUmakefile.am files
3501         and the input GNUmakefile.features.am.in file. The GNUmakefile.list.am files are
3502         omitted on purpose due to relatively high change rate they are exposed to.
3503
3504         The new watchlist would be of use to me as the GTK build system recently went
3505         through a series of changes that included a changed policy on adding configuration
3506         flags to configure.ac and subsequent additions to GNUmakefile.am files. A PSA on the
3507         mailing list about this change will be published later, but I'd also like to be
3508         notified of any pending changes to these files just so I can check the changes are
3509         in compliance with the new policy.
3510
3511         * Scripts/webkitpy/common/config/watchlist:
3512
3513 2012-12-26  Ilya Tikhonovsky  <loislo@chromium.org>
3514
3515         Unreviewed. Replace find("Tools") with rfind("Tools") because base dir of WebKit may have Tools word.
3516         As example ..../DevTools/src/third_party/WebKit
3517
3518         * Scripts/webkitpy/common/webkit_finder.py:
3519         (WebKitFinder.webkit_base):
3520
3521 2012-12-25  Christophe Dumez  <christophe.dumez@intel.com>
3522
3523         [EFL][WK2] Refactor snapshot taking code
3524         https://bugs.webkit.org/show_bug.cgi?id=105687
3525
3526         Reviewed by Kenneth Rohde Christiansen.
3527
3528         Call WKViewCreateSnapshot() instead of WKViewGetSnapshot()
3529         since the function was renamed to follow naming style.
3530
3531         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3532         (WTR::PlatformWebView::windowSnapshotImage):
3533
3534 2012-12-24  Ilya Tikhonovsky  <loislo@chromium.org>
3535
3536         Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
3537         https://bugs.webkit.org/show_bug.cgi?id=105725
3538
3539         Reviewed by Yury Semikhatsky.
3540
3541         MemberType value names were adjusted according to Style Guide.
3542         Existing tests were extended with link type validation.
3543
3544         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3545
3546 2012-12-24  Xiaobo Wang  <xbwang@torchmobile.com.cn>
3547
3548         [BlackBerry] DRT - Crashed when running pixels tests
3549         https://bugs.webkit.org/show_bug.cgi?id=105711
3550
3551         RIM PR 270003
3552
3553         Reviewed by George Staikos.
3554
3555         Calling window->post() here will result in buffer swapping which is
3556         only allowed in UI thread now, and I found we don't need to call it
3557         for GL renderer.
3558
3559         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
3560         (createBitmapContextFromWebView):
3561
3562 2012-12-22  Dan Winship  <danw@gnome.org>
3563
3564         Add a patch to fix libxml2 2.9.0 regression
3565         https://bugs.webkit.org/show_bug.cgi?id=104494
3566
3567         Reviewed by Martin Robinson.
3568
3569         * gtk/jhbuild.modules:
3570         * gtk/patches/libxml2-2.9.0-dtd.patch: patch from upstream
3571
3572 2012-12-23  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3573
3574         Unreviewed update of status to reviewer.
3575
3576         * Scripts/webkitpy/common/config/committers.py:
3577
3578 2012-12-23  Philippe Normand  <pnormand@igalia.com>
3579
3580         [GTK][jhbuild] Bump GStreamer to 1.0.4
3581         https://bugs.webkit.org/show_bug.cgi?id=105640
3582
3583         Reviewed by Martin Robinson.
3584
3585         * gtk/jhbuild.modules: Update GStreamer modules to 1.0.4.
3586
3587 2012-12-21  Nico Weber  <thakis@chromium.org>
3588
3589         chromium: webkit-build-directory doesn't handle ninja output dirs
3590         https://bugs.webkit.org/show_bug.cgi?id=105671
3591
3592         Reviewed by Daniel Bates.
3593
3594         Teach webkit-build-directory to detect the ninja build directory.
3595
3596         * Scripts/webkitdirs.pm:
3597         (determineBaseProductDir):
3598         (determineIsChromiumNinja):
3599
3600 2012-12-21  Ryosuke Niwa  <rniwa@webkit.org>
3601
3602         [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
3603         https://bugs.webkit.org/show_bug.cgi?id=95477
3604
3605         Reviewed by Sam Weinig.
3606
3607         Co-authored by Jia Pu.
3608
3609         Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
3610         we can have consistent autocorrection behavior when running tests.
3611
3612         * DumpRenderTree/mac/DumpRenderTree.mm:
3613         (resetDefaultsToConsistentValues):
3614         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3615         (WTR::InjectedBundle::platformInitialize):
3616
3617 2012-12-21  Zan Dobersek  <zandobersek@gmail.com>
3618
3619         [GTK] Add WebKit1-specific TestExpectations file
3620         https://bugs.webkit.org/show_bug.cgi?id=97562
3621
3622         Reviewed by Dirk Pranke.
3623
3624         Implement the expectations_files method inside the GtkPort class that
3625         returns the list of the TestExpectations files the current test configuration
3626         requires. The method is implemented in a similar way as on the EFL port.
3627         A unit test is also added.
3628
3629         * Scripts/webkitpy/layout_tests/port/gtk.py:
3630         (GtkPort._search_paths):
3631         (GtkPort):
3632         (GtkPort.expectations_files):
3633         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3634         (GtkPortTest.test_expectations_files):
3635
3636 2012-12-21  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3637
3638         [EFL] Enable feature option for the CSS sticky position
3639         https://bugs.webkit.org/show_bug.cgi?id=105630
3640
3641         Reviewed by Kenneth Rohde Christiansen.
3642
3643         Enable CSS sticky position feature by default for&nb