a0cf9b7d7a0d68ba5a1df9f0e17a2e0a72d4c6c7
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
2
3         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
4         https://bugs.webkit.org/show_bug.cgi?id=76269
5
6         Reviewed by Martin Robinson.
7
8         * gtk/gtkdoc.py:
9         (GTKDoc._run_gtkdoc_scangobj):
10
11 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
12
13         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
14         https://bugs.webkit.org/show_bug.cgi?id=76247
15
16         Reviewed by Kenneth Rohde Christiansen.
17
18         * WebKitTestRunner/TestController.cpp:
19         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
20
21 2012-01-13  Hajime Morrita  <morrita@chromium.org>
22
23         [Mac][DRT] Should support --no-timeout
24         https://bugs.webkit.org/show_bug.cgi?id=76242
25
26         Reviewed by Darin Adler.
27
28         * DumpRenderTree/mac/DumpRenderTree.mm:
29         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
30         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
31         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
32         * DumpRenderTree/mac/DumpRenderTreeMac.h:
33         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
34         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
35
36 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
37
38         Mitigate scrollbar differences when running pixel tests
39         https://bugs.webkit.org/show_bug.cgi?id=67217
40
41         Reviewed by Dan Bernstein.
42         
43         Enable mock scrollbars by default for tests.
44
45         * DumpRenderTree/mac/DumpRenderTree.mm:
46         (resetDefaultsToConsistentValues):
47         * WebKitTestRunner/TestController.cpp:
48         (WTR::TestController::resetStateToConsistentValues):
49
50 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
51
52         Need a script to run tests in PerformanceTests
53         https://bugs.webkit.org/show_bug.cgi?id=76132
54
55         Reviewed by Adam Barth.
56
57         Add run-perf-tests to run performance tests using parser/resources/runner.js.
58         Unfortunately, there isn't an easy way of telling which test uses which format
59         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
60
61         All test outputs are re-formatted to match Chromium perf-bot style.
62
63         * Scripts/run-inspector-perf-tests.py:
64         * Scripts/run-perf-tests: Added.
65         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
66         (PerfTestsRunner):
67         (PerfTestsRunner.__init__):
68         (PerfTestsRunner._collect_tests):
69         (PerfTestsRunner.run):
70         (PerfTestsRunner._print_status):
71         (PerfTestsRunner._run_tests_set):
72         (PerfTestsRunner._process_chromium_style_test_result):
73         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
74         (PerfTestsRunner._process_parser_test_result):
75         (PerfTestsRunner._run_single_test):
76         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
77         (MainTest.TestDriver.run_test):
78         (create_runner):
79         (run_test):
80         (test_run_test_set):
81         (test_run_test_set_for_parser_tests):
82         (test_collect_tests):
83
84 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
85
86         webkitpy: clean up port unit tests in preparation for making port_name mandatory
87         https://bugs.webkit.org/show_bug.cgi?id=76123
88
89         Reviewed by Adam Barth.
90
91         This change updates the unit tests to be more consistent in how
92         ports are created, in preparation for making port_name a
93         mandatory parameter to the constructor and removing any version
94         interpretation from it.
95
96         There should be no functional changes in this patch, but some
97         tests that are no longer relevant have been removed or reworked.
98
99         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
100         (PortTest.test_get_option__default):
101         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
102         (ChromiumLinuxPortTest):
103         (ChromiumLinuxPortTest.assert_architecture):
104         (ChromiumLinuxPortTest.test_determine_architecture_fails):
105         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
106         (ChromiumMacPortTest):
107         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
108         (ChromiumPortTest):
109         (ChromiumPortTest.test_all_test_configurations):
110         (ChromiumPortTest.TestMacPort.__init__):
111         (ChromiumPortTest.TestLinuxPort.__init__):
112         (ChromiumPortTest.TestWinPort.__init__):
113         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
114         (ChromiumWinTest):
115         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
116         (EflPortTest):
117         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
118         (GtkPortTest):
119         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
120         (MacTest):
121         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
122         (MockDRTPortTest):
123         (MockDRTPortTest.make_port):
124         * Scripts/webkitpy/layout_tests/port/qt.py:
125         (QtPort._port_flag_for_scripts):
126         (QtPort.__init__):
127         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
128         (QtPortTest):
129         (QtPortTest._assert_search_path):
130         (QtPortTest.test_baseline_search_path):
131         (QtPortTest.test_operating_system):
132         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
133         (WebKitPortTest):
134         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
135         (WinPortTest):
136         (WinPortTest._assert_search_path):
137         (WinPortTest.test_baseline_search_path):
138         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
139         (get_test_config.TestMacPort.__init__):
140
141 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
142
143         test-webkitpy: clean up logging and provide a real --help message
144         https://bugs.webkit.org/show_bug.cgi?id=76142
145
146         Reviewed by Adam Barth.
147
148         This test is mostly more refactoring - it calls objects in
149         unittest directly instead of routing through unittest.main() --
150         in order to gain more control over the logging and to provide a
151         correct --help message. This will also give us a better
152         foundation for adding more feautures down the road.
153
154         This patch adds different levels of logging controlled by the
155         '-s', '-q', and '-v' options (see --help for details), and
156         removes the --verbose-logging option.
157
158         * Scripts/test-webkitpy:
159         * Scripts/webkitpy/test/main.py:
160         (Tester):
161         (Tester.clean_packages):
162         (Tester.__init__):
163         (Tester.parse_args):
164         (Tester.configure):
165         (Tester._configure_logging):
166         (Tester.find_modules):
167         (Tester._exclude):
168         (Tester._modules_from_paths):
169         (Tester.run_tests):
170
171 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
172
173         Make the new WTF module build on Qt
174         https://bugs.webkit.org/show_bug.cgi?id=76163
175
176         Reviewed by Tor Arne Vestbø.
177
178         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
179
180 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
181
182         Unreviewed, mac DumpRenderTree fix.
183
184         * DumpRenderTree/mac/UIDelegate.mm:
185         (-[UIDelegate webView:addMessageToConsole:withSource:]):
186
187 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
188
189         WebKitTestRunner should not print console message line number when it is equal to zero.
190         https://bugs.webkit.org/show_bug.cgi?id=76167
191
192         Reviewed by Csaba Osztrogonác.
193
194         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
195         (WTR::InjectedBundlePage::willAddMessageToConsole):
196
197 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
198
199         Make default console messages line numbers consistent.
200         https://bugs.webkit.org/show_bug.cgi?id=74075
201
202         Reviewed by Pavel Feldman.
203
204         Unset line numbers are not printed to console now.
205         Added Source/WebCore/inspector to efl DumpRenderTree include path.
206
207         * DumpRenderTree/chromium/WebViewHost.cpp:
208         (WebViewHost::didAddMessageToConsole):
209         * DumpRenderTree/efl/CMakeLists.txt:
210         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
211         (onConsoleMessage):
212         * DumpRenderTree/gtk/DumpRenderTree.cpp:
213         (webViewConsoleMessage):
214         * DumpRenderTree/mac/UIDelegate.mm:
215         (-[UIDelegate webView:addMessageToConsole:withSource:]):
216         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
217         (WebCore::WebPage::javaScriptConsoleMessage):
218         * DumpRenderTree/win/UIDelegate.cpp:
219         (UIDelegate::webViewAddMessageToConsole):
220         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
221         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
222
223 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
224
225         test-webkitpy: push more logic into webkitpy.test.main, clean up code
226         https://bugs.webkit.org/show_bug.cgi?id=76021
227
228         Reviewed by Eric Seidel.
229
230         I plan to add more functionality to test-webkitpy, but it is
231         difficult to hack on now; this patch is the first of two that
232         brings test-webkitpy more inline with current coding style by
233         pushing more logic into the webkitpy.test.main.Tester class (so
234         that it will be testable itself).
235         
236         There should be no functional changes in this patch.
237
238         * Scripts/test-webkitpy:
239         (_path_from_webkit_root):
240         * Scripts/webkitpy/test/main.py:
241         (Tester):
242         (Tester.init):
243         (Tester.configure_logging):
244         (Tester.configure_logging.filter):
245         (Tester.clean_packages):
246         (Tester.run_tests):
247
248 2012-01-11  Wei Jia  <wjia@chromium.org>
249
250         implement layout tests for <video> with media stream
251         https://bugs.webkit.org/show_bug.cgi?id=74882
252
253         Reviewed by Kent Tamura.
254
255         * DumpRenderTree/DumpRenderTree.gypi:
256         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
257         (WebKit::WebUserMediaClientMock::create):
258         (WebKit::WebUserMediaClientMock::IsMockStream):
259         (WebKit::WebUserMediaClientMock::requestUserMedia):
260         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
261         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
262         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
263         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
264         * DumpRenderTree/chromium/WebViewHost.cpp:
265         (WebViewHost::userMediaClient):
266         (WebViewHost::userMediaClientMock):
267         (WebViewHost::createMediaPlayer):
268         (WebViewHost::mediaStreamUtil):
269         (WebViewHost::testMediaStreamClient):
270         * DumpRenderTree/chromium/WebViewHost.h:
271
272 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
273
274         Unreviewed, build fix.
275
276         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
277
278         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
279         (ChromiumWinPort.__init__):
280
281 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
282
283         Sheriffbot build fix. Don't emit empty lines on IRC.
284
285         * Scripts/webkitpy/tool/bot/irc_command.py:
286         (LastGreenRevision.execute):
287
288 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
289
290         last-green-revision should report the revision that succeeded on all bots
291         https://bugs.webkit.org/show_bug.cgi?id=76109
292
293         Reviewed by Adam Barth.
294
295         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
296         considered green by this algorithm, all matching builders must have a successful run at the revision
297         or two consecutive successful runs before and after the revision.
298
299         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
300         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
301
302         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
303         (BuildBot._revisions_for_builder):
304         (BuildBot):
305         (BuildBot._find_green_revision):
306         (BuildBot.last_green_revision):
307         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
308         (MockBuildBot.last_green_revision):
309         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
310         (test_revisions_for_builder):
311         (test_find_green_revision):
312         (test_last_green_revision):
313         * Scripts/webkitpy/tool/bot/irc_command.py:
314         (LastGreenRevision.execute):
315         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
316         (SheriffIRCBotTest.test_lgr):
317         * Scripts/webkitpy/tool/commands/queries.py:
318         (LastGreenRevision):
319
320 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
321
322         Unreviewed, fix build bustage on win32 introduced by r104725.
323
324         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
325         (MockDRTPortTest.make_port):
326         (MockChromiumDRTTest.test_pixeltest__fails):
327
328 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
329
330         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
331         https://bugs.webkit.org/show_bug.cgi?id=75618
332
333         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
334
335         Reviewed by Tony Chang.
336
337         * DumpRenderTree/chromium/LayoutTestHelper.mm:
338         (installLayoutTestColorProfile):
339         (restoreUserColorProfile):
340         (main):
341
342 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
343
344         test-webkitpy: fix -v and eliminate some spurious warnings
345         https://bugs.webkit.org/show_bug.cgi?id=76099
346
347         Reviewed by Adam Barth.
348
349         when we added support for --xml output, we broke the -v flag.
350
351         Also, fix the code to swallow a harmless warning from
352         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
353
354         test-webkitpy is now silent again except for the one known
355         logging issue.
356
357         * Scripts/webkitpy/common/checkout/checkout.py:
358         (Checkout.commit_message_for_this_commit):
359         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
360         (test_commit_message_for_this_commit):
361         * Scripts/webkitpy/style/checkers/jsonchecker.py:
362         (JSONChecker.check):
363         (JSONChecker.line_number_from_json_exception):
364         * Scripts/webkitpy/test/main.py:
365         (Tester.run_tests):
366
367 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
368
369         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
370         https://bugs.webkit.org/show_bug.cgi?id=76084
371
372         Reviewed by Adam Barth.
373
374         This will help make it easier to catch layering violations. This
375         change just refactors test code; there are no changes to
376         production code.
377
378         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
379         (PortTest.make_port):
380         (PortTest.test_find_no_paths_specified):
381         (PortTest.test_find_one_test):
382         (PortTest.test_find_glob):
383         (PortTest.test_find_with_skipped_directories):
384         (PortTest.test_find_with_skipped_directories_2):
385         (PortTest.test_parse_reftest_list):
386         (PortTest.test_httpd_returns_error_code):
387         (PortTest.test_virtual_methods):
388         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
389         (ChromiumGpuTest.assert_port_works):
390         (ChromiumGpuTest._assert_baseline_path):
391         (ChromiumGpuTest.test_graphics_type):
392         (ChromiumGpuTest.test_default_tests_paths.test_paths):
393         (ChromiumGpuTest.test_test_files):
394         (ChromiumGpuTest.test_test_files.test_paths):
395         (ChromiumGpuTest):
396         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
397         (ChromiumLinuxPortTest.assert_architecture):
398         (ChromiumLinuxPortTest.test_check_illegal_port_names):
399         (ChromiumLinuxPortTest.test_determine_architecture_fails):
400         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
401         (DriverTest.make_port):
402         (DriverTest):
403         (DriverTest.assertVirtual):
404         (DriverTest._assert_wrapper):
405         (DriverTest.test_virtual_driver_methods):
406         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
407         (MockDRTPortTest.make_port):
408         (MockDRTPortTest.test_port_name_in_constructor):
409         (MockDRTTest.assertTest):
410         (MockDRTTest.test_main):
411         (MockChromiumDRTTest.test_pixeltest__fails):
412         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
413         (QtPortTest._assert_search_path):
414         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
415         (TestWebKitPort.__init__):
416         (WebKitPortUnitTests.test_default_options):
417         (test_runtime_feature_list):
418         (test_test_expectations):
419
420 2012-01-11  Ojan Vafai  <ojan@chromium.org>
421
422         Style skipped tests in the flakiness dashboard
423         https://bugs.webkit.org/show_bug.cgi?id=76091
424
425         Reviewed by Tony Chang.
426
427         * TestResultServer/static-dashboards/dashboard_base.js:
428         Removed "FLAKY" from this list since we don't ever mark individual runs
429         as flaky. Also deleted an outdated line.
430         * TestResultServer/static-dashboards/flakiness_dashboard.html:
431
432 2012-01-11  Ojan Vafai  <ojan@chromium.org>
433
434         Remove gtest normalization code from the test results server
435         https://bugs.webkit.org/show_bug.cgi?id=76089
436
437         Reviewed by Tony Chang.
438
439         The normalization now happens on the gtest side.
440
441         * TestResultServer/model/jsonresults.py:
442         (JsonResults.merge):
443         * TestResultServer/model/jsonresults_unittest.py:
444         (JsonResultsTest.test_gtest):
445
446 2012-01-11  Ojan Vafai  <ojan@chromium.org>
447
448         Be more aggressive about deleting unnecessary results from the test-results-server json files
449         https://bugs.webkit.org/show_bug.cgi?id=76086
450
451         Reviewed by Tony Chang.
452
453         Remove any tests that only contain skip/pass/nodata values whose runtime
454         is less than 5 seconds.
455
456         * TestResultServer/model/jsonresults.py:
457         (JsonResults._normalize_results_json):
458         * TestResultServer/model/jsonresults_unittest.py:
459         (JsonResultsTest.test_merge_remove_test):
460         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
461
462 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
463
464         last-green-revision should give us per-bot information
465         https://bugs.webkit.org/show_bug.cgi?id=76011
466
467         Reviewed by Adam Barth.
468
469         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
470         we report the latest green run on each bot from the last 100 runs.
471
472         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
473         (BuildBot._fetch_builder_page):
474         (BuildBot):
475         (BuildBot._green_revision_for_builder):
476         (BuildBot.last_green_revision):
477         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
478         (test_green_revision_for_builder):
479         (test_last_green_revision):
480         * Scripts/webkitpy/tool/bot/irc_command.py:
481         (LastGreenRevision.execute):
482         * Scripts/webkitpy/tool/commands/queries.py:
483         (LastGreenRevision.execute):
484
485 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
486
487         webkitpy: clean up version detection in webkitpy.layout_tests.port
488         https://bugs.webkit.org/show_bug.cgi?id=76016
489
490         Reviewed by Adam Barth.
491
492         This change updates the code in webkitpy.layout_tests.port to
493         use the new os_name and os_version fields on host.platform. This
494         gets layout_tests.port out of the version parsing business. Most
495         of the diffs are just cleaning up test code to accomodate the
496         changes.
497
498         * Scripts/webkitpy/common/system/executive_mock.py:
499         (MockExecutive):
500         (MockExecutive.ignore_error):
501         (MockExecutive2):
502         (MockExecutive2.ignore_error):
503         * Scripts/webkitpy/common/system/platforminfo_mock.py:
504         (MockPlatformInfo.is_mac):
505         (MockPlatformInfo.is_linux):
506         (MockPlatformInfo.is_win):
507         * Scripts/webkitpy/common/system/systemhost_mock.py:
508         (MockSystemHost.__init__):
509         * Scripts/webkitpy/layout_tests/port/apple.py:
510         (ApplePort.__init__):
511         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
512         (ChromiumMacPort.__init__):
513         (ChromiumMacPort.check_wdiff):
514         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
515         (ChromiumMacPortTest):
516         (ChromiumMacPortTest.assert_name):
517         (ChromiumMacPortTest.test_versions):
518         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
519         (ChromiumPortTest.test_all_test_configurations):
520         (ChromiumPortTest.TestMacPort.__init__):
521         (ChromiumPortTest.TestLinuxPort.__init__):
522         (ChromiumPortTest.TestWinPort.__init__):
523         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
524         (ChromiumWinPort.__init__):
525         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
526         (ChromiumWinTest):
527         (ChromiumWinTest.assert_name):
528         (ChromiumWinTest.test_versions):
529         (ChromiumWinTest.test_baseline_path):
530         (ChromiumWinTest.test_build_path):
531         * Scripts/webkitpy/layout_tests/port/factory.py:
532         (PortFactory._port_name_from_arguments_and_options):
533         (PortFactory.get):
534         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
535         (FactoryTest):
536         (FactoryTest.setUp):
537         (FactoryTest.assert_port):
538         (FactoryTest.test_mac):
539         (FactoryTest.test_win):
540         (FactoryTest.test_google_chrome):
541         (FactoryTest.test_gtk):
542         (FactoryTest.test_qt):
543         (FactoryTest.test_chromium_gpu):
544         (FactoryTest.test_chromium_gpu_linux):
545         (FactoryTest.test_chromium_gpu_mac):
546         (FactoryTest.test_chromium_gpu_win):
547         (FactoryTest.test_chromium_mac):
548         (FactoryTest.test_chromium_linux):
549         (FactoryTest.test_chromium_win):
550         (FactoryTest.test_unknown_specified):
551         (FactoryTest.test_unknown_default):
552         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
553         (TestGoogleChromePort):
554         (TestGoogleChromePort._verify_baseline_path):
555         (TestGoogleChromePort._verify_expectations_overrides):
556         (TestGoogleChromePort.test_get_google_chrome_port):
557         * Scripts/webkitpy/layout_tests/port/mac.py:
558         (MacPort):
559         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
560         (MacTest):
561         (assert_name):
562         (test_tests_for_other_platforms):
563         (test_version):
564         (test_versions):
565         (test_is_version_methods):
566         (test_setup_environ_for_server):
567         (_assert_search_path):
568         (test_show_results_html_file):
569         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
570         (PortTestCase):
571         (PortTestCase.make_port):
572         * Scripts/webkitpy/layout_tests/port/win.py:
573         (WinPort):
574         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
575         (WinPortTest):
576         (WinPortTest.test_show_results_html_file):
577         (WinPortTest._assert_search_path):
578         (WinPortTest._assert_version):
579
580 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
581
582         [Qt][WK2] Remove workaround introduced into bug 75470
583         https://bugs.webkit.org/show_bug.cgi?id=75889
584
585         Reviewed by Tor Arne Vestbø.
586
587         * MiniBrowser/qt/qml/BrowserWindow.qml:
588
589 2012-01-10  Dmitry Lomov  <dslomov@google.com>
590
591         [Chromium] Remove obsolete references to WebWorker class.
592         https://bugs.webkit.org/show_bug.cgi?id=76020
593
594         Reviewed by David Levin.
595
596         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
597         * DumpRenderTree/chromium/WebViewHost.cpp:
598         * DumpRenderTree/chromium/WebViewHost.h:
599
600 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
601
602         [Qt] Some css3 filter tests are failing after r104698
603         https://bugs.webkit.org/show_bug.cgi?id=76055
604
605         Reviewed by Simon Hausmann.
606
607         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
608         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
609
610 2012-01-11  Tony Chang  <tony@chromium.org>
611
612         Don't remove 0 byte files when running build-webkit --chromium
613         https://bugs.webkit.org/show_bug.cgi?id=75997
614
615         Reviewed by Csaba Osztrogonác.
616
617         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
618
619         * Scripts/webkitdirs.pm:
620         (determineIsQt):
621
622 2012-01-10  David Kilzer  <ddkilzer@apple.com>
623
624         Add TestWebKitAPI tests for KURL
625         <http://webkit.org/b/75774>
626
627         Reviewed by Adam Barth.
628
629         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
630         WebCore folder and KURL.cpp source file to the project.
631         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
632         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
633         during setup since this test doesn't go through WebKit or
634         WebKit2.
635         (TestWebKitAPI::TEST_F): Add two basic tests.
636
637 2012-01-10  David Kilzer  <ddkilzer@apple.com>
638
639         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
640
641         Reviewed by Adam Barth.
642
643         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
644
645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
646         WTFStringUtilities.h to the project.
647         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
648         WTFStringUtilities.h.
649         * TestWebKitAPI/WTFStringUtilities.h: Added.
650         (WTF::operator<<):
651
652 2012-01-10  Vincent Scheib  <scheib@chromium.org>
653
654         Clarify run-webkit-tests options reset-results and new-baseline
655         https://bugs.webkit.org/show_bug.cgi?id=75993
656
657         Reviewed by Dirk Pranke.
658
659         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
660         (parse_args):
661
662 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
663
664         Disabled mock scrollbars should draw differently
665         https://bugs.webkit.org/show_bug.cgi?id=75995
666
667         Reviewed by James Robinson.
668
669         When the scrollbar is disabled, paint the entire track of
670         mock scrollbars with a lighter gray, and hide the thumb.
671
672         * DumpRenderTree/mac/DumpRenderTree.mm:
673         (-[DRTMockScroller drawKnob]):
674         (-[DRTMockScroller drawRect:]):
675
676 2012-01-10  James Robinson  <jamesr@chromium.org>
677
678         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
679         https://bugs.webkit.org/show_bug.cgi?id=75988
680
681         Reviewed by Adam Barth.
682
683         * Scripts/webkitpy/common/config/ports.py:
684         (WebKitPort.run_webkit_unit_tests_command):
685         (WebKitPort):
686         (ChromiumPort.run_webkit_unit_tests_command):
687         (ChromiumPort):
688         * Scripts/webkitpy/common/config/ports_mock.py:
689         (MockPort.run_webkit_unit_tests_command):
690         * Scripts/webkitpy/tool/commands/download_unittest.py:
691         (DownloadCommandsTest.test_build_and_test):
692         (test_land):
693         (test_land_red_builders):
694         * Scripts/webkitpy/tool/steps/runtests.py:
695         (RunTests.run):
696         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
697
698 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
699
700         webkitpy: add os_name, os_version to platforminfo
701         https://bugs.webkit.org/show_bug.cgi?id=75931
702
703         Reviewed by Eric Siedel.
704
705         As a first step in cleaning up the version parsing logic in
706         webkitpy.layout_tests.port, this adds common routines for
707         getting the os_name and os_version fields to the PlatformInfo
708         class. Nothing uses them yet but I've added FIXME's to some of
709         the code that needs to be deleted in the port files.
710
711         * Scripts/webkitpy/common/system/platforminfo.py:
712         (PlatformInfo.__init__):
713         (PlatformInfo):
714         (PlatformInfo._determine_os_name):
715         (PlatformInfo._determine_mac_version):
716         (PlatformInfo._determine_linux_version):
717         (PlatformInfo._determine_win_version):
718         (PlatformInfo.display_name):
719         (PlatformInfo.total_bytes_memory):
720         (PlatformInfo._compute_bytes_from_vm_stat_output):
721         (PlatformInfo.free_bytes_memory):
722         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
723         (TestPlatformInfo):
724         (TestPlatformInfo.make_info):
725         (TestPlatformInfo.make_info.mock_run_command):
726         (TestPlatformInfo.setUp):
727         (TestPlatformInfo.tearDown):
728         (TestPlatformInfo.test_basic):
729         (TestPlatformInfo.integration_test_basic):
730         (TestPlatformInfo.test_display_name_mac):
731         (TestPlatformInfo.test_display_name_win32):
732         (TestPlatformInfo.test_memory_mac):
733         (TestPlatformInfo.test_memory_win32):
734         (TestPlatformInfo.test_determine_os_name):
735         (TestPlatformInfo.test_determine_mac_version):
736         (TestPlatformInfo.test_determine_linux_version):
737         (TestPlatformInfo.test_determine_win_version_from_tuple):
738         (TestPlatformInfo.test_determine_win_version_from_cmd):
739         * Scripts/webkitpy/layout_tests/port/apple.py:
740         (ApplePort.__init__):
741         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
742         (ChromiumMacPort.__init__):
743         * Scripts/webkitpy/layout_tests/port/mac.py:
744         (MacPort):
745         * Scripts/webkitpy/layout_tests/port/win.py:
746         (WinPort):
747
748 2012-01-10  Adam Roben  <aroben@apple.com>
749
750         Make it possible to type data: URLs into MiniBrowser on Windows
751
752         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
753         MiniBrowser on Windows
754
755         Reviewed by Darin Adler.
756
757         * MiniBrowser/win/BrowserWindow.cpp:
758         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
759         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
760         does, we assume it already has a scheme and don't modify it.
761
762 2012-01-10  Adam Roben  <aroben@apple.com>
763
764         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
765
766         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
767         MiniBrowser on Windows
768
769         Reviewed by Darin Adler.
770
771         * MiniBrowser/win/BrowserView.cpp:
772         (BrowserView::goToURL): Pass the typed string through
773         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
774
775 2012-01-10  Ben Wells  <benwells@chromium.org>
776
777         Adding myself (benwells) to committers.py
778         https://bugs.webkit.org/show_bug.cgi?id=75971
779
780         Reviewed by Ojan Vafai.
781
782         * Scripts/webkitpy/common/config/committers.py:
783
784 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
785
786         AX: support helpText() in DumpRenderTree
787         https://bugs.webkit.org/show_bug.cgi?id=40193
788
789         Reviewed by Chris Fleizach.
790
791         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
792         (AccessibilityUIElement::helpText): Implemented.
793
794 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
795
796         Unreviewed, rolling out r104572.
797         http://trac.webkit.org/changeset/104572
798         https://bugs.webkit.org/show_bug.cgi?id=75967
799
800         It broke zillion tests (Requested by Ossy on #webkit).
801
802         * DumpRenderTree/qt/EventSenderQt.cpp:
803         (EventSender::EventSender):
804         (EventSender::sendOrQueueEvent):
805         (EventSender::replaySavedEvents):
806         (EventSender::eventFilter):
807         * DumpRenderTree/qt/EventSenderQt.h:
808
809 2012-01-10  Hugo Parente Lima  <hugo.lima@openbossa.org>
810
811         [Qt] fast/events/dont-loose-last-event test fails on WK1
812         https://bugs.webkit.org/show_bug.cgi?id=73894
813
814         Reviewed by Simon Hausmann.
815
816         Empty the entire event queue when requested besides using
817         sendEvent instead of postEvent to make sure all events were
818         delivered.
819         This commit also removes not working DRT code to handle drag and drop,
820         for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
821
822         * DumpRenderTree/qt/EventSenderQt.cpp:
823         (EventSender::EventSender):
824         (EventSender::sendOrQueueEvent):
825         (EventSender::replaySavedEvents):
826         * DumpRenderTree/qt/EventSenderQt.h:
827
828 2012-01-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
829
830         [Qt] Enable CSS_FILTERS in Qt build
831         https://bugs.webkit.org/show_bug.cgi?id=75777
832
833         Add the CSS_FILTERS feature flag to Qt.
834
835         Reviewed by Kenneth Rohde Christiansen.
836
837         * qmake/mkspecs/features/features.prf:
838
839 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
840
841         [Qt] Unreviewed -Werror build fix.
842
843         * MiniBrowser/qt/MiniBrowserApplication.cpp:
844         (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
845         declaration.
846
847 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
848
849         [Qt] Remove dependency to uitools
850         https://bugs.webkit.org/show_bug.cgi?id=75952
851
852         Reviewed by Tor Arne Vestbø.
853
854         QUiLoader is used for creating QLabel/QProgressBar widgets for
855         a layout test, to verify some widget embedding feature. Unfortunately
856         in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
857         depends on qttools. Since we don't really _need_ QUiLoader for our tests,
858         let's break the circular dependency.
859
860         * DumpRenderTree/qt/DumpRenderTree.pro:
861         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
862         (WebCore::WebPage::createPlugin):
863         * QtTestBrowser/QtTestBrowser.pro:
864         * QtTestBrowser/launcherwindow.h:
865         * QtTestBrowser/webpage.cpp:
866         (WebPage::createPlugin):
867         * qmake/mkspecs/features/minimal_qt.prf:
868         * qmake/mkspecs/features/uitools.prf: Removed.
869
870 2012-01-10  Alexander Færøy  <alexander.faeroy@nokia.com>
871
872         [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
873         https://bugs.webkit.org/show_bug.cgi?id=75894
874
875         Reviewed by Tor Arne Vestbø.
876
877         * MiniBrowser/qt/MiniBrowserApplication.h:
878         (MiniBrowserApplication::windowOptions):
879         * MiniBrowser/qt/main.cpp:
880         (main):
881
882 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
883
884         [Qt] DRT crashes with Qt 5
885         https://bugs.webkit.org/show_bug.cgi?id=75951
886
887         Reviewed by Ossy.
888
889         * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
890         Qt relies on font-config to define the default font family.
891
892 2012-01-10  Csaba Osztrogonác  <ossy@webkit.org>
893
894         [Qt] REGRESSION(r100130): Clean build feature is broken.
895         https://bugs.webkit.org/show_bug.cgi?id=75863
896
897         Reviewed by Tor Arne Vestbø.
898
899         * Scripts/webkitdirs.pm:
900         (buildQMakeProject):
901
902 2012-01-10  Zeno Albisser  <zeno@webkit.org>
903
904         [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
905         https://bugs.webkit.org/show_bug.cgi?id=75885
906
907         In QML events are propagated through parents. But since the
908         WebView may consume key events, a shortcut might never reach
909         the top QtQuickItem.
910         Therefore an application wide event handling function in C++
911         needs to take care of shortcuts for MiniBrowser.
912
913         Reviewed by Kenneth Rohde Christiansen.
914
915         * MiniBrowser/qt/BrowserWindow.cpp:
916         (BrowserWindow::reload):
917         (BrowserWindow::focusAddressBar):
918         * MiniBrowser/qt/BrowserWindow.h:
919         * MiniBrowser/qt/MiniBrowserApplication.cpp:
920         (MiniBrowserApplication::notify):
921         * MiniBrowser/qt/qml/BrowserWindow.qml:
922
923 2012-01-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
924
925         Add --efl alias for --platform=efl to run-webkit-test
926         https://bugs.webkit.org/show_bug.cgi?id=75937
927
928         Reviewed by Andreas Kling.
929         
930         * Scripts/run-webkit-tests: Add --efl alias.
931         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
932         (parse_args):
933
934 2012-01-09  Dan Bernstein  <mitz@apple.com>
935
936         -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
937         https://bugs.webkit.org/show_bug.cgi?id=75920
938
939         Reviewed by Darin Adler.
940
941         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
942         (TestWebKitAPI::TEST): Added a test for a range in a
943         -webkit-user-select: none; block.
944
945 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
946
947         webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
948         https://bugs.webkit.org/show_bug.cgi?id=75884
949
950         Reviewed by Ryosuke Niwa.
951
952         Fix regression introduced (revealed?) in r104340. Chromium file         
953         url syntax is different on win32 and the test results weren't           
954         expecting that.                                                         
955
956         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
957         (TestExpectations._report_errors):
958         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
959         (test_parse_error_nonfatal):
960         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
961         (MockDRTTest.input_line):
962         (MockChromiumDRTTest.test_pixeltest__fails):
963         * Scripts/webkitpy/layout_tests/port/test.py:
964         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
965         (TestRebaseliner.make_rebaseliner):
966         (TestRebaseliner.test_one_platform):
967         (TestRebaseliner.test_all_platforms):
968         (TestRebaseliner.test_png_file_with_comment):
969         (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
970         (TestRebaseliner.test_png_file_with_comment_as_duplicate):
971         (TestRealMain.test_all_platforms):
972
973 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
974
975         Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
976
977         Unreviewed, build fix.
978
979         test-webkitpy had a built-in self-test routine to verify that
980         deleting the .pyc files worked correctly. When I removed the
981         python24 directory in r104482, I broke the self-test.
982
983         I have deleted the self-test for now. Since I am reworking
984         test-webkitpy I will make sure the new version is adequately
985         tested.
986
987         * Scripts/test-webkitpy:
988         (configure_logging):
989         (_clean_pyc_files):
990         (_clean_packages):
991         (init):
992
993 2012-01-09  Justin Novosad  <junov@chromium.org>
994
995         [Chromium] remove all references to the legacy accelerated 2d Canvas
996         implementation
997         https://bugs.webkit.org/show_bug.cgi?id=75108
998
999         Purging an old settings flag that is no longer referenced
1000
1001         Reviewed by Darin Fisher.
1002
1003         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1004         (main):
1005         * DumpRenderTree/chromium/TestShell.cpp:
1006         (TestShell::TestShell):
1007         (TestShell::resetWebSettings):
1008         * DumpRenderTree/chromium/TestShell.h:
1009         (TestShell::setAccelerated2dCanvasEnabled):
1010         * DumpRenderTree/chromium/WebPreferences.cpp:
1011         (WebPreferences::reset):
1012         (WebPreferences::applyTo):
1013         * DumpRenderTree/chromium/WebPreferences.h:
1014
1015 2012-01-09  Adam Roben  <aroben@apple.com>
1016
1017         Convert Cygwin paths to Windows paths before passing them to DRT
1018
1019         Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
1020         NRWT
1021
1022         I couldn't find a way to test this because I couldn't figure out how to override the
1023         cygpath function as it is used by WebKitDriver.
1024
1025         Reviewed by Dirk Pranke.
1026
1027         * Scripts/webkitpy/layout_tests/port/webkit.py:
1028         (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
1029         Windows-style path before passing it to DRT.
1030
1031 2012-01-06  Dirk Pranke  <dpranke@chromium.org>
1032
1033         webkitpy: revamp version checking
1034         https://bugs.webkit.org/show_bug.cgi?id=75765
1035
1036         Reviewed by Adam Barth.
1037
1038         The version-checking code in webkitpy/python24/versioning seems really
1039         awkward and overdesigned, especially since we don't support python 2.4
1040         any more.
1041
1042         In addition, I am tired of getting warnings about Python 2.6 being "a
1043         newer release than what is supported" :).
1044
1045         I'm taking a page from the depot_tools python code and just creating a
1046         new webkitpy.common.version_check module that will print a message on
1047         stderr and call sys.exit() if we're running an unsupported version.
1048
1049         * Scripts/check-webkit-style:
1050         * Scripts/new-run-webkit-httpd:
1051         * Scripts/new-run-webkit-tests:
1052         * Scripts/rebaseline-chromium-webkit-tests:
1053         * Scripts/test-webkitpy:
1054         (configure_logging):
1055         (init):
1056         * Scripts/webkit-patch:
1057         (main):
1058         * Scripts/webkitpy/common/system/executive.py:
1059         (Executive._child_process_encoding):
1060         (Executive._should_encode_child_process_arguments):
1061         * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
1062         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1063         * Scripts/webkitpy/python24/__init__.py: Removed.
1064         * Scripts/webkitpy/python24/versioning.py: Removed.
1065         * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
1066
1067 2012-01-09  Adam Barth  <abarth@webkit.org>
1068
1069         Remove Chromium Mac CG from the flakiness dashboard
1070         https://bugs.webkit.org/show_bug.cgi?id=75873
1071
1072         Reviewed by Ojan Vafai.
1073
1074         This configuration no longer exists.
1075
1076         * TestResultServer/static-dashboards/builders.js:
1077         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1078         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1079         (testOverrideJustBuildType):
1080         (testPlatformAndBuildType):
1081
1082 2012-01-06  Adam Roben  <aroben@apple.com>
1083
1084         Print an error message when NRWT can't run Apache
1085
1086         Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
1087
1088         Reviewed by Dirk Pranke.
1089
1090         * Scripts/webkitpy/layout_tests/port/base.py:
1091         (Port.check_httpd): Print an error message when Apache returns an error code instead of
1092         failing silently.
1093
1094         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1095         (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
1096         run Apache.
1097         (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
1098         fails.
1099
1100 2012-01-09  Gabor Rapcsanyi  <rgabor@webkit.org>
1101
1102         [Gtk][ARM] Cross compiler buildbot is failing after r103040
1103         https://bugs.webkit.org/show_bug.cgi?id=75846
1104
1105         Reviewed by Philippe Normand.
1106
1107         * Scripts/webkitdirs.pm:
1108         (runAutogenForAutotoolsProjectIfNecessary):
1109
1110 2012-01-09  Alexander Færøy  <ahf@0x90.dk>
1111
1112         [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
1113         https://bugs.webkit.org/show_bug.cgi?id=75807
1114
1115         This patch adds a new icon to navigationbar of the Qt MiniBrowser
1116         which allows you to dynamically toggle whether touch mocking is
1117         enabled or disabled.
1118
1119         Reviewed by Tor Arne Vestbø.
1120
1121         * MiniBrowser/qt/MiniBrowser.qrc:
1122         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1123         (MiniBrowserApplication::notify):
1124         * MiniBrowser/qt/MiniBrowserApplication.h:
1125         (WindowOptions::WindowOptions):
1126         (WindowOptions::touchMockingEnabled):
1127         (WindowOptions::setTouchMockingEnabled):
1128         * MiniBrowser/qt/icons/touch.png: Added.
1129         * MiniBrowser/qt/qml/BrowserWindow.qml:
1130
1131 2012-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1132
1133         Unreviewed. Fix make distcheck issues.
1134
1135         * MiniBrowser/gtk/GNUmakefile.am:
1136
1137 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
1138
1139         Unreviewed, rolling out r104421.
1140         http://trac.webkit.org/changeset/104421
1141         https://bugs.webkit.org/show_bug.cgi?id=75816
1142
1143         Need to rebaseline some tests on Linux (Requested by noamr on
1144         #webkit).
1145
1146         * qmake/mkspecs/features/features.prf:
1147
1148 2012-01-08  Adam Barth  <abarth@webkit.org>
1149
1150         Remove support for Chromium Mac CG from garden-o-matic
1151         https://bugs.webkit.org/show_bug.cgi?id=75814
1152
1153         Reviewed by Eric Seidel.
1154
1155         This configuration no longer exists.  This patch is mostly a matter of
1156         updating config.js and removing the examples from the unit tests.
1157
1158         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1159         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1160         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1162         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1163
1164 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
1165
1166         [Qt] Enable CSS_FILTERS in Qt build
1167         https://bugs.webkit.org/show_bug.cgi?id=75777
1168
1169         Add the CSS_FILTERS feature flag to Qt.
1170
1171         Reviewed by Kenneth Rohde Christiansen.
1172
1173         * qmake/mkspecs/features/features.prf:
1174
1175 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
1176
1177         Categorize bots by ports instead of core/non-core separation
1178         https://bugs.webkit.org/show_bug.cgi?id=75766
1179
1180         Reviewed by Eric Seidel.
1181
1182         Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
1183         (Chromium still comes before GTK and Qt).
1184
1185         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1186         (loadBuilderConfig):
1187         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1188
1189 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
1190
1191         Remove the concept of core builders from webkitpy
1192         https://bugs.webkit.org/show_bug.cgi?id=75809
1193
1194         Reviewed by Ryosuke Niwa.
1195
1196         Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
1197         and remove the relevant code.
1198
1199         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1200         (BuildBot.__init__):
1201         (BuildBot._matches_regexps):
1202         (BuildBot._builder_statuses_with_names_matching_regexps):
1203         (BuildBot.builder_statuses):
1204         (BuildBot.failure_map):
1205         (BuildBot._latest_builds_from_builders):
1206         (BuildBot.last_green_revision):
1207         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1208         (MockBuildBot.builder_statuses):
1209         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1210         (test_status_parsing):
1211         (test_last_green_revision):
1212         (test_last_green_revision.mock_builds_from_builders):
1213
1214 2012-01-08  Adam Barth  <abarth@webkit.org>
1215
1216         Remove Chromium Mac CG concept from webkitpy
1217         https://bugs.webkit.org/show_bug.cgi?id=75810
1218
1219         Reviewed by Ryosuke Niwa.
1220
1221         This configuration no longer exists.  We can remove all the supporting
1222         code from webkitpy.
1223
1224         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1225         (BaselineOptimizerTest.test_move_baselines):
1226         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
1227         (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
1228         (BaselineOptimizerTest.test_common_directory_includes_root):
1229         (BaselineOptimizerTest.test_complex_shadowing):
1230         * Scripts/webkitpy/common/config/build.py:
1231         (_should_file_trigger_build):
1232         * Scripts/webkitpy/common/config/build_unittest.py:
1233         (ShouldBuildTest):
1234         * Scripts/webkitpy/layout_tests/port/builders.py:
1235         * Scripts/webkitpy/layout_tests/port/chromium.py:
1236         (ChromiumPort):
1237         (ChromiumPort._generate_all_test_configurations):
1238         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1239         (_default_tests_paths):
1240         (ChromiumGpuLinuxPort.tests):
1241         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1242         (ChromiumGpuTest.integration_test_chromium_gpu_mac):
1243         (ChromiumGpuTest.assert_port_works):
1244         (ChromiumGpuTest.test_baseline_paths):
1245         (ChromiumGpuTest.test_graphics_type):
1246         (ChromiumGpuTest.test_default_tests_paths):
1247         (ChromiumGpuTest.test_test_files):
1248         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1249         (ChromiumMacPort):
1250         (ChromiumMacPort.__init__):
1251         (ChromiumMacPort.baseline_search_path):
1252         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1253         (ChromiumMacPortTest.test_graphics_type):
1254         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1255         (ChromiumPortTest.test_all_test_configurations):
1256         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1257         * Scripts/webkitpy/layout_tests/port/factory.py:
1258         (PortFactory._port_name_from_arguments_and_options):
1259         (PortFactory.get):
1260         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1261         (FactoryTest.test_chromium_gpu_mac):
1262         (FactoryTest.test_chromium_mac):
1263         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1264         (GetGoogleChromePortTest._verify_expectations_overrides):
1265         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1266         (MockChromiumDRTTest.test_chromium_parse_options):
1267         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1268         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1269         (test_url_fetcher):
1270         (test_zip_factory):
1271         (test_archive):
1272         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1273         (TestRebaseline.test_rebaseline_expectations):
1274
1275 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
1276
1277         Categorize bots by ports instead of core/non-core separation
1278         https://bugs.webkit.org/show_bug.cgi?id=75766
1279
1280         Reviewed by Adam Barth.
1281
1282         Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
1283
1284         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1285         (loadBuilderConfig):
1286         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1287
1288 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
1289
1290         Unreviewed, rolling out r104403.
1291         http://trac.webkit.org/changeset/104403
1292         https://bugs.webkit.org/show_bug.cgi?id=75803
1293
1294         It broke all tests on Qt5 (Requested by Ossy_weekend on
1295         #webkit).
1296
1297         * qmake/mkspecs/features/features.prf:
1298
1299 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
1300
1301         [Qt] Enable CSS_FILTERS in Qt build
1302         https://bugs.webkit.org/show_bug.cgi?id=75777
1303
1304         Add the CSS_FILTERS feature flag to Qt.
1305
1306         Reviewed by Kenneth Rohde Christiansen.
1307
1308         * qmake/mkspecs/features/features.prf:
1309
1310 2012-01-04  Kentaro Hara  <haraken@chromium.org>
1311
1312         Rewrite the CSS parser of prepare-ChangeLog with unittests.
1313         https://bugs.webkit.org/show_bug.cgi?id=75202
1314
1315         Reviewed by David Kilzer.
1316
1317         The current CSS parser can just parse simple CSSes like
1318
1319             foo bar baz {
1320                 property1: value;
1321                 property2: value;
1322             }
1323
1324         , and cannot parse comments nor a CSS in which a selector and {
1325         appears in different lines. This patch rewrites the CSS parser
1326         (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
1327         shown in css_unittests.css.
1328
1329         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
1330
1331         * Scripts/prepare-ChangeLog:
1332         (get_selector_line_ranges_for_css):
1333         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1334         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
1335         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
1336         (element1):
1337         (element2):
1338         (element3):
1339         (element4.p):
1340         (element5.p.q.r.s):
1341         (element6#p):
1342         (element7 element8):
1343         (element9.p element10.q):
1344         (element11#p element12#q):
1345         (element13, element14):
1346         (.p):
1347         (#p):
1348         (.p element15 #q element16.r element17#s):
1349         (element18:target):
1350         (element19):
1351         (element20):
1352         (element21):
1353         (element22):
1354
1355 2012-01-04  Kentaro Hara  <haraken@chromium.org>
1356
1357         The Perl parser of prepare-ChangeLog can parse here-documents
1358         https://bugs.webkit.org/show_bug.cgi?id=73208
1359
1360         Reviewed by David Kilzer.
1361
1362         Currently prepare-ChangeLog cannot recognize here-documents in Perl,
1363         which results in wrong subroutine names in ChangeLogs.
1364         With this patch, prepare-ChangeLog can judge whether the line of "}"
1365         is the end of a subroutine or a line inside a here-document.
1366
1367         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
1368
1369         * Scripts/prepare-ChangeLog:
1370         (get_function_line_ranges_for_perl):
1371         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1372         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1373         Added test cases for here-documents.
1374         (func7):
1375         (func8):
1376         (func9):
1377         (func10):
1378         (func11):
1379         (func12):
1380         (func13):
1381         (func14):
1382         (func15):
1383         (func16):
1384
1385 2012-01-08  Kentaro Hara  <haraken@chromium.org>
1386
1387         Add unittests for the JavaScript parser of prepare-ChangeLog
1388         https://bugs.webkit.org/show_bug.cgi?id=75201
1389
1390         Reviewed by David Kilzer.
1391
1392         javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
1393         of prepare-ChangeLog.
1394
1395         * Scripts/prepare-ChangeLog:
1396         (get_function_line_ranges_for_javascript): Before this patch, a string found was just
1397         omitted from parsing. Thus,
1398
1399             str = "foo"
1400             function func() {
1401             }
1402
1403         was recognized as equivalent to
1404
1405             str = function func() {
1406             }
1407
1408         This patch replaces a string with a dummy identifier 'string_appeared_here'
1409         to tell the parser that a string appeared there.
1410
1411         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1412         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
1413         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
1414         (func1):
1415         (func2):
1416         (func3):
1417         (func4):
1418         (func5):
1419         (func6):
1420         (func7):
1421         (func8):
1422         (func9):
1423         (func10):
1424         (func11):
1425         (func12):
1426         (funcOverloaded):
1427         (Func1.prototype.get x1):
1428         (Func1.prototype.get x2):
1429         (Func1.prototype.set x1):
1430         (Func1.prototype.set x3):
1431         (Func2.prototype.func13):
1432         (Func2.prototype.func14):
1433         (Func2.prototype.func15):
1434         (func16.func17):
1435         (func16.func18):
1436         (func16.func19):
1437         (func16):
1438
1439 2012-01-08  David Levin  <levin@chromium.org>
1440
1441         [chromium] Add layout test support for autosize code in FrameView.
1442         https://bugs.webkit.org/show_bug.cgi?id=73631
1443
1444         Reviewed by Dmitry Titov.
1445
1446         * DumpRenderTree/chromium/LayoutTestController.cpp:
1447         (LayoutTestController::LayoutTestController): Expose the new autoresize method.
1448         (LayoutTestController::reset): Set the autoresize mode back to false.
1449         (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
1450         * DumpRenderTree/chromium/LayoutTestController.h:
1451         * DumpRenderTree/chromium/WebViewHost.cpp:
1452         (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
1453         * DumpRenderTree/chromium/WebViewHost.h:
1454
1455 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
1456
1457         [WK2][GTK] Each test takes roughly half a second to load
1458         https://bugs.webkit.org/show_bug.cgi?id=70699
1459
1460         Reviewed by Martin Robinson.
1461
1462         Set the XDG_CACHE_HOME environment variable when testing with
1463         WebKitTestRunner. This way the testing is started with a non-existing
1464         application cache. If the cache exists and is not empty, the emptying
1465         and vacuuming that is performed before every test can consume a lot of
1466         time.
1467
1468         This is just a temporary workaround until it becomes possible to set
1469         a desired directory to be used as the application cache location through
1470         WebKitWebContext.
1471
1472         * Scripts/webkitpy/layout_tests/port/gtk.py:
1473         (GtkPort.setup_environ_for_server):
1474
1475 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
1476
1477         [GTK] Enable requestAnimationFrame in build-webkit
1478         https://bugs.webkit.org/show_bug.cgi?id=75773
1479
1480         Reviewed by Martin Robinson.
1481
1482         Enable requestAnimationFrame for the Gtk port.
1483
1484         * Scripts/build-webkit:
1485
1486 2012-01-06  Jarred Nicholls  <jarred@sencha.com>
1487
1488         Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
1489
1490         * Scripts/webkitdirs.pm:
1491         (buildChromium):
1492         Missing parentheses.
1493
1494 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
1495
1496         Fix DRT build on case-sensitive file systems.
1497
1498         Fix case of include of WebDynamicScrollBarsView.h
1499         
1500         * DumpRenderTree/mac/DumpRenderTree.mm:
1501
1502 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
1503
1504         Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
1505         https://bugs.webkit.org/show_bug.cgi?id=75662
1506
1507         Reviewed by Dan Bernstein.
1508         
1509         The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
1510         of color profile issues. Fix by keeping everything in device RGB and ensuring that the
1511         test window uses the main display's color space, so that the pixel values in the bitmap
1512         that gets checksummed are identical to the CSS colors.
1513         
1514         Removed the code that switches the display profile in DRT, since that is no longer required.
1515
1516         * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
1517         * DumpRenderTree/mac/DumpRenderTree.mm:
1518         (crashHandler): Remove code that switches display profiles.
1519         (prepareConsistentTestingEnvironment): Ditto.
1520         (dumpRenderTree): Ditto.
1521         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
1522         (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
1523         (createBitmapContextFromWebView): Add comment about the colorspace handling.
1524         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1525         (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
1526         (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
1527         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1528         (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
1529         (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
1530
1531 2012-01-06  David Kilzer  <ddkilzer@apple.com>
1532
1533         run-api-tests: specify individual suites and tests on the command-line
1534
1535         Reviewed by Adam Roben.
1536
1537         Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
1538
1539         The run-api-tests script will now accept a list of arguments on
1540         the command-line that are used as prefix filters.  To run all
1541         tests in a suite that starts with "WTF" (WTF and WTF_Vector)
1542         use:
1543
1544             $ run-api-tests WTF
1545
1546         To run only the tests in the "WTF" suite, not the "WTF_Vector"
1547         suite, use:
1548
1549             $ run-api-tests WTF.
1550
1551         * Scripts/run-api-tests: Filter tests if any prefix arguments
1552         are passed on the command-line.
1553
1554 2012-01-06  David Kilzer  <ddkilzer@apple.com>
1555
1556         run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
1557
1558         Reviewed by Adam Roben.
1559
1560         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
1561
1562         * Scripts/run-api-tests:
1563         (dumpTestsBySuite): Update to accept array of tests instead of
1564         hash data structure.
1565         (runTestsBySuite): Ditto.
1566         (listAllTests): Rename from populateTests().  Update to return
1567         an array of tests instad of the hash data structure.
1568
1569 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
1570
1571         webkitpy: clean up test/uri conversion routines
1572         https://bugs.webkit.org/show_bug.cgi?id=75648
1573
1574         Reviewed by Eric Seidel.
1575
1576         This change moves test_to_uri and uri_to_test from the Port
1577         class to the Driver class (the routines were only being
1578         called by the drivers), and removes a bunch of stale and/or
1579         busted logic.
1580
1581         * Scripts/webkitpy/layout_tests/port/base.py:
1582         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1583         * Scripts/webkitpy/layout_tests/port/chromium.py:
1584         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1585         * Scripts/webkitpy/layout_tests/port/driver.py:
1586         (is_http_test):
1587         (test_to_uri):
1588         (uri_to_test):
1589         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1590         (run_one_test):
1591         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1592         (MockDRTTest.input_line):
1593         (input_line):
1594         (expected_output):
1595         * Scripts/webkitpy/layout_tests/port/test.py:
1596         * Scripts/webkitpy/layout_tests/port/webkit.py:
1597         (_command_from_driver_input):
1598
1599 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
1600
1601         Mitigate scrollbar differences when running pixel tests
1602         https://bugs.webkit.org/show_bug.cgi?id=67217
1603
1604         Reviewed by Dan Bernstein.
1605         
1606         Add an NSScroller subclass that draws mock scrollbars identically
1607         to the WebCore mock scrollbar theme, and register it with the
1608         WebDynamicScrollbarsView.
1609
1610         * DumpRenderTree/mac/DumpRenderTree.mm:
1611         (-[DRTMockScroller rectForPart:]):
1612         (-[DRTMockScroller drawKnob]):
1613         (-[DRTMockScroller drawRect:]):
1614         (registerMockScrollbars):
1615         (prepareConsistentTestingEnvironment):
1616
1617 2012-01-05  Jon Lee  <jonlee@apple.com>
1618
1619         Update DRT on Mac to draw resize handles on text areas.
1620
1621         Reviewed by John Sullivan.
1622
1623         Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
1624         between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
1625
1626         * DumpRenderTree/mac/DumpRenderTree.mm:
1627         (resetDefaultsToConsistentValues):
1628
1629 2012-01-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1630
1631         [Qt] Move listing of include paths and libs to pri files in sources
1632
1633         Includepaths are sometimes modified by non-Qt contributors so keeping
1634         them in files inside Sources makes it more likely that they are updated
1635         along with project files for the other ports.
1636
1637         Using pri files instead of prf files for this also has the benefit that
1638         the include() from the main target file can be parsed and followed by
1639         Qt Creator -- something that does not work with load().
1640
1641         Dependency from a target to a library through the WEBKIT variable are
1642         handled through forwarding-files in Tools/qmake/mkspecs/modules, which
1643         set the source root of the module and include the right pri file.
1644
1645         Ideally we'd use the variant of include() that takes an optional
1646         namespace to read the variables into, or the fromfile() function,
1647         but both of these add an overhead of about 40% on the total qmake
1648         runtime, due to making a deep copy of all the variables in the
1649         project or re-reading all the prf files from scratch.
1650
1651         Reviewed by Simon Hausmann.
1652         Reviewed by Ossy.
1653
1654         * qmake/mkspecs/features/default_post.prf:
1655         * qmake/mkspecs/modules/javascriptcore.prf: Added.
1656         * qmake/mkspecs/modules/webcore.prf: Added.
1657         * qmake/mkspecs/modules/webkit2.prf: Added.
1658         * qmake/mkspecs/modules/wtf.prf: Added.
1659
1660 2012-01-06  JungJik Lee  <jungjik.lee@samsung.com>
1661
1662         [EFL] Add pre-render handling code in EWebLauncher.
1663         https://bugs.webkit.org/show_bug.cgi?id=73430
1664
1665         Reviewed by Zoltan Herczeg.
1666
1667         Add pre-render handling code by pressing Insert key.
1668
1669         * EWebLauncher/main.c:
1670         (on_key_down):
1671
1672 2012-01-06  Csaba Osztrogonác  <ossy@webkit.org>
1673
1674         NRWT should use test_expectation.txt on wk2 platforms
1675         https://bugs.webkit.org/show_bug.cgi?id=75417
1676
1677         Reviewed by Dirk Pranke.
1678
1679         * Scripts/webkitpy/layout_tests/port/webkit.py:
1680         (path_to_test_expectations_file):
1681         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1682         (test_path_to_test_expectations_file):
1683
1684 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
1685
1686         Don't hardcode expected file URIs in as they depend on the platform
1687         https://bugs.webkit.org/show_bug.cgi?id=75666
1688
1689         Reviewed by Dirk Pranke.
1690
1691         * Scripts/webkitpy/layout_tests/port/win.py:
1692         (WinPort.show_results_html_file):
1693         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1694         (MainTest.test_unexpected_failures):
1695         (MainTest.test_results_directory_default):
1696         (MainTest.test_results_directory_relative):
1697
1698 2012-01-05  Anders Carlsson  <andersca@apple.com>
1699
1700         Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
1701         https://bugs.webkit.org/show_bug.cgi?id=75667
1702         <rdar://problem/10389454>
1703
1704         Reviewed by Kevin Decker.
1705
1706         Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
1707
1708         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1709         (PluginTest::executeScript):
1710         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1711         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
1712         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
1713         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
1714         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
1715
1716 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
1717
1718         webkitpy: clean up port factory methods
1719         https://bugs.webkit.org/show_bug.cgi?id=75590
1720
1721         Reviewed by Eric Seidel.
1722
1723         This change consolidates much of the "factory method" logic
1724         of determining which port objects to create for a given set
1725         of configurations by merging the separate factory methods in
1726         chromium_gpu and google_chrome into PortFactory so that at least
1727         all of the logic is in one place.
1728
1729         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1730         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1731         * Scripts/webkitpy/layout_tests/port/factory.py:
1732         (_port_name_from_arguments_and_options):
1733         (get):
1734         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1735         (test_google_chrome):
1736         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1737         (GoogleChromeLinux32Port):
1738         (GoogleChromeLinux32Port.baseline_search_path):
1739         (test_expectations_overrides):
1740         (architecture):
1741         (GoogleChromeLinux64Port):
1742         (GoogleChromeLinux64Port.baseline_search_path):
1743         (GoogleChromeMacPort):
1744         (GoogleChromeMacPort.baseline_search_path):
1745         (GoogleChromeWinPort):
1746         (GoogleChromeWinPort.baseline_search_path):
1747         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1748         (_verify_baseline_path):
1749
1750 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
1751
1752         Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
1753         https://bugs.webkit.org/show_bug.cgi?id=75617
1754
1755         Reviewed by Dirk Pranke.
1756
1757         * Scripts/webkitpy/common/system/filesystem.py:
1758         (FileSystem.exists):
1759         * Scripts/webkitpy/common/system/filesystem_mock.py:
1760         (MockFileSystem.exists):
1761         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1762         (GenericFileSystemTests.teardown_generic_test_dir):
1763         * Scripts/webkitpy/layout_tests/port/base.py:
1764         (Port.to.show_results_html_file):
1765         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1766         (MainTest.test_results_directory_absolute):
1767
1768 2012-01-05  Adam Roben  <aroben@apple.com>
1769
1770         Remove some unnecessary code from old-run-webkit-tests
1771
1772         Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
1773         WebKitTestRunner.
1774
1775         Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
1776         Windows
1777
1778         Reviewed by Eric Seidel.
1779
1780         * Scripts/old-run-webkit-tests:
1781         (top level):
1782         (openDumpTool):
1783         Removed calls to setPathForRunningWebKitApp.
1784
1785 2012-01-05  Adam Roben  <aroben@apple.com>
1786
1787         Teach NRWT to use run-safari to open results.html on Apple's Windows port
1788
1789         NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
1790         better, since we always want to open results.html using the user's build of WebKit, not
1791         whatever their default browser is.
1792
1793         Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
1794         for Apple's Windows port
1795
1796         Reviewed by Eric Seidel.
1797
1798         * Scripts/webkitpy/layout_tests/port/win.py:
1799         (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
1800         an obsolete comment.
1801
1802         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1803         (WinPortTest.test_show_results_html_file): Updated expected results.
1804
1805 2012-01-05  Adam Roben  <aroben@apple.com>
1806
1807         Prepend Safari.exe's path to the command-line passed to CreateProcess
1808
1809         Safari expects the first argument in the command-line to be the path to Safari.exe itself.
1810         This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
1811         thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
1812         was not including the path to Safari.exe in the command-line, so Safari was ignoring the
1813         first argument that WebKitLauncherWin was trying to pass to it.
1814
1815         Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
1816
1817         Reviewed by Steve Falkenburg.
1818
1819         * WebKitLauncherWin/WebKitLauncherWin.cpp:
1820         (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
1821         path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
1822
1823 2012-01-05  Adam Roben  <aroben@apple.com>
1824
1825         Stop using explicit memory management in WebKitLauncherWin
1826
1827         We now use stack-allocated STL objects instead.
1828
1829         Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
1830         Safari
1831
1832         Reviewed by Steve Falkenburg.
1833
1834         * WebKitLauncherWin/WebKitLauncherWin.cpp:
1835         (getStringValue):
1836         (applePathFromRegistry):
1837         (safariInstallDir):
1838         (safariBrowserExe):
1839         (_tWinMain):
1840         Changed to use stack-allocated STL objects instead of malloc/free.
1841
1842 2012-01-05  Adam Roben  <aroben@apple.com>
1843
1844         Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
1845
1846         This allows us to add the Safari and Apple Application Support directories to PATH before
1847         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
1848
1849         Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
1850         Windows port of DumpRenderTree/WebKitTestRunner
1851
1852         Reviewed by Steve Falkenburg.
1853
1854         * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
1855         ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
1856
1857         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1858         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1859         Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
1860
1861         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
1862         Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
1863         the stub launcher.
1864
1865         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
1866         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
1867         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
1868         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
1869         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
1870         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
1871         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
1872
1873         * WebKitTestRunner/win/main.cpp:
1874         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
1875
1876 2012-01-05  Adam Roben  <aroben@apple.com>
1877
1878         Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
1879
1880         This allows us to add the Safari and Apple Application Support directories to PATH before
1881         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
1882
1883         Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
1884         Windows port of DumpRenderTree/WebKitTestRunner
1885
1886         Reviewed by Steve Falkenburg.
1887
1888         * DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,
1889         which I forgot to add to this .sln when that project was created.
1890
1891         * DumpRenderTree/win/DumpRenderTree.cpp:
1892         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
1893
1894         * DumpRenderTree/win/DumpRenderTree.vcproj:
1895         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1896         Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.
1897
1898         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
1899         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
1900         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
1901         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
1902         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
1903         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
1904         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
1905         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
1906
1907         * win/DLLLauncher/DLLLauncherMain.cpp:
1908         (modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
1909         Safari's directory to PATH so that SafariTheme.dll can be found.
1910
1911         (main):
1912         (wWinMain):
1913         Changed to use the new modifyPath function.
1914
1915 2012-01-05  Alexander Færøy  <alexander.faeroy@nokia.com>
1916
1917         [Qt] Never enable FontConfig on Mac OS X
1918         https://bugs.webkit.org/show_bug.cgi?id=75616
1919
1920         Reviewed by Tor Arne Vestbø.
1921
1922         * qmake/mkspecs/features/features.prf:
1923
1924 2012-01-05  Alpha Lam  <hclam@chromium.org>
1925
1926         Unreviewed, rolling out r104159.
1927         http://trac.webkit.org/changeset/104159
1928         https://bugs.webkit.org/show_bug.cgi?id=75590
1929
1930         Chromium port GPU tests cannot be executed.
1931
1932         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1933         (get):
1934         (_default_tests_paths):
1935         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1936         (ChromiumGpuTest.assert_port_works):
1937         * Scripts/webkitpy/layout_tests/port/factory.py:
1938         (PortFactory._port_name_from_arguments_and_options):
1939         (PortFactory):
1940         (PortFactory._get_kwargs):
1941         (PortFactory.get):
1942         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1943         (FactoryTest.test_google_chrome.names):
1944         (FactoryTest.test_google_chrome):
1945         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1946         (GetGoogleChromePort):
1947         (GetGoogleChromePort.GoogleChromeLinux32Port):
1948         (GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
1949         (GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
1950         (GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
1951         (GetGoogleChromePort.GoogleChromeLinux64Port):
1952         (GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
1953         (GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
1954         (GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
1955         (GetGoogleChromePort.GoogleChromeMacPort):
1956         (GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
1957         (GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
1958         (GetGoogleChromePort.GoogleChromeWinPort):
1959         (GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
1960         (GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):
1961         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1962         (GetGoogleChromePortTest._verify_baseline_path):
1963         (GetGoogleChromePortTest._verify_expectations_overrides):
1964
1965 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
1966
1967         webkitpy: clean up port factory methods
1968         https://bugs.webkit.org/show_bug.cgi?id=75590
1969
1970         Reviewed by Eric Seidel.
1971
1972         This change consolidates much of the "factory method" logic
1973         of determining which port objects to create for a given set
1974         of configurations by merging the separate factory methods in
1975         chromium_gpu and google_chrome into PortFactory so that at least
1976         all of the logic is in one place.
1977
1978         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1979         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1980         * Scripts/webkitpy/layout_tests/port/factory.py:
1981         (_port_name_from_arguments_and_options):
1982         (get):
1983         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1984         (test_google_chrome):
1985         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1986         (GoogleChromeLinux32Port):
1987         (GoogleChromeLinux32Port.baseline_search_path):
1988         (test_expectations_overrides):
1989         (architecture):
1990         (GoogleChromeLinux64Port):
1991         (GoogleChromeLinux64Port.baseline_search_path):
1992         (GoogleChromeMacPort):
1993         (GoogleChromeMacPort.baseline_search_path):
1994         (GoogleChromeWinPort):
1995         (GoogleChromeWinPort.baseline_search_path):
1996         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1997         (_verify_baseline_path):
1998
1999 2012-01-04  Adam Roben  <aroben@apple.com>
2000
2001         Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code
2002
2003         This allows us to add the Apple Application Support directory to PATH before trying to load
2004         WebKit so that CoreGraphics.dll and friends can be found.
2005
2006         Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
2007
2008         Reviewed by Anders Carlsson.
2009
2010         * DumpRenderTree/win/ImageDiff.vcproj:
2011         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2012         Changed to build ImageDiff.dll instead of ImageDiff.exe.
2013
2014         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from
2015         Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.
2016
2017         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
2018         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
2019         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
2020         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
2021         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
2022         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
2023         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
2024
2025         * DumpRenderTree/win/ImageDiffWin.cpp: Added.
2026         (dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
2027         to main.
2028
2029         * win/DLLLauncher/DLLLauncherMain.cpp:
2030         (main):
2031         (wWinMain):
2032         Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
2033         stub launcher acts as a console program and calls a console version of
2034         dllLauncherEntryPoint.
2035
2036 2012-01-04  Adam Roben  <aroben@apple.com>
2037
2038         Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code
2039
2040         This allows us to add the Apple Application Support directory to PATH before trying to load
2041         WebKit so that CoreGraphics.dll and friends can be found.
2042
2043         Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
2044         double-clicked
2045
2046         Reviewed by Anders Carlsson.
2047
2048         * MiniBrowser/MiniBrowser.vcproj:
2049         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2050         Changed to build MiniBrowser.dll instead of MiniBrowser.exe.
2051
2052         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
2053         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
2054         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
2055         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
2056         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
2057         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
2058         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
2059
2060         * MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj
2061         but changed to build the stub launcher.
2062
2063         * MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since
2064         it needs to be compiled into the .exe instead of the .dll.
2065         (DllMain): Added. We use this to store the DLL's HINSTANCE.
2066         (dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
2067         DLLLauncherMain code.
2068
2069         * win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser
2070         to here.
2071
2072 2012-01-04  Adam Roben  <aroben@apple.com>
2073
2074         Make WinLauncher's window frame respond to clicks/drags again
2075
2076         Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
2077         bar when Aero is disabled
2078
2079         Reviewed by Brent Fulgham.
2080
2081         * WinLauncher/WinLauncher.cpp:
2082         (WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
2083         Also removed an unnecessary "break" keyword.
2084
2085 2012-01-04  Adam Roben  <aroben@apple.com>
2086
2087         Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code
2088
2089         This allows us to add the Apple Application Support directory to PATH before trying to load
2090         WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
2091         should use this mechanism.
2092
2093         Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
2094         double-clicked
2095
2096         Reviewed by Anders Carlsson.
2097
2098         * WinLauncher/WinLauncher.cpp: Removed InitInstance.
2099         (DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
2100         done by the now-removed InitInstance function.
2101         (dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
2102         calls. Merged code from InitInstance into this function, and change to use the global hInst
2103         variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
2104         function, which corresponds to WinLauncher.exe.
2105
2106         * WinLauncher/WinLauncher.vcproj:
2107         * WinLauncher/WinLauncherCommon.vsprops:
2108         Changed to build WinLauncher.dll instead of WinLauncher.exe.
2109
2110         * WinLauncher/WinLauncherLauncher.rc: Added.
2111         * WinLauncher/WinLauncherLauncherResource.h: Added.
2112         This just references the WinLauncher.ico file to set the application icon (though it looks
2113         like that's a default icon).
2114
2115         * WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj
2116         but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.
2117
2118         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
2119         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
2120         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
2121         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
2122         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
2123         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
2124         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
2125
2126         * win/DLLLauncher/DLLLauncherMain.cpp: Added.
2127         (enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
2128         program if it detects heap corruption.
2129         (getStringValue): Helper function to read a string value from the registry.
2130         (applePathFromRegistry): Helper function to read the InstallDir for a given Apple
2131         application from the registry.
2132         (appleApplicationSupportDirectory): Helper function to return the path to the Apple
2133         Application Support directory.
2134         (copyEnvironmentVariable): Helper function to copy an environment variable's value.
2135         (prependPath): Helper function to prepend a directory to the PATH.
2136         (fatalError): Helper function to display an error to the user.
2137         (wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
2138         dllLauncherEntryPoint function.
2139
2140 2012-01-05  Kentaro Hara  <haraken@chromium.org>
2141
2142         prepare-ChangeLog cannot parse python code that nests classes and defs
2143         https://bugs.webkit.org/show_bug.cgi?id=75524
2144
2145         Reviewed by Ryosuke Niwa.
2146
2147         This patch fixes the python parser of prepare-ChangeLog so that it can parse
2148         python code that nests classes and defs, like this:
2149
2150         class C:
2151             pass
2152             def f():
2153                 pass
2154             pass
2155
2156         Also, this patch fixes the python parser so that it inserts a dummy line
2157         at the end of the file to pop out all popped scopes.
2158
2159         * Scripts/prepare-ChangeLog:
2160         (get_function_line_ranges_for_python):
2161
2162         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
2163         Added test cases that nest classes and defs.
2164         (func7):
2165         (func7.func8):
2166         (func7.func8.func9):
2167         (Class2):
2168         (Class2.Class3):
2169         (Class2.Class3.Class4):
2170         (Class5):
2171         (Class5.func10):
2172         (Class5.func11):
2173         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
2174
2175 2012-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2176
2177         [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
2178         https://bugs.webkit.org/show_bug.cgi?id=75433
2179
2180         Reviewed by Martin Robinson.
2181
2182         * MiniBrowser/gtk/BrowserWindow.c:
2183         (webViewLoadFailed): Reset the progress bar when load fails.
2184         (browserWindowConstructed): Connect to load-failed signal.
2185
2186 2012-01-04  Dan Bernstein  <mitz@apple.com>
2187
2188         Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
2189         start WebProcess under gdb and WebProcess will then run the client executable.
2190
2191         This is the Tools part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach
2192
2193         Reviewed by Anders Carlsson.
2194
2195         * Scripts/webkitdirs.pm:
2196         (shouldTargetWebProcess): Added.
2197         (determineShouldTargetWebProcess): Added. Checks for --target-web-process.
2198         (execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
2199         app using the -client-executable option if targeting the web process.
2200
2201 2012-01-04  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2202
2203         Adding myself to committers list.
2204
2205         Unreviewed.
2206
2207         * Scripts/webkitpy/common/config/committers.py:
2208
2209 2012-01-04  David Kilzer  <ddkilzer@apple.com>
2210
2211         Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests
2212
2213         This reverts commit r103546.
2214
2215         * TestWebKitAPI/TestsController.cpp:
2216         (TestWebKitAPI::TestsController::TestsController):
2217
2218 2012-01-04  James Robinson  <jamesr@chromium.org>
2219
2220         [chromium] Move WebMimeRegistry and dependencies to Source/Platform
2221         https://bugs.webkit.org/show_bug.cgi?id=74583
2222
2223         Reviewed by Darin Fisher.
2224
2225         Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.
2226
2227         * Scripts/webkitpy/style/checkers/cpp.py:
2228         (check_function_definition):
2229
2230 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2231
2232         [Qt] Fix link order of static libraries and unbreak QtWin32
2233
2234         We were keeping the correct static link order between the intermediate
2235         WebKit libraries, but not the internal dependencies for each of those
2236         libraries. The load() will in some instances mess with LIBS, so we need
2237         to ensure that the dependent libraries are added after the library we
2238         are linking against.
2239
2240         Reviewed by Simon Hausmann.
2241
2242         * qmake/mkspecs/features/default_post.prf:
2243
2244 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2245
2246         [Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
2247
2248         The custom qmake variable 'WEBKIT' is used for signaling that a
2249         target depends in some way on other subproject of the WebKit
2250         project. For now this is limited to the set of intermediate
2251         libraries: wtf, javascriptcore, webcore, and webkit2.
2252
2253         This replaces the previous convension of using load(foo) for
2254         just include paths, and CONFIG += foo to also link against foo.
2255
2256         Adding a dependency results in additional include paths being
2257         available, and potentially linking to the library. This is
2258         decided by the build system based on conditions such as what
2259         kind of target is being built and the general build config.
2260
2261         An advantage to his approach is that it simplifies the individual
2262         foo.prf files, for example by allowing us to use INCLUDEPATH +=
2263         and LIBS += as normal instead of prepending.
2264
2265         Reviewed by Simon Hausmann.
2266
2267         * DumpRenderTree/qt/DumpRenderTree.pro:
2268         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2269         * QtTestBrowser/QtTestBrowser.pro:
2270         * WebKitTestRunner/InjectedBundle/Target.pri:
2271         * WebKitTestRunner/Target.pri:
2272         * qmake/README:
2273         * qmake/mkspecs/features/default_post.prf:
2274         * qmake/mkspecs/features/functions.prf:
2275         * qmake/mkspecs/features/javascriptcore.prf:
2276         * qmake/mkspecs/features/qtwebkit.prf:
2277         * qmake/mkspecs/features/webcore.prf:
2278         * qmake/mkspecs/features/webkit2.prf:
2279         * qmake/mkspecs/features/wtf.prf:
2280
2281 2012-01-04  Alexander Færøy  <ahf@0x90.dk>
2282
2283         [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
2284         https://bugs.webkit.org/show_bug.cgi?id=75488
2285
2286         Reviewed by Tor Arne Vestbø.
2287
2288         * MiniBrowser/qt/MiniBrowser.qrc:
2289         * MiniBrowser/qt/qml/BrowserWindow.qml:
2290         * MiniBrowser/qt/qml/Dialog.qml:
2291         * MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
2292         * MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
2293
2294 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2295
2296         [Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit
2297
2298         It wasn't really a problem at runtime since the right QtWebKit was
2299         already loaded as a dependency of the web process, but the ldd output
2300         would still be busted.
2301
2302         Reviewed by Simon Hausmann.
2303
2304         * WebKitTestRunner/InjectedBundle/Target.pri:
2305
2306 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2307
2308         [Qt] Move use of $$qtLibraryTarget() to a single place
2309
2310         Reviewed by Kenneth Rohde Christiansen.
2311
2312         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2313         * WebKitTestRunner/InjectedBundle/Target.pri:
2314         * qmake/mkspecs/features/default_post.prf:
2315         * qmake/mkspecs/features/webcore.prf:
2316
2317 2012-01-04  Mary Wu  <mary.wu@torchmobile.com.cn>
2318
2319         Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
2320         https://bugs.webkit.org/show_bug.cgi?id=75238
2321
2322         Reviewed by Antonio Gomes.
2323
2324         Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that 
2325         it could initiate download directly if it has the download attribute in the link 
2326         and doesn't need to open new blank page for the target="_blank". Enabling this 
2327         feature in the BlackBerry porting also prepares for later blob feature implementation.
2328
2329         * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
2330         for the BlackBerry porting.
2331
2332 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2333
2334         [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
2335         https://bugs.webkit.org/show_bug.cgi?id=75475
2336
2337         Reviewed by Martin Robinson.
2338
2339         The problem is that the property blurb contains <a ping> and tree
2340         view uses gtk_tooltip_set_markup() internally, so we need to
2341         escape the text.
2342
2343         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2344         (browserSettingsDialogConstructed): Escape property blurb before
2345         storing it in the GtkTreeModel.
2346
2347 2012-01-03  Jochen Eisinger  <jochen@chromium.org>
2348
2349         When showing results.html pass a correct URL to webbrowser.open
2350         https://bugs.webkit.org/show_bug.cgi?id=75438
2351
2352         Reviewed by Adam Barth.
2353
2354         * Scripts/webkitpy/common/system/filesystem.py:
2355         (file_path_as_url):
2356         * Scripts/webkitpy/common/system/filesystem_mock.py:
2357         (file_path_as_url):
2358         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2359         (test_file_path_as_url):
2360         * Scripts/webkitpy/layout_tests/port/base.py:
2361         (show_results_html_file):
2362         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2363         (test_show_results_html_file):
2364         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2365         (test_results_directory_relative):
2366
2367 2012-01-03  Ojan Vafai  <ojan@chromium.org>
2368
2369         shrink the header on the flakiness dashboard
2370         https://bugs.webkit.org/show_bug.cgi?id=65153
2371
2372         Reviewed by Adam Roben.
2373
2374         Move some of the "show" links to be to the right of the header
2375         instead of below the header when they content they're showing
2376         is hidden. That way we don't waste vertical space on them.
2377
2378         No new tests. This code is covered by existing tests.
2379
2380         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2381
2382 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
2383
2384         Add a tool to analyze change logs
2385         https://bugs.webkit.org/show_bug.cgi?id=72243
2386
2387         Reviewed by Eric Seidel.
2388
2389         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
2390         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
2391         for visualizing json files.
2392
2393         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
2394         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
2395         generates json files, and N is the number of changelogs to parse.
2396
2397         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
2398         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
2399         * Scripts/webkitpy/tool/commands/__init__.py:
2400         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
2401         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
2402         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
2403         * Scripts/webkitpy/tool/steps/options.py:
2404
2405 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
2406
2407         Add a tool to analyze change logs
2408         https://bugs.webkit.org/show_bug.cgi?id=72243
2409
2410         Reviewed by Eric Seidel.
2411
2412         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
2413         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
2414         for visualizing json files.
2415
2416         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
2417         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
2418         generates json files, and N is the number of changelogs to parse.
2419
2420         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
2421         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
2422         * Scripts/webkitpy/tool/commands/__init__.py:
2423         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
2424         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
2425         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
2426         * Scripts/webkitpy/tool/steps/options.py:
2427
2428 2012-01-03  Adam Roben  <aroben@apple.com>
2429
2430         Make Port subclasses override the operating_system method rather than setting an attribute
2431
2432         Without this patch, any use of Port.operating_system() within a port's __init__ method would
2433         return the default value ("mac"). This was confusing the version-checking logic inside
2434         ApplePort.__init__ on Windows.
2435
2436         Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
2437         crashes on launch on Windows 7 SP1
2438
2439         Reviewed by Eric Seidel.
2440
2441         * Scripts/webkitpy/layout_tests/port/apple.py:
2442         (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
2443
2444         * Scripts/webkitpy/layout_tests/port/base.py:
2445         (Port.__init__): Removed code that set the self._operating_system attribute. Subclasses
2446         should now override the operating_system method instead.
2447         (Port.operating_system): Changed to always return "mac". Subclasses should override to
2448         return something else.
2449
2450         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2451         (ChromiumLinuxPort.__init__):
2452         (ChromiumLinuxPort.operating_system):
2453         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2454         (ChromiumMacPort.__init__):
2455         (ChromiumMacPort.operating_system):
2456         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2457         (ChromiumWinPort.__init__):
2458         (ChromiumWinPort.operating_system):
2459         * Scripts/webkitpy/layout_tests/port/mac.py:
2460         (MacPort.__init__):
2461         (MacPort.operating_system):
2462         * Scripts/webkitpy/layout_tests/port/win.py:
2463         (WinPort.__init__):
2464         (WinPort.operating_system):
2465         Changed to override the operating_system method rather than setting the _operating_system
2466         attribute, since setting the attribute isn't sufficient for code inside __init__ methods.
2467
2468         * Scripts/webkitpy/layout_tests/port/qt.py:
2469         (QtPort.__init__):
2470         (QtPort._path_to_webcore_library):
2471         Changed to use self.operating_system() instead of self._operating_system, for consistency
2472         with other Port-related code.
2473
2474         (QtPort.operating_system): Added this override of Port.operating_system that returns the
2475         value we determined in our __init__ method.
2476
2477         * Scripts/webkitpy/layout_tests/port/test.py:
2478         (TestPort.operating_system): Added this override of Port.operating_system that returns the
2479         value we determined in our __init__ method.
2480
2481         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2482         (PortTest.test_operating_system):
2483         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2484         (ChromiumLinuxPortTest.test_operating_system):
2485         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2486         (ChromiumMacPortTest.test_operating_system):
2487         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2488         (ChromiumWinPortTest.test_operating_system):
2489         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2490         (MacPortTest.test_operating_system):
2491         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2492         (QtPortTest.test_operating_system):
2493         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2494         (WinPortTest.test_operating_system):
2495         Test that all ports return the expected operating system string.
2496
2497 2012-01-03  Mario Sanchez Prada  <msanchez@igalia.com>
2498
2499         [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix
2500         https://bugs.webkit.org/show_bug.cgi?id=75474
2501
2502         Reviewed by Philippe Normand.
2503
2504         * Scripts/run-gtk-tests: Ignore files whose name does not start
2505         with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).
2506
2507 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
2508
2509         [Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser
2510         https://bugs.webkit.org/show_bug.cgi?id=75472
2511
2512         Reviewed by Tor Arne Vestbø.
2513
2514         * MiniBrowser/qt/MiniBrowser.pro:
2515         * MiniBrowser/qt/MiniBrowser.qrc:
2516         * MiniBrowser/qt/qml/BrowserWindow.qml:
2517         * MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
2518
2519 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
2520
2521         [Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser
2522         https://bugs.webkit.org/show_bug.cgi?id=75471
2523
2524         Reviewed by Tor Arne Vestbø.
2525
2526         Add simple UI for JavaScript Alert dialogs. This patch also adds a
2527         simple DialogButton QML type and a Dialog QML type which will be
2528         reusable for other JavaScript dialogs.
2529
2530         * MiniBrowser/qt/MiniBrowser.qrc:
2531         * MiniBrowser/qt/qml/AlertDialog.qml: Added.
2532         * MiniBrowser/qt/qml/BrowserWindow.qml:
2533         * MiniBrowser/qt/qml/Dialog.qml: Added.
2534         * MiniBrowser/qt/qml/DialogButton.qml: Added.
2535
2536 2012-01-03  Rafael Brandao  <rafael.lobo@openbossa.org>
2537
2538         [Qt][WK2] MiniBrowser doesn't show url bar
2539         https://bugs.webkit.org/show_bug.cgi?id=75470
2540
2541         Reviewed by Tor Arne Vestbø.
2542
2543         * MiniBrowser/qt/qml/BrowserWindow.qml: Remove clipping until it is fixed
2544         on QtDeclarative (QTBUG-23422).
2545
2546 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2547
2548         [GTK] Simplify loader client WebKit2 GTK+ API
2549         https://bugs.webkit.org/show_bug.cgi?id=74605
2550
2551         Reviewed by Gustavo Noronha Silva.
2552
2553         * gtk/generate-gtkdoc: Ignore WebKitWebLoaderClient since it's now
2554         private API.
2555
2556 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2557
2558         [Qt] Clean up detection of fontconfig
2559
2560         We decide in features.prf whether or not fontconfig is available, and
2561         set the HAVE_FONTCONFIG define accordingly. All leaf project files
2562         should use this define to decide whether or not to link against
2563         fontconfig, not do their own detection.
2564
2565         We don't need to add link_pkgconfig to CONFIG in each project file,
2566         as we selectivly enable that configuration in defaults_post when
2567         needed.
2568
2569         Reviewed by Ossy.
2570
2571         * DumpRenderTree/qt/DumpRenderTree.pro:
2572         * QtTestBrowser/QtTestBrowser.pro:
2573         * WebKitTestRunner/InjectedBundle/Target.pri:
2574         * qmake/mkspecs/features/unix/default_post.prf:
2575         * qmake/mkspecs/features/unix/default_pre.prf:
2576
2577 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2578
2579         [Qt] Introduce qmake replace function for the active build config
2580
2581         Reviewed by Ossy.
2582
2583         * qmake/mkspecs/features/default_post.prf:
2584         * qmake/mkspecs/features/functions.prf:
2585
2586 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2587
2588         [GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect()
2589         https://bugs.webkit.org/show_bug.cgi?id=75435
2590
2591         Reviewed by Martin Robinson.
2592
2593         * GNUmakefile.am: Make sure DRT links to X11.
2594         * WebKitTestRunner/GNUmakefile.am: Make sure WTR links to X11.
2595
2596 2011-12-04  Philippe Normand  <pnormand@igalia.com>
2597
2598         [WK2][GTK] WebSettings support in MiniBrowser
2599         https://bugs.webkit.org/show_bug.cgi?id=73773
2600
2601         Reviewed by Martin Robinson.
2602
2603         Patch heavily inspired from the WebKit GtkLauncher to support
2604         command-line WebSettings. Example: --enable-fullscreen=TRUE.
2605         The full list of options can be consulted with --help-websettings.
2606
2607         * MiniBrowser/gtk/main.c:
2608         (loadURI):
2609         (parseOptionEntryCallback):
2610         (isValidParameterType):
2611         (getOptionEntriesFromWebKitSettings):
2612         (addSettingsGroupToContext):
2613         (main):
2614
2615 2012-01-02  Philippe Normand  <pnormand@igalia.com>
2616
2617         [GTK] GtkLauncher settings improvements
2618         https://bugs.webkit.org/show_bug.cgi?id=75439
2619
2620         Reviewed by Martin Robinson.
2621
2622         * GtkLauncher/main.c:
2623         (filenameToURL): We can use NULL in C.
2624         (isValidParameterType): Utility function to filter GParamTypes
2625         that can be edited.
2626         (getOptionEntriesFromWebKitWebSettings): Avoid handling
2627         construct-only properties and use the isValidParameterType
2628         function. Makes the code a bit cleaner.
2629
2630 2012-01-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2631
2632         [EFL] Remove whitespace/declaration style exception
2633         https://bugs.webkit.org/show_bug.cgi?id=75424
2634
2635         Reviewed by David Levin.
2636
2637         Remove *whitespace/eclaration* style rule. However, EWebLauncher and MiniBrowser are EFL simple
2638         application. So, they still need to use EFL coding style.
2639
2640         * Scripts/webkitpy/style/checker.py:
2641
2642 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2643
2644         [GTK] Add a way to change web view settings in MiniBrowser
2645         https://bugs.webkit.org/show_bug.cgi?id=71568
2646
2647         Reviewed by Philippe Normand.
2648
2649         Add a preferences button to the toolbar that shows a dialog to
2650         change settings of the current web view. It uses a GtkTreeView
2651         with a custom cell renderer to support multiple types of values.
2652
2653         * MiniBrowser/gtk/BrowserCellRendererVariant.c: Added.
2654         (browserCellRendererVariantFinalize):
2655         (browserCellRendererVariantGetProperty):
2656         (browserCellRendererVariantSetModeForValue):
2657         (browserCellRendererVariantSetProperty):
2658         (browserCellRendererVariantGetRendererForValue):
2659         (browserCellRendererVariantCellRendererTextEdited):
2660         (browserCellRendererVariantCellRendererSpinEdited):
2661         (browserCellRendererVariantCellRendererActivate):
2662         (browserCellRendererVariantCellRendererRender):
2663         (browserCellRendererVariantCellRendererStartEditing):
2664         (browserCellRendererVariantCellRendererGetPreferredWidth):
2665         (browserCellRendererVariantCellRendererGetPreferredHeight):
2666         (browserCellRendererVariantCellRendererGetPreferredWidthForHeight):
2667         (browserCellRendererVariantCellRendererGetPreferredHeightForWidth):
2668         (browserCellRendererVariantCellRendererGetAlignedArea):
2669         (browser_cell_renderer_variant_init):
2670         (browser_cell_renderer_variant_class_init):
2671         (browser_cell_renderer_variant_new):
2672         * MiniBrowser/gtk/BrowserCellRendererVariant.h: Added.
2673         * MiniBrowser/gtk/BrowserSettingsDialog.c: Added.
2674         (cellRendererChanged):
2675         (browserSettingsDialogSetProperty):
2676         (browser_settings_dialog_init):
2677         (browserSettingsDialogConstructed):
2678         (browser_settings_dialog_class_init):
2679         (browser_settings_dialog_new):
2680         * MiniBrowser/gtk/BrowserSettingsDialog.h: Added.
2681         * MiniBrowser/gtk/BrowserWindow.c:
2682         (settingsCallback):
2683         (browser_window_init):
2684         * MiniBrowser/gtk/GNUmakefile.am:
2685         * MiniBrowser/gtk/browser-marshal.list: Added.
2686
2687 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2688
2689         [GTK] Implement create/ready-to-show/close signals in MiniBrowser
2690         https://bugs.webkit.org/show_bug.cgi?id=74711
2691
2692         Reviewed by Philippe Normand.
2693
2694         * MiniBrowser/gtk/BrowserWindow.c:
2695         (webViewClose): Destroy the window.
2696         (webViewReadyToShow): Use WindowProperties of the new view to
2697         setup and show the window.
2698         (webViewCreate): Create a new view and add it to a browser window.
2699         (browser_window_init):
2700         (browserWindowConstructed): Connect to WebKitWebView::create signal.
2701
2702 2011-12-31  Dan Bernstein  <mitz@apple.com>
2703
2704         MiniBrowser sets the WKView’s frame incorrectly
2705         https://bugs.webkit.org/show_bug.cgi?id=75393
2706
2707         Reviewed by Anders Carlsson.
2708
2709         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed Make Launchable build phase,
2710         which is not needed since the binray is linked with the frameworks search path set to the
2711         built products directory.
2712         * MiniBrowser/mac/BrowserWindowController.m:
2713         (-[BrowserWindowController awakeFromNib]): Changed to set the WKView’s frame to its
2714         container’s bounds rather than its frame.
2715         * MiniBrowser/mac/make-launchable.sh: Removed.
2716
2717 2011-12-29  Dan Bernstein  <mitz@apple.com>
2718
2719         debug-safari --no-saved-state fails to start the debugger
2720         https://bugs.webkit.org/show_bug.cgi?id=75374
2721
2722         Reviewed by Sam Weinig.
2723
2724         * Scripts/webkitdirs.pm:
2725         (execMacWebKitAppForDebugging): Pass the --args option to gdb so that it passes arguments to
2726         the executable being debugged.
2727
2728 2011-12-29  Sam Weinig  <sam@webkit.org>
2729
2730         It should be easier to iterate a Vector backwards
2731         https://bugs.webkit.org/show_bug.cgi?id=75359
2732
2733         Reviewed by Anders Carlsson.
2734
2735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2736         * TestWebKitAPI/TestWebKitAPI.gypi:
2737         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2738         Add new Vector test.
2739
2740         * TestWebKitAPI/Tests/Vector.cpp: Added.
2741         (TestWebKitAPI::TEST):
2742         Test Vector iterators, reverse_iterators and new reversed proxy.
2743
2744 2011-12-28  Dmitry Lomov  <dslomov@google.com>
2745
2746         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
2747         https://bugs.webkit.org/show_bug.cgi?id=66509
2748         Just renames, merges and removal of dead code. Here are the list of renames:
2749           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
2750           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
2751           - WebWorkerBase merged into WebSharedWorkerImpl
2752           - NewWebWorkerBase renamed into WebWorkerBase
2753  
2754         Reviewed by David Levin.
2755
2756         * DumpRenderTree/chromium/TestWebWorker.h:
2757         (TestWebWorker::createWorker):
2758         * DumpRenderTree/chromium/WebViewHost.cpp:
2759         (WebViewHost::createWorker):
2760         * DumpRenderTree/chromium/WebViewHost.h:
2761
2762 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2763
2764         Unreviewed, rolling out r103785.
2765         http://trac.webkit.org/changeset/103785
2766         https://bugs.webkit.org/show_bug.cgi?id=75332
2767
2768         Broke builders; looks like clobbering didnt help (Requested by
2769         dslomov on #webkit).
2770
2771         * DumpRenderTree/chromium/TestWebWorker.h:
2772         (TestWebWorker::createWorker):
2773         * DumpRenderTree/chromium/WebViewHost.cpp:
2774         (WebViewHost::createWorker):
2775         * DumpRenderTree/chromium/WebViewHost.h:
2776
2777 2011-12-28  Dmitry Lomov  <dslomov@google.com>
2778
2779
2780         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
2781         https://bugs.webkit.org/show_bug.cgi?id=66509
2782         Just renames, merges and removal of dead code. Here are the list of renames:
2783           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
2784           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
2785           - WebWorkerBase merged into WebSharedWorkerImpl
2786           - NewWebWorkerBase renamed into WebWorkerBase
2787  
2788         Reviewed by David Levin.
2789
2790         * DumpRenderTree/chromium/TestWebWorker.h:
2791         (TestWebWorker::createWorker):
2792         * DumpRenderTree/chromium/WebViewHost.cpp:
2793         (WebViewHost::createWorker):
2794         * DumpRenderTree/chromium/WebViewHost.h:
2795
2796 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
2797
2798         Unreviewed, rolling out r103620.
2799         http://trac.webkit.org/changeset/103620
2800         https://bugs.webkit.org/show_bug.cgi?id=75316
2801
2802         Causes many crashes (Requested by abarth on #webkit).
2803
2804         * DumpRenderTree/chromium/LayoutTestController.cpp:
2805         (LayoutTestController::LayoutTestController):
2806         (LayoutTestController::reset):
2807         * DumpRenderTree/chromium/LayoutTestController.h:
2808         * DumpRenderTree/chromium/WebViewHost.cpp:
2809         * DumpRenderTree/chromium/WebViewHost.h:
2810
2811 2011-12-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2812
2813         Unreviewed, rolling out r103734.
2814         http://trac.webkit.org/changeset/103734
2815         https://bugs.webkit.org/show_bug.cgi?id=75278
2816
2817         Broke cr-mac (Requested by dslomov on #webkit).
2818
2819         * DumpRenderTree/chromium/TestWebWorker.h:
2820         (TestWebWorker::createWorker):
2821         * DumpRenderTree/chromium/WebViewHost.cpp:
2822         (WebViewHost::createWorker):
2823         * DumpRenderTree/chromium/WebViewHost.h:
2824
2825 2011-12-27  Dmitry Lomov  <dslomov@google.com>
2826
2827
2828         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
2829         https://bugs.webkit.org/show_bug.cgi?id=66509
2830         Just renames, merges and removal of dead code. Here are the list of renames:
2831           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
2832           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
2833           - WebWorkerBase merged into WebSharedWorkerImpl
2834           - NewWebWorkerBase renamed into WebWorkerBase
2835  
2836         Reviewed by David Levin.
2837
2838         * DumpRenderTree/chromium/TestWebWorker.h:
2839         (TestWebWorker::createWorker):
2840         * DumpRenderTree/chromium/WebViewHost.cpp:
2841         (WebViewHost::createWorker):
2842         * DumpRenderTree/chromium/WebViewHost.h:
2843
2844 2011-12-27  Anders Carlsson  <andersca@apple.com>
2845
2846         Function should handle wrapping/unwrapping RefPtr and PassRefPtr
2847         https://bugs.webkit.org/show_bug.cgi?id=75266
2848
2849         Reviewed by Sam Weinig.
2850
2851         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2852         (TestWebKitAPI::Number::create):
2853         (TestWebKitAPI::Number::~Number):
2854         (TestWebKitAPI::Number::value):
2855         (TestWebKitAPI::Number::Number):
2856         (TestWebKitAPI::multiplyNumberByTwo):
2857         (TestWebKitAPI::TEST):
2858
2859 2011-12-24  Kentaro Hara  <haraken@chromium.org>
2860
2861         Add unittests for the C++ parser of prepare-ChangeLog
2862         https://bugs.webkit.org/show_bug.cgi?id=75191
2863
2864         Reviewed by Ryosuke Niwa.
2865
2866         cpp_unittests.cpp is the unittests for get_function_line_ranges_for_cpp()
2867         of prepare-ChangeLog.
2868
2869         * Scripts/prepare-ChangeLog:
2870         (get_function_line_ranges): Renames get_function_line_ranges_for_c()
2871         to get_function_line_ranges_for_cpp().
2872         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2873         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Added.
2874         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added.
2875         (func1):
2876         (func2):
2877         (func3):
2878         (func4):
2879         (func5):
2880         (func6):
2881         (func7):
2882         (func8):
2883         (func9):
2884         (func10):
2885         (func11):
2886         (func12):
2887         (func13):
2888         (func14):
2889         (func15):
2890         (funcOverloaded):
2891         (Class::func16):
2892         (Class1::Class2::func17):
2893         (Class2::func18):
2894         (Class2::func19):
2895         (Class2::func20):
2896         (Class2::func21):
2897         (Class2::func22):
2898         (func23):
2899         (func24):
2900         (Class2::func25):
2901         (Class1::func26):
2902         (Class2::func27):
2903         (Class3::func28):
2904         (Class7::operator+):
2905         (Class100::Class100):
2906         (Class101::~Class101):
2907         (Class102::Class102):
2908         (Class103::Class103):
2909         (Struct1::func29):
2910         (Struct2::func30):
2911         (NameSpace1::func30):
2912         (NameSpace1::NameSpace2::func31):
2913
2914 2011-12-24  Kentaro Hara  <haraken@chromium.org>
2915
2916         Add unittests for the Java parser of prepare-ChangeLog
2917         https://bugs.webkit.org/show_bug.cgi?id=75195
2918
2919         Reviewed by Ryosuke Niwa.
2920
2921         java_unittests.java is unittest cases for get_function_line_ranges_for_java()
2922         of prepare-ChangeLog.
2923
2924         * Scripts/prepare-ChangeLog:
2925         (get_function_line_ranges_for_java): Fixed a parser bug.
2926
2927             interface I
2928             {
2929                 void f()
2930                 {
2931                 }
2932             }
2933
2934         should be recognized as "I.f", and
2935
2936             class C interface I
2937             {
2938                 void f()
2939                 {
2940                 }
2941             }
2942
2943         should be recognized as "C.f".
2944         Without this patch, both are recognized as "I.f".
2945
2946         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2947         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Added.
2948         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests.java: Added.
2949         (Simple):
2950         (Simple.func1):
2951         (Simple.func2):
2952         (Simple.func3):
2953         (Simple.func4):
2954         (Simple.func5):
2955         (Simple.func6):
2956         (Simple.func7):
2957         (Simple.func8):
2958         (Simple.func9):
2959         (Simple.func10):
2960         (Simple.funcOverloaded):
2961         (Simple.func11):
2962         (Simple.func12):
2963         (Simple.func13):
2964         (Simple.func14):
2965         (Simple.func15):
2966         (Simple.func16):
2967         (Simple.func17):
2968         (Simple.func18):
2969         (Simple.func19):
2970         (Simple.func20):
2971         (Simple.func21):
2972         (Derived1):
2973         (Derived1.Derived1):
2974         (Derived1.func22):
2975         (Interface1):
2976         (Interface2):
2977         (Interface2.func23):
2978         (Derived2):
2979         (Derived2.Derived2):
2980         (Derived2.func23):
2981
2982 2011-12-24  Kentaro Hara  <haraken@chromium.org>
2983
2984         Add unittests for the Python parser of prepare-ChangeLog
2985         https://bugs.webkit.org/show_bug.cgi?id=75197
2986
2987         Reviewed by Ryosuke Niwa.
2988
2989         python_unittests.py is the unittest for get_function_line_ranges_for_python()
2990         of prepare-ChangeLog. The unittest just contains classes and defs that are not nested.
2991         This is because the current python parser is wrong, and it cannot correctly parse nested
2992         classes and defs (even one def in a class), nor class inheritance.
2993         We will fix it in another patch.
2994
2995         * Scripts/prepare-ChangeLog:
2996         (get_function_line_ranges_for_python): Ignores comment lines that starts from #.
2997         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2998         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Added.
2999         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py: Added.
3000         (func1):
3001         (func2):
3002         (func3):
3003         (funcInsideComment):
3004         (func4):
3005         (func5):
3006         (func6):
3007         (funcOverloaded):
3008         (Class1):
3009
3010 2011-12-24  Dan Bernstein  <mitz@apple.com>
3011
3012         Set SHARED_PRECOMPS_DIR when Xcode is set to use a custom build product path.
3013
3014         Reviewed by Anders Carlsson.
3015
3016         * Scripts/webkitdirs.pm:
3017         (determineBaseProductDir):
3018
3019 2011-12-24  Dan Bernstein  <mitz@apple.com>
3020
3021         Make build-webkit aware of additional Xcode build location defaults.
3022
3023         Reviewed by Anders Carlsson.
3024
3025         * Scripts/webkitdirs.pm:
3026         (determineXcodeVersion): Added. This was previously in determineBaseProductDir().
3027         (readXcodeUserDefault): Added. Factored out from determineBaseProductDir().
3028         (determineBaseProductDir): Changed to check for a custom build location
3029         style specified as an absolute location.
3030
3031 2011-12-24  Ryosuke Niwa  <rniwa@webkit.org>
3032
3033         Unreviewed, rolling out r103619.
3034         http://trac.webkit.org/changeset/103619
3035         https://bugs.webkit.org/show_bug.cgi?id=66509
3036
3037         Broke chromium clang build
3038
3039         * DumpRenderTree/chromium/TestWebWorker.h:
3040         (TestWebWorker::createWorker):
3041         * DumpRenderTree/chromium/WebViewHost.cpp:
3042         (WebViewHost::createWorker):
3043         * DumpRenderTree/chromium/WebViewHost.h:
3044
3045 2011-12-23  Daniel Bates  <dbates@webkit.org>
3046
3047         Provide option to disable Mac OS 10.7 application resume when using
3048         {debug, run}-{safari, minibrowser, test-runner, test-webkit-api}, and run-webkit-app
3049         https://bugs.webkit.org/show_bug.cgi?id=66902
3050
3051         Reviewed by David Kilzer.
3052
3053         Add an optional command line argument --no-saved-state to disable
3054         application resume (state restoration) for the session on Mac OS 10.7.
3055
3056         For instance, when debugging an issue in Safari it is useful to be able
3057         to temporarily disable application resume. Currently you can disable
3058         application resume when launching Safari from within Xcode. We should
3059         expose a similar option in our command line tools.
3060
3061         * Scripts/debug-minibrowser: Call printHelpAndExitForRunAndDebugWebKitAppIfNeeded()
3062         to print a help message and exit() if the command line argument --help was given.
3063         * Scripts/debug-safari: Ditto.
3064         * Scripts/debug-test-runner: Ditto.
3065         * Scripts/run-minibrowser: Ditto.
3066         * Scripts/run-safari: Ditto.
3067         * Scripts/run-test-runner: Ditto.
3068         * Scripts/run-test-webkit-api: Ditto.
3069         * Scripts/run-webkit-app: Ditto.
3070         * Scripts/webkitdirs.pm:
3071         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Added.
3072         (argumentsForRunAndDebugMacWebKitApp): Added.
3073         (runMacWebKitApp): If the --no-saved-state command line argument was given then
3074         disable application resume for the session.
3075         (execMacWebKitAppForDebugging): Ditto.
3076
3077 2011-12-23  Dmitry Lomov  <dslomov@google.com>
3078
3079         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
3080         https://bugs.webkit.org/show_bug.cgi?id=66509
3081         Just renames, merges and removal of dead code. Here are the list of renames:
3082           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
3083           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
3084           - WebWorkerBase merged into WebSharedWorkerImpl
3085           - NewWebWorkerBase renamed into WebWorkerBase
3086  
3087         Reviewed by David Levin.
3088
3089         * DumpRenderTree/chromium/TestWebWorker.h:
3090         (TestWebWorker::createWorker):
3091         * DumpRenderTree/chromium/WebViewHost.cpp:
3092         (WebViewHost::createWorker):
3093         * DumpRenderTree/chromium/WebViewHost.h:
3094
3095 2011-12-23  Kentaro Hara  <haraken@chromium.org>
3096
3097         Let parser_unittests.pl call different language parsers
3098         https://bugs.webkit.org/show_bug.cgi?id=75081
3099
3100         Reviewed by David Kilzer.
3101
3102         We introduced parser_unittests.pl in bug 74994 , but it is implemented
3103         to always call get_function_line_ranges_for_perl(). In order to enable unittests
3104         for other languages, this patch lets parser_unittests.pl call different language
3105         parsers depending on the languages.
3106
3107         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
3108
3109         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3110
3111 2011-12-22  Adam Roben  <aroben@apple.com>
3112
3113         Snow Leopard test fix
3114
3115         * Scripts/webkitpy/test/main.py:
3116         (Tester.run_tests): Python 2.6.1 doesn't seem to like specifying testRunner=None to
3117         unittest.main, even though that's the default. So now we explicitly specify a
3118         TextTestRunner.
3119
3120 2011-12-22  Chris Fleizach  <cfleizach@apple.com>
3121
3122         AX: attributed strings do not include AXHeading information when a link is contained within the heading
3123         https://bugs.webkit.org/show_bug.cgi?id=75059
3124
3125         Reviewed by Darin Adler.
3126
3127         Support the ability to check if an arbitrary attribute is present within an
3128         attributed string that can be retrieved through an AccessibilityTextMarkerRange.
3129
3130         * DumpRenderTree/AccessibilityUIElement.cpp:
3131         (attributedStringForTextMarkerRangeContainsAttributeCallback):
3132         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
3133         (AccessibilityUIElement::getJSClass):
3134         * DumpRenderTree/AccessibilityUIElement.h:
3135         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3136         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
3137         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3138         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
3139         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3140         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3141         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3142         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
3143
3144 2011-12-22  David Kilzer  <ddkilzer@apple.com>
3145
3146         run-api-tests: runAllTests() and runTest() should not use global variables
3147
3148         Reviewed by Adam Roben.
3149
3150         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3151
3152         * Scripts/run-api-tests:
3153         (runTestsBySuite): Rename from runAllTests().  Add arguments for
3154         list of tests and $verbose.
3155         (runTest): Add $verbose argument.
3156
3157 2011-12-22  David Kilzer  <ddkilzer@apple.com>
3158
3159         run-api-tests: inline runAllTestsInSuite() into runAllTests()
3160
3161         Reviewed by Adam Roben.
3162
3163         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3164
3165         In order to make it easy to run one or more individual suites,
3166         or one more individual tests, it's easier to call a single
3167         method with different data structures than individual methods.
3168
3169         * Scripts/run-api-tests:
3170         (runAllTests): Inline runAllTestsInSuite().
3171
3172 2011-12-22  Adam Roben  <aroben@apple.com>
3173
3174         Add a --xml flag to test-webkitpy
3175
3176         test-webkitpy --xml will, in addition to providing the standard text output on stdout, write
3177         JUnit-style XML files to a test-webkitpy-xml-reports subdirectory in the working directory.
3178         This is useful for working with tools that consume JUnit-style XML files.
3179
3180         Fixes <http://webkit.org/b/75090> Would like a way to generate JUnit-style XML files when
3181         running test-webkitpy
3182
3183         Reviewed by Darin Adler.
3184
3185         * Scripts/webkitpy/test/main.py:
3186         (Tester.run_tests): If the --xml flag is passed, create an XMLTestRunner and pass it to
3187         unittest.main(). Otherwise pass no test runner so that unittest will choose its own default.
3188
3189         * Scripts/webkitpy/thirdparty/__init__.py:
3190         (AutoinstallImportHook.find_module):
3191         (AutoinstallImportHook._install_xmlrunner):
3192         Added code to install unittest-xml-reporting as webkitpy.thirdparty.autoinstalled.xmlrunner.
3193         This change is untested because it's basically impossible to get a test to pass when --xml
3194         is passed to test-webkitpy (because xmlrunner will already have been imported by the time
3195         the test runs).
3196
3197 2011-12-22  David Kilzer  <ddkilzer@apple.com>
3198
3199         TestWebKitAPI: initialize the main thread before running tests
3200         <http://webkit.org/b/75064>
3201
3202         Reviewed by Adam Roben.
3203
3204         * TestWebKitAPI/TestsController.cpp:
3205         (TestWebKitAPI::TestsController::TestsController): Call
3206         WTF::initializeMainThread() to prevent assertions in Debug
3207         builds.
3208
3209 2011-12-22  David Kilzer  <ddkilzer@apple.com>
3210
3211         run-api-tests: dumpAllTests() should not use global variables
3212
3213         Reviewed by Adam Roben.
3214
3215         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3216
3217         * Scripts/run-api-tests: Renamed $dump to $dumpTests.
3218         (dumpTestsBySuite): Rename from dumpAllTests() and pass in
3219         global data as an argument.  Sort suite names and test names
3220         alphabetically to match output when running tests.
3221
3222 2011-12-22  Leo Yang  <leo.yang@torchmobile.com.cn>
3223
3224         [BlackBerry] Enable blob for the BlackBerry porting
3225         https://bugs.webkit.org/show_bug.cgi?id=75074
3226
3227         Reviewed by George Staikos.
3228
3229         * Scripts/build-webkit:
3230
3231 2011-12-22  Kentaro Hara  <haraken@chromium.org>
3232
3233         Add unittests for the Perl parser of prepare-ChangeLog
3234         https://bugs.webkit.org/show_bug.cgi?id=74994
3235
3236         Reviewed by David Kilzer.
3237
3238         This patch adds unittests for get_function_line_ranges_for_perl() of prepare-ChangeLog.
3239
3240         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
3241
3242         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
3243         Runs unittests specified in @testFiles.
3244         You can reset expected results by specifying a --reset-results option.
3245         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl: Added.
3246         Contains simple methods.
3247         (func1):
3248         (func2):
3249         (func3):
3250         (func4):
3251         (func5):
3252         (func6):
3253         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Added.
3254         This test result is generated by the --reset-results option.
3255
3256 2011-12-21  Eric Seidel  <eric@webkit.org>
3257
3258         Add webkit.review.bot@gmail.com and commit-queue@webkit.org as "contributors"
3259         so that they appear in the bugzilla autocomplete CC list.
3260         I also removed the "radar" irc nick (which I believe does not exist)
3261         and removed the uneeded [] around the radar bugzilla email.
3262
3263         Unreviewed.
3264
3265         * Scripts/webkitpy/common/config/committers.py:
3266
3267 2011-12-21  Daniel Bates  <dbates@rim.com>
3268
3269         Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
3270         https://bugs.webkit.org/show_bug.cgi?id=74985
3271
3272         Reviewed by Eric Seidel.
3273
3274         * Scripts/build-jsc:
3275         * Scripts/webkitdirs.pm:
3276         (cmakeBasedPortName): Added.
3277
3278 2011-12-21  Daniel Bates  <dbates@rim.com>
3279
3280         Extract BlackBerry CMake arguments from build-webkit into separate function
3281         https://bugs.webkit.org/show_bug.cgi?id=74981
3282
3283         Reviewed by Rob Buis.
3284
3285         Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
3286         the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
3287         and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
3288         This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
3289         that we can pass them to the CMake build system when building JavaScriptCore.
3290
3291         * Scripts/build-webkit: Move construction of CMake argument list from here to
3292         webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
3293         since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
3294         call it from build-webkit.
3295         * Scripts/webkitdirs.pm:
3296         (blackberryCMakeArguments): Added.
3297         (cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
3298         BlackBerry port.
3299
3300 2011-12-21  Daniel Bates  <dbates@webkit.org>
3301
3302         Extract WinCE CMake arguments from build-webkit into separate function
3303         https://bugs.webkit.org/show_bug.cgi?id=74983
3304
3305         Reviewed by Rob Buis.
3306
3307         Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
3308         WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
3309         This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
3310         that we can pass it to the CMake build system when building JavaScriptCore.
3311
3312         * Scripts/build-webkit:
3313         * Scripts/webkitdirs.pm:
3314         (cmakeBasedPortArguments): Added.
3315
3316 2011-12-21  Kentaro Hara  <haraken@chromium.org>
3317
3318         In prepare-ChangeLog, replace constant global variables with "use constant"
3319         https://bugs.webkit.org/show_bug.cgi?id=74992
3320
3321         Reviewed by Ryosuke Niwa.
3322
3323         This patch replaces the following constant global variables with "use constant"s.
3324             - $changeLogTimeZone
3325             - $SVN
3326             - $GIT
3327             - %supportedTestExtensions
3328
3329         * Scripts/prepare-ChangeLog:
3330         (changeLogNameFromArgs):
3331         (changeLogEmailAddressFromArgs):
3332         (resolveConflictedChangeLogs):
3333         (generateNewChangeLogs):
3334         (diffCommand):
3335         (statusCommand):
3336         (createPatchCommand):
3337         (findOriginalFileFromSvn):
3338         (determinePropertyChanges):
3339         (generateFileList):
3340         (reviewerAndDescriptionForGitCommit):
3341
3342 2011-12-20  Dirk Pranke  <dpranke@chromium.org>
3343
3344         nrwt: rename field references from _fs to _filesystem
3345         https://bugs.webkit.org/show_bug.cgi?id=74898
3346
3347         Reviewed by Adam Barth.
3348
3349         This is a simple cleanup; most of the code uses
3350         self._filesystem, but some used self._fs; this change renames
3351         the latter to the former to be more consistent.
3352
3353         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3354         (Manager.__init__):
3355         (Manager.collect_tests):
3356         (Manager._strip_test_dir_prefix):
3357         (Manager._split_into_chunks_if_necessary):
3358         (Manager.results_directory):
3359         (Manager._clobber_old_results):
3360         (Manager._upload_json_files):
3361         (Manager.print_config):
3362         (Manager._copy_results_html_file):
3363         (Manager._show_results_html_file):
3364         (Manager._log_worker_stack):
3365         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3366         (JSONLayoutResultsGenerator._normalize_results_json):
3367         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3368         (JSONResultsGeneratorBase.__init__):
3369         (JSONResultsGeneratorBase.generate_json_output):
3370         (JSONResultsGeneratorBase.generate_times_ms_file):
3371         (JSONResultsGeneratorBase.upload_json_files):
3372         (JSONResultsGeneratorBase._get_svn_revision):
3373         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3374         (Base.__init__):
3375
3376 2011-12-20  Kentaro Hara  <haraken@chromium.org>
3377
3378         Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
3379         https://bugs.webkit.org/show_bug.cgi?id=74836
3380
3381         Reviewed by David Kilzer.
3382
3383         webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
3384         This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
3385         for unit-testing of other Perl scripts. We are planning to use it for unit-testing
3386         of prepare-ChangeLog.
3387
3388         Using LoadAsModule.pm, you can load a Perl script as follows.
3389         The first argument is the arbitrary package name you want to use, and the second argument
3390         is the name of the Perl script you want to load.
3391
3392             use LoadAsModule qw(RunLeaks run-leaks);
3393             RunLeaks::someFunctionDefinedInRunLeaks(...);
3394
3395         Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
3396                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
3397                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl
3398
3399         * Scripts/webkitperl/LoadAsModule.pm: Added.
3400         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.
3401         (import):
3402         (readFile):
3403         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
3404         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
3405         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
3406
3407 2011-12-20  Balazs Kelemen  <kbalazs@webkit.org>
3408
3409         [Qt] WK2 Debugging quirks need some improvement
3410         https://bugs.webkit.org/show_bug.cgi?id=74859
3411
3412         Reviewed by Simon Hausmann.
3413
3414         Improvements added to make debugging WebKit2 more
3415         confortable and efficient:
3416         1. Unify debugging quirks. From now all of them are controlled
3417         by the QT_WEBKIT2_DEBUG environment variable.
3418         2. Disable crash handlers for WebKitTestRunner if debugging quirks
3419         are used to make it possible to use postmortem debugging via core dumps
3420         which is extremely useful for debugging bugs triggered by layout tests.
3421         3. Disable test timeout for WebKitTestRunner if debugging quirks
3422         are used because that makes debugging impossible.
3423
3424         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3425         (WTR::InjectedBundle::platformInitialize):
3426         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3427         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3428         * WebKitTestRunner/qt/TestControllerQt.cpp:
3429         (WTR::TestController::platformRunUntil):
3430
3431 2011-12-20  Rafael Brandao  <rafael.lobo@openbossa.org>
3432
3433         [Qt][WK2] Implement favicon support
3434         https://bugs.webkit.org/show_bug.cgi?id=71082
3435
3436         Reviewed by Simon Hausmann.
3437
3438         A favorite icon was added on MiniBrowser's url bar as example.
3439         We display a default icon when the page doesn't have an icon ready.
3440
3441         * MiniBrowser/qt/MiniBrowser.qrc:
3442         * MiniBrowser/qt/icons/favicon.png: Added.
3443         * MiniBrowser/qt/qml/BrowserWindow.qml:
3444
3445 2011-12-19  Sam Weinig  <sam@webkit.org>
3446
3447         Add support for scrollLineDown: and scrollLineUp: NSResponder selectors
3448         https://bugs.webkit.org/show_bug.cgi?id=74907
3449
3450         Reviewed by Dan Bernstein.
3451
3452         Add ScrollByLineCommands API test.
3453
3454         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3455         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Added.
3456         * TestWebKitAPI/Tests/WebKit2/simple-tall.html: Added.
3457
3458 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3459
3460         webkitpy: remove port.executive, port.filesystem, port.user properties
3461         https://bugs.webkit.org/show_bug.cgi?id=74896
3462
3463         Reviewed by Eric Seidel.
3464
3465         Following on the refactoring of the port and host objects, this
3466         removes the public executive, filesystem, and user properties
3467         from the Port interface (protected versions of executive and
3468         filesystem still exist). There is still some more clean up to
3469         make the code more consistent and rearrange some other files to
3470         talk to Hosts directly instead of getting them off of the Port
3471         class.
3472
3473         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3474         (Manager.__init__):
3475         (Manager.results_directory):
3476         (Manager._log_worker_stack):
3477         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3478         (ManagerTest.test_fallback_path_in_config):
3479         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3480         (_InlineManager.start_worker):
3481         (_InlineWorkerConnection.__init__):
3482         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3483         (Worker.safe_init):
3484         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3485         (TestConfiguration.from_port):
3486         * Scripts/webkitpy/layout_tests/port/base.py:
3487         (Port.__init__):
3488         (Port.tests):
3489         (Port.show_results_html_file):
3490         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3491         (PortTest.test_layout_tests_skipping):
3492         (PortTest.test_test_dirs):
3493         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3494         (_set_up_derived_options):
3495         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3496         (PerfTestsRunner.__init__):
3497         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3498         (HtmlGenerator.__init__):
3499         (HtmlGenerator.show_html):
3500         (real_main):
3501         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3502         (TestHtmlGenerator.make_generator):
3503
3504 2011-12-19  Daniel Bates  <dbates@webkit.org>
3505
3506         Pass command line arguments to GDB when debugging a Mac WebKit application
3507         https://bugs.webkit.org/show_bug.cgi?id=72829
3508
3509         Reviewed by David Kilzer.
3510
3511         Pass through any command line arguments given to debug-{safari, minibrowser}
3512         to GDB so that they may influence the application instance launched by GDB.
3513
3514         * Scripts/webkitdirs.pm:
3515         (execMacWebKitAppForDebugging):
3516
3517 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3518
3519         webkitpy: remove executive,filesystem,user parameters from Port constructor
3520         https://bugs.webkit.org/show_bug.cgi?id=74878
3521
3522         Reviewed by Eric Seidel.
3523
3524         This change concludes the refactoring that makes Host a required
3525         parameter for Port and ensures that all access to filesystem,
3526         executives, etc. is going through the Host.
3527
3528         * Scripts/webkitpy/layout_tests/port/base.py:
3529         (Port.__init__):
3530
3531 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3532
3533         webkitpy: finish refactoring port classes to make a host mandatory
3534         https://bugs.webkit.org/show_bug.cgi?id=74566
3535
3536         Reviewed by Eric Seidel.
3537
3538         This change makes all Port objects take a required (System)Host
3539         parameter, and updates the TestPort object to no longer create a
3540         mock filesystem or add files to the existing filesystem by
3541         default.
3542
3543         * Scripts/webkitpy/layout_tests/port/base.py:
3544         (Port.__init__):
3545         * Scripts/webkitpy/layout_tests/port/factory.py:
3546         (PortFactory.__init__):
3547         (PortFactory._get_kwargs):
3548         * Scripts/webkitpy/layout_tests/port/test.py:
3549         (TestInstance.__init__):
3550         (TestPort.__init__):
3551         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3552         (passing_run):
3553         (logging_run):
3554         (get_tests_run):
3555         (MainTest.test_single_file):
3556         (MainTest.test_stderr_is_saved):
3557         (MainTest.test_test_list):
3558         (MainTest.test_test_list_with_prefix):
3559         (MainTest.test_missing_and_unexpected_results):
3560         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
3561         (MainTest.test_crash_with_stderr):
3562         (MainTest.test_no_image_failure_with_image_diff):
3563         (MainTest.test_crash_log):
3564         (MainTest.test_web_process_crash_log):
3565         (MainTest.test_exit_after_n_failures_upload):
3566         (MainTest.test_results_directory_absolute):
3567         (MainTest.test_results_directory_relative):
3568         (MainTest.test_retries_directory):
3569         (MainTest.test_tolerance.get_port_for_run):
3570         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
3571         (EndToEndTest.test_end_to_end):
3572         (EndToEndTest.test_reftest_with_two_notrefs):
3573         (RebaselineTest.test_reset_results):
3574         (RebaselineTest.test_missing_results):
3575         (RebaselineTest.test_new_baseline):
3576         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3577         (Rebaseliner.__init__):
3578         (main):
3579         (real_main):
3580         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3581         (test_host_port_and_filesystem):
3582         (TestRebaseliner.make_rebaseliner):
3583         (TestRealMain.test_all_platforms):
3584         (TestHtmlGenerator.make_generator):
3585
3586 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
3587
3588         webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects
3589         https://bugs.webkit.org/show_bug.cgi?id=74562
3590
3591         Reviewed by Eric Seidel.
3592
3593         Apart from a minor change to style/checkers/test_expectations.py
3594         to take a host as a parameter to a TestExpectationsChecker(),
3595         there are only refactoring changes to unit tests here.
3596
3597         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3598         (TestResultWriterTest.test_reftest_diff_image):
3599         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3600         (JSONGeneratorTest._test_json_generation):
3601         (JSONGeneratorTest.test_test_timings_trie):
3602         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3603         (Base.__init__):
3604         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3605         (PortTest.make_port):
3606         (PortTest.test_layout_tests_skipping):
3607         (PortTest.test_test_dirs):
3608         (PortTest.test_additional_platform_directory):
3609         (PortTest.test_uses_test_expectations_file):
3610         (PortTest.test_find_no_paths_specified):
3611         (PortTest.test_find_one_test):
3612         (PortTest.test_find_glob):
3613         (PortTest.test_find_with_skipped_directories):
3614         (PortTest.test_find_with_skipped_directories_2):
3615         (PortTest.test_parse_reftest_list):
3616         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3617         (DryRunPort.__init__):
3618         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3619         (FactoryTest.setUp):
3620         (FactoryTest.tearDown):
3621         (FactoryTest.assert_port):
3622         (FactoryTest.assert_platform_port):
3623         (FactoryTest.test_unknown_specified):
3624         (FactoryTest.test_unknown_default):
3625         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3626         (GetGoogleChromePortTest._verify_expectations_overrides):
3627         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3628         (MockDRTPortTest.make_port):
3629         (MockDRTTest.assertTest):
3630         (MockDRTTest.test_main):
3631         (MockChromiumDRTTest.test_pixeltest__fails):
3632         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3633         (QtPortTest._assert_search_path):
3634         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3635         (TestWebKitPort.__init__):
3636         (WebKitPortTest.test_skipped_directories_for_symbols):
3637         (test_skipped_directories_for_features):
3638         (test_skipped_layout_tests):
3639         (test_skipped_file_search_paths):
3640         (test_root_option):
3641         (test_test_expectations):
3642         (test_build_driver):
3643         (test_linux_distro_detection):
3644         (test_apache_config_file_name_for_platform):
3645         (test_path_to_apache_config_file):
3646         (WebKitDriverTest.test_read_block):
3647         * Scripts/webkitpy/style/checkers/test_expectations.py:
3648         (TestExpectationsChecker.__init__):
3649         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3650         (TestExpectationsTestCase._expect_port_for_expectations_path):
3651         (TestExpectationsTestCase.assert_lines_lint):
3652         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3653         (get_test_config.TestMacPort):
3654
3655 2011-12-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
3656
3657         [Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
3658         https://bugs.webkit.org/show_bug.cgi?id=74854
3659
3660         Reviewed by Csaba Osztrogonác.
3661
3662         Since r101052, libewebkit.so is built in a different location, so we
3663         need to adjust the path returned by builtDylibPathForName.
3664
3665         usesPerConfigurationBuildDirectory also needs to be fixed, as the Efl
3666         port also respects Release/Debug configurations.
3667
3668         These changes should make run-launcher finally work correctly with
3669         webkit-efl.
3670
3671         * Scripts/webkitdirs.pm:
3672         (usesPerConfigurationBuildDirectory):
3673         (builtDylibPathForName):
3674
3675 2011-12-19  Simon Hausmann  <simon.hausmann@nokia.com>
3676
3677         [Qt][WK2] Add support for modal event loop processing for WTR
3678         https://bugs.webkit.org/show_bug.cgi?id=74852
3679
3680         Reviewed by Kenneth Rohde Christiansen.
3681
3682         Rewrote event loop processing: Instead of terminating the event loop
3683         in notifyDone() - something no other platform does - we now respect the
3684         "bool& condition" parameter passed to platformRunUntil. This ensures
3685         proper termination even when the condition is changed from within a
3686         nested event loop, because only when we _exit_ from the nested event
3687         loop we will check the condition and terminate the test properly.
3688
3689         In addition this patch implements TestController::runModal by means of
3690         a nested event loop, which is passed to the platform webview that is
3691         supposed to be modal. It is that view's responsibility to exit the
3692         loop, upon destruction. I believe that's similar to how it works on the Mac,
3693         where it doesn't seem that NSApp's runModalForWindow is terminate via
3694         abort/stopModal but simply because the window is closed.
3695
3696         * WebKitTestRunner/PlatformWebView.h:
3697         (WTR::PlatformWebView::setModalEventLoop):
3698         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3699         (WTR::PlatformWebView::PlatformWebView):
3700         (WTR::PlatformWebView::~PlatformWebView):
3701         * WebKitTestRunner/qt/TestControllerQt.cpp:
3702         (WTR::TestController::notifyDone):
3703         (WTR::TestController::platformRunUntil):
3704         (WTR::TestController::runModal):
3705
3706 2011-12-18  Kentaro Hara  <haraken@chromium.org>
3707
3708         REGRESSION(r103149): prepare-ChangeLog outputs a warning
3709         https://bugs.webkit.org/show_bug.cgi?id=74808
3710
3711         Reviewed by David Kilzer.
3712
3713         Added the prototype declaration of main() to avoid warning messages.
3714         Sorted subroutine declarations in the alphabetical order.
3715
3716         * Scripts/prepare-ChangeLog:
3717
3718 2011-12-17  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3719
3720         [Qt] Fix QtTestBrowser compilation with QtWidgets module
3721         https://bugs.webkit.org/show_bug.cgi?id=74791
3722
3723         Reviewed by Andreas Kling.
3724
3725         * QtTestBrowser/QtTestBrowser.pro:
3726
3727 2011-12-17  Kentaro Hara  <haraken@chromium.org>
3728
3729         Remove top-level code completely from prepare-ChangeLog
3730         https://bugs.webkit.org/show_bug.cgi?id=74698
3731
3732         Reviewed by Darin Adler.
3733
3734         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner.
3735         This patch just moves all top-level code into main().
3736
3737         * Scripts/prepare-ChangeLog:
3738         (main):
3739
3740 2011-12-16  Dean Jackson  <dino@apple.com>
3741
3742         Move webkit-bug-importer to Contributor. It won't
3743         autocomplete as an Account.
3744         See https://bugs.webkit.org/show_bug.cgi?id=74739
3745         for some discussion.
3746
3747         Unreviewed.
3748
3749         * Scripts/webkitpy/common/config/committers.py:
3750
3751 2011-12-16  Dean Jackson  <dino@apple.com>
3752
3753         Add webkit-bug-importer@group.apple.com to accounts
3754         so that it autocompletes in bugzilla.
3755
3756         Unreviewed.
3757
3758         * Scripts/webkitpy/common/config/committers.py:
3759
3760 2011-12-16  Philippe Normand  <pnormand@igalia.com>
3761
3762         Unreviewed, skipping 3 failing GTK API tests.
3763
3764         * Scripts/run-gtk-tests:
3765
3766 2011-12-16  Philippe Normand  <pnormand@igalia.com>
3767
3768         Unreviewed, GTK API tests build fix attempt.
3769
3770         * Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
3771
3772 2011-12-16  Philippe Normand  <pnormand@igalia.com>
3773
3774         Unreviewed, unskipping GTK testdownload. Should pass on the bot now.
3775
3776         * Scripts/run-gtk-tests:
3777
3778 2011-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
3779
3780         [Qt] Fix the build for newer Qt5
3781         https://bugs.webkit.org/show_bug.cgi?id=74703
3782
3783         Reviewed by Csaba Osztrogonác.
3784
3785         * QtTestBrowser/launcherwindow.h: Add missing forward declaration.
3786         * DumpRenderTree/qt/EventSenderQt.cpp:
3787         (EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
3788         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
3789         (WTR::EventSenderProxy::sendTouchEvent):
3790         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3791         (MiniBrowserApplication::sendTouchEvent): Ditto.
3792         (MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
3793
3794 2011-12-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3795
3796         [Qt] Detect and force clean build when feature defines are added
3797
3798         Reviewed by Ossy.
3799
3800         https://bugs.webkit.org/show_bug.cgi?id=74689
3801
3802         * Scripts/webkitdirs.pm:
3803
3804 2011-12-16  Kentaro Hara  <haraken@chromium.org>
3805
3806         [Refactoring] Remove all global variables from prepare-ChangeLog
3807         https://bugs.webkit.org/show_bug.cgi?id=74681
3808
3809         Reviewed by Ryosuke Niwa.
3810
3811         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
3812         manner. This bug is one of the incremental refactorings to remove all top-level
3813         code and global variables from prepare-ChangeLog. In this patch,
3814         we make the following global variables be used only through parameter passing.
3815         This patch removes all global variables from prepare-ChangeLog.
3816             - $mergeBase
3817             - $gitCommit
3818             - $gitIndex
3819
3820         * Scripts/prepare-ChangeLog:
3821         (generateFunctionLists):
3822         (changeLogNameFromArgs):
3823         (changeLogEmailAddressFromArgs):
3824         (generateNewChangeLogs):
3825         (printDiff):
3826         (diffFromToString):
3827         (diffCommand):
3828         (statusCommand):
3829         (createPatchCommand):
3830         (generateFileList):
3831         (isConflictStatus):
3832
3833 2011-12-15  Philippe Normand  <pnormand@igalia.com>
3834
3835         [GTK] Rounding errors on 32-bit machines causes tests to fail
3836         https://bugs.webkit.org/show_bug.cgi?id=72254
3837
3838         Initial patch by vanuan@gmail.com.
3839         Reviewed by Martin Robinson.
3840
3841         * Scripts/webkitdirs.pm:
3842         (runAutogenForAutotoolsProjectIfNecessary): Pass additional
3843         CXXFLAGS to autogen in an attempt to harmonize floating point
3844         values between 32-bit and 64-bit architectures.
3845
3846 2011-12-16  Martin Robinson  <mrobinson@igalia.com>
3847
3848         [GTK] Make distcheck fails during the install
3849         https://bugs.webkit.org/show_bug.cgi?id=74274
3850
3851         No review, since this is a build fix.
3852
3853         * GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc
3854         step. BUILT_SOURCES includes forwarding header generation for WebKit2, which
3855         always runs. This means that the gtkdoc step was always running when make was
3856         invoked. Generating gtkdoc during 'make install' was triggering a race condition
3857         with the library file. Later we can fix generate-forwarding-headers and unbreak
3858         'make docs,' but this bandaid is sufficient to let us release.
3859
3860 2011-12-15  Eric Seidel  <eric@webkit.org>
3861
3862         NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
3863         https://bugs.webkit.org/show_bug.cgi?id=74650
3864
3865         Reviewed by Adam Barth.
3866
3867         * Scripts/webkitpy/common/system/platforminfo.py:
3868         (PlatformInfo._compute_bytes_from_vm_stat_output):
3869         * Scripts/webkitpy/layout_tests/port/base.py:
3870         (Port.default_child_processes):
3871         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3872         (PortTest.test_default_child_processes):
3873
3874 2011-12-15  Filip Pizlo  <fpizlo@apple.com>
3875
3876         bencher script should support remote benchmarking on platforms that don't have ruby
3877         https://bugs.webkit.org/show_bug.cgi?id=74659
3878
3879         Rubber-stamped by Sam Weinig.
3880         
3881         Added the ability to have bencher generate a benchmarking playload that consists of
3882         copies of all of the benchmarks, optionally copies of all of the frameworks and
3883         binaries to run all of the VMs, and a sh script that runs the benchmarks in random
3884         order, which then spits out a raw results file that bencher can parse.
3885         
3886         In normal operating mode, you never see this, as it just generates the payload and
3887         script internally, runs it, parses the results, and spits them out.
3888         
3889         The --remote mode has been changed to use this style, so any remote host that has
3890         sshd, passwordless login support, a ~/.bencher file that points to a "tempPath", and
3891         a sh-compatible shell can be used for remote benchmarking.
3892         
3893         The feature to include VMs in the benchmarking payload is by default only activated
3894         when using --remote, but it can also be activated when doing local benchmarking; the
3895         benefit is that you remove any pathname-related performance pathologies. All VMs
3896         become equal because they are all located in
3897         /path/to/bencher/directory/temp/benchdata/vmN where N is the configuration number
3898         (usually 0 or 1).
3899         
3900         Also fixed bugs in the DumpRenderTree support. It's now possible to run all benchmarks
3901         through DumpRenderTree. This is only a bit slower than running in jsc.
3902
3903         * Scripts/bencher:
3904
3905 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
3906
3907         webkitpy: clean up TestPort to (mostly) not create a new filesystem
3908         https://bugs.webkit.org/show_bug.cgi?id=74556
3909
3910         This change modifies the TestPort to be ready to add tests to an
3911         existing filesystem instead of creating a new filesystem; we
3912         leave unit_test_filesystem() in for now for compatibility.
3913
3914         * Scripts/webkitpy/common/host_mock.py:
3915         (MockHost.__init__):
3916           - call add_unit_tests_to_mock_filesystem by default to make
3917             the MockHost more generally useful for layout_test unit tests.
3918         * Scripts/webkitpy/layout_tests/port/test.py:
3919         (TestInstance.__init__):
3920         (add_unit_tests_to_mock_filesystem):
3921         (add_file):
3922         (unit_test_filesystem):
3923         (TestPort.__init__):
3924         (TestPort._set_default_overriding_none):
3925
3926 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
3927
3928         webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
3929         https://bugs.webkit.org/show_bug.cgi?id=74551
3930
3931         This is some minor cleanup prior to making all of the host/port
3932         changes described in bug 74138.
3933
3934         * Scripts/webkitpy/common/host_mock.py:
3935         (MockHost.__init__):
3936           - make sure the scm object is initialized with the same mock
3937             executive and filesystem objects.
3938
3939         * Scripts/webkitpy/common/system/filesystem_mock.py:
3940         (MockFileSystem.clear_written_files):
3941           - add a routine that will be useful in testing.
3942         (MockFileSystem.maybe_make_directory):
3943         (MockFileSystem.write_binary_file):
3944           - fix bugs to make sure directories are created properly.
3945         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3946         (_Process.run):
3947           - add clarifying comments.
3948         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3949         (MockDRTPort.__init__):
3950         (MockDRT.__init__):
3951           - add clarifying comments.
3952
3953 2011-12-15  Anders Carlsson  <andersca@apple.com>
3954
3955         Regression (r102866): Navigating away from or closing a page with a plugin crashes
3956         https://bugs.webkit.org/show_bug.cgi?id=74655
3957
3958         Reviewed by Sam Weinig.
3959
3960         Add a bunch of tests.
3961
3962         * TestWebKitAPI/Tests/WTF/Functional.cpp:
3963
3964 2011-12-15  Stephanie Lewis  <slewis@apple.com>
3965
3966         https://bugs.webkit.org/show_bug.cgi?id=74469
3967         Escape paths to svn commands so our tools can handle filenames with @ symbols.
3968
3969         Reviewed by Adam Roben.
3970
3971         * Scripts/VCSUtils.pm:
3972         (scmMoveOrRenameFile):
3973         (scmAddExecutableBit):
3974         (scmRemoveExecutableBit):
3975         (determineSVNRoot):
3976         (svnRevisionForDirectory):
3977         (pathRelativeToSVNRepositoryRootForPath):
3978         (svnStatus):
3979         (escapeSubversionPath):
3980         * Scripts/parse-malloc-history:
3981         (main):
3982         * Scripts/prepare-ChangeLog:
3983         (diffCommand):
3984         (statusCommand):
3985         (findOriginalFileFromSvn):
3986         (determinePropertyChanges):
3987         * Scripts/resolve-ChangeLogs:
3988         (conflictFiles):
3989         (resolveConflict):
3990         (showStatus):
3991         * Scripts/svn-apply:
3992         (patch):
3993         (scmCopy):
3994         (scmAdd):
3995         (scmRemove):
3996         * Scripts/svn-create-patch:
3997         (findBaseUrl):
3998         (findMimeType):
3999         (findSourceFileAndRevision):
4000         (generateDiff):
4001         (generateFileList):
4002         (manufacturePatchForAdditionWithHistory):
4003         * Scripts/svn-unapply:
4004         (patch):
4005         (revertDirectories):
4006
4007 2011-12-15  Michael Bruning  <michael.bruning@nokia.com>
4008
4009         [qt][wk2] MiniBrowser: Add pressed state for viewport info button.
4010         https://bugs.webkit.org/show_bug.cgi?id=74617
4011
4012         Reviewed by Kenneth Rohde Christiansen.
4013
4014         * MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring
4015         for viewport info button, adjusted height and added rounded corners.
4016
4017 2011-12-15  Andy Estes  <aestes@apple.com>
4018
4019         TestFailures: store the name of the buildbot results directory in a property
4020         https://bugs.webkit.org/show_bug.cgi?id=74663
4021
4022         Reviewed by Adam Barth.
4023         
4024         Store the name of the results directory as a property on Buildbot's
4025         prototype. This allows subclasses of Buildbot to customize the results
4026         directory.
4027
4028         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
4029         (Buildbot.prototype.resultsDirectoryURL):
4030
4031 2011-12-15  Tony Chang  <tony@chromium.org>
4032
4033         [chromium] pass --delete_unversioned_trees to gclient on the bots
4034         https://bugs.webkit.org/show_bug.cgi?id=74565
4035
4036         Reviewed by Kenneth Russell.
4037
4038         It was temporarily removed in r102891 to keep the bots green.  Now
4039         that the bots have cycled, we can add it back.
4040
4041         * Scripts/update-webkit-chromium:
4042
4043 2011-12-15  Kentaro Hara  <haraken@chromium.org>
4044
4045         [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
4046         https://bugs.webkit.org/show_bug.cgi?id=74497
4047
4048         Reviewed by Ryosuke Niwa.
4049
4050         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
4051         manner. This bug is one of the incremental refactorings to remove all top-level
4052         code and global variables from prepare-ChangeLog. In this patch,
4053         we make the following global variables be used only through parameter passing.
4054             - $bugDescription
4055             - $bugNumber
4056             - $name
4057             - $emailAddress
4058             - $gitReviewer
4059             - $writeChangeLogs
4060
4061         * Scripts/prepare-ChangeLog:
4062         (fetchBugDescriptionFromURL):
4063         (generateNewChangeLogs):
4064         (reviewerAndDescriptionForGitCommit):
4065
4066 2011-12-15  Raphael Kubo da Costa  <kubo@profusion.mobi>
4067
4068         [EFL] Add a few more web database functions to ewk_settings.
4069         https://bugs.webkit.org/show_bug.cgi?id=72148
4070
4071         Reviewed by Antonio Gomes.
4072
4073         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4074         (LayoutTestController::clearAllDatabases):
4075         (LayoutTestController::setDatabaseQuota):
4076
4077 2011-12-15  Martin Kosiba  <mkosiba@google.com>
4078
4079         Fix find on web pages with -webkit-user-select: none for Chromium
4080         https://bugs.webkit.org/show_bug.cgi?id=72281
4081
4082         Reviewed by Ryosuke Niwa.
4083
4084         Provided a partial findString implementation. This doesn't support
4085         all of the FindOptions since they're not exposed via WebFindOptions.
4086
4087         * DumpRenderTree/chromium/LayoutTestController.cpp:
4088         (LayoutTestController::LayoutTestController):
4089         (LayoutTestController::findString):
4090         * DumpRenderTree/chromium/LayoutTestController.h:
4091
4092 2011-12-15  Kenneth Russell  <kbr@google.com>
4093
4094         [chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
4095         https://bugs.webkit.org/show_bug.cgi?id=74581
4096
4097         Reviewed by Darin Fisher.
4098
4099         * DumpRenderTree/chromium/LayoutTestController.cpp:
4100         (LayoutTestController::overridePreference):
4101         * DumpRenderTree/chromium/WebPreferences.cpp:
4102         (WebPreferences::reset):
4103         (WebPreferences::applyTo):
4104         * DumpRenderTree/chromium/WebPreferences.h:
4105
4106 2011-12-15  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4107
4108         [Qt] Improve the look of the viewport info overlay
4109
4110         Reviewed by Tor Arne Vestbø.
4111
4112         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
4113
4114 2011-12-15  Igor Oliveira  <igor.oliveira@openbossa.org>
4115
4116         [Qt] Support requestAnimationFrame API
4117         https://bugs.webkit.org/show_bug.cgi?id=74528
4118
4119         Add build-option for requestAnimationFrame feature.
4120
4121         Reviewed by Kenneth Rohde Christiansen.
4122
4123         * qmake/mkspecs/features/features.prf:
4124
4125 2011-12-15  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4126
4127         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
4128
4129         Reviewed by Simon Hausmann.
4130
4131         * qmake/mkspecs/features/webcore.prf:
4132
4133 2011-12-15  Michael Brüning  <michael.bruning@nokia.com>
4134
4135         [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
4136         https://bugs.webkit.org/show_bug.cgi?id=72893
4137
4138         Reviewed by Kenneth Rohde Christiansen.
4139
4140         This patch extends QQuickWebViewExperimental by a property named
4141         viewportInfo, which contains the viewport scalability and
4142         layout and contents size information. This property is exposed to
4143         QML through the experimental extension for QQuickWebView.
4144
4145         * MiniBrowser/qt/MiniBrowser.pro:
4146         * MiniBrowser/qt/MiniBrowser.qrc:
4147         * MiniBrowser/qt/icons/info.png: Added.
4148         * MiniBrowser/qt/qml/BrowserWindow.qml:
4149         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added.
4150
4151 2011-12-15  Shinya Kawanaka  <shinyak@google.com>
4152
4153         [chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
4154         https://bugs.webkit.org/show_bug.cgi?id=74586
4155
4156         Reviewed by Hajime Morita.
4157
4158         No new tests. Covered by existing tests.
4159
4160         * DumpRenderTree/chromium/WebViewHost.cpp:
4161         (WebViewHost::requestCheckingOfText):
4162           Returns immediately if text is empty.
4163
4164 2011-12-15  Alexander Færøy  <ahf@0x90.dk>
4165
4166         [Qt] QtWebKit fails to build on Mac OS X after r102776
4167         https://bugs.webkit.org/show_bug.cgi?id=74593
4168
4169         Reviewed by Simon Hausmann.
4170
4171         CONFIG =+ link_pkgconfig is needed such that the correct parameters
4172         are passed to the compiler.
4173
4174         * DumpRenderTree/qt/DumpRenderTree.pro:
4175
4176 2011-12-14  Tony Chang  <tony@chromium.org>
4177
4178         [chromium] Remove redundant third_party entries from chromium DEPS
4179         https://bugs.webkit.org/show_bug.cgi?id=74472
4180
4181         Reviewed by Kenneth Russell.
4182
4183         * Scripts/update-webkit-chromium: Temporarily keep unversioned trees.
4184
4185 2011-12-14  Kentaro Hara  <haraken@chromium.org>
4186
4187         [Refactoring] In prepare-ChangeLog, replace $isGit and $isSVN with
4188         VCSUtils::isGit() and VCSUtils::isSVN().
4189         https://bugs.webkit.org/show_bug.cgi?id=74485
4190
4191         Reviewed by David Kilzer.
4192
4193         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
4194         manner. This bug is one of the incremental refactorings to remove all top-level
4195         code and global variables from prepare-ChangeLog. This patch replaces $isGit and $isSVN
4196         with VCSUtils::isGit() and VCSUtils::isSVN(). This patch also removes firstDirectoryOrCwd(),
4197         assuming that no user will mix Git/SVN checkouts and thus we can judge SVN or Git
4198         just by looking at the current working directory.
4199
4200         * Scripts/prepare-ChangeLog: Removed firstDirectoryOrCwd().
4201         (diffFromToString):
4202         (diffCommand):
4203         (statusCommand):
4204         (createPatchCommand):
4205         (diffHeaderFormat):
4206         (generateFileList):
4207         (isAddedStatus):
4208         (isConflictStatus):
4209         (statusDescription):
4210         (extractLineRange):
4211
4212 2011-12-14  Sam Weinig  <weinig@apple.com>
4213
4214         Remove whitespace from InheritedPropertySheets attributes in
4215         vsprops files to appease the Visual Studio project migrator.
4216
4217         Reviewed by Adam Roben.
4218
4219         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops:
4220         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops:
4221         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops:
4222         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
4223         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
4224         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
4225         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops:
4226         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops:
4227         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops:
4228         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
4229         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
4230         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
4231         * DumpRenderTree/win/ImageDiffDebug.vsprops:
4232         * DumpRenderTree/win/ImageDiffDebugAll.vsprops:
4233         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops:
4234         * DumpRenderTree/win/ImageDiffProduction.vsprops:
4235         * DumpRenderTree/win/ImageDiffRelease.vsprops:
4236         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
4237         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops:
4238         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops:
4239         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops:
4240         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
4241         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
4242         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
4243         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
4244         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
4245         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops:
4246         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops:
4247         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops:
4248         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
4249         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
4250         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
4251         * WebKitTestRunner/win/InjectedBundleDebug.vsprops:
4252         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops:
4253         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops:
4254         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
4255         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
4256         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
4257         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops:
4258         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops:
4259         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops:
4260         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
4261         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
4262         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
4263         * WinLauncher/WinLauncherDebug.vsprops:
4264         * WinLauncher/WinLauncherDebugAll.vsprops:
4265         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops:
4266         * WinLauncher/WinLauncherProduction.vsprops:
4267         * WinLauncher/WinLauncherRelease.vsprops:
4268         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
4269         * record-memory-win/record-memory-winDebug.vsprops:
4270         * record-memory-win/record-memory-winDebugAll.vsprops:
4271         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops:
4272         * record-memory-win/record-memory-winProduction.vsprops:
4273         * record-memory-win/record-memory-winRelease.vsprops:
4274         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
4275
4276 2011-12-14  Anders Carlsson  <andersca@apple.com>
4277
4278         Windows build fix.
4279
4280         Move CHECKs out of the destructor.
4281
4282         * TestWebKitAPI/Tests/WTF/Functional.cpp:
4283         (TestWebKitAPI::B::~B):
4284         (TestWebKitAPI::TEST):
4285
4286 2011-12-14  Anders Carlsson  <andersca@apple.com>
4287
4288         binding a member function should ref/deref the object pointer if needed
4289         https://bugs.webkit.org/show_bug.cgi?id=74552
4290
4291         Reviewed by Sam Weinig.
4292