fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
[WebKit-https.git] / Tools / ChangeLog
1 2014-07-29  Alexey Proskuryakov  <ap@apple.com>
2
3         fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
4         https://bugs.webkit.org/show_bug.cgi?id=135398
5
6         Reviewed by Zalan Bujtas.
7
8         * WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):
9         "hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.
10
11         * DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.
12         For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
13         sure why.
14
15 2014-07-29  Alexey Proskuryakov  <ap@apple.com>
16
17         PPT: run-webkit-tests doesn't upload crash logs to bots
18         https://bugs.webkit.org/show_bug.cgi?id=135391
19
20         Reviewed by Joseph Pecoraro.
21
22         * WebKitTestRunner/TestController.cpp: (WTR::TestController::processDidCrash):
23         Not a fix to be proud of, but better than not having it work at all.
24
25 2014-07-29  Adrian Perez de Castro  <aperez@igalia.com>
26
27         [GTK] Remove WebKitWebViewGroup from WebKit2 GTK+ API
28         https://bugs.webkit.org/show_bug.cgi?id=133729
29
30         Reviewed by Carlos Garcia Campos.
31
32         Removes WebKitWebViewGroup, effectively reverting the changes
33         introduced by r149117. The motivation for WebKitWebViewGroup
34         was using the user style sheet injection API, which has been
35         moved into WebKitUserContentManager, rendering it unneeded.
36
37         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Remove tests
38         for WebKitWebViewGroup.
39         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
40         (testWebViewSettings):
41         Restore the assertions that check that settings objects are
42         released. Add test for webkit_web_view_new_with_settings().
43         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Removed.
44
45 2014-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
46
47         Implement webkit_web_view_load_string() in WebKit2
48         https://bugs.webkit.org/show_bug.cgi?id=134735
49
50         Reviewed by Sergio Villar Senin.
51
52         Add /webkit2/WebKitWebView/load-bytes test case and simplify
53         TestDOMXPathNSResolver by using webkit_web_view_load_bytes()
54         instead of a soup server just to sent the Content-type header.
55
56         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
57         (testWebKitDOMXPathNSResolverNative):
58         (testWebKitDOMXPathNSResolverCustom):
59         (beforeAll):
60         (afterAll):
61         (serverCallback): Deleted.
62         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
63         (testLoadBytes):
64         (beforeAll):
65         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
66         (LoadTrackingTest::loadBytes):
67         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
68         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
69         (WebViewTest::loadBytes):
70         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
71
72 2014-07-28  Daniel Bates  <dabates@apple.com>
73
74         Add support for running the Clang static analyzer when building WebKit and JSC
75         https://bugs.webkit.org/show_bug.cgi?id=134955
76
77         Reviewed by Brent Fulgham.
78
79         * Scripts/build-jsc: Added command line options -[no]-analyze (disabled by default).
80         * Scripts/build-webkit: Add --analyze command line option to build-webkit to enable
81         running the Clang static analyzer.
82         * Scripts/webkitdirs.pm:
83         (XcodeStaticAnalyzerOption): Added.
84
85 2014-07-24  David Farler  <dfarler@apple.com>
86
87         Allow for multiple DumpRenderTree and WebKitTestRunner instances in the iOS Simulator
88         https://bugs.webkit.org/show_bug.cgi?id=135272
89
90         Reviewed by Simon Fraser.
91
92         * DumpRenderTree/mac/DumpRenderTree.mm:
93         (dumpRenderTree): Remove hard-coding of FIFO paths.
94         (-[DumpRenderTree applicationDidEnterBackground:]): Create background task.
95         (DumpRenderTreeMain): Set DumpRenderTree as UIApplication delegate.
96         * DumpRenderTree/mac/DumpRenderTreeMac.h: bgTask ivar.
97         * Scripts/old-run-webkit-tests: Update FIFO paths for ORWT.
98         * WebKitTestRunner/TestController.cpp: Remove hard-coding of FIFO paths.
99         * WebKitTestRunner/ios/TestControllerIOS.mm: Move dup2 calls to platformInitialize
100         * WebKitTestRunner/ios/mainIOS.mm: bgTask ivar.
101         (-[WebKitTestRunnerApp applicationDidEnterBackground:]): Create background task.
102         (main): Set WebKitTestRunnerApp as UIApplication delegate.
103
104 2014-07-24  David Farler  <dfarler@apple.com>
105
106         ImageDiff builds for the simulator when running iOS layout tests
107         https://bugs.webkit.org/show_bug.cgi?id=135270
108
109         Reviewed by Simon Fraser.
110
111         * Scripts/build-imagediff: Added.
112
113 2014-07-28  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
114
115         Followup fix after r171594
116         https://bugs.webkit.org/show_bug.cgi?id=135048
117
118         Reviewed by Csaba Osztrogonác.
119
120         * Scripts/sort-export-file: Removed extra newlines from help.
121
122 2014-07-25  Anders Carlsson  <andersca@apple.com>
123
124         WKNavigation's properties are either always nil or don't behave as documented
125         https://bugs.webkit.org/show_bug.cgi?id=135267
126         <rdar://problem/17730536>
127
128         Reviewed by Andreas Kling.
129
130         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
131         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
132         (TEST):
133         (-[DidFailProvisionalNavigationDelegate webView:didStartProvisionalNavigation:]):
134         (-[DidFailProvisionalNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
135
136 2014-07-25  Michael Catanzaro  <mcatanzaro@igalia.com>
137
138         [GTK] install-dependencies needs to install perl-CGI on Fedora
139         https://bugs.webkit.org/show_bug.cgi?id=135302
140
141         Reviewed by Martin Robinson.
142
143         * gtk/install-dependencies:
144         Add perl-CGI to yum dependencies needed for tests
145
146 2014-07-25  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
147
148         Add --dry-run option to sort-export-file
149         https://bugs.webkit.org/show_bug.cgi?id=135048
150
151         Reviewed by Csaba Osztrogonác.
152
153         Added --dry-run option to sort-export-file. Running the script with --dry-run
154         option does not sort the export files but creates a list of the files that
155         need to be sorted.
156
157         * Scripts/sort-export-file:
158         (sawError):
159
160 2014-07-24  Michael Catanzaro  <mcatanzaro@igalia.com>
161
162         GTK jhbuild modules needs to build xserver with --disable-local-transport
163         https://bugs.webkit.org/show_bug.cgi?id=135262
164
165         Reviewed by Martin Robinson.
166
167         * gtk/jhbuild.modules:
168         Build X server with --disable-local-transport, since local transport
169         is only supported on Solaris, SCO, and System V. Fixes build on
170         Fedora.
171
172 2014-07-24  Michael Catanzaro  <mcatanzaro@igalia.com>
173
174         [GTK] build-webkit script fails under jhbuild if ACLOCAL_FLAGS is unset
175         https://bugs.webkit.org/show_bug.cgi?id=135065
176
177         Reviewed by Martin Robinson.
178
179         * jhbuild/jhbuild-wrapper:
180         (ensure_jhbuild): do not assume jhbuild sets ACLOCAL_FLAGS
181
182 2014-07-23  Joseph Pecoraro  <pecoraro@apple.com>
183
184         Unreviewed iOS build fix after r171355.
185
186         * TestWebKitAPI/Configurations/Base.xcconfig:
187         Since all the Tests/WebKit2Cocoa tests are already explicitly skipped on iOS,
188         simplify to skipping all the tests in the directory. PlatformUtilities are not
189         building on iOS, which means we are missing necessary Util functions.
190
191 2014-07-23  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
192
193         [EFL] Fix build after r171454
194         https://bugs.webkit.org/show_bug.cgi?id=135191
195
196         Reviewed by Csaba Osztrogonác.
197
198         * MiniBrowser/efl/CMakeLists.txt: Add path to new EWebKit2.h location .
199
200 2014-07-23  Ryuan Choi  <ryuan.choi@samsung.com>
201
202         [EFL] Do not generate forwarding header for ewk headers
203         https://bugs.webkit.org/show_bug.cgi?id=135147
204
205         Reviewed by Gyuyoung Kim.
206
207         * WebKitTestRunner/EventSenderProxy.h:
208
209 2014-07-21  Sam Weinig  <sam@webkit.org>
210
211         [Cocoa] WKScriptMessageHandlers don't seem to function properly after navigating
212         https://bugs.webkit.org/show_bug.cgi?id=135148
213
214         Reviewed by Geoffrey Garen.
215
216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
217         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: Added.
218         (-[SimpleNavigationDelegate webView:didFinishNavigation:]):
219         (-[ScriptMessageHandler userContentController:didReceiveScriptMessage:]):
220
221 2014-07-22  Brent Fulgham  <bfulgham@apple.com>
222
223         Correct handling of __VERSION_TEXT__ for 4+-tuple versions
224         https://bugs.webkit.org/show_bug.cgi?id=135161
225         <rdar://problem/17763546>
226
227         Reviewed by David Kilzer.
228
229         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
230         Add additional test cases to catch errors in multiple-tuple
231         version string handling.
232
233 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
234
235         Extend exception fuzzing to the LLInt
236         https://bugs.webkit.org/show_bug.cgi?id=135076
237
238         Reviewed by Oliver Hunt.
239
240         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
241
242 2014-07-22  Jochen Eisinger  <jochen@chromium.org>
243
244         Fix my email address in contributors.json
245         https://bugs.webkit.org/show_bug.cgi?id=135156
246
247         Reviewed by Gyuyoung Kim.
248
249         * Scripts/webkitpy/common/config/contributors.json:
250
251 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
252
253         Unreviewed test fix.
254
255         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Revert
256         to older Perl 5.8 syntax for iterating over hashes to allow tests to
257         run on Mountain Lion bots.
258
259 2014-07-21  Alexey Proskuryakov  <ap@apple.com>
260
261         https://bugs.webkit.org/show_bug.cgi?id=135137
262         build.webkit.org/dashboard: webkitperl failures show up as yellow, not red
263
264         Reviewed by Darin Adler.
265
266         webkitperl results are binary, handle them the same way we handle bindings test results.
267
268         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
269         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
270         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
271
272 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
273
274         [Win] Follow-up for r171324.
275
276         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Cygwin
277         perl reports itself as 'cygwin'; native Windows Perl reports as
278         'MSWin32'. We need to handle both cases.
279
280 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
281
282         Unreviewed build fix after r171319.
283
284         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: This test should
285         only execute on Windows. It will fail on other platforms, so give it a way to
286         successfully exit.
287
288 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
289
290         [Win] Extend auto-version.pl to support 5-tuple versions
291         https://bugs.webkit.org/show_bug.cgi?id=135124
292         <rdar://problem/17750334>
293
294         Reviewed by David Kilzer.
295
296         Add test cases for auto-version.pl.
297
298         * Scripts/webkitperl/auto-version_unittest: Added.
299         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Added.
300
301 2014-07-21  Dean Jackson  <dino@apple.com>
302
303         Allow MiniBrowser WK1 to do element fullscreen
304         https://bugs.webkit.org/show_bug.cgi?id=135125
305
306         Reviewed by Simon Fraser.
307
308         Allow WK1 windows to go fullscreen using the DOM API.
309
310         * MiniBrowser/mac/WK1BrowserWindowController.m:
311         (-[WK1BrowserWindowController awakeFromNib]): Enable the preference for
312         fullscreen.
313
314 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
315
316         [GTK] Documentation files are added twice to the tarball
317         https://bugs.webkit.org/show_bug.cgi?id=135115
318
319         Reviewed by Sergio Villar Senin.
320
321         * gtk/manifest.txt: Remove duplicated rules.
322
323 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
324
325         [GTK] Simplify make-dist command line arguments
326         https://bugs.webkit.org/show_bug.cgi?id=134832
327
328         Reviewed by Martin Robinson.
329
330         Remove --tarball-root and -o command line options and add
331         --version, since the version can be used to build both, the
332         tarball root and the output filename. When the version it's not
333         provided, the pkg-config file is used to get the version. Also
334         change the default value of build-dir to the current directory,
335         since it's very common to call make-dist.py from the build dir.
336
337         * gtk/make-dist.py:
338         (get_tarball_root_and_output_filename_from_arguments):
339
340 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
341
342         [GTK] Reduce the size of the tarball generated by distcheck
343         https://bugs.webkit.org/show_bug.cgi?id=134802
344
345         Reviewed by Martin Robinson.
346
347         Add more rules to the manifest to decide what files to add:
348
349           - Do not include platform specific directories of other ports.
350           - Do not include port specific cmake files.
351           - Do not include Objective-C sources.
352           - Do not include .orig and .rej files.
353           - Do not include mac specific sandbox files.
354           - Only include the resources we actually build.
355
356         * gtk/manifest.txt:
357
358 2014-07-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
359
360         [EFL] Enable mpg123 feature for gst-plugin-bad.
361         https://bugs.webkit.org/show_bug.cgi?id=135016
362
363         Reviewed by Laszlo Gombos.
364
365         enable-mpg123 feature is added to jhbuild in order to support playback of mp3 format.
366
367         * efl/install-dependencies:
368         * efl/jhbuild.modules:
369
370 2014-07-20  Dan Bernstein  <mitz@apple.com>
371
372         Test for <rdar://problems/17742611> -[_WKActivatedElementInfo image] is often empty
373         https://bugs.webkit.org/show_bug.cgi?id=135107
374
375         Reviewed by Sam Weinig.
376
377         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
378         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMNode.mm: Added.
379         (-[RenderedImageFromDOMNodeFrameLoadDelegate webView:didFinishLoadForFrame:]):
380         (TestWebKitAPI::TEST):
381
382 2014-07-20  David Kilzer  <ddkilzer@apple.com>
383
384         Checker: Value stored to 'kernResult' is never read (LayoutTestHelper.m:164)
385         <http://webkit.org/b/135096>
386
387         Reviewed by Alexey Proskuryakov.
388
389         * DumpRenderTree/mac/LayoutTestHelper.m:
390         (lockDownDiscreteGraphics): Check the return values of
391         IOServiceOpen() and IOObjectRelease(), and log if not
392         KERN_SUCCESS.
393
394 2014-07-19  Anders Carlsson  <andersca@apple.com>
395
396         Update.
397
398         * Scripts/webkitpy/common/config/watchlist:
399
400 2014-07-18  Sam Weinig  <sam@webkit.org>
401
402         Revert accidental commit to MiniBrowser to make everything layer backed.
403
404         * MiniBrowser/mac/BrowserWindowController.m:
405         (-[BrowserWindowController windowDidLoad]):
406
407 2014-07-18  Dana Burkart  <dburkart@apple.com>
408
409         Add a new 'analyze' target to the makefile. This will make use of a new
410         'PATH_TO_SCAN_BUILD' which, if set will wrap xcodebuild in the clang
411         static analyzer.
412         https://bugs.webkit.org/show_bug.cgi?id=135057
413         <rdar://problem/10193187>
414
415         Reviewed by David Kilzer.
416
417         * Makefile:
418
419 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
420
421         Fix EFL+GTK.
422
423         * Scripts/run-jsc-stress-tests:
424
425 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
426
427         Exception fuzzing should work on iOS
428         https://bugs.webkit.org/show_bug.cgi?id=135070
429
430         Reviewed by Mark Hahnenberg.
431
432         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
433         (fail):
434         * Scripts/run-jsc-stress-tests:
435
436 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
437
438         run-jsc-stress-tests should be able to run helper-based tests in remote mode
439         https://bugs.webkit.org/show_bug.cgi?id=135064
440
441         Reviewed by Mark Hahnenberg.
442
443         * Scripts/run-jsc-stress-tests:
444
445 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
446
447         run-jsc-stress-tests: rename $copy to $doNotMessWithVMPath
448         https://bugs.webkit.org/show_bug.cgi?id=135061
449
450         Rubber stamped by Mark Hahnenberg.
451
452         * Scripts/run-jsc-stress-tests:
453
454 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
455
456         Refactor run-jsc-stress-tests VM copying code to remove some abstractions
457         https://bugs.webkit.org/show_bug.cgi?id=135059
458
459         Reviewed by Mark Lam.
460         
461         This is meant to make it easier for me to extend the copying functionality to copy things other than
462         the framework.
463
464         * Scripts/run-jsc-stress-tests:
465
466 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
467
468         Fix cloop build.
469
470         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
471
472 2014-07-18  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
473
474         Fix -v|--verbose option in sort-export-file script.
475         https://bugs.webkit.org/show_bug.cgi?id=135043
476
477         Reviewed by Tim Horton.
478
479         -v|--verbose option does not work. Option added to getOptionsResult.
480
481         * Scripts/sort-export-file:
482
483 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
484
485         Really remove dependency on ShellQuote.
486
487         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
488
489 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
490
491         Unreviewed, fix build for platforms that don't have ShellQuote.
492         
493         * Scripts/jsc-stress-test-helpers/js-exception-fuzz: Take a single argument that has the whole command string.
494         * Scripts/run-jsc-stress-tests: Do the escaping in Ruby.
495
496 2014-07-15  Filip Pizlo  <fpizlo@apple.com>
497
498         Need ability to fuzz exception throwing
499         https://bugs.webkit.org/show_bug.cgi?id=134945
500         <rdar://problem/17722027>
501
502         Reviewed by Sam Weinig.
503         
504         Adds a new script, js-exception-fuzz, which will run some jsc command-line using
505         exception fuzzing. This means that we will force exceptions to be thrown in random
506         places to see how the engine reacts. This is now integrated with the various test
507         drivers, so run-javascriptcore-tests will run some exception fuzzing tests by
508         default.
509
510         * Scripts/jsc-stress-test-helpers/js-exception-fuzz: Added.
511         (fail):
512         * Scripts/run-javascriptcore-tests:
513         * Scripts/run-jsc-stress-tests:
514
515 2014-07-17  Sam Weinig  <sam@webkit.org>
516
517         Fix failing API tests.
518
519         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
520         (-[ActiveOffscreenWindow isVisible]):
521         Override isVisible to make the NSWindows pretend they are visible.
522
523 2014-07-17  Alexey Proskuryakov  <ap@apple.com>
524
525         Disable button animations in regression tests
526         https://bugs.webkit.org/show_bug.cgi?id=133647
527         <rdar://problem/16677530>
528
529         Reviewed by Dean Jackson.
530
531         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
532         We already did this for WebKit2, let's do it for WebKit1 too.
533
534 2014-07-16  Alexey Proskuryakov  <ap@apple.com>
535
536         A test that hangs at cleanup stage confuses webkitpy hugely
537         https://bugs.webkit.org/show_bug.cgi?id=122475
538         <rdar://problem/17184354>
539
540         Reviewed by Anders Carlsson.
541
542         Terminate WebContent process if it freezes between tests. Ideally, we should report
543         this somehow, but this is better than blaming the wrong test.
544
545         * WebKitTestRunner/TestController.cpp:
546         (WTR::TestController::terminateWebContentProcess):
547         * WebKitTestRunner/TestController.h:
548         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
549
550 2014-07-16  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
551
552         Change style check path with EFL WK2's path in checker_unittest.py
553         https://bugs.webkit.org/show_bug.cgi?id=134967
554
555         Reviewed by Csaba Osztrogonác.
556
557         * Scripts/webkitpy/style/checker_unittest.py: Change ewk_view.h path.
558         (GlobalVariablesTest.test_path_rules_specifier):
559
560 2014-07-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
561
562         Unreviewed. Added myself to the list of committers.
563
564         * Scripts/webkitpy/common/config/contributors.json:
565
566 2014-07-15  Ryuan Choi  <ryuan.choi@samsung.com>
567
568         [EFL] Remove EFL WK1 directory from the checker.py
569         https://bugs.webkit.org/show_bug.cgi?id=134954
570
571         Reviewed by Gyuyoung Kim.
572
573         * Scripts/webkitpy/style/checker.py:
574
575 2014-07-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
576
577         Adding myself to contributors.json breaks a webkitpy test
578         https://bugs.webkit.org/show_bug.cgi?id=134958
579
580         Reviewed by Ryosuke Niwa.
581
582         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
583         (IRCCommandTest.test_whois): Be more specific and include also the
584         first name when asking for the whois of Xan in the unit test.
585
586 2014-07-14  Daniel Bates  <dabates@apple.com>
587
588         check-webkit-style should apply C++ rules to Objective-C++ files
589         https://bugs.webkit.org/show_bug.cgi?id=134884
590
591         Reviewed by Joseph Pecoraro.
592
593         Fixes an issue where check-webkit-style doesn't apply applicable C++ rules to
594         Objective-C++ files.
595
596         Currently check-webkit-style doesn't apply the following rules to Objective-C++
597         files: build/using_std, runtime/max_min_macros, runtime/wtf_move, readability/null.
598         Instead, we should teach check-webkit-style to apply these rules because, as
599         its name implies, an Objective-C++ file may contain C++ code.
600
601         * Scripts/webkitpy/style/checkers/cpp.py:
602         (_FileState.__init__): Add instance variable _is_objective_cpp to track whether a file has
603         extension mm (i.e. an Objective-C++ file).
604         (_FileState.is_objective_c_or_objective_cpp): Added; returns true if the file
605         has extension m or mm or if the file has extension h and contains Objective-C directives.
606         (check_for_null): No change in behavior; don't apply rule to Objective-C++ file.
607         (check_identifier_name_in_declaration): Substitute _FileState.is_objective_c_or_objective_cpp() for
608         _FileState.is_c_or_objective_c()
609         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
610         (WebKitStyleTest.test_null_false_zero): Added test case for Objective-C++ file.
611         (WebKitStyleTest.test_max_macro): Add test case for Objective-C and Objective-C++ file.
612         (WebKitStyleTest.test_min_macro): Ditto.
613         (WebKitStyleTest.test_wtf_move): Add test case for Objective-C++ file.
614
615 2014-07-14  Anders Carlsson  <andersca@apple.com>
616
617         Make shouldKeepCurrentBackForwardListItemInList part of WKPageLoaderClientV5 to avoid breaking ABI
618         https://bugs.webkit.org/show_bug.cgi?id=134889
619
620         Reviewed by Beth Dakin.
621
622         Bump loader version number to 5.
623
624         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
625         (TestWebKitAPI::setPageLoaderClient):
626         * WebKitTestRunner/TestController.cpp:
627         (WTR::TestController::createWebViewWithOptions):
628
629 2014-07-14  Daniel Bates  <dabates@apple.com>
630
631         Teach check-webkit-style to suggest WTF::move() when it sees std::move()
632         https://bugs.webkit.org/show_bug.cgi?id=134620
633
634         Reviewed by Joseph Pecoraro.
635
636         * Scripts/webkitpy/style/checkers/cpp.py:
637         (check_max_min_macros): Fix up comment so that it reads well.
638         (check_wtf_move): Added.
639         (check_style): Modified to call check_wtf_move().
640         (CppChecker): Add category "runtime/wtf_move".
641         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
642         (WebKitStyleTest.test_wtf_move): Added.
643
644 2014-07-12  Peter Szanka  <h868064@stud.u-szeged.hu>
645
646         Style checker complains about namespace indentation when there is no namespace
647         https://bugs.webkit.org/show_bug.cgi?id=105427
648
649         Reviewed by Darin Adler.
650
651         * Scripts/webkitpy/style/checkers/cpp.py:
652         (check_namespace_indentation):
653         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
654         (WebKitStyleTest.test_indentation):
655
656         The indentation level depends on the parantheses too, to avoid false warning in case of several statements inside macros.
657
658 2014-07-12  Daker Fernandes Pinheiro  <daker.pinheiro@openbossa.org>
659
660         Remove excessive nesting from _EnumState.process_clean_line at cpp style checker
661         https://bugs.webkit.org/show_bug.cgi?id=125317
662
663         Reviewed by Darin Adler.
664
665         * Scripts/webkitpy/style/checkers/cpp.py:
666         (_EnumState.process_clean_line):
667
668 2014-07-12  Brian Holt  <brian.holt@samsung.com>
669
670         Style Checker should prevent enums in bitfields
671         https://bugs.webkit.org/show_bug.cgi?id=57352
672
673         Reviewed by Darin Adler.
674
675         Added check that enums are not used as types for bitfields
676         and a unit test.
677
678         * Scripts/webkitpy/style/checkers/cpp.py:
679         (check_language):
680         (CppChecker):
681         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
682         (CppStyleTest):
683         (CppStyleTest.test_enum_bitfields):
684         (CppStyleTest.test_plain_integral_bitfields):
685
686 2014-07-10  Myles C. Maxfield  <mmaxfield@apple.com>
687
688         [iOS] Pasting rich content does not perform a two-step paste
689         https://bugs.webkit.org/show_bug.cgi?id=134795
690
691         Reviewed by Benjamin Poulain.
692
693         Two-step paste requires setting InputViewObeysDOMFocus on the UIWebBrowserView.
694
695         * DumpRenderTree/mac/DumpRenderTree.mm:
696         (createWebViewAndOffscreenWindow):
697
698 2014-07-10  Carlos Garcia Campos  <cgarcia@igalia.com> and Martin Robinson  <mrobinson@igalia.com>
699
700         [GTK][CMake] Add a 'distcheck' target
701         https://bugs.webkit.org/show_bug.cgi?id=130675
702
703         Reviewed by Gustavo Noronha Silva.
704
705         Add --check option to make-dist script that builds and installs the tarball.
706
707         * gtk/make-dist.py:
708         (Distcheck.__init__):
709         (Distcheck.extract_tarball): Extratc the tarball.
710         (Distcheck.configure): Run cmake.
711         (Distcheck.configure.create_dir): Helper function to create a directory.
712         (Distcheck.build): Run make.
713         (Distcheck.install): Run make install.
714         (Distcheck.clean): Clean up the extracted tarball.
715         (Distcheck.check): Run all previous methods in order.
716         * gtk/manifest.txt: Add missing file.
717
718 2014-07-10  Carlos Garcia Campos  <cgarcia@igalia.com>
719
720         [GTK] Use the same default options for production builds that previous stable releases
721         https://bugs.webkit.org/show_bug.cgi?id=134589
722
723         Reviewed by Martin Robinson.
724
725         Make sure all features enabled in production builds are also
726         enabled in developer mode.
727
728         * Scripts/webkitperl/FeatureList.pm: Enable ACCELERATED_2D_CANVAS
729         and CSS_FILTERS for the GTK port.
730
731 2014-07-09  Brent Fulgham  <bfulgham@apple.com>
732
733         [Win] Remove uses of 'bash' in build system
734         https://bugs.webkit.org/show_bug.cgi?id=134782
735         <rdar://problem/17615533>
736
737         Reviewed by Dean Jackson.
738
739         Remove uses of 'bash' by replacing Windows-specific bash scripts
740         with Perl equivalents.
741
742         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
743         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
744         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
745         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
746         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
747         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
748
749 2014-07-09  Brent Fulgham  <bfulgham@apple.com>
750
751         [Win] Remove use of 'grep' in build steps
752         https://bugs.webkit.org/show_bug.cgi?id=134770
753         <rdar://problem/17608783>
754
755         Reviewed by Tim Horton.
756
757         Replace uses of the grep command in Windows builds with the equivalent
758         Perl program.
759
760         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
761         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
762         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
763         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
764         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
765         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
766
767 2014-07-09  Commit Queue  <commit-queue@webkit.org>
768
769         Unreviewed, rolling out r170889.
770         https://bugs.webkit.org/show_bug.cgi?id=134754
771
772         This patch is wrong (Requested by philn on #webkit).
773
774         Reverted changeset:
775
776         "[GTK] Gstreamer missing from the install-dependencies script"
777         https://bugs.webkit.org/show_bug.cgi?id=134727
778         http://trac.webkit.org/changeset/170889
779
780 2014-07-08  Brian J. Burg  <burg@cs.washington.edu>
781
782         resolve-ChangeLogs fails when WebKit repository is a git submodule
783         https://bugs.webkit.org/show_bug.cgi?id=134734
784
785         Reviewed by David Kilzer.
786
787         When using resolve-ChangeLogs in a WebKit git repository with a
788         non-default arrangement of GIT_DIR and GIT_WORK_TREE, incorrect
789         paths are computed and the script fails mysteriously.
790
791         We were naively computing GIT_WORK_TREE as being one level above
792         GIT_DIR, but this is not the case for submodules or a manually
793         configured GIT_WORK_TREE or GIT_DIR location.
794
795         * Scripts/VCSUtils.pm:
796         (gitTreeDirectory): Added. Find the equivalent of GIT_WORK_TREE.
797         (determineVCSRoot): Calculate the working tree root directly.
798
799 2014-07-08  Tim Horton  <timothy_horton@apple.com>
800
801         [WK2] Expose a few drawing/compositing settings on WKPreferences(Private)
802         https://bugs.webkit.org/show_bug.cgi?id=134645
803
804         Reviewed by Dan Bernstein.
805
806         * MiniBrowser/mac/BrowserWindowController.h:
807         * MiniBrowser/mac/MainMenu.xib:
808         Add menu items for layer borders and the tiled scrolling indicator.
809
810         * MiniBrowser/mac/WK1BrowserWindowController.m:
811         (-[WK1BrowserWindowController validateMenuItem:]):
812         (-[WK1BrowserWindowController layerBordersAreVisible]):
813         (-[WK1BrowserWindowController toggleLayerBordersVisibility:]):
814         Add getters/setters/validators for layer borders.
815
816         * MiniBrowser/mac/WK2BrowserWindowController.m:
817         (-[WK2BrowserWindowController awakeFromNib]):
818         (-[WK2BrowserWindowController validateMenuItem:]):
819         (-[WK2BrowserWindowController layerBordersAreVisible]):
820         (-[WK2BrowserWindowController toggleLayerBordersVisibility:]):
821         (-[WK2BrowserWindowController tiledScrollingIndicatorIsVisible]):
822         (-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]):
823         Add getters/setters/validators for layer borders and the tiled scrolling indicator.
824
825         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
826         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
827         Remove the WebKit2 version of the subpixel metrics pref, because it doesn't work, because
828         nothing in WebKit2 reads this default, and there is no WebKit2 API for adjusting this preference.
829
830 2014-07-08  Adrian Perez de Castro  <aperez@igalia.com>
831
832         [GTK] Move user style sheet API out of WebKitWebViewGroup
833         https://bugs.webkit.org/show_bug.cgi?id=134551
834
835         Reviewed by Carlos Garcia Campos.
836
837         Removes testing user style sheet injection from
838         TestWebKitWebViewGroup and moves that into a new
839         TestWebKitUserContentManager, adapting the existing tests to the new
840         API. Also, it contains a new test case for
841         webkit_web_view_new_with_user_content_manager().
842
843         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
844         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: Added.
845         (UserContentManagerTest::UserContentManagerTest):
846         (testWebViewNewWithUserContentManager):
847         (isStyleSheetInjectedForURLAtPath):
848         (fillURLListFromPaths):
849         (removeOldInjectedStyleSheetsAndResetLists):
850         (testUserContentManagerInjectedStyleSheet):
851         (serverCallback):
852         (beforeAll):
853         (afterAll):
854         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
855         (beforeAll):
856         (afterAll):
857         (isStyleSheetInjectedForURLAtPath): Deleted.
858         (fillURLListFromPaths): Deleted.
859         (removeOldInjectedStyleSheetsAndResetLists): Deleted.
860         (testWebViewGroupInjectedStyleSheet): Deleted.
861         (serverCallback): Deleted.
862         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
863         (WebViewTest::WebViewTest):
864         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
865
866 2014-07-08  Ziran Sun  <ziran.sun@samsung.com>
867
868         [GTK] Gstreamer missing from the install-dependencies script
869         https://bugs.webkit.org/show_bug.cgi?id=134727
870
871         Reviewed by Mario Sanchez Prada.
872
873         Added missing gstreamer dependencies for debian based systems.
874
875         * gtk/install-dependencies: Added 2 dependencies for apt-get.
876
877 2014-07-08  Myles C. Maxfield  <mmaxfield@apple.com>
878
879         Add myself to the watchlist for text-related files
880         https://bugs.webkit.org/show_bug.cgi?id=134707
881
882         Reviewed by Timothy Horton.
883
884         * Scripts/webkitpy/common/config/watchlist:
885
886 2014-07-08  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
887
888         Add option to specify output file location in sunspider.
889         https://bugs.webkit.org/show_bug.cgi?id=134339
890
891         Reviewed by Darin Adler.
892
893         * Scripts/run-sunspider:
894
895 2014-07-07  Alex Christensen  <achristensen@webkit.org>
896
897         Unreviewed build fix.
898
899         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
900         Make Common.cpp excluded from both 32-bit and 64-bit builds.
901
902 2014-07-07  Simon Fraser  <simon.fraser@apple.com>
903
904         Have MiniBrowser log and reload if the Web Content Process crashes
905         https://bugs.webkit.org/show_bug.cgi?id=134691
906
907         Reviewed by Tim Horton.
908         
909         Implement _webViewWebProcessDidCrash, log and reload when the web process
910         crashes.
911
912         * MiniBrowser/mac/WK2BrowserWindowController.m:
913         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]):
914
915 2014-07-07  Alberto Garcia  <berto@igalia.com>
916
917         update-webkitgtk-libs script fails by unsatisfied dependencies
918         https://bugs.webkit.org/show_bug.cgi?id=134547
919
920         Reviewed by Martin Robinson.
921
922         Install libxcb-xfixes0-dev, needed to build Mesa.
923
924         * gtk/install-dependencies:
925
926 2014-07-06  Yoav Weiss  <yoav@yoav.ws>
927
928         Turn on img@sizes compile flag
929         https://bugs.webkit.org/show_bug.cgi?id=134634
930
931         Reviewed by Benjamin Poulain.
932
933         * Scripts/webkitperl/FeatureList.pm: Turn on the img@sizes feature.
934
935 2014-07-06  Hyowon Kim  <hw1008.kim@samsung.com>
936
937         Unreviewed. Adding myself to committers.
938
939         * Scripts/webkitpy/common/config/contributors.json:
940
941 2014-07-05  KwangHyuk Kim  <hyuki.kim@samsung.com>
942
943         [EFL] Add libgeoclue-dev to Tools/efl/install-dependencies.
944         https://bugs.webkit.org/show_bug.cgi?id=134648
945
946         Reviewed by Gyuyoung Kim.
947
948         As Geoclue is enabled for EFL, libgeoclue-dev is also added to Tools/efl/install-dependencies.
949
950         * efl/install-dependencies:
951
952 2014-07-04  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
953
954         [EFL] Support Geolocation
955         https://bugs.webkit.org/show_bug.cgi?id=134439
956
957         Reviewed by Antonio Gomes.
958
959         * Scripts/webkitperl/FeatureList.pm: Enable geolocation for EFL port.
960
961 2014-07-04  Shivakumar JM  <shiva.jm@samsung.com>
962
963         [EFL][WK2] Enhance the Minibrowser to show selected/highlighted text in search bar, if any.
964         https://bugs.webkit.org/show_bug.cgi?id=134485
965
966         Reviewed by Gyuyoung Kim.
967
968         Use script_execute_callback to get selected/highlighted text and show in search bar.
969
970         * MiniBrowser/efl/main.c:
971         (script_execute_callback):
972         (on_key_down):
973
974 2014-07-04  Dan Bernstein  <mitz@apple.com>
975
976         Build fix after r170811.
977
978         * MiniBrowser/mac/WK2BrowserWindowController.m:
979         (-[WK2BrowserWindowController reload:]):
980
981 2014-07-04  Timothy Horton  <timothy_horton@apple.com>
982
983         Typo in watchlist config means four specific people get Cc'd on everything
984         https://bugs.webkit.org/show_bug.cgi?id=134626
985
986         Reviewed by Gyuyoung Kim.
987
988         * Scripts/webkitpy/common/config/watchlist:
989         Remove leading pipe, which meant that this rule matched everything!
990
991 2014-07-03  Shivakumar JM  <shiva.jm@samsung.com>
992
993         [EFL][WK2] Enhance the Minibrowser to show text search count and close search bar.
994         https://bugs.webkit.org/show_bug.cgi?id=134486
995
996         Reviewed by Gyuyoung Kim.
997
998         Use on_search_close_button_clicked() callback to close search bar and on_search_text_found() callback to show search count.
999
1000         * MiniBrowser/efl/main.c:
1001         (search_box_show):
1002         (search_box_hide):
1003         (on_search_close_button_clicked):
1004         (on_search_text_found):
1005         (window_create):
1006
1007 2014-07-03  Daniel Bates  <dabates@apple.com>
1008
1009         Add WTF::move()
1010         https://bugs.webkit.org/show_bug.cgi?id=134500
1011
1012         Rubber-stamped by Anders Carlsson.
1013
1014         Substitute WTF::move() for std::move().
1015
1016         * DumpRenderTree/win/DRTDataObject.cpp:
1017         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1018         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1019         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1020         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1021         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1022         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added FIXME comments that explain that some of the sub-tests
1023         aren't actually testing move semantics in tests: MoveAssignmentFromSameType, MoveAssignmentFromSimilarType,
1024         ConstructionFromSameType, and ConstructionFromSimilarType.
1025         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1026
1027 2014-07-03  László Langó  <llango.u-szeged@partner.samsung.com>
1028
1029         [JavaScriptCore] Add --cmakeargs option to build-jsc.
1030         https://bugs.webkit.org/show_bug.cgi?id=134590
1031
1032         Reviewed by Ryosuke Niwa.
1033
1034         * Scripts/build-jsc:
1035
1036 2014-07-03  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1037
1038         Add option to specify jsc args in run-sunspider.
1039         https://bugs.webkit.org/show_bug.cgi?id=134341
1040
1041         Reviewed by Csaba Osztrogonác.
1042
1043         * Scripts/run-sunspider:
1044
1045 2014-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1046
1047         [GTK] Unreviewed gardening.
1048
1049         * Scripts/run-gtk-tests:
1050         (TestRunner): Report and mark flaky test WebKit2Gtk/TestCookieManager:persistent-storage
1051
1052 2014-07-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1053
1054         Clean up unused EFL buildbot information in BuildSlaveSupport and TestResultServer
1055         https://bugs.webkit.org/show_bug.cgi?id=134581
1056
1057         Reviewed by Tim Horton.
1058
1059         Should be removed unused EFL bot info.
1060
1061         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1062         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1063         (EWS):
1064         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1065         (WebKitBuildbot):
1066         * TestResultServer/static-dashboards/builders.jsonp:
1067         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1068         (test):
1069
1070 2014-07-02  Alex Christensen  <achristensen@webkit.org>
1071
1072         Unreviewed.  Moved self to reviewers list.
1073
1074         * Scripts/webkitpy/common/config/contributors.json:
1075         Moved self to reviewers list, added WebGL to expertise.
1076
1077 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1078
1079         [GTK] Make dist only works when run from the source directory
1080         https://bugs.webkit.org/show_bug.cgi?id=134543
1081
1082         Reviewed by Martin Robinson.
1083
1084         Since the paths in the manifest are relative to the source dir,
1085         and the script expects the current working directory to be the
1086         source directory, resolve all passed in relative paths while
1087         parsing the arguments and then change the current working
1088         directory.
1089
1090         * gtk/make-dist.py:
1091
1092 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1093
1094         [GTK] make dist is broken
1095         https://bugs.webkit.org/show_bug.cgi?id=134542
1096
1097         Reviewed by Martin Robinson.
1098
1099         * gtk/make-dist.py: Rename command line options to match what cmake uses.
1100         * gtk/manifest.txt: Remove WebKit1 references and add WebKitDOM documentation.
1101
1102 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1103
1104         [GTK] WebKitWebView::create should receive information about the navigation action
1105         https://bugs.webkit.org/show_bug.cgi?id=133680
1106
1107         Reviewed by Martin Robinson.
1108
1109         Add unit test to check the WebKitNavigationAction passed to
1110         WebKitWebView::create callback.
1111
1112         * MiniBrowser/gtk/BrowserWindow.c:
1113         (webViewCreate): Add WebKitNavigationAction parameter.
1114         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1115         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1116         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1117         (testWebViewCreateNavigationData):
1118         (beforeAll):
1119         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
1120         (createCallback):
1121
1122 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1123
1124         [GTK] Do not add forward declaration of class struct for interfaces
1125         https://bugs.webkit.org/show_bug.cgi?id=134297
1126
1127         Reviewed by Martin Robinson.
1128
1129         Add Iface symbol to documentation instead of Class for interfaces.
1130
1131         * gtk/webkitdom.py:
1132         (WebKitDOMDocGeneratorSections.write_section):
1133
1134 2014-07-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1135
1136         [GTK] XPathNSResolver should be exposed as an interface instead of as a class
1137         https://bugs.webkit.org/show_bug.cgi?id=134028
1138
1139         Reviewed by Gustavo Noronha Silva.
1140
1141         Add unit tests to check WebKitDOMXPathNSResolver API when using the
1142         native one and a user provided one.
1143
1144         * Scripts/webkitpy/style/checker.py: Add WebKitDOMXPathNSResolver
1145         to the list of GTK+ public API exceptions.
1146         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
1147         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: Added.
1148         (webkitXPathNSResolverLookupNamespaceURI):
1149         (webkitXPathNSResolverDOMXPathNSResolverIfaceInit):
1150         (webkit_xpath_ns_resolver_init):
1151         (webkit_xpath_ns_resolver_class_init):
1152         (WebKitDOMXPathNSResolverTest::create):
1153         (WebKitDOMXPathNSResolverTest::webPageFromArgs):
1154         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
1155         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1156         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1157         (WebKitDOMXPathNSResolverTest::runTest):
1158         (registerTests):
1159         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: Added.
1160         (runTest):
1161         (testWebKitDOMXPathNSResolverNative):
1162         (testWebKitDOMXPathNSResolverCustom):
1163         (serverCallback):
1164         (beforeAll):
1165         (afterAll):
1166         * gtk/webkitdom.py:
1167         (WebKitDOMDocGeneratorSections.write_section): Add
1168         WebKitDOMXPathNSResolver to the list of interfaces.
1169
1170 2014-07-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1171
1172         Fix build break on EFL and GTK ports since r170683
1173         https://bugs.webkit.org/show_bug.cgi?id=134536
1174
1175         Unreviewed, build fix.
1176
1177         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1178
1179 2014-07-01  Sam Weinig  <sam@webkit.org>
1180
1181         [Cocoa][Mac] WKWebView should automatically set topContentInset when beneath a toolbar
1182         <rdar://problem/17523159>
1183         https://bugs.webkit.org/show_bug.cgi?id=134496
1184
1185         Reviewed by Beth Dakin.
1186
1187         * MiniBrowser/mac/BrowserWindowController.m:
1188         (-[BrowserWindowController windowDidLoad]):
1189         Use the NSFullSizeContentViewWindowMask bit on Yosemite and later to enable toolbar blurring.
1190
1191 2014-07-01  Zan Dobersek  <zdobersek@igalia.com>
1192
1193         [CMake] Add necessary support for building for the Wayland target
1194         https://bugs.webkit.org/show_bug.cgi?id=134160
1195
1196         Reviewed by Darin Adler.
1197
1198         * CMakeLists.txt: Only build the TestNetscapePlugIn target in case
1199         the X11 windowing target is enabled.
1200
1201 2014-07-01  Chris Fleizach  <cfleizach@apple.com>
1202
1203         AX: HTML indeterminate IDL attribute not mapped to checkbox value=2
1204         https://bugs.webkit.org/show_bug.cgi?id=134492
1205
1206         Reviewed by Andreas Kling.
1207
1208         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1209         (AccessibilityUIElement::isIndeterminate):
1210         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1211         (WTR::AccessibilityUIElement::isIndeterminate):
1212
1213 2014-07-01  Daniel Bates  <dabates@apple.com>
1214
1215         Remove unnecessary calls to std::move()
1216         https://bugs.webkit.org/show_bug.cgi?id=134493
1217
1218         Reviewed by Anders Carlsson.
1219
1220         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1221         (TestWebKitAPI::TEST):
1222         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1223         (TestWebKitAPI::TEST):
1224
1225 2014-07-01  Pratik Solanki  <psolanki@apple.com>
1226
1227         Unreviewed. Adding myself to the reviewers list to make commit bot happy.
1228
1229         * Scripts/webkitpy/common/config/contributors.json:
1230
1231 2014-07-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1232
1233         webkit-patch apply-from-bug / apply-attachment should not ask for credentials if none are required
1234         https://bugs.webkit.org/show_bug.cgi?id=40095
1235
1236         Reviewed by Csaba Osztrogonác.
1237
1238         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1239         (Bugzilla.fetch_attachment_contents): make a first fetch on bugzilla without authentication. If failing, use authentication (similar to fetch_bug_dictionary).
1240         (Bugzilla):
1241         (Bugzilla.bug_id_for_attachment_id): ditto.
1242
1243 2014-07-01  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1244
1245         [webkitpy] Refactor pluralizer in grammar.py
1246         https://bugs.webkit.org/show_bug.cgi?id=133067
1247
1248         Reviewed by Csaba Osztrogonác.
1249
1250         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1251         (LayoutTestRunner.run_tests):
1252         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1253         (Manager.run):
1254         * Scripts/webkitpy/layout_tests/views/printing.py:
1255         (Printer.print_found):
1256         (Printer.print_workers_and_shards):
1257         (Printer._print_one_line_summary):
1258         * Scripts/webkitpy/test/printer.py:
1259         (Printer.print_result):
1260         * Scripts/webkitpy/tool/bot/feeders.py:
1261         (EWSFeeder.feed):
1262         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1263         (FlakyTestReporter._lookup_bug_for_flaky_test):
1264         * Scripts/webkitpy/tool/bot/irc_command.py:
1265         (Rollout._check_diff_failure):
1266         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1267         (IRCCommandTest.test_rollout):
1268         * Scripts/webkitpy/tool/commands/download.py:
1269         (AbstractPatchProcessingCommand._process_patch.execute):
1270         (ProcessBugsMixin._fetch_list_of_patches_to_process):
1271         (ProcessURLsMixin._fetch_list_of_patches_to_process):
1272         * Scripts/webkitpy/tool/commands/queries.py:
1273         (WhatBroke.execute):
1274         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1275         (SuggestNominations._print_nominations):
1276         (SuggestNominations._print_counts):
1277         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1278         (_make_options):
1279         (test_basic):
1280         (test_with_verbose):
1281         * Scripts/webkitpy/tool/commands/upload.py:
1282         (PostCommits.execute):
1283         * Scripts/webkitpy/tool/grammar.py:
1284         (pluralize):
1285         * Scripts/webkitpy/tool/grammar_unittest.py:
1286         (GrammarTest.test_join_with_separators):
1287         (GrammarTest):
1288         (GrammarTest.test_plural):
1289         (GrammarTest.test_pluralize):
1290         * Scripts/webkitpy/tool/multicommandtool.py:
1291         (Command.check_arguments_and_execute):
1292         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1293         (ObsoletePatches.run):
1294         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1295         (PrepareChangeLogForRevert._message_for_revert):
1296
1297 2014-06-30  Myles C. Maxfield  <mmaxfield@apple.com>
1298
1299         [iOS] GSFontAddCGFont is deprecated and we use it in DumpRenderTree
1300         https://bugs.webkit.org/show_bug.cgi?id=134133
1301
1302         Reviewed by Simon Fraser.
1303
1304         Replace it with CTFontManagerRegisterGraphicsFont
1305
1306         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1307         * DumpRenderTree/mac/DumpRenderTree.mm:
1308         (activateFontIOS):
1309
1310 2014-06-30  Michael Saboff  <msaboff@apple.com>
1311
1312         Add option to run-jsc-stress-testes to filter out tests that use large heaps
1313         https://bugs.webkit.org/show_bug.cgi?id=134458
1314
1315         Reviewed by Filip Pizlo.
1316
1317         Added new --memory-limited to filter out tests that have large heap usage.
1318         Such tests are either tagged with //@largeHeap or logic is added to their .yaml file.
1319
1320         * Scripts/run-jsc-stress-tests:
1321
1322 2014-06-30  Myles C. Maxfield  <mmaxfield@apple.com>
1323
1324         DRT in iOS sim crashes while loading fonts
1325         https://bugs.webkit.org/show_bug.cgi?id=134451
1326
1327         Reviewed by Geoffrey Garen.
1328
1329         The magic linker symbols had the same name, and were therefore being unified
1330         to a single font file. Then, adding the same file twice was failing.
1331
1332         * DumpRenderTree/mac/DumpRenderTree.mm:
1333         (activateFontsIOS):
1334
1335 2014-06-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1336
1337         Remove Qt cruft from webkitpy
1338         https://bugs.webkit.org/show_bug.cgi?id=134445
1339
1340         Reviewed by Csaba Osztrogonác.
1341
1342         * Scripts/webkitpy/common/config/ports.py:
1343         (DeprecatedPort.port):
1344         (QtPort): Deleted.
1345         (QtPort.build_webkit_command): Deleted.
1346         (QtPort.run_webkit_tests_command): Deleted.
1347         (QtWK2Port): Deleted.
1348         (QtWK2Port.build_webkit_command): Deleted.
1349         (QtWK2Port.run_webkit_tests_command): Deleted.
1350         * Scripts/webkitpy/common/config/ports_unittest.py:
1351         (DeprecatedPortTest): Deleted.
1352         (DeprecatedPortTest.test_qt_port): Deleted.
1353         (DeprecatedPortTest.test_qt_wk2_port): Deleted.
1354
1355 2014-06-29  Yoav Weiss  <yoav@yoav.ws>
1356
1357         Add support for HTMLImageElement's sizes attribute
1358         https://bugs.webkit.org/show_bug.cgi?id=133620
1359
1360         Reviewed by Dean Jackson.
1361
1362         Added an ENABLE_PICTURE_SIZES compile flag.
1363
1364         * Scripts/webkitperl/FeatureList.pm:
1365
1366 2014-06-27  Tim Horton  <timothy_horton@apple.com>
1367
1368         check-webkit-style should check the order of #imports as well as #includes
1369         https://bugs.webkit.org/show_bug.cgi?id=134428
1370
1371         Reviewed by Dan Bernstein.
1372
1373         * Scripts/webkitpy/style/checkers/cpp.py:
1374         Allow "import" in addition to "include", so that the sort order of headers in ObjC files is checked.
1375
1376 2014-06-27  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1377
1378         [EFL] Remove efl-wk2 from baseline search path
1379         https://bugs.webkit.org/show_bug.cgi?id=134391
1380
1381         Reviewed by Gyuyoung Kim.
1382
1383         As WebKit1 EFL is removed and platform/efl and platform/efl-wk2 baselines and test expectations files
1384         are merged efl-wk2 search path should be removed.
1385
1386         * Scripts/webkitpy/port/base.py:
1387         (Port.test_expectations_file_postion): Added method to determine port test expectations file position in expectations_dict.
1388         * Scripts/webkitpy/port/efl.py:
1389         (EflPort._search_paths): Changed baseline search paths from efl-wk2 -> wk2 -> efl -> generic is changed to: efl -> wk2 -> generic.
1390         (EflPort.test_expectations_file_postion): Added method to determine EFL port specific test expectation file position.
1391         * Scripts/webkitpy/port/port_testcase.py:
1392         (PortTestCase.test_expectations_ordering): Changed constant value to one returned from test_expectations_file_postion().
1393         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1394         (TestExpectationsTestCase.test_determine_port_from_expectations_path): Removed efl-wk2 test case.
1395         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1396         (TestRebaselineTest.test_baseline_directory): Changed directory name in assertion from platform/efl-wk2 to platform/efl.
1397
1398 2014-06-26  Dan Bernstein  <mitz@apple.com>
1399
1400         prepare-ChangeLog outputs (NS_ENUM): entries for Cocoa enums
1401         https://bugs.webkit.org/show_bug.cgi?id=134387
1402
1403         Reviewed by Tim Horton.
1404
1405         * Scripts/prepare-ChangeLog:
1406         (get_function_line_ranges_for_cpp): Don’t consider {CF,NS}_{ENUM,OPTIONS} as function names.
1407
1408 2014-06-26  Dan Bernstein  <mitz@apple.com>
1409
1410         prepare-ChangeLog mangles Objective-C selectors for methods with parameter types that contain colons
1411         https://bugs.webkit.org/show_bug.cgi?id=134383
1412
1413         Reviewed by Tim Horton.
1414
1415         * Scripts/prepare-ChangeLog:
1416         (method_decl_to_selector): Strip out the return type and parameter types before splitting at
1417         colons.
1418
1419 2014-06-26  Brady Eidson  <beidson@apple.com>
1420
1421         MiniBrowser should support a preference to override the default URL
1422         https://bugs.webkit.org/show_bug.cgi?id=134373
1423
1424         Reviewed by Darin Adler.
1425
1426         * MiniBrowser/mac/AppDelegate.m:
1427         (-[BrowserAppDelegate applicationDidFinishLaunching:]): See if there’s a pref
1428           overriding the default URL, and use it if there is.
1429
1430 2014-06-26  Brent Fulgham  <bfulgham@apple.com>
1431
1432         [Win] Fix potential buffer overrun in DLLLauncher
1433         https://bugs.webkit.org/show_bug.cgi?id=134351
1434         <rdar://problem/17469185>
1435
1436         Reviewed by Darin Adler.
1437
1438         * win/DLLLauncher/DLLLauncherMain.cpp: Correct error
1439         in end-of-buffer calculation.
1440
1441 2014-06-26  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1442
1443         [EFL] Missing dependency between freetype6 and fontconfig libs.
1444         https://bugs.webkit.org/show_bug.cgi?id=134190
1445
1446         Reviewed by Gyuyoung Kim.
1447
1448         The external dependencies contain the freetype6 and the fontconfig libs.
1449         The fontconfig lib requires freetype, but the dependency is not set in
1450         the efl/jhbuild.modules file. So, during building the external libs,
1451         fontconfig uses the freetype package of the system, while WebKit
1452         binaries will use freetype from the WebKitBuild/Dependency directory.
1453         There are more similar dependencies that were not indicated in the
1454         jhbuild.modules file.
1455
1456         * efl/jhbuild.modules:
1457           Added dependencies between libs.
1458
1459 2014-06-25  Brent Fulgham  <bfulgham@apple.com>
1460
1461         [Win] Expose Cache Information to WinLauncher
1462         https://bugs.webkit.org/show_bug.cgi?id=134318
1463
1464         Reviewed by Dean Jackson.
1465
1466         * WinLauncher/Common.cpp: Update for new dialog.
1467         * WinLauncher/WinLauncher.cpp: Add support for WebCache
1468         and WebCoreStatistics.
1469         * WinLauncher/WinLauncher.h:
1470         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
1471         Update for new Cache Dialog.
1472         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to
1473         WTF.lib
1474         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
1475         for new Dialog.
1476
1477 2014-06-26  Brent Fulgham  <bfulgham@apple.com>
1478
1479         [Win] Unreviewed gardening. Use consistent line-endings in file.
1480
1481         * WinLauncher/WinLauncher.h: Use '\n' EOL marker, not DOS-style
1482         '\r\n' EOL.
1483
1484 2014-06-25  László Langó  <llango.u-szeged@partner.samsung.com>
1485
1486         [JavaScriptCore] Make build-jsc output format better.
1487         https://bugs.webkit.org/show_bug.cgi?id=133547
1488
1489         Reviewed by Ryosuke Niwa.
1490
1491         * Scripts/build-jsc: Emit built time information on successful builds.
1492         (writeCongrats):
1493         * Scripts/build-webkit: Move formatBuildTime function into webkitdirs.pm.
1494         (cMakeArgsFromFeatures):
1495         (formatBuildTime): Deleted.
1496         * Scripts/webkitdirs.pm:
1497         (formatBuildTime):
1498
1499 2014-06-25  Chris Fleizach  <cfleizach@apple.com>
1500
1501         Add an undo group for each dictated utterance in WebKit
1502         https://bugs.webkit.org/show_bug.cgi?id=134086
1503
1504         Reviewed by Enrica Casucci.
1505
1506         Create a method for creating attributed strings with the undo insertion marker.
1507
1508         * DumpRenderTree/mac/TextInputController.m:
1509         (+[TextInputController isSelectorExcludedFromWebScript:]):
1510         (+[TextInputController webScriptNameForSelector:]):
1511         (-[TextInputController stringWithUndoGroupingInsertion:]):
1512
1513 2014-06-25  Michael Saboff  <msaboff@apple.com>
1514
1515         Provide javascript aware backtrace script for lldb
1516         https://bugs.webkit.org/show_bug.cgi?id=134276
1517
1518         Reviewed by Jer Noble.
1519
1520         * lldb/lldb_webkit.py:
1521         (__lldb_init_module):
1522         (btjs): New scripted command to display a backtrace that shows JavaScript frames with details.
1523
1524 2014-06-25  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1525
1526         REGRESSION (r170426) Broke two python tests
1527         https://bugs.webkit.org/show_bug.cgi?id=134299
1528
1529         Reviewed by Csaba Osztrogonác.
1530
1531         * Scripts/webkitpy/port/efl.py:
1532         (EflPort._search_paths): Added search path for efl-wk2.
1533
1534 2014-06-25  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1535
1536         [EFL] Remove WebKit1 related code from scripts
1537         https://bugs.webkit.org/show_bug.cgi?id=134195
1538
1539         Reviewed by Laszlo Gombos.
1540
1541         After removing WebKit1 from EFL port, still there is some code left related to DumpRenderTree, 
1542         EWebLauncher. Also running layout tests does not require adding -2/--webkit-test-runner switch.
1543
1544         * Scripts/run-launcher: MiniBrowser now runs as default without -2 switch.
1545         * Scripts/webkitdirs.pm:
1546         (builtDylibPathForName): Remove reference to libewebkit.so
1547         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1548         (_set_up_derived_options): Script runs WKTR by default.
1549         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1550         (PerfTestsRunner.__init__): Ditto.
1551         * Scripts/webkitpy/port/efl.py:
1552         (EflPort._search_paths): Remove efl-wk2 from baseline search path.
1553         (EflPort.show_results_html_file): Run MiniBrowser as result viewer.
1554
1555 2014-06-25  Laszlo Gombos  <l.gombos@samsung.com>
1556
1557         Remove build guard for progress element
1558         https://bugs.webkit.org/show_bug.cgi?id=134292
1559
1560         Reviewed by Benjamin Poulain.
1561
1562         * Scripts/webkitperl/FeatureList.pm:
1563
1564 2014-06-24  Tomas Popela  <tpopela@redhat.com>
1565
1566         [GTK] Some of DOM bindings macros are misnamed
1567         https://bugs.webkit.org/show_bug.cgi?id=121543
1568
1569         Reviewed by Carlos Garcia Campos.
1570
1571         As we are using WebKitDOM as a namespace we should unify all type macros
1572         to have WEBKIT_DOM_TYPE prefix instead of WEBKIT_TYPE_DOM. Also add
1573         more exceptions to decamelize function in GObject bindings generator
1574         to fix the names of bindings for BR, HR, UL, OL, DL and LI elements.
1575
1576         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
1577         * gtk/webkitdom.py:
1578         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
1579         (WebKitDOMDocGeneratorSections.write_section):
1580
1581 2014-06-24  Frédéric Wang  <fred.wang@free.fr>
1582
1583         [EFL] Install Latin Modern Math on the bots
1584         https://bugs.webkit.org/show_bug.cgi?id=134153
1585
1586         Reviewed by Gyuyoung Kim.
1587
1588         * efl/jhbuild.modules: Switch back to https://github.com/ for the webkitgtk-test-fonts.
1589
1590 2014-06-24  Frédéric Wang  <fred.wang@free.fr>
1591
1592         [EFL] [GTK] Use Latin Modern Math in the jhbuild environments.
1593         https://bugs.webkit.org/show_bug.cgi?id=134153
1594
1595         Reviewed by Martin Robinson.
1596
1597         * efl/jhbuild.modules: Use webkitgtk-test-fonts.git instead of the zip archive and upgrade to 0.0.5.
1598         * gtk/jhbuild.modules: Upgrade webkitgtk-test-fonts to 0.0.5.
1599
1600 2014-06-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1601
1602         Unreviewed, update my speciality.
1603
1604         * Scripts/webkitpy/common/config/contributors.json:
1605
1606 2014-06-24  Brent Fulgham  <bfulgham@apple.com>
1607
1608         [Win] Clean up and refactor WinLauncher
1609         https://bugs.webkit.org/show_bug.cgi?id=134209
1610
1611         Reviewed by Tim Thorton.
1612
1613         Relanding r170339 and r170340 with correct WinLauncher.h file.
1614
1615         * WinLauncher/Common.cpp: Copied from WinLauncher/WinLauncher.cpp.
1616         (PrintView):
1617         (ToggleMenuItem):
1618         (WndProc):
1619         (BackButtonProc):
1620         (ForwardButtonProc):
1621         (loadURL):
1622         (shouldUseFullDesktop): Deleted.
1623         (SimpleEventListener::SimpleEventListener): Deleted.
1624         (SimpleEventListener::handleEvent): Deleted.
1625         (WinLauncherWebHost::updateAddressBar): Deleted.
1626         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
1627         (WinLauncherWebHost::QueryInterface): Deleted.
1628         (WinLauncherWebHost::AddRef): Deleted.
1629         (WinLauncherWebHost::Release): Deleted.
1630         (updateMenuItemForHistoryItem): Deleted.
1631         (showLastVisitedSites): Deleted.
1632         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
1633         (resizeSubViews): Deleted.
1634         (setToDefaultPreferences): Deleted.
1635         (wWinMain): Deleted.
1636         (MyRegisterClass): Deleted.
1637         (LaunchInspector): Deleted.
1638         (NavigateForwardOrBackward): Deleted.
1639         (NavigateToHistory): Deleted.
1640         * WinLauncher/DOMDefaultImpl.cpp: Copied from WinLauncher/DOMDefaultImpl.h.
1641         (DOMEventListener::Release):
1642         (WebScriptObject::WebScriptObject): Deleted.
1643         (WebScriptObject::~WebScriptObject): Deleted.
1644         (WebScriptObject::throwException): Deleted.
1645         (WebScriptObject::callWebScriptMethod): Deleted.
1646         (WebScriptObject::evaluateWebScript): Deleted.
1647         (WebScriptObject::removeWebScriptKey): Deleted.
1648         (WebScriptObject::stringRepresentation): Deleted.
1649         (WebScriptObject::webScriptValueAtIndex): Deleted.
1650         (WebScriptObject::setWebScriptValueAtIndex): Deleted.
1651         (WebScriptObject::setException): Deleted.
1652         (DOMEventListener::throwException): Deleted.
1653         (DOMEventListener::callWebScriptMethod): Deleted.
1654         (DOMEventListener::evaluateWebScript): Deleted.
1655         (DOMEventListener::removeWebScriptKey): Deleted.
1656         (DOMEventListener::stringRepresentation): Deleted.
1657         (DOMEventListener::webScriptValueAtIndex): Deleted.
1658         (DOMEventListener::setWebScriptValueAtIndex): Deleted.
1659         (DOMEventListener::setException): Deleted.
1660         (DOMEventListener::handleEvent): Deleted.
1661         * WinLauncher/DOMDefaultImpl.h:
1662         (WebScriptObject::QueryInterface): Deleted.
1663         (WebScriptObject::AddRef): Deleted.
1664         (WebScriptObject::Release): Deleted.
1665         (DOMObject::QueryInterface): Deleted.
1666         (DOMEventListener::QueryInterface): Deleted.
1667         (DOMEventListener::AddRef): Deleted.
1668         (DOMEventListener::Release): Deleted.
1669         * WinLauncher/WinLauncher.cpp:
1670         (WinLauncher::WinLauncher):
1671         (WinLauncher::init):
1672         (WinLauncher::prepareViews):
1673         (WinLauncher::setFrameLoadDelegate):
1674         (WinLauncher::setUIDelegate):
1675         (WinLauncher::setAccessibilityDelegate):
1676         (WinLauncher::mainFrame):
1677         (WinLauncher::seedInitialDefaultPreferences):
1678         (WinLauncher::setToDefaultPreferences):
1679         (updateMenuItemForHistoryItem):
1680         (WinLauncher::showLastVisitedSites):
1681         (WinLauncher::launchInspector):
1682         (WinLauncher::navigateForwardOrBackward):
1683         (WinLauncher::navigateToHistory):
1684         (WinLauncher::goBack):
1685         (WinLauncher::goForward):
1686         (WinLauncher::loadURL):
1687         (shouldUseFullDesktop): Deleted.
1688         (SimpleEventListener::SimpleEventListener): Deleted.
1689         (SimpleEventListener::handleEvent): Deleted.
1690         (WinLauncherWebHost::updateAddressBar): Deleted.
1691         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
1692         (WinLauncherWebHost::QueryInterface): Deleted.
1693         (WinLauncherWebHost::AddRef): Deleted.
1694         (WinLauncherWebHost::Release): Deleted.
1695         (showLastVisitedSites): Deleted.
1696         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
1697         (resizeSubViews): Deleted.
1698         (subclassForLayeredWindow): Deleted.
1699         (computeFullDesktopFrame): Deleted.
1700         (DllMain): Deleted.
1701         (getAppDataFolder): Deleted.
1702         (setToDefaultPreferences): Deleted.
1703         (setCacheFolder): Deleted.
1704         (createCrashReport): Deleted.
1705         (wWinMain): Deleted.
1706         (MyRegisterClass): Deleted.
1707         (AbortProc): Deleted.
1708         (getPrinterDC): Deleted.
1709         (initDocStruct): Deleted.
1710         (PrintView): Deleted.
1711         (ToggleMenuItem): Deleted.
1712         (LaunchInspector): Deleted.
1713         (NavigateForwardOrBackward): Deleted.
1714         (NavigateToHistory): Deleted.
1715         (WndProc): Deleted.
1716         (EditProc): Deleted.
1717         (BackButtonProc): Deleted.
1718         (ForwardButtonProc): Deleted.
1719         (About): Deleted.
1720         (loadURL): Deleted.
1721         (dllLauncherEntryPoint): Deleted.
1722         * WinLauncher/WinLauncher.h:
1723         (WinLauncher::standardPreferences):
1724         (WinLauncher::privatePreferences):
1725         (WinLauncher::hasWebView):
1726         (WinLauncher::usesLayeredWebView):
1727         (WinLauncherWebHost::WinLauncherWebHost): Deleted.
1728         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
1729         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame): Deleted.
1730         (WinLauncherWebHost::didCommitLoadForFrame): Deleted.
1731         (WinLauncherWebHost::didReceiveTitle): Deleted.
1732         (WinLauncherWebHost::didChangeIcons): Deleted.
1733         (WinLauncherWebHost::didReceiveIcon): Deleted.
1734         (WinLauncherWebHost::didFailLoadWithError): Deleted.
1735         (WinLauncherWebHost::didChangeLocationWithinPageForFrame): Deleted.
1736         (WinLauncherWebHost::willPerformClientRedirectToURL): Deleted.
1737         (WinLauncherWebHost::didCancelClientRedirectForFrame): Deleted.
1738         (WinLauncherWebHost::willCloseFrame): Deleted.
1739         (WinLauncherWebHost::windowScriptObjectAvailable): Deleted.
1740         (WinLauncherWebHost::didClearWindowObject): Deleted.
1741         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1742         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1743         * WinLauncher/WinLauncherReplace.h:
1744         (processCrashReport):
1745         * WinLauncher/WinLauncherWebHost.cpp: Copied from WinLauncher/WinLauncher.cpp.
1746         (WinLauncherWebHost::updateAddressBar):
1747         (WinLauncherWebHost::QueryInterface):
1748         (WinLauncherWebHost::AddRef):
1749         (WinLauncherWebHost::Release):
1750         (WinLauncherWebHost::didFinishLoadForFrame):
1751         (shouldUseFullDesktop): Deleted.
1752         (updateMenuItemForHistoryItem): Deleted.
1753         (showLastVisitedSites): Deleted.
1754         (resizeSubViews): Deleted.
1755         (subclassForLayeredWindow): Deleted.
1756         (computeFullDesktopFrame): Deleted.
1757         (DllMain): Deleted.
1758         (getAppDataFolder): Deleted.
1759         (setToDefaultPreferences): Deleted.
1760         (setCacheFolder): Deleted.
1761         (createCrashReport): Deleted.
1762         (wWinMain): Deleted.
1763         (MyRegisterClass): Deleted.
1764         (AbortProc): Deleted.
1765         (getPrinterDC): Deleted.
1766         (initDocStruct): Deleted.
1767         (PrintView): Deleted.
1768         (ToggleMenuItem): Deleted.
1769         (LaunchInspector): Deleted.
1770         (NavigateForwardOrBackward): Deleted.
1771         (NavigateToHistory): Deleted.
1772         (WndProc): Deleted.
1773         (EditProc): Deleted.
1774         (BackButtonProc): Deleted.
1775         (ForwardButtonProc): Deleted.
1776         (About): Deleted.
1777         (loadURL): Deleted.
1778         (dllLauncherEntryPoint): Deleted.
1779         * WinLauncher/WinLauncherWebHost.h: Copied from WinLauncher/WinLauncher.h.
1780         (WinLauncherWebHost::WinLauncherWebHost):
1781         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
1782         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
1783         (WinLauncherWebHost::didCommitLoadForFrame):
1784         (WinLauncherWebHost::didReceiveTitle):
1785         (WinLauncherWebHost::didChangeIcons):
1786         (WinLauncherWebHost::didReceiveIcon):
1787         (WinLauncherWebHost::didFailLoadWithError):
1788         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
1789         (WinLauncherWebHost::willPerformClientRedirectToURL):
1790         (WinLauncherWebHost::didCancelClientRedirectForFrame):
1791         (WinLauncherWebHost::willCloseFrame):
1792         (WinLauncherWebHost::windowScriptObjectAvailable):
1793         (WinLauncherWebHost::didClearWindowObject):
1794         * WinLauncher/WinMain.cpp: Copied from WinLauncher/WinLauncher.cpp.
1795         (wWinMain):
1796         (MyRegisterClass):
1797         (shouldUseFullDesktop): Deleted.
1798         (SimpleEventListener::SimpleEventListener): Deleted.
1799         (SimpleEventListener::handleEvent): Deleted.
1800         (WinLauncherWebHost::updateAddressBar): Deleted.
1801         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
1802         (WinLauncherWebHost::QueryInterface): Deleted.
1803         (WinLauncherWebHost::AddRef): Deleted.
1804         (WinLauncherWebHost::Release): Deleted.
1805         (updateMenuItemForHistoryItem): Deleted.
1806         (showLastVisitedSites): Deleted.
1807         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
1808         (resizeSubViews): Deleted.
1809         (subclassForLayeredWindow): Deleted.
1810         (computeFullDesktopFrame): Deleted.
1811         (DllMain): Deleted.
1812         (getAppDataFolder): Deleted.
1813         (setToDefaultPreferences): Deleted.
1814         (setCacheFolder): Deleted.
1815         (createCrashReport): Deleted.
1816         (AbortProc): Deleted.
1817         (getPrinterDC): Deleted.
1818         (initDocStruct): Deleted.
1819         (PrintView): Deleted.
1820         (ToggleMenuItem): Deleted.
1821         (LaunchInspector): Deleted.
1822         (NavigateForwardOrBackward): Deleted.
1823         (NavigateToHistory): Deleted.
1824         (WndProc): Deleted.
1825         (EditProc): Deleted.
1826         (BackButtonProc): Deleted.
1827         (ForwardButtonProc): Deleted.
1828         (About): Deleted.
1829         (loadURL): Deleted.
1830         (dllLauncherEntryPoint): Deleted.
1831
1832 2014-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
1833
1834         [iOS] getsectdata() is deprecated and we use it in DRT
1835         https://bugs.webkit.org/show_bug.cgi?id=134122
1836
1837         Reviewed by Alexey Proskuryakov.
1838
1839         Migrate to using magic linker symbols.
1840
1841         No tests because there should be no behavior change
1842
1843         * DumpRenderTree/mac/DumpRenderTree.mm:
1844         (activateFontsIOS):
1845
1846 2014-06-24  Javier Fernandez  <jfernandez@igalia.com>
1847
1848         Name moving. Unreviewed.
1849
1850         * Scripts/webkitpy/common/config/contributors.json:
1851
1852 2014-06-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1853
1854         Remove EFL WK1 watch category
1855         https://bugs.webkit.org/show_bug.cgi?id=134231
1856
1857         Reviewed by Csaba Osztrogonác.
1858
1859         * Scripts/webkitpy/common/config/watchlist: Removed EFL WK1 category.
1860
1861 2014-06-24  Krzysztof Czech  <k.czech@samsung.com>
1862
1863         [ATK] Remove some unused code from DumpRenderTree
1864         https://bugs.webkit.org/show_bug.cgi?id=134191
1865
1866         Reviewed by Chris Fleizach.
1867
1868         DumpRenderTree's accessibility code could be removed since GTK and EFL has stopped supporting WK1.
1869
1870         * DumpRenderTree/atk/AccessibilityCallbacks.h: Removed.
1871         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Removed.
1872         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp: Removed.
1873         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Removed.
1874         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Removed.
1875         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Removed.
1876
1877 2014-06-23  Shivakumar JM  <shiva.jm@samsung.com>
1878
1879         [EFL][WK2] Search field is not shown properly on doing ctrl+f on Minibrowser.
1880         https://bugs.webkit.org/show_bug.cgi?id=134025
1881
1882         Reviewed by Gyuyoung Kim.
1883
1884         Use EVAS_HINT_FILL in evas_object_size_hint_align_set() api.
1885
1886         * MiniBrowser/efl/main.c:
1887         (window_create):
1888
1889 2014-06-23  Ryuan Choi  <ryuan.choi@samsung.com>
1890
1891         [EFL] Replace RefPtr<Evas_Object> with UniquePtrEfl
1892         https://bugs.webkit.org/show_bug.cgi?id=134236
1893
1894         Reviewed by Gyuyoung Kim.
1895
1896         * ImageDiff/efl/ImageDiff.cpp:
1897         (calculateDifference):
1898         (printImageDifferences):
1899         (readImageFromStdin):
1900         (main):
1901
1902 2014-06-23  Daniel Bates  <dabates@apple.com>
1903
1904         Rolling out r170340 and r170339.
1905
1906         Changeset r170339 broke the Apple Windows Debug and Release builds.
1907
1908         Reverted changesets:
1909
1910         "[Win] Build fix after r134209"
1911         http://trac.webkit.org/changeset/170340
1912
1913         "[Win] Clean up and refactor WinLauncher"
1914         https://bugs.webkit.org/show_bug.cgi?id=134209
1915         http://trac.webkit.org/changeset/170339
1916
1917 2014-06-23  Brent Fulgham  <bfulgham@apple.com>
1918
1919         [Win] Build fix after r134209
1920
1921         * WinLauncher/WinMain.cpp: Must include the resources file
1922         before Common.cpp.
1923
1924 2014-06-23  Brent Fulgham  <bfulgham@apple.com>
1925
1926         [Win] Clean up and refactor WinLauncher
1927         https://bugs.webkit.org/show_bug.cgi?id=134209
1928
1929         Reviewed by Tim Horton.
1930
1931         Make WinLauncher a class, and move all non-class driver functions
1932         into "Common.cpp" and "WinMain.cpp". These files are distinct
1933         to allow some internal tools to reuse the code in 'Common'.
1934
1935         * WinLauncher/Common.cpp: Added. Consists of code moved from
1936         'WinLauncher.cpp' that can be reused for other tools.
1937         (subclassForLayeredWindow):
1938         (computeFullDesktopFrame):
1939         (DllMain):
1940         (getAppDataFolder):
1941         (setCacheFolder):
1942         (createCrashReport):
1943         (AbortProc):
1944         (getPrinterDC):
1945         (initDocStruct):
1946         (PrintView):
1947         (ToggleMenuItem):
1948         (WndProc):
1949         (EditProc):
1950         (BackButtonProc):
1951         (ForwardButtonProc):
1952         (About):
1953         (loadURL):
1954         (dllLauncherEntryPoint):
1955         * WinLauncher/DOMDefaultImpl.cpp: Copied from WinLauncher/DOMDefaultImpl.h.
1956         (DOMEventListener::Release):
1957         (WebScriptObject::WebScriptObject): Deleted.
1958         (WebScriptObject::~WebScriptObject): Deleted.
1959         (WebScriptObject::throwException): Deleted.
1960         (WebScriptObject::callWebScriptMethod): Deleted.
1961         (WebScriptObject::evaluateWebScript): Deleted.
1962         (WebScriptObject::removeWebScriptKey): Deleted.
1963         (WebScriptObject::stringRepresentation): Deleted.
1964         (WebScriptObject::webScriptValueAtIndex): Deleted.
1965         (WebScriptObject::setWebScriptValueAtIndex): Deleted.
1966         (WebScriptObject::setException): Deleted.
1967         (DOMEventListener::throwException): Deleted.
1968         (DOMEventListener::callWebScriptMethod): Deleted.
1969         (DOMEventListener::evaluateWebScript): Deleted.
1970         (DOMEventListener::removeWebScriptKey): Deleted.
1971         (DOMEventListener::stringRepresentation): Deleted.
1972         (DOMEventListener::webScriptValueAtIndex): Deleted.
1973         (DOMEventListener::setWebScriptValueAtIndex): Deleted.
1974         (DOMEventListener::setException): Deleted.
1975         (DOMEventListener::handleEvent): Deleted.
1976         * WinLauncher/DOMDefaultImpl.h:
1977         (WebScriptObject::QueryInterface): Deleted.
1978         (WebScriptObject::AddRef): Deleted.
1979         (WebScriptObject::Release): Deleted.
1980         (DOMObject::QueryInterface): Deleted.
1981         (DOMEventListener::QueryInterface): Deleted.
1982         (DOMEventListener::AddRef): Deleted.
1983         (DOMEventListener::Release): Deleted.
1984         * WinLauncher/WinLauncher.cpp: Converted stand-alone implementation
1985         into a C++ class and removed WinAPI code.
1986         (WinLauncher::WinLauncher):
1987         (WinLauncher::init):
1988         (WinLauncher::prepareViews):
1989         (WinLauncher::setFrameLoadDelegate):
1990         (WinLauncher::setUIDelegate):
1991         (WinLauncher::setAccessibilityDelegate):
1992         (WinLauncher::mainFrame):
1993         (WinLauncher::seedInitialDefaultPreferences):
1994         (WinLauncher::setToDefaultPreferences):
1995         (updateMenuItemForHistoryItem):
1996         (WinLauncher::showLastVisitedSites):
1997         (WinLauncher::launchInspector):
1998         (WinLauncher::navigateForwardOrBackward):
1999         (WinLauncher::navigateToHistory):
2000         (WinLauncher::goBack):
2001         (WinLauncher::goForward):
2002         (WinLauncher::loadURL):
2003         (shouldUseFullDesktop): Deleted.
2004         (SimpleEventListener::SimpleEventListener): Deleted.
2005         (SimpleEventListener::handleEvent): Deleted.
2006         (WinLauncherWebHost::updateAddressBar): Deleted.
2007         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
2008         (WinLauncherWebHost::QueryInterface): Deleted.
2009         (WinLauncherWebHost::AddRef): Deleted.
2010         (WinLauncherWebHost::Release): Deleted.
2011         (showLastVisitedSites): Deleted.
2012         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
2013         (resizeSubViews): Deleted.
2014         (subclassForLayeredWindow): Deleted.
2015         (computeFullDesktopFrame): Deleted.
2016         (DllMain): Deleted.
2017         (getAppDataFolder): Deleted.
2018         (setToDefaultPreferences): Deleted.
2019         (setCacheFolder): Deleted.
2020         (createCrashReport): Deleted.
2021         (wWinMain): Deleted.
2022         (MyRegisterClass): Deleted.
2023         (AbortProc): Deleted.
2024         (getPrinterDC): Deleted.
2025         (initDocStruct): Deleted.
2026         (PrintView): Deleted.
2027         (ToggleMenuItem): Deleted.
2028         (LaunchInspector): Deleted.
2029         (NavigateForwardOrBackward): Deleted.
2030         (NavigateToHistory): Deleted.
2031         (WndProc): Deleted.
2032         (EditProc): Deleted.
2033         (BackButtonProc): Deleted.
2034         (ForwardButtonProc): Deleted.
2035         (About): Deleted.
2036         (loadURL): Deleted.
2037         (dllLauncherEntryPoint): Deleted.
2038         * WinLauncher/WinLauncher.h: Removed.
2039         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2040         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
2041         * WinLauncher/WinLauncherReplace.h:
2042         (processCrashReport):
2043         * WinLauncher/WinLauncherWebHost.cpp: Added.
2044         (SimpleEventListener::SimpleEventListener):
2045         (SimpleEventListener::handleEvent):
2046         (WinLauncherWebHost::updateAddressBar):
2047         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2048         (WinLauncherWebHost::QueryInterface):
2049         (WinLauncherWebHost::AddRef):
2050         (WinLauncherWebHost::Release):
2051         (WinLauncherWebHost::didFinishLoadForFrame):
2052         * WinLauncher/WinLauncherWebHost.h: Copied from WinLauncher/WinLauncher.h.
2053         Moved WinLauncherWebHost implementation from WinLauncher.cpp into
2054         its own set of files.
2055         (WinLauncherWebHost::WinLauncherWebHost):
2056         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
2057         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
2058         (WinLauncherWebHost::didCommitLoadForFrame):
2059         (WinLauncherWebHost::didReceiveTitle):
2060         (WinLauncherWebHost::didChangeIcons):
2061         (WinLauncherWebHost::didReceiveIcon):
2062         (WinLauncherWebHost::didFailLoadWithError):
2063         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
2064         (WinLauncherWebHost::willPerformClientRedirectToURL):
2065         (WinLauncherWebHost::didCancelClientRedirectForFrame):
2066         (WinLauncherWebHost::willCloseFrame):
2067         (WinLauncherWebHost::windowScriptObjectAvailable):
2068         (WinLauncherWebHost::didClearWindowObject):
2069         * WinLauncher/WinMain.cpp: Added. This consists of code from
2070         WinLauncher that is unique to the WinLauncher utility, and is
2071         not part of the WinLauncher class.
2072         (wWinMain):
2073         (MyRegisterClass):
2074
2075 2014-06-23  Simon Fraser  <simon.fraser@apple.com>
2076
2077         Enable the Web Inspector in MiniBrowser
2078         https://bugs.webkit.org/show_bug.cgi?id=134148
2079
2080         Reviewed by Joseph Pecoraro.
2081         
2082         Set the pref to enable Web Inspector in both WK1 and WK2 windows.
2083
2084         * MiniBrowser/mac/AppDelegate.m:
2085         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2086
2087 2014-06-21  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2088
2089         Disable gamepad feature on EFL and GTK ports by default
2090         https://bugs.webkit.org/show_bug.cgi?id=134169
2091
2092         Reviewed by Brady Eidson.
2093
2094         EFL and GTK ports disabled Gamepad feature now. Besides current implementation
2095         was treated to 'deprecated' status.
2096
2097         ENABLE_GAMEPAD_DEPRECATED is disabled for now. There is build break on EFL port.
2098
2099         * Scripts/webkitperl/FeatureList.pm:
2100
2101 2014-06-21  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2102
2103         [Inspector][EFL] Can't resume a special break point on EFL inspector
2104         https://bugs.webkit.org/show_bug.cgi?id=129294
2105
2106         Reviewed by Gyuyoung Kim.
2107
2108         Patch our EFL 1.9 with the fix landed in upstream EFL 1.10
2109         by Ryuan Choi - <https://phab.enlightenment.org/D790>
2110
2111         * efl/jhbuild.modules:
2112         * efl/patches/ecore.patch: Added.
2113
2114 2014-06-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2115
2116         Removing PAGE_VISIBILITY_API compile guard.
2117         https://bugs.webkit.org/show_bug.cgi?id=133844
2118
2119         Reviewed by Gavin Barraclough.
2120
2121         * Scripts/webkitperl/FeatureList.pm:
2122
2123 2014-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
2124
2125         [EFL] Remove DumpRenderTree/efl and EWebLauncher
2126         https://bugs.webkit.org/show_bug.cgi?id=134138
2127
2128         Reviewed by Gyuyoung Kim.
2129
2130         DumpRenderTree/efl and EWebLauncher are not necessary anymore because WebKit1 EFL will be removed.
2131
2132         * CMakeLists.txt:
2133         * DumpRenderTree/PlatformEfl.cmake: Removed.
2134         * DumpRenderTree/efl: Removed entire directory.
2135         * EWebLauncher: Ditto.
2136         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Renamed from Tools/DumpRenderTree/efl/FontManagement.cpp.
2137         (buildPath):
2138         (getCoreFontFiles):
2139         (addFontDirectory):
2140         (addFontFiles):
2141         (getCustomBuildDir):
2142         (getPlatformFontsPath):
2143         (addFontsToEnvironment):
2144         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Renamed from Tools/DumpRenderTree/efl/FontManagement.h.
2145         * WebKitTestRunner/PlatformEfl.cmake:
2146
2147 2014-06-20  Zalan Bujtas  <zalan@apple.com>
2148
2149         Name moving. Unreviewed.
2150
2151         * Scripts/webkitpy/common/config/contributors.json:
2152
2153 2014-06-20  Javier Fernandez  <jfernandez@igalia.com>
2154
2155         Unreviewed. Adding myself to committers.
2156
2157         * Scripts/webkitpy/common/config/contributors.json:
2158
2159 2014-06-20  Yusuke Suzuki  <utatane.tea@gmail.com>
2160
2161         Unreviewed. Adding myself to committers.
2162
2163         * Scripts/webkitpy/common/config/contributors.json:
2164
2165 2014-06-20  Tim Horton  <timothy_horton@apple.com>
2166
2167         Make WebKit2 more accessible in MiniBrowser
2168         https://bugs.webkit.org/show_bug.cgi?id=134099
2169
2170         Reviewed by Anders Carlsson.
2171
2172         * MiniBrowser/mac/AppDelegate.h:
2173         * MiniBrowser/mac/AppDelegate.m:
2174         (-[BrowserAppDelegate newWindow:]):
2175         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2176         (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]):
2177         (-[BrowserAppDelegate _useWebKit2ByDefault]):
2178         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2179         (-[BrowserAppDelegate validateMenuItem:]):
2180         * MiniBrowser/mac/MainMenu.xib:
2181         Add a "Use WebKit2 By Default" menu item to the top of the Debug menu.
2182         When switched on, Cmd-N will make WebKit2 windows (and the default window will be WebKit2).
2183         Make the non-default new-window menu item always show up, because people often don't find it
2184         when you have to press option to have it show up.
2185
2186         * MiniBrowser/mac/BrowserWindowController.h:
2187         * MiniBrowser/mac/BrowserWindowController.m:
2188         (-[BrowserWindowController initWithWindow:]):
2189         
2190         * MiniBrowser/mac/WK1BrowserWindowController.m:
2191         (-[WK1BrowserWindowController validateMenuItem:]):
2192         * MiniBrowser/mac/WK2BrowserWindowController.m:
2193         (-[WK2BrowserWindowController validateMenuItem:]):
2194         Use the cached [menuItem action] like the earlier cases do.
2195
2196 2014-06-20  Daniel Bates  <dabates@apple.com>
2197
2198         Teach run-{safari, webkit-app} about iOS Simulator
2199         https://bugs.webkit.org/show_bug.cgi?id=133986
2200
2201         Reviewed by David Kilzer.
2202
2203         Extract the logic from old-run-webkit-tests to install and launch {DumpRenderTree, WebKitTestRunnerApp}.app
2204         into general-purpose routines in webkitdirs.pm so that they can be used both by script old-run-webkit-tests
2205         and run-safari.
2206
2207         * Scripts/old-run-webkit-tests:
2208         (installAndLaunchDumpToolAppUsingNotification): Extracted logic to install and launch {DumpRenderTree,
2209         WebKitTestRunnerApp}.app into webkitdirs::installAndLaunchIOSWebKitAppInSimulator() and modified code
2210         to call it.
2211         (openIPhoneSimulator): Deleted; moved logic to webkitdirs::openIOSSimulator().
2212         (quitIPhoneSimulator): Deleted; moved logic to webkitdirs::quitIOSSimulator().
2213         * Scripts/run-webkit-app: Modified to call runIOSWebKitApp() when the iOS simulator SDK is used
2214         (say, by specifying the optional command-line argument --simulator). For now, die() with an error
2215         when the iOS device SDK is used as we don't support launching an app on the device at this time.
2216         * Scripts/webkitdirs.pm:
2217         (xcodeSDKVersion): Added.
2218         (setupIOSWebKitEnvironment): Added.
2219         (installedMobileSafariBundle): Added.
2220         (mobileSafariBundle): Added.
2221         (plistPathFromBundle): Added.
2222         (appIdentiferFromBundle): Added.
2223         (appDisplayNameFromBundle): Added.
2224         (loadIPhoneSimulatorNotificationIfNeeded): Added.
2225         (openIOSSimulator): Added.
2226         (quitIOSSimulator): Added.
2227         (iosSimulatorDeviceByName): Added.
2228         (iosSimulatorRuntime): Added.
2229         (findOrCreateSimulatorForIOSDevice): Added.
2230         (runIOSWebKitAppInSimulator): Added.
2231         (installAndLaunchIOSWebKitAppInSimulator): Added.
2232         (runIOSWebKitApp): Added.
2233         (runSafari): Modified to call runIOSWebKitAppInSimulator() the iOS simulator SDK is used. For now,
2234         die() with an error when the iOS device SDK is used as we don't support launching Safari on the
2235         device at this time.
2236
2237 2014-06-19  Anders Carlsson  <andersca@apple.com>
2238
2239         Add WTF::Optional class
2240         https://bugs.webkit.org/show_bug.cgi?id=134083
2241
2242         Reviewed by Andreas Kling.
2243
2244         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2245         * TestWebKitAPI/Tests/WTF/Optional.cpp: Added.
2246         (TestWebKitAPI::TEST):
2247
2248 2014-06-20  Ion Rosca  <rosca@adobe.com>
2249
2250         Unreviewed. Adding myself to Committers list.
2251
2252         * Scripts/webkitpy/common/config/contributors.json:
2253
2254 2014-06-20  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2255
2256         [EFL] Add gstreamer as dependecy of EFL after r169785
2257         https://bugs.webkit.org/show_bug.cgi?id=134066
2258
2259         Reviewed by Gyuyoung Kim.
2260
2261         * efl/jhbuild.modules:
2262
2263 2014-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
2264
2265         [EFL] Merge url_utils.c to MiniBrowser
2266         https://bugs.webkit.org/show_bug.cgi?id=134095
2267
2268         Reviewed by Csaba Osztrogonác.
2269
2270         url_utils.c is simple code to share between EWebLauncher and MiniBrowser.
2271         This patch removes the dependency of url_utils.c from MiniBrowser to drop WebKit1 EFL port.
2272
2273         * MiniBrowser/efl/CMakeLists.txt:
2274         Remove the EWebLauncher/ from the includes and url_utils.h from the source lists.
2275         * MiniBrowser/efl/main.c:
2276         (has_scheme): Copied from url_utils.c
2277         (url_from_user_input): Ditto.
2278
2279 2014-06-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2280
2281         Fix webkitpy tests after EFL WK1 buildbot and EWS removal - r170172.
2282
2283         Reviewed by Csaba Osztrogonác.
2284
2285         * Scripts/webkitpy/common/config/ports_unittest.py:
2286         (DeprecatedPortTest.test_gtk_wk2_port):
2287         (DeprecatedPortTest.test_efl_port): Deleted.
2288         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2289         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2290         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2291         (TestRebaselineExpectations.test_rebaseline_expectations):
2292
2293 2014-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
2294
2295         [EFL][CMAKE] Disable WebKit1 build as a default
2296         https://bugs.webkit.org/show_bug.cgi?id=134093
2297
2298         Reviewed by Gyuyoung Kim.
2299
2300         * CMakeLists.txt:
2301
2302 2014-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2303
2304         [GTK] webkit_dom_document_create_tree_walker impossible to use due to WebKitDOMNodeFilter
2305         https://bugs.webkit.org/show_bug.cgi?id=93002
2306
2307         Reviewed by Gustavo Noronha Silva.
2308
2309         Add unit tests to check WebKitDOMNodefilter API used from both
2310         TreeWalker and NodeIterator.
2311
2312         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+
2313         public headers and add WebKitDOMNodeFilter to the list of exceptions.
2314         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
2315         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: Added.
2316         (webkitNodeFilterAcceptNode):
2317         (webkitNodeFilterDOMNodeFilterIfaceInit):
2318         (webkit_node_filter_init):
2319         (webkit_node_filter_class_init):
2320         (WebKitDOMNodeFilterTest::create):
2321         (WebKitDOMNodeFilterTest::webPageFromArgs):
2322         (WebKitDOMNodeFilterTest::testTreeWalker):
2323         (WebKitDOMNodeFilterTest::testNodeIterator):
2324         (WebKitDOMNodeFilterTest::runTest):
2325         (registerTests):
2326         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: Added.
2327         (runTest):
2328         (testWebKitDOMNodeFilterTreeWalker):
2329         (testWebKitDOMNodeFilterNodeIterator):
2330         (beforeAll):
2331         (afterAll):
2332         * gtk/webkitdom.py:
2333         (WebKitDOMDocGeneratorSections.__init__):
2334         (WebKitDOMDocGeneratorSections._symbol_list):
2335         (WebKitDOMDocGeneratorSections.write_section):
2336
2337 2014-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2338
2339         [GTK] Limit the amount of API exposed to GObject DOM bindings API
2340         https://bugs.webkit.org/show_bug.cgi?id=133726
2341
2342         Reviewed by Gustavo Noronha Silva.
2343
2344         Don't make fatal finding files without a .symbols file, since now
2345         only the stable DOM API has .symbols files.
2346
2347         * gtk/webkitdom.py:
2348         (get_all_webkitdom_symbol_files):
2349
2350 2014-06-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2351
2352         Remove efl wk1 buildbot and ews
2353         https://bugs.webkit.org/show_bug.cgi?id=134089
2354
2355         Reviewed by Benjamin Poulain.
2356
2357         EFL WK1 is not supported anymore. Removed all bots for EFL WK1 bots.
2358
2359         * BuildSlaveSupport/build.webkit.org-config/config.json:
2360         * QueueStatusServer/config/queues.py:
2361         * Scripts/webkitpy/common/config/ews.json:
2362         * Scripts/webkitpy/common/config/ports.py:
2363         (DeprecatedPort.port):
2364         (QtWK2Port.run_webkit_tests_command):
2365         (EflPort): Deleted.
2366         (EflPort.build_webkit_command): Deleted.
2367         * Scripts/webkitpy/port/builders.py:
2368         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2369         * TestResultServer/static-dashboards/loader_unittests.js:
2370
2371 2014-06-19  David Kilzer  <ddkilzer@apple.com>
2372
2373         check-webkit-style does not understand Obj-C literal syntax for NSDictionary
2374         <http://webkit.org/b/134061>
2375
2376         Reviewed by Dan Bernstein.
2377
2378         * Scripts/webkitpy/style/checkers/cpp.py:
2379         (check_spacing): Ignore '@' immediately before '{'.
2380         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2381         (CppStyleTest.test_spacing_before_braces): Add unit test for
2382         '^{' block syntax and '@{' Objective-C liternal NSDitionary
2383         syntax.
2384
2385 2014-06-18  Tim Horton  <timothy_horton@apple.com>
2386
2387         All of MiniBrowser's WKWebViews should share a configuration
2388         https://bugs.webkit.org/show_bug.cgi?id=134017
2389
2390         Reviewed by Anders Carlsson.
2391
2392         * MiniBrowser/mac/WK2BrowserWindowController.m:
2393         (-[WK2BrowserWindowController awakeFromNib]):
2394         Share a single WKWebViewConfiguration between all of MiniBrowser's views.
2395         This means that they'll share things like preferences, visited links, etc.
2396         It also means that we'll properly share processes once we hit the process limit.
2397
2398 2014-06-18  Zan Dobersek  <zdobersek@igalia.com>
2399
2400         [GTK] Bump the GLib and GTK+ dependencies in jhbuild-wayland.modules
2401         https://bugs.webkit.org/show_bug.cgi?id=133971
2402
2403         Reviewed by Martin Robinson.
2404
2405         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's required for
2406         building for the Wayland target. The latest 3.12 version is required to match
2407         the xdg_shell protocol version used in Weston 1.5. GLib dependency is bumped
2408         as well due to GTK+ depending on a newer version.
2409
2410 2014-06-17  Ryuan Choi  <ryuan.choi@samsung.com>
2411
2412         [EFL] Turn on NOSNIFF in FeatureList.pm
2413         https://bugs.webkit.org/show_bug.cgi?id=134010
2414
2415         Reviewed by Csaba Osztrogonác.
2416
2417         r164848 enabled NOSNIFF feature for EFL port but missed to change FeatureList.pm.
2418
2419         * Scripts/webkitperl/FeatureList.pm: Turn on NOSNIFF for the EFL port.
2420
2421 2014-06-17  Tim Horton  <timothy_horton@apple.com>
2422
2423         MiniBrowser should show Web Content process pids in the window title
2424         https://bugs.webkit.org/show_bug.cgi?id=134016
2425
2426         Reviewed by Sam Weinig.
2427
2428         * MiniBrowser/mac/WK2BrowserWindowController.m:
2429         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2430
2431 2014-06-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2432
2433         [GTK] Fix the handling of resize events after r169505.
2434         https://bugs.webkit.org/show_bug.cgi?id=133517
2435
2436         Reviewed by Martin Robinson.
2437
2438         * Scripts/webkitpy/port/xvfbdriver.py:
2439         (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
2440         The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
2441         need at least 900x640 pixels to pass.
2442         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2443         (XvfbDriverTest.test_start_no_pixel_tests): Update resolution.
2444         (XvfbDriverTest.test_start_pixel_tests): Update resolution.
2445         (XvfbDriverTest.test_start_arbitrary_worker_number): Update resolution.
2446         (XvfbDriverTest.test_start_next_worker): Update resolution.
2447         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2448         (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
2449         be requested over the main widget instead of the window.
2450         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
2451         the Mac port.
2452         (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
2453         (WTR::PlatformWebView::setWindowFrame): Set the size and position
2454         of the Window and the web view.
2455
2456 2014-06-17  Matthew Mirman <mmirman@apple.com>
2457
2458         Unreviewed. Added myself to list of contributors.
2459
2460         * Scripts/webkitpy/common/config/contributors.json: Added myself.
2461
2462 2014-06-17  Commit Queue  <commit-queue@webkit.org>
2463
2464         Unreviewed, rolling out r170058.
2465         https://bugs.webkit.org/show_bug.cgi?id=133993
2466
2467         Caused 4 webkitpy failures on the bots (Requested by bradee-oh
2468         on #webkit).
2469
2470         Reverted changeset:
2471
2472         "[GTK] Fix the handling of resize events after r169505."
2473         https://bugs.webkit.org/show_bug.cgi?id=133517
2474         http://trac.webkit.org/changeset/170058
2475
2476 2014-06-17  Rebecca Hauck  <rhauck@adobe.com>
2477
2478         Update import-w3c-tests to reflect current W3C test repo directory structure
2479         https://bugs.webkit.org/show_bug.cgi?id=133460
2480
2481         Reviewed by Bem Jones-Bey.
2482
2483         Removed all references to test status, which are no longer reflected in the
2484         directory names in the W3C CSS test repo.  No tests are required for this 
2485         change, the existing tests pass.
2486
2487         * Scripts/webkitpy/w3c/test_importer.py:
2488         (main):
2489         (TestImporter.__init__):
2490         (TestImporter.find_importable_tests):
2491         (TestImporter.setup_destination_directory):
2492         (TestImporter.write_import_log):
2493         (TestImporter.update_test_status): Deleted.
2494
2495 2014-06-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2496
2497         [GTK] Fix the handling of resize events after r169505.
2498         https://bugs.webkit.org/show_bug.cgi?id=133517
2499
2500         Reviewed by Martin Robinson.
2501
2502         * Scripts/webkitpy/port/xvfbdriver.py:
2503         (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
2504         The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
2505         need at least 900x640 pixels to pass.
2506         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2507         (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
2508         be requested over the main widget instead of the window.
2509         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
2510         the Mac port.
2511         (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
2512         (WTR::PlatformWebView::setWindowFrame): Set the size and position
2513         of the Window and the web view.
2514
2515 2014-06-17  Dan Bernstein  <mitz@apple.com>
2516
2517         String::isolatedCopy doesn’t return an isolated copy when used on an rvalue reference
2518         https://bugs.webkit.org/show_bug.cgi?id=133968
2519
2520         Reviewed by Anders Carlsson.
2521
2522         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2523         (TestWebKitAPI::TEST): Added a test that an isolated copy of an rvalue reference doesn’t
2524         share an impl() with the original.
2525
2526 2014-06-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2527
2528         [EFL][WK2] Skip failing EFL API tests
2529         https://bugs.webkit.org/show_bug.cgi?id=133981
2530
2531         Reviewed by Csaba Osztrogonác.
2532
2533         UserMessage, WillLoad and test_ewk2_view have been failed since r169784.
2534
2535         * TestWebKitAPI/PlatformEfl.cmake:
2536
2537 2014-06-16  Ryuan Choi  <ryuan.choi@samsung.com>
2538
2539         [EFL][WK2] Remove workaround for icon display bug in MiniBrowser
2540         https://bugs.webkit.org/show_bug.cgi?id=133962
2541
2542         Reviewed by Gyuyoung Kim.
2543
2544         Since we bumped EFL to 1.9, this workaround is unnecessary.
2545
2546         * MiniBrowser/efl/main.c:
2547         (update_view_favicon):
2548
2549 2014-06-16  Gwang Yoon Hwang  <yoon@igalia.com>
2550
2551         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
2552         https://bugs.webkit.org/show_bug.cgi?id=131472
2553
2554         Reviewed by Martin Robinson.
2555
2556         This patch reapplies r167510 with fixes to add llvm as a dependency for llvmpipe.
2557
2558         * Scripts/webkitpy/port/xvfbdriver.py:
2559         (XvfbDriver._start): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
2560         when running WebKitTestRunner with the Xvfb driver.
2561         * gtk/install-dependencies: Add LLVM as a dependency to build llvmpipe.
2562         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
2563         installed.
2564         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
2565         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
2566         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
2567         deal.
2568
2569 2014-06-16  Tanay C  <tanay.c@samsung.com>
2570
2571         Remove deprecated API warnings in WebKit/Tools/MiniBrowser/efl/main.c
2572         https://bugs.webkit.org/show_bug.cgi?id=133792
2573
2574         Reviewed by Gyuyoung Kim.
2575
2576         * MiniBrowser/efl/main.c: replaced the deprecated API's with the latest ones
2577         (show_file_entry_dialog):
2578         (window_create):
2579
2580 2014-06-16  Mario Sanchez Prada  <mario.prada@samsung.com>
2581
2582         [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard
2583         https://bugs.webkit.org/show_bug.cgi?id=133512
2584
2585         Reviewed by Chris Fleizach.
2586
2587         Added support for connecting to AtkSelection's 'selection-changed'
2588         signal, and print it out as AXSelectedChildrenChanged in the tests.
2589
2590         Also removed some dead code, that became useless after r169487.
2591
2592         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2593         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Updated.
2594
2595 2014-06-15  Ryuan Choi  <ryuan.choi@samsung.com>
2596
2597         [EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get
2598         https://bugs.webkit.org/show_bug.cgi?id=133841
2599
2600         Reviewed by Gyuyoung Kim.
2601
2602         * MiniBrowser/efl/main.c:
2603         (window_create):
2604
2605 2014-06-15  Dan Bernstein  <mitz@apple.com>
2606
2607         Set the svn:ignore property on an Xcode project to ignore user and workspace data.
2608
2609         * jsc-cli/jsc-cli.xcodeproj: Added property svn:ignore.
2610
2611 2014-06-15  Anders Carlsson  <andersca@apple.com>
2612
2613         Fix build.
2614
2615         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2616         (callRunJavaScriptBlockAndRelease):
2617         (runJavaScriptInMainFrame):
2618         (TEST_F):
2619
2620 2014-06-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2621
2622         Create MSE and EME watchlist
2623         https://bugs.webkit.org/show_bug.cgi?id=133810
2624
2625         Reviewed by Eric Carlson.
2626
2627         * Scripts/webkitpy/common/config/watchlist: Create MSEEME
2628         definition and add Eric Carlson and myself to it.
2629
2630 2014-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2631
2632         [GTK] Remove all deprecated API from GObject DOM bindings
2633         https://bugs.webkit.org/show_bug.cgi?id=133728
2634
2635         Reviewed by Martin Robinson.
2636
2637         * gtk/webkitdom.py:
2638         (WebKitDOMDocGenerator): Remove all deleted classes from the list.
2639         (WebKitDOMDocGeneratorSections.__init__): Fix a typo in member initialization.
2640
2641 2014-06-12  Simon Fraser  <simon.fraser@apple.com>
2642
2643         [iOS] Fix the view being half offscreen in WebKitTestRunner on iOS
2644         https://bugs.webkit.org/show_bug.cgi?id=133835
2645
2646         Reviewed by Tim Horton.
2647         
2648         Don't do the _fakeOrigin stuff when -initWithFrame: is calling -setFrame:
2649
2650         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2651         (-[WebKitTestRunnerWindow initWithFrame:]):
2652         (-[WebKitTestRunnerWindow setFrame:]):
2653
2654 2014-06-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2655
2656         [GTK] Performance tests should be always ran with WKTR.
2657         https://bugs.webkit.org/show_bug.cgi?id=133780
2658
2659         Reviewed by Ryosuke Niwa.
2660
2661         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2662         (PerfTestsRunner.__init__): Enable webkit_test_runner when port
2663         is GTK.
2664
2665 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
2666
2667         [GTK] REGRESSION: application name is not correctly appended to the UA
2668         https://bugs.webkit.org/show_bug.cgi?id=133793
2669
2670         Reviewed by Carlos Garcia Campos.
2671
2672         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2673         (testWebKitSettingsUserAgent):
2674
2675 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
2676
2677         [GTK] Unsupported browser in www.icloud.com
2678         https://bugs.webkit.org/show_bug.cgi?id=133403
2679
2680         Reviewed by Martin Robinson.
2681
2682         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
2683         (TestWebKitAPI::TEST): removed a test for the NeedsSafariVersion6
2684         quirk that was removed.
2685
2686 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
2687
2688         [iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing
2689         https://bugs.webkit.org/show_bug.cgi?id=133779
2690
2691         Reviewed by Benjamin Poulain.
2692         
2693         Tell the WebPage to use the testing viewport configuration from the injected bundle.
2694
2695         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2696         (WTR::InjectedBundle::didReceiveMessage): Code cleanup.
2697         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2698         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Call WKBundlePageSetUseTestingViewportConfiguration()
2699         on iOS.
2700
2701 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
2702
2703         WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
2704         https://bugs.webkit.org/show_bug.cgi?id=133770
2705
2706         Reviewed by Anders Carlsson.
2707         
2708         Push the per-test view configuration up to TestController, so that platforms
2709         can modify the behavior. This also allows platform-specific changes (e.g.
2710         for threaded scrolling) to made without #ifefs.
2711
2712         * WebKitTestRunner/TestController.cpp:
2713         (WTR::TestController::updateWebViewSizeForTest):
2714         (WTR::TestController::updateWindowScaleForTest):
2715         (WTR::shouldUseFixedLayout):
2716         (WTR::TestController::updateLayoutTypeForTest):
2717         (WTR::TestController::platformConfigureViewForTest):
2718         (WTR::TestController::configureViewForTest):
2719         * WebKitTestRunner/TestController.h:
2720         * WebKitTestRunner/TestInvocation.cpp:
2721         (WTR::TestInvocation::invoke):
2722         (WTR::sizeWebViewForCurrentTest): Deleted.
2723         (WTR::changeWindowScaleIfNeeded): Deleted.
2724         (WTR::shouldUseThreadedScrolling): Deleted.
2725         (WTR::updateThreadedScrollingForCurrentTest): Deleted.
2726         (WTR::shouldUseFixedLayout): Deleted.
2727         (WTR::updateLayoutType): Deleted.
2728         * WebKitTestRunner/TestInvocation.h:
2729         (WTR::TestInvocation::pathOrURL):
2730         * WebKitTestRunner/ios/TestControllerIOS.mm:
2731         (WTR::shouldMakeViewportFlexible):
2732         (WTR::TestController::platformConfigureViewForTest):
2733         * WebKitTestRunner/mac/TestControllerMac.mm:
2734         (WTR::shouldUseThreadedScrolling):
2735         (WTR::TestController::platformConfigureViewForTest):
2736
2737 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2738
2739         [EFL] Add dependencies packages to efl install-dependencies file
2740         https://bugs.webkit.org/show_bug.cgi?id=133720
2741
2742         Reviewed by Csaba Osztrogonác.
2743
2744         After r169785, EFL port starts to use efl 1.9 ver. EFL port needs to
2745         install doxygen and libssl-dev because efl 1.9 depends on those libraries.
2746
2747         * efl/install-dependencies:
2748
2749 2014-06-11  Zoltan Horvath  <zoltan@webkit.org>
2750
2751         Unreviewed. Moving myself to the list of reviewers.
2752
2753         * Scripts/webkitpy/common/config/contributors.json:
2754
2755 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2756
2757         [EFL] Drop to maintain EFL 32bit release bot
2758         https://bugs.webkit.org/show_bug.cgi?id=133710
2759
2760         Reviewed by Csaba Osztrogonác.
2761
2762         * BuildSlaveSupport/build.webkit.org-config/config.json: Removed EFL 32bit bot.
2763
2764 2014-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2765
2766         [GTK] Use a different user agent string depending on the site
2767         https://bugs.webkit.org/show_bug.cgi?id=132681
2768
2769         Reviewed by Anders Carlsson.
2770
2771         Add a unit test to check user agent quirks.
2772
2773         * TestWebKitAPI/PlatformGTK.cmake:
2774         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
2775         (TestWebKitAPI::TEST):
2776         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2777         (testWebKitSettings): Site specific quirks setting is now enabled
2778         by default.
2779
2780 2014-06-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2781
2782         Unreviewed, update my list of email addresses in contributors.json.
2783
2784         * Scripts/webkitpy/common/config/contributors.json:
2785
2786 2014-06-10  Simon Fraser  <simon.fraser@apple.com>
2787
2788         Always switch to an sRGB screen color profile when running tests
2789         https://bugs.webkit.org/show_bug.cgi?id=133712
2790
2791         Reviewed by Tim Horton.
2792         
2793         Switch the screen color profile to sRGB when running tests, because even ref
2794         tests need the screen to use the correct color profile.
2795
2796         * DumpRenderTree/mac/LayoutTestHelper.m:
2797         (installLayoutTestColorProfile):
2798         * Scripts/webkitpy/port/mac.py:
2799         (MacPort.start_helper):
2800
2801 2014-06-10  Martin Hodovan  <mhodovan@partner.samsung.com>
2802
2803         [EFL] Bump EFL libraries to 1.9
2804         https://bugs.webkit.org/show_bug.cgi?id=125479
2805
2806         Reviewed by Gyuyoung Kim.
2807
2808         Based on the work of Ryuan Choi <ryuan.choi@samsung.com>
2809         and László Langó <llango.u-szeged@partner.samsung.com>.
2810
2811         * ImageDiff/CMakeLists.txt:
2812         * MiniBrowser/efl/CMakeLists.txt:
2813         * efl/install-dependencies:
2814         * efl/jhbuild.modules:
2815         * efl/jhbuildrc:
2816
2817 2014-06-10  David Farler  <dfarler@apple.com>
2818
2819         old-run-webkit-tests: Create CoreSimulator device on demand and find it by name
2820         https://bugs.webkit.org/show_bug.cgi?id=133663
2821
2822         Reviewed by David Kilzer.
2823
2824         * Scripts/old-run-webkit-tests:
2825         (installAndLaunchDumpToolAppUsingNotification):
2826         - Remove obsolete notification keys
2827         - Key off of mandatory device UDID (a UUID)
2828         - Create a device on demand via CoreSimulator if necessary
2829         -- Grab the UDID from the created device plist.
2830         * Scripts/webkitdirs.pm:
2831         (iOSSimulatorDevicesPath): Added
2832         (iOSSimulatorDevices): Added
2833         (createiOSSimulatorDevice): Added
2834         (deleteiOSSimulatorDevice): Added
2835
2836 2014-06-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
2837
2838         [GTK][gtkdoc] remove -Wcast-align
2839         https://bugs.webkit.org/show_bug.cgi?id=133640
2840
2841         Apparently gcc warns that GParamSpec is not castable to
2842         GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
2843         though ARM hackers claim that those only need 4byte alignment. As long as gcc
2844         behaves that way, this warning is not very useful, also they break the Debian
2845         packaging.
2846
2847         This patch appends the compiler flag -Wno-align-cast for the gtkdoc
2848         scanner compilation, thus the compiler ignores the previous
2849         -Waling-cast flag.
2850
2851         Reviewed by Martin Robinson.
2852
2853         * gtk/generate-gtkdoc:
2854         (get_generator_for_config):
2855
2856 2014-06-09  Alexey Proskuryakov  <ap@apple.com>
2857
2858         Disable button animations in regression tests
2859         https://bugs.webkit.org/show_bug.cgi?id=133647
2860         <rdar://problem/16677530>
2861
2862         Reviewed by Tim Horton.
2863
2864         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2865         (WTR::InjectedBundle::platformInitialize):
2866
2867 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
2868
2869         Move scrolling-related tests to tiled-drawing/scrolling subdirectory, and minor cleanup
2870         https://bugs.webkit.org/show_bug.cgi?id=133650
2871
2872         Reviewed by Tim Horton.
2873         
2874         No point checking for a Windows-style path in Cocoa code.
2875
2876         * WebKitTestRunner/TestInvocation.cpp:
2877         (WTR::shouldUseThreadedScrolling):
2878
2879 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
2880
2881         Fix more latched scrolling test flakiness and slowness
2882         https://bugs.webkit.org/show_bug.cgi?id=133601
2883
2884         Reviewed by Brent Fulgham.
2885         
2886         Latched scrolling tests were flakey for two reasons. First, the EventSender
2887         wheel events were async from the web to the UI process, and the resulting
2888         synthetic events also async from the UI to the web process. Make them sync
2889         for testing.
2890         
2891         Secondly, the timer-based scrolling tree commit could result in the scrolling
2892         tree (specifically the frame node's notion of the scrollable area and content
2893         size) not being updated before the scrolling thread starts getting wheel events.
2894         Fix by having WebPage::wheelEventSyncForTesting() commit if necessary.
2895         
2896         Finally remove all the now-unnecessary timeouts from the tests.
2897
2898         * WebKitTestRunner/mac/EventSenderProxy.mm:
2899         (WTR::EventSenderProxy::mouseMoveTo):
2900         (WTR::EventSenderProxy::mouseScrollBy):
2901         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2902
2903 2014-06-09  Andrzej Badowski  <a.badowski@samsung.com>
2904
2905         [EFL] Add parameter to MiniBrowser to disable web security
2906         https://bugs.webkit.org/show_bug.cgi?id=121095
2907
2908         Reviewed by Gyuyoung Kim.
2909
2910         -w (--web-security) commandline allows to disable/enable web security (enabled by default).
2911         The reason for this is to test and debug (using, for example, MiniBrowser) scripts accessing
2912         resources from other domains (cross-domain requests) such as access map location on another server.
2913         Another possibility is to launch in a webkit browser local file tests that will refer to the links
2914         in the http website loaded in an iframe. It will not be possible without deactivation of web security.
2915
2916         * MiniBrowser/efl/main.c:
2917         (window_create):
2918         (elm_main):
2919
2920 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
2921
2922         32-bit build fix.
2923
2924         * WebKitTestRunner/mac/EventSenderProxy.mm:
2925         (WTR::EventSenderProxy::mouseMoveTo):
2926         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2927
2928 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
2929
2930         Fix builds on 10.8; -firstObject isn't declared on NSArray there.
2931
2932         * DumpRenderTree/mac/DumpRenderTree.mm:
2933         (createWebViewAndOffscreenWindow):
2934         * DumpRenderTree/mac/EventSendingController.mm:
2935         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2936         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2937         * WebKitTestRunner/mac/EventSenderProxy.mm:
2938         (WTR::EventSenderProxy::mouseScrollBy):
2939         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2940
2941 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
2942
2943         Latched scrolling tests are flakey on Mavericks
2944         https://bugs.webkit.org/show_bug.cgi?id=133578
2945         <rdar://problem/17180591>
2946
2947         Reviewed by Brent Fulgham.
2948         
2949         The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
2950         be wrong on machines with more than one screen. This is because we use
2951         [NSScreen mainScreen] when computing the global coordinates of the events, but
2952         [NSScreen mainScreen] returns the screen with the key window, not the first screen.
2953         
2954         So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
2955         add comments clarifying why the coordinate math works (which is not obvious given
2956         the events have no target window).
2957         
2958         Some scrolling tests also dispatched events outside the 800x600 test window, so
2959         fix those tests, and add logging that will appear in test output when this happens.
2960
2961         * DumpRenderTree/mac/DumpRenderTree.mm:
2962         (createWebViewAndOffscreenWindow):
2963         * DumpRenderTree/mac/EventSendingController.mm:
2964         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2965         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2966         * WebKitTestRunner/mac/EventSenderProxy.mm:
2967         (WTR::EventSenderProxy::mouseMoveTo):
2968         (WTR::EventSenderProxy::mouseScrollBy):
2969         (WTR::EventSenderProxy::continuousMouseScrollBy):
2970         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2971
2972 2014-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2973
2974         [GTK] run-perf-tests should run the tests inside the jhbuild shell.
2975         https://bugs.webkit.org/show_bug.cgi?id=133533
2976
2977         Reviewed by Carlos Garcia Campos.
2978
2979         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
2980         (run): Remove the jhbuild-wrapper wrapper from here. It should be
2981         on Scripts/webkitpy/port/gtk.py.
2982         * Scripts/webkitpy/port/base.py:
2983         (Port.set_option): Add a set_option(name, value) function to set
2984         the optparse parameter "name" to the value "value", even if the
2985         parameter "name" is already initialized.
2986         * Scripts/webkitpy/port/gtk.py:
2987         (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
2988         If another wrapper is specified via the option "-l --wrapper=x",
2989         then prepend the jhbuild-wrapper to the one specified.
2990
2991 2014-06-04  David Farler  <dfarler@apple.com>
2992
2993         Build ASan WebKit for iOS Simulator
2994         https://bugs.webkit.org/show_bug.cgi?id=133489
2995
2996         Reviewed by Darin Adler.
2997
2998         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2999         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
3000         - Add missing ASan LDFLAGS.
3001         * asan/asan.xcconfig:
3002         - Split compiler-rt linker flags for OS X and iOS Simulator
3003
3004 2014-06-03  Yoav Weiss  <yoav@yoav.ws>
3005
3006         Add myself (yoav@yoav.ws) to contributors.json
3007         https://bugs.webkit.org/show_bug.cgi?id=133492
3008
3009         * Scripts/webkitpy/common/config/contributors.json:
3010
3011 2014-06-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3012
3013         REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
3014         https://bugs.webkit.org/show_bug.cgi?id=133149
3015
3016         Reviewed by Csaba Osztrogonác.
3017
3018         * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
3019
3020 2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3021
3022         Add a verbose flag to binding tests
3023         https://bugs.webkit.org/show_bug.cgi?id=122303
3024
3025         Reviewed by Csaba Osztrogonác.
3026
3027         This patch will:
3028         - Add a verbose keyword argument to the BindingsTests constructor,
3029         - Add --no-verbose option to the run-bindigs-test.
3030         Verbose mode, which is on by default, prints positive results to stdout as before.
3031         When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
3032
3033         Original patch from Matthew Hanson <matthew_hanson@apple.com>
3034
3035         * Scripts/run-bindings-tests:
3036         (main):
3037         * Scripts/webkitpy/bindings/main.py:
3038         (BindingsTests.__init__):
3039         (BindingsTests.detect_changes):
3040
3041 2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
3042
3043         Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
3044         https://bugs.webkit.org/show_bug.cgi?id=133455
3045
3046         Reviewed by Timothy Hatcher.
3047
3048         Since the perf. dashboard doesn't support following renamed benchmarks,
3049         keep reporting Speedometer results as DoYouEvenBench results.
3050
3051         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3052         (_generate_results_dict):
3053
3054 2014-05-31  Darin Adler  <darin@apple.com>
3055
3056         Viewport percentage tests that resize the viewport are flaky
3057         https://bugs.webkit.org/show_bug.cgi?id=133351
3058
3059         Reviewed by Anders Carlsson.
3060
3061         * DumpRenderTree/mac/DumpRenderTree.mm:
3062         (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
3063         happens to be stored in the UI delegate object. This is part of resetting the
3064         window position.
3065
3066         * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
3067         a frame rectangle. The size is stored in the size of the web view itself.
3068         * DumpRenderTree/mac/UIDelegate.mm:
3069         (-[UIDelegate resetWindowOrigin]): Added.
3070         (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
3071         old version would store the frame, but not resize the web view!
3072         (-[UIDelegate webViewFrame:]): Get the size from the web view.
3073
3074         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3075         (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
3076
3077         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3078         (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
3079         the window.
3080
3081         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3082         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
3083         window gets resized too, not just the web view.
3084         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
3085
3086         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3087         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
3088         window gets resized too, not just the web view.
3089         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
3090
3091 2014-05-30  Michael Saboff  <msaboff@apple.com>
3092
3093         Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
3094         https://bugs.webkit.org/show_bug.cgi?id=133409
3095
3096         Reviewed by Filip Pizlo.
3097
3098         Handle creating a tarball the same way as running remote when processing
3099         paths in prepareBundle.
3100
3101         * Scripts/run-jsc-stress-tests:
3102
3103 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
3104
3105         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
3106         https://bugs.webkit.org/show_bug.cgi?id=132280
3107
3108         Reviewed by Chris Fleizach.
3109
3110         Remove implementation of logAccessibilityEvents() for ATK based
3111         ports, as this has proved to be a flaky method of checking that
3112         ATK events are being properly emitted. Instead, it's better to use
3113         the addNotificationListener() functions and provide a JS callback
3114         to check that the right events are being emmitted from the tests.
3115
3116         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3117         (WTR::AccessibilityController::logAccessibilityEvents): Replaced
3118         with dummy implementation.
3119         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3120         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
3121
3122 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
3123
3124         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
3125         https://bugs.webkit.org/show_bug.cgi?id=132280
3126
3127         Rubber stamped by Carlos Garcia Campos.
3128
3129         Fix two small issues with previous patch (r169483), that caused some tests to break.
3130
3131         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3132         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
3133         duplicated entry.
3134         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3135         (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
3136
3137 2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
3138
3139         [ATK] Added new accessibility signal: text-caret-moved.
3140         Make AccessibilityUIElement.setSelectedTextRange work
3141         as atk_text_set_caret_offset when given offset == 0.
3142         https://bugs.webkit.org/show_bug.cgi?id=132527
3143
3144         Reviewed by Mario Sanchez Prada.
3145
3146         text-caret-moved signal in accessibilityController is needed to
3147         implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
3148         as LayoutTests. Add the signal to the controller.
3149
3150         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3151         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3152         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3153         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3154         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3155         (setSelectedTextRange): Change return type to bool.
3156         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3157         (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
3158         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3159         (axObjectEventListener): Add notification name AXTextCaretMoved, allow
3160         for extra arguments passed to handler and use it for text-caret-moved offset.
3161         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
3162         Connect callback to new listener for ATK:AtkText:text-caret-moved.
3163         Refactor so that failures be reported.
3164         Initialize atk interfaces before trying to connect to them, see
3165         https://bugzilla.gnome.org/show_bug.cgi?id=729922
3166         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
3167         Simplify code by using a vector in place of dozen variables.
3168         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3169         Comment about not synchronizing with accessibilityController.
3170
3171 2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3172
3173         [GTK] Add a WebKit2 Performance bot.
3174         https://bugs.webkit.org/show_bug.cgi?id=132862
3175
3176         Reviewed by Csaba Osztrogonác.
3177
3178         This adds a GTK WebKit2 perf bot.
3179
3180         * BuildSlaveSupport/build.webkit.org-config/config.json:
3181
3182 2014-05-29  Dan Bernstein  <mitz@apple.com>
3183
3184         Fixed the WebKitTestRunner build after r169452.
3185
3186         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3187         (WTR::InjectedBundle::initialize):
3188
3189 2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
3190
3191         Unreviewed. Update my email addresses in contributors.json.
3192
3193         * Scripts/webkitpy/common/config/contributors.json:
3194
3195 2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
3196
3197         Need an API test for bug #133193 (r169315)
3198         <https://bugs.webkit.org/show_bug.cgi?id=133324>
3199
3200         This adds an API test that ensures that calling "stop loading" during a
3201         "did fail provisional load" callback doesn't crash.
3202
3203         Reviewed by Andy Estes.
3204
3205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3206         Add new files to project.
3207
3208         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
3209         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3210         If the message is the "test done" message, record that.
3211         (TestWebKitAPI::setInjectedBundleClient):
3212         Register a function for the "did receive message from injected bundle"
3213         callback.
3214         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
3215         Assert that we received the message from the injected bundle, and set
3216         'done' to finish the test.
3217         (TestWebKitAPI::TEST):
3218         Create a WebView, register a page loader client for the "did fail
3219         provisional load" callback, and load a non-existent resource.
3220
3221         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
3222         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
3223         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
3224         Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
3225         provisional load failed.
3226         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
3227         Register a page loader client for the "did fail provisional load"
3228         callback.
3229         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
3230         Call WKBundlePageStopLoading() during the callback. This not crashing
3231         is what we're ensuring with this test.
3232
3233 2014-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3234
3235         [GTK] Make it possible to build with FTL enabled
3236         https://bugs.webkit.org/show_bug.cgi?id=133219
3237
3238         Reviewed by Philippe Normand.
3239
3240         * gtk/jhbuild-optional.modules: Add llvm from svn and build the
3241         same revision than mac.
3242
3243 2014-05-27  Michael Saboff  <msaboff@apple.com>
3244
3245         REGRESSION(r169265): sh: line 0: cd: ../.vm
3246         https://bugs.webkit.org/show_bug.cgi?id=133242
3247
3248         Rubber stamped by Oliver Hunt.
3249
3250         Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
3251         array since the command may contain character escapes that don't work with the
3252         array form of system().
3253
3254         * Scripts/run-jsc-stress-tests:
3255
3256 2014-05-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3257
3258         [EFL] Change download url of freetype6
3259         https://bugs.webkit.org/show_bug.cgi?id=133303
3260
3261         Reviewed by Csaba Osztrogonác.
3262
3263         freetype6 tarball isn't downloaded in Korea. So, we need to
3264         change the url for now.
3265
3266         * efl/jhbuild.modules:
3267
3268 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3269
3270         Remove BLOB guards
3271         https://bugs.webkit.org/show_bug.cgi?id=132863
3272
3273         Reviewed by Csaba Osztrogonác.
3274
3275         * Scripts/webkitperl/FeatureList.pm:
3276
3277 2014-05-27  Alberto Garcia  <berto@igalia.com>
3278
3279         Remove leftover comment from r165182.
3280
3281         Rubber stamped by Carlos Garcia Campos.
3282
3283         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
3284
3285 2014-05-26  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3286
3287         [EFL] Add LLVM as optional jhbuild module for FTL developers
3288         https://bugs.webkit.org/show_bug.cgi?id=133216
3289
3290         Reviewed by Gyuyoung Kim.
3291
3292         * efl/jhbuild.modules:
3293
3294 2014-05-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3295
3296         Fix test failures on python test
3297         https://bugs.webkit.org/show_bug.cgi?id=133297
3298
3299         Reviewed by Dirk Schulze.
3300
3301         2 tests are failing because of unbounded local variable reference in test_importer.py.
3302
3303         * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
3304         (TestImporter.import_tests):
3305
3306 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3307
3308         [GTK] GObject DOM bindings API break test fails in the tests bots
3309         https://bugs.webkit.org/show_bug.cgi?id=133211
3310
3311         Reviewed by Martin Robinson.
3312
3313         When generating the built product archive on platform GTK, we need
3314         to copy also the file gtkdoc-webkitdom.cfg and the directory
3315         DerivedSources/webkitdom.
3316
3317         * BuildSlaveSupport/built-product-archive:
3318         (archiveBuiltProduct):
3319
3320 2014-05-26  Commit Queue  <commit-queue@webkit.org>
3321
3322         Unreviewed, rolling out r169122.
3323         https://bugs.webkit.org/show_bug.cgi?id=133288
3324
3325         Broke CJK font fallback (Requested by ap on #webkit).
3326
3327         Reverted changeset:
3328
3329         "[Mac] WebProcess doesn't follow localization of UI process
3330         when run as a service"
3331         https://bugs.webkit.org/show_bug.cgi?id=133126
3332         http://trac.webkit.org/changeset/169122
3333
3334 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3335
3336         [GTK] WebProcess leaked when closing pages with network process enabled
3337         https://bugs.webkit.org/show_bug.cgi?id=129684
3338
3339         Reviewed by Anders Carlsson.
3340
3341         Enable the test to check that web processes finish when the web
3342         view is destroyed.
3343
3344         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
3345
3346 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3347
3348         REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
3349         https://bugs.webkit.org/show_bug.cgi?id=133279
3350
3351         Reviewed by Philippe Normand.
3352
3353         generator.saw_warnings is only set by GTKDoc::generate(), so it
3354         should only be used after generate.
3355
3356         * gtk/generate-gtkdoc:
3357         (generate_documentation_for_config): Do not check
3358         generator.saw_warnings again, simply return the value returned by
3359         generate_doc() which is generator.saw_warnings. When rebasing,
3360         returns always False since there aren't warnings.
3361
3362 2014-05-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3363
3364         W3C test importer should catch exceptions coming from HTML/CSS conversion
3365         https://bugs.webkit.org/show_bug.cgi?id=133176
3366
3367         Reviewed by Darin Adler.
3368
3369         Exceptions raised when converting HTML/CSS are caught.
3370         Files for which conversion failed are still copied to the target directory.
3371         Each individual conversion failure is logged.
3372         Total conversion failure number is logged at the end of the import process.
3373
3374         * Scripts/webkitpy/w3c/test_importer.py:
3375         (TestImporter.import_tests):
3376
3377 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3378
3379         [GTK] Allow to run the tests on the native X display.
3380         https://bugs.webkit.org/show_bug.cgi?id=133157
3381
3382         Reviewed by Benjamin Poulain.
3383
3384         This adds a new driver (xorgdriver) that runs the tests on the
3385         X display referenced by the environment variable DISPLAY.
3386
3387         This new driver will be activated only if the environment variable
3388         USE_NATIVE_XDISPLAY is defined. This can be used both for layout
3389         tests and performance tests.
3390
3391         This patch also makes the script run-perf-tests to check the
3392         system dependencies before starting the tests. Previously this
3393         was not checked, and if the system dependencies were not met,
3394         the script tried to execute the tests anyway, causing massive
3395         failures. For example, if you had Xvfb not installed and you
3396         wanted to use the Xvfb driver (the default on GTK and EFL),
3397         run-perf-tests would not abort.
3398
3399         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3400         (PerfTestsRunner._parse_args): Check the system dependencies of
3401         the driver before starting the tests.
3402         * Scripts/webkitpy/port/driver.py:
3403         (Driver): Implement generic check_driver method.
3404         (Driver.check_driver):
3405         (Driver.check_driver.implementation):
3406         * Scripts/webkitpy/port/gtk.py:
3407         (GtkPort._driver_class): Check for environment variable
3408         USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
3409         * Scripts/webkitpy/port/xorgdriver.py: Added.
3410         (XorgDriver): Implement Xorg driver.
3411         (XorgDriver.check_driver):
3412         (XorgDriver._start):
3413
3414 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3415
3416         REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
3417         https://bugs.webkit.org/show_bug.cgi?id=133215
3418
3419         Reviewed by Csaba Osztrogonác.
3420
3421         This reverts r166798.
3422
3423         * BuildSlaveSupport/kill-old-processes:
3424         (main):
3425
3426 2014-05-26  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3427
3428         [EFL] Turn on ENABLE_CSS_FILTERS in build script
3429         https://bugs.webkit.org/show_bug.cgi?id=133278
3430
3431         Reviewed by Gyuyoung Kim.
3432
3433         * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
3434
3435 2014-05-26  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3436
3437         run-javascriptcore-tests warning fix on non Mac platforms
3438         https://bugs.webkit.org/show_bug.cgi?id=133260
3439
3440         Reviewed by Darin Adler.
3441
3442         * Scripts/webkitdirs.pm:
3443         (argumentsForConfiguration):
3444
3445 2014-05-23  Michael Saboff  <msaboff@apple.com>
3446
3447         REGRESSION(r169265): sh: line 0: cd: ../.vm
3448         https://bugs.webkit.org/show_bug.cgi?id=133242
3449
3450         Rubber stamped by Geoffrey Garen.
3451
3452         Added missing shell escapes '\' required as part of previous fix.
3453
3454         * Scripts/run-jsc-stress-tests:
3455
3456 2014-05-23  Ryosuke Niwa  <rniwa@webkit.org>
3457
3458         Revert the erroneous change committed in r169286.
3459
3460         * Scripts/webkitpy/performance_tests/perftest.py:
3461         (PerfTest._run_with_driver):
3462
3463 2014-05-23  Geoffrey Garen  <ggaren@apple.com>
3464
3465         run-perf-tests should ignore whitespace lines when snarfing test output
3466         https://bugs.webkit.org/show_bug.cgi?id=133238
3467
3468         Reviewed by Ryosuke Niwa.
3469
3470         Required for PerformanceTests/Canvas/terrain.html.
3471
3472         * Scripts/webkitpy/performance_tests/perftest.py:
3473         (PerfTest._run_with_driver):
3474         (PerfTest):
3475
3476 2014-05-23  Michael Saboff  <msaboff@apple.com>
3477
3478         REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
3479         https://bugs.webkit.org/show_bug.cgi?id=133223
3480
3481         Reviewed by Geoffrey Garen.
3482
3483         Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
3484         string before calling IO.popen() to work with older versions of ruby.
3485         Changed the remote path in runShellTestRunner to quote the command
3486         string we want to run via ssh so that it will work correctly with array
3487         to string conversion needed for popen.
3488
3489         * Scripts/run-jsc-stress-tests:
3490
3491 2014-05-23  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3492
3493         Remove 'css-shaders' option from the build-webkit
3494         https://bugs.webkit.org/show_bug.cgi?id=133212
3495
3496         Reviewed by Daniel Bates.
3497
3498         Original CSS shaders removed in r162644.
3499
3500         * Scripts/webkitperl/FeatureList.pm:
3501
3502 2014-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3503
3504         [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
3505         https://bugs.webkit.org/show_bug.cgi?id=133209
3506
3507         Reviewed by Sergio Villar Senin.
3508
3509         Return FAILURE when the command failed to run.
3510
3511         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3512         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
3513
3514 2014-05-23  Alberto Garcia  <berto@igalia.com>
3515
3516         [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
3517         https://bugs.webkit.org/show_bug.cgi?id=133210
3518
3519         Reviewed by Carlos Garcia Campos.
3520
3521         * gtk/install-dependencies:
3522
3523 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
3524
3525         Add Yusuke Suzuki to the list of contributors (for real)
3526
3527         Wrong section...
3528
3529         * Scripts/webkitpy/common/config/contributors.json:
3530
3531 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
3532
3533         Add Yusuke Suzuki to the list of contributors
3534
3535         * Scripts/webkitpy/common/config/contributors.json:
3536
3537 2014-05-22  Michael Saboff  <msaboff@apple.com>
3538
3539         Eliminate n/total progress update from run-jsc-stress-tests output to file
3540         https://bugs.webkit.org/show_bug.cgi?id=133191
3541
3542         Reviewed by Geoffrey Garen.
3543
3544         Changed progressMeter setting to be based on stdout being a tty instead of
3545         stdin.  Unified the processing of output from the shell runner to match the
3546         same processing as is used by the makefile runner.  As part of this, the 
3547         shell runner script was simplified.  It now forwards the output of each
3548         test_script just like the Makefile and doesn't provide its own progress.
3549
3550         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
3551         * Scripts/run-jsc-stress-tests:
3552
3553 2014-05-22  Michael Saboff  <msaboff@apple.com>
3554
3555         Add option to run-jsc-stress-tests to use installed jsc
3556         https://bugs.webkit.org/show_bug.cgi?id=133102
3557
3558         Reviewed by Geoffrey Garen.
3559
3560         Added --no-copy option to not copy a JavaScriptCore framework, but use the one
3561         provied with the --jsc option.
3562
3563         * Scripts/run-jsc-stress-tests:
3564
3565 2014-05-21  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3566
3567         [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
3568         https://bugs.webkit.org/show_bug.cgi?id=132907
3569
3570         Reviewed by Gyuyoung Kim.
3571
3572         We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
3573         in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
3574
3575         * efl/install-dependencies:
3576
3577 2014-05-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3578
3579         REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
3580         https://bugs.webkit.org/show_bug.cgi?id=133145
3581
3582         Reviewed by Csaba Osztrogonác.
3583
3584         * Scripts/run-jsc-stress-tests:
3585
3586 2014-05-20  Alexey Proskuryakov  <ap@apple.com>
3587
3588         [Mac] WebProcess doesn't follow localization of UI process when run as a service
3589         https://bugs.webkit.org/show_bug.cgi?id=133126
3590         <rdar://problem/13396515>
3591         <rdar://problem/16561084>
3592
3593         Reviewed by Sam Weinig and Tim Horton.
3594
3595         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3596         (WTR::InjectedBundle::platformInitialize): It was too late to override language
3597         here, and it's not necessary any more. Keeping the code for older OS versions in
3598         case it did have effect in some code paths.
3599
3600 2014-05-19  David Farler  <dfarler@apple.com>
3601
3602         Move WebKitTestRunner to std::unique_ptr
3603         https://bugs.webkit.org/show_bug.cgi?id=133081
3604
3605         Reviewed by Daniel Bates.
3606
3607         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3608         (WTR::InjectedBundle::didCreatePage):
3609         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3610         * WebKitTestRunner/TestController.cpp:
3611         (WTR::TestController::initialize):
3612         (WTR::TestController::createWebViewWithOptions):
3613         (WTR::TestController::resetStateToConsistentValues):
3614         (WTR::TestController::runTest):
3615         * WebKitTestRunner/TestController.h:
3616         * WebKitTestRunner/TestInvocation.cpp:
3617         * WebKitTestRunner/TestInvocation.h:
3618         * WebKitTestRunner/WorkQueueManager.cpp:
3619         (WTR::WorkQueueManager::processWorkQueue):
3620         (WTR::WorkQueueManager::enqueue):
3621         * WebKitTestRunner/WorkQueueManager.h:
3622
3623 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3624
3625         [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
3626         https://bugs.webkit.org/show_bug.cgi?id=133119
3627
3628         Reviewed by Sergio Villar Senin.
3629
3630         Check that redirect response parameter of
3631         WebKitWebPage::send-request signal is NULL when not redirecting
3632         and a valid WebKitURIResponse object when redirecting.
3633
3634         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3635         (testWebResourceSendRequest):
3636         (serverCallback):
3637         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3638         (sendRequestCallback):
3639
3640 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3641
3642         REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
3643         https://bugs.webkit.org/show_bug.cgi?id=133117
3644
3645         Reviewed by Philippe Normand.
3646
3647         Bring back missing tests to the build.
3648
3649         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3650
3651 2014-05-19  Filip Pizlo  <fpizlo@apple.com>
3652
3653         Take care of some ARM64 test failures
3654         https://bugs.webkit.org/show_bug.cgi?id=133090
3655
3656         Reviewed by Geoffrey Garen.
3657
3658         * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
3659
3660 2014-05-19  David Kilzer  <ddkilzer@apple.com>
3661
3662         [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
3663         <http://webkit.org/b/133089>
3664
3665         Reviewed by Darin Adler.
3666
3667         * Scripts/webkitdirs.pm:
3668         (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
3669         specified on the command line, we would remove the '--sdk'
3670         arguments, but leave '--sim', potentially passing it along to
3671         xcodebuild causing a build failure.  This happens when
3672         'old-run-webkit-tests --release --sim' invokes
3673         build-dumprendertree when DumpRenderTree hasn't been built yet.
3674
3675 2014-05-19  David Farler  <dfarler@apple.com>
3676
3677         Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
3678         https://bugs.webkit.org/show_bug.cgi?id=133086
3679
3680         Reviewed by Daniel Bates.
3681
3682         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3683
3684