1 2011-04-13 Lucas Forschler <lforschler@apple.com>
3 Reviewed by Adam Roben.
5 https://bugs.webkit.org/show_bug.cgi?id=58384
6 Update kill-old-processes to include a few new ones.
8 * BuildSlaveSupport/win/kill-old-processes:
10 2011-04-13 Gustavo Noronha Silva <gns@gnome.org>
12 Reviewed by Martin Robinson.
14 [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
15 https://bugs.webkit.org/show_bug.cgi?id=58297
17 Do not disable flash specifically when built with GTK+ 3 -
18 PluginPackage should do the right thing while loading plugins.
23 2011-04-12 Kent Tamura <tkent@chromium.org>
25 Reviewed by Dimitri Glazkov.
27 [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
28 https://bugs.webkit.org/show_bug.cgi?id=57426
30 * DumpRenderTree/chromium/WebPreferences.cpp:
31 (WebPreferences::applyTo): Disable the validation message timer.
33 2011-04-12 James Kozianski <koz@chromium.org>
37 Adding myself to committers.py.
39 * Scripts/webkitpy/common/config/committers.py:
41 2011-04-12 Brent Fulgham <bfulgham@webkit.org>
43 Unreviewed build correction for WinCairo bot after r83639.
44 https://bugs.webkit.org/show_bug.cgi?id=51790
46 Correct typo for the new "update-webkit-wincairo-libs" script.
48 * Scripts/build-webkit: Incorrectly calling the
49 update-webkit-cairo-libs which does not exist.
51 2011-04-12 Alice Liu <alice.liu@apple.com>
53 Reviewed by Jon Honeycutt.
55 A change that should have been part of http://trac.webkit.org/changeset/83628
57 * DumpRenderTree/win/DumpRenderTree.cpp:
58 (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
60 2011-04-12 Dirk Pranke <dpranke@chromium.org>
62 Reviewed by Tony Chang.
64 new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
65 https://bugs.webkit.org/show_bug.cgi?id=58272
67 NRWT was interpreting the --results-directory cmd line arg as
68 relative to the build directory, not the current working
69 directory (ORWT uses the latter, which is much more intuitive).
71 This patch fixes the base case, but includes an override for
72 Chromium that is needed until the bots can be updated.
74 * Scripts/webkitpy/layout_tests/port/base.py:
75 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
76 * Scripts/webkitpy/layout_tests/port/chromium.py:
77 * Scripts/webkitpy/layout_tests/port/port_testcase.py:
78 * Scripts/webkitpy/layout_tests/port/test.py:
79 * Scripts/webkitpy/layout_tests/port/webkit.py:
80 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
81 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
83 2011-04-12 Philippe Normand <pnormand@igalia.com>
85 Unreviewed, roll out r83621 as it broke the GTK build.
87 [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
88 https://bugs.webkit.org/show_bug.cgi?id=58333
91 * Scripts/build-webkit:
93 2011-04-12 Carl Lobo <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>
95 Reviewed by Adam Roben.
97 Patch to download the WinCairo dependancies as part of build-webkit.
98 https://bugs.webkit.org/show_bug.cgi?id=51790
100 This patch downloads the dependancies from
101 http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip
102 checking the modification timestamp etc.
104 * Tools/Scripts/build-webkit
105 * Tools/Scripts/update-webkit: Modified to understand the --wincairo
106 flag, and to update WinCairo dependencies when used.
107 * Tools/Scripts/update-webkit-cairo-libs: added
108 * Tools/Scripts/update-webkit-dependency: added
109 * Tools/Scripts/update-webkit-auxiliary-libs
111 2011-04-12 Jeff Miller <jeffm@apple.com>
113 Reviewed by Adam Roben.
115 WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
116 https://bugs.webkit.org/show_bug.cgi?id=56020
118 Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
119 since WebKit will do this for us. If we didn't do this, TranslateMessage() would be called twice,
120 which would generate two characters for every keypress (for example). I didn't bother doing this for
121 WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.
123 Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.
125 * MiniBrowser/win/main.cpp:
126 (shouldTranslateMessage): Added.
127 (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
128 * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
129 * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
130 * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
131 (TestWebKitAPI::didNotHandleKeyEventCallback): Added.
132 (TestWebKitAPI::runAndWatchForWMChar): Added.
133 (TestWebKitAPI::TEST): Added.
134 * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
135 (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
136 (TestWebKitAPI::Util::shouldTranslateMessage): Added.
137 * TestWebKitAPI/win/PlatformWebViewWin.cpp:
138 (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
139 * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
141 2011-04-12 Dirk Pranke <dpranke@chromium.org>
143 Reviewed by Tony Chang.
145 new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
146 https://bugs.webkit.org/show_bug.cgi?id=58290
148 This is some preliminary refactoring for bug 58272.
150 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
151 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
152 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
153 * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
154 * Scripts/webkitpy/layout_tests/port/test.py:
155 * Scripts/webkitpy/layout_tests/port/chromium.py:
156 * Scripts/webkitpy/layout_tests/port/base.py:
157 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
159 2011-04-12 Dirk Pranke <dpranke@chromium.org>
161 Reviewed by Eric Seidel.
163 webkitpy: fix mock_filesystem abspath to handle relative paths
164 and add filesystem.chdir() and filesystem.getcwd() to be able
165 to test this and mock it out.
167 https://bugs.webkit.org/show_bug.cgi?id=58288
169 * Scripts/webkitpy/common/system/filesystem.py:
170 * Scripts/webkitpy/common/system/filesystem_mock.py:
171 * Scripts/webkitpy/common/system/filesystem_unittest.py:
173 2011-04-12 Alice Liu <alice.liu@apple.com>
175 Reviewed by Sam Weinig.
177 https://bugs.webkit.org/show_bug.cgi?id=58292
178 Provide new setting to allow site icon loading despite disabling automatic image loading in general.
180 * DumpRenderTree/mac/DumpRenderTree.mm:
181 (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
183 2011-04-12 Thouraya ANDOLSI <thouraya.andolsi@st.com>
185 Reviewed by Eric Seidel.
187 [Qt] Enable JIT build for SH4 platforms.
188 https://bugs.webkit.org/show_bug.cgi?id=58317
191 * DumpRenderTree/qt/DumpRenderTree.pro:
192 * QtTestBrowser/QtTestBrowser.pro:
193 * Scripts/webkitdirs.pm:
195 2011-04-12 Tony Chang <tony@chromium.org>
197 Reviewed by Andreas Kling.
199 [Qt] embed checksums in PNGs written by Qt-DRT
200 https://bugs.webkit.org/show_bug.cgi?id=58173
202 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
203 (WebCore::DumpRenderTree::dump):
205 2011-04-12 Eric Seidel <eric@webkit.org>
207 Reviewed by Adam Barth.
209 commit-queue should upload failure diffs when tests fail
210 https://bugs.webkit.org/show_bug.cgi?id=58348
212 This change was mostly just plumbing. We were already saving
213 this information for flaky test reporting. I just made it possible
214 for normal failures to report archives as well.
216 I did a little abstraction work to try and share some code between
217 flakytestreporter.py and this new code. There is still more we could do.
219 In making this change I also went through and updated the various
220 places we have urls hard-coded in our python and pointed them at
223 * Scripts/webkitpy/common/checkout/scm.py:
224 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
225 * Scripts/webkitpy/common/net/buildbot/buildbot.py:
226 * Scripts/webkitpy/common/net/statusserver.py:
227 * Scripts/webkitpy/layout_tests/port/base.py:
228 * Scripts/webkitpy/tool/bot/botinfo.py: Added.
229 * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
230 * Scripts/webkitpy/tool/bot/commitqueuetask.py:
231 * Scripts/webkitpy/tool/bot/flakytestreporter.py:
232 * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
233 * Scripts/webkitpy/tool/commands/queues.py:
235 2011-04-12 Daniel Bates <dbates@rim.com>
237 Rubber-stamped by Eric Seidel.
239 svn-apply and/or patch(1) has trouble applying patches that makes changes to files
240 with Windows line endings
241 https://bugs.webkit.org/show_bug.cgi?id=53625
243 Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
244 applied to an SCM checkout on a Windows file system and vice-versa.
246 This issue manifests itself due to custom SCM settings as well as differences in
247 gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
248 into svn-apply/unapply to compensate for differences in line endings by converting
249 the line endings in a patch to match the line endings in the target file (if it exists).
251 * Scripts/VCSUtils.pm:
252 - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
253 content read from the specified file handle. Obviously, this heuristic will not work
254 for files with mixed line endings, but I don't envision such files to be the norm. If
255 this turns out to be an issue then we can improve the heuristic.
256 - Added firstEOLInFile().
257 - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
258 In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
259 endings in the diff instead of the line endings in the target file.
260 - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
261 re-used in parseDiff().
262 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
263 to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
264 mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
265 * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
266 * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.
268 2011-04-12 Sam Weinig <sam@webkit.org>
270 Reviewed by Adam Roben.
272 REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
273 https://bugs.webkit.org/show_bug.cgi?id=58336
275 * WebKitTestRunner/TestController.cpp:
276 (WTR::TestController::resetStateToConsistentValues):
277 Remove cache clearing as that is causing tests to crash on Windows 7.
279 2011-04-11 Sam Weinig <sam@webkit.org>
281 Reviewed by Anders Carlsson.
283 REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
284 <rdar://problem/8981346>
285 https://bugs.webkit.org/show_bug.cgi?id=54159
287 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
288 (WTR::InjectedBundlePage::InjectedBundlePage):
289 (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
290 (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
291 (WTR::InjectedBundlePage::decidePolicyForResponse):
292 (WTR::InjectedBundlePage::unableToImplementPolicy):
293 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
294 Add short-circuited policy client which matches WebKit1.
296 * WebKitTestRunner/TestController.cpp:
297 (WTR::TestController::resetStateToConsistentValues):
298 Clear the cache between tests to ensure consistent results.
300 2011-04-11 George Guo <George.Guo@nokia.com>
302 Reviewed by Eric Seidel.
304 prepare-ChangeLog support email input but -h did not show the option
305 https://bugs.webkit.org/show_bug.cgi?id=58164
307 Add email option to -h to improve the usability
309 * Scripts/prepare-ChangeLog:
311 2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
313 Reviewed by Eric Carlson.
315 Rename MediaControls to MediaControlRootElement.
316 https://bugs.webkit.org/show_bug.cgi?id=58250
318 * Scripts/do-webcore-rename: Documented the renaming.
320 2011-04-11 Sam Weinig <sam@webkit.org>
324 * MiniBrowser/win/BrowserView.cpp:
325 (BrowserView::create):
327 2011-04-11 Sam Weinig <sam@webkit.org>
329 Reviewed by Anders Carlsson.
331 Move focus management out of WebKit via the UIClient
332 <rdar://problem/8784068>
333 https://bugs.webkit.org/show_bug.cgi?id=58278
335 * MiniBrowser/mac/BrowserWindowController.m:
336 (-[BrowserWindowController awakeFromNib]):
337 * WebKitTestRunner/TestController.cpp:
338 (WTR::TestController::createOtherPage):
339 (WTR::TestController::initialize):
340 Add stubs for new UIClient functions.
342 2011-02-03 Martin Robinson <mrobinson@igalia.com>
344 Reviewed by Eric Seidel.
346 [GTK] The GTK+ DRT needs an implementation of the PlainTextController
347 https://bugs.webkit.org/show_bug.cgi?id=53605
349 Add an implementation of the PlainTextController for the GTK+ DRT.
351 * DumpRenderTree/gtk/DumpRenderTree.cpp:
352 (addControllerToWindow): Added this helper method.
353 (webViewWindowObjectCleared): Use the new helper to add EventSender
354 and the PlainTextController to the window object.
355 * GNUmakefile.am: Added PlainTextController source files.
356 * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
357 on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
358 until that functionality exists somewhere in the WebKitGTK+ stack.
359 * DumpRenderTree/gtk/PlainTextController.h: Added.
361 2011-04-11 Yael Aharon <yael.aharon@nokia.com>
367 * Scripts/webkitpy/common/config/committers.py:
369 2011-04-11 Dirk Pranke <dpranke@chromium.org>
371 Reviewed by Adam Roben.
373 new-run-webkit-tests: fix crash when running under windows cmd.exe
374 https://bugs.webkit.org/show_bug.cgi?id=58197
376 We would intermittently crash when running NRWT directly under
377 cmd.exe on windows because we were sharing the stdin file
378 descriptor between the python process and the http server.
379 cmd.exe really didn't like that, and there was no reason to
380 share the descriptor, so we now use a PIPE instead.
382 * Scripts/webkitpy/layout_tests/port/http_server.py:
384 2011-04-11 Dirk Pranke <dpranke@chromium.org>
386 Reviewed by Ojan Vafai.
388 new-run-webkit-tests: add unit tests for Port.diff_image()
389 https://bugs.webkit.org/show_bug.cgi?id=58196
391 Add the unit tests for the fix in bug 58195.
393 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
394 * Scripts/webkitpy/layout_tests/port/port_testcase.py:
395 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
397 2011-04-11 Dirk Pranke <dpranke@chromium.org>
399 Reviewed by Tony Chang.
401 new-run-webkit-tests: implement support for audio, take two
402 https://bugs.webkit.org/show_bug.cgi?id=58195
404 Attempt to re-land the fix for bug 58101 (which was initially
405 landed in r83330, but rolled out). This is the same patch but
406 fixes crashes in Port.diff_image() caused by the change for
407 empty image files being None instead of ''.
409 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
410 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
411 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
412 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
413 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
414 * Scripts/webkitpy/layout_tests/port/base.py:
415 * Scripts/webkitpy/layout_tests/port/chromium.py:
416 * Scripts/webkitpy/layout_tests/port/dryrun.py:
417 * Scripts/webkitpy/layout_tests/port/mock_drt.py:
418 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
419 * Scripts/webkitpy/layout_tests/port/test.py:
420 * Scripts/webkitpy/layout_tests/port/webkit.py:
422 2011-04-11 Mario Sanchez Prada <msanchez@igalia.com>
424 Reviewed by Xan Lopez.
426 [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
427 https://bugs.webkit.org/show_bug.cgi?id=57854
429 Implement missing features in GTK's DRT.
431 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
432 (indexRangeInTable): New helper function to get the range string
433 for the current cell inside the parent table, either from the
434 point of view of rows or columns.
435 (AccessibilityUIElement::rowIndexRange): Implemented by relying on
436 the new helper function indexRangeInTable().
437 (AccessibilityUIElement::columnIndexRange): Ditto.
439 2011-04-11 Mario Sanchez Prada <msanchez@igalia.com>
441 Reviewed by Chris Fleizach.
443 [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
444 https://bugs.webkit.org/show_bug.cgi?id=57826
446 Implement missing feature in GTK's DRT.
448 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
449 (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
450 relying on the analogous function from the AtkTable interface.
452 2011-04-05 Timothy Hatcher <timothy@apple.com>
454 Fix the extract-localizable-strings script errors that started after
455 WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
457 * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
459 2011-04-11 Tony Chang <tony@chromium.org>
461 Reviewed by Eric Seidel.
463 fix crc computation on 64 bit machines
464 https://bugs.webkit.org/show_bug.cgi?id=58243
466 unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
468 * DumpRenderTree/CyclicRedundancyCheck.cpp:
471 * DumpRenderTree/CyclicRedundancyCheck.h:
472 * DumpRenderTree/PixelDumpSupport.cpp:
474 (convertChecksumToPNGComment):
476 2011-04-10 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
478 Reviewed by Eric Seidel.
480 Require no undefined symbols during compilation.
482 [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
483 https://bugs.webkit.org/show_bug.cgi?id=54896
485 Add -Wl,--no-undefined to catch missing symbols early.
487 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
488 * WebKitTestRunner/qt/WebKitTestRunner.pro:
490 2011-04-10 Kevin Ollivier <kevino@theolliviers.com>
492 [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
494 * wx/build/settings.py:
496 2011-04-10 Kevin Ollivier <kevino@theolliviers.com>
498 [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
500 * wx/build/settings.py:
502 2011-04-10 David Levin <levin@chromium.org>
504 Reviewed by Dimitri Glazkov.
506 REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
507 https://bugs.webkit.org/show_bug.cgi?id=58201
509 * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
512 2011-04-09 David Levin <levin@chromium.org>
514 Unreviewed, rolling out r83394.
515 http://trac.webkit.org/changeset/83394
516 https://bugs.webkit.org/show_bug.cgi?id=53625
518 Patch was incorrect as noted in the bug.
522 2011-04-09 David Levin <levin@chromium.org>
524 Reviewed by Adam Barth.
526 svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
527 https://bugs.webkit.org/show_bug.cgi?id=53625
529 * Scripts/svn-apply: Ensure that the portions of patches
530 which are for vcproj/vsprops files has DOS line endings.
532 2011-04-09 Dirk Pranke <dpranke@chromium.org>
534 Reviewed by Tony Chang.
536 It looks like NRWT has not been stopping DRT/TestShell
537 instances properly on windows, probably for a long time.
538 This would go a long way to explaining why we often have
539 processes lying around :)
541 https://bugs.webkit.org/show_bug.cgi?id=57807
543 * Scripts/webkitpy/layout_tests/port/chromium.py:
544 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
546 2011-04-09 Keith Kyzivat <keith.kyzivat@nokia.com>
548 Reviewed by Laszlo Gombos.
550 [Qt] Don't link against fontconfig or X11 if embedded
551 https://bugs.webkit.org/show_bug.cgi?id=58104
553 * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
554 * QtTestBrowser/QtTestBrowser.pro: ditto
555 * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
556 * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
558 2011-04-08 Jon Honeycutt <jhoneycutt@apple.com>
560 http/tests/loading/preload-append-scan.php is failing on Windows
561 https://bugs.webkit.org/show_bug.cgi?id=58178
563 Reviewed by Brian Weinstein.
565 * DumpRenderTree/win/DumpRenderTree.cpp:
567 Use CFURL API to find the last path component, rather than
568 PathFindFileName(), because the latter will include the query string.
570 2011-04-08 Jian Li <jianli@chromium.org>
572 Unreviewed, rolling out r83327, r83330 since these patches are very
573 likely to break chromium webkit mac10.6 builders.
575 * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
576 * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
577 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
578 * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
579 * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
580 * Scripts/webkitpy/layout_tests/port/base.py:
581 * Scripts/webkitpy/layout_tests/port/chromium.py:
582 * Scripts/webkitpy/layout_tests/port/dryrun.py:
583 * Scripts/webkitpy/layout_tests/port/mock_drt.py:
584 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
585 * Scripts/webkitpy/layout_tests/port/test.py:
586 * Scripts/webkitpy/layout_tests/port/webkit.py:
588 2011-04-08 Vincent Scheib <scheib@chromium.org>
590 Reviewed by Eric Seidel.
592 add chromium-gpu-linux-x86_64 to the recognized list of ports
593 https://bugs.webkit.org/show_bug.cgi?id=58099
595 Add chromium-gpu-linux-x86_64 to fix assert.
597 * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
599 2011-04-08 Alpha Lam <hclam@chromium.org>
601 Unreviewed, rolling out r83335.
602 http://trac.webkit.org/changeset/83335
603 https://bugs.webkit.org/show_bug.cgi?id=53556
605 GTK and QT bots are broken
607 * Scripts/build-webkit:
609 2011-04-07 Anna Cavender <annacc@chromium.org>
611 Reviewed by Eric Carlson.
613 Setup ENABLE(TRACK) feature define
614 https://bugs.webkit.org/show_bug.cgi?id=53556
616 * Scripts/build-webkit:
618 2011-04-08 Dirk Pranke <dpranke@chromium.org>
620 Reviewed by Adam Roben.
622 new-run-webkit-tests: configure a NRWT test bot for Mac SL
623 https://bugs.webkit.org/show_bug.cgi?id=58114
625 This change removes the old new-run-webkit-tests entry and
626 updates it for a new test-only bot.
628 * BuildSlaveSupport/build.webkit.org-config/config.json:
630 2011-04-08 Dominic Cooney <dominicc@google.com>
632 Reviewed by Adam Roben.
634 Make layoutTestController.shadowRoot return null, not undefined,
635 when its argument is invalid.
636 https://bugs.webkit.org/show_bug.cgi?id=58121
638 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
639 (LayoutTestController::shadowRoot):
640 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
641 (WTR::LayoutTestController::shadowRoot):
643 2011-04-08 Pere Martir <pere.martir4@gmail.com>
645 Reviewed by Adam Roben.
647 Locate NSTD.EXE in 64-bit Windows
648 https://bugs.webkit.org/show_bug.cgi?id=57847
650 * Scripts/old-run-webkit-tests:
652 2011-04-08 Adam Roben <aroben@apple.com>
656 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
658 2011-04-07 Adam Roben <aroben@apple.com>
660 Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
662 Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
665 Reviewed by Anders Carlsson.
667 * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
668 (pluginLogWithArguments): Moved code to format and log the message here...
669 (pluginLog): ...from here.
671 * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
673 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
674 (PluginTest::log): Added. Calls through to pluginLogWithArguments.
676 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
678 * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
679 (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
681 (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
683 (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
684 can be used to invoke our setWillBeDestroyed function.
685 (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
686 anything unexpected happens).
687 (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
688 NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
689 NPP_SetWindow was *not* called during destruction.
690 (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
691 method, setWillBeDestroyed.
692 (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
695 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
696 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
697 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
701 * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
702 WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
704 2011-04-08 Mario Sanchez Prada <msanchez@igalia.com>
706 Reviewed by Martin Robinson.
708 [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
709 https://bugs.webkit.org/show_bug.cgi?id=58039
711 Implement missing functions in GTK's DRT.
713 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
714 (AccessibilityUIElement::increment): Implemented.
715 (AccessibilityUIElement::decrement): Implemented.
717 2011-04-08 Dominic Cooney <dominicc@google.com>
719 Reviewed by Kent Tamura.
721 Make WK2 layoutTestController.shadowRoot return undefined, not
722 null, when its argument is not an element.
723 https://bugs.webkit.org/show_bug.cgi?id=58121
725 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
726 (WTR::LayoutTestController::shadowRoot):
728 2011-04-07 Dirk Pranke <dpranke@chromium.org>
730 Reviewed by Mihai Parparita.
732 Change reference port for Mac GPU baselines from
733 Leopard to SnowLeopard, XP to Win7, and Linux-x86
736 https://bugs.webkit.org/show_bug.cgi?id=58099
738 * Scripts/webkitpy/layout_tests/port/chromium.py:
740 2011-04-07 Andrew Scherkus <scherkus@chromium.org>
742 Revert ENABLE_TRACK patch due to compile failures.
744 * Scripts/build-webkit:
746 2011-04-07 Tony Chang <tony@chromium.org>
748 Reviewed by Eric Seidel.
750 update DRT to embed checksums in png files
751 https://bugs.webkit.org/show_bug.cgi?id=57871
753 We insert the bytes for the comment in printPNG rather than at encode
754 time because each platform does its own PNG encoding (either using CG
755 or cairo). Putting this in pringPNG avoids having to duplicate this
756 code, although it's not as clean as doing it at encoding time.
758 We insert the comment right after the IHDR chunk of the PNG.
760 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
761 * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
762 (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
763 (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
764 * DumpRenderTree/CyclicRedundancyCheck.h: Added.
765 * DumpRenderTree/PixelDumpSupport.cpp:
766 (dumpWebViewAsPixelsAndCompareWithExpected):
767 (convertChecksumToPNGComment): Generate the bytes to insert.
768 (printPNG): Insert the png comment before the first IDAT section.
769 * DumpRenderTree/PixelDumpSupport.h:
770 * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
773 * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
776 * DumpRenderTree/win/DumpRenderTree.vcproj:
779 2011-04-07 Jeff Miller <jeffm@apple.com>
781 Reviewed by Adam Roben.
783 Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
784 https://bugs.webkit.org/show_bug.cgi?id=58058
786 * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
787 (TestWebKitAPI::TEST): Add tests for WKStringGetLength() and WKStringGetCharactersPtr().
789 2011-04-07 Chang Shu <cshu@webkit.org>
791 Reviewed by Darin Adler.
793 WebKitTestRunner needs layoutTestController.isPageBoxVisible
794 https://bugs.webkit.org/show_bug.cgi?id=42695
796 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
797 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
798 (WTR::LayoutTestController::isPageBoxVisible):
799 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
801 2011-04-07 Adam Roben <aroben@apple.com>
805 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
807 2011-04-07 Adam Roben <aroben@apple.com>
809 Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
811 commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
812 (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
813 hook we have, so we have to do our work there. I added a new addCustomURLs method which can
814 be overridden by subclasses to provide extra URLs before we call up to the base class (after
815 which adding more URLs is no longer possible).
817 Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
820 Reviewed by John Sullivan.
822 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
823 (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
824 (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
825 method is never called for MasterShellCommands.
826 (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
827 with this method (which is).
829 2011-04-07 Adam Roben <aroben@apple.com>
831 Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
833 This matches how most of our other build steps work, so is good just for improving
834 consistency between build steps. It should also make it possible for
835 ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
836 trying to do this in finished() after we had called up to the base class, but that was
837 apparently too late to add more URLs.)
839 Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
842 Reviewed by John Sullivan.
844 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
845 (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
846 call setText to get the right text to show up for this step. This matches how most of our
847 other build steps work.
848 (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
849 This is how most of our other build steps work.
850 (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
851 function, to match the base class.
853 2011-04-07 Adam Barth <abarth@webkit.org>
855 Reviewed by Maciej Stachowiak.
857 webkit-patch shouldn't state the whole working copy when calling check-webkit-style
858 https://bugs.webkit.org/show_bug.cgi?id=58022
860 Previously, we were ignoring the args variable! This patch fixes the
861 regression introduced in http://trac.webkit.org/changeset/82771.
863 * Scripts/webkitpy/tool/commands/download_unittest.py:
864 * Scripts/webkitpy/tool/mocktool.py:
865 * Scripts/webkitpy/tool/steps/checkstyle.py:
867 2011-04-07 Maciej Stachowiak <mjs@apple.com>
869 Reviewed by Adam Barth.
871 REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
872 https://bugs.webkit.org/show_bug.cgi?id=58017
874 * Scripts/webkitpy/common/checkout/scm.py:
875 * Scripts/webkitpy/common/checkout/scm_unittest.py:
877 2011-04-06 Chang Shu <cshu@webkit.org>
879 Reviewed by Darin Adler.
881 WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
882 https://bugs.webkit.org/show_bug.cgi?id=57984
884 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
885 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
886 (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
887 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
889 2011-04-06 Chris Rogers <crogers@google.com>
891 Reviewed by Tony Chang.
893 Add web audio support to DumpRenderTree (mac port)
894 https://bugs.webkit.org/show_bug.cgi?id=57969
896 * DumpRenderTree/LayoutTestController.cpp:
897 (LayoutTestController::LayoutTestController):
898 (setEncodedAudioDataCallback):
899 (LayoutTestController::staticFunctions):
900 * DumpRenderTree/LayoutTestController.h:
901 (LayoutTestController::dumpAsAudio):
902 (LayoutTestController::setDumpAsAudio):
903 (LayoutTestController::encodedAudioData):
904 (LayoutTestController::setEncodedAudioData):
905 * DumpRenderTree/mac/DumpRenderTree.mm:
909 2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>
911 Reviewed by Kenneth Rohde Christiansen.
913 [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
914 https://bugs.webkit.org/show_bug.cgi?id=56086
916 Add the missing method.
918 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
919 (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
920 * DumpRenderTree/qt/DumpRenderTreeQt.h:
921 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
922 (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
924 2011-04-06 Dai Mikurube <dmikurube@chromium.org>
926 Reviewed by David Levin.
928 Add QUOTA build flag for unified quota API
929 https://bugs.webkit.org/show_bug.cgi?id=57918
931 * Scripts/build-webkit: Added QUOTA build flag
933 2011-04-06 Dirk Pranke <dpranke@chromium.org>
935 Reviewed by Tony Chang.
937 Adjust the apple webkit port's default timeout to match
938 old-run-webkit-tests at 35 seconds.
940 https://bugs.webkit.org/show_bug.cgi?id=37738
942 * Scripts/webkitpy/layout_tests/port/mac.py:
944 2011-04-06 Scott Cameron <sccameron@rim.com>
946 Reviewed by Eric Seidel.
948 Remove global variable $httpdPath and replace with the return value of
949 getHTTPDPath(). Also remove unnecessary calls to getHTTPDPath().
950 https://bugs.webkit.org/show_bug.cgi?id=53499
952 * Scripts/run-iexploder-tests:
953 * Scripts/webkitperl/httpd.pm:
955 2011-04-06 Kevin Ollivier <kevino@theolliviers.com>
957 Reviewed by Darin Adler.
959 Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
961 https://bugs.webkit.org/show_bug.cgi?id=27551
963 * DumpRenderTree/config.h:
964 * WebKitAPITest/config.h:
965 * WebKitTestRunner/config.h:
967 2011-04-06 Tony Chang <tony@chromium.org>
969 Reviewed by Darin Adler.
971 teach run-webkit-tests to read checksums from png files
972 https://bugs.webkit.org/show_bug.cgi?id=57993
974 * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
975 no .checksum and look for the checksum in there.
977 2011-04-06 David Dorwin <ddorwin@chromium.org>
979 Reviewed by David Levin.
981 Enable fullscreen layout tests for Chromium
982 https://bugs.webkit.org/show_bug.cgi?id=55726
984 Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
986 * DumpRenderTree/chromium/WebPreferences.cpp:
987 (WebPreferences::applyTo):
989 2011-04-06 Adam Roben <aroben@apple.com>
991 Add a "view leaks" link to builds on SnowLeopard Intel Leaks
993 Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
995 Reviewed by David Kilzer.
997 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
998 (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
999 build's results directory here...
1000 (ExtractTestResults.finished): ...from here.
1001 (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
1002 (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
1003 leaks" link to point to Leaks Viewer for this build.
1004 (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
1005 but it seemed good to add for consistency with BuildAndTestFactory.
1006 (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
1007 (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
1008 that we'll get a "view leaks" link.
1010 2011-04-06 Zan Dobersek <zandobersek@gmail.com>
1012 Reviewed by Eric Seidel.
1014 [Gtk] plugins/set-status.html fails
1015 https://bugs.webkit.org/show_bug.cgi?id=57844
1017 Allow an empty status text to be dumped.
1019 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1020 (webViewStatusBarTextChanged):
1022 2011-04-06 Chang Shu <cshu@webkit.org>
1024 Reviewed by Darin Adler.
1026 WebKitTestRunner needs layoutTestController.pageNumberForElementById
1027 https://bugs.webkit.org/show_bug.cgi?id=42329
1029 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1030 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1031 (WTR::LayoutTestController::pageNumberForElementById):
1032 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1034 2011-04-06 Sergio Villar Senin <svillar@igalia.com>
1036 Reviewed by Martin Robinson.
1038 [GTK] DumpRenderTree: do not try to free NULL SoupURIs
1039 https://bugs.webkit.org/show_bug.cgi?id=57932
1041 Some Layout tests have invalid URIs that do not generate valid
1042 SoupURI instances. Do not try to free those NULL SoupURIs.
1044 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1045 (willSendRequestCallback):
1047 2011-04-06 Csaba Osztrogonác <ossy@webkit.org>
1049 Reviewed by Andreas Kling.
1051 ORWT shouldn't generate diff files for tests without expected files
1052 https://bugs.webkit.org/show_bug.cgi?id=57846
1054 * Scripts/old-run-webkit-tests:
1056 2011-04-05 Kevin Ollivier <kevino@theolliviers.com>
1058 [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
1061 * wx/install-unix-extras:
1063 2011-04-05 Sheriff Bot <webkit.review.bot@gmail.com>
1065 Unreviewed, rolling out r82978, r82999, and r83001.
1066 http://trac.webkit.org/changeset/82978
1067 http://trac.webkit.org/changeset/82999
1068 http://trac.webkit.org/changeset/83001
1069 https://bugs.webkit.org/show_bug.cgi?id=57913
1071 Does not work in Python 2.5 (Requested by abarth on #webkit).
1073 * Scripts/webkitpy/common/system/executive.py:
1074 * Scripts/webkitpy/common/system/executive_unittest.py:
1076 2011-04-05 Chang Shu <cshu@webkit.org>
1078 Reviewed by Darin Adler.
1080 WebKitTestRunner needs layoutTestController.numberOfPages
1081 https://bugs.webkit.org/show_bug.cgi?id=42694
1083 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1084 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1085 (WTR::LayoutTestController::numberOfPages):
1086 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1088 2011-04-05 Tony Chang <tony@chromium.org>
1090 Reviewed by Mihai Parparita.
1092 [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
1093 https://bugs.webkit.org/show_bug.cgi?id=57889
1095 * Scripts/webkitpy/layout_tests/port/chromium.py:
1096 * Scripts/webkitpy/layout_tests/port/test.py:
1097 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1099 2011-04-05 Adam Barth <abarth@webkit.org>
1101 Silly with statement, from the future!
1103 * Scripts/webkitpy/common/system/executive.py:
1105 2011-04-05 Adam Barth <abarth@webkit.org>
1107 Reviewed by Tony Chang.
1109 Don't use Exception.message because it's deprecated
1110 https://bugs.webkit.org/show_bug.cgi?id=57892
1112 Suppress the warning for now. When we move to Python 3, we might need
1113 to something more dramatic.
1115 * Scripts/webkitpy/common/system/executive.py:
1117 2011-04-05 Mihai Parparita <mihaip@chromium.org>
1119 Reviewed by Ojan Vafai.
1121 Add builders.js to dashboard file list
1122 https://bugs.webkit.org/show_bug.cgi?id=57899
1124 Add file added by http://crrev.com/80538 to dashboard file list.
1126 * TestResultServer/handlers/dashboardhandler.py:
1128 2011-04-05 MORITA Hajime <morrita@google.com>
1130 Reviewed by Adam Barth.
1132 webkit-patch should print git's stderr when git svn dcommit fail
1133 http://webkit.org/b/57861
1135 * Scripts/webkitpy/common/checkout/scm.py:
1137 2011-04-05 Mihai Parparita <mihaip@chromium.org>
1139 Reviewed by Tony Chang.
1141 Add --baseline-search-path to NRWT
1142 https://bugs.webkit.org/show_bug.cgi?id=56233
1144 Add NRWT option to specify additional directories to look for baselines
1145 (will be used by hardware GPU bots which will have local per-bot
1146 expectations for some tests)
1148 * Scripts/webkitpy/common/system/filesystem_mock.py:
1149 * Scripts/webkitpy/layout_tests/port/base.py:
1150 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1151 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1153 2011-04-05 Adam Roben <aroben@apple.com>
1155 Strip off /results.html from results URLs before trying to load leaks files from them
1157 r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
1158 files, rather than pointing to the directory that contains them. This is more convenient for
1159 people browsing build.webkit.org, but confused Leaks Viewer.
1161 Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
1164 Reviewed by Joseph Pecoraro.
1166 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1167 (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
1169 2011-04-05 Carol Szabo <carol@webkit.org>
1173 Updated my info in committers.py
1175 Scripts\webkitpy\common\config\committers.py
1177 2011-04-05 Csaba Osztrogonác <ossy@webkit.org>
1179 Reviewed by Laszlo Gombos.
1181 [Qt] Make WebKitLibraries optional for building QtWebKit
1182 https://bugs.webkit.org/show_bug.cgi?id=57542
1184 * Scripts/build-webkit:
1186 2011-04-05 Chang Shu <cshu@webkit.org>
1188 Reviewed by Laszlo Gombos.
1190 [Qt] MiniBrowser defaultUrl does not work
1191 https://bugs.webkit.org/show_bug.cgi?id=57021
1193 Match the behavior and coding of MiniBrowser to QtTestBrowser.
1194 * MiniBrowser/qt/main.cpp:
1197 2011-04-05 Jade Han <jade.han@nokia.com>
1199 Reviewed by Laszlo Gombos.
1201 [Qt] [Symbian] Disable WebKitTestRunner for Symbian
1202 https://bugs.webkit.org/show_bug.cgi?id=54977
1204 This change is a preparation to enable building webkit2 for Symbian.
1205 Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
1209 2011-04-05 Zoltan Horvath <zoltan@webkit.org>
1211 Reviewed by Andreas Kling.
1213 [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
1214 https://bugs.webkit.org/show_bug.cgi?id=57832
1216 Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
1218 * MiniBrowser/qt/UrlLoader.cpp:
1219 (UrlLoader::UrlLoader):
1221 2011-04-05 Zoltan Horvath <zoltan@webkit.org>
1223 [Qt] Linux Release minimal build fix after r82919.
1225 * MiniBrowser/qt/BrowserWindow.cpp:
1226 (BrowserWindow::loadURLListFromFile):
1227 * QtTestBrowser/launcherwindow.cpp:
1228 (LauncherWindow::loadURLListFromFile):
1230 2011-04-05 Zoltan Horvath <zoltan@webkit.org>
1232 Reviewed by Andreas Kling.
1234 [Qt] Make URL loader accessible from testbrowser's menus
1235 https://bugs.webkit.org/show_bug.cgi?id=57823
1237 Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
1239 * MiniBrowser/qt/BrowserWindow.cpp:
1240 (BrowserWindow::BrowserWindow):
1241 (BrowserWindow::loadURLListFromFile):
1242 (BrowserWindow::~BrowserWindow):
1243 * MiniBrowser/qt/BrowserWindow.h:
1244 * QtTestBrowser/launcherwindow.cpp:
1245 (LauncherWindow::LauncherWindow):
1246 (LauncherWindow::~LauncherWindow):
1247 (LauncherWindow::createChrome):
1248 (LauncherWindow::loadURLListFromFile):
1249 * QtTestBrowser/launcherwindow.h:
1251 2011-04-04 Sam Weinig <sam@webkit.org>
1253 Reviewed by Brian Weinstein.
1255 Remove duplicate API from WKContext
1256 <rdar://problem/8727879>
1257 https://bugs.webkit.org/show_bug.cgi?id=57815
1259 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1260 * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
1261 * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1262 Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
1264 2011-04-04 Tony Chang <tony@chromium.org>
1266 Reviewed by Ojan Vafai.
1268 [chromium] don't write .checksum files if a fallback platform has an embedded checksum
1269 https://bugs.webkit.org/show_bug.cgi?id=57783
1271 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1272 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1274 2011-04-04 Kevin Ollivier <kevino@theolliviers.com>
1276 [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
1279 * Scripts/webkitdirs.pm:
1281 2011-04-04 Martin Robinson <mrobinson@igalia.com>
1283 Reviewed by Gustavo Noronha Silva.
1286 https://bugs.webkit.org/show_bug.cgi?id=31517
1288 Add support to the DRT for turning on WebGL when a layout tests requests it.
1290 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1291 (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
1293 2011-04-04 Chang Shu <cshu@webkit.org>
1295 Reviewed by Darin Adler.
1297 WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
1298 https://bugs.webkit.org/show_bug.cgi?id=57572
1300 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1301 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1302 (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
1303 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1305 2011-04-04 Keith Kyzivat <keith.kyzivat@nokia.com>
1307 Reviewed by Csaba Osztrogonác.
1309 [Qt] DumpRenderTree breaks compilation in some uClibc environments
1310 https://bugs.webkit.org/show_bug.cgi?id=57602
1312 * DumpRenderTree/qt/main.cpp:
1315 2011-04-04 Kevin Ollivier <kevino@theolliviers.com>
1317 [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
1319 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1320 (LayoutTestController::shadowRoot):
1322 2011-04-04 Pavel Podivilov <podivilov@chromium.org>
1324 Unreviewed, fix exception in rebaseline tool.
1326 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1328 2011-04-02 Beth Dakin <bdakin@apple.com>
1330 Rubber-stamped by Geoff Garen.
1333 * DumpRenderTree/mac/DumpRenderTree.mm:
1334 (resetWebViewToConsistentStateBeforeTesting):
1336 2011-04-02 Beth Dakin <bdakin@apple.com>
1338 Rubber-stamped by Geoff Garen.
1340 Need to reset the scale, much like zoom.
1341 * DumpRenderTree/mac/DumpRenderTree.mm:
1342 (resetWebViewToConsistentStateBeforeTesting):
1344 2011-04-02 Sam Weinig <sam@webkit.org>
1346 Reviewed by Beth Dakin.
1348 https://bugs.webkit.org/show_bug.cgi?id=57605
1349 Frame::pageScaleFactor() should not affect getBoundingClientRect() or
1352 <rdar://problem/9194541>
1354 Add DRT support for the scaleWebView SPI.
1355 * DumpRenderTree/mac/EventSendingController.mm:
1356 (+[EventSendingController isSelectorExcludedFromWebScript:]):
1357 (+[EventSendingController webScriptNameForSelector:]):
1358 (-[EventSendingController scalePageBy:atX:andY:]):
1359 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1360 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1361 (WTR::EventSendingController::scalePageBy):
1362 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1363 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1364 (WTR::InjectedBundlePage::reset):
1366 2011-04-02 Dominic Cooney <dominicc@google.com>
1368 Reviewed by Martin Robinson.
1370 Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1371 https://bugs.webkit.org/show_bug.cgi?id=57551
1373 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1374 (LayoutTestController::shadowRoot):
1376 2011-04-02 Patrick Gansterer <paroga@webkit.org>
1378 Reviewed by Eric Seidel.
1380 Remove AbstractStep._run_script and move script names to ports.py
1381 https://bugs.webkit.org/show_bug.cgi?id=57704
1383 Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
1385 * Scripts/webkitpy/common/config/ports.py:
1386 * Scripts/webkitpy/tool/commands/download_unittest.py:
1387 * Scripts/webkitpy/tool/commands/roll_unittest.py:
1388 * Scripts/webkitpy/tool/commands/upload_unittest.py:
1389 * Scripts/webkitpy/tool/steps/abstractstep.py:
1390 * Scripts/webkitpy/tool/steps/checkstyle.py:
1391 * Scripts/webkitpy/tool/steps/preparechangelog.py:
1392 * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1393 * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1395 2011-04-02 Patrick Gansterer <paroga@webkit.org>
1397 Reviewed by Eric Seidel.
1399 Emulate shebang on Win32
1400 https://bugs.webkit.org/show_bug.cgi?id=55927
1402 Scripts on Windows work only if they are called with the explicit interpreter.
1403 Read the first line of scripts to detect the correct executable.
1405 * Scripts/webkitpy/common/config/ports.py:
1406 * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
1407 * Scripts/webkitpy/common/system/executive_unittest.py:
1409 2011-04-01 Adam Barth <abarth@webkit.org>
1411 Reviewed by Eric Seidel.
1413 apos entities shouldn't show up in ChangeLogs when using webkit-patch
1414 https://bugs.webkit.org/show_bug.cgi?id=57692
1416 Previously, we were using BeautifulSoup to process XML from
1417 bugs.webkit.org, but that's incorrect. We should be using
1418 BeautifulStoneSoup to process the XML. We were getting the '
1419 entity wrong because ' is an XML entity but not an HTML entity.
1421 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1422 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1424 2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
1426 Unreviewed, rolling out r82721.
1427 http://trac.webkit.org/changeset/82721
1428 https://bugs.webkit.org/show_bug.cgi?id=57687
1430 This patch introduced assertion failures on the GTK+ bots.
1431 (Requested by mrobinson on #webkit).
1433 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1434 (LayoutTestController::shadowRoot):
1436 2011-04-01 Csaba Osztrogonác <ossy@webkit.org>
1438 Unreviewed buildfix.
1440 [Qt][WK2] Build Webkit2 using "-2" option on Qt
1441 https://bugs.webkit.org/show_bug.cgi?id=55074
1443 * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
1444 (The isWK2() function removes it from @ARGV, but not from @options.)
1446 2011-04-01 Keith Kyzivat <keith.kyzivat@nokia.com>
1448 Reviewed by Csaba Osztrogonác.
1450 [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
1451 https://bugs.webkit.org/show_bug.cgi?id=57666
1453 * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
1455 2011-04-01 Dirk Pranke <dpranke@chromium.org>
1457 Reviewed by Adam Barth.
1459 new-run-webkit-tests: fix feature detection, skipped platform lists on mac
1461 We apparently never implemented the code to skip tests based on
1462 what was compiled into DRT. Also, change the logic used to skip
1463 platform directories to match what old-run-webkit-tests does:
1464 skip every test not in a directory in the baseline search path.
1466 https://bugs.webkit.org/show_bug.cgi?id=57662
1468 * Scripts/webkitpy/layout_tests/port/mac.py:
1469 * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1470 * Scripts/webkitpy/layout_tests/port/webkit.py:
1472 2011-03-29 Mark Rowe <mrowe@apple.com>
1474 Reviewed by Jon Honeycutt.
1476 <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
1478 Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
1480 * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1481 * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1482 * Scripts/webkitpy/layout_tests/port/mac.py:
1483 * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1485 2011-04-01 Chang Shu <cshu@webkit.org>
1487 Reviewed by Csaba Osztrogonác.
1489 [Qt][WK2] Build Webkit2 using "-2" option on Qt
1490 https://bugs.webkit.org/show_bug.cgi?id=55074
1492 * Scripts/build-webkit:
1494 2011-04-01 Dirk Pranke <dpranke@chromium.org>
1496 Reviewed by Tony Chang.
1498 new-run-webkit-tests: remove spurious port version override in webkit.py
1499 base.py provides a default implementation so this is just
1502 https://bugs.webkit.org/show_bug.cgi?id=57667
1504 * Scripts/webkitpy/layout_tests/port/webkit.py:
1505 * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1507 2011-04-01 Csaba Osztrogonác <ossy@webkit.org>
1509 Reviewed by Adam Roben.
1511 Make view results on waterfall direct link to results.html
1512 https://bugs.webkit.org/show_bug.cgi?id=57671
1514 * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
1515 * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
1517 2011-04-01 Sam Weinig <sam@webkit.org>
1521 * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
1522 (TestWebKitAPI::TEST):
1523 * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1524 (TestWebKitAPI::flushMessages):
1526 2011-04-01 Sam Weinig <sam@webkit.org>
1528 Reviewed by Adam Roben.
1530 Add adoptWK to WKRetainPtr.h
1531 https://bugs.webkit.org/show_bug.cgi?id=57670
1533 * TestWebKitAPI/PlatformUtilities.h:
1534 * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1535 * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1536 * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1537 * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1538 * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1539 * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1540 * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1541 * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1542 (TestWebKitAPI::createSessionStateContainingFormData):
1543 * WebKitTestRunner/StringFunctions.h:
1544 Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
1546 2011-04-01 Sam Weinig <sam@webkit.org>
1548 Reviewed by Adam Roben.
1550 Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
1552 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1553 (WTR::LayoutTestController::shadowRoot):
1554 Make judicious use of adoptWK().
1556 2011-04-01 Sam Weinig <sam@webkit.org>
1558 Reviewed by Timothy Hatcher.
1560 Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
1562 * Scripts/extract-localizable-strings:
1564 2011-04-01 Anders Carlsson <andersca@apple.com>
1566 Reviewed by Sam Weinig.
1568 Shockwave plug-in doesn't accept mouse events
1569 https://bugs.webkit.org/show_bug.cgi?id=57653
1570 <rdar://problem/8483273>
1574 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1575 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1576 (PluginTest::indicateTestFailure):
1577 Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
1579 (PluginTest::NPN_ConvertPoint):
1580 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1581 * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1582 (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1583 Call indicateTestFailure.
1585 * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
1586 * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
1587 (ConvertPoint::ConvertPoint):
1588 (ConvertPoint::testConvert):
1589 (ConvertPoint::NPP_New):
1591 2011-04-01 Dominic Cooney <dominicc@google.com>
1593 Reviewed by Martin Robinson.
1595 Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1596 https://bugs.webkit.org/show_bug.cgi?id=57551
1598 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1599 (LayoutTestController::shadowRoot):
1601 2011-04-01 Sam Weinig <sam@webkit.org>
1603 Reviewed by Anders Carlsson.
1605 WebKitTestRunner needs layoutTestController.shadowRoot
1606 https://bugs.webkit.org/show_bug.cgi?id=57661
1608 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1609 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1610 (WTR::LayoutTestController::shadowRoot):
1611 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1612 Implement layoutTestController.shadowRoot for WebKit2.
1614 2011-04-01 Chang Shu <cshu@webkit.org>
1616 Reviewed by Darin Adler.
1618 WebKitTestRunner needs layoutTestController.setDatabaseQuota
1619 https://bugs.webkit.org/show_bug.cgi?id=57568
1621 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1622 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1623 (WTR::LayoutTestController::setDatabaseQuota):
1624 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1626 2011-04-01 Dirk Pranke <dpranke@chromium.org>
1628 Reviewed by Tony Chang.
1630 This patch completes the cleanup of
1631 rebaseline-chromium-webkit-tests to work with all of the
1632 variants of a platform (we can now rebaseline gpu- and non-gpu
1633 files at the same time).
1635 When the rebaselining is complete, any lines declared as
1636 REBASELINE in the expectations file that matches a test that was
1637 actually rebaselined will be deleted, even if only one of the
1638 variants was actually rebaselined. This may cause odd problems,
1639 but is better than where we're at today.
1641 This change removes the -g flag and deprecates -w. The -g flag is gone
1642 because GPU baselines are handled just like any other variant.
1643 The -w flag is deprecated because this tool now only works
1644 against the canaries, since that's the only place we have a full
1645 set of bots. It will be trivial to change this to
1646 build.webkit.org if we decide that's where we want them to be.
1648 Also, this patch deletes a lot of cruft that is no longer needed
1649 in the test_expectations code and the port-specific code.
1651 https://bugs.webkit.org/show_bug.cgi?id=55191
1653 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1654 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1655 * Scripts/webkitpy/layout_tests/port/base.py:
1656 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1657 * Scripts/webkitpy/layout_tests/port/chromium.py:
1658 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1659 * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1660 * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1661 * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1662 * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1663 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1664 * Scripts/webkitpy/layout_tests/port/mac.py:
1665 * Scripts/webkitpy/layout_tests/port/test.py:
1666 * Scripts/webkitpy/layout_tests/port/webkit.py:
1667 * Scripts/webkitpy/layout_tests/port/win.py:
1668 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1669 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1671 2011-04-01 Dirk Pranke <dpranke@chromium.org>
1673 Reviewed by Adam Barth.
1675 rebaseline-chromium-webkit-tests does not work correctly with
1676 version-specific baselines. This patch updates the tool to use
1677 all of the version-specific bots on the canaries, and will now
1678 attempt to rebaseline all of the versions by default, although
1679 it will not update both GPU and CPU versions.
1681 Also, it will no longer modify the test_expectations.txt file
1682 *at all*. You will have to manually delete the REBASELINE lines
1683 after running the tool and determining that it did what you
1684 wanted it to do. This should be fixed in a separate bug - see
1687 https://bugs.webkit.org/show_bug.cgi?id=55608
1689 * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1690 * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1691 * Scripts/webkitpy/layout_tests/port/chromium.py:
1692 * Scripts/webkitpy/layout_tests/port/test.py:
1693 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1694 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1696 2011-03-31 Tony Chang <tony@chromium.org>
1698 Reviewed by Ojan Vafai.
1700 [chromium] update the rebaseline tool to know about pngs with checksums
1701 https://bugs.webkit.org/show_bug.cgi?id=57481
1703 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
1704 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1706 2011-04-01 Adam Roben <aroben@apple.com>
1708 Retrieve revision numbers from the build's got_revision property in Leaks Viewer
1710 Previously, we were getting the revision of the first revision that triggered a build.
1711 Choosing the last revision would have been more accurate. But got_revision is what is used
1712 everywhere else on build.webkit.org, and should work even when there were no changes that
1713 triggered a build (e.g., if someone clicked the Force Build button).
1715 Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
1718 Reviewed by Anders Carlsson.
1720 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1721 (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
1722 property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
1724 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
1725 (Array.prototype.first): Added this helper function to return the first element in an array
1726 that matches the given predicate, or null if no such element exists.
1728 2011-03-31 Adam Roben <aroben@apple.com>
1730 Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
1732 Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
1734 Reviewed by Darin Adler.
1736 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1737 (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
1738 URL on its own line.
1740 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1741 (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
1742 progression, and added a new test that uses a short bug URL while I was at it.
1744 2011-04-01 Adam Roben <aroben@apple.com>
1746 Mark .vcproj/.vsprops/.sln files as being Windows-only
1748 Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
1750 Reviewed by Anders Carlsson.
1752 * Scripts/webkitpy/common/config/build.py:
1753 (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
1754 directories as Windows-only.
1756 * Scripts/webkitpy/common/config/build_unittest.py:
1757 (ShoulBuildTest): Added test cases for the above.
1759 2011-04-01 Keith Kyzivat <keith.kyzivat@nokia.com>
1761 Reviewed by Laszlo Gombos.
1763 [Qt] Build MiniBrowser for Symbian
1764 https://bugs.webkit.org/show_bug.cgi?id=56319
1766 Have MiniBrowser reference it's own copy of useragentlist.txt instead
1767 of copying QtTestBrowser's.
1768 Remove Tools/MiniBrowser/DerivedSources.pro
1769 This reduces complexity in the Tools scripts due to Symbian limitations.
1771 * DerivedSources.pro:
1772 * MiniBrowser/DerivedSources.pro: Removed.
1773 * MiniBrowser/MiniBrowser.qrc:
1774 * MiniBrowser/qt/MiniBrowser.pro:
1775 * Scripts/webkitdirs.pm:
1777 2011-03-31 Chang Shu <cshu@webkit.org>
1779 Reviewed by Darin Adler.
1781 WebKitTestRunner needs layoutTestController.clearAllDatabases
1782 https://bugs.webkit.org/show_bug.cgi?id=42540
1784 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1785 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1786 (WTR::InjectedBundle::beginTesting):
1787 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1788 (WTR::LayoutTestController::clearAllDatabases):
1789 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1791 2011-03-31 Chang Shu <cshu@webkit.org>
1793 Reviewed by Darin Adler.
1795 WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
1796 https://bugs.webkit.org/show_bug.cgi?id=42692
1798 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1800 2011-03-31 Darin Adler <darin@apple.com>
1802 Reviewed by Sam Weinig.
1804 Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
1805 https://bugs.webkit.org/show_bug.cgi?id=57573
1807 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1808 Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
1809 Removed fake definitions of keyDown and contextClick.
1811 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1812 (WTR::operator==): Added. So we can compare two WKPoint structs.
1813 (WTR::parseModifier): Added.
1814 (WTR::parseModifierArray): Added.
1815 (WTR::EventSendingController::EventSendingController): Initialize the
1817 (WTR::EventSendingController::mouseDown): Added. Calls
1818 WKBundlePageSimulateMouseDown.
1819 (WTR::EventSendingController::mouseUp): Added. Calls
1820 WKBundlePageSimulateMouseUp.
1821 (WTR::EventSendingController::mouseMoveTo): Added. Calls
1822 WKBundlePageSimulateMouseMotion.
1823 (WTR::EventSendingController::leapForward): Added.
1824 (WTR::EventSendingController::updateClickCount): Added. Used by the
1825 mouseDown/Up functions to create a click count.
1827 * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
1828 for the changes above.
1830 2011-03-31 Sergio Villar Senin <svillar@igalia.com>
1832 Reviewed by Martin Robinson.
1834 [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
1835 https://bugs.webkit.org/show_bug.cgi?id=57362
1837 Do not generate DRT output if willSendRequestReturnsNull is set.
1839 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1840 (willSendRequestCallback):
1842 2011-03-31 Vamshikrishna.Yellenki <vamshi@motorola.com> and Alejandro G. Castro <alex@igalia.com>
1844 Reviewed by Martin Robinson.
1846 Implement MiniBrowser for Gtk port.
1847 https://bugs.webkit.org/show_bug.cgi?id=48512
1849 Initial implementation of the Gtk MiniBrowser.
1851 * MiniBrowser/gtk/GNUmakefile.am: Added.
1852 * MiniBrowser/gtk/main.c: Added.
1853 (activateUriEntryCallback):
1856 (goForwardCallback):
1863 2011-03-30 Dominic Cooney <dominicc@google.com>
1865 Reviewed by Dimitri Glazkov.
1867 Adds layoutTestController.shadowRoot accessor to Mac DRT.
1868 https://bugs.webkit.org/show_bug.cgi?id=57415
1870 * DumpRenderTree/LayoutTestController.cpp:
1871 (shadowRootCallback):
1872 (LayoutTestController::staticFunctions):
1873 * DumpRenderTree/LayoutTestController.h:
1874 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1875 (LayoutTestController::shadowRoot):
1876 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1877 (LayoutTestController::shadowRoot):
1879 2011-03-30 Matthew Delaney <mdelaney@apple.com>
1881 Reviewed by Chris Marrin.
1883 Update fast/canvas tests to avoid dumping the render tree when possible
1884 https://bugs.webkit.org/show_bug.cgi?id=57493
1886 * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
1887 accelerated drawing and accelerated drawing for canvas
1889 2011-03-30 Adam Roben <aroben@apple.com>
1891 Stop ignoring leaks in CGGradientCreateWithColorStops
1893 Fixes <rdar://problem/7888547>.
1895 Rubber-stamped by John Sullivan.
1897 * Scripts/old-run-webkit-tests:
1898 (countAndPrintLeaks): Removed some code to ignore those leaks.
1900 2011-03-30 Timur Iskhodzhanov <timurrrr@google.com>
1902 Reviewed by Alexey Proskuryakov.
1904 Add some dynamic annotations to JavaScriptCore/wtf
1905 https://bugs.webkit.org/show_bug.cgi?id=53747
1907 By using these annotations we can improve the precision of finding
1908 WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
1909 These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
1911 These files don't add new functionality, so don't need extra tests.
1913 * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
1915 2011-03-30 Steve Falkenburg <sfalken@apple.com>
1917 Reviewed by Adam Roben.
1919 Share most vsprops between Release and Production builds in releaseproduction.vsprops
1920 https://bugs.webkit.org/show_bug.cgi?id=57508
1922 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1923 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
1924 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
1925 * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1926 * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
1927 * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
1928 * DumpRenderTree/win/ImageDiffProduction.vsprops:
1929 * DumpRenderTree/win/ImageDiffRelease.vsprops:
1930 * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
1931 * FindSafari/FindSafariProduction.vsprops:
1932 * FindSafari/FindSafariRelease.vsprops:
1933 * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
1934 * FindSafari/FindSafariReleasePGO.vsprops:
1935 * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1936 * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
1937 * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
1938 * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
1939 * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
1940 * WebKitAPITest/WebKitAPITestProduction.vsprops:
1941 * WebKitAPITest/WebKitAPITestRelease.vsprops:
1942 * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
1943 * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1944 * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
1945 * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
1946 * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1947 * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
1948 * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
1949 * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1950 * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
1951 * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
1952 * WinLauncher/WinLauncherProduction.vsprops:
1953 * WinLauncher/WinLauncherRelease.vsprops:
1954 * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
1955 * record-memory-win/record-memory-winProduction.vsprops:
1956 * record-memory-win/record-memory-winRelease.vsprops:
1957 * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
1959 2011-03-30 Steve Falkenburg <sfalken@apple.com>
1961 Reviewed by Adam Roben.
1963 Update Windows production build logic for new production configurations
1964 https://bugs.webkit.org/show_bug.cgi?id=57494
1966 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1967 * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1968 * DumpRenderTree/win/ImageDiffProduction.vsprops:
1969 * FindSafari/FindSafariProduction.vsprops:
1970 * FindSafari/FindSafariReleasePGO.vsprops:
1971 * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1972 * WebKitAPITest/WebKitAPITestProduction.vsprops:
1973 * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1974 * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1975 * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1976 * WinLauncher/WinLauncherProduction.vsprops:
1977 * record-memory-win/record-memory-winProduction.vsprops:
1979 2011-03-30 Robert Hogan <robert@webkit.org>
1981 Reviewed by Antonio Gomes.
1983 [Qt] Fix LoadHTMLStringItem::invoke() after r75966
1984 Unskip http/tests/navigation/go-back-to-error-page.html
1986 Also add the location of DumpRenderTreeSupportQt.h
1987 to DRT's include paths.
1989 https://bugs.webkit.org/show_bug.cgi?id=52614
1991 * DumpRenderTree/qt/DumpRenderTree.pro:
1992 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1993 * DumpRenderTree/qt/DumpRenderTreeQt.h:
1994 * DumpRenderTree/qt/GCControllerQt.cpp:
1995 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1996 (LayoutTestController::queueLoadHTMLString):
1997 * DumpRenderTree/qt/LayoutTestControllerQt.h:
1998 * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1999 * DumpRenderTree/qt/TextInputControllerQt.cpp:
2000 * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2001 (LoadAlternateHTMLStringItem::invoke):
2002 * DumpRenderTree/qt/WorkQueueItemQt.h:
2003 (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2004 * QtTestBrowser/QtTestBrowser.pro:
2005 * QtTestBrowser/launcherwindow.h:
2007 2011-03-30 Adam Barth <abarth@webkit.org>
2009 Reviewed by Adam Roben.
2011 SheriffBot rollouts take too long
2012 https://bugs.webkit.org/show_bug.cgi?id=57498
2014 We used to build before landing rollouts via the commit-queue to
2015 prevent further breakage, but now that our individual commit-queue
2016 machines are slower, building takes too long. I can't remember the
2017 last time a rollout broke compile. It seems like just landing the
2018 patch is the better trade-off.
2020 * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2021 * Scripts/webkitpy/tool/commands/queues_unittest.py:
2023 2011-03-30 Adam Barth <abarth@webkit.org>
2025 Remove platform/chromium-mac-snowleopard
2026 https://bugs.webkit.org/show_bug.cgi?id=57486
2028 This directory no longer exists, so we can remove it from the fallback
2031 * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2033 2011-03-30 Steve Falkenburg <sfalken@apple.com>
2035 Reviewed by Adam Roben.
2037 Rename Windows configuration Release_LTCG to Production for clarity
2038 https://bugs.webkit.org/show_bug.cgi?id=57465
2040 * DumpRenderTree/DumpRenderTree.sln:
2041 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2042 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
2043 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
2044 * DumpRenderTree/win/DumpRenderTree.vcproj:
2045 * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
2046 * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
2047 * DumpRenderTree/win/ImageDiff.vcproj:
2048 * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
2049 * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
2050 * FindSafari/FindSafari.vcproj:
2051 * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
2052 * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
2053 * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
2054 * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
2055 * MiniBrowser/MiniBrowser.vcproj:
2056 * Scripts/webkitdirs.pm:
2057 * TestWebKitAPI/win/TestWebKitAPI.sln:
2058 * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2059 * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
2060 * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2061 * WebKitAPITest/WebKitAPITest.vcproj:
2062 * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
2063 * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
2064 * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2065 * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
2066 * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
2067 * WebKitTestRunner/WebKitTestRunner.sln:
2068 * WebKitTestRunner/win/InjectedBundle.vcproj:
2069 * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
2070 * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
2071 * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
2072 * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2073 * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
2074 * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
2075 * WinLauncher/WinLauncher.vcproj:
2076 * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
2077 * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
2078 * record-memory-win/record-memory-win.vcproj:
2079 * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
2080 * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
2082 2011-03-30 MORITA Hajime <morrita@google.com>
2084 Reviewed by Dimitri Glazkov.
2086 [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
2087 https://bugs.webkit.org/show_bug.cgi?id=56573
2089 Added LayoutTestController.shadowRoot() to Chromium DRT.
2091 * DumpRenderTree/chromium/LayoutTestController.cpp:
2092 (LayoutTestController::LayoutTestController):
2093 (LayoutTestController::shadowRoot):
2094 * DumpRenderTree/chromium/LayoutTestController.h:
2096 2011-03-30 Yuta Kitamura <yutak@chromium.org>
2098 Reviewed by Kent Tamura.
2100 [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
2101 https://bugs.webkit.org/show_bug.cgi?id=57430
2103 * DumpRenderTree/chromium/LayoutTestController.cpp:
2104 (LayoutTestController::LayoutTestController):
2105 (LayoutTestController::setPluginsEnabled):
2106 * DumpRenderTree/chromium/LayoutTestController.h:
2108 2011-03-30 Maciej Stachowiak <mjs@apple.com>
2110 Reviewed by Adam Barth.
2112 make webkit-patch upload respect -d
2113 https://bugs.webkit.org/show_bug.cgi?id=57425
2115 * Scripts/webkitpy/common/checkout/scm.py:
2116 * Scripts/webkitpy/tool/steps/commit.py:
2118 2011-03-30 Maciej Stachowiak <mjs@apple.com>
2120 Reviewed by Adam Barth.
2122 Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
2123 https://bugs.webkit.org/show_bug.cgi?id=57429
2125 * Scripts/webkitpy/common/checkout/scm.py:
2127 2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
2129 Unreviewed, rolling out r82383.
2130 http://trac.webkit.org/changeset/82383
2131 https://bugs.webkit.org/show_bug.cgi?id=57417
2133 "nrwt isn't shutting down cleanly" (Requested by dpranke on
2136 * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2137 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2138 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2140 2011-03-29 Kent Tamura <tkent@chromium.org>
2142 Reviewed by Dimitri Glazkov.
2144 Make validation message bubble testable
2145 https://bugs.webkit.org/show_bug.cgi?id=57290
2147 * DumpRenderTree/mac/DumpRenderTree.mm:
2148 (createWebViewAndOffscreenWindow): Change a setting so that validation
2149 bubbles isn't hidden automatically.
2151 2011-03-29 Dirk Pranke <dpranke@chromium.org>
2153 Reviewed by Ojan Vafai.
2155 new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
2157 It's a bit unclear whether multiple threads or multiple
2158 processes will be a better model on windows. This change will
2159 test threads for now while we're still working out the bugs in
2162 https://bugs.webkit.org/show_bug.cgi?id=57410
2164 * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2165 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2166 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2168 2011-03-29 David Levin <levin@chromium.org>
2170 Reviewed by Shinichiro Hamaji.
2172 check-webkit-style confused by two ChangeLog entries in a row from same user
2173 https://bugs.webkit.org/show_bug.cgi?id=57250
2175 * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
2176 * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
2177 * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
2178 It basically assumes only one ChangeLog entry is being processed because that is the standard case and
2179 checking more than that would be very messey.
2180 * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
2181 * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
2183 2011-03-29 Kent Tamura <tkent@chromium.org>
2185 Reviewed by Dimitri Glazkov.
2187 [Mac] Enable interactive-validation tests on Mac DRT
2188 https://bugs.webkit.org/show_bug.cgi?id=57308
2190 * DumpRenderTree/mac/DumpRenderTree.mm:
2191 (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
2193 2011-03-29 Chang Shu <cshu@webkit.org>
2195 Reviewed by Kenneth Rohde Christiansen.
2197 WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
2198 https://bugs.webkit.org/show_bug.cgi?id=42692
2200 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2201 (WTR::InjectedBundle::beginTesting):
2202 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2203 (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
2204 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2206 2011-03-24 Martin Robinson <mrobinson@igalia.com>
2208 Reviewed by Xan Lopez.
2210 [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
2211 https://bugs.webkit.org/show_bug.cgi?id=57067
2213 Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
2214 will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
2215 update DRT and pixel results as hundreds of results will need to be updated.
2217 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2218 (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
2219 by overriding the theme RC/CSS files.
2221 2011-03-29 Steve Falkenburg <sfalken@apple.com>
2223 Reviewed by Adam Roben.
2225 Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
2226 https://bugs.webkit.org/show_bug.cgi?id=57394
2228 Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
2229 InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
2230 the IDE. To avoid this, add a separate vsprops file for each project configuration that
2231 contains the required inherited property sheets.
2233 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2234 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
2235 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
2236 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
2237 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
2238 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
2239 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
2240 * DumpRenderTree/win/DumpRenderTree.vcproj:
2241 * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
2242 * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
2243 * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
2244 * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
2245 * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
2246 * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
2247 * DumpRenderTree/win/ImageDiff.vcproj:
2248 * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
2249 * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
2250 * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
2251 * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
2252 * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
2253 * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
2254 * FindSafari/FindSafari.vcproj:
2255 * FindSafari/FindSafariDebug.vsprops: Added.
2256 * FindSafari/FindSafariDebugAll.vsprops: Added.
2257 * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
2258 * FindSafari/FindSafariRelease.vsprops: Added.
2259 * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
2260 * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
2261 * FindSafari/FindSafariReleasePGO.vsprops: Added.
2262 * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
2263 * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
2264 * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
2265 * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
2266 * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
2267 * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
2268 * MiniBrowser/MiniBrowser.vcproj:
2269 * WebKitAPITest/WebKitAPITest.vcproj:
2270 * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
2271 * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
2272 * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
2273 * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
2274 * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
2275 * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
2276 * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2277 * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
2278 * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
2279 * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
2280 * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
2281 * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
2282 * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
2283 * WebKitTestRunner/win/InjectedBundle.vcproj:
2284 * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
2285 * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
2286 * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
2287 * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
2288 * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
2289 * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
2290 * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2291 * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
2292 * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
2293 * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
2294 * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
2295 * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
2296 * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
2297 * WinLauncher/WinLauncher.vcproj:
2298 * WinLauncher/WinLauncherDebug.vsprops: Added.
2299 * WinLauncher/WinLauncherDebugAll.vsprops: Added.
2300 * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
2301 * WinLauncher/WinLauncherRelease.vsprops: Added.
2302 * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
2303 * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
2304 * record-memory-win/record-memory-win.vcproj:
2305 * record-memory-win/record-memory-winDebug.vsprops: Added.
2306 * record-memory-win/record-memory-winDebugAll.vsprops: Added.
2307 * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
2308 * record-memory-win/record-memory-winRelease.vsprops: Added.
2309 * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
2310 * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
2312 2011-03-29 Adam Barth <abarth@webkit.org>
2314 Reviewed by Darin Adler.
2316 test_runner2.py can crash due to undefined variable
2317 https://bugs.webkit.org/show_bug.cgi?id=57356
2319 Replace reference to undefined variable with a variable that's actually
2320 defined. AFAICT, there's no way to test this code.
2322 * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
2324 2011-03-29 Tony Chang <tony@chromium.org>
2326 Reviewed by Eric Seidel.
2328 cleanup rebaseline-chromium-webkit-tests
2329 https://bugs.webkit.org/show_bug.cgi?id=57375
2331 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2332 - Split _extract_and_add_new_baselines into 3 functions
2333 - Reduce the amount of line wrapping (the file already has lines
2334 over 80 col, so may as well try to make the file consistent)
2335 - Remove unnecessary ()s
2337 2011-03-29 Brent Fulgham <bfulgham@webkit.org>
2339 Reviewed by Adam Roben.
2341 Make WinCairo a core builder.
2342 https://bugs.webkit.org/show_bug.cgi?id=57373
2344 * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
2345 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
2347 2011-03-29 Timothy Hatcher <timothy@apple.com>
2349 Update update-webkit-localizable-strings to understand that WebKit and
2350 WebKit2 strings go in WebCore.
2352 Also make extract-localizable-strings optionally use an exclude file. No individual
2353 warnings are produced about unlocalized strings when there is no exclude file. This
2354 is needed for WebCore, since there are too many bare strings.
2356 https://webkit.org/b/57354
2358 Reviewed by Sam Weinig.
2360 * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
2361 * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
2363 2011-03-29 Darin Adler <darin@apple.com>
2365 Reviewed by Adam Roben.
2367 WebKit2 bundle page needs to offer generated file hooks
2368 https://bugs.webkit.org/show_bug.cgi?id=57279
2370 (Land missing part of the original patch after r82289.)
2372 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2373 (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
2375 2011-03-29 Tony Chang <tony@chromium.org>
2377 Reviewed by Ojan Vafai.
2379 [chromium] NRWT should be able to read checksums from png comments
2380 https://bugs.webkit.org/show_bug.cgi?id=57280
2382 * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
2384 * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
2385 * Scripts/webkitpy/common/system/filesystem_mock.py:
2386 * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
2387 if the -checksum.txt file doesn't exist, try looking in the png.
2388 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2389 * Scripts/webkitpy/layout_tests/port/test.py:
2390 * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
2391 2k for a png comment with the checksum
2392 * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
2394 2011-03-29 Philippe Normand <pnormand@igalia.com>
2396 Rubber-stamped by Gustavo Noronha Silva.
2398 [GTK] http/tests/uri/username-with-no-hostname.html fails
2399 https://bugs.webkit.org/show_bug.cgi?id=57325
2401 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2402 (willSendRequestCallback): URI host value check done case-insensitively.
2404 2011-03-29 Philippe Normand <pnormand@igalia.com>
2406 Reviewed by Martin Robinson.
2408 [GTK] http/tests/uri/username-with-no-hostname.html fails
2409 https://bugs.webkit.org/show_bug.cgi?id=57325
2411 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2412 (willSendRequestCallback): Check URI before submitting the request
2415 2011-03-29 Noel Gordon <noel.gordon@gmail.com>
2417 Reviewed by Ojan Vafai.
2419 [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
2420 https://bugs.webkit.org/show_bug.cgi?id=57303
2422 * DumpRenderTree/chromium/EventSender.cpp:
2423 (EventSender::doDragDrop):
2424 (EventSender::beginDragWithFiles):
2426 2011-03-29 Zoltan Horvath <zoltan@webkit.org>
2428 Reviewed by Andreas Kling.
2430 [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
2431 https://bugs.webkit.org/show_bug.cgi?id=57314
2433 Provide possibility to print loaded urls to the standard output.
2435 * MiniBrowser/qt/BrowserWindow.cpp:
2436 (BrowserWindow::BrowserWindow):
2437 (BrowserWindow::printURL):
2438 * MiniBrowser/qt/BrowserWindow.h:
2439 * MiniBrowser/qt/MiniBrowserApplication.cpp:
2440 (MiniBrowserApplication::handleUserOptions):
2441 * MiniBrowser/qt/MiniBrowserApplication.h:
2442 (WindowOptions::WindowOptions):
2443 * QtTestBrowser/launcherwindow.cpp:
2444 (LauncherWindow::initializeView):
2445 (LauncherWindow::printURL):
2446 (LauncherWindow::cloneWindow):
2447 * QtTestBrowser/launcherwindow.h:
2448 (WindowOptions::WindowOptions):
2449 * QtTestBrowser/main.cpp:
2450 (LauncherApplication::handleUserOptions):
2452 2011-03-29 Gabor Loki <loki@webkit.org>
2454 Rubber-stamped by Csaba Osztrogonác.
2456 [Qt] Teach build-jsc how to build JavaScriptCore on Qt
2457 https://bugs.webkit.org/show_bug.cgi?id=56918
2459 * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
2461 2011-03-28 Gabor Loki <loki@webkit.org>
2463 Reviewed by Csaba Osztrogonác.
2465 [Qt] Teach build-jsc how to build JavaScriptCore on Qt
2466 https://bugs.webkit.org/show_bug.cgi?id=56918
2468 * Scripts/build-jsc:
2469 * Scripts/webkitdirs.pm:
2471 2011-03-28 Andrew Foster <andrewf@chromium.org>
2473 Reviewed by Ojan Vafai.
2475 webkit-patch should be more intelligent about whether a bug applies to a patch
2476 Create a new function, parse_bug_id_from_changelog() which determines
2477 that a bug is related to a patch by parsing the output generated from
2478 prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
2479 the description of a patch.
2480 https://bugs.webkit.org/show_bug.cgi?id=56989
2482 * Scripts/webkitpy/common/checkout/api.py:
2483 * Scripts/webkitpy/common/checkout/changelog.py:
2484 * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2485 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2486 * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2487 * Scripts/webkitpy/style/checkers/changelog.py:
2488 * Scripts/webkitpy/tool/commands/upload.py:
2490 2011-03-28 Maciej Stachowiak <mjs@apple.com>
2492 Revert accidentally commited change.
2494 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2495 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2497 2011-03-28 Tony Chang <tony@chromium.org>
2499 Reviewed by Adam Barth.
2501 [chromium] have DRT write the png checksum into a png comment
2502 https://bugs.webkit.org/show_bug.cgi?id=57255
2504 * DumpRenderTree/chromium/TestShell.cpp:
2505 (TestShell::dumpImage):
2507 2011-03-28 Adele Peterson <adele@apple.com>
2509 Removing Qt stub, since it doesn't use the same header as the others.
2511 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2513 2011-03-28 Adele Peterson <adele@apple.com>
2515 Added a few more stubs.
2517 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2518 (LayoutTestController::hasGrammarMarker):
2519 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2520 (LayoutTestController::hasGrammarMarker):
2521 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2522 (LayoutTestController::hasGrammarMarker):
2524 2011-03-28 Adele Peterson <adele@apple.com>
2528 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2529 (LayoutTestController::hasGrammarMarker):
2531 2011-03-28 Adele Peterson <adele@apple.com>
2533 Reviewed by Eric Seidel.
2535 Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
2536 https://bugs.webkit.org/show_bug.cgi?id=57173
2538 * DumpRenderTree/LayoutTestController.cpp:
2539 (hasGrammarMarkerCallback): Added.
2540 (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
2541 * DumpRenderTree/LayoutTestController.h:
2542 * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
2543 * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
2545 2011-03-28 Csaba Osztrogonác <ossy@webkit.org>
2547 Reviewed by Benjamin Poulain.
2549 [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2550 https://bugs.webkit.org/show_bug.cgi?id=57087
2552 Trivial typo fix after r82082.
2554 * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2555 (WTR::activateFonts):
2557 2011-03-28 Alexis Menard <alexis.menard@openbossa.org>
2559 Reviewed by Andreas Kling.
2561 Add myself to the committers list.
2563 * Scripts/webkitpy/common/config/committers.py:
2565 2011-03-28 Simon Fraser <simon.fraser@apple.com>
2567 Reviewed by Sam Weinig.
2569 WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
2570 to link against WebKit.framework for now.
2572 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2574 2011-03-28 Benjamin Poulain <benjamin.poulain@nokia.com>
2576 Reviewed by Andreas Kling.
2578 [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2579 https://bugs.webkit.org/show_bug.cgi?id=57087
2581 Disable QT_ASCII_CAST_WARNINGS for applications.
2583 * DumpRenderTree/qt/DumpRenderTree.pro:
2584 * DumpRenderTree/qt/ImageDiff.pro:
2585 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2586 * MiniBrowser/qt/MiniBrowser.pro:
2587 * QtTestBrowser/QtTestBrowser.pro:
2588 * WebKitTestRunner/qt/WebKitTestRunner.pro:
2590 2011-03-28 Andreas Kling <kling@webkit.org>
2592 Reviewed by Kenneth Rohde Christiansen.
2594 [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
2595 https://bugs.webkit.org/show_bug.cgi?id=57224
2597 * QtTestBrowser/mainwindow.cpp:
2598 (MainWindow::buildUI):
2599 (MainWindow::onTitleChanged):
2600 * QtTestBrowser/mainwindow.h:
2602 2011-03-27 Jer Noble <jer.noble@apple.com>
2604 Reviewed by Maciej Stachowiak.
2606 Full Screen: disable keyboard access by default
2607 https://bugs.webkit.org/show_bug.cgi?id=56684
2609 Accept the withKeyboard parameter to supportsFullScreenForElement.
2611 * DumpRenderTree/mac/UIDelegate.mm:
2612 (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
2614 2011-03-27 Patrick Gansterer <paroga@webkit.org>
2616 Reviewed by David Levin.
2618 check-webkit-style should check ChangeLog for a valid bug number
2619 https://bugs.webkit.org/show_bug.cgi?id=57184
2621 * Scripts/webkitpy/style/checker.py:
2622 * Scripts/webkitpy/style/checker_unittest.py:
2623 * Scripts/webkitpy/style/checkers/changelog.py: Added.
2624 * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
2626 2011-03-27 Benjamin Poulain <benjamin.poulain@nokia.com>
2628 Reviewed by Andreas Kling.
2630 [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2631 https://bugs.webkit.org/show_bug.cgi?id=57087
2633 Use explicit conversion for string to avoid depending on the default codec
2634 installed by the user code.
2636 * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2637 (WTR::activateFonts):
2639 2011-03-26 Maciej Stachowiak <mjs@apple.com>
2641 Revert inadvertantly committed changes.
2643 * Scripts/old-run-webkit-tests:
2644 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2646 2011-03-26 Andreas Kling <kling@webkit.org>
2648 Reviewed by Kenneth Rohde Christiansen.
2650 [Qt] Show page icons (favicons) in QtTestBrowser location bar.
2651 https://bugs.webkit.org/show_bug.cgi?id=57162
2653 * QtTestBrowser/QtTestBrowser.qrc:
2654 * QtTestBrowser/favicon.png: Added.
2655 * QtTestBrowser/locationedit.cpp:
2657 (LocationEdit::LocationEdit):
2658 (LocationEdit::setPageIcon):
2659 (LocationEdit::resizeEvent):
2660 (LocationEdit::updateInternalGeometry):
2661 * QtTestBrowser/locationedit.h:
2662 * QtTestBrowser/mainwindow.cpp:
2663 (MainWindow::buildUI):
2664 (MainWindow::onIconChanged):
2665 (MainWindow::onLoadStarted):
2666 * QtTestBrowser/mainwindow.h:
2668 2011-03-23 Martin Robinson <mrobinson@igalia.com>
2670 Reviewed by Xan Lopez.
2672 [GTK] Force DumpRenderTree to use 96 DPI
2673 https://bugs.webkit.org/show_bug.cgi?id=56866
2675 Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
2676 broader compatibility with WebKit2 and makes setting font sizes more straightforward.
2678 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2679 (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
2680 (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
2681 (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
2683 2011-03-25 Andy Estes <aestes@apple.com>
2685 Reviewed by Adele Peterson.
2687 REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2688 https://bugs.webkit.org/show_bug.cgi?id=49016
2690 TestNetscapePlugIn needs to register support for an image MIME type so
2691 we can test that the embed tag prefers plug-ins to render image MIME
2694 * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
2695 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2696 (NP_GetMIMEDescription): Ditto.
2697 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
2699 2011-03-25 Jessie Berlin <jberlin@apple.com>
2701 Reviewed by Sam Weinig.
2703 WebKit2: Need to be able to set and get the Cookie Storage Policy.
2704 https://bugs.webkit.org/show_bug.cgi?id=50780
2706 Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
2708 The test is named "CookieManager" so that we can eventually exercise more of the
2709 CookieManager functionality in the test.
2711 * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
2712 (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
2713 Assert that the policy returned is equal to the policy set in
2714 didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
2715 (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
2716 Set the policy to something different than the user's policy and get the policy again.
2717 (TestWebKitAPI::didFinishLoadForFrame):
2718 Get the user's policy so that it can be restored at the end of the test.
2719 (TestWebKitAPI::TEST):
2720 Load about:blank so that the Web Process gets instatiated (needed to get the
2723 * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2724 Add CookieManager.cpp.
2726 2011-03-24 Kevin Ollivier <kevino@theolliviers.com>
2728 [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
2730 * wx/build/settings.py:
2732 2011-03-24 Ilya Sherman <isherman@chromium.org>
2734 Reviewed by Adam Roben.
2736 Implement layoutTestController.setAutoFilled in DRT on Windows
2737 https://bugs.webkit.org/show_bug.cgi?id=56828
2739 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2740 (LayoutTestController::setAutofilled): Implemented.
2742 2011-03-24 Brent Fulgham <bfulgham@webkit.org>
2744 Unreviewed build correction.
2746 Correct vsprops file for Debug variant of the CFLite build.
2747 Disable a CFNETWORK-specific test when building for CFLite.
2749 * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
2750 * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2752 2011-03-24 Dirk Pranke <dpranke@chromium.org>
2754 Reviewed by Adam Barth.
2756 fix regressions introduced in 81908 - there were a couple of
2757 code paths that only fired under python 2.5 that I missed.
2759 Also change a couple of 'python' references to sys.executable
2760 in order to handle runing test-webkitpy with a binary other than
2761 something called 'python'.
2763 https://bugs.webkit.org/show_bug.cgi?id=57063
2765 * Scripts/webkitpy/layout_tests/port/mac.py:
2766 * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2767 * Scripts/webkitpy/test/cat.py:
2768 * Scripts/webkitpy/test/echo.py:
2770 2011-03-24 Brent Fulgham <bfulgham@webkit.org>
2772 Unreviewed build correction.
2774 Add a stub implementation of the TestInvocation dumping logic.
2775 Update project files to reflect new file.
2777 * WebKitTestRunner/cairo: Added.
2778 * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
2779 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2780 * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2782 2011-03-24 Dirk Pranke <dpranke@chromium.org>
2784 Reviewed by Tony Chang.
2786 new-run-webkit-tests: clean up worker model defaults. This
2787 changes the default behavior to 'threads' instead of
2788 'old-threads', and clarifies that chromium-win-* and
2789 chromium-mac-leopard are exceptions.
2791 https://bugs.webkit.org/show_bug.cgi?id=56971
2793 * Scripts/webkitpy/layout_tests/port/base.py:
2794 * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2795 * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2796 * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2797 * Scripts/webkitpy/layout_tests/port/test.py:
2798 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2800 2011-03-23 Leandro Gracia Gil <leandrogracia@chromium.org>
2802 Reviewed by Darin Adler.
2804 Media Stream API: fix the order of the options in build-webkit.
2805 https://bugs.webkit.org/show_bug.cgi?id=56949
2807 Fix the order of the options in build-webkit.
2809 * Scripts/build-webkit:
2811 2011-03-23 Adam Klein <adamk@chromium.org>
2813 Reviewed by Mihai Parparita.
2815 Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
2816 https://bugs.webkit.org/show_bug.cgi?id=56884
2818 This option will be utilized by Chromium's ui_tests to allow
2819 referencing js-test-resources from a layout test over HTTP.
2821 * Scripts/new-run-webkit-httpd:
2822 Added --layout_tests_dir option.
2823 * Scripts/webkitpy/layout_tests/port/http_server.py:
2824 Plumbed through as layout_tests_dir param.
2826 2011-03-23 Dirk Pranke <dpranke@chromium.org>
2828 Reviewed by Mihai Parparita.
2830 new-run-webkit-tests: run tests in ascending alphabetical order per
2831 dir. This is a second attempt at the fix; the first attempt, in
2832 r81597, broke the behavior on the old-inline and old-threads
2835 https://bugs.webkit.org/show_bug.cgi?id=56760
2837 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2838 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2839 * Scripts/webkitpy/layout_tests/port/test.py:
2840 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2842 2011-03-23 Mario Sanchez Prada <msanchez@igalia.com>
2844 Reviewed by Martin Robinson.
2846 [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
2847 https://bugs.webkit.org/show_bug.cgi?id=56953
2849 Print the string for the detail of 'property-change' signal.
2851 * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2852 (axObjectEventListener): Print the detail string.
2854 2011-03-23 Yury Semikhatsky <yurys@chromium.org>
2856 Reviewed by Pavel Feldman.
2858 [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
2859 https://bugs.webkit.org/show_bug.cgi?id=56843
2861 * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2862 * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2864 2011-03-22 Eric Seidel <eric@webkit.org>
2866 Reviewed by Adam Barth.
2868 Teach update-webkit about gyp
2869 https://bugs.webkit.org/show_bug.cgi?id=56881
2871 This makes it possible for someone who builds from Xcode
2872 to just run update-webkit --gyp and have the project files
2873 generated after update automatically.
2875 I also added a stand-alone "generate-project-files" script
2876 wrapping Source/gyp/configure. This makes running gyp simpler
2877 since most people will not have gyp or Source/gyp in their path.
2879 * Scripts/build-webkit:
2880 * Scripts/generate-project-files: Added.
2881 * Scripts/update-webkit:
2883 2011-03-22 Anton D'Auria <adauria@apple.com>
2885 Reviewed by Alexey Proskuryakov.
2887 Add +[WebApplicationCache getOriginsWithCache]
2888 https://bugs.webkit.org/show_bug.cgi?id=56722
2890 * DumpRenderTree/LayoutTestController.cpp:
2891 (originsWithApplicationCacheCallback):
2892 (LayoutTestController::staticFunctions):
2893 * DumpRenderTree/LayoutTestController.h:
2894 * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
2895 (LayoutTestController::originsWithApplicationCache):
2896 * DumpRenderTree/chromium/LayoutTestController.h:
2897 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
2898 (LayoutTestController::originsWithApplicationCache):
2899 * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
2900 (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
2901 (LayoutTestController::originsWithApplicationCache):
2902 (LayoutTestController::originsWithLocalStorage):
2903 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
2904 (LayoutTestController::originsWithApplicationCache):
2905 * DumpRenderTree/qt/LayoutTestControllerQt.h:
2906 * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
2907 (LayoutTestController::originsWithApplicationCache):
2908 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
2909 (LayoutTestController::originsWithApplicationCache):
2911 2011-03-22 Eric Seidel <eric@webkit.org>
2913 Reviewed by Adam Barth.
2915 Add support to build-webkit for building with gyp-generated project files
2916 https://bugs.webkit.org/show_bug.cgi?id=56877
2918 build-webkit is a cesspool. This change just hacks in --gyp support for Mac.
2919 Eventually we'll want to support gyp-generated projects in a more general manner.
2921 * Scripts/build-webkit:
2923 2011-03-22 David Kilzer <ddkilzer@apple.com>
2925 <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
2927 Reviewed by Joseph Pecoraro.
2929 * Scripts/build-webkit: Updated usage statement to include
2931 * Scripts/webkitdirs.pm: Added $generateDsym variable.
2932 (generateDsym): Added. Call determineGenerateDsym() and
2933 return $generateDsym.
2934 (determineGenerateDsym): Added. Parse @ARGV for --dsym and set
2936 (argumentsForXcode): Added. Returns additional arguments for
2937 xcodebuild based on command-line switches.
2938 (XcodeOptions): Updated to include argumentsForXcode() in the
2941 2011-03-22 Adam Roben <aroben@apple.com>
2943 Make Leopard Debug bots and Windows XP Debug (Tests) core builders
2945 These bots are consistently green again.
2947 Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
2950 Rubber-stamped by Antti Koivisto.
2952 * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2953 (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
2955 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2956 (BuildBotTest.test_builder_name_regexps): Updated expectations.
2958 2011-03-21 Sheriff Bot <webkit.review.bot@gmail.com>
2960 Unreviewed, rolling out r81597.
2961 http://trac.webkit.org/changeset/81597
2962 https://bugs.webkit.org/show_bug.cgi?id=56801
2964 Change results in lots of unexpected flaky on the dashboard.
2965 (Requested by pfeldman on #webkit).
2967 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2968 * Scripts/webkitpy/layout_tests/port/test.py:
2969 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2971 2011-03-21 Sam Weinig <sam@webkit.org>
2973 Fix failing tests on the WebKit2 bots.
2975 * WebKitTestRunner/TestController.cpp:
2976 (WTR::TestController::resetStateToConsistentValues):
2978 2011-03-21 Daniel Sievers <sievers@google.com>
2980 Reviewed by Simon Fraser.
2982 [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2983 https://bugs.webkit.org/show_bug.cgi?id=56139
2985 * DumpRenderTree/chromium/DumpRenderTree.cpp:
2987 * DumpRenderTree/chromium/LayoutTestController.cpp:
2988 (LayoutTestController::LayoutTestController):
2989 (LayoutTestController::layerTreeAsText):
2990 * DumpRenderTree/chromium/LayoutTestController.h:
2991 (LayoutTestController::setShowDebugLayerTree):
2992 * DumpRenderTree/chromium/TestShell.cpp:
2993 (TestShell::runFileTest):
2995 * DumpRenderTree/chromium/TestShell.h:
2996 (TestParams::TestParams):
2998 2011-03-21 Adam Roben <aroben@apple.com>
3000 Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
3002 Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
3003 output as plain text
3005 Reviewed by David Kilzer.
3007 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3008 (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
3010 (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
3011 since we're running on the build master, not the slave. Instead, turn the raw source of
3012 actual.html which the build slave uploaded into an HTML log.
3014 2011-03-21 Dirk Pranke <dpranke@chromium.org>
3016 Reviewed by Mihai Parparita.
3018 new-run-webkit-tests: run tests in ascending alphabetical order per dir
3019 https://bugs.webkit.org/show_bug.cgi?id=56760
3021 * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3022 * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3023 * Scripts/webkitpy/layout_tests/port/test.py:
3025 2011-03-21 Leandro Gracia Gil <leandrogracia@chromium.org>
3027 Reviewed by Steve Block.
3029 Media Stream API patch 0: adding compilation guards.
3030 https://bugs.webkit.org/show_bug.cgi?id=56458
3032 Adding options to enable the media stream API feature in Chromium.
3034 * Scripts/build-webkit:
3036 2011-03-21 Qi Zhang <qi.2.zhang@nokia.com>
3038 Reviewed by Laszlo Gombos.
3040 [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
3041 https://bugs.webkit.org/show_bug.cgi?id=56323
3043 Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide
3044 "--stdout" or "--stderr" option.
3046 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3047 (WebCore::DumpRenderTree::~DumpRenderTree):
3048 (WebCore::DumpRenderTree::processArgsLine):
3049 (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
3050 * DumpRenderTree/qt/DumpRenderTreeQt.h:
3051 (WebCore::DumpRenderTree::setRedirectOutputFileName):
3052 (WebCore::DumpRenderTree::setRedirectErrorFileName):
3053 * DumpRenderTree/qt/main.cpp:
3059 2011-03-21 Adam Roben <aroben@apple.com>
3061 Fix exceptions on the buildbot due to my last change
3063 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3064 (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
3066 2011-03-21 Adam Roben <aroben@apple.com>
3068 Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
3070 Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
3071 output as plain text
3073 Reviewed by Darin Adler.
3075 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3076 (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
3078 (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
3079 the build master. This will correctly treat it as HTML.
3081 2011-03-20 Bill Budge <bbudge@chromium.org>
3083 Reviewed by Adam Barth.
3085 Rename ThreadSafeShared to ThreadSafeRefCounted
3086 https://bugs.webkit.org/show_bug.cgi?id=56714
3088 No new tests. Exposes no new functionality.
3090 * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
3091 * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
3092 * Scripts/do-webcore-rename:
3094 2011-03-19 Anton D'Auria <adauria@apple.com>
3096 Reviewed by Dan Bernstein.
3098 Add stub to LayoutTestControllerGtk.cpp to fix GTK build
3099 https://bugs.webkit.org/show_bug.cgi?id=56719
3101 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
3102 (LayoutTestController::clearApplicationCacheForOrigin):
3104 2011-03-19 Anton D'Auria <adauria@apple.com>
3106 Reviewed by Alexey Proskuryakov.
3108 ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
3109 https://bugs.webkit.org/show_bug.cgi?id=56415
3111 * DumpRenderTree/LayoutTestController.cpp:
3112 (clearApplicationCacheForOriginCallback):
3113 (LayoutTestController::staticFunctions):
3114 * DumpRenderTree/LayoutTestController.h:
3115 * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
3116 (LayoutTestController::LayoutTestController):
3117 (LayoutTestController::clearAllApplicationCaches):
3118 (LayoutTestController::clearApplicationCacheForOrigin):
3119 * DumpRenderTree/chromium/LayoutTestController.h:
3120 * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
3121 (LayoutTestController::clearApplicationCacheForOrigin):
3122 * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
3123 (LayoutTestController::clearApplicationCacheForOrigin):
3124 * DumpRenderTree/qt/LayoutTestControllerQt.h:
3125 * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
3126 (LayoutTestController::clearApplicationCacheForOrigin):
3127 * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
3128 (LayoutTestController::clearApplicationCacheForOrigin):
3130 2011-03-18 Dan Bernstein <mitz@apple.com>
3132 Revised build fix for r81135.
3134 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3135 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3137 2011-03-18 Adam Roben <aroben@apple.com>
3141 * WebKitTestRunner/config.h: Add a missing #endif.
3143 2011-03-18 Andreas Kling <kling@webkit.org>
3145 Unbreak Qt build after r81494.
3147 * WebKitTestRunner/qt/TestInvocationQt.cpp:
3148 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3150 2011-03-18 Sam Weinig <sam@webkit.org>
3152 Fix windows build. This was really Adam Roben's fault. I swear!
3154 * WebKitTestRunner/config.h:
3156 2011-03-18 Sam Weinig <sam@webkit.org>
3158 Reviewed by Adam Roben.
3160 Pixel tests don't work in WebKitTestRunner on Windows
3161 https://bugs.webkit.org/show_bug.cgi?id=56630
3163 Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
3164 built-in snapshotting instead of using the window server on the Mac.
3166 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3167 (WTR::InjectedBundle::InjectedBundle):
3168 (WTR::InjectedBundle::didReceiveMessage):
3169 (WTR::InjectedBundle::beginTesting):
3170 (WTR::InjectedBundle::done):
3171 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3172 (WTR::InjectedBundle::setPixelResult):
3173 (WTR::InjectedBundle::shouldDumpPixels):
3174 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3175 (WTR::InjectedBundlePage::dump):
3176 Take the snapshot in the bundle and send it to the UIProcess for dumping.
3178 * WebKitTestRunner/TestInvocation.cpp:
3179 (WTR::TestInvocation::invoke):
3180 (WTR::TestInvocation::dump):
3181 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3182 * WebKitTestRunner/TestInvocation.h:
3183 * WebKitTestRunner/cg: Added.
3184 * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
3185 (WTR::createCGContextFromImage):
3186 (WTR::computeMD5HashStringForContext):
3187 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3188 * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
3189 Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
3191 * WebKitTestRunner/win/TestInvocationWin.cpp:
3192 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3193 Keep stub for Cairo build.
3195 * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
3196 Add CG configuration.
3198 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3199 * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3202 2011-03-18 Adam Roben <aroben@apple.com>
3204 Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
3206 Rubber-stamped by Simon Fraser.
3208 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3209 (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
3210 overflow-y:overlay so that the scrollbar doesn't overlay the content.
3212 2011-03-18 Adam Roben <aroben@apple.com>
3214 Don't ellipsize long or indented function names in Leaks Viewer
3216 Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
3219 Reviewed by Simon Fraser.
3221 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3222 (.data-grid .data-container):
3223 (.data-grid td > div, .data-grid th > div):
3224 Allow the contents to extend to the right.
3226 2011-03-18 Adam Roben <aroben@apple.com>
3228 Fix some leaks in DRT seen on the leaks bot
3230 Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
3231 setWillSendRequestClearHeaderCallback in DRT are leaky
3233 Reviewed by Alexey Proskuryakov.
3235 * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
3237 * DumpRenderTree/LayoutTestController.cpp:
3238 (addURLToRedirectCallback):
3239 (setWillSendRequestClearHeaderCallback):
3240 Use OwnArrayPtr to cause the strings to be deleted.
3242 2011-03-18 Adam Roben <aroben@apple.com>
3244 Fix a NSURLCredential leak seen on the leaks bot
3246 Fixes <http://webkit.org/b/56637> -[SynchronousLoader
3247 connection:didReceiveAuthenticationChallenge:] is leaky
3249 Reviewed by John Sullivan.
3251 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3252 (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
3253 cause the NSURLCredential to be released.
3255 2011-03-18 John Knottenbelt <jknotten@chromium.org>
3259 Remove unnecessary brackets around my email address.
3261 * Scripts/webkitpy/common/config/committers.py:
3263 2011-03-18 Adam Roben <aroben@apple.com>
3265 Remove some files I accidentally added in r81454
3267 * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
3268 * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
3270 2011-03-18 Adam Roben <aroben@apple.com>
3272 Ignore an NSNumberFormatter leak on SnowLeopard
3274 * Scripts/old-run-webkit-tests:
3275 (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
3276 getObjectValue:forString:errorDescription:].
3278 2011-03-18 Adam Roben <aroben@apple.com>
3280 Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
3282 Rubber-stamped by Mark Rowe.
3284 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3285 (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
3288 2011-03-17 Adam Roben <aroben@apple.com>
3290 Address a review comment I missed in r81445
3292 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
3293 (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
3294 leaked bytes to speed up searching on long lines.
3296 2011-03-17 Adam Roben <aroben@apple.com>
3298 Mark leaky builds orange, even if all regression tests passed
3300 Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
3301 build.webkit.org when all tests pass even though there are still leaks
3303 Reviewed by Dan Bernstein.
3305 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3306 (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
3307 be marked orange if this build step generates warnings.
3309 2011-03-17 Adam Roben <aroben@apple.com>
3311 Allow values in Leaks Viewer to be shown as percentages
3313 Double-clicking on a column will toggle between showing percentages and showing real values.
3315 Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
3316 number of leaked bytes in Leaks Viewer
3318 Reviewed by Joe Pecoraro.
3320 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
3321 (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
3322 node's totalTime, which is used in calculating percentages.
3324 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
3325 (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
3326 showing them as percentages.
3328 2011-03-17 Adam Roben <aroben@apple.com>
3330 Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
3332 The Self and Total columns now report the number of leaked bytes. The new Calls column shows
3333 the number of leaked allocations. And the new Average column shows the average number of
3334 leaked bytes per call.
3336 Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
3337 just how many allocations
3339 Reviewed by Joe Pecoraro.
3341 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
3342 (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
3343 line and store it with the leak stack.
3344 (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
3346 (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
3347 property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
3348 .numberOfCalls now holds the number of leaked allocations.
3350 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
3351 (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
3353 (monkeyPatchInspectorObjects): Format the values as bytes.
3355 2011-03-17 Adam Roben <aroben@apple.com>
3357 Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
3359 Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
3362 Reviewed by James Robinson.
3364 * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3365 (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
3366 is always populated, even when all regression tests pass.
3368 2011-03-10 Hayato Ito <hayato@chromium.org>
3370 Reviewed by Tony Chang.
3372 Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
3374 https://bugs.webkit.org/show_bug.cgi?id=56076
3376 * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3378 2011-03-17 Adam Roben <aroben@apple.com>
3380 Skip a compositing-sensitive test when accelerated compositing is disabled
3382 Reviewed by Sam Weinig.
3384 * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
3385 accelerated compositing is disabled.
3387 2011-03-17 Adam Roben <aroben@apple.com>
3389 Start using PlatformSpecificScheduler for the Mac builders
3391 The current set of file/directory patterns should work for Mac builders. We may discover
3392 that there are more files and directories we can exclude from the Mac builds, but they can
3395 Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
3397 Reviewed by Mark Rowe.
3399 * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
3400 PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
3402 * Scripts/webkitpy/common/config/build.py:
3403 (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
3404 cleaned up patterns a little bit.
3406 * Scripts/webkitpy/common/config/build_unittest.py:
3407 (ShouldBuildTest): Fixed some expected results.
3408 (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
3411 2011-03-17 Jeff Miller <jeffm@apple.com>
3413 Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
3421 * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
3422 * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
3423 * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
3424 * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3425 * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
3427 2011-03-17 Adam Roben <aroben@apple.com>
3429 Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
3431 Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
3434 Reviewed by Anders Carlsson.
3436 * Scripts/old-run-webkit-tests:
3437 (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
3438 directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
3439 we're running in WebKit2 mode.
3441 2011-03-17 Mikhail Naganov <mnaganov@chromium.org>
3443 Reviewed by Yury Semikhatsky.
3445 Web Inspector: Clean up Inspector strings.
3446 https://bugs.webkit.org/show_bug.cgi?id=56557
3448 Modify the script to deal correctly with "\xNN" escapes, and to
3449 check strings in Chromium's DevTools.js.
3451 * Scripts/check-inspector-strings:
3453 2011-03-17 Keith Kyzivat <keith.kyzivat@nokia.com>
3455 Reviewed by Benjamin Poulain.
3457 Update autoinstall to install mechanize 0.2.4
3458 https://bugs.webkit.org/show_bug.cgi?id=56499
3460 Newer versions of mechanize support HTTPS proxies, which is necessary
3461 for people using webkit-patch behind firewalls.
3463 * Scripts/webkitpy/common/system/autoinstall.py:
3464 * Scripts/webkitpy/thirdparty/__init__.py:
3466 2011-03-16 Sam Weinig <sam@webkit.org>
3468 Reviewed by Adam Roben.
3470 REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
3471 https://bugs.webkit.org/show_bug.cgi?id=56541
3473 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3474 (WTR::InjectedBundlePage::willSendRequestForFrame):
3475 Check for an empty host in addition to a null host. This bug was introduced
3476 when porting off of the KURL code and onto the WKURLRef version.
3478 2011-03-16 Sam Weinig <sam@webkit.org>
3480 Reviewed by Adam Roben.
3482 Add Lucas Forschler to the list of WebKit committers.
3484 * Scripts/webkitpy/common/config/committers.py:
3486 2011-03-16 Sam Weinig <sam@webkit.org>
3488 Reviewed upon and dictated through Adam Roben.
3490 Escape crashing function names in results.html. This fixes an issue
3491 when a crash involves a type with templates.
3493 * Scripts/old-run-webkit-tests:
3495 2011-03-16 Daniel Sievers <sievers@google.com>
3497 Reviewed by James Robinson.
3499 Add setting to always force compositing mode
3500 https://bugs.webkit.org/show_bug.cgi?id=56156
3502 * DumpRenderTree/chromium/DumpRenderTree.cpp:
3504 * DumpRenderTree/chromium/TestShell.cpp:
3505 (TestShell::TestShell):
3506 (TestShell::resetWebSettings):
3507 * DumpRenderTree/chromium/TestShell.h:
3508 (TestShell::setForceCompositingMode):
3509 * DumpRenderTree/chromium/WebPreferences.cpp:
3510 (WebPreferences::reset):
3511 (WebPreferences::applyTo):
3512 * DumpRenderTree/chromium/WebPreferences.h:
3514 2011-03-15 Hayato Ito <hayato@chromium.org>
3516 Reviewed by Ojan Vafai.
3518 Ignore files that will be used by reftests in old-run-webkit-tests.
3520 https://bugs.webkit.org/show_bug.cgi?id=55936
3522 * Scripts/old-run-webkit-tests:
3524 2011-03-15 Felipe Oliveira da Silva Netto <f.dachshund@gmail.com>
3526 Reviewed by Adam Roben.
3528 Function relativeScriptsDir doesn't return the correct relative
3531 * Scripts/webkitdirs.pm:
3532 (relativeScriptsDir): Ensure we use the directory that contains
3533 webkitdirs.pm, not the one that contains the original script that
3536 2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
3538 [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
3539 fix to link against the Security framework after recent WebKitSystemInterface changes.
3541 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3542 (LayoutTestController::originsWithLocalStorage):
3543 * wx/build/settings.py:
3544 * wx/build/waf_extensions.py:
3546 2011-03-15 Sam Weinig <sam@webkit.org>
3548 Reviewed by Darin Adler.
3550 Add script to convert a patch to a prettypatch and show in the default browser
3551 https://bugs.webkit.org/show_bug.cgi?id=56416
3553 This can be used either like
3554 $ svn-create-patch | show-pretty-diff
3556 $ show-pretty-diff patch.diff
3558 * Scripts/show-pretty-diff: Added.
3560 2011-03-15 Brian Weinstein <bweinstein@apple.com>
3562 Rubber-stamped by Adam Roben.
3564 Adding myself as a reviewer.
3566 * Scripts/webkitpy/common/config/committers.py:
3568 2011-03-15 Anders Carlsson <andersca@apple.com>
3570 Try to fix the Windows build.
3572 * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
3573 (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
3575 2011-03-15 Anders Carlsson <andersca@apple.com>
3577 Reviewed by Sam Weinig.
3579 Make sure that NP_Shutdown is always the last NPP function called
3580 https://bugs.webkit.org/show_bug.cgi?id=56391
3582 Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
3584 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3585 * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3586 (PluginTest::PluginTest):
3587 (PluginTest::NP_Shutdown):
3588 (PluginTest::registerNPShutdownFunction):
3589 * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3590 * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
3591 (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
3592 (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
3593 (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
3594 (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
3595 (NPDeallocateCalledBeforeNPShutdown::NPP_New):
3596 (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
3597 (NPDeallocateCalledBeforeNPShutdown::shutdown):
3598 * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3600 * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3601 * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3604 2011-03-15 Ilya Sherman <isherman@chromium.org>
3606 Reviewed by Tony Chang.
3608 Autofilled form elements are assigned fixed background color but not text color
3609 https://bugs.webkit.org/show_bug.cgi?id=48382
3611 * DumpRenderTree/LayoutTestController.cpp:
3612 (setAutofilledCallback): Added.
3613 (LayoutTestController::staticFunctions):
3614 * DumpRenderTree/LayoutTestController.h:
3615 * DumpRenderTree/chromium/LayoutTestController.cpp:
3616 (LayoutTestController::LayoutTestController):
3617 (LayoutTestController::setAutofilled): Added.
3618 * DumpRenderTree/chromium/LayoutTestController.h:
3619 * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3620 (LayoutTestController::setAutofilled): Added.
3621 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3622 (LayoutTestController::setAutofilled): Added.
3623 (LayoutTestController::setValueForUser): Style tweak.
3624 * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3625 (LayoutTestController::setAutofilled): Added (stub).
3626 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3627 (LayoutTestController::setAutofilled): Added (stub).
3629 2011-03-15 Dan Bernstein <mitz@apple.com>
3631 Build fix after r81135.
3633 * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3635 2011-03-15 Dan Bernstein <mitz@apple.com>
3637 Build fix after r81135.
3639 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3640 * WebKitTestRunner/mac/TestControllerMac.mm:
3641 * WebKitTestRunner/mac/TestInvocationMac.mm:
3642 * WebKitTestRunner/mac/main.mm:
3644 2011-03-15 Balazs Kelemen <kbalazs@webkit.org>
3646 Reviewed by Adam Barth.
3648 REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
3649 https://bugs.webkit.org/show_bug.cgi?id=56349
3651 * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
3652 on platforms where we use it. Copied from DumpRenderTree.pro.
3654 2011-03-15 Dan Bernstein <mitz@apple.com>
3656 Build fix after r81135.
3658 * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3659 * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
3661 2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
3663 Reviewed by Darin Adler.
3665 Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
3666 info into the headers rather than in export symbol definition files, but disable it on
3667 all platforms initially so we can deal with port build issues one port at a time.
3669 https://bugs.webkit.org/show_bug.cgi?id=27551
3671 * DumpRenderTree/cg/ImageDiffCG.cpp:
3672 * DumpRenderTree/chromium/config.h:
3673 * DumpRenderTree/config.h:
3674 * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3675 * TestWebKitAPI/TestWe