[Qt][WK2] Implement PageClient::isViewWindowActive()
[WebKit-https.git] / Tools / ChangeLog
1 2012-03-24  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2
3         [Qt][WK2] Implement PageClient::isViewWindowActive()
4         https://bugs.webkit.org/show_bug.cgi?id=81143
5
6         Reviewed by Kenneth Rohde Christiansen.
7
8         Fix the WrapperWindow from our PlatformWebView
9         so it correctly creates the platform related
10         stuff for QWindow, which is not created unless
11         QWindow::setVisible() or QWindow::show() are called.
12
13         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
14         (WTR::PlatformWebView::PlatformWebView):
15
16 2012-03-23  Dirk Pranke  <dpranke@chromium.org>
17
18         nrwt: don't wait for safari to exit before exiting after showing the results file
19         https://bugs.webkit.org/show_bug.cgi?id=81845
20
21         Reviewed by Ryosuke Niwa.
22
23         Prior to this change, if you ran new-run-webkit-tests and
24         displayed the HTML results file at the end, we would block
25         waiting for the user to quit the browser. There doesn't seem to
26         be a need for that, and the Chromium ports don't do this.
27
28         Also, update the mac tests to capture the output and be quiet :).
29
30         * Scripts/webkitpy/common/system/executive_mock.py:
31           Make popen() testable, implement should_log for it.
32         * Scripts/webkitpy/layout_tests/port/mac.py:
33         (MacPort.show_results_html_file):
34         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
35           Silence some of the tests via outputcapture.
36
37 2012-03-23  Gustavo Noronha Silva  <gns@gnome.org>
38
39         [GTK] libgcrypt and p11-kit should not be in jhbuild modules
40         https://bugs.webkit.org/show_bug.cgi?id=82073
41
42         Reviewed by Martin Robinson.
43
44         * Scripts/webkitdirs.pm:
45         (jhbuildConfigurationChanged): new function that isolates the
46         jhbuild configuration change checking from the autogen logic.
47         (mustReRunAutogen): code for the new function lived here.
48         (buildAutotoolsProject): now calls jhbuildConfigurationChanged
49         itself, and cleans up the jhbuild root if configuration has
50         changed; it also forces autogen to be run in that case, to
51         make sure the new libraries are used.
52         * gtk/jhbuild.modules: removed libgcrypt and p11-kit.
53         * jhbuild/jhbuild-wrapper:
54         (ensure_jhbuild): this might be run inside a jhbuild environment,
55         in which case aclocal fails when trying to use the now deleted
56         aclocal directory in the jhbuild prefix, so work around that.
57
58 2012-03-23  Ojan Vafai  <ojan@chromium.org>
59
60         garden-o-matic scrolls to the top of the page when you click an accordion item
61         https://bugs.webkit.org/show_bug.cgi?id=82088
62
63         Reviewed by Adam Barth.
64
65         Check the scroll position and make sure that the clicked accordion item is visible.
66
67         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
68
69 2012-03-23  Dirk Pranke  <dpranke@chromium.org>
70
71         LayoutTestHelper could get torn down earlier (mostly to reset color profile)
72         https://bugs.webkit.org/show_bug.cgi?id=80567
73
74         Reviewed by Ryosuke Niwa.
75
76         Move clean_up_run to occur right after we finish testing and
77         before we start processing the results. Also makes set_up_run()
78         and clean_up_run() private since there's no real need for
79         callers to be aware of them.
80
81         * Scripts/webkitpy/layout_tests/controllers/manager.py:
82         (Manager._set_up_run):
83         (Manager.run):
84         (Manager._clean_up_run):
85         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
86         (ManagerTest.test_http_locking):
87         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
88         (run):
89
90 2012-03-23  Dean Jackson  <dino@apple.com>
91
92         Disable CSS_SHADERS in Apple builds
93         https://bugs.webkit.org/show_bug.cgi?id=81996
94
95         Reviewed by Simon Fraser.
96
97         Default enableCSSShaders to be 0 on all builds that use
98         this script. Use the flag to turn it back on.
99
100         * Scripts/build-webkit:
101
102 2012-03-23  Tony Chang  <tony@chromium.org>
103
104         [chromium] rename newwtf target back to wtf
105         https://bugs.webkit.org/show_bug.cgi?id=82064
106
107         Reviewed by Adam Barth.
108
109         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
110
111 2012-03-23  Jessie Berlin  <jberlin@apple.com>
112
113         Assertion failure in PlatformPasteboardMac constructor causing multiple tests to "crash" on
114         the Lion Intel WebKit2 Debug bots.
115         https://bugs.webkit.org/show_bug.cgi?id=81012.
116
117         Rubber-stamped by Dan Bernstein.
118
119         Add a step to kill the pasteboard server while we investigate what is causing these
120         assertion failures (to get the bots green).
121
122         * BuildSlaveSupport/kill-old-processes:
123
124 2012-03-22  Martin Robinson  <mrobinson@igalia.com>
125
126         [check-webkit-style] Alphabetical sorting errors in headers are reported for the line after the first out of order header
127         https://bugs.webkit.org/show_bug.cgi?id=81986
128
129         Reviewed by David Levin.
130
131         Track whether or not errors are filtered in error handlers. If an
132         alphabetical sorting error is reported for a header and filtered, try
133         reporting it for the other potential source of the error. This ensures
134         that the style bot can still find new sorting errors in both potential
135         situations:
136
137             #include <foo.h> <-- 1. edited line
138             #include <baz.h> <-- 2. edited line
139
140         * Scripts/webkitpy/style/checkers/cpp.py:
141         (check_include_line): Potentially report the error for both lines,
142         if the first error is filtered.
143         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Implement a new style of
144         test that allows only reporting errors for certain lines. This verifies that
145         when one line of an ordering error is filtered, the error is reported on the
146         other line.
147         (ErrorCollector.__init__):
148         (ErrorCollector.__call__):
149         (CppStyleTestBase.perform_lint):
150         (CppStyleTestBase.perform_language_rules_check):
151         (CppStyleTestBase.assert_language_rules_check):
152         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines):
153         Added a new test that verifies that when one line of the two lines of an ordering
154         error occur, the error is reported on the other line.
155         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
156         (MockErrorHandler.__call__): Report True because the error is handled.
157         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
158         (ErrorCollector.__call__): Ditto.
159         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
160         (MockErrorHandler.__call__): Ditto.
161         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
162         (TestErrorHandler.__call__): Ditto.
163         * Scripts/webkitpy/style/checkers/xml_unittest.py:
164         (MockErrorHandler.__call__): Ditto.
165         * Scripts/webkitpy/style/error_handlers.py:
166         (DefaultStyleErrorHandler.__call__): Report True if the error is handled
167         and False if it is filtered.
168
169 2012-03-23  Patrick Gansterer  <paroga@webkit.org>
170
171         Build fix for WinCE after r111778.
172
173         * WinCELauncher/CMakeLists.txt:
174
175 2012-03-23  Peter Beverloo  <peter@chromium.org>
176
177         Unreviewed buildfix for the Chromium Android builder.
178
179         Disable the ImageDiff target for now. Android needs to build this for
180         host rather than for target (as other configurations do), but since the
181         WTF move the dependency chain got significantly more complicated.
182
183         I'll work out a proper fix in the following bug, but since several
184         things are broken due to this, this buildfix should be landed first.
185         https://bugs.webkit.org/show_bug.cgi?id=82039
186
187         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
188
189 2012-03-23  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
190
191         [EFL][DRT] Implement LayoutTestController's methods related with editing.
192         https://bugs.webkit.org/show_bug.cgi?id=80136
193
194         Reviewed by Ryosuke Niwa.
195
196         Implements EFL's LayoutTestController methods e.i. setSmartInsertDeleteEnabled,
197         setSelectTrailingWhitespaceEnabled.
198
199         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
200         (LayoutTestController::setSmartInsertDeleteEnabled):
201         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
202
203 2012-03-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
204
205         Convert hasGrammarMarker to use Internals interface
206         https://bugs.webkit.org/show_bug.cgi?id=82004
207
208         Reviewed by Ryosuke Niwa.
209
210         Remove hasGrammarMarker functions, because it is able to work in the
211         cross-port way through the Internals interface.
212
213         * DumpRenderTree/LayoutTestController.cpp:
214         (LayoutTestController::staticFunctions):
215         * DumpRenderTree/LayoutTestController.h:
216         (LayoutTestController):
217         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
218         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
219         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
220         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
221         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
222         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
223
224 2012-03-22  Adam Barth  <abarth@webkit.org>
225
226         sync-master-with-upstream creates non-linear git history
227         https://bugs.webkit.org/show_bug.cgi?id=82006
228
229         Reviewed by Julien Chaffraix.
230
231         Previously this script would create a merge commit at the HEAD of
232         origin/master, causing your fork of WebKit to diverge from upstream.
233         The new version of this script pushes directly from upstream to origin
234         (without round-tripping through any local branches), avoiding this
235         problem.
236
237         * Scripts/sync-master-with-upstream:
238
239 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
240
241         Unreviewed build fix. Add knowledge of the WTF project to
242         the autotools build system scripts so that build-jsc works
243         correctly for GTK+.
244
245         * Scripts/webkitdirs.pm:
246         (buildAutotoolsProject): handle the WTF project, build the
247         libWTF.la target.
248         (buildGtkProject): add WTF to the list of supported projects.
249
250 2012-03-22  Eric Seidel  <eric@webkit.org>
251
252         Make svn-apply re-write JavaScriptCore/wtf to WTF/wtf
253         https://bugs.webkit.org/show_bug.cgi?id=81984
254
255         Reviewed by Adam Barth.
256
257         * Scripts/VCSUtils.pm:
258         (adjustPathForRecentRenamings):
259
260 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
261
262         [CMake] Fix build-jsc after r111778 and r111797.
263         https://bugs.webkit.org/show_bug.cgi?id=82001
264
265         Reviewed by Filip Pizlo.
266
267         Contrary to the comment in build-jsc, buildCMakeProjectOrExit()
268         does return if no error occurred, and build-jsc failed with
269         "building not defined for this platform".
270
271         * Scripts/build-jsc: Always exit after caling
272         buildCMakeProjectOrExit().
273         * Scripts/webkitdirs.pm:
274         (buildCMakeProjectOrExit): Return 0 if no error occurred.
275
276 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
277
278         [CMake] Unreviewed build fix after r111778.
279
280         * DumpRenderTree/efl/CMakeLists.txt: Replace
281         ${JAVASCRIPTCORE_DIR}/wtf with ${WTF_DIR}/wtf in the include
282         paths.
283         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Use the right
284         wtf include.
285         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Ditto.
286         * WinCELauncher/CMakeLists.txt: Replace ${JAVASCRIPTCORE_DIR}/wtf
287         with ${WTF_DIR}/wtf in the include paths.
288
289 2012-03-22  Filip Pizlo  <fpizlo@apple.com>
290
291         Tools/Scripts/build-jsc doesn't work after WTF move
292         https://bugs.webkit.org/show_bug.cgi?id=81999
293
294         Reviewed by Eric Seidel.
295         
296         For ports that require WTF and JSC to be built as two projects and where
297         the machinery to build both does not already exist, teach the tool to do
298         so for us.
299
300         * Scripts/build-jsc:
301         (buildMyProject):
302
303 2012-03-22  Ojan Vafai  <ojan@chromium.org>
304
305         Fix accidental missing line in r111793.
306
307         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
308         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
309         Remove base.values. It was unused and duplicates the builtin Object.values.
310         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
311         Accidentally deleted this line before committing r111793.
312
313 2012-03-22  Ojan Vafai  <ojan@chromium.org>
314
315         Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page
316         https://bugs.webkit.org/show_bug.cgi?id=81983
317
318         Reviewed by Adam Barth.
319
320         The dialogs get in the way if you are doing multiple rebaselines. Also,
321         a number of people didn't realize that you could do multiple rebaselines
322         in parallel. A non-modal dialog is just confusing.
323
324         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
325         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
326         If we're only rebaselining 1 test, show the test name in the initial message. Otherwise,
327         show the number of tests being rebaselined.
328
329         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
330         Turn MessageBox into StatusArea. StatusArea is a singleton and messages in the StatusArea are grouped
331         by ID. That way, the results of each UI action (e.g. clicking rebaseline) are grouped together
332         into a single area.
333
334         Once addFinalMessage has been called for all IDs, we show the close button. Clicking close
335         also serves to clear all teh content in the StatusArea. 
336
337         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
338         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
339
340 2012-03-22  Tony Chang  <tony@chromium.org>
341
342         Unreviewed, fix chromium build after wtf move.
343
344         Only use newwtf, remove references to wtf.
345
346         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
347
348 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
349
350         Actually move WTF files to their new home
351         https://bugs.webkit.org/show_bug.cgi?id=81844
352
353         [Qt] Unreviewed buildfix after r111778.
354
355         * DumpRenderTree/qt/DumpRenderTree.pro:
356
357 2012-03-22  Dan Bernstein  <mitz@apple.com>
358
359         Font fallback in WebKitTestRunner depends on user settings
360         https://bugs.webkit.org/show_bug.cgi?id=81978
361
362         Reviewed by Jessie Berlin.
363
364         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
365         (WTR::InjectedBundle::platformInitialize): Added an AppleLanguages key
366         with a value consisting of the array ("en") to the override defaults
367         dictionary. This is the same value used in DumpRenderTree, and it
368         ensures that font fallback follows a consistent path that is not
369         affected by the language preferences of the user running the test.
370
371 2012-03-22  Andy Estes  <aestes@apple.com>
372
373         check-for-inappropriate-objc-class-names should ignore the class defined by libarclite.
374         https://bugs.webkit.org/show_bug.cgi?id=81971
375
376         Reviewed by Dan Bernstein.
377
378         Xcode will automatically link ObjC binaries against libarclite in some
379         cases, which defines a class called __ARCLite__.
380         check-for-inappropriate-objc-class-names shouldn't complain about this
381         class name.
382
383         * Scripts/check-for-inappropriate-objc-class-names:
384
385 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
386
387         new-run-webkit-tests blames the wrong test for crashing
388         https://bugs.webkit.org/show_bug.cgi?id=81951
389
390         Reviewed by Adam Barth.
391
392         NRWT wasn't extracting the WebProcess pid correct; should've
393         used re.search instead of re.match :(. Add more tests!
394
395         * Scripts/webkitpy/layout_tests/port/mac.py:
396         (MacPort._get_crash_log):
397         * Scripts/webkitpy/layout_tests/port/webkit.py:
398         (WebKitDriver.has_crashed):
399         (WebKitDriver._check_for_driver_crash):
400         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
401         (WebKitDriverTest.test_no_timeout):
402         (WebKitDriverTest):
403         (WebKitDriverTest.test_check_for_driver_crash):
404         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess):
405         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
406         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
407         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.name):
408         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
409         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
410
411 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
412
413         [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
414         https://bugs.webkit.org/show_bug.cgi?id=81512
415
416         Adding missing implementation markerTextForListItem to EFL's
417         LayoutTestController so that we can unskip related tests from
418         the skip list.
419
420         Reviewed by Antonio Gomes.
421
422         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
423         (LayoutTestController::markerTextForListItem): Implemented.
424
425 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
426
427         [EFL] Enable view mode media feature layout tests
428         https://bugs.webkit.org/show_bug.cgi?id=81205
429
430         Adding missing implementation setViewModeMediaFeature to EFL's 
431         LayoutTestController so that we can unskip view mode 
432         media feature layout tests.
433
434         Reviewed by Antonio Gomes.
435
436         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
437         (LayoutTestController::setViewModeMediaFeature): Implemented.
438
439 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
440
441         nrwt: crash while stopping layout test helper on apple mac lion
442         https://bugs.webkit.org/show_bug.cgi?id=81949
443
444         Reviewed by Eric Seidel.
445
446         stop_helper() didn't work right if the helper process wasn't
447         still running or didn't respond properly to being shut down. Fix
448         this and add some tests. Also add code to MockExecutive() to be
449         able to mock executive.popen() properly.
450
451         * Scripts/webkitpy/common/system/executive_mock.py:
452         (MockProcess.__init__):
453         (MockProcess.wait):
454         (MockExecutive.__init__):
455         (MockExecutive.popen):
456         * Scripts/webkitpy/common/system/systemhost_mock.py:
457         (MockSystemHost.__init__):
458         * Scripts/webkitpy/layout_tests/port/mac.py:
459         (MacPort.start_helper):
460         (MacPort.stop_helper):
461         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
462         (test_get_crash_log):
463         (test_helper_starts):
464         (test_helper_fails_to_start):
465         (test_helper_fails_to_stop):
466         (test_helper_fails_to_stop.bad_waiter):
467
468 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
469
470         [GTK] Add make to the jhbuild moduleset
471         https://bugs.webkit.org/show_bug.cgi?id=81769
472
473         Reviewed by Martin Robinson.
474
475         Mostly based on a patch by Carlos Garcia Campos <cgarcia@igalia.com>.
476         Add GNU make with custom patches to fix several issues:
477
478         - make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to
479           fix the argument list limit of GNU make when running make
480           distcheck.
481         - make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski
482           and Jeremy Devenport to fix parallel build issues present in
483           GNU make 3.82
484
485         * gtk/jhbuild.modules: Added make with patches.
486         * gtk/patches/make-3.82-arg-list-length.patch: Added.
487         * gtk/patches/make-3.82-parallel-build.patch: Added.
488
489 2012-03-22  Kevin Ollivier  <kevino@theolliviers.com>
490
491         [wx] Unreviewed. Adding Source/WTF to the build and updating
492         waf port list.
493
494         * DumpRenderTree/wscript:
495         * waf/build/settings.py:
496
497 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
498
499         Re-land fix for r81603 yet again (!) with latest build fix.
500         https://bugs.webkit.org/show_bug.cgi?id=81603
501
502         Unreviewed, build fix.
503
504         The latest problem was a bad sprintf() in
505         BasePort._get_crash_log(). I've reworked that routine and added
506         unit tests for coverage.
507
508         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
509         (SingleTestRunner._handle_error):
510         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
511         (write_test_result):
512         (TestResultWriter.write_crash_log):
513         * Scripts/webkitpy/layout_tests/port/base.py:
514         (Port.diff_text):
515         (Port._get_crash_log):
516         * Scripts/webkitpy/layout_tests/port/chromium.py:
517         (ChromiumDriver.run_test):
518         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
519         (ChromiumDriverTest.test_crash_log):
520         * Scripts/webkitpy/layout_tests/port/driver.py:
521         (DriverOutput.__init__):
522         * Scripts/webkitpy/layout_tests/port/mac.py:
523         (MacPort.is_lion):
524         (MacPort._get_crash_log):
525         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
526         (test_default_child_processes):
527         (test_get_crash_log):
528         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
529         (MockDRTPortTest.test_get_crash_log):
530         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
531         (PortTestCase.test_get_crash_log):
532         * Scripts/webkitpy/layout_tests/port/test.py:
533         (TestDriver.run_test):
534         * Scripts/webkitpy/layout_tests/port/webkit.py:
535         (WebKitDriver.__init__):
536         (WebKitDriver._start):
537         (WebKitDriver.has_crashed):
538         (WebKitDriver._check_for_driver_crash):
539         (WebKitDriver.run_test):
540
541 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
542
543         [Qt] Enable support for handling database quota's in the MiniBrowser
544         https://bugs.webkit.org/show_bug.cgi?id=81928
545
546         Reviewed by Simon Hausmann.
547
548         * MiniBrowser/qt/qml/BrowserWindow.qml:
549
550 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
551
552         [EFL] Implement LayoutTestController::setEditingBehavior
553         https://bugs.webkit.org/show_bug.cgi?id=81124
554
555         Adding missing implementation setEditingBehavior to EFL's
556         LayoutTestController. This implementation allows us to
557         unskip some tests from the skip list.
558
559         Reviewed by Martin Robinson.
560
561         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
562         (LayoutTestController::setEditingBehavior): Implemented.
563
564 2012-03-22  Carlos Garcia Campos  <cgarcia@bb-webkit-rel-64.local.igalia.com>
565
566         [GTK] Use the angle-bracket form to include wtf headers
567         https://bugs.webkit.org/show_bug.cgi?id=81884
568
569         Reviewed by Eric Seidel.
570
571         Use #include <wtf/foo> instead of #include "foo".
572
573         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
574         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
575         * DumpRenderTree/gtk/DumpRenderTree.cpp:
576         * DumpRenderTree/gtk/EditingCallbacks.cpp:
577         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
578         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
579
580 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
581
582         Unreviewed, add Michael Brüning and Allan Jensen to committers.py.
583
584         * Scripts/webkitpy/common/config/committers.py:
585
586 2012-03-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
587
588         [Qt] Enable FAST_MOBILE_SCROLLING when scrolling is delegated.
589         https://bugs.webkit.org/show_bug.cgi?id=81889
590
591         Reviewed by Kenneth Rohde Christiansen.
592
593         Enable FAST_MOBILE_SCROLLING feature.
594
595         * qmake/mkspecs/features/features.prf:
596
597 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
598
599         [EFL] DRT: Do not pass a relative path to DOWNLOADED_FONTS_DIR.
600         https://bugs.webkit.org/show_bug.cgi?id=81900
601
602         Reviewed by Gustavo Noronha Silva.
603
604         r111598 added the DOWNLOADED_FONTS_DIR define, but it used a relative
605         path which assumed a certain directory structure for the build
606         directory which may noy be true.
607
608         Instead, hardcode the path to the downloaded fonts starting from the
609         top-level source directory. While this solution is also far from
610         perfect, it makes it more consistent and reliable, and easier to
611         tackle at once with the rest of bug 81475.
612
613         * DumpRenderTree/efl/CMakeLists.txt:
614
615 2012-03-22  Carlos Garcia Campos  <cgarcia@igalia.com>
616
617         [GTK] Allow to run any jhbuild command with jhbuild-wrapper script
618         https://bugs.webkit.org/show_bug.cgi?id=81888
619
620         Reviewed by Philippe Normand.
621
622         * Scripts/update-webkit-libs-jhbuild:
623         (runJhbuild): Helper function to run jhbuild with a given command.
624         Instead of running jhbuild directly, use the jhbuild-wrapper, so
625         that we don't need to run it first to check whether jhbuild is
626         installed or not.
627         * efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
628         * gtk/run-with-jhbuild: Ditto.
629         * jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,
630         not only run.
631
632 2012-03-22  Philippe Normand  <pnormand@igalia.com>
633
634         Unreviewed, test-webkitpy fix after r111661.
635
636         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
637         (MainTest.test_crash_log):
638         (MainTest.test_web_process_crash_log):
639
640 2012-03-22  Philippe Normand  <pnormand@igalia.com>
641
642         Unreviewed, test-webkitpy fix after r111642.
643
644         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
645         (ChromiumDriverTest.setUp):
646         (ChromiumDriverTest.test_two_drivers):
647
648 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
649
650         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
651         https://bugs.webkit.org/show_bug.cgi?id=81603
652
653         Unreviewed rolling out r111609 and part of r111615,
654         because it broke NRWT on Qt-WK2 platform.
655
656         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
657         (SingleTestRunner._handle_error):
658         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
659         (write_test_result):
660         (TestResultWriter.write_crash_report):
661         * Scripts/webkitpy/layout_tests/port/base.py:
662         (Port.is_crash_reporter):
663         (Port._driver_class):
664         * Scripts/webkitpy/layout_tests/port/chromium.py:
665         (ChromiumDriver.run_test):
666         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
667         (ChromiumDriverTest.test_crashed_process_name):
668         * Scripts/webkitpy/layout_tests/port/driver.py:
669         (DriverOutput.__init__):
670         * Scripts/webkitpy/layout_tests/port/mac.py:
671         (MacPort):
672         (MacPort.is_crash_reporter):
673         (MacPort.release_http_lock):
674         * Scripts/webkitpy/layout_tests/port/test.py:
675         (TestDriver.run_test):
676         * Scripts/webkitpy/layout_tests/port/webkit.py:
677         (WebKitDriver.__init__):
678         (WebKitDriver._start):
679         (WebKitDriver.has_crashed):
680         (WebKitDriver._check_for_driver_crash):
681         (WebKitDriver.run_test):
682
683 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
684
685         [Qt] Add full platforms to Qt buildslaves
686         https://bugs.webkit.org/show_bug.cgi?id=81877
687
688         Reviewed by Ryosuke Niwa.
689
690         * BuildSlaveSupport/build.webkit.org-config/config.json:
691
692 2012-03-21  Johnny Ding  <jnd@chromium.org>
693
694         Customize layout test timeout value for different ports.
695         https://bugs.webkit.org/show_bug.cgi?id=79859
696
697         Reviewed by Ojan Vafai.
698
699         * Scripts/webkitpy/layout_tests/controllers/manager.py:
700         (Manager):
701         * Scripts/webkitpy/layout_tests/port/base.py:
702         (Port.default_test_timeout_ms):
703         * Scripts/webkitpy/layout_tests/port/chromium.py:
704         (ChromiumDriver.stop):
705         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
706         (ChromiumAndroidPort.default_test_timeout_ms):
707         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
708         (_set_up_derived_options):
709
710 2012-03-21  Mark Rowe  <mrowe@apple.com>
711
712         Fix the build.
713
714         Ensure that our test tools don't try and use RTTI unnecessarily.
715
716         * DumpRenderTree/mac/Configurations/Base.xcconfig:
717         * TestWebKitAPI/Configurations/Base.xcconfig:
718         * WebKitTestRunner/Configurations/Base.xcconfig:
719
720 2012-03-21  Adam Barth  <abarth@webkit.org>
721
722         WebKit should have some scripts to smooth interactions with GitHub
723         https://bugs.webkit.org/show_bug.cgi?id=81842
724
725         Reviewed by Eric Seidel.
726
727         These scripts support the workflow in
728         https://trac.webkit.org/wiki/UsingGitHub by automating the
729         configuration and syncing operations needed for a GitHub fork of WebKit
730         to track the main WebKit repository.
731
732         * Scripts/configure-github-as-upstream: Added.
733         * Scripts/sync-master-with-upstream: Added.
734
735 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
736
737         WTR - log the pid of a crashing WebProcess
738         https://bugs.webkit.org/show_bug.cgi?id=81575
739
740         Reviewed by Alexey Proskuryakov.
741
742         This allows run-webkit-tests to find the right crash log for a
743         given crashed WebProcess in WebKit2.
744
745         * WebKitTestRunner/TestController.cpp:
746         (WTR::exceededDatabaseQuota):
747         (WTR::TestController::createOtherPage):
748         (WTR::TestController::initialize):
749         (WTR::TestController::resetStateToConsistentValues):
750         (WTR::TestController::runTest):
751         (WTR::TestController::processDidCrash):
752
753 2012-03-21  Enrica Casucci  <enrica@apple.com>
754
755         WebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
756         https://bugs.webkit.org/show_bug.cgi?id=81835
757         <rdar://problem/11082749>
758
759         Reviewed by Brady Eidson.
760
761         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
762         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
763         (TestWebKitAPI::contextMenuCopyLink):
764
765 2012-03-21  Alexandru Chiculita  <achicu@adobe.com>
766
767         [CSS Shaders] Make CSS Shaders compile on Chromium
768         https://bugs.webkit.org/show_bug.cgi?id=81435
769
770         Reviewed by Stephen White.
771         
772         I've added WebKitCSSCustomFilterEnabled support for the layoutTestController.overridePreference function.
773
774         * DumpRenderTree/chromium/LayoutTestController.cpp:
775         (LayoutTestController::overridePreference):
776         * DumpRenderTree/chromium/WebPreferences.cpp:
777         (WebPreferences::reset):
778         (WebPreferences::applyTo):
779         * DumpRenderTree/chromium/WebPreferences.h:
780         (WebPreferences):
781
782 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
783
784         fix regression on gtk port introduced by r111609
785         https://bugs.webkit.org/show_bug.cgi?id=81839
786
787         Reviewed by Philippe Normand.
788
789         r111609 should've initialized a couple of missing fields in
790         WebKitDriver, and also should've checked for method overrides
791         in the other ports :(.
792
793         * Scripts/webkitpy/layout_tests/port/gtk.py:
794         (GtkDriver._start):
795         * Scripts/webkitpy/layout_tests/port/webkit.py:
796         (WebKitDriver.__init__):
797         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
798         (MainTest.test_crash_log):
799         (MainTest.test_web_process_crash_log):
800
801 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
802
803         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
804         https://bugs.webkit.org/show_bug.cgi?id=81603
805
806         Reviewed by Adam Barth.
807
808         Add a new _get_crash_log() overridable method on the Port
809         object to customize how we fetch crash logs per port.
810         Mac will now slow-spin with a timeout waiting for the crash log, rather
811         than waiting for the ReportCrash process to exit (it appears
812         that the mac will manage multiple crashes with a single
813         ReportCrash process, the process waits around longer than
814         necessary, presumably to avoid thrashing if processes are
815         repeatedly crashing).
816
817         Also, add the DriverOutput should contain the crash log and other info,
818         which is created in a port-specific manner but can then be
819         treated generically. Previously single_test_runner would get
820         told that something crashed and attempt to do something to get
821         the crash log, but it didn't have the information it needed to
822         od the right thing; better to make the driver hand back the
823         right info.
824
825         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
826         (SingleTestRunner._handle_error):
827         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
828         (write_test_result):
829         (TestResultWriter.write_crash_log):
830         * Scripts/webkitpy/layout_tests/port/base.py:
831         (Port.diff_text):
832         (Port._get_crash_log):
833         * Scripts/webkitpy/layout_tests/port/chromium.py:
834         (ChromiumDriver.run_test):
835         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
836         (ChromiumDriverTest.test_crash_log):
837         * Scripts/webkitpy/layout_tests/port/driver.py:
838         (DriverOutput.__init__):
839         * Scripts/webkitpy/layout_tests/port/mac.py:
840         (MacPort.is_lion):
841         (MacPort._get_crash_log):
842         * Scripts/webkitpy/layout_tests/port/test.py:
843         (TestDriver.run_test):
844         * Scripts/webkitpy/layout_tests/port/webkit.py:
845         (WebKitDriver.__init__):
846         (WebKitDriver._start):
847         (WebKitDriver.has_crashed):
848         (WebKitDriver._check_for_driver_crash):
849         (WebKitDriver.run_test):
850
851 2012-03-21  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
852
853         [EFL] Use jhbuild downloaded fonts instead of hardcoded system font paths
854         https://bugs.webkit.org/show_bug.cgi?id=81507
855
856         Now that we're only loading from one directory, no need to
857         iterate over a list of directories anymore.
858
859         Reviewed by Martin Robinson.
860
861         * DumpRenderTree/efl/CMakeLists.txt:
862         * DumpRenderTree/efl/FontManagement.cpp:
863         (addFontDirectory):
864         (addFontsToEnvironment):
865
866 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
867
868         webkitpy: get ServerProcess out of the reportcrash business
869         https://bugs.webkit.org/show_bug.cgi?id=81600
870
871         Unreviewed, build fix.
872
873         Re-land r111307 and r111293 with another fix for a crash in NRWT;
874         we need to check if the driver has crashed before attempting to
875         read from it.
876
877
878         * Scripts/webkitpy/layout_tests/port/server_process.py:
879         (ServerProcess._reset):
880         (ServerProcess._handle_possible_interrupt):
881         (ServerProcess.write):
882         (ServerProcess.read_stdout):
883         (ServerProcess.has_crashed):
884         (ServerProcess._read):
885         (ServerProcess.stop):
886         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
887         (TrivialMockPort.check_for_leaks):
888         (TestServerProcess.test_broken_pipe):
889         * Scripts/webkitpy/layout_tests/port/webkit.py:
890         (WebKitPort._read_image_diff):
891         (WebKitDriver.has_crashed):
892         (WebKitDriver._check_for_driver_crash):
893         (WebKitDriver.run_test):
894         (WebKitDriver._read_block):
895         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
896         (MockServerProcess.__init__):
897         (MockServerProcess):
898         (MockServerProcess.has_crashed):
899
900 2012-03-21  Zeno Albisser  <zeno@webkit.org>
901
902         [Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a.
903         https://bugs.webkit.org/show_bug.cgi?id=81750
904
905         Building WebCore on mac currently creates an archive that is bigger than
906         4GB. But ranlib fails to create a symbol table for such a big archive,
907         even on 64bit machines.
908         Therefore we start using SVGAllInOne.cpp when building debug
909         on mac. This reduces the size of the archive by about 300MB.
910
911         Reviewed by Tor Arne Vestbø.
912
913         * qmake/mkspecs/features/mac/default_pre.prf:
914
915 2012-03-21  Szilard Ledan  <szledan@inf.u-szeged.hu>
916
917         Updated the address list of committers.py.
918
919         Reviewed by Csaba Osztrogonác.
920
921         * Scripts/webkitpy/common/config/committers.py:
922
923 2012-03-21  W. James MacLean  <wjmaclean@chromium.org>
924
925         Updating my nick in committers file.
926
927         Unreviewed.
928
929         * Scripts/webkitpy/common/config/committers.py:
930
931 2012-03-21  Peter Beverloo  <peter@chromium.org>
932
933         [Chromium] Remove Android build-fix when the proper fix rolled into WebKit
934         https://bugs.webkit.org/show_bug.cgi?id=80861
935
936         Reviewed by Tony Chang.
937
938         Remove most Android-specific logic from webkitdirs.pm in favor of
939         handling this during project generation time.
940
941         * Scripts/webkitdirs.pm:
942         (buildChromiumMakefile):
943
944 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
945
946         [GTK] Allow running javascript from location bar in MiniBrowser
947         https://bugs.webkit.org/show_bug.cgi?id=81331
948
949         Reviewed by Martin Robinson.
950
951         * MiniBrowser/gtk/BrowserWindow.c:
952         (activateUriEntryCallback): Use browser_window_load_uri().
953         (browser_window_load_uri): Check whether uri starts with
954         javascript: and run the given script, or just call
955         webkit_web_view_load_uri() to load the given uri.
956         * MiniBrowser/gtk/BrowserWindow.h:
957         * MiniBrowser/gtk/main.c:
958         (createBrowserWindow): Use browser_window_load_uri().
959
960 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
961
962         [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+
963         https://bugs.webkit.org/show_bug.cgi?id=75543
964
965         Reviewed by Martin Robinson.
966
967         * MiniBrowser/gtk/GNUmakefile.am: Add javascriptcore_cppflags to
968         MiniBrowser CPP flags.
969
970 2012-03-20  Eric Seidel  <eric@webkit.org>
971
972         Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
973         https://bugs.webkit.org/show_bug.cgi?id=80911
974
975         Reviewed by Adam Barth.
976
977         Update include paths for Source/WTF.
978
979         * DumpRenderTree/efl/CMakeLists.txt:
980         * DumpRenderTree/qt/DumpRenderTree.pro:
981         * QtTestBrowser/QtTestBrowser.pro:
982         * Scripts/build-webkit: Build Source/WTF on AppleWin as well.
983
984 2012-03-20  Adam Barth  <abarth@webkit.org>
985
986         svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
987         https://bugs.webkit.org/show_bug.cgi?id=81567
988
989         Reviewed by Eric Seidel.
990
991         This temporary measure should help us avoid disrupting the folks
992         working on WebAudio when we move the webaudio directory to Modules.
993
994         * Scripts/VCSUtils.pm:
995         (adjustPathForRecentRenamings):
996         (parseGitDiffHeader):
997         (parseSvnDiffHeader):
998
999 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
1000
1001         Unreviewed, rolling out r111453.
1002         http://trac.webkit.org/changeset/111453
1003         https://bugs.webkit.org/show_bug.cgi?id=81600
1004
1005         still broken
1006
1007         * Scripts/webkitpy/layout_tests/port/server_process.py:
1008         (ServerProcess._reset):
1009         (ServerProcess.handle_interrupt):
1010         (ServerProcess.write):
1011         (ServerProcess._check_for_crash):
1012         (ServerProcess._handle_timeout):
1013         (ServerProcess._check_for_abort):
1014         (ServerProcess._read):
1015         (ServerProcess.stop):
1016         (ServerProcess):
1017         (ServerProcess.set_crashed):
1018         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1019         (TrivialMockPort.is_crash_reporter):
1020         (TestServerProcess.test_broken_pipe):
1021         * Scripts/webkitpy/layout_tests/port/webkit.py:
1022         (WebKitPort._read_image_diff):
1023         (WebKitDriver.has_crashed):
1024         (WebKitDriver._check_for_driver_crash):
1025         (WebKitDriver):
1026         (WebKitDriver._detected_crash):
1027         (WebKitDriver._subprocess_crashed):
1028         (WebKitDriver._crashed_process_name):
1029         (WebKitDriver.run_test):
1030         (WebKitDriver._read_block):
1031         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1032         (MockServerProcess.__init__):
1033
1034 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
1035
1036         webkitpy: get ServerProcess out of the reportcrash business
1037         https://bugs.webkit.org/show_bug.cgi?id=81600
1038
1039         Unreviewed, build fix.
1040
1041         Re-land r111307 and r111293 with fix for crash in NRWT; I
1042         was failing to set the crashing process name.
1043
1044         * Scripts/webkitpy/layout_tests/port/server_process.py:
1045         (ServerProcess._reset):
1046         (ServerProcess._handle_possible_interrupt):
1047         (ServerProcess.write):
1048         (ServerProcess.read_stdout):
1049         (ServerProcess.has_crashed):
1050         (ServerProcess._read):
1051         (ServerProcess.stop):
1052         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1053         (TrivialMockPort.check_for_leaks):
1054         (TestServerProcess.test_broken_pipe):
1055         * Scripts/webkitpy/layout_tests/port/webkit.py:
1056         (WebKitPort._read_image_diff):
1057         (WebKitDriver.has_crashed):
1058         (WebKitDriver._check_for_driver_crash):
1059         (WebKitDriver.run_test):
1060         (WebKitDriver._read_block):
1061         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1062         (MockServerProcess.__init__):
1063         (MockServerProcess):
1064         (MockServerProcess.has_crashed):
1065
1066 2012-03-20  Tim Horton  <timothy_horton@apple.com>
1067
1068         [mac] Restore color space switching code to run-webkit-tests
1069         https://bugs.webkit.org/show_bug.cgi?id=80571
1070         <rdar://problem/11008529>
1071
1072         Reviewed by Simon Fraser.
1073
1074         http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard.
1075         
1076         Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID
1077         didn't exist until Lion.
1078
1079         * DumpRenderTree/mac/LayoutTestHelper.m:
1080         (installLayoutTestColorProfile):
1081         (restoreUserColorProfile):
1082
1083 2012-03-20  Adele Peterson  <adele@apple.com>
1084
1085         Update the last test to use EXPECT_WK_STREQ.
1086
1087         Reviewed by Dan Bernstein.
1088
1089         * TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST):
1090
1091 2012-03-20  Adele Peterson  <adele@apple.com>
1092
1093         "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
1094         https://bugs.webkit.org/show_bug.cgi?id=81630
1095         <rdar://problem/10650660>
1096
1097         Reviewed by Alexey Proskuryakov.
1098
1099         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1100         * TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
1101         * TestWebKitAPI/Tests/mac/AttributedString.mm: Added.
1102         (-[AttributedStringTest webView:didFinishLoadForFrame:]):
1103         (TestWebKitAPI):
1104         (TestWebKitAPI::didFinishLoadForFrame):
1105         (TestWebKitAPI::TEST):
1106         * TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.
1107
1108 2012-03-20  Eric Seidel  <eric@webkit.org>
1109
1110         Add link on queues.webkit.org to kov's fancy queue-depth graph
1111         https://bugs.webkit.org/show_bug.cgi?id=81690
1112
1113         Reviewed by Adam Barth.
1114
1115         * QueueStatusServer/templates/recentstatus.html:
1116
1117 2012-03-20  Tim Horton  <timothy_horton@apple.com>
1118
1119         [mac] Restore color space switching code to run-webkit-tests
1120         https://bugs.webkit.org/show_bug.cgi?id=80571
1121         <rdar://problem/11008529>
1122
1123         Reviewed by Simon Fraser.
1124
1125         Make use of the layout test helper hooks to restore the Mac system-wide
1126         color profile switching code. This makes WkTR and DRT results match, and
1127         causes the main display's color profile to not affect results on Lion.
1128
1129         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1130         * DumpRenderTree/mac/LayoutTestHelper.m: Added.
1131         (installLayoutTestColorProfile):
1132         (restoreUserColorProfile):
1133         (simpleSignalHandler):
1134         (main):
1135         * Scripts/webkitpy/layout_tests/port/mac.py:
1136         (MacPort.release_http_lock):
1137         (MacPort):
1138         (MacPort._path_to_helper):
1139         (MacPort.start_helper):
1140         (MacPort.stop_helper):
1141         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1142         (WTR::PlatformWebView::PlatformWebView):
1143         (WTR::PlatformWebView::windowSnapshotImage):
1144
1145 2012-02-24  Darin Fisher  <darin@chromium.org>
1146
1147         Add more Chromium WebKit API reviewers
1148         https://bugs.webkit.org/show_bug.cgi?id=81576
1149
1150         Reviewed by Adam Barth and David Levin.
1151
1152         Simplify watchlist to lump all WebKit API into one.
1153
1154         * Scripts/webkitpy/common/config/watchlist:
1155
1156 2012-03-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1157
1158         Convert hasSpellingMarker to use Internals interface.
1159         https://bugs.webkit.org/show_bug.cgi?id=81300
1160
1161         Reviewed by Ryosuke Niwa.
1162
1163         Remove hasSpellingMarker functions, because it is able to work in the
1164         cross-port way through the Internals interface.
1165
1166         * DumpRenderTree/LayoutTestController.cpp:
1167         (LayoutTestController::staticFunctions):
1168         * DumpRenderTree/LayoutTestController.h:
1169         (LayoutTestController):
1170         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1171         * DumpRenderTree/chromium/LayoutTestController.cpp:
1172         (LayoutTestController::LayoutTestController):
1173         * DumpRenderTree/chromium/LayoutTestController.h:
1174         (LayoutTestController):
1175         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1176         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1177         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1178         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1179         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1180         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1181         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1182
1183 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
1184
1185         Add new Qt-WK2 performance tester bot to build.webkit.org
1186         https://bugs.webkit.org/show_bug.cgi?id=80842
1187
1188         Reviewed by Ryosuke Niwa.
1189
1190         * BuildSlaveSupport/build.webkit.org-config/config.json:
1191         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1192         (RunAndUploadPerfTestsWebKit2):
1193         (RunAndUploadPerfTestsWebKit2.start):
1194         (BuildAndPerfTestWebKit2Factory):
1195         (BuildAndPerfTestWebKit2Factory.__init__):
1196         (DownloadAndPerfTestWebKit2Factory):
1197         (DownloadAndPerfTestWebKit2Factory.__init__):
1198
1199 2012-03-20  Peter Beverloo  <peter@chromium.org>
1200
1201         [Chromium] Update to Android NDK r7b
1202         https://bugs.webkit.org/show_bug.cgi?id=81005
1203
1204         Reviewed by Adam Barth.
1205
1206         Update to version r7b of the Android NDK, release notes of which are
1207         available on the following page:
1208         http://developer.android.com/sdk/ndk/index.html
1209
1210         * Scripts/update-webkit-chromium:
1211
1212 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
1213
1214         x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue
1215         https://bugs.webkit.org/show_bug.cgi?id=81502
1216
1217         Unreviewed.
1218
1219         * qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171.
1220
1221 2012-03-19  Jessie Berlin  <jberlin@apple.com>
1222
1223         Unreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293
1224         because they broke running the layout tests on mac.
1225
1226         * Scripts/webkitpy/layout_tests/port/webkit.py:
1227         (WebKitDriver._check_for_driver_crash):
1228
1229 2012-03-16  Martin Robinson  <mrobinson@igalia.com>
1230
1231         [GTK] Allow running run-gtk-tests during 'make distcheck'
1232         https://bugs.webkit.org/show_bug.cgi?id=81415
1233
1234         Reviewed by Philippe Normand.
1235
1236         Modify the build and run-gtk-tests so that it can run during 'make distcheck'
1237
1238         * GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the
1239         main command run during 'make check.'
1240         * Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer
1241         a requirement to run it. If jhbuild isn't around it will simply not start the
1242         SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
1243         main loop and simply use the main loop in a synchronous method to start SPI
1244         daemons. Did a bunch of general cleanup around these tasks.
1245
1246 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1247
1248         jhbuild: Use the multiprocessing module to get the number of CPUs.
1249         https://bugs.webkit.org/show_bug.cgi?id=81585
1250
1251         Reviewed by Martin Robinson.
1252
1253         Now that support for Python 2.5 has been dropped, we can safely
1254         use multiprocessing.cpu_count() to obtain the current number of
1255         CPUs in the system instead of running a webkitperl script for
1256         that.
1257
1258         * efl/common.py:
1259         (top_level_path):
1260         * efl/jhbuildrc:
1261         * gtk/common.py:
1262         (build_path):
1263         * gtk/jhbuildrc:
1264
1265 2012-03-19  Ojan Vafai  <ojan@chromium.org>
1266
1267         We should only add a live event listener once, not once per TestSelector.
1268         Adding one per TestSelector would cause accordion('option', 'active') to
1269         incorrectly be "false" if you examine multiple sets of tests.
1270
1271         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1272
1273 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1274
1275         Fix typo introduced in r111293.
1276
1277         Unreviewed, build fix.
1278
1279         * Scripts/webkitpy/layout_tests/port/webkit.py:
1280         (WebKitDriver._check_for_driver_crash):
1281
1282 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1283
1284         webkitpy: get ServerProcess out of the reportcrash business
1285         https://bugs.webkit.org/show_bug.cgi?id=81600
1286
1287         Reviewed by Adam Barth.
1288
1289         ServerProcess was half-aware that ReportCrash might run
1290         sometimes, and that the process ServerProcess was talking to
1291         might have its own crashing subprocesses; neither of these
1292         things really worked right and it made the logic convoluted, so
1293         this change makes handling crashes completely separate from the
1294         server_process code, so that it can focus on just I/O to the
1295         subprocess.
1296
1297         There should be no functional changes resulting from this patch.
1298
1299         * Scripts/webkitpy/layout_tests/port/server_process.py:
1300         (ServerProcess._reset):
1301         (ServerProcess._handle_possible_interrupt):
1302         (ServerProcess.write):
1303         (ServerProcess.read_stdout):
1304         (ServerProcess.has_crashed):
1305         (ServerProcess._read):
1306         (ServerProcess.stop):
1307         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1308         (TrivialMockPort.check_for_leaks):
1309         (TestServerProcess.test_broken_pipe):
1310         * Scripts/webkitpy/layout_tests/port/webkit.py:
1311         (WebKitPort._read_image_diff):
1312         (WebKitDriver.has_crashed):
1313         (WebKitDriver._check_for_driver_crash):
1314         (WebKitDriver.run_test):
1315         (WebKitDriver._read_block):
1316         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1317         (MockServerProcess.__init__):
1318         (MockServerProcess):
1319         (MockServerProcess.has_crashed):
1320
1321 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1322
1323         webkitpy: crashlog parsing is broken
1324         https://bugs.webkit.org/show_bug.cgi?id=81586
1325
1326         Reviewed by Adam Barth.
1327
1328         Seeking on a file opened through codecs() appears to not work
1329         correctly (at least on SL).
1330         
1331         The code was more complicated than it needed to be, so I have
1332         revamped it to just read a full crashlog at once and then look
1333         for matches. 
1334         
1335         I have also added the ability to optionally propagate
1336         errors back (which can be helpful to debug races when ReportCrash is
1337         still running and you need to see that you couldn't open some
1338         files, rather than just ignoring them).
1339
1340         * Scripts/webkitpy/common/system/crashlogs.py:
1341         (CrashLogs.find_newest_log):
1342         (CrashLogs._find_newest_log_darwin):
1343         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1344         (CrashLogsTest.test_find_log_darwin):
1345
1346 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1347
1348         webkitpy: clean up some port._filesystem references to not reference private members
1349         https://bugs.webkit.org/show_bug.cgi?id=81595
1350
1351         Reviewed by Eric Seidel.
1352
1353         There should be no functional changes in this patch, just some
1354         refactoring. Also, fixes a minor nit in write_image_diff_files(()
1355
1356         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1357         (SingleTestRunner.__init__):
1358         (SingleTestRunner._run_compare_test):
1359         (SingleTestRunner._run_rebaseline):
1360         (SingleTestRunner._save_baseline_data):
1361         (SingleTestRunner._handle_error):
1362         (SingleTestRunner._run_reftest):
1363         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1364         (write_test_result):
1365         (TestResultWriter.__init__):
1366         (TestResultWriter._make_output_directory):
1367         (TestResultWriter.output_filename):
1368         (TestResultWriter._output_testname):
1369         (TestResultWriter.write_output_files):
1370         (TestResultWriter.write_stderr):
1371         (TestResultWriter.write_crash_report):
1372         (TestResultWriter.create_text_diff_and_write_result):
1373         (TestResultWriter.write_image_diff_files):
1374         (copy_file):
1375         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1376         (TestResultWriterTest.test_reftest_diff_image):
1377
1378 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1379
1380         webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
1381         https://bugs.webkit.org/show_bug.cgi?id=81598
1382
1383         Reviewed by Eric Seidel.
1384
1385         "DumpRenderTree" shouldn't be hard-coded here, since some other
1386         process may actually be crashing (WebKitTestRunner, WebProcess, etc.)
1387         
1388         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1389         (TestExpectations):
1390
1391 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1392
1393         webkitpy: allow instance data in TestFailure objects
1394         https://bugs.webkit.org/show_bug.cgi?id=81580
1395
1396         Reviewed by Tony Chang.
1397
1398         Current TestFailures are basically enums, but it would be nice,
1399         especially for crashes, if they contained the name and pid of
1400         the process that crashed.
1401
1402         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1403         (TestFailure.message):
1404         (FailureTimeout.message):
1405         (FailureCrash):
1406         (FailureCrash.__init__):
1407         (FailureCrash.message):
1408         (FailureMissingResult.message):
1409         (FailureTextMismatch.message):
1410         (FailureMissingImageHash.message):
1411         (FailureMissingImage.message):
1412         (FailureImageHashMismatch.message):
1413         (FailureImageHashIncorrect.message):
1414         (FailureReftestMismatch.message):
1415         (FailureReftestMismatchDidNotOccur.message):
1416         (FailureReftestNoImagesGenerated.message):
1417         (FailureMissingAudio.message):
1418         (FailureAudioMismatch.message):
1419         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
1420         (TestFailuresTest.test_equals):
1421         (TestFailuresTest):
1422         (TestFailuresTest.test_crashes):
1423
1424 2012-03-19  Brady Eidson  <beidson@apple.com>
1425
1426         <rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
1427         Crash in 3rd party WebKit apps under XHR/Cache code
1428
1429         Reviewed by Antti Koivisto.
1430
1431         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1432         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
1433         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.
1434         (-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1435         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1436         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1437         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1438         (TestWebKitAPI):
1439         (TestWebKitAPI::TEST):
1440
1441 2012-03-19  Brady Eidson  <beidson@apple.com>
1442
1443         <rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
1444         REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format
1445
1446         Reviewed by Enrica Casucci.
1447
1448         Bring up a context menu on a link, copy the link, then verify the pasteboard contents
1449         are in the correct format.
1450
1451         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1452         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
1453         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.
1454         (-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
1455         (TestWebKitAPI::contextMenuCopyLink):
1456         (TestWebKitAPI::TEST):
1457
1458 2012-03-19  Ojan Vafai  <ojan@chromium.org>
1459
1460         Make the selected item in the accordion a link to the flakiness dashboard
1461         https://bugs.webkit.org/show_bug.cgi?id=81571
1462
1463         Reviewed by Dimitri Glazkov.
1464
1465         Also, make it so that you can select the text of the link, instead of the current behavior
1466         of acting as if you had clicked on the accordion header.
1467
1468         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1469         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1470
1471 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1472
1473         NRWT runs some tests that are skipped with -i command line option
1474         https://bugs.webkit.org/show_bug.cgi?id=81535
1475
1476         Reviewed by Ojan Vafai.
1477
1478         This change modifies the interaction of Skipped files and
1479         test_expectations files so that entries in Skipped files (and
1480         the -i command line) override *everything* in the expectations
1481         file.
1482
1483         Specifically, a directory in a Skipped file will cause all of
1484         the tests in the dir to be skipped even if individual tests in
1485         the dir are listed in the test_expectations.txt.
1486
1487         Skipped files also override anything in an overrides files.
1488
1489         This seems to make more intuitive sense, since if you list
1490         something in the Skips file (and even more specify it on the
1491         command line) you probably want it to be universally applied.
1492
1493         Theoretically we could add more precedence levels and have full
1494         paths in an expectations file override dirs in a Skipped file
1495         (but not the command line), but I don't know yet that that level
1496         of complexity is justified.
1497         
1498         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1499         (TestExpectations.__init__):
1500         (TestExpectations._add_skipped_tests):
1501         (TestExpectations._add_test):
1502         (TestExpectations._add_expectations):
1503         (TestExpectations._add_expectation_line):
1504         (TestExpectations._already_seen_better_match):
1505         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1506         (test_more_specific_override_resets_skip):
1507         (SkippedTests):
1508         (SkippedTests.get_exp):
1509         (SkippedTests.assert_exp):
1510         (SkippedTests.test_skipped_tests_work):
1511         (SkippedTests.test_duplicate_skipped_test_fails_lint):
1512         (SkippedTests.test_skipped_file_overrides_expectations):
1513         (SkippedTests.test_skipped_dir_overrides_expectations):
1514         (SkippedTests.test_skipped_file_overrides_overrides):
1515         (SkippedTests.test_skipped_dir_overrides_overrides):
1516
1517 2012-03-19  Eric Seidel  <eric@webkit.org>
1518
1519         Fix WTF header include discipline in Chromium WebKit
1520         https://bugs.webkit.org/show_bug.cgi?id=81281
1521
1522         Reviewed by James Robinson.
1523
1524         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1525         * Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.
1526
1527 2012-03-19  Andy Chen  <andchen@rim.com>
1528
1529         [BlackBerry] Add new layout test for text match marker
1530         https://bugs.webkit.org/show_bug.cgi?id=81531
1531
1532         Make the LayoutTestControllerBlackBerry::findString to test the
1533         BlackBerry port implementation.
1534
1535         Reviewed by Rob Buis.
1536
1537         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1538         (LayoutTestController::findString):
1539
1540 2012-03-19  Ojan Vafai  <ojan@chromium.org>
1541
1542         Don't show WONTFIX tests in garden-o-matic
1543         https://bugs.webkit.org/show_bug.cgi?id=81554
1544
1545         Reviewed by Dimitri Glazkov.
1546
1547         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1548         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1549
1550 2012-03-19  Chris Fleizach  <cfleizach@apple.com>
1551
1552         platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
1553         https://bugs.webkit.org/show_bug.cgi?id=81530
1554
1555         Reviewed by Jessie Berlin.
1556
1557         Add rowAtIndex to WebKitTestRunner.
1558
1559         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1560         (WTR::AccessibilityUIElement::rowAtIndex):
1561         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1562         (AccessibilityUIElement):
1563         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1564         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1565         (WTR):
1566         (WTR::AccessibilityUIElement::rowAtIndex):
1567
1568 2012-03-19  Ojan Vafai  <ojan@chromium.org>
1569
1570         Change garden-o-matic All Failures tab to Expected Failures
1571         https://bugs.webkit.org/show_bug.cgi?id=81540
1572
1573         Reviewed by Dimitri Glazkov.
1574
1575         Also, fix some broken unittests that had just gotten stale.
1576
1577         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1578         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
1579         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1580         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1581         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1582         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1583         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1584         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1585         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1586         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1587
1588 2012-03-19  Hao Zheng  <zhenghao@chromium.org>
1589
1590         [chromium] DRT crashes at shutdown.
1591         https://bugs.webkit.org/show_bug.cgi?id=81504
1592
1593         Reviewed by James Robinson.
1594
1595         WebCompositor must be destroyed after WebView is properly destroyed,
1596         or some compositor objects like CCLayerTreeHost may not be destroyed.
1597         However, it is really hard to make the destruction order correct
1598         explicitly in ~TestShell. So move it out to DumpRenderTree.
1599
1600         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1601         (main):
1602         * DumpRenderTree/chromium/TestShell.cpp:
1603         (TestShell::~TestShell):
1604
1605 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1606
1607         add dpranke to webkitpy watchlist
1608         https://bugs.webkit.org/show_bug.cgi?id=81433
1609
1610         Reviewed by Benjamin Poulain.
1611
1612         * Scripts/webkitpy/common/config/watchlist:
1613
1614 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1615
1616         test-webkitpy is failing on SL/Python 2.6.1
1617         https://bugs.webkit.org/show_bug.cgi?id=81533
1618
1619         Reviewed by Ojan Vafai.
1620
1621         It appears that itertools.combinations() is buggy in 2.6.1; this
1622         backports the implementation from 2.7.
1623
1624         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1625         (TestConfigurationConverter.collapse_macros):
1626         (TestConfigurationConverter):
1627         (TestConfigurationConverter.combinations):
1628
1629 2012-03-19  David Michael Barr  <davidbarr@google.com>
1630
1631         Optimize the cleanup sequence in the start-queue.sh script
1632         https://github.com/abarth/webkit/pull/1
1633
1634         Reviewed by Adam Barth.
1635
1636         Updating the working copy is an expensive operation
1637         for a repository the size of WebKit.
1638         Attempt to reset only to the target revision.
1639
1640         * EWSTools/start-queue.sh:
1641
1642 2012-03-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
1643
1644         Adjust architecture type of the EFL build bot.
1645         https://bugs.webkit.org/show_bug.cgi?id=81452
1646
1647         Reviewed by Tony Chang.
1648
1649         * BuildSlaveSupport/build.webkit.org-config/config.json: The
1650         buildslave is a 64-bit machine, therefore describe it as being
1651         x86_64, not i386.
1652
1653 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
1654
1655         [Qt] printLoadedUrls prints "Object" instead of the actual URL.
1656         https://bugs.webkit.org/show_bug.cgi?id=81514
1657
1658         Reviewed by Simon Hausmann.
1659
1660         * MiniBrowser/qt/qml/BrowserWindow.qml:
1661
1662 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1663
1664         [EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
1665         https://bugs.webkit.org/show_bug.cgi?id=81491
1666
1667         Reviewed by Philippe Normand.
1668
1669         For the find_path(), find_library() etc CMake calls to find the
1670         dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
1671         set, otherwise CMake cannot know the dependencies exist and will only
1672         look in the standard directories.
1673
1674         * efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with
1675         the jhbuild Root directory.
1676
1677 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1678
1679         [EFL] Add XDG env vars to jhbuildrc
1680         https://bugs.webkit.org/show_bug.cgi?id=81510
1681
1682         Needed to ensure correct glib behaviour in jhbuild environment.
1683
1684         Reviewed by Philippe Normand.
1685
1686         * efl/jhbuildrc:
1687
1688 2012-03-19  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1689
1690         Select best target for tap gesture.
1691         https://bugs.webkit.org/show_bug.cgi?id=78801
1692
1693         Reviewed by Kenneth Rohde Christiansen.
1694
1695         Add TOUCH_ADJUSTMENT to enabled features.
1696
1697         * qmake/mkspecs/features/features.prf:
1698
1699 2012-03-19  Robert Kroeger  <rjkroege@chromium.org>
1700
1701         [chromium] synthesize wheel events for fling on main thread
1702         https://bugs.webkit.org/show_bug.cgi?id=81458
1703
1704         Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.
1705
1706         Reviewed by James Robinson.
1707
1708         * DumpRenderTree/chromium/EventSender.cpp:
1709         (EventSender::EventSender):
1710         (EventSender::gestureFlingCancel):
1711         (EventSender::gestureFlingStart):
1712         * DumpRenderTree/chromium/EventSender.h:
1713         (EventSender):
1714
1715 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
1716
1717         [Qt] Add command line option to set the user agent in the MiniBrowser
1718         https://bugs.webkit.org/show_bug.cgi?id=81508
1719
1720         Reviewed by Simon Hausmann.
1721
1722         * MiniBrowser/qt/BrowserWindow.cpp:
1723         (BrowserWindow::BrowserWindow):
1724         (BrowserWindow::webViewExperimental):
1725         * MiniBrowser/qt/BrowserWindow.h:
1726         (BrowserWindow):
1727         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1728         (printHelp):
1729         (MiniBrowserApplication::handleUserOptions):
1730         * MiniBrowser/qt/MiniBrowserApplication.h:
1731         (WindowOptions::WindowOptions):
1732         (WindowOptions::setUserAgent):
1733         (WindowOptions::userAgent):
1734         (WindowOptions):
1735
1736 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
1737
1738         [Qt] Remove dead user agent code from the MiniBrowser.
1739
1740         Reviewed by Simon Hausmann.
1741
1742         * MiniBrowser/qt/BrowserWindow.cpp:
1743         * MiniBrowser/qt/BrowserWindow.h:
1744         (BrowserWindow):
1745         * MiniBrowser/qt/MiniBrowser.qrc:
1746         * MiniBrowser/qt/useragentlist.txt: Removed.
1747
1748 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1749
1750         jhbuild: Call jhbuild's autogen.sh via bash.
1751         https://bugs.webkit.org/show_bug.cgi?id=81485
1752
1753         Reviewed by Philippe Normand.
1754
1755         jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
1756         this is usually true only on Linux systems, and even then bash for
1757         some reason might not be available in that location. It is safer to
1758         call bash directly and pass autogen.sh to it instead.
1759
1760         * jhbuild/jhbuild-wrapper:
1761         (install_jhbuild):
1762
1763 2012-03-19  Philippe Normand  <pnormand@igalia.com>
1764
1765         [GTK] Prefix run-launcher with run-with-jhbuild
1766         https://bugs.webkit.org/show_bug.cgi?id=81503
1767
1768         Reviewed by Hajime Morita.
1769
1770         * Scripts/run-launcher:
1771
1772 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1773
1774         [EFL] Prefix run-launcher with run-with-jhbuild
1775         https://bugs.webkit.org/show_bug.cgi?id=80026
1776
1777         Reviewed by Hajime Morita.
1778
1779         * Scripts/run-launcher:
1780
1781 2012-03-18  Csaba Osztrogonác  <ossy@webkit.org>
1782
1783         [Qt] Unreviewed. Disable -Werror on x86 until proper fix.
1784         https://bugs.webkit.org/show_bug.cgi?id=81498
1785
1786         * qmake/mkspecs/features/unix/default_post.prf:
1787
1788 2012-03-17  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1789
1790         Unreviewed; switch to using my FreeBSD.org email address, the
1791         other one is going to disappear soon.
1792
1793         * Scripts/webkitpy/common/config/committers.py:
1794         * Scripts/webkitpy/common/config/watchlist:
1795
1796 2012-03-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1797
1798         Unreviewed; fix webkitpy unit test failures after r111116.
1799
1800         It turns out that cmd_line in the patch in bug 80025 had the right
1801         signature when it was submitted, but r109242 added a few more
1802         required parameters, and since the method (and EflDriver) did not
1803         exist at the time we ended up committing a broken method.
1804
1805         * Scripts/webkitpy/layout_tests/port/efl.py:
1806         (EflDriver.cmd_line): Add the `pixel_tests' and `per_test_args'
1807         arguments.
1808
1809 2012-03-17  Charles Wei  <charles.wei@torchmobile.com.cn>
1810
1811         [BlackBerry] Enable Web Timing for performance profiling and improvement.
1812         https://bugs.webkit.org/show_bug.cgi?id=81085
1813
1814         Reviewed by Rob Buis.
1815
1816         * Scripts/build-webkit:
1817
1818 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1819
1820         Add a dependencies installation step for EFL to buildbot master.cfg
1821         https://bugs.webkit.org/show_bug.cgi?id=81337
1822
1823         Reviewed by Gustavo Noronha Silva.
1824
1825         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1826         (InstallEflDependencies):
1827         (Factory.__init__):
1828
1829 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1830
1831         [EFL] Prefixing run-webkit-tests with run-with-jhbuild
1832         https://bugs.webkit.org/show_bug.cgi?id=80025
1833
1834         Reviewed by Gustavo Noronha Silva.
1835
1836         * Scripts/webkitpy/layout_tests/port/efl.py:
1837         (EflDriver):
1838         (EflDriver.cmd_line):
1839         (EflPort._driver_class):
1840
1841 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1842
1843         [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
1844         https://bugs.webkit.org/show_bug.cgi?id=79904
1845
1846         build-webkit --efl will use jhbuild for fetching and building dependencies.
1847
1848         Reviewed by Gustavo Noronha Silva.
1849
1850         * Scripts/update-webkitefl-libs: Added.
1851         * Scripts/webkitdirs.pm:
1852         (jhbuildWrapperPrefixIfNeeded):
1853         (generateBuildSystemFromCMakeProject):
1854         (buildCMakeGeneratedProject):
1855         * efl/common.py: Added.
1856         (script_path):
1857         (top_level_path):
1858         (number_of_cpus):
1859         * efl/jhbuild.modules: Added.
1860         * efl/jhbuildrc: Added.
1861         * efl/run-with-jhbuild: Added.
1862
1863 2012-03-16  Stephanie Lewis  <slewis@apple.com>
1864
1865         https://bugs.webkit.org/show_bug.cgi?id=81065
1866         <rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
1867         Fix crash preventing WebKitTestRunner from working in Release.  
1868         WebKitTestRunner used ostringstream to collect output from the test.  ostringstream is incompatible with our
1869         FastMalloc overrides.  When copying strings out ostringstream a new string is allocated with FastMalloc because
1870         the allocation is inlined.  When that string is freed is uses the system malloc because that call is not inlined.
1871
1872         I removed ostringstream in favor of StringBuilder.  
1873
1874         Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.
1875
1876         Reviewed by Geoff Garen.
1877
1878         Add DEBUG_DEFINES to set NDEBUG on release builds.
1879         * WebKitTestRunner/Configurations/Base.xcconfig:
1880         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1881
1882         Remove ostringstream member in favor of StringBuilder.
1883         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1884         (WTR::InjectedBundle::initialize):
1885         (WTR::InjectedBundle::beginTesting):
1886         (WTR::InjectedBundle::done):
1887         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1888         (WTF):
1889         (WTR::InjectedBundle::stringBuilder):
1890         (InjectedBundle):
1891
1892         Append output to StringBuilder.
1893         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1894         (WTR::hasPrefix):
1895         (WTR::dumpPath):
1896         (WTR::rangeToStr):
1897         (WTR::styleDecToStr):
1898         (WTR::frameToStr):
1899         (WTR::dumpFrameScrollPosition):
1900         (WTR::dumpFrameText):
1901         (WTR::dumpDescendantFramesText):
1902         (WTR::InjectedBundlePage::dump):
1903         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1904         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1905         (WTR::InjectedBundlePage::willSendRequestForFrame):
1906         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1907         (WTR::lastFileURLPathComponent):
1908         (WTR::InjectedBundlePage::willAddMessageToConsole):
1909         (WTR::InjectedBundlePage::willSetStatusbarText):
1910         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1911         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1912         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1913         (WTR::InjectedBundlePage::shouldBeginEditing):
1914         (WTR::InjectedBundlePage::shouldEndEditing):
1915         (WTR::InjectedBundlePage::shouldInsertNode):
1916         (WTR::InjectedBundlePage::shouldInsertText):
1917         (WTR::InjectedBundlePage::shouldDeleteRange):
1918         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1919         (WTR::InjectedBundlePage::shouldApplyStyle):
1920         (WTR::InjectedBundlePage::didBeginEditing):
1921         (WTR::InjectedBundlePage::didEndEditing):
1922         (WTR::InjectedBundlePage::didChange):
1923         (WTR::InjectedBundlePage::didChangeSelection):
1924         (WTR::InjectedBundlePage::supportsFullScreen):
1925         (WTR::InjectedBundlePage::enterFullScreenForElement):
1926         (WTR::InjectedBundlePage::exitFullScreenForElement):
1927         (WTR::InjectedBundlePage::beganEnterFullScreen):
1928         (WTR::InjectedBundlePage::beganExitFullScreen):
1929         (WTR::dumpBackForwardListItem):
1930         (WTR::InjectedBundlePage::dumpBackForwardList):
1931         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1932         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
1933         (WTR::LayoutTestController::dumpConfigurationForViewport):
1934         
1935         Convert between WTF::String and WKStringRef.
1936         * WebKitTestRunner/StringFunctions.h:
1937         (WTR::toWTFString):
1938         (WTR):
1939         * WebKitTestRunner/TestInvocation.cpp:
1940         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1941
1942 2012-03-16  Eric Seidel  <eric@webkit.org>
1943
1944         Add a land-from-url command
1945         https://bugs.webkit.org/show_bug.cgi?id=81411
1946
1947         Reviewed by Adam Barth.
1948
1949         Very basic so far.  The goal is to make it landing smarter
1950         so that users don't have to bother to parse out the ids out of the urls.
1951
1952         * Scripts/webkitpy/common/config/urls.py:
1953         (parse_bug_id):
1954         (parse_attachment_id):
1955         * Scripts/webkitpy/common/config/urls_unittest.py:
1956         (URLsTest.test_parse_bug_id):
1957         (URLsTest):
1958         (URLsTest.test_parse_attachment_id):
1959         * Scripts/webkitpy/tool/commands/download.py:
1960         (ProcessURLsMixin):
1961         (ProcessURLsMixin._fetch_list_of_patches_to_process):
1962         (LandFromURL):
1963         * Scripts/webkitpy/tool/commands/download_unittest.py:
1964         (test_land_from_bug):
1965         (test_land_from_url):
1966
1967 2012-03-16  Dave Tharp  <dtharp@codeaurora.org>
1968
1969         build-webkit launcher instructions use wrong relative path for Qt
1970         https://bugs.webkit.org/show_bug.cgi?id=81357
1971
1972         Reviewed by Eric Seidel.
1973
1974         Ensure we are at the proper directory before generating run-launcher
1975         instructions.
1976
1977         * Scripts/build-webkit:
1978
1979 2012-03-16  Brady Eidson  <beidson@apple.com>
1980
1981         <rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412
1982         REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted
1983
1984         Reviewed by Geoff Garen.
1985
1986         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1987         * TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.
1988
1989 2012-03-16  Ojan Vafai  <ojan@chromium.org>
1990
1991         Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
1992         https://bugs.webkit.org/show_bug.cgi?id=81407
1993
1994         Reviewed by Adam Barth.
1995
1996         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1997         (summarize_results):
1998         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1999         (ResultSummaryTest.summarized_results):
2000         (ResultSummaryTest.test_no_svn_revision):
2001         (ResultSummaryTest.test_svn_revision):
2002         (ResultSummaryTest):
2003         (ResultSummaryTest.test_summarized_results_wontfix):
2004
2005 2012-03-16  Ojan Vafai  <ojan@chromium.org>
2006
2007         Have webkit-patch rebaseline-test update test_expectations.txt
2008         https://bugs.webkit.org/show_bug.cgi?id=81054
2009
2010         Recommit http://trac.webkit.org/changeset/110783 now that
2011         http://trac.webkit.org/changeset/111034 has landed.
2012
2013         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2014         (TestExpectations.remove_configuration_from_test):
2015         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2016         (RemoveConfigurationsTest):
2017         (RemoveConfigurationsTest.test_remove):
2018         (test_remove_line):
2019         * Scripts/webkitpy/tool/commands/rebaseline.py:
2020         (RebaselineTest._update_expectations_file):
2021         (RebaselineTest._rebaseline_test_and_update_expectations):
2022         (RebaselineTest):
2023         (RebaselineTest.execute):
2024         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2025         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2026         (test_rebaseline_updates_expectations_file):
2027
2028 2012-03-15  Ojan Vafai  <ojan@chromium.org>
2029
2030         Specifier collapsing when writing test expectations lines gets a number of cases wrong
2031         https://bugs.webkit.org/show_bug.cgi?id=81309
2032
2033         Reviewed by Dimitri Glazkov.
2034
2035         I've run this over all the lines in the current Chromium test_expectations.txt file,
2036         so I'm relatively confident we now cover all the cases.
2037
2038         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2039         (TestConfigurationConverter.__init__):
2040         (TestConfigurationConverter.collapse_macros):
2041         (TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
2042         (TestConfigurationConverter):
2043         (TestConfigurationConverter.intersect_combination):
2044         (TestConfigurationConverter.symmetric_difference):
2045         (TestConfigurationConverter.to_specifiers_list):
2046         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2047         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2048         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2049         (make_mock_all_test_configurations_set):
2050         (TestConfigurationConverterTest.test_symmetric_difference):
2051         (TestConfigurationConverterTest.test_to_config_set):
2052         (TestConfigurationConverterTest.test_macro_expansion):
2053         (TestConfigurationConverterTest.test_to_specifier_lists):
2054         (TestConfigurationConverterTest.test_converter_macro_collapsing):
2055         * Scripts/webkitpy/layout_tests/port/chromium.py:
2056         (ChromiumPort):
2057         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2058         (ChromiumAndroidPort.__init__):
2059         The android port uses "arm" as it's architecture, which is technically correct,
2060         but considerably complicates making collapsing work. We probably should kill
2061         the concept of architecture entirely. The benefits are not worth the code
2062         complexity.
2063
2064         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2065         (ChromiumPortTest.test_all_test_configurations):
2066         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2067         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2068         (test_rebaseline_updates_expectations_file):
2069
2070 2012-03-16  Dinu Jacob  <dinu.jacob@nokia.com>
2071
2072         [Qt][Wk2] Assertion Failure and crash on file upload
2073         https://bugs.webkit.org/show_bug.cgi?id=80854
2074
2075         Reviewed by Simon Hausmann.
2076
2077         Added filePicker to WebView using experimental API.
2078
2079         * MiniBrowser/qt/MiniBrowser.qrc:
2080         * MiniBrowser/qt/icons/folder.png: Added.
2081         * MiniBrowser/qt/icons/titlebar.png: Added.
2082         * MiniBrowser/qt/icons/up.png: Added.
2083         * MiniBrowser/qt/qml/BrowserWindow.qml:
2084         * MiniBrowser/qt/qml/FilePicker.qml: Added.
2085
2086 2012-03-16  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2087
2088         Updating email for committer.py script.
2089
2090         * Scripts/webkitpy/common/config/committers.py:
2091
2092 2012-03-16  Robert Kroeger  <rjkroege@chromium.org>
2093
2094         [chromium] DRT: Add support for sending gesture scrolls without a begin
2095         https://bugs.webkit.org/show_bug.cgi?id=81292
2096
2097         Reviewed by Kent Tamura.
2098
2099         * DumpRenderTree/chromium/EventSender.cpp:
2100         (EventSender::EventSender):
2101         (EventSender::gestureScrollFirstPoint):
2102         * DumpRenderTree/chromium/EventSender.h:
2103         (EventSender):
2104
2105 2012-03-02  Carlos Garcia Campos  <cgarcia@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
2106
2107         [GTK] WebKitIconDatabase doesn't keep icons cached
2108         https://bugs.webkit.org/show_bug.cgi?id=56200
2109
2110         Reviewed by Martin Robinson.
2111
2112         Add support for favicons in GtkLauncher.
2113
2114         * GtkLauncher/main.c:
2115         (activateUriEntryCb):
2116         (iconLoadedCb):
2117         (createBrowser):
2118
2119 2012-03-16  Adam Barth  <abarth@webkit.org>
2120
2121         Remove sheriff-bot's last-green-revision command
2122         https://bugs.webkit.org/show_bug.cgi?id=81314
2123
2124         Reviewed by Eric Seidel.
2125
2126         This command is a cruel joke.  WebKit doesn't really ever have a
2127         last-green-revision.
2128
2129         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2130         (BuildBot._find_green_revision):
2131         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2132         (MockBuildBot.builder_statuses):
2133         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2134         (test_find_green_revision):
2135         * Scripts/webkitpy/tool/bot/irc_command.py:
2136         (IRCCommand.execute):
2137         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2138         (SheriffIRCBotTest.test_help):
2139         * Scripts/webkitpy/tool/commands/queries.py:
2140         (PatchesToReview.execute):
2141
2142 2012-03-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2143
2144         [Qt] Make gccdepends test aware of broken icecream deps generation
2145
2146         Icecream seems to build the files without passing -o to gcc with
2147         the original destination path, which means the target name in the
2148         dependency file is wrong.
2149
2150         Also, echo something to the final file instead of just touching it,
2151         so it's not deleted on every build.
2152
2153         Reviewed by Simon Hausmann.
2154
2155         * qmake/config.tests/gccdepends/gccdepends.pro:
2156
2157 2012-03-16  Kihong Kwon  <kihong.kwon@samsung.com>
2158
2159         Support for Battery Status API
2160         https://bugs.webkit.org/show_bug.cgi?id=62698
2161
2162         Add include directory and file.
2163         http://www.w3.org/TR/battery-status/
2164
2165         Reviewed by Adam Barth.
2166
2167         * Scripts/build-webkit:
2168
2169 2012-03-16  Kishore Bolisetty  <kbolisetty@innominds.com>
2170
2171         check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
2172         https://bugs.webkit.org/show_bug.cgi?id=81007
2173
2174         Reviewed by Adam Barth.
2175
2176         A dedidcated build slave is available for efl on build.webkit.org. 
2177         This change add's an entry for the elf port in list of available port builders.
2178         This is required because test_expectations.py when triggered, looks for a valid port object for the specified port. 
2179
2180         * Scripts/webkitpy/layout_tests/port/builders.py:
2181
2182 2012-03-16  Adam Barth  <abarth@webkit.org>
2183
2184         [webkitpy] StatusServer.next_work_item has an incorrectly named local variable
2185         https://bugs.webkit.org/show_bug.cgi?id=81302
2186
2187         Reviewed by Eric Seidel.
2188
2189         This is a trivial patch, but the variable name turned up in a grep of
2190         webkitpy and looks like copy pasta.
2191
2192         * Scripts/webkitpy/common/net/statusserver.py:
2193         (StatusServer.next_work_item):
2194
2195 2012-03-16  Andrew Lo  <anlo@rim.com>
2196
2197         [BlackBerry] Enable PAGE_VISIBILITY_API
2198         https://bugs.webkit.org/show_bug.cgi?id=81257
2199
2200         Enable Page Visibility API for BlackBerry.
2201
2202         Reviewed by Rob Buis.
2203
2204         * Scripts/build-webkit:
2205
2206 2012-03-16  Zan Dobersek  <zandobersek@gmail.com>
2207
2208         [Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
2209         https://bugs.webkit.org/show_bug.cgi?id=81232
2210
2211         Reviewed by Philippe Normand.
2212
2213         Use the newly-added helper method in DumpRenderTreeSupportGtk.
2214
2215         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2216         (LayoutTestController::computedStyleIncludingVisitedInfo):
2217
2218 2012-03-15  Eric Seidel  <eric@webkit.org>
2219
2220         Move parse_bug_id into config/urls in preparation for re-use elsewhere.
2221         https://bugs.webkit.org/show_bug.cgi?id=81313
2222
2223         Reviewed by Adam Barth.
2224
2225         * Scripts/webkitpy/common/checkout/changelog.py:
2226         (parse_bug_id_from_changelog):
2227         * Scripts/webkitpy/common/config/urls.py:
2228         (parse_bug_id):
2229         * Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py.
2230         (URLsTest):
2231         (URLsTest.test_parse_bug_id):
2232         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2233         (test_parse_bug_id):
2234         * Scripts/webkitpy/tool/bot/irc_command.py:
2235         (_post_error_and_check_for_bug_url):
2236         * Scripts/webkitpy/tool/bot/sheriff.py:
2237         (Sheriff.post_rollout_patch):
2238         (Sheriff.post_chromium_deps_roll):
2239
2240 2012-03-15  Adam Barth  <abarth@webkit.org>
2241
2242         The commit-queue should fast-track patches that have already passed the testing EWS bots
2243         https://bugs.webkit.org/show_bug.cgi?id=81305
2244
2245         Reviewed by Eric Seidel.
2246
2247         If a patch has already passed the testing EWS bots (currently only the
2248         chromium-ews bot), we should be able to land the patch without running
2249         the tests again.  This patch is somewhat risky in that the tests might
2250         have been broken between when the EWS bots ran and when the
2251         commit-queue is processing the patch.  If that turns out to be a
2252         problem in practice, we'll tighten up this fast-track in some way,
2253         likely by making sure that the pass status is recent.
2254
2255         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2256         (CommitQueueTaskDelegate.did_pass_testing_ews):
2257         (CommitQueueTask._did_pass_tests_recently):
2258         (CommitQueueTask.run):
2259         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2260         (MockCommitQueue.did_pass_testing_ews):
2261         (test_fast_success_case):
2262         * Scripts/webkitpy/tool/commands/queues.py:
2263         (CommitQueue.did_pass_testing_ews):
2264         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2265         (test_did_pass_testing_ews):
2266
2267 2012-03-15  Kentaro Hara  <haraken@chromium.org>
2268
2269         [PerformanceTests] run-perf-tests should output correct units
2270         https://bugs.webkit.org/show_bug.cgi?id=78303
2271
2272         Reviewed by Ryosuke Niwa.
2273
2274         Previously run-perf-tests just supported "ms" for units.
2275         Consequently, Dromaeo perf tests had been reporting runs/s as "ms".
2276         This patch fixes run-perf-tests so that they can support custom units.
2277         The default unit is "ms".
2278
2279         The test result looks like this:
2280
2281         $ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html
2282         RESULT Dromaeo: dom-attr= 6465.9525483 runs/s
2283         median= 0.0 runs/s, stdev= 24.2983433436 runs/s, min= 6435.87649402 runs/s, max= 6515.63693392 runs/s
2284
2285         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2286         (PerfTestsRunner._process_parser_test_result):
2287
2288 2012-03-15  Brent Fulgham  <bfulgham@webkit.org>
2289
2290         [WinCairo] Unreviewed build change after wtf path changes.
2291
2292         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include
2293         directories to look at the private header directory to find 'wtf'.
2294
2295 2012-03-15  Kent Tamura  <tkent@chromium.org>
2296
2297         REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
2298         https://bugs.webkit.org/show_bug.cgi?id=81293
2299
2300         Reviewed by Adam Barth.
2301
2302         r110595 introduced new format of the author field of ChangeLog entry:
2303         "Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>"
2304         Updte chanelog.py to support it.
2305
2306         * Scripts/webkitpy/common/checkout/changelog.py:
2307         (ChangeLogEntry._split_contributor_names):
2308         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2309         (test_parse_authors):
2310
2311 2012-03-15  Lynn Neir  <lynn.neir@skype.net>
2312
2313         Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834
2314
2315         Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.
2316
2317         Reviewed by Jessie Berlin.
2318
2319         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2320         (LayoutTestController::setValueForUser):
2321         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2322         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2323         (WTR::LayoutTestController::setValueForUser):
2324         (WTR):
2325         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2326         (LayoutTestController):
2327
2328 2012-03-15  Adam Barth  <abarth@webkit.org>
2329
2330         Update the start-queue.sh script to match what we're using on the bots
2331         https://bugs.webkit.org/show_bug.cgi?id=81277
2332
2333         Reviewed by Eric Seidel.
2334
2335         Over time we've added more magic git commands to clean up the local repo after
2336         it has been borked in various ways. The idea behind this sequence is to clear
2337         out any changes in the working copy and then to rebuild the master branch from
2338         origin/master.
2339
2340         This patch also removes the watchdog timer that we've stopped using on the
2341         bots.
2342
2343         This patch was reviewed on <https://github.com/eseidel/webkit/pull/1>.
2344         Note: Eric and I are experimenting with GitHub to see if it might be
2345         useful for WebKit.  If you have thoughts on this topic, please feel
2346         free to grab Eric or me on #webkit to chat.  I assume that he and I are
2347         the only ones who care about this file so using this alternative
2348         process for this patch shouldn't cause any trouble.
2349
2350         * EWSTools/start-queue.sh:
2351
2352 2012-03-15  Adam Barth  <abarth@webkit.org>
2353
2354         The commit-queue can hang when the test_expectations.txt style check fails during commit
2355         https://bugs.webkit.org/show_bug.cgi?id=81251
2356
2357         Reviewed by Eric Seidel.
2358
2359         We forgot to check the --non-interactive flag, so we end up prompting
2360         the "user" who doesn't exist on the bot.  We might consider teaching
2361         the User class about non-interactive if we have this sort of bug again.
2362
2363         * Scripts/webkitpy/tool/steps/commit.py:
2364         (Commit.options):
2365         (Commit._check_test_expectations):
2366         (Commit.run):
2367         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2368         (CommitTest.test_check_test_expectations):
2369
2370 2012-03-15  Jessie Berlin  <jberlin@apple.com>
2371
2372         fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on
2373         Mac WK2 because WebAudio is not enabled
2374         https://bugs.webkit.org/show_bug.cgi?id=81259
2375
2376         Reviewed by Dan Bernstein.
2377
2378         Enable WebAudio so that it appears in the window object in the tests.
2379         The webaudio tests are all still skipped in the Mac Skipped list.
2380
2381         * WebKitTestRunner/TestController.cpp:
2382         (WTR::TestController::resetStateToConsistentValues):
2383
2384 2012-03-15  David Levin  <levin@chromium.org>
2385
2386         Various autoresize fixes.
2387         https://bugs.webkit.org/show_bug.cgi?id=81199
2388
2389         Reviewed by Darin Fisher.
2390
2391         * DumpRenderTree/chromium/LayoutTestController.cpp:
2392         (LayoutTestController::reset): Stop using the deprecated api that was removed.
2393
2394 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2395
2396         [GTK] Actually use --release and --debug command line options in run-gtk-test
2397         https://bugs.webkit.org/show_bug.cgi?id=81234
2398
2399         Reviewed by Philippe Normand.
2400
2401         Actually handle --release and --debug command line options to
2402         create the build directory, falling back to current hack to detect
2403         whether it's a Release or Debug build when both options are missed.
2404
2405         * Scripts/run-gtk-tests:
2406         (TestRunner.__init__): Receive options too.
2407         (TestRunner._get_top_level_directory): Helper function to get the
2408         top level directory.
2409         (TestRunner._get_build_directory): Helper function to get the
2410         build directory depending on --release/--debug command line
2411         options or gessing it if both options are missing.
2412         (TestRunner._ensure_accessibility_daemon_is_running): Use
2413         self-options now.
2414         (TestRunner.run): Ditto.
2415         (TestRunner.run.run_tests): Pass options to the constructor
2416         instead of run().
2417
2418 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2419
2420         [GTK] Run unit tests with --verbose in the bots
2421         https://bugs.webkit.org/show_bug.cgi?id=81230
2422
2423         Reviewed by Martin Robinson.
2424
2425         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2426         (RunGtkAPITests): Add --verbose to run-gtk-test command.
2427
2428 2012-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2429
2430         Move wx port to using export macros
2431         https://bugs.webkit.org/show_bug.cgi?id=77279
2432
2433         Reviewed by Hajime Morita.
2434
2435         * waf/build/settings.py:
2436         (common_configure):
2437
2438 2012-03-15  Philippe Normand  <pnormand@igalia.com>
2439
2440         Unreviewed, GTK build fix attempt after r110845.
2441
2442         * Scripts/run-gtk-tests: Added --release and --debug options.
2443
2444 2012-03-15  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2445
2446         Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
2447         https://bugs.webkit.org/show_bug.cgi?id=79673
2448
2449         Preparatory work for bringing jhbuild enabled build to EFL port.
2450
2451         Reviewed by Philippe Normand.
2452
2453         * Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
2454         * Scripts/update-webkitgtk-libs:
2455         * gtk/run-with-jhbuild:
2456         * jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.
2457         (top_level_path):
2458         (jhbuild_installed):
2459         (jhbuild_cloned):
2460         (jhbuild_at_expected_revision):
2461         (update_jhbuild):
2462         (clone_jhbuild):
2463         (install_jhbuild):
2464         (update_webkit_libs_jhbuild):
2465         (determine_platform):
2466         (ensure_jhbuild):
2467
2468 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2469
2470         [GTK] Add command line options to run-gtk-tests script
2471         https://bugs.webkit.org/show_bug.cgi?id=81218
2472
2473         Reviewed by Philippe Normand.
2474
2475         Following command line options have been added:
2476
2477         -v, --verbose: to run gtester with --verbose. That would be used
2478         by the bots to make it easier to know which test case it failing.
2479
2480         --display: to use a different display for Xvfb
2481
2482         It's also possible to pass one or more tests as arguments.
2483
2484         * Scripts/run-gtk-tests:
2485         (TestRunner.__init__): Receive command line arguments.
2486         (TestRunner._get_tests): Get all the tests or the ones passed by
2487         command line arguments.
2488         (TestRunner._ensure_accessibility_daemon_is_running): Use display
2489         command line argument.
2490         (TestRunner.run): Pas command line options.
2491         (TestRunner.run.run_tests): Pass command line arguments.
2492
2493 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2494
2495         [GTK] WebKit2APITests/TestPrinting timeout in the bots
2496         https://bugs.webkit.org/show_bug.cgi?id=81211
2497
2498         Reviewed by Philippe Normand.
2499
2500         Add gtk+ patch to fix timeout in the bots. A similar patch has
2501         already landed in updatream gtk+, see
2502         http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f
2503
2504         * gtk/jhbuild.modules:
2505         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.
2506
2507 2012-03-14  Gustavo Noronha Silva  <gns@gnome.org>
2508
2509         sheriffbot should also be addressable with a comma in addition to colon
2510         https://bugs.webkit.org/show_bug.cgi?id=81101
2511
2512         Reviewed by Adam Barth.
2513
2514         * Scripts/webkitpy/common/net/irc/ircbot.py:
2515         (IRCBot.on_pubmsg):
2516
2517 2012-03-15  Alexander Færøy  <alexander.faeroy@nokia.com>
2518
2519         [Qt] MiniBrowser scroll indicators should not scroll out of view
2520         https://bugs.webkit.org/show_bug.cgi?id=81131
2521
2522         Reviewed by Kenneth Rohde Christiansen.
2523
2524         * MiniBrowser/qt/qml/ScrollIndicator.qml:
2525
2526 2012-03-14  Chris Fleizach  <cfleizach@apple.com>
2527
2528         AX: ARIA tables need to support selected rows attribute/select rows changed notification
2529         https://bugs.webkit.org/show_bug.cgi?id=79821
2530
2531         Reviewed by Beth Dakin.
2532
2533         * DumpRenderTree/AccessibilityUIElement.cpp:
2534         (rowAtIndexCallback):
2535         (AccessibilityUIElement::getJSClass):
2536         * DumpRenderTree/AccessibilityUIElement.h:
2537         (AccessibilityUIElement):
2538         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2539         (AccessibilityUIElement::rowAtIndex):
2540         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2541         (AccessibilityUIElement::rowAtIndex):
2542         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2543         (AccessibilityUIElement::rowAtIndex):
2544         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2545         (AccessibilityUIElement::rowAtIndex):
2546
2547 2012-03-14  Tim Horton  <timothy_horton@apple.com>
2548
2549         NRWT should respect --additional-platform-directory's Skipped list
2550         https://bugs.webkit.org/show_bug.cgi?id=81172
2551
2552         Reviewed by Timothy Hatcher.
2553
2554         Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
2555         from said path are already used, but the Skipped file is ignored.
2556
2557         * Scripts/webkitpy/layout_tests/port/webkit.py:
2558         (WebKitPort._skipped_file_search_paths):
2559         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2560         (test_skipped_file_search_paths):
2561
2562 2012-03-14  Ojan Vafai  <ojan@chromium.org>
2563
2564         Unreviewed, rolling out r110783.
2565         http://trac.webkit.org/changeset/110783
2566         https://bugs.webkit.org/show_bug.cgi?id=81054
2567
2568         Caused existing test expectation lines to expand to one for
2569         each test configuration.
2570
2571         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2572         (TestExpectations.has_warnings):
2573         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2574         (test_macro_overrides):
2575         * Scripts/webkitpy/tool/commands/rebaseline.py:
2576         (RebaselineTest._save_baseline):
2577         (RebaselineTest._rebaseline_test):
2578         (RebaselineTest.execute):
2579         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2580         (TestRebaseline.test_tests_to_update):
2581
2582 2012-03-13  Jon Lee  <jonlee@apple.com>
2583
2584         Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
2585         https://bugs.webkit.org/show_bug.cgi?id=80922
2586         <rdar://problem/11035082>
2587
2588         Reviewed by Jian Li.
2589
2590         You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
2591         LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
2592         new API. Therefore, APIs that are common between the two will have:
2593         #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
2594
2595         This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
2596         the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
2597
2598         Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
2599         * DumpRenderTree/chromium/LayoutTestController.cpp:
2600         (LayoutTestController::grantDesktopNotificationPermission):
2601         (LayoutTestController::simulateDesktopNotificationClick):
2602         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2603         * DumpRenderTree/chromium/TestShell.cpp:
2604         (TestShell::TestShell):
2605         (TestShell::resetTestController):
2606         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2607         (DRTDesktopNotificationPresenter::checkNotificationPermission):
2608
2609 2012-03-13  Ojan Vafai  <ojan@chromium.org>
2610
2611         Have webkit-patch rebaseline-test update test_expectations.txt
2612         https://bugs.webkit.org/show_bug.cgi?id=81054
2613
2614         Reviewed by Dirk Pranke.
2615
2616         This will allow us to use the All Failures tab in garden-o-matic
2617         to rebaseline tests without making test_expectations.txt stale.
2618
2619         It's conservative and only removes lines if the test is
2620         not flaky and fails in a way the rebaseline would fix (e.g.
2621         CRASH/TIMEOUT will not be touched).
2622
2623         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2624         (TestExpectations.remove_configuration_from_test):
2625         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2626         (RemoveConfigurationsTest):
2627         (RemoveConfigurationsTest.test_remove):
2628         (test_remove_line):
2629         * Scripts/webkitpy/tool/commands/rebaseline.py:
2630         (RebaselineTest._is_supported_port):
2631         (RebaselineTest):
2632         (RebaselineTest._update_expectations_file):
2633         (RebaselineTest._rebaseline_test_and_update_expectations):
2634         (RebaselineTest.execute):
2635         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2636         (TestRebaseline.test_rebaseline_updates_expectations_file):
2637
2638 2012-03-14  Jessie Berlin  <jberlin@apple.com>
2639
2640         Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
2641         https://bugs.webkit.org/show_bug.cgi?id=81167
2642
2643         Reviewed by Sam Weinig.
2644
2645         Do not use 0 as a key in a HashMap.
2646
2647         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2648         cacheLayoutTestControllerCallback uses the enum as keys for the callback map.
2649
2650 2012-03-14  Ojan Vafai  <ojan@chromium.org>
2651
2652         Add the chromium lion bot to garden-o-matic and remove
2653         the platform_move_to in builders.py since the Chromium Lion
2654         port is now a normal port.
2655
2656         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2657         * Scripts/webkitpy/layout_tests/port/builders.py:
2658
2659 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
2660
2661         Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.
2662
2663         Unreviewed, build fix.
2664
2665         * Scripts/webkitpy/layout_tests/port/base.py:
2666         (Port.skipped_tests):
2667
2668 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
2669
2670         Please add a way to manually skip some tests in NRWT
2671         https://bugs.webkit.org/show_bug.cgi?id=81019
2672
2673         Reviewed by Ojan Vafai.
2674
2675         This patch implements the -i / --ignore-tests flag from ORWT
2676         and refactors the test_expectations.py code slightly to handle
2677         it.
2678
2679         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2680         (Manager.parse_expectations):
2681         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2682         (TestExpectations.__init__):
2683         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2684         (test_add_skipped_tests):
2685         (test_add_skipped_tests_duplicate):
2686         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2687         (parse_args):
2688         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2689         (MainTest.test_ignore_tests):
2690         (MainTest.test_ignore_tests.assert_ignored):
2691
2692 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
2693
2694         nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
2695         https://bugs.webkit.org/show_bug.cgi?id=81028
2696
2697         Reviewed by Ojan Vafai.
2698
2699         The mac port had incorrect lookups for 'mac-lion' and
2700         'mac-future' in some places. This patch fixes that and adds a
2701         bunch of tests.
2702
2703         * Scripts/webkitpy/layout_tests/port/mac.py:
2704         (MacPort.baseline_path):
2705         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2706         (MacTest.assert_skipped_file_search_paths):
2707         (MacTest.test_skipped_file_search_paths):
2708         (_assert_search_path):
2709         (test_baseline_search_path):
2710         * Scripts/webkitpy/layout_tests/port/webkit.py:
2711         (WebKitPort._skipped_file_search_paths):
2712
2713 2012-03-13  Jer Noble  <jer.noble@apple.com>
2714
2715         Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
2716         https://bugs.webkit.org/show_bug.cgi?id=81056
2717
2718         Reviewed by Jessie Berlin.
2719
2720         Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).
2721
2722         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2723         (WTR::InjectedBundlePage::InjectedBundlePage):
2724         (WTR::InjectedBundlePage::beganEnterFullScreen):
2725         (WTR::InjectedBundlePage::beganExitFullScreen):
2726
2727 2012-03-14  Alexander Færøy  <alexander.faeroy@nokia.com>
2728
2729         The width and height of the scroll indicators in the MiniBrowser does
2730         not consider the offset margins.
2731         https://bugs.webkit.org/show_bug.cgi?id=81112
2732
2733         Reviewed by Kenneth Rohde Christiansen.
2734
2735         This patch fixes the issue by withdrawing two times the anchor
2736         margins.
2737
2738         * MiniBrowser/qt/qml/ScrollIndicator.qml:
2739
2740 2012-03-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2741
2742         [EFL] Implement LayoutTestController::clearBackForwardList
2743         https://bugs.webkit.org/show_bug.cgi?id=80142
2744
2745         Adding missing implementation clearBackForwardList to EFL's
2746         LayoutTestController. This implementation allows us to unskip 
2747         tests connected with history.
2748
2749         Reviewed by Antonio Gomes.
2750
2751         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2752         (LayoutTestController::clearBackForwardList): Implemented.
2753
2754 2012-03-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2755
2756         [EFL][DRT] Expose window.internals object
2757         https://bugs.webkit.org/show_bug.cgi?id=79900
2758
2759         Exposes window.internals for EFL's DRT. Makes possible to
2760         remove some tests from the skip list.
2761
2762         Reviewed by Antonio Gomes.
2763
2764         * DumpRenderTree/efl/CMakeLists.txt:
2765         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2766         (DumpRenderTreeChrome::onWindowObjectCleared):
2767
2768 2012-03-13  Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>
2769
2770         Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
2771         https://bugs.webkit.org/show_bug.cgi?id=78853
2772
2773         Reviewed by Adam Barth.
2774
2775         * Scripts/build-webkit:
2776         * qmake/mkspecs/features/features.prf:
2777
2778 2012-03-12  Antonio Gomes  <agomes@rim.com>
2779
2780         Convert nodesFromRect tests to use Internals interface
2781         https://bugs.webkit.org/show_bug.cgi?id=80886
2782
2783         Reviewed by Ryosuke Niwa.
2784
2785         This clean up allows to remove port specific bits of each
2786         DRT implementation that supports testing Document::nodesFromRect,
2787         in favor of making use of the 'Internals' interface to test it.
2788
2789         This makes its code conveniently more expansible and cleaner.
2790
2791         Also removed stubs from Win and EFL DRTs.
2792
2793         * DumpRenderTree/LayoutTestController.cpp:
2794         (LayoutTestController::staticFunctions):
2795         * DumpRenderTree/LayoutTestController.h:
2796         (LayoutTestController):
2797         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2798         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2799         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2800         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2801         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2802         (LayoutTestController):
2803         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2804
2805 2012-03-13  Ojan Vafai  <ojan@chromium.org>
2806
2807         Rebaselining for a new port doesn't work right with multiple fallback ports
2808         https://bugs.webkit.org/show_bug.cgi?id=80932
2809
2810         Reviewed by Adam Barth.
2811
2812         Since chromium-leopard also falls back to mac-leopard, we need to
2813         copy the existing result for both chromium-leopard and chromium-snowleopard
2814         before doing lion rebaselines.
2815
2816         * Scripts/webkitpy/layout_tests/port/builders.py:
2817         (fallback_port_names_for_new_port):
2818         * Scripts/webkitpy/tool/commands/rebaseline.py:
2819         (RebaselineTest):
2820         (RebaselineTest._copy_existing_baseline):
2821         (RebaselineTest._rebaseline_test):
2822         (RebaselineTest.execute):
2823         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2824         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2825         (GardeningHTTPRequestHandler.rebaseline):
2826         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2827         (GardeningServerTest.test_rebaseline_new_port):
2828
2829 2012-03-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2830
2831         [Qt] Tweak minibrowser UI
2832
2833         Add some margins to the scroll indicators, and set a dark background
2834         color so you see the page dimensions.
2835
2836         Reviewed by Antonio Gomes.
2837
2838         * MiniBrowser/qt/qml/BrowserWindow.qml:
2839         * MiniBrowser/qt/qml/ScrollIndicator.qml:
2840
2841 2012-03-13  ChangSeok Oh  <shivamidow@gmail.com>
2842
2843         [EFL] [DRT] Implement scheduleAsynchronousKeyDown.
2844         https://bugs.webkit.org/show_bug.cgi?id=79601
2845
2846         Reviewed by Gustavo Noronha Silva.
2847
2848         Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
2849         createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
2850         and is taken over to sendKeyDown.
2851         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
2852         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
2853
2854         * DumpRenderTree/efl/EventSender.cpp:
2855         (KeyEventInfo::KeyEventInfo):
2856         (KeyEventInfo):
2857         (createKeyEventInfo):
2858         (sendKeyDown):
2859         (keyDownCallback):
2860         (sendAsynchronousKeyDown):
2861         (scheduleAsynchronousKeyDownCallback):
2862
2863 2012-03-12  Ojan Vafai  <ojan@chromium.org>
2864
2865         webkit-patch optimize-baselines sometimes creates a mac-future result
2866         https://bugs.webkit.org/show_bug.cgi?id=80717
2867
2868         Reviewed by Adam Barth.
2869
2870         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2871         (_baseline_search_hypergraph):
2872         (BaselineOptimizer._find_optimal_result_placement):
2873         (BaselineOptimizer._filter_virtual_ports):
2874         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2875         (BaselineOptimizerTest.test_no_add_mac_future):
2876
2877 2012-03-12  Jessie Berlin  <jberlin@apple.com>
2878
2879         More Windows build fixing.
2880
2881         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2882
2883 2012-03-12  Jessie Berlin  <jberlin@apple.com>
2884
2885         More Windows build fixing.
2886
2887         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2888         * DumpRenderTree/win/EditingDelegate.cpp:
2889         * DumpRenderTree/win/EventSender.cpp:
2890         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2891         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2892         * DumpRenderTree/win/UIDelegate.cpp:
2893
2894 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2895
2896         remove the 'gpu' group from the flakiness dashboard
2897         https://bugs.webkit.org/show_bug.cgi?id=80353
2898
2899         Reviewed by Adam Barth.
2900
2901         Since those bots are obsolete, we don't need this any more.
2902
2903         * TestResultServer/static-dashboards/builders.js:
2904         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2905         (testPlatformAndBuildType):
2906         (testHtmlForTestTypeSwitcherGroup):
2907
2908 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2909
2910         remove graphics_type from webkitpy.layout_tests.models.test_configuration
2911         https://bugs.webkit.org/show_bug.cgi?id=80643
2912
2913         Reviewed by Ojan Vafai.
2914
2915         Now that the chromium-gpu ports are gone, there's no need for
2916         the graphics_type CPU/GPU distinction. Most of this change is
2917         just updating tests accordingly.
2918
2919         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2920         (TestExpectationEditorTests):
2921         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2922         (TestConfiguration.__init__):
2923         (TestConfiguration.category_order):
2924         (TestConfiguration.__str__):
2925         (TestConfiguration.__repr__):
2926         (TestConfiguration.__hash__):
2927         (TestConfigurationConverter.to_specifiers_list):
2928         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2929         (make_mock_all_test_configurations_set):
2930         (TestConfigurationTest.test_items):
2931         (TestConfigurationTest.test_keys):
2932         (TestConfigurationTest.test_str):
2933         (TestConfigurationTest.test_repr):
2934         (TestConfigurationTest.test_hash):
2935         (TestConfigurationTest.test_hash.query_unknown_key):
2936         (TestConfigurationTest.test_eq):
2937         (TestConfigurationTest.test_values):
2938         (SpecifierSorterTest.test_specifier_priority):
2939         (SpecifierSorterTest.test_sort_specifiers):
2940         (TestConfigurationConverterTest.test_to_config_set):
2941         (TestConfigurationConverterTest.test_macro_expansion):
2942         (TestConfigurationConverterTest.test_to_specifier_lists):
2943         (TestConfigurationConverterTest.test_converter_macro_collapsing):
2944         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2945         (test_error_on_different_build_type):
2946         (TestExpectationSerializerTests.test_parsed_to_string):
2947         (TestExpectationSerializerTests.test_reconstitute_only_these):
2948         * Scripts/webkitpy/layout_tests/port/apple.py:
2949         (ApplePort._generate_all_test_configurations):
2950         * Scripts/webkitpy/layout_tests/port/base.py:
2951         (Port.__init__):
2952         (Port.name):
2953         (Port.version):
2954         (Port.test_configuration):
2955         * Scripts/webkitpy/layout_tests/port/builders.py:
2956         * Scripts/webkitpy/layout_tests/port/chromium.py:
2957         (ChromiumPort):
2958         (ChromiumPort._generate_all_test_configurations):
2959         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2960         (ChromiumLinuxPort.__init__):
2961         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2962         (ChromiumLinuxPortTest.test_check_illegal_port_names):
2963         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2964         (ChromiumMacPortTest.test_baseline_path):
2965         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2966         (ChromiumPortTest.test_all_test_configurations):
2967         * Scripts/webkitpy/layout_tests/port/efl.py:
2968         (EflPort._generate_all_test_configurations):
2969         * Scripts/webkitpy/layout_tests/port/gtk.py:
2970         (GtkPort._generate_all_test_configurations):
2971         * Scripts/webkitpy/layout_tests/port/qt.py:
2972         (QtPort._generate_all_test_configurations):
2973         * Scripts/webkitpy/layout_tests/port/test.py:
2974         (TestPort.all_test_configurations):
2975         (TestPort._all_build_types):
2976         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2977         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2978         (BuildCoverageExtrapolatorTest.test_extrapolate):
2979         (GardeningExpectationsUpdaterTest.test_unknown_failure_type):
2980         (GardeningExpectationsUpdaterTest.test_add_new_expectation):
2981         (GardeningExpectationsUpdaterTest.test_replace_old_expectation):
2982         (GardeningExpectationsUpdaterTest.test_pass_expectation):
2983         (GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
2984         (GardeningExpectationsUpdaterTest.test_spurious_updates):
2985
2986 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2987
2988         _runtime_feature_list isn't supported on Apple Mac DRT
2989         https://bugs.webkit.org/show_bug.cgi?id=80906
2990
2991         Reviewed by Eric Seidel.
2992
2993         It looks like this feature is actually only supported on the Win
2994         DRT port, so this patch reworks the code to make that clearer
2995         and reduce unnecessary overrides.
2996
2997         * Scripts/webkitpy/layout_tests/port/efl.py:
2998         (EflPort._path_to_webcore_library):
2999         * Scripts/webkitpy/layout_tests/port/gtk.py:
3000         (GtkPort._path_to_webcore_library):
3001         * Scripts/webkitpy/layout_tests/port/qt.py:
3002         (QtPort._skipped_file_search_paths):
3003         * Scripts/webkitpy/layout_tests/port/webkit.py:
3004         (WebKitPort._runtime_feature_list):
3005         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3006         (TestWebKitPort.__init__):
3007         (TestWebKitPort.all_test_configurations):
3008         (test_skipped_directories_for_features):
3009         * Scripts/webkitpy/layout_tests/port/win.py:
3010         (WinPort):
3011         (WinPort._runtime_feature_list):
3012         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3013         (WinPortTest.test_operating_system):
3014         (WinPortTest):
3015         (WinPortTest.test_runtime_feature_list):
3016
3017 2012-03-12  Peter Beverloo  <peter@chromium.org>
3018
3019         [Chromium] Temporary build-fix for the Android bot
3020         https://bugs.webkit.org/show_bug.cgi?id=80862
3021
3022         Reviewed by Adam Barth.
3023
3024         Manually set the environmental variables required to compile source
3025         files through the Android NDK instead of relying on the envsetup.sh
3026         script. A proper fix will be landed to Chromium ASAP, and following
3027         a Chromium roll into WebKit this code will be removed.
3028
3029         * Scripts/webkitdirs.pm:
3030         (buildChromiumMakefile):
3031
3032 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3033
3034         [Qt] Use right construct to detect config_test_gccdepends
3035
3036         Reviewed by Andreas Kling.
3037
3038         * qmake/mkspecs/features/default_pre.prf:
3039
3040 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3041
3042         [Qt] Expose location of WebKit's bin and imports dir through module file
3043
3044         Reviewed by Andreas Kling.
3045
3046         * qmake/qt_webkit.pri:
3047
3048 2012-03-12  Andras Becsi  <andras.becsi@nokia.com>
3049
3050         [Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
3051         https://bugs.webkit.org/show_bug.cgi?id=80832
3052
3053         Reviewed by Tor Arne Vestbø.
3054
3055         Add a basic scroll indicator component to MiniBrowser so that it
3056         behaves similar to the ScrollDecorator QML component.
3057
3058         * MiniBrowser/qt/MiniBrowser.qrc:
3059         * MiniBrowser/qt/qml/BrowserWindow.qml:
3060         * MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
3061
3062 2012-03-12  C Anthony Risinger  <anthony@xtfx.me>
3063
3064         [GTK] r110296 included an extra $ in @$(AM_V_GEN)
3065         https://bugs.webkit.org/show_bug.cgi?id=80809
3066
3067         Reviewed by Philippe Normand.
3068
3069         * GNUmakefile.am: Add `$` to @(AM_V_GEN), else /bin/sh syntax error
3070
3071 2012-03-12  Ming Xie  <mxie@rim.com>
3072
3073         [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
3074         https://bugs.webkit.org/show_bug.cgi?id=80812
3075
3076         Reviewed by Rob Buis.
3077
3078         * Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
3079         * Scripts/webkitdirs.pm:
3080         (blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define
3081
3082
3083 2012-03-12  Simon Hausmann  <simon.hausmann@nokia.com>
3084
3085         [Qt] Fix build with newer Qt 5.
3086
3087         Reviewed by Tor Arne Vestbø.
3088
3089         Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
3090         renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
3091         we should disable -Werror.
3092
3093         Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
3094         implicit load was removed recently.
3095
3096         * qmake/mkspecs/features/default_pre.prf:
3097         * qmake/mkspecs/features/unix/default_post.prf:
3098
3099 2012-03-11  Maciej Stachowiak  <mjs@apple.com>
3100
3101         Add --instruments option to sunspider to profile with Instruments
3102         https://bugs.webkit.org/show_bug.cgi?id=80783
3103
3104         Reviewed by Filip Pizlo.
3105
3106         * Scripts/run-sunspider:
3107
3108 2012-03-11  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3109
3110         [Qt] [WK2] Support threaded renderer in WK2
3111         https://bugs.webkit.org/show_bug.cgi?id=76661
3112
3113         Remove disabling of threaded rendering.
3114
3115         Reviewed by Noam Rosenthal.
3116
3117         * MiniBrowser/qt/main.cpp:
3118         (main):
3119
3120 2012-03-09  Zan Dobersek  <zandobersek@gmail.com>
3121
3122         [WK2] run-perf-tests should be able to run with WTR
3123         https://bugs.webkit.org/show_bug.cgi?id=80042
3124
3125         Reviewed by Martin Robinson.
3126
3127         Add an option to PerfTestRunner to use WebKitTestRunner instead of
3128         DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
3129         to avoid timing out when running performance tests.
3130
3131         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3132         (PerfTestsRunner._parse_args):
3133         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3134         (WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
3135         to true.
3136         (WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
3137         as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.
3138         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3139         (WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
3140         publicly accessible.
3141         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3142         (WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
3143         is required.
3144         * WebKitTestRunner/TestController.cpp:
3145         (WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
3146         to true.
3147         (WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
3148         if '--no-timeout' option is present.
3149         (WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
3150         value, or -1.0 if timeout should not occur.
3151         * WebKitTestRunner/TestController.h:
3152         (WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
3153         publicly accessible.
3154         * WebKitTestRunner/TestInvocation.cpp:
3155         (WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
3156         containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
3157         Waiting for final message should not time out if not necessary.
3158         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3159         (WTR::TestController::platformRunUntil): Only set up a timeout if necessary.
3160         * WebKitTestRunner/qt/TestControllerQt.cpp:
3161         (WTR::TestController::platformRunUntil): Ditto.
3162         * WebKitTestRunner/mac/TestControllerMac.mm:
3163         (WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
3164         is missing.
3165         * WebKitTestRunner/win/TestControllerWin.cpp:
3166         (WTR::TestController::platformRunUntil): Ditto.
3167
3168 2012-03-09  Jon Lee  <jonlee@apple.com>
3169
3170         Rename NotificationPresenter to NotificationClient
3171         https://bugs.webkit.org/show_bug.cgi?id=80488
3172         <rdar://problem/10965558>
3173
3174         Reviewed by Kentaro Hara.
3175
3176         Refactor to use renamed WebCore::NotificationClient.
3177         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3178         (DRTDesktopNotificationPresenter::checkNotificationPermission):
3179
3180 2012-03-07  James Robinson  <jamesr@chromium.org>
3181
3182         [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
3183         https://bugs.webkit.org/show_bug.cgi?id=80523
3184
3185         Reviewed by Darin Fisher.
3186
3187         * DumpRenderTree/chromium/WebViewHost.cpp:
3188         (WebViewHost::createGraphicsContext3D):
3189         * DumpRenderTree/chromium/WebViewHost.h:
3190         (WebViewHost):
3191
3192 2012-03-09  Eric Seidel  <eric@webkit.org>
3193
3194         build-webkit should build Source/WTF on Mac
3195         https://bugs.webkit.org/show_bug.cgi?id=80728
3196
3197         Reviewed by Adam Barth.
3198
3199         We'll add other ports to this list in future commits.
3200
3201         * Scripts/build-webkit:
3202
3203 2012-03-09  Jon Lee  <jonlee@apple.com>
3204
3205         Add support for ENABLE(LEGACY_NOTIFICATIONS)
3206         https://bugs.webkit.org/show_bug.cgi?id=80497
3207
3208         Reviewed by Adam Barth.
3209
3210         Prep for b80472: Update API for Web Notifications
3211         * Scripts/build-webkit:
3212         * qmake/mkspecs/features/features.prf:
3213
3214 2012-03-09  Ashod Nakashian  <ashodnakashian@yahoo.com>
3215
3216         Bash scripts should support LF endings only
3217         https://bugs.webkit.org/show_bug.cgi?id=79509
3218
3219         Reviewed by David Kilzer.
3220
3221         * EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
3222         * EWSTools/start-queue.sh: Added property svn:eol-style.
3223         * Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
3224         * WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
3225         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
3226         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.
3227
3228 2012-03-09  Ionut Biru  <ibiru@archlinux.org>
3229
3230         [BUILD] use detected python to run generate-gtkdoc
3231         https://bugs.webkit.org/show_bug.cgi?id=80695
3232
3233         Reviewed by Gustavo Noronha Silva.
3234
3235         * GNUmakefile.am: Use $(PYTHON) instead of plain `python`
3236
3237 2012-03-09  Nat Duca  <nduca@chromium.org>
3238
3239         Make check-webkit-style complain about "no new tests" lines in changelogs
3240         https://bugs.webkit.org/show_bug.cgi?id=80582
3241
3242         Reviewed by David Levin.
3243
3244         * Scripts/webkitpy/style/checkers/changelog.py:
3245         (ChangeLogChecker.check_entry):
3246         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3247         (ChangeLogCheckerTest.test_no_new_tests):
3248
3249 2012-03-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3250
3251         Unreviewed, rolling out r110250.
3252         http://trac.webkit.org/changeset/110250
3253         https://bugs.webkit.org/show_bug.cgi?id=80682
3254
3255         It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
3256         qt-linux at all. (Requested by Ossy on #webkit).
3257
3258         * Scripts/old-run-webkit-tests:
3259         * Scripts/webkitpy/layout_tests/port/qt.py:
3260         (QtPort):
3261         (QtPort.determine_full_port_name):
3262         (QtPort.baseline_search_path):
3263         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3264         (QtPortTest):
3265         (QtPortTest._assert_search_path):
3266         (QtPortTest.test_baseline_search_path):
3267
3268 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3269
3270         [Qt] Use Qt's module system for install rules and depending on QtWebKit
3271
3272         Instead of rolling our own install rules we now use the same approach as
3273         every other Qt module, by loading qt_module.prf and qt_module_config.prf.
3274
3275         This ensures that we follow the same semantics as the rest of Qt on
3276         what sort of config options are enabled by default (create_cmake eg.).
3277         It also allows us to use QT += webkit instead of the workaround we had
3278         with CONFIG += qtwebkit.
3279
3280         We do however force Qt to always treat our build as a non-developer build,
3281         so the libraries will end up in the WebKit lib directory instead of the
3282         qtbase directory (as with a normal developer-build). This allows us to
3283         keep the webkit-build self-contained. If Qt is a developer build we still
3284         copy the module file manually to Qt, so that you don't have to install
3285         WebKit to make it available.
3286
3287         For non-developer builds of Qt, it is still possible to use the built
3288         WebKit libraries without having to install them, by having the variable
3289         QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
3290         pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
3291
3292         https://bugs.webkit.org/show_bug.cgi?id=80590
3293
3294         Reviewed by Simon Hausmann.
3295
3296         * DumpRenderTree/qt/DumpRenderTree.pro:
3297         * MiniBrowser/qt/BrowserWindow.cpp:
3298         * MiniBrowser/qt/MiniBrowser.pro:
3299         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3300         * MiniBrowser/qt/UrlLoader.cpp:
3301         * QtTestBrowser/QtTestBrowser.pro:
3302         * Tools.pro:
3303         * WebKitTestRunner/InjectedBundle/Target.pri:
3304         * WebKitTestRunner/Target.pri:
3305         * qmake/mkspecs/features/default_post.prf:
3306         * qmake/mkspecs/features/default_pre.prf:
3307         * qmake/mkspecs/features/functions.prf:
3308         * qmake/mkspecs/features/qtwebkit-private.prf: Removed.
3309         * qmake/mkspecs/features/qtwebkit.prf:
3310         * qmake/mkspecs/features/rpath.prf:
3311         * qmake/mkspecs/modules/qt_webkit.pri: Removed.
3312         * qmake/qt_webkit.pri: Added.
3313
3314 2012-03-08  Igor Oliveira  <igor.o@sisa.samsung.com>
3315
3316         Unreviewed. Update my email.
3317
3318         * Scripts/webkitpy/common/config/committers.py:
3319
3320 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
3321
3322         Recent changes to chromium.py etc. broke chromium_android.py
3323         https://bugs.webkit.org/show_bug.cgi?id=80623
3324
3325         Reviewed by Dirk Pranke.
3326
3327         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3328         (ChromiumAndroidDriver.__init__):
3329         (ChromiumAndroidDriver._start):
3330
3331 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
3332
3333         [Chromium] Exception running reftest with --no-pixel-tests
3334         https://bugs.webkit.org/show_bug.cgi?id=80642
3335
3336         Reviewed by Dirk Pranke.
3337
3338         * Scripts/webkitpy/layout_tests/port/chromium.py:
3339         (ChromiumDriver.__init__):
3340         (ChromiumDriver._wrapper_options):
3341
3342 2012-03-08  Rafael Brandao  <rafael.lobo@openbossa.org>
3343
3344         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
3345         https://bugs.webkit.org/show_bug.cgi?id=72489
3346
3347         Reviewed by Dirk Pranke.
3348
3349         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
3350         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
3351         --platform will override the platform name and then we'll use it.
3352
3353         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
3354         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
3355         override it in the end.
3356
3357         * Scripts/old-run-webkit-tests:
3358         * Scripts/webkitpy/layout_tests/port/qt.py:
3359         (QtPort):
3360         (QtPort.determine_full_port_name):
3361         (QtPort.baseline_search_path):
3362         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3363         (QtPortTest):
3364         (QtPortTest._assert_search_path):
3365         (QtPortTest.test_baseline_search_path):
3366
3367 2012-03-08  Beth Dakin  <bdakin@apple.com>
3368
3369         https://bugs.webkit.org/show_bug.cgi?id=80463
3370         RenderImage is using the wrong origin when calling addRelevantRepaintedObject
3371         -and corresponding-
3372         <rdar://problem/10970221>
3373
3374         Reviewed by Dan Bernstein.
3375
3376         New test!
3377         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3378         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
3379         (TestWebKitAPI):
3380         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3381         (TestWebKitAPI::setPageLoaderClient):
3382         (TestWebKitAPI::TEST):
3383         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
3384         (TestWebKitAPI):
3385         (NewFirstVisuallyNonEmptyLayoutForImagesTest):
3386         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
3387         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
3388         * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
3389
3390 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3391
3392         [Qt] Prospective Windows build fix
3393
3394         Don't assume that windows-builds will always run inside a cmd.exe shell.
3395
3396         * qmake/mkspecs/features/default_pre.prf:
3397
3398 2012-03-08  Dan Bernstein  <mitz@apple.com>
3399
3400         <rdar://problem/10981173> Dashboard regions should not be in device space
3401
3402         Reviewed by John Sullivan.
3403
3404         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3405         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.
3406         (-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
3407         (TestWebKitAPI):
3408         (TestWebKitAPI::TEST):
3409
3410 2012-03-08  Dirk Pranke  <dpranke@chromium.org>
3411
3412         webkit-patch works oddly on local Git branches
3413         https://bugs.webkit.org/show_bug.cgi?id=76958
3414
3415         Reviewed by Ojan Vafai.
3416
3417         This change makes the '-g' flag to webkit-patch behave a
3418         little more consistently with git. The 'HEAD..' syntax
3419         is changed to 'HEAD....' (four dots), so as to not
3420         collide with the underlying git syntax. We also generalize
3421         the syntax to support any refname, so 'foo....' means
3422         diff against foo and include working copy changes.
3423
3424         This change also adds the 'UPSTREAM' shortcut to identify
3425         whatever the current upstream/tracking branch is; this is
3426         useful if you have multiple local branches stacked up.
3427
3428         * Scripts/webkitpy/common/checkout/scm/git.py:
3429         (Git._branch_from_ref):
3430         (Git):
3431         (Git._current_branch):
3432         (Git._upstream_branch):
3433         (Git.merge_base):
3434         (Git._commit_on_branch):
3435         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3436         (GitSVNTest._second_local_commit):
3437         (GitSVNTest._two_local_commits):
3438         (GitSVNTest.test_commit_with_message_git_commit_range):
3439         (GitSVNTest.test_upstream_branch):
3440         (GitSVNTest.test_create_patch_working_copy_only):
3441         (GitSVNTest.test_changed_files_local_plus_working_copy):
3442         (GitSVNTest.test_changed_files_working_copy_only):
3443         (GitSVNTest.test_changed_files_upstream):
3444         * Scripts/webkitpy/tool/steps/options.py:
3445         (Options):
3446
3447 2012-03-08  John Sullivan  <sullivan@apple.com>
3448
3449         Made extract-localizable-strings ignore NSLocalizedFileSizeDescription
3450
3451         Reviewed by Eric Carlson.
3452
3453         * Scripts/extract-localizable-strings:
3454         Added NSLocalizedFileSizeDescription to allowed list of tokens that start
3455         with NSLocalized. Also improved an error message to include the troublesome token.
3456
3457 2012-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3458
3459         Unreviewed, rolling out r110115.
3460         http://trac.webkit.org/changeset/110115
3461         https://bugs.webkit.org/show_bug.cgi?id=80581
3462
3463         broke test-webkitpy (Requested by philn-tp on #webkit).
3464
3465         * Scripts/old-run-webkit-tests:
3466         * Scripts/webkitpy/layout_tests/port/qt.py:
3467         (QtPort):
3468         (QtPort.determine_full_port_name):
3469         (QtPort.baseline_search_path):
3470
3471 2012-03-08  Kentaro Hara  <haraken@chromium.org>
3472
3473         Unreviewed. Added myself to watchlist.
3474
3475         * Scripts/webkitpy/common/config/watchlist:
3476
3477 2012-03-07  Jessie Berlin  <jberlin@apple.com>
3478
3479         Clean Windows build fails after r110033
3480         https://bugs.webkit.org/show_bug.cgi?id=80553
3481
3482         Rubber-stamped by Jon Honeycutt and Eric Seidel.
3483
3484         Add the new JavaScriptCore include directory to some more vsprops files.
3485
3486         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3487         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3488         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3489
3490 2012-03-07  Rafael Brandao  <rafael.lobo@openbossa.org>
3491
3492         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
3493         https://bugs.webkit.org/show_bug.cgi?id=72489
3494
3495         Reviewed by Dirk Pranke.
3496
3497         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
3498         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
3499         --platform will override the platform name and then we'll use it.
3500
3501         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
3502         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
3503         override it in the end.
3504
3505         * Scripts/old-run-webkit-tests:
3506         * Scripts/webkitpy/layout_tests/port/qt.py:
3507         (QtPort):
3508         (QtPort.determine_full_port_name):
3509         (QtPort.baseline_search_path):
3510
3511 2012-03-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
3512
3513         [Qt][WK2] MiniBrowser on desktop does not react to click events
3514         https://bugs.webkit.org/show_bug.cgi?id=80314
3515
3516         Reviewed by Kenneth Rohde Christiansen.
3517
3518         Do not enable touch mocking on desktop mode.
3519
3520         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3521         (MiniBrowserApplication::handleUserOptions):
3522
3523 2012-03-07  Ojan Vafai  <ojan@chromium.org>
3524
3525         Automatically move to the next test after rebaseline in the results view
3526         https://bugs.webkit.org/show_bug.cgi?id=80527
3527
3528         Reviewed by Dimitri Glazkov.
3529
3530         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3531         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3532
3533 2012-03-07  Ojan Vafai  <ojan@chromium.org>
3534
3535         garden-o-matic rebaseline is broken for ports that don't have a fallback port
3536         https://bugs.webkit.org/show_bug.cgi?id=80526
3537
3538         Reviewed by Adam Barth.
3539
3540         Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test"
3541         since there is no "None" port.
3542
3543         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3544         (GardeningHTTPRequestHandler.rebaseline):
3545         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3546         (GardeningServerTest.test_rebaseline):
3547
3548 2012-03-07  James Robinson  <jamesr@chromium.org>
3549
3550         [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
3551         https://bugs.webkit.org/show_bug.cgi?id=80521
3552
3553         Reviewed by Kenneth Russell.
3554
3555         Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
3556         to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
3557         renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
3558
3559         Covered by platform/chromium/compositing/plugins/*
3560
3561         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3562         (TestWebPlugin::TestWebPlugin):
3563         (TestWebPlugin::initialize):
3564         (TestWebPlugin::updateGeometry):
3565         (TestWebPlugin::initScene):
3566         (TestWebPlugin::destroyScene):
3567         * DumpRenderTree/chromium/TestWebPlugin.h:
3568         (TestWebPlugin):
3569         * DumpRenderTree/chromium/WebViewHost.cpp:
3570         (WebViewHost::createPlugin):
3571
3572 2012-03-07  Philippe Normand  <pnormand@igalia.com>
3573
3574         [GTK] remove webkitpy dependency in run-gtk-tests
3575         https://bugs.webkit.org/show_bug.cgi?id=80500
3576
3577         Reviewed by Martin Robinson.
3578
3579         Replace Executive calls with bare subprocess calls.
3580
3581         * Scripts/run-gtk-tests:
3582         (TestRunner):
3583         (TestRunner._lookup_atspi2_binary):
3584         (TestRunner.run):
3585         (TestRunner.run.run_for_real):
3586
3587 2012-03-07  Philippe Normand  <pnormand@igalia.com>
3588
3589         Unreviewed, GTK build fix after r110059.
3590
3591         * Scripts/run-gtk-tests:
3592         (TestRunner._check_if_tests_have_timed_out):
3593         (TestRunner.run.run_tests):
3594         (TestRunner):
3595
3596 2012-03-07  Philippe Normand  <pnormand@igalia.com>
3597
3598         [GTK] race condition in run-gtk-tests
3599         https://bugs.webkit.org/show_bug.cgi?id=80495
3600
3601         Reviewed by Martin Robinson.
3602
3603         Refactored the script to wait the a11y dbus service becomes
3604         available before starting the tests.
3605
3606         * Scripts/run-gtk-tests:
3607         (TestRunner._lookup_atspi2_binary):
3608         (TestRunner):
3609         (TestRunner._wait_dbus_service_and_run):
3610         (TestRunner._wait_dbus_service_and_run.on_name_appeared):
3611         (TestRunner._wait_dbus_service_and_run.on_name_vanished):
3612         (TestRunner.run):
3613         (TestRunner.run.bailout):
3614         (TestRunner.run.run_for_real):
3615
3616 2012-03-07  Dinu Jacob  <dinu.jacob@nokia.com>
3617
3618         [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
3619         https://bugs.webkit.org/show_bug.cgi?id=80425
3620
3621         Reviewed by Simon Hausmann.
3622
3623         Set startScreenPos in mock touch point
3624
3625         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3626         (MiniBrowserApplication::notify):
3627         * MiniBrowser/qt/MiniBrowserApplication.h:
3628         (MiniBrowserApplication):
3629
3630 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
3631
3632         [Qt] Windows build fix.
3633
3634         Reviewed by Tor Arne Vestbø.
3635
3636         Pass the -j parameter only to "make", not "nmake".
3637
3638         * Scripts/webkitdirs.pm:
3639         (buildQMakeProjects):
3640
3641 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
3642
3643         [Qt] Fix compilation without QtQuick1
3644         https://bugs.webkit.org/show_bug.cgi?id=80503
3645
3646         Reviewed by Tor Arne Vestbø.
3647
3648         Introduce HAVE_QQUICK1 as feature and added haveQtModule
3649         as convenience function.
3650
3651         * qmake/mkspecs/features/features.prf:
3652         * qmake/mkspecs/features/functions.prf:
3653
3654 2012-03-07  Zoltan Horvath  <zoltan@webkit.org>
3655
3656         [Qt] Add qmake config tests for JPEG and PNG library
3657         https://bugs.webkit.org/show_bug.cgi?id=80398
3658
3659         Add JPEG and PNG library tests to config.tests and
3660         add error() abort to WebCore.pri if tests don't work.
3661
3662         Reviewed by Tor Arne Vestbø.
3663
3664         * qmake/config.tests/libjpeg/libjpeg.cpp: Added.
3665         (main):
3666         * qmake/config.tests/libjpeg/libjpeg.pro: Added.
3667         * qmake/config.tests/libpng/libpng.cpp: Added.
3668         (main):
3669         * qmake/config.tests/libpng/libpng.pro: Added.
3670         * qmake/sync.profile:
3671
3672 2012-03-07  Byungwoo Lee  <bw80.lee@samsung.com>
3673
3674         [EFL] Build warning: Fix warn_unused_result warnings.
3675         https://bugs.webkit.org/show_bug.cgi?id=79194
3676
3677         Reviewed by Filip Pizlo.
3678
3679         Fixed build warning which is getting generated when not using return