9bbd6a40ac3ed1c61593f1290bc0bf8578d7f99f
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-31  Eric Seidel  <eric@webkit.org>
2
3         webkit-patch apply-from-bug should work regardless of your CWD
4         https://bugs.webkit.org/show_bug.cgi?id=77482
5
6         Reviewed by Adam Barth.
7
8         webkit-patch only ever works with patches made from the root
9         directory.  We should pass the CWD to svn-apply in the case
10         where we're running not from the webkit root.  I believe
11         this used to work in the past and regressed.
12
13         * Scripts/webkitpy/common/checkout/checkout.py:
14         (Checkout.apply_patch):
15         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
16         (CheckoutTest.test_apply_patch):
17
18 2012-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
19
20         Unreviewed, rolling out r106302.
21         http://trac.webkit.org/changeset/106302
22         https://bugs.webkit.org/show_bug.cgi?id=77472
23
24         Broke building DRT before running the tests (Requested by ojan
25         on #webkit).
26
27         * Scripts/webkit-build-directory:
28         * Scripts/webkitpy/layout_tests/port/config.py:
29         (Config.build_directory):
30         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
31         (main):
32         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
33         (ConfigTest.assert_configuration):
34         (ConfigTest.test_build_directory.mock_webkit_build_directory):
35         (ConfigTest.test_build_directory):
36         (ConfigTest.test_default_configuration__notfound):
37         * Scripts/webkitpy/layout_tests/port/webkit.py:
38         (WebKitPort._build_path):
39
40 2012-01-31  Antoine Labour  <piman@chromium.org>
41
42         Merge WebGraphicsContext3D creation and initialization, and move it to
43         WebViewClient.
44         https://bugs.webkit.org/show_bug.cgi?id=76593
45
46         Reviewed by Darin Fisher.
47
48         * DumpRenderTree/chromium/TestWebPlugin.cpp:
49         (TestWebPlugin::TestWebPlugin):
50         (TestWebPlugin::initialize):
51         * DumpRenderTree/chromium/TestWebPlugin.h:
52         * DumpRenderTree/chromium/WebViewHost.cpp:
53         (WebViewHost::createGraphicsContext3D):
54         (WebViewHost::createPlugin):
55         * DumpRenderTree/chromium/WebViewHost.h:
56
57 2012-01-31  Gabor Rapcsanyi  <rgabor@webkit.org>
58
59         [GTK] build-webkit warning.
60         https://bugs.webkit.org/show_bug.cgi?id=77411
61
62         Reviewed by Philippe Normand.
63
64         * Scripts/webkitdirs.pm:
65         (isCrossCompilation):
66
67 2012-01-31  Dan Bernstein  <mitz@apple.com>
68
69         When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
70
71         Reviewed by Anders Carlsson.
72
73         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
74
75 2012-01-31  Csaba Osztrogonác  <ossy@webkit.org>
76
77         If the QTDIR environment variable is set, the build system fails to compile WinCairo
78         https://bugs.webkit.org/show_bug.cgi?id=77112
79
80         Reviewed by Daniel Bates.
81
82         * Scripts/webkitdirs.pm:
83         (determineIsQt):
84
85 2012-01-31  Adam Roben  <aroben@apple.com>
86
87         Only call -typingAttributes on WebViews, not WebHTMLViews
88
89         Looks like this case was just missed in r105908.
90
91         Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
92
93         Reviewed by Antti Koivisto.
94
95         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
96         (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
97         earlier.
98
99 2012-01-31  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
100
101         [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
102         https://bugs.webkit.org/show_bug.cgi?id=77221
103
104         Reviewed by Kenneth Rohde Christiansen.
105
106         This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
107
108         * MiniBrowser/qt/MiniBrowserApplication.cpp:
109         (MiniBrowserApplication::sendTouchEvent):
110
111 2012-01-26  Hans Wennborg  <hans@chromium.org>
112
113         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
114         https://bugs.webkit.org/show_bug.cgi?id=77083
115
116         Reviewed by Darin Fisher.
117
118         Add MockWebSpeechInputController which provides a mock implementation
119         of the WebSpeechInputController interface, and use that in
120         DumpRenderTree.
121
122         * DumpRenderTree/DumpRenderTree.gypi:
123         * DumpRenderTree/chromium/LayoutTestController.cpp:
124         (LayoutTestController::addMockSpeechInputResult):
125         * DumpRenderTree/chromium/LayoutTestController.h:
126         ():
127         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
128         (MockWebSpeechInputController::create):
129         (MockWebSpeechInputController::addMockRecognitionResult):
130         (MockWebSpeechInputController::clearResults):
131         (MockWebSpeechInputController::startRecognition):
132         (MockWebSpeechInputController::cancelRecognition):
133         (MockWebSpeechInputController::stopRecording):
134         (MockWebSpeechInputController::MockWebSpeechInputController):
135         (MockWebSpeechInputController::speechTaskFired):
136         (MockWebSpeechInputController::SpeechTask::SpeechTask):
137         (MockWebSpeechInputController::SpeechTask::stop):
138         (MockWebSpeechInputController::SpeechTask::runIfValid):
139         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
140         (WebKit):
141         (MockWebSpeechInputController):
142         (MockWebSpeechInputController::taskList):
143         (SpeechTask):
144         * DumpRenderTree/chromium/TestShell.cpp:
145         * DumpRenderTree/chromium/WebViewHost.cpp:
146         (WebViewHost::speechInputController):
147         * DumpRenderTree/chromium/WebViewHost.h:
148         (WebKit):
149         (WebViewHost::speechInputControllerMock):
150         (WebViewHost):
151         ():
152
153 2012-01-31  Hajime Morrita  <morrita@chromium.org>
154
155         [PerformanceTests] Add landing html for Dromaeo dom-query test
156         https://bugs.webkit.org/show_bug.cgi?id=77329
157
158         Reviewed by Ryosuke Niwa.
159
160         Added some more ignorable output patterns to allow warnings
161         from a third party test suite.
162
163         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
164         (PerfTestsRunner):
165         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
166
167 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
168
169         [wx] Unreviewed. Update download URLs to new domain.
170         
171         * waf/build/build_utils.py:
172         (update_wx_deps):
173
174 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
175
176         [wx] Unreviewed. Build fix, add JavaScriptCore/tools
177         to the list of build directories.
178         
179         * waf/build/settings.py:
180
181 2012-01-30  Kentaro Hara  <haraken@chromium.org>
182
183         REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
184         output an empty method name (i.e. "()")
185         https://bugs.webkit.org/show_bug.cgi?id=77336
186
187         Reviewed by Darin Adler.
188
189         r105797 tried to detect a change outside methods, but it causes a bug that
190         prepare-ChangeLog can output an empty method name, like this:
191
192             * foo/bar/baz.cpp:
193             (method1):
194             ():
195             (method2):
196
197         This is because the cpp parser in prepare-ChangeLog cannot distinguish
198         '{' as the beginning of a method with '{' as the beginning of an array definition
199         at the top level.
200
201             int a[] = { 1, 2, 3 };  // This '{' is the beginning of an array definition.
202
203             void func() { // This '{' is the beginning of a method.
204                 ...;
205             }
206
207         This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
208
209         * Scripts/prepare-ChangeLog:
210         (get_function_line_ranges_for_cpp): Modified as described above.
211         (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
212         an empty method name. Ideally this should not happen but may happen, since the
213         parsers are not perfect.
214         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
215         (NameSpace7):
216         (NameSpace8):
217         (Class109):
218         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
219
220 2012-01-30  Ojan Vafai  <ojan@chromium.org>
221
222         run-webkit-tests calls out to webkit-build-directory twice
223         https://bugs.webkit.org/show_bug.cgi?id=77248
224
225         Reviewed by Dirk Pranke.
226
227         This reduces to calls to webkit-build-directory to one call and
228         saves 500ms for run-webkit-tests over a single file.
229
230         * Scripts/webkit-build-directory:
231         If called with no arguments, print out both the top-level directory and the 
232         configuration directory.
233
234         * Scripts/webkit-build-directory:
235         * Scripts/webkitpy/layout_tests/port/config.py:
236         (Config.build_directory):
237         When called with no arguments, get and cache both the top-level and configuration directories.
238
239         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
240         (main):
241         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
242         (ConfigTest.assert_configuration):
243         (ConfigTest.test_build_directory.mock_webkit_build_directory):
244         (ConfigTest.test_build_directory):
245         (ConfigTest.test_default_configuration__notfound):
246         * Scripts/webkitpy/layout_tests/port/webkit.py:
247         (WebKitPort._build_path):
248         Cache the root directory in the options object so that other users
249         of the options object don't need to call out to webkit-build-directory.
250
251 2012-01-30  Ojan Vafai  <ojan@chromium.org>
252
253         Parsing test_expecations.txt + Skipped lists takes too long
254         https://bugs.webkit.org/show_bug.cgi?id=77059
255
256         Reviewed by Dirk Pranke.
257
258         This saves ~100ms on the Apple Mac port.
259         -memoize a bunch of path methods.
260         -Avoid doing multiple disk accesses per line.
261         -Parse the skipped list directly instead of turning it into a test_expecations.txt
262         formatting string and parsing that.
263
264         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
265         (TestExpectationParser):
266         (TestExpectationParser.expectation_for_skipped_test):
267         (TestExpectationParser._parse_line):
268         (TestExpectationParser._collect_matching_tests):
269         (TestExpectations.__init__):
270         (TestExpectations._add_skipped_tests):
271         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
272         (test_add_skipped_tests):
273         (test_add_skipped_tests_duplicate):
274         * Scripts/webkitpy/layout_tests/port/base.py:
275         (Port):
276         (Port.test_isfile):
277         (Port.normalize_test_name):
278         (Port.layout_tests_dir):
279         (Port.abspath_for_test):
280         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
281
282 2012-01-30  Alexis Menard  <alexis.menard@openbossa.org>
283
284         Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
285         
286         * Scripts/webkitpy/common/config/watchlist:
287
288 2012-01-30  Gavin Barraclough  <barraclough@apple.com>
289
290         Unreviewed build fix following bug#76855
291
292         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
293         ():
294         (TestWebKitAPI::TEST_F):
295
296 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
297
298         [Qt] WKTR: Use a software rendering pipiline when running tests.
299         https://bugs.webkit.org/show_bug.cgi?id=76708
300
301         Reviewed by Kenneth Rohde Christiansen.
302
303         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
304         (WTR::WrapperWindow::WrapperWindow):
305         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
306
307 2012-01-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
308
309         [Qt] Store build config immediately instead of waiting for a successfull build
310
311         Otherwise we will not pick up changes to the config if the build is aborted,
312         for example due to build errors or if the user pressed Ctrl+Z. We now write
313         the new config before starting a build, but still defer to write the SVN
314         revision once the build completes successfully.
315
316         Reviewed by Ossy.
317
318         * Scripts/webkitdirs.pm:
319         (buildQMakeProjects):
320
321 2012-01-30  Alexander Færøy  <ahf@0x90.dk>
322
323         [Qt] Add "New Window" button to the Qt MiniBrowser
324         https://bugs.webkit.org/show_bug.cgi?id=77281
325
326         Reviewed by Tor Arne Vestbø.
327
328         * MiniBrowser/qt/BrowserWindow.cpp:
329         (BrowserWindow::BrowserWindow):
330         * MiniBrowser/qt/MiniBrowser.qrc:
331         * MiniBrowser/qt/icons/plus.png: Added.
332         * MiniBrowser/qt/qml/BrowserWindow.qml:
333
334 2012-01-30  Csaba Osztrogonác  <ossy@webkit.org>
335
336         Unreviewed rolling out r106222.
337
338         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
339         (SingleTestRunner.__init__):
340         * Scripts/webkitpy/layout_tests/controllers/worker.py:
341         (Worker.handle_test_list):
342         * Scripts/webkitpy/layout_tests/models/test_input.py:
343         (TestInput.__init__):
344         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
345         (_set_up_derived_options):
346         (parse_args):
347         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
348         (MainTest.test_repeat_each):
349         * WebKitTestRunner/TestInvocation.cpp:
350         (WTR::TestInvocation::setIsPixelTest):
351
352 2012-01-30  Hans Wennborg  <hans@chromium.org>
353
354         Unreviewed, rolling out r106219.
355         http://trac.webkit.org/changeset/106219
356         https://bugs.webkit.org/show_bug.cgi?id=77083
357
358         This broke Chromium's test_shell.
359
360         * DumpRenderTree/DumpRenderTree.gypi:
361         * DumpRenderTree/chromium/LayoutTestController.cpp:
362         (LayoutTestController::addMockSpeechInputResult):
363         * DumpRenderTree/chromium/LayoutTestController.h:
364         (WebKit):
365         (LayoutTestController):
366         ():
367         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
368         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
369         * DumpRenderTree/chromium/TestShell.cpp:
370         * DumpRenderTree/chromium/WebViewHost.cpp:
371         (WebViewHost::speechInputController):
372         * DumpRenderTree/chromium/WebViewHost.h:
373         (WebKit):
374         (WebViewHost::speechInputControllerMock):
375         (WebViewHost):
376         ():
377
378 2012-01-26  Hans Wennborg  <hans@chromium.org>
379
380         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
381         https://bugs.webkit.org/show_bug.cgi?id=77083
382
383         Reviewed by Darin Fisher.
384
385         Add MockWebSpeechInputController which provides a mock implementation
386         of the WebSpeechInputController interface, and use that in
387         DumpRenderTree.
388
389         * DumpRenderTree/DumpRenderTree.gypi:
390         * DumpRenderTree/chromium/LayoutTestController.cpp:
391         (LayoutTestController::addMockSpeechInputResult):
392         * DumpRenderTree/chromium/LayoutTestController.h:
393         ():
394         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
395         (MockWebSpeechInputController::create):
396         (MockWebSpeechInputController::addMockRecognitionResult):
397         (MockWebSpeechInputController::clearResults):
398         (MockWebSpeechInputController::startRecognition):
399         (MockWebSpeechInputController::cancelRecognition):
400         (MockWebSpeechInputController::stopRecording):
401         (MockWebSpeechInputController::MockWebSpeechInputController):
402         (MockWebSpeechInputController::speechTaskFired):
403         (MockWebSpeechInputController::SpeechTask::SpeechTask):
404         (MockWebSpeechInputController::SpeechTask::stop):
405         (MockWebSpeechInputController::SpeechTask::runIfValid):
406         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
407         (WebKit):
408         (MockWebSpeechInputController):
409         (MockWebSpeechInputController::taskList):
410         (SpeechTask):
411         * DumpRenderTree/chromium/TestShell.cpp:
412         * DumpRenderTree/chromium/WebViewHost.cpp:
413         (WebViewHost::speechInputController):
414         * DumpRenderTree/chromium/WebViewHost.h:
415         (WebKit):
416         (WebViewHost::speechInputControllerMock):
417         (WebViewHost):
418         ():
419
420 2012-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
421
422         Unreviewed, rolling out r106109.
423         http://trac.webkit.org/changeset/106109
424         https://bugs.webkit.org/show_bug.cgi?id=77302
425
426         It made tests crash (Requested by Ossy_weekend on #webkit).
427
428         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
429         (WTR::WrapperWindow::WrapperWindow):
430         (WTR::PlatformWebView::PlatformWebView):
431
432 2012-01-28  Nico Weber  <thakis@chromium.org>
433
434         [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
435         https://bugs.webkit.org/show_bug.cgi?id=77243
436
437         Reviewed by Adam Barth.
438
439         * Scripts/update-webkit:
440         * Scripts/webkitdirs.pm:
441         (isChromiumNinja):
442         (determineIsChromiumNinja):
443         (buildChromiumNinja):
444         (buildChromium):
445
446 2012-01-27  Kentaro Hara  <haraken@chromium.org>
447
448         The cpp parser of prepare-ChangeLog treats if(...) {} as a method
449         https://bugs.webkit.org/show_bug.cgi?id=77241
450
451         Reviewed by Ryosuke Niwa.
452
453         The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
454         in a method in some namespace or class is treated as a method.
455         This patch fixes the bug.
456
457             class C {
458                 void func()
459                 {
460                     if (1) {    // This should not be treated as a method.
461                     }
462                 }
463             };
464
465         * Scripts/prepare-ChangeLog:
466         (get_function_line_ranges_for_cpp):
467         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
468         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
469         (Class108):
470         (Class108::func35):
471
472 2012-01-27  Enrica Casucci  <enrica@apple.com>
473
474         Followup to http://trac.webkit.org/changeset/106171.
475         Dan Bernstein pointed out correctly that I should
476         have used copy instead of initWithString.
477
478         Reviewed by Dan Bernstein.
479
480         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
481         (-[LocalPasteboard initWithName:]):
482
483 2012-01-27  Enrica Casucci  <enrica@apple.com>
484
485         DRT pasteboard object should return the correct pasteboard name.
486         https://bugs.webkit.org/show_bug.cgi?id=77260
487         
488         Currently the name property always returns nil.
489         Adding a memeber variable to store the pasteboard name and return its
490         value from the name method instead of returning nil always.
491
492         Reviewed by Dan Bernstein.
493
494         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
495         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
496         (-[LocalPasteboard initWithName:]):
497         (-[LocalPasteboard name]):
498
499 2012-01-27  Martin Robinson  <mrobinson@igalia.com>
500
501         [GTK] [WK2] Implement the policy client
502         https://bugs.webkit.org/show_bug.cgi?id=76343
503
504         Reviewed by Gustavo Noronha Silva.
505
506         * gtk/generate-gtkdoc:
507         (get_webkit2_options): Update the list of skipped source files to include all clients.
508
509 2012-01-27  Ada Chan  <adachan@apple.com>
510
511         Add test for WKBundleFrameGetParentFrame().
512         https://bugs.webkit.org/show_bug.cgi?id=77161
513
514         Reviewed by Anders Carlsson.
515
516         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp.
517         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added.
518         (TestWebKitAPI):
519         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle.
520         (TestWebKitAPI::setInjectedBundleClient):
521         (TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result.
522         Make sure the check is successful.
523         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added.
524         (TestWebKitAPI):
525         (ParentFrameTest):
526         (TestWebKitAPI::ParentFrameTest::ParentFrameTest):
527         (TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later.
528         If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result
529         to the test controller.
530         (TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page.
531
532 2012-01-27  Zan Dobersek  <zandobersek@gmail.com>
533
534         [Gtk] DumpRenderTree lacks --no-timeout command line option
535         https://bugs.webkit.org/show_bug.cgi?id=77196
536
537         Reviewed by Martin Robinson.
538
539         Add the --no-timeout command line option and reorganize
540         watchdog code to make running DumpRenderTree without
541         timeout possible.
542
543         * DumpRenderTree/gtk/DumpRenderTree.cpp:
544         (setWaitToDumpWatchdog):
545         (shouldSetWaitToDumpWatchdog):
546         (initializeGlobalsFromCommandLineOptions):
547         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
548         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
549         (waitToDumpWatchdogFired):
550         (LayoutTestController::setWaitToDump):
551
552 2012-01-27  Andras Becsi  <andras.becsi@nokia.com>
553
554         [Qt][WK2] Enable the automatic touch->mouse mocking on the new Qt5 hashes
555         https://bugs.webkit.org/show_bug.cgi?id=77122
556
557         Reviewed by Kenneth Rohde Christiansen.
558
559         * MiniBrowser/qt/MiniBrowserApplication.cpp:
560         (MiniBrowserApplication::MiniBrowserApplication):
561
562 2012-01-27  Zeno Albisser  <zeno@webkit.org>
563
564         [Qt][Mac] Build fails after adding ICU support (r105997).
565         https://bugs.webkit.org/show_bug.cgi?id=77118
566
567         Define WTF_USE_ICU_UNICODE if we are on mac.
568
569         Reviewed by Tor Arne Vestbø.
570
571         * qmake/mkspecs/features/features.prf:
572
573 2012-01-27  Roland Takacs  <takacs.roland@stud.u-szeged.hu>
574
575         Update committers.py with new contributors.
576         https://bugs.webkit.org/show_bug.cgi?id=77207
577
578         I added six new contributors into committers.py:
579
580         - Adam Kallai
581         - Balazs Ankes
582         - Janos Badics
583         - Nandor Huszka
584         - Roland Takacs
585         - Szilard Ledan-Muntean
586
587         * Scripts/webkitpy/common/config/committers.py:
588
589 2012-01-27  Vsevolod Vlasov  <vsevik@chromium.org>
590
591         Add Vsevolod Vlasov to reviewers list.
592
593         Reviewed by Pavel Feldman.
594
595         * Scripts/webkitpy/common/config/committers.py:
596
597 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
598
599         [Qt] WKTR: Use a software rendering pipiline when running tests.
600         https://bugs.webkit.org/show_bug.cgi?id=76708
601
602         Reviewed by Kenneth Rohde Christiansen.
603
604         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
605         (WTR::WrapperWindow::WrapperWindow):
606         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
607
608 2012-01-26  Kevin Ollivier  <kevino@theolliviers.com>
609
610         [wx] Unreviewed. Build fix, add WebCore/testing/js
611         to the list of source directories we build.
612
613         * waf/build/settings.py:
614
615 2012-01-26  Filip Pizlo  <fpizlo@apple.com>
616
617         Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
618         https://bugs.webkit.org/show_bug.cgi?id=77177
619
620         Reviewed by Jon Honeycutt.
621
622         * Scripts/commit-log-editor:
623
624 2012-01-26  Ojan Vafai  <ojan@chromium.org>
625
626         Decrease sleep time when killing server_process on Mac.
627         https://bugs.webkit.org/show_bug.cgi?id=77169
628
629         Reviewed by Eric Seidel.
630
631         This shaves another ~70ms off single test runtime.
632
633         * Scripts/webkitpy/layout_tests/port/server_process.py:
634         (ServerProcess.stop):
635
636 2012-01-26  Ojan Vafai  <ojan@chromium.org>
637
638         Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
639         https://bugs.webkit.org/show_bug.cgi?id=77164
640
641         Reviewed by Dirk Pranke.
642
643         http://trac.webkit.org/changeset/106035 depends on builder_name being
644         falsey by default. There's other code that requires it to be iterable
645         by default. So, make it be the empty string.
646
647         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
648         (parse_args):
649
650 2012-01-26  Ryosuke Niwa  <rniwa@webkit.org>
651
652         run-perf-test should include relative file paths in test names
653         https://bugs.webkit.org/show_bug.cgi?id=77144
654
655         Reviewed by Adam Birth.
656
657         Include all directory names in the test name separated by "/".
658         e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
659
660         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
661         (PerfTestsRunner):
662         (PerfTestsRunner._process_parser_test_result):
663         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
664         (test_run_test_set_with_json_output):
665         (test_run_test_set_with_json_source):
666
667 2012-01-26  Dirk Pranke  <dpranke@chromium.org>
668
669         webkitpy: re-land cleanup of test scaffolding
670         https://bugs.webkit.org/show_bug.cgi?id=77153
671
672         Reviewed by Eric Seidel.
673
674         This is an attempt to reland the change in bug 76973 / 
675         r105935. My earlier attempt to manipulate PYTHONPATH
676         seems to only work some of the time, for reasons that
677         elude me. Directly adding Tools/Scripts to sys.path from
678         inside the test script appears to work (more?) reliably.
679
680         Also, it seemed like the files didn't actually get deleted
681         the last time; I don't know why.
682
683         * Scripts/test-webkitpy:
684         * Scripts/webkitpy/common/system/executive_unittest.py:
685         (command_line):
686         (ExecutiveTest):
687         (ExecutiveTest.test_run_command_args_type):
688         (ExecutiveTest.test_run_command_with_unicode):
689         (ExecutiveTest.test_running_pids):
690         (main):
691         * Scripts/webkitpy/common/system/fileutils.py: Removed.
692         * Scripts/webkitpy/test/cat.py: Removed.
693         * Scripts/webkitpy/test/cat_unittest.py: Removed.
694         * Scripts/webkitpy/test/echo.py: Removed.
695         * Scripts/webkitpy/test/echo_unittest.py: Removed.
696
697 2012-01-26  Ojan Vafai  <ojan@chromium.org>
698
699         run-webkit-tests calls "nm" when it doesn't need to
700         https://bugs.webkit.org/show_bug.cgi?id=77143
701
702         Reviewed by Dirk Pranke.
703
704         If we are not running any test that can be skipped by checking
705         the DRT feature list or looking at the list of symbols, avoid calling
706         out to DRT or calling "nm".
707
708         This saves ~700ms on my Mac Pro. In cases where you still have to call out
709         to "nm" it's only a couple ms slower.
710
711         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
712         (TestExpectations.__init__):
713         * Scripts/webkitpy/layout_tests/port/base.py:
714         (Port.skipped_tests):
715         * Scripts/webkitpy/layout_tests/port/webkit.py:
716         (WebKitPort._should_check_for_missing_features):
717         (WebKitPort):
718         (WebKitPort._should_check_for_missing_symbols):
719         (WebKitPort._skipped_tests_for_unsupported_features):
720         (WebKitPort.skipped_layout_tests):
721         (WebKitPort.skipped_tests):
722         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
723         (WebKitPortTest.test_skipped_directories_for_symbols):
724         (test_skipped_directories_for_features):
725         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
726         (test_skipped_layout_tests):
727
728 2012-01-26  Benjamin Poulain  <bpoulain@apple.com>
729
730         Support a suffix on ChangeLog filenames based on a configuration file
731         https://bugs.webkit.org/show_bug.cgi?id=76956
732
733         Reviewed by Kentaro Hara.
734
735         Modify the tools used to generate, edit and resolve ChangeLogs to support
736         the addition of a suffix to the ChangeLog filename.
737
738         This patch makes it easier to support alternate ChangeLog files in branches.
739
740         * Scripts/VCSUtils.pm:
741         (changeLogSuffix):
742         (changeLogFileName):
743         * Scripts/commit-log-editor:
744         * Scripts/prepare-ChangeLog:
745         (getLatestChangeLogs):
746         (generateNewChangeLogs):
747         (generateFileList):
748         * Scripts/resolve-ChangeLogs:
749         (findChangeLog):
750
751 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
752
753         Unreviewed, rolling out r106038.
754         http://trac.webkit.org/changeset/106038
755         https://bugs.webkit.org/show_bug.cgi?id=77142
756
757         Caused a bunch of skipped tests to not be skipped. (Requested
758         by ojan on #webkit).
759
760         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
761         (TestExpectationParser):
762         (TestExpectationParser.parse):
763         (TestExpectationParser._parse_line):
764         (TestExpectationParser._collect_matching_tests):
765         (TestExpectations.__init__):
766         (TestExpectations._add_skipped_tests):
767         * Scripts/webkitpy/layout_tests/port/base.py:
768         (Port.test_dirs):
769         (Port.normalize_test_name):
770         (Port.update_baseline):
771         (Port.layout_tests_dir):
772         (Port.relative_perf_test_filename):
773         (Port.abspath_for_test):
774
775 2012-01-25  Ojan Vafai  <ojan@chromium.org>
776
777         Parsing test_expecations.txt + Skipped lists takes too long
778         https://bugs.webkit.org/show_bug.cgi?id=77059
779
780         Reviewed by Dirk Pranke.
781
782         This saves ~100ms on the Apple Mac port.
783         -memoize a bunch of path methods.
784         -Avoid doing multiple disk accesses per line.
785         -Parse the skipped list directly instead of turning it into a test_expecations.txt
786         formatting string and parsing that.
787
788         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
789         (TestExpectationParser):
790         (TestExpectationParser.parse_skipped_tests):
791         (TestExpectationParser._parse_line):
792         (TestExpectationParser._collect_matching_tests):
793         (TestExpectations.__init__):
794         (TestExpectations._add_skipped_tests):
795         * Scripts/webkitpy/layout_tests/port/base.py:
796         (Port):
797         (Port.test_isfile):
798         (Port.normalize_test_name):
799         (Port.layout_tests_dir):
800         (Port.abspath_for_test):
801
802 2012-01-25  Ojan Vafai  <ojan@chromium.org>
803
804         Only store the SVN revision in the summarized results if we're on a builder
805         https://bugs.webkit.org/show_bug.cgi?id=76976
806
807         Reviewed by Dirk Pranke.
808
809         This shaves another ~130ms off the single test run-webkit-tests runtime.
810
811         * Scripts/webkitpy/layout_tests/controllers/manager.py:
812         (summarize_results):
813         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
814         (ResultSummaryTest.get_result):
815         (ResultSummaryTest):
816         (ResultSummaryTest.get_result_summary):
817         (ResultSummaryTest.get_unexpected_results):
818         (ResultSummaryTest.test_no_svn_revision):
819         (ResultSummaryTest.test_svn_revision):
820         * Scripts/webkitpy/layout_tests/port/base.py:
821         (Port.use_trac_links_in_results_html):
822
823 2012-01-26  Luciano Wolf  <luciano.wolf@openbossa.org>
824
825         [Qt][WK2] fast/loader tests failed after r94178
826         https://bugs.webkit.org/show_bug.cgi?id=67388
827
828         Reviewed by Simon Hausmann.
829
830         Applying the same fix used for Qt-WebKit1 from bug #67254 -
831         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
832         https://bugs.webkit.org/show_bug.cgi?id=67254
833         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
834         derived from the running location of DumpRenderTree binary.
835
836         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
837         (WTR::LayoutTestController::pathToLocalResource):
838
839 2012-01-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
840
841         Implement overridePreference for boolean preferences in WebKitTestRunner
842         https://bugs.webkit.org/show_bug.cgi?id=77033
843
844         Reviewed by Alexey Proskuryakov.
845
846         For now overridePreference supports boolean values.
847
848         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
849         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
850         (WTR::LayoutTestController::setXSSAuditorEnabled):
851         (WTR::LayoutTestController::overridePreference):
852         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
853         * WebKitTestRunner/TestController.cpp:
854         (WTR::TestController::resetStateToConsistentValues): Reset the overrides
855         explicitly and properly disable the use of PageCache when resetting the
856         state. Tests that use PageCache can now enable it via overridePreference.
857
858 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
859
860         [Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
861         https://bugs.webkit.org/show_bug.cgi?id=77100
862
863         Reviewed by Simon Hausmann.
864
865         This patch makes the MiniBrowser read multiple URL's from the command
866         line such that there will be one browser window opened for each URL.
867
868         * MiniBrowser/qt/MiniBrowserApplication.cpp:
869         (MiniBrowserApplication::handleUserOptions):
870
871 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
872
873         [Qt] The Qt MiniBrowser crashes when given multiple URL's
874         https://bugs.webkit.org/show_bug.cgi?id=77009
875
876         Reviewed by Simon Hausmann.
877
878         This patch fixes a crash in BrowserWindow::newWindow() where a
879         BrowserWindow-object is constructed with a 0 pointer as the
880         WindowOptions parameter which leads to a crash.
881
882         * MiniBrowser/qt/BrowserWindow.cpp:
883         (BrowserWindow::BrowserWindow):
884         (BrowserWindow::newWindow):
885         * MiniBrowser/qt/BrowserWindow.h:
886
887 2012-01-26  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
888
889         [Qt] Use ICU if available
890         https://bugs.webkit.org/show_bug.cgi?id=76821
891
892         Reviewed by Simon Hausmann.
893
894         Adding unicode defines for a Qt 5 based build.
895
896         * qmake/mkspecs/features/features.prf:
897
898 2012-01-26  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
899
900         [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
901         https://bugs.webkit.org/show_bug.cgi?id=42545
902
903         Reviewed by Zoltan Herczeg.
904
905         Implement the setGeolocationPermission method.
906
907         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
908         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
909         (WTR::LayoutTestController::setGeolocationPermission):
910         (WTR):
911         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
912         (LayoutTestController):
913
914 2012-01-26  Balazs Kelemen  <kbalazs@webkit.org>
915
916         [NRWT] Support --ignore-metrics
917         https://bugs.webkit.org/show_bug.cgi?id=76278
918
919         Reviewed by Tony Chang.
920
921         Port the feature from ORWT.
922
923         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
924         (SingleTestRunner._run_compare_test):
925         * Scripts/webkitpy/layout_tests/port/driver.py:
926         (DriverOutput):
927         (DriverOutput.strip_metrics):
928         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
929         (DriverOutputTest):
930         (DriverOutputTest.test_strip_metrics):
931         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
932         (_set_up_derived_options):
933         (parse_args):
934
935 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
936
937         Unreviewed, rolling out r105935 and r105954.
938         http://trac.webkit.org/changeset/105935
939         http://trac.webkit.org/changeset/105954
940         https://bugs.webkit.org/show_bug.cgi?id=77080
941
942         test-webkitpy is still broken (Requested by abarth on
943         #webkit).
944
945         * Scripts/test-webkitpy:
946         * Scripts/webkitpy/common/system/executive_unittest.py:
947         (never_ending_command):
948         (ExecutiveTest.test_run_command_args_type):
949         (ExecutiveTest.test_run_command_with_unicode):
950         (ExecutiveTest.test_running_pids):
951         * Scripts/webkitpy/common/system/fileutils.py:
952         (make_stdout_binary):
953         * Scripts/webkitpy/test/cat.py:
954         (command_arguments):
955         (main):
956         * Scripts/webkitpy/test/cat_unittest.py:
957         (CatTest):
958         (CatTest.assert_cat):
959         (CatTest.test_basic):
960         (CatTest.test_no_newline):
961         (CatTest.test_unicode):
962         (CatTest.test_as_command):
963         * Scripts/webkitpy/test/echo.py:
964         (command_arguments):
965         (main):
966         * Scripts/webkitpy/test/echo_unittest.py:
967         (EchoTest):
968         (EchoTest.test_basic):
969         (EchoTest.test_no_newline):
970         (EchoTest.test_unicode):
971         (EchoTest.test_argument_order):
972         (EchoTest.test_empty_arguments):
973         (EchoTest.test_no_arguments):
974         (EchoTest.test_as_command):
975
976 2012-01-26  Gabor Rapcsanyi  <rgabor@webkit.org>
977
978         [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
979         https://bugs.webkit.org/show_bug.cgi?id=76138
980
981         Reviewed by Martin Robinson.
982
983         * Scripts/webkitdirs.pm:
984         (isCrossCompilation):
985         (buildAutotoolsProject):
986
987 2012-01-25  Adam Barth  <abarth@webkit.org>
988
989         Kentaro is a reviewer now.  Yay!
990
991         * Scripts/webkitpy/common/config/committers.py:
992
993 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
994
995         nrwt: running w/ no arguments fails
996         https://bugs.webkit.org/show_bug.cgi?id=77064
997
998         Unreviewed, build fix.
999
1000         This change fixes a regression introduced in r105944
1001         where running without --platform <foo> or one of the other
1002         platform switches would cause a null deref :(.
1003
1004         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1005         (main):
1006
1007 2012-01-25  Eric Seidel  <eric@webkit.org>
1008
1009         Automatically CC someone from Apple on any changes to Obj-C public API
1010         https://bugs.webkit.org/show_bug.cgi?id=77053
1011
1012         Reviewed by Timothy Hatcher.
1013
1014         This has long been de-facto practice, seems now that we have
1015         fancy watchlist support, we should just make the tools
1016         do this automatically.
1017
1018         * Scripts/webkitpy/common/config/watchlist:
1019
1020 2012-01-25  Antoine Labour  <piman@chromium.org>
1021
1022         Updating status in committers.py.
1023
1024         Unreviewed.
1025
1026         * Scripts/webkitpy/common/config/committers.py:
1027
1028 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1029
1030         test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
1031         https://bugs.webkit.org/show_bug.cgi?id=77058
1032
1033         Reviewed by Eric Seidel.
1034
1035         r105935 broke executive_unittest by changing which script we
1036         were running and not ensuring that the PYTHONPATH was set up
1037         properly.
1038
1039         This change also fixes a regression introduced recently where
1040         test-webkitpy wasn't figuring out the path to Tools/Scripts
1041         right, either (so running ./test-webkitpy would fail).
1042
1043         * Scripts/test-webkitpy:
1044         * Scripts/webkitpy/common/system/executive_unittest.py:
1045         (script_dir):
1046         (ExecutiveTest.setUp):
1047         (ExecutiveTest):
1048         (ExecutiveTest.tearDown):
1049
1050 2012-01-25  Adam Barth  <abarth@webkit.org>
1051
1052         Disable tests on the mac-ews while we sort out hte stability issues.
1053
1054         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1055         (MacEWS):
1056
1057 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
1058
1059         investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
1060         https://bugs.webkit.org/show_bug.cgi?id=76475
1061
1062         Reviewed by Eric Seidel.
1063
1064         This patch cleans up the internal usage of port names for the
1065         Apple mac and Apple win ports so that 'mac' and 'win are never
1066         considered "fully specified" port names: they are still legal
1067         input to the PortFactory.get() routine, but only if run on the given
1068         platform (i.e. trying to PortFactory.get('mac') on windows or
1069         linux will return an error, since we don't know which version of
1070         the port is desired.
1071
1072         This also cleans up handling of the webkit2 variants, so that
1073         the full port names consistently follow the
1074         <operating_system>-<version>[-<wk2>] convention.
1075
1076         Lastly this patch adds some assertions and removes some
1077         try/catch logic to catch more programming and usage errors;
1078         previously mac-tiger might've been allowed -- and it would've
1079         translated into using just the baselines in platform/mac -- but
1080         now it should fail.
1081
1082         * Scripts/webkitpy/layout_tests/port/apple.py:
1083         (ApplePort.determine_full_port_name):
1084         (ApplePort.__init__):
1085         (ApplePort):
1086         (ApplePort._port_name_with_version):
1087         * Scripts/webkitpy/layout_tests/port/builders.py:
1088         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1089         (FactoryTest.test_mac):
1090         (FactoryTest.test_win):
1091         * Scripts/webkitpy/layout_tests/port/mac.py:
1092         (MacPort.baseline_search_path):
1093         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1094         (MacTest.test_versions):
1095         * Scripts/webkitpy/layout_tests/port/win.py:
1096         (WinPort.baseline_search_path):
1097         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1098         (WinTest.test_versions):
1099
1100 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1101
1102         webkitpy: print nicer errors while linting expectations files, remove redundant tests
1103         https://bugs.webkit.org/show_bug.cgi?id=76955
1104
1105         Reviewed by Adam Barth.
1106
1107         This change cleans up the errors that are printed so that the
1108         are more "quickfix" compatible (path:lineno).
1109
1110         Also, there were a bunch of redundant tests between
1111         layout_tests.models.test_expectations_unittest and
1112         style.checkers.test_expectations_unittest. The latter should
1113         just expect the former to do most of the testing.
1114
1115         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1116         (TestExpectationParser._parse_modifiers):
1117         (TestExpectations._report_errors):
1118         (TestExpectations._add_skipped_tests):
1119         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1120         (test_parse_error_nonfatal):
1121         (SemanticTests.test_bad_bugid):
1122         * Scripts/webkitpy/style/checkers/test_expectations.py:
1123         (TestExpectationsChecker.__init__):
1124         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1125         (TestExpectationsTestCase.assert_lines_lint):
1126         (TestExpectationsTestCase.test_valid_expectations):
1127         (TestExpectationsTestCase.test_invalid_expectations):
1128         (TestExpectationsTestCase.test_tab):
1129
1130 2012-01-25  Eric Seidel  <eric@webkit.org>
1131
1132         webkit-patch apply-* should always continue after failures
1133         https://bugs.webkit.org/show_bug.cgi?id=77057
1134
1135         Reviewed by Adam Barth.
1136
1137         As far as I can tell there is only one potential drawback to always
1138         forcing: that if you're somehow in the wrong directory it will create new
1139         directories for new files.  Since webkit-patch always cd's to the root
1140         it seems that's not a drawback.  The drawback of not using --force for
1141         svn-apply, is that it will stop after the first failure, which is rarely
1142         (if ever) the desired behavior.  This just removes the force option
1143         (which was strangely hidden behind --non-interactive).  This should
1144         make for a better user experiance.
1145
1146         * Scripts/webkitpy/common/checkout/checkout.py:
1147         (Checkout.apply_patch):
1148         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1149         (MockCheckout.apply_patch):
1150         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1151         (CheckoutTest.test_chromium_deps):
1152         (CheckoutTest):
1153         (CheckoutTest.test_apply_patch):
1154         * Scripts/webkitpy/tool/commands/download_unittest.py:
1155         (DownloadCommandsTest._default_options):
1156         * Scripts/webkitpy/tool/steps/applypatch.py:
1157         (ApplyPatch.options):
1158         (ApplyPatch.run):
1159         * Scripts/webkitpy/tool/steps/options.py:
1160         (Options):
1161
1162 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1163
1164         nrwt: should be able to run --platform test interactively
1165         https://bugs.webkit.org/show_bug.cgi?id=76959
1166
1167         Reviewed by Adam Barth.
1168
1169         As part of refactoring the Port interfaces, in r103254 I made
1170         passing a Host object to the Port mandatory; previously TestPort
1171         objects would create their own (mock) hosts. However,
1172         new-run-webkit-tests always passed a real Host, not a MockHost,
1173         and so you couldn't run new-run-webkit-tests --platform test
1174         interactively to debug test failures.
1175
1176         This change fixes that by creating a MockHost instead of a real
1177         host if you say --platform test*.
1178
1179         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1180         (main):
1181
1182 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1183
1184         run-webkit-tests --lint-test-files should lint all the ports by default
1185         https://bugs.webkit.org/show_bug.cgi?id=76749
1186
1187         Reviewed by Ojan Vafai.
1188
1189         Currently run-webkit-tests --lint-test-files will only lint the
1190         test_expectations for the single port determined by the command
1191         line options. This is not obvious and can produce unintended results
1192         if you want to lint the chromium port (probably the normal case
1193         for using --lint-test-files) but don't specify a port name or
1194         --chromium.
1195
1196         I think we should probably lint *all* of the ports if no port
1197         name is supplied. This change implements that, and also moves
1198         the linting logic out of the Manager class, since this really
1199         has nothing to do with Managers. It has little to do with
1200         run-webkit-tests, but splitting it into a different script would
1201         introduce compatibility issues. It might make sense to do that
1202         anyway, in a separate patch and combining that with cleaning up
1203         the style checker to share more code.
1204
1205         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1206         (Manager._strip_test_dir_prefix):
1207         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1208         (lint):
1209         (run):
1210         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1211         (LintTest.test_all_configurations): added.
1212         (LintTest.test_lint_test_files): added.
1213         (LintTest.test_lint_test_files__errors): added.
1214         (MainTest.test_lint_test_files): removed.
1215         (MainTest.test_lint_test_files__errors): removed.
1216
1217 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1218
1219         webkitpy: clean up a bunch of test scaffolding
1220         https://bugs.webkit.org/show_bug.cgi?id=76973
1221
1222         Reviewed by Eric Seidel.
1223
1224         There were several helper modules in the webkitpy.test package
1225         that appear to only be used by executive_unittest.py. I am
1226         rolling them all into that file to make that clearer.
1227
1228         * Scripts/webkitpy/common/system/executive_unittest.py:
1229         (ExecutiveTest.test_run_command_args_type):
1230         (ExecutiveTest.test_run_command_with_unicode):
1231         (ExecutiveTest.test_running_pids):
1232         (command_line):
1233         (main):
1234         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1235         * Scripts/webkitpy/test/cat.py: Removed.
1236         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1237         * Scripts/webkitpy/test/echo.py: Removed.
1238         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1239
1240 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1241
1242         webkitpy: clean up a bunch of test scaffolding
1243         https://bugs.webkit.org/show_bug.cgi?id=76973
1244
1245         Reviewed by Eric Seidel.
1246
1247         There were several helper modules in the webkitpy.test package
1248         that appear to only be used by executive_unittest.py. I am
1249         rolling them all into that file to make that clearer.
1250
1251         * Scripts/webkitpy/common/system/executive_unittest.py:
1252         (ExecutiveTest.test_run_command_args_type):
1253         (ExecutiveTest.test_run_command_with_unicode):
1254         (ExecutiveTest.test_running_pids):
1255         (command_line):
1256         (main):
1257         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1258         * Scripts/webkitpy/test/cat.py: Removed.
1259         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1260         * Scripts/webkitpy/test/echo.py: Removed.
1261         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1262
1263 2012-01-25  Eric Seidel  <eric@webkit.org>
1264
1265         Remove Python 2.5 support from WebKit
1266         https://bugs.webkit.org/show_bug.cgi?id=71593
1267
1268         Reviewed by Adam Barth.
1269
1270         Just removing support from this one core file.
1271         I'll commit the rest of the (large) change once we've
1272         gone 24 hours and seen that no bots have exploded.
1273         We can roll out this one change if we break bots
1274         and then roll in the rest once those bots are fixed.
1275
1276         * Scripts/webkitpy/common/system/executive.py:
1277         (Executive.cpu_count):
1278
1279 2012-01-25  Hajime Morita  <morrita@google.com>
1280
1281         ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
1282         https://bugs.webkit.org/show_bug.cgi?id=76863
1283
1284         Reviewed by Dimitri Glazkov.
1285
1286         Added a feature flag.
1287
1288         * Scripts/build-webkit:
1289         * qmake/mkspecs/features/features.prf:
1290
1291 2012-01-25  Martin Robinson  <mrobinson@igalia.com>
1292
1293         [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
1294         https://bugs.webkit.org/show_bug.cgi?id=76344
1295
1296         Reviewed by Sam Weinig.
1297
1298         Add a test verifying that the mouse button during policy decisions for
1299         events not triggered by mouse events is NoButton.
1300
1301         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1302         (TestWebKitAPI::decidePolicyForNavigationAction): Added test.
1303         (TestWebKitAPI::decidePolicyForNewWindowAction): Added test.
1304
1305 2012-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1306
1307         run-perf-tests should timeout sooner
1308         https://bugs.webkit.org/show_bug.cgi?id=77026
1309
1310         Reviewed by Adam Barth.
1311
1312         Bump off the timeout from 10 minutes to 4 minutes.
1313
1314         Also use float instead of str in test result values to compress the size of json files bots upload.
1315
1316         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1317         (PerfTestsRunner._parse_args):
1318         (PerfTestsRunner._process_chromium_style_test_result):
1319         (PerfTestsRunner._process_parser_test_result):
1320         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1321         (test_run_test_set_for_parser_tests):
1322         (test_run_test_set_with_json_output):
1323         (test_run_test_set_with_json_source):
1324
1325 2012-01-25  Enrica Casucci  <enrica@apple.com>
1326
1327         WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
1328         https://bugs.webkit.org/show_bug.cgi?id=76951
1329         <rdar://problem/9325158>
1330
1331         Reviewed by Alexey Proskuryakov.
1332
1333         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
1334         and WebHTMLView.
1335         (TestWebKitAPI::TEST):
1336
1337 2012-01-23  MORITA Hajime  <morrita@google.com>
1338
1339         [Refactoring][Internals] Should have InternalSettings
1340         https://bugs.webkit.org/show_bug.cgi?id=76424
1341
1342         Reviewed by Kent Tamura.
1343
1344         * GNUmakefile.am: Added so new files.
1345
1346 2012-01-25  Takashi Toyoshima  <toyoshim@chromium.org>
1347
1348         webkitpy: new-run-webkit-websocket is broken
1349         https://bugs.webkit.org/show_bug.cgi?id=76999
1350
1351         Reviewed by Dirk Pranke.
1352
1353         r105674 broke new-run-webkit-websocket, since options.chromium
1354         doesn't exist any more. new-run-webkit-httpd was also broken
1355         and already fixed at r105835.
1356         * Scripts/new-run-webkit-websocketserver:
1357         (main):
1358
1359 2012-01-25  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1360
1361         [WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
1362         https://bugs.webkit.org/show_bug.cgi?id=63458
1363
1364         Reviewed by Adam Roben.
1365
1366         Implement the setPopupBlockingEnabled method.
1367
1368         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1369         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1370         (WTR::LayoutTestController::setPopupBlockingEnabled):
1371         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1372
1373 2012-01-24  Balazs Kelemen  <kbalazs@webkit.org>
1374
1375         [Qt] Cleanup testfonts handling
1376         https://bugs.webkit.org/show_bug.cgi?id=76068
1377
1378         Reviewed by Simon Hausmann.
1379
1380         Factor test font initialization into it's own file  so test
1381         font users can share the implementation by adding the file
1382         to their build.
1383         Use fonts.conf from the test font directory to not require the
1384         current directory to be the WebKit root.
1385         Fix the -use-test-fonts option of QtTestBrowser by initializing
1386         the fonts earlier, before it is too late (namely before calling
1387         show on the main window).
1388
1389         * DumpRenderTree/qt/DumpRenderTree.pro:
1390         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1391         (WebCore::DumpRenderTree::open):
1392         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1393         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
1394         (WebKit::initializeTestFonts):
1395         * DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
1396         * DumpRenderTree/qt/fonts.conf: Removed. No need for this since
1397         we will use the one from the test fonts directory.
1398         * DumpRenderTree/qt/main.cpp:
1399         (main): Fix the ifdefs to make it clear that the code to
1400         set up the Dpi has not been ported to Qt5 yet.
1401         * QtTestBrowser/QtTestBrowser.pro:
1402         * QtTestBrowser/launcherwindow.h:
1403         (WindowOptions::WindowOptions):
1404         * QtTestBrowser/main.cpp:
1405         (launcherMain):
1406         (LauncherApplication::handleUserOptions):
1407         * WebKitTestRunner/InjectedBundle/Target.pri:
1408         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1409         (WTR::activateFonts): Remove the code to set up the Dpi
1410         because it does not work with Qt5.
1411
1412 2012-01-25  Simon Hausmann  <simon.hausmann@nokia.com>
1413
1414         [Qt] build-webkit --qt requires a git-svn or SVN checkout.
1415
1416         Reviewed by Tor Arne Vestø.
1417
1418         Don't require it by making svnRevisionForDirectory return "unknown"
1419         instead of bailing out with an error.
1420
1421         * Scripts/VCSUtils.pm:
1422         (svnRevisionForDirectory):
1423
1424 2012-01-25  Adam Barth  <abarth@webkit.org>
1425
1426         Temporarily disable running the unit tests on the Chromium EWS.  These
1427         tests don't work properly (see
1428         https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
1429         blocking the EWS.
1430
1431         * Scripts/webkitpy/common/config/ports.py:
1432         (ChromiumPort):
1433
1434 2012-01-25  Adam Barth  <abarth@webkit.org>
1435
1436         Update results.html version of PixelZoomer
1437         https://bugs.webkit.org/show_bug.cgi?id=76965
1438
1439         Reviewed by Ojan Vafai.
1440
1441         Improve readability as suggested by Ojan.
1442
1443         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
1444
1445 2012-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1446
1447         [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
1448         https://bugs.webkit.org/show_bug.cgi?id=76899
1449
1450         Reviewed by Martin Robinson.
1451
1452         * gtk/generate-gtkdoc:
1453         (get_webkit2_options): WebKitWebLoaderClient has been renamed to
1454         WebKitLoaderClient.
1455
1456 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
1457
1458         Build fix. Trigger Chromium Mac Release (Perf) on new commits.
1459
1460         * BuildSlaveSupport/build.webkit.org-config/config.json:
1461
1462 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
1463
1464         WebKit needs public performance tests running on public bots
1465         https://bugs.webkit.org/show_bug.cgi?id=10266
1466
1467         Reviewed by Adam Barth.
1468
1469         Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
1470         and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.
1471
1472         * BuildSlaveSupport/build.webkit.org-config/config.json:
1473         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1474         (RunAndUploadPerfTests):
1475         (RunAndUploadPerfTests.start):
1476         (UploadPerfTestResults):
1477         (BuildAndPerfTestFactory):
1478         (BuildAndPerfTestFactory.__init__):
1479
1480 2012-01-24  Ojan Vafai  <ojan@chromium.org>
1481
1482         Initializing the browser property of the Bugzilla class takes too long
1483         https://bugs.webkit.org/show_bug.cgi?id=76960
1484
1485         Reviewed by Adam Barth.
1486
1487         Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
1488         on my Mac Pro.
1489
1490         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1491         (Bugzilla.__init__):
1492         (Bugzilla._get_browser):
1493         (Bugzilla):
1494         (Bugzilla._set_browser):
1495
1496 2012-01-24  Mark Rowe  <mrowe@apple.com>
1497
1498         Death to JavaScriptGlue.
1499
1500         Rubber-stamped by Geoffrey Garen.
1501
1502         * BuildSlaveSupport/build-launcher-app:
1503         (copyNightlyLauncher):
1504         * Scripts/build-webkit:
1505         * Scripts/do-file-rename:
1506         * Scripts/do-webcore-rename:
1507         * Scripts/webkitpy/common/config/build.py:
1508         (_should_file_trigger_build):
1509         * Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
1510         path in conjunction with a cross-platform path.
1511         (ShouldBuildTest):
1512
1513 2012-01-24  Kentaro Hara  <haraken@chromium.org>
1514
1515         webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
1516         https://bugs.webkit.org/show_bug.cgi?id=75836
1517
1518         Reviewed by David Kilzer.
1519
1520         Previously parser_unittests.pl can just test the returned value of
1521         get_function_line_ranges() in prepare-ChangeLog. This patch fixes
1522         parser_unittests.pl so that it also tests the stdout and stderr of
1523         get_function_line_ranges().
1524
1525         This patch adds css_unittests_warning.css, which contains test cases
1526         for warning messages of the CSS parser of prepare-ChangeLog.
1527
1528         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1529         (captureOutput): Captures the stdout and stderr of a given method.
1530         (convertAbsolutepathToWebKitPath): Converts absolute paths in a given
1531         string to relative paths.
1532
1533         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
1534         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
1535         (element1):
1536         (element2):
1537         (element3):
1538         (element4):
1539         ():
1540         (element5):
1541         (element6):
1542
1543         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1544         Just updated the test results, i.e. added stdout and stderr results.
1545         No essential changes in the test results.
1546         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
1547         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
1548         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
1549         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
1550         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.
1551
1552 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
1553
1554         webkitpy: new-run-webkit-httpd is broken
1555         https://bugs.webkit.org/show_bug.cgi?id=76963
1556
1557         Reviewed by Adam Barth.
1558
1559         r105674 broke new-run-webkit-httpd, since options.chromium
1560         doesn't exist any more. We didn't catch this because we don't
1561         run the integration tests by default anywhere :(.
1562
1563         * Scripts/new-run-webkit-httpd:
1564         (run):
1565         (main):
1566
1567 2012-01-24  Adam Barth  <abarth@webkit.org>
1568
1569         garden-o-matic pixel zoomer should let you look at every pixel of the image
1570         https://bugs.webkit.org/show_bug.cgi?id=76962
1571
1572         Reviewed by Ojan Vafai.
1573
1574         Previously, you couldn't get up to the right and bottom pixels.
1575
1576         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
1577
1578 2012-01-24  Enrica Casucci  <enrica@apple.com>
1579
1580         WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
1581         https://bugs.webkit.org/show_bug.cgi?id=76951
1582         <rdar://problem/9325158>
1583
1584         Added test to verify that WebHTMLView supports the typingAttributes method and that it
1585         works as expected.
1586         
1587         Reviewed by Alexey Proskuryakov.
1588
1589         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
1590         (TestWebKitAPI::TEST):
1591
1592 2012-01-24  James Robinson  <jamesr@chromium.org>
1593
1594         Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
1595         https://bugs.webkit.org/show_bug.cgi?id=76884
1596
1597         Reviewed by Adam Barth.
1598
1599         * Scripts/webkitpy/tool/bot/irc_command.py:
1600         (Rollout.execute):
1601         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1602         (SheriffIRCBotTest.test_rollout):
1603         (SheriffIRCBotTest.test_revert):
1604         (SheriffIRCBotTest.test_multi_rollout):
1605         (SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
1606         (SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
1607         (SheriffIRCBotTest.test_rollout_invalidate_reason):
1608         (test_multi_rollout_invalidate_reason):
1609
1610 2012-01-24  Kentaro Hara  <haraken@chromium.org>
1611
1612         The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
1613         https://bugs.webkit.org/show_bug.cgi?id=75531
1614
1615         Reviewed by David Kilzer.
1616
1617         Previously, the cpp parser of prepare-ChangeLog could not detect a change
1618         outside methods. Consider the following cpp file.
1619
1620             namespace N {
1621             int a;     // this change does not appear on ChangeLog.
1622             class C {
1623                 int b;     // this change does not appear on ChangeLog.
1624                 void f()
1625                 {
1626                     int c;     // this change appears on ChangeLog.
1627                 }
1628                 int d;     // this change does not appear on ChangeLog.
1629             };
1630             int e;     // this change does not appear on ChangeLog.
1631             };
1632
1633         The previous prepare-ChangeLog outputs just methods in which a change is found:
1634             (N::C::f):
1635
1636         This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
1637         and methods in which a change is found:
1638             (N):
1639             (N::C):
1640             (N::C::f):
1641
1642         * Scripts/prepare-ChangeLog:
1643         (get_function_line_ranges_for_cpp): Modified as described above.
1644
1645         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
1646         (Class104):
1647         (Class105):
1648         (Class106):
1649         (Class106::func32):
1650         (Class106::func33):
1651         (NameSpace3):
1652         (NameSpace4):
1653         (NameSpace5):
1654         (NameSpace6):
1655         (Class107):
1656         (NameSpace5::NameSpace6::Class107::func34):
1657         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1658
1659 2012-01-24  Kentaro Hara  <haraken@chromium.org>
1660
1661         prepare-ChangeLog outputs warnings for top-level { ... } blocks
1662         https://bugs.webkit.org/show_bug.cgi?id=75943
1663
1664         Reviewed by David Kilzer.
1665
1666         Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
1667         because it does not distinguish '}' at the end of a subroutine
1668         with '}' at the end of a if or for statement.
1669
1670         foo.pl:
1671             if (1) {
1672             }
1673             for (@v) {
1674             }
1675
1676         output:
1677             nested functions found at top-level at foo.pl:2
1678             nested functions found at top-level at foo.pl:4
1679
1680         This patch fixes the bug.
1681
1682         * Scripts/prepare-ChangeLog:
1683         (get_function_line_ranges_for_perl):
1684         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1685         Added test cases. No change in the test results.
1686
1687 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
1688
1689         r105674 broke check-webkit-style for chromium's test_expectations.
1690
1691         Unreviewed, build fix.
1692         
1693         We now need to pass in a platform name of 'chromium' if we want
1694         the chromium port; options.chromium is no longer recognized. I
1695         will follow this patch up with a separate patch that has a test,
1696         but this at least fixes the build.
1697
1698         * Scripts/webkitpy/style/checkers/test_expectations.py:
1699         (TestExpectationsChecker._determine_port_from_exepectations_path):
1700
1701 2012-01-20  Ojan Vafai  <ojan@chromium.org>
1702
1703         check-webkit-style of the chromium test_expectations.txt file takes too long
1704         https://bugs.webkit.org/show_bug.cgi?id=76745
1705
1706         Reviewed by Dimitri Glazkov.
1707
1708         When in lint mode, have TestExpectations test all configurations instead
1709         of looping over each configuration. This also has the benefit of making
1710         the error output considerably more concise.
1711
1712         Also, got rid of the double-printing of errors when linting through check-webkit-style.
1713
1714         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1715         (Manager.lint):
1716         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1717         (TestExpectations._report_errors):
1718         (TestExpectations._add_expectations):
1719         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1720         (test_parse_error_nonfatal):
1721         (test_error_on_different_platform):
1722         * Scripts/webkitpy/style/checkers/test_expectations.py:
1723         (TestExpectationsChecker.check_test_expectations):
1724         (TestExpectationsChecker.check):
1725         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1726         (TestExpectationsTestCase.test_determine_port_from_exepectations_path):
1727         (TestExpectationsTestCase.assert_lines_lint):
1728
1729 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
1730
1731         Another build fix attempt after r105543.
1732
1733         * Scripts/webkitpy/common/net/file_uploader.py:
1734         (FileUploader.upload_as_multipart_form_data):
1735
1736 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
1737
1738         Build fix attempt after r105543.
1739
1740         * Scripts/webkitpy/common/net/file_uploader.py:
1741         (FileUploader.upload_as_multipart_form_data):
1742
1743 2012-01-24  Vincent Scheib  <scheib@chromium.org>
1744
1745         [Chromium] Add Pointer Lock test hooks and mock implementation to DumpRenderTree
1746         https://bugs.webkit.org/show_bug.cgi?id=76411
1747
1748         Reviewed by Adam Barth.
1749
1750         Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762
1751         into a series of patches, this change adds a trivial
1752         pointer lock implementation to the Chromium port's DumpRenderTree
1753         and exposes LayoutTestController hooks to force failure conditions.
1754
1755         * DumpRenderTree/chromium/LayoutTestController.cpp:
1756         (LayoutTestController::LayoutTestController):
1757         (LayoutTestController::didLosePointerLock):
1758         (LayoutTestController::setPointerLockWillFailAsynchronously):
1759         (LayoutTestController::setPointerLockWillFailSynchronously):
1760         * DumpRenderTree/chromium/LayoutTestController.h:
1761         * DumpRenderTree/chromium/WebViewHost.cpp:
1762         (WebViewHost::requestPointerLock):
1763         (WebViewHost::requestPointerUnlock):
1764         (WebViewHost::isPointerLocked):
1765         (WebViewHost::didCompletePointerLock):
1766         (WebViewHost::didNotCompletePointerLock):
1767         (WebViewHost::didLosePointerLock):
1768         (WebViewHost::reset):
1769         * DumpRenderTree/chromium/WebViewHost.h:
1770         (WebViewHost::setPointerLockWillFailAsynchronously):
1771         (WebViewHost::setPointerLockWillFailSynchronously):
1772
1773 2012-01-24  Mario Sanchez Prada  <msanchez@igalia.com>
1774
1775         Unreviewed, skip WK2 API test timing out on some GTK bots.
1776
1777         WebKit2APITests/TestDownloads is consistently timing out on the
1778         32bit release and 64bit debug bots.
1779
1780         * Scripts/run-gtk-tests:
1781         (TestRunner): Skip WebKit2APITests/TestDownloads.
1782
1783 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
1784
1785         [Qt] Fix the build with the newes Qt5 hashes
1786         https://bugs.webkit.org/show_bug.cgi?id=76657
1787
1788         Reviewed by Simon Hausmann.
1789
1790         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1791         (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
1792         for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
1793
1794 2012-01-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1795
1796         [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
1797
1798         We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
1799         building with MinGW inside cmd.exe will require the same construct. Instead
1800         we assume that when the first character in PWD is a '/' we're running under
1801         Cygwin, and use the normal unix way of setting environment variables.
1802
1803         Reviewed by Simon Hausmann.
1804
1805         * qmake/mkspecs/features/default_pre.prf:
1806
1807 2012-01-24  Simon Hausmann  <simon.hausmann@nokia.com>
1808
1809         Some qmake build files must include Qt5's "quick" module.
1810         https://bugs.webkit.org/show_bug.cgi?id=76671
1811
1812         Unreviewed build fix.
1813
1814         * MiniBrowser/qt/MiniBrowser.pro:
1815         * WebKitTestRunner/Target.pri:
1816
1817 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
1818
1819         [Qt] Fix the event timestamps for touch mocking
1820
1821         Reviewed by Simon Hausmann.
1822
1823         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1824         (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
1825         timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
1826
1827 2012-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1828
1829         [GTK] Implement DownloadClient in WebKit2 GTK+ API
1830         https://bugs.webkit.org/show_bug.cgi?id=72952
1831
1832         Reviewed by Martin Robinson.
1833
1834         * gtk/generate-gtkdoc:
1835         (get_webkit2_options): Ignore WebKitDownloadClient.
1836
1837 2012-01-23  Zan Dobersek  <zandobersek@gmail.com>
1838
1839         [GTK] editing/deleting/5408255.html results are incorrect
1840         https://bugs.webkit.org/show_bug.cgi?id=53644
1841
1842         Reviewed by Martin Robinson.
1843
1844         WEBKIT_TOP_LEVEL environment variable is now set directly in either
1845         WebKitTestRunner or DumpRenderTree through usage of a compilation-time
1846         macro. This way both tools can be run outside the test harness without
1847         the need to manually set the environment variable.
1848
1849         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1850         (getTopLevelPath):
1851         * GNUmakefile.am:
1852         * Scripts/webkitpy/layout_tests/port/gtk.py:
1853         (GtkPort.setup_environ_for_server):
1854         * WebKitTestRunner/GNUmakefile.am:
1855         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1856         (WTR::InjectedBundle::platformInitialize):
1857
1858 2012-01-23  Dmitry Lomov  <dslomov@google.com>
1859
1860         [Chromium] Implement layoutTestController.workerThreadCount in DRT
1861         https://bugs.webkit.org/show_bug.cgi?id=74653.
1862
1863         Reviewed by Darin Fisher.
1864
1865         * DumpRenderTree/chromium/LayoutTestController.cpp:
1866         (LayoutTestController::LayoutTestController):
1867         (LayoutTestController::workerThreadCount):
1868         * DumpRenderTree/chromium/LayoutTestController.h:
1869
1870 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
1871
1872         nrwt: make --chromium work like --qt
1873         https://bugs.webkit.org/show_bug.cgi?id=76875
1874
1875         Reviewed by Adam Barth.
1876
1877         --chromium used to have to be handled differently from --qt
1878         due to the way the PortFactory was implemented; there's not
1879         really a good reason for that any more so this patch makes
1880         things slightly more consistent and eliminates the
1881         options.chromium flag (--chromium is now truly a synonym for
1882         --platform chromium).
1883
1884         * Scripts/webkitpy/layout_tests/port/factory.py:
1885         (PortFactory._default_port):
1886         (PortFactory.get):
1887         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1888         (FactoryTest.setUp):
1889         (FactoryTest.test_chromium_mac):
1890         (FactoryTest.test_chromium_linux):
1891         (FactoryTest.test_chromium_win):
1892         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1893         (parse_args):
1894
1895 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
1896
1897         run-webkit-tests needs to propagate --chromium
1898         https://bugs.webkit.org/show_bug.cgi?id=76870
1899
1900         Reviewed by Eric Seidel.
1901
1902         run-webkit-tests removes '--chromium' argument from @ARGV when
1903         determining which port to run, which means that that doesn't
1904         propagate to new-run-webkit-tests. That's bad (and is handled
1905         for the other ports by re-adding the flag, but apparently we're
1906         just now noticing for Chromium).
1907
1908         * Scripts/run-webkit-tests:
1909
1910 2012-01-23  Brian Weinstein  <bweinstein@apple.com>
1911
1912         More build fixing after r105646.
1913
1914         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1915         (TestWebKitAPI::TestNode::key):
1916
1917 2012-01-23  Gavin Barraclough  <barraclough@apple.com>
1918
1919         Unreviewed build fix - r105646 broke this.
1920
1921         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1922         (TestWebKitAPI::TestNode::TestNode):
1923         (TestWebKitAPI::TestNode::key):
1924         (TestWebKitAPI::RedBlackTreeTest::assertEqual):
1925         (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
1926         (TestWebKitAPI::RedBlackTreeTest::testDriver):
1927
1928 2012-01-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1929
1930         Unreviewed, rolling out r105658.
1931         http://trac.webkit.org/changeset/105658
1932         https://bugs.webkit.org/show_bug.cgi?id=76883
1933
1934         We want this eventually, but not right at this moment
1935         (Requested by abarth on #webkit).
1936
1937         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1938
1939 2012-01-23  Adam Barth  <abarth@webkit.org>
1940
1941         garden-o-matic should support Chromium Mac Lion
1942         https://bugs.webkit.org/show_bug.cgi?id=76880
1943
1944         Reviewed by Eric Seidel.
1945
1946         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1947
1948 2012-01-23  Emil A Eklund  <eae@chromium.org>
1949
1950         check-webkit-style whitespace/operators triggers on overloaded division operator
1951         https://bugs.webkit.org/show_bug.cgi?id=76650
1952
1953         Reviewed by Darin Adler.
1954
1955         * Scripts/webkitpy/style/checkers/cpp.py:
1956         (check_spacing):
1957         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1958         (CppStyleTest.test_operator_methods):
1959
1960 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
1961
1962         run-perf-tests should report server-side errors
1963         https://bugs.webkit.org/show_bug.cgi?id=76802
1964
1965         Reviewed by Tony Chang.
1966
1967         Report errors whenever server's response doesn't match "OK".
1968
1969         * Scripts/webkitpy/common/net/file_uploader.py:
1970         (FileUploader.upload_single_text_file):
1971         (FileUploader.upload_as_multipart_form_data):
1972         (FileUploader._upload_data.callback):
1973         (FileUploader):
1974         (FileUploader._upload_data):
1975         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1976         (PerfTestsRunner._upload_json):
1977         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1978         (test_upload_json):
1979         (test_upload_json.MockFileUploader.upload_single_text_file):
1980
1981 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1982
1983         run-perf-tests ignore Skipped list on chromium
1984         https://bugs.webkit.org/show_bug.cgi?id=76764
1985
1986         Reviewed by Dirk Pranke.
1987
1988         Move skipped_perf_tests from WebKit port to Base port so that Chromium port
1989         can also find skipped list. Chromium port only uses test_expectations.txt for
1990         layout tests but performacne tests don't use test_expectations.txt so Chromium port
1991         also needs to use Skipped list.
1992
1993         * Scripts/webkitpy/layout_tests/port/base.py:
1994         (Port._tests_from_skipped_file_contents):
1995         (Port):
1996         (Port._expectations_from_skipped_files):
1997         (Port.skipped_perf_tests):
1998         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1999         (PortTest.test_skipped_perf_tests):
2000         (PortTest.test_skipped_perf_tests.add_text_file):
2001         * Scripts/webkitpy/layout_tests/port/webkit.py:
2002         (WebKitPort._skipped_tests_for_unsupported_features):
2003         (WebKitPort._skipped_file_search_paths):
2004         (WebKitPort.skipped_layout_tests):
2005
2006 2012-01-23  Andy Estes  <aestes@apple.com>
2007
2008         Fix the build after r105635.
2009
2010         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2011         (TestWebKitAPI::TEST):
2012
2013 2012-01-23  Xianzhu Wang  <wangxianzhu@chromium.org>
2014
2015         Basic enhancements to StringBuilder
2016         https://bugs.webkit.org/show_bug.cgi?id=67081
2017
2018         Reviewed by Darin Adler.
2019
2020         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2021         (TestWebKitAPI::TEST):
2022
2023 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
2024
2025         [GTK] run-gtk-tests randomly fails while running the xprop comand
2026         https://bugs.webkit.org/show_bug.cgi?id=76817
2027
2028         Reviewed by Gustavo Noronha Silva.
2029
2030         No need to use xprop to remove the AT_SPI_BUS property since
2031         run-gtk-tests will always run new instances of Xvfb.
2032
2033         * Scripts/run-gtk-tests:
2034         (TestRunner): Unskip TestWebKitAccessibility.
2035         (TestRunner.run): Uncomment lines for launching the accessibility
2036         bus and registry daemon, and remove lines for running xprop.
2037
2038 2012-01-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2039
2040         [Qt] Don't warn about override and final being C++11 extensions
2041
2042         Clang will emit a warning when these extensions are used without passing
2043         --std=c++11, but we use feature checking to decide if we have the right
2044         extensions, so we can safely ignore these warnings. The XCode and Windows
2045         project files have the same workaround.
2046
2047         The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
2048         we only have one extra compiler for Objective-C, which is also used for
2049         Objective-C++ sources, so we have to pass the flag, even if it doesn't
2050         make sense for Objective-C.
2051
2052         Reviewed by Simon Hausmann.
2053
2054         * qmake/mkspecs/features/unix/default_post.prf:
2055
2056 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2057
2058         [Qt] Change how build-webkit decides when to do full incremental builds
2059
2060         Instead of relying on update-webkit (which isn't run on the bots) to
2061         decide when to do a full incremental build (make qmake), we let the
2062         build-webkit script itself check the current SVN revision against the
2063         previous build (by storing it in .webkit.config).
2064
2065         If the two differ we assume a full incremental build is needed, since
2066         the new revisions might have introduced problematic things like new
2067         Q_OBJECT macros. If not, we assume the developer is doing changes
2068         locally, and revert to doing a plain 'make'.
2069
2070         In addition, when the build fails in the latter case, we inform the
2071         developer of possible pitfalls and how to manually run 'make qmake'.
2072
2073         Reviewed by Ossy.
2074
2075         * Scripts/update-webkit:
2076         * Scripts/webkitdirs.pm:
2077         (buildQMakeProjects):
2078
2079 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
2080
2081         [GTK] run-gtk-tests randomly fails while running the xprop comand
2082         https://bugs.webkit.org/show_bug.cgi?id=76817
2083
2084         Reviewed by Philippe Normand.
2085
2086         Temporarily comment the lines related to launching the ATSPI bus
2087         and registry daemon, which are making the bots to fail randomly.
2088
2089         * Scripts/run-gtk-tests:
2090         (TestRunner): Skip TestWebKitAccessibility, as it won't run
2091         properly if the ATSPI infrastructure is not properly initialized.
2092         (TestRunner.run): Comment lines related to initialization of ATSPI.
2093
2094 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2095
2096         Windows python test build fix.
2097
2098         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2099         (PerfTestsRunner.__init__):
2100
2101 2012-01-22  Sergio Villar Senin  <svillar@igalia.com>
2102
2103         [GTK] DumpRenderTree converts "file:///" to a path differently
2104         https://bugs.webkit.org/show_bug.cgi?id=76631
2105
2106         Reviewed by Martin Robinson.
2107
2108         DumpRenderTree should print "/" as the last path component if the
2109         path is a lone slash instead of empty output.
2110
2111         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2112         (webViewConsoleMessage):
2113
2114 2012-01-20  David Levin  <levin@chromium.org>
2115
2116         The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
2117         https://bugs.webkit.org/show_bug.cgi?id=76752
2118
2119         Reviewed by Eric Seidel.
2120
2121         * Scripts/webkitpy/style/checkers/cpp.py:
2122         (check_for_leaky_patterns):
2123         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2124         (LeakyPatternTest.test_create_dc):
2125         (LeakyPatternTest.test_create_compatible_dc):
2126
2127 2012-01-20  Shawn Singh  <shawnsingh@chromium.org>
2128
2129         Changed my status in commiters.py
2130
2131         Unreviewed.
2132
2133         * Scripts/webkitpy/common/config/committers.py:
2134
2135 2012-01-20  Ojan Vafai  <ojan@chromium.org>
2136
2137         run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
2138         https://bugs.webkit.org/show_bug.cgi?id=76748
2139
2140         Reviewed by Ryosuke Niwa.
2141
2142         It crawls the whole subtree and then doesn't use the data. Cutting this out
2143         saves 4 seconds warm and 17 seconds cold on my Mac Pro.
2144
2145         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2146         (run):
2147
2148 2012-01-20  Adam Barth  <abarth@webkit.org>
2149
2150         Another tiny tweak to the garden-o-matic CSS.  This makes things line
2151         up slightly nicer when there aren't any failures.
2152
2153         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2154         (#summary):
2155
2156 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
2157
2158         run-perf-tests should support --test-results-server option
2159         https://bugs.webkit.org/show_bug.cgi?id=76680
2160
2161         Reviewed by Adam Barth.
2162
2163         Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
2164         to be used by perf bots. Also refactor file_uploader as needed.
2165
2166         * Scripts/webkitpy/common/net/file_uploader.py:
2167         (FileUploader.__init__):
2168         (FileUploader.upload_single_file):
2169         (FileUploader.upload_as_multipart_form_data):
2170         (FileUploader):
2171         (FileUploader._upload_data):
2172         (FileUploader._upload_data.callback):
2173         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2174         (JSONResultsGeneratorBase.upload_json_files):
2175         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2176         (PerfTestsRunner):
2177         (PerfTestsRunner._parse_args):
2178         (PerfTestsRunner.run):
2179         (PerfTestsRunner._generate_json):
2180         (PerfTestsRunner._upload_json):
2181         (PerfTestsRunner._run_tests_set):
2182         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2183         (create_runner):
2184         (test_run_with_upload_json):
2185         (test_run_with_upload_json.mock_upload_json):
2186         (test_upload_json):
2187         (test_upload_json.MockFileUploader):
2188         (test_upload_json.MockFileUploader.__init__):
2189         (test_upload_json.MockFileUploader.upload_single_file):
2190         (test_parse_args):
2191
2192 2012-01-20  Adam Barth  <abarth@webkit.org>
2193
2194         The party time image overlaps real content!  This patch makes the
2195         image centered vertically.
2196
2197         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2198         (#onebar.partytime #summary):
2199
2200 2012-01-19  Ojan Vafai  <ojan@chromium.org>
2201
2202         Refactor TestExpectationsParser in preparation for caching the results
2203         https://bugs.webkit.org/show_bug.cgi?id=76669
2204
2205         Reviewed by Dimitri Glazkov.
2206
2207         Make everything private expect for the parse method. 
2208         Eventually, we'll need the expectations lines to not be modified
2209         outside of TestExpectationsParser so we can cache the results.
2210         This makes check-webkit-style of the chromium test_expectations.txt file
2211         go from ~17 seconds to ~12 seconds on my Mac Pro.
2212
2213         This patch is just a refactor in preparation, so no new tests.
2214
2215         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2216         (TestExpectationEditorTests.make_parsed_expectation_lines):
2217         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2218         (TestExpectationParser.parse):
2219         (TestExpectationParser):
2220         (TestExpectationParser._parse_line):
2221         (TestExpectationParser._tokenize):
2222         (TestExpectationParser._tokenize_list):
2223         (TestExpectationsModel._clear_expectations_for_test):
2224         (TestExpectations.__init__):
2225         (TestExpectations._add_expectations):
2226         (TestExpectations._add_skipped_tests):
2227         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2228         (TestExpectationParserTests.test_tokenize_blank):
2229         (TestExpectationParserTests.test_tokenize_missing_colon):
2230         (TestExpectationParserTests.test_tokenize_extra_colon):
2231         (TestExpectationParserTests.test_tokenize_empty_comment):
2232         (TestExpectationParserTests.test_tokenize_comment):
2233         (TestExpectationParserTests.test_tokenize_missing_equal):
2234         (TestExpectationParserTests.test_tokenize_extra_equal):
2235         (TestExpectationParserTests.test_tokenize_valid):
2236         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2237         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2238         (TestExpectationParserTests.test_parse_empty_string):
2239         (TestExpectationSerializerTests.assert_round_trip):
2240         (TestExpectationSerializerTests.assert_list_round_trip):
2241         * Scripts/webkitpy/tool/commands/expectations.py:
2242         (OptimizeExpectations.execute):
2243         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2244         (GardeningExpectationsUpdater.update_expectations):
2245
2246 2012-01-20  Adam Barth  <abarth@webkit.org>
2247
2248         Follow-up to previous patch: don't produce NaN when the revision number
2249         is missing.
2250
2251         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2252         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2253
2254 2012-01-20  Adam Barth  <abarth@webkit.org>
2255
2256         Garden-o-matic should tell me which revisions have been checked by all the bots
2257         https://bugs.webkit.org/show_bug.cgi?id=76722
2258
2259         Reviewed by Dimitri Glazkov.
2260
2261         This information helps me know when it's safe for me to roll a
2262         candidate revision.
2263
2264         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2266         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2267
2268 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2269
2270         build-webkit: Don't spit out congratulations message on Ctrl+C
2271
2272         Reviewed by Andreas Kling.
2273
2274         * Scripts/build-webkit:
2275
2276 2012-01-20  Philippe Normand  <pnormand@igalia.com>
2277
2278         [GTK] Allow extra jhbuild modulesets
2279         https://bugs.webkit.org/show_bug.cgi?id=76691
2280
2281         Reviewed by Gustavo Noronha Silva.
2282
2283         * gtk/jhbuildrc: Extra modulesets and modules can be added in
2284         JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
2285         env variables respectively. Use comma-separated values. Example:
2286         WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
2287
2288 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
2289
2290         [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
2291         https://bugs.webkit.org/show_bug.cgi?id=72589
2292
2293         Reviewed by Martin Robinson.
2294
2295         Ensure the accessibility infrastructure is available when running
2296         the unit tests, otherwise WK2's accessibility tests won't work.
2297
2298         * Scripts/run-gtk-tests:
2299         (TestRunner):
2300         (TestRunner._lookup_atspi2_binary): New. Looks for the directory
2301         where at-spi2's stuff is located (like at-spi-bus-launcher and
2302         at-spi2-registryd).
2303         (TestRunner.run): Initialize the accessibility infrastructure.
2304
2305         * gtk/generate-gtkdoc:
2306         (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
2307
2308         * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
2309
2310 2012-01-20  Hayato Ito  <hayato@chromium.org>
2311
2312         Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
2313         https://bugs.webkit.org/show_bug.cgi?id=76353
2314
2315         Reviewed by Hajime Morita.
2316
2317         Add ShadowRoot.idl, which is enabled only on chromium port since this is
2318         under development feature.
2319         ShadowRoot.idl contains minimum API so that we can test it.
2320         Other APIs should be added on other changes so that we can isolate issues.
2321
2322         * DumpRenderTree/chromium/TestShell.cpp:
2323         (TestShell::TestShell):
2324
2325 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
2326
2327         [GTK] GTK's DRT not to log events for already defunct objects
2328         https://bugs.webkit.org/show_bug.cgi?id=76620
2329
2330         Reviewed by Martin Robinson.
2331
2332         Do not log 'state-change:defunct' events.
2333
2334         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2335         (printAccessibilityEvent): Early return if a
2336         'state-change:defunct' signal is passed.
2337         (axObjectEventListener): Pass the signal name and value in
2338         separate parameters to printAccessibilityEvent.
2339
2340 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
2341
2342         Unreviewed build fix. Wrong variable being used as the cwd for git
2343         remote update command.
2344
2345         * gtk/run-with-jhbuild:
2346         (update_jhbuild):
2347
2348 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
2349
2350         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
2351         https://bugs.webkit.org/show_bug.cgi?id=76585
2352
2353         Reviewed by Martin Robinson.
2354
2355         This allows us to specify a minimum version of jhbuild required,
2356         while also providing stability against changes done to the master
2357         branch, by letting us choose what is the exact version that will
2358         be used.
2359
2360         * gtk/run-with-jhbuild: refactored for more hackability and easier
2361         reading
2362         (jhbuild_installed): checks whether jhbuild is installed
2363         (jhbuild_cloned): checks whether jhbuild has been cloned
2364         (jhbuild_at_expected_revision): checks whether jhbuild is at the
2365         expected revision
2366         (update_jhbuild): brings jhbuild to the expected revision
2367         (clone_jhbuild): clones jhbuild
2368         (install_jhbuild): build and installs jhbuild
2369         (update_webkitgtk_libs): runs update-webkitgtk-libs
2370         (ensure_jhbuild): high-level logic to decide whether and which of
2371         the steps above are executed
2372
2373 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
2374
2375         [WK2] DumpRenderTree converts "file:///" to a path differently
2376         https://bugs.webkit.org/show_bug.cgi?id=76653
2377
2378         Reviewed by John Sullivan.
2379
2380         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
2381         Do print a slash if there are no path components.
2382
2383 2012-01-19  Eric Seidel  <eric@webkit.org>
2384
2385         webkit-patch cannot rollout patches without changelog/bug number
2386         https://bugs.webkit.org/show_bug.cgi?id=75962
2387
2388         Reviewed by Adam Barth.
2389
2390         * Scripts/webkitpy/tool/commands/download.py:
2391         (AbstractRolloutPrepCommand._prepare_state):
2392         * Scripts/webkitpy/tool/commands/download_unittest.py:
2393         (AbstractRolloutPrepCommandTest.test_prepare_state):
2394
2395 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
2396
2397         [WK2] fast/url/degenerate-file-base.html fails
2398         https://bugs.webkit.org/show_bug.cgi?id=76619
2399
2400         Reviewed by Adam Roben.
2401
2402         A URL generated form local path for loading had an extra slash, making document.URL
2403         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
2404
2405         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
2406
2407 2012-01-18  Ojan Vafai  <ojan@chromium.org>
2408
2409         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
2410         https://bugs.webkit.org/show_bug.cgi?id=76510
2411
2412         Reviewed by Adam Barth.
2413
2414         Unlike other style rules, if you get the syntax of the test_expectations.txt
2415         file wrong, the layout tests won't run. Also, this check is simple and only
2416         slows down committing if you actually modify one of the test_expectations.txt files.
2417
2418         * Scripts/webkitpy/style/checkers/test_expectations.py:
2419         (TestExpectationsChecker.check_test_expectations):
2420         (TestExpectationsChecker.check):
2421         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2422         (TestExpectationsTestCase.test_check_covers_all_configurations):
2423         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
2424         (TestExpectationsTestCase):
2425         (assert_lines_lint):
2426
2427 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
2428
2429         Build fix. Revert an unintentional change to WebKitDriver in r105443.
2430
2431         * Scripts/webkitpy/layout_tests/port/driver.py:
2432         (DriverProxy.__init__):
2433
2434 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
2435
2436         remove the duplicated build rules from WebKit.gyp, Tools.gyp
2437         https://bugs.webkit.org/show_bug.cgi?id=73384
2438
2439         Reviewed by Tony Chang.
2440
2441         This patch removes the no-longer-necessary conditional logic for
2442         build_webkit_exes_from_webkit_gyp; we now always build the exes
2443         from their own dedicated gyp files.
2444
2445         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2446
2447 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
2448
2449         make-new-script-test should work with HTTP tests
2450         https://bugs.webkit.org/show_bug.cgi?id=76603
2451
2452         Reviewed by Adam Roben.
2453
2454         * Scripts/make-new-script-test:
2455         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
2456         now also creates absolute paths for HTTP.
2457
2458 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
2459
2460         Some perf tests time out when ran by run-perf-tests
2461         https://bugs.webkit.org/show_bug.cgi?id=76612
2462
2463         Reviewed by Dirk Pranke and Eric Seidel.
2464
2465         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
2466         Otherwise some tests such as Parser/xml-parser.html will timeout.
2467
2468         --no-timeout option is currently supported by Chromium and Mac ports.
2469
2470         * Scripts/webkitpy/layout_tests/port/base.py:
2471         (Port.to.create_driver):
2472         * Scripts/webkitpy/layout_tests/port/chromium.py:
2473         (ChromiumDriver.__init__):
2474         (ChromiumDriver._wrapper_options):
2475         * Scripts/webkitpy/layout_tests/port/driver.py:
2476         (Driver.__init__):
2477         (DriverProxy.__init__):
2478         * Scripts/webkitpy/layout_tests/port/webkit.py:
2479         (WebKitDriver.__init__):
2480         (WebKitDriver.cmd_line):
2481         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2482         (WebKitDriverTest.test_read_binary_block):
2483         (WebKitDriverTest):
2484         (WebKitDriverTest.test_no_timeout):
2485         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2486         (get_tests_run.RecordingTestDriver.__init__):
2487         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2488         (PerfTestsRunner._parse_args):
2489         (PerfTestsRunner._run_tests_set):
2490         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2491         (create_runner):
2492
2493 2012-01-19  Ben Wells  <benwells@chromium.org>
2494
2495         Add support for window.print to chromium DRT
2496         https://bugs.webkit.org/show_bug.cgi?id=76479
2497
2498         When used in a test window.print goes into print mode and then
2499         straight out again. This will allow the afterprint event to be
2500         tested by having the afterprint event happen before the dump
2501         happens.
2502
2503         Reviewed by Mihai Parparita.
2504
2505         * DumpRenderTree/chromium/WebViewHost.cpp:
2506         (WebViewHost::printPage):
2507         * DumpRenderTree/chromium/WebViewHost.h:
2508
2509 2012-01-18  Enrica Casucci  <enrica@apple.com>
2510
2511         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
2512         https://bugs.webkit.org/show_bug.cgi?id=76588
2513         <rdar://problem/9325183>
2514
2515         Added test.
2516         
2517         Reviewed by Dan Bernstein.
2518
2519         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2520         (TestWebKitAPI::TEST):
2521
2522 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2523
2524         [Qt] Do full incremental builds until bots use update-webkit
2525
2526         Rubber-stamped by Simon Hausmann.
2527
2528         * Scripts/webkitdirs.pm:
2529         (buildQMakeProjects):
2530
2531 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2532
2533         Fix the Qt build
2534
2535         Unreviewed build fix.
2536
2537         * Scripts/webkitdirs.pm:
2538         (buildQMakeProjects):
2539
2540 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2541
2542         [Qt] Make build-webkit always do safe incremental builds after update-webkit
2543
2544         When building against Qt5 with GCC we would just run 'make' in the build dir,
2545         and rely on the dependency files output by GCC (-MD) to handle dependency
2546         tracking, but that fails for special-cases like adding a Q_OBJECT macro
2547         to a header.
2548
2549         To guarantee that an incrmental build will work, we have to run 'make qmake',
2550         which we now do on every build-webkit that's followed by a successful run
2551         of update-webkit. The reasoning is that update-webkit can result in such
2552         potential corner-cases being applied, and since we can't know for sure
2553         unless we inspect the diff and account for all the corner cases we assume
2554         the worst and always run 'make qmake'.
2555
2556         After a succesful run of build-webkit we proceed to do just 'make' for any
2557         subsequent runs, since we assume that the developer knows what kind of
2558         changes he/she is doing, and when a 'make qmake' is needed.
2559
2560         Reviewed by Simon Hausmann.
2561
2562         * Scripts/update-webkit:
2563         * Scripts/webkitdirs.pm:
2564         (determineCurrentSVNRevision):
2565         (currentSVNRevision):
2566         (buildQMakeProjects):
2567         * qmake/mkspecs/features/default_post.prf:
2568
2569 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
2570
2571         run-perf-tests should support Skipped list
2572         https://bugs.webkit.org/show_bug.cgi?id=76594
2573
2574         Reviewed by Adam Barth.
2575
2576         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
2577
2578         * Scripts/webkitpy/layout_tests/port/base.py:
2579         (Port.perf_tests_dir):
2580         (Port.skipped_perf_tests):
2581         (Port.skips_perf_test):
2582         (Port.relative_perf_test_filename):
2583         * Scripts/webkitpy/layout_tests/port/test.py:
2584         (TestPort.perf_tests_dir):
2585         * Scripts/webkitpy/layout_tests/port/webkit.py:
2586         (WebKitPort._expectations_from_skipped_files):
2587         (WebKitPort):
2588         (WebKitPort.skipped_layout_tests):
2589         (WebKitPort.skipped_perf_tests):
2590         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2591         (PerfTestsRunner._collect_tests):
2592         (PerfTestsRunner.run):
2593         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2594         (test_run_test_set_with_json_output):
2595         (test_run_test_set_with_json_source):
2596         (test_collect_tests_with_skipped_list):
2597         (test_collect_tests_with_skipped_list.add_file):
2598
2599 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
2600
2601         Fix path to chromium_src_dir introduced in previous change.
2602
2603         Unreviewed, build fix.
2604
2605         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2606
2607 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
2608
2609         Need infrastructure to test Content-Disposition filename encoding support
2610         https://bugs.webkit.org/show_bug.cgi?id=76572
2611         <rdar://problem/6421825>
2612
2613         Reviewed by Sam Weinig.
2614
2615         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
2616
2617         WebKitTestRunner does not have a policy delegate yet, bug 42546.
2618
2619         * DumpRenderTree/mac/PolicyDelegate.mm:
2620         (dispositionTypeFromContentDispositionHeader):
2621         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
2622
2623 2012-01-18  Ojan Vafai  <ojan@chromium.org>
2624
2625         Fix tests from http://trac.webkit.org/changeset/105332.
2626
2627         The code assumed that if you passed an options object with a configuration
2628         attribute that it would have a valid value. A bunch of the testing mocks
2629         do things like having a configuration value of None.
2630
2631         * Scripts/webkitpy/layout_tests/port/base.py:
2632         (Port.__init__):
2633
2634 2012-01-18  Ojan Vafai  <ojan@chromium.org>
2635
2636         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
2637         https://bugs.webkit.org/show_bug.cgi?id=76576
2638
2639         Reviewed by Adam Barth.
2640
2641         Avoid calling default_configuration in base.py. We don't need it for
2642         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
2643         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
2644         from common.executive.
2645
2646         At some point someone should probably look into why that call is so slow
2647         since it's on the critical path for run-webkit-tests and build-webkit startup.
2648
2649         * Scripts/webkitpy/layout_tests/port/base.py:
2650         (Port.__init__):
2651         * Scripts/webkitpy/style/checkers/test_expectations.py:
2652         (TestExpectationsChecker._determine_port_from_exepectations_path):
2653
2654 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
2655
2656         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
2657         https://bugs.webkit.org/show_bug.cgi?id=76505
2658
2659         Reviewed by Tony Chang.
2660
2661         Update chromium build script to use All.gyp instead of WebKit.gyp
2662
2663         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
2664         * Scripts/webkitdirs.pm:
2665
2666 2012-01-18  Sam Weinig  <sam@webkit.org>
2667
2668         Don’t hardcode the path to ‘make‘.
2669
2670         Reviewed by Dan Bernstein.
2671
2672         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2673
2674 2012-01-18  Joshua Bell  <jsbell@chromium.org>
2675
2676         Adding myself to committers.py
2677         https://bugs.webkit.org/show_bug.cgi?id=76569
2678
2679         Unreviewed.
2680
2681         * Scripts/webkitpy/common/config/committers.py:
2682
2683 2012-01-18  Adam Barth  <abarth@webkit.org>
2684
2685         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
2686         https://bugs.webkit.org/show_bug.cgi?id=76567
2687
2688         Reviewed by Eric Seidel.
2689
2690         Current the AppleMac port has slightly more failures than we allow on
2691         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
2692         which should hopefully let the mac-ews run to completion.  Once
2693         AppleMac has fewer failures, we can lower the cap again.
2694
2695         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2696         (LayoutTestResultsReaderTest.test_layout_test_results):
2697         * Scripts/webkitpy/tool/steps/runtests.py:
2698         (RunTests):
2699         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2700
2701 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
2702
2703         Provide access to user's list of preferred languages
2704         https://bugs.webkit.org/show_bug.cgi?id=76138
2705
2706         Reviewed by Alexey Proskuryakov.
2707
2708         * GNUmakefile.am: Add JSInternalsCustom.cpp.
2709
2710 2012-01-18  Adam Barth  <abarth@webkit.org>
2711
2712         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
2713         configurations.
2714
2715         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2716         (ChromiumLinuxPort.__init__):
2717
2718 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
2719
2720         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
2721         https://bugs.webkit.org/show_bug.cgi?id=73460
2722
2723         Reviewed by Chris Fleizach.
2724
2725         * DumpRenderTree/AccessibilityUIElement.h:
2726         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2727         (AccessibilityUIElement::AccessibilityUIElement):
2728         (AccessibilityUIElement::scrollToMakeVisibleCallback):
2729         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
2730         (AccessibilityUIElement::scrollToGlobalPointCallback):
2731         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2732         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2733         (AccessibilityUIElement::scrollToMakeVisible):
2734         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2735         (AccessibilityUIElement::scrollToGlobalPoint):
2736         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2737         (AccessibilityUIElement::scrollToMakeVisible):
2738         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2739         (AccessibilityUIElement::scrollToGlobalPoint):
2740         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2741         (AccessibilityUIElement::scrollToMakeVisible):
2742         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2743         (AccessibilityUIElement::scrollToGlobalPoint):
2744
2745 2012-01-17  Enrica Casucci  <enrica@apple.com>
2746
2747         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
2748         https://bugs.webkit.org/show_bug.cgi?id=76490
2749         <rdar://problem/9460733>
2750
2751         Added TestWebKitAPI test.
2752         
2753         Reviewed by Dan Bernstein.
2754
2755         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
2756         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
2757         changeAttributes to the WebView.
2758         
2759 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
2760
2761         [Qt] Consolidate layout test crash logging
2762         https://bugs.webkit.org/show_bug.cgi?id=75088
2763
2764         Reviewed by Simon Hausmann.
2765
2766         Move backtrace generating logic into WTFReportBacktrace
2767         and add a way to deinstall signal handlers if we know
2768         that we have already printed the backtrace.
2769
2770         * DumpRenderTree/qt/main.cpp:
2771         (crashHandler):
2772         (setupSignalHandlers):
2773         (WTFCrashHook):
2774         (main):
2775         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2776         (WTR::crashHandler):
2777         (WTR::setupSignalHandlers):
2778         (WTR::crashHook):
2779         (WTR::InjectedBundle::platformInitialize):
2780
2781 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
2782
2783         Unreviewed build fix after r105256.
2784
2785         There was a cyclic dependency between self._port and self._host assigments.
2786
2787         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2788         (PerfTestsRunner.__init__):
2789
2790 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2791
2792         Add new watchlist rule for the Qt build system
2793
2794         Reviewed by Simon Hausmann.
2795
2796         * Scripts/webkitpy/common/config/watchlist:
2797
2798 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2799
2800         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
2801
2802         Reviewed by Simon Hausmann.
2803
2804         * Tools.pro:
2805
2806 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2807
2808         [Qt] Allow building only a subset of the WebKit sub-projects
2809
2810         Fixes build-jsc, broken in r104825.
2811
2812         We no longer need the intermediate buildQMakeQtProject(), as we're the
2813         only port using qmake, and buildQMakeProject is now highly Qt specific.
2814
2815         <http://webkit.org/b/76179>
2816
2817         Reviewed by Simon Hausmann.
2818
2819         * Scripts/build-jsc:
2820         * Scripts/build-webkit:
2821         * Scripts/webkitdirs.pm:
2822         (buildQMakeProjects):
2823
2824 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
2825
2826         run-perf-tests should generate a json file that summaries the result
2827         https://bugs.webkit.org/show_bug.cgi?id=76504
2828
2829         Reviewed by Adam Barth.
2830
2831         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
2832         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
2833         another json file to be merged into the generated json file.
2834
2835         Also fixed a bug that --build wasn't set by default.
2836
2837         * Scripts/webkitpy/layout_tests/port/test.py:
2838         (TestPort.webkit_base):
2839         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2840         (PerfTestsRunner.__init__):
2841         (PerfTestsRunner):
2842         (PerfTestsRunner._parse_args):
2843         (PerfTestsRunner.run):
2844         (PerfTestsRunner._generate_json_if_specified):
2845         (PerfTestsRunner._process_chromium_style_test_result):
2846         (PerfTestsRunner._process_parser_test_result):
2847         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2848         (MainTest):
2849         (create_runner):
2850         (test_run_test_set):
2851         (test_run_test_set_for_parser_tests):
2852         (test_run_test_set_with_summary_json):
2853         (test_collect_tests):
2854         (test_parse_args):
2855
2856 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
2857
2858         Unreviewed, rolling out r105244.
2859         http://trac.webkit.org/changeset/105244
2860         https://bugs.webkit.org/show_bug.cgi?id=76518
2861
2862         broke Chromium Mac (Requested by rolandsteiner on #webkit).
2863
2864         * DumpRenderTree/AccessibilityUIElement.h:
2865         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2866         (AccessibilityUIElement::AccessibilityUIElement):
2867         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2868         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2869         (AccessibilityUIElement::removeSelection):
2870         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2871         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2872         (AccessibilityUIElement::removeSelection):
2873
2874 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
2875
2876         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
2877         https://bugs.webkit.org/show_bug.cgi?id=73460
2878
2879         Reviewed by Chris Fleizach.
2880
2881         * DumpRenderTree/AccessibilityUIElement.h:
2882         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2883         (AccessibilityUIElement::AccessibilityUIElement):
2884         (AccessibilityUIElement::scrollToMakeVisibleCallback):
2885         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
2886         (AccessibilityUIElement::scrollToGlobalPointCallback):
2887         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2888         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2889         (AccessibilityUIElement::scrollToMakeVisible):
2890         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2891         (AccessibilityUIElement::scrollToGlobalPoint):
2892         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2893         (AccessibilityUIElement::scrollToMakeVisible):
2894         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2895         (AccessibilityUIElement::scrollToGlobalPoint):
2896         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2897         (AccessibilityUIElement::scrollToMakeVisible):
2898         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2899         (AccessibilityUIElement::scrollToGlobalPoint):
2900
2901 2012-01-17  Adam Barth  <abarth@webkit.org>
2902
2903         Enable tests on the mac-ews
2904         https://bugs.webkit.org/show_bug.cgi?id=76502
2905
2906         Reviewed by Simon Fraser.
2907
2908         Apple now has five machines running the mac-ews.  Lucas Forschler has
2909         asked that we try enabling tests to see if we have enough bandwidth.
2910
2911         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2912         (MacEWS):
2913
2914 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
2915
2916         Add a check-webkit-style exception for GDBInterface.cpp
2917         https://bugs.webkit.org/show_bug.cgi?id=76187
2918
2919         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
2920         that it does not fail the style check.
2921
2922         Reviewed by Martin Robinson.
2923
2924         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
2925         readability/naming tests on
2926         Source/JavaScriptCore/jit/GDBInterface.cpp.
2927         * Scripts/webkitpy/style/checker_unittest.py:
2928         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
2929         the above exception.
2930
2931 2012-01-17  Hajime Morrita  <morrita@chromium.org>
2932
2933         https://bugs.webkit.org/show_bug.cgi?id=76245
2934         [Mac][DRT] should allow query string for the file URL.
2935
2936         Reviewed by Tony Chang.
2937
2938         Taught DRT about file:// as a url instead of a file path.
2939         We are now able to use a path file:///foo/bar.html?baz as a url
2940         with which DRT opens "/foo/bar.html" with "baz" as a query string.
2941
2942         * DumpRenderTree/mac/DumpRenderTree.mm:
2943         (runTest):
2944
2945 2012-01-17  Ojan Vafai  <ojan@chromium.org>
2946
2947         Check style on test_expectations.txt files before commit
2948         https://bugs.webkit.org/show_bug.cgi?id=76484
2949
2950         Reviewed by Adam Barth.
2951
2952         Unlike other style rules, if you get the syntax of the test_expectations.txt
2953         file wrong, the layout tests won't run. Also, this check is simple and only
2954         slows down committing if you actually modify one of the test_expectations.txt files.
2955
2956         * Scripts/webkitpy/tool/steps/commit.py:
2957         (Commit._check_test_expectations):
2958         (Commit.run):
2959         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
2960         (CommitTest):
2961         (CommitTest.test_check_test_expectations):
2962
2963 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2964
2965         [Qt] Debug build fails with debug qt5
2966         https://bugs.webkit.org/show_bug.cgi?id=76463
2967
2968         Reviewed by Simon Hausmann.
2969
2970         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
2971
2972         * QtTestBrowser/cookiejar.h:
2973
2974 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
2975
2976         webkitpy: fix json import on linux
2977         https://bugs.webkit.org/show_bug.cgi?id=76481
2978
2979         Reviewed by Adam Barth.
2980
2981         For some reason, the version of simplejson autoinstalled on my linux
2982         box seems to be broken. We should really only be using
2983         simplejson if json isn't available anyway, so this change looks
2984         for json first.
2985
2986         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2987         (JSONGeneratorTest.test_test_timings_trie):
2988
2989 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
2990
2991         Fix failures in test-webkitpy caused by r105177.
2992
2993         Unreviewed, build fix.
2994
2995         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2996         (ChromiumLinuxPort._determine_driver_path_statically):
2997         (ChromiumLinuxPort._static_build_path):
2998
2999 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3000
3001         webkitpy: make PortFactory.get() be fully data-driven
3002         https://bugs.webkit.org/show_bug.cgi?id=76360
3003
3004         Reviewed by Eric Seidel.
3005
3006         Refactor PortFactory.get() to be fully data-driven.
3007
3008         * Scripts/webkitpy/layout_tests/port/factory.py:
3009         (PortFactory):
3010         (PortFactory._default_port):
3011         (PortFactory.get):
3012         (PortFactory.get.in):
3013         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3014         (FactoryTest.assert_port):
3015
3016 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3017
3018         webkitpy: add determine_full_port_name(), clean up port.__init__()
3019         https://bugs.webkit.org/show_bug.cgi?id=76357
3020
3021         Reviewed by Adam Barth.
3022
3023         Each Port class is now required to implement a 'port_name' field
3024         that will match the start of all ports constructed by this class and
3025         a 'determine_full_port_name' field that will make the port
3026         fully-qualified.
3027
3028         * Scripts/webkitpy/layout_tests/port/apple.py:
3029         (ApplePort.__init__):
3030         * Scripts/webkitpy/layout_tests/port/base.py:
3031         (Port):
3032         (Port.determine_port_name):
3033         (Port.__init__):
3034         * Scripts/webkitpy/layout_tests/port/chromium.py:
3035         (ChromiumPort.for):
3036         (ChromiumPort.__init__):
3037         (ChromiumPort):
3038         (ChromiumPort._chromium_base_dir):
3039         (ChromiumPort.path_from_chromium_base):
3040         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3041         (ChromiumGpuLinuxPort):
3042         (ChromiumGpuLinuxPort.__init__):
3043         (ChromiumGpuMacPort):
3044         (ChromiumGpuMacPort.__init__):
3045         (ChromiumGpuWinPort):
3046         (ChromiumGpuWinPort.__init__):
3047         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3048         (ChromiumLinuxPort):
3049         (ChromiumLinuxPort.determine_port_name):
3050         (ChromiumLinuxPort.__init__):
3051         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3052         (ChromiumMacPort):
3053         (ChromiumMacPort.determine_port_name):
3054         (ChromiumMacPort.__init__):
3055         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3056         (ChromiumWinPort):
3057         (ChromiumWinPort.determine_port_name):
3058         (ChromiumWinPort.__init__):
3059         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3060         (DryRunPort):
3061         (DryRunPort.determine_port_name):
3062         (DryRunPort.__init__):
3063         * Scripts/webkitpy/layout_tests/port/efl.py:
3064         (EflPort):
3065         * Scripts/webkitpy/layout_tests/port/factory.py:
3066         (PortFactory):
3067         (PortFactory._default_port):
3068         (PortFactory.get):
3069         (PortFactory.get.in):
3070         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3071         (FactoryTest.assert_port):
3072         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3073         (GoogleChromeLinux32Port):
3074         (GoogleChromeLinux32Port.determine_port_name):
3075         (GoogleChromeLinux64Port):
3076         (GoogleChromeLinux64Port.determine_port_name):
3077         (GoogleChromeMacPort):
3078         (GoogleChromeMacPort.determine_port_name):
3079         (GoogleChromeWinPort):
3080         (GoogleChromeWinPort.determine_port_name):
3081         * Scripts/webkitpy/layout_tests/port/gtk.py:
3082         (GtkPort):
3083         * Scripts/webkitpy/layout_tests/port/mac.py:
3084         (MacPort):
3085         (MacPort.determine_port_name):
3086         (MacPort.__init__):
3087         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3088         (test_versions):
3089         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3090         (MockDRTPort):
3091         (MockDRTPort.determine_port_name):
3092         (MockDRTPort.__init__):
3093         (MockDRT):
3094         (MockDRT.determine_port_name):
3095         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3096         (PortTestCase.make_port):
3097         * Scripts/webkitpy/layout_tests/port/qt.py:
3098         (QtPort):
3099         (QtPort.determine_port_name):
3100         (QtPort.__init__):
3101         * Scripts/webkitpy/layout_tests/port/test.py:
3102         (TestPort):
3103         (TestPort.determine_port_name):
3104         (TestPort.__init__):
3105         * Scripts/webkitpy/layout_tests/port/webkit.py:
3106         (WebKitPort.__init__):
3107         * Scripts/webkitpy/layout_tests/port/win.py:
3108         (WinPort):
3109         (WinPort.determine_port_name):
3110         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3111         (get_test_baselines.AllPlatformsPort.__init__):
3112         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3113         (get_test_config.TestMacPort):
3114         (get_test_config):
3115
3116 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3117
3118         webkitpy: clean up port code in preparation for static port names
3119         https://bugs.webkit.org/show_bug.cgi?id=76356
3120
3121         Reviewed by Adam Barth.
3122
3123         To fix bug 76215 and be able to determine appropriate port names
3124         in webkitpy without actually constructing Port objects, we need
3125         to shuffle some logic in the chromium ports to be able to figure
3126         out whether we built DRT in 32 or 64-bit mode.
3127
3128         * Scripts/webkitpy/layout_tests/port/chromium.py:
3129         (ChromiumPort):
3130         (ChromiumPort._chromium_base_dir):
3131         (ChromiumPort.__init__):
3132         (ChromiumPort.path_from_chromium_base):
3133         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3134         (ChromiumLinuxPort):
3135         (ChromiumLinuxPort._determine_driver_path_statically):
3136         (ChromiumLinuxPort._static_build_path):
3137         (ChromiumLinuxPort._determine_architecture):
3138         (ChromiumLinuxPort.__init__):
3139         (ChromiumLinuxPort._build_path):
3140
3141 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
3142
3143         Do not remove pixel failures for ref tests.
3144         https://bugs.webkit.org/show_bug.cgi?id=76243
3145
3146         Reviewed by Tony Chang.
3147
3148         'NRWT --no-pixel-tests' complains when reftests are expected to
3149         be image mismatch.
3150
3151         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3152         (Manager._update_summary_with_result):
3153         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3154         (is_reftest_failure):
3155         (determine_result_type):
3156
3157 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
3158
3159         REGRESSION(r81225): ORWT should ignore reftests
3160         https://bugs.webkit.org/show_bug.cgi?id=67936
3161
3162         Reviewed by Csaba Osztrogonác.
3163
3164         * Scripts/old-run-webkit-tests:
3165         (isUsedInReftest): $filename should be the first parameter
3166         (findTestsToRun): run test if it isn't reftest
3167
3168 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
3169
3170         Unreviewed. Fix python unit test I broke with r105142
3171
3172         * Scripts/webkitpy/common/config/ports_unittest.py:
3173         (WebKitPortTest.test_gtk_port):
3174
3175 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3176
3177         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
3178
3179         Qt 5 no longer has that flag.
3180
3181         Reviewed by Simon Hausmann.
3182
3183         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3184         (MiniBrowserApplication::notify):
3185
3186 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3187
3188         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
3189         https://bugs.webkit.org/show_bug.cgi?id=75857
3190
3191         Reviewed by Adam Barth.
3192
3193         * Scripts/webkitdirs.pm:
3194         (buildAutotoolsProject): move cleaning the build to happen early,
3195         and handle --update-gtk right after that
3196         * Scripts/webkitpy/common/config/ports.py:
3197         (GtkPort.build_webkit_command): pass --update-gtk as an option to
3198         build-webkit, so that it is used in the EWS
3199
3200 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3201
3202         [Qt] Don't add _debug postfix to targets when building debug only
3203
3204         Reviewed by Simon Hausmann.
3205
3206         * qmake/mkspecs/features/default_post.prf:
3207         * qmake/mkspecs/features/functions.prf:
3208
3209 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3210
3211         [Qt] Add more files to project-files for easier navigation in Qt Creator
3212
3213         Reviewed by Simon Hausmann.
3214
3215         * Tools.pro:
3216         * qmake/config.tests/README: Added.
3217
3218 2012-01-17  Philippe Normand  <pnormand@igalia.com>
3219
3220         [GTK] fast/dom/constructed-objects-prototypes.html fails
3221         https://bugs.webkit.org/show_bug.cgi?id=75432
3222
3223         Reviewed by Martin Robinson.
3224
3225         * Scripts/build-webkit: Enable video-track in GTK.
3226
3227 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
3228
3229         Add toyoshim as a committer.
3230         https://bugs.webkit.org/show_bug.cgi?id=76390
3231
3232         Reviewed by Hajime Morita.
3233
3234         * Scripts/webkitpy/common/config/committers.py:
3235
3236 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
3237
3238         [WinCairo] Build fix after r104155. Several debug targets were not
3239         properly including the '*Common' property sheets.
3240
3241         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
3242         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
3243         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
3244         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
3245         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
3246
3247 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
3248
3249         REGRESSION(r105072): It broke committers_unittest.py
3250         https://bugs.webkit.org/show_bug.cgi?id=76396
3251
3252         Reviewed by Adam Barth.
3253
3254         * Scripts/webkitpy/common/config/committers_unittest.py:
3255         (CommittersTest._assert_fuzz_match): It should handle more names.
3256         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
3257
3258 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
3259
3260         [GTK] Include gtk+3 in the jhbuild modules
3261         https://bugs.webkit.org/show_bug.cgi?id=76284
3262
3263         Reviewed by Philippe Normand.
3264
3265         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
3266
3267 2012-01-16  Dan Winship  <danw@gnome.org>
3268
3269         Add myself as a committer
3270
3271         Unreviewed
3272
3273         * Scripts/webkitpy/common/config/committers.py:
3274
3275 2012-01-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
3276
3277         Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
3278
3279         Some recent versions of a few Linux distributions have started passing
3280         --as-needed and --no-copy-dt-needed-entries by default to the linker,
3281         which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
3282         needed a few symbols from libjavascriptcore_efl.so.
3283
3284         * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
3285         before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
3286         libraries are searched in the right order by the linker.
3287
3288 2012-01-16  Philippe Normand  <pnormand@igalia.com>
3289
3290         [GTK] set audio resources path in NRTW
3291         https://bugs.webkit.org/show_bug.cgi?id=76380
3292
3293         Reviewed by Martin Robinson.
3294
3295         * Scripts/webkitpy/layout_tests/port/gtk.py:
3296         (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
3297         the uninstalled audio resources are used during webaudio tests.
3298
3299 2012-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3300
3301         [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
3302         https://bugs.webkit.org/show_bug.cgi?id=76369
3303
3304         Reviewed by Xan Lopez.
3305
3306         If there's an installed version of webkit and there are new
3307         symbols in the build tree, gtkdoc-scanobj fails due to undefined
3308         references, because the env ldflags are given before the local
3309         ones.
3310
3311         * gtk/gtkdoc.py:
3312         (GTKDoc._run_gtkdoc_scangobj):
3313
3314 2012-01-15  Pablo Flouret  <pablof@motorola.com>
3315
3316         Fix compilation errors on build-webkit --debug --no-video on mac.
3317         https://bugs.webkit.org/show_bug.cgi?id=75867
3318
3319         Reviewed by Philippe Normand.
3320
3321         Add --[no-]video-track to build-webkit, since video track feature
3322         depends on video.
3323
3324         * Scripts/build-webkit:
3325
3326 2012-01-14  James Robinson  <jamesr@chromium.org>
3327
3328         [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
3329         https://bugs.webkit.org/show_bug.cgi?id=76313
3330
3331         Reviewed by Adam Barth.
3332
3333         The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
3334
3335         * Scripts/run-chromium-webkit-unit-tests:
3336
3337 2012-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3338
3339         Unreviewed, rolling out r105017.
3340         http://trac.webkit.org/changeset/105017
3341         https://bugs.webkit.org/show_bug.cgi?id=76333
3342
3343         broke the build (Requested by philn-tp on #webkit).
3344
3345         * gtk/jhbuild.modules:
3346
3347 2012-01-14  Mario Sanchez Prada  <msanchez@igalia.com>
3348
3349         [GTK] Include gtk+3 in the jhbuild modules
3350         https://bugs.webkit.org/show_bug.cgi?id=76284
3351
3352         Reviewed by Philippe Normand.
3353
3354         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
3355
3356 2012-01-13  Adam Barth  <abarth@webkit.org>
3357
3358         Remove --dry-run support from webkit-patch
3359         https://bugs.webkit.org/show_bug.cgi?id=76300
3360
3361         Reviewed by Dirk Pranke.
3362
3363         This is the rest of the patch from Bug 76300.  I landed it separtely
3364         because main.py had some stray conflict markers that I needed to clean
3365         up first.
3366
3367         * Scripts/webkitpy/test/main.py:
3368         (Tester.parse_args):
3369         (Tester._run_tests):
3370
3371 2012-01-13  Adam Barth  <abarth@webkit.org>
3372
3373         test-webkitpy does not run
3374         https://bugs.webkit.org/show_bug.cgi?id=76318
3375
3376         Unreviewed.
3377
3378         Looks like some conflict markers got left in the file.
3379
3380         * Scripts/webkitpy/test/main.py:
3381         (Tester.run):
3382
3383 2012-01-13  Adam Barth  <abarth@webkit.org>
3384
3385         Remove --dry-run support from webkit-patch
3386         https://bugs.webkit.org/show_bug.cgi?id=76300
3387
3388         Reviewed by Dirk Pranke.
3389
3390         We don't use this functionality for anything, and it doesn't really
3391         work.  Someone in #webkit tried using it and and got sad/confused.  We
3392         should just remove it.
3393
3394         * Scripts/webkitpy/common/checkout/scm/git.py:
3395         (Git.push_local_commits_to_server):
3396         * Scripts/webkitpy/common/checkout/scm/scm.py:
3397         (SCM.__init__):
3398         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3399         (_shared_test_commit_with_message):
3400         (GitSVNTest.test_commit_text_parsing):
3401         * Scripts/webkitpy/common/checkout/scm/svn.py:
3402         (SVN.commit_with_message):
3403         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3404         (Bugzilla.__init__):
3405         (Bugzilla.quips):
3406         (Bugzilla.authenticate):
3407         (Bugzilla.add_attachment_to_bug):
3408         (Bugzilla.add_patch_to_bug):
3409         (Bugzilla.create_bug):
3410         (Bugzilla.clear_attachment_flags):
3411         (Bugzilla.set_flag_on_attachment):
3412         (Bugzilla.obsolete_attachment):
3413         (Bugzilla.add_cc_to_bug):
3414         (Bugzilla.post_comment_to_bug):
3415         (Bugzilla.close_bug_as_fixed):
3416         (Bugzilla.reassign_bug):
3417         (reopen_bug):
3418         * Scripts/webkitpy/test/main.py:
3419         (Tester.parse_args):
3420         (Tester.run_tests):
3421
3422 2012-01-13  David Levin  <levin@chromium.org>
3423
3424         check-webkit-style: should encourage the use of Own* classes for Windows DC.
3425         https://bugs.webkit.org/show_bug.cgi?id=76227
3426
3427         Reviewed by Dirk Pranke.
3428
3429         * Scripts/webkitpy/style/checkers/cpp.py:
3430         (check_for_leaky_patterns): The new check.
3431         (process_line): Added a call to the new check.
3432         (CppChecker): Added the new error type.
3433         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3434         (CppStyleTestBase):
3435         (CppStyleTestBase.perform_leaky_pattern_check):
3436         The check for only leaky pattern errors.
3437         (LeakyPatternTest): Test cases.
3438
3439 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
3440
3441         test-webkitpy: clean up handling of test directories, QueueStatusServer
3442         https://bugs.webkit.org/show_bug.cgi?id=76238
3443
3444         Reviewed by Adam Barth.
3445
3446         This patch cleans up a bunch of hacks related to how we find all
3447         of the python unit tests and set up the sys.path variable in
3448         test-webkitpy.
3449
3450         This patch changes how test-webkitpy works slightly in that we
3451         will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
3452         rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
3453         This greatly simplifies the mapping of paths to module names and
3454         appears to have no significant performance impact or other drawbacks.
3455
3456         There are other ways that we could remove all of the hacks and
3457         still have a more flexible mapping of paths to module names, but
3458         the ones I've thought of so far add a decent amount of complexity to
3459         the implementation and don't seem to buy us much.
3460         
3461         * QueueStatusServer/__init__.py:
3462         * Scripts/test-webkitpy:
3463         * Scripts/webkitpy/test/main.py:
3464         (Tester._modules_from_paths):
3465         (Tester._is_module):
3466
3467 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
3468
3469         test-webkitpy: should support classes and individual test names as well as modules
3470         https://bugs.webkit.org/show_bug.cgi?id=76233
3471
3472         Reviewed by Adam Barth.
3473
3474         The default unittest.main() supports a list of individual
3475         TestCase classes or individual tests as well as modules. This
3476         change adds support for the same to test-webkitpy, so now you
3477         can say
3478
3479           % test-wekbitpy webkitpy.test.cat_unittest.CatTest
3480
3481         and
3482
3483           % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
3484
3485         in addition to
3486
3487           % test-wekbitpy webkitpy.test.cat_unittest
3488
3489         * Scripts/test-webkitpy:
3490         * Scripts/webkitpy/test/cat_unittest.py:
3491         * Scripts/webkitpy/test/main.py:
3492         (Tester.parse_args):
3493         (Tester.run):
3494         (Tester):
3495         (Tester._find_modules):
3496         (Tester._exclude):
3497         (Tester._run_tests):
3498         (Tester._is_module):
3499         (Tester._log_exception):
3500
3501 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
3502
3503         test-webkitpy: add basic code coverage support
3504         https://bugs.webkit.org/show_bug.cgi?id=76201
3505
3506         Reviewed by Adam Barth.
3507
3508         This test adds basic code coverage support to test-webkitpy; if
3509         you pass the -c flag, we will generate a new coverage file. We
3510         can start simply with this and add more features as necessary.
3511
3512         This patch requires coverage to be already installed on the
3513         machine. I am not auto-installing this for now.
3514
3515         * Scripts/webkitpy/test/main.py:
3516         (Tester.parse_args):
3517         (Tester.run_tests):
3518
3519 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
3520
3521         StatusBubbleTest.test_build_bubble is failing
3522         https://bugs.webkit.org/show_bug.cgi?id=76222
3523
3524         Reviewed by Adam Barth.
3525
3526         * QueueStatusServer/handlers/statusbubble_unittest.py:
3527         (StatusBubbleTest.test_build_bubble):
3528
3529 2012-01-13  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3530
3531         nrwt should use multiple http shards
3532         https://bugs.webkit.org/show_bug.cgi?id=75958
3533
3534         Add --max-locked-shards option to the nrwt for manual set
3535         the maximum number of the locked shards
3536
3537         Reviewed by Dirk Pranke.
3538
3539         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3540         (Manager._max_locked_shards):
3541         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3542         (ShardingTests.get_shards):
3543         (ShardingTests.test_multiple_locked_shards):
3544         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3545         (parse_args):
3546
3547 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
3548
3549         prepare-ChangeLog: Look for a text editor in a few more variables.
3550         https://bugs.webkit.org/show_bug.cgi?id=76289
3551
3552         Reviewed by Ryosuke Niwa.
3553
3554         A text editor was looked for only in the CHANGE_LOG_EDITOR and
3555         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
3556         to the OS X-specific open(1) command.
3557
3558         As there does not seem to be a common way of looking for a text editor
3559         among the scripts in Tools/Scripts right now, just look at $VISUAL and
3560         $EDITOR (set much more often than the other variables in Unix systems)
3561         before falling back to open(1).
3562
3563         * Scripts/prepare-ChangeLog:
3564         (openChangeLogs):
3565
3566 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
3567
3568         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
3569         https://bugs.webkit.org/show_bug.cgi?id=76269
3570
3571         Reviewed by Martin Robinson.
3572
3573         * gtk/gtkdoc.py:
3574         (GTKDoc._run_gtkdoc_scangobj):
3575
3576 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
3577
3578         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
3579         https://bugs.webkit.org/show_bug.cgi?id=76247
3580
3581         Reviewed by Kenneth Rohde Christiansen.
3582
3583         * WebKitTestRunner/TestController.cpp:
3584         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
3585
3586 2012-01-13  Hajime Morrita  <morrita@chromium.org>
3587
3588         [Mac][DRT] Should support --no-timeout
3589         https://bugs.webkit.org/show_bug.cgi?id=76242
3590
3591         Reviewed by Darin Adler.
3592
3593         * DumpRenderTree/mac/DumpRenderTree.mm:
3594         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
3595         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
3596         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
3597         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3598         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3599         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
3600
3601 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
3602
3603         Mitigate scrollbar differences when running pixel tests
3604         https://bugs.webkit.org/show_bug.cgi?id=67217
3605
3606         Reviewed by Dan Bernstein.
3607         
3608         Enable mock scrollbars by default for tests.
3609
3610         * DumpRenderTree/mac/DumpRenderTree.mm:
3611         (resetDefaultsToConsistentValues):
3612         * WebKitTestRunner/TestController.cpp:
3613         (WTR::TestController::resetStateToConsistentValues):
3614
3615 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
3616
3617         Need a script to run tests in PerformanceTests
3618         https://bugs.webkit.org/show_bug.cgi?id=76132
3619
3620         Reviewed by Adam Barth.
3621
3622         Add run-perf-tests to run performance tests using parser/resources/runner.js.
3623         Unfortunately, there isn't an easy way of telling which test uses which format
3624         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
3625
3626         All test outputs are re-formatted to match Chromium perf-bot style.
3627
3628         * Scripts/run-inspector-perf-tests.py:
3629         * Scripts/run-perf-tests: Added.
3630         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3631         (PerfTestsRunner):
3632         (PerfTestsRunner.__init__):
3633         (PerfTestsRunner._collect_tests):
3634         (PerfTestsRunner.run):
3635         (PerfTestsRunner._print_status):
3636         (PerfTestsRunner._run_tests_set):
3637         (PerfTestsRunner._process_chromium_style_test_result):
3638         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
3639         (PerfTestsRunner._process_parser_test_result):
3640         (PerfTestsRunner._run_single_test):
3641         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3642         (MainTest.TestDriver.run_test):
3643         (create_runner):
3644         (run_test):
3645         (test_run_test_set):
3646         (test_run_test_set_for_parser_tests):
3647         (test_collect_tests):
3648
3649 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
3650
3651         webkitpy: clean up port unit tests in preparation for making port_name mandatory
3652         https://bugs.webkit.org/show_bug.cgi?id=76123
3653
3654         Reviewed by Adam Barth.
3655
3656         This change updates the unit tests to be more consistent in how
3657         ports are created, in preparation for making port_name a
3658         mandatory parameter to the constructor and removing any version
3659         interpretation from it.
3660
3661         There should be no functional changes in this patch, but some
3662         tests that are no longer relevant have been removed or reworked.
3663
3664         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3665         (PortTest.test_get_option__default):
3666         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3667         (ChromiumLinuxPortTest):
3668         (ChromiumLinuxPortTest.assert_architecture):
3669         (ChromiumLinuxPortTest.test_determine_architecture_fails):
3670         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3671         (ChromiumMacPortTest):
3672         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3673         (ChromiumPortTest):
3674         (ChromiumPortTest.test_all_test_configurations):
3675         (ChromiumPortTest.TestMacPort.__init__):
3676         (ChromiumPortTest.TestLinuxPort.__init__):
3677         (ChromiumPortTest.TestWinPort.__init__):
3678         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3679         (ChromiumWinTest):
3680         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3681         (EflPortTest):
3682         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3683         (GtkPortTest):
3684         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3685         (MacTest):
3686         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3687         (MockDRTPortTest):
3688         (MockDRTPortTest.make_port):
3689         * Scripts/webkitpy/layout_tests/port/qt.py:
3690         (QtPort._port_flag_for_scripts):
3691         (QtPort.__init__):
3692         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3693         (QtPortTest):
3694         (QtPortTest._assert_search_path):
3695         (QtPortTest.test_baseline_search_path):
3696         (QtPortTest.test_operating_system):
3697         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3698         (WebKitPortTest):
3699         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3700         (WinPortTest):
3701         (WinPortTest._assert_search_path):
3702         (WinPortTest.test_baseline_search_path):
3703         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3704         (get_test_config.TestMacPort.__init__):
3705
3706 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
3707
3708         test-webkitpy: clean up logging and provide a real --help message
3709         https://bugs.webkit.org/show_bug.cgi?id=76142
3710
3711         Reviewed by Adam Barth.
3712
3713         This test is mostly more refactoring - it calls objects in
3714         unittest directly instead of routing through unittest.main() --
3715         in order to gain more control over the logging and to provide a
3716         correct --help message. This will also give us a better
3717         foundation for adding more feautures down the road.
3718
3719         This patch adds different levels of logging controlled by the
3720         '-s', '-q', and '-v' options (see --help for details), and
3721         removes the --verbose-logging option.
3722
3723         * Scripts/test-webkitpy:
3724         * Scripts/webkitpy/test/main.py:
3725         (Tester):
3726         (Tester.clean_packages):
3727         (Tester.__init__):
3728         (Tester.parse_args):
3729         (Tester.configure):
3730         (Tester._configure_logging):
3731         (Tester.find_modules):
3732         (Tester._exclude):
3733         (Tester._modules_from_paths):
3734         (Tester.run_tests):
3735
3736 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
3737
3738         Make the new WTF module build on Qt
3739         https://bugs.webkit.org/show_bug.cgi?id=76163
3740
3741         Reviewed by Tor Arne Vestbø.
3742
3743         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
3744
3745 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
3746
3747         Unreviewed, mac DumpRenderTree fix.
3748
3749         * DumpRenderTree/mac/UIDelegate.mm:
3750         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3751
3752 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
3753
3754         WebKitTestRunner should not print console message line number when it is equal to zero.
3755         https://bugs.webkit.org/show_bug.cgi?id=76167
3756
3757         Reviewed by Csaba Osztrogonác.
3758
3759         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3760         (WTR::InjectedBundlePage::willAddMessageToConsole):
3761
3762 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
3763
3764         Make default console messages line numbers consistent.
3765         https://bugs.webkit.org/show_bug.cgi?id=74075
3766
3767         Reviewed by Pavel Feldman.
3768
3769         Unset line numbers are not printed to console now.
3770         Added Source/WebCore/inspector to efl DumpRenderTree include path.
3771
3772         * DumpRenderTree/chromium/WebViewHost.cpp:
3773         (WebViewHost::didAddMessageToConsole):
3774         * DumpRenderTree/efl/CMakeLists.txt:
3775         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3776         (onConsoleMessage):
3777         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3778         (webViewConsoleMessage):
3779         * DumpRenderTree/mac/UIDelegate.mm:
3780         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3781         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3782         (WebCore::WebPage::javaScriptConsoleMessage):
3783         * DumpRenderTree/win/UIDelegate.cpp:
3784         (UIDelegate::webViewAddMessageToConsole):
3785         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3786         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
3787
3788 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
3789
3790         test-webkitpy: push more logic into webkitpy.test.main, clean up code
3791         https://bugs.webkit.org/show_bug.cgi?id=76021
3792
3793         Reviewed by Eric Seidel.
3794
3795         I plan to add more functionality to test-webkitpy, but it is
3796         difficult to hack on now; this patch is the first of two that
3797         brings test-webkitpy more inline with current coding style by
3798         pushing more logic into the webkitpy.test.main.Tester class (so
3799         that it will be testable itself).
3800         
3801         There should be no functional changes in this patch.
3802
3803         * Scripts/test-webkitpy:
3804         (_path_from_webkit_root):
3805         * Scripts/webkitpy/test/main.py:
3806         (Tester):
3807         (Tester.init):
3808         (Tester.configure_logging):
3809         (Tester.configure_logging.filter):
3810         (Tester.clean_packages):
3811         (Tester.run_tests):
3812
3813 2012-01-11  Wei Jia  <wjia@chromium.org>
3814
3815         implement layout tests for <video> with media stream
3816         https://bugs.webkit.org/show_bug.cgi?id=74882
3817
3818         Reviewed by Kent Tamura.
3819
3820         * DumpRenderTree/DumpRenderTree.gypi:
3821         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
3822         (WebKit::WebUserMediaClientMock::create):
3823         (WebKit::WebUserMediaClientMock::IsMockStream):
3824         (WebKit::WebUserMediaClientMock::requestUserMedia):
3825         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
3826         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
3827         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
3828         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
3829         * DumpRenderTree/chromium/WebViewHost.cpp:
3830         (WebViewHost::userMediaClient):
3831         (WebViewHost::userMediaClientMock):
3832         (WebViewHost::createMediaPlayer):
3833         (WebViewHost::mediaStreamUtil):
3834         (WebViewHost::testMediaStreamClient):
3835         * DumpRenderTree/chromium/WebViewHost.h:
3836
3837 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
3838
3839         Unreviewed, build fix.
3840
3841         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
3842
3843         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3844         (ChromiumWinPort.__init__):
3845
3846 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
3847
3848         Sheriffbot build fix. Don't emit empty lines on IRC.
3849
3850         * Scripts/webkitpy/tool/bot/irc_command.py:
3851         (LastGreenRevision.execute):
3852
3853 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
3854
3855         last-green-revision should report the revision that succeeded on all bots
3856         https://bugs.webkit.org/show_bug.cgi?id=76109
3857
3858         Reviewed by Adam Barth.
3859
3860         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
3861         considered green by this algorithm, all matching builders must have a successful run at the revision
3862         or two consecutive successful runs before and after the revision.
3863
3864         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
3865         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
3866
3867         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3868         (BuildBot._revisions_for_builder):
3869         (BuildBot):
3870         (BuildBot._find_green_revision):
3871         (BuildBot.last_green_revision):
3872         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3873         (MockBuildBot.last_green_revision):
3874         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3875         (test_revisions_for_builder):
3876         (test_find_green_revision):
3877         (test_last_green_revision):
3878         * Scripts/webkitpy/tool/bot/irc_command.py:
3879         (LastGreenRevision.execute):
3880         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3881         (SheriffIRCBotTest.test_lgr):
3882         * Scripts/webkitpy/tool/commands/queries.py:
3883         (LastGreenRevision):
3884
3885 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
3886
3887         Unreviewed, fix build bustage on win32 introduced by r104725.
3888
3889         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3890         (MockDRTPortTest.make_port):
3891         (MockChromiumDRTTest.test_pixeltest__fails):
3892
3893 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
3894
3895         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
3896         https://bugs.webkit.org/show_bug.cgi?id=75618
3897
3898         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
3899
3900         Reviewed by Tony Chang.
3901
3902         * DumpRenderTree/chromium/LayoutTestHelper.mm:
3903         (installLayoutTestColorProfile):
3904         (restoreUserColorProfile):
3905         (main):
3906
3907 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
3908
3909         test-webkitpy: fix -v and eliminate some spurious warnings
3910         https://bugs.webkit.org/show_bug.cgi?id=76099
3911
3912         Reviewed by Adam Barth.
3913
3914         when we added support for --xml output, we broke the -v flag.
3915
3916         Also, fix the code to swallow a harmless warning from
3917         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
3918
3919         test-webkitpy is now silent again except for the one known
3920         logging issue.
3921
3922         * Scripts/webkitpy/common/checkout/checkout.py:
3923         (Checkout.commit_message_for_this_commit):
3924         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3925         (test_commit_message_for_this_commit):
3926         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3927         (JSONChecker.check):
3928         (JSONChecker.line_number_from_json_exception):
3929         * Scripts/webkitpy/test/main.py:
3930         (Tester.run_tests):
3931
3932 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
3933
3934         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
3935         https://bugs.webkit.org/show_bug.cgi?id=76084
3936
3937         Reviewed by Adam Barth.
3938
3939         This will help make it easier to catch layering violations. This
3940         change just refactors test code; there are no changes to
3941         production code.
3942
3943         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3944         (PortTest.make_port):
3945         (PortTest.test_find_no_paths_specified):
3946         (PortTest.test_find_one_test):
3947         (PortTest.test_find_glob):
3948         (PortTest.test_find_with_skipped_directories):
3949         (PortTest.test_find_with_skipped_directories_2):
3950         (PortTest.test_parse_reftest_list):
3951         (PortTest.test_httpd_returns_error_code):
3952         (PortTest.test_virtual_methods):
3953         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3954         (ChromiumGpuTest.assert_port_works):
3955         (ChromiumGpuTest._assert_baseline_path):
3956         (ChromiumGpuTest.test_graphics_type):
3957         (ChromiumGpuTest.test_default_tests_paths.test_paths):
3958         (ChromiumGpuTest.test_test_files):
3959         (ChromiumGpuTest.test_test_files.test_paths):
3960         (ChromiumGpuTest):
3961         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3962         (ChromiumLinuxPortTest.assert_architecture):
3963         (ChromiumLinuxPortTest.test_check_illegal_port_names):
3964         (ChromiumLinuxPortTest.test_determine_architecture_fails):
3965         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3966         (DriverTest.make_port):
3967         (DriverTest):
3968         (DriverTest.assertVirtual):
3969         (DriverTest._assert_wrapper):
3970         (DriverTest.test_virtual_driver_methods):
3971         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3972         (MockDRTPortTest.make_port):
3973         (MockDRTPortTest.test_port_name_in_constructor):
3974         (MockDRTTest.assertTest):
3975         (MockDRTTest.test_main):
3976         (MockChromiumDRTTest.test_pixeltest__fails):
3977         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3978         (QtPortTest._assert_search_path):
3979         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3980         (TestWebKitPort.__init__):
3981         (WebKitPortUnitTests.test_default_options):
3982         (test_runtime_feature_list):
3983         (test_test_expectations):
3984
3985 2012-01-11  Ojan Vafai  <ojan@chromium.org>
3986
3987         Style skipped tests in the flakiness dashboard
3988         https://bugs.webkit.org/show_bug.cgi?id=76091
3989
3990         Reviewed by Tony Chang.
3991
3992         * TestResultServer/static-dashboards/dashboard_base.js:
3993         Removed "FLAKY" from this list since we don't ever mark individual runs
3994         as flaky. Also deleted an outdated line.
3995         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3996
3997 2012-01-11  Ojan Vafai  <ojan@chromium.org>
3998
3999         Remove gtest normalization code from the test results server
4000         https://bugs.webkit.org/show_bug.cgi?id=76089
4001
4002         Reviewed by Tony Chang.
4003
4004         The normalization now happens on the gtest side.
4005
4006         * TestResultServer/model/jsonresults.py:
4007         (JsonResults.merge):
4008         * TestResultServer/model/jsonresults_unittest.py:
4009         (JsonResultsTest.test_gtest):
4010
4011 2012-01-11  Ojan Vafai  <ojan@chromium.org>
4012
4013         Be more aggressive about deleting unnecessary results from the test-results-server json files
4014         https://bugs.webkit.org/show_bug.cgi?id=76086
4015
4016         Reviewed by Tony Chang.
4017
4018         Remove any tests that only contain skip/pass/nodata values whose runtime
4019         is less than 5 seconds.
4020
4021         * TestResultServer/model/jsonresults.py:
4022         (JsonResults._normalize_results_json):
4023         * TestResultServer/model/jsonresults_unittest.py:
4024         (JsonResultsTest.test_merge_remove_test):
4025         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
4026
4027 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
4028
4029         last-green-revision should give us per-bot information
4030         https://bugs.webkit.org/show_bug.cgi?id=76011
4031
4032         Reviewed by Adam Barth.
4033
4034         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
4035         we report the latest green run on each bot from the last 100 runs.
4036
4037         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4038         (BuildBot._fetch_builder_page):
4039         (BuildBot):
4040         (BuildBot._green_revision_for_builder):
4041         (BuildBot.last_green_revision):
4042         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4043         (test_green_revision_for_builder):
4044         (test_last_green_revision):
4045         * Scripts/webkitpy/tool/bot/irc_command.py:
4046         (LastGreenRevision.execute):
4047         * Scripts/webkitpy/tool/commands/queries.py:
4048         (LastGreenRevision.execute):
4049
4050 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
4051
4052         webkitpy: clean up version detection in webkitpy.layout_tests.port
4053         https://bugs.webkit.org/show_bug.cgi?id=76016
4054
4055         Reviewed by Adam Barth.
4056
4057         This change updates the code in webkitpy.layout_tests.port to
4058         use the new os_name and os_version fields on host.platform. This
4059         gets layout_tests.port out of the version parsing business. Most
4060         of the diffs are just cleaning up test code to accomodate the
4061         changes.
4062
4063         * Scripts/webkitpy/common/system/executive_mock.py:
4064         (MockExecutive):
4065         (MockExecutive.ignore_error):
4066         (MockExecutive2):
4067         (MockExecutive2.ignore_error):
4068         * Scripts/webkitpy/common/system/platforminfo_mock.py:
4069         (MockPlatformInfo.is_mac):
4070         (MockPlatformInfo.is_linux):
4071         (MockPlatformInfo.is_win):
4072         * Scripts/webkitpy/common/system/systemhost_mock.py:
4073         (MockSystemHost.__init__):
4074         * Scripts/webkitpy/layout_tests/port/apple.py:
4075         (ApplePort.__init__):
4076         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4077         (ChromiumMacPort.__init__):
4078         (ChromiumMacPort.check_wdiff):
4079         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4080         (ChromiumMacPortTest):
4081         (ChromiumMacPortTest.assert_name):
4082         (ChromiumMacPortTest.test_versions):
4083         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4084         (ChromiumPortTest.test_all_test_configurations):
4085         (ChromiumPortTest.TestMacPort.__init__):
4086         (ChromiumPortTest.TestLinuxPort.__init__):
4087         (ChromiumPortTest.TestWinPort.__init__):
4088         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4089         (ChromiumWinPort.__init__):
4090         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4091         (ChromiumWinTest):
4092         (ChromiumWinTest.assert_name):
4093         (ChromiumWinTest.test_versions):
4094         (ChromiumWinTest.test_baseline_path):
4095         (ChromiumWinTest.test_build_path):
4096         * Scripts/webkitpy/layout_tests/port/factory.py:
4097         (PortFactory._port_name_from_arguments_and_options):
4098         (PortFactory.get):
4099         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
4100         (FactoryTest):
4101         (FactoryTest.setUp):
4102         (FactoryTest.assert_port):
4103         (FactoryTest.test_mac):
4104         (FactoryTest.test_win):
4105         (FactoryTest.test_google_chrome):
4106         (FactoryTest.test_gtk):
4107         (FactoryTest.test_qt):
4108         (FactoryTest.test_chromium_gpu):
4109         (FactoryTest.test_chromium_gpu_linux):
4110         (FactoryTest.test_chromium_gpu_mac):
4111         (FactoryTest.test_chromium_gpu_win):
4112         (FactoryTest.test_chromium_mac):
4113         (FactoryTest.test_chromium_linux):
4114         (FactoryTest.test_chromium_win):
4115         (FactoryTest.test_unknown_specified):
4116         (FactoryTest.test_unknown_default):
4117         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
4118         (TestGoogleChromePort):
4119         (TestGoogleChromePort._verify_baseline_path):
4120         (TestGoogleChromePort._verify_expectations_overrides):
4121         (TestGoogleChromePort.test_get_google_chrome_port):
4122         * Scripts/webkitpy/layout_tests/port/mac.py:
4123         (MacPort):
4124         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4125         (MacTest):
4126         (assert_name):
4127         (test_tests_for_other_platforms):
4128         (test_version):
4129         (test_versions):
4130         (test_is_version_methods):
4131         (test_setup_environ_for_server):
4132         (_assert_search_path):
4133         (test_show_results_html_file):
4134         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4135         (PortTestCase):
4136         (PortTestCase.make_port):
4137         * Scripts/webkitpy/layout_tests/port/win.py:
4138         (WinPort):
4139         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4140         (WinPortTest):
4141         (WinPortTest.test_show_results_html_file):
4142         (WinPortTest._assert_search_path):
4143         (WinPortTest._assert_version):
4144
4145 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
4146
4147         [Qt][WK2] Remove workaround introduced into bug 75470
4148         https://bugs.webkit.org/show_bug.cgi?id=75889
4149
4150         Reviewed by Tor Arne Vestbø.
4151
4152         * MiniBrowser/qt/qml/BrowserWindow.qml:
4153
4154 2012-01-10  Dmitry Lomov  <dslomov@google.com>
4155
4156         [Chromium] Remove obsolete references to WebWorker class.
4157         https://bugs.webkit.org/show_bug.cgi?id=76020
4158
4159         Reviewed by David Levin.
4160
4161         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
4162         * DumpRenderTree/chromium/WebViewHost.cpp:
4163         * DumpRenderTree/chromium/WebViewHost.h:
4164
4165 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
4166
4167         [Qt] Some css3 filter tests are failing after r104698
4168         https://bugs.webkit.org/show_bug.cgi?id=76055
4169
4170         Reviewed by Simon Hausmann.
4171
4172         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4173         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
4174
4175 2012-01-11  Tony Chang  <tony@chromium.org>
4176
4177         Don't remove 0 byte files when running build-webkit --chromium
4178         https://bugs.webkit.org/show_bug.cgi?id=75997
4179
4180         Reviewed by Csaba Osztrogonác.
4181
4182         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
4183
4184         * Scripts/webkitdirs.pm:
4185         (determineIsQt):
4186
4187 2012-01-10  David Kilzer  <ddkilzer@apple.com>
4188
4189         Add TestWebKitAPI tests for KURL
4190         <http://webkit.org/b/75774>
4191
4192         Reviewed by Adam Barth.
4193
4194         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
4195         WebCore folder and KURL.cpp source file to the project.
4196         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
4197         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
4198         during setup since this test doesn't go through WebKit or
4199         WebKit2.
4200         (TestWebKitAPI::TEST_F): Add two basic tests.
4201
4202 2012-01-10  David Kilzer  <ddkilzer@apple.com>
4203
4204         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
4205
4206         Reviewed by Adam Barth.
4207
4208         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
4209
4210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
4211         WTFStringUtilities.h to the project.
4212         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
4213         WTFStringUtilities.h.
4214         * TestWebKitAPI/WTFStringUtilities.h: Added.
4215         (WTF::operator<<):
4216
4217 2012-01-10  Vincent Scheib  <scheib@chromium.org>
4218
4219         Clarify run-webkit-tests options reset-results and new-baseline
4220         https://bugs.webkit.org/show_bug.cgi?id=75993
4221
4222         Reviewed by Dirk Pranke.
4223
4224         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4225         (parse_args):
4226
4227 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
4228
4229         Disabled mock scrollbars should draw differently
4230         https://bugs.webkit.org/show_bug.cgi?id=75995
4231
4232         Reviewed by James Robinson.
4233
4234         When the scrollbar is disabled, paint the entire track of
4235         mock scrollbars with a lighter gray, and hide the thumb.
4236
4237         * DumpRenderTree/mac/DumpRenderTree.mm:
4238         (-[DRTMockScroller drawKnob]):
4239         (-[DRTMockScroller drawRect:]):
4240
4241 2012-01-10  James Robinson  <jamesr@chromium.org>
4242
4243         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
4244         https://bugs.webkit.org/show_bug.cgi?id=75988
4245
4246         Reviewed by Adam Barth.
4247
4248         * Scripts/webkitpy/common/config/ports.py:
4249         (WebKitPort.run_webkit_unit_tests_command):
4250         (WebKitPort):
4251         (ChromiumPort.run_webkit_unit_tests_command):
4252         (ChromiumPort):
4253         * Scripts/webkitpy/common/config/ports_mock.py:
4254         (MockPort.run_webkit_unit_tests_command):
4255         * Scripts/webkitpy/tool/commands/download_unittest.py:
4256         (DownloadCommandsTest.test_build_and_test):
4257         (test_land):
4258         (test_land_red_builders):
4259         * Scripts/webkitpy/tool/steps/runtests.py:
4260         (RunTests.run):
4261         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
4262
4263 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
4264
4265         webkitpy: add os_name, os_version to platforminfo
4266         https://bugs.webkit.org/show_bug.cgi?id=75931
4267
4268         Reviewed by Eric Siedel.
4269
4270         As a first step in cleaning up the version parsing logic in
4271         webkitpy.layout_tests.port, this adds common routines for
4272         getting the os_name and os_version fields to the PlatformInfo
4273         class. Nothing uses them yet but I've added FIXME's to some of
4274         the code that needs to be deleted in the port files.
4275
4276         * Scripts/webkitpy/common/system/platforminfo.py:
4277         (PlatformInfo.__init__):
4278         (PlatformInfo):
4279         (PlatformInfo._determine_os_name):
4280         (PlatformInfo._determine_mac_version):
4281         (PlatformInfo._determine_linux_version):
4282         (PlatformInfo._determine_win_version):
4283         (PlatformInfo.display_name):
4284         (PlatformInfo.total_bytes_memory):
4285         (PlatformInfo._compute_bytes_from_vm_stat_output):
4286         (PlatformInfo.free_bytes_memory):
4287         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
4288         (TestPlatformInfo):
4289         (TestPlatformInfo.make_info):
4290         (TestPlatformInfo.make_info.mock_run_command):
4291         (TestPlatformInfo.setUp):
4292         (TestPlatformInfo.tearDown):
4293         (TestPlatformInfo.test_basic):
4294         (TestPlatformInfo.integration_test_basic):
4295         (TestPlatformInfo.test_display_name_mac):
4296         (TestPlatformInfo.test_display_name_win32):
4297         (TestPlatformInfo.test_memory_mac):
4298         (TestPlatformInfo.test_memory_win32):
4299         (TestPlatformInfo.test_determine_os_name):
4300         (TestPlatformInfo.test_determine_mac_version):
4301         (TestPlatformInfo.test_determine_linux_version):
4302         (TestPlatformInfo.test_determine_win_version_from_tuple):
4303         (TestPlatformInfo.test_determine_win_version_from_cmd):
4304         * Scripts/webkitpy/layout_tests/port/apple.py:
4305         (ApplePort.__init__):
4306         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4307         (ChromiumMacPort.__init__):
4308         * Scripts/webkitpy/layout_tests/port/mac.py:
4309         (MacPort):
4310         * Scripts/webkitpy/layout_tests/port/win.py:
4311         (WinPort):
4312
4313 2012-01-10  Adam Roben  <aroben@apple.com>
4314
4315         Make it possible to type data: URLs into MiniBrowser on Windows
4316
4317         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
4318         MiniBrowser on Windows
4319
4320         Reviewed by Darin Adler.
4321
4322         * MiniBrowser/win/BrowserWindow.cpp:
4323         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
4324         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
4325         does, we assume it already has a scheme and don't modify it.
4326
4327 2012-01-10  Adam Roben  <aroben@apple.com>
4328
4329         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
4330
4331         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
4332         MiniBrowser on Windows
4333
4334         Reviewed by Darin Adler.
4335
4336         * MiniBrowser/win/BrowserView.cpp:
4337         (BrowserView::goToURL): Pass the typed string through
4338         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
4339
4340 2012-01-10  Ben Wells  <benwells@chromium.org>
4341
4342         Adding myself (benwells) to committers.py
4343         https://bugs.webkit.org/show_bug.cgi?id=75971
4344
4345         Reviewed by Ojan Vafai.
4346
4347         * Scripts/webkitpy/common/config/committers.py:
4348
4349 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
4350
4351         AX: support helpText() in DumpRenderTree
4352         https://bugs.webkit.org/show_bug.cgi?id=40193
4353
4354         Reviewed by Chris Fleizach.
4355
4356         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4357         (AccessibilityUIElement::helpText): Implemented.
4358
4359 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
4360
4361         Unreviewed, rolling out r104572.
4362         http://trac.webkit.org/changeset/104572
4363         https://bugs.webkit.org/show_bug.cgi?id=75967
4364
4365         It broke zillion tests (Requested by Ossy on #webkit).
4366
4367         * DumpRenderTree/qt/EventSenderQt.cpp:
4368         (EventSender::EventSender):
4369         (EventSender::sendOrQueueEvent):