Prepare WebKit Buildbot master for Mavericks.
[WebKit-https.git] / Tools / ChangeLog
1 2013-10-22  Lucas Forschler  <lforschler@apple.com>
2
3         Prepare WebKit Buildbot master for Mavericks.
4         This adds the following bot configurations:
5             Mavericks Release/Debug builders
6             Mavericks Release/Debug WK1 Testers
7             Mavericks Release/Debug WK2 Testers
8
9         Unreviewed.
10         
11         * BuildSlaveSupport/build.webkit.org-config/config.json:
12
13 2013-10-21  Tamas Gergely  <gertom@inf.u-szeged.hu>
14
15         Run tests as if they are expected to pass when --force is given.
16         https://bugs.webkit.org/show_bug.cgi?id=112890
17
18         Reviewed by Ryosuke Niwa.
19
20         The --force switch of new-run-webkit-tests is now forces all tests to
21         be run with 'PASS' as expected result.
22
23         * Scripts/webkitpy/layout_tests/controllers/manager.py:
24         (Manager.run):
25         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
26         (TestExpectations.__init__):
27         (TestExpectations._add_expectations):
28         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
29         (parse_args):
30         (_set_up_derived_options):
31
32 2013-10-21  Mark Rowe  <mrowe@apple.com>
33
34         Add a version of WebKitSystemInterface for Mavericks.
35
36         Reviewed by Ryosuke Niwa.
37
38         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
39         * Scripts/copy-webkitlibraries-to-product-directory:
40         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
41
42 2013-10-21  Anders Carlsson  <andersca@apple.com>
43
44         Navigation policy callback not called when performing the same fragment navigation twice
45         https://bugs.webkit.org/show_bug.cgi?id=123121
46         <rdar://problem/15230466>
47
48         Reviewed by Beth Dakin.
49
50         Add a test.
51
52         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
53         * TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
54         * TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.
55         (+[WebKit1FragmentNavigationTestDelegate shared]):
56         (-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
57         (-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
58         (-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
59         (-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
60         (TestWebKitAPI::TEST):
61
62 2013-10-21  Dan Bernstein  <mitz@apple.com>
63
64         Style checker should allow a space after the @property keyword
65         https://bugs.webkit.org/show_bug.cgi?id=123117
66
67         Reviewed by Anders Carlsson.
68
69         * Scripts/webkitpy/style/checkers/cpp.py:
70         (check_spacing_for_function_call): Allow a space between @property and the following (
71         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
72         (CppStyleTest.test_spacing_for_fncall): Added a test case.
73
74 2013-10-21  peavo@outlook.com  <peavo@outlook.com>
75
76         [WinCairo] Build does not start.
77         https://bugs.webkit.org/show_bug.cgi?id=123059
78
79         Reviewed by Csaba Osztrogonác.
80
81         The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.
82
83         * Scripts/build-webkit:
84
85 2013-10-21  Zan Dobersek  <zdobersek@igalia.com>
86
87         [Jhbuild] Bump the required Jhbuild revision
88         https://bugs.webkit.org/show_bug.cgi?id=123089
89
90         Reviewed by Carlos Garcia Campos.
91
92         * jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild
93         due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
94         in the Jhbuild source so a more recent revision of it should be used.
95
96 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
97
98         Mac build fix.
99
100         * DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.
101
102 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
103
104         Enable webaudio/ tests on DRT/Mac
105         https://bugs.webkit.org/show_bug.cgi?id=86914
106
107         Reviewed by Darin Adler.
108
109         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
110         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
111         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.
112         There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.
113
114         * DumpRenderTree/TestRunner.cpp:
115         (setAudioResultCallback): 
116         (TestRunner::staticFunctions):
117         * DumpRenderTree/TestRunner.h:
118         (TestRunner::audioResult):
119         (TestRunner::setAudioResult):
120         The function has a different name and argument type now, updated accordingly.
121         Changed buffer from std::string to std::vector<char>, because it's more idiomatic.
122
123         * DumpRenderTree/mac/DumpRenderTree.mm:
124         (dumpAudio): Updated for the new name of audioResult accessor.
125         (dump): Print the result in the format webkitpy currently expects.
126
127         * WebKitTestRunner/TestInvocation.cpp:
128         (WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
129         chunks made no sense.
130
131         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
132         (WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.
133
134         * DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,
135         so that "SourceProvider.h" can be found.
136
137 2013-10-19  Ryosuke Niwa  <rniwa@webkit.org>
138
139         run-webkit-tests should submit time and modifiers to the new flakiness dashboard
140         https://bugs.webkit.org/show_bug.cgi?id=123070
141
142         Reviewed by Alexey Proskuryakov.
143
144         * Scripts/webkitpy/layout_tests/controllers/manager.py:
145         (Manager.run):
146         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
147         (summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
148         in the test expectations when this argument is set to true.
149
150 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
151
152         Mac DumpRenderTree builds without NDEBUG even in release mode
153         https://bugs.webkit.org/show_bug.cgi?id=123066
154
155         Reviewed by Dan Bernstein.
156
157         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
158         * DumpRenderTree/mac/Configurations/Base.xcconfig:
159         Use the same pattern as WebCore and WebKitTestRunner.
160
161 2013-10-19  Zan Dobersek  <zdobersek@igalia.com>
162
163         REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
164         https://bugs.webkit.org/show_bug.cgi?id=123064
165
166         Reviewed by Ryosuke Niwa.
167
168         Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.
169
170         * Scripts/webkitpy/common/config/ports.py: Added.
171         (DeprecatedPort):
172         (DeprecatedPort.name):
173         (DeprecatedPort.flag):
174         (DeprecatedPort.script_path):
175         (DeprecatedPort.script_shell_command):
176         (DeprecatedPort.port):
177         (DeprecatedPort.makeArgs):
178         (DeprecatedPort.update_webkit_command):
179         (DeprecatedPort.check_webkit_style_command):
180         (DeprecatedPort.prepare_changelog_command):
181         (DeprecatedPort.build_webkit_command):
182         (DeprecatedPort.run_javascriptcore_tests_command):
183         (DeprecatedPort.run_webkit_unit_tests_command):
184         (DeprecatedPort.run_webkit_tests_command):
185         (DeprecatedPort.run_python_unittests_command):
186         (DeprecatedPort.run_perl_unittests_command):
187         (DeprecatedPort.run_bindings_tests_command):
188         (MacPort):
189         (MacWK2Port):
190         (MacWK2Port.run_webkit_tests_command):
191         (WinPort):
192         (WinPort.run_bindings_tests_command):
193         (GtkPort):
194         (GtkPort.build_webkit_command):
195         (GtkPort.run_webkit_tests_command):
196         (GtkWK2Port):
197         (GtkWK2Port.build_webkit_command):
198         (GtkWK2Port.run_webkit_tests_command):
199         (QtPort):
200         (QtPort.build_webkit_command):
201         (QtPort.run_webkit_tests_command):
202         (QtWK2Port):
203         (QtWK2Port.build_webkit_command):
204         (QtWK2Port.run_webkit_tests_command):
205         (EflPort):
206         (EflPort.build_webkit_command):
207         (EflWK2Port):
208         (EflWK2Port.build_webkit_command):
209         * Scripts/webkitpy/common/config/ports_mock.py: Added.
210         (MockPort):
211         (MockPort.name):
212         (MockPort.check_webkit_style_command):
213         (MockPort.update_webkit_command):
214         (MockPort.build_webkit_command):
215         (MockPort.prepare_changelog_command):
216         (MockPort.run_python_unittests_command):
217         (MockPort.run_perl_unittests_command):
218         (MockPort.run_javascriptcore_tests_command):
219         (MockPort.run_webkit_unit_tests_command):
220         (MockPort.run_webkit_tests_command):
221         (MockPort.run_bindings_tests_command):
222         * Scripts/webkitpy/common/config/ports_unittest.py: Added.
223         (DeprecatedPortTest):
224         (DeprecatedPortTest.test_mac_port):
225         (DeprecatedPortTest.test_gtk_port):
226         (DeprecatedPortTest.test_gtk_wk2_port):
227         (DeprecatedPortTest.test_efl_port):
228         (DeprecatedPortTest.test_qt_port):
229         (DeprecatedPortTest.test_qt_wk2_port):
230         * Scripts/webkitpy/port/base.py:
231         (Port._port_flag_for_scripts):
232         (Port._wk2_port_name):
233         * Scripts/webkitpy/port/base_unittest.py:
234         (PortTest.test_build_path):
235         * Scripts/webkitpy/port/efl_unittest.py:
236         (EflPortTest.test_show_results_html_file):
237         * Scripts/webkitpy/port/gtk_unittest.py:
238         (GtkPortTest.test_get_crash_log):
239         * Scripts/webkitpy/port/mac_unittest.py:
240         (test_64bit):
241         * Scripts/webkitpy/port/test.py:
242         (TestPort.virtual_test_suites):
243         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
244         (FlakyTestReporter.__init__):
245         * Scripts/webkitpy/tool/bot/irc_command.py:
246         (Rollout._update_working_copy):
247         * Scripts/webkitpy/tool/commands/download_unittest.py:
248         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
249         (AbstractEarlyWarningSystem.run_command):
250         * Scripts/webkitpy/tool/commands/queues.py:
251         (PatchProcessingQueue.begin_work_queue):
252         (CommitQueue.run_command):
253         * Scripts/webkitpy/tool/main.py:
254         (WebKitPatch.__init__):
255         (WebKitPatch.deprecated_port):
256         (WebKitPatch.handle_global_options):
257         * Scripts/webkitpy/tool/mocktool.py:
258         (MockTool.__init__):
259         (MockTool.deprecated_port):
260         * Scripts/webkitpy/tool/steps/build.py:
261         (Build.build):
262         * Scripts/webkitpy/tool/steps/checkstyle.py:
263         (CheckStyle.run):
264         * Scripts/webkitpy/tool/steps/commit.py:
265         (Commit._check_test_expectations):
266         * Scripts/webkitpy/tool/steps/preparechangelog.py:
267         (PrepareChangeLog.run):
268         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
269         (PrepareChangeLogForRevert.run):
270         * Scripts/webkitpy/tool/steps/runtests.py:
271         (RunTests.run):
272         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
273         (RunTestsTest.test_webkit_run_unit_tests):
274         * Scripts/webkitpy/tool/steps/steps_unittest.py:
275         (StepsTest.test_runtests_args):
276         * Scripts/webkitpy/tool/steps/update.py:
277         (Update._update_command):
278         * Scripts/webkitpy/tool/steps/update_unittest.py:
279         (UpdateTest.test_update_command_non_interactive):
280         (UpdateTest.test_update_command_interactive):
281
282 2013-10-19  Andreas Kling  <akling@apple.com>
283
284         RefPtr::releaseNonNull() incorrectly increments the refcount.
285         <https://webkit.org/b/123063>
286
287         Add an API test to verify that no extra refs are added when calling
288         RefPtr::releaseNonNull().
289
290         Reviewed by Anders Carlsson.
291
292 2013-10-18  Rik Cabanier <cabanier@adobe.com>
293         Add Rik Cabanier to list of committers
294         https://bugs.webkit.org/show_bug.cgi?id=123031
295
296         reviewed by Dirk Schulze.
297
298         * Tools/Scripts/webkitpy/common/config/contributors.json: Added name.
299
300 2013-10-18  Denis Nomiyama  <d.nomiyama@samsung.com>
301
302         [ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
303         https://bugs.webkit.org/show_bug.cgi?id=122970
304
305         Reviewed by Mario Sanchez Prada.
306
307         Removed an invalid signal to set an object state to layout-complete
308         that does not exist. It was replaced by ATK:AtkDocument:load-complete.
309
310         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
311         (axObjectEventListener): Replaced layout-complete with load-complete.
312         (connectAccessibilityCallbacks): Connect callback to new listener for
313         ATK:AtkDocument:load-complete.
314         (disconnectAccessibilityCallbacks): Disconnect callback to new listener
315         for ATK:AtkDocument:load-complete.
316         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
317         (axObjectEventListener): Replaced layout-complete with load-complete.
318         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
319         Connect callback to new listener for ATK:AtkDocument:load-complete.
320         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
321         Disconnect callback to new listener for ATK:AtkDocument:load-complete.
322
323 2013-10-18  Carlos Garcia Campos  <cgarcia@igalia.com>
324
325         [GTK] Generate API documentation for GObject DOM bindings
326         https://bugs.webkit.org/show_bug.cgi?id=121538
327
328         Reviewed by Gustavo Noronha Silva.
329
330         The .symbols file that is now generated for checking GObject DOM
331         bindings API compatibility while building can also be used to
332         generate the files needed to produce the gtk-doc
333         documentation. The new script generate-webkitdom-doc-files can
334         generate the docs.sgml and sections.txt files from the given list
335         of .symbols files.
336
337         * gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml
338         and webkitdomgtk-sections.txt as well as rules to install the
339         generated WebKitDOMGTK documentation.
340         * gtk/generate-gtkdoc:
341         (webkitdom_docs_html_path): New helper function that returns the
342         path where the DOM API documentation has been generated.
343         (get_webkit2_options): Include DOM API docs to the list of xref
344         dependencies.
345         (get_webkit1_options): Ditto.
346         (get_webkitdom_options): Return the gtk-doc options to generate
347         the DOM API docs.
348         (get_webkitdom_options.derived_sources_path):
349         (get_webkitdom_options.src_path):
350         * gtk/generate-webkitdom-doc-files: Added.
351         (WebKitDOMDocGenerator):
352         (WebKitDOMDocGenerator.write_header):
353         (WebKitDOMDocGenerator.write_section):
354         (WebKitDOMDocGenerator.write_footer):
355         (WebKitDOMDocGeneratorDocs):
356         (WebKitDOMDocGeneratorDocs.write_header):
357         (write_section):
358         (write_footer):
359         (WebKitDOMDocGeneratorSections):
360         (WebKitDOMDocGeneratorSections.__init__):
361         (WebKitDOMDocGeneratorSections._dom_class):
362         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
363         (WebKitDOMDocGeneratorSections._symbol_list):
364         (WebKitDOMDocGeneratorSections.write_section):
365
366 2013-10-17  Alex Christensen  <achristensen@webkit.org>
367
368         Run JavaScriptCore tests again on Windows.
369         https://bugs.webkit.org/show_bug.cgi?id=122787
370
371         Reviewed by Tim Horton.
372
373         * Scripts/build-jsc:
374         (buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
375         * Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
376         * Scripts/webkitdirs.pm:
377         (determineConfigurationForVisualStudio):
378         (determineConfigurationProductDir):
379         Build directory should end with bin64 and configuration should end with |x64 on Win64.
380         (isAppleWinWebKit):
381         (copyInspectorFrontendFiles):
382         (setPathForRunningWebKitApp):
383         Separated WinCairo directories and options from AppleWin.
384
385 2013-10-17  Mihnea Ovidenie  <mihnea@adobe.com>
386
387         Unreviewed. Add myself as a reviewer.
388
389         * Scripts/webkitpy/common/config/contributors.json:
390
391 2013-10-17  Andreas Kling  <akling@apple.com>
392
393         Make it possible to assign a PassRef to a RefPtr.
394         <https://webkit.org/b/122943>
395
396         Added a small API test for RefPtr=(PassRef) so we know this code
397         will compile (and work.)
398
399         Reviewed by Antti Koivisto.
400
401 2013-10-16  Filip Pizlo  <fpizlo@apple.com>
402
403         We need test coverage for just the Baseline JIT
404         https://bugs.webkit.org/show_bug.cgi?id=122929
405
406         Reviewed by Sam Weinig.
407         
408         Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
409         variant.
410
411         * Scripts/run-jsc-stress-tests:
412
413 2013-10-16  Ryosuke Niwa  <rniwa@webkit.org>
414
415         Support multiple repositories in submitting results to --results-server-host
416         https://bugs.webkit.org/show_bug.cgi?id=122935
417
418         Reviewed by Anders Carlsson.
419
420         Remoevd --got-revision and added the logic to extract revision information
421         from multiple repositories as done in run-perf-tests.
422
423         * Scripts/webkitpy/layout_tests/controllers/manager.py:
424         (Manager.upload_results):
425         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
426         (parse_args):
427
428 2013-10-16  Darin Adler  <darin@apple.com>
429
430         Add PassRef and createRefCounted so we can improve creation of RefCounted objects
431         https://bugs.webkit.org/show_bug.cgi?id=122904
432
433         Reviewed by Anders Carlsson.
434
435         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
436
437 2013-10-16  Darin Adler  <darin@apple.com>
438
439         Need tests for RefPtr self-assignment and self-move-assignment.
440
441         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
442
443 2013-10-16  Robert Plociennik  <r.plociennik@samsung.com>
444
445         [EFL] Minibrowser can't load child window's location
446         https://bugs.webkit.org/show_bug.cgi?id=122485
447
448         Reviewed by Gyuyoung Kim.
449
450         * MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
451             followed by an explicit call to ewk_view_url_set() where appropriate.
452         (on_key_down):
453         (on_window_create):
454         (window_create):
455         (elm_main):
456
457 2013-10-15  Sergio Correia  <sergio.correia@openbossa.org>
458
459         [EFL][WK2] Make SeccompFilters build again after r156349 and r156353
460         https://bugs.webkit.org/show_bug.cgi?id=122872
461
462         Reviewed by Anders Carlsson.
463
464         * TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
465         failing.
466
467 2013-10-15  Dean Jackson  <dino@apple.com>
468
469         Add ENABLE_WEB_ANIMATIONS flag
470         https://bugs.webkit.org/show_bug.cgi?id=122871
471
472         Reviewed by Tim Horton.
473
474         Eventually might be http://dev.w3.org/fxtf/web-animations/
475         but this is just engine-internal work at the moment.
476
477         * Scripts/webkitperl/FeatureList.pm:
478
479 2013-10-15  Darin Adler  <darin@apple.com>
480
481         Add some API tests for Vector, RefPtr, and Ref
482         https://bugs.webkit.org/show_bug.cgi?id=122840
483
484         Reviewed by Andreas Kling.
485
486         * TestWebKitAPI/CMakeLists.txt: Added new files.
487         * TestWebKitAPI/GNUmakefile.am: Ditto.
488         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
489         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
491
492         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
493         * TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
494         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
495         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
496
497 2013-10-14  Roger Fong  <roger_fong@apple.com>
498
499         Adding myself to CC list for some components.
500
501         * Scripts/webkitpy/common/config/watchlist:
502
503 2013-10-13  Darin Adler  <darin@apple.com>
504
505         Deprecate or remove deleteAllValues functions; there are only a few call sites left
506         https://bugs.webkit.org/show_bug.cgi?id=122738
507
508         Reviewed by Anders Carlsson.
509
510         * DumpRenderTree/win/DRTDataObject.cpp:
511         (DRTDataObject::~DRTDataObject):
512         * DumpRenderTree/win/UIDelegate.cpp:
513         (DRTUndoStack::~DRTUndoStack):
514         (DRTUndoStack::clear):
515         Renamed deleteAllValues to deprecatedDeleteAllValues.
516
517         * Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
518
519 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
520
521         build.webkit.org/dashboard incorrectly shows interrupted builds as green
522         https://bugs.webkit.org/show_bug.cgi?id=122732
523
524         Reviewed by Tim Hatcher.
525
526         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
527         (BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
528         I don't see it occur any time in recent history, but judging from what happens for
529         status 5 (RETRY), we can just finish this function normally.
530         Record overall text description for iteration as BuildbotIteration.text.
531
532         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
533         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
534         but no tests failed, make it yellow, and use buildbot-provided description for it.
535
536 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
537
538         Remove Chromium specific code from flakiness dashboard
539         https://bugs.webkit.org/show_bug.cgi?id=122714
540
541         Reviewed by Sam Weinig.
542
543         Also removed code related to GPU tests and virtual suites.
544         "Fallbacks map" was chromium only too, not sure why they needed special handling there.
545
546         * TestResultServer/model/jsonresults_unittest.py:
547         * TestResultServer/static-dashboards/builders.js:
548         * TestResultServer/static-dashboards/dashboard_base.js:
549         * TestResultServer/static-dashboards/flakiness_dashboard.html:
550         * TestResultServer/static-dashboards/flakiness_dashboard.js:
551         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
552         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
553         * TestResultServer/static-dashboards/history.js:
554         * TestResultServer/static-dashboards/loader.js:
555         * TestResultServer/static-dashboards/ui.js:
556         * TestResultServer/templates/uploadform.html:
557
558 2013-10-11  Timothy Hatcher  <timothy@apple.com>
559
560         Remove preference support for picking the old Web Inspector.
561         https://bugs.webkit.org/show_bug.cgi?id=122655
562
563         Reviewed by Alexey Proskuryakov.
564
565         * WebKitTestRunner/TestController.cpp:
566         (WTR::TestController::resetStateToConsistentValues):
567
568 2013-10-11  Filip Pizlo  <fpizlo@apple.com>
569
570         Fix 64-bit build on everything but Windows.
571
572         Rubber stamped by Brent Fulgham.
573
574         * Scripts/webkitdirs.pm:
575         (argumentsForConfiguration):
576
577 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
578
579         Touch a file to see how auto-update works.
580
581         Rubber-stamped by Tim Hatcher.
582
583         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
584
585 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
586
587         LeaksViewer fails to present recent results list if current build is still updating svn
588         https://bugs.webkit.org/show_bug.cgi?id=122670
589
590         Fixed an obvious mistake in the previous patch.
591
592         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
593         (RecentBuildsLoader.prototype.start):
594
595 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
596
597         LeaksViewer fails to present recent results list if current build is still updating svn
598         https://bugs.webkit.org/show_bug.cgi?id=122670
599
600         Reviewed by Adam Roben.
601
602         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
603         (RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
604
605 2013-10-11  Brent Fulgham  <bfulgham@apple.com>
606
607         Unreviewed build fix for --64-bit target.
608
609         * Scripts/webkitdirs.pm:
610         (argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
611         been removed by this point.
612         (hasArgument): Remove unused temporary.
613
614 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
615
616         webkit-patch failure-reason has a quite low limit for 'too many failures'
617         https://bugs.webkit.org/show_bug.cgi?id=122556
618
619         Reviewed by Darin Adler.
620
621         * Scripts/webkitpy/tool/commands/queries.py:
622         (FailureReason._explain_failures_for_builder): adjust the number of too many failures
623         to match what the layout test runners use these days.
624
625 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
626
627         webkit-patch failure-reason should allow specifying failures one is interested in
628         https://bugs.webkit.org/show_bug.cgi?id=122554
629
630         Reviewed by Darin Adler.
631
632         * Scripts/webkitpy/tool/commands/queries.py:
633         (FailureReason):
634         (FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
635         loop if the ones we're interested in been explained.
636         (FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
637         (FailureReason.execute): initialize failures to explain and the explained set.
638
639 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
640
641         Make sure that DataTypes.h is in the binary drop.
642
643         Rubber stamped by Michael Saboff.
644
645         * Scripts/export-llvm-build:
646
647 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
648
649         FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
650         https://bugs.webkit.org/show_bug.cgi?id=122566
651
652         Reviewed by Mark Rowe.
653
654         * Scripts/configure-llvm:
655
656 2013-10-10  Mark Rowe  <mrowe@apple.com>
657
658         <rdar://problem/13341666> WebKit should always build against an SDK.
659
660         Have all projects default to building against the OS X Internal SDK for the Production
661         configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
662         to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
663
664         Reviewed by Dan Bernstein.
665
666         * DumpRenderTree/mac/Configurations/Base.xcconfig:
667         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
668         * MiniBrowser/Configurations/Base.xcconfig:
669         * MiniBrowser/Configurations/DebugRelease.xcconfig:
670         * TestWebKitAPI/Configurations/Base.xcconfig:
671         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
672         * WebKitTestRunner/Configurations/Base.xcconfig:
673         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
674
675 2013-10-10  Gustavo Noronha Silva  <gns@gnome.org>
676
677         Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
678
679         * Scripts/run-gtk-tests:
680         (TestRunner): skip TestInspectorServer.
681
682 2013-10-10  Andres Gomez  <agomez@igalia.com>
683
684         [GTK] Provide search functionality to MiniBrowser
685         https://bugs.webkit.org/show_bug.cgi?id=117631
686
687         Reviewed by Carlos Garcia Campos.
688
689         Adds a search bar to MiniBrowser with the minimum functionality
690         and a new button to the toolbar for showing the new search
691         bar. Typical keyboard shortcuts are also added.
692
693         * MiniBrowser/gtk/BrowserSearchBar.c: Added.
694         (doSearch):
695         (searchNext):
696         (searchPrevious):
697         (searchCloseButtonClickedCallback):
698         (searchEntryMenuIconPressedCallback):
699         (searchEntryClearIconReleasedCallback):
700         (searchEntryChangedCallback):
701         (searchEntryActivatedCallback):
702         (searchPrevButtonClickedCallback):
703         (searchNextButtonClickedCallback):
704         (searchMenuCheckButtonToggledCallback):
705         (browser_search_bar_init):
706         (browserSearchBarFinalize):
707         (browser_search_bar_class_init):
708         (browser_search_bar_new):
709         (browser_search_bar_add_accelerators):
710         (browser_search_bar_open):
711         (browser_search_bar_close):
712         * MiniBrowser/gtk/BrowserSearchBar.h: Added.
713         * MiniBrowser/gtk/BrowserWindow.c:
714         (webViewEnterFullScreen): Closes new search bar.
715         (webViewLeaveFullScreen): Opens new search bar if previously
716         visible.
717         (searchCallback): Added. Shows and hides the new search bar.
718         (browser_window_init): Added search button to the toolbar.
719         (browserWindowConstructed): Creates the new search bar.
720         * MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
721
722 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
723
724         webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
725         https://bugs.webkit.org/show_bug.cgi?id=122552
726
727         Reviewed by Darin Adler.
728
729         * Scripts/webkitpy/common/checkout/commitinfo.py:
730         (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
731         will cause UnicodeDecodeError for non-ascii characters.
732
733 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
734
735         Would like a link to dashboard from build.webkit.org main page
736         https://bugs.webkit.org/show_bug.cgi?id=122577
737
738         Reviewed by Tim Hatcher.
739
740         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
741
742 2013-10-09  Brent Fulgham  <bfulgham@apple.com>
743
744         [Win] Check for MathML fonts and warn user if they are missing.
745         https://bugs.webkit.org/show_bug.cgi?id=122568
746
747         Reviewed by Tim Horton.
748
749         * Scripts/webkitdirs.pm:
750         (checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
751         Windows-specific code I added previously.
752         (fontExists): Added
753         (checkInstalledTools): Add check for MathML fonts.
754
755 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
756
757         http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
758         https://bugs.webkit.org/show_bug.cgi?id=122471
759
760         Reviewed by Tim Hatcher.
761
762         Added links to webkitpy, webkitperl and bindings-tests results.
763
764         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
765         (Buildbot.prototype.apiTestResultsURLForIteration):
766         (Buildbot.prototype.webkitpyTestResultsURLForIteration):
767         (Buildbot.prototype.webkitperlTestResultsURLForIteration):
768         (Buildbot.prototype.bindingsTestResultsURLForIteration):
769         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
770         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
771
772 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
773
774         Move some functions from WebKitBuildbot to Buildbot class.
775
776         Suggested by Tim Hatcher.
777
778         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
779         (Buildbot.prototype.javascriptTestResultsURLForIteration):
780         (Buildbot.prototype.apiTestResultsURLForIteration):
781         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
782         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
783
784 2013-10-09  Timothy Hatcher  <timothy@apple.com>
785
786         Add API tests to the Dashbord page.
787
788         https://bugs.webkit.org/show_bug.cgi?id=122283
789
790         Reviewed by Timothy Hatcher.
791
792         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
793         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
794         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
795         (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
796
797 2013-10-09  Timothy Hatcher  <timothy@apple.com>
798
799         Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
800
801         https://bugs.webkit.org/show_bug.cgi?id=122515
802
803         Reviewed by Alexey Proskuryakov.
804
805         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
806         (BuildbotIteration.prototype.update):
807
808 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
809
810         build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
811         https://bugs.webkit.org/show_bug.cgi?id=122573
812
813         Reviewed by Tim Hatcher.
814
815         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
816         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
817
818         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
819         (Buildbot.prototype.buildPageURLForIteration): Added.
820
821 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
822
823         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
824         https://bugs.webkit.org/show_bug.cgi?id=122569
825
826         Reviewed by Tim Hatcher.
827
828         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
829         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
830         to be produced by the old Mozilla test harness that we don't use any more.
831
832 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
833
834         Add GTK 64 bits release to the buildbot dashboard
835         https://bugs.webkit.org/show_bug.cgi?id=122548
836
837         Reviewed by Darin Adler.
838
839         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
840         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
841         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
842         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
843         (table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
844
845 2013-10-09  Mario Sanchez Prada  <mario.prada@samsung.com>
846
847         [ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
848         https://bugs.webkit.org/show_bug.cgi?id=120638
849
850         Reviewed by Gustavo Noronha Silva.
851
852         * gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
853         can check both the old and new APIs to retrieve text at a given offset.
854
855 2013-10-08  Alex Christensen  <achristensen@webkit.org>
856
857         Improved WinLauncher.
858         https://bugs.webkit.org/show_bug.cgi?id=122536
859
860         Reviewed by Brent Fulgham.
861
862         * WinLauncher/PrintWebUIDelegate.cpp:
863         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
864         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
865         * WinLauncher/PrintWebUIDelegate.h: Removed stubs.
866         * WinLauncher/WinLauncher.cpp:
867         (createCrashReport): Use the executable name instead of "WinLauncher".
868         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
869         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
870         * win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
871
872 2013-10-08  Mark Lam  <mark.lam@apple.com>
873
874         Fix ruby LoadError when running run-javascriptcore-tests.
875         https://bugs.webkit.org/show_bug.cgi?id=122519.
876
877         Reviewed by Mark Hahnenberg.
878
879         The scripts needed to explicitly require 'rubygems' for older versions of ruby
880         (versions before 1.9).
881
882         * Scripts/jsc-stress-test-helpers/profiler-test-helper:
883         * Scripts/run-jsc-stress-tests:
884
885 2013-10-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
886
887         Unreviewed, add my new email to contributors.json.
888
889         * Scripts/webkitpy/common/config/contributors.json:
890
891 2013-10-08  Brent Fulgham  <bfulgham@apple.com>
892
893         Unreviewed build correction.
894
895         * Scripts/webkitpy/port/win.py:
896         (WinPort.write_registry_value): Use string representation of error message to avoid
897         format conversion problem.
898
899 2013-10-07  Brent Fulgham  <bfulgham@apple.com>
900
901         [Win] Add checks for proper build and test environment
902         https://bugs.webkit.org/show_bug.cgi?id=122466
903
904         Reviewed by Darin Adler.
905
906         This patch makes two changes:
907         1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or
908            error messages so that people know what to fix to get things working.
909         2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure
910            the various environment settings are properly configured for our test environment.
911
912         * Scripts/webkitdirs.pm:
913         (checkInstalledTools): Add checks for some common Cygwin configuration problems that have
914         caused problems in the past.
915         (setupAppleWinEnv):
916         * Scripts/webkitpy/port/win.py:
917         (WinPort):
918         (WinPort.read_registry_string): Parameterize for run architecture and registry root.
919         (WinPort.write_registry_value): Parameterize registry writing by data type (string versus
920         DWORD, etc.)
921         (WinPort.write_registry_string): Revise to call new generic registry write function.
922         (WinPort.setup_crash_log_saving): Revise for new API
923         (WinPort.restore_crash_log_saving): Ditto
924         (WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
925         servers from running.
926         (WinPort.allow_error_dialogs): Ditto.
927         (WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
928         (WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
929
930 2013-10-08  Philippe Normand  <pnormand@igalia.com>
931
932         [GStreamer] enable v4l2 plugin
933         https://bugs.webkit.org/show_bug.cgi?id=122503
934
935         Reviewed by Martin Robinson.
936
937         * gtk/jhbuild.modules: Enable the plugin, it now builds fine since
938         we updated our GStreamer version to 1.0.8.
939
940 2013-10-08  Mario Sanchez Prada  <mario.prada@samsung.com>
941
942         [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
943         https://bugs.webkit.org/show_bug.cgi?id=122104
944
945         Reviewed by Chris Fleizach.
946
947         Updated stringAttributeValue to double check that the exposure of
948         aria-invalid as a state is consistent with its exposure as a text
949         attribute as well, when it applies (implementations of AtkText).
950
951         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
952         (AccessibilityUIElement::stringAttributeValue): Add double check.
953         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
954         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
955
956 2013-10-07  Filip Pizlo  <fpizlo@apple.com>
957
958         run-jsc-stress-tests progress meter should update more quickly on older Rubies
959         https://bugs.webkit.org/show_bug.cgi?id=122459
960
961         Reviewed by Darin Adler.
962
963         * Scripts/run-jsc-stress-tests:
964
965 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
966
967         [buildbot] parse tests that are reported as crashed correctly for GTK+
968         https://bugs.webkit.org/show_bug.cgi?id=122476
969
970         Reviewed by Martin Robinson.
971
972         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
973         (RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
974         as a failure of the API tests.
975
976 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
977
978         Unreviewed. Skipping API test that is causing the next one to crash,
979         see https://bugs.webkit.org/show_bug.cgi?id=121970.
980
981         * Scripts/run-gtk-tests:
982         (TestRunner):
983
984 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
985
986         [GTK] run-gtk-tests does not distinguish between failure and crashes
987         https://bugs.webkit.org/show_bug.cgi?id=122135
988
989         Reviewed by Martin Robinson.
990
991         The GTK+ API test runner does not distinguish between failures and crashes. This change
992         makes it do that, so it's easier for us to spot the more important/higher priority crash
993         case.
994
995         * Scripts/run-gtk-tests:
996         (TestRunner._run_test_command): return the exit code instead of a boolean true/false,
997         so we have more information on how the process ended.
998         (TestRunner._run_test): check the exit code to distinguish between crashes and failures.
999         (TestRunner.run_tests): report crashes.
1000
1001 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1002
1003         [GTK] Missing packages for APT on install-dependencies
1004         https://bugs.webkit.org/show_bug.cgi?id=121555
1005
1006         Reviewed by Martin Robinson.
1007
1008         * gtk/install-dependencies: add packages that are needed for
1009         building WebKit itself and the jhbuild dependencies.
1010
1011 2013-10-07  Anders Carlsson  <andersca@apple.com>
1012
1013         Fix test failures.
1014
1015         * Scripts/webkitpy/port/base.py:
1016         (Port.to.start_helper):
1017         * Scripts/webkitpy/port/mock_drt.py:
1018         (MockDRTPort.start_helper):
1019
1020 2013-10-07  Anders Carlsson  <andersca@apple.com>
1021
1022         Always force discrete mode when running layout tests
1023         https://bugs.webkit.org/show_bug.cgi?id=122465
1024
1025         Reviewed by Tim Horton.
1026
1027         This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
1028         
1029         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1030         Link with IOKit.
1031
1032         * DumpRenderTree/mac/LayoutTestHelper.m:
1033         (installLayoutTestColorProfile):
1034         Check installColorProfile.
1035
1036         (restoreUserColorProfile):
1037         Check installColorProfile.
1038
1039         (lockDownDiscreteGraphics):
1040         New function to force discrete graphics.
1041
1042         (main):
1043         Add '--install-color-profile' option.
1044
1045         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1046         (Manager._set_up_run):
1047         Always start the helper, but pass self._options.pixel_tests to it.
1048
1049         * Scripts/webkitpy/port/mac.py:
1050         (MacPort.start_helper):
1051         Pass --install-color-profile' to the helper if pixel_tests is true.
1052
1053 2013-10-07  Timothy Hatcher  <timothy@apple.com>
1054
1055         Properly count binding test failures as failures.
1056
1057         Fix the total for multiple failures in different steps too by avoiding undefined.
1058
1059         https://bugs.webkit.org/show_bug.cgi?id=122232
1060
1061         Reviewed by Alexey Proskuryakov.
1062
1063         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1064         (BuildbotTestResults):
1065         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1066         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1067
1068 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1069
1070         [GTK] Fails to build with jhbuild with newer system glib
1071         https://bugs.webkit.org/show_bug.cgi?id=122132
1072
1073         Reviewed by Martin Robinson.
1074
1075         Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
1076         started relying on. glib is not a dependency that should change test results, and is provided in
1077         jhbuild with the intention of supporting the other bits that do, so using a newer stable release
1078         should not be an issue.
1079
1080         * gtk/jhbuild.modules:
1081
1082 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1083
1084         run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
1085         https://bugs.webkit.org/show_bug.cgi?id=122437
1086
1087         Reviewed by Antoine Quint.
1088
1089         * Scripts/run-jsc-stress-tests:
1090
1091 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1092
1093         Unreviewed, fix build on old Rubies.
1094
1095         * Scripts/run-jsc-stress-tests:
1096
1097 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1098
1099         Unified test infrastructure via the jsc shell
1100         https://bugs.webkit.org/show_bug.cgi?id=120696
1101
1102         Reviewed by Oliver Hunt.
1103         
1104         Make run-jsc-stress-tests smart enough to be able to handle different styles of test
1105         output (silent or noisy) and different styles of test failure (just bad exit code,
1106         text diff, filtering for some magical text, etc.). This allows me to get rid of the
1107         layout-test-helper. It also allows me to switch all of the old Mozilla tests to
1108         running in run-jsc-stress-tests.
1109         
1110         Also removes all of the code paths that defended against not having shellwords. Just
1111         install the shellwords gem if you want to run tests.
1112         
1113         Also removes the non-parallel test running code. No reason for it to exist anymore.
1114         
1115         This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
1116         as part of this patch, and left three more as new bugzillas.
1117
1118         * Scripts/create-mozilla-js-test-list: Added.
1119         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
1120         * Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
1121         * Scripts/run-javascriptcore-tests:
1122         * Scripts/run-jsc-stress-tests:
1123
1124 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1125
1126         run-jsc-stress-tests should be less verbose
1127         https://bugs.webkit.org/show_bug.cgi?id=122397
1128
1129         Reviewed by Sam Weinig.
1130         
1131         It now just prints something like:
1132         
1133          965/1831 ....
1134         
1135         Where the first number is the number of tests that completed, the second number is the
1136         number of tests total, and the dots are the number of tests running right now - which is
1137         useful towards the end when you're waiting for the last slow tests to finish.
1138         
1139         It will also print out the output from failing tests and it will print a line for skipped
1140         tests (to annoy you into getting them into a shape where they can be unskipped). For
1141         example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
1142
1143         * Scripts/run-jsc-stress-tests:
1144
1145 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1146
1147         Allow skipping of run-jsc-stress-tests that are configured using yaml files
1148         https://bugs.webkit.org/show_bug.cgi?id=122385
1149
1150         Reviewed by Sam Wieinig.
1151         
1152         Make tests run via YAML be able to do the parse-for-commands trick that allows
1153         us to skip tests and do other custom per-test stuff.
1154
1155         * Scripts/jsc-stress-test-helpers/layout-test-helper:
1156         * Scripts/run-jsc-stress-tests:
1157
1158 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1159
1160         Unreviewed, fix tests on older Rubies.
1161
1162         * Scripts/run-jsc-stress-tests:
1163
1164 2013-10-05  Anders Carlsson  <andersca@apple.com>
1165
1166         Don't filter the weak symbols.
1167
1168         * Scripts/check-for-weak-vtables-and-externals:
1169
1170 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1171
1172         Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
1173         https://bugs.webkit.org/show_bug.cgi?id=122376
1174
1175         Reviewed by Mark Hahnenberg.
1176
1177         * Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
1178         * Scripts/run-javascriptcore-tests:
1179         (printThingsFound):
1180         * Scripts/run-jsc-stress-tests:
1181
1182 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1183
1184         It should be even easier to run and debug a failing JSC stress test
1185         https://bugs.webkit.org/show_bug.cgi?id=122337
1186
1187         Reviewed by Oliver Hunt.
1188         
1189         If a test fails, you can now just say:
1190
1191         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
1192
1193         and get the reproduction. You don't have to set any environment variables like before.
1194         Also if you want to debug the failing test you can now just say:
1195
1196         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
1197
1198         Broadly, any arguments passed to the reproduction script are prepended to the command to
1199         run the test. This is sort of quirky and won't work for some tests (for example the
1200         profiler tests run a ruby script that runs some other stuff) but it'll work for most of
1201         them and that's good enough for now.
1202
1203         * Scripts/run-jsc-stress-tests:
1204
1205 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1206
1207         [Windows] Correct run-path when using 64-bit binaries.
1208
1209         Reviewed by David Kilzer.
1210
1211         * Scripts/webkitdirs.pm:
1212         (determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
1213         directory. Otherwise use the existing 'bin32' directory.
1214
1215 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1216
1217         Teach webkitdirs.pm to honor the --64-bit flag
1218         https://bugs.webkit.org/show_bug.cgi?id=122357
1219
1220         Reviewed by David Kilzer.
1221
1222         * Scripts/webkitdirs.pm:
1223         (argumentsForConfiguration): Modify to check if --64-bit is supplied
1224         by the user.
1225         (findMatchingArguments): Added.
1226         (hasArgument): Added.
1227         (checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
1228         findMatchingArguments subroutine.
1229
1230 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1231
1232         Update svn-config for new Visual Studio extensions
1233         https://bugs.webkit.org/show_bug.cgi?id=122344
1234
1235         Reviewed by Brent Fulgham.
1236
1237         * svn-config: Add new Visual Studio extensions.
1238
1239 2013-10-04  Alex Christensen  <achristensen@webkit.org>
1240
1241         Made WinLauncher have better error handling, crash reporting, and modifiability.
1242         https://bugs.webkit.org/show_bug.cgi?id=122319
1243
1244         Reviewed by Brent Fulgham.
1245
1246         * WinLauncher/WinLauncher.cpp:
1247         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1248         Don't display the numerous "Cancelled" messages that are obviously from the user.
1249         (createCrashReport): Added.
1250         (dllLauncherEntryPoint):
1251         Made main loop back into while loop and write a crash report if it crashes.
1252         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1253         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1254         Added WinLauncherReplace.h.
1255         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
1256         Added linking to DbgHelp.lib.
1257         * WinLauncher/WinLauncherReplace.h:
1258         Added to make modifying WinLauncher behaviour and appearance easy.
1259         (processCrashDump): Added.
1260
1261 2013-10-04  Dirk Pranke  <dpranke@chromium.org>
1262
1263         remove dpranke from webkitpy watchlist
1264         https://bugs.webkit.org/show_bug.cgi?id=122331
1265
1266         Reviewed by Brent Fulgham.
1267
1268         * Scripts/webkitpy/common/config/watchlist:
1269
1270 2013-10-04  Tim Horton  <timothy_horton@apple.com>
1271
1272         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1273         https://bugs.webkit.org/show_bug.cgi?id=122299
1274
1275         Reviewed by Beth Dakin.
1276
1277         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1278         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1279         The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
1280
1281 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1282
1283         Watchlist is broken after <http://trac.webkit.org/r156880>
1284
1285         * Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
1286
1287 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1288
1289         Remove Qt features from build and test tools
1290         https://bugs.webkit.org/show_bug.cgi?id=122312
1291
1292         Reviewed by Anders Carlsson.
1293
1294         * Scripts/build-dumprendertree:
1295         * Scripts/build-jsc:
1296         * Scripts/build-webkit:
1297         * Scripts/build-webkittestrunner:
1298         * Scripts/old-run-webkit-tests:
1299         (openDumpTool):
1300         (buildPlatformResultHierarchy):
1301         (buildPlatformTestHierarchy):
1302         (readSkippedFiles):
1303         * Scripts/run-launcher:
1304         * Scripts/run-qtwebkit-tests: Removed.
1305         * Scripts/run-webkit-tests:
1306         (useNewRunWebKitTests):
1307         * Scripts/update-webkit:
1308         * Scripts/webkit-build-directory:
1309         * Scripts/webkitdirs.pm:
1310         (argumentsForConfiguration):
1311         (jscProductDir):
1312         (builtDylibPathForName):
1313         (isAppleWebKit):
1314         (launcherPath):
1315         (launcherName):
1316         (checkRequiredSystemConfig):
1317         (setupCygwinEnv):
1318         (copyInspectorFrontendFiles):
1319         (setPathForRunningWebKitApp):
1320         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1321         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1322         (BaselineOptimizerTest.test_mac_future):
1323         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1324         (BaselineOptimizerTest.test_common_directory_includes_root):
1325         (BaselineOptimizerTest.test_virtual_ports_filtered):
1326         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1327         (test_parse_reviewer_text):
1328         * Scripts/webkitpy/common/config/watchlist:
1329         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1330         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
1331         * Scripts/webkitpy/port/base.py:
1332         (Port.__init__):
1333         (Port._port_flag_for_scripts):
1334         (Port._wk2_port_name):
1335         * Scripts/webkitpy/port/builders.py:
1336         * Scripts/webkitpy/port/factory.py:
1337         (platform_options):
1338         (PortFactory):
1339         (PortFactory._default_port):
1340         * Scripts/webkitpy/port/factory_unittest.py:
1341         (FactoryTest.test_gtk):
1342         * Scripts/webkitpy/port/qt.py: Removed.
1343         * Scripts/webkitpy/port/qt_unittest.py: Removed.
1344         * Scripts/webkitpy/style/checker.py:
1345         * Scripts/webkitpy/style/checker_unittest.py:
1346         (GlobalVariablesTest.test_path_rules_specifier):
1347         * Scripts/webkitpy/style/checkers/cmake.py:
1348         (CMakeChecker):
1349         * Scripts/webkitpy/style/checkers/cpp.py:
1350         (_classify_include):
1351         (check_include_line):
1352         (check_identifier_name_in_declaration):
1353         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1354         (OrderOfIncludesTest.test_classify_include):
1355         (WebKitStyleTest.test_names):
1356         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1357         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1358         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1359         (TestRebaselineTest.test_baseline_directory):
1360         * Scripts/webkitpy/tool/main.py:
1361         (WebKitPatch):
1362
1363 2013-10-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1364
1365         Unreviewed. Add myself to some watchlists.
1366
1367         * Scripts/webkitpy/common/config/watchlist:
1368
1369 2013-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1370
1371         Remove Qt builders from the flakiness dashboard.
1372
1373         * TestResultServer/static-dashboards/builders.jsonp:
1374         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1375         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1376         * TestResultServer/static-dashboards/loader_unittests.js:
1377
1378 2013-10-03  Tim Horton  <timothy_horton@apple.com>
1379
1380         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1381         https://bugs.webkit.org/show_bug.cgi?id=122299
1382
1383         Reviewed by Beth Dakin.
1384
1385         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1386         Disable threaded scrolling.
1387
1388         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1389         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1390         Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
1391
1392 2013-10-03  Anders Carlsson  <andersca@apple.com>
1393
1394         Use numeric strings in the OS version dictionary
1395         https://bugs.webkit.org/show_bug.cgi?id=122300
1396
1397         Reviewed by Mark Rowe.
1398
1399         * Scripts/webkitpy/common/system/platforminfo.py:
1400         (PlatformInfo._determine_mac_version):
1401
1402 2013-10-03  Alexey Proskuryakov  <ap@apple.com>
1403
1404         Fix LeaksViewer to load leaks results from MountainLion, not Lion.
1405
1406         Rubber-stamped by Tim Horton.
1407
1408         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1409         (LeaksViewer._displayURLPrompt):
1410
1411 2013-10-03  Dan Bernstein  <mitz@apple.com>
1412
1413         REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
1414         https://bugs.webkit.org/show_bug.cgi?id=122260
1415
1416         Reviewed by Alexey Proskuryakov.
1417
1418         For the API to work, the tests need to be compiled with a newer version of the LLVM
1419         compiler. Until the bots are updated to that version, disable the tests on 10.8.
1420
1421         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1422
1423 2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>
1424
1425         [ATK] Expose aria-invalid as a text attribute (not object attribute)
1426         https://bugs.webkit.org/show_bug.cgi?id=122015
1427
1428         Reviewed by Chris Fleizach.
1429
1430         Adapted DRT and WKTR to check the exposure of the aria-invalid
1431         attribute as a text attribute, instead of an object attribute.
1432
1433         Also, done some refactoring of the code to try to keep things
1434         simpler and more coherent, by defining new helper functions,
1435         simplifying code, moving static variables and functions into
1436         unnammed namespaces and so on, without altering the logic other
1437         than for checking the text attribute for aria-invalid.
1438
1439         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1440         (coreAttributeToAtkAttribute): Consider 'invalid' as the name of
1441         the attribute exposed by the ATK wrapper, not 'aria-invalid'.
1442         Also, never return an empty string if not falling through any of
1443         the cases checked here, and return the original attribute instead.
1444         (atkAttributeValueToCoreAttributeValue): New helper function to
1445         match the attributes values returned by the ATK wrapper with the
1446         values expected by the layout tests. Moved the mappings for the
1447         values of AXSortDirection here as well.
1448         (getAttributeSet): New helper function to retrieve a list of
1449         attributes (an AtkAttributeSet) from an AtkObject using the right
1450         API depending on whether we want the object attributes or the text
1451         attributes (in case the object implements AtkText).
1452         (getAttributeSetValueForId): Simplified by using getAttributeSet
1453         and atkAttributeValueToCoreAttributeValue. Also, added a new
1454         parameter to indicater whether we are interested in object
1455         attributes or text attributes.
1456         (getAtkAttributeSetAsString): Ditto.
1457         (attributesOfElement): Updated to pass the new required parameter
1458         to getAtkAttributeSetAsString, indicating that we want the object
1459         attributes in this case, for backwards compatibility.
1460         (indexRangeInTable): Moved up in the file into the unnammed namespace.
1461         (alterCurrentValue): Ditto.
1462         (AccessibilityUIElement::stringAttributeValue): After moving most
1463         of the code here to the new helper functions, simplified it by
1464         just checking whether the required attribute is provided as an
1465         object attribute or, if that's not the case, as a text attribute.
1466         (AccessibilityUIElement::isAttributeSupported): Ditto.
1467         (AccessibilityUIElement::intValue): Updated to pass the new
1468         required parameter to getAttributeSetValueForId, indicating that
1469         we want the object attributes in this case.
1470         (AccessibilityUIElement::hasPopup): Ditto.
1471
1472         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1473         (WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
1474         (WTR::atkAttributeValueToCoreAttributeValue): Ditto.
1475         (WTR::getAttributeSet): Ditto.
1476         (WTR::getAttributeSetValueForId): Ditto.
1477         (WTR::getAtkAttributeSetAsString): Ditto.
1478         (WTR::attributesOfElement): Ditto.
1479         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1480         (WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
1481         (WTR::AccessibilityUIElement::intValue): Ditto.
1482         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1483
1484 2013-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1485
1486         EWS build fix after the Qt EWS removal.
1487
1488         * QueueStatusServer/model/attachment.py:
1489         (Attachment._calculate_queue_positions):
1490
1491 2013-10-02  Anders Carlsson  <andersca@apple.com>
1492
1493         Remove Qt code from Tools/
1494         https://bugs.webkit.org/show_bug.cgi?id=122227
1495
1496         Reviewed by Andreas Kling.
1497
1498         * DumpRenderTree/WorkQueue.cpp:
1499         * DumpRenderTree/blackberry/src.pro: Removed.
1500         * DumpRenderTree/qt/DumpRenderTree.pro: Removed.
1501         * DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
1502         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
1503         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
1504         * DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
1505         * DumpRenderTree/qt/EventSenderQt.cpp: Removed.
1506         * DumpRenderTree/qt/EventSenderQt.h: Removed.
1507         * DumpRenderTree/qt/GCControllerQt.cpp: Removed.
1508         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
1509         * DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
1510         * DumpRenderTree/qt/TestRunnerQt.h: Removed.
1511         * DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
1512         * DumpRenderTree/qt/TextInputControllerQt.h: Removed.
1513         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
1514         * DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
1515         * DumpRenderTree/qt/fonts/AHEM____.TTF: Removed.
1516         * DumpRenderTree/qt/resources/user.css: Removed.
1517         * DumpRenderTree/qt/testplugin.cpp: Removed.
1518         * DumpRenderTree/qt/testplugin.h: Removed.
1519         * ImageDiff/ImageDiff.pro: Removed.
1520         * ImageDiff/qt/ImageDiff.cpp: Removed.
1521         * MiniBrowser/qt/BrowserWindow.cpp: Removed.
1522         * MiniBrowser/qt/BrowserWindow.h: Removed.
1523         * MiniBrowser/qt/MiniBrowser.pro: Removed.
1524         * MiniBrowser/qt/MiniBrowser.qrc: Removed.
1525         * MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
1526         * MiniBrowser/qt/MiniBrowserApplication.h: Removed.
1527         * MiniBrowser/qt/UrlLoader.cpp: Removed.
1528         * MiniBrowser/qt/UrlLoader.h: Removed.
1529         * MiniBrowser/qt/icons/checkbox_checked.png: Removed.
1530         * MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
1531         * MiniBrowser/qt/icons/contents_width.png: Removed.
1532         * MiniBrowser/qt/icons/favicon.png: Removed.
1533         * MiniBrowser/qt/icons/find.png: Removed.
1534         * MiniBrowser/qt/icons/folder.png: Removed.
1535         * MiniBrowser/qt/icons/info.png: Removed.
1536         * MiniBrowser/qt/icons/next.png: Removed.
1537         * MiniBrowser/qt/icons/plus.png: Removed.
1538         * MiniBrowser/qt/icons/previous.png: Removed.
1539         * MiniBrowser/qt/icons/refresh.png: Removed.
1540         * MiniBrowser/qt/icons/stop.png: Removed.
1541         * MiniBrowser/qt/icons/titlebar.png: Removed.
1542         * MiniBrowser/qt/icons/touch.png: Removed.
1543         * MiniBrowser/qt/icons/touchpoint.png: Removed.
1544         * MiniBrowser/qt/icons/up.png: Removed.
1545         * MiniBrowser/qt/js/MultiSelect.js: Removed.
1546         * MiniBrowser/qt/main.cpp: Removed.
1547         * MiniBrowser/qt/qml/AlertDialog.qml: Removed.
1548         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
1549         * MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
1550         * MiniBrowser/qt/qml/CheckBox.qml: Removed.
1551         * MiniBrowser/qt/qml/ColorChooser.qml: Removed.
1552         * MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
1553         * MiniBrowser/qt/qml/Dialog.qml: Removed.
1554         * MiniBrowser/qt/qml/DialogButton.qml: Removed.
1555         * MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
1556         * MiniBrowser/qt/qml/FilePicker.qml: Removed.
1557         * MiniBrowser/qt/qml/ItemSelector.qml: Removed.
1558         * MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
1559         * MiniBrowser/qt/qml/PromptDialog.qml: Removed.
1560         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
1561         * MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
1562         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
1563         * MiniBrowser/qt/raw/DerivedSources.pri: Removed.
1564         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
1565         * MiniBrowser/qt/raw/Target.pri: Removed.
1566         * MiniBrowser/qt/raw/View.cpp: Removed.
1567         * MiniBrowser/qt/raw/View.h: Removed.
1568         * MiniBrowser/qt/utils.cpp: Removed.
1569         * MiniBrowser/qt/utils.h: Removed.
1570         * QtTestBrowser/QtTestBrowser.pro: Removed.
1571         * QtTestBrowser/QtTestBrowser.qrc: Removed.
1572         * QtTestBrowser/cookiejar.cpp: Removed.
1573         * QtTestBrowser/cookiejar.h: Removed.
1574         * QtTestBrowser/favicon.png: Removed.
1575         * QtTestBrowser/fpstimer.cpp: Removed.
1576         * QtTestBrowser/fpstimer.h: Removed.
1577         * QtTestBrowser/launcherwindow.cpp: Removed.
1578         * QtTestBrowser/launcherwindow.h: Removed.
1579         * QtTestBrowser/locationedit.cpp: Removed.
1580         * QtTestBrowser/locationedit.h: Removed.
1581         * QtTestBrowser/mainwindow.cpp: Removed.
1582         * QtTestBrowser/mainwindow.h: Removed.
1583         * QtTestBrowser/qttestbrowser.cpp: Removed.
1584         * QtTestBrowser/urlloader.cpp: Removed.
1585         * QtTestBrowser/urlloader.h: Removed.
1586         * QtTestBrowser/useragentlist.txt: Removed.
1587         * QtTestBrowser/utils.cpp: Removed.
1588         * QtTestBrowser/utils.h: Removed.
1589         * QtTestBrowser/webinspector.h: Removed.
1590         * QtTestBrowser/webpage.cpp: Removed.
1591         * QtTestBrowser/webpage.h: Removed.
1592         * QtTestBrowser/webview.cpp: Removed.
1593         * QtTestBrowser/webview.h: Removed.
1594         * TestWebKitAPI/DerivedSources.pri: Removed.
1595         * TestWebKitAPI/InjectedBundle.pri: Removed.
1596         * TestWebKitAPI/PlatformWebView.h:
1597         * TestWebKitAPI/TestWebKitAPI.pri: Removed.
1598         * TestWebKitAPI/TestWebKitAPI.pro: Removed.
1599         * TestWebKitAPI/Tests.pri: Removed.
1600         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
1601         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
1602         * TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
1603         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
1604         * TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
1605         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
1606         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
1607         * TestWebKitAPI/qt/main.cpp: Removed.
1608         * Tools.pro: Removed.
1609         * WebKitTestRunner/DerivedSources.pri: Removed.
1610         * WebKitTestRunner/EventSenderProxy.h:
1611         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
1612         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
1613         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1614         (WTR::InjectedBundlePage::resetAfterTest):
1615         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1616         (WTR::InjectedBundlePage::didClearWindowForFrame):
1617         * WebKitTestRunner/InjectedBundle/Target.pri: Removed.
1618         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1619         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
1620         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
1621         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
1622         * WebKitTestRunner/PlatformWebView.h:
1623         * WebKitTestRunner/Target.pri: Removed.
1624         * WebKitTestRunner/TestController.cpp:
1625         (WTR::TestController::resetStateToConsistentValues):
1626         * WebKitTestRunner/TestController.h:
1627         * WebKitTestRunner/WebKitTestRunner.pro: Removed.
1628         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
1629         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
1630         * WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
1631         * WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
1632         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
1633         * WebKitTestRunner/qt/main.cpp: Removed.
1634         * WebKitTestRunner/qt/resources/user.css: Removed.
1635         * qmake/.qmake.cache: Removed.
1636         * qmake/.qmake.conf: Removed.
1637         * qmake/README: Removed.
1638         * qmake/config.tests/README: Removed.
1639         * qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
1640         * qmake/config.tests/fontconfig/fontconfig.pro: Removed.
1641         * qmake/config.tests/gccdepends/empty.cpp: Removed.
1642         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
1643         * qmake/config.tests/glx/glx.cpp: Removed.
1644         * qmake/config.tests/glx/glx.pro: Removed.
1645         * qmake/config.tests/gnuld/gnuld.pro: Removed.
1646         * qmake/config.tests/gnuld/main.cpp: Removed.
1647         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
1648         * qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
1649         * qmake/config.tests/libXrender/libXrender.cpp: Removed.
1650         * qmake/config.tests/libXrender/libXrender.pro: Removed.
1651         * qmake/config.tests/libwebp/libwebp.cpp: Removed.
1652         * qmake/config.tests/libwebp/libwebp.pro: Removed.
1653         * qmake/config.tests/libxml2/libxml2.cpp: Removed.
1654         * qmake/config.tests/libxml2/libxml2.pro: Removed.
1655         * qmake/config.tests/libxslt/libxslt.cpp: Removed.
1656         * qmake/config.tests/libxslt/libxslt.pro: Removed.
1657         * qmake/config.tests/libzlib/libzlib.cpp: Removed.
1658         * qmake/config.tests/libzlib/libzlib.pro: Removed.
1659         * qmake/dump-features.pl: Removed.
1660         * qmake/mkspecs/features/configure.prf: Removed.
1661         * qmake/mkspecs/features/default_post.prf: Removed.
1662         * qmake/mkspecs/features/default_pre.prf: Removed.
1663         * qmake/mkspecs/features/features.prf: Removed.
1664         * qmake/mkspecs/features/features.pri: Removed.
1665         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
1666         * qmake/mkspecs/features/functions.prf: Removed.
1667         * qmake/mkspecs/features/gprof.prf: Removed.
1668         * qmake/mkspecs/features/mac/default_post.prf: Removed.
1669         * qmake/mkspecs/features/mac/default_pre.prf: Removed.
1670         * qmake/mkspecs/features/minimal_qt.prf: Removed.
1671         * qmake/mkspecs/features/production_build.prf: Removed.
1672         * qmake/mkspecs/features/rpath.prf: Removed.
1673         * qmake/mkspecs/features/unix/default_post.prf: Removed.
1674         * qmake/mkspecs/features/unix/default_pre.prf: Removed.
1675         * qmake/mkspecs/features/unix/icc.prf: Removed.
1676         * qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
1677         * qmake/mkspecs/features/valgrind.prf: Removed.
1678         * qmake/mkspecs/features/webkit_modules.prf: Removed.
1679         * qmake/mkspecs/features/win32/default_post.prf: Removed.
1680         * qmake/mkspecs/features/win32/default_pre.prf: Removed.
1681         * qmake/mkspecs/modules/angle.prf: Removed.
1682         * qmake/mkspecs/modules/javascriptcore.prf: Removed.
1683         * qmake/mkspecs/modules/webcore.prf: Removed.
1684         * qmake/mkspecs/modules/webkit1.prf: Removed.
1685         * qmake/mkspecs/modules/webkit2.prf: Removed.
1686         * qmake/mkspecs/modules/wtf.prf: Removed.
1687
1688 2013-10-02  Tim Horton  <timothy_horton@apple.com>
1689
1690         [mac] Stop using DrawingAreaImpl on PLATFORM(MAC) 
1691         https://bugs.webkit.org/show_bug.cgi?id=121859
1692         <rdar://problem/15069359>
1693
1694         Reviewed by Anders Carlsson.
1695
1696         * WebKitTestRunner/TestInvocation.cpp:
1697         (WTR::shouldUseThreadedScrolling):
1698         (WTR::updateThreadedScrollingForCurrentTest):
1699         (WTR::TestInvocation::invoke):
1700         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1701         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
1702         (WTR::PlatformWebView::PlatformWebView):
1703         (WTR::PlatformWebView::viewSupportsOptions):
1704         Rename the tiled drawing switch to threaded scrolling, since that's really
1705         all it switches now that we use tiled drawing everywhere.
1706
1707         Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
1708         and to more closely match the case we're interested in testing.
1709
1710 2013-10-02  Anders Carlsson  <andersca@apple.com>
1711
1712         Move AHEM____.TTF from qt/fonts/ to fonts/.
1713
1714         Rubber-stamped by Andreas Kling.
1715
1716         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1717         * DumpRenderTree/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1718
1719 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
1720
1721         Remove Qt bots and EWS from trunk.
1722         https://bugs.webkit.org/show_bug.cgi?id=122210.
1723
1724         Reviewed by Allan Sandfeld Jensen.
1725
1726         Remove Qt buil dbots.
1727
1728         * BuildSlaveSupport/build.webkit.org-config/config.json:
1729         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1730         (appendCustomBuildFlags):
1731         (RunGtkAPITests.getText2):
1732         (Factory.__init__):
1733         (TestFactory.__init__):
1734         (BuildAndTestFactory.__init__):
1735         (loadBuilderConfig):
1736         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1737
1738 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
1739
1740         Remove Qt bots and EWS from trunk.
1741         https://bugs.webkit.org/show_bug.cgi?id=122210.
1742
1743         Reviewed by Allan Sandfeld Jensen.
1744
1745         Remove Qt EWS bots.
1746
1747         * QueueStatusServer/config/queues.py:
1748         * Scripts/webkitpy/common/config/ews.json:
1749
1750 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1751
1752         Fix singular labels for test failures.
1753
1754         https://bugs.webkit.org/show_bug.cgi?id=122200
1755
1756         Reviewed by Joseph Pecoraro.
1757
1758         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1759         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1760
1761 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1762
1763         Don't keep appending iterations each time the queue updates.
1764
1765         https://bugs.webkit.org/show_bug.cgi?id=122198
1766
1767         Reviewed by Joseph Pecoraro.
1768
1769         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1770         (BuildbotQueue.prototype.update):
1771
1772 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1773
1774         Properly sort iterations in the Dashboard by revision for out-of-order queues.
1775
1776         https://bugs.webkit.org/show_bug.cgi?id=122196
1777
1778         Reviewed by Brent Fulgham.
1779
1780         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1781         (BuildbotIteration):
1782         (BuildbotIteration.prototype.update):
1783         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1784         (BuildbotQueue.prototype.update):
1785         (BuildbotQueue.prototype.sortIterations):
1786
1787 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1788
1789         Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
1790
1791         Also fix some URLs to not have extras slashes and add a page title.
1792
1793         https://bugs.webkit.org/show_bug.cgi?id=122192
1794
1795         Reviewed by Joseph Pecoraro.
1796
1797         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1798         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1799         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1800         (WebKitBuildbot.prototype.buildLogURLForIteration):
1801         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
1802         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
1803         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1804
1805 2013-10-01  Alexey Proskuryakov  <ap@apple.com>
1806
1807         [Mac] Set NSApplication current event while sending events directly to views
1808         https://bugs.webkit.org/show_bug.cgi?id=122179
1809
1810         Reviewed by Darin Adler.
1811
1812         DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
1813         which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
1814         use the current event.
1815
1816         * DumpRenderTree/mac/EventSendingController.mm:
1817         (-[EventSendingController mouseDown:withModifiers:]):
1818         (-[EventSendingController mouseUp:withModifiers:]):
1819         (-[EventSendingController mouseMoveToX:Y:]):
1820         (-[EventSendingController mouseScrollByX:andY:continuously:]):
1821         (-[EventSendingController contextClick]):
1822         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1823         * WebKitTestRunner/mac/EventSenderProxy.mm:
1824         (WTR::EventSenderProxy::mouseDown):
1825         (WTR::EventSenderProxy::mouseUp):
1826         (WTR::EventSenderProxy::mouseMoveTo):
1827         (WTR::EventSenderProxy::keyDown):
1828         (WTR::EventSenderProxy::mouseScrollBy):
1829         Update the current event. We were already using the SPI in WebKit.
1830
1831 2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>
1832
1833         Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
1834         https://bugs.webkit.org/show_bug.cgi?id=122183
1835
1836         Reviewed by Timothy Hatcher.
1837
1838         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1839         (BuildbotIteration.prototype.update):
1840
1841 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1842
1843         Tweaks to the Buildbot Dashboard
1844
1845         https://bugs.webkit.org/show_bug.cgi?id=122169
1846
1847         Reviewed by Alexey Proskuryakov.
1848
1849         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1850         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
1851         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1852         (BuildbotQueueView.prototype.revisionLinksForIteration):
1853         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1854         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1855         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
1856         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1857         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1858         (WebKitBuildbot.prototype.buildLogURLForIteration):
1859         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1860
1861 2013-10-01  Commit Queue  <commit-queue@webkit.org>
1862
1863         Unreviewed, rolling out r156725.
1864         http://trac.webkit.org/changeset/156725
1865         https://bugs.webkit.org/show_bug.cgi?id=122176
1866
1867         broke all the mismatch tests again (Requested by thorton on
1868         #webkit).
1869
1870         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1871         (WTR::PlatformWebView::PlatformWebView):
1872
1873 2013-10-01  Alex Christensen  <achristensen@webkit.org>
1874
1875         Implemented createWebViewWithRequest in WinLauncher.
1876         https://bugs.webkit.org/show_bug.cgi?id=122069
1877
1878         Reviewed by Brent Fulgham.
1879
1880         * WinLauncher/PrintWebUIDelegate.cpp:
1881         (PrintWebUIDelegate::createWebViewWithRequest): Added.
1882         * WinLauncher/PrintWebUIDelegate.h:
1883         Removed createWebViewWithRequest stub.
1884
1885 2013-10-01  Tim Horton  <timothy_horton@apple.com>
1886
1887         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
1888         https://bugs.webkit.org/show_bug.cgi?id=122006
1889         <rdar://problem/15095197>
1890
1891         Reviewed by Dean Jackson.
1892
1893         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1894         (WTR::PlatformWebView::PlatformWebView):
1895         Layer-back the root view in WebKitTestRunner's window, to work around a bug
1896         where the window server snapshot API returns blank snapshots.
1897
1898         Re-landing after r156724, this should not break everything now.
1899
1900 2013-10-01  Tim Horton  <timothy_horton@apple.com>
1901
1902         [mac] 1x emulation on Retina hardware shouldn't use SPI
1903         https://bugs.webkit.org/show_bug.cgi?id=122152
1904         <rdar://problem/15119384>
1905
1906         Reviewed by Anders Carlsson.
1907
1908         * DumpRenderTree/mac/DumpRenderTree.mm:
1909         (createWebViewAndOffscreenWindow):
1910         (main):
1911         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1912         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1913         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1914         (WTR::PlatformWebView::PlatformWebView):
1915         * WebKitTestRunner/mac/main.mm:
1916         (main):
1917         Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
1918
1919 2013-09-30  Sam Weinig  <sam@webkit.org>
1920
1921         check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
1922         https://bugs.webkit.org/show_bug.cgi?id=116474
1923
1924         Reviewed by Ryosuke Niwa.
1925
1926         * Scripts/webkitpy/style/checkers/cpp.py:
1927         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1928
1929 2013-09-30  Sam Weinig  <sam@webkit.org>
1930
1931         Remove support for DOMFileSystem
1932         https://bugs.webkit.org/show_bug.cgi?id=122137
1933
1934         Reviewed by Anders Carlsson.
1935
1936         * Scripts/webkitperl/FeatureList.pm:
1937         * Scripts/webkitpy/style/checkers/cpp.py:
1938         (check_spacing):
1939         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1940         (CppStyleTest.test_spacing_for_binary_ops):
1941         * qmake/mkspecs/features/features.pri:
1942
1943 2013-09-30  Mark Rowe  <mrowe@apple.com>
1944
1945         More build fixage for builds with SDKs.
1946
1947         * WebKitTestRunner/Configurations/Base.xcconfig:
1948         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
1949
1950 2013-09-30  Timothy Hatcher  <timothy@apple.com>
1951
1952         Add initial version of a new Buildbot dashboard view.
1953
1954         https://bugs.webkit.org/show_bug.cgi?id=122131
1955
1956         Reviewed by Alexey Proskuryakov.
1957
1958         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
1959         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
1960         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
1961         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
1962         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
1963         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
1964         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
1965         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
1966         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
1967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
1968         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
1969         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
1970         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
1971         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
1972         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
1973         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
1974         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
1975         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
1976         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
1977         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
1978         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
1979         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
1980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
1981         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
1982         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
1983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
1984         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
1985         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
1986         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
1987         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
1988         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
1989         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
1990
1991 2013-09-30  Benjamin Poulain  <benjamin@webkit.org>
1992
1993         Remove the code guarded by STYLE_SCOPED
1994         https://bugs.webkit.org/show_bug.cgi?id=122123
1995
1996         Reviewed by Anders Carlsson.
1997
1998         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1999         (resetDefaultsToConsistentValues):
2000         * Scripts/webkitperl/FeatureList.pm:
2001         * qmake/mkspecs/features/features.pri:
2002
2003 2013-09-30  Mark Rowe  <mrowe@apple.com>
2004
2005         Fix the build when building against an SDK.
2006
2007         Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
2008         the compiler command lines. It can't know to do this for the system framework search paths
2009         we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
2010
2011         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2012         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2013
2014 2013-09-30  Brent Fulgham  <bfulgham@apple.com>
2015
2016         [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
2017
2018         A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
2019         it to be double-freed.
2020
2021         * WinLauncher/WinLauncher.cpp:
2022         (EditProc): Be explicit about type passed to loadURL.
2023         (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
2024         that reallocating the BSTR is done with the knowledge of the smart pointer.
2025
2026 2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2027
2028         [Qt] Fix force_static_libs_as_shared in WebKit2
2029         https://bugs.webkit.org/show_bug.cgi?id=121961
2030
2031         Reviewed by Csaba Osztrogonác.
2032
2033         Get rid of the unused WebKit2QML library
2034
2035         * qmake/mkspecs/features/webkit_modules.prf:
2036         * qmake/mkspecs/modules/webkit2qml.prf: Removed.
2037
2038 2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>
2039
2040         [EFL] Fix incorrect click counting in EventSenderProxy
2041         https://bugs.webkit.org/show_bug.cgi?id=122098
2042
2043         Reviewed by Gyuyoung Kim.
2044
2045         Previously used two types of recording time, which conflicted with each other.
2046
2047         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2048         (WTR::EventSenderProxy::mouseUp):
2049
2050 2013-09-30  Zan Dobersek  <zdobersek@igalia.com>
2051
2052         [webkitpy] Make the Xvfb screen depth overridable
2053         https://bugs.webkit.org/show_bug.cgi?id=122089
2054
2055         Reviewed by Gyuyoung Kim.
2056
2057         Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
2058         was set. The default value that's used if the variable wasn't set is 24.
2059
2060         * Scripts/webkitpy/port/xvfbdriver.py:
2061         (XvfbDriver._xvfb_screen_depth):
2062         (XvfbDriver._start):
2063         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2064         (XvfbDriverTest.make_driver):
2065         (XvfbDriverTest.test_start_no_pixel_tests):
2066         (XvfbDriverTest.test_start_pixel_tests):
2067         (XvfbDriverTest.test_start_arbitrary_worker_number):
2068         (XvfbDriverTest.test_next_free_display):
2069         (XvfbDriverTest.test_start_next_worker):
2070
2071 2013-09-29  Mark Rowe  <mrowe@apple.com>
2072
2073         Fix the Lion build.
2074
2075         Ensure that C++ and Objective-C++ files build with the right compiler flags.
2076
2077         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2078         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2079
2080 2013-09-28  Mark Rowe  <mrowe@apple.com>
2081
2082         Fix some failures with newer versions of clang.
2083
2084         Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
2085         usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
2086         as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
2087         flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
2088         in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
2089
2090         Reviewed by Dan Bernstein.
2091
2092         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2093         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2094         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2095         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2096         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2097         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2098         * WebKitTestRunner/Configurations/Base.xcconfig:
2099         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2100         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2101         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2102         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2103
2104 2013-09-27  Commit Queue  <commit-queue@webkit.org>
2105
2106         Unreviewed, rolling out r156569.
2107         http://trac.webkit.org/changeset/156569
2108         https://bugs.webkit.org/show_bug.cgi?id=122035
2109
2110         broke a lot of mismatch tests (Requested by thorton on
2111         #webkit).
2112
2113         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2114         (WTR::PlatformWebView::PlatformWebView):
2115
2116 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2117
2118         Don't retry failures on Apple MountainLion Release WK1 tester
2119         https://bugs.webkit.org/show_bug.cgi?id=122026
2120
2121         Reviewed by Mark Rowe.
2122
2123         * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
2124         on this bot.
2125
2126 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2127
2128         Don't hardcode builder specific configuration in buildbot master.cfg
2129         https://bugs.webkit.org/show_bug.cgi?id=122023
2130
2131         Reviewed by Mark Rowe.
2132
2133         * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
2134         property to Qt Mountain Lion Release, making it run pixel tests.
2135
2136         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2137         (RunWebKitTests.start): Use additionalArguments.
2138         (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
2139
2140 2013-09-27  Tim Horton  <timothy_horton@apple.com>
2141
2142         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2143         https://bugs.webkit.org/show_bug.cgi?id=122006
2144         <rdar://problem/15095197>
2145
2146         Reviewed by Dean Jackson.
2147
2148         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2149         (WTR::PlatformWebView::PlatformWebView):
2150         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2151         where the window server snapshot API returns blank snapshots.
2152
2153 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2154
2155         [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
2156         https://bugs.webkit.org/show_bug.cgi?id=106924
2157
2158         Reviewed by Chris Fleizach.
2159
2160         Consider headings levels as values to be returned in intValue()
2161         both in DRT and WKTR, so we can share more tests with other ports.
2162
2163         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2164         (AccessibilityUIElement::intValue): Consider headings too.
2165         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2166         (WTR::AccessibilityUIElement::intValue): Ditto.
2167
2168 2013-09-26  Darin Adler  <darin@apple.com>
2169
2170         rename KURL to URL
2171         https://bugs.webkit.org/show_bug.cgi?id=16214
2172
2173         Reviewed by Andreas Kling.
2174
2175         * many files: Renamed, using script.
2176
2177 2013-09-27  Darin Adler  <darin@apple.com>
2178
2179         Fix Python scripts test failures.
2180
2181         * Scripts/webkitpy/style/checkers/cpp.py:
2182         (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
2183         now, not by the checker itself.
2184
2185 2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
2186
2187         [GTK][WK2] Logging of accessibility events is not disabled between tests
2188         https://bugs.webkit.org/show_bug.cgi?id=121957
2189
2190         Reviewed by Mario Sanchez Prada.
2191
2192         Fixed an issue in AccessibilityNotificationHandler where the destructor
2193         was not disconnecting accessibility event callbacks if logging was on.
2194         The decision of disconnecting events can solely rely on the existence of
2195         notification handlers because logging uses the global notification
2196         handler.
2197
2198         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2199         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
2200         disconnection when logging is on.
2201
2202 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
2203
2204         Add general CMakeLists.txt for DRT
2205         https://bugs.webkit.org/show_bug.cgi?id=119268
2206
2207         Reviewed by Gyuyoung Kim.
2208
2209         The new file allows better sharing between ports.
2210
2211         * CMakeLists.txt:
2212         * DumpRenderTree/CMakeLists.txt: Added.
2213         * DumpRenderTree/PlatformEfl.cmake: Added.
2214         * DumpRenderTree/efl/CMakeLists.txt: Removed.
2215
2216 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2217
2218         [Qt] Fix force_static_libs_as_shared in WebKit2
2219         https://bugs.webkit.org/show_bug.cgi?id=121961
2220
2221         Reviewed by Csaba Osztrogonác.
2222
2223         Reenable force_static_libs_as_shared when building WebKit2.
2224
2225         * qmake/mkspecs/features/default_post.prf:
2226
2227 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2228
2229         [Qt] Mock implementations of positioning and orientation not used
2230         https://bugs.webkit.org/show_bug.cgi?id=121956
2231
2232         Reviewed by Csaba Osztrogonác.
2233
2234         Move production_build checks to sanitizeFeatures where its value is actually known.
2235
2236         * qmake/mkspecs/features/features.prf:
2237         * qmake/mkspecs/features/features.pri:
2238
2239 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2240
2241         [ATK] Normalize checks in entry points for DRT and WKTR
2242         https://bugs.webkit.org/show_bug.cgi?id=121959
2243
2244         Reviewed by Chris Fleizach.
2245
2246         Always check if we have a proper instance of AtkObject,
2247         implementing the interfaces that we might need for each case, at
2248         the entry point of every method of AccessibilityUIElement for ATK,
2249         and do those checks in an uniform way across DRT and WKTR, to
2250         avoid confusion and issues when modifying these files in the future.
2251
2252         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2253         (AccessibilityUIElement::getChildren): Use normalized checks.
2254         (AccessibilityUIElement::getChildrenWithRange): Ditto.
2255         (AccessibilityUIElement::rowCount): Ditto.
2256         (AccessibilityUIElement::columnCount): Ditto.
2257         (AccessibilityUIElement::childrenCount): Ditto.
2258         (AccessibilityUIElement::elementAtPoint): Ditto.
2259         (AccessibilityUIElement::getChildAtIndex): Ditto.
2260         (AccessibilityUIElement::allAttributes): Ditto.
2261         (AccessibilityUIElement::titleUIElement): Ditto.
2262         (AccessibilityUIElement::parentElement): Ditto.
2263         (AccessibilityUIElement::attributesOfChildren): Ditto.
2264         (AccessibilityUIElement::role): Ditto.
2265         (AccessibilityUIElement::title): Ditto.
2266         (AccessibilityUIElement::description): Ditto.
2267         (AccessibilityUIElement::stringValue): Ditto.
2268         (AccessibilityUIElement::language): Ditto.
2269         (AccessibilityUIElement::x): Ditto.
2270         (AccessibilityUIElement::y): Ditto.
2271         (AccessibilityUIElement::width): Ditto.
2272         (AccessibilityUIElement::height): Ditto.
2273         (AccessibilityUIElement::orientation): Ditto.
2274         (AccessibilityUIElement::intValue): Ditto.
2275         (AccessibilityUIElement::minValue): Ditto.
2276         (AccessibilityUIElement::maxValue): Ditto.
2277         (indexRangeInTable): Ditto.
2278         (AccessibilityUIElement::cellForColumnAndRow): Ditto.
2279         (AccessibilityUIElement::stringAttributeValue): Ditto.
2280         (alterCurrentValue): Ditto.
2281         (AccessibilityUIElement::press): Ditto.
2282         (AccessibilityUIElement::documentEncoding): Ditto.
2283         (AccessibilityUIElement::documentURI): Ditto.
2284         (AccessibilityUIElement::hasPopup): Ditto.
2285
2286         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2287         (WTR::indexRangeInTable): Use normalized checks.
2288         (WTR::alterCurrentValue): Ditto.
2289         (WTR::AccessibilityUIElement::getChildren): Ditto.
2290         (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
2291         (WTR::AccessibilityUIElement::childrenCount): Ditto.
2292         (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
2293         (WTR::AccessibilityUIElement::indexOfChild): Ditto.
2294         (WTR::AccessibilityUIElement::childAtIndex): Ditto.
2295         (WTR::AccessibilityUIElement::titleUIElement): Ditto.
2296         (WTR::AccessibilityUIElement::parentElement): Ditto.
2297         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
2298         (WTR::AccessibilityUIElement::allAttributes): Ditto.
2299         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2300         (WTR::AccessibilityUIElement::role): Ditto.
2301         (WTR::AccessibilityUIElement::title): Ditto.
2302         (WTR::AccessibilityUIElement::description): Ditto.
2303         (WTR::AccessibilityUIElement::orientation): Ditto.
2304         (WTR::AccessibilityUIElement::stringValue): Ditto.
2305         (WTR::AccessibilityUIElement::language): Ditto.
2306         (WTR::AccessibilityUIElement::x): Ditto.
2307         (WTR::AccessibilityUIElement::y): Ditto.
2308         (WTR::AccessibilityUIElement::width): Ditto.
2309         (WTR::AccessibilityUIElement::height): Ditto.
2310         (WTR::AccessibilityUIElement::intValue): Ditto.
2311         (WTR::AccessibilityUIElement::minValue): Ditto.
2312         (WTR::AccessibilityUIElement::maxValue): Ditto.
2313         (WTR::AccessibilityUIElement::rowCount): Ditto.
2314         (WTR::AccessibilityUIElement::columnCount): Ditto.
2315         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
2316         (WTR::AccessibilityUIElement::press): Ditto.
2317         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
2318         (WTR::AccessibilityUIElement::documentURI): Ditto.
2319         (WTR::AccessibilityUIElement::hasPopup): Ditto.
2320
2321 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2322
2323         [ATK] accessibility/aria-sort.html is failing after r156409
2324         https://bugs.webkit.org/show_bug.cgi?id=121947
2325
2326         Reviewed by Chris Fleizach.
2327
2328         Implement AccessibilityUIElement::isSupported for the ATK
2329         platforms, just by checking whether we have an associated object
2330         attribute exposed for the wrapper object matching the required
2331         attribute in the layout test (e.g "AXSortDirection" -> "sort").
2332
2333         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2334         (AccessibilityUIElement::isAttributeSupported): Implemented.
2335         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2336         (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
2337
2338 2013-09-26  Eric Carlson  <eric.carlson@apple.com>
2339
2340         [MediaStream] make MediaStream testable
2341         https://bugs.webkit.org/show_bug.cgi?id=121967
2342
2343         Reviewed by Dean Jackson.
2344
2345         * DumpRenderTree/mac/UIDelegate.mm:
2346         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
2347             user media request policy delegate.
2348
2349 2013-09-26  Brian J. Burg  <burg@cs.washington.edu>
2350
2351         build-webkit --inspector-frontend should copy WebInspectorUI files
2352         https://bugs.webkit.org/show_bug.cgi?id=117851
2353
2354         Reviewed by Joseph Pecoraro.
2355
2356         Change the --inspector-frontend build option to additionally build/copy 
2357         WebInspectorUI by setting it as the only project that needs to be built.
2358
2359         * Scripts/build-webkit:
2360
2361 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2362
2363         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2364         https://bugs.webkit.org/show_bug.cgi?id=121951
2365
2366         Reviewed by Carlos Garcia Campos.
2367
2368         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2369         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2370         500 layout tests that trigger accelerated compositing to be used.
2371
2372         * Scripts/webkitpy/port/xvfbdriver.py:
2373         (XvfbDriver._start):
2374         * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
2375         (XvfbDriverTest.test_start_no_pixel_tests):
2376         (XvfbDriverTest.test_start_pixel_tests):
2377         (XvfbDriverTest.test_start_arbitrary_worker_number):
2378         (XvfbDriverTest.test_next_free_display):
2379         (XvfbDriverTest.test_start_next_worker):
2380
2381 2013-09-26  Tim Horton  <timothy_horton@apple.com>
2382
2383         Tiled drawing should not imply threaded scrolling
2384         https://bugs.webkit.org/show_bug.cgi?id=121874
2385         <rdar://problem/15071494>
2386
2387         Reviewed by Sam Weinig.
2388
2389         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2390         (WTR::PlatformWebView::PlatformWebView):
2391         The existing tiled-drawing layout tests require threaded scrolling to be enabled.
2392
2393 2013-09-26  Commit Queue  <commit-queue@webkit.org>
2394
2395         Unreviewed, rolling out r156457.
2396         http://trac.webkit.org/changeset/156457
2397         https://bugs.webkit.org/show_bug.cgi?id=121960
2398
2399         Broke webkitpy tests. (Requested by kling on #webkit).
2400
2401         * Scripts/webkitpy/port/xvfbdriver.py:
2402         (XvfbDriver._start):
2403
2404 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2405
2406         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2407         https://bugs.webkit.org/show_bug.cgi?id=121951
2408
2409         Reviewed by Carlos Garcia Campos.
2410
2411         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2412         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2413         500 layout tests that trigger accelerated compositing to be used.
2414
2415         * Scripts/webkitpy/port/xvfbdriver.py:
2416         (XvfbDriver._start):
2417
2418 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2419
2420         Removed check for Apple Application Support directory in WinCairo port.
2421         https://bugs.webkit.org/show_bug.cgi?id=121869
2422
2423         Reviewed by Brent Fulgham.
2424
2425         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2426         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2427         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2428         Use DLLLauncherWinCairo.props for WinCairo ports.
2429         * win/DLLLauncher/DLLLauncherMain.cpp:
2430         (wWinMain):
2431         Don't call modifyPath to check for AAS in the WinCairo port.
2432         * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
2433
2434 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2435
2436         Enabled AssembleBuildLogs on WinCairo port.
2437         https://bugs.webkit.org/show_bug.cgi?id=121923
2438
2439         Reviewed by Brent Fulgham.
2440
2441         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2442         Fixed reference to README, added WinCairo configurations.
2443         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
2444         Fixed reference to README.
2445         * win/AssembleBuildLogs/AssembleLogs.cmd:
2446         Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
2447         * win/AssembleBuildLogs/README: Fixed spelling.
2448
2449 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2450
2451         [WIN] Fix MSVC C4146 compiler warning
2452         https://bugs.webkit.org/show_bug.cgi?id=121838
2453
2454         Reviewed by Brent Fulgham.
2455
2456         Fix some variables from unsinged to int to fix the compiler warning
2457         "unary minus operator applied to unsigned type, result still unsigned".
2458
2459         * DumpRenderTree/WorkQueueItem.h:
2460         (BackItem::BackItem):
2461         (ForwardItem::ForwardItem):
2462         * DumpRenderTree/win/DumpRenderTree.cpp:
2463         (createWebViewAndOffscreenWindow):
2464
2465 2013-09-25  Zan Dobersek  <zdobersek@igalia.com>
2466
2467         [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
2468         https://bugs.webkit.org/show_bug.cgi?id=121256
2469
2470         Reviewed by Martin Robinson.
2471
2472         Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
2473         The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
2474
2475         * BuildSlaveSupport/build.webkit.org-config/config.json:
2476
2477 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2478
2479         Add style checker for CMake lists
2480         https://bugs.webkit.org/show_bug.cgi?id=121764
2481
2482         Reviewed by Ryosuke Niwa.
2483
2484         Add an additional check to make sure that list of files are sorted.
2485         Exclude lists of include directories for now, since the order
2486         can be importent for compilation of some files.
2487
2488         * Scripts/webkitpy/style/checkers/cmake.py:
2489         (CMakeChecker.check):
2490         (CMakeChecker._check_indent):
2491         (CMakeChecker):
2492         (CMakeChecker._check_list_order):
2493         (CMakeChecker._list_item_path):
2494         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2495         (CMakeCheckerTest.test_check):
2496
2497 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2498
2499         CMakeChecker takes unusually long time to run
2500         https://bugs.webkit.org/show_bug.cgi?id=105662
2501
2502         Reviewed by Ryosuke Niwa.
2503
2504         Move the caching mechanism for regular expression of the C++ checker into
2505         a common file and use it for the CMake and ChangeLog checkers too.
2506
2507         * Scripts/webkitpy/style/checkers/changelog.py:
2508         (ChangeLogChecker.check_entry):
2509         * Scripts/webkitpy/style/checkers/cmake.py:
2510         (CMakeChecker._process_line):
2511         (CMakeChecker._check_no_space_cmds):
2512         (CMakeChecker._check_one_space_cmds):
2513         (CMakeChecker._check_non_lowercase_cmd):
2514         * Scripts/webkitpy/style/checkers/common.py:
2515         (match):
2516         (search):
2517         (searchIgnorecase):
2518         (sub):
2519         (subn):
2520         * Scripts/webkitpy/style/checkers/cpp.py:
2521
2522 2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2523
2524         [Qt] Fix build with Qt 5.2 QtPosition module
2525         https://bugs.webkit.org/show_bug.cgi?id=121089
2526
2527         Reviewed by Simon Hausmann.
2528
2529         QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
2530         that might depend on them.
2531
2532         * qmake/mkspecs/features/default_pre.prf:
2533         * qmake/mkspecs/features/features.prf:
2534
2535 2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>
2536
2537         [ATK] Fix style issues in AccessibilityUIElementAtk
2538         https://bugs.webkit.org/show_bug.cgi?id=121898
2539
2540         Reviewed by Chris Fleizach.
2541
2542         Avoid the '.f' suffix for float literals and use G_VALUE_INIT
2543         instead of { 0, { { 0 } } } to initialize a GValue.
2544
2545         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2546         (AccessibilityUIElement::clickPointX): Remove suffix.
2547         (AccessibilityUIElement::clickPointY): Ditto.
2548         (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
2549         (AccessibilityUIElement::minValue): Ditto.
2550         (AccessibilityUIElement::maxValue): Ditto.
2551         (AccessibilityUIElement::numberAttributeValue): Remove suffix.
2552         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2553         (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
2554         (WTR::AccessibilityUIElement::x): Ditto.
2555         (WTR::AccessibilityUIElement::y): Ditto.
2556         (WTR::AccessibilityUIElement::width): Ditto.
2557         (WTR::AccessibilityUIElement::height): Ditto.
2558         (WTR::AccessibilityUIElement::clickPointX): Ditto.
2559         (WTR::AccessibilityUIElement::clickPointY): Ditto.
2560         (WTR::AccessibilityUIElement::intValue): Ditto.
2561         (WTR::AccessibilityUIElement::minValue): Ditto.
2562         (WTR::AccessibilityUIElement::maxValue): Ditto.
2563
2564 2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
2565
2566         [EFL] accessibility/loading-iframe-sends-notification.html is failing
2567         https://bugs.webkit.org/show_bug.cgi?id=112003
2568
2569         Reviewed by Mario Sanchez Prada.
2570
2571         Enabled addNotificationListener and removeNotificationListener for EFL port.
2572
2573         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2574         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2575         (WTR::AccessibilityController::removeNotificationListener):
2576
2577 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
2578
2579         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
2580         https://bugs.webkit.org/show_bug.cgi?id=121844
2581
2582         Reviewed by Mark Hahnenberg.
2583
2584         * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
2585
2586 2013-09-24  Alexey Proskuryakov  <ap@apple.com>
2587
2588         [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
2589         https://bugs.webkit.org/show_bug.cgi?id=121854
2590
2591         Reviewed by Anders Carlsson.
2592
2593         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2594         (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
2595         settings in underlying frameworks.
2596
2597 2013-09-24  Mark Rowe  <mrowe@apple.com>
2598
2599         <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
2600
2601         Reviewed by Dan Bernstein.
2602
2603         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2604         * MiniBrowser/Configurations/Base.xcconfig:
2605         * TestWebKitAPI/Configurations/Base.xcconfig:
2606         * WebKitLauncher/Configurations/Base.xcconfig:
2607         * WebKitTestRunner/Configurations/Base.xcconfig:
2608
2609 2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>
2610
2611         [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
2612         https://bugs.webkit.org/show_bug.cgi?id=121674
2613
2614         Reviewed by Mario Sanchez Prada.
2615
2616         Implemented the global notification listener for
2617         AccessibilityController. The signal is generated by
2618         AXObjectCache::postPlatformNotification() and received by
2619         axObjectEventListener(). axObjectEventListener will then invoke
2620         JSObjectCallAsFunction() with the respective callback function.
2621
2622         There is no additional test for this patch since its implementation will
2623         be tested by an accessibility layout test that is currently failing
2624         (accessibility/loading-iframe-sends-notification.html).
2625
2626         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
2627         stub implementations of addNotificationListener and
2628         removeNotificationListener for the GTK port.
2629         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2630         (WTR::AccessibilityController::addNotificationListener): Creates the
2631         notification handler and sets the notification function callback.
2632         (WTR::AccessibilityController::removeNotificationListener): Removes the
2633         global handler.
2634
2635 2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>
2636
2637         [GTK] fast/images/exif-orientation-composited.html is failing
2638         https://bugs.webkit.org/show_bug.cgi?id=119731
2639
2640         Reviewed by Carlos Garcia Campos.
2641
2642         Add handling respect image orientation property in DRT.
2643
2644         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2645         (TestRunner::overridePreference):
2646
2647 2013-09-24  Zan Dobersek  <zdobersek@igalia.com>
2648
2649         [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
2650         https://bugs.webkit.org/show_bug.cgi?id=121787
2651
2652         Reviewed by Gustavo Noronha Silva.
2653
2654         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
2655         with the Wayland target enabled to version 3.10.0.
2656
2657 2013-09-23  Patrick Gansterer  <paroga@webkit.org>
2658
2659         use NOMINMAX instead of #define min min
2660         https://bugs.webkit.org/show_bug.cgi?id=73563
2661
2662         Reviewed by Brent Fulgham.
2663
2664         Use NOMINMAX instead of #define min/max as a cleaner
2665         way of ensuring that Windows system header files don't
2666         define min/max as macro in the first place.
2667
2668         * DumpRenderTree/DumpRenderTreePrefix.h:
2669         * DumpRenderTree/cg/ImageDiffCG.cpp:
2670         * DumpRenderTree/config.h:
2671         * DumpRenderTree/win/ImageDiffCairo.cpp:
2672         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2673         * WebKitTestRunner/config.h:
2674
2675 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
2676
2677         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
2678         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
2679
2680         Reviewed by Alexey Proskuryakov.
2681
2682         Previously, initalizing a WebPreference would change the cache model
2683         to WebCacheModelDocumentBrowser. That behavior was due to a stale
2684         preference file on disk.
2685
2686         This patch fixes the tests by resetting the default, and using the proper
2687         default values after initializing WebPreference.
2688
2689         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2690         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
2691         to the previous runs.
2692
2693         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2694         (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
2695         cache model to the one required.
2696
2697         * TestWebKitAPI/ios/mainIOS.mm:
2698         (main): Reset the preferences before testing.
2699         * TestWebKitAPI/mac/mainMac.mm:
2700         (main): Ditto.
2701
2702 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
2703
2704         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
2705         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
2706
2707         Reviewed by Alexey Proskuryakov.
2708
2709         Previously, initalizing a WebPreference would change the cache model
2710         to WebCacheModelDocumentBrowser. That behavior was due to a stale
2711         preference file on disk.
2712
2713         This patch fixes the tests by resetting the default, and using the proper
2714         default values after initializing WebPreference.
2715
2716         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2717         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
2718         to the previous runs.
2719
2720         * TestWebKitAPI/ios/mainIOS.mm:
2721         (main): Reset the preferences before testing.
2722         * TestWebKitAPI/mac/mainMac.mm:
2723         (main): Ditto.
2724
2725 2013-09-23  Anders Carlsson  <andersca@apple.com>
2726
2727         ListHashSet should work with move-only types
2728         https://bugs.webkit.org/show_bug.cgi?id=121802
2729
2730         Reviewed by Andreas Kling.
2731
2732         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2733         (TestWebKitAPI::TEST):
2734         Add a test for move-only types.
2735
2736 2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>
2737
2738         Added --64-bit option for Windows build.
2739         https://bugs.webkit.org/show_bug.cgi?id=121799
2740
2741         Reviewed by Brent Fulgham.
2742
2743         * Scripts/webkitdirs.pm:
2744         (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
2745         (isWin64): Added.
2746         (determineIsWin64): Added.
2747
2748 2013-09-23  Anders Carlsson  <andersca@apple.com>
2749
2750         ListHashSet should use std::reverse_iterator for reverse iterators
2751         https://bugs.webkit.org/show_bug.cgi?id=121795
2752
2753         Reviewed by Antti Koivisto.
2754
2755         Add test for reverse iterators.
2756
2757         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2758         (TestWebKitAPI::TEST):
2759
2760 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
2761
2762         [EFL] accessibility/aria-invalid is failing
2763         https://bugs.webkit.org/show_bug.cgi?id=111986
2764
2765         Reviewed by Mario Sanchez Prada.
2766
2767         Adds possibility to retrieve JS context.
2768         This is part of the implementation of AccessibilityUIElement::addNotificationListener
2769         from 119883 and 120421.
2770
2771         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2772         (axObjectEventListener):
2773         (addAccessibilityNotificationHandler):
2774         (removeAccessibilityNotificationHandler):
2775         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2776         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2777         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2778
2779 2013-09-20  Mark Rowe  <mrowe@apple.com>
2780
2781         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
2782
2783         Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
2784
2785         Reviewed by David Kilzer.
2786
2787         * Scripts/webkitdirs.pm:
2788         (checkRequiredSystemConfig):
2789
2790 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
2791
2792         [ATK] Do not expose aria-help in ATK based platforms
2793         https://bugs.webkit.org/show_bug.cgi?id=121675
2794
2795         Reviewed by Chris Fleizach.
2796
2797         Remove the implementations for AccessibilityUIElement::helpText()
2798         from DRT and WKTR for GTK and EFL, since they are based on the
2799         AccessibilityObject::helpText() method and the 'aria-help'
2800         attributes, which is wrong since they should not depend on that
2801         but in ATK specific API (see also http://webkit.org/b/121684).
2802
2803         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2804         (AccessibilityUIElement::helpText): Added a new and empty
2805         implementation, now that we are no longer using this in ATK.
2806         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
2807         as the only function provided here was helpText().
2808         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
2809         * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
2810         removed from the list of sources to compile.
2811         * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
2812         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2813         (WTR::AccessibilityUIElement::helpText): Replaced old implementation
2814         based in DumpRenderTreeSupportGtk with an empty one.
2815
2816 2013-09-20  Dan Bernstein  <mitz@apple.com>
2817
2818         Make extract-localizable-strings available to WebCore clients
2819         https://bugs.webkit.org/show_bug.cgi?id=121699
2820
2821         Reviewed by Darin Adler.
2822
2823         * Scripts/extract-localizable-strings: Copied to
2824         Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
2825         executes the script from its new location. This is a temporary measure until certain code
2826         that is external to WebKit is adapted to the new location.
2827         * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
2828         from its new location.
2829
2830 2013-09-20  Patrick Gansterer  <paroga@webkit.org>
2831
2832         Nuke remaining VS2005 tools from the tree.
2833         https://bugs.webkit.org/show_bug.cgi?id=121691
2834
2835         Reviewed by Brent Fulgham.
2836
2837         * CLWrapper/CLWrapper.cpp: Removed.
2838         * CLWrapper/CLWrapper.sln: Removed.
2839         * CLWrapper/CLWrapper.vcproj: Removed.
2840         * MIDLWrapper/MIDLWrapper.cpp: Removed.
2841         * MIDLWrapper/MIDLWrapper.sln: Removed.
2842         * MIDLWrapper/MIDLWrapper.vcproj: Removed.
2843         * Scripts/parallelcl: Removed.
2844         * vcbin/cl.exe: Removed.
2845         * vcbin/midl.exe: Removed.
2846
2847 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
2848
2849         [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
2850         https://bugs.webkit.org/show_bug.cgi?id=121294
2851
2852         Reviewed by Martin Robinson.
2853
2854         Provide a new patch to deal with the issue in the GTK+ module from
2855         the internal jhbuild environment. This issue has been reported
2856         upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
2857
2858         * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
2859         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
2860
2861 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
2862
2863         [ATK][WTR] accessibility/aria-invalid.html times out
2864         https://bugs.webkit.org/show_bug.cgi?id=121668
2865
2866         Reviewed by Mario Sanchez Prada.
2867
2868         Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
2869         false in case of aria-invalid event with empty value.
2870
2871         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2872         (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
2873         case of aria-invalid event with empty value.
2874
2875 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
2876
2877         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
2878         https://bugs.webkit.org/show_bug.cgi?id=120421
2879
2880         Reviewed by Mario Sanchez Prada.
2881
2882         Implemented the notification listener for AccessibilityUIElement for
2883         WebKitTestRunner. The signal is generated by
2884         AXObjectCache::postPlatformNotification() and received by
2885         axObjectEventListener(). axObjectEventListener() will then invoke
2886         JSObjectCallAsFunction() with the respective callback function. The
2887         notification handlers are stored in HashMap in
2888         AccessibilityNotificationHandlerAtk.cpp.
2889
2890         Moved ATK signal handling (printAccessibilityEvent and
2891         axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
2892
2893         * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
2894         include path.
2895         * WebKitTestRunner/GNUmakefile.am:
2896         Added AccessibilityNotificationHandlerAtk.cpp/h.
2897         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
2898         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
2899         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
2900         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
2901         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
2902         notification handler for GTK+ and EFL.
2903         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2904         Moved printAccessibilityEvent and axObjectEventListener to
2905         AccessibilityNotificationHandlerAtk.cpp.
2906         (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
2907         IDs to AccessibilityNotificationHandlerAtk.cpp.
2908         (WTR::AccessibilityController::resetToConsistentState): Moved listener
2909         IDs to AccessibilityNotificationHandlerAtk.cpp.
2910         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
2911         (WTR::printAccessibilityEvent): Prints accessibility events. This
2912         function was moved from AccessibilityControllerAtk.cpp.
2913         (WTR::axObjectEventListener): Callback for signals. This function was
2914         moved from AccessibilityControllerAtk.cpp.
2915         (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
2916         Initialize element and function callback.
2917         (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
2918         Removes handler from HashMap and disconnects callbacks if necessary.
2919         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
2920         logging mode and connects callbacks.
2921         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2922         Sets the notification callback and connects callback to signals.
2923         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2924         Removes the notification callback from HashMap.
2925         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
2926         Connects axObjectEventListener to ATK signals.
2927         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
2928         Disconnects callback.
2929         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
2930         (WTR::AccessibilityNotificationHandler::create): Creates a new instance
2931         of AccessibilityNotificationHandler.
2932         (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
2933         element.
2934         (WTR::AccessibilityNotificationHandler::platformElement): Gets the
2935         element.
2936         (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
2937         Gets the notification callback.
2938         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2939         (WTR::AccessibilityUIElement::addNotificationListener): Creates
2940         notification handler, set the platform element and the notification
2941         callback.
2942         (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
2943         notification handler.
2944         * WebKitTestRunner/PlatformEfl.cmake:
2945         Added AccessibilityNotificationHandlerAtk.cpp.
2946
2947 2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2948
2949         Update features.pri
2950         https://bugs.webkit.org/show_bug.cgi?id=121670
2951
2952         Reviewed by Jocelyn Turcotte.
2953
2954         Remove feature flags that no longer exists and new ones added to FeatureList.pm
2955
2956         * qmake/mkspecs/features/features.pri:
2957
2958 2013-09-20  Krzysztof Czech  <k.czech@samsung.com>
2959
2960         [GTK][WK2] accessibility/selection-states.html is failing
2961         https://bugs.webkit.org/show_bug.cgi?id=116972
2962
2963         Reviewed by Mario Sanchez Prada.
2964
2965         isSelectable() was not exposed in Accessibility.
2966
2967         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2968
2969 2013-09-19  Dan Bernstein  <mitz@apple.com>
2970
2971         Attempted build fix after r156114.
2972
2973         * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
2974
2975 2013-09-19  Alexey Proskuryakov  <ap@apple.com>
2976
2977         REGRESSION (r129451): run-safari --no-saved-state is broken
2978         https://bugs.webkit.org/show_bug.cgi?id=121566
2979
2980         Undo a last minute change that doesn't actually work.
2981
2982         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
2983         via command line, <rdar://problem/15032886>.
2984
2985 2013-09-19  Dan Bernstein  <mitz@apple.com>
2986
2987         Add a style guideline regarding spacing in range-based for loops
2988         https://bugs.webkit.org/show_bug.cgi?id=121620
2989
2990         Reviewed by Anders Carlsson.
2991
2992         * Scripts/webkitpy/style/checkers/cpp.py:
2993         (check_spacing): Added checking that there are spaces around the colon in a range-based for
2994         loop.
2995         (CppChecker): Added whitespace/colon to the categories set.
2996         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2997         (WebKitStyleTest.test_spacing): Added two tests for the new check.
2998
2999 2013-09-18  Sam Weinig  <sam@webkit.org>
3000
3001         Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
3002         https://bugs.webkit.org/show_bug.cgi?id=121588
3003
3004         Reviewed by Anders Carlsson.
3005
3006         * DumpRenderTree/TestRunner.cpp:
3007         * ImageDiff/efl/ImageDiff.cpp:
3008         * TestWebKitAPI/JavaScriptTest.cpp:
3009         * TestWebKitAPI/PlatformUtilities.cpp:
3010         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3011         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3012         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3013         * WebKitTestRunner/StringFunctions.h:
3014         * WebKitTestRunner/TestInvocation.cpp:
3015         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3016         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3017
3018 2013-09-18  Bem Jones-Bey  <bjonesbe@adobe.com>
3019
3020         W3C Test Import script reformats test HTML
3021         https://bugs.webkit.org/show_bug.cgi?id=119159
3022
3023         Reviewed by Dirk Pranke.
3024
3025         Completely rewrite the test conversion process to minimize
3026         reformatting when adding prefixes, etc. This isn't 100% perfect, there
3027         are still places where it will end up changing the formatting, but it
3028         is much better than before. Most notably, the public interface to the
3029         test converter has changed: now one calls a method instead of creating
3030         an instance of the test converter class. This is because the test
3031         converter class now has state, so one really needs a new instance for
3032         each test.
3033
3034         Note that this also lays some simple groundwork for being able to use
3035         a MockHost in the tests.
3036
3037         * Scripts/webkitpy/w3c/test_converter.py:
3038         (convert_for_webkit):
3039         (_W3CTestConverter):
3040         (_W3CTestConverter.__init__):
3041         (_W3CTestConverter.output):
3042         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3043         (_W3CTestConverter.convert_style_data):
3044         (_W3CTestConverter.convert_attributes_if_needed):
3045         (_W3CTestConverter.handle_starttag):
3046         (_W3CTestConverter.handle_endtag):
3047         (_W3CTestConverter.handle_startendtag):
3048         (_W3CTestConverter.handle_data):
3049         (_W3CTestConverter.handle_entityref):
3050         (_W3CTestConverter.handle_charref):
3051         (_W3CTestConverter.handle_comment):
3052         (_W3CTestConverter.handle_decl):
3053         (_W3CTestConverter.handle_pi):
3054         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3055         (W3CTestConverterTest):
3056         (W3CTestConverterTest.fake_dir_path):
3057         (W3CTestConverterTest.test_read_prefixed_property_list):
3058         (verify_no_conversion_happened):
3059         * Scripts/webkitpy/w3c/test_importer.py:
3060         (TestImporter.import_tests):
3061
3062 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3063
3064         Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
3065         https://bugs.webkit.org/show_bug.cgi?id=121578
3066
3067         Rubber stamped by Geoffrey Garen.
3068
3069         * Scripts/run-layout-jsc:
3070
3071 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3072
3073         Unreviewed, fix for Ruby 1.8.
3074
3075         * Scripts/run-jsc-stress-tests:
3076
3077 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3078
3079         run-jsc-stress-tests should make it easier to look at error spew from tests
3080         https://bugs.webkit.org/show_bug.cgi?id=121531
3081
3082         Reviewed by Mark Hahnenberg.
3083         
3084         This makes two changes:
3085         
3086         - The out/err spew from each test is now saved to a .out file in jsc-stress-results.
3087         
3088         - The same spew also goes to the console but is prefixed by the test's name.
3089         
3090         This required some tee and awk hacks, and then some sh hacks to work around the fact
3091         that if you do "(foo | bar) || baz", and foo fails, then baz won't run - the ||
3092         operator will only see a failure of bar failed. So to pass output to tee and awk, I
3093         needed to do weird things.
3094
3095         * Scripts/run-jsc-stress-tests:
3096
3097 2013-09-18  Alexey Proskuryakov  <ap@apple.com>
3098
3099         REGRESSION (r129451): run-safari --no-saved-state is broken
3100         https://bugs.webkit.org/show_bug.cgi?id=121566
3101
3102         Reviewed by Mark Rowe.
3103
3104         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
3105         Check arguments, not the newly created empty array. Pass a value that silences warnings.
3106         While at it, removed a check for Snow Leopard.
3107
3108 2013-09-18  Alex Christensen  <achristensen@webkit.org>
3109
3110         Improved WinLauncher's URL handling.
3111         https://bugs.webkit.org/show_bug.cgi?id=121535
3112
3113         Reviewed by Brent Fulgham.
3114
3115         * WinLauncher/WinLauncher.cpp:
3116         (EditProc):
3117         Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
3118         (loadURL):
3119         Prepend "http://" to URLs with no scheme.
3120
3121 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3122
3123         DFG should support Int52 for local variables
3124         https://bugs.webkit.org/show_bug.cgi?id=121064
3125
3126         Reviewed by Oliver Hunt.
3127
3128         * Scripts/run-jsc-stress-tests:
3129
3130 2013-09-18  peavo@outlook.com  <peavo@outlook.com>
3131
3132         [Win] TestWebKitAPI does not compile.
3133         https://bugs.webkit.org/show_bug.cgi?id=121485
3134
3135         Reviewed by Brent Fulgham.
3136
3137         It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
3138         Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
3139         to return null, which is the case we want to test.
3140
3141         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3142         (TestWebKitAPI::TEST):
3143
3144 2013-09-18  Mario Sanchez Prada  <mario.prada@samsung.com>
3145
3146         [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
3147         https://bugs.webkit.org/show_bug.cgi?id=121495
3148
3149         Reviewed by Chris Fleizach.
3150
3151         Adapted DRT and WKTR to deal with the new names for the ATK object
3152         attributes being exposed for 'aria-haspopup' and 'aria-sort'.
3153
3154         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3155         (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
3156         (AccessibilityUIElement::stringAttributeValue): Ditto.
3157         (AccessibilityUIElement::hasPopup): Ditto.
3158         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3159         (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
3160         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
3161         (WTR::AccessibilityUIElement::hasPopup): Ditto.
3162
3163 2013-09-18  Commit Queue  <commit-queue@webkit.org>
3164
3165         Unreviewed, rolling out r156019 and r156020.
3166         http://trac.webkit.org/changeset/156019
3167         http://trac.webkit.org/changeset/156020
3168         https://bugs.webkit.org/show_bug.cgi?id=121540
3169
3170         Broke tests (Requested by ap on #webkit).
3171
3172         * Scripts/run-jsc-stress-tests:
3173
3174 2013-09-17  Gwang Yoon Hwang  <ryumiel@company100.net>
3175
3176         Unreviewed. Add myself as a committer.
3177
3178         * Scripts/webkitpy/common/config/contributors.json:
3179
3180 2013-09-17  Jae Hyun Park  <jae.park@company100.net>
3181
3182         Unreviewed. Add myself as a committer.
3183
3184         * Scripts/webkitpy/common/config/contributors.json:
3185
3186 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3187
3188         DFG should support Int52 for local variables
3189         https://bugs.webkit.org/show_bug.cgi?id=121064
3190
3191         Reviewed by Oliver Hunt.
3192
3193         * Scripts/run-jsc-stress-tests:
3194
3195 2013-09-17  Alex Christensen  <alex.christensen@flexsim.com>
3196
3197         Added back and forward buttons to WinLauncher.
3198         https://bugs.webkit.org/show_bug.cgi?id=121212
3199
3200         Reviewed by Brent Fulgham.
3201
3202         * WinLauncher/WinLauncher.cpp:
3203         (resizeSubViews):
3204         Move new back and forward buttons to correct positions before URL bar.
3205         (dllLauncherEntryPoint): 
3206         Store the default button window procedure and replace with my button procedures.
3207         (EditProc): Updated style and renamed from MyEditProc.
3208         (BackButtonProc): Added.
3209         (ForwardButtonProc): Added.
3210
3211 2013-09-17  Michael Saboff  <msaboff@apple.com>
3212
3213         Unreviewed typo fix after r155999
3214
3215         Changed en_US.UTB-8 to en_US.UTF-8
3216
3217         * Scripts/run-javascriptcore-tests:
3218
3219 2013-09-17  Michael Saboff  <msaboff@apple.com>
3220
3221         run-jsc-stress-tests fails with ruby version 2
3222         https://bugs.webkit.org/show_bug.cgi?id=121521
3223
3224         Reviewed by Jessie Berlin.
3225
3226         Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.
3227
3228         * Scripts/run-javascriptcore-tests:
3229
3230 2013-09-17  Brent Fulgham  <bfulgham@apple.com>
3231
3232         [Windows] Unreviewed build fix after r155963.
3233
3234         * DumpRenderTree/win/TestRunnerWin.cpp:
3235         (TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.
3236
3237 2013-09-17  Anders Carlsson  <andersca@apple.com>
3238
3239         Fix a typo.
3240
3241         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3242         (TestWebKitAPI::TEST):
3243
3244 2013-09-16  Anders Carlsson  <andersca@apple.com>
3245
3246         HashMap should work with move-only keys
3247         https://bugs.webkit.org/show_bug.cgi?id=121310
3248
3249         Reviewed by Darin Adler.
3250
3251         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3252         (TestWebKitAPI::TEST):
3253         Add test.
3254
3255 2013-09-17  YuTeh Shen  <shenyute@hotmail.com>
3256
3257         BrowserMarshal.h build fail
3258         https://bugs.webkit.org/show_bug.cgi?id=102938
3259
3260         Reviewed by Carlos Garcia Campos.
3261
3262         Fix variable name.
3263
3264         * MiniBrowser/gtk/GNUmakefile.am:
3265
3266 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
3267
3268         [Windows] Clean up WinLauncher by using smart pointers
3269         https://bugs.webkit.org/show_bug.cgi?id=121467
3270
3271         Reviewed by Anders Carlsson.
3272
3273         * WinLauncher/PrintWebUIDelegate.cpp:
3274         (PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
3275         * WinLauncher/WinLauncher.cpp:
3276         (WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
3277         (WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
3278         (showLastVisitedSites): Smart pointer updates.
3279         (WinLauncherWebHost::didFinishLoadForFrame): Ditto.
3280         (setToDefaultPreferences): Ditto.
3281         (dllLauncherEntryPoint): Ditto.
3282         (PrintView): Ditto.
3283         (LaunchInspector): Ditto.
3284         (NavigateToHistory): Ditto.
3285         (MyEditProc): Ditto.
3286         (loadURL): Ditto.
3287
3288 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
3289
3290         [Windows] Add rudimentary history to WinLauncher.
3291         https://bugs.webkit.org/show_bug.cgi?id=121463
3292
3293         Reviewed by Anders Carlsson.
3294
3295         * WinLauncher/WinLauncher.cpp:
3296         (updateMenuItemForHistoryItem): Added
3297         (showLastVisitedSites): Added
3298         (WinLauncherWebHost::didFinishLoadForFrame): Add history item once
3299         a new page has been visited.
3300         (dllLauncherEntryPoint): Deallocate history on exit.
3301         (NavigateToHistory): Added
3302         (WndProc): Add handler for history entries
3303         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
3304         up to 10 history slots.
3305         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
3306         Windows utility library to allow use of _bstr_t type.
3307         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
3308         to hold up to 10 history slots.
3309         * WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
3310
3311 2013-09-16  Gustavo Noronha Silva  <gns@gnome.org>
3312
3313         [GTK] Make symbol export filter more strict, and disable for dev/test builds
3314         https://bugs.webkit.org/show_bug.cgi?id=120586
3315
3316         Reviewed by Martin Robinson.
3317
3318         * GNUmakefile.am: moved GtkLauncher and documentation builds to their own
3319         makefiles, so they can be included unconditionally.
3320         * GtkLauncher/GNUmakefile.am: added.
3321         * Scripts/webkitdirs.pm:
3322         (runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
3323         to configure, since we consider builds done through build-webkit to be development
3324         and test builds.
3325         * gtk/GNUmakefile.am: added.
3326         * gtk/common.py: do not use the Scripts directory as a reference to the top path;
3327         it's not necessary and it will not work now that the Scripts directory is not
3328         shipped in the tarball.
3329
3330 2013-09-16  Anders Carlsson  <andersca@apple.com>
3331
3332         WTF::Deque should work with move only types
3333         https://bugs.webkit.org/show_bug.cgi?id=121446
3334
3335         Reviewed by Andreas Kling.
3336
3337         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3338         (TestWebKitAPI::TEST):
3339         Add a test.
3340
3341 2013-09-16  Wojciech Bielawski  <w.bielawski@samsung.com>
3342
3343         [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
3344         https://bugs.webkit.org/show_bug.cgi?id=98410
3345
3346         Reviewed by Darin Adler.
3347
3348         Add implementation of click() method of objects returned by eventSender.contextClick().
3349
3350         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3351         (MenuItemPrivateData):
3352         (WTR::menuItemClickCallback):
3353         (WTR::getMenuItemTitleCallback):
3354         (WTR::staticMenuItemFinalize):
3355         (WTR::getMenuItemClass):
3356         (WTR::EventSendingController::contextClick):
3357
3358 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
3359
3360         Make the GDB webkit.py script compatible with Python v3
3361         https://bugs.webkit.org/show_bug.cgi?id=121395
3362
3363         Reviewed by Ryosuke Niwa.
3364
3365         GDB fails to load the printing helpers from the webkit.py script if Python v3 is used. To avoid that,
3366         uses of xrange() in the script are replaced with range(), and the print statements are changed into
3367         the print() function invocations.
3368
3369         * gdb/webkit.py:
3370         (guess_string_length):
3371         (ustring_to_string):
3372         (lstring_to_string):
3373         (WTFCStringPrinter.to_string):
3374         (PrintPathToRootCommand.invoke):
3375
3376 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
3377
3378         [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
3379         https://bugs.webkit.org/show_bug.cgi?id=119631
3380
3381         Reviewed by Ryosuke Niwa.
3382
3383         The perf profiler is attached to the test runner after the test runner has been launched,
3384         but in the case of WebKitTestRunner, this is done after the WebProcess was spawned by the
3385         UIProcess, meaning that WebProcess operations will not be profiled.
3386
3387         To avoid that, the perf profiler is changed to provide a wrapper command for the test runner.
3388         This is done in the scope of already present support for wrapper scripts (such as valgrind)
3389         that are settable through the --wrapper option. This causes the perf profiler to correctly
3390         continue profiling the WebProcess after it was spawned.
3391
3392         When the profiler is launched, a wait process is launched with the profiler's pid as the
3393         argument. This ensures we can check that the profiler exited normally. If it did not, its
3394         output can be corrupted and can cause problems when that output is examined. The after-exit
3395         report is avoided in that case.
3396
3397         * Scripts/webkitpy/common/system/profiler.py:
3398         (Profiler.wrapper_arguments): The method returns an empty list by default.
3399         (Perf.__init__): Remove unnecessary member variables.
3400         (Perf.attach_to_pid): Launch the wait process with the profiler's pid as the argument.
3401         (Perf.wrapper_arguments): Used instead of attaching the profiler to the profiled process' pid,
3402         the method returns a list of arguments that should be used as a wrapper for the test runner.
3403         The arguments specify the 'perf record' command, with the output file and the instruction to
3404         construct the call graph given as well.
3405         (Perf._first_ten_lines_of_profile): Prettify the output by avoiding the unnecessary trailing
3406         whitespace in the profile lines.
3407         (Perf.profile_after_exit): Kill the profiler process through its pid if the wait process is still
3408         running. If it is running even after that, or if the profiler process produced a non-zero exit
3409         code, the method reports the profiling failure and returns. Otherwise it continues on reporting
3410         the top 10 lines of the profile and how to examine the profile further.
3411         * Scripts/webkitpy/port/driver.py:
3412         (Driver._command_wrapper): The method is now a member of the Driver class, returning the wrapper
3413         as specified by the --wrapper option if given, or the profiler wrapper if the profiler is present,
3414         or an empty list otherwise.
3415         (Driver.cmd_line):
3416         * Scripts/webkitpy/port/driver_unittest.py:
3417         (DriverTest.make_port): Adjusted so mock host or options objects can be specified
3418         for the testing-specific Port object.
3419         (DriverTest._assert_wrapper): Pass a MockOptions object with the wrapper value to the make_port method,
3420         as the Driver._command_wrapper now operates on the option's value directly rather than accepting it through
3421         a parameter.
3422         (DriverTest.test_profiler_as_wrapper): Provide a test case to check the correct profiler wrapper is used
3423         when profiling on the Linux platform with the perf profiler.
3424
3425 2013-09-14  Dan Bernstein  <mitz@apple.com>
3426
3427         [mac] Check For Framework Include Consistency build phase checks the wrong framework
3428         https://bugs.webkit.org/show_bug.cgi?id=121215
3429
3430         Reviewed by Mark Rowe.
3431
3432         * Scripts/check-for-webkit-framework-include-consistency: Replaced hard-coded paths to
3433         WebKit.framework’s Headers and PrivateHeaders directories with the current target’s
3434         public and private headers folder paths. Also tweaked the error messages’ format to make
3435         Xcode recognize them as errors.
3436
3437 2013-09-14  Alberto Garcia  <berto@igalia.com>
3438
3439         [GTK] Fails to compile if the build directory is in a different partition
3440         https://bugs.webkit.org/show_bug.cgi?id=121296
3441
3442         Reviewed by Martin Robinson.
3443
3444         Instead of using os.symlink() to install the gtk-doc templates,
3445         use os.link() first and fall back to os.symlink() if it fails.
3446
3447         * gtk/gtkdoc.py:
3448         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
3449
3450 2013-09-14  Alberto Garcia  <berto@igalia.com>
3451
3452         [GTK] WebKitGTK+ is linking against libxslt in too many places
3453         https://bugs.webkit.org/show_bug.cgi?id=121356
3454
3455         Reviewed by Martin Robinson.
3456
3457         TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
3458         so we don't need to link against it.
3459
3460         * MiniBrowser/gtk/GNUmakefile.am:
3461         * TestWebKitAPI/GNUmakefile.am:
3462         * WebKitTestRunner/GNUmakefile.am:
3463
3464 2013-09-14  Ross Burton  <ross.burton@intel.com>
3465
3466         Uses gtk-doc tools even when --disable-gtk-doc passed
3467         https://bugs.webkit.org/show_bug.cgi?id=91239
3468
3469         Reviewed by Martin Robinson.
3470
3471         Don't run generate-gtkdoc on install if gtk-doc is disabled.
3472
3473         * GNUmakefile.am:
3474
3475 2013-09-14  Alberto Garcia  <berto@igalia.com>
3476
3477         [GTK] Fails to compile if the build directory is in a different partition
3478         https://bugs.webkit.org/show_bug.cgi?id=121296
3479
3480         Reviewed by Carlos Garcia Campos.
3481
3482         Use symlinks instead of hard links to support building on a
3483         different file system.
3484
3485         * gtk/gtkdoc.py:
3486         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
3487
3488 2013-09-13  Darin Adler  <darin@apple.com>
3489
3490         Use a better name than m_invertibleCTM
3491         https://bugs.webkit.org/show_bug.cgi?id=121341
3492
3493         Reviewed by Andreas Kling.
3494
3495         * Scripts/do-webcore-rename: Updated to do this replace as we do.
3496
3497 2013-09-13  Anders Carlsson  <andersca@apple.com>
3498
3499         Pick the correct overload when a const reference is passed to appendSlowCase.
3500         https://bugs.webkit.org/show_bug.cgi?id=121326
3501
3502         Reviewed by Darin Adler.
3503
3504         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3505         (TestWebKitAPI::TEST):
3506
3507 2013-09-13  Darin Adler  <darin@apple.com>
3508
3509         Rename confusingly named "runtimeObject" functions
3510         https://bugs.webkit.org/show_bug.cgi?id=121339
3511
3512         Reviewed by Sam Weinig.
3513
3514         * Scripts/do-webcore-rename: Updated to do this replace as usual.
3515
3516 2013-09-13  Filip Pizlo  <fpizlo@apple.com>
3517
3518         DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
3519         https://bugs.webkit.org/show_bug.cgi?id=121330
3520
3521         Reviewed by Mark Hahnenberg and Oliver Hunt.
3522
3523         We should run tests even if they don't have expected files yet.
3524         
3525         * Scripts/run-layout-jsc:
3526
3527 2013-09-13  Anders Carlsson  <andersca@apple.com>
3528
3529         Use nullptr instead of 0 in calls to HashMap::add
3530         https://bugs.webkit.org/show_bug.cgi?id=121322
3531
3532         Reviewed by Sam Weinig.
3533
3534         * DumpRenderTree/mac/TestRunnerMac.mm:
3535         (TestRunner::evaluateScriptInIsolatedWorld):
3536         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3537         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
3538
3539 2013-09-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3540
3541         [GTK] Move to the new web inspector
3542         https://bugs.webkit.org/show_bug.cgi?id=120647
3543
3544         Reviewed by Carlos Garcia Campos.
3545
3546         * GtkLauncher/main.c:
3547         (main): no longer set WEBKIT_INSPECTOR_PATH.
3548         * MiniBrowser/gtk/main.c:
3549         (main): ditto.
3550         * Scripts/old-run-webkit-tests:
3551         (openDumpTool): ditto.
3552         * Scripts/run-gtk-tests: ditto.
3553         * Scripts/webkitpy/port/gtk.py:
3554         (GtkPort.setup_environ_for_server): ditto.
3555
3556 2013-09-13  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3557
3558         [Qt] REGRESSION(r154444): xss-DENIED test results changed
3559         https://bugs.webkit.org/show_bug.cgi?id=120595
3560
3561         Reviewed by Jocelyn Turcotte.
3562
3563         Avoid overwriting Qt meta properties, which we identify by them being undeletable.
3564
3565         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3566         (DumpRenderTree::initJSObjects):
3567
3568 2013-09-13  Darin Adler  <darin@apple.com>
3569
3570         Give actions in Range class NON_SHOUTING_NAMES
3571         https://bugs.webkit.org/show_bug.cgi?id=121280
3572
3573         Reviewed by Andreas Kling.
3574
3575         * Scripts/do-webcore-rename: Updated to do this replace, keeping with
3576         the tradition of checking in the last one we did, along with other
3577         rename ideas for the future.
3578
3579 2013-09-12  Lucas Forschler  <lforschler@apple.com>
3580
3581         Create short build logs for errors and warnings.
3582         https://bugs.webkit.org/show_bug.cgi?id=120614
3583
3584         Reviewed by Ryosuke Niwa.
3585
3586         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3587             -include StringIO 
3588         (CompileWebKit.createSummary):
3589             -add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing
3590
3591 2013-09-12  Roger Fong  <roger_fong@apple.com>
3592
3593         Update cygwin downloader to search for packages in the right location.
3594
3595         * CygwinDownloader/cygwin-downloader.py:
3596         * CygwinDownloader/cygwin-downloader.zip:
3597
3598 2013-09-12  Anders Carlsson  <andersca@apple.com>
3599
3600         Add rudimentary support for move-only types as values in HashMap
3601         https://bugs.webkit.org/show_bug.cgi?id=121226
3602
3603         Reviewed by Andreas Kling.
3604
3605         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3606         (TestWebKitAPI::TEST):
3607         Add a HashMap<unsigned, MoveOnly> test.
3608
3609 2013-09-12  Gabor Abraham  <abrhm@inf.u-szeged.hu>
3610
3611         Auto GDB backtrace generation for EFL/GTK/Qt bots.
3612         https://bugs.webkit.org/show_bug.cgi?id=119338
3613
3614         Reviewed by Csaba Osztrogonác.
3615
3616         * Scripts/webkitpy/port/efl.py:
3617         (EflPort.check_sys_deps):
3618         (EflPort):
3619         (EflPort._get_crash_log):
3620         * Scripts/webkitpy/port/efl_unittest.py:
3621         (EflPortTest.test_show_results_html_file):
3622         (EflPortTest):
3623         (EflPortTest.test_get_crash_log):
3624         * Scripts/webkitpy/port/gtk.py:
3625         (GtkPort._get_crash_log):
3626         * Scripts/webkitpy/port/gtk_unittest.py: