9b370280c7d60bd9d8e76f9ad5fb8192eb390872
[WebKit-https.git] / Tools / ChangeLog
1 2011-06-29  Eric Seidel  <eric@webkit.org>
2
3         Adam says cowboys don't review (or unit test).
4
5         * Scripts/webkitpy/tool/commands/download.py:
6
7 2011-06-29  Eric Seidel  <eric@webkit.org>
8
9         Reviewed by Adam Barth.
10
11         Make port/config.py mockable for easier unit testing
12         https://bugs.webkit.org/show_bug.cgi?id=63661
13
14         Fix an exception from the unit tests.
15
16         * Scripts/webkitpy/layout_tests/port/config.py:
17
18 2011-06-29  Brent Fulgham  <bfulgham@webkit.org>
19
20         Unreviewed build correction.
21
22         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops:
23         Link against zlib1.dll, not the static zlib.lib.
24
25 2011-06-29  Eric Seidel  <eric@webkit.org>
26
27         Reviewed by Adam Barth.
28
29         Make port/config.py mockable for easier unit testing
30         https://bugs.webkit.org/show_bug.cgi?id=63661
31
32         Right now config.py leaks real system paths for
33         webkit_base_dir due to using __file__.  This patch
34         adds a filsystem.py wrapper around __file__ so that
35         we don't have to jump through hoops in webkit_unittest.py
36         to avoid leaking local paths to the unit test results.
37
38         There are probably many more places where we should now
39         use filesystem.path_for_module, but starting with just this one.
40
41         * Scripts/webkitpy/common/system/filesystem.py:
42         * Scripts/webkitpy/common/system/filesystem_mock.py:
43         * Scripts/webkitpy/layout_tests/port/config.py:
44         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
45         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
46
47 2011-06-29  Eric Seidel  <eric@webkit.org>
48
49         Reviewed by Adam Barth.
50
51         Remove duplicate methods in filesystem.py
52         https://bugs.webkit.org/show_bug.cgi?id=63658
53
54         Looks like there was a bad merge at some point.
55
56         I also removed a bunch of redundant docstrings.
57
58         * Scripts/webkitpy/common/system/filesystem.py:
59
60 2011-06-29  Adam Barth  <abarth@webkit.org>
61
62         Reviewed by Eric Seidel.
63
64         Pass --no-new-test-results to NRWT on build.webkit.org
65         https://bugs.webkit.org/show_bug.cgi?id=63653
66
67         This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=38063.
68
69         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
70
71 2011-06-29  Xan Lopez  <xlopez@igalia.com>
72
73         Reviewed by Adam Barth.
74
75         [GTK] overlapping drag&drop tests fail on NRWT
76         https://bugs.webkit.org/show_bug.cgi?id=57640
77
78         Make a GTK test driver that spawns one Xvfb instance per
79         thread. This avoids bad interactions in DnD tests between threads.
80
81         * Scripts/webkitpy/layout_tests/port/gtk.py:
82
83 2011-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
84
85         Unreviewed, rolling out r89888.
86         http://trac.webkit.org/changeset/89888
87         https://bugs.webkit.org/show_bug.cgi?id=63609
88
89          "Seems to be causing merging issues on the dashboard, e.g.
90         http://test-
91         results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=fast%2Fcanvas"
92         (Requested by aboxhall on #webkit).
93
94         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
95         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
96         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
97
98 2011-06-29  Philippe Normand  <pnormand@igalia.com>
99
100         Reviewed by Martin Robinson.
101
102         [webkitpy] Executive.running_pids() sometimes doesn't correctly process "ps" output
103         https://bugs.webkit.org/show_bug.cgi?id=63624
104
105         * Scripts/webkitpy/common/system/executive.py: In some cases the
106         ps output lines can contain one or more leading white-spaces, so
107         strip it before splitting the pid and command name.
108
109 2011-06-29  Noel Gordon  <noel.gordon@gmail.com>
110
111         Reviewed by Kent Tamura.
112
113         [Chromium] [DRT] ImageDiff should compile in VS2010
114         https://bugs.webkit.org/show_bug.cgi?id=63614
115
116         * DumpRenderTree/chromium/ImageDiff.cpp: Include <iterator> for back_inserter.
117
118 2011-06-27  Diego Gonzalez  <diegohcg@webkit.org>
119
120         Reviewed by Kenneth Rohde Christiansen.
121
122         [Qt] DRT support for setInteractiveFormValidationEnabled
123         https://bugs.webkit.org/show_bug.cgi?id=63496
124
125         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
126         (WebCore::DumpRenderTree::DumpRenderTree):
127
128 2011-06-28  Eric Seidel  <eric@webkit.org>
129
130         Reviewed by Adam Barth.
131
132         Make new-run-webkit-tests -2 actually use WebKitTestRunner
133         https://bugs.webkit.org/show_bug.cgi?id=63572
134
135         new-run-webkit-tests -2 works with this change.  However a zillion
136         tests fail since it can't find the right skipped lists for wk2.
137         The Skipped-list fixing is covered in bug 63501.
138
139         * Scripts/webkitpy/layout_tests/port/gtk.py:
140         * Scripts/webkitpy/layout_tests/port/qt.py:
141         * Scripts/webkitpy/layout_tests/port/webkit.py:
142
143 2011-06-28  Ryosuke Niwa  <rniwa@webkit.org>
144
145         Reviewed by Adam Roben.
146
147         Add more machines to Chromium Mac Release and Chromium Mac Release (Tests)
148         https://bugs.webkit.org/show_bug.cgi?id=63500
149
150         Added google-mac-3 and google-mac-4.
151
152         * BuildSlaveSupport/build.webkit.org-config/config.json:
153
154 2011-06-28  Eric Seidel  <eric@webkit.org>
155
156         Reviewed by Dirk Pranke.
157
158         Remove webkitpy's tiger support now that WebKit no longer supports tiger
159         https://bugs.webkit.org/show_bug.cgi?id=63568
160
161         I don't think our support actually fully worked anyway.  Regardless
162         tiger is dead now (thankfully)!
163
164         I also unwrapped some short lines and added a couple FIXMEs while
165         touring the code.
166
167         No new tests, only removing old ones which tested our Tiger support.
168
169         * Scripts/webkitpy/layout_tests/port/base.py:
170         * Scripts/webkitpy/layout_tests/port/builders.py:
171         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
172         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
173         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
174         * Scripts/webkitpy/layout_tests/port/mac.py:
175         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
176         * Scripts/webkitpy/tool/commands/rebaseline.py:
177         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
178
179 2011-06-28  Eric Seidel  <eric@webkit.org>
180
181         Unreviewed, just fixing a typo.
182
183         Fix misspellings of "thead" to "thread".
184
185         * Scripts/webkitpy/common/checkout/scm/git.py:
186         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
187
188 2011-06-28  Eric Seidel  <eric@webkit.org>
189
190         Reviewed by Tony Chang.
191
192         new-run-webkit-tests needs a --webkit-test-runner option
193         https://bugs.webkit.org/show_bug.cgi?id=63439
194
195         This was accidentally fixed in bug 63501 as well.
196         The root problem here was that the webkit unit tests were not using
197         enough mocks.  I've fixed them here to use more mocks
198         which should unbreak windows.
199
200         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
201
202 2011-06-28  Eric Seidel  <eric@webkit.org>
203
204         Reviewed by Tony Chang.
205
206         new-run-webkit-tests should not run mthml tests when MHTML support is disabled
207         https://bugs.webkit.org/show_bug.cgi?id=63549
208
209         This way mhtml tests won't show up as "missing" results on all non-chromium platforms.
210         I happen to go looking for what code was deciding that .mht was a supported
211         extension, found test_files.py and then removed some redundant doc-strings and
212         if branching.
213
214         * Scripts/webkitpy/layout_tests/port/test_files.py:
215         * Scripts/webkitpy/layout_tests/port/webkit.py:
216         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
217
218 2011-06-28  Roland Steiner  <rolandsteiner@chromium.org>
219
220         Reviewed by Tony Chang.
221
222         Fix filesystem_unittest.FileSystemTest test_read_and_write_file()
223         https://bugs.webkit.org/show_bug.cgi?id=63514
224
225         - change write_text_file to write_binary_file
226         - check that text_path and binary_path are actually existant files
227         - change cleanup block from 'except' to 'finally'
228
229         * Scripts/webkitpy/common/system/filesystem_unittest.py:
230
231 2011-06-28  Adam Roben  <aroben@apple.com>
232
233         Roll out r89924 and r89925
234
235         I didn't mean to commit them!
236
237         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
238         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
239         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
240
241 2011-06-27  Adam Barth  <abarth@webkit.org>
242
243         Reviewed by Eric Seidel.
244
245         NRWT should wait for ReportCrash
246         https://bugs.webkit.org/show_bug.cgi?id=63495
247
248         When a test crashes on Mac, ReportCrash confuses us into thinking the
249         test times out.
250
251         I'm not sure how to test this in a meaningful way in our current test
252         harness...
253
254         * Scripts/webkitpy/common/system/crashlogs.py:
255         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
256         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
257         * Scripts/webkitpy/layout_tests/port/base.py:
258         * Scripts/webkitpy/layout_tests/port/mac.py:
259         * Scripts/webkitpy/layout_tests/port/server_process.py:
260         * Scripts/webkitpy/tool/commands/queries.py:
261
262 2011-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
263
264         Unreviewed, rolling out r89881.
265         http://trac.webkit.org/changeset/89881
266         https://bugs.webkit.org/show_bug.cgi?id=63513
267
268         Makes Qt massively slow (Requested by abarth on #webkit).
269
270         * Scripts/webkitpy/common/system/crashlogs.py:
271         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
272         * Scripts/webkitpy/common/system/executive.py:
273         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
274         * Scripts/webkitpy/layout_tests/port/base.py:
275         * Scripts/webkitpy/layout_tests/port/mac.py:
276         * Scripts/webkitpy/layout_tests/port/server_process.py:
277         * Scripts/webkitpy/tool/commands/queries.py:
278
279 2011-06-27  Alice Boxhall  <aboxhall@chromium.org>
280
281         Reviewed by Ojan Vafai.
282
283         Convert json_results_generator.py to output version 4 JSON.
284         https://bugs.webkit.org/show_bug.cgi?id=60869
285
286         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
287         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
288         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
289
290 2011-06-27  Adam Barth  <abarth@webkit.org>
291
292         Reviewed by Eric Seidel.
293
294         NRWT should wait for ReportCrash
295         https://bugs.webkit.org/show_bug.cgi?id=63495
296
297         When a test crashes on Mac, ReportCrash confuses us into thinking the
298         test times out.
299
300         I'm not sure how to test this in a meaningful way in our current test
301         harness...
302
303         * Scripts/webkitpy/common/system/crashlogs.py:
304         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
305         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
306         * Scripts/webkitpy/layout_tests/port/base.py:
307         * Scripts/webkitpy/layout_tests/port/mac.py:
308         * Scripts/webkitpy/layout_tests/port/server_process.py:
309         * Scripts/webkitpy/tool/commands/queries.py:
310
311 2011-06-27  Adam Barth  <abarth@webkit.org>
312
313         Reviewed by Eric Seidel.
314
315         new-run-webkit-tests should upload crash logs
316         https://bugs.webkit.org/show_bug.cgi?id=55907
317
318         NRWT used to have a different name for crash logs.  I've changed the
319         name to patch ORWT.
320
321         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
322         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
323
324 2011-06-27  Eric Seidel  <eric@webkit.org>
325
326         Reviewed by Adam Barth.
327
328         new-run-webkit-tests needs a --webkit-test-runner option
329         https://bugs.webkit.org/show_bug.cgi?id=63439
330
331         NRWT doesn't actually know how to run with the WebKitTestRunner yet
332         but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.
333
334         There is a bunch of other little cleanup in this patch which I added as I
335         took a tour through all of our hard-coded DumpRenderTree strings.
336
337         * Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
338         * Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
339         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
340         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
341         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
342         * Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
343         * Scripts/webkitpy/layout_tests/port/config.py:
344          - build_dumprendertree had no business in this class, removed it.
345          - Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
346          - Exposed _script_path as script_path() (this probably belongs elsewhere).
347         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
348          - Moved these tests to webkit_unittests.
349         * Scripts/webkitpy/layout_tests/port/webkit.py:
350          - Now respects the --webkit-test-runner option.
351          - setup_test_run is empty in base.py too, no need to override it.
352         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
353          - Test the new hotness.
354          - Bad, bad, bad!  The old code was using a real Executive during unit-testing!
355            I think this code is still hitting disk during the unit tests. :(
356         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
357          - Add the option.
358         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
359          - Remove optional args option.
360         * Scripts/webkitpy/tool/commands/commandtest.py:
361          - Remove optional args option.
362         * Scripts/webkitpy/tool/commands/queues_unittest.py:
363          - Remove optional args option.
364
365 2011-06-27  Adam Barth  <abarth@webkit.org>
366
367         Reviewed by Dirk Pranke.
368
369         new-run-webkit-tests does not report stderr output
370         https://bugs.webkit.org/show_bug.cgi?id=37739
371
372         Almost all the infrastructure appears to be in place to report stderr
373         in results.html.  We just need to wire up a bool to tell results.html
374         to create the hyperlink.
375
376         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
377         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
378         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
379         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
380         * Scripts/webkitpy/layout_tests/port/base.py:
381
382 2011-06-27  Adam Barth  <abarth@webkit.org>
383
384         Reviewed by Dirk Pranke.
385
386         webkitpy unit tests should have more descriptive names than just "Test"
387         https://bugs.webkit.org/show_bug.cgi?id=63479
388
389         Luckily we kept these classes in separate namespaces in the harness so
390         we were actually running them all even though they had the same name.
391
392         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
393         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
394         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
395
396 2011-06-27  Greg Simon  <gregsimon@chromium.org>
397
398         No review necessary.
399
400         Add email addr to contributor list
401         https://bugs.webkit.org/show_bug.cgi?id=63478
402
403         * Scripts/webkitpy/common/config/committers.py:
404
405 2011-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
406
407         Unreviewed, rolling out r89834.
408         http://trac.webkit.org/changeset/89834
409         https://bugs.webkit.org/show_bug.cgi?id=63476
410
411         Broke test-webkitpy (Requested by abarth on #webkit).
412
413         * Scripts/webkitpy/common/net/layouttestresults.py:
414         * Scripts/webkitpy/common/system/outputcapture.py:
415         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
416         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
417         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
418         * Scripts/webkitpy/layout_tests/port/base.py:
419         * Scripts/webkitpy/layout_tests/port/config.py:
420         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
421         * Scripts/webkitpy/layout_tests/port/webkit.py:
422         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
423         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
424         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
425         * Scripts/webkitpy/tool/commands/commandtest.py:
426         * Scripts/webkitpy/tool/commands/queues_unittest.py:
427
428 2011-06-27  Jeff Miller  <jeffm@apple.com>
429
430         Reviewed by Adam Roben.
431
432         Stop copying obsolete WebKit libraries on Windows
433         https://bugs.webkit.org/show_bug.cgi?id=63474
434         
435         Don't copy obsolete WebKit library directories and files on Windows, they no longer exist and just generate extraneous warnings. These include the CharacterSets directory, dnssd.dll, and icudt40.dll.
436
437         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
438         * MiniBrowser/MiniBrowserPostBuild.cmd:
439         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
440
441 2011-06-27  Ryosuke Niwa  <rniwa@webkit.org>
442
443         Add Wyatt Carss to the list of non-committer contributors.
444
445         * Scripts/webkitpy/common/config/committers.py:
446
447 2011-06-27  Adam Barth  <abarth@webkit.org>
448
449         Reviewed by Eric Seidel.
450
451         webkitpy should understand crash logs
452         https://bugs.webkit.org/show_bug.cgi?id=63468
453
454         We're planning to use this functionality to upload crash logs along
455         with test results for new-run-webkit-tests.
456
457         * Scripts/webkitpy/common/system/crashlog.py: Added.
458         * Scripts/webkitpy/common/system/crashlog_unittest.py: Added.
459         * Scripts/webkitpy/common/system/executive.py:
460         * Scripts/webkitpy/common/system/executive_unittest.py:
461         * Scripts/webkitpy/common/system/filesystem.py:
462         * Scripts/webkitpy/common/system/filesystem_mock.py:
463         * Scripts/webkitpy/tool/commands/queries.py:
464
465 2011-06-27  Adam Roben  <aroben@apple.com>
466
467         Make LayoutTestResultsLoader cache whether old-run-webkit-tests exited early due to too many
468         failures
469
470         Fixes <http://webkit.org/b/63470> TestFailures page for a particular builder forgets
471         old-run-webkit-tests exited early after reload
472
473         Reviewed by Anders Carlsson.
474
475         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
476         (LayoutTestResultsLoader.prototype.start): Store both the set of failing tests and whether
477         old-run-webkit-tests exited early due to too many failures in PersistentCache.
478
479 2011-06-27  Adam Roben  <aroben@apple.com>
480
481         Make TestFailures load build names from build.webkit.org/old-results too
482
483         Build results are periodically moved from results to old-results. This change makes those
484         builds still visible to TestFailures.
485
486         Fixes <http://webkit.org/b/63453> TestFailures page doesn't show information for builds that
487         have been moved to build.webkit.org/old-results
488
489         Reviewed by Anders Carlsson.
490
491         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
492         (Builder.prototype.getBuildNames): Extracted code to parse build names from a
493         build.webkit.org directory listing into a separate function. Instead of omitting .zip files,
494         we now only include directory entries whose names are parseable as build names (since
495         old-results sometimes contains other random files/directories from who knows what). We now
496         fetch both results and old-results (with a FIXME about loading old-results on demand),
497         extract build names from each, and concatenate the two sets of names.
498
499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js:
500         (WebKitBuildbot.prototype.parseBuildName): Changed to return null when the build name isn't
501         parseable, rather than throwing an exception.
502
503 2011-06-26  Adam Roben  <aroben@apple.com>
504
505         Store analyzed history directly in LayoutTestHistoryAnalyzer instead of in a generic cache
506
507         It seems silly to have a whole generic cache just to store a single object.
508
509         Fixes <http://webkit.org/b/63407> LayoutTestHistoryAnalyzer has a generic cache but doesn't
510         need one
511
512         Reviewed by Anders Carlsson.
513
514         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
515         (LayoutTestHistoryAnalyzer): Replaced this._cache with this._history.
516         (LayoutTestHistoryAnalyzer.prototype.start): Ditto.
517         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Ditto, and removed the
518         no-longer-needed history argument.
519
520 2011-06-26  Adam Roben  <aroben@apple.com>
521
522         Move some inappropriate code out of Builder
523
524         Fixes <http://webkit.org/b/63406> TestFailure page's Builder class has a bunch of code that
525         isn't really about a builder
526
527         Reviewed by Anders Carlsson.
528
529         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
530         (Builder.prototype.getBuildNames): Renamed from _getBuildNames, since it now needs to be
531         called by other objects.
532
533         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
534         Added. Code came from Builder.
535         (LayoutTestHistoryAnalyzer):
536         (LayoutTestHistoryAnalyzer.prototype.start):
537         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory):
538
539         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
540         Added. Code came from Builder.
541         (LayoutTestResultsLoader):
542         (LayoutTestResultsLoader.prototype.start):
543
544         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
545         (ViewController.prototype._displayBuilder): Changed to use LayoutTestHistoryAnalyzer.
546
547         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in new
548         scripts.
549
550 2011-05-17  Nat Duca  <nduca@chromium.org>
551
552         Reviewed by James Robinson.
553
554         [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
555         https://bugs.webkit.org/show_bug.cgi?id=58408
556
557         * DumpRenderTree/chromium/WebViewHost.cpp:
558         (WebViewHost::paintInvalidatedRegion):
559
560 2011-06-27  Eric Seidel  <eric@webkit.org>
561
562         Reviewed by Adam Barth.
563
564         new-run-webkit-tests needs a --webkit-test-runner option
565         https://bugs.webkit.org/show_bug.cgi?id=63439
566
567         NRWT doesn't actually know how to run with the WebKitTestRunner yet
568         but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.
569
570         There is a bunch of other little cleanup in this patch which I added as I
571         took a tour through all of our hard-coded DumpRenderTree strings.
572
573         * Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
574         * Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
575         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
576         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
577         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
578         * Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
579         * Scripts/webkitpy/layout_tests/port/config.py:
580          - build_dumprendertree had no business in this class, removed it.
581          - Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
582          - Exposed _script_path as script_path() (this probably belongs elsewhere).
583         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
584          - Moved these tests to webkit_unittests.
585         * Scripts/webkitpy/layout_tests/port/webkit.py:
586          - Now respects the --webkit-test-runner option.
587          - setup_test_run is empty in base.py too, no need to override it.
588         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
589          - Test the new hotness.
590          - Bad, bad, bad!  The old code was using a real Executive during unit-testing!
591            I think this code is still hitting disk during the unit tests. :(
592         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
593          - Add the option.
594         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
595          - Remove optional args option.
596         * Scripts/webkitpy/tool/commands/commandtest.py:
597          - Remove optional args option.
598         * Scripts/webkitpy/tool/commands/queues_unittest.py:
599          - Remove optional args option.
600
601 2011-06-27  Chang Shu  <cshu@webkit.org>
602
603         Reviewed by Darin Adler.
604
605         [WK2] WebKitTestRunner should reset FrameFlattening flag to disable before each test
606         https://bugs.webkit.org/show_bug.cgi?id=63457
607
608         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
609         (WTR::InjectedBundle::beginTesting):
610
611 2011-06-27  Raphael Kubo da Costa  <kubo@profusion.mobi>
612
613         Reviewed by Kent Tamura.
614
615         [EFL] DRT: Add an ewk_view specialization for EFL's DumpRenderTree.
616         It will be plugged into the build system as soon as the rest of the
617         DRT code is fully upstreamed.
618         https://bugs.webkit.org/show_bug.cgi?id=63086
619
620         * DumpRenderTree/efl/DumpRenderTreeView.cpp: Added.
621         (onConsoleMessage):
622         (onJavaScriptAlert):
623         (onJavaScriptConfirm):
624         (onJavaScriptPrompt):
625         (drtViewTiledAdd):
626         * DumpRenderTree/efl/DumpRenderTreeView.h: Added.
627
628 2011-06-27  Leandro Pereira  <leandro@profusion.mobi>
629
630         Reviewed by Kent Tamura.
631
632         [EFL] Add an EventSender implementation to EFL's DumpRenderTree along
633         with support files.
634         Build system changes will be made as soon as the whole DumpRenderTree
635         is upstreamed.
636         https://bugs.webkit.org/show_bug.cgi?id=61962
637
638         * DumpRenderTree/efl/EventSender.cpp: Added.
639         (setEvasModifiers):
640         (translateMouseButtonNumber):
641         (sendMouseEvent):
642         (sendClick):
643         (scheduleAsynchronousClickCallback):
644         (updateClickCount):
645         (modifierFromJSValue):
646         (modifiersFromJSValue):
647         (mouseDownCallback):
648         (mouseUpCallback):
649         (mouseMoveToCallback):
650         (evasMouseEventFromHorizontalAndVerticalOffsets):
651         (mouseScrollByCallback):
652         (continuousMouseScrollByCallback):
653         (keyPadNameFromJSValue):
654         (keyNameFromJSValue):
655         (keyDownCallback):
656         (scalePageByCallback):
657         (getClass):
658         (makeEventSender):
659         * DumpRenderTree/efl/EventSender.h: Added.
660
661 2011-06-27  Eric Seidel  <eric@webkit.org>
662
663         Reviewed by Adam Barth.
664
665         Remove evil uses of hasattr
666         https://bugs.webkit.org/show_bug.cgi?id=63430
667
668         For some reason these classes believe that they may be called with
669         various flavors of "option" elements and so carefully check to make
670         sure that the options element has their option before checking it.
671
672         We had a set_option_default method which was never called, so I made it
673         do what callsites seemed to want it to do and replaced 3 callers
674         who previously used hasattr manually to use set_option_default instead.
675
676         * Scripts/webkitpy/layout_tests/port/base.py:
677         * Scripts/webkitpy/layout_tests/port/webkit.py:
678
679 2011-06-27  Kent Tamura  <tkent@chromium.org>
680
681         Reviewed by Hajime Morita.
682
683         [Chromium] WebViewHost should be destructed before LayoutTestController, etc.
684         https://bugs.webkit.org/show_bug.cgi?id=63427
685
686         ~WebViewHost() navigates to about:blank, so it calls some
687         callbacks and LayoutTestController functions.
688
689         * DumpRenderTree/chromium/TestShell.h:
690          Move m_printer upper and move m_webViewHost lower.
691
692 2011-06-27  Adam Barth  <abarth@webkit.org>
693
694         Reviewed by Eric Seidel.
695
696         Move server config files to webkitpy.layout_tests.servers
697         https://bugs.webkit.org/show_bug.cgi?id=63436
698
699         The config files belong with the servers.
700
701         * Scripts/webkitpy/layout_tests/port/httpd2.pem: Removed.
702         * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Removed.
703         * Scripts/webkitpy/layout_tests/servers/http_server.py:
704         * Scripts/webkitpy/layout_tests/servers/httpd2.pem: Copied from Tools/Scripts/webkitpy/layout_tests/port/httpd2.pem.
705         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf: Copied from Tools/Scripts/webkitpy/layout_tests/port/lighttpd.conf.
706
707 2011-06-27  Adam Barth  <abarth@webkit.org>
708
709         Reviewed by Eric Seidel.
710
711         Move websocket_server and http_server to webkitpy.layout_package.servers
712         https://bugs.webkit.org/show_bug.cgi?id=63434
713
714         These classes do not represent ports.  They represent servers.
715
716         * Scripts/new-run-webkit-httpd:
717         * Scripts/new-run-webkit-websocketserver:
718         * Scripts/webkitpy/layout_tests/port/base.py:
719         * Scripts/webkitpy/layout_tests/port/chromium.py:
720         * Scripts/webkitpy/layout_tests/port/http_server.py: Removed.
721         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Removed.
722         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
723         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
724         * Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed.
725         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
726         * Scripts/webkitpy/layout_tests/servers/http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server.py.
727         * Scripts/webkitpy/layout_tests/servers/http_server_base.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_base.py.
728         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py.
729         * Scripts/webkitpy/layout_tests/servers/websocket_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/websocket_server.py.
730
731 2011-06-27  Eric Seidel  <eric@webkit.org>
732
733         Reviewed by Adam Barth.
734
735         Remove Chromium and ChromiumMac implementations of driver_name now that everything uses DumpRenderTree
736         https://bugs.webkit.org/show_bug.cgi?id=63428
737
738         * Scripts/webkitpy/layout_tests/port/chromium.py:
739         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
740
741 2011-06-27  Adam Barth  <abarth@webkit.org>
742
743         Reviewed by Eric Seidel.
744
745         Move apache_http_server.py to webkitpy.layout_package.servers
746         https://bugs.webkit.org/show_bug.cgi?id=63433
747
748         The apache_http_server.py is a server, not a port.
749
750         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Removed.
751         * Scripts/webkitpy/layout_tests/port/base.py:
752         * Scripts/webkitpy/layout_tests/servers: Added.
753         * Scripts/webkitpy/layout_tests/servers/__init__.py: Added.
754         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py.
755
756 2011-06-27  Adam Barth  <abarth@webkit.org>
757
758         Reviewed by Eric Seidel.
759
760         Move rebaseline-chromium-webkit-tests.py to webkitpy.to_be_moved
761         https://bugs.webkit.org/show_bug.cgi?id=63432
762
763         This code isn't in the dependency cone of new-run-webkit-tests. It's
764         unclear what it's final home should be, but this patch moves it out of
765         layout_tests to simply the package.
766
767         * Scripts/rebaseline-chromium-webkit-tests:
768         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Removed.
769         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Removed.
770         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py.
771         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py.
772
773 2011-06-27  Adam Barth  <abarth@webkit.org>
774
775         Reviewed by Eric Seidel.
776
777         Move update_webgl_conformance_tests.py to webkitpy.to_be_moved
778         https://bugs.webkit.org/show_bug.cgi?id=63429
779
780         This package as nothing to do with the layout_tests package.
781
782         * Scripts/update-webgl-conformance-tests:
783         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Removed.
784         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Removed.
785         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py.
786         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py.
787
788 2011-06-27  Adam Barth  <abarth@webkit.org>
789
790         Reviewed by Eric Seidel.
791
792         Move deduplicate_tests.py into webkitpy.to_be_moved
793         https://bugs.webkit.org/show_bug.cgi?id=63426
794
795         deduplicate_tests.py doesn't haven anything to do with layout tests.
796         It's really a separate script.  This patch moves it to the (new)
797         to_be_moved package so that it doesn't distract us when working on NRWT.
798
799         * Scripts/deduplicate-tests:
800         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Removed.
801         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Removed.
802         * Scripts/webkitpy/test/main.py:
803         * Scripts/webkitpy/to_be_moved: Added.
804         * Scripts/webkitpy/to_be_moved/__init__.py: Added.
805         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests.py.
806         * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py.
807
808 2011-06-26  Adam Barth  <abarth@webkit.org>
809
810         Rubber-stamped by Eric Seidel.
811
812         Remove empty directory.
813
814         * Scripts/webkitpy/layout_tests/test_types: Removed.
815
816 2011-06-25  Naoki Takano  <honten@chromium.org>
817
818         Reviewed by Eric Seidel.
819
820         Change my entry from contributors to committers.
821         https://bugs.webkit.org/show_bug.cgi?id=63043
822
823         * Scripts/webkitpy/common/config/committers.py: Change my e-mail from takano.naoki@gmail.com to honten@chromium.org. And move the entry to commiters from contributors.
824
825 2011-06-25  Adam Barth  <abarth@webkit.org>
826
827         Reviewed by Eric Seidel.
828
829         [Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
830         https://bugs.webkit.org/show_bug.cgi?id=63394
831
832         * DumpRenderTree/chromium/LayoutTestController.cpp:
833         (LayoutTestController::queueLoad):
834
835 2011-06-25  Brent Fulgham  <bfulgham@webkit.org>
836
837         Unreviewed build correction after r89426.
838
839         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops:
840           Link with Cairo DLL for new functionality.
841         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Include compatibility
842           code for snprintf.
843
844 2011-06-25  Dimitri Glazkov  <dglazkov@chromium.org>
845
846         Reviewed by Adam Barth.
847
848         run-bindings-tests does not work on Chromium Windows.
849         https://bugs.webkit.org/show_bug.cgi?id=63382
850
851         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed run-bindings-tests as a build step for cr-win.
852
853 2011-06-25  Dan Bernstein  <mitz@apple.com>
854
855         Try to fix the Qt and Chromium builds.
856
857         * DumpRenderTree/chromium/LayoutTestController.cpp:
858         (LayoutTestController::setEncodedAudioData):
859         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
860
861 2011-06-24  Dan Bernstein  <mitz@apple.com>
862
863         Reviewed by Anders Carlsson.
864
865         Add an option to enable legacy rounding hacks
866         https://bugs.webkit.org/show_bug.cgi?id=63363
867
868         Added layoutTestController.allowRoundingHacks() and implemented it
869         on OS X.
870
871         * DumpRenderTree/LayoutTestController.cpp:
872         (allowRoundingHacksCallback):
873         (LayoutTestController::staticFunctions):
874         * DumpRenderTree/LayoutTestController.h:
875         * DumpRenderTree/chromium/LayoutTestController.cpp:
876         (LayoutTestController::allowRoundingHacks):
877         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
878         (LayoutTestController::allowRoundingHacks):
879         * DumpRenderTree/mac/DumpRenderTree.mm:
880         (resetWebViewToConsistentStateBeforeTesting):
881         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
882         (LayoutTestController::allowRoundingHacks):
883         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
884         (LayoutTestController::allowRoundingHacks):
885         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
886         (LayoutTestController::allowRoundingHacks):
887         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
888         (LayoutTestController::allowRoundingHacks):
889
890 2011-06-24  Adam Roben  <aroben@apple.com>
891
892         Include the directory containing the failing tests in titles of bugs filed from TestFailures
893         when all the tests won't fit
894
895         Fixes <http://webkit.org/b/63350> Short bug titles from TestFailures page give no indication
896         which tests are failing
897
898         Reviewed by David Kilzer.
899
900         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
901         (longestCommonPathPrefix): Added. Given a set of paths, returns the longest common prefix
902         that ends in a path separator.
903
904         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
905         (ViewController.prototype._domForNewAndExistingBugs): When we can't fit all the test names
906         in the title, first try to include the longest common prefix of the test names, then, if
907         that's still too long or there's no common prefix, fall back to not including any
908         information about which tests are failing.
909
910 2011-06-24  Adam Roben  <aroben@apple.com>
911
912         Include links to Trac in bugs filed from TestFailures
913
914         Fixes <http://webkit.org/b/63348> Bugs filed from TestFailures page should include links to
915         Trac for suspect revisions
916
917         Reviewed by David Kilzer.
918
919         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
920         (Trac.prototype.changesetURL): New function, returns the URL for a particular revision in
921         Trac.
922
923         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
924         (ViewController.prototype._domForNewAndExistingBugs): If there's only one suspect revision,
925         include a link to Trac for it in the first sentence of the description. Otherwise include a
926         link to the suspect range after the list of failing tests.
927
928 2011-06-24  Nat Duca  <nduca@chromium.org>
929
930         Unreviewed, rolling out r89694.
931         http://trac.webkit.org/changeset/89694
932         https://bugs.webkit.org/show_bug.cgi?id=58408
933
934         Test shell still not ready for animate changes.
935
936         * DumpRenderTree/chromium/WebViewHost.cpp:
937         (WebViewHost::paintInvalidatedRegion):
938
939 2011-06-24  Adam Roben  <aroben@apple.com>
940
941         Fix typos introduced in r89696
942
943         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
944         (Builder.prototype.getNumberOfFailingTests): Pass the result data's constituent parts to the
945         callback, since that's what it expects.
946
947 2011-06-24  Adam Roben  <aroben@apple.com>
948
949         Make TestFailures correctly remember whether old-run-webkit-tests exited early
950
951         Fixes <http://webkit.org/b/63342> TestFailures page incorrectly claims test run ran to
952         completion after reload
953
954         Reviewed by David Kilzer.
955
956         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
957         (Builder.prototype.getNumberOfFailingTests): Instead of just storing the number of failures
958         in the PeristentCache, store an object that contains both the number of failures and whether
959         old-run-webkit-tests exited early.
960
961 2011-06-24  Adam Roben  <aroben@apple.com>
962
963         Add links to regression ranges in Trac to the TestFailures page
964
965         Fixes <http://webkit.org/b/61060> <rdar://problem/9452153> TestFailures page should provide
966         links to regression ranges in Trac
967
968         Reviewed by David Kilzer.
969
970         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Added.
971         (Trac): This new class represents a particular instance of Trac for a single project.
972         (Trac.prototype.logURL): Returns the URL that can be used to see the log of the given
973         repository path between the two specified revisions
974         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
975         (ViewController): Added new trac argument.
976         (ViewController.prototype._displayBuilder): Moved code to create the DOM for the
977         passed/failed builds from here...
978         (ViewController.prototype._domForRegressionRange): ...to here. Now also includes a link to
979         Trac if there are multiple suspect revisions.
980
981         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
982         Trac.js and pass a Trac instance for trac.webkit.org to the ViewController.
983
984 2011-05-17  Nat Duca  <nduca@chromium.org>
985
986         Reviewed by James Robinson.
987
988         [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
989         https://bugs.webkit.org/show_bug.cgi?id=58408
990
991         * DumpRenderTree/chromium/WebViewHost.cpp:
992         (WebViewHost::paintInvalidatedRegion):
993
994 2011-06-24  Dominic Cooney   <dominicc@chromium.org>
995
996         Reviewed by Dimitri Glazkov.
997
998         Convert shadow DOM-related tests to use window.internals
999         https://bugs.webkit.org/show_bug.cgi?id=61671
1000
1001         Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
1002         removeShadowRoot from layoutTestController; these have been
1003         replaced by equivalents in window.internals instead.
1004
1005         * DumpRenderTree/LayoutTestController.cpp:
1006         (LayoutTestController::staticFunctions):
1007         * DumpRenderTree/LayoutTestController.h:
1008         * DumpRenderTree/chromium/LayoutTestController.cpp:
1009         (LayoutTestController::LayoutTestController):
1010         * DumpRenderTree/chromium/LayoutTestController.h:
1011         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1012         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1013         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1014         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1015         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1016         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1017         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1018         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1019         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1020
1021 2011-06-24  Csaba Osztrogonác  <ossy@webkit.org>
1022
1023         Reviewed by Dirk Schulze.
1024
1025         Make run-bindings-tests remove its temporary directories.
1026         https://bugs.webkit.org/show_bug.cgi?id=63320
1027
1028         * Scripts/run-bindings-tests:
1029
1030 2011-06-23  MORITA Hajime  <morrita@google.com>
1031
1032         Reviewed by Kent Tamura.
1033
1034         [Chromium] Invalid write inside WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld
1035         https://bugs.webkit.org/show_bug.cgi?id=63216
1036
1037         Deleted m_webViewHost which looks leaked.
1038         
1039         * DumpRenderTree/chromium/TestShell.h:
1040         * DumpRenderTree/chromium/TestShell.cpp:
1041         (TestShell::~TestShell):
1042
1043 2011-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1044
1045         Unreviewed. Fix WebKit2 GTK build.
1046
1047         * WebKitTestRunner/GNUmakefile.am:
1048
1049 2011-06-23  Ryuan Choi  <ryuan.choi@samsung.com>
1050
1051         Unreviewed, add myself as committer.
1052
1053         * Scripts/webkitpy/common/config/committers.py:
1054
1055 2011-06-23  Nat Duca  <nduca@chromium.org>
1056
1057         Unreviewed, add myself as committer.
1058
1059         * Scripts/webkitpy/common/config/committers.py:
1060
1061 2011-06-23  Dirk Pranke  <dpranke@chromium.org>
1062
1063         Reviewed by Tony Chang.
1064
1065         nrwt: move http locking code into manager
1066         https://bugs.webkit.org/show_bug.cgi?id=63103
1067
1068         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1069         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1070
1071 2011-06-23  Alok Priyadarshi  <alokp@chromium.org>
1072
1073         Reviewed by James Robinson.
1074
1075         [chromium] Add support for running layout tests with accelerated rendering
1076         https://bugs.webkit.org/show_bug.cgi?id=63274
1077
1078         * Scripts/webkitpy/layout_tests/port/chromium.py:
1079         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1080
1081 2011-06-23  Adam Roben  <aroben@apple.com>
1082
1083         Avoid fetching JSON data when possible on TestFailures page to determine if
1084         old-run-webkit-tests exited early
1085
1086         As of r89610, results.html includes information about whether old-run-webkit-tests exited
1087         early, so we don't need to look at JSON data to get this information for builds newer than
1088         that.
1089
1090         Fixes <http://webkit.org/b/63281> TestFailures page fetches build JSON for every build,
1091         which is slow and limits history to the last build master restart
1092
1093         Reviewed by David Kilzer.
1094
1095         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1096         (Builder.prototype._getFailingTests): Moved code dealing with results.html into a new
1097         function. If we're dealing with a build that has early-exit information in results.html,
1098         don't bother fetching JSON data and go straight to parsing results.html. Otherwise first use
1099         the JSON data to determine if old-run-webkit-tests exited early, and then parse results.html
1100         (as before).
1101
1102 2011-06-23  Eric Seidel  <eric@webkit.org>
1103
1104         Reviewed by Adam Barth.
1105
1106         sheriffbot can no longer restart
1107         https://bugs.webkit.org/show_bug.cgi?id=63221
1108
1109         Fixed and unit tested.
1110
1111         * Scripts/webkitpy/tool/bot/queueengine.py:
1112         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
1113         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1114
1115 2011-06-23  Martin Robinson  <mrobinson@igalia.com>
1116
1117         Reviewed by Xan Lopez.
1118
1119         [GTK] [WebKit2] WebKitTestRunner does not properly load TestNetscapePlugin
1120         https://bugs.webkit.org/show_bug.cgi?id=63287
1121
1122         Send the path to the TestNetscapePlugin to the WKTR via an environment variable
1123         so that the plugin loads properly.
1124
1125         * Scripts/old-run-webkit-tests: Pass the appropriate environment variable to WKTR.
1126         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1127         (WTR::getEnvironmentVariableAsUTF8String): Added this helper which abstracts away some
1128         of the work for getting an environment variable and converting it to UTF-8.
1129         (WTR::TestController::initializeInjectedBundlePath): Use the helper.
1130         (WTR::TestController::initializeTestPluginDirectory): Get the path from an environment variable now.
1131
1132 2011-06-23  Adam Roben  <aroben@apple.com>
1133
1134         Record whether old-run-webkit-tests aborted early in results.html
1135
1136         Fixes <http://webkit.org/b/63280> results.html gives no indication of whether
1137         old-run-webkit-tests stopped running tests early
1138
1139         Reviewed by David Kilzer.
1140
1141         * Scripts/old-run-webkit-tests:
1142         (top level): Switched to heredoc syntax for printing the start of results.html for clarity.
1143         Added a <style> element with some styles for the new message. If we stopped running early,
1144         put the reason why at the top of results.html.
1145         (stopRunningTestsEarlyIfNeeded): Store the message we print in the new
1146         $stoppedRunningEarlyMessage global.
1147
1148 2011-06-23  Adam Roben  <aroben@apple.com>
1149
1150         Cache some of the TestFailures page's data in localStorage
1151
1152         This makes reloading TestFailures much faster. Right now we only store the number of failing
1153         tests and the list of failing tests for each build. We may choose to store more later, but
1154         it's easy to run up against quota limits.
1155
1156         Fixes <http://webkit.org/b/61520> TestFailures page should take advantage of LocalStorage
1157         APIs (or similar) to improve loading performance
1158
1159         Reviewed by David Kilzer.
1160
1161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1162         (Builder.prototype.getNumberOfFailingTests): Changed to use the new PersistentCache object.
1163         (Builder.prototype.startFetchingBuildHistory): Changed to pass whether or not we're still
1164         fetching data to the callback.
1165         (Builder.prototype._getFailingTests): Changed to use the new PersistentCache object. We now
1166         store the tests in the cache just before calling the callback. (The previous code in this
1167         function relied on being able to modify the tests object after storing it in the cache and
1168         having the cached version be updated. This worked while it was a non-serialized cache, but
1169         PersistentCache uses serialization.)
1170
1171         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Added.
1172         (PersistentCache): This object wraps localStorage. It uses JSON to serialize/deserialize
1173         values, and stores the date that each value was initially stored along with it. This is
1174         later used for pruning the cache.
1175         (PersistentCache.contains): Checks whether the key exists in localStorage.
1176         (PersistentCache.get): Fetch the string we stored in localStorage and extract the original
1177         value out of it.
1178         (PersistentCache.set): Serialize the value, add the date to it, and store it in
1179         localStorage. If this fails due to quota limits, empty the whole cache and try again.
1180         (PersistentCache.prune): Delete any cached data that is deemed old enough.
1181         (PersistentCache._addDateToJSONString): Prepend the current date to the string.
1182         (PersistentCache._emptyCache): Delete everything from localStorage.
1183         (PersistentCache._parseDateAndJSONFromString): Split apart the date and the JSON string and
1184         return them.
1185
1186         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1187         (ViewController.prototype._displayBuilder): Updated for change to callback signature. When
1188         we finish fetching data, prune the PersistentCache. While I was here I also fixed a bug
1189         where we'd never show the new bug link for tests for which we couldn't determine a passing
1190         revision.
1191
1192         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
1193         PersistentCache.js.
1194
1195 2011-06-23  Adam Roben  <aroben@apple.com>
1196
1197         Make finding existing bugs and filing new bugs work on TestFailures even when lots of tests are failing
1198
1199         One bug this fixes is <http://webkit.org/b/61660> New bug links on TestFailures page often
1200         contain titles that are so long they are rejected by Bugzilla
1201
1202         Reviewed by David Kilzer.
1203
1204         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
1205         (Bugzilla.prototype.quickSearch): Use fetchResource to POST the search query rather than
1206         using a query string on the URL. If the search query is very long, using a query string can
1207         cause the request to be rejected due to the URL being too long. POSTing avoids this issue.
1208         (Bugzilla.maximumBugTitleLength): Added this constant based on Bugzilla's implementation.
1209
1210         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1211         (.new-bug-form): Hide the form that we secretly use to file a new bug.
1212
1213         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
1214         (fetchResource): Added. Code came from getResource. If we're using a GET request, add the
1215         query parameters to the URL. Otherwise, send them as the body of the request along with the
1216         appropriate headers.
1217         (getResource): Now just calls through to fetchResource.
1218         (urlEncodedQueryParameters): Added. Moved some code here...
1219         (addQueryParametersToURL): ...from here.
1220
1221         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1222         (ViewController.prototype._domForNewAndExistingBugs): Shorten the title to just mention the
1223         number of failing tests if mentioning all the tests would make the title too long. Improved
1224         the description for large numbers of failures by listing the tests one-per-line instead of
1225         just having them be comma-separated, which was hard to read. Use a form to file the new bug
1226         instead of a link so that we can POST the form data. (Using a URL with a query string can
1227         result in the URL being too long.) The new bug link now just submits the form.
1228
1229 2011-06-23  Adam Roben  <aroben@apple.com>
1230
1231         Show closed bugs on the TestFailures page in addition to open ones
1232
1233         Fixes <http://webkit.org/b/63194> TestFailures page should show closed bugs, too
1234
1235         Reviewed by David Kilzer.
1236
1237         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
1238         (Bugzilla.prototype.quickSearch): Added code to extract the bug's status and store it in the
1239         returned data.
1240         (Bugzilla.isOpenStatus): New function, returns true if the passed-in status indicates that
1241         the associated bug is still open.
1242
1243         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
1244         (addQueryParametersToURL): Add a missing semicolon.
1245         (Node.prototype.appendChildren): New function, like appendChild but takes an array-like
1246         object and appends each of the values stored within.
1247
1248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1249         (ViewController.prototype._domForNewAndExistingBugs): Prepend 'ALL' to the query so closed
1250         bugs will be included in the results. Split the returned bugs into two sets: those which are
1251         open, and those which are closed. Put the open bugs at the top level of the list, and the
1252         closed bugs in a second level.
1253
1254 2011-06-23  Adam Roben  <aroben@apple.com>
1255
1256         Don't count new tests as failures on the TestFailures page
1257
1258         Fixes <http://webkit.org/b/63254> TestFailures page calls new tests "failures", even though
1259         they aren't
1260
1261         Reviewed by Anders Carlsson.
1262
1263         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
1264         (Builder.prototype.getNumberOfFailingTests): Don't add the number of new tests to the number
1265         of failures.
1266
1267 2011-06-23  Dirk Pranke  <dpranke@chromium.org>
1268
1269         Reviewed by Eric Seidel.
1270
1271         nrwt: make TestInput objects printable
1272         https://bugs.webkit.org/show_bug.cgi?id=63225
1273
1274         This makes debugging slighlty easier.
1275
1276         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
1277
1278 2011-06-22  Daniel Bates  <dbates@webkit.org>
1279
1280         Reviewed by Adam Barth.
1281
1282         test-webkitpy --all errors out because scm_unittest.py can't find module checkout
1283         https://bugs.webkit.org/show_bug.cgi?id=62943
1284
1285         Remove "from .checkout import Checkout" from scm_unittest.py since it's included
1286         by Scripts/webkitpy/common/checkout/__init__.py.
1287
1288         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1289
1290 2011-06-22  Dominic Cooney  <dominicc@chromium.org>
1291
1292         Reviewed by Mark Rowe.
1293
1294         Add window.internals to WebKit2's WebKitTestRunner.
1295         https://bugs.webkit.org/show_bug.cgi?id=61073
1296
1297         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pxbproj:
1298         * WebKitTestRunner/Configurations/Base.xcconfig:
1299         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
1300         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1301         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
1302         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1303         (WTR::InjectedBundlePage::didClearWindowForFrame):
1304         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1305         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1306
1307 2011-06-22  Eric Seidel  <eric@webkit.org>
1308
1309         Reviewed by Adam Barth.
1310
1311         Make sheriff-bot rollout messages a little nicer
1312         https://bugs.webkit.org/show_bug.cgi?id=63107
1313
1314         itertools.chain.from_iterable is new in 2.6,
1315         use itertools.chain(*list) for 2.5 compat.
1316
1317         * Scripts/webkitpy/tool/bot/irc_command.py:
1318
1319 2011-06-22  Eric Seidel  <eric@webkit.org>
1320
1321         Reviewed by Adam Barth.
1322
1323         Make sheriff-bot robust against exceptions from commands
1324         https://bugs.webkit.org/show_bug.cgi?id=63211
1325
1326         sheriff-bot was acting strange this afternoon.
1327         We don't know if this will fix the cause, but
1328         at least it adds some unit tests and catches
1329         one possible cause.
1330
1331         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
1332         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1333
1334 2011-06-22  Mark Rowe  <mrowe@apple.com>
1335
1336         Reviewed by David Levin.
1337
1338         <http://webkit.org/b/63212> TestWebKitAPI Xcode project has bogus settings since r86287
1339
1340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Fix the reference to libgtest.a to
1341         be relative to the built products directory rather than using a hard-coded path. Remove the
1342         explicit settings of FRAMEWORK_SEARCH_PATHS, HEADER_SEARCH_PATHS and LIBRARY_SEARCH_PATHS
1343         as they're all unnecessary. If they were necessary they should be set in the .xcconfig file
1344         rather than in the .xcodeproj directly.
1345
1346 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
1347
1348         Reviewed by Ojan Vafai.
1349
1350         new-run-webkit-tests: remove obsolete port.shut_down_http_server method
1351         https://bugs.webkit.org/show_bug.cgi?id=59993
1352
1353         * Scripts/webkitpy/layout_tests/port/base.py:
1354         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1355         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1356         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1357         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1358         * Scripts/webkitpy/layout_tests/port/gtk.py:
1359         * Scripts/webkitpy/layout_tests/port/mac.py:
1360         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1361         * Scripts/webkitpy/layout_tests/port/qt.py:
1362         * Scripts/webkitpy/layout_tests/port/win.py:
1363
1364 2011-06-22  Luke Macpherson   <macpherson@chromium.org>
1365
1366         Reviewed by Andreas Kling.
1367
1368         Move macpherson from contributor list to committer list.
1369         https://bugs.webkit.org/show_bug.cgi?id=63179
1370
1371         * Scripts/webkitpy/common/config/committers.py:
1372         Move macpherson from contributor list to committer list.
1373
1374 2011-06-22  David Levin  <levin@chromium.org>
1375
1376         Reviewed by Adam Barth.
1377
1378         check-webkit-style should detect returning (Own|Ref)Ptr instead of the Pass*Ptr version.
1379         https://bugs.webkit.org/show_bug.cgi?id=63204
1380
1381         * Scripts/webkitpy/style/checkers/cpp.py: Added a check for the return value and combined
1382           with similar code for the parameter checking.
1383         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Removed pass_ptr checks from
1384           those done for single lines since they don't make sense in that case (variable decls look like function decls).
1385           Removed some redundant comments (one of which was slightly wrong).
1386           Added checks for the new functionality and minor other test changes.
1387
1388 2011-06-22  Nate Chapin  <japhet@chromium.org>
1389
1390         Reviewed by Adam Barth.
1391
1392         Add libsoup to libWebCoreInternals build.
1393         https://bugs.webkit.org/show_bug.cgi?id=62066
1394
1395         * GNUmakefile.am:
1396
1397 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
1398
1399         Reviewed by Tony Chang.
1400
1401         nrwt: handle missing httpd cleanly
1402         https://bugs.webkit.org/show_bug.cgi?id=62027
1403
1404         We had reverted the change in r89414, so this adds it back in
1405         (modifying check_sys_deps() in port/base.py to check for an
1406         installed web server).
1407
1408         This change then fixes the change in r89414 to stub out the
1409         check_sys_deps() in the test port so that the unit tests run correctly.
1410
1411         * Scripts/webkitpy/layout_tests/port/base.py:
1412         * Scripts/webkitpy/layout_tests/port/test.py:
1413
1414 2011-06-22  David Levin  <levin@chromium.org>
1415
1416         Reviewed by Adam Barth.
1417
1418         check-webkit-style should check for invalid uses of RefPtr/OwnPtr as parameters.
1419         https://bugs.webkit.org/show_bug.cgi?id=63188
1420
1421         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
1422         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1423
1424 2011-06-22  Tony Chang  <tony@chromium.org>
1425
1426         Reviewed by Ojan Vafai.
1427
1428         Add a buildbot for testing ENABLE(CSS3_FLEXBOX)
1429         https://bugs.webkit.org/show_bug.cgi?id=62891
1430
1431         * BuildSlaveSupport/build.webkit.org-config/config.json:
1432
1433 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
1434
1435         Reviewed by Ojan Vafai.
1436
1437         nrwt: don't look for http lock when running the test port
1438         https://bugs.webkit.org/show_bug.cgi?id=63158
1439
1440         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1441         * Scripts/webkitpy/layout_tests/port/test.py:
1442
1443 2011-06-22  Balazs Kelemen  <kbalazs@webkit.org>
1444
1445         Reviewed by Andreas Kling.
1446
1447         [Qt][WK2] Set up plugin tests
1448         https://bugs.webkit.org/show_bug.cgi?id=63066
1449
1450         * WebKitTestRunner/qt/TestControllerQt.cpp:
1451         (WTR::TestController::initializeTestPluginDirectory):
1452         Use the QTWEBKIT_PLUGIN_PATH environment variable as the path
1453         of the test plugin like DRT does.
1454
1455 2011-06-22  Eric Seidel  <eric@webkit.org>
1456
1457         Reviewed by Ojan Vafai.
1458
1459         Make sheriff-bot rollout messages a little nicer
1460         https://bugs.webkit.org/show_bug.cgi?id=63107
1461
1462         It annoyed me this afternoon that I had to convert sheriff-bots "r12345" revisions
1463         into urls myself.  So I have now fixed its "preparing" message to include a url.
1464
1465         I also figured that I should make the messages mention all of the responsible parties
1466         so that rollouts are never surprises.  If you're in the channel and were involved
1467         in a patch, you will see if someone is using sheriff-bot to rollout a patch.
1468
1469         As part of doing this I also changed (and tested) _parse_args to fail-fast
1470         when given invalid args.
1471
1472         * Scripts/webkitpy/tool/bot/irc_command.py:
1473         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1474         * Scripts/webkitpy/tool/bot/sheriff.py:
1475         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1476
1477 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
1478
1479         Reviewed by Tony Chang.
1480
1481         run-webkit-websocketserver fails to stop websocket server
1482         https://bugs.webkit.org/show_bug.cgi?id=63123
1483
1484         There's a ten-character change in new-run-webkit-websocketserver
1485         that fixes the actual bug, and then we update the code in
1486         new-run-webkit-httpd to do the actual stop call, and add more tests
1487         (refactoring the existing test code so that it is shared).
1488
1489         * Scripts/new-run-webkit-httpd:
1490         * Scripts/new-run-webkit-websocketserver:
1491         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py:
1492
1493 2011-06-22  Adam Roben  <aroben@apple.com>
1494
1495         Add links to existing bugs related to failing tests on TestFailures page
1496
1497         I changed the layout of the page a little to make it easier to read with all the new
1498         information. Passing/failing revisions have been moved down below the list of tests to be
1499         closer to the existing bugs and the new bug link. And each set of tests and its relevant
1500         information is in a light gray box.
1501
1502         Fixes <http://webkit.org/b/61665> TestFailures page should link to existing bugs when
1503         possible
1504
1505         Reviewed by Darin Adler.
1506
1507         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Added.
1508         (Bugzilla): This new class represents a single Bugzilla instance.
1509         (Bugzilla.prototype.quickSearch): Searches Bugzilla using its Quick Search functionality,
1510         passing the resulting bug titles and URLs to the callback when complete. If called multiple
1511         times with the same query before the query returns, caches the callbacks so that only one
1512         query is sent over the wire. When the query completes, all pending callbacks are called.
1513
1514         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
1515         (#failure-history): Reduce the margin/padding on the top-level list a bit.
1516         (#failure-history > li): Put each set of tests in a gray box, and indent most information
1517         inside the box.
1518         (.test-list): Unindent the list of failing tests so it is visually at the top level.
1519         (.new-and-existing-bugs): Reduce the space at the bottom of this area so that the bottom of
1520         each box isn't a big empty space.
1521         (.existing-bugs-list): Use a smaller text size for existing bugs, since their titles can be
1522         quite long.
1523
1524         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
1525         (addQueryParametersToURL): New function extracted from
1526         ViewController.prototype._domForNewAndExistingBugs.
1527
1528         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
1529         (ViewController): Take and store an optional Bugzilla instance.
1530         (ViewController.prototype._displayBuilder): Give the top-level list an id for styling
1531         purposes and move the list of failing tests above all other information. Only show bug
1532         information once we've determined the most-recent passing revision for a set of tests. It's
1533         not that useful to file a new bug before this information has been determined, and searching
1534         for existing bugs before we've figured out which tests started failing at the same time
1535         would end up giving you information about a bunch of unrelated tests.
1536         (ViewController.prototype._domForNewAndExistingBugs): Renamed from _domForNewBugLink. Now
1537         returns a DocumentFragment instead of an HTMLParagraphElement. If we don't have a Bugzilla
1538         instance, just returns an empty DocumentFragment. Starts a search for bugs related to the
1539         failing tests, and adds links to the bugs when the search completes.
1540
1541         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pass a
1542         Bugzilla instance for bugs.webkit.org to the ViewController.
1543
1544 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1545
1546         Reviewed by Martin Robinson.
1547
1548         [GTK] Apply current view settings to newly created views in GtkLauncher
1549         https://bugs.webkit.org/show_bug.cgi?id=63142
1550
1551         * GtkLauncher/main.c:
1552         (createWebViewCb):
1553
1554 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1555
1556         Reviewed by Martin Robinson.
1557
1558         [GTK] Use GOption to parse main arguments in GtkLauncher
1559         https://bugs.webkit.org/show_bug.cgi?id=63060
1560
1561         Instead of getting the settings from the view, create a new
1562         settings object not associated with any view so that we can parse
1563         the command line arguments before creating the view. It will also
1564         allows to use the same settings for more than one view if we
1565         eventually support passing more than one uri from the command
1566         line.
1567
1568         * GtkLauncher/main.c:
1569         (parseOptionEntryCallback): Make this function static. Also use
1570         g_ascii_strtoll/g_ascii_strtod to parse int/float values instead
1571         of atoi/atof to provide better error messages. And always fill the
1572         error struct when the function fails.
1573         (getOptionEntriesFromWebKitWebSettings): Use an array of
1574         GOptionEntry structs instead of a GArray, since that is what
1575         g_option_group_add_entries() expects and the array size doesn't
1576         change.
1577         (addWebSettingsGroupToContext): Helper function to add the
1578         websettings group to the option context.
1579         (main): Create the option context to parse command line arguments.
1580
1581 2011-06-22  Martin Robinson  <mrobinson@igalia.com>
1582
1583         Reviewed by Adam Roben.
1584
1585         [GTK] Implement pixel dump support for WebKitTestRunner
1586         https://bugs.webkit.org/show_bug.cgi?id=58242
1587
1588         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Added.
1589         * GNUmakefile.am: Separate out the ImageDiff bits of the GNUmakefile.
1590         * Scripts/old-run-webkit-tests: Update to add support for the GTK+ port.
1591         * WebKitTestRunner/GNUmakefile.am: Added Cairo specific files to the build.
1592         * WebKitTestRunner/TestInvocation.cpp: Moved this code to the platform-independent
1593         file so that we can share it across platforms.
1594         (WTR::TestInvocation::compareActualHashToExpectedAndDumpResults):
1595         * WebKitTestRunner/TestInvocation.h: Updated method list.
1596         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added Cairo implementation.
1597         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1598         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Updated to use new helper.
1599
1600 2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>
1601
1602         Unreviewed, rolling out r89414.
1603         http://trac.webkit.org/changeset/89414
1604         https://bugs.webkit.org/show_bug.cgi?id=63130
1605
1606         It broke webkitpy tests (Requested by Ossy on #webkit).
1607
1608         * Scripts/webkitpy/layout_tests/port/base.py:
1609
1610 2011-06-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1611
1612         Reviewed by Dirk Pranke.
1613
1614         [NRWT] Print error message when there is no httpd present on the system
1615         https://bugs.webkit.org/show_bug.cgi?id=62027
1616
1617         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1618
1619 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
1620
1621         Unreviewed, build fix.
1622         Fix crashes in new-run-webkit-tests resulting from the
1623         change to the http_server logic in r89400. Python 2.5
1624         on Mac 10.5 has some weird error paths.
1625
1626         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1627         * Scripts/webkitpy/common/system/executive.py:
1628
1629 2011-06-21  MORITA Hajime  <morrita@google.com>
1630
1631         Unreviewed, rolling out r89401 and r89403.
1632         http://trac.webkit.org/changeset/89401
1633         http://trac.webkit.org/changeset/89403
1634         https://bugs.webkit.org/show_bug.cgi?id=62970
1635
1636         Breaks mac build and mistakenly enables the spellcheck API
1637
1638         * Scripts/build-webkit:
1639         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1640
1641 2011-06-21  Kent Tamura  <tkent@chromium.org>
1642
1643         [Mac] Sort Xcode project files.
1644
1645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1646
1647 2011-06-20  MORITA Hajime  <morrita@google.com>
1648
1649         Reviewed by Kent Tamura.
1650
1651         Spellcheck API should be build-able.
1652         https://bugs.webkit.org/show_bug.cgi?id=62970
1653
1654         * Scripts/build-webkit:
1655
1656 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
1657
1658         Reviewed by Tony Chang.
1659
1660         nrwt: attempt #3 at fixing server startup/shutdown
1661         https://bugs.webkit.org/show_bug.cgi?id=62829
1662
1663         Attempt yet again to make starting and stopping servers
1664         reliable. It turns out that apache has races between when the
1665         ctl process exists and when it writes/removes the pid file.
1666         This change accounts for the races.
1667
1668         * Scripts/new-run-webkit-httpd:
1669         * Scripts/webkitpy/common/system/executive.py:
1670         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1671         * Scripts/webkitpy/layout_tests/port/base.py:
1672         * Scripts/webkitpy/layout_tests/port/http_server.py:
1673         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1674         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
1675         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1676         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1677
1678 2011-06-21  Dmitry Lomov  <dslomov@google.com>
1679
1680         Reviewed by Adam Roben.
1681
1682         https://bugs.webkit.org/show_bug.cgi?id=63080
1683         Unit-tests step on test-only bot is broken.
1684         Removing the step until run-api-tests is fixed.
1685
1686         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1687
1688 2011-06-20  Dmitry Lomov  <dslomov@google.com>
1689
1690         Reviewed by David Levin.
1691
1692         https://bugs.webkit.org/show_bug.cgi?id=63017
1693         "Unit tests" step on bots should provide more information in case of failure.
1694
1695         * BuildSlaveSupport/build.webkit.org-config/master.cfg: added --verbose flag to UnitTests step.
1696
1697 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
1698
1699         Reviewed by Ojan Vafai.
1700
1701         new-run-webkit-tests: order shards by name, not number of tests
1702         https://bugs.webkit.org/show_bug.cgi?id=62753
1703
1704         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1705
1706 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
1707
1708         Reviewed by Ojan Vafai.
1709
1710         we should only log the test names to the tests_run.txt files during layout_tests
1711         https://bugs.webkit.org/show_bug.cgi?id=62751
1712
1713         * Scripts/old-run-webkit-tests:
1714         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1715
1716 2011-06-20  Eric Seidel  <eric@webkit.org>
1717
1718         Reviewed by Adam Barth.
1719
1720         commit-queue/ews-bots should run run-bindings-tests for every patch
1721         https://bugs.webkit.org/show_bug.cgi?id=63010
1722
1723         * Scripts/webkitpy/common/config/ports.py:
1724         * Scripts/webkitpy/tool/commands/download_unittest.py:
1725         * Scripts/webkitpy/tool/steps/runtests.py:
1726         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1727         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1728
1729 2011-06-20  Chang Shu  <cshu@webkit.org>
1730
1731         Reviewed by Adam Barth.
1732
1733         fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code tests fail when showModalDialog isn't supported
1734         https://bugs.webkit.org/show_bug.cgi?id=53676
1735
1736         * WebKitTestRunner/TestController.cpp:
1737         (WTR::TestController::initialize):
1738
1739 2011-06-20  Eric Seidel  <eric@webkit.org>
1740
1741         Reviewed by Adam Barth.
1742
1743         buildbots should run run-bindings-tests
1744         https://bugs.webkit.org/show_bug.cgi?id=63001
1745
1746         run-bindings-tests takes 2.4 seconds on my machine, so
1747         I expect this will not be noticeable on the bots.
1748
1749         I also removed tiger-specific checks since Tiger is no
1750         longer a supported platform for webkit.
1751
1752         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1753
1754 2011-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1755
1756         Unreviewed. Fix WebKit2 GTK build after r89249.
1757
1758         * GtkLauncher/main.c:
1759         (main):
1760
1761 2011-06-20  Pavel Feldman  <pfeldman@chromium.org>
1762
1763         Reviewed by Yury Semikhatsky.
1764
1765         Web Inspector: remove LayoutTestController::setTimelineProfilingEnabled.
1766         https://bugs.webkit.org/show_bug.cgi?id=62994
1767
1768         * DumpRenderTree/LayoutTestController.cpp:
1769         (closeWebInspectorCallback):
1770         (LayoutTestController::staticFunctions):
1771         * DumpRenderTree/LayoutTestController.h:
1772         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1773         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1774         * DumpRenderTree/chromium/LayoutTestController.cpp:
1775         (LayoutTestController::LayoutTestController):
1776         * DumpRenderTree/chromium/LayoutTestController.h:
1777         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1778         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1779         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1780         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1781         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1782         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1783         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1784         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1785         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1786
1787 2011-06-20  Lukasz Slachciak  <l.slachciak@samsung.com>
1788
1789         Reviewed by Martin Robinson.
1790
1791         [GTK] General mechanism for adjusting WebKitWebSettings in GtkLauncher.
1792         https://bugs.webkit.org/show_bug.cgi?id=55308
1793
1794         * GtkLauncher/main.c: Added general mechanism for adjusting WebKitWebSettings.
1795         (parseOptionEntryCallback): Callback for parsing option entry.
1796         (getOptionEntriesFromWebKitWebSettings): Basing on the WebKitWebSettings properties prepare
1797         list of option entries.
1798         (transformStringToBoolean): Transform function for boolean convertion used by parseOptionEntryCallback.
1799         (transformStringToInt): Transform function for int convertion used by parseOptionEntryCallback.
1800         (transformStringToFloat): Transform function for float convertion used by parseOptionEntryCallback.
1801         (parseAdditionalOptions): Help function parsing additional commandline options.
1802         (main): Added call to parseAdditionalOptions.
1803
1804 2011-06-20  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1805
1806         Reviewed by Andreas Kling.
1807
1808         [Qt] [WK2] Compile error in ActivateFontsQt.cpp on Mac
1809         https://bugs.webkit.org/show_bug.cgi?id=62869
1810
1811         Add QFont include to fix "incomlete type QFont" error.
1812
1813         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1814
1815 2011-06-19  Adam Bergkvist  <adam.bergkvist@ericsson.com>
1816
1817         Reviewed by Martin Robinson.
1818
1819         [GTK] Enable Media Stream feature and make it default on
1820         https://bugs.webkit.org/show_bug.cgi?id=60394
1821
1822         * Scripts/build-webkit:
1823
1824 2011-06-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1825
1826         Unreviewed, rolling out r89198.
1827         http://trac.webkit.org/changeset/89198
1828         https://bugs.webkit.org/show_bug.cgi?id=62953
1829
1830         Chromium breakage on "Linux Tests" (Requested by senorblanco
1831         on #webkit).
1832
1833         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1834         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1835         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1836
1837 2011-06-18  Daniel Bates  <dbates@webkit.org>
1838
1839         Reviewed by Eric Seidel.
1840
1841         Git.push_local_commits_to_server() should use passed username and
1842         password when we don't have cached credentials
1843         https://bugs.webkit.org/show_bug.cgi?id=62941
1844
1845         Fixes a issue where Git.push_local_commits_to_server() would always look
1846         for cached credentials regardless of whether a username and password
1847         were passed as arguments. Instead, if given both a username and password
1848         then we shouldn't look for cached credentials (since we were explicitly given
1849         credentials).
1850
1851         * Scripts/webkitpy/common/checkout/scm/git.py:
1852         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Added unit tests.
1853
1854 2011-06-18  Daniel Bates  <dbates@rim.com>
1855
1856         Rubber-stamped by Eric Seidel.
1857
1858         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
1859         https://bugs.webkit.org/show_bug.cgi?id=62767
1860
1861         Part 3 of 3
1862
1863         Remove the command-line option --skip-build now that the master BuildBot has been restarted
1864         following <http://trac.webkit.org/changeset/89138>.
1865
1866         Instead, specify --no-build to get analogous functionality.
1867
1868         * Scripts/run-javascriptcore-tests:
1869
1870 2011-06-18  Dirk Pranke  <dpranke@chromium.org>
1871
1872         Reviewed by Tony Chang.
1873
1874         new-run-webkit-tests: fix test sorting
1875         https://bugs.webkit.org/show_bug.cgi?id=58691
1876
1877         This changes the sorting to use a "natural" sort order such that
1878         foo2.html sorts before foo13.html, and sorts the tests so
1879         that all the tests in a directory are run before any test in a
1880         subdirectory.
1881
1882         This change also adds a split() method to the filesystem since
1883         that is needed to cluster files into a directory otherwise.
1884
1885         * Scripts/webkitpy/common/system/filesystem.py:
1886         * Scripts/webkitpy/common/system/filesystem_mock.py:
1887         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1888         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
1889
1890 2011-06-18  Evan Martin  <evan@chromium.org>
1891
1892         Reviewed by Darin Adler.
1893
1894         Compiler warning in double->int conversion in TestNetscapePlugIn
1895         https://bugs.webkit.org/show_bug.cgi?id=51554
1896
1897         This code is providing a JS API for removing a property by numeric ID.
1898         We get it from JS as a double, and must convert it to an int before using it.
1899
1900         Test: LayoutTests/plugins/npruntime/remove-property.html
1901
1902         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
1903         (NPRuntimeRemoveProperty::TestObject::invoke):
1904
1905 2011-06-18  Patrick Gansterer  <paroga@webkit.org>
1906
1907         Reviewed by Eric Seidel.
1908
1909         Don't exit webkit-patch when running on Win32 python
1910         https://bugs.webkit.org/show_bug.cgi?id=55811
1911
1912         Most of the basic actions work in the meantime,
1913         so let people play with in on Win32 now.
1914
1915         * Scripts/webkit-patch:
1916
1917 2011-06-18  Alice Boxhall  <aboxhall@chromium.org>
1918
1919         Reviewed by Ojan Vafai.
1920
1921         Convert json_results_generator.py to output version 4 JSON.
1922         https://bugs.webkit.org/show_bug.cgi?id=60869
1923
1924         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1925         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1926         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1927
1928 2011-06-18  Berend-Jan Wever  <skylined@chromium.org>
1929
1930         Reviewed by Eric Seidel.
1931
1932         Some names with spaces are incorrectly reported as not containing spaces
1933         while running prepare-ChangeLog
1934         https://bugs.webkit.org/show_bug.cgi?id=55572
1935
1936         * Scripts/VCSUtils.pm: Updated CHANGE_LOG_NAME check for spaces to allow
1937           non-alphanumeric characters in names.
1938
1939 2011-06-18  Michael Saboff  <msaboff@apple.com>
1940
1941         Reviewed by Eric Seidel.
1942
1943         Enhancement: New Script to Format malloc_history output as tree
1944         https://bugs.webkit.org/show_bug.cgi?id=56378
1945
1946         New script to process malloc_history output to tree format.
1947
1948         * Scripts/malloc-tree: Added.
1949
1950 2011-06-17  Dmitry Lomov  <dslomov@google.com>
1951
1952         Reviewed by Daniel Bates.
1953
1954         https://bugs.webkit.org/show_bug.cgi?id=62918 
1955         Pass configuration to UnitTests step in master.cfg
1956
1957         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1958
1959 2011-06-17  Leandro Pereira  <leandro@profusion.mobi>
1960
1961         Reviewed by Eric Seidel.
1962
1963         [EFL] Add Evas-based ImageDiff implementation.
1964         https://bugs.webkit.org/show_bug.cgi?id=61942
1965
1966         Build system changes will be performed as soon as the complete
1967         DumpRenderTree implementation is upstreamed.
1968
1969         * DumpRenderTree/efl/ImageDiff.cpp: Added.
1970         (pixelFromImageData):
1971         (differenceImageFromDifferenceBuffer):
1972         (computeDistanceBetweenPixelComponents):
1973         (calculatePixelDifference):
1974         (calculateDifference):
1975         (getTemporaryFile):
1976         (printImage):
1977         (printImageDifferences):
1978         (resizeEcoreEvasIfNeeded):
1979         (readImageFromStdin):
1980         (parseCommandLineOptions):
1981         (shutdownEfl):
1982         (abortWithErrorMessage):
1983         (initEfl):
1984         (main):
1985
1986 2011-06-17  Tony Chang  <tony@chromium.org>
1987
1988         Reviewed by Dirk Pranke.
1989
1990         [chromium] force rebaseline-chromium-webkit-tests to use the chromium port
1991         https://bugs.webkit.org/show_bug.cgi?id=62907
1992
1993         This fixes a bug where the ImageDiff on the user's machine doesn't
1994         match the logic used on the Chromium buildbots.  This has the downside
1995         of requiring that the Chromium ImageDiff is built, but it turns out
1996         that even with --tolerance 0, the CG ImageDiff will allow small pixel
1997         differences through.
1998
1999         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2000
2001 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
2002
2003         [WinCairo] Unreviewed build correction.
2004
2005         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops:
2006         Update WinCairo property sheet to link against the Cairo DLL,
2007         now that we are using a more recent Cairo build. 
2008
2009 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
2010
2011         Reviewed by Brian Weinstein.
2012
2013         Create a simple example of using the COM-based C++ listeners.
2014         A new onclick event is attached (via C++) to the WebKit logo
2015         in the default test pattern displayed on startup.  Clicking on
2016         the logo causes a message box to be displayed.
2017         https://bugs.webkit.org/show_bug.cgi?id=61885
2018
2019         * WinLauncher/DOMDefaultImpl.h: Added.  Stub implementation of
2020           the WebScriptObject and DOMEventListener.
2021         * WinLauncher/WinLauncher.cpp:
2022         (SimpleEventListener::SimpleEventListener): Example implementation
2023           of a simple DOM event listener.
2024         (SimpleEventListener::handleEvent): 
2025         (WinLauncherWebHost::didFinishLoadForFrame): Added implementation
2026          to bind a C++ method to the 'onclick' event for the WebKit logo.
2027         (_tWinMain):
2028         * WinLauncher/WinLauncher.h:
2029         * WinLauncher/WinLauncher.vcproj: Add new DOMDefaultImpl.h file.
2030
2031 2011-06-17  Chang Shu  <cshu@webkit.org>
2032
2033         Reviewed by Andreas Kling.
2034
2035         [Qt] [WK2] Support undo/redo in MiniBrowser
2036         https://bugs.webkit.org/show_bug.cgi?id=62809
2037
2038         * MiniBrowser/qt/BrowserWindow.cpp:
2039         (BrowserWindow::BrowserWindow):
2040
2041 2011-06-17  Daniel Bates  <dbates@rim.com>
2042
2043         Rubber-stamped by Eric Seidel.
2044
2045         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
2046         https://bugs.webkit.org/show_bug.cgi?id=62767
2047
2048         Part 2 of 3
2049
2050         Update the BuildBot master.cfg to use the new --no-build run-javascriptcore-tests
2051         command line option instead of --skip-build.
2052
2053         We'll remove --skip-build from run-javascriptcore-test in a follow up patch once the
2054         master buildbot picks up the change.
2055
2056         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2057
2058 2011-06-17  Daniel Bates  <dbates@rim.com>
2059
2060         Rubber-stamped by Eric Seidel.
2061
2062         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
2063         https://bugs.webkit.org/show_bug.cgi?id=62767
2064
2065         Part 1 of 3
2066
2067         Towards renaming the option --skip-build to --no-build. Add --build/--no-build options to
2068         run-javascriptcore-tests. Also, add a remark about these options to the usage message
2069         printed by run-javascriptcore-tests.
2070
2071         We'll remove --skip-build in a follow up patch once the master buildbot picks up the changes.
2072
2073         * Scripts/run-javascriptcore-tests: Additionally, remove unnecessary initialization
2074           of $showHelp.
2075
2076 2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
2077
2078         Reviewed by Martin Robinson.
2079
2080         [GTK] Replace GdkRectangle by cairo_rectangle_int_t
2081         https://bugs.webkit.org/show_bug.cgi?id=60687
2082
2083         Replace GdkRectangle by cairo_rectangle_int_t.
2084
2085         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
2086         (createBitmapContextFromWebView):
2087         * DumpRenderTree/gtk/TextInputController.cpp: Ditto.
2088         (firstRectForCharacterRangeCallback):
2089
2090 2011-06-16  Dmitry Lomov  <dslomov@google.com>
2091
2092         Reviewed by David Levin.
2093
2094         https://bugs.webkit.org/show_bug.cgi?id=62603
2095         Run run-api-tests on bots in debug mode.
2096         Release mode is disabled due to https://bugs.webkit.org/show_bug.cgi?id=61812.
2097
2098         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2099
2100 2011-06-16  Leandro Pereira  <leandro@profusion.mobi>
2101
2102         Reviewed by Eric Seidel.
2103
2104         [EFL] DumpRenderTree: Add GCController, PixelDumpSupport and
2105         WorkQueueItem.
2106         They will be plugged into the build system once the EFL's DRT is
2107         fully upstreamed.
2108         https://bugs.webkit.org/show_bug.cgi?id=61958
2109
2110         * DumpRenderTree/efl: Added.
2111         * DumpRenderTree/efl/GCControllerEfl.cpp: Added.
2112         (GCController::collect):
2113         (GCController::collectOnAlternateThread):
2114         (GCController::getJSObjectCount):
2115         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp: Added.
2116         (createBitmapContextFromWebView):
2117         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Added.
2118         (LoadItem::invoke):
2119         (LoadHTMLStringItem::invoke):
2120         (ReloadItem::invoke):
2121         (ScriptItem::invoke):
2122         (BackForwardItem::invoke):
2123         * DumpRenderTree/efl/WorkQueueItemEfl.h: Added.
2124         (WorkQueueItem::~WorkQueueItem):
2125         (LoadItem::LoadItem):
2126         (LoadHTMLStringItem::LoadHTMLStringItem):
2127         (ScriptItem::ScriptItem):
2128         (LoadingScriptItem::LoadingScriptItem):
2129         (LoadingScriptItem::invoke):
2130         (NonLoadingScriptItem::NonLoadingScriptItem):
2131         (NonLoadingScriptItem::invoke):
2132         (BackForwardItem::BackForwardItem):
2133         (BackItem::BackItem):
2134         (ForwardItem::ForwardItem):
2135
2136 2011-06-16  Kevin Ollivier  <kevino@theolliviers.com>
2137
2138         [wx] Unreviewed build fix, make sure the waf build checks the webKitBranchBuild
2139         preference like the perl scripts do.
2140
2141         * waf/build/build_utils.py:
2142         * waf/build/settings.py:
2143
2144 2011-06-16  Tommy Widenflycht  <tommyw@google.com>
2145
2146         Reviewed by Tony Gentilcore.
2147
2148         MediaStream API: Runtime enabled features
2149         https://bugs.webkit.org/show_bug.cgi?id=62798
2150
2151         Add the WebRuntimeFeatures API for Media Streams and enable the feature by default in DumpRenderTree.
2152
2153         * DumpRenderTree/chromium/TestShell.cpp:
2154         (TestShell::TestShell):
2155
2156 2011-06-16  Torsten Kurbad  <gentoo@tk-webart.de>
2157
2158         Reviewed by Eric Seidel.
2159
2160         Add support for sys.platform == 'linux3' by relaxing
2161         conditional statements and/or extending lookup dicts.
2162         This way, Linux kernels >=3.0-rc1 get supported in the
2163         build process.
2164         https://bugs.webkit.org/show_bug.cgi?id=62730
2165
2166         * Scripts/webkitpy/common/system/executive.py:
2167         * Scripts/webkitpy/common/system/file_lock.py:
2168         * Scripts/webkitpy/common/system/path_unittest.py:
2169         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2170         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2171         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2172         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2173         * Scripts/webkitpy/layout_tests/port/factory.py:
2174         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2175         * Scripts/webkitpy/layout_tests/port/qt.py:
2176         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2177
2178 2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2179
2180         Unreviewed, rolling out r88796.
2181         http://trac.webkit.org/changeset/88796
2182         https://bugs.webkit.org/show_bug.cgi?id=62790
2183
2184         It made fast/dom/nodesFromRect-basic.html time out on Qt,
2185         64-bit, debug mode (Requested by Ossy on #webkit).
2186
2187         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2188         (LayoutTestController::nodesFromRect):
2189         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2190         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2191         (PlainTextController::plainText):
2192         * DumpRenderTree/qt/PlainTextControllerQt.h:
2193
2194 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2195
2196         Unreviewed, build fix.
2197
2198         Revert the patches in r88995 and r88999; the http servers don't
2199         seem to be shutting down reliably.
2200
2201         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2202         * Scripts/webkitpy/layout_tests/port/base.py:
2203         * Scripts/webkitpy/layout_tests/port/http_server.py:
2204         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2205         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
2206         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2207         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2208
2209 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2210
2211         Unreviewed, build fix.
2212
2213         Add some debugging messages to triage problems introduced in
2214         r88995.
2215
2216         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2217
2218 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2219
2220         Reviewed by Tony Chang.
2221
2222         nrwt: should clean up stale server processes from a previous run
2223         https://bugs.webkit.org/show_bug.cgi?id=62615
2224
2225         This change fixes cases where NRWT might start a server and then
2226         exit, leaving the server still running. Now NRWT should detect
2227         this case and clean up on the next run, without shutting down
2228         any processes it didn't start.
2229
2230         This change also fixes a bug in executive.kill_process on UNIX
2231         where zombies weren't being handled properly.
2232
2233         * Scripts/webkitpy/common/system/executive.py:
2234         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2235         * Scripts/webkitpy/layout_tests/port/base.py:
2236         * Scripts/webkitpy/layout_tests/port/http_server.py:
2237         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2238         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2239         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2240
2241 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2242
2243         Reviewed by Tony Chang.
2244
2245         nrwt: fix http, websocket server startup, shutdown
2246         https://bugs.webkit.org/show_bug.cgi?id=62180
2247
2248         This change refactors all of the server-related code to
2249         have consistent semantics. It pushes the start()/stop()
2250         logic into the base class and adds four much smaller routines
2251         for specialization:
2252         _prepare_config() - for optionally writing config files etc.
2253             to disk prior to starting the server
2254         _remove_stale_log_files()
2255         _spawn_process() - the actual launch of the subprocess
2256         _cleanup_after_stop() - and custom cleanup code
2257
2258         Prior to this change the three server implementations were
2259         fairly inconsistent, leading to lots of weirdness on the bots
2260         with servers being left around, etc.
2261
2262         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2263         * Scripts/webkitpy/layout_tests/port/http_server.py:
2264         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2265         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2266
2267 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2268
2269         Reviewed by Tony Chang.
2270
2271         webkitpy: clean up code prior to functional changes for server startup/shutdown
2272         https://bugs.webkit.org/show_bug.cgi?id=62256
2273
2274         This patch does a bunch of minor cleanup of the code, but there
2275         should be no functional changes except that all of the modules
2276         will now use the same exception type. Other changes include
2277         removing unused code paths and functions, pushing 'name' and
2278         'pid_file' into the base class of the server objects, and using
2279         the Filesystem object instead of the codecs, tempfile, and
2280         shutils modules.
2281
2282         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2283         * Scripts/webkitpy/layout_tests/port/http_server.py:
2284         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2285         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2286
2287 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2288
2289         Reviewed by Tony Chang.
2290
2291         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
2292         https://bugs.webkit.org/show_bug.cgi?id=62251
2293
2294         shut_down_http_server() was a total hack that was only used by
2295         new-run-webkit-httpd, so I've moved the code there and switched
2296         to using executive.kill_process() for the common case. The
2297         method itself will be removed in the patch on bug 59993.
2298
2299         * Scripts/new-run-webkit-httpd:
2300         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2301         * Scripts/webkitpy/layout_tests/port/http_server.py:
2302         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
2303         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2304
2305 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2306
2307         Unreviewed, build fix.
2308
2309         Fix test-webkitpy failure introduced in r88986.
2310
2311         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2312
2313 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
2314
2315         Reviewed by Eric Seidel.
2316
2317         NRWT: doesn't support webarchives, has stale skipping logic.
2318         https://bugs.webkit.org/show_bug.cgi?id=58293
2319
2320         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2321         * Scripts/webkitpy/layout_tests/port/base.py:
2322         * Scripts/webkitpy/layout_tests/port/webkit.py:
2323
2324 2011-06-15  Jeremy Orlow  <jorlow@webkit.org>
2325
2326         Change my email to @webkit.org
2327
2328         * Scripts/webkitpy/common/config/committers.py:
2329
2330 2011-06-15  Nikolas Zimmermann  <nzimmermann@rim.com>
2331
2332         Reviewed by David Hyatt.
2333
2334         CSS 2.1: Support replaced elements with relative intrinsic sizes
2335         https://bugs.webkit.org/show_bug.cgi?id=15849
2336
2337         CSS 2.1 failure: html4/replaced-intrinsic-ratio-001
2338         https://bugs.webkit.org/show_bug.cgi?id=53099
2339
2340         Recognize *.htm tests in the old & new DRT implementation, needed for the vanilla css2.1 html4 tests.
2341
2342         * Scripts/old-run-webkit-tests:
2343         * Scripts/webkitpy/layout_tests/port/test_files.py:
2344
2345 2011-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2346
2347         Reviewed by Martin Robinson.
2348
2349         [GTK] Add a statusbar to MiniBrowser
2350         https://bugs.webkit.org/show_bug.cgi?id=62634
2351
2352         It shows the url of the current hovered link.
2353
2354         * MiniBrowser/gtk/BrowserWindow.c:
2355         (browserWindowConstructed): Create the GtkSatusbar.
2356         (mouseDidMoveOverElement): Update statusbar text.
2357         (browserWindowUIClientInit): Add implementation for
2358         mouseDidMoveOverElement().
2359         * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
2360         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Added.
2361         (mouseDidMoveOverElement): Pass the url of the current hovered
2362         link to the UI process.
2363         (didCreatePage): Set the UI client adding an implementation for
2364         mouseDidMoveOverElement().
2365         (WKBundleInitialize):
2366         * MiniBrowser/gtk/main.c:
2367         (createWKContextWithInjectedBundle): Create a global context with
2368         the injected bundle.
2369         (loadURI): Use the global context.
2370         (main):
2371
2372 2011-06-14  Lucas Forschler  <lforschler@apple.com>
2373
2374         Reviewed by Stephanie Lewis.
2375
2376         https://bugs.webkit.org/show_bug.cgi?id=62495
2377         Bug 62495 - combine windows and mac kill-old-processes script
2378         Add a platform agnostic script.  Remove the recently added mac flavor.
2379         Note: Leaving the windows one alone, since it is currently used by the WebKit bots.
2380         
2381         * BuildSlaveSupport/kill-old-processes: Added.
2382         * BuildSlaveSupport/mac: Removed.
2383         * BuildSlaveSupport/mac/kill-old-processes: Removed.
2384
2385 2011-06-14  Dirk Pranke  <dpranke@chromium.org>
2386
2387         Reviewed by Tony Chang.
2388
2389         nrwt: handle worker exceptions cleanly
2390         https://bugs.webkit.org/show_bug.cgi?id=62614
2391
2392         This change modifiers new-run-webkit-tests to handle exceptions
2393         raised by worker threads better, by:
2394         - capturing the worker's stack and logging it in the manager
2395         - propagating the worker's exception in the caller correctly
2396         - attempting to cancel the workers and clean up even when
2397           we get an unexpected exception
2398
2399         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2400         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2401         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2402         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2403
2404 2011-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
2405
2406         Reviewed by Laszlo Gombos.
2407
2408         [Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
2409         https://bugs.webkit.org/show_bug.cgi?id=62227
2410
2411         QtWebkit does not yet support different CacheModels. This change will 
2412         expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.
2413
2414         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2415         (LayoutTestController::setCacheModel):
2416         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2417
2418 2011-06-14  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2419
2420         Reviewed by Andreas Kling.
2421
2422         [Qt] tst_QWebFrame::overloadedSlots() fails
2423         https://bugs.webkit.org/show_bug.cgi?id=37319
2424
2425         Since we don't implictly convert 'document' object to QWebElement
2426         in metacalls anymore, change the controller to expect QVariantMap instead.
2427
2428         The method plainText() was updated to use QVariantMap as well to let the bridge
2429         do the conversion directly for us.
2430
2431         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2432         (LayoutTestController::nodesFromRect):
2433         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2434         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2435         (PlainTextController::plainText):
2436         * DumpRenderTree/qt/PlainTextControllerQt.h:
2437
2438 2011-06-14  Andras Becsi  <abecsi@webkit.org>
2439
2440         Reviewed by Csaba Osztrogonác.
2441
2442         Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
2443         https://bugs.webkit.org/show_bug.cgi?id=62630
2444
2445         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2446         (NPP_New): remove dead variable 'forceCarbon'
2447
2448 2011-06-13  Hayato Ito  <hayato@chromium.org>
2449
2450         Reviewed by Ojan Vafai.
2451
2452         [NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
2453         https://bugs.webkit.org/show_bug.cgi?id=59188
2454
2455         A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
2456         WebKitDriver should always return an actual hash value if DRT returns that.
2457
2458         No tests since I'll add sample reftests to make sure mismatch reftests work later,
2459         which should be in a separate patch.
2460
2461         * Scripts/webkitpy/layout_tests/port/webkit.py:
2462
2463 2011-06-13  Kent Tamura  <tkent@chromium.org>
2464
2465         [Chromium-win] Fix two wrong assertions exposed by r88757.
2466
2467         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2468         (WebThemeEngineDRTWin::paintTrackbar):
2469
2470 2011-06-13  Alexey Proskuryakov  <ap@apple.com>
2471
2472         Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
2473         and commit queue happy.
2474
2475         * Scripts/webkitpy/common/config/committers.py:
2476
2477 2011-06-13  Chris Rogers  <crogers@google.com>
2478
2479         Unreviewed build fix.
2480
2481         Build fix to chromium DRT until we can rebaseline some tests
2482         https://bugs.webkit.org/show_bug.cgi?id=62608
2483
2484         * DumpRenderTree/chromium/TestShell.cpp:
2485         (TestShell::TestShell):
2486
2487 2011-06-13  Chris Rogers  <crogers@google.com>
2488
2489         Reviewed by Dirk Pranke.
2490
2491         Add Web Audio support to chromium DRT
2492         https://bugs.webkit.org/show_bug.cgi?id=62306
2493
2494         * DumpRenderTree/chromium/LayoutTestController.cpp:
2495         (LayoutTestController::LayoutTestController):
2496         (LayoutTestController::reset):
2497         (LayoutTestController::setEncodedAudioData):
2498         * DumpRenderTree/chromium/LayoutTestController.h:
2499         (LayoutTestController::encodedAudioData):
2500         (LayoutTestController::shouldDumpAsAudio):
2501         (LayoutTestController::setShouldDumpAsAudio):
2502         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2503         (DRTPrinter::handleAudioHeader):
2504         (TestShellPrinter::handleAudioHeader):
2505         * DumpRenderTree/chromium/TestEventPrinter.h:
2506         * DumpRenderTree/chromium/TestShell.cpp:
2507         (TestShell::TestShell):
2508         (TestShell::dump):
2509
2510 2011-06-13  Jaehun Lim  <ljaehun.lim@samsung.com>
2511
2512         Reviewed by Eric Seidel.
2513
2514         [EFL] Add load error handler to EWebLauncher
2515         https://bugs.webkit.org/show_bug.cgi?id=62347
2516
2517         Add a handler function of "load,error" to EWebLauncher.
2518         EWebLauncher now displays a simple error page on load errors.
2519
2520         * EWebLauncher/main.c:
2521         (on_load_error):
2522         (browserCreate):
2523
2524 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
2525
2526         Reviewed by Eric Seidel.
2527
2528         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
2529         https://bugs.webkit.org/show_bug.cgi?id=62385
2530
2531         Remove duplicate TestNetscapePlugIn implementation. Having two copies
2532         of this code makes keeping it in sync much more difficult. The files are
2533         almost identical and this change ports the X11 changes to main.cpp.
2534
2535         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2536         (NPP_New): Do not set the plugin as windowless always. Doing this breaks
2537         some results on Qt and this seems to be unnecessary for the moment.
2538         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
2539         (handleEventX11): Use the handler to properly convert the keycode. Do not print
2540         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
2541         it should not be in the results.
2542         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
2543         XP_UNIX block is first by guarding against using a null instance.
2544         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
2545         the XP_UNIX define for Linux.
2546         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
2547         * GNUmakefile.am: Update source list.
2548
2549 2011-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2550
2551         Unreviewed, rolling out r88671.
2552         http://trac.webkit.org/changeset/88671
2553         https://bugs.webkit.org/show_bug.cgi?id=62591
2554
2555         "didn't work" (Requested by dpranke on #webkit).
2556
2557         * Scripts/new-run-webkit-httpd:
2558         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2559         * Scripts/webkitpy/layout_tests/port/http_server.py:
2560         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2561         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
2562         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2563         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2564
2565 2011-06-13  Nate Chapin  <japhet@chromium.org>
2566
2567         Reviewed by Darin Fisher.
2568
2569         New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
2570
2571         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2572
2573 2011-06-13  Dirk Pranke  <dpranke@chromium.org>
2574
2575         Reviewed by Tony Chang.
2576
2577         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
2578         https://bugs.webkit.org/show_bug.cgi?id=62251
2579
2580         shut_down_http_server() was a total hack that was only used by
2581         new-run-webkit-httpd, so I've moved the code there and switched
2582         to using executive.kill_process() for the common case. The
2583         method itself will be removed in the patch on bug 59993.
2584
2585         * Scripts/new-run-webkit-httpd:
2586         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2587         * Scripts/webkitpy/layout_tests/port/http_server.py:
2588         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
2589         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2590
2591 2011-06-13  Tony Chang  <tony@chromium.org>
2592
2593         Reviewed by Dimitri Glazkov.
2594
2595         rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
2596         https://bugs.webkit.org/show_bug.cgi?id=62578
2597
2598         * Scripts/build-webkit:
2599
2600 2011-06-13  Tony Chang  <tony@chromium.org>
2601
2602         Reviewed by Adam Barth.
2603
2604         rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
2605         https://bugs.webkit.org/show_bug.cgi?id=62545
2606
2607         * Scripts/build-webkit:
2608
2609 2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2610
2611         Reviewed by Martin Robinson.
2612
2613         [GTK] Export an API similar to WebKit1
2614         https://bugs.webkit.org/show_bug.cgi?id=57820
2615
2616         Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
2617         code, but linking to libwebkit2gtk.
2618
2619         * GNUmakefile.am:
2620         * GtkLauncher/main.c:
2621         (createBrowser):
2622         (main):
2623
2624 2011-06-12  MORITA Hajime  <morrita@google.com>
2625
2626         Unreviewed, rolling out r88625.
2627         http://trac.webkit.org/changeset/88625
2628         https://bugs.webkit.org/show_bug.cgi?id=61073
2629
2630         Breaks SL Webkit2 Tests
2631
2632         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
2633         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2634         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
2635         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2636         (WTR::InjectedBundlePage::didClearWindowForFrame):
2637         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2638
2639 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2640
2641         Reviewed by Antonio Gomes.
2642
2643         [Qt] LayoutTestController needs setTextDirection implementation
2644         https://bugs.webkit.org/show_bug.cgi?id=62442
2645
2646         Implements LayoutController.setTextDirection.
2647
2648         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2649         (LayoutTestController::setTextDirection):
2650         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2651
2652 2011-06-12  Dominic Cooney  <dominicc@chromium.org>
2653
2654         Reviewed by Hajime Morita.
2655
2656         Add window.internals to WebKit2's WebKitTestRunner.
2657         https://bugs.webkit.org/show_bug.cgi?id=61073
2658
2659         Test: fast/harness/internals-object.html
2660
2661         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
2662         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2663         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
2664         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2665         (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
2666         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2667
2668 2011-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2669
2670         Unreviewed, rolling out r88616.
2671         http://trac.webkit.org/changeset/88616
2672         https://bugs.webkit.org/show_bug.cgi?id=62517
2673
2674         It broke editing/text-iterator/findString.html (Requested by
2675         tonikitoo on #webkit).
2676
2677         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2678         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2679
2680 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2681
2682         Reviewed by Antonio Gomes.
2683
2684         [Qt] LayoutTestController needs setTextDirection implementation
2685         https://bugs.webkit.org/show_bug.cgi?id=62442
2686
2687         Implements LayoutController.setTextDirection.
2688
2689         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2690         (LayoutTestController::setTextDirection):
2691         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2692
2693 2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>
2694
2695         Reviewed by Ojan Vafai.
2696
2697         new-run-webkit-tests: 'images' links on results.html don't work
2698         https://bugs.webkit.org/show_bug.cgi?id=62194
2699
2700         Use relative path when generating images-diffs.html
2701
2702         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2703         Added _output_testname.
2704
2705 2011-06-10  Lucas Forschler  <lforschler@apple.com>
2706
2707         Reviewed by Stephanie Lewis.
2708
2709         Script to kill old processes on Mac.
2710         This matches the windows version.
2711         https://bugs.webkit.org/show_bug.cgi?id=62479  
2712         
2713         * BuildSlaveSupport/mac: Added.
2714         * BuildSlaveSupport/mac/kill-old-processes: Added.
2715
2716 2011-06-10  Adam Barth  <abarth@webkit.org>
2717
2718         Reviewed by James Robinson.
2719
2720         When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
2721         https://bugs.webkit.org/show_bug.cgi?id=62489
2722
2723         * Scripts/webkitpy/tool/bot/sheriff.py:
2724         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2725
2726 2011-06-10  Tony Chang  <tony@chromium.org>
2727
2728         Reviewed by Ojan Vafai.
2729
2730         add a compile guard ENABLE(FLEXBOX)
2731         https://bugs.webkit.org/show_bug.cgi?id=62049
2732
2733         * Scripts/build-webkit:
2734
2735 2011-06-10  Mark Rowe  <mrowe@apple.com>
2736
2737         Reviewed by Dimitri Glazkov.
2738
2739         <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
2740
2741         Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
2742         header file.
2743
2744         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2745         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2746
2747 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
2748
2749         Unreviewed rolling out r88471, because it broke plugin tests on Qt.
2750
2751         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2752         (handleEventX11):
2753         (NPP_GetValue):
2754         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2755         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
2756         (webkit_test_plugin_new_instance):
2757         (webkit_test_plugin_destroy_instance):
2758         (webkit_test_plugin_set_window):
2759         (executeScript):
2760         (webkit_test_plugin_new_stream):
2761         (webkit_test_plugin_destroy_stream):
2762         (webkit_test_plugin_stream_as_file):
2763         (webkit_test_plugin_write_ready):
2764         (webkit_test_plugin_write):
2765         (webkit_test_plugin_print):
2766         (keyEventToChar):
2767         (webkit_test_plugin_handle_event):
2768         (webkit_test_plugin_url_notify):
2769         (webkit_test_plugin_get_value):
2770         (webkit_test_plugin_set_value):
2771         (NP_GetMIMEDescription):
2772         (NP_Initialize):
2773         (NP_Shutdown):
2774         (NP_GetValue):
2775         * GNUmakefile.am:
2776
2777 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
2778
2779         Reviewed by Eric Seidel.
2780
2781         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
2782         https://bugs.webkit.org/show_bug.cgi?id=55603
2783
2784         Add callbacks to support hasMarkedText and markedRange and also clean up existing 
2785         TextInputController support.
2786
2787         * DumpRenderTree/gtk/TextInputController.cpp:
2788         (setMarkedTextCallback): Accept parameters in terms of start and length, instead
2789         of start and end. This matches the other ports. Do not use GLib style early returns.
2790         (hasMarkedTextCallback): Added.
2791         (markedRangeCallback): Added.
2792         (insertTextCallback): Cleanup as described above.
2793         (unmarkTextCallback): Cleanup as described above.
2794         (firstRectForCharacterRangeCallback): Cleanup as described above.
2795         (selectedRangeCallback): Cleanup as described above.
2796
2797 2011-06-09  Dirk Pranke  <dpranke@chromium.org>
2798
2799         Reviewed by Tony Chang.
2800
2801         nrwt: support webaudio in chromium driver
2802         https://bugs.webkit.org/show_bug.cgi?id=62226
2803
2804         * Scripts/webkitpy/layout_tests/port/chromium.py:
2805
2806 2011-06-09  Dan Bernstein  <mitz@apple.com>
2807
2808         Reviewed by Anders Carlsson.
2809
2810         Added a test for Vector::reverse()
2811         https://bugs.webkit.org/show_bug.cgi?id=62393
2812
2813         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2814         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
2815         (TestWebKitAPI::TEST):
2816         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2817
2818 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
2819
2820         Reviewed by Andreas Kling.
2821
2822         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
2823         https://bugs.webkit.org/show_bug.cgi?id=62385
2824
2825         Remove duplicate TestNetscapePlugIn implementation. Having two copies
2826         of this code makes keeping it in sync much more difficult. The files are
2827         almost identical and this change ports the X11 changes to main.cpp.
2828
2829         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2830         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
2831         (handleEventX11): Use the handler to properly convert the keycode. Do not print
2832         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
2833         it should not be in the results.
2834         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
2835         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
2836         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
2837         * GNUmakefile.am: Update source list.
2838
2839 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
2840
2841         Reviewed by Tony Chang.
2842
2843         Test plugin should support event logging on the windows port.
2844         https://bugs.webkit.org/show_bug.cgi?id=61721
2845
2846         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
2847         calls to mean the plugin handled the event.
2848
2849         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2850         (handleEventWin): Return 0 for each event on windows.
2851
2852 2011-06-09  Chang Shu  <cshu@webkit.org>
2853
2854         Reviewed by Andreas Kling.
2855
2856         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
2857         https://bugs.webkit.org/show_bug.cgi?id=62381
2858
2859         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
2860         QWKPagePrivate::isViewFocused() will check it later.
2861
2862         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2863         (WTR::PlatformWebView::PlatformWebView):
2864
2865 2011-06-09  Robert Hogan  <robert@webkit.org>
2866
2867         Reviewed by Andreas Kling.
2868
2869         Teach Qt about window.internals
2870         https://bugs.webkit.org/show_bug.cgi?id=61074
2871
2872         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2873         (WebCore::DumpRenderTree::initJSObjects):
2874
2875 2011-06-09  Eric Seidel  <eric@webkit.org>
2876
2877         Reviewed by Adam Barth.
2878
2879         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
2880         https://bugs.webkit.org/show_bug.cgi?id=62362
2881
2882         The mac bots are failing inspector tests.  We don't know why yet.
2883         So for now, turning run-webkit-tests off for the mac-ews.
2884
2885         Also noticed that due to the wrong variable name the cr-linux
2886         bots weren't running tests!
2887
2888         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2889
2890 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
2891
2892         Reviewed by Csaba Osztrogonac.
2893
2894         [Qt][WK2] Canvas tests make css2.1 ones failing
2895         https://bugs.webkit.org/show_bug.cgi?id=53427
2896
2897         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
2898         Since the Qt port should eventually go to QRawFont, this issue will be resolved
2899         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
2900         needed for the workaround.
2901
2902         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2903         (WTR::LayoutTestController::platformInitialize):
2904
2905 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
2906
2907         Reviewed by Chris Fleizach.
2908
2909         [GTK] Provide a way in DRT to check the platform name
2910         https://bugs.webkit.org/show_bug.cgi?id=56855
2911
2912         Patch for adding 'platformName' static property to DRT's
2913         LayoutController and provide platform specific implementations.
2914
2915         In principle, this feature will be only of interest for writing
2916         accessibility tests, so that's why it's only implemented in the
2917         Mac, Gtk and Win platforms.
2918
2919         * DumpRenderTree/LayoutTestController.h: New method platformName().
2920         * DumpRenderTree/LayoutTestController.cpp:
2921         (getPlatformNameCallback): New callback for 'platformName'.
2922         (LayoutTestController::staticValues): New static property.
2923
2924         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2925         (LayoutTestController::platformName): Implemented.
2926
2927         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2928         (LayoutTestController::platformName): Implemented.
2929
2930         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2931         (LayoutTestController::platformName): Implemented.
2932
2933 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
2934
2935         Reviewed by James Robinson.
2936
2937         Add mikelawther to committers.py
2938         https://bugs.webkit.org/show_bug.cgi?id=62354
2939
2940         * Scripts/webkitpy/common/config/committers.py:
2941
2942 2011-06-08  Kent Tamura  <tkent@chromium.org>
2943
2944         [Chromium] Fix a typo.
2945
2946         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
2947         (WebThemeControlDRTWin::draw):
2948
2949 2011-06-08  Kent Tamura  <tkent@chromium.org>
2950
2951         Reviewed by Hajime Morita.
2952
2953         [Chromium] Support vertical sliders in Windows DRT
2954         https://bugs.webkit.org/show_bug.cgi?id=62352
2955
2956         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
2957         (WebThemeControlDRTWin::draw):
2958           Paint VerticalSliderThumbType and VerticalSliderTrackType.
2959         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
2960           Add VerticalSliderTrackType and VerticalSliderThumbType.
2961         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2962         (WebThemeEngineDRTWin::paintTrackbar):
2963           Convert Windows identifiers to the internal identifiers for vertical sliders.
2964
2965 2011-06-08  Ojan Vafai  <ojan@chromium.org>
2966
2967         Reviewed by Tony Chang.
2968
2969         add a short-flag for --experimental-fully-parallel
2970         https://bugs.webkit.org/show_bug.cgi?id=62321
2971
2972         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2973
2974 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
2975
2976         Reviewed by Tony Chang.
2977
2978         new-run-webkit-tests: don't turn the tree red when there are new passes
2979         https://bugs.webkit.org/show_bug.cgi?id=62311
2980
2981         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
2982         to match commandComplete.
2983
2984         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2985
2986 2011-06-08  Tom Hudson  <tomhudson@google.com>
2987
2988         Reviewed by Mihai Parparita.
2989
2990         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
2991         https://bugs.webkit.org/show_bug.cgi?id=60964
2992
2993         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2994         Add 'Sort tests by metric' link.
2995         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2996         (disableSorting): Activate 'Sort tests by metric' link.
2997         (enableSorting): Deactivate 'Sort tests by metric' link.
2998         (selectDirectory): Call enableSorting()/disableSorting() depending
2999         on currently selected failure type, and sort tests if requested.
3000         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3001         New .disabled-control class for deactivated links.
3002
3003 2011-06-08  Tom Sepez  <tsepez@chromium.org>
3004
3005         Reviewed by Adam Barth.
3006
3007         Add web permissions callbacks for mixed content blocking.
3008         https://bugs.webkit.org/show_bug.cgi?id=61946
3009
3010         * DumpRenderTree/chromium/LayoutTestController.cpp:
3011         (LayoutTestController::setAllowDisplayOfInsecureContent):
3012         (LayoutTestController::setAllowRunningOfInsecureContent):
3013         (LayoutTestController::overridePreference):
3014         * DumpRenderTree/chromium/WebPermissions.cpp:
3015         (WebPermissions::allowDisplayingInsecureContent):
3016         (WebPermissions::allowRunningInsecureContent):
3017         (WebPermissions::setDisplayingInsecureContentAllowed):
3018         (WebPermissions::setRunningInsecureContentAllowed):
3019         (WebPermissions::reset):
3020         * DumpRenderTree/chromium/WebPermissions.h:
3021
3022 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
3023
3024         Reviewed by Tony Chang.
3025
3026         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
3027         https://bugs.webkit.org/show_bug.cgi?id=62259
3028
3029         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3030
3031 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3032
3033         Reviewed by Tony Chang.
3034
3035         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
3036         https://bugs.webkit.org/show_bug.cgi?id=62303
3037
3038         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
3039
3040         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3041
3042 2011-06-08  Greg Simon  <gregsimon@chromium.org>
3043
3044         Reviewed by Dimitri Glazkov.
3045
3046         Control Indexeddb backends from LayoutTestController
3047         https://bugs.webkit.org/show_bug.cgi?id=61000
3048
3049         * DumpRenderTree/chromium/LayoutTestController.cpp:
3050         (LayoutTestController::LayoutTestController):
3051         (LayoutTestController::setOverrideIndexedDBBackingStore):
3052         (LayoutTestController::clearAllDatabases):
3053         * DumpRenderTree/chromium/LayoutTestController.h:
3054
3055 2011-06-08  Andreas Kling  <kling@webkit.org>
3056
3057         Add Pierre Rossi to contributors list for EZ-CC.
3058
3059         * Scripts/webkitpy/common/config/committers.py:
3060
3061 2011-06-08  Ilya Sherman  <isherman@chromium.org>
3062
3063         Reviewed by Andreas Kling.
3064
3065         Add Ilya Sherman to list of committers
3066         https://bugs.webkit.org/show_bug.cgi?id=62270
3067
3068         * Scripts/webkitpy/common/config/committers.py:
3069
3070 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
3071
3072         Reviewed by Tony Chang.
3073
3074         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
3075         https://bugs.webkit.org/show_bug.cgi?id=62178
3076
3077         Added commandComplete and evaluateCommand for NewRunWebKitTests class
3078         to parse new-run-webkit-tests' results.
3079
3080         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3081
3082 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
3083
3084         Reviewed by Eric Seidel.
3085
3086         webkitpy: add a popen() call to executive
3087         https://bugs.webkit.org/show_bug.cgi?id=62179
3088
3089         This change adds a popen() wrapper call to the Executive object.
3090         This will allow other webkitpy scripts that currently call
3091         subprocess directly to use Executive, instead.
3092
3093         No additional tests are necessary (the existing tests cover the code).
3094
3095         * Scripts/webkitpy/common/system/executive.py:
3096
3097 2011-06-07  Sam Weinig  <sam@webkit.org>
3098
3099         Reviewed by Anders Carlsson.
3100
3101         Remove repeated IPC traffic from SetRenderTreeSize message
3102         https://bugs.webkit.org/show_bug.cgi?id=62244
3103
3104         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3105         (WTR::InjectedBundlePage::InjectedBundlePage):
3106         Add stub for didLayoutForFrame.
3107
3108 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
3109
3110         Reviewed by Tony Chang.
3111
3112         rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
3113         https://bugs.webkit.org/show_bug.cgi?id=62241
3114
3115         * Scripts/webkitpy/layout_tests/port/chromium.py:
3116
3117 2011-06-07  Adam Barth  <abarth@webkit.org>
3118
3119         Rubber-stamped by Eric Seidel.
3120
3121         Enable tests on the mac-ews
3122
3123         When we bring the mac-ews back up, we're going to try running tests!
3124
3125         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3126
3127 2011-06-07  Dmitry Lomov  <dslomov@google.com>
3128
3129         Reviewed by David Levin.
3130
3131         https://bugs.webkit.org/show_bug.cgi?id=62215
3132         Allow comparisons with 0 in LIKELY and UNLIKELY macros.
3133
3134         * Scripts/webkitpy/style/checkers/cpp.py:
3135         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3136
3137 2011-06-07  Nico Weber  <thakis@chromium.org>
3138
3139         Reviewed by Dimitri Glazkov.
3140
3141         [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
3142         https://bugs.webkit.org/show_bug.cgi?id=62210
3143
3144         The change to TestEventPrinter fixes a latent bug, because
3145         objects are deleted through the TestEventPrinter type, but none
3146         of the subclasses have destructors or non-POD members.
3147
3148         The changes to NotificationPresenter and WebViewHost do _not_ to fix a
3149         real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
3150         discussed at http://codereview.chromium.org/7094005/, we prefer making
3151         leaf class destructors virtual over making the leaf classes final.
3152
3153         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3154         (NotificationPresenter::~NotificationPresenter):
3155         * DumpRenderTree/chromium/NotificationPresenter.h:
3156         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3157         (TestEventPrinter::~TestEventPrinter):
3158         * DumpRenderTree/chromium/TestEventPrinter.h:
3159         * DumpRenderTree/chromium/WebViewHost.h:
3160
3161 2011-06-06  Ryosuke Niwa  <rniwa@webkit.org>
3162
3163         Reviewed by Dirk Pranke.
3164
3165         [chromium] Chromium bots on build.webkit.org don't upload results.html
3166         https://bugs.webkit.org/show_bug.cgi?id=61961
3167
3168         Don't fix the path on chromium port erroneously.
3169
3170         * BuildSlaveSupport/test-result-archive:
3171
3172 2011-06-06  Martin Robinson  <mrobinson@igalia.com>
3173
3174         Fix the GTK+ build by ensuring that the autogenerated sources
3175         necessary for libWebCoreInternals are recorded in a predeclared
3176         variable before assigning to BUILT_SOURCES.
3177
3178         * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
3179
3180 2011-06-06  Yong Li  <yoli@rim.com>
3181
3182         Reviewed by Eric Seidel.
3183
3184         https://bugs.webkit.org/show_bug.cgi?id=62097
3185         Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
3186
3187         * Scripts/webkitpy/style/checkers/cpp.py:
3188         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3189
3190 2011-06-06  Xan Lopez  <xlopez@igalia.com>
3191
3192         Reviewed by Martin Robinson.
3193
3194         [GTK] Enable feature/symbol detection in NWRT/GTK
3195         https://bugs.webkit.org/show_bug.cgi?id=62136
3196
3197         Disable feature detection through DRT, since we don't support it,
3198         and set the libwebcore patch correctly so that symbol detection
3199         through 'nm' works.
3200
3201         * Scripts/webkitpy/layout_tests/port/gtk.py:
3202
3203 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
3204
3205         Reviewed by Tony Gentilcore.
3206
3207         Add a "prerender" state for page visibility.
3208         https://bugs.webkit.org/show_bug.cgi?id=62062
3209
3210         * DumpRenderTree/chromium/LayoutTestController.cpp:
3211         (LayoutTestController::setPageVisibility):
3212
3213 2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
3214
3215         [Qt] Implement download feature for QtTestBrowser
3216         https://bugs.webkit.org/show_bug.cgi?id=61865
3217
3218         Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
3219
3220         * QtTestBrowser/launcherwindow.cpp:
3221         (LauncherWindow::LauncherWindow):
3222         * QtTestBrowser/launcherwindow.h:
3223
3224 2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
3225
3226         Reviewed by Csaba Osztrogonác.
3227
3228         [Qt] Implement download feature for QtTestBrowser
3229         https://bugs.webkit.org/show_bug.cgi?id=61865
3230
3231         * QtTestBrowser/launcherwindow.cpp:
3232         (LauncherWindow::LauncherWindow):
3233         (LauncherWindow::downloadRequest):
3234         (LauncherWindow::fileDownloadFinished):
3235         * QtTestBrowser/launcherwindow.h:
3236
3237 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
3238
3239         Reviewed by Dimitri Glazkov.
3240
3241         Make DumpRenderTree initialize window.internals.
3242         https://bugs.webkit.org/show_bug.cgi?id=61076
3243
3244         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
3245         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3246         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
3247
3248 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
3249
3250         Reviewed by Kent Tamura.
3251
3252         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
3253         https://bugs.webkit.org/show_bug.cgi?id=61628
3254
3255         * Scripts/build-webkit:
3256
3257 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
3258
3259         Reviewed by Kent Tamura.
3260
3261         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
3262         https://bugs.webkit.org/show_bug.cgi?id=61631
3263
3264         * Scripts/build-webkit:
3265
3266 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3267
3268         Unreviewed. Fix the GTK+ build.
3269
3270         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
3271
3272 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
3273
3274         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
3275         works properly).
3276
3277         * Scripts/webkitpy/common/config/committers.py:
3278
3279 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
3280
3281         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
3282         WebKit scripts expect, so other scripts work properly with wx.
3283
3284         * waf/build/build_utils.py:
3285         * waf/build/settings.py:
3286
3287 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
3288
3289         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
3290         to build on Mac.
3291
3292         * waf/build/settings.py:
3293         * wx/install-unix-extras:
3294
3295 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
3296
3297         [wx] Unreviewed build fixes for recent trunk changes.
3298
3299         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3300         (LayoutTestController::setTextDirection):
3301         * waf/build/settings.py:
3302
3303 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
3304
3305         Fix the GTK+ build.
3306
3307         * GNUmakefile.am: Add some missing newline escape.
3308
3309 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
3310
3311         Try to fix the GTK+ bulid.
3312
3313         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
3314         source list.
3315
3316 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
3317
3318         Reviewed by Adam Barth.
3319
3320         nrwt: should skip chromium test expectation overrides on upstream bots
3321         https://bugs.webkit.org/show_bug.cgi?id=61888
3322
3323         * Scripts/webkitpy/layout_tests/port/chromium.py:
3324         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3325
3326 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
3327
3328         Reviewed by Ojan Vafai.
3329
3330         new-run-webkit-tests: minor logging, code cleanup
3331         https://bugs.webkit.org/show_bug.cgi?id=62055
3332
3333         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3334         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3335
3336 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
3337
3338         Try to fix the build failure on the GTK+ 32-bit Release bot.
3339
3340         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
3341
3342 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
3343
3344         Reviewed by Ryosuke Niwa.
3345
3346         [GTK] Support smart replace for the pasteboard
3347         https://bugs.webkit.org/show_bug.cgi?id=61734
3348
3349         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
3350         This is required to produce consistent test results.
3351
3352         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3353         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
3354         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3355         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
3356         methods which calls into DumpRenderTreeSupportGtk.
3357
3358 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
3359
3360         Reviewed by Dimitri Glazkov.
3361
3362         Teach Gtk build about window.internals
3363         https://bugs.webkit.org/show_bug.cgi?id=61071
3364
3365         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3366         (webViewWindowObjectCleared): Inject the new internals object when the
3367         window object clears.
3368         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
3369         Also do a little bit of cleanup.
3370
3371 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
3372
3373         Reviewed by Tony Chang.
3374
3375         Worker may not be stopped after LT.
3376         https://bugs.webkit.org/show_bug.cgi?id=61847
3377
3378         Re-submit a variant of the first fix for this bug. It's possible
3379         that actually calling cleanup() in the worker threads was taking
3380         too long and we triggered the assertions in the manager thread.
3381
3382         I've bumped up the timeout in the manager and added better
3383         diagnostics. I also cleaned up the cleanup() code a bit because
3384         there was some unnecessary if-checks.
3385
3386         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3387         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3388
3389 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
3390
3391         Reviewed by Tony Chang.
3392
3393         nrwt: fix duplicate logging regression
3394         https://bugs.webkit.org/show_bug.cgi?id=61981
3395
3396         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3397
3398 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
3399
3400         Reviewed by Adam Barth.
3401
3402         Modified addTouchPoint to correctly re-use touchPoint id values starting
3403         from the lowest not-un-use touchPoint id as is done by the embedder
3404         APIs. (Fixes BUGCR36415)
3405
3406         https://bugs.webkit.org/show_bug.cgi?id=62016
3407
3408         * DumpRenderTree/chromium/EventSender.cpp:
3409         (EventSender::addTouchPoint):
3410
3411 2011-06-03  Cary Clark  <caryclark@google.com>
3412
3413         Reviewed by Eric Seidel.
3414
3415         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
3416         https://bugs.webkit.org/show_bug.cgi?id=61534
3417
3418         Skia on Mac uses Skia to render WebKit, and CG
3419         to render UI elements. The CG elements need a
3420         transcribed graphics context that preserves the
3421         canvas matrix, and the canvas clip.
3422
3423         The SkiaBitLocker utility class sets up a CGContext
3424         from the SkCanvas, locks the bitmap's bits, and
3425         releases the lock when the class goes out of scope.
3426
3427         The SkiaBitLocker implementation is described by
3428         this patch:
3429         http://codereview.chromium.org/7031006/
3430
3431         When WebKit uses Skia for rendering, the WebCanvas
3432         is an SkCanvas. Create an equivalent CGContext to
3433         draw the scrollbar thumb.
3434
3435         As the Chrome Mac port does not yet use Skia, this
3436         patch has no effect and requires no tests.
3437
3438         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3439         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3440
3441 2011-06-03  Andras Becsi  <abecsi@webkit.org>
3442
3443         Unreviewed build fix.
3444
3445         Fix typo.
3446
3447         * Scripts/old-run-webkit-tests:
3448
3449 2011-06-03  Andras Becsi  <abecsi@webkit.org>
3450
3451         Reviewed by Csaba Osztrogonác.
3452
3453         Print error message when there is no httpd present on the system
3454         https://bugs.webkit.org/show_bug.cgi?id=61939
3455
3456         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
3457         * Scripts/webkitperl/httpd.pm:
3458
3459 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
3460
3461         Reviewed by Yury Semikhatsky.
3462
3463         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
3464         https://bugs.webkit.org/show_bug.cgi?id=61533
3465
3466         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
3467
3468         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3469         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
3470         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3471         * DumpRenderTree/chromium/LayoutTestController.cpp:
3472         (LayoutTestController::LayoutTestController):
3473         (LayoutTestController::setJavaScriptProfilingEnabled):
3474         * DumpRenderTree/chromium/LayoutTestController.h:
3475         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3476         (LayoutTestController::setJavaScriptProfilingEnabled):
3477         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3478         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
3479         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3480
3481 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
3482
3483         Reviewed by Tony Chang.
3484
3485         NRWT needs a way to log to a file without including backspaces without needing --verbose
3486         https://bugs.webkit.org/show_bug.cgi?id=60328
3487
3488         This change modifies NRWT so that if it can tell if it is
3489         writing to a terminal, it will overwrite any messages printed
3490         in the 'one-line-progress' and 'updates' print options, and if
3491         not (or if --verbose was specified) the messages will be printed
3492         without backspaces.
3493
3494         If the overwriting updates are disabled, one-line-progress will
3495         only print every 10 seconds instead of on every update. This
3496         ensures that we still get updates once in a while while the
3497         tests are running, even if we're not in --verbose mode. Note
3498         that one-line-progress will now still be printed in --verbose,
3499         since it's useful as long as you're not flooded with the
3500         updates.
3501
3502         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
3503         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3504         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3505
3506 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
3507
3508         Reviewed by Gustavo Noronha Silva.
3509
3510         [GTK] autogen.sh is run twice for each buld on the bots
3511         https://bugs.webkit.org/show_bug.cgi?id=61951
3512
3513         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
3514         for the WebKit project. This prevents build-jsc runs from forcing subsequent
3515         build-webkit runs to re-rerun autogen.sh.
3516
3517 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3518
3519         Unreviewed, rolling out r87946.
3520         http://trac.webkit.org/changeset/87946
3521         https://bugs.webkit.org/show_bug.cgi?id=61965
3522
3523         Cause NRWT to break (Requested by abarth|gardener on #webkit).
3524
3525         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3526
3527 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
3528
3529         Reviewed by Darin Adler.
3530
3531         Add build logistics and plumbing for window.internals object.
3532         https://bugs.webkit.org/show_bug.cgi?id=60313
3533
3534         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
3535         * DumpRenderTree/chromium/TestShell.cpp:
3536         (TestShell::bindJSObjectsToWindow): Added injection code.
3537         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3538         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
3539
3540 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
3541
3542         Reviewed by Dirk Pranke.
3543
3544         Call cleanup() explicitly at the end of worker.run().
3545         https://bugs.webkit.org/show_bug.cgi?id=61847
3546
3547         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3548
3549 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
3550
3551         Unreviewed, rolling out r87926.
3552         http://trac.webkit.org/changeset/87926
3553         https://bugs.webkit.org/show_bug.cgi?id=60313
3554
3555         Fails to find WebCoreTestSupport.dylib on bots.
3556
3557         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3558         * DumpRenderTree/chromium/TestShell.cpp:
3559         (TestShell::bindJSObjectsToWindow):
3560         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3561         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
3562
3563 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
3564
3565         Reviewed by Darin Adler.
3566
3567         Add build logistics and plumbing for window.internals object.
3568         https://bugs.webkit.org/show_bug.cgi?id=60313
3569
3570         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
3571         * DumpRenderTree/chromium/TestShell.cpp:
3572         (TestShell::bindJSObjectsToWindow): Added injection code.
3573         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3574         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
3575
3576 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3577
3578         Reviewed by Eric Seidel.
3579
3580         Adjust efl coding style to more efl directories
3581         https://bugs.webkit.org/show_bug.cgi?id=61903
3582
3583         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
3584
3585 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
3586
3587         Reviewed by Tony Chang.
3588
3589         old-run-webkit-tests: add support for audio files
3590         https://bugs.webkit.org/show_bug.cgi?id=57992
3591
3592         * Scripts/old-run-webkit-tests:
3593
3594 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
3595
3596         Reviewed by Adam Barth.
3597
3598         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
3599         https://bugs.webkit.org/show_bug.cgi?id=34314
3600
3601         * DumpRenderTree/DumpRenderTree.gypi:
3602         * DumpRenderTree/chromium/LayoutTestController.cpp:
3603         (LayoutTestController::LayoutTestController):
3604         (LayoutTestController::setImagesAllowed):
3605         (LayoutTestController::setStorageAllowed):
3606         * DumpRenderTree/chromium/LayoutTestController.h:
3607         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
3608         (WebPermissions::WebPermissions):
3609         (WebPermissions::~WebPermissions):
3610         (WebPermissions::allowImages):
3611         (WebPermissions::allowStorage):
3612         (WebPermissions::setImagesAllowed):
3613         (WebPermissions::setStorageAllowed):
3614         (WebPermissions::reset):
3615         * DumpRenderTree/chromium/WebPermissions.h:
3616
3617 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
3618
3619         Reviewed by Tony Chang.
3620
3621         Test plugin should support event logging on the windows port.
3622         https://bugs.webkit.org/show_bug.cgi?id=61721
3623
3624         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3625         (handleEventWin): Well, handle them.
3626
3627 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
3628
3629         Reviewed by Tony Chang.
3630
3631         [chromium] Use correct file name for dragging out images.
3632         https://bugs.webkit.org/show_bug.cgi?id=24887
3633
3634         * DumpRenderTree/chromium/EventSender.cpp:
3635         (EventSender::EventSender):
3636         (EventSender::dumpFilenameBeingDragged):
3637         * DumpRenderTree/chromium/EventSender.h:
3638
3639 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
3640
3641         Reviewed by Tony Chang.
3642
3643         nrwt: make webaudio work w/o content-length header
3644         https://bugs.webkit.org/show_bug.cgi?id=61819
3645
3646         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3647         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3648         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3649         * Scripts/webkitpy/layout_tests/port/webkit.py:
3650
3651 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3652
3653         Reviewed by Andreas Kling.
3654
3655         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
3656         https://bugs.webkit.org/show_bug.cgi?id=61802
3657
3658         Add command line parameter and menu item to MiniBrowser application 
3659         enabling use of QGLWidget for browser viewport.
3660
3661         * MiniBrowser/qt/BrowserWindow.cpp:
3662         (BrowserWindow::BrowserWindow):
3663         (BrowserWindow::toggleGLViewport):
3664         * MiniBrowser/qt/BrowserWindow.h:
3665         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3666         (MiniBrowserApplication::handleUserOptions):
3667         * MiniBrowser/qt/MiniBrowserApplication.h:
3668         (WindowOptions::WindowOptions):
3669
3670 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
3671
3672         Reviewed by Xan Lopez.
3673
3674         Print out autogen arguments when they differ from the last set, to help
3675         with debugging build issues.
3676
3677         * Scripts/webkitdirs.pm: Print out previous and current build arguments
3678         when they differ.
3679
3680 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3681
3682         Reviewed by Martin Robinson.
3683
3684         [GTK] run-launcher should run MiniBrowser in WebKit2
3685         https://bugs.webkit.org/show_bug.cgi?id=61858
3686
3687         * Scripts/run-launcher: Check whether -2 command line option has
3688         been passed and run MiniBrowser instead of GtkLauncher.
3689
3690 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
3691
3692         Reviewed by Dirk Pranke.
3693
3694         Fix exception in verbose printing mode.
3695         https://bugs.webkit.org/show_bug.cgi?id=61723
3696
3697         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3698
3699 2011-05-31  Yong Li  <yoli@rim.com>
3700
3701         Reviewed by Eric Seidel.
3702
3703         https://bugs.webkit.org/show_bug.cgi?id=54807
3704         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
3705         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
3706         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
3707         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
3708         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
3709         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
3710         rule we should have in order to make our code independent from compilers and compiler flags.
3711
3712         * Scripts/webkitpy/style/checkers/cpp.py:
3713
3714 2011-05-31  Hironori Bono  <hbono@chromium.org>
3715
3716         Reviewed by Eric Seidel.
3717
3718         Add a JavaScript function layoutTestController.setTextDirection().
3719         https://bugs.webkit.org/show_bug.cgi?id=50952
3720
3721         This change adds a new JavaScript function setTextDirection() to the
3722         LayoutTestController class of Safari and Chrome to write layout tests
3723         that changes the text direction of an editable element.
3724
3725         * DumpRenderTree/LayoutTestController.cpp:
3726         (setTextDirectionCallback):
3727         (LayoutTestController::staticFunctions):
3728         * DumpRenderTree/LayoutTestController.h:
3729         * DumpRenderTree/chromium/LayoutTestController.cpp:
3730         (LayoutTestController::LayoutTestController):
3731         (LayoutTestController::setTextDirection):
3732         * DumpRenderTree/chromium/LayoutTestController.h:
3733         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3734         (LayoutTestController::setTextDirection):
3735         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3736         (LayoutTestController::setTextDirection):
3737         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3738         (LayoutTestController::setTextDirection):
3739
3740 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3741
3742         Reviewed by Simon Hausmann.
3743
3744         [Qt] User-agent list of Qt test browsers is very outdated
3745         https://bugs.webkit.org/show_bug.cgi?id=61531
3746
3747         The user can edit the user-agent manually, so there's no need to have
3748         a super complete and up to date list, but it's nice to have it
3749         minimally updated.
3750
3751         * MiniBrowser/qt/useragentlist.txt:
3752         * QtTestBrowser/useragentlist.txt:
3753
3754 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
3755
3756         Reviewed by Adam Roben.
3757
3758         [GTK] [WebKit2] Implement a basic WebKitTestRunner
3759         https://bugs.webkit.org/show_bug.cgi?id=57068
3760
3761         Add an implementation of WebKitTestRunner for GTK+.
3762
3763         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
3764         * Scripts/old-run-webkit-tests: Ditto.
3765         * Scripts/run-launcher: Ditto.
3766         * Scripts/webkitdirs.pm: Ditto.
3767         * WebKitTestRunner/GNUmakefile.am: Added.
3768         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3769         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
3770         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
3771         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
3772         * WebKitTestRunner/PlatformWebView.h:
3773         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
3774         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
3775         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
3776         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3777         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
3778         (main): Added.
3779
3780 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
3781
3782         Reviewed by Tony Chang.
3783
3784         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
3785         https://bugs.webkit.org/show_bug.cgi?id=60241
3786
3787         * Scripts/new-run-webkit-tests:
3788
3789 2011-05-31  Eric Seidel  <eric@webkit.org>
3790
3791         Reviewed by David Kilzer.
3792
3793         webkitpy should create zips with zip -9
3794         https://bugs.webkit.org/show_bug.cgi?id=61789
3795
3796         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
3797
3798         * Scripts/webkitpy/common/system/workspace.py:
3799         * Scripts/webkitpy/common/system/workspace_unittest.py:
3800
3801 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3802
3803         Reviewed by Csaba Osztrogonác.
3804
3805         [Qt] Implement find feature for QtTestBrowser
3806         https://bugs.webkit.org/show_bug.cgi?id=61425
3807
3808         Buildfix for --minimal and CONFIG+=qt_minimal build.
3809
3810         * QtTestBrowser/launcherwindow.cpp:
3811         (LauncherWindow::LauncherWindow):
3812         (LauncherWindow::createChrome):
3813         * QtTestBrowser/launcherwindow.h:
3814
3815 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
3816
3817         Reviewed by Csaba Osztrogonác.
3818
3819         [Qt] Implement find feature for QtTestBrowser
3820         https://bugs.webkit.org/show_bug.cgi?id=61425
3821
3822         * QtTestBrowser/launcherwindow.cpp:
3823         (LauncherWindow::LauncherWindow):
3824         (LauncherWindow::createChrome):
3825         (LauncherWindow::showFindBar):
3826         (LauncherWindow::find):
3827         * QtTestBrowser/launcherwindow.h:
3828
3829 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3830
3831         Reviewed by Martin Robinson.
3832
3833         [GTK] Implement JavaScript dialogs in MiniBrowser
3834         https://bugs.webkit.org/show_bug.cgi?id=61725
3835
3836         * MiniBrowser/gtk/BrowserWindow.c:
3837         (WKStringGetCString): Helper function to get a UTF-8 c string from
3838         a WKStringRef.
3839         (WKURLGetCString): Helper function to get a UTF-8 c string from a
3840         WKURLRef.
3841         (browserWindowUpdateURL): Update to use WKURLGetCString.
3842         (didReceiveTitleForFrame): Update to use WKStringGetCString.
3843         (createMessageDialog): Create a GtkMessageDialog.
3844         (runJavaScriptAlert):
3845         (runJavaScriptConfirm):
3846         (runJavaScriptPrompt):
3847         (browserWindowUIClientInit):
3848
3849 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
3850
3851         Reviewed by Kent Tamura.
3852
3853         WebSocket closing handshake
3854         https://bugs.webkit.org/show_bug.cgi?id=35721
3855
3856         * Scripts/webkitpy/thirdparty/__init__.py:
3857         Pull in pywebsocket 0.6b1. We need to update pywebsocket
3858         to get the right behavior of closing handshake.
3859
3860 2011-05-29  Daniel Bates  <dbates@rim.com>
3861
3862         Reviewed by David Kilzer.
3863
3864         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
3865         https://bugs.webkit.org/show_bug.cgi?id=61162
3866
3867         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
3868         that omits a line count. In particular, the chunk range regular expression does
3869         not match a chunk range line that omits a line count. GNU diff(1) will omit the
3870         line count in the chunk range if the line count is exactly 1. For example, appending
3871         a new line to the end of an existing file F that contains exactly one line of text will
3872         be represented in a diff with a chunk range line that omits the line count for F.
3873
3874         * Scripts/VCSUtils.pm:
3875           (parseChunkRange): Added.
3876         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
3877         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
3878           - Added unit test "Git: Append new line to the end of an existing file".
3879
3880 2011-05-28  Adam Barth  <abarth@webkit.org>
3881
3882         Reviewed by Eric Seidel.
3883
3884         EWS builds patches that fail to build twice, which seems useless and slows down the bots
3885         https://bugs.webkit.org/show_bug.cgi?id=55585
3886
3887         This patch switches all the early warning system bots over to the new
3888         PatchAnalysisTask-based infrastructure.  This patch makes these bots
3889         more efficient (in the case where patches fail to build) and paves the
3890         way for running tests on these bots!
3891
3892         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3893         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3894         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3895         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3896         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3897         * Scripts/webkitpy/tool/commands/queues.py:
3898
3899 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
3900
3901         Reviewed by Kent Tamura.
3902
3903         Add bashi as a committer.
3904
3905         https://bugs.webkit.org/show_bug.cgi?id=61685
3906
3907         * Scripts/webkitpy/common/config/committers.py:
3908
3909 2011-05-27  Adam Barth  <abarth@webkit.org>
3910
3911         Reviewed by Eric Seidel.
3912
3913         When checking whether the tree is red, the EWS posts a link to the wrong log
3914         https://bugs.webkit.org/show_bug.cgi?id=61072
3915
3916         We need to cache the original script error because that contains the
3917         failure log we want to upload.  If we don't cache that script error,
3918         self._script_error will get overwritten when we sanity check the clean
3919         tree (and it also has test failures).
3920
3921         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3922             - This testing approach is slightly goofy.  We'd like to use
3923               assertRaisesRegexp, but that's not available until Python 2.7.
3924         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3925
3926 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
3927
3928         Reviewed by Adam Barth.
3929
3930         Add layoutTestController.setStorageAllowed() to control whether access
3931         to the localStorage API is enabled via the WebPermissionClient
3932         https://bugs.webkit.org/show_bug.cgi?id=61581
3933
3934         * DumpRenderTree/chromium/LayoutTestController.cpp:
3935         (LayoutTestController::LayoutTestController):
3936         (LayoutTestController::setStorageAllowed):
3937         * DumpRenderTree/chromium/LayoutTestController.h:
3938         * DumpRenderTree/chromium/TestShell.cpp:
3939         (TestShell::TestShell):
3940         (TestShell::createNewWindow):
3941         * DumpRenderTree/chromium/TestShell.h:
3942         * DumpRenderTree/chromium/WebPermissions.h: Added.
3943         (WebPermissions::WebPermissions):
3944         (WebPermissions::allowStorage):
3945         (WebPermissions::setStorageAllowed):
3946         (WebPermissions::reset):
3947
3948 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
3949
3950         Reviewed by Eric Seidel.
3951
3952         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
3953         https://bugs.webkit.org/show_bug.cgi?id=60326
3954
3955         This patch removes a lot of the complexity from the
3956         metered_stream implementation that was unnecessary since there
3957         was only one caller and the logic could be coordinated better.
3958
3959         There should be no functional changes in this patch, just code
3960         getting deleted and cleaned up.
3961
3962         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
3963         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
3964         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3965         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3966
3967 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
3968
3969         Reviewed by Eric Seidel.
3970
3971         NRWT: minor cleanup in printing module
3972         https://bugs.webkit.org/show_bug.cgi?id=60329
3973
3974         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3975
3976 2011-05-27  Steve Lacey  <sjl@chromium.org>
3977
3978         Reviewed by David Levin.
3979
3980         Add sjl@chromium.org as a committer.
3981
3982         https://bugs.webkit.org/show_bug.cgi?id=61672
3983
3984         * Scripts/webkitpy/common/config/committers.py:
3985
3986 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
3987
3988         Reviewed by Adam Barth.
3989
3990         NRWT: remove --print detailed-progress
3991         https://bugs.webkit.org/show_bug.cgi?id=60324
3992
3993         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
3994         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3995         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3996         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3997
3998 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
3999
4000         Reviewed by Ojan Vafai.
4001
4002         NRWT: debug messages from the workers are being logged twice
4003         https://bugs.webkit.org/show_bug.cgi?id=60428
4004
4005         It looks like when the workers are run in separate processes
4006         we end up getting two copies of every log message they print.
4007         This has to do with the multiprocessing module on UNIX cloning
4008         the log configuration in a way I wasn't expecting, and so two
4009         log handlers end up getting registered.
4010
4011         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
4012         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
4013         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
4014         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4015
4016 2011-05-27  Adam Roben  <aroben@apple.com>
4017
4018         Always decode tester names from location.hash
4019
4020         When navigating directly to a tester-specific URL (e.g.,
4021         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
4022         with a URL-encoded tester name in the page, and then the encoded name could make its way
4023         into Bugzilla bugs. Bad!
4024
4025         Reviewed by David Kilzer.
4026
4027         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
4028         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
4029         decodeURIComponent before trying to use it.
4030
4031 2011-05-27  Adam Roben  <aroben@apple.com>
4032
4033         Remove testing code that snuck into r87528
4034
4035         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
4036         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
4037
4038 2011-05-27  Adam Roben  <aroben@apple.com>
4039
4040         Add links to TestFailures to easily file bugs about failing tests
4041
4042         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
4043         links to file bugs for failing tests
4044
4045         Reviewed by David Kilzer.
4046
4047         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
4048         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
4049         for a particular build.
4050         (Builder.prototype._getFailingTests): Use resultsPageURL.
4051
4052         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
4053         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
4054         failures.
4055         (ViewController.prototype._domForBuildName): Use resultsPageURL.
4056         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
4057         new bug link. The bug has a title, description, and URL already filled in for you!
4058
4059 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
4060
4061         Unreviewed, rolling out r87464.
4062         http://trac.webkit.org/changeset/87464
4063         https://bugs.webkit.org/show_bug.cgi?id=61643
4064
4065         client-close/server-close tests are flaky on Chromium Mac and
4066         Windows (Requested by aklein on #webkit).
4067
4068         * Scripts/webkitpy/thirdparty/__init__.py:
4069
4070 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
4071
4072         Added Douglas Davidson to contributors list for easier CC'ing.
4073
4074         * Scripts/webkitpy/common/config/committers.py:
4075
4076 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
4077
4078         Reviewed by Adam Barth.
4079
4080         Fix worldID and destinationDomain argument names
4081         https://bugs.webkit.org/show_bug.cgi?id=61571
4082
4083         As part of working on r87423, I noticed a couple of inconsistencies in
4084         argument names:
4085         - We would use worldId in .h files but worldID in .cpp files.
4086           Standardize on the latter
4087         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
4088           destinationDomains argument, even though the actual parameter was for
4089           a single domain (renamed to be singular).
4090
4091         * DumpRenderTree/LayoutTestController.h:
4092         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4093         (LayoutTestController::evaluateScriptInIsolatedWorld):
4094
4095 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
4096
4097         Reviewed by Kent Tamura.
4098
4099         WebSocket closing handshake
4100         https://bugs.webkit.org/show_bug.cgi?id=35721
4101
4102         * Scripts/webkitpy/thirdparty/__init__.py:
4103         Pull in pywebsocket 0.6b1. We need to update pywebsocket
4104         to get the right behavior of closing handshake.
4105
4106 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
4107
4108         Reviewed by Andreas Kling.
4109
4110         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
4111         https://bugs.webkit.org/show_bug.cgi?id=42676
4112
4113         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
4114
4115         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4116         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4117         (WTR::InjectedBundle::beginTesting):
4118         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4119         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
4120         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4121
4122 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
4123
4124         Reviewed by Andreas Kling.
4125
4126         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
4127         https://bugs.webkit.org/show_bug.cgi?id=61527
4128
4129         The setMaximumHeight() call is unecessary and breaks the dialog at
4130         least on my setup.
4131
4132         * QtTestBrowser/launcherwindow.cpp:
4133         (LauncherWindow::showUserAgentDialog):
4134
4135 2011-05-02  Robert Hogan  <robert@webkit.org>
4136
4137         Reviewed by Adam Roben.
4138
4139         [Qt] Allow popup windows from plugins when initiated by a user gesture
4140
4141         https://bugs.webkit.org/show_bug.cgi?id=41292
4142
4143         Support parameters introduced in plugin-initiate-popup-window.html
4144
4145         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
4146         (webkit_test_plugin_new_instance):
4147         (webkit_test_plugin_handle_event):
4148
4149 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
4150
4151         Reviewed by Adam Barth.
4152
4153         Support cross-origin XMLHttpRequest in isolated worlds
4154         https://bugs.webkit.org/show_bug.cgi?id=59843
4155
4156         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
4157
4158         * DumpRenderTree/chromium/LayoutTestController.cpp:
4159         (LayoutTestController::LayoutTestController):
4160         (LayoutTestController::setIsolatedWorldSecurityOrigin):
4161         * DumpRenderTree/chromium/LayoutTestController.h:
4162
4163 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
4164
4165         Reviewed by Adam Roben.
4166
4167         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
4168         https://bugs.webkit.org/show_bug.cgi?id=61474
4169         <rdar://problem/9468337>
4170
4171         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4172         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
4173
4174 2011-05-26  Andreas Kling  <kling@webkit.org>
4175
4176         Unreviewed, correct address to webkit-committers mailing list.
4177
4178         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4179
4180 2011-05-25  Adam Roben  <aroben@apple.com>
4181
4182         Don't assume that builds finish in the order they were started
4183
4184         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
4185         build when one slave is taking a long time to finish a build
4186
4187         Reviewed by Antti Koivisto.
4188
4189         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
4190         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
4191         newer than the oldest in-progress build are also themselves in progress. Just check whether
4192         each build is actually in progress (as signified by its presence in the currentBuilds set).
4193
4194 2011-05-25  Adam Roben  <aroben@apple.com>
4195
4196         Correctly detect cases where only a single test failed/crashed/timed out
4197
4198         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
4199         failing test
4200
4201         Reviewed by Darin Adler.
4202
4203         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
4204         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
4205         will be singular when only a single test fails/crashes/times out.
4206
4207         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
4208         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
4209         failed/crashed/timed out.
4210
4211 2011-05-26  Tom Hudson  <tomhudson@google.com>
4212
4213         Reviewed by Tony Chang.
4214
4215         Add flags to Chromium ImageDiff to write image comparison metrics on
4216         stdout.
4217         https://bugs.webkit.org/show_bug.cgi?id=60569
4218
4219         * DumpRenderTree/chromium/ImageDiff.cpp:
4220         (Image::createFromStdin): Fix spelling.
4221         (maxOf3): New function to do 3-way maximum.
4222         (getRedComponent): Extract red component from ABGR packed encoding.
4223         (getGreenComponent): Extract green component from ABGR packed encoding.
4224         (getBlueComponent): Extract blue component from ABGR packed encoding.
4225         (weightedPercentageDifferent): Determine % of pixels different in two
4226         images multiplied by intensity difference of each pixel.
4227         (printHelp): Document new arguments.
4228         (compareImages): Parameterize.
4229         (untestedCompareImages): Parameterize.
4230         (diffImages): Parameterize; write results on stdout if requested.
4231         (main): Parse new arguments.
4232
4233 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
4234
4235         Reviewed by Simon Hausmann.
4236
4237         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
4238         https://bugs.webkit.org/show_bug.cgi?id=42697
4239
4240         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
4241
4242         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4243         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4244         (WTR::InjectedBundle::beginTesting):
4245         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4246         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
4247         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4248
4249 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
4250
4251         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
4252         https://bugs.webkit.org/show_bug.cgi?id=61428
4253         <rdar://problem/9457006>
4254
4255         Reviewed by Adam Roben.
4256
4257         The crash occurs when Flash posts a message to a window that it
4258         creates, and in processing the message, it calls NPN_Evaluate to
4259         evaluate JavaScript that removes the plug-in from the page. Flash then
4260         crashes when we return to Flash code.
4261
4262         This test emulates that behavior.
4263
4264         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
4265         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
4266         Initialize member vars.
4267         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
4268         Remove our custom property from the message window, and destroy it.
4269         (CallJSThatDestroysPlugin::NPP_Destroy):
4270         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
4271         layout test controller that we're done.
4272         (wndProc):
4273         Get the PluginTest object, and call its runTest() function.
4274         (CallJSThatDestroysPlugin::NPP_New):
4275         Setup the test: register a class for the message-only window, create
4276         it, and post a message to it to run the test.
4277         (CallJSThatDestroysPlugin::runTest):
4278         Execute JS that removes the plug-in from the page, and if we're not
4279         destroyed, log a success message.
4280
4281         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
4282         Add new test to project.
4283
4284 2011-05-25  Tony Chang  <tony@chromium.org>
4285
4286         Reviewed by Adam Barth.
4287
4288         webkitpy's NetworkTransaction shouldn't use mechanize
4289         https://bugs.webkit.org/show_bug.cgi?id=61450
4290
4291         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
4292         use urllib2 directly.  Re-add NetworkTransaction to
4293         test_results_uploader.py (reverting r87124).
4294
4295         * Scripts/webkitpy/common/net/networktransaction.py:
4296         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
4297
4298 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
4299
4300         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
4301         until the port begins using those export macros.
4302
4303         * DumpRenderTree/chromium/config.h:
4304
4305 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
4306
4307         Unreviewed, rolling out r87257.
4308         http://trac.webkit.org/changeset/87257
4309         https://bugs.webkit.org/show_bug.cgi?id=61457
4310
4311         This broke layout tests, see bug 61431. (Requested by
4312         hwennborg on #webkit).
4313
4314         * DumpRenderTree/chromium/LayoutTestController.cpp:
4315         (LayoutTestController::LayoutTestController):
4316         (LayoutTestController::clearAllDatabases):
4317         * DumpRenderTree/chromium/LayoutTestController.h:
4318
4319 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
4320
4321         Reviewed by Andreas Kling.
4322
4323         [Qt] fast/css/disabled-author-styles.html failed
4324         https://bugs.webkit.org/show_bug.cgi?id=61438
4325
4326         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
4327
4328         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4329         (WebCore::WebPage::resetSettings):
4330         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4331         (LayoutTestController::setAuthorAndUserStylesEnabled):