error running layout tests on iOS simulator on latest build
[WebKit-https.git] / Tools / ChangeLog
1 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
2
3         error running layout tests on iOS simulator on latest build
4         https://bugs.webkit.org/show_bug.cgi?id=152719
5         <rdar://problem/24009549>
6
7         Reviewed by Alexey Proskuryakov.
8
9         * Scripts/webkitpy/xcode/simulator.py:
10         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
11           before running simctl spawn command.
12
13 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
14
15         Unreviewed, move Frédéric Wang to committers list
16
17         He seems to be on the contributors list by accident. He has been landing his own commits for
18         about two years now.
19
20         * Scripts/webkitpy/common/config/contributors.json:
21
22 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
23
24         Unreviewed, move Sebastian Dröge to committers list harder
25
26         He accidentally added himself to the reviewers list because the file is confusing. Then I
27         accidentially moved him to the contributors list because the file is confusing, even though
28         I knew the contributors list existed in this file and was attempting to add him to the
29         committers list. Really move him to the committers list now.
30
31         * Scripts/webkitpy/common/config/contributors.json:
32
33 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
34
35         Python SCM should be able to retrieve untracked files - Add SVN support
36         https://bugs.webkit.org/show_bug.cgi?id=152546
37
38         Reviewed by Michael Catanzaro.
39
40         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
41         (test_untracked_files): Activating test for SVN.
42         * Scripts/webkitpy/common/checkout/scm/svn.py:
43         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
44
45 2015-12-31  Andy Estes  <aestes@apple.com>
46
47         Replace WTF::move with WTFMove
48         https://bugs.webkit.org/show_bug.cgi?id=152601
49
50         Reviewed by Brady Eidson.
51
52         * DumpRenderTree/TestRunner.h:
53         (TestRunner::setAllowedHosts):
54         * DumpRenderTree/win/DRTDataObject.cpp:
55         (DRTDataObject::SetData):
56         * TestWebKitAPI/Tests/WTF/Deque.cpp:
57         (TestWebKitAPI::TEST):
58         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
59         (TestWebKitAPI::TEST):
60         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
61         (TestWebKitAPI::TEST):
62         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
63         (TestWebKitAPI::TEST):
64         * TestWebKitAPI/Tests/WTF/Ref.cpp:
65         (TestWebKitAPI::passWithRef):
66         (TestWebKitAPI::TEST):
67         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
68         (TestWebKitAPI::TEST):
69         * TestWebKitAPI/Tests/WTF/Vector.cpp:
70         (TestWebKitAPI::TEST):
71         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
72         (TestWebKitAPI::TEST):
73         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
74         (TestWebKitAPI::TEST):
75         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
76         (TestWebKitAPI::createTestValue):
77         (TestWebKitAPI::TEST):
78         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
79         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
80         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
81         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
82         (TestWebKitAPI::createNFAs):
83         (TestWebKitAPI::TEST_F):
84         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
85         (TestWebKitAPI::combine):
86         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
87         (TestWebKitAPI::createNFAs):
88         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
89         (TEST):
90         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
91         (WebProcessTest::add):
92
93 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
94
95         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
96         https://bugs.webkit.org/show_bug.cgi?id=152634
97
98         Reviewed by Carlos Garcia Campos.
99
100         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
101         (testLoadFromGResource): Added test.
102         (beforeAll):
103         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
104         (registerGResource): Added.
105         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
106         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
107         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
108
109 2015-12-31  David Kilzer  <ddkilzer@apple.com>
110
111         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
112         <https://bugs.webkit.org/show_bug.cgi?id=152601>
113
114         Ignore unknown pragmas on older clangs.  Fixes the following
115         build failure:
116
117             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
118             #pragma clang diagnostic ignored "-Wself-move"
119                                              ^
120             1 error generated.
121
122         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
123         (TestWebKitAPI::TEST):
124         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
125         (TestWebKitAPI::TEST):
126
127 2015-12-31  Andy Estes  <aestes@apple.com>
128
129         Update the style checker to advise using WTFMove() instead of WTF::move()
130         https://bugs.webkit.org/show_bug.cgi?id=152601
131
132         Reviewed by Daniel Bates.
133
134         * Scripts/webkitpy/style/checkers/cpp.py:
135         (check_wtf_move):
136         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
137         (WebKitStyleTest.test_wtf_move):
138
139 2015-12-31  Andy Estes  <aestes@apple.com>
140
141         Fix warnings uncovered by migrating to WTF_MOVE
142         https://bugs.webkit.org/show_bug.cgi?id=152601
143
144         Reviewed by Daniel Bates.
145
146         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
147         self-move, even if doing so would trigger a warning.
148
149         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
150         (TestWebKitAPI::TEST):
151         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
152         (TestWebKitAPI::TEST):
153
154 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
155
156         [GTK] The install-dependencies script has a syntax error
157         https://bugs.webkit.org/show_bug.cgi?id=152613
158
159         Reviewed by Michael Catanzaro.
160
161         * gtk/install-dependencies: Add the missing 'then.'
162
163 2015-12-30  Philippe Normand  <pnormand@igalia.com>
164
165         [Mac][GTK] Jhbuild support for OSX
166         https://bugs.webkit.org/show_bug.cgi?id=150799
167
168         Reviewed by Michael Catanzaro.
169
170         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
171         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
172         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
173         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
174
175 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
176
177         Unreviewed, move Sebastian Dröge to committers list
178
179         He accidentally added himself to the reviewers list because the file is confusing.
180
181         * Scripts/webkitpy/common/config/contributors.json:
182
183 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
184
185         Remove the unused #define _USE_MATH_DEFINES
186         https://bugs.webkit.org/show_bug.cgi?id=152034
187
188         Reviewed by Tim Horton.
189         
190         Update this test to use piDouble from MathExtras.h, and
191         std::numeric_limits<>.
192
193         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
194
195 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
196
197         Python SCM should be able to retrieve untracked files - Generic changes
198         https://bugs.webkit.org/show_bug.cgi?id=152536
199
200         Reviewed by Brent Fulgham.
201
202         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
203         No support is yet added to GIT and SVN specific implementations.
204
205         * Scripts/webkitpy/common/checkout/scm/scm.py:
206         (SCM.untracked_files):
207         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
208         (SCMTest._shared_test_untracked_files):
209
210 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
211
212         SVN checkout used by RunBenchmark should be non-interactive
213         https://bugs.webkit.org/show_bug.cgi?id=152542
214
215         Reviewed by Ryosuke Niwa.
216
217         RunBenchmark should not require user interaction while running.
218
219         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
220         (BenchmarkBuilder._checkout_with_subversion):
221
222 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
223
224         Web Inspector: add support for running protocol-test.js tests on Windows
225         https://bugs.webkit.org/show_bug.cgi?id=148037
226         <rdar://problem/22292237>
227
228         Reviewed by Simon Fraser.
229
230         * DumpRenderTree/win/TestRunnerWin.cpp:
231         (TestRunner::inspectorTestStubURL): Provide implementation.
232
233 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
234
235         [MediaStream] MediaDeviceInfo.label must be empty in some situations
236         https://bugs.webkit.org/show_bug.cgi?id=152000
237
238         Reviewed by Brent Fulgham.
239
240         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
241         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
242         (WTR::InjectedBundle::setUserMediaPermission):
243         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
244         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
245
246         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
247         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
248         * WebKitTestRunner/InjectedBundle/TestRunner.h:
249
250         * WebKitTestRunner/TestController.cpp:
251         (WTR::TestController::setUserMediaPermissionForOrigin):
252         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
253         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
254           persistent permission for origin, that can be done from script now.
255         * WebKitTestRunner/TestController.h:
256
257         * WebKitTestRunner/TestInvocation.cpp:
258         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
259           SetUserMediaPermissionForOrigin.
260
261 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
262
263         [Win] Unreviewed build fix: Recognize Windows 10 variants.
264
265         * Scripts/webkitpy/common/system/platforminfo.py:
266         (PlatformInfo._determine_win_version):
267
268 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
269
270         Content blockers should be able to promote http to https
271         https://bugs.webkit.org/show_bug.cgi?id=148966
272
273         Reviewed by Benjamin Poulain.
274
275         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
276         (WebCore::ContentExtensions::operator<<):
277         (TestWebKitAPI::TEST_F):
278
279 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
280
281         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
282         https://bugs.webkit.org/show_bug.cgi?id=152516
283
284         Reviewed by Gyuyoung Kim.
285
286         * MiniBrowser/efl/main.c:
287
288 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
289
290         Unreviewed: Add John Wilander as a contributor.
291
292         * Scripts/webkitpy/common/config/contributors.json:
293
294 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
295
296         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
297         https://bugs.webkit.org/show_bug.cgi?id=152482
298
299         Reviewed by Brent Fulgham.
300
301         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
302         for the same property. On WK2, the element returned will not be valid, but is still present and
303         that can lead to looping.
304
305         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
306         (AccessibilityUIElement::horizontalScrollbar):
307         (AccessibilityUIElement::verticalScrollbar):
308         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
309         (WTR::AccessibilityUIElement::horizontalScrollbar):
310         (WTR::AccessibilityUIElement::verticalScrollbar):
311
312 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
313
314         Unreviewed.
315
316         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
317
318 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
319
320         [EFL] test_ewk2_context failed after r192808
321         https://bugs.webkit.org/show_bug.cgi?id=151846
322
323         Reviewed by Gyuyoung Kim.
324
325         Used the added ewk_context_web_process_count_limit_set api
326         instead of the deprecated ewk_context_process_model_set.
327
328         * MiniBrowser/efl/main.c:
329         (elm_main):
330
331 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
332
333         Unreviewed, move myself to reviewer list.
334
335         * Scripts/webkitpy/common/config/contributors.json:
336
337 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
338
339         Unreviewed, add myself to the committers list.
340
341         * Scripts/webkitpy/common/config/contributors.json:
342
343 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
344
345         [GTK] jquery.min.js violates DFSG
346         https://bugs.webkit.org/show_bug.cgi?id=152428
347
348         Reviewed by Joseph Pecoraro.
349
350         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
351         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
352
353         * gtk/manifest.txt.in:
354
355 2015-12-19  Dan Bernstein  <mitz@apple.com>
356
357         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
358         https://bugs.webkit.org/show_bug.cgi?id=152462
359
360         Reviewed by Alexey Proskuryakov.
361
362         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
363           OS X 10.9:
364
365         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
366         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
367         * MiniBrowser/Configurations/DebugRelease.xcconfig:
368         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
369         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
370
371         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
372           never getting compiled:
373
374         * DumpRenderTree/mac/TextInputController.m:
375         * MiniBrowser/mac/BrowserWindowController.m:
376         * TestWebKitAPI/Tests/mac/AttributedString.mm:
377         * WebKitTestRunner/mac/EventSenderProxy.mm:
378
379 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
380
381         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
382
383         This is to make it easy to CC it on Bugzilla.
384
385         * Scripts/webkitpy/common/config/contributors.json:
386
387 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
388
389         Pasteboard get messed up after running kill-old-processes
390         https://bugs.webkit.org/show_bug.cgi?id=152426
391
392         Reviewed by Alexey Proskuryakov.
393
394         * BuildSlaveSupport/kill-old-processes:
395         (main): Do not kill pasteboard anymore.
396
397 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
398
399         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
400         https://bugs.webkit.org/show_bug.cgi?id=152157
401         <rdar://problem/23851817>
402
403         Reviewed by Alexey Proskuryakov.
404
405         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
406         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
407         * Scripts/webkitpy/layout_tests/controllers/manager.py:
408         (Manager._get_test_inputs): Common method to calculate test_inputs.
409         (Manager._update_worker_count): Calculate and update required number of workers.
410
411 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
412
413         run-webkit-tests fails to delete Simulator device during cleanup
414         https://bugs.webkit.org/show_bug.cgi?id=152363
415
416         Reviewed by Alexey Proskuryakov.
417
418         * Scripts/webkitpy/xcode/simulator.py:
419         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
420
421 2015-12-16  Tim Horton  <timothy_horton@apple.com>
422
423         [mac-wk2] fast/events force click tests crashing
424         https://bugs.webkit.org/show_bug.cgi?id=152339
425
426         Reviewed by Beth Dakin.
427
428         * WebKitTestRunner/mac/EventSenderProxy.mm:
429         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
430         Set the NSEvent's _type member in addition to overriding -type,
431         because there are assertions in touch event handling code that depend on it.
432
433 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
434
435         Enforce temporarily bots to sync WebKit and WPT testharness.js
436         https://bugs.webkit.org/show_bug.cgi?id=152334
437
438         Reviewed by Darin Adler.
439
440         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
441         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
442
443 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
444
445         [Fetch API] Add fetch API compile time flag
446         https://bugs.webkit.org/show_bug.cgi?id=152254
447
448         Reviewed by Darin Adler.
449
450         * Scripts/webkitperl/FeatureList.pm:
451
452 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
453
454         Unreviewed.
455
456         Added files that have impact in building Streams API to the watchlist.
457
458         * Scripts/webkitpy/common/config/watchlist:
459
460 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
461
462         Unreviewed.
463
464         Added imported tests to Streams API watchlist.
465
466         * Scripts/webkitpy/common/config/watchlist:
467
468 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
469
470         Remove default copy of wpt testharness.js when launching wpt server
471         https://bugs.webkit.org/show_bug.cgi?id=152298
472
473         Reviewed by Darin Adler.
474
475         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
476         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
477
478 2015-12-15  David Kilzer  <ddkilzer@apple.com>
479
480         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
481         <http://webkit.org/b/152314>
482
483         Reviewed by Daniel Bates.
484
485         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
486         code path to exit immediately when calling main().
487         Unfortunately, DumpRenderTreeMain.mm was used for both
488         DumpRenderTree command-line binary and DumpRenderTree.app, which
489         meant that the app would exit immediately with no error code
490         when run!
491
492         The workaround is to introduce a separate source file called
493         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
494         already does.
495
496         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
497         DumpRenderTreeAppMain.mm to the project.  Make it the only
498         compiled source for the DumpRenderTree.app target.
499         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
500         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
501         case someone tries mistakenly to use the app.
502         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
503         Link to JavaScriptCore.framework on iOS for the assert.
504         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
505         Link to JavaScriptCore.framework on OS X for the assert.  Remove
506         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
507         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
508         (main): Add assert for iOS so that a crash occurs if someone
509         tries to run the wrong command.
510
511 2015-12-14  Tim Horton  <timothy_horton@apple.com>
512
513         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
514         https://bugs.webkit.org/show_bug.cgi?id=152266
515         <rdar://problem/22092676>
516
517         Reviewed by Simon Fraser.
518
519         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
520         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
521         Add a test that crashed before this change, and doesn't crash after.
522
523 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
524
525         AX: iOS: Text field variations do not have the correct traits
526         https://bugs.webkit.org/show_bug.cgi?id=152237
527
528         Reviewed by Mario Sanchez Prada.
529
530         Add iOS calls for determing if an object is a search field or a text area.
531
532         * DumpRenderTree/AccessibilityUIElement.cpp:
533         (getIsSearchFieldCallback):
534         (getIsTextAreaCallback):
535         (stringForSelectionCallback):
536         (AccessibilityUIElement::getJSClass):
537         * DumpRenderTree/AccessibilityUIElement.h:
538         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
539         (AccessibilityUIElement::identifier):
540         (AccessibilityUIElement::isTextArea):
541         (AccessibilityUIElement::isSearchField):
542         (AccessibilityUIElement::traits):
543         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
544         (WTR::AccessibilityUIElement::scrollPageRight):
545         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
546         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
547         (WTR::AccessibilityUIElement::isSearchField):
548         (WTR::AccessibilityUIElement::isTextArea):
549         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
550         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
551         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
552         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
553         (WTR::AccessibilityUIElement::isTextArea):
554         (WTR::AccessibilityUIElement::isSearchField):
555         (WTR::AccessibilityUIElement::rowCount):
556
557 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
558
559         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
560         https://bugs.webkit.org/show_bug.cgi?id=152252
561
562         Reviewed by Sergio Villar Senin.
563
564         * gtk/install-dependencies: Add libtool-bin to the list of packages required
565         for building the JHBuild on Debian systems.
566
567 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
568
569         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
570         https://bugs.webkit.org/show_bug.cgi?id=152156
571
572         Reviewed by Dan Bernstein.
573
574         Our frameworks should appropriately prefix all ObjC classes,
575         not just external symbols.
576
577         * Scripts/check-for-inappropriate-objc-class-names:
578         Remove the -g switch to check all ObjC class names.
579
580 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
581
582         [MediaStream] Expose media capture devices persistent permissions to WebCore
583         https://bugs.webkit.org/show_bug.cgi?id=152087
584
585         Add support for the new user media permission checker page UI client method.
586
587         Reviewed by Chris Dumez.
588
589         * WebKitTestRunner/TestController.cpp:
590         (WTR::decidePolicyForUserMediaPermissionRequest):
591         (WTR::checkUserMediaPermissionForOrigin):
592         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
593         (WTR::TestController::createWebViewWithOptions): Ditto.
594         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
595         (WTR::originUserVisibleName): New, create a string for the origin.
596         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
597           according to the state of the origin permission map.
598         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
599           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
600         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
601           origin permission map.
602         * WebKitTestRunner/TestController.h:
603
604 2015-12-10  Alex Christensen  <achristensen@webkit.org>
605
606         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
607         https://bugs.webkit.org/show_bug.cgi?id=152022
608         rdar://problem/23763584
609
610         Reviewed by Darin Adler.
611
612         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
613         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
614         (WTR::InjectedBundlePage::willSendRequestForFrame):
615         * WebKitTestRunner/InjectedBundle/TestRunner.h:
616         (WTR::TestRunner::setWillSendRequestReturnsNull):
617         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
618         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
619         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
620         (WTR::TestRunner::willSendRequestHTTPBody):
621         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
622
623 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
624
625         Remove additional simulator checks before running layout-tests
626         https://bugs.webkit.org/show_bug.cgi?id=152146
627
628         Reviewed by Darin Adler.
629
630         * Scripts/webkitpy/port/ios.py:
631         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
632         * Scripts/webkitpy/xcode/simulator.py:
633         (Simulator._boot_and_shutdown_simulator_device): Deleted.
634         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
635
636 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
637
638         Run atleast one simulator even if max process limit is low
639         https://bugs.webkit.org/show_bug.cgi?id=152081
640         <rdar://problem/23819694>
641
642         Reviewed by Alexey Proskuryakov.
643
644 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
645
646         [GTK] Crash in WebProcess when loading large content with custom URI schemes
647         https://bugs.webkit.org/show_bug.cgi?id=144262
648
649         Reviewed by Carlos Garcia Campos.
650
651         Added new unit test to check the additional scenarios we now
652         handle for custom URI schemes.
653
654         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
655         (generateHTMLContent): New helper function to generate big enough content.
656         (testWebContextURIScheme): New unit test.
657
658 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
659
660         [EFL] Fix unhandled web process message when launching MiniBrowser
661         https://bugs.webkit.org/show_bug.cgi?id=152048
662
663         Reviewed by Gyuyoung Kim.
664
665         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
666         (TestWebKitAPI::TEST):
667
668 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
669
670         [GTK] Add API to handle beforeunload events
671         https://bugs.webkit.org/show_bug.cgi?id=139090
672
673         Reviewed by Gustavo Noronha Silva.
674
675         * MiniBrowser/gtk/BrowserWindow.c:
676         (browserWindowConstructed):
677         (browserWindowDeleteEvent):
678         (browser_window_class_init):
679         Handle delete-event to prevent the window from being closed when
680         the page has beforeunload handlers. Use
681         webkit_web_view_try_close() when the window is requested to be
682         closed.
683         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
684         (testWebViewJavaScriptDialogs):
685         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
686         script dialog type.
687
688 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
689
690         Refactored initialization code in LoadTrackingTest.
691
692         Rubber-stamped by Carlos Garcia Campos.
693
694         Small refactoring to make sure that the state of a LoadTrackingTest
695         gets properly reset before loading new web content.
696
697         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
698         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
699         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
700         functions and reset the remaining local variables.
701         (LoadTrackingTest::loadURI): Call reset();
702         (LoadTrackingTest::loadHtml): Ditto.
703         (LoadTrackingTest::loadPlainText): Ditto.
704         (LoadTrackingTest::loadBytes): Ditto.
705         (LoadTrackingTest::loadRequest): Ditto.
706         (LoadTrackingTest::reload): Ditto.
707         (LoadTrackingTest::goBack): Ditto.
708         (LoadTrackingTest::goForward): Ditto.
709
710 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
711
712         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
713         https://bugs.webkit.org/show_bug.cgi?id=151942
714
715         Reviewed by Darin Adler.
716
717         * MiniBrowser/efl/main.c:
718         (window_create): Enable offline web application cache feature on MiniBrowser.
719         (elm_main):
720
721 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
722
723         https://bugs.webkit.org/show_bug.cgi?id=151243
724         <rdar://problem/22955197>
725
726         Reviewed by Alexey Proskuryakov.
727
728         * LayoutTestRelay/LayoutTestRelay/main.m:
729         (getTestingSimDevice): Use separate testing device for each worker.
730         * Scripts/webkitpy/layout_tests/controllers/manager.py:
731         (Manager.run): Perform cleanup even if setup fails.
732         * Scripts/webkitpy/port/ios.py:
733         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
734         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
735         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
736         (IOSSimulatorPort._quit_ios_simulator): Same
737         (IOSSimulatorPort.clean_up_test_run): Same
738         (IOSSimulatorPort.check_sys_deps): Same
739         (IOSSimulatorPort.testing_device): Same
740         (IOSSimulatorPort.reset_preferences): Same
741         (IOSSimulatorPort.get_simulator_path): Return simulator path.
742         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
743         * Scripts/webkitpy/xcode/simulator.py:
744         (Device.delete): Delete the simulator device.
745         (Simulator.delete_device): Same
746         (Simulator.wait_until_device_is_booted): Wait for device booting.
747
748 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
749
750         [EFL] Add API to provide preferences before creating ewk_view
751         https://bugs.webkit.org/show_bug.cgi?id=151587
752
753         Reviewed by Gyuyoung Kim.
754
755         * MiniBrowser/efl/main.c:
756         (on_key_down):
757         (quit):
758         (window_create):
759         Moved settings related code to configuration() not to update settings
760         whenever ewk_view is created.
761         (configuration):
762         (elm_main):
763
764 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
765
766         Unreviewed. Fix GTK+ API tests after r193639.
767
768         The new jhbuild version needs some more variables ot be present in
769         the builtin dict, even if they are set to None.
770
771         * jhbuild/jhbuildutils.py:
772         (enter_jhbuild_environment_if_available):
773
774 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
775
776         [GTK] Notify WebCore when notification is clicked
777         https://bugs.webkit.org/show_bug.cgi?id=151951
778
779         Reviewed by Carlos Garcia Campos.
780
781         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
782         (testWebViewNotification): test the new API.
783
784 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
785
786         'jhbuild build' should fail immediately when building any module fails
787         https://bugs.webkit.org/show_bug.cgi?id=145697
788
789         Reviewed by Carlos Garcia Campos.
790
791         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
792         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
793         Everything is placed under lib instead of lib64 now.
794         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
795         --exit-on-error when running 'jhbuild build'.
796         * jhbuild/jhbuildrc_common.py:
797         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
798         jhbuild should be able to handle these for us without breaking things....
799
800 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
801
802         Add support to import w3c tests from a repository with a different root that the main repo dir
803         https://bugs.webkit.org/show_bug.cgi?id=151751
804
805         Reviewed by Ryosuke Niwa and Youenn Fablet.
806
807         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
808         in a different directory than the repository root.
809
810         This patch introduces a new parameter tests_directory that we will use as root directory to search for
811         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
812         requires having the copy_path lists including tuples of origin and destination directories.
813
814         * Scripts/webkitpy/w3c/test_downloader.py:
815         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
816         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
817         * Scripts/webkitpy/w3c/test_importer_unittest.py:
818         (TestImporterTest.test_tests_directory): Test.
819
820 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
821
822         Mock TestRepositories in W3C importer tests
823         https://bugs.webkit.org/show_bug.cgi?id=151938
824
825         Reviewed by Youenn Fablet.
826
827         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
828         is because the test repository method reading the file was using the filesystem directly instead of taking the
829         host one. This patch changes that.
830
831         * Scripts/webkitpy/w3c/test_downloader.py:
832         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
833         default one.
834         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
835         * Scripts/webkitpy/w3c/test_importer_unittest.py:
836         (TestImporterTest.test_harnesslinks_conversion):
837         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
838
839 2015-12-07  David Kilzer  <ddkilzer@apple.com>
840
841         TestNetscapePlugIn: Address review comment on 193607
842         <http://webkit.org/b/151881>
843
844         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
845         (testSetStatus): Initializing std::unique_ptr<char[]> with
846         nullptr is redundant.
847
848 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
849
850         [GTK] Add webkit_uri_request_get_http_method
851         https://bugs.webkit.org/show_bug.cgi?id=151601
852
853         Reviewed by Martin Robinson.
854
855         Add test case to check HTTP method of WebKitURIRequest.
856
857         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
858         (testURIRequestHTTPMethod):
859         (serverCallback):
860         (beforeAll):
861         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
862         (sendRequestCallback):
863
864 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
865
866         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
867         https://bugs.webkit.org/show_bug.cgi?id=79918
868
869         Reviewed by Gustavo Noronha Silva.
870
871         Add unit tests to check the different console messages.
872
873         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
874         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
875         (ConsoleMessageTest::ConsoleMessage::operator==):
876         (ConsoleMessageTest::consoleMessageReceivedCallback):
877         (ConsoleMessageTest::ConsoleMessageTest):
878         (ConsoleMessageTest::~ConsoleMessageTest):
879         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
880         (testWebKitConsoleMessageConsoleAPI):
881         (testWebKitConsoleMessageJavaScriptException):
882         (testWebKitConsoleMessageNetworkError):
883         (testWebKitConsoleMessageSecurityError):
884         (beforeAll):
885         (afterAll):
886         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
887         (consoleMessageSentCallback):
888         (pageCreatedCallback):
889
890 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
891
892         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
893         https://bugs.webkit.org/show_bug.cgi?id=151934
894
895         Reviewed by Csaba Osztrogonác.
896
897         * MiniBrowser/efl/main.c:
898         (on_window_deletion): Revert the changes of r192767.
899
900 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
901
902         [GTK] update-webkitgtk-libs cannot build mesa
903         https://bugs.webkit.org/show_bug.cgi?id=151535
904
905         Reviewed by Martin Robinson.
906
907         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
908         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
909         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
910         does not have a stable API and we cannot expect mesa to be buildable unless we control the
911         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
912         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
913
914         * gtk/jhbuild.modules:
915
916 2015-12-07  Philippe Normand  <pnormand@igalia.com>
917
918         [GTK][Mac] libWebExtensionTest link error
919         https://bugs.webkit.org/show_bug.cgi?id=150802
920
921         Reviewed by Carlos Garcia Campos.
922
923         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
924
925 2015-12-06  David Kilzer  <ddkilzer@apple.com>
926
927         TestNetscapePlugIn: Fix leaks found by static analyzer
928         <http://webkit.org/b/151881>
929
930         Reviewed by Darin Adler.
931
932         Fixes the following leaks found by the static analyzer:
933             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
934                     return false;
935                            ^~~~~
936             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
937                     return false;
938                            ^~~~~
939             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
940                     return false;
941                            ^~~~~
942
943         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
944         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
945         early return if allocation fails.
946         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
947         Make sure to call fclose() on filehandle, even for an early
948         return.
949         (testSetStatus): Switch to using std::unique_ptr<char[]>.
950
951 2015-12-05  David Kilzer  <ddkilzer@apple.com>
952
953         prepare-ChangeLog: Fix some warning messages when using svn
954         <http://webkit.org/b/151914>
955
956         Reviewed by Daniel Bates.
957
958         * Scripts/prepare-ChangeLog:
959         (generateFunctionLists): Simplify logic so that we never call
960         normalizePath() with an undefined value.
961         (attributeCommand): Quote $subPath for the shell so that we
962         don't try to run "svn propget" on invalid paths.
963
964 2015-12-04  David Kilzer  <ddkilzer@apple.com>
965
966         TestNetscapePlugIn: Fix remaining static analyzer warnings
967         <http://webkit.org/b/151888>
968
969         Reviewed by Alexey Proskuryakov.
970
971         Fixes the following static analyzer warnings:
972             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
973                     CRASH();
974                     ^~~~~~~
975             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
976                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
977                 ^~~~~~~~~~~~~~~~
978             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
979                 return obj->pluginTest->NPP_SetWindow(window);
980                        ^~~~~~~~~~~~~~~
981             2 warnings generated.
982
983         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
984         (CRASH): Use __builtin_trap() for gcc/clang.
985         (NPP_SetWindow): Add early return if obj is nullptr.
986
987 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
988
989         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
990         https://bugs.webkit.org/show_bug.cgi?id=151797
991
992         Reviewed by Martin Robinson.
993
994         Since we switched to use the network process to run the unit tests
995         the test /webkit2/WebKitWebResource/get-data sometimes fails and
996         sometimes passes. We are now also getting the notification for the
997         css image. Since we wait for 3 resources, sometimes the css image
998         is loaded before and then checkResourceData is called for it, but
999         not handled. When the css image is the last one loaded the test
1000         passes. So, we just need to wait for the 4 resources.
1001
1002         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1003         (testWebResourceGetData):
1004
1005 2015-12-03  David Kilzer  <ddkilzer@apple.com>
1006
1007         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1008         <http://webkit.org/b/151845>
1009
1010         Reviewed by Simon Fraser.
1011
1012         Fixes the following static analyzer warning:
1013             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1014                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1015                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1016
1017         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1018         (createBitmapContext): Free 'buffer' after using it in logging
1019         to fix the use-after-free.  Assign a value of nullptr to buffer
1020         so we don't return with it set to a freed address.
1021
1022 2015-12-03  Jer Noble  <jer.noble@apple.com>
1023
1024         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1025         https://bugs.webkit.org/show_bug.cgi?id=151830
1026
1027         Reviewed by Anders Carlsson.
1028
1029         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1030
1031         * DumpRenderTree/mac/DumpRenderTree.mm:
1032         (resetWebPreferencesToConsistentValues):
1033         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1034         (WTR::initializeWebViewConfiguration):
1035
1036 2015-12-03  Anders Carlsson  <andersca@apple.com>
1037
1038         Remove Objective-C GC support
1039         https://bugs.webkit.org/show_bug.cgi?id=151819
1040         rdar://problem/23746991
1041
1042         Reviewed by Dan Bernstein.
1043
1044         * asan/asan.xcconfig:
1045
1046 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1047
1048         Allow nil for unspecified benchmark pathes
1049         https://bugs.webkit.org/show_bug.cgi?id=151784
1050
1051         Reviewed by Filip Pizlo.
1052
1053         `Pathname.new(nil)` will raise an error.
1054         Only generate Pathname if the benchmark path is specified.
1055
1056         * Scripts/run-jsc-benchmarks:
1057
1058 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
1059
1060         [Win] Run non-http tests without Cygwin
1061         https://bugs.webkit.org/show_bug.cgi?id=151721
1062
1063         Reviewed by Andy Estes.
1064
1065         Support native 32-bit and 64-bit Python (and Perl) builds
1066         for running tests:
1067
1068         1. Use "startswith('win')", rather than "== 'win32'" to support
1069         various Windows build types.
1070         2. Supply full path for some native Windows utilities, since the
1071         path environment does not always have the specified, and they are
1072         guaranteed to exist in those specific locations.
1073         3. Make sure native Windows Python test runs pass proper environment
1074         variables to run programs.
1075         4. Append 'exe' suffix when running Windows executables.
1076         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1077         command doesn't exist.
1078         
1079         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1080         the current Perl executable, rather than requiring a new path search.
1081         * Scripts/webkitpy/common/find_files_unittest.py:
1082         (TestWinNormalize.test_win): Use startswith('win').
1083         * Scripts/webkitpy/common/prettypatch_unittest.py:
1084         (test_pretty_diff_encodings): Ditto.
1085         * Scripts/webkitpy/common/system/executive.py:
1086         (Executive._should_close_fds): Ditto.
1087         (Executive.shell_command_for_script): Use startswith('win').
1088         (Executive.kill_process): Use full path to killall executable.
1089         (Executive.check_running_pid): Use startswith('win').
1090         (Executive.running_pids): Ditto.
1091         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1092         running under native Windows Python.
1093         (Executive._child_process_encoding): Use startswith('win').
1094         (Executive._should_encode_child_process_arguments): Ditto.
1095         (Executive.popen): Recognize proper script engine on Windows, since it
1096         does not support the shebang syntax.
1097         (Executive.run_in_parallel): Use startswith('win').
1098         * Scripts/webkitpy/common/system/executive_unittest.py:
1099         (never_ending_command): Ditto.
1100         (ExecutiveTest.test_run_command_with_unicode): Ditto.
1101         (ExecutiveTest.serial_test_kill_process): Ditto.
1102         (ExecutiveTest.serial_test_kill_all): Ditto.
1103         (ExecutiveTest.serial_test_check_running_pid): Ditto.
1104         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1105         (main): Ditto.
1106         * Scripts/webkitpy/common/system/file_lock.py:
1107         (FileLock._create_lock): Ditto.
1108         (FileLock._remove_lock): Ditto.
1109         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1110         (RealFileSystemTest.test_chdir): Ditto.
1111         (RealFileSystemTest.test_chdir__notexists): Ditto.
1112         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1113         * Scripts/webkitpy/common/system/path_unittest.py:
1114         (AbspathTest.test_abspath_to_uri_win): Ditto.
1115         * Scripts/webkitpy/common/system/platforminfo.py:
1116         (PlatformInfo._determine_os_name): Ditto.
1117         * Scripts/webkitpy/common/system/user.py: Ditto.
1118         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1119         (ManagerTest.integration_test_needs_servers): Ditto.
1120         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1121         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1122         driver letters.
1123         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1124         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1125         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1126         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1127         (HttpServerBase._check_that_all_ports_are_available): Ditto.
1128         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1129         (TestHttpServer.test_start_cmd): Ditto.
1130         * Scripts/webkitpy/port/base.py:
1131         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1132         and 'SYSTEMROOT' in environment passed to test runners.
1133         (Port._apache_config_file_name_for_platform): Use startswith('win').
1134         (Port._build_path): Ditto.
1135         (Port._path_to_driver): Include 'exe' suffix when running under native
1136         Windows.
1137         * Scripts/webkitpy/port/driver.py:
1138         (Driver._setup_environ_for_driver): Explicitly make some environment
1139         variables strings.
1140         * Scripts/webkitpy/port/server_process.py:
1141         (ServerProcess.__init__): Use startswith('win').
1142         * Scripts/webkitpy/port/win.py:
1143         (WinPort): Use the win32 registry utilities on Windows, and appropriate
1144         registry key formats.
1145         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1146         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1147         and regtool on Cygwin.
1148         (WinPort.write_registry_value): Ditto.
1149         (WinPort.setup_crash_log_saving): Ditto.
1150         (WinPort.restore_crash_log_saving): Ditto.
1151         (WinPort.prevent_error_dialogs): Ditto.
1152         (WinPort.allow_error_dialogs): Ditto.
1153         (WinPort.find_system_pid): Revise to use Windows management
1154         infrastructure on native Windows, continue using 'ps' on Cygwin.
1155         (WinPort.read_registry_string): Deleted.
1156         (WinPort.write_registry_string): Deleted.
1157         * Scripts/webkitpy/test/main.py:
1158         (main): Use startswith('win').
1159         (Tester._parse_args): Ditto.
1160
1161 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1162
1163         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1164         https://bugs.webkit.org/show_bug.cgi?id=150792
1165
1166         Reviewed by Saam Barati.
1167
1168         * Scripts/webkitperl/FeatureList.pm:
1169
1170 2015-12-01  Commit Queue  <commit-queue@webkit.org>
1171
1172         Unreviewed, rolling out r192914.
1173         https://bugs.webkit.org/show_bug.cgi?id=151734
1174
1175         JSC tests for this change are failing on 32 and 64-bit bots
1176         (Requested by ryanhaddad on #webkit).
1177
1178         Reverted changeset:
1179
1180         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1181         enable this feature"
1182         https://bugs.webkit.org/show_bug.cgi?id=150792
1183         http://trac.webkit.org/changeset/192914
1184
1185 2015-12-01  David Kilzer  <ddkilzer@apple.com>
1186
1187         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1188         <http://webkit.org/b/151726>
1189
1190         Reviewed by Simon Fraser.
1191
1192         * WebKitTestRunner/mac/EventSenderProxy.mm:
1193         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
1194         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
1195
1196 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
1197
1198         Give String and AtomicString an existingHash() function
1199         https://bugs.webkit.org/show_bug.cgi?id=151717
1200
1201         Reviewed by Andreas Kling.
1202
1203         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1204         (TestWebKitAPI::TEST):
1205         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1206         (TestWebKitAPI::TEST):
1207
1208 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1209
1210         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1211         https://bugs.webkit.org/show_bug.cgi?id=150792
1212
1213         Reviewed by Saam Barati.
1214
1215         * Scripts/webkitperl/FeatureList.pm:
1216
1217 2015-12-01  Sam Weinig  <sam@webkit.org>
1218
1219         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
1220         <rdar://problem/23320863>
1221         https://bugs.webkit.org/show_bug.cgi?id=151708
1222
1223         Reviewed by Anders Carlsson.
1224
1225         * WebKitTestRunner/TestController.cpp:
1226         (WTR::TestController::createOtherPage):
1227         (WTR::TestController::createWebViewWithOptions):
1228         Update for new WKPageUIClient.
1229
1230 2015-12-01  Anders Carlsson  <andersca@apple.com>
1231
1232         Remove WebKit2.framework
1233         https://bugs.webkit.org/show_bug.cgi?id=151715
1234
1235         Reviewed by Dan Bernstein.
1236
1237         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
1238         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
1239         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1240         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1241         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1242         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1243         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1244
1245 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
1246
1247         Unreviewed common typo fix "occurance" => "occurrence".
1248
1249         * Scripts/webkitpy/tool/commands/queries.py:
1250         (FindFlakyTests._print_statistics):
1251
1252 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1253
1254         Make ProcessModel always MultipleSecondaryProcesses
1255         https://bugs.webkit.org/show_bug.cgi?id=151662
1256
1257         Reviewed by Antti Koivisto.
1258
1259         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1260         (TestWebKitAPI::TEST):
1261         * WebKitTestRunner/TestController.cpp:
1262         (WTR::TestController::generatePageConfiguration):
1263
1264 2015-11-30  Alex Christensen  <achristensen@webkit.org>
1265
1266         Make usesNetworkProcess always true
1267         https://bugs.webkit.org/show_bug.cgi?id=151580
1268
1269         Reviewed by Darin Adler.
1270
1271         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1272         (TestWebKitAPI::TEST):
1273         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1274         (TestWebKitAPI::TEST):
1275         * WebKitTestRunner/TestController.cpp:
1276         (WTR::TestController::generatePageConfiguration):
1277
1278 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1279
1280         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
1281
1282         Add a way to skip unit tests only for Debug or Release builds and
1283         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
1284
1285         * Scripts/run-gtk-tests:
1286         (SkippedTest):
1287         (SkippedTest.__init__):
1288         (SkippedTest.__str__):
1289         (SkippedTest.skip_entire_suite):
1290         (SkippedTest.skip_for_build_type):
1291         (TestRunner):
1292         (TestRunner.__init__):
1293
1294 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1295
1296         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
1297
1298         It's an assert hit because we are reloading a view loaded with
1299         HTML data which is not supported. Use loadURI instead.
1300
1301         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1302         (testWebViewCustomCharset):
1303
1304 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1305
1306         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
1307         https://bugs.webkit.org/show_bug.cgi?id=151633
1308
1309         Reviewed by Csaba Osztrogonác.
1310
1311         * TestWebKitAPI/PlatformGTK.cmake:
1312         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
1313
1314 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1315
1316         [GTK] Remove the remaining uses of GMainLoopSource
1317         https://bugs.webkit.org/show_bug.cgi?id=151632
1318
1319         Reviewed by Žan Doberšek.
1320
1321         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1322         (testWebViewSyncRequestOnMaxConns):
1323         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1324         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1325         (WTR::TestRunner::TestRunner):
1326         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1327         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1328         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1329         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1330         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1331         (WTR::timeoutSource):
1332         (WTR::TestController::notifyDone):
1333         (WTR::TestController::platformRunUntil):
1334
1335 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1336
1337         [cmake] Add testb3 to the build system
1338         https://bugs.webkit.org/show_bug.cgi?id=151619
1339
1340         Reviewed by Gyuyoung Kim.
1341
1342         * Scripts/build-jsc:
1343
1344 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
1345
1346         [jhbuild] Fix pixman build with clang
1347         https://bugs.webkit.org/show_bug.cgi?id=151441
1348
1349         Reviewed by Carlos Garcia Campos.
1350
1351         * efl/jhbuild.modules:
1352         * gtk/jhbuild.modules:
1353
1354 2015-11-26  David Kilzer  <ddkilzer@apple.com>
1355
1356         Extract prependToEnvironmentVariableList
1357         <http://webkit.org/b/151536>
1358
1359         Reviewed by Daniel Bates.
1360
1361         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
1362                webkitdirs_unittest/prependToEnvironmentVariableList.pl
1363
1364         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
1365         and prependToEnvironmentVariableList.
1366         (appendToEnvironmentVariableList): Simplify variable name.
1367         Switch to use $Config{path_sep}.
1368         (prependToEnvironmentVariableList): Add new method.
1369         (setupMacWebKitEnvironment): Switch to use
1370         prependToEnvironmentVariableList().
1371         (setupIOSWebKitEnvironment): Ditto.
1372
1373         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
1374         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
1375
1376 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1377
1378         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
1379         https://bugs.webkit.org/show_bug.cgi?id=151567
1380
1381         Reviewed by Darin Adler.
1382
1383         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
1384         (on_window_deletion):
1385
1386 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1387
1388         [GTK] Use the network process unconditionally
1389         https://bugs.webkit.org/show_bug.cgi?id=151541
1390
1391         Reviewed by Alex Christensen.
1392
1393         Fix TestInspectorServer test. Do not assume we already have the
1394         title we want when the page has been loaded, since the title is
1395         changed afterwards. So, check if the title has already been set,
1396         and if not wait for it.
1397
1398         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1399         (openRemoteDebuggingSession):
1400
1401 2015-11-23  Alex Christensen  <achristensen@webkit.org>
1402
1403         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
1404         https://bugs.webkit.org/show_bug.cgi?id=151532
1405
1406         Reviewed by Benjamin Poulain.
1407
1408         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1409         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
1410         (TestWebKitAPI::TEST):
1411         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
1412         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
1413         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
1414         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
1415         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
1416         so it was calling a function on a test object that had gone out of scope.
1417         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
1418         but that will become the default soon and that call will be removed.
1419
1420 2015-11-22  David Kilzer  <ddkilzer@apple.com>
1421
1422         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
1423         <http://webkit.org/b/151542>
1424
1425         Reviewed by Daniel Bates.
1426
1427         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1428         (base_url): Use the Port object (already passed in) to give us
1429         the path to the LayoutTests directory, which already checks for a
1430         --layout-tests-directory command-line switch.
1431         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
1432         argument since we can get this from the Port object already
1433         passed in via Port.results_directory().  Also switch to use
1434         Port.layout_tests_dir() to get the LayoutTests directory.
1435
1436         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1437         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
1438         Add test case for custom LayoutTests directory.
1439         (TestWebPlatformTestServer.test_previously_spawned_instance):
1440         Update Port object to set mock results directory as if it was
1441         set on the command-line.  Remove unneeded argument from
1442         WebPlatformTestServer constructor.
1443         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
1444
1445         * Scripts/webkitpy/port/base.py:
1446         (Port.to.start_web_platform_test_server): Remove unneeded
1447         argument from WebPlatformTestServer constuctor.
1448
1449 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1450
1451         [GTK] Some unit tests fail when using the network process
1452         https://bugs.webkit.org/show_bug.cgi?id=151490
1453
1454         Reviewed by Martin Robinson.
1455
1456         Run the soup server in a separate thread in TestResources test to
1457         avoid deadlocks.
1458
1459         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
1460         /webkit2/WebKitWebResource/get-data when using the network process.
1461
1462         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1463         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
1464         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1465         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
1466         present, create a WorkQueue to run the server.
1467         (WebKitTestServer::run): Run the server in the work queue if it
1468         has been created.
1469         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
1470         type into server options as flags.
1471
1472 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1473
1474         [GTK] ImageDiff should normalize the diff image
1475         https://bugs.webkit.org/show_bug.cgi?id=151261
1476
1477         Reviewed by Sergio Villar Senin.
1478
1479         * ImageDiff/gtk/ImageDiff.cpp:
1480         (readPixbufFromStdin): Fix memory leak.
1481         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
1482         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
1483
1484 == Rolled over to ChangeLog-2015-11-21 ==