Tools/ChangeLog

   1 2017-07-05  Matt Lewis  <jlewis3@apple.com>
   2
   3         Unreviewed, rolling out r219128.
   4
   5         Spoke with engineer who originally submitted, Patch for APi
   6         test to follow.
   7
   8         Reverted changeset:
   9
  10         "Unreviewed, rolling out r219070."
  11         https://bugs.webkit.org/show_bug.cgi?id=174082
  12         http://trac.webkit.org/changeset/219128
  13
  14 2017-07-05  Matt Lewis  <jlewis3@apple.com>
  15
  16         Unreviewed, rolling out r219070.
  17
  18         This revision caused consistent failures of the API test
  19         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
  20
  21         Reverted changeset:
  22
  23         "Pasting single words copied to UIPasteboard inserts URLs in
  24         editable areas"
  25         https://bugs.webkit.org/show_bug.cgi?id=174082
  26         http://trac.webkit.org/changeset/219070
  27
  28 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
  29
  30         Remove unused EFL logo from bot watcher dashboard
  31         https://bugs.webkit.org/show_bug.cgi?id=174136
  32
  33         Reviewed by Alexey Proskuryakov.
  34
  35         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
  36         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
  37
  38 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
  39
  40         [GTK] Add more GTK bots to dashboard
  41         https://bugs.webkit.org/show_bug.cgi?id=174129
  42
  43         Reviewed by Carlos Alberto Lopez Perez.
  44
  45         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
  46         them.
  47
  48         This also changes the sort order to put WPE above GTK so that it's not buried under all the
  49         less-essential GTK bots.
  50
  51         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
  52         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
  53         (WebKitBuildbot):
  54
  55 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
  56
  57         [WPE] Add WPE to bot watcher dashboard
  58         https://bugs.webkit.org/show_bug.cgi?id=174119
  59
  60         Reviewed by Alexey Proskuryakov.
  61
  62         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
  63         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
  64         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
  65         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
  66         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
  67         (WebKitBuildbot):
  68         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
  69         (table.queue-grid tr.platform.linux-wpe img.logo):
  70
  71 2017-07-03  Lucas Forschler  <lforschler@apple.com>
  72
  73         https://bugs.webkit.org/show_bug.cgi?id=174105
  74
  75         Reviewed by Stephanie Lewis.
  76
  77         * BuildSlaveSupport/built-product-archive:
  78         (main): Add a -minify parser option
  79         (createZip): Pass along the optional Minify argument if requested
  80         (minifySource): This will trim down archives, logic limited to Mac platform.
  81
  82 2017-07-03  Matt Rajca  <mrajca@apple.com>
  83
  84         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
  85         https://bugs.webkit.org/show_bug.cgi?id=174103
  86
  87         Reviewed by Alex Christensen.
  88
  89         Added an API test.
  90
  91         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
  92         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
  93         (TEST): Added test.
  94         * TestWebKitAPI/cocoa/TestWKWebView.h:
  95         * TestWebKitAPI/cocoa/TestWKWebView.mm:
  96         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
  97
  98 2017-07-03  Matt Lewis  <jlewis3@apple.com>
  99
 100         Unreviewed, rolling out r219103.
 101
 102         Caused multiple build failures.
 103
 104         Reverted changeset:
 105
 106         "Remove copy of ICU headers from WebKit"
 107         https://bugs.webkit.org/show_bug.cgi?id=116407
 108         http://trac.webkit.org/changeset/219103
 109
 110 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
 111
 112         Remove copy of ICU headers from WebKit
 113         https://bugs.webkit.org/show_bug.cgi?id=116407
 114
 115         Reviewed by Alex Christensen.
 116
 117         Use WTF's copy of ICU headers.
 118
 119         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 120         * TestWebKitAPI/Configurations/Base.xcconfig:
 121         * WebKitTestRunner/Configurations/Base.xcconfig:
 122
 123 2017-07-03  Brady Eidson  <beidson@apple.com>
 124
 125         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
 126         https://bugs.webkit.org/show_bug.cgi?id=174073
 127
 128         Reviewed by Andy Estes.
 129
 130         * DumpRenderTree/mac/TestRunnerMac.mm:
 131         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
 132
 133         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
 134         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
 135
 136 2017-07-03  Matt Lewis  <jlewis3@apple.com>
 137
 138         Unreviewed, rolling out r219083.
 139
 140         The revision caused an API failure on all testing platforms.
 141
 142         Reverted changeset:
 143
 144         "[MediaStream] Protect request and web view during gUM client
 145         callback"
 146         https://bugs.webkit.org/show_bug.cgi?id=174096
 147         http://trac.webkit.org/changeset/219083
 148
 149 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
 150
 151         webkitpy: Properly number duplicated crashlogs
 152         https://bugs.webkit.org/show_bug.cgi?id=172002
 153
 154         Reviewed by Aakash Jain.
 155
 156         * Scripts/webkitpy/common/system/crashlogs.py:
 157         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
 158         an increasing integer.
 159         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
 160         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
 161         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
 162         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
 163
 164 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
 165
 166         WebContent processes crash when the network process crashes with pending connection requests
 167         https://bugs.webkit.org/show_bug.cgi?id=174065
 168         <rdar://problem/30359835>
 169
 170         Reviewed by Tim Horton.
 171
 172         Add a API to ensure UI process tries to relaunch a new network process when the network process
 173         crashes with pending network connection requests.
 174
 175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 176         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
 177         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
 178         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
 179         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
 180
 181 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
 182
 183         [MediaStream] Protect request and web view during gUM client callback
 184         https://bugs.webkit.org/show_bug.cgi?id=174096
 185         <rdar://problem/32833102>
 186
 187         Reviewed by Youenn Fablet.
 188
 189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 190         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
 191
 192 2017-07-03  Andy Estes  <aestes@apple.com>
 193
 194         [Xcode] Add an experimental setting to build with ccache
 195         https://bugs.webkit.org/show_bug.cgi?id=173875
 196
 197         Reviewed by Tim Horton.
 198
 199         On systems that already have ccache(1) installed, this patch adds experimental support for
 200         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
 201
 202         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
 203         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
 204         find the toolchain from which to run clang, and then invokes ccache with the required
 205         arguments.
 206
 207         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
 208         precompiled headers to work properly [1].
 209
 210         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
 211         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
 212         during linking.
 213
 214         [1] https://ccache.samba.org/manual.html#_precompiled_headers
 215
 216         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
 217         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
 218         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
 219         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
 220         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
 221         * ccache/README.md: Added.
 222         * ccache/ccache-clang: Added.
 223         * ccache/ccache-clang++: Added.
 224         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
 225
 226 2017-07-03  Alex Christensen  <achristensen@webkit.org>
 227
 228         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
 229         https://bugs.webkit.org/show_bug.cgi?id=174051
 230
 231         Reviewed by Tim Horton.
 232
 233         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
 234         (TestWebKitAPI::TEST_F):
 235
 236 2017-07-03  Matt Lewis  <jlewis3@apple.com>
 237
 238         Unreviewed, rolling out r219024.
 239
 240         This patch cause 3 didferent test to fail.
 241
 242         Reverted changeset:
 243
 244         "REGRESSION(r215096) Queries of URLs with non-special schemes
 245         should not percent-encode single quotes"
 246         https://bugs.webkit.org/show_bug.cgi?id=174051
 247         http://trac.webkit.org/changeset/219024
 248
 249 2017-07-03  Chris Dumez  <cdumez@apple.com>
 250
 251         Drop ResourceLoadStatisticsStore's statisticsLock
 252         https://bugs.webkit.org/show_bug.cgi?id=174080
 253
 254         Reviewed by Brent Fulgham.
 255
 256         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
 257
 258         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
 259         (WTR::TestController::isStatisticsPrevalentResource):
 260         (WTR::TestController::isStatisticsHasHadUserInteraction):
 261         (WTR::TestController::isStatisticsGrandfathered):
 262
 263 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
 264
 265         Pasting single words copied to UIPasteboard inserts URLs in editable areas
 266         https://bugs.webkit.org/show_bug.cgi?id=174082
 267         <rdar://problem/33046992>
 268
 269         Reviewed by Tim Horton.
 270
 271         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
 272
 273         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
 274         (TestWebKitAPI::setUpWebViewForPasteboardTests):
 275         (TestWebKitAPI::TEST):
 276
 277 2017-07-02  Brady Eidson  <beidson@apple.com>
 278
 279         Add API test for all parts of WebKit1 API related to favicons.
 280         https://bugs.webkit.org/show_bug.cgi?id=174069
 281
 282         Reviewed by Andy Estes.
 283
 284         These two API tests cover all WebKit1 API related to icons.
 285
 286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 287         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
 288         (mainResourceData):
 289         (defaultFaviconData):
 290         (customFaviconData):
 291         (imageFromData):
 292         (+[IconLoadingProtocol canInitWithRequest:]):
 293         (+[IconLoadingProtocol canonicalRequestForRequest:]):
 294         (-[IconLoadingProtocol startLoading]):
 295         (-[IconLoadingProtocol stopLoading]):
 296         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
 297         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
 298         (TestWebKitAPI::TEST):
 299
 300 2017-07-01  Dan Bernstein  <mitz@apple.com>
 301
 302         [iOS] Remove code only needed when building for iOS 9.x
 303         https://bugs.webkit.org/show_bug.cgi?id=174068
 304
 305         Reviewed by Tim Horton.
 306
 307         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
 308         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
 309         (WTR::initializeWebViewConfiguration):
 310         * WebKitTestRunner/ios/HIDEventGenerator.mm:
 311         (-[HIDEventGenerator _createIOHIDEventType:]):
 312
 313 2017-07-01  Brady Eidson  <beidson@apple.com>
 314
 315         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
 316         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
 317
 318         Reviewed by Alex Christensen.
 319
 320         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
 321
 322 2017-07-01  Dan Bernstein  <mitz@apple.com>
 323
 324         [macOS] Remove code only needed when building for OS X Yosemite
 325         https://bugs.webkit.org/show_bug.cgi?id=174067
 326
 327         Reviewed by Tim Horton.
 328
 329         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 330         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
 331         * DumpRenderTree/mac/DumpRenderTree.mm:
 332         (setDefaultsToConsistentValuesForTesting):
 333         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
 334         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
 335         * MiniBrowser/Configurations/Base.xcconfig:
 336         * MiniBrowser/Configurations/DebugRelease.xcconfig:
 337         * TestWebKitAPI/Configurations/Base.xcconfig:
 338         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
 339         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
 340         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
 341         (TestWebKitAPI::TEST_F):
 342         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
 343         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
 344         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
 345         (TestWebKitAPI::TEST_F):
 346         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
 347         (TestWebKitAPI::TEST):
 348         * WebKitTestRunner/Configurations/Base.xcconfig:
 349         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
 350         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
 351         (WTR::InjectedBundle::platformInitialize):
 352         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
 353         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
 354
 355 2017-07-01  Chris Dumez  <cdumez@apple.com>
 356
 357         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
 358         https://bugs.webkit.org/show_bug.cgi?id=174060
 359
 360         Reviewed by Brent Fulgham.
 361
 362         Port WebKitTestRunner over to the new Cocoa SPI.
 363
 364         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 365         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
 366         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
 367         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
 368         no-ops since this code runs in the WebContent process, not the
 369         UIProcess.
 370
 371         * WebKitTestRunner/TestController.cpp:
 372         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
 373
 374 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
 375
 376         Unreviewed mac build fix.
 377
 378         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
 379         (TestWebKitAPI::TEST):
 380
 381 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
 382
 383         Add API to get WKActivatedElementInfo
 384         https://bugs.webkit.org/show_bug.cgi?id=174001
 385         <rdar://problem/29165518>
 386
 387         Tests for now SPI to get activatedElementInfo.
 388
 389         Reviewed by Tim Horton.
 390
 391         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 392         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
 393         (TestWebKitAPI::TEST):
 394
 395 2017-06-30  Chris Dumez  <cdumez@apple.com>
 396
 397         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
 398         https://bugs.webkit.org/show_bug.cgi?id=174038
 399
 400         Reviewed by Brent Fulgham.
 401
 402         Fix typo in API name.
 403
 404         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
 405         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 406         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
 407         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 408         * WebKitTestRunner/TestController.cpp:
 409         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
 410         * WebKitTestRunner/TestController.h:
 411         * WebKitTestRunner/TestInvocation.cpp:
 412         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
 413
 414 2017-06-30  Alex Christensen  <achristensen@webkit.org>
 415
 416         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
 417         https://bugs.webkit.org/show_bug.cgi?id=174051
 418         <rdar://problem/33002846>
 419
 420         Reviewed by Tim Horton.
 421
 422         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
 423         (TestWebKitAPI::TEST_F):
 424
 425 2017-06-30  Daniel Bates  <dabates@apple.com>
 426
 427         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
 428         https://bugs.webkit.org/show_bug.cgi?id=165160
 429         <rdar://problem/29451999>
 430
 431         Reviewed by Brady Eidson.
 432
 433         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
 434         for navigations and window creation.
 435
 436         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 437         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
 438         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
 439         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
 440         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
 441         (TEST):
 442
 443 2017-06-29  Jer Noble  <jer.noble@apple.com>
 444
 445         Make Legacy EME API controlled by RuntimeEnabled setting.
 446         https://bugs.webkit.org/show_bug.cgi?id=173994
 447
 448         Reviewed by Sam Weinig.
 449
 450         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
 451
 452 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
 453
 454         Follow-up fix for r218996
 455
 456         Unreviewed infrastructure fix.
 457
 458         Repeated calls to 'ios_version' make the log noisy, memoize the function.
 459
 460         * Scripts/webkitpy/port/ios_simulator.py:
 461         (IOSSimulatorPort): Memoize ios_version().
 462
 463 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
 464
 465         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
 466         https://bugs.webkit.org/show_bug.cgi?id=174017
 467         <rdar://problem/32959782>
 468
 469         Reviewed by Simon Fraser.
 470
 471         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
 472         changes, the caret would appear outside of the iframe.
 473
 474         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 475         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
 476         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
 477         (checkDragCaretRectIsContainedInRect):
 478         (TestWebKitAPI::TEST):
 479         * TestWebKitAPI/ios/DataInteractionSimulator.h:
 480         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
 481         (-[DataInteractionSimulator _resetSimulatedState]):
 482         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
 483         (-[DataInteractionSimulator _advanceProgress]):
 484         (-[DataInteractionSimulator lastKnownDragCaretRect]):
 485
 486 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
 487
 488         Add support for different versions of iOS when loading test expectations
 489         https://bugs.webkit.org/show_bug.cgi?id=173774
 490         <rdar://problem/32951132>
 491
 492         Rubber-stamped by Aakash Jain.
 493
 494         When running layout tests, we should support multiple version of iOS the same way we do Mac.
 495
 496         * Scripts/webkitpy/port/ios.py:
 497         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
 498         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
 499         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
 500         * Scripts/webkitpy/port/ios_device.py:
 501         (IOSDevicePort.ios_version): Ask connected devices for implementation.
 502         * Scripts/webkitpy/port/ios_device_unittest.py:
 503         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
 504         (IOSDeviceTest.test_baseline_searchpath): Ditto.
 505         (IOSDeviceTest.test_expectations_ordering): Ditto.
 506         * Scripts/webkitpy/port/ios_simulator.py:
 507         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
 508         ask the platform.
 509
 510 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
 511
 512         Fontconfig build breaks with glibc 2.15+
 513         https://bugs.webkit.org/show_bug.cgi?id=174019
 514
 515         Reviewed by Carlos Alberto Lopez Perez.
 516
 517         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
 518
 519         * wpe/jhbuild.modules:
 520         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
 521
 522 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
 523
 524         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
 525         https://bugs.webkit.org/show_bug.cgi?id=174010
 526         <rdar://problem/32597802>
 527
 528         Reviewed by Tim Horton.
 529
 530         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
 531         snapshot fails for any reason.
 532
 533         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 534         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
 535         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
 536         (TestWebKitAPI::TEST):
 537
 538 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
 539
 540         AX: Cannot call setValue() on contenteditable or ARIA text controls
 541         https://bugs.webkit.org/show_bug.cgi?id=173520
 542
 543         Reviewed by Ryosuke Niwa.
 544
 545         Add setValue() method to WKTR (already existed in DRT).
 546
 547         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
 548         (WTR::AccessibilityUIElement::setValue):
 549         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
 550         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
 551         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
 552         (WTR::AccessibilityUIElement::setValue):
 553
 554 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
 555
 556         getBoundingClientRect returns wrong value for combination of page zoom and scroll
 557         https://bugs.webkit.org/show_bug.cgi?id=173841
 558         rdar://problem/32983841
 559
 560         Reviewed by Dean Jackson.
 561
 562         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
 563         always did text zooming.
 564
 565         * MiniBrowser/mac/WK1BrowserWindowController.m:
 566         (-[WK1BrowserWindowController zoomIn:]):
 567         (-[WK1BrowserWindowController zoomOut:]):
 568         (-[WK1BrowserWindowController canResetZoom]):
 569         (-[WK1BrowserWindowController resetZoom:]):
 570
 571 2017-06-29  John Wilander  <wilander@apple.com>
 572
 573         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
 574         https://bugs.webkit.org/show_bug.cgi?id=173940
 575         <rdar://problem/33018125>
 576
 577         Reviewed by Brent Fulgham.
 578
 579         This change allows the TestController to turn off
 580         regular resource load statistics telemetry submission
 581         and to manually control when telemetry is calculated
 582         and submitted.
 583
 584         * WebKitTestRunner/TestController.cpp:
 585         (WTR::TestController::initialize):
 586             Turns off automatic resource load statistics telemetry submission.
 587
 588 2017-06-29  Commit Queue  <commit-queue@webkit.org>
 589
 590         Unreviewed, rolling out r218512.
 591         https://bugs.webkit.org/show_bug.cgi?id=173981
 592
 593         "It changes the behavior of the JS API's JSEvaluateScript
 594         which breaks TurboTax" (Requested by saamyjoon on #webkit).
 595
 596         Reverted changeset:
 597
 598         "test262: Completion values for control flow do not match the
 599         spec"
 600         https://bugs.webkit.org/show_bug.cgi?id=171265
 601         http://trac.webkit.org/changeset/218512
 602
 603 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
 604
 605         Add WebKitSystemInterface for iOS 11
 606         https://bugs.webkit.org/show_bug.cgi?id=173936
 607
 608         Reviewed by Lucas Forschler.
 609
 610         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries.
 611
 612 2017-06-28  Keith Miller  <keith_miller@apple.com>
 613
 614         VMTraps has some races
 615         https://bugs.webkit.org/show_bug.cgi?id=173941
 616
 617         Reviewed by Michael Saboff.
 618
 619         Add new testing mode for testing the Watchdog with our stress
 620         tests.
 621
 622         * Scripts/run-jsc-stress-tests:
 623
 624 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
 625
 626         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
 627         https://bugs.webkit.org/show_bug.cgi?id=173877
 628
 629         Reviewed by Brady Eidson.
 630
 631         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
 632         the next tests.
 633
 634         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
 635         (testGetFavicon):
 636
 637 2017-06-28  Tim Horton  <timothy_horton@apple.com>
 638
 639         MobileSafari was constantly using 10-15% CPU viewing a PDF
 640         https://bugs.webkit.org/show_bug.cgi?id=173944
 641         <rdar://problem/33039910>
 642
 643         Reviewed by Simon Fraser.
 644
 645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 646         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
 647         Add a test that we ever call the stable presentation update callback
 648         when we have a WKPDFView up, instead of infinitely looping.
 649
 650 2017-06-28  Alex Christensen  <achristensen@webkit.org>
 651
 652         Prevent displaying URLs with small capital letters
 653         https://bugs.webkit.org/show_bug.cgi?id=173949
 654         <rdar://problem/32952058>
 655
 656         Reviewed by Brent Fulgham.
 657
 658         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
 659         (TestWebKitAPI::TEST):
 660
 661 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
 662
 663         Unreviewed test fix.
 664
 665         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
 666
 667         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
 668
 669 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
 670
 671         Teach ResourceLoadStatistics to recognize changes in the file system
 672         https://bugs.webkit.org/show_bug.cgi?id=173800
 673         <rdar://problem/32937842>
 674
 675         Reviewed by Chris Dumez.
 676
 677         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 678         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
 679         (TestWebKitAPI::FileMonitorTest::tempFilePath):
 680         (TestWebKitAPI::handleFileModification):
 681         (TestWebKitAPI::handleFileDeletion):
 682         (TestWebKitAPI::resetTestState):
 683         (TestWebKitAPI::TEST_F):
 684
 685 2017-06-28  Brady Eidson  <beidson@apple.com>
 686
 687         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
 688         https://bugs.webkit.org/show_bug.cgi?id=173874
 689
 690         Reviewed by Alex Christensen.
 691
 692         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
 693
 694 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
 695
 696         Unreviewed, adding Don Olmstead to contributors.json
 697
 698         * Scripts/webkitpy/common/config/contributors.json:
 699
 700 2017-06-28  Alex Christensen  <achristensen@webkit.org>
 701
 702         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
 703         https://bugs.webkit.org/show_bug.cgi?id=173886
 704         <rdar://problem/32543191>
 705
 706         Reviewed by Andy Estes.
 707
 708         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
 709         (ParsedRange::ParsedRange):
 710         (-[TestSchemeHandler initWithVideoData:]):
 711         (-[TestSchemeHandler webView:startURLSchemeTask:]):
 712         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
 713         (TEST):
 714
 715 2017-06-27  JF Bastien  <jfbastien@apple.com>
 716
 717         WebAssembly: running out of executable memory should throw OoM
 718         https://bugs.webkit.org/show_bug.cgi?id=171537
 719         <rdar://problem/32963338>
 720
 721         Reviewed by Saam Barati.
 722
 723         * Scripts/run-jsc-stress-tests: add a configuration which runs the
 724         tests under limited executable memory and avoids non-WebAssembly
 725         code generation so that we more reliably run out of executable
 726         memory in WebAssembly.
 727
 728 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
 729
 730         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
 731         https://bugs.webkit.org/show_bug.cgi?id=173854
 732         <rdar://problem/32236827>
 733
 734         Reviewed by Ryosuke Niwa and Tim Horton.
 735
 736         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
 737
 738         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 739         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
 740         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
 741         (TestWebKitAPI::TEST):
 742
 743 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
 744
 745         [PAL] Add symbol export macros for PAL
 746         https://bugs.webkit.org/show_bug.cgi?id=171519
 747
 748         Reviewed by Konstantin Tokarev.
 749
 750         * DumpRenderTree/config.h:
 751         * TestWebKitAPI/CMakeLists.txt:
 752         * TestWebKitAPI/config.h:
 753         * WebKitTestRunner/config.h:
 754
 755 2017-06-27  John Wilander  <wilander@apple.com>
 756
 757         Resource Load Statistics: Add telemetry
 758         https://bugs.webkit.org/show_bug.cgi?id=173499
 759         <rdar://problem/32826094>
 760
 761         Reviewed by Brent Fulgham.
 762
 763         Adds three new testRunner functions:
 764         - installStatisticsDidRunTelemetryCallback()
 765         - statisticsFireTelemetryHandler()
 766         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
 767
 768         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
 769         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 770         (WTR::InjectedBundle::didReceiveMessageToPage):
 771         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 772         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
 773         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
 774         (WTR::TestRunner::statisticsFireTelemetryHandler):
 775         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
 776         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 777         * WebKitTestRunner/TestController.cpp:
 778         (WTR::TestController::resetStateToConsistentValues):
 779         (WTR::TestController::statisticsFireTelemetryHandler):
 780         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
 781         * WebKitTestRunner/TestController.h:
 782         * WebKitTestRunner/TestInvocation.cpp:
 783         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
 784
 785 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
 786
 787         Add missing includes to fix compilation error on FreeBSD
 788         https://bugs.webkit.org/show_bug.cgi?id=172919
 789
 790         Reviewed by Mark Lam.
 791
 792         * ImageDiff/cairo/PlatformImageCairo.cpp:
 793
 794 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
 795
 796         Unreviewed, rolling out r218783.
 797
 798         Causing accessibility/mac/setting-attributes-is-
 799         asynchronous.html to crash consistently on mac-wk2 Debug
 800
 801         Reverted changeset:
 802
 803         "AX: Cannot call setValue() on contenteditable or ARIA text
 804         controls"
 805         https://bugs.webkit.org/show_bug.cgi?id=173520
 806         http://trac.webkit.org/changeset/218783
 807
 808 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
 809
 810         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
 811         https://bugs.webkit.org/show_bug.cgi?id=173825
 812
 813         Reviewed by Saam Barati.
 814
 815         * DumpRenderTree/JavaScriptThreading.cpp:
 816         (runJavaScriptThread):
 817         (startJavaScriptThreads):
 818         * DumpRenderTree/mac/DumpRenderTree.mm:
 819         (runThread):
 820         (runPthread):
 821         (testThreadIdentifierMap):
 822
 823 2017-06-26  David Kilzer  <ddkilzer@apple.com>
 824
 825         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
 826         <https://webkit.org/b/173837>
 827
 828         Reviewed by Geoffrey Garen.
 829
 830         The clang static analyzer can't reason about objects that are
 831         assigned to a delegate as +1 retained, and then released
 832         later in a different method when the delegate is cleared.
 833
 834         Instead, use a common idiom where the object setting the
 835         delegate retains it as an instance variable on initialization.
 836         Then the same object clears the delegate and releases its
 837         instance variable during teardown.
 838
 839         Also add EXPECT_TRUE() tests to make sure the delegate objects
 840         match before teardown.
 841
 842         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
 843         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
 844         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
 845         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
 846         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
 847         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
 848
 849 2017-06-26  David Kilzer  <ddkilzer@apple.com>
 850
 851         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
 852         <https://webkit.org/b/173836>
 853
 854         Reviewed by Brady Eidson.
 855
 856         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
 857         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
 858         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
 859         objects in this test.
 860
 861 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
 862
 863         [ATK] Add support for aria-details and aria-errormessage
 864         https://bugs.webkit.org/show_bug.cgi?id=172588
 865
 866         Reviewed by Chris Fleizach.
 867
 868         Add additional methods to test ARIA properties which are exposed via
 869         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
 870         to versions which support the details and error-message relation types.
 871
 872         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
 873         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
 874         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
 875         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
 876         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
 877         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
 878         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
 879         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
 880         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
 881         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
 882         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
 883         * gtk/jhbuild.modules:
 884
 885 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
 886
 887         Unreviewed. Add libfii to GTK+ install dependencies script.
 888
 889         * gtk/install-dependencies:
 890
 891 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
 892
 893         Unreviewed, rolling out r215190.
 894
 895         Broke product select element on GNOME Bugzilla
 896
 897         Reverted changeset:
 898
 899         "[GTK] Misplaced right click menu on web page due to
 900         deprecated gtk_menu_popup()"
 901         https://bugs.webkit.org/show_bug.cgi?id=170553
 902         http://trac.webkit.org/changeset/215190
 903
 904 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
 905
 906         Remove Reflect.enumerate
 907         https://bugs.webkit.org/show_bug.cgi?id=173806
 908
 909         Reviewed by Yusuke Suzuki.
 910
 911         * Scripts/run-jsc-stress-tests:
 912
 913 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
 914
 915         AX: Cannot call setValue() on contenteditable or ARIA text controls
 916         https://bugs.webkit.org/show_bug.cgi?id=173520
 917
 918         Reviewed by Ryosuke Niwa.
 919
 920         Add setValue() method to WKTR (already existed in DRT).
 921
 922         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
 923         (WTR::AccessibilityUIElement::setValue):
 924         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
 925         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
 926         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
 927         (WTR::AccessibilityUIElement::setValue):
 928
 929 2017-06-23  Keith Miller  <keith_miller@apple.com>
 930
 931         Switch VMTraps to use halt instructions rather than breakpoint instructions
 932         https://bugs.webkit.org/show_bug.cgi?id=173677
 933
 934         Reviewed by JF Bastien.
 935
 936         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
 937         (TEST):
 938
 939 2017-06-23  Youenn Fablet  <youenn@apple.com>
 940
 941         Set getUserMedia permission to true by default on WTR
 942         https://bugs.webkit.org/show_bug.cgi?id=173610
 943
 944         Reviewed by Alex Christensen.
 945
 946         Adding a way to reset the getUserMedia permission to pending.
 947
 948         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
 949         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 950         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
 951         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 952         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 953         (WTR::TestRunner::setUserMediaPermissionAsUnset):
 954         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 955         * WebKitTestRunner/TestController.cpp:
 956         (WTR::TestController::resetStateToConsistentValues):
 957         (WTR::TestController::setUserMediaPermissionAsUnset):
 958         * WebKitTestRunner/TestController.h:
 959         * WebKitTestRunner/TestInvocation.cpp:
 960         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 961
 962 2017-06-23  Alex Christensen  <achristensen@webkit.org>
 963
 964         Add SPI to WKURLSchemeTask for redirection
 965         https://bugs.webkit.org/show_bug.cgi?id=173730
 966
 967         Reviewed by Brady Eidson.
 968
 969         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
 970         (-[SchemeHandler webView:startURLSchemeTask:]):
 971         (-[SchemeHandler webView:stopURLSchemeTask:]):
 972         (TEST):
 973         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
 974         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
 975         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
 976         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
 977         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
 978
 979 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
 980
 981         [WPE] Use JSC API to send script messages from web extension in tests
 982         https://bugs.webkit.org/show_bug.cgi?id=173757
 983
 984         Reviewed by Žan Doberšek.
 985
 986         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
 987         to run postMessage().
 988
 989         Fixes: /wpe/WebKitSecurityManager/file-xhr
 990                /wpe/WebKitConsoleMessage/console-api
 991                /wpe/WebKitConsoleMessage/js-exception
 992                /wpe/WebKitConsoleMessage/network-error
 993                /wpe/WebKitConsoleMessage/security-error
 994
 995         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
 996         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
 997         (beforeAll): Ditto.
 998         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
 999         (testWebContextSecurityFileXHR): Ditto.
1000         (beforeAll): Ditto.
1001         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1002         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
1003         (pageCreatedCallback): Remove ifdefs.
1004
1005 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1006
1007         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
1008
1009         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
1010         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
1011         doesn't exist yet in WPE.
1012
1013         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1014         (testWebViewJavaScriptDialogs):
1015         (testWebViewWindowProperties):
1016
1017 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1018
1019         [GTK] Upgrade pixman and cairo in jhbuild
1020         https://bugs.webkit.org/show_bug.cgi?id=173710
1021
1022         Reviewed by Carlos Alberto Lopez Perez.
1023
1024         * gtk/jhbuild.modules:
1025
1026 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1027
1028         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
1029         https://bugs.webkit.org/show_bug.cgi?id=173711
1030
1031         Reviewed by Carlos Alberto Lopez Perez.
1032
1033         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
1034         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
1035
1036         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1037         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
1038
1039 2017-06-22  David Kilzer  <ddkilzer@apple.com>
1040
1041         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
1042         <https://webkit.org/b/173721>
1043
1044         Reviewed by Joseph Pecoraro.
1045
1046         Use RetainPtr<> to create NSMutableDictionary and NSNumber
1047         objects to fix leaks and to avoid the autoreleasepool.
1048
1049         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
1050         (TEST):
1051
1052 2017-06-22  Matt Lewis  <jlewis3@apple.com>
1053
1054         Unreviewed, rolling out r218633.
1055
1056         The test is failing frequently on Sierra Debug and Windows
1057
1058         Reverted changeset:
1059
1060         "AX: Cannot call setValue() on contenteditable or ARIA text
1061         controls"
1062         https://bugs.webkit.org/show_bug.cgi?id=173520
1063         http://trac.webkit.org/changeset/218633
1064
1065 2017-06-22  David Kilzer  <ddkilzer@apple.com>
1066
1067         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
1068         <https://webkit.org/b/173690>
1069
1070         Reviewed by Chris Dumez.
1071
1072         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
1073         ownership of malloc()-ed memory, then frees it when it's
1074         released.  These tests were passing global variables into the
1075         method, which is not malloc()-ed memory, which violates the API
1076         contract.
1077
1078         The fix is to switch to use
1079         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
1080         NO for the last argument.
1081
1082         Caught by the clang static analyzer.
1083
1084         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
1085         (TEST):
1086         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1087         (TEST):
1088
1089 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1090
1091         [GTK] Upgrade Harfbuzz to version 1.4.2
1092         https://bugs.webkit.org/show_bug.cgi?id=173592
1093
1094         Reviewed by Carlos Alberto Lopez Perez.
1095
1096         * gtk/jhbuild.modules:
1097
1098 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1099
1100         [WPE] Update WPEBackend-mesa
1101         https://bugs.webkit.org/show_bug.cgi?id=173705
1102
1103         Reviewed by Carlos Alberto Lopez Perez.
1104
1105         A crash has been fixed, needed for unit tests to work.
1106
1107         * wpe/jhbuild.modules:
1108
1109 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1110
1111         Remove unused coordinated graphics C API
1112         https://bugs.webkit.org/show_bug.cgi?id=173706
1113
1114         Reviewed by Žan Doberšek.
1115
1116         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
1117         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
1118         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
1119         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
1120         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
1121         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
1122
1123 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1124
1125         [WPE] Build glib API tests
1126         https://bugs.webkit.org/show_bug.cgi?id=173702
1127
1128         Reviewed by Žan Doberšek.
1129
1130         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
1131         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
1132         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
1133         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
1134         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
1135         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
1136         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
1137         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
1138         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
1139         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
1140         and implement the missing features.
1141
1142         * CMakeLists.txt:
1143         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
1144         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
1145         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1146         (testAutomationSessionRequestSession):
1147         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
1148         (testWebKitWebViewSessionState):
1149         (testWebKitWebViewSessionStateWithFormData):
1150         (testWebKitWebViewNavigationAfterSessionRestore):
1151         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1152         (beforeAll):
1153         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1154         (testCookieManagerEphemeral):
1155         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1156         (testBlobDownload):
1157         (beforeAll):
1158         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
1159         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1160         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1161         (testProcessPerWebView):
1162         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1163         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1164         (testWebViewCreateNavigationData):
1165         (testWebViewJavaScriptDialogs):
1166         (testWebViewWindowProperties):
1167         (testWebViewMouseTarget):
1168         (testWebViewGeolocationPermissionRequests):
1169         (testWebViewUserMediaPermissionRequests):
1170         (testWebViewAudioOnlyUserMediaPermissionRequests):
1171         (testWebViewFileChooserRequest):
1172         (beforeAll):
1173         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1174         (beforeAll):
1175         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1176         (testPrivateBrowsing):
1177         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
1178         (testFindControllerHide):
1179         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
1180         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1181         (testWebKitSettings):
1182         (beforeAll):
1183         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1184         (testWebViewNewWithUserContentManager):
1185         (beforeAll):
1186         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1187         (testWebContextEphemeral):
1188         (testWebContextProxySettings):
1189         (beforeAll):
1190         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1191         (testWebViewWebContext):
1192         (testWebViewWebContextLifetime):
1193         (testWebViewEphemeral):
1194         (testWebViewSettings):
1195         (testWebViewCanShowMIMEType):
1196         (testWebViewPageVisibility):
1197         (testWebViewIsPlayingAudio):
1198         (beforeAll):
1199         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1200         (testWebsiteDataEphemeral):
1201         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1202         (documentLoadedCallback):
1203         (pageCreatedCallback):
1204         (methodCallCallback):
1205         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
1206         * TestWebKitAPI/glib/CMakeLists.txt:
1207         * TestWebKitAPI/glib/PlatformGTK.cmake:
1208         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1209         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1210         (main):
1211         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1212         (Test::adoptView):
1213         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1214         (WebKitTestBus::run):
1215         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1216         (WebViewTest::~WebViewTest):
1217         (WebViewTest::initializeWebView):
1218         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
1219         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
1220         (WebViewTest::platformDestroy):
1221         (WebViewTest::platformInitializeWebView):
1222         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
1223         (WebViewTest::resizeView):
1224         (WebViewTest::hideView):
1225         (parentWindowMapped):
1226         (WebViewTest::showInWindow):
1227         (WebViewTest::showInWindowAndWaitUntilMapped):
1228         (WebViewTest::mouseMoveTo):
1229         (WebViewTest::clickMouseButton):
1230         (WebViewTest::emitPopupMenuSignal):
1231         (WebViewTest::keyStroke):
1232         (WebViewTest::doMouseButtonEvent):
1233         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
1234         (WebViewTest::platformDestroy):
1235         (WebViewTest::platformInitializeWebView):
1236         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
1237         (WebViewTest::resizeView):
1238         (WebViewTest::hideView):
1239         (WebViewTest::mouseMoveTo):
1240         (WebViewTest::clickMouseButton):
1241         (WebViewTest::keyStroke):
1242
1243 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1244
1245         [GTK] Move WebKit2 GLib API tests to glib directories
1246         https://bugs.webkit.org/show_bug.cgi?id=173642
1247
1248         Reviewed by Žan Doberšek.
1249
1250         * CMakeLists.txt:
1251         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
1252         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
1253         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
1254         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
1255         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
1256         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
1257         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
1258         (testWebKitConsoleMessageNetworkError):
1259         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
1260         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
1261         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
1262         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
1263         (testLoadFromGResource):
1264         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
1265         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
1266         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
1267         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
1268         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
1269         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
1270         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
1271         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
1272         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
1273         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
1274         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
1275         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
1276         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
1277         (testWebViewRunJavaScript):
1278         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
1279         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
1280         (registerGResource):
1281         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
1282         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
1283         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
1284         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
1285         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
1286         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
1287         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
1288         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
1289         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
1290         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
1291         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
1292         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
1293         * TestWebKitAPI/glib/CMakeLists.txt: Added.
1294         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
1295         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
1296         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
1297         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
1298         (registerGResource):
1299         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
1300         (Test::getResourcesDir):
1301         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
1302         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
1303         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
1304         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
1305         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
1306         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
1307
1308 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1309
1310         [WPE] Add initial web extensions API
1311         https://bugs.webkit.org/show_bug.cgi?id=173640
1312
1313         Reviewed by Žan Doberšek.
1314
1315         Add style checker exceptions for WPE web extensions API files.
1316
1317         * Scripts/webkitpy/style/checker.py:
1318
1319 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1320
1321         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
1322         https://bugs.webkit.org/show_bug.cgi?id=173659
1323         <rdar://problem/32879788>
1324
1325         Reviewed by Tim Horton.
1326
1327         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
1328
1329         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
1330
1331         Augment this test page to log dragend and dragstart events on the drag source as well.
1332
1333         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1334         (checkStringArraysAreEqual):
1335         (TestWebKitAPI::TEST):
1336
1337 2017-06-21  Antoine Quint  <graouts@apple.com>
1338
1339         Ensure DRT always logs rAF suspension debugging code
1340         https://bugs.webkit.org/show_bug.cgi?id=173681
1341
1342         Reviewed by Tim "Mr. T" Horton.
1343
1344         * DumpRenderTree/mac/DumpRenderTree.mm:
1345         (resetWebPreferencesToConsistentValues):
1346
1347 2017-06-21  Chris Dumez  <cdumez@apple.com>
1348
1349         Allow constructing a WTF:Function from a function pointer
1350         https://bugs.webkit.org/show_bug.cgi?id=173660
1351
1352         Reviewed by Alex Christensen.
1353
1354         Add API test coverage.
1355
1356         * TestWebKitAPI/Tests/WTF/Function.cpp:
1357         (TestWebKitAPI::returnThree):
1358         (TestWebKitAPI::returnFour):
1359         (TestWebKitAPI::returnPassedValue):
1360         (TestWebKitAPI::TEST):
1361
1362 2017-06-21  Antoine Quint  <graouts@apple.com>
1363
1364         Add logging to identify when the Page suspends scripted animations
1365         https://bugs.webkit.org/show_bug.cgi?id=173626
1366
1367         Reviewed by Tim Horton.
1368
1369         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
1370
1371         * DumpRenderTree/mac/DumpRenderTree.mm:
1372         (resetWebPreferencesToConsistentValues):
1373
1374 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
1375
1376         AX: Cannot call setValue() on contenteditable or ARIA text controls
1377         https://bugs.webkit.org/show_bug.cgi?id=173520
1378
1379         Reviewed by Ryosuke Niwa.
1380
1381         Add setValue() method to WKTR (already existed in DRT).
1382
1383         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1384         (WTR::AccessibilityUIElement::setValue):
1385         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1386         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1387         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1388         (WTR::AccessibilityUIElement::setValue):
1389
1390 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
1391
1392         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
1393         as one of the dependencies required to build the product.
1394
1395         Rubber-stamped by Carlos Garcia Campos.
1396
1397         * gtk/install-dependencies:
1398         * wpe/install-dependencies:
1399
1400 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
1401
1402         Disable font variations on macOS Sierra and iOS 10
1403         https://bugs.webkit.org/show_bug.cgi?id=173618
1404         <rdar://problem/32879164>
1405
1406         Reviewed by Jon Lee.
1407
1408         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1409
1410 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1411
1412         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
1413         https://bugs.webkit.org/show_bug.cgi?id=173578
1414         <rdar://problem/32825028>
1415
1416         Reviewed by Tim Horton.
1417
1418         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
1419         a custom popover does not cause dragging to fail when the popover is presented.
1420
1421         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1422         (-[DataInteractionSimulator _advanceProgress]):
1423
1424 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1425
1426         [WPE] Add initial implementation of glib API
1427         https://bugs.webkit.org/show_bug.cgi?id=173546
1428
1429         Reviewed by Žan Doberšek.
1430
1431         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
1432         include WPE glib API files.
1433
1434         * Scripts/webkitperl/FeatureList.pm:
1435         * Scripts/webkitpy/style/checker.py:
1436         * Scripts/webkitpy/style/checkers/cpp.py:
1437         (check_identifier_name_in_declaration):
1438
1439 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1440
1441         [GTK] Upgrade to ICU to version 57.1
1442         https://bugs.webkit.org/show_bug.cgi?id=173538
1443
1444         Reviewed by Žan Doberšek.
1445
1446         * gtk/jhbuild.modules:
1447
1448 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1449
1450         [GTK] Remove unneeded modules from the jhbuild
1451         https://bugs.webkit.org/show_bug.cgi?id=170540
1452
1453         Reviewed by Michael Catanzaro.
1454
1455         We are building libxslt and libffi that we don't really need to build from sources.
1456
1457         * gtk/jhbuild.modules:
1458
1459 2017-06-19  Frederic Wang  <fwang@igalia.com>
1460
1461         [Mac] Add an experimental feature setting for async frame scrolling
1462         https://bugs.webkit.org/show_bug.cgi?id=173359
1463
1464         Reviewed by Simon Fraser.
1465
1466         * DumpRenderTree/mac/DumpRenderTree.mm:
1467         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
1468         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
1469         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1470         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
1471
1472 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
1473
1474         Unreviewed, adding myself to contributors.json
1475
1476         * Scripts/webkitpy/common/config/contributors.json:
1477
1478 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
1479
1480         test262: Completion values for control flow do not match the spec
1481         https://bugs.webkit.org/show_bug.cgi?id=171265
1482
1483         Reviewed by Saam Barati.
1484
1485         * Scripts/run-jsc-stress-tests:
1486         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
1487
1488 2017-06-19  Zalan Bujtas  <zalan@apple.com>
1489
1490         Opening certain mails brings up a mail that grows indefinitely.
1491         https://bugs.webkit.org/show_bug.cgi?id=173562
1492         <rdar://problem/32766579>
1493
1494         Reviewed by Tim Horton.
1495
1496         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
1497         (TEST):
1498
1499 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1500
1501         [iOS DnD] Support .zip archives for file uploads via drag and drop
1502         https://bugs.webkit.org/show_bug.cgi?id=173511
1503         <rdar://problem/32521025>
1504
1505         Reviewed by Tim Horton.
1506
1507         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
1508         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
1509
1510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1511         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
1512         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1513         (testZIPArchive):
1514         (TestWebKitAPI::TEST):
1515
1516 2017-06-18  Darin Adler  <darin@apple.com>
1517
1518         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
1519         https://bugs.webkit.org/show_bug.cgi?id=173526
1520
1521         Reviewed by Sam Weinig.
1522
1523         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
1524         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1525
1526         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
1527         tests for assignment before destruction ones.
1528
1529         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
1530         as a function, so it can be used in WTF::Function tests.
1531
1532         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
1533         Added tests for swap and for assignment before deref.
1534
1535         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
1536         to inline everything. Also removed the unnecessary clearing of the log every time
1537         the DerivedRefLogger constructor is called.
1538         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
1539
1540         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
1541         Added tests for assignment before deref and similar for releaseNonNull.
1542
1543 2017-06-19  Sam Weinig  <sam@webkit.org>
1544
1545         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
1546         https://bugs.webkit.org/show_bug.cgi?id=173513
1547
1548         Reviewed by Alex Christensen.
1549
1550         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1551         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1552         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
1553
1554 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
1555
1556         [Win] fast/dom/assign-to-window-status.html is flaky.
1557         https://bugs.webkit.org/show_bug.cgi?id=173512
1558
1559         Reviewed by Alex Christensen.
1560
1561         We should not dump status callbacks when test is done.
1562
1563         * DumpRenderTree/win/UIDelegate.cpp:
1564         (UIDelegate::setStatusText):
1565
1566 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1567
1568         [WPE][JHBuild] Update WPEBackend-mesa
1569         https://bugs.webkit.org/show_bug.cgi?id=173433
1570
1571         Unreviewed.
1572
1573         Update WPEBackend-mesa back (like it was done originally in r218344)
1574         after fixing the issue with the DISPLAY environment variables that
1575         caused the crashes.
1576
1577         * wpe/jhbuild.modules:
1578
1579 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1580
1581         Rename unit test file after r218482
1582         https://bugs.webkit.org/show_bug.cgi?id=173483
1583
1584         Unreviewed.
1585
1586         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
1587
1588 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1589
1590         Unreviewed. Fix wrong style checker condition added in r218487.
1591
1592         * Scripts/webkitpy/style/checkers/cpp.py:
1593         (check_identifier_name_in_declaration):
1594
1595 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
1596
1597         Missing <functional> includes make builds fail with GCC 7.x
1598         https://bugs.webkit.org/show_bug.cgi?id=173544
1599
1600         Unreviewed gardening.
1601
1602         Fix compilation with GCC 7.
1603
1604         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1605         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1606
1607 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1608
1609         [GTK] Move GTK+ API files that could be shared to glib dirs
1610         https://bugs.webkit.org/show_bug.cgi?id=173545
1611
1612         Reviewed by Žan Doberšek.
1613
1614         Update paths of GTK+ API in watchlist and style checker.
1615
1616         * Scripts/webkitpy/common/config/watchlist:
1617         * Scripts/webkitpy/style/checker.py:
1618         * Scripts/webkitpy/style/checkers/cpp.py:
1619         (check_identifier_name_in_declaration):
1620
1621 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1622
1623         Port setup_environ_for_server should not set environment variables related with the driver.
1624         https://bugs.webkit.org/show_bug.cgi?id=173483
1625
1626         Reviewed by Carlos Garcia Campos.
1627
1628         The port setup_environ_for_server() should not set environment variables
1629         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
1630         This varibles should be only set on the driver setup_environ_for_test().
1631
1632         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
1633         into the test environment even when running the tests with a driver
1634         that is not the Xorg or Xvfb one.
1635
1636         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
1637         (Port.to.setup_environ_for_server):
1638         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
1639         (Driver._setup_environ_for_driver):
1640         * Scripts/webkitpy/port/driver_unittest.py:
1641         (DriverTest.test_setup_environ_for_test):
1642         (DriverTest):
1643         (DriverTest.test_setup_environ_base_vars):
1644         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
1645         (GtkPort.setup_environ_for_server):
1646         * Scripts/webkitpy/port/wayland_unittest.py: Added.
1647         (WaylandDriverTest):
1648         (WaylandDriverTest.make_driver):
1649         (WaylandDriverTest.make_environment):
1650         (WaylandDriverTest.test_checkdriver):
1651         (WaylandDriverTest.test_environment_needed_variables):
1652         (WaylandDriverTest.test_environment_forbidden_variables):
1653         (WaylandDriverTest.test_environment_optional_variables):
1654         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
1655         (WaylandDriver.check_driver):
1656         (WaylandDriver._setup_environ_for_test):
1657         * Scripts/webkitpy/port/xorgdriver.py:
1658         (XorgDriver.check_driver):
1659         (XorgDriver._setup_environ_for_test):
1660         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
1661         (XorgDriverTest):
1662         (XorgDriverTest.make_driver):
1663         (XorgDriverTest.make_environment):
1664         (XorgDriverTest.test_checkdriver):
1665         (XorgDriverTest.test_environment_needed_variables):
1666         (XorgDriverTest.test_environment_forbidden_variables):
1667         (XorgDriverTest.test_environment_optional_variables):
1668         * Scripts/webkitpy/port/xvfbdriver.py:
1669         (XvfbDriver._setup_environ_for_test):
1670         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1671         (XvfbDriverTest.assertDriverStartSuccessful):
1672
1673
1674 2017-05-14 Frederic Wang  <fwang@igalia.com>
1675
1676         Add heuristic to avoid flattening "fullscreen" iframes
1677         https://bugs.webkit.org/show_bug.cgi?id=171914
1678
1679         Reviewed by Simon Fraser.
1680
1681         * DumpRenderTree/mac/DumpRenderTree.mm:
1682         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
1683
1684 2017-06-18  Chris Dumez  <cdumez@apple.com>
1685
1686         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
1687         https://bugs.webkit.org/show_bug.cgi?id=173522
1688         <rdar://problem/31185739>
1689
1690         Reviewed by Darin Adler.
1691
1692         Add API test for re-entering Function's assignment operators.
1693
1694         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1695         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
1696         (TestWebKitAPI::TestObject::TestObject):
1697         (TestWebKitAPI::TestObject::~TestObject):
1698         (TestWebKitAPI::TestObject::operator()):
1699         (TestWebKitAPI::TEST):
1700
1701 2017-06-16  Dan Bernstein  <mitz@apple.com>
1702
1703         [Cocoa] Some declarations have missing or incorrect availability attributes
1704         https://bugs.webkit.org/show_bug.cgi?id=173508
1705
1706         Reviewed by Tim Horton.
1707
1708         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
1709         (TestWebKitAPI::TEST): Updated for renames.
1710
1711 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1712
1713         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
1714         https://bugs.webkit.org/show_bug.cgi?id=173366
1715         <rdar://problem/32767014>
1716
1717         Reviewed by Tim Horton.
1718
1719         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
1720         change in behavior.
1721
1722         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1723         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1724         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
1725         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
1726         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
1727         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
1728         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
1729         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
1730         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
1731         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
1732         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
1733         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
1734         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
1735         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
1736         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1737         (-[MockDragDropSession initWithItems:location:window:]):
1738         (-[MockDragDropSession allowsMoveOperation]):
1739         (-[MockDragDropSession isRestrictedToDraggingApplication]):
1740         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
1741         (-[MockDragDropSession canLoadObjectsOfClass:]):
1742         (-[MockDragDropSession canLoadObjectsOfClasses:]):
1743         (-[MockDragDropSession items]):
1744         (-[MockDragDropSession setItems:]):
1745         (-[MockDragDropSession locationInView:]):
1746         (-[MockDataOperationSession initWithProviders:location:window:]):
1747         (-[MockDataOperationSession session]):
1748         (-[MockDataOperationSession isLocal]):
1749         (-[MockDataOperationSession progress]):
1750         (-[MockDataOperationSession setProgressIndicatorStyle:]):
1751         (-[MockDataOperationSession progressIndicatorStyle]):
1752         (-[MockDataOperationSession operationMask]):
1753         (-[MockDataOperationSession localDragSession]):
1754         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
1755         (-[MockDataOperationSession canCreateItemsOfClass:]):
1756         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
1757         (-[MockDataInteractionSession initWithWindow:]):
1758         (-[MockDataInteractionSession localOperationMask]):
1759         (-[MockDataInteractionSession externalOperationMask]):
1760         (-[MockDataInteractionSession session]):
1761         (-[DataInteractionSimulator _advanceProgress]):
1762
1763 2017-06-16  Alex Christensen  <achristensen@webkit.org>
1764
1765         Show punycode to user if a URL has dotless i or j followed by diacritic dot
1766         https://bugs.webkit.org/show_bug.cgi?id=173431
1767
1768         Reviewed by Darin Adler.
1769
1770         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1771         (TestWebKitAPI::TEST):
1772
1773 2017-06-16  Chris Dumez  <cdumez@apple.com>
1774
1775         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
1776         https://bugs.webkit.org/show_bug.cgi?id=173472
1777         <rdar://problem/28858817>
1778
1779         Reviewed by Brady Eidson.
1780
1781         Add API test coverage.
1782
1783         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1784         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
1785         (TEST):
1786
1787 2017-06-16  Brady Eidson  <beidson@apple.com>
1788
1789         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
1790         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
1791
1792         Reviewed by Daniel Bates.
1793
1794         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
1795
1796 2017-06-16  Chris Dumez  <cdumez@apple.com>
1797
1798         DRT fails to reset page visibility between tests
1799         https://bugs.webkit.org/show_bug.cgi?id=173485
1800
1801         Reviewed by Alexey Proskuryakov.
1802
1803         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
1804         Fix this to address flakiness.
1805
1806         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
1807         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
1808         The test became flaky without the DRT change and was no longer flaky with the DRT
1809         change.
1810
1811         WebKitTestRunner already does this.
1812
1813         * DumpRenderTree/mac/DumpRenderTree.mm:
1814         (resetWebViewToConsistentStateBeforeTesting):
1815
1816 2017-06-16  Alex Christensen  <achristensen@webkit.org>
1817
1818         Implement basic authentication in MiniBrowser
1819         https://bugs.webkit.org/show_bug.cgi?id=173443
1820
1821         Reviewed by Tim Horton.
1822
1823         * MiniBrowser/mac/WK2BrowserWindowController.m:
1824         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
1825
1826 2017-06-16  Jer Noble  <jer.noble@apple.com>
1827
1828         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1829         https://bugs.webkit.org/show_bug.cgi?id=173398
1830         <rdar://problem/32592961>
1831
1832         Reviewed by Eric Carlson.
1833
1834         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1835         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1836         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1837         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1838         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1839         (TestWebKitAPI::TEST):
1840         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1841
1842 2017-06-16  Matt Lewis  <jlewis3@apple.com>
1843
1844         Unreviewed, rolling out r218375.
1845
1846         The API test MediaStreamTrackDetached is still timing out
1847         after the patch
1848
1849         Reverted changeset:
1850
1851         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1852         reports no recording to WebKit clients"
1853         https://bugs.webkit.org/show_bug.cgi?id=173398
1854         http://trac.webkit.org/changeset/218375
1855
1856 2017-06-15  Jer Noble  <jer.noble@apple.com>
1857
1858         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1859         https://bugs.webkit.org/show_bug.cgi?id=173398
1860         <rdar://problem/32592961>
1861
1862         Reviewed by Eric Carlson.
1863
1864         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1865         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1866         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1867         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1868         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1869         (TestWebKitAPI::TEST):
1870         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1871
1872 2017-06-15  Matt Lewis  <jlewis3@apple.com>
1873
1874         Unreviewed, rolling out r218365.
1875
1876         The revision caused API timeouts on all builds.
1877
1878         Reverted changeset:
1879
1880         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1881         reports no recording to WebKit clients"
1882         https://bugs.webkit.org/show_bug.cgi?id=173398
1883         http://trac.webkit.org/changeset/218365
1884
1885 2017-06-15  Jer Noble  <jer.noble@apple.com>
1886
1887         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1888         https://bugs.webkit.org/show_bug.cgi?id=173398
1889         <rdar://problem/32592961>
1890
1891         Reviewed by Eric Carlson.
1892
1893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1894         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1895         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1896         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1897         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1898         (TestWebKitAPI::TEST):
1899         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1900
1901 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1902
1903         REGRESSION(r218344): [WPE] Thousands of layout test crashes
1904         https://bugs.webkit.org/show_bug.cgi?id=173433
1905
1906         Unreviewed.
1907
1908         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
1909
1910 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1911
1912         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
1913         https://bugs.webkit.org/show_bug.cgi?id=173061
1914
1915         Reviewed by Žan Doberšek.
1916
1917         Launch dyz <https://github.com/Igalia/dyz> with the script
1918         run-minibrowser for the wpe port. It is now built as part of the
1919         WPE dependencies with JHBuild.
1920
1921         * Scripts/run-minibrowser:
1922         * Scripts/webkitdirs.pm:
1923         (launcherPath):
1924         (launcherName):
1925         * wpe/install-dependencies: Luajit is needed for building dyz.
1926         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
1927
1928 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1929
1930         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
1931         https://bugs.webkit.org/show_bug.cgi?id=173338
1932         <rdar://problem/32777720>
1933
1934         Reviewed by Tim Horton.
1935
1936         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
1937         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
1938         these remaining items on drop.
1939
1940         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1941         (TestWebKitAPI::TEST):
1942         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1943         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1944
1945         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
1946
1947         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
1948
1949 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
1950
1951         [Win] Crash in accessibility layout test.
1952         https://bugs.webkit.org/show_bug.cgi?id=173401
1953
1954         Reviewed by Brent Fulgham.
1955
1956         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
1957         member will be automatically released when the _variant_t object goes out of scope if the vt member
1958         does not equal VT_UNKNOWN | VT_BYREF.
1959         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx.
1960
1961         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1962         (AccessibilityUIElement::titleUIElement):
1963
1964 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1965
1966         [GTK] Add API to allow overriding popup menus
1967         https://bugs.webkit.org/show_bug.cgi?id=172905
1968
1969         Reviewed by Michael Catanzaro.
1970
1971         Add a unit test to check the new API.
1972
1973         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1974         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
1975         (OptionMenuTest::OptionMenuTest):
1976         (OptionMenuTest::~OptionMenuTest):
1977         (OptionMenuTest::destroyMenu):
1978         (OptionMenuTest::showOptionMenuCallback):
1979         (OptionMenuTest::menuCloseCallback):
1980         (OptionMenuTest::showOptionMenu):
1981         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
1982         (OptionMenuTest::close):
1983         (OptionMenuTest::activateItem):
1984         (OptionMenuTest::selectItem):
1985         (testOptionMenuSimple):
1986         (testOptionMenuGroups):
1987         (testOptionMenuActivate):
1988         (testOptionMenuSelect):
1989         (beforeAll):
1990         (afterAll):
1991
1992 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
1993
1994         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
1995         https://bugs.webkit.org/show_bug.cgi?id=173399
1996
1997         Reviewed by Per Arne Vollan.
1998
1999         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
2000         Curl port needs to do nothing because libcurl doesn't have disk cache.
2001
2002         * DumpRenderTree/win/DumpRenderTree.cpp:
2003         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
2004         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
2005
2006 2017-06-14  Tomas Popela  <tpopela@redhat.com>
2007
2008         [GTK] integer expression expected if running Tools/gtk/install-dependencies
2009         https://bugs.webkit.org/show_bug.cgi?id=173356
2010
2011         Reviewed by Michael Catanzaro.
2012
2013         Use the correct operator to compare the strings.
2014
2015         * gtk/install-dependencies:
2016
2017 2017-06-14  Commit Queue  <commit-queue@webkit.org>
2018
2019         Unreviewed, rolling out r218285.
2020         https://bugs.webkit.org/show_bug.cgi?id=173391
2021
2022         API test fails on iOS (Requested by alexchristensen on
2023         #webkit).
2024
2025         Reverted changeset:
2026
2027         "Add SPI for immediate injection of user scripts"
2028         https://bugs.webkit.org/show_bug.cgi?id=173342
2029         http://trac.webkit.org/changeset/218285
2030
2031 2017-06-14  Chris Dumez  <cdumez@apple.com>
2032
2033         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
2034         https://bugs.webkit.org/show_bug.cgi?id=173384
2035         <rdar://problem/32723779>
2036
2037         Reviewed by Dan Bernstein.
2038
2039         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2040         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
2041         Add API test coverage.
2042
2043         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2044         (TestWebKitAPI::Util::sleep):
2045         Update implementation of Util::sleep() so that we actually run the run loop.
2046         Otherwise, we don't process events while sleeping.
2047
2048 2017-06-14  Alex Christensen  <achristensen@webkit.org>
2049
2050         Add SPI for immediate injection of user scripts
2051         https://bugs.webkit.org/show_bug.cgi?id=173342
2052         <rdar://problem/29202285>
2053
2054         Reviewed by Brady Eidson.
2055
2056         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2057         (waitForMessage):
2058         (TEST):
2059
2060 2017-06-14  Claudio Saavedra  <csaavedra@igalia.com>
2061
2062         Add WPE to the flakiness dashboard
2063         https://bugs.webkit.org/show_bug.cgi?id=173365
2064
2065         Reviewed by Carlos Alberto Lopez Perez.
2066
2067         * TestResultServer/static-dashboards/builders.jsonp:
2068         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2069         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2070         (resetGlobals):
2071         * TestResultServer/static-dashboards/loader_unittests.js:
2072
2073 2017-06-14  Brady Eidson  <beidson@apple.com>
2074
2075         WKIconLoadingDelegate never gets asked about the default favicon if touch/touch-precomposed icons are in the <head>
2076         <rdar://problem/32614328> and https://bugs.webkit.org/show_bug.cgi?id=173376
2077
2078         Reviewed by Alex Christensen.
2079
2080         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2081         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Added.
2082         (-[IconLoadingDelegate webView:shouldLoadIconWithParameters:completionHandler:]):
2083         (-[IconLoadingSchemeHandler initWithData:mimeType:]):
2084         (-[IconLoadingSchemeHandler webView:startURLSchemeTask:]):
2085         (-[IconLoadingSchemeHandler webView:stopURLSchemeTask:]):
2086         (TEST):
2087
2088 2017-06-14  Tim Horton  <timothy_horton@apple.com>
2089
2090         WKContentViewEditingActions API test always fails
2091         https://bugs.webkit.org/show_bug.cgi?id=173374
2092
2093         Reviewed by Wenson Hsieh.
2094
2095         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
2096         (TEST):
2097         selectAll isn't working, because canPerformAction for selectAll returns NO
2098         if selectionIsNone (which is true in the non-contenteditable case).
2099         Instead, make use of r218180's test page, which knows how to select itself.
2100         Also, reset the pasteboard at the beginning of the test to reduce confusion
2101         (I landed the test broken because my simulator had the correct text
2102         stuck in its pasteboard).
2103
2104 2017-06-14  Jonathan Bedard  <jbedard@apple.com>
2105
2106         Configure screen scale for running layout tests on plus devices
2107         https://bugs.webkit.org/show_bug.cgi?id=173319
2108
2109         Reviewed by Tim Horton.
2110
2111         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
2112         * DumpRenderTree/mac/DumpRenderTree.mm:
2113         (dumpRenderTree): Set screen scale to 2.0.
2114         * TestRunnerShared/spi/UIKitTestSPI.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h,
2115         add _setScale for UIScreen.
2116         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
2117         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
2118         * WebKitTestRunner/ios/HIDEventGenerator.h: Ditto.
2119         * WebKitTestRunner/ios/HIDEventGenerator.mm: Ditto.
2120         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Ditto.
2121         * WebKitTestRunner/ios/TestControllerIOS.mm: Ditto.
2122         (WTR::TestController::platformInitialize): Set screen scale to 2.0.
2123         * WebKitTestRunner/ios/UIKitSPI.h: Moved to TestRunnerShared/spi/UIKitTestSPI.h.
2124         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
2125         * WebKitTestRunner/ios/mainIOS.mm: Ditto.
2126
2127 2017-06-14  Alexey Proskuryakov  <ap@apple.com>
2128
2129         Add iOS 11 support to the bot watcher's dashboard
2130         https://bugs.webkit.org/show_bug.cgi?id=173369
2131
2132         Reviewed by Lucas Forschler.
2133
2134         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png: Added.
2135         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png: Added.
2136         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png: Added.
2137         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png: Added.
2138         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2139         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2140
2141 2017-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2142
2143         [GTK][WPE] Raise the timeout values for layout tests
2144         https://bugs.webkit.org/show_bug.cgi?id=173368
2145
2146         Reviewed by Carlos Garcia Campos.
2147
2148         Raise the values to 15 seconds in Release builds and 30 seconds (2x) in Debug builds.
2149         When running under valgrind a 10x multiplier is applied.
2150
2151         * Scripts/webkitpy/port/gtk.py:
2152         (GtkPort.default_timeout_ms):
2153         * Scripts/webkitpy/port/gtk_unittest.py:
2154         (GtkPortTest.test_default_timeout_ms):
2155         * Scripts/webkitpy/port/wpe.py:
2156         (WPEPort.default_timeout_ms):
2157         * Scripts/webkitpy/port/wpe_unittest.py: Copied from Tools/Scripts/webkitpy/port/gtk_unittest.py.
2158         (WPEPortTest):
2159         (WPEPortTest.make_port):
2160         (WPEPortTest.test_default_timeout_ms):
2161         (WPEPortTest.test_get_crash_log):
2162
2163 2017-06-14  Alex Christensen  <achristensen@webkit.org>
2164
2165         Test persistent WKHTTPCookieStorages on iOS.
2166         https://bugs.webkit.org/show_bug.cgi?id=173284
2167
2168         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2169         (TEST):
2170         Make the bots green again for now. There's still a problem, and I'll investigate and fix.
2171
2172 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
2173
2174         [Win] DRT should not use disk cache.
2175         https://bugs.webkit.org/show_bug.cgi?id=173361
2176
2177         Reviewed by Darin Adler.
2178
2179         Like on macOS/iOS, DRT on Windows should only use memory cache.
2180
2181         * DumpRenderTree/win/DumpRenderTree.cpp:
2182         (setDefaultsToConsistentValuesForTesting):
2183         (prepareConsistentTestingEnvironment):
2184
2185 2017-06-14  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
2186
2187         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64
2188         https://bugs.webkit.org/show_bug.cgi?id=171668
2189
2190         Reviewed by Jer Noble.
2191
2192         MediaSource duration attribute is a double represented in MediaSource by a MediaTime instance created with
2193         MediaTime::CreateWithDouble(). This method implements an overflow control mechanism which sets MediaTime to
2194         Infinity when the double value passed as argument is greater than 2^64.
2195
2196         This patch removes the overflow control mechanism when time value is represented as a double. This patch also
2197         modifies the behavior of mathematical operations between a double MediaTime and rational MediaTime: the rational
2198         MediaTime is converted to a double before applying the operation. Double MediaTime precision is the same as for
2199         double. Overflow mechanisms still apply to the conversion of a double MediaTime to rational with setTimescale()
2200         method. No behavior change for rational MediaTime.
2201
2202         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Add tests to check operation results between double and rational MediaTime.
2203         (TestWebKitAPI::TEST):
2204
2205 2017-06-13  Alex Christensen  <achristensen@webkit.org>
2206
2207         Test persistent WKHTTPCookieStorages on iOS
2208         https://bugs.webkit.org/show_bug.cgi?id=173284
2209         <rdar://problem/32260156>
2210
2211         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2212         (TEST):
2213
2214 2017-06-13  Matt Rajca  <mrajca@apple.com>
2215
2216         WebsitePolicies: let clients select specific autoplay quirks
2217         https://bugs.webkit.org/show_bug.cgi?id=173343
2218
2219         Reviewed by Alex Christensen.
2220
2221         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2222         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2223         (TEST): Updated tests.
2224
2225 2017-06-13  Daniel Bates  <dabates@apple.com>
2226
2227         Implement W3C Secure Contexts Draft Specification
2228         https://bugs.webkit.org/show_bug.cgi?id=158121
2229         <rdar://problem/26012994>
2230
2231         Reviewed by Brent Fulgham.
2232
2233         Part 4
2234
2235         Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
2236         Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
2237         to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
2238
2239         * DumpRenderTree/TestOptions.h:
2240         * DumpRenderTree/TestOptions.mm:
2241         (TestOptions::TestOptions):
2242         * DumpRenderTree/mac/DumpRenderTree.mm:
2243         (setWebPreferencesForTestOptions):
2244         * DumpRenderTree/win/DumpRenderTree.cpp:
2245         (enableExperimentalFeatures):
2246         * WebKitTestRunner/TestController.cpp:
2247         (WTR::TestController::resetPreferencesToConsistentValues):
2248         (WTR::updateTestOptionsFromTestHeader):
2249         * WebKitTestRunner/TestOptions.h:
2250         (WTR::TestOptions::hasSameInitializationOptions):
2251
2252 2017-06-13  Alex Christensen  <achristensen@webkit.org>
2253
2254         Test persistent WKHTTPCookieStorages on iOS
2255         https://bugs.webkit.org/show_bug.cgi?id=173284
2256         <rdar://problem/32260156>
2257
2258         Reviewed by Alexey Proskuryakov.
2259
2260         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2261         (TEST):
2262
2263 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2264
2265         [GTK] Blob download doesn't work
2266         https://bugs.webkit.org/show_bug.cgi?id=172442
2267
2268         Reviewed by Carlos Alberto Lopez Perez.
2269
2270         Add a unit test to check blob downloads.
2271
2272         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2273         (testBlobDownload):
2274         (beforeAll):
2275
2276 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2277
2278         [GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
2279         https://bugs.webkit.org/show_bug.cgi?id=173316
2280
2281         Reviewed by Alex Christensen.
2282
2283         It's not really possible to run layout tests from the tarball, so it's better not to include those files.
2284
2285         * gtk/manifest.txt.in:
2286
2287 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2288
2289         [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
2290         https://bugs.webkit.org/show_bug.cgi?id=173315
2291
2292         Reviewed by Darin Adler.
2293
2294         This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
2295         somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
2296         returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
2297         freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
2298         WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
2299         destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
2300         WKGeolocationManagerRef is not destroyed.
2301
2302         * WebKitTestRunner/GeolocationProviderMock.cpp:
2303         (WTR::GeolocationProviderMock::GeolocationProviderMock):
2304         * WebKitTestRunner/GeolocationProviderMock.h:
2305
2306 2017-06-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2307
2308         Unable to paste text that was copied from a page into the universal search field
2309         https://bugs.webkit.org/show_bug.cgi?id=173293
2310         <rdar://problem/32440918>
2311
2312         Reviewed by Ryosuke Niwa.
2313
2314         Adds 2 new unit tests for copying plain and rich selected web content.
2315         See WebCore and WebKit ChangeLogs for more detail.
2316
2317         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2318         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
2319         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
2320         (TestWebKitAPI::dataForPasteboardType):
2321         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2322         (TestWebKitAPI::TEST):
2323
2324 2017-06-13  Joanmarie Diggs  <jdiggs@igalia.com>
2325
2326         AX: [ATK] Implement missing AtkRelation types
2327         https://bugs.webkit.org/show_bug.cgi?id=155494
2328
2329         Reviewed by Darin Adler.
2330
2331         Add additional methods to test ARIA properties which are exposed via
2332         AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
2333
2334         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2335         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
2336         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
2337         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
2338         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
2339         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
2340         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
2341         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
2342         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2343         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2344         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2345         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
2346         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
2347         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
2348         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
2349         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
2350         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
2351         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
2352
2353 2017-06-12  Daniel Bates  <dabates@apple.com>
2354
2355         Add unit tests for SecurityOrigin::IsPotentiallyTrustworthy()
2356         https://bugs.webkit.org/show_bug.cgi?id=173286
2357         <rdar://problem/32726102>
2358
2359         Reviewed by Brent Fulgham.
2360
2361         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2362         (TestWebKitAPI::TEST_F):
2363
2364 2017-06-12  Lucas Forschler  <lforschler@apple.com>
2365
2366         <rdar://problem/32683422>
2367         Teach copy-webkitlibraries-to-product-directory script about updated libraries.
2368
2369         Reviewed by Conrad Schultz.
2370
2371         * Scripts/copy-webkitlibraries-to-product-directory:
2372
2373 2017-06-12  Tim Horton  <timothy_horton@apple.com>
2374
2375         [iOS] Cmd-C doesn't copy text from WKWebView
2376         https://bugs.webkit.org/show_bug.cgi?id=173277
2377         <rdar://problem/32396742>
2378
2379         Reviewed by Dan Bernstein.
2380
2381         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2382         * Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
2383         Add a test ensuring that -copy on WKContentView will cause text to be copied.
2384
2385 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
2386
2387         [WebCrypto] Remove experimental feature flag of SubtleCrypto
2388         https://bugs.webkit.org/show_bug.cgi?id=173197
2389         <rdar://problem/32688148>
2390
2391         Reviewed by Brent Fulgham.
2392
2393         * DumpRenderTree/mac/DumpRenderTree.mm:
2394         (enableExperimentalFeatures):
2395         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2396         (WTR::InjectedBundle::beginTesting):
2397         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2398         (WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
2399         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2400
2401 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2402
2403         [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
2404         https://bugs.webkit.org/show_bug.cgi?id=173238
2405         <rdar://problem/31943370>
2406
2407         Reviewed by Ryosuke Niwa and Tim Horton.
2408
2409         Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
2410         element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
2411         of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.
2412
2413         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2414         (TestWebKitAPI::TEST):
2415         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2416         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2417         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
2418         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.
2419
2420 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2421
2422         WebItemProviderPasteboard should call its completion block immediately after a synchronous load
2423         https://bugs.webkit.org/show_bug.cgi?id=173225
2424         <rdar://problem/32713144>
2425
2426         Reviewed by Tim Horton.
2427
2428         Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
2429         cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).
2430
2431         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2432         (TestWebKitAPI::TEST):
2433
2434 2017-06-12  Jonathan Bedard  <jbedard@apple.com>
2435
2436         Return correct process names for iOS on-device testing
2437         https://bugs.webkit.org/show_bug.cgi?id=173263
2438
2439         Reviewed by Alex Christensen.
2440
2441         When running tests on iOS devices, process names do not end with '.Development'
2442         as they do on Mac and iOS simulator.
2443
2444         * WebKitTestRunner/TestController.cpp:
2445         (WTR::TestController::webProcessName): Return correct process name without '.Development'
2446         for iOS on-device testing.
2447         (WTR::TestController::networkProcessName): Ditto.
2448         (WTR::TestController::databaseProcessName): Ditto.
2449
2450 2017-06-12  Chris Dumez  <cdumez@apple.com>
2451
2452         Regression(r217867): Legacy SessionHistoryEntryData format should not change
2453         https://bugs.webkit.org/show_bug.cgi?id=173267
2454         <rdar://problem/32701257>
2455
2456         Reviewed by Simon Fraser.
2457
2458         Restrict test to stop covering saving / restore of scrollRestoration via the legacy
2459         SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
2460         though as this covers the crash that r217867 was fixing.
2461
2462         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
2463         (TestWebKitAPI::createSessionStateData):
2464         (TestWebKitAPI::TEST):
2465         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.
2466
2467 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2468
2469         [GTK] Stop dismissing menus attached to the web view for every injected event
2470         https://bugs.webkit.org/show_bug.cgi?id=172708
2471
2472         Reviewed by Alex Christensen.
2473
2474         It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
2475         that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
2476         events while the menu is open.
2477
2478         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2479         (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
2480         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2481         (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().
2482
2483 2017-06-12  Miguel Gomez  <magomez@igalia.com>
2484
2485         [GTK][WPE] Enable GStreamer GL on development builds
2486         https://bugs.webkit.org/show_bug.cgi?id=173248
2487
2488         Enable GStreamer GL for GTK and WPE.
2489
2490         Reviewed by Carlos Garcia Campos.
2491
2492         * Scripts/webkitperl/FeatureList.pm:
2493
2494 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2495
2496         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
2497
2498         Notifications are no longer cleared on page navigation.
2499
2500         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2501         (testWebViewNotification):
2502
2503 2017-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2504
2505         Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.
2506
2507         DBus interface and object path names were updated in r217831.
2508
2509         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
2510
2511 2017-06-10  Dan Bernstein  <mitz@apple.com>
2512
2513         Reverted r218056 because it made the IDE reindex constantly.
2514
2515         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2516         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2517         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
2518         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2519         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
2520         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2521         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2522         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2523
2524 2017-06-10  Dan Bernstein  <mitz@apple.com>
2525
2526         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
2527         https://bugs.webkit.org/show_bug.cgi?id=173223
2528
2529         Reviewed by Sam Weinig.
2530
2531         The rebuilds were happening due to a difference in the compiler options that the IDE and
2532         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
2533         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
2534         specify an appropriate path in CLANG_INDEX_STORE_PATH.
2535
2536         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2537         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2538         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
2539         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2540         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
2541         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2542         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2543         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2544
2545 2017-06-10  Jonathan Bedard  <jbedard@apple.com>
2546
2547         webkitpy: Reduce polling in ServerProcess
2548         https://bugs.webkit.org/show_bug.cgi?id=173116
2549
2550         Reviewed by Ryosuke Niwa.
2551
2552         We should be smarter about polling. We do not need to poll every time a line is read from
2553         stdout and stderr since lines are usually read from cached data. We should only poll
2554         when extracting that cached data from stdout and stderr.
2555
2556         * Scripts/webkitpy/port/driver.py:
2557         (Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
2558         and on ServerProcess to poll the process if not data is available in stdout and stderr.
2559         * Scripts/webkitpy/port/driver_unittest.py:
2560         (DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
2561         ServerProcess.
2562         * Scripts/webkitpy/port/server_process.py:
2563         (ServerProcess._read): Allow for data to be read from _output even if the process has
2564         crashed. Only poll the process if data needs to be extracted from stdout or stderr.
2565         * Scripts/webkitpy/port/server_process_mock.py:
2566         (MockServerProcess): Add number_of_times_polled.
2567         (MockServerProcess.poll): Increment number_of_times_polled.
2568         (MockServerProcess.has_crashed): Poll before returning crash state.
2569         (MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
2570         just like a ServerProcess would.
2571         (MockServerProcess.read_stdout): Ditto.
2572         * Scripts/webkitpy/port/server_process_unittest.py:
2573         (TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
2574         process from ending before stdout and stderr are read. This is the reason this test was flakey.
2575         (TestServerProcess):
2576         (TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
2577         the processes is polled.
2578         (TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
2579         data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.
2580
2581 2017-06-10  Andy Estes  <aestes@apple.com>
2582
2583         [QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
2584         https://bugs.webkit.org/show_bug.cgi?id=173190
2585         <rdar://problem/31360659>
2586
2587         Reviewed by Brady Eidson.
2588
2589         Added a release assert that tries to create a proper test failure if the web process crashes.
2590
2591         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
2592         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):
2593
2594 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2595
2596         [iOS DnD] Add a hook to perform two-step drops in editable content
2597         https://bugs.webkit.org/show_bug.cgi?id=172992
2598         <rdar://problem/32590174>
2599
2600         Reviewed by Tim Horton.
2601
2602         Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
2603         Tests:  DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
2604                 DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
2605
2606         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
2607         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2608         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):
2609
2610         Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
2611         be overridden. Currently, this is overridden to just return true.
2612
2613         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2614         (TestWebKitAPI::TEST):
2615         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2616         (WTR::InjectedBundlePage::InjectedBundlePage):
2617
2618 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
2619
2620         [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
2621         https://bugs.webkit.org/show_bug.cgi?id=173103
2622
2623         Reviewed by Xabier Rodriguez-Calvar.
2624
2625         * Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
2626         when building the WPE port through build-webkit.
2627
2628 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
2629
2630         [WPE] Enable MEDIA_SOURCE for build-webkit builds
2631         https://bugs.webkit.org/show_bug.cgi?id=173136
2632
2633         Reviewed by Xabier Rodriguez-Calvar.
2634
2635         * Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.
2636
2637 2017-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2638
2639         [GTK] Use API::FormClient instead of the C API in WebKitFormClient
2640         https://bugs.webkit.org/show_bug.cgi?id=173098
2641
2642         Reviewed by Žan Doberšek.
2643
2644         Fix memory leak and runtime warning when running /webkit2/WebKitWebView/submit-form. The web extension is
2645         assuming that all tests containing forms define ids for the form elements like
2646         /webkit2/WebKitWebExtension/form-controls-associated-signal does.
2647
2648         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2649         (formControlsAssociatedCallback):
2650
2651 2017-06-08  Jonathan Bedard  <jbedard@apple.com>
2652
2653         webkitpy: Run sample/spindump on iOS devices
2654         https://bugs.webkit.org/show_bug.cgi?id=171881
2655         <rdar://problem/32084602>
2656
2657         Reviewed by Daniel Bates.
2658
2659         * Scripts/webkitpy/port/darwin.py:
2660         (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
2661         requires sudo to run spindump.
2662         * Scripts/webkitpy/port/ios_device.py:
2663         (IOSDevicePort.look_for_new_samples): Deleted.
2664         (IOSDevicePort.sample_process): Deleted.
2665         * Scripts/webkitpy/port/ios_device_unittest.py:
2666         (IOSDeviceTest): iOS devices use 'ios' and their os_name.
2667         (IOSDeviceTest.test_spindump):
2668         (IOSDeviceTest.test_sample_process):
2669         (IOSDeviceTest.test_sample_process_exception):
2670         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2671         (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.
2672
2673 2017-06-08  Keith Miller  <keith_miller@apple.com>
2674
2675         WebAssembly: We should only create wrappers for functions that can be exported
2676         https://bugs.webkit.org/show_bug.cgi?id=173088
2677
2678         Reviewed by Saam Barati.
2679
2680         Add quick mode for wasm tests.
2681
2682         * Scripts/run-jsc-stress-tests:
2683
2684 2017-06-08  Darin Adler  <darin@apple.com>
2685
2686         WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer
2687         https://bugs.webkit.org/show_bug.cgi?id=173106
2688
2689         Reviewed by Sam Weinig.
2690
2691         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Define RefLogger objects first, so they are
2692         destroyed last.
2693         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Ditto.
2694         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
2695
2696 2017-06-07  Dan Bernstein  <mitz@apple.com>
2697
2698         [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths
2699         https://bugs.webkit.org/show_bug.cgi?id=173086
2700
2701         Reviewed by Andy Estes.
2702
2703         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
2704         (TEST):
2705
2706 2017-06-07  Alexey Proskuryakov  <ap@apple.com>
2707
2708         Add High Sierra support to WebKit tools
2709         https://bugs.webkit.org/show_bug.cgi?id=173080
2710
2711         Rubber-stamped by Daniel Bates.
2712
2713         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added.
2714         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png: Added.
2715         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2716         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2717         Added dashboard support.
2718
2719         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2720         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2721         Trigger the right build queues on check-in.
2722
2723         * Scripts/webkitpy/common/system/platforminfo.py:
2724         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2725         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2726         * Scripts/webkitpy/port/mac.py:
2727         * Scripts/webkitpy/port/mac_unittest.py:
2728         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2729         Added cases for Sierra, and updated tests for new baseline search paths.
2730
2731 2017-06-07  Ryan Haddad  <ryanhaddad@apple.com>
2732
2733         Unreviewed, rolling out r217902.
2734
2735         This change appears to have caused imported/w3c/web-platform-
2736         tests/fetch/api/cors tests to fail on El Capitan.
2737
2738         Reverted changeset:
2739
2740         "Teach run-webkit-tests how to run HTTPS Web Platform Tests"
2741         https://bugs.webkit.org/show_bug.cgi?id=172930
2742         http://trac.webkit.org/changeset/217902
2743
2744 2017-06-07  Daniel Bates  <dabates@apple.com>
2745
2746         Teach run-webkit-tests how to run HTTPS Web Platform Tests
2747         https://bugs.webkit.org/show_bug.cgi?id=172930
2748         <rdar://problem/32570201>
2749
2750         Reviewed by Youenn Fablet.
2751
2752         Some web platform tests need to be run from an HTTPS server in order to exercise functionality
2753         that is conditioned on the page being delivered over a secure protocol. One example of such
2754         a test is LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/secure_context/crypto-subtle-secure-context-available.https.sub.html.
2755
2756         Ideally we should look to use wptrunner to run Web Platform Tests. For now, modify run-webkit-tests
2757         to access web platform tests from an HTTPS server when the filename of the test contains ".https.".
2758         This makes run-webkit-test match the behavior of wptrunner: <https://github.com/w3c/web-platform-tests/blob/7ce469d1c46dd45aacfe1b408bf2ad36a630e089/tools/manifest/item.py#L42>.
2759
2760         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2761         (https_base_url): Parses the Web Platform Tests JSON configuration and returns the base URL
2762         to the Web Platform Tests HTTPS server.
2763         * Scripts/webkitpy/port/base.py:
2764         (Port.to.web_platform_test_server_https_base_url): Turns around and calls https_base_url().
2765         * Scripts/webkitpy/port/driver.py:
2766         (Driver.__init__): Caches the base URL to the Web Platform Tests HTTPS server. Also rename
2767         instance variables web_platform_test_server_doc_root, web_platform_test_server_base_url to
2768         _web_platform_test_server_doc_root and _web_platform_test_server_base_url, respectively to
2769         indicate that they should be considered private instance variables.
2770         (Driver.is_web_platform_test): Update code for renamed instance variables.
2771         (Driver):
2772         (Driver._web_platform_test_base_url_for_test): Returns the URL to access the specified test.
2773         (Driver.test_to_uri): Modified to use Driver._web_platform_test_base_url_for_test() to
2774         determine the base URL to use to access the test.
2775         (Driver.uri_to_test): Added logic to compute the filesystem local test name from a Web
2776         Platform Tests HTTPS URL. Also updated code for renamed instance variables.
2777
2778 2017-06-07  Per Arne Vollan  <pvollan@apple.com>
2779
2780         Support removal of authentication data through the Website data store API.
2781         https://bugs.webkit.org/show_bug.cgi?id=171217
2782
2783         Reviewed by Brady Eidson.
2784
2785         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2786         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2787         (WTR::InjectedBundle::didReceiveMessageToPage):
2788         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2789         (WTR::TestRunner::removeAllSessionCredentials):
2790         (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback):
2791         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2792         * WebKitTestRunner/TestController.h:
2793         * WebKitTestRunner/TestInvocation.cpp:
2794         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2795         (WTR::TestInvocation::didRemoveAllSessionCredentials):
2796         * WebKitTestRunner/TestInvocation.h:
2797         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2798         (WTR::TestController::removeAllSessionCredentials):
2799
2800 2017-06-07  Charlie Turner  <cturner@igalia.com>
2801
2802         Add Charlie Turner as contributor
2803         https://bugs.webkit.org/show_bug.cgi?id=173055
2804
2805         Reviewed by Carlos Alberto Lopez Perez.
2806
2807         I also ran the Tools/Scripts/validate-committer-lists --canonicalize command at the suggestion
2808         of webkit-patch upload, which reordered some fields and removed a newline.
2809
2810         * Scripts/webkitpy/common/config/contributors.json:
2811
2812 2017-06-06  Chris Dumez  <cdumez@apple.com>
2813
2814         RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
2815         https://bugs.webkit.org/show_bug.cgi?id=173033
2816         <rdar://problem/32591099>
2817
2818         Reviewed by Simon Fraser.
2819
2820         Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
2821         WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.
2822
2823         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2824         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.
2825         (TestWebKitAPI::didFinishLoadForFrame):
2826         (TestWebKitAPI::setPageLoaderClient):
2827         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
2828         (TestWebKitAPI::TEST):
2829
2830 2017-06-06  Andy Estes  <aestes@apple.com>
2831
2832         REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
2833         https://bugs.webkit.org/show_bug.cgi?id=172849
2834         <rdar://problem/32567454>
2835
2836         Reviewed by Darin Adler.
2837
2838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2839         * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.
2840         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2841         (TestWebKitAPI::TEST):
2842
2843 2017-06-06  Yoav Weiss  <yoav@yoav.ws>
2844
2845         [preload] Conditional support for media preloading and align media `as` values.
2846         https://bugs.webkit.org/show_bug.cgi?id=172501
2847
2848         Reviewed by Dean Jackson.
2849
2850         Turn on media preloading preference for tests.
2851
2852         * DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
2853         * DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
2854         * WebKitTestRunner/TestController.cpp: Turn on media preloading preference.
2855
2856 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2857
2858         webkitpy: Return correct process names from SimulatorProcess
2859         https://bugs.webkit.org/show_bug.cgi?id=172940
2860
2861         Reviewed by Aakash Jain.
2862
2863         * Scripts/webkitpy/port/darwin.py:
2864         (DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
2865         (DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
2866         (DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.
2867         * Scripts/webkitpy/port/driver.py:
2868         (Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
2869         _server_process.name() will not return the correct process name for iOS.
2870         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
2871         (Driver._read_block): Ditto.
2872         * Scripts/webkitpy/port/driver_unittest.py:
2873         (DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
2874         process_name() instead of name().
2875         * Scripts/webkitpy/port/server_process.py:
2876         (ServerProcess._start): Use process_name() instead of name().
2877         (ServerProcess.stop): Ditto.
2878         (ServerProcess.name): Deleted.
2879         * Scripts/webkitpy/port/simulator_process.py:
2880         (SimulatorProcess.process_name): Check the provided bundle for the process name.
2881
2882 2017-06-06  Dean Johnson  <dean_johnson@apple.com>
2883
2884         test-webkitpy: stop forking unsafely from within a spawned process
2885         https://bugs.webkit.org/show_bug.cgi?id=172774
2886
2887         Reviewed by Darin Adler.
2888
2889         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2890         (Builder.__init__): We don't use mechanize.Browser() as part of testing, so only initialize it when
2891         it's going to be used.
2892         (Builder.force_build):
2893
2894 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2895
2896         webkitpy: Process crash-logs for iOS devices
2897         https://bugs.webkit.org/show_bug.cgi?id=171976
2898         <rdar://problem/32134551>
2899
2900         Reviewed by David Kilzer.
2901
2902         When running layout tests on an iOS device, crash logs should be processed.
2903         Implement crash log searching and parsing for iOS devices.
2904
2905         * Scripts/webkitpy/common/system/crashlogs.py:
2906         (CrashLogs): Moved process regular expression for Darwin to class variable.
2907         (CrashLogs.__init__): Accept optional list of crash logs to ignore.
2908         (CrashLogs.find_newest_log): Add iOS as a potential platform.
2909         (CrashLogs.find_all_logs): Ditto.
2910         (CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
2911         Do not assume that a Darwin crash log starts with the process.
2912         (CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
2913         shared code for parsing Darwin crash logs.
2914         (CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
2915         object so that crash logs already on the system before testing are not parsed.
2916         (CrashLogs._find_newest_log_win.is_crash_log): Ditto.
2917         (CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
2918         (CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.
2919         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2920         (make_mock_crash_report_darwin): Crash logs may not have their process on the first line.
2921         * Scripts/webkitpy/common/system/systemhost.py:
2922         (SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
2923         systems is just the crashlog, use this behavior by default.
2924         * Scripts/webkitpy/common/system/systemhost_mock.py:
2925         (MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
2926         systems is just the crashlog, use this behavior by default.
2927         * Scripts/webkitpy/port/apple.py:
2928         (ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
2929         (ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
2930         the system before testing begins
2931         * Scripts/webkitpy/port/base.py:
2932         (Port._get_crash_log): Pass optional target host when getting crash logs.
2933         * Scripts/webkitpy/port/darwin.py:
2934         (DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
2935         CrashLogs object.
2936         (DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
2937         logs to be skipped to CrashLogs object.
2938         * Scripts/webkitpy/port/darwin_testcase.py:
2939         (DarwinTest.test_get_crash_log): Removed unused local function.
2940         (DarwinTest.test_get_crash_log.fake_time_cb): Deleted.
2941         * Scripts/webkitpy/port/device.py:
2942         (Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
2943         name, call it. Otherwise, assume the default behavior and read the file at the provided path.
2944         * Scripts/webkitpy/port/driver.py:
2945         (Driver._get_crash_log): Pass optional target host when getting crash logs.
2946         * Scripts/webkitpy/port/gtk.py:
2947         (GtkPort._get_crash_log): Pass optional target host when getting crash logs.
2948         * Scripts/webkitpy/port/ios.py: Ditto.
2949         (IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
2950         to be skipped for each host.
2951         * Scripts/webkitpy/port/ios_device.py:
2952         (IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
2953         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
2954         crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
2955         (IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
2956         host is specified. Else, search all connected devices for the specified crash-log.
2957         (IOSDevicePort.look_for_new_crash_logs): Deleted.
2958         * Scripts/webkitpy/port/ios_device_unittest.py:
2959         (IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
2960         (IOSDeviceTest.test_get_crash_log): Ditto.
2961         * Scripts/webkitpy/port/simulator_process.py:
2962         (SimulatorProcess.process_name): Check the provided bundle for the process name.
2963         * Scripts/webkitpy/port/win.py:
2964         (WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
2965         logs to be skipped to CrashLogs object.
2966         * Scripts/webkitpy/port/wpe.py:
2967         (WPEPort._get_crash_log): Pass optional target host when getting crash logs.
2968
2969 2017-06-06  David Kilzer  <ddkilzer@apple.com>
2970
2971         Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
2972         <https://webkit.org/b/172804>
2973
2974         Reviewed by Darin Adler.
2975
2976         WTF_ATTRIBUTE_PRINTF() only works outside the current
2977         compilation unit if it's on the declaration, not the
2978         implementation, of a function or class method.
2979
2980         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2981         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2982         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2983         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2984         - Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
2985         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2986         - Remove redundant CRASH() macro definition.  Use the one from
2987           <wtf/Assertions.h> instead.
2988
2989 2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
2990
2991         Move Resource Timing / User Timing from experimental features into main preferences
2992         https://bugs.webkit.org/show_bug.cgi?id=172950
2993
2994         Reviewed by Darin Adler.
2995
2996         * DumpRenderTree/mac/DumpRenderTree.mm:
2997         (enableExperimentalFeatures):
2998         (resetWebPreferencesToConsistentValues):
2999         * DumpRenderTree/win/DumpRenderTree.cpp:
3000         (enableExperimentalFeatures):
3001         (resetWebPreferencesToConsistentValues):
3002         * WebKitTestRunner/TestController.cpp:
3003         (WTR::TestController::resetPreferencesToConsistentValues):
3004         Move out no longer experimental features to the main list.
3005
3006 2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3007
3008         [WPE] Add an install-dependencies script
3009         https://bugs.webkit.org/show_bug.cgi?id=172948
3010
3011         Reviewed by Žan Doberšek.
3012
3013         It is based on the gtk/install-dependencies script.
3014         Includes support for Debian based distrubutions, Fedora and Arch.
3015         It has been tested on a minimal Debian 9 chroot.
3016
3017         * wpe/install-dependencies: Added.
3018
3019 2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3020
3021         Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
3022         https://bugs.webkit.org/show_bug.cgi?id=172891
3023         <rdar://problem/32204540>
3024
3025         Reviewed by Darin Adler.
3026
3027         Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
3028         contenteditable. See WebCore ChangeLog for more details.
3029
3030         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3031         (TestWebKitAPI::TEST):
3032
3033 2017-06-05  Daniel Bates  <dabates@apple.com>
3034
3035         webkitpy: Abstract Executive class
3036         https://bugs.webkit.org/show_bug.cgi?id=172928
3037         <rdar://problem/32569531>
3038
3039         Reviewed by Ryosuke Niwa.
3040
3041         Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
3042         This will make it straightforward to create additional derived classes that
3043         adhere to the same interface, say for iOS on-device testing.
3044
3045         * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
3046         (AbstractExecutive):
3047         (AbstractExecutive.run_and_throw_if_fail):
3048         (AbstractExecutive.cpu_count):
3049         (AbstractExecutive.interpreter_for_script):
3050         (AbstractExecutive.shell_command_for_script):
3051         (AbstractExecutive.kill_process):
3052         (AbstractExecutive.check_running_pid):
3053         (AbstractExecutive.running_pids):
3054         (AbstractExecutive.wait_newest):
3055         (AbstractExecutive.wait_limited):
3056         (AbstractExecutive.interrupt):
3057         (AbstractExecutive.default_error_handler):
3058         (AbstractExecutive.ignore_error):
3059         (AbstractExecutive._stringify_args):
3060         (AbstractExecutive.command_for_printing):
3061         (AbstractExecutive.run_command):
3062         (AbstractExecutive.popen):
3063         (AbstractExecutive.run_in_parallel):
3064         * Scripts/webkitpy/common/system/executive.py:
3065         (Executive):
3066         (Executive.cpu_count):
3067         (Executive.running_pids):
3068         (Executive.kill_all):
3069         (Executive._compute_stdin):
3070         (Executive.interpreter_for_script): Deleted.
3071         (Executive.shell_command_for_script): Deleted.
3072         (Executive.wait_newest): Deleted.
3073         (Executive.wait_limited): Deleted.
3074         (Executive.default_error_handler): Deleted.
3075         (Executive.ignore_error): Deleted.
3076         (Executive.command_for_printing): Deleted.
3077
3078 2017-06-05  Jonathan Bedard  <jbedard@apple.com>
3079
3080         webkitpy: Add iOS to platform
3081         https://bugs.webkit.org/show_bug.cgi?id=172931
3082
3083         Reviewed by Daniel Bates.
3084
3085         * Scripts/webkitpy/common/system/platforminfo.py:
3086         PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
3087         (PlatformInfo.is_ios): Added.
3088         (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
3089         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3090         (MockPlatformInfo.is_ios): Added.
3091
3092 2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3093
3094         [WPE][JHBuild] Switch github repository from git:// to https://
3095         https://bugs.webkit.org/show_bug.cgi?id=172921
3096
3097         Reviewed by Alex Christensen.
3098
3099         * wpe/jhbuild.modules:
3100
3101 2017-06-05  Tim Horton  <timothy_horton@apple.com>
3102
3103         ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
3104         https://bugs.webkit.org/show_bug.cgi?id=172887
3105         <rdar://problem/32546061>
3106
3107         Reviewed by Sam Weinig.
3108
3109         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3110         (WTR::UIScriptController::applyAutocorrection):
3111         applyAutocorrection can call its completion handler synchronously,
3112         which makes UIScriptController unhappy (see bug 172884).
3113
3114 2017-06-03  Jonathan Bedard  <jbedard@apple.com>
3115
3116         webkitpy: Add contextmanager to disable logging for a block
3117         https://bugs.webkit.org/show_bug.cgi?id=172876
3118
3119         Reviewed by Daniel Bates.
3120
3121         Add a context manager which will use an OutputCapture object to capture logging
3122         in a block and hold it in a variable.
3123
3124         * Scripts/webkitpy/common/system/outputcapture.py:
3125         (OutputCaptureScope):
3126         (OutputCaptureScope.__init__): Construct with OutputCapture object.
3127         (OutputCaptureScope.__enter__): Begin capturing output.
3128         (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
3129         output and retain the resulting log.
3130         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
3131         (OutputCaptureTest.test_output_capture_scope): Added.
3132
3133 2017-06-02  Zalan Bujtas  <zalan@apple.com>
3134
3135         Cleanup FrameView::autoSizeIfEnabled.
3136         https://bugs.webkit.org/show_bug.cgi?id=172889
3137         <rdar://problem/32550783>
3138
3139         Reviewed by Tim Horton.
3140
3141         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3142         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
3143         (TEST):
3144
3145 2017-06-02  Chris Dumez  <cdumez@apple.com>
3146
3147         ResourceLoadStatistics are not using unique paths during test runs
3148         https://bugs.webkit.org/show_bug.cgi?id=172861
3149         <rdar://problem/32442251>
3150
3151         Reviewed by Darin Adler.
3152
3153         Make sure WebKitTestRunner sets a temporary path for saving resource
3154         load statistics.
3155
3156         * WebKitTestRunner/TestController.cpp:
3157         (WTR::TestController::generateContextConfiguration):
3158
3159 2017-06-02  Brady Eidson  <beidson@apple.com>
3160
3161         Prevent scheme handlers from handling all built-in URL schemes.
3162         <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869
3163
3164         Reviewed by Andy Estes.
3165
3166         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3167
3168 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
3169
3170         [JSCOnly] Build static jsc.exe on Windows
3171         https://bugs.webkit.org/show_bug.cgi?id=172833
3172
3173         Reviewed by Konstantin Tokarev.
3174
3175         * CMakeLists.txt:
3176         * Scripts/build-jsc:
3177
3178 2017-06-02  Zalan Bujtas  <zalan@apple.com>
3179
3180         Disable ViewportSizeForViewportUnits tests on iOS.
3181         https://bugs.webkit.org/show_bug.cgi?id=172872
3182
3183         Reviewed by Tim Horton.
3184
3185         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
3186
3187 2017-06-02  Zalan Bujtas  <zalan@apple.com>
3188
3189         Allow clients to override viewport size for CSS viewport units.
3190         https://bugs.webkit.org/show_bug.cgi?id=172838
3191         <rdar://problem/32523441>
3192
3193         Reviewed by Tim Horton.
3194
3195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3196         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
3197         (TEST):
3198
3199 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
3200
3201         Get <chrono> out of StdLibExtras.h
3202         https://bugs.webkit.org/show_bug.cgi?id=172744
3203
3204         Reviewed by Zalan Bujtas.
3205
3206         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3207
3208 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
3209
3210         [WPE] Enable SUBTLE_CRYPTO
3211         https://bugs.webkit.org/show_bug.cgi?id=172756
3212
3213         Reviewed by Michael Catanzaro.
3214
3215         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
3216         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
3217         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
3218         exhausting entropy when running the crypto layout tests.
3219
3220 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3221
3222         [GTK] Bump GTK+ and its dependencies in jhbuild
3223         https://bugs.webkit.org/show_bug.cgi?id=171918
3224
3225         Reviewed by Carlos Alberto Lopez Perez.
3226
3227         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3228         (WTR::initializeGtkSettings):
3229         * gtk/jhbuild.modules:
3230         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
3231         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
3232
3233 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3234
3235         [GTK] Bump wayland and weston in jhbuild
3236         https://bugs.webkit.org/show_bug.cgi?id=171921
3237
3238         Reviewed by Carlos Alberto Lopez Perez.
3239
3240         * gtk/jhbuild.modules:
3241         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
3242
3243 2017-06-01  Andy Estes  <aestes@apple.com>
3244
3245         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
3246         https://bugs.webkit.org/show_bug.cgi?id=172828
3247
3248         Reviewed by Beth Dakin.
3249
3250         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3251
3252 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
3253
3254         webkitpy: Remove unneeded simulator teardown
3255         https://bugs.webkit.org/show_bug.cgi?id=171891
3256
3257         Reviewed by Aakash Jain.
3258
3259         * Scripts/webkitpy/port/ios_simulator.py:
3260         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
3261         for communication between Python and WebKitTestRunner/DumpRenderTree.
3262
3263 2017-06-01  Keith Miller  <keith_miller@apple.com>
3264
3265         Undo rollout in r217638 with bug fix
3266         https://bugs.webkit.org/show_bug.cgi?id=172824
3267
3268         Unreviewed, reland patch with unused set_state code removed.
3269
3270         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3271         (runThreadMessageTest):
3272         (TEST):
3273
3274 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
3275
3276         webkitpy: Do not send 0 or -1 as a pid to kill_process
3277         https://bugs.webkit.org/show_bug.cgi?id=172818
3278
3279         Reviewed by Darin Adler.
3280
3281         Sending a signal to process 0 will result in all processes in the group receiving
3282         the signal. Sending a signal to process -1 will result in all non-system processes
3283         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
3284         should consider these cases
3285
3286         * Scripts/webkitpy/common/system/executive.py:
3287         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
3288         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
3289         never be running, although os.kill may succeed.
3290         * Scripts/webkitpy/port/simulator_process.py:
3291         (SimulatorProcess.stop): Do not kill process if it is undefined.
3292
3293 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
3294
3295         JSC EWS bot does not run on WTF only patches
3296         https://bugs.webkit.org/show_bug.cgi?id=172777
3297         rdar://problem/32495975
3298
3299         Reviewed by Aakash Jain.
3300
3301         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
3302         (CheckPatchRelevance): Add a missing comma.
3303
3304 2017-05-31  Commit Queue  <commit-queue@webkit.org>
3305
3306         Unreviewed, rolling out r217611 and r217631.
3307         https://bugs.webkit.org/show_bug.cgi?id=172785
3308
3309         "caused wasm-hashset-many.html to become flaky." (Requested by
3310         keith_miller on #webkit).
3311
3312         Reverted changesets:
3313
3314         "Reland r216808, underlying lldb bug has been fixed."
3315         https://bugs.webkit.org/show_bug.cgi?id=172759
3316         http://trac.webkit.org/changeset/217611
3317
3318         "Use dispatch queues for mach exceptions"
3319         https://bugs.webkit.org/show_bug.cgi?id=172775
3320         http://trac.webkit.org/changeset/217631
3321
3322 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
3323
3324         EWS bots should reboot themselves more frequently
3325         https://bugs.webkit.org/show_bug.cgi?id=172402
3326
3327         Reviewed by Alexey Proskuryakov.
3328
3329         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
3330
3331         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
3332
3333 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
3334
3335         Reallocate hardware for iOS bots.
3336         https://bugs.webkit.org/show_bug.cgi?id=172657
3337
3338         Reviewed by Alexey Proskuryakov.
3339
3340         * BuildSlaveSupport/build.webkit.org-config/config.json:
3341
3342 2017-05-31  Andy Estes  <aestes@apple.com>
3343
3344         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
3345         https://bugs.webkit.org/show_bug.cgi?id=172366
3346
3347         Reviewed by Daniel Bates.
3348
3349         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3350
3351 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
3352
3353         Unreviewed, add Jiewen Tan as a reviewer
3354
3355         * Scripts/webkitpy/common/config/contributors.json:
3356
3357 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
3358
3359         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
3360         https://bugs.webkit.org/show_bug.cgi?id=172770
3361
3362         Reviewed by Michael Catanzaro.
3363
3364         * MiniBrowser/gtk/BrowserWindow.c:
3365         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
3366         which caused the body of the if-clause to be accidentally empty.
3367
3368 2017-05-31  Keith Miller  <keith_miller@apple.com>
3369
3370         Reland r216808, underlying lldb bug has been fixed.
3371         https://bugs.webkit.org/show_bug.cgi?id=172759
3372
3373         Unreviewed, relanding old patch. See: rdar://problem/31183352
3374
3375         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3376         (runThreadMessageTest):
3377         (TEST):
3378
3379 2017-05-31  Matt Lewis  <jlewis3@apple.com>
3380
3381         Unreviewed, rolling out r217603.
3382
3383         This patch broke the internal builds.
3384
3385         Reverted changeset:
3386
3387         "Get <chrono> out of StdLibExtras.h"
3388         https://bugs.webkit.org/show_bug.cgi?id=172744
3389         http://trac.webkit.org/changeset/217603
3390
3391 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
3392
3393         Make ResourceLoadStatistics testing more reliable
3394         https://bugs.webkit.org/show_bug.cgi?id=172730
3395         <rdar://problem/32028373>
3396
3397         Reviewed by Andy Estes.
3398
3399         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
3400         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
3401
3402         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3403         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3404
3405 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3406
3407         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
3408         https://bugs.webkit.org/show_bug.cgi?id=172757
3409
3410         Reviewed by Xabier Rodriguez-Calvar.
3411
3412         When needed, add the jhbuild wrapper at the beginning of the array
3413         that will be invoked to execute the run-jsc-stress-test or testapi
3414         commands.
3415
3416         * Scripts/run-javascriptcore-tests:
3417         (runJSCStressTests):
3418         * Scripts/webkitdirs.pm:
3419         (shouldUseJhbuild):
3420
3421 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
3422
3423         Get <chrono> out of StdLibExtras.h
3424         https://bugs.webkit.org/show_bug.cgi?id=172744
3425
3426         Reviewed by Saam Barati.
3427
3428         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3429
3430 2017-05-30  Tim Horton  <timothy_horton@apple.com>
3431
3432         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
3433         https://bugs.webkit.org/show_bug.cgi?id=172735
3434         <rdar://problem/32015977>
3435
3436         Reviewed by Enrica Casucci.
3437
3438         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3439         (WTR::UIScriptController::applyAutocorrection):
3440         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3441         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3442         (WTR::UIScriptController::applyAutocorrection):
3443         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3444         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3445         (WTR::UIScriptController::applyAutocorrection):
3446         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
3447         because I don't know how to tap the button in the autocorrection bar from a test.
3448
3449 2017-05-30  Daniel Bates  <dabates@apple.com>
3450
3451         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
3452         https://bugs.webkit.org/show_bug.cgi?id=172671
3453
3454         Reviewed by Alex Christensen.
3455
3456         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
3457         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
3458
3459         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
3460         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
3461         to trigger a navigation to test it.
3462         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
3463         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
3464
3465 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
3466
3467         webkitpy: Start servers before setting-up for testing
3468         https://bugs.webkit.org/show_bug.cgi?id=172176
3469         <rdar://problem/32225538>
3470
3471         Reviewed by Alexey Proskuryakov.
3472
3473         On-device testing requires that servers are started before ports set-up their
3474         test environments.
3475
3476         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3477         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
3478         Servers are unconditionally stopped on exit.
3479         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
3480         Manager now stops servers.
3481         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
3482         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
3483         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3484         (Manager.__init__): Delay construction of the test runner until we can determine
3485         if servers need to be started.
3486         (Manager.run): Determine if servers need to be started and construct the test runner.
3487         Shut servers down when the test run is finished.
3488         (Manager._run_tests): Move the determination of servers to run into Manager.run.
3489         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3490         (is_wpt_server_running): Server is not running if no config is found.
3491         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
3492         (PyWebSocket.is_running): Check if this WebSocket server is running.
3493         * Scripts/webkitpy/port/base.py:
3494         (Port.__init__): Define secure WebSocket server.
3495         (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
3496
3497 2017-05-30  Daniel Bates  <dabates@apple.com>
3498
3499         [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
3500         https://bugs.webkit.org/show_bug.cgi?id=172603
3501         <rdar://problem/32471306>
3502
3503         Reviewed by Brady Eidson.
3504
3505         Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
3506         method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
3507         unloading is initiated for a page that registered a onbeforeunload handler.
3508
3509         Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
3510         is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
3511         when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
3512
3513         Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
3514         for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
3515         as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
3516         registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
3517
3518         * MiniBrowser/mac/WK2BrowserWindowController.m:
3519         (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3520         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
3521         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
3522         (sawDialog):
3523         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3524         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3525         (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3526
3527 2017-05-30  Alex Christensen  <achristensen@webkit.org>
3528
3529         Update libwebrtc configuration
3530         https://bugs.webkit.org/show_bug.cgi?id=172727
3531
3532         Reviewed by Geoffrey Garen.
3533
3534         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3535
3536 2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
3537
3538         [WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
3539         https://bugs.webkit.org/show_bug.cgi?id=172702
3540
3541         Reviewed by Alex Christensen.
3542
3543         EGL PlatformDisplay needs to be shut down before existing a
3544         program on Windows.
3545
3546         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
3547         (TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
3548         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3549         (TestWebKitAPI::WebViewDestruction::TearDown): Ditto.
3550
3551 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
3552
3553         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
3554         https://bugs.webkit.org/show_bug.cgi?id=172709
3555
3556         Reviewed by Brent Fulgham.
3557
3558         Exit fullscreen mode after a fullscreen test.
3559
3560         * DumpRenderTree/win/DumpRenderTree.cpp:
3561         (resetWebViewToConsistentStateBeforeTesting):
3562
3563 2017-05-30  Antti Koivisto  <antti@apple.com>
3564
3565         ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
3566         https://bugs.webkit.org/show_bug.cgi?id=172713
3567
3568         Reviewed by Zalan Bujtas.
3569
3570         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3571         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
3572
3573             Remove forced display from plugin resource load delegate. It is testing some long-obsolete
3574             Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
3575             because on Mac WK1 it may get invoked from middle of a layout.
3576
3577             Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
3578
3579 2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3580
3581         Add a WPE EWS queue
3582         https://bugs.webkit.org/show_bug.cgi?id=172693
3583
3584         Reviewed by Carlos Garcia Campos.
3585
3586         * QueueStatusServer/config/queues.py:
3587         * QueueStatusServer/model/queues.py: Capitalize the name of the
3588         port on the tooltip of the bubbles. Do the same for the GTK port.
3589         (Queue.display_name):
3590         * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
3591         for the GTK+ EWS also. Set for both ports as watcher the alias
3592         bugs-noreply@webkitgtk.org that maintainers of both ports follow.
3593         * Scripts/webkitpy/common/config/ports.py:
3594         (DeprecatedPort.port):
3595         (WpePort):
3596         (WpePort.build_webkit_command):
3597         (WpePort.run_webkit_tests_command):
3598         * Scripts/webkitpy/common/config/ports_unittest.py:
3599         (DeprecatedPortTest):
3600         (DeprecatedPortTest.test_wpe_port):
3601         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3602         (test_ews_name):
3603
3604 2017-05-29  Zan Dobersek  <zdobersek@igalia.com>
3605
3606         Unreviewed. Bumping the WPEBackend-mesa dependency version.
3607
3608         * wpe/jhbuild.modules: Use the latest version that uses proper GLib
3609         priorities for IPC communication.
3610
3611 2017-05-27  Yusuke Suzuki  <utatane.tea@gmail.com>
3612
3613         [JSC] Map and Set constructors should have fast path for cloning
3614         https://bugs.webkit.org/show_bug.cgi?id=172413
3615
3616         Reviewed by Saam Barati.
3617
3618         * TestWebKitAPI/Tests/WTF/MathExtras.cpp: