LLInt get/put inline caches shouldn't use tons of opcodes
[WebKit-https.git] / Tools / ChangeLog
1 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         [Cocoa] Allow testing with the system language
4         https://bugs.webkit.org/show_bug.cgi?id=148671
5
6         Reviewed by Anders Carlsson and Alexey Proskuryakov.
7
8         React to tests marked with language=lang1,lang2,etc in their header.
9         Once this information is parsed, pass it to
10         WKContextConfigurationSetOverrideLanguages().
11
12         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
13         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
14         list.
15         * WebKitTestRunner/TestController.cpp:
16         (WTR::TestController::createWebViewWithOptions): Call
17         WKContextConfigurationSetOverrideLanguages().
18         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
19         * WebKitTestRunner/TestOptions.h:
20         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
21         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
22         option to restart the web process.
23         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
24         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
25
26 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
27
28         [WKTR] Allow changing the WKContextConfiguration between successive tests
29         https://bugs.webkit.org/show_bug.cgi?id=148833
30
31         Reviewed by Tim Horton.
32
33         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
34         However, there are certain tests which require specifying options in this object. This patch makes
35         our existing code for recreating the test runner web view also recreate the WKContext.
36
37         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
38         class.
39
40         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
41         * WebKitTestRunner/PlatformWebView.h:
42         (WTR::PlatformWebView::options):
43         * WebKitTestRunner/TestController.cpp:
44         (WTR::TestController::initialize):
45         (WTR::TestController::generateContextConfiguration):
46         (WTR::TestController::generatePageConfiguration):
47         (WTR::TestController::createWebViewWithOptions):
48         (WTR::TestController::ensureViewSupportsOptionsForTest):
49         (WTR::updateContextConfigurationOptionsFromTestHeader):
50         (WTR::TestController::contextConfigurationOptionsForTest):
51         (WTR::TestController::platformCreateWebView):
52         (WTR::TestController::platformCreateOtherPage):
53         (WTR::updateViewOptionsFromTestHeader): Deleted.
54         (WTR::TestController::viewOptionsForTest): Deleted.
55         * WebKitTestRunner/TestController.h:
56         (WTR::TestController::injectedBundlePath):
57         (WTR::TestController::testPluginDirectory):
58         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
59         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
60         (WTR::TestController::platformCreateWebView):
61         (WTR::TestController::platformCreateOtherPage):
62         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
63         (WTR::PlatformWebView::PlatformWebView):
64         (WTR::PlatformWebView::viewSupportsOptions):
65         * WebKitTestRunner/efl/TestControllerEfl.cpp:
66         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
67         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
68         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
69         (WTR::PlatformWebView::PlatformWebView):
70         (WTR::PlatformWebView::viewSupportsOptions):
71         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
72         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
73         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
74         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
75         (WTR::PlatformWebView::PlatformWebView):
76         (WTR::PlatformWebView::viewSupportsOptions):
77         * WebKitTestRunner/ios/TestControllerIOS.mm:
78         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
79         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
80         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
81         (WTR::PlatformWebView::PlatformWebView):
82         (WTR::PlatformWebView::viewSupportsOptions):
83         * WebKitTestRunner/mac/TestControllerMac.mm:
84         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
85         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
86
87 2015-09-11  Michael Saboff  <msaboff@apple.com>
88
89         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
90         https://bugs.webkit.org/show_bug.cgi?id=149083
91
92         Reviewed by Alexey Proskuryakov.
93
94         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
95
96         * DumpRenderTree/mac/LayoutTestHelper.m:
97         (colorProfileURLForDisplay):
98
99 2015-09-11  Saam barati  <sbarati@apple.com>
100
101         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
102         https://bugs.webkit.org/show_bug.cgi?id=149058
103
104         Reviewed by Geoffrey Garen.
105
106         * Scripts/run-jsc-stress-tests:
107
108 2015-09-10  Commit Queue  <commit-queue@webkit.org>
109
110         Unreviewed, rolling out r189595.
111         https://bugs.webkit.org/show_bug.cgi?id=149052
112
113         The tests still fail (Requested by ap on #webkit).
114
115         Reverted changeset:
116
117         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
118         error -1"
119         https://bugs.webkit.org/show_bug.cgi?id=142929
120         http://trac.webkit.org/changeset/189595
121
122 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
123
124         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
125         https://bugs.webkit.org/show_bug.cgi?id=142929
126
127         Reviewed by Brent Fulgham.
128
129         Silence the logging. We'll track fixing the root cause in Radar.
130
131         * Scripts/webkitpy/port/mac.py:
132         (MacPort.stderr_patterns_to_strip): Added a FIXME.
133
134         * Scripts/webkitpy/port/win.py:
135         (WinPort.logging_patterns_to_strip): Added.
136
137 2015-09-09  Andy Estes  <aestes@apple.com>
138
139         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
140         https://bugs.webkit.org/show_bug.cgi?id=149022
141
142         Reviewed by Daniel Bates.
143
144         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
145         did not account for this.
146
147         * Scripts/webkitpy/xcode/simulator.py:
148         (Simulator): Optionally matched a revision at the end of a runtime version number.
149         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
150
151 2015-09-09  Andy Estes  <aestes@apple.com>
152
153         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
154         https://bugs.webkit.org/show_bug.cgi?id=149029
155         <rdar://problem/22432624>
156
157         Reviewed by Daniel Bates.
158
159         * Scripts/webkitpy/xcode/simulator.py:
160         (Simulator): Taught to parse tvOS runtimes.
161         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
162
163 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
164
165         Fix bit rot on bot watcher's dashboard page
166         https://bugs.webkit.org/show_bug.cgi?id=149012
167
168         Reviewed by Tim Horton.
169
170         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
171         The code path used by the metrics page was trying to add properties to an undefined.
172
173         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
174         Silence an expection that would occur when the step has no logs. This should never
175         happen, but it did (perhaps buildbot was misconfigured for a while).
176
177 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
178
179         Update LayoutTestRelay xcconfig file.
180
181         Rubber-stamped by Dan Bernstein.
182
183         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
184
185 2015-09-09  Saam barati  <sbarati@apple.com>
186
187         DFG should have a debugging option that runs a phase that flushes all locals
188         https://bugs.webkit.org/show_bug.cgi?id=148916
189
190         Reviewed by Filip Pizlo.
191
192         * Scripts/run-jsc-stress-tests:
193
194 2015-09-09  Commit Queue  <commit-queue@webkit.org>
195
196         Unreviewed, rolling out r189530 and r189534.
197         https://bugs.webkit.org/show_bug.cgi?id=148996
198
199         Caused assertion failures on Yosemite (Requested by litherum
200         on #webkit).
201
202         Reverted changesets:
203
204         "[WKTR] Allow changing the WKContextConfiguration between
205         successive tests"
206         https://bugs.webkit.org/show_bug.cgi?id=148833
207         http://trac.webkit.org/changeset/189530
208
209         "[Cocoa] Fix the tests after r189530"
210         http://trac.webkit.org/changeset/189534
211
212 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
213
214         [Cocoa] Fix the tests after r189530
215
216         Unreviewed.
217
218         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
219         (WTR::initializeWebViewConfiguration):
220
221 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
222
223         [WKTR] Allow changing the WKContextConfiguration between successive tests
224         https://bugs.webkit.org/show_bug.cgi?id=148833
225
226         Reviewed by Tim Horton.
227
228         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
229         However, there are certain tests which require specifying options in this object. This patch makes
230         our existing code for recreating the test runner web view also recreate the WKContext.
231
232         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
233         class.
234
235         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
236         * WebKitTestRunner/PlatformWebView.h:
237         (WTR::PlatformWebView::options):
238         * WebKitTestRunner/TestController.cpp:
239         (WTR::TestController::initialize):
240         (WTR::TestController::generateContextConfiguration):
241         (WTR::TestController::generatePageConfiguration):
242         (WTR::TestController::createWebViewWithOptions):
243         (WTR::TestController::ensureViewSupportsOptionsForTest):
244         (WTR::updateContextConfigurationOptionsFromTestHeader):
245         (WTR::TestController::contextConfigurationOptionsForTest):
246         (WTR::TestController::platformCreateWebView):
247         (WTR::TestController::platformCreateOtherPage):
248         (WTR::updateViewOptionsFromTestHeader): Deleted.
249         (WTR::TestController::viewOptionsForTest): Deleted.
250         * WebKitTestRunner/TestController.h:
251         (WTR::TestController::injectedBundlePath):
252         (WTR::TestController::testPluginDirectory):
253         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
254         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
255         (WTR::TestController::platformCreateWebView):
256         (WTR::TestController::platformCreateOtherPage):
257         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
258         (WTR::PlatformWebView::PlatformWebView):
259         (WTR::PlatformWebView::viewSupportsOptions):
260         * WebKitTestRunner/efl/TestControllerEfl.cpp:
261         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
262         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
263         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
264         (WTR::PlatformWebView::PlatformWebView):
265         (WTR::PlatformWebView::viewSupportsOptions):
266         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
267         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
268         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
269         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
270         (WTR::PlatformWebView::PlatformWebView):
271         (WTR::PlatformWebView::viewSupportsOptions):
272         * WebKitTestRunner/ios/TestControllerIOS.mm:
273         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
274         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
275         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
276         (WTR::PlatformWebView::PlatformWebView):
277         (WTR::PlatformWebView::viewSupportsOptions):
278         * WebKitTestRunner/mac/TestControllerMac.mm:
279         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
280         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
281
282 2015-09-08  Daniel Bates  <dabates@apple.com>
283
284         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
285         https://bugs.webkit.org/show_bug.cgi?id=148980
286
287         Reviewed by Alexey Proskuryakov.
288
289         Add setting to enable/disable accelerated drawing so as to support testing
290         this feature in MiniBrowser on Mac.
291
292         * MiniBrowser/mac/SettingsController.h:
293         * MiniBrowser/mac/SettingsController.m:
294         (-[SettingsController _populateMenu]): Add menu item.
295         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
296         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
297         (-[SettingsController acceleratedDrawingEnabled]): Added.
298         * MiniBrowser/mac/WK1BrowserWindowController.m:
299         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
300         * MiniBrowser/mac/WK2BrowserWindowController.m:
301         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
302
303 2015-09-08  Jason Marcell  <jmarcell@apple.com>
304
305         Unreviewed. Added myself as a commiter in contributors.json.
306
307         * Scripts/webkitpy/common/config/contributors.json:
308
309 2015-09-08  Keith Miller  <keith_miller@apple.com>
310
311         Unreviewed, added myself to the list of contributors.
312
313         * Scripts/webkitpy/common/config/contributors.json:
314
315 2015-09-08  Daniel Bates  <dabates@apple.com>
316
317         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
318         https://bugs.webkit.org/show_bug.cgi?id=148921
319
320         Reviewed by Alexey Proskuryakov.
321
322         The ring image is positioned above the platform icon in markup and we specify the CSS
323         property z-index for the ring image so that it is painted on top of the platform icon
324         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
325         of the ring image, switch the order of these DOM elements and remove the use of the CSS
326         property z-index to achieve a similar effect.
327
328         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
329         (documentReady): Create the platform icon image element before the ring image such that
330         the ring image is painted on top of the platform icon.
331         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
332         (table.queue-grid td.logo img.ring): Removed property z-index.
333
334 2015-09-08  Daniel Bates  <dabates@apple.com>
335
336         Dashboard: Remove duplicate gear icon data URLs
337         https://bugs.webkit.org/show_bug.cgi?id=148920
338
339         Reviewed by Alexey Proskuryakov.
340
341         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
342         background-image associated with each of the three gear icon states: collapsed (.settings), hover
343         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
344         as a mask and make use of the CSS background-color to define the fill color for each of these three
345         states.
346
347         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
348         (.settings): Use gear icon as mask and define CSS background-color for collapsed state. 
349         (.settings:hover): Override CSS background-color for hover state.
350         (.settings-visible .settings): Override CSS background-color for expanded state.
351
352 2015-09-07  Andy Estes  <aestes@apple.com>
353
354         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
355         https://bugs.webkit.org/show_bug.cgi?id=148946
356         <rdar://problem/22603981>
357
358         Reviewed by Dan Bernstein.
359
360         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
361         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
362
363 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
364
365         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
366         https://bugs.webkit.org/show_bug.cgi?id=148927
367
368         Reviewed by Csaba Osztrogonác.
369
370         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
371         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
372
373         * WebKitTestRunner/TestController.cpp:
374         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
375         * WebKitTestRunner/efl/TestControllerEfl.cpp:
376         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
377
378 2015-09-07  Andy Estes  <aestes@apple.com>
379
380         Fix the Production build after r189455.
381
382         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
383         In-App Purchase template instead of the Aggregate template. Whoops.
384
385 2015-09-06  Andy Estes  <aestes@apple.com>
386
387         WebKit.xcworkspace should be be able to build iOS platforms
388         https://bugs.webkit.org/show_bug.cgi?id=148881
389
390         Reviewed by Daniel Bates.
391
392         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
393         for all supported platforms.
394
395         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
396         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
397         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
398         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
399
400 2015-09-06  Andy Estes  <aestes@apple.com>
401
402         WebKitTestRunner should build for iOS using the default target
403         https://bugs.webkit.org/show_bug.cgi?id=148918
404
405         Reviewed by Daniel Bates.
406
407         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
408         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
409         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
410
411         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
412         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
413         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
414         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
415         WebKitTestRunner is skipped when installing on iOS.
416
417         The target dependency graph now looks like this:
418
419             All
420                 WebKitTestRunnerApp
421                     WebKitTestRunner (Library)
422                         WebKitTestRunnerInjectedBundle
423                             Derived Sources
424                 WebKitTestRunner
425                     WebKitTestRunner (Library)
426                         WebKitTestRunnerInjectedBundle
427                             Derived Sources
428
429         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
430         * Scripts/build-webkittestrunner: Ditto.
431         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
432         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
433         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
434         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
435         excluded iOS-only files, and skipped installing on iOS.
436         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
437         excluded Mac-only files, and skipped installing on Mac.
438         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
439         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
440         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
441         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
442         new configuration files.
443
444 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
445
446         Web Inspector: Improve prepare-ChangeLog for multiple cases
447         https://bugs.webkit.org/show_bug.cgi?id=148875
448
449         Reviewed by Timothy Hatcher.
450
451         * Scripts/prepare-ChangeLog:
452         (get_function_line_ranges_for_javascript):
453         - We were ignoring everything inside of an anonymous function expression,
454           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
455           Better handle this by inserting a few tweaks.
456         - Allow method syntax outside of classes as long as they are at the global level.
457         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
458
459         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
460         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
461         (Foo.prototype.method1):
462         (Foo.prototype.method2):
463         (Foo.prototype.method3.innerFunction):
464         (Foo.prototype.method3):
465         (insideGlobalAnonymousFunctionExpression):
466         (foo.insideGlobalFunctionExpression):
467         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
468         (IssueWithMapGetAndSet.prototype.method1):
469         (IssueWithMapGetAndSet.prototype.method2):
470         (IssueWithMapGetAndSet.prototype.method3):
471         (IssueWithMapGetAndSet):
472
473 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
474
475         [ES6] Enable ES6 Module in JSC shell by default
476         https://bugs.webkit.org/show_bug.cgi?id=148689
477
478         Reviewed by Geoffrey Garen.
479
480         * Scripts/run-javascriptcore-tests:
481         (runJSCStressTests):
482         * Scripts/run-jsc-stress-tests:
483
484 2015-09-04  Basile Clement  <basile_clement@apple.com>
485
486         Unreviewed, change my email address.
487
488         * Scripts/webkitpy/common/config/contributors.json:
489
490 2015-09-04  Beth Dakin  <bdakin@apple.com>
491
492         Should have a test to make sure links don't navigate after a cancelled force 
493         click
494         https://bugs.webkit.org/show_bug.cgi?id=148846
495
496         Reviewed by Tim Horton.
497
498         New EventSender function for a started then cancelled force click.
499         * WebKitTestRunner/EventSenderProxy.h:
500         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
501         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
502         (WTR::EventSendingController::mouseForceClick):
503         (WTR::EventSendingController::startAndCancelMouseForceClick):
504         (WTR::EventSendingController::mouseForceDown):
505         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
506         * WebKitTestRunner/TestController.cpp:
507         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
508         * WebKitTestRunner/mac/EventSenderProxy.mm:
509         (WTR::EventSenderProxy::mouseForceClick):
510         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
511         (WTR::EventSenderProxy::mouseForceDown):
512         (WTR::EventSenderProxy::mouseMoveTo):
513
514 2015-09-04  Tim Horton  <timothy_horton@apple.com>
515
516         Add a test for r179736 (programmatic navigation during swipe causing a crash)
517         https://bugs.webkit.org/show_bug.cgi?id=148830
518
519         Reviewed by Beth Dakin.
520
521         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
522         (WTR::InjectedBundle::beginTesting):
523         Make sure that TestRunner callbacks don't leak between tests!
524
525 2015-09-04  Anders Carlsson  <andersca@apple.com>
526
527         It should be possible to pass relative HTTP test paths to DumpRenderTree
528         https://bugs.webkit.org/show_bug.cgi?id=148825
529         <rdar://problem/22583866>
530
531         Reviewed by Tim Horton.
532
533         Convert the path to an absolute path if needed.
534
535         * DumpRenderTree/mac/DumpRenderTree.mm:
536         (computeTestURL):
537
538 2015-09-04  Jason Marcell  <jmarcell@apple.com>
539
540         Fix Swift unit tests for prepare-ChangeLog.
541         https://bugs.webkit.org/show_bug.cgi?id=148817
542
543         Reviewed by Alexey Proskuryakov.
544
545         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
546         Swift unit tests for prepare-ChangeLog.
547
548 2015-09-04  Lucas Forschler  <lforschler@apple.com>
549
550         Modifications to the webkit-nightly logic.
551         
552         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
553         (updateAlertPanel):
554         * WebKitLauncher/main.m:
555         (displayErrorAndQuit):
556
557 2015-09-04  Beth Dakin  <bdakin@apple.com>
558
559         Speculative build fix.
560
561         * WebKitTestRunner/mac/EventSenderProxy.mm:
562
563 2015-09-04  Brian Burg  <bburg@apple.com>
564
565         Web Inspector: InspectorController should support multiple frontend channels
566         https://bugs.webkit.org/show_bug.cgi?id=148538
567
568         Reviewed by Joseph Pecoraro.
569
570         InspectorClients must explicitly disconnect their frontend channel(s) from the
571         inspected page's InspectorController.
572
573         To make this possible, DumpRenderTree should not destroy non-primary views until
574         it has tried to close any abandoned Web Inspector instances. Performing teardown
575         in the reverse order prevents disconnection of the frontend channel because that
576         prematurely destroys the inspector frontend client.
577
578         * DumpRenderTree/mac/DumpRenderTree.mm:
579         (runTest):
580         * DumpRenderTree/win/DumpRenderTree.cpp:
581         (runTest):
582
583 2015-09-04  Beth Dakin  <bdakin@apple.com>
584
585         Need to be able to test default behaviors on force click
586         https://bugs.webkit.org/show_bug.cgi?id=148758
587
588         Reviewed by Tim Horton.
589
590         This patch adds a new eventSender method to do a full, completed force click, 
591         and it re-works all of the existing force methods to dispatch their events in 
592         such a way that they will trigger the NSImmediateAction gesture recognizer. 
593         To do this, first we need to send the events to the app rather than straight 
594         to the view, and also needed to tweak some state and send the events in a 
595         delayed fashion.
596
597         New public function mouseForceClick() and private helper functions to make 
598         NSEvents.
599         * WebKitTestRunner/EventSenderProxy.h:
600
601         New public function mouseForceClick().
602         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
603         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
604         (WTR::EventSendingController::mouseMoveTo):
605         (WTR::EventSendingController::mouseForceClick):
606         (WTR::EventSendingController::mouseForceDown):
607         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
608         * WebKitTestRunner/TestController.cpp:
609         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
610
611         initPressureEventAtLocation needs to take a stageTransition and a window.
612         * WebKitTestRunner/mac/EventSenderProxy.mm:
613         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
614         (-[EventSenderSyntheticEvent stageTransition]):
615         (-[EventSenderSyntheticEvent timestamp]):
616         (-[EventSenderSyntheticEvent _cgsEventRecord]):
617         (-[EventSenderSyntheticEvent window]):
618
619         In order to enter the gesture recognizer, we need to start with a mouse down 
620         that has a NSEventMaskPressure modifier.
621         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
622
623         This ensures that the events queue properly for the force monitor in AppKit.
624         (WTR::spinRunLoopForForce):
625
626          We need to start the pressure change events with a began.
627         (WTR::EventSenderProxy::beginPressureEvent):
628
629         These functions can be used to create the NSEvent for a pressure change every 
630         time we need one.
631         (WTR::EventSenderProxy::pressureChangeEvent):
632
633         Send the right series of events to emulate a full, completed force click.
634         (WTR::EventSenderProxy::mouseForceClick):
635
636         Use all of the new things for these existing functions.
637         (WTR::EventSenderProxy::mouseForceDown):
638         (WTR::EventSenderProxy::mouseForceUp):
639         (WTR::EventSenderProxy::mouseForceChanged):
640
641         Set NSFakeForceTouchDevice to YES.
642         * WebKitTestRunner/mac/main.mm:
643         (setDefaultsToConsistentValuesForTesting):
644
645 2015-09-04  Jason Marcell  <jmarcell@apple.com>
646
647         prepare-ChangeLog needs to know how to parse Swift files.
648         https://bugs.webkit.org/show_bug.cgi?id=148784
649         <rdar://problem/22510062>
650
651         Reviewed by Darin Adler.
652
653         * Scripts/prepare-ChangeLog:
654         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
655         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
656         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
657         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
658         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
659         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
660         (freeFunction): Ditto.
661         (MyClass.function): Ditto.
662         (MyClass.functionWithArgument(_:)): Ditto.
663         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
664         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
665         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
666         (MyClass.classFunction): Ditto.
667         (MyClass.readWriteComputedVariable): Ditto.
668         (MyClass.readOnlyComputedVariable): Ditto.
669
670 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
671
672         Import css/css-color-3
673         https://bugs.webkit.org/show_bug.cgi?id=148803
674
675         Reviewed by Chris Dumez.
676
677         Fixed a bug that the imported reference files used the same extention as tests.
678         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
679
680         * Scripts/webkitpy/w3c/test_importer.py:
681         (TestImporter.find_importable_tests):
682
683 2015-09-03  Commit Queue  <commit-queue@webkit.org>
684
685         Unreviewed, rolling out r189338.
686         https://bugs.webkit.org/show_bug.cgi?id=148785
687
688         Caused tons of crashes (Requested by cdumez on #webkit).
689
690         Reverted changeset:
691
692         "Web Inspector: InspectorController should support multiple
693         frontend channels"
694         https://bugs.webkit.org/show_bug.cgi?id=148538
695         http://trac.webkit.org/changeset/189338
696
697 2015-09-03  Brian Burg  <bburg@apple.com>
698
699         Web Inspector: InspectorController should support multiple frontend channels
700         https://bugs.webkit.org/show_bug.cgi?id=148538
701
702         Reviewed by Joseph Pecoraro.
703
704         InspectorClients must explicitly disconnect their frontend channel(s) from the
705         inspected page's InspectorController.
706
707         To make this possible, DumpRenderTree should not destroy non-primary views until
708         it has tried to close any abandoned Web Inspector instances. Performing teardown
709         in the reverse order prevents disconnection of the frontend channel because that
710         prematurely destroys the inspector frontend client.
711
712         * DumpRenderTree/mac/DumpRenderTree.mm:
713         (runTest):
714         * DumpRenderTree/win/DumpRenderTree.cpp:
715         (runTest):
716
717 2015-09-03  Timothy Hatcher  <timothy@apple.com>
718
719         Update WebKit nightly icon to be more like Safari
720         https://bugs.webkit.org/show_bug.cgi?id=148768
721
722         Reviewed by Joseph Pecoraro.
723
724         * WebKitLauncher/webkit.icns:
725
726 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
727
728         JavaScriptCore should have some ES6 conformance tests
729         https://bugs.webkit.org/show_bug.cgi?id=148771
730
731         Reviewed by Chris Dumez.
732
733         * Scripts/run-javascriptcore-tests:
734         (runJSCStressTests): Added es6 as a test suite.
735
736         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
737
738         Some of these tests currently fail, so I also added a way to expect
739         failure for now. We'll migrate failing tests to expected passes as we
740         fix them.
741
742 2015-09-03  Tim Horton  <timothy_horton@apple.com>
743
744         Add a test for swipe-start hysteresis
745         https://bugs.webkit.org/show_bug.cgi?id=148756
746
747         Reviewed by Anders Carlsson.
748
749         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
750         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
751         (WTR::cacheTestRunnerCallback):
752         (WTR::TestRunner::clearTestRunnerCallbacks):
753         * WebKitTestRunner/InjectedBundle/TestRunner.h:
754         Make sure that we log if a client tries to install a callback twice
755         (since we use .add, the second call would not work).
756
757         Also, add clearTestRunnerCallbacks so tests can swap out installed
758         callbacks.
759
760 2015-09-03  Anders Carlsson  <andersca@apple.com>
761
762         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
763         https://bugs.webkit.org/show_bug.cgi?id=148746
764         rdar://problem/22568073
765
766         Reviewed by Tim Horton.
767
768         * DumpRenderTree/mac/DumpRenderTree.mm:
769         (computeTestURL):
770         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests. 
771
772         (runTest):
773         Call computeTestURL.
774
775         (testPathFromURL):
776         Get rid of this; computeTestURL does this for us now.
777
778         * Scripts/webkitpy/port/driver.py:
779         (Driver._command_from_driver_input):
780         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
781
782 2015-09-03  Tim Horton  <timothy_horton@apple.com>
783
784         Swipe tests fail on Mavericks
785         https://bugs.webkit.org/show_bug.cgi?id=148752
786
787         Reviewed by Beth Dakin.
788
789         * WebKitTestRunner/mac/EventSenderProxy.mm:
790
791 2015-09-03  Tim Horton  <timothy_horton@apple.com>
792
793         Fix the 32-bit build
794
795         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
796         (WTR::PlatformWebView::setNavigationGesturesEnabled):
797
798 2015-09-03  Tim Horton  <timothy_horton@apple.com>
799
800         Remove some logging that wasn't meant to be in the tree
801
802         * WebKitTestRunner/mac/EventSenderProxy.mm:
803         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
804
805 2015-09-03  Tim Horton  <timothy_horton@apple.com>
806
807         [Mac] Add support for testing swipes
808         https://bugs.webkit.org/show_bug.cgi?id=148700
809
810         Reviewed by Beth Dakin.
811
812         * WebKitTestRunner/EventSenderProxy.h:
813         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
814         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
815         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
816         (WTR::cgEventPhaseFromString):
817         (WTR::cgEventMomentumPhaseFromString):
818         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
819         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
820         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
821         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
822         (WTR::InjectedBundle::didReceiveMessageToPage):
823         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
824         (WTR::TestRunner::installDidBeginSwipeCallback):
825         (WTR::TestRunner::installWillEndSwipeCallback):
826         (WTR::TestRunner::installDidEndSwipeCallback):
827         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
828         (WTR::TestRunner::callDidBeginSwipeCallback):
829         (WTR::TestRunner::callWillEndSwipeCallback):
830         (WTR::TestRunner::callDidEndSwipeCallback):
831         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
832         * WebKitTestRunner/InjectedBundle/TestRunner.h:
833         * WebKitTestRunner/TestController.cpp:
834         (WTR::TestController::createOtherPage):
835         (WTR::TestController::createWebViewWithOptions):
836         (WTR::TestController::didReceiveMessageFromInjectedBundle):
837         (WTR::TestController::didBeginNavigationGesture):
838         (WTR::TestController::willEndNavigationGesture):
839         (WTR::TestController::didEndNavigationGesture):
840         (WTR::TestController::didRemoveNavigationGestureSnapshot):
841         * WebKitTestRunner/TestController.h:
842         * WebKitTestRunner/TestInvocation.cpp:
843         (WTR::TestInvocation::didBeginSwipe):
844         (WTR::TestInvocation::willEndSwipe):
845         (WTR::TestInvocation::didEndSwipe):
846         (WTR::TestInvocation::didRemoveSwipeSnapshot):
847         * WebKitTestRunner/TestInvocation.h:
848         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
849         when the snapshot is removed.
850
851         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
852         mouseScrollBy function.
853
854         * WebKitTestRunner/mac/EventSenderProxy.mm:
855         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
856         (-[EventSenderSyntheticEvent type]):
857         (-[EventSenderSyntheticEvent subtype]):
858         (-[EventSenderSyntheticEvent locationInWindow]):
859         (-[EventSenderSyntheticEvent location]):
860         (-[EventSenderSyntheticEvent momentumPhase]):
861         (-[EventSenderSyntheticEvent _isTouchesEnded]):
862         (-[EventSenderSyntheticEvent _cgsEventRecord]):
863         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
864         more adjustable values.
865
866         (WTR::EventSenderProxy::mouseForceDown):
867         (WTR::EventSenderProxy::mouseForceUp):
868         (WTR::EventSenderProxy::mouseForceChanged):
869         Adopt EventSenderSyntheticEvent.
870
871         (WTR::nsEventPhaseFromCGEventPhase):
872         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
873         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
874
875         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
876         (WTR::PlatformWebView::PlatformWebView):
877         Enable swipe.
878
879 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
880
881         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
882         https://bugs.webkit.org/show_bug.cgi?id=148723
883
884         Reviewed by Anders Carlsson.
885
886         * WebKitTestRunner/TestController.cpp:
887         (WTR::testPath):
888         (WTR::updateViewOptionsFromTestHeader):
889         (WTR::TestController::viewOptionsForTest):
890
891 2015-09-03  Lucas Forschler  <lforschler@apple.com>
892
893         Test commit.
894
895 2015-09-02  Tim Horton  <timothy_horton@apple.com>
896
897         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
898         https://bugs.webkit.org/show_bug.cgi?id=148693
899
900         Reviewed by Anders Carlsson.
901
902         * WebKitTestRunner/TestController.cpp:
903         (WTR::TestController::createOtherPage):
904         (WTR::TestController::createWebViewWithOptions):
905
906 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
907
908         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
909         https://bugs.webkit.org/show_bug.cgi?id=148529
910
911         Reviewed by Darin Adler.
912
913         When there are pending EventSender messages after a test finishes,
914         they could be processed in the main loop started by the
915         resetStateToConsistentValues(), but the old EventSender has been
916         replaced by a new one at that point. The new Eventsender can crash
917         when processing messages that were sent to the old one. To avoid
918         this, we return early when receiving an EventSender message and
919         the TestController state is not RunningTest.
920
921         * WebKitTestRunner/TestController.cpp:
922         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
923         (WTR::TestController::didReceiveMessageFromInjectedBundle):
924
925 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
926
927         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
928         https://bugs.webkit.org/show_bug.cgi?id=148528
929
930         Reviewed by Darin Adler.
931
932         Before r188548 resetStateToConsistentValues() was called in
933         TestController::run(), before tests are run, but now it's called
934         for every test in TestInvocation::invoke(), after m_status has
935         changed to RunningTest.
936
937         * WebKitTestRunner/TestController.cpp:
938         (WTR::TestController::resetStateToConsistentValues): Use
939         TemporaryChange to reset m_state ot its previous value after reset
940         is done.
941
942 2015-08-31  Jason Marcell  <jmarcell@apple.com>
943
944         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
945         that are marked as requiring corresponding tests.
946         https://bugs.webkit.org/show_bug.cgi?id=148498
947         <rdar://problem/21555314>
948
949         Reviewed by Dan Bernstein and David Kilzer.
950
951         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
952         simulate Git's attribute behevaior.
953         (main): Added "requiresTests" array to contain files that require tests.
954         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
955         section in ChangeLog.
956         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
957         however, we check if the file or any containing folder has the given property set to "1" and
958         return 1 if so; return 0 otherwise.
959         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
960         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
961
962 2015-08-26  Andy Estes  <aestes@apple.com>
963
964         [Content Filtering] Determine navigation and content policy before continuing to filter a load
965         https://bugs.webkit.org/show_bug.cgi?id=148506
966
967         Reviewed by Brady Eidson.
968
969         Added download API tests covering every decision and decision point.
970         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
971
972         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
973         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
974         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
975         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
976         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
977         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
978         decision and decision point as a bundle parameter.
979         (+[MockContentFilterEnabler supportsSecureCoding]):
980         (-[MockContentFilterEnabler copyWithZone:]):
981         (-[MockContentFilterEnabler initWithCoder:]):
982         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
983         (-[MockContentFilterEnabler encodeWithCoder:]):
984         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
985         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
986         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
987         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
988         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
989         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
990         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
991         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
992         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
993         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
994         (+[MockContentFilterEnabler supportsSecureCoding]):
995         (-[MockContentFilterEnabler copyWithZone:]):
996         (-[MockContentFilterEnabler initWithCoder:]):
997         (-[MockContentFilterEnabler dealloc]):
998         (-[MockContentFilterEnabler encodeWithCoder:]):
999         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
1000         (-[ContentFilteringPlugIn dealloc]): Stop observing.
1001         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
1002         (+[ServerRedirectPlugIn initialize]): Deleted.
1003         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1004         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1005         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
1006         (TEST): Deleted.
1007
1008 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
1009
1010         Skip slow lock tests on Windows/debug
1011         https://bugs.webkit.org/show_bug.cgi?id=148643
1012
1013         Reviewed by Alexey Proskuryakov.
1014
1015         The lock tests simulate a critical section by doing some floating point math, and then either
1016         make those critical sections very long or invoke them many times. This appears to be
1017         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
1018         that kind of computation slow.
1019
1020         These tests are almost as useful in release as they are in debug, so it's probably better to
1021         just skip the in debug on platforms where this causes timeouts.
1022
1023         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1024         (TestWebKitAPI::runLockTest):
1025         (TestWebKitAPI::skipSlow):
1026         (TestWebKitAPI::TEST):
1027
1028 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
1029
1030         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
1031         https://bugs.webkit.org/show_bug.cgi?id=125720
1032
1033         Reviewed by Daniel Bates.
1034
1035         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
1036
1037         * DumpRenderTree/AccessibilityUIElement.cpp:
1038         (pressCallback):
1039         (scrollToMakeVisibleWithSubFocusCallback):
1040         (scrollToGlobalPointCallback):
1041         (scrollToMakeVisibleCallback):
1042         (AccessibilityUIElement::getJSClass):
1043         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1044         (AccessibilityUIElement::scrollToMakeVisible):
1045         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1046         (AccessibilityUIElement::scrollToGlobalPoint):
1047         (AccessibilityUIElement::selectedTextRange):
1048         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1049         (AccessibilityUIElement::AccessibilityUIElement):
1050         (AccessibilityUIElement::mathPrescriptsDescription):
1051         (AccessibilityUIElement::scrollToMakeVisible):
1052         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1053         (AccessibilityUIElement::scrollToGlobalPoint):
1054         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1055         (WTR::AccessibilityUIElement::isTextMarkerValid):
1056         (WTR::AccessibilityUIElement::textMarkerForIndex):
1057         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1058         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1059         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1060         (WTR::AccessibilityUIElement::supportedActions):
1061         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
1062         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
1063         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1064         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1065         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1066         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1067         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1068         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1069         (WTR::AccessibilityUIElement::selectedTextRange):
1070         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1071         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1072         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
1073         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1074         (WTR::AccessibilityUIElement::selectedTextRange):
1075
1076 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
1077
1078         Add a mysteriously nonproblematic missing comma.
1079
1080         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1081         (TestExpectationParser._collect_matching_tests):
1082         (TestExpectationParser):
1083
1084 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
1085
1086         Remove an old temporary script that has served its purpose
1087
1088         * Scripts/convert-test-expectations: Removed.
1089
1090 2015-08-28  Jer Noble  <jer.noble@apple.com>
1091
1092         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
1093         https://bugs.webkit.org/show_bug.cgi?id=148579
1094
1095         Reviewed by Anders Carlsson.
1096
1097         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
1098
1099         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
1100         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
1101
1102         * DumpRenderTree/mac/DumpRenderTree.mm:
1103         (resetWebPreferencesToConsistentValues):
1104         (resetWebViewToConsistentStateBeforeTesting): 
1105         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1106         (WTR::initializeWebViewConfiguration):
1107
1108 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
1109
1110         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
1111         https://bugs.webkit.org/show_bug.cgi?id=148592
1112
1113         Reviewed by Tim Horton.
1114
1115         * Scripts/webkitpy/port/base.py:
1116         (Port.to.setup_environ_for_server):
1117         (Port.to):
1118         (Port.to._append_value_colon_separated):
1119         (Port.to.show_results_html_file):
1120         * Scripts/webkitpy/port/ios.py:
1121         (IOSSimulatorPort.setup_environ_for_server):
1122         * Scripts/webkitpy/port/mac.py:
1123         (MacPort.setup_environ_for_server):
1124
1125 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
1126
1127         LICM should be sound even if the CFG has changed
1128         https://bugs.webkit.org/show_bug.cgi?id=148259
1129
1130         Reviewed by Benjamin Poulain.
1131
1132         Add a utility for creating tests that set some uncommon option.
1133
1134         * Scripts/run-jsc-stress-tests:
1135
1136 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
1137
1138         [Win] Unreviewed EWS correction.
1139
1140         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
1141
1142 2015-08-28  Jer Noble  <jer.noble@apple.com>
1143
1144         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
1145         https://bugs.webkit.org/show_bug.cgi?id=147512
1146
1147         Reviewed by Anders Carlsson.
1148
1149         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
1150         to a consistent (true) value.
1151
1152         * DumpRenderTree/mac/DumpRenderTree.mm:
1153         (setDefaultsToConsistentValuesForTesting):
1154         * WebKitTestRunner/TestController.cpp:
1155         (WTR::TestController::resetPreferencesToConsistentValues):
1156
1157 2015-08-28  Tim Horton  <timothy_horton@apple.com>
1158
1159         Add navigation gesture callbacks to WKPageNavigationClient
1160         https://bugs.webkit.org/show_bug.cgi?id=148568
1161         <rdar://problem/22371346>
1162
1163         Reviewed by Anders Carlsson.
1164
1165         * WebKitTestRunner/TestController.cpp:
1166         (WTR::TestController::createOtherPage):
1167         (WTR::TestController::createWebViewWithOptions):
1168         Add some zeroes.
1169
1170 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
1171
1172         [Mac] kill-old-processes should kill more processes
1173         https://bugs.webkit.org/show_bug.cgi?id=148577
1174
1175         Reviewed by Tim Horton.
1176
1177         * BuildSlaveSupport/kill-old-processes:
1178
1179 2015-08-28  Jason Marcell  <jmarcell@apple.com>
1180
1181         The status message for combined builder queues should say "all builds succeeded" if everything
1182         built correctly.
1183         https://bugs.webkit.org/show_bug.cgi?id=148535
1184
1185         Reviewed by David Kilzer and Alexey Proskuryakov.
1186
1187         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1188         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
1189         say "all builds succeeded" if everything built correctly.
1190
1191 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1192
1193         [GTK] Simplify the internal API to create a WebView
1194         https://bugs.webkit.org/show_bug.cgi?id=148570
1195
1196         Reviewed by Žan Doberšek.
1197
1198         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
1199         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1200         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
1201         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
1202         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
1203         passing the received PageConfiguration.
1204         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1205         (WTR::PlatformWebView::PlatformWebView): Create the WebView
1206         passing the received PageConfiguration.
1207
1208 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
1209
1210         iOS Simulator API tests fails as Simulator is not running
1211         https://bugs.webkit.org/show_bug.cgi?id=148501
1212         rdar://problem/22447525
1213
1214         Reviewed by Daniel Bates.
1215
1216         This change is a workaround for <rdar://problem/22388812>.
1217
1218          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
1219          and quit it on program termination when running tests on the iOS port.
1220          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
1221          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
1222
1223 2015-08-27  Alex Christensen  <achristensen@webkit.org>
1224
1225         Make DLLLauncherMain executables dependent on dll
1226         https://bugs.webkit.org/show_bug.cgi?id=148548
1227
1228         Reviewed by Brent Fulgham.
1229
1230         * DumpRenderTree/CMakeLists.txt:
1231         * DumpRenderTree/PlatformWin.cmake:
1232         * MiniBrowser/win/CMakeLists.txt:
1233         * TestWebKitAPI/CMakeLists.txt:
1234         * TestWebKitAPI/PlatformWin.cmake:
1235
1236 2015-08-27  Lucas Forschler  <lforschler@apple.com>
1237
1238         Remove Mac slaves 188/189 after being replaced with 400/401.
1239         
1240         Unreviewed.
1241         
1242         * BuildSlaveSupport/build.webkit.org-config/config.json:
1243
1244 2015-08-27  Lucas Forschler  <lforschler@apple.com>
1245
1246         Add two bots to the Mac Yosemite queue.
1247         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
1248         
1249         Unreviewed.
1250         
1251         * BuildSlaveSupport/build.webkit.org-config/config.json:
1252
1253 2015-08-27  Alex Christensen  <achristensen@webkit.org>
1254
1255         [Win CMake] Fix incremental build after r188673
1256         https://bugs.webkit.org/show_bug.cgi?id=148539
1257
1258         Reviewed by Brent Fulgham.
1259
1260         * TestWebKitAPI/PlatformWin.cmake:
1261         Copy forwarding headers from WebCore before building in case that was not yet done.
1262         It used to be done when running CMake, but now it's a build step.
1263
1264 2015-08-27  Nan Wang  <n_wang@apple.com>
1265
1266         AX: Fix accessibility/select-element-at-index.html test
1267         https://bugs.webkit.org/show_bug.cgi?id=148516
1268
1269         Reviewed by Chris Fleizach.
1270
1271         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
1272
1273         * DumpRenderTree/AccessibilityUIElement.cpp:
1274         (setSelectedChildCallback):
1275         (setSelectedChildAtIndexCallback):
1276         (removeSelectionAtIndexCallback):
1277         (elementAtPointCallback):
1278         (sentenceAtOffsetCallback):
1279         (stringForSelectionCallback):
1280         (AccessibilityUIElement::getJSClass):
1281         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1282         (AccessibilityUIElement::setSelectedChild):
1283         (AccessibilityUIElement::setSelectedChildAtIndex):
1284         (AccessibilityUIElement::removeSelectionAtIndex):
1285         (AccessibilityUIElement::accessibilityValue):
1286         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1287         (WTR::AccessibilityUIElement::wordAtOffset):
1288         (WTR::AccessibilityUIElement::lineAtOffset):
1289         (WTR::AccessibilityUIElement::sentenceAtOffset):
1290         (WTR::AccessibilityUIElement::isSelectable):
1291         (WTR::AccessibilityUIElement::isMultiSelectable):
1292         (WTR::AccessibilityUIElement::setSelectedChild):
1293         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1294         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1295         (WTR::AccessibilityUIElement::selectedChildrenCount):
1296         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1297         (WTR::AccessibilityUIElement::isExpanded):
1298         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1299         (WTR::AccessibilityUIElement::setSelectedChild):
1300         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1301         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1302         (WTR::AccessibilityUIElement::accessibilityValue):
1303
1304 2015-08-27  Alex Christensen  <achristensen@webkit.org>
1305
1306         Build fix after r188982
1307
1308         * MiniBrowser/win/CMakeLists.txt:
1309         The directory structure changed in the move.
1310
1311 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
1312
1313         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
1314
1315         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
1316
1317         * gtk/install-dependencies:
1318
1319 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1320
1321         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
1322
1323         * Scripts/run-gtk-tests:
1324         (TestRunner):
1325
1326 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1327
1328         Fix GTK+ WTR crashes in initializeMainRunLoop()
1329
1330         Rubber-stamped by Žan Doberšek.
1331
1332         Initialize threading and main thread before
1333         RunLoop::initializeMainRunLoop(), since the GLib implementation of
1334         the RunLoop uses isMainThread() to decide whether to create a new
1335         GMainContext or use the default one. Also use RunLoop::run() and
1336         ::stop() instead of gtk_main/quit.
1337
1338         * WebKitTestRunner/TestController.cpp:
1339         (WTR::TestController::initialize):
1340         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1341         (WTR::TestController::notifyDone):
1342         (WTR::TestController::platformRunUntil):
1343
1344 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
1345
1346         Unreviewed, further shorten a test that times out because it's very long
1347         running.
1348
1349         I've locally run these tests on repeat for 24 hours and found no genuine
1350         failures, like deadlocks. So, the timeouts are probably because the test
1351         machine is slow and debug is slow. We should just run this test for fewer
1352         iterations.
1353
1354         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1355         (TestWebKitAPI::TEST):
1356
1357 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
1358
1359         Unreviewed build fix attempt on EFL
1360
1361         * WebKitTestRunner/PlatformEfl.cmake:
1362
1363 2015-08-26  Alex Christensen  <achristensen@webkit.org>
1364
1365         Build fix after r188982
1366
1367         * MiniBrowser/win/CMakeLists.txt:
1368         Find .rc files in correct directory.
1369
1370 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
1371
1372         [EFL] Bump cairo version to 1.14.2
1373         https://bugs.webkit.org/show_bug.cgi?id=148474
1374
1375         Reviewed by Csaba Osztrogonác.
1376
1377         * efl/jhbuild.modules:
1378
1379 2015-08-26  Andy Estes  <aestes@apple.com>
1380
1381         Crash when following a Google search link to Twitter with Limit Adult Content enabled
1382         https://bugs.webkit.org/show_bug.cgi?id=147651
1383
1384         Rubber-stamped by Brady Eidson.
1385
1386         Taught TestRunner how to decide the navigation policy after a delay.
1387
1388         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1389         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1390         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1391         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1392         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1393         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1394         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
1395         * WebKitTestRunner/TestController.cpp:
1396         (WTR::TestController::initialize):
1397         (WTR::TestController::resetStateToConsistentValues):
1398         (WTR::TestController::decidePolicyForNavigationAction):
1399         * WebKitTestRunner/TestController.h:
1400         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
1401         * WebKitTestRunner/TestInvocation.cpp:
1402         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1403
1404 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
1405
1406         [Win] Rename 'WinLauncher' to 'MiniBrowser'
1407         https://bugs.webkit.org/show_bug.cgi?id=148485
1408
1409         Reviewed by Alex Christensen
1410
1411         Move the WinLauncher project and source files to a subdirectory
1412         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
1413         source code and project files.
1414         
1415         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
1416         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
1417         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
1418         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
1419         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
1420         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
1421         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
1422         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
1423         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
1424         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
1425         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
1426         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
1427         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
1428         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
1429         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
1430         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
1431         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
1432         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
1433         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
1434         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
1435         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
1436         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
1437         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
1438         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
1439         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
1440         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
1441         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
1442         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
1443         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
1444         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
1445         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
1446         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
1447         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
1448         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
1449         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
1450         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
1451         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
1452         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
1453         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
1454         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
1455         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
1456         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
1457         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
1458         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
1459         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
1460         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
1461         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
1462         * MiniBrowser/win: Copied from WinLauncher.
1463         * MiniBrowser/win/Common.cpp:
1464         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
1465         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
1466         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
1467         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
1468         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
1469         * MiniBrowser/win/PageLoadTestClient.cpp:
1470         * MiniBrowser/win/PageLoadTestClient.h:
1471         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1472         * MiniBrowser/win/ResourceLoadDelegate.h:
1473         * MiniBrowser/win/WinLauncher.cpp: Removed.
1474         * MiniBrowser/win/WinLauncher.h: Removed.
1475         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
1476         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
1477         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
1478         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
1479         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
1480         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
1481         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
1482         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
1483         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
1484         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
1485         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
1486         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
1487         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
1488         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
1489         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
1490         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
1491         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
1492         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
1493         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
1494         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
1495         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
1496         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
1497         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
1498         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
1499         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
1500         * MiniBrowser/win/WinLauncherReplace.h: Removed.
1501         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
1502         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
1503         * MiniBrowser/win/WinMain.cpp:
1504         * WinLauncher: Removed.
1505         * WinLauncher/AccessibilityDelegate.cpp: Removed.
1506         * WinLauncher/AccessibilityDelegate.h: Removed.
1507         * WinLauncher/CMakeLists.txt: Removed.
1508         * WinLauncher/Common.cpp: Removed.
1509         * WinLauncher/DOMDefaultImpl.cpp: Removed.
1510         * WinLauncher/DOMDefaultImpl.h: Removed.
1511         * WinLauncher/PageLoadTestClient.cpp: Removed.
1512         * WinLauncher/PageLoadTestClient.h: Removed.
1513         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
1514         * WinLauncher/PrintWebUIDelegate.h: Removed.
1515         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
1516         * WinLauncher/ResourceLoadDelegate.h: Removed.
1517         * WinLauncher/WebDownloadDelegate.cpp: Removed.
1518         * WinLauncher/WebDownloadDelegate.h: Removed.
1519         * WinLauncher/WinLauncher.cpp: Removed.
1520         * WinLauncher/WinLauncher.h: Removed.
1521         * WinLauncher/WinLauncher.vcxproj: Removed.
1522         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
1523         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
1524         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
1525         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
1526         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
1527         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
1528         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
1529         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
1530         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
1531         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
1532         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
1533         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
1534         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
1535         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
1536         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
1537         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
1538         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
1539         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
1540         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
1541         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
1542         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
1543         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
1544         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
1545         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
1546         * WinLauncher/WinLauncherReplace.h: Removed.
1547         * WinLauncher/WinLauncherWebHost.cpp: Removed.
1548         * WinLauncher/WinLauncherWebHost.h: Removed.
1549         * WinLauncher/WinMain.cpp: Removed.
1550         * WinLauncher/resource.h: Removed.
1551         * WinLauncher/stdafx.cpp: Removed.
1552         * WinLauncher/stdafx.h: Removed.
1553         * win/AssembleBuildLogs/AssembleLogs.cmd:
1554
1555 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
1556
1557         [Win] Simplify menu handling code in WinLauncher
1558         https://bugs.webkit.org/show_bug.cgi?id=148461
1559
1560         Reviewed by Zalan Bujtas.
1561
1562         Revise 'ToggleMenuItem' to return a boolean value indicating if
1563         it handled the message. Revise WndProc to use this to decide if it
1564         should pass the message on to the default handler, rather than
1565         duplicating the logic in both places.
1566         
1567         * WinLauncher/Common.cpp:
1568         (ToggleMenuItem): Return true if the menu item message was handled.
1569         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
1570         the message tothe default handler.
1571
1572 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
1573
1574         Remove unused code after r188948
1575         https://bugs.webkit.org/show_bug.cgi?id=148467
1576
1577         Reviewed by Gyuyoung Kim.
1578
1579         * WebKitTestRunner/TestController.cpp:
1580         (WTR::TestController::platformPreferences): Deleted.
1581
1582 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1583
1584         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
1585         https://bugs.webkit.org/show_bug.cgi?id=148377
1586
1587         Reviewed by Carlos Garcia Campos.
1588
1589         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
1590         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
1591         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
1592         EFL and GTK at the moment.
1593
1594         * WebKitTestRunner/TestController.cpp:
1595         (WTR::TestController::platformWillRunTest):
1596         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1597         (WTR::TestController::platformPreferences):
1598         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1599         (WTR::TestController::platformPreferences):
1600
1601 2015-08-25  Nan Wang  <n_wang@apple.com>
1602
1603         AX: Enable accessibility/aria-controls.html test for mac
1604         https://bugs.webkit.org/show_bug.cgi?id=148458
1605
1606         Reviewed by Chris Fleizach.
1607
1608         Implemented ariaControlsElementAtIndex(unsigned index).
1609
1610         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1611         (AccessibilityUIElement::ariaControlsElementAtIndex):
1612         (AccessibilityUIElement::disclosedRowAtIndex):
1613         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1614         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
1615
1616 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1617
1618         Remove python tests for PassRefPtr 
1619         https://bugs.webkit.org/show_bug.cgi?id=148463
1620
1621         Reviewed by Andy Estes.
1622
1623         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
1624
1625         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1626         (PassPtrTest): Deleted.
1627         (PassPtrTest.assert_pass_ptr_check): Deleted.
1628         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
1629         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
1630         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
1631         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
1632         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
1633         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
1634
1635 2015-08-25  Andy Estes  <aestes@apple.com>
1636
1637         [iOS] run-webkit-tests fails if watchOS SDK is installed
1638         https://bugs.webkit.org/show_bug.cgi?id=148453
1639
1640         Reviewed by David Kilzer.
1641
1642         * Scripts/webkitpy/xcode/simulator.py:
1643         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
1644         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
1645
1646 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
1647
1648         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
1649         https://bugs.webkit.org/show_bug.cgi?id=148197
1650         rdar://problem/22334382
1651
1652         Reviewed by Daniel Bates.
1653
1654         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
1655         * Scripts/webkitpy/port/ios.py:
1656         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
1657         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
1658         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
1659         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
1660         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
1661
1662 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1663
1664         Remove PassRefPtr style check rule
1665         https://bugs.webkit.org/show_bug.cgi?id=148432
1666
1667         Reviewed by Andreas Kling.
1668
1669         PassRefPtr is being removed. Thus style rule needs to be removed as well.
1670
1671         * Scripts/webkitpy/style/checkers/cpp.py:
1672         (_check_parameter_name_against_text): Deleted.
1673         (check_function_definition_and_pass_ptr): Deleted.
1674         (check_function_definition): Deleted.
1675         (check_pass_ptr_usage): Deleted.
1676         (process_line): Deleted.
1677         (CppChecker): Deleted.
1678
1679 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
1680
1681         [Win] Expose "Inverted Colors" option in WinLauncher
1682         https://bugs.webkit.org/show_bug.cgi?id=148451
1683
1684         Reviewed by Tim Horton.
1685
1686         Add the ability to toggle the "Inverted Colors" preference
1687         in WinLauncher.
1688         
1689         * WinLauncher/Common.cpp:
1690         (ToggleMenuItem): Toggle the feature when the menu item
1691         is selected.
1692         (WndProc): Recognize the new menu option.
1693         * WinLauncher/WinLauncher.cpp:
1694         (WinLauncher::setToDefaultPreferences): Launch with "Invert
1695         Colors" turned off.
1696         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
1697         entry for "Invert Colors".
1698         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
1699
1700 2015-08-25  Nan Wang  <n_wang@apple.com>
1701
1702         [Mac] accessibility/document-attributes.html fails
1703         https://bugs.webkit.org/show_bug.cgi?id=116636
1704
1705         Reviewed by Chris Fleizach.
1706
1707         Implemented documentURI() and documentEncoding().
1708
1709         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1710         (AccessibilityUIElement::documentEncoding):
1711         (AccessibilityUIElement::documentURI):
1712         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1713         (WTR::AccessibilityUIElement::documentEncoding):
1714         (WTR::AccessibilityUIElement::documentURI):
1715
1716 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
1717
1718         [Win] Unreviewed test gardening.
1719
1720         Fix another case where the logging string is constructed using the variable 'frame',
1721         but the method argument is not given a name. This causes the global 'frame' value to
1722         be used, producing incorrect output.
1723
1724         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1725         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
1726         argument.
1727
1728 2015-08-24  Tim Horton  <timothy_horton@apple.com>
1729
1730         (Finally...) get rid of WKViewIOS
1731         https://bugs.webkit.org/show_bug.cgi?id=148404
1732
1733         Reviewed by Anders Carlsson.
1734
1735         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1736         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1737         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
1738         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1739         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1740         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1741         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1742         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1743         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
1744         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
1745         Mark tests that use WKBrowsingContextController as Mac-only.
1746
1747         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1748         (WTR::AccessibilityController::addNotificationListener):
1749         * WebKitTestRunner/ios/mainIOS.mm:
1750         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
1751         Import UIKit instead of depending on WKView.h to do so.
1752
1753 2015-08-24  Jason Marcell  <jmarcell@apple.com>
1754
1755         Add support to dashboard for displaying Git SHA's as revisions.
1756         https://bugs.webkit.org/show_bug.cgi?id=148387
1757
1758         Reviewed by Daniel Bates.
1759
1760         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1761         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
1762         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1763         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
1764         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
1765         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
1766
1767 2015-08-24  Andy Estes  <aestes@apple.com>
1768
1769         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
1770
1771         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
1772
1773 2015-08-23  Andy Estes  <aestes@apple.com>
1774
1775         Addressed a missed piece of review feedback from r188851.
1776
1777         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1778
1779 2015-08-23  Andy Estes  <aestes@apple.com>
1780
1781         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
1782         https://bugs.webkit.org/show_bug.cgi?id=147872
1783         rdar://problem/22044000
1784
1785         Reviewed by Dan Bernstein.
1786         
1787         Added an API test.
1788
1789         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
1790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1791         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
1792         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
1793         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
1794         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
1795         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
1796         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
1797         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
1798         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
1799         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
1800
1801 2015-08-23  Andy Estes  <aestes@apple.com>
1802
1803         Fixed the 32-bit Mac build after r188844.
1804
1805         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
1806         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
1807
1808 2015-08-22  Andy Estes  <aestes@apple.com>
1809
1810         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
1811         https://bugs.webkit.org/show_bug.cgi?id=148317
1812
1813         Reviewed by Dan Bernstein.
1814
1815         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
1816         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
1817         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
1818         when creating WKWebViews.
1819
1820         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
1821         added a new API test for bundle parameters.
1822
1823         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
1824         named its executable TestWebKitAPI.bundle.
1825         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
1826         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
1827         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
1828         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
1829         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
1830         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
1831         bundle parameter and asked for an initial notification.
1832         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
1833         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
1834         mirror its value in the main frame's JSContext.
1835         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
1836         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
1837         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
1838         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
1839         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
1840         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
1841         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
1842         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
1843         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
1844         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
1845
1846 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
1847
1848         URTBF after r188828.
1849
1850         * WebKitTestRunner/PlatformWebView.h:
1851
1852 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
1853
1854         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
1855         https://bugs.webkit.org/show_bug.cgi?id=148356
1856
1857         Reviewed by Darin Adler.
1858
1859         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1860         (BuildbotCombinedQueueView.prototype.update):
1861
1862 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
1863
1864         build.webkit.org/dashboard: Respect step's hidden flag
1865         https://bugs.webkit.org/show_bug.cgi?id=148357
1866
1867         Reviewed by Darin Adler.
1868
1869         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1870         (BuildbotIteration.prototype._parseData):
1871
1872 2015-08-23  Nan Wang  <n_wang@apple.com>
1873
1874         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
1875         https://bugs.webkit.org/show_bug.cgi?id=148328
1876
1877         Reviewed by Darin Adler.
1878
1879         We should only expose stringValue() when value attribute is set.
1880
1881         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1882         (AccessibilityUIElement::stringValue):
1883         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1884         (WTR::AccessibilityUIElement::stringValue):
1885
1886 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1887
1888         Remove style checking rule regarding OwnPtr and PassOwnPtr
1889         https://bugs.webkit.org/show_bug.cgi?id=148360
1890
1891         Reviewed by Darin Adler.
1892
1893         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
1894         Removed it.
1895
1896         * Scripts/do-webcore-rename:
1897         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1898         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
1899         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
1900         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
1901         (WebKitStyleTest.test_names): Deleted.
1902
1903 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
1904
1905         WebKitTestRunner should use WKWebView on OS X and iOS
1906         https://bugs.webkit.org/show_bug.cgi?id=143743
1907         <rdar://problem/16947123>
1908
1909         Reviewed by Anders Carlsson.
1910         Patch by Enrica Casucci and myself.
1911
1912         * WebKitTestRunner/PlatformWebView.h:
1913         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
1914         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
1915         instead of WKContext and WKPageGroup.
1916
1917         Remove the unused, always-true windowSnapshotEnabled().
1918         While technically some platforms don't have window snapshotting,
1919         they just return null instead of implementing windowSnapshotEnabled().
1920
1921         * WebKitTestRunner/TestController.h:
1922         * WebKitTestRunner/TestController.cpp:
1923         (WTR::TestController::createOtherPage):
1924         (WTR::TestController::initialize):
1925         (WTR::TestController::createWebViewWithOptions):
1926         Delegate to the various platforms for creating PlatformWebView instances,
1927         for creating WKContexts, and for accessing WKPreferences,
1928         so that they can do special things (like, use WKWebView instead!).
1929
1930         (WTR::TestController::resetPreferencesToConsistentValues):
1931         Make explicit WebKitTestRunner's desired default for two preferences
1932         which have differing defaults between the antique and modern API,
1933         for consistency's sake.
1934
1935         (WTR::TestController::resetStateToConsistentValues):
1936         Add platformResetStateToConsistentValues.
1937
1938         * WebKitTestRunner/TestInvocation.cpp:
1939         (WTR::TestInvocation::dumpResults):
1940         Adjust to the aforementioned removal of windowSnapshotEnabled().
1941
1942         * WebKitTestRunner/ios/TestControllerCocoa.mm:
1943         (WTR::TestController::platformResetStateToConsistentValues):
1944         (WTR::TestController::platformPreferences):
1945         (WTR::TestController::platformCreateWebView):
1946         (WTR::TestController::platformCreateOtherPage):
1947         (WTR::TestController::platformInitializeConfiguration):
1948         Implement the new platform functions for the Modern WebKit2 API,
1949         in a new TestControllerCocoa file that is shared between iOS and Mac.
1950         
1951         For platformMaybeCreateContext, use the trick that we know we can cast
1952         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
1953         WKWebView's configuration.
1954
1955         Ditto for WKPreferencesRef and WKPreferences.
1956
1957         Remove user content filters on the WKWebView's userContentController.
1958
1959         * WebKitTestRunner/mac/TestControllerMac.mm:
1960         * WebKitTestRunner/ios/TestControllerIOS.mm:
1961         Move code into TestControllerCocoa.
1962
1963         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1964         (WTR::InjectedBundle::beginTesting):
1965         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1966         (WTR::TestRunner::addUserScript):
1967         (WTR::TestRunner::addUserStyleSheet):
1968         Adopt WKBundlePage API for user scripts/sheets.
1969
1970         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1971         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1972         Make and keep a WKWebView instead of a WKView.
1973         
1974         * WebKitTestRunner/mac/EventSenderProxy.mm:
1975         (WTR::EventSenderProxy::mouseUp):
1976         (WTR::EventSenderProxy::mouseMoveTo):
1977         Reach inside the WKWebView to the WKView when dispatching events.
1978         This is fairly ugly and we should come up with a better solution.
1979         Also, fix some flipping and style errors.
1980
1981 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1982
1983         Unreviewed, attempt to fix GTK build after r188718
1984
1985         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1986         (WTR::PlatformWebView::PlatformWebView):
1987
1988 2015-08-21  Commit Queue  <commit-queue@webkit.org>
1989
1990         Unreviewed, rolling out r188807, r188813, and r188815.
1991         https://bugs.webkit.org/show_bug.cgi?id=148349
1992
1993         lots of 32-bit build problems, better to resolve separately
1994         and try again (Requested by thorton on #webkit).
1995
1996         Reverted changesets:
1997
1998         "WebKitTestRunner should use WKWebView on OS X and iOS"
1999         https://bugs.webkit.org/show_bug.cgi?id=143743
2000         http://trac.webkit.org/changeset/188807
2001
2002         "Stop building WebKitTestRunner for 32-bit platforms"
2003         https://bugs.webkit.org/show_bug.cgi?id=143743
2004         http://trac.webkit.org/changeset/188813
2005
2006         "Stop building WebKitTestRunner for 32-bit platforms"
2007         https://bugs.webkit.org/show_bug.cgi?id=143743
2008         http://trac.webkit.org/changeset/188815
2009
2010 2015-08-21  Tim Horton  <timothy_horton@apple.com>
2011
2012         Stop building WebKitTestRunner for 32-bit platforms
2013         https://bugs.webkit.org/show_bug.cgi?id=143743
2014         <rdar://problem/16947123>
2015
2016         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2017         This is a restriction on the valid set, not the desired set.
2018
2019 2015-08-21  Jason Marcell  <jmarcell@apple.com>
2020
2021         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
2022         to work with these new objects.
2023         https://bugs.webkit.org/show_bug.cgi?id=148188
2024
2025         Reviewed by Daniel Bates.
2026
2027         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2028         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
2029         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2030         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
2031         (repository, "branch name")-pair.
2032         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
2033         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2034         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
2035         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2036         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
2037         objects which represent a (repository, "branch name")-pair.
2038         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2039         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
2040         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
2041         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
2042         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
2043         BuildbotQueue.branch to BuildbotQueue.branches.
2044         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2045         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
2046
2047 2015-08-21  Tim Horton  <timothy_horton@apple.com>
2048
2049         Stop building WebKitTestRunner for 32-bit platforms
2050         https://bugs.webkit.org/show_bug.cgi?id=143743
2051         <rdar://problem/16947123>
2052
2053         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2054         WKWebView is not available on 32-bit OS X.
2055
2056 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
2057
2058         [Win] Unreviewed test correction after r188709.
2059
2060         I removed a function argument that happened to be mirrored by a global
2061         value with the same name. This prevented a compile error, but testing
2062         showed that the wrong value was being used in the function.
2063
2064         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2065         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
2066         back
2067
2068 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
2069
2070         WebKitTestRunner should use WKWebView on OS X and iOS
2071         https://bugs.webkit.org/show_bug.cgi?id=143743
2072         <rdar://problem/16947123>
2073
2074         Reviewed by Anders Carlsson.
2075         Patch by Enrica Casucci and myself.
2076
2077         * WebKitTestRunner/PlatformWebView.h:
2078         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
2079         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
2080         instead of WKContext and WKPageGroup.
2081
2082         Remove the unused, always-true windowSnapshotEnabled().
2083         While technically some platforms don't have window snapshotting,
2084         they just return null instead of implementing windowSnapshotEnabled().
2085
2086         * WebKitTestRunner/TestController.h:
2087         * WebKitTestRunner/TestController.cpp:
2088         (WTR::TestController::createOtherPage):
2089         (WTR::TestController::initialize):
2090         (WTR::TestController::createWebViewWithOptions):
2091         Delegate to the various platforms for creating PlatformWebView instances,
2092         for creating WKContexts, and for accessing WKPreferences,
2093         so that they can do special things (like, use WKWebView instead!).
2094
2095         (WTR::TestController::resetPreferencesToConsistentValues):
2096         Make explicit WebKitTestRunner's desired default for two preferences
2097         which have differing defaults between the antique and modern API,
2098         for consistency's sake.
2099
2100         (WTR::TestController::resetStateToConsistentValues):
2101         Add platformResetStateToConsistentValues.
2102
2103         * WebKitTestRunner/TestInvocation.cpp:
2104         (WTR::TestInvocation::dumpResults):
2105         Adjust to the aforementioned removal of windowSnapshotEnabled().
2106
2107         * WebKitTestRunner/ios/TestControllerCocoa.mm:
2108         (WTR::TestController::platformResetStateToConsistentValues):
2109         (WTR::TestController::platformPreferences):
2110         (WTR::TestController::platformCreateWebView):
2111         (WTR::TestController::platformCreateOtherPage):
2112         (WTR::TestController::platformInitializeConfiguration):
2113         Implement the new platform functions for the Modern WebKit2 API,
2114         in a new TestControllerCocoa file that is shared between iOS and Mac.
2115         
2116         For platformMaybeCreateContext, use the trick that we know we can cast
2117         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
2118         WKWebView's configuration.
2119
2120         Ditto for WKPreferencesRef and WKPreferences.
2121
2122         Remove user content filters on the WKWebView's userContentController.
2123
2124         * WebKitTestRunner/mac/TestControllerMac.mm:
2125         * WebKitTestRunner/ios/TestControllerIOS.mm:
2126         Move code into TestControllerCocoa.
2127
2128         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2129         (WTR::InjectedBundle::beginTesting):
2130         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2131         (WTR::TestRunner::addUserScript):
2132         (WTR::TestRunner::addUserStyleSheet):
2133         Adopt WKBundlePage API for user scripts/sheets.
2134
2135         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2136         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2137         Make and keep a WKWebView instead of a WKView.
2138         
2139         * WebKitTestRunner/mac/EventSenderProxy.mm:
2140         (WTR::EventSenderProxy::mouseUp):
2141         (WTR::EventSenderProxy::mouseMoveTo):
2142         Reach inside the WKWebView to the WKView when dispatching events.
2143         This is fairly ugly and we should come up with a better solution.
2144         Also, fix some flipping and style errors.
2145
2146 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
2147
2148         Improve how UI events are dispatched by WebKitTestRunner
2149         https://bugs.webkit.org/show_bug.cgi?id=148326
2150
2151         Reviewed by Anders Carlsson.
2152
2153         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2154         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2155         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
2156         asynchronous (and really, it has always been for the most part).
2157
2158         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2159         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
2160         (WTR::EventSendingController::mouseUp): Ditto.
2161         (WTR::EventSendingController::mouseMoveTo): Ditto.
2162         (WTR::EventSendingController::mouseForceDown): Ditto.
2163         (WTR::EventSendingController::mouseForceUp): Ditto.
2164         (WTR::EventSendingController::mouseForceChanged): Ditto.
2165         (WTR::EventSendingController::leapForward): Ditto.
2166         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
2167         (WTR::EventSendingController::keyDown): Ditto.
2168         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
2169         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
2170         to be done in custom WebKit2 code for test wheel event handling.
2171         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
2172         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
2173         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
2174         (WTR::EventSendingController::addTouchPoint): Ditto.
2175         (WTR::EventSendingController::updateTouchPoint): Ditto.
2176         (WTR::EventSendingController::setTouchModifier): Ditto.
2177         (WTR::EventSendingController::setTouchPointRadius): Ditto.
2178         (WTR::EventSendingController::touchStart): Ditto.
2179         (WTR::EventSendingController::touchMove): Ditto.
2180         (WTR::EventSendingController::touchEnd): Ditto.
2181         (WTR::EventSendingController::touchCancel): Ditto.
2182         (WTR::EventSendingController::clearTouchPoints): Ditto.
2183         (WTR::EventSendingController::releaseTouchPoint): Ditto.
2184         (WTR::EventSendingController::cancelTouchPoint): Ditto.
2185
2186         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2187         (WTR::InjectedBundle::postSetWindowIsKey):
2188         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2189         (WTR::InjectedBundle::isGeolocationProviderActive):
2190         (WTR::InjectedBundle::shouldProcessWorkQueue):
2191         Updated for WKBundlePagePostSynchronousMessage renaming.
2192
2193         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2194         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
2195
2196         * WebKitTestRunner/TestController.cpp:
2197         (WTR::TestController::initialize): Allow handling the new test style messages.
2198         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
2199         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
2200         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2201         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
2202         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
2203
2204         * WebKitTestRunner/mac/EventSenderProxy.mm:
2205         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
2206         (WTR::EventSenderProxy::keyDown): Ditto.
2207         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
2208         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
2209
2210 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2211
2212         Skip no-llint tests that fail due to running out of executable memory after r188969
2213         https://bugs.webkit.org/show_bug.cgi?id=148273
2214
2215         Reviewed by Michael Saboff.
2216
2217         * Scripts/run-jsc-stress-tests:
2218
2219 2015-08-21  Nan Wang  <n_wang@apple.com>
2220
2221         [Mac] accessibility/selection-states.html fails
2222         https://bugs.webkit.org/show_bug.cgi?id=116637
2223
2224         Reviewed by Chris Fleizach.
2225
2226         Implemented isSelectable() and isMultiSelectable().
2227
2228         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2229         (AccessibilityUIElement::isSelectable):
2230         (AccessibilityUIElement::isMultiSelectable):
2231         (AccessibilityUIElement::isSelectedOptionActive):
2232         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2233         (WTR::AccessibilityUIElement::isSelectable):
2234         (WTR::AccessibilityUIElement::isMultiSelectable):
2235         (WTR::AccessibilityUIElement::isVisible):
2236
2237 2015-08-21  Jason Marcell  <jmarcell@apple.com>
2238
2239         Fix iteration over repositories on bot watcher's dashboard.
2240
2241         Reviewed by Alexey Proskuryakov.
2242
2243         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2244         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
2245
2246 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
2247
2248         [EFL] Revise PlatformWebView ctor according to r188718
2249         https://bugs.webkit.org/show_bug.cgi?id=148282
2250
2251         This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
2252         instead of WKContextRef and WKPageGroupRef respectively.
2253
2254         Reviewed by Gyuyoung Kim.
2255
2256         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2257         (WTR::PlatformWebView::PlatformWebView):
2258
2259 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
2260
2261         Unreviewed, changed Devin Rousso's email.
2262
2263         * Scripts/webkitpy/common/config/contributors.json:
2264
2265 2015-08-20  Anders Carlsson  <andersca@apple.com>
2266
2267         Use WKPageConfigurationRef in WebKitTestRunner
2268         https://bugs.webkit.org/show_bug.cgi?id=147996
2269
2270         Reviewed by Tim Horton.
2271
2272         * WebKitTestRunner/TestController.cpp:
2273         (WTR::TestController::createOtherPage):
2274         (WTR::TestController::initialize):
2275         (WTR::TestController::createWebViewWithOptions):
2276         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2277         (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
2278         (WTR::PlatformWebView::PlatformWebView):
2279         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
2280
2281 2015-08-20  Brent Fulgham  <bfulgham@apple.com>
2282
2283         [Win] Update Windows tools for revised MIDL interfaces
2284         https://bugs.webkit.org/show_bug.cgi?id=148249
2285
2286         Reviewed by Dean Jackson.
2287
2288         This is a follow-up to Bug 148001.
2289
2290         Revise the testing software to use compatible signatures and
2291         implementations to match the requirements of the IDL generated
2292         with the SAL annotations.
2293
2294         * DumpRenderTree/win/DRTDataObject.cpp:
2295         * DumpRenderTree/win/DRTDataObject.h:
2296         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2297         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2298         * DumpRenderTree/win/DRTDropSource.cpp:
2299         * DumpRenderTree/win/DRTDropSource.h:
2300         * DumpRenderTree/win/DumpRenderTree.cpp:
2301         * DumpRenderTree/win/EditingDelegate.cpp:
2302         * DumpRenderTree/win/EditingDelegate.h:
2303         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2304         * DumpRenderTree/win/FrameLoadDelegate.h:
2305         * DumpRenderTree/win/HistoryDelegate.cpp:
2306         * DumpRenderTree/win/HistoryDelegate.h:
2307         * DumpRenderTree/win/PolicyDelegate.cpp:
2308         * DumpRenderTree/win/PolicyDelegate.h:
2309         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2310         * DumpRenderTree/win/ResourceLoadDelegate.h:
2311         * DumpRenderTree/win/TestRunnerWin.cpp:
2312         * DumpRenderTree/win/UIDelegate.cpp:
2313         * DumpRenderTree/win/UIDelegate.h:
2314         * WinLauncher/AccessibilityDelegate.cpp:
2315         * WinLauncher/AccessibilityDelegate.h:
2316         * WinLauncher/Common.cpp:
2317         * WinLauncher/DOMDefaultImpl.cpp:
2318         * WinLauncher/DOMDefaultImpl.h:
2319         * WinLauncher/PageLoadTestClient.cpp:
2320         * WinLauncher/PageLoadTestClient.h:
2321         * WinLauncher/PrintWebUIDelegate.cpp:
2322         * WinLauncher/PrintWebUIDelegate.h:
2323         * WinLauncher/ResourceLoadDelegate.cpp:
2324         * WinLauncher/ResourceLoadDelegate.h:
2325         * WinLauncher/WebDownloadDelegate.cpp:
2326         * WinLauncher/WebDownloadDelegate.h:
2327         * WinLauncher/WinLauncherWebHost.cpp:
2328         * WinLauncher/WinLauncherWebHost.h:
2329         * WinLauncher/WinMain.cpp:
2330         * win/DLLLauncher/DLLLauncherMain.cpp:
2331
2332 2015-08-20  Filip Pizlo  <fpizlo@apple.com>
2333
2334         Unreviewed, shorten a test that runs too long and times out.
2335
2336         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2337         (TestWebKitAPI::TEST):
2338
2339 2015-08-20  Alex Christensen  <achristensen@webkit.org>
2340
2341         Clean up CMake build after r188673
2342         https://bugs.webkit.org/show_bug.cgi?id=148234
2343
2344         Reviewed by Tim Horton.
2345
2346         * DumpRenderTree/PlatformWin.cmake:
2347         * TestWebKitAPI/CMakeLists.txt:
2348         * TestWebKitAPI/PlatformWin.cmake:
2349         Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
2350         gtest needs to be a static library on Windows to not crash.
2351
2352 2015-08-19  Alex Christensen  <achristensen@webkit.org>
2353
2354         CMake Windows build should not include files directly from other Source directories
2355         https://bugs.webkit.org/show_bug.cgi?id=148198
2356
2357         Reviewed by Brent Fulgham.
2358
2359         * DumpRenderTree/DumpRenderTreePrefix.h:
2360         Include cmakeconfig.h to properly define all enabled features.
2361         * DumpRenderTree/PlatformWin.cmake:
2362         * TestWebKitAPI/PlatformWin.cmake:
2363
2364 2015-08-19  Alex Christensen  <achristensen@webkit.org>
2365
2366         Build TestWTF on Mac with CMake.
2367         https://bugs.webkit.org/show_bug.cgi?id=147972
2368
2369         Reviewed by Tim Horton.
2370
2371         TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
2372         Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
2373
2374         * TestWebKitAPI/CMakeLists.txt:
2375         Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
2376         WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
2377         * TestWebKitAPI/PlatformMac.cmake: Added.
2378         * TestWebKitAPI/config.h:
2379         Postpone some build fixes until WebKit builds completely on Mac with CMake.
2380
2381 2015-08-19  Brian Burg  <bburg@apple.com>
2382
2383         Unreviewed, add Aleksandr Skachkov to the list of contributors.
2384
2385         * Scripts/webkitpy/common/config/contributors.json:
2386
2387 2015-08-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2388
2389         REGRESSION(r188548): [GTK] Build broken.
2390         https://bugs.webkit.org/show_bug.cgi?id=148154
2391
2392         Reviewed by Martin Robinson.
2393
2394         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2395         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2396         Even if we don't need to add/override any settings in ViewOptions,
2397         we need to define this as an empty function to make it build.
2398
2399 2015-08-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2400
2401         Fix conversion-null warning in conversion.cpp of TestWebKitAPI
2402         https://bugs.webkit.org/show_bug.cgi?id=148073
2403
2404         Reviewed by Alexey Proskuryakov.
2405
2406         * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
2407         (TestWebKitAPI::TEST):
2408
2409 2015-08-18  Anders Carlsson  <andersca@apple.com>
2410
2411         Fix test failure fallout from r188602 by using a V5 page ui client struct.
2412
2413         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2414         (TestWebKitAPI::setUpClients):
2415
2416 2015-08-18  Brian Burg  <bburg@apple.com>
2417
2418         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
2419         https://bugs.webkit.org/show_bug.cgi?id=147955
2420
2421         Reviewed by Timothy Hatcher.
2422
2423         To enable sharing of common test code between protocol and model tests,
2424         start loading the protocol TestStub.js through the WebInspectorUI bundle.
2425
2426         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
2427         protocol-test.js uses to load the inspector frontend stub into its iframe
2428         from an arbitrary local file URL.
2429
2430         * DumpRenderTree/TestRunner.cpp:
2431         (getInspectorTestStubURLCallback):
2432         (TestRunner::staticValues):
2433         * DumpRenderTree/TestRunner.h:
2434         * DumpRenderTree/mac/TestRunnerMac.mm:
2435         (SOFT_LINK_STAGED_FRAMEWORK):
2436         (TestRunner::inspectorTestStubURL):
2437         * DumpRenderTree/win/TestRunnerWin.cpp:
2438         (TestRunner::inspectorTestStubURL):
2439         * WebKitTestRunner/Configurations/Base.xcconfig:
2440         Since WebKitTestRunner now includes WebCore private headers, also search
2441         for the WebCore framework inside the WebKit umbrella framework.
2442
2443         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2444         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2445         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2446         (WTR::TestRunner::inspectorTestStubURL):
2447         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2448         (WTR::TestRunner::inspectorTestStubURL):
2449         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2450         (WTR::TestRunner::inspectorTestStubURL):
2451
2452 2015-08-18  Filip Pizlo  <fpizlo@apple.com>
2453
2454         Unreviewed, fix GTK build.
2455
2456         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2457         (TestWebKitAPI::TEST):
2458
2459 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
2460
2461         Replace all remaining uses of WTF::Mutex with WTF::Lock
2462         https://bugs.webkit.org/show_bug.cgi?id=148089
2463
2464         Reviewed by Geoffrey Garen.
2465
2466         * DumpRenderTree/JavaScriptThreading.cpp:
2467         (javaScriptThreadsMutex):
2468         (runJavaScriptThread):
2469         (startJavaScriptThreads):
2470         (stopJavaScriptThreads):
2471         * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
2472         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2473         (TestWebKitAPI::TEST):
2474         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2475         (TestWebKitAPI::TEST):
2476
2477 2015-08-17  Commit Queue  <commit-queue@webkit.org>
2478
2479         Unreviewed, rolling out r188539, r188544, r188552, and
2480         r188564.
2481         https://bugs.webkit.org/show_bug.cgi?id=148122
2482
2483         Broke tests and some build styles (Requested by ap on
2484         #webkit).
2485
2486         Reverted changesets:
2487
2488         "Web Inspector: load ProtocolTestStub from the WebInspectorUI
2489         bundle"
2490         https://bugs.webkit.org/show_bug.cgi?id=147955
2491         http://trac.webkit.org/changeset/188539
2492
2493         "Web Inspector: split TestStub.js into multiple files and
2494         modernize it"
2495         https://bugs.webkit.org/show_bug.cgi?id=148077
2496         http://trac.webkit.org/changeset/188544
2497
2498         "Web Inspector: InspectorTest should be a subclass of
2499         TestHarness"
2500         https://bugs.webkit.org/show_bug.cgi?id=148079
2501         http://trac.webkit.org/changeset/188552
2502
2503         "Unreviewed internal build fix attempt after r188539."
2504         http://trac.webkit.org/changeset/188564
2505
2506 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
2507
2508         [OS X] Remove support for composite fonts
2509         https://bugs.webkit.org/show_bug.cgi?id=147920
2510
2511         Reviewed by Dan Bernstein.
2512
2513         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2514         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
2515         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2516         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2517         * DumpRenderTree/mac/DumpRenderTree.mm:
2518         (allowedFontFamilySet): Deleted.
2519         (activateTestingFonts): Deleted.
2520         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2521         (WTR::allowedFontFamilySet): Deleted.
2522         (WTR::activateFonts): Deleted.
2523         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2524         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
2525         * WebKitTestRunner/mac/TestControllerMac.mm:
2526         (WTR::allowedFontFamilySet): Deleted.
2527
2528 2015-08-17  Jon Honeycutt  <jhoneycutt@apple.com>
2529
2530         Unreviewed internal build fix attempt after r188539.
2531
2532         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2533
2534 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
2535
2536         Fix the build
2537
2538         Unreviewed.
2539
2540         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
2541
2542 2015-08-17  Alex Christensen  <achristensen@webkit.org>
2543
2544         Build Debug Suffix on Windows with CMake
2545         https://bugs.webkit.org/show_bug.cgi?id=148083
2546
2547         Reviewed by Brent Fulgham.
2548
2549         * TestWebKitAPI/CMakeLists.txt:
2550         * TestWebKitAPI/PlatformWin.cmake:
2551         Add DEBUG_SUFFIX
2552
2553 2015-08-17  Anders Carlsson  <andersca@apple.com>
2554
2555         Simplify how PlatformWebViews are created when view options change
2556         https://bugs.webkit.org/show_bug.cgi?id=148093
2557
2558         Reviewed by Sam Weinig.
2559
2560         Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
2561
2562         TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
2563         TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
2564         ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
2565
2566         If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
2567
2568         Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
2569         always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
2570
2571         * WebKitTestRunner/TestController.cpp:
2572         (WTR::TestController::ensureViewSupportsOptionsForTest):
2573         (WTR::shouldUseFixedLayout):
2574         (WTR::TestController::viewOptionsForTest):
2575         (WTR::TestController::updateWebViewSizeForTest):
2576         (WTR::TestController::updateWindowScaleForTest):
2577         (WTR::TestController::configureViewForTest):
2578         (WTR::TestController::initialize): Deleted.
2579         (WTR::TestController::ensureViewSupportsOptions): Deleted.
2580         (WTR::TestController::updateLayoutTypeForTest): Deleted.
2581         (WTR::TestController::platformConfigureViewForTest): Deleted.
2582         (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
2583         (WTR::TestController::run): Deleted.
2584         * WebKitTestRunner/TestController.h:
2585         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2586         (WTR::shouldUseFixedLayout):
2587         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2588         (WTR::TestController::platformConfigureViewForTest):
2589         (WTR::TestController::platformResetPreferencesToConsistentValues):
2590         * WebKitTestRunner/ios/TestControllerIOS.mm:
2591         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2592         * WebKitTestRunner/mac/TestControllerMac.mm:
2593         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
2594         (WTR::TestController::platformConfigureViewForTest):
2595
2596 2015-08-17  Sam Weinig  <sam@webkit.org>
2597
2598         API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
2599         https://bugs.webkit.org/show_bug.cgi?id=148097
2600
2601         Reviewed by Anders Carlsson.
2602
2603         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
2604         Add tests for WebsiteDataStores in the WKPageConfiguration.
2605
2606 2015-08-17  Brian Burg  <bburg@apple.com>
2607
2608         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
2609         https://bugs.webkit.org/show_bug.cgi?id=147955
2610
2611         Reviewed by Timothy Hatcher.
2612
2613         To enable sharing of common test code between protocol and model tests,
2614         start loading the protocol TestStub.js through the WebInspectorUI bundle.
2615
2616         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
2617         protocol-test.js uses to load the inspector frontend stub into its iframe
2618         from an arbitrary local file URL.
2619
2620         * DumpRenderTree/TestRunner.cpp:
2621         (getInspectorTestStubURLCallback):
2622         (TestRunner::staticValues):
2623         * DumpRenderTree/TestRunner.h:
2624         * DumpRenderTree/mac/TestRunnerMac.mm:
2625         (SOFT_LINK_STAGED_FRAMEWORK):
2626         (TestRunner::inspectorTestStubURL):
2627         * DumpRenderTree/win/TestRunnerWin.cpp:
2628         (TestRunner::inspectorTestStubURL):
2629         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2630         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2631         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2632         (WTR::TestRunner::inspectorTestStubURL):
2633         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2634         (WTR::TestRunner::inspectorTestStubURL):
2635         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2636         (WTR::TestRunner::inspectorTestStubURL):
2637
2638 2015-08-17  Saam barati  <sbarati@apple.com>
2639
2640         Change email address from saambarati1@gmail.com to sbarati@apple.com
2641
2642         * Scripts/webkitpy/common/config/contributors.json:
2643
2644 2015-08-17  Jason Marcell  <jmarcell@apple.com>
2645
2646         Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
2647         repositories other than "openSource" and "internal".
2648         https://bugs.webkit.org/show_bug.cgi?id=147961
2649
2650         Reviewed by Daniel Bates.
2651
2652         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2653         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
2654         generically with repositories other than "openSource" and "internal".
2655
2656 2015-08-17  Alexey Proskuryakov  <ap@apple.com>
2657
2658         build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
2659         https://bugs.webkit.org/show_bug.cgi?id=148081
2660
2661         Reviewed by Tim Horton.
2662
2663         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2664         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2665
2666 2015-08-11  Andy Estes  <aestes@apple.com>
2667
2668         [Cocoa] Add redirect support to CustomProtocolManager
2669         https://bugs.webkit.org/show_bug.cgi?id=147871
2670
2671         Reviewed by Dan Bernstein.
2672
2673         Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
2674
2675         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2676         (TestWebKitAPI::TEST): Unregesitered TestProtocol.
2677         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
2678         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2679         (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
2680         (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
2681         (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
2682         (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
2683         (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
2684         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2685         (TestWebKitAPI::TEST): Unregistered TestProtocol.
2686         * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
2687         (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
2688         (-[TestProtocol startLoading]): Taught to handle redirect responses.
2689
2690 2015-08-13  Andy Estes  <aestes@apple.com>
2691
2692         [Cocoa] Downloads do not start if policy decision is made asynchronously
2693         https://bugs.webkit.org/show_bug.cgi?id=147985
2694
2695         Reviewed by Brady Eidson.
2696
2697         Added a new API test.
2698
2699         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2700         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2701         (-[AsynchronousDownloadDelegate _downloadDidStart:]):
2702         (TEST):
2703
2704 2015-08-14  Commit Queue  <commit-queue@webkit.org>
2705
2706         Unreviewed, rolling out r187357.
2707         https://bugs.webkit.org/show_bug.cgi?id=148032
2708
2709         webkit-patch generates incorrect patches that cannot be
2710         applied (Requested by dydz on #webkit).
2711
2712         Reverted changeset:
2713
2714         "Call fixChangeLogPatch when generating patches from webkit-
2715         patch"
2716         https://bugs.webkit.org/show_bug.cgi?id=147248
2717         http://trac.webkit.org/changeset/187357
2718
2719 2015-08-14  Jason Marcell  <jmarcell@apple.com>
2720
2721         Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
2722         other than "openSource" and "internal".
2723         https://bugs.webkit.org/show_bug.cgi?id=147938
2724
2725         Reviewed by Daniel Bates.
2726
2727         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2728         (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
2729         repositories other than "openSource" and "internal".
2730
2731 2015-08-14  Filip Pizlo  <fpizlo@apple.com>
2732
2733         Unreviewed, shorten another test that is timing out.
2734
2735         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2736         (TestWebKitAPI::TEST):
2737
2738 2015-08-13  Aakash Jain  <aakash_jain@apple.com>
2739
2740         AppScale: Assertion hit when hovering a webkit-queue bubble
2741         https://bugs.webkit.org/show_bug.cgi?id=147997
2742
2743         Reviewed by Alexey Proskuryakov.
2744
2745         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
2746         (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
2747
2748 2015-08-13  Lucas Forschler  <lforschler@apple.com>
2749
2750         Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
2751         
2752         Unreviewed.
2753         
2754         * Scripts/copy-webkitlibraries-to-product-directory:
2755
2756 2015-08-13  Dewei Zhu  <dewei_zhu@apple.com>
2757
2758         Run benchmark customized Dromaeo should not assume there is an internet connection.
2759         https://bugs.webkit.org/show_bug.cgi?id=147995
2760
2761         Reviewed by Ryosuke Niwa.
2762
2763         Add several dependency js libs to local.
2764
2765         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
2766
2767 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
2768
2769         WTF should have a compact Condition object to use with Lock
2770         https://bugs.webkit.org/show_bug.cgi?id=147986
2771
2772         Reviewed by Geoffrey Garen.
2773
2774         Add a test for WTF::Condition.
2775
2776         * TestWebKitAPI/CMakeLists.txt:
2777         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2778         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2779         * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
2780         (TestWebKitAPI::TEST):
2781         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2782         (TestWebKitAPI::runLockTest): Change the name of the thread.
2783
2784 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
2785
2786         Unreviewed, shorten another test. It's timing out in debug on some bot.
2787
2788         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2789         (TestWebKitAPI::TEST):
2790
2791 2015-08-12  Filip Pizlo  <fpizlo@apple.com>
2792
2793         WTF::Lock should not suffer from the thundering herd
2794         https://bugs.webkit.org/show_bug.cgi?id=147947
2795
2796         Reviewed by Geoffrey Garen.
2797
2798         Add testing that checks that locks return to a pristine state after contention is over.
2799
2800         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2801         (TestWebKitAPI::LockInspector::isFullyReset):
2802         (TestWebKitAPI::runLockTest):
2803         (TestWebKitAPI::TEST):
2804
2805 2015-08-12  Dewei Zhu  <dewei_zhu@apple.com>
2806
2807         Benchmarks supported by run_benchmark script should not assume we have internet access.
2808         https://bugs.webkit.org/show_bug.cgi?id=147959
2809
2810         Reviewed by Ryosuke Niwa.
2811
2812         For JSBench we should not request jquery.min.js from google through the internet.
2813
2814         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
2815
2816 2015-08-12  Jason Marcell  <jmarcell@apple.com>
2817
2818         Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
2819         other than "openSource" and "internal".
2820         https://bugs.webkit.org/show_bug.cgi?id=147796
2821
2822         Reviewed by Daniel Bates.
2823
2824         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2825         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
2826         is now a repository object instead of the repository name, thus we don't have to pass the "trac"
2827         object in separately. Also added an assertion to see if the given repository is in iteration.revision,
2828         and another assertion that, if the previousIteration is non-null, the given repository is in
2829         previousIteration.revision.
2830         (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
2831         with repositories other than "openSource" and "internal". Also added an assertion that the returned
2832         fragment has at least one child node.
2833
2834 2015-08-12  Simon Fraser  <simon.fraser@apple.com>
2835
2836         Add a tool that dumps class and struct member layout, showing padding
2837         https://bugs.webkit.org/show_bug.cgi?id=147898
2838
2839         Reviewed by Zalan Bujtas.
2840         
2841         This 'dump-class-layout' script uses the lldb Python bindings to collect data
2842         about data member layout, and displays it.
2843         
2844         Sample output:
2845
2846               +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
2847               +0 < 56>     WebCore::URL m_value;
2848               +0 <  8>         WTF::String m_string;
2849               +0 <  8>             WTF::RefPtr<WTF::StringImpl> m_impl;
2850               +0 <  8>                 WTF::StringImpl * m_ptr;
2851               +8 <  1>         bool:1 m_isValid;
2852               +8 <  1>         bool:1 m_protocolIsInHTTPFamily;
2853               +9 <  3>         <PADDING>
2854              +12 <  4>         int m_schemeEnd;
2855              +16 <  4>         int m_userStart;
2856              +20 <  4>         int m_userEnd;
2857              +24 <  4>         int m_passwordEnd;
2858              +28 <  4>         int m_hostEnd;
2859              +32 <  4>         int m_portEnd;
2860              +36 <  4>         int m_pathAfterLastSlash;
2861              +40 <  4>         int m_pathEnd;
2862              +44 <  4>         int m_queryEnd;
2863              +48 <  4>         int m_fragmentEnd;
2864              +52 <  4>         <PADDING>
2865              +52 <  4>     <PADDING>
2866              +56 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_prev;
2867              +64 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_next;
2868             Total byte size: 72
2869             Total pad bytes: 11
2870             Padding percentage: 15.28 %
2871
2872         * Scripts/dump-class-layout: Added.
2873         (webkit_build_dir):
2874         (developer_dir):
2875         (import_lldb):
2876         (find_build_directory):
2877         (verify_type):
2878         (verify_type_recursive):
2879         (dump_class):
2880         (main):
2881         (main.or):
2882
2883 2015-08-12  Alex Christensen  <achristensen@webkit.org>
2884
2885         Fix Debug CMake builds on Windows
2886         https://bugs.webkit.org/show_bug.cgi?id=147940
2887
2888         Reviewed by Chris Dumez.
2889
2890         * DumpRenderTree/PlatformWin.cmake:
2891         * TestWebKitAPI/PlatformWin.cmake:
2892         The BitmapImage test is not enabled on the AppleWin port.
2893         * WinLauncher/CMakeLists.txt:
2894         Debug builds need /NODEFAULTLIB:MSVCRTD, too.
2895
2896 2015-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2897
2898         Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
2899
2900         In r188125 I added a way to mark tests as slow to use a longer
2901         timeout. But it seems it was not enough for
2902         WTF_Lock.ContendedShortSection, so let's try again with a longer
2903         timeout now.
2904
2905         * Scripts/run-gtk-tests:
2906         (TestRunner._run_google_test):
2907
2908 2015-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
2909
2910         Allow --debug option in run-jsc
2911         https://bugs.webkit.org/show_bug.cgi?id=147923
2912
2913         Reviewed by Csaba Osztrogonác.
2914
2915         When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
2916
2917         * Scripts/run-jsc:
2918
2919 2015-08-11  Alex Christensen  <achristensen@webkit.org>
2920
2921         Fix test after build fix in r188286.
2922         https://bugs.webkit.org/show_bug.cgi?id=147907
2923
2924         Reviewed by Anders Carlsson.
2925
2926         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2927         sleep_for can now be used, but we need to include <thread>
2928
2929 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
2930
2931         Always use a byte-sized lock implementation
2932         https://bugs.webkit.org/show_bug.cgi?id=147908
2933
2934         Reviewed by Geoffrey Garen.
2935
2936         All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
2937         now tests of Lock.
2938
2939         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2940         (TestWebKitAPI::runLockTest):
2941         (TestWebKitAPI::TEST):
2942
2943 2015-08-11  Alexey Proskuryakov  <ap@apple.com>
2944
2945         Make ASan build not depend on asan.xcconfig
2946         https://bugs.webkit.org/show_bug.cgi?id=147840
2947         rdar://problem/21093702
2948
2949         Reviewed by Daniel Bates.
2950
2951         * asan/asan.xcconfig:
2952         * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
2953         are now marked in source code.
2954
2955 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
2956
2957         Unreviewed, shorten another test since it timed out.
2958
2959         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2960         (TestWebKitAPI::TEST):
2961
2962 2015-08-11  Mark Lam  <mark.lam@apple.com>
2963
2964         Fix names of Lock tests: should be "Contended", not "Contented".
2965         https://bugs.webkit.org/show_bug.cgi?id=147905
2966
2967         Reviewed by Saam Barati.
2968
2969         We're testing the behavior of lock contention (i.e. when threads contend), not
2970         whether the locks are happy (contented).
2971
2972         * Scripts/run-gtk-tests:
2973         (TestRunner):
2974         (TestRunner.__init__): Deleted.
2975         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2976         (TestWebKitAPI::runLockTest):
2977         (TestWebKitAPI::TEST):
2978
2979 2015-08-11  Alex Christensen  <achristensen@webkit.org>
2980
2981         Update WinCairoRequirements to VS2015.
2982
2983         * Scripts/update-webkit-wincairo-libs:
2984         Update WinCairoRequirements location.
2985
2986 2015-08-11  Jason Marcell  <jmarcell@apple.com>
2987
2988         Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
2989         for internalTrac.
2990         https://bugs.webkit.org/show_bug.cgi?id=147805
2991
2992         Reviewed by Daniel Bates.
2993
2994         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2995         (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
2996         Dashboard.Repository.Internal.trac for internalTrac.
2997         (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
2998         and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
2999         respectively.
3000         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
3001         (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
3002         Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
3003         internalTrac.
3004         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
3005         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
3006         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3007         (Analyzer): Ditto.
3008         (Analyzer.prototype.analyze): Ditto.
3009
3010 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
3011
3012         Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
3013
3014         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3015         (TestWebKitAPI::TEST):
3016
3017 2015-08-11  Brent Fulgham  <bfulgham@apple.com>
3018
3019         [Win] Switch Windows build to Visual Studio 2015
3020         https://bugs.webkit.org/show_bug.cgi?id=147887
3021         <rdar://problem/22235098>
3022
3023         Reviewed by Alex Christensen.
3024
3025         Update Visual Studio project file settings to use the current Visual
3026         Studio and compiler. Continue targeting binaries to run on our minimum
3027         supported configuration of Windows 7.
3028
3029         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3030         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3031         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3032         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3033         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3034         * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
3035         prefer the newer MSBuild included in Visual Studio 2015.
3036         (visualStudioInstallDir):
3037         (msBuildInstallDir):
3038         (visualStudioVersion):
3039         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3040         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3041         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3042         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3043         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3044         * win/record-memory/record-memory.vcxproj:
3045
3046 2015-08-11  Alex Christensen  <achristensen@webkit.org>
3047
3048         Another speculative build fix after r188280.
3049
3050         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3051         std::this_thread is too modern c++ for VS2013 and supported GCC versions, 
3052         so let's go back to usleep and I made something close to usleep, but with much lower resolution.
3053
3054 2015-08-11  Alex Christensen  <achristensen@webkit.org>
3055
3056         Unreviewed build fix after r188280.
3057
3058         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3059         Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
3060
3061 2015-08-10  Filip Pizlo  <fpizlo@apple.com>
3062
3063         WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
3064         https://bugs.webkit.org/show_bug.cgi?id=147665
3065
3066         Reviewed by Mark Lam.
3067
3068         * TestWebKitAPI/CMakeLists.txt:
3069         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3070         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3071         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3072         (TestWebKitAPI::TEST):
3073         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
3074         (TestWebKitAPI::TEST):
3075
3076 2015-08-11  Brian Burg  <bburg@apple.com>
3077
3078         webkit-patch should not explode when $EDITOR is set incorrectly
3079         https://bugs.webkit.org/show_bug.cgi?id=147884
3080
3081         Reviewed by Darin Adler.
3082
3083         If $EDITOR doesn't exist, log a warning and continue.
3084
3085         * Scripts/webkitpy/common/system/user.py: 
3086         (User.edit):
3087         (User.edit_changelog):
3088
3089 2015-08-11  Dan Bernstein  <mitz@apple.com>
3090
3091         Reverted r188255, because it turned out that delegates do nonot need this information.
3092
3093         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3094         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
3095
3096 2015-08-11  Dan Bernstein  <mitz@apple.com>
3097
3098         [Cocoa] The UI delegate can't tell if printing was user-initiated
3099         https://bugs.webkit.org/show_bug.cgi?id=147869
3100
3101         Reviewed by Sam Weinig.
3102
3103         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3104         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
3105         (-[PrintFrameController webView:didFinishNavigation:]):
3106         (-[PrintFrameController _webView:printFrame:userInitiated:]):
3107         (TEST):
3108
3109 2015-08-10  Alex Christensen  <achristensen@webkit.org>
3110
3111         Another build fix after r188239.
3112
3113         * TestWebKitAPI/PlatformWin.cmake:
3114         Link with more libraries.
3115         * WinLauncher/CMakeLists.txt:
3116         /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
3117
3118 2015-08-10  Ryosuke Niwa  <rniwa@webkit.org>
3119
3120         Build fix after r188237.
3121
3122         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
3123         (BenchmarkBuilder.__enter__):
3124
3125 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
3126
3127         Update ReadMe and correct the way to use abstract abstract class.
3128         https://bugs.webkit.org/show_bug.cgi?id=147860
3129
3130         Reviewed by Ryosuke Niwa.
3131
3132         Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
3133         so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
3134
3135         * Scripts/webkitpy/benchmark_runner/README.md:
3136         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3137         (BrowserDriver):
3138         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3139         (OSXBrowserDriver.restore_env):
3140         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
3141         (HTTPServerDriver):
3142         (HTTPServerDriver.set_device_id):
3143         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3144         (SimpleHTTPServerDriver.get_return_code):
3145         (SimpleHTTPServerDriver):
3146         (SimpleHTTPServerDriver.set_device_id):
3147
3148 2015-08-10  Alex Christensen  <achristensen@webkit.org>
3149
3150         Build TestWebKitAPI with CMake on Windows
3151         https://bugs.webkit.org/show_bug.cgi?id=147851
3152
3153         Reviewed by Chris Dumez.
3154
3155         * CMakeLists.txt:
3156         * TestWebKitAPI/CMakeLists.txt:
3157         Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
3158         Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
3159         Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win 
3160         before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
3161         * TestWebKitAPI/PlatformEfl.cmake:
3162         * TestWebKitAPI/PlatformGTK.cmake:
3163         Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
3164         I did this without changing the directory structure of the existing EFL and GTK builds.
3165         * TestWebKitAPI/PlatformWin.cmake: Added.
3166         * TestWebKitAPI/win/main.cpp:
3167         (main):
3168         (dllLauncherEntryPoint):
3169         Added so we can launch TestWebKitAPI executables after finding the AAS directory.
3170         * WinLauncher/CMakeLists.txt:
3171         AppleWin port needs /NODEFAULTLIB:MSVCRT.
3172
3173 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
3174
3175         Make cleanup more robust and minor code cleaning in run benchmark script.
3176         https://bugs.webkit.org/show_bug.cgi?id=147800
3177
3178         Reviewed by Ryosuke Niwa.
3179
3180         Use 'finnaly' block to make sure cleanup code is always executed.
3181
3182         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3183         (built_benchmark):
3184         (built_benchmark.__init__):
3185         (built_benchmark.__enter__):
3186         (built_benchmark.__exit__):
3187         (test_environment):
3188         (test_environment.__init__):
3189         (test_environment.__enter__):
3190         (test_environment.__exit__):
3191         (BenchmarkRunner.__init__):
3192         (BenchmarkRunner.execute):
3193         (BenchmarkRunner._dump):
3194         (BenchmarkRunner._wrap):
3195         (BenchmarkRunner): Deleted.
3196         (BenchmarkRunner._cleanup): Deleted.
3197         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
3198         (BrowserDriver.close_browsers):
3199         (BrowserDriver):
3200         (BrowserDriver.restore_env):
3201         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3202         (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
3203
3204 2015-08-10  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3205
3206         Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
3207         https://bugs.webkit.org/show_bug.cgi?id=146414
3208
3209         Reviewed by Darin Adler.
3210
3211         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3212         (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
3213
3214 2015-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3215
3216         [GTK] Test  /webkit2/WebKitWebView/submit-form is flaky
3217         https://bugs.webkit.org/show_bug.cgi?id=147727
3218
3219         Reviewed by Sergio Villar Senin.
3220
3221         I think it was not this test in particular, but
3222         /webkit2/WebKitWebView/custom-charset that is affecting the
3223         others. This is because changing the encoding reloads the page,
3224         but we don't wait for the page to be reloaded, so when the test
3225         finishes and other test starts the web process is still reloading
3226         the page.
3227
3228         * Scripts/run-gtk-tests:
3229         (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
3230         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3231         (testWebViewCustomCharset): Wait until page is reloaded after
3232         changing the charset.
3233
3234 2015-08-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3235
3236         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
3237
3238         It's timing out in the bots. My guess is that there's no installer
3239         installed in the bots and gst_install_plugins_supported() returns
3240         false, so we don't even get a permission request because no
3241         installer will be launched.
3242
3243         * Scripts/run-gtk-tests:
3244         (TestRunner):
3245
3246 2015-08-07  Alex Christensen  <achristensen@webkit.org>
3247
3248         [GTK] Another build fix after r188157.
3249
3250         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3251         (WTR::PlatformWebView::viewSupportsOptions):
3252         Name all the things correctly!
3253
3254 2015-08-07  Alex Christensen  <achristensen@webkit.org>
3255
3256         [EFL, GTK] Build fix after r188176.
3257
3258         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3259         I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
3260
3261 2015-08-07  Alex Christensen  <achristensen@webkit.org>
3262
3263         [GTK] Speculative build fix after r188157.
3264
3265         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3266         (WTR::PlatformWebView::PlatformWebView):
3267         Update parameter list.
3268
3269 2015-08-07  Alex Christensen  <achristensen@webkit.org>
3270
3271         Build more testing binaries with CMake on Windows
3272         https://bugs.webkit.org/show_bug.cgi?id=147799
3273
3274         Reviewed by Brent Fulgham.
3275
3276         * DumpRenderTree/CMakeLists.txt:
3277         Build TestNetscapePlugin.
3278         * DumpRenderTree/PlatformWin.cmake:
3279         Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
3280         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
3281         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
3282         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
3283         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
3284         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
3285         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
3286         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
3287         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
3288
3289 2015-08-07  Jason Marcell  <jmarcell@apple.com>
3290
3291         Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
3292         https://bugs.webkit.org/show_bug.cgi?id=147667
3293
3294         Reviewed by Daniel Bates.
3295
3296         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3297         (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
3298         other than "openSource" and "internal".
3299         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
3300         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3301         (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
3302         (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
3303         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3304         (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
3305         (sortedPlatforms): Deleted.
3306         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3307         (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
3308         (sortedPlatforms): Deleted.
3309         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3310         (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
3311         and sorts them by this property returning the new sorted array.
3312
3313 2015-08-07  Filip Pizlo  <fpizlo@apple.com>
3314
3315         Lightweight locks should be adaptive
3316         https://bugs.webkit.org/show_bug.cgi?id=147545
3317
3318         Reviewed by Geoffrey Garen.
3319
3320         * TestWebKitAPI/CMakeLists.txt:
3321         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3322         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3323         * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
3324         (TestWebKitAPI::runLockTest):
3325         (TestWebKitAPI::TEST):
3326
3327 2015-08-07  Anders Carlsson  <andersca@apple.com>
3328
3329         Fix a tyop.
3330
3331         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3332         (WTR::PlatformWebView::viewSupportsOptions):
3333
3334 2015-08-07  Alexey Proskuryakov  <ap@apple.com>
3335
3336         Update AppEngine app version numbers to the latest commit.
3337
3338         * QueueStatusServer/app.yaml:
3339         * TestResultServer/app.yaml:
3340
3341 2015-08-07  Anders Carlsson  <andersca@apple.com>
3342
3343         Simplify WKTR's view options
3344         https://bugs.webkit.org/show_bug.cgi?id=147791
3345
3346         Reviewed by Sam Weinig.
3347
3348         Instead of using a WKDictionaryRef, just use a struct for the options.
3349
3350         * WebKitTestRunner/PlatformWebView.h:
3351         (WTR::PlatformWebView::options):
3352         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
3353         * WebKitTestRunner/TestController.cpp:
3354         (WTR::TestController::initialize):
3355         (WTR::TestController::createWebViewWithOptions):
3356         (WTR::TestController::ensureViewSupportsOptions):
3357         (WTR::TestController::updateLayoutTypeForTest):
3358         * WebKitTestRunner/TestController.h:
3359         * WebKitTestRunner/ViewOptions.h: Added.
3360         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3361         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3362         (WTR::PlatformWebView::PlatformWebView):
3363         (WTR::PlatformWebView::viewSupportsOptions):
3364         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3365         (WTR::PlatformWebView::viewSupportsOptions):
3366         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3367         (WTR::PlatformWebView::viewSupportsOptions):
3368         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3369         (WTR::PlatformWebView::PlatformWebView):
3370         (WTR::PlatformWebView::viewSupportsOptions):
3371         * WebKitTestRunner/mac/TestControllerMac.mm:
3372         (WTR::TestController::platformConfigureViewForTest):
3373
3374 2015-08-07  Joseph Pecoraro  <pecoraro@apple.com>
3375
3376         Running tests for a long time results in some tests running very slowly (throttling)
3377         https://bugs.webkit.org/show_bug.cgi?id=147718
3378
3379         Reviewed by Chris Dumez.
3380
3381         Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
3382         Although COCOA ports default this setting to be disabled in WebKit1,
3383         we should make both test harnesses disable the setting for consistency.
3384
3385         * DumpRenderTree/mac/DumpRenderTree.mm:
3386         (resetWebPreferencesToConsistentValues):
3387
3388 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
3389
3390         Use a specific version of Speedometer in run-benchmark
3391         https://bugs.webkit.org/show_bug.cgi?id=147769
3392
3393         Reviewed by Chris Dumez.
3394
3395         Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
3396
3397         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
3398
3399 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
3400
3401         twisted_http_server.py should support --port
3402         https://bugs.webkit.org/show_bug.cgi?id=147771
3403
3404         Reviewed by Chris Dumez.
3405
3406         Added the option. This makes the script more useful on its own.
3407
3408         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3409
3410 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3411
3412         [GTK] WTF unit tests are timing out in the bots
3413         https://bugs.webkit.org/show_bug.cgi?id=147777
3414
3415         Reviewed by Filip Pizlo.
3416
3417         Add a way to mark google unit tests as slow and add
3418         WTF_Lock.ContentedShortSection to the list. In case of slow test
3419         we use the double of the given timeout for that particular test.
3420
3421         * Scripts/run-gtk-tests:
3422         (TestRunner):
3423         (TestRunner._run_google_test):
3424
3425 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3426
3427         [GTK] run-gtk-tests should not stop when a google test case fails
3428         https://bugs.webkit.org/show_bug.cgi?id=147778
3429
3430         Reviewed by Philippe Normand.
3431
3432         For glib based tests we run the test runner with the -k option,
3433         but for google tests we are aborting as soon as we find a failure.
3434
3435         * Scripts/run-gtk-tests:
3436         (TestRunner._run_google_test_suite): Use a global return code that
3437         is set to 1 when any test has failed.
3438
3439 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3440
3441         [GStreamer] Do not automatically show PackageKit codec installation notifications
3442         https://bugs.webkit.org/show_bug.cgi?id=135973
3443
3444         Reviewed by Philippe Normand.
3445
3446         Handle the missing media plugins installation permission request
3447         in MiniBrowser and add a test case for the new API.
3448
3449         * MiniBrowser/gtk/BrowserWindow.c:
3450         (webViewDecidePermissionRequest):
3451         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3452         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
3453         (permissionRequestCallback):
3454         (testInstallMissingPluginsPermissionRequest):
3455         (beforeAll):
3456         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3457         (methodCallCallback):
3458
3459 2015-08-06  Joseph Pecoraro  <pecoraro@apple.com>
3460
3461         Running tests for a long time results in some tests running very slowly (throttling)
3462         https://bugs.webkit.org/show_bug.cgi?id=147718
3463
3464         Reviewed by Alexey Proskuryakov.
3465
3466         * WebKitTestRunner/TestController.cpp:
3467         (WTR::TestController::resetPreferencesToConsistentValues):
3468         Ensure throttling settings are disabled for tests for all ports, as
3469         COCOA ports default to having these setting enabled. Note, there is
3470         still other timer throttling not covered by these setting.
3471
3472 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
3473
3474         http_server_driver and benchmark_builder should not be in run-benchmark's plan files
3475         https://bugs.webkit.org/show_bug.cgi?id=147752
3476
3477         Reviewed by Chris Dumez.
3478
3479         Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
3480
3481         Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
3482         This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
3483
3484         * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
3485         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
3486         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
3487         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
3488         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
3489         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3490         (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
3491         HTTPServerDriverFactory taking the platform name as an argument.
3492         (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
3493         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
3494         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
3495         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
3496         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
3497         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
3498         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
3499         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
3500         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
3501         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
3502         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
3503         (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
3504         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
3505         (HTTPServerDriver): Replaced name by platforms.
3506         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3507         (SimpleHTTPServerDriver): Ditto.
3508         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3509         (parse_args): Removed --http-server-driver option.
3510         (start): Ditto.
3511
3512 2015-08-06  Chris Dumez  <cdumez@apple.com>
3513
3514         Toggle GPS state based on page visibility to save battery
3515         https://bugs.webkit.org/show_bug.cgi?id=147685
3516
3517         Reviewed by Benjamin Poulain.
3518
3519         Add testRunner.isGeolocationProviderActive() test support function.
3520
3521         * DumpRenderTree/TestRunner.cpp:
3522         (isGeolocationProviderActiveCallback):
3523         (TestRunner::staticFunctions):
3524         * DumpRenderTree/TestRunner.h:
3525         * DumpRenderTree/mac/MockGeolocationProvider.h:
3526         * DumpRenderTree/mac/MockGeolocationProvider.mm:
3527         (-[MockGeolocationProvider isActive]):
3528         * DumpRenderTree/mac/TestRunnerMac.mm:
3529         (TestRunner::isGeolocationProviderActive):
3530         * DumpRenderTree/win/TestRunnerWin.cpp:
3531         (TestRunner::isGeolocationProviderActive):
3532         * WebKitTestRunner/GeolocationProviderMock.h:
3533         (WTR::GeolocationProviderMock::isActive):
3534         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3535         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3536         (WTR::InjectedBundle::isGeolocationProviderActive):
3537         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3538         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3539         (WTR::TestRunner::isGeolocationProviderActive):
3540         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3541         * WebKitTestRunner/TestController.cpp:
3542         (WTR::TestController::isGeolocationProviderActive):
3543         * WebKitTestRunner/TestController.h:
3544         * WebKitTestRunner/TestInvocation.cpp:
3545         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3546
3547 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
3548
3549         Automate JSBench with run-benchmark
3550         https://bugs.webkit.org/show_bug.cgi?id=147716
3551
3552         Reviewed by Chris Dumez.
3553
3554         Added JSBench plan to run-benchmark.
3555
3556         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
3557         (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
3558         (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
3559         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
3560         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
3561         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
3562         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
3563         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
3564         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.