98370f6d9fa8404fe5701e80335677733cec0c40
[WebKit-https.git] / Tools / ChangeLog
1 2014-12-09  Csaba Osztrogonác  <ossy@webkit.org>
2
3         Blink Merge: Remove 'http_lock' code from webkitpy
4         https://bugs.webkit.org/show_bug.cgi?id=136722
5
6         Reviewed by Alexey Proskuryakov.
7
8         Based on Blink commit by Dirk Pranke <dpranke@chromium.org>
9         https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66
10
11         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
12         (LayoutTestRunner.__init__):
13         (LayoutTestRunner.run_tests):
14         (LayoutTestRunner.start_servers): Renamed from start_servers_with_lock.
15         (LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock.
16         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
17         (FakePrinter.flush):
18         (LayoutTestRunnerTests._runner):
19         (LayoutTestRunnerTests._run_tests):
20         (LayoutTestRunnerTests.test_servers_started):
21         (LockCheckingRunner): Deleted.
22         (LockCheckingRunner.__init__): Deleted.
23         (LockCheckingRunner.handle_finished_list): Deleted.
24         (LayoutTestRunnerTests.test_http_locking): Deleted.
25         * Scripts/webkitpy/port/base.py:
26         (Port.__init__):
27         (Port.to.http_server_supports_ipv6):
28         (Port.to.stop_websocket_server):
29         (Port.to.acquire_http_lock): Deleted.
30         (Port.to.release_http_lock): Deleted.
31         * Scripts/webkitpy/port/http_lock.py: Removed.
32         * Scripts/webkitpy/port/http_lock_unittest.py: Removed.
33         * Scripts/webkitpy/port/ios.py:
34         (IOSSimulatorPort.show_results_html_file):
35         (IOSSimulatorPort.acquire_http_lock): Deleted.
36         (IOSSimulatorPort): Deleted.
37         (IOSSimulatorPort.release_http_lock): Deleted.
38         * Scripts/webkitpy/port/mac.py:
39         (MacPort.show_results_html_file):
40         (MacPort): Deleted.
41         (MacPort.acquire_http_lock): Deleted.
42         (MacPort.release_http_lock): Deleted.
43         * Scripts/webkitpy/port/mock_drt.py:
44         (MockDRTPort.start_websocket_server):
45         (MockDRTPort.stop_websocket_server):
46         (MockDRTPort.acquire_http_lock): Deleted.
47         (MockDRTPort.release_http_lock): Deleted.
48         * Scripts/webkitpy/port/mock_drt_unittest.py:
49         (MockDRTPortTest.test_uses_apache):
50         (MockDRTPortTest.integration_test_http_lock): Deleted.
51         * Scripts/webkitpy/port/port_testcase.py:
52         (PortTestCase.assert_servers_are_up):
53         (PortTestCase.integration_test_http_lock): Deleted.
54         * Scripts/webkitpy/port/test.py:
55         (TestPort.start_websocket_server):
56         (TestPort.stop_websocket_server):
57         (TestPort.acquire_http_lock): Deleted.
58         (TestPort.release_http_lock): Deleted.
59
60 2014-12-09  Alberto Garcia  <berto@igalia.com>
61
62         convertToUTF8String converts null string to empty string
63         https://bugs.webkit.org/show_bug.cgi?id=133904
64
65         Reviewed by Carlos Garcia Campos.
66
67         Test that trying to get the value of a non-existent attribute
68         returns 0 instead of an empty string.
69
70         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
71         (WebKitDOMNodeTest::testInsertion):
72
73 2014-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
74
75         [GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2
76         https://bugs.webkit.org/show_bug.cgi?id=139070
77
78         Reviewed by Carlos Garcia Campos.
79
80         * gtk/jhbuild.modules:
81
82 2014-12-08  Tim Horton  <timothy_horton@apple.com>
83
84         Add action menu tests
85         https://bugs.webkit.org/show_bug.cgi?id=139156
86
87         Reviewed by Dean Jackson.
88
89         * TestWebKitAPI/PlatformWebView.h:
90         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
91         (TestWebKitAPI::PlatformWebView::PlatformWebView):
92         Add a mechanism allowing tests to provide their own WKView subclass.
93
94         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
95         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added.
96         Add a file with lots of menu targets.
97
98         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added.
99         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
100         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]):
101         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
102         Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process.
103
104         (-[ActionMenusTestWKView _setOverrideActionMenuItems:]):
105
106         (TestWebKitAPI::didFinishLoadForFrameCallback):
107         (TestWebKitAPI::didFinishDownloadCallback):
108         (TestWebKitAPI::didCreateDownloadDestinationCallback):
109         Watch downloads and ensure that they match the content we expect.
110
111         (TestWebKitAPI::watchPasteboardForString):
112         (TestWebKitAPI::watchPasteboardForImage):
113         (TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext):
114         (TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext):
115         (TestWebKitAPI::javaScriptStringCallback):
116         (TestWebKitAPI::javaScriptBoolCallback):
117         (TestWebKitAPI::callJavaScriptReturningString):
118         (TestWebKitAPI::callJavaScriptReturningBool):
119         (TestWebKitAPI::watchEditableAreaForString):
120         (TestWebKitAPI::waitForVideoReady):
121         (TestWebKitAPI::retrieveSelection):
122         (TestWebKitAPI::retrieveSelectionInElement):
123         (TestWebKitAPI::performMenuItemAtIndexOfTypeAsync):
124         (TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled):
125         Add many helpers for testing, especially to make asynchronous things synchronous.
126
127         (TestWebKitAPI::windowPointForTarget):
128         (TestWebKitAPI::inset8):
129         Hard-code points in action-menu-targets.html for hit testing.
130
131         (TestWebKitAPI::TEST):
132         Add a suite of tests for WebKit2 action menus.
133
134         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added.
135         (TestWebKitAPI::createActionContextForPhoneNumber):
136         (TestWebKitAPI::ActionMenuTest::ActionMenuTest):
137         (TestWebKitAPI::ActionMenuTest::prepareForActionMenu):
138         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
139         (TestWebKitAPI::ActionMenuTest::drawRect):
140         (TestWebKitAPI::ActionMenuTest::didCreatePage):
141         Add a bundle with a PageOverlay and a actionContextForResultAtPoint override,
142         so that we can test that infrastructure.
143
144 2014-12-08  Philippe Normand  <pnormand@igalia.com>
145
146         [GTK] UserMedia Permission Request API
147         https://bugs.webkit.org/show_bug.cgi?id=136449
148
149         Reviewed by Carlos Garcia Campos.
150
151         The GTK version of the MiniBrowser has gained UserMedia permission
152         request support.
153
154         * MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page
155         requires user permission to access audio/video devices.
156         (permissionRequestDialogCallback):
157         (webViewDecidePermissionRequest):
158         (geolocationRequestDialogCallback): Deleted.
159
160 2014-12-08  Anders Carlsson  <andersca@apple.com>
161
162         Add a stubbed out method for clearing out the website data store
163         https://bugs.webkit.org/show_bug.cgi?id=139404
164
165         Reviewed by Antti Koivisto.
166
167         Add a debug menu item for testing clearing of website data.
168
169         * MiniBrowser/mac/MainMenu.xib:
170         * MiniBrowser/mac/WK2BrowserWindowController.m:
171         (-[WK2BrowserWindowController clearWebsiteData:]):
172
173 2014-12-07  Gwang Yoon Hwang  <yoon@igalia.com>
174
175         Update style checker to deal with "const override"
176         https://bugs.webkit.org/show_bug.cgi?id=139371
177
178         Reviewed by Csaba Osztrogonác.
179
180         check-webkit-style shouldn't complain about an open brace to start a
181         line after a function definition with const override.
182
183         * Scripts/webkitpy/style/checkers/cpp.py:
184         (check_braces):
185         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
186         (CppStyleTest.test_brace_at_begin_of_line):
187
188 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
189
190         [GTK] Fix GObject DOM bindings API break tests after r176920
191         https://bugs.webkit.org/show_bug.cgi?id=139368
192
193         Reviewed by Gustavo Noronha Silva.
194
195         Remove the @version from the symbol name before comparing.
196
197         * gtk/check-for-webkitdom-api-breaks:
198         (read_expected_api):
199
200 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
201
202         Remove the option to automatically update the GObject DOM bindings symbols file
203         https://bugs.webkit.org/show_bug.cgi?id=139366
204
205         Reviewed by Martin Robinson.
206
207         It's currently broken, because symbols now need to be in a
208         specific order. Now that the symbols file only contains stable
209         API, it's not a problem to manually update it every time new API
210         is added.
211
212         * gtk/check-for-webkitdom-api-breaks:
213         (read_expected_api):
214         (check_api):
215         (write_expected_api): Deleted.
216
217 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
218
219         [GTK] Use GMainLoopSource in WebKitTestRunner
220         https://bugs.webkit.org/show_bug.cgi?id=138831
221
222         Reviewed by Sergio Villar Senin.
223
224         * WebKitTestRunner/InjectedBundle/TestRunner.h:
225         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
226         (WTR::TestRunner::platformInitialize):
227         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
228         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
229         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
230         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
231         (WTR::TestController::notifyDone):
232         (WTR::TestController::platformRunUntil):
233         (WTR::cancelTimeout): Deleted.
234
235 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
236
237         [GTK] Missing API detected in GObject DOM bindings after r176630
238         https://bugs.webkit.org/show_bug.cgi?id=139201
239
240         Reviewed by Gustavo Noronha Silva.
241
242         Handle deprecated symbols again when generating the GObject DOM
243         bindings documentation.
244
245         * gtk/webkitdom.py:
246         (WebKitDOMDocGenerator):
247         (WebKitDOMDocGenerator.is_deprecated_symbol_file):
248         (WebKitDOMDocGenerator.generate):
249         (WebKitDOMDocGeneratorSections.__init__):
250         (WebKitDOMDocGeneratorSections._find_deprecated_symbols):
251         (WebKitDOMDocGeneratorSections.write_section):
252
253 2014-12-07  Csaba Osztrogonác  <ossy@webkit.org>
254
255         [EFL][jhbuild] Fix libsoup build with clang
256         https://bugs.webkit.org/show_bug.cgi?id=139088
257
258         Reviewed by Gyuyoung Kim.
259
260         * efl/jhbuild.modules:
261         * efl/patches/soup-clang-warning-fix1.patch: Added.
262         * efl/patches/soup-clang-warning-fix2.patch: Added.
263
264 2014-12-06  Alexey Proskuryakov  <ap@apple.com>
265
266         [Mac] DumpRenderTree sets storage directory incorrectly
267         https://bugs.webkit.org/show_bug.cgi?id=139347
268
269         Reviewed by Dan Bernstein.
270
271         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
272         Don't use user defaults to pass per-instance paths, as user defaults are shared
273         across all instances.
274
275 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
276
277         AX: I cannot activate links on the mobile version of news.google.com
278         https://bugs.webkit.org/show_bug.cgi?id=139330
279
280         Reviewed by Simon Fraser.
281
282         Implement press for iOS.
283
284         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
285         (AccessibilityUIElement::press):
286
287 2014-12-05  Daniel Bates  <dabates@apple.com>
288
289         [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
290         https://bugs.webkit.org/show_bug.cgi?id=139326
291
292         Reviewed by Anders Carlsson.
293
294         Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
295         to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
296         using the same scale factor as used in WebKit.
297
298         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
299         (createBitmapContextFromWebView):
300
301 2014-12-05  Anders Carlsson  <andersca@apple.com>
302
303         REGRESSION (r176677): All tests crash on Windows
304         https://bugs.webkit.org/show_bug.cgi?id=139321
305
306         Reviewed by Alexey Proskuryakov.
307
308         * DumpRenderTree/win/DumpRenderTree.cpp:
309         (runTest):
310         Don't call CFRelease on the url while we have an outstanding pointer to its string,
311         and use the right number of bytes when allocating the testURL buffer.
312
313 2014-12-05  Daniel Bates  <dabates@apple.com>
314
315         [iOS] DumpRenderTree produces many reference test mismatches
316         https://bugs.webkit.org/show_bug.cgi?id=139314
317
318         Reviewed by Simon Fraser.
319
320         Fixes an issue where the scale factor used to render the snapshot taken by
321         DumpRenderTree may differ from the device scale factor. In particular, the
322         scale factor used to render a snapshot of a test may differ from the scale
323         factor used to render the snapshot of its expected result.
324
325         Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
326         snapshot the UIWebBrowserView. This SPI always render using a scale factor
327         of one when the backing store for the LegacyTileLayer objects were out-of-
328         date regardless of the device scale factor. Instead we should use UIImage
329         and CALayer API to perform the snapshot with respect to the device scale
330         factor.
331
332         Additionally write iOS pixel dump support logic in terms of existing
333         DumpRenderTree abstractions so as to support generating and comparing
334         pixel dump checksums as well as make the iOS code more consistent with
335         the logic used by other ports.
336
337         * DumpRenderTree/PixelDumpSupport.cpp:
338         (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
339         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
340         (BitmapContext::createFromUIImage): Added.
341         (BitmapContext::pixelData): Added.
342         (BitmapContext::BitmapContext): Added.
343         (computeMD5HashStringForBitmapContext): Added.
344         (dumpBitmap): Added.
345         (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
346         (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
347
348 2014-12-05  Anders Carlsson  <andersca@apple.com>
349
350         Give all web pages a website data store
351         https://bugs.webkit.org/show_bug.cgi?id=139317
352
353         Reviewed by Tim Horton.
354
355         * MiniBrowser/mac/AppDelegate.m:
356         (-[BrowserAppDelegate newPrivateWindow:]):
357         Don't release the controller - it's implicitly retained by the window.
358
359 2014-12-05  Daniel Bates  <dabates@apple.com>
360
361         [iOS] DumpRenderTree fails to render every other test when pixel tests are on
362         https://bugs.webkit.org/show_bug.cgi?id=137581
363         <rdar://problem/18642906>
364
365         Reviewed by Simon Fraser.
366
367         Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
368         of the test that proceeded the currently running test.
369
370         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
371         (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
372         of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
373         as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
374
375 2014-12-05  Jer Noble  <jer.noble@apple.com>
376
377         [WTF] MediaTime should support round-tripping from and to doubles.
378         https://bugs.webkit.org/show_bug.cgi?id=139248
379
380         Reviewed by Eric Carlson.
381
382         Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
383         the MediaTimes after this change.
384
385         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
386         (WTF::operator<<):
387         (TestWebKitAPI::TEST):
388         * lldb/lldb_webkit.py:
389         (WTFMediaTime_SummaryProvider):
390         (WTFMediaTimeProvider.timeValueAsDouble):
391         (WTFMediaTimeProvider.isIndefinite):
392         (WTFMediaTimeProvider):
393         (WTFMediaTimeProvider.hasDoubleValue):
394
395 2014-12-05  Anders Carlsson  <andersca@apple.com>
396
397         Add a private browsing mode to MiniBrowser
398         https://bugs.webkit.org/show_bug.cgi?id=139308
399
400         Reviewed by Sam Weinig.
401
402         * MiniBrowser/mac/AppDelegate.m:
403         (defaultConfiguration):
404         (-[BrowserAppDelegate newWindow:]):
405         (-[BrowserAppDelegate newPrivateWindow:]):
406         * MiniBrowser/mac/MainMenu.xib:
407         * MiniBrowser/mac/WK2BrowserWindowController.h:
408         * MiniBrowser/mac/WK2BrowserWindowController.m:
409         (-[WK2BrowserWindowController awakeFromNib]):
410         (-[WK2BrowserWindowController initWithConfiguration:]):
411         (-[WK2BrowserWindowController dealloc]):
412         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
413
414 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
415
416         Run http tests parallel
417         https://bugs.webkit.org/show_bug.cgi?id=138958
418
419         Reviewed by Daniel Bates.
420
421         Remove the concept of "locked shard". Now http tests are just like any other tests.
422         We start HTTP and WebSocket servers at the start if we need them, and terminate them
423         when done with all the tests (not when the last http test runs, which is unnecessarily
424         unpredictable).
425
426         This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
427         patch, they used to take over 15 minutes.
428
429         As part of the fix, we no longer pass the number of servers to Apache. I don't
430         think that these parameters did what we wanted them to do; Apache handles the load
431         just fine without them.
432
433         The change applies to all platforms. I fixed everything I could find on Mac, and
434         Ossy told me that he's been running http tests in parallel for a long time. If
435         there is increased instability for some ports, it will need to be fixed - there is
436         generally nothing special about http tests at this point, and most code is
437         cross-platform in WebKit2.
438
439         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
440         (LayoutTestRunner.__init__):
441         (LayoutTestRunner.run_tests):
442         (LayoutTestRunner.start_servers_with_lock):
443         (LayoutTestRunner._handle_started_test):
444         (Worker.handle):
445         (Sharder.__init__):
446         (Sharder.shard_tests):
447         (Sharder._shard_every_file):
448         (Sharder._shard_by_directory):
449         (LayoutTestRunner._handle_finished_test_list): Deleted.
450         (LayoutTestRunner._handle_finished_test_list.find): Deleted.
451         (Sharder._shard_in_two): Deleted.
452         (Sharder): Deleted.
453         (Sharder._resize_shards): Deleted.
454         (Sharder._resize_shards.divide_and_round_up): Deleted.
455         (Sharder._resize_shards.extract_and_flatten): Deleted.
456         (Sharder._resize_shards.split_at): Deleted.
457         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
458         (FakePrinter.print_workers_and_shards):
459         (LayoutTestRunnerTests.test_servers_started.start_http_server):
460         (LayoutTestRunnerTests.test_servers_started):
461         (SharderTests.get_shards):
462         (SharderTests.test_shard_by_dir):
463         (SharderTests.test_shard_every_file):
464         (SharderTests): Deleted.
465         (SharderTests.test_shard_in_two): Deleted.
466         (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
467         (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
468         (SharderTests.test_multiple_locked_shards): Deleted.
469         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
470         (ManagerTest.test_needs_servers.get_manager):
471         (ManagerTest.integration_test_needs_servers.get_manager):
472         (ManagerTest.test_look_for_new_crash_logs.get_manager):
473         (ManagerTest):
474         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
475         (_set_up_derived_options):
476         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
477         (RunTest.test_batch_size):
478         (RunTest.test_max_locked_shards): Deleted.
479         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
480         (LayoutTestApacheHttpd.__init__):
481         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
482         (TestLayoutTestApacheHttpd.test_start_cmd):
483         * Scripts/webkitpy/layout_tests/servers/http_server.py:
484         (Lighttpd.__init__):
485         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
486         (HttpServerBase.__init__):
487         * Scripts/webkitpy/layout_tests/views/printing.py:
488         (Printer.print_workers_and_shards):
489         * Scripts/webkitpy/port/base.py:
490         (Port.default_child_processes):
491         (Port.to.start_http_server):
492         (Port.default_max_locked_shards): Deleted.
493         * Scripts/webkitpy/port/port_testcase.py:
494         (PortTestCase.make_port):
495         (PortTestCase.test_default_max_locked_shards): Deleted.
496         * Scripts/webkitpy/port/test.py:
497         (TestPort.start_http_server):
498
499 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
500
501         Don't lock perf tests in run-webkit-tests
502         https://bugs.webkit.org/show_bug.cgi?id=139264
503
504         Reviewed by Daniel Bates.
505
506         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
507         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
508         * Scripts/webkitpy/layout_tests/controllers/manager.py:
509         * Scripts/webkitpy/layout_tests/models/test_input.py:
510         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
511
512 2014-12-03  Alexey Proskuryakov  <ap@apple.com>
513
514         http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
515         https://bugs.webkit.org/show_bug.cgi?id=139243
516
517         Reviewed by Anders Carlsson.
518
519         We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
520         chance to allow untrusted certificates.
521
522         * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
523         Set up more client objects for secondary windows. We may be able to share some of the
524         code with main view creation function, but it's not exactly the same (notably, we
525         do not focus a secondary window when it's done loading).
526
527 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
528
529         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
530         https://bugs.webkit.org/show_bug.cgi?id=139071
531
532         Reviewed by Chris Fleizach.
533
534         Add string value for ATK_ROLE_STATIC in roleToString.
535
536         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
537
538 2014-12-03  Renato Nagy  <rnagy@inf.u-szeged.hu>
539
540         check-webkit-style is confused by ternary expression inside first member initializer
541         https://bugs.webkit.org/show_bug.cgi?id=136442
542
543         Reviewed by Csaba Osztrogonác.
544
545         * Scripts/webkitpy/style/checkers/cpp.py:
546         (check_member_initialization_list):
547
548 2014-12-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
549
550         [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
551         https://bugs.webkit.org/show_bug.cgi?id=139220
552
553         Reviewed by Philippe Normand.
554
555         * gtk/jhbuild.modules:
556         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
557
558 2014-12-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
559
560         Remove unused JSC runtime options
561         https://bugs.webkit.org/show_bug.cgi?id=133070
562
563         Reviewed by Csaba Osztrogonác.
564
565         * Scripts/run-jsc-stress-tests:
566
567 2014-12-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
568
569         [EFL] Add subtle crypto to the build system
570         https://bugs.webkit.org/show_bug.cgi?id=138612
571
572         Reviewed by Csaba Osztrogonác.
573
574         * Scripts/webkitperl/FeatureList.pm:
575
576 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
577
578         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
579         https://bugs.webkit.org/show_bug.cgi?id=139005
580
581         Reviewed by Chris Fleizach.
582
583         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
584         Add mapping for ATK_ROLE_CAPTION to roleToString
585
586 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
587
588         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
589         https://bugs.webkit.org/show_bug.cgi?id=139149
590
591         Reviewed by Anders Carlsson.
592
593         WebKit2 already cleared application caches between runs (although it wasn't entirely
594         effective without WebCore changes in this patch).
595
596         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
597
598         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
599         function is not implemented on Windows, see below).
600
601         * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
602         Ameded a FIXME.
603
604 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
605
606         Generalize PageActivityAssertionToken
607         https://bugs.webkit.org/show_bug.cgi?id=139106
608
609         Reviewed by Sam Weinig.
610
611         Add an API test for WTF::RefCounter.
612
613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
614         * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
615         (TestWebKitAPI::TEST):
616             - added RefCounter test.
617
618 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
619
620         [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
621         https://bugs.webkit.org/show_bug.cgi?id=139174
622
623         Reviewed by Simon Fraser.
624
625         * DumpRenderTree/TestRunner.cpp:
626         * DumpRenderTree/TestRunner.h:
627         Renamed testPathOrURL to testURL, because this variable always contains a URL.
628
629         * DumpRenderTree/mac/DumpRenderTree.mm:
630         (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
631         (testPathFromURL): Moved from FrameLoadDelegate.mm.
632         (runTest): Set crash reporter information here, as we know the exact test URL.
633
634         * DumpRenderTree/mac/FrameLoadDelegate.mm:
635         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
636         reporter information here.
637
638         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
639         * DumpRenderTree/mac/TestRunnerMac.mm:
640         Updated for testPathOrURL renaming.
641
642         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
643         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
644         test URL until load starts, so save it into TestRunner now. A new TestRunner object
645         is created for each test.
646
647         * WebKitTestRunner/InjectedBundle/TestRunner.h:
648         (WTR::TestRunner::testURL):
649         (WTR::TestRunner::setTestURL):
650         Make TestRunner know the test name. For now, it's good enough to have it once load
651         starts, but if we ever need it earlier, we can send it with BeginTest message.
652
653         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
654         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
655         Use test URL, not currently loading URL for CrashReporter.
656
657         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
658         (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
659         (WebKit1 already had it right).
660
661         * DumpRenderTree/win/DumpRenderTree.cpp:
662         (sizeWebViewForCurrentTest):
663         (runTest):
664         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
665         (ResourceLoadDelegate::willSendRequest):
666         Changed Windows DumpRenderTree to also use URL in TestRunner.
667
668 2014-12-02  Daniel Bates  <dabates@apple.com>
669
670         [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
671         https://bugs.webkit.org/show_bug.cgi?id=139143
672
673         Reviewed by David Kilzer.
674
675         Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
676         teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
677         crashes. Run-webkit-tests will record as crashing the test associated with the
678         DumpRenderTree instance that wrote that string.
679
680         Currently almost all of the DumpRenderTree.app crashes are recorded by run-
681         webkit-tests as a time-out because ReportCrash(8) delays delivery of the
682         process exit notification for DumpRenderTree.app to LayoutTestRelay, which
683         launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
684         was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
685         (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
686         about a crash.
687
688         Additionally, update the crash message format written to standard error when LayoutTestRelay
689         detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
690         crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
691         Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
692         when they crash in their test machinery logic/UI process code.
693
694         * DumpRenderTree/mac/DumpRenderTree.mm:
695         (writeCrashedMessageOnFatalError): Added.
696         (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
697         SIGILL, SIGFPE, SIGBUS and SIGSEGV.
698         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
699         (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
700         similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
701         the crash logs for WebKitTestRunner/DumpRenderTree.app.
702         * Scripts/webkitpy/port/driver.py:
703         (Driver.__init__): Update comment.
704         (Driver._check_for_driver_crash): Ditto.
705         * Scripts/webkitpy/port/ios.py:
706         (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
707         regular expression. This constant is used as an optimization to avoid compiling the same
708         regular expression across invocations of _get_crash_log().
709         (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
710         for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
711         closer to where they are used.
712
713 2014-12-01  Anders Carlsson  <andersca@apple.com>
714
715         Remove WKBundleRemoveAllVisitedLinks
716         https://bugs.webkit.org/show_bug.cgi?id=139163
717
718         Reviewed by Sam Weinig.
719
720         Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
721
722         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
723         (WTR::InjectedBundle::beginTesting):
724         * WebKitTestRunner/TestInvocation.cpp:
725         (WTR::TestInvocation::invoke):
726
727 2014-12-02  Anders Carlsson  <andersca@apple.com>
728
729         Fix Windows build.
730
731         * DumpRenderTree/win/DumpRenderTree.cpp:
732         (setAlwaysAcceptCookies):
733
734 2014-12-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
735
736         [EFL] Remove edbus dependency from jhbuild
737         https://bugs.webkit.org/show_bug.cgi?id=139130
738
739         Reviewed by Gyuyoung Kim.
740
741         After http://trac.webkit.org/changeset/176555 we
742         don't need it anymore.
743
744         * efl/jhbuild.modules:
745
746 2014-12-02  Philippe Normand  <pnormand@igalia.com>
747
748         [jhbuild] wrong Dependencies path
749         https://bugs.webkit.org/show_bug.cgi?id=139176
750
751         Reviewed by Martin Robinson.
752
753         * Scripts/webkitpy/port/base.py:
754         (Port._should_use_jhbuild):
755
756 2014-12-02  Philippe Normand  <pnormand@igalia.com>
757
758         [GStreamer] Bump internal jhbuild versions to 1.4.4
759         https://bugs.webkit.org/show_bug.cgi?id=138866
760
761         Reviewed by Carlos Garcia Campos.
762
763         * gtk/jhbuild.modules:
764         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
765         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
766         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
767
768 2014-12-01  Commit Queue  <commit-queue@webkit.org>
769
770         Unreviewed, rolling out r176566.
771         https://bugs.webkit.org/show_bug.cgi?id=139124
772
773         It broke the GTK performance tests. (Requested by clopez on
774         #webkit).
775
776         Reverted changeset:
777
778         "[GTK] Use GMainLoopSource in WebKitTestRunner"
779         https://bugs.webkit.org/show_bug.cgi?id=138831
780         http://trac.webkit.org/changeset/176566
781
782 2014-11-29  Anders Carlsson  <andersca@apple.com>
783
784         Crash when calling WKPageClose on the originated page from within createNewPage callback
785         https://bugs.webkit.org/show_bug.cgi?id=139099
786         <rdar://problem/19052564>
787
788         Reviewed by Sam Weinig.
789
790         Add a test.
791
792         * TestWebKitAPI/PlatformWebView.h:
793         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
794         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
795         (TestWebKitAPI::runJavaScriptAlert):
796         (TestWebKitAPI::createNewPage):
797         (TestWebKitAPI::TEST):
798         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
799         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
800         (TestWebKitAPI::PlatformWebView::PlatformWebView):
801
802 2014-11-28  Commit Queue  <commit-queue@webkit.org>
803
804         Unreviewed, rolling out r176564.
805         https://bugs.webkit.org/show_bug.cgi?id=139093
806
807         massive failures on release test bot (Requested by philn on
808         #webkit).
809
810         Reverted changeset:
811
812         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
813         https://bugs.webkit.org/show_bug.cgi?id=138866
814         http://trac.webkit.org/changeset/176564
815
816 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
817
818         [GTK] Use GMainLoopSource in WebKitTestRunner
819         https://bugs.webkit.org/show_bug.cgi?id=138831
820
821         Reviewed by Sergio Villar Senin.
822
823         * WebKitTestRunner/InjectedBundle/TestRunner.h:
824         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
825         (WTR::TestRunner::platformInitialize):
826         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
827         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
828         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
829         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
830         (WTR::TestController::notifyDone):
831         (WTR::TestController::platformRunUntil):
832         (WTR::cancelTimeout): Deleted.
833
834 2014-11-24  Philippe Normand  <pnormand@igalia.com>
835
836         [GStreamer] Bump internal jhbuild versions to 1.4.4
837         https://bugs.webkit.org/show_bug.cgi?id=138866
838
839         Reviewed by Carlos Garcia Campos.
840
841         * gtk/jhbuild.modules:
842         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
843         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
844         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
845
846 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
847
848         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
849         https://bugs.webkit.org/show_bug.cgi?id=138834
850
851         Reviewed by Sergio Villar Senin.
852
853         It makes everyting simpler and the tests run faster too, since we
854         don't need to spawn the private bus and wait until the DBus name
855         is registered. The web extension registers a new JavaSCript class
856         with a status method to run the tests, similar to the DBus
857         method. In the UI process side, tests use webkit_web_view_run_java_script()
858         instead of sending a DBus message.
859
860         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
861         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
862         (WebKitDOMNodeFilterTest::create):
863         (WebKitDOMNodeFilterTest::testTreeWalker):
864         (WebKitDOMNodeFilterTest::testNodeIterator):
865         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
866         (WebKitDOMNodeFilterTest::runTest): Deleted.
867         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
868         (WebKitDOMNodeTest::create):
869         (WebKitDOMNodeTest::testHierarchyNavigation):
870         (WebKitDOMNodeTest::testInsertion):
871         (WebKitDOMNodeTest::testTagNames):
872         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
873         (WebKitDOMNodeTest::runTest): Deleted.
874         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
875         (WebKitDOMXPathNSResolverTest::create):
876         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
877         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
878         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
879         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
880         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
881         (WebKitFrameTest::create):
882         (WebKitFrameTest::testMainFrame):
883         (WebKitFrameTest::testURI):
884         (WebKitFrameTest::testJavaScriptContext):
885         (WebKitFrameTest::webPageFromArgs): Deleted.
886         (WebKitFrameTest::runTest): Deleted.
887         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
888         (testWebKitDOMNodeHierarchyNavigation):
889         (testWebKitDOMNodeInsertion):
890         (testWebKitDOMNodeTagNames):
891         (beforeAll):
892         (afterAll):
893         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
894         (runTest):
895         (beforeAll):
896         (afterAll):
897         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
898         (testWebKitDOMXPathNSResolverNative):
899         (testWebKitDOMXPathNSResolverCustom):
900         (beforeAll):
901         (afterAll):
902         (runTest): Deleted.
903         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
904         (webkitFrameTestRun):
905         (beforeAll):
906         (afterAll):
907         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
908         (testsMap):
909         (WebProcessTest::add):
910         (WebProcessTest::create):
911         (runTest):
912         (windowObjectClearedCallback):
913         (webkit_web_extension_initialize):
914         (methodCallCallback): Deleted.
915         (webkit_web_extension_initialize_with_user_data): Deleted.
916         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
917         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
918         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
919         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
920         (WebViewTest::runWebProcessTest):
921         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
922
923 2014-11-28  Csaba Osztrogonác  <ossy@webkit.org>
924
925         [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
926         https://bugs.webkit.org/show_bug.cgi?id=139086
927
928         Reviewed by Gyuyoung Kim.
929
930         * efl/jhbuild.modules:
931         * efl/patches/libseccomp-pick-up-CC.patch: Added.
932
933 2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
934
935         [EFL] Add warning if CMake version is too old for building with ninja.
936         https://bugs.webkit.org/show_bug.cgi?id=139055
937
938         Reviewed by Gyuyoung Kim.
939
940         CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
941         that version in their repositories.
942
943         * efl/install-dependencies:
944
945 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
946
947         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
948         https://bugs.webkit.org/show_bug.cgi?id=139044
949
950         Reviewed by Chris Fleizach.
951
952         ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
953         The proposed solution will enable the use of this method for the object table.
954         Existing test shows the result.
955
956         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
957         (WTR::AccessibilityUIElement::columnHeaders):
958
959 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
960
961         [EFL] Remove E_Dbus dependency
962         https://bugs.webkit.org/show_bug.cgi?id=136355
963
964         Reviewed by Gyuyoung Kim.
965
966         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
967
968 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
969
970         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
971         https://bugs.webkit.org/show_bug.cgi?id=139047
972
973         Reviewed by Carlos Garcia Campos.
974
975         * efl/jhbuild.modules:
976         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
977         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
978         * gtk/jhbuild-optional.modules:
979         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
980         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
981
982 2014-11-25  Tanay C  <tanay.c@samsung.com>
983
984         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
985         https://bugs.webkit.org/show_bug.cgi?id=138090
986
987         Reviewed by Carlos Garcia Campos.
988
989         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
990         (browserWindowZoomIn): Added.
991         (browserWindowZoomOut): Added.
992         (scrollEventCallback): Added.
993         (zoomInCallback): Modified.
994         (zoomOutCallback): Modified.
995         (browserWindowConstructed): Modified.
996
997 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
998
999         [EFL] REGRESSION(r176514): It made performance tests fail
1000         https://bugs.webkit.org/show_bug.cgi?id=139037
1001
1002         Reviewed by Gyuyoung Kim.
1003
1004         * Scripts/webkitpy/port/efl.py:
1005         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
1006         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
1007         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
1008
1009 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1010
1011         [GTK] update-webkitgtk-libs fails to build fontconfig
1012         https://bugs.webkit.org/show_bug.cgi?id=139032
1013
1014         Reviewed by Martin Robinson.
1015
1016         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
1017         fontconfig will try to generate documentation and fail.
1018
1019         * gtk/install-dependencies:
1020
1021 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1022
1023         Unreviewed. Fix GTK+ make distcheck.
1024
1025         * gtk/manifest.txt: Remove deleted files.
1026
1027 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
1028
1029         [EFL] Utilize Eail library to support accessibility in EFL
1030         https://bugs.webkit.org/show_bug.cgi?id=137742
1031
1032         Reviewed by Gyuyoung Kim.
1033
1034         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
1035
1036         * efl/jhbuild-optional.modules: Added.
1037         * efl/jhbuild.modules:
1038
1039 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1040
1041         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
1042         https://bugs.webkit.org/show_bug.cgi?id=139023
1043
1044         Reviewed by Sergio Villar Senin.
1045
1046         Rename WebKitWebView/default-context as WebKitWebView/web-context
1047         and check we are always using the right context for new web views.
1048
1049         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1050         (testWebViewWebContext):
1051         (beforeAll):
1052         (testWebViewDefaultContext): Deleted.
1053
1054 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1055
1056         [GTK] Add API to override the default local storage directory
1057         https://bugs.webkit.org/show_bug.cgi?id=138828
1058
1059         Reviewed by Gustavo Noronha Silva.
1060
1061         Add test to check that the local storage directory is created at
1062         the path given on construction.
1063
1064         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1065         (testWebContextConfiguration):
1066         (beforeAll):
1067         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1068         (Test::Test):
1069         (Test::~Test): Deleted.
1070
1071 2014-11-21  Zalan Bujtas  <zalan@apple.com>
1072
1073         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
1074         https://bugs.webkit.org/show_bug.cgi?id=138981
1075
1076         Reviewed by Simon Fraser.
1077
1078         * MiniBrowser/mac/SettingsController.h:
1079         * MiniBrowser/mac/SettingsController.m:
1080         (-[SettingsController _populateMenu]):
1081         (-[SettingsController validateMenuItem:]):
1082         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
1083         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
1084         * MiniBrowser/mac/WK1BrowserWindowController.m:
1085         (-[WK1BrowserWindowController didChangeSettings]):
1086         * MiniBrowser/mac/WK2BrowserWindowController.m:
1087         (-[WK2BrowserWindowController didChangeSettings]):
1088
1089 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
1090
1091         Remove http lock code from webkitperl
1092         https://bugs.webkit.org/show_bug.cgi?id=138959
1093
1094         Reviewed by Alexey Proskuryakov.
1095
1096         * Scripts/webkitperl/httpd.pm:
1097         (cleanUp):
1098         (extractLockNumber): Deleted.
1099         (getLockFiles): Deleted.
1100         (getNextAvailableLockNumber): Deleted.
1101         (getLockNumberForCurrentRunning): Deleted.
1102         (waitForHTTPDLock): Deleted.
1103         (scheduleHttpTesting): Deleted.
1104         (getWaitTime): Deleted.
1105
1106 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
1107
1108         [EFL] The option value of fixed layout is false in MiniBrowser
1109         https://bugs.webkit.org/show_bug.cgi?id=138830
1110
1111         Reviewed by Gyuyoung Kim.
1112
1113         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
1114
1115         * MiniBrowser/efl/main.c:
1116
1117 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
1118
1119         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
1120         https://bugs.webkit.org/show_bug.cgi?id=138871
1121
1122         Reviewed by Carlos Garcia Campos.
1123
1124         Add a test case for the convenience API for posting user messages
1125         added to the DOM bindings.
1126
1127         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1128         (testUserContentManagerMessageFromConvenienceDOMBindings):
1129         (beforeAll):
1130         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1131         (documentLoadedCallback):
1132
1133 2014-11-19  Dana Burkart  <dburkart@apple.com>
1134
1135         Work around the fact that different masters may have different names for their codebases.
1136         https://bugs.webkit.org/show_bug.cgi?id=138878
1137
1138         Reviewed by Mark Rowe.
1139
1140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1141         (parseRevisionProperty): Changed.
1142         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
1143         opensource / internal codebase naming convention.
1144
1145 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
1146
1147         AX: Screen braille input doesn't work on forms.
1148         https://bugs.webkit.org/show_bug.cgi?id=138804
1149
1150         Unreviewed build fix.
1151
1152         * DumpRenderTree/AccessibilityUIElement.cpp:
1153         (AccessibilityUIElement::setValue):
1154
1155 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
1156
1157         AX: Screen braille input doesn't work on forms.
1158         https://bugs.webkit.org/show_bug.cgi?id=138804
1159
1160         Reviewed by Mario Sanchez Prada.
1161
1162         Add a method to setValue through the AX API in DRT.
1163
1164         * DumpRenderTree/AccessibilityUIElement.cpp:
1165         (setValueCallback):
1166         (AccessibilityUIElement::getJSClass):
1167         * DumpRenderTree/AccessibilityUIElement.h:
1168         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1169         (AccessibilityUIElement::setValue):
1170         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1171         (AccessibilityUIElement::setValue):
1172
1173 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
1174
1175         Remove the WinCairo buildbot
1176         https://bugs.webkit.org/show_bug.cgi?id=138805
1177
1178         Reviewed by Alex Christensen.
1179
1180         * BuildSlaveSupport/build.webkit.org-config/config.json:
1181         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1182         (appendCustomBuildFlags):
1183         * BuildSlaveSupport/test-result-archive:
1184         (archiveTestResults):
1185
1186 2014-11-18  Daniel Bates  <dabates@apple.com>
1187
1188         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1189         SPI are not available in public SDK
1190         https://bugs.webkit.org/show_bug.cgi?id=138802
1191
1192         Reviewed by David Kilzer.
1193
1194         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
1195
1196         * DumpRenderTree/mac/CheckedMalloc.cpp:
1197
1198 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1199
1200         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
1201
1202         Forgot to fix this test before landing.
1203
1204         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1205         (testWebViewDefaultContext):
1206
1207 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1208
1209         [GTK] Add API to create a WebKitWebContext
1210         https://bugs.webkit.org/show_bug.cgi?id=138826
1211
1212         Reviewed by Gustavo Noronha Silva.
1213
1214         Use a different WebKitWebContext for every test to ensure test
1215         cases are independent to each other. Tests using DBus to
1216         communicate with the injected bundle extension now use a unique
1217         name for the well known DBus name.
1218
1219         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1220         (beforeAll): Remove comment about the order of the tests and
1221         move the success test before the failed one now that tests don't
1222         depend on each others.
1223         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1224         (beforeAll): Remove call to set the web extensions directory,
1225         since this is now done for all test in the Test constructor.
1226         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1227         (beforeAll): Do not create a temporary directory, a temporary data
1228         directory is now created for all tests.
1229         (afterAll):
1230         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1231         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
1232         to the web process test runner.
1233         (testWebKitDOMNodeInsertion): Ditto.
1234         (testWebKitDOMNodeTagNames): Ditto.
1235         (beforeAll): Remove call to set the web extensions directory.
1236         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
1237         (runTest): Pass the web extension ID to the web process test runner.
1238         (beforeAll): Remove call to set the web extensions directory.
1239         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
1240         (runTest): Pass the web extension ID to the web process test runner.
1241         (beforeAll): Remove call to set the web extensions directory.
1242         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1243         (createFileAtDestination): Use Test::dataDirectory() as base dir
1244         for temporary files.
1245         (beforeAll): Do not create a temporary directory.
1246         (afterAll):
1247         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
1248         (webkitFrameTestRun): Pass the web extension ID to the web process
1249         test runner.
1250         (beforeAll): Remove call to set the web extensions directory.
1251         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1252         (beforeAll): Remove call to set the web extensions directory.
1253         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1254         (testProcessPerWebView): Use local member instead of global variable.
1255         (testMultiprocessWebViewCreateReadyClose): Ditto.
1256         (beforeAll): Do not connect to initialize-web-extensions, Test now
1257         connects to the signal for all tests and calls a virtual method
1258         that test can override.
1259         (afterAll):
1260         (initializeWebExtensions): Deleted.
1261         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1262         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
1263         for temporary files.
1264         (beforeAll): Do not create a temporary directory.
1265         (afterAll):
1266         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1267         (beforeAll): Remove call to set the web extensions directory.
1268         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1269         (beforeAll): Remove comment about the tests order.
1270         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1271         (testWebExtensionGetTitle): Build the DBus service name using the
1272         web extension ID.
1273         (testDocumentLoadedSignal): Ditto.
1274         (testWebKitWebViewProcessCrashed): Ditto.
1275         (testWebExtensionIsolatedWorld): Ditto.
1276         (beforeAll): Remove initialization-user-data test, since now all
1277         tests are passing user data to the web extension.
1278         (testWebExtensionInitializationUserData): Deleted.
1279         (initializeWebExtensions): Deleted.
1280         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1281         (testSetDirectory): Use the web context member inherited from Test.
1282         (testClearDatabase): Ditto.
1283         (testGetFaviconURI): Ditto.
1284         (beforeAll): Do not create a temporary directory.
1285         (afterAll):
1286         (webkitFaviconDatabaseFinalizedCallback): Deleted.
1287         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1288         (UserContentManagerTest::UserContentManagerTest):
1289         (beforeAll): Remove call to set the web extensions directory.
1290         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1291         (testWebContextDefault): Check also that a newly create web
1292         context is not the default web context.
1293         (testWebContextSpellChecker): Use the web context member inherited
1294         from Test.
1295         (testWebContextLanguages): Ditto.
1296         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1297         (methodCallCallback): Remove GetInitializationUserData method.
1298         (webkit_web_extension_initialize_with_user_data): Always create
1299         the DBus name using the user data provided.
1300         (makeBusName): Deleted.
1301         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1302         (webkit_web_extension_initialize_with_user_data): Create the DBus
1303         name using the user data provided.
1304         (webkit_web_extension_initialize): Deleted.
1305         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
1306         (Test::dataDirectory): Return the temporary data directory.
1307         (removeNonEmptyDirectory): Also remove directories recursively.
1308         (main): Remove the disk cache directory initialization, since this
1309         is now done in the Test constructor.
1310         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1311         (Test::initializeWebExtensionsCallback): Call the virtual method
1312         initializeWebExtensions()
1313         (Test::Test): Create a new WebKitWebContext and initialize it.
1314         (Test::~Test): Disconnect initialize-web-extensions signal.
1315         (Test::initializeWebExtensions): Set the web extensions directory
1316         and user data.
1317         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
1318         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
1319         (WebProcessTestRunner::runTest): Build the DBus proxy using a
1320         unique name created with the Test web extension ID.
1321         (WebProcessTestRunner::proxy): Deleted.
1322         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
1323         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1324         (WebViewTest::WebViewTest): Create the web view with the Test web
1325         context.
1326         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
1327         content manager parameter to the constructor.
1328
1329 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
1330
1331         [GTK] Mesa build fails over llvm-3.5
1332         https://bugs.webkit.org/show_bug.cgi?id=138825
1333
1334         Reviewed by Gustavo Noronha Silva.
1335
1336         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
1337
1338         * gtk/jhbuild.modules:
1339         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
1340
1341 2014-11-17  Daniel Bates  <dabates@apple.com>
1342
1343         Unreviewed, rolling out r176232.
1344
1345         Broke the Mac build. Will investigate offline.
1346
1347         Reverted changeset:
1348
1349         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
1350         MobileGestalt"
1351         https://bugs.webkit.org/show_bug.cgi?id=138802
1352         http://trac.webkit.org/changeset/176232
1353
1354 2014-11-17  Daniel Bates  <dabates@apple.com>
1355
1356         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1357         SPI are not available in public SDK
1358         https://bugs.webkit.org/show_bug.cgi?id=138802
1359
1360         Reviewed by David Kilzer.
1361
1362         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
1363
1364         * DumpRenderTree/mac/CheckedMalloc.cpp:
1365
1366 2014-11-17  Jake Nielsen  <jacob_nielsen@apple.com>
1367
1368         Having 30+ flaky failures breaks EWS
1369         https://bugs.webkit.org/show_bug.cgi?id=138743
1370
1371         Reviewed by Alexey Proskuryakov.
1372
1373         Adds tests to ensure that the problem has been solved.
1374         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1375         (test_first_failure_limit):
1376         (test_first_failure_limit_with_some_tree_redness):
1377         (test_second_failure_limit):
1378         (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
1379         (test_first_and_second_failure_limit):
1380         (test_first_and_clean_failure_limit):
1381         (test_first_second_and_clean_failure_limit):
1382         (test_very_red_tree_retry): Deleted.
1383         Really this was renamed to test_first_second_and_clean_failure_limit.
1384         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1385         Makes the appropriate changes to PatchAnalysisTask to make sure that
1386         even when the first test run hits the failure limit, it will still try
1387         a second run.
1388         (PatchAnalysisTask._results_failed_different_tests):
1389         (PatchAnalysisTask._test_patch):
1390         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
1391
1392 2014-11-17  Ting-Wei Lan  <lantw44@gmail.com>
1393
1394         [GTK] Add library search paths from LDFLAGS before pkg-config --libs
1395         https://bugs.webkit.org/show_bug.cgi?id=136018
1396
1397         Reviewed by Carlos Garcia Campos.
1398
1399         It is possible that the order of -L arguments in the output of
1400         pkg-config is wrong, which causes the linker to find the wrong
1401         version (usually older version) of libraries when running
1402         gtkdoc-scangobj.
1403
1404         * gtk/gtkdoc.py:
1405         (GTKDoc._run_gtkdoc_scangobj):
1406
1407 2014-11-17  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1408
1409         Bump EFL version to 1.12.0
1410         https://bugs.webkit.org/show_bug.cgi?id=138733
1411
1412         Reviewed by Gyuyoung Kim.
1413
1414         * efl/jhbuild.modules:
1415
1416 2014-11-16  Joanmarie Diggs  <jdiggs@igalia.com>
1417
1418         AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
1419         https://bugs.webkit.org/show_bug.cgi?id=138771
1420
1421         Reviewed by Chris Fleizach.
1422
1423         Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
1424
1425         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1426
1427 2014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
1428
1429         AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
1430         https://bugs.webkit.org/show_bug.cgi?id=138767
1431
1432         Reviewed by Chris Fleizach.
1433
1434         Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
1435
1436         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1437
1438 2014-11-14  Alexey Proskuryakov  <ap@apple.com>
1439
1440         Add shortcut macros to Mac TestExpectations
1441         https://bugs.webkit.org/show_bug.cgi?id=138729
1442
1443         Reviewed by Simon Fraser.
1444
1445         * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
1446         Add version macros for current OS versions.
1447
1448 2014-11-13  Alexey Proskuryakov  <ap@apple.com>
1449
1450         https://bugs.webkit.org/show_bug.cgi?id=138628
1451         A patch that doesn't apply is stuck in commit queue
1452
1453         Rubber-stamped by David Kilzer.
1454
1455         This also hopefully fixes other issues:
1456         - a patch that has cq+ flag set by a non-committer kills commit queue;
1457         - EWS never reports failing tests, and keeps spinning instead.
1458
1459         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1460         (Bugzilla.set_flag_on_attachment):
1461         (Bugzilla.obsolete_attachment):
1462         Apply the fix from r174797 to more places.
1463
1464 2014-11-13  Dan Bernstein  <mitz@apple.com>
1465
1466         Policy client not called for navigations through the page cache
1467         https://bugs.webkit.org/show_bug.cgi?id=138703
1468
1469         Reviewed by Alexey Proskuryakov.
1470
1471         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1472         (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
1473         (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1474
1475 2014-11-13  Joanmarie Diggs  <jdiggs@igalia.com>
1476
1477         AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
1478         https://bugs.webkit.org/show_bug.cgi?id=137867
1479
1480         Reviewed by Chris Fleizach.
1481
1482         Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
1483         AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
1484         able to test for the presence of ATK_ROLE_INVALID.
1485
1486         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1487         (WTR::AccessibilityUIElement::role):
1488
1489 2014-11-13  Juergen Ributzka  <juergen@apple.com>
1490
1491         Update the "combineModules" script to handel more LLVM metadata.
1492         https://bugs.webkit.org/show_bug.cgi?id=138514
1493
1494         Reviewed by Filip Pizlo.
1495
1496         * ReducedFTL/combineModules.rb:
1497
1498 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
1499
1500         Allow constructing a base PassRef with a derived Ref
1501         https://bugs.webkit.org/show_bug.cgi?id=138701
1502
1503         Reviewed by Andreas Kling
1504
1505         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1506         (TestWebKitAPI::passWithPassRef):
1507         (TestWebKitAPI::passWithPassRefPtr):
1508         (TestWebKitAPI::TEST):
1509
1510 2014-11-05  Ada Chan  <adachan@apple.com>
1511
1512         Implement new plug-in API for muting plug-ins
1513         https://bugs.webkit.org/show_bug.cgi?id=138105
1514
1515         Reviewed by Anders Carlsson.
1516
1517         Add a new plug-in test for the mute API.
1518
1519         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1520         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
1521         (SetMuted::SetMuted):
1522         (SetMuted::isMuted):
1523         (SetMuted::cachedIsMuted):
1524         (SetMuted::ScriptableObject::hasProperty):
1525         (SetMuted::ScriptableObject::getProperty):
1526         (SetMuted::ScriptableObject::pluginTest):
1527         (SetMuted::NPP_New):
1528         (SetMuted::NPP_GetValue):
1529         (SetMuted::NPP_SetValue):
1530
1531 2014-11-12  Philippe Normand  <pnormand@igalia.com>
1532
1533         Unreviewed, GTK gardening.
1534
1535         * Scripts/run-gtk-tests:
1536         (TestRunner): Skip the UserMediaBasic test because it depends on
1537         constraints validation which is going to be fixed in bug #136449.
1538
1539 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1540
1541         [GTK] Expose user script messages to GObject DOM bindings
1542         https://bugs.webkit.org/show_bug.cgi?id=138411
1543
1544         Reviewed by Philippe Normand.
1545
1546         Add a test case to check that user script messages sent using the
1547         DOM bindings API are also received in the UI process.
1548
1549         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1550         (UserScriptMessageTest::waitUntilMessageReceived):
1551         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
1552         (testUserContentManagerScriptMessageFromDOMBindings):
1553         (beforeAll):
1554         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1555         (documentLoadedCallback):
1556
1557 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1558
1559         Unreviewed. Fix GTK+ clean build after r175930.
1560
1561         Partial rollout of r175930 to not build the new unit test that
1562         broke clean builds in GTK+ port.
1563
1564         * TestWebKitAPI/PlatformGTK.cmake:
1565
1566 2014-09-01  Philippe Normand  <pnormand@igalia.com>
1567
1568         [WK2] UserMediaClient support
1569         https://bugs.webkit.org/show_bug.cgi?id=123158
1570
1571         Reviewed by Benjamin Poulain.
1572
1573         Simple API test for the UserMedia permission request API. The
1574         required test infrastructure is also added, inspired by the
1575         Geolocation infrastructure.
1576
1577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
1578         Permission request.
1579         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
1580         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
1581         (TestWebKitAPI::TEST):
1582         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
1583         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
1584         helper method to set the permission request result without user interaction.
1585         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
1586         (WTR::InjectedBundle::setUserMediaPermission):
1587         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
1588         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
1589         (WTR::TestRunner::setUserMediaPermission):
1590         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
1591         * WebKitTestRunner/TestController.cpp:
1592         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
1593         request handler.
1594         (WTR::TestController::createOtherPage): Enable the new UserMedia
1595         permission request handler.
1596         (WTR::TestController::createWebViewWithOptions): Ditto.
1597         (WTR::TestController::resetPreferencesToConsistentValues): Enable
1598         MediaStream support, this is needed for getUserMedia.
1599         (WTR::TestController::resetStateToConsistentValues): clear
1600         UserMedia permissions list and flags.
1601         (WTR::TestController::setUserMediaPermission): Set permission
1602         request result and distpatch it.
1603         (WTR::TestController::handleUserMediaPermissionRequest): Save
1604         request and dispatch it.
1605         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1606         Dispatch cached permission requests.
1607         * WebKitTestRunner/TestController.h:
1608         * WebKitTestRunner/TestInvocation.cpp:
1609         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1610
1611 2014-11-11  David Kilzer  <ddkilzer@apple.com>
1612
1613         webkit-patch --suggest-reviewers is broken with newer versions of git
1614         <http://webkit.org/b/138627>
1615
1616         Reviewed by Michael Saboff with feedback from Daniel Bates.
1617
1618         * Scripts/webkitpy/common/checkout/scm/git.py:
1619         (Git._changes_files_for_commit): Strip blank lines instead of
1620         assuming there is always a blank line at the beginning of the
1621         list.
1622
1623 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
1624
1625         DRT and WKTR touch disk cache
1626         https://bugs.webkit.org/show_bug.cgi?id=138622
1627
1628         Reviewed by Geoffrey Garen.
1629
1630         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
1631         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
1632         because this function uses the shared cache.
1633
1634         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
1635         Create an empty shared cache to prevent a default one from being created on disk.
1636
1637 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
1638
1639         [CSS Grid Layout] Limit the size of explicit/implicit grid
1640         https://bugs.webkit.org/show_bug.cgi?id=136217
1641
1642         Reviewed by Andreas Kling.
1643
1644         Added a new unit test for the CSS parser. Right now it only checks
1645         that we properly clamp the maximum number of tracks on a grid to a
1646         maximum of 1 million.
1647
1648         * TestWebKitAPI/CMakeLists.txt:
1649         * TestWebKitAPI/PlatformEfl.cmake:
1650         * TestWebKitAPI/PlatformGTK.cmake:
1651         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1652         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
1653         (TestWebKitAPI::computeNumberOfTracks): Helper function.
1654         (TestWebKitAPI::TEST): Added a
1655         CSSPropertyParserTest.GridTrackLimits test case.
1656
1657 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1658
1659         webkitpy test fix after r175867
1660         https://bugs.webkit.org/show_bug.cgi?id=138607
1661
1662         Reviewed by Philippe Normand.
1663
1664         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1665         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1666
1667 2014-11-10  Philippe Normand  <pnormand@igalia.com>
1668
1669         webkitpy: demangle C++ symbols from crash log stderr
1670         https://bugs.webkit.org/show_bug.cgi?id=138565
1671
1672         Reviewed by Alexey Proskuryakov.
1673
1674         * Scripts/webkitpy/port/linux_get_crash_log.py:
1675         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
1676         with c++filt.
1677
1678 2014-11-10  Philippe Normand  <pnormand@igalia.com>
1679
1680         [GTK] fix up the GDB backtrace report tool
1681         https://bugs.webkit.org/show_bug.cgi?id=138564
1682
1683         Reviewed by Carlos Garcia Campos.
1684
1685         * Scripts/webkitpy/port/gtk.py:
1686         (GtkPort._get_crash_log): Match the process name reported by the
1687         driver with the GTK port WebProcess executable filename.
1688         * Scripts/webkitpy/port/linux_get_crash_log.py:
1689         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
1690         program.
1691         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
1692         pattern to workaround the 16 characters size limit of %e.
1693
1694 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
1695
1696         Unreviewed, moved myself to the list of committers.
1697
1698         * Scripts/webkitpy/common/config/contributors.json:
1699
1700 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1701
1702         [EFL] Fix the test font path after r175555.
1703
1704         Reviewed by Csaba Osztrogonác.
1705
1706         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
1707
1708 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
1709
1710         Fix the exception fuzz helper to generate targets in the correct range
1711         https://bugs.webkit.org/show_bug.cgi?id=138544
1712
1713         Reviewed by Filip Pizlo.
1714
1715         Currently, the script generates exception fuzz targets in the range of
1716         0..($checkCount-1). However, target 0 is never hit, while target 1 is
1717         always outside of the outermost try block of the tests, which therefore
1718         prints unexpected output and results in false failures when fired at.
1719         Additionally, target $checkCount is never generated.
1720
1721         This patch fixes the script to generate targets in the range of
1722         2..$checkCount.
1723
1724         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1725
1726 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
1727
1728         make-passwords-json.py should generarate everything needed for testing
1729         https://bugs.webkit.org/show_bug.cgi?id=138503
1730
1731         Reviewed by Ryosuke Niwa.
1732
1733         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
1734         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
1735         Additionally generate auth.json, credentials.cfg and committers.cfg too.
1736         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
1737         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1738         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
1739         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
1740
1741 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1742
1743         [GTK] generate-gtkdoc should ignore invalid files
1744         https://bugs.webkit.org/show_bug.cgi?id=138542
1745
1746         Reviewed by Darin Adler.
1747
1748         * gtk/generate-gtkdoc:
1749         (files_to_ignore.file_should_be_ignored): Return True to ignore
1750         invalid files.
1751
1752 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
1753
1754         Delete cookies between tests
1755         https://bugs.webkit.org/show_bug.cgi?id=138528
1756
1757         Reviewed by Sam Weinig.
1758
1759         * DumpRenderTree/mac/DumpRenderTree.mm:
1760         (resetWebPreferencesToConsistentValues):
1761         * WebKitTestRunner/TestController.cpp:
1762         (WTR::TestController::resetPreferencesToConsistentValues):
1763         Do it.
1764
1765         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1766         (WTR::InjectedBundle::beginTesting):
1767         Added a FIXME.
1768
1769 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1770
1771         [GTK] Run layout tests using the network process
1772         https://bugs.webkit.org/show_bug.cgi?id=138428
1773
1774         Reviewed by Martin Robinson.
1775
1776         Shared secondary process is the default in the GTK+ port, but we
1777         should run the tests using the network process to ensure
1778         everything works with the network process. In the future, the
1779         shared secondary process model might be a special case of multiple
1780         processes with 1 as maximum number of processes, but always using
1781         the network process.
1782
1783         * WebKitTestRunner/TestController.cpp:
1784         (WTR::TestController::initialize):
1785
1786 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1787
1788         [GTK] Allow to create a view with a related page in WTR
1789         https://bugs.webkit.org/show_bug.cgi?id=138501
1790
1791         Reviewed by Martin Robinson.
1792
1793         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1794         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
1795         related page to WKViewCreate.
1796         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1797         (WTR::PlatformWebView::PlatformWebView): Pass the given related
1798         page to WKViewCreate.
1799
1800 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1801
1802         WTR crashes after running a test when NetworkProcess enabled
1803         https://bugs.webkit.org/show_bug.cgi?id=138500
1804
1805         Reviewed by Alexey Proskuryakov.
1806
1807         WebNotificationProvider destructor is calling
1808         WKNotificationManagerSetProvider, but m_notificationManager is
1809         null because removeNotificationManager was already called.
1810
1811         * WebKitTestRunner/WebNotificationProvider.cpp:
1812         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
1813         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
1814
1815 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
1816
1817         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
1818         regarding incorrect call to PatchAnalysisTask.report_failure
1819         https://bugs.webkit.org/show_bug.cgi?id=138229
1820
1821         Reviewed by Daniel Bates.
1822
1823         * Scripts/webkitpy/common/net/layouttestresults.py:
1824         Makes sure test_results returns a list.
1825         (LayoutTestResults.test_results):
1826         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1827         Makes unit tests also check to make sure
1828         task.results_from_patch_test_run() and
1829         task.results_from_test_run_without_patch return instances of
1830         LayoutTestResults.
1831         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1832         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1833         Condenses duplicate code into _should_defer_patch_or_throw, and
1834         removes the now-unused _clean_tree_results member.
1835         (PatchAnalysisTask.__init__):
1836         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
1837         (PatchAnalysisTask._should_defer_patch_or_throw):
1838         (PatchAnalysisTask._test_patch):
1839         (PatchAnalysisTask.results_from_patch_test_run):
1840         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
1841         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1842         Removes needless call to results_from_test_run_without_patch
1843         (AbstractEarlyWarningSystem._failing_tests_message):
1844         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1845         Changes order of test failure messages to be in the order that they
1846         appear.
1847         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1848         * Scripts/webkitpy/tool/commands/queues.py:
1849         Removes needless call to results_from_test_run_without_patch.
1850         (CommitQueue._failing_tests_message):
1851         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1852         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
1853
1854 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
1855
1856         Unreviewed. Reorder my e-mail addresses in contributors.json
1857
1858         * Scripts/webkitpy/common/config/contributors.json:
1859
1860 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
1861
1862         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
1863         https://bugs.webkit.org/show_bug.cgi?id=138475
1864
1865         Reviewed by Ryosuke Niwa.
1866
1867         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
1868         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
1869         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
1870         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
1871
1872         * Scripts/webkitpy/common/checkout/scm/git.py:
1873         (Git._run_git_svn_find_rev):
1874         Add comment mentioning that svn_revisions need to begin with 'r'.
1875         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
1876         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
1877         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
1878
1879 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1880
1881         [GTK] Add context menu API to Web Process Extensions
1882         https://bugs.webkit.org/show_bug.cgi?id=138311
1883
1884         Reviewed by Gustavo Noronha Silva.
1885
1886         Add tests cases for WebKitWebPage::context-menu signal.
1887
1888         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1889         (testContextMenuWebExtensionMenu):
1890         (testContextMenuWebExtensionNode):
1891         (beforeAll):
1892         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1893         (serializeContextMenu):
1894         (serializeNode):
1895         (contextMenuCallback):
1896         (pageCreatedCallback):
1897
1898 2014-11-06  Commit Queue  <commit-queue@webkit.org>
1899
1900         Unreviewed, rolling out r175690.
1901         https://bugs.webkit.org/show_bug.cgi?id=138460
1902
1903         We are not ready to run layout tests using the network process
1904         yet (Requested by KaL on #webkit).
1905
1906         Reverted changeset:
1907
1908         "[GTK] Run layout tests using the network process"
1909         https://bugs.webkit.org/show_bug.cgi?id=138428
1910         http://trac.webkit.org/changeset/175690
1911
1912 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1913
1914         [GTK] Run layout tests using the network process
1915         https://bugs.webkit.org/show_bug.cgi?id=138428
1916
1917         Reviewed by Martin Robinson.
1918
1919         Shared secondary process is the default in the GTK+ port, but we
1920         should run the tests using the network process to ensure
1921         everything works with the network process. In the future, the
1922         shared secondary process model might be a special case of multiple
1923         processes with 1 as maximum number of processes, but always using
1924         the network process.
1925
1926         * WebKitTestRunner/TestController.cpp:
1927         (WTR::TestController::initialize):
1928
1929 2014-11-05  Dan Bernstein  <mitz@apple.com>
1930
1931         Remove the unused deletion UI feature
1932         https://bugs.webkit.org/show_bug.cgi?id=138442
1933
1934         Rubber-stamped by Alexey Proskuryakov.
1935
1936         * DumpRenderTree/mac/EditingDelegate.mm:
1937         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
1938         delegate method that’s been removed.
1939
1940 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1941
1942         fast/dom/remove-body-during-body-replacement2.html fails on WK2
1943         https://bugs.webkit.org/show_bug.cgi?id=138334
1944
1945         Reviewed by Anders Carlsson.
1946
1947         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
1948         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
1949         -makeFirstResponder calls, which may or may not be needed for other reasons, but
1950         it also needs to reset internal focus explicitly.
1951
1952         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
1953         WebKit behavior appears wrong, but it matches Firefox.
1954
1955         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1956         (WTR::InjectedBundlePage::resetAfterTest):
1957
1958 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1959
1960         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
1961         https://bugs.webkit.org/show_bug.cgi?id=137862
1962
1963         Reviewed by Gustavo Noronha Silva.
1964
1965         Add a test case to check that WebKitWebResource::failed-with-tls-errors
1966         is emitted when a subresource load fails due to TLS errors.
1967
1968         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1969         (TLSSubresourceTest::resourceLoadStartedCallback):
1970         (TLSSubresourceTest::TLSSubresourceTest):
1971         (TLSSubresourceTest::subresourceFailedCallback):
1972         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
1973         (TLSSubresourceTest::subresourceLoadStarted):
1974         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
1975         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
1976         (testSubresourceLoadFailedWithTLSErrors):
1977         (httpsServerCallback):
1978         (httpServerCallback):
1979         (beforeAll):
1980
1981 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1982
1983         Build fix for some compiler versions.
1984
1985         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
1986         unhappy because this is a getter, and these shouldn't have side effects.
1987
1988 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1989
1990         Add a method for performing cherrypick-merges.
1991         https://bugs.webkit.org/show_bug.cgi?id=138375
1992
1993         Reviewed by Ryosuke Niwa.
1994
1995         Adds support for cherrypick-merges.
1996
1997         * Scripts/webkitpy/common/checkout/scm/git.py:
1998         (Git.cherrypick_merge): Added.
1999
2000 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
2001
2002         Add a way to ascertain the SVN URL associated with a Git branch.
2003         https://bugs.webkit.org/show_bug.cgi?id=138374
2004
2005         Reviewed by Ryosuke Niwa.
2006
2007         The svn_url method returns the SVN URL associated with the current Git branch.
2008
2009         * Scripts/webkitpy/common/checkout/scm/git.py:
2010         (Git.svn_url): Added.
2011
2012 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
2013
2014         Add the ability to search for modifications that are staged for commit.
2015         https://bugs.webkit.org/show_bug.cgi?id=138373
2016
2017         Reviewed by Ryosuke Niwa and Daniel Bates.
2018
2019         This makes is easy to do identify files that require merge post-processing,
2020         in addition to stand-alone utility.
2021
2022         * Scripts/webkitpy/common/checkout/scm/git.py:
2023         (Git.modifications_staged_for_commit): Added.
2024
2025 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
2026
2027         Add a branch keyword argument to _run_git_svn_find_rev.
2028         https://bugs.webkit.org/show_bug.cgi?id=138372
2029
2030         Reviewed by Ryosuke Niwa.
2031
2032         The addition of this keyword argument allows clients to determine the Git hash
2033         of commits made on an SVN branch, provided that branch has been fetched locally.
2034
2035         * Scripts/webkitpy/common/checkout/scm/git.py:
2036         (Git._run_git_svn_find_rev):
2037         Add a branch keyword argument that is added to the end of the command, if present.
2038
2039 2014-11-04  Chris Dumez  <cdumez@apple.com>
2040
2041         Add ptr() method to Ref class
2042         https://bugs.webkit.org/show_bug.cgi?id=138361
2043
2044         Reviewed by Darin Adler.
2045
2046         Use the new Ref::ptr() method.
2047
2048         * TestWebKitAPI/Tests/WTF/Ref.cpp:
2049         (TestWebKitAPI::TEST):
2050
2051 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2052
2053         [jhbuild] Make it possible to build GTK/EFL in same repository
2054         https://bugs.webkit.org/show_bug.cgi?id=137448
2055
2056         Reviewed by Martin Robinson.
2057
2058         * Scripts/webkitdirs.pm:
2059         (getJhbuildPath):
2060         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
2061         (getPlatformFontsPath):
2062         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2063         (WTR::getFontsPath):
2064         * jhbuild/jhbuild-wrapper:
2065         (determine_platform):
2066         (install_jhbuild):
2067         * jhbuild/jhbuildrc_common.py:
2068         (init):
2069
2070 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2071
2072         [EFL] Bump LLVM to version 3.5.0
2073         https://bugs.webkit.org/show_bug.cgi?id=138312
2074
2075         Reviewed by Csaba Osztrogonác.
2076
2077         * efl/jhbuild.modules:
2078         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
2079         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
2080
2081 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
2082
2083         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
2084         https://bugs.webkit.org/show_bug.cgi?id=138257
2085
2086         Reviewed by Tim Horton.
2087         
2088         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
2089         the user to toggle region page overlays on and off. Two overlays are available,
2090         for the non-fast scrollable region, and the region of element with wheel
2091         event handlers.
2092
2093         * MiniBrowser/mac/SettingsController.h:
2094         * MiniBrowser/mac/SettingsController.m:
2095         (-[SettingsController _populateMenu]):
2096         (-[SettingsController validateMenuItem:]):
2097         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
2098         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
2099         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
2100         (-[SettingsController toggleDebugOverlay:]):
2101         (-[SettingsController debugOverlayVisible:]):
2102         * MiniBrowser/mac/WK2BrowserWindowController.m:
2103         (-[WK2BrowserWindowController didChangeSettings]):
2104
2105 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
2106
2107         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
2108         https://bugs.webkit.org/show_bug.cgi?id=138323
2109
2110         Reviewed by Zalan Bujtas.
2111
2112         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
2113
2114 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2115
2116         [ninja] Don't remove response files for verbose builds
2117         https://bugs.webkit.org/show_bug.cgi?id=137816
2118
2119         Reviewed by Csaba Osztrogonác.
2120
2121         * Scripts/webkitdirs.pm:
2122         (determineNinjaVersion):
2123         (buildCMakeGeneratedProject):
2124
2125 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
2126
2127         [GTK] Fix the build of FTL JIT
2128         https://bugs.webkit.org/show_bug.cgi?id=138298
2129
2130         Reviewed by Carlos Garcia Campos.
2131
2132         * gtk/jhbuild-optional.modules:
2133         Bump up LLVM version to 3.5.0 release and apply patches.
2134         * gtk/patches/llvm-elf-add-stackmaps.patch:
2135         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
2136         trunk.
2137         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
2138         Added. Ensures that PC-relative relocations in EH frames are not
2139         truncated to 32 bits on x86_64.
2140
2141 2014-10-31  Michael Saboff  <msaboff@apple.com>
2142
2143         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
2144         https://bugs.webkit.org/show_bug.cgi?id=138268
2145
2146         Reviewed by Andreas Kling.
2147
2148         Added a --arch and --os option to set or override the values that are
2149         normally computed based on examining the JavaScriptCore we want to test.
2150
2151         * Scripts/run-jsc-stress-tests:
2152
2153 2014-10-31  Dan Bernstein  <mitz@apple.com>
2154
2155         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
2156         https://bugs.webkit.org/show_bug.cgi?id=138259
2157
2158         Reviewed by Geoff Garen.
2159
2160         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
2161         going to be empty to silence the warning.
2162
2163 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
2164
2165         [GTK] Support script message handlers WebKitUserContentManager
2166         https://bugs.webkit.org/show_bug.cgi?id=133730
2167
2168         Reviewed by Carlos Garcia Campos.
2169
2170         Support user script message handlers in WebKitUserContentManager.
2171         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
2172         an option is added to the CMake build files. The option is disabled
2173         globally by default, and the WebKitGTK port enables it. On the API
2174         level, two new methods to register and unregister names are provided
2175         in the "window.webkit" namespace, and on message reception the
2176         "WebKitUserContentManager::script-message-received" signal is
2177         emitted, using the registered names as signal detail.
2178
2179         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2180         Add test case for user script message handlers.
2181         (scriptMessageReceived):
2182         (testUserContentManagerScriptMessageReceived):
2183         (beforeAll):
2184
2185 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
2186
2187         bisect-builds should support WebKit clients other than Safari
2188         https://bugs.webkit.org/show_bug.cgi?id=138225
2189
2190         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
2191
2192         The -a / --application optional argument allows the user to specify which application (or application bundle)
2193         should be run against the WebKit nightly builds.
2194
2195         Reviewed by David Kilzer.
2196
2197         * Scripts/bisect-builds:
2198         Swap out $safariPath for the more general $applicationPath
2199         Leave --safari-path as a commandline option for backwards compatibility
2200         (mountAndRunNightly):
2201         Use File::Spec->cat correctly (one directory per argument)
2202         Use open --wait-apps instead of running the target application directly
2203
2204 2014-10-30  Dana Burkart  <dburkart@apple.com>
2205
2206         <rdar://problem/18821260> Perpare for the mysterious future
2207
2208         Reviewed by Lucas Forschler.
2209
2210         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2211         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2212         * LayoutTestRelay/Configurations/Base.xcconfig:
2213         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2214         * MiniBrowser/Configurations/Base.xcconfig:
2215         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2216         * TestWebKitAPI/Configurations/Base.xcconfig:
2217         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2218         * WebKitLauncher/Configurations/Base.xcconfig:
2219         * WebKitTestRunner/Configurations/Base.xcconfig:
2220         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2221
2222 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
2223
2224         Update safariVersion to safariVersionString
2225         https://bugs.webkit.org/show_bug.cgi?id=138193
2226
2227         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
2228         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
2229
2230         Rubber-stamped by David Kilzer.
2231
2232         * Scripts/bisect-builds:
2233         (makeNightlyList):
2234         Compare safariVersionString to a string literal, instead of safariVersion.
2235
2236 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
2237
2238         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
2239         https://bugs.webkit.org/show_bug.cgi?id=137775
2240
2241         Reviewed by Carlos Garcia Campos.
2242
2243         * MiniBrowser/gtk/BrowserWindow.c:
2244         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
2245         (browser_window_init):
2246
2247 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
2248
2249         CommitQueue and EWS should reject any patches that result in consistent test
2250         failures that aren't present on the tree.
2251         https://bugs.webkit.org/show_bug.cgi?id=138184
2252
2253         Reviewed by Alexey Proskuryakov.
2254
2255         * Scripts/webkitpy/layout_tests/models/test_results.py:
2256         Adds a simple hashing function to allow for set operations to handle
2257         TestResult objects properly.
2258         (TestResult.__hash__):
2259         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2260         Adds one unit test, and modifies others to agree with the notion that
2261         patches that introduce new test failures (but also have flakyness)
2262         should be rejected rather than spin.
2263         (MockCommitQueue.report_flaky_tests):
2264         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2265         (test_double_flaky_test_failure):
2266         (test_two_flaky_tests):
2267         (test_very_flaky_patch):
2268         (test_very_flaky_patch_with_some_tree_redness):
2269         (test_different_test_failures):
2270         (test_different_test_failures_with_some_tree_redness):
2271         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
2272         (test_mildly_flaky_patch):
2273         (test_mildly_flaky_patch_with_some_tree_redness):
2274         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2275         Makes PatchAnalysisTask reject said patches.
2276         (PatchAnalysisTask._test_patch):
2277
2278 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2279
2280         WinCairoRequirements.zip cannot be downloaded from dropbox
2281         https://bugs.webkit.org/show_bug.cgi?id=138113
2282
2283         Reviewed by Alexey Proskuryakov.
2284
2285         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
2286
2287 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
2288
2289         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
2290         https://bugs.webkit.org/show_bug.cgi?id=138193
2291
2292         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
2293         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
2294
2295         It also does a bit of refactoring, including distinguishing between versions and version strings and
2296         saving versions to local variables instead of using eval in each conditional.
2297
2298         Reviewed by David Kilzer.
2299
2300         * Scripts/bisect-builds:
2301         (makeNightlyList):
2302         Restrict the set of nightlies to r174650 and above when running Yosemite.
2303         Restrict the set of nightlies to r157846 and above when running Mavericks.
2304         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
2305
2306 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
2307
2308         [EFL] build-webkit should try harder to avoid re-running cmake
2309         https://bugs.webkit.org/show_bug.cgi?id=137949
2310
2311         Reviewed by Martin Robinson.
2312
2313         * Scripts/webkitdirs.pm:
2314         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
2315         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
2316
2317 2014-10-28  Daniel Bates  <dabates@apple.com>
2318
2319         Unify logic in RunTests.run() to run the Python unit tests
2320         https://bugs.webkit.org/show_bug.cgi?id=138160
2321
2322         Reviewed by Martin Robinson.
2323
2324         Unify the interactive and non-interactive code path for running the Python unit tests
2325         in step RunTests so as to remove duplicate code to compute the the path to the script
2326         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
2327
2328         No new tests since no functionality was changed.
2329
2330         * Scripts/webkitpy/port/base.py:
2331         (Port.python_unittest_results_directory):
2332         * Scripts/webkitpy/tool/steps/runtests.py:
2333         (RunTests.run):
2334
2335 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
2336
2337         Make runtest.py call test-webkitpy with the --json flag when in
2338         non-interactive mode.
2339         https://bugs.webkit.org/show_bug.cgi?id=137667
2340
2341         Reviewed by Daniel Bates.
2342
2343         * Scripts/webkitpy/port/base.py:
2344         Adds the python_unittest_results_directory method.
2345         (Port.python_unittest_results_directory):
2346         * Scripts/webkitpy/tool/steps/runtests.py:
2347         Changes RunTests to call test-webkitpy with the --json flag if the
2348         --non-interactive flag is set.
2349         (RunTests):
2350         (RunTests.run):
2351
2352 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
2353
2354         import-w3c-tests should use re.escape() wherever it's handling file paths
2355         https://bugs.webkit.org/show_bug.cgi?id=137934
2356
2357         This patch adds re.escape() to a few places where we're doing string
2358         conversions. This prevents errors when attribute values coincidentally
2359         have character sequences that can be interpreted as regular expressions.
2360
2361         Reviewed by Bem Jones-Bey.
2362
2363         * Scripts/webkitpy/w3c/test_converter.py:
2364         (_W3CTestConverter.convert_attributes_if_needed):
2365
2366 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2367
2368         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
2369         https://bugs.webkit.org/show_bug.cgi?id=138130
2370
2371         Reviewed by Csaba Osztrogonác.
2372
2373         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2374
2375 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
2376
2377         Fix link to Arch Linux Wiki
2378         https://bugs.webkit.org/show_bug.cgi?id=138010
2379
2380         Reviewed by Benjamin Poulain.
2381
2382         * gtk/install-dependencies:
2383
2384 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
2385
2386         Test regressions are not detected when image result is missing
2387         https://bugs.webkit.org/show_bug.cgi?id=138070
2388
2389         Reviewed by Simon Fraser.
2390
2391         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2392         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2393         Count these as regressions, not as flaky tests.
2394
2395         * Scripts/webkitpy/port/test.py:
2396         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2397         Test it.
2398
2399 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
2400
2401         Add Conrad Shultz to the contributors list.
2402
2403         * Scripts/webkitpy/common/config/contributors.json:
2404
2405 2014-10-24  Dan Bernstein  <mitz@apple.com>
2406
2407         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
2408         https://bugs.webkit.org/show_bug.cgi?id=138046
2409
2410         Reviewed by Alexey Proskuryakov.
2411
2412         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2413         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
2414         401. Otherwise, we’ll retry normally in 45 seconds.
2415
2416 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
2417
2418         [GTK] Implement is_selected method on WebKitHitTestResult
2419         https://bugs.webkit.org/show_bug.cgi?id=137110
2420
2421         Reviewed by Tim Horton.
2422
2423         Add tests for new context SELECTION on WebKitHitTestResult.
2424
2425         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2426         (testContextMenuDefaultMenu):
2427         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2428         (testWebViewMouseTarget):
2429
2430 2014-10-23  Roger Fong  <roger_fong@apple.com>
2431
2432         [Win] Skip failing JSC tests following r175078
2433         https://bugs.webkit.org/show_bug.cgi?id=130967.
2434
2435         * Scripts/run-javascriptcore-tests:
2436
2437 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2438
2439         commitqueuetask_unittest.py should be made more concise.
2440         https://bugs.webkit.org/show_bug.cgi?id=137985
2441
2442         Reviewed by Alexey Proskuryakov.
2443
2444         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2445         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
2446         (MockCommitQueue.__init__):
2447         (MockCommitQueue.report_flaky_tests):
2448         (MockCommitQueue):
2449         (MockCommitQueue.get_reported_flaky_tests):
2450         (MockSimpleTestPlanCommitQueue.__init__):
2451         (MockSimpleTestPlanCommitQueue.run_command):
2452         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
2453         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2454         (test_land_failure):
2455         (test_failed_archive):
2456         (test_double_flaky_test_failure):
2457         (test_test_failure):
2458         (test_red_test_failure):
2459         (test_very_red_tree_retry):
2460         (test_red_tree_patch_rejection):
2461         (test_one_flaky_test):
2462         (test_tree_more_red_than_patch):
2463         (MockCommitQueue.test_results): Deleted.
2464         (test_simple_flaky_test_failure): Deleted.
2465         (_expect_validate): Deleted.
2466         (_expect_validate.MockDelegate): Deleted.
2467         (_expect_validate.MockDelegate.refetch_patch): Deleted.
2468         (_expect_validate.MockDelegate.expected_failures): Deleted.
2469         (_mock_patch): Deleted.
2470         (test_validate): Deleted.
2471         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2472         Fixes a bug that slipped through the cracks prior to this change.
2473         (PatchAnalysisTask._test_patch):
2474
2475 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
2476
2477         Flakiness dashboard should support OS X Yosemite
2478         https://bugs.webkit.org/show_bug.cgi?id=137986
2479
2480         Reviewed by Ryosuke Niwa.
2481
2482         * TestResultServer/app.yaml:
2483         * TestResultServer/static-dashboards/builders.jsonp:
2484         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2485
2486 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2487
2488         commitqueuetask should include more tests to ensure that the behavior
2489         of PatchAnalysisTask._test_patch() is well defined
2490         https://bugs.webkit.org/show_bug.cgi?id=137977
2491
2492         Reviewed by Alexey Proskuryakov.
2493
2494         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2495         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
2496         and more readable to define tests that are meant to test the behaviour
2497         of PatchAnalysisTask._test_patch(), and adds several unit tests.
2498         (FailingTestCommitQueue.test_results):
2499         (PatchAnalysisResult):
2500         (MockSimpleTestPlanCommitQueue):
2501         (MockSimpleTestPlanCommitQueue.__init__):
2502         (MockSimpleTestPlanCommitQueue.run_command):
2503         (MockSimpleTestPlanCommitQueue._mock_test_result):
2504         (MockSimpleTestPlanCommitQueue.test_results):
2505         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2506         (test_flaky_test_failure):
2507         (test_failed_archive):
2508         (test_two_flaky_tests):
2509         (test_one_flaky_test):
2510         (test_very_flaky_patch):
2511         (test_very_flaky_patch_with_some_tree_redness):
2512         (test_different_test_failures):
2513         (test_different_test_failures_with_some_tree_redness):
2514         (test_mildly_flaky_patch):
2515         (test_mildly_flaky_patch_with_some_tree_redness):
2516         (test_tree_more_red_than_patch):
2517
2518 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2519
2520         PatchAnalysisTask._test_patch() needs refactoring
2521         https://bugs.webkit.org/show_bug.cgi?id=137904
2522
2523         Reviewed by Alexey Proskuryakov.
2524
2525         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2526         Fixes several small bugs, and makes minor changes to accomodate the
2527         changes in PatchAnalysisTask.
2528         (MockCommitQueue.refetch_patch):
2529         (MockCommitQueue.test_results):
2530         (test_flaky_test_failure):
2531         (test_failed_archive):
2532         (test_very_red_tree_retry):
2533         (_expect_validate.MockDelegate.refetch_patch):
2534         (MockCommitQueue.expected_failures): Deleted.
2535         (_expect_validate.MockDelegate.expected_failures): Deleted.
2536         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
2537         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
2538         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2539         Removes the unexpected_failures member, adds the _clean_tree_results
2540         member, adds a helper function for _test_patch, and refactors
2541         _test_patch to be more readable.
2542         (PatchAnalysisTask.__init__):
2543         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
2544         (PatchAnalysisTask._test_patch):
2545         (PatchAnalysisTask.results_from_test_run_without_patch):
2546         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2547         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
2548         (AbstractEarlyWarningSystem.begin_work_queue):
2549         (AbstractEarlyWarningSystem._failing_tests_message):
2550         (AbstractEarlyWarningSystem.command_failed):
2551         (AbstractEarlyWarningSystem.expected_failures): Deleted.
2552         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2553         Makes changes to accomodate the changes made to PatchAnalysisTask.
2554         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2555         * Scripts/webkitpy/tool/commands/perfalizer.py:
2556         Removes Perfalizer's dependancy on ExpectedFailures. 
2557         (PerfalizerTask.refetch_patch):
2558         (PerfalizerTask.expected_failures): Deleted.
2559         * Scripts/webkitpy/tool/commands/queues.py:
2560         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
2561         initializer to allow for mock injection.
2562         (CommitQueue.__init__):
2563         (CommitQueue.begin_work_queue):
2564         (CommitQueue.process_work_item):
2565         (CommitQueue._failing_tests_message):
2566         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2567         Removes dependancy on ExpectedFailures, and instead uses mock
2568         injection.
2569         (MockCommitQueueTask):
2570         (MockCommitQueueTask.results_from_patch_test_run):
2571         (MockCommitQueueTask.results_from_test_run_without_patch):
2572         (mock_run_webkit_patch):
2573
2574 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
2575
2576         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
2577         https://bugs.webkit.org/show_bug.cgi?id=136736
2578
2579         Reviewed by Gyuyoung Kim.
2580
2581         * MiniBrowser/efl/main.c:
2582         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
2583         (window_create):
2584
2585 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2586
2587         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
2588         https://bugs.webkit.org/show_bug.cgi?id=137884
2589
2590         Reviewed by Gustavo Noronha Silva.
2591
2592         Move InputMethodFilter test from WebCore tests to WebKit2 tests
2593         and adapt it to use the new InputMethodFilter WebKit class. Instead
2594         of having virtual methods just for testing, it has a testing mode
2595         that logs the events.
2596
2597         * TestWebKitAPI/PlatformGTK.cmake:
2598         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
2599         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
2600         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
2601         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
2602         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
2603         (TestWebKitAPI::TEST):
2604         (TestWebKitAPI::temporaryGetPreeditStringOverride):
2605         (TestWebKitAPI::temporaryResetOverride):
2606         (TestWebKitAPI::verifyCanceledComposition):
2607
2608 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
2609
2610         build.webkit.org/dashboard: Cannot click on green tester bubbles
2611         https://bugs.webkit.org/show_bug.cgi?id=137909
2612
2613         Reviewed by Darin Adler.
2614
2615         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2616         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2617
2618 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
2619
2620         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
2621         https://bugs.webkit.org/show_bug.cgi?id=137932
2622
2623         Reviewed by Simon Fraser.
2624
2625         This is the first step in moving over to native Windows rendering for our layout tests.
2626         Once this change lands, approximately 300 tests will start failing on Windows. I will
2627         rebaseline these changes against our test hardware and update this bug with the
2628         commits related to that work.
2629
2630         * DumpRenderTree/win/DumpRenderTree.cpp:
2631         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
2632         we use native Windows drawing style.
2633
2634 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2635
2636         Fix FTL Native Inlining for EFL
2637         https://bugs.webkit.org/show_bug.cgi?id=137774
2638
2639         Reviewed by Michael Saboff.
2640
2641         Added Clang as an optional module to jhbuild.
2642
2643         * efl/jhbuild.modules:
2644
2645 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2646
2647         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
2648         https://bugs.webkit.org/show_bug.cgi?id=137832
2649
2650         Reviewed by Carlos Garcia Campos.
2651
2652         Ensure each test sets the TLS errors policy that it really needs.
2653         Have each test except testTLSErrorsPolicy stash and restore the original
2654         TLS errors policy. Update testTLSErrorsPolicy to account for the new
2655         default policy.
2656
2657         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2658         (testSSL):
2659         (testInsecureContent):
2660         (testTLSErrorsPolicy):
2661         (testTLSErrorsRedirect):
2662         (testTLSErrorsHTTPAuth):
2663         (testLoadFailedWithTLSErrors):
2664         (beforeAll):
2665
2666 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2667
2668         Unreviewed. Unskip inspector server unit tests.
2669
2670         They should pass now.
2671
2672         * Scripts/run-gtk-tests:
2673         (TestRunner):
2674
2675 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2676
2677         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
2678         https://bugs.webkit.org/show_bug.cgi?id=132044
2679
2680         Reviewed by Brian Burg.
2681
2682         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2683         (openRemoteDebuggingSession): Remove trailing slash when
2684         concatenating base inspector URL with the page, because the
2685         inspector returns the relative paths with a leading slash.
2686
2687 2014-10-20  Tanay C  <tanay.c@samsung.com>
2688
2689         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
2690         https://bugs.webkit.org/show_bug.cgi?id=137023
2691
2692         Reviewed by Gyuyoung Kim.
2693
2694         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
2695         (search_box_show): Modified.
2696         (search_box_hide): Modified.
2697         (on_search_field_activated): Modified.
2698         (on_search_backward_button_clicked): Modified.
2699         (on_search_forward_button_clicked): Modified.
2700         (on_search_case_option_changed): Added.
2701         (on_search_word_start_option_changed): Added.
2702         (window_create): Modified.
2703
2704 2014-10-20  Tanay C  <tanay.c@samsung.com>
2705
2706         [GTK][Minibrowser] Escape key does not hide the search box
2707         https://bugs.webkit.org/show_bug.cgi?id=137734
2708
2709         Reviewed by Philippe Normand.
2710
2711         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
2712         (stopPageLoad): Modified.
2713
2714 2014-10-18  Antti Koivisto  <antti@apple.com>
2715
2716         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
2717         https://bugs.webkit.org/show_bug.cgi?id=137855
2718
2719         Reviewed by Dan Bernstein.
2720
2721         Test and warn if the dumped response mime type differs from the platform response mime type.
2722
2723         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2724         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2725         (WTR::InjectedBundlePage::platformResponseMimeType):
2726         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2727         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2728         (WTR::InjectedBundlePage::platformResponseMimeType):
2729
2730 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
2731
2732         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
2733         https://bugs.webkit.org/show_bug.cgi?id=137835
2734
2735         Reviewed by Andreas Kling.
2736
2737         * Scripts/run-inspector-perf-tests.py: Removed.
2738         This script is stale, as PerformanceTests/inspector no longer exists.
2739
2740 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
2741
2742         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
2743
2744         * Scripts/webkitpy/port/ios.py:
2745         (IOSSimulatorPort.default_baseline_search_path):
2746
2747 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
2748
2749         [iOS] Simplify test fallback paths for iOS Simulator testing
2750         https://bugs.webkit.org/show_bug.cgi?id=137830
2751
2752         Reviewed by Zalan Bujtas.
2753         
2754         Make the fallback paths be:
2755             ios-simulator -> generic
2756             ios-simulator-wk2->ios-simulator -> generic
2757         
2758         so don't include mac in the fallback path. Also remove the
2759         version handling for simplicity.
2760
2761         * Scripts/webkitpy/port/ios.py:
2762         (IOSSimulatorPort):
2763         (IOSSimulatorPort.default_baseline_search_path):
2764
2765 2014-10-17  Dana Burkart  <dburkart@apple.com>
2766
2767         Fix typos in the dashboard config file.
2768
2769         Unreviewed.
2770
2771         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2772         (WebKitBuildbot):
2773
2774 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
2775
2776         [Win] Allow WinLauncher to specify Custom User Agent strings
2777         https://bugs.webkit.org/show_bug.cgi?id=137828
2778
2779         Reviewed by Dean Jackson.
2780
2781         * WinLauncher/Common.cpp: Add support for custom user agent strings.
2782         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
2783         and set the user agent strings.
2784         * WinLauncher/WinLauncher.h:
2785         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
2786         resources and dialog for setting custom User Agent strings.
2787         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
2788
2789 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
2790
2791         [iOS] Turn off font autosizing for iOS WebKitTestRunner
2792         https://bugs.webkit.org/show_bug.cgi?id=137806
2793
2794         Reviewed by Sam Weinig.
2795
2796         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
2797         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
2798         to disable font autosizing.
2799         
2800         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
2801         test controller to set platform-specific prefs.
2802
2803         * WebKitTestRunner/TestController.cpp:
2804         (WTR::TestController::resetPreferencesToConsistentValues):
2805         (WTR::TestController::platformResetPreferencesToConsistentValues):
2806         * WebKitTestRunner/TestController.h:
2807         * WebKitTestRunner/ios/TestControllerIOS.mm:
2808         (WTR::TestController::platformResetPreferencesToConsistentValues):
2809         * WebKitTestRunner/mac/TestControllerMac.mm:
2810         (WTR::TestController::platformResetPreferencesToConsistentValues):
2811
2812 2014-10-16  Dan Bernstein  <mitz@apple.com>
2813
2814         OSObjectPtr is missing leakRef()
2815         https://bugs.webkit.org/show_bug.cgi?id=137798
2816
2817         Reviewed by Sam Weinig.
2818
2819         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
2820         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
2821
2822 2014-10-16  Lucas Forschler  <lforschler@apple.com>
2823
2824         Update target platform to remove Leopard, Snow Leopard, Lion.
2825         Add Yosemite. 
2826         
2827         Unreviewed.
2828
2829         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2830         (_should_file_trigger_build):
2831
2832 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2833
2834         commit-queue: fails to replace OO-PS! with reviewer name
2835         <http://webkit.org/b/137795>
2836
2837         Reviewed by Alexey Proskuryakov.
2838
2839         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2840         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
2841         email addresses to unauthenticated page loads, so we must always
2842         authenticate before getting bug data so we get full email
2843         addresses.
2844
2845 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2846
2847         commit-queue: fails to close bugs after successfully landing patches
2848         <http://webkit.org/b/137794>
2849
2850         Reviewed by Alexey Proskuryakov.
2851
2852         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2853         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
2854         tell Mechanize to use the second <textarea> on the page with
2855         name="comment".
2856
2857 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
2858
2859         [Win] Update DRT to match Mac Logic
2860         https://bugs.webkit.org/show_bug.cgi?id=137787
2861
2862         Reviewed by Dean Jackson.
2863
2864         * DumpRenderTree/win/DumpRenderTree.cpp:
2865         (initialize): 0 -> nullptr
2866         (runTest): Initialize MSG structure before using.
2867         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
2868         Also, cleanly shut down COM when exiting.
2869         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2870         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
2871         header and add printf to match Mac.
2872         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
2873         * DumpRenderTree/win/FrameLoadDelegate.h:
2874         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
2875         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
2876         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2877         (isLocalhost): Added.
2878         (hostIsUsedBySomeTestsToGenerateError): Added.
2879         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
2880         of certain error and redirect host names.
2881         * DumpRenderTree/win/UIDelegate.cpp:
2882         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
2883         anything should be output to the console. This modifies behavior to match the Mac.
2884         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2885         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2886         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2887         (UIDelegate::webViewAddMessageToConsole): Ditto.
2888         * WinLauncher/PageLoadTestClient.cpp:
2889         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
2890         added last week.
2891
2892 2014-10-16  Commit Queue  <commit-queue@webkit.org>
2893
2894         Unreviewed, rolling out r174754.
2895         https://bugs.webkit.org/show_bug.cgi?id=137789
2896
2897         Speculative fix for Windows test was ineffective. (Requested
2898         by rfong on #webkit).
2899
2900         Reverted changeset:
2901
2902         "[Windows] Add some more logging to debug Windows test
2903         issues."
2904         http://trac.webkit.org/changeset/174754
2905
2906 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2907
2908         Unreviewed, add myself to CoordinatedGraphics watchers.
2909
2910         * Scripts/webkitpy/common/config/watchlist:
2911
2912 2014-10-15  Roger Fong  <roger_fong@apple.com>
2913
2914         [Windows] Speculative Windows test fix.
2915
2916         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
2917
2918 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
2919
2920         import-w3c-test rewrites relative src paths in ref files incorrectly
2921         https://bugs.webkit.org/show_bug.cgi?id=137586
2922
2923         This patch fixes a bug in test_converter.py where src paths were getting 
2924         rewritten as ../../some-path instead of <script src="../../some-path>". 
2925         It also adds support for rewriting src paths in style  elements, which was 
2926         missing before and it adds tests for this case.
2927
2928         Reviewed by Bem Jones-Bey.
2929
2930         * Scripts/webkitpy/w3c/test_converter.py:
2931         (_W3CTestConverter.convert_attributes_if_needed):
2932         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2933         (test_convert_attributes_if_needed):
2934         (verify_reference_relative_paths):
2935
2936 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
2937
2938         Add --json flag to test-webkitpy to emit JSON formatted test results
2939         to stdout
2940         https://bugs.webkit.org/show_bug.cgi?id=137353
2941
2942         Reviewed by Daniel Bates.
2943
2944         * Scripts/webkitpy/port/server_process_unittest.py:
2945         Adds the read method to MockFile to allow the stdout of test_webkitpy
2946         to be redirected without causing erroneous test failures.
2947         In particular,
2948         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
2949         and
2950         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
2951         because when redirecting to a file, the
2952         _wait_for_data_and_update_buffers_using_select method in 
2953         server_process.py will find that there is a read file descriptor in
2954         its call to select.select, which eventually leads to it calling read()
2955         on the MockFile object.
2956         (MockFile.read):
2957         * Scripts/webkitpy/test/main.py:
2958         Adds the _print_results_as_json method and the --json flag which
2959         determines whether _print_results_as_json will get called.
2960         (Tester._parse_args):
2961         (Tester._print_results_as_json):
2962         (Tester._print_results_as_json.result_dict_from_tuple):
2963         (Tester._run_tests):
2964
2965 2014-10-13  David Farler  <dfarler@apple.com>
2966
2967         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
2968         https://bugs.webkit.org/show_bug.cgi?id=137662
2969
2970         Reviewed by Darin Adler.
2971
2972         The layout test harness can close LayoutTestRelay's subprocess
2973         stdout and stderr in the case of a timeout or if a run is
2974         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
2975         finds that no one is listening to its stdout/stderr (broken
2976         pipe), then just exit(1), there is nothing to report.
2977
2978         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2979         (-[LTRelayController didReceiveStdoutData:]):
2980         Add @try/@catch for NSFileHandleOperationException.
2981         (-[LTRelayController didReceiveStderrData:]):
2982         Add @try/@catch for NSFileHandleOperationException.
2983
2984 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
2985
2986         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
2987         https://bugs.webkit.org/show_bug.cgi?id=137060
2988
2989         Reviewed by Philippe Normand.
2990
2991         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
2992
2993         * MiniBrowser/gtk/BrowserWindow.c:
2994         (zoomInCallback):
2995         (zoomOutCallback):
2996         (defaultZoomCallback): Callback for default zoom keyboard support.
2997         (browser_window_init):
2998
2999 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
3000
3001         [Mac] DRT stderr logging after the test completes gets attributed to the next test
3002
3003         Reviewed by Alexey Proskuryakov.
3004         
3005         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
3006         logging to stderr to get associated with the next test.
3007         
3008         Fix by logging #EOF to stderr later, after we've completely finished with this test.
3009
3010         * DumpRenderTree/mac/DumpRenderTree.mm:
3011         (dumpTestResults):
3012         (runTest):
3013
3014 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
3015
3016         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
3017
3018         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
3019
3020 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
3021
3022         [cmake] Fix the make build after r174683
3023         https://bugs.webkit.org/show_bug.cgi?id=137703
3024
3025         Reviewed by Martin Robinson.
3026
3027         * Scripts/webkitdirs.pm:
3028         (buildCMakeGeneratedProject):
3029
3030 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
3031
3032         Adding myself to the watchlist to CachedFont
3033
3034         Unreviewed.
3035
3036         * Scripts/webkitpy/common/config/watchlist:
3037
3038 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3039
3040         [EFL][GTK] Make it possible to get verbose output with ninja
3041         https://bugs.webkit.org/show_bug.cgi?id=137606
3042
3043         Reviewed by Csaba Osztrogonác.
3044
3045         * Scripts/webkitdirs.pm:
3046         (buildCMakeGeneratedProject):
3047
3048 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3049
3050         [EFL] Make it possible to use ninja for EFL build too
3051         https://bugs.webkit.org/show_bug.cgi?id=137605
3052
3053         Reviewed by Csaba Osztrogonác.
3054
3055         * Scripts/webkitdirs.pm:
3056         (generateBuildSystemFromCMakeProject):
3057         * efl/install-dependencies:
3058
3059 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
3060
3061         [GTK] Minibrowser : Add home buton and keyboard support for home page load
3062         https://bugs.webkit.org/show_bug.cgi?id=137486
3063
3064         Reviewed by Philippe Normand.
3065
3066         * MiniBrowser/gtk/BrowserWindow.c:
3067         (loadHomePage): Callback for home page load.
3068         (browser_window_init):
3069         * MiniBrowser/gtk/BrowserWindow.h:
3070         * MiniBrowser/gtk/main.c:
3071         (main):
3072
3073 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
3074
3075         import-w3c-tests doesn't prefix property values
3076         https://bugs.webkit.org/show_bug.cgi?id=137600
3077
3078         Reviewed by Bem Jones-Bey.
3079
3080         Some property values are prefixed in WebKit. Modified the W3C import
3081         script in order to prefix property values and not only properties.
3082         The patch re-uses most of the already existent logic to prefix
3083         properties.
3084
3085         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
3086         from CSSValueKeywords.in and adapt converter to modify both properties
3087         and property values.
3088         (convert_for_webkit):
3089         (_W3CTestConverter.__init__):
3090         (_W3CTestConverter.output):
3091         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
3092         (_W3CTestConverter):
3093         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
3094         (_W3CTestConverter.add_webkit_prefix_following_regex):
3095         (_W3CTestConverter.convert_reference_relpaths):
3096         (_W3CTestConverter.convert_style_data):
3097         (_W3CTestConverter.convert_attributes_if_needed):
3098         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
3099         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
3100         include checks for property values too.
3101         (W3CTestConverterTest.test_read_prefixed_property_list):
3102         (verify_no_conversion_happened):
3103         (verify_prefixed_properties):
3104         (verify_prefixed_property_values):
3105         (generate_test_content_properties_and_values):
3106         (generate_test_content):
3107         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
3108         prefixed property values and inform about them.
3109         (TestImporter.import_tests):
3110         (TestImporter.write_import_log):
3111
3112 2014-10-13  Jer Noble  <jer.noble@apple.com>
3113
3114         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
3115         https://bugs.webkit.org/show_bug.cgi?id=137533
3116
3117         Reviewed by Andy Estes.
3118
3119         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
3120
3121         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3122         (TestWebKitAPI::isMSEEnabledCallback):
3123         (TestWebKitAPI::TEST):
3124
3125 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
3126
3127         [Win] Implement a page load profiling tool
3128         https://bugs.webkit.org/show_bug.cgi?id=137673
3129
3130         Reviewed by Dean Jackson.
3131
3132         Add a tool to capture and summarize page load statistics.
3133
3134         * WinLauncher/Common.cpp:
3135         (parseCommandLine): Move from WinMain.cpp so that it can
3136         be shared with internal tools.
3137         * WinLauncher/PageLoadTestClient.cpp: Added.
3138         (PageLoadTestClient::PageLoadTestClient):
3139         (PageLoadTestClient::pageLoadStartedAtTime):
3140         (PageLoadTestClient::didStartProvisionalLoad):
3141         (PageLoadTestClient::didCommitLoad):
3142         (PageLoadTestClient::didFirstLayoutForMainFrame):
3143         (PageLoadTestClient::didHandleOnLoadEvents):
3144         (PageLoadTestClient::didFinishLoad):
3145         (PageLoadTestClient::didFailLoad):
3146         (PageLoadTestClient::didInitiateResourceLoad):
3147         (PageLoadTestClient::didEndResourceLoad):
3148         (PageLoadTestClient::pageLoadEndedAtTime):
3149         (PageLoadTestClient::endPageLoad):
3150         (PageLoadTestClient::clearPageLoadState):
3151         (PageLoadTestClient::shouldConsiderPageLoadEnded):
3152         (PageLoadTestClient::maybeEndPageLoadSoon):
3153         (PageLoadTestClient::setPageURL):
3154         (PageLoadTestClient::dumpRunStatistics):
3155         * WinLauncher/PrintWebUIDelegate.cpp:
3156         (PrintWebUIDelegate::createWebViewWithRequest): Handle
3157         nullptr URL properly.
3158         * WinLauncher/ResourceLoadDelegate.cpp: Added.
3159         (ResourceLoadDelegate::QueryInterface):
3160         (ResourceLoadDelegate::AddRef):
3161         (ResourceLoadDelegate::Release):
3162         (ResourceLoadDelegate::identifierForInitialRequest):
3163         (ResourceLoadDelegate::willSendRequest):
3164         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3165         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
3166         (ResourceLoadDelegate::didReceiveResponse):
3167         (ResourceLoadDelegate::didReceiveContentLength):
3168         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3169         (ResourceLoadDelegate::didFailLoadingWithError):
3170         (ResourceLoadDelegate::plugInFailedWithError):
3171         * WinLauncher/ResourceLoadDelegate.h: Added.
3172         (ResourceLoadDelegate::ResourceLoadDelegate):
3173         * WinLauncher/WinLauncher.cpp:
3174         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
3175         page loading statistics.
3176         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
3177         and set private load delegate state.
3178         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
3179         that sets the view's resource load delegate.
3180         (WinLauncher::loadURL): If no URL is passed, load the test document.
3181         * WinLauncher/WinLauncher.h:
3182         (WinLauncher::pageLoadTestClient):
3183         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
3184         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
3185         * WinLauncher/WinLauncherWebHost.cpp:
3186         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
3187         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
3188         it could be used from other source files.
3189         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
3190         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
3191         (WinLauncherWebHost::didFailLoadWithError): Ditto.
3192         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
3193         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
3194         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
3195         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
3196         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
3197         * WinLauncher/WinLauncherWebHost.h:
3198         * WinLauncher/WinMain.cpp:
3199         (wWinMain): Create and use new delegates for gathering page load data.
3200         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
3201
3202 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
3203
3204         Improve the test image diffs page
3205         https://bugs.webkit.org/show_bug.cgi?id=137674
3206
3207         Reviewed by Alexey Proskuryakov.
3208         
3209         Don't treat the input file as a format string, otherwise we have to escape special
3210         characters. Just do a couple of replaces.
3211
3212         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3213         (TestResultWriter.write_image_diff_files):
3214
3215 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3216
3217         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
3218         https://bugs.webkit.org/show_bug.cgi?id=137659
3219
3220         Reviewed by Martin Robinson.
3221
3222         * Scripts/webkitpy/port/xvfbdriver.py:
3223         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
3224
3225 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
3226
3227         Add more detailed wait time information to EWS metrics
3228         https://bugs.webkit.org/show_bug.cgi?id=137649
3229
3230         Reviewed by Daniel Bates.
3231
3232         Added average and worst time (we used to only have median), and also a percentage
3233         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
3234
3235         There is always some wait due to the polling nature of the queues, which is well understood
3236         and doesn't need to be measured. What needs to be measured is whether there is enough
3237         bot machines to process patches as soon as they are submitted.
3238
3239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3240         (Analyzer.prototype._analyzeBubblePerformance):
3241         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
3242         (MetricsBubbleView.prototype._update):
3243
3244 2014-10-11  Jer Noble  <jer.noble@apple.com>
3245
3246         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
3247         https://bugs.webkit.org/show_bug.cgi?id=137533
3248
3249         Reviewed by Darin Adler.
3250
3251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3252         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3253         (TestWebKitAPI::TEST):
3254         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
3255         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
3256
3257 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
3258
3259         iOS DRT snapshots are limited to the page visible area
3260         https://bugs.webkit.org/show_bug.cgi?id=137650
3261
3262         Reviewed by Daniel Bates.
3263         
3264         LegacyTileCache drawing was limited to the window's visible area, found by
3265         crawling up the layer hierarchy to the root layer. This caused test snapshots to
3266         be missing non-composited content outside the iPhone visible area, which hinders
3267         testing.
3268         
3269         Fix by adding a test-only mode where the window visible area is the entire window.
3270         
3271         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3272         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
3273         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3274         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
3275         for the DRT window.
3276         
3277
3278 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
3279
3280         Page not fully rendered in iOS DRT snapshots
3281         https://bugs.webkit.org/show_bug.cgi?id=137638
3282
3283         Reviewed by Tim Horton.
3284         
3285         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
3286         to ensure that the page has laid out and is rendered by the time we take
3287         the snapshot.
3288
3289         * DumpRenderTree/mac/DumpRenderTree.mm:
3290         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
3291         (-[DumpRenderTree _webThreadInvoked]): Moved.
3292         (-[DumpRenderTree _waitForWebThreadThenDump]):
3293         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
3294         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
3295         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
3296         relies on dispatch_async too, and the inner block won't complete until the outer block
3297         has completed.
3298         (dumpTestResults): Move the guts of dump() here.
3299         (runTest): Whitespace.
3300
3301 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
3302
3303         Adding svn:ignore so that .pyc files don't show up as new.
3304
3305         * Scripts/webkitpy/xcode: Added property svn:ignore.
3306
3307 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
3308
3309         [EFL] Introduce EWebKit_Extension
3310         https://bugs.webkit.org/show_bug.cgi?id=134921
3311
3312         Reviewed by Gyuyoung Kim.
3313
3314         * MiniBrowser/efl/main.c: Added x option to test extension path.
3315         (window_create):
3316         (elm_main):
3317         * Scripts/webkitpy/common/config/watchlist:
3318         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
3319         * Scripts/webkitpy/style/checker.py:
3320         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
3321
3322 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
3323
3324         After r174628 we send the test process a SIGTERM before the SIGKILL.
3325
3326         * Scripts/webkitpy/common/system/executive_unittest.py:
3327         (ExecutiveTest.serial_test_kill_process):
3328
3329 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
3330
3331         [EFL] Enable WebP support.
3332         https://bugs.webkit.org/show_bug.cgi?id=136156
3333
3334         Reviewed by Gyuyoung Kim.
3335
3336         Include libwebp-dev package to support WebP for WK2 Efl.
3337
3338         * efl/install-dependencies:
3339
3340 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3341
3342         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
3343         https://bugs.webkit.org/show_bug.cgi?id=137485
3344
3345         Reviewed by Sergio Villar Senin.
3346
3347         Update GMainLoopSource tests. Most of the tests are now run twice,
3348         first with a GMainLoopSource and then with a
3349         GThreadSafeMainLoopSource, since both should have the same
3350         behaviour. The threading test uses GThreadSafeMainLoopSource and
3351         the delete on destroy test uses GMainLoopSource. The tests
3352         themselves haven't changed, since there's no change in behaviour.
3353
3354         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
3355         (TestWebKitAPI::GMainLoopSourceTest::source):
3356         (TestWebKitAPI::basicRescheduling):
3357         (TestWebKitAPI::TEST):
3358         (TestWebKitAPI::reentrantRescheduling):
3359         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
3360         (TestWebKitAPI::basicDestroyCallbacks):
3361         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
3362         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
3363
3364 2014-10-10  Dana Burkart  <dburkart@apple.com>
3365
3366         Fix fat-fingered function name in git-add-reviewer.
3367
3368         Unreviewed.
3369
3370         * Scripts/git-add-reviewer:
3371         (getConfigValue):
3372
3373 2014-10-10  David Farler  <dfarler@apple.com>
3374
3375         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
3376         https://bugs.webkit.org/show_bug.cgi?id=137528
3377
3378         Reviewed by Simon Fraser.
3379
3380         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
3381         and SIGKILL the paired simulator app before exiting cleanly.
3382
3383         webkitpy only uses SIGKILL to kill processes which you cannot
3384         catch. Send SIGTERM to the process and give it chance to do
3385         its thing before sending SIGKILL. Sending a SIGKILL to an already
3386         dead PID is safe.
3387
3388         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3389         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3390         (-[LTRelayController finish]):
3391         * LayoutTestRelay/LayoutTestRelay/main.m:
3392         (receivedSignal):
3393         (main):
3394
3395 2014-10-10  David Farler  <dfarler@apple.com>
3396
3397         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
3398         https://bugs.webkit.org/show_bug.cgi?id=137527
3399
3400         Reviewed by Simon Fraser.
3401
3402         NSFileHandle doesn't notify of EOF in its readability handler.
3403         Use a dispatch_source_t and an event handler that is called when reading is possible.
3404         In the handler block, do a run-of-the-mill read(2) from standard input and
3405         detect EOF in the usual way by checking that zero bytes were read.
3406
3407         Once an EOF is received, the FIFOs are disconnected, the simulator app
3408         is killed, and the relay exits with status 0.
3409
3410         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3411         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
3412         (-[LTRelayController didDisconnect]):
3413         (-[LTRelayController didConnect]):
3414         (-[LTRelayController launchApp]):
3415         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
3416         confusion with this new dispatch source, called "standardInputDispatchSource".
3417         (-[LTRelayController finish]): Added.
3418         (-[LTRelayController readFileHandle:]): Deleted.
3419
3420 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
3421
3422         [EFL] Crash on facebook.com
3423         https://bugs.webkit.org/show_bug.cgi?id=137562
3424
3425         Reviewed by Chris Dumez.
3426
3427         Crash occurs on the facebook.com when the webview is resized
3428         after the <select> item is clicked but no item is chosen.
3429         This crash is just caused by the reference of invalidated variable.
3430         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
3431         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
3432         on MiniBrowser is called.
3433         As a result, just set ewk_menu to NULL in order to prevent crash condition.
3434
3435         * MiniBrowser/efl/main.c:
3436         (on_popup_menu_hide):
3437
3438 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
3439
3440         A small wording change for clarity.
3441
3442         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
3443         (MetricsBubbleView.prototype._update):
3444
3445 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
3446
3447         Dashboard metrics page should have EWS statistics
3448         https://bugs.webkit.org/show_bug.cgi?id=137626
3449
3450         Reviewed by Ryosuke Niwa.
3451
3452         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
3453         (BubbleQueue): Put shortName in the object, so that it's actually useful.
3454
3455         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3456         (BubbleQueueServer): Re-ordered queues to match bubble order.
3457         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
3458         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
3459
3460         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3461         Added analysis for bubble queues.
3462
3463         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
3464
3465         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3466         (buildBubbleQueuesTable): Build the UI.
3467
3468         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
3469         Added JS sources to load.
3470
3471         * QueueStatusServer/app.yaml: To update app version.
3472
3473         * QueueStatusServer/handlers/processingtimesjson.py: Added.
3474
3475         * QueueStatusServer/main.py: Added a handler for processing-times-json.
3476
3477 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
3478
3479         REGRESSION: Commit queue doesn't process rollouts
3480         https://bugs.webkit.org/show_bug.cgi?id=137623
3481
3482         Reviewed by Tim Horton.
3483
3484         * QueueStatusServer/app.yaml:
3485         * QueueStatusServer/handlers/updateworkitems.py:
3486         (UpdateWorkItems._work_items_from_request):
3487
3488 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
3489
3490         Fix syntax error after r174601.
3491
3492         * Scripts/run-javascriptcore-tests:
3493
3494 2014-10-10  Michael Saboff  <msaboff@apple.com>
3495
3496         Add ability to select tarfile name in run-jsc-stress-tests
3497         https://bugs.webkit.org/show_bug.cgi?id=137614
3498
3499         Reviewed by Mark Hahnenberg.
3500
3501         Added optional file name argument to the --tarball option.  
3502
3503         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
3504         extra test given after the options wont be used for the optional tarball file name.
3505         * Scripts/run-jsc-stress-tests:
3506
3507 2014-10-10  Chris Dumez  <cdumez@apple.com>
3508
3509         Unreviewed, update my information in contributors.json
3510
3511         Use my preferred first name and update my expertise areas.
3512
3513         * Scripts/webkitpy/common/config/contributors.json:
3514
3515 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
3516
3517         Fix perl scripts to run with env on Linux
3518         https://bugs.webkit.org/show_bug.cgi?id=137601
3519
3520         Reviewed by Csaba Osztrogonác.
3521
3522         Use of arguments in #! is nonstandard and does not behave the same on
3523         different systems. Linux would look for an executable named "perl -w" 
3524         "use warnings;" does the same things in a more portable way.
3525
3526         * Scripts/commit-log-editor:
3527         * Scripts/num-cpus:
3528         * Scripts/prepare-ChangeLog:
3529         * Scripts/run-launcher:
3530         * Scripts/svn-create-patch:
3531
3532 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3533
3534         [jhbuild] We should be able to disable wiping on configuration change
3535         https://bugs.webkit.org/show_bug.cgi?id=137446
3536
3537         Reviewed by Csaba Osztrogonác.
3538
3539         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
3540         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
3541         or passing --no-wipe-on-change command line option.
3542
3543         * Scripts/update-webkit-libs-jhbuild:
3544
3545 2014-10-09  Andy Estes  <aestes@apple.com>
3546
3547         Teach webkitpy about OS X Yosemite
3548         https://bugs.webkit.org/show_bug.cgi?id=137585
3549
3550         Reviewed by Simon Fraser.
3551
3552         * Scripts/webkitpy/common/system/platforminfo.py:
3553         (PlatformInfo._determine_mac_version):
3554         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3555         (TestPlatformInfo.test_os_version):
3556         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3557         (TestExpectationParser):
3558         * Scripts/webkitpy/port/builders.py:
3559         * Scripts/webkitpy/port/mac.py:
3560         (MacPort):
3561         * Scripts/webkitpy/port/mac_unittest.py:
3562         (test_versions):
3563         (test_baseline_search_path):
3564         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3565         (TestRebaselineTest.test_baseline_directory):
3566         (TestRebaselineExpectations.test_rebaseline_expectations):
3567
3568 2014-10-09  Dana Burkart  <dburkart@apple.com>
3569
3570         Add Mac OS Yosemite dashboard support.
3571
3572         Rubber-stamped by Lucas Forschler.
3573
3574         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
3575         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
3576         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3577         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3578         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3579
3580 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
3581
3582         Add Babak to contributors.json and add historical email addresses for some contributors
3583         https://bugs.webkit.org/show_bug.cgi?id=137546
3584
3585         Reviewed by Christophe Dumez.
3586
3587         contributors.json is used to analyze historical commit data and change logs.
3588
3589         Add back historical email addresses for some contributors and also add Babak (Shafiei).
3590
3591         * Scripts/webkitpy/common/config/contributors.json:
3592
3593 2014-10-09  Lucas Forschler  <lforschler@apple.com>
3594
3595         Add Mac OS Yosemite webkit build infrastructure.
3596         
3597         This patch adds 15 bots to our build.webkit.org configuration.
3598         We are matching the current Mavericks machines 1:1.
3599         
3600         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
3601         
3602         Reviewed by Matt Hanson.
3603
3604         * BuildSlaveSupport/build.webkit.org-config/config.json:
3605
3606 2014-10-09  Dana Burkart  <dburkart@apple.com>
3607
3608         Don't use backticks when running commands, as we run into sh-related
3609         interpolation issues. Also, fix our usage of system() to properly
3610         retrieve the status code.
3611         https://bugs.webkit.org/show_bug.cgi?id=137541
3612
3613         Reviewed by Darin Adler.
3614
3615         * Scripts/git-add-reviewer:
3616         (interactive):
3617         (nonInteractive):
3618         (requireCleanWorkTree):
3619         (cherryPick):
3620         (commit):
3621         (addReviewerToFile):
3622         (head):
3623         (isAncestor):
3624         (toCommit):
3625         (changeLogsForCommit):
3626         (resetToCommit):
3627         (getConfigValue):
3628         (runCommandWithOutput):
3629
3630 2014-10-09  Tim Horton  <timothy_horton@apple.com>
3631
3632         Add a WebKit1 preference for selection services
3633         https://bugs.webkit.org/show_bug.cgi?id=137498
3634         <rdar://problem/18572699>
3635
3636         Reviewed by Simon Fraser.
3637
3638         * MiniBrowser/mac/WK1BrowserWindowController.m:
3639         (-[WK1BrowserWindowController awakeFromNib]):
3640         Turn on image and selection services in the Legacy WebKit MiniBrowser.
3641
3642 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
3643
3644         Get the patch scripts running on Haiku
3645         https://bugs.webkit.org/show_bug.cgi?id=137559
3646
3647         Reviewed by Benjamin Poulain.
3648
3649         Use /usr/bin/env instead of hardcoding path to perl.
3650         Declare haiku platform in platforminfo.py to avoid check-webkit-style
3651         failure.
3652
3653         * Scripts/commit-log-editor:
3654         * Scripts/num-cpus:
3655         * Scripts/prepare-ChangeLog:
3656         * Scripts/run-launcher:
3657         * Scripts/svn-create-patch:
3658         * Scripts/webkitpy/common/system/platforminfo.py:
3659         (PlatformInfo._determine_os_name):
3660
3661 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
3662
3663         StyleQueue should throw a PatchIsNotValid exception to achieve
3664         consistency with CommitQueue and EWS
3665         https://bugs.webkit.org/show_bug.cgi?id=137500
3666
3667         Reviewed by Alexey Proskuryakov.
3668
3669         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3670         Adds a call to validate() in run().
3671         (StyleQueueTask.run):
3672         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3673         Adds a return False in the patch is not valid exception statement.
3674         (AbstractEarlyWarningSystem.review_patch):
3675         * Scripts/webkitpy/tool/commands/queues.py:
3676         Adds a return False in the patch is not valid exception statement in
3677         commit queue, and adds an except statement to catch PatchIsNotValid
3678         exceptions in style queue.
3679         (CommitQueue.process_work_item):
3680         (StyleQueue.review_patch):
3681
3682 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3683
3684         Race condition with WebKitWebView:is-loading after starting page load
3685         https://bugs.webkit.org/show_bug.cgi?id=136692
3686
3687         Reviewed by Gustavo Noronha Silva.
3688
3689         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3690         (loadChangedCallback): Only check is-loading is false when load
3691         has finished if the load didn't fail due to a cancellation.
3692         (loadFailedCallback): Only check is-loading is false if the load
3693         didn't fail due to a cancellation.
3694         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3695         (WebViewTest::loadURI): Check is-loading is true and active URI is
3696         the requested one rigth after requesting the load.
3697         (WebViewTest::loadHtml): Ditto.
3698         (WebViewTest::loadPlainText): Ditto.
3699         (WebViewTest::loadBytes): Ditto.
3700         (WebViewTest::loadRequest): Ditto.
3701         (WebViewTest::loadAlternateHTML): Ditto.
3702         (WebViewTest::goBack): Ditto.
3703         (WebViewTest::goForward): Ditto.
3704         (WebViewTest::goToBackForwardListItem): Ditto.
3705
3706 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
3707
3708         [Win] Resolve various static analyzer warnings in Tools.
3709         https://bugs.webkit.org/show_bug.cgi?id=137534
3710
3711         Reviewed by Dean Jackson.
3712
3713         * DumpRenderTree/cg/ImageDiffCG.cpp:
3714         (main): User proper printf specifiers.
3715         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3716         (AccessibilityUIElement::childrenCount): Handle possibility that
3717         gcc_accChildCount returns with an error.
3718         (accessibilityState): Ditto for gcc_accState.
3719         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3720         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
3721         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
3722         be treated as such.
3723         * DumpRenderTree/win/DumpRenderTree.cpp:
3724         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
3725         by comparing an unsigned value as being greater-than zero.
3726         * DumpRenderTree/win/EditingDelegate.cpp:
3727         (dump): Pass proper character pointer type to printf.
3728         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
3729         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
3730         (EditingDelegate::shouldInsertNode): Ditto.
3731         (EditingDelegate::shouldInsertText): Ditto.
3732         (EditingDelegate::shouldDeleteDOMRange): Ditto.
3733         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
3734         (EditingDelegate::shouldApplyStyle): Ditto.
3735         * DumpRenderTree/win/EventSender.cpp:
3736         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
3737         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
3738         system headers.
3739         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
3740         from CreateDIBSection.
3741         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
3742         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
3743         older versions of MSVC we no longer support.
3744         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
3745         for 64-bit builds.
3746         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
3747         * TestWebKitAPI/TestsController.h: Ditto.
3748         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
3749         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
3750         performing bitwise | before the comparison is done.
3751
3752 2014-10-08  Ada Chan  <adachan@apple.com>
3753
3754         Add a test for WKPageIsPlayingAudio().
3755         https://bugs.webkit.org/show_bug.cgi?id=137048
3756
3757         Reviewed by Darin Adler.
3758
3759         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3760         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
3761         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
3762         (TestWebKitAPI::nullJavaScriptCallback):
3763         (TestWebKitAPI::didFinishLoadForFrame):
3764         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
3765         (TestWebKitAPI::setUpClients):
3766         (TestWebKitAPI::TEST):
3767         This test loads a page with a video in it. When the page is loaded, we first check that
3768         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
3769         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
3770         now returns true for the page.
3771         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
3772         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
3773         This is a video copied from LayoutTests/media/content.
3774
3775 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
3776
3777         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
3778         https://bugs.webkit.org/show_bug.cgi?id=137516
3779
3780         Reviewed by Alexey Proskuryakov.
3781
3782         * Scripts/webkitpy/thirdparty/__init__.py:
3783         (AutoinstallImportHook._install_irc):
3784
3785 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3786
3787         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
3788         https://bugs.webkit.org/show_bug.cgi?id=137520
3789
3790         Reviewed by Philippe Normand.
3791
3792         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
3793         For other distributions, we are already installing libjpeg-turbo.
3794         So, do the same for Debian and derivatives.
3795
3796         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
3797
3798 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3799
3800         [webkitpy] Add back the workaround to replace ZipFile.extractall()
3801         https://bugs.webkit.org/show_bug.cgi?id=137519
3802
3803         Reviewed by Csaba Osztrogonác.
3804
3805         It was removed by <http://trac.webkit.org/changeset/174266>,
3806         because the comment stated it is a workaround for buggy python
3807         2.6.1 which shipped on Snow Leopard. But it turned out the bug
3808         is still valid with python 2.7 shipped on the latest Ubuntu
3809         (12.04 and 14.04) and OS X 10.9.
3810
3811         * Scripts/webkitpy/common/system/autoinstall.py:
3812         (AutoInstaller):
3813         (AutoInstaller._extract_all):
3814         (AutoInstaller._unzip):
3815
3816 2014-10-08  Commit Queue  <commit-queue@webkit.org>
3817
3818         Unreviewed, rolling out r174335.
3819         https://bugs.webkit.org/show_bug.cgi?id=137515
3820
3821         It broke EFL layout test totally (Requested by gyuyoung on
3822         #webkit).
3823
3824         Reverted changeset:
3825
3826         "[EFL] Introduce EWebKit_Extension"
3827         https://bugs.webkit.org/show_bug.cgi?id=134921
3828         http://trac.webkit.org/changeset/174335
3829
3830 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3831
3832         [GTK] Make forwarding headers generation depend on source code
3833         https://bugs.webkit.org/show_bug.cgi?id=137394
3834
3835         Reviewed by Philippe Normand.
3836
3837         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
3838         * TestWebKitAPI/PlatformGTK.cmake: Only run
3839         generate-forwarding-headers.pl when source code changes.
3840         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
3841
3842 2014-10-07  Tanay C  <tanay.c@samsung.com>
3843
3844         Remove build warnings in Hashmap API tests
3845         https://bugs.webkit.org/show_bug.cgi?id=137484
3846
3847         Reviewed by Darin Adler.
3848
3849         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3850         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
3851
3852 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
3853
3854         Commit queue doesn't drop obsolete patches sometimes
3855         https://bugs.webkit.org/show_bug.cgi?id=137460
3856
3857         Reviewed by Alexey Proskuryakov.
3858
3859         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3860         Adds another test patch for use in queues_unittest.py.
3861         courtesy of Csaba Osztrogonác <ossy@webkit.org>
3862         (MockBugzilla):
3863         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3864         Raises a PatchIsNotValid exception in the case of validate() returning
3865         false.
3866         (CommitQueueTask.run):
3867         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3868         Raises a PatchIsNotValid exception in the case of validate() returning
3869         false.
3870         (EarlyWarningSystemTask.run):
3871         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3872         Defines PatchIsNotValid exception. 
3873         (PatchIsNotValid):
3874         (PatchIsNotValid.__init__):
3875         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3876         Remove call to validate() and instead catches the PatchIsNotValid
3877         exception.
3878         (AbstractEarlyWarningSystem.review_patch):
3879         * Scripts/webkitpy/tool/commands/queues.py:
3880         Adds logic to catch the PatchIsNotValid exception.
3881         (CommitQueue.process_work_item):
3882         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3883         Adds the test_non_valid_patch test to ensure that invalid patches are
3884         handled properly, and don't just result in indefinite spinning.
3885         courtesy of Csaba Osztrogonác <ossy@webkit.org>
3886         (test_non_valid_patch):
3887
3888 2014-10-07  Daniel Bates  <dabates@apple.com>
3889
3890         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
3891         https://bugs.webkit.org/show_bug.cgi?id=137499
3892
3893         Reviewed by Simon Fraser.
3894
3895         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
3896         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
3897         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
3898         bit simulator builds of iOS WebKit.
3899
3900         * Scripts/webkitpy/port/ios.py:
3901         (IOSSimulatorPort._generate_all_test_configurations):
3902
3903 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3904
3905         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
3906         https://bugs.webkit.org/show_bug.cgi?id=137482
3907
3908         Reviewed by Martin Robinson.
3909
3910         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
3911
3912 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3913
3914         [SOUP] TLS errors should take precedence over HTTP authentication
3915         https://bugs.webkit.org/show_bug.cgi?id=137300
3916
3917         Reviewed by Sergio Villar Senin.
3918
3919         Add a test case to check that authenticate signal is not emitted
3920         in case of TLS errors, and the load fails instead.
3921
3922         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3923         (webViewAuthenticationCallback):
3924         (testTLSErrorsHTTPAuth):
3925         (httpsServerCallback):
3926         (beforeAll):
3927
3928 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
3929
3930         Make webkit-patch find-users useful
3931         https://bugs.webkit.org/show_bug.cgi?id=137475
3932
3933         Reviewed by Alexey Proskuryakov.
3934
3935         Make find-users use the CommitterList instead of accessing Bugzilla.
3936
3937         This essentially exposes the same functionality as webkitbot's whois command.
3938
3939         * Scripts/webkitpy/tool/commands/findusers.py:
3940         (FindUsers.execute):
3941
3942 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
3943
3944         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
3945         https://bugs.webkit.org/show_bug.cgi?id=137289
3946
3947         Unreviewed build fix.
3948
3949         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3950         (AccessibilityUIElement::getChildrenWithRange):
3951
3952 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
3953
3954         build.webkit.org/dashboard: Add commit queue
3955         https://bugs.webkit.org/show_bug.cgi?id=137462
3956
3957         Reviewed by Tim Horton.
3958
3959         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
3960         Style queue is still invisible, as it doesn't have an associated platform, and also
3961         we never have problems with it anyway, so it's not worth watching.
3962
3963         The UI now allows for adding more bots to the Other column (such as leaks bot).
3964         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
3965         sources of data in a cell.
3966
3967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
3968         (BubbleQueue):
3969         (BubbleQueue.prototype.get statusPageURL):
3970         (BubbleQueue.prototype.update):
3971         (BubbleQueue.prototype.loadDetailedStatus):
3972         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
3973         (BubbleQueueServer):
3974         (BubbleQueueServer.prototype.jsonQueueLengthURL):
3975         (BubbleQueueServer.prototype.jsonQueueStatusURL):
3976         (BubbleQueueServer.prototype.queueStatusURL):
3977         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
3978         (BubbleQueueView):
3979         (BubbleQueueView.prototype.update.appendQueue):
3980         (BubbleQueueView.prototype.update):
3981         (BubbleQueueView.prototype._addQueueHeadingToPopover):
3982         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
3983         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
3984         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
3985         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
3986         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
3987         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3988         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3989         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3990         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
3991         (.bubble-server-popover .latest-status-no-link):
3992         (.bubble-server-popover .bot-status-description):
3993         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3994
3995         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3996         (buildAggregateTable):
3997         (buildQueuesTable):
3998         Removed dysfunctional support for EWS for now. It will be different.
3999
4000 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
4001
4002         One more case of incorrect comparison in recordpatchevent.py
4003         https://bugs.webkit.org/show_bug.cgi?id=137459
4004
4005         Reviewed by Tim Horton.
4006
4007         * QueueStatusServer/app.yaml:
4008         * QueueStatusServer/loggers/recordpatchevent.py:
4009         (RecordPatchEvent.started):
4010
4011 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
4012
4013         webkit-queues PatchLog is incorrect for patches that took less than a second
4014         https://bugs.webkit.org/show_bug.cgi?id=137453
4015
4016         Reviewed by Tim Horton.
4017
4018         * QueueStatusServer/app.yaml: Updated app version.
4019
4020         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
4021         Don't bail out for patches that took 0 seconds to process (as frequently happens
4022         when a patch is obsolete).
4023
4024 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
4025
4026         EWS bubble hover shows wrong timestamps
4027         https://bugs.webkit.org/show_bug.cgi?id=137252
4028
4029         Reviewed by Alexey Proskuryakov.
4030
4031         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
4032
4033         * QueueStatusServer/handlers/queuestatusjson.py:
4034         (QueueStatusJSON.get):
4035         * QueueStatusServer/handlers/statusbubble.py:
4036         (StatusBubble._iso_time):
4037
4038 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
4039
4040         Unreviewed, updated list of email addresses in contributors.json
4041
4042         * Scripts/webkitpy/common/config/contributors.json: Added my former
4043         email address in Igalia, for the sake of completeness.
4044
4045 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
4046
4047         Unreviewed, moved myself to the list of committers.
4048
4049         * Scripts/webkitpy/common/config/contributors.json:
4050
4051 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
4052
4053         [EFL] Introduce EWebKit_Extension
4054         https://bugs.webkit.org/show_bug.cgi?id=134921
4055
4056         Reviewed by Gyuyoung Kim.
4057
4058         * MiniBrowser/efl/main.c: Added x option to test extension path.
4059         (window_create):
4060         (elm_main):
4061         * Scripts/webkitpy/common/config/watchlist:
4062         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
4063         * Scripts/webkitpy/style/checker.py:
4064         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
4065
4066 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
4067
4068         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
4069         https://bugs.webkit.org/show_bug.cgi?id=137390
4070
4071         Reviewed by Carlos Garcia Campos.
4072
4073         * Scripts/update-webkit-libs-jhbuild:
4074
4075 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4076
4077         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
4078         https://bugs.webkit.org/show_bug.cgi?id=137391
4079
4080         Reviewed by Martin Robinson.
4081
4082         Add a custom command to only re-generate
4083         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
4084
4085         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
4086
4087 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4088
4089         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
4090         https://bugs.webkit.org/show_bug.cgi?id=135502
4091
4092         Reviewed by Martin Robinson.
4093
4094         When writing to stdout/stderr fails due to a UnicodeDecodeError
4095         exception, try again without encoding the output.
4096
4097         * gtk/gtkdoc.py:
4098         (GTKDoc._run_command):
4099
4100 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
4101
4102         Bugzilla status bubble displays an exception showing attachment 175738
4103         https://bugs.webkit.org/show_bug.cgi?id=137410
4104
4105         Reviewed by Tim Horton.
4106
4107         * QueueStatusServer/app.yaml: Update version.
4108
4109         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
4110         Don't fail even if expected status message is missing.
4111
4112         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
4113         the field in the same way it's defined in QueueStatus table.
4114
4115 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
4116
4117         Record latest message in PatchLog for quick access
4118         https://bugs.webkit.org/show_bug.cgi?id=137405
4119
4120         Fixing a typo.
4121
4122         * QueueStatusServer/app.yaml:
4123         * QueueStatusServer/handlers/releasepatch.py:
4124
4125 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
4126
4127         Record latest message in PatchLog for quick access
4128         https://bugs.webkit.org/show_bug.cgi?id=137405
4129
4130         Reviewed by Ryosuke Niwa.
4131
4132         It's no SQL...
4133
4134         * QueueStatusServer/handlers/releasepatch.py:
4135         * QueueStatusServer/handlers/updatestatus.py:
4136         * QueueStatusServer/loggers/recordpatchevent.py:
4137         * QueueStatusServer/model/patchlog.py:
4138
4139 2014-10-02  David Farler  <dfarler@apple.com>
4140
4141         -asan-blacklist option also renamed to generic -fsanitize-blacklist
4142         https://bugs.webkit.org/show_bug.cgi?id=137377
4143
4144         Reviewed by Daniel Bates.
4145
4146         * asan/asan.xcconfig:
4147         -asan-blacklist -> -fsanitize-blacklist
4148
4149         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
4150
4151 2014-10-03  Roger Fong  <roger_fong@apple.com>
4152
4153         [Windows] Include batch size argument to layout tests on Windows.
4154
4155         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4156         (RunWebKitTests.start): 
4157         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
4158         These crashes seem to happen on random tests though generally in a spread out fashion.
4159         It seems possible that the DRT instance is being clobbered somehow after running too many
4160         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
4161
4162 2014-10-03  Roger Fong  <roger_fong@apple.com>
4163
4164         [Windows] Settle for 2 chid processes running NRWT on Windows.
4165
4166         * Scripts/webkitpy/port/win.py:
4167         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
4168
4169 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
4170
4171         [GTK] Bump up and patch dependencies to allow building for aarch64
4172         https://bugs.webkit.org/show_bug.cgi?id=137147
4173
4174         Reviewed by Martin Robinson.
4175
4176         The currently used versions of pixman, libffi, librsvg, glib,
4177         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
4178         and/or build for aarch64, so they are bumped up and patched where
4179         necessary. Wherever possible, the same versions and patches were used as
4180         for the EFL port bump-up
4181         (https://bugs.webkit.org/show_bug.cgi?id=135885).
4182
4183         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
4184         regression by crashing http/tests/media/video-redirect.html . A patch
4185         already in upstream fixes that bug.
4186
4187         This change does not touch xserver, which also needs bumping up, but 
4188         will be dealt with later.
4189
4190         * gtk/jhbuild.modules:
4191         Specified versions and patches necessary to correctly build for aarch64.
4192         * gtk/patches/gst-events-arent-gstobjects.patch:
4193         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
4194         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
4195         Added. Patches gst-plugins-base to configure correctly for aarch64.
4196         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
4197         Added. Bumps up config.guess and config.sub in librsvg to recognize
4198         aarch64.
4199         * gtk/patches/libxml2-2.9.0-dtd.patch:
4200         Removed. Not necessary for libxml2 v2.9.1 anymore.
4201
4202 2014-09-28  Sam Weinig  <sam@webkit.org>
4203
4204         Remove RefPtrHashMap
4205         https://bugs.webkit.org/show_bug.cgi?id=137200
4206
4207         Reviewed by Darin Adler.
4208
4209         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4210         (TestWebKitAPI::TEST):
4211         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
4212         a minimum of refcount churn occurs.
4213
4214 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4215
4216         Remove workarounds for versions of Python before 2.7
4217         https://bugs.webkit.org/show_bug.cgi?id=137338
4218
4219         Reviewed by Csaba Osztrogonác.
4220
4221         * Scripts/webkitpy/common/system/autoinstall.py:
4222         (AutoInstaller._extract_targz):
4223         (AutoInstaller._unzip):
4224         (AutoInstaller): Deleted.
4225         (AutoInstaller._extract_all): Deleted.
4226         * Scripts/webkitpy/common/webkitunittest.py:
4227         (TestCase.setUp): Deleted.
4228         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
4229         (TestConfigurationConverter.collapse_macros):
4230         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
4231         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
4232         (TestConfigurationConverter):
4233         (TestConfigurationConverter.combinations): Deleted.
4234         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4235         * Scripts/webkitpy/port/base.py:
4236
4237 2014-10-03  Commit Queue  <commit-queue@webkit.org>
4238
4239         Unreviewed, rolling out r174264.
4240         https://bugs.webkit.org/show_bug.cgi?id=137392
4241
4242         It broke run-webkit-tests (Requested by ebalazsfalvi on
4243         #webkit).
4244
4245         Reverted changeset:
4246
4247         "Remove workarounds for versions of Python before 2.7"
4248         https://bugs.webkit.org/show_bug.cgi?id=137338
4249         http://trac.webkit.org/changeset/174264
4250
4251 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4252
4253         Remove workarounds for versions of Python before 2.7
4254         https://bugs.webkit.org/show_bug.cgi?id=137338
4255
4256         Reviewed by Csaba Osztrogonác.
4257
4258         * Scripts/webkitpy/common/system/autoinstall.py:
4259         (AutoInstaller._extract_targz):
4260         (AutoInstaller._unzip):
4261         (AutoInstaller): Deleted.
4262         (AutoInstaller._extract_all): Deleted.
4263         * Scripts/webkitpy/common/webkitunittest.py:
4264         (TestCase.setUp): Deleted.
4265         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
4266         (TestConfigurationConverter.collapse_macros):
4267         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
4268         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
4269         (TestConfigurationConverter):
4270         (TestConfigurationConverter.combinations): Deleted.
4271         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4272         * Scripts/webkitpy/port/base.py:
4273         * Scripts/webkitpy/port/driver.py:
4274         (ContentBlock.__init__):
4275         * Scripts/webkitpy/port/server_process.py:
4276         (ServerProcess._reset):
4277
4278 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4279
4280         Remove autoinstaller workaround for python 2.6
4281         https://bugs.webkit.org/show_bug.cgi?id=137343
4282
4283         Reviewed by Daniel Bates.
4284
4285         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
4286         2.6, nor Snow Leopard is supported anymore, so the workaround is not
4287         needed anymore.
4288
4289         * Scripts/webkitpy/common/system/autoinstall.py:
4290         (AutoInstaller.install):
4291         * Scripts/webkitpy/test/main.py:
4292         (Tester._run_tests):
4293         * Scripts/webkitpy/thirdparty/__init__.py:
4294