981b86cd060860cdd6063b0b2994681a24c3858a
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-14  Ojan Vafai  <ojan@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         sort columns in the new json_results.html file
6         https://bugs.webkit.org/show_bug.cgi?id=58581
7
8         Also fix padding on TDs and the path to layout tests.
9
10         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
11
12 2011-04-14  Eric Seidel  <eric@webkit.org>
13
14         Reviewed by Dimitri Glazkov.
15
16         queues.webkit.org should display when a bot last passed a patch
17         https://bugs.webkit.org/show_bug.cgi?id=58546
18
19         I am suspicious that some of our commit-queue instances are never
20         actually passing anything.
21
22         This will let us know if those bots are never passing patches.
23
24         * QueueStatusServer/handlers/queuestatus.py:
25         * QueueStatusServer/index.yaml:
26         * QueueStatusServer/templates/queuestatus.html:
27
28 2011-04-14  Dirk Pranke  <dpranke@chromium.org>
29
30         Reviewed by Adam Roben.
31
32         REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13
33         https://bugs.webkit.org/show_bug.cgi?id=58545
34
35         Remove platform-specific overrides; the default behavior should
36         be working everywhere now, I think.
37
38         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
39         * Scripts/webkitpy/layout_tests/port/mac.py:
40
41 2011-04-14  Eric Seidel  <eric@webkit.org>
42
43         Reviewed by Adam Barth.
44
45         commit-queues are hitting an exception trying to land when the tree is red
46         https://bugs.webkit.org/show_bug.cgi?id=58558
47
48         Just an un-tested (and thus broken) code path from yesterday's changes.
49
50         * Scripts/webkitpy/common/net/layouttestresults.py:
51         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
52         * Scripts/webkitpy/tool/commands/queues.py:
53         * Scripts/webkitpy/tool/commands/queues_unittest.py:
54
55 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
56
57         [wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1.
58
59         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
60         (LayoutTestController::shadowRoot):
61         * wx/build/wxpresets.py:
62
63 2011-04-14  Victoria Kirst  <vrk@google.com>
64
65         Reviewed by James Robinson.
66
67         [chromium] Failing GPU video tests
68         https://bugs.webkit.org/show_bug.cgi?id=57926
69
70         Added/updated GPU directory names for rebaseline tool.
71
72         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
73
74 2011-04-13  Daniel Bates  <dbates@rim.com>
75
76         Reviewed by Adam Barth.
77
78         Perl unit test removeEOL.pl should print test case name on failure
79         https://bugs.webkit.org/show_bug.cgi?id=58513
80
81         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Pass $title as
82           second argument of Test::Simple::ok().
83
84 2011-04-13  Kent Tamura  <tkent@chromium.org>
85
86         Reviewed by Eric Seidel.
87
88         gdb-safari should pass arguments to safari.
89         https://bugs.webkit.org/show_bug.cgi?id=58439
90
91         We can do:
92           gdb-safari --debug LayoutTests/.../foo.html
93
94         * Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg.
95
96 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
97
98         Unreviewed, build fix.
99         https://bugs.webkit.org/show_bug.cgi?id=52763
100
101         r83799 broke test-webkitpy because it assumed we always have
102         access to a real filesystem (we don't during the unit tests).
103         Stubbing out the copy for now but we might need a better
104         solution at some point.
105
106         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
107
108 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
109
110         Reviewed by Tony Chang.
111
112         new-run-webkit-tests --run-singly option is busted
113         https://bugs.webkit.org/show_bug.cgi?id=55909
114
115         Python's broken lexical scoping strikes again :(.
116
117         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
118         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
119
120 2011-04-13  Ojan Vafai  <ojan@chromium.org>
121
122         Reviewed by Eric Seidel.
123
124         generated unexpected_results.html from unexpected_results.json
125         https://bugs.webkit.org/show_bug.cgi?id=52763
126
127         Eventually, we'll merge this with results.html and have a single richer results page.
128         For now, I just want to get something checked in that we can iterate on.
129
130         * Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added.
131         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
132
133 2011-04-13  Eric Seidel  <eric@webkit.org>
134
135         Reviewed by Adam Barth.
136
137         Up the failure limit to allow the commit-queue to actually land when the tree is red
138         https://bugs.webkit.org/show_bug.cgi?id=58499
139
140         This change increases the --exit-after-N-failures limit used by the commit-queue
141         from 1 to 10.  This will cause the code added in bug 58494 to actually get
142         exercised and the queues should start being able to land when the trees are red.
143
144         When testing I found that test_runtests_leopard_commit_queue_hack_command was the
145         only unit test to actually detect this change!  Since we don't actually
146         run on leopard anymore, I removed the hack code and repurposed the test.
147
148         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
149         * Scripts/webkitpy/tool/steps/runtests.py:
150         * Scripts/webkitpy/tool/steps/steps_unittest.py:
151
152 2011-04-13  Eric Seidel  <eric@webkit.org>
153
154         Reviewed by Adam Barth.
155
156         commit-queue should be able to land when tree is red
157         https://bugs.webkit.org/show_bug.cgi?id=58494
158
159         There is some yak hair on my hands, I will admit.
160
161         This change is mostly about adding an ExpectedFailures
162         class to track when the bots are red and we should be
163         ignoring failures when landing from the commit-queue.
164
165         However, to make intelligent decisions about patches we
166         need to know whether the run hit the --exit-after-N-failures limit
167         or not.  Right now that information is not saved off in results.html
168         so we have to pull the information from RunTests.
169
170         I've plumbed the --exit-after-N-failures information into
171         LayoutTestResults for now to make the ExpectedFailures code cleaner.
172
173         As a result of adding all these additional calls to delegate.layout_test_results()
174         I broke some of our flaky test detection tests and had to re-write them
175         to not depend on the number of layout_test_results code.
176
177         At the same time I updated the commit-queue to use the newer filesystem
178         API (to allow us to use MockFileSystem) which required further changes
179         to the layout tests.  Changes were required in either case, since
180         we're now calling layout_test_results() in more cases, which previously
181         would try and hit the disk (until I moved it to use tool.filesystem).
182
183         I should note that *all* of this code is disabled for now, since our
184         --exit-after-N-failures limit is currently 1!  (Thus were always in the
185         case where we can't actually tell if the layout test results are legit.)
186         I will up that limit in a second patch (which may require a couple more unit test tweaks).
187
188         * Scripts/webkitpy/common/net/layouttestresults.py:
189         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
190         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
191         * Scripts/webkitpy/tool/bot/expectedfailures.py: Added.
192         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Added.
193         * Scripts/webkitpy/tool/commands/queues.py:
194         * Scripts/webkitpy/tool/commands/queues_unittest.py:
195         * Scripts/webkitpy/tool/commands/queuestest.py:
196         * Scripts/webkitpy/tool/steps/runtests.py:
197
198 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
199
200         Unreviewed build correction.
201
202         * TestWebKitAPI/PlatformWebView.h: Limit include of
203           <CoreGraphics/CGGeometry> to PLATFORM(CG) users.
204
205 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
206
207         Reviewed by Eric Seidel.
208
209         [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
210         https://bugs.webkit.org/show_bug.cgi?id=58489
211         
212         r83743 added --additional-platform-directory to old-run-webkit-tests,
213         rename the equivalent flag in new-run-webkit-tests to be consistent.
214
215         * Scripts/webkitpy/layout_tests/port/base.py:
216         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
217         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
218         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
219
220 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
221
222         Reviewed by Eric Seidel.
223
224         Rebaseline queue server
225         https://bugs.webkit.org/show_bug.cgi?id=57891
226
227         Adds a simple rebaseline queue server (meant to run at
228         http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT)
229         builders and their failing tests, and allows those tests to be added to
230         a per-builer rebaseline queue.
231
232         A subsequent change will add a mode to NRWT (and/or a wrapper script)
233         for pulling the tests to be rebaselined from the server and running them
234         with --reset-results (the initial use-case is for the GPU hardware bots,
235         which do not have checked-in baselines, therefore there is no need for a
236         check-in step yet).
237
238         * RebaselineQueueServer/app.yaml: Added.
239         * RebaselineQueueServer/handlers/__init__.py: Added.
240         * RebaselineQueueServer/handlers/builderqueue.py: Added.
241         * RebaselineQueueServer/handlers/pages.py: Added.
242         * RebaselineQueueServer/index.yaml: Added.
243         * RebaselineQueueServer/main.py: Added.
244         * RebaselineQueueServer/model/__init__.py: Added.
245         * RebaselineQueueServer/model/queueentry.py: Added.
246         * RebaselineQueueServer/static/builder-frame-empty.html: Added.
247         * RebaselineQueueServer/static/styles.css: Added.
248         * RebaselineQueueServer/templates/builder-picker.html: Added.
249         * RebaselineQueueServer/templates/builder-queue-edit.html: Added.
250         * RebaselineQueueServer/templates/builder-queue-list.html: Added.
251         * RebaselineQueueServer/templates/home.html: Added.
252
253 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
254
255         Reviewed by Mihai Parparita.
256
257         nrwt: enable multiple processes by default on Chromium Win.
258         https://bugs.webkit.org/show_bug.cgi?id=55163
259
260         Re-land r79268; it should be more stable now and will hopefully
261         work.
262
263         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
264         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
265
266 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
267
268         Reviewed by Ojan Vafai.
269
270         new-run-webkit-tests: configure logging in child processes properly
271         https://bugs.webkit.org/show_bug.cgi?id=58296
272
273         Logging propagated properly from manager to worker processes on
274         Unix but not on Windows; this fixes that.
275
276         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
277         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
278
279 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
280
281         Reviewed by Ojan Vafai.
282
283         new-run-webkit-tests: suppress extraneous pretty patch warnings
284         https://bugs.webkit.org/show_bug.cgi?id=58295
285
286         NRWT wasn't being careful about when it logged messages from
287         PrettyPatch not being available; it should only log during
288         check_build(), and be silent otherwise. This was causing us to
289         get multiple errors at runtime, which was confusing.
290
291         * Scripts/webkitpy/layout_tests/port/base.py:
292         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
293         * Scripts/webkitpy/layout_tests/port/chromium.py:
294
295 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
296
297         Reviewed by Jian Li.
298
299         add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests
300         https://bugs.webkit.org/show_bug.cgi?id=58461
301
302         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
303
304 2011-04-13  Tony Chang  <tony@chromium.org>
305
306         Unreviewed, fix NRWT.  Stack:
307
308             return super(ChromiumPort, self).results_directory(self)
309         TypeError: results_directory() takes exactly 1 argument (2 given)
310
311         * Scripts/webkitpy/layout_tests/port/chromium.py:
312
313 2011-04-13  Adam Roben  <aroben@apple.com>
314
315         Teach ORWT about extra platform-specific directories to be searched before the default ones
316
317         Fixes <http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for
318         platform-specific results
319
320         Reviewed by Anders Carlsson.
321
322         * Scripts/old-run-webkit-tests:
323         (top-level): Added @additionalPlatformDirectories and hooked up
324         --additional-platform-directories to populate it.
325         (buildPlatformResultHierarchy): Prepend the additional platform directories to the default
326         list (after filtering out any of the additional directories that don't exist).
327
328 2011-04-13  Lucas Forschler  <lforschler@apple.com>
329
330         Reviewed by Adam Roben.
331
332         Add the /T command to taskkill.exe.
333         This will kill spawned child processes.
334         
335         * BuildSlaveSupport/win/kill-old-processes:
336
337 2011-04-13  Lucas Forschler  <lforschler@apple.com>
338
339         Reviewed by Adam Roben.
340
341         Sort kill list alphabeticaly.
342         Fixed capitalization on VcBuildHelper.  
343
344         * BuildSlaveSupport/win/kill-old-processes:
345
346 2011-04-13  Lucas Forschler  <lforschler@apple.com>
347
348         Reviewed by Adam Roben.
349
350         https://bugs.webkit.org/show_bug.cgi?id=58384
351         Update kill-old-processes to include a few new ones.
352         
353         * BuildSlaveSupport/win/kill-old-processes:
354
355 2011-04-13  Gustavo Noronha Silva  <gns@gnome.org>
356
357         Reviewed by Martin Robinson.
358
359         [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
360         https://bugs.webkit.org/show_bug.cgi?id=58297
361
362         Do not disable flash specifically when built with GTK+ 3 -
363         PluginPackage should do the right thing while loading plugins.
364
365         * GtkLauncher/main.c:
366         (main):
367
368 2011-04-12  Kent Tamura  <tkent@chromium.org>
369
370         Reviewed by Dimitri Glazkov.
371
372         [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
373         https://bugs.webkit.org/show_bug.cgi?id=57426
374
375         * DumpRenderTree/chromium/WebPreferences.cpp:
376         (WebPreferences::applyTo): Disable the validation message timer.
377
378 2011-04-12  James Kozianski  <koz@chromium.org>
379
380         Unreviewed.
381
382         Adding myself to committers.py.
383
384         * Scripts/webkitpy/common/config/committers.py:
385
386 2011-04-12  Brent Fulgham  <bfulgham@webkit.org>
387
388         Unreviewed build correction for WinCairo bot after r83639.
389         https://bugs.webkit.org/show_bug.cgi?id=51790
390
391         Correct typo for the new "update-webkit-wincairo-libs" script.
392
393         * Scripts/build-webkit: Incorrectly calling the
394           update-webkit-cairo-libs which does not exist.
395
396 2011-04-12  Alice Liu  <alice.liu@apple.com>
397
398         Reviewed by Jon Honeycutt.
399
400         A change that should have been part of http://trac.webkit.org/changeset/83628
401
402         * DumpRenderTree/win/DumpRenderTree.cpp:
403         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
404
405 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
406
407         Reviewed by Tony Chang.
408
409         new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
410         https://bugs.webkit.org/show_bug.cgi?id=58272
411
412         NRWT was interpreting the --results-directory cmd line arg as
413         relative to the build directory, not the current working
414         directory (ORWT uses the latter, which is much more intuitive).
415         
416         This patch fixes the base case, but includes an override for
417         Chromium that is needed until the bots can be updated.
418
419         * Scripts/webkitpy/layout_tests/port/base.py:
420         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
421         * Scripts/webkitpy/layout_tests/port/chromium.py:
422         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
423         * Scripts/webkitpy/layout_tests/port/test.py:
424         * Scripts/webkitpy/layout_tests/port/webkit.py:
425         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
426         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
427
428 2011-04-12  Philippe Normand  <pnormand@igalia.com>
429
430         Unreviewed, roll out r83621 as it broke the GTK build.
431
432         [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
433         https://bugs.webkit.org/show_bug.cgi?id=58333
434
435         * Scripts/build-jsc:
436         * Scripts/build-webkit:
437
438 2011-04-12  Carl Lobo  <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>
439
440         Reviewed by Adam Roben.
441
442         Patch to download the WinCairo dependancies as part of build-webkit.
443         https://bugs.webkit.org/show_bug.cgi?id=51790
444
445         This patch downloads the dependancies from 
446             http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip 
447         checking the modification timestamp etc. 
448
449         * Tools/Scripts/build-webkit
450         * Tools/Scripts/update-webkit: Modified to understand the --wincairo
451           flag, and to update WinCairo dependencies when used.
452         * Tools/Scripts/update-webkit-cairo-libs: added
453         * Tools/Scripts/update-webkit-dependency: added
454         * Tools/Scripts/update-webkit-auxiliary-libs
455
456 2011-04-12  Jeff Miller  <jeffm@apple.com>
457
458         Reviewed by Adam Roben.
459
460         WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
461         https://bugs.webkit.org/show_bug.cgi?id=56020
462
463         Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
464         since WebKit will do this for us.  If we didn't do this, TranslateMessage() would be called twice,
465         which would generate two characters for every keypress (for example).  I didn't bother doing this for
466         WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.
467         
468         Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.
469
470         * MiniBrowser/win/main.cpp:
471         (shouldTranslateMessage): Added.
472         (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
473         * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
474         * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
475         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
476         (TestWebKitAPI::didNotHandleKeyEventCallback): Added.
477         (TestWebKitAPI::runAndWatchForWMChar): Added.
478         (TestWebKitAPI::TEST): Added.
479         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
480         (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
481         (TestWebKitAPI::Util::shouldTranslateMessage): Added.
482         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
483         (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
484         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
485
486 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
487
488         Reviewed by Tony Chang.
489
490         new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
491         https://bugs.webkit.org/show_bug.cgi?id=58290
492
493         This is some preliminary refactoring for bug 58272.
494
495         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
496         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
497         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
498         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
499         * Scripts/webkitpy/layout_tests/port/test.py:
500         * Scripts/webkitpy/layout_tests/port/chromium.py:
501         * Scripts/webkitpy/layout_tests/port/base.py:
502         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
503
504 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
505
506         Reviewed by Eric Seidel.
507
508         webkitpy: fix mock_filesystem abspath to handle relative paths
509         and add filesystem.chdir() and filesystem.getcwd() to be able
510         to test this and mock it out.
511
512         https://bugs.webkit.org/show_bug.cgi?id=58288
513
514         * Scripts/webkitpy/common/system/filesystem.py:
515         * Scripts/webkitpy/common/system/filesystem_mock.py:
516         * Scripts/webkitpy/common/system/filesystem_unittest.py:
517
518 2011-04-12  Alice Liu  <alice.liu@apple.com>
519
520         Reviewed by Sam Weinig.
521
522         https://bugs.webkit.org/show_bug.cgi?id=58292
523         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
524
525         * DumpRenderTree/mac/DumpRenderTree.mm:
526         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
527
528 2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
529
530         Reviewed by Eric Seidel.
531
532         [Qt] Enable JIT build for SH4 platforms.
533         https://bugs.webkit.org/show_bug.cgi?id=58317
534
535
536         * DumpRenderTree/qt/DumpRenderTree.pro:
537         * QtTestBrowser/QtTestBrowser.pro:
538         * Scripts/webkitdirs.pm:
539
540 2011-04-12  Tony Chang  <tony@chromium.org>
541
542         Reviewed by Andreas Kling.
543
544         [Qt] embed checksums in PNGs written by Qt-DRT
545         https://bugs.webkit.org/show_bug.cgi?id=58173
546
547         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
548         (WebCore::DumpRenderTree::dump):
549
550 2011-04-12  Eric Seidel  <eric@webkit.org>
551
552         Reviewed by Adam Barth.
553
554         commit-queue should upload failure diffs when tests fail
555         https://bugs.webkit.org/show_bug.cgi?id=58348
556
557         This change was mostly just plumbing.  We were already saving
558         this information for flaky test reporting.  I just made it possible
559         for normal failures to report archives as well.
560
561         I did a little abstraction work to try and share some code between
562         flakytestreporter.py and this new code.  There is still more we could do.
563
564         In making this change I also went through and updated the various
565         places we have urls hard-coded in our python and pointed them at
566         common.config.urls.
567
568         * Scripts/webkitpy/common/checkout/scm.py:
569         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
570         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
571         * Scripts/webkitpy/common/net/statusserver.py:
572         * Scripts/webkitpy/layout_tests/port/base.py:
573         * Scripts/webkitpy/tool/bot/botinfo.py: Added.
574         * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
575         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
576         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
577         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
578         * Scripts/webkitpy/tool/commands/queues.py:
579
580 2011-04-12  Daniel Bates  <dbates@rim.com>
581
582         Rubber-stamped by Eric Seidel.
583
584         svn-apply and/or patch(1) has trouble applying patches that makes changes to files
585         with Windows line endings
586         https://bugs.webkit.org/show_bug.cgi?id=53625
587
588         Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
589         applied to an SCM checkout on a Windows file system and vice-versa.
590
591         This issue manifests itself due to custom SCM settings as well as differences in
592         gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
593         into svn-apply/unapply to compensate for differences in line endings by converting
594         the line endings in a patch to match the line endings in the target file (if it exists).
595
596         * Scripts/VCSUtils.pm:
597           - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
598             content read from the specified file handle. Obviously, this heuristic will not work
599             for files with mixed line endings, but I don't envision such files to be the norm. If
600             this turns out to be an issue then we can improve the heuristic.
601           - Added firstEOLInFile().
602           - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
603             In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
604             endings in the diff instead of the line endings in the target file.
605           - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
606             re-used in parseDiff().
607         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
608           to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
609           mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
610         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
611         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.
612
613 2011-04-12  Sam Weinig  <sam@webkit.org>
614
615         Reviewed by Adam Roben.
616
617         REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
618         https://bugs.webkit.org/show_bug.cgi?id=58336
619
620         * WebKitTestRunner/TestController.cpp:
621         (WTR::TestController::resetStateToConsistentValues):
622         Remove cache clearing as that is causing tests to crash on Windows 7.
623
624 2011-04-11  Sam Weinig  <sam@webkit.org>
625
626         Reviewed by Anders Carlsson.
627
628         REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
629         <rdar://problem/8981346>
630         https://bugs.webkit.org/show_bug.cgi?id=54159
631
632         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
633         (WTR::InjectedBundlePage::InjectedBundlePage):
634         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
635         (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
636         (WTR::InjectedBundlePage::decidePolicyForResponse):
637         (WTR::InjectedBundlePage::unableToImplementPolicy):
638         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
639         Add short-circuited policy client which matches WebKit1.
640
641         * WebKitTestRunner/TestController.cpp:
642         (WTR::TestController::resetStateToConsistentValues):
643         Clear the cache between tests to ensure consistent results.
644
645 2011-04-11  George Guo  <George.Guo@nokia.com>
646
647         Reviewed by Eric Seidel.
648
649         prepare-ChangeLog support email input but -h did not show the option
650         https://bugs.webkit.org/show_bug.cgi?id=58164
651
652         Add email option to -h to improve the usability
653
654         * Scripts/prepare-ChangeLog:
655
656 2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>
657
658         Reviewed by Eric Carlson.
659
660         Rename MediaControls to MediaControlRootElement.
661         https://bugs.webkit.org/show_bug.cgi?id=58250
662
663         * Scripts/do-webcore-rename: Documented the renaming.
664
665 2011-04-11  Sam Weinig  <sam@webkit.org>
666
667         Fix Windows build.
668
669         * MiniBrowser/win/BrowserView.cpp:
670         (BrowserView::create):
671
672 2011-04-11  Sam Weinig  <sam@webkit.org>
673
674         Reviewed by Anders Carlsson.
675
676         Move focus management out of WebKit via  the UIClient
677         <rdar://problem/8784068>
678         https://bugs.webkit.org/show_bug.cgi?id=58278
679
680         * MiniBrowser/mac/BrowserWindowController.m:
681         (-[BrowserWindowController awakeFromNib]):
682         * WebKitTestRunner/TestController.cpp:
683         (WTR::TestController::createOtherPage):
684         (WTR::TestController::initialize):
685         Add stubs for new UIClient functions.
686
687 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
688
689         Reviewed by Eric Seidel.
690
691         [GTK] The GTK+ DRT needs an implementation of the PlainTextController
692         https://bugs.webkit.org/show_bug.cgi?id=53605
693
694         Add an implementation of the PlainTextController for the GTK+ DRT.
695
696         * DumpRenderTree/gtk/DumpRenderTree.cpp:
697         (addControllerToWindow): Added this helper method.
698         (webViewWindowObjectCleared): Use the new helper to add EventSender
699         and the PlainTextController to the window object.
700         * GNUmakefile.am: Added PlainTextController source files.
701         * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
702         on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
703         until that functionality exists somewhere in the WebKitGTK+ stack.
704         * DumpRenderTree/gtk/PlainTextController.h: Added.
705
706 2011-04-11  Yael Aharon  <yael.aharon@nokia.com>
707
708         Unreviewed.
709
710         Adding my IRC nick.
711
712         * Scripts/webkitpy/common/config/committers.py:
713
714 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
715
716         Reviewed by Adam Roben.
717
718         new-run-webkit-tests: fix crash when running under windows cmd.exe
719         https://bugs.webkit.org/show_bug.cgi?id=58197
720
721         We would intermittently crash when running NRWT directly under
722         cmd.exe on windows because we were sharing the stdin file
723         descriptor between the python process and the http server.
724         cmd.exe really didn't like that, and there was no reason to
725         share the descriptor, so we now use a PIPE instead.
726
727         * Scripts/webkitpy/layout_tests/port/http_server.py:
728
729 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
730
731         Reviewed by Ojan Vafai.
732
733         new-run-webkit-tests: add unit tests for Port.diff_image()
734         https://bugs.webkit.org/show_bug.cgi?id=58196
735
736         Add the unit tests for the fix in bug 58195.
737
738         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
739         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
740         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
741
742 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
743
744         Reviewed by Tony Chang.
745
746         new-run-webkit-tests: implement support for audio, take two
747         https://bugs.webkit.org/show_bug.cgi?id=58195
748
749         Attempt to re-land the fix for bug 58101 (which was initially
750         landed in r83330, but rolled out). This is the same patch but
751         fixes crashes in Port.diff_image() caused by the change for
752         empty image files being None instead of ''.
753
754         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
755         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
756         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
757         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
758         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
759         * Scripts/webkitpy/layout_tests/port/base.py:
760         * Scripts/webkitpy/layout_tests/port/chromium.py:
761         * Scripts/webkitpy/layout_tests/port/dryrun.py:
762         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
763         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
764         * Scripts/webkitpy/layout_tests/port/test.py:
765         * Scripts/webkitpy/layout_tests/port/webkit.py:
766
767 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
768
769         Reviewed by Xan Lopez.
770
771         [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
772         https://bugs.webkit.org/show_bug.cgi?id=57854
773
774         Implement missing features in GTK's DRT.
775
776         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
777         (indexRangeInTable): New helper function to get the range string
778         for the current cell inside the parent table, either from the
779         point of view of rows or columns.
780         (AccessibilityUIElement::rowIndexRange): Implemented by relying on
781         the new helper function indexRangeInTable().
782         (AccessibilityUIElement::columnIndexRange): Ditto.
783
784 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
785
786         Reviewed by Chris Fleizach.
787
788         [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
789         https://bugs.webkit.org/show_bug.cgi?id=57826
790
791         Implement missing feature in GTK's DRT.
792
793         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
794         (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
795         relying on the analogous function from the AtkTable interface.
796
797 2011-04-05  Timothy Hatcher  <timothy@apple.com>
798
799         Fix the extract-localizable-strings script errors that started after
800         WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
801
802         * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
803
804 2011-04-11  Tony Chang  <tony@chromium.org>
805
806         Reviewed by Eric Seidel.
807
808         fix crc computation on 64 bit machines
809         https://bugs.webkit.org/show_bug.cgi?id=58243
810
811         unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
812
813         * DumpRenderTree/CyclicRedundancyCheck.cpp:
814         (makeCrcTable):
815         (computeCrc):
816         * DumpRenderTree/CyclicRedundancyCheck.h:
817         * DumpRenderTree/PixelDumpSupport.cpp:
818         (appendIntToVector):
819         (convertChecksumToPNGComment):
820
821 2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
822
823         Reviewed by Eric Seidel.
824
825         Require no undefined symbols during compilation.
826
827         [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
828         https://bugs.webkit.org/show_bug.cgi?id=54896
829
830         Add -Wl,--no-undefined to catch missing symbols early.
831
832         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
833         * WebKitTestRunner/qt/WebKitTestRunner.pro:
834
835 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
836
837         [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
838
839         * wx/build/settings.py:
840
841 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
842
843         [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
844
845         * wx/build/settings.py:
846
847 2011-04-10  David Levin  <levin@chromium.org>
848
849         Reviewed by Dimitri Glazkov.
850
851         REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
852         https://bugs.webkit.org/show_bug.cgi?id=58201
853
854         * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
855         and filed bug 58202.
856
857 2011-04-09  David Levin  <levin@chromium.org>
858
859         Unreviewed, rolling out r83394.
860         http://trac.webkit.org/changeset/83394
861         https://bugs.webkit.org/show_bug.cgi?id=53625
862
863         Patch was incorrect as noted in the bug.
864
865         * Scripts/svn-apply:
866
867 2011-04-09  David Levin  <levin@chromium.org>
868
869         Reviewed by Adam Barth.
870
871         svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
872         https://bugs.webkit.org/show_bug.cgi?id=53625
873
874         * Scripts/svn-apply: Ensure that the portions of patches
875         which are for vcproj/vsprops files has DOS line endings.
876
877 2011-04-09  Dirk Pranke  <dpranke@chromium.org>
878
879         Reviewed by Tony Chang.
880
881         It looks like NRWT has not been stopping DRT/TestShell
882         instances properly on windows, probably for a long time.
883         This would go a long way to explaining why we often have
884         processes lying around :)
885
886         https://bugs.webkit.org/show_bug.cgi?id=57807
887
888         * Scripts/webkitpy/layout_tests/port/chromium.py:
889         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
890
891 2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>
892
893         Reviewed by Laszlo Gombos.
894
895         [Qt] Don't link against fontconfig or X11 if embedded
896         https://bugs.webkit.org/show_bug.cgi?id=58104
897
898         * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
899         * QtTestBrowser/QtTestBrowser.pro: ditto
900         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
901         * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
902
903 2011-04-08  Jon Honeycutt  <jhoneycutt@apple.com>
904
905         http/tests/loading/preload-append-scan.php is failing on Windows
906         https://bugs.webkit.org/show_bug.cgi?id=58178
907
908         Reviewed by Brian Weinstein.
909
910         * DumpRenderTree/win/DumpRenderTree.cpp:
911         (lastPathComponent):
912         Use CFURL API to find the last path component, rather than
913         PathFindFileName(), because the latter will include the query string.
914
915 2011-04-08  Jian Li  <jianli@chromium.org>
916
917         Unreviewed, rolling out r83327, r83330 since these patches are very
918         likely to break chromium webkit mac10.6 builders.
919
920         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
921         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
922         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
923         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
924         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
925         * Scripts/webkitpy/layout_tests/port/base.py:
926         * Scripts/webkitpy/layout_tests/port/chromium.py:
927         * Scripts/webkitpy/layout_tests/port/dryrun.py:
928         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
929         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
930         * Scripts/webkitpy/layout_tests/port/test.py:
931         * Scripts/webkitpy/layout_tests/port/webkit.py:
932
933 2011-04-08  Vincent Scheib  <scheib@chromium.org>
934
935         Reviewed by Eric Seidel.
936
937         add chromium-gpu-linux-x86_64 to the recognized list of ports
938         https://bugs.webkit.org/show_bug.cgi?id=58099
939
940         Add chromium-gpu-linux-x86_64 to fix assert.
941
942         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
943
944 2011-04-08  Alpha Lam  <hclam@chromium.org>
945
946         Unreviewed, rolling out r83335.
947         http://trac.webkit.org/changeset/83335
948         https://bugs.webkit.org/show_bug.cgi?id=53556
949
950         GTK and QT bots are broken
951
952         * Scripts/build-webkit:
953
954 2011-04-07  Anna Cavender  <annacc@chromium.org>
955
956         Reviewed by Eric Carlson.
957
958         Setup ENABLE(TRACK) feature define
959         https://bugs.webkit.org/show_bug.cgi?id=53556
960
961         * Scripts/build-webkit:
962
963 2011-04-08  Dirk Pranke  <dpranke@chromium.org>
964
965         Reviewed by Adam Roben.
966
967         new-run-webkit-tests: configure a NRWT test bot for Mac SL
968         https://bugs.webkit.org/show_bug.cgi?id=58114
969
970         This change removes the old new-run-webkit-tests entry and
971         updates it for a new test-only bot.
972
973         * BuildSlaveSupport/build.webkit.org-config/config.json:
974
975 2011-04-08  Dominic Cooney  <dominicc@google.com>
976
977         Reviewed by Adam Roben.
978
979         Make layoutTestController.shadowRoot return null, not undefined,
980         when its argument is invalid.
981         https://bugs.webkit.org/show_bug.cgi?id=58121
982
983         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
984         (LayoutTestController::shadowRoot):
985         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
986         (WTR::LayoutTestController::shadowRoot):
987
988 2011-04-08  Pere Martir  <pere.martir4@gmail.com>
989
990         Reviewed by Adam Roben.
991
992         Locate NSTD.EXE in 64-bit Windows
993         https://bugs.webkit.org/show_bug.cgi?id=57847
994
995         * Scripts/old-run-webkit-tests:
996
997 2011-04-08  Adam Roben  <aroben@apple.com>
998
999         Qt build fix
1000
1001         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
1002
1003 2011-04-07  Adam Roben  <aroben@apple.com>
1004
1005         Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
1006
1007         Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
1008         plugin
1009
1010         Reviewed by Anders Carlsson.
1011
1012         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1013         (pluginLogWithArguments): Moved code to format and log the message here...
1014         (pluginLog): ...from here.
1015
1016         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
1017
1018         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1019         (PluginTest::log): Added. Calls through to pluginLogWithArguments.
1020
1021         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
1022
1023         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
1024         (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
1025         to begin.
1026         (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
1027         constructor.
1028         (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
1029         can be used to invoke our setWillBeDestroyed function.
1030         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
1031         anything unexpected happens).
1032         (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
1033         NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
1034         NPP_SetWindow was *not* called during destruction.
1035         (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
1036         method, setWillBeDestroyed.
1037         (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
1038         object.
1039
1040         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1041         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1042         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1043         * GNUmakefile.am:
1044         Added new test.
1045
1046         * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
1047         WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
1048
1049 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
1050
1051         Reviewed by Martin Robinson.
1052
1053         [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
1054         https://bugs.webkit.org/show_bug.cgi?id=58039
1055
1056         Implement missing functions in GTK's DRT.
1057
1058         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1059         (AccessibilityUIElement::increment): Implemented.
1060         (AccessibilityUIElement::decrement): Implemented.
1061
1062 2011-04-08  Dominic Cooney  <dominicc@google.com>
1063
1064         Reviewed by Kent Tamura.
1065
1066         Make WK2 layoutTestController.shadowRoot return undefined, not
1067         null, when its argument is not an element.
1068         https://bugs.webkit.org/show_bug.cgi?id=58121
1069
1070         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1071         (WTR::LayoutTestController::shadowRoot):
1072
1073 2011-04-07  Dirk Pranke  <dpranke@chromium.org>
1074
1075         Reviewed by Mihai Parparita.
1076
1077         Change reference port for Mac GPU baselines from
1078         Leopard to SnowLeopard, XP to Win7, and Linux-x86
1079         to Linux x86-64.
1080
1081         https://bugs.webkit.org/show_bug.cgi?id=58099
1082
1083         * Scripts/webkitpy/layout_tests/port/chromium.py:
1084
1085 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
1086
1087         Revert ENABLE_TRACK patch due to compile failures.
1088
1089         * Scripts/build-webkit:
1090
1091 2011-04-07  Tony Chang  <tony@chromium.org>
1092
1093         Reviewed by Eric Seidel.
1094
1095         update DRT to embed checksums in png files
1096         https://bugs.webkit.org/show_bug.cgi?id=57871
1097
1098         We insert the bytes for the comment in printPNG rather than at encode
1099         time because each platform does its own PNG encoding (either using CG
1100         or cairo).  Putting this in pringPNG avoids having to duplicate this
1101         code, although it's not as clean as doing it at encoding time.
1102
1103         We insert the comment right after the IHDR chunk of the PNG.
1104
1105         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1106         * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
1107         (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
1108         (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
1109         * DumpRenderTree/CyclicRedundancyCheck.h: Added.
1110         * DumpRenderTree/PixelDumpSupport.cpp:
1111         (dumpWebViewAsPixelsAndCompareWithExpected):
1112         (convertChecksumToPNGComment): Generate the bytes to insert.
1113         (printPNG): Insert the png comment before the first IDAT section.
1114         * DumpRenderTree/PixelDumpSupport.h:
1115         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
1116         (printPNG):
1117         (dumpBitmap):
1118         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1119         (printPNG):
1120         (dumpBitmap):
1121         * DumpRenderTree/win/DumpRenderTree.vcproj:
1122         * GNUmakefile.am:
1123
1124 2011-04-07  Jeff Miller  <jeffm@apple.com>
1125
1126         Reviewed by Adam Roben.
1127
1128         Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
1129         https://bugs.webkit.org/show_bug.cgi?id=58058
1130
1131         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
1132         (TestWebKitAPI::TEST): Add tests for  WKStringGetLength() and WKStringGetCharactersPtr().
1133
1134 2011-04-07  Chang Shu  <cshu@webkit.org>
1135
1136         Reviewed by Darin Adler.
1137
1138         WebKitTestRunner needs layoutTestController.isPageBoxVisible
1139         https://bugs.webkit.org/show_bug.cgi?id=42695
1140
1141         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1142         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1143         (WTR::LayoutTestController::isPageBoxVisible):
1144         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1145
1146 2011-04-07  Adam Roben  <aroben@apple.com>
1147
1148         Build fix
1149
1150         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
1151
1152 2011-04-07  Adam Roben  <aroben@apple.com>
1153
1154         Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
1155
1156         commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
1157         (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
1158         hook we have, so we have to do our work there. I added a new addCustomURLs method which can
1159         be overridden by subclasses to provide extra URLs before we call up to the base class (after
1160         which adding more URLs is no longer possible).
1161
1162         Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
1163         bot results page
1164
1165         Reviewed by John Sullivan.
1166
1167         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1168         (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
1169         (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
1170         method is never called for MasterShellCommands.
1171         (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
1172         with this method (which is).
1173
1174 2011-04-07  Adam Roben  <aroben@apple.com>
1175
1176         Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
1177
1178         This matches how most of our other build steps work, so is good just for improving
1179         consistency between build steps. It should also make it possible for
1180         ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
1181         trying to do this in finished() after we had called up to the base class, but that was
1182         apparently too late to add more URLs.)
1183
1184         Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
1185         results page
1186
1187         Reviewed by John Sullivan.
1188
1189         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1190         (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
1191         call setText to get the right text to show up for this step. This matches how most of our
1192         other build steps work.
1193         (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
1194         This is how most of our other build steps work.
1195         (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
1196         function, to match the base class.
1197
1198 2011-04-07  Adam Barth  <abarth@webkit.org>
1199
1200         Reviewed by Maciej Stachowiak.
1201
1202         webkit-patch shouldn't state the whole working copy when calling check-webkit-style
1203         https://bugs.webkit.org/show_bug.cgi?id=58022
1204
1205         Previously, we were ignoring the args variable!  This patch fixes the
1206         regression introduced in http://trac.webkit.org/changeset/82771.
1207
1208         * Scripts/webkitpy/tool/commands/download_unittest.py:
1209         * Scripts/webkitpy/tool/mocktool.py:
1210         * Scripts/webkitpy/tool/steps/checkstyle.py:
1211
1212 2011-04-07  Maciej Stachowiak  <mjs@apple.com>
1213
1214         Reviewed by Adam Barth.
1215
1216         REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
1217         https://bugs.webkit.org/show_bug.cgi?id=58017
1218
1219         * Scripts/webkitpy/common/checkout/scm.py:
1220         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1221
1222 2011-04-06  Chang Shu  <cshu@webkit.org>
1223
1224         Reviewed by Darin Adler.
1225
1226         WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
1227         https://bugs.webkit.org/show_bug.cgi?id=57984
1228
1229         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1230         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1231         (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
1232         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1233
1234 2011-04-06  Chris Rogers  <crogers@google.com>
1235
1236         Reviewed by Tony Chang.
1237
1238         Add web audio support to DumpRenderTree (mac port)
1239         https://bugs.webkit.org/show_bug.cgi?id=57969
1240
1241         * DumpRenderTree/LayoutTestController.cpp:
1242         (LayoutTestController::LayoutTestController):
1243         (setEncodedAudioDataCallback):
1244         (LayoutTestController::staticFunctions):
1245         * DumpRenderTree/LayoutTestController.h:
1246         (LayoutTestController::dumpAsAudio):
1247         (LayoutTestController::setDumpAsAudio):
1248         (LayoutTestController::encodedAudioData):
1249         (LayoutTestController::setEncodedAudioData):
1250         * DumpRenderTree/mac/DumpRenderTree.mm:
1251         (dumpAudio):
1252         (dump):
1253
1254 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
1255
1256         Reviewed by Kenneth Rohde Christiansen.
1257
1258         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
1259         https://bugs.webkit.org/show_bug.cgi?id=56086
1260
1261         Add the missing method.
1262
1263         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1264         (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
1265         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1266         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1267         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1268
1269 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
1270
1271         Reviewed by David Levin.
1272
1273         Add QUOTA build flag for unified quota API
1274         https://bugs.webkit.org/show_bug.cgi?id=57918
1275
1276         * Scripts/build-webkit: Added QUOTA build flag
1277
1278 2011-04-06  Dirk Pranke  <dpranke@chromium.org>
1279
1280         Reviewed by Tony Chang.
1281
1282         Adjust the apple webkit port's default timeout to match
1283         old-run-webkit-tests at 35 seconds.
1284
1285         https://bugs.webkit.org/show_bug.cgi?id=37738
1286
1287         * Scripts/webkitpy/layout_tests/port/mac.py:
1288
1289 2011-04-06  Scott Cameron  <sccameron@rim.com>
1290
1291         Reviewed by Eric Seidel.
1292
1293         Remove global variable $httpdPath and replace with the return value of
1294         getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
1295         https://bugs.webkit.org/show_bug.cgi?id=53499
1296
1297         * Scripts/run-iexploder-tests:
1298         * Scripts/webkitperl/httpd.pm:
1299
1300 2011-04-06  Kevin Ollivier  <kevino@theolliviers.com>
1301
1302         Reviewed by Darin Adler.
1303
1304         Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
1305         
1306         https://bugs.webkit.org/show_bug.cgi?id=27551
1307         
1308         * DumpRenderTree/config.h:
1309         * WebKitAPITest/config.h:
1310         * WebKitTestRunner/config.h:
1311
1312 2011-04-06  Tony Chang  <tony@chromium.org>
1313
1314         Reviewed by Darin Adler.
1315
1316         teach run-webkit-tests to read checksums from png files
1317         https://bugs.webkit.org/show_bug.cgi?id=57993
1318
1319         * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
1320           no .checksum and look for the checksum in there.
1321
1322 2011-04-06  David Dorwin  <ddorwin@chromium.org>
1323
1324         Reviewed by David Levin.
1325
1326         Enable fullscreen layout tests for Chromium
1327         https://bugs.webkit.org/show_bug.cgi?id=55726
1328
1329         Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
1330
1331         * DumpRenderTree/chromium/WebPreferences.cpp:
1332         (WebPreferences::applyTo):
1333
1334 2011-04-06  Adam Roben  <aroben@apple.com>
1335
1336         Add a "view leaks" link to builds on SnowLeopard Intel Leaks
1337
1338         Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
1339
1340         Reviewed by David Kilzer.
1341
1342         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1343         (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
1344         build's results directory here...
1345         (ExtractTestResults.finished): ...from here.
1346         (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
1347         (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
1348         leaks" link to point to Leaks Viewer for this build.
1349         (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
1350         but it seemed good to add for consistency with BuildAndTestFactory.
1351         (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
1352         (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
1353         that we'll get a "view leaks" link.
1354
1355 2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
1356
1357         Reviewed by Eric Seidel.
1358
1359         [Gtk] plugins/set-status.html fails
1360         https://bugs.webkit.org/show_bug.cgi?id=57844
1361
1362         Allow an empty status text to be dumped.
1363
1364         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1365         (webViewStatusBarTextChanged):
1366
1367 2011-04-06  Chang Shu  <cshu@webkit.org>
1368
1369         Reviewed by Darin Adler.
1370
1371         WebKitTestRunner needs layoutTestController.pageNumberForElementById
1372         https://bugs.webkit.org/show_bug.cgi?id=42329
1373
1374         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1375         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1376         (WTR::LayoutTestController::pageNumberForElementById):
1377         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1378
1379 2011-04-06  Sergio Villar Senin  <svillar@igalia.com>
1380
1381         Reviewed by Martin Robinson.
1382
1383         [GTK] DumpRenderTree: do not try to free NULL SoupURIs
1384         https://bugs.webkit.org/show_bug.cgi?id=57932
1385
1386         Some Layout tests have invalid URIs that do not generate valid
1387         SoupURI instances. Do not try to free those NULL SoupURIs.
1388
1389         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1390         (willSendRequestCallback):
1391
1392 2011-04-06  Csaba Osztrogonác  <ossy@webkit.org>
1393
1394         Reviewed by Andreas Kling.
1395
1396         ORWT shouldn't generate diff files for tests without expected files
1397         https://bugs.webkit.org/show_bug.cgi?id=57846
1398
1399         * Scripts/old-run-webkit-tests:
1400
1401 2011-04-05  Kevin Ollivier  <kevino@theolliviers.com>
1402
1403         [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
1404         to deps.
1405
1406         * wx/install-unix-extras:
1407
1408 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1409
1410         Unreviewed, rolling out r82978, r82999, and r83001.
1411         http://trac.webkit.org/changeset/82978
1412         http://trac.webkit.org/changeset/82999
1413         http://trac.webkit.org/changeset/83001
1414         https://bugs.webkit.org/show_bug.cgi?id=57913
1415
1416         Does not work in Python 2.5 (Requested by abarth on #webkit).
1417
1418         * Scripts/webkitpy/common/system/executive.py:
1419         * Scripts/webkitpy/common/system/executive_unittest.py:
1420
1421 2011-04-05  Chang Shu  <cshu@webkit.org>
1422
1423         Reviewed by Darin Adler.
1424
1425         WebKitTestRunner needs layoutTestController.numberOfPages
1426         https://bugs.webkit.org/show_bug.cgi?id=42694
1427
1428         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1429         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1430         (WTR::LayoutTestController::numberOfPages):
1431         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1432
1433 2011-04-05  Tony Chang  <tony@chromium.org>
1434
1435         Reviewed by Mihai Parparita.
1436
1437         [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
1438         https://bugs.webkit.org/show_bug.cgi?id=57889
1439
1440         * Scripts/webkitpy/layout_tests/port/chromium.py:
1441         * Scripts/webkitpy/layout_tests/port/test.py:
1442         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1443
1444 2011-04-05  Adam Barth  <abarth@webkit.org>
1445
1446         Silly with statement, from the future!
1447
1448         * Scripts/webkitpy/common/system/executive.py:
1449
1450 2011-04-05  Adam Barth  <abarth@webkit.org>
1451
1452         Reviewed by Tony Chang.
1453
1454         Don't use Exception.message because it's deprecated
1455         https://bugs.webkit.org/show_bug.cgi?id=57892
1456
1457         Suppress the warning for now.  When we move to Python 3, we might need
1458         to something more dramatic.
1459
1460         * Scripts/webkitpy/common/system/executive.py:
1461
1462 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
1463
1464         Reviewed by Ojan Vafai.
1465
1466         Add builders.js to dashboard file list
1467         https://bugs.webkit.org/show_bug.cgi?id=57899
1468
1469         Add file added by http://crrev.com/80538 to dashboard file list.
1470
1471         * TestResultServer/handlers/dashboardhandler.py:
1472
1473 2011-04-05  MORITA Hajime  <morrita@google.com>
1474
1475         Reviewed by Adam Barth.
1476
1477         webkit-patch should print git's stderr when git svn dcommit fail
1478         http://webkit.org/b/57861
1479
1480         * Scripts/webkitpy/common/checkout/scm.py:
1481
1482 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
1483
1484         Reviewed by Tony Chang.
1485
1486         Add --baseline-search-path to NRWT
1487         https://bugs.webkit.org/show_bug.cgi?id=56233
1488         
1489         Add NRWT option to specify additional directories to look for baselines
1490         (will be used by hardware GPU bots which will have local per-bot
1491         expectations for some tests)
1492
1493         * Scripts/webkitpy/common/system/filesystem_mock.py:
1494         * Scripts/webkitpy/layout_tests/port/base.py:
1495         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1496         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1497
1498 2011-04-05  Adam Roben  <aroben@apple.com>
1499
1500         Strip off /results.html from results URLs before trying to load leaks files from them
1501
1502         r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
1503         files, rather than pointing to the directory that contains them. This is more convenient for
1504         people browsing build.webkit.org, but confused Leaks Viewer.
1505
1506         Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
1507         list don't work
1508
1509         Reviewed by Joseph Pecoraro.
1510
1511         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1512         (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
1513
1514 2011-04-05  Carol Szabo  <carol@webkit.org>
1515
1516         Unreviewed.
1517
1518         Updated my info in committers.py
1519
1520         Scripts\webkitpy\common\config\committers.py 
1521
1522 2011-04-05  Csaba Osztrogonác  <ossy@webkit.org>
1523
1524         Reviewed by Laszlo Gombos.
1525
1526         [Qt] Make WebKitLibraries optional for building QtWebKit
1527         https://bugs.webkit.org/show_bug.cgi?id=57542
1528
1529         * Scripts/build-webkit:
1530
1531 2011-04-05  Chang Shu  <cshu@webkit.org>
1532
1533         Reviewed by Laszlo Gombos.
1534
1535         [Qt] MiniBrowser defaultUrl does not work
1536         https://bugs.webkit.org/show_bug.cgi?id=57021
1537
1538         Match the behavior and coding of MiniBrowser to QtTestBrowser.
1539         * MiniBrowser/qt/main.cpp:
1540         (main):
1541
1542 2011-04-05  Jade Han  <jade.han@nokia.com>
1543
1544         Reviewed by Laszlo Gombos.
1545
1546         [Qt] [Symbian] Disable WebKitTestRunner for Symbian
1547         https://bugs.webkit.org/show_bug.cgi?id=54977
1548
1549         This change is a preparation to enable building webkit2 for Symbian.
1550         Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
1551
1552         * Tools.pro:
1553
1554 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1555
1556         Reviewed by Andreas Kling.
1557
1558         [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
1559         https://bugs.webkit.org/show_bug.cgi?id=57832
1560
1561         Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
1562
1563         * MiniBrowser/qt/UrlLoader.cpp:
1564         (UrlLoader::UrlLoader):
1565
1566 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1567
1568         [Qt] Linux Release minimal build fix after r82919.
1569
1570         * MiniBrowser/qt/BrowserWindow.cpp:
1571         (BrowserWindow::loadURLListFromFile):
1572         * QtTestBrowser/launcherwindow.cpp:
1573         (LauncherWindow::loadURLListFromFile):
1574
1575 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
1576
1577         Reviewed by Andreas Kling.
1578
1579         [Qt] Make URL loader accessible from testbrowser's menus
1580         https://bugs.webkit.org/show_bug.cgi?id=57823
1581
1582         Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
1583
1584         * MiniBrowser/qt/BrowserWindow.cpp:
1585         (BrowserWindow::BrowserWindow):
1586         (BrowserWindow::loadURLListFromFile):
1587         (BrowserWindow::~BrowserWindow):
1588         * MiniBrowser/qt/BrowserWindow.h:
1589         * QtTestBrowser/launcherwindow.cpp:
1590         (LauncherWindow::LauncherWindow):
1591         (LauncherWindow::~LauncherWindow):
1592         (LauncherWindow::createChrome):
1593         (LauncherWindow::loadURLListFromFile):
1594         * QtTestBrowser/launcherwindow.h:
1595
1596 2011-04-04  Sam Weinig  <sam@webkit.org>
1597
1598         Reviewed by Brian Weinstein.
1599
1600         Remove duplicate API from WKContext
1601         <rdar://problem/8727879>
1602         https://bugs.webkit.org/show_bug.cgi?id=57815
1603
1604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1605         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
1606         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1607         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
1608
1609 2011-04-04  Tony Chang  <tony@chromium.org>
1610
1611         Reviewed by Ojan Vafai.
1612
1613         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
1614         https://bugs.webkit.org/show_bug.cgi?id=57783
1615
1616         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1617         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1618
1619 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
1620
1621         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
1622         from WebKitBuild.
1623
1624         * Scripts/webkitdirs.pm:
1625
1626 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
1627
1628         Reviewed by Gustavo Noronha Silva.
1629
1630         [GTK] WebGL support
1631         https://bugs.webkit.org/show_bug.cgi?id=31517
1632
1633         Add support to the DRT for turning on WebGL when a layout tests requests it.
1634
1635         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1636         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
1637
1638 2011-04-04  Chang Shu  <cshu@webkit.org>
1639
1640         Reviewed by Darin Adler.
1641
1642         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
1643         https://bugs.webkit.org/show_bug.cgi?id=57572
1644
1645         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1646         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1647         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
1648         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1649
1650 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
1651
1652         Reviewed by Csaba Osztrogonác.
1653
1654         [Qt] DumpRenderTree breaks compilation in some uClibc environments
1655         https://bugs.webkit.org/show_bug.cgi?id=57602
1656
1657         * DumpRenderTree/qt/main.cpp:
1658         (get_backtrace):
1659
1660 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
1661
1662         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
1663
1664         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1665         (LayoutTestController::shadowRoot):
1666
1667 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
1668
1669         Unreviewed, fix exception in rebaseline tool.
1670
1671         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1672
1673 2011-04-02  Beth Dakin  <bdakin@apple.com>
1674
1675         Rubber-stamped by Geoff Garen.
1676
1677         For Dan!
1678         * DumpRenderTree/mac/DumpRenderTree.mm:
1679         (resetWebViewToConsistentStateBeforeTesting):
1680
1681 2011-04-02  Beth Dakin  <bdakin@apple.com>
1682
1683         Rubber-stamped by Geoff Garen.
1684
1685         Need to reset the scale, much like zoom.
1686         * DumpRenderTree/mac/DumpRenderTree.mm:
1687         (resetWebViewToConsistentStateBeforeTesting):
1688
1689 2011-04-02  Sam Weinig  <sam@webkit.org>
1690
1691         Reviewed by Beth Dakin.
1692
1693         https://bugs.webkit.org/show_bug.cgi?id=57605
1694         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
1695         getClientRects()
1696         -and corresponding-
1697         <rdar://problem/9194541>
1698
1699         Add DRT support for the scaleWebView SPI.
1700         * DumpRenderTree/mac/EventSendingController.mm:
1701         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1702         (+[EventSendingController webScriptNameForSelector:]):
1703         (-[EventSendingController scalePageBy:atX:andY:]):
1704         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1705         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1706         (WTR::EventSendingController::scalePageBy):
1707         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1708         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1709         (WTR::InjectedBundlePage::reset):
1710
1711 2011-04-02  Dominic Cooney  <dominicc@google.com>
1712
1713         Reviewed by Martin Robinson.
1714
1715         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1716         https://bugs.webkit.org/show_bug.cgi?id=57551
1717
1718         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1719         (LayoutTestController::shadowRoot):
1720
1721 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
1722
1723         Reviewed by Eric Seidel.
1724
1725         Remove AbstractStep._run_script and move script names to ports.py
1726         https://bugs.webkit.org/show_bug.cgi?id=57704
1727
1728         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
1729
1730         * Scripts/webkitpy/common/config/ports.py:
1731         * Scripts/webkitpy/tool/commands/download_unittest.py:
1732         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1733         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1734         * Scripts/webkitpy/tool/steps/abstractstep.py:
1735         * Scripts/webkitpy/tool/steps/checkstyle.py:
1736         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1737         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1738         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1739
1740 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
1741
1742         Reviewed by Eric Seidel.
1743
1744         Emulate shebang on Win32
1745         https://bugs.webkit.org/show_bug.cgi?id=55927
1746
1747         Scripts on Windows work only if they are called with the explicit interpreter.
1748         Read the first line of scripts to detect the correct executable.
1749
1750         * Scripts/webkitpy/common/config/ports.py:
1751         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
1752         * Scripts/webkitpy/common/system/executive_unittest.py:
1753
1754 2011-04-01  Adam Barth  <abarth@webkit.org>
1755
1756         Reviewed by Eric Seidel.
1757
1758         apos entities shouldn't show up in ChangeLogs when using webkit-patch
1759         https://bugs.webkit.org/show_bug.cgi?id=57692
1760
1761         Previously, we were using BeautifulSoup to process XML from
1762         bugs.webkit.org, but that's incorrect.  We should be using
1763         BeautifulStoneSoup to process the XML.  We were getting the &apos;
1764         entity wrong because &apos; is an XML entity but not an HTML entity.
1765
1766         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1767         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1768
1769 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1770
1771         Unreviewed, rolling out r82721.
1772         http://trac.webkit.org/changeset/82721
1773         https://bugs.webkit.org/show_bug.cgi?id=57687
1774
1775         This patch introduced assertion failures on the GTK+ bots.
1776         (Requested by mrobinson on #webkit).
1777
1778         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1779         (LayoutTestController::shadowRoot):
1780
1781 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
1782
1783         Unreviewed buildfix.
1784
1785         [Qt][WK2] Build Webkit2 using "-2" option on Qt
1786         https://bugs.webkit.org/show_bug.cgi?id=55074
1787
1788         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
1789         (The isWK2() function removes it from @ARGV, but not from @options.)
1790
1791 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
1792
1793         Reviewed by Csaba Osztrogonác.
1794
1795         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
1796         https://bugs.webkit.org/show_bug.cgi?id=57666
1797
1798         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
1799
1800 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1801
1802         Reviewed by Adam Barth.
1803
1804         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
1805
1806         We apparently never implemented the code to skip tests based on
1807         what was compiled into DRT. Also, change the logic used to skip
1808         platform directories to match what old-run-webkit-tests does: 
1809         skip every test not in a directory in the baseline search path.
1810
1811         https://bugs.webkit.org/show_bug.cgi?id=57662
1812
1813         * Scripts/webkitpy/layout_tests/port/mac.py:
1814         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1815         * Scripts/webkitpy/layout_tests/port/webkit.py:
1816
1817 2011-03-29  Mark Rowe  <mrowe@apple.com>
1818
1819         Reviewed by Jon Honeycutt.
1820
1821         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
1822
1823         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
1824
1825         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1826         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1827         * Scripts/webkitpy/layout_tests/port/mac.py:
1828         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1829
1830 2011-04-01  Chang Shu  <cshu@webkit.org>
1831
1832         Reviewed by Csaba Osztrogonác.
1833
1834         [Qt][WK2] Build Webkit2 using "-2" option on Qt
1835         https://bugs.webkit.org/show_bug.cgi?id=55074
1836
1837         * Scripts/build-webkit:
1838
1839 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1840
1841         Reviewed by Tony Chang.
1842
1843         new-run-webkit-tests: remove spurious port version override in webkit.py
1844         base.py provides a default implementation so this is just
1845         breaking things.
1846
1847         https://bugs.webkit.org/show_bug.cgi?id=57667
1848
1849         * Scripts/webkitpy/layout_tests/port/webkit.py:
1850         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1851
1852 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
1853
1854         Reviewed by Adam Roben.
1855
1856         Make view results on waterfall direct link to results.html
1857         https://bugs.webkit.org/show_bug.cgi?id=57671
1858
1859         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
1860         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
1861
1862 2011-04-01  Sam Weinig  <sam@webkit.org>
1863
1864         Fix windows build.
1865
1866         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
1867         (TestWebKitAPI::TEST):
1868         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1869         (TestWebKitAPI::flushMessages):
1870
1871 2011-04-01  Sam Weinig  <sam@webkit.org>
1872
1873         Reviewed by Adam Roben.
1874
1875         Add adoptWK to WKRetainPtr.h
1876         https://bugs.webkit.org/show_bug.cgi?id=57670
1877
1878         * TestWebKitAPI/PlatformUtilities.h:
1879         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1880         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1881         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1882         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1883         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1884         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1885         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1886         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1887         (TestWebKitAPI::createSessionStateContainingFormData):
1888         * WebKitTestRunner/StringFunctions.h:
1889         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
1890
1891 2011-04-01  Sam Weinig  <sam@webkit.org>
1892
1893         Reviewed by Adam Roben.
1894
1895         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
1896
1897         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1898         (WTR::LayoutTestController::shadowRoot):
1899         Make judicious use of adoptWK().
1900
1901 2011-04-01  Sam Weinig  <sam@webkit.org>
1902
1903         Reviewed by Timothy Hatcher.
1904
1905         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
1906
1907         * Scripts/extract-localizable-strings:
1908
1909 2011-04-01  Anders Carlsson  <andersca@apple.com>
1910
1911         Reviewed by Sam Weinig.
1912
1913         Shockwave plug-in doesn't accept mouse events
1914         https://bugs.webkit.org/show_bug.cgi?id=57653
1915         <rdar://problem/8483273>
1916
1917         Add a plug-in test.
1918
1919         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1920         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1921         (PluginTest::indicateTestFailure):
1922         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
1923
1924         (PluginTest::NPN_ConvertPoint):
1925         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1926         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1927         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1928         Call indicateTestFailure.
1929
1930         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
1931         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
1932         (ConvertPoint::ConvertPoint):
1933         (ConvertPoint::testConvert):
1934         (ConvertPoint::NPP_New):
1935
1936 2011-04-01  Dominic Cooney  <dominicc@google.com>
1937
1938         Reviewed by Martin Robinson.
1939
1940         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1941         https://bugs.webkit.org/show_bug.cgi?id=57551
1942
1943         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1944         (LayoutTestController::shadowRoot):
1945
1946 2011-04-01  Sam Weinig  <sam@webkit.org>
1947
1948         Reviewed by Anders Carlsson.
1949
1950         WebKitTestRunner needs layoutTestController.shadowRoot
1951         https://bugs.webkit.org/show_bug.cgi?id=57661
1952
1953         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1954         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1955         (WTR::LayoutTestController::shadowRoot):
1956         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1957         Implement layoutTestController.shadowRoot for WebKit2.
1958
1959 2011-04-01  Chang Shu  <cshu@webkit.org>
1960
1961         Reviewed by Darin Adler.
1962
1963         WebKitTestRunner needs layoutTestController.setDatabaseQuota
1964         https://bugs.webkit.org/show_bug.cgi?id=57568
1965
1966         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1967         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1968         (WTR::LayoutTestController::setDatabaseQuota):
1969         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1970
1971 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1972
1973         Reviewed by Tony Chang.
1974
1975         This patch completes the cleanup of
1976         rebaseline-chromium-webkit-tests to work with all of the
1977         variants of a platform (we can now rebaseline gpu- and non-gpu
1978         files at the same time).
1979
1980         When the rebaselining is complete, any lines declared as
1981         REBASELINE in the expectations file that matches a test that was
1982         actually rebaselined will be deleted, even if only one of the
1983         variants was actually rebaselined. This may cause odd problems,
1984         but is better than where we're at today.
1985
1986         This change removes the -g flag and deprecates -w. The -g flag is gone
1987         because GPU baselines are handled just like any other variant.
1988         The -w flag is deprecated because this tool now only works
1989         against the canaries, since that's the only place we have a full
1990         set of bots. It will be trivial to change this to
1991         build.webkit.org if we decide that's where we want them to be.
1992
1993         Also, this patch deletes a lot of cruft that is no longer needed
1994         in the test_expectations code and the port-specific code.
1995
1996         https://bugs.webkit.org/show_bug.cgi?id=55191
1997
1998         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1999         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2000         * Scripts/webkitpy/layout_tests/port/base.py:
2001         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2002         * Scripts/webkitpy/layout_tests/port/chromium.py:
2003         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2004         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2005         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2006         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2007         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2008         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2009         * Scripts/webkitpy/layout_tests/port/mac.py:
2010         * Scripts/webkitpy/layout_tests/port/test.py:
2011         * Scripts/webkitpy/layout_tests/port/webkit.py:
2012         * Scripts/webkitpy/layout_tests/port/win.py:
2013         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2014         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2015
2016 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
2017
2018         Reviewed by Adam Barth.
2019
2020         rebaseline-chromium-webkit-tests does not work correctly with
2021         version-specific baselines. This patch updates the tool to use
2022         all of the version-specific bots on the canaries, and will now
2023         attempt to rebaseline all of the versions by default, although
2024         it will not update both GPU and CPU versions.
2025         
2026         Also, it will no longer modify the test_expectations.txt file
2027         *at all*. You will have to manually delete the REBASELINE lines
2028         after running the tool and determining that it did what you
2029         wanted it to do. This should be fixed in a separate bug - see
2030         webkit bug #55191.
2031
2032         https://bugs.webkit.org/show_bug.cgi?id=55608
2033
2034         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2035         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2036         * Scripts/webkitpy/layout_tests/port/chromium.py:
2037         * Scripts/webkitpy/layout_tests/port/test.py:
2038         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2039         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2040
2041 2011-03-31  Tony Chang  <tony@chromium.org>
2042
2043         Reviewed by Ojan Vafai.
2044
2045         [chromium] update the rebaseline tool to know about pngs with checksums
2046         https://bugs.webkit.org/show_bug.cgi?id=57481
2047
2048         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
2049         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2050
2051 2011-04-01  Adam Roben  <aroben@apple.com>
2052
2053         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
2054
2055         Previously, we were getting the revision of the first revision that triggered a build.
2056         Choosing the last revision would have been more accurate. But got_revision is what is used
2057         everywhere else on build.webkit.org, and should work even when there were no changes that
2058         triggered a build (e.g., if someone clicked the Force Build button).
2059
2060         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
2061         recent builds list
2062
2063         Reviewed by Anders Carlsson.
2064
2065         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2066         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
2067         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
2068
2069         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
2070         (Array.prototype.first): Added this helper function to return the first element in an array
2071         that matches the given predicate, or null if no such element exists.
2072
2073 2011-03-31  Adam Roben  <aroben@apple.com>
2074
2075         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
2076
2077         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
2078
2079         Reviewed by Darin Adler.
2080
2081         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2082         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
2083         URL on its own line.
2084
2085         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2086         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
2087         progression, and added a new test that uses a short bug URL while I was at it.
2088
2089 2011-04-01  Adam Roben  <aroben@apple.com>
2090
2091         Mark .vcproj/.vsprops/.sln files as being Windows-only
2092
2093         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
2094
2095         Reviewed by Anders Carlsson.
2096
2097         * Scripts/webkitpy/common/config/build.py:
2098         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
2099         directories as Windows-only.
2100
2101         * Scripts/webkitpy/common/config/build_unittest.py:
2102         (ShoulBuildTest): Added test cases for the above.
2103
2104 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
2105
2106         Reviewed by Laszlo Gombos.
2107
2108         [Qt] Build MiniBrowser for Symbian
2109         https://bugs.webkit.org/show_bug.cgi?id=56319
2110
2111         Have MiniBrowser reference it's own copy of useragentlist.txt instead
2112         of copying QtTestBrowser's.
2113         Remove Tools/MiniBrowser/DerivedSources.pro
2114         This reduces complexity in the Tools scripts due to Symbian limitations.
2115
2116         * DerivedSources.pro:
2117         * MiniBrowser/DerivedSources.pro: Removed.
2118         * MiniBrowser/MiniBrowser.qrc:
2119         * MiniBrowser/qt/MiniBrowser.pro:
2120         * Scripts/webkitdirs.pm:
2121
2122 2011-03-31  Chang Shu  <cshu@webkit.org>
2123
2124         Reviewed by Darin Adler.
2125
2126         WebKitTestRunner needs layoutTestController.clearAllDatabases
2127         https://bugs.webkit.org/show_bug.cgi?id=42540
2128
2129         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2130         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2131         (WTR::InjectedBundle::beginTesting):
2132         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2133         (WTR::LayoutTestController::clearAllDatabases):
2134         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2135
2136 2011-03-31  Chang Shu  <cshu@webkit.org>
2137
2138         Reviewed by Darin Adler.
2139
2140         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
2141         https://bugs.webkit.org/show_bug.cgi?id=42692
2142
2143         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2144
2145 2011-03-31  Darin Adler  <darin@apple.com>
2146
2147         Reviewed by Sam Weinig.
2148
2149         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
2150         https://bugs.webkit.org/show_bug.cgi?id=57573
2151
2152         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2153         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
2154         Removed fake definitions of keyDown and contextClick.
2155
2156         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2157         (WTR::operator==): Added. So we can compare two WKPoint structs.
2158         (WTR::parseModifier): Added.
2159         (WTR::parseModifierArray): Added.
2160         (WTR::EventSendingController::EventSendingController): Initialize the
2161         new data members.
2162         (WTR::EventSendingController::mouseDown): Added. Calls
2163         WKBundlePageSimulateMouseDown.
2164         (WTR::EventSendingController::mouseUp): Added. Calls
2165         WKBundlePageSimulateMouseUp.
2166         (WTR::EventSendingController::mouseMoveTo): Added. Calls
2167         WKBundlePageSimulateMouseMotion.
2168         (WTR::EventSendingController::leapForward): Added.
2169         (WTR::EventSendingController::updateClickCount): Added. Used by the
2170         mouseDown/Up functions to create a click count.
2171
2172         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
2173         for the changes above.
2174
2175 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
2176
2177         Reviewed by Martin Robinson.
2178
2179         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
2180         https://bugs.webkit.org/show_bug.cgi?id=57362
2181
2182         Do not generate DRT output if willSendRequestReturnsNull is set.
2183
2184         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2185         (willSendRequestCallback):
2186
2187 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
2188
2189         Reviewed by Martin Robinson.
2190
2191         Implement MiniBrowser for Gtk port.
2192         https://bugs.webkit.org/show_bug.cgi?id=48512
2193
2194         Initial implementation of the Gtk MiniBrowser.
2195
2196         * MiniBrowser/gtk/GNUmakefile.am: Added.
2197         * MiniBrowser/gtk/main.c: Added.
2198         (activateUriEntryCallback):
2199         (destroyCallback):
2200         (goBackCallback):
2201         (goForwardCallback):
2202         (createToolbar):
2203         (createWebView):
2204         (createWindow):
2205         (argumentToURL):
2206         (main):
2207
2208 2011-03-30  Dominic Cooney  <dominicc@google.com>
2209
2210         Reviewed by Dimitri Glazkov.
2211
2212         Adds layoutTestController.shadowRoot accessor to Mac DRT.
2213         https://bugs.webkit.org/show_bug.cgi?id=57415
2214
2215         * DumpRenderTree/LayoutTestController.cpp:
2216         (shadowRootCallback):
2217         (LayoutTestController::staticFunctions):
2218         * DumpRenderTree/LayoutTestController.h:
2219         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2220         (LayoutTestController::shadowRoot):
2221         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2222         (LayoutTestController::shadowRoot):
2223
2224 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
2225
2226         Reviewed by Chris Marrin.
2227
2228         Update fast/canvas tests to avoid dumping the render tree when possible
2229         https://bugs.webkit.org/show_bug.cgi?id=57493
2230
2231         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
2232           accelerated drawing and accelerated drawing for canvas
2233
2234 2011-03-30  Adam Roben  <aroben@apple.com>
2235
2236         Stop ignoring leaks in CGGradientCreateWithColorStops
2237
2238         Fixes <rdar://problem/7888547>.
2239
2240         Rubber-stamped by John Sullivan.
2241
2242         * Scripts/old-run-webkit-tests:
2243         (countAndPrintLeaks): Removed some code to ignore those leaks.
2244
2245 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
2246
2247         Reviewed by Alexey Proskuryakov.
2248
2249         Add some dynamic annotations to JavaScriptCore/wtf
2250         https://bugs.webkit.org/show_bug.cgi?id=53747
2251
2252         By using these annotations we can improve the precision of finding
2253         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
2254         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
2255
2256         These files don't add new functionality, so don't need extra tests.
2257
2258         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
2259
2260 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
2261
2262         Reviewed by Adam Roben.
2263
2264         Share most vsprops between Release and Production builds in releaseproduction.vsprops
2265         https://bugs.webkit.org/show_bug.cgi?id=57508
2266
2267         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
2268         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
2269         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
2270         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
2271         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
2272         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
2273         * DumpRenderTree/win/ImageDiffProduction.vsprops:
2274         * DumpRenderTree/win/ImageDiffRelease.vsprops:
2275         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
2276         * FindSafari/FindSafariProduction.vsprops:
2277         * FindSafari/FindSafariRelease.vsprops:
2278         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
2279         * FindSafari/FindSafariReleasePGO.vsprops:
2280         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
2281         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
2282         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
2283         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
2284         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
2285         * WebKitAPITest/WebKitAPITestProduction.vsprops:
2286         * WebKitAPITest/WebKitAPITestRelease.vsprops:
2287         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
2288         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
2289         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
2290         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
2291         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
2292         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
2293         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
2294         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
2295         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
2296         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
2297         * WinLauncher/WinLauncherProduction.vsprops:
2298         * WinLauncher/WinLauncherRelease.vsprops:
2299         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
2300         * record-memory-win/record-memory-winProduction.vsprops:
2301         * record-memory-win/record-memory-winRelease.vsprops:
2302         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
2303
2304 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
2305
2306         Reviewed by Adam Roben.
2307
2308         Update Windows production build logic for new production configurations
2309         https://bugs.webkit.org/show_bug.cgi?id=57494
2310
2311         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
2312         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
2313         * DumpRenderTree/win/ImageDiffProduction.vsprops:
2314         * FindSafari/FindSafariProduction.vsprops:
2315         * FindSafari/FindSafariReleasePGO.vsprops:
2316         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
2317         * WebKitAPITest/WebKitAPITestProduction.vsprops:
2318         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
2319         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
2320         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
2321         * WinLauncher/WinLauncherProduction.vsprops:
2322         * record-memory-win/record-memory-winProduction.vsprops:
2323
2324 2011-03-30  Robert Hogan  <robert@webkit.org>
2325
2326         Reviewed by Antonio Gomes.
2327
2328         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
2329         Unskip http/tests/navigation/go-back-to-error-page.html
2330
2331         Also add the location of DumpRenderTreeSupportQt.h
2332         to DRT's include paths.
2333
2334         https://bugs.webkit.org/show_bug.cgi?id=52614
2335
2336         * DumpRenderTree/qt/DumpRenderTree.pro:
2337         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2338         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2339         * DumpRenderTree/qt/GCControllerQt.cpp:
2340         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2341         (LayoutTestController::queueLoadHTMLString):
2342         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2343         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2344         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2345         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2346         (LoadAlternateHTMLStringItem::invoke):
2347         * DumpRenderTree/qt/WorkQueueItemQt.h:
2348         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2349         * QtTestBrowser/QtTestBrowser.pro:
2350         * QtTestBrowser/launcherwindow.h:
2351
2352 2011-03-30  Adam Barth  <abarth@webkit.org>
2353
2354         Reviewed by Adam Roben.
2355
2356         SheriffBot rollouts take too long
2357         https://bugs.webkit.org/show_bug.cgi?id=57498
2358
2359         We used to build before landing rollouts via the commit-queue to
2360         prevent further breakage, but now that our individual commit-queue
2361         machines are slower, building takes too long.  I can't remember the
2362         last time a rollout broke compile.  It seems like just landing the
2363         patch is the better trade-off.
2364
2365         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2366         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2367
2368 2011-03-30  Adam Barth  <abarth@webkit.org>
2369
2370         Remove platform/chromium-mac-snowleopard
2371         https://bugs.webkit.org/show_bug.cgi?id=57486
2372
2373         This directory no longer exists, so we can remove it from the fallback
2374         chain.
2375
2376         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2377
2378 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
2379
2380         Reviewed by Adam Roben.
2381
2382         Rename Windows configuration Release_LTCG to Production for clarity
2383         https://bugs.webkit.org/show_bug.cgi?id=57465
2384
2385         * DumpRenderTree/DumpRenderTree.sln:
2386         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2387         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
2388         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
2389         * DumpRenderTree/win/DumpRenderTree.vcproj:
2390         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
2391         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
2392         * DumpRenderTree/win/ImageDiff.vcproj:
2393         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
2394         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
2395         * FindSafari/FindSafari.vcproj:
2396         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
2397         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
2398         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
2399         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
2400         * MiniBrowser/MiniBrowser.vcproj:
2401         * Scripts/webkitdirs.pm:
2402         * TestWebKitAPI/win/TestWebKitAPI.sln:
2403         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2404         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
2405         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2406         * WebKitAPITest/WebKitAPITest.vcproj:
2407         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
2408         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
2409         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2410         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
2411         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
2412         * WebKitTestRunner/WebKitTestRunner.sln:
2413         * WebKitTestRunner/win/InjectedBundle.vcproj:
2414         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
2415         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
2416         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
2417         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2418         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
2419         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
2420         * WinLauncher/WinLauncher.vcproj:
2421         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
2422         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
2423         * record-memory-win/record-memory-win.vcproj:
2424         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
2425         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
2426
2427 2011-03-30  MORITA Hajime  <morrita@google.com>
2428
2429         Reviewed by Dimitri Glazkov.
2430
2431         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
2432         https://bugs.webkit.org/show_bug.cgi?id=56573
2433
2434         Added LayoutTestController.shadowRoot() to Chromium DRT.
2435
2436         * DumpRenderTree/chromium/LayoutTestController.cpp:
2437         (LayoutTestController::LayoutTestController):
2438         (LayoutTestController::shadowRoot):
2439         * DumpRenderTree/chromium/LayoutTestController.h:
2440
2441 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
2442
2443         Reviewed by Kent Tamura.
2444
2445         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
2446         https://bugs.webkit.org/show_bug.cgi?id=57430
2447
2448         * DumpRenderTree/chromium/LayoutTestController.cpp:
2449         (LayoutTestController::LayoutTestController):
2450         (LayoutTestController::setPluginsEnabled):
2451         * DumpRenderTree/chromium/LayoutTestController.h:
2452
2453 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
2454
2455         Reviewed by Adam Barth.
2456
2457         make webkit-patch upload respect -d
2458         https://bugs.webkit.org/show_bug.cgi?id=57425
2459
2460         * Scripts/webkitpy/common/checkout/scm.py:
2461         * Scripts/webkitpy/tool/steps/commit.py:
2462
2463 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
2464
2465         Reviewed by Adam Barth.
2466
2467         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
2468         https://bugs.webkit.org/show_bug.cgi?id=57429
2469
2470         * Scripts/webkitpy/common/checkout/scm.py:
2471
2472 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2473
2474         Unreviewed, rolling out r82383.
2475         http://trac.webkit.org/changeset/82383
2476         https://bugs.webkit.org/show_bug.cgi?id=57417
2477
2478         "nrwt isn't shutting down cleanly" (Requested by dpranke on
2479         #webkit).
2480
2481         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2482         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2483         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2484
2485 2011-03-29  Kent Tamura  <tkent@chromium.org>
2486
2487         Reviewed by Dimitri Glazkov.
2488
2489         Make validation message bubble testable
2490         https://bugs.webkit.org/show_bug.cgi?id=57290
2491
2492         * DumpRenderTree/mac/DumpRenderTree.mm:
2493         (createWebViewAndOffscreenWindow): Change a setting so that validation
2494           bubbles isn't hidden automatically.
2495
2496 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
2497
2498         Reviewed by Ojan Vafai.
2499
2500         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
2501
2502         It's a bit unclear whether multiple threads or multiple
2503         processes will be a better model on windows. This change will
2504         test threads for now while we're still working out the bugs in
2505         multiple-processes.
2506
2507         https://bugs.webkit.org/show_bug.cgi?id=57410
2508
2509         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2510         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2511         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2512
2513 2011-03-29  David Levin  <levin@chromium.org>
2514
2515         Reviewed by Shinichiro Hamaji.
2516
2517         check-webkit-style confused by two ChangeLog entries in a row from same user
2518         https://bugs.webkit.org/show_bug.cgi?id=57250
2519
2520         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
2521         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
2522         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
2523           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
2524           checking more than that would be very messey.
2525         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
2526         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
2527
2528 2011-03-29  Kent Tamura  <tkent@chromium.org>
2529
2530         Reviewed by Dimitri Glazkov.
2531
2532         [Mac] Enable interactive-validation tests on Mac DRT
2533         https://bugs.webkit.org/show_bug.cgi?id=57308
2534
2535         * DumpRenderTree/mac/DumpRenderTree.mm:
2536         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
2537
2538 2011-03-29  Chang Shu  <cshu@webkit.org>
2539
2540         Reviewed by Kenneth Rohde Christiansen.
2541
2542         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
2543         https://bugs.webkit.org/show_bug.cgi?id=42692
2544
2545         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2546         (WTR::InjectedBundle::beginTesting):
2547         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2548         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
2549         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2550
2551 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
2552
2553         Reviewed by Xan Lopez.
2554
2555         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
2556         https://bugs.webkit.org/show_bug.cgi?id=57067
2557
2558         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
2559         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
2560         update DRT and pixel results as hundreds of results will need to be updated.
2561
2562         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2563         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
2564         by overriding the theme RC/CSS files.
2565
2566 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
2567
2568         Reviewed by Adam Roben.
2569
2570         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
2571         https://bugs.webkit.org/show_bug.cgi?id=57394
2572
2573         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
2574         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
2575         the IDE. To avoid this, add a separate vsprops file for each project configuration that
2576         contains the required inherited property sheets.
2577
2578         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2579         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
2580         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
2581         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
2582         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
2583         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
2584         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
2585         * DumpRenderTree/win/DumpRenderTree.vcproj:
2586         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
2587         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
2588         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
2589         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
2590         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
2591         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
2592         * DumpRenderTree/win/ImageDiff.vcproj:
2593         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
2594         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
2595         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
2596         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
2597         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
2598         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
2599         * FindSafari/FindSafari.vcproj:
2600         * FindSafari/FindSafariDebug.vsprops: Added.
2601         * FindSafari/FindSafariDebugAll.vsprops: Added.
2602         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
2603         * FindSafari/FindSafariRelease.vsprops: Added.
2604         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
2605         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
2606         * FindSafari/FindSafariReleasePGO.vsprops: Added.
2607         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
2608         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
2609         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
2610         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
2611         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
2612         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
2613         * MiniBrowser/MiniBrowser.vcproj:
2614         * WebKitAPITest/WebKitAPITest.vcproj:
2615         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
2616         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
2617         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
2618         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
2619         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
2620         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
2621         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2622         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
2623         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
2624         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
2625         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
2626         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
2627         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
2628         * WebKitTestRunner/win/InjectedBundle.vcproj:
2629         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
2630         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
2631         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
2632         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
2633         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
2634         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
2635         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2636         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
2637         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
2638         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
2639         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
2640         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
2641         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
2642         * WinLauncher/WinLauncher.vcproj:
2643         * WinLauncher/WinLauncherDebug.vsprops: Added.
2644         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
2645         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
2646         * WinLauncher/WinLauncherRelease.vsprops: Added.
2647         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
2648         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
2649         * record-memory-win/record-memory-win.vcproj:
2650         * record-memory-win/record-memory-winDebug.vsprops: Added.
2651         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
2652         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
2653         * record-memory-win/record-memory-winRelease.vsprops: Added.
2654         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
2655         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
2656
2657 2011-03-29  Adam Barth  <abarth@webkit.org>
2658
2659         Reviewed by Darin Adler.
2660
2661         test_runner2.py can crash due to undefined variable
2662         https://bugs.webkit.org/show_bug.cgi?id=57356
2663
2664         Replace reference to undefined variable with a variable that's actually
2665         defined.  AFAICT, there's no way to test this code.
2666
2667         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
2668
2669 2011-03-29  Tony Chang  <tony@chromium.org>
2670
2671         Reviewed by Eric Seidel.
2672
2673         cleanup rebaseline-chromium-webkit-tests
2674         https://bugs.webkit.org/show_bug.cgi?id=57375
2675
2676         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2677             - Split _extract_and_add_new_baselines into 3 functions
2678             - Reduce the amount of line wrapping (the file already has lines
2679               over 80 col, so may as well try to make the file consistent)
2680             - Remove unnecessary ()s
2681
2682 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
2683
2684         Reviewed by Adam Roben.
2685
2686         Make WinCairo a core builder.
2687         https://bugs.webkit.org/show_bug.cgi?id=57373
2688
2689         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
2690         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
2691
2692 2011-03-29  Timothy Hatcher  <timothy@apple.com>
2693
2694         Update update-webkit-localizable-strings to understand that WebKit and
2695         WebKit2 strings go in WebCore.
2696
2697         Also make extract-localizable-strings optionally use an exclude file. No individual
2698         warnings are produced about unlocalized strings when there is no exclude file. This
2699         is needed for WebCore, since there are too many bare strings.
2700
2701         https://webkit.org/b/57354
2702
2703         Reviewed by Sam Weinig.
2704
2705         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
2706         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
2707
2708 2011-03-29  Darin Adler  <darin@apple.com>
2709
2710         Reviewed by Adam Roben.
2711
2712         WebKit2 bundle page needs to offer generated file hooks
2713         https://bugs.webkit.org/show_bug.cgi?id=57279
2714
2715         (Land missing part of the original patch after r82289.)
2716
2717         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2718         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
2719
2720 2011-03-29  Tony Chang  <tony@chromium.org>
2721
2722         Reviewed by Ojan Vafai.
2723
2724         [chromium] NRWT should be able to read checksums from png comments
2725         https://bugs.webkit.org/show_bug.cgi?id=57280
2726
2727         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
2728             from a file.
2729         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
2730         * Scripts/webkitpy/common/system/filesystem_mock.py:
2731         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
2732             if the -checksum.txt file doesn't exist, try looking in the png.
2733         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2734         * Scripts/webkitpy/layout_tests/port/test.py:
2735         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
2736             2k for a png comment with the checksum
2737         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
2738
2739 2011-03-29  Philippe Normand  <pnormand@igalia.com>
2740
2741         Rubber-stamped by Gustavo Noronha Silva.
2742
2743         [GTK] http/tests/uri/username-with-no-hostname.html fails
2744         https://bugs.webkit.org/show_bug.cgi?id=57325
2745
2746         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2747         (willSendRequestCallback): URI host value check done case-insensitively.
2748
2749 2011-03-29  Philippe Normand  <pnormand@igalia.com>
2750
2751         Reviewed by Martin Robinson.
2752
2753         [GTK] http/tests/uri/username-with-no-hostname.html fails
2754         https://bugs.webkit.org/show_bug.cgi?id=57325
2755
2756         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2757         (willSendRequestCallback): Check URI before submitting the request
2758         to WebCore.
2759
2760 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
2761
2762         Reviewed by Ojan Vafai.
2763
2764         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
2765         https://bugs.webkit.org/show_bug.cgi?id=57303
2766
2767         * DumpRenderTree/chromium/EventSender.cpp:
2768         (EventSender::doDragDrop):
2769         (EventSender::beginDragWithFiles):
2770
2771 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
2772
2773         Reviewed by Andreas Kling.
2774
2775         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
2776         https://bugs.webkit.org/show_bug.cgi?id=57314
2777
2778         Provide possibility to print loaded urls to the standard output.
2779
2780         * MiniBrowser/qt/BrowserWindow.cpp:
2781         (BrowserWindow::BrowserWindow):
2782         (BrowserWindow::printURL):
2783         * MiniBrowser/qt/BrowserWindow.h:
2784         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2785         (MiniBrowserApplication::handleUserOptions):
2786         * MiniBrowser/qt/MiniBrowserApplication.h:
2787         (WindowOptions::WindowOptions):
2788         * QtTestBrowser/launcherwindow.cpp:
2789         (LauncherWindow::initializeView):
2790         (LauncherWindow::printURL):
2791         (LauncherWindow::cloneWindow):
2792         * QtTestBrowser/launcherwindow.h:
2793         (WindowOptions::WindowOptions):
2794         * QtTestBrowser/main.cpp:
2795         (LauncherApplication::handleUserOptions):
2796
2797 2011-03-29  Gabor Loki  <loki@webkit.org>
2798
2799         Rubber-stamped by Csaba Osztrogonác.
2800
2801         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
2802         https://bugs.webkit.org/show_bug.cgi?id=56918
2803
2804         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
2805
2806 2011-03-28  Gabor Loki  <loki@webkit.org>
2807
2808         Reviewed by Csaba Osztrogonác.
2809
2810         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
2811         https://bugs.webkit.org/show_bug.cgi?id=56918
2812
2813         * Scripts/build-jsc:
2814         * Scripts/webkitdirs.pm:
2815
2816 2011-03-28  Andrew Foster  <andrewf@chromium.org>
2817
2818         Reviewed by Ojan Vafai.
2819
2820         webkit-patch should be more intelligent about whether a bug applies to a patch
2821         Create a new function, parse_bug_id_from_changelog() which determines
2822         that a bug is related to a patch by parsing the output generated from
2823         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
2824         the description of a patch.
2825         https://bugs.webkit.org/show_bug.cgi?id=56989
2826
2827         * Scripts/webkitpy/common/checkout/api.py:
2828         * Scripts/webkitpy/common/checkout/changelog.py:
2829         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2830         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2831         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2832         * Scripts/webkitpy/style/checkers/changelog.py:
2833         * Scripts/webkitpy/tool/commands/upload.py:
2834
2835 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
2836
2837         Revert accidentally commited change.
2838
2839         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2840         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2841
2842 2011-03-28  Tony Chang  <tony@chromium.org>
2843
2844         Reviewed by Adam Barth.
2845
2846         [chromium] have DRT write the png checksum into a png comment
2847         https://bugs.webkit.org/show_bug.cgi?id=57255
2848
2849         * DumpRenderTree/chromium/TestShell.cpp:
2850         (TestShell::dumpImage):
2851
2852 2011-03-28  Adele Peterson  <adele@apple.com>
2853
2854         Removing Qt stub, since it doesn't use the same header as the others.
2855
2856         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2857
2858 2011-03-28  Adele Peterson  <adele@apple.com>
2859
2860         Added a few more stubs.
2861
2862         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2863         (LayoutTestController::hasGrammarMarker):
2864         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2865         (LayoutTestController::hasGrammarMarker):
2866         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2867         (LayoutTestController::hasGrammarMarker):
2868
2869 2011-03-28  Adele Peterson  <adele@apple.com>
2870
2871         Build fix.
2872
2873         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2874         (LayoutTestController::hasGrammarMarker):
2875
2876 2011-03-28  Adele Peterson  <adele@apple.com>
2877
2878         Reviewed by Eric Seidel.
2879
2880         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
2881         https://bugs.webkit.org/show_bug.cgi?id=57173
2882
2883         * DumpRenderTree/LayoutTestController.cpp:
2884         (hasGrammarMarkerCallback): Added.
2885         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
2886         * DumpRenderTree/LayoutTestController.h:
2887         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
2888         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
2889
2890 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
2891
2892         Reviewed by Benjamin Poulain.
2893
2894         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2895         https://bugs.webkit.org/show_bug.cgi?id=57087
2896
2897         Trivial typo fix after r82082.
2898
2899         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2900         (WTR::activateFonts):
2901
2902 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
2903
2904         Reviewed by Andreas Kling.
2905
2906         Add myself to the committers list.
2907
2908         * Scripts/webkitpy/common/config/committers.py:
2909
2910 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
2911
2912         Reviewed by Sam Weinig.
2913
2914         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
2915         to link against WebKit.framework for now.
2916
2917         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2918
2919 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
2920
2921         Reviewed by Andreas Kling.
2922
2923         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2924         https://bugs.webkit.org/show_bug.cgi?id=57087
2925
2926         Disable QT_ASCII_CAST_WARNINGS for applications.
2927
2928         * DumpRenderTree/qt/DumpRenderTree.pro:
2929         * DumpRenderTree/qt/ImageDiff.pro:
2930         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2931         * MiniBrowser/qt/MiniBrowser.pro:
2932         * QtTestBrowser/QtTestBrowser.pro:
2933         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2934
2935 2011-03-28  Andreas Kling  <kling@webkit.org>
2936
2937         Reviewed by Kenneth Rohde Christiansen.
2938
2939         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
2940         https://bugs.webkit.org/show_bug.cgi?id=57224
2941
2942         * QtTestBrowser/mainwindow.cpp:
2943         (MainWindow::buildUI):
2944         (MainWindow::onTitleChanged):
2945         * QtTestBrowser/mainwindow.h:
2946
2947 2011-03-27  Jer Noble  <jer.noble@apple.com>
2948
2949         Reviewed by Maciej Stachowiak.
2950
2951         Full Screen: disable keyboard access by default
2952         https://bugs.webkit.org/show_bug.cgi?id=56684
2953
2954         Accept the withKeyboard parameter to supportsFullScreenForElement.
2955
2956         * DumpRenderTree/mac/UIDelegate.mm:
2957         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
2958
2959 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
2960
2961         Reviewed by David Levin.
2962
2963         check-webkit-style should check ChangeLog for a valid bug number
2964         https://bugs.webkit.org/show_bug.cgi?id=57184
2965
2966         * Scripts/webkitpy/style/checker.py:
2967         * Scripts/webkitpy/style/checker_unittest.py:
2968         * Scripts/webkitpy/style/checkers/changelog.py: Added.
2969         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
2970
2971 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
2972
2973         Reviewed by Andreas Kling.
2974
2975         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2976         https://bugs.webkit.org/show_bug.cgi?id=57087
2977
2978         Use explicit conversion for string to avoid depending on the default codec
2979         installed by the user code.
2980
2981         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2982         (WTR::activateFonts):
2983
2984 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
2985
2986         Revert inadvertantly committed changes.
2987
2988         * Scripts/old-run-webkit-tests:
2989         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2990
2991 2011-03-26  Andreas Kling  <kling@webkit.org>
2992
2993         Reviewed by Kenneth Rohde Christiansen.
2994
2995         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
2996         https://bugs.webkit.org/show_bug.cgi?id=57162
2997
2998         * QtTestBrowser/QtTestBrowser.qrc:
2999         * QtTestBrowser/favicon.png: Added.
3000         * QtTestBrowser/locationedit.cpp:
3001         (defaultPageIcon):
3002         (LocationEdit::LocationEdit):
3003         (LocationEdit::setPageIcon):
3004         (LocationEdit::resizeEvent):
3005         (LocationEdit::updateInternalGeometry):
3006         * QtTestBrowser/locationedit.h:
3007         * QtTestBrowser/mainwindow.cpp:
3008         (MainWindow::buildUI):
3009         (MainWindow::onIconChanged):
3010         (MainWindow::onLoadStarted):
3011         * QtTestBrowser/mainwindow.h:
3012
3013 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
3014
3015         Reviewed by Xan Lopez.
3016
3017         [GTK] Force DumpRenderTree to use 96 DPI
3018         https://bugs.webkit.org/show_bug.cgi?id=56866
3019
3020         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
3021         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
3022
3023         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3024         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
3025         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
3026         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
3027
3028 2011-03-25  Andy Estes  <aestes@apple.com>
3029
3030         Reviewed by Adele Peterson.
3031
3032         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
3033         https://bugs.webkit.org/show_bug.cgi?id=49016
3034
3035         TestNetscapePlugIn needs to register support for an image MIME type so
3036         we can test that the embed tag prefers plug-ins to render image MIME
3037         types.
3038
3039         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
3040         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3041         (NP_GetMIMEDescription): Ditto.
3042         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
3043
3044 2011-03-25  Jessie Berlin  <jberlin@apple.com>
3045
3046         Reviewed by Sam Weinig.
3047
3048         WebKit2: Need to be able to set and get the Cookie Storage Policy.
3049         https://bugs.webkit.org/show_bug.cgi?id=50780
3050
3051         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
3052
3053         The test is named "CookieManager" so that we can eventually exercise more of the
3054         CookieManager functionality in the test.
3055
3056         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
3057         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
3058         Assert that the policy returned is equal to the policy set in
3059         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
3060         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
3061         Set the policy to something different than the user's policy and get the policy again.
3062         (TestWebKitAPI::didFinishLoadForFrame):
3063         Get the user's policy so that it can be restored at the end of the test.
3064         (TestWebKitAPI::TEST):
3065         Load about:blank so that the Web Process gets instatiated (needed to get the
3066         CookieManager).
3067
3068         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3069         Add CookieManager.cpp.
3070
3071 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
3072
3073         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
3074
3075         * wx/build/settings.py:
3076
3077 2011-03-24  Ilya Sherman  <isherman@chromium.org>
3078
3079         Reviewed by Adam Roben.
3080
3081         Implement layoutTestController.setAutoFilled in DRT on Windows
3082         https://bugs.webkit.org/show_bug.cgi?id=56828
3083
3084         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3085         (LayoutTestController::setAutofilled): Implemented.
3086
3087 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
3088
3089         Unreviewed build correction.
3090
3091         Correct vsprops file for Debug variant of the CFLite build.
3092         Disable a CFNETWORK-specific test when building for CFLite.
3093
3094         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
3095         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3096
3097 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
3098
3099         Reviewed by Adam Barth.
3100
3101         fix regressions introduced in 81908 - there were a couple of
3102         code paths that only fired under python 2.5 that I missed.
3103
3104         Also change a couple of 'python' references to sys.executable
3105         in order to handle runing test-webkitpy with a binary other than
3106         something called 'python'.
3107
3108         https://bugs.webkit.org/show_bug.cgi?id=57063
3109
3110         * Scripts/webkitpy/layout_tests/port/mac.py:
3111         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3112         * Scripts/webkitpy/test/cat.py:
3113         * Scripts/webkitpy/test/echo.py:
3114
3115 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
3116
3117         Unreviewed build correction.
3118
3119         Add a stub implementation of the TestInvocation dumping logic.
3120         Update project files to reflect new file.
3121
3122         * WebKitTestRunner/cairo: Added.
3123         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
3124         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3125         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3126
3127 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
3128
3129         Reviewed by Tony Chang.
3130
3131         new-run-webkit-tests: clean up worker model defaults. This
3132         changes the default behavior to 'threads' instead of
3133         'old-threads', and clarifies that chromium-win-* and
3134         chromium-mac-leopard are exceptions.
3135
3136         https://bugs.webkit.org/show_bug.cgi?id=56971
3137
3138         * Scripts/webkitpy/layout_tests/port/base.py:
3139         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3140         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3141         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3142         * Scripts/webkitpy/layout_tests/port/test.py:
3143         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3144
3145 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
3146
3147         Reviewed by Darin Adler.
3148
3149         Media Stream API: fix the order of the options in build-webkit.
3150         https://bugs.webkit.org/show_bug.cgi?id=56949
3151
3152         Fix the order of the options in build-webkit.
3153
3154         * Scripts/build-webkit:
3155
3156 2011-03-23  Adam Klein  <adamk@chromium.org>
3157
3158         Reviewed by Mihai Parparita.
3159
3160         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
3161         https://bugs.webkit.org/show_bug.cgi?id=56884
3162
3163         This option will be utilized by Chromium's ui_tests to allow
3164         referencing js-test-resources from a layout test over HTTP.
3165
3166         * Scripts/new-run-webkit-httpd:
3167         Added --layout_tests_dir option.
3168         * Scripts/webkitpy/layout_tests/port/http_server.py:
3169         Plumbed through as layout_tests_dir param.
3170
3171 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
3172
3173         Reviewed by Mihai Parparita.
3174
3175         new-run-webkit-tests: run tests in ascending alphabetical order per
3176         dir. This is a second attempt at the fix; the first attempt, in 
3177         r81597, broke the behavior on the old-inline and old-threads
3178         worker models.
3179
3180         https://bugs.webkit.org/show_bug.cgi?id=56760
3181
3182         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3183         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3184         * Scripts/webkitpy/layout_tests/port/test.py:
3185         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3186
3187 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
3188
3189         Reviewed by Martin Robinson.
3190
3191         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
3192         https://bugs.webkit.org/show_bug.cgi?id=56953
3193
3194         Print the string for the detail of 'property-change' signal.
3195
3196         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
3197         (axObjectEventListener): Print the detail string.
3198
3199 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
3200
3201         Reviewed by Pavel Feldman.
3202
3203         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
3204         https://bugs.webkit.org/show_bug.cgi?id=56843
3205
3206         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3207         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3208
3209 2011-03-22  Eric Seidel  <eric@webkit.org>
3210
3211         Reviewed by Adam Barth.
3212
3213         Teach update-webkit about gyp
3214         https://bugs.webkit.org/show_bug.cgi?id=56881
3215
3216         This makes it possible for someone who builds from Xcode
3217         to just run update-webkit --gyp and have the project files
3218         generated after update automatically.
3219
3220         I also added a stand-alone "generate-project-files" script
3221         wrapping Source/gyp/configure.  This makes running gyp simpler
3222         since most people will not have gyp or Source/gyp in their path.
3223
3224         * Scripts/build-webkit:
3225         * Scripts/generate-project-files: Added.
3226         * Scripts/update-webkit:
3227
3228 2011-03-22  Anton D'Auria  <adauria@apple.com>
3229
3230         Reviewed by Alexey Proskuryakov.
3231
3232         Add +[WebApplicationCache getOriginsWithCache]
3233         https://bugs.webkit.org/show_bug.cgi?id=56722
3234
3235         * DumpRenderTree/LayoutTestController.cpp:
3236         (originsWithApplicationCacheCallback):
3237         (LayoutTestController::staticFunctions):
3238         * DumpRenderTree/LayoutTestController.h:
3239         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
3240         (LayoutTestController::originsWithApplicationCache):
3241         * DumpRenderTree/chromium/LayoutTestController.h:
3242         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
3243         (LayoutTestController::originsWithApplicationCache):
3244         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
3245         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
3246         (LayoutTestController::originsWithApplicationCache):
3247         (LayoutTestController::originsWithLocalStorage):
3248         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
3249         (LayoutTestController::originsWithApplicationCache):
3250         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3251         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
3252         (LayoutTestController::originsWithApplicationCache):
3253         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
3254         (LayoutTestController::originsWithApplicationCache):
3255
3256 2011-03-22  Eric Seidel  <eric@webkit.org>
3257
3258         Reviewed by Adam Barth.
3259
3260         Add support to build-webkit for building with gyp-generated project files
3261         https://bugs.webkit.org/show_bug.cgi?id=56877
3262
3263         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
3264         Eventually we'll want to support gyp-generated projects in a more general manner.
3265
3266         * Scripts/build-webkit:
3267
3268 2011-03-22  David Kilzer  <ddkilzer@apple.com>
3269
3270         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
3271
3272         Reviewed by Joseph Pecoraro.
3273
3274         * Scripts/build-webkit: Updated usage statement to include
3275         --dsym.
3276         * Scripts/webkitdirs.pm: Added $generateDsym variable.
3277         (generateDsym): Added. Call determineGenerateDsym() and
3278         return $generateDsym.
3279         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
3280         $generateDsym.
3281         (argumentsForXcode): Added.  Returns additional arguments for
3282         xcodebuild based on command-line switches.
3283         (XcodeOptions): Updated to include argumentsForXcode() in the
3284         array returned.
3285
3286 2011-03-22  Adam Roben  <aroben@apple.com>
3287
3288         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
3289
3290         These bots are consistently green again.
3291
3292         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
3293         core builders
3294
3295         Rubber-stamped by Antti Koivisto.
3296
3297         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3298         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
3299
3300         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3301         (BuildBotTest.test_builder_name_regexps): Updated expectations.
3302
3303 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
3304
3305         Unreviewed, rolling out r81597.
3306         http://trac.webkit.org/changeset/81597
3307         https://bugs.webkit.org/show_bug.cgi?id=56801
3308
3309         Change results in lots of unexpected flaky on the dashboard.
3310         (Requested by pfeldman on #webkit).
3311
3312         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3313         * Scripts/webkitpy/layout_tests/port/test.py:
3314         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3315
3316 2011-03-21  Sam Weinig  <sam@webkit.org>
3317
3318         Fix failing tests on the WebKit2 bots.
3319
3320         * WebKitTestRunner/TestController.cpp:
3321         (WTR::TestController::resetStateToConsistentValues):
3322
3323 2011-03-21  Daniel Sievers  <sievers@google.com>
3324
3325         Reviewed by Simon Fraser.
3326
3327         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
3328         https://bugs.webkit.org/show_bug.cgi?id=56139
3329
3330         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3331         (main):
3332         * DumpRenderTree/chromium/LayoutTestController.cpp:
3333         (LayoutTestController::LayoutTestController):
3334         (LayoutTestController::layerTreeAsText):
3335         * DumpRenderTree/chromium/LayoutTestController.h:
3336         (LayoutTestController::setShowDebugLayerTree):
3337         * DumpRenderTree/chromium/TestShell.cpp:
3338         (TestShell::runFileTest):
3339         (TestShell::dump):
3340         * DumpRenderTree/chromium/TestShell.h:
3341         (TestParams::TestParams):
3342
3343 2011-03-21  Adam Roben  <aroben@apple.com>
3344
3345         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
3346
3347         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
3348         output as plain text
3349
3350         Reviewed by David Kilzer.
3351
3352         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3353         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
3354         to the master.
3355         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
3356         since we're running on the build master, not the slave. Instead, turn the raw source of
3357         actual.html which the build slave uploaded into an HTML log.
3358
3359 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
3360
3361         Reviewed by Mihai Parparita.
3362
3363         new-run-webkit-tests: run tests in ascending alphabetical order per dir
3364         https://bugs.webkit.org/show_bug.cgi?id=56760
3365
3366         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3367         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3368         * Scripts/webkitpy/layout_tests/port/test.py:
3369
3370 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
3371
3372         Reviewed by Steve Block.
3373
3374         Media Stream API patch 0: adding compilation guards.
3375         https://bugs.webkit.org/show_bug.cgi?id=56458
3376
3377         Adding options to enable the media stream API feature in Chromium.
3378
3379         * Scripts/build-webkit:
3380
3381 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
3382
3383         Reviewed by Laszlo Gombos.
3384
3385         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
3386         https://bugs.webkit.org/show_bug.cgi?id=56323
3387
3388         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
3389         "--stdout" or "--stderr" option.
3390
3391         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3392         (WebCore::DumpRenderTree::~DumpRenderTree):
3393         (WebCore::DumpRenderTree::processArgsLine):
3394         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
3395         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3396         (WebCore::DumpRenderTree::setRedirectOutputFileName):
3397         (WebCore::DumpRenderTree::setRedirectErrorFileName):
3398         * DumpRenderTree/qt/main.cpp:
3399         (isOption):
3400         (takeOptionValue):
3401         (printUsage):
3402         (main):
3403
3404 2011-03-21  Adam Roben  <aroben@apple.com>
3405
3406         Fix exceptions on the buildbot due to my last change
3407
3408         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3409         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
3410
3411 2011-03-21  Adam Roben  <aroben@apple.com>
3412
3413         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
3414
3415         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
3416         output as plain text
3417
3418         Reviewed by Darin Adler.
3419
3420         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3421         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
3422         logs.
3423         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
3424         the build master. This will correctly treat it as HTML.
3425
3426 2011-03-20  Bill Budge  <bbudge@chromium.org>
3427
3428         Reviewed by Adam Barth.
3429
3430         Rename ThreadSafeShared to ThreadSafeRefCounted
3431         https://bugs.webkit.org/show_bug.cgi?id=56714
3432
3433         No new tests. Exposes no new functionality.
3434
3435         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
3436         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
3437         * Scripts/do-webcore-rename:
3438
3439 2011-03-19  Anton D'Auria  <adauria@apple.com>
3440
3441         Reviewed by Dan Bernstein.
3442
3443         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
3444         https://bugs.webkit.org/show_bug.cgi?id=56719
3445
3446         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
3447         (LayoutTestController::clearApplicationCacheForOrigin):
3448
3449 2011-03-19  Anton D'Auria  <adauria@apple.com>
3450
3451         Reviewed by Alexey Proskuryakov.
3452
3453         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
3454         https://bugs.webkit.org/show_bug.cgi?id=56415
3455
3456         * DumpRenderTree/LayoutTestController.cpp:
3457         (clearApplicationCacheForOriginCallback):
3458         (LayoutTestController::staticFunctions):
3459         * DumpRenderTree/LayoutTestController.h:
3460         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
3461         (LayoutTestController::LayoutTestController):
3462         (LayoutTestController::clearAllApplicationCaches):
3463         (LayoutTestController::clearApplicationCacheForOrigin): 
3464         * DumpRenderTree/chromium/LayoutTestController.h:
3465         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
3466         (LayoutTestController::clearApplicationCacheForOrigin):
3467         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
3468         (LayoutTestController::clearApplicationCacheForOrigin):
3469         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3470         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
3471         (LayoutTestController::clearApplicationCacheForOrigin):
3472         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
3473         (LayoutTestController::clearApplicationCacheForOrigin):
3474
3475 2011-03-18  Dan Bernstein  <mitz@apple.com>
3476
3477         Revised build fix for r81135.
3478
3479         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3480         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3481
3482 2011-03-18  Adam Roben  <aroben@apple.com>
3483
3484         Windows build fix
3485
3486         * WebKitTestRunner/config.h: Add a missing #endif.
3487
3488 2011-03-18  Andreas Kling  <kling@webkit.org>
3489
3490         Unbreak Qt build after r81494.
3491
3492         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3493         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3494
3495 2011-03-18  Sam Weinig  <sam@webkit.org>
3496
3497         Fix windows build. This was really Adam Roben's fault. I swear!
3498
3499         * WebKitTestRunner/config.h:
3500
3501 2011-03-18  Sam Weinig  <sam@webkit.org>
3502
3503         Reviewed by Adam Roben.
3504
3505         Pixel tests don't work in WebKitTestRunner on Windows
3506         https://bugs.webkit.org/show_bug.cgi?id=56630
3507
3508         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
3509         built-in snapshotting instead of using the window server on the Mac.
3510
3511         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3512         (WTR::InjectedBundle::InjectedBundle):
3513         (WTR::InjectedBundle::didReceiveMessage):
3514         (WTR::InjectedBundle::beginTesting):
3515         (WTR::InjectedBundle::done):
3516         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3517         (WTR::InjectedBundle::setPixelResult):
3518         (WTR::InjectedBundle::shouldDumpPixels):
3519         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3520         (WTR::InjectedBundlePage::dump):
3521         Take the snapshot in the bundle and send it to the UIProcess for dumping.
3522
3523         * WebKitTestRunner/TestInvocation.cpp:
3524         (WTR::TestInvocation::invoke):
3525         (WTR::TestInvocation::dump):
3526         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3527         * WebKitTestRunner/TestInvocation.h:
3528         * WebKitTestRunner/cg: Added.
3529         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
3530         (WTR::createCGContextFromImage):
3531         (WTR::computeMD5HashStringForContext):
3532         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3533         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
3534         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
3535
3536         * WebKitTestRunner/win/TestInvocationWin.cpp:
3537         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3538         Keep stub for Cairo build.
3539
3540         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
3541         Add CG configuration.
3542
3543         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3544         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3545         Add new files.
3546
3547 2011-03-18  Adam Roben  <aroben@apple.com>
3548
3549         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
3550
3551         Rubber-stamped by Simon Fraser.
3552
3553         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3554         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
3555         overflow-y:overlay so that the scrollbar doesn't overlay the content.
3556
3557 2011-03-18  Adam Roben  <aroben@apple.com>
3558
3559         Don't ellipsize long or indented function names in Leaks Viewer
3560
3561         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
3562         scrollbar
3563
3564         Reviewed by Simon Fraser.
3565
3566         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3567         (.data-grid .data-container):
3568         (.data-grid td > div, .data-grid th > div):
3569         Allow the contents to extend to the right.
3570
3571 2011-03-18  Adam Roben  <aroben@apple.com>
3572
3573         Fix some leaks in DRT seen on the leaks bot
3574
3575         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
3576         setWillSendRequestClearHeaderCallback in DRT are leaky
3577
3578         Reviewed by Alexey Proskuryakov.
3579
3580         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
3581
3582         * DumpRenderTree/LayoutTestController.cpp:
3583         (addURLToRedirectCallback):
3584         (setWillSendRequestClearHeaderCallback):
3585         Use OwnArrayPtr to cause the strings to be deleted.
3586
3587 2011-03-18  Adam Roben  <aroben@apple.com>
3588
3589         Fix a NSURLCredential leak seen on the leaks bot
3590
3591         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
3592         connection:didReceiveAuthenticationChallenge:] is leaky
3593
3594         Reviewed by John Sullivan.
3595
3596         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3597         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
3598         cause the NSURLCredential to be released.
3599
3600 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
3601
3602         Unreviewed.
3603
3604         Remove unnecessary brackets around my email address.
3605
3606         * Scripts/webkitpy/common/config/committers.py:
3607
3608 2011-03-18  Adam Roben  <aroben@apple.com>
3609         
3610         Remove some files I accidentally added in r81454
3611
3612         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
3613         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
3614
3615 2011-03-18  Adam Roben  <aroben@apple.com>
3616
3617         Ignore an NSNumberFormatter leak on SnowLeopard
3618
3619         * Scripts/old-run-webkit-tests:
3620         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
3621         getObjectValue:forString:errorDescription:].
3622
3623 2011-03-18  Adam Roben  <aroben@apple.com>
3624
3625         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
3626
3627         Rubber-stamped by Mark Rowe.
3628
3629         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3630         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
3631         released.
3632
3633 2011-03-17  Adam Roben  <aroben@apple.com>
3634
3635         Address a review comment I missed in r81445
3636
3637         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
3638         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
3639         leaked bytes to speed up searching on long lines.
3640
3641 2011-03-17  Adam Roben  <aroben@apple.com>
3642
3643         Mark leaky builds orange, even if all regression tests passed
3644
3645         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
3646         build.webkit.org when all tests pass even though there are still leaks
3647
3648         Reviewed by Dan Bernstein.
3649
3650         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3651         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
3652         be marked orange if this build step generates warnings.
3653
3654 2011-03-17  Adam Roben  <aroben@apple.com>
3655
3656         Allow values in Leaks Viewer to be shown as percentages
3657
3658         Double-clicking on a column will toggle between showing percentages and showing real values.
3659
3660         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
3661         number of leaked bytes in Leaks Viewer
3662
3663         Reviewed by Joe Pecoraro.
3664
3665         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
3666         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
3667         node's totalTime, which is used in calculating percentages.
3668
3669         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
3670         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
3671         showing them as percentages.
3672
3673 2011-03-17  Adam Roben  <aroben@apple.com>
3674
3675         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
3676
3677         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
3678         the number of leaked allocations. And the new Average column shows the average number of
3679         leaked bytes per call.
3680
3681         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
3682         just how many allocations
3683
3684         Reviewed by Joe Pecoraro.
3685
3686         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
3687         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
3688         line and store it with the leak stack.
3689         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
3690         properties.
3691         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
3692         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
3693         .numberOfCalls now holds the number of leaked allocations.
3694
3695         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
3696         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
3697         appear.
3698         (monkeyPatchInspectorObjects): Format the values as bytes.
3699
3700 2011-03-17  Adam Roben  <aroben@apple.com>
3701
3702         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
3703
3704         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
3705         regression tests
3706
3707         Reviewed by James Robinson.
3708
3709         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3710         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
3711         is always populated, even when all regression tests pass.
3712
3713 2011-03-10  Hayato Ito  <hayato@chromium.org>
3714
3715         Reviewed by Tony Chang.
3716
3717         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
3718
3719         https://bugs.webkit.org/show_bug.cgi?id=56076
3720
3721         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3722
3723 2011-03-17  Adam Roben  <aroben@apple.com>
3724
3725         Skip a compositing-sensitive test when accelerated compositing is disabled
3726
3727         Reviewed by Sam Weinig.
3728
3729         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
3730         accelerated compositing is disabled.
3731
3732 2011-03-17  Adam Roben  <aroben@apple.com>
3733
3734         Start using PlatformSpecificScheduler for the Mac builders
3735
3736         The current set of file/directory patterns should work for Mac builders. We may discover
3737         that there are more files and directories we can exclude from the Mac builds, but they can
3738         be added later.
3739
3740         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
3741
3742         Reviewed by Mark Rowe.
3743
3744         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
3745         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
3746
3747         * Scripts/webkitpy/common/config/build.py:
3748         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
3749         cleaned up patterns a little bit.
3750
3751         * Scripts/webkitpy/common/config/build_unittest.py:
3752         (ShouldBuildTest): Fixed some expected results.
3753         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
3754         platforms.
3755
3756 2011-03-17  Jeff Miller  <jeffm@apple.com>
3757
3758         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
3759         
3760         *.mode*
3761         *.pbxuser
3762         *.perspective*
3763         project.xcworkspace
3764         xcuserdata
3765
3766         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
3767         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
3768         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
3769         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3770         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
3771
3772 2011-03-17  Adam Roben  <aroben@apple.com>
3773
3774         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
3775
3776         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
3777         mac-wk2
3778
3779         Reviewed by Anders Carlsson.
3780
3781         * Scripts/old-run-webkit-tests:
3782         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
3783         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
3784         we're running in WebKit2 mode.
3785
3786 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
3787
3788         Reviewed by Yury Semikhatsky.
3789
3790         Web Inspector: Clean up Inspector strings.
3791         https://bugs.webkit.org/show_bug.cgi?id=56557
3792
3793         Modify the script to deal correctly with "\xNN" escapes, and to
3794         check strings in Chromium's DevTools.js.
3795
3796         * Scripts/check-inspector-strings:
3797
3798 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
3799
3800         Reviewed by Benjamin Poulain.
3801
3802         Update autoinstall to install mechanize 0.2.4
3803         https://bugs.webkit.org/show_bug.cgi?id=56499
3804
3805         Newer versions of mechanize support HTTPS proxies, which is necessary
3806         for people using webkit-patch behind firewalls.
3807
3808         * Scripts/webkitpy/common/system/autoinstall.py:
3809         * Scripts/webkitpy/thirdparty/__init__.py:
3810
3811 2011-03-16  Sam Weinig  <sam@webkit.org>
3812
3813         Reviewed by Adam Roben.
3814
3815         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
3816         https://bugs.webkit.org/show_bug.cgi?id=56541
3817
3818         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3819         (WTR::InjectedBundlePage::willSendRequestForFrame):
3820         Check for an empty host in addition to a null host.  This bug was introduced
3821         when porting off of the KURL code and onto the WKURLRef version.
3822
3823 2011-03-16  Sam Weinig  <sam@webkit.org>
3824
3825         Reviewed by Adam Roben.
3826
3827         Add Lucas Forschler to the list of WebKit committers.
3828
3829         * Scripts/webkitpy/common/config/committers.py:
3830
3831 2011-03-16  Sam Weinig  <sam@webkit.org>
3832
3833         Reviewed upon and dictated through Adam Roben.
3834
3835         Escape crashing function names in results.html. This fixes an issue
3836         when a crash involves a type with templates.
3837
3838         * Scripts/old-run-webkit-tests:
3839
3840 2011-03-16  Daniel Sievers  <sievers@google.com>
3841
3842         Reviewed by James Robinson.
3843
3844         Add setting to always force compositing mode
3845         https://bugs.webkit.org/show_bug.cgi?id=56156
3846
3847         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3848         (main):
3849         * DumpRenderTree/chromium/TestShell.cpp:
3850         (TestShell::TestShell):
3851         (TestShell::resetWebSettings):
3852         * DumpRenderTree/chromium/TestShell.h:
3853         (TestShell::setForceCompositingMode):
3854         * DumpRenderTree/chromium/WebPreferences.cpp:
3855         (WebPreferences::reset):
3856         (WebPreferences::applyTo):
3857         * DumpRenderTree/chromium/WebPreferences.h:
3858
3859 2011-03-15  Hayato Ito  <hayato@chromium.org>
3860
3861         Reviewed by Ojan Vafai.
3862
3863         Ignore files that will be used by reftests in old-run-webkit-tests.
3864
3865         https://bugs.webkit.org/show_bug.cgi?id=55936
3866
3867         * Scripts/old-run-webkit-tests:
3868
3869 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
3870
3871         Reviewed by Adam Roben.
3872
3873         Function relativeScriptsDir doesn't return the correct relative
3874         Scripts directory.
3875
3876         * Scripts/webkitdirs.pm:
3877         (relativeScriptsDir): Ensure we use the directory that contains
3878         webkitdirs.pm, not the one that contains the original script that
3879         was invoked.
3880
3881 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
3882
3883         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
3884         fix to link against the Security framework after recent WebKitSystemInterface changes.
3885
3886         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3887         (LayoutTestController::originsWithLocalStorage):
3888         * wx/build/settings.py:
3889         * wx/build/waf_extensions.py:
3890
3891 2011-03-15  Sam Weinig  <sam@webkit.org>
3892
3893         Reviewed by Darin Adler.
3894
3895         Add script to convert a patch to a prettypatch and show in the default browser
3896         https://bugs.webkit.org/show_bug.cgi?id=56416
3897
3898         This can be used either like
3899             $ svn-create-patch | show-pretty-diff
3900         or
3901             $ show-pretty-diff patch.diff
3902
3903         * Scripts/show-pretty-diff: Added.
3904
3905 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
3906
3907         Rubber-stamped by Adam Roben.
3908
3909         Adding myself as a reviewer.
3910
3911         * Scripts/webkitpy/common/config/committers.py:
3912
3913 2011-03-15  Anders Carlsson  <andersca@apple.com>
3914
3915         Try to fix the Windows build.
3916
3917         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
3918         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
3919
3920 2011-03-15  Anders Carlsson  <andersca@apple.com>
3921
3922         Reviewed by Sam Weinig.
3923
3924         Make sure that NP_Shutdown is always the last NPP function called
3925         https://bugs.webkit.org/show_bug.cgi?id=56391
3926
3927         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
3928
3929         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3930         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3931         (PluginTest::PluginTest):
3932         (PluginTest::NP_Shutdown):
3933         (PluginTest::registerNPShutdownFunction):
3934         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3935         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
3936         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
3937         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
3938         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
3939         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
3940         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
3941         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
3942         (NPDeallocateCalledBeforeNPShutdown::shutdown):
3943         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3944         (NP_Shutdown):
3945         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3946         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3947         * GNUmakefile.am:
3948
3949 2011-03-15  Ilya Sherman  <isherman@chromium.org>
3950
3951         Reviewed by Tony Chang.
3952
3953         Autofilled form elements are assigned fixed background color but not text color
3954         https://bugs.webkit.org/show_bug.cgi?id=48382
3955
3956         * DumpRenderTree/LayoutTestController.cpp:
3957         (setAutofilledCallback): Added.
3958         (LayoutTestController::staticFunctions):
3959         * DumpRenderTree/LayoutTestController.h:
3960         * DumpRenderTree/chromium/LayoutTestController.cpp:
3961         (LayoutTestController::LayoutTestController):
3962         (LayoutTestController::setAutofilled): Added.
3963         * DumpRenderTree/chromium/LayoutTestController.h:
3964         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3965         (LayoutTestController::setAutofilled): Added.
3966         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3967         (LayoutTestController::setAutofilled): Added.
3968         (LayoutTestController::setValueForUser): Style tweak.
3969         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3970         (LayoutTestController::setAutofilled): Added (stub).
3971         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3972         (LayoutTestController::setAutofilled): Added (stub).
3973
3974 2011-03-15  Dan Bernstein  <mitz@apple.com>
3975
3976         Build fix after r81135.
3977
3978         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3979
3980 2011-03-15  Dan Bernstein  <mitz@apple.com>
3981
3982         Build fix after r81135.
3983
3984         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3985         * WebKitTestRunner/mac/TestControllerMac.mm:
3986         * WebKitTestRunner/mac/TestInvocationMac.mm:
3987         * WebKitTestRunner/mac/main.mm:
3988
3989 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
3990
3991         Reviewed by Adam Barth.
3992
3993         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
3994         https://bugs.webkit.org/show_bug.cgi?id=56349
3995
3996         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
3997         on platforms where we use it. Copied from DumpRenderTree.pro.
3998
3999 2011-03-15  Dan Bernstein  <mitz@apple.com>
4000
4001         Build fix after r81135.
4002
4003         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
4004         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
4005
4006 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
4007
4008         Reviewed by Darin Adler.
4009
4010         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
4011         info into the headers rather than in export symbol definition files, but disable it on 
4012         all platforms initially so we can deal with port build issues one port at a time.
4013         
4014         https://bugs.webkit.org/show_bug.cgi?id=27551
4015
4016         * DumpRenderTree/cg/ImageDiffCG.cpp:
4017         * DumpRenderTree/chromium/config.h:
4018         * DumpRenderTree/config.h:
4019         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4020         * TestWebKitAPI/TestWebKitAPIPrefix.h:
4021         * WebKitAPITest/HostWindow.cpp:
4022         * WebKitAPITest/TestsController.cpp:
4023         * WebKitAPITest/config.h: Added.
4024         * WebKitAPITest/main.cpp:
4025         * WebKitAPITest/tests/WebViewDestruction.cpp:
4026         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
4027         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4028         * WebKitTestRunner/InjectedBundle/GCController.cpp:
4029         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4030         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
4031         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4032         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4033         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
4034         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
4035         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
4036         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
4037         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
4038         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
4039         * WebKitTestRunner/TestController.cpp:
4040         * WebKitTestRunner/TestInvocation.cpp:
4041         * WebKitTestRunner/config.h: Added.
4042         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4043         * WebKitTestRunner/qt/TestControllerQt.cpp:
4044         * WebKitTestRunner/qt/TestInvocationQt.cpp:
4045         * WebKitTestRunner/qt/main.cpp:
4046         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4047         * WebKitTestRunner/win/TestControllerWin.cpp:
4048         * WebKitTestRunner/win/TestInvocationWin.cpp:
4049         * WebKitTestRunner/win/main.cpp:
4050         * wx/build/settings.py:
4051
4052 2011-03-15  Hayato Ito  <hayato@chromium.org>
4053
4054         Reviewed by Shinichiro Hamaji.
4055
4056         [NRWT] Add support for reftests to new-run-webkit-tests.
4057
4058         https://bugs.webkit.org/show_bug.cgi?id=55457
4059
4060         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
4061         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
4062         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
4063         * Scripts/webkitpy/layout_tests/port/base.py:
4064         * Scripts/webkitpy/layout_tests/port/dryrun.py:
4065         * Scripts/webkitpy/layout_tests/port/test.py:
4066         * Scripts/webkitpy/layout_tests/port/test_files.py:
4067         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4068
4069 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
4070
4071         Reviewed by Martin Robinson.
4072
4073         [GTK] Fix compilation warning after r80892
4074         https://bugs.webkit.org/show_bug.cgi?id=56302
4075
4076         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4077         (LayoutTestController::originsWithLocalStorage):
4078
4079 2011-03-15  Robert Hogan  <robert@webkit.org>
4080
4081         Reviewed by Adam Barth.
4082
4083         Document the qmakearg argument, and hint how to build webkit2 on Qt
4084         https://bugs.webkit.org/show_bug.cgi?id=56326
4085
4086         * Scripts/build-webkit: add --qmakearg to build-webkit --help
4087
4088 2011-03-15  Adam Roben  <aroben@apple.com>
4089
4090         Make Windows 7 Release (Tests) a core builder
4091
4092         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
4093         give it a few more days of greenness first.
4094
4095         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
4096
4097         Reviewed by Sam Weinig.
4098
4099         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4100         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
4101
4102         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4103         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
4104         Updated the core regexps to match the buildbot module. Updated the expected results to match
4105         the current set of core builders.
4106
4107 2011-03-14  Adam Roben  <aroben@apple.com>
4108
4109         Add forgotten file from r81116
4110
4111         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
4112
4113 2011-03-14  Sam Weinig  <sam@webkit.org>
4114
4115         Reviewed by Adam Roben.
4116
4117         about:blank fake responses don't get serialized when sent the UIProcess
4118         <rdar://problem/9108119>
4119         https://bugs.webkit.org/show_bug.cgi?id=56357
4120
4121         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
4122         (TestWebKitAPI::decidePolicyForResponse):
4123         (TestWebKitAPI::TEST):
4124         Add test that loads of about:blank have a response with a MIMEType of text/html.
4125
4126         * TestWebKitAPI/PlatformUtilities.h:
4127         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
4128         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
4129         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4130         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
4131         Add helper to get the MIMEType from a WKURLResponse.
4132
4133         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4134         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4135         Add new files.
4136
4137 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
4138
4139         Reviewed by Kenneth Rohde Christiansen.
4140
4141         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
4142         https://bugs.webkit.org/show_bug.cgi?id=56006
4143
4144         * QtTestBrowser/launcherwindow.cpp:
4145         (LauncherWindow::initializeView):
4146         * QtTestBrowser/main.cpp:
4147         (LauncherApplication::handleUserOptions):
4148
4149 2011-03-14  James Kozianski  <koz@chromium.org>
4150
4151         Reviewed by Ojan Vafai.
4152
4153         Add method to make BuildBot return test outputs
4154         https://bugs.webkit.org/show_bug.cgi?id=54374
4155
4156         The Builder.latest_cached_build will be used by the new rebaseline
4157         script to determine the build to use baselines from.
4158
4159         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4160         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4161
4162 2011-03-14  Adam Roben  <aroben@apple.com>
4163
4164         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
4165
4166         Reviewed by Sam Weinig.
4167
4168         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
4169         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
4170         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
4171         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
4172         ensure the web process is initialized, then ask the bundle to run the test and assert that
4173         it succeeded.
4174
4175         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
4176         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
4177         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
4178         handle a given URL.
4179         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
4180         URL type cannot be handled).
4181         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
4182         result.
4183
4184         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4185         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4186         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
4187         Added new files to the project.
4188
4189 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
4190
4191         Unreviewed, rolling out r81094.
4192         http://trac.webkit.org/changeset/81094
4193         https://bugs.webkit.org/show_bug.cgi?id=56355
4194
4195         Broke the chromium DRT related build. (Requested by dave_levin
4196         on #webkit).
4197
4198         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4199         (main):
4200         * DumpRenderTree/chromium/LayoutTestController.cpp:
4201         (LayoutTestController::LayoutTestController):
4202         (LayoutTestController::layerTreeAsText):
4203         * DumpRenderTree/chromium/LayoutTestController.h:
4204         * DumpRenderTree/chromium/TestShell.cpp:
4205         (TestShell::runFileTest):
4206         (TestShell::dump):
4207         * DumpRenderTree/chromium/TestShell.h:
4208         (TestParams::TestParams):
4209
4210 2011-03-14  Daniel Sievers  <sievers@google.com>
4211
4212         Reviewed by Simon Fraser.
4213
4214         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
4215         https://bugs.webkit.org/show_bug.cgi?id=56139
4216
4217         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4218         (main):
4219         * DumpRenderTree/chromium/LayoutTestController.cpp:
4220         (LayoutTestController::LayoutTestController):
4221         (LayoutTestController::layerTreeAsText):
4222         * DumpRenderTree/chromium/LayoutTestController.h:
4223         (LayoutTestController::setShowDebugLayerTree):
4224         * DumpRenderTree/chromium/TestShell.cpp:
4225         (TestShell::runFileTest):
4226         (TestShell::dump):
4227         * DumpRenderTree/chromium/TestShell.h:
4228         (TestParams::TestParams):
4229
4230 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
4231
4232         Reviewed by Adam Roben.
4233
4234         [Qt][WK2]Unbreak InjectedBundle on Qt
4235         https://bugs.webkit.org/show_bug.cgi?id=54109
4236
4237         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4238         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
4239         API's instead of KURL to analyze the URL.
4240         * WebKitTestRunner/StringFunctions.h:
4241         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
4242         in the WebKitTestRunner project.
4243         (WTR::toWK): Use adoptWK.
4244         (WTR::operator<<): Added helper for printing a WKURL.
4245         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
4246         against WebCore.
4247
4248 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
4249
4250         Reviewed by Kenneth Rohde Christiansen.
4251
4252         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
4253         https://bugs.webkit.org/show_bug.cgi?id=56321
4254
4255         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
4256         to the list of exceptions for WebKit2 C API headers.
4257
4258 2011-03-14  Adam Roben  <aroben@apple.com>
4259
4260         Show the list of recent leaky builds in reverse chronological order
4261
4262         Previously they were being shown in a deterministic but surprising order based on
4263         lexicographically sorting the build offsets (-1, -10, -2, -3...).
4264
4265         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
4266
4267         Reviewed by Darin Adler.
4268
4269         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
4270         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
4271         callback.
4272
4273 2011-03-14  Adam Roben  <aroben@apple.com>
4274
4275         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
4276
4277         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
4278         analyze
4279
4280         Reviewed by David Kilzer and Joe Pecoraro.
4281
4282         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
4283         (#url-prompt): Made this a bit taller to make room for the list of builds.
4284
4285         (#recent-builds-loading-indicator):
4286         (#recent-builds-list):
4287         Added styles for the build list and loading indicator.
4288
4289         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
4290         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
4291         it. This will unescape it.
4292         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
4293         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
4294         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
4295         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
4296         prompt UI.
4297         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
4298         now also used when a recent build is clicked.
4299
4300         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
4301         (RecentBuildsLoader): Store the callback.
4302         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
4303         builder. Find the revision number, leak count, and results URL for each one. Pass the
4304         resulting info to our callback.
4305
4306         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
4307         (range): Added this helper function to return an array containing the integers [0, n).
4308
4309         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
4310         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
4311
4312 2011-03-14  Mark Rowe  <mrowe@apple.com>
4313
4314         Reviewed by Adam Roben.
4315
4316         Fix two memory leaks within LayoutTestController's storage support.
4317
4318         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4319         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
4320         by JSStringCreateWithCFString.
4321         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
4322         allocate.
4323
4324 2011-03-14  Mark Rowe  <mrowe@apple.com>
4325
4326         Reviewed by Oliver Hunt.
4327
4328         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
4329
4330         * DumpRenderTree/LayoutTestController.cpp:
4331         (LayoutTestController::staticFunctions): Remove duplicate entries.
4332
4333 2011-03-14  Alice Liu  <alice.liu@apple.com>
4334
4335         Reviewed by Dan Bernstein.
4336
4337         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
4338
4339         * DumpRenderTree/mac/PerlSupport/Makefile:
4340         Add whitespace when joining "-arch" with the architectures passed in as arguments.
4341
4342 2011-03-14  Daniel Bates  &