9787a510578a7807bd97d1ba82a3545b8ac0ebee
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-11  Julie Parent  <jparent@chromium.org>
2
3         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
4         https://bugs.webkit.org/show_bug.cgi?id=106247
5
6         Old code nulled out the loader instance when it completed loading and
7         then later used the fact that it was null to determine if it had loaded
8         or not.  This is not only unintuitive, but it also prevents using the
9         loader object later on.
10         
11         Added new method, used it, added unit test for it.
12         
13         Reviewed by Dirk Pranke.
14
15         * TestResultServer/static-dashboards/dashboard_base.js:
16         (resourceLoadingComplete):
17         (handleLocationChange):
18         * TestResultServer/static-dashboards/loader.js:
19         (.):
20         * TestResultServer/static-dashboards/loader_unittests.js:
21
22 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
23
24         Try CRLF to LF change in r139407 again.
25
26         * BuildSlaveSupport/delete-stale-build-files:
27         (main):
28         (webkitBuildDirectory):
29         * BuildSlaveSupport/kill-old-processes:
30         (main):
31
32 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
33
34         [GTK] Disable the unit tests timeout when running from make check
35         https://bugs.webkit.org/show_bug.cgi?id=106670
36
37         Reviewed by Philippe Normand.
38
39         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
40
41 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
42
43         Yet another unreviewed fix after r139431.
44
45         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
46         the correct order.
47
48 2013-01-11  Dan Carney  <dcarney@google.com>
49
50         [chromium] move some whitespace and resize related methods to TestRunner library
51         https://bugs.webkit.org/show_bug.cgi?id=106655
52
53         Reviewed by Jochen Eisinger.
54
55         * DumpRenderTree/chromium/DRTTestRunner.cpp:
56         (DRTTestRunner::DRTTestRunner):
57         * DumpRenderTree/chromium/DRTTestRunner.h:
58         (DRTTestRunner):
59         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
60         (WebKit):
61         (WebTestRunner::WebTestDelegate::setClientWindowRect):
62         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
63         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
64         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
65         (WebTestRunner::TestRunner::TestRunner):
66         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
67         (WebTestRunner):
68         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
69         (WebTestRunner::TestRunner::enableAutoResizeMode):
70         (WebTestRunner::TestRunner::disableAutoResizeMode):
71         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
72         (TestRunner):
73         * DumpRenderTree/chromium/WebViewHost.cpp:
74         (WebViewHost::setClientWindowRect):
75         * DumpRenderTree/chromium/WebViewHost.h:
76         (WebViewHost):
77
78 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
79
80         Unreviewed. Update my e-mail addresses.
81
82         * Scripts/webkitpy/common/config/committers.py:
83
84 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
85
86         Another unreviewed fix after r139431.
87
88         In a way, this is also a generic bug fix, since previously isEfl()
89         would fail when called from run-efl-tests and we thus did not use
90         jhbuild to run our tests. This now resulted in us calling
91         "jhbuild-wrapper run" without specifying a platform.
92
93         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
94         to work.
95
96 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
97
98         [Qt][WK1] Web Audio support
99         https://bugs.webkit.org/show_bug.cgi?id=106651
100
101         Reviewed by Jocelyn Turcotte.
102
103         Implements support for dumping audio data in DumpRenderTree.
104
105         Adds WebAudio to toggleable features in QtTestBrowser.
106
107         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
108         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
109
110         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
111         (WebCore::DumpRenderTree::dump):
112         * DumpRenderTree/qt/TestRunnerQt.cpp:
113         (TestRunner::reset):
114         (TestRunner::overridePreference):
115         (TestRunner::setAudioData):
116         * DumpRenderTree/qt/TestRunnerQt.h:
117         (TestRunner::shouldDumpAsAudio):
118         (TestRunner::audioData):
119         (TestRunner):
120         * QtTestBrowser/launcherwindow.cpp:
121         (LauncherWindow::applyPrefs):
122         (LauncherWindow::createChrome):
123         (LauncherWindow::toggleWebAudio):
124         * QtTestBrowser/launcherwindow.h:
125         (WindowOptions::WindowOptions):
126         (WindowOptions):
127         (LauncherWindow):
128         * qmake/mkspecs/features/features.prf:
129         * qmake/mkspecs/features/features.pri:
130
131 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
132
133         Unreviewed jhbuild-related fix after r139431.
134
135         * Scripts/webkitpy/layout_tests/port/efl.py:
136         (EflPort.__init__): Pass a string to set_option_default(), since
137         shlex.split() will be called on it later.
138
139 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
140
141         Unreviewed typo fixes after r139431.
142
143         * Scripts/run-javascriptcore-tests:
144
145 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
146
147         [jhbuild] Remove the "run-with-jhbuild" scripts.
148         https://bugs.webkit.org/show_bug.cgi?id=106572
149
150         Reviewed by Martin Robinson.
151
152         Both ports which use jhbuild were mostly duplicating the
153         `run-with-jhbuild' script in their own directories for no clear reason.
154
155         The script itself was just a thin wrapper around the `jhbuild-wrapper',
156         so just start using that directly and get rid of a useless middle man.
157
158         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
159         instead.
160
161         * Scripts/run-javascriptcore-tests:
162         * Scripts/run-launcher:
163         * Scripts/webkitdirs.pm:
164         (runAutogenForAutotoolsProjectIfNecessary):
165         (buildAutotoolsProject):
166         (jhbuildWrapperPrefixIfNeeded):
167         (generateBuildSystemFromCMakeProject):
168         (buildCMakeGeneratedProject):
169         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
170         (run):
171         * Scripts/webkitpy/layout_tests/port/efl.py:
172         (EflPort.__init__):
173         (EflPort._image_diff_command):
174         * efl/run-with-jhbuild: Removed.
175         * gtk/run-with-jhbuild: Removed.
176
177 2013-01-11  Alan Cutter  <alancutter@chromium.org>
178
179         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
180         https://bugs.webkit.org/show_bug.cgi?id=106636
181
182         Reviewed by Adam Barth.
183
184         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
185
186         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
187         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
188         * EWSTools/screen-config:
189         * EWSTools/start-queue.sh:
190
191 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
192
193         kill-old-processes and delete-stale-build-files use CRLF linebreaks
194         https://bugs.webkit.org/show_bug.cgi?id=106622
195
196         Reviewed by Simon Fraser.
197
198         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
199         Also escape clang\+\+ correctly in kill-old-processes.
200
201         * BuildSlaveSupport/delete-stale-build-files:
202         * BuildSlaveSupport/kill-old-processes:
203
204 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
205
206         Build fix after r139357. It was missing a comma.
207
208         * QueueStatusServer/model/queues.py:
209         (Queue):
210
211 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
212
213         Fixing AuthenticationError when running test-webkitpy as a non-committer.
214         https://bugs.webkit.org/show_bug.cgi?id=106420
215
216         Reviewed by Eric Seidel.
217
218         * Scripts/webkitpy/common/checkout/scm/git.py:
219         (Git.push_local_commits_to_server):
220         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
221         * Scripts/webkitpy/common/checkout/scm/svn.py:
222         (SVNRepository):
223         (SVNRepository.has_authorization_for_realm):
224
225 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
226
227         [EFL][jhbuild] Use tarballs for gstreamer instead of git
228         https://bugs.webkit.org/show_bug.cgi?id=106552
229
230         Reviewed by Laszlo Gombos.
231
232         Use tarballs for gstreamer instead of git in EFL's jhbuild
233         to work around intermittent network issues on our build
234         bots. Tarballs are fully cached and require no network
235         operation if their checksum matches.
236
237         * efl/jhbuild.modules:
238
239 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
240
241         Add Mac WK2 EWS bots
242         https://bugs.webkit.org/show_bug.cgi?id=106590
243
244         Reviewed by Adam Barth.
245
246         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
247         Also add a deprecated MacWK2Port class.
248
249         * QueueStatusServer/model/queues.py:
250         (Queue):
251         * Scripts/webkitpy/common/config/ports.py:
252         (DeprecatedPort.port):
253         (MacWK2Port):
254         (MacWK2Port.run_webkit_tests_command):
255         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
256         (MacEWS):
257         (MacWK2EWS):
258         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
259         (_test_ewses):
260
261 2013-01-10  Dan Carney  <dcarney@google.com>
262
263         [chromium] move webpermissionclient related methods to TestRunner library
264         https://bugs.webkit.org/show_bug.cgi?id=106548
265
266         Reviewed by Jochen Eisinger.
267
268         * DumpRenderTree/DumpRenderTree.gypi:
269         * DumpRenderTree/chromium/DRTTestRunner.cpp:
270         (DRTTestRunner::DRTTestRunner):
271         (DRTTestRunner::reset):
272         * DumpRenderTree/chromium/DRTTestRunner.h:
273         (DRTTestRunner):
274         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
275         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
276         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
277         (WebKit):
278         (WebTestRunner::WebTestRunner::webPermissions):
279         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
280         (WebTestRunner::TestRunner::TestRunner):
281         (WebTestRunner::TestRunner::setDelegate):
282         (WebTestRunner):
283         (WebTestRunner::TestRunner::reset):
284         (WebTestRunner::TestRunner::webPermissions):
285         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
286         (WebTestRunner::TestRunner::setImagesAllowed):
287         (WebTestRunner::TestRunner::setScriptsAllowed):
288         (WebTestRunner::TestRunner::setStorageAllowed):
289         (WebTestRunner::TestRunner::setPluginsAllowed):
290         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
291         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
292         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
293         (WebTestRunner):
294         (TestRunner):
295         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
296         (WebTestRunner):
297         (WebTestRunner::WebPermissions::WebPermissions):
298         (WebTestRunner::WebPermissions::~WebPermissions):
299         (WebTestRunner::WebPermissions::allowImage):
300         (WebTestRunner::WebPermissions::allowScriptFromSource):
301         (WebTestRunner::WebPermissions::allowStorage):
302         (WebTestRunner::WebPermissions::allowPlugins):
303         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
304         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
305         (WebTestRunner::WebPermissions::setImagesAllowed):
306         (WebTestRunner::WebPermissions::setScriptsAllowed):
307         (WebTestRunner::WebPermissions::setStorageAllowed):
308         (WebTestRunner::WebPermissions::setPluginsAllowed):
309         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
310         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
311         (WebTestRunner::WebPermissions::setDelegate):
312         (WebTestRunner::WebPermissions::setDumpCallbacks):
313         (WebTestRunner::WebPermissions::reset):
314         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
315         (WebTestRunner):
316         (WebPermissions):
317         * DumpRenderTree/chromium/TestShell.cpp:
318         (TestShell::initialize):
319         (TestShell::resetTestController):
320         (TestShell::createNewWindow):
321         * DumpRenderTree/chromium/TestShell.h:
322         (TestShell):
323         * DumpRenderTree/chromium/WebViewHost.cpp:
324         (WebViewHost::normalizeLayoutTestURL):
325         * DumpRenderTree/chromium/WebViewHost.h:
326         (WebViewHost):
327
328 2013-01-10  Alan Cutter  <alancutter@chromium.org>
329
330         Split EWS tool cold-boot.sh into modular components
331         https://bugs.webkit.org/show_bug.cgi?id=106527
332
333         Reviewed by Adam Barth.
334
335         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
336         Updated GCE bot build scripts to match.
337         Unable to test scripts directly as they depend on being in the repository to work!
338
339         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
340         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
341         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
342         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
343         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
344
345 2013-01-10  Julie Parent  <jparent@chromium.org>
346
347         Dashboard Cleanup: Do not generate the page if we are about to reload.
348         https://bugs.webkit.org/show_bug.cgi?id=106584
349
350         Reviewed by Dirk Pranke.
351
352         Move the logic to determine if we should generate the page into
353         parseParameters() since that is where we have the knowledge to
354         determine it, and return that value to handleLocationChange, 
355         rather than passing the changed parameters back to handleLocationChange
356         and having it make the decision.
357         
358         This is logically equivalent, save one case: when we are about to do
359         a reload, we know that there is no reason to generate the page.  Old
360         code was causing an extra page generation in this case.
361         
362         * TestResultServer/static-dashboards/dashboard_base.js:
363         (parseParameters):
364         (handleLocationChange):
365
366 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
367
368         [jhbuild] Use the "configure" script to build glib
369         https://bugs.webkit.org/show_bug.cgi?id=106569
370
371         Reviewed by Martin Robinson.
372
373         So far both EFL and GTK have been using autogen.sh to build glib.
374         While that does work most of the time, it's not really needed since
375         we are downloading and building stable releases from tarballs.
376         Additionally, autogen.sh fails to work with automake 1.13 due to the
377         usage of some macros that have been removed (this has already been
378         fixed in glib master).
379
380         * efl/jhbuild.modules:
381         * gtk/jhbuild.modules:
382
383 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
384
385         Changing tests to be consistent and use self.scm rather then recreating the scm object.
386         (Missed a couple)
387         https://bugs.webkit.org/show_bug.cgi?id=106536
388
389         Reviewed by Eric Seidel.
390
391         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
392
393 2013-01-10  Tony Chang  <tony@chromium.org>
394
395         Speed up supplemental dependency computation
396         https://bugs.webkit.org/show_bug.cgi?id=106503
397
398         Reviewed by Adam Barth.
399
400         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
401
402         * WebKitTestRunner/CMakeLists.txt:
403
404 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
405
406         Remove the ENABLE_ANIMATION_API feature define occurences
407         https://bugs.webkit.org/show_bug.cgi?id=106544
408
409         Reviewed by Simon Fraser.
410
411         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
412         feature define handling still lingers in various build systems and configurations
413         but is of no use, so it should be removed.
414
415         * Scripts/webkitperl/FeatureList.pm:
416         * qmake/mkspecs/features/features.pri:
417
418 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
419
420         [GTK] Add support for loading web process extensions
421         https://bugs.webkit.org/show_bug.cgi?id=105631
422
423         Reviewed by Gustavo Noronha Silva.
424
425         * MiniBrowser/gtk/GNUmakefile.am:
426         * MiniBrowser/gtk/main.c:
427         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
428         bundle lib from build dir.
429         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
430         located in WebProcess/InjectedBundle/API/gtk.
431         * gtk/generate-gtkdoc:
432         (get_webkit2_options): Scan also files in
433         WebProcess/InjectedBundle/API/gtk to generate API docs.
434         (get_webkit2_options.injected_bundle_src_path): Helper function to
435         build paths in WebProcess/InjectedBundle/API/gtk.
436
437 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
438
439         [EFL][WK2] Writing immediately to created windows (open) fails
440         https://bugs.webkit.org/show_bug.cgi?id=105276
441
442         Reviewed by Kenneth Rohde Christiansen.
443
444         Do not reset 'about:blank' url for the new pages in mini browser.
445
446         * MiniBrowser/efl/main.c:
447         (window_create):
448
449 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
450
451         Changing tests to be consistent and use self.scm rather then recreating the scm object.
452         https://bugs.webkit.org/show_bug.cgi?id=106536
453
454         Reviewed by Eric Seidel.
455
456         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
457
458 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
459
460         Converting to unittest2 so we can use assertItemsEqual, making tests
461         not dependent on order of items.
462         https://bugs.webkit.org/show_bug.cgi?id=106532
463
464         Before:
465         Ran 1733 tests in 38.385s
466         FAILED (failures=1, errors=22)
467
468         After:
469         Ran 1733 tests in 32.298s
470         FAILED (failures=0, errors=22)
471
472         Reviewed by Eric Seidel.
473
474         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
475         * Scripts/webkitpy/thirdparty/__init__.py:
476         (AutoinstallImportHook._install_unittest2):
477
478 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
479
480         [EFL] Add gstreamer 1.0.5 to jhbuild
481         https://bugs.webkit.org/show_bug.cgi?id=106178
482
483         Reviewed by Laszlo Gombos.
484
485         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
486
487         * efl/jhbuild.modules:
488
489 2013-01-09  Alan Cutter  <alancutter@chromium.org>
490
491         Updated parameters in GCE build scripts so they now work.
492         https://bugs.webkit.org/show_bug.cgi?id=106523
493
494         Reviewed by Adam Barth.
495
496         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
497         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
498         * EWSTools/cold-boot.sh:
499
500 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
501
502         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
503         https://bugs.webkit.org/show_bug.cgi?id=106520
504
505         Reviewed by James Robinson.
506
507         Part of a larger refactoring series. See tracking bug 82948.
508
509         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
510         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
511
512 2013-01-09  Julie Parent  <jparent@chromium.org>
513
514         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
515         https://bugs.webkit.org/show_bug.cgi?id=106514
516
517         This is old code, as these can no longer get out of sync.
518         permmaLinkURLHash is generated from currentState, which is set only
519         from the location.  The commment about how these can get out of sync
520         refers to a function that no longer exists.
521         
522         Reviewed by Dirk Pranke.
523
524         * TestResultServer/static-dashboards/dashboard_base.js:
525         (handleLocationChange):
526
527 2013-01-09  Julie Parent  <jparent@chromium.org>
528
529         Dashboard Cleanup: Reload the page as soon as we know we need to.
530         https://bugs.webkit.org/show_bug.cgi?id=106515
531
532         No need to continue parsing all of the data once we know that
533         we need to do a reload.
534         
535         Reviewed by Dirk Pranke.
536
537         * TestResultServer/static-dashboards/dashboard_base.js:
538         (parseParameters):
539
540 2013-01-09  Eric Seidel  <eric@webkit.org>
541
542         run-perf-tests --chromium-android --profile should show symbols for the kernel
543         https://bugs.webkit.org/show_bug.cgi?id=106498
544
545         Reviewed by Adam Barth.
546
547         Turns out this was easy, once I finally read the output from "perf report".
548         It appears there may be a bug in "perf record" on android, as it complains
549         about not being able to read from /proc/kallsyms even when
550         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
551         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
552         but rather just flip it to 0 long enough to grab the /proc/kallsyms
553         and then flip it back to whatever the device had.
554
555         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
556         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
557         to symbol names.  Its world-readable, but will return all 0s if you
558         don't have permission to see the kernel symbols.  kptr_restrict
559         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
560         1 is only a specific group, and 2 is "no one, not even root".
561         By default kptr_restrict is 2 on Android it seems.
562         More kptr_restrict docs: http://lwn.net/Articles/420403/
563
564         I also took this opportunity to clean up how the perf record command
565         was built for use/display in AndroidPerf.profile_after_exit and
566         change to always using long-form names for the arguments (to hopefully help readability).
567
568         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
569         (AndroidPerf.__init__):
570         (profile_after_exit):
571         (ChromiumAndroidDriver.__init__):
572         (ChromiumAndroidDriver._update_kallsyms_cache):
573         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
574
575 2013-01-09  Julie Parent  <jparent@chromium.org>
576
577         Dashboard cleanup: remove dead code.
578         https://bugs.webkit.org/show_bug.cgi?id=106509
579
580         Reviewed by Dirk Pranke.
581
582         * TestResultServer/static-dashboards/dashboard_base.js:
583         (parseParameters):
584
585 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
586
587         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
588         https://bugs.webkit.org/show_bug.cgi?id=105638
589
590         Reviewed by Martin Robinson.
591
592         The test was failing for two reasons:
593         - AccessibilityRenderObject::correspondingLabelForControlElement() was
594           not ignoring the ARIA labelled-by property
595         - AccessibilityController::accessibleElementById() was not implemented
596
597         Because getting an element by ID cannot be done in the UIProcess, the
598         decision was made to expose the element's ID as an accessible attribute
599         of the object.
600
601         In addition, fixing the bug in AccessibilityRenderObject made it possible
602         to eliminate the Gtk platform-specific expectations for another test.
603
604         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
605         (childElementById): Added. Walks the tree looking for the AtkObject
606         Attribute which exposes the HTML element's ID.
607         (AccessibilityController::accessibleElementById): Implemented.
608         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
609         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
610         when there is no title, as is done with the Mac port.
611         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
612         (WTR):
613         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
614         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
615         Attribute which exposes the HTML element's ID.
616         (WTR):
617         (WTR::AccessibilityController::accessibleElementById): Implemented.
618         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
619         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
620         even when there is no title, as is done with the Mac port.
621
622 2013-01-09  Gregg Tavares  <gman@google.com>
623
624         Add Gregg Tavares as a committer
625         https://bugs.webkit.org/show_bug.cgi?id=106492
626
627         Unreviewed.
628
629         * Scripts/webkitpy/common/config/committers.py:
630
631 2013-01-09  Roger Fong  <roger_fong@apple.com>
632
633         Enable seamless iFrames for Windows DRT.
634         https://bugs.webkit.org/show_bug.cgi?id=106468.
635
636         Rubberstamped by Timothy Horton.
637
638         * DumpRenderTree/win/DumpRenderTree.cpp:
639         (resetDefaultsToConsistentValues):
640
641 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
642
643         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
644         https://bugs.webkit.org/show_bug.cgi?id=93979
645
646         Reviewed by Benjamin Poulain.
647
648         Implement eventSender.scheduleAsynchronousKeyDown() in
649         WebKitTestRunner.
650
651         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
652         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
653         (WTR::createKeyDownMessageBody):
654         (WTR::EventSendingController::keyDown):
655         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
656         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
657         (EventSendingController):
658         * WebKitTestRunner/TestController.cpp:
659         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
660         (WTR::TestController::didReceiveMessageFromInjectedBundle):
661         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
662         * WebKitTestRunner/TestController.h:
663         (TestController):
664
665 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
666
667         [chromium] move resource load callback dumping to TestRunner library
668         https://bugs.webkit.org/show_bug.cgi?id=106449
669
670         Reviewed by Adam Barth.
671
672         * DumpRenderTree/chromium/DRTTestRunner.cpp:
673         (DRTTestRunner::DRTTestRunner):
674         (DRTTestRunner::reset):
675         * DumpRenderTree/chromium/DRTTestRunner.h:
676         (DRTTestRunner):
677         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
678         (WebKit):
679         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
680         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
681         (WebKit):
682         (WebTestProxyBase):
683         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
684         (WebTestRunner::WebTestProxy::willRequestResource):
685         (WebTestRunner::WebTestProxy::willSendRequest):
686         (WebTestRunner::WebTestProxy::didReceiveResponse):
687         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
688         (WebTestRunner::WebTestProxy::didFailResourceLoad):
689         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
690         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
691         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
692         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
693         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
694         (WebTestRunner::TestRunner::TestRunner):
695         (WebTestRunner::TestRunner::reset):
696         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
697         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
698         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
699         (WebTestRunner):
700         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
701         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
702         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
703         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
704         (TestRunner):
705         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
706         (WebTestRunner::WebTestProxyBase::reset):
707         (WebTestRunner):
708         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
709         (WebTestRunner::WebTestProxyBase::willRequestResource):
710         (WebTestRunner::WebTestProxyBase::willSendRequest):
711         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
712         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
713         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
714         * DumpRenderTree/chromium/WebViewHost.cpp:
715         (WebViewHost::willSendRequest):
716         (WebViewHost::makeURLErrorDescription):
717         (WebViewHost::reset):
718         * DumpRenderTree/chromium/WebViewHost.h:
719         (WebViewHost):
720
721 2013-01-09  Dan Carney  <dcarney@google.com>
722
723         [chromium] move dumpcreateview methods to testrunner library
724         https://bugs.webkit.org/show_bug.cgi?id=106434
725
726         Reviewed by Adam Barth.
727
728         * DumpRenderTree/chromium/DRTTestRunner.cpp:
729         (DRTTestRunner::DRTTestRunner):
730         (DRTTestRunner::reset):
731         * DumpRenderTree/chromium/DRTTestRunner.h:
732         (DRTTestRunner):
733         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
734         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
735         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
736         (WebTestRunner::TestRunner::TestRunner):
737         (WebTestRunner::TestRunner::reset):
738         (WebTestRunner::TestRunner::shouldDumpCreateView):
739         (WebTestRunner):
740         (WebTestRunner::TestRunner::dumpCreateView):
741         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
742         (TestRunner):
743
744 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
745
746         webkitpy cleanup: Merge additional_comment_text into comment_text
747         https://bugs.webkit.org/show_bug.cgi?id=106421
748
749         Reviewed by Adam Barth.
750
751         * Scripts/webkitpy/common/config/committervalidator.py:
752         (CommitterValidator.reject_patch_from_commit_queue):
753         (CommitterValidator.reject_patch_from_review_queue):
754         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
755         (Bugzilla.set_flag_on_attachment):
756         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
757         (MockBugzilla.set_flag_on_attachment):
758         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
759         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
760         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
761         * Scripts/webkitpy/tool/commands/queues_unittest.py:
762
763 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
764
765         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
766         https://bugs.webkit.org/show_bug.cgi?id=106464
767
768         Reviewed by Martin Robinson.
769
770         Current version in jhbuild.modules (2.26.0) is giving trouble to
771         when trying to build WebKitGTK from scratch, due to a segmentation
772         fault error in gdk-pixbuf-query-loader during the 'make'
773         phase. Raising the version to 2.26.5 fixes this issue.
774
775         * gtk/jhbuild.modules: Version raised, checksums updated.
776
777 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
778
779         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
780         https://bugs.webkit.org/show_bug.cgi?id=90968.
781
782         Reviewed by Csaba Osztrogonác.
783
784         Added functionality in DRT and WTR to use any timeout value while running
785         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
786         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
787         to indicate whether the current port supports setting timeout value
788         per test (it's False by default; I enabled it only on Qt).
789         Also corrected a typo in driver.py
790
791         * DumpRenderTree/DumpRenderTree.h:
792         (TestCommand::TestCommand):
793         (TestCommand):
794         * DumpRenderTree/DumpRenderTreeCommon.cpp:
795         (parseInputLine):
796         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
797         (WebCore::DumpRenderTree::processLine):
798         * Scripts/webkitpy/layout_tests/port/base.py:
799         (Port.supports_per_test_timeout):
800         * Scripts/webkitpy/layout_tests/port/driver.py:
801         (Driver.run_test):
802         (Driver._command_from_driver_input):
803         * Scripts/webkitpy/layout_tests/port/qt.py:
804         (QtPort.supports_per_test_timeout):
805         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
806         (WTR::InjectedBundle::InjectedBundle):
807         (WTR::InjectedBundle::didReceiveMessage):
808         (WTR::InjectedBundle::beginTesting):
809         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
810         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
811         (WTR::TestRunner::setCustomTimeout):
812         (WTR):
813         * WebKitTestRunner/InjectedBundle/TestRunner.h:
814         (TestRunner):
815         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
816         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
817         * WebKitTestRunner/TestController.cpp:
818         (WTR::TestController::TestController):
819         (WTR::TestController::getCustomTimeout):
820         (WTR):
821         (WTR::TestCommand::TestCommand):
822         (TestCommand):
823         (WTR::parseInputLine):
824         (WTR::TestController::runTest):
825         (WTR::TestController::runUntil):
826         * WebKitTestRunner/TestController.h:
827         (TestController):
828         * WebKitTestRunner/TestInvocation.cpp:
829         (WTR::TestInvocation::TestInvocation):
830         (WTR::TestInvocation::setCustomTimeout):
831         (WTR):
832         (WTR::TestInvocation::invoke):
833         * WebKitTestRunner/TestInvocation.h:
834         (TestInvocation):
835
836 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
837
838         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
839         https://bugs.webkit.org/show_bug.cgi?id=106290
840
841         Reviewed by Martin Robinson.
842
843         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
844         the macro isn't enabled.
845
846         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
847
848 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
849
850         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
851         https://bugs.webkit.org/show_bug.cgi?id=103653
852
853         Reviewed by Anders Carlsson.
854
855         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
856         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
857         client callback.
858
859         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
860         methods to the JavaScript API.
861         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
862         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
863         (WTR::TestRunner::setAuthenticationUsername): Ditto.
864         (WTR::TestRunner::setAuthenticationPassword): Ditto.
865         * WebKitTestRunner/InjectedBundle/TestRunner.h:
866         (TestRunner): Added new declarations for the above.
867         * WebKitTestRunner/TestController.cpp:
868         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
869         callback.
870         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
871         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
872         the authentication information passed from the InjectedBundle.
873         * WebKitTestRunner/TestController.h:
874         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
875         to communicate with the TestController.
876         (WTR::TestController::setAuthenticationUsername): Ditto.
877         (WTR::TestController::setAuthenticationPassword): Ditto.
878         (TestController):
879         * WebKitTestRunner/TestInvocation.cpp:
880         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
881         information from the InjectedBundle.
882         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
883         text to the TestInvocation text output.
884         * WebKitTestRunner/TestInvocation.h:
885         (TestInvocation): Added declaration for new method.
886
887 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
888
889         Add myself as a watcher for Web Geolocation
890
891         Unreviewed.
892
893         * Scripts/webkitpy/common/config/watchlist:
894
895 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
896
897         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
898         https://bugs.webkit.org/show_bug.cgi?id=106364
899
900         Reviewed by Eric Seidel.
901
902         When the setup_test_run method is called on the subclasses of the base Port
903         interface, the parent method should also be called via super(), despite the
904         parent method not doing anything at the moment.
905
906         The according calls to super() are required in the ChromiumPort, EflPort
907         and GtkPort implementations.
908
909         * Scripts/webkitpy/layout_tests/port/chromium.py:
910         (ChromiumPort.setup_test_run):
911         * Scripts/webkitpy/layout_tests/port/efl.py:
912         (EflPort.setup_test_run):
913         * Scripts/webkitpy/layout_tests/port/gtk.py:
914         (GtkPort.setup_test_run):
915
916 2013-01-08  Julie Parent  <jparent@chromium.org>
917
918         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
919         https://bugs.webkit.org/show_bug.cgi?id=106356
920
921         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
922         dashboard_base, assigned by Loader, and used only by dashboard_base to
923         create error messages.  Moved the variables to be privates on the Loader
924         object, moved error message creation to _getLoadingErrorMessages on the
925         Loader object, and now pass the errors back to dashboard base via the
926         resourceLoadingComplete callback.
927         
928         Also removed the now unused clearError function, it was only being used
929         by unit tests to clean up global state.
930         
931         Reviewed by Dirk Pranke.
932
933         * TestResultServer/static-dashboards/dashboard_base.js:
934         (resourceLoadingComplete):
935         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
936         * TestResultServer/static-dashboards/loader.js:
937         (.):
938         * TestResultServer/static-dashboards/loader_unittests.js:
939
940 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
941
942         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
943         https://bugs.webkit.org/show_bug.cgi?id=106354
944
945         Reviewed by Eric Seidel.
946
947         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
948         instead of those two inheriting from it. Also add a mock object of the
949         sanitizer that's used in unit tests.
950
951         * Scripts/webkitpy/layout_tests/port/efl.py:
952         (EflPort):
953         (EflPort.__init__):
954         (EflPort.setup_test_run):
955         (EflPort.clean_up_test_run):
956         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
957         importing order.
958         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
959         * Scripts/webkitpy/layout_tests/port/gtk.py:
960         (GtkPort):
961         (GtkPort.__init__):
962         (GtkPort.setup_test_run):
963         (GtkPort.clean_up_test_run):
964         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
965         importing order.
966         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
967         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
968         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
969         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
970         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
971         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
972         (PulseAudioSanitizerMock.unload_pulseaudio_module):
973         (PulseAudioSanitizerMock.restore_pulseaudio_module):
974
975 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
976
977         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
978         https://bugs.webkit.org/show_bug.cgi?id=106324
979
980         Reviewed by Adam Barth.
981
982         Since the frame load callbacks are part of the WebFrameClient, the
983         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
984         methods.
985
986         * DumpRenderTree/chromium/DRTTestRunner.cpp:
987         (DRTTestRunner::DRTTestRunner):
988         (DRTTestRunner::reset):
989         * DumpRenderTree/chromium/DRTTestRunner.h:
990         (DRTTestRunner):
991         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
992         (WebTestInterfaces):
993         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
994         (WebKit):
995         (WebTestProxyBase):
996         (WebTestRunner):
997         (WebTestRunner::WebTestProxy::WebTestProxy):
998         (WebTestProxy):
999         (WebTestRunner::WebTestProxy::didInvalidateRect):
1000         (WebTestRunner::WebTestProxy::didScrollRect):
1001         (WebTestRunner::WebTestProxy::scheduleComposite):
1002         (WebTestRunner::WebTestProxy::scheduleAnimation):
1003         (WebTestRunner::WebTestProxy::setWindowRect):
1004         (WebTestRunner::WebTestProxy::show):
1005         (WebTestRunner::WebTestProxy::didAutoResize):
1006         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
1007         (WebTestRunner::WebTestProxy::startDragging):
1008         (WebTestRunner::WebTestProxy::shouldBeginEditing):
1009         (WebTestRunner::WebTestProxy::shouldEndEditing):
1010         (WebTestRunner::WebTestProxy::shouldInsertNode):
1011         (WebTestRunner::WebTestProxy::shouldInsertText):
1012         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
1013         (WebTestRunner::WebTestProxy::shouldDeleteRange):
1014         (WebTestRunner::WebTestProxy::shouldApplyStyle):
1015         (WebTestRunner::WebTestProxy::didBeginEditing):
1016         (WebTestRunner::WebTestProxy::didChangeSelection):
1017         (WebTestRunner::WebTestProxy::didChangeContents):
1018         (WebTestRunner::WebTestProxy::didEndEditing):
1019         (WebTestRunner::WebTestProxy::registerIntentService):
1020         (WebTestRunner::WebTestProxy::dispatchIntent):
1021         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
1022         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
1023         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
1024         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
1025         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
1026         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
1027         (WebTestRunner::WebTestProxy::didReceiveTitle):
1028         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
1029         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
1030         (WebTestRunner::WebTestProxy::didFailLoad):
1031         (WebTestRunner::WebTestProxy::didFinishLoad):
1032         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
1033         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
1034         (WebTestRunner::WebTestProxy::didRunInsecureContent):
1035         (WebTestRunner::WebTestProxy::didDetectXSS):
1036         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1037         (WebTestRunner::WebTestRunner::setTestIsRunning):
1038         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
1039         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
1040         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
1041         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
1042         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
1043         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1044         (WebTestRunner::TestRunner::TestRunner):
1045         (WebTestRunner::TestRunner::reset):
1046         (WebTestRunner::TestRunner::setTestIsRunning):
1047         (WebTestRunner):
1048         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
1049         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
1050         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
1051         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
1052         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
1053         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
1054         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
1055         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
1056         (WebTestRunner::TestRunner::dumpTitleChanges):
1057         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1058         (TestRunner):
1059         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1060         (WebTestInterfaces::Internal):
1061         (WebTestRunner::WebTestInterfaces::Internal::webView):
1062         (WebTestRunner::WebTestInterfaces::Internal::Internal):
1063         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
1064         (WebTestRunner):
1065         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
1066         (WebTestRunner::WebTestInterfaces::setWebView):
1067         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
1068         (WebTestRunner::WebTestInterfaces::webView):
1069         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1070         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
1071         (WebTestRunner):
1072         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
1073         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
1074         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
1075         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
1076         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
1077         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1078         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
1079         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
1080         (WebTestRunner::WebTestProxyBase::didFailLoad):
1081         (WebTestRunner::WebTestProxyBase::didFinishLoad):
1082         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
1083         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
1084         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
1085         (WebTestRunner::WebTestProxyBase::didDetectXSS):
1086         * DumpRenderTree/chromium/TestShell.cpp:
1087         (TestShell::runFileTest):
1088         (TestShell::testFinished):
1089         * DumpRenderTree/chromium/TestShell.h:
1090         (TestShell):
1091         * DumpRenderTree/chromium/WebViewHost.cpp:
1092         (WebViewHost::didStartProvisionalLoad):
1093         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
1094         (WebViewHost::didFailProvisionalLoad):
1095         (WebViewHost::didCommitProvisionalLoad):
1096         (WebViewHost::didReceiveTitle):
1097         (WebViewHost::didFailLoad):
1098         (WebViewHost::didFinishLoad):
1099         * DumpRenderTree/chromium/WebViewHost.h:
1100         (WebViewHost):
1101
1102 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1103
1104         [GTK] Lower the default timeout value for WebKitTestRunner
1105         https://bugs.webkit.org/show_bug.cgi?id=106353
1106
1107         Reviewed by Dirk Pranke.
1108
1109         The default timeout value for WebKitTestRunner should be lowered.
1110         The current value (80 seconds) is irrational and just leads to producing
1111         text failures for layout tests that genuinely time out. This just leads
1112         to more deviation from the GTK WK1 port in terms of test expectations.
1113
1114         The value used is the same as when running the DumpRenderTree, that's
1115         6 seconds in release builds and 12 seconds in debug builds.
1116
1117         * Scripts/webkitpy/layout_tests/port/gtk.py:
1118         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1119         (GtkPortTest.test_default_timeout_ms):
1120
1121 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1122
1123         test-webkitpy shows failure output on my linux box
1124         https://bugs.webkit.org/show_bug.cgi?id=101261
1125
1126         Reviewed by Eric Seidel.
1127
1128         Mock out the PulseAudioSanitizer methods when creating testing instances
1129         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
1130         PulseAudio output when the sanitizer was trying to unload modules which
1131         were already unloaded by another unit test that was being run in parallel.
1132
1133         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1134         (EflPortTest):
1135         (EflPortTest.make_port):
1136         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1137         (GtkPortTest):
1138         (GtkPortTest.make_port):
1139
1140 2013-01-08  Julie Parent  <jparent@chromium.org>
1141
1142         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
1143         https://bugs.webkit.org/show_bug.cgi?id=106254
1144
1145         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
1146         only to figure out if we should call addBuilderLoadErrors during
1147         handleLocationChange, which was called when the loader completed and on
1148         any hash change, but we only ever wanted to call addBuilderLoadErrors
1149         on the initial loader load.  Moved the call of addBuilderLoadErrors to
1150         resourceLoadingComplete rather than handleLocationChange, so now we
1151         only call it when we want to, and the check can go away completely.
1152
1153         Reviewed by Dirk Pranke.
1154
1155         * TestResultServer/static-dashboards/dashboard_base.js:
1156         (addBuilderLoadErrors):
1157         (resourceLoadingComplete):
1158         (handleLocationChange):
1159         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1160
1161 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
1162
1163         Add aboxhall@chromium.org to accessibility watchlist.
1164
1165         Unreviewed.
1166
1167         * Scripts/webkitpy/common/config/watchlist:
1168
1169 2013-01-08  Dan Winship  <danw@gnome.org>
1170
1171         Add Apache 2.4 support for Fedora 18
1172         https://bugs.webkit.org/show_bug.cgi?id=104478
1173
1174         Reviewed by Martin Robinson.
1175
1176         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
1177         need a separate config.
1178
1179         * Scripts/webkitpy/layout_tests/port/base.py:
1180         (Port._apache_version):
1181         (Port._apache_config_file_name_for_platform):
1182         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1183         * Scripts/run-webkit-httpd:
1184         * Scripts/webkitperl/httpd.pm:
1185         (getApacheVersion):
1186         (getDefaultConfigForTestDirectory):
1187         (getHTTPDConfigPathForTestDirectory):
1188
1189 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1190
1191         Make the override-feature-defines script compatible with Python v3
1192         https://bugs.webkit.org/show_bug.cgi?id=105742
1193
1194         Reviewed by Martin Robinson.
1195
1196         Instead of printing output through a statement, use the print function and format
1197         the output using the str.format method. This makes the script runnable with Python v3.
1198
1199         * gtk/override-feature-defines:
1200         (adjust_feature_defines_makefile):
1201
1202 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
1203
1204         [Qt] Fix libxml2 config test
1205         https://bugs.webkit.org/show_bug.cgi?id=106317
1206
1207         Reviewed by Simon Hausmann.
1208
1209         Don't assume standard include/libxml2, libxml-2.0.pc should know
1210         where it's headers are.
1211
1212         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
1213
1214 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1215
1216         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
1217         https://bugs.webkit.org/show_bug.cgi?id=106195
1218
1219         Reviewed by Philippe Normand.
1220
1221         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
1222         to make the Python code compatible with Python 3. This includes modifying
1223         print statements, exception handling, dictionary iteration and
1224         byte-sequence-to-string conversion.
1225
1226         * gtk/common.py:
1227         (get_build_path):
1228         (pkg_config_file_variable):
1229         (gtk_version_of_pkg_config_file):
1230         * gtk/generate-gtkdoc:
1231         (print_missing_api):
1232         * gtk/gtkdoc.py:
1233         (GTKDoc.__init__):
1234         (GTKDoc._run_command):
1235
1236 2013-01-02  Steve Block  <steveblock@chromium.org>
1237
1238         Add chromium.org email address for Steve Block.
1239
1240         Unreviewed.
1241
1242         * Scripts/webkitpy/common/config/committers.py:
1243
1244 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
1245
1246         Rationalize closure call heuristics and profiling
1247         https://bugs.webkit.org/show_bug.cgi?id=106270
1248
1249         Reviewed by Oliver Hunt.
1250         
1251         Add ability to use display-profiler-output via a pipe, and add the ability to dump
1252         all generated code ('display *' or 'd *').
1253
1254         * Scripts/display-profiler-output:
1255
1256 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1257
1258         Sorted more xcodeproj files.
1259
1260         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1262         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1263
1264 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1265
1266         Sorted xcodeproj files.
1267
1268         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1269         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1270
1271 2013-01-07  Dan Bernstein  <mitz@apple.com>
1272
1273         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
1274         https://bugs.webkit.org/show_bug.cgi?id=106261
1275
1276         Reviewed by Simon Fraser.
1277
1278         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
1279
1280         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1281         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
1282         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
1283         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
1284         (TestWebKitAPI):
1285         (TestWebKitAPI::TEST):
1286
1287 2013-01-07  Ojan Vafai  <ojan@chromium.org>
1288
1289         Add the Apple MountainLion bots to garden-o-matic.
1290         Eventually, we really should move away from hardcoding
1291         the list of bots.
1292
1293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1294
1295 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
1296
1297         [chromium] move web audio related methods to testrunner library
1298         https://bugs.webkit.org/show_bug.cgi?id=106211
1299
1300         Reviewed by Adam Barth.
1301
1302         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1303         (DRTTestRunner::DRTTestRunner):
1304         (DRTTestRunner::reset):
1305         * DumpRenderTree/chromium/DRTTestRunner.h:
1306         (DRTTestRunner):
1307         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1308         (WebKit):
1309         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
1310         (WebTestRunner::WebTestRunner::audioData):
1311         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1312         (WebTestRunner::TestRunner::TestRunner):
1313         (WebTestRunner::TestRunner::reset):
1314         (WebTestRunner::TestRunner::shouldDumpAsAudio):
1315         (WebTestRunner):
1316         (WebTestRunner::TestRunner::audioData):
1317         (WebTestRunner::TestRunner::setAudioData):
1318         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1319         (TestRunner):
1320         * DumpRenderTree/chromium/TestShell.cpp:
1321         (TestShell::dump):
1322
1323 2013-01-07  Mike West  <mkwst@chromium.org>
1324
1325         Make the IFRAME_SEAMLESS flag runtime-enabled.
1326         https://bugs.webkit.org/show_bug.cgi?id=106213
1327
1328         Reviewed by Ojan Vafai.
1329
1330         * DumpRenderTree/chromium/TestShell.cpp:
1331         (TestShell::TestShell):
1332         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1333         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1334         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1335         (resetDefaultsToConsistentValues):
1336         * DumpRenderTree/mac/DumpRenderTree.mm:
1337         (resetDefaultsToConsistentValues):
1338         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1339         (WebCore::WebPage::resetSettings):
1340         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1341         (WTR::InjectedBundle::beginTesting):
1342             Ensure that seamless IFrames are enabled for layout tests in each of
1343             the ports that support seamless IFrames.
1344
1345 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
1346
1347         [chromium] move dumpAsText and friends to the TestRunner library
1348         https://bugs.webkit.org/show_bug.cgi?id=106222
1349
1350         Reviewed by Adam Barth.
1351
1352         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
1353
1354         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1355         (DRTTestRunner::DRTTestRunner):
1356         (DRTTestRunner::reset):
1357         * DumpRenderTree/chromium/DRTTestRunner.h:
1358         (DRTTestRunner):
1359         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1360         (WebTestRunner::WebTestRunner::shouldDumpAsText):
1361         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
1362         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
1363         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
1364         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
1365         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
1366         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1367         (WebTestRunner::TestRunner::TestRunner):
1368         (WebTestRunner::TestRunner::reset):
1369         (WebTestRunner::TestRunner::shouldDumpAsText):
1370         (WebTestRunner):
1371         (WebTestRunner::TestRunner::setShouldDumpAsText):
1372         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
1373         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
1374         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
1375         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
1376         (WebTestRunner::TestRunner::dumpAsText):
1377         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
1378         (WebTestRunner::TestRunner::dumpChildFramesAsText):
1379         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1380         (TestRunner):
1381
1382 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1383
1384         Build fix attempt after r138810.
1385
1386         Apparently python 2.6 is really bad at floating point computation.
1387
1388         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1389         (MainTest.test_run_memory_test):
1390
1391 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1392
1393         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
1394         https://bugs.webkit.org/show_bug.cgi?id=106172
1395
1396         Reviewed by Tony Chang.
1397
1398         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
1399         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
1400         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
1401         test on perf-o-matic and perf. test's results page.
1402
1403         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
1404
1405         * Scripts/webkitpy/performance_tests/perftest.py:
1406         (PerfTestMetric): Added.
1407         (PerfTestMetric.__init__): Added.
1408         (PerfTestMetric.metric): Added.
1409         (PerfTestMetric.has_values): Added.
1410         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
1411         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
1412         conversions to be done on the client side (perf-o-matic and results page).
1413         (PerfTestMetric.append): Added.
1414         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
1415         a result for this metric.
1416         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
1417         (PerfTestMetric.compute_statistics): Moved from PerfTest.
1418
1419         (PerfTest._create_driver): Extracted from PerfTest.run.
1420         (PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
1421         as needed.
1422         (PerfTest._run_with_driver):
1423         (PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
1424         (PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
1425         all keys except "values". We rely on PerfTestMetric to compute the statistics for us.
1426
1427         (ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
1428         from other perf tests, there isn't much point in sharing the code here.
1429
1430         (PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
1431         statistics for the measured values.
1432
1433         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1434         (TestPerfTestMetric): Added.
1435         (TestPerfTestMetric.test_init_set_missing_unit): Added.
1436         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
1437         (TestPerfTestMetric.test_has_values): Added.
1438         (TestPerfTestMetric.test_append): Added.
1439         (TestPerfTestMetric.test_compute_statistics.compute_statistics):
1440         (TestPerfTestMetric.test_compute_statistics): Added a trivial test case.
1441
1442         (TestPerfTest._assert_results_are_correct): Updated as needed.
1443         (TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
1444         in PerfTest.run now after generating the results dictionary.
1445         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.
1446
1447 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
1448
1449         Support size_t multiplication and division operators on LayoutUnit
1450         https://bugs.webkit.org/show_bug.cgi?id=83848
1451
1452         Reviewed by Emil A Eklund.
1453
1454         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1455         Added some simple tests for the new operators using size_t.
1456
1457 2013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1458
1459         [Qt] run-webkit-tests cleanup for parallel NRWT
1460         https://bugs.webkit.org/show_bug.cgi?id=106220
1461
1462         Reviewed by Dirk Pranke.
1463
1464         * Scripts/run-webkit-tests:
1465         (useNewRunWebKitTests):
1466         * Scripts/webkitpy/layout_tests/port/qt.py:
1467         (QtPort):
1468         (QtPort.default_child_processes):
1469
1470 2013-01-07  Philippe Normand  <pnormand@igalia.com>
1471
1472         Create a GStreamerAudio watchlist and add myself to it.
1473
1474         Unreviewed.
1475
1476         * Scripts/webkitpy/common/config/watchlist:
1477
1478 2013-01-05  Ryosuke Niwa  <rniwa@webkit.org>
1479
1480         Add svn:executable to a bunch of scripts in BuildSlaveSupport.
1481         Also removed the empty mac directory.
1482
1483         * BuildSlaveSupport/built-product-archive: Added property svn:executable.
1484         * BuildSlaveSupport/download-built-product: Added property svn:executable.
1485         * BuildSlaveSupport/mac: Removed.
1486         * BuildSlaveSupport/test-result-archive: Added property svn:executable.
1487
1488 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
1489
1490         Add a script to delete stale zero-byte build files
1491         https://bugs.webkit.org/show_bug.cgi?id=106131
1492
1493         Reviewed by Tony Chang.
1494
1495         Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
1496
1497         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1498         (DeleteStaleBuildFiles): Added.
1499         (Factory.__init__): Add DeleteStaleBuildFiles step.
1500         * BuildSlaveSupport/delete-stale-build-files: Added.
1501         (main): Delete zero-byte files except ones intentionally generated by our build process.
1502         (webkitBuildDirectory): Copied from build-product-archive.
1503
1504 2013-01-04  Michael Pruett  <michael@68k.org>
1505
1506         [GTK] Fix build error on GTK due to r138836
1507         https://bugs.webkit.org/show_bug.cgi?id=106154
1508
1509         Reviewed by Kentaro Hara.
1510
1511         * GNUmakefile.am:
1512
1513 2013-01-04  Dan Bernstein  <mitz@apple.com>
1514
1515         [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
1516         https://bugs.webkit.org/show_bug.cgi?id=106121
1517
1518         Reviewed by Adele Peterson.
1519
1520         Added test for -[DOMTHMLTableCellElement _cellAbove].
1521
1522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1523         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
1524         (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
1525         (TestWebKitAPI):
1526         (TestWebKitAPI::expectCellAboveCell):
1527         (TestWebKitAPI::TEST):
1528         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
1529
1530 2013-01-04  Eric Seidel  <eric@webkit.org>
1531
1532         FlakyTestReporter should be re-enabled and taught how to post patches
1533         https://bugs.webkit.org/show_bug.cgi?id=103839
1534
1535         Reviewed by Adam Barth.
1536
1537         This moves LayoutTestResultsReader off of the DeprecatedPort object.
1538         It also adds a real Port object to the EWS and CommitQueue objects
1539         using a new PatchProcessingQueue superclass.
1540         PatchProcessingQueue doesn't seem to be the cleanest insertion point
1541         but works for this purpose.
1542         I also moved _upload_results_archive_for_patch into PatchProcessingQueue
1543         to resolve a FIXME.
1544
1545         This required some hacks/shiming between the non-specific "old"
1546         port names which the EWS system is currently using, and the new
1547         port objects.  This shimming is done in PatchProcessingQueue._new_port_name_from_old.
1548
1549         Hopefully this will fix the flaky test reporter and results uploading.
1550         Certainly it's another small step towards getting rid of the old ports.py
1551         infrastructure and making the NRWT Port class common webkitpy infrastructure.
1552
1553         Now that DeprecatedPort is no longer used for the results directory
1554         I removed all the explicit results-dir code which webkit-patch was using
1555         in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
1556
1557         * Scripts/webkitpy/common/config/ports.py:
1558         (DeprecatedPort.run_perl_unittests_command):
1559         * Scripts/webkitpy/common/config/ports_mock.py:
1560         (MockPort.name):
1561         * Scripts/webkitpy/common/system/outputcapture.py:
1562         (OutputCapture.assert_outputs):
1563         * Scripts/webkitpy/layout_tests/port/apple.py:
1564         (ApplePort.determine_full_port_name):
1565         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1566         (LayoutTestResultsReader.__init__):
1567         (LayoutTestResultsReader):
1568         (LayoutTestResultsReader._read_file_contents):
1569         (LayoutTestResultsReader._create_layout_test_results):
1570         (LayoutTestResultsReader._create_unit_test_results):
1571         (LayoutTestResultsReader.results):
1572         (LayoutTestResultsReader.archive):
1573         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1574         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1575         (LayoutTestResultsReaderTest.test_create_unit_test_results):
1576         (test_missing_unit_test_results_path):
1577         (test_layout_test_results):
1578         (test_archive_last_layout_test_results):
1579         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1580         (AbstractEarlyWarningSystem):
1581         (AbstractEarlyWarningSystem.__init__):
1582         (AbstractEarlyWarningSystem.begin_work_queue):
1583         (AbstractEarlyWarningSystem.run_command):
1584         * Scripts/webkitpy/tool/commands/queues.py:
1585         (AbstractPatchQueue.work_item_log_path):
1586         (PatchProcessingQueue):
1587         (PatchProcessingQueue._new_port_name_from_old):
1588         (PatchProcessingQueue.begin_work_queue):
1589         (PatchProcessingQueue._upload_results_archive_for_patch):
1590         (CommitQueue):
1591         (CommitQueue.begin_work_queue):
1592         (CommitQueue.run_command):
1593         (AbstractReviewQueue):
1594         (AbstractReviewQueue.__init__):
1595         (AbstractReviewQueue.begin_work_queue):
1596         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1597         (AbstractPatchQueueTest.test_next_patch):
1598         (PatchProcessingQueueTest):
1599         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
1600         * Scripts/webkitpy/tool/steps/runtests.py:
1601         (RunTests.run):
1602         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1603
1604 2013-01-04  Dana Jansens  <danakj@chromium.org>
1605
1606         [chromium] Remove lost-compositor-context layout tests
1607         https://bugs.webkit.org/show_bug.cgi?id=106089
1608
1609         Reviewed by James Robinson.
1610
1611         Remove the loseCompositorContext() test function.
1612
1613         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1614         (WebTestRunner::TestRunner::TestRunner):
1615         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1616         (TestRunner):
1617
1618 2013-01-04  Adam Klein  <adamk@chromium.org>
1619
1620         Remove ENABLE_MUTATION_OBSERVERS #define
1621         https://bugs.webkit.org/show_bug.cgi?id=105459
1622
1623         Reviewed by Ryosuke Niwa.
1624
1625         * Scripts/webkitperl/FeatureList.pm:
1626         * qmake/mkspecs/features/features.pri:
1627
1628 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
1629
1630         Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
1631         https://bugs.webkit.org/show_bug.cgi?id=106078
1632
1633         Reviewed by Tony Chang.
1634
1635         This patch updates values for individual iterations in dummy performance tests used in
1636         perftest_unittest.py and perftest_integrationtest.py so that they match up with
1637         statistics such as stdev and median reported in those tests. This change is required
1638         to resolve the bug 97510.
1639
1640         This patch also refactors integration tests by extracting *TestData classes that
1641         centralizes the definitions of each dummy performance test's text (DRT output),
1642         runner output, and parsed results (JSON) so that we may share more data between
1643         python tests.
1644
1645         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1646         (MainTest._assert_results_are_correct): Extracted from test_parse_output.
1647         Use self.assertAlmostEqual when comparing the standard deviation.
1648         (MainTest.test_parse_output):
1649         (test_parse_output_with_failing_line):
1650         (test_parse_output_with_description): Use _assert_results_are_correct.
1651         (test_parse_output_with_subtests): Ditto.
1652
1653         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1654         (InspectorPassTestData): Extracted from tests below.
1655         (EventTargetWrapperTestData): Ditto.
1656         (SomeParserTestData): Ditto.
1657         (MemoryTestData): Ditto.
1658         (TestDriver.run_test): Moved test definitions out of the method.
1659         (MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
1660         (MainTest._load_output_json): Extracted from create_runner.
1661         (MainTest.create_runner):
1662         (MainTest.test_run_test_set_for_parser_tests):
1663         (MainTest.test_run_memory_test):
1664         (MainTest._test_run_with_json_output):
1665         (MainTest.test_run_with_json_output):
1666         (MainTest.test_run_with_description):
1667         (MainTest.test_run_generates_json_by_default):
1668         (MainTest.test_run_merges_output_by_default):
1669         (MainTest.test_run_respects_reset_results):
1670         (MainTest.test_run_generates_and_show_results_page):
1671         (MainTest.test_run_with_slave_config_json):
1672         (MainTest.test_run_with_multiple_repositories):
1673
1674 2013-01-04  Martin Robinson  <mrobinson@igalia.com>
1675
1676         [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
1677         https://bugs.webkit.org/show_bug.cgi?id=106045
1678
1679         Reviewed by Carlos Garcia Campos.
1680
1681         Update test results to confirm that compositions without preedits do not trigger
1682         a composition confirmation.
1683
1684         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
1685         (TestWebKitAPI::verifyCanceledComposition):
1686
1687 2013-01-04  Sailesh Agrawal  <sail@chromium.org>
1688
1689         [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
1690         https://bugs.webkit.org/show_bug.cgi?id=105958
1691
1692         Reviewed by Alexey Proskuryakov.
1693
1694         Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
1695
1696         * WebKitTestRunner/mac/EventSenderProxy.mm:
1697         (KeyMappingEntry):
1698         (WTR):
1699         (WTR::EventSenderProxy::keyDown): Added all numpad keys.
1700
1701 2013-01-03  Chris Fleizach  <cfleizach@apple.com>
1702
1703         REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
1704         https://bugs.webkit.org/show_bug.cgi?id=106073
1705
1706         Reviewed by Ryosuke Niwa.
1707
1708         Check that the element being compared to is not nil. 
1709         This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
1710         It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
1711         controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it 
1712         sometimes before on parallel WebKitTestRunner runs.
1713
1714         * DumpRenderTree/AccessibilityUIElement.cpp:
1715         (AccessibilityUIElement::isEqual):
1716         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1717         (WTR::AccessibilityUIElement::isEqual):
1718
1719 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
1720
1721         Downloads can be flaky, so try downloading multiple times.
1722         https://bugs.webkit.org/show_bug.cgi?id=105976
1723
1724         Reviewed by Eric Seidel.
1725
1726         * Scripts/webkitpy/common/system/autoinstall.py:
1727         (AutoInstaller._download_to_stream):
1728
1729 2013-01-03  Eric Seidel  <eric@webkit.org>
1730
1731         Rename Tool.port to deprecated_port in preparation for removing more callers
1732         https://bugs.webkit.org/show_bug.cgi?id=106076
1733
1734         Reviewed by Ryosuke Niwa.
1735
1736         This resolves a long-standing FIXME to rename this method. :)
1737
1738         * Scripts/webkitpy/tool/bot/botinfo.py:
1739         (BotInfo.summary_text):
1740         * Scripts/webkitpy/tool/bot/irc_command.py:
1741         (Rollout._update_working_copy):
1742         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1743         (LayoutTestResultsReader._create_layout_test_results):
1744         (LayoutTestResultsReader._create_unit_test_results):
1745         (LayoutTestResultsReader._results_directory):
1746         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1747         (test_missing_unit_test_results_path):
1748         * Scripts/webkitpy/tool/main.py:
1749         (WebKitPatch.deprecated_port):
1750         * Scripts/webkitpy/tool/mocktool.py:
1751         (MockTool.deprecated_port):
1752         * Scripts/webkitpy/tool/steps/build.py:
1753         (Build.build):
1754         * Scripts/webkitpy/tool/steps/checkstyle.py:
1755         (CheckStyle.run):
1756         * Scripts/webkitpy/tool/steps/commit.py:
1757         (Commit._check_test_expectations):
1758         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1759         (PrepareChangeLog.run):
1760         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1761         (PrepareChangeLogForDEPSRoll.run):
1762         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1763         (PrepareChangeLogForRevert.run):
1764         * Scripts/webkitpy/tool/steps/runtests.py:
1765         (RunTests.run):
1766         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1767         (StepsTest.test_runtests_args):
1768         * Scripts/webkitpy/tool/steps/update.py:
1769         (Update._update_command):
1770
1771 2013-01-03  Eric Seidel  <eric@webkit.org>
1772
1773         Add myself to the webkitpy watchlist.
1774
1775         Unreviewed.
1776
1777         * Scripts/webkitpy/common/config/watchlist:
1778
1779 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
1780
1781         Cleanup perftest* tests and add a test for computing statistics
1782         https://bugs.webkit.org/show_bug.cgi?id=105685
1783
1784         Reviewed by Eric Seidel.
1785
1786         Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
1787         extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
1788
1789         Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
1790
1791         * Scripts/webkitpy/performance_tests/perftest.py:
1792         (PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
1793         directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
1794         accurate result for the mean.
1795         (PageLoadingPerfTest.run_single):
1796         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1797         (MainTest.test_compute_statistics):
1798         (MainTest.test_compute_statistics.compute_statistics): Added.
1799         (TestPageLoadingPerfTest.test_run): floatify values.
1800         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
1801         correctly recognizes them as integers.
1802
1803         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
1804         Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
1805         (TestDriver): Moved out of MainTest.
1806         (MainTest): Got rid of assertWritten and all unit tests.
1807         (MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
1808         (MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
1809         (MainTest.test_run_test_set_for_parser_tests):
1810         (MainTest.test_run_memory_test):
1811         (MainTest._test_run_with_json_output):
1812         (MainTest.test_run_generates_json_by_default):
1813         (MainTest.test_run_merges_output_by_default):
1814         (MainTest.test_run_respects_reset_results):
1815         (MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
1816         parsing output JSON files. Just verify that the output path is correct instead.
1817         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1818         (MainTest): Removed all integration tests.
1819         (MainTest.create_runner): Simplified.
1820
1821 2013-01-03  Julie Parent  <jparent@chromium.org>
1822
1823         Dashboard cleanup: remove usage of global g_defaultBuilderName
1824         https://bugs.webkit.org/show_bug.cgi?id=106043
1825
1826         Use now public defaultBuilder() from the BuilderGroup, rather
1827         than global variable.
1828
1829         Also eliminates the setup() and initBuilders() functions since we
1830         no longer need to track the global.
1831
1832         Reviewed by Adam Barth.
1833
1834         * TestResultServer/static-dashboards/builders.js:
1835         (BuilderGroup.prototype.defaultBuilder):
1836         (BuilderGroup.prototype.master):
1837         * TestResultServer/static-dashboards/dashboard_base.js:
1838         (parseParameters):
1839         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1840         (updateDefaultBuilderState):
1841         * TestResultServer/static-dashboards/loader.js:
1842         (.):
1843         * TestResultServer/static-dashboards/loader_unittests.js:
1844
1845 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
1846
1847         Disable an intermittently failing unit test for now.
1848         The failure is tracked by the bug 106051.
1849
1850         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
1851         (TestWebKitAPI::TEST):
1852
1853 2013-01-03  Dan Bernstein  <mitz@apple.com>
1854
1855         No way to obtain a DOMNode given a JS wrapper for a Node
1856         https://bugs.webkit.org/show_bug.cgi?id=106033
1857
1858         Added a test for +[DOMNode _nodeFromJSWrapper:].
1859
1860         Reviewed by Sam Weinig.
1861
1862         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1863         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
1864         (TestWebKitAPI):
1865         (TestWebKitAPI::TEST):
1866
1867 2013-01-03  Emil A Eklund  <eae@chromium.org>
1868
1869         Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
1870         https://bugs.webkit.org/show_bug.cgi?id=105961
1871
1872         Reviewed by Levi Weintraub.
1873         
1874         Add tests for LayoutUnit::ceil and floor.
1875
1876         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1877         (TestWebKitAPI::TEST):
1878         (TestWebKitAPI):
1879
1880 2013-01-03  Julie Parent  <jparent@chromium.org>
1881
1882         Add unit test for default builder for the dashboards.
1883         https://bugs.webkit.org/show_bug.cgi?id=105972
1884
1885         Reviewed by Dirk Pranke.
1886
1887         * TestResultServer/static-dashboards/loader_unittests.js:
1888
1889 2013-01-03  Tony Chang  <tony@chromium.org>
1890
1891         Generate internal.settings from Settings.in
1892         https://bugs.webkit.org/show_bug.cgi?id=104740
1893
1894         Reviewed by Adam Barth.
1895
1896         * GNUmakefile.am: Compile new generated files on GTK+.
1897         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
1898         with both extra_sources and add_output_to_sources=false will still
1899         compile the files in extra_sources. This makes it possible to compile
1900         InternalSettingsGenerated.cpp and not be confused by
1901         InternalSettingsGenerated.idl.
1902
1903 2013-01-03  Zan Dobersek  <zandobersek@gmail.com>
1904
1905         [style] WebIDL-reflecting uppercase enums reported as style violation
1906         https://bugs.webkit.org/show_bug.cgi?id=105832
1907
1908         Reviewed by Tony Chang.
1909
1910         Recognize the enum as WebIDL-reflecting one if there's a comment present that
1911         indicates this. In enums spanning over multiple lines, the comment is expected
1912         on the first line. In enums placed in one line, the comment is expected at the
1913         end of that line.
1914
1915         WebIDL-reflecting enum values are required to be written in uppercase and as such
1916         violate the common rule of these values being written in InterCaps. Annotating
1917         enums this way makes it possible to avoid false style violation reports.
1918
1919         The comment is of form '// Web(?:Kit)?IDL enum'.
1920
1921         * Scripts/webkitpy/style/checkers/cpp.py:
1922         (_EnumState.__init__):
1923         (_EnumState.process_clean_line):
1924         (check_enum_casing):
1925         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1926         (NoNonVirtualDestructorsTest.test_enum_casing):
1927
1928 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
1929
1930         Adding favicon.ico to the garden-o-matic.
1931         https://bugs.webkit.org/show_bug.cgi?id=105982
1932
1933         Reviewed by Adam Barth.
1934
1935         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1936         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
1937
1938 2013-01-03  Jonathan Liu  <net147@gmail.com>
1939
1940         [Qt] Fix library linking order
1941         https://bugs.webkit.org/show_bug.cgi?id=105818
1942
1943         Some Qt libraries are linked before the private static libraries
1944         that depend on them which results in QtWebKit failing to link.
1945
1946         Copy Qt module dependencies from QT to QT_PRIVATE when creating
1947         module to ensure the Qt libraries are linked after the private
1948         static libraries that depend on them.
1949
1950         Reviewed by Tor Arne Vestbø.
1951
1952         * qmake/mkspecs/features/default_post.prf:
1953
1954 2013-01-02  Byungwoo Lee  <bw80.lee@samsung.com>
1955
1956         [EFL][WK2] Fix tooltip bugs in MiniBrowser.
1957         https://bugs.webkit.org/show_bug.cgi?id=102209
1958
1959         Reviewed by Gyuyoung Kim.
1960
1961         Set tooltip on the elm_window instead of ewk_view, and add delay to
1962         show the tooltip window.
1963
1964         Setting tooltip on the ewk_view makes elementary error message because
1965         ewk_view is not an elementary widget. To remove the error message,
1966         tooltip should be set on the elm_window.
1967
1968         Most browsers show the tooltip after a mouse pointer stays on an
1969         element object that has tooltip text.
1970         But elm_tooltip widget itself doesn't have delay or handle mouse
1971         events to show/hide.
1972
1973         So additional codes are added to show/hide tooltip widget along with
1974         mouse events.
1975           1) When a mouse pointer stays for a second on an element which has
1976              tooltip text, then tooltip widget is displayed.
1977           2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
1978              widget.
1979
1980         * MiniBrowser/efl/main.c:
1981         (_Tooltip_Information):
1982         (_Browser_Window):
1983         (on_tooltip_show):
1984         (window_tooltip_hide):
1985         (window_tooltip_update):
1986         (on_mouse_in):
1987         (on_mouse_move):
1988         (on_mouse_out):
1989         (window_free):
1990         (on_tooltip_text_set):
1991         (on_tooltip_text_unset):
1992         (window_create):
1993
1994 2013-01-02  Tony Chang  <tony@chromium.org>
1995
1996         Unreviewed, rolling out r138661.
1997         http://trac.webkit.org/changeset/138661
1998         https://bugs.webkit.org/show_bug.cgi?id=104740
1999
2000         Compile problems on EFL
2001
2002         * GNUmakefile.am:
2003         * qmake/mkspecs/features/default_post.prf:
2004
2005 2013-01-02  Tony Chang  <tony@chromium.org>
2006
2007         Generate internal.settings from Settings.in
2008         https://bugs.webkit.org/show_bug.cgi?id=104740
2009
2010         Reviewed by Adam Barth.
2011
2012         * GNUmakefile.am: Compile new generated files on GTK+.
2013         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
2014         with both extra_sources and add_output_to_sources=false will still
2015         compile the files in extra_sources. This makes it possible to compile
2016         InternalSettingsGenerated.cpp and not be confused by
2017         InternalSettingsGenerated.idl.
2018
2019 2013-01-02  Adam Barth  <abarth@webkit.org>
2020
2021         Remove old-run-webkit-tests support from webkitpy
2022         https://bugs.webkit.org/show_bug.cgi?id=105619
2023
2024         Reviewed by Eric Seidel.
2025
2026         This patch removes support for webkitpy parsing the
2027         old-run-webkit-tests results format. There doesn't seem to be any
2028         reason to keep this code around anymore now that most bots have
2029         switched to new-run-webkit-tests.
2030
2031         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2032         (Builder.fetch_layout_test_results):
2033         * Scripts/webkitpy/common/net/layouttestresults.py:
2034         (path_for_layout_test):
2035         (LayoutTestResults.results_from_string):
2036         (LayoutTestResults):
2037         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2038         (LayoutTestResultsTest.test_results_from_string):
2039         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2040         (test_flaky_test_failure):
2041         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2042         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
2043         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2044         (PatchAnalysisTask._test_patch):
2045         * Scripts/webkitpy/tool/commands/queuestest.py:
2046         (QueuesTest.assert_queue_outputs):
2047
2048 2013-01-02  Heikki Paajanen  <heikki.paajanen@palm.com>
2049
2050         [Qt][WK2] Add simple UI to find text from page
2051         https://bugs.webkit.org/show_bug.cgi?id=96481
2052
2053         Reviewed by Jocelyn Turcotte.
2054
2055         Find bar that slides between navigation bar and WebView.
2056
2057         * MiniBrowser/qt/BrowserWindow.cpp:
2058         (BrowserWindow::toggleFind):
2059         * MiniBrowser/qt/BrowserWindow.h:
2060         (BrowserWindow):
2061         * MiniBrowser/qt/MiniBrowser.qrc:
2062         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2063         (MiniBrowserApplication::notify):
2064         * MiniBrowser/qt/icons/find.png: Added.
2065         * MiniBrowser/qt/qml/BrowserWindow.qml:
2066
2067 2013-01-02  Christophe Dumez  <christophe.dumez@intel.com>
2068
2069         Regression(r138603): Caused 2 webkitpy tests to fail
2070         https://bugs.webkit.org/show_bug.cgi?id=105913
2071
2072         Reviewed by Kentaro Hara.
2073
2074         Fix 2 webkitpy tests that started to fail after
2075         r138603.
2076
2077         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2078         (IRCCommandTest._sheriff_test_data_url): Make sure the
2079         returned test file URL is valid no matter what the
2080         current working directory is.
2081         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2082         (IRCBotTest.test_help): Add "sheriffs" command to the
2083         list of available commands.
2084
2085 2013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
2086
2087         [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
2088         https://bugs.webkit.org/show_bug.cgi?id=105897
2089
2090         Reviewed by Alexey Proskuryakov.
2091
2092         Dump in WebKitTestRunner the message that is expected by layout tests
2093         when the missing plugin button is clicked.
2094
2095         * WebKitTestRunner/TestController.cpp:
2096         (WTR::TestController::createWebViewWithOptions):
2097         (WTR::TestController::unavailablePluginButtonClicked):
2098         (WTR):
2099         * WebKitTestRunner/TestController.h:
2100         (TestController):
2101
2102 2013-01-01  KwangYong Choi  <ky0.choi@samsung.com>
2103
2104         [EFL] Enable MHTML feature
2105         https://bugs.webkit.org/show_bug.cgi?id=105815
2106
2107         Reviewed by Laszlo Gombos.
2108
2109         Enable MHTML feature for EFL port by default.
2110
2111         * Scripts/webkitperl/FeatureList.pm:
2112
2113 2013-01-01  Alan Cutter  <alancutter@chromium.org>
2114
2115         sheriff-bot should know who the gardeners/sheriffs are
2116         https://bugs.webkit.org/show_bug.cgi?id=105698
2117
2118         Reviewed by Eric Seidel.
2119
2120         Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
2121
2122         * Scripts/webkitpy/tool/bot/irc_command.py:
2123         (Current):
2124         (Current._retrieve_webkit_sheriffs):
2125         (Current.execute):
2126         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2127         (IRCCommandTest.test_current):
2128         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
2129         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
2130         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
2131         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
2132         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
2133
2134 2012-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2135
2136         [GTK] Move ImageDiff to the Tools directory root
2137         https://bugs.webkit.org/show_bug.cgi?id=105421
2138
2139         Reviewed by Kenneth Rohde Christiansen.
2140
2141         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
2142         * GNUmakefile.am:
2143         * ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
2144
2145 2012-12-30  Mike West  <mkwst@chromium.org>
2146
2147         Add myself to watchlists for CSP and console logs.
2148         https://bugs.webkit.org/show_bug.cgi?id=105874
2149
2150         Reviewed by Dirk Pranke.
2151
2152         Because I really, really, really need more email.
2153
2154         * Scripts/webkitpy/common/config/committers.py:
2155             Add mkwst+watchlist@chromium.org as a contributor.
2156         * Scripts/webkitpy/common/config/watchlist:
2157             Create watchlist categories for 1) the various mechanisms used to
2158             generate console messages, and 2) CSP usage and files.
2159
2160 2012-12-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2161
2162         [EFL] Enable TEMPLATE_ELEMENT feature
2163         https://bugs.webkit.org/show_bug.cgi?id=105865
2164         
2165         Reviewed by Laszlo Gombos.
2166
2167         * Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
2168
2169 2012-12-30  Zan Dobersek  <zandobersek@gmail.com>
2170
2171         Unreviewed GTK gardening of the unit tests.
2172
2173         Skip the TestInspectorServer unit test that's timing out completely.
2174
2175         * Scripts/run-gtk-tests:
2176         (TestRunner):
2177
2178 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
2179
2180         Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
2181         https://bugs.webkit.org/show_bug.cgi?id=105855
2182
2183         Reviewed by Vsevolod Vlasov.
2184
2185         Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
2186         addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.
2187
2188         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2189         (ReportMemoryUsageVisitor):
2190         (clang::AddMemberCallVisitor::VisitCallExpr):
2191         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
2192         (clang::ReportMemoryUsageVisitor::checkMembersCoverage):
2193
2194 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
2195
2196         Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
2197         https://bugs.webkit.org/show_bug.cgi?id=105852
2198
2199         Reviewed by Alexander Pavlov.
2200
2201         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2202         (clang):
2203         (AddMemberCallVisitor):
2204         (ReportMemoryUsageVisitor):
2205         (clang::ReportMemoryUsageAction::ParseArgs):
2206         (clang::AddMemberCallVisitor::VisitCallExpr):
2207         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
2208         (clang::ReportMemoryUsageVisitor::emitWarning):
2209         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
2210         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
2211         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
2212
2213 2012-12-29  Zan Dobersek  <zandobersek@gmail.com>
2214
2215         [webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
2216         https://bugs.webkit.org/show_bug.cgi?id=105835
2217
2218         Reviewed by Dirk Pranke.
2219
2220         The BeautifulSoup module is a third-party import and as such we don't have much control
2221         over its testing. Because of that it should be omitted from code coverage checking.
2222
2223         * Scripts/webkitpy/test/main.py:
2224         (Tester._run_tests):
2225
2226 2012-12-28  Martin Robinson  <mrobinson@igalia.com>
2227
2228         [GTK][WK2] Add support for IME Composition
2229         https://bugs.webkit.org/show_bug.cgi?id=65093
2230
2231         Reviewed by Carlos Garcia Campos.
2232
2233         Update unit tests for GtkInputMethodFilter to note whether or not an event
2234         was a fake event synthesized for composition purposes. This is now used
2235         for WebKit2.
2236
2237         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
2238         (TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
2239         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
2240         (TestWebKitAPI::TEST):
2241         * gtk/generate-gtkdoc:
2242         (get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
2243         generation.
2244
2245 2012-12-27  Ilya Tikhonovsky  <loislo@chromium.org>
2246
2247         Web Inspector: Native Memory Instrumentation. Update clang plugin according to the current state of memory instrumentation code.
2248         https://bugs.webkit.org/show_bug.cgi?id=105800
2249
2250         Reviewed by Yury Semikhatsky.
2251
2252         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2253         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
2254         (clang):
2255
2256 2012-12-27  Zan Dobersek  <zandobersek@gmail.com>
2257
2258         Create a GTK build system watchlist and add myself to it
2259         https://bugs.webkit.org/show_bug.cgi?id=105769
2260
2261         Reviewed by Dirk Pranke.
2262
2263         Add a GTK build system watchlist, watching the configure.ac, GNUmakefile.am files
2264         and the input GNUmakefile.features.am.in file. The GNUmakefile.list.am files are
2265         omitted on purpose due to relatively high change rate they are exposed to.
2266
2267         The new watchlist would be of use to me as the GTK build system recently went
2268         through a series of changes that included a changed policy on adding configuration
2269         flags to configure.ac and subsequent additions to GNUmakefile.am files. A PSA on the
2270         mailing list about this change will be published later, but I'd also like to be
2271         notified of any pending changes to these files just so I can check the changes are
2272         in compliance with the new policy.
2273
2274         * Scripts/webkitpy/common/config/watchlist:
2275
2276 2012-12-26  Ilya Tikhonovsky  <loislo@chromium.org>
2277
2278         Unreviewed. Replace find("Tools") with rfind("Tools") because base dir of WebKit may have Tools word.
2279         As example ..../DevTools/src/third_party/WebKit
2280
2281         * Scripts/webkitpy/common/webkit_finder.py:
2282         (WebKitFinder.webkit_base):
2283
2284 2012-12-25  Christophe Dumez  <christophe.dumez@intel.com>
2285
2286         [EFL][WK2] Refactor snapshot taking code
2287         https://bugs.webkit.org/show_bug.cgi?id=105687
2288
2289         Reviewed by Kenneth Rohde Christiansen.
2290
2291         Call WKViewCreateSnapshot() instead of WKViewGetSnapshot()
2292         since the function was renamed to follow naming style.
2293
2294         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2295         (WTR::PlatformWebView::windowSnapshotImage):
2296
2297 2012-12-24  Ilya Tikhonovsky  <loislo@chromium.org>
2298
2299         Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
2300         https://bugs.webkit.org/show_bug.cgi?id=105725
2301
2302         Reviewed by Yury Semikhatsky.
2303
2304         MemberType value names were adjusted according to Style Guide.
2305         Existing tests were extended with link type validation.
2306
2307         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2308
2309 2012-12-24  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2310
2311         [BlackBerry] DRT - Crashed when running pixels tests
2312         https://bugs.webkit.org/show_bug.cgi?id=105711
2313
2314         RIM PR 270003
2315
2316         Reviewed by George Staikos.
2317
2318         Calling window->post() here will result in buffer swapping which is
2319         only allowed in UI thread now, and I found we don't need to call it
2320         for GL renderer.
2321
2322         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2323         (createBitmapContextFromWebView):
2324
2325 2012-12-22  Dan Winship  <danw@gnome.org>
2326
2327         Add a patch to fix libxml2 2.9.0 regression
2328         https://bugs.webkit.org/show_bug.cgi?id=104494
2329
2330         Reviewed by Martin Robinson.
2331
2332         * gtk/jhbuild.modules:
2333         * gtk/patches/libxml2-2.9.0-dtd.patch: patch from upstream
2334
2335 2012-12-23  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2336
2337         Unreviewed update of status to reviewer.
2338
2339         * Scripts/webkitpy/common/config/committers.py:
2340
2341 2012-12-23  Philippe Normand  <pnormand@igalia.com>
2342
2343         [GTK][jhbuild] Bump GStreamer to 1.0.4
2344         https://bugs.webkit.org/show_bug.cgi?id=105640
2345
2346         Reviewed by Martin Robinson.
2347
2348         * gtk/jhbuild.modules: Update GStreamer modules to 1.0.4.
2349
2350 2012-12-21  Nico Weber  <thakis@chromium.org>
2351
2352         chromium: webkit-build-directory doesn't handle ninja output dirs
2353         https://bugs.webkit.org/show_bug.cgi?id=105671
2354
2355         Reviewed by Daniel Bates.
2356
2357         Teach webkit-build-directory to detect the ninja build directory.
2358
2359         * Scripts/webkitdirs.pm:
2360         (determineBaseProductDir):
2361         (determineIsChromiumNinja):
2362
2363 2012-12-21  Ryosuke Niwa  <rniwa@webkit.org>
2364
2365         [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
2366         https://bugs.webkit.org/show_bug.cgi?id=95477
2367
2368         Reviewed by Sam Weinig.
2369
2370         Co-authored by Jia Pu.
2371
2372         Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
2373         we can have consistent autocorrection behavior when running tests.
2374
2375         * DumpRenderTree/mac/DumpRenderTree.mm:
2376         (resetDefaultsToConsistentValues):
2377         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2378         (WTR::InjectedBundle::platformInitialize):
2379
2380 2012-12-21  Zan Dobersek  <zandobersek@gmail.com>
2381
2382         [GTK] Add WebKit1-specific TestExpectations file
2383         https://bugs.webkit.org/show_bug.cgi?id=97562
2384
2385         Reviewed by Dirk Pranke.
2386
2387         Implement the expectations_files method inside the GtkPort class that
2388         returns the list of the TestExpectations files the current test configuration
2389         requires. The method is implemented in a similar way as on the EFL port.
2390         A unit test is also added.
2391
2392         * Scripts/webkitpy/layout_tests/port/gtk.py:
2393         (GtkPort._search_paths):
2394         (GtkPort):
2395         (GtkPort.expectations_files):
2396         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2397         (GtkPortTest.test_expectations_files):
2398
2399 2012-12-21  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2400
2401         [EFL] Enable feature option for the CSS sticky position
2402         https://bugs.webkit.org/show_bug.cgi?id=105630
2403
2404         Reviewed by Kenneth Rohde Christiansen.
2405
2406         Enable CSS sticky position feature by default for the
2407         EFL port. This feature option was added in r138252.
2408
2409         No new tests. Existing layout tests pass.
2410
2411         * Scripts/webkitperl/FeatureList.pm:
2412
2413 2012-12-21  Jussi Kukkonen  <jussi.kukkonen@intel.com>
2414
2415         [WK2] REGRESSION(r138232): It made 4 tests timeout
2416         https://bugs.webkit.org/show_bug.cgi?id=105623
2417
2418         Reviewed by Kenneth Rohde Christiansen.
2419
2420         r138232 changed functionality so that empty text output
2421         no longer leads to a dump() call, which leads to a timeout.
2422         Instead do a text dump if there is text output or if there
2423         is no audio output.
2424
2425         * WebKitTestRunner/TestInvocation.cpp:
2426         (WTR::TestInvocation::dumpResults):
2427
2428 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2429
2430         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
2431         https://bugs.webkit.org/show_bug.cgi?id=105309
2432
2433         On Windows the library name is Qt5WebKitWidgets as well.
2434         So r138136 should not have adjusted the library name for Windows.
2435
2436         Reviewed by Simon Hausmann.
2437
2438         * Scripts/webkitdirs.pm:
2439         (builtDylibPathForName):
2440
2441 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2442
2443         [Qt] Add new TestExpectations for qt-5.0-mac-wk2.
2444         https://bugs.webkit.org/show_bug.cgi?id=105424
2445
2446         This change will allow us to run a very specific
2447         subset of the available LayoutTests on a mac buildbot.
2448         The new baseline search path for mac will look as follows:
2449         qt-5.0-mac-wk2 -> qt-5.0-wk2 -> qt-5.0 -> qt-mac -> qt
2450
2451         Reviewed by Dirk Pranke.
2452
2453         * Scripts/webkitpy/layout_tests/port/qt.py:
2454         (QtPort._search_paths):
2455         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2456         (QtPortTest):
2457
2458 2012-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2459
2460         [EFL] Build break with latest EFL libraries.
2461         https://bugs.webkit.org/show_bug.cgi?id=104827
2462
2463         Reviewed by Laszlo Gombos.
2464
2465         The eo EFL package is introduced and evas and ecore use it since 1.8.
2466         While introducing Eo, EFL changed several structures of Evas and Ecore
2467         from own specific class to Eo.
2468
2469         So, this patch adds FindEo and changes declaration of Evas, Evas_Object,
2470         Ecore_Timer to build with latest EFL libraries.
2471
2472         * DumpRenderTree/efl/CMakeLists.txt: Includes eo EFL library.
2473         * EWebLauncher/CMakeLists.txt: Ditto.
2474         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2475         * ImageDiff/PlatformEfl.cmake: Ditto.
2476         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
2477         * TestWebKitAPI/PlatformWebView.h: Modified declaration of Evas_Object.
2478         * WebKitTestRunner/InjectedBundle/TestRunner.h: Modified declaration of Ecore_Timer.
2479         * WebKitTestRunner/PlatformEfl.cmake: Includes eo EFL library.
2480         * WebKitTestRunner/PlatformWebView.h: Modified declaration of Evas_Object.
2481
2482 2012-12-20  Dirk Pranke  <dpranke@chromium.org>
2483
2484         TestExpectation fallback is broken
2485         https://bugs.webkit.org/show_bug.cgi?id=105583
2486
2487         Reviewed by Ryosuke Niwa.
2488
2489         When I added support for the -wk2 in port names, it looks
2490         like I broke the way we computed the list of TestExpectations
2491         files so that the implementation-version directory was left out :(.
2492         Fixed and cleaned up the tests.
2493
2494         * Scripts/webkitpy/layout_tests/port/base.py:
2495         (Port.expectations_files):
2496         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2497         (TestWebKitPort.__init__):
2498         (PortTestCase.test_skipped_directories_for_symbols):
2499         (test_skipped_directories_for_features):
2500         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
2501         (test_skipped_tests_for_unsupported_features_empty_test_list):
2502         (test_skipped_layout_tests):
2503         (test_expectations_files):
2504
2505 2012-12-20  Anders Carlsson  <andersca@apple.com>
2506
2507         Don't include WebKit2 headers when building TestWebKitAPI on windows
2508         https://bugs.webkit.org/show_bug.cgi?id=105582
2509
2510         Reviewed by Tim Horton.
2511
2512         * TestWebKitAPI/config.h:
2513         * TestWebKitAPI/win/main.cpp:
2514
2515 2012-12-20  Ryosuke Niwa  <rniwa@webkit.org>
2516
2517         REGRESSION(r133820?): SimplifyMarkupTest API test asserts
2518         https://bugs.webkit.org/show_bug.cgi?id=105370
2519
2520         Reviewed by Simon Fraser.
2521
2522         Re-enable the test.
2523
2524         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2525         (TestWebKitAPI::TEST):
2526
2527 2012-12-20  Nico Weber  <thakis@chromium.org>
2528
2529         chromium nrwt: Pick the newest binary found in DEFAULT_BUILD_DIRECTORIES, not the first
2530         https://bugs.webkit.org/show_bug.cgi?id=105498
2531
2532         Reviewed by Dirk Pranke.
2533
2534         Use the newest binary available rather than an than always picking one
2535         build directory over another based on iteration order.
2536
2537         * Scripts/webkitpy/layout_tests/port/chromium.py:
2538         (ChromiumPort._static_build_path):
2539         Check for timestamps.
2540         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2541         (ChromiumMacPortTest.test_build_path_timestamps):
2542         Test that out / xcodebuild selection happens based on timestamps
2543         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2544         (ChromiumWinPortTest.test_build_path_timestamps):
2545         Test that out / build selection happens based on timestamps
2546
2547 2012-12-19  Simon Fraser  <simon.fraser@apple.com>
2548
2549         Lots of sticky tests failing in WK2
2550         https://bugs.webkit.org/show_bug.cgi?id=105464
2551
2552         Reviewed by Beth Dakin.
2553
2554         WebKitTestRunner had a race between snapshotting in the UI process,
2555         and resettting after the test in the web process. InjectedBundle::done()
2556         was a bad place to call page()->resetAfterTest(), because of this race;
2557         it could reset the scroll position before the UI snapshot had been obtained.
2558         
2559         Fix by moving the call to page()->resetAfterTest() into didReceiveMessage(),
2560         for the "Reset" message which will come in before the next test.
2561
2562         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2563         (WTR::InjectedBundle::didReceiveMessage):
2564         (WTR::InjectedBundle::done):
2565
2566 2012-12-19  Filip Pizlo  <fpizlo@apple.com>
2567
2568         DFG speculation checks that take JumpList should consolidate OSRExits
2569         https://bugs.webkit.org/show_bug.cgi?id=105401
2570
2571         Reviewed by Oliver Hunt.
2572
2573         Update the profiler to understand that an OSR exit may have multiple
2574         candidate exit sites.
2575
2576         * Scripts/display-profiler-output:
2577
2578 2012-12-20  Eric Seidel  <eric@webkit.org>
2579
2580         EWSes do not need to dump build/test logs when things pass
2581         https://bugs.webkit.org/show_bug.cgi?id=105402
2582
2583         Reviewed by Dirk Pranke.
2584
2585         When we were first writing the commit-queue and EWS system
2586         and running them locally, we thought it was important to see the
2587         build/test output as it happened.  Now these queues have been running
2588         for years, and we don't use this feature anymore.  So this patch
2589         makes us stop tee-ing the output directly to stdout, and instead
2590         only print any output from commands when they fail.
2591
2592         I also added some logging when we execute each command
2593         since we are no longer printing the command output itself.
2594         This should make it much easier to see errors with the EWS
2595         system itself, now that all the passing-build output is removed.
2596
2597         This required updating a zillion unittests, since we have a bunch of
2598         "integration" style testing of the queue-bots.  Many of the unittests for the bots were
2599         already approximating this behavior by using a "logging" Executive.
2600         I disabled logging in those cases to avoid redundant logging in those tests.
2601
2602         * Scripts/webkitpy/common/system/executive.py:
2603         (Executive.command_for_printing):
2604         (Executive.run_command):
2605         * Scripts/webkitpy/common/system/executive_mock.py:
2606         (MockExecutive.command_for_printing):
2607         (MockExecutive.run_command):
2608         * Scripts/webkitpy/common/system/executive_unittest.py:
2609         (ExecutiveTest.test_auto_stringify_args):
2610         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2611         (EarlyWarningSytemTest._default_expected_logs):
2612         (_test_ews):
2613         (_test_ewses):
2614         * Scripts/webkitpy/tool/commands/queues.py:
2615         (AbstractQueue.run_webkit_patch):
2616         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2617         (AbstractQueueTest._assert_run_webkit_patch):
2618         (CommitQueueTest.test_commit_queue):
2619         (test_rollout):
2620         (test_rollout_lands):
2621         (test_manual_reject_during_processing):
2622         (StyleQueueTest.test_style_queue_with_style_exception):
2623         (test_style_queue_with_watch_list_exception):
2624
2625 2012-12-20  Dominic Mazzoni  <dmazzoni@google.com>
2626
2627         AX: support clickPoint in DRT for chromium
2628         https://bugs.webkit.org/show_bug.cgi?id=97359
2629
2630         Reviewed by Chris Fleizach.
2631
2632         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
2633         several more tests can pass.
2634
2635         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2636         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2637         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
2638         (WebTestRunner):
2639         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
2640         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2641         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2642         (AccessibilityUIElement):
2643
2644 2012-12-20  Dan Bernstein  <mitz@apple.com>
2645
2646         prepare-ChangeLog adds "Additional information of the change such as approach, rationale" where it doesn't make sense
2647         https://bugs.webkit.org/show_bug.cgi?id=99268
2648
2649         Reviewed by Alexey Proskuryakov.
2650
2651         * Scripts/prepare-ChangeLog:
2652         (generateNewChangeLogs): Removed the "Additional information of the change" line.
2653
2654 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2655
2656         Unreviewed. Skip unit test /webkit/atk/getTextInParagraphAndBodyModerate
2657
2658         * Scripts/run-gtk-tests:
2659         (TestRunner):
2660
2661 2012-12-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2662
2663         [Qt] Move ImageDiff to the Tools directory root
2664         https://bugs.webkit.org/show_bug.cgi?id=105420
2665
2666         Reviewed by Tor Arne Vestbø.
2667
2668         Moved ImageDiff from outside DumpRenderTree because it is also a
2669         dependency when running pixel tests for WebKit2.
2670
2671         * ImageDiff/ImageDiff.pro: Renamed from Tools/DumpRenderTree/qt/ImageDiff.pro.
2672         * ImageDiff/qt/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/qt/ImageDiff.cpp.
2673         * Tools.pro:
2674
2675 2012-12-20  Zan Dobersek  <zandobersek@gmail.com>
2676
2677         [GTK] Remove the --enable-unstable-features configuration option
2678         https://bugs.webkit.org/show_bug.cgi?id=105327
2679
2680         Reviewed by Martin Robinson.
2681
2682         Add a missing feature option for the CSS sticky position feature.
2683
2684         * Scripts/webkitperl/FeatureList.pm:
2685
2686 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2687
2688         Unreviewed. Skip unit test WebKit2.ForceRepaint that times out
2689
2690         * Scripts/run-gtk-tests:
2691         (TestRunner):
2692
2693 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
2694
2695         [EFL] MiniBrowser does not play Infinite Gangnam Style
2696         https://bugs.webkit.org/show_bug.cgi?id=103531
2697
2698         Reviewed by Kenneth Rohde Christiansen.
2699
2700         For EFL we would like this feature to be built by default.
2701
2702         * Scripts/webkitperl/FeatureList.pm:
2703
2704 2012-12-20  Csaba Osztrogonác  <ossy@webkit.org>
2705
2706         [Qt] EWS bots should call qmake always
2707         https://bugs.webkit.org/show_bug.cgi?id=90049
2708
2709         Reviewed by Simon Hausmann.
2710
2711         * Scripts/webkitdirs.pm:
2712         (buildQMakeProjects):
2713
2714 2012-12-20  Jochen Eisinger  <jochen@chromium.org>
2715
2716         [chromium] fix stray printf in TestRunner's WebTestProxy
2717         https://bugs.webkit.org/show_bug.cgi?id=105515
2718
2719         Reviewed by Ryosuke Niwa.
2720
2721         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2722         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
2723
2724 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
2725
2726         [WK2] WebAudio WKTR support
2727         https://bugs.webkit.org/show_bug.cgi?id=95084
2728
2729         Reviewed by Kenneth Rohde Christiansen.
2730
2731         Implementing audio data dump support for WebKitTestRunner,
2732         by adding the API to the IDL, enabling IPC for transferring
2733         the audio data as bytebuffer and dumping it according
2734         to run-webkit-tests script's expectations.
2735         This enables audio testing on WebKit2 ports.
2736         Based on initial wip-patch from Philippe Normand - thanks.
2737
2738         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding setAudioData API.
2739         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Assign audio buffer data to a local WKDataRef after extracting it from WK2 using WKBundleDataFromUint8Array bundle API.
2740         (WTR::TestRunner::setAudioData):
2741         (WTR):
2742         * WebKitTestRunner/InjectedBundle/TestRunner.h: Add a whatToDump state for dumping Audio.
2743         (TestRunner):
2744         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Add audio to the message that's transferred to the WKTR process.
2745         (WTR::InjectedBundle::done):
2746         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Allow setting and audio result handle to be transferred.
2747         (WTR::InjectedBundle::setAudioResult):
2748         (InjectedBundle):
2749         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2750         (WTR::InjectedBundlePage::dump): Dummy handling the Audio case in the switch, build fix for Mac.
2751         * WebKitTestRunner/TestInvocation.cpp: Audio dump support, dump audio if we haven't received a text dump from the web process.
2752         (WTR::TestInvocation::dumpResults):
2753         (WTR):
2754         (WTR::TestInvocation::dumpAudio):
2755         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Storing received audio data before dumping.
2756         * WebKitTestRunner/TestInvocation.h:
2757         (TestInvocation):
2758
2759 2012-12-20  Alberto Garcia  <agarcia@igalia.com>
2760
2761         [GTK] Count failed and timed out tests separately
2762         https://bugs.webkit.org/show_bug.cgi?id=105448
2763
2764         Reviewed by Carlos Garcia Campos.
2765
2766         Display the number of tests that fail, time out and are skipped
2767         separately in the buildbot page.
2768
2769         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2770         (RunGtkAPITests.commandComplete):
2771         (RunGtkAPITests.evaluateCommand):
2772         (RunGtkAPITests.getText2):
2773         * Scripts/run-gtk-tests:
2774         (TestRunner.run_tests):
2775
2776 2012-12-19  Ryosuke Niwa  <rniwa@webkit.org>
2777
2778         PerfTest.parse_output does too much
2779         https://bugs.webkit.org/show_bug.cgi?id=105391
2780
2781         Reviewed by Tony Chang.
2782
2783         Moved the code to filter lines into PerfTest._filter_output, which has been renamed from _filter_stderr.
2784         Also moved the code to output test results into PerfTest._run_with_driver.
2785
2786         * Scripts/webkitpy/performance_tests/perftest.py:
2787         (PerfTest.__init__): Added _description.
2788         (PerfTest.description): Added.
2789         (PerfTest._run_with_driver): Moved the code to output test description and test results.
2790         (PerfTest._filter_output): Moved and renamed from PerfTest._filter_stderr.
2791         (PerfTest.parse_output): Removed the code to output test results. Return test results and description
2792         respectively. Also removed the code that allowed some tests to omit values since all tests report each
2793         iteration now since r136492.
2794         (PerfTest.output_statistics): Removed the code to print test description, now done in _run_with_driver.
2795         (ChromiumStylePerfTest._run_with_driver): Added. Chromium style tests are sufficiently different from
2796         regular PerfTest that it doesn't make much sense to share _run_with_driver. But really, we should just
2797         get rid of this type of test altogether in favor of regular performance tests that uses runner.js.
2798         (ChromiumStylePerfTest.parse_and_log_output): Renamed from parse_output.
2799         (PageLoadingPerfTest._run_with_driver): Removed the explicit '' for the test description.
2800         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2801         (MainTest.test_parse_output): Removed the expected logs since parse_output no longer prints out results.
2802         Also added a call to _filter_output since parse_output doesn't filter the output text anymore.
2803         (MainTest.test_parse_output_with_failing_line): Added a call to _filter_output. Also added ',' after 'Time:'
2804         so that it's not string-concatenated with the next line.
2805         (MainTest.test_parse_output_with_description): Added; a test for PerfTest.description().
2806         (MainTest.test_parse_output_with_subtests): Removed the expected logs, and added a call to _filter_output.
2807
2808 2012-12-19  Alexis Menard  <alexis@webkit.org>
2809
2810         Implement CSS parsing for CSS transitions unprefixed.
2811         https://bugs.webkit.org/show_bug.cgi?id=104804
2812
2813         Reviewed by Dean Jackson.
2814
2815         Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
2816         to cover the work of unprefixing Transforms, Animations and 
2817         Transitions. It will let the possibility of each ports to turn it off 
2818         in their release branches until we're confident that these CSS 
2819         properties are ready to be unprefixed.
2820
2821         * Scripts/webkitperl/FeatureList.pm:
2822         * qmake/mkspecs/features/features.pri:
2823
2824 2012-12-19  Julien Chaffraix  <jchaffraix@webkit.org>
2825
2826         2 clampTo unit tests are failing
2827         https://bugs.webkit.org/show_bug.cgi?id=105253
2828
2829         Reviewed by Emil A Eklund.
2830
2831         Removed clampToUnsigned as it was actually testing exactly what
2832         clampToUnsignedLong was doing. Also made clampToIntFloat more robust
2833         to precision loss (fix suggested by Emil).
2834
2835         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2836
2837 2012-12-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2838
2839         [EFL] Move ImageDiff to the Tools directory root
2840         https://bugs.webkit.org/show_bug.cgi?id=105305
2841
2842         Reviewed by Laszlo Gombos.
2843
2844         We previously moved this directory from the DRT directory to
2845         efl/ImageDiff. The major reason for doing so was because ImageDiff does
2846         not depend on DumpRenderTree but for legacy reasons was living inside the
2847         DRT folder, even though it is needed when running pixel tests for WK2.
2848
2849         Now we are moving to Tool directory root as other ports agreed to do the same.
2850
2851         * CMakeLists.txt:
2852         * ImageDiff/CMakeLists.txt: Added.
2853         * ImageDiff/PlatformEfl.cmake: Added.
2854         * ImageDiff/efl/ImageDiff.cpp: Renamed from Tools/efl/ImageDiff/ImageDiff.cpp.
2855         * efl/ImageDiff/CMakeLists.txt: Removed.
2856
2857 2012-12-19  Zeno Albisser  <zeno@webkit.org>
2858
2859         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
2860         https://bugs.webkit.org/show_bug.cgi?id=105309
2861
2862         The version number is only used as a part
2863         of the library name on Linux.
2864
2865         Reviewed by Kenneth Rohde Christiansen.
2866
2867         * Scripts/webkitdirs.pm:
2868         (builtDylibPathForName):
2869
2870 2012-12-19  Alberto Garcia  <agarcia@igalia.com>
2871
2872         [GTK] Tests that time out are not considered as failures.
2873         https://bugs.webkit.org/show_bug.cgi?id=105318
2874
2875         Reviewed by Martin Robinson.
2876
2877         Fix parsing of the GTK API tests log files.
2878
2879         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2880         (RunGtkAPITests.commandComplete):
2881
2882 2012-12-18  Ilya Tikhonovsky  <loislo@chromium.org>
2883
2884         Unreviewed, rolling out r138061.
2885         https://bugs.webkit.org/show_bug.cgi?id=105396
2886
2887         Original patch:
2888         http://trac.webkit.org/changeset/138061
2889         https://bugs.webkit.org/show_bug.cgi?id=97359
2890
2891         It is crashing on Debug bots
2892
2893         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2894         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2895         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2896         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2897         (AccessibilityUIElement):
2898
2899 2012-12-18  Alice Liu  <alice.liu@apple.com>
2900
2901         Test for https://bugs.webkit.org/show_bug.cgi?id=105106
2902         Add SPI to WebKit1 WebFrame for hit testing
2903
2904         Reviewed by Dan Bernstein.
2905
2906         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/ElementAtPointInWebFrame.mm
2907         * TestWebKitAPI/Tests/mac/ElementAtPointInWebFrame.mm: Added.
2908         (TestWebKitAPI::TEST): Loads html with two divs positioned in the 2nd and 4th quadrants of the webview.
2909         Then hit-tests at three points, expecting to hit the two divs and body element. 
2910
2911 2012-12-18  Alice Liu  <alice.liu@apple.com>
2912
2913         Test for https://bugs.webkit.org/show_bug.cgi?id=105262
2914         Add SPI to WebKit1 WebFrame for node conversion to JSValueRef
2915
2916         Reviewed by Anders Carlsson.
2917
2918         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/JSWrapperForNodeInWebFrame.mm.mm
2919         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm.mm: Added.
2920         (TestWebKitAPI::TEST): Tests for the correct JS wrapper for a DOMNode, provided a WebScriptWorld.
2921         Loads html with a single div element. In an isolated world, creates a property on that node.
2922         Also, in the standard world, creates a different property on that node.  Then tests for 4 things:
2923             - Existence of the isolated property in the isolated world.
2924             - Existence of the standard property in the standard world.
2925             - Non-existence of the isolated property in the standard world.
2926             - Non-existence of the standard property in the isolated world.
2927
2928 2012-12-18  Simon Fraser  <simon.fraser@apple.com>
2929
2930         Disable the SimplifyMarkup API test, wich asserts in debug builds.
2931         Tracked by https://bugs.webkit.org/show_bug.cgi?id=105370.
2932         
2933         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2934         (TestWebKitAPI::TEST):
2935
2936 2012-12-18  Joseph Pecoraro  <pecoraro@apple.com>
2937
2938         [Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)
2939         https://bugs.webkit.org/show_bug.cgi?id=104279
2940
2941         Reviewed by David Kilzer.
2942
2943         Add a build phase script that checks a framework's header files for
2944         Platform.h and Compiler.h macros. Also add some tests for the script.
2945
2946         * Scripts/check-for-inappropriate-macros-in-external-headers: Added.
2947         Script to be used in build phases to check for inappropriate macros in headers.
2948
2949         * Scripts/test-webkitruby: Added.
2950         Script that can be used to run all webkitruby tests.
2951
2952         * Scripts/test-webkit-scripts:
2953         Also run the ruby tests.
2954
2955         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/fake-data-failing-expected.txt: Added.
2956         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/pass-expected.txt: Added.
2957         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Fail.h: Added.
2958         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Pass.h: Added.
2959         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/run-test.rb: Added.
2960         Tests for the new script.
2961
2962 2012-12-18  Dominic Mazzoni  <dmazzoni@google.com>
2963
2964         AX: support clickPoint in DRT for chromium
2965         https://bugs.webkit.org/show_bug.cgi?id=97359
2966
2967         Reviewed by Chris Fleizach.
2968
2969         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
2970         several more tests can pass.
2971
2972         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2973         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2974         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
2975         (WebTestRunner):
2976         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
2977         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2978         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2979         (AccessibilityUIElement):
2980
2981 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
2982
2983         Build fix after r138045.
2984
2985         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2986         (PerfTestsRunner._collect_tests): Use relative_path. We skip only when this path
2987         is not explicitly specified. The condition was backwards but never matched so we
2988         always ran the test regardless of whether it's listed in the skipped list or not.
2989         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2990         (test_collect_tests_with_ignored_skipped_list): Renamed so that it actually runs.
2991
2992 2012-12-18  Emil A Eklund  <eae@chromium.org>
2993
2994         TestWebKitAPI/Tests/WebCore/LayoutUnit fails on mac
2995         https://bugs.webkit.org/show_bug.cgi?id=105332
2996         
2997         Reviewed by Levi Weintraub.
2998         
2999         Create new test suite for LayoutUnit tests as the KURL tests are
3000         of the incompatible TEST_F type.
3001
3002         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3003         (TestWebKitAPI):
3004         (TestWebKitAPI::TEST_F):
3005
3006 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
3007
3008         Running a skipped test with run-perf-tests could alert the user
3009         https://bugs.webkit.org/show_bug.cgi?id=105219
3010
3011         Reviewed by Eric Seidel.
3012
3013         Force run skipped performance tests explicitly specified in the command line.
3014         Also warn the user when the specified paths don't exist.
3015
3016         * Scripts/webkitpy/layout_tests/port/base.py:
3017         (Port.relative_test_filename):
3018         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3019         (PerfTestsRunner._parse_args):
3020         (PerfTestsRunner._collect_tests):
3021         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3022         (test_collect_tests_with_skipped_list_and_files):
3023
3024 2012-12-18  Yaron Friedman  <yfriedman@chromium.org>
3025
3026         Chrome Android java output is too verbose
3027         https://bugs.webkit.org/show_bug.cgi?id=105247
3028
3029         Reviewed by Tony Chang.
3030
3031         Pass -quiet to ant to suppress extraneous output.
3032
3033         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3034         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3035
3036 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
3037
3038         Consider removing --pause-before-testing option
3039         https://bugs.webkit.org/show_bug.cgi?id=105248
3040
3041         Reviewed by Eric Seidel.
3042
3043         Remove --pause-before-testing option.
3044
3045         * Tools/Scripts/webkitpy/layout_tests/port/driver.py:
3046         (DriverProxy.start): Removed.
3047         * Scripts/webkitpy/performance_tests/perftest.py:
3048         (PerfTest.__init__):
3049         (PerfTest.test_path): Renamed from path_or_url.
3050         (PerfTest.run):
3051         (PerfTest): Removed "driver" argument.
3052         (PerfTest._run_with_driver):
3053         (PerfTest.run_single):
3054         (ChromiumStylePerfTest.__init__):
3055         (PageLoadingPerfTest.__init__):
3056         (PageLoadingPerfTest.run_single):
3057         (PageLoadingPerfTest._run_with_driver): Renamed from run so that PerfTest.run can create a driver for us.
3058         (ReplayPerfTest.__init__):
3059         (ReplayPerfTest.prepare):
3060         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3061         (TestPageLoadingPerfTest.test_run):
3062         (TestPageLoadingPerfTest.test_run_with_memory_output):
3063         (TestPageLoadingPerfTest.test_run_with_bad_output):
3064         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3065         (PerfTestsRunner._parse_args):
3066         (PerfTestsRunner._run_tests_set): Removed the code to create a driver and pause before running the test.
3067         (PerfTestsRunner._run_single_test): Removed "driver" argument.
3068         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3069         (run_test):
3070         (test_run_test_pause_before_testing): Removed.
3071
3072 2012-12-18  Alberto Garcia  <agarcia@igalia.com>
3073
3074         [GTK] Tests that time out are not considered as failures.
3075         https://bugs.webkit.org/show_bug.cgi?id=105318
3076
3077         Reviewed by Martin Robinson.
3078
3079         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3080         (RunGtkAPITests.commandComplete):
3081         Consider log lines that end with TIMEOUT as errors.
3082
3083         * Scripts/run-gtk-tests:
3084         (TestRunner.run_tests):
3085         Consider timeouts as failures when returning the number of failed
3086         tests.
3087
3088 2012-12-18  Pravin D  <pravin.d@samsung.com>
3089
3090         Unreviewed, adding secondary email.
3091
3092         * Scripts/webkitpy/common/config/committers.py:
3093
3094 2012-12-18  Pravin D  <pravin.d@samsung.com>
3095
3096         Unreviewed, promoting myself to committer's list.
3097
3098         * Scripts/webkitpy/common/config/committers.py:
3099
3100 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3101
3102         [EFL] ImageDiff does not build on WebKit2 only builds
3103         https://bugs.webkit.org/show_bug.cgi?id=105288
3104
3105         Reviewed by Kenneth Rohde Christiansen.
3106
3107         Moved ImageDiff to the efl/ folder inside Tools/ (so we don't pollute
3108         the folder with things which are EFL-specific.
3109
3110         ImageDiff will be built by default now regardless of WebKit API flavor
3111         you choose.
3112
3113         * CMakeLists.txt:
3114         * DumpRenderTree/efl/CMakeLists.txt:
3115         * efl/ImageDiff/CMakeLists.txt: Added.
3116         * efl/ImageDiff/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/efl/ImageDiff.cpp.
3117
3118 2012-12-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3119
3120         [EFL][WK2] When creating new windows, use the opener's context
3121         https://bugs.webkit.org/show_bug.cgi?id=105283
3122
3123         Reviewed by Laszlo Gombos.
3124
3125         Use the context of the opener if exists.
3126
3127         * MiniBrowser/efl/main.c:
3128         (on_key_down):
3129         (on_window_create):
3130         (window_create):
3131         (elm_main):
3132
3133 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3134
3135         [EFL][WK2] Gardening of TestWebKitAPI tests
3136         https://bugs.webkit.org/show_bug.cgi?id=105268
3137
3138         Reviewed by Kenneth Rohde Christiansen.
3139
3140         Some tests were marked as failing but are passing and the newly added
3141         LayoutUnit should have it's own binary because it conflicts with the
3142         fixture used by KURL and is failing on the bots because of that.
3143
3144         * TestWebKitAPI/CMakeLists.txt:
3145         * TestWebKitAPI/PlatformEfl.cmake:
3146
3147 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
3148
3149         [chromium] move webintent related methods to TestRunner library
3150         https://bugs.webkit.org/show_bug.cgi?id=105164
3151
3152         Reviewed by Darin Fisher.
3153
3154         Also deleted the unused deliveredIntentFailure and
3155         deliveredIntentResult methods.
3156
3157         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3158         (DRTTestRunner::DRTTestRunner):
3159         * DumpRenderTree/chromium/DRTTestRunner.h:
3160         (DRTTestRunner):
3161         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3162         (WebKit):
3163         (WebTestRunner::WebTestDelegate::setCurrentWebIntentRequest):
3164         (WebTestRunner::WebTestDelegate::currentWebIntentRequest):
3165         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3166         (WebKit):
3167         (WebTestProxyBase):
3168         (WebTestRunner::WebTestProxy::registerIntentService):
3169         (WebTestRunner::WebTestProxy::dispatchIntent):
3170         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3171         (WebTestRunner::TestRunner::TestRunner):
3172         (WebTestRunner::TestRunner::sendWebIntentResponse):
3173         (WebTestRunner):
3174         (WebTestRunner::TestRunner::deliverWebIntent):
3175         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3176         (TestRunner):
3177         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3178         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
3179         (WebTestRunner::WebTestProxyBase::registerIntentService):
3180         (WebTestRunner):
3181         (WebTestRunner::WebTestProxyBase::dispatchIntent):
3182         * DumpRenderTree/chromium/WebViewHost.cpp:
3183         (WebViewHost::setCurrentWebIntentRequest):
3184         (WebViewHost::currentWebIntentRequest):
3185         * DumpRenderTree/chromium/WebViewHost.h:
3186         (WebKit):
3187         (WebViewHost):
3188
3189 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
3190
3191         [chromium] move editing callback dumping to the WebTestProxy
3192         https://bugs.webkit.org/show_bug.cgi?id=105013
3193
3194         Reviewed by Darin Fisher.
3195
3196         To decide whether or not to dump the editing callbacks, the WebTestProxy
3197         needs to query the TestRunner. For this purpose, I introduce a
3198         WebTestRunner class that just exposes the shouldDumpEditingCallbacks
3199         method. In contrast to e.g. WebEventSender, the WebTestRunner is just
3200         an interface, and it is not owned by the WebTestInterfaces, but the
3201         embedder of the TestRunner library must provide it. This will change
3202         once all TestRunner methods are in the library.
3203
3204         * DumpRenderTree/DumpRenderTree.gypi:
3205         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3206         (DRTTestRunner::DRTTestRunner):
3207         (DRTTestRunner::reset):
3208         * DumpRenderTree/chromium/DRTTestRunner.h:
3209         (DRTTestRunner):
3210         (DRTTestRunner::taskList):
3211         (DRTTestRunner::WorkQueue::taskList):
3212         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3213         (WebTestRunner):
3214         (WebTestInterfaces):
3215         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3216         (WebKit):
3217         (WebTestRunner):
3218         (WebTestProxyBase):
3219         (WebTestRunner::WebTestProxy::shouldBeginEditing):
3220         (WebTestRunner::WebTestProxy::shouldEndEditing):
3221         (WebTestRunner::WebTestProxy::shouldInsertNode):
3222         (WebTestRunner::WebTestProxy::shouldInsertText):
3223         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
3224         (WebTestRunner::WebTestProxy::shouldDeleteRange):
3225         (WebTestRunner::WebTestProxy::shouldApplyStyle):
3226         (WebTestRunner::WebTestProxy::didBeginEditing):
3227         (WebTestRunner::WebTestProxy::didChangeSelection):
3228         (WebTestRunner::WebTestProxy::didChangeContents):
3229         (WebTestRunner::WebTestProxy::didEndEditing):
3230         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
3231         (WebTestRunner):
3232         (WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
3233         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3234         (WebTestRunner::TestRunner::TestRunner):
3235         (WebTestRunner::TestRunner::~TestRunner):
3236         (WebTestRunner):
3237         (WebTestRunner::TestRunner::reset):
3238         (WebTestRunner::TestRunner::shouldDumpEditingCallbacks):
3239         (WebTestRunner::TestRunner::dumpEditingCallbacks):
3240         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3241         (TestRunner):
3242         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3243         (WebTestRunner::WebTestInterfaces::Internal::testRunner):
3244         (WebTestRunner::WebTestInterfaces::Internal::setTestRunner):
3245         (WebTestInterfaces::Internal):
3246         (WebTestRunner::WebTestInterfaces::Internal::Internal):
3247         (WebTestRunner::WebTestInterfaces::testRunner):
3248         (WebTestRunner):
3249         (WebTestRunner::WebTestInterfaces::setTestRunner):
3250         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3251         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
3252         (WebTestRunner):
3253         (WebTestRunner::WebTestProxyBase::shouldBeginEditing):
3254         (WebTestRunner::WebTestProxyBase::shouldEndEditing):
3255         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
3256         (WebTestRunner::WebTestProxyBase::shouldInsertText):
3257         (WebTestRunner::WebTestProxyBase::shouldChangeSelectedRange):
3258         (WebTestRunner::WebTestProxyBase::shouldDeleteRange):
3259         (WebTestRunner::WebTestProxyBase::shouldApplyStyle):
3260         (WebTestRunner::WebTestProxyBase::didBeginEditing):
3261         (WebTestRunner::WebTestProxyBase::didChangeSelection):
3262         (WebTestRunner::WebTestProxyBase::didChangeContents):
3263         (WebTestRunner::WebTestProxyBase::didEndEditing):
3264         * DumpRenderTree/chromium/TestShell.cpp:
3265         (TestShell::initialize):
3266         (TestShell::createNewWindow):
3267         * DumpRenderTree/chromium/WebViewHost.cpp:
3268         (WebViewHost::shouldBeginEditing):
3269         (WebViewHost::shouldEndEditing):
3270         (WebViewHost::shouldInsertNode):
3271         (WebViewHost::shouldInsertText):
3272         (WebViewHost::shouldChangeSelectedRange):
3273         (WebViewHost::shouldDeleteRange):
3274         (WebViewHost::shouldApplyStyle):
3275         * DumpRenderTree/chromium/WebViewHost.h:
3276         (WebViewHost):
3277
3278 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
3279
3280         [chromium] Fix methods in TestRunner that directly modify the settings instead of going through WebPreferences
3281         https://bugs.webkit.org/show_bug.cgi?id=105154
3282
3283         Reviewed by Tony Chang.
3284
3285         If the settings are modified directly, the embedder can't keep track of
3286         them and might accidentially override the changed settings.
3287
3288         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3289         (WebPreferences):
3290         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3291         (WebTestRunner::TestRunner::TestRunner):
3292         (WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled):
3293         (WebTestRunner):
3294         (WebTestRunner::TestRunner::setMinimumTimerInterval):
3295         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
3296         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3297         (TestRunner):
3298         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3299         (WebTestRunner::WebPreferences::reset):
3300         (WebTestRunner::WebPreferences::applyTo):
3301
3302 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
3303
3304         Unreviewed unit test skipping.
3305
3306         Filed https://bugs.webkit.org/show_bug.cgi?id=105253 to re-enable them.
3307
3308         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3309         (TestWebKitAPI):
3310         (TestWebKitAPI::TEST):
3311
3312 2012-12-17  Dean Jackson  <dino@apple.com>
3313
3314         Unreviewed. Add Silvia Pfeiffer to contributor list.
3315
3316         * Scripts/webkitpy/common/config/committers.py:
3317
3318 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3319
3320         build.webkit.org - add more google windows bots
3321         https://bugs.webkit.org/show_bug.cgi?id=105225
3322
3323         Reviewed by Eric Seidel.
3324
3325         Adds two more windows bots (google-windows-3, a builder, and
3326         google-windows-4, a tester) for the Chromium configs.
3327
3328         * BuildSlaveSupport/build.webkit.org-config/config.json:
3329
3330 2012-12-17  Eric Seidel  <eric@webkit.org>
3331
3332         Cleanup --profiler=perf code a little and allow up to 1000 report files (instead of 100)
3333         https://bugs.webkit.org/show_bug.cgi?id=105217
3334
3335         Reviewed by Dirk Pranke.
3336
3337         Previously --profile would fail strangely if find_unused_filename returned None
3338         (which would happen as soon as we had 100 report files).
3339         Now we'll search through 1000 filenames before giving up (and assert if we failed to find one).
3340         I also made some minor cleanups to the output of perf, and tried to make the
3341         commands more self-documenting by using long-names for args.
3342
3343         * Scripts/webkitpy/common/system/profiler.py:
3344         (SingleFileOutputProfiler.__init__):
3345         (Perf.attach_to_pid):
3346         (Perf.profile_after_exit):
3347
3348 2012-12-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3349
3350         Unreviewed, rolling out r137198.
3351         http://trac.webkit.org/changeset/137198
3352         https://bugs.webkit.org/show_bug.cgi?id=105212
3353
3354         This patch is causing API behavior compatibility problems
3355         (Requested by zdobersek on #webkit).
3356
3357         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3358         (willSendRequestCallback):
3359
3360 2012-12-17  Elliott Sprehn  <esprehn@chromium.org>
3361
3362         Unreviewed. Adding myself to committers list.
3363
3364         * Scripts/webkitpy/common/config/committers.py:
3365
3366 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3367
3368         nrwt: shuffle code around for cleanup in run_webkit_tests.py
3369         https://bugs.webkit.org/show_bug.cgi?id=105078
3370
3371         Reviewed by Ojan Vafai.
3372
3373         This patch reorders functions so that run_webkit_tests can be
3374         understood in a top-down matter better, and to make things slightly
3375         more sensible when I merge manager.py into it.
3376
3377         Also, this adds tests for the actual main() routine, which had several
3378         bugs get through testing a week or two ago.
3379
3380         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3381         (main):
3382         (parse_args):
3383         (_set_up_derived_options):
3384         (run):
3385         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3386         (RunTest):
3387         (RunTest.test_no_http_tests):
3388         (PortTest.disabled_test_mac_lion):
3389         (MainTest):
3390         (MainTest.test_exception_handling):
3391         (MainTest.test_exception_handling.interrupting_run):
3392         (MainTest.test_exception_handling.successful_run):
3393         (MainTest.test_exception_handling.successful_run.FakeRunDetails):
3394         (MainTest.test_exception_handling.exception_raising_run):
3395
3396 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3397
3398         webkitpy: move --lint-test-files code into its own module
3399         https://bugs.webkit.org/show_bug.cgi?id=105077
3400
3401         Reviewed by Eric Seidel.
3402
3403         It really didn't need to be in run_webkit_tests.py anymore.
3404         This patch adds a new lint-test-expectations scripts to Tools/Scripts;
3405         rwt --lint-test-files is still supported for backwards compatibility
3406         for now.
3407
3408         * Scripts/lint-test-expectations: Added.
3409         * Scripts/webkitpy/layout_tests/lint_test_expectations.py: Added.
3410         (lint):
3411         (main):
3412         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py: Added.
3413         (FakePort):
3414         (FakePort.__init__):
3415         (FakePort.test_configuration):
3416         (FakePort.expectations_dict):
3417         (FakePort.skipped_layout_tests):
3418         (FakePort.all_test_configurations):
3419         (FakePort.configuration_specifier_macros):
3420         (FakePort.get_option):
3421         (FakeFactory):
3422         (FakeFactory.__init__):
3423         (FakeFactory.get):
3424         (FakeFactory.all_port_names):
3425         (LintTest):
3426         (LintTest.test_all_configurations):
3427         (LintTest.test_lint_test_files):
3428         (LintTest.test_lint_test_files__errors):
3429         (MainTest):
3430         (MainTest.test_success):
3431         (MainTest.test_success.interrupting_lint):
3432         (MainTest.test_success.successful_lint):
3433         (MainTest.test_success.exception_raising_lint):
3434         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3435         (main):
3436         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3437         (StreamTestingMixin.assertNotEmpty):
3438
3439 2012-12-17  Adam Klein  <adamk@chromium.org>
3440
3441         build-webkit: rename --template-tag to --template-element to match ENABLE #define name
3442         https://bugs.webkit.org/show_bug.cgi?id=105072
3443
3444         Reviewed by Laszlo Gombos.
3445
3446         * Scripts/webkitperl/FeatureList.pm:
3447
3448 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
3449
3450         Add some unit testing for WTF::clampTo* functions
3451         https://bugs.webkit.org/show_bug.cgi?id=105060
3452
3453         Reviewed by Emil A Eklund.
3454
3455         The new tests are targeted at clamping to int / unsigned and float as those are
3456         the one explicitely exposed through more dedicated functions (like clampToInteger,
3457         clampToPositiveInteger and clampToFloat).
3458
3459         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3460
3461 2012-12-17  Eric Seidel  <eric@webkit.org>
3462
3463         rpt --profile --chromium-android throws exception
3464         https://bugs.webkit.org/show_bug.cgi?id=105061
3465
3466         Reviewed by Daniel Bates.
3467
3468         Somehow popen(args) got turned into popen(*args) at some point,
3469         which caused my new stringify code to fail when args was passed by name.
3470         Fixed and tested.
3471
3472         * Scripts/webkitpy/common/system/executive.py:
3473         (Executive._stringify_args):
3474         (Executive):
3475         (Executive.popen):
3476         * Scripts/webkitpy/common/system/executive_unittest.py:
3477         (ExecutiveTest.test_popen_args):
3478
3479 2012-12-17  Mark Pilgrim  <pilgrim@chromium.org>
3480
3481         Use Platform::current() instead of webKitPlatformSupport() in DumpRenderTree
3482         https://bugs.webkit.org/show_bug.cgi?id=105054
3483
3484         Reviewed by Jochen Eisinger.
3485
3486         Part of a refactoring series; see tracking bug 82948.
3487
3488         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3489         (NotificationPresenter::show):
3490         * DumpRenderTree/chromium/Task.cpp:
3491         (postTask):
3492         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
3493
3494 2012-12-17  Emil A Eklund  <eae@chromium.org>
3495
3496         Clamp values in LayoutUnit::operator/ when SATURATED_LAYOUT_ARITHMETIC is enabled
3497         https://bugs.webkit.org/show_bug.cgi?id=104955
3498
3499         Reviewed by Julien Chaffraix.
3500
3501         Add tests for LayoutUnit.
3502
3503         * TestWebKitAPI/CMakeLists.txt:
3504         * TestWebKitAPI/ForwardingHeaders: Added.
3505         * TestWebKitAPI/ForwardingHeaders/WebCore: Added.
3506         * TestWebKitAPI/ForwardingHeaders/WebCore/LayoutUnit.h: Added.
3507         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3508         * TestWebKitAPI/TestWebKitAPI.gypi:
3509         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3510         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Added.
3511         (TestWebKitAPI):
3512         (TestWebKitAPI::TEST):
3513         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3514
3515 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
3516
3517         [chromium] removed unused preferences from testRunner.overridePreference
3518         https://bugs.webkit.org/show_bug.cgi?id=105169
3519
3520         Reviewed by Tony Chang.
3521
3522         Most notably this removes the code related to font family maps which is
3523         now handled via window.internals.settings
3524
3525         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3526         (WebPreferences):
3527         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3528         (WebTestRunner::TestRunner::overridePreference):
3529         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3530         (TestRunner):
3531         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3532         (WebTestRunner::WebPreferences::applyTo):
3533
3534 2012-12-17  James Robinson  <jamesr@chromium.org>
3535
3536         [chromium] Move creation of WebLayerTreeView to WebWidgetClient
3537         https://bugs.webkit.org/show_bug.cgi?id=105071
3538
3539         Reviewed by Adrienne Walker.
3540
3541         Update WebViewHost for the new WebWidgetClient interface.
3542
3543         * DumpRenderTree/chromium/WebViewHost.cpp:
3544         (WebViewHost::initializeLayerTreeView):
3545         (WebViewHost::layerTreeView):
3546         (WebViewHost::~WebViewHost):
3547         * DumpRenderTree/chromium/WebViewHost.h:
3548         (WebViewHost):
3549
3550 2012-12-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3551
3552         [EFL][WK2] window_create doesn't receive the url
3553         https://bugs.webkit.org/show_bug.cgi?id=105184
3554
3555         Reviewed by Alexis Menard.
3556
3557         * MiniBrowser/efl/main.c: Use the url supplied to window_create
3558         (on_window_create):
3559
3560 2012-12-17  Ilya Tikhonovsky  <loislo@chromium.org>
3561
3562         Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
3563         https://bugs.webkit.org/show_bug.cgi?id=105026
3564
3565         Reviewed by Yury Semikhatsky.
3566
3567         Old SFINAE test was replaced with new one based on this article:
3568         http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
3569
3570         New test which covers this problem was added.
3571
3572         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3573
3574 2012-12-17  Anthony Scian  <ascian@rim.com>
3575
3576         [Blackberry] Static code analysis warning fixes
3577         https://bugs.webkit.org/show_bug.cgi?id=105129
3578
3579         Reviewed by Rob Buis.
3580
3581         Added null checks for fopen calls, no recovery attempted; access fault prevention only.
3582
3583         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3584         (BlackBerry::WebKit::createFile):
3585         (BlackBerry::WebKit::DumpRenderTree::runTest):
3586
3587 2012-12-17  John Mellor  <johnme@chromium.org>
3588
3589         Add Anton Vayvod and Tim Volodine as contributors in committers.py
3590         https://bugs.webkit.org/show_bug.cgi?id=105025
3591
3592         Unreviewed. Adds two contributors to committers.py.
3593         They are initially contributing to the Text Autosizing feature (master bug: 84186).
3594
3595         * Scripts/webkitpy/common/config/committers.py:
3596
3597 2012-12-17  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3598
3599         Unreviewed, add myself to committers.py.
3600
3601         * Scripts/webkitpy/common/config/committers.py:
3602
3603 2012-12-17  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
3604
3605         [Qt] remove some unnecessary CONFIG additions
3606
3607         Reviewed by Simon Hausmann.
3608
3609         qt is already added by spec_pre.prf, warn_on and depend_includepath by
3610         default_pre.prf.
3611
3612         * qmake/mkspecs/features/default_post.prf:
3613
3614 2012-12-17  Ilya Tikhonovsky  <loislo@chromium.org>
3615
3616         Unreviewed, rolling out r137892.
3617         http://trac.webkit.org/changeset/137892
3618         https://bugs.webkit.org/show_bug.cgi?id=105026
3619
3620         it broke compilation on windows
3621
3622         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3623
3624 2012-12-14  Ilya Tikhonovsky  <loislo@chromium.org>
3625
3626         Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
3627         https://bugs.webkit.org/show_bug.cgi?id=105026
3628
3629         Reviewed by Yury Semikhatsky.
3630
3631         Old SFINAE test was replaced with new one based on this article:
3632         http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
3633
3634         New test which covers this problem was added.
3635