1 2015-11-20 Michael Catanzaro <mcatanzaro@igalia.com>
3 Unreviewed, fix installation of ninja-build after the previous commit
5 * gtk/install-dependencies:
7 2015-11-20 Michael Catanzaro <mcatanzaro@igalia.com>
9 [GTK] install-dependencies should run installer exactly once
10 https://bugs.webkit.org/show_bug.cgi?id=151477
12 Reviewed by Carlos Garcia Campos.
14 * gtk/install-dependencies:
16 2015-11-20 Csaba Osztrogonác <ossy@webkit.org>
18 [EFL] Enable FTL JIT by default on X86_64
19 https://bugs.webkit.org/show_bug.cgi?id=143822
21 Reviewed by Carlos Garcia Campos.
24 * Scripts/run-javascriptcore-tests:
25 * Scripts/webkitperl/FeatureList.pm:
26 * efl/jhbuild.modules:
28 * jhbuild/jhbuildrc_common.py:
31 2015-11-19 Michael Catanzaro <mcatanzaro@igalia.com>
33 Unreviewed, install llvm-static on Fedora to fix build now FTL is enabled
35 * gtk/install-dependencies:
37 2015-11-19 Commit Queue <commit-queue@webkit.org>
39 Unreviewed, rolling out r192667 and r192668.
40 https://bugs.webkit.org/show_bug.cgi?id=151476
42 broke api tests (Requested by alexchristensen on #webkit).
46 "Remove the non-NetworkProcess configurations"
47 https://bugs.webkit.org/show_bug.cgi?id=151418
48 http://trac.webkit.org/changeset/192667
50 "Fix GTK Build after r192667."
51 http://trac.webkit.org/changeset/192668
53 2015-11-19 Alex Christensen <achristensen@webkit.org>
55 Remove the non-NetworkProcess configurations
56 https://bugs.webkit.org/show_bug.cgi?id=151418
58 Reviewed by Geoffrey Garen.
60 * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
61 (TestWebKitAPI::TEST):
62 * WebKitTestRunner/TestController.cpp:
63 (WTR::TestController::generatePageConfiguration):
65 2015-11-19 Alexey Proskuryakov <ap@apple.com>
67 LayoutTestRelay processes leak on iOS testers
68 https://bugs.webkit.org/show_bug.cgi?id=151447
70 Reviewed by Tim Horton.
72 * BuildSlaveSupport/kill-old-processes: Added LayoutTestRelay.
74 2015-11-19 Brent Fulgham <bfulgham@apple.com>
76 [Win] webkitpy is applying abspath to DOS paths, yielding invalid paths
77 https://bugs.webkit.org/show_bug.cgi?id=151156
81 I tracked down the cause of the test regression on the Windows builders. Once I fixed that,
82 I realized that the new 'abs_results_directory' value was not needed, so this change reverts
85 * Scripts/webkitpy/port/base.py:
86 (Port.to.start_websocket_server): We don't need a special directory variable on Cygwin anymore.
87 (Port.abs_results_directory): Deleted.
88 * Scripts/webkitpy/port/win.py:
89 (WinPort.__init__): Deleted.
90 (WinPort.abs_results_directory): Deleted.
91 (WinPort.results_directory): Deleted.
93 2015-11-19 Alexey Proskuryakov <ap@apple.com>
95 build.webkit.org/dashboard: Move layoutTestResultsDirectoryURLForIteration implementation to base class
96 https://bugs.webkit.org/show_bug.cgi?id=151425
98 Reviewed by Tim Horton.
100 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
101 (Buildbot.prototype.layoutTestResultsDirectoryURLForIteration):
102 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
103 (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Deleted.
105 2015-11-19 Youenn Fablet <youenn.fablet@crf.canon.fr>
107 WPT server should use its own testharness.js file and generate a warning when it does not match WebKit version
108 https://bugs.webkit.org/show_bug.cgi?id=150332
110 Reviewed by Darin Adler and Ryosuke Niwa.
112 Removing testharness.js overwriting from LayoutTests/resources to LayoutTests/imported/w3c/web-platform-tests/resources.
113 Adding support for file comparison in python filesystem.
116 * Scripts/webkitpy/common/system/filesystem.py:
117 (FileSystem.compare): Adding compare as a wrapper around filecmp.cmp.
118 * Scripts/webkitpy/common/system/filesystem_mock.py:
119 (MockFileSystem.compare): Adding a mock compare.
120 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
121 (WebPlatformTestServer.__init__): Removed testharness.js as file to copy from WK to WPT.
122 (WebPlatformTestServer._copy_webkit_test_files): Added warning generation when WK testharness.js is not matching WPT version.
123 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
124 (TestWebPlatformTestServer.test_previously_spawned_instance): Updated tests to add testharness.js to mock filesystem.
125 (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
127 2015-11-18 Jiewen Tan <jiewen_tan@apple.com>
129 [WK1] Crash loading Blink layout test fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
130 https://bugs.webkit.org/show_bug.cgi?id=150198
131 <rdar://problem/23136026>
133 Reviewed by Brent Fulgham.
135 * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
136 (WTR::TestRunner::inspectorTestStubURL):
137 Since WebInspectorUI.framework is not available for iOS, the framework
138 and corresponding functions are disabled in iOS.
140 2015-11-18 Alexey Proskuryakov <ap@apple.com>
142 [Mac] Swipe tests depend on user preferences
143 https://bugs.webkit.org/show_bug.cgi?id=151403
145 Reviewed by Tim Horton.
147 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
148 * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
149 Override these preferences to match the default for a new OS X installation.
151 * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
152 Swipe tests are not enabled in WK1, but let's override the default anyway.
154 2015-11-18 Carlos Garcia Campos <cgarcia@igalia.com>
156 [GTK] Update xserver version in jhbuild
157 https://bugs.webkit.org/show_bug.cgi?id=151383
159 Reviewed by Alejandro G. Castro.
161 In r192568 I assumed the bots would have a recent enough Xvfb
162 to use the -displayfd option, but I forgot we build our own
163 xserver just for Xvfb. The version we build is too old, so
164 we could just use an updated version (the same bots have
165 installed, for example) to use the -displayfd option.
167 * gtk/jhbuild.modules: Update xserver to 1.16.4.
168 * gtk/patches/xserver-fix-glx-init.patch: Deleted.
169 * gtk/patches/xserver-remove-bogus-dependencies.patch: Updated to
172 2015-11-18 Carlos Garcia Campos <cgarcia@igalia.com>
174 Unreviewed. Fix webkitpy tests after r192568.
176 Instead of ignoring exception when closing mock fds, use a helper
177 function that the unit test can override to do nothing.
179 * Scripts/webkitpy/port/xvfbdriver.py:
180 (XvfbDriver._xvfb_close_pipe):
181 (XvfbDriver._xvfb_run):
182 * Scripts/webkitpy/port/xvfbdriver_unittest.py:
183 (XvfbDriverTest.make_driver):
185 2015-11-18 Carlos Garcia Campos <cgarcia@igalia.com>
187 [XvfbDriver] Fail to run all layout tests when X server started with -displayfd option
188 https://bugs.webkit.org/show_bug.cgi?id=151135
190 Reviewed by Darin Adler.
192 The XvfbDriver uses the x server command line to check the
193 displays that are currently in use. This doesn't work when X
194 server was started with -displayfd option. This option is used to let
195 the server find the display id available that is written to the
196 given file descriptor. With this option xorg doesn't need to
197 create the lock files in tmp either. The -displayfd option is also
198 available in Xvfb, so we could use it too. That would simplify the
199 code, fixing also race conditions between the check for available
200 displays and Xvfb opening the connection, we wouldn't need to wait
201 for 4 seconds after launching Xvfb, and all lock files we are
202 using won't be needed either.
204 * Scripts/webkitpy/port/xvfbdriver.py:
205 (XvfbDriver._xvfb_pipe): Helper function to create the pipe, only
206 needed to be overriden by unit tests.
207 (XvfbDriver._xvfb_read_display_id): Helper function to read from
208 the pipe, only needed to be overriden by unit tests.
209 (XvfbDriver._xvfb_run): Run Xvfb with -displayfd option, using a
210 pipe to read the display id.
211 (XvfbDriver._start): Call _xvfb_run() and remove the code to run
212 Xvfb for a given display.
213 (XvfbDriver.stop): Remove code to release and delete file locks.
214 * Scripts/webkitpy/port/xvfbdriver_unittest.py:
215 (XvfbDriverTest.make_driver):
216 (XvfbDriverTest.test_start):
217 (XvfbDriverTest.test_start_arbitrary_worker_number):
218 (XvfbDriverTest.test_stop):
219 (XvfbDriverTest.assertDriverStartSuccessful): Deleted.
220 (XvfbDriverTest): Deleted.
221 (XvfbDriverTest.test_stop.FakeXvfbProcess): Deleted.
223 2015-11-17 Alexey Proskuryakov <ap@apple.com>
225 run-webkit-tests should not truncate persistent lines
226 https://bugs.webkit.org/show_bug.cgi?id=151376
227 rdar://problem/23162775
229 Reviewed by Antti Koivisto.
231 It is OK to truncate progress lines, but it's not OK to truncate error (or otherwise
232 unexpected result) messages that remain on the screen to be read. In practice, this
233 almost always truncates the test path, which is important to see.
235 * Scripts/webkitpy/layout_tests/views/printing.py:
236 (Printer._test_status_line):
237 (Printer.print_finished_test):
238 * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
239 (Testprinter.test_test_status_line):
241 2015-11-16 Carlos Garcia Campos <cgarcia@igalia.com>
243 Unreviewed. Fix GTK+ unit tests after r192469.
245 In r192469 jhbuild version was updated and coinfig lcas API changed.
247 * jhbuild/jhbuildutils.py:
248 (enter_jhbuild_environment_if_available): Pass an empty list for
249 conditions to the Config constructor.
251 2015-11-16 Carlos Garcia Campos <cgarcia@igalia.com>
253 Unreviewed. Use commit id instead of tag name for jhbuild revision.
255 In r192469 I updated the jhbuild version to 3.12.0, and used the
256 tag instead of the commit id to make it easier to read and
257 remember. But we use the commit id to check if the current
258 revision is up to date, and when compared to the tag id it always
259 fails and jhbuild is always updated.
261 * jhbuild/jhbuild-wrapper: Use commit id and add a comment to
262 remember this is the id of 3.12.0.
264 2015-11-16 Carlos Garcia Campos <cgarcia@igalia.com>
266 Unreviewed. Fix GTK+ layout tests running after r192469.
268 We fail to find the Gallium llvmpipe driver because of the build
269 directory change in r192469.
271 * gtk/jhbuildrc: Use buildroot instead of checkoutdir to build
272 the LLVMPIPE_LIBGL_PATH.
274 2015-11-16 Carlos Garcia Campos <cgarcia@igalia.com>
276 [GTK] Use FTL by default when LLVM 3.7 is available
277 https://bugs.webkit.org/show_bug.cgi?id=142128
279 Reviewed by Csaba Osztrogonác.
281 * Scripts/run-javascriptcore-tests: Enable FTL for GTK+ port when
282 architecture is x86_64.
283 * Scripts/update-webkit-libs-jhbuild:
284 (cleanJhbuild): Remove also the separate Build directory used by
286 * Scripts/webkitdirs.pm:
288 * Scripts/webkitperl/FeatureList.pm: Enable FTL by default for
289 GTK+ port when architecture is x86_64.
290 * gtk/jhbuild-optional.modules: Remove llvm.
291 * gtk/jhbuild.modules: Add llvm 3.7 and include it as dependecy
292 only when architecture is x86_64.
293 * gtk/jhbuildrc: Set a buildroot to use a separate build
294 directory. LLVM 3.7 fails to build if configure script is run from
295 source dir. Since it's not possible to use a separate build dir
296 only for llvm, we do it now globally. Modules not supporting non
297 source build dirs are marked in the moduleset. Also set x86_64
298 condition when the architecture is x86_64.
299 * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Removed.
300 * gtk/patches/llvm-elf-add-stackmaps.patch: Removed.
301 * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Removed.
302 * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed.
303 * jhbuild/jhbuild-wrapper: Use a newer jhbuild version to be able
306 2015-11-15 Commit Queue <commit-queue@webkit.org>
308 Unreviewed, rolling out r192462.
309 https://bugs.webkit.org/show_bug.cgi?id=151295
311 failing python tests (Requested by youenn on #webkit).
315 "WPT server should use its own testharness.js file and
316 generate a warning when it does not match WebKit version"
317 https://bugs.webkit.org/show_bug.cgi?id=150332
318 http://trac.webkit.org/changeset/192462
320 2015-11-15 Youenn Fablet <youenn.fablet@crf.canon.fr>
322 WPT server should use its own testharness.js file and generate a warning when it does not match WebKit version
323 https://bugs.webkit.org/show_bug.cgi?id=150332
325 Reviewed by Darin Adler.
327 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
328 (WebPlatformTestServer.__init__): Removed testharness.js as file to copy from WK to WPT.
329 (WebPlatformTestServer._copy_webkit_test_files): Added warning generation when WK testharness.js is not matching WPT version.
331 2015-11-14 Nan Wang <n_wang@apple.com>
333 AX: add a new trait for elements in fieldset on iOS
334 https://bugs.webkit.org/show_bug.cgi?id=151281
336 Reviewed by Chris Fleizach.
338 * DumpRenderTree/AccessibilityUIElement.cpp:
339 (assistiveTechnologySimulatedFocusCallback):
340 (fieldsetAncestorElementCallback):
341 (childAtIndexCallback):
342 (getElementTextLengthCallback):
343 (hasContainedByFieldsetTraitCallback):
344 (AccessibilityUIElement::getJSClass):
345 * DumpRenderTree/AccessibilityUIElement.h:
346 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
347 (AccessibilityUIElement::elementTextLength):
348 (AccessibilityUIElement::hasContainedByFieldsetTrait):
349 (AccessibilityUIElement::fieldsetAncestorElement):
350 (AccessibilityUIElement::url):
351 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
352 (WTR::AccessibilityUIElement::scrollPageDown):
353 (WTR::AccessibilityUIElement::scrollPageLeft):
354 (WTR::AccessibilityUIElement::scrollPageRight):
355 (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
356 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
357 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
358 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
359 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
360 (WTR::AccessibilityUIElement::identifier):
361 (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
362 (WTR::AccessibilityUIElement::fieldsetAncestorElement):
363 (WTR::AccessibilityUIElement::rowCount):
365 2015-11-13 Keith Miller <keith_miller@apple.com>
367 Unreviewed, change JavaScriptCore watchlist to exclude inspector things.
369 * Scripts/webkitpy/common/config/watchlist:
371 2015-11-13 Tim Horton <timothy_horton@apple.com>
373 Support printing in WKWebView
374 https://bugs.webkit.org/show_bug.cgi?id=151276
375 <rdar://problem/23525715>
377 Reviewed by Beth Dakin.
379 * MiniBrowser/mac/MainMenu.xib:
380 * MiniBrowser/mac/WK1BrowserWindowController.m:
381 (-[WK1BrowserWindowController printWebView:]):
382 * MiniBrowser/mac/WK2BrowserWindowController.m:
383 (-[WK2BrowserWindowController printWebView:]):
384 Hook up printing to Minibrowser!
386 2015-11-13 Tim Horton <timothy_horton@apple.com>
388 Hardware keyboard spacebar scrolls too far on iOS
389 https://bugs.webkit.org/show_bug.cgi?id=151227
390 <rdar://problem/23500681>
392 Reviewed by Simon Fraser.
394 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
395 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
396 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
397 (WTR::UIScriptController::setDidEndScrollingCallback):
398 (WTR::UIScriptController::didEndScrollingCallback):
399 (WTR::UIScriptController::platformSetDidEndScrollingCallback):
400 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
401 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
402 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
403 (-[TestRunnerWKWebView dealloc]):
404 (-[TestRunnerWKWebView _didFinishScrolling]):
405 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
406 (WTR::UIScriptController::platformSetDidEndScrollingCallback):
407 (WTR::UIScriptController::platformClearAllCallbacks):
408 Expose _didFinishScrolling on WKWebView to the UIScriptController.
410 2015-11-13 Brent Fulgham <bfulgham@apple.com>
412 [Win] Unreviewed test fix.
414 * Scripts/webkitpy/port/win.py:
415 (WinPort.results_directory): Our 'results_directory' should be an absolute path (even when not
416 using Cygwin), but should be in DOS format for non-Cygwin clients.
418 2015-11-12 Daniel Bates <dabates@apple.com>
420 Add my apple.com email address to contributors.json
422 * Scripts/webkitpy/common/config/contributors.json:
424 2015-11-12 Daniel Bates <dabates@apple.com>
426 webkitpy: Remove extraneous word "the" from the description of command attach-to-bug
428 * Scripts/webkitpy/tool/commands/upload.py:
431 2015-11-12 Brent Fulgham <bfulgham@apple.com>
433 [Win] webkitpy is applying abspath to DOS paths, yielding invalid paths
434 https://bugs.webkit.org/show_bug.cgi?id=151156
436 Reviewed by Anders Carlsson.
438 My earlier patch was incomplete. There are some Python libraries that want
439 to receive UNIX style paths, even though all of our applications and tools
440 use DOS paths. To handle this special case, we need to track a UNIX-style
441 absolute path that can be given to things like the Python socket server.
443 When we cut over to all-native Windows Python we can get rid of this
446 * Scripts/webkitpy/common/system/filesystem.py:
447 (FileSystem.abspath): Add special code for Cygwin to convert a DOS-style
448 path into something Cygwin can use internally.
449 * Scripts/webkitpy/port/base.py:
450 (Port.results_directory): Remove custom Windows code. Instead, override
451 the method in the windows port object.
452 (Port.abs_results_directory): Add stub.
453 (Port.to.start_websocket_server): For Cygwin, use special cygwin absolute
455 * Scripts/webkitpy/port/win.py:
456 (WinPort.__init__): Added to initialze new _abs_results_directory value.
457 (WinPort.abs_results_directory): Added,
458 (WinPort.results_directory): Modified to also create a value for
459 _abs_results_directory
461 2015-11-12 Keith Miller <keith_miller@apple.com>
463 Unreviewed, add Michael Saboff to the JavaScriptCore watchlist, per request.
465 * Scripts/webkitpy/common/config/watchlist:
467 2015-11-12 Keith Miller <keith_miller@apple.com>
469 Unreviewed, add watchlist for Source/JavaScriptCore and add myself, Saam, and Mark.
471 * Scripts/webkitpy/common/config/watchlist:
473 2015-11-12 Daniel Bates <dabates@apple.com>
475 Support building configuration Production of DumpRenderTree and WebKitTestRunner for iOS
476 https://bugs.webkit.org/show_bug.cgi?id=151191
478 Reviewed by Andy Estes.
480 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove hardcoded SKIP_INTALL.
481 Will override this setting in DumpRenderTree.xcconfig.
482 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: When building for iOS we now
483 compile source file DumpRenderTreeMain.mm to produce a built product and make the Apple
484 Internal build system happy. Do not waste time coping OpenType font files (*.otf files)
485 and skip installation when building for iOS since we are not interested in the build product
486 and are only building this target to make the Apple Internal build system happy.
487 * DumpRenderTree/mac/DumpRenderTreeMain.mm:
488 (main): Added dummy implementation for iOS so that we build an actual command line tool to
489 make the Apple Internal build system happy.
490 * WebKitTestRunner/Configurations/Base.xcconfig: Add iOS-specific definition for WEBKIT_UMBRELLA_FRAMEWORKS_DIR.
491 * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Remove variable WEBKIT_UMBRELLA_FRAMEWORKS_DIR.
492 * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Build file WebKitTestRunner/mac/main.mm
493 on iOS Only to produce a built product and make the Apple Internal build system happy. No need
494 to define OTHER_LDFLAGS when building this target for iOS as the default linker flags are sufficient.
495 * WebKitTestRunner/mac/main.mm:
496 (main): Added dummy implementation for iOS so that we build an actual command line tool to
497 make the Apple Internal build system happy.
499 2015-11-12 Chris Dumez <cdumez@apple.com>
501 Unreviewed, add watchlist for history/ and add myself.
503 * Scripts/webkitpy/common/config/watchlist:
505 2015-11-12 Chris Dumez <cdumez@apple.com>
507 Unreviewed, update my watchlists.
509 * Scripts/webkitpy/common/config/watchlist:
511 2015-11-12 Daniel Bates <dabates@apple.com>
513 Rename webkitdirs::willUseIOS{Device, Simulator}SDKWhenBuilding() to willUseIOS{Device, Simulator}SDK()
514 https://bugs.webkit.org/show_bug.cgi?id=151207
516 Rubber-stamped by Alexey Proskuryakov.
518 The functions webkitdirs::willUseIOS{Device, Simulator}SDKWhenBuilding() are not specific to building
519 iOS software. We should rename these functions to webkitdirs::willUseIOS{Device, Simulator}SDK() to
520 convey their general-purpose nature of determining whether we are using the iphoneos or iphonesimulator SDK.
523 * Scripts/build-layouttestrelay:
524 * Scripts/build-webkit:
525 * Scripts/copy-webkitlibraries-to-product-directory:
526 * Scripts/run-api-tests:
528 (prepareEnvironmentForRunningTestTool):
529 * Scripts/run-javascriptcore-tests:
530 * Scripts/webkitdirs.pm:
532 (willUseIOSDeviceSDK): Formerly named willUseIOSDeviceSDKWhenBuilding.
533 (willUseIOSSimulatorSDK): Formerly name willUseIOSSimulatorSDKWhenBuilding.
536 (willUseIOSDeviceSDKWhenBuilding): Deleted.
537 (willUseIOSSimulatorSDKWhenBuilding): Deleted.
539 2015-11-12 Daniel Bates <dabates@apple.com>
541 run-api-tests fails to run with public iOS SDK
542 https://bugs.webkit.org/show_bug.cgi?id=151076
544 Reviewed by Alexey Proskuryakov.
546 Use the command line tool simctl as the sim tool was removed from the public iOS 9 SDK.
548 A side benefit of this change it is sufficient to run the tests without launching Simulator.app
549 to boot the simulator device beforehand because simctl will boot the device for us.
551 Additionally, use Perl pragma sigtrap to install signal handlers to catch SIG{HUP, INT, PIPE, TERM}
552 signals and ultimately run our END block so that we shutdown the simulator device (if applicable).
553 This makes Control-C terminate the app gracefully.
555 * Scripts/run-api-tests:
558 (prepareEnvironmentForRunningTestTool): When running for iOS Simulator use setupIOSWebKitEnvironment()
559 to setup the environment variables for iOS instead of using setupMacWebKitEnvironment(). We also
560 prefix the name of these environment variables with "SIMCTL_CHILD_" so that simctl sets these environment
561 variables in the simulator environment.
562 * Scripts/webkitdirs.pm:
563 (shutDownIOSSimulatorDevice): Added.
564 (restartIOSSimulatorDevice): Added.
566 2015-11-12 KwangHyuk Kim <hyuki.kim@samsung.com>
568 [EFL] fix EvasGL configuration error
569 https://bugs.webkit.org/show_bug.cgi?id=151180
571 Reviewed by Csaba Osztrogonác.
573 EvasGL backend and depth, stencil buffer size should be specified before elm_win_add to let EvasGL keep quiet.
574 Additionally, duplicated elm_config_accel_preference_set() call is eleminated.
576 * MiniBrowser/efl/main.c:
580 2015-11-12 Csaba Osztrogonác <ossy@webkit.org>
582 [EFL] Fix EFL 1.16 with enabled NEON support
583 https://bugs.webkit.org/show_bug.cgi?id=151188
585 Unreviewed buildfix, disable NEON temporarily after r192358.
587 * efl/jhbuild.modules:
589 2015-11-12 Csaba Osztrogonác <ossy@webkit.org>
591 [EFL] Bump EFL version to 1.16.0
592 https://bugs.webkit.org/show_bug.cgi?id=150228
594 Reviewed by Gyuyoung Kim.
596 * efl/jhbuild.modules:
597 * efl/patches/efl-remove-XPrint.patch: Removed.
599 2015-11-12 Csaba Osztrogonác <ossy@webkit.org>
601 Remove ENABLE(SATURATED_LAYOUT_ARITHMETIC) guards
602 https://bugs.webkit.org/show_bug.cgi?id=150972
604 Reviewed by Darin Adler.
606 * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
608 2015-11-12 KwangHyuk Kim <hyuki.kim@samsung.com>
610 [EFL] fix EvasGL configuration error
611 https://bugs.webkit.org/show_bug.cgi?id=151180
613 Reviewed by Gyuyoung Kim.
615 EvasGL backend and depth, stencil buffer size should be specified before elm_win_add to let EvasGL keep quiet
617 * MiniBrowser/efl/main.c:
620 2015-11-11 Brent Fulgham <bfulgham@apple.com>
622 [Win] webkitpy is applying abspath to DOS paths, yielding invalid paths
623 https://bugs.webkit.org/show_bug.cgi?id=151156
625 Reviewed by Anders Carlsson.
627 * Scripts/webkitpy/port/base.py:
628 (Port.results_directory): Don't pass paths through 'abspath'
629 (Port._build_path): Ditto.
630 * Scripts/webkitpy/port/win.py:
631 (WinPort._build_path): Ditto.
633 2015-11-11 Akos Kiss <akiss@inf.u-szeged.hu>
635 Unreviewed, add myself to the committers list.
637 * Scripts/webkitpy/common/config/contributors.json:
639 2015-11-11 Anders Carlsson <andersca@apple.com>
641 _WKRemoteObjectInterface should handle specifying allowed classes for reply block arguments
642 https://bugs.webkit.org/show_bug.cgi?id=151144
644 Reviewed by Tim Horton.
646 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
647 (remoteObjectInterface):
648 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
650 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
651 (-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
652 (-[RemoteObjectRegistryPlugIn selectionAndClickInformationForClickAtPoint:completionHandler:]):
654 2015-11-10 Wenson Hsieh <wenson_hsieh@apple.com>
656 UI-side scripts in WebKitTestRunner should wait until event handling completes before finishing
657 https://bugs.webkit.org/show_bug.cgi?id=151101
658 <rdar://problem/23428601>
660 Reviewed by Simon Fraser.
662 WebKitTestRunner may still crash in the scenario where a marker event is dequeued and handled
663 after uiScriptComplete has been called. This patch teaches the UI script execution context to
664 defer script completion until all non-persistent tasks (currently tap, double tap and hardware
665 keyboard) have been handled, so marker events will no longer bleed through tests.
667 We accomplish this by changing the behavior of uiScriptComplete. When calling uiScriptComplete,
668 we store that a request to complete the UI-side script for the current parent callback has been
669 made. Subsequently, when a callback (either persistent or non-persistent) finishes invoking and
670 a request has been made to complete the UI script (this request may have been made when running
671 a previous callback) we check if all the non-persistent callbacks that have the same parent
672 callback as the current one have finished. If so, we complete the callback immediately;
673 otherwise, we wait until the in-flight non-persistent callbacks finish execution to complete the
676 This patch also refactors some logic in UIScriptContext. It introduces a new convention for
677 assigning IDs to callbacks: IDs 1000 and above are treated as non-persistent callbacks, whereas
678 IDs between 0 and 999 are persistent task callbacks. This is similar to the existing convention
679 for assigning IDs in the 100s range to parent callbacks, and allows us to easily differentiate
680 between callbacks that are persistent and non-persistent, as well as determine when an existing
681 persistent callback must be unregistered before a new callback function can be set.
683 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
684 (isPersistentCallbackID):
685 (UIScriptContext::runUIScript):
686 (UIScriptContext::nextTaskCallbackID):
687 (UIScriptContext::prepareForAsyncTask):
688 (UIScriptContext::asyncTaskComplete):
689 (UIScriptContext::registerCallback):
690 (UIScriptContext::fireCallback):
691 (UIScriptContext::requestUIScriptCompletion):
692 (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
693 (UIScriptContext::currentParentCallbackHasOutstandingAsyncTasks):
694 (UIScriptContext::uiScriptComplete): Deleted.
695 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
696 (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
697 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
698 (WTR::UIScriptController::setWillBeginZoomingCallback):
699 (WTR::UIScriptController::willBeginZoomingCallback):
700 (WTR::UIScriptController::setDidEndZoomingCallback):
701 (WTR::UIScriptController::didEndZoomingCallback):
702 (WTR::UIScriptController::setDidShowKeyboardCallback):
703 (WTR::UIScriptController::didShowKeyboardCallback):
704 (WTR::UIScriptController::setDidHideKeyboardCallback):
705 (WTR::UIScriptController::didHideKeyboardCallback):
706 (WTR::UIScriptController::uiScriptComplete):
707 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
708 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
709 (WTR::UIScriptController::doAsyncTask):
710 (WTR::UIScriptController::zoomToScale):
711 (WTR::UIScriptController::singleTapAtPoint):
712 (WTR::UIScriptController::doubleTapAtPoint):
713 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
714 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
715 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
716 (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
717 (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
718 (WTR::UIScriptController::platformClearAllCallbacks): Deleted.
719 * WebKitTestRunner/mac/UIScriptControllerMac.mm:
720 (WTR::UIScriptController::doAsyncTask):
722 2015-11-10 Daniel Bates <dabates@apple.com>
724 Teach Makefile to build LayoutTestRelay when building for iOS Simulator
725 https://bugs.webkit.org/show_bug.cgi?id=150849
727 Reviewed by Alexey Proskuryakov.
729 Unless variable DO_NOT_BUILD_LAYOUT_TEST_RELAY is non-empty, build LayoutTestRelay when
730 building WebKit tools.
734 2015-11-10 David Kilzer <ddkilzer@apple.com>
736 [check-webkit-style] False positive (readability/enum_casing) on CF-styled enum members
737 <http://webkit.org/b/104417>
739 Reviewed by Brent Fulgham.
741 * Scripts/webkitpy/style/checkers/cpp.py:
742 (_EnumState.process_clean_line): Allow 'k' to start enums.
743 (check_enum_casing): Update error message to discuss 'k'.
744 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
745 (NoNonVirtualDestructorsTest.test_enum_casing): Update error
746 messages, and add new tests for enums that start with lowercase
749 2015-11-10 Geoffrey Garen <ggaren@apple.com>
751 run-jsc-benchmarks doesn't work with internal benchmarks
752 https://bugs.webkit.org/show_bug.cgi?id=151047
754 Reviewed by Filip Pizlo.
756 * Scripts/run-jsc-benchmarks: Use Pathname so we get a "/" inserted when
759 2015-11-10 Carlos Garcia Campos <cgarcia@igalia.com>
761 [GTK] Use CROSS_PLATFORM_CONTEXT_MENUS
762 https://bugs.webkit.org/show_bug.cgi?id=150642
764 Reviewed by Martin Robinson.
766 Remove test for input methods submenu.
768 * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
770 2015-11-09 Joonghun Park <jh718.park@samsung.com>
772 Unreviewed, add myself to the committers list.
774 * Scripts/webkitpy/common/config/contributors.json:
776 2015-11-09 Ryuan Choi <ryuan.choi@navercorp.com>
778 [EFL] Crash while opening child webview with EWK_PROCESS_MODEL_MULTIPLE_SECONDARY
779 https://bugs.webkit.org/show_bug.cgi?id=145924
781 Reviewed by Gyuyoung Kim.
783 * MiniBrowser/efl/main.c:
786 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
787 (TestWebKitAPI::TEST):
788 * TestWebKitAPI/efl/PlatformWebView.cpp:
789 (TestWebKitAPI::PlatformWebView::PlatformWebView):
790 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
791 (WTR::PlatformWebView::PlatformWebView):
793 2015-11-09 Anders Carlsson <andersca@apple.com>
795 Add reply blocks to _WKRemoteObjectInterface similar to NSXPCConnection
796 https://bugs.webkit.org/show_bug.cgi?id=151056
797 rdar://problem/23222609
799 Reviewed by Tim Horton.
803 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
805 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
806 (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
808 2015-11-09 Tim Horton <timothy_horton@apple.com>
810 Add drawsBackground SPI to WKWebView, and get rid of drawsTransparentBackground from WebKit2
811 https://bugs.webkit.org/show_bug.cgi?id=151054
812 <rdar://problem/22907994>
814 Reviewed by Simon Fraser.
816 * MiniBrowser/mac/WK1BrowserWindowController.m:
817 (-[WK1BrowserWindowController didChangeSettings]):
818 * MiniBrowser/mac/WK2BrowserWindowController.m:
819 (-[WK2BrowserWindowController didChangeSettings]):
820 Use drawsBackground instead, and make sure to set the window background color,
821 otherwise it might end up being gray anyway!
823 WebKit1 still doesn't work unless you turn off toolbar blurring, but at least
824 WebKit2 is working now!
826 2015-11-09 Isaac Devine <isaac@devinesystems.co.nz>
828 Fresh checkout fails to build on windows, DumpRenderTree can't find cairo_win.h
829 https://bugs.webkit.org/show_bug.cgi?id=151013
831 Use the variable defined in the CMake scripts to determine the cairo include location, rather
832 than relying on a environment variable to be set correctly. Otherwise the DumpRenderTreeLib.vcxproj will
833 contain "\include\cairo" rather than the fully qualified path to the cairo include location.
835 Reviewed by Darin Adler.
837 * DumpRenderTree/PlatformWin.cmake:
839 2015-11-09 Csaba Osztrogonác <ossy@webkit.org>
841 [EFL] Fix the gst-plugins-bad jhbuild module build on Ubuntu 15.10
842 https://bugs.webkit.org/show_bug.cgi?id=150928
844 Reviewed by Gyuyoung Kim.
846 * efl/jhbuild.modules:
848 2015-11-07 Daniel Bates <dabates@apple.com>
850 Attempt to fix the Windows EWS bot after r192087
851 (https://bugs.webkit.org/show_bug.cgi?id=150859)
853 Following r192087 Port._build_path() stores the computed root directory path in option
854 _cached_root instead of overwriting option root. We need to teach the Windows-specific
855 logic to make use of option _cached_root instead of option root when computing its adjusted
856 path and to cache its adjusted in _cached_root instead of root.
858 * Scripts/webkitpy/port/win.py:
859 (WinPort._build_path):
861 2015-11-06 Daniel Bates <dabates@apple.com>
863 Do not build LayoutTestRelay when --root is specified to run-webkit-tests
864 https://bugs.webkit.org/show_bug.cgi?id=150989
866 Reviewed by Alexey Proskuryakov.
868 The script run-webkit-tests should only check if LayoutTestRelay exists when invoked with
869 --root and exit with an error if it does not exist. That is, we should not build LayoutTestRelay
870 when it does not exist and an explicit directory of built executables was specified via --root.
871 This will make the criterion for building LayoutTestRelay match the criterion for building
872 DumpRenderTree/WebKitTestRunner.
874 * Scripts/webkitpy/port/ios.py:
875 (IOSSimulatorPort._check_port_build): Moved logic from IOSSimulatorPort.{_check_build_relay, check_build} to here.
876 (IOSSimulatorPort._check_build_relay): Deleted.
877 (IOSSimulatorPort.check_build): Deleted.
879 2015-11-06 Tim Horton <timothy_horton@apple.com>
881 Add preliminary (SPI) support for NSTextFinder on WKWebView
882 https://bugs.webkit.org/show_bug.cgi?id=150907
883 <rdar://problem/19171624>
885 Reviewed by Darin Adler.
887 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
888 * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm: Added.
889 (-[FindInPageNavigationDelegate webView:didFinishNavigation:]):
893 * WebEditingTester/WK1WebDocumentController.m:
894 * WebEditingTester/WK2WebDocumentController.m:
895 (-[WK2WebDocumentController awakeFromNib]):
896 (-[WK2WebDocumentController contentView]):
897 Use incremental find, and show the overlay/indicator.
899 2015-11-06 Alexey Proskuryakov <ap@apple.com>
901 iOS test results are not visible on the flakiness dashboard
902 https://bugs.webkit.org/show_bug.cgi?id=150884
904 Reviewed by Darin Adler.
906 One more change was needed for the minimal fix.
908 * TestResultServer/static-dashboards/flakiness_dashboard.js:
910 2015-11-06 Daniel Bates <dabates@apple.com>
912 Teach Makefile to build LayoutTestRelay when building for iOS Simulator
913 https://bugs.webkit.org/show_bug.cgi?id=150849
915 Reviewed by Alexey Proskuryakov.
917 Override the user-specified arguments SDKROOT and ARCHS to use the default SDK
918 and default ARCHS since LayoutTestRelay is a Mac command line tool.
920 * LayoutTestRelay/Makefile: Define OVERRIDE_SDKROOT and OVERRIDE_ARCHS.
922 2015-11-05 Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au>
924 Add runtime and compile time flags for enabling Web Animations API and model.
925 https://bugs.webkit.org/show_bug.cgi?id=150914
927 Reviewed by Benjamin Poulain.
929 Add ENABLE_WEB_ANIMATIONS compile time flag, runtime flag webAnimationsEnabled and Expose WK2 preference for runtime flag.
931 * Scripts/webkitperl/FeatureList.pm:
933 2015-11-05 Ryuan Choi <ryuan.choi@navercorp.com>
935 [EFL] Separate beforeunload confirm callback from confirm callback
936 https://bugs.webkit.org/show_bug.cgi?id=150964
938 Reviewed by Gyuyoung Kim.
940 * MiniBrowser/efl/main.c:
941 (on_javascript_before_unload_confirm):
944 2015-11-05 Jason Marcell <jmarcell@apple.com>
946 run-webkit-test should look in --root directory for LayoutTestRelay
947 https://bugs.webkit.org/show_bug.cgi?id=150859
949 Reviewed by Daniel Bates.
951 For iOS run-webkit-tests, use LayoutTestRelay specified by --root; otherwise find
952 LayoutTestRelay in the Mac build directory when --root is unspecified.
954 * Scripts/webkitpy/port/base.py:
955 (Port._build_path): Use '_cached_root' instead of 'root' so that we don't overwrite the
956 argument that was passed in via the --root argument.
957 * Scripts/webkitpy/port/ios.py:
958 (IOSSimulatorPort.relay_path):
960 2015-11-05 David Kilzer <ddkilzer@apple.com>
962 TestWebKitAPI crashed in TestWebKitAPI: TestWebKitAPI::SharedBufferTest_copyBufferCreatedWithContentsOfExistingFile_Test::TestBody
963 <http://webkit.org/b/150931>
964 <rdar://problem/23409384>
966 Reviewed by Youenn Fablet.
968 * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
969 (TestWebKitAPI::TEST_F(SharedBufferTest, copyBufferCreatedWithContentsOfExistingFile)):
970 - Switch from strnstr() to memcmp() since strings are
971 not guaranteed to be NULL-terminated.
972 - Add another expectation that the size is greater than
973 zero since memcmp() returns 0 (matching) if the length
975 (TestWebKitAPI::TEST_F(SharedBufferTest, appendBufferCreatedWithContentsOfExistingFile)):
976 - Same change to keep tests consistent, although the
977 second string is NULL-terminated in this case.
979 2015-11-05 Commit Queue <commit-queue@webkit.org>
981 Unreviewed, rolling out r192073.
982 https://bugs.webkit.org/show_bug.cgi?id=150962
984 "Broke the internal iOS build; will investigate offline"
985 (Requested by dydz on #webkit).
989 "Teach Makefile to build LayoutTestRelay when building for iOS
991 https://bugs.webkit.org/show_bug.cgi?id=150849
992 http://trac.webkit.org/changeset/192073
994 2015-11-05 Daniel Bates <dabates@apple.com>
996 Teach Makefile to build LayoutTestRelay when building for iOS Simulator
997 https://bugs.webkit.org/show_bug.cgi?id=150849
999 Reviewed by Alexey Proskuryakov.
1001 * LayoutTestRelay/Makefile: Temporarily override SDKROOT when it is iphonesimulator so
1002 that we build with the default SDK. We assume that the default SDK is the OS X SDK.
1003 * Makefile: Append LayoutTestRelay to the list of modules to build when building with
1004 SDK iphonesimulator.
1006 2015-11-05 Ryuan Choi <ryuan.choi@navercorp.com>
1008 [EFL] Add try_close API to handle beforeunload event
1009 https://bugs.webkit.org/show_bug.cgi?id=150705
1011 Reviewed by Gyuyoung Kim.
1013 * MiniBrowser/efl/main.c:
1014 (on_window_deletion):
1015 Call ewk_view_try_close instead of removing object directly.
1016 (window_create): Fixed that passes wrong data.
1018 2015-11-04 Wenson Hsieh <wenson_hsieh@apple.com>
1020 Fix crashing and flaky UIScriptController-based tests in fast/events/ios
1021 https://bugs.webkit.org/show_bug.cgi?id=150901
1022 <rdar://problem/23261499>
1024 Reviewed by Simon Fraser.
1026 Clear out zooming and keyboard-related callbacks after uiScriptComplete has been invoked. This prevents
1027 later tests from calling into code which previous tests attached to these callbacks and causing
1028 WebKitTestRunner to crash due to accessing a deallocated UIScriptController.
1030 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1031 (WTR::UIScriptController::platformClearAllCallbacks):
1032 (WTR::UIScriptController::uiScriptComplete):
1033 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1034 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1035 (WTR::UIScriptController::platformClearAllCallbacks):
1037 2015-11-04 Jer Noble <jer.noble@apple.com>
1039 [iOS] <video> elements without audio tracks should not interrupt music
1040 https://bugs.webkit.org/show_bug.cgi?id=149888
1042 Reviewed by Eric Carlson.
1044 Add tests to ensure that the AVAudioSession category is correctly set when playing
1045 back media both with and without audio tracks.
1047 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1048 * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm: Added.
1049 (-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
1050 (TestWebKitAPI::TEST):
1051 * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html: Added.
1052 * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.mp4: Added.
1053 * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html: Added.
1054 * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.mp4: Added.
1056 2015-11-04 Alexey Proskuryakov <ap@apple.com>
1058 iOS test results are not visible on the flakiness dashboard
1059 https://bugs.webkit.org/show_bug.cgi?id=150884
1061 Reviewed by Darin Adler.
1063 Re-generated builders.jsonp using generate_builders_json.py.
1065 I think that this is all that's needed for basic support. There is more work needed
1066 to display test expectations, but that's already mostly broken even for Mac.
1068 * TestResultServer/static-dashboards/builders.jsonp:
1070 2015-11-03 Commit Queue <commit-queue@webkit.org>
1072 Unreviewed, rolling out r191995.
1073 https://bugs.webkit.org/show_bug.cgi?id=150880
1075 Broke iOS tests (Requested by ap on #webkit).
1079 "run-webkit-test should look in --root directory for
1081 https://bugs.webkit.org/show_bug.cgi?id=150859
1082 http://trac.webkit.org/changeset/191995
1084 2015-11-03 Said Abou-Hallawa <sabouhallawa@apple.com>
1086 Add graphics benchmark to performance bot
1087 https://bugs.webkit.org/show_bug.cgi?id=150450
1089 Reviewed by Chris Dumez.
1091 * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Added.
1092 * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Added.
1093 Add a patch and a plan to set the defaults of the benchmark, run it,
1094 collect the result and report it to the benchmark runner.
1096 2015-11-03 Jason Marcell <jmarcell@apple.com>
1098 run-webkit-test should look in --root directory for LayoutTestRelay
1099 https://bugs.webkit.org/show_bug.cgi?id=150859
1101 Reviewed by Daniel Bates.
1103 For iOS run-webkit-tests, use LayoutTestRelay specified by --root; otherwise find
1104 LayoutTestRelay in the Mac build directory when --root is unspecified.
1106 * Scripts/webkitpy/port/ios.py:
1107 (IOSSimulatorPort.relay_path):
1109 2015-11-03 Alexey Proskuryakov <ap@apple.com>
1111 build.webkit.org/dashboard should use ISO dates in Trac URLs
1112 https://bugs.webkit.org/show_bug.cgi?id=150855
1114 Reviewed by Darin Adler.
1116 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1117 (Trac.prototype._xmlTimelineURL):
1119 2015-11-03 Said Abou-Hallawa <sabouhallawa@apple.com>
1121 Unreviewed, add myself to the SVG watchlist.
1123 * Scripts/webkitpy/common/config/watchlist:
1125 2015-11-03 Wenson Hsieh <wenson_hsieh@apple.com>
1127 Fix touch event sending crash in WebKitTestRunner
1128 https://bugs.webkit.org/show_bug.cgi?id=150848
1129 <rdar://problem/23360841>
1131 Reviewed by Simon Fraser.
1133 Fixes a redundant force event generated by HIDEventGenerator. See the Radar diagnosis for more details.
1135 * WebKitTestRunner/ios/HIDEventGenerator.mm:
1136 (-[HIDEventGenerator _createIOHIDEventType:]): Deleted.
1138 2015-11-03 Brent Fulgham <bfulgham@apple.com>
1140 [Win] Unreviewed build fix after r191958.
1142 * MiniBrowser/win/MiniBrowser.h: Add missing include.
1143 * MiniBrowser/win/MiniBrowserWebHost.h: Ditto.
1145 2015-11-02 Jiewen Tan <jiewen_tan@apple.com>
1147 Add Jiewen Tan (jiewen_tan@apple.com) to committer list.
1149 * Scripts/webkitpy/common/config/contributors.json:
1151 2015-11-03 Csaba Osztrogonác <ossy@webkit.org>
1153 Unreviewed, add unittest after r191827.
1155 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1157 2015-11-02 Andy Estes <aestes@apple.com>
1159 [Cocoa] Add tvOS and watchOS to SUPPORTED_PLATFORMS
1160 https://bugs.webkit.org/show_bug.cgi?id=150819
1162 Reviewed by Dan Bernstein.
1164 This tells Xcode to include these platforms in its Devices dropdown, making it possible to build in the IDE.
1166 * DumpRenderTree/mac/Configurations/Base.xcconfig:
1167 * MiniBrowser/Configurations/Base.xcconfig:
1168 * TestWebKitAPI/Configurations/Base.xcconfig:
1169 * WebKitTestRunner/Configurations/Base.xcconfig:
1171 2015-11-02 Anders Carlsson <andersca@apple.com>
1173 Begin work on supporting reply blocks in _WKRemoteObjectRegistry
1174 https://bugs.webkit.org/show_bug.cgi?id=150739
1176 Reviewed by Tim Horton.
1178 Add a test. We only test the encoding right now.
1180 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1181 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1183 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1184 (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
1186 2015-11-02 Tim Horton <timothy_horton@apple.com>
1188 Get rid of WKWebView's inner WKView (WKView being inside WKWebView leads to weird API issues)
1189 https://bugs.webkit.org/show_bug.cgi?id=150174
1191 Reviewed by Anders Carlsson.
1193 * WebKitTestRunner/mac/EventSenderProxy.mm:
1194 (WTR::EventSenderProxy::mouseUp):
1195 (WTR::EventSenderProxy::mouseMoveTo):
1196 Revert some parts of r188828 which no longer apply.
1198 2015-10-30 Dana Burkart <dburkart@apple.com>
1200 svn-apply should handle unified diffs
1201 https://bugs.webkit.org/show_bug.cgi?id=150650
1203 Reviewed by Darin Adler.
1205 * Scripts/VCSUtils.pm:
1206 (parseUnifiedDiffHeader):
1207 This method parses a unified diff header, and returns a information in the
1208 style of parseGitDiffHeader and parseSvnDiffHeader.
1211 Teach parseDiffHeader to recognize unified diff headers.
1214 Teach parseDiff to recognize unified diffs.
1216 * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1217 * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl: Added.
1219 2015-11-02 Csaba Osztrogonác <ossy@webkit.org>
1221 Fix the FTL JIT build with system LLVM on Linux
1222 https://bugs.webkit.org/show_bug.cgi?id=150795
1224 Reviewed by Filip Pizlo.
1226 * efl/install-dependencies:
1227 * gtk/install-dependencies:
1229 2015-11-02 Csaba Osztrogonác <ossy@webkit.org>
1231 [EFL] Bump harfbuzz versions to 0.9.35
1232 https://bugs.webkit.org/show_bug.cgi?id=150448
1234 Reviewed by Gyuyoung Kim.
1236 * efl/jhbuild.modules:
1238 2015-11-02 Csaba Osztrogonác <ossy@webkit.org>
1240 [EFL] gnutls-3.3.0 jhbuild module build fails on Ubuntu 15.10
1241 https://bugs.webkit.org/show_bug.cgi?id=150622
1243 Reviewed by Gyuyoung Kim.
1245 * efl/install-dependencies:
1246 * efl/jhbuild.modules:
1248 2015-11-02 Csaba Osztrogonác <ossy@webkit.org>
1250 Fix EFL jhbuild module build on Ubuntu 15.10
1251 https://bugs.webkit.org/show_bug.cgi?id=150621
1253 Reviewed by Gyuyoung Kim.
1255 * efl/jhbuild.modules:
1256 * efl/patches/efl-remove-XPrint.patch: Added.
1258 2015-11-02 Carlos Garcia Campos <cgarcia@igalia.com>
1260 [GLIB] Remove delete on destroy GMainLoopSources
1261 https://bugs.webkit.org/show_bug.cgi?id=150771
1263 Reviewed by Žan Doberšek.
1265 * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:
1266 (TestWebKitAPI::TEST): Remove DeleteOnDestroy unit tests.
1267 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1268 (WebViewTest::wait): Use g_timeout_add instead of GMainLoopSource.
1270 2015-11-01 Yusuke Suzuki <utatane.tea@gmail.com>
1272 [ES6] Support Generator Syntax
1273 https://bugs.webkit.org/show_bug.cgi?id=150769
1275 Reviewed by Geoffrey Garen.
1277 Added ENABLE_ES6_GENERATORS flag.
1279 * Scripts/webkitperl/FeatureList.pm:
1281 2015-11-01 Alexey Proskuryakov <ap@apple.com>
1283 Sort EWS bots in popovers
1284 https://bugs.webkit.org/show_bug.cgi?id=150782
1286 Reviewed by Darin Adler.
1288 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
1289 (BubbleQueueView.prototype._popoverContentForBubbleQueue):
1291 2015-10-31 Filip Pizlo <fpizlo@apple.com>
1293 B3::reduceStrength's DCE should be more agro and less wrong
1294 https://bugs.webkit.org/show_bug.cgi?id=150748
1296 Reviewed by Geoffrey Garen.
1298 Add an LLVM version of testb3's "testComplex".
1300 * ReducedFTL/ComplexTest.cpp: Added.
1302 2015-11-01 Commit Queue <commit-queue@webkit.org>
1304 Unreviewed, rolling out r191831.
1305 https://bugs.webkit.org/show_bug.cgi?id=150774
1307 The new test fails (Requested by ap on #webkit).
1311 "Begin work on supporting reply blocks in
1312 _WKRemoteObjectRegistry"
1313 https://bugs.webkit.org/show_bug.cgi?id=150739
1314 http://trac.webkit.org/changeset/191831
1316 2015-10-31 Andreas Kling <akling@apple.com>
1318 Add a debug overlay with information about web process resource usage.
1319 <https://webkit.org/b/150599>
1321 Reviewed by Darin Adler.
1323 Add a menu item to the MiniBrowser so we can toggle the resource usage overlay on/off.
1325 * MiniBrowser/mac/SettingsController.h:
1326 * MiniBrowser/mac/SettingsController.m:
1327 (-[SettingsController _populateMenu]):
1328 (-[SettingsController validateMenuItem:]):
1329 (-[SettingsController toggleShowResourceUsageOverlay:]):
1330 (-[SettingsController resourceUsageOverlayVisible]):
1331 * MiniBrowser/mac/WK2BrowserWindowController.m:
1332 (-[WK2BrowserWindowController didChangeSettings]):
1334 2015-10-31 Lucas Forschler <lforschler@apple.com>
1336 Teach the CompileWebKit step to look for additional arguments.
1338 Unreviewed config change.
1340 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1341 (CompileWebKit.start):
1343 2015-10-30 Anders Carlsson <andersca@apple.com>
1345 Begin work on supporting reply blocks in _WKRemoteObjectRegistry
1346 https://bugs.webkit.org/show_bug.cgi?id=150739
1348 Reviewed by Tim Horton.
1350 Add a test. We only test the encoding right now.
1352 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1353 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1355 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1356 (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
1358 2015-10-30 Lucas Forschler <lforschler@apple.com>
1360 Add CMAke builder to build.webkit.org
1361 https://bugs.webkit.org/show_bug.cgi?id=150738
1363 Reviewed by Alex Christensen.
1365 * BuildSlaveSupport/build.webkit.org-config/config.json:
1367 2015-10-30 Brent Fulgham <bfulgham@apple.com>
1369 [Win] build-jsc and run-javascriptcore-tests do not work
1370 https://bugs.webkit.org/show_bug.cgi?id=150700
1372 Reviewed by Mark Lam.
1374 Correct our build system so that it expects Windows to be using CMake,
1375 and to build the correct sub-projects for our JSC helper scripts.
1377 * Scripts/build-jsc: Make sure to build the testapi harness when
1378 building for Windows.
1379 * Scripts/build-webkit:
1380 (1) Use the existing 'cmakeBasedPortName()'
1381 (2) Use File::Spec rather than hard-coding path delimeters.
1382 (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
1383 method rather than hard-coding the name based on conditional.
1384 * Scripts/copy-webkitlibraries-to-product-directory: Don't try to grab
1385 LLVM libraries on Apple Windows build.
1386 * Scripts/run-javascriptcore-tests:
1387 (testapiPath): Use File::Spec rather than hard-coding path delimeters.
1388 * Scripts/run-jsc: Ditto.
1389 * Scripts/webkitdirs.pm:
1390 (cmakeBasedPortName): Update to return the right value for the Apple
1391 Windows port and the WinCairo port.
1392 (isCMakeBuild): Expect CMake build for all Windows ports.
1394 2015-10-30 Carlos Garcia Campos <cgarcia@igalia.com>
1396 [JHBuild] Do not try to update the dependencies if jhbuild configuration hasn't changed
1397 https://bugs.webkit.org/show_bug.cgi?id=150665
1399 Reviewed by Csaba Osztrogonác.
1401 We check it only to wipe the directory or not, but we are still
1402 tryihng to update every module even when the configuration hasn't
1403 changed. This is problematic because it makes the whole build fail
1404 when any repository fails to checkout an already checked out
1405 revision, because the server is down for example. This is even
1406 more problematic for the bots that skip perfectly valid revisions.
1407 It's still possible to force an update passing --force command
1410 * Scripts/update-webkit-libs-jhbuild:
1411 (deleteJhbuildMd5): Delete the md5sum files if exist.
1412 (runJhbuild): Return early if the md5sum files haven't
1413 changed. Only write them after a successful build and delete them
1414 if the build fails to ensure we don't skip next run.
1416 2015-10-30 Philippe Normand <pnormand@igalia.com>
1418 [GTK] Fix MacCLang build errors in Tools
1419 https://bugs.webkit.org/show_bug.cgi?id=150031
1421 Reviewed by Carlos Garcia Campos.
1423 * TestWebKitAPI/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
1424 * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
1425 * WebKitTestRunner/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
1426 * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
1428 2015-10-29 Hunseop Jeong <hs85.jeong@samsung.com>
1430 [EFL] MiniBrowser didn't work after r191749.
1431 https://bugs.webkit.org/show_bug.cgi?id=150706
1433 Reviewed by Alex Christensen.
1435 Renamed jhbuildWrapperPrefixIfNeeded to wrapperPrefixIfNeeded in r191749.
1437 * Scripts/run-minibrowser:
1439 2015-10-29 Commit Queue <commit-queue@webkit.org>
1441 Unreviewed, rolling out r191766.
1442 https://bugs.webkit.org/show_bug.cgi?id=150707
1444 Problem with Cygwin build (Requested by bfulgham_ on #webkit).
1448 "[Win] build-jsc and run-javascriptcore-tests do not work"
1449 https://bugs.webkit.org/show_bug.cgi?id=150700
1450 http://trac.webkit.org/changeset/191766
1452 2015-10-29 Brent Fulgham <bfulgham@apple.com>
1454 [Win] build-jsc and run-javascriptcore-tests do not work
1455 https://bugs.webkit.org/show_bug.cgi?id=150700
1457 Reviewed by Mark Lam.
1459 Correct our build system so that it expects Windows to be using CMake,
1460 and to build the correct sub-projects for our JSC helper scripts.
1462 * Scripts/build-jsc: Make sure to build the testapi harness when
1463 building for Windows.
1464 * Scripts/build-webkit:
1465 (1) Use the existing 'cmakeBasedPortName()'
1466 (2) Use File::Spec rather than hard-coding path delimeters.
1467 (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
1468 method rather than hard-coding the name based on conditional.
1469 * Scripts/run-javascriptcore-tests:
1470 (testapiPath): Use File::Spec rather than hard-coding path delimeters.
1471 * Scripts/run-jsc: Ditto.
1472 * Scripts/webkitdirs.pm:
1473 (cmakeBasedPortName): Update to return the right value for the Apple
1474 Windows port and the WinCairo port.
1475 (isCMakeBuild): Expect CMake build for all Windows ports.
1477 2015-10-29 Alex Christensen <achristensen@webkit.org>
1479 Fix build-jsc on Mac after r191749.
1481 * Scripts/build-jsc:
1482 Use isCMakeBuild to determine if we are building with CMake instead of cmakeBasedPortName.
1484 2015-10-29 Alex Christensen <achristensen@webkit.org>
1487 https://bugs.webkit.org/show_bug.cgi?id=150686
1489 Reviewed by Filip Pizlo.
1491 * Scripts/build-webkit:
1492 * Scripts/webkitdirs.pm:
1493 (isCachedArgumentfileOutOfDate):
1494 (wrapperPrefixIfNeeded):
1495 (generateBuildSystemFromCMakeProject):
1496 (buildCMakeGeneratedProject):
1497 (cmakeBasedPortName):
1498 (determineIsCMakeBuild):
1501 (jhbuildWrapperPrefixIfNeeded): Deleted.
1503 2015-10-29 Lucas Forschler <lforschler@apple.com>
1505 Teach JSC bots to build 32bit instead of x86_64
1507 Reviewed by Mark Lam.
1509 * BuildSlaveSupport/build.webkit.org-config/config.json:
1511 2015-10-29 Per Arne Vollan <peavo@outlook.com>
1513 [WinCairo] Fall back to AppleWin results in layout tests.
1514 https://bugs.webkit.org/show_bug.cgi?id=150672
1516 Reviewed by Alex Christensen.
1518 * Scripts/webkitpy/port/win.py:
1520 (WinCairoPort.default_baseline_search_path):
1522 2015-10-28 Keith Rollin <krollin@apple.com>
1524 Do not sanitize user input for input[type=url]
1525 https://bugs.webkit.org/show_bug.cgi?id=150346
1526 <rdar://problem/23243240>
1528 Reviewed by Brent Fulgham.
1530 The Windows version of DumpRenderTree's eventSender.keyDown handler
1531 simulates user-entry by decomposing the given character into a virtual
1532 key code and a set of modifier keys. The code that determines if the
1533 shift key should be simulated only worked if the character was an
1534 upper case character. Extend this support to also include symbols that
1535 (on the U.S. keyboard) require holding down the shift key.
1537 This change allows fast/forms/input-user-input-sanitization.html
1538 to succeed, which requires us to simulate the entering of '@' and ':'.
1540 * DumpRenderTree/win/EventSender.cpp:
1543 2015-10-28 Alex Christensen <achristensen@webkit.org>
1545 Compile and link with CMake on Mac
1546 https://bugs.webkit.org/show_bug.cgi?id=150632
1548 Reviewed by Tim Horton.
1550 * TestWebKitAPI/PlatformMac.cmake:
1552 2015-10-28 Xabier Rodriguez Calvar <calvaris@igalia.com>
1556 * Scripts/webkitpy/common/config/watchlist: Removed dead files from Streams API watchlist.
1558 2015-10-28 Per Arne Vollan <peavo@outlook.com>
1560 Add WinCairo to list of ports in run-webkit-tests.
1561 https://bugs.webkit.org/show_bug.cgi?id=150625
1563 Reviewed by Brent Fulgham.
1565 * Scripts/webkitpy/common/config/ports.py:
1566 (DeprecatedPort.port):
1567 (WinPort.run_webkit_tests_command):
1570 * Scripts/webkitpy/port/factory.py:
1572 * Scripts/webkitpy/port/win.py:
1573 (WinPort.find_system_pid):
1576 2015-10-27 Alexey Proskuryakov <ap@apple.com>
1578 WebKitTestRunner leaks in generateWhitelist()
1579 https://bugs.webkit.org/show_bug.cgi?id=150563
1581 Reviewed by Andreas Kling.
1583 * WebKitTestRunner/mac/TestControllerMac.mm:
1584 (WTR::generateWhitelist):
1586 2015-10-27 Anders Carlsson <andersca@apple.com>
1588 Add an API test for _WKRemoteObjectRegistry
1589 https://bugs.webkit.org/show_bug.cgi?id=150597
1591 Reviewed by Andreas Kling.
1593 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1594 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Added.
1595 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Added.
1597 * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Added.
1598 (-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1599 (-[RemoteObjectRegistryPlugIn sayHello:]):
1601 2015-10-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
1603 Add myself to the reviewers list
1604 https://bugs.webkit.org/show_bug.cgi?id=150581
1608 * Scripts/webkitpy/common/config/contributors.json:
1610 2015-10-26 Ryan Haddad <ryanhaddad@apple.com>
1612 Adding myself to contributors.json
1614 * Scripts/webkitpy/common/config/contributors.json:
1616 2015-10-26 Tim Horton <timothy_horton@apple.com>
1618 Don't expose the whitelist/blacklist in _WKUserStyleSheet
1619 https://bugs.webkit.org/show_bug.cgi?id=150566
1621 Reviewed by Anders Carlsson.
1623 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1626 2015-10-26 Philippe Normand <pnormand@igalia.com>
1628 Unreviewed, rolling out r191576.
1634 "[GStreamer] Bump internal jhbuild versions to 1.6.0"
1635 https://bugs.webkit.org/show_bug.cgi?id=149594
1636 http://trac.webkit.org/changeset/191576
1638 2015-10-26 ChangSeok Oh <changseok.oh@collabora.com>
1640 [GStreamer] Bump internal jhbuild versions to 1.6.0
1641 https://bugs.webkit.org/show_bug.cgi?id=149594
1643 Reviewed by Philippe Normand.
1645 Bump up whole gstreamer libraries to 1.6.0. Relevant patches are no more
1646 useful so they are removed accordingly.
1648 * gtk/jhbuild.modules:
1649 * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
1650 * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
1651 * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
1653 2015-10-25 Alexey Proskuryakov <ap@apple.com>
1655 API tests fail on El Capitan after r191543
1656 https://bugs.webkit.org/show_bug.cgi?id=150547
1658 Reviewed by Dan Bernstein.
1660 * Scripts/run-api-tests: (listAllTests): Add appropriate arch arguments in one more place.
1662 2015-10-24 Tim Horton <timothy_horton@apple.com>
1664 Add a way to add user style sheets to WKUserContentController
1665 https://bugs.webkit.org/show_bug.cgi?id=150531
1666 <rdar://problem/23191691>
1668 Reviewed by Darin Adler.
1670 * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1673 2015-10-24 Tim Horton <timothy_horton@apple.com>
1675 Expose more information about the exception in WKErrorJavaScriptExceptionOccurred errors
1676 https://bugs.webkit.org/show_bug.cgi?id=150525
1678 Reviewed by Darin Adler.
1680 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
1682 Test the various new keys.
1684 2015-10-24 Frederic Wang <fred.wang@free.fr>
1686 check-webkit-style complains about missing operator whitespace inside character literal
1687 https://bugs.webkit.org/show_bug.cgi?id=150396
1689 Reviewed by Darin Adler.
1691 * Scripts/webkitpy/style/checkers/cpp.py: Improve matching of C++ character literal.
1692 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1693 (WebKitStyleTest.test_spacing): Add a test to verify that the spacing for the character literal 'OS/2' is not tested.
1695 2015-10-23 Michael Saboff <msaboff@apple.com>
1697 REGRESSION (r179357-r179359): WebContent Crash using AOL Mail @ com.apple.JavascriptCore JSC::linkPolymorphicCall(JSC::ExecState*, JSC::CallLinkInfo&, JSC::CallVariant, JSC::RegisterPreservationMode) + 1584
1698 https://bugs.webkit.org/show_bug.cgi?id=150513
1700 Reviewed by Saam Barati.
1702 Added a new test function, failNextNewCodeBlock() to simplify the writing of a regression test.
1704 * DumpRenderTree/TestRunner.cpp:
1705 (simulateWebNotificationClickCallback):
1706 (failNextCodeBlock):
1707 (numberOfDFGCompiles):
1708 (TestRunner::staticFunctions):
1709 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1710 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1711 (WTR::TestRunner::setBlockAllPlugins):
1712 (WTR::TestRunner::failNextCodeBlock):
1713 (WTR::TestRunner::numberOfDFGCompiles):
1714 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1716 2015-10-23 Anders Carlsson <andersca@apple.com>
1718 Simplify the WebKitLegacy menu conversion code
1719 https://bugs.webkit.org/show_bug.cgi?id=150509
1721 Reviewed by Andreas Kling.
1723 Implement the context menu delegate method so we'll test that code path.
1725 * MiniBrowser/mac/WK1BrowserWindowController.m:
1726 (-[WK1BrowserWindowController webView:contextMenuItemsForElement:defaultMenuItems:]):
1728 2015-10-23 Per Arne Vollan <peavo@outlook.com>
1730 [WinCairo] Improve test results for fast layouttests.
1731 https://bugs.webkit.org/show_bug.cgi?id=150464
1733 Reviewed by Alex Christensen.
1735 Set custom device scale factor to 1.0.
1737 * DumpRenderTree/win/DumpRenderTree.cpp:
1738 (createWebViewAndOffscreenWindow):
1740 2015-10-23 Mark Salisbury <mark.salisbury@hp.com>
1742 [GTK] update-webkitgtk-libs should use mesa tarball
1744 https://bugs.webkit.org/show_bug.cgi?id=150470
1746 update-webkitgtk-libs downloads all build dependencies; in fixing
1747 bug 148941 mesa was switched from ftp to git access. Now an http
1748 tarball is available, which is preferred over accessing via git.
1750 Reviewed by Philippe Normand
1752 * gtk/jhbuild.modules:
1753 Mesa access changed to http tarball.
1755 2015-10-22 Sam Weinig <sam@webkit.org>
1757 Navigations on the same host (but with different schemes and ports) should not trigger universal links
1758 <rdar://problem/22811325>
1759 https://bugs.webkit.org/show_bug.cgi?id=150481
1761 Reviewed by Dan Bernstein.
1763 * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1764 Update test to test that navigations on the same host but with different schemes does not
1765 trigger universal links, but that changes in the host do.
1767 2015-10-22 Ryosuke Niwa <rniwa@webkit.org>
1769 REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
1770 https://bugs.webkit.org/show_bug.cgi?id=150428
1772 Reviewed by Antti Koivisto.
1774 Added a regression test using WebKit API test.
1776 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1777 * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
1778 (TestWebKitAPI::didFinishLoadForFrame):
1779 (TestWebKitAPI::TEST):
1781 2015-10-22 Carlos Garcia Campos <cgarcia@igalia.com>
1783 Unreviewed. Fix GTK+ build after r191423.
1785 Add WebKitDOMHTMLBaseFontElement to the list of deleted classes.
1788 (WebKitDOMDocGenerator):
1790 2015-10-22 Aakash Jain <aakash_jain@apple.com>
1792 [Win][EFL][GTK] webkitpy test failed after r191374.
1793 https://bugs.webkit.org/show_bug.cgi?id=150433
1795 Reviewed by Alexey Proskuryakov.
1797 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1798 (CrashLogsTest.test_find_all_log_darwin): Check platform before running test.
1799 (CrashLogsTest.test_find_log_darwin): Same.
1801 2015-10-21 Brian Burg <bburg@apple.com>
1803 Unreviewed, update watchlist for JS builtins.
1805 Add a category for JS builtins code generator, similar to other generators.
1807 Add a nag message to rebaseline builtins generator tests when touching
1808 code generator files in Source/JavaScriptCore/Scripts/builtins/.
1810 * Scripts/webkitpy/common/config/watchlist:
1812 2015-10-21 Brian Burg <bburg@apple.com>
1814 Restructure generate-js-bindings script to be modular and testable
1815 https://bugs.webkit.org/show_bug.cgi?id=149929
1817 Reviewed by Alex Christensen.
1819 Add a stub shell script and basic webkitpy support for running builtins
1822 * Scripts/run-builtins-generator-tests: Added.
1824 * Scripts/webkitpy/codegen/__init__.py: Added.
1825 * Scripts/webkitpy/codegen/main.py: Added.
1827 The only interesting difference here from the inspector protocol
1828 generator equivalent is that this implementation decodes the target
1829 framework and output mode (combined or separate) from the test's file name.
1831 (BuiltinsGeneratorTests):
1832 (BuiltinsGeneratorTests.__init__):
1833 (BuiltinsGeneratorTests.generate_from_js_builtins):
1834 (BuiltinsGeneratorTests.write_error_file):
1835 (BuiltinsGeneratorTests.detect_changes):
1836 (BuiltinsGeneratorTests.run_tests):
1837 (BuiltinsGeneratorTests.main):
1839 2015-10-21 Aakash Jain <aakash_jain@apple.com>
1841 run-webkit-tests does not copy all crash logs for layout test failures on Mac
1842 https://bugs.webkit.org/show_bug.cgi?id=150407
1843 <rdar://problem/22239750>
1845 Reviewed by Alexey Proskuryakov.
1847 * Scripts/webkitpy/port/mac.py:
1848 (MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
1849 (MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
1851 (MacPort.look_for_new_crash_logs): Uses above method to get crash logs
1852 from log directory and merge them with the list of already crashed tests.
1854 2015-10-21 Filip Pizlo <fpizlo@apple.com>
1856 Failures in PutStackSinkingPhase should be less severe
1857 https://bugs.webkit.org/show_bug.cgi?id=150400
1859 Reviewed by Geoffrey Garen.
1861 Add a test mode for no PutStackSinkingPhase.
1863 * Scripts/run-jsc-stress-tests:
1865 2015-10-21 Nan Wang <n_wang@apple.com>
1867 AX: Expose table size and cell indexes on iOS
1868 https://bugs.webkit.org/show_bug.cgi?id=150366
1870 Reviewed by Chris Fleizach.
1872 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1873 (AccessibilityUIElement::rowCount):
1874 (AccessibilityUIElement::columnCount):
1875 (AccessibilityUIElement::indexInTable):
1876 (AccessibilityUIElement::numberAttributeValue):
1877 * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1878 (WTR::AccessibilityUIElement::numberAttributeValue):
1879 (WTR::AccessibilityUIElement::rowCount):
1880 (WTR::AccessibilityUIElement::columnCount):
1881 (WTR::AccessibilityUIElement::indexInTable):
1883 2015-10-21 Youenn Fablet <youenn.fablet@crf.canon.fr>
1885 W3C test importer should not import reference files as regular tests
1886 https://bugs.webkit.org/show_bug.cgi?id=150331
1888 Reviewed by Darin Adler.
1890 Updated test_parser to return information that a file can be a referencefile or a manual test.
1891 Updated test importer to skip those files.
1892 Updated/Added test parser unit tests accordingly.
1894 Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
1895 Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
1896 to mark these files as Skip, since they are not direct tests.
1898 * Scripts/webkitpy/w3c/test_importer.py:
1899 (TestImporter.__init__):
1900 (TestImporter.find_importable_tests):
1901 (TestImporter.import_tests):
1902 * Scripts/webkitpy/w3c/test_parser.py:
1903 (TestParser.analyze_test):
1904 * Scripts/webkitpy/w3c/test_parser_unittest.py:
1905 (test_analyze_non_html_file):
1906 (test_reference_test):
1908 2015-10-20 Aakash Jain <aakash_jain@apple.com>
1910 run-webkit-tests does not copy all crash logs for layout test failures on iOS
1911 https://bugs.webkit.org/show_bug.cgi?id=150056
1912 <rdar://problem/9280656>
1914 Reviewed by Alexey Proskuryakov.
1916 * Scripts/webkitpy/common/system/crashlogs.py:
1917 (CrashLogs.find_all_logs): Generic method to find all crash logs.
1918 (CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
1919 It iterates through log directory and returns all the logs based on timestamp.
1920 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1921 (CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
1922 (CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
1923 (CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
1924 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1925 (Manager.run): Modified start_time to start counting before simulator launch
1926 so that we can capture crashes during simualator launch.
1927 (Manager._look_for_new_crash_logs): Browse through list of crashes and append
1928 any test which is not already marked as CRASH to the run_results.
1929 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1930 (TestExpectationsModel.get_expectations_string): return PASS in case there
1931 are no expectations defined for this test.
1932 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1933 (summarize_results): Add other_crashes in a separte category in full_results.json.
1934 * Scripts/webkitpy/port/ios.py:
1935 (IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
1936 (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
1937 from the log directory.
1938 (IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
1939 logs from log directory and merge them with the list of already crashed tests.
1941 2015-10-20 Dana Burkart <dburkart@apple.com>
1947 My previous patch was missing a necessary space character.
1949 * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
1951 2015-10-20 Dana Burkart <dburkart@apple.com>
1953 svn-apply fails to apply binary diffs in some cases
1954 https://bugs.webkit.org/show_bug.cgi?id=64647
1956 Reviewed by Daniel Bates.
1958 * Scripts/VCSUtils.pm:
1959 (decodeGitBinaryPatchDeltaSize): Modified.
1960 We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
1961 * Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
1963 2015-10-20 Alexey Proskuryakov <ap@apple.com>
1965 Mac Debug EWS never finishes when there are failures
1966 https://bugs.webkit.org/show_bug.cgi?id=150334
1968 Reviewed by Daniel Bates.
1970 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1971 * Scripts/webkitpy/tool/commands/queues.py:
1973 2015-10-20 Philippe Normand <pnormand@igalia.com>
1975 [GTK] Enable OpenWebRTC test video/audio sources in tests
1977 This is needed because we can't expect the buildbots to have
1978 webcam/mic devices plugged in.
1980 Rubber-stamped by Carlos Garcia Campos.
1982 * Scripts/run-gtk-tests:
1983 (TestRunner._setup_testing_environment):
1984 * Scripts/webkitpy/port/gtk.py:
1985 (GtkPort.setup_environ_for_server):
1987 2015-10-20 Yoav Weiss <yoav@yoav.ws>
1989 Rename the PICTURE_SIZES flag to CURRENTSRC
1990 https://bugs.webkit.org/show_bug.cgi?id=150275
1992 Reviewed by Dean Jackson.
1994 * Scripts/webkitperl/FeatureList.pm:
1996 2015-10-19 Hunseop Jeong <hs85.jeong@samsung.com>
1998 Unreviewed, add myself to the committers list.
2000 * Scripts/webkitpy/common/config/contributors.json:
2002 2015-10-19 Alexey Proskuryakov <ap@apple.com>
2004 Add new EWS queues to bot watcher's dashboard
2005 https://bugs.webkit.org/show_bug.cgi?id=150297
2007 Reviewed by Darin Adler.
2009 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2010 (BubbleQueueServer):
2012 2015-10-19 ChangSeok Oh <changseok.oh@collabora.com>
2014 REGRESSION(r190262): User media unit test failures after r190262
2015 https://bugs.webkit.org/show_bug.cgi?id=149580
2017 Reviewed by Carlos Garcia Campos.
2019 The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
2020 So we do not need to skip them anymore.
2022 * Scripts/run-gtk-tests:
2023 (TestRunner): Deleted.
2025 2015-10-19 Csaba Osztrogonác <ossy@webkit.org>
2027 Add historical addresses to contributors.json
2028 https://bugs.webkit.org/show_bug.cgi?id=150227
2030 Reviewed by Darin Adler.
2032 * Scripts/webkitpy/common/config/contributors.json:
2034 2015-10-18 Sungmann Cho <sungmann.cho@navercorp.com>
2036 [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
2037 https://bugs.webkit.org/show_bug.cgi?id=150307
2039 Reviewed by Brent Fulgham.
2041 The DLL build rules have been changed to generate "{Name}Lib.DLL",
2042 but these changes have not yet been applied to the Visual Studio builds.
2044 * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
2046 2015-10-16 Andreas Kling <akling@apple.com>
2048 [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
2049 <https://webkit.org/b/150153>
2053 Just use simple arrays of LChar and UChar for this test instead of creating String
2054 objects and then getting the characters8()/characters16() from them, since that
2055 doesn't guarantee null-termination (the bug.)
2057 * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2058 (TestWebKitAPI::TEST):
2059 (TestWebKitAPI::build): Deleted.
2061 2015-10-16 Tim Horton <timothy_horton@apple.com>
2063 WebKit2.AutoLayoutIntegration API test is failing on some of the bots
2064 https://bugs.webkit.org/show_bug.cgi?id=150255
2066 Reviewed by Simon Fraser.
2068 * Scripts/run-api-tests:
2070 * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2071 (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
2072 (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
2073 (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
2074 (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
2075 Don't set the layout size until after the load finishes and we're waiting
2076 for the reply, so that there is no race between the new size coming in
2077 and us waiting for it.
2079 2015-10-16 Anders Carlsson <andersca@apple.com>
2081 WebEditingDelegate should be a formal protocol
2082 https://bugs.webkit.org/show_bug.cgi?id=150254
2083 <rdar://problem/23149847>
2085 Reviewed by Dan Bernstein.
2087 * DumpRenderTree/mac/EditingDelegate.h:
2088 Conform to the WebEditingDelegate protocol.
2090 2015-10-16 Tim Horton <timothy_horton@apple.com>
2092 Hook up autolayout intrinsic sizing for WKWebView
2093 https://bugs.webkit.org/show_bug.cgi?id=150219
2094 <rdar://problem/20016905>
2096 Reviewed by Simon Fraser.
2098 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2099 * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
2100 (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
2101 (-[AutoLayoutWKWebView load:expectingContentSize:]):
2102 (-[AutoLayoutWKWebView expectContentSizeChange:]):
2103 (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
2105 Add a variety of tests, including one which catches the bug that
2106 the WebCore part of this patch fixes.
2108 2015-10-15 Csaba Osztrogonác <ossy@webkit.org>
2110 Update the help message of --system-malloc
2111 https://bugs.webkit.org/show_bug.cgi?id=150169
2113 Reviewed by Geoffrey Garen.
2115 * Scripts/webkitperl/FeatureList.pm:
2117 2015-10-15 Youenn Fablet <youenn.fablet@crf.canon.fr>
2119 Update ImportExpectations according currently imported wpt tests
2120 https://bugs.webkit.org/show_bug.cgi?id=150158
2122 Reviewed by Chris Dumez.
2124 * Scripts/webkitpy/w3c/test_downloader.py:
2125 (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
2127 2015-10-15 Eunmi Lee <eunmi15.lee@samsung.com>
2129 Unreviewed, Update my email address.
2131 * Scripts/webkitpy/common/config/contributors.json:
2133 2015-10-15 Carlos Garcia Campos <cgarcia@igalia.com>
2135 [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
2136 https://bugs.webkit.org/show_bug.cgi?id=84960
2138 Reviewed by Žan Doberšek.
2140 * Scripts/run-gtk-tests:
2141 (TestRunner): Unskip tests using SessionState.
2142 * TestWebKitAPI/PlatformGTK.cmake: Add
2143 WKPageCopySessionStateWithFiltering test.
2145 2015-10-14 Carlos Garcia Campos <cgarcia@igalia.com>
2147 [GTK] Missing return value on TestWebExtensions.cpp:193
2148 https://bugs.webkit.org/show_bug.cgi?id=149755
2150 Unreviewed. Add missing return value.
2152 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2153 (permissionRequestCallback):
2155 2015-10-14 Andy Estes <aestes@apple.com>
2157 [iOS] build-dumprendertree does not build ImageDiff
2158 https://bugs.webkit.org/show_bug.cgi?id=150152
2160 Reviewed by Tim Horton.
2162 run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
2163 On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
2164 as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
2165 WebKit.xcworkspace), tests that rely on image diffing won't work properly.
2167 There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
2168 fine on that platform, and results in ImageDiff being built.
2170 * Scripts/build-dumprendertree:
2172 2015-10-14 Brent Fulgham <bfulgham@apple.com>
2174 [Win] Enforce launcher/library naming scheme
2175 https://bugs.webkit.org/show_bug.cgi?id=150124
2177 Reviewed by Alex Christensen.
2179 * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
2180 * MiniBrowser/win/CMakeLists.txt: Ditto.
2181 * TestWebKitAPI/PlatformWin.cmake: Ditto.
2182 * win/DLLLauncher/DLLLauncherMain.cpp:
2183 (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
2184 original {name}.dll.
2186 2015-10-14 Andreas Kling <akling@apple.com>
2188 REGRESSION(r190882): Concatenating a character array and an empty string is broken.
2189 <https://webkit.org/b/150135>
2191 Reviewed by Geoffrey Garen.
2193 Add a new WTF API test that covers this issue.
2195 * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2196 (TestWebKitAPI::build):
2197 (TestWebKitAPI::TEST):
2199 2015-10-14 Alex Christensen <achristensen@webkit.org>
2201 Add SPI for reloading without content blockers
2202 https://bugs.webkit.org/show_bug.cgi?id=150058
2203 rdar://problem/22742222
2205 Reviewed by Sam Weinig.
2207 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2208 (WTR::TestController::cocoaResetStateToConsistentValues):
2209 * WebKitTestRunner/mac/TestControllerMac.mm:
2210 (WTR::TestController::platformConfigureViewForTest):
2212 2015-10-14 Mark Lam <mark.lam@apple.com>
2214 Rename some JSC option names to be more uniform.
2215 https://bugs.webkit.org/show_bug.cgi?id=150127
2217 Reviewed by Geoffrey Garen.
2219 * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
2220 * Scripts/run-jsc-stress-tests:
2222 2015-10-14 Anders Carlsson <andersca@apple.com>
2224 Change the bundle app cache APIs to take a page
2225 https://bugs.webkit.org/show_bug.cgi?id=150123
2227 Reviewed by Sam Weinig.
2231 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2232 (WTR::InjectedBundle::beginTesting):
2233 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2234 (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2235 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2236 (WTR::TestRunner::clearAllApplicationCaches):
2237 (WTR::TestRunner::clearApplicationCacheForOrigin):
2238 (WTR::TestRunner::setAppCacheMaximumSize):
2239 (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
2240 (WTR::TestRunner::originsWithApplicationCache):
2242 2015-10-14 Youenn Fablet <youenn.fablet@crf.canon.fr>
2244 Update web-platform-tests tools to the latest revision
2245 https://bugs.webkit.org/show_bug.cgi?id=149645
2247 Reviewed by Darin Adler.
2249 Disabling git submodules information conversion to json install file for web-platform-tests.
2250 Disabling related python unit tests.
2251 The tools submodules contain submodules and the conversion tool does not support that yet.
2253 Updating wpt launcher script to aling it with web-platform-test main script.
2255 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2257 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2258 (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
2259 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2260 (TestImporterTest.test_submodules_generation):
2262 2015-10-13 Alexey Proskuryakov <ap@apple.com>
2264 More debug queue build fixing.
2266 Preserve the build style in one more place. Changed mock build_style from "both"
2267 to "release", as we don't support testing both debug and release.
2269 * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2270 (MockCommitQueue.archive_last_test_results):
2272 (MockCommitQueue.build_style):
2273 (MockCommitQueue.did_pass_testing_ews):
2274 * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2275 (PatchAnalysisTask._test):
2276 (PatchAnalysisTask._build_and_test_without_patch):
2277 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2278 (EarlyWarningSystemTest._default_expected_logs):
2279 * Scripts/webkitpy/tool/commands/queues_unittest.py:
2281 2015-10-13 Alexey Proskuryakov <ap@apple.com>
2283 More debug queue build fixing.
2285 Add build_style argument to derived classes as well.
2287 * Scripts/webkitpy/common/config/ports.py:
2289 (MacPort.run_webkit_tests_command):
2290 (WinPort.run_bindings_tests_command):
2292 (WinPort.run_webkit_tests_command):
2293 (GtkWK2Port.build_webkit_command):
2295 (GtkWK2Port.run_webkit_tests_command):
2297 2015-10-13 Myles C. Maxfield <mmaxfield@apple.com>
2303 Mach-O section names are limited to 16 characters.
2305 * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2306 * DumpRenderTree/mac/DumpRenderTree.mm:
2309 2015-10-13 Alexey Proskuryakov <ap@apple.com>
2311 Build fix for mac-debug EWS queue.
2315 Pass --debug to run-webkit-tests.
2317 While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
2318 will need to be substantially modified to work in EWS, so the dummy implementation
2321 * Scripts/webkitpy/common/config/ports.py:
2322 (DeprecatedPort.run_javascriptcore_tests_command):
2324 (DeprecatedPort.run_webkit_tests_command):
2325 (DeprecatedPort.run_python_unittests_command):
2326 (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
2327 * Scripts/webkitpy/common/config/ports_mock.py:
2328 (MockPort.run_javascriptcore_tests_command):
2330 (MockPort.run_webkit_tests_command):
2331 (MockPort.run_bindings_tests_command):
2332 (MockPort.run_webkit_unit_tests_command): Deleted.
2333 * Scripts/webkitpy/tool/commands/download_unittest.py:
2334 * Scripts/webkitpy/tool/steps/runtests.py:
2336 * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2337 (RunTestsTest.test_webkit_run_unit_tests):
2338 * Scripts/webkitpy/tool/steps/steps_unittest.py:
2339 (StepsTest.test_runtests_args):
2341 2015-10-13 Brent Fulgham <bfulgham@apple.com>
2343 [Win] Generate Crash Traces
2344 https://bugs.webkit.org/show_bug.cgi?id=150103
2346 Reviewed by Daniel Bates.
2348 We were using an exception filter to try to emit "#CRASHED" to stderr
2349 when a test program crashed. However, the modern Python implementation
2350 seems capable of recognizing crashes on its own. Furthermore, registering
2351 the exception handler was preventing the JIT debugger (NTSD) from
2352 automatically attaching to the crashing program, so we were not getting
2355 * DumpRenderTree/win/DumpRenderTree.cpp:
2356 (main): Don't register an exception filter.
2357 (exceptionFilter): Deleted.
2358 * Scripts/webkitpy/common/system/crashlogs.py:
2359 (CrashLogs): Add another regular expression to handle a second crash trace
2360 syntax I encountered during testing.
2361 (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
2362 try the new one. The PID found by the new expression is in hexadecimal, so
2363 convert it to an integer before returning it.
2364 * Scripts/webkitpy/port/driver.py:
2365 (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
2366 the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
2367 check for "#CRASHED" after stripping off the EOL characters.
2368 * Scripts/webkitpy/port/win.py:
2369 (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
2370 invocation. This is apparently used to signal an event when the debugger is finished.
2372 2015-10-13 Alexey Proskuryakov <ap@apple.com>
2374 Mac Debug and 32-bit queues should be separate
2375 https://bugs.webkit.org/show_bug.cgi?id=150092
2377 Reviewed by Lucas Forschler.
2379 * QueueStatusServer/config/queues.py:
2380 * QueueStatusServer/model/queues.py:
2381 (Queue._capitalize_after_dash):
2382 (Queue._caplitalize_after_dash): Deleted.
2383 * Scripts/webkitpy/common/config/ews.json:
2385 2015-10-13 Sergio Villar Senin <svillar@igalia.com>
2387 [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
2388 https://bugs.webkit.org/show_bug.cgi?id=150085
2390 Reviewed by Carlos Garcia Campos.
2392 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2394 2015-10-13 Sebastian Dröge <sebastian@centricular.com>
2396 Unreviewed, add myself to the committers list.
2398 * Scripts/webkitpy/common/config/contributors.json:
2400 2015-10-12 Alexey Proskuryakov <ap@apple.com>
2402 Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
2403 https://bugs.webkit.org/show_bug.cgi?id=149983
2405 Reviewed by Dan Bates.
2407 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2408 (BubbleQueueServer):
2409 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2411 2015-10-12 Alexey Proskuryakov <ap@apple.com>
2413 Fix webkitpy tests after r190922.
2415 * Scripts/webkitpy/common/config/ews.json:
2416 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2417 * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2419 2015-10-12 Alexey Proskuryakov <ap@apple.com>
2421 Add a Mac debug EWS queue
2422 https://bugs.webkit.org/show_bug.cgi?id=150069
2424 Reviewed by Geoffrey Garen.
2426 * QueueStatusServer/config/queues.py:
2427 * Scripts/webkitpy/common/config/ews.json:
2428 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2429 (AbstractEarlyWarningSystem):
2430 (AbstractEarlyWarningSystem.archive_last_test_results):
2431 (AbstractEarlyWarningSystem.build_style):
2432 (AbstractEarlyWarningSystem.refetch_patch):
2433 (AbstractEarlyWarningSystem.load_ews_classes):
2435 2015-10-12 Mario Sanchez Prada <mario@endlessm.com>
2437 [GTK] Update jhbuild's version of harfbuzz
2438 https://bugs.webkit.org/show_bug.cgi?id=149749
2440 Reviewed by Martin Robinson.
2442 Update harfbuzz to 0.9.35, following the lead of Debian Stable.
2444 * gtk/jhbuild.modules: Updated details for harfbuzz.
2446 2015-10-12 Mario Sanchez Prada <mario@endlessm.com>
2448 [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
2449 https://bugs.webkit.org/show_bug.cgi?id=150026
2451 Reviewed by Philippe Normand.
2453 Backport upstream patch from gst-plugins-bad so that the right version
2454 of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
2455 gets compiled properly, avoiding crashes on runtime while running tests.
2457 * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
2458 * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
2460 2015-10-11 Myles C. Maxfield <mmaxfield@apple.com>
2462 Test font-variant-* and font-feature-settings with mocked preinstalled fonts
2463 https://bugs.webkit.org/show_bug.cgi?id=149777
2465 Reviewed by Simon Fraser.
2467 Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
2468 to the list of tests to preinstall at startup time.
2470 Also, update the generation of the 'name' table in the FontWithFeatures font.
2472 * DumpRenderTree/mac/DumpRenderTree.mm:
2473 (allowedFontFamilySet):
2474 (activateTestingFonts):
2476 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2477 (Generator::generate):
2478 (Generator::appendCFFTable):
2479 (Generator::appendNameSubtable):
2480 (Generator::appendNAMETable):
2481 * FontWithFeatures/FontWithFeatures/main.cpp:
2483 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2484 (WTR::allowedFontFamilySet):
2485 (WTR::activateFonts):
2486 * WebKitTestRunner/mac/TestControllerMac.mm:
2487 (WTR::allowedFontFamilySet):
2489 2015-10-11 Jinyoung Hur <hur.ims@navercorp.com>
2491 Unreviewed. Add Jinyoung Hur as a committer.
2493 * Scripts/webkitpy/common/config/contributors.json:
2495 2015-10-10 Dan Bernstein <mitz@apple.com>
2497 [iOS] Remove unnecessary iOS version checks
2498 https://bugs.webkit.org/show_bug.cgi?id=150002
2500 Reviewed by Alexey Proskuryakov.
2502 * WebKitTestRunner/ios/HIDEventGenerator.mm:
2503 (-[HIDEventGenerator _createIOHIDEventType:]):
2504 (-[HIDEventGenerator _sendHIDEvent:]):
2505 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
2506 * WebKitTestRunner/ios/UIKitSPI.h:
2508 2015-10-09 Myles C. Maxfield <mmaxfield@apple.com>
2510 Unreviewed, rolling out r190689
2511 https://bugs.webkit.org/show_bug.cgi?id=149992
2513 Fixed in other repository.
2515 Reverted changesets:
2517 "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
2518 https://bugs.webkit.org/show_bug.cgi?id=149897
2520 2015-10-09 Brian Burg <bburg@apple.com>
2522 Teach webkitperl how to figure out IOS versions from the SDK
2523 https://bugs.webkit.org/show_bug.cgi?id=149963
2525 Reviewed by Daniel Bates.
2527 It should be easier to check the major and minor version of IOS SDKs.
2529 * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
2530 * Scripts/webkitdirs.pm:
2531 (splitVersionString): Added.
2532 (determineOSXVersion): Use splitVersionString.
2533 (determineIOSVersion): Added. Look at the SDK version and make a tuple.
2534 (iosVersion): Added.
2536 2015-10-09 Simon Fraser <simon.fraser@apple.com>
2538 [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
2539 https://bugs.webkit.org/show_bug.cgi?id=149960
2541 Reviewed by Tim Horton.
2543 Use adoptWK(), and null out some members (file is not using ARC).
2545 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
2546 (UIScriptContext::uiScriptComplete):
2547 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2548 (-[TestRunnerWKWebView dealloc]):
2550 2015-10-09 Csaba Osztrogonác <ossy@webkit.org>
2552 Remove ENABLE_SUID_SANDBOX_LINUX cruft
2553 https://bugs.webkit.org/show_bug.cgi?id=149954
2555 Reviewed by Darin Adler.
2557 * Scripts/webkitperl/FeatureList.pm:
2559 2015-10-09 Daniel Bates <dabates@apple.com>
2561 Make iOS builders generate debug information in a separate dSYM file
2562 https://bugs.webkit.org/show_bug.cgi?id=149696
2564 Reviewed by Darin Adler.
2566 Similar to the Mac builders, the iOS builders should write debug information
2567 into a separate dSYM file instead of including such information in the binary
2568 itself (default Xcode behavior)
2570 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2571 (CompileWebKit.start):
2573 2015-10-09 Csaba Osztrogonác <ossy@webkit.org>
2575 Fix webkitpy tests after r190779
2576 https://bugs.webkit.org/show_bug.cgi?id=149949
2578 Reviewed by Ryosuke Niwa.
2580 * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
2581 (BenchmarkResults.format):
2582 (BenchmarkResults._format_values):
2584 2015-10-08 Dewei Zhu <dewei_zhu@apple.com>
2586 Extend run-benchmark script to support human-readable results conversion.
2587 https://bugs.webkit.org/show_bug.cgi?id=149944
2589 Reviewed by Ryosuke Niwa.
2591 Add '--read-results-json' and '--no-adjust-unit' options.
2592 '--read-results-json' option converts result file to human readable format.
2593 '--no-adjust-unit' option skips scientific notation convertion.
2594 '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
2596 * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
2597 (BenchmarkResults.format):
2598 (BenchmarkResults._format_tests):
2599 (BenchmarkResults._format_values):
2600 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2601 (BenchmarkRunner.__init__):
2602 (BenchmarkRunner._run_benchmark):
2603 (BenchmarkRunner._dump):
2604 (BenchmarkRunner.show_results):
2605 (BenchmarkRunner._show_results): Deleted.
2606 * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2610 2015-10-08 Daniel Bates <dabates@apple.com>
2612 Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
2613 https://bugs.webkit.org/show_bug.cgi?id=149945
2615 Reviewed by Dan Bernstein.
2617 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
2618 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
2619 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2620 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2622 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2623 (table.queue-grid tr.platform.ios-9 img.logo):
2625 2015-10-08 Daniel Bates <dabates@apple.com>
2627 Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
2628 https://bugs.webkit.org/show_bug.cgi?id=149943
2630 Reviewed by Dan Bernstein.
2632 Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
2633 teach build-webkit to install them when building for iOS device using the public iOS SDK.
2635 * Scripts/build-webkit:
2637 2015-10-08 Daniel Bates <dabates@apple.com>
2639 Add LLVM binaries for iOS 9 device
2640 https://bugs.webkit.org/show_bug.cgi?id=149913
2642 Reviewed by Filip Pizlo.
2644 Implement support for building LLVM for ARM64-based iOS devices.
2646 * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
2647 * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
2648 an existing build earlier in the file such that remove previously built
2649 libraries before building/copying new ones (if applicable).
2650 (fileContains): Moved function outside of if-block.
2651 (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
2652 (buildLLVM): Added. Extracted machinery to build LLVM into this function and
2653 added logic to build LLVM for ARM64-based iOS devices.
2654 (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
2655 LLVM into the WebKitBuild directory.
2657 2015-10-08 Alexey Proskuryakov <ap@apple.com>
2659 Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
2660 https://bugs.webkit.org/show_bug.cgi?id=149848
2662 Reviewed by Darin Adler.
2664 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2666 2015-10-07 Brent Fulgham <bfulgham@apple.com>
2668 [Win] Support 64-bit Build and Testing
2669 https://bugs.webkit.org/show_bug.cgi?id=149904
2671 Reviewed by Daniel Bates.
2673 Extend our existing scripts to support 64-bit build and test operations on
2676 * Scripts/build-dumprendertree: We don't need to build DRT on its own;
2677 Windows always builds the whole stack.
2678 * Scripts/webkit-build-directory: Add an option to return the location of
2679 the executable files produced by a specific configuration. This change is
2680 actually useful for Gtk and EFL, too.
2681 * Scripts/webkitdirs.pm:
2682 (executableProductDir): Added. This function appends the proper binary
2683 path to the productDir. This is useful for Windows, Gtk, and EFL ports.
2684 (jscProductDir): Use the new 'executableProductDir' method.
2685 (setPathForRunningWebKitApp): Ditto.
2687 (runMiniBrowser): Ditto.
2688 * Scripts/webkitpy/port/factory.py:
2689 (configuration_options): Add a 64-bit option, used on Windows to specify
2690 which binary target should be used for testing.
2691 * Scripts/webkitpy/port/win.py:
2692 (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
2693 processes when needed.
2694 (WinPort._build_path): Add the correct binary target path to _build_path.
2695 (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
2696 64-bit paths for 64-bit tests.
2697 (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
2698 NTSD debugger does not understand this argument.
2700 2015-10-07 Myles C. Maxfield <mmaxfield@apple.com>
2702 Test font-variant-* and font-feature-settings with TrueType fonts
2703 https://bugs.webkit.org/show_bug.cgi?id=149776
2705 Reviewed by Simon Fraser.
2707 This test extends our existing FontWithFeatures project to be able to generate a
2708 TrueType font. This font is conceptually similar as the existing OpenType font,
2709 except the feature -> character mapping is different.
2711 The font itself only supports the following characters:
2712 ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
2713 However, the shape of these letters are either an X or a check mark.
2714 The letter "A" always is a check mark.
2715 The letter "B" always is an X.
2716 Each font feature has an letter associated with it. When the font feature is enabled,
2717 that letter is shown as a check mark. For example, when
2718 "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
2721 Here are the mappings of font features to letters:
2722 kLigaturesType / kCommonLigaturesOnSelector: C
2723 kLigaturesType / kContextualLigaturesOnSelector: D
2724 kLigaturesType / kRareLigaturesOnSelector: G
2725 kLigaturesType / kHistoricalLigaturesOnSelector: I
2726 kContextualAlternatesType / kContextualAlternatesOnSelector: L
2727 kVerticalPositionType / kInferiorsSelector: O
2728 kVerticalPositionType / kSuperiorsSelector: P
2729 kLowerCaseType / kLowerCaseSmallCapsSelector: S
2730 kUpperCaseType / kUpperCaseSmallCapsSelector: V
2731 kLowerCaseType / kLowerCasePetiteCapsSelector: T
2732 kUpperCaseType / kUpperCasePetiteCapsSelector: W
2733 kLetterCaseType / 14: Y
2734 kStyleOptionsType / kTitlingCapsSelector: a
2735 kNumberCaseType / kUpperCaseNumbersSelector: c
2736 kNumberCaseType / kLowerCaseNumbersSelector: d
2737 kNumberSpacingType / kProportionalNumbersSelector: f
2738 kNumberSpacingType / kMonospacedNumbersSelector: g
2739 kFractionsType / kDiagonalFractionsSelector: i
2740 kFractionsType / kVerticalFractionsSelector: j
2741 kVerticalPositionType / kOrdinalsSelector: Q
2742 kTypographicExtrasType / kSlashedZeroOnSelector: k
2743 kLigaturesType / kHistoricalLigaturesOnSelector: K
2744 kCharacterShapeType / kJIS1978CharactersSelector: m
2745 kCharacterShapeType / kJIS1983CharactersSelector: n
2746 kCharacterShapeType / kJIS1990CharactersSelector: o
2747 kCharacterShapeType / kJIS2004CharactersSelector: p
2748 kCharacterShapeType / kSimplifiedCharactersSelector: q
2749 kCharacterShapeType / kTraditionalCharactersSelector: r
2750 kTextSpacingType / kMonospacedTextSelector: t
2751 kTextSpacingType / kProportionalTextSelector: u
2752 kRubyKanaType / kRubyKanaOnSelector: v
2754 * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
2755 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2756 (CFFBuilder::moveTo):
2757 (CFFBuilder::lineTo):
2758 (GLYFBuilder::GLYFBuilder):
2759 (GLYFBuilder::takeResult):
2760 (GLYFBuilder::moveTo):
2761 (GLYFBuilder::lineTo):
2762 (GLYFBuilder::closePath):
2763 (GLYFBuilder::writePoint):
2764 (GLYFBuilder::append16):
2765 (generateBoxCharString):
2766 (generateCheckCharString):
2767 (generateXCharString):
2769 (Generator::generate):
2770 (Generator::insertSelector):
2771 (Generator::insertFeature):
2772 (Generator::generateFeatureDescription):
2773 (Generator::appendCFFTable):
2774 (Generator::appendGLYFTable):
2775 (Generator::appendLOCATable):
2776 (Generator::appendFEATTable):
2777 (Generator::appendMetamorphosisChain):
2778 (Generator::appendMORXTable):
2779 (Generator::appendHEADTable):
2780 (Generator::appendHMTXTable):
2781 (Generator::appendNameSubtable):
2782 (Generator::append2ByteASCIIString):
2783 (Generator::appendNAMETable):
2785 (CFFBuilder::curveToCubic): Deleted.
2786 (charStringForGlyph): Deleted.
2787 * FontWithFeatures/FontWithFeatures/FontCreator.h:
2788 * FontWithFeatures/FontWithFeatures/main.cpp:
2789 (constructFontWithTrueTypeFeature):
2790 (constructFontWithOpenTypeFeature):
2793 (drawTextWithFeature): Deleted.
2795 2015-10-07 Commit Queue <commit-queue@webkit.org>
2797 Unreviewed, rolling out r190572, r190593, r190594, and
2799 https://bugs.webkit.org/show_bug.cgi?id=149897
2801 Breaks Mavericks build (Requested by litherum on #webkit).
2803 Reverted changesets:
2805 "Allow WKRetainPtrs to be used as keys in hashing data
2807 https://bugs.webkit.org/show_bug.cgi?id=149762
2808 http://trac.webkit.org/changeset/190572
2810 "REGRESSION(189668?): http/tests/notifications/events.html
2811 flakily asserts or times out"
2812 https://bugs.webkit.org/show_bug.cgi?id=149218
2813 http://trac.webkit.org/changeset/190593
2815 "Prospective Mavericks build fix."
2816 http://trac.webkit.org/changeset/190594
2818 "Post-review cleanup after r190572."
2819 http://trac.webkit.org/changeset/190639
2821 2015-10-06 Michael Catanzaro <mcatanzaro@igalia.com>
2823 [GTK] Add autocleanups
2824 https://bugs.webkit.org/show_bug.cgi?id=149588
2826 Reviewed by Darin Adler.
2828 * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
2829 (AutocleanupsTest::create):
2830 (AutocleanupsTest::testWebProcessAutocleanups):
2832 * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2833 * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
2834 (testUIProcessAutocleanups):
2835 (testWebProcessAutocleanups):
2839 2015-10-06 Brian Burg <bburg@apple.com>
2841 Unreviewed, try to fix the iOS 8 build after r190368.
2843 On older versions, IOHIDEventCreateForceEvent is not available.
2845 * WebKitTestRunner/ios/HIDEventGenerator.mm:
2846 (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
2848 2015-10-06 Keith Miller <keith_miller@apple.com>
2850 Add gmalloc option to run-javascriptcore-tests.
2851 https://bugs.webkit.org/show_bug.cgi?id=149858
2853 Reviewed by Geoffrey Garen.
2855 run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
2856 If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
2858 * Scripts/run-javascriptcore-tests:
2860 2015-10-06 Myles C. Maxfield <mmaxfield@apple.com>
2862 Post-review cleanup after r190572.
2866 * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
2868 2015-10-06 Brent Fulgham <bfulgham@apple.com>
2870 [Win] Unreviewed build correction.
2872 * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
2873 are soft-linked at runtime.
2875 2015-10-06 Keith Miller <keith_miller@apple.com>
2877 Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
2878 https://bugs.webkit.org/show_bug.cgi?id=149815
2880 Reviewed by Filip Pizlo.
2882 Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
2883 Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
2884 running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
2885 Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
2886 so should just use one test runner.
2888 * Scripts/run-javascriptcore-tests:
2889 (runJSCStressTests):
2890 (runMozillaTests): Deleted.
2891 (defaultJsDriverArgsForMozillaTests): Deleted.
2892 * Scripts/run-jsc-stress-tests:
2894 2015-10-06 Mark Salisbury <mark.salisbury@hp.com>
2896 [GTK] Make update-webkitgtk-libs work behind firewall
2898 update-webkitgtk-libs can work behind a firewall with changes to
2899 a few packages. Where outbound git and active FTP connections
2900 fail, using http protocol succeeds. Most packages are
2901 already accessed using http.
2903 https://bugs.webkit.org/show_bug.cgi?id=148941
2905 Reviewed by Martin Robinson.
2908 * gtk/jhbuild.modules:
2909 Replace git URLs with http. Remove no longer used ftp repositories.
2910 Update argument for libxml2's autogen.sh script (--without-python
2911 is ignored; --with-python=no is correct).
2912 * jhbuild/jhbuild-wrapper:
2913 Instead of connecting to git://git.gnome.org/jhbuild, connect to
2914 http://git.gnome.org/browse/jhbuild.
2916 2015-10-06 Daniel Bates <dbates@webkit.org>
2918 Enable XSLT when building WebKit for iOS using the public iOS SDK
2919 https://bugs.webkit.org/show_bug.cgi?id=149827
2921 Reviewed by Alexey Proskuryakov.
2923 Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
2924 and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
2925 run this script before building WebKit for iOS or the build will fail because one or more XSLT
2926 headers cannot be found.
2928 * Scripts/configure-xcode-for-ios-development:
2929 (copyMissingXSLTHeadersToSDKIfNeeded): Added.
2931 2015-10-05 Myles C. Maxfield <mmaxfield@apple.com>
2933 REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
2934 https://bugs.webkit.org/show_bug.cgi?id=149218
2936 Reviewed by Alexey Proskuryakov.
2938 Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
2939 when the TestOptions change. Previously, WebNotificationProvider only could handle a single
2940 WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
2941 and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
2942 the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
2943 WebNotificationProvider must be updated to appropriately handle multiple
2944 WKNotificationManagerRefs in flight at the same time.
2946 * WebKitTestRunner/WebNotificationProvider.cpp:
2947 (WTR::WebNotificationProvider::~WebNotificationProvider):
2948 (WTR::WebNotificationProvider::showWebNotification):
2949 (WTR::WebNotificationProvider::closeWebNotification):
2950 (WTR::WebNotificationProvider::addNotificationManager):
2951 (WTR::WebNotificationProvider::removeNotificationManager):
2952 (WTR::WebNotificationProvider::simulateWebNotificationClick):
2953 (WTR::WebNotificationProvider::reset):
2954 * WebKitTestRunner/WebNotificationProvider.h:
2956 2015-10-05 Daniel Bates <dabates@apple.com>
2958 Disable Bitcode when building for iOS device
2959 https://bugs.webkit.org/show_bug.cgi?id=149818
2961 Reviewed by Alexey Proskuryakov.
2963 Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
2964 when building for iOS device.
2966 * Scripts/webkitdirs.pm:
2969 2015-10-05 Daniel Bates <dabates@apple.com>
2971 [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
2972 https://bugs.webkit.org/show_bug.cgi?id=140828
2973 <rdar://problem/19520599>
2975 Reviewed by Alexey Proskuryakov.
2977 Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
2978 we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
2979 to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
2982 * Scripts/webkitdirs.pm:
2983 (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
2984 to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
2985 Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
2986 (hasIOSDevelopmentCertificate): Added.
2988 2015-10-05 Daniel Bates <dabates@apple.com>
2990 DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
2991 https://bugs.webkit.org/show_bug.cgi?id=149766
2993 Reviewed by Alexey Proskuryakov.
2995 Create network storage testing session on iOS.
2997 Currently we do not create a network storage testing session on iOS. A network storage testing session always
2998 has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
2999 returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
3000 NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
3001 NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
3002 it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
3003 create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
3004 testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
3005 DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
3007 As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
3008 when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
3009 returns a non-null pointer to a cookie store.
3011 * DumpRenderTree/mac/DumpRenderTree.mm:
3012 (prepareConsistentTestingEnvironment):
3014 2015-10-05 Simon Fraser <simon.fraser@apple.com>
3016 Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
3019 * WebKitTestRunner/ios/HIDEventGenerator.mm:
3020 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
3022 2015-10-05 Myles C. Maxfield <mmaxfield@apple.com>
3024 Allow WKRetainPtrs to be used as keys in hashing data structures
3025 https://bugs.webkit.org/show_bug.cgi?id=149762
3027 Reviewed by Anders Carlsson.
3029 * TestWebKitAPI/PlatformGTK.cmake:
3030 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3031 * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
3032 (TestWebKitAPI::TEST):
3034 2015-10-05 Simon Fraser <simon.fraser@apple.com>
3036 Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
3037 available, and tidy up the #ifdefs in the UIKitSPI header.
3039 * WebKitTestRunner/ios/HIDEventGenerator.mm:
3040 (-[HIDEventGenerator _sendHIDEvent:]):
3041 * WebKitTestRunner/ios/UIKitSPI.h:
3043 2015-10-04 Zan Dobersek <zdobersek@igalia.com>
3045 [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
3046 https://bugs.webkit.org/show_bug.cgi?id=149792
3048 Reviewed by Martin Robinson.
3050 * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
3051 for WebKitTestRunner multiple times.
3053 2015-10-04 Daniel Bates <dabates@apple.com>
3055 Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
3056 (https://bugs.webkit.org/show_bug.cgi?id=149753)
3058 For now, support calling build-layouttestrelay without --ios-simulator so long
3059 as we are building on a Mac.
3061 * Scripts/build-layouttestrelay:
3063 2015-10-04 Alexey Proskuryakov <ap@apple.com>
3065 Support Trac 1.0.x XML timeline link format
3066 https://bugs.webkit.org/show_bug.cgi?id=149786
3068 Reviewed by Lucas Forschler.
3070 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3071 (Trac.prototype._convertCommitInfoElementToObject):
3073 2015-10-04 Alexey Proskuryakov <ap@apple.com>
3075 Fix some errors on bot watcher's dashboard
3076 https://bugs.webkit.org/show_bug.cgi?id=149789
3078 Reviewed by Lucas Forschler.
3080 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3081 (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
3082 tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
3084 2015-10-04 Alexey Proskuryakov <ap@apple.com>
3086 Bot watcher's dashboard builders should turn yellow when svn fails
3087 https://bugs.webkit.org/show_bug.cgi?id=149791
3089 Reviewed by Lucas Forschler.
3091 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3092 (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
3093 (BuildbotBuilderQueueView.prototype.update):
3095 2015-10-02 Daniel Bates <dabates@apple.com>
3097 Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
3098 https://bugs.webkit.org/show_bug.cgi?id=149769
3100 Reviewed by Alexey Proskuryakov.
3102 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
3103 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
3104 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3105 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3107 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3108 (table.queue-grid tr.platform.ios-simulator-9 img.logo):
3110 2015-10-02 Ryosuke Niwa <rniwa@webkit.org>
3112 REGRESSION(r190370): Speedometer spits out an extra console message
3113 https://bugs.webkit.org/show_bug.cgi?id=149720
3115 Unreviewed. Temporarily ignore the console error message.
3117 * Scripts/webkitpy/performance_tests/perftest.py:
3118 (PerfTest._filter_output):
3120 2015-10-02 Brent Fulgham <bfulgham@apple.com>
3122 Provide "--no-ninja" option to avoid using Ninja
3123 https://bugs.webkit.org/show_bug.cgi?id=149757
3125 Reviewed by Alex Christensen.
3127 Add a new command line argument understood by webkitdirs.pm so
3128 that we can conditionally avoid using Ninja. This is an
3129 'opt-out' argument, so no existing Ninja users should be affected.
3131 * Scripts/webkitdirs.pm:
3132 (canUseNinja): Check for option and block ninja if present.
3134 2015-10-02 Aakash Jain <aakash_jain@apple.com>
3136 Flakiness dashboard should support OS X El Capitan
3137 https://bugs.webkit.org/show_bug.cgi?id=149648
3139 Reviewed by Alexey Proskuryakov.
3141 * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
3143 2015-10-02 Daniel Bates <dabates@apple.com>
3145 Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
3146 (https://bugs.webkit.org/show_bug.cgi?id=149753)
3148 For now, pass --ios-simulator.
3150 * Scripts/webkitpy/port/ios.py:
3151 (IOSSimulatorPort._build_relay):
3153 2015-10-02 Simon Fraser <simon.fraser@apple.com>
3155 Remove a "nullable" that breaks the iOS 8 build.
3157 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3158 (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
3160 2015-10-02 Daniel Bates <dabates@apple.com>
3162 LayoutTestRelay is not built and archived when building for iOS Simulator
3163 https://bugs.webkit.org/show_bug.cgi?id=149753
3165 Reviewed by Alexey Proskuryakov and Andy Estes.
3167 Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
3168 and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
3169 product archive when building for iOS Simulator, respectively.
3171 * BuildSlaveSupport/built-product-archive:
3172 (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
3173 differentiate between iOS device and iOS Simulator platforms.
3174 (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
3175 from determineWebKitBuildDirectories() into this function so that it can be used by both
3176 determineWebKitBuildDirectories() and archiveBuiltProduct().
3177 (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
3178 webkitBuildDirectoryForConfigurationAndPlatform().
3179 (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
3180 we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
3181 argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
3182 when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
3183 and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
3184 for the limitation that ditto(1) can only accept a single directory to archive on its command line.
3185 (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
3186 For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
3187 build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
3188 LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
3189 * Scripts/build-layouttestrelay:
3190 - Remove unnecessary include of Perl module POSIX.
3191 - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
3192 * Scripts/build-webkit:
3193 - Invoke script build-layouttestrelay when building for iOS Simulator.
3195 2015-10-02 Brent Fulgham <bfulgham@apple.com>
3197 [Win] Unreviewed test fix.
3199 You cannot run 'run-webkit-tests' from the command line because it does not know
3200 to append the binary subdirectory (bin32/bin64). We don't see this on our builders
3201 because they explicitly set use the 'root' argument to provide the full path to
3204 * Scripts/webkitpy/port/win.py:
3205 (WinPort._build_path): Added.
3207 2015-10-02 Alex Christensen <achristensen@webkit.org>
3209 Reloading without content blockers doesn't apply to resource loads after the main frame finishes
3210 https://bugs.webkit.org/show_bug.cgi?id=149430
3211 rdar://problem/22742222
3213 Reviewed by Geoffrey Garen.
3215 * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3216 (WTR::TestController::cocoaResetStateToConsistentValues):
3217 * WebKitTestRunner/mac/TestControllerMac.mm:
3218 (WTR::TestController::platformConfigureViewForTest):
3219 Test what happens when you disable content blockers from the SPI.
3221 2015-10-01 Brent Fulgham <bfulgham@apple.com>
3223 [Win] Unreviewed build fix for run-api-tests
3225 * Scripts/run-api-tests:
3226 (testToolPaths): Windows run needs to specify the binary path.
3228 2015-10-01 Daniel Bates <dabates@apple.com>
3230 Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
3231 (https://bugs.webkit.org/show_bug.cgi?id=149695)
3233 Following r190424 we can now rely on webkit-build-directory to return the path to
3234 the correct configuration-specific build directory on Windows.
3236 * BuildSlaveSupport/built-product-archive:
3237 (archiveBuiltProduct):
3239 2015-10-01 Brent Fulgham <bfulgham@apple.com>
3241 [Win] Unreviewed build fix.
3243 * Scripts/webkitdirs.pm:
3244 (setupAppleWinEnv): Use 64-bit build tools if available
3246 2015-10-01 Brent Fulgham <bfulgham@apple.com>
3248 [Win] Fix TestWebKitAPI build under CMake.
3250 Reviewed by Alex Christensen.
3252 * TestWebKitAPI/PlatformWin.cmake: Add missing link command
3255 2015-10-01 Brent Fulgham <bfulgham@apple.com>
3257 [Win] Fix behavior of webkit-build-directory script
3258 https://bugs.webkit.org/show_bug.cgi?id=149718
3260 Reviewed by Alex Christensen.
3262 * Scripts/webkitdirs.pm:
3263 (determineConfigurationProductDir): Do not include the binary
3264 sub-directory in the configuration product directory output.
3265 (jscProductDir): Append correct binary path for Windows build.
3266 (setPathForRunningWebKitApp): Include properly binary subdirectories.
3267 (runSafari): Update for revised productDir behavior.
3268 (runMiniBrowser): Ditto.
3270 2015-10-01 Alexey Proskuryakov <ap@apple.com>
3272 Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
3273 use iOS SDK, like with all the others.
3275 * Scripts/build-webkit:
3277 2015-10-01 Daniel Bates <dabates@apple.com>
3279 Attempt to fix the iOS 9 Simulator testers
3281 Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
3282 build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
3283 LayoutTestRelay when building for iOS Simulator.
3285 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3286 * Scripts/build-webkit:
3288 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
3290 [GTK] Websites with invalid auth header keep loading forever
3291 https://bugs.webkit.org/show_bug.cgi?id=149710
3293 Reviewed by Martin Robinson.
3295 Add test case to check that we can authenticate sites with an
3298 * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
3299 (testWebViewAuthenticationEmptyRealm):
3303 2015-10-01 Alexey Proskuryakov <ap@apple.com>
3305 [Mac] Make run-api-tests work with System Integrity Protection
3306 https://bugs.webkit.org/show_bug.cgi?id=149711
3307 rdar://problem/22928202
3309 Reviewed by Dan Bernstein.
3311 * Scripts/run-api-tests:
3313 (archCommandLineArgumentsForRestrictedEnvironmentVariables):
3315 2015-10-01 Daniel Bates <dabates@apple.com>
3317 Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
3318 (https://bugs.webkit.org/show_bug.cgi?id=149695)
3320 For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
3321 For now, use the path to the top-level WebKit build directory instead of using the configuration-
3322 specific build directory.
3324 * BuildSlaveSupport/built-product-archive:
3325 (archiveBuiltProduct):
3327 2015-10-01 Csaba Osztrogonác <ossy@webkit.org>
3329 [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
3330 https://bugs.webkit.org/show_bug.cgi?id=145837
3332 Reviewed by Philippe Normand.
3334 * efl/jhbuild.modules:
3335 * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
3336 * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
3338 2015-10-01 Wenson Hsieh <wenson_hsieh@apple.com>
3340 Unreviewed. Fix the iOS build after r190407.
3342 * WebKitTestRunner/ios/IOKitSPI.h:
3344 2015-10-01 Wenson Hsieh <wenson_hsieh@apple.com>
3346 Implement keyboard event sending for iOS in WebKitTestRunner
3347 https://bugs.webkit.org/show_bug.cgi?id=149676
3349 Reviewed by Simon Fraser.
3351 Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
3352 way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
3353 allows us to run code when the keyboard is shown or hidden.
3355 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
3356 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
3357 (WTR::UIScriptController::setDidShowKeyboardCallback):
3358 (WTR::UIScriptController::didShowKeyboardCallback):
3359 (WTR::UIScriptController::setDidHideKeyboardCallback):
3360 (WTR::UIScriptController::didHideKeyboardCallback):
3361 (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
3362 (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
3363 (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
3364 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
3365 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3366 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3367 (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
3368 the notifications that the keyboard has been raised or lowered.
3369 (-[TestRunnerWKWebView _keyboardDidShow:]):
3370 (-[TestRunnerWKWebView _keyboardDidHide:]):
3371 * WebKitTestRunner/ios/HIDEventGenerator.h:
3372 * WebKitTestRunner/ios/HIDEventGenerator.m:
3373 (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
3374 (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
3375 (hidUsageCodeForCharacter): Ditto.
3376 (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
3377 a keyDown event in WebKit.
3378 * WebKitTestRunner/ios/IOKitSPI.h:
3379 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3381 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
3383 Unreviewed, rolling out r190399.
3385 Tests are still failing even after r190362
3389 "Unreviewed. Unskip GTK+ user media unit tests after r190362."
3390 http://trac.webkit.org/changeset/190399
3392 2015-10-01 Csaba Osztrogonác <ossy@webkit.org>
3394 [jhbuild] switch to new upstream usrsctp library
3395 https://bugs.webkit.org/show_bug.cgi?id=149494
3397 Reviewed by Philippe Normand.
3399 * efl/jhbuild.modules:
3400 * gtk/jhbuild.modules:
3402 2015-10-01 Carlos Garcia Campos <cgarcia@igalia.com>
3404 Unreviewed. Unskip GTK+ user media unit tests after r190362.
3406 They should pass now.
3408 * Scripts/run-gtk-tests:
3411 2015-09-30 Daniel Bates <dabates@apple.com>
3413 Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
3414 (https://bugs.webkit.org/show_bug.cgi?id=149695)
3416 * BuildSlaveSupport/built-product-archive:
3417 (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
3418 (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
3420 2015-09-30 Daniel Bates <dabates@apple.com>
3422 Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
3423 (https://bugs.webkit.org/show_bug.cgi?id=149695)
3425 Actually, we need to pass --configuration to script webkit-build-directory to have
3426 it return the path to the configuration-specific build directory.
3428 * BuildSlaveSupport/built-product-archive:
3429 (determineWebKitBuildDirectories):
3431 2015-09-30 Daniel Bates <dabates@apple.com>
3433 built-product-archive archives incorrect build directory for iOS port
3434 https://bugs.webkit.org/show_bug.cgi?id=149695
3436 Reviewed by Darin Adler.
3438 Fixes an issue where the script built-product-archive archives a non-existent
3439 build directory for the iOS port. Without loss of generality, the script assumes
3440 the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
3441 But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
3443 Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
3444 to determine the top-level build directory and computes the configuration-specific
3445 build directory to be the concatenation of the the top-level build directory and
3446 the configuration (e.g. Release). This is incorrect. Instead we should call
3447 webkit-build-directory omitting the flag --top-level to compute the path to the
3448 configuration-specific build directory.
3450 * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
3451 (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
3452 its purpose and added global variable _configurationBuildDirectory to store the path
3453 to the configuration-specific build directory. Ensure that we have a non-empty string
3454 for both the top-level and configuration-specific build directories.
3455 (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
3456 Compute the configuration-specific build directory and store it in the global variable
3457 _configurationBuildDirectory.
3458 (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
3459 (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
3461 (determineWebKitBuildDirectory): Deleted.
3463 2015-09-30 Hunseop Jeong <hs85.jeong@samsung.com>
3465 [EFL] css3/device-adapt/* tests failed after r190335.
3466 https://bugs.webkit.org/show_bug.cgi?id=149655
3468 Reviewed by Simon Fraser.
3470 device-adapt/* tests need the fixedLayout option but useFixedLayout option is
3471 overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
3473 * WebKitTestRunner/efl/TestControllerEfl.cpp:
3474 (WTR::shouldUseFixedLayout):
3476 2015-09-30 Dewei Zhu <dewei_zhu@apple.com>
3478 Extend JetStream timeout for slow devices.
3480 Reviewed by Chris Dumez.
3482 Extend JetStream timeout to 20 minutes.
3484 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
3486 2015-09-30 Daniel Bates <dabates@apple.com>
3488 Rename iOS builders/testers to include version
3489 https://bugs.webkit.org/show_bug.cgi?id=149685
3491 Reviewed by Simon Fraser.
3493 Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
3494 make it clear to a reader the version of iOS these builders/testers are using.
3496 * BuildSlaveSupport/build.webkit.org-config/config.json:
3497 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3499 2015-09-30 Daniel Bates <dabates@apple.com>
3501 Add iOS criterion for triggering a build
3502 https://bugs.webkit.org/show_bug.cgi?id=149679
3504 Rubber-stamped by Alexey Proskuryakov.
3506 First pass at defining criterion for triggering an iOS build.
3508 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3509 (_should_file_trigger_build):
3510 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3512 (ShouldBuildTest.test_should_build):
3514 2015-09-29 Simon Fraser <simon.fraser@apple.com>
3516 [iOS] Allow tests to generate user gestures for UI testing
3517 https://bugs.webkit.org/show_bug.cgi?id=149653
3519 Reviewed by Tim Horton.
3521 Expose functionality in UIScriptController to allow for testing single- and double-tap,
3522 and to listen for completion of scrolling and zooming in the WKWebView.
3524 Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
3525 which hides the complexity of creating these events. Event dispatch is asynchronous.
3526 We detect when the last event has been handled by dispatching a vendor-specific event,
3527 which is detected via -_handleHIDEvent: in our UIApplication subclass.
3529 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
3530 * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
3531 for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
3532 single and double taps.
3533 * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
3534 (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
3535 Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
3536 (UIScriptContext::unregisterCallback):
3537 (UIScriptContext::callbackWithID):
3538 (UIScriptContext::fireCallback):
3539 * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
3540 * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
3541 (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
3542 (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
3543 (WTR::UIScriptController::setDidEndZoomingCallback):
3544 (WTR::UIScriptController::didEndZoomingCallback):
3545 (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
3546 (WTR::UIScriptController::doubleTapAtPoint): Ditto.
3547 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
3548 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
3549 * WebKitTestRunner/UIScriptContext/UIScriptController.h:
3550 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3551 * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
3552 * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3553 (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
3554 (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
3555 (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
3556 (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
3557 * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
3558 * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
3560 (calculateNextLocation):
3562 (+[HIDEventGenerator sharedHIDEventGenerator]):
3563 (+[HIDEventGenerator nextEventCallbackID]):
3564 (-[HIDEventGenerator init]):
3565 (-[HIDEventGenerator _createIOHIDEventType:]):
3566 (-[HIDEventGenerator _sendHIDEvent:]):
3567 (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
3568 (-[HIDEventGenerator _updateTouchPoints:count:]):
3569 (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
3570 (-[HIDEventGenerator touchDown:touchCount:]):
3571 (-[HIDEventGenerator touchDown:]):
3572 (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
3573 (-[HIDEventGenerator liftUp:touchCount:]):
3574 (-[HIDEventGenerator liftUp:]):
3575 (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
3576 (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3577 (-[HIDEventGenerator tap:completionBlock:]):
3578 (-[HIDEventGenerator doubleTap:completionBlock:]):
3579 (-[HIDEventGenerator twoFingerTap:completionBlock:]):
3580 (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3581 (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
3582 (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
3583 (-[HIDEventGenerator markerEventReceived:]):
3584 * WebKitTestRunner/ios/IOKitSPI.h: Added.
3585 * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
3586 * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3587 (WTR::globalToContentCoordinates):
3588 (WTR::UIScriptController::singleTapAtPoint):
3589 (WTR::UIScriptController::doubleTapAtPoint):
3590 (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
3591 (WTR::UIScriptController::platformSetDidEndZoomingCallback):
3592 * WebKitTestRunner/ios/mainIOS.mm:
3593 (-[WebKitTestRunnerApp _handleHIDEvent:]):
3595 2015-09-30 Dana Burkart <dburkart@apple.com>
3597 git-add-reviewer should trim trailing spaces/newlines
3598 https://bugs.webkit.org/show_bug.cgi?id=149513
3600 Reviewed by Darin Adler.
3602 * Scripts/git-add-reviewer:
3605 2015-09-30 Eric Carlson <eric.carlson@apple.com>
3607 REGRESSION(r190262): User media unit test failures after r190262
3608 https://bugs.webkit.org/show_bug.cgi?id=149580
3610 Reviewed by Darin Adler.
3612 * WebKitTestRunner/TestController.cpp:
3613 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
3614 order to WKUserMediaPermissionRequestAllow.
3616 2015-09-30 Daniel Bates <dabates@apple.com>
3618 Add iOS builders and testers
3619 https://bugs.webkit.org/show_bug.cgi?id=149549
3621 Reviewed by Alexey Proskuryakov.
3623 Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
3624 builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
3626 * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
3627 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
3629 2015-09-30 Timothy Hatcher <timothy@apple.com>
3631 Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
3632 https://bugs.webkit.org/show_bug.cgi?id=149674
3634 Reviewed by Lucas Forschler.
3636 * WebKitLauncher/WebKitLauncher.entitlements: Added.
3637 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3639 2015-09-30 Jason Marcell <jmarcell@apple.com>
3641 BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
3642 have an associated trac instance.
3643 https://bugs.webkit.org/show_bug.cgi?id=149673
3645 Reviewed by Alexey Proskuryakov.
3647 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3648 (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
3649 have an associated trac instance.
3651 2015-09-30 Daniel Bates <dabates@apple.com>
3653 Prioritize testing latest build request on iOS test bots
3654 https://bugs.webkit.org/show_bug.cgi?id=149669
3656 Reviewed by Darin Adler.
3658 We should prioritize testing of the latest build request on the iOS test bots
3659 as we do for Mac and Windows test bots.
3661 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3662 (loadBuilderConfig):
3664 2015-09-30 Daniel Bates <dabates@apple.com>
3666 Add buildbot category for iOS builders and testers
3667 https://bugs.webkit.org/show_bug.cgi?id=149667
3669 Reviewed by Darin Adler.
3671 Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
3672 for iOS to the build.webkit.org home page.
3674 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3675 (loadBuilderConfig):
3676 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3678 2015-09-30 Daniel Bates <dabates@apple.com>
3680 Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
3681 (https://bugs.webkit.org/show_bug.cgi?id=149539)
3683 I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
3684 in <http://trac.webkit.org/changeset/190351>.
3686 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3687 (CompileWebKit.start):
3689 2015-09-30 Daniel Bates <dabates@apple.com>
3691 Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
3692 (https://bugs.webkit.org/show_bug.cgi?id=149539)
3694 {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
3695 respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
3697 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3698 (CompileWebKit.start):
3700 2015-09-30 Lucas Forschler <lforschler@apple.com>
3702 bot210 was configured for a queue instead of bot126.
3704 Unreviewed config.json fix.
3706 * BuildSlaveSupport/build.webkit.org-config/config.json:
3708 2015-09-30 Lucas Forschler <lforschler@apple.com>
3710 Bring El Capitan buildbot infrastructure online.
3711 https://bugs.webkit.org/show_bug.cgi?id=149605
3713 Reviewed by Darin Adler.
3715 * BuildSlaveSupport/build.webkit.org-config/config.json:
3717 2015-09-30 Tomas Popela <tpopela@redhat.com>
3719 [GTK] Deprecation warnings in DOMNodeTest
3720 https://bugs.webkit.org/show_bug.cgi?id=149663
3722 After the webkit_dom_document_get_elements_by_tag_name deprecation we
3723 need to update the tests to use webkit_dom_document_query_selector_all
3724 to avoid compilation warnings.
3726 Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
3727 (the suggested replacement for the deprecated function).
3729 Reviewed by Carlos Garcia Campos.
3731 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3732 (WebKitDOMNodeTest::testTagNamesNodeList):
3733 (WebKitDOMNodeTest::testTagNamesHTMLCollection):
3735 (WebKitDOMNodeTest::testTagNames): Deleted.
3736 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3737 (prepareDOMForTagNamesTests):
3738 (testWebKitDOMNodeTagNamesNodeList):
3739 (testWebKitDOMNodeTagNamesHTMLCollection):
3741 (testWebKitDOMNodeTagNames): Deleted.
3743 2015-09-29 Simon Fraser <simon.fraser@apple.com>
3745 WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
3746 https://bugs.webkit.org/show_bug.cgi?id=149650
3748 Reviewed by Tim Horton.
3750 TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
3751 looks at the file path, and not the custom options that come from file comments.
3753 Fix by computing TestOptions before making the TestInvocation, and setting them
3754 as const TestInvocation data. This meant changing various call sites to take
3755 the std::string pathOrURL, rather than the TestInvocation itself.
3757 Also initialize TestInvocation with a WKURLRef, rather than a std::string.
3759 * WebKitTestRunner/CMakeLists.txt:
3760 * WebKitTestRunner/TestController.cpp:
3761 (WTR::TestController::ensureViewSupportsOptionsForTest):
3763 (WTR::createTestURL):
3764 (WTR::updateTestOptionsFromTestHeader):
3765 (WTR::TestController::testOptionsForTest):
3766 (WTR::TestController::updateWebViewSizeForTest):
3767 (WTR::TestController::updateWindowScaleForTest):
3768 (WTR::TestController::runTest):
3769 * WebKitTestRunner/TestController.h:
3770 * WebKitTestRunner/TestInvocation.cpp:
3771 (WTR::TestInvocation::TestInvocation):
3772 (WTR::TestInvocation::invoke):
3773 (WTR::createWKURL): Deleted.
3774 (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
3775 (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
3776 * WebKitTestRunner/TestInvocation.h:
3777 (WTR::TestInvocation::options):
3778 * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
3779 (WTR::pathContains):
3780 (WTR::shouldMakeViewportFlexible):
3781 (WTR::shouldUseFixedLayout):
3782 (WTR::isSVGTestPath):
3783 (WTR::isHiDPITestPath):
3784 (WTR::TestOptions::TestOptions):
3785 * WebKitTestRunner/TestOptions.h:
3786 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3787 * WebKitTestRunner/efl/TestControllerEfl.cpp:
3788 (WTR::pathContains):
3789 (WTR::shouldUseFixedLayout):
3790 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3791 * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3792 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3793 * WebKitTestRunner/ios/TestControllerIOS.mm:
3794 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3795 * WebKitTestRunner/mac/TestControllerMac.mm:
3796 (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3798 2015-09-29 Aakash Jain <aakash_jain@apple.com>
3800 Flakiness dashboard should support OS X El Capitan
3801 https://bugs.webkit.org/show_bug.cgi?id=149648
3803 Reviewed by Alexey Proskuryakov.
3805 * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of
3806 difference between new appscale and old Google App Engine implementation.
3807 * TestResultServer/app.yaml: Same.
3808 * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
3810 2015-09-29 Daniel Bates <dabates@apple.com>
3812 configure-xcode-for-ios-development does not work with Xcode 7
3813 https://bugs.webkit.org/show_bug.cgi?id=149640
3815 Reviewed by Alexey Proskuryakov.
3817 When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
3818 because it cannot find the Xcode specification files for iOS simulator and device. These
3819 files have moved to a new location in Xcode 7 distribution. Moreover we must add the
3820 relevant definitions to the Xcode 7 specification files directly as opposed to creating
3821 new specification files with the added definitions (as we did in older versions of Xcode)
3822 in order for Xcode 7 to honor these definitions.
3824 * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
3825 (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
3826 (updateXcode7SpecificationFile): Added.
3827 (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
3828 (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
3829 appropriate success message.
3830 (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
3831 (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
3832 (createXcodeSpecificationFromSpecificationAndId): Deleted.
3834 2015-09-29 Brent Fulgham <bfulgham@apple.com>
3836 [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
3837 https://bugs.webkit.org/show_bug.cgi?id=149639
3839 Reviewed by Alex Christensen.
3841 * Scripts/VCSUtils.pm:
3842 (exitStatus): Use 'isWindows()' method.
3843 (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
3844 an error. This method could probably just go away.
3845 (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
3846 always changing to Unix style.
3847 (unixPath): Added. Needed so Windows can always show a Unix path in the
3849 (changeLogName): Work around the fact that 'getpwuid' is not available on
3850 a pure Windows build of Perl.
3851 * Scripts/prepare-ChangeLog:
3852 (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
3854 (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
3855 support using arrays for 'open' arguments.
3856 (resolveChangeLogsPath): Ditto.
3857 (resolveConflictedChangeLogs): Use new helper functions.
3858 (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
3859 (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
3860 quotes. Unix systems are happy either way.
3861 (statusCommand): Ditto.
3862 * Scripts/webkitdirs.pm:
3863 (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
3865 2015-09-29 Brent Fulgham <bfulgham@apple.com>
3867 [Win] Unreviewed 64-bit build fix after switch to CMake.
3869 * Scripts/webkitdirs.pm:
3870 (determineIsWin64FromArchitecture): Added.
3872 2015-09-16 Carlos Garcia Campos <cgarcia@igalia.com>
3874 printing does not use minimum page zoom factor
3875 https://bugs.webkit.org/show_bug.cgi?id=108507
3877 Reviewed by Darin Adler.
3879 WebKitTestRunner always takes the snapshots from the UI process
3880 (expect for IOS), so in the case of printing, the layout in the
3881 web view is not the expected one. When printing, we need to take
3882 the snapshot in the web process and ensure it's rendered with a
3885 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3886 (WTR::InjectedBundlePage::dump): When dumping pixels, pass
3887 kWKSnapshotOptionsPrinting option to
3888 WKBundlePageCreateSnapshotWithOptions() when printing.
3890 2015-09-28 Carlos Garcia Campos <cgarcia@igalia.com>
3892 [WTR] Pixel tests generate the snapshots twice in Web and UI processes
3893 https://bugs.webkit.org/show_bug.cgi?id=149595
3895 Reviewed by Tim Horton.
3897 All ports except IOS implement
3898 PlatformWebView::windowSnapshotImage() to generate the snapshot
3899 for the pixel tests in the UI process. But we are still generating
3900 a snapshot for pixel tests in the Web process too, that is passed
3901 to the UI process but ignored.
3902 Whether a pixel result is needed or not, is only known by the web
3903 process depending on whether the test called dumpAsText with
3904 dumpPixels == true or not. Since the pixels are now dump in the UI
3905 process, we need to pass that information to the UI process when
3906 the test is done. For that we set a PixelResultIsPending bool
3907 parameter to the Done message, and we only add the PixelResult
3908 when UI process doesn't need to generate the pixels dump.
3910 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3911 (WTR::InjectedBundle::didReceiveMessageToPage): Set
3912 m_pixelResultIsPending to false on reset.
3913 (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
3914 Done message, and set the PixelResult if m_pixelResultIsPending is false.
3915 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3916 (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
3917 (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
3918 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3919 (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
3921 * WebKitTestRunner/TestInvocation.cpp:
3922 (WTR::TestInvocation::dumpResults): Use either the pixel result
3923 from the web process or generate a pixel result from the web view
3925 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3926 * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
3927 parameter to dumpPixelsAndCompareWithExpected, since the snapshot
3928 is created by the caller now, but the CG implementation needs to
3929 know if it's a Web or UI process snapshot.
3930 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3931 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3932 cairo surface for the given image.
3933 * WebKitTestRunner/cg/TestInvocationCG.cpp:
3934 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
3935 CGContext for the given image.
3937 2015-09-28 Dean Johnson <dean_johnson@apple.com>
3939 Fix JS errors on dashboard metrics page
3940 https://bugs.webkit.org/show_bug.cgi?id=149608
3942 Reviewed by Alexey Proskuryakov.
3944 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
3945 (initPlatformsByFamily):
3946 (updateHiddenPlatforms):
3947 (parsePlatformFamily): Deleted.
3948 (updateToggleButtons): Deleted.
3949 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3950 (updateHiddenPlatforms): Added to remove errors.
3951 (initPlatformsByFamily): Added to remove errors.
3952 (unhiddenQueues): Updated to use Settings.
3953 (documentReady): Added logic to add toggle buttons to the settings menu.
3954 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3955 (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
3956 MetricsMain.js to Settings.
3957 (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
3958 MetricsMain.js to Settings.
3959 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3960 (QueueView.prototype._updateHiddenState): Updated to use Settings.
3962 2015-09-28 Aakash Jain <aakash_jain@apple.com>
3964 Appscale query fails because of missing index
3965 https://bugs.webkit.org/show_bug.cgi?id=149609
3967 Reviewed by Darin Adler.
3969 * QueueStatusServer/index.yaml: Added the required index.
3971 2015-09-28 Brent Fulgham <bfulgham@apple.com>
3973 [Win] Fix the 64-bit build after switch to cmake.
3975 Reviewed by Alex Christensen.
3977 * Scripts/webkitdirs.pm:
3978 (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
3981 2015-09-28 Brent Fulgham <bfulgham@apple.com>
3983 [Win] Allow Windows to run test-webkitpy without Cygwin
3984 https://bugs.webkit.org/show_bug.cgi?id=149602
3986 Reviewed by Alex Christensen.
3988 These changes mostly shift from hard-coded paths using UNIX-style
3989 separators to Python's "os.path.join" syntax that uses the correct
3990 path separator for each platform.
3992 * Scripts/webkitpy/common/system/path.py:
3993 (cygpath): Don't pass paths through Cygpath on native Windows.
3994 * Scripts/webkitpy/port/win.py:
3995 (WinPort._path_to_apache): Use os.path.join.
3996 (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
3997 in 64-bit environments).
3998 * Scripts/webkitpy/style/checker.py: Use os.path.join.
3999 * Scripts/webkitpy/style/checker_unittest.py:
4000 (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
4001 (GlobalVariablesTest.test_path_rules_specifier): Ditto.
4002 (GlobalVariablesTest): Ditto.
4003 (GlobalVariablesTest.test_max_reports_per_category): Ditto.
4004 (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
4005 (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
4006 (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
4007 (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
4008 (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
4009 (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
4010 (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
4011 (StyleProcessor_CodeCoverageTest): Ditto.
4012 (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
4013 (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
4014 (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
4015 * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
4016 manual string concatenation of paths.
4018 2015-09-28 Csaba Osztrogonác <ossy@webkit.org>
4020 Add bugzilla addresses of committers to contributors.json
4021 https://bugs.webkit.org/show_bug.cgi?id=149520
4023 Reviewed by Darin Adler.
4025 * Scripts/webkitpy/common/config/contributors.json:
4027 2015-09-28 Csaba Osztrogonác <ossy@webkit.org>
4029 validate-committer-lists -b shouldn't need edituser privileges
4030 https://bugs.webkit.org/show_bug.cgi?id=149519
4032 Reviewed by Darin Adler.
4034 * Scripts/validate-committer-lists:
4035 (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
4036 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4037 (BugzillaQueries.is_invalid_bugzilla_email):
4038 (BugzillaQueries): Deleted.
4039 (BugzillaQueries.fetch_logins_matching_substring): Deleted.
4041 2015-09-26 Carlos Garcia Campos <cgarcia@igalia.com>
4043 Unreviewed. Gardening: skip media stream tests failing after r190262.
4045 * Scripts/run-gtk-tests:
4048 2015-09-25 Alexey Proskuryakov <ap@apple.com>
4050 [Mac] USE_INTERNAL_SDK is used undefined in tools projects
4051 https://bugs.webkit.org/show_bug.cgi?id=149571
4053 Reviewed by Dan Bernstein.
4055 Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig).
4057 * DumpRenderTree/mac/Configurations/Base.xcconfig:
4058 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
4059 * LayoutTestRelay/Configurations/Base.xcconfig:
4060 * MiniBrowser/Configurations/Base.xcconfig:
4061 * MiniBrowser/Configurations/DebugRelease.xcconfig:
4062 * TestWebKitAPI/Configurations/Base.xcconfig:
4063 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
4064 * WebEditingTester/Configurations/Base.xcconfig:
4065 * WebEditingTester/Configurations/DebugRelease.xcconfig:
4066 * WebKitTestRunner/Configurations/Base.xcconfig:
4067 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
4068 * WebKitTestRunner/iOS.xcconfig: Removed.
4070 2015-09-25 Eric Carlson <eric.carlson@apple.com>
4072 Clean up user media request internal API
4073 https://bugs.webkit.org/show_bug.cgi?id=149527
4075 Reviewed by Tim Horton.
4077 * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
4078 (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
4080 * WebKitTestRunner/TestController.cpp:
4081 (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
4083 2015-09-25 Simon Fraser <simon.fraser@apple.com>
4085 [iOS WK2] Add viewport tests and fix runUIScript() timing issues
4086 https://bugs.webkit.org/show_bug.cgi?id=149577
4088 Reviewed by Tim Horton.
4090 When calling testRunner.runUIScript() from a page load event, the script could run
4091 in the UI process before the current remote layer tree transaction had been handled
4092 there. This meant that runUIScript() could query state which was about to change.
4094 Fix by delaying the execution of the UI script until a layer tree transaction has
4095 been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
4097 * WebKitTestRunner/TestInvocation.cpp:
4098 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4099 (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
4100 * WebKitTestRunner/TestInvocation.h:
4102 2015-09-25 Alexey Proskuryakov <ap@apple.com>
4104 [Mac] Media tests start to time out after a few days of bot uptime
4105 https://bugs.webkit.org/show_bug.cgi?id=149468
4107 Reviewed by Darin Adler.
4109 Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
4110 as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
4111 all temporary and cache files go to a custom location.
4113 * Scripts/webkitpy/port/base.py:
4114 * Scripts/webkitpy/port/driver.py:
4115 * Scripts/webkitpy/port/mac.py:
4116 * Scripts/webkitpy/port/win.py:
4117 (WinPort._driver_tempdir_for_environment): Deleted unused function.
4119 2015-09-25 Dan Bernstein <mitz@apple.com>
4121 Removed MiniBrowser.entitlements.
4123 Rubber-stamped by Anders Carlsson.
4125 The entitlements weren’t used anyway.
4127 * MiniBrowser/MiniBrowser.entitlements: Removed.
4128 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4130 2015-09-24 Daniel Bates <dabates@apple.com>
4132 Add WebKitSystemInterface for iOS 9.0
4133 https://bugs.webkit.org/show_bug.cgi?id=149550
4135 Rubber-stamped by Alexey Proskuryakov.
4137 * Scripts/copy-webkitlibraries-to-product-directory:
4139 2015-09-24 Daniel Bates <dabates@apple.com>
4141 Support building for arbitrary architectures
4142 https://bugs.webkit.org/show_bug.cgi?id=149539
4144 Reviewed by Alexey Proskuryakov.
4146 Teach buildbot to pass the architectures associated with the builder to build-webkit
4147 when building on OS X and iOS. As a side effect of this change we now support building
4148 universal binaries when multiples architectures are specified.
4150 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4151 (CompileWebKit.start):
4153 2015-09-24 Daniel Bates <dabates@apple.com>
4155 Fix the build after <http://trac.webkit.org/changeset/190212>
4156 (http://trac.webkit.org/changeset/190212)
4158 I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
4160 * BuildSlaveSupport/built-product-archive:
4163 2015-09-24 Daniel Bates <dabates@apple.com>
4165 Support running unit tests on iOS Simulator test bot
4166 https://bugs.webkit.org/show_bug.cgi?id=149536
4168 Reviewed by Alexey Proskuryakov.
4170 Implements support for running unit tests on a iOS test bot. At the time of writing,
4171 the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
4173 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4174 (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
4175 (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
4177 2015-09-24 Daniel Bates <dabates@apple.com>
4179 Add support infrastructure for OpenSource iOS builders and testers
4180 https://bugs.webkit.org/show_bug.cgi?id=149534
4182 Reviewed by Darin Adler.
4184 Towards setting up OpenSource iOS build bots, teach buildbot and its support
4187 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4188 (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
4189 --ios-simulator or --device for a builder/tester whose full platform name begins with
4190 "ios-simulator" or "ios", respectively.
4191 (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
4192 * BuildSlaveSupport/built-product-archive:
4193 (main): Pass the full platform name to determineWebKitBuildDirectory().
4194 (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
4195 command line flag when building for iOS.
4196 (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
4197 parameter fullPlatform. This parameter was originally added in r125066 to support the
4198 Chromium Android port, which has since been removed from the OpenSource WebKit Project.
4199 (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
4200 * BuildSlaveSupport/clean-build:
4201 (main): Call script webkit-build-directory with the appropriate command line flag when
4203 * BuildSlaveSupport/delete-stale-build-files:
4204 (main): Use the same logic for iOS as we do for Mac.
4205 (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
4206 flag when building for iOS.
4207 * BuildSlaveSupport/test-result-archive:
4208 (archiveTestResults): Use the same logic for iOS as we do for Mac.
4210 2015-09-24 Daniel Bates <dabates@apple.com>
4212 Remove Chromium-specific changes to script built-product-archive
4213 https://bugs.webkit.org/show_bug.cgi?id=149530
4215 Rubber-stamped by Csaba Osztrogonác.
4217 Reverts changes made in r113074 and r113067 to support Chromium testers. The
4218 Chromium code has long since been removed from the OpenSource WebKit Project.
4220 * BuildSlaveSupport/built-product-archive:
4221 (createZipManually):
4223 (archiveBuiltProduct):
4225 2015-09-24 Dan Bernstein <mitz@apple.com>
4229 * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
4231 2015-09-24 Mark Lam <mark.lam@apple.com>
4233 Unreviewed. Make Lucas Forschler a WebKit reviewer.
4235 * Scripts/webkitpy/common/config/contributors.json:
4237 2015-09-24 Carlos Garcia Campos <cgarcia@igalia.com>
4239 Unreviewed. Fix GObject DOM API breaks after r190120.
4241 Bring back code removed in r169931 to handle documentation of
4245 (WebKitDOMDocGenerator):
4246 (WebKitDOMDocGenerator.write_deleted_classes):
4247 (WebKitDOMDocGenerator.generate):
4248 (write_deleted_classes):
4249 (WebKitDOMDocGeneratorSections._deleted_class):
4250 (WebKitDOMDocGeneratorSections._deleted_class.in):
4251 (WebKitDOMDocGeneratorSections.write_deleted_classes):
4252 (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
4254 2015-09-23 Myles C. Maxfield <mmaxfield@apple.com>
4256 [Cocoa] [Font Features] Implement font-variant-*
4257 https://bugs.webkit.org/show_bug.cgi?id=148413
4259 Reviewed by Darin Adler.
4261 Update test font to use "lnum" feature.
4263 * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
4264 (Generator::appendGSUBTable):
4266 2015-09-22 Andy Estes <aestes@apple.com>
4268 ContentFiltering.AllowDownloadAfterAddData is very flaky
4269 https://bugs.webkit.org/show_bug.cgi?id=148885
4270 <rdar://problem/22729563>
4272 Reviewed by Alexey Proskuryakov.
4274 The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
4275 but there is no guarantee of this. For tests that should allow a download, spin the runloop until
4276 -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
4278 * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
4281 2015-09-22 Alexey Proskuryakov <ap@apple.com>
4283 Mavericks: Media tests start to time&nb