Myles C. Maxfield is a committer now
[WebKit-https.git] / Tools / ChangeLog
1 2013-12-20  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         Myles C. Maxfield is a committer now
4
5         Unreviewed.
6
7         * Scripts/webkitpy/common/config/contributors.json:
8
9 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
10
11         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
12         https://bugs.webkit.org/show_bug.cgi?id=125854
13
14         Reviewed by Chris Fleizach.
15
16         Ensure we don't ever create instances of AccessibilityUIElement
17         wrapping invalid platform-specific accessibility objects in DRT,
18         both for consistency with what WKTR does (so we avoid situations
19         where some tests fail in WK2 and not in WK1) and also to avoid
20         overlooking tests that might not be checking the right thing.
21
22         * DumpRenderTree/AccessibilityUIElement.cpp:
23         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
24         nullPtr if the platformUIElement() is not a valid one.
25         * DumpRenderTree/AccessibilityUIElement.h:
26         (AccessibilityUIElement::platformUIElement): Added const modifier.
27
28 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
29
30         Programmatically-inserted children lack accessibility events
31         https://bugs.webkit.org/show_bug.cgi?id=100275
32
33         Reviewed by Chris Fleizach.
34
35         Update DRT and WebKitTestRunner to handle the children-changed
36         signal properly, considering the detail and optional parameters.
37
38         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
39         (axObjectEventListener):
40         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
41
42 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
43
44         Removed unused BUILDER_BASE_URL.
45         https://bugs.webkit.org/show_bug.cgi?id=125442
46
47         Reviewed by Csaba Osztrogonác.
48
49         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
50         (JSONGeneratorTest._test_json_generation): Trivial test fix after r160900.
51
52 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
53
54         Removed unused BUILDER_BASE_URL.
55         https://bugs.webkit.org/show_bug.cgi?id=125442
56
57         Reviewed by Csaba Osztrogonác.
58
59         The string constant BUILDER_BASE_URL is passed around several times,
60         but we don't use it anywhere. It is a leftover from Chromium, cleaned it up.
61
62         * Scripts/webkitpy/layout_tests/controllers/manager.py:
63         (Manager._upload_json_files):
64         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
65         (JSONLayoutResultsGenerator.__init__):
66         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
67         (JSONResultsGenerator.__init__):
68
69 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
70
71         check-webkit-style mistakenly flags assigning to a dereferenced pointer
72         https://bugs.webkit.org/show_bug.cgi?id=126041
73
74         Reviewed by Ryosuke Niwa.
75
76         When checking for lines like "Foo *bar;", check-webkit-style doesn't make
77         sure that there is a declaration. This patch makes sure that there is a
78         declaration in order to flag spacing around asterisks.
79
80         * Scripts/webkitpy/style/checkers/cpp.py:
81         (check_spacing):
82         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
83         (CppStyleTest.test_pointer_reference_marker_location):
84
85 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
86
87         check-webkit-style marks rvalue references as violations
88         https://bugs.webkit.org/show_bug.cgi?id=126000
89
90         Reviewed by Ryosuke Niwa.
91
92         Previously, check-webkit-style was making sure that any line with "&&" had
93         spaces around it. However, we can now legitimately use "&&" without a previous
94         space when declaring an rvalue reference. This patch relaxes this check.
95
96         * Scripts/webkitpy/style/checkers/cpp.py:
97         (check_spacing):
98         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
99         (CppStyleTest.test_spacing_for_binary_ops):
100
101 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
102
103         check-webkit-style marks auto return types for functions as violations
104         https://bugs.webkit.org/show_bug.cgi?id=125999
105
106         Reviewed by Ryosuke Niwa.
107
108         If a function declaration ends with a "->" followed by a non whitespace
109         string, don't mark as an invalid "{" on its own line
110
111         * Scripts/webkitpy/style/checkers/cpp.py:
112         (check_braces):
113         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
114         (CppStyleTest.test_brace_at_begin_of_line):
115
116 2013-12-19  Alex Christensen  <achristensen@webkit.org>
117
118         [WinCairo] More GStreamer preparations.
119
120         Unreviewed.
121
122         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props:
123         Include FeatureDefinesCairo and WinCairo to compile the GLib part of WinLauncher.
124
125 2013-12-19  Lucas Forschler  <lforschler@apple.com>
126
127         Add Apple Mavericks perf bot.
128         
129         Unreviewed.
130
131         * BuildSlaveSupport/build.webkit.org-config/config.json:
132
133 2013-12-19  Commit Queue  <commit-queue@webkit.org>
134
135         Unreviewed, rolling out r160842.
136         http://trac.webkit.org/changeset/160842
137         https://bugs.webkit.org/show_bug.cgi?id=126003
138
139         broke accessibility/loading-iframe-updates-axtree.html
140         (Requested by ap on #webkit).
141
142         * DumpRenderTree/AccessibilityUIElement.cpp:
143         (AccessibilityUIElement::makeJSAccessibilityUIElement):
144         * DumpRenderTree/AccessibilityUIElement.h:
145         (AccessibilityUIElement::platformUIElement):
146
147 2013-12-19  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
148
149         get_test_baseline should get Host from test_config
150         https://bugs.webkit.org/show_bug.cgi?id=125989
151
152         Reviewed by Ryosuke Niwa.
153
154         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
155         (TestConfig.__init__):
156         (RebaselineServer._prepare_config):
157         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
158         (get_test_baselines):
159         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
160         (get_test_config):
161
162 2013-12-19  Roger Fong  <roger_fong@apple.com>
163
164         Don't check VSINSTALLDIR when looking for Visual Studio install directory.
165         https://bugs.webkit.org/show_bug.cgi?id=125998.
166
167         Reviewed by Alexey Proskuryakov.
168
169         * Scripts/webkitdirs.pm:
170         (visualStudioInstallDir):
171         Get rid of the VSINSTALLDIR check. We can't build on anything besides VS2013 now anyways.
172
173 2013-12-19  Mario Sanchez Prada  <mario.prada@samsung.com>
174
175         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
176         https://bugs.webkit.org/show_bug.cgi?id=125854
177
178         Reviewed by Chris Fleizach.
179
180         Ensure we don't ever create instances of AccessibilityUIElement
181         wrapping invalid platform-specific accessibility objects in DRT,
182         both for consistency with what WKTR does (so we avoid situations
183         where some tests fail in WK2 and not in WK1) and also to avoid
184         overlooking tests that might not be checking the right thing.
185
186         * DumpRenderTree/AccessibilityUIElement.cpp:
187         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
188         nullPtr if the platformUIElement() is not a valid one.
189         * DumpRenderTree/AccessibilityUIElement.h:
190         (AccessibilityUIElement::platformUIElement): Added const modifier.
191
192 2013-12-18  Anders Carlsson  <andersca@apple.com>
193
194         Deprecate some WKMutableDictionary functions
195         https://bugs.webkit.org/show_bug.cgi?id=125962
196
197         Reviewed by Tim Horton.
198
199         * TestWebKitAPI/PlatformUtilities.cpp:
200         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
201         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
202         (TestWebKitAPI::didAssociateFormControls):
203         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
204         (TestWebKitAPI::WillLoadTest::willLoadURLRequest):
205         (TestWebKitAPI::WillLoadTest::willLoadDataRequest):
206         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
207         (WTR::createMouseMessageBody):
208         (WTR::EventSendingController::mouseMoveTo):
209         (WTR::EventSendingController::leapForward):
210         (WTR::createKeyDownMessageBody):
211         (WTR::EventSendingController::mouseScrollBy):
212         (WTR::EventSendingController::continuousMouseScrollBy):
213         (WTR::EventSendingController::addTouchPoint):
214         (WTR::EventSendingController::updateTouchPoint):
215         (WTR::EventSendingController::setTouchModifier):
216         (WTR::EventSendingController::setTouchPointRadius):
217         (WTR::EventSendingController::touchStart):
218         (WTR::EventSendingController::touchMove):
219         (WTR::EventSendingController::touchEnd):
220         (WTR::EventSendingController::touchCancel):
221         (WTR::EventSendingController::clearTouchPoints):
222         (WTR::EventSendingController::releaseTouchPoint):
223         (WTR::EventSendingController::cancelTouchPoint):
224         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
225         (WTR::InjectedBundle::done):
226         (WTR::InjectedBundle::setMockGeolocationPosition):
227         (WTR::InjectedBundle::setCustomPolicyDelegate):
228         (WTR::InjectedBundle::setVisibilityState):
229         (WTR::InjectedBundle::queueLoad):
230         (WTR::InjectedBundle::queueLoadHTMLString):
231         * WebKitTestRunner/TestController.cpp:
232         (WTR::TestController::initialize):
233         (WTR::TestController::resetStateToConsistentValues):
234         * WebKitTestRunner/TestInvocation.cpp:
235         (WTR::updateThreadedScrollingForCurrentTest):
236         (WTR::updateLayoutType):
237         (WTR::TestInvocation::invoke):
238
239 2013-12-18  Martin Robinson  <mrobinson@igalia.com>
240
241         [GTK] [CMake] Add support for building GtkLauncher
242         https://bugs.webkit.org/show_bug.cgi?id=125766
243
244         Reviewed by Gustavo Noronha Silva.
245
246         * CMakeLists.txt: Add the GtkLauncher subdirectory for the GTK port.
247         * GtkLauncher/CMakeLists.txt: Added.
248         * GtkLauncher/main.c: Support including the CMake config file.
249
250 2013-12-18  Alex Christensen  <achristensen@webkit.org>
251
252         [WinCairo] Preparation for GStreamer on Windows.
253         https://bugs.webkit.org/show_bug.cgi?id=125946
254
255         Reviewed by Brent Fulgham.
256
257         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
258         Use new GStreamer property sheets for WinCairo.
259         * win/DLLLauncher/DLLLauncherMain.cpp:
260         (modifyPath):
261         (wWinMain):
262         Prepend GStreamer bin directory to path if it exists.
263
264 2013-12-18  Anders Carlsson  <andersca@apple.com>
265
266         Remove now useless test.
267
268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
269         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Removed.
270         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Removed.
271         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Removed.
272
273 2013-12-18  Gavin Barraclough  <barraclough@apple.com>
274
275         Fix page visibility api test, initialization in WebKit2
276         https://bugs.webkit.org/show_bug.cgi?id=125933
277
278         Reviewed by Anders Carlsson.
279
280         The API test for page visibility is broken, fix this. This revealed a recent regression in WebKit2
281         (introduced in https://bugs.webkit.org/show_bug.cgi?id=123379), caused by a typo removing a '!'.
282
283         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
284         (TestWebKitAPI::TEST_F):
285             - Running a test on WebKit1 twice is not the same as running it on WebKit2!
286
287 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
288
289         Should not have identifiers with underscores in them, especially not leading underscores.
290         https://bugs.webkit.org/show_bug.cgi?id=125847
291
292         Reviewed by Darin Adler.
293
294         * Scripts/webkitpy/style/checkers/cpp.py:
295         (check_identifier_name_in_declaration):
296         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
297         (CppStyleTest.test_runtime_selfinit):
298         (WebKitStyleTest.test_names):
299
300 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
301
302         False webkit-check-style warnings on *.
303         https://bugs.webkit.org/show_bug.cgi?id=125915
304
305         Reviewed by Darin Adler.
306
307         * Scripts/webkitpy/style/checkers/cpp.py:
308         (check_spacing):
309         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
310         (CppStyleTest.test_pointer_reference_marker_location):
311
312 2013-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
313
314         prepare-ChangeLog doesn't handle templates properly
315         https://bugs.webkit.org/show_bug.cgi?id=125853
316
317         Reviewed by Daniel Bates.
318
319         * Scripts/prepare-ChangeLog:
320         (get_function_line_ranges_for_cpp):
321         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
322         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
323         (Class110<TemplateClass>::func36):
324
325 2013-12-18  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
326
327         Move expectation parsing out of the constructor of TestExpectations
328         https://bugs.webkit.org/show_bug.cgi?id=125439
329
330         Reviewed by Csaba Osztrogonác.
331
332         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
333         (LayoutTestRunnerTests._run_tests):
334         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
335         (LayoutTestRunnerTests.test_update_summary_with_result):
336         * Scripts/webkitpy/layout_tests/controllers/manager.py:
337         (Manager.run):
338         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
339         (ManagerTest.test_look_for_new_crash_logs):
340         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
341         (lint):
342         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
343         (TestExpectations.suffixes_for_expectations):
344         (TestExpectations.__init__):
345         (TestExpectations):
346         (TestExpectations.parse_generic_expectations):
347         (TestExpectations.parse_default_port_expectations):
348         (TestExpectations.parse_override_expectations):
349         (TestExpectations.parse_all_expectations):
350         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
351         (parse_exp):
352         (SkippedTests.check):
353         (SkippedTests.test_skipped_entry_dont_exist):
354         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
355         (run_results):
356         * Scripts/webkitpy/tool/commands/queries.py:
357         (PrintExpectations._model):
358         * Scripts/webkitpy/tool/commands/rebaseline.py:
359         (RebaselineTest._update_expectations_file):
360         (RebaselineExpectations._update_expectations_files):
361         (RebaselineExpectations._tests_to_rebaseline):
362
363 2013-12-17  Jer Noble  <jer.noble@apple.com>
364
365         Fix TimeRanges::intersectWith
366         https://bugs.webkit.org/show_bug.cgi?id=118802
367
368         Reviewed by Eric Carlson.
369
370         Add unit tests for WebCore/TimeRanges.
371
372         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
373         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: Added.
374         (TestWebKitAPI::ToString):
375         (TestWebKitAPI::TEST):
376
377 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
378
379         Botwatcher's dashboard ceases to update itself after a while
380         https://bugs.webkit.org/show_bug.cgi?id=125885
381
382         Reviewed by Timothy Hatcher.
383
384         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
385         Removed code that checked for the view being hidden. It's none of model's business.
386
387         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
388         (BuildbotQueueView): Find out what platform the view is for. Initlialize update timer.
389         (BuildbotQueueView.prototype._updateHiddenState): Start or stop update timer as appropriate.
390         We now stop the timer for hidden views.
391         (BuildbotQueueView.prototype._updateQueues): Removed the logic for ignoring some updates.
392
393 2013-12-17  Anders Carlsson  <andersca@apple.com>
394
395         Fix the 32-bit build.
396
397         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
398         * MiniBrowser/MiniBrowserWebProcessPlugIn.m:
399
400 2013-12-17  Anders Carlsson  <andersca@apple.com>
401
402         Give the MiniBrowser a bundle
403         https://bugs.webkit.org/show_bug.cgi?id=125882
404
405         Reviewed by Sam Weinig.
406
407         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Added.
408         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
409         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Added.
410         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Added.
411         (-[MiniBrowserWebProcessPlugIn webProcessPlugIn:initializeWithObject:]):
412         * MiniBrowser/mac/AppDelegate.m:
413         (-[BrowserAppDelegate init]):
414         * MiniBrowser/mac/Bundle/Info.plist: Added.
415         * MiniBrowser/mac/Bundle/MiniBrowserBundle_Prefix.pch: Added.
416
417 2013-12-17  Gavin Barraclough  <barraclough@apple.com>
418
419         Remove PageVisibilityStateUnloaded
420         https://bugs.webkit.org/show_bug.cgi?id=125869
421
422         Reviewed by Anders Carlsson.
423
424         This is not currently supported by WebKit, remove this enum value.
425         We can always add this back later if/when we add support for this state.
426
427         * DumpRenderTree/mac/TestRunnerMac.mm:
428         (TestRunner::setPageVisibility):
429         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
430         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
431         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
432         (WTR::TestRunner::setPageVisibility):
433             - remove test for visibility state "unloaded"; this is no longer supported (it never really was).
434
435 2013-12-12  Martin Robinson  <mrobinson@igalia.com>
436
437         [GTK] [CMake] Build the plugin process against GTK+ 2
438         https://bugs.webkit.org/show_bug.cgi?id=116374
439
440         Reviewed by Gustavo Noronha Silva.
441
442         * TestWebKitAPI/PlatformGTK.cmake: Add WebCorePlatformGTK to the list of
443         libraries required for WebCore unit tests.
444
445 2013-12-17  Brent Fulgham  <bfulgham@apple.com>
446
447         [Win] Revise filter-build-webkit to deal with Windows build logs
448         https://bugs.webkit.org/show_bug.cgi?id=125866
449
450         Reviewed by David Kilzer.
451
452         Enhance the script to accept a 'platform' argument. When platform
453         'win' is provided, use processing for the Windows build file format.
454         Otherwise, process the files as normal.
455
456         * Scripts/filter-build-webkit:
457         (usageAndExit): Add a 'platform' argument
458         (shouldIgnoreLine): When platform == 'win' use the new Windows
459         rules for processing the build file.
460
461 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
462
463         Update style checker now that ENUM_CLASS is gone
464         https://bugs.webkit.org/show_bug.cgi?id=125864
465
466         Reviewed by Anders Carlsson.
467
468         * Scripts/webkitpy/style/checkers/cpp.py:
469         (_EnumState.process_clean_line):
470         (check_braces):
471         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
472         (NoNonVirtualDestructorsTest.test_enum_casing.Foo):
473         (NoNonVirtualDestructorsTest.test_enum_casing):
474         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123):
475         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass):
476         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum):
477         (WebKitStyleTest.test_braces.CPP11EnumClass):
478
479 2013-12-17  Mario Sanchez Prada  <mario.prada@samsung.com>
480
481         [ATK] Expose accessibility objects for <dl>, <dt> and <dd>
482         https://bugs.webkit.org/show_bug.cgi?id=125857
483
484         Reviewed by Chris Fleizach.
485
486         Add mappings to DRT & WKTR for the newly exposed roles, and
487         increase the version of ATK used by the internal jhbuild.
488
489         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
490         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
491         * gtk/jhbuild.modules: Raise version of ATK up to 2.11.4.
492
493 2013-12-17  Alex Christensen  <achristensen@webkit.org>
494
495         [WinCairo] Adding support for GStreamer and GLib.
496         https://bugs.webkit.org/show_bug.cgi?id=124867
497
498         Reviewed by Philippe Normand.
499
500         * WinLauncher/WinLauncher.cpp:
501         (wWinMain):
502         Added g_main_context_iteration in main event loop.
503
504 2013-12-17  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
505
506         Fix for C++ should have the & or * beside the type not the variable name check.
507         https://bugs.webkit.org/show_bug.cgi?id=125846
508
509         Reviewed by Darin Adler.
510
511         * Scripts/webkitpy/style/checkers/cpp.py:
512         (check_spacing):
513         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
514         (CppStyleTest.test_pointer_reference_marker_location):
515
516 2013-12-16  Rob Buis  <rob.buis@samsung.com>
517
518         Add my Samsung email address.
519
520         Unreviewed.
521
522         * Scripts/webkitpy/common/config/contributors.json:
523
524 2013-12-16  Oliver Hunt  <oliver@apple.com>
525
526         Cache getters and custom accessors on the prototype chain
527         https://bugs.webkit.org/show_bug.cgi?id=125602
528
529         Reviewed by Michael Saboff.
530
531         Make sure bencher scripts also make noInline exist
532
533         * Scripts/bencher:
534
535 2013-12-16  Anders Carlsson  <andersca@apple.com>
536
537         Fix crash when trying to load a null HTML string
538         https://bugs.webkit.org/show_bug.cgi?id=125801
539
540         Reviewed by Dan Bernstein.
541
542         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
543         (TestWebKitAPI::TEST_F):
544         Update test results.
545
546 2013-12-16  Alex Christensen  <achristensen@webkit.org>
547
548         Fixed Win64 build on VS2013.
549         https://bugs.webkit.org/show_bug.cgi?id=125753
550
551         Reviewed by Brent Fulgham.
552
553         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
554         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
555         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
556         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
557         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
558         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
559         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
560         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
561         * win/record-memory/record-memory.vcxproj:
562         Added correct PlatformToolset for 64-bit builds.
563
564 2013-12-16  Simon Fraser  <simon.fraser@apple.com>
565
566         Add a menu option to MiniBrowser to enable UI-side compositing
567         https://bugs.webkit.org/show_bug.cgi?id=125793
568
569         Reviewed by Anders Carlsson.
570         
571         Make it possible to test UI-side compositing in MiniBrowser WK2 windows.
572
573         * MiniBrowser/mac/BrowserWindowController.h: Add optional protocol method
574         to toggle UI-side compositing.
575         * MiniBrowser/mac/MainMenu.xib: Add menu item to Debug menu.
576         * MiniBrowser/mac/WK2BrowserWindowController.m:
577         (-[WK2BrowserWindowController validateMenuItem:]):
578         (-[WK2BrowserWindowController isUISideCompositingEnabled]):
579         (-[WK2BrowserWindowController toggleUISideCompositing:]):
580         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
581         Adjust the window title to indicate whether the window is using UI-side compositing.
582
583 2013-12-16  Commit Queue  <commit-queue@webkit.org>
584
585         Unreviewed, rolling out r160645.
586         http://trac.webkit.org/changeset/160645
587         https://bugs.webkit.org/show_bug.cgi?id=125787
588
589         Change breaks test-webkitpy (Requested by bfulgham on
590         #webkit).
591
592         * Scripts/prepare-ChangeLog:
593         (get_selector_line_ranges_for_css):
594
595 2013-12-16  David Farler  <dfarler@apple.com>
596
597         [ASAN] WebKitLauncher: Include libasancrashreporter.dylib in DYLD_INSERT_LIBRARIES if it exists
598         https://bugs.webkit.org/show_bug.cgi?id=124610
599
600         Reviewed by Mark Rowe.
601
602         * WebKitLauncher/WebKitNightlyEnabler.m:
603         (enableWebKitNightlyBehaviour):
604         Add libasancrashreporter.dylib to DYLD_INSERT_LIBRARIES.
605         * WebKitLauncher/main.m:
606         (main):
607         Include both libasancrashreporter and the nightly enabler to
608         the list of libraries to insert.
609
610 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
611
612         Resolve inconsistant style warning caused by r160319.
613         https://bugs.webkit.org/show_bug.cgi?id=125772
614
615         Reviewed by Darin Adler.
616
617         * Scripts/webkitpy/style/checkers/cpp.py:
618         (check_for_extra_new_line_at_eof):
619         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
620         (CppStyleTest.test_newline_at_eof):
621         (CppStyleTest.test_extra_newlines_at_eof):
622
623 2013-12-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
624
625         Remove mock_drt.py: parse_options() - --test-shell and --pixel-tests=<path>
626         https://bugs.webkit.org/show_bug.cgi?id=125780
627
628         Reviewed by Darin Adler.
629
630         * Scripts/webkitpy/port/mock_drt.py:
631         (main):
632         (parse_options):
633         (MockDRT.write_test_output):
634         * Scripts/webkitpy/port/mock_drt_unittest.py:
635         (MockDRTTest.assertTest):
636         (MockDRTTest.test_reftest_mismatch):
637
638 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
639
640         prepare-Changelog treats CSS keyframes as mismatched parentheses.
641         https://bugs.webkit.org/show_bug.cgi?id=125435
642
643         Reviewed by Darin Adler.
644
645         * Scripts/prepare-ChangeLog:
646         (get_selector_line_ranges_for_css):
647
648 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
649
650         [ATK] Expose accessibility objects for more WAI-ARIA roles
651         https://bugs.webkit.org/show_bug.cgi?id=125596
652
653         Reviewed by Chris Fleizach.
654
655         Add mappings to DRT & WKTR for the newly exposed roles.
656
657         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
658         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
659
660 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
661
662         [ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM
663         https://bugs.webkit.org/show_bug.cgi?id=125594
664
665         Reviewed by Chris Fleizach.
666
667         Add mappings to DRT & WKTR for checkmenuitem role.
668
669         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
670         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
671
672 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
673
674         [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
675         https://bugs.webkit.org/show_bug.cgi?id=125587
676
677         Reviewed by Chris Fleizach.
678
679         Add mappings to DRT & WKTR for article roles.
680
681         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
682         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
683
684 2013-12-16  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
685
686         [FTL] Allow EFL to build FTL with the build-jsc script.
687         https://bugs.webkit.org/show_bug.cgi?id=125774
688
689         Reviewed by Zoltan Herczeg.
690
691         * Scripts/build-jsc:
692
693 2013-12-16  Krzysztof Czech  <k.czech@samsung.com>
694
695         Add myself as a committer
696
697         Unreviewed.
698
699         * Scripts/webkitpy/common/config/contributors.json:
700
701 2013-12-15  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
702
703         Refactor option handling in WebKitTestRunner.
704         https://bugs.webkit.org/show_bug.cgi?id=123185
705
706         Reviewed by Darin Adler.
707
708         Option handling is refactored (according to the FIXME) that allows
709         to automatically generate the help message.
710
711         * WebKitTestRunner/CMakeLists.txt:
712         * WebKitTestRunner/GNUmakefile.am:
713         * WebKitTestRunner/Options.cpp: Added.
714         (WTR::Options::Options):
715         (WTR::handleOptionTimeout):
716         (WTR::handleOptionNoTimeout):
717         (WTR::handleOptionNoTimeoutAtAll):
718         (WTR::handleOptionVerbose):
719         (WTR::handleOptionGcBetweenTests):
720         (WTR::handleOptionPixelTests):
721         (WTR::handleOptionPrintSupportedFeatures):
722         (WTR::handleOptionComplexText):
723         (WTR::handleOptionAcceleratedDrawing):
724         (WTR::handleOptionRemoteLayerTree):
725         (WTR::handleOptionUnmatched):
726         (WTR::OptionsHandler::OptionsHandler):
727         (WTR::Option::Option):
728         (WTR::Option::matches):
729         (WTR::OptionsHandler::parse):
730         (WTR::OptionsHandler::printHelp):
731         * WebKitTestRunner/Options.h: Added.
732         * WebKitTestRunner/TestController.cpp:
733         (WTR::TestController::initialize):
734         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
735
736 2013-12-15  Dan Bernstein  <mitz@apple.com>
737
738         32-bit build fix.
739
740         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
741         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
742
743 2013-12-14  Tim Horton  <timothy_horton@apple.com>
744
745         stylebot should warn when FeatureDefines differ
746         https://bugs.webkit.org/show_bug.cgi?id=125748
747
748         Reviewed by Dan Bernstein.
749
750         Add a stylebot checker that ensures that FeatureDefines.xcconfig files
751         are always exactly equal (and warns people adding new FeatureDefines.xcconfig files,
752         an unlikely occurrance, to add them to the list).
753
754         It's a bit nontraditional for stylebot because it will warn on existing errors in the tree,
755         but that is the most straightforward way to implement it (and we're at zero diffs right now).
756
757         * Scripts/webkitpy/style/checker.py:
758         (_all_categories):
759         (FileType):
760         (CheckerDispatcher._file_type):
761         (CheckerDispatcher._create_checker):
762         * Scripts/webkitpy/style/checkers/featuredefines.py: Added.
763         (FeatureDefinesChecker):
764         (FeatureDefinesChecker.__init__):
765         (FeatureDefinesChecker.check):
766
767 2013-12-13  Sam Weinig  <sam@webkit.org>
768
769         Fix API tests.
770
771         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
772         (TestWebKitAPI::TEST_F):
773
774 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
775
776         [Win] Remove Pre-VS2013 support code.
777         https://bugs.webkit.org/show_bug.cgi?id=125693
778
779         Reviewed by Darin Adler.
780
781         * DumpRenderTree/cg/ImageDiffCG.cpp: Remove strtof stub now supplied by
782         the math library.
783         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
784
785 2013-12-13  Lucas Forschler  <lforschler@apple.com>
786
787         Update Webkit bots.
788         
789         Unreviewed.
790         
791         * BuildSlaveSupport/build.webkit.org-config/config.json:
792
793 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
794
795         [Win] Unreviewed build fix after r160548
796
797         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Specify
798         we are using vs12_xp target for Makefile-based projects.
799
800 2013-12-13  Lucas Forschler  <lforschler@apple.com>
801
802         Update Apple Webkit Bots
803         
804         Unreviewed.
805
806         * BuildSlaveSupport/build.webkit.org-config/config.json:
807
808 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
809
810         Unreviewed build fix after r160548.
811
812         * Scripts/webkitdirs.pm:
813         (setupCygwinEnv): VCExpress.exe is now called WDExpress.exe.
814
815 2013-12-13  Lucas Forschler  <lforschler@apple.com>
816
817         Update Apple bots.
818         
819         Unreviewed.
820
821         * BuildSlaveSupport/build.webkit.org-config/config.json:
822
823 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
824
825         [Win] Switch WebKit solution to Visual Studio 2013
826         https://bugs.webkit.org/show_bug.cgi?id=125192
827
828         Reviewed by Anders Carlsson.
829
830         Project files must reference vs12_xp for 32-bit builds. 
831
832         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
833         Update for VS2013
834         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
835         Ditto
836         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
837         Ditto
838         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
839         Ditto
840         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
841         Ditto
842         * Scripts/webkitdirs.pm:
843         (visualStudioInstallDir): Specify VS2013
844         (visualStudioVersion): Ditto.
845         (setupAppleWinEnv): Use VS2013 in messages
846         (setupCygwinEnv): Ditto
847         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
848         Update for VS2013
849         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
850         Ditto
851         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
852         Ditto
853         * win/record-memory/record-memory.vcxproj:
854         Ditto
855
856 2013-12-11  Martin Robinson  <mrobinson@igalia.com> and Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
857
858         Adding a .ycm_extra_conf file for webkitGtk
859         https://bugs.webkit.org/show_bug.cgi?id=119618
860
861         Reviewed by Gustavo Noronha Silva.
862
863         Added a YouCompleteMe flag discovery script for Vim and the GTK+ port. The script
864         read the GTK+ build files to determine dynamically what flags to compile a source
865         file with. This allows Vim to provide auto-complete for C++/C language. See
866         https://github.com/Valloric/YouCompleteMe for how to use this file.
867
868         * gtk/common.py:
869         (get_build_path): Added a fatal argument to build_path to avoid crashing YCM on failure.
870         * gtk/ycm_extra_conf.py: Added.
871
872 2013-12-12  Tim Horton  <timothy_horton@apple.com>
873
874         [wk2] Handle pinch-to-zoom gesture
875         https://bugs.webkit.org/show_bug.cgi?id=125604
876
877         Reviewed by Simon Fraser.
878
879         * MiniBrowser/mac/WK2BrowserWindowController.m:
880         (-[WK2BrowserWindowController awakeFromNib]):
881         Enable handling of the magnification gesture in Minibrowser WebKit2 windows.
882
883 2013-12-12  Eunmi Lee  <eunmi15.lee@samsung.com>
884
885         Unreviewed. Add myself as a committer.
886
887         * Scripts/webkitpy/common/config/contributors.json:
888
889 2013-12-12  Lucas Forschler  <lforschler@apple.com>
890
891         Update hardware for Apple bots.
892         
893         Unreviewed.
894
895         * BuildSlaveSupport/build.webkit.org-config/config.json:
896
897 2013-12-12  Lucas Forschler  <lforschler@apple.com>
898
899         Remove unused Apple Bots.
900         
901         Unreviewed.
902
903         * BuildSlaveSupport/build.webkit.org-config/config.json:
904
905 2013-12-12  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
906
907         Unreviewed. Add myself as a committer.
908
909         * Scripts/webkitpy/common/config/contributors.json:
910
911 2013-12-12  Joseph Pecoraro  <pecoraro@apple.com>
912
913         Test new JSContext name APIs
914         https://bugs.webkit.org/show_bug.cgi?id=125607
915
916         Reviewed by Darin Adler.
917
918         * Scripts/run-javascriptcore-tests:
919         Remove trailing whitespace.
920
921 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
922
923         [Autotools] Prepend the WebCore layer archives' names with 'lib'
924         https://bugs.webkit.org/show_bug.cgi?id=125627
925
926         Reviewed by Martin Robinson.
927
928         * TestWebKitAPI/GNUmakefile.am: Libtool can complain about the WebCore layer archives not being prepended
929         with 'lib' when they are used during linking, so the prefix is now added to avoid such issues.
930
931 2013-12-12  Commit Queue  <commit-queue@webkit.org>
932
933         Unreviewed, rolling out r160446.
934         http://trac.webkit.org/changeset/160446
935         https://bugs.webkit.org/show_bug.cgi?id=125630
936
937         The upower-glib-based implementation is using API that was
938         recently removed (Requested by zdobersek1 on #webkit).
939
940         * Scripts/webkitperl/FeatureList.pm:
941
942 2013-12-12  Commit Queue  <commit-queue@webkit.org>
943
944         Unreviewed, rolling out r160417.
945         http://trac.webkit.org/changeset/160417
946         https://bugs.webkit.org/show_bug.cgi?id=125629
947
948         The patch is causing crashes (Requested by zdobersek1 on
949         #webkit).
950
951         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
952         (axObjectEventListener):
953         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
954
955 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
956
957         Use of ar T option not supported by older binutils
958         https://bugs.webkit.org/show_bug.cgi?id=118732
959
960         Reviewed by Gustavo Noronha Silva.
961
962         * TestWebKitAPI/GNUmakefile.am: To support non-thin archives when generating the WebCoreLayer archive,
963         switch to using the AR_FLAGS variable (which can be overridden) for providing the ar flags for the
964         new archive. Non-thin archives also pose the problem as their members are only noted by the basename
965         of the member's object file, and not the full path to it. To work around that, all the object files
966         under the build directory are listed by their relative paths. The members of various archives then have
967         the basenames of their paths grepped against that list, with the found path correlating to the member
968         finally added as the new member of the WebCoreLayer archive.
969
970 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
971
972         check-webkit-style shouldn't check spacing in #if preprocessor lines
973         https://bugs.webkit.org/show_bug.cgi?id=125534
974
975         Reviewed by Ryosuke Niwa.
976
977         Preprocessor lines that start with #if shouldn't have to adhere to
978         the same spacing requirements that regular code does
979
980         * Scripts/webkitpy/style/checkers/cpp.py:
981         (check_spacing):
982         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
983         (CppStyleTest.test_spacing_for_binary_ops):
984         (WebKitStyleTest.test_line_breaking):
985
986 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
987
988         check-webkit-style can't determine if a comma is part of an initialization list
989         https://bugs.webkit.org/show_bug.cgi?id=125537
990
991         Reviewed by Darin Adler.
992
993         The original check to make sure that initialization list lines start with
994         a comma didn't distinguish between commas that belong to the initialization
995         list and commas that are part of function calls. Because we don't want to
996         match parentheses with regular expressions, we should weaken this check to
997         only check for commas at the end of initialization list lines.
998
999         * Scripts/webkitpy/style/checkers/cpp.py:
1000         (check_member_initialization_list):
1001         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1002         (WebKitStyleTest.test_member_initialization_list):
1003
1004 2013-12-11  Tim Horton  <timothy_horton@apple.com>
1005
1006         Make it possible to compare layout test results between various configurations of WebKit
1007         https://bugs.webkit.org/show_bug.cgi?id=125212
1008         <rdar://problem/15199108>
1009
1010         Reviewed by Darin Adler.
1011
1012         * Scripts/compare-webkit-configurations: Added.
1013         Add a script that allows comparison between the "normal" WebKit configuration
1014         used for testing and a different configuration (e.g. with accelerated drawing
1015         turned on, with the remote layer tree enabled, or WebKit1 vs WebKit2), like so:
1016
1017         compare-webkit-configurations -2 --comparison=accelerated-drawing compositing/background-color
1018
1019         This script runs the tests once in the default configuration, ignoring
1020         all test expectations, writing the results out to a temporary directory.
1021
1022         It then runs the tests again in the modified configuration, against the
1023         just-written temporary results.
1024
1025         Ref tests are treated as pixel tests, with their pixel output dumped to disk.
1026
1027         * DumpRenderTree/mac/DumpRenderTree.mm:
1028         (resetWebPreferencesToConsistentValues):
1029         (initializeGlobalsFromCommandLineOptions):
1030         Enable accelerated drawing if requested.
1031
1032         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1033         (parse_args):
1034         Add --accelerated-drawing and --remote-layer-tree feature switches, which
1035         are forwarded on to the test drivers.
1036         Move those two and --complex-text into their own "feature switches" section.
1037         Drive-by change "Mac OS X" to "OS X".
1038         Add --treat-ref-tests-as-pixel-tests option, which treats ref tests
1039         as traditional pixel tests (with PNGs dumped on disk), and
1040         ignores e.g. -expected.html files.
1041
1042         * Scripts/webkitpy/port/base.py:
1043         (Port.reference_files):
1044         Pretend that there are no ref tests.
1045         Since is_reference_html_file is intact, our mechanism to ignore
1046         the expected files will continue working in this case.
1047
1048         * Scripts/webkitpy/port/driver.py:
1049         (Driver.cmd_line):
1050         Forward --accelerated-drawing and --remote-layer-tree to DRT/WKTR.
1051
1052         * WebKitTestRunner/TestController.cpp:
1053         (WTR::TestController::TestController):
1054         (WTR::TestController::initialize):
1055         (WTR::TestController::resetPreferencesToConsistentValues):
1056         * WebKitTestRunner/TestController.h:
1057         (WTR::TestController::shouldUseRemoteLayerTree):
1058         * WebKitTestRunner/TestInvocation.cpp:
1059         (WTR::updateThreadedScrollingForCurrentTest):
1060         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1061         (WTR::PlatformWebView::PlatformWebView):
1062         Parse and implement the three feature switches.
1063
1064 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
1065
1066         [ATK] Expose accessibility objects WAI-ARIA landmark roles
1067         https://bugs.webkit.org/show_bug.cgi?id=125584
1068
1069         Reviewed by Chris Fleizach.
1070
1071         Add mappings to DRT & WKTR for landmark roles.
1072
1073         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1074         (AccessibilityUIElement::role):
1075         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1076         (WTR::AccessibilityUIElement::role):
1077         * gtk/jhbuild.modules:
1078
1079 2013-12-11  Alejandro G. Castro  <alex@igalia.com>
1080
1081         [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py
1082         https://bugs.webkit.org/show_bug.cgi?id=125441
1083
1084         Reviewed by Martin Robinson.
1085
1086         Just avoid the double quotations when building the parameter
1087         because some versions of valgrind are not handling it correctly.
1088
1089         * Scripts/webkitpy/port/gtk.py:
1090         (GtkPort.setup_environ_for_server):
1091
1092 2013-12-11  Zan Dobersek  <zdobersek@igalia.com>
1093
1094         [GTK] Enable Battery Status API
1095         https://bugs.webkit.org/show_bug.cgi?id=125453
1096
1097         Reviewed by Martin Robinson.
1098
1099         * Scripts/webkitperl/FeatureList.pm: Enable the Battery Status API feature for the GTK port.
1100
1101 2013-12-11  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
1102
1103         [GTK][WK2] Add the WebKitBatteryProvider class
1104         https://bugs.webkit.org/show_bug.cgi?id=115720
1105
1106         Reviewed by Martin Robinson.
1107
1108         * gtk/generate-gtkdoc:
1109         (get_webkit2_options): Ignore the WebKitBatteryProvider source files when generating the documentation.
1110
1111 2013-12-11  Mark Rowe  <mrowe@apple.com>
1112
1113         <https://webkit.org/b/125563> Remove the DumpRenderTree Perl Support module
1114
1115         Now that old-run-webkit-tests is not used on OS X it's not worth the time and effort
1116         to build and maintain this custom Perl module.
1117
1118         Reviewed by Anders Carlsson.
1119
1120         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
1121         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Removed.
1122         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
1123         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
1124         * DumpRenderTree/mac/PerlSupport/Makefile: Removed.
1125         * Scripts/old-run-webkit-tests: Update a comment that referred to DumpRenderTreeSupport as a reason to
1126         build DumpRenderTree.
1127         (dumpToolDidCrash): Stop importing and using the module.
1128         * Scripts/webkitpy/port/base.py:
1129         (Port._build_driver): Update a comment in the same manner as in old-run-webkit-tests.
1130
1131 2013-12-11  Brendan Long  <b.long@cablelabs.com>
1132
1133         [GTK] Add "enable-mediasource" property to WebKitWebSettings
1134         https://bugs.webkit.org/show_bug.cgi?id=125566
1135
1136         Reviewed by Philippe Normand.
1137
1138         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1139         (resetDefaultsToConsistentValues): Turn MediaSource on by default for easier testing.
1140         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1141         (TestRunner::overridePreference): Allow overriding WebKitMediaSourceEnabled.
1142
1143 2013-12-11  Dan Bernstein  <mitz@apple.com>
1144
1145         [Mac] Observe the activeURL property to keep the MiniBrowser URL field up to date
1146         https://bugs.webkit.org/show_bug.cgi?id=125579
1147
1148         Reviewed by Anders Carlsson.
1149
1150         * MiniBrowser/mac/WK2BrowserWindowController.m:
1151         (-[WK2BrowserWindowController dealloc]): Stop observing the activeURL property.
1152         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): When the
1153         activeURL property changes, update the URL field with its value.
1154         (-[WK2BrowserWindowController awakeFromNib]): Start observing the activeURL property.
1155         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]): Just log.
1156         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
1157         Ditto.
1158         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]):
1159         Ditto.
1160         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
1161         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
1162
1163 2013-12-11  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1164
1165         Fixed test-wepkitpy logging for buildslaves
1166         https://bugs.webkit.org/show_bug.cgi?id=125445
1167
1168         Reviewed by Csaba Osztrogonác.
1169
1170         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1171         (RunPythonTests):
1172
1173 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
1174
1175         Programmatically-inserted children lack accessibility events
1176         https://bugs.webkit.org/show_bug.cgi?id=100275
1177
1178         Reviewed by Chris Fleizach.
1179
1180         Update DRT and WebKitTestRunner to handle the children-changed
1181         signal properly, considering the detail and optional parameters.
1182
1183         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
1184         (axObjectEventListener):
1185         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
1186
1187 2013-12-03  Mark Rowe  <mrowe@apple.com>
1188
1189         <https://webkit.org/b/125139> Modernize the WebKit API headers
1190         <rdar://problem/15540175>
1191
1192         Reviewed by Anders Carlsson.
1193
1194         * DumpRenderTree/mac/TestRunnerMac.mm:
1195         (TestRunner::setCacheModel): Cast to the enum type.
1196
1197 2013-12-10  Filip Pizlo  <fpizlo@apple.com>
1198
1199         Get rid of forward exit on DoubleAsInt32
1200         https://bugs.webkit.org/show_bug.cgi?id=125552
1201
1202         Reviewed by Oliver Hunt.
1203         
1204         Add some support for testing the generic (non-X86) paths on X86 by disabling
1205         architecture-specific optimizations (ASO's).
1206
1207         * Scripts/run-javascriptcore-tests:
1208         * Scripts/run-jsc-stress-tests:
1209
1210 2013-12-10  Ryuan Choi  <ryuan.choi@samsung.com>
1211
1212         Unreviewed EFL build fix attempt
1213
1214         * TestWebKitAPI/CMakeLists.txt: Added ${WEBKIT2_DIR}/Platform/CoreIPC to include lists.
1215         * WebKitTestRunner/CMakeLists.txt: Ditto.
1216
1217 2013-12-10  Anders Carlsson  <andersca@apple.com>
1218
1219         Add a HashMap constructor that takes an initializer list
1220         https://bugs.webkit.org/show_bug.cgi?id=125551
1221
1222         Reviewed by Dan Bernstein.
1223
1224         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1225         (TestWebKitAPI::TEST):
1226
1227 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1228
1229         Use std::array when computing MD5 checksum
1230         https://bugs.webkit.org/show_bug.cgi?id=125509
1231
1232         Reviewed by Anders Carlsson.
1233
1234         Use MD5::Digest type and MD5::hashSize when computing MD5 checksum.
1235
1236         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1237         (computeMD5HashStringForBitmapContext):
1238         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
1239         (computeMD5HashStringForBitmapContext):
1240         * TestWebKitAPI/Tests/WTF/MD5.cpp:
1241         (TestWebKitAPI::expectMD5):
1242         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1243         (WTR::computeMD5HashStringForCairoSurface):
1244         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1245         (WTR::computeMD5HashStringForContext):
1246
1247 2013-12-10  Mario Sanchez Prada  <mario.prada@samsung.com>
1248
1249         [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
1250         https://bugs.webkit.org/show_bug.cgi?id=125522
1251
1252         Reviewed by Chris Fleizach.
1253
1254         Update strings representing ATK_ROLE_SEPARATOR for layout tests.
1255
1256         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1257         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1258
1259 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1260
1261         Add --makeargs option to build-jsc
1262         https://bugs.webkit.org/show_bug.cgi?id=125344
1263
1264         Reviewed by Filip Pizlo.
1265
1266         * Scripts/build-jsc: Handle and pass makefile arguments in jsc build.
1267
1268 2013-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
1269
1270         AX: [ATK] Convert the get_text atktest.c unit tests to layout tests
1271         https://bugs.webkit.org/show_bug.cgi?id=125497
1272
1273         Reviewed by Mario Sanchez Prada.
1274
1275         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1276         (AccessibilityUIElement::stringForRange): Implemented.
1277         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1278         (WTR::AccessibilityUIElement::stringForRange): Implemented.
1279
1280 2013-12-10  Martin Robinson  <mrobinson@igalia.com>
1281
1282         Various fixes for the CMake GTK+ build
1283
1284         Reviewed by Gustavo Noronha.
1285
1286         * MiniBrowser/gtk/CMakeLists.txt: Update source list and correct the name of BrowserMarshal.h.
1287         * TestWebKitAPI/PlatformGTK.cmake: Add GTK+ libraries to the test program. They're required.
1288
1289 2013-12-10  László Langó  <lango@inf.u-szeged.hu>
1290
1291         --cloop option does not work in Tools/Scripts/build-jsc.
1292         https://bugs.webkit.org/show_bug.cgi?id=125214
1293
1294         Reviewed by Csaba Osztrogonác.
1295
1296         * Scripts/build-jsc:
1297
1298 2013-12-10  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1299
1300         Merge mark_for_landing and mark_for_commit_queue into one argument
1301         https://bugs.webkit.org/show_bug.cgi?id=125448
1302
1303         Reviewed by Ryosuke Niwa.
1304
1305         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1306         (CommitQueueFlag):
1307         (Bugzilla._commit_queue_flag):
1308         (Bugzilla._fill_attachment_form):
1309         (Bugzilla.add_patch_to_bug):
1310         (Bugzilla.create_bug):
1311         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1312         (test_commit_queue_flag.assert_commit_queue_flag):
1313         (test_commit_queue_flag):
1314
1315 2013-12-09  Tim Horton  <timothy_horton@apple.com>
1316
1317         Remove dead extract_reference_link.py (and the reftests module)
1318         https://bugs.webkit.org/show_bug.cgi?id=125116
1319
1320         Reviewed by Ryosuke Niwa.
1321
1322         This code doesn't seem to have ever been used.
1323
1324         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Removed.
1325         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Removed.
1326         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Removed.
1327
1328 2013-12-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1329
1330         [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
1331         https://bugs.webkit.org/show_bug.cgi?id=125456
1332
1333         Reviewed by Chris Fleizach.
1334
1335         Return 'AXSection' for section roles instead of 'AXDiv'.
1336
1337         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1338         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1339
1340 2013-12-09  Brian J. Burg  <burg@cs.washington.edu>
1341
1342         check-webkit-style should check for extra newlines at EOF
1343         https://bugs.webkit.org/show_bug.cgi?id=125424
1344
1345         Reviewed by Darin Adler.
1346
1347         Report a style violation if extraneous newlines are added
1348         to the end of a C++ file. There should only be one newline at EOF.
1349
1350         * Scripts/webkitpy/style/checkers/cpp.py:
1351         (check_for_missing_new_line_at_eof): Renamed from check_for_new_line_at_eof.
1352         (check_for_extra_new_line_at_eof): Added.
1353         (_process_lines): Added new check and renamed existing EOF check.
1354         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1355         (CppStyleTest.test_extra_newlines_at_eof): Added.
1356         (CppStyleTest.test_extra_newlines_at_eof.do_test): Added.
1357
1358 2013-12-09  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1359
1360         check-webkit-style: ternary operator in macro call identified as initialization list
1361         https://bugs.webkit.org/show_bug.cgi?id=125443
1362
1363         Reviewed by Ryosuke Niwa.
1364
1365         Do not match initialization list when questionmark is placed before :
1366
1367         * Scripts/webkitpy/style/checkers/cpp.py:
1368         (check_member_initialization_list):
1369
1370 2013-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
1371
1372         AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests
1373         https://bugs.webkit.org/show_bug.cgi?id=125451
1374
1375         Reviewed by Mario Sanchez Prada.
1376
1377         Create the needed callbacks for DRT and WKTR.
1378
1379         * DumpRenderTree/AccessibilityUIElement.cpp:
1380         (characterAtOffsetCallback): added
1381         (wordAtOffsetCallback): added
1382         (lineAtOffsetCallback): added
1383         (sentenceAtOffsetCallback): added
1384         (AccessibilityUIElement::getJSClass):
1385         * DumpRenderTree/AccessibilityUIElement.h:
1386         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1387         (stringAtOffset): added
1388         (AccessibilityUIElement::characterAtOffset): added
1389         (AccessibilityUIElement::wordAtOffset): added
1390         (AccessibilityUIElement::lineAtOffset): added
1391         (AccessibilityUIElement::sentenceAtOffset): added
1392         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1393         (WTR::AccessibilityUIElement::characterAtOffset): added
1394         (WTR::AccessibilityUIElement::wordAtOffset): added
1395         (WTR::AccessibilityUIElement::lineAtOffset): added
1396         (WTR::AccessibilityUIElement::sentenceAtOffset): added
1397         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1398         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1399         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1400         (WTR::stringAtOffset): added
1401         (WTR::AccessibilityUIElement::characterAtOffset): added
1402         (WTR::AccessibilityUIElement::wordAtOffset): added
1403         (WTR::AccessibilityUIElement::lineAtOffset): added
1404         (WTR::AccessibilityUIElement::sentenceAtOffset): added
1405
1406 2013-12-08  Sam Weinig  <sam@webkit.org>
1407
1408         32-bit MiniBrowser doesn't build
1409         https://bugs.webkit.org/show_bug.cgi?id=125420
1410
1411         Reviewed by Dan Bernstein.
1412
1413         * MiniBrowser/mac/AppDelegate.h:
1414         * MiniBrowser/mac/AppDelegate.m:
1415         (-[BrowserAppDelegate init]):
1416         (-[BrowserAppDelegate applicationWillTerminate:]):
1417
1418 2013-12-08  Brian Holt  <brian.holt@samsung.com>
1419
1420         [WK2] Add ENABLE_NETWORK_PROCESS flag
1421         https://bugs.webkit.org/show_bug.cgi?id=125421
1422
1423         Add support to build with the Network Process enabled.
1424
1425         Reviewed by Martin Robinson.
1426
1427         * Scripts/webkitperl/FeatureList.pm:
1428
1429 2013-12-07  Filip Pizlo  <fpizlo@apple.com>
1430
1431         Fold typedArray.length if typedArray is constant
1432         https://bugs.webkit.org/show_bug.cgi?id=125252
1433
1434         Reviewed by Sam Weinig.
1435         
1436         Add Source/JavaScriptCore/tests/stress to the set of JS tests. This is where you
1437         should put tests that run just like JSRegress but don't run as part of LayoutTests.
1438         Currently I'm using it for tests that require some surgical support from jsc.cpp.
1439
1440         * Scripts/run-javascriptcore-tests:
1441
1442 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
1443
1444         [gdb] Update printers for WTF::CString, JSC::JSString
1445         https://bugs.webkit.org/show_bug.cgi?id=124600
1446
1447         Reviewed by Gustavo Noronha Silva.
1448
1449         Update the two printers after they fell behind the changes in implementation.
1450
1451         * gdb/webkit.py:
1452         (WTFCStringPrinter.to_string):
1453         (JSCJSStringPrinter.to_string):
1454
1455 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
1456
1457         [webkitpy] Add a WestonDriver unit test
1458         https://bugs.webkit.org/show_bug.cgi?id=125408
1459
1460         Reviewed by Gustavo Noronha Silva.
1461
1462         Add a webkitpy unit test for the Weston driver.
1463
1464         * Scripts/webkitpy/port/westondriver_unittest.py: Added.
1465         (WestonDriverTest):
1466         (WestonDriverTest.make_driver): Sets up a new WestonDriver instance for testing purposes.
1467         (WestonDriverTest.test_start): Check that the Weston compositor is launched properly and that
1468         the server environment contains proper WAYLAND and GDK_BACKEND entries.
1469         (WestonDriverTest.test_stop): Check that the Weston compositor is terminated properly and that
1470         the driver cleans up the temporary directory.
1471         (WestonDriverTest.test_stop.FakeWestonProcess): A helper class that logs the expected termination.
1472         (WestonDriverTest.test_stop.FakeWestonProcess.terminate):
1473
1474 2013-12-08  Brendan Long  <b.long@cablelabs.com>
1475
1476         [Gtk] install-dependencies doesn't install libgtk-3-dev
1477         https://bugs.webkit.org/show_bug.cgi?id=125320
1478
1479         Reviewed by Gustavo Noronha Silva.
1480
1481         * gtk/install-dependencies: Add libgtk-3-dev, libsoup2.4 and subversion
1482
1483 2013-12-07  Sam Weinig  <sam@webkit.org>
1484
1485         [Cocoa] Convert a few more parts of MiniBrowser over to the Objective-C API
1486         https://bugs.webkit.org/show_bug.cgi?id=125401
1487
1488         Reviewed by Dan Bernstein.
1489
1490         * MiniBrowser/mac/WK2BrowserWindowController.m:
1491         (-[WK2BrowserWindowController fetch:]):
1492         (-[WK2BrowserWindowController reload:]):
1493         (-[WK2BrowserWindowController goBack:]):
1494         (-[WK2BrowserWindowController goForward:]):
1495         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
1496         (-[WK2BrowserWindowController currentZoomFactor]):
1497         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
1498         (-[WK2BrowserWindowController zoomIn:]):
1499         (-[WK2BrowserWindowController zoomOut:]):
1500         (-[WK2BrowserWindowController canResetZoom]):
1501         (-[WK2BrowserWindowController resetZoom:]):
1502         (-[WK2BrowserWindowController toggleZoomMode:]):
1503         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
1504
1505 2013-12-07  Sam Weinig  <sam@webkit.org>
1506
1507         Convert MiniBrowser to use WKProcessGroup and WKBrowsingContextGroup
1508         https://bugs.webkit.org/show_bug.cgi?id=125400
1509
1510         Reviewed by Dan Bernstein.
1511
1512         * MiniBrowser/mac/AppDelegate.h:
1513         * MiniBrowser/mac/AppDelegate.m:
1514         * MiniBrowser/mac/WK2BrowserWindowController.h:
1515         * MiniBrowser/mac/WK2BrowserWindowController.m:
1516         (-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
1517         (-[WK2BrowserWindowController dealloc]):
1518         (createNewPage):
1519         (-[WK2BrowserWindowController awakeFromNib]):
1520         (-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
1521         (-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
1522         (-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
1523         (-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):
1524         Replace global WKContextRef and WKPageGroupRef with WKProcessGroup and WKBrowsingContextGroup. Also
1525         replace context based WKContextHistoryClient with WKBrowsingContextController based WKBrowsingContextHistoryDelegate
1526
1527 2013-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1528
1529         [GTK] Run each gtest subtest separately instead of in one go
1530         https://bugs.webkit.org/show_bug.cgi?id=125386
1531
1532         Reviewed by Martin Robinson.
1533
1534         This is what other ports are doing (except they build each test as a separate binary)
1535         and will help with the timeouts we sometimes hit because it applies to the full test
1536         run.
1537
1538         * Scripts/run-gtk-tests:
1539         (TestRunner._get_tests_from_google_test_suite): get a list of available sub-tests.
1540         (TestRunner._run_google_test): run a single subtest from a gtest binary.
1541         (TestRunner._run_google_test_suite): call the binary once per subtest.
1542
1543 2013-12-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1544
1545         Move PrettyPatch related code to prettypatch.py
1546         https://bugs.webkit.org/show_bug.cgi?id=124937
1547
1548         Reviewed by Ryosuke Niwa.
1549
1550         This code seems to have a better place here than in Port, since PrettyPatch already knows
1551         pretty_patch_path, and this also unifies the usage of PrettyPatch
1552
1553         * Scripts/webkitpy/common/prettypatch.py:
1554         (PrettyPatch.__init__):
1555         (PrettyPatch.pretty_diff):
1556         (PrettyPatch):
1557         (PrettyPatch.pretty_patch_available):
1558         (PrettyPatch.check_pretty_patch):
1559         (PrettyPatch.pretty_patch_text):
1560         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1561         (TestResultWriter.create_text_diff_and_write_result):
1562         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1563         (summarize_results):
1564         * Scripts/webkitpy/port/base.py:
1565         (Port.__init__):
1566         (Port.wdiff_available):
1567         (Port.check_image_diff):
1568         (Port.wdiff_text):
1569         * Scripts/webkitpy/port/base_unittest.py:
1570         (PortTest.test_pretty_patch_os_error):
1571         (PortTest.test_pretty_patch_script_error):
1572
1573 2013-12-06  Dan Bernstein  <mitz@apple.com>
1574
1575         [Mac] MiniBrowser Debug builds are compiled with -Os
1576         https://bugs.webkit.org/show_bug.cgi?id=125376
1577
1578         Reviewed by Tim Horton.
1579
1580         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Set GCC_OPTIMIZATION_LEVEL to 0 for
1581         the Debug configuration at the project level.
1582
1583 2013-12-06  Jer Noble  <jer.noble@apple.com>
1584
1585         [MSE] Add a runtime-setting for the MediaSource constructor.
1586         https://bugs.webkit.org/show_bug.cgi?id=125336
1587
1588         Reviewed by Eric Carlson.
1589
1590         Enable MediaSource in DRT and WKTR.
1591
1592         * DumpRenderTree/mac/DumpRenderTree.mm:
1593         (resetWebPreferencesToConsistentValues):
1594         * WebKitTestRunner/TestController.cpp:
1595         (WTR::TestController::resetPreferencesToConsistentValues):
1596
1597 2013-12-06  Jer Noble  <jer.noble@apple.com>
1598
1599         Strip out extraneous logging from AppleGVA in media tests.
1600         https://bugs.webkit.org/show_bug.cgi?id=125357
1601
1602         Reviewed by Simon Fraser.
1603
1604         Add a mechanism for stripping out abritrary regular expressions from test input and output.
1605
1606         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1607         (SingleTestRunner._run_compare_test): Strip out logging
1608         * Scripts/webkitpy/port/base.py:
1609         (Port.logging_patterns_to_strip): Return an empty list by default.
1610         * Scripts/webkitpy/port/driver.py:
1611         (DriverOutput.strip_patterns): Apply the port specific patterns to the text.
1612         * Scripts/webkitpy/port/mac.py:
1613         (MacPort.logging_patterns_to_strip): Return a complete list.
1614
1615 2013-12-06  Dean Jackson  <dino@apple.com>
1616
1617         Updating ANGLE should point to instructions
1618         https://bugs.webkit.org/show_bug.cgi?id=125361
1619
1620         Reviewed by Eric Carlson.
1621
1622         Point to https://trac.webkit.org/wiki/UpdatingANGLE when
1623         someone wants to patch ANGLE.
1624
1625         * Scripts/webkitpy/common/config/watchlist:
1626
1627 2013-12-06  Dan Bernstein  <mitz@apple.com>
1628
1629         [Mac] Transition MiniBrowser to the Cocoa API: load delegate
1630         https://bugs.webkit.org/show_bug.cgi?id=125334
1631
1632         Reviewed by Darin Adler.
1633
1634         * MiniBrowser/mac/WK2BrowserWindowController.m:
1635         (-[WK2BrowserWindowController dealloc]): Nil out the load delegate and stop observing the
1636         title property.
1637         (-[WK2BrowserWindowController isPaginated]): Changed to use Cocoa SPI.
1638         (-[WK2BrowserWindowController togglePaginationMode:]): Ditto.
1639         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): Update the
1640         window title with the title property changes.
1641         (-[WK2BrowserWindowController awakeFromNib]): Start observing the title property. Changed to
1642         set the load delegate instead of the load client.
1643         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Changed to use Cocoa types.
1644         (-[WK2BrowserWindowController updateProvisionalURL]): Removed frame parameter.
1645         (-[WK2BrowserWindowController updateCommittedURL]): Ditto.
1646         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
1647         Implemented this load delegate method.
1648         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
1649         Ditto.
1650         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]): Ditto.
1651         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
1652         (-[WK2BrowserWindowController browsingContextControllerDidFinishLoad:]): Ditto.
1653         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
1654         (-[WK2BrowserWindowController browsingContextControllerDidChangeBackForwardList:addedItem:removedItems:]):
1655         Ditto.
1656         (-[WK2BrowserWindowController browsingContextController:canAuthenticateAgainstProtectionSpace:]):
1657         Ditto.
1658         (-[WK2BrowserWindowController browsingContextController:didReceiveAuthenticationChallenge:]): Ditto.
1659
1660 2013-12-06  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1661
1662         Remove function from style/checkers/cpp.py.
1663         https://bugs.webkit.org/show_bug.cgi?id=125341
1664
1665         Reviewed by Darin Adler.
1666
1667         Corrects a FIXME: by removing a function from cpp.py.
1668
1669         * Scripts/webkitpy/style/checkers/cpp.py:
1670         (CppChecker.__init__):
1671         (CppChecker.check):
1672         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1673         (CppStyleTestBase.process_file_data):
1674
1675 2013-12-06  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1676
1677         check-webkit-style: false positive warning for indentation of #ifdef code.
1678         https://bugs.webkit.org/show_bug.cgi?id=125254
1679
1680         Reviewed by Darin Adler.
1681
1682         * Scripts/webkitpy/style/checkers/cpp.py:
1683         (check_member_initialization_list):
1684         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1685         (WebKitStyleTest.test_member_initialization_list):
1686
1687 2013-12-06  Chris Fleizach  <cfleizach@apple.com>
1688
1689         Fix spelling error in style checker: beggining
1690         https://bugs.webkit.org/show_bug.cgi?id=125347
1691
1692         Reviewed by Anders Carlsson.
1693
1694         * Scripts/webkitpy/style/checkers/cpp.py:
1695         (check_member_initialization_list):
1696         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1697         (WebKitStyleTest.test_member_initialization_list):
1698
1699 2013-12-06  Lukasz Gajowy  <l.gajowy@samsung.com>
1700
1701         [ATK] Missing aria roles mappings
1702         https://bugs.webkit.org/show_bug.cgi?id=117729
1703
1704         Reviewed by Mario Sanchez Prada.
1705
1706         Added new mappings to AccessibilityUIElementAtk.cpp.
1707
1708         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1709         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1710
1711 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1712
1713         Typo fix after r160218.
1714
1715         * Scripts/webkitpy/test/main.py:
1716         (main):
1717
1718 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1719
1720         Unreviewed fix after r160206.
1721
1722         * Scripts/webkitpy/test/main.py:
1723         (main): sys.platform can be win32 or cygwin too on Windows.
1724
1725 2013-12-05  Csaba Osztrogonác  <ossy@webkit.org>
1726
1727         Disable WebKit2 webkitpy unittests on Windows
1728         https://bugs.webkit.org/show_bug.cgi?id=125318
1729
1730         Reviewed by Ryosuke Niwa.
1731
1732         * Scripts/webkitpy/test/main.py:
1733         (main):
1734
1735 2013-12-05  Anders Carlsson  <andersca@apple.com>
1736
1737         Tweak WeakObjCPtr
1738         https://bugs.webkit.org/show_bug.cgi?id=125311
1739
1740         Reviewed by Darin Adler.
1741
1742         Split up tests into more logical groups. Add new tests for new functionality.
1743
1744         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1745
1746 2013-12-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1747
1748         [GTK] Fix gtk-doc warnings when generating DOM bindings API docs
1749         https://bugs.webkit.org/show_bug.cgi?id=125302
1750
1751         Reviewed by Philippe Normand.
1752
1753         * gtk/generate-webkitdom-doc-files:
1754         (WebKitDOMDocGeneratorSections.write_footer): Add a new section
1755         containing a private subsection for WEBKIT_API, WEBKIT_DEPRECATED
1756         and WEBKIT_DEPRECATED_FOR macros.
1757
1758 2013-12-05  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1759
1760         Fix cross compilation on x86
1761         https://bugs.webkit.org/show_bug.cgi?id=125295
1762
1763         Reviewed by Zoltan Herczeg.
1764
1765         Certain compiler flags should not be added when cross compilation is enabled.
1766
1767         * Scripts/webkitdirs.pm:
1768         (runAutogenForAutotoolsProjectIfNecessary):
1769         (generateBuildSystemFromCMakeProject):
1770
1771 2013-12-05  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1772
1773         Remove duplicated/dead code from cpp style checker unit tests.
1774         https://bugs.webkit.org/show_bug.cgi?id=125226
1775
1776         Reviewed by Ryosuke Niwa.
1777
1778         Remove the first definition of OrderOfIncludesTest class as it is
1779         overwritten by the second. Remove a duplicated assert statement
1780         from the second class.
1781
1782         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1783         (OrderOfIncludesTest.setUp):
1784         (OrderOfIncludesTest.test_try_drop_common_suffixes):
1785           The last assert was duplicated.
1786
1787 2013-12-05  László Langó  <lango@inf.u-szeged.hu>
1788
1789         Remove Scripts/generate-qt-inspector-resource.
1790         https://bugs.webkit.org/show_bug.cgi?id=125288
1791
1792         Reviewed by Andreas Kling.
1793
1794         * Scripts/generate-qt-inspector-resource: Removed. There is no QT anymore.
1795         We don't need this file.
1796
1797 2013-12-05  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1798
1799         Remove certain methods from TestExpectations and use TestExpectationsModel instead of them
1800         https://bugs.webkit.org/show_bug.cgi?id=125218
1801
1802         Reviewed by Ryosuke Niwa.
1803
1804         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1805         (LayoutTestFinder.skip_tests):
1806         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1807         (LayoutTestRunner.run_tests):
1808         (LayoutTestRunner._update_summary_with_result):
1809         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1810         (Manager._test_is_slow):
1811         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1812         (JSONLayoutResultsGenerator._insert_failure_summaries):
1813         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1814         (TestExpectations.get_rebaselining_failures):
1815         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1816         (assert_exp):
1817         (MiscTests.test_multiple_results):
1818         (MiscTests.test_category_expectations):
1819         (MiscTests.test_get_modifiers):
1820         (MiscTests.test_get_expectations_string):
1821         (MiscTests.test_expectation_to_string):
1822         (MiscTests.test_get_test_set):
1823         (MiscTests.test_more_specific_override_resets_skip):
1824         (SkippedTests.check):
1825         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1826         (TestRunResults.__init__):
1827         (summarize_results):
1828         * Scripts/webkitpy/tool/commands/rebaseline.py:
1829         (RebaselineExpectations._tests_to_rebaseline):
1830
1831 2013-12-04  Ryosuke Niwa  <rniwa@webkit.org>
1832
1833         Enable HTMLTemplateElement by default
1834         https://bugs.webkit.org/show_bug.cgi?id=123851
1835
1836         Reviewed by Antti Koivisto.
1837
1838         * Scripts/webkitperl/FeatureList.pm:
1839
1840 2013-12-04  Jozsef Berta  <jberta@inf.u-szeged.hu>
1841
1842         [EFL] Bumping GStreamer version to 1.2.1
1843         https://bugs.webkit.org/show_bug.cgi?id=125155
1844
1845         Reviewed by Gyuyoung Kim.
1846
1847         * efl/jhbuild.modules: Set the GStreamer version to 1.2.1
1848
1849
1850 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1851
1852         Update jhbuild revision.
1853         https://bugs.webkit.org/show_bug.cgi?id=124966
1854         
1855         Reviewed by Gyuyoung Kim.
1856
1857         Used version of Jhbuild failed to create directories and caused
1858         update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.
1859
1860         * jhbuild/jhbuild-wrapper:
1861
1862 2013-12-04  Anders Carlsson  <andersca@apple.com>
1863
1864         Add a WeakObjCPtr class
1865         https://bugs.webkit.org/show_bug.cgi?id=125267
1866
1867         Reviewed by Geoffrey Garen.
1868
1869         Add API tests for WeakObjCPtr.
1870
1871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1872         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
1873         (TEST):
1874
1875 2013-12-04  Anders Carlsson  <andersca@apple.com>
1876
1877         Make the estimatedProgress property observable using KVO
1878         https://bugs.webkit.org/show_bug.cgi?id=125259
1879
1880         Reviewed by Dan Bernstein.
1881
1882         Bind the progress indicator value to the "estimatedProgress" property.
1883
1884         * MiniBrowser/mac/WK2BrowserWindowController.m:
1885         (-[WK2BrowserWindowController dealloc]):
1886         (-[WK2BrowserWindowController awakeFromNib]):
1887
1888 2013-12-04  Anders Carlsson  <andersca@apple.com>
1889
1890         Add a loading property to WKBrowsingContextController
1891         https://bugs.webkit.org/show_bug.cgi?id=125256
1892
1893         Reviewed by Dan Bernstein.
1894
1895         Bind the progress indicator visibility to the "loading" property.
1896
1897         * MiniBrowser/mac/WK2BrowserWindowController.m:
1898         (-[WK2BrowserWindowController dealloc]):
1899         (-[WK2BrowserWindowController awakeFromNib]):
1900         (-[WK2BrowserWindowController didStartProgress]):
1901         (-[WK2BrowserWindowController didFinishProgress]):
1902
1903 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
1904
1905         [EFL][WK2] Buildfix after r160104
1906         https://bugs.webkit.org/show_bug.cgi?id=125231
1907
1908         Reviewed by Anders Carlsson.
1909
1910         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1911         (TestWebKitAPI::TEST): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base
1912         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1913         (TestWebKitAPI::setViewClient): Ditto.
1914
1915 2013-12-04  Myles C. Maxfield  <mmaxfield@apple.com>
1916
1917         check-webkit-style detected some ternary statements as initialization lists
1918         https://bugs.webkit.org/show_bug.cgi?id=125246
1919
1920         Reviewed by Dean Jackson.
1921
1922         The regular expression that check-webkit-tests uses to detect initialization
1923         lists was too broad, resulting in false positives. This patch makes the
1924         regex more specific
1925
1926         * Scripts/webkitpy/style/checkers/cpp.py:
1927         (check_member_initialization_list):
1928         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1929         (WebKitStyleTest.test_member_initialization_list):
1930
1931 2013-12-04  Mark Hahnenberg  <mhahnenberg@apple.com>
1932
1933         run-jsc-stress-tests can only run locally
1934         https://bugs.webkit.org/show_bug.cgi?id=124551
1935
1936         Reviewed by Filip Pizlo.
1937
1938         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Fixed a couple issues. One was if the script was
1939         killed before the lock directory was removed, future executions wouldn't make any progress. Also 
1940         added a couple more signals to handle gracefully at shutdown. 
1941         * Scripts/run-javascriptcore-tests: Pass through the --remote argument to run-jsc-stress-tests.
1942         * Scripts/run-jsc-stress-tests: Added support for the --remote flag. It accepts a hostname, user, and port.
1943         The script then generates the test bundle, tars it up, and copies it to the remote host via ssh where
1944         it then untars the bundle and executes the shell-based test runner. Also refactored some of the logic
1945         toward the end of the script to make it easier to tell which of the various modes do what.
1946
1947 2013-12-04  Csaba Osztrogonác  <ossy@webkit.org>
1948
1949         [EFL][WK2] Buildfix after r160104
1950         https://bugs.webkit.org/show_bug.cgi?id=125233
1951
1952         Reviewed by Anders Carlsson.
1953
1954         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1955         (TestWebKitAPI::TEST):
1956         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1957         (TestWebKitAPI::setPageLoaderClient):
1958
1959 2013-12-03  Anders Carlsson  <andersca@apple.com>
1960
1961         Deprecate all unversioned client structs in favor of having explicit versioned structs
1962         https://bugs.webkit.org/show_bug.cgi?id=125203
1963
1964         Reviewed by Dan Bernstein.
1965
1966         Update for WebKit2 API changes.
1967
1968         * MiniBrowser/mac/AppDelegate.m:
1969         (-[BrowserAppDelegate init]):
1970         * MiniBrowser/mac/WK2BrowserWindowController.m:
1971         (-[WK2BrowserWindowController awakeFromNib]):
1972         * TestWebKitAPI/InjectedBundleController.cpp:
1973         (TestWebKitAPI::InjectedBundleController::initialize):
1974         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1975         (TestWebKitAPI::TEST):
1976         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1977         (TestWebKitAPI::setInjectedBundleClient):
1978         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
1979         (TestWebKitAPI::TEST):
1980         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1981         (TestWebKitAPI::TEST):
1982         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1983         (TestWebKitAPI::TEST):
1984         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1985         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
1986         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
1987         (TestWebKitAPI::TEST):
1988         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1989         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
1990         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
1991         (TestWebKitAPI::setInjectedBundleClient):
1992         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1993         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1994         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1995         (TestWebKitAPI::TEST):
1996         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1997         (TestWebKitAPI::TEST):
1998         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1999         (TestWebKitAPI::setContextDownloadClient):
2000         (TestWebKitAPI::setPagePolicyClient):
2001         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2002         (TestWebKitAPI::TEST):
2003         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2004         (TestWebKitAPI::TEST):
2005         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2006         (TestWebKitAPI::TEST):
2007         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2008         (TestWebKitAPI::TEST):
2009         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2010         (TestWebKitAPI::TEST):
2011         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2012         (TestWebKitAPI::TEST):
2013         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2014         (TestWebKitAPI::setupGeolocationProvider):
2015         (TestWebKitAPI::setupView):
2016         (TestWebKitAPI::TEST):
2017         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
2018         (TestWebKitAPI::TEST):
2019         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2020         (TestWebKitAPI::setPageLoaderClient):
2021         (TestWebKitAPI::setInjectedBundleClient):
2022         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2023         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
2024         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2025         (TestWebKitAPI::TEST):
2026         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
2027         (TestWebKitAPI::setInjectedBundleClient):
2028         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2029         (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
2030         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
2031         (TestWebKitAPI::TEST):
2032         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
2033         (TestWebKitAPI::TEST):
2034         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2035         (TestWebKitAPI::TEST):
2036         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2037         (TestWebKitAPI::TEST):
2038         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2039         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage):
2040         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
2041         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2042         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2043         (TestWebKitAPI::setPageLoaderClient):
2044         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
2045         (TestWebKitAPI::setPageLoaderClient):
2046         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2047         (TestWebKitAPI::setPageLoaderClient):
2048         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2049         (TestWebKitAPI::setPageLoaderClient):
2050         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2051         (TestWebKitAPI::setPageLoaderClient):
2052         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2053         (TestWebKitAPI::TEST):
2054         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2055         (TestWebKitAPI::TEST):
2056         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
2057         (TestWebKitAPI::setInjectedBundleClient):
2058         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
2059         (TestWebKitAPI::ParentFrameTest::didCreatePage):
2060         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
2061         (TestWebKitAPI::setInjectedBundleClient):
2062         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
2063         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
2064         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2065         (TestWebKitAPI::TEST):
2066         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
2067         (TestWebKitAPI::TEST):
2068         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2069         (TestWebKitAPI::TEST):
2070         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
2071         (TestWebKitAPI::TEST):
2072         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2073         (TestWebKitAPI::setInjectedBundleClient):
2074         (TestWebKitAPI::setPageLoaderClient):
2075         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2076         (TestWebKitAPI::setPageLoaderClient):
2077         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2078         (TestWebKitAPI::TEST):
2079         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
2080         (TestWebKitAPI::setPageLoaderClient):
2081         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
2082         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
2083         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2084         (TestWebKitAPI::TEST):
2085         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
2086         (TestWebKitAPI::TEST):
2087         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
2088         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
2089         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
2090         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp:
2091         (TestWebKitAPI::TEST):
2092         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp:
2093         (TestWebKitAPI::WKConnectionTest::initialize):
2094         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
2095         (TestWebKitAPI::setPageLoaderClient):
2096         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2097         (TestWebKitAPI::setInjectedBundleClient):
2098         (TestWebKitAPI::TEST):
2099         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
2100         (TestWebKitAPI::WebKit2WillLoadTest::setInjectedBundleClient):
2101         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2102         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
2103         (TestWebKitAPI::setInjectedBundleClient):
2104         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
2105         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
2106         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
2107         (TestWebKitAPI::TEST):
2108         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
2109         (TestWebKitAPI::setInjectedBundleClient):
2110         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2111         (TestWebKitAPI::TEST):
2112         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2113         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
2114         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
2115         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
2116         (TestWebKitAPI::didCreateConnection):
2117         (TestWebKitAPI::TEST):
2118         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2119         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
2120         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
2121         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2122         (TestWebKitAPI::setPageLoaderClient):
2123         * WebKitTestRunner/GeolocationProviderMock.cpp:
2124         (WTR::GeolocationProviderMock::GeolocationProviderMock):
2125         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2126         (WTR::InjectedBundle::initialize):
2127         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2128         (WTR::InjectedBundlePage::InjectedBundlePage):
2129         * WebKitTestRunner/TestController.cpp:
2130         (WTR::TestController::createOtherPage):
2131         (WTR::TestController::initialize):
2132         (WTR::TestController::createWebViewWithOptions):
2133
2134 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2135
2136         Style checker for .messages.in files (WTF:: prefix)
2137         https://bugs.webkit.org/show_bug.cgi?id=125142
2138
2139         Reviewed by Anders Carlsson.
2140
2141         A new style checker for .messages.in files, that checks for the use of WTF::
2142         prefix in these files. (Also checks for tabs as these files were previously
2143         handled as text files.)
2144
2145         * Scripts/webkitpy/style/checker.py:
2146         (CheckerDispatcher._create_checker):
2147           New checker is returned for .messages.in files.
2148         * Scripts/webkitpy/style/checkers/messagesin.py: Added.
2149           The new style checker class.
2150         (MessagesInChecker):
2151         (MessagesInChecker.__init__):
2152         (MessagesInChecker.check):
2153         (MessagesInChecker.check_WTF_prefix):
2154         * Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added.
2155           Unit test for the new style  checker class.
2156         (MessagesInCheckerStyleTestCase):
2157         (test_checker):
2158         (test_checker.error_handler_for_test):
2159         (MessagesInCheckerTestCase):
2160         (MessagesInCheckerTestCase.test_init):
2161         (MessagesInCheckerTestCase.test_init.error_handler_for_test):
2162
2163 2013-12-04  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2164
2165         Style checker requires alphabetical ordering in cmake lists even it contains variable.
2166         https://bugs.webkit.org/show_bug.cgi?id=124918
2167
2168         Reviewed by Csaba Osztrogonác.
2169
2170         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2171         (CMakeCheckerTest.test_check):
2172         * Scripts/webkitpy/style/checkers/cmake.py:
2173         (CMakeChecker._check_list_order):
2174         This will ignore lines with variable substitution.
2175
2176 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
2177
2178         check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
2179         https://bugs.webkit.org/show_bug.cgi?id=124731
2180
2181         Reviewed by Zoltan Herczeg.
2182
2183         * Scripts/webkitpy/style/checkers/cpp.py:
2184         (check_spacing):
2185         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2186         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
2187
2188 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
2189
2190         Remove codecs and os dependencies from filereader.py in webkitpy/style.
2191         https://bugs.webkit.org/show_bug.cgi?id=124719
2192
2193         Although TextFileReader requires a FileSystem it circumvents it in two places!
2194         We should use the FileSystem only and remove codecs and os imports.
2195
2196         Reviewed by Zoltan Herczeg.
2197
2198         * Scripts/webkitpy/common/system/filesystem.py:
2199         (FileSystem.open_stdin): Moved from TextFileReader
2200         * Scripts/webkitpy/style/filereader.py:
2201         (TextFileReader._read_lines): use FileSystem instead of calling codecs.open directly
2202         (TextFileReader._process_directory): use FileSystem instead of calling os.walk directly
2203
2204 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
2205
2206         check-webkit-style should check member initialization indentation.
2207         https://bugs.webkit.org/show_bug.cgi?id=124820
2208
2209         Reviewed by Zoltan Herczeg.
2210
2211         check-webkit-style should check member initialization indentation
2212         belongs to webkit coding style:
2213         http://www.webkit.org/coding/coding-style.html#punctuation-member-init
2214
2215         * Scripts/webkitpy/style/checkers/cpp.py:
2216         (check_member_initialization_list): Add new method to check member
2217         initialization list.
2218         (check_style): Add the call of the new method.
2219         (check_language): Move self initialization checking into the new method.
2220         (CppChecker): Add a new category for initialization list.
2221         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2222         (CppStyleTest.test_runtime_selfinit):
2223         (CppStyleTest.test_deprecated_cast):
2224         (WebKitStyleTest.test_member_initialization_list): Add new testcases for
2225         the new feature.
2226
2227 2013-12-04  Tamas Gergely  <gertom@inf.u-szeged.hu>
2228
2229         style-bot should reject Committer additions to committers.py
2230         https://bugs.webkit.org/show_bug.cgi?id=107574
2231
2232         Reviewed by Zoltan Herczeg.
2233
2234         The style check when executed in non-interactive mode (probably by a
2235         bot) will raise an additional error if the contributors.json file is
2236         modified. Non-interactive mode information is propagated to the
2237         Dispatcher, which creates a special JSON checker for the
2238         contributors.json file.
2239
2240         * Scripts/webkitpy/style/checker.py:
2241         (check_webkit_style_configuration):
2242         (CheckerDispatcher._create_checker):
2243         (CheckerDispatcher.dispatch):
2244         (StyleProcessorConfiguration.__init__):
2245         (StyleProcessor.process):
2246         * Scripts/webkitpy/style/checker_unittest.py:
2247         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
2248         (CheckerDispatcherDispatchTest.dispatch):
2249         (StyleProcessorConfigurationTest._style_checker_configuration):
2250         (StyleProcessor_EndToEndTest.test_init):
2251         (StyleProcessor_EndToEndTest.test_process):
2252         (StyleProcessor_CodeCoverageTest.MockDispatcher.dispatch):
2253         (StyleProcessor_CodeCoverageTest.setUp):
2254         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2255         (JSONChecker.line_number_from_json_exception):
2256         (JSONContributorsChecker):
2257         (JSONContributorsChecker.check):
2258         * Scripts/webkitpy/style/error_handlers_unittest.py:
2259         (DefaultStyleErrorHandlerTest._style_checker_configuration):
2260         * Scripts/webkitpy/style/optparser.py:
2261         (CommandOptionValues.__init__):
2262         (ArgumentParser._create_option_parser):
2263         (ArgumentParser.parse):
2264         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2265         (test_post):
2266         (test_upload):
2267         * Scripts/webkitpy/tool/steps/checkstyle.py:
2268         (CheckStyle.run):
2269
2270 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
2271
2272         [EFL][WK2] Fix build after API::Client changes
2273         https://bugs.webkit.org/show_bug.cgi?id=125206
2274
2275         Reviewed by Csaba Osztrogonác.
2276
2277         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
2278         (TestWebKitAPI::TEST):
2279         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2280         (TestWebKitAPI::setViewClient):
2281
2282 2013-12-03  Dan Bernstein  <mitz@apple.com>
2283
2284         Fixed a test timing out after r160040.
2285
2286         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2287         (-[SimpleLoadFailDelegate browsingContextController:didFailProvisionalLoadWithError:]):
2288         Updated for the delegate method rename.
2289
2290 2013-12-03  Filip Pizlo  <fpizlo@apple.com>
2291
2292         REGRESSION: repro scripts disappear when you rerun tests
2293         https://bugs.webkit.org/show_bug.cgi?id=125184
2294
2295         Reviewed by Mark Hahnenberg.
2296         
2297         This bug made it difficult to quickly see if a test that recently failed is still
2298         failing while also running a new batch of tests.
2299
2300         Repro scripts are supposed to stay around until you delete them explicitly. This
2301         patch accomplishes that.
2302
2303         * Scripts/run-jsc-stress-tests:
2304
2305 2013-12-03  peavo@outlook.com  <peavo@outlook.com>
2306
2307         [Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
2308         https://bugs.webkit.org/show_bug.cgi?id=125111
2309
2310         Reviewed by Filip Pizlo.
2311
2312         Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.
2313
2314         * Scripts/run-javascriptcore-tests: Enable api test and stress test for WinCairo.
2315         * Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.
2316
2317 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
2318
2319         Add a script to automatically configure a git clone
2320         https://bugs.webkit.org/show_bug.cgi?id=110073
2321
2322         Revert the change to use https for now since git.webkit.org is setup with http.
2323
2324         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2325         (SetupGitClone.execute):
2326
2327 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
2328
2329         Add a script to automatically configure a git clone
2330         https://bugs.webkit.org/show_bug.cgi?id=110073
2331
2332         Reviewed by Benjamin Poulain.
2333
2334         Added "webkit-patch setup-git-clone" to setup a brand new Git clone.
2335
2336         This command runs various commands listed on http://trac.webkit.org/wiki/UsingGitWithWebKit
2337
2338         * Scripts/webkitpy/tool/commands/__init__.py:
2339         * Scripts/webkitpy/tool/commands/setupgitclone.py: Added.
2340         (SetupGitClone):
2341         (SetupGitClone.execute):
2342
2343 2013-12-03  Anders Carlsson  <andersca@apple.com>
2344
2345         Deprecate WKNotificationProvider
2346         https://bugs.webkit.org/show_bug.cgi?id=125178
2347
2348         Reviewed by Sam Weinig.
2349
2350         Update for WebKit2 changes.
2351
2352         * WebKitTestRunner/TestController.cpp:
2353         (WTR::TestController::initialize):
2354         * WebKitTestRunner/WebNotificationProvider.cpp:
2355         (WTR::WebNotificationProvider::provider):
2356         * WebKitTestRunner/WebNotificationProvider.h:
2357
2358 2013-12-03  Brent Fulgham  <bfulgham@apple.com>
2359
2360         [Win] Support 64-bit Application Support Libraries Location 
2361         https://bugs.webkit.org/show_bug.cgi?id=125179
2362
2363         Reviewed by Tim Horton.
2364
2365         Enable the user to specify a location for 64-bit support libraries (such as libxml2, ICU, etc.)
2366         on Windows until an official distribution is available that properly creates registry settings
2367         to specify these locations.
2368
2369         * Scripts/webkitdirs.pm:
2370         (setupAppleWinEnv): Notify user to set WEBKIT_64_SUPPORT environment variable if needed.
2371         (setupCygwinEnv): Report WEWBKIT_64_SUPPORT path when running 64-bit builds.
2372         (appleApplicationSupportPath): Add WEBKIT_64_SUPPORT location to runtime environment when
2373         running 64-bit builds.
2374
2375 2013-12-03  Mark Hahnenberg  <mhahnenberg@apple.com>
2376
2377         run-jsc-stress-tests only supports host environments that have make installed
2378         https://bugs.webkit.org/show_bug.cgi?id=124550
2379
2380         Reviewed by Darin Adler.
2381
2382         This might not be the case for all hosts, so this patch implements an alternate "backend" 
2383         for run-jsc-stress-tests to use normal shell commands rather than Makefiles. To remain at 
2384         least somewhat competitive with the make-based test runner, the shell backend uses subshells
2385         run in the background to allow tests to run in parallel. Since the concurrency primitives 
2386         in shell scripting are rather coarse, the overhead of this parallelism is higher than that 
2387         of the make-based runner.
2388
2389         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added. This is the runner that is copied into
2390         the bundle and controls all of the parallel aspects of the shell-based test runner.
2391         * Scripts/run-jsc-stress-tests:
2392
2393 2013-12-03  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2394
2395         Remove function from TextChecker
2396         https://bugs.webkit.org/show_bug.cgi?id=125148
2397
2398         Reviewed by Darin Adler.
2399
2400         The process_file_data is used only from the unit tests, so it is simply moved there.
2401
2402         * Scripts/webkitpy/style/checkers/text.py:
2403         (TextChecker.check):
2404         * Scripts/webkitpy/style/checkers/text_unittest.py:
2405         (TextStyleTestCase.process_file_data):
2406         (TextStyleTestCase.assertNoError):
2407         (TextStyleTestCase.assertError):
2408
2409 2013-12-03  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2410
2411         Remove get_test() and reference test names directly instead.
2412         https://bugs.webkit.org/show_bug.cgi?id=124962
2413
2414         Reviewed by Csaba Osztrogonác.
2415
2416         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2417         (Base.__init__):
2418         (Base.get_basic_tests):
2419         (assert_exp):
2420         (MiscTests.test_multiple_results):
2421         (MiscTests.test_category_expectations):
2422         (MiscTests.test_get_modifiers):
2423         (MiscTests.test_get_expectations_string):
2424         (MiscTests.test_get_test_set):
2425         (MiscTests.test_parse_warning):
2426         (MiscTests.test_pixel_tests_flag.match):
2427
2428 2013-12-03  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2429
2430         Style Checker false pass.
2431         https://bugs.webkit.org/show_bug.cgi?id=112456
2432
2433         Reviewed by Csaba Osztrogonác.
2434
2435         * Scripts/webkitpy/style/checkers/changelog.py:
2436         (ChangeLogChecker.check_entry):
2437         simple regex fix to check "No new tests (...)."
2438         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2439         (ChangeLogCheckerTest.test_no_new_tests):
2440
2441 2013-12-02  Filip Pizlo  <fpizlo@apple.com>
2442
2443         run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
2444         https://bugs.webkit.org/show_bug.cgi?id=125130
2445
2446         Reviewed by Geoffrey Garen.
2447
2448         * Scripts/run-jsc-stress-tests:
2449
2450 2013-12-02  Samuel White  <samuel_white@apple.com>
2451
2452         AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
2453         https://bugs.webkit.org/show_bug.cgi?id=124561
2454
2455         Reviewed by Chris Fleizach.
2456
2457         Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should.
2458
2459         * DumpRenderTree/AccessibilityUIElement.cpp:
2460         (uiElementCountForSearchPredicateCallback):
2461         (uiElementForSearchPredicateCallback):
2462         (AccessibilityUIElement::getJSClass):
2463         * DumpRenderTree/AccessibilityUIElement.h:
2464         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2465         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2466         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2467         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2468         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2469         (searchPredicateParameterizedAttributeForSearchCriteria):
2470         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2471         (AccessibilityUIElement::uiElementForSearchPredicate):
2472         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2473         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2474         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2475         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2476         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2477         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2478         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2479         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2480         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2481         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2482         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2483         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2484
2485 2013-12-02  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2486
2487         Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py
2488         https://bugs.webkit.org/show_bug.cgi?id=124714
2489
2490         Reviewed by Ryosuke Niwa.
2491
2492         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2493         (write_test_result):
2494         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2495         (TestFailure.write_failure):
2496         (FailureText):
2497         (FailureText.write_failure):
2498         (FailureAudio):
2499         (FailureAudio.write_failure):
2500         (FailureCrash.write_failure):
2501         (FailureMissingResult):
2502         (FailureTextMismatch):
2503         (FailureMissingImageHash.write_failure):
2504         (FailureMissingImage.write_failure):
2505         (FailureImageHashMismatch.write_failure):
2506         (FailureReftestMismatch.write_failure):
2507         (FailureReftestMismatchDidNotOccur.write_failure):
2508         (FailureMissingAudio):
2509         (FailureAudioMismatch):
2510
2511 2013-12-02  László Langó  <lango@inf.u-szeged.hu>
2512
2513         Remove the stderr_write attribute from StyleProcessorConfiguration
2514         https://bugs.webkit.org/show_bug.cgi?id=124703
2515
2516         Reviewed by Ryosuke Niwa.
2517
2518         Remove the stderr_write attribute from this class in checker and
2519         replace its use with calls to a logging module logger. We Should 
2520         use logging module instead of writing to stderr directly.
2521
2522         * Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger.
2523         (check_webkit_style_configuration):
2524         (CheckerDispatcher.dispatch): Remove FIXME comment.
2525         (StyleProcessorConfiguration):
2526         (StyleProcessorConfiguration.__init__):
2527         (StyleProcessorConfiguration.write_style_error):
2528         * Scripts/webkitpy/style/checker_unittest.py: Update test to the modification.
2529         There is an "ERROR" prefix in log messiges from now.
2530         (StyleProcessorConfigurationTest):
2531         (StyleProcessorConfigurationTest._style_checker_configuration):
2532         (StyleProcessorConfigurationTest.test_init):
2533         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
2534         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
2535         (StyleProcessor_EndToEndTest.with):
2536         (StyleProcessor_EndToEndTest.test_init):
2537         (StyleProcessor_EndToEndTest.test_process):
2538         (StyleProcessor_CodeCoverageTest.setUp):
2539         * Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger.
2540         (DefaultStyleErrorHandler.__call__):
2541         * Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification.
2542         There is an "ERROR" prefix in log messiges from now.
2543         (DefaultStyleErrorHandlerTest):
2544         (DefaultStyleErrorHandlerTest.setUp):
2545         (DefaultStyleErrorHandlerTest._mock_increment_error_count):
2546         (DefaultStyleErrorHandlerTest._style_checker_configuration):
2547         (DefaultStyleErrorHandlerTest._check_initialized):
2548         (DefaultStyleErrorHandlerTest.test_non_reportable_error):
2549         (DefaultStyleErrorHandlerTest.test_max_reports_per_category):
2550         (DefaultStyleErrorHandlerTest.test_line_numbers):
2551
2552 2013-12-02  Brian J. Burg  <burg@cs.washington.edu>
2553
2554         Add JavaScript style checker and teach checker.py about .js files
2555         https://bugs.webkit.org/show_bug.cgi?id=125049
2556
2557         Reviewed by Joseph Pecoraro.
2558
2559         Add a JavaScript file type, extension, and checker (JSChecker).
2560         Use TextChecker for JavaScript tests, libraries, website resources,
2561         etc. and use JSChecker for files within WebInspectorUI/UserInterface.
2562
2563         Amended tests for TextChecker to reflect the rule above.
2564
2565         * Scripts/webkitpy/style/checker.py:
2566         (_all_categories): Add categories defined by JSChecker.
2567         (FileType): Add file type for JS and re-number the enum.
2568         (CheckerDispatcher._file_type): Detect .js files as JavaScript.
2569         (CheckerDispatcher._create_checker):
2570         Create a JSChecker or TextChecker depending on the file's path.
2571
2572         * Scripts/webkitpy/style/checker_unittest.py:
2573         (CheckerDispatcherDispatchTest.assert_checker_js): Added.
2574         (CheckerDispatcherDispatchTest.test_js_paths): Added.
2575         (CheckerDispatcherDispatchTest.test_text_paths): Add new test paths
2576         that end in .js but should be checked with TextChecker.
2577         * Scripts/webkitpy/style/checkers/js.py: Added.
2578         (JSChecker):
2579         (JSChecker.__init__):
2580         (JSChecker.check):
2581         * Scripts/webkitpy/style/checkers/js_unittest.py: Added.
2582         (JSTestCase):
2583         (JSTestCase.assertNoError):
2584         (JSTestCase.assertNoError.error_for_test):
2585         (JSTestCase.assertError):
2586         (JSTestCase.assertError.error_for_test):
2587         (JSTestCase.test_no_error):
2588         (JSTestCase.test_error):
2589
2590 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2591
2592         run-jsc-stress-tests always copies the VM
2593         https://bugs.webkit.org/show_bug.cgi?id=125092
2594
2595         Reviewed by Filip Pizlo.
2596
2597         This can be slow, especially with full debug builds. It should just symlink the VM into the 
2598         bundle by default and do a full copy only when asked.
2599
2600         * Scripts/run-jsc-stress-tests:
2601
2602 2013-12-02  Brent Fulgham  <bfulgham@apple.com>
2603
2604         [Win] Port run-jsc-stress-tests
2605         https://bugs.webkit.org/show_bug.cgi?id=124801
2606
2607         Reviewed by Filip Pizlo.
2608
2609         * Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl
2610         command on Windows so that stress tests can run.
2611
2612 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2613
2614         Build fix after r159955
2615
2616         * Scripts/run-jsc-stress-tests:
2617
2618 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2619
2620         run-jsc-stress-tests should be able to package its tests and move them places
2621         https://bugs.webkit.org/show_bug.cgi?id=124549
2622
2623         Reviewed by Filip Pizlo.
2624
2625         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
2626         of grep -i -q
2627         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
2628         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
2629         We now also copy whatever VM was specified, along with its associated framework, into this directory.
2630         All of the generated scripts now are completely relative within the results directory. This allows
2631         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
2632         tarball of the generated results directory. Also refactored several portions of the script into
2633         separate functions to make it easier to run them conditionally depending on which mode we're running in. 
2634
2635 2013-12-02  Andrzej Badowski  <a.badowski@samsung.com>
2636
2637         [ATK] Support active state for listbox elements.
2638         https://bugs.webkit.org/show_bug.cgi?id=125009
2639
2640         Reviewed by Chris Fleizach.
2641
2642         Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.
2643
2644         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2645         (AccessibilityUIElement::isSelectedOptionActive):
2646         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2647         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2648         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2649         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2650         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2651         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2652         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2653         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2654
2655 2013-12-02  Zan Dobersek  <zdobersek@igalia.com>
2656
2657         Unreviewed GTK gardening.
2658
2659         * Scripts/run-gtk-tests:
2660         (TestRunner): Skip two unit tests that are causing the subsequent test to crash.
2661
2662 2013-12-01  Dan Bernstein  <mitz@apple.com>
2663
2664         [Mac] Transition MiniBrowser to the Cocoa API: policy delegate   
2665         https://bugs.webkit.org/show_bug.cgi?id=125046
2666
2667         Reviewed by Sam Weinig.
2668
2669         * MiniBrowser/mac/AppDelegate.m:
2670         (-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
2671         (-[BrowserAppDelegate openDocument:]): Ditto.
2672         * MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the
2673         interface to the implementation.
2674         * MiniBrowser/mac/WK2BrowserWindowController.m:
2675         (-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
2676         the policy client.
2677         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
2678         Moved policy client implementation into this delegate method.
2679         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
2680         Ditto.
2681         (-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
2682         Ditto.
2683
2684 2013-12-01  Dan Bernstein  <mitz@apple.com>
2685
2686         [Mac] Remove the MiniBrowser injected bundle
2687         https://bugs.webkit.org/show_bug.cgi?id=125041
2688
2689         Reviewed by Anders Carlsson.
2690
2691         It had no ops!
2692
2693         * MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
2694         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2695         * MiniBrowser/mac/AppDelegate.m:
2696         (-[BrowserAppDelegate init]):
2697         * MiniBrowser/mac/WebBundle/Info.plist: Removed.
2698         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2699
2700 2013-11-29  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2701
2702         check-webkit-style should check for extraneous newline between config.h and primary header.
2703         https://bugs.webkit.org/show_bug.cgi?id=124821
2704
2705         Reviewed by Csaba Osztrogonác.
2706
2707         * Scripts/webkitpy/style/checkers/cpp.py:
2708         (check_include_line):
2709         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2710         (OrderOfIncludesTest.test_check_line_break_after_own_header):
2711         (OrderOfIncludesTest):
2712         (OrderOfIncludesTest.test_check_line_break_before_own_header):
2713
2714 2013-11-29  Jozsef Berta  <jberta@inf.u-szeged.hu>
2715
2716         test-webkit-scripts should show the failing tests and use an appropriate exit code
2717         https://bugs.webkit.org/show_bug.cgi?id=124840
2718
2719         Reviewed by Ryosuke Niwa.
2720
2721         A fixme in test-webkit-scripts asked that the script should display success or failiure
2722         and exit with a 0 or 1 value accordingly after all of the tests have completed.
2723
2724         * Scripts/test-webkit-scripts:
2725         (ScriptsTester.run_test_script):
2726         The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
2727         because at this point we don't need to pass on more information other than success or failiure.
2728         (ScriptsTester.main):
2729         The return values are now stored for each script and when all tests have completed successfully,
2730         the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.
2731
2732 2013-11-29  Krzysztof Czech  <k.czech@samsung.com>
2733
2734         [ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
2735         https://bugs.webkit.org/show_bug.cgi?id=124923
2736
2737         Reviewed by Mario Sanchez Prada.
2738
2739         Added missing implementation of isAttributeSettable. Using
2740         ATK_STATE_EDITABLE for checking whether attribute is settable.
2741
2742         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2743         (AccessibilityUIElement::isAttributeSettable):
2744         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2745         (WTR::AccessibilityUIElement::isAttributeSettable):
2746
2747 2013-11-28  Commit Queue  <commit-queue@webkit.org>
2748
2749         Unreviewed, rolling out r159839.
2750         http://trac.webkit.org/changeset/159839
2751         https://bugs.webkit.org/show_bug.cgi?id=124974
2752
2753         run-webkit-tests doesn't generate pretty diff (Requested by
2754         Ossy on #webkit).
2755
2756         * Scripts/webkitpy/common/prettypatch.py:
2757         (PrettyPatch.__init__):
2758         (PrettyPatch.pretty_diff):
2759         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2760         (TestResultWriter.create_text_diff_and_write_result):
2761         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2762         (summarize_results):
2763         * Scripts/webkitpy/port/base.py:
2764         (Port.__init__):
2765         (Port.pretty_patch_available):
2766         (Port.check_pretty_patch):
2767         (Port.variable):
2768         (Port.variable.pretty_patch_text):
2769         * Scripts/webkitpy/port/base_unittest.py:
2770         (PortTest.test_pretty_patch_os_error):
2771         (PortTest.test_pretty_patch_script_error):
2772
2773 2013-11-28  Antti Koivisto  <antti@apple.com>
2774
2775         Remove feature: CSS variables
2776         https://bugs.webkit.org/show_bug.cgi?id=114119
2777
2778         Reviewed by Andreas Kling.
2779
2780         * Scripts/webkitperl/FeatureList.pm:
2781
2782 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2783
2784         Move PrettyPatch related code to prettypatch.py
2785         https://bugs.webkit.org/show_bug.cgi?id=124937
2786
2787         Reviewed by Ryosuke Niwa.
2788
2789         This code seems to have a better place here than in Port, since PrettyPatch already knows
2790         pretty_patch_path, and this also unifies the usage of PrettyPatch
2791
2792         * Scripts/webkitpy/common/prettypatch.py:
2793         (PrettyPatch.__init__):
2794         (PrettyPatch.pretty_diff):
2795         (PrettyPatch):
2796         (PrettyPatch.pretty_patch_available):
2797         (PrettyPatch.check_pretty_patch):
2798         (PrettyPatch.pretty_patch_text):
2799         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2800         (TestResultWriter.create_text_diff_and_write_result):
2801         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2802         (summarize_results):
2803         * Scripts/webkitpy/port/base.py:
2804         (Port.__init__):
2805         (Port.wdiff_available):
2806         (Port.check_image_diff):
2807         (Port.wdiff_text):
2808         * Scripts/webkitpy/port/base_unittest.py:
2809         (PortTest.test_pretty_patch_os_error):
2810         (PortTest.test_pretty_patch_script_error):
2811
2812 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2813
2814         Checkout should own the scm object in Host
2815         https://bugs.webkit.org/show_bug.cgi?id=124943
2816
2817         Reviewed by Ryosuke Niwa.
2818
2819         * Scripts/webkitpy/common/host.py:
2820         (Host.__init__):
2821         (Host.initialize_scm):
2822         (Host.scm):
2823
2824 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
2825
2826         Do bytecode validation as part of testing
2827         https://bugs.webkit.org/show_bug.cgi?id=124913
2828
2829         Reviewed by Oliver Hunt.
2830
2831         * Scripts/run-jsc-stress-tests:
2832
2833 2013-11-27  Andres Gomez  <agomez@igalia.com>
2834
2835         [GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
2836         https://bugs.webkit.org/show_bug.cgi?id=124940
2837
2838         Reviewed by Martin Robinson.
2839
2840         xserver-font-utils is needed for building gtk port dependencies
2841         with jhbuild.
2842
2843         * gtk/install-dependencies: Added xserver-font-utils to jhbuild
2844         dependecies.
2845
2846 2013-11-27  Andres Gomez  <agomez@igalia.com>
2847
2848         [GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
2849         https://bugs.webkit.org/show_bug.cgi?id=124938
2850
2851         Reviewed by Philippe Normand.
2852
2853         Added needed git dependency for building the gtk port with
2854         jhbuild. Also, the dependencies needed for building the gtk port
2855         are now sorted alphabetically.
2856
2857         * gtk/install-dependencies: Added git as jhbuild dependency and
2858         sorted dependencies alphabetically.
2859
2860 2013-11-27  Jozsef Berta  <jberta@inf.u-szeged.hu>
2861
2862         run_webkit_tests.py: error: no such option: --wincairo
2863         https://bugs.webkit.org/show_bug.cgi?id=124927
2864
2865         Reviewed by Ryosuke Niwa.
2866
2867         * BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports
2868         the layout testing on wincairo, so it is turned off.
2869
2870 2013-11-26  Marcelo Lira  <marcelo.lira@openbossa.org>
2871
2872         Nix upstreaming - Adding build files and supporting scripts
2873         https://bugs.webkit.org/show_bug.cgi?id=118367
2874
2875         Reviewed by Ryosuke Niwa.
2876
2877         * Scripts/build-webkit:
2878         * Scripts/run-nix-tests: Added.
2879         * Scripts/run-webkit-tests:
2880         * Scripts/update-webkit-libs-jhbuild:
2881         * Scripts/update-webkitnix-libs: Added.
2882         * Scripts/webkitdirs.pm:
2883         (determineArchitecture):
2884         (argumentsForConfiguration):
2885         (jscProductDir):
2886         (builtDylibPathForName):
2887         (determineIsNix):
2888         (isNix):
2889         (isAppleWebKit):
2890         (launcherPath):
2891         (launcherName):
2892         (checkRequiredSystemConfig):
2893         (copyInspectorFrontendFiles):
2894         (jhbuildWrapperPrefixIfNeeded):
2895         (buildCMakeProjectOrExit):
2896         (cmakeBasedPortName):
2897         * Scripts/webkitpy/common/config/ports.py:
2898         (DeprecatedPort.port):
2899         (EflWK2Port.build_webkit_command):
2900         (NixPort):
2901         (NixPort.build_webkit_command):
2902         * Scripts/webkitpy/port/factory.py:
2903         (platform_options):
2904         (PortFactory):
2905         * Scripts/webkitpy/port/nix.py: Added.
2906         (NixPort):
2907         (NixPort._wk2_port_name):
2908         (NixPort.determine_full_port_name):
2909         (NixPort.__init__):
2910         (NixPort._port_flag_for_scripts):
2911         (NixPort.setup_test_run):
2912         (NixPort.setup_environ_for_server):
2913         (NixPort.default_timeout_ms):
2914         (NixPort.clean_up_test_run):
2915         (NixPort._generate_all_test_configurations):
2916         (NixPort._path_to_driver):
2917         (NixPort._path_to_image_diff):
2918         (NixPort._image_diff_command):
2919         (NixPort._search_paths):
2920         (NixPort.show_results_html_file):
2921         (NixPort._port_specific_expectations_files):
2922         (NixPort.default_baseline_search_path):
2923         * Scripts/webkitpy/port/nix_unittest.py: Added.
2924         (NixPortTest):
2925         (NixPortTest._assert_search_path):
2926         (NixPortTest._assert_expectations_files):
2927         (NixPortTest.test_baseline_search_path):
2928         (NixPortTest.test_expectations_files):
2929         (NixPortTest.test_default_timeout_ms):
2930         * jhbuild/jhbuild-wrapper:
2931         (determine_platform):
2932         * nix/common.py: Added.
2933         (script_path):
2934         (top_level_path):
2935         * nix/jhbuild.modules: Added.
2936         * nix/jhbuildrc: Added.
2937
2938 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2939
2940         Record subtest values in Dromaeo tests
2941         https://bugs.webkit.org/show_bug.cgi?id=124498
2942
2943         Reviewed by Andreas Kling.
2944
2945         Supported parsing subtest results.
2946
2947         * Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of
2948         which contains a dictionary with its name and an ordered list of subtest's metrics.
2949         (PerfTest.__init__): Initialize _metrics as a list.
2950         (PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
2951         (PerfTest._run_with_driver):
2952         (PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.
2953
2954         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2955         (TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
2956         (TestPerfTest.test_parse_output): Ditto.
2957         (TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
2958         assertions to ensure subtest results are parsed properly.
2959         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
2960         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.
2961
2962         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2963         (_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
2964         incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
2965         adding new results.
2966
2967         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2968         (TestWithSubtestsData): Added.
2969         (TestDriver.run_test):
2970         (MainTest.test_run_test_with_subtests): Added.
2971
2972 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2973
2974         Enable HTML template element on Windows ports
2975         https://bugs.webkit.org/show_bug.cgi?id=124758
2976
2977         Reviewed by Andreas Kling.
2978
2979         * Scripts/webkitperl/FeatureList.pm:
2980
2981 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2982
2983         Remove replay performance tests as it's not actively maintained
2984         https://bugs.webkit.org/show_bug.cgi?id=124764
2985
2986         Reviewed by Andreas Kling.
2987
2988         Removed the feature.
2989
2990         * Scripts/webkitpy/performance_tests/perftest.py:
2991         (SingleProcessPerfTest.__init__):
2992         (PerfTestFactory):
2993         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2994         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2995         (PerfTestsRunner._parse_args):
2996         (PerfTestsRunner._collect_tests):
2997         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2998         (MainTest.test_collect_tests_with_ignored_skipped_list):
2999         (MainTest.test_default_args):
3000         * Scripts/webkitpy/thirdparty/__init__.py:
3001         (AutoinstallImportHook.find_module):
3002         (AutoinstallImportHook._install_unittest2):
3003         * Scripts/webkitpy/thirdparty/__init___unittest.py:
3004         (ThirdpartyTest.test_imports):
3005
3006 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
3007
3008         Enable aggressive DFG validation in testing
3009         https://bugs.webkit.org/show_bug.cgi?id=124911
3010
3011         Rubber stamped by Ryosuke Niwa.
3012         
3013         This enables validation testing in non-concurrent-JIT runs.
3014
3015         * Scripts/run-jsc-stress-tests:
3016
3017 2013-11-26  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3018
3019         Moved methods which belong to Checkout into checkout.py
3020         https://bugs.webkit.org/show_bug.cgi?id=124889
3021
3022         Reviewed by Ryosuke Niwa.
3023
3024         * Scripts/webkitpy/common/checkout/checkout.py:
3025         (Checkout.scripts_directory):
3026         (Checkout):
3027         (Checkout.script_path):
3028         (Checkout.commit_message_for_this_commit):
3029         (Checkout.apply_patch):
3030         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3031         (test_commit_message_for_this_commit):
3032         (CheckoutTest.test_apply_patch):
3033         * Scripts/webkitpy/common/checkout/scm/scm.py:
3034         (SCM.absolute_path):
3035         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3036         (SCMTest._setup_webkittools_scripts_symlink):
3037         * Scripts/webkitpy/common/checkout/scm/svn.py:
3038         (SVN.create_patch):
3039
3040 2013-11-25  Ryuan Choi  <ryuan.choi@samsung.com>
3041
3042         [EFL] Use Config mode of find_package for EFL 1.8
3043         https://bugs.webkit.org/show_bug.cgi?id=124555
3044
3045         Reviewed by Gyuyoung Kim.
3046
3047         * MiniBrowser/efl/CMakeLists.txt:
3048         Added optional config mode and made version requirement optional.
3049
3050 2013-11-25  Andres Gomez  <agomez@igalia.com>
3051
3052         [GTK] Search functionality in MiniBrowser provides feedback on search fail
3053         https://bugs.webkit.org/show_bug.cgi?id=122681
3054
3055         Reviewed by Mario Sanchez Prada.
3056
3057         When using the search functionality in MiniBrowser, if the search
3058         fails, the entry background color gets red to report the user
3059         about the failing condition. When the entry is cleaned or the
3060         search is again succesful the background turns back to its
3061         original color.
3062
3063         * MiniBrowser/gtk/BrowserSearchBar.c:
3064         (setFailedStyleForEntry): Added.
3065         (doSearch): Sets the entry's background to its original style if
3066         there is no text to search.
3067         (findControllerFailedToFindTextCallback): Added.
3068         (findControllerFoundTextCallback): Added.
3069         (browser_search_bar_init): Creates and adds a new CSS provider to
3070         the text entry so we can change its style based on the success
3071         condition of the search.
3072         (browserSearchBarFinalize): Frees the new CSS provider.
3073         (browser_search_bar_new): Connects the two new handlers to the
3074         "failed-to-find-text" and "found-text" signals emitted by the
3075         WebKitFindController.
3076
3077 2013-11-25  Dan Bernstein  <mitz@apple.com>
3078
3079         [Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
3080         https://bugs.webkit.org/show_bug.cgi?id=124850
3081
3082         Reviewed by Brady Eidson.
3083
3084         Added #if WK_API_ENABLED guards around tests that use the Objective-C API.
3085
3086         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3087         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3088         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3089         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3090         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3091         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
3092         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3093
3094 2013-11-25  Commit Queue  <commit-queue@webkit.org>
3095
3096         Unreviewed, rolling out r159752 and r159754.
3097         http://trac.webkit.org/changeset/159752
3098         http://trac.webkit.org/changeset/159754
3099         https://bugs.webkit.org/show_bug.cgi?id=124847
3100
3101         Broke linux test bots. (Requested by mhahnenberg on #webkit).
3102
3103         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
3104         * Scripts/run-javascriptcore-tests:
3105         * Scripts/run-jsc-stress-tests:
3106
3107 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
3108
3109         Followup fix after r159752
3110
3111         * Scripts/run-jsc-stress-tests: We need to handle Release builds too.
3112
3113 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
3114
3115         run-jsc-stress-tests should be able to package its tests and move them places
3116         https://bugs.webkit.org/show_bug.cgi?id=124549
3117
3118         Reviewed by Filip Pizlo.
3119
3120         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation 
3121         of grep -i -q
3122         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
3123         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory. 
3124         We now also copy whatever VM was specified, along with its associated framework, into this directory. 
3125         All of the generated scripts now are completely relative within the results directory. This allows 
3126         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a 
3127         tarball of the generated results directory. Also refactored several portions of the script into 
3128         separate functions to make it easier to run them conditionally depending on which mode we're running in.
3129
3130 2013-11-25  László Langó  <lango@inf.u-szeged.hu>
3131
3132         EWS creates 0 byte sized log files
3133         https://bugs.webkit.org/show_bug.cgi?id=107606
3134
3135         Reviewed by Ryosuke Niwa.
3136
3137         There was a modification in r138264, that tried to make less log,
3138         because some of the messeges were duplicated. After this the EWS
3139         created the log file (with the same name as the bugID) but doesn't
3140         write anything into it, even if there were errors during the build.
3141         From now only creates the log file only if there is some error.
3142
3143         * Scripts/webkitpy/tool/bot/queueengine.py:
3144         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
3145         there is nothing to log. Open the log file only if a ScriptError was raised to
3146         avoid to make empty log files for bugs.
3147         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
3148         because of changes in r138264. Teeing is used for locally testing purposes and
3149         this feature is not used anymore.
3150         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
3151         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
3152         change.
3153         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3154         (LoggingDelegate): The order of the callbacks was changed by this patch.
3155         (QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
3156         so we have to update this test.
3157         (QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
3158         this patch.
3159         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3160         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
3161         to be able to handle it in QueueEngine.run. Without this change, the existing
3162         exception handler never run (the process_work_item method never raise ScriptError)
3163         We can get the error message only from the ScriptError at this point.
3164
3165 2013-11-22  Dean Jackson  <dino@apple.com>
3166
3167         Speculative Mountain Lion build fix.
3168
3169         * MiniBrowser/mac/AppDelegate.m:
3170         (-[BrowserAppDelegate openDocument:]):
3171
3172 2013-11-22  Anders Carlsson  <andersca@apple.com>
3173
3174         Fix Mountain Lion bug.
3175
3176         * MiniBrowser/mac/AppDelegate.m:
3177         (-[BrowserAppDelegate openDocument:]):
3178
3179 2013-11-22  Anders Carlsson  <andersca@apple.com>
3180
3181         MiniBrowser should use the blocks-based NSOpenPanel API
3182         https://bugs.webkit.org/show_bug.cgi?id=124786
3183
3184         Reviewed by Simon Fraser.
3185
3186         * MiniBrowser/mac/AppDelegate.m:
3187         (-[BrowserAppDelegate frontmostBrowserWindowController]):
3188         Account for windows that don't have a BrowserWindowController.
3189
3190         (-[BrowserAppDelegate openDocument:]):
3191
3192 2013-11-22  Commit Queue  <commit-queue@webkit.org>
3193
3194         Unreviewed, rolling out r159690.
3195         http://trac.webkit.org/changeset/159690
3196         https://bugs.webkit.org/show_bug.cgi?id=124782
3197
3198         Broke webkitpy tests (Requested by ap on #webkit).
3199
3200         * Scripts/webkitpy/tool/bot/queueengine.py:
3201         (QueueEngine.run):
3202         (QueueEngine._open_work_log):
3203         (QueueEngine._ensure_work_log_closed):
3204         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3205         (AbstractEarlyWarningSystem.review_patch):
3206
3207 2013-11-22  László Langó  <lango@inf.u-szeged.hu>
3208
3209         EWS creates 0 byte sized log files
3210         https://bugs.webkit.org/show_bug.cgi?id=107606
3211
3212         Reviewed by Ryosuke Niwa.
3213
3214         There was a modification in r138264, that tried to make less log, 
3215         because some of the messeges were duplicated. After this the EWS 
3216         created the log file (with the same name as the bugID) but doesn't 
3217         write anything into it, even if there were errors during the build. 
3218         From now only creates the log file only if there is some error.
3219
3220         * Scripts/webkitpy/tool/bot/queueengine.py:
3221         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
3222         there is nothing to log. Open the log file only if a ScriptError was raised to
3223         avoid to make empty log files for bugs.
3224         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
3225         because of changes in r138264. Teeing is used for locally testing purposes and
3226         this feature is not used anymore.
3227         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output 
3228         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
3229         change.
3230         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3231         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
3232         to be able to handle it in QueueEngine.run. Without this change, the existing
3233         exception handler never run (the process_work_item method never raise ScriptError)
3234         We can get the error message only from the ScriptError at this point.
3235
3236 2013-11-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3237
3238         Remove ENABLE_WORKERS
3239         https://bugs.webkit.org/show_bug.cgi?id=105784
3240
3241         Reviewed by Darin Adler.
3242
3243         * Scripts/webkitperl/FeatureList.pm:
3244
3245 2013-11-21  Darin Adler  <darin@apple.com>
3246
3247         Try to fix buildbot Dashboard for people who have not hidden anything.
3248
3249         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3250         Add a null check for hidden platforms.
3251
3252 2013-11-21  Peter Szanka  <h868064@stud.u-szeged.hu>
3253
3254         Remove chrome/chromium related things from webkitpy.
3255         https://bugs.webkit.org/show_bug.cgi?id=124493
3256
3257         Reviewed by Darin Adler.
3258
3259         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3260         (PortTest.assert_mock_port_works):
3261         * Scripts/webkitpy/port/base.py:
3262         (Port.to.setup_environ_for_server):
3263         * Scripts/webkitpy/port/mac_unittest.py:
3264         (test_tests_for_other_platforms):
3265         * Scripts/webkitpy/port/mock_drt.py:
3266         (MockTestShell.output_for_test):
3267         * Scripts/webkitpy/tool/bot/irc_command.py:
3268         (Restart.execute):
3269         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3270         (IRCBotTest.test_help):
3271
3272 2013-11-21  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3273
3274         In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
3275         https://bugs.webkit.org/show_bug.cgi?id=124717
3276
3277         Reviewed by Ryosuke Niwa.
3278
3279         * Scripts/webkitpy/style/filereader.py:
3280         (TextFileReader.process_file):
3281         * Scripts/webkitpy/style/filereader_unittest.py:
3282         (TextFileReaderTest.test_process_file__does_not_exist):
3283
3284 2013-11-21  Mark Rowe  <mrowe@apple.com>
3285
3286         <https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
3287
3288         All modern versions of Xcode set it appropriately for our needs.
3289
3290         Reviewed by Alexey Proskuryakov.
3291
3292         * MiniBrowser/Configurations/Base.xcconfig:
3293         * WebKitTestRunner/Configurations/Base.xcconfig:
3294
3295 2013-11-21  Nick Diego Yamane  <nick.yamane@openbossa.org>
3296
3297         webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
3298         https://bugs.webkit.org/show_bug.cgi?id=124676
3299
3300         Reviewed by Daniel Bates.
3301
3302         checkForArgumentAndRemoveFromArrayRef functions was removing wrong
3303         elements when there were more then one occurrence of that argument.
3304         E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
3305         {b, a}, when it should be {b, c}.
3306
3307         * Scripts/webkitdirs.pm:
3308         (checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
3309         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
3310         Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
3311
3312 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
3313
3314         Update build-webkit after r159550.
3315
3316         * Scripts/webkitperl/FeatureList.pm:
3317
3318 2013-11-21  Lucas Forschler  <lforschler@apple.com>
3319
3320         Bring a new bot online, replacing the previous ones.
3321         
3322         Unreviewed.
3323
3324         * BuildSlaveSupport/build.webkit.org-config/config.json:
3325
3326 2013-11-21  Dean Jackson  <dino@apple.com>
3327
3328         Don't fetch hidden platforms on build.webkit.org/dashboard
3329         https://bugs.webkit.org/show_bug.cgi?id=124750
3330
3331         Reviewed by Tim Horton.
3332
3333         If a platform is hidden, don't fetch its data. If it
3334         becomes unhidden, try to fetch immediately (unless
3335         you've recently fetched).
3336
3337         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3338         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3339
3340 2013-11-21  Commit Queue  <commit-queue@webkit.org>
3341
3342         Unreviewed, rolling out r159633.
3343         http://trac.webkit.org/changeset/159633
3344         https://bugs.webkit.org/show_bug.cgi?id=124726
3345
3346         it broke 10 webkitpy tests (Requested by dino_ on #webkit).
3347
3348         * Scripts/webkitpy/style/checker.py:
3349         (check_webkit_style_configuration):
3350         (CheckerDispatcher.dispatch):
3351         (StyleProcessorConfiguration):
3352         (StyleProcessorConfiguration.__init__):
3353         (StyleProcessorConfiguration.write_style_error):
3354
3355 2013-11-21  László Langó  <lango@inf.u-szeged.hu>
3356
3357         Remove the stderr_write attribute from StyleProcessorConfiguration.
3358         https://bugs.webkit.org/show_bug.cgi?id=124703
3359
3360         Reviewed by Brent Fulgham.
3361
3362         * Scripts/webkitpy/style/checker.py:
3363         (check_webkit_style_configuration):
3364         (CheckerDispatcher.dispatch):
3365         (StyleProcessorConfiguration):
3366         (StyleProcessorConfiguration.__init__):
3367         (StyleProcessorConfiguration.write_style_error):
3368
3369 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
3370
3371         PerfTestRunner._generate_results_dict shouldn't depend on test objects
3372         https://bugs.webkit.org/show_bug.cgi?id=124623
3373
3374         Removed the dependency on test objects from results JSON generation.
3375         This allows single test.run to return metrics for multiple tests
3376
3377         Reviewed by Antti Koivisto.
3378
3379         * Scripts/webkitpy/performance_tests/perftest.py:
3380         (PerfTestMetric.__init__): Takes the test path and test name.
3381         (PerfTestMetric.path): Added.
3382         (PerfTestMetric.test_file_name): Added.
3383         (PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
3384         (PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
3385         The path is going to have the names of subtests at the end once we support them.
3386
3387         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3388         (TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
3389         (TestPerfTestMetric.test_init_set_time_metric): Ditto.
3390         (TestPerfTestMetric.test_has_values): Ditto.
3391         (TestPerfTestMetric.test_append): Ditto.
3392
3393         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3394         (_generate_results_dict): Only use metrics.
3395         (_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.
3396
3397 2013-11-21  Manuel Rego Casasnovas  <rego@igalia.com>
3398
3399         REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
3400         https://bugs.webkit.org/show_bug.cgi?id=124697
3401
3402         Reviewed by Ryosuke Niwa.
3403
3404         * Scripts/webkitdirs.pm:
3405         (checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
3406         before trying to access to the first element.
3407
3408 2013-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3409
3410         [GTK] Mark all deprecated symbols in GObject DOM bindings
3411         https://bugs.webkit.org/show_bug.cgi?id=124406
3412
3413         Reviewed by Gustavo Noronha Silva.
3414
3415         * Scripts/webkitpy/style/checker.py: Add special case for
3416         WebKitDOMDeprecated.
3417         * gtk/generate-gtkdoc:
3418         (get_webkit2_options): Use the prefix of the methods as namespace,
3419         since this is what gtkdoc expects to sort the index.
3420         (get_webkit1_options): Ditto.
3421         (get_webkitdom_options): Ditto.
3422         * gtk/generate-webkitdom-doc-files:
3423         (WebKitDOMDocGenerator): Add a global list of deleted objects.
3424         (WebKitDOMDocGenerator.write_deleted_classes): New method to write
3425         the documentation for classes that are deprecated because they
3426         have been removed.
3427         (WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
3428         for deleted classes too.
3429         (WebKitDOMDocGeneratorSections.__init__): Build a list of
3430         deprecated symbols using the given symbols file.
3431         (WebKitDOMDocGeneratorSections._deleted_class): Returns the
3432         deleted class corresponding to the given function.
3433         (WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
3434         dictionary of deprecated symbols for every class.
3435         (WebKitDOMDocGeneratorSections.write_section): Add also the
3436         deprecated symbols in every section.
3437         (WebKitDOMDocGeneratorSections.write_deleted_classes): Add
3438         sections for deleted classes too.
3439
3440 2013-11-20  László Langó  <lango@inf.u-szeged.hu>
3441
3442         check-webkit-style should support C++11 rvalue references.
3443         https://bugs.webkit.org/show_bug.cgi?id=123406
3444
3445         Reviewed by Brent Fulgham.
3446
3447         * Scripts/webkitpy/style/checkers/cpp.py:
3448         (check_style):
3449         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3450         (Cpp11StyleTest):
3451         (Cpp11StyleTest.test_rvaule_reference_at_end_of_line):
3452
3453 2013-11-20  Dean Jackson  <dino@apple.com>
3454
3455         Allow settings to be shown/hidden on build.webkit.org/dashboard
3456         https://bugs.webkit.org/show_bug.cgi?id=124694
3457
3458         Reviewed by Tim Horton.
3459
3460         In preparation for more options/buttons, allow the page to
3461         show or hide all the interactive things using a little gear icon
3462         in the top left corner.
3463
3464         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3465         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3466         (Settings.prototype.toggleSettingsDisplay):
3467         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3468         (div.cellButton.hide):
3469         (div.cellButton.unhide):
3470         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
3471         (.settings):
3472         (.settings:hover):
3473         (.settings-visible .settings):
3474
3475 2013-11-20  Dean Jackson  <dino@apple.com>
3476
3477         No need to base64 SVG on build.webkit.org/dashboard
3478         https://bugs.webkit.org/show_bug.cgi?id=124687
3479
3480         Reviewed by Tim Horton.
3481
3482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3483         (.status-line.good .bubble.pictogram):
3484
3485 2013-11-20  Dean Jackson  <dino@apple.com>
3486
3487         Make links look more like links on build.webkit.org/dashboard
3488         https://bugs.webkit.org/show_bug.cgi?id=124686
3489
3490         Reviewed by Tim Horton.
3491
3492         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
3493         (.queue-view .queueLabel:hover):
3494         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3495         (.status-line.linked .label:hover):
3496
3497 2013-11-20  Nick Diego Yamane  <nick.yamane@openbossa.org>
3498
3499         Modify webkitdirs to reuse checkForArgumentAndRemoveFromARGV
3500         https://bugs.webkit.org/show_bug.cgi?id=124581
3501
3502         Reviewed by Daniel Bates.
3503
3504         Some subroutines are replicating code from checkForArgument**
3505         functions instead of reusing them as is being done by all other functions.
3506
3507         * Scripts/webkitdirs.pm:
3508         (determineXcodeSDK): Added.
3509         (determinePassedConfiguration): Added.
3510         (determinePassedArchitecture): Added.
3511         (checkForArgumentAndRemoveFromARGV): Added.
3512         (checkForArgumentAndRemoveFromARGVGettingValue): Added.
3513
3514 2013-11-20  Jozsef Berta  <jberta@inf.u-szeged.hu>
3515
3516         Delete baseline optimizer
3517         https://bugs.webkit.org/show_bug.cgi?id=122333
3518
3519         Reviewed by Ryosuke Niwa.
3520
3521         * Scripts/webkitpy/common/checkout/baselineoptimizer.py: Removed.
3522         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: Removed.
3523         * Scripts/webkitpy/tool/commands/rebaseline.py:
3524         (RebaselineTest.execute):
3525         (AbstractParallelRebaselineCommand._files_to_add):
3526         (AbstractParallelRebaselineCommand._rebaseline):
3527         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3528         (TestRebaselineJson.test_rebaseline_all):
3529         (TestRebaselineJson.test_rebaseline_debug):
3530         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
3531
3532 2013-11-20  Anders Carlsson  <andersca@apple.com>
3533
3534         Enable PageLoadTest assertions again
3535         https://bugs.webkit.org/show_bug.cgi?id=124681
3536
3537         Reviewed by Tim Horton.
3538
3539         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3540         Actually install all-content-in-one-iframe.html, noticed while debugging this assertion.
3541
3542 2013-11-20  Mark Rowe  <mrowe@apple.com>
3543
3544         Remove some obsolete logic from WebKit.app.
3545
3546         Reviewed by Alexey Proskuryakov.
3547
3548         * WebKitLauncher/WebKitNightlyEnabler.m:
3549         (poseAsWebKitApp): Remove a pre-10.6 codepath.
3550         (enableWebKitNightlyBehaviour): Remove a 10.4-specific codepath.
3551
3552 2013-11-20  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3553
3554         Moved stray urls from svn.py and statusserver.py into common.config.urls
3555         https://bugs.webkit.org/show_bug.cgi?id=124650
3556
3557         Reviewed by Ryosuke Niwa.
3558
3559         * Scripts/webkitpy/common/checkout/scm/svn.py:
3560         (SVNRepository):
3561         * Scripts/webkitpy/common/config/urls.py:
3562         * Scripts/webkitpy/common/net/statusserver.py:
3563         (StatusServer.__init__):
3564         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3565         (_generate_results_dict):
3566
3567 2013-11-20  Commit Queue  <commit-queue@webkit.org>
3568
3569         Unreviewed, rolling out r159496.
3570         http://trac.webkit.org/changeset/159496
3571         https://bugs.webkit.org/show_bug.cgi?id=124641
3572
3573         It caused warning and build break with cmake lower than 2.8.8
3574         (Requested by ryuan on #webkit).
3575
3576         * MiniBrowser/efl/CMakeLists.txt:
3577
3578 2013-11-20  Gabor Rapcsanyi  <rgabor@webkit.org>
3579
3580         [EFL] libseccomp-2.0.0 doesn't support ARM architecture
3581         https://bugs.webkit.org/show_bug.cgi?id=124412
3582
3583         Reviewed by Gyuyoung Kim.
3584
3585         Update libseccomp to a newer 2.1.0 version.
3586
3587         * efl/jhbuild.modules:
3588
3589 2013-11-19  Mark Rowe  <mrowe@apple.com>
3590
3591         <rdar://problem/15487072> Modernize WebKit.app's OS X version checking logic.
3592
3593         Gestalt is deprecated on recent OS X versions so we should switch off it.
3594
3595         Reviewed by Sam Weinig.
3596
3597         * WebKitLauncher/main.m:
3598         (currentMacOSXVersion): Retrieve the version string from SystemVersion.plist.
3599         (currentMacOSXMajorVersion): Split the version string at the periods, retrieve the first
3600         two components, then join them back up.
3601         (main): Switch to using currentMacOSXMajorVersion to make it clearer which part of
3602         the version we care about.
3603
3604 2013-11-19  Commit Queue  <commit-queue@webkit.org>
3605
3606         Unreviewed, rolling out r159538.
3607         http://trac.webkit.org/changeset/159538
3608         https://bugs.webkit.org/show_bug.cgi?id=124627
3609
3610         it broke run-jsc-stress-tests (Requested by mhahnenberg on
3611         #webkit).
3612
3613         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
3614         * Scripts/run-javascriptcore-tests:
3615         * Scripts/run-jsc-stress-tests:
3616
3617 2013-11-19  Mark Hahnenberg  <mhahnenberg@apple.com>
3618
3619         run-jsc-stress-tests should be able to package its tests and move them places
3620         https://bugs.webkit.org/show_bug.cgi?id=124549
3621
3622         Reviewed by Geoff Garen and Filip Pizlo.
3623
3624         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. This script was just a ruby reimplementation 
3625         of grep -i -q 
3626         * Scripts/run-javascriptcore-tests: Pass through the --make-bundle flag.
3627         * Scripts/run-jsc-stress-tests: Added the new concept of a "bundle", which is a collection of all tests and any
3628         other files that those tests require to run in any environment along with a fixed root directory into which these
3629         files and their expected directory structure are cloned. The default Bundle class is basically 
3630         a no-op so that it functions like run-jsc-stress-tests prior to this patch. MovableBundle is a Bundle that knows 
3631         how to translate local paths to bundle paths and does all the work of moving each test file into the right place 
3632         inside the .tests directory. After all the test files have been created in jsc-stress-results MovableBundle 
3633         creates a tarball of the entire directory for easy relocation. The --make-bundle flag causes run-jsc-stress-tests 
3634         to use MovableBundle instead of just Bundle. 
3635
3636 2013-11-19  Dan Bernstein  <mitz@apple.com>
3637
3638         <rdar://problem/15139479> Reenable the JSC Objective-C API tests on Mountain Lion once the bots are running Xcode 5
3639
3640         Rubber-stamped by Mark Rowe.
3641
3642         Reverted r156840.
3643
3644         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
3645
3646 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
3647
3648         Yet another build fix. Just allow any character.
3649         There are just too many special characters to be listed here.
3650
3651         * Scripts/webkitpy/performance_tests/perftest.py:
3652         (PerfTest._lines_to_ignore_in_parser_result):
3653         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3654         (TestPerfTest.test_parse_output_with_subtests)
3655