[Chromium] Fix broken DRT build for Aura Linux
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
2
3         [Chromium] Fix broken DRT build for Aura Linux
4         https://bugs.webkit.org/show_bug.cgi?id=72667
5
6         Reviewed by Tony Chang.
7
8         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
9
10         The following changes have been made:
11
12           1. Renamed TestShellAndroid to TestShellLinux.
13           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
14           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
15
16         * DumpRenderTree/DumpRenderTree.gypi:
17         * DumpRenderTree/chromium/EventSender.cpp:
18         (EventSender::keyDown):
19         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
20         * DumpRenderTree/chromium/TestShellGtk.cpp:
21         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
22         (AlarmHandler):
23         (TestShell::waitTestFinished):
24         (setupFontconfig):
25         (platformInit):
26         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
27         (checkLayoutTestSystemDependencies):
28         (openStartupDialog):
29
30 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
31
32         [Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController
33         https://bugs.webkit.org/show_bug.cgi?id=73328
34
35         Reviewed by Kent Tamura.
36
37         * DumpRenderTree/chromium/LayoutTestController.cpp:
38         (LayoutTestController::enableFixedLayoutMode):
39         (LayoutTestController::setFixedLayoutSize):
40
41 2011-11-29  Hayato Ito  <hayato@chromium.org>
42
43         Skip writing the result of diff_image since non-chromium ports don't implement diff_image.
44         https://bugs.webkit.org/show_bug.cgi?id=73381
45
46         Reviewed by Ryosuke Niwa.
47
48         This is a quick fix for the breakage of tests on non-chromium port.
49         We should implement diff_image later on non-chromium ports.
50
51         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
52         (write_test_result):
53
54 2011-11-29  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
55
56         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
57         https://bugs.webkit.org/show_bug.cgi?id=72489
58
59         Reviewed by Eric Seidel.
60
61         Before the this fix always added "qt" option for the option list
62         * Scripts/run-webkit-tests:
63         * Scripts/webkitpy/layout_tests/port/qt.py:
64
65 2011-11-29  David Levin  <levin@chromium.org>
66
67         Add a way to revert a variable to its previous value after leaving a scope.
68         https://bugs.webkit.org/show_bug.cgi?id=73371
69
70         Reviewed by Adam Barth.
71
72         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Added.
73         * TestWebKitAPI/TestWebKitAPI.gypi: Added test file to the build.
74         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
75         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
76         * TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp: Added.
77         (TestWebKitAPI::TEST): Added a test for TemporarilyChange.
78
79 2011-11-28  Kentaro Hara  <haraken@chromium.org>
80
81         Implement [Supplemental] IDL and support it in run-bindings-tests
82         https://bugs.webkit.org/show_bug.cgi?id=73162
83
84         Reviewed by Adam Barth.
85
86         run-bindings-tests supports the [Supplemental] IDL in the following way.
87             (1) It creates a file |x| listing all IDL files.
88             (2) It generates a supplemental dependency file |y| using resolve-supplemental.pl and |x|.
89             (3) For each IDL file |z|, it runs generate-bindings.pl with |y|.
90                 Then, generate-bindings.pl generates .h and .cpp files for the IDL file |z|,
91                 including all attributes in IDL files that are supplementing the IDL file |z|.
92
93         * Scripts/run-bindings-tests:
94         (generate_from_idl):
95         (generate_supplemental_dependency):
96         (detect_changes):
97         (run_tests):
98         (main):
99
100 2011-11-18  Nat Duca  <nduca@chromium.org>
101
102         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
103         https://bugs.webkit.org/show_bug.cgi?id=70838
104
105         Reviewed by James Robinson.
106
107         * DumpRenderTree/chromium/TestShell.cpp:
108         (TestShell::resetWebSettings):
109         * DumpRenderTree/chromium/TestShell.h:
110         (TestShell::threadedCompositingEnabled):
111         * DumpRenderTree/chromium/WebPreferences.cpp:
112         (WebPreferences::reset):
113         (WebPreferences::applyTo):
114         * DumpRenderTree/chromium/WebPreferences.h:
115         * DumpRenderTree/chromium/WebViewHost.cpp:
116         (WebViewHost::WebViewHost):
117         (WebViewHost::~WebViewHost):
118
119 2011-11-29  Ojan Vafai  <ojan@chromium.org>
120
121         List of builders in the flakiness dashboard is out of date
122         https://bugs.webkit.org/show_bug.cgi?id=73347
123
124         Reviewed by Adam Barth.
125
126         The chromium gpu bots no longer run layout tests, so kill that
127         group entirely.
128
129         * TestResultServer/static-dashboards/builders.js:
130         * TestResultServer/static-dashboards/dashboard_base.js:
131
132 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
133
134         [Qt] Don't hard-code the list of WebKit2 generated sources
135
136         The generated sources are... wait for it... generated. So
137         use the generator itself to figure out which sources we need
138         to compile.
139
140         Reviewed by Simon Hausmann.
141
142         * qmake/mkspecs/features/default_post.prf:
143
144 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
145
146         [GTK] Add a method to detect 'make dist' errors without running 'make dist'
147         https://bugs.webkit.org/show_bug.cgi?id=73216
148
149         Reviewed by Philippe Normand.
150
151         Add a script that tries to sniff out 'make dist' problems without running
152         'make dist.' 'make distcheck' takes a very long time to run and this should
153         reduce the amount of times it needs to be run consecutively.
154
155         * gtk/common.py:
156         (get_build_path.is_valid_build_directory): Guess the source directory
157         by the existence of the GNUmakefile instead of the .libs directory. This
158         allows one to run the script after running autogen.sh but before fully
159         building.
160         * gtk/find-make-dist-errors: Added.
161
162 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
163
164         [Qt] Remove use of internal headers in the MiniBrowser
165
166         Reviewed by Simon Hausmann.
167
168         * MiniBrowser/qt/MiniBrowser.pro:
169
170 2011-11-29  Simon Hausmann  <simon.hausmann@nokia.com>
171
172         [Qt] Fix debug-shlib build without webkit2
173
174         Reviewed by Tor Arne Vestbø.
175
176         * qmake/mkspecs/features/qtwebkit.prf: Respect no_webkit2.
177
178 2011-11-28  Csaba Osztrogonác  <ossy@webkit.org>
179
180         [Qt][WK2] Unreviewed buildfix after r101307.
181
182         * qmake/mkspecs/features/webkit2.prf: Add missing includepath.
183
184 2011-11-29  Roland Steiner  <rolandsteiner@chromium.org>
185
186         <style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit
187         https://bugs.webkit.org/show_bug.cgi?id=72848
188
189         Add option to build-webkit.
190
191         Reviewed by Dimitri Glazkov.
192
193         * Scripts/build-webkit:
194
195 2011-11-28  Ojan Vafai  <ojan@chromium.org>
196
197         gtest normalization in the test results server is sometimes wrong
198         https://bugs.webkit.org/show_bug.cgi?id=73262
199
200         Reviewed by Tony Chang.
201
202         If a gtest has it's modified changed (e.g. add FLAKY_) then it will have two
203         entries in the incremental JSON, one of the entries will have the correct data
204         from the run and the other will have dummy no-data values. Make sure to
205         always pick the one with real data.
206
207         * TestResultServer/model/jsonresults.py:
208         (JsonResults._remove_gtest_modifiers):
209         * TestResultServer/model/jsonresults_unittest.py:
210         (JsonResultsTest.test_remove_gtest_modifiers):
211
212 2011-11-28  Ojan Vafai  <ojan@chromium.org>
213
214         Some of the results.json files have results/times entries at the directory level
215         https://bugs.webkit.org/show_bug.cgi?id=73261
216
217         Reviewed by Tony Chang.
218
219         This is just a bug that got introduced in a temporary push of the results server.
220         This patch repairs the broken files. After all the bots have cycled, we can simplify
221         this code to just assert that results/times are not at the directory level.
222
223         Also, when catching exceptions, log the full stacktrace.
224
225         * TestResultServer/model/jsonresults.py:
226         (_is_directory):
227         (JsonResults._load_json):
228         (JsonResults._merge_tests):
229         (JsonResults.merge):
230         * TestResultServer/model/jsonresults_unittest.py:
231         (JsonResultsTest.test_merge_directory_hierarchy_extra_results_and_times):
232
233 2011-11-28  Tony Chang  <tony@chromium.org>
234
235         ews bots should pass --force to update-webkit-chromium
236         https://bugs.webkit.org/show_bug.cgi?id=73230
237
238         Reviewed by Adam Barth.
239
240         This makes it less likely for gclient changes to break the bots (e.g.,
241         if a DEPS repository moves or is switched to a branch).
242
243         Also pass --force when using |build-webkit --update-chromium| since this
244         appears to only be used by the bots.
245
246         Take 2: Add Options.non_interactive to update.py's options() method.
247
248         * Scripts/update-webkit:
249         * Scripts/webkitdirs.pm:
250         (determineIsChromium): Add --force-update to update-webkit --chromium.
251         (forceChromiumUpdate):
252         (buildChromium): Pass --force to update-webkit-chromium.
253         * Scripts/webkitpy/tool/steps/update.py:
254         (Update.run): Add --force-update if non-interactive (i.e., bots).
255         * Scripts/webkitpy/tool/steps/update_unittest.py:
256
257 2011-11-28  Tony Chang  <tony@chromium.org>
258
259         Revert r101279, broke the ews and cq bots.
260
261         * Scripts/update-webkit:
262         * Scripts/webkitdirs.pm:
263         (determineIsChromium):
264         (buildChromium):
265         * Scripts/webkitpy/common/config/ports.py:
266         (WebKitPort.update_webkit_command):
267         (ChromiumPort.update_webkit_command):
268         * Scripts/webkitpy/common/config/ports_mock.py:
269         (MockPort.update_webkit_command):
270         * Scripts/webkitpy/tool/steps/update.py:
271         * Scripts/webkitpy/tool/steps/update_unittest.py: Removed.
272
273 2011-11-28  Ojan Vafai  <ojan@chromium.org>
274
275         testlistjson on the test results server doesn't understand hierarchical results format
276         https://bugs.webkit.org/show_bug.cgi?id=73246
277
278         Reviewed by Tony Chang.
279
280         * TestResultServer/model/jsonresults.py:
281         (JsonResults._delete_results_and_times):
282         Instead of just getting the top-level keys, we now walk the tests tree and
283         delete the results and times values.
284
285         * TestResultServer/model/jsonresults_unittest.py:
286         Simplify the test harness to take in the same JSON format for the tests
287         that the actual results.json uses instead of something very similar but
288         needlessly different. This also allows for testing the broken case of
289         results and times values being at non-leaf level.
290
291 2011-11-28  Tony Chang  <tony@chromium.org>
292
293         ews bots should pass --force to update-webkit-chromium
294         https://bugs.webkit.org/show_bug.cgi?id=73230
295
296         Reviewed by Adam Barth.
297
298         This makes it less likely for gclient changes to break the bots (e.g.,
299         if a DEPS repository moves or is switched to a branch).
300
301         Also pass --force when using |build-webkit --update-chromium| since this
302         appears to only be used by the bots.
303
304         * Scripts/update-webkit:
305         * Scripts/webkitdirs.pm:
306         (determineIsChromium): Add --force-update to update-webkit --chromium.
307         (forceChromiumUpdate):
308         (buildChromium): Pass --force to update-webkit-chromium.
309         * Scripts/webkitpy/tool/steps/update.py:
310         (Update.run): Add --force-update if non-interactive (i.e., bots).
311         * Scripts/webkitpy/tool/steps/update_unittest.py:
312
313 2011-11-28  Michael Saboff  <msaboff@apple.com>
314
315         Fixed help message for --exclude-kraken to say that
316         it excludes Kraken and not SunSpider.
317
318         Rubber-stamped by Filip Pizlo.
319
320         * Scripts/bencher:
321
322 2011-11-28  Sheriff Bot  <webkit.review.bot@gmail.com>
323
324         Unreviewed, rolling out r101273.
325         http://trac.webkit.org/changeset/101273
326         https://bugs.webkit.org/show_bug.cgi?id=73244
327
328         multiple test failures and timeouts (Requested by tony^work on
329         #webkit).
330
331         * DumpRenderTree/DumpRenderTree.gypi:
332         * DumpRenderTree/chromium/EventSender.cpp:
333         (EventSender::keyDown):
334         * DumpRenderTree/chromium/TestShellAndroid.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
335         (AlarmHandler):
336         (TestShell::waitTestFinished):
337         (platformInit):
338         (openStartupDialog):
339         (checkLayoutTestSystemDependencies):
340         * DumpRenderTree/chromium/TestShellGtk.cpp:
341         (AlarmHandler):
342         (setupFontconfig):
343         (TestShell::waitTestFinished):
344         (platformInit):
345         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed.
346         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
347
348 2011-11-28  John Yani  <vanuan@gmail.com>
349
350         new-run-webkit-tests is locale dependent
351         https://bugs.webkit.org/show_bug.cgi?id=68691
352
353         Reviewed and modified by Eric Seidel.
354
355         This is a simpler version of John's patch which I'm landing.
356         This just engages the hacks from the Host constructor on a global
357         basis.
358
359         * Scripts/webkitpy/common/host.py:
360         (Host.__init__):
361         (Host._engage_awesome_locale_hacks):
362
363 2011-11-28  Fady Samuel  <fsamuel@chromium.org>
364
365         [Chromium] Fix broken DRT build for Aura Linux
366         https://bugs.webkit.org/show_bug.cgi?id=72667
367
368         Reviewed by Tony Chang.
369
370         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
371
372         The following changes have been made:
373
374           1. Renamed TestShellAndroid to TestShellLinux.
375           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
376           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
377
378         * DumpRenderTree/DumpRenderTree.gypi:
379         * DumpRenderTree/chromium/EventSender.cpp:
380         (EventSender::keyDown):
381         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
382         * DumpRenderTree/chromium/TestShellGtk.cpp:
383         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
384         (AlarmHandler):
385         (TestShell::waitTestFinished):
386         (setupFontconfig):
387         (platformInit):
388         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
389         (checkLayoutTestSystemDependencies):
390         (openStartupDialog):
391
392 2011-11-28  Eric Seidel  <eric@webkit.org>
393
394         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
395         https://bugs.webkit.org/show_bug.cgi?id=71983
396
397         Reviewed by Adam Barth.
398
399         We'll add more code to Environment overtime,
400         allowing us to mock out more of our direct interactions with os.environ.
401
402         This patch also makes run_command print the passed in environment.
403
404         * Scripts/webkitpy/common/host_mock.py:
405         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
406         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
407         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
408         * Scripts/webkitpy/common/system/executive.py:
409         * Scripts/webkitpy/common/system/executive_mock.py:
410         * Scripts/webkitpy/layout_tests/port/webkit.py:
411         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
412         * Scripts/webkitpy/tool/commands/download_unittest.py:
413         * Scripts/webkitpy/tool/steps/build.py:
414
415 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
416
417         [Qt] Build system fixes against V8.
418
419         Reviewed by Tor Arne Vestbø.
420
421         * qmake/mkspecs/features/webcore.prf: Get rid of old v8 cruft.
422         * qmake/mkspecs/features/wtf.prf: If requested, pull in v8 from Qt and configure
423         WTF accordingly to use v8. (WTF in the implementation needs it as well as users of WTF)
424
425 2011-11-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
426
427         Make sure the useFixedLayout feature is consistently handled
428         https://bugs.webkit.org/show_bug.cgi?id=73212
429
430         Reviewed by Simon Hausmann.
431
432         The web page parameters are set to our Qt defaults and are now altered
433         in the WebKitTestRunner.
434
435         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
436         (WTR::WrapperWindow::WrapperWindow):
437
438 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
439
440         [Qt] WTF should be built as separate static library
441         https://bugs.webkit.org/show_bug.cgi?id=73201
442
443         Reviewed by Tor Arne Vestbø.
444
445         * DumpRenderTree/qt/DumpRenderTree.pro: Require wtf.
446         * MiniBrowser/qt/BrowserWindow.cpp: Remove unnecessary config.h inclusion and
447         thus wtf dependency.
448         * WebKitTestRunner/InjectedBundle/Target.pri: Require wtf.
449         * WebKitTestRunner/Target.pri: Ditto.
450         * qmake/mkspecs/features/default_post.prf: When re-ordering the static libs
451         consider wtf, too.
452         * qmake/mkspecs/features/javascriptcore.prf: Remove WTF specific build stuff,
453         moved into wtf.prf.
454         * qmake/mkspecs/features/qtwebkit.prf: For debug builds with shared libs, also
455         link in libwtf.
456         * qmake/mkspecs/features/wtf.prf: Added. Stuff needed for building and using WTF.
457
458 2011-11-28  Kentaro Hara  <haraken@chromium.org>
459
460         run-bindings-tests shows diff error for a newly added binding test
461         https://bugs.webkit.org/show_bug.cgi?id=73179
462
463         Reviewed by Adam Barth.
464
465         Currently, when we add a new binding test, say bindings/scripts/test/TestSupplemental.idl,
466         run-bindings-tests just shows diff error because reference files
467         (i.e. {V8,JS,...}TestSupplemental.h and {V8,JS,...}TestSupplemental.cpp) do not yet exist:
468
469             FAIL: (V8) V8TestSupplemental.h
470             diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.h: No such file or directory
471
472         Instead, this patch treats a non-existent reference file as an empty file and
473         shows the result of the newly added binding test, like this:
474
475             FAIL: (V8) V8TestSupplemental.h
476             --- WebCore/bindings/scripts/test/V8/V8TestSupplemental.h       1970-01-01 09:00:00.000000000 +0900
477             +++ /tmp/tmpmX2i2F/V8TestSupplemental.h 2011-11-28 11:08:34.150707677 +0900
478             @@ -0,0 +1,84 @@
479             +/*
480             +    This file is part of the WebKit open source project.
481             +    This file has been generated by generate-bindings.pl. DO NOT MODIFY!
482             +
483             (omitted)
484
485         * Scripts/run-bindings-tests:
486         (detect_changes): Just added an -N option to the diff command.
487
488 2011-11-28  Martin Robinson  <mrobinson@igalia.com>
489
490         [Gtk][gtkdoc] Syntax error in Tools/gtk/generate-gtkdoc
491         https://bugs.webkit.org/show_bug.cgi?id=73165
492
493         Reviewed by Philippe Normand.
494
495         Fix some syntax errors in this script and remove an unused variable.
496
497         * gtk/generate-gtkdoc:
498         (get_webkit2_options.src_path): 
499         (get_webkit2_options):
500         (get_webkit1_options.src_path):
501
502 2011-11-26  Kevin Ollivier  <kevino@theolliviers.com>
503
504         [wx] Unreviewed build fix. Enable the inspector.
505         
506         * waf/build/settings.py:
507
508 2011-11-26  Martin Robinson  <mrobinson@igalia.com>
509
510         Try to fix the build after r101174.
511
512         * gtk/generate-gtkdoc: Properly handle empty PKG_CONFIG_PATHs.
513
514 2011-11-17  Martin Robinson  <mrobinson@igalia.com>
515
516         [GTK] Integrate build-gtkdoc into build-webkit and make
517         https://bugs.webkit.org/show_bug.cgi?id=72626
518
519         Reviewed by Philippe Normand.
520
521         * GNUmakefile.am: Added support for new scripts and "make docs".
522         * Scripts/webkitdirs.pm: Call generate-gtkdoc when building.
523         (buildAutotoolsProject):
524         * gtk/generate-gtkdoc: Added.
525         * gtk/gtkdoc.py: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py.
526
527 2011-11-25  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
528
529         [Qt] Add support for using OWRT with Qt5
530         https://bugs.webkit.org/show_bug.cgi?id=72947
531
532         Add qt-5.0 platform and don't pass -graphicssystem to QtTestBrowser if using Qt5.
533
534         Reviewed by Csaba Osztrogonác.
535
536         * Scripts/old-run-webkit-tests:
537
538 2011-11-25  Yury Semikhatsky  <yurys@chromium.org>
539
540         [Chromium] Web Inspector: get rid of WebDevToolsFrontendClient::sendFrontendLoaded method
541         https://bugs.webkit.org/show_bug.cgi?id=73126
542
543         No need to have a separate client call for this. The front-end can store messages
544         which arrive before front-end loaded and dispatch them later. This happens in layout
545         tests only by the way as all other messages should be initiated by the front-end code.
546
547         Reviewed by Pavel Feldman.
548
549         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
550         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
551         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
552         * DumpRenderTree/chromium/DRTDevToolsClient.h:
553
554 2011-11-24  Kentaro Hara  <haraken@chromium.org>
555
556         Replace subprocess.call() with subprocess.Popen()
557         https://bugs.webkit.org/show_bug.cgi?id=73105
558
559         Reviewed by Adam Barth.
560
561         Currently, the stdout and stderr of the child processes of run-bindings-tests
562         are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself.
563         This is the problem of subprocess.call(), which does not synchronize the stdout and stderr
564         between a parent process and a child process. This patch replaces subprocess.call() with
565         subprocess.Popen() and synchronizes the stdout and stderr between them.
566         This patch also makes output messages of run-bindings-tests more readable.
567
568         With this patch, the output messages of run-bindings-tests look like as follows:
569
570             PASS: (CPP) WebDOMTestObj.h
571             PASS: (CPP) WebDOMTestObj.cpp
572             FAIL: (CPP) WebDOMTestInterface.h
573             --- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h      2011-11-25 13:34:09.313516268 +0900
574             +++ /tmp/tmpDAV87G/WebDOMTestInterface.h        2011-11-25 13:44:42.712946812 +0900
575             @@ -23,7 +23,7 @@
576              #ifndef WebDOMTestInterface_h
577              #define WebDOMTestInterface_h
578
579             -#if ENABLE(Condition1) || ENABLE(Condition2)
580             +#if ENABLE(Condition1) || ENABLE(Condition3)
581
582              #include <WebDOMObject.h>
583              #include <WebDOMString.h>
584              @@ -53,5 +53,5 @@
585              WebDOMTestInterface toWebKit(WebCore::TestInterface*);
586
587              #endif
588             -#endif // ENABLE(Condition1) || ENABLE(Condition2)
589             +#endif // ENABLE(Condition1) || ENABLE(Condition3)
590             PASS: (CPP) WebDOMFloat64Array.cpp
591             PASS: (CPP) WebDOMFloat64Array.h
592
593             Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")
594
595         * Scripts/run-bindings-tests:
596         (generate_from_idl):
597         (detect_changes):
598         (run_tests):
599         (main):
600
601 2011-11-24  Kentaro Hara  <haraken@chromium.org>
602
603         Fix the current working directory of run-bindings-tests
604         https://bugs.webkit.org/show_bug.cgi?id=73106
605
606         Reviewed by Adam Barth.
607
608         Currently, run-bindings-tests outputs the following error
609         (although it outputs "all tests passed!" in the end):
610
611             Testing the ObjC generator on TestObj.idl
612             gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
613             gcc: warning: '-x objective-c' after last input file has no effect
614             gcc: no input files
615
616         This is because CodeGeneratorObjC.pm assumes that the current working directory
617         is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
618         Thus, this patch changes it to WebKit/Source/.
619
620         * Scripts/run-bindings-tests:
621         (generate_from_idl):
622         (main):
623
624 2011-11-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
625
626         [Qt] Get rid of the buildDirForSource() function in the build system
627
628         At some point the plan was to allow for running qmake on sub-trees
629         of the sources, into the top level build directory, but this is no
630         longer possible, so no reason to keep the convenience function around.
631
632         Reviewed by Simon Hausmann.
633
634         * WebKitTestRunner/DerivedSources.pri:
635         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
636         * qmake/mkspecs/features/default_post.prf:
637         * qmake/mkspecs/features/default_pre.prf:
638         * qmake/mkspecs/features/functions.prf:
639         * qmake/mkspecs/features/javascriptcore.prf:
640         * qmake/mkspecs/features/webcore.prf:
641         * qmake/mkspecs/features/webkit2.prf:
642
643 2011-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
644
645         Unreviewed, rolling out r101107.
646         http://trac.webkit.org/changeset/101107
647         https://bugs.webkit.org/show_bug.cgi?id=73062
648
649         Breaks the commit-queue (Requested by abarth on #webkit).
650
651         * Scripts/webkitpy/common/host.py:
652         (Host._engage_awesome_windows_hacks):
653         * Scripts/webkitpy/common/host_mock.py:
654         (MockHost.__init__):
655         * Scripts/webkitpy/common/system/environment.py: Removed.
656         * Scripts/webkitpy/common/system/environment_unittest.py: Removed.
657         * Scripts/webkitpy/common/system/executive.py:
658         (Executive._run_command_with_teed_output):
659         (Executive.run_and_throw_if_fail):
660         * Scripts/webkitpy/common/system/executive_mock.py:
661         (MockExecutive.run_and_throw_if_fail):
662         (MockExecutive.run_command):
663         * Scripts/webkitpy/layout_tests/port/webkit.py:
664         (WebKitPort._driver_build_script_name):
665         (WebKitPort._run_script):
666         (WebKitPort._build_driver):
667         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
668         (test_build_driver):
669         * Scripts/webkitpy/tool/commands/download_unittest.py:
670         * Scripts/webkitpy/tool/steps/build.py:
671         (Build.build):
672
673 2011-11-23  Ojan Vafai  <ojan@chromium.org>
674
675         Unreviewed, rolling out r101110.
676         http://trac.webkit.org/changeset/101110
677         https://bugs.webkit.org/show_bug.cgi?id=73057
678
679         The bots have now cycled and this patch is no longer needed.
680
681         * Scripts/webkitpy/layout_tests/controllers/manager.py:
682         (Manager._upload_json_files):
683
684 2011-11-23  Ojan Vafai  <ojan@chromium.org>
685
686         Temporarily save the incremental results json in order to identify bug
687         https://bugs.webkit.org/show_bug.cgi?id=73057
688
689         Reviewed by Dean Jackson.
690
691         The test results server needed to be rolled back from tip of tree
692         due to a JSON merging bug. It's hard to identify what the bug is without
693         the raw data.
694
695         * Scripts/webkitpy/layout_tests/controllers/manager.py:
696         (Manager._upload_json_files):
697
698 2011-11-23  Ojan Vafai  <ojan@chromium.org>
699
700         Merging two version 4 results hits an error in the test results server
701         https://bugs.webkit.org/show_bug.cgi?id=73042
702
703         Reviewed by Adam Barth.
704
705         The old code assumed that if the aggregate results value was not a leaf
706         value that the incremental results would exist, which is just totally
707         wrong. Added a test for that case as well.
708
709         * TestResultServer/model/jsonresults.py:
710         (JsonResults._merge_tests):
711         * TestResultServer/model/jsonresults_unittest.py:
712         (JsonResultsTest.test_merge_build_directory_hierarchy_old_version):
713         (JsonResultsTest.test_merge_build_directory_hierarchy):
714
715 2011-11-23  Eric Seidel  <eric@webkit.org>
716
717         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
718         https://bugs.webkit.org/show_bug.cgi?id=71983
719
720         Reviewed by Adam Barth.
721
722         We'll add more code to Environment overtime,
723         allowing us to mock out more of our direct interactions with os.environ.
724
725         This patch also makes run_command print the passed in environment.
726
727         * Scripts/webkitpy/common/host_mock.py:
728         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
729         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
730         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
731         * Scripts/webkitpy/common/system/executive.py:
732         * Scripts/webkitpy/common/system/executive_mock.py:
733         * Scripts/webkitpy/layout_tests/port/webkit.py:
734         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
735         * Scripts/webkitpy/tool/commands/download_unittest.py:
736         * Scripts/webkitpy/tool/steps/build.py:
737
738 2011-11-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
739
740         [Qt] Re-generate QtWebKit API forwarding headers when API changes
741
742         The forwarding headers are generated by syncqt, and syncqt is run by qmake,
743         so we need sync.profile to live in the same directory as the project file
744         that will be touched when adding/removing API (api.pri in our case).
745
746         Since the WebKit2 APIs live in a separate static library, we have to
747         add the project file for WebKit2 as a dependency of the api.pri file
748         as well, so that any changes to the WebKit2 API will still trigger a
749         run of qmake (and then syncqt).
750
751         Lastly, we use the new QMAKE_SYNCQT_OUTDIR variable in Qt 5 to ensure
752         that the forwarding headers are still generated in the root build dir,
753         not in the Source dir along with the internal forwarding headers.
754
755         Reviewed by Andreas Kling.
756
757         * qmake/mkspecs/features/default_pre.prf:
758         * qmake/mkspecs/features/functions.prf:
759
760 2011-11-23  Johnny Ding  <jnd@chromium.org>
761
762         Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
763         https://bugs.webkit.org/show_bug.cgi?id=72950
764
765         Reviewed by Tony Chang.
766
767         * DumpRenderTree/chromium/LayoutTestController.cpp:
768         (LayoutTestController::queueLoadHTMLString):
769
770 2011-11-23  Adam Barth  <abarth@webkit.org>
771
772         garden-o-matic should display a message if it can't find results to display
773         https://bugs.webkit.org/show_bug.cgi?id=72991
774
775         Reviewed by Dimitri Glazkov.
776
777         Not all failures (e.g., TIMEOUT) have results that we can display.
778         This patch adds a short message so that the user can see that we're
779         done trying to load the results.
780
781         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
782         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
783         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
784
785 2011-11-23  Adam Barth  <abarth@webkit.org>
786
787         garden-o-matic should explain more clearly what the builder lists at the top of the page mean
788         https://bugs.webkit.org/show_bug.cgi?id=72992
789
790         Reviewed by Dimitri Glazkov.
791
792         This patch also prepares us to list other sorts of failures, like
793         performance and unit test.
794
795         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
796         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
797         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
798         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
799
800 2011-11-23  Ryan Sleevi  <rsleevi@chromium.org>
801
802         Add new Chromium tests to the flakiness dashboard
803         https://bugs.webkit.org/show_bug.cgi?id=72997
804
805         Reviewed by Ojan Vafai.
806
807         * TestResultServer/static-dashboards/dashboard_base.js:
808         ():
809
810 2011-11-23  Adam Barth  <abarth@webkit.org>
811
812         garden-o-matic should support AUDIO failures
813         https://bugs.webkit.org/show_bug.cgi?id=69477
814
815         Reviewed by Dimitri Glazkov.
816
817         This is a first iteration at supporting AUDIO failures in
818         garden-o-matic.  We'll probably need to iterate a bit when we have a
819         real audio failure in the tree to play with.  For example, we'll
820         probably want to add and <audio> element to the "Examine" view to hear
821         the differences, but that all can be done in a subsequent patch.
822
823         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
824
825 2011-11-23  Scott Graham  <scottmg@chromium.org>
826
827         Adding gamepad support
828         https://bugs.webkit.org/show_bug.cgi?id=69451
829
830         Reviewed by Darin Fisher.
831
832         Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
833         gamepad data that will be retrieved when JS code pulls via API access.
834
835         * DumpRenderTree/DumpRenderTree.gypi:
836         * DumpRenderTree/chromium/GamepadController.cpp: Added.
837         (GamepadController::GamepadController):
838         (GamepadController::bindToJavascript):
839         (GamepadController::reset):
840         (GamepadController::connect):
841         (GamepadController::disconnect):
842         (GamepadController::setId):
843         (GamepadController::setButtonCount):
844         (GamepadController::setButtonData):
845         (GamepadController::setAxisCount):
846         (GamepadController::setAxisData):
847         (GamepadController::fallbackCallback):
848         * DumpRenderTree/chromium/GamepadController.h: Added.
849         * DumpRenderTree/chromium/TestShell.cpp:
850         (TestShell::TestShell):
851         (TestShell::resetTestController):
852         (TestShell::bindJSObjectsToWindow):
853         * DumpRenderTree/chromium/TestShell.h:
854         (TestShell::gamepadController):
855
856 2011-11-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
857
858         [CMake] Move the top-level logic to the top-level directory.
859         https://bugs.webkit.org/show_bug.cgi?id=72685
860
861         Reviewed by Brent Fulgham.
862
863         * CMakeLists.txt: Added.
864         * DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
865         * EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
866         * Scripts/webkitdirs.pm:
867         (generateBuildSystemFromCMakeProject):
868         * WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.
869
870 2011-11-17  Vincent Scheib  <scheib@chromium.org>
871
872         Pointer Lock: Initial Tests for navigator.webkitPonter
873         https://bugs.webkit.org/show_bug.cgi?id=72659
874
875         Reviewed by Darin Fisher.
876
877         * DumpRenderTree/chromium/TestShell.cpp:
878         (TestShell::TestShell):
879             Enabling PointerLock in TestShell
880
881 2011-11-22  Ryan Sleevi  <rsleevi@chromium.org>
882
883         Update flakiness dashboard for new Chromium builders and tests
884         https://bugs.webkit.org/show_bug.cgi?id=72931
885
886         Reviewed by Ojan Vafai.
887
888         * TestResultServer/static-dashboards/builders.js:
889         * TestResultServer/static-dashboards/dashboard_base.js:
890
891 2011-11-22  Adam Roben  <aroben@apple.com>
892
893         Remove some debugging code I accidentally left in r101005
894
895         * Scripts/prepare-ChangeLog:
896         (get_function_line_ranges_for_python):
897
898 2011-11-22  Adam Roben  <aroben@apple.com>
899
900         Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files
901
902         Fixes <http://webkit.org/b/57008> prepare-ChangeLog doesn't find names of modified
903         classes/methods in Python source files
904
905         Reviewed by Dan Bates.
906
907         * Scripts/prepare-ChangeLog:
908         (get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
909         or that use python as their interpreter. Modified the code that extracts the interpreter to
910         ignore a leading "/usr/bin/env " in the interpreter line, as is common for our Python
911         scripts.
912         (get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
913         for class/def lines and generate ranges based on them.
914
915 2011-11-21  Yuta Kitamura  <yutak@chromium.org>
916
917         [GTK] Enable WebSocket hybi tests
918         https://bugs.webkit.org/show_bug.cgi?id=72870
919
920         Reviewed by Xan Lopez.
921
922         * DumpRenderTree/gtk/DumpRenderTree.cpp:
923         (resetDefaultsToConsistentValues):
924         Reset the setting value to the default value (true).
925         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
926         (LayoutTestController::overridePreference):
927         Change the setting value through a function in DumpRenderTreeSupportGtk.
928
929 2011-11-21  Ryosuke Niwa  <rniwa@webkit.org>
930
931         ChangeLogEntry should be able to parse entries with multiple authors
932         https://bugs.webkit.org/show_bug.cgi?id=72690
933
934         Reviewed by Eric Seidel.
935
936         Support multi-author change log entries in ChangeLogEntry. Split author names using
937         the same logic as splitting reviewer names. _authors now stores list of dictionaries
938         with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
939         accounts because some contributors are never listed in committers.py. 
940
941         * Scripts/webkitpy/common/checkout/changelog.py:
942         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
943         * Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}
944         throws an exception when the argument is None.
945
946 2011-11-21  Simon Hausmann  <simon.hausmann@nokia.com>
947
948         [Qt] Speed up debug builds.
949         https://bugs.webkit.org/show_bug.cgi?id=72882
950
951         Reviewed by Tor Arne Vestbø.
952
953         Introduce a special type of build that replaces the static jsc/wc/wk2
954         static libraries with shared libraries, that individually are much faster
955         to link and don't require relinking into the big library when changing just
956         one file in one module. It can be enabled with
957         --qmakearg="CONFIG+=force_static_libs_as_shared"
958
959         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,
960         disable symbol visibility, static linkage and enable rpath.
961         * qmake/mkspecs/features/functions.prf: Add a helper function to determine if
962         we need to link the convenience libraries together or not and renamed linkStaticLibrary
963         to just linkLibrary (because linkage is not necessarily static).
964         * qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also
965         link against jsc/wc/wk2 when linking app code against QtWebKit.
966         * qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper
967         function.
968         * qmake/mkspecs/features/webcore.prf: Ditto.
969         * qmake/mkspecs/features/webkit2.prf: Ditto.
970
971 2011-11-21  Adam Klein  <adamk@chromium.org>
972
973         Update flakiness dashboard linkification regexps for crbug.com/100000 and above
974         https://bugs.webkit.org/show_bug.cgi?id=72898
975
976         Reviewed by Ojan Vafai.
977
978         Also removed a comment that was going to be more trouble to keep up to
979         date than seemed worthwhile (the code is now the documentation).
980
981         * TestResultServer/static-dashboards/flakiness_dashboard.html:
982
983 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
984
985         [Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
986         https://bugs.webkit.org/show_bug.cgi?id=72895
987
988         Reviewed by Chris Fleizach.
989
990         * DumpRenderTree/chromium/WebViewHost.cpp:
991         (WebViewHost::postAccessibilityNotification):
992
993 2011-11-21  Philippe Normand  <pnormand@igalia.com>
994
995         Unreviewed, run-gtk-tests temporary workaround after r98500.
996
997         * Scripts/run-gtk-tests: Try to find the build directory like in
998         build-gtkdoc, until webkit-build-directory --configuration gets fixed.
999
1000 2011-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1001
1002         [GTK] Add a way to skip unit tests in the bots
1003         https://bugs.webkit.org/show_bug.cgi?id=72879
1004
1005         Reviewed by Philippe Normand.
1006
1007         Rewrite the script in python to make it easier for everybody to
1008         change it and add support for skipping tests.
1009
1010         * Scripts/run-gtk-tests:
1011
1012 2011-11-21  Raphael Kubo da Costa  <kubo@profusion.mobi>
1013
1014         [EFL] Add more appcache functions to ewk_settings.
1015         https://bugs.webkit.org/show_bug.cgi?id=72143
1016
1017         Reviewed by Kenneth Rohde Christiansen.
1018
1019         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1020         (LayoutTestController::clearAllApplicationCaches):
1021         (LayoutTestController::setAppCacheMaximumSize): Use the right
1022         function, this is not related to the memory cache, but rather to the
1023         appcache.
1024
1025 2011-11-18  Adam Roben  <aroben@apple.com>
1026
1027         Make NRWT consider all lines of output from parse-malloc-history, not just the first
1028
1029         Fixes <http://webkit.org/b/72652> REGRESSION (NRWT): NRWT always reports "1 unique leaks
1030         found" even when there are more than 1 unique leaks
1031
1032         Reviewed by Darin Adler.
1033
1034         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1035         (LeakDetector.count_total_bytes_and_unique_leaks): Pass re.MULTILINE to re.findall so that
1036         "^" will be considered to match the beginning of any line, not only the beginning of the
1037         string.
1038
1039         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1040         (LeakDetectorTest.test_count_total_bytes_and_unique_leaks): Added a second callstack to the
1041         fake output and updated expectations to match.
1042
1043 2011-11-21  Andras Becsi  <andras.becsi@nokia.com>
1044
1045         [Qt] Clean up MiniBrowser project file after recent changes
1046         https://bugs.webkit.org/show_bug.cgi?id=72869
1047
1048         Reviewed by Simon Hausmann.
1049
1050         Remove nonexistent files from OTHER_FILES after our touch and desktop webviews were merged.
1051
1052         * MiniBrowser/qt/MiniBrowser.pro:
1053
1054 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
1055
1056         Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
1057         https://bugs.webkit.org/show_bug.cgi?id=72479
1058
1059         Reviewed by Chris Fleizach.
1060
1061         * DumpRenderTree/AccessibilityUIElement.cpp:
1062         (getIsSelectedOptionActiveCallback):
1063         (AccessibilityUIElement::getJSClass):
1064         * DumpRenderTree/AccessibilityUIElement.h:
1065         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1066         (AccessibilityUIElement::AccessibilityUIElement):
1067         (AccessibilityUIElement::isSelectedOptionActiveGetterCallback):
1068         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1069         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1070         (AccessibilityUIElement::isSelectedOptionActive):
1071         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1072         (AccessibilityUIElement::isSelectedOptionActive):
1073         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1074         (AccessibilityUIElement::isSelectedOptionActive):
1075
1076 2011-11-21  Takashi Toyoshima  <toyoshim@chromium.org>
1077
1078         Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
1079         https://bugs.webkit.org/show_bug.cgi?id=72859
1080
1081         Reviewed by Eric Seidel.
1082         
1083         * Scripts/new-run-webkit-websocketserver:
1084
1085 2011-11-20  Shinya Kawanaka  <shinyak@google.com>
1086
1087         [Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
1088         https://bugs.webkit.org/show_bug.cgi?id=72655
1089
1090         Reviewed by Hajime Morita.
1091
1092         Fixed the calculation of offset.
1093
1094         * DumpRenderTree/chromium/WebViewHost.cpp:
1095         (WebViewHost::finishLastTextCheck):
1096
1097 2011-11-20  Ojan Vafai  <ojan@chromium.org>
1098
1099         Change the final place where we use version 3 of the results json output
1100         https://bugs.webkit.org/show_bug.cgi?id=72838
1101
1102         Reviewed by Adam Barth.
1103
1104         This converts the json from being a flat map of test name --> results
1105         to being hierarchical by directory. This will make the json files 
1106         considerably smaller.
1107
1108         Also cleaned up some functions that were returning/checking boolean values
1109         that were always True.
1110
1111         * TestResultServer/model/jsonresults.py:
1112         * TestResultServer/model/jsonresults_unittest.py:
1113
1114 2011-11-20  Ojan Vafai  <ojan@chromium.org>
1115
1116         Include the master name when querying the test results server.
1117         This will soon be required since leaving the master name out mean
1118         that multiple files could match the query.
1119
1120         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1121
1122 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1123
1124         Fix jsonp callback code to add the callback if json content
1125         is not jsonp.
1126         * TestResultServer/handlers/testfilehandler.py:
1127
1128 2011-11-19  Alice Boxhall  <aboxhall@chromium.org>
1129
1130         Modify dashboard_base.js to optionally accept version 4 results json.
1131
1132         Reviewed by Ojan Vafai.
1133
1134         * TestResultServer/static-dashboards/dashboard_base.js:
1135         (ADD_RESULTS):
1136         (flattenTrie):
1137         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1138         (testFlattenTrie):
1139
1140 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1141
1142         Stop storing results files as jsonp in the test results server
1143         https://bugs.webkit.org/show_bug.cgi?id=72814
1144
1145         Reviewed by Adam Barth.
1146
1147         * TestResultServer/model/jsonresults.py:
1148         * TestResultServer/model/jsonresults_unittest.py:
1149
1150 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1151
1152         Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
1153         https://bugs.webkit.org/show_bug.cgi?id=72813
1154
1155         Reviewed by Adam Barth.
1156
1157         Once this lands, we can start storing pure json in the test results server and then
1158         we can delete the code with all the FIXMEs added here.
1159
1160         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1161         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1162         Only add jsonp for full_results.json.
1163         * TestResultServer/model/jsonresults.py:
1164         * TestResultServer/model/jsonresults_unittest.py:
1165         Accept pure json uploads.
1166         * TestResultServer/static-dashboards/dashboard_base.js:
1167         (appendJSONScriptElementFor):
1168         Use the callback parameter so that the server can start returning pure json if it's left out.
1169
1170 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1171
1172         Allow json NRWT downloads to be pure json and not jsonp
1173         https://bugs.webkit.org/show_bug.cgi?id=72809
1174
1175         Reviewed by Adam Barth.
1176
1177         I'm moving the server to storing and serving up raw json instead of jsonp.
1178         You can still get the jsonp by passing a "callback" parameter, but there's no
1179         need for run-webkit-tests to get jsonp when all it wants is the raw json.
1180
1181         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1182         Make the wrapper stripping only happen if the json is actually wrapped.
1183         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1184
1185 2011-11-18  Daniel Bates  <dbates@rim.com>
1186
1187         Add CMake build infrastructure for the BlackBerry port
1188         https://bugs.webkit.org/show_bug.cgi?id=72768
1189
1190         Reviewed by Antonio Gomes.
1191
1192         Add optional --blackberry command line argument to build-webkit to build the
1193         BlackBerry port.
1194
1195         * Scripts/build-webkit:
1196         * Scripts/webkitdirs.pm:
1197         (determineBaseProductDir):
1198         (argumentsForConfiguration):
1199         (builtDylibPathForName):
1200         (determineIsQt):
1201         (isBlackBerry): Added.
1202         (determineIsBlackBerry): Added.
1203         (blackberryTargetArchitecture): Added.
1204         (isAppleWebKit):
1205
1206 2011-11-18  James Robinson  <jamesr@chromium.org>
1207
1208         Unreviewed, rolling out r100835.
1209         http://trac.webkit.org/changeset/100835
1210         https://bugs.webkit.org/show_bug.cgi?id=72778
1211
1212         Broke some page scale tests
1213
1214         * DumpRenderTree/chromium/EventSender.cpp:
1215         (EventSender::scalePageBy):
1216
1217 2011-11-18  Adam Barth  <abarth@webkit.org>
1218
1219         Prepare to move manual-tests out of WebCore
1220         https://bugs.webkit.org/show_bug.cgi?id=72782
1221
1222         Reviewed by Eric Seidel.
1223
1224         Update this file to refer to the new location of ManualTests.
1225
1226         * Scripts/webkitpy/common/config/build.py:
1227
1228 2011-11-18  James Robinson  <jamesr@chromium.org>
1229
1230         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
1231         https://bugs.webkit.org/show_bug.cgi?id=72778
1232
1233         Reviewed by Kenneth Russell.
1234
1235         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
1236
1237         * DumpRenderTree/chromium/EventSender.cpp:
1238         (EventSender::scalePageBy):
1239
1240 2011-11-18  Scott Graham  <scottmg@chromium.org>
1241
1242         IDL changes for gamepad support
1243         https://bugs.webkit.org/show_bug.cgi?id=71753
1244
1245         Reviewed by Adam Barth.
1246
1247         Runtime enable gamepad in chromium test shell.
1248
1249         * DumpRenderTree/chromium/TestShell.cpp:
1250         (TestShell::TestShell):
1251
1252 2011-10-27  Darin Fisher  <darin@chromium.org>
1253
1254         [chromium] Improve fullscreen API
1255         https://bugs.webkit.org/show_bug.cgi?id=70477
1256
1257         Reviewed by Adam Barth.
1258
1259         Implement enter/exitFullScreen.  The implementation is asynchronous,
1260         via postDelayedTask, to simulate how the browser actually behaves.
1261
1262         * DumpRenderTree/chromium/WebViewHost.cpp:
1263         (WebViewHost::enterFullScreen):
1264         (WebViewHost::exitFullScreen):
1265         (WebViewHost::setAddressBarURL):
1266         (WebViewHost::enterFullScreenNow):
1267         (WebViewHost::exitFullScreenNow):
1268         * DumpRenderTree/chromium/WebViewHost.h:
1269
1270 2011-11-18  Adam Roben  <aroben@apple.com>
1271
1272         Ignore an ANGLE leak that is not WebKit's fault
1273
1274         * Scripts/old-run-webkit-tests:
1275         (countAndPrintLeaks):
1276         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1277         (LeakDetector._callstacks_to_exclude_from_leaks):
1278         Added ScanFromString to the call stacks to exclude on all OS versions.
1279
1280 2011-11-18  Adam Roben  <aroben@apple.com>
1281
1282         Ignore another Lion-specific leak that is not WebKit's fault
1283
1284         * Scripts/old-run-webkit-tests:
1285         (countAndPrintLeaks):
1286         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1287         (LeakDetector._callstacks_to_exclude_from_leaks):
1288         Added SecTransformExecute to the call stacks to exclude.
1289
1290 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
1291
1292         [Qt] Enable WebSocket hybi tests
1293         https://bugs.webkit.org/show_bug.cgi?id=72687
1294
1295         Reviewed by Simon Hausmann.
1296
1297         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
1298
1299         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1300         (WebCore::WebPage::resetSettings):
1301         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1302         (LayoutTestController::overridePreference):
1303
1304 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
1305
1306         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
1307         https://bugs.webkit.org/show_bug.cgi?id=72707
1308
1309         Reviewed by Philippe Normand.
1310
1311         Make new-run-webkit-tests use the right path to locate the test
1312         plugin used by WebKitTestRunner.
1313
1314         * Scripts/webkitpy/layout_tests/port/gtk.py:
1315
1316 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
1317
1318         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
1319         https://bugs.webkit.org/show_bug.cgi?id=72697
1320
1321         Reviewed by Kenneth Rohde Christiansen.
1322
1323         * Tools.pro: Make WTR linux only for the moment.
1324         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
1325         * WebKitTestRunner/Target.pri: Ditto.
1326         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
1327         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
1328
1329 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1330
1331         [Qt] Change default size of the MiniBrowser
1332
1333         Reviewed by Simon Hausmann.
1334
1335         As we lay out desktop pages using the width of 980, change our default
1336         size to 980x735 so that we are not scaling down by default.
1337
1338         * MiniBrowser/qt/MiniBrowserApplication.h:
1339         (WindowOptions::WindowOptions):
1340
1341 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1342
1343         [EFL] Clean up the use of DATA_DIR in the buildsystem
1344         https://bugs.webkit.org/show_bug.cgi?id=72681
1345
1346         Reviewed by Daniel Bates.
1347
1348         Instead of adding -DDATA_DIR in all scopes, only define it in
1349         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
1350         it.
1351
1352         We can then define DATA_DIR to the generated theme directory for
1353         EWebLauncher, since it's what we want here.
1354
1355         * CMakeListsEfl.txt:
1356
1357 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1358
1359         [EFL] Move platform includes last in DRT's include directories.
1360         https://bugs.webkit.org/show_bug.cgi?id=72684
1361
1362         Reviewed by Daniel Bates.
1363
1364         This is the first step in fixing the build when a platform include (in
1365         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
1366         is included instead of WebKit's.
1367
1368         * DumpRenderTree/efl/CMakeLists.txt:
1369
1370 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
1371
1372         fuzzy_match doesn't recognize "Dan B" or "hyatt"
1373         https://bugs.webkit.org/show_bug.cgi?id=72636
1374
1375         Reviewed by Eric Seidel.
1376
1377         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
1378         and user names of email addreses such as rniwa in rniwa@webkit.org.
1379
1380         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
1381
1382         * Scripts/webkitpy/common/config/committers.py:
1383         * Scripts/webkitpy/common/config/committers_unittest.py:
1384
1385 2011-11-17  Eric Seidel  <eric@webkit.org>
1386
1387         Remove support for running check-webkit-style w/o a webkit checkout
1388         https://bugs.webkit.org/show_bug.cgi?id=72678
1389
1390         Reviewed by Adam Barth.
1391
1392         After talking to Dave Levin we've decided to remove this
1393         code.  I know of no users of check-webkit-style w/o a webkit checkout
1394         and this needlessly adds complexity.
1395
1396         * Scripts/webkitpy/style/main.py:
1397
1398 2011-11-17  Eric Seidel  <eric@webkit.org>
1399
1400         Remove more direct uses of os.path
1401         https://bugs.webkit.org/show_bug.cgi?id=72677
1402
1403         Reviewed by Adam Barth.
1404
1405         Remove more uses of os.path, including refactoring
1406         CommitterValidator to use a Host object instead of
1407         manual hacks to emulate what SCM and FileSystem provide.
1408
1409         * Scripts/webkitpy/common/checkout/changelog.py:
1410         * Scripts/webkitpy/common/config/committervalidator.py:
1411         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1412         * Scripts/webkitpy/common/system/filesystem_mock.py:
1413          - Turns out none of our unittests actually looked at this path.
1414            now I've made it be a valid path.
1415         * Scripts/webkitpy/tool/bot/feeders.py:
1416         * Scripts/webkitpy/tool/commands/queues.py:
1417
1418 2011-11-17  Eric Seidel  <eric@webkit.org>
1419
1420         Teach TextFileReader about FileSystem
1421         https://bugs.webkit.org/show_bug.cgi?id=72673
1422
1423         Reviewed by Adam Barth.
1424
1425         Unfortunately TextFileReader doesn't use FileSystem
1426         everywhere yet, so we can't move the unittests to
1427         using MockFileSystem, but we're close.
1428
1429         * Scripts/webkitpy/style/filereader.py:
1430         * Scripts/webkitpy/style/filereader_unittest.py:
1431         * Scripts/webkitpy/style/main.py:
1432
1433 2011-11-17  Eric Seidel  <eric@webkit.org>
1434
1435         Give check-webkit-style a Host
1436         https://bugs.webkit.org/show_bug.cgi?id=72670
1437
1438         Reviewed by Adam Barth.
1439
1440         * Scripts/webkitpy/common/checkout/scm/detection.py:
1441         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1442          - We don't run these unittests, but this one was looking for the wrong exception.
1443         * Scripts/webkitpy/style/main.py:
1444         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1445          - This was create a new scm object even though it already had one?
1446
1447 2011-11-17  Eric Seidel  <eric@webkit.org>
1448
1449         Move check-webkit-style change_directory code to more modern mocks
1450         https://bugs.webkit.org/show_bug.cgi?id=72664
1451
1452         Reviewed by Adam Barth.
1453
1454         * Scripts/check-webkit-style:
1455         * Scripts/webkitpy/style/main.py:
1456         * Scripts/webkitpy/style/main_unittest.py:
1457
1458 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
1459
1460         [GTK] enable ref tests
1461         https://bugs.webkit.org/show_bug.cgi?id=72601
1462
1463         Re-enable ref tests. Run the driver under evenly numbered display if performing
1464         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
1465         being run in an already used Xvfb instance if pixel tests are disabled.
1466
1467         Reviewed by Tony Chang.
1468
1469         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
1470         after the process is killed
1471
1472 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1473
1474         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
1475         https://bugs.webkit.org/show_bug.cgi?id=72620
1476
1477         Reviewed by David Levin.
1478
1479         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
1480         adding the suffix the cpp file. One example of false positive
1481         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
1482
1483         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
1484         basename contains the cpp's basename.
1485         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1486
1487 2011-11-17  Eric Seidel  <eric@webkit.org>
1488
1489         Move check-webkit-style's guts into webkitpy/style/main.py
1490         https://bugs.webkit.org/show_bug.cgi?id=72657
1491
1492         Reviewed by Adam Barth.
1493
1494         * Scripts/check-webkit-style:
1495         * Scripts/webkitpy/style/main.py:
1496
1497 2011-11-17  Eric Seidel  <eric@webkit.org>
1498
1499         new-run-webkit-tests is locale dependent
1500         https://bugs.webkit.org/show_bug.cgi?id=68691
1501
1502         Reviewed by Adam Barth.
1503
1504         Make NRWT use a clean environment, just like ORWT did.
1505
1506         * Scripts/webkitpy/layout_tests/port/base.py:
1507         * Scripts/webkitpy/layout_tests/port/chromium.py:
1508         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1509         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1510         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1511         * Scripts/webkitpy/layout_tests/port/efl.py:
1512         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1513         * Scripts/webkitpy/layout_tests/port/mac.py:
1514         * Scripts/webkitpy/layout_tests/port/qt.py:
1515         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1516         * Scripts/webkitpy/layout_tests/port/webkit.py:
1517         * Scripts/webkitpy/layout_tests/port/win.py:
1518
1519 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
1520
1521         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
1522         https://bugs.webkit.org/show_bug.cgi?id=72615
1523
1524         Reviewed by James Robinson.
1525
1526         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1527
1528 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
1529
1530         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
1531         https://bugs.webkit.org/show_bug.cgi?id=72595
1532
1533         Reviewed by Noam Rosenthal.
1534
1535         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1536         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
1537         ensure the registration of the DRTNode JS bindings.
1538         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1539         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
1540         registration of QWebElement (now done implicitly through QWebPage ->
1541         QtWebElementRunTime::initialize code path)
1542
1543 2011-11-17  Adam Roben  <aroben@apple.com>
1544
1545         Fix a crash-inducing typo I introduced in r100648
1546
1547         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
1548         handling a crashing test
1549
1550         Reviewed by Adam Barth.
1551
1552         * Scripts/webkitpy/layout_tests/port/chromium.py:
1553         (ChromiumDriver.run_test): Get the driver name from the port.
1554
1555         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1556         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
1557         right crashed process name.
1558
1559 2011-11-17  Adam Roben  <aroben@apple.com>
1560
1561         Fix NRWT's parsing of the number of excluded leaks
1562
1563         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
1564         leaks were excluded
1565
1566         Reviewed by Adam Barth.
1567
1568         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1569         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
1570         regular expression match, not the entire matched string.
1571
1572         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1573         (LeakDetectorTest): Added some example output that shows how things look when leaks are
1574         excluded.
1575         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
1576         correctly.
1577
1578 2011-11-17  Adam Roben  <aroben@apple.com>
1579
1580         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
1581
1582         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
1583         when web process crashes, but WebProcess crash log should get saved instead
1584
1585         Reviewed by Eric Seidel.
1586
1587         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1588         (write_test_result): Simplified a little to share more code between the case where we
1589         crashed when running the test and where we crashed when checking the expected rendering for
1590         a reftest. Changed to pass the crashed process name down to write_crash_report.
1591         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
1592         along to CrashLogs.find_newest_log rather than always using the driver name.
1593
1594         * Scripts/webkitpy/layout_tests/port/chromium.py:
1595         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
1596         crashed.
1597
1598         * Scripts/webkitpy/layout_tests/port/test.py:
1599         (TestInstance.__init__): Initialize new web_process_crash attribute.
1600         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
1601         test this patch adds.
1602         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
1603         specifies that the driver crashed or the web process crashed.
1604
1605         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1606         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
1607         which we pretend the web process crashed rather than the driver process.
1608
1609         (MainTest.test_run_singly_actually_runs_tests):
1610         (MainTest.test_unexpected_failures):
1611         (EndToEndTest.test_end_to_end):
1612         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
1613
1614 2011-11-17  Tony Chang  <tony@chromium.org>
1615
1616         [chromium] stop spamming features warning on every build
1617         https://bugs.webkit.org/show_bug.cgi?id=72629
1618
1619         Reviewed by Ojan Vafai.
1620
1621         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
1622         $mediaStreamSupport is on by default for chromium, make the default
1623         for $blobSupport also on.
1624
1625         * Scripts/build-webkit:
1626
1627 2011-11-17  Adam Roben  <aroben@apple.com>
1628
1629         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
1630
1631         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
1632         that are supposed to be ignored
1633
1634         Reviewed by Adam Barth.
1635
1636         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1637         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
1638         required when passing arguments via the shell (which we aren't doing here). It is not
1639         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
1640
1641         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1642         (LeakDetectorTest.test_leaks_args): Updated expectations.
1643
1644 2011-11-17  Philippe Normand  <pnormand@igalia.com>
1645
1646         Unreviewed, run-bindings-tests fix after r91028.
1647
1648         * Scripts/run-bindings-tests: Use scm.detection module.
1649
1650 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
1651
1652         Silence a warning about control reaching the end of a non-void function
1653         https://bugs.webkit.org/show_bug.cgi?id=72616
1654
1655         Reviewed by Tony Gentilcore.
1656
1657         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1658         (AccessibilityUIElement::verticalScrollbar):
1659
1660 2011-11-17  Adam Roben  <aroben@apple.com>
1661
1662         Ignore some leaks in frameworks we link against on Lion
1663
1664         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
1665         aren't WebKit's fault
1666
1667         Reviewed by Antti Koivisto.
1668
1669         * Scripts/old-run-webkit-tests:
1670         (countAndPrintLeaks):
1671         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1672         (LeakDetector._callstacks_to_exclude_from_leaks):
1673         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
1674
1675         * Scripts/webkitpy/layout_tests/port/mac.py:
1676         (MacPort.is_lion): Added.
1677
1678         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1679         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
1680         methods.
1681
1682 2011-11-17  Philippe Normand  <pnormand@igalia.com>
1683
1684         [GTK] Disable ref tests
1685         https://bugs.webkit.org/show_bug.cgi?id=72599
1686
1687         Reviewed by Xan Lopez.
1688
1689         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
1690         tests to avoid massive flakiness.
1691
1692 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1693
1694         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
1695
1696         A new extension object has been added to QQuickWebView (the same approach should be used
1697         for other API classes that need experimental APIs). The QML extension mechanism is then
1698         built on top of the experimental object.
1699
1700         https://bugs.webkit.org/show_bug.cgi?id=72522
1701
1702         Reviewed by Simon Hausmann.
1703
1704         * MiniBrowser/qt/BrowserWindow.cpp:
1705         (BrowserWindow::BrowserWindow):
1706         (BrowserWindow::webView):
1707         * MiniBrowser/qt/BrowserWindow.h:
1708         * MiniBrowser/qt/UrlLoader.cpp:
1709         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1710         * qmake/mkspecs/features/default_post.prf:
1711         * qmake/mkspecs/features/default_pre.prf:
1712         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
1713         * qmake/mkspecs/features/qtwebkit.prf:
1714
1715 2011-11-17  Adam Barth  <abarth@webkit.org>
1716
1717         Move test_results_uploader.py out of layout_package
1718         https://bugs.webkit.org/show_bug.cgi?id=72590
1719
1720         Reviewed by Eric Seidel.
1721
1722         Most of the lines of code in this file are wrong, but I've restrained
1723         myself and only changed a few of them to generalized this class to the
1724         common package.
1725
1726         This is part of a series of patches to remove layout_package.
1727
1728         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
1729         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1730         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
1731
1732 2011-11-17  Adam Barth  <abarth@webkit.org>
1733
1734         Unreviewed. Fix style nits in printing.py.
1735
1736         * Scripts/webkitpy/layout_tests/views/printing.py:
1737
1738 2011-11-17  Adam Barth  <abarth@webkit.org>
1739
1740         Minor style nits in run_webkit_tests.py
1741         https://bugs.webkit.org/show_bug.cgi?id=72583
1742
1743         Reviewed by Eric Seidel.
1744
1745         This patch just fixes some minor style issues as I work my way back
1746         into this code.
1747
1748         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1749
1750 2011-11-17  Adam Barth  <abarth@webkit.org>
1751
1752         Move test_result_writer out of layout_package
1753         https://bugs.webkit.org/show_bug.cgi?id=72586
1754
1755         Rubber-stamped by Eric Seidel.
1756
1757         This is part of a series of patches to remove layout_package.
1758
1759         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1760         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
1761         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
1762         * Scripts/webkitpy/tool/commands/rebaseline.py:
1763
1764 2011-11-17  Adam Barth  <abarth@webkit.org>
1765
1766         svn-apply shouldn't magically move files into Source anymore
1767         https://bugs.webkit.org/show_bug.cgi?id=72579
1768
1769         Reviewed by Eric Seidel.
1770
1771         The Source directory has existed for long enough that we don't need
1772         svn-apply to magically re-write old-style patches anymore.
1773
1774         * Scripts/VCSUtils.pm:
1775         (parseGitDiffHeader):
1776         (parseSvnDiffHeader):
1777
1778 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1779
1780         Add a list of contribution areas
1781         https://bugs.webkit.org/show_bug.cgi?id=72566
1782
1783         Reviewed by Eric Seidel.
1784
1785         Added ContributionAreas class.
1786
1787         * Scripts/webkitpy/common/config/contributionareas.py: Added.
1788         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
1789
1790 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1791
1792         Refactor ChangeLogTest.test_parse_reviewer_text
1793         https://bugs.webkit.org/show_bug.cgi?id=72572
1794
1795         Reviewed by Eric Seidel.
1796
1797         Refactored the test code by introduing two helper functions.
1798
1799         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1800
1801 2011-11-16  Eric Seidel  <eric@webkit.org>
1802
1803         Add SCMDetector object to make scm detection mockable
1804         https://bugs.webkit.org/show_bug.cgi?id=72247
1805
1806         Reviewed by Adam Barth.
1807
1808         I think SCM detection may eventually be rolled into Checkout,
1809         but this patch at least makes it possible to mock code-paths
1810         which rely on scm detection.
1811         In the process of replacing callers of these free-functions
1812         I found that one of the functions was no longer used,
1813         and that one of the callers could instead just use the SCM
1814         object it already had access to through port.host.scm().
1815         I also discovered that I was not calling Host._initialize_scm()
1816         and thus host.scm() was always returning None!
1817
1818         * Scripts/check-webkit-style:
1819         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1820         * Scripts/webkitpy/common/checkout/deps.py:
1821         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1822         * Scripts/webkitpy/common/checkout/scm/detection.py:
1823         * Scripts/webkitpy/common/checkout/scm/git.py:
1824         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1825         * Scripts/webkitpy/common/checkout/scm/svn.py:
1826         * Scripts/webkitpy/common/host.py:
1827         * Scripts/webkitpy/common/host_mock.py:
1828         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1829         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1830         * Scripts/webkitpy/layout_tests/port/base.py:
1831         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1832         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1833         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1834         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1835
1836 2011-11-16  Mark Rowe  <mrowe@apple.com>
1837
1838         Fix the build.
1839
1840         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
1841         Apply the workaround that we use in other projects to WebKitTestRunner.
1842
1843         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
1844         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
1845         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
1846
1847 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1848
1849         [Qt] Fix build after WTR AX support
1850         https://bugs.webkit.org/show_bug.cgi?id=72560
1851
1852         Reviewed by Geoffrey Garen.
1853
1854         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1855         * WebKitTestRunner/InjectedBundle/Target.pri:
1856
1857 2011-11-16  Tony Chang  <tony@chromium.org>
1858
1859         repurpose the flexbox bot for grid layout
1860         https://bugs.webkit.org/show_bug.cgi?id=72557
1861
1862         Reviewed by Ryosuke Niwa.
1863
1864         Since new flexbox is enabled everywhere, we don't need this bot
1865         anymore.  However, work on grid layout has begun, so we can use this
1866         bot to compile with ENABLE_CSS_GRID_LAYOUT.
1867
1868         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
1869         the bot on the waterfall, I will change the slave config to enable
1870         the compile flag and tests.
1871
1872 2011-11-11  Adrienne Walker  <enne@google.com>
1873
1874         [chromium] Expose mock scrollbars to window.internals
1875         https://bugs.webkit.org/show_bug.cgi?id=72195
1876
1877         Reviewed by James Robinson.
1878
1879         Because mock scrollbars are a global setting, reset between runs.
1880
1881         * DumpRenderTree/chromium/WebPreferences.cpp:
1882         (WebPreferences::applyTo):
1883
1884 2011-11-16  James Robinson  <jamesr@chromium.org>
1885
1886         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
1887         https://bugs.webkit.org/show_bug.cgi?id=72562
1888
1889         Reviewed by Dirk Pranke.
1890
1891         * DumpRenderTree/chromium/TestShell.cpp:
1892         (TestShell::runFileTest):
1893
1894 2011-11-16  Tony Chang  <tony@chromium.org>
1895
1896         [NRWT] speculative fix for multiple subprocess test on cygwin
1897         https://bugs.webkit.org/show_bug.cgi?id=72518
1898
1899         Reviewed by Adam Barth.
1900
1901         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
1902             tries to emulate posix fd behavior.
1903         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1904
1905 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1906
1907         Revert r100509; change was committed twice (first time as r100491).
1908         Unreviewed, build fix.
1909
1910         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1911
1912 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1913
1914         Run a dummy test in the gpu configurations if there's nothing to do.
1915         https://bugs.webkit.org/show_bug.cgi?id=72498
1916
1917         Reviewed by James Robinson.
1918
1919         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1920
1921 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1922
1923         contributors_by_fuzzy_match is super slow
1924         https://bugs.webkit.org/show_bug.cgi?id=72540
1925
1926         Reviewed by Eric Seidel.
1927
1928         Make contributors_by_name do case insensitive search using a dictionary.
1929
1930         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
1931         because that's the most common case.
1932
1933         * Scripts/webkitpy/common/config/committers.py:
1934         * Scripts/webkitpy/common/config/committers_unittest.py:
1935
1936 2011-11-16  David Levin  <levin@chromium.org>
1937
1938         check-webkit-style should recognize functions even if they have OVERRIDE after them.
1939         https://bugs.webkit.org/show_bug.cgi?id=72515
1940
1941         Reviewed by Adam Barth.
1942
1943         * Scripts/webkitpy/style/checkers/cpp.py:
1944         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1945
1946 2011-11-16  Tony Chang  <tony@chromium.org>
1947
1948         [NRWT] refactor drivers to require pixel_tests param
1949         https://bugs.webkit.org/show_bug.cgi?id=72517
1950
1951         Reviewed by Ojan Vafai.
1952
1953         No tests, just a refactoring.
1954
1955         * Scripts/webkitpy/layout_tests/port/chromium.py:
1956         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1957         * Scripts/webkitpy/layout_tests/port/webkit.py:
1958         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1959
1960 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1961
1962         Run a dummy test in the gpu configurations if there's nothing to do.
1963         https://bugs.webkit.org/show_bug.cgi?id=72498
1964
1965         Reviewed by James Robinson.
1966
1967         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1968
1969 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
1970
1971         WebKitTestRunner needs to support accessibility-related DRT APIs
1972         https://bugs.webkit.org/show_bug.cgi?id=42131
1973
1974         Reviewed by Beth Dakin.
1975
1976         Port the AX code in DRT to WKTestRunner by using IDL.
1977
1978         * DumpRenderTree/AccessibilityUIElement.cpp:
1979         (horizontalScrollbarCallback):
1980         (verticalScrollbarCallback):
1981         (AccessibilityUIElement::horizontalScrollbar):
1982         (AccessibilityUIElement::verticalScrollbar):
1983         (AccessibilityUIElement::getJSClass):
1984         * DumpRenderTree/AccessibilityUIElement.h:
1985         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1986         (AccessibilityUIElement::horizontalScrollbar):
1987         (AccessibilityUIElement::verticalScrollbar):
1988         * WebKitTestRunner/DerivedSources.make:
1989         * WebKitTestRunner/GNUmakefile.am:
1990         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
1991         (WTR::AccessibilityController::create):
1992         (WTR::AccessibilityController::AccessibilityController):
1993         (WTR::AccessibilityController::~AccessibilityController):
1994         (WTR::AccessibilityController::makeWindowObject):
1995         (WTR::AccessibilityController::wrapperClass):
1996         (WTR::AccessibilityController::rootElement):
1997         (WTR::AccessibilityController::focusedElement):
1998         (WTR::AccessibilityController::elementAtPoint):
1999         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
2000         (WTR::AccessibilityController::logFocusEvents):
2001         (WTR::AccessibilityController::logValueChangeEvents):
2002         (WTR::AccessibilityController::logScrollingStartEvents):
2003         (WTR::AccessibilityController::logAccessibilityEvents):
2004         (WTR::AccessibilityController::addNotificationListener):
2005         (WTR::AccessibilityController::notificationReceived):
2006         (WTR::AccessibilityController::resetToConsistentState):
2007         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
2008         (WTR::AccessibilityTextMarker::create):
2009         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
2010         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
2011         (WTR::AccessibilityTextMarker::platformTextMarker):
2012         (WTR::AccessibilityTextMarker::wrapperClass):
2013         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
2014         (WTR::AccessibilityTextMarker::isEqual):
2015         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
2016         (WTR::AccessibilityTextMarkerRange::create):
2017         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2018         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
2019         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
2020         (WTR::AccessibilityTextMarkerRange::wrapperClass):
2021         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
2022         (WTR::AccessibilityTextMarkerRange::isEqual):
2023         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
2024         (WTR::AccessibilityUIElement::create):
2025         (WTR::AccessibilityUIElement::wrapperClass):
2026         (WTR::AccessibilityUIElement::isValid):
2027         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2028         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
2029         (WTR::AccessibilityUIElement::isEqual):
2030         (WTR::AccessibilityUIElement::elementAtPoint):
2031         (WTR::AccessibilityUIElement::childAtIndex):
2032         (WTR::AccessibilityUIElement::indexOfChild):
2033         (WTR::AccessibilityUIElement::childrenCount):
2034         (WTR::AccessibilityUIElement::titleUIElement):
2035         (WTR::AccessibilityUIElement::parentElement):
2036         (WTR::AccessibilityUIElement::takeFocus):
2037         (WTR::AccessibilityUIElement::takeSelection):
2038         (WTR::AccessibilityUIElement::addSelection):
2039         (WTR::AccessibilityUIElement::removeSelection):
2040         (WTR::AccessibilityUIElement::allAttributes):
2041         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
2042         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2043         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
2044         (WTR::AccessibilityUIElement::attributesOfChildren):
2045         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
2046         (WTR::AccessibilityUIElement::increment):
2047         (WTR::AccessibilityUIElement::decrement):
2048         (WTR::AccessibilityUIElement::showMenu):
2049         (WTR::AccessibilityUIElement::press):
2050         (WTR::AccessibilityUIElement::stringAttributeValue):
2051         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2052         (WTR::AccessibilityUIElement::numberAttributeValue):
2053         (WTR::AccessibilityUIElement::boolAttributeValue):
2054         (WTR::AccessibilityUIElement::isAttributeSupported):
2055         (WTR::AccessibilityUIElement::isAttributeSettable):
2056         (WTR::AccessibilityUIElement::isActionSupported):
2057         (WTR::AccessibilityUIElement::role):
2058         (WTR::AccessibilityUIElement::subrole):
2059         (WTR::AccessibilityUIElement::roleDescription):
2060         (WTR::AccessibilityUIElement::title):
2061         (WTR::AccessibilityUIElement::description):
2062         (WTR::AccessibilityUIElement::language):
2063         (WTR::AccessibilityUIElement::stringValue):
2064         (WTR::AccessibilityUIElement::accessibilityValue):
2065         (WTR::AccessibilityUIElement::helpText):
2066         (WTR::AccessibilityUIElement::orientation):
2067         (WTR::AccessibilityUIElement::x):
2068         (WTR::AccessibilityUIElement::y):
2069         (WTR::AccessibilityUIElement::width):
2070         (WTR::AccessibilityUIElement::height):
2071         (WTR::AccessibilityUIElement::intValue):
2072         (WTR::AccessibilityUIElement::minValue):
2073         (WTR::AccessibilityUIElement::maxValue):
2074         (WTR::AccessibilityUIElement::valueDescription):
2075         (WTR::AccessibilityUIElement::insertionPointLineNumber):
2076         (WTR::AccessibilityUIElement::selectedTextRange):
2077         (WTR::AccessibilityUIElement::isEnabled):
2078         (WTR::AccessibilityUIElement::isRequired):
2079         (WTR::AccessibilityUIElement::isFocused):
2080         (WTR::AccessibilityUIElement::isFocusable):
2081         (WTR::AccessibilityUIElement::isSelected):
2082         (WTR::AccessibilityUIElement::isSelectable):
2083         (WTR::AccessibilityUIElement::isMultiSelectable):
2084         (WTR::AccessibilityUIElement::setSelectedChild):
2085         (WTR::AccessibilityUIElement::selectedChildrenCount):
2086         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2087         (WTR::AccessibilityUIElement::isExpanded):
2088         (WTR::AccessibilityUIElement::isChecked):
2089         (WTR::AccessibilityUIElement::isVisible):
2090         (WTR::AccessibilityUIElement::isOffScreen):
2091         (WTR::AccessibilityUIElement::isCollapsed):
2092         (WTR::AccessibilityUIElement::isIgnored):
2093         (WTR::AccessibilityUIElement::hasPopup):
2094         (WTR::AccessibilityUIElement::hierarchicalLevel):
2095         (WTR::AccessibilityUIElement::clickPointX):
2096         (WTR::AccessibilityUIElement::clickPointY):
2097         (WTR::AccessibilityUIElement::documentEncoding):
2098         (WTR::AccessibilityUIElement::documentURI):
2099         (WTR::AccessibilityUIElement::url):
2100         (WTR::AccessibilityUIElement::speak):
2101         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2102         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2103         (WTR::AccessibilityUIElement::attributesOfColumns):
2104         (WTR::AccessibilityUIElement::attributesOfRows):
2105         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2106         (WTR::AccessibilityUIElement::attributesOfHeader):
2107         (WTR::AccessibilityUIElement::indexInTable):
2108         (WTR::AccessibilityUIElement::rowIndexRange):
2109         (WTR::AccessibilityUIElement::columnIndexRange):
2110         (WTR::AccessibilityUIElement::rowCount):
2111         (WTR::AccessibilityUIElement::columnCount):
2112         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2113         (WTR::AccessibilityUIElement::disclosedByRow):
2114         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2115         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2116         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2117         (WTR::AccessibilityUIElement::ariaIsGrabbed):
2118         (WTR::AccessibilityUIElement::ariaDropEffects):
2119         (WTR::AccessibilityUIElement::lineForIndex):
2120         (WTR::AccessibilityUIElement::rangeForLine):
2121         (WTR::AccessibilityUIElement::boundsForRange):
2122         (WTR::AccessibilityUIElement::setSelectedTextRange):
2123         (WTR::AccessibilityUIElement::stringForRange):
2124         (WTR::AccessibilityUIElement::attributedStringForRange):
2125         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2126         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2127         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2128         (WTR::AccessibilityUIElement::horizontalScrollbar):
2129         (WTR::AccessibilityUIElement::verticalScrollbar):
2130         (WTR::AccessibilityUIElement::addNotificationListener):
2131         (WTR::AccessibilityUIElement::removeNotificationListener):
2132         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2133         (WTR::AccessibilityUIElement::textMarkerRangeLength):
2134         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2135         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2136         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2137         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2138         (WTR::AccessibilityUIElement::textMarkerForPoint):
2139         (WTR::AccessibilityUIElement::previousTextMarker):
2140         (WTR::AccessibilityUIElement::nextTextMarker):
2141         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2142         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
2143         (WTR::AccessibilityUIElement::platformUIElement):
2144         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
2145         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
2146         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
2147         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
2148         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2149         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2150         (WTR::InjectedBundle::beginTesting):
2151         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2152         (WTR::InjectedBundle::accessibilityController):
2153         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2154         (WTR::InjectedBundlePage::didClearWindowForFrame):
2155         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2156         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
2157         (WTR::LayoutTestController::platformName):
2158         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
2159         (WTR::AccessibilityTextMarker::isEqual):
2160         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
2161         (WTR::AccessibilityTextMarkerRange::isEqual):
2162         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
2163         (+[NSString stringWithJSStringRef:]):
2164         (-[NSString createJSStringRef]):
2165         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
2166         (-[AccessibilityNotificationHandler dealloc]):
2167         (-[AccessibilityNotificationHandler _notificationReceived:]):
2168         (-[AccessibilityNotificationHandler setCallback:]):
2169         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2170         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
2171         (WTR::AccessibilityUIElement::isEqual):
2172         (WTR::descriptionOfValue):
2173         (WTR::attributesOfElement):
2174         (WTR::concatenateAttributeAndValue):
2175         (WTR::convertNSArrayToVector):
2176         (WTR::descriptionOfElements):
2177         (WTR::AccessibilityUIElement::getLinkedUIElements):
2178         (WTR::AccessibilityUIElement::getDocumentLinks):
2179         (WTR::AccessibilityUIElement::getChildren):
2180         (WTR::AccessibilityUIElement::getChildrenWithRange):
2181         (WTR::AccessibilityUIElement::childrenCount):
2182         (WTR::AccessibilityUIElement::elementAtPoint):
2183         (WTR::AccessibilityUIElement::indexOfChild):
2184         (WTR::AccessibilityUIElement::childAtIndex):
2185         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2186         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2187         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2188         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2189         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2190         (WTR::AccessibilityUIElement::selectedChildrenCount):
2191         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2192         (WTR::AccessibilityUIElement::titleUIElement):
2193         (WTR::AccessibilityUIElement::parentElement):
2194         (WTR::AccessibilityUIElement::disclosedByRow):
2195         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
2196         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
2197         (WTR::AccessibilityUIElement::attributesOfChildren):
2198         (WTR::AccessibilityUIElement::allAttributes):
2199         (WTR::AccessibilityUIElement::stringAttributeValue):
2200         (WTR::AccessibilityUIElement::numberAttributeValue):
2201         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2202         (WTR::AccessibilityUIElement::boolAttributeValue):
2203         (WTR::AccessibilityUIElement::isAttributeSettable):
2204         (WTR::AccessibilityUIElement::isAttributeSupported):
2205         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
2206         (WTR::AccessibilityUIElement::role):
2207         (WTR::AccessibilityUIElement::subrole):
2208         (WTR::AccessibilityUIElement::roleDescription):
2209         (WTR::AccessibilityUIElement::title):
2210         (WTR::AccessibilityUIElement::description):
2211         (WTR::AccessibilityUIElement::orientation):
2212         (WTR::AccessibilityUIElement::stringValue):
2213         (WTR::AccessibilityUIElement::language):
2214         (WTR::AccessibilityUIElement::helpText):
2215         (WTR::AccessibilityUIElement::x):
2216         (WTR::AccessibilityUIElement::y):
2217         (WTR::AccessibilityUIElement::width):
2218         (WTR::AccessibilityUIElement::height):
2219         (WTR::AccessibilityUIElement::clickPointX):
2220         (WTR::AccessibilityUIElement::clickPointY):
2221         (WTR::AccessibilityUIElement::intValue):
2222         (WTR::AccessibilityUIElement::minValue):
2223         (WTR::AccessibilityUIElement::maxValue):
2224         (WTR::AccessibilityUIElement::valueDescription):
2225         (WTR::AccessibilityUIElement::insertionPointLineNumber):
2226         (WTR::AccessibilityUIElement::isActionSupported):
2227         (WTR::AccessibilityUIElement::isEnabled):
2228         (WTR::AccessibilityUIElement::isRequired):
2229         (WTR::AccessibilityUIElement::isFocused):
2230         (WTR::AccessibilityUIElement::isSelected):
2231         (WTR::AccessibilityUIElement::isExpanded):
2232         (WTR::AccessibilityUIElement::isChecked):
2233         (WTR::AccessibilityUIElement::hierarchicalLevel):
2234         (WTR::AccessibilityUIElement::speak):
2235         (WTR::AccessibilityUIElement::ariaIsGrabbed):
2236         (WTR::AccessibilityUIElement::ariaDropEffects):
2237         (WTR::AccessibilityUIElement::lineForIndex):
2238         (WTR::AccessibilityUIElement::rangeForLine):
2239         (WTR::AccessibilityUIElement::boundsForRange):
2240         (WTR::AccessibilityUIElement::stringForRange):
2241         (WTR::AccessibilityUIElement::attributedStringForRange):
2242         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2243         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2244         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2245         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2246         (WTR::AccessibilityUIElement::attributesOfColumns):
2247         (WTR::AccessibilityUIElement::attributesOfRows):
2248         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2249         (WTR::AccessibilityUIElement::attributesOfHeader):
2250         (WTR::AccessibilityUIElement::rowCount):
2251         (WTR::AccessibilityUIElement::columnCount):
2252         (WTR::AccessibilityUIElement::indexInTable):
2253         (WTR::AccessibilityUIElement::rowIndexRange):
2254         (WTR::AccessibilityUIElement::columnIndexRange):
2255         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2256         (WTR::AccessibilityUIElement::horizontalScrollbar):
2257         (WTR::AccessibilityUIElement::verticalScrollbar):
2258         (WTR::AccessibilityUIElement::selectedTextRange):
2259         (WTR::AccessibilityUIElement::setSelectedTextRange):
2260         (WTR::AccessibilityUIElement::increment):
2261         (WTR::AccessibilityUIElement::decrement):
2262         (WTR::AccessibilityUIElement::showMenu):
2263         (WTR::AccessibilityUIElement::press):
2264         (WTR::AccessibilityUIElement::setSelectedChild):
2265         (WTR::AccessibilityUIElement::accessibilityValue):
2266         (WTR::AccessibilityUIElement::documentEncoding):
2267         (WTR::AccessibilityUIElement::documentURI):
2268         (WTR::AccessibilityUIElement::url):
2269         (WTR::AccessibilityUIElement::addNotificationListener):
2270         (WTR::AccessibilityUIElement::removeNotificationListener):
2271         (WTR::AccessibilityUIElement::isFocusable):
2272         (WTR::AccessibilityUIElement::isSelectable):
2273         (WTR::AccessibilityUIElement::isMultiSelectable):
2274         (WTR::AccessibilityUIElement::isVisible):
2275         (WTR::AccessibilityUIElement::isOffScreen):
2276         (WTR::AccessibilityUIElement::isCollapsed):
2277         (WTR::AccessibilityUIElement::isIgnored):
2278         (WTR::AccessibilityUIElement::hasPopup):
2279         (WTR::AccessibilityUIElement::takeFocus):
2280         (WTR::AccessibilityUIElement::takeSelection):
2281         (WTR::AccessibilityUIElement::addSelection):
2282         (WTR::AccessibilityUIElement::removeSelection):
2283         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2284         (WTR::AccessibilityUIElement::textMarkerRangeLength):
2285         (WTR::AccessibilityUIElement::previousTextMarker):
2286         (WTR::AccessibilityUIElement::nextTextMarker):
2287         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2288         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2289         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2290         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2291         (WTR::AccessibilityUIElement::textMarkerForPoint):
2292         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2293         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
2294         (WTR::LayoutTestController::platformName):
2295         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2296         (WTR::LayoutTestController::platformName):
2297         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2298         (WTR::LayoutTestController::platformName):
2299         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2300         * WebKitTestRunner/win/InjectedBundle.vcproj:
2301
2302 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2303
2304         [Qt] Fix use of config.tests
2305
2306         We were checking @buildArgs to determine if the optional argument was
2307         passed or not, but this is not the right way to do that in Perl. The
2308         right way is to not use a prototype for the function, and to pass
2309         the list as a reference (to avoid list expansion). That way we can
2310         check the number of arguments, and choose the right code path based
2311         on that.
2312
2313         We were also missing a default-value of 0 for any feature that's not
2314         set in features.prf.
2315
2316         Reviewed by Kenneth Rohde Christiansen.
2317
2318         * Scripts/build-webkit:
2319         * Scripts/webkitdirs.pm:
2320         (qtFeatureDefaults):
2321         (buildQMakeProject):
2322
2323 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2324
2325         [Qt] Prospective fix for broken plugin tests
2326
2327         Don't hide symbols for the NPAPI test plugin
2328
2329         Rubber-stamped by Andreas Kling.
2330
2331         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2332
2333 2011-11-16  Adam Roben  <aroben@apple.com>
2334
2335         Move filenames/line numbers off to the right edge in Leaks Viewer
2336
2337         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
2338         because filenames/line numbers are right next to function names
2339
2340         Reviewed by Andreas Kling.
2341
2342         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
2343         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
2344         function name. Use the filename as the profile node's URL (we don't have enough info to
2345         compute a real URL currently) and the line number as the profile node's line number so the
2346         Inspector code will put them on the right side of the callstack graph.
2347
2348         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2349         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
2350         passed here, just filenames.
2351
2352         (WebInspector.linkifyURLAsNode):
2353         (WebInspector.linkifyResourceAsNode):
2354         Copied and slightly modified from inspector.js.
2355
2356 2011-11-16  Adam Roben  <aroben@apple.com>
2357
2358         Make Leaks Viewer load builds from the new Lion Leaks bot
2359
2360         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
2361
2362         Reviewed by Andreas Kling.
2363
2364         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2365         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
2366         SnowLeopard one.
2367
2368 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
2369
2370         [EFL] Clean up the offline apps-related functions in ewk_settings.
2371         https://bugs.webkit.org/show_bug.cgi?id=72132
2372
2373         Reviewed by Kenneth Rohde Christiansen.
2374
2375         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
2376         prefixes for code that is related only to the HTML5 app cache
2377         features.
2378
2379         Use `ewk_settings_application_cache' and
2380         `ewk_view_setting_application_cache' instead.
2381
2382         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2383         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2384
2385 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2386
2387         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
2388
2389         Reviewed by Tor Arne Vestbø.
2390
2391         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
2392         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
2393         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
2394         removes the .so.0.0.0 and just produces .so.
2395
2396 2011-11-16  Peter Beverloo  <peter@chromium.org>
2397
2398         Explicitly include unistd.h in TestNetscapePlugIn
2399         https://bugs.webkit.org/show_bug.cgi?id=72385
2400
2401         This is needed for the sleep() call in the indicateTestFailure method,
2402         which seems to be implicitly available for other platforms. This is not
2403         the case on Android.
2404
2405         Reviewed by Steve Block.
2406
2407         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2408
2409 2011-11-16  Peter Beverloo  <peter@chromium.org>
2410
2411         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
2412         https://bugs.webkit.org/show_bug.cgi?id=72384
2413
2414         Update to Android NDK r7, which was released last Friday. This adds
2415         support for RTTI and the -mimplicit-it gcc flag, which are required to
2416         respectively build ICU and Skia.
2417
2418         Reviewed by Steve Block.
2419
2420         * Scripts/update-webkit-chromium:
2421         * Scripts/webkitdirs.pm:
2422         (buildChromiumMakefile):
2423
2424 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
2425
2426         Unreviewed, rolling out r100266.
2427         http://trac.webkit.org/changeset/100266
2428
2429         Broke WTR.
2430
2431         * qmake/mkspecs/features/default_post.prf:
2432
2433 2011-11-16  Eric Seidel  <eric@webkit.org>
2434
2435         check-webkit-style broken by r99773: "Could not determine the port"
2436         https://bugs.webkit.org/show_bug.cgi?id=72275
2437
2438         Reviewed by Adam Barth.
2439
2440         I will continue engaging hacks, until windows improves.
2441
2442         * Scripts/webkitpy/common/host.py:
2443          - Host uses self.executive instead of self._executive like Port does.
2444          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
2445
2446 2011-11-16  Eric Seidel  <eric@webkit.org>
2447
2448         check-webkit-style broken by r99773: "Could not determine the port"
2449         https://bugs.webkit.org/show_bug.cgi?id=72275
2450
2451         Reviewed by Adam Barth.
2452
2453         Engage windows hacks harder.
2454
2455         This is a speculative fix for ChromiumWin.  We're now
2456         creating an SCM object much earlier, so we need to
2457         engage our "awesome" windows hacks earlier.
2458
2459         * Scripts/webkitpy/common/host.py:
2460         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2461
2462 2011-11-15  Darin Adler  <darin@apple.com>
2463
2464         DRT's uiElementAttributeValueCallback function is leaky
2465         https://bugs.webkit.org/show_bug.cgi?id=72453
2466
2467         Reviewed by Dan Bernstein.
2468
2469         * DumpRenderTree/AccessibilityUIElement.cpp:
2470         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
2471
2472 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
2473
2474         Implement edit-distance based reviewer recognition algorithm
2475         https://bugs.webkit.org/show_bug.cgi?id=72351
2476
2477         Reviewed by Eric Seidel.
2478
2479         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
2480         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
2481         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
2482         "build fix" to a reviewer's name (e.g. with with edit distance 9).
2483
2484         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
2485         the edit distance is implemented in edit_distance.py.
2486
2487         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
2488         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
2489
2490         * Scripts/webkitpy/common/checkout/changelog.py:
2491         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2492         * Scripts/webkitpy/common/config/committers.py:
2493         * Scripts/webkitpy/common/config/committers_unittest.py:
2494         * Scripts/webkitpy/common/editdistance.py: Added.
2495         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
2496         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2497         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
2498
2499 2011-11-15  Tony Chang  <tony@chromium.org>
2500
2501         Skip a failing webkitpy test on cygwin.
2502
2503         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2504
2505 2011-11-15  Sam Weinig  <sam@webkit.org>
2506
2507         TestWebKitAPI should not put its resources in the root products directory
2508         https://bugs.webkit.org/show_bug.cgi?id=72446
2509
2510         Reviewed by Anders Carlsson.
2511
2512         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2513         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
2514         directory.
2515
2516         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2517         (TEST_F):
2518         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
2519         (TestWebKitAPI::TEST):
2520         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2521         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
2522         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2523         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
2524         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2525         (TestWebKitAPI::Util::createURLForResource):
2526         Update calls to retrieve files from the bundle to look in the newly
2527         created subdirectory.
2528
2529 2011-11-15  Tony Chang  <tony@chromium.org>
2530
2531         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
2532
2533         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2534
2535 2011-11-15  Tony Chang  <tony@chromium.org>
2536
2537         Unreviewed, fix test-webkitpy tests.  Move the check for image results
2538         earlier.
2539
2540         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2541         * Scripts/webkitpy/layout_tests/port/webkit.py:
2542
2543 2011-11-15  James Robinson  <jamesr@chromium.org>
2544
2545         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
2546         https://bugs.webkit.org/show_bug.cgi?id=72444
2547
2548         Reviewed by Adam Barth.
2549
2550         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2551
2552 2011-11-15  Tony Chang  <tony@chromium.org>
2553
2554         Unreviewed, better fix for ref tests failures on SL Intel bot.
2555         Revert the previous change and return None if pixel results from
2556         either the test page or the expected page is missing.
2557
2558         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2559         * Scripts/webkitpy/layout_tests/port/webkit.py:
2560
2561 2011-11-15  James Robinson  <jamesr@chromium.org>
2562
2563         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
2564         https://bugs.webkit.org/show_bug.cgi?id=72402
2565
2566         Reviewed by Dirk Pranke.
2567
2568         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
2569         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
2570         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
2571         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
2572         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
2573         compositing enabled.
2574
2575         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
2576         patch should not impact any tests.
2577
2578         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2579         (main):
2580         * DumpRenderTree/chromium/TestShell.cpp:
2581         (TestShell::TestShell):
2582         (TestShell::resetWebSettings):
2583         * DumpRenderTree/chromium/TestShell.h:
2584         (TestShell::setAcceleratedCompositingForVideoEnabled):
2585         * DumpRenderTree/chromium/WebPreferences.cpp:
2586         (WebPreferences::reset):
2587         (WebPreferences::applyTo):
2588         * DumpRenderTree/chromium/WebPreferences.h:
2589         * Scripts/webkitpy/layout_tests/port/chromium.py:
2590         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2591         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2592
2593 2011-11-15  Tony Chang  <tony@chromium.org>
2594
2595         Unreviewed, try to fix ref tests failures on SL Intel bot.
2596         It looks like ImageDiff isn't returning an image diff.
2597
2598         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2599
2600 2011-11-15  Tony Chang  <tony@chromium.org>
2601
2602         Unreviewed fix of ref-tests on GTK+.
2603         If a driver is never started, _xvfb_process is never set.
2604
2605         * Scripts/webkitpy/layout_tests/port/gtk.py:
2606
2607 2011-11-14  Tony Chang  <tony@chromium.org>
2608
2609         [NRWT] Reftests should run even when pixel tests are disabled.
2610         https://bugs.webkit.org/show_bug.cgi?id=60605
2611
2612         Reviewed by Dirk Pranke.
2613
2614         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
2615             Also add an assert to make sure we get image hashes back when running ref tests.
2616         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
2617         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2618         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
2619         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
2620             of starting a pixel driver if needed.  It handles the logic of sending the test
2621             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
2622         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2623         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
2624         * Scripts/webkitpy/layout_tests/port/webkit.py:
2625         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
2626         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
2627
2628 2011-11-15  David Kilzer  <ddkilzer@apple.com>
2629
2630         Don't use File::Slurp for run-leaks unit tests
2631         <http://webkit.org/b/72356>
2632
2633         Reviewed by Daniel Bates.
2634
2635         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
2636         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
2637         Extracted common package logic into RunLeaks.pm.  Fixed call to
2638         RunLeaks::parseLeaksOutput().
2639         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
2640         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
2641
2642 2011-11-15  Peter Kasting  <pkasting@google.com>
2643
2644         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
2645         https://bugs.webkit.org/show_bug.cgi?id=72349
2646
2647         Reviewed by Adam Roben.
2648
2649         * Scripts/VCSUtils.pm:
2650         (isSVNDirectory):
2651
2652 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2653
2654         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
2655
2656         Reviewed by Tor Arne Vestbø.
2657
2658         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
2659         magic here where we handle all TEMPLATE = lib .pro files.
2660
2661 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2662
2663         [Qt] Unreviewed prospective --minimal build fix.
2664
2665         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
2666         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
2667
2668 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2669
2670         [Qt] Unreviewed --minimal build fix.
2671
2672         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
2673         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
2674         to make moc's preprocessor abort.
2675
2676 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
2677
2678         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
2679         https://bugs.webkit.org/show_bug.cgi?id=72156
2680
2681         Reviewed by Daniel Bates.
2682
2683         Similar to --makearg and --qmakearg, --cmakearg lets one pass
2684         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
2685
2686         * Scripts/build-webkit:
2687         * Scripts/webkitdirs.pm:
2688         (generateBuildSystemFromCMakeProject):
2689
2690 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
2691
2692         Improve ChangeLogEntry's reviewer parsing algorithm part 2
2693         https://bugs.webkit.org/show_bug.cgi?id=72340
2694
2695         Reviewed by Eric Seidel.
2696
2697         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
2698         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
2699
2700         * Scripts/webkitpy/common/checkout/changelog.py:
2701         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2702
2703 2011-11-14  Eric Seidel  <eric@webkit.org>
2704
2705         check-webkit-style broken by r99773: "Could not determine the port"
2706         https://bugs.webkit.org/show_bug.cgi?id=72275
2707
2708         Reviewed by Adam Barth.
2709
2710         The TestExpectationsChecker was using a generic try/except block
2711         which caught all exceptions, so we didn't notice that failing
2712         to pass a Host to PortFactory was causing an exception in port instantiation.
2713         I've factored out the "lookup the port" logic into a separate function
2714         which I've now unittested.  This should fix the bug and prevent
2715         others like it from occuring the the future.
2716
2717         * Scripts/webkitpy/style/checkers/test_expectations.py:
2718         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2719
2720 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
2721
2722         Add --css-grid-layout to build-webkit and the build systems
2723         https://bugs.webkit.org/show_bug.cgi?id=72320
2724
2725         Reviewed by Ojan Vafai.
2726
2727         * Scripts/build-webkit:
2728         Added the option.
2729
2730 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2731
2732         Unreviewed, rolling out r100192.
2733         http://trac.webkit.org/changeset/100192
2734         https://bugs.webkit.org/show_bug.cgi?id=72328
2735
2736         Caused infinite tests to fail (Requested by abarth on
2737         #webkit).
2738
2739         * Scripts/webkitpy/layout_tests/port/base.py:
2740         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2741
2742 2011-11-14  Tony Chang  <tony@chromium.org>
2743
2744         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
2745         https://bugs.webkit.org/show_bug.cgi?id=72196
2746
2747         Reviewed by Ojan Vafai.
2748
2749         * Scripts/build-webkit:
2750
2751 2011-11-14  John Yani  <vanuan@gmail.com>
2752
2753         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
2754         Override LOCALE to en_US.
2755
2756         Reviewed by Eric Seidel.
2757
2758         * Scripts/webkitpy/layout_tests/port/base.py:
2759
2760 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
2761
2762         [Chromium] build-webkit silently drops the features flags
2763         https://bugs.webkit.org/show_bug.cgi?id=72293
2764
2765         Reviewed by Tony Chang.
2766
2767         Chromium still ignores @features but now we give a warning!
2768
2769         * Scripts/build-webkit: Check if one of the features is different
2770         from the default and print a warning in this case.
2771
2772 2011-11-14  David Kilzer  <ddkilzer@apple.com>
2773
2774         run-leaks does not work on Lion?
2775         <http://webkit.org/b/71059>
2776         <rdar://problem/10428527>
2777
2778         Reviewed by Adam Roben.
2779
2780         The output of leaks(1) changed again in Lion to move the
2781         "leaks Report Version: 2.0" line from the first line of the
2782         output to just above the "Process " lines that run-leaks is
2783         interested in parsing.  This required using a more generic
2784         algorithm to find the start of the "Process " lines.
2785
2786         * Scripts/run-leaks:
2787         (parseLeaksOutput): Make the code to skip headers more generic.
2788         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
2789         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
2790         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
2791
2792 2011-11-14  Lei Zhang  <thestig@chromium.org>
2793
2794         Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
2795         https://bugs.webkit.org/show_bug.cgi?id=72088
2796
2797         Reviewed by Tony Chang.
2798
2799         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2800
2801 2011-11-14  Andrew Scherkus  <scherkus@chromium.org>
2802
2803         [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
2804         https://bugs.webkit.org/show_bug.cgi?id=72147
2805
2806         Reviewed by Adam Barth.
2807
2808         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2809
2810 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2811
2812         [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
2813
2814         Reviewed by Simon Hausmann.
2815
2816         * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
2817
2818 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
2819
2820         [Qt] Disable plugins on X11 for WK2
2821
2822         Reviewed by Kenneth Rohde Christiansen.
2823
2824         Currently plugins are in-process and they crash in the likely case of
2825         a plugin installation that uses Qt 4, which beautifully clashes with the
2826         Qt 5 based QtWebProcess.
2827
2828         * qmake/mkspecs/features/features.prf:
2829
2830 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2831
2832         [Qt] Add support for config tests for Qt 5
2833
2834         This allows us to build and run configure-tests at build
2835         time to determine if a given platform feature is available.
2836
2837         Reviewed by Simon Hausmann.
2838
2839         * Scripts/build-webkit:
2840         * Scripts/webkitdirs.pm:
2841         (qtFeatureDefaults):
2842         * qmake/configure.pro: Added.
2843         * qmake/mkspecs/features/features.prf:
2844         * qmake/sync.profile: Added.
2845
2846 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
2847
2848         [Qt] Remove the QStyle dependency in Qt's mobile theme
2849         https://bugs.webkit.org/show_bug.cgi?id=67773
2850
2851         This refactoring splits up RenderThemeQt with two
2852         subclasses, a QStyle-backed one, and a Mobile version
2853         that uses the old mobile theme for now.
2854
2855         QStyle availability is detected at compile time, and
2856         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
2857         environment variable.
2858
2859         Reviewed by Simon Hausmann.
2860
2861         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2862         (WTR::activateFonts):
2863         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
2864         based on availability of QtWidgets.
2865         * qmake/mkspecs/features/webcore.prf: cleanup.
2866
2867 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
2868
2869         Unreviewed, rolling out r100116.
2870         http://trac.webkit.org/changeset/100116
2871
2872         r100104 was rolled out, so no longer needed
2873
2874         * Scripts/run-bindings-tests:
2875
2876 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
2877
2878         Unreviewed, rolling out r100104.
2879         http://trac.webkit.org/changeset/100104
2880         https://bugs.webkit.org/show_bug.cgi?id=72247
2881
2882         broke windows builds
2883
2884         * Scripts/check-webkit-style:
2885         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2886         * Scripts/webkitpy/common/checkout/deps.py:
2887         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2888         * Scripts/webkitpy/common/checkout/scm/detection.py:
2889         * Scripts/webkitpy/common/checkout/scm/git.py:
2890         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2891         * Scripts/webkitpy/common/checkout/scm/svn.py:
2892         * Scripts/webkitpy/common/host.py:
2893         * Scripts/webkitpy/common/host_mock.py:
2894         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2895         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2896         * Scripts/webkitpy/layout_tests/port/base.py:
2897         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2898         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2899         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2900         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2901
2902 2011-11-14  Philippe Normand  <pnormand@igalia.com>
2903
2904         Unreviewed, build fix after r100104. run-binding-tests broke.
2905
2906         * Scripts/run-bindings-tests: Explicitely use scm.detection.
2907
2908 2011-11-13  Eric Seidel  <eric@webkit.org>
2909
2910         Add SCMDetector object to make scm detection mockable
2911         https://bugs.webkit.org/show_bug.cgi?id=72247
2912
2913         Reviewed by Adam Barth.
2914
2915         I think SCM detection may eventually be rolled into Checkout,
2916         but this patch at least makes it possible to mock code-paths
2917         which rely on scm detection.
2918         In the process of replacing callers of these free-functions
2919         I found that one of the functions was no longer used,
2920         and that one of the callers could instead just use the SCM
2921         object it already had access to through port.host.scm().
2922         I also discovered that I was not calling Host._initialize_scm()
2923         and thus host.scm() was always returning None!
2924
2925         * Scripts/check-webkit-style:
2926         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2927         * Scripts/webkitpy/common/checkout/deps.py:
2928         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2929         * Scripts/webkitpy/common/checkout/scm/detection.py:
2930         * Scripts/webkitpy/common/checkout/scm/git.py:
2931         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2932         * Scripts/webkitpy/common/checkout/scm/svn.py:
2933         * Scripts/webkitpy/common/host.py:
2934         * Scripts/webkitpy/common/host_mock.py:
2935         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2936         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2937         * Scripts/webkitpy/layout_tests/port/base.py:
2938         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2939         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2940         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2941         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2942
2943 2011-11-13  Gavin Peters  <gavinp@chromium.org>
2944
2945         command line control of webcore log channels in chromium DumpRenderTree
2946         https://bugs.webkit.org/show_bug.cgi?id=72126
2947         
2948         The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
2949         what chromium takes.
2950
2951         Reviewed by Kent Tamura.
2952
2953         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2954         (main):
2955
2956 2011-11-12  Ariya Hidayat  <ariya@sencha.com>
2957
2958         [Qt] Fix minor config typo in the build tool documentation
2959         https://bugs.webkit.org/show_bug.cgi?id=72194
2960
2961         Reviewed by Andreas Kling.
2962
2963         * qmake/README:
2964
2965 2011-11-11  Stephen Chenney  <schenney@chromium.org>
2966
2967         [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
2968         https://bugs.webkit.org/show_bug.cgi?id=49257
2969
2970         Adds the remaining missing layout test functionality for printing.
2971
2972         Reviewed by Darin Fisher.
2973
2974         * DumpRenderTree/chromium/LayoutTestController.cpp:
2975         (LayoutTestController::LayoutTestController): Add bindings for new JS methods
2976         (parsePageNumber): Method to parse JS arguments for a page number
2977         (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
2978         (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
2979         (LayoutTestController::isPageBoxVisible): get the visibility status for printing
2980         (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
2981         * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
2982
2983 2011-11-11  Darin Adler  <darin@apple.com>
2984
2985         Remove all releaseRef implementations except for RetainPtr
2986         https://bugs.webkit.org/show_bug.cgi?id=71423
2987
2988         Reviewed by Julien Chaffraix.
2989
2990         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2991         (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
2992
2993 2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>
2994
2995         Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
2996         https://bugs.webkit.org/show_bug.cgi?id=72090
2997
2998         Reviewed by Eric Seidel.
2999
3000         Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
3001         ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
3002
3003         yay! r100002.
3004
3005         * Scripts/webkitpy/common/checkout/changelog.py:
3006         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3007
3008 2011-11-11  Tony Chang  <tony@chromium.org>
3009
3010         Remove --force from gclient sync.  The bots seem to have made it past
3011         the update step.
3012
3013         * Scripts/update-webkit:
3014
3015 2011-11-11  Tony Chang  <tony@chromium.org>
3016
3017         Add --force to gclient sync. Once the cq bots cycle, we can remove
3018         this since it slows down the normal sync.
3019
3020         * Scripts/update-webkit:
3021
3022 2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>
3023
3024         When --force is used, also use --reset
3025         https://bugs.webkit.org/show_bug.cgi?id=72129
3026
3027         Reviewed by Dimitri Glazkov.
3028
3029         * Scripts/update-webkit-chromium:
3030
3031 2011-11-11  Tony Chang  <tony@chromium.org>
3032
3033         allow two chromium drivers to run at the same time in NRWT
3034         https://bugs.webkit.org/show_bug.cgi?id=72067
3035
3036         Reviewed by Dirk Pranke.
3037
3038         * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
3039             posix prevents the subprocesses from sharing the same fd for stdin.
3040             Sharing the same fd prevents us from closing the files unless all references
3041             to the fd are closed.
3042         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
3043             to adding a test for this, speed up a test (from 3sec to 0) by fixing
3044             the timeout override. It looks like it regressed in r95875.
3045
3046 2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3047
3048         Unreviewed, rolling out r99964.
3049         http://trac.webkit.org/changeset/99964
3050         https://bugs.webkit.org/show_bug.cgi?id=72124
3051
3052         Broke too many Qt tests (Requested by tronical_ on #webkit).
3053
3054         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3055         (WTR::activateFonts):
3056         * qmake/mkspecs/features/features.prf:
3057         * qmake/mkspecs/features/webcore.prf:
3058
3059 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
3060
3061         [Qt] Remove the QStyle dependency in Qt's mobile theme
3062         https://bugs.webkit.org/show_bug.cgi?id=67773
3063
3064         This refactoring splits up RenderThemeQt with two
3065         subclasses, a QStyle-backed one, and a Mobile version
3066         that uses the old mobile theme for now.
3067
3068         QStyle availability is detected at compile time, and
3069         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
3070         environment variable.
3071
3072         Reviewed by Simon Hausmann.
3073
3074         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3075         (WTR::activateFonts):
3076         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
3077         based on availability of QtWidgets.
3078         * qmake/mkspecs/features/webcore.prf: cleanup.
3079
3080 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3081
3082         [Qt] Add missing include to PlatformWebViewQt
3083
3084         Reviewed by Simon Hausmann.
3085
3086         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3087
3088 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3089
3090         [Qt] Fix incremental builds on Windows after buildsystem refactor
3091
3092         The qmake rules to ensure that we run make on the derived sources
3093         before running qmake on the target were inside a unix-scope, which
3094         resulted in flakey builds on Windows.
3095
3096         We now generate a rule on all platforms that ensures that "make qmake"
3097         will always run make on the derived sources. In addition, on platforms
3098         that have GNU make (where "make incremental" does not run "make qmake",
3099         but only "make"), we add a similar rule that ensures that any time the
3100         target makefile is regenerated we first run qmake and make on the derived
3101         sources. This rule relies on GNU make's order-only-prerequisites to
3102         not trigger a qmake-run of the target every time we run make.
3103
3104         https://bugs.webkit.org/show_bug.cgi?id=71778
3105
3106         Reviewed by Simon Hausmann.
3107
3108         * qmake/mkspecs/features/functions.prf:
3109
3110 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
3111
3112         [Qt][WK2] Remove QWebNavigationController
3113         https://bugs.webkit.org/show_bug.cgi?id=72113
3114
3115         Reviewed by Andreas Kling.
3116
3117         Adapt to the move of the QWebNavigationController functions/properties to
3118         QQuickWebView.
3119
3120         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3121         * MiniBrowser/qt/qml/BrowserWindow.qml:
3122
3123 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
3124
3125         [Qt] Build system tweak
3126
3127         Reviewed by Tor Arne Vestbø.
3128
3129         Be a good qmake citizen, return true from our linkStaticLibrary
3130         "test" function.
3131
3132         * qmake/mkspecs/features/functions.prf:
3133
3134 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
3135
3136         [Qt] Add support for QT += webkit-private
3137
3138         Reviewed by Tor Arne Vestbø.
3139
3140         * qmake/qt_webkit.pri: Declare private headers.
3141
3142 2011-11-11  Philippe Normand  <pnormand@igalia.com>
3143
3144         Unreviewed, build fix attempt after r99907. Since that revision
3145         GTK layout tests were not running at all...
3146
3147         * Scripts/webkitpy/layout_tests/port/gtk.py:
3148
3149 2011-11-10  Andrew Scherkus  <scherkus@chromium.org>
3150
3151         [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
3152         https://bugs.webkit.org/show_bug.cgi?id=72001
3153
3154         Reviewed by Dirk Pranke.
3155
3156         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3157
3158 2011-11-05  Filip Pizlo  <fpizlo@apple.com>
3159
3160         bencher script should support remote benchmarking
3161         https://bugs.webkit.org/show_bug.cgi?id=71618
3162
3163         Rubber-stamped by Geoff Garen.
3164         
3165         Added the following features:
3166         
3167         - Benchmark report tells you the hostname and machine model (according to
3168           'sysctl hw.model') of the machine you did the run on, and svn revision number
3169           (according to 'svn info') of the VMs you're testing.
3170         
3171         - The --remote option. You give this an ssh-style hostname (i.e. user@host is
3172           acceptable, in addition to just host, in which case your username is used)
3173           and it automatically packages the build directories of the VMs you're testing,
3174           sends them to the remote machine along with your copy of the bencher script
3175           and all of the options you passed.  This pretty much seamlessly allows you
3176           to run a set of benchmarks on any machine that is sufficiently compatible with
3177           yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
3178           must now include a tempPath setting that tells bencher where to put files
3179           when that machine is used as a slave in a remote benchmarking run.
3180           
3181         - Added yet another way of specifying which benchmarks to run. This was sort of
3182           necessary for --remote to work as expected. Previously, you either said what
3183           suites to exclude (for example --exclude-sunspider) or that you only wanted
3184           to run one suite to the exclusion of others (--sunspider-only). But it's
3185           often better to just be able to specify the list of suites you want. This is
3186           now supported. You can say, for example, --v8 --sunspider, which means, just
3187           run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
3188           still supported.
3189
3190         * Scripts/bencher:
3191
3192 2011-11-10  Tony Chang  <tony@chromium.org>
3193
3194         Lazily start DRT instances in NRWT
3195         https://bugs.webkit.org/show_bug.cgi?id=72038
3196
3197         Reviewed by Eric Seidel.
3198
3199         Just a refactoring, no new tests.
3200
3201         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3202         * Scripts/webkitpy/layout_tests/port/chromium.py:
3203         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3204         * Scripts/webkitpy/layout_tests/port/test.py:
3205         * Scripts/webkitpy/layout_tests/port/webkit.py:
3206
3207 2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>
3208
3209         ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
3210         https://bugs.webkit.org/show_bug.cgi?id=72057
3211
3212         Reviewed by Eric Seidel.
3213
3214         Make the regular expression more explicit.
3215
3216         * Scripts/webkitpy/common/checkout/changelog.py:
3217         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3218
3219 2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>
3220
3221         [Qt] X11 plugins need to be reworked for Qt5
3222         https://bugs.webkit.org/show_bug.cgi?id=70023
3223
3224         Reviewed by Simon Hausmann.
3225
3226         Rework our basic plugin support in a way that does
3227         not need a bridge between Qt and X. The solution is
3228         based on getting the content drawed by the plugin
3229         from the server as an image and creating a QImage
3230         from it.
3231
3232         * qmake/mkspecs/features/features.prf: Enable X11
3233         plugins if Qt is built with the xcb-xlib backend.
3234
3235 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
3236
3237         [Qt] Fix keyboard related layout tests after API refactoring
3238
3239         Reviewed by Tor Arne Vestbø.
3240
3241         Send key events to the handling page item, not the view.
3242
3243         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3244         (WTR::PlatformWebView::sendEvent):
3245         (WTR::PlatformWebView::postEvent):
3246
3247 2011-11-10  Alexandre Mazari  <amazari@igalia.com>
3248
3249         [GTK] Make the ENABLE(FEATURE) macro work in DRT
3250         https://bugs.webkit.org/show_bug.cgi?id=71940
3251
3252         Reviewed by Philippe Normand.
3253
3254         * GNUmakefile.am:
3255         Add webcore_cppflags to Programs_DumpRenderTree_CPP so
3256         ENABLE_* variables are part of the environment.
3257
3258 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
3259
3260         [Qt] Fix focus related layout tests after API refactoring
3261
3262         Reviewed by Tor Arne Vestbø.
3263
3264         Make sure the focus is set on the page now, not on the view
3265         (which doesn't actually handle the focus).
3266
3267         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3268         (WTR::WrapperWindow::WrapperWindow):
3269         (WTR::WrapperWindow::handleStatusChanged):
3270
3271 2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>
3272
3273         [Qt] Merge QTouchWebView and QDesktopWebView into one class
3274         https://bugs.webkit.org/show_bug.cgi?id=71355
3275
3276         Reviewed by Kenneth Rohde Christiansen.
3277
3278         Make MiniBrowser and WebKitTestRunner work again after the
3279         merge.
3280
3281         * MiniBrowser/qt/BrowserWindow.cpp:
3282         (BrowserWindow::BrowserWindow):
3283         (BrowserWindow::webView):
3284         * MiniBrowser/qt/MiniBrowser.pro:
3285         * MiniBrowser/qt/MiniBrowser.qrc:
3286         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3287         * MiniBrowser/qt/main.cpp:
3288         * MiniBrowser/qt/qml/BrowserWindow.qml:
3289         * MiniBrowser/qt/qml/DesktopView.qml: Removed.
3290         * MiniBrowser/qt/qml/TouchView.qml: Removed.
3291         * WebKitTestRunner/PlatformWebView.h:
3292         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3293         (WTR::PlatformWebView::PlatformWebView):
3294
3295 2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3296
3297         [Qt] Change semantics of the haveQt() function to match API promises
3298
3299         Having Qt 5 does not imply that we have Qt 4, from an API point of
3300         view, as a major version can in theory break BC/SC. Our minimum
3301         version of Qt 4 will always be the latest released version of Qt 4,
3302         so the only place we should use haveQt(4, x) is when checking for
3303         the minimum requirements.
3304
3305         Reviewed by Simon Hausmann.
3306
3307         * qmake/mkspecs/features/default_pre.prf:
3308         * qmake/mkspecs/features/features.prf:
3309         * qmake/mkspecs/features/functions.prf:
3310
3311 2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>
3312
3313         [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
3314         https://bugs.webkit.org/show_bug.cgi?id=69411
3315
3316         Reviewed by Martin Robinson.
3317
3318         * WebKitTestRunner/EventSenderProxy.h:
3319         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3320         * WebKitTestRunner/TestController.cpp:
3321         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3322         use the EventSender instead of WebProcess Event Simulation.
3323         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3324         (WTR::WTREventQueueItem::WTREventQueueItem):
3325         (WTR::EventSenderProxy::EventSenderProxy):
3326         (WTR::getMouseButtonModifiers):
3327         (WTR::eventSenderButtonToGDKButton):
3328         (WTR::EventSenderProxy::createMouseButtonEvent):
3329         (WTR::EventSenderProxy::updateClickCountForButton):
3330         (WTR::EventSenderProxy::replaySavedEvents):
3331         (WTR::EventSenderProxy::sendOrQueueEvent):
3332         (WTR::webkitModifiersToGDKModifiers):
3333         (WTR::getGDKKeySymForKeyRef):
3334         (WTR::EventSenderProxy::keyDown):
3335         (WTR::EventSenderProxy::mouseDown):
3336         (WTR::EventSenderProxy::mouseUp):
3337         (WTR::EventSenderProxy::mouseMoveTo):
3338         (WTR::EventSenderProxy::mouseScrollBy):
3339         (WTR::EventSenderProxy::leapForward):
3340
3341 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3342
3343         [Qt] Enable exports and constructor functions in static libs
3344
3345         Reviewed by Tor Arne Vestbø.
3346
3347         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
3348         mac/win32-msvc equivalents when linking static libraries into a shared
3349         library or executable.
3350
3351 2011-11-09  Hayato Ito  <hayato@chromium.org>
3352
3353         [NRWT] Make results.html aware of reference filename in reftests.
3354         https://bugs.webkit.org/show_bug.cgi?id=71574
3355
3356         Reviewed by Ryosuke Niwa.
3357
3358         If a reference filename is different from the default one, include that in result summary
3359         so results.html can link to the correct reference file.
3360
3361         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3362         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3363
3364 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
3365
3366         [wx] Unreviewed build fix. Update project files and
3367         add LTC stubs for new methods.
3368
3369         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3370         (LayoutTestController::addChromeInputField):
3371         (LayoutTestController::removeChromeInputField):
3372         (LayoutTestController::focusWebView):
3373         (LayoutTestController::setBackingScaleFactor):
3374         * waf/build/settings.py:
3375
3376 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
3377
3378         [wx] Unreviewed build fix. Support XCode 4 when building deps.
3379
3380         * wx/install-unix-extras:
3381
3382 2011-11-09  Eric Seidel  <eric@webkit.org>
3383
3384         Remove the concept of platform-dependent unittests
3385         https://bugs.webkit.org/show_bug.cgi?id=71963
3386
3387         Unreviewed.  Fix test-webkitpy on cygwin.
3388
3389         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3390
3391 2011-11-09  Dana Jansens  <danakj@chromium.org>
3392
3393         Add cc-bugs group to watch changes in chromium graphics
3394         https://bugs.webkit.org/show_bug.cgi?id=71690
3395
3396         Reviewed by David Levin.
3397
3398         * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
3399         * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
3400         * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
3401         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
3402
3403 2011-11-09  Eric Seidel  <eric@webkit.org>
3404
3405         Remove more platform-dependent unittests
3406         https://bugs.webkit.org/show_bug.cgi?id=71971
3407
3408         Reviewed by Adam Barth.
3409
3410         Tests which only run on a couple platforms will break.
3411         All tests should run on all platforms where possible.
3412
3413         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3414         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3415         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3416         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3417
3418 2011-11-09  Ojan Vafai  <ojan@chromium.org>
3419
3420         Merge in results to the test results server even if build numbers conflict
3421         https://bugs.webkit.org/show_bug.cgi?id=71967
3422
3423         Reviewed by Tony Chang.
3424
3425         This was initially meant to be a sanity check that we don't
3426         enter duplicate runs, but it turns out that we can reasonably get
3427         in these situations when a builder is clobbered (e.g. the build
3428         numbers start over again from 0).
3429
3430         * TestResultServer/model/jsonresults.py:
3431         * TestResultServer/model/jsonresults_unittest.py:
3432
3433 2011-11-09  Eric Seidel  <eric@webkit.org>
3434
3435         Remove the concept of platform-dependent unittests
3436         https://bugs.webkit.org/show_bug.cgi?id=71963
3437
3438         Reviewed by Adam Barth.
3439
3440         These have been the source of never-ending sadness.
3441         We'd change behavior and forget to update results in
3442         some unittests because they were only run on certain platforms.
3443         This change removes a large source of these platform-dependent
3444         unittests, which was caused by the port_maker stuff.
3445
3446         It's possible that this change will break test-webkitpy
3447         on some platforms, but that will be a one-time cost.
3448         I will fix the breakage by removing the platform-dependantness
3449         of any such broken tests.
3450
3451         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3452         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3453         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3454         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3455         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3456         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3457         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3458         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3459         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3460         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3461         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3462         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3463         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3464
3465 2011-11-09  Eric Seidel  <eric@webkit.org>
3466
3467         Make the Port object have a Host
3468         https://bugs.webkit.org/show_bug.cgi?id=71961
3469
3470         Reviewed by Adam Barth.
3471
3472         This has been a long time coming.
3473         Now that Port has a Host object, it's very easy
3474         to write unittests which use a properly mocked Port.
3475         Soon we will remove the executive, filesystem and user
3476         members of Port and get everything through the Host.
3477
3478         Note how in many callsites we're actually removing
3479         explicit mocks, since we're now always going to get the
3480         correct Executive/User/FileSystem from the
3481         Host and callsites don't need to be careful to pass each one.
3482
3483         This is prep-work for adding a new Environment member to
3484         Host and needing to be able to access the Environment
3485         member from Port functions w/o needing to pass an Environment
3486         object (or appropriate Mock) every place we create a Port object.
3487         Now that we have a single Host object to reach out through, its
3488         simple to add additional functionality (like Environment) while
3489         keeping our unittests properly mocked.
3490
3491         * Scripts/webkitpy/common/host.py:
3492         * Scripts/webkitpy/common/net/credentials_unittest.py:
3493         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3494         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3495         * Scripts/webkitpy/layout_tests/port/apple.py:
3496         * Scripts/webkitpy/layout_tests/port/base.py:
3497         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3498         * Scripts/webkitpy/layout_tests/port/chromium.py:
3499         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3500         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3501         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3502         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3503         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3504         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3505         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3506         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3507         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3508         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3509         * Scripts/webkitpy/layout_tests/port/efl.py:
3510         * Scripts/webkitpy/layout_tests/port/factory.py:
3511         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3512         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3513         * Scripts/webkitpy/layout_tests/port/gtk.py:
3514         * Scripts/webkitpy/layout_tests/port/mac.py:
3515         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3516         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3517         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3518         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3519         * Scripts/webkitpy/layout_tests/port/qt.py:
3520         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3521         * Scripts/webkitpy/layout_tests/port/test.py:
3522         * Scripts/webkitpy/layout_tests/port/webkit.py:
3523         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3524         * Scripts/webkitpy/layout_tests/port/win.py:
3525         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3526         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3527         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3528         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3529         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3530
3531 2011-11-09  Dominic Mazzoni  <dmazzoni@google.com>
3532
3533         [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
3534         https://bugs.webkit.org/show_bug.cgi?id=71561
3535
3536         Reviewed by Dimitri Glazkov.
3537
3538         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3539         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
3540
3541 2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
3542
3543         Implement dumpProgressFinishedCallback() for Mac layoutTestController
3544         https://bugs.webkit.org/show_bug.cgi?id=66772
3545
3546         Reviewed by Simon Fraser.
3547
3548         When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
3549         "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
3550
3551         On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
3552         in the FrameLoadDelegate and print the output in response to the notification.
3553
3554         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3555         (-[FrameLoadDelegate init]):
3556         (-[FrameLoadDelegate dealloc]):
3557         (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
3558
3559 2011-11-09  Philippe Normand  <pnormand@igalia.com>
3560
3561         [GTK][DRT] window internals object is not reset after each test
3562         https://bugs.webkit.org/show_bug.cgi?id=71890
3563
3564         Reviewed by Martin Robinson.
3565
3566         Call WebCoreTestSupport::resetInternalsObject without going
3567         through DumpRenderTreeSupport.
3568
3569         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3570         (runTest):
3571
3572 2011-11-09  Beth Dakin  <bdakin@apple.com>
3573
3574         Build fix.
3575
3576         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3577         (AccessibilityUIElement::uiElementAttributeValue):
3578
3579 2011-11-09  Beth Dakin  <bdakin@apple.com>
3580
3581         Speculative build fix.
3582
3583         * DumpRenderTree/AccessibilityUIElement.h:
3584
3585 2011-11-09  Julien Chaffraix  <jchaffraix@webkit.org>
3586
3587         Unreviewed build fix.
3588
3589         * DumpRenderTree/AccessibilityUIElement.cpp:
3590         (AccessibilityUIElement::makeJSAccessibilityUIElement):
3591         A bad merge added this check that is making the bots sad.
3592
3593 2011-11-09  Chris Fleizach  <cfleizach@apple.com>
3594
3595         AX: crash when accessing selectedTab in a tab list
3596         https://bugs.webkit.org/show_bug.cgi?id=70938
3597
3598         Reviewed by Beth Dakin.
3599
3600         Add the ability to retrieve an element through an arbitrary attribute.
3601
3602         * DumpRenderTree/AccessibilityUIElement.cpp:
3603         (uiElementAttributeValueCallback):
3604         (AccessibilityUIElement::uiElementAttributeValue):
3605         (AccessibilityUIElement::getJSClass):
3606         * DumpRenderTree/AccessibilityUIElement.h:
3607         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3608         (AccessibilityUIElement::uiElementAttributeValue):
3609
3610 2011-11-09  Andy Wingo  <wingo@igalia.com>
3611
3612         Add webkitdirs.pm:getArchitecture implementation for GTK
3613         https://bugs.webkit.org/show_bug.cgi?id=71370
3614
3615         Reviewed by Xan Lopez.
3616
3617         * Scripts/webkitdirs.pm (determineArchitecture): Add an
3618         implementation for ports using autotools, so that a vanilla
3619         `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
3620         to build-jsc on x86-64 machines.
3621
3622 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3623
3624         Unreviewed, rolling out r99707.
3625         http://trac.webkit.org/changeset/99707
3626
3627         Re-enable until we can disable it together with tests in one
3628         shot.
3629
3630         * qmake/mkspecs/features/features.prf:
3631
3632 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>