94a1e232d6fe3e8fed443cf202c4df013b7745b4
[WebKit-https.git] / Tools / ChangeLog
1 2010-12-23  Evan Martin  <evan@chromium.org>
2
3         Reviewed by Ryosuke Niwa.
4
5         [chromium] LayoutTestController warning in float->int conversion
6         https://bugs.webkit.org/show_bug.cgi?id=51553
7
8         Rather than reading an int, converting to a float, then getting a compiler
9         warning on passing the float to something that expects an int, instead
10         just pass around ints.
11
12         No tests, fixes a compiler warning.
13
14         * DumpRenderTree/chromium/LayoutTestController.cpp:
15         (parsePageSizeParameters):
16         (LayoutTestController::pageNumberForElementById):
17         (LayoutTestController::numberOfPages):
18
19 2010-12-23  Lucas Forschler  <lforschler@apple.com>
20
21         Reviewed by Darin Adler.
22
23         Bug 51537 - iexploder needs cleanup
24         
25         * iExploder/htdocs: Removed.
26         * iExploder/htdocs/config.rb: Removed.
27         * iExploder/htdocs/cssproperties.in: Removed.
28         * iExploder/htdocs/cssvalues.in: Removed.
29         * iExploder/htdocs/htmlattrs.in: Removed.
30         * iExploder/htdocs/htmltags.in: Removed.
31         * iExploder/htdocs/htmlvalues.in: Removed.
32         * iExploder/htdocs/iexploder.cgi: Removed.
33         * iExploder/htdocs/iexploder.rb: Removed.
34         * iExploder/htdocs/index.html: Removed.
35         * iExploder/htdocs/webserver.rb: Removed.
36         * iExploder/iexploder-1.7.2/output: Removed.
37         * iExploder/tools: Removed.
38         * iExploder/tools/lasthit.rb: Removed.
39         * iExploder/tools/osx_last_crash.rb: Removed.
40         * iExploder/tools/showtest.rb: Removed.
41
42 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
43
44         Reviewed by Kenneth Rohde Christiansen.
45
46         [EFL] Make 'single' the default backing store in EWebLauncher
47         https://bugs.webkit.org/show_bug.cgi?id=51534
48
49         'single' is the simplest backing store and the one intended to be the
50         default in the test browser. By mistake the tiled backing store was
51         left as default in r72617.
52
53         * EWebLauncher/main.c:
54         (browserCreate): ditto.
55
56 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
57
58         Reviewed by Kenneth Rohde Christiansen.
59
60         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
61         https://bugs.webkit.org/show_bug.cgi?id=51533
62
63         There's no point in concatenating env("HOME") with "blah", so remove
64         option from EWebLauncher.
65
66         * EWebLauncher/main.c:
67         (main): ditto.
68
69 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
70
71         Reviewed by Eric Seidel.
72
73         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
74
75         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
76         I just discovered that we have two additional GC runs per each WebViewHost.
77         Test_shell had no such calls.
78         These gc runs eat 15% of cpu time.
79
80         https://bugs.webkit.org/show_bug.cgi?id=51479
81
82         * DumpRenderTree/chromium/WebViewHost.cpp:
83         (WebViewHost::~WebViewHost):
84
85 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
86
87         Reviewed by Ojan Vafai.
88
89         This change splits out the TestRunner class into its own file.
90         When we fork the code for message passing, we will create a new
91         TestRunner, and this change will allow that to be more modular.
92
93         While we're at it, split out TestInput and ResultSummary into
94         their own files, to reduce the size of run_webkit_tests to
95         something more managable.
96
97         https://bugs.webkit.org/show_bug.cgi?id=51092
98
99         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
100         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
101         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
102         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
103         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
104         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
105         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
106
107  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
108
109         Reviewed by Ojan Vafai.
110
111         nrwt multiprocessing - start over, prepare to fork the code
112  
113         This code cleans up the signatures and implementation of the
114         TestRunner class so we can easily fork it to run either the
115         stable implementation or the new, unstable message-passing
116         implementation. The two variants will have different
117         implementations of the run_tests() method. We will switch
118         between the two based on the setting for the '--worker-model'
119         switch. We rename the two currently valid values to 'old-inline'
120         and 'old-threads'.
121
122         https://bugs.webkit.org/show_bug.cgi?id=51081
123
124         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
125         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
126
127 2010-12-22  Victor Wang  <victorw@chromium.org>
128
129         Reviewed by Darin Fisher.
130
131         [Chromium] Update chromium archive test result url in rebaseline script.
132
133         https://bugs.webkit.org/show_bug.cgi?id=51503
134
135         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
136
137 2010-12-22  Lucas Forschler  <lforschler@apple.com>
138
139         Reviewed by Alice Liu.
140
141         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
142         Verified on Chrome, Safari, and IE.
143         With this change, we will record memory from a parent browser window and all child processes.
144
145         * record-memory-win/main.cpp:
146         (ProcessArgs):
147         (PrintUsage):
148         (getMemoryInfo):
149         (printProcessInfo):
150         (evalProcesses):
151         (UseImage):
152         (QueryContinuously):
153         (ElapsedTime):
154
155 2010-12-22  Lucas Forschler  <lforschler@apple.com>
156
157         Unreviewed rollout r74489, because it was missing changelog.
158
159         * record-memory-win/main.cpp:
160         
161 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
162
163         Adding myself as a reviewer.
164
165         * Scripts/webkitpy/common/config/committers.py:
166
167 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
168
169         Unreviewed.  Adding myself to committers.py.
170
171         * Scripts/webkitpy/common/config/committers.py:
172
173 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
174
175         Reviewed by Kenneth Rohde Christiansen.
176
177         TestNetscapePlugIn should use #if defined
178         https://bugs.webkit.org/show_bug.cgi?id=51471
179
180         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
181         (NP_Initialize):
182         (NPP_New):
183
184 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
185
186         Reviewed by Yury Semikhatsky.
187
188         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
189
190         DevTools window should be closed explicitly because it has custom deinitialization code.
191
192         https://bugs.webkit.org/show_bug.cgi?id=50722
193
194         * DumpRenderTree/chromium/TestShell.cpp:
195         (TestShell::closeRemainingWindows):
196
197 2010-12-22  David Levin  <levin@chromium.org>
198
199         Reviewed by Shinichiro Hamaji.
200
201         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
202         https://bugs.webkit.org/show_bug.cgi?id=51452
203
204         * Scripts/webkitpy/style/checkers/cpp.py:
205         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
206         Using the file extension if possible but falling back to the file contents if we have a header file.
207         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
208         (_FileState.is_c_or_objective_c):
209         (check_using_std): Changed to using _FileState to determine the file type.
210         (check_max_min_macros): Ditto.
211         (check_for_null): Ditto.
212         (check_style): Changed the parameters to various calls since they now need _FileState
213         to determine the file type.
214         (check_language): Added the file_state parameter so it could be passed
215         to check_identifier_name_in_declaration.
216         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
217         this is an Objective C file.
218         (_process_lines): Added information for the _FileState constructor (and moved the
219         call to a place that had the information).
220         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
221         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
222         its functionality.
223         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
224
225 2010-12-21  Andy Estes  <aestes@apple.com>
226
227         Reviewed by Mark Rowe.
228
229         Do not build non-Intel architectures for WebKit2-related projects.
230         https://bugs.webkit.org/show_bug.cgi?id=51440
231
232         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
233         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
234         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
235
236 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
237
238         Reviewed by Darin Fisher.
239
240         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
241         https://bugs.webkit.org/show_bug.cgi?id=51406 
242         
243         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
244         to WebThemeEngineDRTWin and update references everywhere.
245
246         * DumpRenderTree/DumpRenderTree.gypi:
247         * DumpRenderTree/chromium/TestShellWin.cpp:
248         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
249         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
250         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
251         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
252
253 2010-12-21  Anders Carlsson  <andersca@apple.com>
254
255         Reviewed by John Sullivan.
256
257         Clicking missing plug-in text does not show a sheet
258         https://bugs.webkit.org/show_bug.cgi?id=51403
259
260         Update for changes to the WebPageUIClient.
261
262         * MiniBrowser/mac/BrowserWindowController.m:
263         (-[BrowserWindowController awakeFromNib]):
264         * WebKitTestRunner/TestController.cpp:
265         (WTR::createOtherPage):
266         (WTR::TestController::initialize):
267
268 2010-12-21  Eric Seidel  <eric@webkit.org>
269
270         Reviewed by Adam Barth.
271
272         commit-queue will report constant failures as flaky if other tests flake
273         https://bugs.webkit.org/show_bug.cgi?id=51272
274
275         This patch just removes functionality and adds testing.
276         Previously we attempted to report flaky tests when we had
277         two different tests fail in a row.  However, since we stop
278         running the tests at the first failure, our code was wrong in
279         trying to determine flakiness from the incomplete runs.
280
281         Originally I posted an alternate patch:
282         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
283         which fixed our flaky logic in this case, however it was decided
284         that that patch would be too difficult to maintain, so now
285         I'm just removing the broken logic.
286
287         This will dramatically cut-down on our flaky-test false positives
288         at the (small) cost of the queues being unable to report
289         any flakiness if the tree is very flaky.  (With at least one test
290         flaking on every run, we'll never report failures anymore.)  I think
291         this is a tradeoff worth making.
292
293         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
294         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
295
296 2010-12-20  Eric Seidel  <eric@webkit.org>
297
298         Reviewed by Adam Barth.
299
300         commit-queue wrongly rejects patches when it can't update itself
301         https://bugs.webkit.org/show_bug.cgi?id=46636
302
303         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
304         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
305         * Scripts/webkitpy/tool/commands/queues_unittest.py:
306
307 2010-12-20  Adam Barth  <abarth@webkit.org>
308
309         Move web sites to Websites directory
310         https://bugs.webkit.org/show_bug.cgi?id=51323
311
312         Update references to BugsSite to point to the new location.
313
314         This patch was never officially reviewed (because it was too large to
315         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
316         Rowe gave me the green light.
317
318         * Scripts/old-run-webkit-tests:
319         * Scripts/webkitpy/common/config/build.py:
320         * Scripts/webkitpy/common/config/build_unittest.py:
321         * Scripts/webkitpy/common/prettypatch.py:
322         * Scripts/webkitpy/layout_tests/port/base.py:
323         * Scripts/webkitpy/style/main.py:
324
325 2010-12-20  Adrienne Walker  <enne@google.com>
326
327         Unreviewed. Adding myself to the list of committers.
328
329         * webkitpy/common/config/committers.py:
330
331 2010-12-20  Mark Rowe  <mrowe@apple.com>
332
333         Reviewed by Dan Bernstein.
334
335         <rdar://problem/8757601> Don't install header files in to the Resources directory.
336
337         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
338         Resources directory.
339
340 2010-12-20  Eric Seidel  <eric@webkit.org>
341
342         Reviewed by Adam Barth.
343
344         commit-queue should include bot id when attaching failure diffs
345         https://bugs.webkit.org/show_bug.cgi?id=51280
346
347         This is a tiny change to include the bot id in the name of the attachment.
348         Most of this diff is just changing the unit test expectations
349         now that I hid the comment printing when the comment is None.
350
351         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
352         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
353         * Scripts/webkitpy/tool/commands/upload_unittest.py:
354         * Scripts/webkitpy/tool/mocktool.py:
355
356 2010-12-20  Jeff Miller  <jeffm@apple.com>
357
358         Reviewed by Dan Bernstein.
359
360         Tools/vcbin/midl.exe needs to be rebuilt
361         https://bugs.webkit.org/show_bug.cgi?id=51347
362
363         * vcbin/midl.exe: Rebuilt.
364
365 2010-12-20  David Levin  <levin@chromium.org>
366
367         Reviewed by Ariya Hidayat.
368
369         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
370         https://bugs.webkit.org/show_bug.cgi?id=51343
371
372         Follow up from the WebKitTools -> Tools rename.
373
374         * Scripts/webkit-tools-completion.sh:
375
376 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
377
378         Reviewed by James Robinson.
379
380         new-run-webkit-tests ignores trailing EOL differences in text tests
381         https://bugs.webkit.org/show_bug.cgi?id=36983
382
383         Changed the handling of new-line characters within new-run-webkit-tests
384         to match old-run-webkit-tests.  Differences in leading and trailing empty
385         lines in text expectation files are no longer ignored.
386
387         * Scripts/webkitpy/layout_tests/port/base.py:
388         * Scripts/webkitpy/layout_tests/port/test.py:
389         Added unit tests.  Removed old duplicate unit test entries.
390         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
391
392 2010-12-20  David Levin  <levin@chromium.org>
393
394         Reviewed by Shinichiro Hamaji.
395
396         check-webkit-style should detect function declarations (and trivial functions).
397         https://bugs.webkit.org/show_bug.cgi?id=51303
398
399         * Scripts/webkitpy/style/checkers/cpp.py:
400         (_FunctionState.begin): Add is_declaration and changed the line count
401         start to begin at -1 (which will keep the results consistent, since
402         the starting line number passed in is one less in this change).
403         (detect_functions): changed function detection to now catch trivial
404         functions and declarations.
405         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
406         of the function as this may look at return values (when processing
407         a declaration).
408         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
409         (FunctionDetectionTest.perform_function_detection): Basic mechanics
410         of testing the function detection.
411         (FunctionDetectionTest.test_basic_function_detection): Test a simple
412         function.
413         (FunctionDetectionTest.test_function_declaration_detection): Test a
414         declaration.
415         (FunctionDetectionTest.test_non_functions): A test case for a case
416         that caused the code to fail due to the { being in quotes.
417         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
418         cases to help catch false alarms for return values.
419         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
420         we don't get false alarms for member variables either.
421
422 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
423
424         Reviewed by Antonio Gomes.
425
426         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
427         https://bugs.webkit.org/show_bug.cgi?id=51319
428
429         * CMakeListsEfl.txt:
430
431 2010-12-18  Adam Barth  <abarth@webkit.org>
432
433         Reviewed by Sam Weinig.
434
435         Move WebKitExamplePlugins to Examples
436         https://bugs.webkit.org/show_bug.cgi?id=51291
437
438         * Scripts/webkitpy/common/config/build.py:
439
440 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
441
442         Unreviewed Qt buildfix after r74301.
443
444         Rename WebKitTools to Tools
445         https://bugs.webkit.org/show_bug.cgi?id=49861
446
447         * MiniBrowser/DerivedSources.pro:
448         * MiniBrowser/qt/MiniBrowser.pro:
449
450 2010-12-17  Dan Bernstein  <mitz@apple.com>
451
452         Reviewed by Simon Fraser.
453
454         Rename WebKitTools to Tools
455         https://bugs.webkit.org/show_bug.cgi?id=49861
456
457         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
458         * CodeCoverage/README:
459         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
460         (WebCore::DumpRenderTree::initializeFonts):
461         * EWSTools/start-commit-queue.sh:
462         * EWSTools/start-queue.sh:
463         * GNUmakefile.am:
464         * MIDLWrapper/MIDLWrapper.cpp:
465         (wmain):
466         * MiniBrowser/qt/MiniBrowser.pro:
467         * Scripts/build-api-tests:
468         * Scripts/build-dumprendertree:
469         * Scripts/build-webkit:
470         * Scripts/build-webkittestrunner:
471         * Scripts/generate-coverage-data:
472         * Scripts/old-run-webkit-tests:
473         * Scripts/run-api-tests:
474         * Scripts/run-iexploder-tests:
475         * Scripts/run-javascriptcore-tests:
476         * Scripts/run-mangleme-tests:
477         * Scripts/run-sunspider:
478         * Scripts/run-webkit-websocketserver:
479         * Scripts/sunspider-compare-results:
480         * Scripts/test-webkitperl:
481         * Scripts/test-webkitpy:
482         * Scripts/update-iexploder-cssproperties:
483         * Scripts/update-webkit:
484         * Scripts/update-webkit-localizable-strings:
485         * Scripts/webkitdirs.pm:
486         * Scripts/webkitpy/common/checkout/scm.py:
487         * Scripts/webkitpy/common/checkout/scm_unittest.py:
488         * Scripts/webkitpy/common/config/committervalidator.py:
489         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
490         * Scripts/webkitpy/common/config/ports.py:
491         * Scripts/webkitpy/common/config/ports_unittest.py:
492         * Scripts/webkitpy/common/system/logutils_unittest.py:
493         * Scripts/webkitpy/common/system/ospath_unittest.py:
494         * Scripts/webkitpy/layout_tests/port/chromium.py:
495         * Scripts/webkitpy/layout_tests/port/config.py:
496         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
497         * Scripts/webkitpy/layout_tests/port/http_server.py:
498         * Scripts/webkitpy/layout_tests/port/test.py:
499         * Scripts/webkitpy/style/checker.py:
500         * Scripts/webkitpy/style/checker_unittest.py:
501         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
502         * Scripts/webkitpy/tool/commands/queues_unittest.py:
503         * Scripts/webkitpy/tool/steps/steps_unittest.py:
504         * WebKitTestRunner/DerivedSources.pro:
505         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
506         (WTR::activateFonts):
507         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
508         * wx/build/build_utils.py:
509
510 2010-12-16  Antonio Gomes  <agomes@rim.com>
511
512         Reviewed by Martin Robinson.
513
514         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
515         https://bugs.webkit.org/show_bug.cgi?id=51163
516
517         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
518         GTK+'s DRT should also reset to UNIX after each test execution.
519
520         * DumpRenderTree/gtk/DumpRenderTree.cpp:
521         (resetDefaultsToConsistentValues):
522
523 2010-12-17  David Levin  <levin@chromium.org>
524
525         Reviewed by Eric Seidel.
526
527         check-webkit-style should understand WTF #include guards
528         https://bugs.webkit.org/show_bug.cgi?id=44911
529
530         * Scripts/webkitpy/style/checkers/cpp.py:
531         (get_header_guard_cpp_variable): modify to suggest the WTF style
532         of header guard when appropriate.
533         (check_for_header_guard): handle multiple return values from
534         get_header_guard_cpp_variable
535         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
536         (CppStyleTest.test_build_header_guard): Added tests for the WTF
537         header style.
538
539 2010-12-16  David Levin  <levin@chromium.org>
540
541         Reviewed by Eric Seidel.
542
543         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
544         https://bugs.webkit.org/show_bug.cgi?id=51210
545
546         The error only shows up when using python 2.6 or later.
547
548         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
549         the decprecated field error,message with something equivalent.
550
551 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
552
553         Reviewed by Eric Seidel.
554
555         Add --exit-after-n-failures/crashes to NRWT
556         https://bugs.webkit.org/show_bug.cgi?id=51160
557         
558         Abort test run (in a similar way to how control-C is handled) when
559         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
560         that number of unexpected failures/crashes/timeouts.
561
562         * Scripts/webkitpy/layout_tests/port/test.py:
563         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
564         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
565
566 2010-12-16  David Levin  <levin@chromium.org>
567
568         Reviewed by Shinichiro Hamaji.
569
570         check-webkit-style unit tests has some duplicate boilerplate code.
571         https://bugs.webkit.org/show_bug.cgi?id=49519
572
573         * Scripts/webkitpy/style/checkers/cpp.py:
574         (update_include_state): Replaced the "io" parameter with the global
575         configuration _unit_test_config. This allowed not calling into
576         functions at a low level and also not plumbing through the injection
577         information through many levels of code.
578         (check_for_include_what_you_use): Ditto.
579         (process_file_data): Added the ability to set up the unit test config
580         to allow for injection.
581         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
582         (ErrorCollector.__init__): Added support for having a filter for errors.
583         (ErrorCollector.__call__): Ditto.
584         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
585         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
586         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
587         functions in the cpp.py with generic processing and a filter that
588         indicates what errors should be kept.
589         (CppStyleTestBase.perform_multi_line_lint): Ditto.
590         (CppStyleTestBase.perform_language_rules_check): Ditto.
591         (CppStyleTestBase.perform_function_lengths_check): Ditto.
592         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
593         (CppStyleTestBase.perform_include_what_you_use): Ditto.
594         (CppStyleTest.test_multi_line_comments): Added another
595         error message which applies to the test case.
596         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
597         to not have config.h, since it is processed as a header file.
598         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
599         style and indentation in checked code.
600         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
601         Fixed line number.
602         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
603         Ditto.
604
605 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
606
607         Unreviewed, rolling out r74136.
608         http://trac.webkit.org/changeset/74136
609         https://bugs.webkit.org/show_bug.cgi?id=51135
610
611         r74136 breaks chromium canary bots because some tests are not
612         rebaselined correctly to resolve EOL differences (Requested by
613         jianli on #webkit).
614
615         * Scripts/webkitpy/layout_tests/port/base.py:
616         * Scripts/webkitpy/layout_tests/port/test.py:
617         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
618
619 2010-12-15  Adam Roben  <aroben@apple.com>
620
621         Teach check-webkit-style to check .vcproj and .vsprops files for XML
622         syntax errors
623
624         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
625         XML syntax errors in .vcproj/.vsprops files
626
627         Reviewed by Dave Levin.
628
629         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
630         that should be treated as XML and that should be allowed to contain
631         carriage returns. (These lists happen to be identical currently.)
632         (FileType): Added a new XML type.
633         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
634         Just does a simple file extension check.
635         (CheckerDispatcher._file_type): Added a case for XML files.
636         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
637         files (surprise!).
638         (StyleProcessor.process): Ask the dispatcher whether we should pass the
639         lines through the carriage checker.
640
641         * Scripts/webkitpy/style/checker_unittest.py:
642         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
643         Added. Checks a few file names to see if carriage returns are allowed
644         or not.
645         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
646         other assert_checker_* functions.
647         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
648         test_*_paths functions.
649         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
650         test_*_paths functions.
651         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
652         file from this test case, as vcproj files now have a type.
653         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
654         Added. Similar to the other should_* functions.
655         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
656         Added. Checks that carriage returns aren't checked for or stripped for
657         allowed files.
658
659         * Scripts/webkitpy/style/checkers/xml.py: Added.
660         (XMLChecker.__init__): Simple init method.
661         (XMLChecker.check): Pass each line through the expat parser, and record
662         a style error for any errors thrown by the parser.
663
664         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
665         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
666         produce a style error.
667         (XMLCheckerTest.assert_error): Checks that the given XML produces an
668         error of the given category on the given line.
669         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
670         checking that the XMLChecker constructor works properly.
671         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
672         cause a style error (see, e.g., r73887).
673         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
674         cause a style error (see, e.g., r73773).
675         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
676         properly.
677         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
678         tags cause a style error (see, e.g., r72795).
679         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
680         style error.
681
682 2010-12-15  Lucas Forschler  <lforschler@apple.com>
683
684         Reviewed by Stephanie Lewis.
685
686         https://bugs.webkit.org/show_bug.cgi?id=51117
687         Add a new leopard test bot
688         really really commit to trunk this time.
689
690         * BuildSlaveSupport/build.webkit.org-config/config.json:
691
692 2010-12-15  Sam Weinig  <sam@webkit.org>
693
694         Reviewed by Anders Carlsson.
695
696         WebKit2: Can't add files to an <input type=file>
697         https://bugs.webkit.org/show_bug.cgi?id=51087
698
699         * MiniBrowser/mac/BrowserWindowController.m:
700         (runOpenPanel):
701         (-[BrowserWindowController awakeFromNib]):
702         Add simple implementation of runOpenPanel callback.
703
704         * MiniBrowser/win/BrowserView.cpp:
705         (BrowserView::create):
706         * WebKitTestRunner/TestController.cpp:
707         (WTR::createOtherPage):
708         (WTR::TestController::initialize):
709         Stub out runOpenPanel callback. 
710
711 2010-12-14  Eric Seidel  <eric@webkit.org>
712
713         Reviewed by Adam Barth.
714
715         commit-queue should upload failure diffs when tests flake
716         https://bugs.webkit.org/show_bug.cgi?id=51051
717
718         To make this testable I needed to pipe FileSystem down onto tool.
719         We've wanted it there for a long time anyway.
720
721         This patch is kinda a big hack.  But we don't have a nice
722         way to read results.html files.  I think this will need further
723         revision before this code actually feels clean.
724
725         As part of testing this change, I had to make MockBugzilla.create_bug
726         actually return an id (like it should) which required updating
727         a few other unit test results (for the better).
728
729         The results_matching_keys change in layouttestresults/rebasline
730         was an alternate path which I decided not to use in the end, but
731         I left the change as it seemed an improvement.
732
733         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
734         * Scripts/webkitpy/common/net/layouttestresults.py:
735         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
736         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
737         * Scripts/webkitpy/tool/commands/queues.py:
738         * Scripts/webkitpy/tool/commands/rebaseline.py:
739         * Scripts/webkitpy/tool/main.py:
740         * Scripts/webkitpy/tool/mocktool.py:
741
742 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
743
744         Reviewed by James Robinson.
745
746         new-run-webkit-tests ignores trailing EOL differences in text tests
747         https://bugs.webkit.org/show_bug.cgi?id=36983
748
749         Changed the handling of new-line characters within new-run-webkit-tests
750         to match old-run-webkit-tests.  Differences in leading and trailing empty
751         lines in text expectation files are no longer ignored.
752
753         * Scripts/webkitpy/layout_tests/port/base.py:
754         * Scripts/webkitpy/layout_tests/port/test.py:
755         Added unit tests.  Removed old duplicate unit test entries.
756         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
757
758 2010-12-15  Ojan Vafai  <ojan@chromium.org>
759
760         Reviewed by Adam Barth.
761
762         make status-bubble white-space:nowrap so we can measure it's width without wrapping
763         https://bugs.webkit.org/show_bug.cgi?id=51149
764
765         * QueueStatusServer/templates/statusbubble.html:
766
767 2010-12-15  Ojan Vafai  <ojan@chromium.org>
768
769         Reviewed by Adam Barth.
770
771         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
772         https://bugs.webkit.org/show_bug.cgi?id=51125
773
774         * QueueStatusServer/templates/statusbubble.html:
775
776 2010-12-15  Darin Adler  <darin@apple.com>
777
778         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
779
780 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
781
782         Unreviewed, rolling out r74117.
783         http://trac.webkit.org/changeset/74117
784         https://bugs.webkit.org/show_bug.cgi?id=51113
785
786         This broke the GTK1 build. (Requested by mrobinson on
787         #webkit).
788
789         * Scripts/webkitdirs.pm:
790
791 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
792
793         Reviewed by Martin Robinson.
794
795         Change generate-forwarding-headers.pl for GTK port usage 
796         (https://bugs.webkit.org/show_bug.cgi?id=37369)
797
798         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
799
800 2010-12-14  Kent Tamura  <tkent@chromium.org>
801
802         Reviewed by Jian Li.
803
804         [DRT/Chromium] Remove another unnecessary error message
805         https://bugs.webkit.org/show_bug.cgi?id=51083
806
807         * DumpRenderTree/chromium/WebViewHost.cpp:
808         (WebViewHost::didInvalidateRect):
809
810 2010-12-14  Lucas Forschler  <lforschler@apple.com>
811
812         Reviewed by Stephanie Lewis.
813
814         Add a new Leopard Debug Test WK2 Bot
815
816         * BuildSlaveSupport/build.webkit.org-config/config.json:
817
818 2010-12-14  Ojan Vafai  <ojan@chromium.org>
819
820         Fix python unittests after http://trac.webkit.org/changeset/74070.
821
822         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
823
824 2010-12-14  Kent Tamura  <tkent@chromium.org>
825
826         Reviewed by Jian Li.
827
828         [DRT/Chromium] Remove a unnecessary error message
829         https://bugs.webkit.org/show_bug.cgi?id=51069
830
831         * DumpRenderTree/chromium/WebViewHost.cpp:
832         (WebViewHost::paintInvalidatedRegion):
833
834 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
835
836         Reviewed by Ojan Vafai.
837
838         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
839         https://bugs.webkit.org/show_bug.cgi?id=48926
840
841         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
842         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
843
844 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
845
846         Reviewed by Eric Seidel.
847
848         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
849         https://bugs.webkit.org/show_bug.cgi?id=50231
850
851         Guard CONFIG+=link_pkgconfig with !symbian.
852
853         * DumpRenderTree/qt/DumpRenderTree.pro:
854         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
855         * WebKitTestRunner/qt/WebKitTestRunner.pro:
856
857 2010-12-14  Philippe Normand  <pnormand@igalia.com>
858
859         Reviewed by Ojan Vafai.
860
861         [new-run-webkit-tests] expectations parsing is slow
862         https://bugs.webkit.org/show_bug.cgi?id=50635
863
864         Avoid expensive iteration of all the tests when checking if a test
865         file is to be skipped or not.
866
867         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
868         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
869         * Scripts/webkitpy/layout_tests/port/test.py:
870
871 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
872
873         Reviewed by Xan Lopez.
874
875         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
876         https://bugs.webkit.org/show_bug.cgi?id=27048
877
878         Add support in DRT for checking whether an accessibility UI
879         element is focusable and/or focused. Implemented for GTK.
880
881         * DumpRenderTree/AccessibilityUIElement.cpp:
882         (getIsFocusedCallback): New.
883         (getIsFocusableCallback): New.
884         (AccessibilityUIElement::getJSClass): Add the new available
885         callbacks for isFocused and isFocusable.
886         * DumpRenderTree/AccessibilityUIElement.h:
887         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
888         (AccessibilityUIElement::isFocused): New, implemented by checking
889         whether the related AtkState value is in the object's state set.
890         (AccessibilityUIElement::isFocusable): Ditto.
891         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
892         (AccessibilityUIElement::isFocused): New, dummy implementation.
893         (AccessibilityUIElement::isFocusable): Ditto.
894         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
895         (AccessibilityUIElement::isFocused): Ditto.
896         (AccessibilityUIElement::isFocusable): Ditto.
897
898 2010-12-14  Eric Seidel  <eric@webkit.org>
899
900         Reviewed by Ojan Vafai.
901
902         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
903         https://bugs.webkit.org/show_bug.cgi?id=50715
904
905         This patch makes webkit-patch print the following:
906
907         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
908         Install a 64-bit git for better performance, see:
909         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
910
911         I wrote this mostly because I have approximately 8 machines that I use
912         and making sure each one is using a good Git install seemed folly.
913         webkit-patch makes a lot of git calls, so using a fast git can shave
914         several seconds in every invocation.  See the webkit-dev thread for more info.
915
916         This message will print twice during 'webkit-patch upload',
917         once from webkit-patch and once from check-webkit-style.
918
919         Unfortunately there is no good way to test this due to how machine-dependent
920         the code is.  I considered writing a test for the log message, but it seemed not worth it.
921
922         * Scripts/webkitpy/common/checkout/scm.py:
923
924 2010-12-13  Eric Seidel  <eric@webkit.org>
925
926         Reviewed by Adam Barth.
927
928         FlakyTestReporter doesn't understand bots running from multiple email addresses
929         https://bugs.webkit.org/show_bug.cgi?id=50960
930
931         This explains at least one of the dupes of:
932         https://bugs.webkit.org/show_bug.cgi?id=50863
933         that we saw filed by the commit-queue this morning.
934         I think the other one was explained by my previous fix to result counting code.
935
936         Since this is really hard to test with a unit test, instead I
937         create a new (possibly useful in the future) command
938         which given a layout test path will return you
939         the one bug which our tools would assume it the flaky test bug.
940         If some other script wants to use bug-for-test we'll
941         need to extend it with some options like --create-if-missing or similar.
942
943         * Scripts/webkitpy/common/net/bugzilla/bug.py:
944         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
945         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
946         * Scripts/webkitpy/tool/commands/__init__.py:
947         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
948
949 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
950
951         Reviewed by James Robinson.
952
953         Add option to build-webkit to not build WebKit2
954         https://bugs.webkit.org/show_bug.cgi?id=50988
955         
956         Add support for a --no-webkit2 option to build-webkit. It seems to save
957         ~1 minute from clean builds and ~10 seconds from no-op builds.
958
959         * Scripts/build-webkit:
960
961 2010-12-13  Lucas Forschler  <lforschler@apple.com>
962
963         Reviewed by Dave Kilzer.
964
965         Update iexploder from 1.3.2 to 1.7.2
966         Move 1.3.2 into its own subdir
967         Add 1.7.2 into its own subdir
968         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
969
970         * Scripts/run-iexploder-tests:
971         * Scripts/update-iexploder-cssproperties:
972         * iExploder/CHANGELOG.txt: Removed.
973         * iExploder/LICENSE.txt: Removed.
974         * iExploder/README.txt: Removed.
975         * iExploder/htdocs: Removed.
976         * iExploder/iexploder-1.3.2: Added.
977         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
978         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
979         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
980         * iExploder/iexploder-1.3.2/htdocs: Added.
981         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
982         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
983         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
984         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
985         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
986         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
987         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
988         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
989         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
990         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
991         * iExploder/iexploder-1.3.2/tools: Added.
992         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
993         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
994         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
995         * iExploder/iexploder-1.7.2: Added.
996         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
997         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
998         * iExploder/iexploder-1.7.2/README.txt: Added.
999         * iExploder/iexploder-1.7.2/output: Added.
1000         * iExploder/iexploder-1.7.2/src: Added.
1001         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
1002         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
1003         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
1004         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
1005         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
1006         * iExploder/iexploder-1.7.2/src/css-properties: Added.
1007         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
1008         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
1009         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
1010         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
1011         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
1012         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
1013         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
1014         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
1015         * iExploder/iexploder-1.7.2/src/css-values: Added.
1016         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
1017         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
1018         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
1019         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
1020         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
1021         * iExploder/iexploder-1.7.2/src/headers: Added.
1022         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
1023         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
1024         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
1025         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
1026         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
1027         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
1028         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
1029         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
1030         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
1031         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
1032         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
1033         * iExploder/iexploder-1.7.2/src/html-tags: Added.
1034         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
1035         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
1036         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
1037         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
1038         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
1039         * iExploder/iexploder-1.7.2/src/html-values: Added.
1040         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
1041         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
1042         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
1043         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
1044         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
1045         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
1046         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
1047         * iExploder/iexploder-1.7.2/src/index.html: Added.
1048         * iExploder/iexploder-1.7.2/src/media: Added.
1049         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
1050         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
1051         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
1052         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
1053         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
1054         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
1055         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
1056         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
1057         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
1058         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
1059         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
1060         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
1061         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
1062         * iExploder/iexploder-1.7.2/src/mime-types: Added.
1063         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
1064         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
1065         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
1066         * iExploder/iexploder-1.7.2/src/protocols: Added.
1067         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
1068         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
1069         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
1070         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
1071         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
1072         * iExploder/iexploder-1.7.2/src/version.rb: Added.
1073         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
1074         * iExploder/iexploder-1.7.2/testcases: Added.
1075         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
1076         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
1077         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
1078         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
1079         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
1080         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
1081         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
1082         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
1083         * iExploder/iexploder-1.7.2/tools: Added.
1084         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
1085         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
1086         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
1087         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
1088         * iExploder/tools: Removed.
1089
1090 2010-12-13  Sam Weinig  <sam@webkit.org>
1091
1092         Reviewed by Anders Carlsson.
1093
1094         Remove associated page concept from WKView constructor
1095         https://bugs.webkit.org/show_bug.cgi?id=50983
1096
1097         Step 1: Remove associate page constructors from WKView and make
1098         all views use the shared namespace for the context.
1099
1100         * TestWebKitAPI/PlatformWebView.h:
1101         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1102         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1103         * WebKitTestRunner/PlatformWebView.h:
1104         * WebKitTestRunner/TestController.cpp:
1105         (WTR::createOtherPage):
1106         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1107         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1108         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1109
1110 2010-12-13  Sam Weinig  <sam@webkit.org>
1111
1112         Reviewed by Anders Carlsson.
1113
1114         Change the WebKit2 public API so there is no explicit WKPageNamespace object
1115         https://bugs.webkit.org/show_bug.cgi?id=50898
1116
1117         * MiniBrowser/mac/AppDelegate.h:
1118         * MiniBrowser/mac/AppDelegate.m:
1119         * MiniBrowser/mac/BrowserWindowController.h:
1120         * MiniBrowser/mac/BrowserWindowController.m:
1121         * MiniBrowser/win/BrowserView.cpp:
1122         Convert MiniBrowser to not use PageNamespaces.
1123
1124         * TestWebKitAPI/PlatformWebView.h:
1125         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1126         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1127         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1128         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1129         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1130         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1131         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1132         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1133         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1134         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1135         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1136         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1137         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1138         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1139         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1140         Convert TestWebKitAPI to not use PageNamespaces.
1141
1142         * WebKitTestRunner/PlatformWebView.h:
1143         * WebKitTestRunner/TestController.cpp:
1144         * WebKitTestRunner/TestController.h:
1145         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1146         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1147         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1148         Convert WebKitTestRunner to not use PageNamespaces.
1149
1150 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1151
1152         Reviewed by Eric Seidel.
1153
1154         webkit-patch rollout should be able to do multi-revision rollouts
1155         https://bugs.webkit.org/show_bug.cgi?id=33336
1156
1157         Make it possible to pass more than one revision to webkit-patch.
1158
1159         * Scripts/webkitpy/common/checkout/api.py:
1160         * Scripts/webkitpy/common/checkout/changelog.py:
1161         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1162         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1163         * Scripts/webkitpy/tool/commands/download.py:
1164         * Scripts/webkitpy/tool/commands/download_unittest.py:
1165         * Scripts/webkitpy/tool/mocktool.py:
1166         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1167         * Scripts/webkitpy/tool/steps/revertrevision.py:
1168
1169 2010-12-13  Eric Seidel  <eric@webkit.org>
1170
1171         Unreviewed.
1172
1173         Teach webkit-patch how to search bugzilla
1174         https://bugs.webkit.org/show_bug.cgi?id=50500
1175
1176         webkit-patch bug-search fails when there is only one result.
1177         Turns out we needed a bit more logic in our result count parsing code.
1178
1179         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1180         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1181
1182 2010-12-13  Antti Koivisto  <antti@apple.com>
1183
1184         Reviewed by Alexey Proskuryakov.
1185
1186         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
1187         https://bugs.webkit.org/show_bug.cgi?id=50758
1188
1189         * DumpRenderTree/LayoutTestController.cpp:
1190         (setSerializeHTTPLoadsCallback):
1191         (LayoutTestController::staticFunctions):
1192         * DumpRenderTree/LayoutTestController.h:
1193         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1194         (LayoutTestController::setSerializeHTTPLoads):
1195         * DumpRenderTree/mac/DumpRenderTree.mm:
1196         (resetDefaultsToConsistentValues):
1197         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1198         (LayoutTestController::setSerializeHTTPLoads):
1199         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1200         (LayoutTestController::setSerializeHTTPLoads):
1201
1202 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
1203
1204         Reviewed by Ojan Vafai.
1205
1206         Remove "use-drt" option from test step command line, since the option was removed in r73748.
1207         https://bugs.webkit.org/show_bug.cgi?id=50936
1208
1209         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
1210
1211 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
1212
1213         Reviewed by Csaba Osztrogonác.
1214
1215         Add revlink to BuildBot status
1216         https://bugs.webkit.org/show_bug.cgi?id=50914
1217
1218         This adds a hyperlink to trac changeset on the revision numbers. 
1219
1220         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1221
1222 2010-12-13  Andras Becsi  <abecsi@webkit.org>
1223
1224         Reviewed by Csaba Osztrogonác.
1225
1226         [Qt][WK2] Fix build if WebKitTools are not available
1227         https://bugs.webkit.org/show_bug.cgi?id=50242
1228
1229         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
1230         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
1231         * MiniBrowser/DerivedSources.pro: Added.
1232
1233 2010-12-13  Eric Seidel  <eric@webkit.org>
1234
1235         Reviewed by Adam Barth.
1236
1237         EWS Queues should remove orpahned pyc files before starting
1238         https://bugs.webkit.org/show_bug.cgi?id=50904
1239
1240         A previous check added a platform.py which caused
1241         EWS bots on some platforms to hit an import exception.
1242         The platform.py file was removed in a subsequent commit, but
1243         the EWS bots in question stayed stuck.  This change will
1244         fix those bots once restarted (and prevent this in the future).
1245
1246         I also went ahead and unified start-queue and start-commit-queue
1247         since they were nearly identical.  I also added bot_id support
1248         to both force all EWSes to have bot ids as well as get rid of the one
1249         remaining reason why I had my own copies of these scripts.
1250         Hopefully this will be enough to get all the other bot admins
1251         (ahem, Adam, ahem) to move to using these checked in copies as well.
1252
1253         * EWSTools/start-commit-queue.sh: Removed.
1254         * EWSTools/start-queue.sh:
1255
1256 2010-10-28  MORITA Hajime  <morrita@google.com>
1257
1258         Reviewed by Ojan Vafai.
1259
1260         spellcheck does not check pasted text
1261         https://bugs.webkit.org/show_bug.cgi?id=40092
1262
1263         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
1264         to control the setting.
1265
1266         * DumpRenderTree/LayoutTestController.cpp:
1267         (setAsynchronousSpellCheckingEnabledCallback):
1268         (LayoutTestController::staticFunctions):
1269         * DumpRenderTree/LayoutTestController.h:
1270         * DumpRenderTree/chromium/LayoutTestController.h:
1271         * DumpRenderTree/chromium/LayoutTestController.cpp:
1272         (LayoutTestController::LayoutTestController):
1273         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1274         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1275         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1276         * DumpRenderTree/mac/DumpRenderTree.mm:
1277         (resetDefaultsToConsistentValues):
1278         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1279         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1280         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1281         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1282         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1283         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1284         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1285         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1286         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1287
1288 2010-12-12  Sam Weinig  <sam@webkit.org>
1289
1290         Reviewed by Anders Carlsson.
1291
1292         Fix failing API test. It turns out that a pop-state event
1293         is sent before every fragment navigation, so we have to test
1294         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
1295
1296         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1297         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1298
1299 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
1300
1301         Reviewed by Eric Seidel.
1302
1303         [GTK] Add new-run-webkit-tests support to gtk
1304         https://bugs.webkit.org/show_bug.cgi?id=50681
1305
1306         Adding the basic support to run the new-run-webkit-tests.
1307
1308         * Scripts/webkitpy/layout_tests/port/gtk.py:
1309
1310 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
1311
1312         Reviewed by Kenneth Rohde Christiansen.
1313
1314         [Qt] Mock DeviceOrientation client for DRT
1315         https://bugs.webkit.org/show_bug.cgi?id=47490
1316
1317         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1318         (WebCore::DumpRenderTree::DumpRenderTree):
1319         (WebCore::DumpRenderTree::~DumpRenderTree):
1320         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1321         (LayoutTestController::setMockDeviceOrientation):
1322
1323 2010-12-11  Philippe Normand  <pnormand@igalia.com>
1324
1325         Reviewed by Gustavo Noronha Silva.
1326
1327         [GTK] launcher: disable the Mozilla-style fullscreen API
1328         https://bugs.webkit.org/show_bug.cgi?id=50874
1329
1330         Disabling the fullscreen API until its implementation for GTK is
1331         mature enough. The webview setting for it is already FALSE by
1332         default.
1333
1334         * GtkLauncher/main.c:
1335         (createWindow):
1336
1337 2010-12-10  Eric Seidel  <eric@webkit.org>
1338
1339         Reviewed by Adam Barth.
1340
1341         commit-queue flaky test messages show cryptic version information for mac os x
1342         https://bugs.webkit.org/show_bug.cgi?id=50864
1343
1344         Turns out platform.platform() returns kernel version information
1345         which isn't helpful, and just plain confusing on Mac
1346         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
1347
1348         So I've updated PlatformInfo.display_name() to special case
1349         mac.  I also found a bad use of sys.platform in the process
1350         and fixed that.  (sys.platform always returns 'darwin' on mac).
1351
1352         * Scripts/webkitpy/common/system/platforminfo.py:
1353         * Scripts/webkitpy/common/system/user.py:
1354         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1355         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1356         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1357
1358 2010-12-10  Eric Seidel  <eric@webkit.org>
1359
1360         Unreviewed.
1361
1362         Exception seen while reporting flaky test with commit-queue.
1363         Just a missing include.
1364
1365         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1366         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1367
1368 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
1369
1370         Reviewed by Eric Seidel.
1371
1372         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
1373         https://bugs.webkit.org/show_bug.cgi?id=50796
1374
1375         Also updating the test code to use JSONResultsGeneratorBase and
1376         to improve test coverage for incremental cases.
1377
1378         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1379         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1380
1381 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
1382
1383         Reviewed by Darin Adler.
1384
1385         prepare-ChangeLog --help doesn't mention --bug shorthand -b
1386         https://bugs.webkit.org/show_bug.cgi?id=50835
1387
1388         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
1389
1390 2010-12-10  Eric Seidel  <eric@webkit.org>
1391
1392         Reviewed by Adam Barth.
1393
1394         Bugs created by the commit-queue should all block on a master bug
1395         https://bugs.webkit.org/show_bug.cgi?id=50857
1396
1397         This makes all bugs created by the commit-queue block on:
1398         https://bugs.webkit.org/show_bug.cgi?id=50856
1399
1400         In the process of testing this, I found that the existing
1401         create_bug code was wrong.  I also found that existing
1402         unit tests for create-rollout used invalid values
1403         for options.blocks.  I fixed both issues and tested.
1404
1405         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1406         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1407         * Scripts/webkitpy/tool/commands/commandtest.py:
1408         * Scripts/webkitpy/tool/commands/download_unittest.py:
1409         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1410         * Scripts/webkitpy/tool/mocktool.py:
1411         * Scripts/webkitpy/tool/steps/options.py:
1412
1413 2010-12-10  Eric Seidel  <eric@webkit.org>
1414
1415         Reviewed by Adam Barth.
1416
1417         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
1418         https://bugs.webkit.org/show_bug.cgi?id=50853
1419
1420         I also discovered when doing this that the code was posting
1421         the comment on the wrong bug, but that's fixed here too.
1422
1423         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1424         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1425         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1426         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1427         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1428         * Scripts/webkitpy/tool/mocktool.py:
1429
1430 2010-12-10  Anders Carlsson  <andersca@apple.com>
1431
1432         Reviewed by John Sullivan.
1433
1434         Make WKContextGetStatistics gather global statistics
1435         https://bugs.webkit.org/show_bug.cgi?id=50850
1436
1437         Remove the code that gets the statistics and fills in the per context
1438         statistics information for now.
1439
1440         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1441         (-[BrowserStatisticsWindowController refreshStatistics:]):
1442
1443 2010-12-10  Eric Seidel  <eric@webkit.org>
1444
1445         Unreviewed.
1446
1447         commit-queue should report port/platform information when commenting on flaky test bugs
1448         https://bugs.webkit.org/show_bug.cgi?id=50839
1449
1450         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
1451         which was only used by new run webkit tests (and clearly not unit tested).
1452
1453         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
1454         * Scripts/webkitpy/tool/main.py:
1455         * Scripts/webkitpy/tool/mocktool.py:
1456
1457 2010-12-10  Eric Seidel  <eric@webkit.org>
1458
1459         Reviewed by Tony Chang.
1460
1461         commit-queue should report port/platform information when commenting on flaky test bugs
1462         https://bugs.webkit.org/show_bug.cgi?id=50839
1463
1464         This was a suggestion from Tony Chang this morning.
1465         I added a platform.py class so I could easily mock the platform call,
1466         but that may not be the final solution for this mocking.
1467         We'll try it and see.
1468
1469         * Scripts/webkitpy/common/system/platform.py: Added.
1470         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1471         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1472         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1473         * Scripts/webkitpy/tool/main.py:
1474         * Scripts/webkitpy/tool/mocktool.py:
1475
1476 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
1477
1478         Reviewed by Joseph Pecoraro.
1479
1480         Bug 43455 - [Qt]: Implement Application Cache Quotas
1481         https://bugs.webkit.org/show_bug.cgi?id=43455
1482
1483         Introduce functions to allow new appcache layout test origin-quota.html
1484         to work correctly under Qt.
1485
1486         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1487         (WebCore::DumpRenderTree::DumpRenderTree):
1488         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
1489         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1490
1491         Introduce functions to allow new appcache layout test origin-quota.html
1492         to be successful under qt. Changes required because LayoutTestControllerQt
1493         does not inherit from LayoutController.
1494
1495         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1496         (LayoutTestController::reset):
1497         (LayoutTestController::clearAllApplicationCaches):
1498         (LayoutTestController::setApplicationCacheOriginQuota):
1499         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1500         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
1501         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
1502
1503 2010-12-10  Eric Seidel  <eric@webkit.org>
1504
1505         Reviewed by Adam Barth.
1506
1507         Move buildbot.py into its own module so we can split it out into one-file-per-class
1508         https://bugs.webkit.org/show_bug.cgi?id=50806
1509
1510         We're adding more buildbot logic these days, so it makes sense
1511         to give buildbot its own module.
1512
1513         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
1514         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
1515         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
1516         * Scripts/webkitpy/common/net/failuremap.py:
1517         * Scripts/webkitpy/common/net/regressionwindow.py:
1518         * Scripts/webkitpy/tool/commands/rebaseline.py:
1519
1520 2010-12-10  Tony Chang  <tony@chromium.org>
1521
1522         Reviewed by Eric Seidel.
1523
1524         Use FileSystem::remove when cleaning up http lock files
1525         https://bugs.webkit.org/show_bug.cgi?id=50830
1526
1527         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1528
1529 2010-12-10  Joone Hur  <joone@kldp.org>
1530
1531         Reviewed by Martin Robinson.
1532
1533         [GTK] DRT needs layoutTestController.setCacheModel
1534         https://bugs.webkit.org/show_bug.cgi?id=50705
1535         
1536         webkit_set_cache_mode() is called to set the cache model.
1537         
1538         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1539         (LayoutTestController::setCacheModel): Set the cache model. 
1540
1541 2010-12-10  Tony Chang  <tony@chromium.org>
1542
1543         Reviewed by Ojan Vafai.
1544
1545         [chromium] remove --use-drt and add --use-test-shell
1546         https://bugs.webkit.org/show_bug.cgi?id=50701
1547
1548         * Scripts/webkitpy/common/config/ports.py:
1549         * Scripts/webkitpy/common/config/ports_unittest.py:
1550         * Scripts/webkitpy/layout_tests/port/chromium.py:
1551         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1552         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1553         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1554         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1555         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1556         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1557         * Scripts/webkitpy/layout_tests/port/webkit.py:
1558         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1559         * Scripts/webkitpy/style/checkers/test_expectations.py:
1560         * Scripts/webkitpy/tool/commands/queries.py:
1561
1562 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
1563
1564         Reviewed by Steve Block.
1565
1566         [Chromium] Implement mocks for client-based geolocation
1567         https://bugs.webkit.org/show_bug.cgi?id=46895
1568
1569         * DumpRenderTree/chromium/LayoutTestController.cpp:
1570         (LayoutTestController::setGeolocationPermission):
1571         (LayoutTestController::setMockGeolocationPosition):
1572         (LayoutTestController::setMockGeolocationError):
1573         * DumpRenderTree/chromium/LayoutTestController.h:
1574         * DumpRenderTree/chromium/WebViewHost.cpp:
1575         (WebViewHost::geolocationClient):
1576         (WebViewHost::geolocationClientMock):
1577         (WebViewHost::reset):
1578         * DumpRenderTree/chromium/WebViewHost.h:
1579
1580 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
1581
1582         Reviewed by Martin Robinson.
1583
1584         [GTK] Add hasSpellingMarker support to the DRT
1585         https://bugs.webkit.org/show_bug.cgi?id=50739
1586
1587         Implemented the hasSpellingMarker to support spelling tests.
1588
1589         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1590         (LayoutTestController::hasSpellingMarker):
1591
1592 2010-12-10  Eric Seidel  <eric@webkit.org>
1593
1594         Reviewed by Ojan Vafai.
1595
1596         webkit-patch: not possible to use build-and-test with local commits
1597         https://bugs.webkit.org/show_bug.cgi?id=33378
1598
1599         Make --no-clean not even check if we have local commits.
1600         It's unclear to me why the code was originally written this way.
1601         I was unable to dig up a reason from svn history.
1602
1603         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1604         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1605
1606 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
1607
1608         Reviewed by Martin Robinson.
1609
1610         [GTK] AX: implement isEnabled in DRT
1611         https://bugs.webkit.org/show_bug.cgi?id=50814
1612
1613         Implement AccessibilityUIElement::isEnabled() for GTK.
1614
1615         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1616         (checkElementState): New function to refactor common code.
1617         (AccessibilityUIElement::isEnabled): Implement this by checking
1618         the current state of the AtkObject.
1619         (AccessibilityUIElement::isSelected): Use the new
1620         checkElementState function.
1621
1622 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1623
1624         Reviewed by Kenneth Rohde Christiansen.
1625
1626         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
1627         https://bugs.webkit.org/show_bug.cgi?id=50750
1628
1629         * MiniBrowser/qt/BrowserView.cpp:
1630         (BrowserView::BrowserView):
1631         * MiniBrowser/qt/BrowserView.h:
1632         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1633         (WTR::WebView::WebView):
1634
1635 2010-12-10  Joone Hur  <joone@kldp.org>
1636
1637         Reviewed by Xan Lopez.
1638
1639         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
1640         https://bugs.webkit.org/show_bug.cgi?id=50808
1641
1642         Unskipping the following test cases:
1643         userscripts/mixed-case-stylesheet.html
1644         userscripts/simple-stylesheet.html
1645         userscripts/user-style-all-frames.html
1646
1647         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1648         (LayoutTestController::addUserStyleSheet):
1649
1650 2010-12-10  Joone Hur  <joone@kldp.org>
1651
1652         Reviewed by Eric Seidel.
1653
1654         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
1655         https://bugs.webkit.org/show_bug.cgi?id=50783
1656
1657         This patch allows to unskip the following test cases:
1658         printing/page-rule-selection.html
1659         printing/page-format-data.html
1660
1661         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1662         (LayoutTestController::pageProperty): Added.
1663         (LayoutTestController::isPageBoxVisible): Ditto.
1664         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
1665         (LayoutTestController::addUserStyleSheet): Ditto.
1666
1667 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1668
1669         Reviewed by Kenneth Rohde Christiansen.
1670
1671         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
1672
1673         A menu allows to switch QNAM back to the same thread.
1674
1675         * QtTestBrowser/launcherwindow.cpp:
1676         (LauncherWindow::initializeView):
1677         (LauncherWindow::createChrome):
1678         (LauncherWindow::toggleThreadedQnam):
1679         * QtTestBrowser/launcherwindow.h:
1680         (WindowOptions::WindowOptions):
1681         * QtTestBrowser/webpage.cpp:
1682         (WebPage::WebPage):
1683         (WebPage::setQnamThreaded):
1684         * QtTestBrowser/webpage.h:
1685         (QnamThread::QnamThread):
1686         (QnamThread::~QnamThread):
1687         (QnamThread::networkAccessManager):
1688         (QnamThread::run):
1689
1690 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
1691
1692         Reviewed by Xan Lopez.
1693
1694         [Gtk] style="font-family: courier" makes text disappear
1695         https://bugs.webkit.org/show_bug.cgi?id=47452
1696
1697         Add a test that verifies that fonts without valid charmaps are
1698         never selected.
1699
1700         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1701         (initializeFonts): Initialize DRT with our font (derived from Ahem)
1702         that has no valid charmap.
1703         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
1704         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
1705         settings which may disable selection of bitmap fonts.
1706
1707 2010-12-10  Eric Seidel  <eric@webkit.org>
1708
1709         Unreviewed.
1710
1711         The commit-queue should file bugs about flaky tests it encounters
1712         https://bugs.webkit.org/show_bug.cgi?id=50803
1713
1714         create_bug_for_flaky_test was insufficiently tested, thus buggy.
1715         Now it's tested.
1716
1717         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1718         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1719
1720 2010-12-10  Eric Seidel  <eric@webkit.org>
1721
1722         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
1723
1724         The commit-queue should file bugs about flaky tests it encounters
1725         https://bugs.webkit.org/show_bug.cgi?id=50803
1726
1727         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1728
1729 2010-12-09  Eric Seidel  <eric@webkit.org>
1730
1731         Reviewed by Adam Barth.
1732
1733         The commit-queue should file bugs about flaky tests it encounters
1734         https://bugs.webkit.org/show_bug.cgi?id=50803
1735
1736         This change got a bit big.  I also added a new config.urls file
1737         because I needed to share the view_source_url code with committervalidator.py.
1738
1739         This adds a new class FlakyTestReporter which holds all the logic about
1740         reporting flaky tests to bugzilla.
1741
1742         Right now this code knows how to look up bugs for flaky tests.
1743         If it can't find a bug filed from the commit-queue, it will open a new
1744         one, ccing the relevant people and adding information about the failure.
1745
1746         It is not yet smart enough to chase down duplicate chains, or to include
1747         the actual failure diff.  But those can be added in later iterations.
1748
1749         * Scripts/webkitpy/common/checkout/api.py:
1750         * Scripts/webkitpy/common/checkout/changelog.py:
1751         * Scripts/webkitpy/common/checkout/commitinfo.py:
1752         * Scripts/webkitpy/common/config/committervalidator.py:
1753         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1754         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1755         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
1756         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1757         * Scripts/webkitpy/tool/bot/irc_command.py:
1758         * Scripts/webkitpy/tool/bot/sheriff.py:
1759         * Scripts/webkitpy/tool/commands/download.py:
1760         * Scripts/webkitpy/tool/commands/queues.py:
1761         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1762         * Scripts/webkitpy/tool/comments.py:
1763         * Scripts/webkitpy/tool/mocktool.py:
1764         * Scripts/webkitpy/tool/steps/commit.py:
1765
1766 2010-12-09  Eric Seidel  <eric@webkit.org>
1767
1768         Reviewed by Adam Barth.
1769
1770         Teach webkit-patch how to search bugzilla
1771         https://bugs.webkit.org/show_bug.cgi?id=50500
1772
1773         This is a step towards teaching webkitpy how to file
1774         new bugs for flaky tests and update them when new flakes occur.
1775
1776         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1777         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1778         * Scripts/webkitpy/tool/commands/__init__.py:
1779         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
1780
1781 2010-12-09  Adam Barth  <abarth@webkit.org>
1782
1783         Reviewed by Ojan Vafai.
1784
1785         commit-queue errors out due to local commits
1786         https://bugs.webkit.org/show_bug.cgi?id=50766
1787
1788         We seem to be tripping over having local commits in the working copy a
1789         lot recently.  I don't quite fully understand what the issue is, but
1790         this patch attempts to solve the problem by adding an explicit clean
1791         step before processing a patch.  Previously, we did the cleaning as
1792         part of the apply-attachment step, so this might not actually fix the
1793         problem.
1794
1795         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1796         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1797         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1798
1799 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
1800
1801         Reviewed by Ojan Vafai.
1802
1803         Make new-run-webkit-tests --lint-test-files log slightly better
1804         messages and return -1 if lint fails. Remove the
1805         'suppress_errors' keyword param to the TestExpectationsFile
1806         class, and clean up logging and exception raising for error
1807         handling. Also add more unit tests and clean up the unit test code a bit.
1808
1809         https://bugs.webkit.org/show_bug.cgi?id=50205
1810
1811         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1812         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1813         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
1814         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
1815         * Scripts/webkitpy/layout_tests/port/chromium.py:
1816         * Scripts/webkitpy/style/checkers/test_expectations.py:
1817         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1818
1819 2010-12-09  Tony Chang  <tony@chromium.org>
1820
1821         Unreviewed, fix for windows code.  We were catching the wrong
1822         exception in Windows.
1823
1824         * Scripts/webkitpy/common/system/filesystem.py:
1825
1826 2010-12-09  Antonio Gomes  <agomes@rim.com>
1827
1828         Reviewed by Martin Robinson.
1829
1830         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
1831         https://bugs.webkit.org/show_bug.cgi?id=48429
1832
1833         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
1834
1835         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1836         (LayoutTestController::workerThreadCount):
1837
1838 2010-12-06  Philippe Normand  <pnormand@igalia.com>
1839
1840         Reviewed by Martin Robinson.
1841
1842         [GTK] Support the Mozilla-style Fullscreen Javascript API
1843         https://bugs.webkit.org/show_bug.cgi?id=50572
1844
1845         Enable the Javascript Fullscreen support in the GtkLauncher. Also
1846         make DRT update the Chrome when the WebView settings have been
1847         reset to consistent values.
1848
1849         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1850         (resetDefaultsToConsistentValues):
1851         * GtkLauncher/main.c:
1852         (create_window):
1853         * Scripts/build-webkit:
1854
1855 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
1856
1857         Reviewed by Tor Arne Vestbø
1858
1859         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
1860         https://bugs.webkit.org/show_bug.cgi?id=50742
1861
1862         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
1863
1864         * Scripts/webkitdirs.pm:
1865
1866 2010-12-09  Joone Hur  <joone@kldp.org>
1867
1868          Reviewed by Martin Robinson.
1869
1870          [GTK] Support for viewport meta tag
1871          https://bugs.webkit.org/show_bug.cgi?id=45443
1872
1873          Add support for testing the viewport properties for WebKitGtk.
1874
1875          * DumpRenderTree/LayoutTestController.cpp:
1876          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
1877          (LayoutTestController::staticFunctions):
1878          * DumpRenderTree/LayoutTestController.h:
1879          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1880          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
1881          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1882          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1883          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1884          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1885          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1886          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1887          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1888          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1889
1890 2010-12-08  William Siegrist <wsiegrist@apple.com>
1891
1892         Reviewed by Eric Seidel.
1893
1894         Migrate buildbot.py from xmlrpc to json.
1895         https://bugs.webkit.org/show_bug.cgi?id=50647
1896
1897         * Scripts/webkitpy/common/net/buildbot.py:
1898
1899 2010-12-08  Tony Chang  <tony@chromium.org>
1900
1901         Reviewed by Eric Seidel.
1902
1903         make starting the websocket server more reliable on windows
1904         https://bugs.webkit.org/show_bug.cgi?id=50712
1905
1906         * Scripts/webkitpy/common/system/filesystem.py:
1907         (remove): Substitute method for os.remove to retry on error on Windows
1908         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1909         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
1910
1911 2010-12-08  Jessie Berlin  <jberlin@apple.com>
1912
1913         Reviewed by Adam Roben.
1914
1915         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
1916         https://bugs.webkit.org/show_bug.cgi?id=50656
1917
1918         * MiniBrowser/mac/BrowserWindowController.m:
1919         (-[BrowserWindowController awakeFromNib]):
1920         Indicate that exceededDatabaseQuota is not implemented.
1921         * MiniBrowser/win/BrowserView.cpp:
1922         (BrowserView::create):
1923         Ditto.
1924         * WebKitTestRunner/TestController.cpp:
1925         (WTR::createOtherPage):
1926         Ditto.
1927         (WTR::TestController::initialize):
1928         Ditto.
1929
1930 2010-12-08  Antonio Gomes  <agomes@rim.com>
1931
1932         Reviewed by Martin Robinson.
1933
1934         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
1935         https://bugs.webkit.org/show_bug.cgi?id=48429
1936
1937         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
1938         * webkit_gc_collect_javascript_objects;
1939         * webkit_gc_collect_javascript_objects_on_alternate_thread;
1940         * webkit_gc_count_javascript_objects;
1941         * webkit_web_frame_layout.
1942
1943         These were all only used by GTK+ DRT.
1944
1945         * DumpRenderTree/gtk/EventSender.cpp:
1946         (dispatchEvent):
1947         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1948         (GCController::collect):
1949         (GCController::collectOnAlternateThread):
1950         (GCController::getJSObjectCount):
1951
1952 2010-12-07  Tony Chang  <tony@chromium.org>
1953
1954         Reviewed by Ojan Vafai.
1955
1956         [chromium] force NRWT to use DRT
1957         https://bugs.webkit.org/show_bug.cgi?id=50359
1958
1959         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1960
1961 2010-12-06  Sam Weinig  <sam@webkit.org>
1962
1963         Reviewed by Anders Carlsson.
1964
1965         Generalize didChangeLocationWithinPageForFrame for all same document navigations
1966         https://bugs.webkit.org/show_bug.cgi?id=50584
1967
1968         * MiniBrowser/mac/BrowserWindowController.m:
1969         (didSameDocumentNavigationForFrame):
1970         (-[BrowserWindowController awakeFromNib]):
1971         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
1972         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1973         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1974         (TestWebKitAPI::TEST):
1975         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1976         (WTR::InjectedBundlePage::InjectedBundlePage):
1977         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
1978         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1979         * WebKitTestRunner/TestController.cpp:
1980         (WTR::TestController::initialize):
1981
1982 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
1983
1984         Reviewed by Ojan Vafai.
1985
1986         Make TestResultsServer return 404 for non-existing results files.
1987         https://bugs.webkit.org/show_bug.cgi?id=50581
1988
1989         * TestResultServer/handlers/testfilehandler.py:
1990
1991 2010-12-06  Tony Chang  <tony@chromium.org>
1992
1993         Reviewed by Ojan Vafai.
1994
1995         [chromium] fix an assert hit in DRT
1996         https://bugs.webkit.org/show_bug.cgi?id=50575
1997
1998         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
1999         semantics.
2000
2001         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
2002         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
2003         WTF::RefCountedBase::ref()).
2004
2005         * DumpRenderTree/chromium/TestWebWorker.h:
2006         (TestWebWorker::TestWebWorker):
2007
2008 2010-12-02  Ojan Vafai  <ojan@chromium.org>
2009
2010         Reviewed by Eric Seidel.
2011
2012         make webkit-patch command work when the git branch is not synced to the remote svn branch
2013         https://bugs.webkit.org/show_bug.cgi?id=50424
2014
2015         * Scripts/webkitpy/common/checkout/scm.py:
2016         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2017
2018 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
2019
2020         Reviewed by Andreas Kling.
2021
2022         [WINCE] Add build system
2023         https://bugs.webkit.org/show_bug.cgi?id=50522
2024
2025         * CMakeListsWinCE.txt: Added.
2026
2027 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2028
2029         Reviewed by Tony Chang.
2030
2031         Allow the Chromium port to have Leopard-specific baselines
2032         https://bugs.webkit.org/show_bug.cgi?id=50506
2033
2034         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2035
2036 2010-12-03  Tony Chang  <tony@chromium.org>
2037
2038         Reviewed by Kent Tamura.
2039
2040         [chromium] fix 2 bugs with inspector tests in DRT
2041         https://bugs.webkit.org/show_bug.cgi?id=50492
2042
2043         Tasks can outlive the tasklist (even when canceled) so this was
2044         causing a crash when ~WebTask() ran.  Avoid this by unregistering
2045         when a task is canceled.
2046
2047         Also fix an assert when closing devtool windows by copying some
2048         logic from test_shell.
2049
2050         * DumpRenderTree/chromium/Task.cpp:
2051         (WebTask::~WebTask):
2052         (TaskList::revokeAll):
2053         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
2054             the tasklist (since the task can outlive the tasklist).
2055         * DumpRenderTree/chromium/TestShell.h:
2056         (TestShell::devToolsWebView):
2057         * DumpRenderTree/chromium/WebViewHost.cpp:
2058         (WebViewHost::~WebViewHost): Don't load about:blank when closing
2059             a window if the window has devtools loaded.  This avoids an
2060             ASSERT and matches test_shell.
2061
2062 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
2063
2064         Reviewed by Martin Robinson.
2065
2066         [GTK] Fix GtkLauncher.c style, use webkit style
2067         https://bugs.webkit.org/show_bug.cgi?id=50542
2068
2069         * GtkLauncher/main.c:
2070         (activateUriEntryCb):
2071         (updateTitle):
2072         (linkHoverCb):
2073         (notifyTitleCb):
2074         (notifyLoadStatusCb):
2075         (notifyProgressCb):
2076         (destroyCb):
2077         (goBackCb):
2078         (goForwardCb):
2079         (create_webViewCb):
2080         (webViewReadyCb):
2081         (closeWebViewCb):
2082         (createBrowser):
2083         (createStatusbar):
2084         (createToolbar):
2085         (createWindow):
2086         (main):
2087
2088 2010-12-04  Antonio Gomes  <agomes@rim.com>
2089
2090         Reviewed by Martin Robinson.
2091
2092         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
2093         https://bugs.webkit.org/show_bug.cgi?id=48429
2094
2095         Moved more private method declared with WEBKIT_API to
2096         DumpRenderTreeSupportGtk, since they were only being used by DRT.
2097
2098         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2099         (resetDefaultsToConsistentValues):
2100         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2101         (LayoutTestController::addOriginAccessWhitelistEntry):
2102         (LayoutTestController::execCommand):
2103         (LayoutTestController::isCommandEnabled):
2104
2105 2010-12-04  Antonio Gomes  <agomes@rim.com>
2106
2107         Reviewed by Andreas Kling.
2108
2109         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
2110
2111         Method was removed by http://trac.webkit.org/changeset/71604
2112
2113         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2114
2115 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
2116
2117         Reviewed by Xan Lopez.
2118
2119         [GTK] Fix compilation warnings reported by clang
2120         https://bugs.webkit.org/show_bug.cgi?id=50252
2121
2122         * GtkLauncher/main.c:
2123         (create_window): The create_statusbar function does not have
2124         parameters.
2125
2126 2010-12-05  Robert Hogan  <robert@webkit.org>
2127
2128         Reviewed by Andreas Kling.
2129
2130         [Qt] Zero-sized font does not yet work
2131
2132         Fix fast/text/font-size-zero.html
2133
2134         Copy other ports by setting minimumFontSize to 0 for DRT runs.
2135
2136         https://bugs.webkit.org/show_bug.cgi?id=49759
2137
2138         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2139         (WebCore::WebPage::WebPage):
2140
2141 2010-12-04  Sam Weinig  <sam@webkit.org>
2142
2143         Reviewed by Jon Honeycutt.
2144
2145         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
2146         https://bugs.webkit.org/show_bug.cgi?id=50511
2147
2148         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
2149         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
2150
2151         * MiniBrowser/mac/BrowserWindowController.m:
2152         (didChangeLocationWithinPageForFrame):
2153         (-[BrowserWindowController awakeFromNib]):
2154         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
2155         * TestWebKitAPI/PlatformUtilities.cpp:
2156         (TestWebKitAPI::Util::toWK):
2157         * TestWebKitAPI/PlatformUtilities.h:
2158         (TestWebKitAPI::Util::adoptWK):
2159         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2160         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
2161         (TestWebKitAPI::nullJavaScriptCallback):
2162         (TestWebKitAPI::didFinishLoadForFrame):
2163         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
2164         (TestWebKitAPI::TEST):
2165         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
2166         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2167         * TestWebKitAPI/win/copy-resources.cmd:
2168         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2169         (WTR::InjectedBundlePage::InjectedBundlePage):
2170         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2171         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2172         * WebKitTestRunner/TestController.cpp:
2173         (WTR::TestController::initialize):
2174
2175 2010-11-08  Antonio Gomes  <agomes@rim.com>
2176
2177         Reviewed by Martin Robinson.
2178
2179         [Gtk] Populate DumpRenderTreeSupportGtk
2180         https://bugs.webkit.org/show_bug.cgi?id=48429
2181
2182         Made the previous calls to webkit_web_frame* functions defined as private
2183         APIs in webkitprivate.h go through DRTSupportGtk.
2184
2185         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2186         (AccessibilityController::focusedElement):
2187         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2188         (dumpFramesAsText):
2189         (resetDefaultsToConsistentValues):
2190         (dump):
2191         (webViewDocumentLoadFinished):
2192         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2193         (LayoutTestController::counterValueForElementById):
2194         (LayoutTestController::pageNumberForElementById):
2195         (LayoutTestController::numberOfPages):
2196         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2197         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2198         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2199         (LayoutTestController::numberOfActiveAnimations):
2200         (LayoutTestController::suspendAnimations):
2201         (LayoutTestController::resumeAnimations):
2202         (LayoutTestController::markerTextForListItem):
2203
2204 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2205
2206         Reviewed by Tony Chang.
2207
2208         Rebaseline server: use pretty text diff output
2209         https://bugs.webkit.org/show_bug.cgi?id=50484
2210         
2211         Serve *-pretty-diff.html for text diff output.
2212
2213         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2214         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2215         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2216         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2217
2218 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2219
2220         Unreviewed, rolling out r73302.
2221         http://trac.webkit.org/changeset/73302
2222         https://bugs.webkit.org/show_bug.cgi?id=50499
2223
2224         Causes crashes in debug LayoutTests (Requested by xan_ on
2225         #webkit).
2226
2227         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2228         (AccessibilityUIElement::AccessibilityUIElement):
2229         (AccessibilityUIElement::parentElementCallback):
2230         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2231         * DumpRenderTree/chromium/CppBoundClass.cpp:
2232         * DumpRenderTree/chromium/CppBoundClass.h:
2233
2234 2010-12-03  Sam Weinig  <sam@webkit.org>
2235
2236         Reviewed by Maciej Stachowiak.
2237
2238         Enable <a ping> for Mac/Windows/WebKit2 builds
2239         <rdar://problem/8504473>
2240         https://bugs.webkit.org/show_bug.cgi?id=50488
2241
2242         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2243         (TestWebKitAPI::TEST): Test that the default value of
2244         WKPreferencesGetHyperlinkAuditingEnabled is true.
2245
2246 2010-12-03  Chris Guillory  <chris.guillory@google.com>
2247
2248         Reviewed by Chris Fleizach.
2249
2250         Include the FrameView widget of a RenderWidget in the accessibility tree.
2251         https://bugs.webkit.org/show_bug.cgi?id=49106
2252
2253         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2254         (AccessibilityUIElement::AccessibilityUIElement):
2255         (AccessibilityUIElement::parentElementCallback):
2256         (AccessibilityUIElement::isEqualCallback):
2257         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2258         * DumpRenderTree/chromium/CppBoundClass.cpp:
2259         (CppBoundClass::getFromCppVariant):
2260         * DumpRenderTree/chromium/CppBoundClass.h:
2261
2262 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2263
2264         Reviewed by Tony Chang.
2265
2266         Rebaseline server: organize tests by state, add dry run mode
2267         https://bugs.webkit.org/show_bug.cgi?id=50473
2268         
2269         Group tests in the menu by state, so that it's easier to see after
2270         processing the queue which failed.
2271         
2272         Add support for the --dry-run flag so that it's easier to test changes
2273         such as this (stubs out filesystem and SCM operations).
2274
2275         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2276         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2277         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2278
2279 2010-12-03  Brady Eidson  <beidson@apple.com>
2280
2281         Reviewed by Anders Carlsson.
2282
2283         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
2284         WebKit2 Authentication Support
2285
2286         Keep these builds working:
2287         * MiniBrowser/mac/BrowserWindowController.m:
2288         (-[BrowserWindowController awakeFromNib]):
2289
2290         * WebKitTestRunner/TestController.cpp:
2291         (WTR::TestController::initialize):
2292
2293 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
2294
2295         Reviewed by Tony Chang.
2296
2297         Rebaseline server: move existing baselines
2298         https://bugs.webkit.org/show_bug.cgi?id=50421
2299         
2300         Implement moving of existing baselines: move all files that are about
2301         to be overwriten by update baselines.
2302         
2303         Also fix a typo in the UI JS.
2304
2305         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2306         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2307         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2308
2309 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2310
2311         Unreviewed, rolling out r73211.
2312         http://trac.webkit.org/changeset/73211
2313         https://bugs.webkit.org/show_bug.cgi?id=50450
2314
2315         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
2316         yutak on #webkit).
2317
2318         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2319
2320 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2321
2322         Unreviewed, rolling out r73222.
2323         http://trac.webkit.org/changeset/73222
2324         https://bugs.webkit.org/show_bug.cgi?id=50449
2325
2326         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2327         (Requested by yutak on #webkit).
2328
2329         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2330         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2331         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2332         * Scripts/webkitpy/layout_tests/port/base.py:
2333         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2334         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2335
2336 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2337
2338         Unreviewed, rolling out r73228.
2339         http://trac.webkit.org/changeset/73228
2340         https://bugs.webkit.org/show_bug.cgi?id=50448
2341
2342         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2343         (Requested by yutak on #webkit).
2344
2345         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2346         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2347         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2348         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2349         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2350
2351 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2352
2353         Unreviewed, rolling out r73231.
2354         http://trac.webkit.org/changeset/73231
2355         https://bugs.webkit.org/show_bug.cgi?id=50443
2356
2357         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
2358         (Requested by yutak on #webkit).
2359
2360         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2361         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2362         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2363         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2364
2365 2010-12-03  David Levin  <levin@chromium.org>
2366
2367         Reviewed by Shinichiro Hamaji.
2368
2369         check-webkit-style: false positive reported for #if macro
2370         https://bugs.webkit.org/show_bug.cgi?id=48242
2371
2372         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
2373           all preprocessor commands.
2374         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
2375
2376 2010-12-02  Eric Seidel  <eric@webkit.org>
2377
2378         Reviewed by Adam Barth.
2379
2380         Update the EWSTools scripts to use modern-style git repos
2381         https://bugs.webkit.org/show_bug.cgi?id=50402
2382
2383         * EWSTools/create-webkit-git:
2384         * EWSTools/start-commit-queue.sh:
2385         * EWSTools/start-queue.sh:
2386
2387 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2388
2389         Fix Chromium Linux plugin tests by not logging
2390         unconditionally from the event handling code.
2391
2392         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2393         (handleEventX11):
2394
2395 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2396
2397         Reviewed by Tony Chang.
2398
2399         nrwt multiprocessing - move logic back into run_webkit_tests
2400
2401         This change moves a bunch of logic that I had put into
2402         message_broker back into run_webkit_tests, in a slightly
2403         different format. WorkerMessageBroker needed to become less aware of
2404         the logic the TestRunner class uses, and more generic.
2405         Eventually the MessageBroker will only do generic messaging and
2406         thread/process-pooling, and (almost) all of the
2407         run-webkit-tests-specific logic will be moved to
2408         run_webkit_tests.py and dump_render_tree_thread.py.
2409         
2410         The biggest changes are that the Broker can now start a single
2411         worker, but the responsibility for starting all of them is pushed
2412         back to the TestRunner (Manager), and the logic for checking if
2413         the threads are done or wedged is moved back to TestRunner. We
2414         also remove WorkerMessageBroker.cleanup (not needed) and
2415         cancel_workers (they have to be cancelled individually).
2416         
2417         The  message_broker is now encapsulated inside
2418         TestRunner._run_tests(); it only needs to exist while actually
2419         running the tests.
2420
2421         Also, delete a bunch of tests in message_broker_unittest that no
2422         longer make much sense.
2423
2424         This patch depends on bug 50372.
2425
2426         https://bugs.webkit.org/show_bug.cgi?id=50374
2427
2428         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2429         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2430         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2431         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2432         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2433
2434 2010-12-02  Hayato Ito  <hayato@chromium.org>
2435
2436         Reviewed by Eric Seidel.
2437
2438         Refactor test_types's compare_output() method so that it takes a
2439         TestInput object.
2440
2441         compare_output() will need additional information included in a TestInput
2442         object to support reftests. This change is a pre-requirement of that.
2443
2444         https://bugs.webkit.org/show_bug.cgi?id=50362
2445
2446         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2447         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2448         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2449         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2450         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2451
2452 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2453
2454         Reviewed by Anders Carlsson.
2455
2456         Add the ability to run script on 'new' and 'paint' in the test plugin
2457         https://bugs.webkit.org/show_bug.cgi?id=50425
2458         
2459         Add "onnew" and "onpaintevent" attributes to the test plugin,
2460         so that tests can run JS at these times.
2461
2462         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2463         (pluginAllocate):
2464         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2465         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2466         (NPP_New):
2467         (NPP_Destroy):
2468         (handleEventCarbon):
2469         (handleEventCocoa):
2470         (NPP_HandleEvent):
2471
2472 2010-12-02  Sam Weinig  <sam@webkit.org>
2473
2474         Fix Qt build.
2475
2476         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2477         (WTR::PlatformWebView::PlatformWebView):
2478
2479 2010-12-02  Sam Weinig  <sam@webkit.org>
2480
2481         Reviewed by Anders Carlsson.
2482
2483         WebKit2 Preferences should be held off the PageGroup, not the Context
2484         https://bugs.webkit.org/show_bug.cgi?id=50414
2485
2486         Update for API changes.
2487
2488         * WebKitTestRunner/PlatformWebView.h:
2489         * WebKitTestRunner/TestController.cpp:
2490         (WTR::createOtherPage):
2491         (WTR::TestController::initialize):
2492         (WTR::TestController::resetStateToConsistentValues):
2493         * WebKitTestRunner/TestController.h:
2494         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2495         (WTR::PlatformWebView::PlatformWebView):
2496         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2497         (WTR::PlatformWebView::PlatformWebView):
2498
2499 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2500
2501         Reviewed by Tony Chang.
2502
2503         new-run-webkit-tests: minor cleanup for multiprocessing work
2504
2505         This change:
2506         * moves worker naming into TestShellThread, eliminating a
2507           parameter to the constructor and putting the responsibility in
2508           the correct place.
2509         * eliminates the _WorkerState() class in message_broker, because
2510           it turns out that state really needs to be in run_webkit_tests
2511         * renames the Broker classes to be module-private.
2512         * fixes a bunch of minor commenting and whitespace issues to
2513           make subsequent patches a bit clearer.
2514         * Adds a Port hook for default_worker_model() so that we can
2515           accomodate the potential for different worker models on
2516           different ports.
2517         * merge in the fix from 50420 for the brokenness introduced in
2518           bug 50367.
2519
2520         This patch depends on bug 50367.
2521
2522         https://bugs.webkit.org/show_bug.cgi?id=50372
2523
2524         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2525         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2526         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2527         * Scripts/webkitpy/layout_tests/port/base.py:
2528         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2529         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2530
2531 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2532
2533         Reviewed by Tony Chang.
2534
2535         This change is a bunch of cleanup / refactoring of the file
2536         below. It moves a bunch of free functions to methods on the
2537         TestShellThread class, and restructures other methods to be
2538         closer to the structure we'll need for the multiprocessing
2539         rewrite.
2540
2541         It also makes the logic of --run-singly a *lot* easier to follow
2542         by nestling all of the separate-thread logic into a single
2543         routine.
2544
2545         There should be no semantic changes in this patch, just cleanup.
2546
2547         https://bugs.webkit.org/show_bug.cgi?id=50367
2548
2549         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2550
2551 2010-12-02  Tony Chang  <tony@chromium.org>
2552
2553         Unreviewed, rolling out r73164.
2554         http://trac.webkit.org/changeset/73164
2555         https://bugs.webkit.org/show_bug.cgi?id=50359
2556
2557         broke debugger tests on win
2558
2559         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2560
2561 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2562
2563         Reviewed by Tony Chang.
2564
2565         Rebaseline server: add updating of baselines
2566         https://bugs.webkit.org/show_bug.cgi?id=50305
2567         
2568         Implements updating of baselines, where we copy -actual.* files over
2569         the current -expected.* files. To do this, we need a
2570         _get_actual_result_files method to get test results files and a
2571         _rebaseline_test method to actually do the file copy and SCM operation.
2572         _rebaseline_test logs output into a buffer, this is useful for both
2573         showing result in the UI and for unit tests.
2574         
2575         To make passing around of the various test environment properties
2576         (results directory, filesystem, SCM, etc) easier, add a TestConfig
2577         class for them.
2578         
2579         Moving of existing baselines is not implemented yet, this patch is big
2580         enough as it is.
2581
2582         * Scripts/webkitpy/common/system/filesystem.py:
2583         * Scripts/webkitpy/common/system/filesystem_mock.py:
2584         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2585         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2586         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2587         * Scripts/webkitpy/tool/mocktool.py:
2588
2589 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
2590
2591         Unreviewed build fix after vcproj updates.
2592
2593         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
2594         that WIN_CAIRO is defined for this build.
2595         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
2596         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
2597         (these were previously 'Debug_Cairo' and 'Release_Cairo'
2598
2599 2010-12-02  Sam Weinig  <sam@webkit.org>
2600
2601         Reviewed by Anders Carlsson.
2602
2603         WebKit2 needs API to turn on popup blocking
2604         https://bugs.webkit.org/show_bug.cgi?id=50407
2605
2606         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2607         (TestWebKitAPI::TEST):
2608         * WebKitTestRunner/TestController.cpp:
2609         (WTR::TestController::resetStateToConsistentValues):
2610
2611 2010-12-01  Tony Chang  <tony@chromium.org>
2612
2613         Reviewed by Ojan Vafai.
2614
2615         [chromium] force NRWT to use DRT
2616         https://bugs.webkit.org/show_bug.cgi?id=50359
2617
2618         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2619
2620 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
2621
2622         Reviewed by Xan Lopez.
2623
2624         [GTK] DumpRenderTree has two copies of JavaScriptCore
2625         https://bugs.webkit.org/show_bug.cgi?id=49877
2626
2627         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
2628         LDADD list for DumpRenderTree.
2629
2630 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
2631
2632         Unreviewed: Added myself to list of Committers.
2633
2634         * Scripts/webkitpy/common/config/committers.py:
2635
2636 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
2637
2638         Reviewed by Adam Barth.
2639
2640         build-webkit --chromium always updates DEPS and re-generates project files
2641         https://bugs.webkit.org/show_bug.cgi?id=50340
2642         
2643         Make build-webkit --chromium invoke update-webkit-chromium only when
2644         --update-chromium is passed in, so that we don't add 20 seconds to all
2645         builds.
2646         
2647         Making all invocations update was added with r61883, with the goal of
2648         making EWS bots always update. The bots will switch to using this flag
2649         (as will all other webkit-patch build steps) so nothing should change
2650         for them.
2651
2652         * Scripts/webkitdirs.pm:
2653         * Scripts/webkitpy/common/config/ports.py:
2654         * Scripts/webkitpy/common/config/ports_unittest.py:
2655
2656 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
2657
2658         Reviewed by Tony Chang.
2659
2660         new-run-webkit-tests: add a --dry-run / -n flag
2661         https://bugs.webkit.org/show_bug.cgi?id=50045
2662
2663         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2664         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2665
2666 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2667
2668         Reviewed by Adam Roben.
2669
2670         WinCairo build should not use link-time code generation (LTCG)
2671         https://bugs.webkit.org/show_bug.cgi?id=50353
2672
2673         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2674         * DumpRenderTree/win/DumpRenderTree.vcproj:
2675         * DumpRenderTree/win/ImageDiff.vcproj:
2676         * FindSafari/FindSafari.vcproj:
2677         * MiniBrowser/MiniBrowser.vcproj:
2678         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2679         * WebKitAPITest/WebKitAPITest.vcproj:
2680         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2681         * WebKitTestRunner/win/InjectedBundle.vcproj:
2682         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2683         * WinLauncher/WinLauncher.vcproj:
2684         * record-memory-win/record-memory-win.vcproj:
2685
2686 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2687
2688         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
2689         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
2690         adding the file to the sources list was not enough to force the rebuild.
2691
2692         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
2693         Remove an empty line at the end of this file to force a rebuild.
2694
2695 2010-12-01  Sam Weinig  <sam@webkit.org>
2696
2697         Fix windows build.
2698
2699         * MiniBrowser/win/BrowserView.cpp:
2700         (BrowserView::create):
2701
2702 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2703
2704         Add missing file to the TestNetscapePlugin sources list after r73057.
2705
2706         * GNUmakefile.am: Add missing file.
2707
2708 2010-12-01  Sam Weinig  <sam@webkit.org>
2709
2710         Reviewed by Anders Carlsson.
2711
2712         Add PageGrouping to WebKit2 API
2713         https://bugs.webkit.org/show_bug.cgi?id=50332
2714
2715         - Update testing harnesses to deal with new PageGroup API.
2716
2717         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2718         (WKBundleInitialize):
2719         * TestWebKitAPI/InjectedBundleController.cpp:
2720         (TestWebKitAPI::InjectedBundleController::initialize):
2721         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
2722         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
2723         * TestWebKitAPI/InjectedBundleController.h:
2724         * TestWebKitAPI/InjectedBundleTest.h:
2725         (TestWebKitAPI::InjectedBundleTest::initialize):
2726         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
2727         * TestWebKitAPI/PlatformUtilities.cpp:
2728         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2729         * TestWebKitAPI/PlatformUtilities.h:
2730         * TestWebKitAPI/PlatformWebView.h:
2731         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2732         (TestWebKitAPI::TEST):
2733         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2734         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2735         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2736         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2737         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2738         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2739         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2740         (WTR::InjectedBundle::didInitializePageGroup):
2741         (WTR::InjectedBundle::initialize):
2742         (WTR::InjectedBundle::beginTesting):
2743         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2744         (WTR::InjectedBundle::pageGroup):
2745         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2746         (WTR::LayoutTestController::addUserScript):
2747         (WTR::LayoutTestController::addUserStyleSheet):
2748         (WTR::LayoutTestController::setXSSAuditorEnabled):
2749         * WebKitTestRunner/TestController.cpp:
2750         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2751         (WTR::PlatformWebView::PlatformWebView):
2752
2753 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2754
2755         Reviewed by Adam Roben.
2756
2757         vcproj changes can't be applied cleanly by the Windows EWS bot
2758         https://bugs.webkit.org/show_bug.cgi?id=50328
2759
2760         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2761         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
2762         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2763         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
2764         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
2765         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
2766         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
2767         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
2768         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
2769         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
2770         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
2771         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
2772         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
2773         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2774         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
2775         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
2776         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
2777         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
2778         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
2779         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
2780         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
2781         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
2782         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
2783         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
2784         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
2785         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
2786         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
2787         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
2788         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
2789         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
2790         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
2791         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
2792         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
2793         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
2794         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
2795         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
2796         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
2797         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
2798         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
2799         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
2800         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
2801         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
2802         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
2803         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
2804         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
2805
2806 2010-12-01  Anders Carlsson  <andersca@apple.com>
2807
2808         Reviewed by Darin Adler.
2809
2810         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
2811         https://bugs.webkit.org/show_bug.cgi?id=50336
2812
2813         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2814         Add new test.
2815
2816         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2817         (PluginTest::NPP_New):
2818         Add default implementation/
2819
2820         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2821         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
2822         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
2823         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
2824         Get the user agent.
2825
2826         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2827         (NPP_New):
2828         Call PluginTest::NPP_New.
2829
2830         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2831         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2832         Add new files.
2833
2834         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2835         (webkit_test_plugin_new_instance):
2836         Call PluginTest::NPP_New.
2837
2838 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
2839
2840         [wx] Build fixes after recent trunk changes.
2841
2842         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2843         (LayoutTestController::findString):
2844         * wx/build/settings.py:
2845
2846 2010-12-01  Dan Bernstein  <mitz@apple.com>
2847
2848         Reviewed by Darin Adler.
2849
2850         WebKitTestRunner needs layoutTestController.findString
2851         https://bugs.webkit.org/show_bug.cgi?id=50238
2852
2853         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
2854         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2855         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
2856         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2857
2858 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2859
2860         Try using svn:eol-style native on a vcproj file.
2861
2862         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
2863
2864 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
2865
2866         Reviewed by Adam Roben.
2867
2868         [WINCE] Add WinCELauncher
2869         https://bugs.webkit.org/show_bug.cgi?id=50217
2870
2871         * WinCELauncher/main.cpp: Added.
2872
2873 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
2874
2875         Reviewed by Kenneth Rohde Christiansen.
2876
2877         [Qt] Implement layoutTestController.findString
2878         https://bugs.webkit.org/show_bug.cgi?id=50236
2879
2880         Add the missing function to the LayoutTestController.
2881
2882         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2883         (LayoutTestController::findString):
2884         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2885
2886 2010-11-30  Tony Chang  <tony@chromium.org>
2887
2888         Reviewed by Adam Barth.
2889
2890         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
2891         https://bugs.webkit.org/show_bug.cgi?id=49036
2892
2893         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
2894             for CppVariants.
2895         (LayoutTestController::cppVariantToBool):
2896         (LayoutTestController::cppVariantToInt32):
2897         (LayoutTestController::setDatabaseQuota):
2898         (LayoutTestController::evaluateInWebInspector):
2899         (LayoutTestController::setMockGeolocationError):
2900
2901 2010-11-30  Eric Seidel  <eric@webkit.org>
2902
2903         Reviewed by Tony Chang.
2904
2905         update-webkit should call git fetch before git svn rebase
2906         https://bugs.webkit.org/show_bug.cgi?id=50273
2907
2908         After discussion on webkit-dev, we've decided to move the "default"
2909         git setup to pulling updates from git.webkit.org in preference
2910         to rebuilding the local svn index using git svn fetch every time.
2911
2912         This change should have no effect on people using the "old" git setup
2913         and should dramatically increase the speed of updates for those using
2914         the "new" git setup along with update-webkit.  I'm about to move the
2915         EWS and other queues over to this setup once this lands.
2916
2917         * Scripts/update-webkit:
2918
2919 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
2920
2921         Reviewed by Xan Lopez.
2922
2923         GTK: AX: implement press in DRT
2924         https://bugs.webkit.org/show_bug.cgi?id=36146
2925
2926         Implement AccessibilityUIElement::press() for GTK.
2927
2928         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2929         (AccessibilityUIElement::press): Implemented.
2930
2931 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
2932
2933         Reviewed by Tony Chang.
2934
2935         config.webkit_base_dir returns a path with a trailing slash
2936         https://bugs.webkit.org/show_bug.cgi?id=50197
2937         
2938         config.webkit_base_dir() should return a path without a trailing slash,
2939         like all the other methods that return paths.
2940         
2941         Undoes MockFileSytem changes by r72640, since they're no longer
2942         necessary for GetBaselinesTest to pass.
2943
2944         * Scripts/webkitpy/common/system/filesystem_mock.py:
2945         * Scripts/webkitpy/layout_tests/port/base.py:
2946         * Scripts/webkitpy/layout_tests/port/config.py:
2947         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2948
2949 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2950
2951         Reviewed by Tony Chang.
2952
2953         Rebaseline server: baseline display tweaks
2954         https://bugs.webkit.org/show_bug.cgi?id=50207
2955         
2956         Determine which baselines were used when running the tests and highlight
2957         them in the UI. Sort platform names alphabetically.
2958         
2959         Also makes the server URL be launched in the user's browser
2960         automatically.
2961
2962         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2963         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2964         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2965         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2966         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2967
2968 2010-11-30  Dan Bernstein  <mitz@apple.com>
2969
2970         Reviewed by Anders Carlsson.
2971
2972         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
2973         https://bugs.webkit.org/show_bug.cgi?id=50238
2974
2975         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2976         (WTR::LayoutTestController::findString): Added.
2977         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2978
2979 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
2980
2981         Reviewed by Adam Roben.
2982
2983         All projects on Windows should use cmd files for build events
2984         https://bugs.webkit.org/show_bug.cgi?id=50213
2985
2986         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2987         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
2988         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
2989         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2990         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
2991         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
2992         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2993         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
2994         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
2995         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
2996         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2997         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
2998         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
2999         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
3000         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3001         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
3002         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
3003         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3004         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
3005         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
3006         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3007         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3008         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
3009         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
3010         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
3011         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
3012         * WinLauncher/WinLauncherCommon.vsprops:
3013         * WinLauncher/WinLauncherPostBuild.cmd: Added.
3014         * WinLauncher/WinLauncherPreBuild.cmd: Added.
3015
3016 2010-11-29  Dan Bernstein  <mitz@apple.com>
3017
3018         GTK DumpRenderTree build fix after r72887.
3019
3020         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3021         (LayoutTestController::findString):
3022
3023 2010-11-29  Dan Bernstein  <mitz@apple.com>
3024
3025         Windows DumpRenderTree build fix after r72887.
3026
3027         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3028         (LayoutTestController::findString): Added empty implementation.
3029
3030 2010-11-29  Dan Bernstein  <mitz@apple.com>
3031
3032         Reviewed by Darin Adler.
3033
3034         DumpRenderTree changes for testing the text search API.
3035         https://bugs.webkit.org/show_bug.cgi?id=50038
3036
3037         * DumpRenderTree/LayoutTestController.cpp:
3038         (findStringCallback):
3039         (LayoutTestController::staticFunctions):
3040         * DumpRenderTree/LayoutTestController.h:
3041         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3042         (LayoutTestController::findString):
3043         * MiniBrowser/mac/BrowserWindowController.m:
3044         (-[BrowserWindowController find:]):
3045
3046 2010-11-29  Johnny Ding  <jnd@chromium.org>
3047
3048         Unreviewed: Add myself to the list of Committers.
3049
3050         * Scripts/webkitpy/common/config/committers.py:
3051
3052 2010-11-29  Mark Rowe  <mrowe@apple.com>
3053
3054         Reviewed by Adele Peterson.
3055
3056         <rdar://problem/8694997> DumpRenderTree fails to build.
3057
3058         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
3059
3060 2010-11-29  Mark Rowe  <mrowe@apple.com>
3061
3062         Reviewed by Adele Peterson.
3063
3064         <rdar://problem/8694997> DumpRenderTree fails to build.
3065
3066         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
3067         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
3068         * DumpRenderTree/mac/PerlSupport/Makefile:
3069
3070 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
3071
3072         Reviewed by Martin Robinson.
3073
3074         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
3075         https://bugs.webkit.org/show_bug.cgi?id=50154
3076
3077         Added missing checks to allAttributes().
3078
3079         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3080         (AccessibilityUIElement::allAttributes): Added missing checks.
3081
3082 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3083
3084         Reviewed by Kenneth Rohde Christiansen.
3085
3086         [Qt] Allow pre-generation for package builds for WebKit2
3087         https://bugs.webkit.org/show_bug.cgi?id=50139
3088
3089         Use a build variable for the generated directory path and set the
3090         value based on CONFIG just like for WebKit1.
3091
3092         For non-package builds use a relative base path for the
3093         genrated directory just like for WebKit1.
3094
3095         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3096         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3097
3098 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3099
3100         Reviewed by Kenneth Rohde Christiansen.
3101
3102         [Qt] Move some build logic from Qt to platform independent code
3103         https://bugs.webkit.org/show_bug.cgi?id=50134
3104
3105         Create target directories inside generate-forwarding-headers.pl.
3106
3107         * Scripts/generate-forwarding-headers.pl:
3108
3109 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
3110
3111         Reviewed by Martin Robinson.
3112
3113         [GTK] Windowless plugins gets broken key input
3114         https://bugs.webkit.org/show_bug.cgi?id=49927
3115
3116         Convert the XEvent::keycode to ASCII before printing it. Not
3117         doing this was causing false positive in 
3118         plugins/keyboard-events.html.
3119
3120         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3121         (keycode_to_char):
3122         (webkit_test_plugin_handle_event):
3123
3124 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
3125
3126         Reviewed by Antonio Gomes.
3127
3128         [Qt] Html autofocus not working with QGraphicsWebView
3129         https://bugs.webkit.org/show_bug.cgi?id=43169
3130
3131         Tell the scene to set the webview item as the currently
3132         focused item. This makes the input field with autofocus get
3133         focus as it should.
3134
3135         * QtTestBrowser/webview.cpp:
3136         (WebViewGraphicsBased::WebViewGraphicsBased):
3137
3138 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3139
3140         Reviewed by Tony Chang.
3141
3142         nrwt - clean up create_driver interface and print out the
3143         command line used for DumpRenderTree/TestShell.
3144
3145         This patch adds a driver_cmd_line() call to the Port class in
3146         order to retrive the command line to print it out (as part of
3147         --print config).
3148
3149         In addition, this patch cleans up the Port.create_driver()
3150         signature and the Driver constructor interface to take a worker
3151         number and no longer require the image_path argument (Chromium's
3152         drivers now synthesize the image_path from the worker number
3153         internally).
3154
3155         https://bugs.webkit.org/show_bug.cgi?id=49934
3156
3157         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3158         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3159         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3160         * Scripts/webkitpy/layout_tests/port/base.py:
3161         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3162         * Scripts/webkitpy/layout_tests/port/chromium.py:
3163         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3164         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3165         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3166         * Scripts/webkitpy/layout_tests/port/test.py:
3167         * Scripts/webkitpy/layout_tests/port/webkit.py:
3168         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3169         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3170
3171 2010-11-24  Ojan Vafai  <ojan@chromium.org>
3172
3173         Reviewed by Tony Chang.
3174
3175         [chromium] improve memory usage for test results server and store fewer runs
3176         https://bugs.webkit.org/show_bug.cgi?id=50035
3177
3178         Store fewer runs and don't pass full files around when we only need bools.
3179         Greatly improves error rates on test-results.appspot.com.
3180
3181         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3182         * TestResultServer/handlers/testfilehandler.py:
3183         * TestResultServer/model/dashboardfile.py:
3184         * TestResultServer/model/jsonresults.py:
3185
3186 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3187
3188         Reviewed by Tony Chang.
3189
3190         This patch implements the first part of the manager side of the
3191         Broker objects - it handles creating threads, waiting for them
3192         to complete, and running a single-threaded loop as well.
3193
3194         https://bugs.webkit.org/show_bug.cgi?id=49779
3195
3196         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3197         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3198         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3199         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3200
3201 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
3202
3203         Reviewed by David Levin.
3204
3205         DRT should not generate pixel output for text/plain tests
3206         https://bugs.webkit.org/show_bug.cgi?id=50002
3207         
3208         Modify Mac, Windows and GTK DRT implementations to disable pixel output
3209         when encountering a text/plain response (the Chromium one already does
3210         this, and none of the other ports special-case text/plain output in
3211         the first place).
3212
3213         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3214         (dump):
3215         * DumpRenderTree/mac/DumpRenderTree.mm:
3216         (dump):
3217         * DumpRenderTree/win/DumpRenderTree.cpp:
3218         (dump):
3219
3220 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3221
3222         Unreviewed.
3223
3224         Add my other email address to committers.py.
3225
3226         * Scripts/webkitpy/common/config/committers.py:
3227
3228 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3229
3230         Reviewed by Csaba Osztrogonác.
3231
3232         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
3233         https://bugs.webkit.org/show_bug.cgi?id=49975
3234
3235         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
3236         to enable the script to define it 0 in case of a minimal build.
3237
3238 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
3239
3240         Reviewed by Xan Lopez.
3241
3242         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
3243         https://bugs.webkit.org/show_bug.cgi?id=49143
3244
3245         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3246         (createWebView): Call the new connectEditingCallbacks function.
3247         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
3248         (dumpNodePath):
3249         (dumpRange):
3250         (insertActionString):
3251         (selectionAffinityString):
3252         (shouldBeginEditing):
3253         (shouldEndEditing):
3254         (shouldInsertNode):
3255         (shouldInsertText):
3256         (shouldDeleteRange):
3257         (shouldShowDeleteInterfaceForElement):
3258         (shouldChangeSelectedRange):
3259         (shouldApplyStyle):
3260         (editingBegan):
3261         (userChangedContents):
3262         (editingEnded):
3263         (selectionChanged):
3264         (connectEditingCallbacks):
3265         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
3266         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
3267
3268 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
3269
3270         Reviewed by Andreas Kling.
3271
3272         [Qt] Make QtTestBrowser remember the selected user agent
3273         https://bugs.webkit.org/show_bug.cgi?id=50021
3274
3275         Set user agent for a new page by using the old page's
3276
3277         * QtTestBrowser/mainwindow.cpp:
3278         (MainWindow::setPage):
3279
3280 2010-11-24 Patrick Gansterer <paroga@webkit.org>
3281
3282         Reviewed by Csaba Osztrogonác.
3283
3284         Remove Bakefile build system files
3285         https://bugs.webkit.org/show_bug.cgi?id=49983
3286
3287         r53757 only removed the content, but not the files.
3288         This patch removes that empty files.
3289
3290         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
3291         * wx/browser/browser.bkl: Removed.
3292         * wx/build-wxwebkit: Removed.
3293
3294 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
3295
3296         Reviewed by Tony Chang.
3297
3298         This patch cleans up the logic used to shard tests into groups a
3299         bit and adds the --worker-model flag to NRWT. The flag is only
3300         used at the moment to control whether to run single-threaded or
3301         not, but eventually will also allow toggling between threads and
3302         processes.
3303
3304         Also add a minor cleanup with _test_is_slow(), which just
3305         eliminates some repetition and gives slightly better encapsulation.
3306
3307         https://bugs.webkit.org/show_bug.cgi?id=49773
3308
3309         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3310         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3311
3312 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
3313
3314         Reviewed by Tony Chang.
3315
3316         Rebaseline server: list current baselines and platforms
3317         https://bugs.webkit.org/show_bug.cgi?id=49991
3318         
3319         List existing baselines (with Trac links) for tests.
3320         
3321         Add dropdowns for choosing with platform baselines to target (and what
3322         to do with existing ones).
3323
3324         Also fix MockFileSystem.join to behave more like os.path.join (unit
3325         test was ending up with two consecutive slashes in a layout test
3326         path).        
3327
3328         * Scripts/webkitpy/common/system/filesystem_mock.py:
3329         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3330         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3331         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3332         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
3333         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3334         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3335         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
3336
3337 2010-11-23  Ojan Vafai  <ojan@chromium.org>
3338
3339         Reviewed by Tony Chang.
3340
3341         remove timeout argument to urlopen
3342         https://bugs.webkit.org/show_bug.cgi?id=49995
3343
3344         Apparently the version of python we have on the bots doesn't accept a timeout argument.
3345
3346         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3347
3348 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3349
3350         Unreviewed, rolling out r72628.
3351         http://trac.webkit.org/changeset/72628
3352         https://bugs.webkit.org/show_bug.cgi?id=49994
3353
3354         This patch is causing layout-test failtures on GTK Linux
3355         64-bit Debug (Requested by ctguil on #webkit).
3356
3357         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3358         (AccessibilityUIElement::AccessibilityUIElement):
3359         (AccessibilityUIElement::parentElementCallback):
3360         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3361         * DumpRenderTree/chromium/CppBoundClass.cpp:
3362         * DumpRenderTree/chromium/CppBoundClass.h:
3363
3364 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3365
3366         Reviewed by Tony Chang.
3367
3368         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
3369         https://bugs.webkit.org/show_bug.cgi?id=49944
3370
3371         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3372
3373 2010-11-23  Chris Guillory  <chris.guillory@google.com>
3374
3375         Reviewed by Dimitri Glazkov.
3376
3377         Include the FrameView widget of a RenderWidget in the accessibility tree.
3378         https://bugs.webkit.org/show_bug.cgi?id=49106
3379
3380         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3381         (AccessibilityUIElement::AccessibilityUIElement):
3382         (AccessibilityUIElement::parentElementCallback):
3383         (AccessibilityUIElement::isEqualCallback):
3384         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3385         * DumpRenderTree/chromium/CppBoundClass.cpp:
3386         (CppBoundClass::getFromCppVariant):
3387         * DumpRenderTree/chromium/CppBoundClass.h:
3388
3389 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
3390
3391         Reviewed by Kenneth Rohde Christiansen.
3392
3393         [EFL] Add tiled backing store to EWebLauncher
3394         https://bugs.webkit.org/show_bug.cgi?id=45777
3395
3396         Allow EWebLauncher to choose between single and tiled backing store
3397
3398         * EWebLauncher/main.c:
3399         (on_key_down):
3400         (browserCreate):
3401         (main):
3402
3403 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3404
3405         Reviewed by Tor Arne Vestbø.
3406
3407         [Qt] Review the setUserPermission & friends API
3408         https://bugs.webkit.org/show_bug.cgi?id=46810
3409
3410         Renamed requestPermissionFromUser to featurePermissionRequested
3411         and cancelRequestsForPermission to featurePermissionRequestCanceled.
3412
3413         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3414         (WebCore::WebPage::WebPage):
3415         * QtTestBrowser/webpage.cpp:
3416         (WebPage::WebPage):
3417         (WebPage::featurePermissionRequestCanceled):
3418         * QtTestBrowser/webpage.h:
3419
3420 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3421
3422         Reviewed by Tor Arne Vestbø.
3423
3424         [Qt] Review the setUserPermission & friends API
3425         https://bugs.webkit.org/show_bug.cgi?id=46810
3426
3427         Rename setUserPermission to setFeaturePermission
3428
3429         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3430         (WebCore::WebPage::requestPermission):
3431         (WebCore::WebPage::permissionSet):
3432         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3433         (LayoutTestController::grantDesktopNotificationPermission):
3434         * QtTestBrowser/webpage.cpp:
3435         (WebPage::requestPermission):
3436
3437 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3438
3439         Reviewed by Tor Arne Vestbø.
3440
3441         [Qt] Review the setUserPermission & friends API
3442         https://bugs.webkit.org/show_bug.cgi?id=46810
3443
3444         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
3445         and GeolocationPermissionDomain to Geolocation.
3446
3447         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3448         (WebCore::WebPage::WebPage):
3449         (WebCore::WebPage::requestPermission):
3450         (WebCore::WebPage::cancelPermission):
3451         (WebCore::WebPage::permissionSet):
3452         (WebCore::DumpRenderTree::geolocationPermissionSet):
3453         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3454         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3455         (LayoutTestController::grantDesktopNotificationPermission):
3456         * QtTestBrowser/webpage.cpp:
3457         (WebPage::WebPage):
3458         (WebPage::requestPermission):
3459         (WebPage::cancelRequestsForPermission):
3460         * QtTestBrowser/webpage.h:
3461
3462 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3463
3464         Reviewed by Tor Arne Vestbø.
3465
3466         [Qt] Review the setUserPermission & friends API
3467         https://bugs.webkit.org/show_bug.cgi?id=46810
3468
3469         Add a ByUser suffix to PermissionGranted/Denied. In the future
3470         we can add PermissionGrantedByDefault.
3471
3472
3473         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3474         (WebCore::WebPage::requestPermission):
3475         (WebCore::WebPage::permissionSet):
3476         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3477         (LayoutTestController::grantDesktopNotificationPermission):
3478         * QtTestBrowser/webpage.cpp:
3479         (WebPage::requestPermission):
3480
3481 2010-11-18  Satish Sampath  <satish@chromium.org>
3482
3483         Reviewed by Jeremy Orlow.
3484
3485         For speech input event, send an event object containing all the recognition results and metadata.
3486         https://bugs.webkit.org/show_bug.cgi?id=49736
3487
3488         Updated DRT by renaming the mock result method on all platforms to the new signature.
3489
3490         * DumpRenderTree/LayoutTestController.cpp:
3491         (addMockSpeechInputResultCallback):
3492         (LayoutTestController::staticFunctions):
3493         * DumpRenderTree/LayoutTestController.h:
3494         * DumpRenderTree/chromium/LayoutTestController.cpp:
3495         (LayoutTestController::LayoutTestController):
3496         (LayoutTestController::addMockSpeechInputResult):
3497         * DumpRenderTree/chromium/LayoutTestController.h:
3498         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3499         (LayoutTestController::addMockSpeechInputResult):
3500         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3501         (LayoutTestController::addMockSpeechInputResult):
3502         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3503         (LayoutTestController::addMockSpeechInputResult):
3504         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3505         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3506         (LayoutTestController::addMockSpeechInputResult):
3507         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3508         (LayoutTestController::addMockSpeechInputResult):
3509
3510 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
3511
3512         Reviewed by Tony Chang.
3513
3514         Fix some spacing issues with log messages with
3515         new-run-webkit-tests --verbose.
3516
3517         https://bugs.webkit.org/show_bug.cgi?id=49936
3518
3519         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3520
3521 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3522
3523         Reviewed by Adam Barth.
3524
3525         update scm to work with different remote branches
3526         https://bugs.webkit.org/show_bug.cgi?id=49949
3527
3528         This works if there are multiple svn tracking branches
3529         and/or if the tracking branch is refs/remots/origin/master
3530         instead of refs/remotes/trunk which is the direction we're trying
3531         to head since that makes fetches faster.
3532
3533         * Scripts/webkitpy/common/checkout/scm.py:
3534         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3535
3536 2010-11-22  Hayato Ito  <hayato@chromium.org>
3537
3538         Reviewed by Shinichiro Hamaji.
3539
3540         Ignore reference files which will be used by reftests when collecting
3541         test cases.
3542         https://bugs.webkit.org/show_bug.cgi?id=49835
3543
3544         * Scripts/webkitpy/layout_tests/port/test_files.py:
3545         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3546
3547 2010-11-22  Adam Roben  <aroben@apple.com>
3548
3549         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
3550
3551         Apple's Windows build allows placing header files and import libraries for WebKit's
3552         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
3553         $WebKitLibrariesDir environment variable. This is both required for production builds and
3554         convenient for Apple-internal developer builds. Apple's production builds also require that
3555         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
3556         builds, the files are copied into that directory tree by the
3557         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
3558         copying is done by
3559         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
3560
3561         This .vsprops copying is problematic in one very important case: when a developer updates
3562         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
3563         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
3564         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
3565         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
3566         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
3567         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
3568
3569         To fix this, we now use normal relative paths to access the .vsprops files in the source
3570         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
3571         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
3572         unset, so the normal relative paths are used to read the .vsprops files out of the source
3573         tree directly. In production builds, this environment variable is set to a fake directory
3574         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
3575         is resolved.
3576         
3577         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
3578
3579         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3580
3581         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
3582         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
3583         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
3584         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
3585         FeatureDefines.vsprops becomes:
3586
3587         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3588
3589         which resolves to:
3590
3591         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3592
3593         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
3594         actually exist since they are matched by an equal number of ".." path components.)
3595
3596         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
3597         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
3598
3599         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
3600         updated
3601
3602         Reviewed by Dave Hyatt.
3603
3604         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3605         * DumpRenderTree/win/DumpRenderTree.vcproj:
3606         * DumpRenderTree/win/ImageDiff.vcproj:
3607         * FindSafari/FindSafari.vcproj:
3608         * MiniBrowser/MiniBrowser.vcproj:
3609         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3610         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3611         * WebKitAPITest/WebKitAPITest.vcproj:
3612         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3613         * WebKitTestRunner/win/InjectedBundle.vcproj:
3614         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3615         * WinLauncher/WinLauncher.vcproj:
3616         * record-memory-win/record-memory-win.vcproj:
3617         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
3618         files.
3619
3620 2010-11-22  Adam Roben  <aroben@apple.com>
3621
3622         Make it possible to run tests on Windows without Visual Studio or VC++
3623         Express installed
3624
3625         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
3626         are not installed. But this function doesn't need to be called when we
3627         already have a build available and are just trying to run the tests.
3628
3629         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
3630         because Visual Studio/VC++ Express aren't installed
3631
3632         Reviewed by Dave Hyatt.
3633
3634         * Scripts/webkitdirs.pm:
3635         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
3636         it is not needed by this function. Also added a FIXME.
3637
3638         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than</