Enable tests for Windows EWS!
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-29  Lucas Forschler  <lforschler@apple.com>
2
3         Enable tests for Windows EWS!
4         https://bugs.webkit.org/show_bug.cgi?id=107968
5         
6         Reviewed by Adam Barth.
7
8         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
9         (WinEWS):
10
11 2013-01-29  Alan Cutter  <alancutter@chromium.org>
12
13         MockWeb should be able to serve mock web content
14         https://bugs.webkit.org/show_bug.cgi?id=108240
15
16         Reviewed by Dirk Pranke.
17
18         Added the ability to have MockWeb serve mock web data.
19
20         * Scripts/webkitpy/common/host_mock.py:
21         (MockHost.__init__):
22         * Scripts/webkitpy/common/net/web_mock.py:
23         (MockWeb.__init__):
24         (MockWeb.get_binary):
25
26 2013-01-29  Jessie Berlin  <jberlin@apple.com>
27
28         run-api-tests should have an option to specify root
29         https://bugs.webkit.org/show_bug.cgi?id=108210
30
31         Reviewed by Ryosuke Niwa.
32
33         * Scripts/run-api-tests:
34         Add the option and use it to set the configuration product directory. Since it is supposed
35         to point to the built products, do not build the products if root is specified (this mimics
36         the behavior of run-javascriptcore-tests).
37
38 2013-01-29  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
39
40         [EFL] Add Toggle fullscreen (F11) to MiniBrowser
41         https://bugs.webkit.org/show_bug.cgi?id=108122
42
43         Reviewed by Antonio Gomes.
44
45         Adds fullscreen mode toggle (F11) option to MiniBrowser using native API.
46
47         * MiniBrowser/efl/main.c:
48         (on_key_down): Add 'F11' key handler.
49
50 2013-01-29  Patrick Gansterer  <paroga@webkit.org>
51
52         [CMake] Use offical Windows CE support
53         https://bugs.webkit.org/show_bug.cgi?id=108061
54
55         Reviewed by Laszlo Gombos.
56
57         Recent version of CMake has added Windows CE support, but uses a
58         slightly different interface than the patched version used before.
59         Change the command line parameters to use the offical CMake binaries.
60
61         * Scripts/webkitdirs.pm:
62         (cmakeBasedPortArguments):
63
64 2013-01-29  Alan Cutter  <alancutter@chromium.org>
65
66         QueueStatusServer needs pages to display historical queue data
67         https://bugs.webkit.org/show_bug.cgi?id=107659
68
69         Reviewed by Eric Seidel.
70
71         Created a /queue-charts/<queue-name> handler to present queue and patch data using Google Chart Tools.
72
73         * QueueStatusServer/app.yaml:
74         * QueueStatusServer/config/charts.py: Copied from Tools/QueueStatusServer/model/queuelog.py.
75         (get_time_unit):
76         * QueueStatusServer/filters/webkit_extras.py:
77         (webkit_linkify):
78         (webkit_bug_id):
79         (webkit_attachment_id):
80         (results_link):
81         (queue_status_link):
82         (queue_charts_link):
83         * QueueStatusServer/handlers/queuecharts.py: Added.
84         (QueueCharts):
85         (QueueCharts.get):
86         (QueueCharts._get_min_med_max):
87         (QueueCharts._get_patch_data):
88         (QueueCharts._get_patch_logs):
89         (QueueCharts._get_queue_data):
90         (QueueCharts._get_queue_logs):
91         (QueueCharts._get_time_unit):
92         (QueueCharts._get_timestamp):
93         (QueueCharts._get_view_range):
94         * QueueStatusServer/handlers/queuestatus.py:
95         (QueueStatus.get):
96         * QueueStatusServer/index.yaml:
97         * QueueStatusServer/main.py:
98         * QueueStatusServer/model/queuelog.py:
99         (QueueLog):
100         (QueueLog.create_key):
101         (QueueLog.get_at):
102         (QueueLog.get_current):
103         (QueueLog.get_or_create):
104         (QueueLog._get_or_create_txn):
105         * QueueStatusServer/stylesheets/charts.css: Added.
106         (.chart):
107         (.choices):
108         * QueueStatusServer/templates/queuecharts.html: Added.
109         * QueueStatusServer/templates/queuestatus.html:
110
111 2013-01-29  Mario Sanchez Prada  <mario.prada@samsung.com>
112
113         [GTK] Missing build flags when building with Harfbuzz
114         https://bugs.webkit.org/show_bug.cgi?id=108174
115
116         Reviewed by Martin Robinson.
117
118         Add FREETYPE_CFLAGS and FREETYPE_LIBS to makefiles so -lharfbuzz
119         parameter will be added to linking lines when needed.
120
121         * GNUmakefile.am: Added FREETYPE_CFLAGS and FREETYPE_LIBS.
122         * MiniBrowser/gtk/GNUmakefile.am: Ditto.
123         * TestWebKitAPI/GNUmakefile.am: Ditto.
124
125 2013-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
126
127         [GTK] Implement resources API using injected bundle
128         https://bugs.webkit.org/show_bug.cgi?id=107457
129
130         Reviewed by Sam Weinig.
131
132         * Scripts/run-gtk-tests:
133         (TestRunner): Unksip resources unit tests.
134
135 2013-01-29  Michael Brüning  <michael.bruning@digia.com>
136
137         Unreviewed, updated my email information.
138
139         * Scripts/webkitpy/common/config/committers.py:
140
141 2013-01-29  Jochen Eisinger  <jochen@chromium.org>
142
143         [chromium] delete DRTTestRunner
144         https://bugs.webkit.org/show_bug.cgi?id=108082
145
146         Reviewed by Adam Barth.
147
148         * DumpRenderTree/DumpRenderTree.gypi:
149         * DumpRenderTree/chromium/DRTTestRunner.cpp: Removed.
150         * DumpRenderTree/chromium/DRTTestRunner.h: Removed.
151         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
152         (WebTestRunner::WebTestDelegate::testFinished):
153         (WebTestRunner::WebTestDelegate::testTimedOut):
154         (WebTestRunner::WebTestDelegate::isBeingDebugged):
155         (WebTestRunner::WebTestDelegate::layoutTestTimeout):
156         (WebTestRunner::WebTestDelegate::closeRemainingWindows):
157         (WebTestRunner::WebTestDelegate::navigationEntryCount):
158         (WebTestRunner::WebTestDelegate::windowCount):
159         (WebTestRunner::WebTestDelegate::setCustomPolicyDelegate):
160         (WebTestRunner::WebTestDelegate::waitForPolicyDelegate):
161         (WebTestRunner::WebTestDelegate::goToOffset):
162         (WebTestRunner::WebTestDelegate::reload):
163         (WebTestRunner::WebTestDelegate::loadURLForFrame):
164         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
165         (WebTestRunner::WebTestRunner::policyDelegateDone):
166         (WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
167         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
168         (WebTestRunner::TestRunner::WorkQueue::~WorkQueue):
169         (WebTestRunner):
170         (WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
171         (WebTestRunner::TestRunner::WorkQueue::processWork):
172         (WebTestRunner::TestRunner::WorkQueue::reset):
173         (WebTestRunner::TestRunner::WorkQueue::addWork):
174         (WebTestRunner::TestRunner::TestRunner):
175         (WebTestRunner::TestRunner::reset):
176         (WebTestRunner::TestRunner::policyDelegateDone):
177         (WebTestRunner::TestRunner::shouldInterceptPostMessage):
178         (WebTestRunner::TestRunner::waitUntilDone):
179         (WebTestRunner::TestRunner::notifyDone):
180         (WebTestRunner::TestRunner::completeNotifyDone):
181         (WorkItemBackForward):
182         (WebTestRunner::WorkItemBackForward::WorkItemBackForward):
183         (WebTestRunner::WorkItemBackForward::run):
184         (WebTestRunner::TestRunner::queueBackNavigation):
185         (WebTestRunner::TestRunner::queueForwardNavigation):
186         (WorkItemReload):
187         (WebTestRunner::WorkItemReload::run):
188         (WebTestRunner::TestRunner::queueReload):
189         (WorkItemLoadingScript):
190         (WebTestRunner::WorkItemLoadingScript::WorkItemLoadingScript):
191         (WebTestRunner::WorkItemLoadingScript::run):
192         (WorkItemNonLoadingScript):
193         (WebTestRunner::WorkItemNonLoadingScript::WorkItemNonLoadingScript):
194         (WebTestRunner::WorkItemNonLoadingScript::run):
195         (WebTestRunner::TestRunner::queueLoadingScript):
196         (WebTestRunner::TestRunner::queueNonLoadingScript):
197         (WorkItemLoad):
198         (WebTestRunner::WorkItemLoad::WorkItemLoad):
199         (WebTestRunner::WorkItemLoad::run):
200         (WebTestRunner::TestRunner::queueLoad):
201         (WorkItemLoadHTMLString):
202         (WebTestRunner::WorkItemLoadHTMLString::WorkItemLoadHTMLString):
203         (WebTestRunner::WorkItemLoadHTMLString::run):
204         (WebTestRunner::TestRunner::queueLoadHTMLString):
205         (WebTestRunner::TestRunner::locationChangeDone):
206         (WebTestRunner::TestRunner::windowCount):
207         (WebTestRunner::TestRunner::setCloseRemainingWindowsWhenComplete):
208         (WebTestRunner::TestRunner::setCustomPolicyDelegate):
209         (WebTestRunner::TestRunner::waitForPolicyDelegate):
210         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
211         (TestRunner):
212         (WorkItem):
213         (WebTestRunner::TestRunner::WorkItem::~WorkItem):
214         (WorkQueue):
215         (WebTestRunner::TestRunner::WorkQueue::WorkQueue):
216         (WebTestRunner::TestRunner::WorkQueue::setFrozen):
217         (WebTestRunner::TestRunner::WorkQueue::isEmpty):
218         (WebTestRunner::TestRunner::WorkQueue::taskList):
219         * DumpRenderTree/chromium/TestShell.cpp:
220         (TestShell::initialize):
221         (TestShell::runFileTest):
222         (TestShell::loadURL):
223         (TestShell::createNewWindow):
224         * DumpRenderTree/chromium/TestShell.h:
225         (TestShell::testRunner):
226         (TestShell):
227         * DumpRenderTree/chromium/WebViewHost.cpp:
228         (WebViewHost::testFinished):
229         (WebViewHost::testTimedOut):
230         (WebViewHost::isBeingDebugged):
231         (WebViewHost::layoutTestTimeout):
232         (WebViewHost::closeRemainingWindows):
233         (WebViewHost::navigationEntryCount):
234         (WebViewHost::windowCount):
235         (WebViewHost::setCustomPolicyDelegate):
236         (WebViewHost::waitForPolicyDelegate):
237         (WebViewHost::goToOffset):
238         (WebViewHost::reload):
239         (WebViewHost::loadURLForFrame):
240         (WebViewHost::shutdown):
241         (WebViewHost::testRunner):
242         * DumpRenderTree/chromium/WebViewHost.h:
243         (WebTestRunner):
244         (WebViewHost):
245
246 2013-01-28  Timothy Loh  <timloh@chromium.com>
247
248         Refactor ChangeLog and PrepareChangeLog to use FileSystem objects
249         https://bugs.webkit.org/show_bug.cgi?id=107903
250
251         Reviewed by Eric Seidel.
252
253         To make ChangeLog and PrepareChangeLog easier to test, we can use
254         FileSystem objects instead of just passing around paths.
255
256         * Scripts/webkitpy/common/checkout/changelog.py:
257         (ChangeLog.__init__):
258         (ChangeLog.parse_latest_entry_from_file):
259         (ChangeLog.parse_entries_from_file):
260         (ChangeLog.latest_entry):
261         (ChangeLog.update_with_unreviewed_message):
262         (ChangeLog.set_reviewer):
263         (ChangeLog.set_short_description_and_bug_url):
264         (ChangeLog.delete_entries):
265         (ChangeLog.prepend_text):
266         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
267         (ChangeLogTest):
268         (test_parse_log_entries_from_changelog):
269         (test_latest_entry_parse_single_entry):
270         (test_set_reviewer):
271         (test_set_short_description_and_bug_url):
272         (test_delete_entries):
273         (test_prepend_text):
274         * Scripts/webkitpy/common/system/filesystem_mock.py:
275         (ReadableTextFileObject.__init__):
276         * Scripts/webkitpy/tool/steps/preparechangelog.py:
277         (PrepareChangeLog._ensure_bug_url):
278         (PrepareChangeLog._resolve_existing_entry):
279         (PrepareChangeLog.run):
280         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
281         (test_ensure_bug_url):
282         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
283         (_assert_message_for_revert_output):
284
285 2013-01-28  Raymond Toy  <rtoy@google.com>
286
287         Add myself to committers.py
288         https://bugs.webkit.org/show_bug.cgi?id=107992
289
290         Reviewed by kbr@google.com.
291
292         * Scripts/webkitpy/common/config/committers.py:
293
294 2013-01-28  Joseph Pecoraro  <pecoraro@apple.com>
295
296         [Mac] Update PageVisibilityState when WebView is hidden / visible
297         https://bugs.webkit.org/show_bug.cgi?id=107509
298
299         Reviewed by Sam Weinig.
300
301         Add a test that PageVisibility of WK1 WebViews and WK2 WKViews
302         automatically changes between hidden and visible as the view is added
303         and removed from window, or when it is in a window that changes
304         visibility, for instance by minimizing / deminimizing.
305
306         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
307         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html: Added.
308         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Added.
309         (-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
310         (runJavaScriptAlert):
311         (PageVisibilityStateWithWindowChanges):
312         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
313         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
314         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
315         (TestWebKitAPI::TEST_F):
316         Test visibility state of a page in a WebView/WKView with different window states.
317
318         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
319         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
320         (TestWebKitAPI::WebKitAgnosticTest::teardownView):
321         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
322         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
323         Add a WK1 and WK2 teardownView to balance initializeView.
324
325 2013-01-28  Joseph Pecoraro  <pecoraro@apple.com>
326
327         Improve PageVisibility API with enums
328         https://bugs.webkit.org/show_bug.cgi?id=107364
329
330         Reviewed by Sam Weinig.
331
332         * DumpRenderTree/mac/TestRunnerMac.mm:
333         (TestRunner::resetPageVisibility):
334         (TestRunner::setPageVisibility):
335         Update the WK1 test code to use the new WK1 enums.
336
337         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
338         (WTR::InjectedBundle::setVisibilityState):
339         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
340         (InjectedBundle):
341         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
342         (WTR::TestRunner::setPageVisibility):
343         (WTR::TestRunner::resetPageVisibility):
344         * WebKitTestRunner/TestController.cpp:
345         (WTR::TestController::setVisibilityState):
346         * WebKitTestRunner/TestController.h:
347         (TestController):
348         * WebKitTestRunner/TestInvocation.cpp:
349         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
350         Update the WK2 test code to use the new WK2 API and enums.
351
352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
353         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Added.
354         (TestWebKitAPI):
355         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
356         (TestWebKitAPI::assertSerializedScriptValueIsStringValue):
357         (TestWebKitAPI::didRunStep1StateChangeVisibleToHidden):
358         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
359         (TestWebKitAPI::didRunStep3StateChangePrerenderToPreview):
360         (TestWebKitAPI::didRunStep4InStatePreview):
361         (TestWebKitAPI::TEST):
362         Test the new WK2 API with all enum types.
363
364 2013-01-28  Jochen Eisinger  <jochen@chromium.org>
365
366         [chromium] remove temporary define used for updating TestRunner API
367
368         Unreviewed. Clean-up change.
369
370         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
371
372 2013-01-28  James Craig  <james@cookiecrook.com>
373
374         HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
375         https://bugs.webkit.org/show_bug.cgi?id=107650
376
377         Reviewed by Chris Fleizach.
378
379         Updating accessibility strings and accessors for DL/DT/DD.
380
381         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js:
382         (createDescriptionList):
383         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
384         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
385
386 2013-01-28  Manuel Rego Casasnovas  <rego@igalia.com>
387
388         [GTK][WTR] Update layoutTestController.pathToLocalResource
389         https://bugs.webkit.org/show_bug.cgi?id=107538
390
391         Reviewed by Martin Robinson.
392
393         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
394         (WTR::TestRunner::pathToLocalResource): Update implementation based on
395         DRT code.
396
397 2013-01-28  Manuel Rego Casasnovas  <rego@igalia.com>
398
399         [GTK][WTR] Move getTopLevelPath() to utilities file
400         https://bugs.webkit.org/show_bug.cgi?id=107541
401
402         Reviewed by Martin Robinson.
403
404         * WebKitTestRunner/GNUmakefile.am: Add new files.
405         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
406         (WTR::getOutputDir): Uses the moved method from InjectedBundleUtilities.
407         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp: Added.
408         (WTR):
409         (WTR::topLevelPath): Implementation moved from ActivateFontsGtk.
410         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h: Added.
411         (WTR): Add new method header and documentation.
412
413 2013-01-28  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
414
415         [EFL] Include Ecore_Getopt.h in MiniBrowser.
416         https://bugs.webkit.org/show_bug.cgi?id=108067
417
418         Reviewed by Kenneth Rohde Christiansen.
419
420         Be explicit and include Ecore_Getopt.h since we use it for parsing
421         command line options. It is safer than relying on other headers
422         including it for us.
423
424         * MiniBrowser/efl/main.c:
425
426 2013-01-28  Renata Hodovan  <reni@webkit.org>
427
428         [WK2] Putting QtWebProcess into a chrooted sandbox
429         https://bugs.webkit.org/show_bug.cgi?id=90005
430
431         Reviewed by Anders Carlsson and  Zoltan Herczeg.
432
433         Add feature flag for suid sandbox in linux.
434
435         * Scripts/webkitperl/FeatureList.pm:
436
437 2013-01-27  David Farler  <dfarler@apple.com>
438
439         REGRESSION (r140912): Broke specifying non-trivial ARCHS value to make / build-webkit
440         https://bugs.webkit.org/show_bug.cgi?id=108028
441
442         Reviewed by Dan Bernstein.
443
444         * DumpRenderTree/Makefile: Reverted.
445         * Makefile: Reverted.
446         * Scripts/webkitdirs.pm: Reverted.
447
448 2013-01-27  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
449
450         Fixing atomicIncrement implementation for Windows by dropping support before XP SP2.
451         https://bugs.webkit.org/show_bug.cgi?id=106740
452
453         Reviewed by Benjamin Poulain.
454
455         * DumpRenderTree/config.h:
456         * WinLauncher/stdafx.h:
457
458 2013-01-26  David Farler  <dfarler@apple.com>
459
460         Makefiles should work for arbitrary SDKs and architectures on Apple ports
461         https://bugs.webkit.org/show_bug.cgi?id=107863
462
463         Reviewed by David Kilzer.
464
465         * Makefile:
466         Added temporary filters for projects not yet building on iOS.
467         * DumpRenderTree/Makefile:
468         Building with iOS SDKs -> -target All-iOS
469         * Scripts/webkitdirs.pm:
470         (determineConfiguration):
471         Added --configuration switch detection.
472         (determineArchitecture):
473         Added --architecture and ARCH=(.*) switch detection.
474         (argumentsForConfiguration):
475         (determineXcodeSDK):
476         Look for --device, --simulator, and --sdk switches.
477         (xcodeSDK):
478         Added.
479         (XcodeOptions):
480         Determine Xcode SDK and generate -arch switches.
481
482 2013-01-25  Jochen Eisinger  <jochen@chromium.org>
483
484         [chromium] move tracking of the top loading frame to TestRunner library
485         https://bugs.webkit.org/show_bug.cgi?id=107948
486
487         Reviewed by Adam Barth.
488
489         * DumpRenderTree/chromium/DRTTestRunner.cpp:
490         (DRTTestRunner::WorkQueue::processWorkSoon):
491         (DRTTestRunner::WorkQueue::processWork):
492         (DRTTestRunner::completeNotifyDone):
493         * DumpRenderTree/chromium/DRTTestRunner.h:
494         (DRTTestRunner):
495         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
496         (WebTestProxyBase):
497         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
498         (WebTestRunner::WebTestRunner::setTopLoadingFrame):
499         (WebTestRunner::WebTestRunner::topLoadingFrame):
500         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
501         (WebTestRunner::TestRunner::TestRunner):
502         (WebTestRunner::TestRunner::reset):
503         (WebTestRunner::TestRunner::setTopLoadingFrame):
504         (WebTestRunner):
505         (WebTestRunner::TestRunner::topLoadingFrame):
506         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
507         (TestRunner):
508         (WebTestRunner::TestRunner::locationChangeDone):
509         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
510         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
511         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
512         (WebTestRunner::WebTestProxyBase::didFailLoad):
513         (WebTestRunner::WebTestProxyBase::didFinishLoad):
514         (WebTestRunner::WebTestProxyBase::locationChangeDone):
515         (WebTestRunner):
516         * DumpRenderTree/chromium/WebViewHost.cpp:
517         (WebViewHost::reset):
518         (WebViewHost::updateURL):
519         * DumpRenderTree/chromium/WebViewHost.h:
520         (WebViewHost):
521
522 2013-01-25  Sheriff Bot  <webkit.review.bot@gmail.com>
523
524         Unreviewed, rolling out r140774.
525         http://trac.webkit.org/changeset/140774
526         https://bugs.webkit.org/show_bug.cgi?id=107932
527
528          Tests ScrollingCoordinatorChromiumTest.fastScrollingByDefault
529         and fastScrollingForFixedPosition are failing (Requested by
530         keishi on #webkit).
531
532         * DumpRenderTree/chromium/WebViewHost.cpp:
533         (WebViewHost::initializeLayerTreeView):
534         (WebViewHost::setWebWidget):
535
536 2013-01-25  Alan Cutter  <alancutter@chromium.org>
537
538         Quick fix for Chromium EWS bots running out of space due to a tmp file leak
539         https://bugs.webkit.org/show_bug.cgi?id=107905
540
541         Reviewed by Eric Seidel.
542
543         Added line to EWS loop to clear /tmp of known Chromium test leak.
544         Directories named ".org.chromium.Chromium.XXXXXX" not getting cleaned up.
545
546         * EWSTools/start-queue.sh:
547
548 2013-01-25  Ryosuke Niwa  <rniwa@webkit.org>
549
550         Update Anne's email address
551         https://bugs.webkit.org/show_bug.cgi?id=107866
552
553         Reviewed by Adam Barth.
554
555         * Scripts/webkitpy/common/config/committers.py:
556
557 2013-01-24  Alan Cutter  <alancutter@chromium.org>
558
559         HTTP 500 error between QueueStatusServer and bot(s)
560         https://bugs.webkit.org/show_bug.cgi?id=107184
561
562         Reviewed by Adam Barth.
563
564         Removed the use of memcache which was the source of the exception.
565
566         * QueueStatusServer/handlers/updatestatus.py:
567         (UpdateStatus.post):
568         * QueueStatusServer/model/attachment.py:
569         (Attachment):
570         (Attachment.summary):
571
572 2013-01-24  Sheriff Bot  <webkit.review.bot@gmail.com>
573
574         Unreviewed, rolling out r140653.
575         http://trac.webkit.org/changeset/140653
576         https://bugs.webkit.org/show_bug.cgi?id=107916
577
578         Causes a temp file leak on the bots (Requested by abarth on
579         #webkit).
580
581         * DumpRenderTree/chromium/TestShell.cpp:
582         (TestShell::resetTestController):
583
584 2013-01-24  Eric Seidel  <eric@webkit.org>
585
586         Skip haslanded_unittest.py on systems which do not have interdiff installed
587         https://bugs.webkit.org/show_bug.cgi?id=106402
588
589         Unreviewed.
590
591         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
592         (HasLandedTest):
593
594 2013-01-24  Ryosuke Niwa  <rniwa@webkit.org>
595
596         Disable the failing webkitpy test for now.
597
598         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
599
600 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
601
602         Fixing the diff_parser to correctly identify git diffs even with leading comments.
603         https://bugs.webkit.org/show_bug.cgi?id=107871
604
605         Reviewed by Eric Seidel.
606
607         * Scripts/webkitpy/common/checkout/diff_parser.py:
608         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
609         * Scripts/webkitpy/tool/steps/haslanded.py:
610
611 2013-01-24  James Robinson  <jamesr@chromium.org>
612
613         [chromium] Remove dead transitional code from WebViewImpl
614         https://bugs.webkit.org/show_bug.cgi?id=107889
615
616         Reviewed by Adrienne Walker.
617
618         * DumpRenderTree/chromium/WebViewHost.cpp:
619         (WebViewHost::initializeLayerTreeView):
620         (WebViewHost::setWebWidget):
621
622 2013-01-24  Joshua Bell  <jsbell@chromium.org>
623
624         Add watchlist for IndexedDB development, and add myself and others.
625
626         Unreviewed.
627
628         * Scripts/webkitpy/common/config/watchlist:
629
630 2013-01-24  Martin Robinson  <mrobinson@igalia.com>
631
632         Abstract the logic for appending a UChar32 onto StringBuilder
633         https://bugs.webkit.org/show_bug.cgi?id=107505
634
635         Reviewed by Darin Adler.
636
637         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
638         (TestWebKitAPI::TEST): Added a simple test for appending UChar32.
639
640 2013-01-24  Erik Arvidsson  <arv@chromium.org>
641
642         Unreviewed, rolling out r140703.
643         http://trac.webkit.org/changeset/140703
644         https://bugs.webkit.org/show_bug.cgi?id=107556
645
646         r140561 was not the reason for the Android breakage
647
648         * DumpRenderTree/chromium/TestShell.cpp:
649         (TestShell::~TestShell):
650         (TestShell::closeWindow):
651         * DumpRenderTree/chromium/WebViewHost.cpp:
652         (WebViewHost::WebViewHost):
653         (WebViewHost::~WebViewHost):
654         (WebViewHost::shutdown):
655         * DumpRenderTree/chromium/WebViewHost.h:
656         (WebViewHost):
657
658 2013-01-24  Dean Jackson  <dino@apple.com>
659
660         Allow some plugin snapshot UI content to come from Injected Bundle
661         https://bugs.webkit.org/show_bug.cgi?id=107852
662
663         Reviewed by Anders Carlsson.
664
665         Null implementations of plugInStartLabelTitle, plugInStartLabelSubtitle and
666         plugInExtraStyleSheet.
667
668         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
669         (WTR::InjectedBundlePage::InjectedBundlePage):
670
671 2013-01-24  Erik Arvidsson  <arv@chromium.org>
672
673         Unreviewed, rolling out r140561.
674         http://trac.webkit.org/changeset/140561
675         https://bugs.webkit.org/show_bug.cgi?id=107556
676
677         Suspected to break Android which prevens WebKit roll
678
679         * DumpRenderTree/chromium/TestShell.cpp:
680         (TestShell::~TestShell):
681         (TestShell::closeWindow):
682         * DumpRenderTree/chromium/WebViewHost.cpp:
683         (WebViewHost::WebViewHost):
684         (WebViewHost::~WebViewHost):
685         * DumpRenderTree/chromium/WebViewHost.h:
686         (WebViewHost):
687
688 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
689
690         Adding "has-landed" command to webkit-patch which compares a
691         committed patch to the changes which exist locally (ignoring the
692         ChangeLog file).
693
694         https://bugs.webkit.org/show_bug.cgi?id=106402
695
696         Reviewed by Eric Seidel.
697
698         * Scripts/webkitpy/common/checkout/diff_parser.py:
699         (git_diff_to_svn_diff):
700         * Scripts/webkitpy/common/net/bugzilla/bug.py:
701         (Bug.commit_revision):
702         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
703         (BugTest.test_is_in_comments):
704         (BugTest):
705         (BugTest.test_commit_revision):
706         * Scripts/webkitpy/tool/commands/upload.py:
707         (HasLanded):
708         * Scripts/webkitpy/tool/steps/__init__.py:
709         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
710         (HasLanded):
711         (HasLanded.convert_to_svn):
712         (HasLanded.strip_change_log):
713         (run):
714
715         * Scripts/webkitpy/common/net/bugzilla/bug.py:
716         (Bug.commit_revision):
717         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
718         (BugTest.test_is_in_comments):
719         (BugTest):
720         (BugTest.test_commit_revision):
721         * Scripts/webkitpy/tool/commands/upload.py:
722         (HasLanded):
723         * Scripts/webkitpy/tool/steps/__init__.py:
724         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
725         (HasLanded):
726         (HasLanded.convert_to_svn):
727         (HasLanded.strip_change_log):
728         (HasLanded.diff_diff):
729         (HasLanded.run):
730         * Scripts/webkitpy/tool/steps/haslanded_unittest.py: Added.
731         (HasLandedTest):
732         (HasLandedTest.test_run):
733         (test_convert_to_svn_and_strip_change_log):
734
735 2013-01-24  Dan Carney  <dcarney@google.com>
736
737         [chromium] move most WebViewHost printf calls to WebTestProxy
738         https://bugs.webkit.org/show_bug.cgi?id=107553
739
740         Reviewed by Jochen Eisinger.
741
742         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
743         (WebKit):
744         (WebTestProxyBase):
745         (WebTestRunner::WebTestProxy::unableToImplementPolicyWithError):
746         (WebTestRunner::WebTestProxy::didAddMessageToConsole):
747         (WebTestRunner::WebTestProxy::runModalAlertDialog):
748         (WebTestRunner::WebTestProxy::runModalConfirmDialog):
749         (WebTestRunner::WebTestProxy::runModalPromptDialog):
750         (WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):
751         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
752         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
753         (WebTestRunner::WebTestProxyBase::reset):
754         (WebTestRunner::WebTestProxyBase::setLogConsoleOutput):
755         (WebTestRunner):
756         (WebTestRunner::WebTestProxyBase::unableToImplementPolicyWithError):
757         (WebTestRunner::WebTestProxyBase::didAddMessageToConsole):
758         (WebTestRunner::WebTestProxyBase::runModalAlertDialog):
759         (WebTestRunner::WebTestProxyBase::runModalConfirmDialog):
760         (WebTestRunner::WebTestProxyBase::runModalPromptDialog):
761         (WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
762         * DumpRenderTree/chromium/TestShell.cpp:
763         (TestShell::showDevTools):
764         * DumpRenderTree/chromium/WebViewHost.cpp:
765         (WebViewHost::didAddMessageToConsole):
766         (WebViewHost::runModalAlertDialog):
767         (WebViewHost::runModalConfirmDialog):
768         (WebViewHost::runModalPromptDialog):
769         (WebViewHost::runModalBeforeUnloadDialog):
770         (WebViewHost::unableToImplementPolicyWithError):
771         (WebViewHost::reset):
772         * DumpRenderTree/chromium/WebViewHost.h:
773         (WebViewHost):
774
775 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
776
777         [Chromium] Give webkit_support a chance to reset state between layout test runs
778         https://bugs.webkit.org/show_bug.cgi?id=107132
779
780         Reviewed by Adam Barth.
781
782         We currently only have need for this on OS(ANDROID), but now it
783         would be useful to have a hook for resetting state on all
784         platforms. Will soon be using this for IDBFactory initialization.
785
786         * DumpRenderTree/chromium/TestShell.cpp:
787         (TestShell::resetTestController): Call webkit_support::ResetTestEnvironment()
788
789 2013-01-23  Alan Cutter  <alancutter@chromium.org>
790
791         QueueStatusServer crashes in production on next-patch
792         https://bugs.webkit.org/show_bug.cgi?id=107775
793
794         Reviewed by Adam Barth.
795
796         Replaced Python 2.5 incompatible call to timedelta.total_seconds().
797
798         * QueueStatusServer/app.yaml:
799         * QueueStatusServer/model/patchlog.py:
800         (PatchLog.calculate_wait_duration):
801         (PatchLog.calculate_process_duration):
802         (PatchLog):
803         (PatchLog._time_delta_to_seconds):
804
805 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
806
807         The previous patch wasn't complete. Finish reverting r139998 for real.
808
809         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
810         (ProfilerAgent.getProfile):
811
812 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
813
814         Revert r139998 for now since the Leaks Viewer pulls in a specific version of Inspector code.
815
816         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
817         (ProfilerAgent.getProfile):
818
819 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
820
821         [Chromium] Remove unused header files in chromium/public/platform/
822         https://bugs.webkit.org/show_bug.cgi?id=107741
823
824         Reviewed by James Robinson.
825
826         These header files have migrated to the new Platform directory.
827         This patch updates the remaining #include references and removes
828         the old files that did nothing but redirect to the new ones.
829
830         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
831         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
832
833 2013-01-23  Martin Robinson  <mrobinson@igalia.com>
834
835         [GTK] Bump webkitgtk-test-fonts dependency to cover fallbacks for Tamil, Bengali, and others
836         https://bugs.webkit.org/show_bug.cgi?id=107727
837
838         Reviewed by Gustavo Noronha Silva.
839
840         * gtk/jhbuild.modules: Update the JHBuild moduleset to point to the new webkitgtk-test-fonts.
841         We are using the git repository now that github has deprecated the downloads feature.
842
843 2013-01-23  Tony Chang  <tony@chromium.org>
844
845         Unreviewed, set svn:eol-style to CRLF on Windows .sln files.
846
847         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
848         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
849         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
850         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
851
852 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
853
854         [Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory
855         https://bugs.webkit.org/show_bug.cgi?id=107145
856
857         Reviewed by Adam Barth.
858
859         Part of a larger refactoring series; see tracking bug 82948.
860         
861         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
862         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
863         * DumpRenderTree/chromium/DRTDevToolsClient.h:
864         * DumpRenderTree/chromium/DRTTestRunner.cpp:
865         * DumpRenderTree/chromium/DRTTestRunner.h:
866         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h:
867         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
868         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
869         * DumpRenderTree/chromium/NotificationPresenter.cpp:
870         * DumpRenderTree/chromium/TestNavigationController.h:
871         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
872         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
873         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
874         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
875         (WebTestRunner):
876         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
877         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
878         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
879         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
880         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
881         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
882         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
883         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
884         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
885         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
886         * DumpRenderTree/chromium/TestShell.cpp:
887         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
888         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
889         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
890         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
891         * DumpRenderTree/chromium/WebViewHost.cpp:
892
893 2013-01-23  Jochen Eisinger  <jochen@chromium.org>
894
895         [chromium] Use after free in plugins/geturlnotify-during-document-teardown.html
896         https://bugs.webkit.org/show_bug.cgi?id=107556
897
898         Reviewed by Tony Chang.
899
900         WebViewHost initiates a navigation to about:blank in its destructor.
901         However, since WebTestProxy inherits from WebViewHost, at this point
902         the WebViewClient and WebFrameClient interfaces are already partially
903         destructed resulting in the use after free.
904
905         This does not affect the chromium implementation since it doesn't
906         invoke WebKit API methods in its destructor.
907
908         * DumpRenderTree/chromium/TestShell.cpp:
909         (TestShell::~TestShell):
910         (TestShell::closeWindow):
911         * DumpRenderTree/chromium/WebViewHost.cpp:
912         (WebViewHost::WebViewHost):
913         (WebViewHost::~WebViewHost):
914         (WebViewHost::shutdown):
915         * DumpRenderTree/chromium/WebViewHost.h:
916         (WebViewHost):
917
918 2013-01-23  Andrei Bucur  <abucur@adobe.com>
919
920         [CSS Regions] Create Regions watchlist
921         https://bugs.webkit.org/show_bug.cgi?id=107281
922
923         Reviewed by Adam Barth.
924
925         This patch adds 4 new definitions:
926         - RegionsDevelopment - used to track the development progress for regions
927         - RegionsExpectationsMore and RegionsExpectationsLess - used to track expectations changes for the regions tests
928         - RegionsUsage - used to track changes that make use of regions in all the code base
929
930         For now, the Adobe internal tracker is the only email address listening for these patterns.
931
932         * Scripts/webkitpy/common/config/watchlist:
933
934 2013-01-22  Pavel Feldman  <pfeldman@chromium.org>
935
936         Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
937         https://bugs.webkit.org/show_bug.cgi?id=107523
938
939         Reviewed by Yury Semikhatsky.
940
941         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
942         (DRTDevToolsClient::isUnderTest):
943         (DRTDevToolsClient::call):
944         * DumpRenderTree/chromium/DRTDevToolsClient.h:
945         (DRTDevToolsClient):
946
947 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
948
949         Removing command line shortening as it makes it difficult to see the command during errors.
950         https://bugs.webkit.org/show_bug.cgi?id=107643
951
952         Reviewed by Eric Seidel.
953
954         * Scripts/webkitpy/common/system/executive.py:
955         (ScriptError):
956         (ScriptError.__init__):
957         * Scripts/webkitpy/common/system/executive_unittest.py:
958
959 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
960
961         Adding myself as contributor in committers.py (as requested by eseidel).
962         https://bugs.webkit.org/show_bug.cgi?id=107647
963
964         Reviewed by Eric Seidel.
965
966         * Scripts/webkitpy/common/config/committers.py:
967
968 2013-01-22  Alan Cutter  <alancutter@chromium.org>
969
970         Add monitoring of patches and queues to the QueueStatusServer
971         https://bugs.webkit.org/show_bug.cgi?id=107612
972
973         Reviewed by Adam Barth.
974
975         Created classes for recording events into the datastore and integrated them into the existing handlers.
976         Code for presenting the recorded data will come in a separate patch.
977
978         * QueueStatusServer/app.yaml:
979         * QueueStatusServer/config/__init__.py: Added.
980         * QueueStatusServer/config/logging.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
981         * QueueStatusServer/config/messages.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
982         * QueueStatusServer/handlers/nextpatch.py:
983         (NextPatch.get):
984         (NextPatch._assign_patch):
985         * QueueStatusServer/handlers/releasepatch.py:
986         (ReleasePatch.post):
987         * QueueStatusServer/handlers/updatestatus.py:
988         (UpdateStatus.post):
989         * QueueStatusServer/handlers/updateworkitems.py:
990         (UpdateWorkItems._parse_work_items_string):
991         (UpdateWorkItems):
992         (UpdateWorkItems._update_work_items_from_request):
993         (UpdateWorkItems._queue_from_request):
994         (UpdateWorkItems.post):
995         * QueueStatusServer/loggers/__init__.py: Added.
996         * QueueStatusServer/loggers/recordbotevent.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
997         (RecordBotEvent):
998         (RecordBotEvent.activity):
999         * QueueStatusServer/loggers/recordpatchevent.py: Added.
1000         (RecordPatchEvent):
1001         (RecordPatchEvent.added):
1002         (RecordPatchEvent.retrying):
1003         (RecordPatchEvent.started):
1004         (RecordPatchEvent.stopped):
1005         (RecordPatchEvent.updated):
1006         (RecordPatchEvent._get_patches_waiting):
1007         * QueueStatusServer/model/patchlog.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
1008         (PatchLog):
1009         (PatchLog.lookup):
1010         (PatchLog.calculate_wait_duration):
1011         (PatchLog.calculate_process_duration):
1012         * QueueStatusServer/model/queuelog.py: Copied from Tools/QueueStatusServer/handlers/nextpatch.py.
1013         (QueueLog):
1014         (QueueLog.get_current):
1015         (QueueLog.create_key):
1016         * QueueStatusServer/model/queuestatus.py:
1017         (QueueStatus.is_retry_request):
1018
1019 2013-01-22  Timothy Loh  <timloh@chromium.com>
1020
1021         prepare-Changelog should support updating the list of changed files
1022         https://bugs.webkit.org/show_bug.cgi?id=74358
1023
1024         Reviewed by Eric Seidel.
1025
1026         Needing to re-make ChangeLog entries when the list of files/functions
1027         changes is a bit annoying, it'd be nice to have this more automated.
1028         This patch makes `webkit-patch update' update the date line and bug
1029         description if needed, and if the list of changed files/functions has
1030         changed, either updates the list (if there are no annotations), or
1031         otherwise appends the new list below.
1032
1033         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1034         (PrepareChangeLog._resolve_existing_entry):
1035         (PrepareChangeLog):
1036         (PrepareChangeLog._merge_entries):
1037         (PrepareChangeLog.run):
1038         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1039         (PrepareChangeLogTest.test_resolve_existing_entry):
1040         (make_entry):
1041         (test_ensure_bug_url):
1042
1043 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
1044
1045         Use Python 2.7 unittest syntax in our unittests
1046         https://bugs.webkit.org/show_bug.cgi?id=105607
1047
1048         Reviewed by Eric Seidel.
1049
1050         * Scripts/webkitpy/**/*_unittest.py:
1051
1052 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
1053
1054         Convert disable-msg to disable for new pylint.
1055         https://bugs.webkit.org/show_bug.cgi?id=107627
1056
1057         Reviewed by Eric Seidel.
1058
1059         * Scripts/webkitpy/common/checkout/scm/svn.py:
1060         (SVNRepository.has_authorization_for_realm):
1061         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1062         (Builder.force_build):
1063         * Scripts/webkitpy/common/system/executive_mock.py:
1064         (MockExecutive2.run_command):
1065         * Scripts/webkitpy/layout_tests/port/base.py:
1066         (Port.reference_files):
1067         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
1068         (ChromiumPortTestCase.test_default_configuration):
1069         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1070         (PortTestCase.test_expectations_ordering):
1071         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1072         (HttpServerBase._check_that_all_ports_are_available):
1073         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
1074         (AbstractLocalServerCommand.execute):
1075         * Scripts/webkitpy/tool/commands/download.py:
1076         (AbstractPatchProcessingCommand):
1077         * Scripts/webkitpy/tool/commands/rebaseline.py:
1078         (AbstractRebaseliningCommand):
1079         (AbstractParallelRebaselineCommand):
1080         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1081         (_BaseTestCase.setUp):
1082         (TestAnalyzeBaselines.setUp):
1083
1084 2013-01-22  Frank Farzan  <frankf@chromium.org>
1085
1086         Flakiness dashboard: update builders.jsonp
1087         https://bugs.webkit.org/show_bug.cgi?id=107610
1088
1089         Reviewed by Ojan Vafai.
1090
1091         * TestResultServer/static-dashboards/builders.jsonp:
1092
1093 2013-01-22  Frank Farzan  <frankf@chromium.org>
1094
1095         Add Android instrumentation tests from ChromiumLinux waterfall
1096         https://bugs.webkit.org/show_bug.cgi?id=107597
1097
1098         Reviewed by Ojan Vafai.
1099
1100         * TestResultServer/static-dashboards/builders.js:
1101         (loadBuildersList):
1102
1103 2013-01-21  Kentaro Hara  <haraken@chromium.org>
1104
1105         Implement UIEvent constructor
1106         https://bugs.webkit.org/show_bug.cgi?id=107430
1107
1108         Reviewed by Adam Barth.
1109
1110         Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
1111
1112         UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag,
1113         which is enabled on Safari and Chromium for now.
1114
1115         * Scripts/webkitperl/FeatureList.pm:
1116
1117 2013-01-22  Timothy Loh  <timloh@chromium.com>
1118
1119         Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries
1120         https://bugs.webkit.org/show_bug.cgi?id=107478
1121
1122         Reviewed by Eric Seidel.
1123
1124         On the road to resolving Bug 74358, we need a few more functions in
1125         changelog.py.
1126         To make things easier to mock, change @staticmethods to @classmethods.
1127
1128         * Scripts/webkitpy/common/checkout/changelog.py:
1129         (ChangeLogEntry):
1130         (ChangeLogEntry._parse_reviewer_text):
1131         (ChangeLogEntry._split_contributor_names):
1132         (ChangeLogEntry._parse_author_name_and_email):
1133         (ChangeLogEntry._parse_author_text):
1134         (ChangeLogEntry._parse_touched_functions):
1135         (ChangeLogEntry._parse_bug_description):
1136         (ChangeLogEntry._parse_entry):
1137         (ChangeLogEntry.date_line):
1138         (ChangeLogEntry.bug_description):
1139         (ChangeLogEntry.touched_functions):
1140         (ChangeLogEntry.touched_files_text):
1141         (ChangeLogEntry.is_touched_files_text_clean):
1142         (ChangeLog):
1143         (ChangeLog.parse_latest_entry_from_file):
1144         (ChangeLog._separate_revision_and_line):
1145         (ChangeLog.parse_entries_from_file):
1146         (ChangeLog.set_short_description_and_bug_url):
1147         (ChangeLog.delete_entries):
1148         (ChangeLog.prepend_text):
1149         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1150         (test_parse_log_entries_from_changelog):
1151         (test_latest_entry_parse):
1152         (test_set_short_description_and_bug_url):
1153         (test_delete_entries):
1154         (test_prepend_text):
1155
1156 2013-01-22  Lucas Forschler  <lforschler@apple.com>
1157
1158         Create a MAC EWS startup shell script.
1159
1160         Reviewed by Ryosuke Niwa.
1161
1162         * EWSTools/start-queue-mac.sh: Added.
1163
1164 2013-01-22  Joseph Pecoraro  <pecoraro@apple.com>
1165
1166         [Mac] Enable Page Visibility (PAGE_VISIBILITY_API)
1167         https://bugs.webkit.org/show_bug.cgi?id=107230
1168
1169         Reviewed by David Kilzer.
1170
1171         * DumpRenderTree/mac/TestRunnerMac.mm:
1172         (TestRunner::resetPageVisibility):
1173         Fix a typo in the original implementation. resetPageVisibility should
1174         pass initialState YES so an event is not dispatched, which causes
1175         issues in multiple tests. This now matches other ports.
1176
1177 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
1178
1179         [GTK] Enable CSS Image Orientation feature
1180         https://bugs.webkit.org/show_bug.cgi?id=99040
1181
1182         Reviewed by Martin Robinson.
1183
1184         Enable the CSS Image Orientation feature in the development
1185         builds of the GTK port. The feature is still disabled in the release
1186         builds.
1187
1188         * Scripts/webkitperl/FeatureList.pm:
1189
1190 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
1191
1192         [GTK] Enable the <template> element support in development builds
1193         https://bugs.webkit.org/show_bug.cgi?id=106575
1194
1195         Reviewed by Martin Robinson.
1196
1197         Enable the <template> element support in the development builds of the GTK port.
1198
1199         * Scripts/webkitperl/FeatureList.pm:
1200
1201 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
1202
1203         Prettify the output of the override-feature-defines script
1204         https://bugs.webkit.org/show_bug.cgi?id=106542
1205
1206         Reviewed by Martin Robinson.
1207
1208         The output now clearly lists the feature defines being overridden
1209         along with the default and overriding values for each feature define.
1210
1211         * gtk/override-feature-defines:
1212         (adjust_feature_defines_makefile):
1213         (adjust_feature_defines_makefile.override_feature_define):
1214
1215 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
1216
1217         Remove uses of deprecated unittest.TestCase aliases
1218         https://bugs.webkit.org/show_bug.cgi?id=102252
1219
1220         Reviewed by Adam Barth.
1221
1222         Replace the deprecated assertEquals method of the TestCase interface
1223         used in some webkitpy unittests with the assertEqual method.
1224
1225         * Scripts/webkitpy/common/system/profiler_unittest.py:
1226         (ProfilerFactoryTest._assert_default_profiler_name):
1227         (ProfilerFactoryTest.test_default_profiler_output):
1228         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1229         (GtkPortTest.test_expectations_files):
1230         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1231         (TestHttpServer.test_win32_start_and_stop):
1232
1233 2013-01-22  Jer Noble  <jer.noble@apple.com>
1234
1235         REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
1236         https://bugs.webkit.org/show_bug.cgi?id=107562
1237
1238         Rubber-stamped by Alexy Proskuryakov.
1239
1240         The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.
1241
1242         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1243         (WTR::PlatformWebView::PlatformWebView):
1244         (WTR::PlatformWebView::viewSupportsOptions):
1245
1246 2013-01-22  Alexey Proskuryakov  <ap@apple.com>
1247
1248         One is not allowed to use commit-queue to make oneself a committer.
1249
1250         * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.
1251
1252 2013-01-22  Eugene Klyuchnikov  <eustas@chromium.org>
1253
1254         Add myself to commiters.py
1255         https://bugs.webkit.org/show_bug.cgi?id=107546
1256
1257         Reviewed by Kentaro Hara.
1258
1259         * Scripts/webkitpy/common/config/committers.py:
1260
1261 2013-01-22  Manuel Rego Casasnovas  <rego@igalia.com>
1262
1263         [GTK] Implement TestRunner::setTextDirection
1264         https://bugs.webkit.org/show_bug.cgi?id=107131
1265
1266         Reviewed by Philippe Normand.
1267
1268         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1269         (resetDefaultsToConsistentValues): Reset direction to default value.
1270         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1271         (TestRunner::setTextDirection): Implement method using
1272         gtk_widget_set_direction.
1273
1274 2013-01-22  Jochen Eisinger  <jochen@chromium.org>
1275
1276         [chromium] move spell checking mocks to TestRunner library
1277         https://bugs.webkit.org/show_bug.cgi?id=107455
1278
1279         Reviewed by Kent Tamura.
1280
1281         The content module doesn't provide its own WebSpellCheckClient.
1282
1283         * DumpRenderTree/DumpRenderTree.gypi:
1284         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1285         (WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
1286         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1287         (WebKit):
1288         (WebTestRunner):
1289         (WebTestProxyBase):
1290         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1291         (WebTestRunner):
1292         (WebTestRunner::makeMenuItemStringsFor):
1293         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
1294         (MockGrammarCheck::checkGrammarOfString):
1295         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
1296         (WebKit):
1297         (MockGrammarCheck):
1298         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
1299         (MockSpellCheck::MockSpellCheck):
1300         (MockSpellCheck::~MockSpellCheck):
1301         (isNotASCIIAlpha):
1302         (MockSpellCheck::spellCheckWord):
1303         (MockSpellCheck::fillSuggestionList):
1304         (MockSpellCheck::initializeIfNeeded):
1305         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
1306         (MockSpellCheck):
1307         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
1308         (WebTestRunner::SpellCheckClient::SpellCheckClient):
1309         (WebTestRunner):
1310         (WebTestRunner::SpellCheckClient::~SpellCheckClient):
1311         (WebTestRunner::SpellCheckClient::setDelegate):
1312         (WebTestRunner::SpellCheckClient::spellCheck):
1313         (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
1314         (WebTestRunner::SpellCheckClient::requestCheckingOfText):
1315         (WebTestRunner::SpellCheckClient::finishLastTextCheck):
1316         (WebTestRunner::SpellCheckClient::autoCorrectWord):
1317         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
1318         (WebTestRunner):
1319         (SpellCheckClient):
1320         (WebTestRunner::SpellCheckClient::taskList):
1321         (WebTestRunner::SpellCheckClient::mockSpellCheck):
1322         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
1323         (TestDelegate):
1324         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1325         (WebTestInterfaces::Internal):
1326         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1327         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
1328         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
1329         (WebTestRunner::WebTestProxyBase::setDelegate):
1330         (WebTestRunner::WebTestProxyBase::spellCheckClient):
1331         (WebTestRunner):
1332         * DumpRenderTree/chromium/WebViewHost.cpp:
1333         (WebViewHost::WebViewHost):
1334         (WebViewHost::setWebWidget):
1335         * DumpRenderTree/chromium/WebViewHost.h:
1336         (WebViewHost):
1337
1338 2013-01-22  Krzysztof Czech  <k.czech@samsung.com>
1339
1340         [EFL] Adds Accessibility support to wk1
1341         https://bugs.webkit.org/show_bug.cgi?id=107440
1342
1343         Reviewed by Gyuyoung Kim.
1344
1345         * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.
1346
1347 2013-01-21  Joseph Pecoraro  <pecoraro@apple.com>
1348
1349         [Mac] WK1 MiniBrowser should clear delegates before releasing webview
1350         https://bugs.webkit.org/show_bug.cgi?id=107506
1351
1352         Reviewed by Dan Bernstein.
1353
1354         * MiniBrowser/mac/WK1BrowserWindowController.m:
1355         (-[WK1BrowserWindowController dealloc]):
1356
1357 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
1358
1359         Add build flag for Canvas's Path object (disabled by default)
1360         https://bugs.webkit.org/show_bug.cgi?id=107473
1361
1362         Reviewed by Dean Jackson.
1363
1364         Add CANVAS_PATH build flag to build systems.
1365
1366         * Scripts/webkitperl/FeatureList.pm:
1367
1368 2013-01-21  Jinwoo Song  <jinwoo7.song@samsung.com>
1369
1370         [EFL][WK2] Add APIs to set/get view source mode
1371         https://bugs.webkit.org/show_bug.cgi?id=106633
1372
1373         Reviewed by Gyuyoung Kim.
1374
1375         Added a shotcut 'F8' in Minibrowser to display a source code
1376         of the web page in a new window.
1377
1378        * MiniBrowser/efl/main.c:
1379         (on_key_down):
1380         (on_window_create):
1381         (window_create):
1382         (elm_main):
1383
1384 2013-01-21  Nico Weber  <thakis@chromium.org>
1385
1386         [chromium] Don't archive generated source files.
1387         https://bugs.webkit.org/show_bug.cgi?id=106736
1388
1389         Reviewed by Eric Seidel.
1390
1391         They shouldn't be needed to run tests. They don't need a lot of space,
1392         but add many lines to the "extracting" stdout. This attempts to reduce
1393         that noise a bit.
1394
1395         * BuildSlaveSupport/built-product-archive:
1396         (archiveBuiltProduct):
1397
1398 2013-01-21  Benjamin Poulain  <benjamin@webkit.org>
1399
1400         Mac DumpRenderTree's installSignalHandlers() is unreachable code
1401         https://bugs.webkit.org/show_bug.cgi?id=107383
1402
1403         Reviewed by Sam Weinig.
1404
1405         The CrashHandler of DumpRenderTree were originally used for restoring
1406         the color profile of the main display even if DRT crashes.
1407
1408         That feature was later limited to pixel tests only in r29999.
1409
1410         In r104351, the DRT was changed to use device color space. Making the crash
1411         handlers useless, but they were left in the code since the error reporting
1412         code was still reachable.
1413
1414         Later, r124581 refactored the code and dumpPixelsForCurrentTest
1415         is being used before being assigned its value.
1416         This did cause any regression because the code had become useless with the previous change.
1417
1418         * DumpRenderTree/mac/DumpRenderTree.mm:
1419         Remove crashHandler() and installSignalHandlers() as they have become useless and
1420         have been unreachable code for 6 months.
1421         (dumpRenderTree):
1422         Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
1423         at those points.
1424
1425 2013-01-21  Nico Weber  <thakis@chromium.org>
1426
1427         Make ninja the default build system for build-webkit --chromium on mac
1428         https://bugs.webkit.org/show_bug.cgi?id=106737
1429
1430         Reviewed by Eric Seidel.
1431
1432         * Scripts/update-webkit-chromium:
1433
1434 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
1435
1436         Regression(r140262): Causes a lot of flakiness
1437         https://bugs.webkit.org/show_bug.cgi?id=107454
1438
1439         Reviewed by Alexey Proskuryakov.
1440
1441         r140262 introduced a lot of flakiness due to fixed layout mode
1442         not getting disabled on the view after being enabled for
1443         specific test cases. This patch makes sure fixed layout mode
1444         properly gets reset in WebKitTestRunner to avoid flakiness.
1445
1446         * WebKitTestRunner/TestInvocation.cpp:
1447         (WTR::updateLayoutType):
1448
1449 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
1450
1451         REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
1452         https://bugs.webkit.org/show_bug.cgi?id=107421
1453
1454         Unreviewed build fix.
1455
1456         * Scripts/run-gtk-tests:
1457         (TestRunner): skip Resource tests.
1458
1459 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
1460
1461         [EFL][WKTR] platformRunUntil() should keep the main loop running
1462         https://bugs.webkit.org/show_bug.cgi?id=107442
1463
1464         Reviewed by Noam Rosenthal.
1465
1466         EFL's implementation of platformRunUntil() should keep the main loop
1467         running and avoid calling sleep() between calls to
1468         ecore_main_loop_iterate(). This call to sleep seems to be a source
1469         of deadlocks (see Bug 106884).
1470
1471         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1472         (WTR::TestController::platformRunUntil):
1473
1474 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
1475
1476         QtTestBrowser should provide way to clear selected elements
1477         https://bugs.webkit.org/show_bug.cgi?id=107437
1478
1479         Reviewed by Simon Hausmann.
1480
1481         Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
1482         Invoke the clearSelection prior to highlighting new elements.
1483
1484         * QtTestBrowser/launcherwindow.cpp:
1485         (ElementHighlight):
1486         (LauncherWindow::createChrome):
1487         (LauncherWindow::selectElements):
1488         (LauncherWindow::clearSelection):
1489         * QtTestBrowser/launcherwindow.h:
1490         (LauncherWindow):
1491
1492 2013-01-21  Jochen Eisinger  <jochen@chromium.org>
1493
1494         [chromium] move methods interacting with willSendRequest to TestRunner
1495         https://bugs.webkit.org/show_bug.cgi?id=107270
1496
1497         Reviewed by Kent Tamura.
1498
1499         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1500         (DRTTestRunner::DRTTestRunner):
1501         (DRTTestRunner::waitForPolicyDelegate):
1502         * DumpRenderTree/chromium/DRTTestRunner.h:
1503         (DRTTestRunner):
1504         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1505         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1506         (WebTestRunner::WebTestRunner::httpHeadersToClear):
1507         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
1508         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
1509         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1510         (WebTestRunner::TestRunner::TestRunner):
1511         (WebTestRunner::TestRunner::reset):
1512         (WebTestRunner::TestRunner::httpHeadersToClear):
1513         (WebTestRunner):
1514         (WebTestRunner::TestRunner::shouldBlockRedirects):
1515         (WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
1516         (WebTestRunner::TestRunner::setWillSendRequestClearHeader):
1517         (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1518         (WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
1519         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1520         (TestRunner):
1521         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1522         (WebTestRunner::WebTestProxyBase::willSendRequest):
1523         * DumpRenderTree/chromium/WebViewHost.cpp:
1524         (WebViewHost::willSendRequest):
1525         (WebViewHost::reset):
1526         * DumpRenderTree/chromium/WebViewHost.h:
1527         (WebViewHost):
1528
1529 2013-01-21  Zan Dobersek  <zdobersek@igalia.com>
1530
1531         [GTK] Stop building WebKit2 on GTK EWSs
1532         https://bugs.webkit.org/show_bug.cgi?id=107435
1533
1534         Reviewed by Philippe Normand.
1535
1536         The WebKit2 build of the GTK is at the moment not efficiently maintainable,
1537         so stop building it on GTK EWSs.
1538
1539         * Scripts/webkitpy/common/config/ports.py:
1540         (GtkPort.build_webkit_command):
1541         * Scripts/webkitpy/common/config/ports_unittest.py:
1542         (DeprecatedPortTest.test_gtk_port):
1543
1544 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
1545
1546         MediaStream API: Update the RTCPeerConnection states to match the latest specification
1547         https://bugs.webkit.org/show_bug.cgi?id=107120
1548
1549         Reviewed by Adam Barth.
1550
1551         Updating mock to use the new states.
1552
1553         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1554         (RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
1555         (MockWebRTCPeerConnectionHandler::initialize):
1556         (MockWebRTCPeerConnectionHandler::updateICE):
1557
1558 2013-01-20  Tim 'mithro' Ansell  <mithro@mithis.com>
1559
1560         Extend diff_parser to support the --full-index output.
1561         https://bugs.webkit.org/show_bug.cgi?id=107408
1562
1563         Reviewed by Maciej Stachowiak.
1564
1565         * Scripts/webkitpy/common/checkout/diff_parser.py:
1566         (git_diff_to_svn_diff):
1567         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1568         (DiffParserTest):
1569         (DiffParserTest.test_git_diff_to_svn_diff):
1570         (git_diff_to_svn_diff):
1571
1572 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
1573
1574         Dragging over an element with scrollbars should scroll the element when dragging near edges
1575         https://bugs.webkit.org/show_bug.cgi?id=39725
1576
1577         Reviewed by Hajime Morita.
1578
1579         This patch introduces canceling drag-and-drop by escape key for testing
1580         behavior after cancellation drag-and-drop.
1581
1582         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1583         (WebTestRunner):
1584         (WebTestRunner::EventSender::doMouseUp):
1585         (WebTestRunner::EventSender::finishDragAndDrop):
1586         (WebTestRunner::EventSender::keyDown):
1587         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
1588         (EventSender):
1589         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
1590
1591 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1592
1593         [chromium] move frame generation related methods to TestRunner
1594         https://bugs.webkit.org/show_bug.cgi?id=107268
1595
1596         Reviewed by Adam Barth.
1597
1598         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1599         (DRTTestRunner::DRTTestRunner):
1600         (DRTTestRunner::setWillSendRequestReturnsNull):
1601         * DumpRenderTree/chromium/DRTTestRunner.h:
1602         (DRTTestRunner):
1603         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1604         (WebTestRunner::WebTestDelegate::display):
1605         (WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
1606         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1607         (WebTestRunner::TestRunner::TestRunner):
1608         (WebTestRunner::TestRunner::display):
1609         (WebTestRunner):
1610         (WebTestRunner::TestRunner::displayInvalidatedRegion):
1611         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1612         (TestRunner):
1613         * DumpRenderTree/chromium/WebViewHost.cpp:
1614         (WebViewHost::display):
1615         (WebViewHost::displayInvalidatedRegion):
1616         * DumpRenderTree/chromium/WebViewHost.h:
1617
1618 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1619
1620         [chromium] move speech related methods to TestRunner library
1621         https://bugs.webkit.org/show_bug.cgi?id=107266
1622
1623         Reviewed by Adam Barth.
1624
1625         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1626         (DRTTestRunner::DRTTestRunner):
1627         (DRTTestRunner::displayInvalidatedRegion):
1628         * DumpRenderTree/chromium/DRTTestRunner.h:
1629         (DRTTestRunner):
1630         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1631         (WebTestDelegate):
1632         (WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
1633         (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
1634         (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
1635         (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
1636         (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
1637         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1638         (WebTestRunner::TestRunner::TestRunner):
1639         (WebTestRunner):
1640         (WebTestRunner::TestRunner::addMockSpeechInputResult):
1641         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
1642         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
1643         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
1644         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
1645         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1646         (TestRunner):
1647         * DumpRenderTree/chromium/WebViewHost.cpp:
1648         (WebViewHost::addMockSpeechInputResult):
1649         (WebViewHost::setMockSpeechInputDumpRect):
1650         (WebViewHost::addMockSpeechRecognitionResult):
1651         (WebViewHost::setMockSpeechRecognitionError):
1652         (WebViewHost::wasMockSpeechRecognitionAborted):
1653         * DumpRenderTree/chromium/WebViewHost.h:
1654
1655 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1656
1657         [chromium] move notification related methods to TestRunner
1658         https://bugs.webkit.org/show_bug.cgi?id=107269
1659
1660         Reviewed by Adam Barth.
1661
1662         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1663         (DRTTestRunner::DRTTestRunner):
1664         * DumpRenderTree/chromium/DRTTestRunner.h:
1665         (DRTTestRunner):
1666         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1667         (WebTestDelegate):
1668         (WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
1669         (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
1670         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1671         (WebTestRunner::TestRunner::TestRunner):
1672         (WebTestRunner):
1673         (WebTestRunner::TestRunner::grantWebNotificationPermission):
1674         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
1675         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1676         (TestRunner):
1677         * DumpRenderTree/chromium/WebViewHost.cpp:
1678         (WebViewHost::grantWebNotificationPermission):
1679         (WebViewHost::simulateLegacyWebNotificationClick):
1680         * DumpRenderTree/chromium/WebViewHost.h:
1681
1682 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1683
1684         [chromium] move geolocation related methods to TestRunner
1685         https://bugs.webkit.org/show_bug.cgi?id=107267
1686
1687         Reviewed by Adam Barth.
1688
1689         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1690         (DRTTestRunner::DRTTestRunner):
1691         * DumpRenderTree/chromium/DRTTestRunner.h:
1692         (DRTTestRunner):
1693         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1694         (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
1695         (WebTestRunner::WebTestDelegate::setGeolocationPermission):
1696         (WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
1697         (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
1698         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1699         (WebTestRunner::TestRunner::TestRunner):
1700         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
1701         (WebTestRunner):
1702         (WebTestRunner::TestRunner::setGeolocationPermission):
1703         (WebTestRunner::TestRunner::setMockGeolocationPosition):
1704         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
1705         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1706         (TestRunner):
1707         * DumpRenderTree/chromium/WebViewHost.cpp:
1708         (WebViewHost::numberOfPendingGeolocationPermissionRequests):
1709         (WebViewHost::setGeolocationPermission):
1710         (WebViewHost::setMockGeolocationPosition):
1711         (WebViewHost::setMockGeolocationPositionUnavailableError):
1712         * DumpRenderTree/chromium/WebViewHost.h:
1713
1714 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
1715
1716         Unreviewed build fix for Qt WK2 after r140258.
1717         Use the size_t type instead of unsigned for the variable
1718         which holds the position of the first null character in the
1719         console message.
1720
1721         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1722         (WTR::InjectedBundlePage::willAddMessageToConsole):
1723
1724 2013-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1725
1726         Unreviewed, rolling out r140260.
1727         http://trac.webkit.org/changeset/140260
1728         https://bugs.webkit.org/show_bug.cgi?id=107387
1729
1730         breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
1731         nothing else) (Requested by thakis__ on #webkit).
1732
1733         * Scripts/update-webkit-chromium:
1734
1735 2013-01-19  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1736
1737         Delegated scrolling: Assertion on attempt to show a CSS sticky element
1738         https://bugs.webkit.org/show_bug.cgi?id=106890
1739
1740         Reviewed by Kenneth Rohde Christiansen.
1741
1742         Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.
1743
1744         * WebKitTestRunner/TestInvocation.cpp:
1745         (WTR::shouldUseFixedLayout):
1746         (WTR):
1747         (WTR::updateLayoutType):
1748
1749 2013-01-19  Nico Weber  <thakis@chromium.org>
1750
1751         Make ninja the default build system for build-webkit --chromium on mac
1752         https://bugs.webkit.org/show_bug.cgi?id=106737
1753
1754         Reviewed by Eric Seidel.
1755
1756         * Scripts/update-webkit-chromium:
1757
1758 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
1759
1760         [WK2] svg/dom/fuzz-path-parser.html is failing
1761         https://bugs.webkit.org/show_bug.cgi?id=107133
1762
1763         Reviewed by Alexey Proskuryakov.
1764
1765         Console messages can contain null characters before the end of string.
1766         Appending such message to the StringBuilder as a WTFString appends the
1767         complete string, including the null character. This later cuts off everything
1768         after the null character when the string is being printed out to the test
1769         output.
1770
1771         To avoid this, truncate the string up to the first null character. This
1772         preserves the newline character appended immediately after this and
1773         stops giving incorrect output.
1774
1775         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1776         (WTR::InjectedBundlePage::willAddMessageToConsole):
1777
1778 2013-01-19  Eric Seidel  <eric@webkit.org>
1779
1780         Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
1781         https://bugs.webkit.org/show_bug.cgi?id=107367
1782
1783         Reviewed by Ryosuke Niwa.
1784
1785         Using srcdoc instead of document.write changes the error output
1786         ever so slightly.  Clearly we were already trying to ignore these
1787         messages, just not succeeding.  This change makes this new test "pass" correctly.
1788
1789         * Scripts/webkitpy/performance_tests/perftest.py:
1790         (PerfTest):
1791
1792 2013-01-18  Dan Winship  <danw@gnome.org>
1793
1794         REGRESSION (r139071): run-webkit-httpd complains at launch
1795         https://bugs.webkit.org/show_bug.cgi?id=107310
1796
1797         Reviewed by Alexey Proskuryakov.
1798
1799         * Scripts/webkitperl/httpd.pm:
1800         (getApacheVersion): use preferred perl syntax
1801
1802 2013-01-18  Julie Parent  <jparent@chromium.org>
1803
1804         Add back 'group' as a default cross dashboard parameter, but with null as its value.
1805         https://bugs.webkit.org/show_bug.cgi?id=107336
1806
1807         We need to have 'group' listed as a parameter, else we never parse it,
1808         as we only parse parameters with defaults.
1809         
1810         Reviewed by Ojan Vafai.
1811
1812         * TestResultServer/static-dashboards/dashboard_base.js:
1813
1814 2013-01-18  Emil A Eklund  <eae@chromium.org>
1815
1816         Update LayoutUnit rounding unit test
1817         https://bugs.webkit.org/show_bug.cgi?id=107322
1818
1819         Reviewed by Levi Weintraub.
1820         
1821         Update the LayoutUnitRounding test to use fromFloatRound for
1822         values that cannot accurately be represented as a LayoutUnit
1823         (the default behavior is to floor the value to the nearest
1824         LayoutUnit).
1825
1826         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1827         (TestWebKitAPI::TEST):
1828
1829 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1830
1831         VCSUtils.pm: Stop calling git repo-config.
1832         https://bugs.webkit.org/show_bug.cgi?id=107294
1833
1834         Reviewed by Dirk Pranke.
1835
1836         The `repo-config' git command has been deprecated since early
1837         2008, and recent versions have started warning it is deprecated.
1838
1839         Basically revert r27870 and use the `config' command all the time.
1840
1841         * Scripts/VCSUtils.pm:
1842         (gitConfig):
1843
1844 2013-01-18  Levi Weintraub  <leviw@chromium.org>
1845
1846         LayoutUnit should round half consistently, not away from zero
1847         https://bugs.webkit.org/show_bug.cgi?id=107208
1848
1849         Reviewed by Eric Seidel.
1850
1851         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Updating to reflect and
1852         cover this change in rounding behavior.
1853
1854 2013-01-18  Tim Horton  <timothy_horton@apple.com>
1855
1856         [mac] DumpRenderTree/WebKitTestRunner should not participate in Exposé/Mission Control
1857         https://bugs.webkit.org/show_bug.cgi?id=107234
1858
1859         Reviewed by Simon Fraser.
1860
1861         * DumpRenderTree/mac/DumpRenderTree.mm:
1862         (createWebViewAndOffscreenWindow): Disable participation in Exposé via NSWindowCollectionBehaviorStationary.
1863         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1864         (WTR::PlatformWebView::PlatformWebView): Ditto.
1865
1866 2013-01-18  Tim Horton  <timothy_horton@apple.com>
1867
1868         [mac] DumpRenderTree/WebKitTestRunner should disable NSBeep
1869         https://bugs.webkit.org/show_bug.cgi?id=107251
1870
1871         Reviewed by Simon Fraser.
1872
1873         Disable NSBeep in DumpRenderTree and WebKitTestRunner using NSSound SPI.
1874
1875         * DumpRenderTree/mac/DumpRenderTree.mm:
1876         (dumpRenderTree):
1877         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1878         (WTR::InjectedBundle::platformInitialize):
1879
1880 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
1881
1882         [GTK] Enable indexed database for development builds
1883         https://bugs.webkit.org/show_bug.cgi?id=107299
1884
1885         Reviewed by Gustavo Noronha Silva.
1886
1887         * Scripts/webkitperl/FeatureList.pm: Enable indexed database by default
1888         for GTK+ development builds.
1889
1890 2013-01-18  Dominic Mazzoni  <dmazzoni@google.com>
1891
1892         AX: Improve table-guessing heuristics
1893         https://bugs.webkit.org/show_bug.cgi?id=107042
1894
1895         Reviewed by Chris Fleizach.
1896
1897         Implement parentElementCallback on Chromium to make testing easier.
1898
1899         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1900         (WebTestRunner::AccessibilityUIElement::parentElementCallback):
1901
1902 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
1903
1904         [GTK] Add property for IndexedDB database path to WebKitGTK+
1905         https://bugs.webkit.org/show_bug.cgi?id=106136
1906
1907         Reviewed by Gustavo Noronha Silva.
1908
1909         During testing, set the web database directory to DUMPRENDERTREE_TEMP
1910         before falling back to the old default. This is necessary because
1911         indexed database tests require that each DRT shard is using a different
1912         IDB database location.
1913
1914         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1915         (temporaryDatabaseDirectory): Added this helper for getting the
1916         database directory.
1917         (setDefaultsToConsistentStateValuesForTesting): Use the new helper.
1918
1919 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1920
1921         [EFL][WK2] Enable API test InjectedBundleFrameHitTest on EFL
1922         https://bugs.webkit.org/show_bug.cgi?id=107264
1923
1924         Reviewed by Laszlo Gombos.
1925
1926         Enable API test InjectedBundleFrameHitTest for hit-testing,
1927         since it is now passing on both Debug and Release builds.
1928
1929         * TestWebKitAPI/CMakeLists.txt:
1930         * TestWebKitAPI/PlatformEfl.cmake:
1931
1932 2013-01-18  Manuel Rego Casasnovas  <rego@igalia.com>
1933
1934         [GTK] Implement TestRunner::addUserScript
1935         https://bugs.webkit.org/show_bug.cgi?id=107275
1936
1937         Reviewed by Philippe Normand.
1938
1939         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1940         (TestRunner::addUserScript): Implement method using
1941         DumpRenderTreeSupportGtk::addUserScript.
1942
1943 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1944
1945         Unreviewed, add my secondary email address to the list.
1946
1947         * Scripts/webkitpy/common/config/committers.py:
1948
1949 2013-01-18  Dan Carney  <dcarney@google.com>
1950
1951         [chromium] move pointerlock functions to TestRunner library
1952         https://bugs.webkit.org/show_bug.cgi?id=107241
1953
1954         Reviewed by Jochen Eisinger.
1955
1956         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1957         (DRTTestRunner::DRTTestRunner):
1958         * DumpRenderTree/chromium/DRTTestRunner.h:
1959         (DRTTestRunner):
1960         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1961         (WebTestRunner::WebTestDelegate::didAcquirePointerLock):
1962         (WebTestRunner::WebTestDelegate::didNotAcquirePointerLock):
1963         (WebTestRunner::WebTestDelegate::didLosePointerLock):
1964         (WebTestRunner::WebTestDelegate::setPointerLockWillRespondAsynchronously):
1965         (WebTestRunner::WebTestDelegate::setPointerLockWillFailSynchronously):
1966         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1967         (WebTestRunner::TestRunner::TestRunner):
1968         (WebTestRunner):
1969         (WebTestRunner::TestRunner::didAcquirePointerLock):
1970         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
1971         (WebTestRunner::TestRunner::didLosePointerLock):
1972         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
1973         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
1974         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1975         (TestRunner):
1976         * DumpRenderTree/chromium/WebViewHost.h:
1977         (WebViewHost):
1978
1979 2013-01-14  Dominik Röttsches  <dominik.rottsches@intel.com>
1980
1981         [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
1982         https://bugs.webkit.org/show_bug.cgi?id=106774
1983
1984         Reviewed by Martin Robinson.
1985
1986         In order to fix a long standing linespacing/font ascent & descent issue
1987         we found that FreeType commit b0962ac34e660 solves that problem.
1988         Let's update FreeType accordingly, but bump it to 2.4.11 due to the
1989         maintainer recommending several security updates after that said commit.
1990
1991         Also, in order to avoid extra rebaselining, let's activate subpixel
1992         layout at the same time.
1993
1994         * efl/jhbuild.modules: New freetype 2.4.11
1995
1996 2013-01-17  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1997
1998         [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
1999         https://bugs.webkit.org/show_bug.cgi?id=107107
2000         PR 282192
2001
2002         Reviewed by Rob Buis.
2003
2004         The DRT application will convert relative/absolute file path to
2005         file://<real-file-path> format, so we only check for http/file prefix.
2006
2007         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2008         (BlackBerry::WebKit::isFullUrl):
2009         (WebKit):
2010         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
2011
2012 2013-01-17  Frank Farzan  <frankf@chromium.org>
2013
2014         Flakiness dashboard: Add ChromiumFYI master
2015         https://bugs.webkit.org/show_bug.cgi?id=107180
2016
2017         Reviewed by Ojan Vafai.
2018
2019         This is needed to enable Chrome Android bots
2020         to upload results for instrumentation tests.
2021
2022         * TestResultServer/generate_builders_json.py:
2023         (main):
2024         * TestResultServer/static-dashboards/builders.jsonp:
2025
2026 2013-01-17  Frank Farzan  <frankf@chromium.org>
2027
2028         Add Chrome on Android instrumentation test types to flakiness dashboard
2029         https://bugs.webkit.org/show_bug.cgi?id=106964
2030
2031         Reviewed by Ojan Vafai.
2032
2033         Specifically, add these test types:
2034         
2035          androidwebview_instrumentation_tests
2036          chromiumtestshell_instrumentation_tests
2037          contentshell_instrumentation_tests
2038         
2039         Also, add ChromiumFYI to the list of masters.
2040
2041         * TestResultServer/static-dashboards/builders.js:
2042         (loadBuildersList):
2043         * TestResultServer/static-dashboards/dashboard_base.js:
2044         (currentBuilderGroupCategory):
2045
2046 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
2047
2048         Fixing webkitpy's SCM unit tests.
2049         https://bugs.webkit.org/show_bug.cgi?id=106429
2050
2051         Reviewed by Eric Seidel.
2052
2053         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2054         (SCMDetectorTest.test_detect_scm_system):
2055         * Scripts/webkitpy/common/checkout/scm/git.py:
2056         (Git.in_working_directory):
2057         (Git.read_git_config):
2058         (Git._assert_can_squash):
2059         (Git.remote_branch_ref):
2060         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2061         (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
2062         (GitTestWithMock):
2063         (GitTestWithMock.make_scm):
2064         (GitTestWithMock.test_create_patch):
2065         * Scripts/webkitpy/common/system/outputcapture.py:
2066         (OutputCapture.assert_outputs):
2067         (OutputCaptureTestCaseBase):
2068         * Scripts/webkitpy/test/printer.py:
2069         (Printer.configure):
2070
2071 2013-01-17  Julie Parent  <jparent@chromium.org>
2072
2073         Flakiness dashboard assumes there must be ToT tests
2074         https://bugs.webkit.org/show_bug.cgi?id=107155
2075
2076         Remove group as a default parameter, since we can't actually know
2077         the name of a group initially.  Instead, introduces 
2078         currentBuilderGroupName which returns the current builder group
2079         if it has been explicitly set, or picks the first one available
2080         as a default. Allows us to remove some extra code tracking this
2081         stuff as well.
2082         
2083         Reviewed by Ojan Vafai.
2084
2085         * TestResultServer/static-dashboards/dashboard_base.js:
2086         (parseCrossDashboardParameters):
2087         (currentBuilderGroupName):
2088         (currentBuilderGroup):
2089         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2090         (platformAndBuildType):
2091         * TestResultServer/static-dashboards/loader.js:
2092         (.):
2093
2094 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
2095
2096         Remove NodeListsNodeData when it's no longer needed
2097         https://bugs.webkit.org/show_bug.cgi?id=107074
2098
2099         Reviewed by Darin Adler.
2100
2101         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
2102
2103         * Scripts/webkitpy/performance_tests/perftest.py:
2104         (PerfTest):
2105
2106 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
2107
2108         Ref test images are upside-down in WebKit2
2109         https://bugs.webkit.org/show_bug.cgi?id=105457
2110
2111         Reviewed by Sam "Speedy" Weinig.
2112         
2113         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
2114         from the window snapshot contained a flipped copy of the image, causing all ref
2115         and pixel images to be upside-down.
2116
2117         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2118         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2119
2120 2013-01-17  Timothy Loh  <timloh@google.com>
2121
2122         Replaced specifiers variable with is_debug in builders.py
2123         https://bugs.webkit.org/show_bug.cgi?id=107057
2124
2125         Reviewed by Dirk Pranke.
2126
2127         Replaced specifiers variable with is_debug in builders.py to simplify
2128         Bug 106259. The other specifiers are not used elsewhere in the code.
2129         Fixed builder_name_for_port_name to return a debug builder if we don't
2130         have a release builder.
2131
2132         * Scripts/webkitpy/layout_tests/port/builders.py:
2133         (all_port_names):
2134         (builder_name_for_port_name):
2135         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2136         (TestRebaselineExpectations.test_rebaseline_expectations):
2137
2138 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
2139
2140         [GTK] Build with LevelDB when IndexedDB is enabled
2141         https://bugs.webkit.org/show_bug.cgi?id=103220
2142
2143         Reviewed by Gustavo Noronha Silva.
2144
2145         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
2146         as it does not conform to WebKit style.
2147
2148 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2149
2150         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
2151         https://bugs.webkit.org/show_bug.cgi?id=107119
2152
2153         Reviewed by Laszlo Gombos.
2154
2155         Do not use ASSERT on ecore_evas_init(), since the expression inside
2156         the macro compiles out of release builds.
2157
2158         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
2159         * TestWebKitAPI/efl/PlatformWebView.cpp:
2160         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
2161
2162 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
2163
2164         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
2165         https://bugs.webkit.org/show_bug.cgi?id=104545
2166
2167         Reviewed by Yury Semikhatsky.
2168
2169         Adopt signature changes.
2170
2171         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2172         (ProfilerAgent.getCPUProfile): Renamed.
2173         (ProfilerAgent.getHeapSnapshot): Added.
2174
2175 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
2176
2177         [GTK][EFL] NWRT should check that Xvfb is installed
2178         https://bugs.webkit.org/show_bug.cgi?id=71767
2179
2180         Reviewed by Dirk Pranke.
2181
2182         EFL and GTK ports now check that Xvfb is installed before running
2183         layout tests. The command line used to check whether Xvfb is present
2184         is a simple `which Xvfb` that should return 0 as the exit code upon
2185         success.
2186
2187         * Scripts/webkitpy/layout_tests/port/efl.py:
2188         (EflPort.show_results_html_file):
2189         (EflPort):
2190         (EflPort.check_sys_deps):
2191         * Scripts/webkitpy/layout_tests/port/gtk.py:
2192         (GtkPort.check_sys_deps):
2193         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2194         (XvfbDriver):
2195         (XvfbDriver.check_xvfb):
2196
2197 2013-01-16  Alan Cutter  <alancutter@chromium.org>
2198
2199         sheriffbot can't tell me who "kov" is
2200         https://bugs.webkit.org/show_bug.cgi?id=106184
2201
2202         Reviewed by Eric Seidel.
2203
2204         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
2205
2206         * Scripts/webkitpy/common/config/committers.py:
2207         (Account.matches_glob):
2208         (CommitterList.contributors_by_search_string):
2209         * Scripts/webkitpy/common/config/committers_unittest.py:
2210         (CommittersTest.test_committer_lookup):
2211         * Scripts/webkitpy/tool/bot/irc_command.py:
2212         (Whois):
2213
2214 2013-01-16  David Kilzer  <ddkilzer@apple.com>
2215
2216         Use xcrun to find path to make for Mac port
2217         <http://webkit.org/b/107091>
2218
2219         Reviewed by Dan Bernstein.
2220
2221         * Scripts/webkitpy/layout_tests/port/mac.py:
2222         (MacPort._build_java_test_support): Call self.make_command().
2223         (MacPort.make_command): Add.  Call xcrun_find().
2224         (MacPort.nm_command): Use self.xcrun_find().
2225         (MacPort.xcrun_find): Add.  Extract from nm_command().
2226
2227 2013-01-16  Sam Weinig  <sam@webkit.org>
2228
2229         Make debug-safari --target-web-process work again
2230         https://bugs.webkit.org/show_bug.cgi?id=107088
2231
2232         Reviewed by Anders Carlsson.
2233
2234         * Scripts/webkitdirs.pm:
2235         (execMacWebKitAppForDebugging):
2236         The shim is now called SecItemShim.
2237
2238 2013-01-16  Alan Cutter  <alancutter@chromium.org>
2239
2240         GCE build scripts don't take working directory into account when calling findzone.sh
2241         https://bugs.webkit.org/show_bug.cgi?id=106962
2242
2243         Reviewed by Adam Barth.
2244
2245         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2246         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2247         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2248
2249 2013-01-16  Alan Cutter  <alancutter@chromium.org>
2250
2251         start-queue.sh does not pass remaining parameters correctly
2252         https://bugs.webkit.org/show_bug.cgi?id=107054
2253
2254         Reviewed by Adam Barth.
2255
2256         start-queue.sh now passes all remaining params to the webkit-patch command.
2257         Previously only one additional queue parameter could be sent.
2258
2259         * EWSTools/start-queue.sh:
2260
2261 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
2262
2263         check-webkit-style script cannot running in Chinese windows.
2264         https://bugs.webkit.org/show_bug.cgi?id=87548
2265
2266         Reviewed by Darin Adler.
2267
2268         * Scripts/webkitpy/common/system/platforminfo.py:
2269         (PlatformInfo._win_version_tuple_from_cmd):
2270
2271 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
2272
2273         Delete an extraneous print statement.
2274         https://bugs.webkit.org/show_bug.cgi?id=106562
2275
2276         Delete the extraneous print statement introduced in r139841.
2277
2278         * Scripts/webkitpy/layout_tests/views/printing.py:
2279         (Printer.print_found):
2280
2281 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
2282
2283         Please reinstate --pixel
2284         https://bugs.webkit.org/show_bug.cgi?id=101995
2285
2286         Reviewed by Dirk Pranke.
2287
2288         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
2289         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
2290         Some developers are still used to these options that were available in the ORWT.
2291
2292         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2293         (parse_args):
2294
2295 2013-01-16  Eric Seidel  <eric@webkit.org>
2296
2297         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
2298         https://bugs.webkit.org/show_bug.cgi?id=99512
2299
2300         Reviewed by Darin Adler.
2301
2302         * Scripts/run-sunspider:
2303
2304 2013-01-16  Eric Seidel  <eric@webkit.org>
2305
2306         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
2307         https://bugs.webkit.org/show_bug.cgi?id=106036
2308
2309         Reviewed by Darin Adler.
2310
2311         * Scripts/webkitpy/webkitpy.pyproj: Removed.
2312         * Scripts/webkitpy/webkitpy.sln: Removed.
2313
2314 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
2315
2316         [Chromium] Remove hardcoded chromium_*.jar in gyp files
2317         https://bugs.webkit.org/show_bug.cgi?id=104049
2318
2319         Reviewed by Eric Seidel.
2320
2321         Targets with dependencies (direct/indirect) on a java target receive
2322         the chromium_*.jar paths in the variable input_jars_paths. Targets
2323         should use that rather than hardcoding where they think the jar will
2324         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
2325         than as --jars to generate_native_test.py.
2326
2327         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2328         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2329
2330 2013-01-16  Dan Carney  <dcarney@google.com>
2331
2332         [chromium] move setMockDeviceOrientation to TestRunner library
2333         https://bugs.webkit.org/show_bug.cgi?id=106895
2334
2335         Reviewed by Jochen Eisinger.
2336
2337         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2338         (DRTTestRunner::DRTTestRunner):
2339         * DumpRenderTree/chromium/DRTTestRunner.h:
2340         (DRTTestRunner):
2341         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2342         (WebKit):
2343         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
2344         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2345         (WebTestRunner::TestRunner::TestRunner):
2346         (WebTestRunner::TestRunner::setMockDeviceOrientation):
2347         (WebTestRunner):
2348         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2349         (TestRunner):
2350         * DumpRenderTree/chromium/WebViewHost.cpp:
2351         (WebViewHost::setDeviceOrientation):
2352         * DumpRenderTree/chromium/WebViewHost.h:
2353         (WebViewHost):
2354
2355 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
2356
2357         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2358         https://bugs.webkit.org/show_bug.cgi?id=106904
2359
2360         Reviewed by Adam Barth.
2361
2362         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2363         (DRTTestRunner::DRTTestRunner):
2364         (DRTTestRunner::notifyDone):
2365         (DRTTestRunner::reset):
2366         * DumpRenderTree/chromium/DRTTestRunner.h:
2367         (DRTTestRunner):
2368         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2369         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
2370         (WebTestRunner::WebTestDelegate::setFocus):
2371         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
2372         (WebTestRunner::WebTestDelegate::pathToLocalResource):
2373         (WebTestRunner::WebTestDelegate::setLocale):
2374         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2375         (WebTestRunner::TestRunner::TestRunner):
2376         (WebTestRunner::TestRunner::reset):
2377         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
2378         (WebTestRunner):
2379         (WebTestRunner::TestRunner::setWindowIsKey):
2380         (WebTestRunner::TestRunner::pathToLocalResource):
2381         (WebTestRunner::TestRunner::setBackingScaleFactor):
2382         (WebTestRunner::TestRunner::setPOSIXLocale):
2383         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2384         (WebTestRunner::TestRunner::taskList):
2385         (TestRunner):
2386         * DumpRenderTree/chromium/WebViewHost.cpp:
2387         (WebViewHost::setDeviceScaleFactor):
2388         (WebViewHost::setFocus):
2389         (WebViewHost::setAcceptAllCookies):
2390         (WebViewHost::pathToLocalResource):
2391         (WebViewHost::setLocale):
2392         * DumpRenderTree/chromium/WebViewHost.h:
2393         (WebViewHost):
2394
2395 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
2396
2397         [GTK] build-webkit fails if the jhbuild wrapper is not used
2398         https://bugs.webkit.org/show_bug.cgi?id=106769
2399
2400         Reviewed by Martin Robinson.
2401
2402         Return an empty array instead of "" in
2403         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
2404         will not be recognized as a valid command when the returned array
2405         is directly passed to perl's system() call.
2406
2407         * Scripts/webkitdirs.pm:
2408         (jhbuildWrapperPrefixIfNeeded):
2409
2410 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
2411
2412         [chromium] add title text direction attribute to TestRunner
2413         https://bugs.webkit.org/show_bug.cgi?id=106907
2414
2415         Reviewed by Adam Barth.
2416
2417         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2418         (DRTTestRunner::DRTTestRunner):
2419         (DRTTestRunner::reset):
2420         * DumpRenderTree/chromium/DRTTestRunner.h:
2421         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2422         (WebTestRunner::WebTestRunner::setTitleTextDirection):
2423         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2424         (WebTestRunner::TestRunner::TestRunner):
2425         (WebTestRunner::TestRunner::reset):
2426         (WebTestRunner::TestRunner::setTitleTextDirection):
2427         (WebTestRunner):
2428         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2429         (TestRunner):
2430         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2431         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2432         * DumpRenderTree/chromium/WebViewHost.cpp:
2433         (WebViewHost::didReceiveTitle):
2434
2435 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
2436
2437         NRWT still confused about test count with --repeat-each and --iterations
2438         https://bugs.webkit.org/show_bug.cgi?id=106562
2439
2440         Reviewed by Dirk Pranke.
2441
2442         Fix the printed unique test count and skipped count. This
2443         seems to have broken in r127688 ("NRWT lies about the number
2444         of tests that it's skipping when used with --repeat-each").
2445
2446         Also add a test for print_found()
2447
2448         * Scripts/webkitpy/layout_tests/views/printing.py:
2449         (Printer.print_found):
2450         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2451         (Testprinter.test_details):
2452         (Testprinter):
2453         (Testprinter.test_found):
2454
2455 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2456
2457         Unreviewed follow-up to r139769.
2458
2459         Note that omitting the WebKit1 code from the build now
2460         works for GTK as well.
2461
2462         * Scripts/build-webkit:
2463
2464 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2465
2466         test-webkitpy: truncate output to the terminal width when necessary
2467         https://bugs.webkit.org/show_bug.cgi?id=106973
2468
2469         Reviewed by Ojan Vafai.
2470
2471         this implements the same logic for test-webkitpy that we have
2472         for run-webkit-tests (and ninja).
2473
2474         No tests written as this is exercised by running test-webkitpy itself.
2475
2476         * Scripts/webkitpy/test/printer.py:
2477         (Printer.configure):
2478         (Printer._test_line):
2479
2480 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2481
2482         remove extraneous output in test-webkitpy
2483         https://bugs.webkit.org/show_bug.cgi?id=106971
2484
2485         Reviewed by Ojan Vafai.
2486
2487         We weren't ignoring or capturing the echoed output from
2488         these two tests, and getting noise in the logs as a result.
2489
2490         * Scripts/webkitpy/common/system/executive_unittest.py:
2491         (ExecutiveTest.test_auto_stringify_args):
2492         (ExecutiveTest.test_popen_args):
2493
2494 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2495
2496         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
2497         https://bugs.webkit.org/show_bug.cgi?id=106974
2498
2499         Reviewed by Ryosuke Niwa.
2500
2501         I forgot to stub out the call to check to ensure that the ports were
2502         available, so this test could fail if something was listening on 8000 or
2503         8443 on the machine.
2504
2505         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2506         (TestHttpServer.test_win32_start_and_stop):
2507
2508 2013-01-15  Levi Weintraub  <leviw@chromium.org>
2509
2510         Unreviewed, rolling out r139792.
2511         http://trac.webkit.org/changeset/139792
2512         https://bugs.webkit.org/show_bug.cgi?id=106970
2513
2514         Broke the windows build.
2515
2516         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2517         (DRTTestRunner::DRTTestRunner):
2518         (DRTTestRunner::notifyDone):
2519         (DRTTestRunner::reset):
2520         (DRTTestRunner::setAlwaysAcceptCookies):
2521         (DRTTestRunner::setWindowIsKey):
2522         (DRTTestRunner::pathToLocalResource):
2523         (DRTTestRunner::setPOSIXLocale):
2524         (InvokeCallbackTask):
2525         (InvokeCallbackTask::InvokeCallbackTask):
2526         (InvokeCallbackTask::runIfValid):
2527         (DRTTestRunner::setBackingScaleFactor):
2528         * DumpRenderTree/chromium/DRTTestRunner.h:
2529         (DRTTestRunner):
2530         (DRTTestRunner::taskList):
2531         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2532         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
2533         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2534         (WebTestRunner::TestRunner::TestRunner):
2535         (WebTestRunner::TestRunner::reset):
2536         (WebTestRunner::TestRunner::setDatabaseQuota):
2537         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2538         (TestRunner):
2539         * DumpRenderTree/chromium/WebViewHost.cpp:
2540         (WebViewHost::setPendingExtraData):
2541         (WebViewHost::setDeviceScaleFactor):
2542         * DumpRenderTree/chromium/WebViewHost.h:
2543         (WebViewHost):
2544
2545 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
2546
2547         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
2548
2549         * Scripts/webkitpy/common/config/ports.py:
2550         (MacWK2Port):
2551
2552 2013-01-15  Alan Cutter  <alancutter@chromium.org>
2553
2554         Extend sheriffbot's "help" command to be able to get help on individual commands
2555         https://bugs.webkit.org/show_bug.cgi?id=106629
2556
2557         Reviewed by Eric Seidel.
2558
2559         Added a help command to sheriffbot.
2560         Fixed some style issues and ordered the commands alphabetically.
2561
2562         * Scripts/webkitpy/tool/bot/irc_command.py:
2563         (IRCCommand):
2564         (IRCCommand.execute):
2565         (IRCCommand.usage):
2566         (IRCCommand.help):
2567         (CreateBug):
2568         (CreateBug.execute):
2569         (Help):
2570         (Help.execute):
2571         (Help._post_command_help):
2572         (Hi):
2573         (Hi.execute):
2574         (Restart):
2575         (RollChromiumDEPS):
2576         (RollChromiumDEPS._parse_args):
2577         (RollChromiumDEPS._expand_irc_nickname):
2578         (RollChromiumDEPS.execute):
2579         (Rollout):
2580         (Rollout._extract_revisions):
2581         (Rollout.execute):
2582         (Sheriffs):
2583         (Sheriffs.execute):
2584         (Whois):
2585         (Whois.execute):
2586         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2587         (IRCBotTest.test_help):
2588
2589 2013-01-15  Enrica Casucci  <enrica@apple.com>
2590
2591         Add a new set of WebKit2 APIs for text search and
2592         search results management.
2593         https://bugs.webkit.org/show_bug.cgi?id=106834.
2594         <rdar://problem/12597159>
2595
2596         Added new test for the new WebKit2 API for
2597         text search.
2598         
2599         Reviewed by Simon Fraser.
2600
2601         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2602         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
2603
2604 2013-01-15  Levi Weintraub  <leviw@chromium.org>
2605
2606         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2607         https://bugs.webkit.org/show_bug.cgi?id=106904
2608
2609         Reverting 139794. It broke the build. It appears that a header file,
2610         WebTextDirection.h, was left out.
2611
2612         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2613         (DRTTestRunner::DRTTestRunner):
2614         (DRTTestRunner::reset):
2615         * DumpRenderTree/chromium/DRTTestRunner.h:
2616         (DRTTestRunner::setTitleTextDirection):
2617         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2618         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2619         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2620         (WebTestRunner::TestRunner::TestRunner):
2621         (WebTestRunner::TestRunner::reset):
2622         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2623         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2624         (TestRunner):
2625         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2626         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2627         * DumpRenderTree/chromium/WebViewHost.cpp:
2628         (WebViewHost::didReceiveTitle):
2629
2630 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2631
2632         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2633         https://bugs.webkit.org/show_bug.cgi?id=106904
2634
2635         Reviewed by Adam Barth.
2636
2637         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2638         (DRTTestRunner::DRTTestRunner):
2639         (DRTTestRunner::notifyDone):
2640         (DRTTestRunner::reset):
2641         * DumpRenderTree/chromium/DRTTestRunner.h:
2642         (DRTTestRunner):
2643         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2644         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
2645         (WebTestRunner::WebTestDelegate::setFocus):
2646         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
2647         (WebTestRunner::WebTestDelegate::pathToLocalResource):
2648         (WebTestRunner::WebTestDelegate::setLocale):
2649         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2650         (WebTestRunner::TestRunner::TestRunner):
2651         (WebTestRunner::TestRunner::reset):
2652         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
2653         (WebTestRunner):
2654         (WebTestRunner::TestRunner::setWindowIsKey):
2655         (WebTestRunner::TestRunner::pathToLocalResource):
2656         (WebTestRunner::TestRunner::setBackingScaleFactor):
2657         (WebTestRunner::TestRunner::setPOSIXLocale):
2658         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2659         (WebTestRunner::TestRunner::taskList):
2660         (TestRunner):
2661         * DumpRenderTree/chromium/WebViewHost.cpp:
2662         (WebViewHost::setDeviceScaleFactor):
2663         (WebViewHost::setFocus):
2664         (WebViewHost::setAcceptAllCookies):
2665         (WebViewHost::pathToLocalResource):
2666         (WebViewHost::setLocale):
2667         * DumpRenderTree/chromium/WebViewHost.h:
2668         (WebViewHost):
2669
2670 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2671
2672         Tests with WontFix expectation are (indirectly) skipped
2673         https://bugs.webkit.org/show_bug.cgi?id=105860
2674
2675         Reviewed by Dirk Pranke.
2676
2677         Only skip the WontFix expectation if there are no other layout test
2678         expectations (like Failure, ImageOnlyFailure) listed for the test.
2679         This makes it possible to run an expected failure for which there
2680         is no reason or interest to fix. There are some ports that would like
2681         to exercise this behavior as well as specific test cases that should use
2682         such expectations.
2683
2684         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2685         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
2686         WONTFIX test if there are no expectations listed. The warning is adjusted
2687         to reflect the new behavior.
2688         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
2689         and adjust test cases for these changes.
2690         (ExpectationSyntaxTests.test_wontfix):
2691         (SemanticTests.test_skip_and_wontfix):
2692
2693 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2694
2695         [chromium] add title text direction attribute to TestRunner
2696         https://bugs.webkit.org/show_bug.cgi?id=106907
2697
2698         Reviewed by Adam Barth.
2699
2700         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2701         (DRTTestRunner::DRTTestRunner):
2702         (DRTTestRunner::reset):
2703         * DumpRenderTree/chromium/DRTTestRunner.h:
2704         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2705         (WebTestRunner::WebTestRunner::setTitleTextDirection):
2706         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2707         (WebTestRunner::TestRunner::TestRunner):
2708         (WebTestRunner::TestRunner::reset):
2709         (WebTestRunner::TestRunner::setTitleTextDirection):
2710         (WebTestRunner):
2711         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2712         (TestRunner):
2713         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2714         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2715         * DumpRenderTree/chromium/WebViewHost.cpp:
2716         (WebViewHost::didReceiveTitle):
2717
2718 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2719
2720         nrwt: change the default # of locked shards on chromium_win to 1
2721         https://bugs.webkit.org/show_bug.cgi?id=106938
2722
2723         Reviewed by Eric Seidel.
2724
2725         It looks like LigHTTPd might be buggy or unstable if we are
2726         running multiple http tests in parallel; see
2727         http://code.google.com/p/chromium/issues/detail?id=169530 for more
2728         context as well. This change will stop running http tests in parallel
2729         and we can see if this fixes things.
2730
2731         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2732         (ChromiumWinPort.default_max_locked_shards):
2733         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2734         (ChromiumWinTest.test_path_to_image_diff):
2735         (ChromiumWinTest):
2736         (ChromiumWinTest.test_default_max_locked_shards):
2737
2738 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2739
2740         [chromium] move WebDatabase related methods to TestRunner library
2741         https://bugs.webkit.org/show_bug.cgi?id=106905
2742
2743         Reviewed by Adam Barth.
2744
2745         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2746         (DRTTestRunner::DRTTestRunner):
2747         (DRTTestRunner::reset):
2748         * DumpRenderTree/chromium/DRTTestRunner.h:
2749         (DRTTestRunner):
2750         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2751         (WebTestRunner::WebTestDelegate::clearAllDatabases):
2752         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
2753         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2754         (WebTestRunner::TestRunner::TestRunner):
2755         (WebTestRunner::TestRunner::reset):
2756         (WebTestRunner::TestRunner::clearAllDatabases):
2757         (WebTestRunner):
2758         (WebTestRunner::TestRunner::setDatabaseQuota):
2759         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2760         (TestRunner):
2761         * DumpRenderTree/chromium/WebViewHost.cpp:
2762         (WebViewHost::clearAllDatabases):
2763         (WebViewHost::setDatabaseQuota):
2764         * DumpRenderTree/chromium/WebViewHost.h:
2765         (WebViewHost):
2766
2767 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
2768
2769         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
2770         functionality match the name.
2771         https://bugs.webkit.org/show_bug.cgi?id=106870
2772
2773         Reviewed by Adam Barth.
2774
2775         * Scripts/webkitpy/tool/commands/download.py:
2776         (Clean):
2777         (Update):
2778         (Build):
2779         (BuildAndTest):
2780         (CheckStyle):
2781         (BuildAttachment):
2782         (BuildAndTestAttachment):
2783         (AbstractPatchApplyingCommand):
2784         (ApplyWatchList):
2785         (AbstractPatchLandingCommand):
2786         (CreateRollout):
2787         * Scripts/webkitpy/tool/steps/__init__.py:
2788         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2789         (CleanWorkingDirectory.options):
2790         (CleanWorkingDirectory.run):
2791         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2792         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2793         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
2794
2795 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2796
2797         [Autotools] Add support for WebKit2-only builds
2798         https://bugs.webkit.org/show_bug.cgi?id=106889
2799
2800         Reviewed by Gustavo Noronha Silva.
2801
2802         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
2803         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
2804         building the GTK port through build-webkit.
2805         * Scripts/webkitdirs.pm:
2806         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
2807         arguments when not building WebKit1.
2808         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
2809         through the Autotools build system.
2810
2811 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2812
2813         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
2814         https://bugs.webkit.org/show_bug.cgi?id=106197
2815
2816         Reviewed by Martin Robinson.
2817
2818         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
2819         features. Enable them on GTK, meaning they will be enabled in development builds
2820         (i.e. when building with build-webkit).
2821
2822 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2823
2824         [GTK] Enable CSS Image Resolution feature
2825         https://bugs.webkit.org/show_bug.cgi?id=99038
2826
2827         Reviewed by Gustavo Noronha Silva.
2828
2829         Enable the CSS Image Resolution feature for the development
2830         builds of the GTK port.
2831
2832         * Scripts/webkitperl/FeatureList.pm:
2833
2834 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2835
2836         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
2837         https://bugs.webkit.org/show_bug.cgi?id=106579
2838
2839         Reviewed by Gustavo Noronha Silva.
2840
2841         The --enable-unstable-features flag is not required to be passed anymore
2842         to the configure script as it was removed in r138252.
2843
2844         * Scripts/webkitdirs.pm:
2845         (buildAutotoolsProject):
2846
2847 2013-01-15  Tony Chang  <tony@chromium.org>
2848
2849         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
2850
2851         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2852         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
2853         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2854         (TestHttpServer.test_win32_start_and_stop):
2855
2856 2013-01-15  Joshua Bell  <jsbell@chromium.org>
2857
2858         Unreviewed. Adding Michael Pruett as contributor.
2859
2860         * Scripts/webkitpy/common/config/committers.py:
2861
2862 2013-01-15  Victor Carbune  <victor@rosedu.org>
2863
2864         Unreviewed. Update my email addresses.
2865
2866         * Scripts/webkitpy/common/config/committers.py:
2867
2868 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2869
2870         [GTK] Waiting on the gdb process will lead to deadlock
2871         https://bugs.webkit.org/show_bug.cgi?id=106906
2872
2873         Reviewed by Philippe Normand.
2874
2875         Use communicate() rather than wait() on the Popen object that's running the gdb
2876         command. This avoids the deadlock that occurs on the GTK builders.
2877
2878         * Scripts/webkitpy/layout_tests/port/gtk.py:
2879         (GtkPort._get_gdb_output):
2880
2881 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2882
2883         [GTK] Limit the number of frames printed out when backtracing with gdb
2884         https://bugs.webkit.org/show_bug.cgi?id=106901
2885
2886         Reviewed by Philippe Normand.
2887
2888         Printing an unlimited number of frames when dumping the gdb backtracing
2889         output can cause timeouts in the builders. This patch limits the number
2890         of frames that are printed out to 1024.
2891
2892         * Scripts/webkitpy/layout_tests/port/gtk.py:
2893         (GtkPort._get_gdb_output):
2894
2895 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
2896
2897         [Qt] Fix ImageDiff's image format conversion
2898         https://bugs.webkit.org/show_bug.cgi?id=106880
2899
2900         Reviewed by Csaba Osztrogonác.
2901
2902         Besides actually doing the conversion this also silences the suspicious warning:
2903         "ignoring return value of function declared with warn_unused_result attribute".
2904
2905         * ImageDiff/qt/ImageDiff.cpp:
2906         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
2907         copy of the image in the given format and does not alter the image itself.
2908
2909 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2910
2911         [chromium] move remaining methods that just set a boolean flag to TestRunner library
2912         https://bugs.webkit.org/show_bug.cgi?id=106823
2913
2914         Reviewed by Darin Fisher.
2915
2916         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2917         (DRTTestRunner::DRTTestRunner):
2918         (DRTTestRunner::reset):
2919         * DumpRenderTree/chromium/DRTTestRunner.h:
2920         (DRTTestRunner):
2921         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2922         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
2923         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
2924         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
2925         (WebTestRunner::WebTestRunner::testRepaint):
2926         (WebTestRunner::WebTestRunner::sweepHorizontally):
2927         (WebTestRunner::WebTestRunner::isPrinting):
2928         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2929         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2930         (WebTestRunner::TestRunner::TestRunner):
2931         (WebTestRunner::TestRunner::reset):
2932         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
2933         (WebTestRunner):
2934         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
2935         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
2936         (WebTestRunner::TestRunner::testRepaint):
2937         (WebTestRunner::TestRunner::sweepHorizontally):
2938         (WebTestRunner::TestRunner::isPrinting):
2939         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2940         (WebTestRunner::TestRunner::dumpBackForwardList):
2941         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
2942         (WebTestRunner::TestRunner::dumpSelectionRect):
2943         (WebTestRunner::TestRunner::repaintSweepHorizontally):
2944         (WebTestRunner::TestRunner::setPrinting):
2945         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
2946         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2947         (TestRunner):
2948
2949 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2950
2951         nrwt: stub out show_results_html for mock ports
2952         https://bugs.webkit.org/show_bug.cgi?id=106848
2953
2954         Reviewed by Ojan Vafai.
2955
2956         We were accidentally using the underlying ports'
2957         show_results_html_file() implementation, which would, unsurprisingly,
2958         fail in many cases (e.g., running mock-efl on the mac).
2959
2960         No test added since we don't generally add tests for the mock
2961         implementation.
2962
2963         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2964         (MockDRTPort.show_results_html_file):
2965
2966 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
2967
2968         Changing clean_working_directory/clean_local_commits and related
2969         functions to have consistent naming.
2970
2971         https://bugs.webkit.org/show_bug.cgi?id=104198
2972
2973         Reviewed by Adam Barth.
2974
2975         * Scripts/webkitpy/common/checkout/scm/git.py:
2976         * Scripts/webkitpy/common/checkout/scm/scm.py:
2977         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2978         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2979         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2980         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2981
2982 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2983
2984         Fix EWS GCE build scripts to detect which zone is available
2985         https://bugs.webkit.org/show_bug.cgi?id=106524
2986
2987         Reviewed by Adam Barth.
2988
2989         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2990         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2991         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2992         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
2993
2994 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
2995
2996         Adding an error string to AmbiguousCommitError.
2997         https://bugs.webkit.org/show_bug.cgi?id=106846
2998
2999         Reviewed by Adam Barth.
3000
3001         * Scripts/webkitpy/common/checkout/scm/git.py:
3002         (AmbiguousCommitError.__init__):
3003
3004 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
3005
3006         kill whole lighttpd process tree for chromium win
3007         https://bugs.webkit.org/show_bug.cgi?id=106838
3008
3009         Reviewed by Tony Chang.
3010
3011         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
3012         I think a test is causing a httpd server child process to wedge and
3013         killing the parent httpd server process isn't sufficient to ensure
3014         that the children are also killed.
3015
3016         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3017         (Lighttpd._check_and_kill):
3018         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3019         (TestHttpServer.test_start_cmd):
3020         (TestHttpServer):
3021         (TestHttpServer.test_win32_start_and_stop):
3022         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
3023         (TestHttpServer.test_win32_start_and_stop.mock_returns):
3024         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
3025
3026 2013-01-14  Nico Weber  <thakis@chromium.org>
3027
3028         [chromium] Enable `update-webkit --chromium --ninja` on windows
3029         https://bugs.webkit.org/show_bug.cgi?id=106836
3030
3031         Reviewed by Eric Seidel.
3032
3033         After running this, build-webkit --chromium will use ninja to build.
3034         Apparently there are some minor issues with that still, so it's
3035         not quite ready for use yet.
3036
3037         * Scripts/webkitdirs.pm:
3038         (determineIsChromiumNinja):
3039         (buildChromium):
3040
3041 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
3042
3043         nrwt: use the same search path for baselines and TestExpectations on apple mac
3044         https://bugs.webkit.org/show_bug.cgi?id=105599
3045
3046         Reviewed by Ryosuke Niwa.
3047
3048         Bug 105583 revealed some confusion due to the fact that the Apple
3049         Mac port used a different list of directories to search for baselines
3050         and TestExpectations files (actually, pretty much every port does).
3051
3052         It seems like a good idea to use the same list for both by default, but
3053         making this happen will affect every port in slightly different ways, so
3054         we'll try this on the Apple Mac port first.
3055
3056         Note that the effective changes for this are that:
3057         1) The apple mac port will look in platform/wk2 for baselines where
3058         it didn't before (it will look after looking in mac-wk2 but before
3059         the non-wk2 dirs)
3060         2) The apple mac-snowleopard port will use the expectations in
3061         mac-lion as well as the expectations in mac-snowleopard, although
3062         I'm not even sure if mac-snowleopard is still supported ...
3063
3064         * Scripts/webkitpy/layout_tests/port/mac.py:
3065         (MacPort.default_baseline_search_path):
3066         (MacPort.expectations_files):
3067         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3068         (test_baseline_search_path):
3069
3070 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
3071
3072         AX: Need to implement ColorWellRole
3073         https://bugs.webkit.org/show_bug.cgi?id=106756
3074
3075         Reviewed by Chris Fleizach.
3076
3077         Returns a string representation of the value of a color
3078         when the role is Color Well, to make it easy to write layout
3079         tests for color controls.
3080
3081         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
3082
3083 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
3084
3085         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
3086         https://bugs.webkit.org/show_bug.cgi?id=106682
3087
3088         Reviewed by Chris Fleizach.
3089
3090         Modify Chromium's DRT implementation of intValue to return a
3091         different value depending on the role.
3092
3093         There are actually platform-specific differences in what should
3094         be returned in the "value" of an object, so Chromium normally keeps
3095         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
3096         but this is a fine simplification to make cross-platform tests easier.
3097
3098         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
3099         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
3100
3101 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
3102
3103         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
3104         https://bugs.webkit.org/show_bug.cgi?id=106785
3105
3106         Reviewed by Adam Barth.
3107
3108         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3109         (DRTTestRunner::DRTTestRunner):
3110         (DRTTestRunner::reset):
3111         * DumpRenderTree/chromium/DRTTestRunner.h:
3112         (DRTTestRunner):
3113         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3114         (WebTestProxyBase):
3115         (WebTestRunner::WebTestProxy::setStatusText):
3116         (WebTestRunner::WebTestProxy::didStopLoading):
3117         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3118         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
3119         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
3120         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3121         (WebTestRunner::TestRunner::TestRunner):
3122         (WebTestRunner::TestRunner::reset):
3123         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
3124         (WebTestRunner):
3125         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
3126         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
3127         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
3128         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3129         (TestRunner):
3130         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3131         (WebTestRunner::WebTestProxyBase::setStatusText):
3132         (WebTestRunner):
3133         (WebTestRunner::WebTestProxyBase::didStopLoading):
3134         * DumpRenderTree/chromium/WebViewHost.cpp:
3135         (WebViewHost::didStopLoading):
3136         * DumpRenderTree/chromium/WebViewHost.h:
3137         (WebViewHost):
3138
3139 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
3140
3141         Web Inspector: devtools front-end doesn't have focus in TestShell
3142         https://bugs.webkit.org/show_bug.cgi?id=106778
3143
3144         Reviewed by Pavel Feldman.
3145
3146         Focus devTools window after loadURL method.
3147
3148         * DumpRenderTree/chromium/TestShell.cpp:
3149         (TestShell::runFileTest):
3150
3151 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3152
3153         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
3154         https://bugs.webkit.org/show_bug.cgi?id=106573
3155
3156         Reviewed by Philippe Normand.
3157
3158         Similarly to what's been described in bug 106569, we're building
3159         from release tarballs, so there's no reason to regenerate the
3160         autoconf-related stuff with autogen.sh, especially since we might
3161         run into trouble with automake 1.13 and deprecated macros.
3162
3163         * efl/jhbuild.modules:
3164
3165 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
3166
3167         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
3168         https://bugs.webkit.org/show_bug.cgi?id=104909
3169
3170         Reviewed by Simon Hausmann.
3171
3172         To be able to build redistribuable binary packages, Qt's configure switches
3173         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
3174         dynamically link to optional system libraries.
3175         QtWebKit is doing its own configure checks for those libraries, thus adding a
3176         runtime dependency that might not be fulfilled if the packager's machine had
3177         those libraries while the user's machine won't.
3178
3179         Since in most cases where WebKit will want to use those system libraries, Qt will
3180         also be using them, remove these configure tests from WebKit.
3181
3182         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
3183         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
3184         * qmake/config.tests/libpng/libpng.cpp: Removed.
3185         * qmake/config.tests/libpng/libpng.pro: Removed.
3186         * qmake/mkspecs/features/features.prf:
3187
3188 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3189
3190         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
3191         https://bugs.webkit.org/show_bug.cgi?id=106574
3192
3193         Reviewed by Laszlo Gombos.
3194
3195         Rely on a more recent stable release, which includes support for
3196         Lua 5.2 in Edje and other assorted minor fixes.
3197
3198         While here, also use the "configure" script to build the libraries
3199         instead of relying on autogen.sh, which is not really needed with
3200         a release tarball and may have problems with automake 1.13.
3201
3202         * efl/jhbuild.modules:
3203
3204 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
3205
3206         Web Inspector: fix DRT to deliver simulated events to devtools front-end
3207         https://bugs.webkit.org/show_bug.cgi?id=106650
3208
3209         Reviewed by Pavel Feldman.
3210
3211         Add separated m_devToolsTestInterfaces object to testShell which is
3212         bind to devTools webview.
3213
3214         * DumpRenderTree/chromium/TestShell.cpp:
3215         (TestShell::initialize):
3216         (TestShell::createMainWindow):
3217         (TestShell::~TestShell):
3218         (TestShell::showDevTools):
3219         (TestShell::resetTestController):
3220         (TestShell::bindJSObjectsToWindow):
3221         (TestShell::createNewWindow):
3222         * DumpRenderTree/chromium/TestShell.h:
3223         (TestShell):
3224
3225 2013-01-14  Alan Cutter  <alancutter@chromium.org>
3226
3227         Sheriffbot command aliases need test cases
3228         https://bugs.webkit.org/show_bug.cgi?id=106754
3229
3230         Reviewed by Eric Seidel.
3231
3232         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3233         (SheriffBotTest.test_command_aliases):
3234
3235 2013-01-13  Alan Cutter  <alancutter@chromium.org>
3236
3237         Allow users to misspell the "sheriffs" command in sheriffbot
3238         https://bugs.webkit.org/show_bug.cgi?id=106628
3239
3240         Reviewed by Steve Block.
3241
3242         * Scripts/webkitpy/tool/bot/irc_command.py:
3243
3244 2013-01-13  Alan Cutter  <alancutter@chromium.org>
3245
3246         Make "gardeners" an alias for "sheriffs" in sherrifbot
3247         https://bugs.webkit.org/show_bug.cgi?id=106627
3248
3249         Reviewed by Eric Seidel.
3250
3251         * Scripts/webkitpy/tool/bot/irc_command.py:
3252
3253 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
3254
3255         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
3256         https://bugs.webkit.org/show_bug.cgi?id=105380
3257
3258         Reviewed by Eric Seidel.
3259
3260         Fix a regression introduced in r137692 where we were double-encoding
3261         the arguments to popen(); this was only an issue on windows, where
3262         we would try to encode something to mbcs, then try to encode it
3263         to unicode as if the input as ascii.
3264
3265         * Scripts/webkitpy/common/system/executive.py:
3266         (Executive.run_command):
3267
3268 2013-01-13  Alan Cutter  <alancutter@chromium.org>
3269
3270         State who told sheriffbot to roll the Chromium deps and to what revision
3271         https://bugs.webkit.org/show_bug.cgi?id=106626
3272
3273         Reviewed by Eric Seidel.
3274
3275         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
3276
3277         * Scripts/webkitpy/tool/bot/irc_command.py:
3278         (RollChromiumDEPS._expand_irc_nickname):
3279         (RollChromiumDEPS.execute):
3280         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3281         (IRCCommandTest.test_roll_chromium_deps):
3282         * Scripts/webkitpy/tool/bot/sheriff.py:
3283         (Sheriff.post_chromium_deps_roll):
3284         * Scripts/webkitpy/tool/commands/roll.py:
3285         (RollChromiumDEPS._prepare_state):
3286         (PostChromiumDEPSRoll):
3287         (PostChromiumDEPSRoll._prepare_state):
3288         * Scripts/webkitpy/tool/commands/roll_unittest.py:
3289         (PostRollCommandsTest.test_prepare_state):
3290         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
3291         (PrepareChangeLogForDEPSRoll.run):
3292
3293 2013-01-13  Alan Cutter  <alancutter@chromium.org>
3294
3295         Add Alan Cutter as contributor
3296         https://bugs.webkit.org/show_bug.cgi?id=106747
3297
3298         Reviewed by Eric Seidel.
3299
3300         * Scripts/webkitpy/common/config/committers.py:
3301
3302 2013-01-13  Jonathan Liu  <net147@gmail.com>
3303
3304         Fix CONFIG missing link_pkgconfig on Windows
3305         https://bugs.webkit.org/show_bug.cgi?id=106647
3306
3307         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
3308         properly on Windows because they are added to PKGCONFIG but
3309         CONFIG does not contain link_pkgconfig.
3310
3311         This is because link_pkgconfig is added in unix/default_pre.prf
3312         which is only used for UNIX platforms. To fix this, move it to
3313         the general default_pre.prf.
3314
3315         Reviewed by Simon Hausmann.
3316
3317         * qmake/mkspecs/features/default_pre.prf:
3318         * qmake/mkspecs/features/unix/default_pre.prf:
3319
3320 2013-01-12  Nico Weber  <thakis@chromium.org>
3321
3322         nrwt/chromium: Don't prefer chromium over webkit build directories
3323         https://bugs.webkit.org/show_bug.cgi?id=105597
3324
3325         Reviewed by Dirk Pranke.
3326
3327         Rely on the new timestamp logic instead. Requested by dpranke in
3328         https://bugs.webkit.org/show_bug.cgi?id=105498
3329
3330         * Scripts/webkitpy/layout_tests/port/chromium.py:
3331         (ChromiumPort._static_build_path):
3332         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3333         (ChromiumLinuxPortTest.test_build_path):
3334         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3335         (ChromiumMacPortTest.test_build_path):
3336         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3337         (ChromiumWinTest.test_build_path):
3338
3339 2013-01-12  Nico Weber  <thakis@chromium.org>
3340
3341         Use ninja by default on Linux for build-webkit --chromium, bot edition
3342         https://bugs.webkit.org/show_bug.cgi?id=104434
3343
3344         Reviewed by Eric Seidel.
3345
3346         r139557 changed update-webkit to pick ninja by default on linux, but
3347         the bots run update-webkit-chromium directly so they didn't see this.
3348         Move the default for ninja into update-webkit-chromium so that it's
3349         picked up by the bots, and let update-webkit forward non-default
3350         options to there.
3351
3352         This way, the default is in one place only and both developers (who
3353         usually use update-webkit which then shells out to
3354         updat-webkit-chromium) and bots (which use update-webkit-chromium
3355         directly) see the same behavior.
3356
3357         * Scripts/update-webkit:
3358         * Scripts/update-webkit-chromium:
3359
3360 2013-01-12  Nico Weber  <thakis@chromium.org>
3361
3362         Make ninja the default build system on Linux for build-webkit --chromium
3363         https://bugs.webkit.org/show_bug.cgi?id=104434
3364
3365         Reviewed by Eric Seidel.
3366
3367         * Scripts/update-webkit:
3368
3369 2013-01-12  Alan Cutter  <alancutter@chromium.org>
3370
3371         Migrate the remaining bots in EC2 to Google Compute Engine
3372         https://bugs.webkit.org/show_bug.cgi?id=106005
3373
3374         Reviewed by Eric Seidel.
3375
3376         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
3377
3378         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
3379         * EWSTools/boot.sh:
3380         * EWSTools/build-repo.sh:
3381         * EWSTools/start-queue.sh:
3382
3383 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
3384
3385         [chromium] move inspector related methods to TestRunner library
3386         https://bugs.webkit.org/show_bug.cgi?id=106654
3387
3388         Reviewed by Adam Barth.
3389
3390         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3391         (DRTTestRunner::DRTTestRunner):
3392         * DumpRenderTree/chromium/DRTTestRunner.h:
3393         (DRTTestRunner):
3394         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3395         (WebTestRunner::WebTestDelegate::showDevTools):
3396         (WebTestRunner::WebTestDelegate::closeDevTools):
3397         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
3398         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3399         (WebTestRunner::TestRunner::TestRunner):
3400         (WebTestRunner::TestRunner::showWebInspector):
3401         (WebTestRunner):
3402         (WebTestRunner::TestRunner::closeWebInspector):
3403         (WebTestRunner::TestRunner::evaluateInWebInspector):
3404         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3405         (TestRunner):
3406         * DumpRenderTree/chromium/WebViewHost.cpp:
3407         (WebViewHost::showDevTools):
3408         (WebViewHost::closeDevTools):
3409         (WebViewHost::evaluateInWebInspector):
3410         * DumpRenderTree/chromium/WebViewHost.h:
3411         (WebViewHost):
3412
3413 2013-01-11  Julie Parent  <jparent@chromium.org>
3414
3415         Builder should not be a valid parameter for stats dashboard
3416         https://bugs.webkit.org/show_bug.cgi?id=106698
3417
3418         Reviewed by Dirk Pranke.
3419         
3420         Since builder is a dashboard specific parameter, dashboard_base
3421         should not be handling it in handleValidHashParameterWrapper, rather,
3422         each specific dashboard should in its handleValidHashParameter function.
3423     
3424         Note that the FIXME in dashboard_base about this was actually wrong -
3425         we don't want to move it to g_crossDashboardState, because it isn't
3426         actually cross dashboard state.
3427         
3428         In fact, flakiness and treemap have the code in 
3429         handleValidHashParameter, but it is currently dead code because 
3430         dashboard_base gets to it first.
3431         
3432         Added the proper handling to timeline_explorer, since builder is
3433         valid there.
3434
3435         * TestResultServer/static-dashboards/dashboard_base.js:
3436         * TestResultServer/static-dashboards/timeline_explorer.html:
3437
3438 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
3439
3440         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
3441         https://bugs.webkit.org/show_bug.cgi?id=106688
3442
3443         Reviewed by Eric Seidel.
3444
3445         Update the regular expression used to strip the garbage at the beginning.
3446
3447         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3448         (RunWebKitTests.nrwt_log_message_regexp):
3449
3450 2013-01-11  Pratik Solanki  <psolanki@apple.com>
3451
3452         TestRunner leaks when running tests
3453         https://bugs.webkit.org/show_bug.cgi?id=106683
3454
3455         Reviewed by Simon Fraser.
3456
3457         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
3458         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
3459         tests.
3460
3461         * DumpRenderTree/TestRunner.cpp:
3462         (TestRunner::makeWindowObject):
3463
3464 2013-01-11  Julie Parent  <jparent@chromium.org>
3465
3466         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
3467         https://bugs.webkit.org/show_bug.cgi?id=106247
3468
3469         Old code nulled out the loader instance when it completed loading and
3470         then later used the fact that it was null to determine if it had loaded
3471         or not.  This is not only unintuitive, but it also prevents using the
3472         loader object later on.
3473         
3474         Added new method, used it, added unit test for it.
3475         
3476         Reviewed by Dirk Pranke.
3477
3478         * TestResultServer/static-dashboards/dashboard_base.js:
3479         (resourceLoadingComplete):
3480         (handleLocationChange):
3481         * TestResultServer/static-dashboards/loader.js:
3482         (.):
3483         * TestResultServer/static-dashboards/loader_unittests.js:
3484
3485 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
3486
3487         Try CRLF to LF change in r139407 again.
3488
3489         * BuildSlaveSupport/delete-stale-build-files:
3490         (main):
3491         (webkitBuildDirectory):
3492         * BuildSlaveSupport/kill-old-processes:
3493         (main):
3494
3495 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3496
3497         [GTK] Disable the unit tests timeout when running from make check
3498         https://bugs.webkit.org/show_bug.cgi?id=106670
3499
3500         Reviewed by Philippe Normand.
3501
3502         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
3503
3504 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3505
3506         Yet another unreviewed fix after r139431.
3507
3508         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
3509         the correct order.
3510
3511 2013-01-11  Dan Carney  <dcarney@google.com>
3512
3513         [chromium] move some whitespace and resize related methods to TestRunner library
3514         https://bugs.webkit.org/show_bug.cgi?id=106655
3515
3516         Reviewed by Jochen Eisinger.
3517
3518         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3519         (DRTTestRunner::DRTTestRunner):
3520         * DumpRenderTree/chromium/DRTTestRunner.h:
3521         (DRTTestRunner):
3522         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3523         (WebKit):
3524         (WebTestRunner::WebTestDelegate::setClientWindowRect):
3525         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
3526         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
3527         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3528         (WebTestRunner::TestRunner::TestRunner):
3529         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
3530         (WebTestRunner):
3531         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
3532         (WebTestRunner::TestRunner::enableAutoResizeMode):
3533         (WebTestRunner::TestRunner::disableAutoResizeMode):
3534         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3535         (TestRunner):
3536         * DumpRenderTree/chromium/WebViewHost.cpp:
3537         (WebViewHost::setClientWindowRect):
3538         * DumpRenderTree/chromium/WebViewHost.h:
3539         (WebViewHost):
3540
3541 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
3542
3543         Unreviewed. Update my e-mail addresses.
3544
3545         * Scripts/webkitpy/common/config/committers.py:
3546
3547 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3548
3549         Another unreviewed fix after r139431.
3550
3551         In a way, this is also a generic bug fix, since previously isEfl()
3552         would fail when called from run-efl-tests and we thus did not use
3553         jhbuild to run our tests. This now resulted in us calling
3554         "jhbuild-wrapper run" without specifying a platform.
3555
3556         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
3557         to work.
3558
3559 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3560
3561         [Qt][WK1] Web Audio support
3562         https://bugs.webkit.org/show_bug.cgi?id=106651
3563
3564         Reviewed by Jocelyn Turcotte.
3565
3566         Implements support for dumping audio data in DumpRenderTree.
3567
3568         Adds WebAudio to toggleable features in QtTestBrowser.
3569
3570         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
3571         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
3572
3573         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3574         (WebCore::DumpRenderTree::dump):
3575         * DumpRenderTree/qt/TestRunnerQt.cpp:
3576         (TestRunner::reset):
3577         (TestRunner::overridePreference):
3578         (TestRunner::setAudioData):
3579         * DumpRenderTree/qt/TestRunnerQt.h:
3580         (TestRunner::shouldDumpAsAudio):
3581         (TestRunner::audioData):
3582         (TestRunner):
3583         * QtTestBrowser/launcherwindow.cpp:
3584         (LauncherWindow::applyPrefs):
3585         (LauncherWindow::createChrome):
3586         (LauncherWindow::toggleWebAudio):
3587         * QtTestBrowser/launcherwindow.h:
3588         (WindowOptions::WindowOptions):
3589         (WindowOptions):
3590         (LauncherWindow):
3591         * qmake/mkspecs/features/features.prf:
3592         * qmake/mkspecs/features/features.pri:
3593
3594 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3595
3596         Unreviewed jhbuild-related fix after r139431.
3597
3598         * Scripts/webkitpy/layout_tests/port/efl.py:
3599         (EflPort.__init__): Pass a string to set_option_default(), since
3600         shlex.split() will be called on it later.
3601
3602 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
3603
3604         Unreviewed typo fixes after r139431.
3605
3606         * Scripts/run-javascriptcore-tests:
3607
3608 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3609
3610         [jhbuild] Remove the "run-with-jhbuild" scripts.
3611         https://bugs.webkit.org/show_bug.cgi?id=106572
3612
3613         Reviewed by Martin Robinson.
3614
3615         Both ports which use jhbuild were mostly duplicating the
3616         `run-with-jhbuild' script in their own directories for no clear reason.
3617
3618         The script itself was just a thin wrapper around the `jhbuild-wrapper',
3619         so just start using that directly and get rid of a useless middle man.
3620
3621         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
3622         instead.
3623
3624         * Scripts/run-javascriptcore-tests:
3625         * Scripts/run-launcher:
3626         * Scripts/webkitdirs.pm:
3627         (runAutogenForAutotoolsProjectIfNecessary):
3628         (buildAutotoolsProject):
3629         (jhbuildWrapperPrefixIfNeeded):
3630         (generateBuildSystemFromCMakeProject):
3631         (buildCMakeGeneratedProject):
3632         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
3633         (run):
3634         * Scripts/webkitpy/layout_tests/port/efl.py:
3635         (EflPort.__init__):
3636         (EflPort._image_diff_command):
3637         * efl/run-with-jhbuild: Removed.
3638         * gtk/run-with-jhbuild: Removed.
3639
3640 2013-01-11  Alan Cutter  <alancutter@chromium.org>
3641
3642         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
3643         https://bugs.webkit.org/show_bug.cgi?id=106636
3644
3645         Reviewed by Adam Barth.
3646
3647         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
3648
3649         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3650         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3651         * EWSTools/screen-config:
3652         * EWSTools/start-queue.sh:
3653
3654 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3655
3656         kill-old-processes and delete-stale-build-files use CRLF linebreaks
3657         https://bugs.webkit.org/show_bug.cgi?id=106622
3658
3659         Reviewed by Simon Fraser.
3660
3661         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
3662         Also escape clang\+\+ correctly in kill-old-processes.
3663
3664         * BuildSlaveSupport/delete-stale-build-files:
3665         * BuildSlaveSupport/kill-old-processes:
3666
3667 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3668
3669         Build fix after r139357. It was missing a comma.
3670
3671         * QueueStatusServer/model/queues.py:
3672         (Queue):
3673
3674 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3675
3676         Fixing AuthenticationError when running test-webkitpy as a non-committer.
3677         https://bugs.webkit.org/show_bug.cgi?id=106420
3678
3679         Reviewed by Eric Seidel.
3680
3681         * Scripts/webkitpy/common/checkout/scm/git.py:
3682         (Git.push_local_commits_to_server):
3683         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3684         * Scripts/webkitpy/common/checkout/scm/svn.py:
3685         (SVNRepository):
3686         (SVNRepository.has_authorization_for_realm):
3687
3688 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
3689