91835085d3ca7c7ff0f0ba08841596d91000b3e9
[WebKit-https.git] / Tools / ChangeLog
1 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2
3         [EFL][GTK] Make it possible to get verbose output with ninja
4         https://bugs.webkit.org/show_bug.cgi?id=137606
5
6         Reviewed by Csaba Osztrogonác.
7
8         * Scripts/webkitdirs.pm:
9         (buildCMakeGeneratedProject):
10
11 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
12
13         [EFL] Make it possible to use ninja for EFL build too
14         https://bugs.webkit.org/show_bug.cgi?id=137605
15
16         Reviewed by Csaba Osztrogonác.
17
18         * Scripts/webkitdirs.pm:
19         (generateBuildSystemFromCMakeProject):
20         * efl/install-dependencies:
21
22 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
23
24         [GTK] Minibrowser : Add home buton and keyboard support for home page load
25         https://bugs.webkit.org/show_bug.cgi?id=137486
26
27         Reviewed by Philippe Normand.
28
29         * MiniBrowser/gtk/BrowserWindow.c:
30         (loadHomePage): Callback for home page load.
31         (browser_window_init):
32         * MiniBrowser/gtk/BrowserWindow.h:
33         * MiniBrowser/gtk/main.c:
34         (main):
35
36 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
37
38         import-w3c-tests doesn't prefix property values
39         https://bugs.webkit.org/show_bug.cgi?id=137600
40
41         Reviewed by Bem Jones-Bey.
42
43         Some property values are prefixed in WebKit. Modified the W3C import
44         script in order to prefix property values and not only properties.
45         The patch re-uses most of the already existent logic to prefix
46         properties.
47
48         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
49         from CSSValueKeywords.in and adapt converter to modify both properties
50         and property values.
51         (convert_for_webkit):
52         (_W3CTestConverter.__init__):
53         (_W3CTestConverter.output):
54         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
55         (_W3CTestConverter):
56         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
57         (_W3CTestConverter.add_webkit_prefix_following_regex):
58         (_W3CTestConverter.convert_reference_relpaths):
59         (_W3CTestConverter.convert_style_data):
60         (_W3CTestConverter.convert_attributes_if_needed):
61         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
62         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
63         include checks for property values too.
64         (W3CTestConverterTest.test_read_prefixed_property_list):
65         (verify_no_conversion_happened):
66         (verify_prefixed_properties):
67         (verify_prefixed_property_values):
68         (generate_test_content_properties_and_values):
69         (generate_test_content):
70         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
71         prefixed property values and inform about them.
72         (TestImporter.import_tests):
73         (TestImporter.write_import_log):
74
75 2014-10-13  Jer Noble  <jer.noble@apple.com>
76
77         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
78         https://bugs.webkit.org/show_bug.cgi?id=137533
79
80         Reviewed by Andy Estes.
81
82         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
83
84         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
85         (TestWebKitAPI::isMSEEnabledCallback):
86         (TestWebKitAPI::TEST):
87
88 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
89
90         [Win] Implement a page load profiling tool
91         https://bugs.webkit.org/show_bug.cgi?id=137673
92
93         Reviewed by Dean Jackson.
94
95         Add a tool to capture and summarize page load statistics.
96
97         * WinLauncher/Common.cpp:
98         (parseCommandLine): Move from WinMain.cpp so that it can
99         be shared with internal tools.
100         * WinLauncher/PageLoadTestClient.cpp: Added.
101         (PageLoadTestClient::PageLoadTestClient):
102         (PageLoadTestClient::pageLoadStartedAtTime):
103         (PageLoadTestClient::didStartProvisionalLoad):
104         (PageLoadTestClient::didCommitLoad):
105         (PageLoadTestClient::didFirstLayoutForMainFrame):
106         (PageLoadTestClient::didHandleOnLoadEvents):
107         (PageLoadTestClient::didFinishLoad):
108         (PageLoadTestClient::didFailLoad):
109         (PageLoadTestClient::didInitiateResourceLoad):
110         (PageLoadTestClient::didEndResourceLoad):
111         (PageLoadTestClient::pageLoadEndedAtTime):
112         (PageLoadTestClient::endPageLoad):
113         (PageLoadTestClient::clearPageLoadState):
114         (PageLoadTestClient::shouldConsiderPageLoadEnded):
115         (PageLoadTestClient::maybeEndPageLoadSoon):
116         (PageLoadTestClient::setPageURL):
117         (PageLoadTestClient::dumpRunStatistics):
118         * WinLauncher/PrintWebUIDelegate.cpp:
119         (PrintWebUIDelegate::createWebViewWithRequest): Handle
120         nullptr URL properly.
121         * WinLauncher/ResourceLoadDelegate.cpp: Added.
122         (ResourceLoadDelegate::QueryInterface):
123         (ResourceLoadDelegate::AddRef):
124         (ResourceLoadDelegate::Release):
125         (ResourceLoadDelegate::identifierForInitialRequest):
126         (ResourceLoadDelegate::willSendRequest):
127         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
128         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
129         (ResourceLoadDelegate::didReceiveResponse):
130         (ResourceLoadDelegate::didReceiveContentLength):
131         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
132         (ResourceLoadDelegate::didFailLoadingWithError):
133         (ResourceLoadDelegate::plugInFailedWithError):
134         * WinLauncher/ResourceLoadDelegate.h: Added.
135         (ResourceLoadDelegate::ResourceLoadDelegate):
136         * WinLauncher/WinLauncher.cpp:
137         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
138         page loading statistics.
139         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
140         and set private load delegate state.
141         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
142         that sets the view's resource load delegate.
143         (WinLauncher::loadURL): If no URL is passed, load the test document.
144         * WinLauncher/WinLauncher.h:
145         (WinLauncher::pageLoadTestClient):
146         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
147         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
148         * WinLauncher/WinLauncherWebHost.cpp:
149         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
150         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
151         it could be used from other source files.
152         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
153         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
154         (WinLauncherWebHost::didFailLoadWithError): Ditto.
155         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
156         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
157         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
158         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
159         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
160         * WinLauncher/WinLauncherWebHost.h:
161         * WinLauncher/WinMain.cpp:
162         (wWinMain): Create and use new delegates for gathering page load data.
163         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
164
165 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
166
167         Improve the test image diffs page
168         https://bugs.webkit.org/show_bug.cgi?id=137674
169
170         Reviewed by Alexey Proskuryakov.
171         
172         Don't treat the input file as a format string, otherwise we have to escape special
173         characters. Just do a couple of replaces.
174
175         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
176         (TestResultWriter.write_image_diff_files):
177
178 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
179
180         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
181         https://bugs.webkit.org/show_bug.cgi?id=137659
182
183         Reviewed by Martin Robinson.
184
185         * Scripts/webkitpy/port/xvfbdriver.py:
186         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
187
188 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
189
190         Add more detailed wait time information to EWS metrics
191         https://bugs.webkit.org/show_bug.cgi?id=137649
192
193         Reviewed by Daniel Bates.
194
195         Added average and worst time (we used to only have median), and also a percentage
196         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
197
198         There is always some wait due to the polling nature of the queues, which is well understood
199         and doesn't need to be measured. What needs to be measured is whether there is enough
200         bot machines to process patches as soon as they are submitted.
201
202         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
203         (Analyzer.prototype._analyzeBubblePerformance):
204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
205         (MetricsBubbleView.prototype._update):
206
207 2014-10-11  Jer Noble  <jer.noble@apple.com>
208
209         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
210         https://bugs.webkit.org/show_bug.cgi?id=137533
211
212         Reviewed by Darin Adler.
213
214         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
215         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
216         (TestWebKitAPI::TEST):
217         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
218         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
219
220 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
221
222         iOS DRT snapshots are limited to the page visible area
223         https://bugs.webkit.org/show_bug.cgi?id=137650
224
225         Reviewed by Daniel Bates.
226         
227         LegacyTileCache drawing was limited to the window's visible area, found by
228         crawling up the layer hierarchy to the root layer. This caused test snapshots to
229         be missing non-composited content outside the iPhone visible area, which hinders
230         testing.
231         
232         Fix by adding a test-only mode where the window visible area is the entire window.
233         
234         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
235         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
236         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
237         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
238         for the DRT window.
239         
240
241 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
242
243         Page not fully rendered in iOS DRT snapshots
244         https://bugs.webkit.org/show_bug.cgi?id=137638
245
246         Reviewed by Tim Horton.
247         
248         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
249         to ensure that the page has laid out and is rendered by the time we take
250         the snapshot.
251
252         * DumpRenderTree/mac/DumpRenderTree.mm:
253         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
254         (-[DumpRenderTree _webThreadInvoked]): Moved.
255         (-[DumpRenderTree _waitForWebThreadThenDump]):
256         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
257         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
258         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
259         relies on dispatch_async too, and the inner block won't complete until the outer block
260         has completed.
261         (dumpTestResults): Move the guts of dump() here.
262         (runTest): Whitespace.
263
264 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
265
266         Adding svn:ignore so that .pyc files don't show up as new.
267
268         * Scripts/webkitpy/xcode: Added property svn:ignore.
269
270 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
271
272         [EFL] Introduce EWebKit_Extension
273         https://bugs.webkit.org/show_bug.cgi?id=134921
274
275         Reviewed by Gyuyoung Kim.
276
277         * MiniBrowser/efl/main.c: Added x option to test extension path.
278         (window_create):
279         (elm_main):
280         * Scripts/webkitpy/common/config/watchlist:
281         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
282         * Scripts/webkitpy/style/checker.py:
283         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
284
285 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
286
287         After r174628 we send the test process a SIGTERM before the SIGKILL.
288
289         * Scripts/webkitpy/common/system/executive_unittest.py:
290         (ExecutiveTest.serial_test_kill_process):
291
292 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
293
294         [EFL] Enable WebP support.
295         https://bugs.webkit.org/show_bug.cgi?id=136156
296
297         Reviewed by Gyuyoung Kim.
298
299         Include libwebp-dev package to support WebP for WK2 Efl.
300
301         * efl/install-dependencies:
302
303 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
304
305         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
306         https://bugs.webkit.org/show_bug.cgi?id=137485
307
308         Reviewed by Sergio Villar Senin.
309
310         Update GMainLoopSource tests. Most of the tests are now run twice,
311         first with a GMainLoopSource and then with a
312         GThreadSafeMainLoopSource, since both should have the same
313         behaviour. The threading test uses GThreadSafeMainLoopSource and
314         the delete on destroy test uses GMainLoopSource. The tests
315         themselves haven't changed, since there's no change in behaviour.
316
317         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
318         (TestWebKitAPI::GMainLoopSourceTest::source):
319         (TestWebKitAPI::basicRescheduling):
320         (TestWebKitAPI::TEST):
321         (TestWebKitAPI::reentrantRescheduling):
322         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
323         (TestWebKitAPI::basicDestroyCallbacks):
324         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
325         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
326
327 2014-10-10  Dana Burkart  <dburkart@apple.com>
328
329         Fix fat-fingered function name in git-add-reviewer.
330
331         Unreviewed.
332
333         * Scripts/git-add-reviewer:
334         (getConfigValue):
335
336 2014-10-10  David Farler  <dfarler@apple.com>
337
338         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
339         https://bugs.webkit.org/show_bug.cgi?id=137528
340
341         Reviewed by Simon Fraser.
342
343         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
344         and SIGKILL the paired simulator app before exiting cleanly.
345
346         webkitpy only uses SIGKILL to kill processes which you cannot
347         catch. Send SIGTERM to the process and give it chance to do
348         its thing before sending SIGKILL. Sending a SIGKILL to an already
349         dead PID is safe.
350
351         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
352         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
353         (-[LTRelayController finish]):
354         * LayoutTestRelay/LayoutTestRelay/main.m:
355         (receivedSignal):
356         (main):
357
358 2014-10-10  David Farler  <dfarler@apple.com>
359
360         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
361         https://bugs.webkit.org/show_bug.cgi?id=137527
362
363         Reviewed by Simon Fraser.
364
365         NSFileHandle doesn't notify of EOF in its readability handler.
366         Use a dispatch_source_t and an event handler that is called when reading is possible.
367         In the handler block, do a run-of-the-mill read(2) from standard input and
368         detect EOF in the usual way by checking that zero bytes were read.
369
370         Once an EOF is received, the FIFOs are disconnected, the simulator app
371         is killed, and the relay exits with status 0.
372
373         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
374         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
375         (-[LTRelayController didDisconnect]):
376         (-[LTRelayController didConnect]):
377         (-[LTRelayController launchApp]):
378         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
379         confusion with this new dispatch source, called "standardInputDispatchSource".
380         (-[LTRelayController finish]): Added.
381         (-[LTRelayController readFileHandle:]): Deleted.
382
383 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
384
385         [EFL] Crash on facebook.com
386         https://bugs.webkit.org/show_bug.cgi?id=137562
387
388         Reviewed by Chris Dumez.
389
390         Crash occurs on the facebook.com when the webview is resized
391         after the <select> item is clicked but no item is chosen.
392         This crash is just caused by the reference of invalidated variable.
393         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
394         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
395         on MiniBrowser is called.
396         As a result, just set ewk_menu to NULL in order to prevent crash condition.
397
398         * MiniBrowser/efl/main.c:
399         (on_popup_menu_hide):
400
401 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
402
403         A small wording change for clarity.
404
405         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
406         (MetricsBubbleView.prototype._update):
407
408 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
409
410         Dashboard metrics page should have EWS statistics
411         https://bugs.webkit.org/show_bug.cgi?id=137626
412
413         Reviewed by Ryosuke Niwa.
414
415         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
416         (BubbleQueue): Put shortName in the object, so that it's actually useful.
417
418         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
419         (BubbleQueueServer): Re-ordered queues to match bubble order.
420         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
421         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
422
423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
424         Added analysis for bubble queues.
425
426         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
427
428         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
429         (buildBubbleQueuesTable): Build the UI.
430
431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
432         Added JS sources to load.
433
434         * QueueStatusServer/app.yaml: To update app version.
435
436         * QueueStatusServer/handlers/processingtimesjson.py: Added.
437
438         * QueueStatusServer/main.py: Added a handler for processing-times-json.
439
440 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
441
442         REGRESSION: Commit queue doesn't process rollouts
443         https://bugs.webkit.org/show_bug.cgi?id=137623
444
445         Reviewed by Tim Horton.
446
447         * QueueStatusServer/app.yaml:
448         * QueueStatusServer/handlers/updateworkitems.py:
449         (UpdateWorkItems._work_items_from_request):
450
451 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
452
453         Fix syntax error after r174601.
454
455         * Scripts/run-javascriptcore-tests:
456
457 2014-10-10  Michael Saboff  <msaboff@apple.com>
458
459         Add ability to select tarfile name in run-jsc-stress-tests
460         https://bugs.webkit.org/show_bug.cgi?id=137614
461
462         Reviewed by Mark Hahnenberg.
463
464         Added optional file name argument to the --tarball option.  
465
466         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
467         extra test given after the options wont be used for the optional tarball file name.
468         * Scripts/run-jsc-stress-tests:
469
470 2014-10-10  Chris Dumez  <cdumez@apple.com>
471
472         Unreviewed, update my information in contributors.json
473
474         Use my preferred first name and update my expertise areas.
475
476         * Scripts/webkitpy/common/config/contributors.json:
477
478 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
479
480         Fix perl scripts to run with env on Linux
481         https://bugs.webkit.org/show_bug.cgi?id=137601
482
483         Reviewed by Csaba Osztrogonác.
484
485         Use of arguments in #! is nonstandard and does not behave the same on
486         different systems. Linux would look for an executable named "perl -w" 
487         "use warnings;" does the same things in a more portable way.
488
489         * Scripts/commit-log-editor:
490         * Scripts/num-cpus:
491         * Scripts/prepare-ChangeLog:
492         * Scripts/run-launcher:
493         * Scripts/svn-create-patch:
494
495 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
496
497         [jhbuild] We should be able to disable wiping on configuration change
498         https://bugs.webkit.org/show_bug.cgi?id=137446
499
500         Reviewed by Csaba Osztrogonác.
501
502         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
503         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
504         or passing --no-wipe-on-change command line option.
505
506         * Scripts/update-webkit-libs-jhbuild:
507
508 2014-10-09  Andy Estes  <aestes@apple.com>
509
510         Teach webkitpy about OS X Yosemite
511         https://bugs.webkit.org/show_bug.cgi?id=137585
512
513         Reviewed by Simon Fraser.
514
515         * Scripts/webkitpy/common/system/platforminfo.py:
516         (PlatformInfo._determine_mac_version):
517         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
518         (TestPlatformInfo.test_os_version):
519         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
520         (TestExpectationParser):
521         * Scripts/webkitpy/port/builders.py:
522         * Scripts/webkitpy/port/mac.py:
523         (MacPort):
524         * Scripts/webkitpy/port/mac_unittest.py:
525         (test_versions):
526         (test_baseline_search_path):
527         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
528         (TestRebaselineTest.test_baseline_directory):
529         (TestRebaselineExpectations.test_rebaseline_expectations):
530
531 2014-10-09  Dana Burkart  <dburkart@apple.com>
532
533         Add Mac OS Yosemite dashboard support.
534
535         Rubber-stamped by Lucas Forschler.
536
537         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
538         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
539         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
540         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
541         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
542
543 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
544
545         Add Babak to contributors.json and add historical email addresses for some contributors
546         https://bugs.webkit.org/show_bug.cgi?id=137546
547
548         Reviewed by Christophe Dumez.
549
550         contributors.json is used to analyze historical commit data and change logs.
551
552         Add back historical email addresses for some contributors and also add Babak (Shafiei).
553
554         * Scripts/webkitpy/common/config/contributors.json:
555
556 2014-10-09  Lucas Forschler  <lforschler@apple.com>
557
558         Add Mac OS Yosemite webkit build infrastructure.
559         
560         This patch adds 15 bots to our build.webkit.org configuration.
561         We are matching the current Mavericks machines 1:1.
562         
563         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
564         
565         Reviewed by Matt Hanson.
566
567         * BuildSlaveSupport/build.webkit.org-config/config.json:
568
569 2014-10-09  Dana Burkart  <dburkart@apple.com>
570
571         Don't use backticks when running commands, as we run into sh-related
572         interpolation issues. Also, fix our usage of system() to properly
573         retrieve the status code.
574         https://bugs.webkit.org/show_bug.cgi?id=137541
575
576         Reviewed by Darin Adler.
577
578         * Scripts/git-add-reviewer:
579         (interactive):
580         (nonInteractive):
581         (requireCleanWorkTree):
582         (cherryPick):
583         (commit):
584         (addReviewerToFile):
585         (head):
586         (isAncestor):
587         (toCommit):
588         (changeLogsForCommit):
589         (resetToCommit):
590         (getConfigValue):
591         (runCommandWithOutput):
592
593 2014-10-09  Tim Horton  <timothy_horton@apple.com>
594
595         Add a WebKit1 preference for selection services
596         https://bugs.webkit.org/show_bug.cgi?id=137498
597         <rdar://problem/18572699>
598
599         Reviewed by Simon Fraser.
600
601         * MiniBrowser/mac/WK1BrowserWindowController.m:
602         (-[WK1BrowserWindowController awakeFromNib]):
603         Turn on image and selection services in the Legacy WebKit MiniBrowser.
604
605 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
606
607         Get the patch scripts running on Haiku
608         https://bugs.webkit.org/show_bug.cgi?id=137559
609
610         Reviewed by Benjamin Poulain.
611
612         Use /usr/bin/env instead of hardcoding path to perl.
613         Declare haiku platform in platforminfo.py to avoid check-webkit-style
614         failure.
615
616         * Scripts/commit-log-editor:
617         * Scripts/num-cpus:
618         * Scripts/prepare-ChangeLog:
619         * Scripts/run-launcher:
620         * Scripts/svn-create-patch:
621         * Scripts/webkitpy/common/system/platforminfo.py:
622         (PlatformInfo._determine_os_name):
623
624 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
625
626         StyleQueue should throw a PatchIsNotValid exception to achieve
627         consistency with CommitQueue and EWS
628         https://bugs.webkit.org/show_bug.cgi?id=137500
629
630         Reviewed by Alexey Proskuryakov.
631
632         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
633         Adds a call to validate() in run().
634         (StyleQueueTask.run):
635         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
636         Adds a return False in the patch is not valid exception statement.
637         (AbstractEarlyWarningSystem.review_patch):
638         * Scripts/webkitpy/tool/commands/queues.py:
639         Adds a return False in the patch is not valid exception statement in
640         commit queue, and adds an except statement to catch PatchIsNotValid
641         exceptions in style queue.
642         (CommitQueue.process_work_item):
643         (StyleQueue.review_patch):
644
645 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
646
647         Race condition with WebKitWebView:is-loading after starting page load
648         https://bugs.webkit.org/show_bug.cgi?id=136692
649
650         Reviewed by Gustavo Noronha Silva.
651
652         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
653         (loadChangedCallback): Only check is-loading is false when load
654         has finished if the load didn't fail due to a cancellation.
655         (loadFailedCallback): Only check is-loading is false if the load
656         didn't fail due to a cancellation.
657         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
658         (WebViewTest::loadURI): Check is-loading is true and active URI is
659         the requested one rigth after requesting the load.
660         (WebViewTest::loadHtml): Ditto.
661         (WebViewTest::loadPlainText): Ditto.
662         (WebViewTest::loadBytes): Ditto.
663         (WebViewTest::loadRequest): Ditto.
664         (WebViewTest::loadAlternateHTML): Ditto.
665         (WebViewTest::goBack): Ditto.
666         (WebViewTest::goForward): Ditto.
667         (WebViewTest::goToBackForwardListItem): Ditto.
668
669 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
670
671         [Win] Resolve various static analyzer warnings in Tools.
672         https://bugs.webkit.org/show_bug.cgi?id=137534
673
674         Reviewed by Dean Jackson.
675
676         * DumpRenderTree/cg/ImageDiffCG.cpp:
677         (main): User proper printf specifiers.
678         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
679         (AccessibilityUIElement::childrenCount): Handle possibility that
680         gcc_accChildCount returns with an error.
681         (accessibilityState): Ditto for gcc_accState.
682         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
683         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
684         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
685         be treated as such.
686         * DumpRenderTree/win/DumpRenderTree.cpp:
687         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
688         by comparing an unsigned value as being greater-than zero.
689         * DumpRenderTree/win/EditingDelegate.cpp:
690         (dump): Pass proper character pointer type to printf.
691         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
692         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
693         (EditingDelegate::shouldInsertNode): Ditto.
694         (EditingDelegate::shouldInsertText): Ditto.
695         (EditingDelegate::shouldDeleteDOMRange): Ditto.
696         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
697         (EditingDelegate::shouldApplyStyle): Ditto.
698         * DumpRenderTree/win/EventSender.cpp:
699         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
700         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
701         system headers.
702         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
703         from CreateDIBSection.
704         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
705         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
706         older versions of MSVC we no longer support.
707         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
708         for 64-bit builds.
709         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
710         * TestWebKitAPI/TestsController.h: Ditto.
711         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
712         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
713         performing bitwise | before the comparison is done.
714
715 2014-10-08  Ada Chan  <adachan@apple.com>
716
717         Add a test for WKPageIsPlayingAudio().
718         https://bugs.webkit.org/show_bug.cgi?id=137048
719
720         Reviewed by Darin Adler.
721
722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
723         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
724         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
725         (TestWebKitAPI::nullJavaScriptCallback):
726         (TestWebKitAPI::didFinishLoadForFrame):
727         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
728         (TestWebKitAPI::setUpClients):
729         (TestWebKitAPI::TEST):
730         This test loads a page with a video in it. When the page is loaded, we first check that
731         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
732         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
733         now returns true for the page.
734         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
735         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
736         This is a video copied from LayoutTests/media/content.
737
738 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
739
740         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
741         https://bugs.webkit.org/show_bug.cgi?id=137516
742
743         Reviewed by Alexey Proskuryakov.
744
745         * Scripts/webkitpy/thirdparty/__init__.py:
746         (AutoinstallImportHook._install_irc):
747
748 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
749
750         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
751         https://bugs.webkit.org/show_bug.cgi?id=137520
752
753         Reviewed by Philippe Normand.
754
755         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
756         For other distributions, we are already installing libjpeg-turbo.
757         So, do the same for Debian and derivatives.
758
759         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
760
761 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
762
763         [webkitpy] Add back the workaround to replace ZipFile.extractall()
764         https://bugs.webkit.org/show_bug.cgi?id=137519
765
766         Reviewed by Csaba Osztrogonác.
767
768         It was removed by <http://trac.webkit.org/changeset/174266>,
769         because the comment stated it is a workaround for buggy python
770         2.6.1 which shipped on Snow Leopard. But it turned out the bug
771         is still valid with python 2.7 shipped on the latest Ubuntu
772         (12.04 and 14.04) and OS X 10.9.
773
774         * Scripts/webkitpy/common/system/autoinstall.py:
775         (AutoInstaller):
776         (AutoInstaller._extract_all):
777         (AutoInstaller._unzip):
778
779 2014-10-08  Commit Queue  <commit-queue@webkit.org>
780
781         Unreviewed, rolling out r174335.
782         https://bugs.webkit.org/show_bug.cgi?id=137515
783
784         It broke EFL layout test totally (Requested by gyuyoung on
785         #webkit).
786
787         Reverted changeset:
788
789         "[EFL] Introduce EWebKit_Extension"
790         https://bugs.webkit.org/show_bug.cgi?id=134921
791         http://trac.webkit.org/changeset/174335
792
793 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
794
795         [GTK] Make forwarding headers generation depend on source code
796         https://bugs.webkit.org/show_bug.cgi?id=137394
797
798         Reviewed by Philippe Normand.
799
800         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
801         * TestWebKitAPI/PlatformGTK.cmake: Only run
802         generate-forwarding-headers.pl when source code changes.
803         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
804
805 2014-10-07  Tanay C  <tanay.c@samsung.com>
806
807         Remove build warnings in Hashmap API tests
808         https://bugs.webkit.org/show_bug.cgi?id=137484
809
810         Reviewed by Darin Adler.
811
812         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
813         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
814
815 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
816
817         Commit queue doesn't drop obsolete patches sometimes
818         https://bugs.webkit.org/show_bug.cgi?id=137460
819
820         Reviewed by Alexey Proskuryakov.
821
822         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
823         Adds another test patch for use in queues_unittest.py.
824         courtesy of Csaba Osztrogonác <ossy@webkit.org>
825         (MockBugzilla):
826         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
827         Raises a PatchIsNotValid exception in the case of validate() returning
828         false.
829         (CommitQueueTask.run):
830         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
831         Raises a PatchIsNotValid exception in the case of validate() returning
832         false.
833         (EarlyWarningSystemTask.run):
834         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
835         Defines PatchIsNotValid exception. 
836         (PatchIsNotValid):
837         (PatchIsNotValid.__init__):
838         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
839         Remove call to validate() and instead catches the PatchIsNotValid
840         exception.
841         (AbstractEarlyWarningSystem.review_patch):
842         * Scripts/webkitpy/tool/commands/queues.py:
843         Adds logic to catch the PatchIsNotValid exception.
844         (CommitQueue.process_work_item):
845         * Scripts/webkitpy/tool/commands/queues_unittest.py:
846         Adds the test_non_valid_patch test to ensure that invalid patches are
847         handled properly, and don't just result in indefinite spinning.
848         courtesy of Csaba Osztrogonác <ossy@webkit.org>
849         (test_non_valid_patch):
850
851 2014-10-07  Daniel Bates  <dabates@apple.com>
852
853         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
854         https://bugs.webkit.org/show_bug.cgi?id=137499
855
856         Reviewed by Simon Fraser.
857
858         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
859         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
860         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
861         bit simulator builds of iOS WebKit.
862
863         * Scripts/webkitpy/port/ios.py:
864         (IOSSimulatorPort._generate_all_test_configurations):
865
866 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
867
868         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
869         https://bugs.webkit.org/show_bug.cgi?id=137482
870
871         Reviewed by Martin Robinson.
872
873         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
874
875 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
876
877         [SOUP] TLS errors should take precedence over HTTP authentication
878         https://bugs.webkit.org/show_bug.cgi?id=137300
879
880         Reviewed by Sergio Villar Senin.
881
882         Add a test case to check that authenticate signal is not emitted
883         in case of TLS errors, and the load fails instead.
884
885         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
886         (webViewAuthenticationCallback):
887         (testTLSErrorsHTTPAuth):
888         (httpsServerCallback):
889         (beforeAll):
890
891 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
892
893         Make webkit-patch find-users useful
894         https://bugs.webkit.org/show_bug.cgi?id=137475
895
896         Reviewed by Alexey Proskuryakov.
897
898         Make find-users use the CommitterList instead of accessing Bugzilla.
899
900         This essentially exposes the same functionality as webkitbot's whois command.
901
902         * Scripts/webkitpy/tool/commands/findusers.py:
903         (FindUsers.execute):
904
905 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
906
907         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
908         https://bugs.webkit.org/show_bug.cgi?id=137289
909
910         Unreviewed build fix.
911
912         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
913         (AccessibilityUIElement::getChildrenWithRange):
914
915 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
916
917         build.webkit.org/dashboard: Add commit queue
918         https://bugs.webkit.org/show_bug.cgi?id=137462
919
920         Reviewed by Tim Horton.
921
922         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
923         Style queue is still invisible, as it doesn't have an associated platform, and also
924         we never have problems with it anyway, so it's not worth watching.
925
926         The UI now allows for adding more bots to the Other column (such as leaks bot).
927         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
928         sources of data in a cell.
929
930         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
931         (BubbleQueue):
932         (BubbleQueue.prototype.get statusPageURL):
933         (BubbleQueue.prototype.update):
934         (BubbleQueue.prototype.loadDetailedStatus):
935         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
936         (BubbleQueueServer):
937         (BubbleQueueServer.prototype.jsonQueueLengthURL):
938         (BubbleQueueServer.prototype.jsonQueueStatusURL):
939         (BubbleQueueServer.prototype.queueStatusURL):
940         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
941         (BubbleQueueView):
942         (BubbleQueueView.prototype.update.appendQueue):
943         (BubbleQueueView.prototype.update):
944         (BubbleQueueView.prototype._addQueueHeadingToPopover):
945         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
946         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
947         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
949         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
950         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
953         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
954         (.bubble-server-popover .latest-status-no-link):
955         (.bubble-server-popover .bot-status-description):
956         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
957
958         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
959         (buildAggregateTable):
960         (buildQueuesTable):
961         Removed dysfunctional support for EWS for now. It will be different.
962
963 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
964
965         One more case of incorrect comparison in recordpatchevent.py
966         https://bugs.webkit.org/show_bug.cgi?id=137459
967
968         Reviewed by Tim Horton.
969
970         * QueueStatusServer/app.yaml:
971         * QueueStatusServer/loggers/recordpatchevent.py:
972         (RecordPatchEvent.started):
973
974 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
975
976         webkit-queues PatchLog is incorrect for patches that took less than a second
977         https://bugs.webkit.org/show_bug.cgi?id=137453
978
979         Reviewed by Tim Horton.
980
981         * QueueStatusServer/app.yaml: Updated app version.
982
983         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
984         Don't bail out for patches that took 0 seconds to process (as frequently happens
985         when a patch is obsolete).
986
987 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
988
989         EWS bubble hover shows wrong timestamps
990         https://bugs.webkit.org/show_bug.cgi?id=137252
991
992         Reviewed by Alexey Proskuryakov.
993
994         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
995
996         * QueueStatusServer/handlers/queuestatusjson.py:
997         (QueueStatusJSON.get):
998         * QueueStatusServer/handlers/statusbubble.py:
999         (StatusBubble._iso_time):
1000
1001 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
1002
1003         Unreviewed, updated list of email addresses in contributors.json
1004
1005         * Scripts/webkitpy/common/config/contributors.json: Added my former
1006         email address in Igalia, for the sake of completeness.
1007
1008 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1009
1010         Unreviewed, moved myself to the list of committers.
1011
1012         * Scripts/webkitpy/common/config/contributors.json:
1013
1014 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
1015
1016         [EFL] Introduce EWebKit_Extension
1017         https://bugs.webkit.org/show_bug.cgi?id=134921
1018
1019         Reviewed by Gyuyoung Kim.
1020
1021         * MiniBrowser/efl/main.c: Added x option to test extension path.
1022         (window_create):
1023         (elm_main):
1024         * Scripts/webkitpy/common/config/watchlist:
1025         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
1026         * Scripts/webkitpy/style/checker.py:
1027         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
1028
1029 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
1030
1031         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
1032         https://bugs.webkit.org/show_bug.cgi?id=137390
1033
1034         Reviewed by Carlos Garcia Campos.
1035
1036         * Scripts/update-webkit-libs-jhbuild:
1037
1038 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1039
1040         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
1041         https://bugs.webkit.org/show_bug.cgi?id=137391
1042
1043         Reviewed by Martin Robinson.
1044
1045         Add a custom command to only re-generate
1046         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
1047
1048         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1049
1050 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1051
1052         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
1053         https://bugs.webkit.org/show_bug.cgi?id=135502
1054
1055         Reviewed by Martin Robinson.
1056
1057         When writing to stdout/stderr fails due to a UnicodeDecodeError
1058         exception, try again without encoding the output.
1059
1060         * gtk/gtkdoc.py:
1061         (GTKDoc._run_command):
1062
1063 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1064
1065         Bugzilla status bubble displays an exception showing attachment 175738
1066         https://bugs.webkit.org/show_bug.cgi?id=137410
1067
1068         Reviewed by Tim Horton.
1069
1070         * QueueStatusServer/app.yaml: Update version.
1071
1072         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
1073         Don't fail even if expected status message is missing.
1074
1075         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
1076         the field in the same way it's defined in QueueStatus table.
1077
1078 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1079
1080         Record latest message in PatchLog for quick access
1081         https://bugs.webkit.org/show_bug.cgi?id=137405
1082
1083         Fixing a typo.
1084
1085         * QueueStatusServer/app.yaml:
1086         * QueueStatusServer/handlers/releasepatch.py:
1087
1088 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1089
1090         Record latest message in PatchLog for quick access
1091         https://bugs.webkit.org/show_bug.cgi?id=137405
1092
1093         Reviewed by Ryosuke Niwa.
1094
1095         It's no SQL...
1096
1097         * QueueStatusServer/handlers/releasepatch.py:
1098         * QueueStatusServer/handlers/updatestatus.py:
1099         * QueueStatusServer/loggers/recordpatchevent.py:
1100         * QueueStatusServer/model/patchlog.py:
1101
1102 2014-10-02  David Farler  <dfarler@apple.com>
1103
1104         -asan-blacklist option also renamed to generic -fsanitize-blacklist
1105         https://bugs.webkit.org/show_bug.cgi?id=137377
1106
1107         Reviewed by Daniel Bates.
1108
1109         * asan/asan.xcconfig:
1110         -asan-blacklist -> -fsanitize-blacklist
1111
1112         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
1113
1114 2014-10-03  Roger Fong  <roger_fong@apple.com>
1115
1116         [Windows] Include batch size argument to layout tests on Windows.
1117
1118         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1119         (RunWebKitTests.start): 
1120         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
1121         These crashes seem to happen on random tests though generally in a spread out fashion.
1122         It seems possible that the DRT instance is being clobbered somehow after running too many
1123         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
1124
1125 2014-10-03  Roger Fong  <roger_fong@apple.com>
1126
1127         [Windows] Settle for 2 chid processes running NRWT on Windows.
1128
1129         * Scripts/webkitpy/port/win.py:
1130         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
1131
1132 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
1133
1134         [GTK] Bump up and patch dependencies to allow building for aarch64
1135         https://bugs.webkit.org/show_bug.cgi?id=137147
1136
1137         Reviewed by Martin Robinson.
1138
1139         The currently used versions of pixman, libffi, librsvg, glib,
1140         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
1141         and/or build for aarch64, so they are bumped up and patched where
1142         necessary. Wherever possible, the same versions and patches were used as
1143         for the EFL port bump-up
1144         (https://bugs.webkit.org/show_bug.cgi?id=135885).
1145
1146         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
1147         regression by crashing http/tests/media/video-redirect.html . A patch
1148         already in upstream fixes that bug.
1149
1150         This change does not touch xserver, which also needs bumping up, but 
1151         will be dealt with later.
1152
1153         * gtk/jhbuild.modules:
1154         Specified versions and patches necessary to correctly build for aarch64.
1155         * gtk/patches/gst-events-arent-gstobjects.patch:
1156         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
1157         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
1158         Added. Patches gst-plugins-base to configure correctly for aarch64.
1159         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
1160         Added. Bumps up config.guess and config.sub in librsvg to recognize
1161         aarch64.
1162         * gtk/patches/libxml2-2.9.0-dtd.patch:
1163         Removed. Not necessary for libxml2 v2.9.1 anymore.
1164
1165 2014-09-28  Sam Weinig  <sam@webkit.org>
1166
1167         Remove RefPtrHashMap
1168         https://bugs.webkit.org/show_bug.cgi?id=137200
1169
1170         Reviewed by Darin Adler.
1171
1172         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1173         (TestWebKitAPI::TEST):
1174         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
1175         a minimum of refcount churn occurs.
1176
1177 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1178
1179         Remove workarounds for versions of Python before 2.7
1180         https://bugs.webkit.org/show_bug.cgi?id=137338
1181
1182         Reviewed by Csaba Osztrogonác.
1183
1184         * Scripts/webkitpy/common/system/autoinstall.py:
1185         (AutoInstaller._extract_targz):
1186         (AutoInstaller._unzip):
1187         (AutoInstaller): Deleted.
1188         (AutoInstaller._extract_all): Deleted.
1189         * Scripts/webkitpy/common/webkitunittest.py:
1190         (TestCase.setUp): Deleted.
1191         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1192         (TestConfigurationConverter.collapse_macros):
1193         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1194         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1195         (TestConfigurationConverter):
1196         (TestConfigurationConverter.combinations): Deleted.
1197         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1198         * Scripts/webkitpy/port/base.py:
1199
1200 2014-10-03  Commit Queue  <commit-queue@webkit.org>
1201
1202         Unreviewed, rolling out r174264.
1203         https://bugs.webkit.org/show_bug.cgi?id=137392
1204
1205         It broke run-webkit-tests (Requested by ebalazsfalvi on
1206         #webkit).
1207
1208         Reverted changeset:
1209
1210         "Remove workarounds for versions of Python before 2.7"
1211         https://bugs.webkit.org/show_bug.cgi?id=137338
1212         http://trac.webkit.org/changeset/174264
1213
1214 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1215
1216         Remove workarounds for versions of Python before 2.7
1217         https://bugs.webkit.org/show_bug.cgi?id=137338
1218
1219         Reviewed by Csaba Osztrogonác.
1220
1221         * Scripts/webkitpy/common/system/autoinstall.py:
1222         (AutoInstaller._extract_targz):
1223         (AutoInstaller._unzip):
1224         (AutoInstaller): Deleted.
1225         (AutoInstaller._extract_all): Deleted.
1226         * Scripts/webkitpy/common/webkitunittest.py:
1227         (TestCase.setUp): Deleted.
1228         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1229         (TestConfigurationConverter.collapse_macros):
1230         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1231         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1232         (TestConfigurationConverter):
1233         (TestConfigurationConverter.combinations): Deleted.
1234         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1235         * Scripts/webkitpy/port/base.py:
1236         * Scripts/webkitpy/port/driver.py:
1237         (ContentBlock.__init__):
1238         * Scripts/webkitpy/port/server_process.py:
1239         (ServerProcess._reset):
1240
1241 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1242
1243         Remove autoinstaller workaround for python 2.6
1244         https://bugs.webkit.org/show_bug.cgi?id=137343
1245
1246         Reviewed by Daniel Bates.
1247
1248         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
1249         2.6, nor Snow Leopard is supported anymore, so the workaround is not
1250         needed anymore.
1251
1252         * Scripts/webkitpy/common/system/autoinstall.py:
1253         (AutoInstaller.install):
1254         * Scripts/webkitpy/test/main.py:
1255         (Tester._run_tests):
1256         * Scripts/webkitpy/thirdparty/__init__.py:
1257         (AutoinstallImportHook._install_mechanize):
1258         (AutoinstallImportHook._install_pep8):
1259         (AutoinstallImportHook._install_pylint):
1260         (AutoinstallImportHook._install_buildbot):
1261         (AutoinstallImportHook._install_coverage):
1262         (AutoinstallImportHook._install_eliza):
1263         (AutoinstallImportHook._install_irc):
1264         (AutoinstallImportHook._install):
1265         (autoinstall_everything):
1266
1267 2014-10-02  Daniel Bates  <dabates@apple.com>
1268
1269         Use version number 101000 instead of 10100 for OS X Yosemite
1270         https://bugs.webkit.org/show_bug.cgi?id=137372
1271
1272         Reviewed by Mark Rowe.
1273
1274         The version number for OS X Yosemite is 101000.
1275
1276         * DumpRenderTree/mac/TextInputController.m:
1277
1278 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
1279
1280         update-work-items should never delete items
1281         https://bugs.webkit.org/show_bug.cgi?id=137366
1282
1283         Reviewed by Ryosuke Niwa.
1284
1285         As we don't just replace the whole list any more, indicate which items are high
1286         priority, and which are not. Hight priority ones will be prepended to the queue,
1287         others will be appended.
1288
1289         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
1290         But hopefully we will never have many rollouts competing like that.
1291
1292         * QueueStatusServer/app.yaml: Update version.
1293
1294         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
1295         priority and regular items separately. Removed some error handling that used to
1296         end up in returning status 500 - an uncaught exception does that automatically.
1297
1298         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
1299
1300         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
1301
1302         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
1303         priority items.
1304
1305         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1306         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
1307         line that complicated testing.
1308
1309         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
1310
1311         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
1312         priority items into separate lists.
1313
1314         * Scripts/webkitpy/common/net/statusserver_mock.py:
1315         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1316         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1317         Updated tests.
1318
1319 2014-10-02  Brendan Long  <b.long@cablelabs.com>
1320
1321         Annoying build warnings in WTFString API tests
1322         https://bugs.webkit.org/show_bug.cgi?id=137360
1323
1324         Reviewed by Darin Adler.
1325
1326         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1327         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
1328
1329 2014-10-02  Roger Fong  <roger_fong@apple.com>
1330
1331         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
1332
1333         * Scripts/webkitpy/port/win.py:
1334         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
1335
1336 2014-10-02  David Farler  <dfarler@apple.com>
1337
1338         Move ASan arguments from LLVM (-mllvm) to the frontend
1339         https://bugs.webkit.org/show_bug.cgi?id=137365
1340
1341         Reviewed by David Kilzer.
1342
1343         * asan/asan.xcconfig:
1344         Remove the -mllvm prefix to the asan-blacklist argument, moving it
1345         to the clang frontend.
1346
1347         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
1348
1349 2014-10-02  Commit Queue  <commit-queue@webkit.org>
1350
1351         Unreviewed, rolling out r174120.
1352         https://bugs.webkit.org/show_bug.cgi?id=137350
1353
1354         While number of failures is reasonable with 2 processes, test
1355         results seem to be inconsistent between runs (Requested by
1356         rfong on #webkit).
1357
1358         Reverted changeset:
1359
1360         "[Windows] Back to 2 child processes for NRWT on Windows."
1361         http://trac.webkit.org/changeset/174120
1362
1363 2014-10-02  Jeff Miller  <jeffm@apple.com>
1364
1365         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
1366         https://bugs.webkit.org/show_bug.cgi?id=137347
1367
1368         Reviewed by Dan Bernstein.
1369
1370         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1371         Use WebKitSystemInterfaceYosemite on OS X 10.10.
1372
1373         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1374         Ditto.
1375
1376 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1377
1378         [GTK] [JHBuild] Switch sourceware.org mirror to http.
1379
1380         Unreviewed.
1381
1382         The ftp access is recently failing to work as expected, and the
1383         bots fail to download the file.
1384         The same mirror is available via http and seems to work better.
1385
1386         * gtk/jhbuild.modules:
1387
1388 2014-10-01  Commit Queue  <commit-queue@webkit.org>
1389
1390         Unreviewed, rolling out r174185.
1391         https://bugs.webkit.org/show_bug.cgi?id=137334
1392
1393         Patch that adds logging causes webkitpy failures (Requested by
1394         rfong on #webkit).
1395
1396         Reverted changeset:
1397
1398         "commitqueuetasks_unittest references a non-existent member
1399         variable"
1400         https://bugs.webkit.org/show_bug.cgi?id=137303
1401         http://trac.webkit.org/changeset/174185
1402
1403 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1404
1405         EWS and Commit Queue should know better than to spew 500 failed
1406         results in the case of extremely red patches.
1407         https://bugs.webkit.org/show_bug.cgi?id=137324
1408
1409         Reviewed by Alexey Proskuryakov.
1410
1411         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1412         Adds a check for did_exceed_test_failure_limit.
1413         (AbstractEarlyWarningSystem._failing_tests_message):
1414         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1415         Alters the task mock to respond properly to
1416         results_from_patch_test_run(patch)
1417         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1418         * Scripts/webkitpy/tool/commands/queues.py:
1419         Adds a check for did_exceed_test_failure_limit.
1420         (CommitQueue._failing_tests_message):
1421
1422 2014-10-01  Daniel Bates  <dabates@apple.com>
1423
1424         Unreviewed, rolling out r174192.
1425
1426         Revert the unit test fix in r174192 since we reverted r174187
1427         in r174194 due to correctness issues. See
1428         <http://webkit.org/b/137329> for more details.
1429
1430         Reverted changeset:
1431
1432         "Test fix after r174187"
1433         http://trac.webkit.org/changeset/174192
1434
1435 2014-10-01  Mark Rowe  <mrowe@apple.com>
1436
1437         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
1438
1439         Reviewed by Dan Bernstein.
1440
1441         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
1442         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
1443         for the LLVM components when on Yosemite.
1444
1445 2014-10-01  Commit Queue  <commit-queue@webkit.org>
1446
1447         Unreviewed, rolling out r174187.
1448         https://bugs.webkit.org/show_bug.cgi?id=137329
1449
1450         webkitpy failures, and thorton says the patch is wrong
1451         (Requested by dethbakin on #webkit).
1452
1453         Reverted changeset:
1454
1455         "[Windows] Increase layout test timeout for Windows following
1456         r174162."
1457         http://trac.webkit.org/changeset/174187
1458
1459 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
1460
1461         Test fix after r174187
1462
1463         * Scripts/webkitpy/port/win_unittest.py:
1464         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
1465
1466 2014-10-01  Roger Fong  <roger_fong@apple.com>
1467
1468         [Windows] Increase layout test timeout for Windows following r174162.
1469
1470         * Scripts/webkitpy/port/win.py:
1471         (WinPort.default_timeout_ms):
1472
1473 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1474
1475         commitqueuetasks_unittest references a non-existent member variable
1476         when mock-reporting flaky tests.
1477         https://bugs.webkit.org/show_bug.cgi?id=137303
1478
1479         Reviewed by Daniel Bates.
1480
1481         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1482         (MockCommitQueue.report_flaky_tests):
1483         Makes the appropriate name change.
1484         (test_simple_flaky_test_failure):
1485         Adds a unit test to make sure that the code is excercised.
1486
1487 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1488
1489         EWS is inconclusively spinning forever on a patch that breaks 500+
1490         tests
1491         https://bugs.webkit.org/show_bug.cgi?id=137223
1492
1493         Reviewed by Tim Horton.
1494
1495         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1496         Checks to see whether the tests have exceeded the failure limit, and
1497         only spins off another test if they have not exceeded the limit.
1498         (PatchAnalysisTask._test_patch):
1499
1500 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
1501
1502         Unreviewed, add Katie Madonna as a contributor.
1503
1504         * Scripts/webkitpy/common/config/contributors.json:
1505
1506 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1507
1508         commitqueuetasks_unittest does not construct FailingTestCommitQueue
1509         objects properly in its test cases.
1510         https://bugs.webkit.org/show_bug.cgi?id=137281
1511
1512         Reviewed by Daniel Bates.
1513
1514         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1515         (FailingTestCommitQueue.test_results):
1516         Adds an assert to make FailingTestCommitQueue harder to mis-use.
1517         (test_double_flaky_test_failure):
1518         Nests the intended test failure strings into one-length lists.
1519         (test_red_test_failure):
1520         Nests the intended test failure strings into one-length lists.
1521
1522 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
1523
1524         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
1525         https://bugs.webkit.org/show_bug.cgi?id=136987
1526
1527         Reviewed by Daniel Bates.
1528
1529         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
1530         Specify the default encoding for all WebKit developers to get consistent results.
1531
1532 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
1533
1534         EWS is too eager to say that a patch does not apply to trunk of repository
1535         https://bugs.webkit.org/show_bug.cgi?id=137290
1536
1537         Reviewed by Ryosuke Niwa.
1538
1539         * QueueStatusServer/app.yaml: Updated app version.
1540
1541         * QueueStatusServer/handlers/statusbubble.py:
1542         (StatusBubble._build_bubble):
1543         (StatusBubble._build_bubbles_for_attachment):
1544         Rewrote to make more sense.
1545
1546 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1547
1548         Remove thirdparty/unittest2 from webkitpy
1549         https://bugs.webkit.org/show_bug.cgi?id=137251
1550
1551         Reviewed by Brent Fulgham.
1552
1553         Additionally ordered imports in related webkitpy files and
1554         removed unnecessary shebangs from unittest files.
1555
1556         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
1557         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1558         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1559         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
1560         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1561         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1562         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1563         * Scripts/webkitpy/common/config/committers_unittest.py:
1564         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1565         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
1566         * Scripts/webkitpy/common/config/ports_unittest.py:
1567         * Scripts/webkitpy/common/config/urls_unittest.py:
1568         * Scripts/webkitpy/common/editdistance_unittest.py:
1569         * Scripts/webkitpy/common/find_files_unittest.py:
1570         * Scripts/webkitpy/common/lru_cache_unittest.py:
1571         * Scripts/webkitpy/common/memoized_unittest.py:
1572         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
1573         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1574         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1575         * Scripts/webkitpy/common/net/credentials_unittest.py:
1576         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1577         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
1578         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1579         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1580         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
1581         * Scripts/webkitpy/common/net/statusserver_unittest.py:
1582         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
1583         * Scripts/webkitpy/common/newstringio_unittest.py:
1584         * Scripts/webkitpy/common/prettypatch_unittest.py:
1585         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
1586         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1587         * Scripts/webkitpy/common/system/environment_unittest.py:
1588         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
1589         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
1590         * Scripts/webkitpy/common/system/executive_unittest.py:
1591         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
1592         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1593         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1594         * Scripts/webkitpy/common/system/logtesting.py:
1595         * Scripts/webkitpy/common/system/logutils_unittest.py:
1596         * Scripts/webkitpy/common/system/outputcapture.py:
1597         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
1598         * Scripts/webkitpy/common/system/outputtee_unittest.py:
1599         * Scripts/webkitpy/common/system/path_unittest.py:
1600         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1601         * Scripts/webkitpy/common/system/profiler_unittest.py:
1602         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
1603         * Scripts/webkitpy/common/system/user_unittest.py:
1604         * Scripts/webkitpy/common/system/workspace_unittest.py:
1605         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1606         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
1607         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
1608         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
1609         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
1610         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
1611         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
1612         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
1613         * Scripts/webkitpy/common/webkitunittest.py:
1614         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1615         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1616         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1617         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1618         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1619         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
1620         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1621         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
1622         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
1623         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1624         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1625         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1626         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
1627         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1628         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1629         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
1630         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1631         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1632         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1633         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1634         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1635         * Scripts/webkitpy/port/base_unittest.py:
1636         * Scripts/webkitpy/port/builders_unittest.py:
1637         * Scripts/webkitpy/port/config_unittest.py:
1638         * Scripts/webkitpy/port/driver_unittest.py:
1639         * Scripts/webkitpy/port/efl_unittest.py:
1640         * Scripts/webkitpy/port/factory_unittest.py:
1641         * Scripts/webkitpy/port/gtk_unittest.py:
1642         * Scripts/webkitpy/port/http_lock_unittest.py:
1643         * Scripts/webkitpy/port/image_diff_unittest.py:
1644         * Scripts/webkitpy/port/leakdetector_unittest.py:
1645         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
1646         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1647         * Scripts/webkitpy/port/mock_drt_unittest.py:
1648         * Scripts/webkitpy/port/port_testcase.py:
1649         * Scripts/webkitpy/port/server_process_unittest.py:
1650         * Scripts/webkitpy/port/westondriver_unittest.py:
1651         * Scripts/webkitpy/port/win_unittest.py:
1652         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1653         * Scripts/webkitpy/style/checker_unittest.py:
1654         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1655         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
1656         * Scripts/webkitpy/style/checkers/common_unittest.py:
1657         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1658         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
1659         * Scripts/webkitpy/style/checkers/js_unittest.py:
1660         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
1661         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
1662         * Scripts/webkitpy/style/checkers/png_unittest.py:
1663         * Scripts/webkitpy/style/checkers/python_unittest.py:
1664         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1665         * Scripts/webkitpy/style/checkers/text_unittest.py:
1666         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
1667         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
1668         * Scripts/webkitpy/style/checkers/xml_unittest.py:
1669         * Scripts/webkitpy/style/error_handlers_unittest.py:
1670         * Scripts/webkitpy/style/filereader_unittest.py:
1671         * Scripts/webkitpy/style/filter_unittest.py:
1672         * Scripts/webkitpy/style/main_unittest.py:
1673         * Scripts/webkitpy/style/optparser_unittest.py:
1674         * Scripts/webkitpy/style/patchreader_unittest.py:
1675         * Scripts/webkitpy/test/finder_unittest.py:
1676         * Scripts/webkitpy/test/main.py: Ordered imports.
1677         * Scripts/webkitpy/test/main_unittest.py:
1678         * Scripts/webkitpy/test/printer.py: Ordered imports.
1679         (Printer.configure):
1680         * Scripts/webkitpy/test/runner_unittest.py:
1681         * Scripts/webkitpy/test/skip_unittest.py:
1682         * Scripts/webkitpy/thirdparty/__init__.py:
1683         (AutoinstallImportHook._install_irc):
1684         (AutoinstallImportHook._install_unittest2): Deleted.
1685         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1686         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
1687         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
1688         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1689         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1690         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
1691         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1692         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1693         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1694         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1695         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1696         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1697         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1698         * Scripts/webkitpy/tool/commands/download_unittest.py:
1699         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1700         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
1701         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1702         * Scripts/webkitpy/tool/commands/queuestest.py:
1703         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1704         * Scripts/webkitpy/tool/grammar_unittest.py:
1705         * Scripts/webkitpy/tool/mocktool_unittest.py:
1706         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1707         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1708         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1709         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
1710         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
1711         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
1712         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
1713         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
1714         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1715         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
1716         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
1717         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1718         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1719         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1720         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1721         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1722         * Scripts/webkitpy/tool/steps/update_unittest.py:
1723         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1724         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1725         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1726         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1727         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1728
1729 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
1730
1731         LayoutTestResults and ExpectedFailures should know about the
1732         interrupted flag from the json results file
1733         https://bugs.webkit.org/show_bug.cgi?id=137229
1734
1735         Reviewed by Daniel Bates.
1736
1737         Changes LayoutTestResults to use the interrupted flag instead of
1738         counting failures.
1739
1740         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1741         (BuilderTest._install_fetch_build._mock_fetch_build):
1742         (BuilderTest.test_latest_layout_test_results):
1743         * Scripts/webkitpy/common/net/layouttestresults.py:
1744         Removes notion of failure_limit_count, and adds
1745         did_exceed_test_failure_limit.
1746
1747         (LayoutTestResults.results_from_string):
1748         (LayoutTestResults.__init__):
1749         (LayoutTestResults.did_exceed_test_failure_limit):
1750         (LayoutTestResults): Deleted.
1751         (LayoutTestResults.set_failure_limit_count): Deleted.
1752         (LayoutTestResults.failure_limit_count): Deleted.
1753         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1754         Removes unit test for failure_limit_count logic.
1755
1756         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
1757         * Scripts/webkitpy/common/net/resultsjsonparser.py:
1758         Instead of providing a class method that returns a list of
1759         TestResults objects, resultsjsonparser now provides a class
1760         ParsedJSONResults that serves as an interface between the results.json
1761         file and the rest of webkitpy.
1762
1763         (ParsedJSONResults):
1764         (ParsedJSONResults.__init__):
1765         (ParsedJSONResults.did_exceed_test_failure_limit):
1766         (ParsedJSONResults.test_results):
1767         (ResultsJSONParser): Deleted.
1768         (ResultsJSONParser.parse_results_json): Deleted.
1769         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
1770         Updates the unit test so that it can test the new ResultsJSONParser
1771         class.
1772
1773         (ParsedJSONResultsTest):
1774         (test_basic):
1775         (ResultsJSONParserTest): Deleted.
1776         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1777         Updates the unit test to instantiate ResultsJSONParser objects rather
1778         than simple lists of TestResult objects.
1779
1780         (MockCommitQueue.test_results):
1781         (FailingTestCommitQueue.test_results):
1782         (test_flaky_test_failure):
1783         (test_failed_archive):
1784         * Scripts/webkitpy/tool/bot/expectedfailures.py:
1785         Updates ExpectedFailures to use the did_exceed_test_failure_limit
1786         method rather than counting the number of failed tests.
1787
1788         (ExpectedFailures._should_trust):
1789         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
1790         Updates MockResults to more closely resemble the updated
1791         LayoutTestResults class.
1792
1793         (MockResults.__init__):
1794         (MockResults.did_exceed_test_failure_limit):
1795         (ExpectedFailuresTest.test_can_trust_results):
1796         (ExpectedFailuresTest.test_unexpected_failures_observed):
1797         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
1798         (MockResults.failure_limit_count): Deleted.
1799         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1800         Removes a FIXME regarding the use of the
1801         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
1802
1803         (LayoutTestResultsReader.results):
1804         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1805         Updates test to not check the now-nonexistant failure_count_limit
1806         method.
1807
1808         (test_missing_unit_test_results_path):
1809         (test_layout_test_results):
1810         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1811         Accounts for name change: ResultsJSONParserTest ->
1812         ParsedJSONParserTest.
1813
1814         (RebaselineTestTest.test_gather_baselines):
1815
1816 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1817
1818         [EFL] Rename TEST_THEME_DIR macro
1819         https://bugs.webkit.org/show_bug.cgi?id=137244
1820
1821         Reviewed by Csaba Osztrogonác.
1822
1823         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
1824         DEFAULT_THEME_DIR is better than it.
1825
1826         * MiniBrowser/efl/main.c:
1827         (window_create):
1828         * TestWebKitAPI/efl/PlatformWebView.cpp:
1829         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1830         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1831         (WTR::PlatformWebView::PlatformWebView):
1832
1833 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
1834
1835         Windows EWS went purple when it failed to build
1836         https://bugs.webkit.org/show_bug.cgi?id=137267
1837
1838         Reviewed by Ryosuke Niwa.
1839
1840         * QueueStatusServer/app.yaml: Update the version.
1841
1842         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
1843         Make it work for style and win-ews queues.
1844
1845 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
1846
1847         It should be fun and easy to run every possible JavaScript benchmark from the command line
1848         https://bugs.webkit.org/show_bug.cgi?id=137245
1849
1850         Reviewed by Oliver Hunt.
1851         
1852         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
1853         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
1854         having their own private scripts for doing benchmark runs, and didn't share them in the open
1855         source community, because of fears about the shady licensing of the benchmarks suites that
1856         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
1857         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
1858         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
1859         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
1860         but some of them are. The non-public tests are exclusively those that were not made by any
1861         WebKit contributor, but which JSC/WebKit devs found useful for testing.
1862
1863         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
1864         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
1865         checked into WebKit svn at all) can be run by passing the path to them via a configuration
1866         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
1867         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
1868         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
1869         probably never be checked in because there is no license text anywhere in that benchmark.
1870         A valid ~/.run-jsc-benchmarks file will just be something like:
1871         
1872             {
1873                 "OctanePath": "/path/to/Octane2",
1874                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
1875             }
1876         
1877         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
1878         run-jsc-benchmarks will just gracefully avoid running that test suite.
1879         
1880         Finally, a word about policy: it is understood that different organizations that do
1881         development on JSC may find themselves having internal benchmarks that they cannot share
1882         because of weird licensing. It happens - usually because the organization doing JSC
1883         development found some test in the wild that is owned by someone else and therefore cannot
1884         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
1885         that add support for some new kind of benchmark suite even if the suite is not made public
1886         as part of the same patch - so long as the patch isn't too invasive. An example of
1887         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
1888         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
1889         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
1890         completely open-sourced and committed to the WebKit repo - but the reality is that this
1891         can't always be done safely.
1892
1893         * Scripts/bencher: Removed.
1894         * Scripts/run-jsc-benchmarks: Added.
1895
1896 2014-09-30  Roger Fong  <roger_fong@apple.com>
1897
1898         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
1899
1900         * Scripts/webkitpy/port/drdiver.py:
1901         (Driver.stop):
1902         * Scripts/webkitpy/port/server_process.py:
1903         (ServerProcess.stop):
1904
1905 2014-09-30  Roger Fong  <roger_fong@apple.com>
1906
1907         [Windows] Back to 2 child processes for NRWT on Windows.
1908
1909         * Scripts/webkitpy/port/win.py:
1910         (WinPort.default_child_processes):
1911         Changing the number of processes to 1 did not have an effect on the layout test results. 
1912         It does introduce an issue with one of the workers hanging indefinitely and causing the 
1913         layout tests to timeout as a whole occasionally, but we should just fix that.
1914
1915 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
1916
1917         Remove an accidentally committed line..
1918
1919         * QueueStatusServer/handlers/statusbubble.py:
1920         (StatusBubble._build_bubble):
1921
1922 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
1923
1924         build.webkit.org/dashboard: Switch EWS view to using actual retry count
1925         https://bugs.webkit.org/show_bug.cgi?id=137240
1926
1927         Reviewed by Ryosuke Niwa.
1928
1929         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1930         (EWSQueue.prototype.loadDetailedStatus):
1931         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
1932         (EWSQueueView.prototype._popoverContentForEWSQueue):
1933         Use the new retry_count data member from JSON.
1934
1935         * QueueStatusServer/app.yaml: Updating the version.
1936
1937         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
1938         Instead of message_count, produce retry_count.
1939
1940 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
1941
1942         EWS doesn't need to show all the bubbles when a patch fails to apply
1943         https://bugs.webkit.org/show_bug.cgi?id=137256
1944
1945         Reviewed by Ryosuke Niwa.
1946
1947         * QueueStatusServer/app.yaml: Updated app version.
1948
1949         * QueueStatusServer/handlers/statusbubble.py:
1950         (StatusBubble._build_bubble):
1951         (StatusBubble._build_bubbles_for_attachment):
1952         (StatusBubble.get):
1953         * QueueStatusServer/templates/statusbubble.html:
1954         When some queues fail to apply, and no queues had meaningful output (meaning that
1955         they will almost certainly fail to apply later), we can show a single bubble
1956         telling the user just that.
1957
1958 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1959
1960         [EFL] Bump EFL version to 1.11.2
1961         https://bugs.webkit.org/show_bug.cgi?id=137118
1962
1963         Reviewed by Gyuyoung Kim.
1964
1965         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
1966         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
1967
1968         * efl/jhbuild.modules:
1969         * efl/patches/ecore.patch: Removed.
1970
1971 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1972
1973         REGRESSION(r173929): [GTK] TestInspector fails after r173929
1974         https://bugs.webkit.org/show_bug.cgi?id=137247
1975
1976         Reviewed by Philippe Normand.
1977
1978         Wait until can-attach property changes before trying to attach the
1979         inspector after resizing the view.
1980
1981         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
1982         (testInspectorDefault):
1983
1984 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1985
1986         Require Python 2.7 version
1987         https://bugs.webkit.org/show_bug.cgi?id=137112
1988
1989         Reviewed by Csaba Osztrogonác.
1990
1991         * Scripts/ensure-valid-python:
1992         (checkPythonVersion):
1993         * Scripts/webkitpy/common/version_check.py:
1994
1995 2014-09-30  Martin Hock  <mhock@apple.com>
1996
1997         Skip a JSC test after r174036.
1998         https://bugs.webkit.org/show_bug.cgi?id=137236
1999
2000         Reviewed by Csaba Osztrogonác.
2001
2002         * Scripts/run-javascriptcore-tests:
2003
2004 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2005
2006         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
2007         https://bugs.webkit.org/show_bug.cgi?id=137212
2008
2009         This moves TestNetscapePlugin to a new folder (lib/plugins).
2010         We should not use the same directory for TestNetscapePlugin and
2011         the other libraries, because we end up scanning all the .so in the
2012         lib dir for every test.
2013
2014         Reviewed by Carlos Garcia Campos.
2015
2016         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
2017         * Scripts/webkitpy/port/efl.py:
2018         (EflPort.setup_environ_for_server): Update plugin path.
2019         * Scripts/webkitpy/port/gtk.py:
2020         (GtkPort.setup_environ_for_server): Update plugin path.
2021         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
2022
2023 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2024
2025         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
2026
2027         Rubber-stamped by Tim Horton.
2028
2029         * QueueStatusServer/app.yaml:
2030         * QueueStatusServer/handlers/statusbubble.py:
2031         (StatusBubble._build_bubble):
2032
2033 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2034
2035         Typo fix, suggested by Tim Horton.
2036
2037         * QueueStatusServer/handlers/statusbubble.py:
2038         (StatusBubble._build_message_for_provisional_failure):
2039
2040 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2041
2042         Improve Bugzilla status bubbles
2043         https://bugs.webkit.org/show_bug.cgi?id=137232
2044
2045         Reviewed by Ryosuke Niwa.
2046
2047         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
2048
2049         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
2050         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
2051         that are stuck, as it was only confusing that they disappeared after 99.
2052
2053         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
2054         by old bubbles. We need a lot more information to determine color, so the implementation
2055         can not be here.
2056
2057         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
2058         always have a link for consistency. Added code to convert timestamps in tooltips
2059         to local time zone.
2060
2061 2014-09-29  Commit Queue  <commit-queue@webkit.org>
2062
2063         Unreviewed, rolling out r174045.
2064         https://bugs.webkit.org/show_bug.cgi?id=137231
2065
2066         Introduced a crash during page loading tests on Mac (Requested
2067         by rniwa on #webkit).
2068
2069         Reverted changeset:
2070
2071         "Replace OSObjectPtr with RetainPtr/adoptOS"
2072         https://bugs.webkit.org/show_bug.cgi?id=137158
2073         http://trac.webkit.org/changeset/174045
2074
2075 2014-09-29  Tim Horton  <timothy_horton@apple.com>
2076
2077         Add Jake as a contributor.
2078
2079         * Scripts/webkitpy/common/config/contributors.json:
2080
2081 2014-09-29  Roger Fong  <roger_fong@apple.com>
2082
2083         [Windows] Skip a javascriptcore test following r174036.
2084
2085         * Scripts/run-javascriptcore-tests:
2086
2087 2014-09-29  Roger Fong  <roger_fong@apple.com>
2088
2089         [Windows] Reduce number of processes used by NRWT on Windows to 1.
2090
2091         * Scripts/webkitpy/port/win.py:
2092         (WinPort.default_child_processes):
2093         Reduce number of processes to 1 so we can get a good baseline for what failures
2094         we should be expecting to see from the Windows bots.
2095
2096 2014-09-29  Darin Adler  <darin@apple.com>
2097
2098         Tweak and tighten SVG font converter
2099         https://bugs.webkit.org/show_bug.cgi?id=136956
2100
2101         Reviewed by Myles Maxfield.
2102
2103         I was investigating behavior of String::toInt, String::toDouble, and
2104         String::toFloat for various failure cases, and decided to start some
2105         unit tests for those functions here.
2106
2107         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2108         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
2109         StringToDouble testing.
2110
2111 2014-09-29  Philippe Normand  <pnormand@igalia.com>
2112
2113         [GTK][CMake] TestWebCore target build sometimes fail
2114         https://bugs.webkit.org/show_bug.cgi?id=137207
2115
2116         Reviewed by Csaba Osztrogon.
2117
2118         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
2119         headers are generated before the TestWebCore target is built.
2120
2121 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2122
2123         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
2124         https://bugs.webkit.org/show_bug.cgi?id=137209
2125
2126         Reviewed by Philippe Normand.
2127
2128         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
2129         from the WebCore test sources.
2130
2131 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
2132
2133         Allow webkit-patch upload to respect the --directory argument with git checkouts
2134         https://bugs.webkit.org/show_bug.cgi?id=137166
2135
2136         Reviewed by Darin Adler.
2137
2138         We simply hadn't plumbed it through.
2139
2140         * Scripts/webkitpy/common/checkout/scm/detection.py:
2141         (SCMDetector.detect_scm_system):
2142         * Scripts/webkitpy/common/checkout/scm/git.py:
2143         (Git.__init__):
2144         (Git.changed_files):
2145
2146 2014-09-26  Sam Weinig  <sam@webkit.org>
2147
2148         Replace OSObjectPtr with RetainPtr/adoptOS
2149         https://bugs.webkit.org/show_bug.cgi?id=137158
2150
2151         Reviewed by Dan Bernstein.
2152
2153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2154         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
2155         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
2156         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
2157
2158 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
2159
2160         Disable function.arguments
2161         https://bugs.webkit.org/show_bug.cgi?id=137167
2162
2163         Rubber stamped by Geoffrey Garen
2164         
2165         Enable the feature by default during tests.
2166
2167         * Scripts/run-jsc-stress-tests:
2168
2169 2014-09-26  Beth Dakin  <bdakin@apple.com>
2170
2171         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
2172         https://bugs.webkit.org/show_bug.cgi?id=137089
2173
2174         Reviewed by Tim Horton.
2175
2176         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
2177         tests run at 1x, but that code does not seem to execute at the right time for 
2178         these tests, so if we just ensure we start out at 1x, that appears to fix these 
2179         tests and does not break the HiDPI tests either.
2180         * WebKitTestRunner/TestController.cpp:
2181         (WTR::TestController::createWebViewWithOptions):
2182
2183 2014-09-26  Roger Fong  <roger_fong@apple.com>
2184
2185         [Windows] Decrease default number of child processes used by Windows.
2186
2187         * Scripts/webkitpy/port/win.py:
2188         (WinPort.default_child_processes):
2189         Having too many seems to cause many tests to crash or timeout. 
2190         We may even need to make it have only 1 child process if we’re still seeing problems after this.
2191
2192 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2193
2194         Mac EWS bots do not keep logs as promised
2195         https://bugs.webkit.org/show_bug.cgi?id=137151
2196
2197         Reviewed by Ryosuke Niwa.
2198
2199         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
2200
2201 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2202
2203         Get rid of webkit-queues dashboard
2204         https://bugs.webkit.org/show_bug.cgi?id=137141
2205
2206         Reviewed by Ryosuke Niwa.
2207
2208         * QueueStatusServer/app.yaml: Updated version.
2209
2210         * QueueStatusServer/templates/dashboard.html: Removed.
2211         * QueueStatusServer/handlers/dashboard.py: Removed.
2212         * QueueStatusServer/main.py:
2213         Kill it!
2214
2215         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
2216         (.status-cell): Deleted.
2217         (.status-cell:hover): Deleted.
2218         (.status-cell.pass): Deleted.
2219         (.status-cell.fail): Deleted.
2220         (.status-cell.pending): Deleted.
2221         (.status-cell.error): Deleted.
2222         * QueueStatusServer/stylesheets/dashboard.css: Removed.
2223         * QueueStatusServer/templates/activebots.html:
2224         * QueueStatusServer/templates/patch.html:
2225         * QueueStatusServer/templates/queuestatus.html:
2226         * QueueStatusServer/templates/recentstatus.html:
2227         Renamed dashboard.css to common.css, and removed dashboard-only rules.
2228
2229 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2230
2231         Get rid of Retry status in webkit-queues
2232         https://bugs.webkit.org/show_bug.cgi?id=137135
2233
2234         Reviewed by Ryosuke Niwa.
2235
2236         * QueueStatusServer/config/messages.py: Removed Retry.
2237
2238         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
2239         no longer needs to check the latest status. It just always both unlocks the patch
2240         and removes it from WorkItems.
2241
2242         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
2243         I don't understand why we even needed to check for retries here, but now that there
2244         are no retries, that code can go to /dev/null.
2245
2246         * QueueStatusServer/loggers/recordpatchevent.py:
2247         (RecordPatchEvent.started):
2248         (RecordPatchEvent.retrying): Deleted.
2249         Fixed retry counting, it should work for all queues now.
2250
2251         * QueueStatusServer/model/queuestatus.py:
2252         (QueueStatus.is_retry_request): Deleted. These are no more.
2253
2254         * Scripts/webkitpy/common/net/statusserver_mock.py:
2255         (MockStatusServer.release_lock):
2256         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2257         Did whatever it took to keep passing the tests. The particular test doesn't seem
2258         quite right, but whatever.
2259
2260         * Scripts/webkitpy/tool/commands/queues.py:
2261         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
2262         and let others pick up. Also, added explicit returns for clarity.
2263         (AbstractPatchQueue._did_retry): Deleted.
2264
2265 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
2266
2267         [EFL] Fix the gst-libav build on ARM Thumb2
2268         https://bugs.webkit.org/show_bug.cgi?id=137022
2269
2270         Reviewed by Zoltan Herczeg.
2271
2272         * efl/jhbuild.modules:
2273         * efl/patches/gst-libav.patch: Added.
2274
2275 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
2276
2277         [EFL] Bump up dependencies not to conflict with the GTK port.
2278         https://bugs.webkit.org/show_bug.cgi?id=137143
2279
2280         Reviewed by Gyuyoung Kim.
2281
2282         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
2283         installing and removing different versions of libgnutls-dev, thus
2284         hindering the development for both ports on the same machine. GTK is
2285         using the newer version of the package, now bumping up EFL to use the 
2286         same.
2287
2288         * efl/install-dependencies:
2289
2290 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
2291
2292         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
2293         https://bugs.webkit.org/show_bug.cgi?id=136854
2294
2295         Reviewed by Gyuyoung Kim.
2296
2297         'Escape' key should exit fullscreen first and then should be used to stop page load.
2298
2299         * MiniBrowser/efl/main.c:
2300         (on_key_down):
2301
2302 2014-09-25  Dean Jackson  <dino@apple.com>
2303
2304         Add Said to the contributors list so his name completes in bugzilla.
2305
2306         * Scripts/webkitpy/common/config/contributors.json:
2307
2308 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
2309
2310         EWS only repeats its cycle every two hours
2311         https://bugs.webkit.org/show_bug.cgi?id=137129
2312
2313         Reviewed by Ryosuke Niwa.
2314
2315         * QueueStatusServer/app.yaml: Updated version.
2316
2317         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
2318
2319         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
2320         the patch from work items.
2321
2322         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
2323
2324         * QueueStatusServer/main.py: Added release-lock.
2325
2326         * QueueStatusServer/model/activeworkitems.py:
2327         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
2328
2329         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
2330         we don't want it to be immediately picked up again, it's better to give other patches
2331         a chance.
2332
2333         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
2334         these interactive versions, but OK.
2335
2336         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
2337         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
2338         or svn is down).
2339
2340         * Scripts/webkitpy/tool/commands/queues.py:
2341         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
2342         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
2343         meaning that these handlers could never do the right thing. We'd either get a duplicate
2344         _did_fail, or try to unlock an already unlocked patch.
2345         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
2346         making it eligible for retry immediately.
2347
2348         * Scripts/webkitpy/common/net/statusserver.py:
2349         (StatusServer._post_release_lock):
2350         (StatusServer.release_lock):
2351         Added a call to release-lock.
2352
2353 2014-09-25  Roger Fong  <roger_fong@apple.com>
2354
2355         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
2356
2357         * Scripts/webkitpy/common/system/path.py:
2358         (_CygPath.convert):
2359
2360 2014-09-25  Roger Fong  <roger_fong@apple.com>
2361
2362         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
2363
2364         * Scripts/webkitpy/common/system/path.py:
2365         (_CygPath.convert):
2366
2367 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2368
2369         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
2370         https://bugs.webkit.org/show_bug.cgi?id=136377
2371
2372         Reviewed by Philippe Normand.
2373
2374         * Scripts/webkitdirs.pm:
2375         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
2376
2377 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
2378
2379         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
2380         https://bugs.webkit.org/show_bug.cgi?id=137117
2381
2382         Tools/efl/install-dependencies relies on apt-get to install packages.
2383         Unfortunately, if a package does not exist (e.g., for a given
2384         architecture) then apt-get install is not able to ignore the missing
2385         package and install the rest but fails to run entirely (and there
2386         seems to be no intent to change this behaviour).
2387
2388         On ARM64, the luajit package is missing and currently it needs manual
2389         editing of install-dependencies to get the script install as much as it
2390         can.
2391
2392         This patch separates the installation of the universally available
2393         packages from those which might not be available for all architectures.
2394
2395         Reviewed by Gyuyoung Kim.
2396
2397         * efl/install-dependencies:
2398
2399 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
2400
2401         Remove WinCE port from trunk
2402         https://bugs.webkit.org/show_bug.cgi?id=136951
2403
2404         Reviewed by Alex Christensen.
2405
2406         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2407         (_should_file_trigger_build):
2408         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2409         (ShouldBuildTest):
2410         * CMakeLists.txt:
2411         * DumpRenderTree/win/DRTDataObject.cpp:
2412         (DRTDataObject::CopyMedium):
2413         * Scripts/build-webkit:
2414         * Scripts/webkit-build-directory:
2415         * Scripts/webkitdirs.pm:
2416         (argumentsForConfiguration):
2417         (builtDylibPathForName):
2418         (isAppleWinWebKit):
2419         (launcherPath):
2420         (launcherName):
2421         (shouldRemoveCMakeCache):
2422         (cmakeBasedPortArguments):
2423         (cmakeBasedPortName):
2424         (isCMakeBuild):
2425         (isWinCE): Deleted.
2426         (determineIsWinCE): Deleted.
2427         * Scripts/webkitperl/FeatureList.pm:
2428         * Scripts/webkitpy/port/port_testcase.py:
2429         (test_apache_config_file_name_for_platform):
2430         * TestWebKitAPI/config.h:
2431         * WinCELauncher/CMakeLists.txt: Removed.
2432         * WinCELauncher/main.cpp: Removed.
2433         * gtk/manifest.txt:
2434
2435 2014-09-23  David Farler  <dfarler@apple.com>
2436
2437         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
2438         https://bugs.webkit.org/show_bug.cgi?id=136895
2439
2440         Reviewed by David Kilzer.
2441
2442         Create Device, DeviceType, and Runtime data classes.
2443         Create Simulator class represent simctl output.
2444
2445         Wherever possible, use structured data classes anywhere a raw
2446         identifier or UDID string was used for a cleaner implementation
2447         and to encapsulate the inherent fragility of scraping simctl output.
2448
2449         Create a suitably named testing device if one doesn't exist.
2450
2451         Finally, accurately handle having multiple simulator runtimes (SDKs)
2452         installed in the active Xcode.app bundle.
2453
2454         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2455         (_set_up_derived_options):
2456         * Scripts/webkitpy/port/driver.py:
2457         (IOSSimulatorDriver.cmd_line):
2458         Construct DeviceType and Runtime objects from identifiers passed at the
2459         command line, still providing sensible defaults for 32- and 64-bit testing.
2460         * Scripts/webkitpy/port/ios.py:
2461         (IOSSimulatorPort.__init__):
2462         (IOSSimulatorPort.setup_test_run):
2463         (IOSSimulatorPort):
2464         (IOSSimulatorPort.testing_device):
2465         Cache the testing device once it is created or found.
2466         (IOSSimulatorPort.reset_preferences):
2467         Get the device path from the Device object instead of consructing it
2468         in the port class.
2469         (IOSSimulatorPort.simulator_udid): Deleted.
2470         Get the UDID from the testing_device :: Device object itself.
2471         * Scripts/webkitpy/xcode/simulator.py:
2472         Created Device, DeviceType, Runtime, and Simulator classes.
2473         (get_runtimes): Deleted.
2474         (get_devices): Deleted.
2475         (get_device_types): Deleted.
2476         (get_latest_runtime): Deleted.
2477
2478 2014-09-24  Roger Fong  <roger_fong@apple.com>
2479
2480         [Windows] Tentative fix for Windows test bots.
2481
2482         * Scripts/webkitpy/common/system/path.py:
2483         (_CygPath.convert):
2484
2485 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
2486
2487         Change more build.webkit.org links to https
2488         https://bugs.webkit.org/show_bug.cgi?id=137049
2489
2490         Reviewed by Csaba Osztrogonác.
2491
2492         Fix appspot, svn.webkit.org and Trac links.
2493
2494         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2495         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
2496         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2497         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
2498         (ViewController.prototype._domForBuildName):
2499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2500         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2501         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2502         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2503         (.):
2504         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
2505         (EWS):
2506         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2507         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
2508         (TestHistory):
2509         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2510
2511 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
2512
2513         Update the list of u-szeged contributors.
2514
2515         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
2516
2517         * Scripts/webkitpy/common/config/contributors.json:
2518
2519 2014-09-23  Roger Fong  <roger_fong@apple.com>
2520
2521         [Windows] More debugging for the Windows bots.
2522
2523         * Scripts/webkitpy/common/system/path.py:
2524         (_CygPath):
2525
2526 2014-09-23  Roger Fong  <roger_fong@apple.com>
2527
2528         Unreviewed. Fix for r173899, those tabs should be spaces.
2529
2530         * Scripts/webkitpy/port/driver.py:
2531         (Driver._command_from_driver_input):
2532         (Driver): Deleted.
2533
2534 2014-09-23  Roger Fong  <roger_fong@apple.com>
2535
2536         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
2537
2538         * Scripts/webkitpy/port/driver.py:
2539         (Driver):
2540
2541 2014-09-23  Jer Noble  <jer.noble@apple.com>
2542
2543         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
2544         https://bugs.webkit.org/show_bug.cgi?id=137031
2545
2546         Reviewed by Joseph Pecoraro.
2547
2548         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
2549         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
2550         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
2551         ChangeLog locations before passing them to createCommitMessage().
2552
2553         * Scripts/commit-log-editor:
2554
2555 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2556
2557         W3C test importer should detect manual and reference tests according their filenames
2558         https://bugs.webkit.org/show_bug.cgi?id=133852
2559
2560         Reviewed by Bem Jones-Bey.
2561
2562         * Scripts/webkitpy/w3c/test_parser.py:
2563         (TestParser.analyze_test): Adding checks based on WPT filename rules.
2564         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
2565         (TestParser):
2566         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
2567         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
2568         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2569         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
2570
2571 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
2572
2573         Unreviewed, add Rebecca Hauck as a contributor.
2574
2575         * Scripts/webkitpy/common/config/contributors.json:
2576
2577 2014-09-23  David Kilzer  <ddkilzer@apple.com>
2578
2579         Switch build.webkit.org URLs to https
2580
2581         Reviewed by Lucas Forschler and Alexey Proskuryakov.
2582
2583         * TestResultServer/app.yaml: Update version to this commit
2584         revision.
2585
2586         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2587         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2588         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2589         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
2590         (WebKitBuildbot):
2591         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2592         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2593         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2594         (.):
2595         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2596         (WebKitBuildbot):
2597         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2598         * Scripts/webkitpy/common/config/urls.py:
2599         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2600         (test_builder_with_name):
2601         * Scripts/webkitpy/tool/commands/queries.py:
2602         (TreeStatus):
2603         * TestResultServer/generate_builders_json.py:
2604         (main):
2605         * TestResultServer/generate_builders_json_unittest.py:
2606         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
2607         (GenerateBuildersJsonTest):
2608         (GenerateBuildersJsonTest.test_generate_json_data):
2609         * TestResultServer/static-dashboards/builders.jsonp:
2610         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2611         (loadExpectationsLayoutTests):
2612         * TestResultServer/static-dashboards/timeline_explorer.js:
2613
2614 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2615
2616         W3C test importer should copy .htaccess files
2617         https://bugs.webkit.org/show_bug.cgi?id=136850
2618
2619         Reviewed by Bem Jones-Bey.
2620
2621         * Scripts/webkitpy/w3c/test_importer.py:
2622         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
2623         (TestImporter):
2624         (TestImporter.find_importable_tests): Making use of new helper function.
2625
2626 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
2627
2628         Trying to revive bot watcher's dashboard after HSTS.
2629
2630         Unreviewed.
2631
2632         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2633         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
2634
2635 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2636
2637         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
2638         https://bugs.webkit.org/show_bug.cgi?id=137026
2639
2640         Reviewed by Csaba Osztrogonác.
2641
2642         * BuildSlaveSupport/wait-for-SVN-server.py:
2643         (getLatestSVNRevision):
2644         (waitForSVNRevision):
2645
2646 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2647
2648         Remove unlinkZeroFiles from build-webkit
2649         https://bugs.webkit.org/show_bug.cgi?id=137018
2650
2651         Reviewed by Csaba Osztrogonác.
2652
2653         * Scripts/build-webkit:
2654         (unlinkZeroFiles): Deleted.
2655
2656 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
2657
2658         [GTK] Minibrowser : Add keyboard support for stop page load
2659         https://bugs.webkit.org/show_bug.cgi?id=136857
2660
2661         Reviewed by Philippe Normand.
2662
2663         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
2664
2665         * MiniBrowser/gtk/BrowserWindow.c:
2666         (stopPageLoad): Callback to stop page load.
2667         (browser_window_init):
2668
2669 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
2670
2671         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
2672         https://bugs.webkit.org/show_bug.cgi?id=136813
2673
2674         Reviewed by Gyuyoung Kim.
2675
2676         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
2677
2678         * MiniBrowser/efl/main.c:
2679         (on_key_down):
2680
2681 2014-09-22  Daniel Bates  <dabates@apple.com>
2682
2683         [Cocoa] Add UI delegate callback when window.close() is called
2684         https://bugs.webkit.org/show_bug.cgi?id=137008
2685         <rdar://problem/17801001>
2686
2687         Reviewed by Anders Carlsson.
2688
2689         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
2690         for window opened via JavaScript (i.e. window.open()).
2691
2692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2693         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
2694         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
2695
2696 2014-09-22  Youenn Fablet  <youennf@gmail.com>
2697
2698         W3C importer should import html files within resources folders
2699         https://bugs.webkit.org/show_bug.cgi?id=127548
2700
2701         Reviewed by Ryosuke Niwa.
2702         
2703         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
2704
2705         * Scripts/webkitpy/w3c/test_importer.py:
2706         (TestImporter.find_importable_tests):
2707
2708 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2709
2710         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
2711         https://bugs.webkit.org/show_bug.cgi?id=136998
2712
2713         Reviewed by Philippe Normand.
2714
2715         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2716         (testWebViewCanShowMIMEType): Remove the check of PDF as
2717         unsupported MIME type.
2718
2719 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2720
2721         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
2722
2723         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
2724         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
2725
2726         * Scripts/webkitpy/common/config/watchlist: Use
2727         Source/WebCore/platform/gtk/po/ as directory to watch for
2728         WebKitGTKTranslations rule and add berto and myself to the list of
2729         watchers.
2730
2731 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
2732
2733         Fix syntaxError in watchlist since r173594
2734         https://bugs.webkit.org/show_bug.cgi?id=136996
2735
2736         Reviewed by Philippe Normand.
2737
2738         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
2739
2740 2014-09-20  Sam Weinig  <sam@webkit.org>
2741
2742         Make possible HashSet<std::unique_ptr<>>
2743         https://bugs.webkit.org/show_bug.cgi?id=136166
2744
2745         Reviewed by Darin Adler.
2746
2747         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
2748         * TestWebKitAPI/Counters.cpp: Added.
2749         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
2750         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
2751         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
2752         translation unit.
2753     
2754         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2755         Add new files.
2756
2757         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2758         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
2759
2760         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2761         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
2762
2763 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2764
2765         run-webkit-tests should count tests submitted as absolute paths once
2766         https://bugs.webkit.org/show_bug.cgi?id=136848
2767
2768         Reviewed by Darin Adler.
2769
2770         * Scripts/webkitpy/port/base.py:
2771         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
2772
2773 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
2774
2775         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
2776         https://bugs.webkit.org/show_bug.cgi?id=136974
2777
2778         Reviewed by Chris Fleizach.
2779
2780         * DumpRenderTree/AccessibilityUIElement.cpp:
2781         (selectTextWithCriteriaCallback):
2782         Be sure to release the string if it was allocated.
2783
2784 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
2785
2786         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
2787         https://bugs.webkit.org/show_bug.cgi?id=136966
2788
2789         Reviewed by Daniel Bates.
2790
2791         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2792         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
2793
2794 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2795
2796         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
2797         https://bugs.webkit.org/show_bug.cgi?id=136917
2798
2799         Reviewed by Darin Adler.
2800
2801         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
2802
2803         * TestWebKitAPI/PlatformEfl.cmake:
2804         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
2805         (TestWebKitAPI::didFinishLoadForFrame):
2806         (TestWebKitAPI::TEST):
2807         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
2808
2809 2014-09-19  Daniel Bates  <dabates@apple.com>
2810
2811         Always assume internal SDK when building configuration Production
2812         https://bugs.webkit.org/show_bug.cgi?id=136925
2813         <rdar://problem/18362399>
2814
2815         Reviewed by Dan Bernstein.
2816
2817         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2818         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2819         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2820         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2821
2822 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2823
2824         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
2825         https://bugs.webkit.org/show_bug.cgi?id=136847
2826
2827         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
2828
2829         Reviewed by Alexey Proskuryakov.
2830
2831         * WebKitTestRunner/TestController.cpp:
2832         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
2833
2834 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2835
2836         [GTK] Missing inspector files in the tarball
2837         https://bugs.webkit.org/show_bug.cgi?id=136952
2838
2839         Reviewed by Gustavo Noronha Silva.
2840
2841         * gtk/manifest.txt: Add
2842         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
2843         to the tarball.
2844
2845 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2846
2847         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
2848         https://bugs.webkit.org/show_bug.cgi?id=136632
2849
2850         Reviewed by Gustavo Noronha Silva.
2851
2852         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
2853         the gtk icons.
2854         * gtk/manifest.txt: Only include the free icons in the tarball.
2855
2856 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2857
2858         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
2859         https://bugs.webkit.org/show_bug.cgi?id=136943
2860
2861         Reviewed by Philippe Normand.
2862
2863         Update the script to receive the list of files from the command
2864         line instead of scanning the given directories.
2865
2866         * gtk/generate-inspector-gresource-manifest.py:
2867         (get_filenames): Convert filenames to use relative paths.
2868         (find_all_files_in_directory): Deleted.
2869         (find_all_files_in_directory.select_file): Deleted.
2870
2871 2014-09-18  Tanay C  <tanay.c@samsung.com>
2872
2873         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
2874         https://bugs.webkit.org/show_bug.cgi?id=136739
2875
2876         Reviewed by Gyuyoung Kim.
2877
2878         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
2879         (on_mouse_wheel): Modified.
2880
2881 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2882
2883         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
2884         https://bugs.webkit.org/show_bug.cgi?id=136923
2885
2886         Reviewed by Gustavo Noronha Silva.
2887
2888         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
2889         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
2890         the source.
2891
2892 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
2893
2894         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
2895         https://bugs.webkit.org/show_bug.cgi?id=136856
2896
2897         Reviewed by Darin Adler.
2898
2899         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2900         (RunLLINTCLoopTests.countFailures):
2901         (Run32bitJSCTests.countFailures):
2902         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2903         (RunLLINTCLoopTestsTest.test_failures):
2904         (RunLLINTCLoopTestsTest.test_failure):
2905         (RunLLINTCLoopTestsTest.test_no_failure):
2906         (Run32bitJSCTestsTest.test_failures):
2907         (Run32bitJSCTestsTest.test_failure):
2908         (Run32bitJSCTestsTest.test_no_failure):
2909
2910 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
2911
2912         GMainLoopSource is exposed to race conditions
2913         https://bugs.webkit.org/show_bug.cgi?id=135800
2914
2915         Reviewed by Carlos Garcia Campos.
2916
2917         Add unit tests for GMainLoopSource.
2918
2919         The tests check correct behavior of GMainLoopSource in various conditions --
2920         from the most simple rescheduling to rescheduling during dispatch, cancelling
2921         or destroying the GMainLoopSource during dispatch, proper destroy callback
2922         dispatching etc.
2923
2924         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
2925         State of the GMainLoopSource object (either ready, sheduled or active) is
2926         thoroughly tested throughout the lifetime of that object.
2927
2928         Still missing are tests for socket callbacks, which are a bit trickier because
2929         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
2930         are also not tested thoroughly, simply because it is at the moment impossible
2931         to test that the objects are actually destroyed when the corresponding source
2932         is finally deleted.
2933
2934         * TestWebKitAPI/PlatformGTK.cmake:
2935         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
2936         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
2937         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
2938         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
2939         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
2940         (TestWebKitAPI::GMainLoopSourceTest::finish):
2941         (TestWebKitAPI::GMainLoopSourceTest::source):
2942         (TestWebKitAPI::TEST):
2943
2944 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
2945
2946         Unreviewed, Update my email in contributors.json
2947
2948         * Scripts/webkitpy/common/config/contributors.json:
2949
2950 2014-09-17  Daniel Bates  <dabates@apple.com>
2951
2952         Unreviewed, rolling out r173695.
2953
2954         Broke building third-party Legacy WebKit apps; will
2955         investigate offline
2956
2957         Reverted changeset:
2958
2959         "[iOS] Make WebCore build with public iOS SDK"
2960         https://bugs.webkit.org/show_bug.cgi?id=136487
2961         http://trac.webkit.org/changeset/173695
2962
2963 2014-09-17  Daniel Bates  <dabates@apple.com>
2964
2965         [iOS] Make WebCore build with public iOS SDK
2966         https://bugs.webkit.org/show_bug.cgi?id=136487
2967
2968         Reviewed by David Kilzer.
2969
2970         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
2971
2972         * DumpRenderTree/mac/CheckedMalloc.cpp:
2973
2974 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2975
2976         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
2977         https://bugs.webkit.org/show_bug.cgi?id=136889
2978
2979         Reviewed by Gustavo Noronha Silva.
2980
2981         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2982         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
2983         event was added to the events vector.
2984         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2985         (loadFailedCallback): Do not assume the web view URI is the
2986         failing URI when the load fails before the committed state.
2987         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
2988         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
2989         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
2990         (LoadTrackingTest::loadFailedWithTLSErrors): Add
2991         LoadFailedWithTLSErrors event to the events vector.
2992         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
2993
2994 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
2995
2996         [EFL][GTK] Remove WebKit1 related codes
2997         https://bugs.webkit.org/show_bug.cgi?id=136853
2998
2999         Reviewed by Csaba Osztrogonác.
3000
3001         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
3002         from scripts.
3003
3004         * BuildSlaveSupport/build.webkit.org-config/config.json:
3005         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3006         (Compile32bitJSC):
3007         (BuildAndTestWebKit2Factory):
3008         (CompileWebKit1Only): Deleted.
3009         (CompileWebKit2Only): Deleted.
3010         (BuildAndTestWebKit1OnlyFactory): Deleted.
3011         (BuildAndTestWebKit2OnlyFactory): Deleted.
3012         * Scripts/build-webkit:
3013         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
3014         * Scripts/webkitpy/common/config/ports.py:
3015         (GtkWK2Port.build_webkit_command):
3016         (EflWK2Port.build_webkit_command):
3017         * Scripts/webkitpy/common/config/ports_unittest.py:
3018         (DeprecatedPortTest.test_gtk_wk2_port):
3019         * Scripts/webkitpy/port/efl.py:
3020         (EflPort.build_webkit_command):
3021         * Scripts/webkitpy/port/gtk.py:
3022         (GtkPort._built_libraries_path):
3023         (GtkPort._search_paths):
3024         (GtkPort.test_expectations_file_position):
3025         (GtkPort.build_webkit_command):
3026         (GtkPort.run_webkit_tests_command):
3027         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
3028
3029 2014-09-16  Daniel Bates  <dabates@apple.com>
3030
3031         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
3032         https://bugs.webkit.org/show_bug.cgi?id=136862
3033
3034         Reviewed by David Kilzer.
3035
3036         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3037         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3038         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
3039         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
3040
3041 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3042
3043         Mac queue slaves should reboot every so often
3044         https://bugs.webkit.org/show_bug.cgi?id=136791
3045
3046         Reviewed by Alexey Proskuryakov.
3047
3048         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
3049
3050         * EWSTools/start-queue-mac.sh:
3051
3052 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3053
3054         Unreviewed gardening, skip one more tests on Windows.
3055
3056         * Scripts/run-javascriptcore-tests:
3057
3058 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3059
3060         JSC test gardening
3061         https://bugs.webkit.org/show_bug.cgi?id=136823
3062
3063         Reviewed by Geoffrey Garen.
3064
3065         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
3066
3067 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3068
3069         Remove shouldAbortEarly cruft from master.cfg
3070         https://bugs.webkit.org/show_bug.cgi?id=136779
3071
3072         Reviewed by Csaba Osztrogonác.
3073
3074         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3075         (ConfigureBuild.start):
3076         (RunWebKitTests.start):
3077         (RunWebKit2Tests.start): Deleted.
3078
3079 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3080
3081         Remove ORWT related crufts from webkitdirs.pm
3082         https://bugs.webkit.org/show_bug.cgi?id=136821
3083
3084         Reviewed by Alexey Proskuryakov.
3085
3086         * Scripts/webkitdirs.pm:
3087         (isPerianInstalled): Deleted.
3088         (determineIPhoneSimulatorVersion): Deleted.
3089         (iPhoneSimulatorVersion): Deleted.
3090         (isSnowLeopard): Deleted.
3091         (isLion): Deleted.
3092         (quitIOSSimulator): Deleted.
3093
3094 2014-09-15  Roger Fong  <roger_fong@apple.com>
3095
3096         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
3097         https://bugs.webkit.org/show_bug.cgi?id=25160
3098
3099         * Scripts/run-javascriptcore-tests:
3100
3101 2014-09-15  Lucas Forschler  <lforschler@apple.com>
3102
3103         Add another Apple build slave to the Mountain Lion Debug WK1 queue
3104         
3105         Rubber stamped by Matt Hanson.
3106         
3107         * BuildSlaveSupport/build.webkit.org-config/config.json:
3108
3109 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3110
3111         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
3112         https://bugs.webkit.org/show_bug.cgi?id=136822
3113
3114         Reviewed by Gyuyoung Kim.
3115
3116         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
3117         initialized as we already does it in PlatformWebView::PlatformWebView
3118         calling ewk_init(). The reason for that was to ensure testing for example,
3119         WTF where creating the view is not mandatory.
3120
3121         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
3122         in order to properly initalize and release EWebKit.
3123
3124         * TestWebKitAPI/PlatformEfl.cmake:
3125         * TestWebKitAPI/efl/PlatformWebView.cpp:
3126         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3127         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3128         * TestWebKitAPI/efl/main.cpp:
3129         (main):
3130
3131 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
3132
3133         [WinCairo] Make it easier to enable/disable GStreamer.
3134         https://bugs.webkit.org/show_bug.cgi?id=135766
3135
3136         Reviewed by Brent Fulgham.
3137
3138         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
3139
3140         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
3141
3142 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
3143
3144         Web Inspector: remind about rebaselining generator test results
3145         https://bugs.webkit.org/show_bug.cgi?id=136759
3146
3147         Reviewed by Joseph Pecoraro.
3148
3149         For now, we can implement this as a watchlist message. Add watchlist
3150         groups and messages for the inspector and web replay generators.
3151
3152         * Scripts/webkitpy/common/config/watchlist:
3153
3154 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
3155
3156         build.webkit.org/dashboard: Overlapping text when status is long
3157         https://bugs.webkit.org/show_bug.cgi?id=136794
3158
3159         Reviewed by Timothy Hatcher.
3160
3161         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3162         (.status-line): Replaces height with min-height.
3163
3164 2014-09-12  Timothy Hatcher  <timothy@apple.com>
3165
3166         Make Brian Burg a WebKit reviewer.
3167
3168         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
3169
3170 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
3171
3172         Multiple EWS or commit bots can pick up processing of the same patch
3173         https://bugs.webkit.org/show_bug.cgi?id=136793
3174
3175         Reviewed by Ryosuke Niwa.
3176
3177         Change timeout from one hour to two hours. This will let bots finish, and in the
3178         unlikely event of a bot being frozen, will only delay patch processing restart by
3179         one hour.
3180
3181         * QueueStatusServer/app.yaml:
3182         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
3183
3184 2014-09-11  Andy Estes  <aestes@apple.com>
3185
3186         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
3187         https://bugs.webkit.org/show_bug.cgi?id=136768
3188
3189         Reviewed by Tim Horton.
3190
3191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3192         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
3193         (TestWebKitAPI::TEST):
3194
3195 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3196
3197         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
3198         https://bugs.webkit.org/show_bug.cgi?id=136669
3199
3200         Reviewed by Antti Koivisto.
3201
3202         * Scripts/run-gtk-tests:
3203         (TestRunner): Unskip SSL test.
3204
3205 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
3206
3207         Strip extraneous AVFoundation and CoreMedia logging
3208         https://bugs.webkit.org/show_bug.cgi?id=136747
3209
3210         Reviewed by Jer Noble.
3211
3212         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3213         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
3214
3215         * Scripts/webkitpy/port/base.py:
3216         (Port.stderr_patterns_to_strip): Base class, empty list
3217
3218         * Scripts/webkitpy/port/driver.py:
3219         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
3220
3221         * Scripts/webkitpy/port/ios.py:
3222         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
3223
3224         * Scripts/webkitpy/port/mac.py:
3225         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
3226
3227
3228 2014-09-11  Michael Saboff  <msaboff@apple.com>
3229
3230         lldb_webkit.py:btjs doesn't work with release builds
3231         https://bugs.webkit.org/show_bug.cgi?id=136760
3232
3233         Reviewed by Jer Noble.
3234
3235         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
3236         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
3237         we can't get a valid result from trying either call.  In that case, we fallback to
3238         just showing the PC.  Also added check for both entry points.  If neither is found,
3239         we issue a warning and output the stack trace without JavaScript annotations.
3240
3241         * lldb/lldb_webkit.py:
3242         (btjs):
3243
3244 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
3245
3246         webkitpy test failures from import-w3c-tests
3247         https://bugs.webkit.org/show_bug.cgi?id=136752
3248
3249         Reviewed by Bem Jones-Bey.
3250
3251         This patch fixes a bug in import-w3c-tests where we were appending
3252         the wrong set of files to the copy_list. This also updates the tests
3253         to clear the failures introduced in the patch for bug 135929.
3254
3255         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3256         (W3CTestConverterTest.test_read_prefixed_property_list):
3257         * Scripts/webkitpy/w3c/test_parser.py:
3258         (TestParser.analyze_test):
3259         (TestParser.support_files):
3260         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3261
3262 2014-09-10  Brent Fulgham  <bfulgham@apple.com>
3263
3264         Blink merge: Speculative fix for windows run-webkit-tests hangs
3265         https://bugs.webkit.org/show_bug.cgi?id=136727
3266
3267         Reviewed by Csaba Osztrogonác.
3268
3269         Merged from Blink (patch by Dirk Pranke):
3270         <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
3271
3272         * Scripts/webkitpy/common/system/executive.py:
3273         (Executive.kill_process):
3274
3275 2014-09-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3276
3277         Added myself as a committer.
3278
3279         Unreviewed.
3280
3281         * Scripts/webkitpy/common/config/contributors.json:
3282
3283 2014-09-11  László Langó  <llango.u-szeged@partner.samsung.com>
3284
3285         [JavaScriptCore] Fix FTL on platform EFL.
3286         https://bugs.webkit.org/show_bug.cgi?id=133571
3287
3288         Reviewed by Filip Pizlo.
3289
3290         * efl/install-dependencies: Revert r169181.
3291         * efl/jhbuild.modules: Clone and build a custom branch.
3292         This branch contains some fix for FTL of platform EFL.
3293         The branch is a fork of llvm r206311.
3294
3295 2014-09-10  Tanay C  <tanay.c@samsung.com>
3296
3297         [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
3298         https://bugs.webkit.org/show_bug.cgi?id=136698
3299
3300         Reviewed by Gyuyoung Kim.
3301
3302         * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
3303         (on_mouse_wheel): Added.
3304         (window_free):
3305         (window_create):
3306
3307 2014-09-10  Rohit Kumar  <kumar.rohit@samsung.com>
3308
3309         [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
3310         https://bugs.webkit.org/show_bug.cgi?id=136284
3311
3312         Reviewed by Gyuyoung Kim.
3313
3314         * MiniBrowser/efl/main.c:
3315         (window_create):
3316
3317 2014-09-10  Rebecca Hauck  <rhauck@adobe.com>
3318
3319         import-w3c-tests doesn't handle relative paths to support files in ref files correctly
3320         https://bugs.webkit.org/show_bug.cgi?id=135929
3321
3322         Reviewed by Bem Jones-Bey.
3323
3324         The recent refactor of the W3C test repo falsified a bunch of assmumptions that
3325         were made when this script was originally written with respect to relative paths
3326         in ref files. This patch updates import-w3c-tests to update paths in ref files if
3327         they move relative to the test file.
3328
3329
3330         * Scripts/webkitpy/w3c/test_converter.py:
3331         (convert_for_webkit):
3332         (_W3CTestConverter.__init__):
3333         (_W3CTestConverter.convert_reference_relpaths):
3334         (_W3CTestConverter.convert_style_data):
3335         (_W3CTestConverter.convert_attributes_if_needed):
3336         * Scripts/webkitpy/w3c/test_importer.py:
3337         (TestImporter.find_importable_tests):
3338         (TestImporter.import_tests):
3339         * Scripts/webkitpy/w3c/test_parser.py:
3340         (TestParser.load_file):
3341         (TestParser.analyze_test):
3342         (TestParser.support_files):
3343
3344 2014-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3345
3346         [GTK] allow overwriting destination of download
3347         https://bugs.webkit.org/show_bug.cgi?id=136372
3348
3349         Reviewed by Carlos Garcia Campos.
3350
3351         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3352         (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
3353         (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
3354         (createFileAtDestination): Added
3355         (testDownloadOverwriteDestinationAllowed): Added
3356         (testDownloadOverwriteDestinationDisallowed): Added
3357         (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
3358         (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
3359         (beforeAll): New tests
3360
3361 2014-08-05  David Farler  <dfarler@apple.com>
3362
3363         iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
3364         https://bugs.webkit.org/show_bug.cgi?id=135551
3365
3366         Reviewed by Daniel Bates.
3367
3368         Prevent printing invalid Unicode strings going to stderr.
3369         Also, make filesystem.py more tolerant about receiving
3370         Unicode (encoded as UTF-8) when writing to files, in the
3371         rare case that an NSError description will make it to
3372         stderr, such as -[LTRelayController createUniqueApp].
3373
3374         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3375         (-[LTRelayController launchSimulator]): Removed.
3376         (-[LTRelayController createUniqueApp]):
3377         Don't explicitly try to uninstall the app. It is automatically handled
3378         when installing an app with the same bundle identifier.
3379         (-[LTRelayController start]):
3380         (-[LTRelayController bootDevice]): Removed.
3381         The device already boots as a part of starting the simulator. Attempting
3382         to boot a second time may cause spurious stderr output.
3383         * Scripts/webkitpy/port/driver.py:
3384         (IOSSimulatorDriver._setup_environ_for_driver):
3385         Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
3386         Open the iOS Simulator once instead of the LayoutTestRelay trying
3387         to do it.
3388         * Scripts/webkitpy/port/ios.py:
3389         (IOSSimulatorPort._get_crash_log):
3390         Make sure stderr is at least an empty string.
3391         (IOSSimulatorPort):
3392         (IOSSimulatorPort.developer_dir):
3393         New property for setting up DEVELOPER_DIR in the driver environment.
3394
3395 2014-09-09  Dan Bernstein  <mitz@apple.com>
3396
3397         Clean up the MiniBrowser Xcode project
3398         https://bugs.webkit.org/show_bug.cgi?id=136684
3399
3400         Reviewed by Tim Horton.
3401
3402         * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
3403         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
3404         WebKit2.framework. Upgraded project file version.
3405
3406 2014-09-09  Daniel Bates  <dbates@webkit.org>
3407
3408         svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
3409         https://bugs.webkit.org/show_bug.cgi?id=136379
3410
3411         Reviewed by David Kilzer.
3412
3413         Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
3414         a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
3415         and sets a property on F (say, the executable bit).
3416
3417         * Scripts/svn-apply:
3418         (patch): Only add file if the diff has text chunks.
3419         * Scripts/svn-unapply:
3420         (patch): Only delete added file if the diff has text chunks.
3421
3422 2014-09-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3423
3424         [GTK] Unreviewed GTK gardening.
3425
3426         * Scripts/run-gtk-tests:
3427         (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
3428
3429 2014-09-09  Christophe Dumez  <cdumez@apple.com>
3430
3431         Update my email in contributors.json
3432         https://bugs.webkit.org/show_bug.cgi?id=136671
3433
3434         Reviewed by Andreas Kling.
3435
3436         * Scripts/webkitpy/common/config/contributors.json:
3437
3438 2014-09-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3439
3440         [EFL] Enable fixed layout by default
3441         https://bugs.webkit.org/show_bug.cgi?id=136607
3442
3443         Reviewed by Csaba Osztrogonác.
3444
3445         Fixed layout is being used by Tizen platform by default. However, the feature
3446         has still many defects now. So, we need to enable it by default, then should fix
3447         those bugs. 
3448
3449         * MiniBrowser/efl/main.c:
3450
3451 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3452
3453         Remove FILTERS flag
3454         https://bugs.webkit.org/show_bug.cgi?id=136571
3455
3456         Reviewed by Darin Adler.
3457
3458         * Scripts/webkitperl/FeatureList.pm:
3459
3460 2014-09-08  Alexey Proskuryakov  <ap@apple.com>
3461
3462         Dashboard metrics should ignore commits that didn't trigger builds
3463         https://bugs.webkit.org/show_bug.cgi?id=136618
3464
3465         Reviewed by Darin Adler.
3466
3467         Commits that didn't trigger builds are ones like ChangeLog updates, patches for
3468         other platforms etc. It does not make sense to count wait time for these, as it
3469         can be arbitrarily long.
3470
3471         The new algorithm is much slower asymptotically, but it's OK, computers are fast.
3472
3473         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3474         (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
3475
3476         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3477         We used to walk the timeline to see which revisions are fully tested, but that's not
3478         correct. A revision that's only tested by a subset of queues finishes independently
3479         of another that's tested by another subset. Now, we just search for the answer for
3480         each revision individually.
3481
3482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
3483         (MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
3484         the analyzer now reports. Removed best time, which is more confusing than meaningful.
3485
3486 2014-09-08  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3487
3488         Remove EWebLauncher from webkitdirs.pm
3489         https://bugs.webkit.org/show_bug.cgi?id=136622
3490
3491         Reviewed by Gyuyoung Kim.
3492
3493         * Scripts/webkitdirs.pm:
3494         (launcherName):
3495
3496 2014-09-06  Sam Weinig  <sam@webkit.org>
3497
3498         XPCPtr should be converted into an all purpose smart pointer for os_objects
3499         https://bugs.webkit.org/show_bug.cgi?id=136602
3500
3501         Reviewed by Darin Adler.
3502
3503         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3504         * TestWebKitAPI/Tests/WTF/darwin: Added.
3505         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
3506         Add basic unit tests for OSObjectPtr.
3507
3508 2014-09-06  Saam Barati  <saambarati1@gmail.com>
3509
3510         Unreviewed. Add myself as a committer.
3511
3512         * Scripts/webkitpy/common/config/contributors.json:
3513
3514 2014-09-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3515
3516         Unreviewed, EFL build fix when SHARED_CORE is on.
3517
3518         * TestWebKitAPI/PlatformEfl.cmake:
3519
3520 2014-09-05  Lucas Forschler  <lforschler@apple.com>
3521
3522         <https://webkit.org/b/136586> Add bots to Apple build/test queues
3523         
3524         Reviewed by Daniel Bates.
3525
3526         * BuildSlaveSupport/build.webkit.org-config/config.json:
3527
3528 2014-09-05  Alexey Proskuryakov  <ap@apple.com>
3529
3530         Buildbot metrics page gives wrong results after a new bot gets added
3531         https://bugs.webkit.org/show_bug.cgi?id=136516
3532
3533         Reviewed by Tim Horton.
3534
3535         Part 2: Fix elapsed times.
3536
3537         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3538         (Analyzer.prototype._countTimes): Made lastTestedRevisionByQueue contain undefined values
3539         until the first build in a queue. This happens to work as needed with _fullyTestedRevisionNumber().
3540
3541 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3542
3543         [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
3544         https://bugs.webkit.org/show_bug.cgi?id=136562
3545
3546         Reviewed by Martin Robinson.
3547
3548         * Scripts/run-gtk-tests:
3549         (TestRunner): Remove failure expectations for tests that now pass.
3550
3551 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
3552
3553         Dashboard metrics page wastes a lot of time sorting iterations
3554         https://bugs.webkit.org/show_bug.cgi?id=136559
3555
3556         Reviewed by Tim Horton.
3557
3558         Also fixes comments here and there, and adds a missing "var".
3559
3560         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3561         (BuildbotIteration.prototype._parseData):
3562         (BuildbotIteration.prototype._updateWithData):
3563         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3564         (BuildbotQueue.prototype.loadAll):
3565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3566         (Analyzer.prototype._countTimes):
3567
3568 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3569
3570         [GTK] Unreviewed GTK gardening.
3571
3572         * Scripts/run-gtk-tests:
3573         (TestRunner): Skip tests failing since r173272.
3574
3575 2014-09-04  Simon Fraser  <simon.fraser@apple.com>
3576
3577         Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
3578         https://bugs.webkit.org/show_bug.cgi?id=136561
3579
3580         Reviewed by Tim Horton.
3581         
3582         Log for calloc() and CGBitmapContextCreate() failures.
3583
3584         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3585         (createBitmapContext):
3586         (createBitmapContextFromWebView):
3587
3588 2014-09-04  Andy Estes  <aestes@apple.com>
3589
3590         Fix the Mac Production build after r173283.
3591
3592         * WebKitTestRunner/config.h: Reverted to defining WEBCORE_EXPORT for now.
3593
3594 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
3595
3596         [Win] webkitpy test suite frequently fails to complete
3597         https://bugs.webkit.org/show_bug.cgi?id=136546
3598
3599         Reviewed by Daniel Bates.
3600
3601         Properly convert the ASCII crash log produced by ntsd into
3602         a unicode string as early as possible so that we handle it
3603         properly when generating our logs and other test support output.
3604
3605         We were mixing ASCII/unicode strings under Windows, which was
3606         causing test system failures when we processed some crash logs.
3607
3608         Also do a better job of handling garbage pid entries in the
3609         Cygwin lock files.
3610
3611         * Scripts/webkitpy/common/system/crashlogs.py:
3612         (CrashLogs._find_newest_log_win): The ntsd '.logopen' command
3613         creates an ASCII file. Decode it as ASCII, not 'utf-8', and
3614         handle the strings as unicode from that point on.
3615         * Scripts/webkitpy/port/http_lock.py:
3616         (HttpLock._current_lock_pid): Add logging and handle case of
3617         the current_pid failing to cleanly convert to 'int'.
3618         * Scripts/webkitpy/port/win.py:
3619         (WinPort): Add 64-bit architecture as a known target for the
3620         Windows build.
3621
3622 2014-09-04  Andy Estes  <aestes@apple.com>
3623
3624         Address additional review feedback after landing r173283.
3625
3626         Reviewed by Daniel Bates.
3627
3628         * DumpRenderTree/config.h: Removed redundant includes.
3629         * TestWebKitAPI/config.h: Ditto.
3630         * WebKitTestRunner/config.h: Ditto.
3631
3632 2014-09-03  Andy Estes  <aestes@apple.com>
3633
3634         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
3635         https://bugs.webkit.org/show_bug.cgi?id=136521
3636
3637         Reviewed by Anders Carlsson.
3638
3639         * DumpRenderTree/config.h: Included <WebCore/PlatformExportMacros.h> instead of defining WEBCORE_EXPORT.
3640         * TestWebKitAPI/config.h: Ditto.
3641         * WebKitTestRunner/config.h: Ditto.
3642
3643 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
3644
3645         REGRESSION: Dashboard metrics page aggregation counts performance bots
3646         https://bugs.webkit.org/show_bug.cgi?id=136539
3647
3648         Reviewed by Tim Horton.
3649
3650         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3651
3652 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
3653
3654         [Win] Perl test fix.
3655
3656         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Correct test to check for
3657         VersionStamp.exe tool, not just the driver script.
3658
3659 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3660
3661         Remove CSS_FILTERS flag
3662         https://bugs.webkit.org/show_bug.cgi?id=136529
3663
3664         Reviewed by Dirk Schulze.
3665
3666         * Scripts/webkitperl/FeatureList.pm:
3667
3668 2014-09-04  Commit Queue  <commit-queue@webkit.org>
3669
3670         Unreviewed, rolling out r173201.
3671         https://bugs.webkit.org/show_bug.cgi?id=136538
3672
3673         Improves the situation but also introduces additional crashes.
3674         (Requested by zdobersek on #webkit).
3675
3676         Reverted changeset:
3677
3678         "GMainLoopSource is exposed to race conditions"
3679         https://bugs.webkit.org/show_bug.cgi?id=135800
3680         http://trac.webkit.org/changeset/173201
3681
3682 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
3683
3684         Buildbot metrics page gives wrong results after a new bot gets added
3685         https://bugs.webkit.org/show_bug.cgi?id=136516
3686
3687         Part 1: Fix red/green counters. Dashboard is considered green at a given time
3688         if all the bots that ever had results before this time are green.
3689
3690         This doesn't (and cannot) address situations where the bot gets removed and then
3691         re-added. It also gives wrong results after a bot gets removed, because it doesn't
3692         know that it was ever displayed on the dashboard.
3693
3694         Reviewed by Darin Adler.
3695
3696         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3697         (Analyzer.prototype._dashboardIsAllGreen):
3698         (Analyzer.prototype._updateStretchOfRedCounters):
3699         (Analyzer.prototype._countPercentageOfGreen):
3700         (Analyzer.prototype._allQueuesAreSuccessful): Deleted.
3701
3702 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
3703
3704         [Win] Unreviewed test fix.
3705
3706         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Don't fail
3707         test if user doesn't have the VersionStamp.exe program.
3708
3709 2014-09-03  Dana Burkart  <dburkart@apple.com>
3710
3711         Unreviewed. Add myself as a committer.
3712
3713         * Scripts/webkitpy/common/config/contributors.json:
3714
3715 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
3716
3717         build.webkit.org/dashboard performance popover is unstyled
3718         https://bugs.webkit.org/show_bug.cgi?id=136499
3719
3720         Reviewed by Tim Horton.
3721
3722         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3723         (.performance-popover):
3724         (.performance-popover .dashboard-link):
3725
3726 2014-09-03  Saam Barati  <saambarati1@gmail.com>
3727
3728         Create tests for type profiling
3729         https://bugs.webkit.org/show_bug.cgi?id=136161
3730
3731         Reviewed by Geoffrey Garen.
3732
3733         Have run-javascriptcore-tests run the newly created
3734         tests for the type profiler.
3735
3736         * Scripts/run-javascriptcore-tests:
3737         * Scripts/run-jsc-stress-tests:
3738
3739 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
3740
3741         [Win] Revise test environment for Windows build.
3742         https://bugs.webkit.org/show_bug.cgi?id=136486
3743
3744         Reviewed by David Kilzer.
3745
3746         The various calls to get the Safari path really only have
3747         meaning on the Mac. Other ports get access to the build
3748         and test environment separately, so remove the various
3749         checks in the Safari-specific code to simplify things.
3750
3751         Remove some 64-bit hacks used on Windows now that the
3752         various tools know how to find the 64-bit runtime environment.
3753
3754         * Scripts/run-javascriptcore-tests: 
3755         * Scripts/webkitdirs.pm:
3756         (safariPathFromSafariBundle): Revise to expect Mac.
3757         (installedSafariPath): Ditto.
3758         (safariPath): Ditto.
3759         (appleApplicationSupportPath): Get rid of 64-bit Windows hack.
3760         (setPathForRunningWebKitApp): Get rid of unused SafariPath
3761         argument for Windows runs.
3762
3763 2014-09-03  Dana Burkart  <dburkart@apple.com>
3764
3765         Dashboard should show performance bots.
3766         https://bugs.webkit.org/show_bug.cgi?id=136386
3767
3768         Reviewed by Alexey Proskuryakov.
3769
3770         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3771         (BuildbotIteration.prototype._parseData.collectPerfTestResults):
3772         (BuildbotIteration.prototype._parseData):
3773         Support possible performance failures.
3774
3775         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
3776         New QueueView to manage the way we present performance data.
3777
3778         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3779         (BuildbotQueue):
3780         Support new 'performance' and 'performanceTestName' keys.
3781
3782
3783         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3784         Add performance column to the main page.
3785
3786         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3787         (WebKitBuildbot):
3788         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3789         (body):
3790         Make sure everything fits on 13 inch screens.
3791
3792         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3793
3794 2014-09-03  Zan Dobersek  <zdobersek@igalia.com>
3795
3796         GMainLoopSource is exposed to race conditions
3797         https://bugs.webkit.org/show_bug.cgi?id=135800
3798
3799         Reviewed by Carlos Garcia Campos.
3800
3801         Add a unit test for GMainLoopSource that tests different
3802         types of rescheduling tasks on already-active sources.
3803
3804         * TestWebKitAPI/PlatformGTK.cmake:
3805         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
3806         (GMainLoopSourceTest::GMainLoopSourceTest):
3807         (GMainLoopSourceTest::~GMainLoopSourceTest):
3808         (GMainLoopSourceTest::runLoop):
3809         (GMainLoopSourceTest::finish):
3810         (GMainLoopSourceTest::source):
3811         (testGMainLoopSourceBasicRescheduling):
3812         (testGMainLoopSourceReentrantRescheduling):
3813         (testGMainLoopSourceDifferentThreadRescheduling):
3814         (beforeAll):
3815         (afterAll):
3816         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
3817         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
3818         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
3819         (TestWebKitAPI::GMainLoopSourceTest::finish):
3820         (TestWebKitAPI::GMainLoopSourceTest::source):
3821         (TestWebKitAPI::TEST):
3822
3823 2014-09-02  Simon Fraser  <simon.fraser@apple.com>
3824
3825         Make sure WK1 prefs are initialized in MiniBrowser
3826         https://bugs.webkit.org/show_bug.cgi?id=136465
3827
3828         Reviewed by Tim Horton.
3829         
3830         Call -didChangeSettings from -awakeFromNib for WK1 windows just as we do
3831         for WK2 windows, to make sure that WebPreferences are updated (to get
3832         layer borders to work consistently).
3833
3834         * MiniBrowser/mac/WK1BrowserWindowController.m:
3835         (-[WK1BrowserWindowController awakeFromNib]):
3836
3837 2014-09-02  Renato Nagy  <rnagy@inf.u-szeged.hu>
3838
3839         check-webkit-style should complain about C++ comments in Platform.h
3840         https://bugs.webkit.org/show_bug.cgi?id=133802
3841
3842         Reviewed by Csaba Osztrogonác.
3843
3844         * Scripts/webkitpy/style/checkers/cpp.py:
3845         (check_platformh_comments):
3846         (_process_lines):
3847         (CppChecker):
3848         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3849         (CppStyleTest.test_platformh_comment):
3850
3851 2014-09-02  Brendan Long  <self@brendanlong.com>
3852
3853         [Gtk] Make install-dependencies work on Arch Linux
3854         https://bugs.webkit.org/show_bug.cgi?id=136374
3855
3856         Reviewed by Philippe Normand.
3857
3858         * gtk/install-dependencies: Add dependencies for pacman (Arch Linux).
3859
3860 2014-09-01  Brian J. Burg  <burg@cs.washington.edu>
3861
3862         Provide column numbers to DTrace willExecute/didExecute probes
3863         https://bugs.webkit.org/show_bug.cgi?id=136434
3864
3865         Reviewed by Antti Koivisto.
3866
3867         Create a directory for DTrace scripts. Add an example script that
3868         shows how to use static probes provided by JavaScriptCore's profiler.
3869
3870         * Scripts/dtrace/jsc-trace-profiler-events.d: Added.
3871
3872 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3873
3874         [GTK] [JHBuild] Cyclic dependency between cairo and librsvg.
3875         https://bugs.webkit.org/show_bug.cgi?id=136431
3876
3877         Reviewed by Martin Robinson.
3878
3879         * gtk/jhbuild.modules: Disable cairo SVG testsuite.
3880         Add missing dependencies for librsvg (glib and cairo).
3881
3882 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3883
3884         [GTK] install-dependencies don't installs dbus-launch that is needed for the API tests.
3885         https://bugs.webkit.org/show_bug.cgi?id=136425
3886
3887         Reviewed by Martin Robinson.
3888
3889         * gtk/install-dependencies: Add dbus-x11 to the list of packages needed for running the tests.
3890
3891 2014-09-01  Ryuan Choi  <ryuan.choi@samsung.com>
3892
3893         Update my list of email addresses in contributors.json
3894         https://bugs.webkit.org/show_bug.cgi?id=136424
3895
3896         Reviewed by Gyuyoung Kim.
3897
3898         * Scripts/webkitpy/common/config/contributors.json:
3899
3900 2014-08-30  Filip Pizlo  <fpizlo@apple.com>
3901
3902         [RJST] eager-no-cjit should really mean eager
3903         https://bugs.webkit.org/show_bug.cgi?id=136407
3904
3905         Reviewed by Mark Hahnenberg.
3906         
3907         At some point we made NO_CJIT_OPTIONS force threshold settings to something reasonable
3908         and well-known. But the way we appended options was such that NO_CJIT_OPTIONS came in
3909         after EAGER_OPTIONS. The whole point of "eager" was to use eager tier-up thresholds. This
3910         all meant that NO_CJIT_OPTIONS was overriding the eagerness of EAGER_OPTIONS, for the one
3911         threshold setting that NO_CJIT_OPTIONS was currently setting
3912         (thresholdForJITAfterWarmUp). The solution is to make sure that we always append
3913         NO_CJIT_OPTIONS before we append EAGER_OPTIONS.
3914         
3915         Luckily, no tests regressed during the time that we lost eager-no-cjit coverage.
3916
3917         * Scripts/run-jsc-stress-tests:
3918
3919 2014-08-29  Daniel Bates  <dabates@apple.com>
3920
3921         [iOS] Configure Xcode to build a command line tool for the iOS Simulator
3922         https://bugs.webkit.org/show_bug.cgi?id=136388
3923
3924         Reviewed by David Kilzer.
3925
3926         Add a script, called configure-xcode-for-ios-development, to configure Xcode to
3927         support building a command line tool for the iOS Simulator. You must run this
3928         script as root.
3929
3930         The script uses the xcspec files in the OS X SDK to create xcspec files in the
3931         iOS Simulator SDK with the product- and package- type definitions to build a
3932         command line tool, if applicable.
3933
3934         * Scripts/configure-xcode-for-ios-development: Added.
3935
3936 2014-08-29  Tim Horton  <timothy_horton@apple.com>
3937
3938         Remove Windows WebKit2 code from TestWebKitAPI
3939         https://bugs.webkit.org/show_bug.cgi?id=136385
3940
3941         Reviewed by Alexey Proskuryakov.
3942
3943         * TestWebKitAPI/PlatformUtilities.h:
3944         * TestWebKitAPI/PlatformWebView.h:
3945         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Deleted.
3946         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
3947         (TestWebKitAPI::TEST): Deleted.
3948         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3949         (TestWebKitAPI::TEST):
3950         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3951         (TestWebKitAPI::TEST):
3952         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Removed.
3953         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Removed.
3954         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Removed.
3955         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Removed.
3956         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Removed.
3957         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Removed.
3958         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Removed.
3959
3960 2014-08-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3961
3962         [JSC] Some JSC tests are dependent on the machine time zone.
3963         https://bugs.webkit.org/show_bug.cgi?id=136363
3964
3965         Reviewed by Filip Pizlo.
3966
3967         * Scripts/run-javascriptcore-tests: Export TZ environment variable to US/Pacific.
3968         Unskip the tests that were skipped on r99580.
3969
3970 2014-08-29  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3971
3972         [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
3973         https://bugs.webkit.org/show_bug.cgi?id=135560
3974
3975         Reviewed by Gyuyoung Kim.
3976
3977         * Scripts/webkitperl/FeatureList.pm: Removed TILED_BACKING_STORE guard.
3978
3979 2014-08-28  Daniel Bates  <dabates@apple.com>
3980
3981         [Win] update-webkit should update auxiliary libs by default
3982
3983         Reviewed by Dan Bernstein.
3984
3985         The change set <http://trac.webkit.org/changeset/172795> inadvertently prevented update-webkit
3986         from updating the Windows auxiliary libs by default. We should make update-webkit update the
3987         Windows auxiliary libs by default. This will make its behavior match its usage text.
3988
3989         * Scripts/update-webkit:
3990
3991 2014-08-28  Brian J. Burg  <burg@cs.washington.edu>
3992
3993         build-webkit --inspector-frontend tries to copy files from old inspector path
3994         https://bugs.webkit.org/show_bug.cgi?id=136346
3995
3996         Reviewed by Timothy Hatcher.
3997
3998         Remove the old code path for copying inspector resources. It doesn't work.
3999         Complain if this option is passed to CMake-based builds.
4000
4001         * Scripts/build-webkit:
4002         * Scripts/webkitdirs.pm:
4003         (copyInspectorFrontendFiles): Deleted.
4004
4005 2014-08-28  Alexey Proskuryakov  <ap@apple.com>
4006
4007         Dashboard metrics page could show longest stretch of red
4008         https://bugs.webkit.org/show_bug.cgi?id=136334
4009
4010         Reviewed by Sam Weinig.
4011
4012         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
4013         (Analyzer.prototype._updateStretchOfRedCounters):
4014         (Analyzer.prototype._countPercentageOfGreen):
4015         When counting percentage of green, also keep track of how long the page was red.
4016
4017         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
4018         (MetricsView.prototype._update.addDivider):
4019         (MetricsView.prototype._update.appendQueueResults):
4020         Show it in aggregate queues (can't think of a reason to have it in individual ones).
4021
4022         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
4023         Changed to use an explicit divider element between green time and performance groups,
4024         as there are too many combinations to easily express in CSS.
4025
4026 2014-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
4027
4028         [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
4029         https://bugs.webkit.org/show_bug.cgi?id=136248
4030
4031         Reviewed by Gustavo Noronha Silva.
4032
4033         Add new test case for webkit_uri_response_get_http_headers().
4034
4035         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
4036         (testURIResponseHTTPHeaders):
4037         (serverCallback):
4038         (beforeAll):
4039
4040 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
4041
4042         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
4043         https://bugs.webkit.org/show_bug.cgi?id=131668
4044
4045         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
4046         (EWSQueue.prototype.loadDetailedStatus): Fixed a typo in assertion.
4047
4048 2014-08-27  Zalan Bujtas  <zalan@apple.com>
4049
4050         Subpixel layout: Cleanup snapSizeToPixel/snapSizeToDevicePixel.
4051         https://bugs.webkit.org/show_bug.cgi?id=136264
4052
4053         Reviewed by Simon Fraser.
4054         
4055         1. Align snapSizeToPixel()/snapSizeToDevicePixel() function names with the rest of snapping
4056         functions. ->snappedIntSize()/snapSizeToDevicePixel().
4057         2. Operate on LayoutSize/LayoutPoint instead of LayoutUnit/LayoutUnit to reflect functionality.
4058
4059         Covered by existing tests.
4060
4061         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
4062         (TestWebKitAPI::TEST): Deleted.
4063
4064 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
4065
4066         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
4067         https://bugs.webkit.org/show_bug.cgi?id=131668
4068
4069         Reviewed by Daniel Bates.
4070
4071         We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
4072         to not just hardcode.
4073
4074         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
4075         (EWS.prototype.queueStatusURL): Added.
4076
4077         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
4078         (EWSQueue.prototype.get statusPageURL): Use the above function.
4079         (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
4080
4081         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
4082         (EWSQueueView.prototype.update): While at it, made a popover show up even if there
4083         are no patches in the queue. The popover has other useful information, such as charts
4084         link and bot status.
4085
4086 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
4087
4088         https://bugs.webkit.org/show_bug.cgi?id=136317
4089         Dashboard metrics page sometimes shows 0 for best time
4090
4091         Reviewed by Tim Horton.
4092
4093         This also affects regular dashboard display in a good way - iterations that failed
4094         due to infrastructure misbehavior will more reliably show up as yellow and not red.
4095
4096         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4097         (BuildbotIteration): Added a list of steps that we actually care about. It will need to be
4098         updated if we rename steps.
4099         (BuildbotIteration.prototype.get productive): Now that computation is more involved,
4100         do it once.
4101         (BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
4102         that failed e.g. at downloading built archive step are not productive.
4103
4104 2014-08-27  Brent Fulgham  <bfulgham@apple.com>
4105
4106         [Win] Unreviewed gardening.
4107
4108         * win/AssembleBuildLogs/AssembleLogs.cmd: Add some missing build logs to the set
4109         of logs assembled into the final build output.
4110
4111 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
4112
4113         build.webkit.org/dashboard: Add a metrics page with overall bot performance results
4114         https://bugs.webkit.org/show_bug.cgi?id=136196
4115
4116         Reviewed by Timothy Hatcher.
4117
4118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External: Added.
4119         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Added.
4120         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery-1.11.1.min.js: Added.
4121         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Added.
4122         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Added.
4123         A date range picker control with dependencies.
4124         There are a few modifications from upstream at <https://github.com/longbill/jquery-date-range-picker>:
4125         - Fixed a bug where selected dates were not at midnight the first time a range was chosen
4126         (it didn't happen again upon re-opening the picker).
4127         - Made made style tweaks to match Dashboard UI.
4128
4129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
4130         Don't create objects that are not needed by the given app, and thus are not loaded at all.
4131
4132         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: Added.
4133         Math to count all the things. Only supports open source tree and trunk at the moment,
4134         but written with internal tree and branches in mind.
4135
4136         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: Added.
4137         Like dashboard Main.js, draws the UI and creates all necessary objects.
4138
4139         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js: Added.
4140         A view for table cells.
4141
4142         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
4143         (Settings.prototype.toggleSettingsDisplay): Added an event for entering settings.
4144         Metrics page has individual platforms initially scrolled away form the view, so 
4145         it needs to scroll down to reveal what's being configured.
4146
4147         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
4148         Added Array.prototype.average and Array.prototype.median.
4149
4150         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4151         Made gear icon fixed instead of absolute, so that it's visible on metrics page when
4152         in settings mode.
4153
4154         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
4155         Additional style rules.
4156
4157         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
4158         The metrics page.
4159
4160 2014-08-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4161
4162         Remove networkinfo watch category in watchlist
4163         https://bugs.webkit.org/show_bug.cgi?id=136279
4164
4165         Reviewed by Alexey Proskuryakov.
4166
4167         Network info was removed. So, it is not needed anymore.
4168
4169         * Scripts/webkitpy/common/config/watchlist:
4170
4171 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
4172
4173         build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
4174         https://bugs.webkit.org/show_bug.cgi?id=136281
4175
4176         Reviewed by Tim Horton.
4177
4178         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4179         Track and expose whether the itertion is being loaded. Made update() a no-op if
4180         the iteration is already being loaded.
4181
4182         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
4183         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
4184         loading everything at once, ask the queue to load a little more. We can always repeat
4185         if we still don't have enough data.
4186
4187         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
4188         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
4189         10 more iterations intelligently.
4190
4191 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
4192
4193         build.webkit.org/dashboard raises an exception when Trac RSS fails to load
4194         https://bugs.webkit.org/show_bug.cgi?id=136283
4195
4196         Reviewed by Tim Horton.
4197
4198         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
4199         Don't.
4200
4201 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
4202
4203         build.webkit.org/dashboard raises an exception after a hidden platform is removed
4204         https://bugs.webkit.org/show_bug.cgi?id=136282
4205
4206         Reviewed by Tim Horton.
4207
4208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
4209         (updateHiddenPlatforms): Check that the platform is still valid.
4210
4211 2014-08-26  Matt Lilek  <mrl@apple.com>
4212
4213         Add WebKit SPI to control the navigator.standalone property
4214         https://bugs.webkit.org/show_bug.cgi?id=136189
4215
4216         Reviewed by Andy Estes.
4217
4218         Add API test for WKPreferences
4219
4220         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4221         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
4222         (TEST):
4223
4224 2014-08-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4225
4226         Remove ENABLE_DRT environment variable to enable SHARED_CORE
4227         https://bugs.webkit.org/show_bug.cgi?id=136205
4228
4229         Reviewed by Andrei Bucur.
4230
4231         EFL port doesn't need to enable SHARED_CORE since r172894. Thus, we don't need to
4232         use ENABLE_DRT enviroment variable, which enables SHARED_CORE.
4233
4234         * Scripts/webkitdirs.pm:
4235         (generateBuildSystemFromCMakeProject):
4236
4237 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
4238
4239         [Win] Version stamp should include package-level version
4240         https://bugs.webkit.org/show_bug.cgi?id=136266
4241         <rdar://problem/18134138>
4242
4243         Reviewed by David Kilzer.
4244
4245         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add
4246         tests for the full 3+ digit version.
4247         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
4248         Confirm that the final output DLL uses the 3+ digit version.
4249
4250 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
4251
4252         [Win] WebKit IDL incorrectly passes HWND as OLE_HANDLE
4253         https://bugs.webkit.org/show_bug.cgi?id=136258
4254         <rdar://problem/18134138>
4255
4256         Reviewed by Tim Horton.
4257
4258         Avoid 32/64-bit truncation by preventing 64-bit HWND (and other)
4259         values from passing through the 32-bit OLE_HANDLE data type.
4260
4261         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4262         (AccessibilityController::rootElement):
4263         * DumpRenderTree/win/DumpRenderTree.cpp:
4264         (resetWebViewToConsistentStateBeforeTesting):
4265         (runTest):
4266         (createWebViewAndOffscreenWindow):
4267         * DumpRenderTree/win/FrameLoadDelegate.h:
4268         (FrameLoadDelegate::didReceiveIcon):
4269         * DumpRenderTree/win/TestRunnerWin.cpp:
4270         (TestRunner::setWindowIsKey):
4271         * DumpRenderTree/win/UIDelegate.cpp:
4272         (UIDelegate::trackCustomPopupMenu):
4273         (UIDelegate::drawHeaderInRect):
4274         (UIDelegate::drawFooterInRect):
4275         (UIDelegate::webViewClose):
4276         (UIDelegate::webViewFocus):
4277         (UIDelegate::webViewSetCursor):
4278         (UIDelegate::drawBackground):
4279         * DumpRenderTree/win/UIDelegate.h:
4280         (UIDelegate::webViewFirstResponder):
4281         (UIDelegate::makeFirstResponder):
4282         (UIDelegate::contextMenuItemsForElement):
4283         (UIDelegate::addCustomMenuDrawingData):
4284         (UIDelegate::cleanUpCustomMenuDrawingData):
4285         (UIDelegate::webViewLostFocus):
4286         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
4287         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
4288         * WinLauncher/PrintWebUIDelegate.cpp:
4289         (PrintWebUIDelegate::drawHeaderInRect):
4290         (PrintWebUIDelegate::drawFooterInRect):
4291         * WinLauncher/PrintWebUIDelegate.h:
4292         (PrintWebUIDelegate::webViewFirstResponder):
4293         (PrintWebUIDelegate::makeFirstResponder):
4294         (PrintWebUIDelegate::contextMenuItemsForElement):
4295         (PrintWebUIDelegate::trackCustomPopupMenu):