Make DLLLauncherMain executables dependent on dll
[WebKit-https.git] / Tools / ChangeLog
1 2015-08-27  Alex Christensen  <achristensen@webkit.org>
2
3         Make DLLLauncherMain executables dependent on dll
4         https://bugs.webkit.org/show_bug.cgi?id=148548
5
6         Reviewed by Brent Fulgham.
7
8         * DumpRenderTree/CMakeLists.txt:
9         * DumpRenderTree/PlatformWin.cmake:
10         * MiniBrowser/win/CMakeLists.txt:
11         * TestWebKitAPI/CMakeLists.txt:
12         * TestWebKitAPI/PlatformWin.cmake:
13
14 2015-08-27  Lucas Forschler  <lforschler@apple.com>
15
16         Remove Mac slaves 188/189 after being replaced with 400/401.
17         
18         Unreviewed.
19         
20         * BuildSlaveSupport/build.webkit.org-config/config.json:
21
22 2015-08-27  Lucas Forschler  <lforschler@apple.com>
23
24         Add two bots to the Mac Yosemite queue.
25         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
26         
27         Unreviewed.
28         
29         * BuildSlaveSupport/build.webkit.org-config/config.json:
30
31 2015-08-27  Alex Christensen  <achristensen@webkit.org>
32
33         [Win CMake] Fix incremental build after r188673
34         https://bugs.webkit.org/show_bug.cgi?id=148539
35
36         Reviewed by Brent Fulgham.
37
38         * TestWebKitAPI/PlatformWin.cmake:
39         Copy forwarding headers from WebCore before building in case that was not yet done.
40         It used to be done when running CMake, but now it's a build step.
41
42 2015-08-27  Nan Wang  <n_wang@apple.com>
43
44         AX: Fix accessibility/select-element-at-index.html test
45         https://bugs.webkit.org/show_bug.cgi?id=148516
46
47         Reviewed by Chris Fleizach.
48
49         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
50
51         * DumpRenderTree/AccessibilityUIElement.cpp:
52         (setSelectedChildCallback):
53         (setSelectedChildAtIndexCallback):
54         (removeSelectionAtIndexCallback):
55         (elementAtPointCallback):
56         (sentenceAtOffsetCallback):
57         (stringForSelectionCallback):
58         (AccessibilityUIElement::getJSClass):
59         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
60         (AccessibilityUIElement::setSelectedChild):
61         (AccessibilityUIElement::setSelectedChildAtIndex):
62         (AccessibilityUIElement::removeSelectionAtIndex):
63         (AccessibilityUIElement::accessibilityValue):
64         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
65         (WTR::AccessibilityUIElement::wordAtOffset):
66         (WTR::AccessibilityUIElement::lineAtOffset):
67         (WTR::AccessibilityUIElement::sentenceAtOffset):
68         (WTR::AccessibilityUIElement::isSelectable):
69         (WTR::AccessibilityUIElement::isMultiSelectable):
70         (WTR::AccessibilityUIElement::setSelectedChild):
71         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
72         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
73         (WTR::AccessibilityUIElement::selectedChildrenCount):
74         (WTR::AccessibilityUIElement::selectedChildAtIndex):
75         (WTR::AccessibilityUIElement::isExpanded):
76         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
77         (WTR::AccessibilityUIElement::setSelectedChild):
78         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
79         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
80         (WTR::AccessibilityUIElement::accessibilityValue):
81
82 2015-08-27  Alex Christensen  <achristensen@webkit.org>
83
84         Build fix after r188982
85
86         * MiniBrowser/win/CMakeLists.txt:
87         The directory structure changed in the move.
88
89 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
90
91         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
92
93         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
94
95         * gtk/install-dependencies:
96
97 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
98
99         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
100
101         * Scripts/run-gtk-tests:
102         (TestRunner):
103
104 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
105
106         Fix GTK+ WTR crashes in initializeMainRunLoop()
107
108         Rubber-stamped by Žan Doberšek.
109
110         Initialize threading and main thread before
111         RunLoop::initializeMainRunLoop(), since the GLib implementation of
112         the RunLoop uses isMainThread() to decide whether to create a new
113         GMainContext or use the default one. Also use RunLoop::run() and
114         ::stop() instead of gtk_main/quit.
115
116         * WebKitTestRunner/TestController.cpp:
117         (WTR::TestController::initialize):
118         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
119         (WTR::TestController::notifyDone):
120         (WTR::TestController::platformRunUntil):
121
122 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
123
124         Unreviewed, further shorten a test that times out because it's very long
125         running.
126
127         I've locally run these tests on repeat for 24 hours and found no genuine
128         failures, like deadlocks. So, the timeouts are probably because the test
129         machine is slow and debug is slow. We should just run this test for fewer
130         iterations.
131
132         * TestWebKitAPI/Tests/WTF/Lock.cpp:
133         (TestWebKitAPI::TEST):
134
135 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
136
137         Unreviewed build fix attempt on EFL
138
139         * WebKitTestRunner/PlatformEfl.cmake:
140
141 2015-08-26  Alex Christensen  <achristensen@webkit.org>
142
143         Build fix after r188982
144
145         * MiniBrowser/win/CMakeLists.txt:
146         Find .rc files in correct directory.
147
148 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
149
150         [EFL] Bump cairo version to 1.14.2
151         https://bugs.webkit.org/show_bug.cgi?id=148474
152
153         Reviewed by Csaba Osztrogonác.
154
155         * efl/jhbuild.modules:
156
157 2015-08-26  Andy Estes  <aestes@apple.com>
158
159         Crash when following a Google search link to Twitter with Limit Adult Content enabled
160         https://bugs.webkit.org/show_bug.cgi?id=147651
161
162         Rubber-stamped by Brady Eidson.
163
164         Taught TestRunner how to decide the navigation policy after a delay.
165
166         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
167         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
168         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
169         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
170         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
171         * WebKitTestRunner/InjectedBundle/TestRunner.h:
172         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
173         * WebKitTestRunner/TestController.cpp:
174         (WTR::TestController::initialize):
175         (WTR::TestController::resetStateToConsistentValues):
176         (WTR::TestController::decidePolicyForNavigationAction):
177         * WebKitTestRunner/TestController.h:
178         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
179         * WebKitTestRunner/TestInvocation.cpp:
180         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
181
182 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
183
184         [Win] Rename 'WinLauncher' to 'MiniBrowser'
185         https://bugs.webkit.org/show_bug.cgi?id=148485
186
187         Reviewed by Alex Christensen
188
189         Move the WinLauncher project and source files to a subdirectory
190         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
191         source code and project files.
192         
193         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
194         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
195         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
196         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
197         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
198         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
199         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
200         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
201         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
202         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
203         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
204         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
205         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
206         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
207         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
208         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
209         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
210         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
211         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
212         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
213         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
214         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
215         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
216         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
217         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
218         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
219         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
220         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
221         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
222         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
223         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
224         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
225         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
226         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
227         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
228         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
229         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
230         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
231         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
232         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
233         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
234         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
235         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
236         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
237         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
238         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
239         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
240         * MiniBrowser/win: Copied from WinLauncher.
241         * MiniBrowser/win/Common.cpp:
242         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
243         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
244         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
245         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
246         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
247         * MiniBrowser/win/PageLoadTestClient.cpp:
248         * MiniBrowser/win/PageLoadTestClient.h:
249         * MiniBrowser/win/ResourceLoadDelegate.cpp:
250         * MiniBrowser/win/ResourceLoadDelegate.h:
251         * MiniBrowser/win/WinLauncher.cpp: Removed.
252         * MiniBrowser/win/WinLauncher.h: Removed.
253         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
254         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
255         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
256         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
257         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
258         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
259         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
260         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
261         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
262         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
263         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
264         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
265         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
266         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
267         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
268         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
269         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
270         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
271         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
272         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
273         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
274         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
275         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
276         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
277         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
278         * MiniBrowser/win/WinLauncherReplace.h: Removed.
279         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
280         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
281         * MiniBrowser/win/WinMain.cpp:
282         * WinLauncher: Removed.
283         * WinLauncher/AccessibilityDelegate.cpp: Removed.
284         * WinLauncher/AccessibilityDelegate.h: Removed.
285         * WinLauncher/CMakeLists.txt: Removed.
286         * WinLauncher/Common.cpp: Removed.
287         * WinLauncher/DOMDefaultImpl.cpp: Removed.
288         * WinLauncher/DOMDefaultImpl.h: Removed.
289         * WinLauncher/PageLoadTestClient.cpp: Removed.
290         * WinLauncher/PageLoadTestClient.h: Removed.
291         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
292         * WinLauncher/PrintWebUIDelegate.h: Removed.
293         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
294         * WinLauncher/ResourceLoadDelegate.h: Removed.
295         * WinLauncher/WebDownloadDelegate.cpp: Removed.
296         * WinLauncher/WebDownloadDelegate.h: Removed.
297         * WinLauncher/WinLauncher.cpp: Removed.
298         * WinLauncher/WinLauncher.h: Removed.
299         * WinLauncher/WinLauncher.vcxproj: Removed.
300         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
301         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
302         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
303         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
304         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
305         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
306         * WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
307         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
308         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
309         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
310         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
311         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
312         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
313         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
314         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
315         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
316         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
317         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
318         * WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
319         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
320         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
321         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
322         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
323         * WinLauncher/WinLauncher.vcxproj/small.ico: Removed.
324         * WinLauncher/WinLauncherReplace.h: Removed.
325         * WinLauncher/WinLauncherWebHost.cpp: Removed.
326         * WinLauncher/WinLauncherWebHost.h: Removed.
327         * WinLauncher/WinMain.cpp: Removed.
328         * WinLauncher/resource.h: Removed.
329         * WinLauncher/stdafx.cpp: Removed.
330         * WinLauncher/stdafx.h: Removed.
331         * win/AssembleBuildLogs/AssembleLogs.cmd:
332
333 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
334
335         [Win] Simplify menu handling code in WinLauncher
336         https://bugs.webkit.org/show_bug.cgi?id=148461
337
338         Reviewed by Zalan Bujtas.
339
340         Revise 'ToggleMenuItem' to return a boolean value indicating if
341         it handled the message. Revise WndProc to use this to decide if it
342         should pass the message on to the default handler, rather than
343         duplicating the logic in both places.
344         
345         * WinLauncher/Common.cpp:
346         (ToggleMenuItem): Return true if the menu item message was handled.
347         (WndProc): If 'ToggleMenuItem' did not handle the message, pass
348         the message tothe default handler.
349
350 2015-08-26  Csaba Osztrogonác  <ossy@webkit.org>
351
352         Remove unused code after r188948
353         https://bugs.webkit.org/show_bug.cgi?id=148467
354
355         Reviewed by Gyuyoung Kim.
356
357         * WebKitTestRunner/TestController.cpp:
358         (WTR::TestController::platformPreferences): Deleted.
359
360 2015-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
361
362         [EFL][GTK] REGRESSION(r188828): All performance tests and almost all layout tests crash
363         https://bugs.webkit.org/show_bug.cgi?id=148377
364
365         Reviewed by Carlos Garcia Campos.
366
367         EFL and GTK don't support TestController::platformPreferences() yet which was introduced by r188828.
368         It caused all crashes of layout test and performance test on EFL and GTK. So this patch implements
369         TestController::platformPreferences() using WKPageGroupGetPreferences() which was previous thing for
370         EFL and GTK at the moment.
371
372         * WebKitTestRunner/TestController.cpp:
373         (WTR::TestController::platformWillRunTest):
374         * WebKitTestRunner/efl/TestControllerEfl.cpp:
375         (WTR::TestController::platformPreferences):
376         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
377         (WTR::TestController::platformPreferences):
378
379 2015-08-25  Nan Wang  <n_wang@apple.com>
380
381         AX: Enable accessibility/aria-controls.html test for mac
382         https://bugs.webkit.org/show_bug.cgi?id=148458
383
384         Reviewed by Chris Fleizach.
385
386         Implemented ariaControlsElementAtIndex(unsigned index).
387
388         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
389         (AccessibilityUIElement::ariaControlsElementAtIndex):
390         (AccessibilityUIElement::disclosedRowAtIndex):
391         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
392         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
393
394 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
395
396         Remove python tests for PassRefPtr 
397         https://bugs.webkit.org/show_bug.cgi?id=148463
398
399         Reviewed by Andy Estes.
400
401         As we're removing uses of PassRefPtr, we need to remove all python tests for PassRefPtr as well.
402
403         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
404         (PassPtrTest): Deleted.
405         (PassPtrTest.assert_pass_ptr_check): Deleted.
406         (PassPtrTest.test_pass_ref_ptr_in_function): Deleted.
407         (PassPtrTest.test_pass_other_type_ptr_in_function): Deleted.
408         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
409         (PassPtrTest.test_ref_ptr_parameter_value): Deleted.
410         (PassPtrTest.test_ref_ptr_member_variable): Deleted.
411         (PassPtrTest.test_ref_ptr_member_variable.Foo): Deleted.
412
413 2015-08-25  Andy Estes  <aestes@apple.com>
414
415         [iOS] run-webkit-tests fails if watchOS SDK is installed
416         https://bugs.webkit.org/show_bug.cgi?id=148453
417
418         Reviewed by David Kilzer.
419
420         * Scripts/webkitpy/xcode/simulator.py:
421         (Simulator): Taught Simulator how to parse watchOS runtimes and devices.
422         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
423
424 2015-08-25  Aakash Jain  <aakash_jain@apple.com>
425
426         iOS Simulator layout-tests fail to start while cleaning a directory structure if simulator is already running
427         https://bugs.webkit.org/show_bug.cgi?id=148197
428         rdar://problem/22334382
429
430         Reviewed by Daniel Bates.
431
432         * BuildSlaveSupport/kill-old-processes: Add Simulator to the list of processes to kill (for iOS builders).
433         * Scripts/webkitpy/port/ios.py:
434         (IOSSimulatorPort): Converted bundle id com.apple.iphonesimulator to a variable SIMULATOR_BUNDLE_ID.
435         (IOSSimulatorPort._quitIOSSimulator): Common function to quit iOS Simulator.
436         (IOSSimulatorPort.clean_up_test_run): Quit the simulator during the cleanup.
437         (IOSSimulatorPort.check_sys_deps): No need to quit the simulator here as its now being quit in reset_preferences().
438         (IOSSimulatorPort.reset_preferences): Quit the simulator before trying to delete associated data directory.
439
440 2015-08-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
441
442         Remove PassRefPtr style check rule
443         https://bugs.webkit.org/show_bug.cgi?id=148432
444
445         Reviewed by Andreas Kling.
446
447         PassRefPtr is being removed. Thus style rule needs to be removed as well.
448
449         * Scripts/webkitpy/style/checkers/cpp.py:
450         (_check_parameter_name_against_text): Deleted.
451         (check_function_definition_and_pass_ptr): Deleted.
452         (check_function_definition): Deleted.
453         (check_pass_ptr_usage): Deleted.
454         (process_line): Deleted.
455         (CppChecker): Deleted.
456
457 2015-08-25  Brent Fulgham  <bfulgham@apple.com>
458
459         [Win] Expose "Inverted Colors" option in WinLauncher
460         https://bugs.webkit.org/show_bug.cgi?id=148451
461
462         Reviewed by Tim Horton.
463
464         Add the ability to toggle the "Inverted Colors" preference
465         in WinLauncher.
466         
467         * WinLauncher/Common.cpp:
468         (ToggleMenuItem): Toggle the feature when the menu item
469         is selected.
470         (WndProc): Recognize the new menu option.
471         * WinLauncher/WinLauncher.cpp:
472         (WinLauncher::setToDefaultPreferences): Launch with "Invert
473         Colors" turned off.
474         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu
475         entry for "Invert Colors".
476         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
477
478 2015-08-25  Nan Wang  <n_wang@apple.com>
479
480         [Mac] accessibility/document-attributes.html fails
481         https://bugs.webkit.org/show_bug.cgi?id=116636
482
483         Reviewed by Chris Fleizach.
484
485         Implemented documentURI() and documentEncoding().
486
487         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
488         (AccessibilityUIElement::documentEncoding):
489         (AccessibilityUIElement::documentURI):
490         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
491         (WTR::AccessibilityUIElement::documentEncoding):
492         (WTR::AccessibilityUIElement::documentURI):
493
494 2015-08-24  Brent Fulgham  <bfulgham@apple.com>
495
496         [Win] Unreviewed test gardening.
497
498         Fix another case where the logging string is constructed using the variable 'frame',
499         but the method argument is not given a name. This causes the global 'frame' value to
500         be used, producing incorrect output.
501
502         * DumpRenderTree/win/FrameLoadDelegate.cpp:
503         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Use 'frame'
504         argument.
505
506 2015-08-24  Tim Horton  <timothy_horton@apple.com>
507
508         (Finally...) get rid of WKViewIOS
509         https://bugs.webkit.org/show_bug.cgi?id=148404
510
511         Reviewed by Anders Carlsson.
512
513         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
514         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
515         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
516         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
517         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
518         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
519         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
520         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
521         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
522         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
523         Mark tests that use WKBrowsingContextController as Mac-only.
524
525         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
526         (WTR::AccessibilityController::addNotificationListener):
527         * WebKitTestRunner/ios/mainIOS.mm:
528         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
529         Import UIKit instead of depending on WKView.h to do so.
530
531 2015-08-24  Jason Marcell  <jmarcell@apple.com>
532
533         Add support to dashboard for displaying Git SHA's as revisions.
534         https://bugs.webkit.org/show_bug.cgi?id=148387
535
536         Reviewed by Daniel Bates.
537
538         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
539         (parseRevisionProperty): Added support to dashboard for displaying Git SHA's as revisions.
540         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
541         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
542         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added
543         "isSVN" property to Dashboard.Repository.(OpenSource|Internal).
544
545 2015-08-24  Andy Estes  <aestes@apple.com>
546
547         REGRESSION (r188851): WebKit2.BundleParameters fails on iOS
548
549         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Specify LD_RUNPATH_SEARCH_PATHS correctly for iOS.
550
551 2015-08-23  Andy Estes  <aestes@apple.com>
552
553         Addressed a missed piece of review feedback from r188851.
554
555         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
556
557 2015-08-23  Andy Estes  <aestes@apple.com>
558
559         [Content Filtering] REGRESSION (r182356): Provisional URL is incorrect in didReceiveServerRedirectForProvisionalLoadForFrame when Content Filtering is enabled
560         https://bugs.webkit.org/show_bug.cgi?id=147872
561         rdar://problem/22044000
562
563         Reviewed by Dan Bernstein.
564         
565         Added an API test.
566
567         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Linked libWebCoreTestSupport in order to use MockContentFilter.
568         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
569         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added.
570         (-[ServerRedirectNavigationDelegate webView:didStartProvisionalNavigation:]): Expect the initial request URL.
571         (-[ServerRedirectNavigationDelegate webView:didReceiveServerRedirectForProvisionalNavigation:]): Expect the redirect URL.
572         (-[ServerRedirectNavigationDelegate webView:didCommitNavigation:]):
573         (TEST): Tested that -[WKWebView URL] is updated after a redirect when content filtering is enabled.
574         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added.
575         (+[ServerRedirectPlugIn initialize]): Enable MockContentFilter.
576         * TestWebKitAPI/cocoa/TestProtocol.h: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.h.
577         * TestWebKitAPI/cocoa/TestProtocol.mm: Renamed from Tools/TestWebKitAPI/mac/TestProtocol.mm.
578
579 2015-08-23  Andy Estes  <aestes@apple.com>
580
581         Fixed the 32-bit Mac build after r188844.
582
583         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
584         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
585
586 2015-08-22  Andy Estes  <aestes@apple.com>
587
588         [Cocoa] API tests using the Modern WebKit API should be able to create web process plug-ins
589         https://bugs.webkit.org/show_bug.cgi?id=148317
590
591         Reviewed by Dan Bernstein.
592
593         Added the ability for Modern WebKit API tests to create WKWebProcessPlugIns. A test can create a plug-in by
594         creating a class that conforms to WKWebProcessPlugIn, adding it to the WebProcessPlugIn target, and using the
595         WKWebViewConfiguration returned by +[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]
596         when creating WKWebViews.
597
598         Since TestWebKitAPI relies on a bundle parameter to know which test class to instantiate in the plug-in, I also
599         added a new API test for bundle parameters.
600
601         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Added. Named the bundle TestWebKitAPI.wkbundle and
602         named its executable TestWebKitAPI.bundle.
603         * TestWebKitAPI/PlatformUtilities.h: Declared TestPlugInClassNameParameter.
604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added the WebProcessPlugIn target.
605         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm: Added.
606         (TEST): Tested bundle parameters by verifying that parameter changes in the UI process are observed in the bundle.
607         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm: Added.
608         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]): Started observing changes to a
609         bundle parameter and asked for an initial notification.
610         (-[BundleParametersPlugIn dealloc]): Stopped observing changes to a bundle parameter.
611         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): When a bundle parameter changes,
612         mirror its value in the main frame's JSContext.
613         * TestWebKitAPI/WKWebViewConfigurationExtras.h: Added.
614         * TestWebKitAPI/WKWebViewConfigurationExtras.mm: Added.
615         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Created a configuration with
616         TestWebKitAPI's bundle URL and set a bundle parameter indicating the test plug-in's class name.
617         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Defined TestPlugInClassNameParameter.
618         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added. Set the principal class to WebProcessPlugIn.
619         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm: Added.
620         (-[WebProcessPlugIn webProcessPlugIn:initializeWithObject:]): Forwarded to a newly-created test class instance.
621         (-[WebProcessPlugIn respondsToSelector:]): Returned YES if the test class instance response.
622         (-[WebProcessPlugIn forwardingTargetForSelector:]): Forwarded unimplemented methods to the test class instance.
623
624 2015-08-23  Csaba Osztrogonác  <ossy@webkit.org>
625
626         URTBF after r188828.
627
628         * WebKitTestRunner/PlatformWebView.h:
629
630 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
631
632         build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
633         https://bugs.webkit.org/show_bug.cgi?id=148356
634
635         Reviewed by Darin Adler.
636
637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
638         (BuildbotCombinedQueueView.prototype.update):
639
640 2015-08-23  Alexey Proskuryakov  <ap@apple.com>
641
642         build.webkit.org/dashboard: Respect step's hidden flag
643         https://bugs.webkit.org/show_bug.cgi?id=148357
644
645         Reviewed by Darin Adler.
646
647         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
648         (BuildbotIteration.prototype._parseData):
649
650 2015-08-23  Nan Wang  <n_wang@apple.com>
651
652         AX: Fix accessibility/deleting-iframe-destroys-axcache.html test
653         https://bugs.webkit.org/show_bug.cgi?id=148328
654
655         Reviewed by Darin Adler.
656
657         We should only expose stringValue() when value attribute is set.
658
659         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
660         (AccessibilityUIElement::stringValue):
661         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
662         (WTR::AccessibilityUIElement::stringValue):
663
664 2015-08-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
665
666         Remove style checking rule regarding OwnPtr and PassOwnPtr
667         https://bugs.webkit.org/show_bug.cgi?id=148360
668
669         Reviewed by Darin Adler.
670
671         OwnPtr and PassOwnPtr were totally removed though, style rule is still alive.
672         Removed it.
673
674         * Scripts/do-webcore-rename:
675         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
676         (PassPtrTest.test_pass_own_ptr_in_function): Deleted.
677         (PassPtrTest.test_pass_ref_ptr_return_value): Deleted.
678         (PassPtrTest.test_own_ptr_parameter_value): Deleted.
679         (WebKitStyleTest.test_names): Deleted.
680
681 2015-08-22  Timothy Horton  <timothy_horton@apple.com>
682
683         WebKitTestRunner should use WKWebView on OS X and iOS
684         https://bugs.webkit.org/show_bug.cgi?id=143743
685         <rdar://problem/16947123>
686
687         Reviewed by Anders Carlsson.
688         Patch by Enrica Casucci and myself.
689
690         * WebKitTestRunner/PlatformWebView.h:
691         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
692         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
693         instead of WKContext and WKPageGroup.
694
695         Remove the unused, always-true windowSnapshotEnabled().
696         While technically some platforms don't have window snapshotting,
697         they just return null instead of implementing windowSnapshotEnabled().
698
699         * WebKitTestRunner/TestController.h:
700         * WebKitTestRunner/TestController.cpp:
701         (WTR::TestController::createOtherPage):
702         (WTR::TestController::initialize):
703         (WTR::TestController::createWebViewWithOptions):
704         Delegate to the various platforms for creating PlatformWebView instances,
705         for creating WKContexts, and for accessing WKPreferences,
706         so that they can do special things (like, use WKWebView instead!).
707
708         (WTR::TestController::resetPreferencesToConsistentValues):
709         Make explicit WebKitTestRunner's desired default for two preferences
710         which have differing defaults between the antique and modern API,
711         for consistency's sake.
712
713         (WTR::TestController::resetStateToConsistentValues):
714         Add platformResetStateToConsistentValues.
715
716         * WebKitTestRunner/TestInvocation.cpp:
717         (WTR::TestInvocation::dumpResults):
718         Adjust to the aforementioned removal of windowSnapshotEnabled().
719
720         * WebKitTestRunner/ios/TestControllerCocoa.mm:
721         (WTR::TestController::platformResetStateToConsistentValues):
722         (WTR::TestController::platformPreferences):
723         (WTR::TestController::platformCreateWebView):
724         (WTR::TestController::platformCreateOtherPage):
725         (WTR::TestController::platformInitializeConfiguration):
726         Implement the new platform functions for the Modern WebKit2 API,
727         in a new TestControllerCocoa file that is shared between iOS and Mac.
728         
729         For platformMaybeCreateContext, use the trick that we know we can cast
730         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
731         WKWebView's configuration.
732
733         Ditto for WKPreferencesRef and WKPreferences.
734
735         Remove user content filters on the WKWebView's userContentController.
736
737         * WebKitTestRunner/mac/TestControllerMac.mm:
738         * WebKitTestRunner/ios/TestControllerIOS.mm:
739         Move code into TestControllerCocoa.
740
741         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
742         (WTR::InjectedBundle::beginTesting):
743         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
744         (WTR::TestRunner::addUserScript):
745         (WTR::TestRunner::addUserStyleSheet):
746         Adopt WKBundlePage API for user scripts/sheets.
747
748         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
749         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
750         Make and keep a WKWebView instead of a WKView.
751         
752         * WebKitTestRunner/mac/EventSenderProxy.mm:
753         (WTR::EventSenderProxy::mouseUp):
754         (WTR::EventSenderProxy::mouseMoveTo):
755         Reach inside the WKWebView to the WKView when dispatching events.
756         This is fairly ugly and we should come up with a better solution.
757         Also, fix some flipping and style errors.
758
759 2015-08-22  Michael Catanzaro  <mcatanzaro@igalia.com>
760
761         Unreviewed, attempt to fix GTK build after r188718
762
763         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
764         (WTR::PlatformWebView::PlatformWebView):
765
766 2015-08-21  Commit Queue  <commit-queue@webkit.org>
767
768         Unreviewed, rolling out r188807, r188813, and r188815.
769         https://bugs.webkit.org/show_bug.cgi?id=148349
770
771         lots of 32-bit build problems, better to resolve separately
772         and try again (Requested by thorton on #webkit).
773
774         Reverted changesets:
775
776         "WebKitTestRunner should use WKWebView on OS X and iOS"
777         https://bugs.webkit.org/show_bug.cgi?id=143743
778         http://trac.webkit.org/changeset/188807
779
780         "Stop building WebKitTestRunner for 32-bit platforms"
781         https://bugs.webkit.org/show_bug.cgi?id=143743
782         http://trac.webkit.org/changeset/188813
783
784         "Stop building WebKitTestRunner for 32-bit platforms"
785         https://bugs.webkit.org/show_bug.cgi?id=143743
786         http://trac.webkit.org/changeset/188815
787
788 2015-08-21  Tim Horton  <timothy_horton@apple.com>
789
790         Stop building WebKitTestRunner for 32-bit platforms
791         https://bugs.webkit.org/show_bug.cgi?id=143743
792         <rdar://problem/16947123>
793
794         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
795         This is a restriction on the valid set, not the desired set.
796
797 2015-08-21  Jason Marcell  <jmarcell@apple.com>
798
799         Make Dashboard.Branches be objects of the form (repository, "branch name") and update existing code
800         to work with these new objects.
801         https://bugs.webkit.org/show_bug.cgi?id=148188
802
803         Reviewed by Daniel Bates.
804
805         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
806         (Buildbot.prototype._normalizeQueueInfo): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
807         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
808         (BuildbotCombinedQueueView): Changed to work with new branch objects which represent a
809         (repository, "branch name")-pair.
810         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Ditto.
811         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
812         (BuildbotQueue): Renamed BuildbotQueue.branch to BuildbotQueue.branches.
813         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
814         (BuildbotQueueView.prototype._appendPendingRevisionCount): Changed to work with new branch
815         objects which represent a (repository, "branch name")-pair.
816         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
817         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
818         (BuildbotQueueView.prototype._addDividerToPopover): Ditto.
819         (BuildbotQueueView.prototype.revisionContentForIteration): Ditto.
820         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Renamed
821         BuildbotQueue.branch to BuildbotQueue.branches.
822         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
823         (WebKitBuildbot.prototype.get defaultBranches): Changed to new (repository, "branch name") format.
824
825 2015-08-21  Tim Horton  <timothy_horton@apple.com>
826
827         Stop building WebKitTestRunner for 32-bit platforms
828         https://bugs.webkit.org/show_bug.cgi?id=143743
829         <rdar://problem/16947123>
830
831         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
832         WKWebView is not available on 32-bit OS X.
833
834 2015-08-21  Brent Fulgham  <bfulgham@apple.com>
835
836         [Win] Unreviewed test correction after r188709.
837
838         I removed a function argument that happened to be mirrored by a global
839         value with the same name. This prevented a compile error, but testing
840         showed that the wrong value was being used in the function.
841
842         * DumpRenderTree/win/FrameLoadDelegate.cpp:
843         (FrameLoadDelegate::willPerformClientRedirectToURL): Put function argument
844         back
845
846 2015-08-21  Timothy Horton  <timothy_horton@apple.com>
847
848         WebKitTestRunner should use WKWebView on OS X and iOS
849         https://bugs.webkit.org/show_bug.cgi?id=143743
850         <rdar://problem/16947123>
851
852         Reviewed by Anders Carlsson.
853         Patch by Enrica Casucci and myself.
854
855         * WebKitTestRunner/PlatformWebView.h:
856         (WTR::PlatformWebView::windowSnapshotEnabled): Deleted.
857         Add a PlatformWebView constructor that takes a WKWebViewConfiguration
858         instead of WKContext and WKPageGroup.
859
860         Remove the unused, always-true windowSnapshotEnabled().
861         While technically some platforms don't have window snapshotting,
862         they just return null instead of implementing windowSnapshotEnabled().
863
864         * WebKitTestRunner/TestController.h:
865         * WebKitTestRunner/TestController.cpp:
866         (WTR::TestController::createOtherPage):
867         (WTR::TestController::initialize):
868         (WTR::TestController::createWebViewWithOptions):
869         Delegate to the various platforms for creating PlatformWebView instances,
870         for creating WKContexts, and for accessing WKPreferences,
871         so that they can do special things (like, use WKWebView instead!).
872
873         (WTR::TestController::resetPreferencesToConsistentValues):
874         Make explicit WebKitTestRunner's desired default for two preferences
875         which have differing defaults between the antique and modern API,
876         for consistency's sake.
877
878         (WTR::TestController::resetStateToConsistentValues):
879         Add platformResetStateToConsistentValues.
880
881         * WebKitTestRunner/TestInvocation.cpp:
882         (WTR::TestInvocation::dumpResults):
883         Adjust to the aforementioned removal of windowSnapshotEnabled().
884
885         * WebKitTestRunner/ios/TestControllerCocoa.mm:
886         (WTR::TestController::platformResetStateToConsistentValues):
887         (WTR::TestController::platformPreferences):
888         (WTR::TestController::platformCreateWebView):
889         (WTR::TestController::platformCreateOtherPage):
890         (WTR::TestController::platformInitializeConfiguration):
891         Implement the new platform functions for the Modern WebKit2 API,
892         in a new TestControllerCocoa file that is shared between iOS and Mac.
893         
894         For platformMaybeCreateContext, use the trick that we know we can cast
895         the WKProcessPool to a WKContextRef to retrieve a WKContextRef from
896         WKWebView's configuration.
897
898         Ditto for WKPreferencesRef and WKPreferences.
899
900         Remove user content filters on the WKWebView's userContentController.
901
902         * WebKitTestRunner/mac/TestControllerMac.mm:
903         * WebKitTestRunner/ios/TestControllerIOS.mm:
904         Move code into TestControllerCocoa.
905
906         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
907         (WTR::InjectedBundle::beginTesting):
908         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
909         (WTR::TestRunner::addUserScript):
910         (WTR::TestRunner::addUserStyleSheet):
911         Adopt WKBundlePage API for user scripts/sheets.
912
913         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
914         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
915         Make and keep a WKWebView instead of a WKView.
916         
917         * WebKitTestRunner/mac/EventSenderProxy.mm:
918         (WTR::EventSenderProxy::mouseUp):
919         (WTR::EventSenderProxy::mouseMoveTo):
920         Reach inside the WKWebView to the WKView when dispatching events.
921         This is fairly ugly and we should come up with a better solution.
922         Also, fix some flipping and style errors.
923
924 2015-08-21  Alexey Proskuryakov  <ap@apple.com>
925
926         Improve how UI events are dispatched by WebKitTestRunner
927         https://bugs.webkit.org/show_bug.cgi?id=148326
928
929         Reviewed by Anders Carlsson.
930
931         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
932         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
933         Removed asyncScrolling from mouseScrollByWithWheelAndMomentumPhases, it's now always
934         asynchronous (and really, it has always been for the most part).
935
936         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
937         (WTR::EventSendingController::mouseDown): Updated for WKBundlePagePostSynchronousMessage renaming.
938         (WTR::EventSendingController::mouseUp): Ditto.
939         (WTR::EventSendingController::mouseMoveTo): Ditto.
940         (WTR::EventSendingController::mouseForceDown): Ditto.
941         (WTR::EventSendingController::mouseForceUp): Ditto.
942         (WTR::EventSendingController::mouseForceChanged): Ditto.
943         (WTR::EventSendingController::leapForward): Ditto.
944         (WTR::EventSendingController::scheduleAsynchronousClick): Ditto.
945         (WTR::EventSendingController::keyDown): Ditto.
946         (WTR::EventSendingController::scheduleAsynchronousKeyDown): Ditto.
947         (WTR::EventSendingController::mouseScrollBy): Force a scrolling tree commit. It used
948         to be done in custom WebKit2 code for test wheel event handling.
949         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases): Got rid of sync version.
950         (WTR::EventSendingController::continuousMouseScrollBy): Added a FIXME. This one is weird.
951         (WTR::EventSendingController::contextClick): Updated for WKBundlePagePostSynchronousMessage renaming.
952         (WTR::EventSendingController::addTouchPoint): Ditto.
953         (WTR::EventSendingController::updateTouchPoint): Ditto.
954         (WTR::EventSendingController::setTouchModifier): Ditto.
955         (WTR::EventSendingController::setTouchPointRadius): Ditto.
956         (WTR::EventSendingController::touchStart): Ditto.
957         (WTR::EventSendingController::touchMove): Ditto.
958         (WTR::EventSendingController::touchEnd): Ditto.
959         (WTR::EventSendingController::touchCancel): Ditto.
960         (WTR::EventSendingController::clearTouchPoints): Ditto.
961         (WTR::EventSendingController::releaseTouchPoint): Ditto.
962         (WTR::EventSendingController::cancelTouchPoint): Ditto.
963
964         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
965         (WTR::InjectedBundle::postSetWindowIsKey):
966         (WTR::InjectedBundle::postSimulateWebNotificationClick):
967         (WTR::InjectedBundle::isGeolocationProviderActive):
968         (WTR::InjectedBundle::shouldProcessWorkQueue):
969         Updated for WKBundlePagePostSynchronousMessage renaming.
970
971         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
972         (WTR::TestRunner::secureEventInputIsEnabled): Ditto.
973
974         * WebKitTestRunner/TestController.cpp:
975         (WTR::TestController::initialize): Allow handling the new test style messages.
976         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle): Removed calls
977         to WKPageSetShouldSendEventsSynchronously, which we no longer need.
978         (WTR::TestController::didReceiveMessageFromInjectedBundle):
979         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Moved
980         "MouseScrollBy" to async section, and got rid of WKPageSetShouldSendEventsSynchronously.
981
982         * WebKitTestRunner/mac/EventSenderProxy.mm:
983         (WTR::EventSenderProxy::mouseMoveTo): Got rid of WKPageSetShouldSendEventsSynchronously.
984         (WTR::EventSenderProxy::keyDown): Ditto.
985         (WTR::EventSenderProxy::mouseScrollBy): Ditto.
986         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
987
988 2015-08-21  Yusuke Suzuki  <utatane.tea@gmail.com>
989
990         Skip no-llint tests that fail due to running out of executable memory after r188969
991         https://bugs.webkit.org/show_bug.cgi?id=148273
992
993         Reviewed by Michael Saboff.
994
995         * Scripts/run-jsc-stress-tests:
996
997 2015-08-21  Nan Wang  <n_wang@apple.com>
998
999         [Mac] accessibility/selection-states.html fails
1000         https://bugs.webkit.org/show_bug.cgi?id=116637
1001
1002         Reviewed by Chris Fleizach.
1003
1004         Implemented isSelectable() and isMultiSelectable().
1005
1006         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1007         (AccessibilityUIElement::isSelectable):
1008         (AccessibilityUIElement::isMultiSelectable):
1009         (AccessibilityUIElement::isSelectedOptionActive):
1010         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1011         (WTR::AccessibilityUIElement::isSelectable):
1012         (WTR::AccessibilityUIElement::isMultiSelectable):
1013         (WTR::AccessibilityUIElement::isVisible):
1014
1015 2015-08-21  Jason Marcell  <jmarcell@apple.com>
1016
1017         Fix iteration over repositories on bot watcher's dashboard.
1018
1019         Reviewed by Alexey Proskuryakov.
1020
1021         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1022         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Don't reuse the same index variable.
1023
1024 2015-08-20  Joonghun Park  <jh718.park@samsung.com>
1025
1026         [EFL] Revise PlatformWebView ctor according to r188718
1027         https://bugs.webkit.org/show_bug.cgi?id=148282
1028
1029         This patch change PlatformWebView ctor's argument to use WKPageConfigurationRef
1030         instead of WKContextRef and WKPageGroupRef respectively.
1031
1032         Reviewed by Gyuyoung Kim.
1033
1034         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1035         (WTR::PlatformWebView::PlatformWebView):
1036
1037 2015-08-20  Devin Rousso  <dcrousso+webkit@gmail.com>
1038
1039         Unreviewed, changed Devin Rousso's email.
1040
1041         * Scripts/webkitpy/common/config/contributors.json:
1042
1043 2015-08-20  Anders Carlsson  <andersca@apple.com>
1044
1045         Use WKPageConfigurationRef in WebKitTestRunner
1046         https://bugs.webkit.org/show_bug.cgi?id=147996
1047
1048         Reviewed by Tim Horton.
1049
1050         * WebKitTestRunner/TestController.cpp:
1051         (WTR::TestController::createOtherPage):
1052         (WTR::TestController::initialize):
1053         (WTR::TestController::createWebViewWithOptions):
1054         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1055         (-[TestRunnerWKView initWithFrame:configurationRef:useThreadedScrolling:]):
1056         (WTR::PlatformWebView::PlatformWebView):
1057         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]): Deleted.
1058
1059 2015-08-20  Brent Fulgham  <bfulgham@apple.com>
1060
1061         [Win] Update Windows tools for revised MIDL interfaces
1062         https://bugs.webkit.org/show_bug.cgi?id=148249
1063
1064         Reviewed by Dean Jackson.
1065
1066         This is a follow-up to Bug 148001.
1067
1068         Revise the testing software to use compatible signatures and
1069         implementations to match the requirements of the IDL generated
1070         with the SAL annotations.
1071
1072         * DumpRenderTree/win/DRTDataObject.cpp:
1073         * DumpRenderTree/win/DRTDataObject.h:
1074         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1075         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1076         * DumpRenderTree/win/DRTDropSource.cpp:
1077         * DumpRenderTree/win/DRTDropSource.h:
1078         * DumpRenderTree/win/DumpRenderTree.cpp:
1079         * DumpRenderTree/win/EditingDelegate.cpp:
1080         * DumpRenderTree/win/EditingDelegate.h:
1081         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1082         * DumpRenderTree/win/FrameLoadDelegate.h:
1083         * DumpRenderTree/win/HistoryDelegate.cpp:
1084         * DumpRenderTree/win/HistoryDelegate.h:
1085         * DumpRenderTree/win/PolicyDelegate.cpp:
1086         * DumpRenderTree/win/PolicyDelegate.h:
1087         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1088         * DumpRenderTree/win/ResourceLoadDelegate.h:
1089         * DumpRenderTree/win/TestRunnerWin.cpp:
1090         * DumpRenderTree/win/UIDelegate.cpp:
1091         * DumpRenderTree/win/UIDelegate.h:
1092         * WinLauncher/AccessibilityDelegate.cpp:
1093         * WinLauncher/AccessibilityDelegate.h:
1094         * WinLauncher/Common.cpp:
1095         * WinLauncher/DOMDefaultImpl.cpp:
1096         * WinLauncher/DOMDefaultImpl.h:
1097         * WinLauncher/PageLoadTestClient.cpp:
1098         * WinLauncher/PageLoadTestClient.h:
1099         * WinLauncher/PrintWebUIDelegate.cpp:
1100         * WinLauncher/PrintWebUIDelegate.h:
1101         * WinLauncher/ResourceLoadDelegate.cpp:
1102         * WinLauncher/ResourceLoadDelegate.h:
1103         * WinLauncher/WebDownloadDelegate.cpp:
1104         * WinLauncher/WebDownloadDelegate.h:
1105         * WinLauncher/WinLauncherWebHost.cpp:
1106         * WinLauncher/WinLauncherWebHost.h:
1107         * WinLauncher/WinMain.cpp:
1108         * win/DLLLauncher/DLLLauncherMain.cpp:
1109
1110 2015-08-20  Filip Pizlo  <fpizlo@apple.com>
1111
1112         Unreviewed, shorten a test that runs too long and times out.
1113
1114         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1115         (TestWebKitAPI::TEST):
1116
1117 2015-08-20  Alex Christensen  <achristensen@webkit.org>
1118
1119         Clean up CMake build after r188673
1120         https://bugs.webkit.org/show_bug.cgi?id=148234
1121
1122         Reviewed by Tim Horton.
1123
1124         * DumpRenderTree/PlatformWin.cmake:
1125         * TestWebKitAPI/CMakeLists.txt:
1126         * TestWebKitAPI/PlatformWin.cmake:
1127         Define WIN_CAIRO so WinCairo executables can find the correct dlls in WebKitLibraries.
1128         gtest needs to be a static library on Windows to not crash.
1129
1130 2015-08-19  Alex Christensen  <achristensen@webkit.org>
1131
1132         CMake Windows build should not include files directly from other Source directories
1133         https://bugs.webkit.org/show_bug.cgi?id=148198
1134
1135         Reviewed by Brent Fulgham.
1136
1137         * DumpRenderTree/DumpRenderTreePrefix.h:
1138         Include cmakeconfig.h to properly define all enabled features.
1139         * DumpRenderTree/PlatformWin.cmake:
1140         * TestWebKitAPI/PlatformWin.cmake:
1141
1142 2015-08-19  Alex Christensen  <achristensen@webkit.org>
1143
1144         Build TestWTF on Mac with CMake.
1145         https://bugs.webkit.org/show_bug.cgi?id=147972
1146
1147         Reviewed by Tim Horton.
1148
1149         TestWTF only depends on gtest and WTF instead of TestWebKitAPi depending on all of WebKit.
1150         Now I can run the WTF API tests after a few seconds of building instead of waiting for all of WebKit to build.
1151
1152         * TestWebKitAPI/CMakeLists.txt:
1153         Added WTF as a dependency for platforms that do not have ForwardingHeadersForTestWebKitAPI_NAME.
1154         WTF was already a library that was linked, but having at least one item makes the syntax of add_dependencies work.
1155         * TestWebKitAPI/PlatformMac.cmake: Added.
1156         * TestWebKitAPI/config.h:
1157         Postpone some build fixes until WebKit builds completely on Mac with CMake.
1158
1159 2015-08-19  Brian Burg  <bburg@apple.com>
1160
1161         Unreviewed, add Aleksandr Skachkov to the list of contributors.
1162
1163         * Scripts/webkitpy/common/config/contributors.json:
1164
1165 2015-08-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1166
1167         REGRESSION(r188548): [GTK] Build broken.
1168         https://bugs.webkit.org/show_bug.cgi?id=148154
1169
1170         Reviewed by Martin Robinson.
1171
1172         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1173         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1174         Even if we don't need to add/override any settings in ViewOptions,
1175         we need to define this as an empty function to make it build.
1176
1177 2015-08-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1178
1179         Fix conversion-null warning in conversion.cpp of TestWebKitAPI
1180         https://bugs.webkit.org/show_bug.cgi?id=148073
1181
1182         Reviewed by Alexey Proskuryakov.
1183
1184         * TestWebKitAPI/Tests/WTF/Condition.cpp: Use EXPECT_FALSE instead of EXPECT_EQ.
1185         (TestWebKitAPI::TEST):
1186
1187 2015-08-18  Anders Carlsson  <andersca@apple.com>
1188
1189         Fix test failure fallout from r188602 by using a V5 page ui client struct.
1190
1191         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1192         (TestWebKitAPI::setUpClients):
1193
1194 2015-08-18  Brian Burg  <bburg@apple.com>
1195
1196         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1197         https://bugs.webkit.org/show_bug.cgi?id=147955
1198
1199         Reviewed by Timothy Hatcher.
1200
1201         To enable sharing of common test code between protocol and model tests,
1202         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1203
1204         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1205         protocol-test.js uses to load the inspector frontend stub into its iframe
1206         from an arbitrary local file URL.
1207
1208         * DumpRenderTree/TestRunner.cpp:
1209         (getInspectorTestStubURLCallback):
1210         (TestRunner::staticValues):
1211         * DumpRenderTree/TestRunner.h:
1212         * DumpRenderTree/mac/TestRunnerMac.mm:
1213         (SOFT_LINK_STAGED_FRAMEWORK):
1214         (TestRunner::inspectorTestStubURL):
1215         * DumpRenderTree/win/TestRunnerWin.cpp:
1216         (TestRunner::inspectorTestStubURL):
1217         * WebKitTestRunner/Configurations/Base.xcconfig:
1218         Since WebKitTestRunner now includes WebCore private headers, also search
1219         for the WebCore framework inside the WebKit umbrella framework.
1220
1221         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1222         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1223         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1224         (WTR::TestRunner::inspectorTestStubURL):
1225         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1226         (WTR::TestRunner::inspectorTestStubURL):
1227         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1228         (WTR::TestRunner::inspectorTestStubURL):
1229
1230 2015-08-18  Filip Pizlo  <fpizlo@apple.com>
1231
1232         Unreviewed, fix GTK build.
1233
1234         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1235         (TestWebKitAPI::TEST):
1236
1237 2015-08-17  Filip Pizlo  <fpizlo@apple.com>
1238
1239         Replace all remaining uses of WTF::Mutex with WTF::Lock
1240         https://bugs.webkit.org/show_bug.cgi?id=148089
1241
1242         Reviewed by Geoffrey Garen.
1243
1244         * DumpRenderTree/JavaScriptThreading.cpp:
1245         (javaScriptThreadsMutex):
1246         (runJavaScriptThread):
1247         (startJavaScriptThreads):
1248         (stopJavaScriptThreads):
1249         * TestWebKitAPI/Tests/WTF/Condition.cpp: Fixed a bug in the test that I found from turning the test into a benchmark.
1250         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1251         (TestWebKitAPI::TEST):
1252         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1253         (TestWebKitAPI::TEST):
1254
1255 2015-08-17  Commit Queue  <commit-queue@webkit.org>
1256
1257         Unreviewed, rolling out r188539, r188544, r188552, and
1258         r188564.
1259         https://bugs.webkit.org/show_bug.cgi?id=148122
1260
1261         Broke tests and some build styles (Requested by ap on
1262         #webkit).
1263
1264         Reverted changesets:
1265
1266         "Web Inspector: load ProtocolTestStub from the WebInspectorUI
1267         bundle"
1268         https://bugs.webkit.org/show_bug.cgi?id=147955
1269         http://trac.webkit.org/changeset/188539
1270
1271         "Web Inspector: split TestStub.js into multiple files and
1272         modernize it"
1273         https://bugs.webkit.org/show_bug.cgi?id=148077
1274         http://trac.webkit.org/changeset/188544
1275
1276         "Web Inspector: InspectorTest should be a subclass of
1277         TestHarness"
1278         https://bugs.webkit.org/show_bug.cgi?id=148079
1279         http://trac.webkit.org/changeset/188552
1280
1281         "Unreviewed internal build fix attempt after r188539."
1282         http://trac.webkit.org/changeset/188564
1283
1284 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1285
1286         [OS X] Remove support for composite fonts
1287         https://bugs.webkit.org/show_bug.cgi?id=147920
1288
1289         Reviewed by Dan Bernstein.
1290
1291         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1292         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
1293         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1294         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1295         * DumpRenderTree/mac/DumpRenderTree.mm:
1296         (allowedFontFamilySet): Deleted.
1297         (activateTestingFonts): Deleted.
1298         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1299         (WTR::allowedFontFamilySet): Deleted.
1300         (WTR::activateFonts): Deleted.
1301         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1302         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
1303         * WebKitTestRunner/mac/TestControllerMac.mm:
1304         (WTR::allowedFontFamilySet): Deleted.
1305
1306 2015-08-17  Jon Honeycutt  <jhoneycutt@apple.com>
1307
1308         Unreviewed internal build fix attempt after r188539.
1309
1310         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1311
1312 2015-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1313
1314         Fix the build
1315
1316         Unreviewed.
1317
1318         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
1319
1320 2015-08-17  Alex Christensen  <achristensen@webkit.org>
1321
1322         Build Debug Suffix on Windows with CMake
1323         https://bugs.webkit.org/show_bug.cgi?id=148083
1324
1325         Reviewed by Brent Fulgham.
1326
1327         * TestWebKitAPI/CMakeLists.txt:
1328         * TestWebKitAPI/PlatformWin.cmake:
1329         Add DEBUG_SUFFIX
1330
1331 2015-08-17  Anders Carlsson  <andersca@apple.com>
1332
1333         Simplify how PlatformWebViews are created when view options change
1334         https://bugs.webkit.org/show_bug.cgi?id=148093
1335
1336         Reviewed by Sam Weinig.
1337
1338         Instead of letting each port dictate when the PlatformWebView should be recreated we now do the following:
1339
1340         TestController::ensureViewSupportsOptionsForTest gets the view options for a test by calling
1341         TestController::viewOptionsForTest, which returns a filled in ViewOptions struct for a given test. It also allows
1342         ports to add/override settings by calling TestController::updatePlatformSpecificViewOptionsForTest.
1343
1344         If the current PlatformWebView doesn't support the given view options, delete the web view and create a new one.
1345
1346         Also, get rid of the first call to TestController::createWebViewWithOptions in TestController::initialize and
1347         always rely on TestController::ensureViewSupportsOptionsForTest creating a PlatformWebView for us.
1348
1349         * WebKitTestRunner/TestController.cpp:
1350         (WTR::TestController::ensureViewSupportsOptionsForTest):
1351         (WTR::shouldUseFixedLayout):
1352         (WTR::TestController::viewOptionsForTest):
1353         (WTR::TestController::updateWebViewSizeForTest):
1354         (WTR::TestController::updateWindowScaleForTest):
1355         (WTR::TestController::configureViewForTest):
1356         (WTR::TestController::initialize): Deleted.
1357         (WTR::TestController::ensureViewSupportsOptions): Deleted.
1358         (WTR::TestController::updateLayoutTypeForTest): Deleted.
1359         (WTR::TestController::platformConfigureViewForTest): Deleted.
1360         (WTR::TestController::platformResetPreferencesToConsistentValues): Deleted.
1361         (WTR::TestController::run): Deleted.
1362         * WebKitTestRunner/TestController.h:
1363         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1364         (WTR::shouldUseFixedLayout):
1365         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1366         (WTR::TestController::platformConfigureViewForTest):
1367         (WTR::TestController::platformResetPreferencesToConsistentValues):
1368         * WebKitTestRunner/ios/TestControllerIOS.mm:
1369         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1370         * WebKitTestRunner/mac/TestControllerMac.mm:
1371         (WTR::TestController::updatePlatformSpecificViewOptionsForTest):
1372         (WTR::TestController::platformConfigureViewForTest):
1373
1374 2015-08-17  Sam Weinig  <sam@webkit.org>
1375
1376         API::PageConfiguration's sessionID needs to be set whenever the API::WebsiteDataStore is set
1377         https://bugs.webkit.org/show_bug.cgi?id=148097
1378
1379         Reviewed by Anders Carlsson.
1380
1381         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp:
1382         Add tests for WebsiteDataStores in the WKPageConfiguration.
1383
1384 2015-08-17  Brian Burg  <bburg@apple.com>
1385
1386         Web Inspector: load ProtocolTestStub from the WebInspectorUI bundle
1387         https://bugs.webkit.org/show_bug.cgi?id=147955
1388
1389         Reviewed by Timothy Hatcher.
1390
1391         To enable sharing of common test code between protocol and model tests,
1392         start loading the protocol TestStub.js through the WebInspectorUI bundle.
1393
1394         This patch adds the read-only getter TestRunner.inspectorTestStubURL, which
1395         protocol-test.js uses to load the inspector frontend stub into its iframe
1396         from an arbitrary local file URL.
1397
1398         * DumpRenderTree/TestRunner.cpp:
1399         (getInspectorTestStubURLCallback):
1400         (TestRunner::staticValues):
1401         * DumpRenderTree/TestRunner.h:
1402         * DumpRenderTree/mac/TestRunnerMac.mm:
1403         (SOFT_LINK_STAGED_FRAMEWORK):
1404         (TestRunner::inspectorTestStubURL):
1405         * DumpRenderTree/win/TestRunnerWin.cpp:
1406         (TestRunner::inspectorTestStubURL):
1407         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1408         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1409         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
1410         (WTR::TestRunner::inspectorTestStubURL):
1411         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1412         (WTR::TestRunner::inspectorTestStubURL):
1413         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1414         (WTR::TestRunner::inspectorTestStubURL):
1415
1416 2015-08-17  Saam barati  <sbarati@apple.com>
1417
1418         Change email address from saambarati1@gmail.com to sbarati@apple.com
1419
1420         * Scripts/webkitpy/common/config/contributors.json:
1421
1422 2015-08-17  Jason Marcell  <jmarcell@apple.com>
1423
1424         Refactor BuildbotQueueView._presentPopoverForPendingCommits to work more generically with
1425         repositories other than "openSource" and "internal".
1426         https://bugs.webkit.org/show_bug.cgi?id=147961
1427
1428         Reviewed by Daniel Bates.
1429
1430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1431         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Refactored to work more
1432         generically with repositories other than "openSource" and "internal".
1433
1434 2015-08-17  Alexey Proskuryakov  <ap@apple.com>
1435
1436         build.webkit.org/dashboard shows yellow when crash-only queues have too many failures
1437         https://bugs.webkit.org/show_bug.cgi?id=148081
1438
1439         Reviewed by Tim Horton.
1440
1441         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1442         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1443
1444 2015-08-11  Andy Estes  <aestes@apple.com>
1445
1446         [Cocoa] Add redirect support to CustomProtocolManager
1447         https://bugs.webkit.org/show_bug.cgi?id=147871
1448
1449         Reviewed by Dan Bernstein.
1450
1451         Updated WebKit2CustomProtocolsTest.MainResource to generate a redirect response.
1452
1453         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1454         (TestWebKitAPI::TEST): Unregesitered TestProtocol.
1455         * TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Changed scheme to http.
1456         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1457         (-[CustomProtocolsLoadDelegate browsingContextControllerDidStartProvisionalLoad:]): Expected a certain provisional URL.
1458         (-[CustomProtocolsLoadDelegate browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]): Ditto.
1459         (-[CustomProtocolsLoadDelegate browsingContextControllerDidCommitLoad:]): Expected a certain committed URL.
1460         (-[CustomProtocolsLoadDelegate browsingContextControllerDidFinishLoad:]): Expected isLoading to be false.
1461         (TestWebKitAPI::TEST): Used the new load delegate and unregistered TestProtocol.
1462         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1463         (TestWebKitAPI::TEST): Unregistered TestProtocol.
1464         * TestWebKitAPI/mac/TestProtocol.mm: Changed scheme to http.
1465         (+[TestProtocol canInitWithRequest:]): Changed to use property syntax.
1466         (-[TestProtocol startLoading]): Taught to handle redirect responses.
1467
1468 2015-08-13  Andy Estes  <aestes@apple.com>
1469
1470         [Cocoa] Downloads do not start if policy decision is made asynchronously
1471         https://bugs.webkit.org/show_bug.cgi?id=147985
1472
1473         Reviewed by Brady Eidson.
1474
1475         Added a new API test.
1476
1477         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1478         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1479         (-[AsynchronousDownloadDelegate _downloadDidStart:]):
1480         (TEST):
1481
1482 2015-08-14  Commit Queue  <commit-queue@webkit.org>
1483
1484         Unreviewed, rolling out r187357.
1485         https://bugs.webkit.org/show_bug.cgi?id=148032
1486
1487         webkit-patch generates incorrect patches that cannot be
1488         applied (Requested by dydz on #webkit).
1489
1490         Reverted changeset:
1491
1492         "Call fixChangeLogPatch when generating patches from webkit-
1493         patch"
1494         https://bugs.webkit.org/show_bug.cgi?id=147248
1495         http://trac.webkit.org/changeset/187357
1496
1497 2015-08-14  Jason Marcell  <jmarcell@apple.com>
1498
1499         Refactor BuildbotQueueView._appendPendingRevisionCount to work more generically with repositories
1500         other than "openSource" and "internal".
1501         https://bugs.webkit.org/show_bug.cgi?id=147938
1502
1503         Reviewed by Daniel Bates.
1504
1505         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1506         (BuildbotQueueView.prototype._appendPendingRevisionCount): Refactored to work more generically with
1507         repositories other than "openSource" and "internal".
1508
1509 2015-08-14  Filip Pizlo  <fpizlo@apple.com>
1510
1511         Unreviewed, shorten another test that is timing out.
1512
1513         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1514         (TestWebKitAPI::TEST):
1515
1516 2015-08-13  Aakash Jain  <aakash_jain@apple.com>
1517
1518         AppScale: Assertion hit when hovering a webkit-queue bubble
1519         https://bugs.webkit.org/show_bug.cgi?id=147997
1520
1521         Reviewed by Alexey Proskuryakov.
1522
1523         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
1524         (BubbleQueue.prototype.loadDetailedStatus): Strip off http(s) before asserting.
1525
1526 2015-08-13  Lucas Forschler  <lforschler@apple.com>
1527
1528         Teach Scripts/copy-webkitlibraries-to-product-directory to copy the El Capitan Library.
1529         
1530         Unreviewed.
1531         
1532         * Scripts/copy-webkitlibraries-to-product-directory:
1533
1534 2015-08-13  Dewei Zhu  <dewei_zhu@apple.com>
1535
1536         Run benchmark customized Dromaeo should not assume there is an internet connection.
1537         https://bugs.webkit.org/show_bug.cgi?id=147995
1538
1539         Reviewed by Ryosuke Niwa.
1540
1541         Add several dependency js libs to local.
1542
1543         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
1544
1545 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1546
1547         WTF should have a compact Condition object to use with Lock
1548         https://bugs.webkit.org/show_bug.cgi?id=147986
1549
1550         Reviewed by Geoffrey Garen.
1551
1552         Add a test for WTF::Condition.
1553
1554         * TestWebKitAPI/CMakeLists.txt:
1555         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1556         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1557         * TestWebKitAPI/Tests/WTF/Condition.cpp: Added.
1558         (TestWebKitAPI::TEST):
1559         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1560         (TestWebKitAPI::runLockTest): Change the name of the thread.
1561
1562 2015-08-13  Filip Pizlo  <fpizlo@apple.com>
1563
1564         Unreviewed, shorten another test. It's timing out in debug on some bot.
1565
1566         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1567         (TestWebKitAPI::TEST):
1568
1569 2015-08-12  Filip Pizlo  <fpizlo@apple.com>
1570
1571         WTF::Lock should not suffer from the thundering herd
1572         https://bugs.webkit.org/show_bug.cgi?id=147947
1573
1574         Reviewed by Geoffrey Garen.
1575
1576         Add testing that checks that locks return to a pristine state after contention is over.
1577
1578         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1579         (TestWebKitAPI::LockInspector::isFullyReset):
1580         (TestWebKitAPI::runLockTest):
1581         (TestWebKitAPI::TEST):
1582
1583 2015-08-12  Dewei Zhu  <dewei_zhu@apple.com>
1584
1585         Benchmarks supported by run_benchmark script should not assume we have internet access.
1586         https://bugs.webkit.org/show_bug.cgi?id=147959
1587
1588         Reviewed by Ryosuke Niwa.
1589
1590         For JSBench we should not request jquery.min.js from google through the internet.
1591
1592         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
1593
1594 2015-08-12  Jason Marcell  <jmarcell@apple.com>
1595
1596         Refactor BuildbotQueueView.revisionContentForIteration to work more generically with repositories
1597         other than "openSource" and "internal".
1598         https://bugs.webkit.org/show_bug.cgi?id=147796
1599
1600         Reviewed by Daniel Bates.
1601
1602         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1603         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): The "repository" parameter
1604         is now a repository object instead of the repository name, thus we don't have to pass the "trac"
1605         object in separately. Also added an assertion to see if the given repository is in iteration.revision,
1606         and another assertion that, if the previousIteration is non-null, the given repository is in
1607         previousIteration.revision.
1608         (BuildbotQueueView.prototype.revisionContentForIteration): Refactored to work more generically
1609         with repositories other than "openSource" and "internal". Also added an assertion that the returned
1610         fragment has at least one child node.
1611
1612 2015-08-12  Simon Fraser  <simon.fraser@apple.com>
1613
1614         Add a tool that dumps class and struct member layout, showing padding
1615         https://bugs.webkit.org/show_bug.cgi?id=147898
1616
1617         Reviewed by Zalan Bujtas.
1618         
1619         This 'dump-class-layout' script uses the lldb Python bindings to collect data
1620         about data member layout, and displays it.
1621         
1622         Sample output:
1623
1624               +0 { 72} WTF::ListHashSet<WebCore::URL, WebCore::URLHash>::Node
1625               +0 < 56>     WebCore::URL m_value;
1626               +0 <  8>         WTF::String m_string;
1627               +0 <  8>             WTF::RefPtr<WTF::StringImpl> m_impl;
1628               +0 <  8>                 WTF::StringImpl * m_ptr;
1629               +8 <  1>         bool:1 m_isValid;
1630               +8 <  1>         bool:1 m_protocolIsInHTTPFamily;
1631               +9 <  3>         <PADDING>
1632              +12 <  4>         int m_schemeEnd;
1633              +16 <  4>         int m_userStart;
1634              +20 <  4>         int m_userEnd;
1635              +24 <  4>         int m_passwordEnd;
1636              +28 <  4>         int m_hostEnd;
1637              +32 <  4>         int m_portEnd;
1638              +36 <  4>         int m_pathAfterLastSlash;
1639              +40 <  4>         int m_pathEnd;
1640              +44 <  4>         int m_queryEnd;
1641              +48 <  4>         int m_fragmentEnd;
1642              +52 <  4>         <PADDING>
1643              +52 <  4>     <PADDING>
1644              +56 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_prev;
1645              +64 <  8>     WTF::ListHashSetNode<WebCore::URL> * m_next;
1646             Total byte size: 72
1647             Total pad bytes: 11
1648             Padding percentage: 15.28 %
1649
1650         * Scripts/dump-class-layout: Added.
1651         (webkit_build_dir):
1652         (developer_dir):
1653         (import_lldb):
1654         (find_build_directory):
1655         (verify_type):
1656         (verify_type_recursive):
1657         (dump_class):
1658         (main):
1659         (main.or):
1660
1661 2015-08-12  Alex Christensen  <achristensen@webkit.org>
1662
1663         Fix Debug CMake builds on Windows
1664         https://bugs.webkit.org/show_bug.cgi?id=147940
1665
1666         Reviewed by Chris Dumez.
1667
1668         * DumpRenderTree/PlatformWin.cmake:
1669         * TestWebKitAPI/PlatformWin.cmake:
1670         The BitmapImage test is not enabled on the AppleWin port.
1671         * WinLauncher/CMakeLists.txt:
1672         Debug builds need /NODEFAULTLIB:MSVCRTD, too.
1673
1674 2015-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1675
1676         Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
1677
1678         In r188125 I added a way to mark tests as slow to use a longer
1679         timeout. But it seems it was not enough for
1680         WTF_Lock.ContendedShortSection, so let's try again with a longer
1681         timeout now.
1682
1683         * Scripts/run-gtk-tests:
1684         (TestRunner._run_google_test):
1685
1686 2015-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
1687
1688         Allow --debug option in run-jsc
1689         https://bugs.webkit.org/show_bug.cgi?id=147923
1690
1691         Reviewed by Csaba Osztrogonác.
1692
1693         When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
1694
1695         * Scripts/run-jsc:
1696
1697 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1698
1699         Fix test after build fix in r188286.
1700         https://bugs.webkit.org/show_bug.cgi?id=147907
1701
1702         Reviewed by Anders Carlsson.
1703
1704         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1705         sleep_for can now be used, but we need to include <thread>
1706
1707 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1708
1709         Always use a byte-sized lock implementation
1710         https://bugs.webkit.org/show_bug.cgi?id=147908
1711
1712         Reviewed by Geoffrey Garen.
1713
1714         All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
1715         now tests of Lock.
1716
1717         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1718         (TestWebKitAPI::runLockTest):
1719         (TestWebKitAPI::TEST):
1720
1721 2015-08-11  Alexey Proskuryakov  <ap@apple.com>
1722
1723         Make ASan build not depend on asan.xcconfig
1724         https://bugs.webkit.org/show_bug.cgi?id=147840
1725         rdar://problem/21093702
1726
1727         Reviewed by Daniel Bates.
1728
1729         * asan/asan.xcconfig:
1730         * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
1731         are now marked in source code.
1732
1733 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1734
1735         Unreviewed, shorten another test since it timed out.
1736
1737         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1738         (TestWebKitAPI::TEST):
1739
1740 2015-08-11  Mark Lam  <mark.lam@apple.com>
1741
1742         Fix names of Lock tests: should be "Contended", not "Contented".
1743         https://bugs.webkit.org/show_bug.cgi?id=147905
1744
1745         Reviewed by Saam Barati.
1746
1747         We're testing the behavior of lock contention (i.e. when threads contend), not
1748         whether the locks are happy (contented).
1749
1750         * Scripts/run-gtk-tests:
1751         (TestRunner):
1752         (TestRunner.__init__): Deleted.
1753         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1754         (TestWebKitAPI::runLockTest):
1755         (TestWebKitAPI::TEST):
1756
1757 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1758
1759         Update WinCairoRequirements to VS2015.
1760
1761         * Scripts/update-webkit-wincairo-libs:
1762         Update WinCairoRequirements location.
1763
1764 2015-08-11  Jason Marcell  <jmarcell@apple.com>
1765
1766         Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
1767         for internalTrac.
1768         https://bugs.webkit.org/show_bug.cgi?id=147805
1769
1770         Reviewed by Daniel Bates.
1771
1772         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1773         (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
1774         Dashboard.Repository.Internal.trac for internalTrac.
1775         (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
1776         and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
1777         respectively.
1778         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
1779         (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
1780         Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
1781         internalTrac.
1782         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
1783         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
1784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1785         (Analyzer): Ditto.
1786         (Analyzer.prototype.analyze): Ditto.
1787
1788 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
1789
1790         Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
1791
1792         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1793         (TestWebKitAPI::TEST):
1794
1795 2015-08-11  Brent Fulgham  <bfulgham@apple.com>
1796
1797         [Win] Switch Windows build to Visual Studio 2015
1798         https://bugs.webkit.org/show_bug.cgi?id=147887
1799         <rdar://problem/22235098>
1800
1801         Reviewed by Alex Christensen.
1802
1803         Update Visual Studio project file settings to use the current Visual
1804         Studio and compiler. Continue targeting binaries to run on our minimum
1805         supported configuration of Windows 7.
1806
1807         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1808         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1809         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1810         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1811         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1812         * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
1813         prefer the newer MSBuild included in Visual Studio 2015.
1814         (visualStudioInstallDir):
1815         (msBuildInstallDir):
1816         (visualStudioVersion):
1817         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1818         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1819         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1820         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1821         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1822         * win/record-memory/record-memory.vcxproj:
1823
1824 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1825
1826         Another speculative build fix after r188280.
1827
1828         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1829         std::this_thread is too modern c++ for VS2013 and supported GCC versions, 
1830         so let's go back to usleep and I made something close to usleep, but with much lower resolution.
1831
1832 2015-08-11  Alex Christensen  <achristensen@webkit.org>
1833
1834         Unreviewed build fix after r188280.
1835
1836         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1837         Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
1838
1839 2015-08-10  Filip Pizlo  <fpizlo@apple.com>
1840
1841         WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
1842         https://bugs.webkit.org/show_bug.cgi?id=147665
1843
1844         Reviewed by Mark Lam.
1845
1846         * TestWebKitAPI/CMakeLists.txt:
1847         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1848         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1849         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1850         (TestWebKitAPI::TEST):
1851         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
1852         (TestWebKitAPI::TEST):
1853
1854 2015-08-11  Brian Burg  <bburg@apple.com>
1855
1856         webkit-patch should not explode when $EDITOR is set incorrectly
1857         https://bugs.webkit.org/show_bug.cgi?id=147884
1858
1859         Reviewed by Darin Adler.
1860
1861         If $EDITOR doesn't exist, log a warning and continue.
1862
1863         * Scripts/webkitpy/common/system/user.py: 
1864         (User.edit):
1865         (User.edit_changelog):
1866
1867 2015-08-11  Dan Bernstein  <mitz@apple.com>
1868
1869         Reverted r188255, because it turned out that delegates do nonot need this information.
1870
1871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1872         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
1873
1874 2015-08-11  Dan Bernstein  <mitz@apple.com>
1875
1876         [Cocoa] The UI delegate can't tell if printing was user-initiated
1877         https://bugs.webkit.org/show_bug.cgi?id=147869
1878
1879         Reviewed by Sam Weinig.
1880
1881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1882         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
1883         (-[PrintFrameController webView:didFinishNavigation:]):
1884         (-[PrintFrameController _webView:printFrame:userInitiated:]):
1885         (TEST):
1886
1887 2015-08-10  Alex Christensen  <achristensen@webkit.org>
1888
1889         Another build fix after r188239.
1890
1891         * TestWebKitAPI/PlatformWin.cmake:
1892         Link with more libraries.
1893         * WinLauncher/CMakeLists.txt:
1894         /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
1895
1896 2015-08-10  Ryosuke Niwa  <rniwa@webkit.org>
1897
1898         Build fix after r188237.
1899
1900         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1901         (BenchmarkBuilder.__enter__):
1902
1903 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
1904
1905         Update ReadMe and correct the way to use abstract abstract class.
1906         https://bugs.webkit.org/show_bug.cgi?id=147860
1907
1908         Reviewed by Ryosuke Niwa.
1909
1910         Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
1911         so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
1912
1913         * Scripts/webkitpy/benchmark_runner/README.md:
1914         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1915         (BrowserDriver):
1916         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1917         (OSXBrowserDriver.restore_env):
1918         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1919         (HTTPServerDriver):
1920         (HTTPServerDriver.set_device_id):
1921         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1922         (SimpleHTTPServerDriver.get_return_code):
1923         (SimpleHTTPServerDriver):
1924         (SimpleHTTPServerDriver.set_device_id):
1925
1926 2015-08-10  Alex Christensen  <achristensen@webkit.org>
1927
1928         Build TestWebKitAPI with CMake on Windows
1929         https://bugs.webkit.org/show_bug.cgi?id=147851
1930
1931         Reviewed by Chris Dumez.
1932
1933         * CMakeLists.txt:
1934         * TestWebKitAPI/CMakeLists.txt:
1935         Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
1936         Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
1937         Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win 
1938         before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
1939         * TestWebKitAPI/PlatformEfl.cmake:
1940         * TestWebKitAPI/PlatformGTK.cmake:
1941         Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
1942         I did this without changing the directory structure of the existing EFL and GTK builds.
1943         * TestWebKitAPI/PlatformWin.cmake: Added.
1944         * TestWebKitAPI/win/main.cpp:
1945         (main):
1946         (dllLauncherEntryPoint):
1947         Added so we can launch TestWebKitAPI executables after finding the AAS directory.
1948         * WinLauncher/CMakeLists.txt:
1949         AppleWin port needs /NODEFAULTLIB:MSVCRT.
1950
1951 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
1952
1953         Make cleanup more robust and minor code cleaning in run benchmark script.
1954         https://bugs.webkit.org/show_bug.cgi?id=147800
1955
1956         Reviewed by Ryosuke Niwa.
1957
1958         Use 'finnaly' block to make sure cleanup code is always executed.
1959
1960         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1961         (built_benchmark):
1962         (built_benchmark.__init__):
1963         (built_benchmark.__enter__):
1964         (built_benchmark.__exit__):
1965         (test_environment):
1966         (test_environment.__init__):
1967         (test_environment.__enter__):
1968         (test_environment.__exit__):
1969         (BenchmarkRunner.__init__):
1970         (BenchmarkRunner.execute):
1971         (BenchmarkRunner._dump):
1972         (BenchmarkRunner._wrap):
1973         (BenchmarkRunner): Deleted.
1974         (BenchmarkRunner._cleanup): Deleted.
1975         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1976         (BrowserDriver.close_browsers):
1977         (BrowserDriver):
1978         (BrowserDriver.restore_env):
1979         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1980         (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
1981
1982 2015-08-10  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1983
1984         Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
1985         https://bugs.webkit.org/show_bug.cgi?id=146414
1986
1987         Reviewed by Darin Adler.
1988
1989         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1990         (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
1991
1992 2015-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1993
1994         [GTK] Test  /webkit2/WebKitWebView/submit-form is flaky
1995         https://bugs.webkit.org/show_bug.cgi?id=147727
1996
1997         Reviewed by Sergio Villar Senin.
1998
1999         I think it was not this test in particular, but
2000         /webkit2/WebKitWebView/custom-charset that is affecting the
2001         others. This is because changing the encoding reloads the page,
2002         but we don't wait for the page to be reloaded, so when the test
2003         finishes and other test starts the web process is still reloading
2004         the page.
2005
2006         * Scripts/run-gtk-tests:
2007         (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
2008         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2009         (testWebViewCustomCharset): Wait until page is reloaded after
2010         changing the charset.
2011
2012 2015-08-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2013
2014         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
2015
2016         It's timing out in the bots. My guess is that there's no installer
2017         installed in the bots and gst_install_plugins_supported() returns
2018         false, so we don't even get a permission request because no
2019         installer will be launched.
2020
2021         * Scripts/run-gtk-tests:
2022         (TestRunner):
2023
2024 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2025
2026         [GTK] Another build fix after r188157.
2027
2028         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2029         (WTR::PlatformWebView::viewSupportsOptions):
2030         Name all the things correctly!
2031
2032 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2033
2034         [EFL, GTK] Build fix after r188176.
2035
2036         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2037         I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
2038
2039 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2040
2041         [GTK] Speculative build fix after r188157.
2042
2043         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2044         (WTR::PlatformWebView::PlatformWebView):
2045         Update parameter list.
2046
2047 2015-08-07  Alex Christensen  <achristensen@webkit.org>
2048
2049         Build more testing binaries with CMake on Windows
2050         https://bugs.webkit.org/show_bug.cgi?id=147799
2051
2052         Reviewed by Brent Fulgham.
2053
2054         * DumpRenderTree/CMakeLists.txt:
2055         Build TestNetscapePlugin.
2056         * DumpRenderTree/PlatformWin.cmake:
2057         Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
2058         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
2059         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
2060         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
2061         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
2062         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
2063         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
2064         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
2065         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
2066
2067 2015-08-07  Jason Marcell  <jmarcell@apple.com>
2068
2069         Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
2070         https://bugs.webkit.org/show_bug.cgi?id=147667
2071
2072         Reviewed by Daniel Bates.
2073
2074         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2075         (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
2076         other than "openSource" and "internal".
2077         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
2078         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2079         (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
2080         (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
2081         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2082         (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
2083         (sortedPlatforms): Deleted.
2084         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2085         (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
2086         (sortedPlatforms): Deleted.
2087         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
2088         (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
2089         and sorts them by this property returning the new sorted array.
2090
2091 2015-08-07  Filip Pizlo  <fpizlo@apple.com>
2092
2093         Lightweight locks should be adaptive
2094         https://bugs.webkit.org/show_bug.cgi?id=147545
2095
2096         Reviewed by Geoffrey Garen.
2097
2098         * TestWebKitAPI/CMakeLists.txt:
2099         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2101         * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
2102         (TestWebKitAPI::runLockTest):
2103         (TestWebKitAPI::TEST):
2104
2105 2015-08-07  Anders Carlsson  <andersca@apple.com>
2106
2107         Fix a tyop.
2108
2109         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2110         (WTR::PlatformWebView::viewSupportsOptions):
2111
2112 2015-08-07  Alexey Proskuryakov  <ap@apple.com>
2113
2114         Update AppEngine app version numbers to the latest commit.
2115
2116         * QueueStatusServer/app.yaml:
2117         * TestResultServer/app.yaml:
2118
2119 2015-08-07  Anders Carlsson  <andersca@apple.com>
2120
2121         Simplify WKTR's view options
2122         https://bugs.webkit.org/show_bug.cgi?id=147791
2123
2124         Reviewed by Sam Weinig.
2125
2126         Instead of using a WKDictionaryRef, just use a struct for the options.
2127
2128         * WebKitTestRunner/PlatformWebView.h:
2129         (WTR::PlatformWebView::options):
2130         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
2131         * WebKitTestRunner/TestController.cpp:
2132         (WTR::TestController::initialize):
2133         (WTR::TestController::createWebViewWithOptions):
2134         (WTR::TestController::ensureViewSupportsOptions):
2135         (WTR::TestController::updateLayoutTypeForTest):
2136         * WebKitTestRunner/TestController.h:
2137         * WebKitTestRunner/ViewOptions.h: Added.
2138         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2139         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2140         (WTR::PlatformWebView::PlatformWebView):
2141         (WTR::PlatformWebView::viewSupportsOptions):
2142         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2143         (WTR::PlatformWebView::viewSupportsOptions):
2144         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2145         (WTR::PlatformWebView::viewSupportsOptions):
2146         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2147         (WTR::PlatformWebView::PlatformWebView):
2148         (WTR::PlatformWebView::viewSupportsOptions):
2149         * WebKitTestRunner/mac/TestControllerMac.mm:
2150         (WTR::TestController::platformConfigureViewForTest):
2151
2152 2015-08-07  Joseph Pecoraro  <pecoraro@apple.com>
2153
2154         Running tests for a long time results in some tests running very slowly (throttling)
2155         https://bugs.webkit.org/show_bug.cgi?id=147718
2156
2157         Reviewed by Chris Dumez.
2158
2159         Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
2160         Although COCOA ports default this setting to be disabled in WebKit1,
2161         we should make both test harnesses disable the setting for consistency.
2162
2163         * DumpRenderTree/mac/DumpRenderTree.mm:
2164         (resetWebPreferencesToConsistentValues):
2165
2166 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2167
2168         Use a specific version of Speedometer in run-benchmark
2169         https://bugs.webkit.org/show_bug.cgi?id=147769
2170
2171         Reviewed by Chris Dumez.
2172
2173         Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
2174
2175         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2176
2177 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2178
2179         twisted_http_server.py should support --port
2180         https://bugs.webkit.org/show_bug.cgi?id=147771
2181
2182         Reviewed by Chris Dumez.
2183
2184         Added the option. This makes the script more useful on its own.
2185
2186         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2187
2188 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2189
2190         [GTK] WTF unit tests are timing out in the bots
2191         https://bugs.webkit.org/show_bug.cgi?id=147777
2192
2193         Reviewed by Filip Pizlo.
2194
2195         Add a way to mark google unit tests as slow and add
2196         WTF_Lock.ContentedShortSection to the list. In case of slow test
2197         we use the double of the given timeout for that particular test.
2198
2199         * Scripts/run-gtk-tests:
2200         (TestRunner):
2201         (TestRunner._run_google_test):
2202
2203 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2204
2205         [GTK] run-gtk-tests should not stop when a google test case fails
2206         https://bugs.webkit.org/show_bug.cgi?id=147778
2207
2208         Reviewed by Philippe Normand.
2209
2210         For glib based tests we run the test runner with the -k option,
2211         but for google tests we are aborting as soon as we find a failure.
2212
2213         * Scripts/run-gtk-tests:
2214         (TestRunner._run_google_test_suite): Use a global return code that
2215         is set to 1 when any test has failed.
2216
2217 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2218
2219         [GStreamer] Do not automatically show PackageKit codec installation notifications
2220         https://bugs.webkit.org/show_bug.cgi?id=135973
2221
2222         Reviewed by Philippe Normand.
2223
2224         Handle the missing media plugins installation permission request
2225         in MiniBrowser and add a test case for the new API.
2226
2227         * MiniBrowser/gtk/BrowserWindow.c:
2228         (webViewDecidePermissionRequest):
2229         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2230         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2231         (permissionRequestCallback):
2232         (testInstallMissingPluginsPermissionRequest):
2233         (beforeAll):
2234         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2235         (methodCallCallback):
2236
2237 2015-08-06  Joseph Pecoraro  <pecoraro@apple.com>
2238
2239         Running tests for a long time results in some tests running very slowly (throttling)
2240         https://bugs.webkit.org/show_bug.cgi?id=147718
2241
2242         Reviewed by Alexey Proskuryakov.
2243
2244         * WebKitTestRunner/TestController.cpp:
2245         (WTR::TestController::resetPreferencesToConsistentValues):
2246         Ensure throttling settings are disabled for tests for all ports, as
2247         COCOA ports default to having these setting enabled. Note, there is
2248         still other timer throttling not covered by these setting.
2249
2250 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2251
2252         http_server_driver and benchmark_builder should not be in run-benchmark's plan files
2253         https://bugs.webkit.org/show_bug.cgi?id=147752
2254
2255         Reviewed by Chris Dumez.
2256
2257         Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
2258
2259         Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
2260         This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
2261
2262         * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
2263         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
2264         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
2265         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
2266         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
2267         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2268         (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
2269         HTTPServerDriverFactory taking the platform name as an argument.
2270         (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
2271         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
2272         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
2273         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2274         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
2275         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
2276         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
2277         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2278         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
2279         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
2280         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
2281         (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
2282         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2283         (HTTPServerDriver): Replaced name by platforms.
2284         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2285         (SimpleHTTPServerDriver): Ditto.
2286         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2287         (parse_args): Removed --http-server-driver option.
2288         (start): Ditto.
2289
2290 2015-08-06  Chris Dumez  <cdumez@apple.com>
2291
2292         Toggle GPS state based on page visibility to save battery
2293         https://bugs.webkit.org/show_bug.cgi?id=147685
2294
2295         Reviewed by Benjamin Poulain.
2296
2297         Add testRunner.isGeolocationProviderActive() test support function.
2298
2299         * DumpRenderTree/TestRunner.cpp:
2300         (isGeolocationProviderActiveCallback):
2301         (TestRunner::staticFunctions):
2302         * DumpRenderTree/TestRunner.h:
2303         * DumpRenderTree/mac/MockGeolocationProvider.h:
2304         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2305         (-[MockGeolocationProvider isActive]):
2306         * DumpRenderTree/mac/TestRunnerMac.mm:
2307         (TestRunner::isGeolocationProviderActive):
2308         * DumpRenderTree/win/TestRunnerWin.cpp:
2309         (TestRunner::isGeolocationProviderActive):
2310         * WebKitTestRunner/GeolocationProviderMock.h:
2311         (WTR::GeolocationProviderMock::isActive):
2312         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2313         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2314         (WTR::InjectedBundle::isGeolocationProviderActive):
2315         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2316         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2317         (WTR::TestRunner::isGeolocationProviderActive):
2318         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2319         * WebKitTestRunner/TestController.cpp:
2320         (WTR::TestController::isGeolocationProviderActive):
2321         * WebKitTestRunner/TestController.h:
2322         * WebKitTestRunner/TestInvocation.cpp:
2323         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2324
2325 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
2326
2327         Automate JSBench with run-benchmark
2328         https://bugs.webkit.org/show_bug.cgi?id=147716
2329
2330         Reviewed by Chris Dumez.
2331
2332         Added JSBench plan to run-benchmark.
2333
2334         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2335         (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
2336         (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
2337         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
2338         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
2339         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
2340         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
2341         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
2342         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
2343         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
2344         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
2345         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
2346         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
2347         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
2348         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
2349         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
2350
2351 2015-08-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2352
2353         Pass-through the undefined options in run-jsc
2354         https://bugs.webkit.org/show_bug.cgi?id=147717
2355
2356         Undefined options in run-jsc is just passed to the actual jsc shell.
2357         We can execute `Tools/Scripts/run-jsc -d`.
2358
2359         Reviewed by Csaba Osztrogonác.
2360
2361         * Scripts/run-jsc:
2362
2363 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2364
2365         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form.
2366
2367         It's flaky.
2368
2369         * Scripts/run-gtk-tests:
2370         (TestRunner):
2371
2372 2015-08-06  Csaba Osztrogonác  <ossy@webkit.org>
2373
2374         [EFL] Bump EFL version to 1.15.0
2375         https://bugs.webkit.org/show_bug.cgi?id=147450
2376
2377         Reviewed by Gyuyoung Kim.
2378
2379         * efl/jhbuild.modules:
2380
2381 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2382
2383         Unreviewed. Unksip TestContextMenu GTK+ API test.
2384
2385         This has been skipped for a long time, and it's very
2386         unconvenient. It has never failed for me locally, so let's try
2387         again to see if it works in the bots. I'll skip it again if it
2388         keeps failing.
2389
2390         * Scripts/run-gtk-tests:
2391         (TestRunner):
2392
2393 2015-08-05  Filip Pizlo  <fpizlo@apple.com>
2394
2395         Unreviewed, roll out http://trac.webkit.org/changeset/187972.
2396
2397         * DumpRenderTree/JavaScriptThreading.cpp:
2398         (javaScriptThreadsMutex):
2399         (runJavaScriptThread):
2400         (startJavaScriptThreads):
2401         (stopJavaScriptThreads):
2402         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2403         (TestWebKitAPI::TEST):
2404         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2405         (TestWebKitAPI::TEST):
2406
2407 2015-08-05  Alex Christensen  <achristensen@webkit.org>
2408
2409         Build DumpRenderTree with CMake.
2410         https://bugs.webkit.org/show_bug.cgi?id=147519
2411
2412         Reviewed by Brent Fulgham.
2413
2414         * CMakeLists.txt:
2415         Build the DumpRenderTree directory now that it builds successfully.
2416         * DumpRenderTree/CMakeLists.txt:
2417         Added missing source file and don't link with WebCore.lib.
2418         * DumpRenderTree/PlatformWin.cmake:
2419         Added sources to DumpRenderTreeLib and made DumpRenderTree only build DLLLauncherMain.cpp. 
2420         * WinLauncher/CMakeLists.txt:
2421         We need libcmt now that we are not linking with WebCore.lib.
2422
2423 2015-08-05  Alexey Proskuryakov  <ap@apple.com>
2424
2425         AppScale: Use https URLs for subresources and links
2426         https://bugs.webkit.org/show_bug.cgi?id=147686
2427
2428         Reviewed by Ryosuke Niwa.
2429
2430         * QueueStatusServer/filters/webkit_extras.py:
2431         * TestResultServer/static-dashboards/dashboard_base.js:
2432         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2433         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2434         * TestResultServer/static-dashboards/treemap.js:
2435         * TestResultServer/static-dashboards/ui.js:
2436
2437 2015-08-04  Filip Pizlo  <fpizlo@apple.com>
2438
2439         Rename Mutex to DeprecatedMutex
2440         https://bugs.webkit.org/show_bug.cgi?id=147675
2441
2442         Reviewed by Geoffrey Garen.
2443
2444         * DumpRenderTree/JavaScriptThreading.cpp:
2445         (javaScriptThreadsMutex):
2446         (runJavaScriptThread):
2447         (startJavaScriptThreads):
2448         (stopJavaScriptThreads):
2449         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2450         (TestWebKitAPI::TEST):
2451         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
2452         (TestWebKitAPI::TEST):
2453
2454 2015-08-05  Timothy Hatcher  <timothy@apple.com>
2455
2456         Update the WebKit nightly icon
2457         https://bugs.webkit.org/show_bug.cgi?id=147684
2458
2459         Reviewed by Sam Weinig.
2460
2461         * WebKitLauncher/webkit.icns: Replaced.
2462
2463 2015-08-05  Daniel Bates  <dabates@apple.com>
2464
2465         REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes
2466         https://bugs.webkit.org/show_bug.cgi?id=147678
2467         <rdar://problem/21827815>
2468
2469         Reviewed by Brady Eidson.
2470
2471         Add a test to ensure that we restore the "should open external URLs" policy on
2472         page reload after the web content process crashes.
2473
2474         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2475         * TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Added.
2476         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2477         (TEST):
2478
2479 2015-08-04  Hunseop Jeong  <hs85.jeong@samsung.com>
2480
2481         [EFL] Editing tests have been broken since r186694
2482         https://bugs.webkit.org/show_bug.cgi?id=146888
2483
2484         Reviewed by Brent Fulgham.
2485
2486         Restored some codes for the context click on GTK+ and EFL port.
2487
2488         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2489         (WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
2490
2491 2015-08-04  Dewei Zhu  <dewei_zhu@apple.com>
2492
2493         Install twisted package for http server when necessary.
2494         https://bugs.webkit.org/show_bug.cgi?id=147082
2495
2496         Reviewed by Ryosuke Niwa.
2497
2498         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
2499         * Scripts/webkitpy/thirdparty/__init__.py:
2500         (AutoinstallImportHook.find_module):
2501         (AutoinstallImportHook._install_twisted):
2502
2503 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2504
2505         [Win] Update Apple Windows build for VS2015
2506         https://bugs.webkit.org/show_bug.cgi?id=147653
2507
2508         Reviewed by Dean Jackson.
2509
2510         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/PluginTest.h: If building with
2511         something older than VS2015, define snprintf as _snprintf.
2512         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
2513         Remove unneeded macro definition for snprintf.
2514         * Scripts/webkitpy/common/system/platforminfo.py:
2515         (PlatformInfo._determine_win_version): Recognize Windows 10.
2516         * Scripts/webkitpy/port/win.py:
2517         (WinPort): Ditto.
2518         * Scripts/webkitpy/port/win_unittest.py:
2519         (WinPortTest.test_baseline_search_path): Include Windows 10 in tests.
2520         (WinPortTest._assert_version): Ditto.
2521
2522 2015-08-04  Brian Burg  <bburg@apple.com>
2523
2524         Unreviewed, update email addresses in contributors.json and watchlist.
2525
2526         * Scripts/webkitpy/common/config/contributors.json:
2527         * Scripts/webkitpy/common/config/watchlist:
2528
2529 2015-08-04  Alexey Proskuryakov  <ap@apple.com>
2530
2531         Implement NPAPI redirect handling
2532         https://bugs.webkit.org/show_bug.cgi?id=138675
2533         rdar://problem/15779101
2534
2535         Patch by Jeffrey Pfau, updated and tweaked by me.
2536
2537         Reviewed by Anders Carlsson.
2538
2539         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2540         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2541         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2542         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2543         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2544         (PluginTest::NPP_URLNotify):
2545         (PluginTest::NPP_URLRedirectNotify):
2546         (PluginTest::NPP_GetValue):
2547         (PluginTest::NPN_GetURLNotify):
2548         (PluginTest::NPN_PostURLNotify):
2549         (PluginTest::NPN_GetValue):
2550         (PluginTest::NPN_ReleaseVariantValue):
2551         (PluginTest::NPN_URLRedirectResponse):
2552         (PluginTest::NPN_ConvertPoint):
2553         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2554         * DumpRenderTree/TestNetscapePlugIn/Tests/URLRedirect.cpp: Added.
2555         (URLRedirect::URLRedirect):
2556         (URLRedirect::ScriptableObject::hasMethod):
2557         (URLRedirect::ScriptableObject::get):
2558         (URLRedirect::ScriptableObject::serviceAsync):
2559         (URLRedirect::ScriptableObject::invoke):
2560         (URLRedirect::NPP_GetValue):
2561         (URLRedirect::NPP_URLNotify):
2562         (URLRedirect::NPP_URLRedirectNotify):
2563         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2564         (NP_GetEntryPoints):
2565         (NPP_URLNotify):
2566         (NPP_URLRedirectNotify):
2567         (NPP_GetValue):
2568
2569 2015-08-04  Tim Horton  <timothy_horton@apple.com>
2570
2571         Move Matt Daiter to committers.
2572
2573         * Scripts/webkitpy/common/config/contributors.json:
2574
2575 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
2576
2577         [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.
2578         https://bugs.webkit.org/show_bug.cgi?id=147636
2579
2580         Reviewed by Alex Christensen.
2581         
2582         We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly.
2583         Stop the build-webkit script from interacting with BuildOutput.htm, thereby preventing a potential build failure (especially
2584         on EWS machines)
2585
2586         * Scripts/build-webkit:
2587
2588 2015-08-04  Jason Marcell  <jmarcell@apple.com>
2589
2590         Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.
2591         https://bugs.webkit.org/show_bug.cgi?id=147280
2592
2593         Reviewed by Daniel Bates.
2594
2595         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2596         (BuildbotIteration): Removed opensourceRevision, internalRevision. Added revision.
2597         Refactored _parseData to handle repositories more generically.
2598         (parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevant.
2599         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2600         (BuildbotQueue.prototype.compareIterations): Using "revision" property instead of
2601         "opensourceRevision" and "internalRevision".
2602         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
2603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2604         (BuildbotQueueView.prototype._appendPendingRevisionCount): Ditto.
2605         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
2606         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changing "internal" boolean
2607         parameter to more generic "repository" string parameter. Added "trac" parameter in order to
2608         specify the trac instance to use. Using "revision" property instead of "opensourceRevision"
2609         and "internalRevision".
2610         (BuildbotQueueView.prototype.revisionContentForIteration): Passing the repository name and trac
2611         instance to _revisionContentWithPopoverForIteration(). Using "revision" property instead of
2612         "opensourceRevision" and "internalRevision".
2613         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Adding
2614         constants for internal and opensource repositories.
2615         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
2616         (Analyzer.prototype._findIndexOfLargestIterationAtOrBeforeStart): Using "revision" property
2617         instead of "opensourceRevision" and "internalRevision".
2618         (Analyzer.prototype._countPercentageOfGreen): Ditto.
2619         (Analyzer.prototype.webkitTrac.recordedCommits.forEach): Ditto.
2620         (Analyzer.prototype._countTimes): Ditto.
2621         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2622         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Ditto.
2623
2624 2015-08-04  Mark Lam  <mark.lam@apple.com>
2625
2626         Removed a local debugging line I accidentally left in from a previous commit.
2627
2628         Not Reviewed.
2629
2630         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2631
2632 2015-08-04  Mark Lam  <mark.lam@apple.com>
2633
2634         Unreviewed. Make Saam Barati a WebKit reviewer.
2635
2636         * Scripts/webkitpy/common/config/contributors.json:
2637
2638 2015-08-04  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2639
2640         Unreviewed, updated Streams API watchlist.
2641
2642         * Scripts/webkitpy/common/config/watchlist: Matched .*Readable.*Stream.* and .*QueuingStrategy.* in bindings/js.
2643
2644 2015-08-03  Csaba Osztrogonác  <ossy@webkit.org>
2645
2646         [CMake] Add an option to build AllInOne files
2647         https://bugs.webkit.org/show_bug.cgi?id=102647
2648
2649         Reviewed by Alex Christensen.
2650
2651         * Scripts/webkitperl/FeatureList.pm:
2652
2653 2015-08-03  Alexey Proskuryakov  <ap@apple.com>
2654
2655         AppScale: Add required indices
2656         https://bugs.webkit.org/show_bug.cgi?id=147593
2657
2658         Reviewed by Tim Horton.
2659
2660         * QueueStatusServer/index.yaml:
2661
2662 2015-08-03  Filip Pizlo  <fpizlo@apple.com>
2663
2664         Check in LLVM 3.6.2 binary drops for El Capitan
2665         https://bugs.webkit.org/show_bug.cgi?id=147582
2666
2667         Reviewed by Alexey Proskuryakov.
2668         
2669         Recognize 10.11 and use the right drops.
2670
2671         * Scripts/copy-webkitlibraries-to-product-directory:
2672
2673 2015-08-03  Alex Christensen  <achristensen@webkit.org>
2674
2675         [Win] Build fix after r187733.
2676
2677         * WinLauncher/PageLoadTestClient.cpp:
2678         (PageLoadTestClient::dumpRunStatistics):
2679         wtf/MathExtras.h is now included in HashTable.h, which #defines pow to wtf_pow.
2680
2681 2015-08-02  Benjamin Poulain  <bpoulain@apple.com>
2682
2683         Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses
2684         https://bugs.webkit.org/show_bug.cgi?id=118455
2685
2686         Reviewed by Filip Pizlo.
2687
2688         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2689         (TestWebKitAPI::TEST):
2690
2691 2015-07-31  Alex Christensen  <achristensen@webkit.org>
2692
2693         Prepare for VS2015
2694         https://bugs.webkit.org/show_bug.cgi?id=146579
2695
2696         Reviewed by Jon Honeycutt.
2697
2698         * WinLauncher/stdafx.h:
2699         Define __STDC_LIMIT_MACROS to have access to INTMAX_MAX.
2700
2701 2015-07-31  Csaba Osztrogonác  <ossy@webkit.org>
2702
2703         [EFL] Fix pixman build on ARM with GCC 4.9.3
2704         https://bugs.webkit.org/show_bug.cgi?id=147224
2705
2706         Reviewed by Gyuyoung Kim.
2707
2708         * efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug.
2709
2710 2015-07-30  Anders Carlsson  <andersca@apple.com>
2711
2712         Add support for window.open to WK1BrowserWindowController
2713         https://bugs.webkit.org/show_bug.cgi?id=147474
2714
2715         Reviewed by Dan Bernstein.
2716
2717         * MiniBrowser/mac/WK1BrowserWindowController.m:
2718         (-[WK1BrowserWindowController awakeFromNib]):
2719         Set javaScriptCanOpenWindowsAutomatically to YES. 
2720         If this becomes a nuisance, we can always add a menu item to toggle this.
2721
2722         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2723         Implement this UI delegate method.
2724
2725 2015-07-30  Anders Carlsson  <andersca@apple.com>
2726
2727         Undo stray commit.
2728
2729         * MiniBrowser/mac/WK1BrowserWindowController.m:
2730         (-[WK1BrowserWindowController awakeFromNib]):
2731         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
2732
2733 2015-07-29  Dean Jackson  <dino@apple.com>
2734
2735         Don't use (Details) when exposing SPI
2736         https://bugs.webkit.org/show_bug.cgi?id=147426
2737         <rdar://problem/22062407>
2738
2739         Reviewed by Dan Bernstein.
2740
2741         If we are declaring the interface without any implementation,
2742         we should use class extensions.
2743
2744         * DumpRenderTree/mac/DumpRenderTree.mm:
2745         * DumpRenderTree/mac/EventSendingController.mm:
2746         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2747         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2748         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2749         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2750         * WebKitTestRunner/mac/TestControllerMac.mm:
2751
2752 2015-07-30  Aakash Jain  <aakash_jain@apple.com>
2753
2754         Replace Google App Engine with AppScale
2755         https://bugs.webkit.org/show_bug.cgi?id=147178
2756
2757         Reviewed by Daniel Bates.
2758
2759         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2760         (RunWebKitTests):
2761         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2762         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2763         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2764         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2765         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2766         (.):
2767         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2768         (BubbleQueueServer):
2769         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
2770         (TestHistory):
2771         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2772         * QueueStatusServer/app.yaml: We must explicitly define threadsafe property when using the Python 2.7 runtime. We set threadsafe to be false because the status server code was written to be run in AppEngine's CGI environment and AppEngine's CGI programming model handles requests serially per section "Concurrent Requests and WSGI" of <https://cloud.google.com/appengine/docs/python/python25/migrate27>.
2773         * TestResultServer/app.yaml: Ditto
2774         * Scripts/webkitpy/common/config/urls.py:
2775         * TestResultServer/main.py:
2776         * TestResultServer/static-dashboards/dashboard_base.js:
2777         * TestResultServer/static-dashboards/loader.js:
2778
2779 2015-07-30  Joonghun Park  <jh718.park@samsung.com>
2780
2781         [EFL] Enable IndexedDB based on DatabaseProcess
2782         https://bugs.webkit.org/show_bug.cgi?id=147221
2783
2784         Reviewed by Csaba Osztrogonác.
2785
2786         * Scripts/webkitperl/FeatureList.pm:
2787
2788 2015-07-30  Alex Christensen  <achristensen@webkit.org>
2789
2790         Build AppleWin port with CMake
2791         https://bugs.webkit.org/show_bug.cgi?id=147385
2792
2793         Reviewed by Martin Robinson.
2794
2795         * WinLauncher/CMakeLists.txt:
2796         Link to CoreFoundation.lib and added /NODEFAULTLIB:LIBCMT to get it to link successfully.
2797
2798 2015-07-29  Andy VanWagoner  <thetalecrafter@gmail.com>
2799
2800         Implement basic types for ECMAScript Internationalization API
2801         https://bugs.webkit.org/show_bug.cgi?id=146926
2802
2803         Reviewed by Benjamin Poulain.
2804
2805         Enable flag now that the basic objects are in place.
2806
2807         * Scripts/webkitperl/FeatureList.pm: Enabled INTL
2808
2809 2015-07-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2810
2811         [GTK] Add API to set the maximum number of web processes per WebKitWebContext
2812         https://bugs.webkit.org/show_bug.cgi?id=147108
2813
2814         Reviewed by Gustavo Noronha Silva.
2815
2816         Add test case to check the web process limit.
2817
2818         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2819         (testWebProcessLimit):
2820         (beforeAll):
2821
2822 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2823
2824         [GTK] Missing casts in BrowserWindow.c
2825         https://bugs.webkit.org/show_bug.cgi?id=147395
2826
2827         Reviewed by Carlos Garcia Campos.
2828
2829         * MiniBrowser/gtk/BrowserWindow.c:
2830         (browserWindowSetupEditorToolbar):
2831
2832 2015-07-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2833
2834         [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value "false"
2835         https://bugs.webkit.org/show_bug.cgi?id=147350
2836
2837         Reviewed by Sam Weinig.
2838
2839         * Scripts/webkitperl/FeatureList.pm:
2840
2841 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2842
2843         [Freetype] Always allow font matching for strong aliases
2844         https://bugs.webkit.org/show_bug.cgi?id=147057
2845
2846         Reviewed by Martin Robinson.
2847
2848         Create family aliases needed for the new layout tests.
2849
2850         * WebKitTestRunner/gtk/fonts/fonts.conf:
2851
2852 2015-07-28  Alexey Proskuryakov  <ap@apple.com>
2853
2854         webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com
2855         https://bugs.webkit.org/show_bug.cgi?id=147359
2856
2857         Reviewed by Ryosuke Niwa.
2858
2859         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2860         (NewCommitBot.begin_work_queue):
2861         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2862         (SheriffBot.begin_work_queue):
2863
2864 2015-07-27  Alex Christensen  <achristensen@webkit.org>
2865
2866         Use Ninja on Windows.
2867         https://bugs.webkit.org/show_bug.cgi?id=147228
2868
2869         Reviewed by Martin Robinson.
2870
2871         * WinLauncher/CMakeLists.txt:
2872         WinLauncherLib must make WinLauncher.dll, not WinLauncherLib.dll.
2873         * Scripts/build-webkit:
2874         Use Ninja to build WinCairo by default, but fall back to Visual Studio if Ninja is not on the system.
2875
2876 2015-07-24  Jon Honeycutt  <jhoneycutt@apple.com>
2877
2878         Test for bug #147164 "[iOS] Keyboard bold/italic/underline keys don't
2879         highlight after being tapped to style a selection"
2880         https://bugs.webkit.org/show_bug.cgi?id=147278
2881
2882         Reviewed by Ryosuke Niwa.
2883
2884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2885
2886         * TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm: Added.
2887         (-[WordBoundaryTypingAttributesController webView:didFinishLoadForFrame:]):
2888         (TestWebKitAPI::TEST):
2889         Load a page with the string "Hello, world!", then select "world" and
2890         underline it. Test that the typing attributes for the current selection
2891         include the underline attribute.
2892
2893 2015-07-24  Hyungwook Lee  <hyungwook.lee@navercorp.com>
2894
2895         Unreviewed, updated my nick name in contributors.json
2896
2897         * Scripts/webkitpy/common/config/contributors.json:
2898
2899 2015-07-24  Chris Fleizach  <cfleizach@apple.com>
2900
2901         AX: scrollable elements do not allow 3-finger swipe
2902         https://bugs.webkit.org/show_bug.cgi?id=141893
2903
2904         Reviewed by Mario Sanchez Prada.
2905
2906         Support global notification listeners for iOS code.
2907         Fix an issue in DRT where the dictionary of data was not being passed back to the layout test for the notication callback.
2908         Implement scrollUp/Down/Left/Right.
2909
2910         * DumpRenderTree/AccessibilityController.h:
2911         * DumpRenderTree/AccessibilityUIElement.cpp:
2912         (increaseTextSelectionCallback):
2913         (scrollPageUpCallback):
2914         (scrollPageDownCallback):
2915         (scrollPageLeftCallback):
2916         (scrollPageRightCallback):
2917         (decreaseTextSelectionCallback):
2918         (getElementTextLengthCallback):
2919         (AccessibilityUIElement::getJSClass):
2920         * DumpRenderTree/AccessibilityUIElement.h:
2921         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2922         (AccessibilityController::~AccessibilityController):
2923         (AccessibilityController::elementAtPoint):
2924         (AccessibilityController::addNotificationListener):
2925         (AccessibilityController::platformResetToConsistentState):
2926         (AccessibilityController::removeNotificationListener):
2927         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2928         (AccessibilityUIElement::AccessibilityUIElement):
2929         (AccessibilityUIElement::subrole):
2930         (AccessibilityUIElement::scrollPageUp):
2931         (AccessibilityUIElement::scrollPageDown):
2932         (AccessibilityUIElement::scrollPageLeft):
2933         (AccessibilityUIElement::scrollPageRight):
2934         (AccessibilityUIElement::roleDescription):
2935         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2936         (-[AccessibilityNotificationHandler _notificationReceived:]):
2937         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2938         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2939         (WTR::AccessibilityUIElement::linkedElement):
2940         (WTR::AccessibilityUIElement::headerElementAtIndex):
2941         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2942         (WTR::AccessibilityUIElement::scrollPageUp):
2943         (WTR::AccessibilityUIElement::scrollPageDown):
2944         (WTR::AccessibilityUIElement::scrollPageLeft):
2945         (WTR::AccessibilityUIElement::scrollPageRight):
2946         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2947         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2948         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2949         (WTR::AccessibilityController::addNotificationListener):
2950         (WTR::AccessibilityController::removeNotificationListener):
2951         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2952         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2953         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2954         (WTR::AccessibilityUIElement::scrollPageUp):
2955         (WTR::AccessibilityUIElement::scrollPageDown):
2956         (WTR::AccessibilityUIElement::scrollPageLeft):
2957         (WTR::AccessibilityUIElement::scrollPageRight):
2958         (WTR::AccessibilityUIElement::increaseTextSelection):
2959
2960 2015-07-24  Brent Fulgham  <bfulgham@apple.com>
2961
2962         [Win] Activate CSP_NEXT and Connect UserScript and UserStyleSheet through WebView.
2963         https://bugs.webkit.org/show_bug.cgi?id=147279
2964         <rdar://problem/21990767>
2965
2966         Reviewed by Dean Jackson.
2967
2968         * DumpRenderTree/win/TestRunnerWin.cpp:
2969         (TestRunner::addUserScript):
2970         (TestRunner::addUserStyleSheet):
2971         (TestRunner::setDeveloperExtrasEnabled):
2972
2973 2015-07-24  Basile Clement  <basile_clement@apple.com>
2974
2975         Call fixChangeLogPatch when generating patches from webkit-patch
2976         https://bugs.webkit.org/show_bug.cgi?id=147248
2977
2978         Reviewed by Geoffrey Garen.
2979
2980         When two consecutive patches are from the same author, diff tools
2981         create wrong-looking diffs for ChangeLog files where the apparent added
2982         author is actually the previous patch's author line, making it awkward
2983         to read - and things only get worse when committing a patch and a
2984         followup fix for the same bug shortly after.
2985
2986         We have a perl function in VCSUtils.pm, fixChangeLogPatch, to corrects
2987         this, which we use in perl scripts (svn-create-patch et al). But it is
2988         not used by webkit-patch, which is a python script, and thus creates
2989         "bad" diffs.
2990
2991         In the long term, we should probably port fixChangeLogPatch to python -
2992         but in the short term, let's make webkit-patch call perl to run
2993         fixChangeLogPatch. We are already making various external calls there
2994         anyway.
2995
2996         * Scripts/webkitpy/common/checkout/scm/git.py:
2997         (Git.create_patch):
2998         * Scripts/webkitpy/common/checkout/scm/scm.py:
2999         (SCM.fix_changelog_patch):
3000         * Scripts/webkitpy/common/checkout/scm/svn.py:
3001         (SVN.create_patch):
3002
3003 2015-07-24  Dean Johnson  <dean_johnson@apple.com>
3004
3005         commit-queue flags in webkit-patch are confusing
3006         https://bugs.webkit.org/show_bug.cgi?id=88694
3007
3008         Reviewed by Csaba Osztrogonác.
3009
3010         * Scripts/webkitpy/tool/steps/options.py:
3011         (Options): Updated help string to be more descriptive.
3012
3013 2015-07-23  Brent Fulgham  <bfulgham@apple.com>
3014
3015         [Win] Implement proper High DPI support features
3016         https://bugs.webkit.org/show_bug.cgi?id=146335
3017         <rdar://problem/21558269>
3018
3019         Reviewed by Alex Christensen.
3020
3021         Update WinLauncher to take device scaling factor into account.
3022
3023         * WinLauncher/Common.cpp:
3024         (resizeSubViews): Make sure toolbars and URL bar are properly sized and using
3025         a valid font.
3026         (computeFullDesktopFrame): Handle high DPI desktops.
3027         (WndProc): Make comments more precise.
3028         * WinLauncher/WinLauncher.cpp:
3029         (WinLauncher::init): Determine device scale factor at launch.
3030         (WinLauncher::updateDeviceScaleFactor): Added.
3031         * WinLauncher/WinLauncher.h:
3032         * WinLauncher/WinLauncherWebHost.h: Use C++11 initialization.
3033         * WinLauncher/WinMain.cpp: Size interface based on scaling factor.
3034         (wWinMain): Ditto.
3035         * win/DLLLauncher/DLLLauncherMain.cpp:
3036         (wWinMain): Tell Windows we understand high DPI.
3037
3038 2015-07-23  Alex Christensen  <achristensen@webkit.org>
3039
3040         [Win] Unreviewed build fix after r187169.
3041
3042         * Scripts/build-webkit:
3043         Correctly find WebKit.sln.
3044
3045 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3046
3047         [GTK] Add API to allow executing editing commands that require an argument
3048         https://bugs.webkit.org/show_bug.cgi?id=146781
3049
3050         Reviewed by Gustavo Noronha Silva.
3051
3052         Add buttons to insert image/link to the MiniBrowser edit toolbar,
3053         and test cases for insert image/link commands too.
3054
3055         * MiniBrowser/gtk/BrowserWindow.c:
3056         (insertImageCommandCallback):
3057         (insertLinkCommandCallback):
3058         (browserWindowSetupEditorToolbar):
3059         (browserWindowConstructed):
3060         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3061         (testWebViewEditorInsertImage):
3062         (testWebViewEditorCreateLink):
3063         (beforeAll):
3064
3065 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3066
3067         Unregistering and re-registering a user message handler does not work
3068         https://bugs.webkit.org/show_bug.cgi?id=138142
3069
3070         Reviewed by Martin Robinson.
3071
3072         This has probably been fixed in r184846, enable the test case
3073         blocked on it.
3074
3075         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3076         (testUserContentManagerScriptMessageReceived):
3077
3078 2015-07-22  Sukolsak Sakshuwong  <sukolsak@gmail.com>
3079
3080         Add ENABLE_WEBASSEMBLY feature flag for WebAssembly
3081         https://bugs.webkit.org/show_bug.cgi?id=147212
3082
3083         Reviewed by Filip Pizlo.
3084
3085         * Scripts/webkitperl/FeatureList.pm:
3086
3087 2015-07-22  Jon Honeycutt  <jhoneycutt@apple.com>
3088
3089         Add --ios-simulator to run-api-tests --help.
3090
3091         Rubber-stamped by Dan Bates.
3092
3093         * Scripts/run-api-tests:
3094
3095 2015-07-22  Jason Marcell  <jmarcell@apple.com>
3096
3097         Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
3098         https://bugs.webkit.org/show_bug.cgi?id=147043
3099
3100         Reviewed by Daniel Bates and Alexey Proskuryakov.
3101
3102         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3103         (Buildbot.prototype._normalizeQueueInfo):
3104         The _normalizeQueueInfo method now calls the defaultBranches getter instead of using hardcoded values
3105         in cases where the queue.branch property is not set and the queue is not a combined queue.
3106         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3107         (BuildbotCombinedQueueView):
3108         Ensuring uniformity of repository branches within a combined queue.
3109         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3110         (WebKitBuildbot.prototype.get defaultBranches):
3111         Added; provides a WebKit-specific implementation that sets the queue.branches dictionary to have a
3112         single entry for "openSource" as the default set of branches. Note that we intentionally omitted a
3113         base class implementation of the defaultBranches getter so as to cause a JavaScript TypeError when a
3114         sub-queue of a combined queue does not specify property branch and the derived Buildbot class does not
3115         implement defaultBranches so that a person can either update the definition of the sub-queue or
3116         implement defaultBranches in the derived Buildbot class they are using.
3117
3118 2015-07-22  Alex Christensen  <achristensen@webkit.org>
3119
3120         Switch WinCairo build to use CMake.
3121         https://bugs.webkit.org/show_bug.cgi?id=147169
3122
3123         Reviewed by Brent Fulgham.
3124
3125         * Scripts/build-webkit:
3126         * Scripts/webkitdirs.pm:
3127         (determineConfiguration):
3128         (determineArchitecture):
3129         (determinePassedConfiguration):
3130         (passedConfiguration):
3131         (jhbuildWrapperPrefixIfNeeded):
3132         (generateBuildSystemFromCMakeProject):
3133         It's CMake time!  We now use the CMake files to generate a solution in WebKitBuild/Release/WebKit.sln and build that.
3134
3135 2015-07-22  Alex Christensen  <achristensen@webkit.org>
3136
3137         Fix quirks in CMake build on Mac and Windows
3138         https://bugs.webkit.org/show_bug.cgi?id=147174
3139
3140         Reviewed by Gyuyoung Kim.
3141
3142         * CMakeLists.txt:
3143         Don't build DumpRenderTree with CMake for now (until we get that working).
3144         * WinLauncher/CMakeLists.txt:
3145         Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build.
3146
3147 2015-07-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3148
3149         [check-webkit-style] .lut.h files shouldn't raise a sorting issue
3150         https://bugs.webkit.org/show_bug.cgi?id=147146
3151
3152         Reviewed by Darin Adler.
3153
3154         * Scripts/webkitpy/style/checkers/cpp.py:
3155         (check_include_line): Avoid checking previous lines if it it is a lut.h include.
3156         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3157         (OrderOfIncludesTest.test_check_alphabetical_include_order): Added test.
3158
3159 2015-07-21  Filip Pizlo  <fpizlo@apple.com>
3160
3161         Fixed VM pool allocation should have a reserve for allocations that cannot fail
3162         https://bugs.webkit.org/show_bug.cgi?id=147154
3163         rdar://problem/21847618
3164
3165         Reviewed by Geoffrey Garen.
3166         
3167         Add a new test mode where we artificially limit JIT memory to 50KB. If our JIT OOM
3168         mitigations work, these should all pass. Prior to this patch there were >20 failures.
3169
3170         * Scripts/run-jsc-stress-tests:
3171
3172 2015-07-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3173
3174         [GTK] Add API to be notified about editor state changes
3175         https://bugs.webkit.org/show_bug.cgi?id=145875
3176
3177         Reviewed by Gustavo Noronha Silva.
3178
3179         Update the typing attributes toggle buttons state according to the
3180         editor state in MiniBrowser, and add a test case to the
3181         WebViewEditor unit tests.
3182
3183         * MiniBrowser/gtk/BrowserWindow.c:
3184         (browserWindowEditingCommandToggleButtonSetActive):
3185         (typingAttributesChanged):
3186         (browserWindowSetupEditorToolbar):
3187         (browserWindowConstructed):
3188         (browser_window_init):
3189         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3190         (testWebViewEditorEditorStateTypingAttributes):
3191         (beforeAll):
3192
3193 2015-07-20  Tomas Popela  <tpopela@redhat.com>
3194
3195         [GTK] Add selection-changed signal to the WebKit2 API
3196         https://bugs.webkit.org/show_bug.cgi?id=137116
3197
3198         Reviewed by Carlos Garcia Campos.
3199
3200         Add a new WebProcess test TestEditor that is testing the WebKitWebEditor
3201         (namely the selection-changed signal).
3202
3203         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3204         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added.
3205         (WebKitWebEditorTest::create):
3206         (WebKitWebEditorTest::selectionChangedCallback):
3207         (WebKitWebEditorTest::testSelectionSelectAll):
3208         (WebKitWebEditorTest::testSelectionCollapse):
3209         (WebKitWebEditorTest::testSelectionModifyMove):
3210         (WebKitWebEditorTest::testSelectionModifyExtend):
3211         (WebKitWebEditorTest::testSelectionUnselect):
3212         (registerTests):
3213         * TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added.
3214         (testWebKitWebEditorSelectionChanged):
3215         (beforeAll):
3216         (afterAll):
3217
3218 2015-07-20  Alex Christensen  <achristensen@webkit.org>
3219
3220         Resurrect CMake build on Windows.
3221         https://bugs.webkit.org/show_bug.cgi?id=147083
3222
3223         Reviewed by Gyuyoung Kim.
3224
3225         * DumpRenderTree/CMakeLists.txt:
3226         * DumpRenderTree/PlatformWin.cmake: Added.
3227         * WinLauncher/CMakeLists.txt:
3228
3229 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3230
3231         [GTK] Enable seccomp filter API tests
3232         https://bugs.webkit.org/show_bug.cgi?id=140071
3233
3234         Reviewed by Žan Doberšek.
3235
3236         These tests will now be run by the run-gtk-tests script.
3237
3238         * TestWebKitAPI/PlatformGTK.cmake:
3239
3240 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3241
3242         [GTK] Add seccomp filters support
3243         https://bugs.webkit.org/show_bug.cgi?id=110014
3244
3245         Reviewed by Žan Doberšek.
3246
3247         Add libseccomp to jhbuild modulesets.
3248
3249         * gtk/jhbuild.modules:
3250
3251 2015-07-18  Simon Fraser  <simon.fraser@apple.com>
3252
3253         MiniBrowser window title is just "Window" when page has no <title>
3254         https://bugs.webkit.org/show_bug.cgi?id=147076
3255
3256         Reviewed by Tim Horton.
3257         
3258         Make MiniBrowser windows show the filename from the URL if we never get a title changed
3259         notification.
3260
3261         * MiniBrowser/mac/WK1BrowserWindowController.m:
3262         (-[WK1BrowserWindowController updateTitle:]):
3263         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]):
3264         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
3265         * MiniBrowser/mac/WK2BrowserWindowController.m:
3266         (-[WK2BrowserWindowController updateTitle:]):
3267         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3268         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
3269
3270 2015-07-17  Andy Estes  <aestes@apple.com>
3271
3272         [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment
3273         https://bugs.webkit.org/show_bug.cgi?id=147044
3274         rdar://problem/21567820
3275
3276         Reviewed by Brady Eidson.
3277
3278         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3279         (WTR::InjectedBundlePage::decidePolicyForResponse): Only log the message about attachments if the custom policy delegate is enabled.
3280         This matches the behavior of DumpRenderTree.
3281
3282 2015-07-17  Benjamin Poulain  <bpoulain@apple.com>
3283
3284         [Content Extensions] Term::isUniversalTransition() incorrectly expects the end-of-line assertion in character sets
3285         https://bugs.webkit.org/show_bug.cgi?id=147032
3286
3287         Reviewed by Alex Christensen.
3288
3289         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3290         Test that the useless terms are eliminated by counting
3291         the number of NFA nodes generated.
3292
3293 2015-07-17  Dan Bernstein  <mitz@apple.com>
3294
3295         Tests for <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
3296         https://bugs.webkit.org/show_bug.cgi?id=147040
3297
3298         Reviewed by Dean Jackson.
3299
3300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3301         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Added.
3302         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:decidePolicyForNavigationAction:decisionHandler:]):
3303         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:didFinishNavigation:]):
3304         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3305         (TEST):
3306
3307 2015-07-16  Dean Johnson  <dean_johnson@apple.com>
3308
3309         webkit-patch uses incorrect credentials from keychain to login until account lockout
3310         https://bugs.webkit.org/show_bug.cgi?id=146923
3311
3312         Reviewed by Daniel Bates.
3313
3314         When `webkit-patch upload` asks for login credentials for bugs.webkit.org, if you
3315         provide incorrect credentials then ask for them to be saved to the keychain
3316         webkit-patch will then use those incorrect credentials until 5 total attempts
3317         have been made to log in. This will lock the user out of Bugzilla for a
3318         half hour.
3319
3320         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3321         (Bugzilla.authenticate): Added argument to read_credentials() that
3322         passes in whether or not to use stored credentials.
3323         * Scripts/webkitpy/common/net/credentials.py:
3324         (Credentials.read_credentials): Added optional argument 'use_stored_credentials'
3325         that specifies whether or not to use credentials stored on the system. If it
3326         does, we do not auto-fill credentials since either the credentials caused
3327         the failure, or they weren't used in the first place so there is no reason
3328         to try and use them again if a failure happened.
3329         * Scripts/webkitpy/common/net/credentials_unittest.py: Added unit test for newly added
3330         use_stored_credentials argument.
3331         (test_do_not_use_stored_credentials): Added unit test to make sure functions that
3332         retrieve username/password information from the local system (environment, Git, keychain,
3333         keyring) are never called. It also tests that we get back our mocked username and password.
3334         (test_do_not_use_stored_credentials.MockKeyring): Mock keyring
3335         (test_do_not_use_stored_credentials.MockKeyring.get_password): Assert this is never called.
3336         (test_do_not_use_stored_credentials.FakeCredentials): Mock credentials
3337         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_keychain): Assert this
3338         is never called.
3339         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_environment): Ditto
3340         (test_do_not_use_stored_credentials.FakeCredentials._offer_to_store_credentials_in_keyring): Ditto
3341         (test_do_not_use_stored_credentials.FakeUser): Mock the User class
3342         (test_do_not_use_stored_credentials.FakeUser.prompt): Returns a username to assert against.
3343         (test_do_not_use_stored_credentials.FakeUser.prompt_password): Returns a password to assert
3344         against.
3345
3346 2015-07-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3347
3348         Unreviewed, remove my redundant email information.
3349
3350         * Scripts/webkitpy/common/config/contributors.json:
3351
3352 2015-07-16  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3353
3354         Unreviewed. Add Hyungwook Lee as a committer.
3355
3356         * Scripts/webkitpy/common/config/contributors.json:
3357
3358 2015-07-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3359
3360         Added myself to the list of contributors.
3361
3362         Reviewed by Brent Fulgham.
3363
3364         * Scripts/webkitpy/common/config/contributors.json:
3365
3366 2015-07-16  Alex Christensen  <achristensen@webkit.org>
3367
3368         [Content Extensions] Cache domain actions
3369         https://bugs.webkit.org/show_bug.cgi?id=146817
3370
3371         Reviewed by Benjamin Poulain.
3372
3373         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3374         (TestWebKitAPI::TEST_F):
3375         Test if-domain and unless-domain with multiple load types.
3376
3377 2015-07-16  Benjamin Poulain  <bpoulain@apple.com>
3378
3379         [Content extensions] Combine suffixes when generating NFAs
3380         https://bugs.webkit.org/show_bug.cgi?id=146961
3381
3382         Reviewed by Alex Christensen.
3383
3384         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3385         (TestWebKitAPI::compareContents):
3386         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3387
3388 2015-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3389
3390         [GTK] Input method filter is always enabled when the view is focused
3391         https://bugs.webkit.org/show_bug.cgi?id=146965
3392
3393         Reviewed by Martin Robinson.
3394
3395         Use setEnabled() instead of notifyFocusedIn() to enable input methods.
3396
3397         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
3398         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
3399
3400 2015-07-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3401
3402         [EFL] Bump libseccomp version to 2.2.3
3403         https://bugs.webkit.org/show_bug.cgi?id=146980
3404
3405         Reviewed by Gyuyoung Kim.
3406
3407         * efl/jhbuild.modules:
3408
3409 2015-07-15  Brent Fulgham  <bfulgham@apple.com>
3410
3411         [Win] Maintain consistent COM Interfaces
3412         https://bugs.webkit.org/show_bug.cgi?id=146983
3413         <rdar://problem/21822278>
3414
3415         Reviewed by Dean Jackson.
3416
3417         Update DumpRenderTree and WinLauncher to use the properly
3418         versioned COM interface objects.
3419
3420         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3421         (AccessibilityController::rootElement):
3422         * DumpRenderTree/win/DumpRenderTree.cpp:
3423         (resetWebPreferencesToConsistentValues):
3424         (resetWebViewToConsistentStateBeforeTesting):
3425         (runTest):
3426         (createWebViewAndOffscreenWindow):
3427         * DumpRenderTree/win/EditingDelegate.cpp:
3428         (EditingDelegate::QueryInterface):
3429         (EditingDelegate::shouldEndEditingInDOMRange):
3430         (EditingDelegate::shouldInsertNode):
3431         * DumpRenderTree/win/EditingDelegate.h:
3432         * DumpRenderTree/win/EventSender.cpp:
3433         (scalePageByCallback):
3434         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3435         (FrameLoadDelegate::didCommitLoadForFrame):
3436         * DumpRenderTree/win/TestRunnerWin.cpp:
3437         (TestRunner::callShouldCloseOnWebView):
3438         (TestRunner::applicationCacheDiskUsageForOrigin):
3439         (TestRunner::clearApplicationCacheForOrigin):
3440         (TestRunner::setDefersLoading):
3441         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3442         (TestRunner::setTabKeyCyclesThroughElements):
3443         (TestRunner::setValueForUser):
3444         (TestRunner::dispatchPendingLoadRequests):
3445         (TestRunner::setWindowIsKey):
3446         (TestRunner::execCommand):
3447         (TestRunner::addOriginAccessWhitelistEntry):
3448         (TestRunner::removeOriginAccessWhitelistEntry):
3449         (TestRunner::addUserScript):
3450         (TestRunner::addUserStyleSheet):
3451         (TestRunner::showWebInspector):
3452         (TestRunner::closeWebInspector):
3453         (TestRunner::evaluateInWebInspector):
3454         (TestRunner::setSerializeHTTPLoads):
3455         * DumpRenderTree/win/TextInputControllerWin.cpp:
3456         (TextInputController::setMarkedText):
3457         (TextInputController::hasMarkedText):
3458         (TextInputController::unmarkText):
3459         (TextInputController::markedRange):
3460         (TextInputController::insertText):
3461         (TextInputController::firstRectForCharacterRange):
3462         (TextInputController::selectedRange):
3463         * DumpRenderTree/win/UIDelegate.h:
3464         (UIDelegate::unused2):
3465         (UIDelegate::unused3):
3466         (UIDelegate::webViewScrolled):
3467         (UIDelegate::webViewShouldInterruptJavaScript):
3468         (UIDelegate::webViewReceivedFocus):
3469         (UIDelegate::unused4): Deleted.
3470         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3471         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
3472         * WinLauncher/PageLoadTestClient.cpp:
3473         (PageLoadTestClient::didStartProvisionalLoad):
3474         * WinLauncher/WinLauncher.cpp:
3475         (WinLauncher::init):
3476         * WinLauncher/WinLauncher.h:
3477         * WinLauncher/WinLauncherWebHost.cpp:
3478         (WinLauncherWebHost::didFinishLoadForFrame):
3479         (WinLauncherWebHost::didFirstLayoutInFrame):
3480         * WinLauncher/WinLauncherWebHost.h:
3481
3482 2015-07-15  Dean Johnson  <dean_johnson@apple.com>
3483
3484         Many test failures in scm_unittest.py
3485         https://bugs.webkit.org/show_bug.cgi?id=143967
3486
3487         Reviewed by Daniel Bates. 
3488
3489         * Scripts/webkitpy/common/checkout/scm/detection.py:
3490         (SCMDetector.detect_scm_system): Paths with symlinks are now resolved to
3491         absolute canonical file paths. Two mutually exclusive issues cause this
3492         to be a problem.
3493             1) Python's os.path.relpath() function does not return correct relative
3494             paths between two filepaths that point to the same file, if symlinks are
3495             involved.
3496                 On Mac, /tmp points to /private/tmp
3497                 ex. os.path.relpath('/tmp', '/private/tmp')
3498                     returns '../../tmp'
3499             What we want is actually just '.'
3500             2) Git does not allow file paths to trace outside of
3501             the Git repository. This means that if you have a repository in
3502             /tmp and you refer to that repository when invoking a git command as
3503             ../tmp, Git will produce errors about working outside of the repository.
3504         * Scripts/webkitpy/common/checkout/scm/git.py: Over time Git has changed
3505         its default behavior and such, needed to be updated.
3506         (Git.changed_files): '--' was added into the command so that patch_directories
3507         were taken as positional arguments.
3508         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Changed tests and setup 
3509         in the GitSVNTest class to more closely emulate the version of Git that the tests
3510         assumed a system had. Also fixed a small side-effect from the absolute canonical
3511         path fix in SCMDetector.detect_scm_system
3512         (SVNTestRepository.setup): A relative filepath was previously passed as the
3513         checkout root to SCMDetector.detect_scm_system, but is now cleaned to
3514         an absolute canonical path before being passed in. The failing test
3515         was a "sanity check" that the svn.checkout_root and scm.checkout_root
3516         were the same.
3517         (GitSVNTest._setup_git_checkout):
3518             1) Added "--prefix ''" option to `git clone` since Git changed its default
3519             behavior in version 2.0.
3520             2) The branch master was renamed to trunk to more closely emulate what
3521             tests expected when they were written. 
3522         (GitSVNTest.test_changed_files_local_plus_working_copy): Two of the three
3523         original tests failed because the tests expected the trunk branch
3524         to produce its parent's commit, whereas Git merely provides the HEAD commit
3525         for a given branch (trunk in this case). Based on other tests written
3526         in the same commit, it appears these tests were failing from the point they
3527         were written.
3528
3529 2015-07-14  Anders Carlsson  <andersca@apple.com>
3530
3531         Assertions.h should include ExportMacros.h
3532         https://bugs.webkit.org/show_bug.cgi?id=146948
3533
3534         Reviewed by Tim Horton.
3535
3536         Remove now unneeded WTF_EXPORT_PRIVATE define.
3537
3538         * DumpRenderTree/cg/ImageDiffCG.cpp:
3539
3540 2015-07-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3541
3542         [GTK] [Wayland] Build by default the X11 and Wayland targets.
3543         https://bugs.webkit.org/show_bug.cgi?id=146057
3544
3545         Reviewed by Carlos Garcia Campos.
3546
3547         * gtk/install-dependencies:
3548
3549 2015-07-10  Brent Fulgham  <bfulgham@apple.com>
3550
3551         [Mac] Unable to dismiss context menu during test runs
3552         https://bugs.webkit.org/show_bug.cgi?id=146836
3553
3554         Reviewed by Tim Horton.
3555
3556         Since Context Menus are modal, the test system would block on the displayed context menu,
3557         causing tests to fail. Instead, we should do what WK1 was doing, which is to perform the
3558         mouse click and generate the menu contents, but not ask AppKit to display it.
3559
3560         Drive-by fix: We did not handle 'escape' key presses. This is also fixed.
3561
3562         * DumpRenderTree/mac/EventSendingController.mm:
3563         (-[EventSendingController keyDown:withModifiers:withLocation:]): Handle the 'escape' character.
3564         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3565         (WTR::EventSendingController::mouseMoveTo): Keep track of the current mouse position.
3566         (WTR::EventSendingController::contextClick): Don't emit an actual context menu invocation and then
3567         copy the menu items. Instead, use WKBundlePageCopyContentMenuAtPointInWindow to do all the same
3568         work without actually calling on AppKit to display the menu.
3569         ask WebCore to do all the work EXCEPT displaying the menu.
3570         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3571         * WebKitTestRunner/mac/EventSenderProxy.mm:
3572         (WTR::EventSenderProxy::keyDown): Handle the 'escape' character.
3573
3574 2015-07-09  Filip Pizlo  <fpizlo@apple.com>
3575
3576         It should be possible to run the OSR exit fuzzer
3577         https://bugs.webkit.org/show_bug.cgi?id=146814
3578
3579         Reviewed by Mark Lam.
3580         
3581         This runs a test command to detect how many static OSR exit sites it had, and then for
3582         each exit site, it triggers three exits (earliest opportunity, last opportunity, some
3583         middle opportunity), plus a mode where the check always exits. This is an exhaustive
3584         search, so in the future it'll be very appropriate for cases where we have a simple test
3585         and we want to see what happens when you eventually exit in this test.