90679e37afbb20c56d5c1590ca56697d21b25ea9
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Some perf tests time out when ran by run-perf-tests
4         https://bugs.webkit.org/show_bug.cgi?id=76612
5
6         Reviewed by Dirk Pranke and Eric Seidel.
7
8         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
9         Otherwise some tests such as Parser/xml-parser.html will timeout.
10
11         --no-timeout option is currently supported by Chromium and Mac ports.
12
13         * Scripts/webkitpy/layout_tests/port/base.py:
14         (Port.to.create_driver):
15         * Scripts/webkitpy/layout_tests/port/chromium.py:
16         (ChromiumDriver.__init__):
17         (ChromiumDriver._wrapper_options):
18         * Scripts/webkitpy/layout_tests/port/driver.py:
19         (Driver.__init__):
20         (DriverProxy.__init__):
21         * Scripts/webkitpy/layout_tests/port/webkit.py:
22         (WebKitDriver.__init__):
23         (WebKitDriver.cmd_line):
24         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
25         (WebKitDriverTest.test_read_binary_block):
26         (WebKitDriverTest):
27         (WebKitDriverTest.test_no_timeout):
28         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
29         (get_tests_run.RecordingTestDriver.__init__):
30         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
31         (PerfTestsRunner._parse_args):
32         (PerfTestsRunner._run_tests_set):
33         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
34         (create_runner):
35
36 2012-01-19  Ben Wells  <benwells@chromium.org>
37
38         Add support for window.print to chromium DRT
39         https://bugs.webkit.org/show_bug.cgi?id=76479
40
41         When used in a test window.print goes into print mode and then
42         straight out again. This will allow the afterprint event to be
43         tested by having the afterprint event happen before the dump
44         happens.
45
46         Reviewed by Mihai Parparita.
47
48         * DumpRenderTree/chromium/WebViewHost.cpp:
49         (WebViewHost::printPage):
50         * DumpRenderTree/chromium/WebViewHost.h:
51
52 2012-01-18  Enrica Casucci  <enrica@apple.com>
53
54         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
55         https://bugs.webkit.org/show_bug.cgi?id=76588
56         <rdar://problem/9325183>
57
58         Added test.
59         
60         Reviewed by Dan Bernstein.
61
62         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
63         (TestWebKitAPI::TEST):
64
65 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
66
67         [Qt] Do full incremental builds until bots use update-webkit
68
69         Rubber-stamped by Simon Hausmann.
70
71         * Scripts/webkitdirs.pm:
72         (buildQMakeProjects):
73
74 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
75
76         Fix the Qt build
77
78         Unreviewed build fix.
79
80         * Scripts/webkitdirs.pm:
81         (buildQMakeProjects):
82
83 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
84
85         [Qt] Make build-webkit always do safe incremental builds after update-webkit
86
87         When building against Qt5 with GCC we would just run 'make' in the build dir,
88         and rely on the dependency files output by GCC (-MD) to handle dependency
89         tracking, but that fails for special-cases like adding a Q_OBJECT macro
90         to a header.
91
92         To guarantee that an incrmental build will work, we have to run 'make qmake',
93         which we now do on every build-webkit that's followed by a successful run
94         of update-webkit. The reasoning is that update-webkit can result in such
95         potential corner-cases being applied, and since we can't know for sure
96         unless we inspect the diff and account for all the corner cases we assume
97         the worst and always run 'make qmake'.
98
99         After a succesful run of build-webkit we proceed to do just 'make' for any
100         subsequent runs, since we assume that the developer knows what kind of
101         changes he/she is doing, and when a 'make qmake' is needed.
102
103         Reviewed by Simon Hausmann.
104
105         * Scripts/update-webkit:
106         * Scripts/webkitdirs.pm:
107         (determineCurrentSVNRevision):
108         (currentSVNRevision):
109         (buildQMakeProjects):
110         * qmake/mkspecs/features/default_post.prf:
111
112 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
113
114         run-perf-tests should support Skipped list
115         https://bugs.webkit.org/show_bug.cgi?id=76594
116
117         Reviewed by Adam Barth.
118
119         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
120
121         * Scripts/webkitpy/layout_tests/port/base.py:
122         (Port.perf_tests_dir):
123         (Port.skipped_perf_tests):
124         (Port.skips_perf_test):
125         (Port.relative_perf_test_filename):
126         * Scripts/webkitpy/layout_tests/port/test.py:
127         (TestPort.perf_tests_dir):
128         * Scripts/webkitpy/layout_tests/port/webkit.py:
129         (WebKitPort._expectations_from_skipped_files):
130         (WebKitPort):
131         (WebKitPort.skipped_layout_tests):
132         (WebKitPort.skipped_perf_tests):
133         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
134         (PerfTestsRunner._collect_tests):
135         (PerfTestsRunner.run):
136         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
137         (test_run_test_set_with_json_output):
138         (test_run_test_set_with_json_source):
139         (test_collect_tests_with_skipped_list):
140         (test_collect_tests_with_skipped_list.add_file):
141
142 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
143
144         Fix path to chromium_src_dir introduced in previous change.
145
146         Unreviewed, build fix.
147
148         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
149
150 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
151
152         Need infrastructure to test Content-Disposition filename encoding support
153         https://bugs.webkit.org/show_bug.cgi?id=76572
154         <rdar://problem/6421825>
155
156         Reviewed by Sam Weinig.
157
158         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
159
160         WebKitTestRunner does not have a policy delegate yet, bug 42546.
161
162         * DumpRenderTree/mac/PolicyDelegate.mm:
163         (dispositionTypeFromContentDispositionHeader):
164         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
165
166 2012-01-18  Ojan Vafai  <ojan@chromium.org>
167
168         Fix tests from http://trac.webkit.org/changeset/105332.
169
170         The code assumed that if you passed an options object with a configuration
171         attribute that it would have a valid value. A bunch of the testing mocks
172         do things like having a configuration value of None.
173
174         * Scripts/webkitpy/layout_tests/port/base.py:
175         (Port.__init__):
176
177 2012-01-18  Ojan Vafai  <ojan@chromium.org>
178
179         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
180         https://bugs.webkit.org/show_bug.cgi?id=76576
181
182         Reviewed by Adam Barth.
183
184         Avoid calling default_configuration in base.py. We don't need it for
185         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
186         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
187         from common.executive.
188
189         At some point someone should probably look into why that call is so slow
190         since it's on the critical path for run-webkit-tests and build-webkit startup.
191
192         * Scripts/webkitpy/layout_tests/port/base.py:
193         (Port.__init__):
194         * Scripts/webkitpy/style/checkers/test_expectations.py:
195         (TestExpectationsChecker._determine_port_from_exepectations_path):
196
197 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
198
199         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
200         https://bugs.webkit.org/show_bug.cgi?id=76505
201
202         Reviewed by Tony Chang.
203
204         Update chromium build script to use All.gyp instead of WebKit.gyp
205
206         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
207         * Scripts/webkitdirs.pm:
208
209 2012-01-18  Sam Weinig  <sam@webkit.org>
210
211         Don’t hardcode the path to ‘make‘.
212
213         Reviewed by Dan Bernstein.
214
215         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
216
217 2012-01-18  Joshua Bell  <jsbell@chromium.org>
218
219         Adding myself to committers.py
220         https://bugs.webkit.org/show_bug.cgi?id=76569
221
222         Unreviewed.
223
224         * Scripts/webkitpy/common/config/committers.py:
225
226 2012-01-18  Adam Barth  <abarth@webkit.org>
227
228         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
229         https://bugs.webkit.org/show_bug.cgi?id=76567
230
231         Reviewed by Eric Seidel.
232
233         Current the AppleMac port has slightly more failures than we allow on
234         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
235         which should hopefully let the mac-ews run to completion.  Once
236         AppleMac has fewer failures, we can lower the cap again.
237
238         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
239         (LayoutTestResultsReaderTest.test_layout_test_results):
240         * Scripts/webkitpy/tool/steps/runtests.py:
241         (RunTests):
242         * Scripts/webkitpy/tool/steps/steps_unittest.py:
243
244 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
245
246         Provide access to user's list of preferred languages
247         https://bugs.webkit.org/show_bug.cgi?id=76138
248
249         Reviewed by Alexey Proskuryakov.
250
251         * GNUmakefile.am: Add JSInternalsCustom.cpp.
252
253 2012-01-18  Adam Barth  <abarth@webkit.org>
254
255         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
256         configurations.
257
258         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
259         (ChromiumLinuxPort.__init__):
260
261 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
262
263         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
264         https://bugs.webkit.org/show_bug.cgi?id=73460
265
266         Reviewed by Chris Fleizach.
267
268         * DumpRenderTree/AccessibilityUIElement.h:
269         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
270         (AccessibilityUIElement::AccessibilityUIElement):
271         (AccessibilityUIElement::scrollToMakeVisibleCallback):
272         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
273         (AccessibilityUIElement::scrollToGlobalPointCallback):
274         * DumpRenderTree/chromium/AccessibilityUIElement.h:
275         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
276         (AccessibilityUIElement::scrollToMakeVisible):
277         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
278         (AccessibilityUIElement::scrollToGlobalPoint):
279         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
280         (AccessibilityUIElement::scrollToMakeVisible):
281         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
282         (AccessibilityUIElement::scrollToGlobalPoint):
283         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
284         (AccessibilityUIElement::scrollToMakeVisible):
285         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
286         (AccessibilityUIElement::scrollToGlobalPoint):
287
288 2012-01-17  Enrica Casucci  <enrica@apple.com>
289
290         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
291         https://bugs.webkit.org/show_bug.cgi?id=76490
292         <rdar://problem/9460733>
293
294         Added TestWebKitAPI test.
295         
296         Reviewed by Dan Bernstein.
297
298         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
299         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
300         changeAttributes to the WebView.
301         
302 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
303
304         [Qt] Consolidate layout test crash logging
305         https://bugs.webkit.org/show_bug.cgi?id=75088
306
307         Reviewed by Simon Hausmann.
308
309         Move backtrace generating logic into WTFReportBacktrace
310         and add a way to deinstall signal handlers if we know
311         that we have already printed the backtrace.
312
313         * DumpRenderTree/qt/main.cpp:
314         (crashHandler):
315         (setupSignalHandlers):
316         (WTFCrashHook):
317         (main):
318         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
319         (WTR::crashHandler):
320         (WTR::setupSignalHandlers):
321         (WTR::crashHook):
322         (WTR::InjectedBundle::platformInitialize):
323
324 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
325
326         Unreviewed build fix after r105256.
327
328         There was a cyclic dependency between self._port and self._host assigments.
329
330         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
331         (PerfTestsRunner.__init__):
332
333 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
334
335         Add new watchlist rule for the Qt build system
336
337         Reviewed by Simon Hausmann.
338
339         * Scripts/webkitpy/common/config/watchlist:
340
341 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
342
343         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
344
345         Reviewed by Simon Hausmann.
346
347         * Tools.pro:
348
349 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
350
351         [Qt] Allow building only a subset of the WebKit sub-projects
352
353         Fixes build-jsc, broken in r104825.
354
355         We no longer need the intermediate buildQMakeQtProject(), as we're the
356         only port using qmake, and buildQMakeProject is now highly Qt specific.
357
358         <http://webkit.org/b/76179>
359
360         Reviewed by Simon Hausmann.
361
362         * Scripts/build-jsc:
363         * Scripts/build-webkit:
364         * Scripts/webkitdirs.pm:
365         (buildQMakeProjects):
366
367 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
368
369         run-perf-tests should generate a json file that summaries the result
370         https://bugs.webkit.org/show_bug.cgi?id=76504
371
372         Reviewed by Adam Barth.
373
374         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
375         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
376         another json file to be merged into the generated json file.
377
378         Also fixed a bug that --build wasn't set by default.
379
380         * Scripts/webkitpy/layout_tests/port/test.py:
381         (TestPort.webkit_base):
382         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
383         (PerfTestsRunner.__init__):
384         (PerfTestsRunner):
385         (PerfTestsRunner._parse_args):
386         (PerfTestsRunner.run):
387         (PerfTestsRunner._generate_json_if_specified):
388         (PerfTestsRunner._process_chromium_style_test_result):
389         (PerfTestsRunner._process_parser_test_result):
390         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
391         (MainTest):
392         (create_runner):
393         (test_run_test_set):
394         (test_run_test_set_for_parser_tests):
395         (test_run_test_set_with_summary_json):
396         (test_collect_tests):
397         (test_parse_args):
398
399 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
400
401         Unreviewed, rolling out r105244.
402         http://trac.webkit.org/changeset/105244
403         https://bugs.webkit.org/show_bug.cgi?id=76518
404
405         broke Chromium Mac (Requested by rolandsteiner on #webkit).
406
407         * DumpRenderTree/AccessibilityUIElement.h:
408         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
409         (AccessibilityUIElement::AccessibilityUIElement):
410         * DumpRenderTree/chromium/AccessibilityUIElement.h:
411         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
412         (AccessibilityUIElement::removeSelection):
413         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
414         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
415         (AccessibilityUIElement::removeSelection):
416
417 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
418
419         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
420         https://bugs.webkit.org/show_bug.cgi?id=73460
421
422         Reviewed by Chris Fleizach.
423
424         * DumpRenderTree/AccessibilityUIElement.h:
425         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
426         (AccessibilityUIElement::AccessibilityUIElement):
427         (AccessibilityUIElement::scrollToMakeVisibleCallback):
428         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
429         (AccessibilityUIElement::scrollToGlobalPointCallback):
430         * DumpRenderTree/chromium/AccessibilityUIElement.h:
431         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
432         (AccessibilityUIElement::scrollToMakeVisible):
433         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
434         (AccessibilityUIElement::scrollToGlobalPoint):
435         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
436         (AccessibilityUIElement::scrollToMakeVisible):
437         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
438         (AccessibilityUIElement::scrollToGlobalPoint):
439         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
440         (AccessibilityUIElement::scrollToMakeVisible):
441         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
442         (AccessibilityUIElement::scrollToGlobalPoint):
443
444 2012-01-17  Adam Barth  <abarth@webkit.org>
445
446         Enable tests on the mac-ews
447         https://bugs.webkit.org/show_bug.cgi?id=76502
448
449         Reviewed by Simon Fraser.
450
451         Apple now has five machines running the mac-ews.  Lucas Forschler has
452         asked that we try enabling tests to see if we have enough bandwidth.
453
454         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
455         (MacEWS):
456
457 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
458
459         Add a check-webkit-style exception for GDBInterface.cpp
460         https://bugs.webkit.org/show_bug.cgi?id=76187
461
462         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
463         that it does not fail the style check.
464
465         Reviewed by Martin Robinson.
466
467         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
468         readability/naming tests on
469         Source/JavaScriptCore/jit/GDBInterface.cpp.
470         * Scripts/webkitpy/style/checker_unittest.py:
471         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
472         the above exception.
473
474 2012-01-17  Hajime Morrita  <morrita@chromium.org>
475
476         https://bugs.webkit.org/show_bug.cgi?id=76245
477         [Mac][DRT] should allow query string for the file URL.
478
479         Reviewed by Tony Chang.
480
481         Taught DRT about file:// as a url instead of a file path.
482         We are now able to use a path file:///foo/bar.html?baz as a url
483         with which DRT opens "/foo/bar.html" with "baz" as a query string.
484
485         * DumpRenderTree/mac/DumpRenderTree.mm:
486         (runTest):
487
488 2012-01-17  Ojan Vafai  <ojan@chromium.org>
489
490         Check style on test_expectations.txt files before commit
491         https://bugs.webkit.org/show_bug.cgi?id=76484
492
493         Reviewed by Adam Barth.
494
495         Unlike other style rules, if you get the syntax of the test_expectations.txt
496         file wrong, the layout tests won't run. Also, this check is simple and only
497         slows down committing if you actually modify one of the test_expectations.txt files.
498
499         * Scripts/webkitpy/tool/steps/commit.py:
500         (Commit._check_test_expectations):
501         (Commit.run):
502         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
503         (CommitTest):
504         (CommitTest.test_check_test_expectations):
505
506 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
507
508         [Qt] Debug build fails with debug qt5
509         https://bugs.webkit.org/show_bug.cgi?id=76463
510
511         Reviewed by Simon Hausmann.
512
513         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
514
515         * QtTestBrowser/cookiejar.h:
516
517 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
518
519         webkitpy: fix json import on linux
520         https://bugs.webkit.org/show_bug.cgi?id=76481
521
522         Reviewed by Adam Barth.
523
524         For some reason, the version of simplejson autoinstalled on my linux
525         box seems to be broken. We should really only be using
526         simplejson if json isn't available anyway, so this change looks
527         for json first.
528
529         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
530         (JSONGeneratorTest.test_test_timings_trie):
531
532 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
533
534         Fix failures in test-webkitpy caused by r105177.
535
536         Unreviewed, build fix.
537
538         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
539         (ChromiumLinuxPort._determine_driver_path_statically):
540         (ChromiumLinuxPort._static_build_path):
541
542 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
543
544         webkitpy: make PortFactory.get() be fully data-driven
545         https://bugs.webkit.org/show_bug.cgi?id=76360
546
547         Reviewed by Eric Seidel.
548
549         Refactor PortFactory.get() to be fully data-driven.
550
551         * Scripts/webkitpy/layout_tests/port/factory.py:
552         (PortFactory):
553         (PortFactory._default_port):
554         (PortFactory.get):
555         (PortFactory.get.in):
556         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
557         (FactoryTest.assert_port):
558
559 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
560
561         webkitpy: add determine_full_port_name(), clean up port.__init__()
562         https://bugs.webkit.org/show_bug.cgi?id=76357
563
564         Reviewed by Adam Barth.
565
566         Each Port class is now required to implement a 'port_name' field
567         that will match the start of all ports constructed by this class and
568         a 'determine_full_port_name' field that will make the port
569         fully-qualified.
570
571         * Scripts/webkitpy/layout_tests/port/apple.py:
572         (ApplePort.__init__):
573         * Scripts/webkitpy/layout_tests/port/base.py:
574         (Port):
575         (Port.determine_port_name):
576         (Port.__init__):
577         * Scripts/webkitpy/layout_tests/port/chromium.py:
578         (ChromiumPort.for):
579         (ChromiumPort.__init__):
580         (ChromiumPort):
581         (ChromiumPort._chromium_base_dir):
582         (ChromiumPort.path_from_chromium_base):
583         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
584         (ChromiumGpuLinuxPort):
585         (ChromiumGpuLinuxPort.__init__):
586         (ChromiumGpuMacPort):
587         (ChromiumGpuMacPort.__init__):
588         (ChromiumGpuWinPort):
589         (ChromiumGpuWinPort.__init__):
590         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
591         (ChromiumLinuxPort):
592         (ChromiumLinuxPort.determine_port_name):
593         (ChromiumLinuxPort.__init__):
594         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
595         (ChromiumMacPort):
596         (ChromiumMacPort.determine_port_name):
597         (ChromiumMacPort.__init__):
598         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
599         (ChromiumWinPort):
600         (ChromiumWinPort.determine_port_name):
601         (ChromiumWinPort.__init__):
602         * Scripts/webkitpy/layout_tests/port/dryrun.py:
603         (DryRunPort):
604         (DryRunPort.determine_port_name):
605         (DryRunPort.__init__):
606         * Scripts/webkitpy/layout_tests/port/efl.py:
607         (EflPort):
608         * Scripts/webkitpy/layout_tests/port/factory.py:
609         (PortFactory):
610         (PortFactory._default_port):
611         (PortFactory.get):
612         (PortFactory.get.in):
613         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
614         (FactoryTest.assert_port):
615         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
616         (GoogleChromeLinux32Port):
617         (GoogleChromeLinux32Port.determine_port_name):
618         (GoogleChromeLinux64Port):
619         (GoogleChromeLinux64Port.determine_port_name):
620         (GoogleChromeMacPort):
621         (GoogleChromeMacPort.determine_port_name):
622         (GoogleChromeWinPort):
623         (GoogleChromeWinPort.determine_port_name):
624         * Scripts/webkitpy/layout_tests/port/gtk.py:
625         (GtkPort):
626         * Scripts/webkitpy/layout_tests/port/mac.py:
627         (MacPort):
628         (MacPort.determine_port_name):
629         (MacPort.__init__):
630         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
631         (test_versions):
632         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
633         (MockDRTPort):
634         (MockDRTPort.determine_port_name):
635         (MockDRTPort.__init__):
636         (MockDRT):
637         (MockDRT.determine_port_name):
638         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
639         (PortTestCase.make_port):
640         * Scripts/webkitpy/layout_tests/port/qt.py:
641         (QtPort):
642         (QtPort.determine_port_name):
643         (QtPort.__init__):
644         * Scripts/webkitpy/layout_tests/port/test.py:
645         (TestPort):
646         (TestPort.determine_port_name):
647         (TestPort.__init__):
648         * Scripts/webkitpy/layout_tests/port/webkit.py:
649         (WebKitPort.__init__):
650         * Scripts/webkitpy/layout_tests/port/win.py:
651         (WinPort):
652         (WinPort.determine_port_name):
653         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
654         (get_test_baselines.AllPlatformsPort.__init__):
655         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
656         (get_test_config.TestMacPort):
657         (get_test_config):
658
659 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
660
661         webkitpy: clean up port code in preparation for static port names
662         https://bugs.webkit.org/show_bug.cgi?id=76356
663
664         Reviewed by Adam Barth.
665
666         To fix bug 76215 and be able to determine appropriate port names
667         in webkitpy without actually constructing Port objects, we need
668         to shuffle some logic in the chromium ports to be able to figure
669         out whether we built DRT in 32 or 64-bit mode.
670
671         * Scripts/webkitpy/layout_tests/port/chromium.py:
672         (ChromiumPort):
673         (ChromiumPort._chromium_base_dir):
674         (ChromiumPort.__init__):
675         (ChromiumPort.path_from_chromium_base):
676         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
677         (ChromiumLinuxPort):
678         (ChromiumLinuxPort._determine_driver_path_statically):
679         (ChromiumLinuxPort._static_build_path):
680         (ChromiumLinuxPort._determine_architecture):
681         (ChromiumLinuxPort.__init__):
682         (ChromiumLinuxPort._build_path):
683
684 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
685
686         Do not remove pixel failures for ref tests.
687         https://bugs.webkit.org/show_bug.cgi?id=76243
688
689         Reviewed by Tony Chang.
690
691         'NRWT --no-pixel-tests' complains when reftests are expected to
692         be image mismatch.
693
694         * Scripts/webkitpy/layout_tests/controllers/manager.py:
695         (Manager._update_summary_with_result):
696         * Scripts/webkitpy/layout_tests/models/test_failures.py:
697         (is_reftest_failure):
698         (determine_result_type):
699
700 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
701
702         REGRESSION(r81225): ORWT should ignore reftests
703         https://bugs.webkit.org/show_bug.cgi?id=67936
704
705         Reviewed by Csaba Osztrogonác.
706
707         * Scripts/old-run-webkit-tests:
708         (isUsedInReftest): $filename should be the first parameter
709         (findTestsToRun): run test if it isn't reftest
710
711 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
712
713         Unreviewed. Fix python unit test I broke with r105142
714
715         * Scripts/webkitpy/common/config/ports_unittest.py:
716         (WebKitPortTest.test_gtk_port):
717
718 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
719
720         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
721
722         Qt 5 no longer has that flag.
723
724         Reviewed by Simon Hausmann.
725
726         * MiniBrowser/qt/MiniBrowserApplication.cpp:
727         (MiniBrowserApplication::notify):
728
729 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
730
731         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
732         https://bugs.webkit.org/show_bug.cgi?id=75857
733
734         Reviewed by Adam Barth.
735
736         * Scripts/webkitdirs.pm:
737         (buildAutotoolsProject): move cleaning the build to happen early,
738         and handle --update-gtk right after that
739         * Scripts/webkitpy/common/config/ports.py:
740         (GtkPort.build_webkit_command): pass --update-gtk as an option to
741         build-webkit, so that it is used in the EWS
742
743 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
744
745         [Qt] Don't add _debug postfix to targets when building debug only
746
747         Reviewed by Simon Hausmann.
748
749         * qmake/mkspecs/features/default_post.prf:
750         * qmake/mkspecs/features/functions.prf:
751
752 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
753
754         [Qt] Add more files to project-files for easier navigation in Qt Creator
755
756         Reviewed by Simon Hausmann.
757
758         * Tools.pro:
759         * qmake/config.tests/README: Added.
760
761 2012-01-17  Philippe Normand  <pnormand@igalia.com>
762
763         [GTK] fast/dom/constructed-objects-prototypes.html fails
764         https://bugs.webkit.org/show_bug.cgi?id=75432
765
766         Reviewed by Martin Robinson.
767
768         * Scripts/build-webkit: Enable video-track in GTK.
769
770 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
771
772         Add toyoshim as a committer.
773         https://bugs.webkit.org/show_bug.cgi?id=76390
774
775         Reviewed by Hajime Morita.
776
777         * Scripts/webkitpy/common/config/committers.py:
778
779 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
780
781         [WinCairo] Build fix after r104155. Several debug targets were not
782         properly including the '*Common' property sheets.
783
784         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
785         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
786         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
787         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
788         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
789
790 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
791
792         REGRESSION(r105072): It broke committers_unittest.py
793         https://bugs.webkit.org/show_bug.cgi?id=76396
794
795         Reviewed by Adam Barth.
796
797         * Scripts/webkitpy/common/config/committers_unittest.py:
798         (CommittersTest._assert_fuzz_match): It should handle more names.
799         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
800
801 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
802
803         [GTK] Include gtk+3 in the jhbuild modules
804         https://bugs.webkit.org/show_bug.cgi?id=76284
805
806         Reviewed by Philippe Normand.
807
808         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
809
810 2012-01-16  Dan Winship  <danw@gnome.org>
811
812         Add myself as a committer
813
814         Unreviewed
815
816         * Scripts/webkitpy/common/config/committers.py:
817
818 2012-01-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
819
820         Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
821
822         Some recent versions of a few Linux distributions have started passing
823         --as-needed and --no-copy-dt-needed-entries by default to the linker,
824         which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
825         needed a few symbols from libjavascriptcore_efl.so.
826
827         * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
828         before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
829         libraries are searched in the right order by the linker.
830
831 2012-01-16  Philippe Normand  <pnormand@igalia.com>
832
833         [GTK] set audio resources path in NRTW
834         https://bugs.webkit.org/show_bug.cgi?id=76380
835
836         Reviewed by Martin Robinson.
837
838         * Scripts/webkitpy/layout_tests/port/gtk.py:
839         (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
840         the uninstalled audio resources are used during webaudio tests.
841
842 2012-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
843
844         [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
845         https://bugs.webkit.org/show_bug.cgi?id=76369
846
847         Reviewed by Xan Lopez.
848
849         If there's an installed version of webkit and there are new
850         symbols in the build tree, gtkdoc-scanobj fails due to undefined
851         references, because the env ldflags are given before the local
852         ones.
853
854         * gtk/gtkdoc.py:
855         (GTKDoc._run_gtkdoc_scangobj):
856
857 2012-01-15  Pablo Flouret  <pablof@motorola.com>
858
859         Fix compilation errors on build-webkit --debug --no-video on mac.
860         https://bugs.webkit.org/show_bug.cgi?id=75867
861
862         Reviewed by Philippe Normand.
863
864         Add --[no-]video-track to build-webkit, since video track feature
865         depends on video.
866
867         * Scripts/build-webkit:
868
869 2012-01-14  James Robinson  <jamesr@chromium.org>
870
871         [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
872         https://bugs.webkit.org/show_bug.cgi?id=76313
873
874         Reviewed by Adam Barth.
875
876         The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
877
878         * Scripts/run-chromium-webkit-unit-tests:
879
880 2012-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
881
882         Unreviewed, rolling out r105017.
883         http://trac.webkit.org/changeset/105017
884         https://bugs.webkit.org/show_bug.cgi?id=76333
885
886         broke the build (Requested by philn-tp on #webkit).
887
888         * gtk/jhbuild.modules:
889
890 2012-01-14  Mario Sanchez Prada  <msanchez@igalia.com>
891
892         [GTK] Include gtk+3 in the jhbuild modules
893         https://bugs.webkit.org/show_bug.cgi?id=76284
894
895         Reviewed by Philippe Normand.
896
897         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
898
899 2012-01-13  Adam Barth  <abarth@webkit.org>
900
901         Remove --dry-run support from webkit-patch
902         https://bugs.webkit.org/show_bug.cgi?id=76300
903
904         Reviewed by Dirk Pranke.
905
906         This is the rest of the patch from Bug 76300.  I landed it separtely
907         because main.py had some stray conflict markers that I needed to clean
908         up first.
909
910         * Scripts/webkitpy/test/main.py:
911         (Tester.parse_args):
912         (Tester._run_tests):
913
914 2012-01-13  Adam Barth  <abarth@webkit.org>
915
916         test-webkitpy does not run
917         https://bugs.webkit.org/show_bug.cgi?id=76318
918
919         Unreviewed.
920
921         Looks like some conflict markers got left in the file.
922
923         * Scripts/webkitpy/test/main.py:
924         (Tester.run):
925
926 2012-01-13  Adam Barth  <abarth@webkit.org>
927
928         Remove --dry-run support from webkit-patch
929         https://bugs.webkit.org/show_bug.cgi?id=76300
930
931         Reviewed by Dirk Pranke.
932
933         We don't use this functionality for anything, and it doesn't really
934         work.  Someone in #webkit tried using it and and got sad/confused.  We
935         should just remove it.
936
937         * Scripts/webkitpy/common/checkout/scm/git.py:
938         (Git.push_local_commits_to_server):
939         * Scripts/webkitpy/common/checkout/scm/scm.py:
940         (SCM.__init__):
941         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
942         (_shared_test_commit_with_message):
943         (GitSVNTest.test_commit_text_parsing):
944         * Scripts/webkitpy/common/checkout/scm/svn.py:
945         (SVN.commit_with_message):
946         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
947         (Bugzilla.__init__):
948         (Bugzilla.quips):
949         (Bugzilla.authenticate):
950         (Bugzilla.add_attachment_to_bug):
951         (Bugzilla.add_patch_to_bug):
952         (Bugzilla.create_bug):
953         (Bugzilla.clear_attachment_flags):
954         (Bugzilla.set_flag_on_attachment):
955         (Bugzilla.obsolete_attachment):
956         (Bugzilla.add_cc_to_bug):
957         (Bugzilla.post_comment_to_bug):
958         (Bugzilla.close_bug_as_fixed):
959         (Bugzilla.reassign_bug):
960         (reopen_bug):
961         * Scripts/webkitpy/test/main.py:
962         (Tester.parse_args):
963         (Tester.run_tests):
964
965 2012-01-13  David Levin  <levin@chromium.org>
966
967         check-webkit-style: should encourage the use of Own* classes for Windows DC.
968         https://bugs.webkit.org/show_bug.cgi?id=76227
969
970         Reviewed by Dirk Pranke.
971
972         * Scripts/webkitpy/style/checkers/cpp.py:
973         (check_for_leaky_patterns): The new check.
974         (process_line): Added a call to the new check.
975         (CppChecker): Added the new error type.
976         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
977         (CppStyleTestBase):
978         (CppStyleTestBase.perform_leaky_pattern_check):
979         The check for only leaky pattern errors.
980         (LeakyPatternTest): Test cases.
981
982 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
983
984         test-webkitpy: clean up handling of test directories, QueueStatusServer
985         https://bugs.webkit.org/show_bug.cgi?id=76238
986
987         Reviewed by Adam Barth.
988
989         This patch cleans up a bunch of hacks related to how we find all
990         of the python unit tests and set up the sys.path variable in
991         test-webkitpy.
992
993         This patch changes how test-webkitpy works slightly in that we
994         will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
995         rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
996         This greatly simplifies the mapping of paths to module names and
997         appears to have no significant performance impact or other drawbacks.
998
999         There are other ways that we could remove all of the hacks and
1000         still have a more flexible mapping of paths to module names, but
1001         the ones I've thought of so far add a decent amount of complexity to
1002         the implementation and don't seem to buy us much.
1003         
1004         * QueueStatusServer/__init__.py:
1005         * Scripts/test-webkitpy:
1006         * Scripts/webkitpy/test/main.py:
1007         (Tester._modules_from_paths):
1008         (Tester._is_module):
1009
1010 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1011
1012         test-webkitpy: should support classes and individual test names as well as modules
1013         https://bugs.webkit.org/show_bug.cgi?id=76233
1014
1015         Reviewed by Adam Barth.
1016
1017         The default unittest.main() supports a list of individual
1018         TestCase classes or individual tests as well as modules. This
1019         change adds support for the same to test-webkitpy, so now you
1020         can say
1021
1022           % test-wekbitpy webkitpy.test.cat_unittest.CatTest
1023
1024         and
1025
1026           % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
1027
1028         in addition to
1029
1030           % test-wekbitpy webkitpy.test.cat_unittest
1031
1032         * Scripts/test-webkitpy:
1033         * Scripts/webkitpy/test/cat_unittest.py:
1034         * Scripts/webkitpy/test/main.py:
1035         (Tester.parse_args):
1036         (Tester.run):
1037         (Tester):
1038         (Tester._find_modules):
1039         (Tester._exclude):
1040         (Tester._run_tests):
1041         (Tester._is_module):
1042         (Tester._log_exception):
1043
1044 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1045
1046         test-webkitpy: add basic code coverage support
1047         https://bugs.webkit.org/show_bug.cgi?id=76201
1048
1049         Reviewed by Adam Barth.
1050
1051         This test adds basic code coverage support to test-webkitpy; if
1052         you pass the -c flag, we will generate a new coverage file. We
1053         can start simply with this and add more features as necessary.
1054
1055         This patch requires coverage to be already installed on the
1056         machine. I am not auto-installing this for now.
1057
1058         * Scripts/webkitpy/test/main.py:
1059         (Tester.parse_args):
1060         (Tester.run_tests):
1061
1062 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1063
1064         StatusBubbleTest.test_build_bubble is failing
1065         https://bugs.webkit.org/show_bug.cgi?id=76222
1066
1067         Reviewed by Adam Barth.
1068
1069         * QueueStatusServer/handlers/statusbubble_unittest.py:
1070         (StatusBubbleTest.test_build_bubble):
1071
1072 2012-01-13  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1073
1074         nrwt should use multiple http shards
1075         https://bugs.webkit.org/show_bug.cgi?id=75958
1076
1077         Add --max-locked-shards option to the nrwt for manual set
1078         the maximum number of the locked shards
1079
1080         Reviewed by Dirk Pranke.
1081
1082         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1083         (Manager._max_locked_shards):
1084         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1085         (ShardingTests.get_shards):
1086         (ShardingTests.test_multiple_locked_shards):
1087         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1088         (parse_args):
1089
1090 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
1091
1092         prepare-ChangeLog: Look for a text editor in a few more variables.
1093         https://bugs.webkit.org/show_bug.cgi?id=76289
1094
1095         Reviewed by Ryosuke Niwa.
1096
1097         A text editor was looked for only in the CHANGE_LOG_EDITOR and
1098         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
1099         to the OS X-specific open(1) command.
1100
1101         As there does not seem to be a common way of looking for a text editor
1102         among the scripts in Tools/Scripts right now, just look at $VISUAL and
1103         $EDITOR (set much more often than the other variables in Unix systems)
1104         before falling back to open(1).
1105
1106         * Scripts/prepare-ChangeLog:
1107         (openChangeLogs):
1108
1109 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
1110
1111         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
1112         https://bugs.webkit.org/show_bug.cgi?id=76269
1113
1114         Reviewed by Martin Robinson.
1115
1116         * gtk/gtkdoc.py:
1117         (GTKDoc._run_gtkdoc_scangobj):
1118
1119 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1120
1121         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
1122         https://bugs.webkit.org/show_bug.cgi?id=76247
1123
1124         Reviewed by Kenneth Rohde Christiansen.
1125
1126         * WebKitTestRunner/TestController.cpp:
1127         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
1128
1129 2012-01-13  Hajime Morrita  <morrita@chromium.org>
1130
1131         [Mac][DRT] Should support --no-timeout
1132         https://bugs.webkit.org/show_bug.cgi?id=76242
1133
1134         Reviewed by Darin Adler.
1135
1136         * DumpRenderTree/mac/DumpRenderTree.mm:
1137         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
1138         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
1139         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
1140         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1141         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1142         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
1143
1144 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
1145
1146         Mitigate scrollbar differences when running pixel tests
1147         https://bugs.webkit.org/show_bug.cgi?id=67217
1148
1149         Reviewed by Dan Bernstein.
1150         
1151         Enable mock scrollbars by default for tests.
1152
1153         * DumpRenderTree/mac/DumpRenderTree.mm:
1154         (resetDefaultsToConsistentValues):
1155         * WebKitTestRunner/TestController.cpp:
1156         (WTR::TestController::resetStateToConsistentValues):
1157
1158 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
1159
1160         Need a script to run tests in PerformanceTests
1161         https://bugs.webkit.org/show_bug.cgi?id=76132
1162
1163         Reviewed by Adam Barth.
1164
1165         Add run-perf-tests to run performance tests using parser/resources/runner.js.
1166         Unfortunately, there isn't an easy way of telling which test uses which format
1167         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
1168
1169         All test outputs are re-formatted to match Chromium perf-bot style.
1170
1171         * Scripts/run-inspector-perf-tests.py:
1172         * Scripts/run-perf-tests: Added.
1173         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1174         (PerfTestsRunner):
1175         (PerfTestsRunner.__init__):
1176         (PerfTestsRunner._collect_tests):
1177         (PerfTestsRunner.run):
1178         (PerfTestsRunner._print_status):
1179         (PerfTestsRunner._run_tests_set):
1180         (PerfTestsRunner._process_chromium_style_test_result):
1181         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
1182         (PerfTestsRunner._process_parser_test_result):
1183         (PerfTestsRunner._run_single_test):
1184         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1185         (MainTest.TestDriver.run_test):
1186         (create_runner):
1187         (run_test):
1188         (test_run_test_set):
1189         (test_run_test_set_for_parser_tests):
1190         (test_collect_tests):
1191
1192 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1193
1194         webkitpy: clean up port unit tests in preparation for making port_name mandatory
1195         https://bugs.webkit.org/show_bug.cgi?id=76123
1196
1197         Reviewed by Adam Barth.
1198
1199         This change updates the unit tests to be more consistent in how
1200         ports are created, in preparation for making port_name a
1201         mandatory parameter to the constructor and removing any version
1202         interpretation from it.
1203
1204         There should be no functional changes in this patch, but some
1205         tests that are no longer relevant have been removed or reworked.
1206
1207         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1208         (PortTest.test_get_option__default):
1209         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1210         (ChromiumLinuxPortTest):
1211         (ChromiumLinuxPortTest.assert_architecture):
1212         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1213         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1214         (ChromiumMacPortTest):
1215         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1216         (ChromiumPortTest):
1217         (ChromiumPortTest.test_all_test_configurations):
1218         (ChromiumPortTest.TestMacPort.__init__):
1219         (ChromiumPortTest.TestLinuxPort.__init__):
1220         (ChromiumPortTest.TestWinPort.__init__):
1221         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1222         (ChromiumWinTest):
1223         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1224         (EflPortTest):
1225         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1226         (GtkPortTest):
1227         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1228         (MacTest):
1229         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1230         (MockDRTPortTest):
1231         (MockDRTPortTest.make_port):
1232         * Scripts/webkitpy/layout_tests/port/qt.py:
1233         (QtPort._port_flag_for_scripts):
1234         (QtPort.__init__):
1235         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1236         (QtPortTest):
1237         (QtPortTest._assert_search_path):
1238         (QtPortTest.test_baseline_search_path):
1239         (QtPortTest.test_operating_system):
1240         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1241         (WebKitPortTest):
1242         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1243         (WinPortTest):
1244         (WinPortTest._assert_search_path):
1245         (WinPortTest.test_baseline_search_path):
1246         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1247         (get_test_config.TestMacPort.__init__):
1248
1249 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1250
1251         test-webkitpy: clean up logging and provide a real --help message
1252         https://bugs.webkit.org/show_bug.cgi?id=76142
1253
1254         Reviewed by Adam Barth.
1255
1256         This test is mostly more refactoring - it calls objects in
1257         unittest directly instead of routing through unittest.main() --
1258         in order to gain more control over the logging and to provide a
1259         correct --help message. This will also give us a better
1260         foundation for adding more feautures down the road.
1261
1262         This patch adds different levels of logging controlled by the
1263         '-s', '-q', and '-v' options (see --help for details), and
1264         removes the --verbose-logging option.
1265
1266         * Scripts/test-webkitpy:
1267         * Scripts/webkitpy/test/main.py:
1268         (Tester):
1269         (Tester.clean_packages):
1270         (Tester.__init__):
1271         (Tester.parse_args):
1272         (Tester.configure):
1273         (Tester._configure_logging):
1274         (Tester.find_modules):
1275         (Tester._exclude):
1276         (Tester._modules_from_paths):
1277         (Tester.run_tests):
1278
1279 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
1280
1281         Make the new WTF module build on Qt
1282         https://bugs.webkit.org/show_bug.cgi?id=76163
1283
1284         Reviewed by Tor Arne Vestbø.
1285
1286         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
1287
1288 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1289
1290         Unreviewed, mac DumpRenderTree fix.
1291
1292         * DumpRenderTree/mac/UIDelegate.mm:
1293         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1294
1295 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1296
1297         WebKitTestRunner should not print console message line number when it is equal to zero.
1298         https://bugs.webkit.org/show_bug.cgi?id=76167
1299
1300         Reviewed by Csaba Osztrogonác.
1301
1302         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1303         (WTR::InjectedBundlePage::willAddMessageToConsole):
1304
1305 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
1306
1307         Make default console messages line numbers consistent.
1308         https://bugs.webkit.org/show_bug.cgi?id=74075
1309
1310         Reviewed by Pavel Feldman.
1311
1312         Unset line numbers are not printed to console now.
1313         Added Source/WebCore/inspector to efl DumpRenderTree include path.
1314
1315         * DumpRenderTree/chromium/WebViewHost.cpp:
1316         (WebViewHost::didAddMessageToConsole):
1317         * DumpRenderTree/efl/CMakeLists.txt:
1318         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1319         (onConsoleMessage):
1320         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1321         (webViewConsoleMessage):
1322         * DumpRenderTree/mac/UIDelegate.mm:
1323         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1324         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1325         (WebCore::WebPage::javaScriptConsoleMessage):
1326         * DumpRenderTree/win/UIDelegate.cpp:
1327         (UIDelegate::webViewAddMessageToConsole):
1328         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1329         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
1330
1331 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
1332
1333         test-webkitpy: push more logic into webkitpy.test.main, clean up code
1334         https://bugs.webkit.org/show_bug.cgi?id=76021
1335
1336         Reviewed by Eric Seidel.
1337
1338         I plan to add more functionality to test-webkitpy, but it is
1339         difficult to hack on now; this patch is the first of two that
1340         brings test-webkitpy more inline with current coding style by
1341         pushing more logic into the webkitpy.test.main.Tester class (so
1342         that it will be testable itself).
1343         
1344         There should be no functional changes in this patch.
1345
1346         * Scripts/test-webkitpy:
1347         (_path_from_webkit_root):
1348         * Scripts/webkitpy/test/main.py:
1349         (Tester):
1350         (Tester.init):
1351         (Tester.configure_logging):
1352         (Tester.configure_logging.filter):
1353         (Tester.clean_packages):
1354         (Tester.run_tests):
1355
1356 2012-01-11  Wei Jia  <wjia@chromium.org>
1357
1358         implement layout tests for <video> with media stream
1359         https://bugs.webkit.org/show_bug.cgi?id=74882
1360
1361         Reviewed by Kent Tamura.
1362
1363         * DumpRenderTree/DumpRenderTree.gypi:
1364         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
1365         (WebKit::WebUserMediaClientMock::create):
1366         (WebKit::WebUserMediaClientMock::IsMockStream):
1367         (WebKit::WebUserMediaClientMock::requestUserMedia):
1368         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
1369         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
1370         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
1371         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
1372         * DumpRenderTree/chromium/WebViewHost.cpp:
1373         (WebViewHost::userMediaClient):
1374         (WebViewHost::userMediaClientMock):
1375         (WebViewHost::createMediaPlayer):
1376         (WebViewHost::mediaStreamUtil):
1377         (WebViewHost::testMediaStreamClient):
1378         * DumpRenderTree/chromium/WebViewHost.h:
1379
1380 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1381
1382         Unreviewed, build fix.
1383
1384         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
1385
1386         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1387         (ChromiumWinPort.__init__):
1388
1389 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1390
1391         Sheriffbot build fix. Don't emit empty lines on IRC.
1392
1393         * Scripts/webkitpy/tool/bot/irc_command.py:
1394         (LastGreenRevision.execute):
1395
1396 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1397
1398         last-green-revision should report the revision that succeeded on all bots
1399         https://bugs.webkit.org/show_bug.cgi?id=76109
1400
1401         Reviewed by Adam Barth.
1402
1403         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
1404         considered green by this algorithm, all matching builders must have a successful run at the revision
1405         or two consecutive successful runs before and after the revision.
1406
1407         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
1408         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
1409
1410         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1411         (BuildBot._revisions_for_builder):
1412         (BuildBot):
1413         (BuildBot._find_green_revision):
1414         (BuildBot.last_green_revision):
1415         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1416         (MockBuildBot.last_green_revision):
1417         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1418         (test_revisions_for_builder):
1419         (test_find_green_revision):
1420         (test_last_green_revision):
1421         * Scripts/webkitpy/tool/bot/irc_command.py:
1422         (LastGreenRevision.execute):
1423         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1424         (SheriffIRCBotTest.test_lgr):
1425         * Scripts/webkitpy/tool/commands/queries.py:
1426         (LastGreenRevision):
1427
1428 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1429
1430         Unreviewed, fix build bustage on win32 introduced by r104725.
1431
1432         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1433         (MockDRTPortTest.make_port):
1434         (MockChromiumDRTTest.test_pixeltest__fails):
1435
1436 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
1437
1438         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
1439         https://bugs.webkit.org/show_bug.cgi?id=75618
1440
1441         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
1442
1443         Reviewed by Tony Chang.
1444
1445         * DumpRenderTree/chromium/LayoutTestHelper.mm:
1446         (installLayoutTestColorProfile):
1447         (restoreUserColorProfile):
1448         (main):
1449
1450 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1451
1452         test-webkitpy: fix -v and eliminate some spurious warnings
1453         https://bugs.webkit.org/show_bug.cgi?id=76099
1454
1455         Reviewed by Adam Barth.
1456
1457         when we added support for --xml output, we broke the -v flag.
1458
1459         Also, fix the code to swallow a harmless warning from
1460         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
1461
1462         test-webkitpy is now silent again except for the one known
1463         logging issue.
1464
1465         * Scripts/webkitpy/common/checkout/checkout.py:
1466         (Checkout.commit_message_for_this_commit):
1467         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1468         (test_commit_message_for_this_commit):
1469         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1470         (JSONChecker.check):
1471         (JSONChecker.line_number_from_json_exception):
1472         * Scripts/webkitpy/test/main.py:
1473         (Tester.run_tests):
1474
1475 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1476
1477         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
1478         https://bugs.webkit.org/show_bug.cgi?id=76084
1479
1480         Reviewed by Adam Barth.
1481
1482         This will help make it easier to catch layering violations. This
1483         change just refactors test code; there are no changes to
1484         production code.
1485
1486         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1487         (PortTest.make_port):
1488         (PortTest.test_find_no_paths_specified):
1489         (PortTest.test_find_one_test):
1490         (PortTest.test_find_glob):
1491         (PortTest.test_find_with_skipped_directories):
1492         (PortTest.test_find_with_skipped_directories_2):
1493         (PortTest.test_parse_reftest_list):
1494         (PortTest.test_httpd_returns_error_code):
1495         (PortTest.test_virtual_methods):
1496         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1497         (ChromiumGpuTest.assert_port_works):
1498         (ChromiumGpuTest._assert_baseline_path):
1499         (ChromiumGpuTest.test_graphics_type):
1500         (ChromiumGpuTest.test_default_tests_paths.test_paths):
1501         (ChromiumGpuTest.test_test_files):
1502         (ChromiumGpuTest.test_test_files.test_paths):
1503         (ChromiumGpuTest):
1504         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1505         (ChromiumLinuxPortTest.assert_architecture):
1506         (ChromiumLinuxPortTest.test_check_illegal_port_names):
1507         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1508         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1509         (DriverTest.make_port):
1510         (DriverTest):
1511         (DriverTest.assertVirtual):
1512         (DriverTest._assert_wrapper):
1513         (DriverTest.test_virtual_driver_methods):
1514         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1515         (MockDRTPortTest.make_port):
1516         (MockDRTPortTest.test_port_name_in_constructor):
1517         (MockDRTTest.assertTest):
1518         (MockDRTTest.test_main):
1519         (MockChromiumDRTTest.test_pixeltest__fails):
1520         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1521         (QtPortTest._assert_search_path):
1522         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1523         (TestWebKitPort.__init__):
1524         (WebKitPortUnitTests.test_default_options):
1525         (test_runtime_feature_list):
1526         (test_test_expectations):
1527
1528 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1529
1530         Style skipped tests in the flakiness dashboard
1531         https://bugs.webkit.org/show_bug.cgi?id=76091
1532
1533         Reviewed by Tony Chang.
1534
1535         * TestResultServer/static-dashboards/dashboard_base.js:
1536         Removed "FLAKY" from this list since we don't ever mark individual runs
1537         as flaky. Also deleted an outdated line.
1538         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1539
1540 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1541
1542         Remove gtest normalization code from the test results server
1543         https://bugs.webkit.org/show_bug.cgi?id=76089
1544
1545         Reviewed by Tony Chang.
1546
1547         The normalization now happens on the gtest side.
1548
1549         * TestResultServer/model/jsonresults.py:
1550         (JsonResults.merge):
1551         * TestResultServer/model/jsonresults_unittest.py:
1552         (JsonResultsTest.test_gtest):
1553
1554 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1555
1556         Be more aggressive about deleting unnecessary results from the test-results-server json files
1557         https://bugs.webkit.org/show_bug.cgi?id=76086
1558
1559         Reviewed by Tony Chang.
1560
1561         Remove any tests that only contain skip/pass/nodata values whose runtime
1562         is less than 5 seconds.
1563
1564         * TestResultServer/model/jsonresults.py:
1565         (JsonResults._normalize_results_json):
1566         * TestResultServer/model/jsonresults_unittest.py:
1567         (JsonResultsTest.test_merge_remove_test):
1568         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
1569
1570 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1571
1572         last-green-revision should give us per-bot information
1573         https://bugs.webkit.org/show_bug.cgi?id=76011
1574
1575         Reviewed by Adam Barth.
1576
1577         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
1578         we report the latest green run on each bot from the last 100 runs.
1579
1580         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1581         (BuildBot._fetch_builder_page):
1582         (BuildBot):
1583         (BuildBot._green_revision_for_builder):
1584         (BuildBot.last_green_revision):
1585         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1586         (test_green_revision_for_builder):
1587         (test_last_green_revision):
1588         * Scripts/webkitpy/tool/bot/irc_command.py:
1589         (LastGreenRevision.execute):
1590         * Scripts/webkitpy/tool/commands/queries.py:
1591         (LastGreenRevision.execute):
1592
1593 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1594
1595         webkitpy: clean up version detection in webkitpy.layout_tests.port
1596         https://bugs.webkit.org/show_bug.cgi?id=76016
1597
1598         Reviewed by Adam Barth.
1599
1600         This change updates the code in webkitpy.layout_tests.port to
1601         use the new os_name and os_version fields on host.platform. This
1602         gets layout_tests.port out of the version parsing business. Most
1603         of the diffs are just cleaning up test code to accomodate the
1604         changes.
1605
1606         * Scripts/webkitpy/common/system/executive_mock.py:
1607         (MockExecutive):
1608         (MockExecutive.ignore_error):
1609         (MockExecutive2):
1610         (MockExecutive2.ignore_error):
1611         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1612         (MockPlatformInfo.is_mac):
1613         (MockPlatformInfo.is_linux):
1614         (MockPlatformInfo.is_win):
1615         * Scripts/webkitpy/common/system/systemhost_mock.py:
1616         (MockSystemHost.__init__):
1617         * Scripts/webkitpy/layout_tests/port/apple.py:
1618         (ApplePort.__init__):
1619         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1620         (ChromiumMacPort.__init__):
1621         (ChromiumMacPort.check_wdiff):
1622         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1623         (ChromiumMacPortTest):
1624         (ChromiumMacPortTest.assert_name):
1625         (ChromiumMacPortTest.test_versions):
1626         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1627         (ChromiumPortTest.test_all_test_configurations):
1628         (ChromiumPortTest.TestMacPort.__init__):
1629         (ChromiumPortTest.TestLinuxPort.__init__):
1630         (ChromiumPortTest.TestWinPort.__init__):
1631         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1632         (ChromiumWinPort.__init__):
1633         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1634         (ChromiumWinTest):
1635         (ChromiumWinTest.assert_name):
1636         (ChromiumWinTest.test_versions):
1637         (ChromiumWinTest.test_baseline_path):
1638         (ChromiumWinTest.test_build_path):
1639         * Scripts/webkitpy/layout_tests/port/factory.py:
1640         (PortFactory._port_name_from_arguments_and_options):
1641         (PortFactory.get):
1642         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1643         (FactoryTest):
1644         (FactoryTest.setUp):
1645         (FactoryTest.assert_port):
1646         (FactoryTest.test_mac):
1647         (FactoryTest.test_win):
1648         (FactoryTest.test_google_chrome):
1649         (FactoryTest.test_gtk):
1650         (FactoryTest.test_qt):
1651         (FactoryTest.test_chromium_gpu):
1652         (FactoryTest.test_chromium_gpu_linux):
1653         (FactoryTest.test_chromium_gpu_mac):
1654         (FactoryTest.test_chromium_gpu_win):
1655         (FactoryTest.test_chromium_mac):
1656         (FactoryTest.test_chromium_linux):
1657         (FactoryTest.test_chromium_win):
1658         (FactoryTest.test_unknown_specified):
1659         (FactoryTest.test_unknown_default):
1660         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1661         (TestGoogleChromePort):
1662         (TestGoogleChromePort._verify_baseline_path):
1663         (TestGoogleChromePort._verify_expectations_overrides):
1664         (TestGoogleChromePort.test_get_google_chrome_port):
1665         * Scripts/webkitpy/layout_tests/port/mac.py:
1666         (MacPort):
1667         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1668         (MacTest):
1669         (assert_name):
1670         (test_tests_for_other_platforms):
1671         (test_version):
1672         (test_versions):
1673         (test_is_version_methods):
1674         (test_setup_environ_for_server):
1675         (_assert_search_path):
1676         (test_show_results_html_file):
1677         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1678         (PortTestCase):
1679         (PortTestCase.make_port):
1680         * Scripts/webkitpy/layout_tests/port/win.py:
1681         (WinPort):
1682         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1683         (WinPortTest):
1684         (WinPortTest.test_show_results_html_file):
1685         (WinPortTest._assert_search_path):
1686         (WinPortTest._assert_version):
1687
1688 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
1689
1690         [Qt][WK2] Remove workaround introduced into bug 75470
1691         https://bugs.webkit.org/show_bug.cgi?id=75889
1692
1693         Reviewed by Tor Arne Vestbø.
1694
1695         * MiniBrowser/qt/qml/BrowserWindow.qml:
1696
1697 2012-01-10  Dmitry Lomov  <dslomov@google.com>
1698
1699         [Chromium] Remove obsolete references to WebWorker class.
1700         https://bugs.webkit.org/show_bug.cgi?id=76020
1701
1702         Reviewed by David Levin.
1703
1704         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
1705         * DumpRenderTree/chromium/WebViewHost.cpp:
1706         * DumpRenderTree/chromium/WebViewHost.h:
1707
1708 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
1709
1710         [Qt] Some css3 filter tests are failing after r104698
1711         https://bugs.webkit.org/show_bug.cgi?id=76055
1712
1713         Reviewed by Simon Hausmann.
1714
1715         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1716         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
1717
1718 2012-01-11  Tony Chang  <tony@chromium.org>
1719
1720         Don't remove 0 byte files when running build-webkit --chromium
1721         https://bugs.webkit.org/show_bug.cgi?id=75997
1722
1723         Reviewed by Csaba Osztrogonác.
1724
1725         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
1726
1727         * Scripts/webkitdirs.pm:
1728         (determineIsQt):
1729
1730 2012-01-10  David Kilzer  <ddkilzer@apple.com>
1731
1732         Add TestWebKitAPI tests for KURL
1733         <http://webkit.org/b/75774>
1734
1735         Reviewed by Adam Barth.
1736
1737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
1738         WebCore folder and KURL.cpp source file to the project.
1739         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
1740         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
1741         during setup since this test doesn't go through WebKit or
1742         WebKit2.
1743         (TestWebKitAPI::TEST_F): Add two basic tests.
1744
1745 2012-01-10  David Kilzer  <ddkilzer@apple.com>
1746
1747         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
1748
1749         Reviewed by Adam Barth.
1750
1751         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
1752
1753         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1754         WTFStringUtilities.h to the project.
1755         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
1756         WTFStringUtilities.h.
1757         * TestWebKitAPI/WTFStringUtilities.h: Added.
1758         (WTF::operator<<):
1759
1760 2012-01-10  Vincent Scheib  <scheib@chromium.org>
1761
1762         Clarify run-webkit-tests options reset-results and new-baseline
1763         https://bugs.webkit.org/show_bug.cgi?id=75993
1764
1765         Reviewed by Dirk Pranke.
1766
1767         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1768         (parse_args):
1769
1770 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
1771
1772         Disabled mock scrollbars should draw differently
1773         https://bugs.webkit.org/show_bug.cgi?id=75995
1774
1775         Reviewed by James Robinson.
1776
1777         When the scrollbar is disabled, paint the entire track of
1778         mock scrollbars with a lighter gray, and hide the thumb.
1779
1780         * DumpRenderTree/mac/DumpRenderTree.mm:
1781         (-[DRTMockScroller drawKnob]):
1782         (-[DRTMockScroller drawRect:]):
1783
1784 2012-01-10  James Robinson  <jamesr@chromium.org>
1785
1786         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
1787         https://bugs.webkit.org/show_bug.cgi?id=75988
1788
1789         Reviewed by Adam Barth.
1790
1791         * Scripts/webkitpy/common/config/ports.py:
1792         (WebKitPort.run_webkit_unit_tests_command):
1793         (WebKitPort):
1794         (ChromiumPort.run_webkit_unit_tests_command):
1795         (ChromiumPort):
1796         * Scripts/webkitpy/common/config/ports_mock.py:
1797         (MockPort.run_webkit_unit_tests_command):
1798         * Scripts/webkitpy/tool/commands/download_unittest.py:
1799         (DownloadCommandsTest.test_build_and_test):
1800         (test_land):
1801         (test_land_red_builders):
1802         * Scripts/webkitpy/tool/steps/runtests.py:
1803         (RunTests.run):
1804         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1805
1806 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
1807
1808         webkitpy: add os_name, os_version to platforminfo
1809         https://bugs.webkit.org/show_bug.cgi?id=75931
1810
1811         Reviewed by Eric Siedel.
1812
1813         As a first step in cleaning up the version parsing logic in
1814         webkitpy.layout_tests.port, this adds common routines for
1815         getting the os_name and os_version fields to the PlatformInfo
1816         class. Nothing uses them yet but I've added FIXME's to some of
1817         the code that needs to be deleted in the port files.
1818
1819         * Scripts/webkitpy/common/system/platforminfo.py:
1820         (PlatformInfo.__init__):
1821         (PlatformInfo):
1822         (PlatformInfo._determine_os_name):
1823         (PlatformInfo._determine_mac_version):
1824         (PlatformInfo._determine_linux_version):
1825         (PlatformInfo._determine_win_version):
1826         (PlatformInfo.display_name):
1827         (PlatformInfo.total_bytes_memory):
1828         (PlatformInfo._compute_bytes_from_vm_stat_output):
1829         (PlatformInfo.free_bytes_memory):
1830         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
1831         (TestPlatformInfo):
1832         (TestPlatformInfo.make_info):
1833         (TestPlatformInfo.make_info.mock_run_command):
1834         (TestPlatformInfo.setUp):
1835         (TestPlatformInfo.tearDown):
1836         (TestPlatformInfo.test_basic):
1837         (TestPlatformInfo.integration_test_basic):
1838         (TestPlatformInfo.test_display_name_mac):
1839         (TestPlatformInfo.test_display_name_win32):
1840         (TestPlatformInfo.test_memory_mac):
1841         (TestPlatformInfo.test_memory_win32):
1842         (TestPlatformInfo.test_determine_os_name):
1843         (TestPlatformInfo.test_determine_mac_version):
1844         (TestPlatformInfo.test_determine_linux_version):
1845         (TestPlatformInfo.test_determine_win_version_from_tuple):
1846         (TestPlatformInfo.test_determine_win_version_from_cmd):
1847         * Scripts/webkitpy/layout_tests/port/apple.py:
1848         (ApplePort.__init__):
1849         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1850         (ChromiumMacPort.__init__):
1851         * Scripts/webkitpy/layout_tests/port/mac.py:
1852         (MacPort):
1853         * Scripts/webkitpy/layout_tests/port/win.py:
1854         (WinPort):
1855
1856 2012-01-10  Adam Roben  <aroben@apple.com>
1857
1858         Make it possible to type data: URLs into MiniBrowser on Windows
1859
1860         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
1861         MiniBrowser on Windows
1862
1863         Reviewed by Darin Adler.
1864
1865         * MiniBrowser/win/BrowserWindow.cpp:
1866         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
1867         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
1868         does, we assume it already has a scheme and don't modify it.
1869
1870 2012-01-10  Adam Roben  <aroben@apple.com>
1871
1872         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
1873
1874         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
1875         MiniBrowser on Windows
1876
1877         Reviewed by Darin Adler.
1878
1879         * MiniBrowser/win/BrowserView.cpp:
1880         (BrowserView::goToURL): Pass the typed string through
1881         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
1882
1883 2012-01-10  Ben Wells  <benwells@chromium.org>
1884
1885         Adding myself (benwells) to committers.py
1886         https://bugs.webkit.org/show_bug.cgi?id=75971
1887
1888         Reviewed by Ojan Vafai.
1889
1890         * Scripts/webkitpy/common/config/committers.py:
1891
1892 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
1893
1894         AX: support helpText() in DumpRenderTree
1895         https://bugs.webkit.org/show_bug.cgi?id=40193
1896
1897         Reviewed by Chris Fleizach.
1898
1899         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1900         (AccessibilityUIElement::helpText): Implemented.
1901
1902 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1903
1904         Unreviewed, rolling out r104572.
1905         http://trac.webkit.org/changeset/104572
1906         https://bugs.webkit.org/show_bug.cgi?id=75967
1907
1908         It broke zillion tests (Requested by Ossy on #webkit).
1909
1910         * DumpRenderTree/qt/EventSenderQt.cpp:
1911         (EventSender::EventSender):
1912         (EventSender::sendOrQueueEvent):
1913         (EventSender::replaySavedEvents):
1914         (EventSender::eventFilter):
1915         * DumpRenderTree/qt/EventSenderQt.h:
1916
1917 2012-01-10  Hugo Parente Lima  <hugo.lima@openbossa.org>
1918
1919         [Qt] fast/events/dont-loose-last-event test fails on WK1
1920         https://bugs.webkit.org/show_bug.cgi?id=73894
1921
1922         Reviewed by Simon Hausmann.
1923
1924         Empty the entire event queue when requested besides using
1925         sendEvent instead of postEvent to make sure all events were
1926         delivered.
1927         This commit also removes not working DRT code to handle drag and drop,
1928         for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
1929
1930         * DumpRenderTree/qt/EventSenderQt.cpp:
1931         (EventSender::EventSender):
1932         (EventSender::sendOrQueueEvent):
1933         (EventSender::replaySavedEvents):
1934         * DumpRenderTree/qt/EventSenderQt.h:
1935
1936 2012-01-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
1937
1938         [Qt] Enable CSS_FILTERS in Qt build
1939         https://bugs.webkit.org/show_bug.cgi?id=75777
1940
1941         Add the CSS_FILTERS feature flag to Qt.
1942
1943         Reviewed by Kenneth Rohde Christiansen.
1944
1945         * qmake/mkspecs/features/features.prf:
1946
1947 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
1948
1949         [Qt] Unreviewed -Werror build fix.
1950
1951         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1952         (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
1953         declaration.
1954
1955 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
1956
1957         [Qt] Remove dependency to uitools
1958         https://bugs.webkit.org/show_bug.cgi?id=75952
1959
1960         Reviewed by Tor Arne Vestbø.
1961
1962         QUiLoader is used for creating QLabel/QProgressBar widgets for
1963         a layout test, to verify some widget embedding feature. Unfortunately
1964         in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
1965         depends on qttools. Since we don't really _need_ QUiLoader for our tests,
1966         let's break the circular dependency.
1967
1968         * DumpRenderTree/qt/DumpRenderTree.pro:
1969         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1970         (WebCore::WebPage::createPlugin):
1971         * QtTestBrowser/QtTestBrowser.pro:
1972         * QtTestBrowser/launcherwindow.h:
1973         * QtTestBrowser/webpage.cpp:
1974         (WebPage::createPlugin):
1975         * qmake/mkspecs/features/minimal_qt.prf:
1976         * qmake/mkspecs/features/uitools.prf: Removed.
1977
1978 2012-01-10  Alexander Færøy  <alexander.faeroy@nokia.com>
1979
1980         [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
1981         https://bugs.webkit.org/show_bug.cgi?id=75894
1982
1983         Reviewed by Tor Arne Vestbø.
1984
1985         * MiniBrowser/qt/MiniBrowserApplication.h:
1986         (MiniBrowserApplication::windowOptions):
1987         * MiniBrowser/qt/main.cpp:
1988         (main):
1989
1990 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
1991
1992         [Qt] DRT crashes with Qt 5
1993         https://bugs.webkit.org/show_bug.cgi?id=75951
1994
1995         Reviewed by Ossy.
1996
1997         * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
1998         Qt relies on font-config to define the default font family.
1999
2000 2012-01-10  Csaba Osztrogonác  <ossy@webkit.org>
2001
2002         [Qt] REGRESSION(r100130): Clean build feature is broken.
2003         https://bugs.webkit.org/show_bug.cgi?id=75863
2004
2005         Reviewed by Tor Arne Vestbø.
2006
2007         * Scripts/webkitdirs.pm:
2008         (buildQMakeProject):
2009
2010 2012-01-10  Zeno Albisser  <zeno@webkit.org>
2011
2012         [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
2013         https://bugs.webkit.org/show_bug.cgi?id=75885
2014
2015         In QML events are propagated through parents. But since the
2016         WebView may consume key events, a shortcut might never reach
2017         the top QtQuickItem.
2018         Therefore an application wide event handling function in C++
2019         needs to take care of shortcuts for MiniBrowser.
2020
2021         Reviewed by Kenneth Rohde Christiansen.
2022
2023         * MiniBrowser/qt/BrowserWindow.cpp:
2024         (BrowserWindow::reload):
2025         (BrowserWindow::focusAddressBar):
2026         * MiniBrowser/qt/BrowserWindow.h:
2027         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2028         (MiniBrowserApplication::notify):
2029         * MiniBrowser/qt/qml/BrowserWindow.qml:
2030
2031 2012-01-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2032
2033         Add --efl alias for --platform=efl to run-webkit-test
2034         https://bugs.webkit.org/show_bug.cgi?id=75937
2035
2036         Reviewed by Andreas Kling.
2037         
2038         * Scripts/run-webkit-tests: Add --efl alias.
2039         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
2040         (parse_args):
2041
2042 2012-01-09  Dan Bernstein  <mitz@apple.com>
2043
2044         -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
2045         https://bugs.webkit.org/show_bug.cgi?id=75920
2046
2047         Reviewed by Darin Adler.
2048
2049         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
2050         (TestWebKitAPI::TEST): Added a test for a range in a
2051         -webkit-user-select: none; block.
2052
2053 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2054
2055         webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
2056         https://bugs.webkit.org/show_bug.cgi?id=75884
2057
2058         Reviewed by Ryosuke Niwa.
2059
2060         Fix regression introduced (revealed?) in r104340. Chromium file         
2061         url syntax is different on win32 and the test results weren't           
2062         expecting that.                                                         
2063
2064         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2065         (TestExpectations._report_errors):
2066         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2067         (test_parse_error_nonfatal):
2068         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2069         (MockDRTTest.input_line):
2070         (MockChromiumDRTTest.test_pixeltest__fails):
2071         * Scripts/webkitpy/layout_tests/port/test.py:
2072         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2073         (TestRebaseliner.make_rebaseliner):
2074         (TestRebaseliner.test_one_platform):
2075         (TestRebaseliner.test_all_platforms):
2076         (TestRebaseliner.test_png_file_with_comment):
2077         (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
2078         (TestRebaseliner.test_png_file_with_comment_as_duplicate):
2079         (TestRealMain.test_all_platforms):
2080
2081 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2082
2083         Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
2084
2085         Unreviewed, build fix.
2086
2087         test-webkitpy had a built-in self-test routine to verify that
2088         deleting the .pyc files worked correctly. When I removed the
2089         python24 directory in r104482, I broke the self-test.
2090
2091         I have deleted the self-test for now. Since I am reworking
2092         test-webkitpy I will make sure the new version is adequately
2093         tested.
2094
2095         * Scripts/test-webkitpy:
2096         (configure_logging):
2097         (_clean_pyc_files):
2098         (_clean_packages):
2099         (init):
2100
2101 2012-01-09  Justin Novosad  <junov@chromium.org>
2102
2103         [Chromium] remove all references to the legacy accelerated 2d Canvas
2104         implementation
2105         https://bugs.webkit.org/show_bug.cgi?id=75108
2106
2107         Purging an old settings flag that is no longer referenced
2108
2109         Reviewed by Darin Fisher.
2110
2111         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2112         (main):
2113         * DumpRenderTree/chromium/TestShell.cpp:
2114         (TestShell::TestShell):
2115         (TestShell::resetWebSettings):
2116         * DumpRenderTree/chromium/TestShell.h:
2117         (TestShell::setAccelerated2dCanvasEnabled):
2118         * DumpRenderTree/chromium/WebPreferences.cpp:
2119         (WebPreferences::reset):
2120         (WebPreferences::applyTo):
2121         * DumpRenderTree/chromium/WebPreferences.h:
2122
2123 2012-01-09  Adam Roben  <aroben@apple.com>
2124
2125         Convert Cygwin paths to Windows paths before passing them to DRT
2126
2127         Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
2128         NRWT
2129
2130         I couldn't find a way to test this because I couldn't figure out how to override the
2131         cygpath function as it is used by WebKitDriver.
2132
2133         Reviewed by Dirk Pranke.
2134
2135         * Scripts/webkitpy/layout_tests/port/webkit.py:
2136         (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
2137         Windows-style path before passing it to DRT.
2138
2139 2012-01-06  Dirk Pranke  <dpranke@chromium.org>
2140
2141         webkitpy: revamp version checking
2142         https://bugs.webkit.org/show_bug.cgi?id=75765
2143
2144         Reviewed by Adam Barth.
2145
2146         The version-checking code in webkitpy/python24/versioning seems really
2147         awkward and overdesigned, especially since we don't support python 2.4
2148         any more.
2149
2150         In addition, I am tired of getting warnings about Python 2.6 being "a
2151         newer release than what is supported" :).
2152
2153         I'm taking a page from the depot_tools python code and just creating a
2154         new webkitpy.common.version_check module that will print a message on
2155         stderr and call sys.exit() if we're running an unsupported version.
2156
2157         * Scripts/check-webkit-style:
2158         * Scripts/new-run-webkit-httpd:
2159         * Scripts/new-run-webkit-tests:
2160         * Scripts/rebaseline-chromium-webkit-tests:
2161         * Scripts/test-webkitpy:
2162         (configure_logging):
2163         (init):
2164         * Scripts/webkit-patch:
2165         (main):
2166         * Scripts/webkitpy/common/system/executive.py:
2167         (Executive._child_process_encoding):
2168         (Executive._should_encode_child_process_arguments):
2169         * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
2170         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2171         * Scripts/webkitpy/python24/__init__.py: Removed.
2172         * Scripts/webkitpy/python24/versioning.py: Removed.
2173         * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
2174
2175 2012-01-09  Adam Barth  <abarth@webkit.org>
2176
2177         Remove Chromium Mac CG from the flakiness dashboard
2178         https://bugs.webkit.org/show_bug.cgi?id=75873
2179
2180         Reviewed by Ojan Vafai.
2181
2182         This configuration no longer exists.
2183
2184         * TestResultServer/static-dashboards/builders.js:
2185         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2186         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2187         (testOverrideJustBuildType):
2188         (testPlatformAndBuildType):
2189
2190 2012-01-06  Adam Roben  <aroben@apple.com>
2191
2192         Print an error message when NRWT can't run Apache
2193
2194         Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
2195
2196         Reviewed by Dirk Pranke.
2197
2198         * Scripts/webkitpy/layout_tests/port/base.py:
2199         (Port.check_httpd): Print an error message when Apache returns an error code instead of
2200         failing silently.
2201
2202         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2203         (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
2204         run Apache.
2205         (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
2206         fails.
2207
2208 2012-01-09  Gabor Rapcsanyi  <rgabor@webkit.org>
2209
2210         [Gtk][ARM] Cross compiler buildbot is failing after r103040
2211         https://bugs.webkit.org/show_bug.cgi?id=75846
2212
2213         Reviewed by Philippe Normand.
2214
2215         * Scripts/webkitdirs.pm:
2216         (runAutogenForAutotoolsProjectIfNecessary):
2217
2218 2012-01-09  Alexander Færøy  <ahf@0x90.dk>
2219
2220         [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
2221         https://bugs.webkit.org/show_bug.cgi?id=75807
2222
2223         This patch adds a new icon to navigationbar of the Qt MiniBrowser
2224         which allows you to dynamically toggle whether touch mocking is
2225         enabled or disabled.
2226
2227         Reviewed by Tor Arne Vestbø.
2228
2229         * MiniBrowser/qt/MiniBrowser.qrc:
2230         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2231         (MiniBrowserApplication::notify):
2232         * MiniBrowser/qt/MiniBrowserApplication.h:
2233         (WindowOptions::WindowOptions):
2234         (WindowOptions::touchMockingEnabled):
2235         (WindowOptions::setTouchMockingEnabled):
2236         * MiniBrowser/qt/icons/touch.png: Added.
2237         * MiniBrowser/qt/qml/BrowserWindow.qml:
2238
2239 2012-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2240
2241         Unreviewed. Fix make distcheck issues.
2242
2243         * MiniBrowser/gtk/GNUmakefile.am:
2244
2245 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2246
2247         Unreviewed, rolling out r104421.
2248         http://trac.webkit.org/changeset/104421
2249         https://bugs.webkit.org/show_bug.cgi?id=75816
2250
2251         Need to rebaseline some tests on Linux (Requested by noamr on
2252         #webkit).
2253
2254         * qmake/mkspecs/features/features.prf:
2255
2256 2012-01-08  Adam Barth  <abarth@webkit.org>
2257
2258         Remove support for Chromium Mac CG from garden-o-matic
2259         https://bugs.webkit.org/show_bug.cgi?id=75814
2260
2261         Reviewed by Eric Seidel.
2262
2263         This configuration no longer exists.  This patch is mostly a matter of
2264         updating config.js and removing the examples from the unit tests.
2265
2266         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2267         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2268         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2269         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2270         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2271
2272 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2273
2274         [Qt] Enable CSS_FILTERS in Qt build
2275         https://bugs.webkit.org/show_bug.cgi?id=75777
2276
2277         Add the CSS_FILTERS feature flag to Qt.
2278
2279         Reviewed by Kenneth Rohde Christiansen.
2280
2281         * qmake/mkspecs/features/features.prf:
2282
2283 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2284
2285         Categorize bots by ports instead of core/non-core separation
2286         https://bugs.webkit.org/show_bug.cgi?id=75766
2287
2288         Reviewed by Eric Seidel.
2289
2290         Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
2291         (Chromium still comes before GTK and Qt).
2292
2293         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2294         (loadBuilderConfig):
2295         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2296
2297 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2298
2299         Remove the concept of core builders from webkitpy
2300         https://bugs.webkit.org/show_bug.cgi?id=75809
2301
2302         Reviewed by Ryosuke Niwa.
2303
2304         Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
2305         and remove the relevant code.
2306
2307         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2308         (BuildBot.__init__):
2309         (BuildBot._matches_regexps):
2310         (BuildBot._builder_statuses_with_names_matching_regexps):
2311         (BuildBot.builder_statuses):
2312         (BuildBot.failure_map):
2313         (BuildBot._latest_builds_from_builders):
2314         (BuildBot.last_green_revision):
2315         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2316         (MockBuildBot.builder_statuses):
2317         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2318         (test_status_parsing):
2319         (test_last_green_revision):
2320         (test_last_green_revision.mock_builds_from_builders):
2321
2322 2012-01-08  Adam Barth  <abarth@webkit.org>
2323
2324         Remove Chromium Mac CG concept from webkitpy
2325         https://bugs.webkit.org/show_bug.cgi?id=75810
2326
2327         Reviewed by Ryosuke Niwa.
2328
2329         This configuration no longer exists.  We can remove all the supporting
2330         code from webkitpy.
2331
2332         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2333         (BaselineOptimizerTest.test_move_baselines):
2334         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
2335         (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
2336         (BaselineOptimizerTest.test_common_directory_includes_root):
2337         (BaselineOptimizerTest.test_complex_shadowing):
2338         * Scripts/webkitpy/common/config/build.py:
2339         (_should_file_trigger_build):
2340         * Scripts/webkitpy/common/config/build_unittest.py:
2341         (ShouldBuildTest):
2342         * Scripts/webkitpy/layout_tests/port/builders.py:
2343         * Scripts/webkitpy/layout_tests/port/chromium.py:
2344         (ChromiumPort):
2345         (ChromiumPort._generate_all_test_configurations):
2346         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2347         (_default_tests_paths):
2348         (ChromiumGpuLinuxPort.tests):
2349         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2350         (ChromiumGpuTest.integration_test_chromium_gpu_mac):
2351         (ChromiumGpuTest.assert_port_works):
2352         (ChromiumGpuTest.test_baseline_paths):
2353         (ChromiumGpuTest.test_graphics_type):
2354         (ChromiumGpuTest.test_default_tests_paths):
2355         (ChromiumGpuTest.test_test_files):
2356         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2357         (ChromiumMacPort):
2358         (ChromiumMacPort.__init__):
2359         (ChromiumMacPort.baseline_search_path):
2360         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2361         (ChromiumMacPortTest.test_graphics_type):
2362         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2363         (ChromiumPortTest.test_all_test_configurations):
2364         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2365         * Scripts/webkitpy/layout_tests/port/factory.py:
2366         (PortFactory._port_name_from_arguments_and_options):
2367         (PortFactory.get):
2368         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2369         (FactoryTest.test_chromium_gpu_mac):
2370         (FactoryTest.test_chromium_mac):
2371         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2372         (GetGoogleChromePortTest._verify_expectations_overrides):
2373         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2374         (MockChromiumDRTTest.test_chromium_parse_options):
2375         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2376         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2377         (test_url_fetcher):
2378         (test_zip_factory):
2379         (test_archive):
2380         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2381         (TestRebaseline.test_rebaseline_expectations):
2382
2383 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2384
2385         Categorize bots by ports instead of core/non-core separation
2386         https://bugs.webkit.org/show_bug.cgi?id=75766
2387
2388         Reviewed by Adam Barth.
2389
2390         Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
2391
2392         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2393         (loadBuilderConfig):
2394         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2395
2396 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2397
2398         Unreviewed, rolling out r104403.
2399         http://trac.webkit.org/changeset/104403
2400         https://bugs.webkit.org/show_bug.cgi?id=75803
2401
2402         It broke all tests on Qt5 (Requested by Ossy_weekend on
2403         #webkit).
2404
2405         * qmake/mkspecs/features/features.prf:
2406
2407 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2408
2409         [Qt] Enable CSS_FILTERS in Qt build
2410         https://bugs.webkit.org/show_bug.cgi?id=75777
2411
2412         Add the CSS_FILTERS feature flag to Qt.
2413
2414         Reviewed by Kenneth Rohde Christiansen.
2415
2416         * qmake/mkspecs/features/features.prf:
2417
2418 2012-01-04  Kentaro Hara  <haraken@chromium.org>
2419
2420         Rewrite the CSS parser of prepare-ChangeLog with unittests.
2421         https://bugs.webkit.org/show_bug.cgi?id=75202
2422
2423         Reviewed by David Kilzer.
2424
2425         The current CSS parser can just parse simple CSSes like
2426
2427             foo bar baz {
2428                 property1: value;
2429                 property2: value;
2430             }
2431
2432         , and cannot parse comments nor a CSS in which a selector and {
2433         appears in different lines. This patch rewrites the CSS parser
2434         (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
2435         shown in css_unittests.css.
2436
2437         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
2438
2439         * Scripts/prepare-ChangeLog:
2440         (get_selector_line_ranges_for_css):
2441         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2442         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
2443         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
2444         (element1):
2445         (element2):
2446         (element3):
2447         (element4.p):
2448         (element5.p.q.r.s):
2449         (element6#p):
2450         (element7 element8):
2451         (element9.p element10.q):
2452         (element11#p element12#q):
2453         (element13, element14):
2454         (.p):
2455         (#p):
2456         (.p element15 #q element16.r element17#s):
2457         (element18:target):
2458         (element19):
2459         (element20):
2460         (element21):
2461         (element22):
2462
2463 2012-01-04  Kentaro Hara  <haraken@chromium.org>
2464
2465         The Perl parser of prepare-ChangeLog can parse here-documents
2466         https://bugs.webkit.org/show_bug.cgi?id=73208
2467
2468         Reviewed by David Kilzer.
2469
2470         Currently prepare-ChangeLog cannot recognize here-documents in Perl,
2471         which results in wrong subroutine names in ChangeLogs.
2472         With this patch, prepare-ChangeLog can judge whether the line of "}"
2473         is the end of a subroutine or a line inside a here-document.
2474
2475         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
2476
2477         * Scripts/prepare-ChangeLog:
2478         (get_function_line_ranges_for_perl):
2479         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
2480         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2481         Added test cases for here-documents.
2482         (func7):
2483         (func8):
2484         (func9):
2485         (func10):
2486         (func11):
2487         (func12):
2488         (func13):
2489         (func14):
2490         (func15):
2491         (func16):
2492
2493 2012-01-08  Kentaro Hara  <haraken@chromium.org>
2494
2495         Add unittests for the JavaScript parser of prepare-ChangeLog
2496         https://bugs.webkit.org/show_bug.cgi?id=75201
2497
2498         Reviewed by David Kilzer.
2499
2500         javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
2501         of prepare-ChangeLog.
2502
2503         * Scripts/prepare-ChangeLog:
2504         (get_function_line_ranges_for_javascript): Before this patch, a string found was just
2505         omitted from parsing. Thus,
2506
2507             str = "foo"
2508             function func() {
2509             }
2510
2511         was recognized as equivalent to
2512
2513             str = function func() {
2514             }
2515
2516         This patch replaces a string with a dummy identifier 'string_appeared_here'
2517         to tell the parser that a string appeared there.
2518
2519         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2520         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
2521         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
2522         (func1):
2523         (func2):
2524         (func3):
2525         (func4):
2526         (func5):
2527         (func6):
2528         (func7):
2529         (func8):
2530         (func9):
2531         (func10):
2532         (func11):
2533         (func12):
2534         (funcOverloaded):
2535         (Func1.prototype.get x1):
2536         (Func1.prototype.get x2):
2537         (Func1.prototype.set x1):
2538         (Func1.prototype.set x3):
2539         (Func2.prototype.func13):
2540         (Func2.prototype.func14):
2541         (Func2.prototype.func15):
2542         (func16.func17):
2543         (func16.func18):
2544         (func16.func19):
2545         (func16):
2546
2547 2012-01-08  David Levin  <levin@chromium.org>
2548
2549         [chromium] Add layout test support for autosize code in FrameView.
2550         https://bugs.webkit.org/show_bug.cgi?id=73631
2551
2552         Reviewed by Dmitry Titov.
2553
2554         * DumpRenderTree/chromium/LayoutTestController.cpp:
2555         (LayoutTestController::LayoutTestController): Expose the new autoresize method.
2556         (LayoutTestController::reset): Set the autoresize mode back to false.
2557         (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
2558         * DumpRenderTree/chromium/LayoutTestController.h:
2559         * DumpRenderTree/chromium/WebViewHost.cpp:
2560         (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
2561         * DumpRenderTree/chromium/WebViewHost.h:
2562
2563 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
2564
2565         [WK2][GTK] Each test takes roughly half a second to load
2566         https://bugs.webkit.org/show_bug.cgi?id=70699
2567
2568         Reviewed by Martin Robinson.
2569
2570         Set the XDG_CACHE_HOME environment variable when testing with
2571         WebKitTestRunner. This way the testing is started with a non-existing
2572         application cache. If the cache exists and is not empty, the emptying
2573         and vacuuming that is performed before every test can consume a lot of
2574         time.
2575
2576         This is just a temporary workaround until it becomes possible to set
2577         a desired directory to be used as the application cache location through
2578         WebKitWebContext.
2579
2580         * Scripts/webkitpy/layout_tests/port/gtk.py:
2581         (GtkPort.setup_environ_for_server):
2582
2583 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
2584
2585         [GTK] Enable requestAnimationFrame in build-webkit
2586         https://bugs.webkit.org/show_bug.cgi?id=75773
2587
2588         Reviewed by Martin Robinson.
2589
2590         Enable requestAnimationFrame for the Gtk port.
2591
2592         * Scripts/build-webkit:
2593
2594 2012-01-06  Jarred Nicholls  <jarred@sencha.com>
2595
2596         Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
2597
2598         * Scripts/webkitdirs.pm:
2599         (buildChromium):
2600         Missing parentheses.
2601
2602 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2603
2604         Fix DRT build on case-sensitive file systems.
2605
2606         Fix case of include of WebDynamicScrollBarsView.h
2607         
2608         * DumpRenderTree/mac/DumpRenderTree.mm:
2609
2610 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2611
2612         Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
2613         https://bugs.webkit.org/show_bug.cgi?id=75662
2614
2615         Reviewed by Dan Bernstein.
2616         
2617         The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
2618         of color profile issues. Fix by keeping everything in device RGB and ensuring that the
2619         test window uses the main display's color space, so that the pixel values in the bitmap
2620         that gets checksummed are identical to the CSS colors.
2621         
2622         Removed the code that switches the display profile in DRT, since that is no longer required.
2623
2624         * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
2625         * DumpRenderTree/mac/DumpRenderTree.mm:
2626         (crashHandler): Remove code that switches display profiles.
2627         (prepareConsistentTestingEnvironment): Ditto.
2628         (dumpRenderTree): Ditto.
2629         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
2630         (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
2631         (createBitmapContextFromWebView): Add comment about the colorspace handling.
2632         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2633         (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
2634         (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
2635         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2636         (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
2637         (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
2638
2639 2012-01-06  David Kilzer  <ddkilzer@apple.com>
2640
2641         run-api-tests: specify individual suites and tests on the command-line
2642
2643         Reviewed by Adam Roben.
2644
2645         Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
2646
2647         The run-api-tests script will now accept a list of arguments on
2648         the command-line that are used as prefix filters.  To run all
2649         tests in a suite that starts with "WTF" (WTF and WTF_Vector)
2650         use:
2651
2652             $ run-api-tests WTF
2653
2654         To run only the tests in the "WTF" suite, not the "WTF_Vector"
2655         suite, use:
2656
2657             $ run-api-tests WTF.
2658
2659         * Scripts/run-api-tests: Filter tests if any prefix arguments
2660         are passed on the command-line.
2661
2662 2012-01-06  David Kilzer  <ddkilzer@apple.com>
2663
2664         run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
2665
2666         Reviewed by Adam Roben.
2667
2668         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
2669
2670         * Scripts/run-api-tests:
2671         (dumpTestsBySuite): Update to accept array of tests instead of
2672         hash data structure.
2673         (runTestsBySuite): Ditto.
2674         (listAllTests): Rename from populateTests().  Update to return
2675         an array of tests instad of the hash data structure.
2676
2677 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
2678
2679         webkitpy: clean up test/uri conversion routines
2680         https://bugs.webkit.org/show_bug.cgi?id=75648
2681
2682         Reviewed by Eric Seidel.
2683
2684         This change moves test_to_uri and uri_to_test from the Port
2685         class to the Driver class (the routines were only being
2686         called by the drivers), and removes a bunch of stale and/or
2687         busted logic.
2688
2689         * Scripts/webkitpy/layout_tests/port/base.py:
2690         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2691         * Scripts/webkitpy/layout_tests/port/chromium.py:
2692         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2693         * Scripts/webkitpy/layout_tests/port/driver.py:
2694         (is_http_test):
2695         (test_to_uri):
2696         (uri_to_test):
2697         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2698         (run_one_test):
2699         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2700         (MockDRTTest.input_line):
2701         (input_line):
2702         (expected_output):
2703         * Scripts/webkitpy/layout_tests/port/test.py:
2704         * Scripts/webkitpy/layout_tests/port/webkit.py:
2705         (_command_from_driver_input):
2706
2707 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2708
2709         Mitigate scrollbar differences when running pixel tests
2710         https://bugs.webkit.org/show_bug.cgi?id=67217
2711
2712         Reviewed by Dan Bernstein.
2713         
2714         Add an NSScroller subclass that draws mock scrollbars identically
2715         to the WebCore mock scrollbar theme, and register it with the
2716         WebDynamicScrollbarsView.
2717
2718         * DumpRenderTree/mac/DumpRenderTree.mm:
2719         (-[DRTMockScroller rectForPart:]):
2720         (-[DRTMockScroller drawKnob]):
2721         (-[DRTMockScroller drawRect:]):
2722         (registerMockScrollbars):
2723         (prepareConsistentTestingEnvironment):
2724
2725 2012-01-05  Jon Lee  <jonlee@apple.com>
2726
2727         Update DRT on Mac to draw resize handles on text areas.
2728
2729         Reviewed by John Sullivan.
2730
2731         Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
2732         between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
2733
2734         * DumpRenderTree/mac/DumpRenderTree.mm:
2735         (resetDefaultsToConsistentValues):
2736
2737 2012-01-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2738
2739         [Qt] Move listing of include paths and libs to pri files in sources
2740
2741         Includepaths are sometimes modified by non-Qt contributors so keeping
2742         them in files inside Sources makes it more likely that they are updated
2743         along with project files for the other ports.
2744
2745         Using pri files instead of prf files for this also has the benefit that
2746         the include() from the main target file can be parsed and followed by
2747         Qt Creator -- something that does not work with load().
2748
2749         Dependency from a target to a library through the WEBKIT variable are
2750         handled through forwarding-files in Tools/qmake/mkspecs/modules, which
2751         set the source root of the module and include the right pri file.
2752
2753         Ideally we'd use the variant of include() that takes an optional
2754         namespace to read the variables into, or the fromfile() function,
2755         but both of these add an overhead of about 40% on the total qmake
2756         runtime, due to making a deep copy of all the variables in the
2757         project or re-reading all the prf files from scratch.
2758
2759         Reviewed by Simon Hausmann.
2760         Reviewed by Ossy.
2761
2762         * qmake/mkspecs/features/default_post.prf:
2763         * qmake/mkspecs/modules/javascriptcore.prf: Added.
2764         * qmake/mkspecs/modules/webcore.prf: Added.
2765         * qmake/mkspecs/modules/webkit2.prf: Added.
2766         * qmake/mkspecs/modules/wtf.prf: Added.
2767
2768 2012-01-06  JungJik Lee  <jungjik.lee@samsung.com>
2769
2770         [EFL] Add pre-render handling code in EWebLauncher.
2771         https://bugs.webkit.org/show_bug.cgi?id=73430
2772
2773         Reviewed by Zoltan Herczeg.
2774
2775         Add pre-render handling code by pressing Insert key.
2776
2777         * EWebLauncher/main.c:
2778         (on_key_down):
2779
2780 2012-01-06  Csaba Osztrogonác  <ossy@webkit.org>
2781
2782         NRWT should use test_expectation.txt on wk2 platforms
2783         https://bugs.webkit.org/show_bug.cgi?id=75417
2784
2785         Reviewed by Dirk Pranke.
2786
2787         * Scripts/webkitpy/layout_tests/port/webkit.py:
2788         (path_to_test_expectations_file):
2789         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2790         (test_path_to_test_expectations_file):
2791
2792 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
2793
2794         Don't hardcode expected file URIs in as they depend on the platform
2795         https://bugs.webkit.org/show_bug.cgi?id=75666
2796
2797         Reviewed by Dirk Pranke.
2798
2799         * Scripts/webkitpy/layout_tests/port/win.py:
2800         (WinPort.show_results_html_file):
2801         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2802         (MainTest.test_unexpected_failures):
2803         (MainTest.test_results_directory_default):
2804         (MainTest.test_results_directory_relative):
2805
2806 2012-01-05  Anders Carlsson  <andersca@apple.com>
2807
2808         Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
2809         https://bugs.webkit.org/show_bug.cgi?id=75667
2810         <rdar://problem/10389454>
2811
2812         Reviewed by Kevin Decker.
2813
2814         Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
2815
2816         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2817         (PluginTest::executeScript):
2818         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2819         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
2820         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
2821         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
2822         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
2823
2824 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
2825
2826         webkitpy: clean up port factory methods
2827         https://bugs.webkit.org/show_bug.cgi?id=75590
2828
2829         Reviewed by Eric Seidel.
2830
2831         This change consolidates much of the "factory method" logic
2832         of determining which port objects to create for a given set
2833         of configurations by merging the separate factory methods in
2834         chromium_gpu and google_chrome into PortFactory so that at least
2835         all of the logic is in one place.
2836
2837         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2838         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2839         * Scripts/webkitpy/layout_tests/port/factory.py:
2840         (_port_name_from_arguments_and_options):
2841         (get):
2842         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2843         (test_google_chrome):
2844         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2845         (GoogleChromeLinux32Port):
2846         (GoogleChromeLinux32Port.baseline_search_path):
2847         (test_expectations_overrides):
2848         (architecture):
2849         (GoogleChromeLinux64Port):
2850         (GoogleChromeLinux64Port.baseline_search_path):
2851         (GoogleChromeMacPort):
2852         (GoogleChromeMacPort.baseline_search_path):
2853         (GoogleChromeWinPort):
2854         (GoogleChromeWinPort.baseline_search_path):
2855         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2856         (_verify_baseline_path):
2857
2858 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
2859
2860         Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
2861         https://bugs.webkit.org/show_bug.cgi?id=75617
2862
2863         Reviewed by Dirk Pranke.
2864
2865         * Scripts/webkitpy/common/system/filesystem.py:
2866         (FileSystem.exists):
2867         * Scripts/webkitpy/common/system/filesystem_mock.py:
2868         (MockFileSystem.exists):
2869         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2870         (GenericFileSystemTests.teardown_generic_test_dir):
2871         * Scripts/webkitpy/layout_tests/port/base.py:
2872         (Port.to.show_results_html_file):
2873         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2874         (MainTest.test_results_directory_absolute):
2875
2876 2012-01-05  Adam Roben  <aroben@apple.com>
2877
2878         Remove some unnecessary code from old-run-webkit-tests
2879
2880         Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
2881         WebKitTestRunner.
2882
2883         Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
2884         Windows
2885
2886         Reviewed by Eric Seidel.
2887
2888         * Scripts/old-run-webkit-tests:
2889         (top level):
2890         (openDumpTool):
2891         Removed calls to setPathForRunningWebKitApp.
2892
2893 2012-01-05  Adam Roben  <aroben@apple.com>
2894
2895         Teach NRWT to use run-safari to open results.html on Apple's Windows port
2896
2897         NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
2898         better, since we always want to open results.html using the user's build of WebKit, not
2899         whatever their default browser is.
2900
2901         Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
2902         for Apple's Windows port
2903
2904         Reviewed by Eric Seidel.
2905
2906         * Scripts/webkitpy/layout_tests/port/win.py:
2907         (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
2908         an obsolete comment.
2909
2910         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2911         (WinPortTest.test_show_results_html_file): Updated expected results.
2912
2913 2012-01-05  Adam Roben  <aroben@apple.com>
2914
2915         Prepend Safari.exe's path to the command-line passed to CreateProcess
2916
2917         Safari expects the first argument in the command-line to be the path to Safari.exe itself.
2918         This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
2919         thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
2920         was not including the path to Safari.exe in the command-line, so Safari was ignoring the
2921         first argument that WebKitLauncherWin was trying to pass to it.
2922
2923         Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
2924
2925         Reviewed by Steve Falkenburg.
2926
2927         * WebKitLauncherWin/WebKitLauncherWin.cpp:
2928         (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
2929         path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
2930
2931 2012-01-05  Adam Roben  <aroben@apple.com>
2932
2933         Stop using explicit memory management in WebKitLauncherWin
2934
2935         We now use stack-allocated STL objects instead.
2936
2937         Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
2938         Safari
2939
2940         Reviewed by Steve Falkenburg.
2941
2942         * WebKitLauncherWin/WebKitLauncherWin.cpp:
2943         (getStringValue):
2944         (applePathFromRegistry):
2945         (safariInstallDir):
2946         (safariBrowserExe):
2947         (_tWinMain):
2948         Changed to use stack-allocated STL objects instead of malloc/free.
2949
2950 2012-01-05  Adam Roben  <aroben@apple.com>
2951
2952         Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
2953
2954         This allows us to add the Safari and Apple Application Support directories to PATH before
2955         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
2956
2957         Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
2958         Windows port of DumpRenderTree/WebKitTestRunner
2959
2960         Reviewed by Steve Falkenburg.
2961
2962         * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
2963         ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
2964
2965         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2966         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2967         Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
2968
2969         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
2970         Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
2971         the stub launcher.
2972
2973         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
2974         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
2975         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
2976         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
2977         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
2978         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
2979         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
2980
2981         * WebKitTestRunner/win/main.cpp:
2982         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
2983
2984 2012-01-05  Adam Roben  <aroben@apple.com>
2985
2986         Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
2987
2988         This allows us to add the Safari and Apple Application Support directories to PATH before
2989         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
2990
2991         Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
2992         Windows port of DumpRenderTree/WebKitTestRunner
2993
2994         Reviewed by Steve Falkenburg.
2995
2996         * DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,
2997         which I forgot to add to this .sln when that project was created.
2998
2999         * DumpRenderTree/win/DumpRenderTree.cpp:
3000         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
3001
3002         * DumpRenderTree/win/DumpRenderTree.vcproj:
3003         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3004         Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.
3005
3006         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
3007         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
3008         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
3009         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
3010         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
3011         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
3012         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
3013         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
3014
3015         * win/DLLLauncher/DLLLauncherMain.cpp:
3016         (modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
3017         Safari's directory to PATH so that SafariTheme.dll can be found.
3018
3019         (main):
3020         (wWinMain):
3021         Changed to use the new modifyPath function.
3022
3023 2012-01-05  Alexander Færøy  <alexander.faeroy@nokia.com>
3024
3025         [Qt] Never enable FontConfig on Mac OS X
3026         https://bugs.webkit.org/show_bug.cgi?id=75616
3027
3028         Reviewed by Tor Arne Vestbø.
3029
3030         * qmake/mkspecs/features/features.prf:
3031
3032 2012-01-05  Alpha Lam  <hclam@chromium.org>
3033
3034         Unreviewed, rolling out r104159.
3035         http://trac.webkit.org/changeset/104159
3036         https://bugs.webkit.org/show_bug.cgi?id=75590
3037
3038         Chromium port GPU tests cannot be executed.
3039
3040         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3041         (get):
3042         (_default_tests_paths):
3043         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3044         (ChromiumGpuTest.assert_port_works):
3045         * Scripts/webkitpy/layout_tests/port/factory.py:
3046         (PortFactory._port_name_from_arguments_and_options):
3047         (PortFactory):
3048         (PortFactory._get_kwargs):
3049         (PortFactory.get):
3050         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3051         (FactoryTest.test_google_chrome.names):
3052         (FactoryTest.test_google_chrome):
3053         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3054         (GetGoogleChromePort):
3055         (GetGoogleChromePort.GoogleChromeLinux32Port):
3056         (GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
3057         (GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
3058         (GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
3059         (GetGoogleChromePort.GoogleChromeLinux64Port):
3060         (GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
3061         (GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
3062         (GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
3063         (GetGoogleChromePort.GoogleChromeMacPort):
3064         (GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
3065         (GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
3066         (GetGoogleChromePort.GoogleChromeWinPort):
3067         (GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
3068         (GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):
3069         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3070         (GetGoogleChromePortTest._verify_baseline_path):
3071         (GetGoogleChromePortTest._verify_expectations_overrides):
3072
3073 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3074
3075         webkitpy: clean up port factory methods
3076         https://bugs.webkit.org/show_bug.cgi?id=75590
3077
3078         Reviewed by Eric Seidel.
3079
3080         This change consolidates much of the "factory method" logic
3081         of determining which port objects to create for a given set
3082         of configurations by merging the separate factory methods in
3083         chromium_gpu and google_chrome into PortFactory so that at least
3084         all of the logic is in one place.
3085
3086         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3087         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3088         * Scripts/webkitpy/layout_tests/port/factory.py:
3089         (_port_name_from_arguments_and_options):
3090         (get):
3091         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3092         (test_google_chrome):
3093         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3094         (GoogleChromeLinux32Port):
3095         (GoogleChromeLinux32Port.baseline_search_path):
3096         (test_expectations_overrides):
3097         (architecture):
3098         (GoogleChromeLinux64Port):
3099         (GoogleChromeLinux64Port.baseline_search_path):
3100         (GoogleChromeMacPort):
3101         (GoogleChromeMacPort.baseline_search_path):
3102         (GoogleChromeWinPort):
3103         (GoogleChromeWinPort.baseline_search_path):
3104         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3105         (_verify_baseline_path):
3106
3107 2012-01-04  Adam Roben  <aroben@apple.com>
3108
3109         Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code
3110
3111         This allows us to add the Apple Application Support directory to PATH before trying to load
3112         WebKit so that CoreGraphics.dll and friends can be found.
3113
3114         Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
3115
3116         Reviewed by Anders Carlsson.
3117
3118         * DumpRenderTree/win/ImageDiff.vcproj:
3119         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3120         Changed to build ImageDiff.dll instead of ImageDiff.exe.
3121
3122         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from
3123         Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.
3124
3125         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
3126         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
3127         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
3128         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
3129         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
3130         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
3131         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
3132
3133         * DumpRenderTree/win/ImageDiffWin.cpp: Added.
3134         (dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
3135         to main.
3136
3137         * win/DLLLauncher/DLLLauncherMain.cpp:
3138         (main):
3139         (wWinMain):
3140         Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
3141         stub launcher acts as a console program and calls a console version of
3142         dllLauncherEntryPoint.
3143
3144 2012-01-04  Adam Roben  <aroben@apple.com>
3145
3146         Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code
3147
3148         This allows us to add the Apple Application Support directory to PATH before trying to load
3149         WebKit so that CoreGraphics.dll and friends can be found.
3150
3151         Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
3152         double-clicked
3153
3154         Reviewed by Anders Carlsson.
3155
3156         * MiniBrowser/MiniBrowser.vcproj:
3157         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3158         Changed to build MiniBrowser.dll instead of MiniBrowser.exe.
3159
3160         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
3161         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
3162         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
3163         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
3164         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
3165         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
3166         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
3167
3168         * MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj
3169         but changed to build the stub launcher.
3170
3171         * MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since
3172         it needs to be compiled into the .exe instead of the .dll.
3173         (DllMain): Added. We use this to store the DLL's HINSTANCE.
3174         (dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
3175         DLLLauncherMain code.
3176
3177         * win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser
3178         to here.
3179
3180 2012-01-04  Adam Roben  <aroben@apple.com>
3181
3182         Make WinLauncher's window frame respond to clicks/drags again
3183
3184         Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
3185         bar when Aero is disabled
3186
3187         Reviewed by Brent Fulgham.
3188
3189         * WinLauncher/WinLauncher.cpp:
3190         (WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
3191         Also removed an unnecessary "break" keyword.
3192
3193 2012-01-04  Adam Roben  <aroben@apple.com>
3194
3195         Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code
3196
3197         This allows us to add the Apple Application Support directory to PATH before trying to load
3198         WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
3199         should use this mechanism.
3200
3201         Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
3202         double-clicked
3203
3204         Reviewed by Anders Carlsson.
3205
3206         * WinLauncher/WinLauncher.cpp: Removed InitInstance.
3207         (DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
3208         done by the now-removed InitInstance function.
3209         (dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
3210         calls. Merged code from InitInstance into this function, and change to use the global hInst
3211         variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
3212         function, which corresponds to WinLauncher.exe.
3213
3214         * WinLauncher/WinLauncher.vcproj:
3215         * WinLauncher/WinLauncherCommon.vsprops:
3216         Changed to build WinLauncher.dll instead of WinLauncher.exe.
3217
3218         * WinLauncher/WinLauncherLauncher.rc: Added.
3219         * WinLauncher/WinLauncherLauncherResource.h: Added.
3220         This just references the WinLauncher.ico file to set the application icon (though it looks
3221         like that's a default icon).
3222
3223         * WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj
3224         but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.
3225
3226         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
3227         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
3228         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
3229         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
3230         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
3231         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
3232         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
3233
3234         * win/DLLLauncher/DLLLauncherMain.cpp: Added.
3235         (enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
3236         program if it detects heap corruption.
3237         (getStringValue): Helper function to read a string value from the registry.
3238         (applePathFromRegistry): Helper function to read the InstallDir for a given Apple
3239         application from the registry.
3240         (appleApplicationSupportDirectory): Helper function to return the path to the Apple
3241         Application Support directory.
3242         (copyEnvironmentVariable): Helper function to copy an environment variable's value.
3243         (prependPath): Helper function to prepend a directory to the PATH.
3244         (fatalError): Helper function to display an error to the user.
3245         (wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
3246         dllLauncherEntryPoint function.
3247
3248 2012-01-05  Kentaro Hara  <haraken@chromium.org>
3249
3250         prepare-ChangeLog cannot parse python code that nests classes and defs
3251         https://bugs.webkit.org/show_bug.cgi?id=75524
3252
3253         Reviewed by Ryosuke Niwa.
3254
3255         This patch fixes the python parser of prepare-ChangeLog so that it can parse
3256         python code that nests classes and defs, like this:
3257
3258         class C:
3259             pass
3260             def f():
3261                 pass
3262             pass
3263
3264         Also, this patch fixes the python parser so that it inserts a dummy line
3265         at the end of the file to pop out all popped scopes.
3266
3267         * Scripts/prepare-ChangeLog:
3268         (get_function_line_ranges_for_python):
3269
3270         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
3271         Added test cases that nest classes and defs.
3272         (func7):
3273         (func7.func8):
3274         (func7.func8.func9):
3275         (Class2):
3276         (Class2.Class3):
3277         (Class2.Class3.Class4):
3278         (Class5):
3279         (Class5.func10):
3280         (Class5.func11):
3281         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
3282
3283 2012-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3284
3285         [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
3286         https://bugs.webkit.org/show_bug.cgi?id=75433
3287
3288         Reviewed by Martin Robinson.
3289
3290         * MiniBrowser/gtk/BrowserWindow.c:
3291         (webViewLoadFailed): Reset the progress bar when load fails.
3292         (browserWindowConstructed): Connect to load-failed signal.
3293
3294 2012-01-04  Dan Bernstein  <mitz@apple.com>
3295
3296         Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
3297         start WebProcess under gdb and WebProcess will then run the client executable.
3298
3299         This is the Tools part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach
3300
3301         Reviewed by Anders Carlsson.
3302
3303         * Scripts/webkitdirs.pm:
3304         (shouldTargetWebProcess): Added.
3305         (determineShouldTargetWebProcess): Added. Checks for --target-web-process.
3306         (execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
3307         app using the -client-executable option if targeting the web process.
3308
3309 2012-01-04  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3310
3311         Adding myself to committers list.
3312
3313         Unreviewed.
3314
3315         * Scripts/webkitpy/common/config/committers.py:
3316
3317 2012-01-04  David Kilzer  <ddkilzer@apple.com>
3318
3319         Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests
3320
3321         This reverts commit r103546.
3322
3323         * TestWebKitAPI/TestsController.cpp:
3324         (TestWebKitAPI::TestsController::TestsController):
3325
3326 2012-01-04  James Robinson  <jamesr@chromium.org>
3327
3328         [chromium] Move WebMimeRegistry and dependencies to Source/Platform
3329         https://bugs.webkit.org/show_bug.cgi?id=74583
3330
3331         Reviewed by Darin Fisher.
3332
3333         Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.
3334
3335         * Scripts/webkitpy/style/checkers/cpp.py:
3336         (check_function_definition):
3337
3338 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3339
3340         [Qt] Fix link order of static libraries and unbreak QtWin32
3341
3342         We were keeping the correct static link order between the intermediate
3343         WebKit libraries, but not the internal dependencies for each of those
3344         libraries. The load() will in some instances mess with LIBS, so we need
3345         to ensure that the dependent libraries are added after the library we
3346         are linking against.
3347
3348         Reviewed by Simon Hausmann.
3349
3350         * qmake/mkspecs/features/default_post.prf:
3351
3352 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3353
3354         [Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
3355
3356         The custom qmake variable 'WEBKIT' is used for signaling that a
3357         target depends in some way on other subproject of the WebKit
3358         project. For now this is limited to the set of intermediate
3359         libraries: wtf, javascriptcore, webcore, and webkit2.
3360
3361         This replaces the previous convension of using load(foo) for
3362         just include paths, and CONFIG += foo to also link against foo.
3363
3364         Adding a dependency results in additional include paths being
3365         available, and potentially linking to the library. This is
3366         decided by the build system based on conditions such as what
3367         kind of target is being built and the general build config.
3368
3369         An advantage to his approach is that it simplifies the individual
3370         foo.prf files, for example by allowing us to use INCLUDEPATH +=
3371         and LIBS += as normal instead of prepending.
3372
3373         Reviewed by Simon Hausmann.
3374
3375         * DumpRenderTree/qt/DumpRenderTree.pro:
3376         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3377         * QtTestBrowser/QtTestBrowser.pro:
3378         * WebKitTestRunner/InjectedBundle/Target.pri:
3379         * WebKitTestRunner/Target.pri:
3380         * qmake/README:
3381         * qmake/mkspecs/features/default_post.prf:
3382         * qmake/mkspecs/features/functions.prf:
3383         * qmake/mkspecs/features/javascriptcore.prf:
3384         * qmake/mkspecs/features/qtwebkit.prf:
3385         * qmake/mkspecs/features/webcore.prf:
3386         * qmake/mkspecs/features/webkit2.prf:
3387         * qmake/mkspecs/features/wtf.prf:
3388
3389 2012-01-04  Alexander Færøy  <ahf@0x90.dk>
3390
3391         [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
3392         https://bugs.webkit.org/show_bug.cgi?id=75488
3393
3394         Reviewed by Tor Arne Vestbø.
3395
3396         * MiniBrowser/qt/MiniBrowser.qrc:
3397         * MiniBrowser/qt/qml/BrowserWindow.qml:
3398         * MiniBrowser/qt/qml/Dialog.qml:
3399         * MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
3400         * MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
3401
3402 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3403
3404         [Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit
3405
3406         It wasn't really a problem at runtime since the right QtWebKit was
3407         already loaded as a dependency of the web process, but the ldd output
3408         would still be busted.
3409
3410         Reviewed by Simon Hausmann.
3411
3412         * WebKitTestRunner/InjectedBundle/Target.pri:
3413
3414 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3415
3416         [Qt] Move use of $$qtLibraryTarget() to a single place
3417
3418         Reviewed by Kenneth Rohde Christiansen.
3419
3420         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3421         * WebKitTestRunner/InjectedBundle/Target.pri:
3422         * qmake/mkspecs/features/default_post.prf:
3423         * qmake/mkspecs/features/webcore.prf:
3424
3425 2012-01-04  Mary Wu  <mary.wu@torchmobile.com.cn>
3426
3427         Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
3428         https://bugs.webkit.org/show_bug.cgi?id=75238
3429
3430         Reviewed by Antonio Gomes.
3431
3432         Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that 
3433         it could initiate download directly if it has the download attribute in the link 
3434         and doesn't need to open new blank page for the target="_blank". Enabling this 
3435         feature in the BlackBerry porting also prepares for later blob feature implementation.
3436
3437         * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
3438         for the BlackBerry porting.
3439
3440 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3441
3442         [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
3443         https://bugs.webkit.org/show_bug.cgi?id=75475
3444
3445         Reviewed by Martin Robinson.
3446
3447         The problem is that the property blurb contains <a ping> and tree
3448         view uses gtk_tooltip_set_markup() internally, so we need to
3449         escape the text.
3450
3451         * MiniBrowser/gtk/BrowserSettingsDialog.c:
3452         (browserSettingsDialogConstructed): Escape property blurb before
3453         storing it in the GtkTreeModel.
3454
3455 2012-01-03  Jochen Eisinger  <jochen@chromium.org>
3456
3457         When showing results.html pass a correct URL to webbrowser.open
3458         https://bugs.webkit.org/show_bug.cgi?id=75438
3459
3460         Reviewed by Adam Barth.
3461
3462         * Scripts/webkitpy/common/system/filesystem.py:
3463         (file_path_as_url):
3464         * Scripts/webkitpy/common/system/filesystem_mock.py:
3465         (file_path_as_url):
3466         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3467         (test_file_path_as_url):
3468         * Scripts/webkitpy/layout_tests/port/base.py:
3469         (show_results_html_file):
3470         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3471         (test_show_results_html_file):
3472         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3473         (test_results_directory_relative):
3474
3475 2012-01-03  Ojan Vafai  <ojan@chromium.org>
3476
3477         shrink the header on the flakiness dashboard
3478         https://bugs.webkit.org/show_bug.cgi?id=65153
3479
3480         Reviewed by Adam Roben.
3481
3482         Move some of the "show" links to be to the right of the header
3483         instead of below the header when they content they're showing
3484         is hidden. That way we don't waste vertical space on them.
3485
3486         No new tests. This code is covered by existing tests.
3487
3488         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3489
3490 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3491
3492         Add a tool to analyze change logs
3493         https://bugs.webkit.org/show_bug.cgi?id=72243
3494
3495         Reviewed by Eric Seidel.
3496
3497         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
3498         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
3499         for visualizing json files.
3500
3501         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
3502         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
3503         generates json files, and N is the number of changelogs to parse.
3504
3505         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
3506         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
3507         * Scripts/webkitpy/tool/commands/__init__.py:
3508         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
3509         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
3510         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
3511         * Scripts/webkitpy/tool/steps/options.py:
3512
3513 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3514
3515         Add a tool to analyze change logs
3516         https://bugs.webkit.org/show_bug.cgi?id=72243
3517
3518         Reviewed by Eric Seidel.
3519
3520         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
3521         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
3522         for visualizing json files.
3523
3524         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
3525         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
3526         generates json files, and N is the number of changelogs to parse.
3527
3528         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
3529         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
3530         * Scripts/webkitpy/tool/commands/__init__.py:
3531         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
3532         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
3533         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
3534         * Scripts/webkitpy/tool/steps/options.py:
3535
3536 2012-01-03  Adam Roben  <aroben@apple.com>
3537
3538         Make Port subclasses override the operating_system method rather than setting an attribute
3539
3540         Without this patch, any use of Port.operating_system() within a port's __init__ method would
3541         return the default value ("mac"). This was confusing the version-checking logic inside
3542         ApplePort.__init__ on Windows.
3543
3544         Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
3545         crashes on launch on Windows 7 SP1
3546
3547         Reviewed by Eric Seidel.
3548
3549         * Scripts/webkitpy/layout_tests/port/apple.py:
3550         (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
3551
3552         * Scripts/webkitpy/layout_tests/port/base.py:
3553         (Port.__init__): Removed code that set the self._operating_system attribute. Subclasses
3554         should now override the operating_system method instead.
3555         (Port.operating_system): Changed to always return "mac". Subclasses should override to
3556         return something else.
3557
3558         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3559         (ChromiumLinuxPort.__init__):
3560         (ChromiumLinuxPort.operating_system):
3561         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3562         (ChromiumMacPort.__init__):
3563         (ChromiumMacPort.operating_system):
3564         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3565         (ChromiumWinPort.__init__):
3566         (ChromiumWinPort.operating_system):
3567         * Scripts/webkitpy/layout_tests/port/mac.py:
3568         (MacPort.__init__):
3569         (MacPort.operating_system):
3570         * Scripts/webkitpy/layout_tests/port/win.py:
3571         (WinPort.__init__):
3572         (WinPort.operating_system):
3573         Changed to override the operating_system method rather than setting the _operating_system
3574         attribute, since setting the attribute isn't sufficient for code inside __init__ methods.
3575
3576         * Scripts/webkitpy/layout_tests/port/qt.py:
3577         (QtPort.__init__):
3578         (QtPort._path_to_webcore_library):
3579         Changed to use self.operating_system() instead of self._operating_system, for consistency
3580         with other Port-related code.
3581
3582         (QtPort.operating_system): Added this override of Port.operating_system that returns the
3583         value we determined in our __init__ method.
3584
3585         * Scripts/webkitpy/layout_tests/port/test.py:
3586         (TestPort.operating_system): Added this override of Port.operating_system that returns the
3587         value we determined in our __init__ method.
3588
3589         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3590         (PortTest.test_operating_system):
3591         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3592         (ChromiumLinuxPortTest.test_operating_system):
3593         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3594         (ChromiumMacPortTest.test_operating_system):
3595         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3596         (ChromiumWinPortTest.test_operating_system):
3597         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3598         (MacPortTest.test_operating_system):
3599         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3600         (QtPortTest.test_operating_system):
3601         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3602         (WinPortTest.test_operating_system):
3603         Test that all ports return the expected operating system string.
3604
3605 2012-01-03  Mario Sanchez Prada  <msanchez@igalia.com>
3606
3607         [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix
3608         https://bugs.webkit.org/show_bug.cgi?id=75474
3609
3610         Reviewed by Philippe Normand.
3611
3612         * Scripts/run-gtk-tests: Ignore files whose name does not start
3613         with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).
3614
3615 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
3616
3617         [Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser
3618         https://bugs.webkit.org/show_bug.cgi?id=75472
3619
3620         Reviewed by Tor Arne Vestbø.
3621
3622         * MiniBrowser/qt/MiniBrowser.pro:
3623         * MiniBrowser/qt/MiniBrowser.qrc:
3624         * MiniBrowser/qt/qml/BrowserWindow.qml:
3625         * MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
3626
3627 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
3628
3629         [Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser
3630         https://bugs.webkit.org/show_bug.cgi?id=75471
3631
3632         Reviewed by Tor Arne Vestbø.
3633
3634         Add simple UI for JavaScript Alert dialogs. This patch also adds a
3635         simple DialogButton QML type and a Dialog QML type which will be
3636         reusable for other JavaScript dialogs.
3637
3638         * MiniBrowser/qt/MiniBrowser.qrc:
3639         * MiniBrowser/qt/qml/AlertDialog.qml: Added.
3640         * MiniBrowser/qt/qml/BrowserWindow.qml:
3641         * MiniBrowser/qt/qml/Dialog.qml: Added.
3642         * MiniBrowser/qt/qml/DialogButton.qml: Added.
3643
3644 2012-01-03  Rafael Brandao  <rafael.lobo@openbossa.org>
3645
3646         [Qt][WK2] MiniBrowser doesn't show url bar
3647         https://bugs.webkit.org/show_bug.cgi?id=75470
3648
3649         Reviewed by Tor Arne Vestbø.
3650
3651         * MiniBrowser/qt/qml/BrowserWindow.qml: Remove clipping until it is fixed
3652         on QtDeclarative (QTBUG-23422).
3653
3654 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3655
3656         [GTK] Simplify loader client WebKit2 GTK+ API
3657         https://bugs.webkit.org/show_bug.cgi?id=74605
3658
3659         Reviewed by Gustavo Noronha Silva.
3660
3661         * gtk/generate-gtkdoc: Ig