Tools/ChangeLog

   1 2011-04-01  Sam Weinig  <sam@webkit.org>
   2
   3         Reviewed by Anders Carlsson.
   4
   5         WebKitTestRunner needs layoutTestController.shadowRoot
   6         https://bugs.webkit.org/show_bug.cgi?id=57661
   7
   8         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
   9         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  10         (WTR::LayoutTestController::shadowRoot):
  11         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  12         Implement layoutTestController.shadowRoot for WebKit2.
  13
  14 2011-04-01  Chang Shu  <cshu@webkit.org>
  15
  16         Reviewed by Darin Adler.
  17
  18         WebKitTestRunner needs layoutTestController.setDatabaseQuota
  19         https://bugs.webkit.org/show_bug.cgi?id=57568
  20
  21         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  22         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  23         (WTR::LayoutTestController::setDatabaseQuota):
  24         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  25
  26 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
  27
  28         Reviewed by Tony Chang.
  29
  30         This patch completes the cleanup of
  31         rebaseline-chromium-webkit-tests to work with all of the
  32         variants of a platform (we can now rebaseline gpu- and non-gpu
  33         files at the same time).
  34
  35         When the rebaselining is complete, any lines declared as
  36         REBASELINE in the expectations file that matches a test that was
  37         actually rebaselined will be deleted, even if only one of the
  38         variants was actually rebaselined. This may cause odd problems,
  39         but is better than where we're at today.
  40
  41         This change removes the -g flag and deprecates -w. The -g flag is gone
  42         because GPU baselines are handled just like any other variant.
  43         The -w flag is deprecated because this tool now only works
  44         against the canaries, since that's the only place we have a full
  45         set of bots. It will be trivial to change this to
  46         build.webkit.org if we decide that's where we want them to be.
  47
  48         Also, this patch deletes a lot of cruft that is no longer needed
  49         in the test_expectations code and the port-specific code.
  50
  51         https://bugs.webkit.org/show_bug.cgi?id=55191
  52
  53         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  54         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  55         * Scripts/webkitpy/layout_tests/port/base.py:
  56         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  57         * Scripts/webkitpy/layout_tests/port/chromium.py:
  58         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  59         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  60         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  61         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  62         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  63         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  64         * Scripts/webkitpy/layout_tests/port/mac.py:
  65         * Scripts/webkitpy/layout_tests/port/test.py:
  66         * Scripts/webkitpy/layout_tests/port/webkit.py:
  67         * Scripts/webkitpy/layout_tests/port/win.py:
  68         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  69         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  70
  71 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
  72
  73         Reviewed by Adam Barth.
  74
  75         rebaseline-chromium-webkit-tests does not work correctly with
  76         version-specific baselines. This patch updates the tool to use
  77         all of the version-specific bots on the canaries, and will now
  78         attempt to rebaseline all of the versions by default, although
  79         it will not update both GPU and CPU versions.
  80
  81         Also, it will no longer modify the test_expectations.txt file
  82         *at all*. You will have to manually delete the REBASELINE lines
  83         after running the tool and determining that it did what you
  84         wanted it to do. This should be fixed in a separate bug - see
  85         webkit bug #55191.
  86
  87         https://bugs.webkit.org/show_bug.cgi?id=55608
  88
  89         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  90         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  91         * Scripts/webkitpy/layout_tests/port/chromium.py:
  92         * Scripts/webkitpy/layout_tests/port/test.py:
  93         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  94         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  95
  96 2011-03-31  Tony Chang  <tony@chromium.org>
  97
  98         Reviewed by Ojan Vafai.
  99
 100         [chromium] update the rebaseline tool to know about pngs with checksums
 101         https://bugs.webkit.org/show_bug.cgi?id=57481
 102
 103         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
 104         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
 105
 106 2011-04-01  Adam Roben  <aroben@apple.com>
 107
 108         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
 109
 110         Previously, we were getting the revision of the first revision that triggered a build.
 111         Choosing the last revision would have been more accurate. But got_revision is what is used
 112         everywhere else on build.webkit.org, and should work even when there were no changes that
 113         triggered a build (e.g., if someone clicked the Force Build button).
 114
 115         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
 116         recent builds list
 117
 118         Reviewed by Anders Carlsson.
 119
 120         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
 121         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
 122         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
 123
 124         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
 125         (Array.prototype.first): Added this helper function to return the first element in an array
 126         that matches the given predicate, or null if no such element exists.
 127
 128 2011-03-31  Adam Roben  <aroben@apple.com>
 129
 130         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
 131
 132         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
 133
 134         Reviewed by Darin Adler.
 135
 136         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
 137         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
 138         URL on its own line.
 139
 140         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
 141         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
 142         progression, and added a new test that uses a short bug URL while I was at it.
 143
 144 2011-04-01  Adam Roben  <aroben@apple.com>
 145
 146         Mark .vcproj/.vsprops/.sln files as being Windows-only
 147
 148         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
 149
 150         Reviewed by Anders Carlsson.
 151
 152         * Scripts/webkitpy/common/config/build.py:
 153         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
 154         directories as Windows-only.
 155
 156         * Scripts/webkitpy/common/config/build_unittest.py:
 157         (ShoulBuildTest): Added test cases for the above.
 158
 159 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
 160
 161         Reviewed by Laszlo Gombos.
 162
 163         [Qt] Build MiniBrowser for Symbian
 164         https://bugs.webkit.org/show_bug.cgi?id=56319
 165
 166         Have MiniBrowser reference it's own copy of useragentlist.txt instead
 167         of copying QtTestBrowser's.
 168         Remove Tools/MiniBrowser/DerivedSources.pro
 169         This reduces complexity in the Tools scripts due to Symbian limitations.
 170
 171         * DerivedSources.pro:
 172         * MiniBrowser/DerivedSources.pro: Removed.
 173         * MiniBrowser/MiniBrowser.qrc:
 174         * MiniBrowser/qt/MiniBrowser.pro:
 175         * Scripts/webkitdirs.pm:
 176
 177 2011-03-31  Chang Shu  <cshu@webkit.org>
 178
 179         Reviewed by Darin Adler.
 180
 181         WebKitTestRunner needs layoutTestController.clearAllDatabases
 182         https://bugs.webkit.org/show_bug.cgi?id=42540
 183
 184         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
 185         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 186         (WTR::InjectedBundle::beginTesting):
 187         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 188         (WTR::LayoutTestController::clearAllDatabases):
 189         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 190
 191 2011-03-31  Chang Shu  <cshu@webkit.org>
 192
 193         Reviewed by Darin Adler.
 194
 195         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
 196         https://bugs.webkit.org/show_bug.cgi?id=42692
 197
 198         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
 199
 200 2011-03-31  Darin Adler  <darin@apple.com>
 201
 202         Reviewed by Sam Weinig.
 203
 204         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
 205         https://bugs.webkit.org/show_bug.cgi?id=57573
 206
 207         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
 208         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
 209         Removed fake definitions of keyDown and contextClick.
 210
 211         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
 212         (WTR::operator==): Added. So we can compare two WKPoint structs.
 213         (WTR::parseModifier): Added.
 214         (WTR::parseModifierArray): Added.
 215         (WTR::EventSendingController::EventSendingController): Initialize the
 216         new data members.
 217         (WTR::EventSendingController::mouseDown): Added. Calls
 218         WKBundlePageSimulateMouseDown.
 219         (WTR::EventSendingController::mouseUp): Added. Calls
 220         WKBundlePageSimulateMouseUp.
 221         (WTR::EventSendingController::mouseMoveTo): Added. Calls
 222         WKBundlePageSimulateMouseMotion.
 223         (WTR::EventSendingController::leapForward): Added.
 224         (WTR::EventSendingController::updateClickCount): Added. Used by the
 225         mouseDown/Up functions to create a click count.
 226
 227         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
 228         for the changes above.
 229
 230 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
 231
 232         Reviewed by Martin Robinson.
 233
 234         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
 235         https://bugs.webkit.org/show_bug.cgi?id=57362
 236
 237         Do not generate DRT output if willSendRequestReturnsNull is set.
 238
 239         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 240         (willSendRequestCallback):
 241
 242 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
 243
 244         Reviewed by Martin Robinson.
 245
 246         Implement MiniBrowser for Gtk port.
 247         https://bugs.webkit.org/show_bug.cgi?id=48512
 248
 249         Initial implementation of the Gtk MiniBrowser.
 250
 251         * MiniBrowser/gtk/GNUmakefile.am: Added.
 252         * MiniBrowser/gtk/main.c: Added.
 253         (activateUriEntryCallback):
 254         (destroyCallback):
 255         (goBackCallback):
 256         (goForwardCallback):
 257         (createToolbar):
 258         (createWebView):
 259         (createWindow):
 260         (argumentToURL):
 261         (main):
 262
 263 2011-03-30  Dominic Cooney  <dominicc@google.com>
 264
 265         Reviewed by Dimitri Glazkov.
 266
 267         Adds layoutTestController.shadowRoot accessor to Mac DRT.
 268         https://bugs.webkit.org/show_bug.cgi?id=57415
 269
 270         * DumpRenderTree/LayoutTestController.cpp:
 271         (shadowRootCallback):
 272         (LayoutTestController::staticFunctions):
 273         * DumpRenderTree/LayoutTestController.h:
 274         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 275         (LayoutTestController::shadowRoot):
 276         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 277         (LayoutTestController::shadowRoot):
 278
 279 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
 280
 281         Reviewed by Chris Marrin.
 282
 283         Update fast/canvas tests to avoid dumping the render tree when possible
 284         https://bugs.webkit.org/show_bug.cgi?id=57493
 285
 286         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
 287           accelerated drawing and accelerated drawing for canvas
 288
 289 2011-03-30  Adam Roben  <aroben@apple.com>
 290
 291         Stop ignoring leaks in CGGradientCreateWithColorStops
 292
 293         Fixes <rdar://problem/7888547>.
 294
 295         Rubber-stamped by John Sullivan.
 296
 297         * Scripts/old-run-webkit-tests:
 298         (countAndPrintLeaks): Removed some code to ignore those leaks.
 299
 300 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
 301
 302         Reviewed by Alexey Proskuryakov.
 303
 304         Add some dynamic annotations to JavaScriptCore/wtf
 305         https://bugs.webkit.org/show_bug.cgi?id=53747
 306
 307         By using these annotations we can improve the precision of finding
 308         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
 309         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
 310
 311         These files don't add new functionality, so don't need extra tests.
 312
 313         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
 314
 315 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
 316
 317         Reviewed by Adam Roben.
 318
 319         Share most vsprops between Release and Production builds in releaseproduction.vsprops
 320         https://bugs.webkit.org/show_bug.cgi?id=57508
 321
 322         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
 323         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
 324         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
 325         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
 326         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
 327         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
 328         * DumpRenderTree/win/ImageDiffProduction.vsprops:
 329         * DumpRenderTree/win/ImageDiffRelease.vsprops:
 330         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
 331         * FindSafari/FindSafariProduction.vsprops:
 332         * FindSafari/FindSafariRelease.vsprops:
 333         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
 334         * FindSafari/FindSafariReleasePGO.vsprops:
 335         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
 336         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
 337         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
 338         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
 339         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
 340         * WebKitAPITest/WebKitAPITestProduction.vsprops:
 341         * WebKitAPITest/WebKitAPITestRelease.vsprops:
 342         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
 343         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
 344         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
 345         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
 346         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
 347         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
 348         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
 349         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
 350         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
 351         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
 352         * WinLauncher/WinLauncherProduction.vsprops:
 353         * WinLauncher/WinLauncherRelease.vsprops:
 354         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
 355         * record-memory-win/record-memory-winProduction.vsprops:
 356         * record-memory-win/record-memory-winRelease.vsprops:
 357         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
 358
 359 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
 360
 361         Reviewed by Adam Roben.
 362
 363         Update Windows production build logic for new production configurations
 364         https://bugs.webkit.org/show_bug.cgi?id=57494
 365
 366         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
 367         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
 368         * DumpRenderTree/win/ImageDiffProduction.vsprops:
 369         * FindSafari/FindSafariProduction.vsprops:
 370         * FindSafari/FindSafariReleasePGO.vsprops:
 371         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
 372         * WebKitAPITest/WebKitAPITestProduction.vsprops:
 373         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
 374         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
 375         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
 376         * WinLauncher/WinLauncherProduction.vsprops:
 377         * record-memory-win/record-memory-winProduction.vsprops:
 378
 379 2011-03-30  Robert Hogan  <robert@webkit.org>
 380
 381         Reviewed by Antonio Gomes.
 382
 383         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
 384         Unskip http/tests/navigation/go-back-to-error-page.html
 385
 386         Also add the location of DumpRenderTreeSupportQt.h
 387         to DRT's include paths.
 388
 389         https://bugs.webkit.org/show_bug.cgi?id=52614
 390
 391         * DumpRenderTree/qt/DumpRenderTree.pro:
 392         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 393         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 394         * DumpRenderTree/qt/GCControllerQt.cpp:
 395         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 396         (LayoutTestController::queueLoadHTMLString):
 397         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 398         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
 399         * DumpRenderTree/qt/TextInputControllerQt.cpp:
 400         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
 401         (LoadAlternateHTMLStringItem::invoke):
 402         * DumpRenderTree/qt/WorkQueueItemQt.h:
 403         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
 404         * QtTestBrowser/QtTestBrowser.pro:
 405         * QtTestBrowser/launcherwindow.h:
 406
 407 2011-03-30  Adam Barth  <abarth@webkit.org>
 408
 409         Reviewed by Adam Roben.
 410
 411         SheriffBot rollouts take too long
 412         https://bugs.webkit.org/show_bug.cgi?id=57498
 413
 414         We used to build before landing rollouts via the commit-queue to
 415         prevent further breakage, but now that our individual commit-queue
 416         machines are slower, building takes too long.  I can't remember the
 417         last time a rollout broke compile.  It seems like just landing the
 418         patch is the better trade-off.
 419
 420         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 421         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 422
 423 2011-03-30  Adam Barth  <abarth@webkit.org>
 424
 425         Remove platform/chromium-mac-snowleopard
 426         https://bugs.webkit.org/show_bug.cgi?id=57486
 427
 428         This directory no longer exists, so we can remove it from the fallback
 429         chain.
 430
 431         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 432
 433 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
 434
 435         Reviewed by Adam Roben.
 436
 437         Rename Windows configuration Release_LTCG to Production for clarity
 438         https://bugs.webkit.org/show_bug.cgi?id=57465
 439
 440         * DumpRenderTree/DumpRenderTree.sln:
 441         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
 442         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
 443         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
 444         * DumpRenderTree/win/DumpRenderTree.vcproj:
 445         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
 446         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
 447         * DumpRenderTree/win/ImageDiff.vcproj:
 448         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
 449         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
 450         * FindSafari/FindSafari.vcproj:
 451         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
 452         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
 453         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
 454         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
 455         * MiniBrowser/MiniBrowser.vcproj:
 456         * Scripts/webkitdirs.pm:
 457         * TestWebKitAPI/win/TestWebKitAPI.sln:
 458         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
 459         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
 460         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
 461         * WebKitAPITest/WebKitAPITest.vcproj:
 462         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
 463         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
 464         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
 465         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
 466         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
 467         * WebKitTestRunner/WebKitTestRunner.sln:
 468         * WebKitTestRunner/win/InjectedBundle.vcproj:
 469         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
 470         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
 471         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
 472         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
 473         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
 474         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
 475         * WinLauncher/WinLauncher.vcproj:
 476         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
 477         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
 478         * record-memory-win/record-memory-win.vcproj:
 479         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
 480         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
 481
 482 2011-03-30  MORITA Hajime  <morrita@google.com>
 483
 484         Reviewed by Dimitri Glazkov.
 485
 486         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
 487         https://bugs.webkit.org/show_bug.cgi?id=56573
 488
 489         Added LayoutTestController.shadowRoot() to Chromium DRT.
 490
 491         * DumpRenderTree/chromium/LayoutTestController.cpp:
 492         (LayoutTestController::LayoutTestController):
 493         (LayoutTestController::shadowRoot):
 494         * DumpRenderTree/chromium/LayoutTestController.h:
 495
 496 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
 497
 498         Reviewed by Kent Tamura.
 499
 500         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
 501         https://bugs.webkit.org/show_bug.cgi?id=57430
 502
 503         * DumpRenderTree/chromium/LayoutTestController.cpp:
 504         (LayoutTestController::LayoutTestController):
 505         (LayoutTestController::setPluginsEnabled):
 506         * DumpRenderTree/chromium/LayoutTestController.h:
 507
 508 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
 509
 510         Reviewed by Adam Barth.
 511
 512         make webkit-patch upload respect -d
 513         https://bugs.webkit.org/show_bug.cgi?id=57425
 514
 515         * Scripts/webkitpy/common/checkout/scm.py:
 516         * Scripts/webkitpy/tool/steps/commit.py:
 517
 518 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
 519
 520         Reviewed by Adam Barth.
 521
 522         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
 523         https://bugs.webkit.org/show_bug.cgi?id=57429
 524
 525         * Scripts/webkitpy/common/checkout/scm.py:
 526
 527 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
 528
 529         Unreviewed, rolling out r82383.
 530         http://trac.webkit.org/changeset/82383
 531         https://bugs.webkit.org/show_bug.cgi?id=57417
 532
 533         "nrwt isn't shutting down cleanly" (Requested by dpranke on
 534         #webkit).
 535
 536         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 537         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
 538         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 539
 540 2011-03-29  Kent Tamura  <tkent@chromium.org>
 541
 542         Reviewed by Dimitri Glazkov.
 543
 544         Make validation message bubble testable
 545         https://bugs.webkit.org/show_bug.cgi?id=57290
 546
 547         * DumpRenderTree/mac/DumpRenderTree.mm:
 548         (createWebViewAndOffscreenWindow): Change a setting so that validation
 549           bubbles isn't hidden automatically.
 550
 551 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
 552
 553         Reviewed by Ojan Vafai.
 554
 555         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
 556
 557         It's a bit unclear whether multiple threads or multiple
 558         processes will be a better model on windows. This change will
 559         test threads for now while we're still working out the bugs in
 560         multiple-processes.
 561
 562         https://bugs.webkit.org/show_bug.cgi?id=57410
 563
 564         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 565         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
 566         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 567
 568 2011-03-29  David Levin  <levin@chromium.org>
 569
 570         Reviewed by Shinichiro Hamaji.
 571
 572         check-webkit-style confused by two ChangeLog entries in a row from same user
 573         https://bugs.webkit.org/show_bug.cgi?id=57250
 574
 575         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
 576         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
 577         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
 578           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
 579           checking more than that would be very messey.
 580         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
 581         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
 582
 583 2011-03-29  Kent Tamura  <tkent@chromium.org>
 584
 585         Reviewed by Dimitri Glazkov.
 586
 587         [Mac] Enable interactive-validation tests on Mac DRT
 588         https://bugs.webkit.org/show_bug.cgi?id=57308
 589
 590         * DumpRenderTree/mac/DumpRenderTree.mm:
 591         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
 592
 593 2011-03-29  Chang Shu  <cshu@webkit.org>
 594
 595         Reviewed by Kenneth Rohde Christiansen.
 596
 597         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
 598         https://bugs.webkit.org/show_bug.cgi?id=42692
 599
 600         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 601         (WTR::InjectedBundle::beginTesting):
 602         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 603         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
 604         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
 605
 606 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
 607
 608         Reviewed by Xan Lopez.
 609
 610         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
 611         https://bugs.webkit.org/show_bug.cgi?id=57067
 612
 613         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
 614         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
 615         update DRT and pixel results as hundreds of results will need to be updated.
 616
 617         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 618         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
 619         by overriding the theme RC/CSS files.
 620
 621 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
 622
 623         Reviewed by Adam Roben.
 624
 625         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
 626         https://bugs.webkit.org/show_bug.cgi?id=57394
 627
 628         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
 629         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
 630         the IDE. To avoid this, add a separate vsprops file for each project configuration that
 631         contains the required inherited property sheets.
 632
 633         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
 634         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
 635         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
 636         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
 637         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
 638         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
 639         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
 640         * DumpRenderTree/win/DumpRenderTree.vcproj:
 641         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
 642         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
 643         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
 644         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
 645         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
 646         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
 647         * DumpRenderTree/win/ImageDiff.vcproj:
 648         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
 649         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
 650         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
 651         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
 652         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
 653         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
 654         * FindSafari/FindSafari.vcproj:
 655         * FindSafari/FindSafariDebug.vsprops: Added.
 656         * FindSafari/FindSafariDebugAll.vsprops: Added.
 657         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
 658         * FindSafari/FindSafariRelease.vsprops: Added.
 659         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
 660         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
 661         * FindSafari/FindSafariReleasePGO.vsprops: Added.
 662         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
 663         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
 664         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
 665         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
 666         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
 667         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
 668         * MiniBrowser/MiniBrowser.vcproj:
 669         * WebKitAPITest/WebKitAPITest.vcproj:
 670         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
 671         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
 672         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
 673         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
 674         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
 675         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
 676         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
 677         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
 678         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
 679         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
 680         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
 681         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
 682         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
 683         * WebKitTestRunner/win/InjectedBundle.vcproj:
 684         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
 685         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
 686         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
 687         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
 688         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
 689         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
 690         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
 691         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
 692         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
 693         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
 694         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
 695         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
 696         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
 697         * WinLauncher/WinLauncher.vcproj:
 698         * WinLauncher/WinLauncherDebug.vsprops: Added.
 699         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
 700         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
 701         * WinLauncher/WinLauncherRelease.vsprops: Added.
 702         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
 703         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
 704         * record-memory-win/record-memory-win.vcproj:
 705         * record-memory-win/record-memory-winDebug.vsprops: Added.
 706         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
 707         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
 708         * record-memory-win/record-memory-winRelease.vsprops: Added.
 709         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
 710         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
 711
 712 2011-03-29  Adam Barth  <abarth@webkit.org>
 713
 714         Reviewed by Darin Adler.
 715
 716         test_runner2.py can crash due to undefined variable
 717         https://bugs.webkit.org/show_bug.cgi?id=57356
 718
 719         Replace reference to undefined variable with a variable that's actually
 720         defined.  AFAICT, there's no way to test this code.
 721
 722         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
 723
 724 2011-03-29  Tony Chang  <tony@chromium.org>
 725
 726         Reviewed by Eric Seidel.
 727
 728         cleanup rebaseline-chromium-webkit-tests
 729         https://bugs.webkit.org/show_bug.cgi?id=57375
 730
 731         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 732             - Split _extract_and_add_new_baselines into 3 functions
 733             - Reduce the amount of line wrapping (the file already has lines
 734               over 80 col, so may as well try to make the file consistent)
 735             - Remove unnecessary ()s
 736
 737 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
 738
 739         Reviewed by Adam Roben.
 740
 741         Make WinCairo a core builder.
 742         https://bugs.webkit.org/show_bug.cgi?id=57373
 743
 744         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
 745         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
 746
 747 2011-03-29  Timothy Hatcher  <timothy@apple.com>
 748
 749         Update update-webkit-localizable-strings to understand that WebKit and
 750         WebKit2 strings go in WebCore.
 751
 752         Also make extract-localizable-strings optionally use an exclude file. No individual
 753         warnings are produced about unlocalized strings when there is no exclude file. This
 754         is needed for WebCore, since there are too many bare strings.
 755
 756         https://webkit.org/b/57354
 757
 758         Reviewed by Sam Weinig.
 759
 760         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
 761         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
 762
 763 2011-03-29  Darin Adler  <darin@apple.com>
 764
 765         Reviewed by Adam Roben.
 766
 767         WebKit2 bundle page needs to offer generated file hooks
 768         https://bugs.webkit.org/show_bug.cgi?id=57279
 769
 770         (Land missing part of the original patch after r82289.)
 771
 772         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 773         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
 774
 775 2011-03-29  Tony Chang  <tony@chromium.org>
 776
 777         Reviewed by Ojan Vafai.
 778
 779         [chromium] NRWT should be able to read checksums from png comments
 780         https://bugs.webkit.org/show_bug.cgi?id=57280
 781
 782         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
 783             from a file.
 784         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
 785         * Scripts/webkitpy/common/system/filesystem_mock.py:
 786         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
 787             if the -checksum.txt file doesn't exist, try looking in the png.
 788         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
 789         * Scripts/webkitpy/layout_tests/port/test.py:
 790         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
 791             2k for a png comment with the checksum
 792         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
 793
 794 2011-03-29  Philippe Normand  <pnormand@igalia.com>
 795
 796         Rubber-stamped by Gustavo Noronha Silva.
 797
 798         [GTK] http/tests/uri/username-with-no-hostname.html fails
 799         https://bugs.webkit.org/show_bug.cgi?id=57325
 800
 801         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 802         (willSendRequestCallback): URI host value check done case-insensitively.
 803
 804 2011-03-29  Philippe Normand  <pnormand@igalia.com>
 805
 806         Reviewed by Martin Robinson.
 807
 808         [GTK] http/tests/uri/username-with-no-hostname.html fails
 809         https://bugs.webkit.org/show_bug.cgi?id=57325
 810
 811         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 812         (willSendRequestCallback): Check URI before submitting the request
 813         to WebCore.
 814
 815 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
 816
 817         Reviewed by Ojan Vafai.
 818
 819         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
 820         https://bugs.webkit.org/show_bug.cgi?id=57303
 821
 822         * DumpRenderTree/chromium/EventSender.cpp:
 823         (EventSender::doDragDrop):
 824         (EventSender::beginDragWithFiles):
 825
 826 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
 827
 828         Reviewed by Andreas Kling.
 829
 830         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
 831         https://bugs.webkit.org/show_bug.cgi?id=57314
 832
 833         Provide possibility to print loaded urls to the standard output.
 834
 835         * MiniBrowser/qt/BrowserWindow.cpp:
 836         (BrowserWindow::BrowserWindow):
 837         (BrowserWindow::printURL):
 838         * MiniBrowser/qt/BrowserWindow.h:
 839         * MiniBrowser/qt/MiniBrowserApplication.cpp:
 840         (MiniBrowserApplication::handleUserOptions):
 841         * MiniBrowser/qt/MiniBrowserApplication.h:
 842         (WindowOptions::WindowOptions):
 843         * QtTestBrowser/launcherwindow.cpp:
 844         (LauncherWindow::initializeView):
 845         (LauncherWindow::printURL):
 846         (LauncherWindow::cloneWindow):
 847         * QtTestBrowser/launcherwindow.h:
 848         (WindowOptions::WindowOptions):
 849         * QtTestBrowser/main.cpp:
 850         (LauncherApplication::handleUserOptions):
 851
 852 2011-03-29  Gabor Loki  <loki@webkit.org>
 853
 854         Rubber-stamped by Csaba Osztrogonác.
 855
 856         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
 857         https://bugs.webkit.org/show_bug.cgi?id=56918
 858
 859         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
 860
 861 2011-03-28  Gabor Loki  <loki@webkit.org>
 862
 863         Reviewed by Csaba Osztrogonác.
 864
 865         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
 866         https://bugs.webkit.org/show_bug.cgi?id=56918
 867
 868         * Scripts/build-jsc:
 869         * Scripts/webkitdirs.pm:
 870
 871 2011-03-28  Andrew Foster  <andrewf@chromium.org>
 872
 873         Reviewed by Ojan Vafai.
 874
 875         webkit-patch should be more intelligent about whether a bug applies to a patch
 876         Create a new function, parse_bug_id_from_changelog() which determines
 877         that a bug is related to a patch by parsing the output generated from
 878         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
 879         the description of a patch.
 880         https://bugs.webkit.org/show_bug.cgi?id=56989
 881
 882         * Scripts/webkitpy/common/checkout/api.py:
 883         * Scripts/webkitpy/common/checkout/changelog.py:
 884         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
 885         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
 886         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
 887         * Scripts/webkitpy/style/checkers/changelog.py:
 888         * Scripts/webkitpy/tool/commands/upload.py:
 889
 890 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
 891
 892         Revert accidentally commited change.
 893
 894         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 895         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
 896
 897 2011-03-28  Tony Chang  <tony@chromium.org>
 898
 899         Reviewed by Adam Barth.
 900
 901         [chromium] have DRT write the png checksum into a png comment
 902         https://bugs.webkit.org/show_bug.cgi?id=57255
 903
 904         * DumpRenderTree/chromium/TestShell.cpp:
 905         (TestShell::dumpImage):
 906
 907 2011-03-28  Adele Peterson  <adele@apple.com>
 908
 909         Removing Qt stub, since it doesn't use the same header as the others.
 910
 911         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 912
 913 2011-03-28  Adele Peterson  <adele@apple.com>
 914
 915         Added a few more stubs.
 916
 917         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 918         (LayoutTestController::hasGrammarMarker):
 919         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 920         (LayoutTestController::hasGrammarMarker):
 921         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 922         (LayoutTestController::hasGrammarMarker):
 923
 924 2011-03-28  Adele Peterson  <adele@apple.com>
 925
 926         Build fix.
 927
 928         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 929         (LayoutTestController::hasGrammarMarker):
 930
 931 2011-03-28  Adele Peterson  <adele@apple.com>
 932
 933         Reviewed by Eric Seidel.
 934
 935         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
 936         https://bugs.webkit.org/show_bug.cgi?id=57173
 937
 938         * DumpRenderTree/LayoutTestController.cpp:
 939         (hasGrammarMarkerCallback): Added.
 940         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
 941         * DumpRenderTree/LayoutTestController.h:
 942         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
 943         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
 944
 945 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
 946
 947         Reviewed by Benjamin Poulain.
 948
 949         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
 950         https://bugs.webkit.org/show_bug.cgi?id=57087
 951
 952         Trivial typo fix after r82082.
 953
 954         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
 955         (WTR::activateFonts):
 956
 957 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
 958
 959         Reviewed by Andreas Kling.
 960
 961         Add myself to the committers list.
 962
 963         * Scripts/webkitpy/common/config/committers.py:
 964
 965 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
 966
 967         Reviewed by Sam Weinig.
 968
 969         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
 970         to link against WebKit.framework for now.
 971
 972         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
 973
 974 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
 975
 976         Reviewed by Andreas Kling.
 977
 978         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
 979         https://bugs.webkit.org/show_bug.cgi?id=57087
 980
 981         Disable QT_ASCII_CAST_WARNINGS for applications.
 982
 983         * DumpRenderTree/qt/DumpRenderTree.pro:
 984         * DumpRenderTree/qt/ImageDiff.pro:
 985         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 986         * MiniBrowser/qt/MiniBrowser.pro:
 987         * QtTestBrowser/QtTestBrowser.pro:
 988         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 989
 990 2011-03-28  Andreas Kling  <kling@webkit.org>
 991
 992         Reviewed by Kenneth Rohde Christiansen.
 993
 994         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
 995         https://bugs.webkit.org/show_bug.cgi?id=57224
 996
 997         * QtTestBrowser/mainwindow.cpp:
 998         (MainWindow::buildUI):
 999         (MainWindow::onTitleChanged):
1000         * QtTestBrowser/mainwindow.h:
1001
1002 2011-03-27  Jer Noble  <jer.noble@apple.com>
1003
1004         Reviewed by Maciej Stachowiak.
1005
1006         Full Screen: disable keyboard access by default
1007         https://bugs.webkit.org/show_bug.cgi?id=56684
1008
1009         Accept the withKeyboard parameter to supportsFullScreenForElement.
1010
1011         * DumpRenderTree/mac/UIDelegate.mm:
1012         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
1013
1014 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
1015
1016         Reviewed by David Levin.
1017
1018         check-webkit-style should check ChangeLog for a valid bug number
1019         https://bugs.webkit.org/show_bug.cgi?id=57184
1020
1021         * Scripts/webkitpy/style/checker.py:
1022         * Scripts/webkitpy/style/checker_unittest.py:
1023         * Scripts/webkitpy/style/checkers/changelog.py: Added.
1024         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
1025
1026 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
1027
1028         Reviewed by Andreas Kling.
1029
1030         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
1031         https://bugs.webkit.org/show_bug.cgi?id=57087
1032
1033         Use explicit conversion for string to avoid depending on the default codec
1034         installed by the user code.
1035
1036         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1037         (WTR::activateFonts):
1038
1039 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
1040
1041         Revert inadvertantly committed changes.
1042
1043         * Scripts/old-run-webkit-tests:
1044         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1045
1046 2011-03-26  Andreas Kling  <kling@webkit.org>
1047
1048         Reviewed by Kenneth Rohde Christiansen.
1049
1050         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
1051         https://bugs.webkit.org/show_bug.cgi?id=57162
1052
1053         * QtTestBrowser/QtTestBrowser.qrc:
1054         * QtTestBrowser/favicon.png: Added.
1055         * QtTestBrowser/locationedit.cpp:
1056         (defaultPageIcon):
1057         (LocationEdit::LocationEdit):
1058         (LocationEdit::setPageIcon):
1059         (LocationEdit::resizeEvent):
1060         (LocationEdit::updateInternalGeometry):
1061         * QtTestBrowser/locationedit.h:
1062         * QtTestBrowser/mainwindow.cpp:
1063         (MainWindow::buildUI):
1064         (MainWindow::onIconChanged):
1065         (MainWindow::onLoadStarted):
1066         * QtTestBrowser/mainwindow.h:
1067
1068 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
1069
1070         Reviewed by Xan Lopez.
1071
1072         [GTK] Force DumpRenderTree to use 96 DPI
1073         https://bugs.webkit.org/show_bug.cgi?id=56866
1074
1075         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
1076         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
1077
1078         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1079         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
1080         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
1081         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
1082
1083 2011-03-25  Andy Estes  <aestes@apple.com>
1084
1085         Reviewed by Adele Peterson.
1086
1087         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
1088         https://bugs.webkit.org/show_bug.cgi?id=49016
1089
1090         TestNetscapePlugIn needs to register support for an image MIME type so
1091         we can test that the embed tag prefers plug-ins to render image MIME
1092         types.
1093
1094         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
1095         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1096         (NP_GetMIMEDescription): Ditto.
1097         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
1098
1099 2011-03-25  Jessie Berlin  <jberlin@apple.com>
1100
1101         Reviewed by Sam Weinig.
1102
1103         WebKit2: Need to be able to set and get the Cookie Storage Policy.
1104         https://bugs.webkit.org/show_bug.cgi?id=50780
1105
1106         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
1107
1108         The test is named "CookieManager" so that we can eventually exercise more of the
1109         CookieManager functionality in the test.
1110
1111         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
1112         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
1113         Assert that the policy returned is equal to the policy set in
1114         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
1115         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
1116         Set the policy to something different than the user's policy and get the policy again.
1117         (TestWebKitAPI::didFinishLoadForFrame):
1118         Get the user's policy so that it can be restored at the end of the test.
1119         (TestWebKitAPI::TEST):
1120         Load about:blank so that the Web Process gets instatiated (needed to get the
1121         CookieManager).
1122
1123         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1124         Add CookieManager.cpp.
1125
1126 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
1127
1128         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
1129
1130         * wx/build/settings.py:
1131
1132 2011-03-24  Ilya Sherman  <isherman@chromium.org>
1133
1134         Reviewed by Adam Roben.
1135
1136         Implement layoutTestController.setAutoFilled in DRT on Windows
1137         https://bugs.webkit.org/show_bug.cgi?id=56828
1138
1139         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1140         (LayoutTestController::setAutofilled): Implemented.
1141
1142 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1143
1144         Unreviewed build correction.
1145
1146         Correct vsprops file for Debug variant of the CFLite build.
1147         Disable a CFNETWORK-specific test when building for CFLite.
1148
1149         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
1150         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1151
1152 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1153
1154         Reviewed by Adam Barth.
1155
1156         fix regressions introduced in 81908 - there were a couple of
1157         code paths that only fired under python 2.5 that I missed.
1158
1159         Also change a couple of 'python' references to sys.executable
1160         in order to handle runing test-webkitpy with a binary other than
1161         something called 'python'.
1162
1163         https://bugs.webkit.org/show_bug.cgi?id=57063
1164
1165         * Scripts/webkitpy/layout_tests/port/mac.py:
1166         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1167         * Scripts/webkitpy/test/cat.py:
1168         * Scripts/webkitpy/test/echo.py:
1169
1170 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
1171
1172         Unreviewed build correction.
1173
1174         Add a stub implementation of the TestInvocation dumping logic.
1175         Update project files to reflect new file.
1176
1177         * WebKitTestRunner/cairo: Added.
1178         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
1179         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1180         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1181
1182 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1183
1184         Reviewed by Tony Chang.
1185
1186         new-run-webkit-tests: clean up worker model defaults. This
1187         changes the default behavior to 'threads' instead of
1188         'old-threads', and clarifies that chromium-win-* and
1189         chromium-mac-leopard are exceptions.
1190
1191         https://bugs.webkit.org/show_bug.cgi?id=56971
1192
1193         * Scripts/webkitpy/layout_tests/port/base.py:
1194         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1195         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1196         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1197         * Scripts/webkitpy/layout_tests/port/test.py:
1198         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1199
1200 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
1201
1202         Reviewed by Darin Adler.
1203
1204         Media Stream API: fix the order of the options in build-webkit.
1205         https://bugs.webkit.org/show_bug.cgi?id=56949
1206
1207         Fix the order of the options in build-webkit.
1208
1209         * Scripts/build-webkit:
1210
1211 2011-03-23  Adam Klein  <adamk@chromium.org>
1212
1213         Reviewed by Mihai Parparita.
1214
1215         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
1216         https://bugs.webkit.org/show_bug.cgi?id=56884
1217
1218         This option will be utilized by Chromium's ui_tests to allow
1219         referencing js-test-resources from a layout test over HTTP.
1220
1221         * Scripts/new-run-webkit-httpd:
1222         Added --layout_tests_dir option.
1223         * Scripts/webkitpy/layout_tests/port/http_server.py:
1224         Plumbed through as layout_tests_dir param.
1225
1226 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
1227
1228         Reviewed by Mihai Parparita.
1229
1230         new-run-webkit-tests: run tests in ascending alphabetical order per
1231         dir. This is a second attempt at the fix; the first attempt, in
1232         r81597, broke the behavior on the old-inline and old-threads
1233         worker models.
1234
1235         https://bugs.webkit.org/show_bug.cgi?id=56760
1236
1237         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1238         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1239         * Scripts/webkitpy/layout_tests/port/test.py:
1240         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1241
1242 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
1243
1244         Reviewed by Martin Robinson.
1245
1246         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
1247         https://bugs.webkit.org/show_bug.cgi?id=56953
1248
1249         Print the string for the detail of 'property-change' signal.
1250
1251         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
1252         (axObjectEventListener): Print the detail string.
1253
1254 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
1255
1256         Reviewed by Pavel Feldman.
1257
1258         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
1259         https://bugs.webkit.org/show_bug.cgi?id=56843
1260
1261         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1262         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1263
1264 2011-03-22  Eric Seidel  <eric@webkit.org>
1265
1266         Reviewed by Adam Barth.
1267
1268         Teach update-webkit about gyp
1269         https://bugs.webkit.org/show_bug.cgi?id=56881
1270
1271         This makes it possible for someone who builds from Xcode
1272         to just run update-webkit --gyp and have the project files
1273         generated after update automatically.
1274
1275         I also added a stand-alone "generate-project-files" script
1276         wrapping Source/gyp/configure.  This makes running gyp simpler
1277         since most people will not have gyp or Source/gyp in their path.
1278
1279         * Scripts/build-webkit:
1280         * Scripts/generate-project-files: Added.
1281         * Scripts/update-webkit:
1282
1283 2011-03-22  Anton D'Auria  <adauria@apple.com>
1284
1285         Reviewed by Alexey Proskuryakov.
1286
1287         Add +[WebApplicationCache getOriginsWithCache]
1288         https://bugs.webkit.org/show_bug.cgi?id=56722
1289
1290         * DumpRenderTree/LayoutTestController.cpp:
1291         (originsWithApplicationCacheCallback):
1292         (LayoutTestController::staticFunctions):
1293         * DumpRenderTree/LayoutTestController.h:
1294         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
1295         (LayoutTestController::originsWithApplicationCache):
1296         * DumpRenderTree/chromium/LayoutTestController.h:
1297         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
1298         (LayoutTestController::originsWithApplicationCache):
1299         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
1300         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
1301         (LayoutTestController::originsWithApplicationCache):
1302         (LayoutTestController::originsWithLocalStorage):
1303         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
1304         (LayoutTestController::originsWithApplicationCache):
1305         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1306         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
1307         (LayoutTestController::originsWithApplicationCache):
1308         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
1309         (LayoutTestController::originsWithApplicationCache):
1310
1311 2011-03-22  Eric Seidel  <eric@webkit.org>
1312
1313         Reviewed by Adam Barth.
1314
1315         Add support to build-webkit for building with gyp-generated project files
1316         https://bugs.webkit.org/show_bug.cgi?id=56877
1317
1318         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
1319         Eventually we'll want to support gyp-generated projects in a more general manner.
1320
1321         * Scripts/build-webkit:
1322
1323 2011-03-22  David Kilzer  <ddkilzer@apple.com>
1324
1325         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
1326
1327         Reviewed by Joseph Pecoraro.
1328
1329         * Scripts/build-webkit: Updated usage statement to include
1330         --dsym.
1331         * Scripts/webkitdirs.pm: Added $generateDsym variable.
1332         (generateDsym): Added. Call determineGenerateDsym() and
1333         return $generateDsym.
1334         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
1335         $generateDsym.
1336         (argumentsForXcode): Added.  Returns additional arguments for
1337         xcodebuild based on command-line switches.
1338         (XcodeOptions): Updated to include argumentsForXcode() in the
1339         array returned.
1340
1341 2011-03-22  Adam Roben  <aroben@apple.com>
1342
1343         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
1344
1345         These bots are consistently green again.
1346
1347         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
1348         core builders
1349
1350         Rubber-stamped by Antti Koivisto.
1351
1352         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1353         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
1354
1355         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1356         (BuildBotTest.test_builder_name_regexps): Updated expectations.
1357
1358 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
1359
1360         Unreviewed, rolling out r81597.
1361         http://trac.webkit.org/changeset/81597
1362         https://bugs.webkit.org/show_bug.cgi?id=56801
1363
1364         Change results in lots of unexpected flaky on the dashboard.
1365         (Requested by pfeldman on #webkit).
1366
1367         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1368         * Scripts/webkitpy/layout_tests/port/test.py:
1369         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1370
1371 2011-03-21  Sam Weinig  <sam@webkit.org>
1372
1373         Fix failing tests on the WebKit2 bots.
1374
1375         * WebKitTestRunner/TestController.cpp:
1376         (WTR::TestController::resetStateToConsistentValues):
1377
1378 2011-03-21  Daniel Sievers  <sievers@google.com>
1379
1380         Reviewed by Simon Fraser.
1381
1382         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
1383         https://bugs.webkit.org/show_bug.cgi?id=56139
1384
1385         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1386         (main):
1387         * DumpRenderTree/chromium/LayoutTestController.cpp:
1388         (LayoutTestController::LayoutTestController):
1389         (LayoutTestController::layerTreeAsText):
1390         * DumpRenderTree/chromium/LayoutTestController.h:
1391         (LayoutTestController::setShowDebugLayerTree):
1392         * DumpRenderTree/chromium/TestShell.cpp:
1393         (TestShell::runFileTest):
1394         (TestShell::dump):
1395         * DumpRenderTree/chromium/TestShell.h:
1396         (TestParams::TestParams):
1397
1398 2011-03-21  Adam Roben  <aroben@apple.com>
1399
1400         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
1401
1402         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1403         output as plain text
1404
1405         Reviewed by David Kilzer.
1406
1407         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1408         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
1409         to the master.
1410         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
1411         since we're running on the build master, not the slave. Instead, turn the raw source of
1412         actual.html which the build slave uploaded into an HTML log.
1413
1414 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
1415
1416         Reviewed by Mihai Parparita.
1417
1418         new-run-webkit-tests: run tests in ascending alphabetical order per dir
1419         https://bugs.webkit.org/show_bug.cgi?id=56760
1420
1421         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1422         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1423         * Scripts/webkitpy/layout_tests/port/test.py:
1424
1425 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
1426
1427         Reviewed by Steve Block.
1428
1429         Media Stream API patch 0: adding compilation guards.
1430         https://bugs.webkit.org/show_bug.cgi?id=56458
1431
1432         Adding options to enable the media stream API feature in Chromium.
1433
1434         * Scripts/build-webkit:
1435
1436 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
1437
1438         Reviewed by Laszlo Gombos.
1439
1440         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
1441         https://bugs.webkit.org/show_bug.cgi?id=56323
1442
1443         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide
1444         "--stdout" or "--stderr" option.
1445
1446         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1447         (WebCore::DumpRenderTree::~DumpRenderTree):
1448         (WebCore::DumpRenderTree::processArgsLine):
1449         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1450         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1451         (WebCore::DumpRenderTree::setRedirectOutputFileName):
1452         (WebCore::DumpRenderTree::setRedirectErrorFileName):
1453         * DumpRenderTree/qt/main.cpp:
1454         (isOption):
1455         (takeOptionValue):
1456         (printUsage):
1457         (main):
1458
1459 2011-03-21  Adam Roben  <aroben@apple.com>
1460
1461         Fix exceptions on the buildbot due to my last change
1462
1463         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1464         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
1465
1466 2011-03-21  Adam Roben  <aroben@apple.com>
1467
1468         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
1469
1470         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1471         output as plain text
1472
1473         Reviewed by Darin Adler.
1474
1475         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1476         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
1477         logs.
1478         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
1479         the build master. This will correctly treat it as HTML.
1480
1481 2011-03-20  Bill Budge  <bbudge@chromium.org>
1482
1483         Reviewed by Adam Barth.
1484
1485         Rename ThreadSafeShared to ThreadSafeRefCounted
1486         https://bugs.webkit.org/show_bug.cgi?id=56714
1487
1488         No new tests. Exposes no new functionality.
1489
1490         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
1491         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
1492         * Scripts/do-webcore-rename:
1493
1494 2011-03-19  Anton D'Auria  <adauria@apple.com>
1495
1496         Reviewed by Dan Bernstein.
1497
1498         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
1499         https://bugs.webkit.org/show_bug.cgi?id=56719
1500
1501         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
1502         (LayoutTestController::clearApplicationCacheForOrigin):
1503
1504 2011-03-19  Anton D'Auria  <adauria@apple.com>
1505
1506         Reviewed by Alexey Proskuryakov.
1507
1508         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
1509         https://bugs.webkit.org/show_bug.cgi?id=56415
1510
1511         * DumpRenderTree/LayoutTestController.cpp:
1512         (clearApplicationCacheForOriginCallback):
1513         (LayoutTestController::staticFunctions):
1514         * DumpRenderTree/LayoutTestController.h:
1515         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
1516         (LayoutTestController::LayoutTestController):
1517         (LayoutTestController::clearAllApplicationCaches):
1518         (LayoutTestController::clearApplicationCacheForOrigin):
1519         * DumpRenderTree/chromium/LayoutTestController.h:
1520         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
1521         (LayoutTestController::clearApplicationCacheForOrigin):
1522         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
1523         (LayoutTestController::clearApplicationCacheForOrigin):
1524         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1525         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
1526         (LayoutTestController::clearApplicationCacheForOrigin):
1527         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
1528         (LayoutTestController::clearApplicationCacheForOrigin):
1529
1530 2011-03-18  Dan Bernstein  <mitz@apple.com>
1531
1532         Revised build fix for r81135.
1533
1534         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1535         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1536
1537 2011-03-18  Adam Roben  <aroben@apple.com>
1538
1539         Windows build fix
1540
1541         * WebKitTestRunner/config.h: Add a missing #endif.
1542
1543 2011-03-18  Andreas Kling  <kling@webkit.org>
1544
1545         Unbreak Qt build after r81494.
1546
1547         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1548         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1549
1550 2011-03-18  Sam Weinig  <sam@webkit.org>
1551
1552         Fix windows build. This was really Adam Roben's fault. I swear!
1553
1554         * WebKitTestRunner/config.h:
1555
1556 2011-03-18  Sam Weinig  <sam@webkit.org>
1557
1558         Reviewed by Adam Roben.
1559
1560         Pixel tests don't work in WebKitTestRunner on Windows
1561         https://bugs.webkit.org/show_bug.cgi?id=56630
1562
1563         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
1564         built-in snapshotting instead of using the window server on the Mac.
1565
1566         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1567         (WTR::InjectedBundle::InjectedBundle):
1568         (WTR::InjectedBundle::didReceiveMessage):
1569         (WTR::InjectedBundle::beginTesting):
1570         (WTR::InjectedBundle::done):
1571         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1572         (WTR::InjectedBundle::setPixelResult):
1573         (WTR::InjectedBundle::shouldDumpPixels):
1574         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1575         (WTR::InjectedBundlePage::dump):
1576         Take the snapshot in the bundle and send it to the UIProcess for dumping.
1577
1578         * WebKitTestRunner/TestInvocation.cpp:
1579         (WTR::TestInvocation::invoke):
1580         (WTR::TestInvocation::dump):
1581         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1582         * WebKitTestRunner/TestInvocation.h:
1583         * WebKitTestRunner/cg: Added.
1584         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
1585         (WTR::createCGContextFromImage):
1586         (WTR::computeMD5HashStringForContext):
1587         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1588         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1589         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
1590
1591         * WebKitTestRunner/win/TestInvocationWin.cpp:
1592         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1593         Keep stub for Cairo build.
1594
1595         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
1596         Add CG configuration.
1597
1598         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1599         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1600         Add new files.
1601
1602 2011-03-18  Adam Roben  <aroben@apple.com>
1603
1604         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
1605
1606         Rubber-stamped by Simon Fraser.
1607
1608         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1609         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
1610         overflow-y:overlay so that the scrollbar doesn't overlay the content.
1611
1612 2011-03-18  Adam Roben  <aroben@apple.com>
1613
1614         Don't ellipsize long or indented function names in Leaks Viewer
1615
1616         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
1617         scrollbar
1618
1619         Reviewed by Simon Fraser.
1620
1621         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1622         (.data-grid .data-container):
1623         (.data-grid td > div, .data-grid th > div):
1624         Allow the contents to extend to the right.
1625
1626 2011-03-18  Adam Roben  <aroben@apple.com>
1627
1628         Fix some leaks in DRT seen on the leaks bot
1629
1630         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
1631         setWillSendRequestClearHeaderCallback in DRT are leaky
1632
1633         Reviewed by Alexey Proskuryakov.
1634
1635         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
1636
1637         * DumpRenderTree/LayoutTestController.cpp:
1638         (addURLToRedirectCallback):
1639         (setWillSendRequestClearHeaderCallback):
1640         Use OwnArrayPtr to cause the strings to be deleted.
1641
1642 2011-03-18  Adam Roben  <aroben@apple.com>
1643
1644         Fix a NSURLCredential leak seen on the leaks bot
1645
1646         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
1647         connection:didReceiveAuthenticationChallenge:] is leaky
1648
1649         Reviewed by John Sullivan.
1650
1651         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1652         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
1653         cause the NSURLCredential to be released.
1654
1655 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
1656
1657         Unreviewed.
1658
1659         Remove unnecessary brackets around my email address.
1660
1661         * Scripts/webkitpy/common/config/committers.py:
1662
1663 2011-03-18  Adam Roben  <aroben@apple.com>
1664
1665         Remove some files I accidentally added in r81454
1666
1667         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
1668         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
1669
1670 2011-03-18  Adam Roben  <aroben@apple.com>
1671
1672         Ignore an NSNumberFormatter leak on SnowLeopard
1673
1674         * Scripts/old-run-webkit-tests:
1675         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
1676         getObjectValue:forString:errorDescription:].
1677
1678 2011-03-18  Adam Roben  <aroben@apple.com>
1679
1680         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
1681
1682         Rubber-stamped by Mark Rowe.
1683
1684         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1685         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
1686         released.
1687
1688 2011-03-17  Adam Roben  <aroben@apple.com>
1689
1690         Address a review comment I missed in r81445
1691
1692         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1693         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
1694         leaked bytes to speed up searching on long lines.
1695
1696 2011-03-17  Adam Roben  <aroben@apple.com>
1697
1698         Mark leaky builds orange, even if all regression tests passed
1699
1700         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
1701         build.webkit.org when all tests pass even though there are still leaks
1702
1703         Reviewed by Dan Bernstein.
1704
1705         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1706         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
1707         be marked orange if this build step generates warnings.
1708
1709 2011-03-17  Adam Roben  <aroben@apple.com>
1710
1711         Allow values in Leaks Viewer to be shown as percentages
1712
1713         Double-clicking on a column will toggle between showing percentages and showing real values.
1714
1715         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
1716         number of leaked bytes in Leaks Viewer
1717
1718         Reviewed by Joe Pecoraro.
1719
1720         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1721         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
1722         node's totalTime, which is used in calculating percentages.
1723
1724         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1725         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
1726         showing them as percentages.
1727
1728 2011-03-17  Adam Roben  <aroben@apple.com>
1729
1730         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
1731
1732         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
1733         the number of leaked allocations. And the new Average column shows the average number of
1734         leaked bytes per call.
1735
1736         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
1737         just how many allocations
1738
1739         Reviewed by Joe Pecoraro.
1740
1741         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1742         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
1743         line and store it with the leak stack.
1744         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
1745         properties.
1746         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
1747         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
1748         .numberOfCalls now holds the number of leaked allocations.
1749
1750         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1751         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
1752         appear.
1753         (monkeyPatchInspectorObjects): Format the values as bytes.
1754
1755 2011-03-17  Adam Roben  <aroben@apple.com>
1756
1757         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
1758
1759         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
1760         regression tests
1761
1762         Reviewed by James Robinson.
1763
1764         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1765         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
1766         is always populated, even when all regression tests pass.
1767
1768 2011-03-10  Hayato Ito  <hayato@chromium.org>
1769
1770         Reviewed by Tony Chang.
1771
1772         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
1773
1774         https://bugs.webkit.org/show_bug.cgi?id=56076
1775
1776         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1777
1778 2011-03-17  Adam Roben  <aroben@apple.com>
1779
1780         Skip a compositing-sensitive test when accelerated compositing is disabled
1781
1782         Reviewed by Sam Weinig.
1783
1784         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
1785         accelerated compositing is disabled.
1786
1787 2011-03-17  Adam Roben  <aroben@apple.com>
1788
1789         Start using PlatformSpecificScheduler for the Mac builders
1790
1791         The current set of file/directory patterns should work for Mac builders. We may discover
1792         that there are more files and directories we can exclude from the Mac builds, but they can
1793         be added later.
1794
1795         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
1796
1797         Reviewed by Mark Rowe.
1798
1799         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
1800         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
1801
1802         * Scripts/webkitpy/common/config/build.py:
1803         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
1804         cleaned up patterns a little bit.
1805
1806         * Scripts/webkitpy/common/config/build_unittest.py:
1807         (ShouldBuildTest): Fixed some expected results.
1808         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
1809         platforms.
1810
1811 2011-03-17  Jeff Miller  <jeffm@apple.com>
1812
1813         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
1814
1815         *.mode*
1816         *.pbxuser
1817         *.perspective*
1818         project.xcworkspace
1819         xcuserdata
1820
1821         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1822         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1823         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1824         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1825         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1826
1827 2011-03-17  Adam Roben  <aroben@apple.com>
1828
1829         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
1830
1831         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
1832         mac-wk2
1833
1834         Reviewed by Anders Carlsson.
1835
1836         * Scripts/old-run-webkit-tests:
1837         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
1838         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
1839         we're running in WebKit2 mode.
1840
1841 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
1842
1843         Reviewed by Yury Semikhatsky.
1844
1845         Web Inspector: Clean up Inspector strings.
1846         https://bugs.webkit.org/show_bug.cgi?id=56557
1847
1848         Modify the script to deal correctly with "\xNN" escapes, and to
1849         check strings in Chromium's DevTools.js.
1850
1851         * Scripts/check-inspector-strings:
1852
1853 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
1854
1855         Reviewed by Benjamin Poulain.
1856
1857         Update autoinstall to install mechanize 0.2.4
1858         https://bugs.webkit.org/show_bug.cgi?id=56499
1859
1860         Newer versions of mechanize support HTTPS proxies, which is necessary
1861         for people using webkit-patch behind firewalls.
1862
1863         * Scripts/webkitpy/common/system/autoinstall.py:
1864         * Scripts/webkitpy/thirdparty/__init__.py:
1865
1866 2011-03-16  Sam Weinig  <sam@webkit.org>
1867
1868         Reviewed by Adam Roben.
1869
1870         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
1871         https://bugs.webkit.org/show_bug.cgi?id=56541
1872
1873         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1874         (WTR::InjectedBundlePage::willSendRequestForFrame):
1875         Check for an empty host in addition to a null host.  This bug was introduced
1876         when porting off of the KURL code and onto the WKURLRef version.
1877
1878 2011-03-16  Sam Weinig  <sam@webkit.org>
1879
1880         Reviewed by Adam Roben.
1881
1882         Add Lucas Forschler to the list of WebKit committers.
1883
1884         * Scripts/webkitpy/common/config/committers.py:
1885
1886 2011-03-16  Sam Weinig  <sam@webkit.org>
1887
1888         Reviewed upon and dictated through Adam Roben.
1889
1890         Escape crashing function names in results.html. This fixes an issue
1891         when a crash involves a type with templates.
1892
1893         * Scripts/old-run-webkit-tests:
1894
1895 2011-03-16  Daniel Sievers  <sievers@google.com>
1896
1897         Reviewed by James Robinson.
1898
1899         Add setting to always force compositing mode
1900         https://bugs.webkit.org/show_bug.cgi?id=56156
1901
1902         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1903         (main):
1904         * DumpRenderTree/chromium/TestShell.cpp:
1905         (TestShell::TestShell):
1906         (TestShell::resetWebSettings):
1907         * DumpRenderTree/chromium/TestShell.h:
1908         (TestShell::setForceCompositingMode):
1909         * DumpRenderTree/chromium/WebPreferences.cpp:
1910         (WebPreferences::reset):
1911         (WebPreferences::applyTo):
1912         * DumpRenderTree/chromium/WebPreferences.h:
1913
1914 2011-03-15  Hayato Ito  <hayato@chromium.org>
1915
1916         Reviewed by Ojan Vafai.
1917
1918         Ignore files that will be used by reftests in old-run-webkit-tests.
1919
1920         https://bugs.webkit.org/show_bug.cgi?id=55936
1921
1922         * Scripts/old-run-webkit-tests:
1923
1924 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
1925
1926         Reviewed by Adam Roben.
1927
1928         Function relativeScriptsDir doesn't return the correct relative
1929         Scripts directory.
1930
1931         * Scripts/webkitdirs.pm:
1932         (relativeScriptsDir): Ensure we use the directory that contains
1933         webkitdirs.pm, not the one that contains the original script that
1934         was invoked.
1935
1936 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1937
1938         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
1939         fix to link against the Security framework after recent WebKitSystemInterface changes.
1940
1941         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1942         (LayoutTestController::originsWithLocalStorage):
1943         * wx/build/settings.py:
1944         * wx/build/waf_extensions.py:
1945
1946 2011-03-15  Sam Weinig  <sam@webkit.org>
1947
1948         Reviewed by Darin Adler.
1949
1950         Add script to convert a patch to a prettypatch and show in the default browser
1951         https://bugs.webkit.org/show_bug.cgi?id=56416
1952
1953         This can be used either like
1954             $ svn-create-patch | show-pretty-diff
1955         or
1956             $ show-pretty-diff patch.diff
1957
1958         * Scripts/show-pretty-diff: Added.
1959
1960 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
1961
1962         Rubber-stamped by Adam Roben.
1963
1964         Adding myself as a reviewer.
1965
1966         * Scripts/webkitpy/common/config/committers.py:
1967
1968 2011-03-15  Anders Carlsson  <andersca@apple.com>
1969
1970         Try to fix the Windows build.
1971
1972         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1973         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1974
1975 2011-03-15  Anders Carlsson  <andersca@apple.com>
1976
1977         Reviewed by Sam Weinig.
1978
1979         Make sure that NP_Shutdown is always the last NPP function called
1980         https://bugs.webkit.org/show_bug.cgi?id=56391
1981
1982         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
1983
1984         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1985         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1986         (PluginTest::PluginTest):
1987         (PluginTest::NP_Shutdown):
1988         (PluginTest::registerNPShutdownFunction):
1989         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1990         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
1991         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
1992         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1993         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
1994         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
1995         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
1996         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
1997         (NPDeallocateCalledBeforeNPShutdown::shutdown):
1998         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1999         (NP_Shutdown):
2000         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2001         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2002         * GNUmakefile.am:
2003
2004 2011-03-15  Ilya Sherman  <isherman@chromium.org>
2005
2006         Reviewed by Tony Chang.
2007
2008         Autofilled form elements are assigned fixed background color but not text color
2009         https://bugs.webkit.org/show_bug.cgi?id=48382
2010
2011         * DumpRenderTree/LayoutTestController.cpp:
2012         (setAutofilledCallback): Added.
2013         (LayoutTestController::staticFunctions):
2014         * DumpRenderTree/LayoutTestController.h:
2015         * DumpRenderTree/chromium/LayoutTestController.cpp:
2016         (LayoutTestController::LayoutTestController):
2017         (LayoutTestController::setAutofilled): Added.
2018         * DumpRenderTree/chromium/LayoutTestController.h:
2019         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2020         (LayoutTestController::setAutofilled): Added.
2021         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2022         (LayoutTestController::setAutofilled): Added.
2023         (LayoutTestController::setValueForUser): Style tweak.
2024         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2025         (LayoutTestController::setAutofilled): Added (stub).
2026         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2027         (LayoutTestController::setAutofilled): Added (stub).
2028
2029 2011-03-15  Dan Bernstein  <mitz@apple.com>
2030
2031         Build fix after r81135.
2032
2033         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2034
2035 2011-03-15  Dan Bernstein  <mitz@apple.com>
2036
2037         Build fix after r81135.
2038
2039         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2040         * WebKitTestRunner/mac/TestControllerMac.mm:
2041         * WebKitTestRunner/mac/TestInvocationMac.mm:
2042         * WebKitTestRunner/mac/main.mm:
2043
2044 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
2045
2046         Reviewed by Adam Barth.
2047
2048         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
2049         https://bugs.webkit.org/show_bug.cgi?id=56349
2050
2051         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
2052         on platforms where we use it. Copied from DumpRenderTree.pro.
2053
2054 2011-03-15  Dan Bernstein  <mitz@apple.com>
2055
2056         Build fix after r81135.
2057
2058         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2059         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
2060
2061 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
2062
2063         Reviewed by Darin Adler.
2064
2065         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
2066         info into the headers rather than in export symbol definition files, but disable it on
2067         all platforms initially so we can deal with port build issues one port at a time.
2068
2069         https://bugs.webkit.org/show_bug.cgi?id=27551
2070
2071         * DumpRenderTree/cg/ImageDiffCG.cpp:
2072         * DumpRenderTree/chromium/config.h:
2073         * DumpRenderTree/config.h:
2074         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2075         * TestWebKitAPI/TestWebKitAPIPrefix.h:
2076         * WebKitAPITest/HostWindow.cpp:
2077         * WebKitAPITest/TestsController.cpp:
2078         * WebKitAPITest/config.h: Added.
2079         * WebKitAPITest/main.cpp:
2080         * WebKitAPITest/tests/WebViewDestruction.cpp:
2081         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
2082         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2083         * WebKitTestRunner/InjectedBundle/GCController.cpp:
2084         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2085         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2086         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2087         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2088         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2089         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2090         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2091         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
2092         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
2093         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2094         * WebKitTestRunner/TestController.cpp:
2095         * WebKitTestRunner/TestInvocation.cpp:
2096         * WebKitTestRunner/config.h: Added.
2097         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2098         * WebKitTestRunner/qt/TestControllerQt.cpp:
2099         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2100         * WebKitTestRunner/qt/main.cpp:
2101         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2102         * WebKitTestRunner/win/TestControllerWin.cpp:
2103         * WebKitTestRunner/win/TestInvocationWin.cpp:
2104         * WebKitTestRunner/win/main.cpp:
2105         * wx/build/settings.py:
2106
2107 2011-03-15  Hayato Ito  <hayato@chromium.org>
2108
2109         Reviewed by Shinichiro Hamaji.
2110
2111         [NRWT] Add support for reftests to new-run-webkit-tests.
2112
2113         https://bugs.webkit.org/show_bug.cgi?id=55457
2114
2115         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2116         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2117         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2118         * Scripts/webkitpy/layout_tests/port/base.py:
2119         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2120         * Scripts/webkitpy/layout_tests/port/test.py:
2121         * Scripts/webkitpy/layout_tests/port/test_files.py:
2122         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2123
2124 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
2125
2126         Reviewed by Martin Robinson.
2127
2128         [GTK] Fix compilation warning after r80892
2129         https://bugs.webkit.org/show_bug.cgi?id=56302
2130
2131         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2132         (LayoutTestController::originsWithLocalStorage):
2133
2134 2011-03-15  Robert Hogan  <robert@webkit.org>
2135
2136         Reviewed by Adam Barth.
2137
2138         Document the qmakearg argument, and hint how to build webkit2 on Qt
2139         https://bugs.webkit.org/show_bug.cgi?id=56326
2140
2141         * Scripts/build-webkit: add --qmakearg to build-webkit --help
2142
2143 2011-03-15  Adam Roben  <aroben@apple.com>
2144
2145         Make Windows 7 Release (Tests) a core builder
2146
2147         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
2148         give it a few more days of greenness first.
2149
2150         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
2151
2152         Reviewed by Sam Weinig.
2153
2154         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2155         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
2156
2157         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2158         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
2159         Updated the core regexps to match the buildbot module. Updated the expected results to match
2160         the current set of core builders.
2161
2162 2011-03-14  Adam Roben  <aroben@apple.com>
2163
2164         Add forgotten file from r81116
2165
2166         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
2167
2168 2011-03-14  Sam Weinig  <sam@webkit.org>
2169
2170         Reviewed by Adam Roben.
2171
2172         about:blank fake responses don't get serialized when sent the UIProcess
2173         <rdar://problem/9108119>
2174         https://bugs.webkit.org/show_bug.cgi?id=56357
2175
2176         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
2177         (TestWebKitAPI::decidePolicyForResponse):
2178         (TestWebKitAPI::TEST):
2179         Add test that loads of about:blank have a response with a MIMEType of text/html.
2180
2181         * TestWebKitAPI/PlatformUtilities.h:
2182         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2183         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2184         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2185         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2186         Add helper to get the MIMEType from a WKURLResponse.
2187
2188         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2189         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2190         Add new files.
2191
2192 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
2193
2194         Reviewed by Kenneth Rohde Christiansen.
2195
2196         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
2197         https://bugs.webkit.org/show_bug.cgi?id=56006
2198
2199         * QtTestBrowser/launcherwindow.cpp:
2200         (LauncherWindow::initializeView):
2201         * QtTestBrowser/main.cpp:
2202         (LauncherApplication::handleUserOptions):
2203
2204 2011-03-14  James Kozianski  <koz@chromium.org>
2205
2206         Reviewed by Ojan Vafai.
2207
2208         Add method to make BuildBot return test outputs
2209         https://bugs.webkit.org/show_bug.cgi?id=54374
2210
2211         The Builder.latest_cached_build will be used by the new rebaseline
2212         script to determine the build to use baselines from.
2213
2214         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2215         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2216
2217 2011-03-14  Adam Roben  <aroben@apple.com>
2218
2219         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
2220
2221         Reviewed by Sam Weinig.
2222
2223         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
2224         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
2225         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
2226         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
2227         ensure the web process is initialized, then ask the bundle to run the test and assert that
2228         it succeeded.
2229
2230         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
2231         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
2232         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
2233         handle a given URL.
2234         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
2235         URL type cannot be handled).
2236         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
2237         result.
2238
2239         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2240         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2241         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2242         Added new files to the project.
2243
2244 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2245
2246         Unreviewed, rolling out r81094.
2247         http://trac.webkit.org/changeset/81094
2248         https://bugs.webkit.org/show_bug.cgi?id=56355
2249
2250         Broke the chromium DRT related build. (Requested by dave_levin
2251         on #webkit).
2252
2253         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2254         (main):
2255         * DumpRenderTree/chromium/LayoutTestController.cpp:
2256         (LayoutTestController::LayoutTestController):
2257         (LayoutTestController::layerTreeAsText):
2258         * DumpRenderTree/chromium/LayoutTestController.h:
2259         * DumpRenderTree/chromium/TestShell.cpp:
2260         (TestShell::runFileTest):
2261         (TestShell::dump):
2262         * DumpRenderTree/chromium/TestShell.h:
2263         (TestParams::TestParams):
2264
2265 2011-03-14  Daniel Sievers  <sievers@google.com>
2266
2267         Reviewed by Simon Fraser.
2268
2269         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2270         https://bugs.webkit.org/show_bug.cgi?id=56139
2271
2272         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2273         (main):
2274         * DumpRenderTree/chromium/LayoutTestController.cpp:
2275         (LayoutTestController::LayoutTestController):
2276         (LayoutTestController::layerTreeAsText):
2277         * DumpRenderTree/chromium/LayoutTestController.h:
2278         (LayoutTestController::setShowDebugLayerTree):
2279         * DumpRenderTree/chromium/TestShell.cpp:
2280         (TestShell::runFileTest):
2281         (TestShell::dump):
2282         * DumpRenderTree/chromium/TestShell.h:
2283         (TestParams::TestParams):
2284
2285 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2286
2287         Reviewed by Adam Roben.
2288
2289         [Qt][WK2]Unbreak InjectedBundle on Qt
2290         https://bugs.webkit.org/show_bug.cgi?id=54109
2291
2292         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2293         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
2294         API's instead of KURL to analyze the URL.
2295         * WebKitTestRunner/StringFunctions.h:
2296         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
2297         in the WebKitTestRunner project.
2298         (WTR::toWK): Use adoptWK.
2299         (WTR::operator<<): Added helper for printing a WKURL.
2300         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
2301         against WebCore.
2302
2303 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2304
2305         Reviewed by Kenneth Rohde Christiansen.
2306
2307         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
2308         https://bugs.webkit.org/show_bug.cgi?id=56321
2309
2310         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
2311         to the list of exceptions for WebKit2 C API headers.
2312
2313 2011-03-14  Adam Roben  <aroben@apple.com>
2314
2315         Show the list of recent leaky builds in reverse chronological order
2316
2317         Previously they were being shown in a deterministic but surprising order based on
2318         lexicographically sorting the build offsets (-1, -10, -2, -3...).
2319
2320         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
2321
2322         Reviewed by Darin Adler.
2323
2324         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2325         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
2326         callback.
2327
2328 2011-03-14  Adam Roben  <aroben@apple.com>
2329
2330         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
2331
2332         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
2333         analyze
2334
2335         Reviewed by David Kilzer and Joe Pecoraro.
2336
2337         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2338         (#url-prompt): Made this a bit taller to make room for the list of builds.
2339
2340         (#recent-builds-loading-indicator):
2341         (#recent-builds-list):
2342         Added styles for the build list and loading indicator.
2343
2344         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2345         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
2346         it. This will unescape it.
2347         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
2348         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
2349         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
2350         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
2351         prompt UI.
2352         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
2353         now also used when a recent build is clicked.
2354
2355         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
2356         (RecentBuildsLoader): Store the callback.
2357         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
2358         builder. Find the revision number, leak count, and results URL for each one. Pass the
2359         resulting info to our callback.
2360
2361         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
2362         (range): Added this helper function to return an array containing the integers [0, n).
2363
2364         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
2365         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
2366
2367 2011-03-14  Mark Rowe  <mrowe@apple.com>
2368
2369         Reviewed by Adam Roben.
2370
2371         Fix two memory leaks within LayoutTestController's storage support.
2372
2373         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2374         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
2375         by JSStringCreateWithCFString.
2376         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
2377         allocate.
2378
2379 2011-03-14  Mark Rowe  <mrowe@apple.com>
2380
2381         Reviewed by Oliver Hunt.
2382
2383         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
2384
2385         * DumpRenderTree/LayoutTestController.cpp:
2386         (LayoutTestController::staticFunctions): Remove duplicate entries.
2387
2388 2011-03-14  Alice Liu  <alice.liu@apple.com>
2389
2390         Reviewed by Dan Bernstein.
2391
2392         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
2393
2394         * DumpRenderTree/mac/PerlSupport/Makefile:
2395         Add whitespace when joining "-arch" with the architectures passed in as arguments.
2396
2397 2011-03-14  Daniel Bates  <dbates@rim.com>
2398
2399         https://bugs.webkit.org/show_bug.cgi?id=55438
2400         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
2401         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
2402
2403         * Scripts/build-webkit:
2404
2405 2011-03-14  Daniel Bates  <dbates@rim.com>
2406
2407         Reviewed by David Kilzer.
2408
2409         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
2410         https://bugs.webkit.org/show_bug.cgi?id=55438
2411
2412         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
2413         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
2414         CMake arguments for feature defines.
2415
2416         * Scripts/build-webkit:
2417           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
2418           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
2419           - Sorted forward declarations.
2420           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
2421             Modified call sites as needed.
2422         * Scripts/webkitdirs.pm:
2423           - Added cleanCMakeGeneratedProject() to clean a CMake build.
2424           - Added buildCMakeGeneratedProject() to build using generated build system.
2425           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
2426           - Added generateBuildSystemFromCMakeProject() to generate the build system from
2427             a CMake project.
2428           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
2429
2430 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
2431
2432         Reviewed by Steve Block.
2433
2434         Detach Geolocation from Frame when Page destroyed.
2435         https://bugs.webkit.org/show_bug.cgi?id=52877
2436
2437         Extend the layout test controller to expose the number of pending
2438         geolocation requests, so that we can test that the requests have
2439         been cancelled on page close.
2440
2441         * DumpRenderTree/LayoutTestController.cpp:
2442         (numberOfPendingGeolocationPermissionRequestsCallback):
2443         (LayoutTestController::staticFunctions):
2444         * DumpRenderTree/LayoutTestController.h:
2445         * DumpRenderTree/chromium/LayoutTestController.cpp:
2446         (LayoutTestController::LayoutTestController):
2447         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2448         * DumpRenderTree/chromium/LayoutTestController.h:
2449         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2450         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2451         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2452         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2453         * DumpRenderTree/mac/UIDelegate.h:
2454         * DumpRenderTree/mac/UIDelegate.mm:
2455         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2456         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2457         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2458         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2459         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2460         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2461         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2462         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2463
2464
2465 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2466
2467         Unreviewed. Modify my email address in committers.py.
2468
2469         * Scripts/webkitpy/common/config/committers.py:
2470
2471 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
2472
2473         Reviewed by Kenneth Rohde Christiansen.
2474
2475         [Qt] QtLauncher does not load the same set of fonts as the DRT
2476         https://bugs.webkit.org/show_bug.cgi?id=34959
2477
2478         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
2479         When this option is used the webkit fonts are loaded the same
2480         as they are in DumpRenderTree.  This option can be used on
2481         QtTestBrowser and run-launcher.  It can only be used
2482         on Linux systems with FcInit and is configured as such.
2483
2484         * QtTestBrowser/launcherwindow.h:
2485         (WindowOptions::WindowOptions):
2486         * QtTestBrowser/main.cpp:
2487         (initWebKitTestFonts):
2488         (launcherMain):
2489         (LauncherApplication::handleUserOptions):
2490
2491 2011-03-12  Dan Bernstein  <mitz@apple.com>
2492
2493         Reviewed by Mark Rowe.
2494
2495         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
2496         DumpRenderTree is being built for.
2497
2498         * DumpRenderTree/mac/PerlSupport/Makefile:
2499
2500 2011-03-12  Dan Bernstein  <mitz@apple.com>
2501
2502         Suggested by Mark Rowe.
2503
2504         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
2505         as they were before r80915.
2506
2507 2011-03-12  Anders Carlsson  <andersca@apple.com>
2508
2509         Reviewed by Sam Weinig.
2510
2511         Should be able to download a PDF to the Downloads folder
2512         https://bugs.webkit.org/show_bug.cgi?id=56256
2513
2514         * MiniBrowser/mac/BrowserWindowController.m:
2515         (-[BrowserWindowController awakeFromNib]):
2516         * WebKitTestRunner/TestController.cpp:
2517         (WTR::TestController::createOtherPage):
2518         (WTR::TestController::initialize):
2519         Update for API changes.
2520
2521 2011-03-11  Anton D'Auria  <adauria@apple.com>
2522
2523         Reviewed and landed by Brady Eidson.
2524
2525         https://bugs.webkit.org/show_bug.cgi?id=51878
2526         Add WebKit1 API to view and delete local storage
2527
2528         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
2529
2530         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2531         * DumpRenderTree/LayoutTestController.cpp:
2532         (syncLocalStorageCallback):
2533         (observeStorageTrackerNotificationsCallback):
2534         (deleteAllLocalStorageCallback):
2535         (deleteLocalStorageForOriginCallback):
2536         (originsWithLocalStorageCallback):
2537         (LayoutTestController::staticFunctions):
2538         * DumpRenderTree/LayoutTestController.h:
2539         * DumpRenderTree/StorageTrackerDelegate.h: Added.
2540         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
2541         (-[StorageTrackerDelegate init]):
2542         (-[StorageTrackerDelegate logNotifications:controller:]):
2543         (-[StorageTrackerDelegate originModified:]):
2544         (-[StorageTrackerDelegate dealloc]):
2545         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
2546         * DumpRenderTree/chromium/LayoutTestController.cpp:
2547         (LayoutTestController::LayoutTestController):
2548         (LayoutTestController::deleteAllLocalStorage):
2549         (LayoutTestController::originsWithLocalStorage):
2550         (LayoutTestController::deleteLocalStorageForOrigin):
2551         (observeStorageTrackerNotifications):
2552         (syncLocalStorage):
2553         * DumpRenderTree/chromium/LayoutTestController.h:
2554         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2555         (LayoutTestController::originsWithLocalStorage):
2556         (LayoutTestController::deleteAllLocalStorage):
2557         (LayoutTestController::deleteLocalStorageForOrigin):
2558         (LayoutTestController::observeStorageTrackerNotifications):
2559         (LayoutTestController::syncLocalStorage):
2560         * DumpRenderTree/mac/DumpRenderTree.mm:
2561         (resetDefaultsToConsistentValues):
2562         (allocateGlobalControllers):
2563         (releaseGlobalControllers):
2564         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2565         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2566         (LayoutTestController::syncLocalStorage):
2567         (LayoutTestController::observeStorageTrackerNotifications):
2568         (LayoutTestController::deleteAllLocalStorage):
2569         (LayoutTestController::originsWithLocalStorage):
2570         (LayoutTestController::deleteLocalStorageForOrigin):
2571         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2572         (LayoutTestController::originsWithLocalStorage):
2573         (LayoutTestController::deleteAllLocalStorage):
2574         (LayoutTestController::deleteLocalStorageForOrigin):
2575         (LayoutTestController::observeStorageTrackerNotifications):
2576         (LayoutTestController::syncLocalStorage):
2577         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2578         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2579         (LayoutTestController::clearAllApplicationCaches):
2580         (LayoutTestController::syncLocalStorage):
2581         (LayoutTestController::observeStorageTrackerNotifications):
2582         (LayoutTestController::clearAllDatabases):
2583         (LayoutTestController::deleteAllLocalStorage):
2584         (LayoutTestController::originsWithLocalStorage):
2585         (LayoutTestController::deleteLocalStorageForOrigin):
2586         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2587         (LayoutTestController::syncLocalStorage):
2588         (LayoutTestController::observeStorageTrackerNotifications):
2589         (LayoutTestController::clearAllDatabases):
2590         (LayoutTestController::deleteAllLocalStorage):
2591         (LayoutTestController::originsWithLocalStorage):
2592         (LayoutTestController::deleteLocalStorageForOrigin):
2593
2594 2011-03-11  Jessie Berlin  <jberlin@apple.com>
2595
2596         Reviewed by Adam Roben.
2597
2598         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
2599         Process has finished launching.
2600         https://bugs.webkit.org/show_bug.cgi?id=56208
2601
2602         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
2603         (TestWebKitAPI::TEST):
2604         Test that calling WKContextClearResourceCaches works with both options when called before
2605         the Web Process is valid.
2606
2607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2608         Add the new test.
2609         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2610         Ditto.
2611
2612 2011-03-11  Adam Roben  <aroben@apple.com>
2613
2614         Make it possible to view all leaks from a build at once in Leaks Viewer
2615
2616         You can now give Leaks Viewer the URL of a build results page (e.g.,
2617         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
2618         will load all the leaks files from that build.
2619
2620         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
2621         files from a particular build at once, rather than one at a time
2622
2623         Reviewed by David Kilzer.
2624
2625         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
2626         (LeaksLoader): Initialize our properties.
2627         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
2628         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
2629         from that page.
2630         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
2631         so it can provide feedback. Then load each one and pass it to the client.
2632         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
2633         it into a DOM, pull out all the links to leaks files, and load each one.
2634
2635         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
2636         (LeaksParser): Initialize our worker.
2637         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
2638
2639         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
2640         This code mostly came from Worker.js.
2641         (LeaksParserWorker): Initialize our profile.
2642         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
2643         profile.
2644         (LeaksParserWorker.prototype._parseLeaks):
2645         (LeaksParserWorker.prototype._createNode):
2646         (LeaksParserWorker.prototype._incorporateLeaks):
2647         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
2648         version of createProfile which adds to this.profile instead of making a new profile each
2649         time.
2650         (onmessage): Parse the file and send back the new profile.
2651
2652         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2653         (#loading-indicator):
2654         (#spinner):
2655         (#loading-indicator-label):
2656         Tweaked styles to accomodate a longer label.
2657
2658         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2659         (LeaksViewer.loaded): Set up a loader and parser.
2660
2661         (LeaksViewer.get filesLeftToParse):
2662         (LeaksViewer.set filesLeftToParse):
2663         Added these simple accessors.
2664
2665         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
2666         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
2667         the parser.
2668         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
2669         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
2670         _loadLeaksFromURL function).
2671         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
2672         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
2673         loading indicator, including the number of files being loaded.
2674         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
2675         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
2676         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
2677         _loadingIndicatorText.
2678
2679         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
2680         (getResource): Moved here from LeaksViewer.js.
2681
2682         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
2683         LeaksParserWorker.js.
2684
2685         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
2686         files, added a #loading-indicator-label element, and tweaked the prompt wording.
2687
2688 2011-03-11  Adam Roben  <aroben@apple.com>
2689
2690         Don't trigger a build when build.webkit.org's HTML files are modified
2691
2692         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
2693
2694         Reviewed by Dan Bernstein.
2695
2696         * Scripts/webkitpy/common/config/build.py:
2697         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
2698         directories that shouldn't trigger builds. Re-sorted the list.
2699
2700         * Scripts/webkitpy/common/config/build_unittest.py:
2701         (ShouldBuildTest): Added a test to cover the above change.
2702
2703 2011-03-11  Adam Roben  <aroben@apple.com>
2704
2705         Roll out r80848
2706
2707         It was accidentally committed.
2708
2709         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2710         (LeaksViewer._loadLeaksFromURL):
2711
2712 2011-03-11  Tony Chang  <tony@chromium.org>
2713
2714         Reviewed by Ojan Vafai.
2715
2716         kill hung lighttpd processes on the chromium win bot
2717         https://bugs.webkit.org/show_bug.cgi?id=56152
2718
2719         Sometimes this process doesn't exit and it holds on to
2720         a log file that we can't delete or copy, causing the tests
2721         to go red.
2722
2723         * BuildSlaveSupport/win/kill-old-processes:
2724
2725 2011-03-11  Ilya Sherman  <isherman@chromium.org>
2726
2727         Reviewed by Kent Tamura.
2728
2729         [Chromium] missing HTMLInputElement::setValueForUser() to tests
2730         https://bugs.webkit.org/show_bug.cgi?id=55854
2731
2732         * DumpRenderTree/chromium/LayoutTestController.cpp:
2733         (LayoutTestController::LayoutTestController):
2734         (LayoutTestController::setValueForUser): Added.
2735         * DumpRenderTree/chromium/LayoutTestController.h:
2736
2737 2011-03-10  Peter Kasting  <pkasting@google.com>
2738
2739         Reviewed by Dimitri Glazkov.
2740
2741         Clean up some gross code in TestShellWin.cpp.  No functional change.
2742         https://bugs.webkit.org/show_bug.cgi?id=56048
2743
2744         * DumpRenderTree/chromium/TestShellWin.cpp:
2745         (checkLayoutTestSystemDependencies):
2746
2747 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
2748
2749         Reviewed by Laszlo Gombos.
2750
2751         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
2752
2753         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2754         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
2755
2756 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2757
2758         Reviewed by Kenneth Rohde Christiansen.
2759
2760         [EFL] Make single backing store the default for EWebLauncher
2761         https://bugs.webkit.org/show_bug.cgi?id=55753
2762
2763         Set single backing store the default for EWebLauncher.
2764
2765         * EWebLauncher/main.c:
2766         (main):
2767
2768 2011-03-10  Adam Roben  <aroben@apple.com>
2769
2770         Ignore errors from files being held open when creating a test result archive
2771
2772         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
2773         fails to delete the results directory
2774
2775         Reviewed by Mark Rowe.
2776
2777         * BuildSlaveSupport/test-result-archive:
2778         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
2779         thrown when a process is holding a file open.
2780
2781 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2782
2783         Unreviewed, rolling out r80701.
2784         http://trac.webkit.org/changeset/80701
2785         https://bugs.webkit.org/show_bug.cgi?id=56126
2786
2787         fast/dom/Geolocation/window-close-crash.html fails on Snow
2788         Leopard release builds (Requested by mihaip on #webkit).
2789
2790         * DumpRenderTree/LayoutTestController.cpp:
2791         (LayoutTestController::staticFunctions):
2792         * DumpRenderTree/LayoutTestController.h:
2793         * DumpRenderTree/chromium/LayoutTestController.cpp:
2794         (LayoutTestController::LayoutTestController):
2795         * DumpRenderTree/chromium/LayoutTestController.h:
2796         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2797         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2798         * DumpRenderTree/mac/UIDelegate.h:
2799         * DumpRenderTree/mac/UIDelegate.mm:
2800         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2801         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2802         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2803         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2804
2805 2011-03-10  Philippe Normand  <pnormand@igalia.com>
2806
2807         Reviewed by Gustavo Noronha Silva.
2808
2809         [GTK] run-gtk-tests doesn't fail if a test crashes
2810         https://bugs.webkit.org/show_bug.cgi?id=56089
2811
2812         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
2813         even if a test crashes. So run the tests individually and if a
2814         test fails remember its exit code so run-gtk-test fails too, if
2815         required.
2816
2817 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
2818
2819         Reviewed by Dmitry Titov.
2820
2821         Detach Geolocation from Frame when Page destroyed.
2822         https://bugs.webkit.org/show_bug.cgi?id=52877
2823
2824         Extend the layout test controller to expose the number of pending
2825         geolocation requests, so that we can test that the requests have
2826         been cancelled on page close.
2827
2828         * DumpRenderTree/LayoutTestController.cpp:
2829         (numberOfPendingGeolocationPermissionRequestsCallback):
2830         (LayoutTestController::staticFunctions):
2831         * DumpRenderTree/LayoutTestController.h:
2832         * DumpRenderTree/chromium/LayoutTestController.cpp:
2833         (LayoutTestController::LayoutTestController):
2834         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2835         * DumpRenderTree/chromium/LayoutTestController.h:
2836         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2837         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2838         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2839         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2840         * DumpRenderTree/mac/UIDelegate.h:
2841         * DumpRenderTree/mac/UIDelegate.mm:
2842         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2843         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2844         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2845         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2846         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2847         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2848         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2849         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2850
2851
2852 2011-03-09  Adam Roben  <aroben@apple.com>
2853
2854         Hide Leaks Viewer's URL prompt by default
2855
2856         We will show it as needed. I think I left it visible by default by accident after doing some
2857         testing.
2858
2859         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
2860         URL is passed as a query parameter, but does
2861
2862         Reviewed by Simon Fraser.
2863
2864         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
2865
2866 2011-03-09  Adam Roben  <aroben@apple.com>
2867
2868         Don't use Element.classList or box-shadow in Leaks Viewer
2869
2870         They aren't supported by Safari 5. Luckily we have substitutes for them!
2871
2872         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
2873
2874         Reviewed by Simon Fraser.
2875
2876         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2877         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
2878
2879         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2880         (LeaksViewer.urlPromptButtonClicked):
2881         (LeaksViewer._displayURLPrompt):
2882         (LeaksViewer._setLoadingIndicatorHidden):
2883         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
2884
2885 2011-03-09  Adam Roben  <aroben@apple.com>
2886
2887         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
2888
2889         Rubber-stamped by David Kilzer.
2890
2891         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2892
2893 2011-03-09  Adam Roben  <aroben@apple.com>
2894
2895         Add a Leaks Viewer tool to build.webkit.org
2896
2897         This tool parses leaks from the files generated by the leaks bot and displays them in a
2898         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
2899         code).
2900
2901         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
2902         be passed to the tool via the "url" query parameter.
2903
2904         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
2905         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
2906         Inspector's Heavy profile view. But it's still pretty useful as-is.
2907
2908         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
2909
2910         Reviewed by Darin Adler.
2911
2912         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
2913         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
2914         (#url-prompt): This is the prompt itself.
2915
2916         (#loading-indicator):
2917         (#loading-indicator > img):
2918         These show a spinner in the bottom-right when we're loading a leaks file.
2919
2920         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
2921         as percentages.
2922
2923         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
2924         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
2925         URL if one wasn't given to us as a query parameter).
2926
2927         (LeaksViewer.get loading):
2928         (LeaksViewer.set loading):
2929         (LeaksViewer.get url):
2930         (LeaksViewer.set url):
2931         Pretty simple accessors.
2932
2933         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
2934         prompt.
2935         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
2936         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
2937         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
2938         the profile to the Web Inspector code once it's been created.
2939         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
2940         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
2941         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
2942         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
2943
2944         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
2945         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
2946         (ProfilerAgent.getProfile): Store the callback.
2947         (ProfilerAgent.profileReady): Call the callback.
2948         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
2949         count and total leak counts as real values, not percentages or milliseconds.
2950
2951         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
2952         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
2953         (parseLeaks): Extract call stacks out of a leaks file.
2954         (createNode): Helper function to create a new empty profile node.
2955         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
2956         WebInspector.ProfileView.
2957
2958         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
2959
2960 2011-03-09  Dan Bernstein  <mitz@apple.com>
2961
2962         Reviewed by Adam Roben.
2963
2964         Combine multiple --ignore-tests values
2965         https://bugs.webkit.org/show_bug.cgi?id=56016
2966
2967         * Scripts/old-run-webkit-tests:
2968
2969 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
2970
2971         Reviewed by David Levin.
2972
2973         Adding myself to the committer file.
2974
2975         * Scripts/webkitpy/common/config/committers.py:
2976
2977 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2978
2979         Rubber-stamped by Adam Roben.
2980
2981         Fix two leaks I introduced into the API tests.
2982
2983         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2984         (TestWebKitAPI::TEST):
2985
2986 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2987
2988         Reviewed by Anders Carlsson.
2989
2990         Crash in CFNetwork visiting google.com
2991         https://bugs.webkit.org/show_bug.cgi?id=55958
2992
2993         Add a test for not trying to copy a null CFURLResponse.
2994
2995         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
2996         (TestWebKitAPI::TEST):
2997         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2998
2999 2011-03-08  Hayato Ito  <hayato@chromium.org>
3000
3001         Reviewed by Ojan Vafai.
3002
3003         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
3004
3005         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
3006
3007         https://bugs.webkit.org/show_bug.cgi?id=55450
3008
3009         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3010
3011 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3012
3013         Reviewed by Martin Robinson.
3014
3015         [GTK] Add layoutTestController.setValueForUser() after r80412
3016         https://bugs.webkit.org/show_bug.cgi?id=55862
3017
3018         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3019         (LayoutTestController::setValueForUser): Implement setValueForUser()
3020
3021 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
3022
3023         Reviewed by Adam Barth.
3024
3025         Add script_shell_command to WebKitPort
3026         https://bugs.webkit.org/show_bug.cgi?id=55925
3027
3028         Add a central place where we generate the shell command from the script name.
3029         This function will be used later to detect the correct script interpreter on Win32.
3030
3031         * Scripts/webkitpy/common/config/ports.py:
3032         * Scripts/webkitpy/layout_tests/port/base.py:
3033         * Scripts/webkitpy/tool/steps/abstractstep.py:
3034         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3035
3036 2011-03-07  Ojan Vafai  <ojan@chromium.org>
3037
3038         Reviewed by Adam Barth.
3039
3040         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
3041         https://bugs.webkit.org/show_bug.cgi?id=55749
3042
3043         * Scripts/webkitpy/tool/commands/upload.py:
3044         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3045         * Scripts/webkitpy/tool/steps/__init__.py:
3046         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
3047         * Scripts/webkitpy/tool/steps/options.py:
3048
3049 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
3050
3051         Reviewed by David Levin.
3052
3053         Add support for DataTransferItems
3054         https://bugs.webkit.org/show_bug.cgi?id=55115
3055
3056         Enable data transfer items in DRT.
3057
3058         * DumpRenderTree/chromium/TestShell.cpp:
3059         (TestShell::TestShell):
3060
3061 2011-03-06  Ojan Vafai  <ojan@chromium.org>
3062
3063         Reviewed by Tony Chang.
3064
3065         [test dashboard] pull treemap files
3066         https://bugs.webkit.org/show_bug.cgi?id=55852
3067
3068         * TestResultServer/handlers/dashboardhandler.py:
3069
3070 2011-03-03  Hayato Ito  <hayato@chromium.org>
3071
3072         Reviewed by Mihai Parparita.
3073
3074         [NRWT] Clear output image file used by DumpRenderTree to make sure the
3075         previous image should not be used in the ChromiumDriver.
3076
3077         Also make sure that output image from the ChromiumDriver should be ''
3078         (empty string) if a test crashes for consistency with the WebKitDriver
3079         implementation.
3080
3081         https://bugs.webkit.org/show_bug.cgi?id=55746
3082
3083         * Scripts/webkitpy/layout_tests/port/chromium.py:
3084
3085 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
3086
3087         Reviewed by Martin Robinson.
3088
3089         [Gtk] fast/js/navigator-language.html fails locally
3090         https://bugs.webkit.org/show_bug.cgi?id=55880
3091
3092         Add LANG variable to the clean environment when running
3093         old-run-webkit-tests script.
3094
3095         * Scripts/old-run-webkit-tests:
3096
3097 2011-03-07  Tony Chang  <tony@chromium.org>
3098
3099         Reviewed by Mihai Parparita.
3100
3101         [Chromium] Find .checksum files without .pngs and vice-versa
3102         https://bugs.webkit.org/show_bug.cgi?id=55236
3103
3104         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
3105             mismatched results.
3106
3107 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
3108
3109         Reviewed by Beth Dakin.
3110
3111         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
3112         https://bugs.webkit.org/show_bug.cgi?id=55706
3113
3114         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
3115
3116         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3117         (AccessibilityController::focusedElement):
3118            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this
3119            because it could change at any time.
3120         (AccessibilityController::rootElement):
3121
3122 2011-03-07  Sam Weinig  <sam@webkit.org>
3123
3124         Reviewed by Anders Carlsson.
3125
3126         Add unableToImplementPolicy callback for WebKit2 policy client
3127         <rdar://problem/9071902>
3128         https://bugs.webkit.org/show_bug.cgi?id=55884
3129
3130         * MiniBrowser/mac/BrowserWindowController.m:
3131         (-[BrowserWindowController awakeFromNib]):
3132         Update policy client initialization struct for new member.
3133
3134 2011-03-07  Sam Weinig  <sam@webkit.org>
3135
3136         Reviewed by Anders Carlsson.
3137
3138         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
3139         https://bugs.webkit.org/show_bug.cgi?id=55827
3140
3141         * MiniBrowser/mac/BrowserWindowController.m:
3142         (decidePolicyForResponse):
3143         (-[BrowserWindowController awakeFromNib]):
3144         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3145         (TestWebKitAPI::decidePolicyForResponse):
3146         (TestWebKitAPI::TEST):
3147         Update tools for new name.
3148
3149 2011-03-06  Daniel Bates  <dbates@rim.com>
3150
3151         Reviewed by Eric Seidel and David Kilzer.
3152
3153         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
3154         https://bugs.webkit.org/show_bug.cgi?id=55503
3155
3156         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
3157         in checkForJavaSDK().
3158
3159         Also, remove extraneous space in function prototype for unlinkZeroFiles.
3160
3161         * Scripts/build-webkit:
3162
3163 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
3164
3165         Reviewed by Sam Weinig.
3166
3167         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
3168
3169         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3170         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
3171             by willSendRequestForFrame. The API expects a retained reference to the URL request.
3172
3173 2011-03-05  Ilya Sherman  <isherman@chromium.org>
3174
3175         Reviewed by Darin Adler.
3176
3177         HTMLInputElement::setValue() should schedule change event when the element is focused
3178         In service of https://code.google.com/p/chromium/issues/detail?id=42716
3179         https://bugs.webkit.org/show_bug.cgi?id=53160
3180
3181         * DumpRenderTree/LayoutTestController.cpp:
3182         (setValueForUserCallback):
3183         (LayoutTestController::staticFunctions):
3184         * DumpRenderTree/LayoutTestController.h:
3185         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3186         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3187         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3188         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
3189         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3190         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3191         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3192         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3193         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3194         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3195
3196 2011-03-04  Mark Rowe  <mrowe@apple.com>
3197
3198         Reviewed by Alexey Proskuryakov.
3199
3200         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
3201
3202         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
3203
3204         * DumpRenderTree/mac/CheckedMalloc.cpp:
3205         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
3206         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
3207         and then restore the initial protection flags when we're done.
3208
3209 2011-03-04  Evan Martin  <evan@chromium.org>
3210
3211         Reviewed by Tony Chang.
3212
3213         [gdb] pretty-print KURL in gdb
3214         https://bugs.webkit.org/show_bug.cgi?id=55788
3215
3216         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
3217         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
3218         pretty-printing.
3219
3220 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3221
3222         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
3223
3224         Reviewed by Darin Adler.
3225
3226         * TestWebKitAPI/JavaScriptTest.cpp:
3227         (TestWebKitAPI::javaScriptCallback):
3228         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3229         (TestWebKitAPI::didRunJavaScript):
3230         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3231         (TestWebKitAPI::nullJavaScriptCallback):
3232         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3233         (TestWebKitAPI::didRunJavaScript):
3234
3235 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3236
3237         Make run-api-tests show failed if a test fails.
3238
3239         https://webkit.org/b/55725
3240
3241         Reviewed by Sam Weinig.
3242
3243         * Scripts/run-api-tests:
3244         (runTest): Remove "my" from the nested $result assignment so the
3245         check outside the condition sees the real result.
3246
3247 2011-03-02  MORITA Hajime  <morrita@google.com>
3248
3249         Reviewed by Kent Tamura.
3250
3251         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
3252         https://bugs.webkit.org/show_bug.cgi?id=55434
3253
3254         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
3255         and passed the object webkit_support::PostDelayedTask directly.
3256
3257         Note that the change keeps postTask() as is because it has a
3258         semantics taht webkit_support::PostDelayedTask() has; It jumps to
3259         the main thread.
3260
3261         * DumpRenderTree/chromium/Task.cpp:
3262         (postDelayedTask):
3263         * DumpRenderTree/chromium/Task.h:
3264         (WebTask::Run):
3265
3266 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3267
3268         Reviewed by Kenneth Rohde Christiansen.
3269
3270         [QT] Implement mock client-based geolocation for layout testing
3271         https://bugs.webkit.org/show_bug.cgi?id=54334
3272
3273         Implement testing for Client-Based geolocation for QtWebkit.
3274
3275         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3276         (WebCore::DumpRenderTree::DumpRenderTree):
3277         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3278         (LayoutTestController::reset):
3279         (LayoutTestController::setGeolocationPermission):
3280         (LayoutTestController::setMockGeolocationError):
3281         (LayoutTestController::setMockGeolocationPosition):
3282
3283 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3284
3285         Unreviewed, rolling out r80237.
3286         http://trac.webkit.org/changeset/80237
3287         https://bugs.webkit.org/show_bug.cgi?id=55714
3288
3289         Windows bots aren't ready to be core (Requested by aroben on
3290         #webkit).
3291
3292         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3293         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3294
3295 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
3296
3297         Reviewed by Tony Chang.
3298
3299         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
3300         https://bugs.webkit.org/show_bug.cgi?id=55694
3301
3302         Fixes for interruptions in NRWT:
3303         - Make TestRunInterruptedException be pickleable correctly (the base
3304           Exception class defines a __reduce__ that does not include the reason)
3305         - Fix ordering of returned arguments from TestRunner2._run_tests
3306           (interrupted and keyboard_interrupted were reversed)
3307         - Fix cancel_workers callsites (was using old name).
3308         - In handle_exception re-raise actual exception instance that was thrown
3309
3310         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3311         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
3312         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3313         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3314
3315 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
3316
3317         Unreviewed.
3318
3319         Adding myself as a committer.
3320
3321         * Scripts/webkitpy/common/config/committers.py:
3322
3323 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
3324
3325         Reviewed by Mihai Parparita.
3326
3327         Teach sheriffbot to answer whois commands
3328         https://bugs.webkit.org/show_bug.cgi?id=55687
3329
3330         * Scripts/webkitpy/tool/bot/irc_command.py:
3331         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3332         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3333
3334 2011-03-03  Victoria Kirst  <vrk@google.com>
3335
3336         Reviewed by Eric Carlson.
3337
3338         Enable media tests in chromium-gpu/test_expectations
3339         https://bugs.webkit.org/show_bug.cgi?id=53608
3340
3341         Add media folder to the list of GPU test paths.
3342
3343         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3344
3345 2011-03-03  Adam Roben  <aroben@apple.com>
3346
3347         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
3348
3349         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
3350         incorrect parsing of absolute Windows-style file: URLs
3351
3352         Reviewed by Tim Hatcher.
3353
3354         * WebKitTestRunner/TestInvocation.cpp:
3355         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
3356         <http://webkit.org/b/55683>.
3357
3358 2011-03-03  Tony Chang  <tony@chromium.org>
3359
3360         Reviewed by Dimitri Glazkov.
3361
3362         [chromium] Run kill-old-processes on the chromium-win bot too
3363         https://bugs.webkit.org/show_bug.cgi?id=55630
3364
3365         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3366         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
3367
3368 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3369
3370         Reviewed by Martin Robinson.
3371
3372         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
3373         https://bugs.webkit.org/show_bug.cgi?id=53960
3374
3375         * DumpRenderTree/gtk/EventSender.cpp:
3376         (sendClick):
3377         (scheduleAsynchronousClickCallback):
3378
3379 2011-03-03  Adam Roben  <aroben@apple.com>
3380
3381         Look for Windows-style paths when checking whether a test is an Inspector test
3382
3383         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
3384         out or crash on Windows 7 Release (WebKit2 Tests)
3385
3386         Reviewed by Darin Adler.
3387
3388         * WebKitTestRunner/TestInvocation.cpp:
3389         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
3390         Windows.
3391
3392 2011-03-03  Adam Roben  <aroben@apple.com>
3393
3394         Make Windows 7 Release (Tests) a core builder
3395
3396         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
3397         give it a few more days of greenness first.
3398
3399         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
3400
3401         Reviewed by Andreas Kling.
3402
3403         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3404         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
3405
3406         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3407         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
3408         Updated the core regexps to match the buildbot module. Updated the expected results to match
3409         the current set of core builders.
3410
3411 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
3412
3413         Reviewed by Andreas Kling.
3414
3415         Adding myself as a reviewer.
3416
3417         * Scripts/webkitpy/common/config/committers.py:
3418
3419 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
3420
3421         Reviewed by Xan Lopez.
3422
3423         [GTK] Extended application cache database API and added unit tests file.
3424         https://bugs.webkit.org/show_bug.cgi?id=55335
3425
3426         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
3427         of webkit_application_cache_set_maximum_size due to API exposal.
3428
3429 2011-03-02  Ojan Vafai  <ojan@chromium.org>
3430
3431         Reviewed by Adam Barth.
3432
3433         make webkit-patch upload work for security bugs
3434         https://bugs.webkit.org/show_bug.cgi?id=55655
3435
3436         The problem is that we shell out to prepare-ChangeLog,
3437         which does not authenticate with bugzilla. All it needs from
3438         bugzilla is the bug title though. We just pass it through from
3439         webkit-patch instead.
3440
3441         * Scripts/prepare-ChangeLog:
3442         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3443         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3444
3445 2011-03-01  Ojan Vafai  <ojan@chromium.org>
3446
3447         Reviewed by Tony Chang.
3448
3449         [test-dashboard] make gtest JSON match layout-tests JSON
3450         https://bugs.webkit.org/show_bug.cgi?id=55556
3451
3452         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
3453         Make this code match.
3454
3455         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3456
3457 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
3458
3459         Reviewed by Tony Chang.
3460
3461         NRWT - implement Linux Hardy 64-bit port support. This involves
3462         adding support for non-'x86' architectures and updating the
3463         "deduplicate_tests" script to correctly understand that
3464         port.name() is not always equal to basename(port.baseline_path()).
3465
3466         This change introduces two new port names: 'chromium-linux-x86'
3467         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
3468         flag will cause the code to determine which one to use at
3469         runtime, just like we currently do with 'chromium-win'.
3470
3471         https://bugs.webkit.org/show_bug.cgi?id=55535
3472
3473         * Scripts/webkitpy/common/system/executive_mock.py:
3474           Handle 'return_stderr' keyword arg to run_command()
3475         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3476         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3477         * Scripts/webkitpy/layout_tests/port/base.py:
3478         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3479         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3480         * Scripts/webkitpy/layout_tests/port/factory.py:
3481         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3482
3483 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
3484
3485         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
3486         update symlinks accordingly.
3487
3488         * wx/packaging/build-mac-installer.py:
3489
3490 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3491
3492         Unreviewed, rolling out r80139.
3493         http://trac.webkit.org/changeset/80139
3494         https://bugs.webkit.org/show_bug.cgi?id=55620
3495
3496         failing and crashing tests on Snow Leopard bot (Requested by
3497         mihaip1 on #webkit).
3498
3499         * DumpRenderTree/LayoutTestController.cpp:
3500         (LayoutTestController::staticFunctions):
3501         * DumpRenderTree/LayoutTestController.h:
3502         * DumpRenderTree/chromium/LayoutTestController.cpp:
3503         (LayoutTestController::LayoutTestController):
3504         * DumpRenderTree/chromium/LayoutTestController.h:
3505         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3506         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3507         * DumpRenderTree/mac/UIDelegate.h:
3508         * DumpRenderTree/mac/UIDelegate.mm:
3509         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3510         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3511         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3512         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3513
3514 2011-03-02  Adam Roben  <aroben@apple.com>
3515
3516         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
3517
3518         This matches DumpRenderTree on Windows.
3519
3520         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
3521         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
3522         in WebKit2
3523
3524         Reviewed by Beth Dakin.
3525
3526         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3527         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
3528         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
3529
3530 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
3531
3532         Reviewed by David Levin.
3533
3534         Add feature define for data transfer items
3535         https://bugs.webkit.org/show_bug.cgi?id=55510
3536
3537         * Scripts/build-webkit:
3538
3539 2011-03-02  Adam Roben  <aroben@apple.com>
3540
3541         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
3542
3543         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
3544         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
3545         the former location, but was getting lucky on some SnowLeopard machines because symlinks
3546         were being created there pointing into DiagnosticReports. For machines without these
3547         symlinks, crash logs were not getting captured.
3548
3549         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
3550         SnowLeopard machines
3551
3552         Reviewed by Eric Seidel.
3553
3554         * Scripts/old-run-webkit-tests:
3555         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
3556
3557 2011-03-02  Adam Roben  <aroben@apple.com>
3558
3559         Don't try to capture crash logs on platforms that haven't implemented that feature
3560
3561         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
3562         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
3563
3564         Reviewed by Joseph Pecoraro.
3565
3566         * Scripts/old-run-webkit-tests:
3567         (captureSavedCrashLog): Bail if we don't have a crash log glob.
3568         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
3569         strictly required to fix bug 55504, but seems worthwhile.
3570
3571 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
3572
3573         Reviewed by Dmitry Titov.
3574
3575         Detach Geolocation from Frame when Page destroyed.
3576         https://bugs.webkit.org/show_bug.cgi?id=52877
3577
3578         Extend the layout test controller to expose the number of pending
3579         geolocation requests, so that we can test that the requests have
3580         been cancelled on page close.
3581
3582         * DumpRenderTree/LayoutTestController.cpp:
3583         (numberOfPendingGeolocationPermissionRequestsCallback):
3584         (LayoutTestController::staticFunctions):
3585         * DumpRenderTree/LayoutTestController.h:
3586         * DumpRenderTree/chromium/LayoutTestController.cpp:
3587         (LayoutTestController::LayoutTestController):
3588         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3589         * DumpRenderTree/chromium/LayoutTestController.h:
3590         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3591         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3592         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3593         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3594         * DumpRenderTree/mac/UIDelegate.h:
3595         * DumpRenderTree/mac/UIDelegate.mm:
3596         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
3597         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3598         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3599         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3600         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3601         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3602         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3603         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3604
3605
3606 2011-03-01  Kent Tamura  <tkent@chromium.org>
3607
3608         Reviewed by Dimitri Glazkov.
3609
3610         Assertion fails when a form validation bubble appears
3611         https://bugs.webkit.org/show_bug.cgi?id=55550
3612
3613         Test: fast/forms/interactive-validation-attach-assertion.html
3614
3615         * DumpRenderTree/chromium/WebPreferences.cpp:
3616         (WebPreferences::applyTo): Enable the interactive validation feature by
3617           default. This matches to Chromium browser.
3618
3619 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3620
3621         Reviewed by Kent Tamura.
3622
3623         Remove efl port style exception of Webcore/JavaScriptCore
3624         https://bugs.webkit.org/show_bug.cgi?id=55549
3625
3626         WebCore and JavaScriptCore need to adhere WebKit coding style.
3627
3628         * Scripts/webkitpy/style/checker.py:
3629
3630 2011-03-01  Tony Chang  <tony@chromium.org>
3631
3632         Reviewed by Ojan Vafai.
3633
3634         [chromium] clean up temp files on chromium-mac builder too
3635         https://bugs.webkit.org/show_bug.cgi?id=55525
3636
3637         * BuildSlaveSupport/chromium/remove-crash-logs:
3638
3639 2011-02-28  Ojan Vafai  <ojan@chromium.org>
3640
3641         Reviewed by Tony Chang.
3642
3643         wrap json in a function call to afford cross-domain loading
3644         https://bugs.webkit.org/show_bug.cgi?id=55353
3645
3646         Also delete the code that compacts the JSON. It turns out this
3647         breaks the rebaseline tool and is probably a premature optimization anyways.
3648
3649         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3650         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3651         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3652         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3653
3654 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3655
3656         Unreviewed, rolling out r80079.
3657         http://trac.webkit.org/changeset/80079
3658         https://bugs.webkit.org/show_bug.cgi?id=55547
3659
3660         "Broke the Win debug build?" (Requested by dcheng on #webkit).
3661
3662         * Scripts/build-webkit:
3663
3664 2011-03-01  Mark Rowe  <mrowe@apple.com>
3665
3666         Reviewed by Sam Weinig.
3667
3668         Update verification scripts to handle WebKit2.
3669
3670         * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
3671         * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
3672         WebKit2.
3673
3674 2011-03-01  Daniel Cheng  <dcheng@chromium.org>
3675
3676         Reviewed by David Levin.
3677
3678         Add feature define for data transfer items
3679         https://bugs.webkit.org/show_bug.cgi?id=55510
3680
3681         * Scripts/build-webkit:
3682
3683 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
3684
3685         Reviewed by Timothy Hatcher.
3686
3687         All Console Messages should be passed to ChromeClients.
3688         https://bugs.webkit.org/show_bug.cgi?id=54926
3689
3690         Update DumpRenderTree's UIDelegate to use the new console message delegate.
3691
3692         * DumpRenderTree/mac/UIDelegate.mm:
3693         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3694
3695 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3696
3697         Reviewed by Adam Barth.
3698
3699         Tragically, we stopped running the python unit tests
3700         on Chromium Win just as I was getting them to be green.
3701         This patch turns them back on.
3702
3703         https://bugs.webkit.org/show_bug.cgi?id=55521
3704
3705         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3706
3707 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3708
3709         Reviewed by Adam Roben.
3710
3711         Disable
3712         webkitpy.common.system.executive_unittest.ExecutiveTest.\
3713            test_kill_all fails on win until it can be properly triaged.
3714
3715         https://bugs.webkit.org/show_bug.cgi?id=54790
3716
3717         * Scripts/webkitpy/common/system/executive_unittest.py:
3718
3719     2011-03-01  Helder Correia  <helder@sencha.com>
3720
3721             Unreviewed. Add myself to committers.py.
3722
3723             * Scripts/webkitpy/common/config/committers.py:
3724
3725 2011-03-01  Adam Roben  <aroben@apple.com>
3726
3727         Give up if a crash log for the web process is taking too long to be saved on Windows
3728
3729         This should keep the bots from getting stuck while waiting for a crash log, if writing a
3730         crash log ever hangs or the UI process for some reason doesn't notice it's finished.
3731
3732         Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
3733         to be saved for the web process
3734
3735         Reviewed by Steve Falkenburg.
3736
3737         * WebKitTestRunner/win/TestControllerWin.cpp:
3738         (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
3739         Generalized the code slightly to handle the optional object to wait on.
3740         (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
3741         it (with a timeout) when waiting for a crash log for the web process to be saved. This will
3742         prevent us from waiting forever.
3743
3744 2011-03-01  Adam Roben  <aroben@apple.com>
3745
3746         Give WebKitLauncherWin's PDB file a name different from WebKit's
3747
3748         WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
3749         fighting over the same PDB file, meaning that one of them was going to lose and not have
3750         symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
3751
3752         Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
3753         runs (due to missing symbols)
3754
3755         Reviewed by David Kilzer.
3756
3757         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
3758         "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
3759
3760 2011-03-01  Adam Roben  <aroben@apple.com>
3761
3762         Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
3763
3764         Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
3765         --exit-after-n-crashes-or-timeouts limit
3766
3767         Reviewed by David Kilzer.
3768
3769         * Scripts/old-run-webkit-tests:
3770         (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
3771         the number of tests that caused the web process to crash when exiting early.
3772
3773 2011-03-01  Adam Roben  <aroben@apple.com>
3774
3775         Save a crash log when the web process crashes
3776
3777         On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
3778         until it has finished crashing, which guarantees that the crash log will have had time to be
3779         saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
3780         log, so all we have to do is choose the right crash log out of the CrashReporter directory.
3781
3782         Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
3783         a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
3784
3785         Reviewed by Sam Weinig.
3786
3787         * Scripts/old-run-webkit-tests:
3788         (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
3789         kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
3790         Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
3791         (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
3792         WebProces_*.crash files when the web process crashes.
3793
3794         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3795         (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
3796         initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
3797         along to platformInitialize.
3798
3799         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
3800
3801         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3802         (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
3803
3804         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3805         (WTR::InjectedBundle::platformInitialize):
3806         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3807         (WTR::InjectedBundle::platformInitialize):
3808         Updated function signature.
3809
3810         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
3811         (WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
3812         webProcessCrashingEvent, then lets the crash continue as normal.
3813
3814         (WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
3815         event we should use to tell the UI process we're crashing from the initializationUserData,
3816         and get a handle to that event.
3817
3818         * WebKitTestRunner/TestController.cpp:
3819         (WTR::TestController::TestController): Initialize new members.
3820         (WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
3821         only print the "#CRASHED - WebProcess" message once, since this can be called more than once
3822         when a crash log is being saved on Windows. Exit right away if specified. (This is the
3823         default.)
3824
3825         * WebKitTestRunner/TestController.h: Added new members.
3826
3827         * WebKitTestRunner/win/TestControllerWin.cpp:
3828         (WTR::TestController::platformInitialize): Set up the event the web process will use to tell
3829         us it's crashing.
3830         (WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
3831         ::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
3832         ::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
3833         has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
3834         so the test harness will know the web process has crashed and not try to kill us, then wait
3835         for the web process to finish crashing so a crash log will have time to be saved.
3836         (WTR::toWK): Simple hepler function.
3837         (WTR::TestController::platformInitializeContext): Pass along the name of the event the web
3838         process should use to tell us it is crashing in the context's initialization user data.
3839
3840 2011-03-01  Dimitri Glazkov  <dglazkov@chromium.org>
3841
3842         Reviewed by Tony Gentilcore.
3843
3844         Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
3845         https://bugs.webkit.org/show_bug.cgi?id=55476
3846
3847         Chromium Win uses BuildAndTestFactory, not TestFactory.
3848
3849         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.
3850
3851 2011-03-01  Adam Roben  <aroben@apple.com>
3852
3853         Test that the WebKit2 responsiveness timer doesn't fire too early
3854
3855         Test for <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
3856         early on Windows
3857
3858         Reviewed by Anders Carlsson.
3859
3860         * TestWebKitAPI/PlatformUtilities.h: Added sleep().
3861
3862         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
3863         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3864         (TestWebKitAPI::didFinishLoadForFrame):
3865         (TestWebKitAPI::processDidBecomeUnresponsive):
3866         (TestWebKitAPI::setInjectedBundleClient):
3867         (TestWebKitAPI::setPageLoaderClient):
3868         Simple helper functions.
3869
3870         (TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
3871         tell the web process to pause and press the spacebar key. The spacebar keypress should cause
3872         the responsiveness timer to start, but the web process should unpause before it has a chance
3873         to fire. Run until the web process has unpaused, and assert that the timer didn't fire.
3874
3875         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
3876         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
3877         Call up to the base class.
3878         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
3879         pause, sleep for 0.5 seconds, then send back a message saying we paused.
3880
3881         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3882         (TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
3883         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3884         (TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.
3885
3886         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3887         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3888         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3889         Added new files.
3890
3891 2011-03-01  Andras Becsi  <abecsi@webkit.org>
3892
3893         Reviewed by Csaba Osztrogonác.
3894
3895         [Qt] Clean up the project files and move common options to WebKit.pri.
3896
3897         * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.
3898
3899
3900 2011-03-01  Adam Roben  <aroben@apple.com>
3901
3902         Skip another multiprocessing test on Windows
3903
3904         It is sometimes failing (and may be leaving child Python processes around).
3905         <http://webkit.org/b/55087> tracks the failure.
3906
3907         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
3908         (FuncitonTests.test_get__processes): Skip this test on Windows.
3909
3910 2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
3911
3912         Reviewed by Pavel Feldman.
3913
3914         Web Inspector: reduce inspector tests flakiness.
3915         https://bugs.webkit.org/show_bug.cgi?id=55401
3916
3917         * DumpRenderTree/chromium/TestShell.cpp:
3918         (TestShell::runFileTest):
3919         * DumpRenderTree/chromium/WebPreferences.cpp:
3920         (WebPreferences::reset):
3921
3922 2011-02-28  Mihai Parparita  <mihaip@chromium.org>
3923
3924         Reviewed by James Robinson.
3925
3926         NRWT should still upload results when it exits early due to too many failures
3927         https://bugs.webkit.org/show_bug.cgi?id=55432
3928
3929         Only keyboard interrupts should prevent results from being uploaded.
3930
3931         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3932         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3933
3934 2011-02-28  Alice Liu  <alice.liu@apple.com>
3935
3936         Reviewed by Adam Roben and Gavin Barraclough.
3937
3938         Test for https://bugs.webkit.org/show_bug.cgi?id=54898
3939         InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.
3940
3941         * TestWebKitAPI/InjectedBundleController.h:
3942         (TestWebKitAPI::InjectedBundleController::bundle):
3943         * TestWebKitAPI/PlatformWebView.h:
3944         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
3945         (TestWebKitAPI::didFinishLoadForFrame):
3946         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3947         (TestWebKitAPI::setPageLoaderClient):
3948         (TestWebKitAPI::TEST):
3949         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
3950         (TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
3951         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
3952         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
3953         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3954         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3955         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3956         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3957
3958         Added files to:
3959         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3960         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3961         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3962
3963 2011-02-28  Adam Roben  <aroben@apple.com>
3964
3965         Start running InjectedBundle API tests on Windows
3966
3967         A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.
3968
3969         Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
3970
3971         Reviewed by Darin Adler.
3972
3973         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
3974         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
3975         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
3976         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
3977         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
3978         These are just extracted from TestWebKitAPI.vcproj.
3979
3980         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
3981         up the DLL's filename.
3982
3983         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
3984         (TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
3985         0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.
3986
3987         * TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
3988         "all" configuration.
3989
3990         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
3991         injected bundle tests. Let VS resort things.
3992
3993         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.
3994
3995 2011-02-28  Adam Roben  <aroben@apple.com>
3996
3997         Add a test for the paint rect passed via WM_PAINT to windowless plugins
3998
3999         Test for <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
4000         Large portions of pages with plugins paint black
4001
4002         Reviewed by Anders Carlsson.
4003
4004         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
4005         (PluginTest::NPP_HandleEvent):
4006         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
4007         Added NPP_HandleEvent. Just returns 0 at this level.
4008
4009         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
4010         (WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
4011         (WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
4012         (WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
4013         WM_PAINT has the expected coordinates.
4014
4015         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4016         (NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
4017         else.
4018
4019         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
4020         resort things.
4021
4022         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4023         (WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
4024         This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
4025         webView:didFinishLoadForFrame:] in DumpRenderTree.
4026
4027         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4028         (WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
4029         can start running.
4030
4031 2011-02-28  Adam Roben  <aroben@apple.com>
4032
4033         Tell MiniBrowser's WKViews that they're in a window
4034
4035         Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows
4036
4037         Reviewed by Anders Carlsson.
4038
4039         * MiniBrowser/win/BrowserView.cpp:
4040         (BrowserView::create): Call WKViewSetIsInWindow after creating the view.
4041
4042 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
4043
4044         Reviewed by Csaba Osztrogonác.
4045
4046         The new QML tests require QML_IMPORT_PATH variable to be set in order to
4047         load the proper plugin.
4048
4049         * Scripts/run-qtwebkit-tests:
4050
4051 2011-02-28  Joone Hur  <joone.hur@collabora.co.uk>
4052
4053         Unreviewed, fix spelling mistake.
4054
4055         hardware-accelated => hardware-accelerated.
4056
4057         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4058
4059 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
4060
4061         Reviewed by Andreas Kling.
4062
4063         Made sure that the build-webkit --qmake argument is always respected.
4064
4065         Previously, it would be respected during the build, but not during
4066         the early feature detection. The build would also fail if qmake was
4067         not in your path, even if you specified --qmake with a valid qmake
4068         binary.
4069
4070         [Qt] WebKit patches required to work with a modularized version of Qt
4071         https://bugs.webkit.org/show_bug.cgi?id=53916
4072
4073         * Scripts/build-webkit:
4074         * Scripts/webkitdirs.pm:
4075
4076 2011-02-27  Ojan Vafai  <ojan@chromium.org>
4077
4078         Fix failing tests from http://trac.webkit.org/changeset/79837.
4079
4080         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
4081         This was just a mistake that would break if someone tried printing with this configuration.
4082         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
4083         Method signature changed. Didn't notice that this method was being calling in a unittest.
4084
4085 2011-02-24  Hayato Ito  <hayato@chromium.org>
4086
4087         Reviewed by Eric Seidel.
4088
4089         [NRWT] Remove test_types/* classes.
4090
4091         This is the last patch in the series of efforts which tried to remove test_types classes.
4092         A single_test_runner module will take over responsibilities of test_type classes.
4093
4094         From this patch, we won't display statistics per test_type even if a '--verbose' option is given.
4095
4096         https://bugs.webkit.org/show_bug.cgi?id=55123
4097
4098         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
4099         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
4100         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
4101         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
4102         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
4103         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed.
4104         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
4105         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
4106         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
4107         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
4108
4109 2011-02-25  Ojan Vafai  <ojan@chromium.org>
4110
4111         Reviewed by Tony Chang.
4112
4113         Change results.json format to the one used by unexpected_results.json
4114         https://bugs.webkit.org/show_bug.cgi?id=52267
4115
4116         Also add runtimes in milliseconds to the JSON and make the output format more compact.
4117         Named the file full_results.json to avoid conflicting with the results.json
4118         file the test-results server currently serves up.
4119
4120         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
4121         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4122         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4123         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
4124         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
4125         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
4126
4127 2011-02-27  Adam Roben  <aroben@apple.com>
4128
4129         Followup fix to r79827
4130
4131         * DumpRenderTree/win/UIDelegate.cpp:
4132         (UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
4133         lastPathComponent. This matches what we did here before r79827, and matches Mac.
4134
4135 2011-02-27  Dan Bernstein  <mitz@apple.com>
4136
4137         Reviewed by Adam Roben.
4138
4139         Make bisect-builds print a trac link for the regression range
4140         https://bugs.webkit.org/show_bug.cgi?id=55331
4141
4142         * Scripts/bisect-builds:
4143
4144 2011-02-27  Adam Roben  <aroben@apple.com>
4145
4146         Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
4147
4148         Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
4149         EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
4150         fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled
4151
4152         Reviewed by Anders Carlsson.
4153
4154         * DumpRenderTree/win/EditingDelegate.cpp:
4155         (indexOfFirstWordCharacter):
4156         (wordLength):
4157         Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.
4158
4159 2011-02-27  Adam Roben  <aroben@apple.com>
4160
4161         Make ResourceLoadDelegate print URLs relative to the main resource on Windows
4162
4163         This matches Mac. (In fact, the code was ported from Mac!)
4164
4165         Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
4166         match Mac
4167
4168         Reviewed by Anders Carlsson.
4169
4170         * DumpRenderTree/win/DumpRenderTree.cpp:
4171         (substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
4172         (urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
4173         _drt_descriptionSuitableForTestResult].
4174         (cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.
4175
4176         * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
4177
4178         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
4179         DumpRenderTree.cpp.
4180
4181 2011-02-27  Adam Roben  <aroben@apple.com>
4182
4183         Change the order of Chang Shu's email addresses so the first one is their Bugzilla username
4184
4185         This makes Bugzilla autocompletion work correctly.
4186
4187         * Scripts/webkitpy/common/config/committers.py:
4188
4189 2011-02-27  Patrick Gansterer  <paroga@webkit.org>
4190
4191         Reviewed by Andreas Kling.
4192
4193         [Qt] fast/loader/user-stylesheet-fast-path.html fails
4194         https://bugs.webkit.org/show_bug.cgi?id=50911
4195
4196         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4197         (LayoutTestController::setUserStyleSheetLocation):
4198         Use QUrl::fromEncoded since the passed string is already encoded.
4199
4200 2011-02-27  Adam Roben  <aroben@apple.com>
4201
4202         Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
4203
4204         Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
4205         is different from old-run-webkit-test's. Because of this, the path to the crash log file
4206         (which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
4207         details.
4208
4209         Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
4210         --results-directory path is used (like on the test slaves)
4211
4212         Reviewed by Dan Bernstein.
4213
4214         * Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
4215         made $testResultsDirectory an absolute path.
4216
4217 2011-02-26  Dominic Mazzoni  <dmazzoni@google.com>
4218
4219         Reviewed by Adam Barth.
4220
4221         m_dumpAccessibilityNotifications should be initialized.
4222         https://bugs.webkit.org/show_bug.cgi?id=54874
4223
4224         * DumpRenderTree/chromium/AccessibilityController.cpp:
4225         (AccessibilityController::AccessibilityController):
4226
4227 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
4228
4229         Reviewed by Pavel Feldman.
4230
4231         DumpRenderTree should reset frame opener between tests.
4232         https://bugs.webkit.org/show_bug.cgi?id=54874
4233
4234         Added clearOpener() calls between tests.
4235         Some tests are using window.open() to change current window location.
4236         This changes window.opener property whose nullity is checked before
4237         showing xml viewer.
4238
4239         * DumpRenderTree/chromium/TestShell.cpp:
4240         (TestShell::resetTestController):
4241         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4242         (resetDefaultsToConsistentValues):
4243         * DumpRenderTree/mac/DumpRenderTree.mm:
4244         (resetWebViewToConsistentStateBeforeTesting):
4245         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4246         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4247         * DumpRenderTree/win/DumpRenderTree.cpp:
4248         (resetWebViewToConsistentStateBeforeTesting):
4249         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4250         (WTR::InjectedBundlePage::reset):
4251
4252 2011-02-26  Yael Aharon  <yael.aharon@nokia.com>
4253
4254         Reviewed by Andreas Kling.
4255
4256         [Qt] Fix the focus in MiniBrowser.
4257         https://bugs.webkit.org/show_bug.cgi?id=55288
4258
4259         Give focus to the web view when a load starts.
4260
4261         * MiniBrowser/qt/BrowserWindow.cpp:
4262         (BrowserWindow::urlChanged):
4263
4264 2011-02-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4265
4266         Reviewed by Adam Barth.
4267
4268         [EFL] Add coding style exceptions for EFL port
4269         https://bugs.webkit.org/show_bug.cgi?id=54733
4270
4271         The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased,
4272         underscore-sparated values. But, style checking rule have found parameter_name errors
4273         in efl directories so far.
4274
4275         * Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories.
4276
4277 2011-02-26  David Levin  <levin@chromium.org>
4278
4279         Reviewed by Darin Adler.
4280
4281         check-webkit-style should check for spaces after periods in comments
4282         https://bugs.webkit.org/show_bug.cgi?id=55253
4283
4284         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
4285         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests
4286           and fixed the name of one related test.
4287
4288 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4289
4290         Reviewed by Andreas Kling.
4291
4292         Make it possible to test the targetdensity-dpi support
4293         https://bugs.webkit.org/show_bug.cgi?id=55142
4294
4295         Test the viewport meta tag feature targetdensity-dpi by