[WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
[WebKit-https.git] / Tools / ChangeLog
1 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2
3         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
4         https://bugs.webkit.org/show_bug.cgi?id=174780
5
6         Reviewed by Carlos Garcia Campos.
7
8         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
9         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
10         in case the eglplatform.h header doesn't provide that macro. This replicates
11         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
12
13 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
14
15         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
16         https://bugs.webkit.org/show_bug.cgi?id=174758
17
18         Reviewed by Dan Bernstein.
19
20         Migrate position-information-related unit tests from the PositionInformationTests suite to
21         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
22
23         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
25         (TestWebKitAPI::checkElementTypeAndBoundingRect):
26         (TestWebKitAPI::TEST):
27         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
28         * TestWebKitAPI/cocoa/TestWKWebView.h:
29         * TestWebKitAPI/cocoa/TestWKWebView.mm:
30         (-[TestWKWebView activatedElementAtPosition:]):
31
32 2017-07-22  Chris Dumez  <cdumez@apple.com>
33
34         REGRESSION(r204565): WKObject is broken
35         https://bugs.webkit.org/show_bug.cgi?id=174736
36         <rdar://problem/33246169>
37
38         Reviewed by Dan Bernstein.
39
40         Add API test that used to crash.
41
42         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
43         (TestWebKitAPI::TEST):
44
45 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
46
47         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
48         https://bugs.webkit.org/show_bug.cgi?id=174705
49
50         Reviewed by Mark Lam.
51
52         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
53         (TestWebKitAPI::testThreadGroup):
54         (TestWebKitAPI::TEST):
55
56 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
57
58         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
59         https://bugs.webkit.org/show_bug.cgi?id=174724
60
61         Reviewed by Aakash Jain.
62
63         * Scripts/webkitpy/port/ios_simulator.py:
64         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
65         simulator. Errors here should be treated the same as no simulators found.
66
67 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
68
69         [CMake] Add an option to stop build after generating project files
70         https://bugs.webkit.org/show_bug.cgi?id=174664
71
72         Reviewed by Konstantin Tokarev.
73
74         Add "--generate-project-only" to stop build after generating project files.
75
76         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
77         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
78         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
79         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
80         (isGenerateProjectOnly): ditto
81
82 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
83
84         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
85         https://bugs.webkit.org/show_bug.cgi?id=174501
86
87         Reviewed by Darin Adler.
88
89         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
90         (TestWebKitAPI::TEST):
91
92 2017-07-20  David Quesada  <david_quesada@apple.com>
93
94         Add SPI to notify WKNavigationDelegate about client redirects
95         https://bugs.webkit.org/show_bug.cgi?id=174680
96         rdar://problem/33184886
97
98         Reviewed by Brady Eidson.
99
100         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
101         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
102         (TEST):
103         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
104
105 2017-07-20  Brady Eidson  <beidson@apple.com>
106
107         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
108         https://bugs.webkit.org/show_bug.cgi?id=174685
109
110         Reviewed by Andy Estes.
111
112         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
113         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
114
115 2017-07-20  Brady Eidson  <beidson@apple.com>
116
117         Deprecate WebIconDatabase in WebKitLegacy/mac.
118         https://bugs.webkit.org/show_bug.cgi?id=174607
119
120         Reviewed by Alex Christensen.
121
122         * DumpRenderTree/mac/TestRunnerMac.mm:
123
124 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
125
126         lint-test-expectations should be run during style checking
127         https://bugs.webkit.org/show_bug.cgi?id=173559
128         <rdar://problem/32854941>
129
130         Reviewed by Aakash Jain.
131
132         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
133         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
134         prevents identifying errors on specific lines in a file.
135         * Scripts/webkitpy/style/main_unittest.py:
136         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
137         case where a linter error is in the file modified, but the line modified is not related to
138         the linter error.
139
140 2017-07-20  Brady Eidson  <beidson@apple.com>
141
142         Remove WebIconDatabase from WebKitLegacy/win.
143         https://bugs.webkit.org/show_bug.cgi?id=174608
144
145         Reviewed by Alex Christensen.
146
147         * DumpRenderTree/win/DumpRenderTree.cpp:
148         (main):
149         * DumpRenderTree/win/TestRunnerWin.cpp:
150         (TestRunner::setIconDatabaseEnabled):
151
152 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
153
154         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
155         https://bugs.webkit.org/show_bug.cgi?id=174671
156
157         Reviewed by Carlos Garcia Campos.
158
159         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
160         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
161         priority for this source in order to have it dispatched on the same
162         priority as the other WebKit-controlled GSource objects.
163
164 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
165
166         lint-test-expectations should be run during style checking
167         https://bugs.webkit.org/show_bug.cgi?id=173559
168         <rdar://problem/32854941>
169
170         Reviewed by Daniel Bates.
171
172         Follow up fix addressing style and a few minor bugs.
173
174         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
175         (TestExpectationParser.__init__): Use lambda x: x instead of str
176         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
177         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
178         reduce the calls of _shorten_filename, fix minor bug in appending the current
179         expectation's line number instead of the previous ones, clarify treatment of None
180         in file-to-line-number mapping.
181         (TestExpectations._report_warnings): Collapse call.
182         * Scripts/webkitpy/style/checkers/test_expectations.py:
183         (TestExpectationsChecker.lint_test_expectations):
184         * Scripts/webkitpy/style/filereader.py: Re-write comment.
185         (TextFileReader.process_file): Add comment explaining treatment of None in
186         file-to-line-number mapping.
187         (TextFileReader.delete_file): Collapse call.
188
189 2017-07-19  Chris Dumez  <cdumez@apple.com>
190
191         Unreviewed attempt to fix API test failure after r219663.
192
193         The test was hard-coding an exception string and the string has changed slightly
194         in r219663.
195
196         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
197         (TEST):
198
199 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
200
201         Don't write file URLs to iOS Pasteboard
202         https://bugs.webkit.org/show_bug.cgi?id=174647
203         <rdar://problem/33199730>
204
205         Reviewed by Wenson Hsieh.
206
207         Updating tests to reflect the lack of file URLs for images.
208
209         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
210         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
211         (checkEstimatedSize):
212         (TestWebKitAPI::TEST):
213
214 2017-07-19  Brady Eidson  <beidson@apple.com>
215
216         iBooks sometimes crashes when closing a book.
217         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
218
219         Reviewed by Oliver Hunt.
220
221         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
222         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
223         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
224         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
225         (TestWebKitAPI::TEST):
226
227         Add a "spin the runloop X number of times" utility:
228         * TestWebKitAPI/Utilities.h:
229         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
230         (TestWebKitAPI::Util::spinRunLoop):
231
232 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
233
234         lint-test-expectations should be run during style checking
235         https://bugs.webkit.org/show_bug.cgi?id=173559
236         <rdar://problem/32854941>
237
238         Reviewed by David Kilzer.
239
240         Running the test expectation linter requires reading both files and lines not in the
241         patch because, for example, deletion of a test can cause a lint failure even though
242         no test expectations where modified. This means that the linter will occasionally warn
243         about lines which were not changed in a given patch but whose error is related to a
244         change made in that patch.
245
246         * Scripts/webkitpy/common/system/filesystem_mock.py:
247         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
248         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
249         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
250         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
251         content, description of the error and the name of the associated test.
252         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
253         (TestExpectationParser.__init__): Pass shorten_filename function to
254         TestExpectationsParser to add a deleted file to the related_files dictionary.
255         (TestExpectationParser._check_test_exists): If the test does not exist, add the
256         missing path to the related_files dictionary.
257         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
258         files and line numbers related to this test expectation line. This will allow
259         tracking linter errors in the style checker occurring across multiple files.
260         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
261         lines to related_files dictionary.
262         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
263         (TestExpectations._report_warnings): Construct warning object instead of string
264         when adding to warnings list.
265         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
266         clean-up log.
267         * Scripts/webkitpy/style/checker.py:
268         (ProcessorBase.do_association_check): Add required function for processor classes.
269         (StyleProcessor):
270         (StyleProcessor.do_association_check): Run the TestExpectations linter when
271         checking for errors between associated files.
272         * Scripts/webkitpy/style/checkers/test_expectations.py:
273         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
274         (TestExpectationsChecker):
275         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
276         of modified files, the current working directory and the host, determine if the linter
277         warning is associated with the changes.
278         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
279         style checker.
280         * Scripts/webkitpy/style/filereader.py:
281         (TextFileReader):
282         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
283         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
284         (TextFileReader.process_file): Track both the number of files changed and which lines
285         in those files were changed.
286         (TextFileReader.do_association_check): Run the processor's association check on all
287         modified or deleted files processed by TextFileReader.
288         (TextFileReader.delete_file): Track deleted files in _files dictionary.
289         (TextFileReader.count_delete_only_file): Deleted.
290         * Scripts/webkitpy/style/filereader_unittest.py:
291         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
292         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
293         * Scripts/webkitpy/style/main.py:
294         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
295         explicitly run the association check on the file reader.
296         * Scripts/webkitpy/style/main_unittest.py:
297         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
298         embedded in the style checker.
299         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
300         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
301         construct the TextFileReader object with a StyleProcessor used to run style checks on
302         specific files.
303         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
304         testing the test expectation linter inside the style checker. This host must contain a
305         mock file system with the basic structure of test expectations.
306         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
307         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
308         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
309         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
310         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
311         * Scripts/webkitpy/style/patchreader.py:
312         (PatchReader.check): Specify which file was deleted, run the association check.
313         * Scripts/webkitpy/style/patchreader_unittest.py:
314         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
315         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
316         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
317
318 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
319
320         [WTF] Implement WTF::ThreadGroup
321         https://bugs.webkit.org/show_bug.cgi?id=174081
322
323         Reviewed by Mark Lam.
324
325         Add WTF::ThreadGroup tests.
326
327         * TestWebKitAPI/CMakeLists.txt:
328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
329         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
330         (TestWebKitAPI::testThreadGroup):
331         (TestWebKitAPI::TEST):
332
333 2017-07-18  Andy Estes  <aestes@apple.com>
334
335         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
336         https://bugs.webkit.org/show_bug.cgi?id=174631
337
338         Reviewed by Tim Horton.
339
340         * DumpRenderTree/mac/Configurations/Base.xcconfig:
341         * MiniBrowser/Configurations/Base.xcconfig:
342         * MobileMiniBrowser/Configurations/Base.xcconfig:
343         * TestWebKitAPI/Configurations/Base.xcconfig:
344         * WebKitTestRunner/Configurations/Base.xcconfig:
345
346 2017-07-18  Andy Estes  <aestes@apple.com>
347
348         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
349         https://bugs.webkit.org/show_bug.cgi?id=174631
350
351         Reviewed by Sam Weinig.
352
353         * DumpRenderTree/mac/Configurations/Base.xcconfig:
354         * MiniBrowser/Configurations/Base.xcconfig:
355         * MobileMiniBrowser/Configurations/Base.xcconfig:
356         * TestWebKitAPI/Configurations/Base.xcconfig:
357         * WebKitTestRunner/Configurations/Base.xcconfig:
358
359 2017-07-18  Daniel Bates  <dabates@apple.com>
360
361         lldb: Add type summary for StringView
362         https://bugs.webkit.org/show_bug.cgi?id=174637
363
364         Reviewed by Sam Weinig.
365
366         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
367         StringView object will print output that has the form:
368
369             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
370               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
371               m_length = 2
372               m_is8Bit = true
373               m_underlyingString = 0x0000614000000a90
374             }
375
376         * lldb/lldb_webkit.py:
377         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
378         (WTFStringView_SummaryProvider):
379         (WTFStringViewProvider):
380         (WTFStringViewProvider.__init__):
381         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
382         (WTFStringViewProvider.get_length): Access field StringView.m_length.
383         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
384         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
385
386 2017-07-18  Andy Estes  <aestes@apple.com>
387
388         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
389         https://bugs.webkit.org/show_bug.cgi?id=174631
390
391         Reviewed by Dan Bernstein.
392
393         * DumpRenderTree/mac/Configurations/Base.xcconfig:
394         * MiniBrowser/Configurations/Base.xcconfig:
395         * MobileMiniBrowser/Configurations/Base.xcconfig:
396         * TestWebKitAPI/Configurations/Base.xcconfig:
397         * WebKitTestRunner/Configurations/Base.xcconfig:
398
399 2017-07-18  Devin Rousso  <drousso@apple.com>
400
401         Web Inspector: Add memoryCost to Inspector Protocol objects
402         https://bugs.webkit.org/show_bug.cgi?id=174478
403
404         Reviewed by Joseph Pecoraro.
405
406         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
407         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
408         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
409         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
410         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
411         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
412         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
413         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
414         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
415         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
416         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
417         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
418         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
419         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
420         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
421         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
422         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
423
424 2017-07-18  Andy Estes  <aestes@apple.com>
425
426         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
427         https://bugs.webkit.org/show_bug.cgi?id=174631
428
429         Reviewed by Darin Adler.
430
431         * DumpRenderTree/mac/Configurations/Base.xcconfig:
432         * MiniBrowser/Configurations/Base.xcconfig:
433         * MobileMiniBrowser/Configurations/Base.xcconfig:
434         * TestWebKitAPI/Configurations/Base.xcconfig:
435         * WebKitTestRunner/Configurations/Base.xcconfig:
436
437 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
438
439         Unreviewed, fix the iOS build.
440
441         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
442
443         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
444         (TestWebKitAPI::TEST):
445
446 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
447
448         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
449         https://bugs.webkit.org/show_bug.cgi?id=174585
450         <rdar://problem/33302541>
451
452         Reviewed by Tim Horton.
453
454         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
455         being dragged when initiating a drag.
456
457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
458         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
459         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
460         (TestWebKitAPI::TEST):
461         * TestWebKitAPI/cocoa/TestWKWebView.h:
462
463         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
464
465         * TestWebKitAPI/cocoa/TestWKWebView.mm:
466         (-[TestWKWebView synchronouslyLoadHTMLString:]):
467
468 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
469
470         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
471         https://bugs.webkit.org/show_bug.cgi?id=174547
472
473         Reviewed by Alex Christensen.
474
475         * DumpRenderTree/PlatformWin.cmake:
476         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
477
478 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
479
480         Update style checker to deal with "final"
481         https://bugs.webkit.org/show_bug.cgi?id=174528
482
483         Reviewed by Alex Christensen.
484         
485         check-webkit-style shouldn't complain about an open brace to start a
486         line after a function definition with "final" or "const final".
487
488         * Scripts/webkitpy/style/checkers/cpp.py:
489         (check_braces):
490         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
491         (CppStyleTest.test_brace_at_begin_of_line):
492
493 2017-07-17  Alex Christensen  <achristensen@webkit.org>
494
495         Modernize content extension code
496         https://bugs.webkit.org/show_bug.cgi?id=174588
497
498         Reviewed by Sam Weinig.
499
500         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
501         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
502         (TestWebKitAPI::testRequest):
503         (TestWebKitAPI::makeBackend):
504         (TestWebKitAPI::TEST_F):
505
506 2017-07-17  Brady Eidson  <beidson@apple.com>
507
508         WKHTTPCookieStore observing only works on the default cookie store.
509         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
510
511         Reviewed by Sam Weinig.
512
513         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
514         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
515           called for the default store, a non-persistent store, and a custom store.
516         (TEST):
517
518 2017-07-16  Sam Weinig  <sam@webkit.org>
519
520         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
521         https://bugs.webkit.org/show_bug.cgi?id=174575
522
523         Reviewed by Brady Eidson.
524
525         * Scripts/svn-create-patch:
526         (findModificationType):
527         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
528         default value of "unknown".
529
530         (generateFileList):
531         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
532         for untracked, which matches our old behavior.
533
534 2017-07-17  Charlie Turner  <cturner@igalia.com>
535
536         Add some missing build dependencies on Fedora
537         https://bugs.webkit.org/show_bug.cgi?id=174578
538
539         Unreviewed dependency update.
540
541         * gtk/install-dependencies:
542
543 2017-07-16  Brady Eidson  <beidson@apple.com>
544
545         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
546         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
547
548         Reviewed by Tim Horton.
549
550         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
551         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
552         (TEST):
553
554 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
555
556         [GTK] Sort inspector GResource manifest to ensure reproducible builds
557         https://bugs.webkit.org/show_bug.cgi?id=174540
558
559         Reviewed by Michael Catanzaro.
560
561         * gtk/generate-inspector-gresource-manifest.py:
562         (get_filenames): sort list of input files
563
564 2017-07-15  Brady Eidson  <beidson@apple.com>
565
566         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
567         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
568
569         Reviewed by Tim Horton.
570
571         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
572         (TEST): Make this test more reliable by clearing everything beforehand.
573
574 2017-07-15  David Kilzer  <ddkilzer@apple.com>
575
576         Make it possible to extend check-webkit-style with Apple-internal checkers
577         <https://webkit.org/b/174464>
578         <rdar://problem/25564402>
579
580         Reviewed by Darin Adler.
581
582         * Scripts/webkitpy/style/checker.py: Import apple_additions.
583         (_all_categories): Add categories from apple_additions() if it
584         exists.
585         (CheckerDispatcher._create_checker): Create python checker
586         from apple_additions() if it exists.
587
588 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
589
590         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
591         https://bugs.webkit.org/show_bug.cgi?id=174539
592         <rdar://problem/33307395>
593
594         Reviewed by Darin Adler.
595
596         Adds a new unit test suite to cover action sheet popover presentation.
597
598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
599         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
600         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
601         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
602
603         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
604
605         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
606         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
607
608         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
609
610         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
611         (TestWebKitAPI::TEST):
612
613 2017-07-15  Sam Weinig  <sam@webkit.org>
614
615         [Scripts] Make svn-create-patch work better when called in sub directories
616         https://bugs.webkit.org/show_bug.cgi?id=174551
617
618         Reviewed by Darin Adler.
619
620         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
621           by ensuring that the prefix is applied as is done in generateDiff.
622         - Silence output of explanatory lines from svn stat (" > move to ...")
623           that show up in STDERR when running svn-create-patch.
624         - Add verbose logging that I found useful while debugging this issue.
625
626         * Scripts/svn-create-patch:
627         (findBaseUrl):
628         (findMimeType):
629         (findSourceFileAndRevision):
630         (generateDiff):
631         (generateFileList):
632         (manufacturePatchForAdditionWithHistory):
633
634 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
635
636         Unreviewed build fix after r219537.
637
638         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
639
640 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
641
642         Add iOS 11 SPI
643         https://bugs.webkit.org/show_bug.cgi?id=174430
644         <rdar://problem/33269288>
645
646         Reviewed by Tim Horton.
647
648         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
649         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
650         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
651
652 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
653
654         Failing to install on iPad simulators
655         https://bugs.webkit.org/show_bug.cgi?id=174532
656         <rdar://problem/33328347>
657
658         Reviewed by Stephanie Lewis.
659
660         * Scripts/webkitpy/xcode/simulated_device.py:
661         (SimulatedDevice.install_app): Place install command in retry try-except block.
662
663 2017-07-14  Jeff Miller  <jeffm@apple.com>
664
665         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
666         https://bugs.webkit.org/show_bug.cgi?id=174524
667
668         Reviewed by Sam Weinig.
669
670         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
671         (TEST):
672         Renamed TestParameter to TestParameter1.
673         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
674
675         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
676         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
677         Observe changes for two bundle parameters.
678
679         (-[BundleParametersPlugIn dealloc]):
680         Remove observers for two bundle parameters.
681
682 2017-07-14  Commit Queue  <commit-queue@webkit.org>
683
684         Unreviewed, rolling out r219510.
685         https://bugs.webkit.org/show_bug.cgi?id=174525
686
687         Need to revert length() == 0 check for null string (Requested
688         by yusukesuzuki on #webkit).
689
690         Reverted changeset:
691
692         "[WTF] Newly added AtomicStringImpl should use BufferInternal
693         static string if StringImpl is static"
694         https://bugs.webkit.org/show_bug.cgi?id=174501
695         http://trac.webkit.org/changeset/219510
696
697 2017-07-14  Jer Noble  <jer.noble@apple.com>
698
699         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
700         https://bugs.webkit.org/show_bug.cgi?id=174514
701
702         Reviewed by Sam Weinig.
703
704         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
705         (TestWebKitAPI::TEST_F):
706
707 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
708
709         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
710         https://bugs.webkit.org/show_bug.cgi?id=174501
711
712         Reviewed by Darin Adler.
713
714         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
715         (TestWebKitAPI::TEST):
716
717 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
718
719         Bring mac expectations in-line with other platforms
720         https://bugs.webkit.org/show_bug.cgi?id=174472
721         <rdar://problem/33297388>
722
723         Reviewed by David Kilzer.
724
725         The override order for Mac test expectations does not conform to the pattern used by iOS,
726         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
727
728             platform/mac-wk2
729             platform/wk2
730             platform/mac-elcapitan
731             platform/mac-sierra
732             generic
733
734         After this change, El Capitan's baseline search path looks like this:
735
736             platform/mac-sierra-wk2
737             platform/mac-sierra
738             platform/mac-wk2
739             platform/wk2
740             generic
741
742         * Scripts/webkitpy/port/mac.py:
743         (MacPort.__init__): If a specific version is specified in the port name, use that
744         as the os version.
745         (MacPort.default_baseline_search_path): Expectation search paths should work the
746         same way they do on other ports. Port + version overrides port, port overrides generic
747         and wk1/wk2 should override expectations for the two combined.
748         * Scripts/webkitpy/port/mac_unittest.py:
749         (MacTest.test_tests_for_other_platforms): Deleted.
750         (MacTest._assert_search_path): Deleted.
751         (MacTest.test_baseline_search_path): Deleted.
752         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
753         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
754         (test_rebaseline_test_and_print_scm_changes): Ditto.
755         (test_rebaseline_and_copy_test): Ditto.
756         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
757         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
758         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
759
760 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
761
762         Fix style checker unit test
763
764         Unreviewed WebKit2 => WebKit fixup.
765
766         * Scripts/webkitpy/style/checker_unittest.py:
767         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
768
769 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
770
771         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
772
773         Unreviewed build fix.
774
775         r219492 missed one hunk from its partial revert of r219489.
776         This patch reverts that hunk.
777
778         * TestWebKitAPI/CMakeLists.txt:
779
780 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
781
782         Use the old WebKit/WebKit2 targets for CMake builds.
783
784         Unreviewed build fix.
785
786         We can update the target names to match the Framework names in a future patch.
787         This is a partial revert of r219489.
788
789         * TestWebKitAPI/CMakeLists.txt:
790         WebKitLegacy => WebKit
791         WebKit => WebKit2
792
793 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
794
795         Fix TestWebKit API.
796         https://bugs.webkit.org/show_bug.cgi?id=174164
797         rdar://problem/33137595
798
799         Reviewed by Dan Bernstein.
800
801         * TestWebKitAPI/CMakeLists.txt:
802         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
803         * TestWebKitAPI/PlatformGTK.cmake:
804
805 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
806
807         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
808         https://bugs.webkit.org/show_bug.cgi?id=174164
809         rdar://problem/33137595
810
811         Reviewed by Dan Bernstein.
812
813         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
814         (ShouldBuildTest):
815         * DumpRenderTree/mac/Configurations/Base.xcconfig:
816         * Scripts/build-webkit:
817         * Scripts/do-file-rename:
818         * Scripts/do-webcore-rename:
819         * Scripts/update-webkit-localizable-strings:
820         * Scripts/webkitpy/common/config/watchlist:
821         * Scripts/webkitpy/style/checker.py:
822         * Scripts/webkitpy/style/checkers/featuredefines.py:
823         * gtk/make-dist.py:
824         (ensure_version_if_possible):
825         * gtk/manifest.txt.in:
826
827 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
828
829         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
830         https://bugs.webkit.org/show_bug.cgi?id=174162
831         rdar://problem/33137594
832
833         Reviewed by Dan Bernstein.
834
835         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
836
837         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
838         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
839         * EWSTools/configure-clang-linux.sh:
840         * Scripts/build-webkit:
841         * Scripts/do-file-rename:
842         * Scripts/do-webcore-rename:
843         * Scripts/update-webkit-localizable-strings:
844         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
845         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
846         * Scripts/webkitpy/style/checkers/featuredefines.py:
847         * gtk/manifest.txt.in:
848
849 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
850
851         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
852         https://bugs.webkit.org/show_bug.cgi?id=174438
853         <rdar://problem/33277112>
854
855         Reviewed by Aakash Jain.
856
857         Given a patch, this will convert the changes from the path to the new directory structure.
858
859         * Scripts/rebase-patch-after-webkit-move: Added.
860         (append_source): Append 'Source' to the provided path.
861         (is_editable_line): Return true if a line the script expects to modify.
862         (needs_rebase): Return if a line needs to be rebased based on it's content.
863         (rebase_line): Rebase the provided line.
864         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
865         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
866         were provided.
867
868 2017-07-12  Nan Wang  <n_wang@apple.com>
869
870         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
871         https://bugs.webkit.org/show_bug.cgi?id=174393
872         <rdar://problem/33248006>
873
874         Reviewed by Chris Fleizach.
875
876         * DumpRenderTree/AccessibilityUIElement.cpp:
877         (textMarkerRangeMatchesTextNearMarkersCallback):
878         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
879         (AccessibilityUIElement::getJSClass):
880         * DumpRenderTree/AccessibilityUIElement.h:
881         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
882         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
883         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
884         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
885         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
886         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
887         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
888         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
889
890 2017-07-12  Matt Lewis  <jlewis3@apple.com>
891
892         Unreviewed, rolling out r219409.
893
894         The revision caused the Windows builds to fail.
895
896         Reverted changeset:
897
898         "AX: [iOS] Implement a way to retrieve a text marker range
899         with desired text that is closest to a position"
900         https://bugs.webkit.org/show_bug.cgi?id=174393
901         http://trac.webkit.org/changeset/219409
902
903 2017-07-12  Nan Wang  <n_wang@apple.com>
904
905         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
906         https://bugs.webkit.org/show_bug.cgi?id=174393
907         <rdar://problem/33248006>
908
909         Reviewed by Chris Fleizach.
910
911         * DumpRenderTree/AccessibilityUIElement.cpp:
912         (textMarkerRangeMatchesTextNearMarkersCallback):
913         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
914         (AccessibilityUIElement::getJSClass):
915         * DumpRenderTree/AccessibilityUIElement.h:
916         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
917         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
918         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
919         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
920         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
921         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
922         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
923         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
924
925 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
926
927         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
928         https://bugs.webkit.org/show_bug.cgi?id=174197
929
930         Reviewed by Darin Adler.
931
932         This bit me the first time I tried to submit a patch to WebKit, and still I have
933         to manually edit the ChangeLog every time I use the script.
934
935         This generates a more convenient and standard ChangeLog entry.
936
937         * Scripts/prepare-ChangeLog:
938         (generateNewChangeLogs):
939
940 2017-07-12  Matt Lewis  <jlewis3@apple.com>
941
942         Unreviewed, rolling out r219401.
943
944         This revision rolled out the previous patch, but after talking
945         with reviewer, a rebaseline is what was needed.Rolling back in
946         before rebaseline.
947
948         Reverted changeset:
949
950         "Unreviewed, rolling out r219379."
951         https://bugs.webkit.org/show_bug.cgi?id=174400
952         http://trac.webkit.org/changeset/219401
953
954 2017-07-12  Matt Lewis  <jlewis3@apple.com>
955
956         Unreviewed, rolling out r219379.
957
958         This revision caused a consistent failure in the test
959         fast/dom/Window/property-access-on-cached-window-after-frame-
960         removed.html.
961
962         Reverted changeset:
963
964         "Remove NAVIGATOR_HWCONCURRENCY"
965         https://bugs.webkit.org/show_bug.cgi?id=174400
966         http://trac.webkit.org/changeset/219379
967
968 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
969
970         [WPE] Use libepoxy
971         https://bugs.webkit.org/show_bug.cgi?id=172104
972
973         Reviewed by Michael Catanzaro.
974
975         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
976         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
977
978 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
979
980         [GTK][WPE] Align Jhbuild patches for GStreamer packages
981         https://bugs.webkit.org/show_bug.cgi?id=174363
982
983         Reviewed by Michael Catanzaro.
984
985         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
986         between the GTK+ and WPE port. There's no reason for the two ports to apply
987         different patches over same versions of GStreamer releases.
988
989         This aligns the two ports on this specific issue. Next we'll look into
990         creating a single GStreamer-specific Jhbuild moduleset that will allow us
991         to keep these patches in a single place, avoiding duplicate files.
992
993         * gtk/jhbuild.modules:
994         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
995         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
996         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
997         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
998
999 2017-07-11  Dean Jackson  <dino@apple.com>
1000
1001         Remove NAVIGATOR_HWCONCURRENCY
1002         https://bugs.webkit.org/show_bug.cgi?id=174400
1003
1004         Reviewed by Sam Weinig.
1005
1006         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1007
1008 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
1009
1010         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
1011         https://bugs.webkit.org/show_bug.cgi?id=174239
1012
1013         Reviewed by Brady Eidson.
1014
1015         Create windows with specific features set and make sure those are properly reflected in the
1016         WKWindowFeatures object.
1017
1018         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
1019         (resetToConsistentState):
1020         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1021         (TEST):
1022
1023 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
1024
1025         Do not duplicate files when deleting directories with svn 1.9
1026         https://bugs.webkit.org/show_bug.cgi?id=174339
1027         <rdar://problem/33226781>
1028
1029         Reviewed by David Kilzer.
1030
1031         * Scripts/svn-create-patch:
1032         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
1033         (generateFileList): Determine which files are deleted because they are part of a
1034         directory being deleted.
1035
1036 2017-07-11  Dean Jackson  <dino@apple.com>
1037
1038         Rolling out r219372.
1039
1040         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1041
1042 2017-07-11  Dean Jackson  <dino@apple.com>
1043
1044         Remove NAVIGATOR_HWCONCURRENCY
1045         https://bugs.webkit.org/show_bug.cgi?id=174400
1046
1047         Reviewed by Sam Weinig.
1048
1049         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1050
1051 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1052
1053         Teach build workers to fetch archives from S3.
1054         https://bugs.webkit.org/show_bug.cgi?id=174384
1055
1056         Reviewed by Aakash Jain.
1057
1058         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1059         (DownloadBuiltProduct):
1060
1061 2017-07-11  Lucas Forschler  <lforschler@apple.com>
1062
1063         Configure buildbot to transfer all archives to S3.
1064         Previously this was Mac only, but it's time to expand!
1065         https://bugs.webkit.org/show_bug.cgi?id=174378
1066         
1067         Reviewed by Aakash Jain.
1068
1069         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1070         (BuildFactory.__init__):
1071
1072 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
1073
1074         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
1075         https://bugs.webkit.org/show_bug.cgi?id=174350
1076
1077         Reviewed by Xabier Rodriguez-Calvar.
1078
1079         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
1080         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
1081         patches are removed. The patches for gst-plugins-good are updated, removing
1082         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
1083         rtpbin elements that will help with the EMEv3 development.
1084
1085         * wpe/jhbuild.modules:
1086         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
1087         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
1088         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
1089         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
1090         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1091         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
1092         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1093         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1094         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1095
1096 2017-07-10  John Wilander  <wilander@apple.com>
1097
1098         Resource Load Statistics: Prune statistics in orders of importance
1099         https://bugs.webkit.org/show_bug.cgi?id=174215
1100         <rdar://problem/33164403>
1101
1102         Reviewed by Chris Dumez.
1103
1104         Nest infrastructure. Adds these functions:
1105         1. testRunner.setStatisticsLastSeen()
1106         2. setStatisticsMaxStatisticsEntries()
1107         3. setStatisticsPruneEntriesDownTo()
1108
1109         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1110         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1111         (WTR::TestRunner::setStatisticsLastSeen):
1112         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1113         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1114         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1115         * WebKitTestRunner/TestController.cpp:
1116         (WTR::TestController::setStatisticsLastSeen):
1117         (WTR::TestController::setMaxStatisticsEntries):
1118         (WTR::TestController::setPruneEntriesDownTo):
1119         * WebKitTestRunner/TestController.h:
1120         * WebKitTestRunner/TestInvocation.cpp:
1121         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1122         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1123         (WTR::TestController::setStatisticsLastSeen):
1124         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1125         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1126
1127 2017-07-03  Brian Burg  <bburg@apple.com>
1128
1129         Web Replay: remove some unused code
1130         https://bugs.webkit.org/show_bug.cgi?id=173903
1131
1132         Rubber-stamped by Joseph Pecoraro.
1133
1134         * Scripts/run-input-generator-tests: Removed.
1135         * Scripts/webkitpy/replay/__init__.py: Removed.
1136         * Scripts/webkitpy/replay/main.py: Removed.
1137
1138 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
1139
1140         [WPE] Fix layout test baseline and TestExpectations hierarchy
1141         https://bugs.webkit.org/show_bug.cgi?id=174092
1142
1143         Reviewed by Michael Catanzaro.
1144
1145         Like for the GTK+ port, override the default_baseline_search_path() and
1146         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
1147         Both methods operate on a short list of search paths that defaults to 'wpe' and
1148         'wk2', along with any other user-specified platform directory.
1149
1150         The test_expectations_file_position() method is overridden for testing purposes,
1151         and relevant unit tests are added.
1152
1153         * Scripts/webkitpy/port/wpe.py:
1154         (WPEPort._search_paths):
1155         (WPEPort):
1156         (WPEPort.default_baseline_search_path):
1157         (WPEPort._port_specific_expectations_files):
1158         (WPEPort.test_expectations_file_position):
1159         * Scripts/webkitpy/port/wpe_unittest.py:
1160         (WPEPortTest.test_default_baseline_search_path):
1161         (WPEPortTest):
1162         (WPEPortTest.test_port_specific_expectations_files):
1163
1164 2017-07-10  Chris Dumez  <cdumez@apple.com>
1165
1166         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
1167         https://bugs.webkit.org/show_bug.cgi?id=174301
1168
1169         Reviewed by Brent Fulgham.
1170
1171         Rename some of the testRunner API for clarity and to better match what it calls
1172         internally.
1173
1174         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1175         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1176         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1177         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1178         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1179         * WebKitTestRunner/TestController.cpp:
1180         (WTR::TestController::statisticsUpdateCookiePartitioning):
1181         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1182         * WebKitTestRunner/TestController.h:
1183         * WebKitTestRunner/TestInvocation.cpp:
1184         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1185         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1186         (WTR::TestController::statisticsUpdateCookiePartitioning):
1187         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1188
1189 2017-07-10  Charlie Turner  <cturner@igalia.com>
1190
1191         [GStreamer] Live twitch.tv videos do not play
1192         https://bugs.webkit.org/show_bug.cgi?id=174222
1193
1194         Reviewed by Michael Catanzaro.
1195
1196         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
1197         fixes videos not playing on twitch.tv.
1198
1199         * gtk/jhbuild.modules:
1200
1201 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
1202
1203         Add WebGL2 configuration option to build-webkit
1204         https://bugs.webkit.org/show_bug.cgi?id=174251
1205
1206         Reviewed by Michael Catanzaro.
1207
1208         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
1209         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
1210         is marked as enabled for the Apple Cocoa ports.
1211
1212 2017-07-08  Chris Dumez  <cdumez@apple.com>
1213
1214         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
1215         https://bugs.webkit.org/show_bug.cgi?id=174290
1216
1217         Reviewed by Brent Fulgham.
1218
1219         Rename testRunner API to match the new internal API names.
1220
1221         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1222         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1223         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1224         (WTR::TestRunner::statisticsSubmitTelemetry):
1225         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1226         * WebKitTestRunner/TestController.cpp:
1227         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1228         (WTR::TestController::statisticsSubmitTelemetry):
1229         * WebKitTestRunner/TestController.h:
1230         * WebKitTestRunner/TestInvocation.cpp:
1231         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1232         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1233         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1234         (WTR::TestController::statisticsSubmitTelemetry):
1235
1236 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1237
1238         Drop NOSNIFF compile flag
1239         https://bugs.webkit.org/show_bug.cgi?id=174289
1240
1241         Reviewed by Michael Catanzaro.
1242
1243         * Scripts/webkitperl/FeatureList.pm:
1244         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1245
1246 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1247
1248         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
1249         https://bugs.webkit.org/show_bug.cgi?id=174219
1250         <rdar://problem/32083177>
1251
1252         Reviewed by Ryosuke Niwa.
1253
1254         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
1255         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
1256         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
1257         place.
1258
1259         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
1260         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
1261         no action is taken when dropping.
1262
1263         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
1264         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1265         (TestWebKitAPI::TEST):
1266         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1267         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1268         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
1269         (-[MockDragDropSession allowsMoveOperation]):
1270         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
1271         (-[MockDataInteractionSession initWithWindow:allowMove:]):
1272         (-[DataInteractionSimulator initWithWebView:]):
1273         (-[DataInteractionSimulator runFrom:to:]):
1274         (-[DataInteractionSimulator _advanceProgress]):
1275         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
1276         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
1277         (-[MockDataInteractionSession initWithWindow:]): Deleted.
1278
1279 2017-07-07  Commit Queue  <commit-queue@webkit.org>
1280
1281         Unreviewed, rolling out r219238, r219239, and r219241.
1282         https://bugs.webkit.org/show_bug.cgi?id=174265
1283
1284         "fast/workers/dedicated-worker-lifecycle.html is flaky"
1285         (Requested by yusukesuzuki on #webkit).
1286
1287         Reverted changesets:
1288
1289         "[WTF] Implement WTF::ThreadGroup"
1290         https://bugs.webkit.org/show_bug.cgi?id=174081
1291         http://trac.webkit.org/changeset/219238
1292
1293         "Unreviewed, build fix after r219238"
1294         https://bugs.webkit.org/show_bug.cgi?id=174081
1295         http://trac.webkit.org/changeset/219239
1296
1297         "Unreviewed, CLoop build fix after r219238"
1298         https://bugs.webkit.org/show_bug.cgi?id=174081
1299         http://trac.webkit.org/changeset/219241
1300
1301 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1302
1303         [GTK][WPE] Enable X-Content-Type-Options: nosniff
1304         https://bugs.webkit.org/show_bug.cgi?id=174250
1305
1306         Reviewed by Carlos Alberto Lopez Perez.
1307
1308         * Scripts/webkitperl/FeatureList.pm:
1309
1310 2017-07-07  Charlie Turner  <cturner@igalia.com>
1311         [GStreamer] vid.me videos do not play
1312         https://bugs.webkit.org/show_bug.cgi?id=172240
1313
1314         Reviewed by Xabier Rodriguez-Calvar.
1315
1316         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1317         have the existing libsoup build against GNOME to avoid header drift
1318         against GStreamer's linked Soup library.
1319
1320         * gtk/jhbuild.modules:
1321
1322 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1323
1324         Write a support script to enable buildbot to upload to S3
1325         https://bugs.webkit.org/show_bug.cgi?id=174196
1326         
1327         Reviewed by Stephanie Lewis.
1328
1329         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
1330         (uploadToS3):
1331         (archiveExists):
1332
1333 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1334
1335         Enabling uploading archives to S3.
1336         https://bugs.webkit.org/show_bug.cgi?id=174198
1337         
1338         Reviewed by Stephanie Lewis.
1339
1340         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1341         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1342         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1343         (TransferToS3): Transfer full and minified archives to S3
1344
1345 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1346
1347         [WTF] Implement WTF::ThreadGroup
1348         https://bugs.webkit.org/show_bug.cgi?id=174081
1349
1350         Reviewed by Mark Lam.
1351
1352         Add WTF::ThreadGroup tests.
1353
1354         * TestWebKitAPI/CMakeLists.txt:
1355         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1356         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1357         (TestWebKitAPI::TEST):
1358
1359 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
1360
1361         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1362         https://bugs.webkit.org/show_bug.cgi?id=174150
1363
1364         Reviewed by Mark Lam.
1365
1366         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1367         (TestWebKitAPI::TEST):
1368         * TestWebKitAPI/TestsController.cpp:
1369         (TestWebKitAPI::TestsController::TestsController):
1370
1371 2017-07-06  Lucas Forschler  <lforschler@apple.com>
1372
1373         Enabling uploading archives to S3.
1374         https://bugs.webkit.org/show_bug.cgi?id=174198
1375         
1376         Reviewed by Lucas Forschler.
1377
1378         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1379         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
1380         (UploadMinifiedBuiltProduct): Upload minified archive to build master
1381         (TransferToS3): Transfer full and minified archives to S3
1382
1383 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1384
1385         [GTK][WPE] kill-old-process should kill more webkit related process
1386         https://bugs.webkit.org/show_bug.cgi?id=174220
1387
1388         Reviewed by Michael Catanzaro.
1389
1390         Generate list of possible webkit-related process names and add
1391         them to the list of process to kill.
1392         Also update the possible system related process for GTK+/WPE.
1393
1394         * BuildSlaveSupport/kill-old-processes:
1395         (listAllWebKitPrograms):
1396         (main):
1397
1398 2017-07-06  Chris Dumez  <cdumez@apple.com>
1399
1400         FileMonitor should not be ref counted
1401         https://bugs.webkit.org/show_bug.cgi?id=174166
1402
1403         Reviewed by Brent Fulgham.
1404
1405         Update the API tests to reflect the API change.
1406
1407         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1408         (TestWebKitAPI::TEST_F):
1409
1410 2017-07-06  Commit Queue  <commit-queue@webkit.org>
1411
1412         Unreviewed, rolling out r219194.
1413         https://bugs.webkit.org/show_bug.cgi?id=174207
1414
1415         it broke some layout tests (Requested by clopez on #webkit).
1416
1417         Reverted changeset:
1418
1419         "[GStreamer] vid.me videos do not play"
1420         https://bugs.webkit.org/show_bug.cgi?id=172240
1421         http://trac.webkit.org/changeset/219194
1422
1423 2017-07-06  Matt Lewis  <jlewis3@apple.com>
1424
1425         Unreviewed, rolling out r219178.
1426
1427         This caused a consistent failure with the API test
1428         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
1429
1430         Reverted changeset:
1431
1432         "[WTF] Clean up StringStatics.cpp by using
1433         LazyNeverDestroyed<> for Atoms"
1434         https://bugs.webkit.org/show_bug.cgi?id=174150
1435         http://trac.webkit.org/changeset/219178
1436
1437 2017-07-06  Alicia Boya García  <aboya@igalia.com>
1438
1439         Add CWD to Perl library path (no longer the default since 5.26.0)
1440         https://bugs.webkit.org/show_bug.cgi?id=174200
1441
1442         Reviewed by Michael Catanzaro.
1443
1444         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1445         (SetupGitClone._get_username_and_email):
1446
1447 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1448
1449         Unreviewed, update my email address.
1450
1451         * Scripts/webkitpy/common/config/contributors.json:
1452
1453 2017-07-06  Charlie Turner  <cturner@igalia.com>
1454         [GStreamer] vid.me videos do not play
1455         https://bugs.webkit.org/show_bug.cgi?id=172240
1456
1457         Reviewed by Xabier Rodriguez-Calvar.
1458
1459         Build httpsoupsrc again for use in adaptive streaming pipelines, and
1460         have the existing libsoup build against GNOME to avoid header drift
1461         against GStreamer's linked Soup library.
1462
1463         * gtk/jhbuild.modules:
1464
1465 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
1466
1467         [WTF] Move SoftLinking.h into WTF
1468         https://bugs.webkit.org/show_bug.cgi?id=174000
1469
1470         Reviewed by Alex Christensen.
1471
1472         * DumpRenderTree/mac/TestRunnerMac.mm:
1473         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1474         (test_primary_header):
1475         (ErrorCollector.__init__): Deleted.
1476         (ErrorCollector.__call__): Deleted.
1477         (ErrorCollector.results): Deleted.
1478         (ErrorCollector.result_list): Deleted.
1479         (ErrorCollector.verify_all_categories_are_seen): Deleted.
1480         (MockIo.open): Deleted.
1481         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
1482         (CppFunctionsTest.test_create_acronym): Deleted.
1483         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
1484         (CppFunctionsTest.test_parameter): Deleted.
1485         (CppFunctionsTest.test_single_line_view): Deleted.
1486         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
1487         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
1488         (CppFunctionsTest.test_parameter_list): Deleted.
1489         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
1490         (CppStyleTestBase.process_file_data): Deleted.
1491         (CppStyleTestBase.perform_lint): Deleted.
1492         (CppStyleTestBase.perform_single_line_lint): Deleted.
1493         (CppStyleTestBase.perform_multi_line_lint): Deleted.
1494         (CppStyleTestBase.perform_language_rules_check): Deleted.
1495         (CppStyleTestBase.perform_function_lengths_check): Deleted.
1496         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
1497         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
1498         (CppStyleTestBase.perform_include_what_you_use): Deleted.
1499         (CppStyleTestBase.perform_header_guard_check): Deleted.
1500         (CppStyleTestBase.assert_lint): Deleted.
1501         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
1502         (CppStyleTestBase.assert_multi_line_lint): Deleted.
1503         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
1504         (CppStyleTestBase.assert_language_rules_check): Deleted.
1505         (CppStyleTestBase.assert_include_what_you_use): Deleted.
1506         (CppStyleTestBase.assert_header_guard): Deleted.
1507         (CppStyleTestBase.assert_blank_lines_check): Deleted.
1508         (CppStyleTestBase.assert_positions_equal): Deleted.
1509         (FunctionDetectionTest.test_basic_function_detection): Deleted.
1510         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
1511         (FunctionDetectionTest.test_pure_function_detection): Deleted.
1512         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
1513         (FunctionDetectionTest.test_ignore_macros): Deleted.
1514         (FunctionDetectionTest.test_non_functions): Deleted.
1515         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
1516         (FunctionDetectionTest.test_parameter_list): Deleted.
1517         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
1518         (CppStyleTest.test_asm_lines_ignored): Deleted.
1519         (CppStyleTest.test_get_line_width): Deleted.
1520         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
1521         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
1522         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
1523         (CppStyleTest.test_position): Deleted.
1524         (CppStyleTest.test_rfind_in_lines): Deleted.
1525         (CppStyleTest.test_close_expression): Deleted.
1526         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
1527         (CppStyleTest.test_cstyle_cast): Deleted.
1528         (CppStyleTest.test_runtime_casting): Deleted.
1529         (CppStyleTest.test_runtime_selfinit): Deleted.
1530         (CppStyleTest.test_runtime_rtti): Deleted.
1531         (CppStyleTest.test_static_cast_readability): Deleted.
1532         (CppStyleTest.test_check_for_unnamed_params): Deleted.
1533         (CppStyleTest.void): Deleted.
1534         (CppStyleTest.test_deprecated_cast): Deleted.
1535         (CppStyleTest.test_mock_method): Deleted.
1536         (CppStyleTest.test_sizeof_type): Deleted.
1537         (CppStyleTest.cases): Deleted.
1538         (CppStyleTest.for): Deleted.
1539         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
1540         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
1541         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
1542         (CppStyleTest.test_include_what_you_use): Deleted.
1543         (CppStyleTest.test_files_belong_to_same_module): Deleted.
1544         (CppStyleTest.test_cleanse_line): Deleted.
1545         (CppStyleTest.test_multi_line_comments): Deleted.
1546         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
1547         (CppStyleTest.test_multiline_strings): Deleted.
1548         (CppStyleTest.test_platformh_comments): Deleted.
1549         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
1550         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
1551         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
1552         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
1553         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
1554         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
1555         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
1556         (CppStyleTest.test_check_posix_threading): Deleted.
1557         (CppStyleTest.test_insecure_string_operations): Deleted.
1558         (CppStyleTest.test_format_strings): Deleted.
1559         (CppStyleTest.test_insecure_temp_file): Deleted.
1560         (CppStyleTest.test_variable_length_array_detection): Deleted.
1561         (CppStyleTest.test_braces): Deleted.
1562         (CppStyleTest.test_check_check): Deleted.
1563         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
1564         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
1565         (CppStyleTest.test_spacing_for_fncall): Deleted.
1566         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
1567         (CppStyleTest.test_spacing_before_braces): Deleted.
1568         (CppStyleTest.test_spacing_between_braces): Deleted.
1569         (CppStyleTest.test_spacing_before_brackets): Deleted.
1570         (CppStyleTest.test_cpp_lambda_functions): Deleted.
1571         (CppStyleTest.test_objective_c_block): Deleted.
1572         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
1573         (CppStyleTest.test_spacing_around_else): Deleted.
1574         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
1575         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
1576         (CppStyleTest.test_operator_methods): Deleted.
1577         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
1578         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
1579         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
1580         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
1581         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
1582         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
1583         (CppStyleTest.test_space_after_comment_marker): Deleted.
1584         (CppStyleTest.test_newline_at_eof): Deleted.
1585         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
1586         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
1587         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
1588         (CppStyleTest.test_invalid_utf8): Deleted.
1589         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
1590         (CppStyleTest.test_is_blank_line): Deleted.
1591         (CppStyleTest.test_blank_lines_check): Deleted.
1592         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
1593         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
1594         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
1595         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
1596         (CppStyleTest.test_comma): Deleted.
1597         (CppStyleTest.test_declaration): Deleted.
1598         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
1599         (CppStyleTest.test_indent): Deleted.
1600         (CppStyleTest.test_indent.Foo): Deleted.
1601         (CppStyleTest.test_not_alabel): Deleted.
1602         (CppStyleTest.test_tab): Deleted.
1603         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
1604         (CppStyleTest.test_build_class): Deleted.
1605         (CppStyleTest.test_build_class.definitions): Deleted.
1606         (CppStyleTest.test_build_class.Foo): Deleted.
1607         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
1608         (CppStyleTest.test_build_end_comment): Deleted.
1609         (CppStyleTest.test_build_forward_decl): Deleted.
1610         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
1611         (CppStyleTest.test_build_header_guard): Deleted.
1612         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
1613         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
1614         (CppStyleTest.test_build_printf_format): Deleted.
1615         (CppStyleTest.test_runtime_printf_format): Deleted.
1616         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
1617         (CppStyleTest.test_build_storage_class): Deleted.
1618         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
1619         (CppStyleTest.test_build_storage_class.declaration): Deleted.
1620         (CppStyleTest.test_build_storage_class.after): Deleted.
1621         (CppStyleTest.test_build_storage_class.is): Deleted.
1622         (CppStyleTest.test_legal_copyright): Deleted.
1623         (CppStyleTest.test_invalid_increment): Deleted.
1624         (CppStyleTest.test_enum_bitfields): Deleted.
1625         (CppStyleTest.test_plain_integral_bitfields): Deleted.
1626         (CleansedLinesTest.test_init_empty): Deleted.
1627         (CleansedLinesTest.test_collapse_strings): Deleted.
1628         (OrderOfIncludesTest.tearDown): Deleted.
1629         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
1630         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
1631         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
1632         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
1633         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
1634         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
1635         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
1636         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
1637         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
1638         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
1639         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
1640         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
1641         (OrderOfIncludesTest.test_primary_header): Deleted.
1642         (OrderOfIncludesTest.test_public_primary_header): Deleted.
1643         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
1644         (OrderOfIncludesTest.test_classify_include): Deleted.
1645         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
1646         (CheckForFunctionLengthsTest.tearDown): Deleted.
1647         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
1648         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
1649         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
1650         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
1651         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
1652         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
1653         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
1654         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
1655         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
1656         (CheckForFunctionLengthsTest.function_body): Deleted.
1657         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
1658         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
1659         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
1660         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
1661         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
1662         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
1663         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
1664         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
1665         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
1666         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
1667         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
1668         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
1669         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
1670         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
1671         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
1672         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
1673         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
1674         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
1675         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
1676         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
1677         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
1678         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
1679         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
1680         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
1681         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
1682         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
1683         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
1684         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
1685         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
1686         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
1687         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
1688         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
1689         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
1690         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
1691         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
1692         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
1693         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
1694         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
1695         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
1696         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
1697         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
1698         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
1699         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
1700         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
1701         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
1702         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
1703         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
1704         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
1705         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
1706         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
1707         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
1708         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
1709         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
1710         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
1711         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
1712         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
1713         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
1714         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
1715         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
1716         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
1717         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
1718         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
1719         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
1720         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
1721         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
1722         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
1723         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
1724         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
1725         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
1726         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
1727         (LeakyPatternTest.test_get_dc): Deleted.
1728         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
1729         (LeakyPatternTest.test_own_get_dc): Deleted.
1730         (LeakyPatternTest.test_create_dc): Deleted.
1731         (LeakyPatternTest.test_create_compatible_dc): Deleted.
1732         (WebKitStyleTest.test_indentation): Deleted.
1733         (WebKitStyleTest.test_indentation.Foo): Deleted.
1734         (WebKitStyleTest.test_indentation.Document): Deleted.
1735         (WebKitStyleTest.test_spacing): Deleted.
1736         (WebKitStyleTest.test_line_breaking): Deleted.
1737         (WebKitStyleTest.test_braces): Deleted.
1738         (WebKitStyleTest.test_braces.MyClass): Deleted.
1739         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
1740         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
1741         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
1742         (WebKitStyleTest.test_null_false_zero): Deleted.
1743         (WebKitStyleTest.test_directive_indentation): Deleted.
1744         (WebKitStyleTest.test_using_std): Deleted.
1745         (WebKitStyleTest.test_using_namespace): Deleted.
1746         (WebKitStyleTest.test_max_macro): Deleted.
1747         (WebKitStyleTest.test_min_macro): Deleted.
1748         (WebKitStyleTest.test_wtf_move): Deleted.
1749         (WebKitStyleTest.test_ctype_fucntion): Deleted.
1750         (WebKitStyleTest.test_names): Deleted.
1751         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
1752         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
1753         (WebKitStyleTest.test_names.declarations): Deleted.
1754         (WebKitStyleTest.test_names.struct): Deleted.
1755         (WebKitStyleTest.test_names.VectorType): Deleted.
1756         (WebKitStyleTest.test_parameter_names): Deleted.
1757         (WebKitStyleTest.test_comments): Deleted.
1758         (WebKitStyleTest.test_webkit_export_check): Deleted.
1759         (WebKitStyleTest.test_member_initialization_list): Deleted.
1760         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
1761         (WebKitStyleTest.test_other): Deleted.
1762         (CppCheckerTest.mock_handle_style_error): Deleted.
1763         (CppCheckerTest._checker): Deleted.
1764         (CppCheckerTest.test_init): Deleted.
1765         (CppCheckerTest.test_eq): Deleted.
1766         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
1767         (CppCheckerTest.test_ne): Deleted.
1768         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1769         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1770         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1771         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1772         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1773         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1774
1775 2017-07-05  Saam Barati  <sbarati@apple.com>
1776
1777         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
1778         https://bugs.webkit.org/show_bug.cgi?id=174188
1779         <rdar://problem/30581423>
1780
1781         Reviewed by Mark Lam.
1782
1783         * Scripts/run-jsc-stress-tests:
1784
1785 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1786
1787         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
1788         https://bugs.webkit.org/show_bug.cgi?id=174150
1789
1790         Reviewed by Mark Lam.
1791
1792         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1793         (TestWebKitAPI::TEST):
1794
1795 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
1796
1797         Remove copy of ICU headers from WebKit
1798         https://bugs.webkit.org/show_bug.cgi?id=116407
1799
1800         Reviewed by Alex Christensen.
1801
1802         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1803         * TestWebKitAPI/Configurations/Base.xcconfig:
1804         * WebKitTestRunner/Configurations/Base.xcconfig:
1805
1806 2017-07-05  Chris Dumez  <cdumez@apple.com>
1807
1808         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
1809         https://bugs.webkit.org/show_bug.cgi?id=174163
1810         <rdar://problem/33067518>
1811
1812         Reviewed by Alex Christensen.
1813
1814         Add API test coverage.
1815
1816         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1817         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
1818         (TEST):
1819
1820 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1821
1822         When dragging a selection, clearing the selection in dragstart should not crash the web process
1823         https://bugs.webkit.org/show_bug.cgi?id=174142
1824         <rdar://problem/33067501>
1825
1826         Reviewed by Tim Horton.
1827
1828         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
1829         drag is starting up.
1830
1831         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1832         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
1833         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1834         (TestWebKitAPI::TEST):
1835
1836 2017-07-05  Daniel Bates  <dabates@apple.com>
1837
1838         Do not pass API::FrameInfo for source frame or clear out page of target frame on
1839         API navigation
1840         https://bugs.webkit.org/show_bug.cgi?id=174170
1841         <rdar://problem/33140328>
1842
1843         Reviewed by Brady Eidson.
1844
1845         Update tests as needed for the behavior change.
1846
1847         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
1848         (TEST):
1849
1850 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
1851
1852         Add WebKitPrivateFrameworkStubs for iOS 11
1853         https://bugs.webkit.org/show_bug.cgi?id=173988
1854
1855         Reviewed by David Kilzer.
1856
1857         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
1858         should use the same directory for private framework stubs.
1859         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1860
1861 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
1862
1863         [MediaStream] Protect request and web view during gUM client callback
1864         https://bugs.webkit.org/show_bug.cgi?id=174096
1865         <rdar://problem/32833102>
1866
1867         Reviewed by Youenn Fablet.
1868
1869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1870         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
1871
1872 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1873
1874         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
1875
1876         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1877
1878 2017-07-05  Matt Lewis  <jlewis3@apple.com>
1879
1880         Unreviewed, rolling out r219128.
1881
1882         Spoke with engineer who originally submitted, Patch for APi
1883         test to follow.
1884
1885         Reverted changeset:
1886
1887         "Unreviewed, rolling out r219070."
1888         https://bugs.webkit.org/show_bug.cgi?id=174082
1889         http://trac.webkit.org/changeset/219128
1890
1891 2017-07-05  Matt Lewis  <jlewis3@apple.com>
1892
1893         Unreviewed, rolling out r219070.
1894
1895         This revision caused consistent failures of the API test
1896         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
1897
1898         Reverted changeset:
1899
1900         "Pasting single words copied to UIPasteboard inserts URLs in
1901         editable areas"
1902         https://bugs.webkit.org/show_bug.cgi?id=174082
1903         http://trac.webkit.org/changeset/219070
1904
1905 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1906
1907         Remove unused EFL logo from bot watcher dashboard
1908         https://bugs.webkit.org/show_bug.cgi?id=174136
1909
1910         Reviewed by Alexey Proskuryakov.
1911
1912         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
1913         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
1914
1915 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1916
1917         [GTK] Add more GTK bots to dashboard
1918         https://bugs.webkit.org/show_bug.cgi?id=174129
1919
1920         Reviewed by Carlos Alberto Lopez Perez.
1921
1922         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
1923         them.
1924
1925         This also changes the sort order to put WPE above GTK so that it's not buried under all the
1926         less-essential GTK bots.
1927
1928         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1929         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1930         (WebKitBuildbot):
1931
1932 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1933
1934         [WPE] Add WPE to bot watcher dashboard
1935         https://bugs.webkit.org/show_bug.cgi?id=174119
1936
1937         Reviewed by Alexey Proskuryakov.
1938
1939         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
1940         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
1941         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
1942         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1944         (WebKitBuildbot):
1945         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1946         (table.queue-grid tr.platform.linux-wpe img.logo):
1947
1948 2017-07-03  Lucas Forschler  <lforschler@apple.com>
1949
1950         https://bugs.webkit.org/show_bug.cgi?id=174105
1951         
1952         Reviewed by Stephanie Lewis.
1953
1954         * BuildSlaveSupport/built-product-archive:
1955         (main): Add a -minify parser option
1956         (createZip): Pass along the optional Minify argument if requested
1957         (minifySource): This will trim down archives, logic limited to Mac platform.
1958
1959 2017-07-03  Matt Rajca  <mrajca@apple.com>
1960
1961         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
1962         https://bugs.webkit.org/show_bug.cgi?id=174103
1963
1964         Reviewed by Alex Christensen.
1965
1966         Added an API test.
1967
1968         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
1969         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1970         (TEST): Added test.
1971         * TestWebKitAPI/cocoa/TestWKWebView.h:
1972         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1973         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
1974
1975 2017-07-03  Matt Lewis  <jlewis3@apple.com>
1976
1977         Unreviewed, rolling out r219103.
1978
1979         Caused multiple build failures.
1980
1981         Reverted changeset:
1982
1983         "Remove copy of ICU headers from WebKit"
1984         https://bugs.webkit.org/show_bug.cgi?id=116407
1985         http://trac.webkit.org/changeset/219103
1986
1987 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
1988
1989         Remove copy of ICU headers from WebKit
1990         https://bugs.webkit.org/show_bug.cgi?id=116407
1991
1992         Reviewed by Alex Christensen.
1993
1994         Use WTF's copy of ICU headers.
1995
1996         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1997         * TestWebKitAPI/Configurations/Base.xcconfig:
1998         * WebKitTestRunner/Configurations/Base.xcconfig:
1999
2000 2017-07-03  Brady Eidson  <beidson@apple.com>
2001
2002         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2003         https://bugs.webkit.org/show_bug.cgi?id=174073
2004
2005         Reviewed by Andy Estes.
2006
2007         * DumpRenderTree/mac/TestRunnerMac.mm:
2008         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
2009
2010         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
2011         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2012
2013 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2014
2015         Unreviewed, rolling out r219083.
2016
2017         The revision caused an API failure on all testing platforms.
2018
2019         Reverted changeset:
2020
2021         "[MediaStream] Protect request and web view during gUM client
2022         callback"
2023         https://bugs.webkit.org/show_bug.cgi?id=174096
2024         http://trac.webkit.org/changeset/219083
2025
2026 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
2027
2028         webkitpy: Properly number duplicated crashlogs
2029         https://bugs.webkit.org/show_bug.cgi?id=172002
2030
2031         Reviewed by Aakash Jain.
2032
2033         * Scripts/webkitpy/common/system/crashlogs.py:
2034         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
2035         an increasing integer.
2036         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2037         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
2038         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
2039         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
2040
2041 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
2042
2043         WebContent processes crash when the network process crashes with pending connection requests
2044         https://bugs.webkit.org/show_bug.cgi?id=174065
2045         <rdar://problem/30359835>
2046
2047         Reviewed by Tim Horton.
2048
2049         Add a API to ensure UI process tries to relaunch a new network process when the network process
2050         crashes with pending network connection requests.
2051
2052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2053         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
2054         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2055         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2056         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
2057
2058 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
2059
2060         [MediaStream] Protect request and web view during gUM client callback
2061         https://bugs.webkit.org/show_bug.cgi?id=174096
2062         <rdar://problem/32833102>
2063
2064         Reviewed by Youenn Fablet.
2065
2066         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2067         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2068
2069 2017-07-03  Andy Estes  <aestes@apple.com>
2070
2071         [Xcode] Add an experimental setting to build with ccache
2072         https://bugs.webkit.org/show_bug.cgi?id=173875
2073
2074         Reviewed by Tim Horton.
2075
2076         On systems that already have ccache(1) installed, this patch adds experimental support for
2077         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
2078
2079         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
2080         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
2081         find the toolchain from which to run clang, and then invokes ccache with the required
2082         arguments.
2083
2084         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
2085         precompiled headers to work properly [1].
2086
2087         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
2088         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
2089         during linking.
2090         
2091         [1] https://ccache.samba.org/manual.html#_precompiled_headers
2092
2093         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
2094         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2095         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2096         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
2097         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
2098         * ccache/README.md: Added.
2099         * ccache/ccache-clang: Added.
2100         * ccache/ccache-clang++: Added.
2101         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
2102
2103 2017-07-03  Alex Christensen  <achristensen@webkit.org>
2104
2105         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2106         https://bugs.webkit.org/show_bug.cgi?id=174051
2107
2108         Reviewed by Tim Horton.
2109
2110         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2111         (TestWebKitAPI::TEST_F):
2112
2113 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2114
2115         Unreviewed, rolling out r219024.
2116
2117         This patch cause 3 didferent test to fail.
2118
2119         Reverted changeset:
2120
2121         "REGRESSION(r215096) Queries of URLs with non-special schemes
2122         should not percent-encode single quotes"
2123         https://bugs.webkit.org/show_bug.cgi?id=174051
2124         http://trac.webkit.org/changeset/219024
2125
2126 2017-07-03  Chris Dumez  <cdumez@apple.com>
2127
2128         Drop ResourceLoadStatisticsStore's statisticsLock
2129         https://bugs.webkit.org/show_bug.cgi?id=174080
2130
2131         Reviewed by Brent Fulgham.
2132
2133         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
2134
2135         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2136         (WTR::TestController::isStatisticsPrevalentResource):
2137         (WTR::TestController::isStatisticsHasHadUserInteraction):
2138         (WTR::TestController::isStatisticsGrandfathered):
2139
2140 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2141
2142         Pasting single words copied to UIPasteboard inserts URLs in editable areas
2143         https://bugs.webkit.org/show_bug.cgi?id=174082
2144         <rdar://problem/33046992>
2145
2146         Reviewed by Tim Horton.
2147
2148         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
2149
2150         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2151         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2152         (TestWebKitAPI::TEST):
2153
2154 2017-07-02  Brady Eidson  <beidson@apple.com>
2155
2156         Add API test for all parts of WebKit1 API related to favicons.
2157         https://bugs.webkit.org/show_bug.cgi?id=174069
2158
2159         Reviewed by Andy Estes.
2160
2161         These two API tests cover all WebKit1 API related to icons.
2162         
2163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2164         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
2165         (mainResourceData):
2166         (defaultFaviconData):
2167         (customFaviconData):
2168         (imageFromData):
2169         (+[IconLoadingProtocol canInitWithRequest:]):
2170         (+[IconLoadingProtocol canonicalRequestForRequest:]):
2171         (-[IconLoadingProtocol startLoading]):
2172         (-[IconLoadingProtocol stopLoading]):
2173         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2174         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
2175         (TestWebKitAPI::TEST):
2176
2177 2017-07-01  Dan Bernstein  <mitz@apple.com>
2178
2179         [iOS] Remove code only needed when building for iOS 9.x
2180         https://bugs.webkit.org/show_bug.cgi?id=174068
2181
2182         Reviewed by Tim Horton.
2183
2184         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2185         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2186         (WTR::initializeWebViewConfiguration):
2187         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2188         (-[HIDEventGenerator _createIOHIDEventType:]):
2189
2190 2017-07-01  Brady Eidson  <beidson@apple.com>
2191
2192         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
2193         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
2194
2195         Reviewed by Alex Christensen.
2196
2197         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2198
2199 2017-07-01  Dan Bernstein  <mitz@apple.com>
2200
2201         [macOS] Remove code only needed when building for OS X Yosemite
2202         https://bugs.webkit.org/show_bug.cgi?id=174067
2203
2204         Reviewed by Tim Horton.
2205
2206         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2207         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2208         * DumpRenderTree/mac/DumpRenderTree.mm:
2209         (setDefaultsToConsistentValuesForTesting):
2210         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2211         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
2212         * MiniBrowser/Configurations/Base.xcconfig:
2213         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2214         * TestWebKitAPI/Configurations/Base.xcconfig:
2215         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2216         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2217         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2218         (TestWebKitAPI::TEST_F):
2219         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2220         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
2221         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2222         (TestWebKitAPI::TEST_F):
2223         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2224         (TestWebKitAPI::TEST):
2225         * WebKitTestRunner/Configurations/Base.xcconfig:
2226         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2227         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2228         (WTR::InjectedBundle::platformInitialize):
2229         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2230         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
2231
2232 2017-07-01  Chris Dumez  <cdumez@apple.com>
2233
2234         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
2235         https://bugs.webkit.org/show_bug.cgi?id=174060
2236
2237         Reviewed by Brent Fulgham.
2238
2239         Port WebKitTestRunner over to the new Cocoa SPI.
2240
2241         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2242         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2243         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2244         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
2245         no-ops since this code runs in the WebContent process, not the
2246         UIProcess.
2247
2248         * WebKitTestRunner/TestController.cpp:
2249         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2250
2251 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2252
2253         Unreviewed mac build fix.
2254
2255         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2256         (TestWebKitAPI::TEST):
2257
2258 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
2259
2260         Add API to get WKActivatedElementInfo
2261         https://bugs.webkit.org/show_bug.cgi?id=174001
2262         <rdar://problem/29165518>
2263         
2264         Tests for now SPI to get activatedElementInfo.
2265
2266         Reviewed by Tim Horton.
2267
2268         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2269         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
2270         (TestWebKitAPI::TEST):
2271
2272 2017-06-30  Chris Dumez  <cdumez@apple.com>
2273
2274         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
2275         https://bugs.webkit.org/show_bug.cgi?id=174038
2276
2277         Reviewed by Brent Fulgham.
2278
2279         Fix typo in API name.
2280
2281         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2282         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2283         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2284         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2285         * WebKitTestRunner/TestController.cpp:
2286         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2287         * WebKitTestRunner/TestController.h:
2288         * WebKitTestRunner/TestInvocation.cpp:
2289         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2290
2291 2017-06-30  Alex Christensen  <achristensen@webkit.org>
2292
2293         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
2294         https://bugs.webkit.org/show_bug.cgi?id=174051
2295         <rdar://problem/33002846>
2296
2297         Reviewed by Tim Horton.
2298
2299         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2300         (TestWebKitAPI::TEST_F):
2301
2302 2017-06-30  Daniel Bates  <dabates@apple.com>
2303
2304         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2305         https://bugs.webkit.org/show_bug.cgi?id=165160
2306         <rdar://problem/29451999>
2307
2308         Reviewed by Brady Eidson.
2309
2310         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
2311         for navigations and window creation.
2312
2313         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2314         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
2315         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
2316         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
2317         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2318         (TEST):
2319
2320 2017-06-29  Jer Noble  <jer.noble@apple.com>
2321
2322         Make Legacy EME API controlled by RuntimeEnabled setting.
2323         https://bugs.webkit.org/show_bug.cgi?id=173994
2324
2325         Reviewed by Sam Weinig.
2326
2327         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2328
2329 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2330
2331         Follow-up fix for r218996
2332
2333         Unreviewed infrastructure fix.
2334
2335         Repeated calls to 'ios_version' make the log noisy, memoize the function.
2336
2337         * Scripts/webkitpy/port/ios_simulator.py:
2338         (IOSSimulatorPort): Memoize ios_version().
2339
2340 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2341
2342         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
2343         https://bugs.webkit.org/show_bug.cgi?id=174017
2344         <rdar://problem/32959782>
2345
2346         Reviewed by Simon Fraser.
2347
2348         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
2349         changes, the caret would appear outside of the iframe.
2350
2351         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2352         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
2353         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2354         (checkDragCaretRectIsContainedInRect):
2355         (TestWebKitAPI::TEST):
2356         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2357         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2358         (-[DataInteractionSimulator _resetSimulatedState]):
2359         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2360         (-[DataInteractionSimulator _advanceProgress]):
2361         (-[DataInteractionSimulator lastKnownDragCaretRect]):
2362
2363 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
2364
2365         Add support for different versions of iOS when loading test expectations
2366         https://bugs.webkit.org/show_bug.cgi?id=173774
2367         <rdar://problem/32951132>
2368
2369         Rubber-stamped by Aakash Jain.
2370
2371         When running layout tests, we should support multiple version of iOS the same way we do Mac.
2372
2373         * Scripts/webkitpy/port/ios.py:
2374         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
2375         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
2376         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
2377         * Scripts/webkitpy/port/ios_device.py:
2378         (IOSDevicePort.ios_version): Ask connected devices for implementation.
2379         * Scripts/webkitpy/port/ios_device_unittest.py:
2380         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
2381         (IOSDeviceTest.test_baseline_searchpath): Ditto.
2382         (IOSDeviceTest.test_expectations_ordering): Ditto.
2383         * Scripts/webkitpy/port/ios_simulator.py:
2384         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
2385         ask the platform.
2386
2387 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
2388
2389         Fontconfig build breaks with glibc 2.15+
2390         https://bugs.webkit.org/show_bug.cgi?id=174019
2391
2392         Reviewed by Carlos Alberto Lopez Perez.
2393
2394         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
2395
2396         * wpe/jhbuild.modules:
2397         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
2398
2399 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2400
2401         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
2402         https://bugs.webkit.org/show_bug.cgi?id=174010
2403         <rdar://problem/32597802>
2404
2405         Reviewed by Tim Horton.
2406
2407         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
2408         snapshot fails for any reason.
2409
2410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2411         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
2412         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2413         (TestWebKitAPI::TEST):
2414
2415 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
2416
2417         AX: Cannot call setValue() on contenteditable or ARIA text controls
2418         https://bugs.webkit.org/show_bug.cgi?id=173520
2419
2420         Reviewed by Ryosuke Niwa.
2421
2422         Add setValue() method to WKTR (already existed in DRT).
2423
2424         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2425         (WTR::AccessibilityUIElement::setValue):
2426         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2427         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2428         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2429         (WTR::AccessibilityUIElement::setValue):
2430
2431 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
2432
2433         getBoundingClientRect returns wrong value for combination of page zoom and scroll
2434         https://bugs.webkit.org/show_bug.cgi?id=173841
2435         rdar://problem/32983841
2436
2437         Reviewed by Dean Jackson.
2438
2439         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
2440         always did text zooming.
2441
2442         * MiniBrowser/mac/WK1BrowserWindowController.m:
2443         (-[WK1BrowserWindowController zoomIn:]):
2444         (-[WK1BrowserWindowController zoomOut:]):
2445         (-[WK1BrowserWindowController canResetZoom]):
2446         (-[WK1BrowserWindowController resetZoom:]):
2447
2448 2017-06-29  John Wilander  <wilander@apple.com>
2449
2450         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
2451         https://bugs.webkit.org/show_bug.cgi?id=173940
2452         <rdar://problem/33018125>
2453
2454         Reviewed by Brent Fulgham.
2455
2456         This change allows the TestController to turn off
2457         regular resource load statistics telemetry submission
2458         and to manually control when telemetry is calculated
2459         and submitted.
2460
2461         * WebKitTestRunner/TestController.cpp:
2462         (WTR::TestController::initialize):
2463             Turns off automatic resource load statistics telemetry submission.
2464
2465 2017-06-29  Commit Queue  <commit-queue@webkit.org>
2466
2467         Unreviewed, rolling out r218512.
2468         https://bugs.webkit.org/show_bug.cgi?id=173981
2469
2470         "It changes the behavior of the JS API's JSEvaluateScript
2471         which breaks TurboTax" (Requested by saamyjoon on #webkit).
2472
2473         Reverted changeset:
2474
2475         "test262: Completion values for control flow do not match the
2476         spec"
2477         https://bugs.webkit.org/show_bug.cgi?id=171265
2478         http://trac.webkit.org/changeset/218512
2479
2480 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
2481
2482         Add WebKitSystemInterface for iOS 11
2483         https://bugs.webkit.org/show_bug.cgi?id=173936
2484
2485         Reviewed by Lucas Forschler.
2486
2487         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
2488
2489 2017-06-28  Keith Miller  <keith_miller@apple.com>
2490
2491         VMTraps has some races
2492         https://bugs.webkit.org/show_bug.cgi?id=173941
2493
2494         Reviewed by Michael Saboff.
2495
2496         Add new testing mode for testing the Watchdog with our stress
2497         tests.
2498
2499         * Scripts/run-jsc-stress-tests:
2500
2501 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2502
2503         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
2504         https://bugs.webkit.org/show_bug.cgi?id=173877
2505
2506         Reviewed by Brady Eidson.
2507
2508         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
2509         the next tests.
2510
2511         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
2512         (testGetFavicon):
2513
2514 2017-06-28  Tim Horton  <timothy_horton@apple.com>
2515
2516         MobileSafari was constantly using 10-15% CPU viewing a PDF
2517         https://bugs.webkit.org/show_bug.cgi?id=173944
2518         <rdar://problem/33039910>
2519
2520         Reviewed by Simon Fraser.
2521
2522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2523         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2524         Add a test that we ever call the stable presentation update callback
2525         when we have a WKPDFView up, instead of infinitely looping.
2526
2527 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2528
2529         Prevent displaying URLs with small capital letters
2530         https://bugs.webkit.org/show_bug.cgi?id=173949
2531         <rdar://problem/32952058>
2532
2533         Reviewed by Brent Fulgham.
2534
2535         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2536         (TestWebKitAPI::TEST):
2537
2538 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2539
2540         Unreviewed test fix.
2541
2542         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
2543
2544         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
2545
2546 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
2547
2548         Teach ResourceLoadStatistics to recognize changes in the file system
2549         https://bugs.webkit.org/show_bug.cgi?id=173800
2550         <rdar://problem/32937842>
2551
2552         Reviewed by Chris Dumez.
2553
2554         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2555         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
2556         (TestWebKitAPI::FileMonitorTest::tempFilePath):
2557         (TestWebKitAPI::handleFileModification):
2558         (TestWebKitAPI::handleFileDeletion):
2559         (TestWebKitAPI::resetTestState):
2560         (TestWebKitAPI::TEST_F):
2561
2562 2017-06-28  Brady Eidson  <beidson@apple.com>
2563
2564         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
2565         https://bugs.webkit.org/show_bug.cgi?id=173874
2566
2567         Reviewed by Alex Christensen.
2568
2569         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2570
2571 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
2572
2573         Unreviewed, adding Don Olmstead to contributors.json
2574
2575         * Scripts/webkitpy/common/config/contributors.json:
2576
2577 2017-06-28  Alex Christensen  <achristensen@webkit.org>
2578
2579         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
2580         https://bugs.webkit.org/show_bug.cgi?id=173886
2581         <rdar://problem/32543191>
2582
2583         Reviewed by Andy Estes.
2584
2585         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2586         (ParsedRange::ParsedRange):
2587         (-[TestSchemeHandler initWithVideoData:]):
2588         (-[TestSchemeHandler webView:startURLSchemeTask:]):
2589         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
2590         (TEST):
2591
2592 2017-06-27  JF Bastien  <jfbastien@apple.com>
2593
2594         WebAssembly: running out of executable memory should throw OoM
2595         https://bugs.webkit.org/show_bug.cgi?id=171537
2596         <rdar://problem/32963338>
2597
2598         Reviewed by Saam Barati.
2599
2600         * Scripts/run-jsc-stress-tests: add a configuration which runs the
2601         tests under limited executable memory and avoids non-WebAssembly
2602         code generation so that we more reliably run out of executable
2603         memory in WebAssembly.
2604
2605 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2606
2607         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
2608         https://bugs.webkit.org/show_bug.cgi?id=173854
2609         <rdar://problem/32236827>
2610
2611         Reviewed by Ryosuke Niwa and Tim Horton.
2612
2613         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
2614
2615         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2616         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
2617         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2618         (TestWebKitAPI::TEST):
2619
2620 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
2621
2622         [PAL] Add symbol export macros for PAL
2623         https://bugs.webkit.org/show_bug.cgi?id=171519
2624
2625         Reviewed by Konstantin Tokarev.
2626
2627         * DumpRenderTree/config.h:
2628         * TestWebKitAPI/CMakeLists.txt:
2629         * TestWebKitAPI/config.h:
2630         * WebKitTestRunner/config.h:
2631
2632 2017-06-27  John Wilander  <wilander@apple.com>
2633
2634         Resource Load Statistics: Add telemetry
2635         https://bugs.webkit.org/show_bug.cgi?id=173499
2636         <rdar://problem/32826094>
2637
2638         Reviewed by Brent Fulgham.
2639
2640         Adds three new testRunner functions:
2641         - installStatisticsDidRunTelemetryCallback()
2642         - statisticsFireTelemetryHandler()
2643         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
2644
2645         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2646         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2647         (WTR::InjectedBundle::didReceiveMessageToPage):
2648         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2649         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
2650         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
2651         (WTR::TestRunner::statisticsFireTelemetryHandler):
2652         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2653         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2654         * WebKitTestRunner/TestController.cpp:
2655         (WTR::TestController::resetStateToConsistentValues):
2656         (WTR::TestController::statisticsFireTelemetryHandler):
2657         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2658         * WebKitTestRunner/TestController.h:
2659         * WebKitTestRunner/TestInvocation.cpp:
2660         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2661
2662 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
2663
2664         Add missing includes to fix compilation error on FreeBSD
2665         https://bugs.webkit.org/show_bug.cgi?id=172919
2666
2667         Reviewed by Mark Lam.
2668
2669         * ImageDiff/cairo/PlatformImageCairo.cpp:
2670
2671 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
2672
2673         Unreviewed, rolling out r218783.
2674
2675         Causing accessibility/mac/setting-attributes-is-
2676         asynchronous.html to crash consistently on mac-wk2 Debug
2677
2678         Reverted changeset:
2679
2680         "AX: Cannot call setValue() on contenteditable or ARIA text
2681         controls"
2682         https://bugs.webkit.org/show_bug.cgi?id=173520
2683         http://trac.webkit.org/changeset/218783
2684
2685 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
2686
2687         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
2688         https://bugs.webkit.org/show_bug.cgi?id=173825
2689
2690         Reviewed by Saam Barati.
2691
2692         * DumpRenderTree/JavaScriptThreading.cpp:
2693         (runJavaScriptThread):
2694         (startJavaScriptThreads):
2695         * DumpRenderTree/mac/DumpRenderTree.mm:
2696         (runThread):
2697         (runPthread):
2698         (testThreadIdentifierMap):
2699
2700 2017-06-26  David Kilzer  <ddkilzer@apple.com>
2701
2702         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
2703         <https://webkit.org/b/173837>
2704
2705         Reviewed by Geoffrey Garen.
2706
2707         The clang static analyzer can't reason about objects that are
2708         assigned to a delegate as +1 retained, and then released
2709         later in a different method when the delegate is cleared.
2710
2711         Instead, use a common idiom where the object setting the
2712         delegate retains it as an instance variable on initialization.
2713         Then the same object clears the delegate and releases its
2714         instance variable during teardown.
2715
2716         Also add EXPECT_TRUE() tests to make sure the delegate objects
2717         match before teardown.
2718
2719         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2720         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2721         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
2722         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2723         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
2724         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
2725
2726 2017-06-26  David Kilzer  <ddkilzer@apple.com>
2727
2728         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
2729         <https://webkit.org/b/173836>
2730
2731         Reviewed by Brady Eidson.
2732
2733         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2734         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
2735         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
2736         objects in this test.
2737
2738 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
2739
2740         [ATK] Add support for aria-details and aria-errormessage
2741         https://bugs.webkit.org/show_bug.cgi?id=172588
2742
2743         Reviewed by Chris Fleizach.
2744
2745         Add additional methods to test ARIA properties which are exposed via
2746         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
2747         to versions which support the details and error-message relation types.
2748
2749         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2750         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
2751         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
2752         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
2753         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
2754         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2755         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2756         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
2757         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
2758         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
2759         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
2760         * gtk/jhbuild.modules:
2761
2762 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2763
2764         Unreviewed. Add libfii to GTK+ install dependencies script.
2765
2766         * gtk/install-dependencies:
2767
2768 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2769
2770         Unreviewed, rolling out r215190.
2771
2772         Broke product select element on GNOME Bugzilla
2773
2774         Reverted changeset:
2775
2776         "[GTK] Misplaced right click menu on web page due to
2777         deprecated gtk_menu_popup()"
2778         https://bugs.webkit.org/show_bug.cgi?id=170553
2779         http://trac.webkit.org/changeset/215190
2780
2781 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
2782
2783         Remove Reflect.enumerate
2784         https://bugs.webkit.org/show_bug.cgi?id=173806
2785
2786         Reviewed by Yusuke Suzuki.
2787
2788         * Scripts/run-jsc-stress-tests:
2789
2790 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
2791
2792         AX: Cannot call setValue() on contenteditable or ARIA text controls
2793         https://bugs.webkit.org/show_bug.cgi?id=173520
2794
2795         Reviewed by Ryosuke Niwa.
2796
2797         Add setValue() method to WKTR (already existed in DRT).
2798
2799         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2800         (WTR::AccessibilityUIElement::setValue):
2801         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2802         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2803         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2804         (WTR::AccessibilityUIElement::setValue):
2805
2806 2017-06-23  Keith Miller  <keith_miller@apple.com>
2807
2808         Switch VMTraps to use halt instructions rather than breakpoint instructions
2809         https://bugs.webkit.org/show_bug.cgi?id=173677
2810
2811         Reviewed by JF Bastien.
2812
2813         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2814         (TEST):
2815
2816 2017-06-23  Youenn Fablet  <youenn@apple.com>
2817
2818         Set getUserMedia permission to true by default on WTR
2819         https://bugs.webkit.org/show_bug.cgi?id=173610
2820
2821         Reviewed by Alex Christensen.
2822
2823         Adding a way to reset the getUserMedia permission to pending.
2824
2825         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2826         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2827         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
2828         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2829         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2830         (WTR::TestRunner::setUserMediaPermissionAsUnset):
2831         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2832         * WebKitTestRunner/TestController.cpp:
2833         (WTR::TestController::resetStateToConsistentValues):
2834         (WTR::TestController::setUserMediaPermissionAsUnset):
2835         * WebKitTestRunner/TestController.h:
2836         * WebKitTestRunner/TestInvocation.cpp:
2837         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2838
2839 2017-06-23  Alex Christensen  <achristensen@webkit.org>
2840
2841         Add SPI to WKURLSchemeTask for redirection
2842         https://bugs.webkit.org/show_bug.cgi?id=173730
2843
2844         Reviewed by Brady Eidson.
2845
2846         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2847         (-[SchemeHandler webView:startURLSchemeTask:]):
2848         (-[SchemeHandler webView:stopURLSchemeTask:]):
2849         (TEST):
2850         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
2851         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
2852         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
2853         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
2854         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
2855
2856 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2857
2858         [WPE] Use JSC API to send script messages from web extension in tests
2859         https://bugs.webkit.org/show_bug.cgi?id=173757
2860
2861         Reviewed by Žan Doberšek.
2862
2863         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
2864         to run postMessage().
2865
2866         Fixes: /wpe/WebKitSecurityManager/file-xhr
2867                /wpe/WebKitConsoleMessage/console-api
2868                /wpe/WebKitConsoleMessage/js-exception
2869                /wpe/WebKitConsoleMessage/network-error
2870                /wpe/WebKitConsoleMessage/security-error
2871
2872         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
2873         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
2874         (beforeAll): Ditto.
2875         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
2876         (testWebContextSecurityFileXHR): Ditto.
2877         (beforeAll): Ditto.
2878         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2879         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
2880         (pageCreatedCallback): Remove ifdefs.
2881
2882 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2883
2884         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
2885
2886         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
2887         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
2888         doesn't exist yet in WPE.
2889
2890         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2891         (testWebViewJavaScriptDialogs):
2892         (testWebViewWindowProperties):
2893
2894 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2895
2896         [GTK] Upgrade pixman and cairo in jhbuild
2897         https://bugs.webkit.org/show_bug.cgi?id=173710
2898
2899         Reviewed by Carlos Alberto Lopez Perez.
2900
2901         * gtk/jhbuild.modules:
2902
2903 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2904
2905         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
2906         https://bugs.webkit.org/show_bug.cgi?id=173711
2907
2908         Reviewed by Carlos Alberto Lopez Perez.
2909
2910         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
2911         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
2912
2913         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2914         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
2915
2916 2017-06-22  David Kilzer  <ddkilzer@apple.com>
2917
2918         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
2919         <https://webkit.org/b/173721>
2920
2921         Reviewed by Joseph Pecoraro.
2922
2923         Use RetainPtr<> to create NSMutableDictionary and NSNumber
2924         objects to fix leaks and to avoid the autoreleasepool.
2925
2926         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
2927         (TEST):
2928
2929 2017-06-22  Matt Lewis  <jlewis3@apple.com>
2930
2931         Unreviewed, rolling out r218633.
2932
2933         The test is failing frequently on Sierra Debug and Windows
2934
2935         Reverted changeset:
2936
2937         "AX: Cannot call setValue() on contenteditable or ARIA text
2938         controls"
2939         https://bugs.webkit.org/show_bug.cgi?id=173520
2940         http://trac.webkit.org/changeset/218633
2941
2942 2017-06-22  David Kilzer  <ddkilzer@apple.com>
2943
2944         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
2945         <https://webkit.org/b/173690>
2946
2947         Reviewed by Chris Dumez.
2948
2949         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
2950         ownership of malloc()-ed memory, then frees it when it's
2951         released.  These tests were passing global variables into the
2952         method, which is not malloc()-ed memory, which violates the API
2953         contract.
2954
2955         The fix is to switch to use
2956         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
2957         NO for the last argument.
2958
2959         Caught by the clang static analyzer.
2960
2961         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
2962         (TEST):
2963         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2964         (TEST):
2965
2966 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2967
2968         [GTK] Upgrade Harfbuzz to version 1.4.2
2969         https://bugs.webkit.org/show_bug.cgi?id=173592
2970
2971         Reviewed by Carlos Alberto Lopez Perez.
2972
2973         * gtk/jhbuild.modules:
2974
2975 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2976
2977         [WPE] Update WPEBackend-mesa
2978         https://bugs.webkit.org/show_bug.cgi?id=173705
2979
2980         Reviewed by Carlos Alberto Lopez Perez.
2981
2982         A crash has been fixed, needed for unit tests to work.
2983
2984         * wpe/jhbuild.modules:
2985
2986 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2987
2988         Remove unused coordinated graphics C API
2989         https://bugs.webkit.org/show_bug.cgi?id=173706
2990
2991         Reviewed by Žan Doberšek.
2992
2993         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
2994         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
2995         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
2996         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
2997         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
2998         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
2999
3000 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3001
3002         [WPE] Build glib API tests
3003         https://bugs.webkit.org/show_bug.cgi?id=173702
3004
3005         Reviewed by Žan Doberšek.
3006
3007         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
3008         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
3009         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
3010         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
3011         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
3012         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
3013         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
3014         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
3015         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
3016         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
3017         and implement the missing features.
3018
3019         * CMakeLists.txt:
3020         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
3021         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3022         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3023         (testAutomationSessionRequestSession):
3024         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3025         (testWebKitWebViewSessionState):
3026         (testWebKitWebViewSessionStateWithFormData):
3027         (testWebKitWebViewNavigationAfterSessionRestore):
3028         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3029         (beforeAll):
3030         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3031         (testCookieManagerEphemeral):
3032         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3033         (testBlobDownload):
3034         (beforeAll):
3035         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3036         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3037         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3038         (testProcessPerWebView):
3039         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3040         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3041         (testWebViewCreateNavigationData):
3042         (testWebViewJavaScriptDialogs):
3043         (testWebViewWindowProperties):
3044         (testWebViewMouseTarget):
3045         (testWebViewGeolocationPermissionRequests):
3046         (testWebViewUserMediaPermissionRequests):
3047         (testWebViewAudioOnlyUserMediaPermissionRequests):
3048         (testWebViewFileChooserRequest):
3049         (beforeAll):
3050         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3051         (beforeAll):
3052         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3053         (testPrivateBrowsing):
3054         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3055         (testFindControllerHide):
3056         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3057         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3058         (testWebKitSettings):
3059         (beforeAll):
3060         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3061         (testWebViewNewWithUserContentManager):
3062         (beforeAll):
3063         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3064         (testWebContextEphemeral):
3065         (testWebContextProxySettings):
3066         (beforeAll):
3067         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3068         (testWebViewWebContext):
3069         (testWebViewWebContextLifetime):
3070         (testWebViewEphemeral):
3071         (testWebViewSettings):
3072         (testWebViewCanShowMIMEType):
3073         (testWebViewPageVisibility):
3074         (testWebViewIsPlayingAudio):
3075         (beforeAll):
3076         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3077         (testWebsiteDataEphemeral):
3078         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3079         (documentLoadedCallback):
3080         (pageCreatedCallback):
3081         (methodCallCallback):
3082         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
3083         * TestWebKitAPI/glib/CMakeLists.txt:
3084         * TestWebKitAPI/glib/PlatformGTK.cmake:
3085         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3086         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3087         (main):
3088         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3089         (Test::adoptView):
3090         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3091         (WebKitTestBus::run):
3092         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3093         (WebViewTest::~WebViewTest):
3094         (WebViewTest::initializeWebView):
3095         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3096         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
3097         (WebViewTest::platformDestroy):
3098         (WebViewTest::platformInitializeWebView):
3099         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3100         (WebViewTest::resizeView):
3101         (WebViewTest::hideView):
3102         (parentWindowMapped):
3103         (WebViewTest::showInWindow):
3104         (WebViewTest::showInWindowAndWaitUntilMapped):
3105         (WebViewTest::mouseMoveTo):
3106         (WebViewTest::clickMouseButton):
3107         (WebViewTest::emitPopupMenuSignal):
3108         (WebViewTest::keyStroke):
3109         (WebViewTest::doMouseButtonEvent):
3110         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
3111         (WebViewTest::platformDestroy):
3112         (WebViewTest::platformInitializeWebView):
3113         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
3114         (WebViewTest::resizeView):
3115         (WebViewTest::hideView):
3116         (WebViewTest::mouseMoveTo):
3117         (WebViewTest::clickMouseButton):
3118         (WebViewTest::keyStroke):
3119
3120 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3121
3122         [GTK] Move WebKit2 GLib API tests to glib directories
3123         https://bugs.webkit.org/show_bug.cgi?id=173642
3124
3125         Reviewed by Žan Doberšek.
3126
3127         * CMakeLists.txt:
3128         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
3129         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
3130         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
3131         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
3132         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
3133         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
3134         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
3135         (testWebKitConsoleMessageNetworkError):
3136         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
3137         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
3138         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
3139         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
3140         (testLoadFromGResource):
3141         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
3142         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
3143         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
3144         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
3145         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
3146         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
3147         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
3148         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
3149         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
3150         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
3151         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
3152         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
3153         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
3154         (testWebViewRunJavaScript):
3155         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
3156         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
3157         (registerGResource):
3158         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
3159         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
3160         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
3161         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
3162         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
3163         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
3164         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
3165         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
3166         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
3167         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
3168         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
3169         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
3170         * TestWebKitAPI/glib/CMakeLists.txt: Added.
3171         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
3172         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
3173         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
3174         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
3175         (registerGResource):
3176         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
3177         (Test::getResourcesDir):
3178         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
3179         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
3180         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
3181         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
3182         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
3183         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
3184
3185 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3186
3187         [WPE] Add initial web extensions API
3188         https://bugs.webkit.org/show_bug.cgi?id=173640
3189
3190         Reviewed by Žan Doberšek.
3191
3192         Add style checker exceptions for WPE web extensions API files.
3193
3194         * Scripts/webkitpy/style/checker.py:
3195
3196 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3197
3198         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
3199         https://bugs.webkit.org/show_bug.cgi?id=173659
3200         <rdar://problem/32879788>
3201
3202         Reviewed by Tim Horton.
3203
3204         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
3205
3206         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
3207
3208         Augment this test page to log dragend and dragstart events on the drag source as well.
3209
3210         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3211         (checkStringArraysAreEqual):
3212         (TestWebKitAPI::TEST):
3213
3214 2017-06-21  Antoine Quint  <graouts@apple.com>
3215
3216         Ensure DRT always logs rAF suspension debugging code
3217         https://bugs.webkit.org/show_bug.cgi?id=173681
3218
3219         Reviewed by Tim "Mr. T" Horton.
3220
3221         * DumpRenderTree/mac/DumpRenderTree.mm:
3222         (resetWebPreferencesToConsistentValues):
3223
3224 2017-06-21  Chris Dumez  <cdumez@apple.com>
3225
3226         Allow constructing a WTF:Function from a function pointer
3227         https://bugs.webkit.org/show_bug.cgi?id=173660
3228
3229         Reviewed by Alex Christensen.
3230
3231         Add API test coverage.
3232
3233         * TestWebKitAPI/Tests/WTF/Function.cpp:
3234         (TestWebKitAPI::returnThree):
3235         (TestWebKitAPI::returnFour):
3236         (TestWebKitAPI::returnPassedValue):
3237         (TestWebKitAPI::TEST):
3238
3239 2017-06-21  Antoine Quint  <graouts@apple.com>
3240
3241         Add logging to identify when the Page suspends scripted animations
3242         https://bugs.webkit.org/show_bug.cgi?id=173626
3243
3244         Reviewed by Tim Horton.
3245
3246         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
3247
3248         * DumpRenderTree/mac/DumpRenderTree.mm:
3249         (resetWebPreferencesToConsistentValues):
3250
3251 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
3252
3253         AX: Cannot call setValue() on contenteditable or ARIA text controls
3254         https://bugs.webkit.org/show_bug.cgi?id=173520
3255
3256         Reviewed by Ryosuke Niwa.
3257
3258         Add setValue() method to WKTR (already existed in DRT).
3259
3260         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3261         (WTR::AccessibilityUIElement::setValue):
3262         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3263         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3264         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3265         (WTR::AccessibilityUIElement::setValue):
3266
3267 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
3268
3269         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
3270         as one of the dependencies required to build the product.
3271
3272         Rubber-stamped by Carlos Garcia Campos.
3273
3274         * gtk/install-dependencies:
3275         * wpe/install-dependencies:
3276
3277 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
3278
3279         Disable font variations on macOS Sierra and iOS 10
3280         https://bugs.webkit.org/show_bug.cgi?id=173618
3281         <rdar://problem/32879164>
3282
3283         Reviewed by Jon Lee.
3284
3285         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3286
3287 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3288
3289         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
3290         https://bugs.webkit.org/show_bug.cgi?id=173578
3291         <rdar://problem/32825028>
3292
3293         Reviewed by Tim Horton.
3294
3295         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
3296         a custom popover does not cause dragging to fail when the popover is presented.
3297
3298         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3299         (-[DataInteractionSimulator _advanceProgress]):
3300
3301 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3302
3303         [WPE] Add initial implementation of glib API
3304         https://bugs.webkit.org/show_bug.cgi?id=173546
3305
3306         Reviewed by Žan Doberšek.
3307
3308         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
3309         include WPE glib API files.
3310
3311         * Scripts/webkitperl/FeatureList.pm:
3312         * Scripts/webkitpy/style/checker.py:
3313         * Scripts/webkitpy/style/checkers/cpp.py:
3314         (check_identifier_name_in_declaration):
3315
3316 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3317
3318         [GTK] Upgrade to ICU to version 57.1
3319         https://bugs.webkit.org/show_bug.cgi?id=173538
3320
3321         Reviewed by Žan Doberšek.
3322
3323         * gtk/jhbuild.modules:
3324
3325 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3326
3327         [GTK] Remove unneeded modules from the jhbuild
3328         https://bugs.webkit.org/show_bug.cgi?id=170540
3329
3330         Reviewed by Michael Catanzaro.
3331
3332         We are building libxslt and libffi that we don't really need to build from sources.
3333
3334         * gtk/jhbuild.modules:
3335
3336 2017-06-19  Frederic Wang  <fwang@igalia.com>
3337
3338         [Mac] Add an experimental feature setting for async frame scrolling
3339         https://bugs.webkit.org/show_bug.cgi?id=173359
3340
3341         Reviewed by Simon Fraser.
3342
3343         * DumpRenderTree/mac/DumpRenderTree.mm:
3344         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
3345         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
3346         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3347         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
3348
3349 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
3350
3351         Unreviewed, adding myself to contributors.json
3352
3353         * Scripts/webkitpy/common/config/contributors.json:
3354
3355 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
3356
3357         test262: Completion values for control flow do not match the spec
3358         https://bugs.webkit.org/show_bug.cgi?id=171265
3359
3360         Reviewed by Saam Barati.
3361
3362         * Scripts/run-jsc-stress-tests:
3363         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
3364
3365 2017-06-19  Zalan Bujtas  <zalan@apple.com>
3366
3367         Opening certain mails brings up a mail that grows indefinitely.
3368         https://bugs.webkit.org/show_bug.cgi?id=173562
3369         <rdar://problem/32766579>
3370
3371         Reviewed by Tim Horton.
3372
3373         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3374         (TEST):
3375
3376 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3377
3378         [iOS DnD] Support .zip archives for file uploads via drag and drop
3379         https://bugs.webkit.org/show_bug.cgi?id=173511
3380         <rdar://problem/32521025>
3381
3382         Reviewed by Tim Horton.
3383
3384         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
3385         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
3386
3387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3388         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
3389         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3390         (testZIPArchive):
3391         (TestWebKitAPI::TEST):
3392
3393 2017-06-18  Darin Adler  <darin@apple.com>
3394
3395         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
3396         https://bugs.webkit.org/show_bug.cgi?id=173526
3397
3398         Reviewed by Sam Weinig.
3399
3400         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
3401         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
3402
3403         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
3404         tests for assignment before destruction ones.
3405
3406         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
3407         as a function, so it can be used in WTF::Function tests.
3408
3409         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
3410         Added tests for swap and for assignment before deref.
3411
3412         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
3413         to inline everything. Also removed the unnecessary clearing of the log every time
3414         the DerivedRefLogger constructor is called.
3415         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
3416
3417         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
3418         Added tests for assignment before deref and similar for releaseNonNull.
3419
3420 2017-06-19  Sam Weinig  <sam@webkit.org>
3421
3422         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
3423         https://bugs.webkit.org/show_bug.cgi?id=173513
3424
3425         Reviewed by Alex Christensen.
3426
3427         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3428         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3429         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
3430
3431 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
3432
3433         [Win] fast/dom/assign-to-window-status.html is flaky.
3434         https://bugs.webkit.org/show_bug.cgi?id=173512
3435
3436         Reviewed by Alex Christensen.
3437
3438         We should not dump status callbacks when test is done.
3439
3440         * DumpRenderTree/win/UIDelegate.cpp:
3441         (UIDelegate::setStatusText):
3442
3443 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3444
3445         [WPE][JHBuild] Update WPEBackend-mesa
3446         https://bugs.webkit.org/show_bug.cgi?id=173433
3447
3448         Unreviewed.
3449
3450         Update WPEBackend-mesa back (like it was done originally in r218344)
3451         after fixing the issue with the DISPLAY environment variables that
3452         caused the crashes.
3453
3454         * wpe/jhbuild.modules:
3455
3456 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3457
3458         Rename unit test file after r218482
3459         https://bugs.webkit.org/show_bug.cgi?id=173483
3460
3461         Unreviewed.
3462
3463         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
3464
3465 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3466
3467         Unreviewed. Fix wrong style checker condition added in r218487.
3468
3469         * Scripts/webkitpy/style/checkers/cpp.py:
3470         (check_identifier_name_in_declaration):
3471
3472 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
3473
3474         Missing <functional> includes make builds fail with GCC 7.x
3475         https://bugs.webkit.org/show_bug.cgi?id=173544
3476
3477         Unreviewed gardening.
3478
3479         Fix compilation with GCC 7.
3480
3481         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3482         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3483
3484 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3485
3486         [GTK] Move GTK+ API files that could be shared to glib dirs
3487         https://bugs.webkit.org/show_bug.cgi?id=173545
3488
3489         Reviewed by Žan Doberšek.
3490
3491         Update paths of GTK+ API in watchlist and style checker.
3492
3493         * Scripts/webkitpy/common/config/watchlist:
3494         * Scripts/webkitpy/style/checker.py:
3495         * Scripts/webkitpy/style/checkers/cpp.py:
3496         (check_identifier_name_in_declaration):
3497
3498 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3499
3500         Port setup_environ_for_server should not set environment variables related with the driver.
3501         https://bugs.webkit.org/show_bug.cgi?id=173483
3502
3503         Reviewed by Carlos Garcia Campos.
3504
3505         The port setup_environ_for_server() should not set environment variables
3506         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
3507         This varibles should be only set on the driver setup_environ_for_test().
3508
3509         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
3510         into the test environment even when running the tests with a driver
3511         that is not the Xorg or Xvfb one.
3512
3513         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
3514         (Port.to.setup_environ_for_server):
3515         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
3516         (Driver._setup_environ_for_driver):
3517         * Scripts/webkitpy/port/driver_unittest.py:
3518         (DriverTest.test_setup_environ_for_test):
3519         (DriverTest):
3520         (DriverTest.test_setup_environ_base_vars):
3521         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
3522         (GtkPort.setup_environ_for_server):
3523         * Scripts/webkitpy/port/wayland_unittest.py: Added.
3524         (WaylandDriverTest):
3525         (WaylandDriverTest.make_driver):
3526         (WaylandDriverTest.make_environment):
3527         (WaylandDriverTest.test_checkdriver):
3528         (WaylandDriverTest.test_environment_needed_variables):
3529         (WaylandDriverTest.test_environment_forbidden_variables):
3530         (WaylandDriverTest.test_environment_optional_variables):
3531         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
3532         (WaylandDriver.check_driver):
3533         (WaylandDriver._setup_environ_for_test):
3534         * Scripts/webkitpy/port/xorgdriver.py:
3535         (XorgDriver.check_driver):
3536         (XorgDriver._setup_environ_for_test):
3537         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
3538         (XorgDriverTest):
3539         (XorgDriverTest.make_driver):
3540         (XorgDriverTest.make_environment):
3541         (XorgDriverTest.test_checkdriver):
3542         (XorgDriverTest.test_environment_needed_variables):
3543         (XorgDriverTest.test_environment_forbidden_variables):
3544         (XorgDriverTest.test_environment_optional_variables):
3545         * Scripts/webkitpy/port/xvfbdriver.py:
3546         (XvfbDriver._setup_environ_for_test):
3547         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3548         (XvfbDriverTest.assertDriverStartSuccessful):
3549
3550
3551 2017-05-14 Frederic Wang  <fwang@igalia.com>
3552
3553         Add heuristic to avoid flattening "fullscreen" iframes
3554         https://bugs.webkit.org/show_bug.cgi?id=171914
3555
3556         Reviewed by Simon Fraser.
3557
3558         * DumpRenderTree/mac/DumpRenderTree.mm:
3559         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
3560
3561 2017-06-18  Chris Dumez  <cdumez@apple.com>
3562
3563         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
3564         https://bugs.webkit.org/show_bug.cgi?id=173522
3565         <rdar://problem/31185739>
3566
3567         Reviewed by Darin Adler.
3568
3569         Add API test for re-entering Function's assignment operators.
3570
3571         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3572         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
3573         (TestWebKitAPI::TestObject::TestObject):
3574         (TestWebKitAPI::TestObject::~TestObject):
3575         (TestWebKitAPI::TestObject::operator()):
3576         (TestWebKitAPI::TEST):
3577
3578 2017-06-16  Dan Bernstein  <mitz@apple.com>
3579
3580         [Cocoa] Some declarations have missing or incorrect availability attributes
3581         https://bugs.webkit.org/show_bug.cgi?id=173508
3582
3583         Reviewed by Tim Horton.
3584
3585         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
3586         (TestWebKitAPI::TEST): Updated for renames.
3587
3588 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3589
3590         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
3591         https://bugs.webkit.org/show_bug.cgi?id=173366
3592         <rdar://problem/32767014>
3593
3594         Reviewed by Tim Horton.
3595
3596         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
3597         change in behavior.
3598
3599         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3600         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3601         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
3602         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
3603         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
3604         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
3605         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
3606         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
3607         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
3608         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
3609         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
3610         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
3611         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
3612         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
3613         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3614         (-[MockDragDropSession initWithItems:location:window:]