8e214f5fd16b5a00ee04b7a632cb9378b30f886c
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-24  Mario Sanchez Prada  <msanchez@igalia.com>
2
3         Unreviewed, skip WK2 API test timing out on some GTK bots.
4
5         WebKit2APITests/TestDownloads is consistently timing out on the
6         32bit release and 64bit debug bots.
7
8         * Scripts/run-gtk-tests:
9         (TestRunner): Skip WebKit2APITests/TestDownloads.
10
11 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
12
13         [Qt] Fix the build with the newes Qt5 hashes
14         https://bugs.webkit.org/show_bug.cgi?id=76657
15
16         Reviewed by Simon Hausmann.
17
18         * MiniBrowser/qt/MiniBrowserApplication.cpp:
19         (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
20         for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
21
22 2012-01-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
23
24         [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
25
26         We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
27         building with MinGW inside cmd.exe will require the same construct. Instead
28         we assume that when the first character in PWD is a '/' we're running under
29         Cygwin, and use the normal unix way of setting environment variables.
30
31         Reviewed by Simon Hausmann.
32
33         * qmake/mkspecs/features/default_pre.prf:
34
35 2012-01-24  Simon Hausmann  <simon.hausmann@nokia.com>
36
37         Some qmake build files must include Qt5's "quick" module.
38         https://bugs.webkit.org/show_bug.cgi?id=76671
39
40         Unreviewed build fix.
41
42         * MiniBrowser/qt/MiniBrowser.pro:
43         * WebKitTestRunner/Target.pri:
44
45 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
46
47         [Qt] Fix the event timestamps for touch mocking
48
49         Reviewed by Simon Hausmann.
50
51         * MiniBrowser/qt/MiniBrowserApplication.cpp:
52         (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
53         timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
54
55 2012-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
56
57         [GTK] Implement DownloadClient in WebKit2 GTK+ API
58         https://bugs.webkit.org/show_bug.cgi?id=72952
59
60         Reviewed by Martin Robinson.
61
62         * gtk/generate-gtkdoc:
63         (get_webkit2_options): Ignore WebKitDownloadClient.
64
65 2012-01-23  Zan Dobersek  <zandobersek@gmail.com>
66
67         [GTK] editing/deleting/5408255.html results are incorrect
68         https://bugs.webkit.org/show_bug.cgi?id=53644
69
70         Reviewed by Martin Robinson.
71
72         WEBKIT_TOP_LEVEL environment variable is now set directly in either
73         WebKitTestRunner or DumpRenderTree through usage of a compilation-time
74         macro. This way both tools can be run outside the test harness without
75         the need to manually set the environment variable.
76
77         * DumpRenderTree/gtk/DumpRenderTree.cpp:
78         (getTopLevelPath):
79         * GNUmakefile.am:
80         * Scripts/webkitpy/layout_tests/port/gtk.py:
81         (GtkPort.setup_environ_for_server):
82         * WebKitTestRunner/GNUmakefile.am:
83         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
84         (WTR::InjectedBundle::platformInitialize):
85
86 2012-01-23  Dmitry Lomov  <dslomov@google.com>
87
88         [Chromium] Implement layoutTestController.workerThreadCount in DRT
89         https://bugs.webkit.org/show_bug.cgi?id=74653.
90
91         Reviewed by Darin Fisher.
92
93         * DumpRenderTree/chromium/LayoutTestController.cpp:
94         (LayoutTestController::LayoutTestController):
95         (LayoutTestController::workerThreadCount):
96         * DumpRenderTree/chromium/LayoutTestController.h:
97
98 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
99
100         nrwt: make --chromium work like --qt
101         https://bugs.webkit.org/show_bug.cgi?id=76875
102
103         Reviewed by Adam Barth.
104
105         --chromium used to have to be handled differently from --qt
106         due to the way the PortFactory was implemented; there's not
107         really a good reason for that any more so this patch makes
108         things slightly more consistent and eliminates the
109         options.chromium flag (--chromium is now truly a synonym for
110         --platform chromium).
111
112         * Scripts/webkitpy/layout_tests/port/factory.py:
113         (PortFactory._default_port):
114         (PortFactory.get):
115         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
116         (FactoryTest.setUp):
117         (FactoryTest.test_chromium_mac):
118         (FactoryTest.test_chromium_linux):
119         (FactoryTest.test_chromium_win):
120         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
121         (parse_args):
122
123 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
124
125         run-webkit-tests needs to propagate --chromium
126         https://bugs.webkit.org/show_bug.cgi?id=76870
127
128         Reviewed by Eric Seidel.
129
130         run-webkit-tests removes '--chromium' argument from @ARGV when
131         determining which port to run, which means that that doesn't
132         propagate to new-run-webkit-tests. That's bad (and is handled
133         for the other ports by re-adding the flag, but apparently we're
134         just now noticing for Chromium).
135
136         * Scripts/run-webkit-tests:
137
138 2012-01-23  Brian Weinstein  <bweinstein@apple.com>
139
140         More build fixing after r105646.
141
142         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
143         (TestWebKitAPI::TestNode::key):
144
145 2012-01-23  Gavin Barraclough  <barraclough@apple.com>
146
147         Unreviewed build fix - r105646 broke this.
148
149         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
150         (TestWebKitAPI::TestNode::TestNode):
151         (TestWebKitAPI::TestNode::key):
152         (TestWebKitAPI::RedBlackTreeTest::assertEqual):
153         (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
154         (TestWebKitAPI::RedBlackTreeTest::testDriver):
155
156 2012-01-23  Sheriff Bot  <webkit.review.bot@gmail.com>
157
158         Unreviewed, rolling out r105658.
159         http://trac.webkit.org/changeset/105658
160         https://bugs.webkit.org/show_bug.cgi?id=76883
161
162         We want this eventually, but not right at this moment
163         (Requested by abarth on #webkit).
164
165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
166
167 2012-01-23  Adam Barth  <abarth@webkit.org>
168
169         garden-o-matic should support Chromium Mac Lion
170         https://bugs.webkit.org/show_bug.cgi?id=76880
171
172         Reviewed by Eric Seidel.
173
174         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
175
176 2012-01-23  Emil A Eklund  <eae@chromium.org>
177
178         check-webkit-style whitespace/operators triggers on overloaded division operator
179         https://bugs.webkit.org/show_bug.cgi?id=76650
180
181         Reviewed by Darin Adler.
182
183         * Scripts/webkitpy/style/checkers/cpp.py:
184         (check_spacing):
185         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
186         (CppStyleTest.test_operator_methods):
187
188 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
189
190         run-perf-tests should report server-side errors
191         https://bugs.webkit.org/show_bug.cgi?id=76802
192
193         Reviewed by Tony Chang.
194
195         Report errors whenever server's response doesn't match "OK".
196
197         * Scripts/webkitpy/common/net/file_uploader.py:
198         (FileUploader.upload_single_text_file):
199         (FileUploader.upload_as_multipart_form_data):
200         (FileUploader._upload_data.callback):
201         (FileUploader):
202         (FileUploader._upload_data):
203         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
204         (PerfTestsRunner._upload_json):
205         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
206         (test_upload_json):
207         (test_upload_json.MockFileUploader.upload_single_text_file):
208
209 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
210
211         run-perf-tests ignore Skipped list on chromium
212         https://bugs.webkit.org/show_bug.cgi?id=76764
213
214         Reviewed by Dirk Pranke.
215
216         Move skipped_perf_tests from WebKit port to Base port so that Chromium port
217         can also find skipped list. Chromium port only uses test_expectations.txt for
218         layout tests but performacne tests don't use test_expectations.txt so Chromium port
219         also needs to use Skipped list.
220
221         * Scripts/webkitpy/layout_tests/port/base.py:
222         (Port._tests_from_skipped_file_contents):
223         (Port):
224         (Port._expectations_from_skipped_files):
225         (Port.skipped_perf_tests):
226         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
227         (PortTest.test_skipped_perf_tests):
228         (PortTest.test_skipped_perf_tests.add_text_file):
229         * Scripts/webkitpy/layout_tests/port/webkit.py:
230         (WebKitPort._skipped_tests_for_unsupported_features):
231         (WebKitPort._skipped_file_search_paths):
232         (WebKitPort.skipped_layout_tests):
233
234 2012-01-23  Andy Estes  <aestes@apple.com>
235
236         Fix the build after r105635.
237
238         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
239         (TestWebKitAPI::TEST):
240
241 2012-01-23  Xianzhu Wang  <wangxianzhu@chromium.org>
242
243         Basic enhancements to StringBuilder
244         https://bugs.webkit.org/show_bug.cgi?id=67081
245
246         Reviewed by Darin Adler.
247
248         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
249         (TestWebKitAPI::TEST):
250
251 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
252
253         [GTK] run-gtk-tests randomly fails while running the xprop comand
254         https://bugs.webkit.org/show_bug.cgi?id=76817
255
256         Reviewed by Gustavo Noronha Silva.
257
258         No need to use xprop to remove the AT_SPI_BUS property since
259         run-gtk-tests will always run new instances of Xvfb.
260
261         * Scripts/run-gtk-tests:
262         (TestRunner): Unskip TestWebKitAccessibility.
263         (TestRunner.run): Uncomment lines for launching the accessibility
264         bus and registry daemon, and remove lines for running xprop.
265
266 2012-01-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
267
268         [Qt] Don't warn about override and final being C++11 extensions
269
270         Clang will emit a warning when these extensions are used without passing
271         --std=c++11, but we use feature checking to decide if we have the right
272         extensions, so we can safely ignore these warnings. The XCode and Windows
273         project files have the same workaround.
274
275         The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
276         we only have one extra compiler for Objective-C, which is also used for
277         Objective-C++ sources, so we have to pass the flag, even if it doesn't
278         make sense for Objective-C.
279
280         Reviewed by Simon Hausmann.
281
282         * qmake/mkspecs/features/unix/default_post.prf:
283
284 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
285
286         [Qt] Change how build-webkit decides when to do full incremental builds
287
288         Instead of relying on update-webkit (which isn't run on the bots) to
289         decide when to do a full incremental build (make qmake), we let the
290         build-webkit script itself check the current SVN revision against the
291         previous build (by storing it in .webkit.config).
292
293         If the two differ we assume a full incremental build is needed, since
294         the new revisions might have introduced problematic things like new
295         Q_OBJECT macros. If not, we assume the developer is doing changes
296         locally, and revert to doing a plain 'make'.
297
298         In addition, when the build fails in the latter case, we inform the
299         developer of possible pitfalls and how to manually run 'make qmake'.
300
301         Reviewed by Ossy.
302
303         * Scripts/update-webkit:
304         * Scripts/webkitdirs.pm:
305         (buildQMakeProjects):
306
307 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
308
309         [GTK] run-gtk-tests randomly fails while running the xprop comand
310         https://bugs.webkit.org/show_bug.cgi?id=76817
311
312         Reviewed by Philippe Normand.
313
314         Temporarily comment the lines related to launching the ATSPI bus
315         and registry daemon, which are making the bots to fail randomly.
316
317         * Scripts/run-gtk-tests:
318         (TestRunner): Skip TestWebKitAccessibility, as it won't run
319         properly if the ATSPI infrastructure is not properly initialized.
320         (TestRunner.run): Comment lines related to initialization of ATSPI.
321
322 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
323
324         Windows python test build fix.
325
326         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
327         (PerfTestsRunner.__init__):
328
329 2012-01-22  Sergio Villar Senin  <svillar@igalia.com>
330
331         [GTK] DumpRenderTree converts "file:///" to a path differently
332         https://bugs.webkit.org/show_bug.cgi?id=76631
333
334         Reviewed by Martin Robinson.
335
336         DumpRenderTree should print "/" as the last path component if the
337         path is a lone slash instead of empty output.
338
339         * DumpRenderTree/gtk/DumpRenderTree.cpp:
340         (webViewConsoleMessage):
341
342 2012-01-20  David Levin  <levin@chromium.org>
343
344         The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
345         https://bugs.webkit.org/show_bug.cgi?id=76752
346
347         Reviewed by Eric Seidel.
348
349         * Scripts/webkitpy/style/checkers/cpp.py:
350         (check_for_leaky_patterns):
351         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
352         (LeakyPatternTest.test_create_dc):
353         (LeakyPatternTest.test_create_compatible_dc):
354
355 2012-01-20  Shawn Singh  <shawnsingh@chromium.org>
356
357         Changed my status in commiters.py
358
359         Unreviewed.
360
361         * Scripts/webkitpy/common/config/committers.py:
362
363 2012-01-20  Ojan Vafai  <ojan@chromium.org>
364
365         run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
366         https://bugs.webkit.org/show_bug.cgi?id=76748
367
368         Reviewed by Ryosuke Niwa.
369
370         It crawls the whole subtree and then doesn't use the data. Cutting this out
371         saves 4 seconds warm and 17 seconds cold on my Mac Pro.
372
373         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
374         (run):
375
376 2012-01-20  Adam Barth  <abarth@webkit.org>
377
378         Another tiny tweak to the garden-o-matic CSS.  This makes things line
379         up slightly nicer when there aren't any failures.
380
381         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
382         (#summary):
383
384 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
385
386         run-perf-tests should support --test-results-server option
387         https://bugs.webkit.org/show_bug.cgi?id=76680
388
389         Reviewed by Adam Barth.
390
391         Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
392         to be used by perf bots. Also refactor file_uploader as needed.
393
394         * Scripts/webkitpy/common/net/file_uploader.py:
395         (FileUploader.__init__):
396         (FileUploader.upload_single_file):
397         (FileUploader.upload_as_multipart_form_data):
398         (FileUploader):
399         (FileUploader._upload_data):
400         (FileUploader._upload_data.callback):
401         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
402         (JSONResultsGeneratorBase.upload_json_files):
403         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
404         (PerfTestsRunner):
405         (PerfTestsRunner._parse_args):
406         (PerfTestsRunner.run):
407         (PerfTestsRunner._generate_json):
408         (PerfTestsRunner._upload_json):
409         (PerfTestsRunner._run_tests_set):
410         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
411         (create_runner):
412         (test_run_with_upload_json):
413         (test_run_with_upload_json.mock_upload_json):
414         (test_upload_json):
415         (test_upload_json.MockFileUploader):
416         (test_upload_json.MockFileUploader.__init__):
417         (test_upload_json.MockFileUploader.upload_single_file):
418         (test_parse_args):
419
420 2012-01-20  Adam Barth  <abarth@webkit.org>
421
422         The party time image overlaps real content!  This patch makes the
423         image centered vertically.
424
425         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
426         (#onebar.partytime #summary):
427
428 2012-01-19  Ojan Vafai  <ojan@chromium.org>
429
430         Refactor TestExpectationsParser in preparation for caching the results
431         https://bugs.webkit.org/show_bug.cgi?id=76669
432
433         Reviewed by Dimitri Glazkov.
434
435         Make everything private expect for the parse method. 
436         Eventually, we'll need the expectations lines to not be modified
437         outside of TestExpectationsParser so we can cache the results.
438         This makes check-webkit-style of the chromium test_expectations.txt file
439         go from ~17 seconds to ~12 seconds on my Mac Pro.
440
441         This patch is just a refactor in preparation, so no new tests.
442
443         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
444         (TestExpectationEditorTests.make_parsed_expectation_lines):
445         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
446         (TestExpectationParser.parse):
447         (TestExpectationParser):
448         (TestExpectationParser._parse_line):
449         (TestExpectationParser._tokenize):
450         (TestExpectationParser._tokenize_list):
451         (TestExpectationsModel._clear_expectations_for_test):
452         (TestExpectations.__init__):
453         (TestExpectations._add_expectations):
454         (TestExpectations._add_skipped_tests):
455         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
456         (TestExpectationParserTests.test_tokenize_blank):
457         (TestExpectationParserTests.test_tokenize_missing_colon):
458         (TestExpectationParserTests.test_tokenize_extra_colon):
459         (TestExpectationParserTests.test_tokenize_empty_comment):
460         (TestExpectationParserTests.test_tokenize_comment):
461         (TestExpectationParserTests.test_tokenize_missing_equal):
462         (TestExpectationParserTests.test_tokenize_extra_equal):
463         (TestExpectationParserTests.test_tokenize_valid):
464         (TestExpectationParserTests.test_tokenize_valid_with_comment):
465         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
466         (TestExpectationParserTests.test_parse_empty_string):
467         (TestExpectationSerializerTests.assert_round_trip):
468         (TestExpectationSerializerTests.assert_list_round_trip):
469         * Scripts/webkitpy/tool/commands/expectations.py:
470         (OptimizeExpectations.execute):
471         * Scripts/webkitpy/tool/servers/gardeningserver.py:
472         (GardeningExpectationsUpdater.update_expectations):
473
474 2012-01-20  Adam Barth  <abarth@webkit.org>
475
476         Follow-up to previous patch: don't produce NaN when the revision number
477         is missing.
478
479         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
480         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
481
482 2012-01-20  Adam Barth  <abarth@webkit.org>
483
484         Garden-o-matic should tell me which revisions have been checked by all the bots
485         https://bugs.webkit.org/show_bug.cgi?id=76722
486
487         Reviewed by Dimitri Glazkov.
488
489         This information helps me know when it's safe for me to roll a
490         candidate revision.
491
492         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
494         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
495
496 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
497
498         build-webkit: Don't spit out congratulations message on Ctrl+C
499
500         Reviewed by Andreas Kling.
501
502         * Scripts/build-webkit:
503
504 2012-01-20  Philippe Normand  <pnormand@igalia.com>
505
506         [GTK] Allow extra jhbuild modulesets
507         https://bugs.webkit.org/show_bug.cgi?id=76691
508
509         Reviewed by Gustavo Noronha Silva.
510
511         * gtk/jhbuildrc: Extra modulesets and modules can be added in
512         JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
513         env variables respectively. Use comma-separated values. Example:
514         WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
515
516 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
517
518         [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
519         https://bugs.webkit.org/show_bug.cgi?id=72589
520
521         Reviewed by Martin Robinson.
522
523         Ensure the accessibility infrastructure is available when running
524         the unit tests, otherwise WK2's accessibility tests won't work.
525
526         * Scripts/run-gtk-tests:
527         (TestRunner):
528         (TestRunner._lookup_atspi2_binary): New. Looks for the directory
529         where at-spi2's stuff is located (like at-spi-bus-launcher and
530         at-spi2-registryd).
531         (TestRunner.run): Initialize the accessibility infrastructure.
532
533         * gtk/generate-gtkdoc:
534         (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
535
536         * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
537
538 2012-01-20  Hayato Ito  <hayato@chromium.org>
539
540         Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
541         https://bugs.webkit.org/show_bug.cgi?id=76353
542
543         Reviewed by Hajime Morita.
544
545         Add ShadowRoot.idl, which is enabled only on chromium port since this is
546         under development feature.
547         ShadowRoot.idl contains minimum API so that we can test it.
548         Other APIs should be added on other changes so that we can isolate issues.
549
550         * DumpRenderTree/chromium/TestShell.cpp:
551         (TestShell::TestShell):
552
553 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
554
555         [GTK] GTK's DRT not to log events for already defunct objects
556         https://bugs.webkit.org/show_bug.cgi?id=76620
557
558         Reviewed by Martin Robinson.
559
560         Do not log 'state-change:defunct' events.
561
562         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
563         (printAccessibilityEvent): Early return if a
564         'state-change:defunct' signal is passed.
565         (axObjectEventListener): Pass the signal name and value in
566         separate parameters to printAccessibilityEvent.
567
568 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
569
570         Unreviewed build fix. Wrong variable being used as the cwd for git
571         remote update command.
572
573         * gtk/run-with-jhbuild:
574         (update_jhbuild):
575
576 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
577
578         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
579         https://bugs.webkit.org/show_bug.cgi?id=76585
580
581         Reviewed by Martin Robinson.
582
583         This allows us to specify a minimum version of jhbuild required,
584         while also providing stability against changes done to the master
585         branch, by letting us choose what is the exact version that will
586         be used.
587
588         * gtk/run-with-jhbuild: refactored for more hackability and easier
589         reading
590         (jhbuild_installed): checks whether jhbuild is installed
591         (jhbuild_cloned): checks whether jhbuild has been cloned
592         (jhbuild_at_expected_revision): checks whether jhbuild is at the
593         expected revision
594         (update_jhbuild): brings jhbuild to the expected revision
595         (clone_jhbuild): clones jhbuild
596         (install_jhbuild): build and installs jhbuild
597         (update_webkitgtk_libs): runs update-webkitgtk-libs
598         (ensure_jhbuild): high-level logic to decide whether and which of
599         the steps above are executed
600
601 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
602
603         [WK2] DumpRenderTree converts "file:///" to a path differently
604         https://bugs.webkit.org/show_bug.cgi?id=76653
605
606         Reviewed by John Sullivan.
607
608         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
609         Do print a slash if there are no path components.
610
611 2012-01-19  Eric Seidel  <eric@webkit.org>
612
613         webkit-patch cannot rollout patches without changelog/bug number
614         https://bugs.webkit.org/show_bug.cgi?id=75962
615
616         Reviewed by Adam Barth.
617
618         * Scripts/webkitpy/tool/commands/download.py:
619         (AbstractRolloutPrepCommand._prepare_state):
620         * Scripts/webkitpy/tool/commands/download_unittest.py:
621         (AbstractRolloutPrepCommandTest.test_prepare_state):
622
623 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
624
625         [WK2] fast/url/degenerate-file-base.html fails
626         https://bugs.webkit.org/show_bug.cgi?id=76619
627
628         Reviewed by Adam Roben.
629
630         A URL generated form local path for loading had an extra slash, making document.URL
631         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
632
633         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
634
635 2012-01-18  Ojan Vafai  <ojan@chromium.org>
636
637         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
638         https://bugs.webkit.org/show_bug.cgi?id=76510
639
640         Reviewed by Adam Barth.
641
642         Unlike other style rules, if you get the syntax of the test_expectations.txt
643         file wrong, the layout tests won't run. Also, this check is simple and only
644         slows down committing if you actually modify one of the test_expectations.txt files.
645
646         * Scripts/webkitpy/style/checkers/test_expectations.py:
647         (TestExpectationsChecker.check_test_expectations):
648         (TestExpectationsChecker.check):
649         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
650         (TestExpectationsTestCase.test_check_covers_all_configurations):
651         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
652         (TestExpectationsTestCase):
653         (assert_lines_lint):
654
655 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
656
657         Build fix. Revert an unintentional change to WebKitDriver in r105443.
658
659         * Scripts/webkitpy/layout_tests/port/driver.py:
660         (DriverProxy.__init__):
661
662 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
663
664         remove the duplicated build rules from WebKit.gyp, Tools.gyp
665         https://bugs.webkit.org/show_bug.cgi?id=73384
666
667         Reviewed by Tony Chang.
668
669         This patch removes the no-longer-necessary conditional logic for
670         build_webkit_exes_from_webkit_gyp; we now always build the exes
671         from their own dedicated gyp files.
672
673         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
674
675 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
676
677         make-new-script-test should work with HTTP tests
678         https://bugs.webkit.org/show_bug.cgi?id=76603
679
680         Reviewed by Adam Roben.
681
682         * Scripts/make-new-script-test:
683         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
684         now also creates absolute paths for HTTP.
685
686 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
687
688         Some perf tests time out when ran by run-perf-tests
689         https://bugs.webkit.org/show_bug.cgi?id=76612
690
691         Reviewed by Dirk Pranke and Eric Seidel.
692
693         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
694         Otherwise some tests such as Parser/xml-parser.html will timeout.
695
696         --no-timeout option is currently supported by Chromium and Mac ports.
697
698         * Scripts/webkitpy/layout_tests/port/base.py:
699         (Port.to.create_driver):
700         * Scripts/webkitpy/layout_tests/port/chromium.py:
701         (ChromiumDriver.__init__):
702         (ChromiumDriver._wrapper_options):
703         * Scripts/webkitpy/layout_tests/port/driver.py:
704         (Driver.__init__):
705         (DriverProxy.__init__):
706         * Scripts/webkitpy/layout_tests/port/webkit.py:
707         (WebKitDriver.__init__):
708         (WebKitDriver.cmd_line):
709         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
710         (WebKitDriverTest.test_read_binary_block):
711         (WebKitDriverTest):
712         (WebKitDriverTest.test_no_timeout):
713         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
714         (get_tests_run.RecordingTestDriver.__init__):
715         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
716         (PerfTestsRunner._parse_args):
717         (PerfTestsRunner._run_tests_set):
718         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
719         (create_runner):
720
721 2012-01-19  Ben Wells  <benwells@chromium.org>
722
723         Add support for window.print to chromium DRT
724         https://bugs.webkit.org/show_bug.cgi?id=76479
725
726         When used in a test window.print goes into print mode and then
727         straight out again. This will allow the afterprint event to be
728         tested by having the afterprint event happen before the dump
729         happens.
730
731         Reviewed by Mihai Parparita.
732
733         * DumpRenderTree/chromium/WebViewHost.cpp:
734         (WebViewHost::printPage):
735         * DumpRenderTree/chromium/WebViewHost.h:
736
737 2012-01-18  Enrica Casucci  <enrica@apple.com>
738
739         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
740         https://bugs.webkit.org/show_bug.cgi?id=76588
741         <rdar://problem/9325183>
742
743         Added test.
744         
745         Reviewed by Dan Bernstein.
746
747         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
748         (TestWebKitAPI::TEST):
749
750 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
751
752         [Qt] Do full incremental builds until bots use update-webkit
753
754         Rubber-stamped by Simon Hausmann.
755
756         * Scripts/webkitdirs.pm:
757         (buildQMakeProjects):
758
759 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
760
761         Fix the Qt build
762
763         Unreviewed build fix.
764
765         * Scripts/webkitdirs.pm:
766         (buildQMakeProjects):
767
768 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
769
770         [Qt] Make build-webkit always do safe incremental builds after update-webkit
771
772         When building against Qt5 with GCC we would just run 'make' in the build dir,
773         and rely on the dependency files output by GCC (-MD) to handle dependency
774         tracking, but that fails for special-cases like adding a Q_OBJECT macro
775         to a header.
776
777         To guarantee that an incrmental build will work, we have to run 'make qmake',
778         which we now do on every build-webkit that's followed by a successful run
779         of update-webkit. The reasoning is that update-webkit can result in such
780         potential corner-cases being applied, and since we can't know for sure
781         unless we inspect the diff and account for all the corner cases we assume
782         the worst and always run 'make qmake'.
783
784         After a succesful run of build-webkit we proceed to do just 'make' for any
785         subsequent runs, since we assume that the developer knows what kind of
786         changes he/she is doing, and when a 'make qmake' is needed.
787
788         Reviewed by Simon Hausmann.
789
790         * Scripts/update-webkit:
791         * Scripts/webkitdirs.pm:
792         (determineCurrentSVNRevision):
793         (currentSVNRevision):
794         (buildQMakeProjects):
795         * qmake/mkspecs/features/default_post.prf:
796
797 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
798
799         run-perf-tests should support Skipped list
800         https://bugs.webkit.org/show_bug.cgi?id=76594
801
802         Reviewed by Adam Barth.
803
804         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
805
806         * Scripts/webkitpy/layout_tests/port/base.py:
807         (Port.perf_tests_dir):
808         (Port.skipped_perf_tests):
809         (Port.skips_perf_test):
810         (Port.relative_perf_test_filename):
811         * Scripts/webkitpy/layout_tests/port/test.py:
812         (TestPort.perf_tests_dir):
813         * Scripts/webkitpy/layout_tests/port/webkit.py:
814         (WebKitPort._expectations_from_skipped_files):
815         (WebKitPort):
816         (WebKitPort.skipped_layout_tests):
817         (WebKitPort.skipped_perf_tests):
818         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
819         (PerfTestsRunner._collect_tests):
820         (PerfTestsRunner.run):
821         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
822         (test_run_test_set_with_json_output):
823         (test_run_test_set_with_json_source):
824         (test_collect_tests_with_skipped_list):
825         (test_collect_tests_with_skipped_list.add_file):
826
827 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
828
829         Fix path to chromium_src_dir introduced in previous change.
830
831         Unreviewed, build fix.
832
833         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
834
835 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
836
837         Need infrastructure to test Content-Disposition filename encoding support
838         https://bugs.webkit.org/show_bug.cgi?id=76572
839         <rdar://problem/6421825>
840
841         Reviewed by Sam Weinig.
842
843         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
844
845         WebKitTestRunner does not have a policy delegate yet, bug 42546.
846
847         * DumpRenderTree/mac/PolicyDelegate.mm:
848         (dispositionTypeFromContentDispositionHeader):
849         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
850
851 2012-01-18  Ojan Vafai  <ojan@chromium.org>
852
853         Fix tests from http://trac.webkit.org/changeset/105332.
854
855         The code assumed that if you passed an options object with a configuration
856         attribute that it would have a valid value. A bunch of the testing mocks
857         do things like having a configuration value of None.
858
859         * Scripts/webkitpy/layout_tests/port/base.py:
860         (Port.__init__):
861
862 2012-01-18  Ojan Vafai  <ojan@chromium.org>
863
864         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
865         https://bugs.webkit.org/show_bug.cgi?id=76576
866
867         Reviewed by Adam Barth.
868
869         Avoid calling default_configuration in base.py. We don't need it for
870         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
871         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
872         from common.executive.
873
874         At some point someone should probably look into why that call is so slow
875         since it's on the critical path for run-webkit-tests and build-webkit startup.
876
877         * Scripts/webkitpy/layout_tests/port/base.py:
878         (Port.__init__):
879         * Scripts/webkitpy/style/checkers/test_expectations.py:
880         (TestExpectationsChecker._determine_port_from_exepectations_path):
881
882 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
883
884         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
885         https://bugs.webkit.org/show_bug.cgi?id=76505
886
887         Reviewed by Tony Chang.
888
889         Update chromium build script to use All.gyp instead of WebKit.gyp
890
891         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
892         * Scripts/webkitdirs.pm:
893
894 2012-01-18  Sam Weinig  <sam@webkit.org>
895
896         Don’t hardcode the path to ‘make‘.
897
898         Reviewed by Dan Bernstein.
899
900         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
901
902 2012-01-18  Joshua Bell  <jsbell@chromium.org>
903
904         Adding myself to committers.py
905         https://bugs.webkit.org/show_bug.cgi?id=76569
906
907         Unreviewed.
908
909         * Scripts/webkitpy/common/config/committers.py:
910
911 2012-01-18  Adam Barth  <abarth@webkit.org>
912
913         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
914         https://bugs.webkit.org/show_bug.cgi?id=76567
915
916         Reviewed by Eric Seidel.
917
918         Current the AppleMac port has slightly more failures than we allow on
919         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
920         which should hopefully let the mac-ews run to completion.  Once
921         AppleMac has fewer failures, we can lower the cap again.
922
923         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
924         (LayoutTestResultsReaderTest.test_layout_test_results):
925         * Scripts/webkitpy/tool/steps/runtests.py:
926         (RunTests):
927         * Scripts/webkitpy/tool/steps/steps_unittest.py:
928
929 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
930
931         Provide access to user's list of preferred languages
932         https://bugs.webkit.org/show_bug.cgi?id=76138
933
934         Reviewed by Alexey Proskuryakov.
935
936         * GNUmakefile.am: Add JSInternalsCustom.cpp.
937
938 2012-01-18  Adam Barth  <abarth@webkit.org>
939
940         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
941         configurations.
942
943         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
944         (ChromiumLinuxPort.__init__):
945
946 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
947
948         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
949         https://bugs.webkit.org/show_bug.cgi?id=73460
950
951         Reviewed by Chris Fleizach.
952
953         * DumpRenderTree/AccessibilityUIElement.h:
954         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
955         (AccessibilityUIElement::AccessibilityUIElement):
956         (AccessibilityUIElement::scrollToMakeVisibleCallback):
957         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
958         (AccessibilityUIElement::scrollToGlobalPointCallback):
959         * DumpRenderTree/chromium/AccessibilityUIElement.h:
960         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
961         (AccessibilityUIElement::scrollToMakeVisible):
962         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
963         (AccessibilityUIElement::scrollToGlobalPoint):
964         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
965         (AccessibilityUIElement::scrollToMakeVisible):
966         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
967         (AccessibilityUIElement::scrollToGlobalPoint):
968         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
969         (AccessibilityUIElement::scrollToMakeVisible):
970         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
971         (AccessibilityUIElement::scrollToGlobalPoint):
972
973 2012-01-17  Enrica Casucci  <enrica@apple.com>
974
975         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
976         https://bugs.webkit.org/show_bug.cgi?id=76490
977         <rdar://problem/9460733>
978
979         Added TestWebKitAPI test.
980         
981         Reviewed by Dan Bernstein.
982
983         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
984         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
985         changeAttributes to the WebView.
986         
987 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
988
989         [Qt] Consolidate layout test crash logging
990         https://bugs.webkit.org/show_bug.cgi?id=75088
991
992         Reviewed by Simon Hausmann.
993
994         Move backtrace generating logic into WTFReportBacktrace
995         and add a way to deinstall signal handlers if we know
996         that we have already printed the backtrace.
997
998         * DumpRenderTree/qt/main.cpp:
999         (crashHandler):
1000         (setupSignalHandlers):
1001         (WTFCrashHook):
1002         (main):
1003         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1004         (WTR::crashHandler):
1005         (WTR::setupSignalHandlers):
1006         (WTR::crashHook):
1007         (WTR::InjectedBundle::platformInitialize):
1008
1009 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
1010
1011         Unreviewed build fix after r105256.
1012
1013         There was a cyclic dependency between self._port and self._host assigments.
1014
1015         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1016         (PerfTestsRunner.__init__):
1017
1018 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1019
1020         Add new watchlist rule for the Qt build system
1021
1022         Reviewed by Simon Hausmann.
1023
1024         * Scripts/webkitpy/common/config/watchlist:
1025
1026 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1027
1028         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
1029
1030         Reviewed by Simon Hausmann.
1031
1032         * Tools.pro:
1033
1034 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1035
1036         [Qt] Allow building only a subset of the WebKit sub-projects
1037
1038         Fixes build-jsc, broken in r104825.
1039
1040         We no longer need the intermediate buildQMakeQtProject(), as we're the
1041         only port using qmake, and buildQMakeProject is now highly Qt specific.
1042
1043         <http://webkit.org/b/76179>
1044
1045         Reviewed by Simon Hausmann.
1046
1047         * Scripts/build-jsc:
1048         * Scripts/build-webkit:
1049         * Scripts/webkitdirs.pm:
1050         (buildQMakeProjects):
1051
1052 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
1053
1054         run-perf-tests should generate a json file that summaries the result
1055         https://bugs.webkit.org/show_bug.cgi?id=76504
1056
1057         Reviewed by Adam Barth.
1058
1059         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
1060         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
1061         another json file to be merged into the generated json file.
1062
1063         Also fixed a bug that --build wasn't set by default.
1064
1065         * Scripts/webkitpy/layout_tests/port/test.py:
1066         (TestPort.webkit_base):
1067         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1068         (PerfTestsRunner.__init__):
1069         (PerfTestsRunner):
1070         (PerfTestsRunner._parse_args):
1071         (PerfTestsRunner.run):
1072         (PerfTestsRunner._generate_json_if_specified):
1073         (PerfTestsRunner._process_chromium_style_test_result):
1074         (PerfTestsRunner._process_parser_test_result):
1075         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1076         (MainTest):
1077         (create_runner):
1078         (test_run_test_set):
1079         (test_run_test_set_for_parser_tests):
1080         (test_run_test_set_with_summary_json):
1081         (test_collect_tests):
1082         (test_parse_args):
1083
1084 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
1085
1086         Unreviewed, rolling out r105244.
1087         http://trac.webkit.org/changeset/105244
1088         https://bugs.webkit.org/show_bug.cgi?id=76518
1089
1090         broke Chromium Mac (Requested by rolandsteiner on #webkit).
1091
1092         * DumpRenderTree/AccessibilityUIElement.h:
1093         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1094         (AccessibilityUIElement::AccessibilityUIElement):
1095         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1096         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1097         (AccessibilityUIElement::removeSelection):
1098         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1099         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1100         (AccessibilityUIElement::removeSelection):
1101
1102 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
1103
1104         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
1105         https://bugs.webkit.org/show_bug.cgi?id=73460
1106
1107         Reviewed by Chris Fleizach.
1108
1109         * DumpRenderTree/AccessibilityUIElement.h:
1110         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1111         (AccessibilityUIElement::AccessibilityUIElement):
1112         (AccessibilityUIElement::scrollToMakeVisibleCallback):
1113         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
1114         (AccessibilityUIElement::scrollToGlobalPointCallback):
1115         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1116         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1117         (AccessibilityUIElement::scrollToMakeVisible):
1118         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1119         (AccessibilityUIElement::scrollToGlobalPoint):
1120         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1121         (AccessibilityUIElement::scrollToMakeVisible):
1122         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1123         (AccessibilityUIElement::scrollToGlobalPoint):
1124         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1125         (AccessibilityUIElement::scrollToMakeVisible):
1126         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1127         (AccessibilityUIElement::scrollToGlobalPoint):
1128
1129 2012-01-17  Adam Barth  <abarth@webkit.org>
1130
1131         Enable tests on the mac-ews
1132         https://bugs.webkit.org/show_bug.cgi?id=76502
1133
1134         Reviewed by Simon Fraser.
1135
1136         Apple now has five machines running the mac-ews.  Lucas Forschler has
1137         asked that we try enabling tests to see if we have enough bandwidth.
1138
1139         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1140         (MacEWS):
1141
1142 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
1143
1144         Add a check-webkit-style exception for GDBInterface.cpp
1145         https://bugs.webkit.org/show_bug.cgi?id=76187
1146
1147         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
1148         that it does not fail the style check.
1149
1150         Reviewed by Martin Robinson.
1151
1152         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
1153         readability/naming tests on
1154         Source/JavaScriptCore/jit/GDBInterface.cpp.
1155         * Scripts/webkitpy/style/checker_unittest.py:
1156         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
1157         the above exception.
1158
1159 2012-01-17  Hajime Morrita  <morrita@chromium.org>
1160
1161         https://bugs.webkit.org/show_bug.cgi?id=76245
1162         [Mac][DRT] should allow query string for the file URL.
1163
1164         Reviewed by Tony Chang.
1165
1166         Taught DRT about file:// as a url instead of a file path.
1167         We are now able to use a path file:///foo/bar.html?baz as a url
1168         with which DRT opens "/foo/bar.html" with "baz" as a query string.
1169
1170         * DumpRenderTree/mac/DumpRenderTree.mm:
1171         (runTest):
1172
1173 2012-01-17  Ojan Vafai  <ojan@chromium.org>
1174
1175         Check style on test_expectations.txt files before commit
1176         https://bugs.webkit.org/show_bug.cgi?id=76484
1177
1178         Reviewed by Adam Barth.
1179
1180         Unlike other style rules, if you get the syntax of the test_expectations.txt
1181         file wrong, the layout tests won't run. Also, this check is simple and only
1182         slows down committing if you actually modify one of the test_expectations.txt files.
1183
1184         * Scripts/webkitpy/tool/steps/commit.py:
1185         (Commit._check_test_expectations):
1186         (Commit.run):
1187         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
1188         (CommitTest):
1189         (CommitTest.test_check_test_expectations):
1190
1191 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1192
1193         [Qt] Debug build fails with debug qt5
1194         https://bugs.webkit.org/show_bug.cgi?id=76463
1195
1196         Reviewed by Simon Hausmann.
1197
1198         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
1199
1200         * QtTestBrowser/cookiejar.h:
1201
1202 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1203
1204         webkitpy: fix json import on linux
1205         https://bugs.webkit.org/show_bug.cgi?id=76481
1206
1207         Reviewed by Adam Barth.
1208
1209         For some reason, the version of simplejson autoinstalled on my linux
1210         box seems to be broken. We should really only be using
1211         simplejson if json isn't available anyway, so this change looks
1212         for json first.
1213
1214         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1215         (JSONGeneratorTest.test_test_timings_trie):
1216
1217 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1218
1219         Fix failures in test-webkitpy caused by r105177.
1220
1221         Unreviewed, build fix.
1222
1223         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1224         (ChromiumLinuxPort._determine_driver_path_statically):
1225         (ChromiumLinuxPort._static_build_path):
1226
1227 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1228
1229         webkitpy: make PortFactory.get() be fully data-driven
1230         https://bugs.webkit.org/show_bug.cgi?id=76360
1231
1232         Reviewed by Eric Seidel.
1233
1234         Refactor PortFactory.get() to be fully data-driven.
1235
1236         * Scripts/webkitpy/layout_tests/port/factory.py:
1237         (PortFactory):
1238         (PortFactory._default_port):
1239         (PortFactory.get):
1240         (PortFactory.get.in):
1241         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1242         (FactoryTest.assert_port):
1243
1244 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1245
1246         webkitpy: add determine_full_port_name(), clean up port.__init__()
1247         https://bugs.webkit.org/show_bug.cgi?id=76357
1248
1249         Reviewed by Adam Barth.
1250
1251         Each Port class is now required to implement a 'port_name' field
1252         that will match the start of all ports constructed by this class and
1253         a 'determine_full_port_name' field that will make the port
1254         fully-qualified.
1255
1256         * Scripts/webkitpy/layout_tests/port/apple.py:
1257         (ApplePort.__init__):
1258         * Scripts/webkitpy/layout_tests/port/base.py:
1259         (Port):
1260         (Port.determine_port_name):
1261         (Port.__init__):
1262         * Scripts/webkitpy/layout_tests/port/chromium.py:
1263         (ChromiumPort.for):
1264         (ChromiumPort.__init__):
1265         (ChromiumPort):
1266         (ChromiumPort._chromium_base_dir):
1267         (ChromiumPort.path_from_chromium_base):
1268         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1269         (ChromiumGpuLinuxPort):
1270         (ChromiumGpuLinuxPort.__init__):
1271         (ChromiumGpuMacPort):
1272         (ChromiumGpuMacPort.__init__):
1273         (ChromiumGpuWinPort):
1274         (ChromiumGpuWinPort.__init__):
1275         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1276         (ChromiumLinuxPort):
1277         (ChromiumLinuxPort.determine_port_name):
1278         (ChromiumLinuxPort.__init__):
1279         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1280         (ChromiumMacPort):
1281         (ChromiumMacPort.determine_port_name):
1282         (ChromiumMacPort.__init__):
1283         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1284         (ChromiumWinPort):
1285         (ChromiumWinPort.determine_port_name):
1286         (ChromiumWinPort.__init__):
1287         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1288         (DryRunPort):
1289         (DryRunPort.determine_port_name):
1290         (DryRunPort.__init__):
1291         * Scripts/webkitpy/layout_tests/port/efl.py:
1292         (EflPort):
1293         * Scripts/webkitpy/layout_tests/port/factory.py:
1294         (PortFactory):
1295         (PortFactory._default_port):
1296         (PortFactory.get):
1297         (PortFactory.get.in):
1298         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1299         (FactoryTest.assert_port):
1300         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1301         (GoogleChromeLinux32Port):
1302         (GoogleChromeLinux32Port.determine_port_name):
1303         (GoogleChromeLinux64Port):
1304         (GoogleChromeLinux64Port.determine_port_name):
1305         (GoogleChromeMacPort):
1306         (GoogleChromeMacPort.determine_port_name):
1307         (GoogleChromeWinPort):
1308         (GoogleChromeWinPort.determine_port_name):
1309         * Scripts/webkitpy/layout_tests/port/gtk.py:
1310         (GtkPort):
1311         * Scripts/webkitpy/layout_tests/port/mac.py:
1312         (MacPort):
1313         (MacPort.determine_port_name):
1314         (MacPort.__init__):
1315         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1316         (test_versions):
1317         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1318         (MockDRTPort):
1319         (MockDRTPort.determine_port_name):
1320         (MockDRTPort.__init__):
1321         (MockDRT):
1322         (MockDRT.determine_port_name):
1323         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1324         (PortTestCase.make_port):
1325         * Scripts/webkitpy/layout_tests/port/qt.py:
1326         (QtPort):
1327         (QtPort.determine_port_name):
1328         (QtPort.__init__):
1329         * Scripts/webkitpy/layout_tests/port/test.py:
1330         (TestPort):
1331         (TestPort.determine_port_name):
1332         (TestPort.__init__):
1333         * Scripts/webkitpy/layout_tests/port/webkit.py:
1334         (WebKitPort.__init__):
1335         * Scripts/webkitpy/layout_tests/port/win.py:
1336         (WinPort):
1337         (WinPort.determine_port_name):
1338         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1339         (get_test_baselines.AllPlatformsPort.__init__):
1340         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1341         (get_test_config.TestMacPort):
1342         (get_test_config):
1343
1344 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1345
1346         webkitpy: clean up port code in preparation for static port names
1347         https://bugs.webkit.org/show_bug.cgi?id=76356
1348
1349         Reviewed by Adam Barth.
1350
1351         To fix bug 76215 and be able to determine appropriate port names
1352         in webkitpy without actually constructing Port objects, we need
1353         to shuffle some logic in the chromium ports to be able to figure
1354         out whether we built DRT in 32 or 64-bit mode.
1355
1356         * Scripts/webkitpy/layout_tests/port/chromium.py:
1357         (ChromiumPort):
1358         (ChromiumPort._chromium_base_dir):
1359         (ChromiumPort.__init__):
1360         (ChromiumPort.path_from_chromium_base):
1361         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1362         (ChromiumLinuxPort):
1363         (ChromiumLinuxPort._determine_driver_path_statically):
1364         (ChromiumLinuxPort._static_build_path):
1365         (ChromiumLinuxPort._determine_architecture):
1366         (ChromiumLinuxPort.__init__):
1367         (ChromiumLinuxPort._build_path):
1368
1369 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
1370
1371         Do not remove pixel failures for ref tests.
1372         https://bugs.webkit.org/show_bug.cgi?id=76243
1373
1374         Reviewed by Tony Chang.
1375
1376         'NRWT --no-pixel-tests' complains when reftests are expected to
1377         be image mismatch.
1378
1379         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1380         (Manager._update_summary_with_result):
1381         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1382         (is_reftest_failure):
1383         (determine_result_type):
1384
1385 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
1386
1387         REGRESSION(r81225): ORWT should ignore reftests
1388         https://bugs.webkit.org/show_bug.cgi?id=67936
1389
1390         Reviewed by Csaba Osztrogonác.
1391
1392         * Scripts/old-run-webkit-tests:
1393         (isUsedInReftest): $filename should be the first parameter
1394         (findTestsToRun): run test if it isn't reftest
1395
1396 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
1397
1398         Unreviewed. Fix python unit test I broke with r105142
1399
1400         * Scripts/webkitpy/common/config/ports_unittest.py:
1401         (WebKitPortTest.test_gtk_port):
1402
1403 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1404
1405         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
1406
1407         Qt 5 no longer has that flag.
1408
1409         Reviewed by Simon Hausmann.
1410
1411         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1412         (MiniBrowserApplication::notify):
1413
1414 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1415
1416         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
1417         https://bugs.webkit.org/show_bug.cgi?id=75857
1418
1419         Reviewed by Adam Barth.
1420
1421         * Scripts/webkitdirs.pm:
1422         (buildAutotoolsProject): move cleaning the build to happen early,
1423         and handle --update-gtk right after that
1424         * Scripts/webkitpy/common/config/ports.py:
1425         (GtkPort.build_webkit_command): pass --update-gtk as an option to
1426         build-webkit, so that it is used in the EWS
1427
1428 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1429
1430         [Qt] Don't add _debug postfix to targets when building debug only
1431
1432         Reviewed by Simon Hausmann.
1433
1434         * qmake/mkspecs/features/default_post.prf:
1435         * qmake/mkspecs/features/functions.prf:
1436
1437 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1438
1439         [Qt] Add more files to project-files for easier navigation in Qt Creator
1440
1441         Reviewed by Simon Hausmann.
1442
1443         * Tools.pro:
1444         * qmake/config.tests/README: Added.
1445
1446 2012-01-17  Philippe Normand  <pnormand@igalia.com>
1447
1448         [GTK] fast/dom/constructed-objects-prototypes.html fails
1449         https://bugs.webkit.org/show_bug.cgi?id=75432
1450
1451         Reviewed by Martin Robinson.
1452
1453         * Scripts/build-webkit: Enable video-track in GTK.
1454
1455 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
1456
1457         Add toyoshim as a committer.
1458         https://bugs.webkit.org/show_bug.cgi?id=76390
1459
1460         Reviewed by Hajime Morita.
1461
1462         * Scripts/webkitpy/common/config/committers.py:
1463
1464 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
1465
1466         [WinCairo] Build fix after r104155. Several debug targets were not
1467         properly including the '*Common' property sheets.
1468
1469         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
1470         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
1471         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
1472         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
1473         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
1474
1475 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
1476
1477         REGRESSION(r105072): It broke committers_unittest.py
1478         https://bugs.webkit.org/show_bug.cgi?id=76396
1479
1480         Reviewed by Adam Barth.
1481
1482         * Scripts/webkitpy/common/config/committers_unittest.py:
1483         (CommittersTest._assert_fuzz_match): It should handle more names.
1484         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
1485
1486 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
1487
1488         [GTK] Include gtk+3 in the jhbuild modules
1489         https://bugs.webkit.org/show_bug.cgi?id=76284
1490
1491         Reviewed by Philippe Normand.
1492
1493         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
1494
1495 2012-01-16  Dan Winship  <danw@gnome.org>
1496
1497         Add myself as a committer
1498
1499         Unreviewed
1500
1501         * Scripts/webkitpy/common/config/committers.py:
1502
1503 2012-01-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
1504
1505         Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
1506
1507         Some recent versions of a few Linux distributions have started passing
1508         --as-needed and --no-copy-dt-needed-entries by default to the linker,
1509         which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
1510         needed a few symbols from libjavascriptcore_efl.so.
1511
1512         * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
1513         before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
1514         libraries are searched in the right order by the linker.
1515
1516 2012-01-16  Philippe Normand  <pnormand@igalia.com>
1517
1518         [GTK] set audio resources path in NRTW
1519         https://bugs.webkit.org/show_bug.cgi?id=76380
1520
1521         Reviewed by Martin Robinson.
1522
1523         * Scripts/webkitpy/layout_tests/port/gtk.py:
1524         (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
1525         the uninstalled audio resources are used during webaudio tests.
1526
1527 2012-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1528
1529         [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
1530         https://bugs.webkit.org/show_bug.cgi?id=76369
1531
1532         Reviewed by Xan Lopez.
1533
1534         If there's an installed version of webkit and there are new
1535         symbols in the build tree, gtkdoc-scanobj fails due to undefined
1536         references, because the env ldflags are given before the local
1537         ones.
1538
1539         * gtk/gtkdoc.py:
1540         (GTKDoc._run_gtkdoc_scangobj):
1541
1542 2012-01-15  Pablo Flouret  <pablof@motorola.com>
1543
1544         Fix compilation errors on build-webkit --debug --no-video on mac.
1545         https://bugs.webkit.org/show_bug.cgi?id=75867
1546
1547         Reviewed by Philippe Normand.
1548
1549         Add --[no-]video-track to build-webkit, since video track feature
1550         depends on video.
1551
1552         * Scripts/build-webkit:
1553
1554 2012-01-14  James Robinson  <jamesr@chromium.org>
1555
1556         [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
1557         https://bugs.webkit.org/show_bug.cgi?id=76313
1558
1559         Reviewed by Adam Barth.
1560
1561         The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
1562
1563         * Scripts/run-chromium-webkit-unit-tests:
1564
1565 2012-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1566
1567         Unreviewed, rolling out r105017.
1568         http://trac.webkit.org/changeset/105017
1569         https://bugs.webkit.org/show_bug.cgi?id=76333
1570
1571         broke the build (Requested by philn-tp on #webkit).
1572
1573         * gtk/jhbuild.modules:
1574
1575 2012-01-14  Mario Sanchez Prada  <msanchez@igalia.com>
1576
1577         [GTK] Include gtk+3 in the jhbuild modules
1578         https://bugs.webkit.org/show_bug.cgi?id=76284
1579
1580         Reviewed by Philippe Normand.
1581
1582         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
1583
1584 2012-01-13  Adam Barth  <abarth@webkit.org>
1585
1586         Remove --dry-run support from webkit-patch
1587         https://bugs.webkit.org/show_bug.cgi?id=76300
1588
1589         Reviewed by Dirk Pranke.
1590
1591         This is the rest of the patch from Bug 76300.  I landed it separtely
1592         because main.py had some stray conflict markers that I needed to clean
1593         up first.
1594
1595         * Scripts/webkitpy/test/main.py:
1596         (Tester.parse_args):
1597         (Tester._run_tests):
1598
1599 2012-01-13  Adam Barth  <abarth@webkit.org>
1600
1601         test-webkitpy does not run
1602         https://bugs.webkit.org/show_bug.cgi?id=76318
1603
1604         Unreviewed.
1605
1606         Looks like some conflict markers got left in the file.
1607
1608         * Scripts/webkitpy/test/main.py:
1609         (Tester.run):
1610
1611 2012-01-13  Adam Barth  <abarth@webkit.org>
1612
1613         Remove --dry-run support from webkit-patch
1614         https://bugs.webkit.org/show_bug.cgi?id=76300
1615
1616         Reviewed by Dirk Pranke.
1617
1618         We don't use this functionality for anything, and it doesn't really
1619         work.  Someone in #webkit tried using it and and got sad/confused.  We
1620         should just remove it.
1621
1622         * Scripts/webkitpy/common/checkout/scm/git.py:
1623         (Git.push_local_commits_to_server):
1624         * Scripts/webkitpy/common/checkout/scm/scm.py:
1625         (SCM.__init__):
1626         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1627         (_shared_test_commit_with_message):
1628         (GitSVNTest.test_commit_text_parsing):
1629         * Scripts/webkitpy/common/checkout/scm/svn.py:
1630         (SVN.commit_with_message):
1631         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1632         (Bugzilla.__init__):
1633         (Bugzilla.quips):
1634         (Bugzilla.authenticate):
1635         (Bugzilla.add_attachment_to_bug):
1636         (Bugzilla.add_patch_to_bug):
1637         (Bugzilla.create_bug):
1638         (Bugzilla.clear_attachment_flags):
1639         (Bugzilla.set_flag_on_attachment):
1640         (Bugzilla.obsolete_attachment):
1641         (Bugzilla.add_cc_to_bug):
1642         (Bugzilla.post_comment_to_bug):
1643         (Bugzilla.close_bug_as_fixed):
1644         (Bugzilla.reassign_bug):
1645         (reopen_bug):
1646         * Scripts/webkitpy/test/main.py:
1647         (Tester.parse_args):
1648         (Tester.run_tests):
1649
1650 2012-01-13  David Levin  <levin@chromium.org>
1651
1652         check-webkit-style: should encourage the use of Own* classes for Windows DC.
1653         https://bugs.webkit.org/show_bug.cgi?id=76227
1654
1655         Reviewed by Dirk Pranke.
1656
1657         * Scripts/webkitpy/style/checkers/cpp.py:
1658         (check_for_leaky_patterns): The new check.
1659         (process_line): Added a call to the new check.
1660         (CppChecker): Added the new error type.
1661         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1662         (CppStyleTestBase):
1663         (CppStyleTestBase.perform_leaky_pattern_check):
1664         The check for only leaky pattern errors.
1665         (LeakyPatternTest): Test cases.
1666
1667 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1668
1669         test-webkitpy: clean up handling of test directories, QueueStatusServer
1670         https://bugs.webkit.org/show_bug.cgi?id=76238
1671
1672         Reviewed by Adam Barth.
1673
1674         This patch cleans up a bunch of hacks related to how we find all
1675         of the python unit tests and set up the sys.path variable in
1676         test-webkitpy.
1677
1678         This patch changes how test-webkitpy works slightly in that we
1679         will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
1680         rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
1681         This greatly simplifies the mapping of paths to module names and
1682         appears to have no significant performance impact or other drawbacks.
1683
1684         There are other ways that we could remove all of the hacks and
1685         still have a more flexible mapping of paths to module names, but
1686         the ones I've thought of so far add a decent amount of complexity to
1687         the implementation and don't seem to buy us much.
1688         
1689         * QueueStatusServer/__init__.py:
1690         * Scripts/test-webkitpy:
1691         * Scripts/webkitpy/test/main.py:
1692         (Tester._modules_from_paths):
1693         (Tester._is_module):
1694
1695 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1696
1697         test-webkitpy: should support classes and individual test names as well as modules
1698         https://bugs.webkit.org/show_bug.cgi?id=76233
1699
1700         Reviewed by Adam Barth.
1701
1702         The default unittest.main() supports a list of individual
1703         TestCase classes or individual tests as well as modules. This
1704         change adds support for the same to test-webkitpy, so now you
1705         can say
1706
1707           % test-wekbitpy webkitpy.test.cat_unittest.CatTest
1708
1709         and
1710
1711           % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
1712
1713         in addition to
1714
1715           % test-wekbitpy webkitpy.test.cat_unittest
1716
1717         * Scripts/test-webkitpy:
1718         * Scripts/webkitpy/test/cat_unittest.py:
1719         * Scripts/webkitpy/test/main.py:
1720         (Tester.parse_args):
1721         (Tester.run):
1722         (Tester):
1723         (Tester._find_modules):
1724         (Tester._exclude):
1725         (Tester._run_tests):
1726         (Tester._is_module):
1727         (Tester._log_exception):
1728
1729 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1730
1731         test-webkitpy: add basic code coverage support
1732         https://bugs.webkit.org/show_bug.cgi?id=76201
1733
1734         Reviewed by Adam Barth.
1735
1736         This test adds basic code coverage support to test-webkitpy; if
1737         you pass the -c flag, we will generate a new coverage file. We
1738         can start simply with this and add more features as necessary.
1739
1740         This patch requires coverage to be already installed on the
1741         machine. I am not auto-installing this for now.
1742
1743         * Scripts/webkitpy/test/main.py:
1744         (Tester.parse_args):
1745         (Tester.run_tests):
1746
1747 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1748
1749         StatusBubbleTest.test_build_bubble is failing
1750         https://bugs.webkit.org/show_bug.cgi?id=76222
1751
1752         Reviewed by Adam Barth.
1753
1754         * QueueStatusServer/handlers/statusbubble_unittest.py:
1755         (StatusBubbleTest.test_build_bubble):
1756
1757 2012-01-13  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1758
1759         nrwt should use multiple http shards
1760         https://bugs.webkit.org/show_bug.cgi?id=75958
1761
1762         Add --max-locked-shards option to the nrwt for manual set
1763         the maximum number of the locked shards
1764
1765         Reviewed by Dirk Pranke.
1766
1767         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1768         (Manager._max_locked_shards):
1769         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1770         (ShardingTests.get_shards):
1771         (ShardingTests.test_multiple_locked_shards):
1772         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1773         (parse_args):
1774
1775 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
1776
1777         prepare-ChangeLog: Look for a text editor in a few more variables.
1778         https://bugs.webkit.org/show_bug.cgi?id=76289
1779
1780         Reviewed by Ryosuke Niwa.
1781
1782         A text editor was looked for only in the CHANGE_LOG_EDITOR and
1783         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
1784         to the OS X-specific open(1) command.
1785
1786         As there does not seem to be a common way of looking for a text editor
1787         among the scripts in Tools/Scripts right now, just look at $VISUAL and
1788         $EDITOR (set much more often than the other variables in Unix systems)
1789         before falling back to open(1).
1790
1791         * Scripts/prepare-ChangeLog:
1792         (openChangeLogs):
1793
1794 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
1795
1796         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
1797         https://bugs.webkit.org/show_bug.cgi?id=76269
1798
1799         Reviewed by Martin Robinson.
1800
1801         * gtk/gtkdoc.py:
1802         (GTKDoc._run_gtkdoc_scangobj):
1803
1804 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1805
1806         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
1807         https://bugs.webkit.org/show_bug.cgi?id=76247
1808
1809         Reviewed by Kenneth Rohde Christiansen.
1810
1811         * WebKitTestRunner/TestController.cpp:
1812         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
1813
1814 2012-01-13  Hajime Morrita  <morrita@chromium.org>
1815
1816         [Mac][DRT] Should support --no-timeout
1817         https://bugs.webkit.org/show_bug.cgi?id=76242
1818
1819         Reviewed by Darin Adler.
1820
1821         * DumpRenderTree/mac/DumpRenderTree.mm:
1822         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
1823         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
1824         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
1825         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1826         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1827         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
1828
1829 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
1830
1831         Mitigate scrollbar differences when running pixel tests
1832         https://bugs.webkit.org/show_bug.cgi?id=67217
1833
1834         Reviewed by Dan Bernstein.
1835         
1836         Enable mock scrollbars by default for tests.
1837
1838         * DumpRenderTree/mac/DumpRenderTree.mm:
1839         (resetDefaultsToConsistentValues):
1840         * WebKitTestRunner/TestController.cpp:
1841         (WTR::TestController::resetStateToConsistentValues):
1842
1843 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
1844
1845         Need a script to run tests in PerformanceTests
1846         https://bugs.webkit.org/show_bug.cgi?id=76132
1847
1848         Reviewed by Adam Barth.
1849
1850         Add run-perf-tests to run performance tests using parser/resources/runner.js.
1851         Unfortunately, there isn't an easy way of telling which test uses which format
1852         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
1853
1854         All test outputs are re-formatted to match Chromium perf-bot style.
1855
1856         * Scripts/run-inspector-perf-tests.py:
1857         * Scripts/run-perf-tests: Added.
1858         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1859         (PerfTestsRunner):
1860         (PerfTestsRunner.__init__):
1861         (PerfTestsRunner._collect_tests):
1862         (PerfTestsRunner.run):
1863         (PerfTestsRunner._print_status):
1864         (PerfTestsRunner._run_tests_set):
1865         (PerfTestsRunner._process_chromium_style_test_result):
1866         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
1867         (PerfTestsRunner._process_parser_test_result):
1868         (PerfTestsRunner._run_single_test):
1869         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1870         (MainTest.TestDriver.run_test):
1871         (create_runner):
1872         (run_test):
1873         (test_run_test_set):
1874         (test_run_test_set_for_parser_tests):
1875         (test_collect_tests):
1876
1877 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1878
1879         webkitpy: clean up port unit tests in preparation for making port_name mandatory
1880         https://bugs.webkit.org/show_bug.cgi?id=76123
1881
1882         Reviewed by Adam Barth.
1883
1884         This change updates the unit tests to be more consistent in how
1885         ports are created, in preparation for making port_name a
1886         mandatory parameter to the constructor and removing any version
1887         interpretation from it.
1888
1889         There should be no functional changes in this patch, but some
1890         tests that are no longer relevant have been removed or reworked.
1891
1892         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1893         (PortTest.test_get_option__default):
1894         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1895         (ChromiumLinuxPortTest):
1896         (ChromiumLinuxPortTest.assert_architecture):
1897         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1898         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1899         (ChromiumMacPortTest):
1900         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1901         (ChromiumPortTest):
1902         (ChromiumPortTest.test_all_test_configurations):
1903         (ChromiumPortTest.TestMacPort.__init__):
1904         (ChromiumPortTest.TestLinuxPort.__init__):
1905         (ChromiumPortTest.TestWinPort.__init__):
1906         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1907         (ChromiumWinTest):
1908         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1909         (EflPortTest):
1910         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1911         (GtkPortTest):
1912         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1913         (MacTest):
1914         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1915         (MockDRTPortTest):
1916         (MockDRTPortTest.make_port):
1917         * Scripts/webkitpy/layout_tests/port/qt.py:
1918         (QtPort._port_flag_for_scripts):
1919         (QtPort.__init__):
1920         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1921         (QtPortTest):
1922         (QtPortTest._assert_search_path):
1923         (QtPortTest.test_baseline_search_path):
1924         (QtPortTest.test_operating_system):
1925         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1926         (WebKitPortTest):
1927         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1928         (WinPortTest):
1929         (WinPortTest._assert_search_path):
1930         (WinPortTest.test_baseline_search_path):
1931         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1932         (get_test_config.TestMacPort.__init__):
1933
1934 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1935
1936         test-webkitpy: clean up logging and provide a real --help message
1937         https://bugs.webkit.org/show_bug.cgi?id=76142
1938
1939         Reviewed by Adam Barth.
1940
1941         This test is mostly more refactoring - it calls objects in
1942         unittest directly instead of routing through unittest.main() --
1943         in order to gain more control over the logging and to provide a
1944         correct --help message. This will also give us a better
1945         foundation for adding more feautures down the road.
1946
1947         This patch adds different levels of logging controlled by the
1948         '-s', '-q', and '-v' options (see --help for details), and
1949         removes the --verbose-logging option.
1950
1951         * Scripts/test-webkitpy:
1952         * Scripts/webkitpy/test/main.py:
1953         (Tester):
1954         (Tester.clean_packages):
1955         (Tester.__init__):
1956         (Tester.parse_args):
1957         (Tester.configure):
1958         (Tester._configure_logging):
1959         (Tester.find_modules):
1960         (Tester._exclude):
1961         (Tester._modules_from_paths):
1962         (Tester.run_tests):
1963
1964 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
1965
1966         Make the new WTF module build on Qt
1967         https://bugs.webkit.org/show_bug.cgi?id=76163
1968
1969         Reviewed by Tor Arne Vestbø.
1970
1971         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
1972
1973 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1974
1975         Unreviewed, mac DumpRenderTree fix.
1976
1977         * DumpRenderTree/mac/UIDelegate.mm:
1978         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1979
1980 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1981
1982         WebKitTestRunner should not print console message line number when it is equal to zero.
1983         https://bugs.webkit.org/show_bug.cgi?id=76167
1984
1985         Reviewed by Csaba Osztrogonác.
1986
1987         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1988         (WTR::InjectedBundlePage::willAddMessageToConsole):
1989
1990 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
1991
1992         Make default console messages line numbers consistent.
1993         https://bugs.webkit.org/show_bug.cgi?id=74075
1994
1995         Reviewed by Pavel Feldman.
1996
1997         Unset line numbers are not printed to console now.
1998         Added Source/WebCore/inspector to efl DumpRenderTree include path.
1999
2000         * DumpRenderTree/chromium/WebViewHost.cpp:
2001         (WebViewHost::didAddMessageToConsole):
2002         * DumpRenderTree/efl/CMakeLists.txt:
2003         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2004         (onConsoleMessage):
2005         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2006         (webViewConsoleMessage):
2007         * DumpRenderTree/mac/UIDelegate.mm:
2008         (-[UIDelegate webView:addMessageToConsole:withSource:]):
2009         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2010         (WebCore::WebPage::javaScriptConsoleMessage):
2011         * DumpRenderTree/win/UIDelegate.cpp:
2012         (UIDelegate::webViewAddMessageToConsole):
2013         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2014         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
2015
2016 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
2017
2018         test-webkitpy: push more logic into webkitpy.test.main, clean up code
2019         https://bugs.webkit.org/show_bug.cgi?id=76021
2020
2021         Reviewed by Eric Seidel.
2022
2023         I plan to add more functionality to test-webkitpy, but it is
2024         difficult to hack on now; this patch is the first of two that
2025         brings test-webkitpy more inline with current coding style by
2026         pushing more logic into the webkitpy.test.main.Tester class (so
2027         that it will be testable itself).
2028         
2029         There should be no functional changes in this patch.
2030
2031         * Scripts/test-webkitpy:
2032         (_path_from_webkit_root):
2033         * Scripts/webkitpy/test/main.py:
2034         (Tester):
2035         (Tester.init):
2036         (Tester.configure_logging):
2037         (Tester.configure_logging.filter):
2038         (Tester.clean_packages):
2039         (Tester.run_tests):
2040
2041 2012-01-11  Wei Jia  <wjia@chromium.org>
2042
2043         implement layout tests for <video> with media stream
2044         https://bugs.webkit.org/show_bug.cgi?id=74882
2045
2046         Reviewed by Kent Tamura.
2047
2048         * DumpRenderTree/DumpRenderTree.gypi:
2049         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
2050         (WebKit::WebUserMediaClientMock::create):
2051         (WebKit::WebUserMediaClientMock::IsMockStream):
2052         (WebKit::WebUserMediaClientMock::requestUserMedia):
2053         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
2054         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
2055         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
2056         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
2057         * DumpRenderTree/chromium/WebViewHost.cpp:
2058         (WebViewHost::userMediaClient):
2059         (WebViewHost::userMediaClientMock):
2060         (WebViewHost::createMediaPlayer):
2061         (WebViewHost::mediaStreamUtil):
2062         (WebViewHost::testMediaStreamClient):
2063         * DumpRenderTree/chromium/WebViewHost.h:
2064
2065 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
2066
2067         Unreviewed, build fix.
2068
2069         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
2070
2071         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2072         (ChromiumWinPort.__init__):
2073
2074 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2075
2076         Sheriffbot build fix. Don't emit empty lines on IRC.
2077
2078         * Scripts/webkitpy/tool/bot/irc_command.py:
2079         (LastGreenRevision.execute):
2080
2081 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2082
2083         last-green-revision should report the revision that succeeded on all bots
2084         https://bugs.webkit.org/show_bug.cgi?id=76109
2085
2086         Reviewed by Adam Barth.
2087
2088         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
2089         considered green by this algorithm, all matching builders must have a successful run at the revision
2090         or two consecutive successful runs before and after the revision.
2091
2092         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
2093         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
2094
2095         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2096         (BuildBot._revisions_for_builder):
2097         (BuildBot):
2098         (BuildBot._find_green_revision):
2099         (BuildBot.last_green_revision):
2100         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2101         (MockBuildBot.last_green_revision):
2102         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2103         (test_revisions_for_builder):
2104         (test_find_green_revision):
2105         (test_last_green_revision):
2106         * Scripts/webkitpy/tool/bot/irc_command.py:
2107         (LastGreenRevision.execute):
2108         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2109         (SheriffIRCBotTest.test_lgr):
2110         * Scripts/webkitpy/tool/commands/queries.py:
2111         (LastGreenRevision):
2112
2113 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
2114
2115         Unreviewed, fix build bustage on win32 introduced by r104725.
2116
2117         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2118         (MockDRTPortTest.make_port):
2119         (MockChromiumDRTTest.test_pixeltest__fails):
2120
2121 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
2122
2123         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
2124         https://bugs.webkit.org/show_bug.cgi?id=75618
2125
2126         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
2127
2128         Reviewed by Tony Chang.
2129
2130         * DumpRenderTree/chromium/LayoutTestHelper.mm:
2131         (installLayoutTestColorProfile):
2132         (restoreUserColorProfile):
2133         (main):
2134
2135 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
2136
2137         test-webkitpy: fix -v and eliminate some spurious warnings
2138         https://bugs.webkit.org/show_bug.cgi?id=76099
2139
2140         Reviewed by Adam Barth.
2141
2142         when we added support for --xml output, we broke the -v flag.
2143
2144         Also, fix the code to swallow a harmless warning from
2145         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
2146
2147         test-webkitpy is now silent again except for the one known
2148         logging issue.
2149
2150         * Scripts/webkitpy/common/checkout/checkout.py:
2151         (Checkout.commit_message_for_this_commit):
2152         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2153         (test_commit_message_for_this_commit):
2154         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2155         (JSONChecker.check):
2156         (JSONChecker.line_number_from_json_exception):
2157         * Scripts/webkitpy/test/main.py:
2158         (Tester.run_tests):
2159
2160 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
2161
2162         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
2163         https://bugs.webkit.org/show_bug.cgi?id=76084
2164
2165         Reviewed by Adam Barth.
2166
2167         This will help make it easier to catch layering violations. This
2168         change just refactors test code; there are no changes to
2169         production code.
2170
2171         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2172         (PortTest.make_port):
2173         (PortTest.test_find_no_paths_specified):
2174         (PortTest.test_find_one_test):
2175         (PortTest.test_find_glob):
2176         (PortTest.test_find_with_skipped_directories):
2177         (PortTest.test_find_with_skipped_directories_2):
2178         (PortTest.test_parse_reftest_list):
2179         (PortTest.test_httpd_returns_error_code):
2180         (PortTest.test_virtual_methods):
2181         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2182         (ChromiumGpuTest.assert_port_works):
2183         (ChromiumGpuTest._assert_baseline_path):
2184         (ChromiumGpuTest.test_graphics_type):
2185         (ChromiumGpuTest.test_default_tests_paths.test_paths):
2186         (ChromiumGpuTest.test_test_files):
2187         (ChromiumGpuTest.test_test_files.test_paths):
2188         (ChromiumGpuTest):
2189         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2190         (ChromiumLinuxPortTest.assert_architecture):
2191         (ChromiumLinuxPortTest.test_check_illegal_port_names):
2192         (ChromiumLinuxPortTest.test_determine_architecture_fails):
2193         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
2194         (DriverTest.make_port):
2195         (DriverTest):
2196         (DriverTest.assertVirtual):
2197         (DriverTest._assert_wrapper):
2198         (DriverTest.test_virtual_driver_methods):
2199         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2200         (MockDRTPortTest.make_port):
2201         (MockDRTPortTest.test_port_name_in_constructor):
2202         (MockDRTTest.assertTest):
2203         (MockDRTTest.test_main):
2204         (MockChromiumDRTTest.test_pixeltest__fails):
2205         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2206         (QtPortTest._assert_search_path):
2207         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2208         (TestWebKitPort.__init__):
2209         (WebKitPortUnitTests.test_default_options):
2210         (test_runtime_feature_list):
2211         (test_test_expectations):
2212
2213 2012-01-11  Ojan Vafai  <ojan@chromium.org>
2214
2215         Style skipped tests in the flakiness dashboard
2216         https://bugs.webkit.org/show_bug.cgi?id=76091
2217
2218         Reviewed by Tony Chang.
2219
2220         * TestResultServer/static-dashboards/dashboard_base.js:
2221         Removed "FLAKY" from this list since we don't ever mark individual runs
2222         as flaky. Also deleted an outdated line.
2223         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2224
2225 2012-01-11  Ojan Vafai  <ojan@chromium.org>
2226
2227         Remove gtest normalization code from the test results server
2228         https://bugs.webkit.org/show_bug.cgi?id=76089
2229
2230         Reviewed by Tony Chang.
2231
2232         The normalization now happens on the gtest side.
2233
2234         * TestResultServer/model/jsonresults.py:
2235         (JsonResults.merge):
2236         * TestResultServer/model/jsonresults_unittest.py:
2237         (JsonResultsTest.test_gtest):
2238
2239 2012-01-11  Ojan Vafai  <ojan@chromium.org>
2240
2241         Be more aggressive about deleting unnecessary results from the test-results-server json files
2242         https://bugs.webkit.org/show_bug.cgi?id=76086
2243
2244         Reviewed by Tony Chang.
2245
2246         Remove any tests that only contain skip/pass/nodata values whose runtime
2247         is less than 5 seconds.
2248
2249         * TestResultServer/model/jsonresults.py:
2250         (JsonResults._normalize_results_json):
2251         * TestResultServer/model/jsonresults_unittest.py:
2252         (JsonResultsTest.test_merge_remove_test):
2253         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
2254
2255 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2256
2257         last-green-revision should give us per-bot information
2258         https://bugs.webkit.org/show_bug.cgi?id=76011
2259
2260         Reviewed by Adam Barth.
2261
2262         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
2263         we report the latest green run on each bot from the last 100 runs.
2264
2265         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2266         (BuildBot._fetch_builder_page):
2267         (BuildBot):
2268         (BuildBot._green_revision_for_builder):
2269         (BuildBot.last_green_revision):
2270         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2271         (test_green_revision_for_builder):
2272         (test_last_green_revision):
2273         * Scripts/webkitpy/tool/bot/irc_command.py:
2274         (LastGreenRevision.execute):
2275         * Scripts/webkitpy/tool/commands/queries.py:
2276         (LastGreenRevision.execute):
2277
2278 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
2279
2280         webkitpy: clean up version detection in webkitpy.layout_tests.port
2281         https://bugs.webkit.org/show_bug.cgi?id=76016
2282
2283         Reviewed by Adam Barth.
2284
2285         This change updates the code in webkitpy.layout_tests.port to
2286         use the new os_name and os_version fields on host.platform. This
2287         gets layout_tests.port out of the version parsing business. Most
2288         of the diffs are just cleaning up test code to accomodate the
2289         changes.
2290
2291         * Scripts/webkitpy/common/system/executive_mock.py:
2292         (MockExecutive):
2293         (MockExecutive.ignore_error):
2294         (MockExecutive2):
2295         (MockExecutive2.ignore_error):
2296         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2297         (MockPlatformInfo.is_mac):
2298         (MockPlatformInfo.is_linux):
2299         (MockPlatformInfo.is_win):
2300         * Scripts/webkitpy/common/system/systemhost_mock.py:
2301         (MockSystemHost.__init__):
2302         * Scripts/webkitpy/layout_tests/port/apple.py:
2303         (ApplePort.__init__):
2304         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2305         (ChromiumMacPort.__init__):
2306         (ChromiumMacPort.check_wdiff):
2307         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2308         (ChromiumMacPortTest):
2309         (ChromiumMacPortTest.assert_name):
2310         (ChromiumMacPortTest.test_versions):
2311         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2312         (ChromiumPortTest.test_all_test_configurations):
2313         (ChromiumPortTest.TestMacPort.__init__):
2314         (ChromiumPortTest.TestLinuxPort.__init__):
2315         (ChromiumPortTest.TestWinPort.__init__):
2316         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2317         (ChromiumWinPort.__init__):
2318         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2319         (ChromiumWinTest):
2320         (ChromiumWinTest.assert_name):
2321         (ChromiumWinTest.test_versions):
2322         (ChromiumWinTest.test_baseline_path):
2323         (ChromiumWinTest.test_build_path):
2324         * Scripts/webkitpy/layout_tests/port/factory.py:
2325         (PortFactory._port_name_from_arguments_and_options):
2326         (PortFactory.get):
2327         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2328         (FactoryTest):
2329         (FactoryTest.setUp):
2330         (FactoryTest.assert_port):
2331         (FactoryTest.test_mac):
2332         (FactoryTest.test_win):
2333         (FactoryTest.test_google_chrome):
2334         (FactoryTest.test_gtk):
2335         (FactoryTest.test_qt):
2336         (FactoryTest.test_chromium_gpu):
2337         (FactoryTest.test_chromium_gpu_linux):
2338         (FactoryTest.test_chromium_gpu_mac):
2339         (FactoryTest.test_chromium_gpu_win):
2340         (FactoryTest.test_chromium_mac):
2341         (FactoryTest.test_chromium_linux):
2342         (FactoryTest.test_chromium_win):
2343         (FactoryTest.test_unknown_specified):
2344         (FactoryTest.test_unknown_default):
2345         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2346         (TestGoogleChromePort):
2347         (TestGoogleChromePort._verify_baseline_path):
2348         (TestGoogleChromePort._verify_expectations_overrides):
2349         (TestGoogleChromePort.test_get_google_chrome_port):
2350         * Scripts/webkitpy/layout_tests/port/mac.py:
2351         (MacPort):
2352         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2353         (MacTest):
2354         (assert_name):
2355         (test_tests_for_other_platforms):
2356         (test_version):
2357         (test_versions):
2358         (test_is_version_methods):
2359         (test_setup_environ_for_server):
2360         (_assert_search_path):
2361         (test_show_results_html_file):
2362         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2363         (PortTestCase):
2364         (PortTestCase.make_port):
2365         * Scripts/webkitpy/layout_tests/port/win.py:
2366         (WinPort):
2367         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2368         (WinPortTest):
2369         (WinPortTest.test_show_results_html_file):
2370         (WinPortTest._assert_search_path):
2371         (WinPortTest._assert_version):
2372
2373 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
2374
2375         [Qt][WK2] Remove workaround introduced into bug 75470
2376         https://bugs.webkit.org/show_bug.cgi?id=75889
2377
2378         Reviewed by Tor Arne Vestbø.
2379
2380         * MiniBrowser/qt/qml/BrowserWindow.qml:
2381
2382 2012-01-10  Dmitry Lomov  <dslomov@google.com>
2383
2384         [Chromium] Remove obsolete references to WebWorker class.
2385         https://bugs.webkit.org/show_bug.cgi?id=76020
2386
2387         Reviewed by David Levin.
2388
2389         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
2390         * DumpRenderTree/chromium/WebViewHost.cpp:
2391         * DumpRenderTree/chromium/WebViewHost.h:
2392
2393 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
2394
2395         [Qt] Some css3 filter tests are failing after r104698
2396         https://bugs.webkit.org/show_bug.cgi?id=76055
2397
2398         Reviewed by Simon Hausmann.
2399
2400         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2401         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
2402
2403 2012-01-11  Tony Chang  <tony@chromium.org>
2404
2405         Don't remove 0 byte files when running build-webkit --chromium
2406         https://bugs.webkit.org/show_bug.cgi?id=75997
2407
2408         Reviewed by Csaba Osztrogonác.
2409
2410         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
2411
2412         * Scripts/webkitdirs.pm:
2413         (determineIsQt):
2414
2415 2012-01-10  David Kilzer  <ddkilzer@apple.com>
2416
2417         Add TestWebKitAPI tests for KURL
2418         <http://webkit.org/b/75774>
2419
2420         Reviewed by Adam Barth.
2421
2422         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
2423         WebCore folder and KURL.cpp source file to the project.
2424         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
2425         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
2426         during setup since this test doesn't go through WebKit or
2427         WebKit2.
2428         (TestWebKitAPI::TEST_F): Add two basic tests.
2429
2430 2012-01-10  David Kilzer  <ddkilzer@apple.com>
2431
2432         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
2433
2434         Reviewed by Adam Barth.
2435
2436         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
2437
2438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
2439         WTFStringUtilities.h to the project.
2440         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
2441         WTFStringUtilities.h.
2442         * TestWebKitAPI/WTFStringUtilities.h: Added.
2443         (WTF::operator<<):
2444
2445 2012-01-10  Vincent Scheib  <scheib@chromium.org>
2446
2447         Clarify run-webkit-tests options reset-results and new-baseline
2448         https://bugs.webkit.org/show_bug.cgi?id=75993
2449
2450         Reviewed by Dirk Pranke.
2451
2452         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2453         (parse_args):
2454
2455 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
2456
2457         Disabled mock scrollbars should draw differently
2458         https://bugs.webkit.org/show_bug.cgi?id=75995
2459
2460         Reviewed by James Robinson.
2461
2462         When the scrollbar is disabled, paint the entire track of
2463         mock scrollbars with a lighter gray, and hide the thumb.
2464
2465         * DumpRenderTree/mac/DumpRenderTree.mm:
2466         (-[DRTMockScroller drawKnob]):
2467         (-[DRTMockScroller drawRect:]):
2468
2469 2012-01-10  James Robinson  <jamesr@chromium.org>
2470
2471         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
2472         https://bugs.webkit.org/show_bug.cgi?id=75988
2473
2474         Reviewed by Adam Barth.
2475
2476         * Scripts/webkitpy/common/config/ports.py:
2477         (WebKitPort.run_webkit_unit_tests_command):
2478         (WebKitPort):
2479         (ChromiumPort.run_webkit_unit_tests_command):
2480         (ChromiumPort):
2481         * Scripts/webkitpy/common/config/ports_mock.py:
2482         (MockPort.run_webkit_unit_tests_command):
2483         * Scripts/webkitpy/tool/commands/download_unittest.py:
2484         (DownloadCommandsTest.test_build_and_test):
2485         (test_land):
2486         (test_land_red_builders):
2487         * Scripts/webkitpy/tool/steps/runtests.py:
2488         (RunTests.run):
2489         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2490
2491 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2492
2493         webkitpy: add os_name, os_version to platforminfo
2494         https://bugs.webkit.org/show_bug.cgi?id=75931
2495
2496         Reviewed by Eric Siedel.
2497
2498         As a first step in cleaning up the version parsing logic in
2499         webkitpy.layout_tests.port, this adds common routines for
2500         getting the os_name and os_version fields to the PlatformInfo
2501         class. Nothing uses them yet but I've added FIXME's to some of
2502         the code that needs to be deleted in the port files.
2503
2504         * Scripts/webkitpy/common/system/platforminfo.py:
2505         (PlatformInfo.__init__):
2506         (PlatformInfo):
2507         (PlatformInfo._determine_os_name):
2508         (PlatformInfo._determine_mac_version):
2509         (PlatformInfo._determine_linux_version):
2510         (PlatformInfo._determine_win_version):
2511         (PlatformInfo.display_name):
2512         (PlatformInfo.total_bytes_memory):
2513         (PlatformInfo._compute_bytes_from_vm_stat_output):
2514         (PlatformInfo.free_bytes_memory):
2515         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
2516         (TestPlatformInfo):
2517         (TestPlatformInfo.make_info):
2518         (TestPlatformInfo.make_info.mock_run_command):
2519         (TestPlatformInfo.setUp):
2520         (TestPlatformInfo.tearDown):
2521         (TestPlatformInfo.test_basic):
2522         (TestPlatformInfo.integration_test_basic):
2523         (TestPlatformInfo.test_display_name_mac):
2524         (TestPlatformInfo.test_display_name_win32):
2525         (TestPlatformInfo.test_memory_mac):
2526         (TestPlatformInfo.test_memory_win32):
2527         (TestPlatformInfo.test_determine_os_name):
2528         (TestPlatformInfo.test_determine_mac_version):
2529         (TestPlatformInfo.test_determine_linux_version):
2530         (TestPlatformInfo.test_determine_win_version_from_tuple):
2531         (TestPlatformInfo.test_determine_win_version_from_cmd):
2532         * Scripts/webkitpy/layout_tests/port/apple.py:
2533         (ApplePort.__init__):
2534         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2535         (ChromiumMacPort.__init__):
2536         * Scripts/webkitpy/layout_tests/port/mac.py:
2537         (MacPort):
2538         * Scripts/webkitpy/layout_tests/port/win.py:
2539         (WinPort):
2540
2541 2012-01-10  Adam Roben  <aroben@apple.com>
2542
2543         Make it possible to type data: URLs into MiniBrowser on Windows
2544
2545         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
2546         MiniBrowser on Windows
2547
2548         Reviewed by Darin Adler.
2549
2550         * MiniBrowser/win/BrowserWindow.cpp:
2551         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
2552         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
2553         does, we assume it already has a scheme and don't modify it.
2554
2555 2012-01-10  Adam Roben  <aroben@apple.com>
2556
2557         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
2558
2559         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
2560         MiniBrowser on Windows
2561
2562         Reviewed by Darin Adler.
2563
2564         * MiniBrowser/win/BrowserView.cpp:
2565         (BrowserView::goToURL): Pass the typed string through
2566         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
2567
2568 2012-01-10  Ben Wells  <benwells@chromium.org>
2569
2570         Adding myself (benwells) to committers.py
2571         https://bugs.webkit.org/show_bug.cgi?id=75971
2572
2573         Reviewed by Ojan Vafai.
2574
2575         * Scripts/webkitpy/common/config/committers.py:
2576
2577 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
2578
2579         AX: support helpText() in DumpRenderTree
2580         https://bugs.webkit.org/show_bug.cgi?id=40193
2581
2582         Reviewed by Chris Fleizach.
2583
2584         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2585         (AccessibilityUIElement::helpText): Implemented.
2586
2587 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2588
2589         Unreviewed, rolling out r104572.
2590         http://trac.webkit.org/changeset/104572
2591         https://bugs.webkit.org/show_bug.cgi?id=75967
2592
2593         It broke zillion tests (Requested by Ossy on #webkit).
2594
2595         * DumpRenderTree/qt/EventSenderQt.cpp:
2596         (EventSender::EventSender):
2597         (EventSender::sendOrQueueEvent):
2598         (EventSender::replaySavedEvents):
2599         (EventSender::eventFilter):
2600         * DumpRenderTree/qt/EventSenderQt.h:
2601
2602 2012-01-10  Hugo Parente Lima  <hugo.lima@openbossa.org>
2603
2604         [Qt] fast/events/dont-loose-last-event test fails on WK1
2605         https://bugs.webkit.org/show_bug.cgi?id=73894
2606
2607         Reviewed by Simon Hausmann.
2608
2609         Empty the entire event queue when requested besides using
2610         sendEvent instead of postEvent to make sure all events were
2611         delivered.
2612         This commit also removes not working DRT code to handle drag and drop,
2613         for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
2614
2615         * DumpRenderTree/qt/EventSenderQt.cpp:
2616         (EventSender::EventSender):
2617         (EventSender::sendOrQueueEvent):
2618         (EventSender::replaySavedEvents):
2619         * DumpRenderTree/qt/EventSenderQt.h:
2620
2621 2012-01-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
2622
2623         [Qt] Enable CSS_FILTERS in Qt build
2624         https://bugs.webkit.org/show_bug.cgi?id=75777
2625
2626         Add the CSS_FILTERS feature flag to Qt.
2627
2628         Reviewed by Kenneth Rohde Christiansen.
2629
2630         * qmake/mkspecs/features/features.prf:
2631
2632 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2633
2634         [Qt] Unreviewed -Werror build fix.
2635
2636         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2637         (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
2638         declaration.
2639
2640 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2641
2642         [Qt] Remove dependency to uitools
2643         https://bugs.webkit.org/show_bug.cgi?id=75952
2644
2645         Reviewed by Tor Arne Vestbø.
2646
2647         QUiLoader is used for creating QLabel/QProgressBar widgets for
2648         a layout test, to verify some widget embedding feature. Unfortunately
2649         in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
2650         depends on qttools. Since we don't really _need_ QUiLoader for our tests,
2651         let's break the circular dependency.
2652
2653         * DumpRenderTree/qt/DumpRenderTree.pro:
2654         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2655         (WebCore::WebPage::createPlugin):
2656         * QtTestBrowser/QtTestBrowser.pro:
2657         * QtTestBrowser/launcherwindow.h:
2658         * QtTestBrowser/webpage.cpp:
2659         (WebPage::createPlugin):
2660         * qmake/mkspecs/features/minimal_qt.prf:
2661         * qmake/mkspecs/features/uitools.prf: Removed.
2662
2663 2012-01-10  Alexander Færøy  <alexander.faeroy@nokia.com>
2664
2665         [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
2666         https://bugs.webkit.org/show_bug.cgi?id=75894
2667
2668         Reviewed by Tor Arne Vestbø.
2669
2670         * MiniBrowser/qt/MiniBrowserApplication.h:
2671         (MiniBrowserApplication::windowOptions):
2672         * MiniBrowser/qt/main.cpp:
2673         (main):
2674
2675 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2676
2677         [Qt] DRT crashes with Qt 5
2678         https://bugs.webkit.org/show_bug.cgi?id=75951
2679
2680         Reviewed by Ossy.
2681
2682         * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
2683         Qt relies on font-config to define the default font family.
2684
2685 2012-01-10  Csaba Osztrogonác  <ossy@webkit.org>
2686
2687         [Qt] REGRESSION(r100130): Clean build feature is broken.
2688         https://bugs.webkit.org/show_bug.cgi?id=75863
2689
2690         Reviewed by Tor Arne Vestbø.
2691
2692         * Scripts/webkitdirs.pm:
2693         (buildQMakeProject):
2694
2695 2012-01-10  Zeno Albisser  <zeno@webkit.org>
2696
2697         [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
2698         https://bugs.webkit.org/show_bug.cgi?id=75885
2699
2700         In QML events are propagated through parents. But since the
2701         WebView may consume key events, a shortcut might never reach
2702         the top QtQuickItem.
2703         Therefore an application wide event handling function in C++
2704         needs to take care of shortcuts for MiniBrowser.
2705
2706         Reviewed by Kenneth Rohde Christiansen.
2707
2708         * MiniBrowser/qt/BrowserWindow.cpp:
2709         (BrowserWindow::reload):
2710         (BrowserWindow::focusAddressBar):
2711         * MiniBrowser/qt/BrowserWindow.h:
2712         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2713         (MiniBrowserApplication::notify):
2714         * MiniBrowser/qt/qml/BrowserWindow.qml:
2715
2716 2012-01-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2717
2718         Add --efl alias for --platform=efl to run-webkit-test
2719         https://bugs.webkit.org/show_bug.cgi?id=75937
2720
2721         Reviewed by Andreas Kling.
2722         
2723         * Scripts/run-webkit-tests: Add --efl alias.
2724         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
2725         (parse_args):
2726
2727 2012-01-09  Dan Bernstein  <mitz@apple.com>
2728
2729         -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
2730         https://bugs.webkit.org/show_bug.cgi?id=75920
2731
2732         Reviewed by Darin Adler.
2733
2734         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
2735         (TestWebKitAPI::TEST): Added a test for a range in a
2736         -webkit-user-select: none; block.
2737
2738 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2739
2740         webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
2741         https://bugs.webkit.org/show_bug.cgi?id=75884
2742
2743         Reviewed by Ryosuke Niwa.
2744
2745         Fix regression introduced (revealed?) in r104340. Chromium file         
2746         url syntax is different on win32 and the test results weren't           
2747         expecting that.                                                         
2748
2749         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2750         (TestExpectations._report_errors):
2751         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2752         (test_parse_error_nonfatal):
2753         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2754         (MockDRTTest.input_line):
2755         (MockChromiumDRTTest.test_pixeltest__fails):
2756         * Scripts/webkitpy/layout_tests/port/test.py:
2757         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2758         (TestRebaseliner.make_rebaseliner):
2759         (TestRebaseliner.test_one_platform):
2760         (TestRebaseliner.test_all_platforms):
2761         (TestRebaseliner.test_png_file_with_comment):
2762         (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
2763         (TestRebaseliner.test_png_file_with_comment_as_duplicate):
2764         (TestRealMain.test_all_platforms):
2765
2766 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2767
2768         Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
2769
2770         Unreviewed, build fix.
2771
2772         test-webkitpy had a built-in self-test routine to verify that
2773         deleting the .pyc files worked correctly. When I removed the
2774         python24 directory in r104482, I broke the self-test.
2775
2776         I have deleted the self-test for now. Since I am reworking
2777         test-webkitpy I will make sure the new version is adequately
2778         tested.
2779
2780         * Scripts/test-webkitpy:
2781         (configure_logging):
2782         (_clean_pyc_files):
2783         (_clean_packages):
2784         (init):
2785
2786 2012-01-09  Justin Novosad  <junov@chromium.org>
2787
2788         [Chromium] remove all references to the legacy accelerated 2d Canvas
2789         implementation
2790         https://bugs.webkit.org/show_bug.cgi?id=75108
2791
2792         Purging an old settings flag that is no longer referenced
2793
2794         Reviewed by Darin Fisher.
2795
2796         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2797         (main):
2798         * DumpRenderTree/chromium/TestShell.cpp:
2799         (TestShell::TestShell):
2800         (TestShell::resetWebSettings):
2801         * DumpRenderTree/chromium/TestShell.h:
2802         (TestShell::setAccelerated2dCanvasEnabled):
2803         * DumpRenderTree/chromium/WebPreferences.cpp:
2804         (WebPreferences::reset):
2805         (WebPreferences::applyTo):
2806         * DumpRenderTree/chromium/WebPreferences.h:
2807
2808 2012-01-09  Adam Roben  <aroben@apple.com>
2809
2810         Convert Cygwin paths to Windows paths before passing them to DRT
2811
2812         Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
2813         NRWT
2814
2815         I couldn't find a way to test this because I couldn't figure out how to override the
2816         cygpath function as it is used by WebKitDriver.
2817
2818         Reviewed by Dirk Pranke.
2819
2820         * Scripts/webkitpy/layout_tests/port/webkit.py:
2821         (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
2822         Windows-style path before passing it to DRT.
2823
2824 2012-01-06  Dirk Pranke  <dpranke@chromium.org>
2825
2826         webkitpy: revamp version checking
2827         https://bugs.webkit.org/show_bug.cgi?id=75765
2828
2829         Reviewed by Adam Barth.
2830
2831         The version-checking code in webkitpy/python24/versioning seems really
2832         awkward and overdesigned, especially since we don't support python 2.4
2833         any more.
2834
2835         In addition, I am tired of getting warnings about Python 2.6 being "a
2836         newer release than what is supported" :).
2837
2838         I'm taking a page from the depot_tools python code and just creating a
2839         new webkitpy.common.version_check module that will print a message on
2840         stderr and call sys.exit() if we're running an unsupported version.
2841
2842         * Scripts/check-webkit-style:
2843         * Scripts/new-run-webkit-httpd:
2844         * Scripts/new-run-webkit-tests:
2845         * Scripts/rebaseline-chromium-webkit-tests:
2846         * Scripts/test-webkitpy:
2847         (configure_logging):
2848         (init):
2849         * Scripts/webkit-patch:
2850         (main):
2851         * Scripts/webkitpy/common/system/executive.py:
2852         (Executive._child_process_encoding):
2853         (Executive._should_encode_child_process_arguments):
2854         * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
2855         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2856         * Scripts/webkitpy/python24/__init__.py: Removed.
2857         * Scripts/webkitpy/python24/versioning.py: Removed.
2858         * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
2859
2860 2012-01-09  Adam Barth  <abarth@webkit.org>
2861
2862         Remove Chromium Mac CG from the flakiness dashboard
2863         https://bugs.webkit.org/show_bug.cgi?id=75873
2864
2865         Reviewed by Ojan Vafai.
2866
2867         This configuration no longer exists.
2868
2869         * TestResultServer/static-dashboards/builders.js:
2870         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2871         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2872         (testOverrideJustBuildType):
2873         (testPlatformAndBuildType):
2874
2875 2012-01-06  Adam Roben  <aroben@apple.com>
2876
2877         Print an error message when NRWT can't run Apache
2878
2879         Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
2880
2881         Reviewed by Dirk Pranke.
2882
2883         * Scripts/webkitpy/layout_tests/port/base.py:
2884         (Port.check_httpd): Print an error message when Apache returns an error code instead of
2885         failing silently.
2886
2887         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2888         (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
2889         run Apache.
2890         (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
2891         fails.
2892
2893 2012-01-09  Gabor Rapcsanyi  <rgabor@webkit.org>
2894
2895         [Gtk][ARM] Cross compiler buildbot is failing after r103040
2896         https://bugs.webkit.org/show_bug.cgi?id=75846
2897
2898         Reviewed by Philippe Normand.
2899
2900         * Scripts/webkitdirs.pm:
2901         (runAutogenForAutotoolsProjectIfNecessary):
2902
2903 2012-01-09  Alexander Færøy  <ahf@0x90.dk>
2904
2905         [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
2906         https://bugs.webkit.org/show_bug.cgi?id=75807
2907
2908         This patch adds a new icon to navigationbar of the Qt MiniBrowser
2909         which allows you to dynamically toggle whether touch mocking is
2910         enabled or disabled.
2911
2912         Reviewed by Tor Arne Vestbø.
2913
2914         * MiniBrowser/qt/MiniBrowser.qrc:
2915         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2916         (MiniBrowserApplication::notify):
2917         * MiniBrowser/qt/MiniBrowserApplication.h:
2918         (WindowOptions::WindowOptions):
2919         (WindowOptions::touchMockingEnabled):
2920         (WindowOptions::setTouchMockingEnabled):
2921         * MiniBrowser/qt/icons/touch.png: Added.
2922         * MiniBrowser/qt/qml/BrowserWindow.qml:
2923
2924 2012-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2925
2926         Unreviewed. Fix make distcheck issues.
2927
2928         * MiniBrowser/gtk/GNUmakefile.am:
2929
2930 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2931
2932         Unreviewed, rolling out r104421.
2933         http://trac.webkit.org/changeset/104421
2934         https://bugs.webkit.org/show_bug.cgi?id=75816
2935
2936         Need to rebaseline some tests on Linux (Requested by noamr on
2937         #webkit).
2938
2939         * qmake/mkspecs/features/features.prf:
2940
2941 2012-01-08  Adam Barth  <abarth@webkit.org>
2942
2943         Remove support for Chromium Mac CG from garden-o-matic
2944         https://bugs.webkit.org/show_bug.cgi?id=75814
2945
2946         Reviewed by Eric Seidel.
2947
2948         This configuration no longer exists.  This patch is mostly a matter of
2949         updating config.js and removing the examples from the unit tests.
2950
2951         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2952         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2953         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2954         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2955         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2956
2957 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2958
2959         [Qt] Enable CSS_FILTERS in Qt build
2960         https://bugs.webkit.org/show_bug.cgi?id=75777
2961
2962         Add the CSS_FILTERS feature flag to Qt.
2963
2964         Reviewed by Kenneth Rohde Christiansen.
2965
2966         * qmake/mkspecs/features/features.prf:
2967
2968 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2969
2970         Categorize bots by ports instead of core/non-core separation
2971         https://bugs.webkit.org/show_bug.cgi?id=75766
2972
2973         Reviewed by Eric Seidel.
2974
2975         Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
2976         (Chromium still comes before GTK and Qt).
2977
2978         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2979         (loadBuilderConfig):
2980         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2981
2982 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2983
2984         Remove the concept of core builders from webkitpy
2985         https://bugs.webkit.org/show_bug.cgi?id=75809
2986
2987         Reviewed by Ryosuke Niwa.
2988
2989         Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
2990         and remove the relevant code.
2991
2992         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2993         (BuildBot.__init__):
2994         (BuildBot._matches_regexps):
2995         (BuildBot._builder_statuses_with_names_matching_regexps):
2996         (BuildBot.builder_statuses):
2997         (BuildBot.failure_map):
2998         (BuildBot._latest_builds_from_builders):
2999         (BuildBot.last_green_revision):
3000         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3001         (MockBuildBot.builder_statuses):
3002         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3003         (test_status_parsing):
3004         (test_last_green_revision):
3005         (test_last_green_revision.mock_builds_from_builders):
3006
3007 2012-01-08  Adam Barth  <abarth@webkit.org>
3008
3009         Remove Chromium Mac CG concept from webkitpy
3010         https://bugs.webkit.org/show_bug.cgi?id=75810
3011
3012         Reviewed by Ryosuke Niwa.
3013
3014         This configuration no longer exists.  We can remove all the supporting
3015         code from webkitpy.
3016
3017         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3018         (BaselineOptimizerTest.test_move_baselines):
3019         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
3020         (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
3021         (BaselineOptimizerTest.test_common_directory_includes_root):
3022         (BaselineOptimizerTest.test_complex_shadowing):
3023         * Scripts/webkitpy/common/config/build.py:
3024         (_should_file_trigger_build):
3025         * Scripts/webkitpy/common/config/build_unittest.py:
3026         (ShouldBuildTest):
3027         * Scripts/webkitpy/layout_tests/port/builders.py:
3028         * Scripts/webkitpy/layout_tests/port/chromium.py:
3029         (ChromiumPort):
3030         (ChromiumPort._generate_all_test_configurations):
3031         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3032         (_default_tests_paths):
3033         (ChromiumGpuLinuxPort.tests):
3034         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3035         (ChromiumGpuTest.integration_test_chromium_gpu_mac):
3036         (ChromiumGpuTest.assert_port_works):
3037         (ChromiumGpuTest.test_baseline_paths):
3038         (ChromiumGpuTest.test_graphics_type):
3039         (ChromiumGpuTest.test_default_tests_paths):
3040         (ChromiumGpuTest.test_test_files):
3041         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3042         (ChromiumMacPort):
3043         (ChromiumMacPort.__init__):
3044         (ChromiumMacPort.baseline_search_path):
3045         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3046         (ChromiumMacPortTest.test_graphics_type):
3047         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3048         (ChromiumPortTest.test_all_test_configurations):
3049         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3050         * Scripts/webkitpy/layout_tests/port/factory.py:
3051         (PortFactory._port_name_from_arguments_and_options):
3052         (PortFactory.get):
3053         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3054         (FactoryTest.test_chromium_gpu_mac):
3055         (FactoryTest.test_chromium_mac):
3056         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3057         (GetGoogleChromePortTest._verify_expectations_overrides):
3058         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3059         (MockChromiumDRTTest.test_chromium_parse_options):
3060         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3061         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3062         (test_url_fetcher):
3063         (test_zip_factory):
3064         (test_archive):
3065         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3066         (TestRebaseline.test_rebaseline_expectations):
3067
3068 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
3069
3070         Categorize bots by ports instead of core/non-core separation
3071         https://bugs.webkit.org/show_bug.cgi?id=75766
3072
3073         Reviewed by Adam Barth.
3074
3075         Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
3076
3077         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3078         (loadBuilderConfig):
3079         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3080
3081 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3082
3083         Unreviewed, rolling out r104403.
3084         http://trac.webkit.org/changeset/104403
3085         https://bugs.webkit.org/show_bug.cgi?id=75803
3086
3087         It broke all tests on Qt5 (Requested by Ossy_weekend on
3088         #webkit).
3089
3090         * qmake/mkspecs/features/features.prf:
3091
3092 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
3093
3094         [Qt] Enable CSS_FILTERS in Qt build
3095         https://bugs.webkit.org/show_bug.cgi?id=75777
3096
3097         Add the CSS_FILTERS feature flag to Qt.
3098
3099         Reviewed by Kenneth Rohde Christiansen.
3100
3101         * qmake/mkspecs/features/features.prf:
3102
3103 2012-01-04  Kentaro Hara  <haraken@chromium.org>
3104
3105         Rewrite the CSS parser of prepare-ChangeLog with unittests.
3106         https://bugs.webkit.org/show_bug.cgi?id=75202
3107
3108         Reviewed by David Kilzer.
3109
3110         The current CSS parser can just parse simple CSSes like
3111
3112             foo bar baz {
3113                 property1: value;
3114                 property2: value;
3115             }
3116
3117         , and cannot parse comments nor a CSS in which a selector and {
3118         appears in different lines. This patch rewrites the CSS parser
3119         (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
3120         shown in css_unittests.css.
3121
3122         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
3123
3124         * Scripts/prepare-ChangeLog:
3125         (get_selector_line_ranges_for_css):
3126         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3127         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
3128         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
3129         (element1):
3130         (element2):
3131         (element3):
3132         (element4.p):
3133         (element5.p.q.r.s):
3134         (element6#p):
3135         (element7 element8):
3136         (element9.p element10.q):
3137         (element11#p element12#q):
3138         (element13, element14):
3139         (.p):
3140         (#p):
3141         (.p element15 #q element16.r element17#s):
3142         (element18:target):
3143         (element19):
3144         (element20):
3145         (element21):
3146         (element22):
3147
3148 2012-01-04  Kentaro Hara  <haraken@chromium.org>
3149
3150         The Perl parser of prepare-ChangeLog can parse here-documents
3151         https://bugs.webkit.org/show_bug.cgi?id=73208
3152
3153         Reviewed by David Kilzer.
3154
3155         Currently prepare-ChangeLog cannot recognize here-documents in Perl,
3156         which results in wrong subroutine names in ChangeLogs.
3157         With this patch, prepare-ChangeLog can judge whether the line of "}"
3158         is the end of a subroutine or a line inside a here-document.
3159
3160         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
3161
3162         * Scripts/prepare-ChangeLog:
3163         (get_function_line_ranges_for_perl):
3164         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
3165         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
3166         Added test cases for here-documents.
3167         (func7):
3168         (func8):
3169         (func9):
3170         (func10):
3171         (func11):
3172         (func12):
3173         (func13):
3174         (func14):
3175         (func15):
3176         (func16):
3177
3178 2012-01-08  Kentaro Hara  <haraken@chromium.org>
3179
3180         Add unittests for the JavaScript parser of prepare-ChangeLog
3181         https://bugs.webkit.org/show_bug.cgi?id=75201
3182
3183         Reviewed by David Kilzer.
3184
3185         javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
3186         of prepare-ChangeLog.
3187
3188         * Scripts/prepare-ChangeLog:
3189         (get_function_line_ranges_for_javascript): Before this patch, a string found was just
3190         omitted from parsing. Thus,
3191
3192             str = "foo"
3193             function func() {
3194             }
3195
3196         was recognized as equivalent to
3197
3198             str = function func() {
3199             }
3200
3201         This patch replaces a string with a dummy identifier 'string_appeared_here'
3202         to tell the parser that a string appeared there.
3203
3204         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3205         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
3206         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
3207         (func1):
3208         (func2):
3209         (func3):
3210         (func4):
3211         (func5):
3212         (func6):
3213         (func7):
3214         (func8):
3215         (func9):
3216         (func10):
3217         (func11):
3218         (func12):
3219         (funcOverloaded):
3220         (Func1.prototype.get x1):
3221         (Func1.prototype.get x2):
3222         (Func1.prototype.set x1):
3223         (Func1.prototype.set x3):
3224         (Func2.prototype.func13):
3225         (Func2.prototype.func14):
3226         (Func2.prototype.func15):
3227         (func16.func17):
3228         (func16.func18):
3229         (func16.func19):
3230         (func16):
3231
3232 2012-01-08  David Levin  <levin@chromium.org>
3233
3234         [chromium] Add layout test support for autosize code in FrameView.
3235         https://bugs.webkit.org/show_bug.cgi?id=73631
3236
3237         Reviewed by Dmitry Titov.
3238
3239         * DumpRenderTree/chromium/LayoutTestController.cpp:
3240         (LayoutTestController::LayoutTestController): Expose the new autoresize method.
3241         (LayoutTestController::reset): Set the autoresize mode back to false.
3242         (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
3243         * DumpRenderTree/chromium/LayoutTestController.h:
3244         * DumpRenderTree/chromium/WebViewHost.cpp:
3245         (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
3246         * DumpRenderTree/chromium/WebViewHost.h:
3247
3248 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
3249
3250         [WK2][GTK] Each test takes roughly half a second to load
3251         https://bugs.webkit.org/show_bug.cgi?id=70699
3252
3253         Reviewed by Martin Robinson.
3254
3255         Set the XDG_CACHE_HOME environment variable when testing with
3256         WebKitTestRunner. This way the testing is started with a non-existing
3257         application cache. If the cache exists and is not empty, the emptying
3258         and vacuuming that is performed before every test can consume a lot of
3259         time.
3260
3261         This is just a temporary workaround until it becomes possible to set
3262         a desired directory to be used as the application cache location through
3263         WebKitWebContext.
3264
3265         * Scripts/webkitpy/layout_tests/port/gtk.py:
3266         (GtkPort.setup_environ_for_server):
3267
3268 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
3269
3270         [GTK] Enable requestAnimationFrame in build-webkit
3271         https://bugs.webkit.org/show_bug.cgi?id=75773
3272
3273         Reviewed by Martin Robinson.
3274
3275         Enable requestAnimationFrame for the Gtk port.
3276
3277         * Scripts/build-webkit:
3278
3279 2012-01-06  Jarred Nicholls  <jarred@sencha.com>
3280
3281         Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
3282
3283         * Scripts/webkitdirs.pm:
3284         (buildChromium):
3285         Missing parentheses.
3286
3287 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
3288
3289         Fix DRT build on case-sensitive file systems.
3290
3291         Fix case of include of WebDynamicScrollBarsView.h
3292         
3293         * DumpRenderTree/mac/DumpRenderTree.mm:
3294
3295 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
3296
3297         Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
3298         https://bugs.webkit.org/show_bug.cgi?id=75662
3299
3300         Reviewed by Dan Bernstein.
3301         
3302         The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
3303         of color profile issues. Fix by keeping everything in device RGB and ensuring that the
3304         test window uses the main display's color space, so that the pixel values in the bitmap
3305         that gets checksummed are identical to the CSS colors.
3306         
3307         Removed the code that switches the display profile in DRT, since that is no longer required.
3308
3309         * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
3310         * DumpRenderTree/mac/DumpRenderTree.mm:
3311         (crashHandler): Remove code that switches display profiles.
3312         (prepareConsistentTestingEnvironment): Ditto.
3313         (dumpRenderTree): Ditto.
3314         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
3315         (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
3316         (createBitmapContextFromWebView): Add comment about the colorspace handling.
3317         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3318         (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
3319         (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
3320         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3321         (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
3322         (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
3323
3324 2012-01-06  David Kilzer  <ddkilzer@apple.com>
3325
3326         run-api-tests: specify individual suites and tests on the command-line
3327
3328         Reviewed by Adam Roben.
3329
3330         Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3331
3332         The run-api-tests script will now accept a list of arguments on
3333         the command-line that are used as prefix filters.  To run all
3334         tests in a suite that starts with "WTF" (WTF and WTF_Vector)
3335         use:
3336
3337             $ run-api-tests WTF
3338
3339         To run only the tests in the "WTF" suite, not the "WTF_Vector"
3340         suite, use:
3341
3342             $ run-api-tests WTF.
3343
3344         * Scripts/run-api-tests: Filter tests if any prefix arguments
3345         are passed on the command-line.
3346
3347 2012-01-06  David Kilzer  <ddkilzer@apple.com>
3348
3349         run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
3350
3351         Reviewed by Adam Roben.
3352
3353         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3354
3355         * Scripts/run-api-tests:
3356         (dumpTestsBySuite): Update to accept array of tests instead of
3357         hash data structure.
3358         (runTestsBySuite): Ditto.
3359         (listAllTests): Rename from populateTests().  Update to return
3360         an array of tests instad of the hash data structure.
3361
3362 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3363
3364         webkitpy: clean up test/uri conversion routines
3365         https://bugs.webkit.org/show_bug.cgi?id=75648
3366
3367         Reviewed by Eric Seidel.
3368
3369         This change moves test_to_uri and uri_to_test from the Port
3370         class to the Driver class (the routines were only being
3371         called by the drivers), and removes a bunch of stale and/or
3372         busted logic.
3373
3374         * Scripts/webkitpy/layout_tests/port/base.py:
3375         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3376         * Scripts/webkitpy/layout_tests/port/chromium.py:
3377         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3378         * Scripts/webkitpy/layout_tests/port/driver.py:
3379         (is_http_test):
3380         (test_to_uri):
3381         (uri_to_test):
3382         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3383         (run_one_test):
3384         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3385         (MockDRTTest.input_line):
3386         (input_line):
3387         (expected_output):
3388         * Scripts/webkitpy/layout_tests/port/test.py:
3389         * Scripts/webkitpy/layout_tests/port/webkit.py:
3390         (_command_from_driver_input):
3391
3392 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
3393
3394         Mitigate scrollbar differences when running pixel tests
3395         https://bugs.webkit.org/show_bug.cgi?id=67217
3396
3397         Reviewed by Dan Bernstein.
3398         
3399         Add an NSScroller subclass that draws mock scrollbars identically
3400         to the WebCore mock scrollbar theme, and register it with the
3401         WebDynamicScrollbarsView.
3402
3403         * DumpRenderTree/mac/DumpRenderTree.mm:
3404         (-[DRTMockScroller rectForPart:]):
3405         (-[DRTMockScroller drawKnob]):
3406         (-[DRTMockScroller drawRect:]):
3407         (registerMockScrollbars):
3408         (prepareConsistentTestingEnvironment):
3409
3410 2012-01-05  Jon Lee  <jonlee@apple.com>
3411
3412         Update DRT on Mac to draw resize handles on text areas.
3413
3414         Reviewed by John Sullivan.
3415
3416         Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
3417         between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
3418
3419         * DumpRenderTree/mac/DumpRenderTree.mm:
3420         (resetDefaultsToConsistentValues):
3421
3422 2012-01-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3423
3424         [Qt] Move listing of include paths and libs to pri files in sources
3425
3426         Includepaths are sometimes modified by non-Qt contributors so keeping
3427         them in files inside Sources makes it more likely that they are updated
3428         along with project files for the other ports.
3429
3430         Using pri files instead of prf files for this also has the benefit that
3431         the include() from the main target file can be parsed and followed by
3432         Qt Creator -- something that does not work with load().
3433
3434         Dependency from a target to a library through the WEBKIT variable are
3435         handled through forwarding-files in Tools/qmake/mkspecs/modules, which
3436         set the source root of the module and include the right pri file.
3437
3438         Ideally we'd use the variant of include() that takes an optional
3439         namespace to read the variables into, or the fromfile() function,
3440         but both of these add an overhead of about 40% on the total qmake
3441         runtime, due to making a deep copy of all the variables in the
3442         project or re-reading all the prf files from scratch.
3443
3444         Reviewed by Simon Hausmann.
3445         Reviewed by Ossy.
3446
3447         * qmake/mkspecs/features/default_post.prf:
3448         * qmake/mkspecs/modules/javascriptcore.prf: Added.
3449         * qmake/mkspecs/modules/webcore.prf: Added.
3450         * qmake/mkspecs/modules/webkit2.prf: Added.
3451         * qmake/mkspecs/modules/wtf.prf: Added.
3452
3453 2012-01-06  JungJik Lee  <jungjik.lee@samsung.com>
3454
3455         [EFL] Add pre-render handling code in EWebLauncher.
3456         https://bugs.webkit.org/show_bug.cgi?id=73430
3457
3458         Reviewed by Zoltan Herczeg.
3459
3460         Add pre-render handling code by pressing Insert key.
3461
3462         * EWebLauncher/main.c:
3463         (on_key_down):
3464
3465 2012-01-06  Csaba Osztrogonác  <ossy@webkit.org>
3466
3467         NRWT should use test_expectation.txt on wk2 platforms
3468         https://bugs.webkit.org/show_bug.cgi?id=75417
3469
3470         Reviewed by Dirk Pranke.
3471
3472         * Scripts/webkitpy/layout_tests/port/webkit.py:
3473         (path_to_test_expectations_file):
3474         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3475         (test_path_to_test_expectations_file):
3476
3477 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
3478
3479         Don't hardcode expected file URIs in as they depend on the platform
3480         https://bugs.webkit.org/show_bug.cgi?id=75666
3481
3482         Reviewed by Dirk Pranke.
3483
3484         * Scripts/webkitpy/layout_tests/port/win.py:
3485         (WinPort.show_results_html_file):
3486         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3487         (MainTest.test_unexpected_failures):
3488         (MainTest.test_results_directory_default):
3489         (MainTest.test_results_directory_relative):
3490
3491 2012-01-05  Anders Carlsson  <andersca@apple.com>
3492
3493         Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
3494         https://bugs.webkit.org/show_bug.cgi?id=75667
3495         <rdar://problem/10389454>
3496
3497         Reviewed by Kevin Decker.
3498
3499         Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
3500
3501         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3502         (PluginTest::executeScript):
3503         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3504         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
3505         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
3506         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
3507         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
3508
3509 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3510
3511         webkitpy: clean up port factory methods
3512         https://bugs.webkit.org/show_bug.cgi?id=75590
3513
3514         Reviewed by Eric Seidel.
3515
3516         This change consolidates much of the "factory method" logic
3517         of determining which port objects to create for a given set
3518         of configurations by merging the separate factory methods in
3519         chromium_gpu and google_chrome into PortFactory so that at least
3520         all of the logic is in one place.
3521
3522         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3523         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3524         * Scripts/webkitpy/layout_tests/port/factory.py:
3525         (_port_name_from_arguments_and_options):
3526         (get):
3527         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3528         (test_google_chrome):
3529         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3530         (GoogleChromeLinux32Port):
3531         (GoogleChromeLinux32Port.baseline_search_path):
3532         (test_expectations_overrides):
3533         (architecture):
3534         (GoogleChromeLinux64Port):
3535         (GoogleChromeLinux64Port.baseline_search_path):
3536         (GoogleChromeMacPort):
3537         (GoogleChromeMacPort.baseline_search_path):
3538         (GoogleChromeWinPort):
3539         (GoogleChromeWinPort.baseline_search_path):
3540         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3541         (_verify_baseline_path):
3542
3543 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
3544
3545         Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
3546         https://bugs.webkit.org/show_bug.cgi?id=75617
3547
3548         Reviewed by Dirk Pranke.
3549
3550         * Scripts/webkitpy/common/system/filesystem.py:
3551         (FileSystem.exists):
3552         * Scripts/webkitpy/common/system/filesystem_mock.py:
3553         (MockFileSystem.exists):
3554         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3555         (GenericFileSystemTests.teardown_generic_test_dir):
3556         * Scripts/webkitpy/layout_tests/port/base.py:
3557         (Port.to.show_results_html_file):
3558         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3559         (MainTest.test_results_directory_absolute):
3560
3561 2012-01-05  Adam Roben  <aroben@apple.com>
3562
3563         Remove some unnecessary code from old-run-webkit-tests
3564
3565         Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
3566         WebKitTestRunner.
3567
3568         Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
3569         Windows
3570
3571         Reviewed by Eric Seidel.
3572
3573         * Scripts/old-run-webkit-tests:
3574         (top level):
3575         (openDumpTool):
3576         Removed calls to setPathForRunningWebKitApp.
3577
3578 2012-01-05  Adam Roben  <aroben@apple.com>
3579
3580         Teach NRWT to use run-safari to open results.html on Apple's Windows port
3581
3582         NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
3583         better, since we always want to open results.html using the user's build of WebKit, not
3584         whatever their default browser is.
3585
3586         Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
3587         for Apple's Windows port
3588
3589         Reviewed by Eric Seidel.
3590
3591         * Scripts/webkitpy/layout_tests/port/win.py:
3592         (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
3593         an obsolete comment.
3594
3595         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3596         (WinPortTest.test_show_results_html_file): Updated expected results.
3597
3598 2012-01-05  Adam Roben  <aroben@apple.com>
3599
3600         Prepend Safari.exe's path to the command-line passed to CreateProcess
3601
3602         Safari expects the first argument in the command-line to be the path to Safari.exe itself.
3603         This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
3604         thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
3605         was not including the path to Safari.exe in the command-line, so Safari was ignoring the
3606         first argument that WebKitLauncherWin was trying to pass to it.
3607
3608         Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
3609
3610         Reviewed by Steve Falkenburg.
3611
3612         * WebKitLauncherWin/WebKitLauncherWin.cpp:
3613         (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
3614         path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
3615
3616 2012-01-05  Adam Roben  <aroben@apple.com>
3617
3618         Stop using explicit memory management in WebKitLauncherWin
3619
3620         We now use stack-allocated STL objects instead.
3621
3622         Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
3623         Safari
3624
3625         Reviewed by Steve Falkenburg.
3626
3627         * WebKitLauncherWin/WebKitLauncherWin.cpp:
3628         (getStringValue):
3629         (applePathFromRegistry):
3630         (safariInstallDir):
3631         (safariBrowserExe):
3632         (_tWinMain):
3633         Changed to use stack-allocated STL objects instead of malloc/free.
3634
3635 2012-01-05  Adam Roben  <aroben@apple.com>
3636
3637         Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
3638
3639         This allows us to add the Safari and Apple Application Support directories to PATH before
3640         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
3641
3642         Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
3643         Windows port of DumpRenderTree/WebKitTestRunner
3644
3645         Reviewed by Steve Falkenburg.
3646
3647         * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
3648         ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
3649
3650         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3651         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3652         Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
3653
3654         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
3655         Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
3656         the stub launcher.
3657
3658         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
3659         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
3660         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
3661         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
3662         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
3663         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
3664         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
3665
3666         * WebKitTestRunner/win/main.cpp:
3667         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
3668
3669 2012-01-05  Adam Roben  <aroben@apple.com>
3670
3671         Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
3672
3673         This allows us to add the Safari and Apple Application Support directories to PATH before
3674         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
3675
3676         Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
3677         Windows port of DumpRenderTree/WebKitTestRunner
3678
3679         Reviewed by Steve Falkenburg.
3680
3681         * DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,
3682         which I forgot to add to this .sln when that project was created.
3683
3684         * DumpRenderTree/win/DumpRenderTree.cpp:
3685         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
3686
3687         * DumpRenderTree/win/DumpRenderTree.vcproj: