8dd423011d710de717e693d6982c7340880405e1
[WebKit-https.git] / Tools / ChangeLog
1 2013-10-21  Anders Carlsson  <andersca@apple.com>
2
3         Navigation policy callback not called when performing the same fragment navigation twice
4         https://bugs.webkit.org/show_bug.cgi?id=123121
5         <rdar://problem/15230466>
6
7         Reviewed by Beth Dakin.
8
9         Add a test.
10
11         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12         * TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
13         * TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.
14         (+[WebKit1FragmentNavigationTestDelegate shared]):
15         (-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
16         (-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
17         (-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
18         (-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
19         (TestWebKitAPI::TEST):
20
21 2013-10-21  Dan Bernstein  <mitz@apple.com>
22
23         Style checker should allow a space after the @property keyword
24         https://bugs.webkit.org/show_bug.cgi?id=123117
25
26         Reviewed by Anders Carlsson.
27
28         * Scripts/webkitpy/style/checkers/cpp.py:
29         (check_spacing_for_function_call): Allow a space between @property and the following (
30         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
31         (CppStyleTest.test_spacing_for_fncall): Added a test case.
32
33 2013-10-21  peavo@outlook.com  <peavo@outlook.com>
34
35         [WinCairo] Build does not start.
36         https://bugs.webkit.org/show_bug.cgi?id=123059
37
38         Reviewed by Csaba Osztrogonác.
39
40         The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.
41
42         * Scripts/build-webkit:
43
44 2013-10-21  Zan Dobersek  <zdobersek@igalia.com>
45
46         [Jhbuild] Bump the required Jhbuild revision
47         https://bugs.webkit.org/show_bug.cgi?id=123089
48
49         Reviewed by Carlos Garcia Campos.
50
51         * jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild
52         due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
53         in the Jhbuild source so a more recent revision of it should be used.
54
55 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
56
57         Mac build fix.
58
59         * DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.
60
61 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
62
63         Enable webaudio/ tests on DRT/Mac
64         https://bugs.webkit.org/show_bug.cgi?id=86914
65
66         Reviewed by Darin Adler.
67
68         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
69         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
70         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.
71         There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.
72
73         * DumpRenderTree/TestRunner.cpp:
74         (setAudioResultCallback): 
75         (TestRunner::staticFunctions):
76         * DumpRenderTree/TestRunner.h:
77         (TestRunner::audioResult):
78         (TestRunner::setAudioResult):
79         The function has a different name and argument type now, updated accordingly.
80         Changed buffer from std::string to std::vector<char>, because it's more idiomatic.
81
82         * DumpRenderTree/mac/DumpRenderTree.mm:
83         (dumpAudio): Updated for the new name of audioResult accessor.
84         (dump): Print the result in the format webkitpy currently expects.
85
86         * WebKitTestRunner/TestInvocation.cpp:
87         (WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
88         chunks made no sense.
89
90         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
91         (WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.
92
93         * DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,
94         so that "SourceProvider.h" can be found.
95
96 2013-10-19  Ryosuke Niwa  <rniwa@webkit.org>
97
98         run-webkit-tests should submit time and modifiers to the new flakiness dashboard
99         https://bugs.webkit.org/show_bug.cgi?id=123070
100
101         Reviewed by Alexey Proskuryakov.
102
103         * Scripts/webkitpy/layout_tests/controllers/manager.py:
104         (Manager.run):
105         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
106         (summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
107         in the test expectations when this argument is set to true.
108
109 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
110
111         Mac DumpRenderTree builds without NDEBUG even in release mode
112         https://bugs.webkit.org/show_bug.cgi?id=123066
113
114         Reviewed by Dan Bernstein.
115
116         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
117         * DumpRenderTree/mac/Configurations/Base.xcconfig:
118         Use the same pattern as WebCore and WebKitTestRunner.
119
120 2013-10-19  Zan Dobersek  <zdobersek@igalia.com>
121
122         REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
123         https://bugs.webkit.org/show_bug.cgi?id=123064
124
125         Reviewed by Ryosuke Niwa.
126
127         Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.
128
129         * Scripts/webkitpy/common/config/ports.py: Added.
130         (DeprecatedPort):
131         (DeprecatedPort.name):
132         (DeprecatedPort.flag):
133         (DeprecatedPort.script_path):
134         (DeprecatedPort.script_shell_command):
135         (DeprecatedPort.port):
136         (DeprecatedPort.makeArgs):
137         (DeprecatedPort.update_webkit_command):
138         (DeprecatedPort.check_webkit_style_command):
139         (DeprecatedPort.prepare_changelog_command):
140         (DeprecatedPort.build_webkit_command):
141         (DeprecatedPort.run_javascriptcore_tests_command):
142         (DeprecatedPort.run_webkit_unit_tests_command):
143         (DeprecatedPort.run_webkit_tests_command):
144         (DeprecatedPort.run_python_unittests_command):
145         (DeprecatedPort.run_perl_unittests_command):
146         (DeprecatedPort.run_bindings_tests_command):
147         (MacPort):
148         (MacWK2Port):
149         (MacWK2Port.run_webkit_tests_command):
150         (WinPort):
151         (WinPort.run_bindings_tests_command):
152         (GtkPort):
153         (GtkPort.build_webkit_command):
154         (GtkPort.run_webkit_tests_command):
155         (GtkWK2Port):
156         (GtkWK2Port.build_webkit_command):
157         (GtkWK2Port.run_webkit_tests_command):
158         (QtPort):
159         (QtPort.build_webkit_command):
160         (QtPort.run_webkit_tests_command):
161         (QtWK2Port):
162         (QtWK2Port.build_webkit_command):
163         (QtWK2Port.run_webkit_tests_command):
164         (EflPort):
165         (EflPort.build_webkit_command):
166         (EflWK2Port):
167         (EflWK2Port.build_webkit_command):
168         * Scripts/webkitpy/common/config/ports_mock.py: Added.
169         (MockPort):
170         (MockPort.name):
171         (MockPort.check_webkit_style_command):
172         (MockPort.update_webkit_command):
173         (MockPort.build_webkit_command):
174         (MockPort.prepare_changelog_command):
175         (MockPort.run_python_unittests_command):
176         (MockPort.run_perl_unittests_command):
177         (MockPort.run_javascriptcore_tests_command):
178         (MockPort.run_webkit_unit_tests_command):
179         (MockPort.run_webkit_tests_command):
180         (MockPort.run_bindings_tests_command):
181         * Scripts/webkitpy/common/config/ports_unittest.py: Added.
182         (DeprecatedPortTest):
183         (DeprecatedPortTest.test_mac_port):
184         (DeprecatedPortTest.test_gtk_port):
185         (DeprecatedPortTest.test_gtk_wk2_port):
186         (DeprecatedPortTest.test_efl_port):
187         (DeprecatedPortTest.test_qt_port):
188         (DeprecatedPortTest.test_qt_wk2_port):
189         * Scripts/webkitpy/port/base.py:
190         (Port._port_flag_for_scripts):
191         (Port._wk2_port_name):
192         * Scripts/webkitpy/port/base_unittest.py:
193         (PortTest.test_build_path):
194         * Scripts/webkitpy/port/efl_unittest.py:
195         (EflPortTest.test_show_results_html_file):
196         * Scripts/webkitpy/port/gtk_unittest.py:
197         (GtkPortTest.test_get_crash_log):
198         * Scripts/webkitpy/port/mac_unittest.py:
199         (test_64bit):
200         * Scripts/webkitpy/port/test.py:
201         (TestPort.virtual_test_suites):
202         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
203         (FlakyTestReporter.__init__):
204         * Scripts/webkitpy/tool/bot/irc_command.py:
205         (Rollout._update_working_copy):
206         * Scripts/webkitpy/tool/commands/download_unittest.py:
207         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
208         (AbstractEarlyWarningSystem.run_command):
209         * Scripts/webkitpy/tool/commands/queues.py:
210         (PatchProcessingQueue.begin_work_queue):
211         (CommitQueue.run_command):
212         * Scripts/webkitpy/tool/main.py:
213         (WebKitPatch.__init__):
214         (WebKitPatch.deprecated_port):
215         (WebKitPatch.handle_global_options):
216         * Scripts/webkitpy/tool/mocktool.py:
217         (MockTool.__init__):
218         (MockTool.deprecated_port):
219         * Scripts/webkitpy/tool/steps/build.py:
220         (Build.build):
221         * Scripts/webkitpy/tool/steps/checkstyle.py:
222         (CheckStyle.run):
223         * Scripts/webkitpy/tool/steps/commit.py:
224         (Commit._check_test_expectations):
225         * Scripts/webkitpy/tool/steps/preparechangelog.py:
226         (PrepareChangeLog.run):
227         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
228         (PrepareChangeLogForRevert.run):
229         * Scripts/webkitpy/tool/steps/runtests.py:
230         (RunTests.run):
231         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
232         (RunTestsTest.test_webkit_run_unit_tests):
233         * Scripts/webkitpy/tool/steps/steps_unittest.py:
234         (StepsTest.test_runtests_args):
235         * Scripts/webkitpy/tool/steps/update.py:
236         (Update._update_command):
237         * Scripts/webkitpy/tool/steps/update_unittest.py:
238         (UpdateTest.test_update_command_non_interactive):
239         (UpdateTest.test_update_command_interactive):
240
241 2013-10-19  Andreas Kling  <akling@apple.com>
242
243         RefPtr::releaseNonNull() incorrectly increments the refcount.
244         <https://webkit.org/b/123063>
245
246         Add an API test to verify that no extra refs are added when calling
247         RefPtr::releaseNonNull().
248
249         Reviewed by Anders Carlsson.
250
251 2013-10-18  Rik Cabanier <cabanier@adobe.com>
252         Add Rik Cabanier to list of committers
253         https://bugs.webkit.org/show_bug.cgi?id=123031
254
255         reviewed by Dirk Schulze.
256
257         * Tools/Scripts/webkitpy/common/config/contributors.json: Added name.
258
259 2013-10-18  Denis Nomiyama  <d.nomiyama@samsung.com>
260
261         [ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
262         https://bugs.webkit.org/show_bug.cgi?id=122970
263
264         Reviewed by Mario Sanchez Prada.
265
266         Removed an invalid signal to set an object state to layout-complete
267         that does not exist. It was replaced by ATK:AtkDocument:load-complete.
268
269         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
270         (axObjectEventListener): Replaced layout-complete with load-complete.
271         (connectAccessibilityCallbacks): Connect callback to new listener for
272         ATK:AtkDocument:load-complete.
273         (disconnectAccessibilityCallbacks): Disconnect callback to new listener
274         for ATK:AtkDocument:load-complete.
275         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
276         (axObjectEventListener): Replaced layout-complete with load-complete.
277         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
278         Connect callback to new listener for ATK:AtkDocument:load-complete.
279         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
280         Disconnect callback to new listener for ATK:AtkDocument:load-complete.
281
282 2013-10-18  Carlos Garcia Campos  <cgarcia@igalia.com>
283
284         [GTK] Generate API documentation for GObject DOM bindings
285         https://bugs.webkit.org/show_bug.cgi?id=121538
286
287         Reviewed by Gustavo Noronha Silva.
288
289         The .symbols file that is now generated for checking GObject DOM
290         bindings API compatibility while building can also be used to
291         generate the files needed to produce the gtk-doc
292         documentation. The new script generate-webkitdom-doc-files can
293         generate the docs.sgml and sections.txt files from the given list
294         of .symbols files.
295
296         * gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml
297         and webkitdomgtk-sections.txt as well as rules to install the
298         generated WebKitDOMGTK documentation.
299         * gtk/generate-gtkdoc:
300         (webkitdom_docs_html_path): New helper function that returns the
301         path where the DOM API documentation has been generated.
302         (get_webkit2_options): Include DOM API docs to the list of xref
303         dependencies.
304         (get_webkit1_options): Ditto.
305         (get_webkitdom_options): Return the gtk-doc options to generate
306         the DOM API docs.
307         (get_webkitdom_options.derived_sources_path):
308         (get_webkitdom_options.src_path):
309         * gtk/generate-webkitdom-doc-files: Added.
310         (WebKitDOMDocGenerator):
311         (WebKitDOMDocGenerator.write_header):
312         (WebKitDOMDocGenerator.write_section):
313         (WebKitDOMDocGenerator.write_footer):
314         (WebKitDOMDocGeneratorDocs):
315         (WebKitDOMDocGeneratorDocs.write_header):
316         (write_section):
317         (write_footer):
318         (WebKitDOMDocGeneratorSections):
319         (WebKitDOMDocGeneratorSections.__init__):
320         (WebKitDOMDocGeneratorSections._dom_class):
321         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
322         (WebKitDOMDocGeneratorSections._symbol_list):
323         (WebKitDOMDocGeneratorSections.write_section):
324
325 2013-10-17  Alex Christensen  <achristensen@webkit.org>
326
327         Run JavaScriptCore tests again on Windows.
328         https://bugs.webkit.org/show_bug.cgi?id=122787
329
330         Reviewed by Tim Horton.
331
332         * Scripts/build-jsc:
333         (buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
334         * Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
335         * Scripts/webkitdirs.pm:
336         (determineConfigurationForVisualStudio):
337         (determineConfigurationProductDir):
338         Build directory should end with bin64 and configuration should end with |x64 on Win64.
339         (isAppleWinWebKit):
340         (copyInspectorFrontendFiles):
341         (setPathForRunningWebKitApp):
342         Separated WinCairo directories and options from AppleWin.
343
344 2013-10-17  Mihnea Ovidenie  <mihnea@adobe.com>
345
346         Unreviewed. Add myself as a reviewer.
347
348         * Scripts/webkitpy/common/config/contributors.json:
349
350 2013-10-17  Andreas Kling  <akling@apple.com>
351
352         Make it possible to assign a PassRef to a RefPtr.
353         <https://webkit.org/b/122943>
354
355         Added a small API test for RefPtr=(PassRef) so we know this code
356         will compile (and work.)
357
358         Reviewed by Antti Koivisto.
359
360 2013-10-16  Filip Pizlo  <fpizlo@apple.com>
361
362         We need test coverage for just the Baseline JIT
363         https://bugs.webkit.org/show_bug.cgi?id=122929
364
365         Reviewed by Sam Weinig.
366         
367         Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
368         variant.
369
370         * Scripts/run-jsc-stress-tests:
371
372 2013-10-16  Ryosuke Niwa  <rniwa@webkit.org>
373
374         Support multiple repositories in submitting results to --results-server-host
375         https://bugs.webkit.org/show_bug.cgi?id=122935
376
377         Reviewed by Anders Carlsson.
378
379         Remoevd --got-revision and added the logic to extract revision information
380         from multiple repositories as done in run-perf-tests.
381
382         * Scripts/webkitpy/layout_tests/controllers/manager.py:
383         (Manager.upload_results):
384         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
385         (parse_args):
386
387 2013-10-16  Darin Adler  <darin@apple.com>
388
389         Add PassRef and createRefCounted so we can improve creation of RefCounted objects
390         https://bugs.webkit.org/show_bug.cgi?id=122904
391
392         Reviewed by Anders Carlsson.
393
394         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
395
396 2013-10-16  Darin Adler  <darin@apple.com>
397
398         Need tests for RefPtr self-assignment and self-move-assignment.
399
400         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
401
402 2013-10-16  Robert Plociennik  <r.plociennik@samsung.com>
403
404         [EFL] Minibrowser can't load child window's location
405         https://bugs.webkit.org/show_bug.cgi?id=122485
406
407         Reviewed by Gyuyoung Kim.
408
409         * MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
410             followed by an explicit call to ewk_view_url_set() where appropriate.
411         (on_key_down):
412         (on_window_create):
413         (window_create):
414         (elm_main):
415
416 2013-10-15  Sergio Correia  <sergio.correia@openbossa.org>
417
418         [EFL][WK2] Make SeccompFilters build again after r156349 and r156353
419         https://bugs.webkit.org/show_bug.cgi?id=122872
420
421         Reviewed by Anders Carlsson.
422
423         * TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
424         failing.
425
426 2013-10-15  Dean Jackson  <dino@apple.com>
427
428         Add ENABLE_WEB_ANIMATIONS flag
429         https://bugs.webkit.org/show_bug.cgi?id=122871
430
431         Reviewed by Tim Horton.
432
433         Eventually might be http://dev.w3.org/fxtf/web-animations/
434         but this is just engine-internal work at the moment.
435
436         * Scripts/webkitperl/FeatureList.pm:
437
438 2013-10-15  Darin Adler  <darin@apple.com>
439
440         Add some API tests for Vector, RefPtr, and Ref
441         https://bugs.webkit.org/show_bug.cgi?id=122840
442
443         Reviewed by Andreas Kling.
444
445         * TestWebKitAPI/CMakeLists.txt: Added new files.
446         * TestWebKitAPI/GNUmakefile.am: Ditto.
447         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
448         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
449         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
450
451         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
452         * TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
453         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
454         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
455
456 2013-10-14  Roger Fong  <roger_fong@apple.com>
457
458         Adding myself to CC list for some components.
459
460         * Scripts/webkitpy/common/config/watchlist:
461
462 2013-10-13  Darin Adler  <darin@apple.com>
463
464         Deprecate or remove deleteAllValues functions; there are only a few call sites left
465         https://bugs.webkit.org/show_bug.cgi?id=122738
466
467         Reviewed by Anders Carlsson.
468
469         * DumpRenderTree/win/DRTDataObject.cpp:
470         (DRTDataObject::~DRTDataObject):
471         * DumpRenderTree/win/UIDelegate.cpp:
472         (DRTUndoStack::~DRTUndoStack):
473         (DRTUndoStack::clear):
474         Renamed deleteAllValues to deprecatedDeleteAllValues.
475
476         * Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
477
478 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
479
480         build.webkit.org/dashboard incorrectly shows interrupted builds as green
481         https://bugs.webkit.org/show_bug.cgi?id=122732
482
483         Reviewed by Tim Hatcher.
484
485         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
486         (BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
487         I don't see it occur any time in recent history, but judging from what happens for
488         status 5 (RETRY), we can just finish this function normally.
489         Record overall text description for iteration as BuildbotIteration.text.
490
491         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
492         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
493         but no tests failed, make it yellow, and use buildbot-provided description for it.
494
495 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
496
497         Remove Chromium specific code from flakiness dashboard
498         https://bugs.webkit.org/show_bug.cgi?id=122714
499
500         Reviewed by Sam Weinig.
501
502         Also removed code related to GPU tests and virtual suites.
503         "Fallbacks map" was chromium only too, not sure why they needed special handling there.
504
505         * TestResultServer/model/jsonresults_unittest.py:
506         * TestResultServer/static-dashboards/builders.js:
507         * TestResultServer/static-dashboards/dashboard_base.js:
508         * TestResultServer/static-dashboards/flakiness_dashboard.html:
509         * TestResultServer/static-dashboards/flakiness_dashboard.js:
510         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
511         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
512         * TestResultServer/static-dashboards/history.js:
513         * TestResultServer/static-dashboards/loader.js:
514         * TestResultServer/static-dashboards/ui.js:
515         * TestResultServer/templates/uploadform.html:
516
517 2013-10-11  Timothy Hatcher  <timothy@apple.com>
518
519         Remove preference support for picking the old Web Inspector.
520         https://bugs.webkit.org/show_bug.cgi?id=122655
521
522         Reviewed by Alexey Proskuryakov.
523
524         * WebKitTestRunner/TestController.cpp:
525         (WTR::TestController::resetStateToConsistentValues):
526
527 2013-10-11  Filip Pizlo  <fpizlo@apple.com>
528
529         Fix 64-bit build on everything but Windows.
530
531         Rubber stamped by Brent Fulgham.
532
533         * Scripts/webkitdirs.pm:
534         (argumentsForConfiguration):
535
536 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
537
538         Touch a file to see how auto-update works.
539
540         Rubber-stamped by Tim Hatcher.
541
542         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
543
544 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
545
546         LeaksViewer fails to present recent results list if current build is still updating svn
547         https://bugs.webkit.org/show_bug.cgi?id=122670
548
549         Fixed an obvious mistake in the previous patch.
550
551         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
552         (RecentBuildsLoader.prototype.start):
553
554 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
555
556         LeaksViewer fails to present recent results list if current build is still updating svn
557         https://bugs.webkit.org/show_bug.cgi?id=122670
558
559         Reviewed by Adam Roben.
560
561         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
562         (RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
563
564 2013-10-11  Brent Fulgham  <bfulgham@apple.com>
565
566         Unreviewed build fix for --64-bit target.
567
568         * Scripts/webkitdirs.pm:
569         (argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
570         been removed by this point.
571         (hasArgument): Remove unused temporary.
572
573 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
574
575         webkit-patch failure-reason has a quite low limit for 'too many failures'
576         https://bugs.webkit.org/show_bug.cgi?id=122556
577
578         Reviewed by Darin Adler.
579
580         * Scripts/webkitpy/tool/commands/queries.py:
581         (FailureReason._explain_failures_for_builder): adjust the number of too many failures
582         to match what the layout test runners use these days.
583
584 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
585
586         webkit-patch failure-reason should allow specifying failures one is interested in
587         https://bugs.webkit.org/show_bug.cgi?id=122554
588
589         Reviewed by Darin Adler.
590
591         * Scripts/webkitpy/tool/commands/queries.py:
592         (FailureReason):
593         (FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
594         loop if the ones we're interested in been explained.
595         (FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
596         (FailureReason.execute): initialize failures to explain and the explained set.
597
598 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
599
600         Make sure that DataTypes.h is in the binary drop.
601
602         Rubber stamped by Michael Saboff.
603
604         * Scripts/export-llvm-build:
605
606 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
607
608         FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
609         https://bugs.webkit.org/show_bug.cgi?id=122566
610
611         Reviewed by Mark Rowe.
612
613         * Scripts/configure-llvm:
614
615 2013-10-10  Mark Rowe  <mrowe@apple.com>
616
617         <rdar://problem/13341666> WebKit should always build against an SDK.
618
619         Have all projects default to building against the OS X Internal SDK for the Production
620         configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
621         to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
622
623         Reviewed by Dan Bernstein.
624
625         * DumpRenderTree/mac/Configurations/Base.xcconfig:
626         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
627         * MiniBrowser/Configurations/Base.xcconfig:
628         * MiniBrowser/Configurations/DebugRelease.xcconfig:
629         * TestWebKitAPI/Configurations/Base.xcconfig:
630         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
631         * WebKitTestRunner/Configurations/Base.xcconfig:
632         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
633
634 2013-10-10  Gustavo Noronha Silva  <gns@gnome.org>
635
636         Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
637
638         * Scripts/run-gtk-tests:
639         (TestRunner): skip TestInspectorServer.
640
641 2013-10-10  Andres Gomez  <agomez@igalia.com>
642
643         [GTK] Provide search functionality to MiniBrowser
644         https://bugs.webkit.org/show_bug.cgi?id=117631
645
646         Reviewed by Carlos Garcia Campos.
647
648         Adds a search bar to MiniBrowser with the minimum functionality
649         and a new button to the toolbar for showing the new search
650         bar. Typical keyboard shortcuts are also added.
651
652         * MiniBrowser/gtk/BrowserSearchBar.c: Added.
653         (doSearch):
654         (searchNext):
655         (searchPrevious):
656         (searchCloseButtonClickedCallback):
657         (searchEntryMenuIconPressedCallback):
658         (searchEntryClearIconReleasedCallback):
659         (searchEntryChangedCallback):
660         (searchEntryActivatedCallback):
661         (searchPrevButtonClickedCallback):
662         (searchNextButtonClickedCallback):
663         (searchMenuCheckButtonToggledCallback):
664         (browser_search_bar_init):
665         (browserSearchBarFinalize):
666         (browser_search_bar_class_init):
667         (browser_search_bar_new):
668         (browser_search_bar_add_accelerators):
669         (browser_search_bar_open):
670         (browser_search_bar_close):
671         * MiniBrowser/gtk/BrowserSearchBar.h: Added.
672         * MiniBrowser/gtk/BrowserWindow.c:
673         (webViewEnterFullScreen): Closes new search bar.
674         (webViewLeaveFullScreen): Opens new search bar if previously
675         visible.
676         (searchCallback): Added. Shows and hides the new search bar.
677         (browser_window_init): Added search button to the toolbar.
678         (browserWindowConstructed): Creates the new search bar.
679         * MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
680
681 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
682
683         webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
684         https://bugs.webkit.org/show_bug.cgi?id=122552
685
686         Reviewed by Darin Adler.
687
688         * Scripts/webkitpy/common/checkout/commitinfo.py:
689         (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
690         will cause UnicodeDecodeError for non-ascii characters.
691
692 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
693
694         Would like a link to dashboard from build.webkit.org main page
695         https://bugs.webkit.org/show_bug.cgi?id=122577
696
697         Reviewed by Tim Hatcher.
698
699         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
700
701 2013-10-09  Brent Fulgham  <bfulgham@apple.com>
702
703         [Win] Check for MathML fonts and warn user if they are missing.
704         https://bugs.webkit.org/show_bug.cgi?id=122568
705
706         Reviewed by Tim Horton.
707
708         * Scripts/webkitdirs.pm:
709         (checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
710         Windows-specific code I added previously.
711         (fontExists): Added
712         (checkInstalledTools): Add check for MathML fonts.
713
714 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
715
716         http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
717         https://bugs.webkit.org/show_bug.cgi?id=122471
718
719         Reviewed by Tim Hatcher.
720
721         Added links to webkitpy, webkitperl and bindings-tests results.
722
723         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
724         (Buildbot.prototype.apiTestResultsURLForIteration):
725         (Buildbot.prototype.webkitpyTestResultsURLForIteration):
726         (Buildbot.prototype.webkitperlTestResultsURLForIteration):
727         (Buildbot.prototype.bindingsTestResultsURLForIteration):
728         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
729         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
730
731 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
732
733         Move some functions from WebKitBuildbot to Buildbot class.
734
735         Suggested by Tim Hatcher.
736
737         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
738         (Buildbot.prototype.javascriptTestResultsURLForIteration):
739         (Buildbot.prototype.apiTestResultsURLForIteration):
740         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
741         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
742
743 2013-10-09  Timothy Hatcher  <timothy@apple.com>
744
745         Add API tests to the Dashbord page.
746
747         https://bugs.webkit.org/show_bug.cgi?id=122283
748
749         Reviewed by Timothy Hatcher.
750
751         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
752         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
753         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
754         (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
755
756 2013-10-09  Timothy Hatcher  <timothy@apple.com>
757
758         Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
759
760         https://bugs.webkit.org/show_bug.cgi?id=122515
761
762         Reviewed by Alexey Proskuryakov.
763
764         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
765         (BuildbotIteration.prototype.update):
766
767 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
768
769         build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
770         https://bugs.webkit.org/show_bug.cgi?id=122573
771
772         Reviewed by Tim Hatcher.
773
774         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
775         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
776
777         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
778         (Buildbot.prototype.buildPageURLForIteration): Added.
779
780 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
781
782         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
783         https://bugs.webkit.org/show_bug.cgi?id=122569
784
785         Reviewed by Tim Hatcher.
786
787         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
788         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
789         to be produced by the old Mozilla test harness that we don't use any more.
790
791 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
792
793         Add GTK 64 bits release to the buildbot dashboard
794         https://bugs.webkit.org/show_bug.cgi?id=122548
795
796         Reviewed by Darin Adler.
797
798         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
799         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
800         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
801         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
802         (table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
803
804 2013-10-09  Mario Sanchez Prada  <mario.prada@samsung.com>
805
806         [ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
807         https://bugs.webkit.org/show_bug.cgi?id=120638
808
809         Reviewed by Gustavo Noronha Silva.
810
811         * gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
812         can check both the old and new APIs to retrieve text at a given offset.
813
814 2013-10-08  Alex Christensen  <achristensen@webkit.org>
815
816         Improved WinLauncher.
817         https://bugs.webkit.org/show_bug.cgi?id=122536
818
819         Reviewed by Brent Fulgham.
820
821         * WinLauncher/PrintWebUIDelegate.cpp:
822         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
823         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
824         * WinLauncher/PrintWebUIDelegate.h: Removed stubs.
825         * WinLauncher/WinLauncher.cpp:
826         (createCrashReport): Use the executable name instead of "WinLauncher".
827         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
828         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
829         * win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
830
831 2013-10-08  Mark Lam  <mark.lam@apple.com>
832
833         Fix ruby LoadError when running run-javascriptcore-tests.
834         https://bugs.webkit.org/show_bug.cgi?id=122519.
835
836         Reviewed by Mark Hahnenberg.
837
838         The scripts needed to explicitly require 'rubygems' for older versions of ruby
839         (versions before 1.9).
840
841         * Scripts/jsc-stress-test-helpers/profiler-test-helper:
842         * Scripts/run-jsc-stress-tests:
843
844 2013-10-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
845
846         Unreviewed, add my new email to contributors.json.
847
848         * Scripts/webkitpy/common/config/contributors.json:
849
850 2013-10-08  Brent Fulgham  <bfulgham@apple.com>
851
852         Unreviewed build correction.
853
854         * Scripts/webkitpy/port/win.py:
855         (WinPort.write_registry_value): Use string representation of error message to avoid
856         format conversion problem.
857
858 2013-10-07  Brent Fulgham  <bfulgham@apple.com>
859
860         [Win] Add checks for proper build and test environment
861         https://bugs.webkit.org/show_bug.cgi?id=122466
862
863         Reviewed by Darin Adler.
864
865         This patch makes two changes:
866         1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or
867            error messages so that people know what to fix to get things working.
868         2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure
869            the various environment settings are properly configured for our test environment.
870
871         * Scripts/webkitdirs.pm:
872         (checkInstalledTools): Add checks for some common Cygwin configuration problems that have
873         caused problems in the past.
874         (setupAppleWinEnv):
875         * Scripts/webkitpy/port/win.py:
876         (WinPort):
877         (WinPort.read_registry_string): Parameterize for run architecture and registry root.
878         (WinPort.write_registry_value): Parameterize registry writing by data type (string versus
879         DWORD, etc.)
880         (WinPort.write_registry_string): Revise to call new generic registry write function.
881         (WinPort.setup_crash_log_saving): Revise for new API
882         (WinPort.restore_crash_log_saving): Ditto
883         (WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
884         servers from running.
885         (WinPort.allow_error_dialogs): Ditto.
886         (WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
887         (WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
888
889 2013-10-08  Philippe Normand  <pnormand@igalia.com>
890
891         [GStreamer] enable v4l2 plugin
892         https://bugs.webkit.org/show_bug.cgi?id=122503
893
894         Reviewed by Martin Robinson.
895
896         * gtk/jhbuild.modules: Enable the plugin, it now builds fine since
897         we updated our GStreamer version to 1.0.8.
898
899 2013-10-08  Mario Sanchez Prada  <mario.prada@samsung.com>
900
901         [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
902         https://bugs.webkit.org/show_bug.cgi?id=122104
903
904         Reviewed by Chris Fleizach.
905
906         Updated stringAttributeValue to double check that the exposure of
907         aria-invalid as a state is consistent with its exposure as a text
908         attribute as well, when it applies (implementations of AtkText).
909
910         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
911         (AccessibilityUIElement::stringAttributeValue): Add double check.
912         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
913         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
914
915 2013-10-07  Filip Pizlo  <fpizlo@apple.com>
916
917         run-jsc-stress-tests progress meter should update more quickly on older Rubies
918         https://bugs.webkit.org/show_bug.cgi?id=122459
919
920         Reviewed by Darin Adler.
921
922         * Scripts/run-jsc-stress-tests:
923
924 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
925
926         [buildbot] parse tests that are reported as crashed correctly for GTK+
927         https://bugs.webkit.org/show_bug.cgi?id=122476
928
929         Reviewed by Martin Robinson.
930
931         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
932         (RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
933         as a failure of the API tests.
934
935 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
936
937         Unreviewed. Skipping API test that is causing the next one to crash,
938         see https://bugs.webkit.org/show_bug.cgi?id=121970.
939
940         * Scripts/run-gtk-tests:
941         (TestRunner):
942
943 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
944
945         [GTK] run-gtk-tests does not distinguish between failure and crashes
946         https://bugs.webkit.org/show_bug.cgi?id=122135
947
948         Reviewed by Martin Robinson.
949
950         The GTK+ API test runner does not distinguish between failures and crashes. This change
951         makes it do that, so it's easier for us to spot the more important/higher priority crash
952         case.
953
954         * Scripts/run-gtk-tests:
955         (TestRunner._run_test_command): return the exit code instead of a boolean true/false,
956         so we have more information on how the process ended.
957         (TestRunner._run_test): check the exit code to distinguish between crashes and failures.
958         (TestRunner.run_tests): report crashes.
959
960 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
961
962         [GTK] Missing packages for APT on install-dependencies
963         https://bugs.webkit.org/show_bug.cgi?id=121555
964
965         Reviewed by Martin Robinson.
966
967         * gtk/install-dependencies: add packages that are needed for
968         building WebKit itself and the jhbuild dependencies.
969
970 2013-10-07  Anders Carlsson  <andersca@apple.com>
971
972         Fix test failures.
973
974         * Scripts/webkitpy/port/base.py:
975         (Port.to.start_helper):
976         * Scripts/webkitpy/port/mock_drt.py:
977         (MockDRTPort.start_helper):
978
979 2013-10-07  Anders Carlsson  <andersca@apple.com>
980
981         Always force discrete mode when running layout tests
982         https://bugs.webkit.org/show_bug.cgi?id=122465
983
984         Reviewed by Tim Horton.
985
986         This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
987         
988         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
989         Link with IOKit.
990
991         * DumpRenderTree/mac/LayoutTestHelper.m:
992         (installLayoutTestColorProfile):
993         Check installColorProfile.
994
995         (restoreUserColorProfile):
996         Check installColorProfile.
997
998         (lockDownDiscreteGraphics):
999         New function to force discrete graphics.
1000
1001         (main):
1002         Add '--install-color-profile' option.
1003
1004         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1005         (Manager._set_up_run):
1006         Always start the helper, but pass self._options.pixel_tests to it.
1007
1008         * Scripts/webkitpy/port/mac.py:
1009         (MacPort.start_helper):
1010         Pass --install-color-profile' to the helper if pixel_tests is true.
1011
1012 2013-10-07  Timothy Hatcher  <timothy@apple.com>
1013
1014         Properly count binding test failures as failures.
1015
1016         Fix the total for multiple failures in different steps too by avoiding undefined.
1017
1018         https://bugs.webkit.org/show_bug.cgi?id=122232
1019
1020         Reviewed by Alexey Proskuryakov.
1021
1022         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1023         (BuildbotTestResults):
1024         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1025         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1026
1027 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1028
1029         [GTK] Fails to build with jhbuild with newer system glib
1030         https://bugs.webkit.org/show_bug.cgi?id=122132
1031
1032         Reviewed by Martin Robinson.
1033
1034         Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
1035         started relying on. glib is not a dependency that should change test results, and is provided in
1036         jhbuild with the intention of supporting the other bits that do, so using a newer stable release
1037         should not be an issue.
1038
1039         * gtk/jhbuild.modules:
1040
1041 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1042
1043         run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
1044         https://bugs.webkit.org/show_bug.cgi?id=122437
1045
1046         Reviewed by Antoine Quint.
1047
1048         * Scripts/run-jsc-stress-tests:
1049
1050 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1051
1052         Unreviewed, fix build on old Rubies.
1053
1054         * Scripts/run-jsc-stress-tests:
1055
1056 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1057
1058         Unified test infrastructure via the jsc shell
1059         https://bugs.webkit.org/show_bug.cgi?id=120696
1060
1061         Reviewed by Oliver Hunt.
1062         
1063         Make run-jsc-stress-tests smart enough to be able to handle different styles of test
1064         output (silent or noisy) and different styles of test failure (just bad exit code,
1065         text diff, filtering for some magical text, etc.). This allows me to get rid of the
1066         layout-test-helper. It also allows me to switch all of the old Mozilla tests to
1067         running in run-jsc-stress-tests.
1068         
1069         Also removes all of the code paths that defended against not having shellwords. Just
1070         install the shellwords gem if you want to run tests.
1071         
1072         Also removes the non-parallel test running code. No reason for it to exist anymore.
1073         
1074         This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
1075         as part of this patch, and left three more as new bugzillas.
1076
1077         * Scripts/create-mozilla-js-test-list: Added.
1078         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
1079         * Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
1080         * Scripts/run-javascriptcore-tests:
1081         * Scripts/run-jsc-stress-tests:
1082
1083 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1084
1085         run-jsc-stress-tests should be less verbose
1086         https://bugs.webkit.org/show_bug.cgi?id=122397
1087
1088         Reviewed by Sam Weinig.
1089         
1090         It now just prints something like:
1091         
1092          965/1831 ....
1093         
1094         Where the first number is the number of tests that completed, the second number is the
1095         number of tests total, and the dots are the number of tests running right now - which is
1096         useful towards the end when you're waiting for the last slow tests to finish.
1097         
1098         It will also print out the output from failing tests and it will print a line for skipped
1099         tests (to annoy you into getting them into a shape where they can be unskipped). For
1100         example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
1101
1102         * Scripts/run-jsc-stress-tests:
1103
1104 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1105
1106         Allow skipping of run-jsc-stress-tests that are configured using yaml files
1107         https://bugs.webkit.org/show_bug.cgi?id=122385
1108
1109         Reviewed by Sam Wieinig.
1110         
1111         Make tests run via YAML be able to do the parse-for-commands trick that allows
1112         us to skip tests and do other custom per-test stuff.
1113
1114         * Scripts/jsc-stress-test-helpers/layout-test-helper:
1115         * Scripts/run-jsc-stress-tests:
1116
1117 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1118
1119         Unreviewed, fix tests on older Rubies.
1120
1121         * Scripts/run-jsc-stress-tests:
1122
1123 2013-10-05  Anders Carlsson  <andersca@apple.com>
1124
1125         Don't filter the weak symbols.
1126
1127         * Scripts/check-for-weak-vtables-and-externals:
1128
1129 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1130
1131         Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
1132         https://bugs.webkit.org/show_bug.cgi?id=122376
1133
1134         Reviewed by Mark Hahnenberg.
1135
1136         * Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
1137         * Scripts/run-javascriptcore-tests:
1138         (printThingsFound):
1139         * Scripts/run-jsc-stress-tests:
1140
1141 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1142
1143         It should be even easier to run and debug a failing JSC stress test
1144         https://bugs.webkit.org/show_bug.cgi?id=122337
1145
1146         Reviewed by Oliver Hunt.
1147         
1148         If a test fails, you can now just say:
1149
1150         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
1151
1152         and get the reproduction. You don't have to set any environment variables like before.
1153         Also if you want to debug the failing test you can now just say:
1154
1155         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
1156
1157         Broadly, any arguments passed to the reproduction script are prepended to the command to
1158         run the test. This is sort of quirky and won't work for some tests (for example the
1159         profiler tests run a ruby script that runs some other stuff) but it'll work for most of
1160         them and that's good enough for now.
1161
1162         * Scripts/run-jsc-stress-tests:
1163
1164 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1165
1166         [Windows] Correct run-path when using 64-bit binaries.
1167
1168         Reviewed by David Kilzer.
1169
1170         * Scripts/webkitdirs.pm:
1171         (determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
1172         directory. Otherwise use the existing 'bin32' directory.
1173
1174 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1175
1176         Teach webkitdirs.pm to honor the --64-bit flag
1177         https://bugs.webkit.org/show_bug.cgi?id=122357
1178
1179         Reviewed by David Kilzer.
1180
1181         * Scripts/webkitdirs.pm:
1182         (argumentsForConfiguration): Modify to check if --64-bit is supplied
1183         by the user.
1184         (findMatchingArguments): Added.
1185         (hasArgument): Added.
1186         (checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
1187         findMatchingArguments subroutine.
1188
1189 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1190
1191         Update svn-config for new Visual Studio extensions
1192         https://bugs.webkit.org/show_bug.cgi?id=122344
1193
1194         Reviewed by Brent Fulgham.
1195
1196         * svn-config: Add new Visual Studio extensions.
1197
1198 2013-10-04  Alex Christensen  <achristensen@webkit.org>
1199
1200         Made WinLauncher have better error handling, crash reporting, and modifiability.
1201         https://bugs.webkit.org/show_bug.cgi?id=122319
1202
1203         Reviewed by Brent Fulgham.
1204
1205         * WinLauncher/WinLauncher.cpp:
1206         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1207         Don't display the numerous "Cancelled" messages that are obviously from the user.
1208         (createCrashReport): Added.
1209         (dllLauncherEntryPoint):
1210         Made main loop back into while loop and write a crash report if it crashes.
1211         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1212         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1213         Added WinLauncherReplace.h.
1214         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
1215         Added linking to DbgHelp.lib.
1216         * WinLauncher/WinLauncherReplace.h:
1217         Added to make modifying WinLauncher behaviour and appearance easy.
1218         (processCrashDump): Added.
1219
1220 2013-10-04  Dirk Pranke  <dpranke@chromium.org>
1221
1222         remove dpranke from webkitpy watchlist
1223         https://bugs.webkit.org/show_bug.cgi?id=122331
1224
1225         Reviewed by Brent Fulgham.
1226
1227         * Scripts/webkitpy/common/config/watchlist:
1228
1229 2013-10-04  Tim Horton  <timothy_horton@apple.com>
1230
1231         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1232         https://bugs.webkit.org/show_bug.cgi?id=122299
1233
1234         Reviewed by Beth Dakin.
1235
1236         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1237         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1238         The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
1239
1240 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1241
1242         Watchlist is broken after <http://trac.webkit.org/r156880>
1243
1244         * Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
1245
1246 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1247
1248         Remove Qt features from build and test tools
1249         https://bugs.webkit.org/show_bug.cgi?id=122312
1250
1251         Reviewed by Anders Carlsson.
1252
1253         * Scripts/build-dumprendertree:
1254         * Scripts/build-jsc:
1255         * Scripts/build-webkit:
1256         * Scripts/build-webkittestrunner:
1257         * Scripts/old-run-webkit-tests:
1258         (openDumpTool):
1259         (buildPlatformResultHierarchy):
1260         (buildPlatformTestHierarchy):
1261         (readSkippedFiles):
1262         * Scripts/run-launcher:
1263         * Scripts/run-qtwebkit-tests: Removed.
1264         * Scripts/run-webkit-tests:
1265         (useNewRunWebKitTests):
1266         * Scripts/update-webkit:
1267         * Scripts/webkit-build-directory:
1268         * Scripts/webkitdirs.pm:
1269         (argumentsForConfiguration):
1270         (jscProductDir):
1271         (builtDylibPathForName):
1272         (isAppleWebKit):
1273         (launcherPath):
1274         (launcherName):
1275         (checkRequiredSystemConfig):
1276         (setupCygwinEnv):
1277         (copyInspectorFrontendFiles):
1278         (setPathForRunningWebKitApp):
1279         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1280         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1281         (BaselineOptimizerTest.test_mac_future):
1282         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1283         (BaselineOptimizerTest.test_common_directory_includes_root):
1284         (BaselineOptimizerTest.test_virtual_ports_filtered):
1285         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1286         (test_parse_reviewer_text):
1287         * Scripts/webkitpy/common/config/watchlist:
1288         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1289         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
1290         * Scripts/webkitpy/port/base.py:
1291         (Port.__init__):
1292         (Port._port_flag_for_scripts):
1293         (Port._wk2_port_name):
1294         * Scripts/webkitpy/port/builders.py:
1295         * Scripts/webkitpy/port/factory.py:
1296         (platform_options):
1297         (PortFactory):
1298         (PortFactory._default_port):
1299         * Scripts/webkitpy/port/factory_unittest.py:
1300         (FactoryTest.test_gtk):
1301         * Scripts/webkitpy/port/qt.py: Removed.
1302         * Scripts/webkitpy/port/qt_unittest.py: Removed.
1303         * Scripts/webkitpy/style/checker.py:
1304         * Scripts/webkitpy/style/checker_unittest.py:
1305         (GlobalVariablesTest.test_path_rules_specifier):
1306         * Scripts/webkitpy/style/checkers/cmake.py:
1307         (CMakeChecker):
1308         * Scripts/webkitpy/style/checkers/cpp.py:
1309         (_classify_include):
1310         (check_include_line):
1311         (check_identifier_name_in_declaration):
1312         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1313         (OrderOfIncludesTest.test_classify_include):
1314         (WebKitStyleTest.test_names):
1315         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1316         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1317         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1318         (TestRebaselineTest.test_baseline_directory):
1319         * Scripts/webkitpy/tool/main.py:
1320         (WebKitPatch):
1321
1322 2013-10-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1323
1324         Unreviewed. Add myself to some watchlists.
1325
1326         * Scripts/webkitpy/common/config/watchlist:
1327
1328 2013-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1329
1330         Remove Qt builders from the flakiness dashboard.
1331
1332         * TestResultServer/static-dashboards/builders.jsonp:
1333         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1334         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1335         * TestResultServer/static-dashboards/loader_unittests.js:
1336
1337 2013-10-03  Tim Horton  <timothy_horton@apple.com>
1338
1339         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1340         https://bugs.webkit.org/show_bug.cgi?id=122299
1341
1342         Reviewed by Beth Dakin.
1343
1344         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1345         Disable threaded scrolling.
1346
1347         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1348         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1349         Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
1350
1351 2013-10-03  Anders Carlsson  <andersca@apple.com>
1352
1353         Use numeric strings in the OS version dictionary
1354         https://bugs.webkit.org/show_bug.cgi?id=122300
1355
1356         Reviewed by Mark Rowe.
1357
1358         * Scripts/webkitpy/common/system/platforminfo.py:
1359         (PlatformInfo._determine_mac_version):
1360
1361 2013-10-03  Alexey Proskuryakov  <ap@apple.com>
1362
1363         Fix LeaksViewer to load leaks results from MountainLion, not Lion.
1364
1365         Rubber-stamped by Tim Horton.
1366
1367         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1368         (LeaksViewer._displayURLPrompt):
1369
1370 2013-10-03  Dan Bernstein  <mitz@apple.com>
1371
1372         REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
1373         https://bugs.webkit.org/show_bug.cgi?id=122260
1374
1375         Reviewed by Alexey Proskuryakov.
1376
1377         For the API to work, the tests need to be compiled with a newer version of the LLVM
1378         compiler. Until the bots are updated to that version, disable the tests on 10.8.
1379
1380         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1381
1382 2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>
1383
1384         [ATK] Expose aria-invalid as a text attribute (not object attribute)
1385         https://bugs.webkit.org/show_bug.cgi?id=122015
1386
1387         Reviewed by Chris Fleizach.
1388
1389         Adapted DRT and WKTR to check the exposure of the aria-invalid
1390         attribute as a text attribute, instead of an object attribute.
1391
1392         Also, done some refactoring of the code to try to keep things
1393         simpler and more coherent, by defining new helper functions,
1394         simplifying code, moving static variables and functions into
1395         unnammed namespaces and so on, without altering the logic other
1396         than for checking the text attribute for aria-invalid.
1397
1398         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1399         (coreAttributeToAtkAttribute): Consider 'invalid' as the name of
1400         the attribute exposed by the ATK wrapper, not 'aria-invalid'.
1401         Also, never return an empty string if not falling through any of
1402         the cases checked here, and return the original attribute instead.
1403         (atkAttributeValueToCoreAttributeValue): New helper function to
1404         match the attributes values returned by the ATK wrapper with the
1405         values expected by the layout tests. Moved the mappings for the
1406         values of AXSortDirection here as well.
1407         (getAttributeSet): New helper function to retrieve a list of
1408         attributes (an AtkAttributeSet) from an AtkObject using the right
1409         API depending on whether we want the object attributes or the text
1410         attributes (in case the object implements AtkText).
1411         (getAttributeSetValueForId): Simplified by using getAttributeSet
1412         and atkAttributeValueToCoreAttributeValue. Also, added a new
1413         parameter to indicater whether we are interested in object
1414         attributes or text attributes.
1415         (getAtkAttributeSetAsString): Ditto.
1416         (attributesOfElement): Updated to pass the new required parameter
1417         to getAtkAttributeSetAsString, indicating that we want the object
1418         attributes in this case, for backwards compatibility.
1419         (indexRangeInTable): Moved up in the file into the unnammed namespace.
1420         (alterCurrentValue): Ditto.
1421         (AccessibilityUIElement::stringAttributeValue): After moving most
1422         of the code here to the new helper functions, simplified it by
1423         just checking whether the required attribute is provided as an
1424         object attribute or, if that's not the case, as a text attribute.
1425         (AccessibilityUIElement::isAttributeSupported): Ditto.
1426         (AccessibilityUIElement::intValue): Updated to pass the new
1427         required parameter to getAttributeSetValueForId, indicating that
1428         we want the object attributes in this case.
1429         (AccessibilityUIElement::hasPopup): Ditto.
1430
1431         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1432         (WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
1433         (WTR::atkAttributeValueToCoreAttributeValue): Ditto.
1434         (WTR::getAttributeSet): Ditto.
1435         (WTR::getAttributeSetValueForId): Ditto.
1436         (WTR::getAtkAttributeSetAsString): Ditto.
1437         (WTR::attributesOfElement): Ditto.
1438         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1439         (WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
1440         (WTR::AccessibilityUIElement::intValue): Ditto.
1441         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1442
1443 2013-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1444
1445         EWS build fix after the Qt EWS removal.
1446
1447         * QueueStatusServer/model/attachment.py:
1448         (Attachment._calculate_queue_positions):
1449
1450 2013-10-02  Anders Carlsson  <andersca@apple.com>
1451
1452         Remove Qt code from Tools/
1453         https://bugs.webkit.org/show_bug.cgi?id=122227
1454
1455         Reviewed by Andreas Kling.
1456
1457         * DumpRenderTree/WorkQueue.cpp:
1458         * DumpRenderTree/blackberry/src.pro: Removed.
1459         * DumpRenderTree/qt/DumpRenderTree.pro: Removed.
1460         * DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
1461         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
1462         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
1463         * DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
1464         * DumpRenderTree/qt/EventSenderQt.cpp: Removed.
1465         * DumpRenderTree/qt/EventSenderQt.h: Removed.
1466         * DumpRenderTree/qt/GCControllerQt.cpp: Removed.
1467         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
1468         * DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
1469         * DumpRenderTree/qt/TestRunnerQt.h: Removed.
1470         * DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
1471         * DumpRenderTree/qt/TextInputControllerQt.h: Removed.
1472         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
1473         * DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
1474         * DumpRenderTree/qt/fonts/AHEM____.TTF: Removed.
1475         * DumpRenderTree/qt/resources/user.css: Removed.
1476         * DumpRenderTree/qt/testplugin.cpp: Removed.
1477         * DumpRenderTree/qt/testplugin.h: Removed.
1478         * ImageDiff/ImageDiff.pro: Removed.
1479         * ImageDiff/qt/ImageDiff.cpp: Removed.
1480         * MiniBrowser/qt/BrowserWindow.cpp: Removed.
1481         * MiniBrowser/qt/BrowserWindow.h: Removed.
1482         * MiniBrowser/qt/MiniBrowser.pro: Removed.
1483         * MiniBrowser/qt/MiniBrowser.qrc: Removed.
1484         * MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
1485         * MiniBrowser/qt/MiniBrowserApplication.h: Removed.
1486         * MiniBrowser/qt/UrlLoader.cpp: Removed.
1487         * MiniBrowser/qt/UrlLoader.h: Removed.
1488         * MiniBrowser/qt/icons/checkbox_checked.png: Removed.
1489         * MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
1490         * MiniBrowser/qt/icons/contents_width.png: Removed.
1491         * MiniBrowser/qt/icons/favicon.png: Removed.
1492         * MiniBrowser/qt/icons/find.png: Removed.
1493         * MiniBrowser/qt/icons/folder.png: Removed.
1494         * MiniBrowser/qt/icons/info.png: Removed.
1495         * MiniBrowser/qt/icons/next.png: Removed.
1496         * MiniBrowser/qt/icons/plus.png: Removed.
1497         * MiniBrowser/qt/icons/previous.png: Removed.
1498         * MiniBrowser/qt/icons/refresh.png: Removed.
1499         * MiniBrowser/qt/icons/stop.png: Removed.
1500         * MiniBrowser/qt/icons/titlebar.png: Removed.
1501         * MiniBrowser/qt/icons/touch.png: Removed.
1502         * MiniBrowser/qt/icons/touchpoint.png: Removed.
1503         * MiniBrowser/qt/icons/up.png: Removed.
1504         * MiniBrowser/qt/js/MultiSelect.js: Removed.
1505         * MiniBrowser/qt/main.cpp: Removed.
1506         * MiniBrowser/qt/qml/AlertDialog.qml: Removed.
1507         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
1508         * MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
1509         * MiniBrowser/qt/qml/CheckBox.qml: Removed.
1510         * MiniBrowser/qt/qml/ColorChooser.qml: Removed.
1511         * MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
1512         * MiniBrowser/qt/qml/Dialog.qml: Removed.
1513         * MiniBrowser/qt/qml/DialogButton.qml: Removed.
1514         * MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
1515         * MiniBrowser/qt/qml/FilePicker.qml: Removed.
1516         * MiniBrowser/qt/qml/ItemSelector.qml: Removed.
1517         * MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
1518         * MiniBrowser/qt/qml/PromptDialog.qml: Removed.
1519         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
1520         * MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
1521         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
1522         * MiniBrowser/qt/raw/DerivedSources.pri: Removed.
1523         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
1524         * MiniBrowser/qt/raw/Target.pri: Removed.
1525         * MiniBrowser/qt/raw/View.cpp: Removed.
1526         * MiniBrowser/qt/raw/View.h: Removed.
1527         * MiniBrowser/qt/utils.cpp: Removed.
1528         * MiniBrowser/qt/utils.h: Removed.
1529         * QtTestBrowser/QtTestBrowser.pro: Removed.
1530         * QtTestBrowser/QtTestBrowser.qrc: Removed.
1531         * QtTestBrowser/cookiejar.cpp: Removed.
1532         * QtTestBrowser/cookiejar.h: Removed.
1533         * QtTestBrowser/favicon.png: Removed.
1534         * QtTestBrowser/fpstimer.cpp: Removed.
1535         * QtTestBrowser/fpstimer.h: Removed.
1536         * QtTestBrowser/launcherwindow.cpp: Removed.
1537         * QtTestBrowser/launcherwindow.h: Removed.
1538         * QtTestBrowser/locationedit.cpp: Removed.
1539         * QtTestBrowser/locationedit.h: Removed.
1540         * QtTestBrowser/mainwindow.cpp: Removed.
1541         * QtTestBrowser/mainwindow.h: Removed.
1542         * QtTestBrowser/qttestbrowser.cpp: Removed.
1543         * QtTestBrowser/urlloader.cpp: Removed.
1544         * QtTestBrowser/urlloader.h: Removed.
1545         * QtTestBrowser/useragentlist.txt: Removed.
1546         * QtTestBrowser/utils.cpp: Removed.
1547         * QtTestBrowser/utils.h: Removed.
1548         * QtTestBrowser/webinspector.h: Removed.
1549         * QtTestBrowser/webpage.cpp: Removed.
1550         * QtTestBrowser/webpage.h: Removed.
1551         * QtTestBrowser/webview.cpp: Removed.
1552         * QtTestBrowser/webview.h: Removed.
1553         * TestWebKitAPI/DerivedSources.pri: Removed.
1554         * TestWebKitAPI/InjectedBundle.pri: Removed.
1555         * TestWebKitAPI/PlatformWebView.h:
1556         * TestWebKitAPI/TestWebKitAPI.pri: Removed.
1557         * TestWebKitAPI/TestWebKitAPI.pro: Removed.
1558         * TestWebKitAPI/Tests.pri: Removed.
1559         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
1560         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
1561         * TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
1562         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
1563         * TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
1564         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
1565         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
1566         * TestWebKitAPI/qt/main.cpp: Removed.
1567         * Tools.pro: Removed.
1568         * WebKitTestRunner/DerivedSources.pri: Removed.
1569         * WebKitTestRunner/EventSenderProxy.h:
1570         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
1571         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
1572         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1573         (WTR::InjectedBundlePage::resetAfterTest):
1574         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1575         (WTR::InjectedBundlePage::didClearWindowForFrame):
1576         * WebKitTestRunner/InjectedBundle/Target.pri: Removed.
1577         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1578         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
1579         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
1580         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
1581         * WebKitTestRunner/PlatformWebView.h:
1582         * WebKitTestRunner/Target.pri: Removed.
1583         * WebKitTestRunner/TestController.cpp:
1584         (WTR::TestController::resetStateToConsistentValues):
1585         * WebKitTestRunner/TestController.h:
1586         * WebKitTestRunner/WebKitTestRunner.pro: Removed.
1587         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
1588         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
1589         * WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
1590         * WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
1591         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
1592         * WebKitTestRunner/qt/main.cpp: Removed.
1593         * WebKitTestRunner/qt/resources/user.css: Removed.
1594         * qmake/.qmake.cache: Removed.
1595         * qmake/.qmake.conf: Removed.
1596         * qmake/README: Removed.
1597         * qmake/config.tests/README: Removed.
1598         * qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
1599         * qmake/config.tests/fontconfig/fontconfig.pro: Removed.
1600         * qmake/config.tests/gccdepends/empty.cpp: Removed.
1601         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
1602         * qmake/config.tests/glx/glx.cpp: Removed.
1603         * qmake/config.tests/glx/glx.pro: Removed.
1604         * qmake/config.tests/gnuld/gnuld.pro: Removed.
1605         * qmake/config.tests/gnuld/main.cpp: Removed.
1606         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
1607         * qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
1608         * qmake/config.tests/libXrender/libXrender.cpp: Removed.
1609         * qmake/config.tests/libXrender/libXrender.pro: Removed.
1610         * qmake/config.tests/libwebp/libwebp.cpp: Removed.
1611         * qmake/config.tests/libwebp/libwebp.pro: Removed.
1612         * qmake/config.tests/libxml2/libxml2.cpp: Removed.
1613         * qmake/config.tests/libxml2/libxml2.pro: Removed.
1614         * qmake/config.tests/libxslt/libxslt.cpp: Removed.
1615         * qmake/config.tests/libxslt/libxslt.pro: Removed.
1616         * qmake/config.tests/libzlib/libzlib.cpp: Removed.
1617         * qmake/config.tests/libzlib/libzlib.pro: Removed.
1618         * qmake/dump-features.pl: Removed.
1619         * qmake/mkspecs/features/configure.prf: Removed.
1620         * qmake/mkspecs/features/default_post.prf: Removed.
1621         * qmake/mkspecs/features/default_pre.prf: Removed.
1622         * qmake/mkspecs/features/features.prf: Removed.
1623         * qmake/mkspecs/features/features.pri: Removed.
1624         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
1625         * qmake/mkspecs/features/functions.prf: Removed.
1626         * qmake/mkspecs/features/gprof.prf: Removed.
1627         * qmake/mkspecs/features/mac/default_post.prf: Removed.
1628         * qmake/mkspecs/features/mac/default_pre.prf: Removed.
1629         * qmake/mkspecs/features/minimal_qt.prf: Removed.
1630         * qmake/mkspecs/features/production_build.prf: Removed.
1631         * qmake/mkspecs/features/rpath.prf: Removed.
1632         * qmake/mkspecs/features/unix/default_post.prf: Removed.
1633         * qmake/mkspecs/features/unix/default_pre.prf: Removed.
1634         * qmake/mkspecs/features/unix/icc.prf: Removed.
1635         * qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
1636         * qmake/mkspecs/features/valgrind.prf: Removed.
1637         * qmake/mkspecs/features/webkit_modules.prf: Removed.
1638         * qmake/mkspecs/features/win32/default_post.prf: Removed.
1639         * qmake/mkspecs/features/win32/default_pre.prf: Removed.
1640         * qmake/mkspecs/modules/angle.prf: Removed.
1641         * qmake/mkspecs/modules/javascriptcore.prf: Removed.
1642         * qmake/mkspecs/modules/webcore.prf: Removed.
1643         * qmake/mkspecs/modules/webkit1.prf: Removed.
1644         * qmake/mkspecs/modules/webkit2.prf: Removed.
1645         * qmake/mkspecs/modules/wtf.prf: Removed.
1646
1647 2013-10-02  Tim Horton  <timothy_horton@apple.com>
1648
1649         [mac] Stop using DrawingAreaImpl on PLATFORM(MAC) 
1650         https://bugs.webkit.org/show_bug.cgi?id=121859
1651         <rdar://problem/15069359>
1652
1653         Reviewed by Anders Carlsson.
1654
1655         * WebKitTestRunner/TestInvocation.cpp:
1656         (WTR::shouldUseThreadedScrolling):
1657         (WTR::updateThreadedScrollingForCurrentTest):
1658         (WTR::TestInvocation::invoke):
1659         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1660         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
1661         (WTR::PlatformWebView::PlatformWebView):
1662         (WTR::PlatformWebView::viewSupportsOptions):
1663         Rename the tiled drawing switch to threaded scrolling, since that's really
1664         all it switches now that we use tiled drawing everywhere.
1665
1666         Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
1667         and to more closely match the case we're interested in testing.
1668
1669 2013-10-02  Anders Carlsson  <andersca@apple.com>
1670
1671         Move AHEM____.TTF from qt/fonts/ to fonts/.
1672
1673         Rubber-stamped by Andreas Kling.
1674
1675         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1676         * DumpRenderTree/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1677
1678 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
1679
1680         Remove Qt bots and EWS from trunk.
1681         https://bugs.webkit.org/show_bug.cgi?id=122210.
1682
1683         Reviewed by Allan Sandfeld Jensen.
1684
1685         Remove Qt buil dbots.
1686
1687         * BuildSlaveSupport/build.webkit.org-config/config.json:
1688         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1689         (appendCustomBuildFlags):
1690         (RunGtkAPITests.getText2):
1691         (Factory.__init__):
1692         (TestFactory.__init__):
1693         (BuildAndTestFactory.__init__):
1694         (loadBuilderConfig):
1695         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1696
1697 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
1698
1699         Remove Qt bots and EWS from trunk.
1700         https://bugs.webkit.org/show_bug.cgi?id=122210.
1701
1702         Reviewed by Allan Sandfeld Jensen.
1703
1704         Remove Qt EWS bots.
1705
1706         * QueueStatusServer/config/queues.py:
1707         * Scripts/webkitpy/common/config/ews.json:
1708
1709 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1710
1711         Fix singular labels for test failures.
1712
1713         https://bugs.webkit.org/show_bug.cgi?id=122200
1714
1715         Reviewed by Joseph Pecoraro.
1716
1717         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1718         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1719
1720 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1721
1722         Don't keep appending iterations each time the queue updates.
1723
1724         https://bugs.webkit.org/show_bug.cgi?id=122198
1725
1726         Reviewed by Joseph Pecoraro.
1727
1728         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1729         (BuildbotQueue.prototype.update):
1730
1731 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1732
1733         Properly sort iterations in the Dashboard by revision for out-of-order queues.
1734
1735         https://bugs.webkit.org/show_bug.cgi?id=122196
1736
1737         Reviewed by Brent Fulgham.
1738
1739         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1740         (BuildbotIteration):
1741         (BuildbotIteration.prototype.update):
1742         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1743         (BuildbotQueue.prototype.update):
1744         (BuildbotQueue.prototype.sortIterations):
1745
1746 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1747
1748         Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
1749
1750         Also fix some URLs to not have extras slashes and add a page title.
1751
1752         https://bugs.webkit.org/show_bug.cgi?id=122192
1753
1754         Reviewed by Joseph Pecoraro.
1755
1756         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1757         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1758         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1759         (WebKitBuildbot.prototype.buildLogURLForIteration):
1760         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
1761         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
1762         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1763
1764 2013-10-01  Alexey Proskuryakov  <ap@apple.com>
1765
1766         [Mac] Set NSApplication current event while sending events directly to views
1767         https://bugs.webkit.org/show_bug.cgi?id=122179
1768
1769         Reviewed by Darin Adler.
1770
1771         DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
1772         which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
1773         use the current event.
1774
1775         * DumpRenderTree/mac/EventSendingController.mm:
1776         (-[EventSendingController mouseDown:withModifiers:]):
1777         (-[EventSendingController mouseUp:withModifiers:]):
1778         (-[EventSendingController mouseMoveToX:Y:]):
1779         (-[EventSendingController mouseScrollByX:andY:continuously:]):
1780         (-[EventSendingController contextClick]):
1781         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1782         * WebKitTestRunner/mac/EventSenderProxy.mm:
1783         (WTR::EventSenderProxy::mouseDown):
1784         (WTR::EventSenderProxy::mouseUp):
1785         (WTR::EventSenderProxy::mouseMoveTo):
1786         (WTR::EventSenderProxy::keyDown):
1787         (WTR::EventSenderProxy::mouseScrollBy):
1788         Update the current event. We were already using the SPI in WebKit.
1789
1790 2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>
1791
1792         Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
1793         https://bugs.webkit.org/show_bug.cgi?id=122183
1794
1795         Reviewed by Timothy Hatcher.
1796
1797         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1798         (BuildbotIteration.prototype.update):
1799
1800 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1801
1802         Tweaks to the Buildbot Dashboard
1803
1804         https://bugs.webkit.org/show_bug.cgi?id=122169
1805
1806         Reviewed by Alexey Proskuryakov.
1807
1808         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1809         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
1810         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1811         (BuildbotQueueView.prototype.revisionLinksForIteration):
1812         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1813         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1814         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
1815         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1816         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1817         (WebKitBuildbot.prototype.buildLogURLForIteration):
1818         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1819
1820 2013-10-01  Commit Queue  <commit-queue@webkit.org>
1821
1822         Unreviewed, rolling out r156725.
1823         http://trac.webkit.org/changeset/156725
1824         https://bugs.webkit.org/show_bug.cgi?id=122176
1825
1826         broke all the mismatch tests again (Requested by thorton on
1827         #webkit).
1828
1829         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1830         (WTR::PlatformWebView::PlatformWebView):
1831
1832 2013-10-01  Alex Christensen  <achristensen@webkit.org>
1833
1834         Implemented createWebViewWithRequest in WinLauncher.
1835         https://bugs.webkit.org/show_bug.cgi?id=122069
1836
1837         Reviewed by Brent Fulgham.
1838
1839         * WinLauncher/PrintWebUIDelegate.cpp:
1840         (PrintWebUIDelegate::createWebViewWithRequest): Added.
1841         * WinLauncher/PrintWebUIDelegate.h:
1842         Removed createWebViewWithRequest stub.
1843
1844 2013-10-01  Tim Horton  <timothy_horton@apple.com>
1845
1846         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
1847         https://bugs.webkit.org/show_bug.cgi?id=122006
1848         <rdar://problem/15095197>
1849
1850         Reviewed by Dean Jackson.
1851
1852         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1853         (WTR::PlatformWebView::PlatformWebView):
1854         Layer-back the root view in WebKitTestRunner's window, to work around a bug
1855         where the window server snapshot API returns blank snapshots.
1856
1857         Re-landing after r156724, this should not break everything now.
1858
1859 2013-10-01  Tim Horton  <timothy_horton@apple.com>
1860
1861         [mac] 1x emulation on Retina hardware shouldn't use SPI
1862         https://bugs.webkit.org/show_bug.cgi?id=122152
1863         <rdar://problem/15119384>
1864
1865         Reviewed by Anders Carlsson.
1866
1867         * DumpRenderTree/mac/DumpRenderTree.mm:
1868         (createWebViewAndOffscreenWindow):
1869         (main):
1870         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1871         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1872         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1873         (WTR::PlatformWebView::PlatformWebView):
1874         * WebKitTestRunner/mac/main.mm:
1875         (main):
1876         Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
1877
1878 2013-09-30  Sam Weinig  <sam@webkit.org>
1879
1880         check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
1881         https://bugs.webkit.org/show_bug.cgi?id=116474
1882
1883         Reviewed by Ryosuke Niwa.
1884
1885         * Scripts/webkitpy/style/checkers/cpp.py:
1886         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1887
1888 2013-09-30  Sam Weinig  <sam@webkit.org>
1889
1890         Remove support for DOMFileSystem
1891         https://bugs.webkit.org/show_bug.cgi?id=122137
1892
1893         Reviewed by Anders Carlsson.
1894
1895         * Scripts/webkitperl/FeatureList.pm:
1896         * Scripts/webkitpy/style/checkers/cpp.py:
1897         (check_spacing):
1898         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1899         (CppStyleTest.test_spacing_for_binary_ops):
1900         * qmake/mkspecs/features/features.pri:
1901
1902 2013-09-30  Mark Rowe  <mrowe@apple.com>
1903
1904         More build fixage for builds with SDKs.
1905
1906         * WebKitTestRunner/Configurations/Base.xcconfig:
1907         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
1908
1909 2013-09-30  Timothy Hatcher  <timothy@apple.com>
1910
1911         Add initial version of a new Buildbot dashboard view.
1912
1913         https://bugs.webkit.org/show_bug.cgi?id=122131
1914
1915         Reviewed by Alexey Proskuryakov.
1916
1917         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
1918         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
1919         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
1920         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
1921         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
1922         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
1923         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
1924         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
1925         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
1926         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
1927         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
1928         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
1929         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
1930         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
1931         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
1932         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
1933         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
1934         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
1935         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
1936         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
1937         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
1938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
1939         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
1940         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
1941         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
1942         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
1943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
1944         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
1945         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
1946         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
1947         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
1948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
1949
1950 2013-09-30  Benjamin Poulain  <benjamin@webkit.org>
1951
1952         Remove the code guarded by STYLE_SCOPED
1953         https://bugs.webkit.org/show_bug.cgi?id=122123
1954
1955         Reviewed by Anders Carlsson.
1956
1957         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1958         (resetDefaultsToConsistentValues):
1959         * Scripts/webkitperl/FeatureList.pm:
1960         * qmake/mkspecs/features/features.pri:
1961
1962 2013-09-30  Mark Rowe  <mrowe@apple.com>
1963
1964         Fix the build when building against an SDK.
1965
1966         Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
1967         the compiler command lines. It can't know to do this for the system framework search paths
1968         we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
1969
1970         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
1971         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
1972
1973 2013-09-30  Brent Fulgham  <bfulgham@apple.com>
1974
1975         [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
1976
1977         A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
1978         it to be double-freed.
1979
1980         * WinLauncher/WinLauncher.cpp:
1981         (EditProc): Be explicit about type passed to loadURL.
1982         (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
1983         that reallocating the BSTR is done with the knowledge of the smart pointer.
1984
1985 2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1986
1987         [Qt] Fix force_static_libs_as_shared in WebKit2
1988         https://bugs.webkit.org/show_bug.cgi?id=121961
1989
1990         Reviewed by Csaba Osztrogonác.
1991
1992         Get rid of the unused WebKit2QML library
1993
1994         * qmake/mkspecs/features/webkit_modules.prf:
1995         * qmake/mkspecs/modules/webkit2qml.prf: Removed.
1996
1997 2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>
1998
1999         [EFL] Fix incorrect click counting in EventSenderProxy
2000         https://bugs.webkit.org/show_bug.cgi?id=122098
2001
2002         Reviewed by Gyuyoung Kim.
2003
2004         Previously used two types of recording time, which conflicted with each other.
2005
2006         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2007         (WTR::EventSenderProxy::mouseUp):
2008
2009 2013-09-30  Zan Dobersek  <zdobersek@igalia.com>
2010
2011         [webkitpy] Make the Xvfb screen depth overridable
2012         https://bugs.webkit.org/show_bug.cgi?id=122089
2013
2014         Reviewed by Gyuyoung Kim.
2015
2016         Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
2017         was set. The default value that's used if the variable wasn't set is 24.
2018
2019         * Scripts/webkitpy/port/xvfbdriver.py:
2020         (XvfbDriver._xvfb_screen_depth):
2021         (XvfbDriver._start):
2022         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2023         (XvfbDriverTest.make_driver):
2024         (XvfbDriverTest.test_start_no_pixel_tests):
2025         (XvfbDriverTest.test_start_pixel_tests):
2026         (XvfbDriverTest.test_start_arbitrary_worker_number):
2027         (XvfbDriverTest.test_next_free_display):
2028         (XvfbDriverTest.test_start_next_worker):
2029
2030 2013-09-29  Mark Rowe  <mrowe@apple.com>
2031
2032         Fix the Lion build.
2033
2034         Ensure that C++ and Objective-C++ files build with the right compiler flags.
2035
2036         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2037         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2038
2039 2013-09-28  Mark Rowe  <mrowe@apple.com>
2040
2041         Fix some failures with newer versions of clang.
2042
2043         Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
2044         usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
2045         as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
2046         flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
2047         in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
2048
2049         Reviewed by Dan Bernstein.
2050
2051         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2052         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2053         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2054         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2055         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2056         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2057         * WebKitTestRunner/Configurations/Base.xcconfig:
2058         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2059         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2060         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2061         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2062
2063 2013-09-27  Commit Queue  <commit-queue@webkit.org>
2064
2065         Unreviewed, rolling out r156569.
2066         http://trac.webkit.org/changeset/156569
2067         https://bugs.webkit.org/show_bug.cgi?id=122035
2068
2069         broke a lot of mismatch tests (Requested by thorton on
2070         #webkit).
2071
2072         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2073         (WTR::PlatformWebView::PlatformWebView):
2074
2075 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2076
2077         Don't retry failures on Apple MountainLion Release WK1 tester
2078         https://bugs.webkit.org/show_bug.cgi?id=122026
2079
2080         Reviewed by Mark Rowe.
2081
2082         * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
2083         on this bot.
2084
2085 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2086
2087         Don't hardcode builder specific configuration in buildbot master.cfg
2088         https://bugs.webkit.org/show_bug.cgi?id=122023
2089
2090         Reviewed by Mark Rowe.
2091
2092         * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
2093         property to Qt Mountain Lion Release, making it run pixel tests.
2094
2095         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2096         (RunWebKitTests.start): Use additionalArguments.
2097         (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
2098
2099 2013-09-27  Tim Horton  <timothy_horton@apple.com>
2100
2101         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2102         https://bugs.webkit.org/show_bug.cgi?id=122006
2103         <rdar://problem/15095197>
2104
2105         Reviewed by Dean Jackson.
2106
2107         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2108         (WTR::PlatformWebView::PlatformWebView):
2109         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2110         where the window server snapshot API returns blank snapshots.
2111
2112 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2113
2114         [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
2115         https://bugs.webkit.org/show_bug.cgi?id=106924
2116
2117         Reviewed by Chris Fleizach.
2118
2119         Consider headings levels as values to be returned in intValue()
2120         both in DRT and WKTR, so we can share more tests with other ports.
2121
2122         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2123         (AccessibilityUIElement::intValue): Consider headings too.
2124         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2125         (WTR::AccessibilityUIElement::intValue): Ditto.
2126
2127 2013-09-26  Darin Adler  <darin@apple.com>
2128
2129         rename KURL to URL
2130         https://bugs.webkit.org/show_bug.cgi?id=16214
2131
2132         Reviewed by Andreas Kling.
2133
2134         * many files: Renamed, using script.
2135
2136 2013-09-27  Darin Adler  <darin@apple.com>
2137
2138         Fix Python scripts test failures.
2139
2140         * Scripts/webkitpy/style/checkers/cpp.py:
2141         (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
2142         now, not by the checker itself.
2143
2144 2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
2145
2146         [GTK][WK2] Logging of accessibility events is not disabled between tests
2147         https://bugs.webkit.org/show_bug.cgi?id=121957
2148
2149         Reviewed by Mario Sanchez Prada.
2150
2151         Fixed an issue in AccessibilityNotificationHandler where the destructor
2152         was not disconnecting accessibility event callbacks if logging was on.
2153         The decision of disconnecting events can solely rely on the existence of
2154         notification handlers because logging uses the global notification
2155         handler.
2156
2157         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2158         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
2159         disconnection when logging is on.
2160
2161 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
2162
2163         Add general CMakeLists.txt for DRT
2164         https://bugs.webkit.org/show_bug.cgi?id=119268
2165
2166         Reviewed by Gyuyoung Kim.
2167
2168         The new file allows better sharing between ports.
2169
2170         * CMakeLists.txt:
2171         * DumpRenderTree/CMakeLists.txt: Added.
2172         * DumpRenderTree/PlatformEfl.cmake: Added.
2173         * DumpRenderTree/efl/CMakeLists.txt: Removed.
2174
2175 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2176
2177         [Qt] Fix force_static_libs_as_shared in WebKit2
2178         https://bugs.webkit.org/show_bug.cgi?id=121961
2179
2180         Reviewed by Csaba Osztrogonác.
2181
2182         Reenable force_static_libs_as_shared when building WebKit2.
2183
2184         * qmake/mkspecs/features/default_post.prf:
2185
2186 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2187
2188         [Qt] Mock implementations of positioning and orientation not used
2189         https://bugs.webkit.org/show_bug.cgi?id=121956
2190
2191         Reviewed by Csaba Osztrogonác.
2192
2193         Move production_build checks to sanitizeFeatures where its value is actually known.
2194
2195         * qmake/mkspecs/features/features.prf:
2196         * qmake/mkspecs/features/features.pri:
2197
2198 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2199
2200         [ATK] Normalize checks in entry points for DRT and WKTR
2201         https://bugs.webkit.org/show_bug.cgi?id=121959
2202
2203         Reviewed by Chris Fleizach.
2204
2205         Always check if we have a proper instance of AtkObject,
2206         implementing the interfaces that we might need for each case, at
2207         the entry point of every method of AccessibilityUIElement for ATK,
2208         and do those checks in an uniform way across DRT and WKTR, to
2209         avoid confusion and issues when modifying these files in the future.
2210
2211         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2212         (AccessibilityUIElement::getChildren): Use normalized checks.
2213         (AccessibilityUIElement::getChildrenWithRange): Ditto.
2214         (AccessibilityUIElement::rowCount): Ditto.
2215         (AccessibilityUIElement::columnCount): Ditto.
2216         (AccessibilityUIElement::childrenCount): Ditto.
2217         (AccessibilityUIElement::elementAtPoint): Ditto.
2218         (AccessibilityUIElement::getChildAtIndex): Ditto.
2219         (AccessibilityUIElement::allAttributes): Ditto.
2220         (AccessibilityUIElement::titleUIElement): Ditto.
2221         (AccessibilityUIElement::parentElement): Ditto.
2222         (AccessibilityUIElement::attributesOfChildren): Ditto.
2223         (AccessibilityUIElement::role): Ditto.
2224         (AccessibilityUIElement::title): Ditto.
2225         (AccessibilityUIElement::description): Ditto.
2226         (AccessibilityUIElement::stringValue): Ditto.
2227         (AccessibilityUIElement::language): Ditto.
2228         (AccessibilityUIElement::x): Ditto.
2229         (AccessibilityUIElement::y): Ditto.
2230         (AccessibilityUIElement::width): Ditto.
2231         (AccessibilityUIElement::height): Ditto.
2232         (AccessibilityUIElement::orientation): Ditto.
2233         (AccessibilityUIElement::intValue): Ditto.
2234         (AccessibilityUIElement::minValue): Ditto.
2235         (AccessibilityUIElement::maxValue): Ditto.
2236         (indexRangeInTable): Ditto.
2237         (AccessibilityUIElement::cellForColumnAndRow): Ditto.
2238         (AccessibilityUIElement::stringAttributeValue): Ditto.
2239         (alterCurrentValue): Ditto.
2240         (AccessibilityUIElement::press): Ditto.
2241         (AccessibilityUIElement::documentEncoding): Ditto.
2242         (AccessibilityUIElement::documentURI): Ditto.
2243         (AccessibilityUIElement::hasPopup): Ditto.
2244
2245         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2246         (WTR::indexRangeInTable): Use normalized checks.
2247         (WTR::alterCurrentValue): Ditto.
2248         (WTR::AccessibilityUIElement::getChildren): Ditto.
2249         (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
2250         (WTR::AccessibilityUIElement::childrenCount): Ditto.
2251         (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
2252         (WTR::AccessibilityUIElement::indexOfChild): Ditto.
2253         (WTR::AccessibilityUIElement::childAtIndex): Ditto.
2254         (WTR::AccessibilityUIElement::titleUIElement): Ditto.
2255         (WTR::AccessibilityUIElement::parentElement): Ditto.
2256         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
2257         (WTR::AccessibilityUIElement::allAttributes): Ditto.
2258         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2259         (WTR::AccessibilityUIElement::role): Ditto.
2260         (WTR::AccessibilityUIElement::title): Ditto.
2261         (WTR::AccessibilityUIElement::description): Ditto.
2262         (WTR::AccessibilityUIElement::orientation): Ditto.
2263         (WTR::AccessibilityUIElement::stringValue): Ditto.
2264         (WTR::AccessibilityUIElement::language): Ditto.
2265         (WTR::AccessibilityUIElement::x): Ditto.
2266         (WTR::AccessibilityUIElement::y): Ditto.
2267         (WTR::AccessibilityUIElement::width): Ditto.
2268         (WTR::AccessibilityUIElement::height): Ditto.
2269         (WTR::AccessibilityUIElement::intValue): Ditto.
2270         (WTR::AccessibilityUIElement::minValue): Ditto.
2271         (WTR::AccessibilityUIElement::maxValue): Ditto.
2272         (WTR::AccessibilityUIElement::rowCount): Ditto.
2273         (WTR::AccessibilityUIElement::columnCount): Ditto.
2274         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
2275         (WTR::AccessibilityUIElement::press): Ditto.
2276         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
2277         (WTR::AccessibilityUIElement::documentURI): Ditto.
2278         (WTR::AccessibilityUIElement::hasPopup): Ditto.
2279
2280 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2281
2282         [ATK] accessibility/aria-sort.html is failing after r156409
2283         https://bugs.webkit.org/show_bug.cgi?id=121947
2284
2285         Reviewed by Chris Fleizach.
2286
2287         Implement AccessibilityUIElement::isSupported for the ATK
2288         platforms, just by checking whether we have an associated object
2289         attribute exposed for the wrapper object matching the required
2290         attribute in the layout test (e.g "AXSortDirection" -> "sort").
2291
2292         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2293         (AccessibilityUIElement::isAttributeSupported): Implemented.
2294         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2295         (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
2296
2297 2013-09-26  Eric Carlson  <eric.carlson@apple.com>
2298
2299         [MediaStream] make MediaStream testable
2300         https://bugs.webkit.org/show_bug.cgi?id=121967
2301
2302         Reviewed by Dean Jackson.
2303
2304         * DumpRenderTree/mac/UIDelegate.mm:
2305         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
2306             user media request policy delegate.
2307
2308 2013-09-26  Brian J. Burg  <burg@cs.washington.edu>
2309
2310         build-webkit --inspector-frontend should copy WebInspectorUI files
2311         https://bugs.webkit.org/show_bug.cgi?id=117851
2312
2313         Reviewed by Joseph Pecoraro.
2314
2315         Change the --inspector-frontend build option to additionally build/copy 
2316         WebInspectorUI by setting it as the only project that needs to be built.
2317
2318         * Scripts/build-webkit:
2319
2320 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2321
2322         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2323         https://bugs.webkit.org/show_bug.cgi?id=121951
2324
2325         Reviewed by Carlos Garcia Campos.
2326
2327         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2328         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2329         500 layout tests that trigger accelerated compositing to be used.
2330
2331         * Scripts/webkitpy/port/xvfbdriver.py:
2332         (XvfbDriver._start):
2333         * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
2334         (XvfbDriverTest.test_start_no_pixel_tests):
2335         (XvfbDriverTest.test_start_pixel_tests):
2336         (XvfbDriverTest.test_start_arbitrary_worker_number):
2337         (XvfbDriverTest.test_next_free_display):
2338         (XvfbDriverTest.test_start_next_worker):
2339
2340 2013-09-26  Tim Horton  <timothy_horton@apple.com>
2341
2342         Tiled drawing should not imply threaded scrolling
2343         https://bugs.webkit.org/show_bug.cgi?id=121874
2344         <rdar://problem/15071494>
2345
2346         Reviewed by Sam Weinig.
2347
2348         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2349         (WTR::PlatformWebView::PlatformWebView):
2350         The existing tiled-drawing layout tests require threaded scrolling to be enabled.
2351
2352 2013-09-26  Commit Queue  <commit-queue@webkit.org>
2353
2354         Unreviewed, rolling out r156457.
2355         http://trac.webkit.org/changeset/156457
2356         https://bugs.webkit.org/show_bug.cgi?id=121960
2357
2358         Broke webkitpy tests. (Requested by kling on #webkit).
2359
2360         * Scripts/webkitpy/port/xvfbdriver.py:
2361         (XvfbDriver._start):
2362
2363 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2364
2365         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2366         https://bugs.webkit.org/show_bug.cgi?id=121951
2367
2368         Reviewed by Carlos Garcia Campos.
2369
2370         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2371         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2372         500 layout tests that trigger accelerated compositing to be used.
2373
2374         * Scripts/webkitpy/port/xvfbdriver.py:
2375         (XvfbDriver._start):
2376
2377 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2378
2379         Removed check for Apple Application Support directory in WinCairo port.
2380         https://bugs.webkit.org/show_bug.cgi?id=121869
2381
2382         Reviewed by Brent Fulgham.
2383
2384         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2385         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2386         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2387         Use DLLLauncherWinCairo.props for WinCairo ports.
2388         * win/DLLLauncher/DLLLauncherMain.cpp:
2389         (wWinMain):
2390         Don't call modifyPath to check for AAS in the WinCairo port.
2391         * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
2392
2393 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2394
2395         Enabled AssembleBuildLogs on WinCairo port.
2396         https://bugs.webkit.org/show_bug.cgi?id=121923
2397
2398         Reviewed by Brent Fulgham.
2399
2400         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2401         Fixed reference to README, added WinCairo configurations.
2402         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
2403         Fixed reference to README.
2404         * win/AssembleBuildLogs/AssembleLogs.cmd:
2405         Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
2406         * win/AssembleBuildLogs/README: Fixed spelling.
2407
2408 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2409
2410         [WIN] Fix MSVC C4146 compiler warning
2411         https://bugs.webkit.org/show_bug.cgi?id=121838
2412
2413         Reviewed by Brent Fulgham.
2414
2415         Fix some variables from unsinged to int to fix the compiler warning
2416         "unary minus operator applied to unsigned type, result still unsigned".
2417
2418         * DumpRenderTree/WorkQueueItem.h:
2419         (BackItem::BackItem):
2420         (ForwardItem::ForwardItem):
2421         * DumpRenderTree/win/DumpRenderTree.cpp:
2422         (createWebViewAndOffscreenWindow):
2423
2424 2013-09-25  Zan Dobersek  <zdobersek@igalia.com>
2425
2426         [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
2427         https://bugs.webkit.org/show_bug.cgi?id=121256
2428
2429         Reviewed by Martin Robinson.
2430
2431         Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
2432         The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
2433
2434         * BuildSlaveSupport/build.webkit.org-config/config.json:
2435
2436 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2437
2438         Add style checker for CMake lists
2439         https://bugs.webkit.org/show_bug.cgi?id=121764
2440
2441         Reviewed by Ryosuke Niwa.
2442
2443         Add an additional check to make sure that list of files are sorted.
2444         Exclude lists of include directories for now, since the order
2445         can be importent for compilation of some files.
2446
2447         * Scripts/webkitpy/style/checkers/cmake.py:
2448         (CMakeChecker.check):
2449         (CMakeChecker._check_indent):
2450         (CMakeChecker):
2451         (CMakeChecker._check_list_order):
2452         (CMakeChecker._list_item_path):
2453         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2454         (CMakeCheckerTest.test_check):
2455
2456 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2457
2458         CMakeChecker takes unusually long time to run
2459         https://bugs.webkit.org/show_bug.cgi?id=105662
2460
2461         Reviewed by Ryosuke Niwa.
2462
2463         Move the caching mechanism for regular expression of the C++ checker into
2464         a common file and use it for the CMake and ChangeLog checkers too.
2465
2466         * Scripts/webkitpy/style/checkers/changelog.py:
2467         (ChangeLogChecker.check_entry):
2468         * Scripts/webkitpy/style/checkers/cmake.py:
2469         (CMakeChecker._process_line):
2470         (CMakeChecker._check_no_space_cmds):
2471         (CMakeChecker._check_one_space_cmds):
2472         (CMakeChecker._check_non_lowercase_cmd):
2473         * Scripts/webkitpy/style/checkers/common.py:
2474         (match):
2475         (search):
2476         (searchIgnorecase):
2477         (sub):
2478         (subn):
2479         * Scripts/webkitpy/style/checkers/cpp.py:
2480
2481 2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2482
2483         [Qt] Fix build with Qt 5.2 QtPosition module
2484         https://bugs.webkit.org/show_bug.cgi?id=121089
2485
2486         Reviewed by Simon Hausmann.
2487
2488         QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
2489         that might depend on them.
2490
2491         * qmake/mkspecs/features/default_pre.prf:
2492         * qmake/mkspecs/features/features.prf:
2493
2494 2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>
2495
2496         [ATK] Fix style issues in AccessibilityUIElementAtk
2497         https://bugs.webkit.org/show_bug.cgi?id=121898
2498
2499         Reviewed by Chris Fleizach.
2500
2501         Avoid the '.f' suffix for float literals and use G_VALUE_INIT
2502         instead of { 0, { { 0 } } } to initialize a GValue.
2503
2504         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2505         (AccessibilityUIElement::clickPointX): Remove suffix.
2506         (AccessibilityUIElement::clickPointY): Ditto.
2507         (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
2508         (AccessibilityUIElement::minValue): Ditto.
2509         (AccessibilityUIElement::maxValue): Ditto.
2510         (AccessibilityUIElement::numberAttributeValue): Remove suffix.
2511         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2512         (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
2513         (WTR::AccessibilityUIElement::x): Ditto.
2514         (WTR::AccessibilityUIElement::y): Ditto.
2515         (WTR::AccessibilityUIElement::width): Ditto.
2516         (WTR::AccessibilityUIElement::height): Ditto.
2517         (WTR::AccessibilityUIElement::clickPointX): Ditto.
2518         (WTR::AccessibilityUIElement::clickPointY): Ditto.
2519         (WTR::AccessibilityUIElement::intValue): Ditto.
2520         (WTR::AccessibilityUIElement::minValue): Ditto.
2521         (WTR::AccessibilityUIElement::maxValue): Ditto.
2522
2523 2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
2524
2525         [EFL] accessibility/loading-iframe-sends-notification.html is failing
2526         https://bugs.webkit.org/show_bug.cgi?id=112003
2527
2528         Reviewed by Mario Sanchez Prada.
2529
2530         Enabled addNotificationListener and removeNotificationListener for EFL port.
2531
2532         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2533         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2534         (WTR::AccessibilityController::removeNotificationListener):
2535
2536 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
2537
2538         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
2539         https://bugs.webkit.org/show_bug.cgi?id=121844
2540
2541         Reviewed by Mark Hahnenberg.
2542
2543         * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
2544
2545 2013-09-24  Alexey Proskuryakov  <ap@apple.com>
2546
2547         [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
2548         https://bugs.webkit.org/show_bug.cgi?id=121854
2549
2550         Reviewed by Anders Carlsson.
2551
2552         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2553         (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
2554         settings in underlying frameworks.
2555
2556 2013-09-24  Mark Rowe  <mrowe@apple.com>
2557
2558         <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
2559
2560         Reviewed by Dan Bernstein.
2561
2562         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2563         * MiniBrowser/Configurations/Base.xcconfig:
2564         * TestWebKitAPI/Configurations/Base.xcconfig:
2565         * WebKitLauncher/Configurations/Base.xcconfig:
2566         * WebKitTestRunner/Configurations/Base.xcconfig:
2567
2568 2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>
2569
2570         [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
2571         https://bugs.webkit.org/show_bug.cgi?id=121674
2572
2573         Reviewed by Mario Sanchez Prada.
2574
2575         Implemented the global notification listener for
2576         AccessibilityController. The signal is generated by
2577         AXObjectCache::postPlatformNotification() and received by
2578         axObjectEventListener(). axObjectEventListener will then invoke
2579         JSObjectCallAsFunction() with the respective callback function.
2580
2581         There is no additional test for this patch since its implementation will
2582         be tested by an accessibility layout test that is currently failing
2583         (accessibility/loading-iframe-sends-notification.html).
2584
2585         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
2586         stub implementations of addNotificationListener and
2587         removeNotificationListener for the GTK port.
2588         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2589         (WTR::AccessibilityController::addNotificationListener): Creates the
2590         notification handler and sets the notification function callback.
2591         (WTR::AccessibilityController::removeNotificationListener): Removes the
2592         global handler.
2593
2594 2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>
2595
2596         [GTK] fast/images/exif-orientation-composited.html is failing
2597         https://bugs.webkit.org/show_bug.cgi?id=119731
2598
2599         Reviewed by Carlos Garcia Campos.
2600
2601         Add handling respect image orientation property in DRT.
2602
2603         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2604         (TestRunner::overridePreference):
2605
2606 2013-09-24  Zan Dobersek  <zdobersek@igalia.com>
2607
2608         [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
2609         https://bugs.webkit.org/show_bug.cgi?id=121787
2610
2611         Reviewed by Gustavo Noronha Silva.
2612
2613         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
2614         with the Wayland target enabled to version 3.10.0.
2615
2616 2013-09-23  Patrick Gansterer  <paroga@webkit.org>
2617
2618         use NOMINMAX instead of #define min min
2619         https://bugs.webkit.org/show_bug.cgi?id=73563
2620
2621         Reviewed by Brent Fulgham.
2622
2623         Use NOMINMAX instead of #define min/max as a cleaner
2624         way of ensuring that Windows system header files don't
2625         define min/max as macro in the first place.
2626
2627         * DumpRenderTree/DumpRenderTreePrefix.h:
2628         * DumpRenderTree/cg/ImageDiffCG.cpp:
2629         * DumpRenderTree/config.h:
2630         * DumpRenderTree/win/ImageDiffCairo.cpp:
2631         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2632         * WebKitTestRunner/config.h:
2633
2634 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
2635
2636         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
2637         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
2638
2639         Reviewed by Alexey Proskuryakov.
2640
2641         Previously, initalizing a WebPreference would change the cache model
2642         to WebCacheModelDocumentBrowser. That behavior was due to a stale
2643         preference file on disk.
2644
2645         This patch fixes the tests by resetting the default, and using the proper
2646         default values after initializing WebPreference.
2647
2648         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2649         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
2650         to the previous runs.
2651
2652         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2653         (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
2654         cache model to the one required.
2655
2656         * TestWebKitAPI/ios/mainIOS.mm:
2657         (main): Reset the preferences before testing.
2658         * TestWebKitAPI/mac/mainMac.mm:
2659         (main): Ditto.
2660
2661 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
2662
2663         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
2664         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
2665
2666         Reviewed by Alexey Proskuryakov.
2667
2668         Previously, initalizing a WebPreference would change the cache model
2669         to WebCacheModelDocumentBrowser. That behavior was due to a stale
2670         preference file on disk.
2671
2672         This patch fixes the tests by resetting the default, and using the proper
2673         default values after initializing WebPreference.
2674
2675         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2676         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
2677         to the previous runs.
2678
2679         * TestWebKitAPI/ios/mainIOS.mm:
2680         (main): Reset the preferences before testing.
2681         * TestWebKitAPI/mac/mainMac.mm:
2682         (main): Ditto.
2683
2684 2013-09-23  Anders Carlsson  <andersca@apple.com>
2685
2686         ListHashSet should work with move-only types
2687         https://bugs.webkit.org/show_bug.cgi?id=121802
2688
2689         Reviewed by Andreas Kling.
2690
2691         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2692         (TestWebKitAPI::TEST):
2693         Add a test for move-only types.
2694
2695 2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>
2696
2697         Added --64-bit option for Windows build.
2698         https://bugs.webkit.org/show_bug.cgi?id=121799
2699
2700         Reviewed by Brent Fulgham.
2701
2702         * Scripts/webkitdirs.pm:
2703         (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
2704         (isWin64): Added.
2705         (determineIsWin64): Added.
2706
2707 2013-09-23  Anders Carlsson  <andersca@apple.com>
2708
2709         ListHashSet should use std::reverse_iterator for reverse iterators
2710         https://bugs.webkit.org/show_bug.cgi?id=121795
2711
2712         Reviewed by Antti Koivisto.
2713
2714         Add test for reverse iterators.
2715
2716         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2717         (TestWebKitAPI::TEST):
2718
2719 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
2720
2721         [EFL] accessibility/aria-invalid is failing
2722         https://bugs.webkit.org/show_bug.cgi?id=111986
2723
2724         Reviewed by Mario Sanchez Prada.
2725
2726         Adds possibility to retrieve JS context.
2727         This is part of the implementation of AccessibilityUIElement::addNotificationListener
2728         from 119883 and 120421.
2729
2730         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2731         (axObjectEventListener):
2732         (addAccessibilityNotificationHandler):
2733         (removeAccessibilityNotificationHandler):
2734         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2735         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2736         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2737
2738 2013-09-20  Mark Rowe  <mrowe@apple.com>
2739
2740         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
2741
2742         Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
2743
2744         Reviewed by David Kilzer.
2745
2746         * Scripts/webkitdirs.pm:
2747         (checkRequiredSystemConfig):
2748
2749 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
2750
2751         [ATK] Do not expose aria-help in ATK based platforms
2752         https://bugs.webkit.org/show_bug.cgi?id=121675
2753
2754         Reviewed by Chris Fleizach.
2755
2756         Remove the implementations for AccessibilityUIElement::helpText()
2757         from DRT and WKTR for GTK and EFL, since they are based on the
2758         AccessibilityObject::helpText() method and the 'aria-help'
2759         attributes, which is wrong since they should not depend on that
2760         but in ATK specific API (see also http://webkit.org/b/121684).
2761
2762         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2763         (AccessibilityUIElement::helpText): Added a new and empty
2764         implementation, now that we are no longer using this in ATK.
2765         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
2766         as the only function provided here was helpText().
2767         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
2768         * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
2769         removed from the list of sources to compile.
2770         * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
2771         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2772         (WTR::AccessibilityUIElement::helpText): Replaced old implementation
2773         based in DumpRenderTreeSupportGtk with an empty one.
2774
2775 2013-09-20  Dan Bernstein  <mitz@apple.com>
2776
2777         Make extract-localizable-strings available to WebCore clients
2778         https://bugs.webkit.org/show_bug.cgi?id=121699
2779
2780         Reviewed by Darin Adler.
2781
2782         * Scripts/extract-localizable-strings: Copied to
2783         Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
2784         executes the script from its new location. This is a temporary measure until certain code
2785         that is external to WebKit is adapted to the new location.
2786         * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
2787         from its new location.
2788
2789 2013-09-20  Patrick Gansterer  <paroga@webkit.org>
2790
2791         Nuke remaining VS2005 tools from the tree.
2792         https://bugs.webkit.org/show_bug.cgi?id=121691
2793
2794         Reviewed by Brent Fulgham.
2795
2796         * CLWrapper/CLWrapper.cpp: Removed.
2797         * CLWrapper/CLWrapper.sln: Removed.
2798         * CLWrapper/CLWrapper.vcproj: Removed.
2799         * MIDLWrapper/MIDLWrapper.cpp: Removed.
2800         * MIDLWrapper/MIDLWrapper.sln: Removed.
2801         * MIDLWrapper/MIDLWrapper.vcproj: Removed.
2802         * Scripts/parallelcl: Removed.
2803         * vcbin/cl.exe: Removed.
2804         * vcbin/midl.exe: Removed.
2805
2806 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
2807
2808         [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
2809         https://bugs.webkit.org/show_bug.cgi?id=121294
2810
2811         Reviewed by Martin Robinson.
2812
2813         Provide a new patch to deal with the issue in the GTK+ module from
2814         the internal jhbuild environment. This issue has been reported
2815         upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
2816
2817         * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
2818         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
2819
2820 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
2821
2822         [ATK][WTR] accessibility/aria-invalid.html times out
2823         https://bugs.webkit.org/show_bug.cgi?id=121668
2824
2825         Reviewed by Mario Sanchez Prada.
2826
2827         Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
2828         false in case of aria-invalid event with empty value.
2829
2830         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2831         (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
2832         case of aria-invalid event with empty value.
2833
2834 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
2835
2836         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
2837         https://bugs.webkit.org/show_bug.cgi?id=120421
2838
2839         Reviewed by Mario Sanchez Prada.
2840
2841         Implemented the notification listener for AccessibilityUIElement for
2842         WebKitTestRunner. The signal is generated by
2843         AXObjectCache::postPlatformNotification() and received by
2844         axObjectEventListener(). axObjectEventListener() will then invoke
2845         JSObjectCallAsFunction() with the respective callback function. The
2846         notification handlers are stored in HashMap in
2847         AccessibilityNotificationHandlerAtk.cpp.
2848
2849         Moved ATK signal handling (printAccessibilityEvent and
2850         axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
2851
2852         * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
2853         include path.
2854         * WebKitTestRunner/GNUmakefile.am:
2855         Added AccessibilityNotificationHandlerAtk.cpp/h.
2856         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
2857         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
2858         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
2859         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
2860         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
2861         notification handler for GTK+ and EFL.
2862         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2863         Moved printAccessibilityEvent and axObjectEventListener to
2864         AccessibilityNotificationHandlerAtk.cpp.
2865         (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
2866         IDs to AccessibilityNotificationHandlerAtk.cpp.
2867         (WTR::AccessibilityController::resetToConsistentState): Moved listener
2868         IDs to AccessibilityNotificationHandlerAtk.cpp.
2869         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
2870         (WTR::printAccessibilityEvent): Prints accessibility events. This
2871         function was moved from AccessibilityControllerAtk.cpp.
2872         (WTR::axObjectEventListener): Callback for signals. This function was
2873         moved from AccessibilityControllerAtk.cpp.
2874         (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
2875         Initialize element and function callback.
2876         (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
2877         Removes handler from HashMap and disconnects callbacks if necessary.
2878         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
2879         logging mode and connects callbacks.
2880         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2881         Sets the notification callback and connects callback to signals.
2882         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2883         Removes the notification callback from HashMap.
2884         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
2885         Connects axObjectEventListener to ATK signals.
2886         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
2887         Disconnects callback.
2888         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
2889         (WTR::AccessibilityNotificationHandler::create): Creates a new instance
2890         of AccessibilityNotificationHandler.
2891         (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
2892         element.
2893         (WTR::AccessibilityNotificationHandler::platformElement): Gets the
2894         element.
2895         (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
2896         Gets the notification callback.
2897         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2898         (WTR::AccessibilityUIElement::addNotificationListener): Creates
2899         notification handler, set the platform element and the notification
2900         callback.
2901         (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
2902         notification handler.
2903         * WebKitTestRunner/PlatformEfl.cmake:
2904         Added AccessibilityNotificationHandlerAtk.cpp.
2905
2906 2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2907
2908         Update features.pri
2909         https://bugs.webkit.org/show_bug.cgi?id=121670
2910
2911         Reviewed by Jocelyn Turcotte.
2912
2913         Remove feature flags that no longer exists and new ones added to FeatureList.pm
2914
2915         * qmake/mkspecs/features/features.pri:
2916
2917 2013-09-20  Krzysztof Czech  <k.czech@samsung.com>
2918
2919         [GTK][WK2] accessibility/selection-states.html is failing
2920         https://bugs.webkit.org/show_bug.cgi?id=116972
2921
2922         Reviewed by Mario Sanchez Prada.
2923
2924         isSelectable() was not exposed in Accessibility.
2925
2926         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2927
2928 2013-09-19  Dan Bernstein  <mitz@apple.com>
2929
2930         Attempted build fix after r156114.
2931
2932         * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
2933
2934 2013-09-19  Alexey Proskuryakov  <ap@apple.com>
2935
2936         REGRESSION (r129451): run-safari --no-saved-state is broken
2937         https://bugs.webkit.org/show_bug.cgi?id=121566
2938
2939         Undo a last minute change that doesn't actually work.
2940
2941         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
2942         via command line, <rdar://problem/15032886>.
2943
2944 2013-09-19  Dan Bernstein  <mitz@apple.com>
2945
2946         Add a style guideline regarding spacing in range-based for loops
2947         https://bugs.webkit.org/show_bug.cgi?id=121620
2948
2949         Reviewed by Anders Carlsson.
2950
2951         * Scripts/webkitpy/style/checkers/cpp.py:
2952         (check_spacing): Added checking that there are spaces around the colon in a range-based for
2953         loop.
2954         (CppChecker): Added whitespace/colon to the categories set.
2955         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2956         (WebKitStyleTest.test_spacing): Added two tests for the new check.
2957
2958 2013-09-18  Sam Weinig  <sam@webkit.org>
2959
2960         Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
2961         https://bugs.webkit.org/show_bug.cgi?id=121588
2962
2963         Reviewed by Anders Carlsson.
2964
2965         * DumpRenderTree/TestRunner.cpp:
2966         * ImageDiff/efl/ImageDiff.cpp:
2967         * TestWebKitAPI/JavaScriptTest.cpp:
2968         * TestWebKitAPI/PlatformUtilities.cpp:
2969         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2970         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2971         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2972         * WebKitTestRunner/StringFunctions.h:
2973         * WebKitTestRunner/TestInvocation.cpp:
2974         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2975         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2976
2977 2013-09-18  Bem Jones-Bey  <bjonesbe@adobe.com>
2978
2979         W3C Test Import script reformats test HTML
2980         https://bugs.webkit.org/show_bug.cgi?id=119159
2981
2982         Reviewed by Dirk Pranke.
2983
2984         Completely rewrite the test conversion process to minimize
2985         reformatting when adding prefixes, etc. This isn't 100% perfect, there
2986         are still places where it will end up changing the formatting, but it
2987         is much better than before. Most notably, the public interface to the
2988         test converter has changed: now one calls a method instead of creating
2989         an instance of the test converter class. This is because the test
2990         converter class now has state, so one really needs a new instance for
2991         each test.
2992
2993         Note that this also lays some simple groundwork for being able to use
2994         a MockHost in the tests.
2995
2996         * Scripts/webkitpy/w3c/test_converter.py:
2997         (convert_for_webkit):
2998         (_W3CTestConverter):
2999         (_W3CTestConverter.__init__):
3000         (_W3CTestConverter.output):
3001         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3002         (_W3CTestConverter.convert_style_data):
3003         (_W3CTestConverter.convert_attributes_if_needed):
3004         (_W3CTestConverter.handle_starttag):
3005         (_W3CTestConverter.handle_endtag):
3006         (_W3CTestConverter.handle_startendtag):
3007         (_W3CTestConverter.handle_data):
3008         (_W3CTestConverter.handle_entityref):
3009         (_W3CTestConverter.handle_charref):
3010         (_W3CTestConverter.handle_comment):
3011         (_W3CTestConverter.handle_decl):
3012         (_W3CTestConverter.handle_pi):
3013         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3014         (W3CTestConverterTest):
3015         (W3CTestConverterTest.fake_dir_path):
3016         (W3CTestConverterTest.test_read_prefixed_property_list):
3017         (verify_no_conversion_happened):
3018         * Scripts/webkitpy/w3c/test_importer.py:
3019         (TestImporter.import_tests):
3020
3021 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3022
3023         Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
3024         https://bugs.webkit.org/show_bug.cgi?id=121578
3025
3026         Rubber stamped by Geoffrey Garen.
3027
3028         * Scripts/run-layout-jsc:
3029
3030 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3031
3032         Unreviewed, fix for Ruby 1.8.
3033
3034         * Scripts/run-jsc-stress-tests:
3035
3036 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3037
3038         run-jsc-stress-tests should make it easier to look at error spew from tests
3039         https://bugs.webkit.org/show_bug.cgi?id=121531
3040
3041         Reviewed by Mark Hahnenberg.
3042         
3043         This makes two changes:
3044         
3045         - The out/err spew from each test is now saved to a .out file in jsc-stress-results.
3046         
3047         - The same spew also goes to the console but is prefixed by the test's name.
3048         
3049         This required some tee and awk hacks, and then some sh hacks to work around the fact
3050         that if you do "(foo | bar) || baz", and foo fails, then baz won't run - the ||
3051         operator will only see a failure of bar failed. So to pass output to tee and awk, I
3052         needed to do weird things.
3053
3054         * Scripts/run-jsc-stress-tests:
3055
3056 2013-09-18  Alexey Proskuryakov  <ap@apple.com>
3057
3058         REGRESSION (r129451): run-safari --no-saved-state is broken
3059         https://bugs.webkit.org/show_bug.cgi?id=121566
3060
3061         Reviewed by Mark Rowe.
3062
3063         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
3064         Check arguments, not the newly created empty array. Pass a value that silences warnings.
3065         While at it, removed a check for Snow Leopard.
3066
3067 2013-09-18  Alex Christensen  <achristensen@webkit.org>
3068
3069         Improved WinLauncher's URL handling.
3070         https://bugs.webkit.org/show_bug.cgi?id=121535
3071
3072         Reviewed by Brent Fulgham.
3073
3074         * WinLauncher/WinLauncher.cpp:
3075         (EditProc):
3076         Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
3077         (loadURL):
3078         Prepend "http://" to URLs with no scheme.
3079
3080 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3081
3082         DFG should support Int52 for local variables
3083         https://bugs.webkit.org/show_bug.cgi?id=121064
3084
3085         Reviewed by Oliver Hunt.
3086
3087         * Scripts/run-jsc-stress-tests:
3088
3089 2013-09-18  peavo@outlook.com  <peavo@outlook.com>
3090
3091         [Win] TestWebKitAPI does not compile.
3092         https://bugs.webkit.org/show_bug.cgi?id=121485
3093
3094         Reviewed by Brent Fulgham.
3095
3096         It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
3097         Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
3098         to return null, which is the case we want to test.
3099
3100         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3101         (TestWebKitAPI::TEST):
3102
3103 2013-09-18  Mario Sanchez Prada  <mario.prada@samsung.com>
3104
3105         [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
3106         https://bugs.webkit.org/show_bug.cgi?id=121495
3107
3108         Reviewed by Chris Fleizach.
3109
3110         Adapted DRT and WKTR to deal with the new names for the ATK object
3111         attributes being exposed for 'aria-haspopup' and 'aria-sort'.
3112
3113         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3114         (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
3115         (AccessibilityUIElement::stringAttributeValue): Ditto.
3116         (AccessibilityUIElement::hasPopup): Ditto.
3117         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3118         (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
3119         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
3120         (WTR::AccessibilityUIElement::hasPopup): Ditto.
3121
3122 2013-09-18  Commit Queue  <commit-queue@webkit.org>
3123
3124         Unreviewed, rolling out r156019 and r156020.
3125         http://trac.webkit.org/changeset/156019
3126         http://trac.webkit.org/changeset/156020
3127         https://bugs.webkit.org/show_bug.cgi?id=121540
3128
3129         Broke tests (Requested by ap on #webkit).
3130
3131         * Scripts/run-jsc-stress-tests:
3132
3133 2013-09-17  Gwang Yoon Hwang  <ryumiel@company100.net>
3134
3135         Unreviewed. Add myself as a committer.
3136
3137         * Scripts/webkitpy/common/config/contributors.json:
3138
3139 2013-09-17  Jae Hyun Park  <jae.park@company100.net>
3140
3141         Unreviewed. Add myself as a committer.
3142
3143         * Scripts/webkitpy/common/config/contributors.json:
3144
3145 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3146
3147         DFG should support Int52 for local variables
3148         https://bugs.webkit.org/show_bug.cgi?id=121064
3149
3150         Reviewed by Oliver Hunt.
3151
3152         * Scripts/run-jsc-stress-tests:
3153
3154 2013-09-17  Alex Christensen  <alex.christensen@flexsim.com>
3155
3156         Added back and forward buttons to WinLauncher.
3157         https://bugs.webkit.org/show_bug.cgi?id=121212
3158
3159         Reviewed by Brent Fulgham.
3160
3161         * WinLauncher/WinLauncher.cpp:
3162         (resizeSubViews):
3163         Move new back and forward buttons to correct positions before URL bar.
3164         (dllLauncherEntryPoint): 
3165         Store the default button window procedure and replace with my button procedures.
3166         (EditProc): Updated style and renamed from MyEditProc.
3167         (BackButtonProc): Added.
3168         (ForwardButtonProc): Added.
3169
3170 2013-09-17  Michael Saboff  <msaboff@apple.com>
3171
3172         Unreviewed typo fix after r155999
3173
3174         Changed en_US.UTB-8 to en_US.UTF-8
3175
3176         * Scripts/run-javascriptcore-tests:
3177
3178 2013-09-17  Michael Saboff  <msaboff@apple.com>
3179
3180         run-jsc-stress-tests fails with ruby version 2
3181         https://bugs.webkit.org/show_bug.cgi?id=121521
3182
3183         Reviewed by Jessie Berlin.
3184
3185         Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.
3186
3187         * Scripts/run-javascriptcore-tests:
3188
3189 2013-09-17  Brent Fulgham  <bfulgham@apple.com>
3190
3191         [Windows] Unreviewed build fix after r155963.
3192
3193         * DumpRenderTree/win/TestRunnerWin.cpp:
3194         (TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.
3195
3196 2013-09-17  Anders Carlsson  <andersca@apple.com>
3197
3198         Fix a typo.
3199
3200         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3201         (TestWebKitAPI::TEST):
3202
3203 2013-09-16  Anders Carlsson  <andersca@apple.com>
3204
3205         HashMap should work with move-only keys
3206         https://bugs.webkit.org/show_bug.cgi?id=121310
3207
3208         Reviewed by Darin Adler.
3209
3210         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3211         (TestWebKitAPI::TEST):
3212         Add test.
3213
3214 2013-09-17  YuTeh Shen  <shenyute@hotmail.com>
3215
3216         BrowserMarshal.h build fail
3217         https://bugs.webkit.org/show_bug.cgi?id=102938
3218
3219         Reviewed by Carlos Garcia Campos.
3220
3221         Fix variable name.
3222
3223         * MiniBrowser/gtk/GNUmakefile.am:
3224
3225 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
3226
3227         [Windows] Clean up WinLauncher by using smart pointers
3228         https://bugs.webkit.org/show_bug.cgi?id=121467
3229
3230         Reviewed by Anders Carlsson.
3231
3232         * WinLauncher/PrintWebUIDelegate.cpp:
3233         (PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
3234         * WinLauncher/WinLauncher.cpp:
3235         (WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
3236         (WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
3237         (showLastVisitedSites): Smart pointer updates.
3238         (WinLauncherWebHost::didFinishLoadForFrame): Ditto.
3239         (setToDefaultPreferences): Ditto.
3240         (dllLauncherEntryPoint): Ditto.
3241         (PrintView): Ditto.
3242         (LaunchInspector): Ditto.
3243         (NavigateToHistory): Ditto.
3244         (MyEditProc): Ditto.
3245         (loadURL): Ditto.
3246
3247 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
3248
3249         [Windows] Add rudimentary history to WinLauncher.
3250         https://bugs.webkit.org/show_bug.cgi?id=121463
3251
3252         Reviewed by Anders Carlsson.
3253
3254         * WinLauncher/WinLauncher.cpp:
3255         (updateMenuItemForHistoryItem): Added
3256         (showLastVisitedSites): Added
3257         (WinLauncherWebHost::didFinishLoadForFrame): Add history item once
3258         a new page has been visited.
3259         (dllLauncherEntryPoint): Deallocate history on exit.
3260         (NavigateToHistory): Added
3261         (WndProc): Add handler for history entries
3262         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
3263         up to 10 history slots.
3264         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
3265         Windows utility library to allow use of _bstr_t type.
3266         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
3267         to hold up to 10 history slots.
3268         * WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
3269
3270 2013-09-16  Gustavo Noronha Silva  <gns@gnome.org>
3271
3272         [GTK] Make symbol export filter more strict, and disable for dev/test builds
3273         https://bugs.webkit.org/show_bug.cgi?id=120586
3274
3275         Reviewed by Martin Robinson.
3276
3277         * GNUmakefile.am: moved GtkLauncher and documentation builds to their own
3278         makefiles, so they can be included unconditionally.
3279         * GtkLauncher/GNUmakefile.am: added.
3280         * Scripts/webkitdirs.pm:
3281         (runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
3282         to configure, since we consider builds done through build-webkit to be development
3283         and test builds.
3284         * gtk/GNUmakefile.am: added.
3285         * gtk/common.py: do not use the Scripts directory as a reference to the top path;
3286         it's not necessary and it will not work now that the Scripts directory is not
3287         shipped in the tarball.
3288
3289 2013-09-16  Anders Carlsson  <andersca@apple.com>
3290
3291         WTF::Deque should work with move only types
3292         https://bugs.webkit.org/show_bug.cgi?id=121446
3293
3294         Reviewed by Andreas Kling.
3295
3296         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3297         (TestWebKitAPI::TEST):
3298         Add a test.
3299
3300 2013-09-16  Wojciech Bielawski  <w.bielawski@samsung.com>
3301
3302         [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
3303         https://bugs.webkit.org/show_bug.cgi?id=98410
3304
3305         Reviewed by Darin Adler.
3306
3307         Add implementation of click() method of objects returned by eventSender.contextClick().
3308
3309         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3310         (MenuItemPrivateData):
3311         (WTR::menuItemClickCallback):
3312         (WTR::getMenuItemTitleCallback):
3313         (WTR::staticMenuItemFinalize):
3314         (WTR::getMenuItemClass):
3315         (WTR::EventSendingController::contextClick):
3316
3317 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
3318
3319         Make the GDB webkit.py script compatible with Python v3
3320         https://bugs.webkit.org/show_bug.cgi?id=121395
3321
3322         Reviewed by Ryosuke Niwa.
3323
3324         GDB fails to load the printing helpers from the webkit.py script if Python v3 is used. To avoid that,
3325         uses of xrange() in the script are replaced with range(), and the print statements are changed into
3326         the print() function invocations.
3327
3328         * gdb/webkit.py:
3329         (guess_string_length):
3330         (ustring_to_string):
3331         (lstring_to_string):
3332         (WTFCStringPrinter.to_string):
3333         (PrintPathToRootCommand.invoke):
3334
3335 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
3336
3337         [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
3338         https://bugs.webkit.org/show_bug.cgi?id=119631
3339
3340         Reviewed by Ryosuke Niwa.
3341
3342         The perf profiler is attached to the test runner after the test runner has been launched,
3343         but in the case of WebKitTestRunner, this is done after the WebProcess was spawned by the
3344         UIProcess, meaning that WebProcess operations will not be profiled.
3345
3346         To avoid that, the perf profiler is changed to provide a wrapper command for the test runner.
3347         This is done in the scope of already present support for wrapper scripts (such as valgrind)
3348         that are settable through the --wrapper option. This causes the perf profiler to correctly
3349         continue profiling the WebProcess after it was spawned.
3350
3351         When the profiler is launched, a wait process is launched with the profiler's pid as the
3352         argument. This ensures we can check that the profiler exited normally. If it did not, its
3353         output can be corrupted and can cause problems when that output is examined. The after-exit
3354         report is avoided in that case.
3355
3356         * Scripts/webkitpy/common/system/profiler.py:
3357         (Profiler.wrapper_arguments): The method returns an empty list by default.
3358         (Perf.__init__): Remove unnecessary member variables.
3359         (Perf.attach_to_pid): Launch the wait process with the profiler's pid as the argument.
3360         (Perf.wrapper_arguments): Used instead of attaching the profiler to the profiled process' pid,
3361         the method returns a list of arguments that should be used as a wrapper for the test runner.
3362         The arguments specify the 'perf record' command, with the output file and the instruction to
3363         construct the call graph given as well.
3364         (Perf._first_ten_lines_of_profile): Prettify the output by avoiding the unnecessary trailing
3365         whitespace in the profile lines.
3366         (Perf.profile_after_exit): Kill the profiler process through its pid if the wait process is still
3367         running. If it is running even after that, or if the profiler process produced a non-zero exit
3368         code, the method reports the profiling failure and returns. Otherwise it continues on reporting
3369         the top 10 lines of the profile and how to examine the profile further.
3370         * Scripts/webkitpy/port/driver.py:
3371         (Driver._command_wrapper): The method is now a member of the Driver class, returning the wrapper
3372         as specified by the --wrapper option if given, or the profiler wrapper if the profiler is present,
3373         or an empty list otherwise.
3374         (Driver.cmd_line):
3375         * Scripts/webkitpy/port/driver_unittest.py:
3376         (DriverTest.make_port): Adjusted so mock host or options objects can be specified
3377         for the testing-specific Port object.
3378         (DriverTest._assert_wrapper): Pass a MockOptions object with the wrapper value to the make_port method,
3379         as the Driver._command_wrapper now operates on the option's value directly rather than accepting it through
3380         a parameter.
3381         (DriverTest.test_profiler_as_wrapper): Provide a test case to check the correct profiler wrapper is used
3382         when profiling on the Linux platform with the perf profiler.
3383
3384 2013-09-14  Dan Bernstein  <mitz@apple.com>
3385
3386         [mac] Check For Framework Include Consistency build phase checks the wrong framework
3387         https://bugs.webkit.org/show_bug.cgi?id=121215
3388
3389         Reviewed by Mark Rowe.
3390
3391         * Scripts/check-for-webkit-framework-include-consistency: Replaced hard-coded paths to
3392         WebKit.framework’s Headers and PrivateHeaders directories with the current target’s
3393         public and private headers folder paths. Also tweaked the error messages’ format to make
3394         Xcode recognize them as errors.
3395
3396 2013-09-14  Alberto Garcia  <berto@igalia.com>
3397
3398         [GTK] Fails to compile if the build directory is in a different partition
3399         https://bugs.webkit.org/show_bug.cgi?id=121296
3400
3401         Reviewed by Martin Robinson.
3402
3403         Instead of using os.symlink() to install the gtk-doc templates,
3404         use os.link() first and fall back to os.symlink() if it fails.
3405
3406         * gtk/gtkdoc.py:
3407         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
3408
3409 2013-09-14  Alberto Garcia  <berto@igalia.com>
3410
3411         [GTK] WebKitGTK+ is linking against libxslt in too many places
3412         https://bugs.webkit.org/show_bug.cgi?id=121356
3413
3414         Reviewed by Martin Robinson.
3415
3416         TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
3417         so we don't need to link against it.
3418
3419         * MiniBrowser/gtk/GNUmakefile.am:
3420         * TestWebKitAPI/GNUmakefile.am:
3421         * WebKitTestRunner/GNUmakefile.am:
3422
3423 2013-09-14  Ross Burton  <ross.burton@intel.com>
3424
3425         Uses gtk-doc tools even when --disable-gtk-doc passed
3426         https://bugs.webkit.org/show_bug.cgi?id=91239
3427
3428         Reviewed by Martin Robinson.
3429
3430         Don't run generate-gtkdoc on install if gtk-doc is disabled.
3431
3432         * GNUmakefile.am:
3433
3434 2013-09-14  Alberto Garcia  <berto@igalia.com>
3435
3436         [GTK] Fails to compile if the build directory is in a different partition
3437         https://bugs.webkit.org/show_bug.cgi?id=121296
3438
3439         Reviewed by Carlos Garcia Campos.
3440
3441         Use symlinks instead of hard links to support building on a
3442         different file system.
3443
3444         * gtk/gtkdoc.py:
3445         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
3446
3447 2013-09-13  Darin Adler  <darin@apple.com>
3448
3449         Use a better name than m_invertibleCTM
3450         https://bugs.webkit.org/show_bug.cgi?id=121341
3451
3452         Reviewed by Andreas Kling.
3453
3454         * Scripts/do-webcore-rename: Updated to do this replace as we do.
3455
3456 2013-09-13  Anders Carlsson  <andersca@apple.com>
3457
3458         Pick the correct overload when a const reference is passed to appendSlowCase.
3459         https://bugs.webkit.org/show_bug.cgi?id=121326
3460
3461         Reviewed by Darin Adler.
3462
3463         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3464         (TestWebKitAPI::TEST):
3465
3466 2013-09-13  Darin Adler  <darin@apple.com>
3467
3468         Rename confusingly named "runtimeObject" functions
3469         https://bugs.webkit.org/show_bug.cgi?id=121339
3470
3471         Reviewed by Sam Weinig.
3472
3473         * Scripts/do-webcore-rename: Updated to do this replace as usual.
3474
3475 2013-09-13  Filip Pizlo  <fpizlo@apple.com>
3476
3477         DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
3478         https://bugs.webkit.org/show_bug.cgi?id=121330
3479
3480         Reviewed by Mark Hahnenberg and Oliver Hunt.
3481
3482         We should run tests even if they don't have expected files yet.
3483         
3484         * Scripts/run-layout-jsc:
3485
3486 2013-09-13  Anders Carlsson  <andersca@apple.com>
3487
3488         Use nullptr instead of 0 in calls to HashMap::add
3489         https://bugs.webkit.org/show_bug.cgi?id=121322
3490
3491         Reviewed by Sam Weinig.
3492
3493         * DumpRenderTree/mac/TestRunnerMac.mm:
3494         (TestRunner::evaluateScriptInIsolatedWorld):
3495         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3496         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
3497
3498 2013-09-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3499
3500         [GTK] Move to the new web inspector
3501         https://bugs.webkit.org/show_bug.cgi?id=120647
3502
3503         Reviewed by Carlos Garcia Campos.
3504
3505         * GtkLauncher/main.c:
3506         (main): no longer set WEBKIT_INSPECTOR_PATH.
3507         * MiniBrowser/gtk/main.c:
3508         (main): ditto.
3509         * Scripts/old-run-webkit-tests:
3510         (openDumpTool): ditto.
3511         * Scripts/run-gtk-tests: ditto.
3512         * Scripts/webkitpy/port/gtk.py:
3513         (GtkPort.setup_environ_for_server): ditto.
3514
3515 2013-09-13  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3516
3517         [Qt] REGRESSION(r154444): xss-DENIED test results changed
3518         https://bugs.webkit.org/show_bug.cgi?id=120595
3519
3520         Reviewed by Jocelyn Turcotte.
3521
3522         Avoid overwriting Qt meta properties, which we identify by them being undeletable.
3523
3524         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3525         (DumpRenderTree::initJSObjects):
3526
3527 2013-09-13  Darin Adler  <darin@apple.com>
3528
3529         Give actions in Range class NON_SHOUTING_NAMES
3530         https://bugs.webkit.org/show_bug.cgi?id=121280
3531
3532         Reviewed by Andreas Kling.
3533
3534         * Scripts/do-webcore-rename: Updated to do this replace, keeping with
3535         the tradition of checking in the last one we did, along with other
3536         rename ideas for the future.
3537
3538 2013-09-12  Lucas Forschler  <lforschler@apple.com>
3539
3540         Create short build logs for errors and warnings.
3541         https://bugs.webkit.org/show_bug.cgi?id=120614
3542
3543         Reviewed by Ryosuke Niwa.
3544
3545         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3546             -include StringIO 
3547         (CompileWebKit.createSummary):
3548             -add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing
3549
3550 2013-09-12  Roger Fong  <roger_fong@apple.com>
3551
3552         Update cygwin downloader to search for packages in the right location.
3553
3554         * CygwinDownloader/cygwin-downloader.py:
3555         * CygwinDownloader/cygwin-downloader.zip:
3556
3557 2013-09-12  Anders Carlsson  <andersca@apple.com>
3558
3559         Add rudimentary support for move-only types as values in HashMap
3560         https://bugs.webkit.org/show_bug.cgi?id=121226
3561
3562         Reviewed by Andreas Kling.
3563
3564         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3565         (TestWebKitAPI::TEST):
3566         Add a HashMap<unsigned, MoveOnly> test.
3567
3568 2013-09-12  Gabor Abraham  <abrhm@inf.u-szeged.hu>
3569
3570         Auto GDB backtrace generation for EFL/GTK/Qt bots.
3571         https://bugs.webkit.org/show_bug.cgi?id=119338
3572
3573         Reviewed by Csaba Osztrogonác.
3574
3575         * Scripts/webkitpy/port/efl.py:
3576         (EflPort.check_sys_deps):
3577         (EflPort):
3578         (EflPort._get_crash_log):
3579         * Scripts/webkitpy/port/efl_unittest.py:
3580         (EflPortTest.test_show_results_html_file):
3581         (EflPortTest):
3582         (EflPortTest.test_get_crash_log):
3583         * Scripts/webkitpy/port/gtk.py:
3584         (GtkPort._get_crash_log):
3585         * Scripts/webkitpy/port/gtk_unittest.py:
3586         (GtkPortTest.test_get_crash_log):
3587         * Scripts/webkitpy/port/linux_get_crash_log.py: Added.
3588         (GDBCrashLogGenerator):
3589         (GDBCrashLogGenerator.__init__):
3590         (GDBCrashLogGenerator._get_gdb_output):
3591         (GDBCrashLogGenerator.generate_crash_log):
3592         (GDBCrashLogGenerator.generate_crash_log.match_filename):
3593         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.
3594         (GDBCrashLogGeneratorTest):
3595         (GDBCrashLogGeneratorTest.test_generate_crash_log):
3596         (_mock_gdb_output):
3597         * Scripts/webkitpy/port/qt.py:
3598         (QtPort.default_child_processes):
3599         (QtPort):
3600         (QtPort._get_crash_log):
3601         * Scripts/webkitpy/port/qt_unittest.py:
3602         (QtPortTest.test_check_sys_deps):
3603         (QtPortTest):
3604         (QtPortTest.test_get_crash_log):
3605
3606 2013-09-12  Peter Gal  <galpeter@inf.u-szeged.hu>
3607
3608         Unreviewed. Moving myself to the commiters list.
3609
3610         * Scripts/webkitpy/common/config/contributors.json:
3611
3612 2013-09-12  ChangSeok Oh  <changseok.oh@collabora.com>
3613
3614         [GTK] Add jhbuild-wayland.modules
3615         https://bugs.webkit.org/show_bug.cgi?id=120455
3616
3617         Reviewed by Gustavo Noronha Silva.
3618
3619         Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
3620         With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
3621         WEBKIT_EXTRA_MODULESETS.
3622
3623         * gtk/jhbuild-wayland.modules: Added.
3624
3625 2013-09-12  Mario Sanchez Prada  <mario.prada@samsung.com>
3626
3627         [GTK][WK2] a11y tests unconditionally launching a11y daemons
3628         https://bugs.webkit.org/show_bug.cgi?id=120299
3629
3630         Reviewed by Carlos Garcia Campos.
3631
3632         Use the right variable name to store a reference to the at-spi2
3633         bus launcher process, so we can be sure we are terminating it when
3634         calling _tear_down_testing_environment().
3635
3636         * Scripts/run-gtk-tests:
3637         (TestRunner._start_accessibility_daemons): Use _spi_bus_launcher
3638         instead of _ally_bus_launcher.
3639
3640 2013-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3641
3642         [GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
3643         https://bugs.webkit.org/show_bug.cgi?id=121218
3644
3645         Reviewed by Philippe Normand.
3646
3647         Skipping the entire suite was added to skip tests when they can't
3648         be run because of the environment, for example to skip the a11y
3649         tests when the at-spi daemons fail to start. This is no longer
3650         true for all the cases, so we can disable the tests that are
3651         impossible to run instead of skipping them.
3652
3653         * Scripts/run-gtk-tests:
3654         (TestRunner.__init__): Initialize the skipped tests list.
3655         (TestRunner._setup_testing_environment): Add
3656         TestWebKitAccessibility path to the list of disabled tests when
3657         at-spi daemon fail to start.
3658         (TestRunner._should_run_test_program): Check first if the test
3659         program is disabled and then whether it's skipped honoring the
3660         skipped command line option.
3661
3662 2013-09-12  Samuel White  <samuel_white@apple.com>
3663
3664         <meter> element text value exposed as AXTitle; should be exposing AXValueDescription
3665         https://bugs.webkit.org/show_bug.cgi?id=117651
3666
3667         Reviewed by Mario Sanchez Prada.
3668
3669         Prepended 'AXValueDescription: ' to valueDescription output and updated impacted tests.
3670
3671         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3672         (AccessibilityUIElement::valueDescription):
3673         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3674         (WTR::AccessibilityUIElement::valueDescription):
3675
3676 2013-09-12  Denis Nomiyama  <d.nomiyama@samsung.com>
3677
3678         REGRESSION(r154781): accessibility/notification-listeners.html is failing
3679         https://bugs.webkit.org/show_bug.cgi?id=120669
3680
3681         Reviewed by Chris Fleizach.
3682
3683         Fixed 4 problems that were causing notification-listeners.html to fail.
3684
3685         Notifications for AXFocusedUIElementChanged and AXValueChanged had to be
3686         implemented in axObjectEventListener().
3687
3688         A notification for AXFocusedUIElementChanged was incorrectly sent when
3689         the element lost focus.
3690
3691         Global notification was not dispatched if an element notification was
3692         present in the HashMap.
3693
3694         connectAccessibilityCallbacks() was connecting signals to callbacks
3695         multiple times because it was not checking if
3696         disconnectAccessibilityCallbacks() had an early return if there were
3697         active handlers.
3698
3699         * DumpRenderTree/atk/AccessibilityCallbacks.h: Modified
3700         disconnectAccessibilityCallbacks() to inform if the callbacks were
3701         successfully disconnected.
3702         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3703         (axObjectEventListener): Implemented notifications for
3704         AXFocusedUIElementChanged and AXValueChanged. Fixed the global
3705         notification, which was not dispatched if an element notification
3706         existed. Fixed the notification for AXFocusedUIElementChanged that was
3707         incorrectly sent when the element lost focus. In addition, fixed a typo
3708         where TRUE should be true.
3709         (connectAccessibilityCallbacks): Added early return if
3710         disconnectAccessibilityCallbacks() did not disconnect the callbacks.
3711         (disconnectAccessibilityCallbacks): Added a return value to inform if
3712         callbacks were successfully disconnected.
3713
3714 2013-09-11  Anders Carlsson  <andersca@apple.com>
3715
3716         Try to fix GCC builds.
3717
3718         * TestWebKitAPI/Tests/WTF/MoveOnly.h:
3719
3720 2013-09-11  Anders Carlsson  <andersca@apple.com>
3721
3722         Try to fix the build.
3723
3724         Move MoveOnly.h to Tests/WTF and fix the broken Xcode project that caused me to add the header
3725         file in the Tests/ directory in the first place.
3726
3727         * TestWebKitAPI/CMakeLists.txt:
3728         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
3729         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
3730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3731         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Renamed from Tools/TestWebKitAPI/Tests/MoveOnly.h.
3732
3733 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
3734
3735         [Windows] Build fix for MoveOnly
3736
3737         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Add
3738         Tests to include search path.
3739         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
3740         Ditto.
3741
3742 2013-09-11  Anders Carlsson  <andersca@apple.com>
3743
3744         Add HashSet::take
3745         https://bugs.webkit.org/show_bug.cgi?id=121192
3746
3747         Reviewed by Darin Adler.
3748
3749         Add a test for HashSet::take.
3750
3751         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3752         (TestWebKitAPI::TEST):
3753
3754 2013-09-11  Anders Carlsson  <andersca@apple.com>
3755
3756         HashSet should work with move only types
3757         https://bugs.webkit.org/show_bug.cgi?id=121188
3758
3759         Reviewed by Geoffrey Garen.
3760
3761         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3762         * TestWebKitAPI/Tests/MoveOnly.h: Added.
3763         Move the MoveOnly class from Vector out into its own header.
3764
3765         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3766         (TestWebKitAPI::TEST):
3767         Add aHashSet<MoveOnly> test.
3768
3769         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3770         Include MoveOnly.h.
3771
3772 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
3773
3774         [Windows] Avoid converting from IntSize->SIZE->IntSize
3775         https://bugs.webkit.org/show_bug.cgi?id=121180
3776
3777         Reviewed by Anders Carlsson.
3778
3779         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3780         (TestWebKitAPI::TEST): Use IntSize instead of SIZE struct.
3781
3782 2013-09-11  Dan Bernstein  <mitz@apple.com>
3783
3784         REGRESSION (r155561): extract-localizable-strings can miss strings
3785         https://bugs.webkit.org/show_bug.cgi?id=121184
3786
3787         Reviewed by Darin Adler.
3788
3789         * Scripts/extract-localizable-strings: Don’t discard lines if we are waiting for a closing
3790         parenthesis or bracket.
3791
3792 2013-09-11  Dan Bernstein  <mitz@apple.com>
3793
3794         update-webkit-localizable-strings is at least 5.8x slower than it should be
3795         https://bugs.webkit.org/show_bug.cgi?id=121178
3796
3797         Reviewed by Darin Adler.
3798
3799         * Scripts/extract-localizable-strings: Quickly skip over lines that contain neither " nor /*.
3800         Note that this does not change functionality, because the script already does not understand
3801         the line continuation sequence (backslash followed by a newline).
3802
3803 2013-09-11  Anders Carlsson  <andersca@apple.com>
3804
3805         Vector::append doesn't work if element type has overloaded operator&
3806         https://bugs.webkit.org/show_bug.cgi?id=121175
3807
3808         Reviewed by Brent Fulgham.
3809
3810         Add a test case.
3811
3812         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3813         (TestWebKitAPI::TEST):
3814
3815 2013-09-11  Anders Carlsson  <andersca@apple.com>
3816
3817         Implement Vector::append for move-only types
3818         https://bugs.webkit.org/show_bug.cgi?id=120805
3819
3820         Reviewed by Sam Weinig.
3821
3822         Add a test for Vector<MoveOnly>::append.
3823
3824         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3825         (TestWebKitAPI::TEST):
3826
3827 2013-09-11  Csaba Osztrogonác  <ossy@webkit.org>
3828
3829         Unreviewed. Fix the indentation after r105848. Typo fix after r155523.
3830
3831         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3832         (RunAndUploadPerfTests):
3833         (RunAndUploadPerfTests.start):
3834         (RunAndUploadPerfTests.getText2):
3835
3836 2013-09-11  Anders Carlsson  <andersca@apple.com>
3837
3838         The style checker shouldn't complain about returning or passing OwnPtr
3839         https://bugs.webkit.org/show_bug.cgi?id=121163
3840
3841         Reviewed by Antti Koivisto.
3842
3843         * Scripts/webkitpy/style/checkers/cpp.py:
3844         (check_function_definition_and_pass_ptr):
3845         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3846         (PassPtrTest.test_pass_ref_ptr_return_value):
3847         (PassPtrTest.test_own_ptr_parameter_value):
3848
3849 2013-09-11  Mario Sanchez Prada  <mario.prada@samsung.com>
3850
3851         [GTK] Remove Gail dependency from build system for GTK3
3852         https://bugs.webkit.org/show_bug.cgi?id=119673
3853
3854         Reviewed by Gustavo Noronha Silva.
3855
3856         * EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
3857         * Scripts/webkitpy/port/gtk.py:
3858         (GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.
3859         * TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.
3860
3861 2013-09-11  Gabor Abraham  <abrhm@inf.u-szeged.hu>
3862
3863         Performance tester bots should report the number of failing tests
3864         https://bugs.webkit.org/show_bug.cgi?id=120462
3865
3866         Reviewed by Csaba Osztrogonác.
3867
3868         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3869         (RunAndUploadPerfTests.start.getText):
3870         (RunAndUploadPerfTests.start):
3871         (RunAndUploadPerfTests):
3872         (RunAndUploadPerfTests.start.getText2):
3873
3874 2013-09-11  Krzysztof Czech  <k.czech@samsung.com>
3875
3876         [ATK] Adds mapping MenuItemRadioRole to ATK
3877         https://bugs.webkit.org/show_bug.cgi?id=121149
3878
3879         Reviewed by Mario Sanchez Prada.
3880
3881         Adds mapping MenuItemRadioRole to ATK.
3882
3883         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3884         (roleToString):
3885         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3886         (WTR::roleToString):
3887
3888 2013-09-10  Csaba Osztrogonác  <ossy@webkit.org>
3889
3890         Unreviewed fix after the unreviewed r155498 to unbreak the failure
3891         counter of run-javascriptcore-tests build step on build.webkit.org.
3892
3893         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3894         (RunJavaScriptCoreTests.commandComplete):
3895         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3896
3897 2013-09-10  Filip Pizlo  <fpizlo@apple.com>
3898
3899         Unreviewed, be a bit more clear about what we mean by 'js' tests. I think this
3900         got a bit overlooked from the fast/js->js refactoring.
3901
3902         * Scripts/run-javascriptcore-tests:
3903
3904 2013-09-10  Daniel Bates  <dabates@apple.com>
3905
3906         [iOS] Upstream text autosizing
3907         https://bugs.webkit.org/show_bug.cgi?id=121111
3908
3909         Reviewed by Andy Estes and Sam Weinig.
3910
3911         Implement infrastructure to test the iOS text autosizing code.
3912
3913         * DumpRenderTree/TestRunner.cpp:
3914         (setTextAutosizingEnabledCallback): Added.
3915         (TestRunner::staticFunctions):
3916         * DumpRenderTree/TestRunner.h:
3917         * DumpRenderTree/mac/DumpRenderTree.mm:
3918         (resetDefaultsToConsistentValues):
3919         * DumpRenderTree/mac/TestRunnerMac.mm:
3920         (TestRunner::setTextAutosizingEnabled): Added.
3921
3922 2013-09-10  Mark Hahnenberg  <mhahnenberg@apple.com>
3923
3924         run-jsc-stress-tests should have a mode for always running the copy phase
3925         https://bugs.webkit.org/show_bug.cgi?id=121128
3926
3927         Reviewed by Geoffrey Garen.
3928
3929         This will increase test coverage of the copying phase, which might not always get 
3930         triggered normally with our default parameters for required Heap/CopiedBlock utilization.
3931
3932         * Scripts/run-jsc-stress-tests:
3933
3934 2013-09-10  Sergio Correia  <sergio.correia@openbossa.org>
3935
3936         [EFL][JHBUILD] Use a tarball for libseccomp, instead of git
3937         https://bugs.webkit.org/show_bug.cgi?id=121114
3938
3939         Reviewed by Christophe Dumez.
3940
3941         Use a tarball for libseccomp instead of git to avoid network issues on
3942         the buildbots while checking out the git repo. Using tarballs has the
3943         advantage of them being cached if the checksum matches, in which case
3944         there will be no need to download them again.
3945
3946         * efl/jhbuild.modules:
3947
3948 2013-09-10  Mark Lam  <mark.lam@apple.com>
3949
3950         Replace remaining "fast js" names in scripts.
3951         https://bugs.webkit.org/show_bug.cgi?id=120899.
3952
3953         Rubber stamped by Filip Pizlo.
3954
3955         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3956         (test_layout_failure_new_output):
3957         (test_layout_crash_new_output):
3958         (test_mozilla_and_layout_failure_new_output):
3959         * Scripts/run-fast-jsc: Removed.
3960         * Scripts/run-javascriptcore-tests:
3961         * Scripts/run-layout-jsc: Copied from Tools/Scripts/run-fast-jsc.
3962
3963 2013-09-10  Zan Dobersek  <zdobersek@igalia.com>
3964
3965         Enable JSC stress tests for the rest of non-Windows platforms
3966         https://bugs.webkit.org/show_bug.cgi?id=121021
3967
3968         Reviewed by Filip Pizlo.
3969
3970         The JSC stress tests can already be enabled on Linux-based ports.
3971
3972         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3973         (RunJavaScriptCoreTests.commandComplete): Reformulate the regular expressions used to find the number of regressed
3974         JSC tests of various test suites. The expressions now look for the suite-specific report compartment over the
3975         complete output, with the number of failing or crashing tests properly extracted.
3976         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a couple of unit tests and expand the tested
3977         output in other unit tests testing the parsing of the output in the new format.
3978         (test_jsc_stress_failure_new_output):
3979         (test_fast_js_crashes_and_jsc_stress_failures_new_output):
3980         * Scripts/run-javascriptcore-tests: Enable the JSC stress tests on all but the Apple Win port.
3981         * Scripts/run-jsc-stress-tests: `sysctl -n hw.availcpu` doesn't work on Linux-based ports but the numProcesses
3982         variable is still gracefully assigned a zero value. In that case, try running `nproc --all` to gather the number
3983         of available CPUs so the stress tests can be run in parallel.
3984
3985 2013-09-10  Chris Fleizach  <cfleizach@apple.com>
3986
3987         AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
3988         https://bugs.webkit.org/show_bug.cgi?id=120552
3989
3990         Unreviewed build fix.
3991
3992         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3993         (AccessibilityUIElement::classList):
3994
3995 2013-09-10  Chris Fleizach  <cfleizach@apple.com>
3996
3997         AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
3998         https://bugs.webkit.org/show_bug.cgi?id=120552
3999
4000         Reviewed by Darin Adler.
4001
4002         * DumpRenderTree/AccessibilityUIElement.cpp:
4003         (getClassListCallback):
4004         (AccessibilityUIElement::getJSClass):
4005         * DumpRenderTree/AccessibilityUIElement.h:
4006         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4007         (AccessibilityUIElement::classList):
4008         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
4009         (AccessibilityUIElement::classList):
4010         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4011         (AccessibilityUIElement::classList):
4012         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4013         (AccessibilityUIElement::classList):
4014         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4015         (WTR::AccessibilityUIElement::classList):
4016         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4017         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4018         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4019         (WTR::AccessibilityUIElement::classList):
4020         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4021         (WTR::AccessibilityUIElement::classList):
4022
4023 2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>
4024
4025         [GTK] accessibility/loading-iframe-sends-notification.html is failing
4026         https://bugs.webkit.org/show_bug.cgi?id=98370
4027
4028         Reviewed by Chris Fleizach.
4029
4030         Added AXLayoutComplete for the GTK platform.
4031
4032         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
4033         (axObjectEventListener): Added notification AXLayoutComplete for
4034         layout-complete signal.
4035
4036 2013-09-09  Brent Fulgham  <bfulgham@apple.com>
4037
4038         [Windows] Change from using OwnPtr<GDI Stuff> to new GDIObject.
4039         https://bugs.webkit.org/show_bug.cgi?id=120778
4040
4041         Reviewed by Anders Carlsson.
4042
4043         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
4044         (createBitmapContextFromWebView): Use GDIObject.
4045         * Scripts/webkitpy/style/checkers/cpp.py:
4046         (check_for_leaky_patterns): Update for GDIObject instead of adoptPtr and OwnPtr.
4047         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4048         (LeakyPatternTest.test_create_dc): Update for GDIObject instead of adoptPtr/OwnPtr.
4049         (LeakyPatternTest.test_create_compatible_dc): Ditto.
4050
4051 2013-09-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
4052
4053         Unreviewed. Add myself as a committer.
4054
4055         * Scripts/webkitpy/common/config/contributors.json:
4056
4057 2013-09-10  Mark Lam  <mark.lam@apple.com>
4058
4059         Move LayoutTests/fast/js to LayoutTests/js.
4060         https://bugs.webkit.org/show_bug.cgi?id=120899.
4061
4062         Rubber stamped by Filip Pizlo.
4063
4064         Changed scripts to reflect the path change.
4065
4066         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4067         (RunJavaScriptCoreTests.commandComplete):
4068         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4069         (test_fast_js_failure_new_output):
4070         (test_fast_js_crash_new_output):
4071         (test_mozilla_and_fast_js_failure_new_output):
4072         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
4073         (BlackBerry::WebKit::DumpRenderTree::runTests):
4074         * Scripts/make-script-test-wrappers:
4075         (findTemplateFiles):
4076         * Scripts/run-fast-jsc:
4077         * Scripts/run-javascriptcore-tests:
4078         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4079         (TestExpectations):
4080
4081 2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>
4082
4083         [GTK] Missing DRT AccessibilityController::addNotificationListener implementation
4084         https://bugs.webkit.org/show_bug.cgi?id=70606
4085
4086         Reviewed by Mario Sanchez Prada.
4087
4088         Implemented the global notification listener for
4089         AccessibilityController. The signal is generated by
4090         AXObjectCache::postPlatformNotification() and received by
4091         axObjectEventListener(). axObjectEventListener will then invoke
4092         JSObjectCallAsFunction() with the respective callback function.
4093
4094         There is no additional test for this patch since its implementation will
4095         be tested by a11y layout tests that are currently skipped (e.g. bug
4096         98370).
4097
4098         * DumpRenderTree/AccessibilityController.h: Added a global notification
4099         handler for GTK+.
4100         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
4101         (AccessibilityController::AccessibilityController): Initializes the
4102         global handler with 0.
4103         (AccessibilityController::addNotificationListener): Creates the
4104         notification handler and sets the notification function callback.
4105         (AccessibilityController::removeNotificationListener): Removes the
4106         global handler.
4107
4108 2013-09-10  Krzysztof Czech  <k.czech@samsung.com>
4109
4110         [ATK] Incorrect type for holding float value
4111         https://bugs.webkit.org/show_bug.cgi?id=121091
4112
4113         Reviewed by Mario Sanchez Prada.
4114
4115         Variable is not set properly, because of it's type.
4116
4117         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4118         (WTR::alterCurrentValue):
4119
4120 2013-09-10  Allan Sandfeld Jensen  <allan.jensen@digia.com>
4121
4122         [Qt] make use of qtHaveModule() 
4123         https://bugs.webkit.org/show_bug.cgi?id=121090
4124
4125         Reviewed by Jocelyn Turcotte.
4126         Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com>
4127
4128         Use qtHaveModule instead of our own haveQtModule.
4129
4130         * QtTestBrowser/QtTestBrowser.pro:
4131         * qmake/mkspecs/features/configure.prf:
4132         * qmake/mkspecs/features/features.prf:
4133         * qmake/mkspecs/features/functions.prf:
4134
4135 2013-09-10  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
4136
4137         Unreviewed. Add myself as a committer.
4138
4139         * Scripts/webkitpy/common/config/contributors.json:
4140
4141 2013-09-10  Radu Stavila  <stavila@adobe.com>
4142
4143         Unreviewed. Added myself as a committer.
4144
4145         * Scripts/webkitpy/common/config/contributors.json:
4146
4147 2013-09-10  Mario Sanchez Prada  <mario.prada@samsung.com>
4148
4149         [GTK] Test /webkit/atk/getTextInParagraphAndBodyModerate fails
4150         https://bugs.webkit.org/show_bug.cgi?id=105538
4151
4152         Reviewed by Chris Fleizach.
4153
4154         Unskip passing test getTextInParagraphAndBodyModerate.
4155
4156         * Scripts/run-gtk-tests:
4157         (TestRunner): Unskip pasing test.
4158
4159 2013-09-09  Mark Lam  <mark.lam@apple.com>
4160
4161         Remove more references to the deleted js-test-style.css.
4162         https://bugs.webkit.org/show_bug.cgi?id=120899.
4163
4164         Reviewed by Ryosuke Niwa.
4165
4166         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
4167         (translate_includes):
4168
4169 2013-09-09  Mark Lam  <mark.lam@apple.com>
4170
4171         Re-landing r155392 (Point Tools scripts to LayoutTests/resources).
4172         https://bugs.webkit.org/show_bug.cgi?id=120899.
4173
4174         Not reviewed.
4175
4176         The webkitpy test failure that resulted in the rollout is due to
4177         update_webgl_conformance_tests_unittest.py referencing js-test-style.css
4178         which is to be deleted. Deleting that line fixes the issue.
4179
4180         * Scripts/make-new-script-test:
4181         (makePathToSharedSources):
4182         * Scripts/run-fast-jsc:
4183         * Scripts/webkitperl/httpd.pm:
4184         (getDefaultConfigForTestDirectory):
4185         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
4186         (LayoutTestApacheHttpd.__init__):
4187         * Scripts/webkitpy/layout_tests/servers/http_server.py:
4188         (Lighttpd.__init__):
4189         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
4190         (BaseTest.integration_test_port_and_root):
4191         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
4192         (TestHttpServer.test_start_cmd):
4193         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
4194         (translate_includes):
4195         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
4196         (TestTranslation.test_include_rewriting):
4197
4198 2013-09-09  Mark Lam  <mark.lam@apple.com>
4199
4200         Rolling out r155392 (Point Tools scripts to LayoutTests/resources): breaks tests.
4201         https://bugs.webkit.org/show_bug.cgi?id=120899.
4202
4203         Not reviewed.
4204
4205         * Scripts/make-new-script-test:
4206         (makePathToSharedSources):
4207         * Scripts/run-fast-jsc:
4208         * Scripts/webkitperl/httpd.pm:
4209         (getDefaultConfigForTestDirectory):
4210         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
4211         (LayoutTestApacheHttpd.__init__):
4212         * Scripts/webkitpy/layout_tests/servers/http_server.py:
4213         (Lighttpd.__init__):
4214         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
4215         (BaseTest.integration_test_port_and_root):
4216         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
4217         (TestHttpServer.test_start_cmd):
4218         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
4219         (translate_includes):
4220         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
4221         (TestTranslation.test_include_rewriting):
4222
4223 2013-09-09  Mark Lam  <mark.lam@apple.com>
4224
4225         Point Tools scripts to LayoutTests/resources.
4226         https://bugs.webkit.org/show_bug.cgi?id=120899.
4227
4228         Reviewed by Ryosuke Niwa.
4229
4230         * Scripts/make-new-script-test:
4231         (makePathToSharedSources):
4232         * Scripts/run-fast-jsc:
4233         * Scripts/webkitperl/httpd.pm:
4234         (getDefaultConfigForTestDirectory):
4235         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
4236         (LayoutTestApacheHttpd.__init__):
4237         * Scripts/webkitpy/layout_tests/servers/http_server.py:
4238         (Lighttpd.__init__):
4239         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
4240         (BaseTest.integration_test_port_and_root):
4241         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
4242         (TestHttpServer.test_start_cmd):
4243         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
4244         (translate_includes):
4245         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
4246         (TestTranslation.test_include_rewriting):
4247
4248 2013-09-09  Roger Fong  <roger_fong@apple.com>
4249
4250         Unreviewed. Update Cygwin Downloader to include lighttpd and download setup-x86.exe.
4251
4252         * CygwinDownloader/cygwin-downloader.py:
4253         * CygwinDownloader/cygwin-downloader.zip:
4254
4255 2013-09-09  Filip Pizlo  <fpizlo@apple.com>
4256
4257         Unreviewed, fix Ruby exception handling.
4258
4259         * Scripts/run-jsc-stress-tests:
4260
4261 2013-09-09  Filip Pizlo  <fpizlo@apple.com>
4262
4263         Stress tests should test the jsc profiler (-p)
4264         https://bugs.webkit.org/show_bug.cgi?id=121043
4265
4266         Reviewed by Mark Hahnenberg.
4267         
4268         Add a runProfiler command that all tests could use. This requires profiler-test-helper,
4269         which first runs the JS test and then tries the output with display-profiler-output.
4270         But if any of the things required for this to work aren't present, we just do a simpler
4271         test that just uses "-p".
4272         
4273         Because I didn't want to pollute SunSpider with "//@ runProfiler", I added the ability
4274         to create test collections using a yaml file that specifies the test path and the
4275         command to run.
4276
4277         * Scripts/jsc-stress-test-helpers: Added.
4278         * Scripts/jsc-stress-test-helpers/profiler-test-helper: Added.
4279         * Scripts/run-javascriptcore-tests:
4280         * Scripts/run-jsc-stress-tests:
4281
4282 2013-09-09  Zan Dobersek  <zdobersek@igalia.com>
4283
4284         [webkitpy] Remove the DeprecatedPort class
4285         https://bugs.webkit.org/show_bug.cgi?id=121030
4286
4287         Reviewed by Ryosuke Niwa.
4288
4289         Remove the remaining uses of DeprecatedPort, folding its functionality into the Port class.
4290
4291         The various methods returning commands are moved from the DeprecatedPort class into the Port class,
4292         with the Port subclasses overriding specific methods as required.
4293
4294         * Scripts/webkitpy/common/config/port