Add a new Leopard test bot.
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-24  Lucas Forschler  <lforschler@apple.com>
2
3         Reviewed by Stephanie Lewis.
4
5         Add a new Leopard test bot.
6
7         * BuildSlaveSupport/build.webkit.org-config/config.json:
8
9 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
10
11         Reviewed by Adam Barth.
12
13         Add EFL Builder to core waterfall
14         https://bugs.webkit.org/show_bug.cgi?id=52704
15
16         Add EFL Builder to the core waterfall again.
17
18         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
19         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
20
21 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
22
23         Reviewed by Tony Chang.
24
25         new-run-webkit-tests fails to start HTTP server if there are proxy settings
26         https://bugs.webkit.org/show_bug.cgi?id=52872
27
28         Force disabling proxy to resolve the problem.
29
30         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
31         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
32
33 2011-01-24  Andreas Kling  <kling@webkit.org>
34
35         Reviewed by Darin Adler.
36
37         check-webkit-style: Update exemptions following Source/ move.
38         https://bugs.webkit.org/show_bug.cgi?id=53017
39
40         * Scripts/webkitpy/style/checker.py:
41         * Scripts/webkitpy/style/checker_unittest.py:
42
43 2011-01-24  Andras Becsi  <abecsi@webkit.org>
44
45         Rubber-stamped by Csaba Osztrogonác.
46
47         [Qt] Move project files into Source
48         https://bugs.webkit.org/show_bug.cgi?id=52891
49
50         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
51
52 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
53
54         Reviewed by Yury Semikhatsky.
55
56         Web Inspector: Find duplicate strings in localizedStrings.js
57
58         https://bugs.webkit.org/show_bug.cgi?id=53005
59
60         * Scripts/check-inspector-strings:
61
62 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
63
64         Reviewed by Andreas Kling.
65
66         [Qt] Regroup MiniBrowser's menubar and add open file action
67         https://bugs.webkit.org/show_bug.cgi?id=53000
68
69         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
70
71         * MiniBrowser/qt/BrowserWindow.cpp:
72         (BrowserWindow::BrowserWindow):
73         (BrowserWindow::openFile):
74         (BrowserWindow::~BrowserWindow):
75         * MiniBrowser/qt/BrowserWindow.h:
76
77 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
78
79         Unreviewed fix after r76496
80
81         [Qt] Move project files into Source
82         https://bugs.webkit.org/show_bug.cgi?id=52891
83
84         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
85         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
86         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
87
88 2011-01-24  Andras Becsi  <abecsi@webkit.org>
89
90         Reviewed by Csaba Osztrogonác.
91
92         [Qt] Move project files into Source
93         https://bugs.webkit.org/show_bug.cgi?id=52891
94
95         * DerivedSources.pro: Renamed from DerivedSources.pro.
96         * DumpRenderTree/qt/DumpRenderTree.pro:
97         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
98         * MiniBrowser/DerivedSources.pro:
99         * MiniBrowser/qt/MiniBrowser.pro:
100         * QtTestBrowser/QtTestBrowser.pro:
101         * Scripts/webkitdirs.pm:
102         * Tools.pro: Added.
103         * WebKitTestRunner/DerivedSources.pro:
104         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
105         * WebKitTestRunner/qt/WebKitTestRunner.pro:
106
107 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
108
109         Reviewed by Dan Bernstein.
110
111         Beefed up --threaded mode to catch even more kinds of errors.
112         https://bugs.webkit.org/show_bug.cgi?id=52971
113
114         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
115         context group to force JSC to mark multiple threads. (This used to be
116         the default, but it changed in SnowLeopard.)
117         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
118         to give threading mistakes more chances to show themselves.
119         (startJavaScriptThreads):
120         (stopJavaScriptThreads):
121
122 2011-01-22  Robert Hogan  <robert@webkit.org>
123
124         Reviewed by Andreas Kling.
125
126         [Qt] Support layoutTestController.addURLToRedirect()
127         https://bugs.webkit.org/show_bug.cgi?id=52956
128
129         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
130         (LayoutTestController::addURLToRedirect):
131         * DumpRenderTree/qt/LayoutTestControllerQt.h:
132
133 2011-01-22  Robert Hogan  <robert@webkit.org>
134
135         Reviewed by Kenneth Rohde Christiansen.
136
137         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
138         https://bugs.webkit.org/show_bug.cgi?id=49802
139
140         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
141         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
142         (WebCore::DumpRenderTree::open):
143
144 2011-01-21  Adam Barth  <abarth@webkit.org>
145
146         Reviewed by Maciej Stachowiak.
147
148         Disable mac_unittest.py that fails on some of the Mac bots
149         https://bugs.webkit.org/show_bug.cgi?id=52947
150
151         As noted in the comment, this test does not appear to be correct
152         because the function this test is testing returns different results
153         depending on which flavor of Mac the test is run on.  This patch
154         disable the test.  Hopefully we can re-enable the test once we've
155         probably insulated the test from its environment.
156
157         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
158
159 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
160
161         Reviewed by Mihai Parparita.
162
163         Fix bug introduced in r76322 that caused NRWT to not actually
164         read the Skipped files properly.
165
166         https://bugs.webkit.org/show_bug.cgi?id=52771
167
168         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
169         * Scripts/webkitpy/layout_tests/port/webkit.py:
170         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
171
172 2011-01-21  Sam Weinig  <sam@webkit.org>
173
174         Reviewed by Geoffrey Sean Garen and Mark Rowe.
175
176         WebKitTestRunner needs the HOME environment variable to be set.
177         <rdar://problem/8896573>
178
179         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
180         it exists.
181
182 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
183
184         Reviewed by Eric Seidel.
185
186         Suppress a few remaining integration tests so that none of the
187         layout_test unit tests ever read from the filesystem or launch
188         subprocesses that aren't part of the unit tests.
189
190         Also fix a minor bug in the printing unit tests that was
191         incorrectly relying on sys.argv.
192
193         https://bugs.webkit.org/show_bug.cgi?id=52863
194
195         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
196         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
197         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
198
199 2011-01-21  Darin Adler  <darin@apple.com>
200
201        Fix Mac build.
202
203         * MiniBrowser/mac/BrowserWindowController.m:
204         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
205
206 2011-01-20  Darin Adler  <darin@apple.com>
207
208         Reviewed by Dan Bernstein.
209
210         WebKit2: Implement showModalDialog
211         https://bugs.webkit.org/show_bug.cgi?id=52855
212
213         This fixes WebKitTestRunner to compile, but more work is probably
214         needed to get it to pass the tests.
215
216         * WebKitTestRunner/TestController.cpp:
217         (WTR::TestController::runModal): Added. Calls through to the
218         platform-specific version of runModal.
219         (WTR::TestController::createOtherPage): Changed to be a private
220         static member function so it can refer to runModal, which is
221         a private static member function.
222         (WTR::TestController::initialize): Pass 0 for the runModal
223         function since we don't need to run the main window modal.
224         I suspect this is wrong and will need to change.
225         * WebKitTestRunner/TestController.h: Added declarations for
226         the functions added above.
227         * WebKitTestRunner/mac/TestControllerMac.mm:
228         (WTR::TestController::runModal): Added. Untested implementation.
229         * WebKitTestRunner/qt/TestControllerQt.cpp:
230         (WTR::TestController::runModal): Added.
231         * WebKitTestRunner/win/TestControllerWin.cpp:
232         (WTR::TestController::runModal): Added.
233
234 2011-01-21  Eric Seidel  <eric@webkit.org>
235
236         Reviewed by Adam Barth.
237
238         Split Host object off from WebKitPatch for easier re-use
239         https://bugs.webkit.org/show_bug.cgi?id=52284
240
241         new-run-webkit-tests and other tools are eventually going to want one of these.
242         Basically you need to inherit from this class if you want to pretend to be a
243         self.tool object for Steps/Commands.
244
245         * Scripts/webkitpy/common/host.py: Added.
246         * Scripts/webkitpy/tool/main.py:
247
248 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
249
250         Reviewed by Adam Barth.
251
252         Disable the tests that start and stop the http server and web
253         server, so that we don't have to worry about port collisions on
254         the bots.
255
256         https://bugs.webkit.org/show_bug.cgi?id=52861
257
258         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
259
260 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
261
262         Reviewed by Eric Seidel.
263
264         nrwt: rewrite google_chrome_unittest to use mock filesystem.
265         
266         https://bugs.webkit.org/show_bug.cgi?id=52772
267         
268         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
269
270 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
271
272         Reviewed by Eric Siedel.
273
274         nrwt: clean up almost all remaining port references, remove
275         unnecessary import clauses. The only remaining references are
276         in places where a mock filesystem makes no sense or can't be
277         used, and in one routine in port/google_chrome_unittest that
278         I'll rewrite in a separate patch.
279
280         https://bugs.webkit.org/show_bug.cgi?id=52771
281
282         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
283         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
284         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
285         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
286         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
287         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
288         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
289         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
290         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
291         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
292         * Scripts/webkitpy/layout_tests/port/gtk.py:
293         * Scripts/webkitpy/layout_tests/port/mac.py:
294         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
295         * Scripts/webkitpy/layout_tests/port/qt.py:
296         * Scripts/webkitpy/layout_tests/port/webkit.py:
297         * Scripts/webkitpy/layout_tests/port/win.py:
298         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
299
300 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
301
302         Reviewed by Mihai Parparita.
303
304         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
305
306         https://bugs.webkit.org/show_bug.cgi?id=52762
307
308         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
309         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
310
311 2011-01-20  Tony Chang  <tony@chromium.org>
312
313         Reviewed by Ojan Vafai.
314
315         [chromium] fix the paths used for the rebaseline tool
316         https://bugs.webkit.org/show_bug.cgi?id=52857
317
318         Some of the bots were renamed so the path to grab the results zip
319         file has changed.
320
321         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
322
323 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
324
325         Reviewed by Tony Chang.
326
327         Fix bug introduced in r72688 / bug 52768 that broke the
328         generation of the output filename links in the results.html
329         output. Apparently none of the unit tests actually checked to
330         make sure the generated links were correct :(
331
332         https://bugs.webkit.org/show_bug.cgi?id=52854
333
334         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
335         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
336
337 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
338
339         Reviewed by Darin Adler.
340
341         https://bugs.webkit.org/show_bug.cgi?id=52849
342         Make window.print work with WebKit2
343
344         * MiniBrowser/mac/BrowserWindowController.m:
345         (-[BrowserWindowController awakeFromNib]):
346         * WebKitTestRunner/TestController.cpp:
347         (WTR::createOtherPage):
348         (WTR::TestController::initialize):
349         Added zeroes to WKPageUIClient structures to avoid build failures.
350
351 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
352
353         Reviewed by Eric Seidel.
354
355         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
356
357         https://bugs.webkit.org/show_bug.cgi?id=52756
358
359         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
360         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
361         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
362         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
363         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
364         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
365
366 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
367
368         Reviewed by Antonio Gomes.
369
370         QtTestBrowser should have a seperate menu for Settings
371         https://bugs.webkit.org/show_bug.cgi?id=52817
372         
373         Added a new menu item named "Settings"
374         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
375
376         * QtTestBrowser/launcherwindow.cpp:
377         (LauncherWindow::createChrome):
378
379 2011-01-20  Sam Weinig  <sam@webkit.org>
380
381         Reviewed by John Sullivan.
382
383         Update update-webkit-localizable-strings with new path to WebKit.
384
385         * Scripts/update-webkit-localizable-strings:
386
387 2011-01-20  James Robinson  <jamesr@chromium.org>
388
389         Reviewed by Darin Fisher.
390
391         Implement mozilla's requestAnimationFrame API
392         https://bugs.webkit.org/show_bug.cgi?id=51218
393
394         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
395
396         * DumpRenderTree/chromium/WebViewHost.cpp:
397         (invokeScheduleComposite):
398         (WebViewHost::scheduleAnimation):
399         (WebViewHost::paintInvalidatedRegion):
400         * DumpRenderTree/chromium/WebViewHost.h:
401
402 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
403
404         Reviewed by Adam Roben.
405
406         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
407         https://bugs.webkit.org/show_bug.cgi?id=42327
408
409         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
410         for methods that take their normal arguments but also a JSContextRef.
411         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
412         for evaluateScriptInIsolatedWorld.
413         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
414         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
415         this call is for an isolated world.
416         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
417         (WTR::worldMap): Helper to create a world map.
418         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
419         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
420         added LayoutTestController API.
421         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
422
423 2011-01-19  Adam Roben  <aroben@apple.com>
424
425         Convert paths in environment variables back to msys-style inside commit-log-editor
426
427         When this script gets run from inside git commit, msys-style paths in the environment will
428         have been turned into Windows-style paths with forward slashes. This screws up functions
429         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
430         the paths back to msys-style before doing anything else.
431
432         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
433         using msysgit's Perl and multiple ChangeLogs have been edited
434
435         Reviewed by David Kilzer.
436
437         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
438         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
439         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
440
441 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
442
443         [Win] Unreviewed build fix after r76248.
444
445         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
446
447 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
448
449         Reviewed by Csaba Osztrogonác.
450
451         Refactoring of the custom allocation framework
452         https://bugs.webkit.org/show_bug.cgi?id=49897
453
454         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
455         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
456         equivalent macro implementation at the necessary places.
457 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
458
459         Unreviewed. 
460
461         Adding myself to committers.py.
462
463         * Scripts/webkitpy/common/config/committers.py:
464
465 2011-01-20  Adam Barth  <abarth@webkit.org>
466
467         Reviewed by Tony Chang.
468
469         Chromium builders don't delete unversioned directories when DEPS change
470         https://bugs.webkit.org/show_bug.cgi?id=52745
471
472         If we pass this option to gclient sync, gclient will delete directories
473         that are no longer part of DEPS instead of leaving them around to
474         confuse us later.  Apparently, the downstream buildbots use this option
475         already.
476
477         * Scripts/update-webkit-chromium:
478
479 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
480
481         Unreviewed, build fix - I pulled this patch in to fix an issue
482         revealed by r76195 running on some new bots). Also fix a couple
483         of other issues revealed in testing.
484
485         nrwt: remove fs refs from layout_package/json*
486
487         https://bugs.webkit.org/show_bug.cgi?id=52754
488
489         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
490         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
491         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
492         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
493         * Scripts/webkitpy/layout_tests/port/base.py:
494
495 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
496
497         Unreviewed, build fix.
498
499         Fix a couple of minor bugs discovered while bringing up new bots
500         for testing.
501
502         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
503         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
504
505 2011-01-19  James Robinson  <jamesr@chromium.org>
506
507         Unreviewed, rolling out r76194.
508         http://trac.webkit.org/changeset/76194
509         https://bugs.webkit.org/show_bug.cgi?id=51218
510
511         Caused mysterious compile failure on the chromium win
512         build.webkit.org bots
513
514         * DumpRenderTree/chromium/WebViewHost.cpp:
515         (WebViewHost::paintInvalidatedRegion):
516         * DumpRenderTree/chromium/WebViewHost.h:
517
518 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
519
520         Reviewed by Mihai Parparita.
521
522         remove fs refs from test_runner, dump_render_tree_thread
523
524         https://bugs.webkit.org/show_bug.cgi?id=52753
525
526         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
527         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
528         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
529         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
530
531 2011-01-19  James Robinson  <jamesr@chromium.org>
532
533         Reviewed by Darin Fisher.
534
535         Implement mozilla's requestAnimationFrame API
536         https://bugs.webkit.org/show_bug.cgi?id=51218
537
538         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
539
540         * DumpRenderTree/chromium/WebViewHost.cpp:
541         (invokeScheduleComposite):
542         (WebViewHost::scheduleAnimation):
543         (WebViewHost::paintInvalidatedRegion):
544         * DumpRenderTree/chromium/WebViewHost.h:
545
546 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
547
548         Unreviewed, build fix.
549
550         Fix a few incorrect "self._filesystem" references introduced in
551         r76184.
552
553         * Scripts/webkitpy/layout_tests/port/chromium.py:
554         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
555
556 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
557
558         Reviewed by Mihai Parparita.
559
560         add a .sep property, abspath(), isabs(), mtime(), and
561         open_text_file_for_writing() to filesystem modules. Some of
562         these properties are not needed in this patch but will be needed
563         in subsequent patches (I'm doing this to avoid having to track
564         multiple versions of a single file).
565
566         Also, change most of the port/* modules to use the filesystem
567         objects instead of referencing the filesystem directly.
568
569         https://bugs.webkit.org/show_bug.cgi?id=52748
570
571         * Scripts/webkitpy/common/system/filesystem.py:
572         * Scripts/webkitpy/common/system/filesystem_mock.py:
573         * Scripts/webkitpy/layout_tests/port/__init__.py:
574         * Scripts/webkitpy/layout_tests/port/base.py:
575         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
576         * Scripts/webkitpy/layout_tests/port/chromium.py:
577         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
578         * Scripts/webkitpy/layout_tests/port/config.py:
579         * Scripts/webkitpy/layout_tests/port/test.py:
580         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
581
582 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
583
584         Reviewed by Anders Carlsson.
585
586         If resetting between tests times out, treat it as a WebProcess crash
587         https://bugs.webkit.org/show_bug.cgi?id=52757
588
589         * WebKitTestRunner/TestController.cpp:
590         (WTR::TestController::runTest):
591
592 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
593
594         Reviewed by Darin Adler.
595
596         https://bugs.webkit.org/show_bug.cgi?id=52739
597         Make it possible for a WebKit2 client to print headers and footers
598
599         Added dummy implementations for new printing UIClient calls.
600
601         * MiniBrowser/mac/BrowserWindowController.m:
602         (-[BrowserWindowController awakeFromNib]):
603         * WebKitTestRunner/TestController.cpp:
604         (WTR::createOtherPage):
605         (WTR::TestController::initialize):
606
607 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
608
609         Reviewed by Ojan Vafai.
610
611         Change webkitpy/layout_tests/port/test.py to use the
612         in-memory filesystem for cleaner unit testing. This
613         change allows us to kill a lot of code that was
614         specific to the test port, at the cost of being a
615         little less clear about how things would work if
616         you didn't have a filesystem.
617
618         https://bugs.webkit.org/show_bug.cgi?id=52605
619
620         * Scripts/webkitpy/layout_tests/port/test.py:
621
622 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
623
624         Unreviewed, build fix.
625
626         Fix test failure caused by committing attachment 79368 instead
627         of attachment 79461 on bug 52604.
628
629         * Scripts/webkitpy/common/system/filesystem_mock.py:
630
631 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
632
633         Reviewed by Mihai Parparita.
634
635         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
636         unit testing. os.walk() is too much of a hassle to implement on
637         top of the in-memory mock filesystem and adding the necessary
638         interface to files_under() gives clients a cleaner API anyway
639         (for this particular usage model).
640
641         https://bugs.webkit.org/show_bug.cgi?id=52691
642
643         * Scripts/webkitpy/common/system/filesystem.py:
644         * Scripts/webkitpy/common/system/filesystem_mock.py:
645         * Scripts/webkitpy/layout_tests/port/test_files.py:
646         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
647
648 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
649
650         Reviewed by Tony Chang.
651
652         Change more modules in the layout-tests code to use the
653         filesystem wrapper for cleaner unit testing.
654
655         This patch also adds the glob() wrapper to the filesystem
656         abstraction.
657         
658         https://bugs.webkit.org/show_bug.cgi?id=52604
659
660         * Scripts/webkitpy/layout_tests/port/test_files.py:
661         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
662         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
663         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
664         * Scripts/webkitpy/common/system/filesystem.py:
665         * Scripts/webkitpy/common/system/filesystem_mock.py:
666
667 2011-01-19  Levi Weintraub  <leviw@chromium.org>
668
669         Unreviewed.
670
671         Updating my email addresses and irc nick.
672
673         * Scripts/webkitpy/common/config/committers.py:
674
675 2011-01-19  Tony Chang  <tony@chromium.org>
676
677         Reviewed by Mihai Parparita.
678
679         [chromium] [linux] if check-sys-deps fails, output the failure reason
680         https://bugs.webkit.org/show_bug.cgi?id=52671
681
682         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
683             error handler functions.
684         * Scripts/webkitpy/layout_tests/port/chromium.py:
685             output the error text from --check-sys-deps
686         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
687
688 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
689
690         Reviewed by Andreas Kling.
691
692         [Qt] QtTestBrowser crashes when closing if Facebook is opened
693         https://bugs.webkit.org/show_bug.cgi?id=52554
694         
695         QtNetworkAccessManager is created in a thread and set as
696         member variable in QWebPage. When the thread is destroyed
697         the object is still used. So fix will set the object to
698         NULL once the thread is destroyed.
699
700         * QtTestBrowser/launcherwindow.cpp:
701         (LauncherWindow::~LauncherWindow):
702
703 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
704
705         Rubber stamped by Csaba Osztrogonac
706
707         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
708
709 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
710
711         Reviewed by Tony Chang.
712
713         new-run-webkit-tests: add a --build-directory command line argument
714
715         Official Google Chrome builds use a non-standard build directory
716         location. This patch adds a --build-directory argument that
717         allows that location to be specified on the command line. Only
718         Chromium-based builds will use this flag for now, but anyone can
719         in the future.
720
721         There are no unit tests for this since it's difficult to test
722         until mock filesystems are fully supported in the code. This was
723         tested by hand for now.
724
725         https://bugs.webkit.org/show_bug.cgi?id=52694
726
727         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
728         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
729         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
730         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
731
732 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
733
734         Not reviewed. Bot fix.
735
736         Remove an inadvertently committed debugging print.
737
738         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
739         (LayoutTestController::notifyDone):
740
741 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
742
743         Reviewed by Sam Weinig.
744
745         WebKitTestRunner should track loading more like DumpRenderTree
746         https://bugs.webkit.org/show_bug.cgi?id=52692
747
748         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
749         This makes some tests that call notifyDone multiple times pass.
750         
751         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
752         (WTR::InjectedBundle::InjectedBundle):
753         (WTR::InjectedBundle::done):
754         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
755         (WTR::InjectedBundle::topLoadingFrame):
756         (WTR::InjectedBundle::setTopLoadingFrame):
757         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
758         (WTR::InjectedBundlePage::InjectedBundlePage):
759         (WTR::InjectedBundlePage::stopLoading):
760         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
761         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
762         (WTR::InjectedBundlePage::didFinishLoadForFrame):
763         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
764         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
765         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
766         (WTR::LayoutTestController::notifyDone):
767         * WebKitTestRunner/TestController.cpp:
768         (WTR::TestController::didReceiveMessageFromInjectedBundle):
769
770 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
771
772         Reviewed by Kent Tamura.
773
774         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
775         https://bugs.webkit.org/show_bug.cgi?id=52678
776         
777         Update path now that WebKit is inside Source.
778
779         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
780
781 2011-01-18  Robert Hogan  <robert@webkit.org>
782
783         Reviewed by Simon Hausmann.
784
785         [Qt] http/tests/incremental/slow-utf8-text.pl fails
786         https://bugs.webkit.org/show_bug.cgi?id=44282
787
788         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
789         (WebCore::DumpRenderTree::dump):
790
791 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
792
793         Reviewed by Mihai Parparita.
794
795         Fix a small race condition that could cause the unit tests for
796         new-run-webkit-tests to fail in a multithreaded environment.
797         There was a small window in the code where one thread would
798         check to see if a thread had raised an exception, do something,
799         and then check to see if the thread was alive. If the other
800         thread raised an exception and exited in between these two
801         steps, the exception would be lost. Flipping the order of the
802         two checks fixes the race, since we will now always check for an
803         exception on the thread before exiting.
804
805         https://bugs.webkit.org/show_bug.cgi?id=51579
806
807         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
808
809 2011-01-18  Eric Seidel  <eric@webkit.org>
810
811         Reviewed by Adam Barth.
812
813         commit-queue dies when test archiving fails
814         https://bugs.webkit.org/show_bug.cgi?id=52617
815
816         I looked at the machine and it had 10 archives already
817         thus find_unused_name was returning None.  I've upped
818         the limit to 100 (per bug) and tested the case where
819         find_unused_name returns None (making archive return None).
820
821         * Scripts/webkitpy/common/system/workspace.py:
822         * Scripts/webkitpy/common/system/workspace_unittest.py:
823         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
824         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
825         * Scripts/webkitpy/tool/commands/queues.py:
826
827 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
828
829         Reviewed by Ojan Vafai.
830
831         Update rebaseline-chromium-webkit-tests unit tests to use a mock
832         filesystem. Also fix a couple of "with" statements missed by
833         r76050.
834
835         https://bugs.webkit.org/show_bug.cgi?id=52487
836
837         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
838
839 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
840
841         Reviewed by Martin Robinson.
842
843         [Gtk] Build fixes for gtk3 build
844         https://bugs.webkit.org/show_bug.cgi?id=52648
845
846         * DumpRenderTree/gtk/EventSender.cpp:
847         (beginDragWithFilesCallback):
848
849 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
850
851         Reviewed by Mihai Parparita.
852
853         Update rebaseline-chromium-webkit-tests to use filesystem objects
854         instead of direct references to os.path, shutil, tempfile, etc.
855
856         This patch doesn't change anything, but will allow subsequent
857         patches to change the unit tests to no longer use the real
858         filesystem.
859
860         This patch adds a bunch more methods to the filesystem object as
861         well.
862
863         https://bugs.webkit.org/show_bug.cgi?id=52482
864
865         * Scripts/webkitpy/common/system/filesystem.py:
866         * Scripts/webkitpy/common/system/filesystem_mock.py:
867         * Scripts/webkitpy/tool/commands/queues.py:
868         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
869         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
870
871 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
872
873         Reviewed by Mihai Parparita.
874
875         new-run-webkit-tests shouldn't crash when you try to run a
876         directory containing only skipped files.
877
878         https://bugs.webkit.org/show_bug.cgi?id=52478
879         
880         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
881         * Scripts/webkitpy/layout_tests/port/test.py:
882         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
883
884 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
885
886         Reviewed by Gustavo Noronha Silva.
887
888         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
889         https://bugs.webkit.org/show_bug.cgi?id=40833
890
891         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
892         GTK+ event sender.
893         (dragWithFilesDragDataGetCallback): Added.
894         (dragWithFilesDragEndCallback): Added.
895         (beginDragWithFilesCallback): Added.
896
897 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
898
899         Reviewed by Adam Barth.
900
901         ews: Add additional watcher to efl ews
902         https://bugs.webkit.org/show_bug.cgi?id=52613
903
904         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
905
906         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
907
908 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
909
910         Reviewed by Alexey Proskuryakov.
911
912         Fix some headers with missing or misspelled #ifndef guards
913         https://bugs.webkit.org/show_bug.cgi?id=52545
914
915         * DumpRenderTree/chromium/TestEventPrinter.h:
916         * DumpRenderTree/chromium/WebPreferences.h:
917
918 2011-01-17  Jessie Berlin  <jberlin@apple.com>
919
920         Reviewed by Anders Carlsson.
921
922         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
923         navigating back to an unreachable URL
924         https://bugs.webkit.org/show_bug.cgi?id=52388
925
926         Add a third parameter (unreachableURL) to queueLoadHTMLString.
927
928         * DumpRenderTree/LayoutTestController.cpp:
929         (queueLoadHTMLStringCallback):
930         (LayoutTestController::queueLoadHTMLString):
931         (LayoutTestController::queueLoadAlternateHTMLString):
932         * DumpRenderTree/LayoutTestController.h:
933
934         * DumpRenderTree/WorkQueueItem.h:
935         (LoadHTMLStringItem::LoadHTMLStringItem):
936
937         * DumpRenderTree/chromium/LayoutTestController.cpp:
938         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
939         (WorkItemLoadHTMLString::run):
940         (LayoutTestController::queueLoadHTMLString):
941
942         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
943         (LoadHTMLStringItem::invoke):
944         * DumpRenderTree/mac/WorkQueueItemMac.mm:
945         (LoadHTMLStringItem::invoke):
946         * DumpRenderTree/win/WorkQueueItemWin.cpp:
947         (LoadHTMLStringItem::invoke):
948
949 2011-01-17  Dan Bernstein  <mitz@apple.com>
950
951         Rubber-stamped by Mark Rowe.
952
953         Update xcodeproj svn:ignore to include xcuserdata.
954
955         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
956         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
957         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
958         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
959         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
960
961 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
962
963         Unreviewed fix after r75908.
964
965         Move WebKit into Source
966         https://bugs.webkit.org/show_bug.cgi?id=52530
967
968         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
969
970 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
971
972         Unreviewed.
973
974         Remove accidentally committed debug printing after r75908.
975
976         * Scripts/webkitdirs.pm:
977
978 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
979
980         Unreviewed.
981
982         Add myself to committers list
983         https://bugs.webkit.org/show_bug.cgi?id=52566
984
985         * Scripts/webkitpy/common/config/committers.py:
986
987 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
988
989         Reviewed by Jeremy Orlow.
990
991         GeolocationController should call stopUpdating on destruction
992         https://bugs.webkit.org/show_bug.cgi?id=52216
993
994         fast/dom/Geolocation/window-close-crash.html requires that a
995         Geolocation watch be started in a secondary window. Consequently,
996         we need to allow geolocation permission and provide a mock
997         geolocation position for the secondary window's
998         GeolocationClientMock.
999
1000         * DumpRenderTree/chromium/LayoutTestController.cpp:
1001         (LayoutTestController::setGeolocationPermission):
1002         (LayoutTestController::setMockGeolocationPosition):
1003         (LayoutTestController::setMockGeolocationError):
1004         * DumpRenderTree/chromium/TestShell.h:
1005         (TestShell::windowList):
1006
1007 2011-01-16  Adam Barth  <abarth@webkit.org>
1008
1009         Update more include paths to reflect WebKit move.
1010
1011         * DumpRenderTree/chromium/EventSender.cpp:
1012         (EventSender::keyDown):
1013         (EventSender::needsShiftModifier):
1014         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1015         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1016
1017 2011-01-16  Kent Tamura  <tkent@chromium.org>
1018
1019         Unreviewed, Chromium build fix.
1020
1021         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1022
1023 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1024
1025         Build fix for GTK+ after source directory movement.
1026
1027         * GNUmakefile.am: Correct include paths.
1028
1029 2011-01-16  Adam Barth  <abarth@webkit.org>
1030
1031         Teach svn-apply about WebKit move.
1032
1033         * Scripts/VCSUtils.pm:
1034
1035 2011-01-16  Adam Barth  <abarth@webkit.org>
1036
1037         Rubber-stamped by Eric Seidel.
1038
1039         Move WebKit into Source
1040         https://bugs.webkit.org/show_bug.cgi?id=52530
1041
1042         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1043         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1044         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1045         * DumpRenderTree/qt/GCControllerQt.cpp:
1046         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1047         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1048         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1049         * DumpRenderTree/wscript:
1050         * QtTestBrowser/launcherwindow.h:
1051         * Scripts/build-webkit:
1052         * Scripts/webkitdirs.pm:
1053
1054 2011-01-15  Adam Barth  <abarth@webkit.org>
1055
1056         Teach svn-apply about WebKit2 move.
1057
1058         * Scripts/VCSUtils.pm:
1059
1060 2011-01-15  Adam Barth  <abarth@webkit.org>
1061
1062         Rubber-stamped by Eric Seidel.
1063
1064         Move WebKit2 into Source
1065         https://bugs.webkit.org/show_bug.cgi?id=52438
1066
1067         * MiniBrowser/qt/MiniBrowser.pro:
1068         * Scripts/build-webkit:
1069         * Scripts/do-file-rename:
1070         * Scripts/do-webcore-rename:
1071         * Scripts/test-webkitpy:
1072         * Scripts/webkitdirs.pm:
1073         * Scripts/webkitpy/style/checker.py:
1074         * WebKitTestRunner/DerivedSources.pro:
1075         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1076         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1077
1078 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1079
1080         Reviewed by David Levin.
1081
1082         [chromium] remove obsolete createView method
1083         https://bugs.webkit.org/show_bug.cgi?id=52437
1084
1085         * DumpRenderTree/chromium/WebViewHost.cpp:
1086         (WebViewHost::createView):
1087         * DumpRenderTree/chromium/WebViewHost.h:
1088
1089 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1090
1091         Reviewed by Geoff Garen.
1092
1093         ShouldLoadResourceForFrame should use strings, not URLs.
1094         https://bugs.webkit.org/show_bug.cgi?id=52476
1095
1096         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1097         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1098         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1099
1100 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1101
1102         Reviewed by David Levin.
1103
1104         Add Tony Gentilcore as a reviewer
1105         https://bugs.webkit.org/show_bug.cgi?id=52480
1106
1107         * Scripts/webkitpy/common/config/committers.py:
1108
1109 2011-01-14  David Levin  <levin@chromium.org>
1110
1111         Reviewed by Eric Seidel.
1112
1113         check-webkit-style: _FunctionState should keep track of where the function name starts.
1114         https://bugs.webkit.org/show_bug.cgi?id=52454
1115
1116         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1117         _FunctionState and logic for setting it correctly.
1118         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1119
1120 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1121
1122         Reviewed by David Levin.
1123
1124         Add support to DumpRenderTree to use the GPU rather than software renderer
1125         https://bugs.webkit.org/show_bug.cgi?id=52333
1126
1127         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1128         (main):
1129         * Scripts/webkitpy/layout_tests/port/chromium.py:
1130         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1131
1132 2011-01-14  Tony Chang  <tony@chromium.org>
1133
1134         Reviewed by Kent Tamura.
1135
1136         [chromium] update fonts.conf to fix 6 linux tests in drt
1137         https://bugs.webkit.org/show_bug.cgi?id=52411
1138
1139         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1140             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1141
1142 2011-01-14  Eric Seidel  <eric@webkit.org>
1143
1144         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1145
1146         Reviewed by Adam Barth.
1147
1148         Fix when running Tools/Scripts/check-webkit-style without arguments.
1149         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1150
1151         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1152         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1153
1154 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1155
1156         Reviewed by David Levin.
1157
1158         Store the tempdir object in a variable so it doesn't get deleted too early.
1159         https://bugs.webkit.org/show_bug.cgi?id=51875
1160
1161         * Scripts/update-webkit-auxiliary-libs:
1162         * Scripts/update-webkit-support-libs:
1163
1164 2011-01-14  Eric Seidel  <eric@webkit.org>
1165
1166         Unreviewed.  Make it work in python 2.5.
1167
1168         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1169         https://bugs.webkit.org/show_bug.cgi?id=49158
1170
1171         * Scripts/webkitpy/common/checkout/api_unittest.py:
1172
1173 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1174
1175         Unreviewed, rolling out r75774.
1176         http://trac.webkit.org/changeset/75774
1177         https://bugs.webkit.org/show_bug.cgi?id=52431
1178
1179         gtk builds were broken (Requested by loislo2 on #webkit).
1180
1181         * Scripts/webkitpy/common/checkout/scm.py:
1182
1183 2011-01-14  David Levin  <levin@chromium.org>
1184
1185         Reviewed by Shinichiro Hamaji.
1186
1187         check-webkit-style: _FunctionState should detect pure functions.
1188         https://bugs.webkit.org/show_bug.cgi?id=52428
1189
1190         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1191         is a pure virtual function.
1192         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1193         virtual functions are correctly detected.
1194
1195 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1196
1197         Reviewed by Yury Semikhatsky.
1198
1199         Just small fix for problem with check-webkit-style.
1200         It just didn't work for this patch.
1201         Old code can't concatenate a list of strings with None.
1202
1203         * Scripts/webkitpy/common/checkout/scm.py:
1204
1205 2011-01-13  David Levin  <levin@chromium.org>
1206
1207         Reviewed by Shinichiro Hamaji.
1208
1209         check-webkit-style: _FunctionState should use Position to know where items are.
1210         https://bugs.webkit.org/show_bug.cgi?id=52424
1211
1212         * Scripts/webkitpy/style/checkers/cpp.py:
1213         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1214         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1215         did some minor clean-up.
1216         (*): Other changes are simply about converting to use the Position's in_FunctionState
1217         instead of line numbers.
1218         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1219         to verify the positions stored in _FunctionState.
1220
1221 2011-01-13  Eric Seidel  <eric@webkit.org>
1222
1223         Reviewed by David Levin.
1224
1225         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1226         https://bugs.webkit.org/show_bug.cgi?id=49158
1227
1228         This is not the most elegant, but it is a very safe fix to this bug.
1229         One advantage of catching ScriptError like this instead of adding a
1230         new added_or_modified_files or fixing all changed_files callers
1231         to use a more specific change_files variant, is that we catch
1232         all kinds of ScriptErrors which might cause our (non-essential)
1233         suggest-reviewers code to fail out.  This should make passing
1234         --suggest-reviewers to webkit-patch upload much more robust
1235         and may even make it possible for us to make it default.
1236
1237         The root of the problem here is that SCM.changed_files includes
1238         deleted ChangeLog paths (from moves, etc) which then when we ask
1239         SVN/Git for the contents of the file at that revision, the command
1240         errors out and Executive.run_command raises a ScriptError.
1241
1242         In the future we might fix this differently by making all current
1243         callers of chagned_files use a more specific method for requesting
1244         what types of changes they're interested in (adds, modifies, deletes, etc.)
1245
1246         * Scripts/webkitpy/common/checkout/api.py:
1247         * Scripts/webkitpy/common/checkout/api_unittest.py:
1248
1249 2011-01-13  Dan Bernstein  <mitz@apple.com>
1250
1251         Reviewed by Alexey Proskuryakov.
1252
1253         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1254         https://bugs.webkit.org/show_bug.cgi?id=52419
1255
1256         Allow to further control the behavior of the willSendRequest delegate callback by making it
1257         set a different URL in the new request.
1258
1259         * DumpRenderTree/LayoutTestController.cpp:
1260         (addURLToRedirectCallback): Added.
1261         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1262         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1263         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1264         * DumpRenderTree/LayoutTestController.h:
1265         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1266         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1267         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1268         change the URL in the new request to the redirect destination.
1269
1270 2011-01-13  Eric Seidel  <eric@webkit.org>
1271
1272         Reviewed by Mihai Parparita.
1273
1274         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1275         https://bugs.webkit.org/show_bug.cgi?id=52416
1276
1277         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1278         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1279
1280         I also added FIXMEs about the changed_files returning deleted files problem
1281         which is causing the other most common exception for suggest-reviewers
1282         (and is probably breaking sheriff-bots blame detection).
1283
1284         * Scripts/webkitpy/common/checkout/api.py:
1285         * Scripts/webkitpy/common/checkout/api_unittest.py:
1286         * Scripts/webkitpy/common/checkout/scm.py:
1287
1288 2011-01-13  Eric Seidel  <eric@webkit.org>
1289
1290         Reviewed by Adam Barth.
1291
1292         results archives from commit-queue are too large to upload
1293         https://bugs.webkit.org/show_bug.cgi?id=52405
1294
1295         * Scripts/webkitpy/common/system/filesystem.py:
1296         * Scripts/webkitpy/common/system/filesystem_mock.py:
1297         * Scripts/webkitpy/tool/commands/queues.py:
1298
1299 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1300
1301         Reviewed by Martin Robinson.
1302
1303         [gtk] Zero-sized font does not yet work
1304         https://bugs.webkit.org/show_bug.cgi?id=49793
1305
1306         Set minimum-font-size to 0 for the DRT.
1307
1308         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1309         (resetDefaultsToConsistentValues):
1310
1311 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1312
1313         Reviewed by Darin Adler.
1314
1315         Make old-run-webkit-tests more robust on buildbots
1316         https://bugs.webkit.org/show_bug.cgi?id=52364
1317
1318         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1319
1320 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1321
1322         Reviewed by Darin Adler.
1323
1324         Make old-run-webkit-tests more robust on buildbots
1325         https://bugs.webkit.org/show_bug.cgi?id=52364
1326
1327         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1328
1329 2011-01-13  Tony Chang  <tony@chromium.org>
1330
1331         Reviewed by Kent Tamura.
1332
1333         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1334         https://bugs.webkit.org/show_bug.cgi?id=52332
1335
1336         Forked Info.plist is not longer needed.
1337
1338         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1339
1340 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1341
1342         Reviewed by Timothy Hatcher.
1343
1344         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1345         to be passed directly to WebInspector.UIString
1346
1347         https://bugs.webkit.org/show_bug.cgi?id=52365
1348
1349         * Scripts/check-inspector-strings:
1350
1351 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1352
1353         Unreviewed, rolling out r74881.
1354         http://trac.webkit.org/changeset/74881
1355         https://bugs.webkit.org/show_bug.cgi?id=52357
1356
1357         The EFL builder has been red for days (Requested by abarth on
1358         #webkit).
1359
1360         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1361         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1362
1363 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1364
1365         Reviewed by David Levin.
1366
1367         Add beforeunload support to WebKitTestRunner
1368         https://bugs.webkit.org/show_bug.cgi?id=52353
1369         
1370         This makes a number of currently failing tests pass.
1371
1372         * WebKitTestRunner/TestController.cpp:
1373         (WTR::runBeforeUnloadConfirmPanel):
1374         (WTR::createOtherPage):
1375         (WTR::TestController::initialize):
1376
1377 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1378
1379         Reviewed by Sam Weinig.
1380
1381         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1382         https://bugs.webkit.org/show_bug.cgi?id=52330
1383
1384         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1385         a web process crash.
1386         * WebKitTestRunner/TestController.cpp:
1387         (WTR::TestController::initialize): Set up a processDidCrash
1388         callback.
1389         (WTR::TestController::processDidCrash): Report that the Web process
1390         crashed.
1391         * WebKitTestRunner/TestController.h:
1392
1393 2011-01-12  David Levin  <levin@chromium.org>
1394
1395         Reviewed by Shinichiro Hamaji.
1396
1397         check-webkit-style -- close_expression function doesn't work correctly.
1398         https://bugs.webkit.org/show_bug.cgi?id=52272
1399
1400         * Scripts/webkitpy/style/checkers/cpp.py:
1401         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1402         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1403         generally useful (for upcoming code changes).
1404         (close_expression): Changed to use Position for input and output.
1405         Also, fixed many bugs such as only working correctly for parenthesis,
1406         not working correctly if given an offset in a line and not finding
1407         the real closing element if there were multiple closing elements in
1408         the same line.
1409         (detect_functions): Adjusted due to the change in arguments for
1410         close_expression.
1411         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1412         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1413         two positions are the same.
1414         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1415         (CppStyleTest.test_close_expression): Added tests to catch the issues
1416         that were fixed.
1417
1418 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1419
1420         Unreviewed, rolling out r75576.
1421         http://trac.webkit.org/changeset/75576
1422         https://bugs.webkit.org/show_bug.cgi?id=52304
1423
1424         broke rebaseline-chromium-webkit-test (Requested by thakis on
1425         #webkit).
1426
1427         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1428         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1429         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1430         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1431         * Scripts/webkitpy/layout_tests/port/base.py:
1432         * Scripts/webkitpy/layout_tests/port/chromium.py:
1433         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1434         * Scripts/webkitpy/layout_tests/port/test.py:
1435         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1436         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1437         * Scripts/webkitpy/style/checkers/test_expectations.py:
1438         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1439
1440 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1441
1442         Reviewed by Darin Adler.
1443
1444         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1445         https://bugs.webkit.org/show_bug.cgi?id=52307
1446
1447         * Scripts/old-run-webkit-tests:
1448
1449 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1450
1451         Reviewed by Martin Robinson.
1452
1453         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1454         https://bugs.webkit.org/show_bug.cgi?id=50867
1455
1456         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1457         TestNetscapePlugin.cpp 
1458
1459         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1460         * Scripts/webkitdirs.pm:
1461
1462 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1463
1464         Reviewed by Pavel Feldman.
1465
1466         Add check-inspector-strings script.
1467
1468         https://bugs.webkit.org/show_bug.cgi?id=52295
1469
1470         * Scripts/check-inspector-strings: Added.
1471
1472 2011-01-12  Adam Roben  <aroben@apple.com>
1473
1474         Advertise the .testnetscape file extension on Windows
1475
1476         Fixes <http://webkit.org/b/52298>
1477         plugins/no-mime-with-valid-extension.html fails on Windows
1478
1479         Reviewed by Dan Bernstein.
1480
1481         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1482         FileExtents field to map the .testnetscape file extension to the
1483         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1484
1485 2011-01-12  Adam Barth  <abarth@webkit.org>
1486
1487         Reviewed by Eric Seidel.
1488
1489         Make webkit-patch support subdirectories for SVN checkouts
1490         https://bugs.webkit.org/show_bug.cgi?id=52261
1491
1492         os.relpath does not exist on Python 2.5, so we need to call our version
1493         of the API.
1494
1495         * Scripts/webkitpy/common/checkout/scm.py:
1496
1497 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1498
1499         Reviewed by Eric Seidel.
1500
1501         Close additional pages opened during a test once the test completes.
1502         https://bugs.webkit.org/show_bug.cgi?id=52276
1503
1504         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1505         (WTR::InjectedBundle::done):
1506
1507 2011-01-11  David Levin  <levin@chromium.org>
1508
1509         Reviewed by Eric Seidel.
1510
1511         Errors should be separated from the command line in bot messages.
1512         https://bugs.webkit.org/show_bug.cgi?id=52275
1513
1514         * Scripts/webkitpy/common/system/executive.py:
1515         (ScriptError.message_with_output): Added a newline to separate the command
1516         line from the errors.
1517         * Scripts/webkitpy/common/system/executive_unittest.py:
1518         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1519         paths in message_with_output.
1520
1521 2011-01-11  Eric Seidel  <eric@webkit.org>
1522
1523         Unreviewed.
1524
1525         commit-queue should know how to upload archived results (for test flakes or general failures)
1526         https://bugs.webkit.org/show_bug.cgi?id=52048
1527
1528         The zips are mostly empty due to forgetting -r.
1529         Expected diffs were not being pulled from the archive due
1530         to the archive having longer paths than I realized.
1531
1532         * Scripts/webkitpy/common/system/workspace.py:
1533         * Scripts/webkitpy/common/system/workspace_unittest.py:
1534         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1535         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1536
1537 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1538
1539         Reviewed by Ojan Vafai.
1540
1541         The current modifier parsing code in test_expectations is
1542         fragile and hard-coded, so it's not easy to understand the logic
1543         or easily add new types of modifiers (like GPU vs. CPU testing
1544         for graphics tests, or 32-bit vs. 64-bit differences).
1545
1546         This is the first of two patches that will add in more generic
1547         support and then eliminate the GPU-specific test expectations
1548         files for Chromium.
1549
1550         This patch adds two standalone objects for handling modifiers. The
1551         rules for interpreting modifiers, precedence, and conflicts are
1552         given in the docstring to the ModifierMatcher class, which
1553         returns ModifierMatchResult objects.
1554         
1555         This patch also adds routines to the Port interface and a
1556         default set of values in the base object, in order to obtain the
1557         values needed on a given test run. These values are then passed
1558         to the expectation parser. This also allows us to clean up the
1559         logic used to lint all of the different configurations in a
1560         single test_expectations.txt file.
1561
1562         The next patch will merge in the separate GPU expectations file.
1563
1564         https://bugs.webkit.org/show_bug.cgi?id=51222
1565
1566         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1567         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1568         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1569         * Scripts/webkitpy/layout_tests/port/base.py:
1570         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1571         * Scripts/webkitpy/layout_tests/port/chromium.py:
1572         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1573         * Scripts/webkitpy/layout_tests/port/test.py:
1574         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1575         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1576
1577 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1578
1579         Reviewed by Adam Barth.
1580
1581         Make webkit-patch support subdirectories for SVN checkouts
1582         https://bugs.webkit.org/show_bug.cgi?id=52261
1583
1584         * Scripts/webkitpy/common/checkout/scm.py:
1585         * Scripts/webkitpy/style_references.py:
1586         * Scripts/webkitpy/tool/main.py:
1587         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1588
1589 2011-01-11  Eric Seidel  <eric@webkit.org>
1590
1591         Unreviewed.
1592
1593         commit-queue should know how to upload archived results (for test flakes or general failures)
1594         https://bugs.webkit.org/show_bug.cgi?id=52048
1595
1596         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1597         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1598
1599         * Scripts/webkitpy/common/system/workspace.py:
1600         * Scripts/webkitpy/common/system/workspace_unittest.py:
1601         * Scripts/webkitpy/tool/commands/queues.py:
1602
1603 2011-01-11  Sam Weinig  <sam@webkit.org>
1604
1605         Roll r75474 back in.
1606
1607 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1608
1609         Reviewed by Kenneth Rohde Christiansen.
1610
1611         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1612         https://bugs.webkit.org/show_bug.cgi?id=51204
1613
1614         * QtTestBrowser/webpage.h:
1615         (QtNAMThread::QtNAMThread):
1616         (QtNAMThread::networkAccessManager):
1617         (QtNAMThread::run):
1618
1619 2011-01-11  Peter Varga  <pvarga@webkit.org>
1620
1621         Unreviewed.
1622
1623         Add myself to committers' list.
1624
1625         * Scripts/webkitpy/common/config/committers.py:
1626
1627 2011-01-11  Eric Seidel  <eric@webkit.org>
1628
1629         Reviewed by Adam Barth.
1630
1631         commit-queue should know how to upload archived results (for test flakes or general failures)
1632         https://bugs.webkit.org/show_bug.cgi?id=52048
1633
1634         Now the queue will always upload results.  Either the entire zip, or just
1635         the diffs.txt in the case of text failures.
1636
1637         This should make understanding flakes much easier, and paves the way
1638         for having the EWS run layout tests (and upload failures).
1639
1640         In order to upload .zip files I had to teach bugzilla.py to autodetect
1641         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1642         for .patch files, I have it add one before calling guess_type.
1643
1644         We may find that always uploading the whole zip instead of just the -diffs.txt
1645         file is preferable, but for now I'm keeping the old behavior because it makes
1646         quickly understanding text failures easy.
1647
1648         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1649         * Scripts/webkitpy/common/system/workspace.py: Added.
1650         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1651         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1652         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1653         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1654         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1655         * Scripts/webkitpy/tool/commands/queues.py:
1656         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1657
1658 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1659
1660         Unreviewed, rolling out r75464.
1661         http://trac.webkit.org/changeset/75464
1662         https://bugs.webkit.org/show_bug.cgi?id=52193
1663
1664         Followup rollout for 75474 (Requested by Ossy on #webkit).
1665
1666         * MiniBrowser/mac/BrowserWindowController.m:
1667         (-[BrowserWindowController awakeFromNib]):
1668         * MiniBrowser/win/BrowserView.cpp:
1669         (BrowserView::create):
1670         * WebKitTestRunner/TestController.cpp:
1671         (WTR::createOtherPage):
1672         (WTR::TestController::initialize):
1673
1674 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1675
1676         Reviewed by Csaba Osztrogonác.
1677
1678         [Qt] Baseline qt_minimal configuration
1679         https://bugs.webkit.org/show_bug.cgi?id=51313
1680
1681         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1682         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1683         QT_NO_UNDOSTACK guard.
1684
1685         * QtTestBrowser/launcherwindow.cpp:
1686         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1687         guards.
1688         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1689         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1690         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1691         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1692
1693         * QtTestBrowser/launcherwindow.h:
1694         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1695         * QtTestBrowser/locationedit.h: Ditto.
1696
1697         * QtTestBrowser/mainwindow.cpp:
1698         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1699         QT_NO_UNDOSTACK guards.
1700         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1701         (MainWindow::changeLocation): Ditto.
1702         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1703         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1704
1705         * QtTestBrowser/webpage.cpp:
1706         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1707         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1708
1709         * QtTestBrowser/webview.cpp:
1710         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1711         (WebViewGraphicsBased::animatedYFlip): Ditto.
1712
1713 2011-01-10  Sam Weinig  <sam@webkit.org>
1714
1715         Fix build.
1716
1717         * MiniBrowser/mac/BrowserWindowController.m:
1718         (-[BrowserWindowController awakeFromNib]):
1719         * MiniBrowser/win/BrowserView.cpp:
1720         (BrowserView::create):
1721         * WebKitTestRunner/TestController.cpp:
1722         (WTR::createOtherPage):
1723         (WTR::TestController::initialize):
1724
1725 2011-01-10  Eric Seidel  <eric@webkit.org>
1726
1727         Reviewed by Ojan Vafai.
1728
1729         style-queue messages are way too long for big patches
1730         https://bugs.webkit.org/show_bug.cgi?id=52161
1731
1732         We definitely could build much fancier list-to-string-with-limit functions
1733         but this should be sufficient for our needs at the moment.
1734
1735         * Scripts/webkitpy/common/system/executive.py:
1736         * Scripts/webkitpy/common/system/executive_unittest.py:
1737
1738 2011-01-10  Tony Chang  <tony@chromium.org>
1739
1740         Unreviewed, rolling out r75398.
1741         http://trac.webkit.org/changeset/75398
1742         https://bugs.webkit.org/show_bug.cgi?id=52008
1743
1744         Some layout tests are crashing on Chromium Win.
1745
1746         * DumpRenderTree/chromium/WebViewHost.cpp:
1747         (WebViewHost::updatePaintRect):
1748         * DumpRenderTree/chromium/WebViewHost.h:
1749
1750 2011-01-10  Adam Roben  <aroben@apple.com>
1751
1752         Roll out r75392
1753
1754         It isn't needed now that r75289 has been rolled out.
1755
1756         * Scripts/run-javascriptcore-tests:
1757
1758 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1759
1760         Reviewed by Anders Carlsson.
1761
1762         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1763         https://bugs.webkit.org/show_bug.cgi?id=52160
1764
1765         * WebKitTestRunner/mac/TestControllerMac.mm:
1766         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1767         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1768         anyway.
1769
1770 2011-01-10  Tony Chang  <tony@chromium.org>
1771
1772         Reviewed by Mihai Parparita.
1773
1774         [chromium] fix for animated gif layout tests
1775         https://bugs.webkit.org/show_bug.cgi?id=52008
1776
1777         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1778             to trigger gif animations.
1779         (WebViewHostPaintTask::WebViewHostPaintTask):
1780         (WebViewHostPaintTask::runIfValid):
1781         (WebViewHost::updatePaintRect):
1782         * DumpRenderTree/chromium/WebViewHost.h:
1783         (WebViewHost::taskList):
1784
1785 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1786
1787         Reviewed by Xan Lopez.
1788
1789         [GTK] Fix gtk2 compilation for master
1790         https://bugs.webkit.org/show_bug.cgi?id=51885
1791
1792         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1793         (createBitmapContextFromWebView): Replaced the old
1794         gdk_drawable_get_size with gdk_pixmap_get_size.
1795
1796 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1797
1798         Reviewed by Laszlo Gombos.
1799
1800         [WINCE] Reenable NPAPI after r75203
1801         https://bugs.webkit.org/show_bug.cgi?id=52109
1802
1803         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1804         it with !isEfl(), because EFL port does not support NPAPI (yet).
1805
1806         * Scripts/build-webkit:
1807
1808 2011-01-10  Adam Roben  <aroben@apple.com>
1809
1810         Skip some asserting JS tests
1811
1812         See <http://webkit.org/b/52156>.
1813
1814         * Scripts/run-javascriptcore-tests:
1815
1816 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1817
1818         Reviewed by Xan Lopez.
1819
1820         [GTK] build-webkit disable Blob support via arguments passed to automake
1821         https://bugs.webkit.org/show_bug.cgi?id=52097
1822
1823         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1824         build-webkit.
1825
1826 2011-01-10  Adam Roben  <aroben@apple.com>
1827
1828         Use the same name and description for TestNetscapePlugin on Windows and
1829         Mac
1830
1831         Fixes <http://webkit.org/b/52151>
1832         fast/frames/iframe-reparenting-plugins.html fails on Windows
1833
1834         Reviewed by Steve Falkenburg.
1835
1836         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1837         the name and description from Mac's Info.plist.
1838
1839 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1840
1841         Reviewed by Laszlo Gombos.
1842
1843         [Qt][WK2] Guard gcc-specific syntax
1844
1845         Non-gcc based compliers choke on the "-include"
1846         syntax for preinclude, place guard around it.
1847
1848         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1849         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1850
1851 2011-01-10  Andreas Kling  <kling@webkit.org>
1852
1853         Reviewed by Simon Hausmann.
1854
1855         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1856         https://bugs.webkit.org/show_bug.cgi?id=52111
1857
1858         When getting a createNewPage() callback from QWKPage, create the
1859         new page with the same QWKContext as the page that is passed to
1860         the callback.
1861
1862         * MiniBrowser/qt/BrowserView.h:
1863         * MiniBrowser/qt/BrowserWindow.cpp:
1864         (newPageFunction):
1865         (BrowserWindow::BrowserWindow):
1866         * MiniBrowser/qt/BrowserWindow.h:
1867
1868 2011-01-10  Andreas Kling  <kling@webkit.org>
1869
1870         Reviewed by Kenneth Rohde Christiansen.
1871
1872         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1873
1874         BrowserView set its own useless createNewPage() callback on QWKPage.
1875         This was immediately overridden by BrowserWindow anyway, so remove
1876         the BrowserView one.
1877
1878         * MiniBrowser/qt/BrowserView.cpp:
1879         (BrowserView::BrowserView):
1880
1881 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1882
1883         Reviewed by Jeremy Orlow.
1884
1885         [Chromium] Remove non-client-based Geolocation code
1886         https://bugs.webkit.org/show_bug.cgi?id=50921
1887
1888         * DumpRenderTree/chromium/LayoutTestController.cpp:
1889         (LayoutTestController::setGeolocationPermission):
1890         (LayoutTestController::setMockGeolocationPosition):
1891         (LayoutTestController::setMockGeolocationError):
1892         * DumpRenderTree/chromium/WebViewHost.cpp:
1893         (WebViewHost::geolocationClientMock):
1894         (WebViewHost::reset):
1895         * DumpRenderTree/chromium/WebViewHost.h:
1896
1897 2011-01-10  Eric Seidel  <eric@webkit.org>
1898
1899         Reviewed by Adam Barth.
1900
1901         Commit bot tried to land r? cq+ patch
1902         https://bugs.webkit.org/show_bug.cgi?id=36638
1903
1904         It should now be possible to post a patch with r? and cq+ and the
1905         commit-queue will correctly wait for the r+ before attempting to land the patch.
1906         (This was a feature requested by several users.)
1907
1908         One caveat: We don't actually reject r-, cq+ patches from the queue
1909         (we just ignore them), but I think that's OK for now.
1910
1911         I also noticed that setting r- once a commit-queue node had grabbed
1912         a patch would not properly cancel the landing.  That's fixed and
1913         tested in this patch.
1914
1915         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1916         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1917         * Scripts/webkitpy/tool/bot/feeders.py:
1918         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1919
1920 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1921
1922         Reviewed by Kenneth Rohde Christiansen.
1923
1924         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1925         https://bugs.webkit.org/show_bug.cgi?id=51934
1926
1927         When accessing the network from the destructor of QWebPage, the network access manager
1928         was already deleted because the object WebPage was already destructed.
1929
1930         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1931         The object is now destructed in the destructor of QObject.
1932
1933         * QtTestBrowser/webpage.cpp:
1934         (WebPage::WebPage):
1935         (WebPage::setQnamThreaded):
1936         * QtTestBrowser/webpage.h:
1937         (QtNAMThread::QtNAMThread):
1938
1939 2011-01-08  Eric Seidel  <eric@webkit.org>
1940
1941         Reviewed by Ojan Vafai.
1942
1943         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1944         https://bugs.webkit.org/show_bug.cgi?id=52067
1945
1946         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1947         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1948
1949         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1950
1951 2011-01-08  Eric Seidel  <eric@webkit.org>
1952
1953         Reviewed by Mihai Parparita.
1954
1955         commit-queue hangs when the ChangeLog diff is bad
1956         https://bugs.webkit.org/show_bug.cgi?id=52072
1957
1958         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1959         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1960
1961 2011-01-08  Adam Barth  <abarth@webkit.org>
1962
1963         Teach svn-apply how to re-write WebCore to Source/WebCore.
1964
1965         * Scripts/VCSUtils.pm:
1966
1967 2011-01-07  Adam Barth  <abarth@webkit.org>
1968
1969         Rubber-stamped by Eric Seidel.
1970
1971         Move WebCore to Source
1972         https://bugs.webkit.org/show_bug.cgi?id=52050
1973
1974         Update the tools to understand WebCore's new location.
1975
1976         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1977         * DumpRenderTree/wscript:
1978         * GNUmakefile.am:
1979         * Scripts/build-webkit:
1980         * Scripts/do-file-rename:
1981         * Scripts/do-webcore-rename:
1982         * Scripts/generate-qt-inspector-resource:
1983         * Scripts/prepare-ChangeLog:
1984         * Scripts/run-bindings-tests:
1985         * Scripts/update-iexploder-cssproperties:
1986         * Scripts/update-sources-list.py:
1987         * Scripts/update-webkit-localizable-strings:
1988         * Scripts/webkitdirs.pm:
1989         * Scripts/webkitpy/common/config/build.py:
1990         * Scripts/webkitpy/common/config/build_unittest.py:
1991         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1992         * Scripts/webkitpy/style/checker.py:
1993         * Scripts/webkitpy/style/checker_unittest.py:
1994         * WebKitTestRunner/DerivedSources.pro:
1995         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1996         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1997         * wx/browser/wscript:
1998         * wx/build/settings.py:
1999
2000 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2001
2002         Reviewed by Sam Weinig.
2003
2004         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2005         https://bugs.webkit.org/show_bug.cgi?id=52086
2006
2007         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2008         (WTR::InjectedBundle::didReceiveMessage):
2009         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2010         (WTR::LayoutTestController::notifyDone):
2011         * WebKitTestRunner/TestController.cpp:
2012         (WTR::TestController::resetStateToConsistentValues):
2013         (WTR::TestController::run):
2014
2015 2011-01-07  James Robinson  <jamesr@chromium.org>
2016
2017         Revert "Implement mozilla's animationTime property"
2018         https://bugs.webkit.org/show_bug.cgi?id=51952
2019
2020         This approach isn't quite right.
2021
2022         * DumpRenderTree/chromium/WebViewHost.cpp:
2023         (WebViewHost::paintInvalidatedRegion):
2024
2025 2011-01-07  Adam Roben  <aroben@apple.com>
2026
2027         Build master fix
2028
2029         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2030         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2031
2032 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2033
2034         Reviewed by Csaba Osztrogonác.
2035
2036         run-qtwebkit-tests should be able to kill a testsuite.
2037
2038         Add new option in the script that can setup a timeout for a test.
2039         If the test execution takes more then specified time then the test
2040         would be terminated.
2041
2042         [Qt] run-qtwebkit-tests needs timeout
2043         https://bugs.webkit.org/show_bug.cgi?id=51894
2044
2045         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2046         * Scripts/run-qtwebkit-tests:
2047
2048 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2049
2050         Unreviewed fix after r75233.
2051
2052         Based on idea from Eric Seidel.
2053
2054         Add remote zip file handling to webkitpy.
2055         https://bugs.webkit.org/show_bug.cgi?id=50901
2056
2057         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2058
2059 2011-01-07  Shane Stephens  <shanestephens@google.com>
2060
2061         Reviewed by Eric Seidel.
2062
2063         svn-apply: should support git binary delta diffs
2064         https://bugs.webkit.org/show_bug.cgi?id=38864
2065
2066         * Scripts/VCSUtils.pm:
2067         * Scripts/svn-apply:
2068
2069 2011-01-06  Julie Parent  <jparent@chromium.org>
2070
2071         Reviewed by Eric Seidel.
2072
2073         Test Result Server not removing old results.
2074         https://bugs.webkit.org/show_bug.cgi?id=52012
2075
2076         * TestResultServer/model/jsonresults.py:
2077         Fix off-by-one: Truncate if >= num_runs, not just >.
2078         * TestResultServer/model/jsonresults_unittest.py:
2079         Add unit test to test that merging in a new result with the same value
2080         as the last result causes previous result to fall off.
2081
2082 2011-01-06  James Kozianski  <koz@chromium.org>
2083
2084         Reviewed by Mihai Parparita.
2085
2086         Add classes to provide a consistent interface to a set of files.
2087         https://bugs.webkit.org/show_bug.cgi?id=50901
2088
2089         These classes allow us to write code that is agnostic to whether a
2090         particular set of files resides in a local directory or in a zip file
2091         on a remote machine.
2092
2093         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2094         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2095         * Scripts/webkitpy/common/system/fileset.py: Added.
2096         * Scripts/webkitpy/common/system/filesystem.py:
2097         * Scripts/webkitpy/common/system/filesystem_mock.py:
2098         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2099         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2100
2101 2011-01-06  Eric Seidel  <eric@webkit.org>
2102
2103         Reviewed by Adam Barth.
2104
2105         NetworkTransaction should log the url it is retrying
2106         https://bugs.webkit.org/show_bug.cgi?id=52043
2107
2108         * Scripts/webkitpy/common/net/networktransaction.py:
2109         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2110
2111 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2112
2113         Windows build fix.
2114         Import os before using it.
2115
2116         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2117
2118 2011-01-06  Eric Seidel  <eric@webkit.org>
2119
2120         Reviewed by Adam Barth.
2121
2122         StyleQueue fails to report errors when patches have many files
2123         https://bugs.webkit.org/show_bug.cgi?id=52042
2124
2125         This is one of at least two errors preventing style error reporting at the moment.
2126         When we moved to passing the list of files to check explicitly,
2127         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2128         We could change the type of the QueueStatus.message type, or we could
2129         just teach statusserver.py how to clamp values (and warn when it does).
2130         I chose the latter path.
2131
2132         * Scripts/webkitpy/common/net/statusserver.py:
2133
2134 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2135
2136         Reviewed by Stephanie Lewis.
2137         
2138         Fix syntax error in script.
2139
2140         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2141         https://bugs.webkit.org/show_bug.cgi?id=51996
2142
2143         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2144
2145 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2146
2147         Unreviewed, fixing WinCE build after r75196.
2148
2149         WinCE port does not (yet) support NPAPI.
2150
2151         * Scripts/build-webkit:
2152
2153 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2154
2155         Reviewed by Darin Adler.
2156
2157         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2158         https://bugs.webkit.org/show_bug.cgi?id=52015
2159
2160         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2161         after the platform has been detected, otherwise the script will
2162         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2163         detection.
2164
2165 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2166
2167         Reviewed by Eric Seidel.
2168
2169         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2170         https://bugs.webkit.org/show_bug.cgi?id=51346
2171
2172         * Scripts/build-webkit:
2173
2174 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2175
2176         Reviewed by Adam Roben.
2177
2178         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2179         https://bugs.webkit.org/show_bug.cgi?id=51996
2180         
2181         After the configuration directory change, we were archiving the incorrect directory for
2182         build product, so we were running tests on the wrong binaries.
2183         
2184         This change archives the correct directory, and also unarchives it into a configuration-
2185         specific directory.
2186
2187         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2188         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2189
2190 2011-01-06  Eric Seidel  <eric@webkit.org>
2191
2192         Reviewed by Mihai Parparita.
2193
2194         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2195         https://bugs.webkit.org/show_bug.cgi?id=52002
2196
2197         See an example of this here:
2198         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2199
2200         It's due to the fact that we pass around TestFailure() instance
2201         objects and yet expect them to all compare to be the same.
2202
2203         This is bad.  We should either have shared instances of these values
2204         or we should just pass around the class names.  There are already hacks
2205         in place to make TestFailure objects pass equality tests, I just added
2206         a __hash__ implementation so they can be used in sets as expected.
2207
2208         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2209         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2210
2211 2011-01-06  Evan Martin  <evan@chromium.org>
2212
2213         Reviewed by Tony Chang.
2214
2215         [gdb] handle inaccessible memory and UChar*
2216         https://bugs.webkit.org/show_bug.cgi?id=52003
2217
2218         To pretty-print a UChar*, we just grope around in the memory
2219         looking for a terminating NUL.  We need to handle the exception
2220         that can occur when we poke into an invalid location.
2221
2222         Additionally, the logic for choosing which pretty-printer would
2223         early return before hitting the point where we'd use the UChar*
2224         printer.  (Did this ever work?  How did it regress?)
2225
2226         * gdb/webkit.py:
2227
2228 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2229
2230         Reviewed by Ada Chan.
2231
2232         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2233         https://bugs.webkit.org/show_bug.cgi?id=51969
2234         
2235         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2236
2237         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2238         (WTR::InjectedBundlePage::InjectedBundlePage):
2239         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2240         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2241
2242 2011-01-06  James Robinson  <jamesr@chromium.org>
2243
2244         Reviewed by Simon Fraser.
2245
2246         Implement mozilla's animationTime property
2247         https://bugs.webkit.org/show_bug.cgi?id=51952
2248
2249         Chromium DRT support for webkitAnimationTime.
2250
2251         * DumpRenderTree/chromium/WebViewHost.cpp:
2252         (WebViewHost::paintInvalidatedRegion):
2253
2254 2011-01-06  Julie Parent  <jparent@chromium.org>
2255
2256         Reviewed by Tony Chang.
2257
2258         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2259         https://bugs.webkit.org/show_bug.cgi?id=51217
2260
2261         * TestResultServer/model/jsonresults.py:
2262         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2263         Adds missing documentation.
2264         * TestResultServer/model/jsonresults_unittest.py:
2265         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2266         Update test_merge to take a number of builds to truncate at.
2267
2268 2011-01-06  Adam Barth  <abarth@webkit.org>
2269
2270         Reviewed by Eric Seidel.
2271
2272         The EWS should log outside of the working directory
2273         https://bugs.webkit.org/show_bug.cgi?id=51986
2274
2275         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2276         script, which will actually clean the working copy back to a pristine
2277         state instead of leaving untracked directories and ignored files.
2278
2279         * Scripts/webkitpy/tool/commands/queues.py:
2280         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2281
2282 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2283
2284         Windows build fix.
2285         Back out attempted change to built-product-archive.
2286
2287         * BuildSlaveSupport/built-product-archive:
2288
2289 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2290
2291         Windows build fix.
2292         Include configuration name when unpacking a build archive.
2293
2294         Needed, since we split Windows build results into configuration-specific directories
2295         under WebKitOutputDir.
2296
2297         * BuildSlaveSupport/built-product-archive:
2298
2299 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2300
2301         Reviewed by Darin Adler.
2302
2303         Debug and Release builds on Windows clobber each other
2304         https://bugs.webkit.org/show_bug.cgi?id=49185
2305
2306         Changes the structure of WebKitBuild build products directory so we
2307         completely separate each build configuration into independent directories.
2308         
2309         Although we previously had per-configuration directories for obj, this change adds
2310         per-configuration directories for bin, lib, obj, and include. Each configuration's
2311         build products are stored within a directory inside of WebKitBuild.
2312         
2313         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2314         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2315
2316         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2317         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2318         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2319         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2320         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2321         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2322         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2323         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2324         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2325         * FindSafari/FindSafari.vcproj:
2326         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2327         * MiniBrowser/MiniBrowserPostBuild.cmd:
2328         * MiniBrowser/MiniBrowserPreBuild.cmd:
2329         * Scripts/webkitdirs.pm:
2330         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2331         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2332         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2333         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2334         * TestWebKitAPI/win/copy-resources.cmd:
2335         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2336         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2337         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2338         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2339         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2340         * WebKitTestRunner/win/InjectedBundle.vcproj:
2341         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2342         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2343         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2344         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2345         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2346         * WinLauncher/WinLauncherCommon.vsprops:
2347         * WinLauncher/WinLauncherPostBuild.cmd:
2348         * WinLauncher/WinLauncherPreBuild.cmd:
2349
2350 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2351
2352         Reviewed by Ariya Hidayat.
2353
2354         [Qt] TestNetscapePlugin doesn't link on OS X
2355         https://bugs.webkit.org/show_bug.cgi?id=51948
2356
2357         Only add a dependency on libX11 on X11 systems
2358
2359         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2360
2361 2011-01-05  Jeff Miller  <jeffm@apple.com>
2362
2363         Reviewed by Adam Roben.
2364
2365         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2366         https://bugs.webkit.org/show_bug.cgi?id=51970
2367
2368         * Scripts/webkitpy/style/checker.py:
2369         Add -readability/naming for WebKit2 C API directories.
2370
2371 2011-01-05  Eric Seidel  <eric@webkit.org>
2372
2373         Unreviewed, just fixing one more log error from my previous python patch.
2374
2375         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2376         https://bugs.webkit.org/show_bug.cgi?id=51802
2377
2378         webkit-patch failure-reason was logging about parsing errors
2379         due to my misunderstanding of how BeautifulSoup.findAll worked.
2380
2381         Fixed, and added a unit test.
2382
2383         * Scripts/webkitpy/common/net/layouttestresults.py:
2384         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2385
2386 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2387
2388         Reviewed by Kenneth Rohde Christiansen.
2389
2390         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2391         https://bugs.webkit.org/show_bug.cgi?id=51951
2392
2393         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2394         to create new window from WebKit.
2395
2396         * MiniBrowser/qt/BrowserWindow.cpp:
2397         (newPageFunction):
2398         (BrowserWindow::BrowserWindow):
2399         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2400         (BrowserWindow::newWindow):
2401         (BrowserWindow::updateUserAgentList):
2402         (BrowserWindow::showUserAgentDialog):
2403         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2404         define the type of the backing store used for new windows.
2405         * MiniBrowser/qt/main.cpp:
2406         (main):
2407
2408 2011-01-05  Eric Seidel  <eric@webkit.org>
2409
2410         Reviewed by Ojan Vafai.
2411
2412         commit-queue should report failure type when reporting flaky tests
2413         https://bugs.webkit.org/show_bug.cgi?id=51900
2414
2415         This patch was a ridiculous amount of plumbing.  In the end I like
2416         the NRWT-style TestResult class even less.  But now we're passing
2417         a list of TestResult objects from the queue to the FlakyTestReporter.
2418         Thus the FlakyTestReporter can more easily report what type of failure
2419         occurred.
2420
2421         In the process, I found that I was not alone in finding TestResult
2422         cumbersome to use.  A bunch of code was trying to create a TestResult
2423         object with default values.  However since the constructor didn't make
2424         this easy, some places were getting it wrong (including the TestResult unit test)!
2425         I've fixed the TestResult constructor to have default values for non-essential
2426         arguments.
2427
2428         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2429         * Scripts/webkitpy/common/net/layouttestresults.py:
2430         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2431         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2432         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2433         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2434         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2435         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2436         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2437         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2438         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2439         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2440         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2441         * Scripts/webkitpy/tool/commands/queues.py:
2442         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2443
2444 2011-01-05  Eric Seidel  <eric@webkit.org>
2445
2446         Unreviewed.
2447
2448         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2449         https://bugs.webkit.org/show_bug.cgi?id=51802
2450
2451         Add another unit test to cover a previously missing import.
2452
2453         * Scripts/webkitpy/common/net/layouttestresults.py:
2454         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2455
2456 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2457
2458         Reviewed by David Levin.
2459
2460         Add mihaip@chromium.org as a reviewer
2461         https://bugs.webkit.org/show_bug.cgi?id=51966
2462         
2463         Add myself as a reviewer.
2464
2465         * Scripts/webkitpy/common/config/committers.py:
2466
2467 2011-01-05  James Simonsen  <simonjam@chromium.org>
2468
2469         Unreviewed. Adding myself to the list of committers.
2470
2471         * Scripts/webkitpy/common/config/committers.py:
2472
2473 2011-01-05  Eric Seidel  <eric@webkit.org>
2474
2475         Unreviewed.
2476
2477         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2478         https://bugs.webkit.org/show_bug.cgi?id=51802
2479
2480         Fix two exceptions seen on the bots after my original commit.
2481
2482         * Scripts/webkitpy/common/net/layouttestresults.py:
2483         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2484
2485 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2486
2487         Reviewed by Andreas Kling.
2488
2489         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2490         https://bugs.webkit.org/show_bug.cgi?id=51750
2491
2492         * QtTestBrowser/main.cpp:
2493         (LauncherApplication::handleUserOptions):
2494          Local storage settings can be enable form command line arguments for
2495          QtTestBrowser.
2496
2497 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2498
2499         Reviewed by Martin Robinson.
2500
2501         GTK: AX: DRT needs to use correct root object method.
2502         https://bugs.webkit.org/show_bug.cgi?id=51911
2503
2504         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2505         (AccessibilityController::rootElement):
2506
2507 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2508
2509         Rubber-stamped by Csaba Osztrogonác.
2510
2511         Based on idea from Péter Gál.
2512
2513         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2514
2515 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2516
2517         Reviewed by Adam Barth.
2518
2519         sheriff-bot should be able to do multi-revision rollouts
2520         https://bugs.webkit.org/show_bug.cgi?id=51176
2521
2522         * Scripts/webkitpy/tool/bot/irc_command.py:
2523         * Scripts/webkitpy/tool/bot/sheriff.py:
2524         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2525
2526 2011-01-05  Eric Seidel  <eric@webkit.org>
2527
2528         Reviewed by Adam Barth.
2529
2530         queues.webkit.org should have per-bot status pages
2531         https://bugs.webkit.org/show_bug.cgi?id=51906
2532
2533         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2534         statuses from a single queue.  Now that we have many bots servicing
2535         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2536         you care about scroll off the end of the 15-message limit on the main page.
2537
2538         Eventually we should probably rename /queue-status to /queue or /queues,
2539         but that's fodder for another patch.
2540
2541         * QueueStatusServer/handlers/queuestatus.py:
2542         * QueueStatusServer/index.yaml:
2543         * QueueStatusServer/main.py:
2544         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2545          - This probably should use a custom filter instead of hard-coding
2546            the URL scheme here, but I couldn't figure out how to easily
2547            create such a filter.  Most filters work with "strings" so we can't
2548            pass the status object.  We could add a method to the status
2549            object and call that, but that seemed a bit strange too.
2550         * QueueStatusServer/templates/queuestatus.html:
2551
2552 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2553
2554         Unreviewed. Adding myself to the list of committers.
2555
2556         * Scripts/webkitpy/common/config/committers.py:
2557
2558 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2559
2560         Reviewed by David Levin.
2561
2562         check-webkit-style treated some macros with parentheses after #elif as function calls
2563         https://bugs.webkit.org/show_bug.cgi?id=51695
2564
2565         Ingore function call space checking in any preprocessor directives
2566         (things starting with #). Change search() to match() because 
2567         preprocessor directives are supposed to be in the beginning of lines.
2568
2569         * Scripts/webkitpy/style/checkers/cpp.py:
2570         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2571
2572 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2573
2574         Reviewed by Tony Chang.
2575
2576         Change the --multi-load test option to --stress-opt
2577         https://bugs.webkit.org/show_bug.cgi?id=50751
2578
2579         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2580         (runTest):
2581         (main):
2582         * DumpRenderTree/chromium/TestShell.cpp:
2583         (TestShell::TestShell):
2584         * DumpRenderTree/chromium/TestShell.h:
2585         (TestShell::stressOpt):
2586         (TestShell::setStressOpt):
2587         (TestShell::stressDeopt):
2588         (TestShell::setStressDeopt):
2589         (TestShell::javaScriptFlags):
2590         (TestShell::setJavaScriptFlags):
2591         * Scripts/webkitpy/layout_tests/port/chromium.py:
2592         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2593
2594 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2595
2596         Reviewed by Sam Weinig.
2597
2598         WK2: Support Accessibility
2599         https://bugs.webkit.org/show_bug.cgi?id=51859
2600
2601         Use rootObject() method to get top of accessibility tree.
2602
2603         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2604         (AccessibilityController::focusedElement):
2605         (AccessibilityController::rootElement):
2606
2607 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2608
2609         Reviewed by Darin Adler.
2610
2611         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2612         https://bugs.webkit.org/show_bug.cgi?id=51846
2613
2614         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2615         back to GRefPtr.
2616
2617 2011-01-04  Zhe Su  <suzhe@chromium.org>
2618
2619         Reviewed by Kenneth Russell.
2620
2621         Fix insertText, setMarkedText and unmarkText methods of
2622         TextInputController to call corresponding methods of WebKit::WebView
2623         rather than WebKit::WebFrame. This change matches the behavior of
2624         chromium browser.
2625         insertText corresponds to WebView::confirmComposition(text)
2626         setMarkedText corresponds to WebView::setComposition(...)
2627         unmarkText corresponds to WebView::confirmComposition()
2628         https://bugs.webkit.org/show_bug.cgi?id=51693
2629
2630         * DumpRenderTree/chromium/TextInputController.cpp:
2631         (TextInputController::insertText):
2632         (TextInputController::setMarkedText):
2633         (TextInputController::unmarkText):
2634
2635 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2636
2637         Reviewed by Laszlo Gombos.
2638
2639         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2640
2641         On Symbian productDir points to the source directory. Removing all the
2642         empty files from the productDir directory corrupts the svn repository.
2643
2644         * Scripts/build-webkit:
2645
2646 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2647
2648         Reviewed by Adam Barth.
2649
2650         [Qt] Add SelectAll option to the context menu for the editor
2651         https://bugs.webkit.org/show_bug.cgi?id=50049
2652
2653         Set shortcut for the SelectAll action.
2654
2655         * QtTestBrowser/mainwindow.cpp:
2656         (MainWindow::buildUI):
2657
2658 2011-01-03  David Levin  <levin@chromium.org>
2659
2660         Reviewed by Eric Seidel.
2661
2662         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2663         https://bugs.webkit.org/show_bug.cgi?id=51842
2664
2665         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2666         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2667
2668 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2669
2670         Reviewed by David Kilzer.
2671
2672         [WINCE] Adds a build slave.
2673         https://bugs.webkit.org/show_bug.cgi?id=50523
2674
2675         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2676         entry for a release build of the WinCE port.
2677         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2678         flag to build the WinCE port.
2679
2680 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2681
2682         Reviewed by David Kilzer.
2683
2684         Add WinCE support to build-webkit
2685         https://bugs.webkit.org/show_bug.cgi?id=51642
2686
2687         * Scripts/build-webkit:
2688         * Scripts/webkitdirs.pm:
2689
2690 2011-01-03  Eric Seidel  <eric@webkit.org>
2691
2692         Reviewed by Adam Barth.
2693
2694         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2695         https://bugs.webkit.org/show_bug.cgi?id=51802
2696
2697         I'm not the biggest fan of the test_failures or test_results classes,
2698         but it's better to have one shared set of classes, than separate ones
2699         for new vs. old run-webkit-test result handling.
2700
2701         This moves the ORWT results class "LayoutTestResults" over to using
2702         TestResult and TestFailure classes, making it easy for us to
2703         make all our sheriff-bot and other webkitpy code NRWT ready.
2704
2705         This also makes it a trivial patch to generate results.json information
2706         from ORWT results.html files (for flaky test analysis, etc.) as well
2707         as making it a one-liner to report test failure types when the
2708         commit-queue sees flaky tests.
2709
2710         This patch tried not to add new functionality, but only to replace
2711         the guts of LayoutTestResults, while adding unit tests and hoping
2712         not to break anything.
2713
2714         I also moved callers which assumed User.prompt* were static/class methods
2715         to using them as instance methods (since we'll eventually want to make them such).
2716
2717         In the process of re-writing things, I broke the rebaseline command, so I wrote
2718         a unit test to catch my breakage were I do do so again in the future.
2719
2720         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2721         * Scripts/webkitpy/common/net/layouttestresults.py:
2722         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2723         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2724         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2725         * Scripts/webkitpy/tool/commands/queries.py:
2726         * Scripts/webkitpy/tool/commands/rebaseline.py:
2727         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2728         * Scripts/webkitpy/tool/mocktool.py:
2729
2730 2011-01-03  Adam Barth  <abarth@webkit.org>
2731
2732         Reviewed by Simon Fraser.
2733
2734         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2735         https://bugs.webkit.org/show_bug.cgi?id=51840
2736
2737         * Scripts/webkitpy/common/checkout/scm.py:
2738
2739 2011-01-03  Adam Barth  <abarth@webkit.org>
2740
2741         Reviewed by Simon Fraser.
2742
2743         webkit-patch should only hide update output if --quiet
2744         https://bugs.webkit.org/show_bug.cgi?id=51838
2745
2746         As requested by smfr.
2747
2748         * Scripts/webkitpy/tool/steps/update.py:
2749
2750 2011-01-03  Adam Barth  <abarth@webkit.org>
2751
2752         Reviewed by David Levin.
2753
2754         commit-queue shouldn't reject patches twice if two bots process the same patch
2755         https://bugs.webkit.org/show_bug.cgi?id=51805
2756
2757         Before raising an error, we first check whether the patch is still in
2758         the commit-queue.  This check is still racy, of course, but the time
2759         window is much smaller.
2760
2761         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2762
2763 2011-01-03  Sam Weinig  <sam@webkit.org>
2764
2765         Reviewed by Anders Carlsson.
2766
2767         Make run-api-tests less chatty.
2768         https://bugs.webkit.org/show_bug.cgi?id=51831
2769
2770         - Make script quiet by default and add --verbose option (replacing --quiet).
2771         - When not verbose, pipe stdout and stderr to devnull.
2772
2773         * Scripts/run-api-tests:
2774
2775 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2776
2777         Unreviewed. Adding myself to committers.py.
2778
2779         * Scripts/webkitpy/common/config/committers.py:
2780
2781 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2782
2783         Reviewed by Xan Lopez.
2784
2785         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2786         https://bugs.webkit.org/show_bug.cgi?id=51806
2787
2788         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2789         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2790         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2791         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2792         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2793         so make it 'WebKitBuild/Release/.libs'
2794
2795         * Scripts/webkitdirs.pm: 
2796
2797 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2798
2799         Reviewed by Adam Barth.
2800
2801         Make EFL a core builder
2802         https://bugs.webkit.org/show_bug.cgi?id=51804
2803
2804         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2805         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2806
2807 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2808
2809         [Qt] Unreviewed fix after r74855 and r74875.
2810
2811         * BuildSlaveSupport/built-product-archive:
2812          - Create directories explicitly.
2813          - Pass shell=True to subprocess.call().
2814
2815 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2816
2817         [Qt] Unreviewed fix after r74855.
2818
2819         Move JavaScriptCore to Source
2820         https://bugs.webkit.org/show_bug.cgi?id=51604
2821
2822         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2823
2824 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2825
2826         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2827
2828         Move JavaScriptCore to Source
2829         https://bugs.webkit.org/show_bug.cgi?id=51604
2830
2831         * Scripts/webkitdirs.pm:
2832
2833 2011-01-02  Robert Hogan  <robert@webkit.org>
2834
2835         Unreviewed, build fix.
2836
2837         [Qt] Fix DRT build after 74855
2838
2839         * DumpRenderTree/qt/DumpRenderTree.pro:
2840
2841 2011-01-01  Adam Barth  <abarth@webkit.org>
2842
2843         Remove the assumption from the Qt and Gtk builds that every project is
2844         in the root directory.
2845
2846         * Scripts/build-webkit:
2847
2848 2011-01-01  Adam Barth  <abarth@webkit.org>
2849
2850         Reviewed by Eric Seidel.
2851
2852         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2853         https://bugs.webkit.org/show_bug.cgi?id=51796
2854
2855         After this change, svn-apply will magically apply patches to
2856         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2857
2858         * Scripts/VCSUtils.pm:
2859
2860 2011-01-01  Adam Barth  <abarth@webkit.org>
2861
2862         Reviewed by Eric Seidel.
2863
2864         Move JavaScriptCore to Source
2865         https://bugs.webkit.org/show_bug.cgi?id=51604
2866
2867         Update references to JavaScriptCore to point to the new location.
2868
2869         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2870         * DumpRenderTree/qt/DumpRenderTree.pro:
2871         * DumpRenderTree/qt/ImageDiff.pro:
2872         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2873         * DumpRenderTree/wscript:
2874         * Scripts/build-jsc:
2875         * Scripts/build-webkit:
2876         * Scripts/do-file-rename:
2877         * Scripts/do-webcore-rename:
2878         * Scripts/run-javascriptcore-tests:
2879         * Scripts/update-javascriptcore-test-results:
2880         * Scripts/webkitdirs.pm:
2881         * Scripts/webkitpy/common/config/build_unittest.py:
2882         * Scripts/webkitpy/style/checker.py:
2883         * Scripts/webkitpy/style/checker_unittest.py:
2884         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2885         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2886         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2887         * wx/build/settings.py:
2888
2889 2011-01-01  Adam Barth  <abarth@webkit.org>
2890
2891         Reviewed by Eric Seidel.
2892
2893         Move Sources to Source
2894         https://bugs.webkit.org/show_bug.cgi?id=51794
2895
2896         Update scripts to point to the new location.
2897
2898         * Scripts/build-webkit:
2899         * Scripts/do-file-rename:
2900         * Scripts/do-webcore-rename:
2901         * Scripts/webkitpy/common/config/build.py:
2902         * Scripts/webkitpy/common/config/build_unittest.py:
2903
2904 2010-12-31  Kent Tamura  <tkent@chromium.org>
2905
2906         Reviewed by Eric Seidel.
2907
2908         [DRT/Chromium] Enable mock spell checker on non-OSX
2909         https://bugs.webkit.org/show_bug.cgi?id=51401
2910
2911         * DumpRenderTree/chromium/WebViewHost.cpp:
2912         (WebViewHost::spellCheck):
2913
2914 2010-12-31  Adam Barth  <abarth@webkit.org>
2915
2916         Reviewed by Ariya Hidayat.
2917
2918         Remove Tools/Scripts/wkstyle
2919         https://bugs.webkit.org/show_bug.cgi?id=51774
2920
2921         This script appears to not have been touched in a while and seems to
2922         have been replaced by check-webkit-style.
2923
2924         * Scripts/wkstyle: Removed.
2925
2926 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2927
2928         Unreviewed. Coding style fix.
2929
2930         * DumpRenderTree/chromium/TestShell.h:
2931
2932 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2933
2934         Reviewed by Pavel Feldman.
2935
2936         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2937
2938         It was a problem with Chromium DRT. DevToolsAgent object instance was
2939         attached not only to the inspected page but to the DevTools window too.
2940         As result all the inspector files were interpreted as a content of inspected page
2941         and were transfered to the DevTools scripts panel for debugging etc.
2942
2943         https://bugs.webkit.org/show_bug.cgi?id=51735
2944
2945         * DumpRenderTree/chromium/TestShell.cpp:
2946         (TestShell::TestShell):
2947         (TestShell::bindJSObjectsToWindow):
2948         (TestShell::createNewWindow):
2949         * DumpRenderTree/chromium/TestShell.h:
2950
2951 2010-12-31  Adam Barth  <abarth@webkit.org>
2952
2953         Rubber-stamped by Eric Seidel.
2954
2955         Move PageLoadTests to PerformanceTests/PageLoad
2956         https://bugs.webkit.org/show_bug.cgi?id=51771
2957
2958         Update references to PageLoadTests to point to the new location.
2959
2960         * Scripts/run-pageloadtest:
2961         * Scripts/webkitpy/common/config/build.py:
2962
2963 2010-12-31  Adam Barth  <abarth@webkit.org>
2964
2965         Rubber-stamped by Eric Seidel.
2966
2967         Move SunSpider into PerformanceTests
2968         https://bugs.webkit.org/show_bug.cgi?id=51769
2969
2970         Update these scripts to point to the new location.
2971
2972         * Scripts/run-sunspider:
2973         * Scripts/sunspider-compare-results:
2974
2975 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2976
2977         Reviewed by Kent Tamura.
2978
2979         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2980         https://bugs.webkit.org/show_bug.cgi?id=51728
2981         
2982         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2983         to render top-level scrollbars. This makes them match the Mac port's
2984         use of an NSScrollView, which means that we'll be able to share more
2985         pixel baselines.
2986         
2987         The new rendering code will not be activated until the 
2988         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2989         ScrollbarThemeChromiumMac.
2990
2991         * DumpRenderTree/DumpRenderTree.gypi:
2992         * DumpRenderTree/chromium/TestShellMac.mm:
2993         (platformInit):
2994         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2995         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2996         (+[FakeActiveWindow alwaysActiveWindow]):
2997         (+[FakeActiveWindow alwaysInactiveWindow]):
2998         (-[FakeActiveWindow initWithActiveControls:]):
2999         (-[FakeActiveWindow _hasActiveControls]):
3000         (WebThemeEngineDRTMac::paintScrollbarThumb):
3001         (stateToHIEnableState):
3002         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3003         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3004
3005 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
3006
3007         Reviewed by David Kilzer.
3008
3009         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
3010         used
3011         https://bugs.webkit.org/show_bug.cgi?id=51672
3012
3013         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
3014         with USE_SYSTEM_MALLOC=1
3015         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
3016         with USE_SYSTEM_MALLOC=1
3017
3018 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3019
3020         Reviewed by David Kilzer.
3021
3022         [Qt] [Symbian] Fix build-webkit script for Symbian
3023         https://bugs.webkit.org/show_bug.cgi?id=51509
3024
3025         Set the OUTPUT_DIR for Symbian to be the same as the source
3026         directory.
3027
3028         * Scripts/webkitdirs.pm:
3029
3030 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
3031
3032         Reviewed by Darin Adler.
3033
3034         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
3035         https://bugs.webkit.org/show_bug.cgi?id=51758
3036
3037         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
3038
3039         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
3040         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3041
3042 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3043
3044         Unreviewed WinCE buildfix.
3045
3046         * WinCELauncher/main.cpp: Add missing include.
3047
3048 2010-12-29  Daniel Bates  <dbates@rim.com>
3049
3050         Reviewed by Darin Adler.
3051
3052         svn-apply updates date of wrong change log entry for a change log diff that
3053         contains two consecutive entries with the same author and date
3054         https://bugs.webkit.org/show_bug.cgi?id=46061
3055
3056         Fixes an issue where the date of the wrong change log entry may be modified.
3057         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
3058         in a ChangeLog file to the top of the file.
3059
3060         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
3061         diff when it detects that the diff inserts a change log entry earlier in a
3062         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
3063         change. With the advent of the commit-queue this functionality of bailing out
3064         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
3065         Instead, we should always move the change log entry to the top of the ChangeLog file.
3066
3067         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
3068         the date line of the correct change log entry in a ChangeLog diff.
3069
3070         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
3071
3072         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3073           Updated the following unit tests now that we move entries inserted earlier to the top:
3074           - "fixChangeLogPatch: New entry inserted in middle."
3075             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
3076
3077           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
3078             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
3079
3080         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
3081
3082 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
3083
3084         Reviewed by Eric Seidel.
3085
3086         [Qt] Fixed compatibility with gold linker on X11 platforms
3087         https://bugs.webkit.org/show_bug.cgi?id=51700
3088
3089         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3090         Linked TestNetscapePlugin with libX11 on Unix platforms
3091
3092 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3093
3094         Reviewed by Darin Adler.
3095
3096         Circular dependency in webkitpy.common.checkout.changelog module
3097         https://bugs.webkit.org/show_bug.cgi?id=50475
3098
3099         Remove automatic import of api.Checkout module when any checkout/
3100         submodule is imported (e.g.: when checkout.scm.Git is imported).
3101
3102         * Scripts/webkitpy/common/checkout/__init__.py:
3103
3104 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3105
3106         Reviewed by Ojan Vafai.
3107
3108         prepare-ChangeLog should support the -g option for specifying the git-commit
3109         https://bugs.webkit.org/show_bug.cgi?id=51708
3110
3111         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3112         webkit-patch, though the exact meaning of the two options remain different.
3113
3114         * Scripts/prepare-ChangeLog: Add -g.
3115
3116 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3117
3118         Reviewed by Simon Hausmann.
3119
3120         [Qt] Fix compilation with Qt in namespace
3121         https://bugs.webkit.org/show_bug.cgi?id=51701
3122
3123         * QtTestBrowser/webview.h:
3124
3125 2010-12-28  Daniel Bates  <dbates@rim.com>
3126
3127         Reviewed by Sam Weinig.
3128
3129         Substitute // MARK: for compiler-specific #pragma mark
3130         https://bugs.webkit.org/show_bug.cgi?id=51657
3131
3132         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3133         substituting  "// MARK:" for "#pragma mark", which provides
3134         analogous code-bookmarking functionality under Xcode.
3135
3136         Also, for consistency, we should substitute "// MARK:" for compiler-
3137         specific "#pragma mark" in the source files for the Mac port.
3138
3139         * DumpRenderTree/AccessibilityTextMarker.cpp:
3140         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3141         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3142         * DumpRenderTree/mac/ObjCController.m:
3143         * MiniBrowser/mac/AppDelegate.m:
3144         * MiniBrowser/mac/BrowserWindowController.m:
3145
3146 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3147
3148         Reviewed by Eric Seidel.
3149
3150         Add --no-build option to run-sunspider
3151         https://bugs.webkit.org/show_bug.cgi?id=51658
3152
3153         * Scripts/run-sunspider: add --no-build flag to skip building
3154         phase.
3155
3156 2010-12-27  Daniel Bates  <dbates@rim.com>
3157
3158         Rubber-stamped by Martin Robinson.
3159
3160         Append the directory Tools/DumpRenderTree to the list of directories that
3161         do-webcore-rename should search so that it can rename DRT files and
3162         source code.
3163
3164         * Scripts/do-webcore-rename:
3165
3166 2010-12-27  Eric Seidel  <eric@webkit.org>
3167
3168         Reviewed by Adam Barth.
3169
3170         build-webkit should detect missing Java SDK and explain how to install it
3171         https://bugs.webkit.org/show_bug.cgi?id=51651
3172
3173         * Scripts/build-webkit:
3174
3175 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3176
3177         Reviewed by Daniel Bates.
3178
3179         [GTK] Add support for build-jsc
3180         https://bugs.webkit.org/show_bug.cgi?id=51625
3181
3182         Add GTK+ support to build-jsc now that building the jsc executable as
3183         a standalone target is easy.
3184
3185         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3186         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3187         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3188         and pass it along to buildAutotoolsProject.
3189
3190 2010-12-27  David Levin  <levin@chromium.org>
3191
3192         Reviewed by Eric Seidel.
3193
3194         check-webkit-style check for meaningless variable names in function declarations.
3195         https://bugs.webkit.org/show_bug.cgi?id=51523
3196
3197         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3198         from the new check and whitespace/parens because the syntax is unusual and
3199         produced a fair number of positives for these checks.
3200         * Scripts/webkitpy/style/checkers/cpp.py:
3201         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3202         and parameter names when determining if the parameter name is useless.
3203         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3204         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3205         format.
3206         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3207         text or an acronym of it.
3208         (check_function_definition): Checks function definitions for meaningless variable names.
3209         (process_line): Added call to check_function_definition.
3210         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3211         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3212         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3213         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3214         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3215         because when only checking a snippet, there are a lot of bogus functions.
3216         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3217         that I put there previously and just noticed.
3218         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3219         check_function_definition and process_line.
3220
3221 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3222
3223         Reviewed by Martin Robinson.
3224
3225         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3226         https://bugs.webkit.org/show_bug.cgi?id=51591
3227
3228         Flash plugin uses gtk2 that is incompatible with gtk3 making
3229         webkit crash when it's built with gtk3.
3230
3231         * GtkLauncher/main.c:
3232         (main):
3233
3234 2010-12-25  Adam Barth  <abarth@webkit.org>
3235
3236         Reviewed by Eric Seidel.
3237
3238         Move ANGLE to Sources/ThirdParty
3239         https://bugs.webkit.org/show_bug.cgi?id=51605
3240
3241         * Scripts/build-webkit:
3242           - Point to the new ANGLE location.
3243
3244 2010-12-26  David Levin  <levin@chromium.org>
3245
3246         Reviewed by Eric Seidel.
3247
3248         check-webkit-style should be able to parse function declaration parameters.
3249         https://bugs.webkit.org/show_bug.cgi?id=51451
3250
3251         * Scripts/webkitpy/style/checkers/cpp.py:
3252         (Position.__init__): Holds simple position information (row, column).
3253         (Parameter.__init__): Holds information about a parameter.
3254         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3255         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3256         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3257         (find_parameter_name_index): Finds where the parameter name is.
3258         (parameter_list): Generates the list of parameters for a function.
3259         (_FunctionState.begin): Added information to allow determining the parameters
3260         on demand.
3261         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3262         (detect_functions): Improve function detection for operator functions and
3263         determine where the parameters end and pass that to _FunctionState.begin.
3264         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3265         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3266         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3267         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3268         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3269         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3270         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3271         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3272         the parameters found.
3273         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3274         detection test to verify that we catch the operator functions.
3275         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3276         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3277         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3278         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3279         test_function_length_check_definition_severity1_for_test.
3280
3281 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3282
3283         Unreviewed WinCE buildfix after r74334.
3284
3285         * CMakeListsWinCE.txt:
3286
3287 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3288
3289         Unreviewed, rolling out r74632.
3290         http://trac.webkit.org/changeset/74632
3291         https://bugs.webkit.org/show_bug.cgi?id=51600
3292
3293         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3294         on #webkit).
3295
3296         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3297         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3298
3299 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3300
3301         Reviewed by Kenneth Rohde Christiansen.
3302
3303         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3304         https://bugs.webkit.org/show_bug.cgi?id=43528
3305
3306         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3307         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3308         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3309         called.
3310
3311         * EWebLauncher/main.c:
3312         (browserCreate):
3313
3314 2010-12-24  Eric Seidel  <eric@webkit.org>
3315
3316         Reviewed by Adam Barth.
3317
3318         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3319         https://bugs.webkit.org/show_bug.cgi?id=28291
3320
3321         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3322         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3323         to strings with find in the diff.
3324         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3325
3326         * Scripts/webkitpy/common/checkout/api.py:
3327         * Scripts/webkitpy/common/checkout/diff_parser.py:
3328         * Scripts/webkitpy/tool/steps/abstractstep.py:
3329         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3330         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3331         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3332         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3333
3334 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3335
3336         Reviewed by Kenneth Russell.
3337
3338         Modify new-run-webkit-tests to shut up and exit when all the threads
3339         are wedged so that test runs complete faster and we don't end up
3340         w/ enormous log files.
3341
3342         https://bugs.webkit.org/show_bug.cgi?id=51572
3343
3344         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3345         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3346
3347 2010-12-24  Eric Seidel  <eric@webkit.org>
3348
3349         Reviewed by David Levin.
3350
3351         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3352         https://bugs.webkit.org/show_bug.cgi?id=51549
3353
3354         I've had multiple people ask me about the commit-queue's behavior
3355         regarding reporting flaky tests.  I figured it would be best to just
3356         have the queue explain itself in the bugs it files.
3357
3358         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3359         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3360
3361 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3362
3363         Reviewed by Eric Seidel.
3364
3365         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3366         https://bugs.webkit.org/show_bug.cgi?id=51467
3367
3368         * Scripts/webkitpy/style/checker.py:
3369         * Scripts/webkitpy/style/checker_unittest.py:
3370
3371 2010-12-23  Adam Barth  <abarth@webkit.org>
3372
3373         Rubber-stamped by Eric Seidel.
3374
3375         Move JavaScriptGlue into Sources
3376         https://bugs.webkit.org/show_bug.cgi?id=51583
3377
3378         These tools refer to JavaScriptGlue and need to be updated to its new
3379         location.
3380
3381         * Scripts/build-webkit:
3382         * Scripts/do-file-rename:
3383         * Scripts/do-webcore-rename:
3384         * Scripts/webkitpy/common/config/build.py:
3385         * Scripts/webkitpy/common/config/build_unittest.py:
3386
3387 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3388
3389         Reviewed by Eric Seidel.
3390
3391         Bug 51539 - update iexploder scripts to point to new location
3392
3393         * Scripts/run-iexploder-tests:
3394         * Scripts/update-iexploder-cssproperties:
3395
3396 2010-12-23  Evan Martin  <evan@chromium.org>
3397
3398         Reviewed by Ryosuke Niwa.
3399
3400         [chromium] LayoutTestController warning in float->int conversion
3401         https://bugs.webkit.org/show_bug.cgi?id=51553
3402
3403         Rather than reading an int, converting to a float, then getting a compiler
3404         warning on passing the float to something that expects an int, instead
3405         just pass around ints.
3406
3407         No tests, fixes a compiler warning.
3408
3409         * DumpRenderTree/chromium/LayoutTestController.cpp:
3410         (parsePageSizeParameters):
3411         (LayoutTestController::pageNumberForElementById):
3412         (LayoutTestController::numberOfPages):
3413
3414 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3415
3416         Reviewed by Darin Adler.
3417
3418         Bug 51537 - iexploder needs cleanup
3419         
3420         * iExploder/htdocs: Removed.
3421         * iExploder/htdocs/config.rb: Removed.
3422         * iExploder/htdocs/cssproperties.in: Removed.
3423         * iExploder/htdocs/cssvalues.in: Removed.
3424         * iExploder/htdocs/htmlattrs.in: Removed.
3425         * iExploder/htdocs/htmltags.in: Removed.
3426         * iExploder/htdocs/htmlvalues.in: Removed.
3427         * iExploder/htdocs/iexploder.cgi: Removed.
3428         * iExploder/htdocs/iexploder.rb: Removed.
3429         * iExploder/htdocs/index.html: Removed.
3430         * iExploder/htdocs/webserver.rb: Removed.
3431         * iExploder/iexploder-1.7.2/output: Removed.
3432         * iExploder/tools: Removed.
3433         * iExploder/tools/lasthit.rb: Removed.
3434         * iExploder/tools/osx_last_crash.rb: Removed.
3435         * iExploder/tools/showtest.rb: Removed.
3436
3437 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3438
3439         Reviewed by Kenneth Rohde Christiansen.
3440
3441         [EFL] Make 'single' the default backing store in EWebLauncher
3442         https://bugs.webkit.org/show_bug.cgi?id=51534
3443
3444         'single' is the simplest backing store and the one intended to be the
3445         default in the test browser. By mistake the tiled backing store was
3446         left as default in r72617.
3447
3448         * EWebLauncher/main.c:
3449         (browserCreate): ditto.
3450
3451 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3452
3453         Reviewed by Kenneth Rohde Christiansen.
3454
3455         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3456         https://bugs.webkit.org/show_bug.cgi?id=51533
3457
3458         There's no point in concatenating env("HOME") with "blah", so remove
3459         option from EWebLauncher.
3460
3461         * EWebLauncher/main.c:
3462         (main): ditto.
3463
3464 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3465
3466         Reviewed by Eric Seidel.
3467
3468         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3469
3470         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3471         I just discovered that we have two additional GC runs per each WebViewHost.
3472         Test_shell had no such calls.
3473         These gc runs eat 15% of cpu time.
3474
3475         https://bugs.webkit.org/show_bug.cgi?id=51479
3476
3477         * DumpRenderTree/chromium/WebViewHost.cpp:
3478         (WebViewHost::~WebViewHost):
3479
3480 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3481
3482         Reviewed by Ojan Vafai.
3483
3484         This change splits out the TestRunner class into its own file.
3485         When we fork the code for message passing, we will create a new
3486         TestRunner, and this change will allow that to be more modular.
3487
3488         While we're at it, split out TestInput and ResultSummary into
3489         their own files, to reduce the size of run_webkit_tests to
3490         something more managable.
3491
3492         https://bugs.webkit.org/show_bug.cgi?id=51092
3493
3494         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3495         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3496         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3497         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3498         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3499         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3500         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3501
3502  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3503
3504         Reviewed by Ojan Vafai.
3505
3506         nrwt multiprocessing - start over, prepare to fork the code
3507  
3508         This code cleans up the signatures and implementation of the
3509         TestRunner class so we can easily fork it to run either the
3510         stable implementation or the new, unstable message-passing
3511         implementation. The two variants will have different
3512         implementations of the run_tests() method. We will switch
3513         between the two based on the setting for the '--worker-model'
3514         switch. We rename the two currently valid values to 'old-inline'
3515         and 'old-threads'.
3516
3517         https://bugs.webkit.org/show_bug.cgi?id=51081
3518
3519         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3520         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3521
3522 2010-12-22  Victor Wang  <victorw@chromium.org>
3523
3524         Reviewed by Darin Fisher.
3525
3526         [Chromium] Update chromium archive test result url in rebaseline script.
3527
3528         https://bugs.webkit.org/show_bug.cgi?id=51503
3529
3530         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3531
3532 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3533
3534         Reviewed by Alice Liu.
3535
3536         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3537         Verified on Chrome, Safari, and IE.
3538         With this change, we will record memory from a parent browser window and all child processes.
3539
3540         * record-memory-win/main.cpp:
3541         (ProcessArgs):
3542         (PrintUsage):
3543         (getMemoryInfo):
3544         (printProcessInfo):
3545         (evalProcesses):
3546         (UseImage):
3547         (QueryContinuously):
3548         (ElapsedTime):
3549
3550 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3551
3552         Unreviewed rollout r74489, because it was missing changelog.
3553
3554         * record-memory-win/main.cpp:
3555         
3556 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3557
3558         Adding myself as a reviewer.
3559
3560         * Scripts/webkitpy/common/config/committers.py:
3561
3562 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3563
3564         Unreviewed.  Adding myself to committers.py.
3565
3566         * Scripts/webkitpy/common/config/committers.py:
3567
3568 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3569
3570         Reviewed by Kenneth Rohde Christiansen.
3571
3572         TestNetscapePlugIn should use #if defined
3573         https://bugs.webkit.org/show_bug.cgi?id=51471
3574
3575         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3576         (NP_Initialize):
3577         (NPP_New):
3578
3579 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3580
3581         Reviewed by Yury Semikhatsky.
3582
3583         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3584
3585         DevTools window should be closed explicitly because it has custom deinitialization code.
3586
3587         https://bugs.webkit.org/show_bug.cgi?id=50722
3588
3589         * DumpRenderTree/chromium/TestShell.cpp:
3590         (TestShell::closeRemainingWindows):
3591
3592 2010-12-22  David Levin  <levin@chromium.org>
3593
3594         Reviewed by Shinichiro Hamaji.
3595
3596         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3597         https://bugs.webkit.org/show_bug.cgi?id=51452
3598
3599         * Scripts/webkitpy/style/checkers/cpp.py:
3600         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3601         Using the file extension if possible but falling back to the file contents if we have a header file.
3602         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3603         (_FileState.is_c_or_objective_c):
3604         (check_using_std): Changed to using _FileState to determine the file type.
3605         (check_max_min_macros): Ditto.
3606         (check_for_null): Ditto.
3607         (check_style): Changed the parameters to various calls since they now need _FileState
3608         to determine the file type.
3609         (check_language): Added the file_state parameter so it could be passed
3610         to check_identifier_name_in_declaration.
3611         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3612         this is an Objective C file.
3613         (_process_lines): Added information for the _FileState constructor (and moved the
3614         call to a place that had the information).
3615         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3616         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3617         its functionality.
3618         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3619
3620 2010-12-21  Andy Estes  <aestes@apple.com>
3621
3622         Reviewed by Mark Rowe.
3623
3624         Do not build non-Intel architectures for WebKit2-related projects.
3625         https://bugs.webkit.org/show_bug.cgi?id=51440
3626
3627         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3628         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3629         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3630
3631 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3632
3633         Reviewed by Darin Fisher.
3634
3635         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3636         https://bugs.webkit.org/show_bug.cgi?id=51406 
3637         
3638         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3639         to WebThemeEngineDRTWin and update references everywhere.
3640
3641         * DumpRenderTree/DumpRenderTree.gypi:
3642         * DumpRenderTree/chromium/TestShellWin.cpp:
3643         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3644         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3645         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3646         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3647
3648 2010-12-21  Anders Carlsson  <andersca@apple.com>
3649
3650         Reviewed by John Sullivan.
3651
3652         Clicking missing plug-in text does not show a sheet
3653         https://bugs.webkit.org/show_bug.cgi?id=51403
3654
3655         Update for changes to the WebPageUIClient.
3656
3657         * MiniBrowser/mac/BrowserWindowController.m:
3658         (-[BrowserWindowController awakeFromNib]):
3659         * WebKitTestRunner/TestController.cpp:
3660         (WTR::createOtherPage):
3661         (WTR::TestController::initialize):
3662
3663 2010-12-21  Eric Seidel  <eric@webkit.org>
3664
3665         Reviewed by Adam Barth.
3666
3667         commit-queue will report constant failures as flaky if other tests flake
3668         https://bugs.webkit.org/show_bug.cgi?id=51272
3669
3670         This patch just removes functionality and adds testing.
3671         Previously we attempted to report flaky tests when we had
3672         two different tests fail in a row.  However, since we stop
3673         running the tests at the first failure, our code was wrong in
3674         trying to determine flakiness from the incomplete runs.
3675
3676         Originally I posted an alternate patch:
3677         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3678         which fixed our flaky logic in this case, however it was decided
3679         that that patch would be too difficult to maintain, so now
3680         I'm just removing the broken logic.
3681
3682         This will dramatically cut-down on our flaky-test false positives
3683         at the (small) cost of the queues being unable to report
3684         any flakiness if the tree is very flaky.  (With at least one test
3685         flaking on every run, we'll never report failures anymore.)  I think
3686         this is a tradeoff worth making.
3687
3688         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3689         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3690
3691 2010-12-20  Eric Seidel  <eric@webkit.org>
3692
3693         Reviewed by Adam Barth.
3694
3695         commit-queue wrongly rejects patches when it can't update itself
3696