Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-21  Takashi Toyoshima  <toyoshim@chromium.org>
2
3         Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
4         https://bugs.webkit.org/show_bug.cgi?id=72859
5
6         Reviewed by Eric Seidel.
7         
8         * Scripts/new-run-webkit-websocketserver:
9
10 2011-11-20  Shinya Kawanaka  <shinyak@google.com>
11
12         [Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
13         https://bugs.webkit.org/show_bug.cgi?id=72655
14
15         Reviewed by Hajime Morita.
16
17         Fixed the calculation of offset.
18
19         * DumpRenderTree/chromium/WebViewHost.cpp:
20         (WebViewHost::finishLastTextCheck):
21
22 2011-11-20  Ojan Vafai  <ojan@chromium.org>
23
24         Change the final place where we use version 3 of the results json output
25         https://bugs.webkit.org/show_bug.cgi?id=72838
26
27         Reviewed by Adam Barth.
28
29         This converts the json from being a flat map of test name --> results
30         to being hierarchical by directory. This will make the json files 
31         considerably smaller.
32
33         Also cleaned up some functions that were returning/checking boolean values
34         that were always True.
35
36         * TestResultServer/model/jsonresults.py:
37         * TestResultServer/model/jsonresults_unittest.py:
38
39 2011-11-20  Ojan Vafai  <ojan@chromium.org>
40
41         Include the master name when querying the test results server.
42         This will soon be required since leaving the master name out mean
43         that multiple files could match the query.
44
45         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
46
47 2011-11-19  Ojan Vafai  <ojan@chromium.org>
48
49         Fix jsonp callback code to add the callback if json content
50         is not jsonp.
51         * TestResultServer/handlers/testfilehandler.py:
52
53 2011-11-19  Alice Boxhall  <aboxhall@chromium.org>
54
55         Modify dashboard_base.js to optionally accept version 4 results json.
56
57         Reviewed by Ojan Vafai.
58
59         * TestResultServer/static-dashboards/dashboard_base.js:
60         (ADD_RESULTS):
61         (flattenTrie):
62         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
63         (testFlattenTrie):
64
65 2011-11-19  Ojan Vafai  <ojan@chromium.org>
66
67         Stop storing results files as jsonp in the test results server
68         https://bugs.webkit.org/show_bug.cgi?id=72814
69
70         Reviewed by Adam Barth.
71
72         * TestResultServer/model/jsonresults.py:
73         * TestResultServer/model/jsonresults_unittest.py:
74
75 2011-11-19  Ojan Vafai  <ojan@chromium.org>
76
77         Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
78         https://bugs.webkit.org/show_bug.cgi?id=72813
79
80         Reviewed by Adam Barth.
81
82         Once this lands, we can start storing pure json in the test results server and then
83         we can delete the code with all the FIXMEs added here.
84
85         * Scripts/webkitpy/layout_tests/controllers/manager.py:
86         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
87         Only add jsonp for full_results.json.
88         * TestResultServer/model/jsonresults.py:
89         * TestResultServer/model/jsonresults_unittest.py:
90         Accept pure json uploads.
91         * TestResultServer/static-dashboards/dashboard_base.js:
92         (appendJSONScriptElementFor):
93         Use the callback parameter so that the server can start returning pure json if it's left out.
94
95 2011-11-19  Ojan Vafai  <ojan@chromium.org>
96
97         Allow json NRWT downloads to be pure json and not jsonp
98         https://bugs.webkit.org/show_bug.cgi?id=72809
99
100         Reviewed by Adam Barth.
101
102         I'm moving the server to storing and serving up raw json instead of jsonp.
103         You can still get the jsonp by passing a "callback" parameter, but there's no
104         need for run-webkit-tests to get jsonp when all it wants is the raw json.
105
106         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
107         Make the wrapper stripping only happen if the json is actually wrapped.
108         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
109
110 2011-11-18  Daniel Bates  <dbates@rim.com>
111
112         Add CMake build infrastructure for the BlackBerry port
113         https://bugs.webkit.org/show_bug.cgi?id=72768
114
115         Reviewed by Antonio Gomes.
116
117         Add optional --blackberry command line argument to build-webkit to build the
118         BlackBerry port.
119
120         * Scripts/build-webkit:
121         * Scripts/webkitdirs.pm:
122         (determineBaseProductDir):
123         (argumentsForConfiguration):
124         (builtDylibPathForName):
125         (determineIsQt):
126         (isBlackBerry): Added.
127         (determineIsBlackBerry): Added.
128         (blackberryTargetArchitecture): Added.
129         (isAppleWebKit):
130
131 2011-11-18  James Robinson  <jamesr@chromium.org>
132
133         Unreviewed, rolling out r100835.
134         http://trac.webkit.org/changeset/100835
135         https://bugs.webkit.org/show_bug.cgi?id=72778
136
137         Broke some page scale tests
138
139         * DumpRenderTree/chromium/EventSender.cpp:
140         (EventSender::scalePageBy):
141
142 2011-11-18  Adam Barth  <abarth@webkit.org>
143
144         Prepare to move manual-tests out of WebCore
145         https://bugs.webkit.org/show_bug.cgi?id=72782
146
147         Reviewed by Eric Seidel.
148
149         Update this file to refer to the new location of ManualTests.
150
151         * Scripts/webkitpy/common/config/build.py:
152
153 2011-11-18  James Robinson  <jamesr@chromium.org>
154
155         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
156         https://bugs.webkit.org/show_bug.cgi?id=72778
157
158         Reviewed by Kenneth Russell.
159
160         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
161
162         * DumpRenderTree/chromium/EventSender.cpp:
163         (EventSender::scalePageBy):
164
165 2011-11-18  Scott Graham  <scottmg@chromium.org>
166
167         IDL changes for gamepad support
168         https://bugs.webkit.org/show_bug.cgi?id=71753
169
170         Reviewed by Adam Barth.
171
172         Runtime enable gamepad in chromium test shell.
173
174         * DumpRenderTree/chromium/TestShell.cpp:
175         (TestShell::TestShell):
176
177 2011-10-27  Darin Fisher  <darin@chromium.org>
178
179         [chromium] Improve fullscreen API
180         https://bugs.webkit.org/show_bug.cgi?id=70477
181
182         Reviewed by Adam Barth.
183
184         Implement enter/exitFullScreen.  The implementation is asynchronous,
185         via postDelayedTask, to simulate how the browser actually behaves.
186
187         * DumpRenderTree/chromium/WebViewHost.cpp:
188         (WebViewHost::enterFullScreen):
189         (WebViewHost::exitFullScreen):
190         (WebViewHost::setAddressBarURL):
191         (WebViewHost::enterFullScreenNow):
192         (WebViewHost::exitFullScreenNow):
193         * DumpRenderTree/chromium/WebViewHost.h:
194
195 2011-11-18  Adam Roben  <aroben@apple.com>
196
197         Ignore an ANGLE leak that is not WebKit's fault
198
199         * Scripts/old-run-webkit-tests:
200         (countAndPrintLeaks):
201         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
202         (LeakDetector._callstacks_to_exclude_from_leaks):
203         Added ScanFromString to the call stacks to exclude on all OS versions.
204
205 2011-11-18  Adam Roben  <aroben@apple.com>
206
207         Ignore another Lion-specific leak that is not WebKit's fault
208
209         * Scripts/old-run-webkit-tests:
210         (countAndPrintLeaks):
211         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
212         (LeakDetector._callstacks_to_exclude_from_leaks):
213         Added SecTransformExecute to the call stacks to exclude.
214
215 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
216
217         [Qt] Enable WebSocket hybi tests
218         https://bugs.webkit.org/show_bug.cgi?id=72687
219
220         Reviewed by Simon Hausmann.
221
222         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
223
224         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
225         (WebCore::WebPage::resetSettings):
226         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
227         (LayoutTestController::overridePreference):
228
229 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
230
231         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
232         https://bugs.webkit.org/show_bug.cgi?id=72707
233
234         Reviewed by Philippe Normand.
235
236         Make new-run-webkit-tests use the right path to locate the test
237         plugin used by WebKitTestRunner.
238
239         * Scripts/webkitpy/layout_tests/port/gtk.py:
240
241 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
242
243         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
244         https://bugs.webkit.org/show_bug.cgi?id=72697
245
246         Reviewed by Kenneth Rohde Christiansen.
247
248         * Tools.pro: Make WTR linux only for the moment.
249         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
250         * WebKitTestRunner/Target.pri: Ditto.
251         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
252         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
253
254 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
255
256         [Qt] Change default size of the MiniBrowser
257
258         Reviewed by Simon Hausmann.
259
260         As we lay out desktop pages using the width of 980, change our default
261         size to 980x735 so that we are not scaling down by default.
262
263         * MiniBrowser/qt/MiniBrowserApplication.h:
264         (WindowOptions::WindowOptions):
265
266 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
267
268         [EFL] Clean up the use of DATA_DIR in the buildsystem
269         https://bugs.webkit.org/show_bug.cgi?id=72681
270
271         Reviewed by Daniel Bates.
272
273         Instead of adding -DDATA_DIR in all scopes, only define it in
274         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
275         it.
276
277         We can then define DATA_DIR to the generated theme directory for
278         EWebLauncher, since it's what we want here.
279
280         * CMakeListsEfl.txt:
281
282 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
283
284         [EFL] Move platform includes last in DRT's include directories.
285         https://bugs.webkit.org/show_bug.cgi?id=72684
286
287         Reviewed by Daniel Bates.
288
289         This is the first step in fixing the build when a platform include (in
290         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
291         is included instead of WebKit's.
292
293         * DumpRenderTree/efl/CMakeLists.txt:
294
295 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
296
297         fuzzy_match doesn't recognize "Dan B" or "hyatt"
298         https://bugs.webkit.org/show_bug.cgi?id=72636
299
300         Reviewed by Eric Seidel.
301
302         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
303         and user names of email addreses such as rniwa in rniwa@webkit.org.
304
305         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
306
307         * Scripts/webkitpy/common/config/committers.py:
308         * Scripts/webkitpy/common/config/committers_unittest.py:
309
310 2011-11-17  Eric Seidel  <eric@webkit.org>
311
312         Remove support for running check-webkit-style w/o a webkit checkout
313         https://bugs.webkit.org/show_bug.cgi?id=72678
314
315         Reviewed by Adam Barth.
316
317         After talking to Dave Levin we've decided to remove this
318         code.  I know of no users of check-webkit-style w/o a webkit checkout
319         and this needlessly adds complexity.
320
321         * Scripts/webkitpy/style/main.py:
322
323 2011-11-17  Eric Seidel  <eric@webkit.org>
324
325         Remove more direct uses of os.path
326         https://bugs.webkit.org/show_bug.cgi?id=72677
327
328         Reviewed by Adam Barth.
329
330         Remove more uses of os.path, including refactoring
331         CommitterValidator to use a Host object instead of
332         manual hacks to emulate what SCM and FileSystem provide.
333
334         * Scripts/webkitpy/common/checkout/changelog.py:
335         * Scripts/webkitpy/common/config/committervalidator.py:
336         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
337         * Scripts/webkitpy/common/system/filesystem_mock.py:
338          - Turns out none of our unittests actually looked at this path.
339            now I've made it be a valid path.
340         * Scripts/webkitpy/tool/bot/feeders.py:
341         * Scripts/webkitpy/tool/commands/queues.py:
342
343 2011-11-17  Eric Seidel  <eric@webkit.org>
344
345         Teach TextFileReader about FileSystem
346         https://bugs.webkit.org/show_bug.cgi?id=72673
347
348         Reviewed by Adam Barth.
349
350         Unfortunately TextFileReader doesn't use FileSystem
351         everywhere yet, so we can't move the unittests to
352         using MockFileSystem, but we're close.
353
354         * Scripts/webkitpy/style/filereader.py:
355         * Scripts/webkitpy/style/filereader_unittest.py:
356         * Scripts/webkitpy/style/main.py:
357
358 2011-11-17  Eric Seidel  <eric@webkit.org>
359
360         Give check-webkit-style a Host
361         https://bugs.webkit.org/show_bug.cgi?id=72670
362
363         Reviewed by Adam Barth.
364
365         * Scripts/webkitpy/common/checkout/scm/detection.py:
366         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
367          - We don't run these unittests, but this one was looking for the wrong exception.
368         * Scripts/webkitpy/style/main.py:
369         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
370          - This was create a new scm object even though it already had one?
371
372 2011-11-17  Eric Seidel  <eric@webkit.org>
373
374         Move check-webkit-style change_directory code to more modern mocks
375         https://bugs.webkit.org/show_bug.cgi?id=72664
376
377         Reviewed by Adam Barth.
378
379         * Scripts/check-webkit-style:
380         * Scripts/webkitpy/style/main.py:
381         * Scripts/webkitpy/style/main_unittest.py:
382
383 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
384
385         [GTK] enable ref tests
386         https://bugs.webkit.org/show_bug.cgi?id=72601
387
388         Re-enable ref tests. Run the driver under evenly numbered display if performing
389         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
390         being run in an already used Xvfb instance if pixel tests are disabled.
391
392         Reviewed by Tony Chang.
393
394         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
395         after the process is killed
396
397 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
398
399         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
400         https://bugs.webkit.org/show_bug.cgi?id=72620
401
402         Reviewed by David Levin.
403
404         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
405         adding the suffix the cpp file. One example of false positive
406         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
407
408         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
409         basename contains the cpp's basename.
410         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
411
412 2011-11-17  Eric Seidel  <eric@webkit.org>
413
414         Move check-webkit-style's guts into webkitpy/style/main.py
415         https://bugs.webkit.org/show_bug.cgi?id=72657
416
417         Reviewed by Adam Barth.
418
419         * Scripts/check-webkit-style:
420         * Scripts/webkitpy/style/main.py:
421
422 2011-11-17  Eric Seidel  <eric@webkit.org>
423
424         new-run-webkit-tests is locale dependent
425         https://bugs.webkit.org/show_bug.cgi?id=68691
426
427         Reviewed by Adam Barth.
428
429         Make NRWT use a clean environment, just like ORWT did.
430
431         * Scripts/webkitpy/layout_tests/port/base.py:
432         * Scripts/webkitpy/layout_tests/port/chromium.py:
433         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
434         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
435         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
436         * Scripts/webkitpy/layout_tests/port/efl.py:
437         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
438         * Scripts/webkitpy/layout_tests/port/mac.py:
439         * Scripts/webkitpy/layout_tests/port/qt.py:
440         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
441         * Scripts/webkitpy/layout_tests/port/webkit.py:
442         * Scripts/webkitpy/layout_tests/port/win.py:
443
444 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
445
446         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
447         https://bugs.webkit.org/show_bug.cgi?id=72615
448
449         Reviewed by James Robinson.
450
451         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
452
453 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
454
455         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
456         https://bugs.webkit.org/show_bug.cgi?id=72595
457
458         Reviewed by Noam Rosenthal.
459
460         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
461         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
462         ensure the registration of the DRTNode JS bindings.
463         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
464         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
465         registration of QWebElement (now done implicitly through QWebPage ->
466         QtWebElementRunTime::initialize code path)
467
468 2011-11-17  Adam Roben  <aroben@apple.com>
469
470         Fix a crash-inducing typo I introduced in r100648
471
472         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
473         handling a crashing test
474
475         Reviewed by Adam Barth.
476
477         * Scripts/webkitpy/layout_tests/port/chromium.py:
478         (ChromiumDriver.run_test): Get the driver name from the port.
479
480         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
481         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
482         right crashed process name.
483
484 2011-11-17  Adam Roben  <aroben@apple.com>
485
486         Fix NRWT's parsing of the number of excluded leaks
487
488         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
489         leaks were excluded
490
491         Reviewed by Adam Barth.
492
493         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
494         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
495         regular expression match, not the entire matched string.
496
497         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
498         (LeakDetectorTest): Added some example output that shows how things look when leaks are
499         excluded.
500         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
501         correctly.
502
503 2011-11-17  Adam Roben  <aroben@apple.com>
504
505         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
506
507         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
508         when web process crashes, but WebProcess crash log should get saved instead
509
510         Reviewed by Eric Seidel.
511
512         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
513         (write_test_result): Simplified a little to share more code between the case where we
514         crashed when running the test and where we crashed when checking the expected rendering for
515         a reftest. Changed to pass the crashed process name down to write_crash_report.
516         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
517         along to CrashLogs.find_newest_log rather than always using the driver name.
518
519         * Scripts/webkitpy/layout_tests/port/chromium.py:
520         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
521         crashed.
522
523         * Scripts/webkitpy/layout_tests/port/test.py:
524         (TestInstance.__init__): Initialize new web_process_crash attribute.
525         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
526         test this patch adds.
527         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
528         specifies that the driver crashed or the web process crashed.
529
530         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
531         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
532         which we pretend the web process crashed rather than the driver process.
533
534         (MainTest.test_run_singly_actually_runs_tests):
535         (MainTest.test_unexpected_failures):
536         (EndToEndTest.test_end_to_end):
537         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
538
539 2011-11-17  Tony Chang  <tony@chromium.org>
540
541         [chromium] stop spamming features warning on every build
542         https://bugs.webkit.org/show_bug.cgi?id=72629
543
544         Reviewed by Ojan Vafai.
545
546         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
547         $mediaStreamSupport is on by default for chromium, make the default
548         for $blobSupport also on.
549
550         * Scripts/build-webkit:
551
552 2011-11-17  Adam Roben  <aroben@apple.com>
553
554         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
555
556         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
557         that are supposed to be ignored
558
559         Reviewed by Adam Barth.
560
561         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
562         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
563         required when passing arguments via the shell (which we aren't doing here). It is not
564         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
565
566         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
567         (LeakDetectorTest.test_leaks_args): Updated expectations.
568
569 2011-11-17  Philippe Normand  <pnormand@igalia.com>
570
571         Unreviewed, run-bindings-tests fix after r91028.
572
573         * Scripts/run-bindings-tests: Use scm.detection module.
574
575 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
576
577         Silence a warning about control reaching the end of a non-void function
578         https://bugs.webkit.org/show_bug.cgi?id=72616
579
580         Reviewed by Tony Gentilcore.
581
582         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
583         (AccessibilityUIElement::verticalScrollbar):
584
585 2011-11-17  Adam Roben  <aroben@apple.com>
586
587         Ignore some leaks in frameworks we link against on Lion
588
589         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
590         aren't WebKit's fault
591
592         Reviewed by Antti Koivisto.
593
594         * Scripts/old-run-webkit-tests:
595         (countAndPrintLeaks):
596         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
597         (LeakDetector._callstacks_to_exclude_from_leaks):
598         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
599
600         * Scripts/webkitpy/layout_tests/port/mac.py:
601         (MacPort.is_lion): Added.
602
603         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
604         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
605         methods.
606
607 2011-11-17  Philippe Normand  <pnormand@igalia.com>
608
609         [GTK] Disable ref tests
610         https://bugs.webkit.org/show_bug.cgi?id=72599
611
612         Reviewed by Xan Lopez.
613
614         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
615         tests to avoid massive flakiness.
616
617 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
618
619         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
620
621         A new extension object has been added to QQuickWebView (the same approach should be used
622         for other API classes that need experimental APIs). The QML extension mechanism is then
623         built on top of the experimental object.
624
625         https://bugs.webkit.org/show_bug.cgi?id=72522
626
627         Reviewed by Simon Hausmann.
628
629         * MiniBrowser/qt/BrowserWindow.cpp:
630         (BrowserWindow::BrowserWindow):
631         (BrowserWindow::webView):
632         * MiniBrowser/qt/BrowserWindow.h:
633         * MiniBrowser/qt/UrlLoader.cpp:
634         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
635         * qmake/mkspecs/features/default_post.prf:
636         * qmake/mkspecs/features/default_pre.prf:
637         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
638         * qmake/mkspecs/features/qtwebkit.prf:
639
640 2011-11-17  Adam Barth  <abarth@webkit.org>
641
642         Move test_results_uploader.py out of layout_package
643         https://bugs.webkit.org/show_bug.cgi?id=72590
644
645         Reviewed by Eric Seidel.
646
647         Most of the lines of code in this file are wrong, but I've restrained
648         myself and only changed a few of them to generalized this class to the
649         common package.
650
651         This is part of a series of patches to remove layout_package.
652
653         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
654         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
655         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
656
657 2011-11-17  Adam Barth  <abarth@webkit.org>
658
659         Unreviewed. Fix style nits in printing.py.
660
661         * Scripts/webkitpy/layout_tests/views/printing.py:
662
663 2011-11-17  Adam Barth  <abarth@webkit.org>
664
665         Minor style nits in run_webkit_tests.py
666         https://bugs.webkit.org/show_bug.cgi?id=72583
667
668         Reviewed by Eric Seidel.
669
670         This patch just fixes some minor style issues as I work my way back
671         into this code.
672
673         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
674
675 2011-11-17  Adam Barth  <abarth@webkit.org>
676
677         Move test_result_writer out of layout_package
678         https://bugs.webkit.org/show_bug.cgi?id=72586
679
680         Rubber-stamped by Eric Seidel.
681
682         This is part of a series of patches to remove layout_package.
683
684         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
685         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
686         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
687         * Scripts/webkitpy/tool/commands/rebaseline.py:
688
689 2011-11-17  Adam Barth  <abarth@webkit.org>
690
691         svn-apply shouldn't magically move files into Source anymore
692         https://bugs.webkit.org/show_bug.cgi?id=72579
693
694         Reviewed by Eric Seidel.
695
696         The Source directory has existed for long enough that we don't need
697         svn-apply to magically re-write old-style patches anymore.
698
699         * Scripts/VCSUtils.pm:
700         (parseGitDiffHeader):
701         (parseSvnDiffHeader):
702
703 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
704
705         Add a list of contribution areas
706         https://bugs.webkit.org/show_bug.cgi?id=72566
707
708         Reviewed by Eric Seidel.
709
710         Added ContributionAreas class.
711
712         * Scripts/webkitpy/common/config/contributionareas.py: Added.
713         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
714
715 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
716
717         Refactor ChangeLogTest.test_parse_reviewer_text
718         https://bugs.webkit.org/show_bug.cgi?id=72572
719
720         Reviewed by Eric Seidel.
721
722         Refactored the test code by introduing two helper functions.
723
724         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
725
726 2011-11-16  Eric Seidel  <eric@webkit.org>
727
728         Add SCMDetector object to make scm detection mockable
729         https://bugs.webkit.org/show_bug.cgi?id=72247
730
731         Reviewed by Adam Barth.
732
733         I think SCM detection may eventually be rolled into Checkout,
734         but this patch at least makes it possible to mock code-paths
735         which rely on scm detection.
736         In the process of replacing callers of these free-functions
737         I found that one of the functions was no longer used,
738         and that one of the callers could instead just use the SCM
739         object it already had access to through port.host.scm().
740         I also discovered that I was not calling Host._initialize_scm()
741         and thus host.scm() was always returning None!
742
743         * Scripts/check-webkit-style:
744         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
745         * Scripts/webkitpy/common/checkout/deps.py:
746         * Scripts/webkitpy/common/checkout/scm/__init__.py:
747         * Scripts/webkitpy/common/checkout/scm/detection.py:
748         * Scripts/webkitpy/common/checkout/scm/git.py:
749         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
750         * Scripts/webkitpy/common/checkout/scm/svn.py:
751         * Scripts/webkitpy/common/host.py:
752         * Scripts/webkitpy/common/host_mock.py:
753         * Scripts/webkitpy/layout_tests/controllers/manager.py:
754         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
755         * Scripts/webkitpy/layout_tests/port/base.py:
756         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
757         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
758         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
759         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
760
761 2011-11-16  Mark Rowe  <mrowe@apple.com>
762
763         Fix the build.
764
765         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
766         Apply the workaround that we use in other projects to WebKitTestRunner.
767
768         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
769         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
770         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
771
772 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
773
774         [Qt] Fix build after WTR AX support
775         https://bugs.webkit.org/show_bug.cgi?id=72560
776
777         Reviewed by Geoffrey Garen.
778
779         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
780         * WebKitTestRunner/InjectedBundle/Target.pri:
781
782 2011-11-16  Tony Chang  <tony@chromium.org>
783
784         repurpose the flexbox bot for grid layout
785         https://bugs.webkit.org/show_bug.cgi?id=72557
786
787         Reviewed by Ryosuke Niwa.
788
789         Since new flexbox is enabled everywhere, we don't need this bot
790         anymore.  However, work on grid layout has begun, so we can use this
791         bot to compile with ENABLE_CSS_GRID_LAYOUT.
792
793         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
794         the bot on the waterfall, I will change the slave config to enable
795         the compile flag and tests.
796
797 2011-11-11  Adrienne Walker  <enne@google.com>
798
799         [chromium] Expose mock scrollbars to window.internals
800         https://bugs.webkit.org/show_bug.cgi?id=72195
801
802         Reviewed by James Robinson.
803
804         Because mock scrollbars are a global setting, reset between runs.
805
806         * DumpRenderTree/chromium/WebPreferences.cpp:
807         (WebPreferences::applyTo):
808
809 2011-11-16  James Robinson  <jamesr@chromium.org>
810
811         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
812         https://bugs.webkit.org/show_bug.cgi?id=72562
813
814         Reviewed by Dirk Pranke.
815
816         * DumpRenderTree/chromium/TestShell.cpp:
817         (TestShell::runFileTest):
818
819 2011-11-16  Tony Chang  <tony@chromium.org>
820
821         [NRWT] speculative fix for multiple subprocess test on cygwin
822         https://bugs.webkit.org/show_bug.cgi?id=72518
823
824         Reviewed by Adam Barth.
825
826         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
827             tries to emulate posix fd behavior.
828         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
829
830 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
831
832         Revert r100509; change was committed twice (first time as r100491).
833         Unreviewed, build fix.
834
835         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
836
837 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
838
839         Run a dummy test in the gpu configurations if there's nothing to do.
840         https://bugs.webkit.org/show_bug.cgi?id=72498
841
842         Reviewed by James Robinson.
843
844         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
845
846 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
847
848         contributors_by_fuzzy_match is super slow
849         https://bugs.webkit.org/show_bug.cgi?id=72540
850
851         Reviewed by Eric Seidel.
852
853         Make contributors_by_name do case insensitive search using a dictionary.
854
855         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
856         because that's the most common case.
857
858         * Scripts/webkitpy/common/config/committers.py:
859         * Scripts/webkitpy/common/config/committers_unittest.py:
860
861 2011-11-16  David Levin  <levin@chromium.org>
862
863         check-webkit-style should recognize functions even if they have OVERRIDE after them.
864         https://bugs.webkit.org/show_bug.cgi?id=72515
865
866         Reviewed by Adam Barth.
867
868         * Scripts/webkitpy/style/checkers/cpp.py:
869         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
870
871 2011-11-16  Tony Chang  <tony@chromium.org>
872
873         [NRWT] refactor drivers to require pixel_tests param
874         https://bugs.webkit.org/show_bug.cgi?id=72517
875
876         Reviewed by Ojan Vafai.
877
878         No tests, just a refactoring.
879
880         * Scripts/webkitpy/layout_tests/port/chromium.py:
881         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
882         * Scripts/webkitpy/layout_tests/port/webkit.py:
883         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
884
885 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
886
887         Run a dummy test in the gpu configurations if there's nothing to do.
888         https://bugs.webkit.org/show_bug.cgi?id=72498
889
890         Reviewed by James Robinson.
891
892         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
893
894 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
895
896         WebKitTestRunner needs to support accessibility-related DRT APIs
897         https://bugs.webkit.org/show_bug.cgi?id=42131
898
899         Reviewed by Beth Dakin.
900
901         Port the AX code in DRT to WKTestRunner by using IDL.
902
903         * DumpRenderTree/AccessibilityUIElement.cpp:
904         (horizontalScrollbarCallback):
905         (verticalScrollbarCallback):
906         (AccessibilityUIElement::horizontalScrollbar):
907         (AccessibilityUIElement::verticalScrollbar):
908         (AccessibilityUIElement::getJSClass):
909         * DumpRenderTree/AccessibilityUIElement.h:
910         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
911         (AccessibilityUIElement::horizontalScrollbar):
912         (AccessibilityUIElement::verticalScrollbar):
913         * WebKitTestRunner/DerivedSources.make:
914         * WebKitTestRunner/GNUmakefile.am:
915         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
916         (WTR::AccessibilityController::create):
917         (WTR::AccessibilityController::AccessibilityController):
918         (WTR::AccessibilityController::~AccessibilityController):
919         (WTR::AccessibilityController::makeWindowObject):
920         (WTR::AccessibilityController::wrapperClass):
921         (WTR::AccessibilityController::rootElement):
922         (WTR::AccessibilityController::focusedElement):
923         (WTR::AccessibilityController::elementAtPoint):
924         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
925         (WTR::AccessibilityController::logFocusEvents):
926         (WTR::AccessibilityController::logValueChangeEvents):
927         (WTR::AccessibilityController::logScrollingStartEvents):
928         (WTR::AccessibilityController::logAccessibilityEvents):
929         (WTR::AccessibilityController::addNotificationListener):
930         (WTR::AccessibilityController::notificationReceived):
931         (WTR::AccessibilityController::resetToConsistentState):
932         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
933         (WTR::AccessibilityTextMarker::create):
934         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
935         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
936         (WTR::AccessibilityTextMarker::platformTextMarker):
937         (WTR::AccessibilityTextMarker::wrapperClass):
938         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
939         (WTR::AccessibilityTextMarker::isEqual):
940         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
941         (WTR::AccessibilityTextMarkerRange::create):
942         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
943         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
944         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
945         (WTR::AccessibilityTextMarkerRange::wrapperClass):
946         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
947         (WTR::AccessibilityTextMarkerRange::isEqual):
948         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
949         (WTR::AccessibilityUIElement::create):
950         (WTR::AccessibilityUIElement::wrapperClass):
951         (WTR::AccessibilityUIElement::isValid):
952         (WTR::AccessibilityUIElement::AccessibilityUIElement):
953         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
954         (WTR::AccessibilityUIElement::isEqual):
955         (WTR::AccessibilityUIElement::elementAtPoint):
956         (WTR::AccessibilityUIElement::childAtIndex):
957         (WTR::AccessibilityUIElement::indexOfChild):
958         (WTR::AccessibilityUIElement::childrenCount):
959         (WTR::AccessibilityUIElement::titleUIElement):
960         (WTR::AccessibilityUIElement::parentElement):
961         (WTR::AccessibilityUIElement::takeFocus):
962         (WTR::AccessibilityUIElement::takeSelection):
963         (WTR::AccessibilityUIElement::addSelection):
964         (WTR::AccessibilityUIElement::removeSelection):
965         (WTR::AccessibilityUIElement::allAttributes):
966         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
967         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
968         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
969         (WTR::AccessibilityUIElement::attributesOfChildren):
970         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
971         (WTR::AccessibilityUIElement::increment):
972         (WTR::AccessibilityUIElement::decrement):
973         (WTR::AccessibilityUIElement::showMenu):
974         (WTR::AccessibilityUIElement::press):
975         (WTR::AccessibilityUIElement::stringAttributeValue):
976         (WTR::AccessibilityUIElement::uiElementAttributeValue):
977         (WTR::AccessibilityUIElement::numberAttributeValue):
978         (WTR::AccessibilityUIElement::boolAttributeValue):
979         (WTR::AccessibilityUIElement::isAttributeSupported):
980         (WTR::AccessibilityUIElement::isAttributeSettable):
981         (WTR::AccessibilityUIElement::isActionSupported):
982         (WTR::AccessibilityUIElement::role):
983         (WTR::AccessibilityUIElement::subrole):
984         (WTR::AccessibilityUIElement::roleDescription):
985         (WTR::AccessibilityUIElement::title):
986         (WTR::AccessibilityUIElement::description):
987         (WTR::AccessibilityUIElement::language):
988         (WTR::AccessibilityUIElement::stringValue):
989         (WTR::AccessibilityUIElement::accessibilityValue):
990         (WTR::AccessibilityUIElement::helpText):
991         (WTR::AccessibilityUIElement::orientation):
992         (WTR::AccessibilityUIElement::x):
993         (WTR::AccessibilityUIElement::y):
994         (WTR::AccessibilityUIElement::width):
995         (WTR::AccessibilityUIElement::height):
996         (WTR::AccessibilityUIElement::intValue):
997         (WTR::AccessibilityUIElement::minValue):
998         (WTR::AccessibilityUIElement::maxValue):
999         (WTR::AccessibilityUIElement::valueDescription):
1000         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1001         (WTR::AccessibilityUIElement::selectedTextRange):
1002         (WTR::AccessibilityUIElement::isEnabled):
1003         (WTR::AccessibilityUIElement::isRequired):
1004         (WTR::AccessibilityUIElement::isFocused):
1005         (WTR::AccessibilityUIElement::isFocusable):
1006         (WTR::AccessibilityUIElement::isSelected):
1007         (WTR::AccessibilityUIElement::isSelectable):
1008         (WTR::AccessibilityUIElement::isMultiSelectable):
1009         (WTR::AccessibilityUIElement::setSelectedChild):
1010         (WTR::AccessibilityUIElement::selectedChildrenCount):
1011         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1012         (WTR::AccessibilityUIElement::isExpanded):
1013         (WTR::AccessibilityUIElement::isChecked):
1014         (WTR::AccessibilityUIElement::isVisible):
1015         (WTR::AccessibilityUIElement::isOffScreen):
1016         (WTR::AccessibilityUIElement::isCollapsed):
1017         (WTR::AccessibilityUIElement::isIgnored):
1018         (WTR::AccessibilityUIElement::hasPopup):
1019         (WTR::AccessibilityUIElement::hierarchicalLevel):
1020         (WTR::AccessibilityUIElement::clickPointX):
1021         (WTR::AccessibilityUIElement::clickPointY):
1022         (WTR::AccessibilityUIElement::documentEncoding):
1023         (WTR::AccessibilityUIElement::documentURI):
1024         (WTR::AccessibilityUIElement::url):
1025         (WTR::AccessibilityUIElement::speak):
1026         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1027         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1028         (WTR::AccessibilityUIElement::attributesOfColumns):
1029         (WTR::AccessibilityUIElement::attributesOfRows):
1030         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1031         (WTR::AccessibilityUIElement::attributesOfHeader):
1032         (WTR::AccessibilityUIElement::indexInTable):
1033         (WTR::AccessibilityUIElement::rowIndexRange):
1034         (WTR::AccessibilityUIElement::columnIndexRange):
1035         (WTR::AccessibilityUIElement::rowCount):
1036         (WTR::AccessibilityUIElement::columnCount):
1037         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1038         (WTR::AccessibilityUIElement::disclosedByRow):
1039         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1040         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1041         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1042         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1043         (WTR::AccessibilityUIElement::ariaDropEffects):
1044         (WTR::AccessibilityUIElement::lineForIndex):
1045         (WTR::AccessibilityUIElement::rangeForLine):
1046         (WTR::AccessibilityUIElement::boundsForRange):
1047         (WTR::AccessibilityUIElement::setSelectedTextRange):
1048         (WTR::AccessibilityUIElement::stringForRange):
1049         (WTR::AccessibilityUIElement::attributedStringForRange):
1050         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1051         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1052         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1053         (WTR::AccessibilityUIElement::horizontalScrollbar):
1054         (WTR::AccessibilityUIElement::verticalScrollbar):
1055         (WTR::AccessibilityUIElement::addNotificationListener):
1056         (WTR::AccessibilityUIElement::removeNotificationListener):
1057         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1058         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1059         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1060         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1061         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1062         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1063         (WTR::AccessibilityUIElement::textMarkerForPoint):
1064         (WTR::AccessibilityUIElement::previousTextMarker):
1065         (WTR::AccessibilityUIElement::nextTextMarker):
1066         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1067         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
1068         (WTR::AccessibilityUIElement::platformUIElement):
1069         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
1070         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
1071         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
1072         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
1073         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1074         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1075         (WTR::InjectedBundle::beginTesting):
1076         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1077         (WTR::InjectedBundle::accessibilityController):
1078         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1079         (WTR::InjectedBundlePage::didClearWindowForFrame):
1080         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1081         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
1082         (WTR::LayoutTestController::platformName):
1083         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
1084         (WTR::AccessibilityTextMarker::isEqual):
1085         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
1086         (WTR::AccessibilityTextMarkerRange::isEqual):
1087         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
1088         (+[NSString stringWithJSStringRef:]):
1089         (-[NSString createJSStringRef]):
1090         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
1091         (-[AccessibilityNotificationHandler dealloc]):
1092         (-[AccessibilityNotificationHandler _notificationReceived:]):
1093         (-[AccessibilityNotificationHandler setCallback:]):
1094         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1095         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1096         (WTR::AccessibilityUIElement::isEqual):
1097         (WTR::descriptionOfValue):
1098         (WTR::attributesOfElement):
1099         (WTR::concatenateAttributeAndValue):
1100         (WTR::convertNSArrayToVector):
1101         (WTR::descriptionOfElements):
1102         (WTR::AccessibilityUIElement::getLinkedUIElements):
1103         (WTR::AccessibilityUIElement::getDocumentLinks):
1104         (WTR::AccessibilityUIElement::getChildren):
1105         (WTR::AccessibilityUIElement::getChildrenWithRange):
1106         (WTR::AccessibilityUIElement::childrenCount):
1107         (WTR::AccessibilityUIElement::elementAtPoint):
1108         (WTR::AccessibilityUIElement::indexOfChild):
1109         (WTR::AccessibilityUIElement::childAtIndex):
1110         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1111         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1112         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1113         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1114         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1115         (WTR::AccessibilityUIElement::selectedChildrenCount):
1116         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1117         (WTR::AccessibilityUIElement::titleUIElement):
1118         (WTR::AccessibilityUIElement::parentElement):
1119         (WTR::AccessibilityUIElement::disclosedByRow):
1120         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1121         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1122         (WTR::AccessibilityUIElement::attributesOfChildren):
1123         (WTR::AccessibilityUIElement::allAttributes):
1124         (WTR::AccessibilityUIElement::stringAttributeValue):
1125         (WTR::AccessibilityUIElement::numberAttributeValue):
1126         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1127         (WTR::AccessibilityUIElement::boolAttributeValue):
1128         (WTR::AccessibilityUIElement::isAttributeSettable):
1129         (WTR::AccessibilityUIElement::isAttributeSupported):
1130         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1131         (WTR::AccessibilityUIElement::role):
1132         (WTR::AccessibilityUIElement::subrole):
1133         (WTR::AccessibilityUIElement::roleDescription):
1134         (WTR::AccessibilityUIElement::title):
1135         (WTR::AccessibilityUIElement::description):
1136         (WTR::AccessibilityUIElement::orientation):
1137         (WTR::AccessibilityUIElement::stringValue):
1138         (WTR::AccessibilityUIElement::language):
1139         (WTR::AccessibilityUIElement::helpText):
1140         (WTR::AccessibilityUIElement::x):
1141         (WTR::AccessibilityUIElement::y):
1142         (WTR::AccessibilityUIElement::width):
1143         (WTR::AccessibilityUIElement::height):
1144         (WTR::AccessibilityUIElement::clickPointX):
1145         (WTR::AccessibilityUIElement::clickPointY):
1146         (WTR::AccessibilityUIElement::intValue):
1147         (WTR::AccessibilityUIElement::minValue):
1148         (WTR::AccessibilityUIElement::maxValue):
1149         (WTR::AccessibilityUIElement::valueDescription):
1150         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1151         (WTR::AccessibilityUIElement::isActionSupported):
1152         (WTR::AccessibilityUIElement::isEnabled):
1153         (WTR::AccessibilityUIElement::isRequired):
1154         (WTR::AccessibilityUIElement::isFocused):
1155         (WTR::AccessibilityUIElement::isSelected):
1156         (WTR::AccessibilityUIElement::isExpanded):
1157         (WTR::AccessibilityUIElement::isChecked):
1158         (WTR::AccessibilityUIElement::hierarchicalLevel):
1159         (WTR::AccessibilityUIElement::speak):
1160         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1161         (WTR::AccessibilityUIElement::ariaDropEffects):
1162         (WTR::AccessibilityUIElement::lineForIndex):
1163         (WTR::AccessibilityUIElement::rangeForLine):
1164         (WTR::AccessibilityUIElement::boundsForRange):
1165         (WTR::AccessibilityUIElement::stringForRange):
1166         (WTR::AccessibilityUIElement::attributedStringForRange):
1167         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1168         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1169         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1170         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1171         (WTR::AccessibilityUIElement::attributesOfColumns):
1172         (WTR::AccessibilityUIElement::attributesOfRows):
1173         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1174         (WTR::AccessibilityUIElement::attributesOfHeader):
1175         (WTR::AccessibilityUIElement::rowCount):
1176         (WTR::AccessibilityUIElement::columnCount):
1177         (WTR::AccessibilityUIElement::indexInTable):
1178         (WTR::AccessibilityUIElement::rowIndexRange):
1179         (WTR::AccessibilityUIElement::columnIndexRange):
1180         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1181         (WTR::AccessibilityUIElement::horizontalScrollbar):
1182         (WTR::AccessibilityUIElement::verticalScrollbar):
1183         (WTR::AccessibilityUIElement::selectedTextRange):
1184         (WTR::AccessibilityUIElement::setSelectedTextRange):
1185         (WTR::AccessibilityUIElement::increment):
1186         (WTR::AccessibilityUIElement::decrement):
1187         (WTR::AccessibilityUIElement::showMenu):
1188         (WTR::AccessibilityUIElement::press):
1189         (WTR::AccessibilityUIElement::setSelectedChild):
1190         (WTR::AccessibilityUIElement::accessibilityValue):
1191         (WTR::AccessibilityUIElement::documentEncoding):
1192         (WTR::AccessibilityUIElement::documentURI):
1193         (WTR::AccessibilityUIElement::url):
1194         (WTR::AccessibilityUIElement::addNotificationListener):
1195         (WTR::AccessibilityUIElement::removeNotificationListener):
1196         (WTR::AccessibilityUIElement::isFocusable):
1197         (WTR::AccessibilityUIElement::isSelectable):
1198         (WTR::AccessibilityUIElement::isMultiSelectable):
1199         (WTR::AccessibilityUIElement::isVisible):
1200         (WTR::AccessibilityUIElement::isOffScreen):
1201         (WTR::AccessibilityUIElement::isCollapsed):
1202         (WTR::AccessibilityUIElement::isIgnored):
1203         (WTR::AccessibilityUIElement::hasPopup):
1204         (WTR::AccessibilityUIElement::takeFocus):
1205         (WTR::AccessibilityUIElement::takeSelection):
1206         (WTR::AccessibilityUIElement::addSelection):
1207         (WTR::AccessibilityUIElement::removeSelection):
1208         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1209         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1210         (WTR::AccessibilityUIElement::previousTextMarker):
1211         (WTR::AccessibilityUIElement::nextTextMarker):
1212         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1213         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1214         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1215         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1216         (WTR::AccessibilityUIElement::textMarkerForPoint):
1217         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1218         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
1219         (WTR::LayoutTestController::platformName):
1220         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1221         (WTR::LayoutTestController::platformName):
1222         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1223         (WTR::LayoutTestController::platformName):
1224         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1225         * WebKitTestRunner/win/InjectedBundle.vcproj:
1226
1227 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1228
1229         [Qt] Fix use of config.tests
1230
1231         We were checking @buildArgs to determine if the optional argument was
1232         passed or not, but this is not the right way to do that in Perl. The
1233         right way is to not use a prototype for the function, and to pass
1234         the list as a reference (to avoid list expansion). That way we can
1235         check the number of arguments, and choose the right code path based
1236         on that.
1237
1238         We were also missing a default-value of 0 for any feature that's not
1239         set in features.prf.
1240
1241         Reviewed by Kenneth Rohde Christiansen.
1242
1243         * Scripts/build-webkit:
1244         * Scripts/webkitdirs.pm:
1245         (qtFeatureDefaults):
1246         (buildQMakeProject):
1247
1248 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1249
1250         [Qt] Prospective fix for broken plugin tests
1251
1252         Don't hide symbols for the NPAPI test plugin
1253
1254         Rubber-stamped by Andreas Kling.
1255
1256         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1257
1258 2011-11-16  Adam Roben  <aroben@apple.com>
1259
1260         Move filenames/line numbers off to the right edge in Leaks Viewer
1261
1262         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
1263         because filenames/line numbers are right next to function names
1264
1265         Reviewed by Andreas Kling.
1266
1267         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
1268         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
1269         function name. Use the filename as the profile node's URL (we don't have enough info to
1270         compute a real URL currently) and the line number as the profile node's line number so the
1271         Inspector code will put them on the right side of the callstack graph.
1272
1273         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1274         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
1275         passed here, just filenames.
1276
1277         (WebInspector.linkifyURLAsNode):
1278         (WebInspector.linkifyResourceAsNode):
1279         Copied and slightly modified from inspector.js.
1280
1281 2011-11-16  Adam Roben  <aroben@apple.com>
1282
1283         Make Leaks Viewer load builds from the new Lion Leaks bot
1284
1285         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
1286
1287         Reviewed by Andreas Kling.
1288
1289         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1290         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
1291         SnowLeopard one.
1292
1293 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
1294
1295         [EFL] Clean up the offline apps-related functions in ewk_settings.
1296         https://bugs.webkit.org/show_bug.cgi?id=72132
1297
1298         Reviewed by Kenneth Rohde Christiansen.
1299
1300         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
1301         prefixes for code that is related only to the HTML5 app cache
1302         features.
1303
1304         Use `ewk_settings_application_cache' and
1305         `ewk_view_setting_application_cache' instead.
1306
1307         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1308         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1309
1310 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1311
1312         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1313
1314         Reviewed by Tor Arne Vestbø.
1315
1316         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1317         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
1318         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
1319         removes the .so.0.0.0 and just produces .so.
1320
1321 2011-11-16  Peter Beverloo  <peter@chromium.org>
1322
1323         Explicitly include unistd.h in TestNetscapePlugIn
1324         https://bugs.webkit.org/show_bug.cgi?id=72385
1325
1326         This is needed for the sleep() call in the indicateTestFailure method,
1327         which seems to be implicitly available for other platforms. This is not
1328         the case on Android.
1329
1330         Reviewed by Steve Block.
1331
1332         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1333
1334 2011-11-16  Peter Beverloo  <peter@chromium.org>
1335
1336         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
1337         https://bugs.webkit.org/show_bug.cgi?id=72384
1338
1339         Update to Android NDK r7, which was released last Friday. This adds
1340         support for RTTI and the -mimplicit-it gcc flag, which are required to
1341         respectively build ICU and Skia.
1342
1343         Reviewed by Steve Block.
1344
1345         * Scripts/update-webkit-chromium:
1346         * Scripts/webkitdirs.pm:
1347         (buildChromiumMakefile):
1348
1349 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
1350
1351         Unreviewed, rolling out r100266.
1352         http://trac.webkit.org/changeset/100266
1353
1354         Broke WTR.
1355
1356         * qmake/mkspecs/features/default_post.prf:
1357
1358 2011-11-16  Eric Seidel  <eric@webkit.org>
1359
1360         check-webkit-style broken by r99773: "Could not determine the port"
1361         https://bugs.webkit.org/show_bug.cgi?id=72275
1362
1363         Reviewed by Adam Barth.
1364
1365         I will continue engaging hacks, until windows improves.
1366
1367         * Scripts/webkitpy/common/host.py:
1368          - Host uses self.executive instead of self._executive like Port does.
1369          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
1370
1371 2011-11-16  Eric Seidel  <eric@webkit.org>
1372
1373         check-webkit-style broken by r99773: "Could not determine the port"
1374         https://bugs.webkit.org/show_bug.cgi?id=72275
1375
1376         Reviewed by Adam Barth.
1377
1378         Engage windows hacks harder.
1379
1380         This is a speculative fix for ChromiumWin.  We're now
1381         creating an SCM object much earlier, so we need to
1382         engage our "awesome" windows hacks earlier.
1383
1384         * Scripts/webkitpy/common/host.py:
1385         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1386
1387 2011-11-15  Darin Adler  <darin@apple.com>
1388
1389         DRT's uiElementAttributeValueCallback function is leaky
1390         https://bugs.webkit.org/show_bug.cgi?id=72453
1391
1392         Reviewed by Dan Bernstein.
1393
1394         * DumpRenderTree/AccessibilityUIElement.cpp:
1395         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
1396
1397 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1398
1399         Implement edit-distance based reviewer recognition algorithm
1400         https://bugs.webkit.org/show_bug.cgi?id=72351
1401
1402         Reviewed by Eric Seidel.
1403
1404         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
1405         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
1406         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
1407         "build fix" to a reviewer's name (e.g. with with edit distance 9).
1408
1409         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
1410         the edit distance is implemented in edit_distance.py.
1411
1412         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
1413         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
1414
1415         * Scripts/webkitpy/common/checkout/changelog.py:
1416         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1417         * Scripts/webkitpy/common/config/committers.py:
1418         * Scripts/webkitpy/common/config/committers_unittest.py:
1419         * Scripts/webkitpy/common/editdistance.py: Added.
1420         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
1421         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1422         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
1423
1424 2011-11-15  Tony Chang  <tony@chromium.org>
1425
1426         Skip a failing webkitpy test on cygwin.
1427
1428         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1429
1430 2011-11-15  Sam Weinig  <sam@webkit.org>
1431
1432         TestWebKitAPI should not put its resources in the root products directory
1433         https://bugs.webkit.org/show_bug.cgi?id=72446
1434
1435         Reviewed by Anders Carlsson.
1436
1437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1438         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
1439         directory.
1440
1441         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1442         (TEST_F):
1443         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1444         (TestWebKitAPI::TEST):
1445         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1446         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
1447         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1448         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
1449         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1450         (TestWebKitAPI::Util::createURLForResource):
1451         Update calls to retrieve files from the bundle to look in the newly
1452         created subdirectory.
1453
1454 2011-11-15  Tony Chang  <tony@chromium.org>
1455
1456         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
1457
1458         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1459
1460 2011-11-15  Tony Chang  <tony@chromium.org>
1461
1462         Unreviewed, fix test-webkitpy tests.  Move the check for image results
1463         earlier.
1464
1465         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1466         * Scripts/webkitpy/layout_tests/port/webkit.py:
1467
1468 2011-11-15  James Robinson  <jamesr@chromium.org>
1469
1470         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
1471         https://bugs.webkit.org/show_bug.cgi?id=72444
1472
1473         Reviewed by Adam Barth.
1474
1475         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1476
1477 2011-11-15  Tony Chang  <tony@chromium.org>
1478
1479         Unreviewed, better fix for ref tests failures on SL Intel bot.
1480         Revert the previous change and return None if pixel results from
1481         either the test page or the expected page is missing.
1482
1483         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1484         * Scripts/webkitpy/layout_tests/port/webkit.py:
1485
1486 2011-11-15  James Robinson  <jamesr@chromium.org>
1487
1488         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
1489         https://bugs.webkit.org/show_bug.cgi?id=72402
1490
1491         Reviewed by Dirk Pranke.
1492
1493         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
1494         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
1495         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
1496         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
1497         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
1498         compositing enabled.
1499
1500         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
1501         patch should not impact any tests.
1502
1503         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1504         (main):
1505         * DumpRenderTree/chromium/TestShell.cpp:
1506         (TestShell::TestShell):
1507         (TestShell::resetWebSettings):
1508         * DumpRenderTree/chromium/TestShell.h:
1509         (TestShell::setAcceleratedCompositingForVideoEnabled):
1510         * DumpRenderTree/chromium/WebPreferences.cpp:
1511         (WebPreferences::reset):
1512         (WebPreferences::applyTo):
1513         * DumpRenderTree/chromium/WebPreferences.h:
1514         * Scripts/webkitpy/layout_tests/port/chromium.py:
1515         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1516         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1517
1518 2011-11-15  Tony Chang  <tony@chromium.org>
1519
1520         Unreviewed, try to fix ref tests failures on SL Intel bot.
1521         It looks like ImageDiff isn't returning an image diff.
1522
1523         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1524
1525 2011-11-15  Tony Chang  <tony@chromium.org>
1526
1527         Unreviewed fix of ref-tests on GTK+.
1528         If a driver is never started, _xvfb_process is never set.
1529
1530         * Scripts/webkitpy/layout_tests/port/gtk.py:
1531
1532 2011-11-14  Tony Chang  <tony@chromium.org>
1533
1534         [NRWT] Reftests should run even when pixel tests are disabled.
1535         https://bugs.webkit.org/show_bug.cgi?id=60605
1536
1537         Reviewed by Dirk Pranke.
1538
1539         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
1540             Also add an assert to make sure we get image hashes back when running ref tests.
1541         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
1542         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1543         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
1544         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
1545             of starting a pixel driver if needed.  It handles the logic of sending the test
1546             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
1547         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1548         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
1549         * Scripts/webkitpy/layout_tests/port/webkit.py:
1550         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
1551         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
1552
1553 2011-11-15  David Kilzer  <ddkilzer@apple.com>
1554
1555         Don't use File::Slurp for run-leaks unit tests
1556         <http://webkit.org/b/72356>
1557
1558         Reviewed by Daniel Bates.
1559
1560         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
1561         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1562         Extracted common package logic into RunLeaks.pm.  Fixed call to
1563         RunLeaks::parseLeaksOutput().
1564         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
1565         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
1566
1567 2011-11-15  Peter Kasting  <pkasting@google.com>
1568
1569         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
1570         https://bugs.webkit.org/show_bug.cgi?id=72349
1571
1572         Reviewed by Adam Roben.
1573
1574         * Scripts/VCSUtils.pm:
1575         (isSVNDirectory):
1576
1577 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1578
1579         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1580
1581         Reviewed by Tor Arne Vestbø.
1582
1583         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1584         magic here where we handle all TEMPLATE = lib .pro files.
1585
1586 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1587
1588         [Qt] Unreviewed prospective --minimal build fix.
1589
1590         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
1591         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
1592
1593 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1594
1595         [Qt] Unreviewed --minimal build fix.
1596
1597         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
1598         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
1599         to make moc's preprocessor abort.
1600
1601 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
1602
1603         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
1604         https://bugs.webkit.org/show_bug.cgi?id=72156
1605
1606         Reviewed by Daniel Bates.
1607
1608         Similar to --makearg and --qmakearg, --cmakearg lets one pass
1609         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
1610
1611         * Scripts/build-webkit:
1612         * Scripts/webkitdirs.pm:
1613         (generateBuildSystemFromCMakeProject):
1614
1615 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1616
1617         Improve ChangeLogEntry's reviewer parsing algorithm part 2
1618         https://bugs.webkit.org/show_bug.cgi?id=72340
1619
1620         Reviewed by Eric Seidel.
1621
1622         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
1623         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
1624
1625         * Scripts/webkitpy/common/checkout/changelog.py:
1626         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1627
1628 2011-11-14  Eric Seidel  <eric@webkit.org>
1629
1630         check-webkit-style broken by r99773: "Could not determine the port"
1631         https://bugs.webkit.org/show_bug.cgi?id=72275
1632
1633         Reviewed by Adam Barth.
1634
1635         The TestExpectationsChecker was using a generic try/except block
1636         which caught all exceptions, so we didn't notice that failing
1637         to pass a Host to PortFactory was causing an exception in port instantiation.
1638         I've factored out the "lookup the port" logic into a separate function
1639         which I've now unittested.  This should fix the bug and prevent
1640         others like it from occuring the the future.
1641
1642         * Scripts/webkitpy/style/checkers/test_expectations.py:
1643         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1644
1645 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1646
1647         Add --css-grid-layout to build-webkit and the build systems
1648         https://bugs.webkit.org/show_bug.cgi?id=72320
1649
1650         Reviewed by Ojan Vafai.
1651
1652         * Scripts/build-webkit:
1653         Added the option.
1654
1655 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1656
1657         Unreviewed, rolling out r100192.
1658         http://trac.webkit.org/changeset/100192
1659         https://bugs.webkit.org/show_bug.cgi?id=72328
1660
1661         Caused infinite tests to fail (Requested by abarth on
1662         #webkit).
1663
1664         * Scripts/webkitpy/layout_tests/port/base.py:
1665         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1666
1667 2011-11-14  Tony Chang  <tony@chromium.org>
1668
1669         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
1670         https://bugs.webkit.org/show_bug.cgi?id=72196
1671
1672         Reviewed by Ojan Vafai.
1673
1674         * Scripts/build-webkit:
1675
1676 2011-11-14  John Yani  <vanuan@gmail.com>
1677
1678         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
1679         Override LOCALE to en_US.
1680
1681         Reviewed by Eric Seidel.
1682
1683         * Scripts/webkitpy/layout_tests/port/base.py:
1684
1685 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1686
1687         [Chromium] build-webkit silently drops the features flags
1688         https://bugs.webkit.org/show_bug.cgi?id=72293
1689
1690         Reviewed by Tony Chang.
1691
1692         Chromium still ignores @features but now we give a warning!
1693
1694         * Scripts/build-webkit: Check if one of the features is different
1695         from the default and print a warning in this case.
1696
1697 2011-11-14  David Kilzer  <ddkilzer@apple.com>
1698
1699         run-leaks does not work on Lion?
1700         <http://webkit.org/b/71059>
1701         <rdar://problem/10428527>
1702
1703         Reviewed by Adam Roben.
1704
1705         The output of leaks(1) changed again in Lion to move the
1706         "leaks Report Version: 2.0" line from the first line of the
1707         output to just above the "Process " lines that run-leaks is
1708         interested in parsing.  This required using a more generic
1709         algorithm to find the start of the "Process " lines.
1710
1711         * Scripts/run-leaks:
1712         (parseLeaksOutput): Make the code to skip headers more generic.
1713         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
1714         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
1715         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
1716
1717 2011-11-14  Lei Zhang  <thestig@chromium.org>
1718
1719         Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
1720         https://bugs.webkit.org/show_bug.cgi?id=72088
1721
1722         Reviewed by Tony Chang.
1723
1724         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1725
1726 2011-11-14  Andrew Scherkus  <scherkus@chromium.org>
1727
1728         [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
1729         https://bugs.webkit.org/show_bug.cgi?id=72147
1730
1731         Reviewed by Adam Barth.
1732
1733         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1734
1735 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1736
1737         [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
1738
1739         Reviewed by Simon Hausmann.
1740
1741         * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
1742
1743 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
1744
1745         [Qt] Disable plugins on X11 for WK2
1746
1747         Reviewed by Kenneth Rohde Christiansen.
1748
1749         Currently plugins are in-process and they crash in the likely case of
1750         a plugin installation that uses Qt 4, which beautifully clashes with the
1751         Qt 5 based QtWebProcess.
1752
1753         * qmake/mkspecs/features/features.prf:
1754
1755 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1756
1757         [Qt] Add support for config tests for Qt 5
1758
1759         This allows us to build and run configure-tests at build
1760         time to determine if a given platform feature is available.
1761
1762         Reviewed by Simon Hausmann.
1763
1764         * Scripts/build-webkit:
1765         * Scripts/webkitdirs.pm:
1766         (qtFeatureDefaults):
1767         * qmake/configure.pro: Added.
1768         * qmake/mkspecs/features/features.prf:
1769         * qmake/sync.profile: Added.
1770
1771 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
1772
1773         [Qt] Remove the QStyle dependency in Qt's mobile theme
1774         https://bugs.webkit.org/show_bug.cgi?id=67773
1775
1776         This refactoring splits up RenderThemeQt with two
1777         subclasses, a QStyle-backed one, and a Mobile version
1778         that uses the old mobile theme for now.
1779
1780         QStyle availability is detected at compile time, and
1781         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
1782         environment variable.
1783
1784         Reviewed by Simon Hausmann.
1785
1786         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1787         (WTR::activateFonts):
1788         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
1789         based on availability of QtWidgets.
1790         * qmake/mkspecs/features/webcore.prf: cleanup.
1791
1792 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
1793
1794         Unreviewed, rolling out r100116.
1795         http://trac.webkit.org/changeset/100116
1796
1797         r100104 was rolled out, so no longer needed
1798
1799         * Scripts/run-bindings-tests:
1800
1801 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
1802
1803         Unreviewed, rolling out r100104.
1804         http://trac.webkit.org/changeset/100104
1805         https://bugs.webkit.org/show_bug.cgi?id=72247
1806
1807         broke windows builds
1808
1809         * Scripts/check-webkit-style:
1810         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1811         * Scripts/webkitpy/common/checkout/deps.py:
1812         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1813         * Scripts/webkitpy/common/checkout/scm/detection.py:
1814         * Scripts/webkitpy/common/checkout/scm/git.py:
1815         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1816         * Scripts/webkitpy/common/checkout/scm/svn.py:
1817         * Scripts/webkitpy/common/host.py:
1818         * Scripts/webkitpy/common/host_mock.py:
1819         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1820         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1821         * Scripts/webkitpy/layout_tests/port/base.py:
1822         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1823         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1824         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1825         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1826
1827 2011-11-14  Philippe Normand  <pnormand@igalia.com>
1828
1829         Unreviewed, build fix after r100104. run-binding-tests broke.
1830
1831         * Scripts/run-bindings-tests: Explicitely use scm.detection.
1832
1833 2011-11-13  Eric Seidel  <eric@webkit.org>
1834
1835         Add SCMDetector object to make scm detection mockable
1836         https://bugs.webkit.org/show_bug.cgi?id=72247
1837
1838         Reviewed by Adam Barth.
1839
1840         I think SCM detection may eventually be rolled into Checkout,
1841         but this patch at least makes it possible to mock code-paths
1842         which rely on scm detection.
1843         In the process of replacing callers of these free-functions
1844         I found that one of the functions was no longer used,
1845         and that one of the callers could instead just use the SCM
1846         object it already had access to through port.host.scm().
1847         I also discovered that I was not calling Host._initialize_scm()
1848         and thus host.scm() was always returning None!
1849
1850         * Scripts/check-webkit-style:
1851         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1852         * Scripts/webkitpy/common/checkout/deps.py:
1853         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1854         * Scripts/webkitpy/common/checkout/scm/detection.py:
1855         * Scripts/webkitpy/common/checkout/scm/git.py:
1856         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1857         * Scripts/webkitpy/common/checkout/scm/svn.py:
1858         * Scripts/webkitpy/common/host.py:
1859         * Scripts/webkitpy/common/host_mock.py:
1860         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1861         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1862         * Scripts/webkitpy/layout_tests/port/base.py:
1863         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1864         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1865         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1866         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1867
1868 2011-11-13  Gavin Peters  <gavinp@chromium.org>
1869
1870         command line control of webcore log channels in chromium DumpRenderTree
1871         https://bugs.webkit.org/show_bug.cgi?id=72126
1872         
1873         The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
1874         what chromium takes.
1875
1876         Reviewed by Kent Tamura.
1877
1878         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1879         (main):
1880
1881 2011-11-12  Ariya Hidayat  <ariya@sencha.com>
1882
1883         [Qt] Fix minor config typo in the build tool documentation
1884         https://bugs.webkit.org/show_bug.cgi?id=72194
1885
1886         Reviewed by Andreas Kling.
1887
1888         * qmake/README:
1889
1890 2011-11-11  Stephen Chenney  <schenney@chromium.org>
1891
1892         [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
1893         https://bugs.webkit.org/show_bug.cgi?id=49257
1894
1895         Adds the remaining missing layout test functionality for printing.
1896
1897         Reviewed by Darin Fisher.
1898
1899         * DumpRenderTree/chromium/LayoutTestController.cpp:
1900         (LayoutTestController::LayoutTestController): Add bindings for new JS methods
1901         (parsePageNumber): Method to parse JS arguments for a page number
1902         (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
1903         (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
1904         (LayoutTestController::isPageBoxVisible): get the visibility status for printing
1905         (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
1906         * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
1907
1908 2011-11-11  Darin Adler  <darin@apple.com>
1909
1910         Remove all releaseRef implementations except for RetainPtr
1911         https://bugs.webkit.org/show_bug.cgi?id=71423
1912
1913         Reviewed by Julien Chaffraix.
1914
1915         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1916         (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
1917
1918 2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>
1919
1920         Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
1921         https://bugs.webkit.org/show_bug.cgi?id=72090
1922
1923         Reviewed by Eric Seidel.
1924
1925         Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
1926         ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
1927
1928         yay! r100002.
1929
1930         * Scripts/webkitpy/common/checkout/changelog.py:
1931         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1932
1933 2011-11-11  Tony Chang  <tony@chromium.org>
1934
1935         Remove --force from gclient sync.  The bots seem to have made it past
1936         the update step.
1937
1938         * Scripts/update-webkit:
1939
1940 2011-11-11  Tony Chang  <tony@chromium.org>
1941
1942         Add --force to gclient sync. Once the cq bots cycle, we can remove
1943         this since it slows down the normal sync.
1944
1945         * Scripts/update-webkit:
1946
1947 2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>
1948
1949         When --force is used, also use --reset
1950         https://bugs.webkit.org/show_bug.cgi?id=72129
1951
1952         Reviewed by Dimitri Glazkov.
1953
1954         * Scripts/update-webkit-chromium:
1955
1956 2011-11-11  Tony Chang  <tony@chromium.org>
1957
1958         allow two chromium drivers to run at the same time in NRWT
1959         https://bugs.webkit.org/show_bug.cgi?id=72067
1960
1961         Reviewed by Dirk Pranke.
1962
1963         * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
1964             posix prevents the subprocesses from sharing the same fd for stdin.
1965             Sharing the same fd prevents us from closing the files unless all references
1966             to the fd are closed.
1967         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
1968             to adding a test for this, speed up a test (from 3sec to 0) by fixing
1969             the timeout override. It looks like it regressed in r95875.
1970
1971 2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
1972
1973         Unreviewed, rolling out r99964.
1974         http://trac.webkit.org/changeset/99964
1975         https://bugs.webkit.org/show_bug.cgi?id=72124
1976
1977         Broke too many Qt tests (Requested by tronical_ on #webkit).
1978
1979         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1980         (WTR::activateFonts):
1981         * qmake/mkspecs/features/features.prf:
1982         * qmake/mkspecs/features/webcore.prf:
1983
1984 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
1985
1986         [Qt] Remove the QStyle dependency in Qt's mobile theme
1987         https://bugs.webkit.org/show_bug.cgi?id=67773
1988
1989         This refactoring splits up RenderThemeQt with two
1990         subclasses, a QStyle-backed one, and a Mobile version
1991         that uses the old mobile theme for now.
1992
1993         QStyle availability is detected at compile time, and
1994         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
1995         environment variable.
1996
1997         Reviewed by Simon Hausmann.
1998
1999         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2000         (WTR::activateFonts):
2001         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
2002         based on availability of QtWidgets.
2003         * qmake/mkspecs/features/webcore.prf: cleanup.
2004
2005 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2006
2007         [Qt] Add missing include to PlatformWebViewQt
2008
2009         Reviewed by Simon Hausmann.
2010
2011         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2012
2013 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2014
2015         [Qt] Fix incremental builds on Windows after buildsystem refactor
2016
2017         The qmake rules to ensure that we run make on the derived sources
2018         before running qmake on the target were inside a unix-scope, which
2019         resulted in flakey builds on Windows.
2020
2021         We now generate a rule on all platforms that ensures that "make qmake"
2022         will always run make on the derived sources. In addition, on platforms
2023         that have GNU make (where "make incremental" does not run "make qmake",
2024         but only "make"), we add a similar rule that ensures that any time the
2025         target makefile is regenerated we first run qmake and make on the derived
2026         sources. This rule relies on GNU make's order-only-prerequisites to
2027         not trigger a qmake-run of the target every time we run make.
2028
2029         https://bugs.webkit.org/show_bug.cgi?id=71778
2030
2031         Reviewed by Simon Hausmann.
2032
2033         * qmake/mkspecs/features/functions.prf:
2034
2035 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2036
2037         [Qt][WK2] Remove QWebNavigationController
2038         https://bugs.webkit.org/show_bug.cgi?id=72113
2039
2040         Reviewed by Andreas Kling.
2041
2042         Adapt to the move of the QWebNavigationController functions/properties to
2043         QQuickWebView.
2044
2045         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2046         * MiniBrowser/qt/qml/BrowserWindow.qml:
2047
2048 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2049
2050         [Qt] Build system tweak
2051
2052         Reviewed by Tor Arne Vestbø.
2053
2054         Be a good qmake citizen, return true from our linkStaticLibrary
2055         "test" function.
2056
2057         * qmake/mkspecs/features/functions.prf:
2058
2059 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2060
2061         [Qt] Add support for QT += webkit-private
2062
2063         Reviewed by Tor Arne Vestbø.
2064
2065         * qmake/qt_webkit.pri: Declare private headers.
2066
2067 2011-11-11  Philippe Normand  <pnormand@igalia.com>
2068
2069         Unreviewed, build fix attempt after r99907. Since that revision
2070         GTK layout tests were not running at all...
2071
2072         * Scripts/webkitpy/layout_tests/port/gtk.py:
2073
2074 2011-11-10  Andrew Scherkus  <scherkus@chromium.org>
2075
2076         [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
2077         https://bugs.webkit.org/show_bug.cgi?id=72001
2078
2079         Reviewed by Dirk Pranke.
2080
2081         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2082
2083 2011-11-05  Filip Pizlo  <fpizlo@apple.com>
2084
2085         bencher script should support remote benchmarking
2086         https://bugs.webkit.org/show_bug.cgi?id=71618
2087
2088         Rubber-stamped by Geoff Garen.
2089         
2090         Added the following features:
2091         
2092         - Benchmark report tells you the hostname and machine model (according to
2093           'sysctl hw.model') of the machine you did the run on, and svn revision number
2094           (according to 'svn info') of the VMs you're testing.
2095         
2096         - The --remote option. You give this an ssh-style hostname (i.e. user@host is
2097           acceptable, in addition to just host, in which case your username is used)
2098           and it automatically packages the build directories of the VMs you're testing,
2099           sends them to the remote machine along with your copy of the bencher script
2100           and all of the options you passed.  This pretty much seamlessly allows you
2101           to run a set of benchmarks on any machine that is sufficiently compatible with
2102           yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
2103           must now include a tempPath setting that tells bencher where to put files
2104           when that machine is used as a slave in a remote benchmarking run.
2105           
2106         - Added yet another way of specifying which benchmarks to run. This was sort of
2107           necessary for --remote to work as expected. Previously, you either said what
2108           suites to exclude (for example --exclude-sunspider) or that you only wanted
2109           to run one suite to the exclusion of others (--sunspider-only). But it's
2110           often better to just be able to specify the list of suites you want. This is
2111           now supported. You can say, for example, --v8 --sunspider, which means, just
2112           run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
2113           still supported.
2114
2115         * Scripts/bencher:
2116
2117 2011-11-10  Tony Chang  <tony@chromium.org>
2118
2119         Lazily start DRT instances in NRWT
2120         https://bugs.webkit.org/show_bug.cgi?id=72038
2121
2122         Reviewed by Eric Seidel.
2123
2124         Just a refactoring, no new tests.
2125
2126         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2127         * Scripts/webkitpy/layout_tests/port/chromium.py:
2128         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2129         * Scripts/webkitpy/layout_tests/port/test.py:
2130         * Scripts/webkitpy/layout_tests/port/webkit.py:
2131
2132 2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>
2133
2134         ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
2135         https://bugs.webkit.org/show_bug.cgi?id=72057
2136
2137         Reviewed by Eric Seidel.
2138
2139         Make the regular expression more explicit.
2140
2141         * Scripts/webkitpy/common/checkout/changelog.py:
2142         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2143
2144 2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>
2145
2146         [Qt] X11 plugins need to be reworked for Qt5
2147         https://bugs.webkit.org/show_bug.cgi?id=70023
2148
2149         Reviewed by Simon Hausmann.
2150
2151         Rework our basic plugin support in a way that does
2152         not need a bridge between Qt and X. The solution is
2153         based on getting the content drawed by the plugin
2154         from the server as an image and creating a QImage
2155         from it.
2156
2157         * qmake/mkspecs/features/features.prf: Enable X11
2158         plugins if Qt is built with the xcb-xlib backend.
2159
2160 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2161
2162         [Qt] Fix keyboard related layout tests after API refactoring
2163
2164         Reviewed by Tor Arne Vestbø.
2165
2166         Send key events to the handling page item, not the view.
2167
2168         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2169         (WTR::PlatformWebView::sendEvent):
2170         (WTR::PlatformWebView::postEvent):
2171
2172 2011-11-10  Alexandre Mazari  <amazari@igalia.com>
2173
2174         [GTK] Make the ENABLE(FEATURE) macro work in DRT
2175         https://bugs.webkit.org/show_bug.cgi?id=71940
2176
2177         Reviewed by Philippe Normand.
2178
2179         * GNUmakefile.am:
2180         Add webcore_cppflags to Programs_DumpRenderTree_CPP so
2181         ENABLE_* variables are part of the environment.
2182
2183 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2184
2185         [Qt] Fix focus related layout tests after API refactoring
2186
2187         Reviewed by Tor Arne Vestbø.
2188
2189         Make sure the focus is set on the page now, not on the view
2190         (which doesn't actually handle the focus).
2191
2192         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2193         (WTR::WrapperWindow::WrapperWindow):
2194         (WTR::WrapperWindow::handleStatusChanged):
2195
2196 2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>
2197
2198         [Qt] Merge QTouchWebView and QDesktopWebView into one class
2199         https://bugs.webkit.org/show_bug.cgi?id=71355
2200
2201         Reviewed by Kenneth Rohde Christiansen.
2202
2203         Make MiniBrowser and WebKitTestRunner work again after the
2204         merge.
2205
2206         * MiniBrowser/qt/BrowserWindow.cpp:
2207         (BrowserWindow::BrowserWindow):
2208         (BrowserWindow::webView):
2209         * MiniBrowser/qt/MiniBrowser.pro:
2210         * MiniBrowser/qt/MiniBrowser.qrc:
2211         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2212         * MiniBrowser/qt/main.cpp:
2213         * MiniBrowser/qt/qml/BrowserWindow.qml:
2214         * MiniBrowser/qt/qml/DesktopView.qml: Removed.
2215         * MiniBrowser/qt/qml/TouchView.qml: Removed.
2216         * WebKitTestRunner/PlatformWebView.h:
2217         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2218         (WTR::PlatformWebView::PlatformWebView):
2219
2220 2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2221
2222         [Qt] Change semantics of the haveQt() function to match API promises
2223
2224         Having Qt 5 does not imply that we have Qt 4, from an API point of
2225         view, as a major version can in theory break BC/SC. Our minimum
2226         version of Qt 4 will always be the latest released version of Qt 4,
2227         so the only place we should use haveQt(4, x) is when checking for
2228         the minimum requirements.
2229
2230         Reviewed by Simon Hausmann.
2231
2232         * qmake/mkspecs/features/default_pre.prf:
2233         * qmake/mkspecs/features/features.prf:
2234         * qmake/mkspecs/features/functions.prf:
2235
2236 2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>
2237
2238         [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
2239         https://bugs.webkit.org/show_bug.cgi?id=69411
2240
2241         Reviewed by Martin Robinson.
2242
2243         * WebKitTestRunner/EventSenderProxy.h:
2244         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2245         * WebKitTestRunner/TestController.cpp:
2246         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2247         use the EventSender instead of WebProcess Event Simulation.
2248         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2249         (WTR::WTREventQueueItem::WTREventQueueItem):
2250         (WTR::EventSenderProxy::EventSenderProxy):
2251         (WTR::getMouseButtonModifiers):
2252         (WTR::eventSenderButtonToGDKButton):
2253         (WTR::EventSenderProxy::createMouseButtonEvent):
2254         (WTR::EventSenderProxy::updateClickCountForButton):
2255         (WTR::EventSenderProxy::replaySavedEvents):
2256         (WTR::EventSenderProxy::sendOrQueueEvent):
2257         (WTR::webkitModifiersToGDKModifiers):
2258         (WTR::getGDKKeySymForKeyRef):
2259         (WTR::EventSenderProxy::keyDown):
2260         (WTR::EventSenderProxy::mouseDown):
2261         (WTR::EventSenderProxy::mouseUp):
2262         (WTR::EventSenderProxy::mouseMoveTo):
2263         (WTR::EventSenderProxy::mouseScrollBy):
2264         (WTR::EventSenderProxy::leapForward):
2265
2266 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2267
2268         [Qt] Enable exports and constructor functions in static libs
2269
2270         Reviewed by Tor Arne Vestbø.
2271
2272         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2273         mac/win32-msvc equivalents when linking static libraries into a shared
2274         library or executable.
2275
2276 2011-11-09  Hayato Ito  <hayato@chromium.org>
2277
2278         [NRWT] Make results.html aware of reference filename in reftests.
2279         https://bugs.webkit.org/show_bug.cgi?id=71574
2280
2281         Reviewed by Ryosuke Niwa.
2282
2283         If a reference filename is different from the default one, include that in result summary
2284         so results.html can link to the correct reference file.
2285
2286         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2287         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2288
2289 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
2290
2291         [wx] Unreviewed build fix. Update project files and
2292         add LTC stubs for new methods.
2293
2294         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2295         (LayoutTestController::addChromeInputField):
2296         (LayoutTestController::removeChromeInputField):
2297         (LayoutTestController::focusWebView):
2298         (LayoutTestController::setBackingScaleFactor):
2299         * waf/build/settings.py:
2300
2301 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
2302
2303         [wx] Unreviewed build fix. Support XCode 4 when building deps.
2304
2305         * wx/install-unix-extras:
2306
2307 2011-11-09  Eric Seidel  <eric@webkit.org>
2308
2309         Remove the concept of platform-dependent unittests
2310         https://bugs.webkit.org/show_bug.cgi?id=71963
2311
2312         Unreviewed.  Fix test-webkitpy on cygwin.
2313
2314         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2315
2316 2011-11-09  Dana Jansens  <danakj@chromium.org>
2317
2318         Add cc-bugs group to watch changes in chromium graphics
2319         https://bugs.webkit.org/show_bug.cgi?id=71690
2320
2321         Reviewed by David Levin.
2322
2323         * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
2324         * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
2325         * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
2326         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
2327
2328 2011-11-09  Eric Seidel  <eric@webkit.org>
2329
2330         Remove more platform-dependent unittests
2331         https://bugs.webkit.org/show_bug.cgi?id=71971
2332
2333         Reviewed by Adam Barth.
2334
2335         Tests which only run on a couple platforms will break.
2336         All tests should run on all platforms where possible.
2337
2338         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2339         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2340         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2341         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2342
2343 2011-11-09  Ojan Vafai  <ojan@chromium.org>
2344
2345         Merge in results to the test results server even if build numbers conflict
2346         https://bugs.webkit.org/show_bug.cgi?id=71967
2347
2348         Reviewed by Tony Chang.
2349
2350         This was initially meant to be a sanity check that we don't
2351         enter duplicate runs, but it turns out that we can reasonably get
2352         in these situations when a builder is clobbered (e.g. the build
2353         numbers start over again from 0).
2354
2355         * TestResultServer/model/jsonresults.py:
2356         * TestResultServer/model/jsonresults_unittest.py:
2357
2358 2011-11-09  Eric Seidel  <eric@webkit.org>
2359
2360         Remove the concept of platform-dependent unittests
2361         https://bugs.webkit.org/show_bug.cgi?id=71963
2362
2363         Reviewed by Adam Barth.
2364
2365         These have been the source of never-ending sadness.
2366         We'd change behavior and forget to update results in
2367         some unittests because they were only run on certain platforms.
2368         This change removes a large source of these platform-dependent
2369         unittests, which was caused by the port_maker stuff.
2370
2371         It's possible that this change will break test-webkitpy
2372         on some platforms, but that will be a one-time cost.
2373         I will fix the breakage by removing the platform-dependantness
2374         of any such broken tests.
2375
2376         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2377         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2378         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2379         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2380         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2381         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2382         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2383         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2384         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2385         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2386         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2387         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2388         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2389
2390 2011-11-09  Eric Seidel  <eric@webkit.org>
2391
2392         Make the Port object have a Host
2393         https://bugs.webkit.org/show_bug.cgi?id=71961
2394
2395         Reviewed by Adam Barth.
2396
2397         This has been a long time coming.
2398         Now that Port has a Host object, it's very easy
2399         to write unittests which use a properly mocked Port.
2400         Soon we will remove the executive, filesystem and user
2401         members of Port and get everything through the Host.
2402
2403         Note how in many callsites we're actually removing
2404         explicit mocks, since we're now always going to get the
2405         correct Executive/User/FileSystem from the
2406         Host and callsites don't need to be careful to pass each one.
2407
2408         This is prep-work for adding a new Environment member to
2409         Host and needing to be able to access the Environment
2410         member from Port functions w/o needing to pass an Environment
2411         object (or appropriate Mock) every place we create a Port object.
2412         Now that we have a single Host object to reach out through, its
2413         simple to add additional functionality (like Environment) while
2414         keeping our unittests properly mocked.
2415
2416         * Scripts/webkitpy/common/host.py:
2417         * Scripts/webkitpy/common/net/credentials_unittest.py:
2418         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2419         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2420         * Scripts/webkitpy/layout_tests/port/apple.py:
2421         * Scripts/webkitpy/layout_tests/port/base.py:
2422         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2423         * Scripts/webkitpy/layout_tests/port/chromium.py:
2424         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2425         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2426         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2427         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2428         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2429         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2430         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2431         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2432         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2433         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2434         * Scripts/webkitpy/layout_tests/port/efl.py:
2435         * Scripts/webkitpy/layout_tests/port/factory.py:
2436         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2437         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2438         * Scripts/webkitpy/layout_tests/port/gtk.py:
2439         * Scripts/webkitpy/layout_tests/port/mac.py:
2440         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2441         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2442         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2443         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2444         * Scripts/webkitpy/layout_tests/port/qt.py:
2445         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2446         * Scripts/webkitpy/layout_tests/port/test.py:
2447         * Scripts/webkitpy/layout_tests/port/webkit.py:
2448         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2449         * Scripts/webkitpy/layout_tests/port/win.py:
2450         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2451         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2452         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2453         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2454         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2455
2456 2011-11-09  Dominic Mazzoni  <dmazzoni@google.com>
2457
2458         [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
2459         https://bugs.webkit.org/show_bug.cgi?id=71561
2460
2461         Reviewed by Dimitri Glazkov.
2462
2463         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2464         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
2465
2466 2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
2467
2468         Implement dumpProgressFinishedCallback() for Mac layoutTestController
2469         https://bugs.webkit.org/show_bug.cgi?id=66772
2470
2471         Reviewed by Simon Fraser.
2472
2473         When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
2474         "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
2475
2476         On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
2477         in the FrameLoadDelegate and print the output in response to the notification.
2478
2479         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2480         (-[FrameLoadDelegate init]):
2481         (-[FrameLoadDelegate dealloc]):
2482         (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
2483
2484 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2485
2486         [GTK][DRT] window internals object is not reset after each test
2487         https://bugs.webkit.org/show_bug.cgi?id=71890
2488
2489         Reviewed by Martin Robinson.
2490
2491         Call WebCoreTestSupport::resetInternalsObject without going
2492         through DumpRenderTreeSupport.
2493
2494         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2495         (runTest):
2496
2497 2011-11-09  Beth Dakin  <bdakin@apple.com>
2498
2499         Build fix.
2500
2501         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2502         (AccessibilityUIElement::uiElementAttributeValue):
2503
2504 2011-11-09  Beth Dakin  <bdakin@apple.com>
2505
2506         Speculative build fix.
2507
2508         * DumpRenderTree/AccessibilityUIElement.h:
2509
2510 2011-11-09  Julien Chaffraix  <jchaffraix@webkit.org>
2511
2512         Unreviewed build fix.
2513
2514         * DumpRenderTree/AccessibilityUIElement.cpp:
2515         (AccessibilityUIElement::makeJSAccessibilityUIElement):
2516         A bad merge added this check that is making the bots sad.
2517
2518 2011-11-09  Chris Fleizach  <cfleizach@apple.com>
2519
2520         AX: crash when accessing selectedTab in a tab list
2521         https://bugs.webkit.org/show_bug.cgi?id=70938
2522
2523         Reviewed by Beth Dakin.
2524
2525         Add the ability to retrieve an element through an arbitrary attribute.
2526
2527         * DumpRenderTree/AccessibilityUIElement.cpp:
2528         (uiElementAttributeValueCallback):
2529         (AccessibilityUIElement::uiElementAttributeValue):
2530         (AccessibilityUIElement::getJSClass):
2531         * DumpRenderTree/AccessibilityUIElement.h:
2532         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2533         (AccessibilityUIElement::uiElementAttributeValue):
2534
2535 2011-11-09  Andy Wingo  <wingo@igalia.com>
2536
2537         Add webkitdirs.pm:getArchitecture implementation for GTK
2538         https://bugs.webkit.org/show_bug.cgi?id=71370
2539
2540         Reviewed by Xan Lopez.
2541
2542         * Scripts/webkitdirs.pm (determineArchitecture): Add an
2543         implementation for ports using autotools, so that a vanilla
2544         `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
2545         to build-jsc on x86-64 machines.
2546
2547 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2548
2549         Unreviewed, rolling out r99707.
2550         http://trac.webkit.org/changeset/99707
2551
2552         Re-enable until we can disable it together with tests in one
2553         shot.
2554
2555         * qmake/mkspecs/features/features.prf:
2556
2557 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2558
2559         [Qt] Disable use of QtUiTools if the library/module is not found
2560
2561         We rely on the lookup order of prf files to inject our own uitools.prf
2562         that will verify that QtUiTools is in fact present before allowing the
2563         CONFIG += uitools to have any effect.
2564
2565         Reviewed by Simon Hausmann.
2566
2567         * DumpRenderTree/qt/DumpRenderTree.pro:
2568         * QtTestBrowser/QtTestBrowser.pro:
2569         * qmake/mkspecs/features/uitools.prf: Added.
2570
2571 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2572
2573         Unreviewed, rolling out r99701.
2574         http://trac.webkit.org/changeset/99701
2575
2576         Breaks Qt mac build
2577
2578         * qmake/mkspecs/features/functions.prf:
2579
2580 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2581
2582         [Qt] Prospective build fix for Win32/Mac with xmlpatterns
2583
2584         Reviewed by Tor Arne Vestbø.
2585
2586         * qmake/mkspecs/features/features.prf: Disable XSLT support initially.
2587         We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
2588         is not up to the task of full XSLT support, so we should disable it.
2589
2590 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2591
2592         [Qt] Enable exports and constructor functions in static libs
2593
2594         Reviewed by Tor Arne Vestbø.
2595
2596         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2597         mac/win32-msvc equivalents when linking static libraries into a shared
2598         library or executable.
2599
2600 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2601
2602         [GTK][DRT] window internals object is not reset after each test
2603         https://bugs.webkit.org/show_bug.cgi?id=71890
2604
2605         Reviewed by Xan Lopez.
2606
2607         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2608         (runTest): reset the Internals object after each test.
2609
2610 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2611
2612         [Qt] Detect presence of QtUiTools and enable it only when available
2613
2614         The disable_uitools option was a workaround for missing detection.
2615
2616         Reviewed by Simon Hausmann.
2617
2618         * QtTestBrowser/QtTestBrowser.pro:
2619         * qmake/mkspecs/features/default_post.prf:
2620         * qmake/mkspecs/features/default_pre.prf:
2621
2622 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2623
2624         [Qt] Don't override config for the build_pass of debug_and_release
2625
2626         Qmake will parse the profile once for each configuration (debug and
2627         release), with the build_pass option set. In that situation we don't
2628         want to override what qmake is setting explicitly, otherwise the
2629         debug-step will end up hitting all the release-scopes.
2630
2631         Reviewed by Simon Hausmann.
2632
2633         * qmake/mkspecs/features/default_pre.prf:
2634
2635 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2636
2637         [Qt] Unbreak the Qt build (copy & paste mistake - oops)
2638
2639         * qmake/mkspecs/features/functions.prf:
2640
2641 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2642
2643         [Qt] Centralize duplicated code for linking the static libs
2644
2645         Reviewed by Tor Arne Vestbø.
2646
2647         * qmake/mkspecs/features/functions.prf:
2648         * qmake/mkspecs/features/javascriptcore.prf:
2649         * qmake/mkspecs/features/webcore.prf:
2650         * qmake/mkspecs/features/webkit2.prf:
2651
2652 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2653
2654         [Qt] Build system cleanup
2655         https://bugs.webkit.org/show_bug.cgi?id=71815
2656
2657         Reviewed by Kenneth Rohde Christiansen.
2658
2659         * WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2
2660         static library.
2661         * qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency
2662         (ownPtr functions for glib types). Propagate that to everyone using javascriptcore.
2663
2664 2011-11-08  Hayato Ito  <hayato@chromium.org>
2665
2666         [NRWT] Make single_test_runner aware of reference filename of test_input.
2667         https://bugs.webkit.org/show_bug.cgi?id=71567
2668
2669         Reviewed by Ryosuke Niwa.
2670
2671         Make single_test_runner honor a reference filename of given test_input so that
2672         we can use any file as reference html, instead of depending on implicit naming convention.
2673         The typical use case is to support w3c reftests.
2674
2675         No tests since no functional changes until there is a client.
2676         Test should be easily written with future clients.
2677
2678         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2679         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2680         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2681         * Scripts/webkitpy/layout_tests/models/test_input.py:
2682
2683 2011-11-08  Lucas Forschler  <lforschler@apple.com>
2684
2685         https://bugs.webkit.org/show_bug.cgi?id=71839
2686         Update the leaks bot OS to Lion.
2687         Update the config.json to reflect the update.
2688
2689         Reviewed by Stephanie Lewis.
2690
2691         * BuildSlaveSupport/build.webkit.org-config/config.json:
2692
2693 2011-11-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2694
2695         Unreviewed, rolling out r99626.
2696         http://trac.webkit.org/changeset/99626
2697         https://bugs.webkit.org/show_bug.cgi?id=71866
2698
2699         "C++ exceptions cannot be disabled without influencing the
2700         Objective-C exceptions" (Requested by benjaminp on #webkit).
2701
2702         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2703
2704 2011-11-08  Benjamin Poulain  <bpoulain@apple.com>
2705
2706         [Mac] Disable C++ exceptions from DumpRenderTree
2707         https://bugs.webkit.org/show_bug.cgi?id=71834
2708
2709         Reviewed by Darin Adler.
2710
2711         DumpRenderTree Mac does not handle C++ exceptions. When such exception
2712         happens, it tends to cause the AutoReleasePool stack to be corrupted,
2713         which leads to crashes long after the exception was raised.
2714
2715         This patch disabled C++ exceptions in order to catch the problems where
2716         they happen when a C++ exception is raised.
2717
2718         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2719
2720 2011-11-08  Julien Chaffraix  <jchaffraix@webkit.org>
2721
2722         Moved myself to the reviewer list (yay!).
2723
2724         * Scripts/webkitpy/common/config/committers.py:
2725
2726 2011-11-08  Zeno Albisser  <zeno@webkit.org>
2727
2728         Added myself as a committer.
2729
2730         * Scripts/webkitpy/common/config/committers.py:
2731
2732 2011-11-08  Andy Wingo  <wingo@igalia.com>
2733
2734         Skip some ECMAScript tests that fail on Linux in some time zones.
2735         https://bugs.webkit.org/show_bug.cgi?id=71371
2736
2737         Reviewed by Martin Robinson.
2738
2739         * Scripts/run-javascriptcore-tests: Skip some more tests.
2740
2741 2011-11-08  Csaba Osztrogonác  <ossy@webkit.org>
2742
2743         [Qt] Unreviewed trivial fix after build system refactoring.
2744
2745         * Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
2746
2747 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2748
2749         [Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
2750
2751         If a pro file needs to access the OBJECTS_DIR it should use the
2752         form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
2753         after defaults_post has been processed.
2754
2755         Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
2756         the command line will override whatever we set in defaults_pre.
2757
2758         Reviewed by Simon Hausmann.
2759
2760         * qmake/mkspecs/features/default_post.prf:
2761         * qmake/mkspecs/features/default_pre.prf:
2762
2763 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2764
2765         [Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
2766
2767         Reviewed by Simon Hausmann.
2768
2769         * qmake/mkspecs/features/default_post.prf:
2770
2771 2011-11-07  Zeno Albisser  <zeno.albisser@nokia.com>
2772
2773         [Qt][WK2] MiniBrowser should use urlFromUserInput()
2774         https://bugs.webkit.org/show_bug.cgi?id=71680
2775
2776         Use urlFromUserInput() / QUrl::fromUserInput() to automatically
2777         complete urls in MiniBrowser.
2778
2779         Reviewed by Tor Arne Vestbø.
2780
2781         * MiniBrowser/qt/BrowserWindow.cpp:
2782         (BrowserWindow::BrowserWindow):
2783         (BrowserWindow::load):
2784         * MiniBrowser/qt/qml/BrowserWindow.qml:
2785         * MiniBrowser/qt/utils.cpp:
2786         (Utils::urlFromUserInput):
2787         * MiniBrowser/qt/utils.h:
2788         (Utils::Utils):
2789
2790 2011-11-07  Yuqiang Xian  <yuqiang.xian@intel.com>
2791
2792         Added myself as a committer.
2793
2794         * Scripts/webkitpy/common/config/committers.py:
2795
2796 2011-11-07  Csaba Osztrogonác  <ossy@webkit.org>
2797
2798         Unreviewed webkitpy test fix after r99512.
2799
2800         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2801         Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.
2802
2803 2011-11-07  Xianzhu Wang  <wangxianzhu@chromium.org>
2804
2805         Added myself as a committer.
2806
2807         * Scripts/webkitpy/common/config/committers.py:
2808
2809 2011-11-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2810
2811         Unreviewed, rolling out r99470.
2812         http://trac.webkit.org/changeset/99470
2813         https://bugs.webkit.org/show_bug.cgi?id=71740
2814
2815         "Broke test-webkitpy" (Requested by eseidel2 on #webkit).
2816
2817         * Scripts/webkitpy/common/config/watchlist:
2818
2819 2011-11-07  Tony Chang  <tony@chromium.org>
2820
2821         [chromium] update flakiness dashboard to reflect current bots
2822
2823         Reviewed by Ojan Vafai.
2824
2825         * TestResultServer/static-dashboards/builders.js: Remove (deps) debug
2826             bots and merged linux debug bots into a single bot.
2827         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2828         (setupExpectationsTest):
2829
2830 2011-11-07  Dana Jansens  <danakj@chromium.org>
2831
2832         Add cc-bugs group to watch changes in chromium graphics
2833         https://bugs.webkit.org/show_bug.cgi?id=71690
2834
2835         Reviewed by James Robinson.
2836
2837         * Scripts/webkitpy/common/config/watchlist:
2838
2839 2011-11-07  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
2840
2841         [NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
2842         https://bugs.webkit.org/show_bug.cgi?id=70912
2843
2844         Reviewed by Ojan Vafai.
2845
2846         * Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
2847         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
2848
2849 2011-11-07  Eric Seidel  <eric@webkit.org>
2850
2851         new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
2852         https://bugs.webkit.org/show_bug.cgi?id=62199
2853
2854         Reviewed by Dirk Pranke.
2855
2856         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2857         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2858         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2859
2860 2011-11-07  Fady Samuel  <fsamuel@chromium.org>
2861
2862         [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
2863         https://bugs.webkit.org/show_bug.cgi?id=71485
2864
2865         Reviewed by Darin Fisher.
2866
2867         * DumpRenderTree/chromium/EventSender.cpp:
2868         (EventSender::scalePageBy):
2869         * DumpRenderTree/chromium/TestShell.cpp:
2870         (TestShell::resetTestController):
2871
2872 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2873
2874         [Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree
2875
2876         Allows us to not package up the whole Source/JavaScriptCore directory for the
2877         buildbots.
2878
2879         Reviewed-by Simon Hausmann.
2880
2881         * BuildSlaveSupport/built-product-archive:
2882         * Scripts/webkitdirs.pm:
2883         (jscProductDir):
2884
2885 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2886
2887         [Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
2888
2889         Reviewed-by Simon Hausmann.
2890
2891         * qmake/mkspecs/features/default_post.prf:
2892
2893 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2894
2895         [Qt] Sanitize qmake paths correctly before comparing
2896
2897         The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
2898         which caused us to always generate derived webcore sources, but never build
2899         them. The bug has been fixed, and we now also sanitize paths for the injected
2900         bundle derived sources.
2901
2902         Reviewed by Simon Hausmann.
2903
2904         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2905         * qmake/mkspecs/features/functions.prf:
2906
2907 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2908
2909         [Qt] Print right order for changing feature defines
2910
2911         Reviewed by Simon Hausmann.
2912
2913         * Scripts/webkitdirs.pm:
2914         (buildQMakeProject):
2915
2916 2011-11-06  Csaba Osztrogonác  <ossy@webkit.org>
2917
2918         [Qt] Unreviewed trivial fix after build system refactoring.
2919
2920         * Scripts/run-qtwebkit-tests: Fix qml_import_path.
2921
2922 2011-11-06  Eric Seidel  <eric@webkit.org>
2923
2924         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
2925         https://bugs.webkit.org/show_bug.cgi?id=66078
2926
2927         Unreviewed.  Add an assert about the type of "args"
2928         to our Executive Mocks and fix a piece of code
2929         from this patch which was hitting that assert
2930         when executing for real.
2931
2932         * Scripts/webkitpy/common/system/executive_mock.py:
2933         * Scripts/webkitpy/layout_tests/port/webkit.py:
2934
2935 2011-11-06  Eric Seidel  <eric@webkit.org>
2936
2937         Split chunk handling out of prepare_lists_and_print_output to make it more readable
2938         https://bugs.webkit.org/show_bug.cgi?id=71629
2939
2940         Reviewed by Adam Barth.
2941
2942         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2943
2944 2011-11-06  Eric Seidel  <eric@webkit.org>
2945
2946         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
2947         https://bugs.webkit.org/show_bug.cgi?id=66078
2948
2949         Reviewed by Adam Barth.
2950
2951         The runtime feature detection was fixed to work in bug 64472.
2952         In this bug I moved the symbol-based feature detection from
2953         popen() to Executive.run_command and cleaned up the callers
2954         and unittests to make sure that we're correctly parsing the
2955         nm output correctly.  The old code happened to work even though
2956         the runtime-features path was using "str in list" and the
2957         symbol features path was using "str in str" and it just happened
2958         to do what we wanted to.  Now runtime features and symbol feature
2959         blacklists are computed separately (and with better documentation).
2960
2961         This system remains confusing, partially because these are black-lists
2962         which are amended to whatever static blacklist may exist for the
2963         port as part of a Skipped list file.
2964
2965         For example, notice how the runtime feature list only has directory
2966         blacklists for a couple features.  If all features are off,
2967         how do we skip enough tests with only 2 entries in the blacklist map?
2968         The answer is that Windows is the only port to use runtime feature
2969         detection, and the win/Skipped file turns off all the other features
2970         statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
2971         which use symbol-based feature detection turn of mathml, wcss, etc
2972         using the blacklists found in _missing_symbol_to_skipped_tests.
2973
2974         I also noticed a couple places where we still referenced xhtmlmp
2975         even though support for such has been removed from WebKit.  Removed those.
2976
2977         This should result in no functional change.
2978
2979         * Scripts/webkitpy/layout_tests/port/gtk.py:
2980          - Use self._filesystem instead of os.path
2981         * Scripts/webkitpy/layout_tests/port/webkit.py:
2982         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2983
2984 2011-11-06  Dan Bernstein  <mitz@apple.com>
2985
2986         Made show-pretty-diff work when the input path contains spaces.
2987
2988         Reviewed by Anders Carlsson.
2989
2990         * Scripts/show-pretty-diff:
2991
2992 2011-11-05  Daniel Cheng  <dcheng@chromium.org>
2993
2994         [chromium] Use the security origin instead of the URL when checking notification permissions
2995         https://bugs.webkit.org/show_bug.cgi?id=71590
2996
2997         Reviewed by Adam Barth.
2998
2999         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3000         (NotificationPresenter::checkPermission):
3001         * DumpRenderTree/chromium/NotificationPresenter.h:
3002
3003 2011-11-05  Darin Adler  <darin@apple.com>
3004
3005         Fix a small leak in Mac version of LayoutTestController
3006         https://bugs.webkit.org/show_bug.cgi?id=71615
3007
3008         Reviewed by Mark Rowe.
3009
3010         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3011         (LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
3012         (LayoutTestController::localStorageDiskUsageForOrigin): Ditto.
3013
3014 2011-11-04  Eric Seidel  <eric@webkit.org>
3015
3016         Upgrade to the latest Mechanize
3017         https://bugs.webkit.org/show_bug.cgi?id=71594
3018
3019         Reviewed by Adam Barth.
3020
3021         I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
3022         Mechanize is no longer two separate libraries, so importing it is much simpler.
3023
3024         * Scripts/webkitpy/thirdparty/__init__.py:
3025
3026 2011-11-04  Stephen Chenney  <schenney@chromium.org>
3027
3028         Crash in ScrollAnimator.cpp
3029         https://bugs.webkit.org/show_bug.cgi?id=69865
3030
3031         The code in ScrollAnimator assumes that horizontal per-page mouse
3032         wheel events cannot happen, which is not true. This patch adds layout
3033         tests for all paging wheel event situations and fixes the broken
3034         horizontal case.
3035
3036         Reviewed by Anders Carlsson
3037
3038         * DumpRenderTree/chromium/EventSender.cpp:
3039         (EventSender::handleMouseWheel): Added the ability to specify that a
3040         mouse wheel event should be paging.
3041
3042 2011-11-04  Eric Seidel  <eric@webkit.org>
3043
3044         Remove deprecated free functions in port.factory
3045         https://bugs.webkit.org/show_bug.cgi?id=71494
3046
3047         Unreviewed.  Fix exception when running new-run-webkit-httpd.
3048
3049         * Scripts/new-run-webkit-httpd:
3050
3051 2011-11-04  Adam Roben  <aroben@apple.com>
3052
3053         Remove Leopard-specific code from build.webkit.org
3054
3055         We don't have any Leopard bots anymore.
3056
3057         Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code
3058
3059         Reviewed by Mark Rowe.
3060
3061         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
3062         and StopATSServer steps.
3063         (unitTestsSupported): Removed check for mac-leopard.
3064         (TestFactory.__init__): Removed Leopard-specific steps.
3065
3066 2011-11-04  Eric Seidel  <eric@webkit.org>
3067
3068         new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
3069         https://bugs.webkit.org/show_bug.cgi?id=71549
3070
3071         Reviewed by Adam Barth.
3072
3073         Several members of Host didn't really belong there
3074         and were instead specific to WebKitPatch, so I've moved
3075         them up onto that class.
3076
3077         * Scripts/webkitpy/common/host.py:
3078         * Scripts/webkitpy/common/host_mock.py:
3079         * Scripts/webkitpy/tool/main.py:
3080         * Scripts/webkitpy/tool/mocktool.py:
3081         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3082
3083 2011-11-04  Tony Chang  <tony@chromium.org>
3084
3085         garden-o-matic: bring back party time!
3086         https://bugs.webkit.org/show_bug.cgi?id=71582
3087
3088         Reviewed by Adam Barth.
3089
3090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
3091         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
3092         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
3093         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
3094         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
3095         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
3096
3097 2011-11-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
3098
3099         [EFL] DRT: Fix the order of the items in the dumped history list.
3100         https://bugs.webkit.org/show_bug.cgi?id=71562
3101
3102         It did not make much sense to hold the history list in a map, as we do not need
3103         the keys. And the printed items must be sorted by target, which is more easily
3104         done with a vector.
3105
3106         Should make tests such as http/tests/navigation/error404-frames.html pass.
3107
3108         Reviewed by Antonio Gomes.
3109
3110         * DumpRenderTree/efl/DumpHistoryItem.cpp:
3111         (compareHistoryItemsByTarget):
3112         (dumpHistoryItem):
3113
3114 2011-11-04  Patrick Gansterer  <paroga@webkit.org>
3115
3116         [Qt] Remove ENABLE_SQLITE from qmake files
3117         https://bugs.webkit.org/show_bug.cgi?id=71546
3118
3119         Reviewed by Simon Hausmann.
3120
3121         * qmake/mkspecs/features/features.prf:
3122         * qmake/mkspecs/features/webcore.prf:
3123
3124 2011-11-04  Adam Barth  <abarth@webkit.org>
3125
3126         watchlist for WebIDL shouldn't trigger on Internals.idl
3127         https://bugs.webkit.org/show_bug.cgi?id=70657
3128
3129         Reviewed by David Levin.
3130
3131         Internals.idl isn't part of the Web-facing IDL in the project.
3132
3133         * Scripts/webkitpy/common/config/watchlist:
3134
3135 2011-11-04  Anders Carlsson  <andersca@apple.com>
3136
3137         Fix WKTR crash when running NPN_ConvertPoint test.
3138
3139         Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.
3140
3141         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3142         (ConvertPoint::NPP_SetWindow):
3143
3144 2011-11-04  Anders Carlsson  <andersca@apple.com>
3145
3146         NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
3147         https://bugs.webkit.org/show_bug.cgi?id=71570
3148
3149         Reviewed by Simon Fraser.
3150
3151         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3152         (PluginTest::NPP_SetWindow):
3153         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3154         Remove the NPP parameter from NPP_SetWindow.
3155
3156         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
3157         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
3158         Remove the NPP parameter from NPP_SetWindow.
3159
3160         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3161         (PassDifferentNPPStruct::NPP_SetWindow):
3162         Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.
3163
3164         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3165         (ConvertPoint::NPP_SetWindow):
3166         Run the test from NPP_SetWindow and call notifyDone() when done.
3167
3168         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3169         (NPP_SetWindow):
3170         Remove unnecessary parameter.
3171
3172 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3173
3174         [Qt] Fix run-qtwebkit-tests execution on the build bot(s).
3175
3176         Rubber-stamped by Tor Arne Vestbø.
3177
3178         * BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
3179         changed slightly after the refactoring.
3180
3181 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3182
3183         [Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
3184
3185         Reviewed by Simon Hausmann.
3186
3187         * qmake/mkspecs/features/default_pre.prf:
3188
3189 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3190
3191         [Qt] Don't error out on wrong Qt version when qmake does recursive includes
3192
3193         Reviewed by Simmon Hausmann.
3194
3195         * qmake/mkspecs/features/default_pre.prf:
3196
3197 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3198
3199         [Qt] Disable STDIN check before cleaning build dir
3200
3201         It didn't work on the bots.
3202
3203         Reviewed by Ossy.
3204
3205         * Scripts/webkitdirs.pm:
3206
3207 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3208
3209         [Qt] Don't build all of webkit when running build-jsc
3210
3211         In case the whole webkit project was built, but we then subsequently
3212         want to build only JSC, we need to run make in the proper subdirectory.
3213
3214         This also means the incremental target needs to be added to all
3215         makefiles.
3216
3217         Reviewed by Simmon Hausmann.
3218
3219         * Scripts/webkitdirs.pm:
3220         (buildQMakeProject):
3221         * qmake/mkspecs/features/default_post.prf:
3222
3223 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3224
3225         Fix run-javascriptcore-tests for Qt when it's executed by the bot.
3226
3227         Reviewed by Tor Arne Vestbø.
3228
3229         * Scripts/webkitdirs.pm:
3230         (jscProductDir): jsc path changed.
3231
3232 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3233
3234         [Qt] Error out early if trying to build against Qt < 4.8
3235
3236         Reviewed by Simon Hausmann.
3237
3238         * qmake/mkspecs/features/default_pre.prf:
3239
3240 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3241
3242         Fix run-launcher for Qt and Gtk.
3243
3244         Rubber-stamped by Tor Arne Vestbø.
3245
3246         * Scripts/webkitdirs.pm:
3247         (isWK2): Re-add isWK2(), as it's used in run-launcher.
3248
3249 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3250
3251         [Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
3252
3253         Reviewed by Simon Hausmann.
3254
3255         * Scripts/build-webkit:
3256
3257 2011-11-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3258
3259         [GTK] Use web view title as window title in MiniBrowser
3260         https://bugs.webkit.org/show_bug.cgi?id=71544
3261
3262         Reviewed by Philippe Normand.
3263
3264         * MiniBrowser/gtk/BrowserWindow.c:
3265         (webViewURIChanged): Removed extra space.
3266         (webViewTitleChanged): Set window title using
3267         webkit_web_view_get_title().
3268         (browser_window_init): Set initial default window title.
3269         (browserWindowConstructed): Connect to WebView notify::title
3270         signal.
3271
3272 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3273
3274         [Qt] Refactor and clean up the qmake build system
3275
3276         The qmake build system has accumulated a bit of cruft and redundancy
3277         over time. There's also a fairly tight coupling between how to build
3278         the various targets, and _what_ to build, making it harder to add new
3279         rules or sources. This patch aims to elevate these issues somewhat.
3280
3281         This is a short-list of the changes:
3282
3283           * The rules for how to build targets are now mostly contained as
3284             prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
3285             allows us to do pre- and post-processing of each project file,
3286             which helps to clean up the actual project files.
3287
3288           * Derived sources are no longer generated as a separate make-step
3289             but is part of each target's project file as a subdir. Makefile
3290             rules are used to ensure that we run make on the derived sources
3291             before running qmake on the actual target makefile. This makes
3292             it easier to keep a proper dependency between derived sources
3293             and the target.
3294
3295           * We use GNU make and the compiler to generate dependencies on
3296             UNIX-based systems running Qt 5. This allows us to lessen the
3297             need to run qmake, which should reduce compile time.
3298
3299           * WebKit2 is now build by default if building with Qt 5. It can
3300             be disabled by passing --no-webkit2 to build-webkit.
3301
3302         The result of these changes are hopefully a cleaner and easier
3303         build system to modify, and faster build times due to no longer
3304         running qmake on every single build. It's also a first step
3305         towards possibly generating the list of sources using another
3306         build system.
3307
3308         https://bugs.webkit.org/show_bug.cgi?id=71222
3309
3310         Reviewed by Simon Hausmann.
3311
3312         * DerivedSources.pro: Removed.
3313         * DumpRenderTree/qt/DumpRenderTree.pro:
3314         * DumpRenderTree/qt/ImageDiff.pro:
3315         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3316         * MiniBrowser/qt/MiniBrowser.pro:
3317         * QtTestBrowser/QtTestBrowser.pro:
3318         * QtTestBrowser/launcherwindow.cpp:
3319         (LauncherWindow::initializeView):
3320         (LauncherWindow::createChrome):
3321         (LauncherWindow::screenshot):
3322         * QtTestBrowser/launcherwindow.h:
3323         (WindowOptions::WindowOptions):
3324         * Scripts/build-webkit:
3325         (unlinkZeroFiles):
3326         * Scripts/webkitdirs.pm:
3327         (qtFeatureDefaults):
3328         (promptUser):
3329         (buildQMakeProject):
3330         * Tools.pro:
3331         * WebKitTestRunner/DerivedSources.pri: Added.
3332         * WebKitTestRunner/DerivedSources.pro: Removed.
3333         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Added.
3334         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Added.
3335         * WebKitTestRunner/InjectedBundle/Target.pri: Added.
3336         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Removed.
3337         * WebKitTestRunner/Target.pri: Added.
3338         * WebKitTestRunner/WebKitTestRunner.pro:
3339         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3340         * WebKitTestRunner/qt/WebKitTestRunner.pro: Removed.
3341         * qmake/README: Added.
3342         * qmake/mkspecs/features/default_post.prf: Added.
3343         * qmake/mkspecs/features/default_pre.prf: Added.
3344         * qmake/mkspecs/features/features.prf: Renamed from Source/WebCore/features.pri.
3345         * qmake/mkspecs/features/functions.prf: Added.
3346         * qmake/mkspecs/features/javascriptcore.prf: Renamed from Source/JavaScriptCore/JavaScriptCore.pri.
3347         * qmake/mkspecs/features/mac/default_post.prf: Added.
3348         * qmake/mkspecs/features/mac/default_pre.prf: Added.
3349         * qmake/mkspecs/features/minimal_qt.prf: Added.
3350         * qmake/mkspecs/features/qtwebkit.prf: Added.
3351         * qmake/mkspecs/features/rpath.prf: Added.
3352         * qmake/mkspecs/features/unix/default_post.prf: Added.
3353         * qmake/mkspecs/features/unix/default_pre.prf: Added.
3354         * qmake/mkspecs/features/valgrind.prf: Added.
3355         * qmake/mkspecs/features/webcore.prf: Renamed from Source/WebCore/WebCore.pri.
3356         * qmake/mkspecs/features/webkit2.prf: Copied from Source/WebKit2/WebKit2.pri.
3357         * qmake/mkspecs/features/win32/default_post.prf: Added.
3358         * qmake/qt_webkit.pri: Renamed from Source/WebKit/qt/qt_webkit_version.pri.
3359         * qmake/syncqt-4.8: Added.
3360         (showUsage):
3361         ():
3362         (copyFile):
3363         (symlinkFile):
3364
3365 2011-11-04  Eric Seidel  <eric@webkit.org>
3366
3367         Remove deprecated free functions in port.factory
3368         https://bugs.webkit.org/show_bug.cgi?id=71494
3369
3370         Unreviewed.  Fixing exception seen when running test-webkitpy.
3371
3372         Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
3373         unittest, since that script is nearly ready to be deleted.  But I added
3374         it back at the last second and failed to run the tests. :(
3375         This fixes the exception the bots were seeing.
3376
3377         * Scripts/webkitpy/style/checkers/test_expectations.py:
3378         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3379         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3380
3381 2011-11-02  Xiaomei Ji  <xji@chromium.org>
3382
3383         Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
3384         https://bugs.webkit.org/show_bug.cgi?id=71163
3385
3386         Reviewed by Ryosuke Niwa.
3387
3388         * DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.
3389         (WebPreferences::applyTo):
3390
3391 2011-11-03  Eric Seidel  <eric@webkit.org>
3392
3393         Remove deprecated free functions in port.factory
3394         https://bugs.webkit.org/show_bug.cgi?id=71494
3395
3396         Reviewed by Adam Barth.
3397
3398         I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
3399         free functions in factory.py.  To remove these required fixing all callsites
3400         to use MockHost, Host, or PortFactory where appropriate.  After this change
3401         we're only left with a handfull of places where we inappropraitely use a
3402         real Executive, FileSystem or User object during unittesting.
3403
3404         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3405          - These PortFactory overrides were from an earlier edition of my previous patch
3406            in the end, I removed MockPortFactory so all tests ended up with this same
3407            real PortFactory() with a MockHost.  This was simply redundent code.
3408         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3409          - Use MockHost to get a mocked-out PortFactory.
3410         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3411          - This code has no access to a Host object, so we just use a default PortFactory
3412            for now.  This will still incorrectly create real Executive/FileSystem objects
3413            durring unittesting, which is wrong. :(
3414         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3415          - Use a MockHost to get a mocked PortFactory.
3416         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3417          - Use a MockHost to get a mocked PortFactory.
3418         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3419          - ditto.
3420         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3421          - ditto.
3422         * Scripts/webkitpy/layout_tests/port/__init__.py:
3423          - factory.get no longer exists.  Yay!
3424         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3425          - Use a MockHost to get a mocked PortFactory.
3426            To do this efficiently, I created a helper function
3427            and combined all these (mostly redundant) tests into one test
3428            with several calls to the helper function.
3429         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3430          - Pass MockUser and MockExecutive in these port testing subclasses.
3431          - I also removed a bunch of unecessary uses of mocktool. namespacing.
3432         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3433          - Awesome windows hacks should only happen on win32.  Once we started
3434            using MockExecutives these 'svn help' commands started printing in
3435            other tests, which is how I found this bug.
3436         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3437          - DryRunPort has no Host, so just use a PortFactory() directly.
3438            This will do the wrong thing if we're unittesting the DryRun port
3439            but it's no worse than the existing code.
3440         * Scripts/webkitpy/layout_tests/port/factory.py:
3441          - Remove the free functions.
3442          - Fix argument overriding to be able to override None.
3443         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3444          - Use a mocked-out PortFactory during testing.
3445         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3446          - Pass MockExecutive and MockUser to these manual Port instantiations.
3447         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3448          - No access to a Host object here, so just using PortFactory directly.
3449            This is wrong, but no more wrong than the existing code was.
3450         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3451          - Use a MockHost to get a mocked out PortFactory.
3452         * Scripts/webkitpy/layout_tests/port/test.py:
3453          - Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
3454         * Scripts/webkitpy/layout_tests/port/win.py:
3455          - Don't run cmd /c ver from WinPort.__init__ or it shows up in unittests which have logging MockExecutive
3456            now that we're actually passing MockExecutive to most Port instantiations during testing.
3457         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3458          - Pass our new "unittesting" bool to _detect_version when actually unittesting.
3459         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3460          - Host is the future.
3461         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3462          - Use a MockHost to get a mocked out PortFactory.  Once we have a mocked PortFactory
3463            we don't need to pass MockUser explicitly, it does that automatically for us.
3464         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3465          - Use a MockHost to get a mocked out PortFactory.
3466         * Scripts/webkitpy/style/checkers/test_expectations.py:
3467          - We don't have access to a Host object, so using PortFactory() directly.
3468         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3469          - Remove unused variable.
3470         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3471          - Host isn't accessible here, so using PortFactory() directly, which
3472            although unfortunate is no worse than before.
3473         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3474          - Testing is much easier when you don't need to hack global state...
3475         * Scripts/webkitpy/tool/commands/expectations.py:
3476          - Use the port_factory on the tool.
3477         * Scripts/webkitpy/tool/commands/rebaseline.py:
3478          - ditto.
3479         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3480          - This unittest was wrong.  It was trying to pass the tool object, but failing to pass
3481            the arguments in the right order.  Fixing that made it use a MockFileSystem
3482            (like it had been trying to), which then required us to actually populate
3483            that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
3484         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3485          - Get the port_factory from the tool.
3486         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3487          - Ditto.
3488         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3489          - Use a MockHost to get a mocked out Port object.
3490
3491 2011-11-03  Raphael Kubo da Costa  <kubo@profusion.mobi>
3492
3493         [EFL] DRT: Allow choosing which backing store to use.
3494         https://bugs.webkit.org/show_bug.cgi?id=70532
3495
3496         Reviewed by Antonio Gomes.
3497
3498         This change makes it possible to change the backing store used by DRT
3499         from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
3500         setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.
3501
3502         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3503         (DumpRenderTreeChrome::createView):
3504         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3505         (shouldUseSingleBackingStore):
3506         (chooseAndInitializeAppropriateSmartClass):
3507         (drtViewAdd):
3508         * DumpRenderTree/efl/DumpRenderTreeView.h:
3509
3510 2011-11-02  Erik Arvidsson  <arv@chromium.org>
3511
3512         JS Test Harness: Remove more link tags
3513         https://bugs.webkit.org/show_bug.cgi?id=71339
3514
3515         Reviewed by Ojan Vafai.
3516
3517         * Scripts/make-new-script-test:
3518         (writeTestFile): Don't output <link>
3519
3520 2011-11-03  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
3521
3522         Reviewed by Martin Robinson.
3523
3524         [GTK] arguments passed to build-jsc are not taken into account
3525         https://bugs.webkit.org/show_bug.cgi?id=58333
3526
3527         * Scripts/build-jsc:
3528
3529 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3530
3531         [GTK] Show url of history items in a status bar in MiniBrowser
3532         https://bugs.webkit.org/show_bug.cgi?id=71474
3533
3534         Reviewed by Martin Robinson.
3535
3536         * MiniBrowser/gtk/BrowserWindow.c:
3537         (browserWindowSetStatusText): Set status text and show/hide the
3538         status label.
3539         (resetStatusText): Reset status text when history menu is hidden.
3540         (browserWindowHistoryItemSelected): Show url of currently selected
3541         history item.
3542         (browserWindowCreateBackForwardMenu): Connect to hide signal of
3543         menu to reset the status text.
3544         (browserWindowConstructed): Use GtkOverlay if available to show
3545         status text.
3546
3547 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3548
3549         [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
3550         https://bugs.webkit.org/show_bug.cgi?id=71466
3551
3552         Reviewed by Martin Robinson.
3553
3554         * MiniBrowser/gtk/BrowserWindow.c:
3555         (browserWindowHistoryItemActivated): Go to selected back formard
3556         list item using webkit_web_view_go_to_back_forward_list_item()
3557         (browserWindowCreateBackForwardMenu): Create a GtkMenu for the
3558         given GList of WebKitBackForwardListItems.
3559         (browserWindowUpdateNavigationActions): Enable/disable back and
3560         forward buttons depending on whether it's possible to go
3561         back/forward. Create a menu for back and forward toolbar buttons.
3562         (backForwadlistChanged): Call browserWindowUpdateNavigationActions().
3563         (browserWindowConstructed): Connect to WebKitBackForwardList
3564         changed signal.
3565
3566 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3567
3568         [Qt] Remove Maemo specific code paths
3569         https://bugs.webkit.org/show_bug.cgi?id=71476
3570
3571         Reviewed by Kenneth Rohde Christiansen.
3572
3573         * QtTestBrowser/launcherwindow.cpp:
3574         (LauncherWindow::~LauncherWindow):
3575         (LauncherWindow::init):
3576         (LauncherWindow::showLinkHover):
3577         (LauncherWindow::selectElements):
3578         (LauncherWindow::showFPS):
3579         (LauncherWindow::updateFPS):
3580         * QtTestBrowser/launcherwindow.h:
3581         (WindowOptions::WindowOptions):
3582         * QtTestBrowser/locationedit.cpp:
3583         * QtTestBrowser/locationedit.h:
3584
3585 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3586
3587         [GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
3588         https://bugs.webkit.org/show_bug.cgi?id=71461
3589
3590         Reviewed by Martin Robinson.
3591
3592         * MiniBrowser/gtk/BrowserWindow.c:
3593         (resetEntryProgress): Reset the entry progress after a while when
3594         load has been completed.
3595         (webViewLoadProgressChanged): Update location entry progress.
3596         (browserWindowConstructed): Connect to WebView
3597         notify::estimated-load-progress signal.
3598
3599 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3600
3601         [GTK] Remove WebKit2 C API from MiniBrowser
3602         https://bugs.webkit.org/show_bug.cgi?id=71459
3603
3604         Reviewed by Martin Robinson.
3605
3606         Use the GTK+ API instead to add minimum functionality. The other
3607         features will be ported to GTK+ API in following patches.
3608
3609         * MiniBrowser/gtk/BrowserWindow.c:
3610         (activateUriEntryCallback): Use webkit_web_view_load_uri().
3611         (goBackCallback): Use webkit_web_view_go_back().
3612         (goForwardCallback): Use webkit_web_view_go_forward().
3613         (webViewURIChanged): Update location entry with current uri using
3614         webkit_web_view_get_uri().
3615         (browserWindowFinalize):
3616         (browserWindowGetProperty):
3617         (browserWindowSetProperty):
3618         (browser_window_init):
3619         (browserWindowConstructed): Connect to notify::uri signal of
3620         WebView to be notified when the URI changes.
3621         (browser_window_class_init):
3622         (browser_window_new): Use WebKitWebView.
3623         (browser_window_get_view): Use WebKitWebView
3624         * MiniBrowser/gtk/BrowserWindow.h:
3625         * MiniBrowser/gtk/GNUmakefile.am:
3626         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
3627         * MiniBrowser/gtk/main.c:
3628         (loadURI): Use webkit_web_view_new().
3629         (main):
3630
3631 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3632