8c54afe1b55cea753fc37633a647212e9542a701
[WebKit-https.git] / Tools / ChangeLog
1 2014-05-06  Brady Eidson  <beidson@apple.com>
2
3         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
4         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
5
6         Reviewed by Sam Weinig.
7
8         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
9
10         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
11         (TestWebKitAPI::itemURLLastComponentIsString):
12         (TestWebKitAPI::didFinishLoadForFrame):
13         (TestWebKitAPI::willGoToBackForwardListItem):
14         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
15         (TestWebKitAPI::setPageLoaderClient):
16         (TestWebKitAPI::TEST):
17         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
18         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
19
20         * WebKitTestRunner/TestController.cpp:
21         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
22
23 2014-05-06  Darin Adler  <darin@apple.com>
24
25         Try to fix iOS build.
26
27         * DumpRenderTree/mac/TestRunnerMac.mm:
28         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
29         Updated since I changed testRunner into a pointer instead of a reference.
30         Updated argument names to avoid conflict with field names.
31         (-[APITestDelegateIPhone run]): Ditto.
32         (-[APITestDelegateIPhone _cleanUp]): Ditto.
33
34 2014-05-06  Commit Queue  <commit-queue@webkit.org>
35
36         Unreviewed, rolling out r168304.
37         https://bugs.webkit.org/show_bug.cgi?id=132607
38
39         Broke the build (Requested by KaL on #webkit).
40
41         Reverted changeset:
42
43         "[GTK][CMake] Unable to do make install"
44         https://bugs.webkit.org/show_bug.cgi?id=130188
45         http://trac.webkit.org/changeset/168304
46
47 2014-05-04  Darin Adler  <darin@apple.com>
48
49         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
50         https://bugs.webkit.org/show_bug.cgi?id=80222
51
52         Reviewed by Alexey Proskuryakov.
53
54         * DumpRenderTree/mac/TestRunnerMac.mm:
55         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
56         do more work here so we don't use RetainPtr local variables.
57         (-[APITestDelegateIPhone dealloc]): Added.
58         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
59         created. Updated for changes to member names and types.
60         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
61         updated for changes to member names and types. Changed to two word spelling.
62         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
63         name of _cleanUp method.
64         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
65         Ditto.
66         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
67
68 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
69
70         Clean up Image Document and tweak the layout and viewport
71         https://bugs.webkit.org/show_bug.cgi?id=132552
72
73         Reviewed by Anders Carlsson.
74
75         * DumpRenderTree/mac/DumpRenderTree.mm:
76         (resetWebPreferencesToConsistentValues):
77         Update the default settings to have something consistent with WebKit2.
78
79 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
80
81         [GTK][CMake] Unable to do make install
82         https://bugs.webkit.org/show_bug.cgi?id=130188
83
84         Reviewed by Carlos Garcia Campos.
85
86         * Scripts/webkitdirs.pm:
87         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
88         will give an early signal that a change has broken the documentation.
89
90 2014-05-05  Pratik Solanki  <psolanki@apple.com>
91
92         Update framework locations in package-root
93         https://bugs.webkit.org/show_bug.cgi?id=132571
94
95         Reviewed by Simon Fraser.
96
97         * Scripts/package-root:
98
99 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
100
101         [EFL][WK2] Refactor favicon database APIs
102         https://bugs.webkit.org/show_bug.cgi?id=132519
103
104         Reviewed by Gyuyoung Kim.
105
106         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
107         (update_view_favicon):
108         (on_icon_changed_cb):
109         (window_free):
110         (on_url_changed):
111         (window_create):
112         (on_view_favicon_changed): Deleted.
113
114 2014-05-02  Mark Rowe  <mrowe@apple.com>
115
116         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
117
118         Reviewed by Dan Bernstein.
119
120         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
121         when determining which LLVM archive to extract.
122
123 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
124
125         Add Jeremy as a committer.
126         https://bugs.webkit.org/show_bug.cgi?id=132492
127
128         Reviewed by Jer Noble.
129
130         Add myself as a committer.
131
132         * Scripts/webkitpy/common/config/contributors.json:
133
134 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
135
136         Add Jeremy as a committer.
137         https://bugs.webkit.org/show_bug.cgi?id=132492
138
139         Reviewed by Jer Noble.
140
141         Add Jeremy Jones to the committers file.
142
143         * Scripts/webkitpy/common/config/contributors.json:
144
145 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
146
147         Hard to figure out how to run a single test with run-api-tests
148         https://bugs.webkit.org/show_bug.cgi?id=116332
149
150         Reviewed by Alexey Proskuryakov.
151
152         * Scripts/run-api-tests: add two examples to the help message.
153
154 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
155
156         Fix several memory leaks found by code inspection
157         https://bugs.webkit.org/show_bug.cgi?id=132472
158
159         Reviewed by Geoffrey Garen.
160         
161         Fix memory leaks.
162
163         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
164         (TestWebKitAPI::TEST):
165         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
166         (WTR::InjectedBundlePage::willSendRequestForFrame):
167         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
168         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
169
170 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
171
172         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
173         https://bugs.webkit.org/show_bug.cgi?id=132446
174
175         Reviewed by Mark Hahnenberg.
176         
177         Test the FTL by default now that it's enabled by default.
178
179         * Scripts/run-javascriptcore-tests:
180
181 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
182
183         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
184         https://bugs.webkit.org/show_bug.cgi?id=132240
185
186         Reviewed by Anders Carlsson.
187
188         Removed ewk_view_setting_tiled_backingstore related code.
189
190         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
191         (DumpRenderTreeChrome::createView):
192         (shouldUseTiledBackingStore): Deleted.
193         * EWebLauncher/main.c:
194         (windowCreate):
195         (parseUserArguments):
196
197 2014-05-01  Anders Carlsson  <andersca@apple.com>
198
199         window.testRunner.keepWebHistory() should update the UI process state
200         https://bugs.webkit.org/show_bug.cgi?id=132440
201
202         Reviewed by Dan Bernstein.
203
204         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
205         (WTR::InjectedBundle::postSetAddsVisitedLinks):
206         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
207         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
208         (WTR::TestRunner::keepWebHistory):
209         * WebKitTestRunner/TestInvocation.cpp:
210         (WTR::TestInvocation::invoke):
211         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
212
213 2014-05-01  David Kilzer  <ddkilzer@apple.com>
214
215         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
216         <http://webkit.org/b/132432>
217
218         Reviewed by Tim Horton.
219
220         * Scripts/webkitperl/FeatureList.pm: Remove support for
221         --plugin-proxy-for-video switch.
222
223 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
224
225         Kernel sysctl interface hw.activecpu don't exists on Linux.
226         https://bugs.webkit.org/show_bug.cgi?id=132286
227
228         Reviewed by Filip Pizlo.
229
230         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
231         calling sysctl over hw.activecpu
232
233 2014-04-30  Anders Carlsson  <andersca@apple.com>
234
235         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
236         https://bugs.webkit.org/show_bug.cgi?id=132399
237         <rdar://problem/15920046>
238
239         Reviewed by Dan Bernstein.
240
241         * Scripts/check-for-webkit-framework-include-consistency:
242         Allos WAK headers in WebKitLegacy as well as WebKit.
243
244         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
245         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
246         Update header imports.
247
248 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
249
250         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
251         https://bugs.webkit.org/show_bug.cgi?id=131954
252
253         Reviewed by Darin Adler.
254         
255         WebKitTestRunner was adding application-specific information to crash reports
256         to log the test path, but only in the web process. Fix it to also do this
257         for the UI process, for both iOS and OS X.
258         
259         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
260         both iOS and OS X.
261         
262         Factored crash reprorter-related code into CrashReporterInfo, and call it from
263         a new TestController::platformWillRunTest() function on Mac and iOS.
264         
265         Also remove Xcode-added unit test junk from the project.
266
267         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
268         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
269         * WebKitTestRunner/TestController.cpp:
270         (WTR::TestController::runTest):
271         * WebKitTestRunner/TestController.h:
272         * WebKitTestRunner/TestInvocation.cpp:
273         (WTR::TestInvocation::url):
274         * WebKitTestRunner/TestInvocation.h:
275         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
276         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
277         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
278         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
279         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
280         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
281         (WTR::testPathFromURL):
282         (WTR::setCrashReportApplicationSpecificInformationToURL):
283         * WebKitTestRunner/efl/TestControllerEfl.cpp:
284         (WTR::TestController::platformWillRunTest):
285         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
286         (WTR::TestController::platformWillRunTest):
287         * WebKitTestRunner/ios/TestControllerIOS.mm:
288         (WTR::TestController::platformWillRunTest):
289         (WTR::TestController::setHidden):
290         * WebKitTestRunner/mac/TestControllerMac.mm:
291         (WTR::TestController::platformWillRunTest):
292
293 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
294
295         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
296
297         Reviewed by Tim Horton.
298
299         * DumpRenderTree/mac/DumpRenderTree.mm:
300         (resetWebPreferencesToConsistentValues):
301         (prepareConsistentTestingEnvironment):
302
303 2014-04-30  Anders Carlsson  <andersca@apple.com>
304
305         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
306         https://bugs.webkit.org/show_bug.cgi?id=132397
307
308         Reviewed by Dan Bernstein.
309
310         * Scripts/check-for-inappropriate-macros-in-external-headers:
311
312 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
313
314         [GTK] Make it easier to run CMake for downstreams
315         https://bugs.webkit.org/show_bug.cgi?id=132370
316
317         Reviewed by Carlos Garcia Campos.
318
319         * Scripts/webkitdirs.pm:
320         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
321         the GTK+ port.
322
323 2014-04-29  Stephanie Lewis  <slewis@apple.com>
324
325         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
326         
327         Rubber stamped by Jessie Berlin.
328
329         JSON.pm was removed from our tools setup.
330
331         * Scripts/generate-coverage-data:
332
333 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
334
335         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
336         https://bugs.webkit.org/show_bug.cgi?id=112840
337
338         Rubber stamped by Geoffrey Garen.
339
340         * Scripts/build-jsc: Enable it on Mac.
341         * Scripts/build-webkit: Enable it on Mac.
342         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
343
344 2014-04-28  Sam Weinig  <sam@webkit.org>
345
346         REGRESSION (r167751): svn-create-patch is very slow
347         https://bugs.webkit.org/show_bug.cgi?id=132300
348
349         Reviewed by Alexey Proskuryakov.
350
351         * Scripts/svn-create-patch:
352         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
353         by calling `svn-create-patch --style`.
354
355 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
356
357         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
358         https://bugs.webkit.org/show_bug.cgi?id=132190
359
360         Reviewed by Gustavo Noronha Silva.
361
362         * Scripts/webkitdirs.pm:
363         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
364             if ninja is in the path.
365         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
366             to the previous ninja generator if not.
367
368 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
369
370         check-webkit-style should understand --git-index
371         https://bugs.webkit.org/show_bug.cgi?id=125364
372
373         Reviewed by Csaba Osztrogonác.
374
375         * Scripts/webkitpy/common/checkout/scm/git.py:
376         (Git.create_patch): The command now supports the --cached option.
377         * Scripts/webkitpy/style/main.py:
378         (CheckWebKitStyle.main): Passing the --git-index option.
379         * Scripts/webkitpy/style/optparser.py:
380         (CommandOptionValues.__init__): The git-index option is switched off by default.
381         (CommandOptionValues.__eq__): Equality check for the new option.
382         (ArgumentParser._create_option_parser):Adding the --git-index option
383         (ArgumentParser.parse):
384         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
385         (CommandOptionValuesTest.test_init): 
386         (CommandOptionValuesTest.test_eq):
387
388 2014-04-28  Michael Saboff  <msaboff@apple.com>
389
390         Crash in platform/mac/accessibility/table-visible-rows.html
391         https://bugs.webkit.org/show_bug.cgi?id=132146
392
393         Reviewed by Filip Pizlo.
394
395         Instead of creating a local JSValueRef array on the stack and passing that to
396         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
397         values using the JSObjectSetPropertyAtIndex() API.
398
399         * DumpRenderTree/AccessibilityUIElement.cpp:
400         (elementsForRangeCallback):
401         (convertElementsToObjectArray):
402         * DumpRenderTree/mac/TestRunnerMac.mm:
403         (originsArrayToJS):
404         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
405         (WTR::EventSendingController::contextClick):
406         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
407         (WTR::stringArrayToJS):
408         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
409         (WTR::convertElementsToObjectArray):
410
411 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
412
413         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
414         "no-cjit" runs force the old-school threshold.
415
416         Rubber stamped by Mark Hahnenberg.
417
418         * Scripts/run-jsc-stress-tests:
419
420 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
421
422         [GTK] install-dependencies should also install ruby-json and ruby-highline
423         https://bugs.webkit.org/show_bug.cgi?id=132292
424
425         Reviewed by Philippe Normand.
426
427         * gtk/install-dependencies: Install ruby json and highline packages.
428
429 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
430
431         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
432         https://bugs.webkit.org/show_bug.cgi?id=132176
433
434         Reviewed by Gyuyoung Kim.
435
436         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
437         and turn off indexedDB feature until the sqlite implementation is introduced.
438
439         * Scripts/webkitperl/FeatureList.pm:
440
441 2014-04-25  James Craig  <jcraig@apple.com>
442
443         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
444         https://bugs.webkit.org/show_bug.cgi?id=132209
445
446         Reviewed by Daniel Bates.
447
448         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
449         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
450
451         * Scripts/prepare-ChangeLog:
452         (main): 
453
454 2014-04-25  Michael Saboff  <msaboff@apple.com>
455
456         Crash in platform/mac/accessibility/table-visible-rows.html
457         https://bugs.webkit.org/show_bug.cgi?id=132146
458
459         Reviewed by Mark Lam.
460
461         Changed to use a local JSValueRef array temporary instead of a
462         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
463         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
464         the temporary values could be collected.
465
466         * DumpRenderTree/AccessibilityUIElement.cpp:
467         (convertElementsToObjectArray):
468         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
469         (WTR::EventSendingController::contextClick):
470         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
471         (WTR::convertElementsToObjectArray):
472
473 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
474
475         Unreviewed GTK gardening
476
477         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
478         (TestRunner):
479
480 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
481
482         prepare-ChangeLog reports as deleted methods that has not been removed.
483         https://bugs.webkit.org/show_bug.cgi?id=131733
484
485         Reviewed by Ryosuke Niwa.
486
487         * Scripts/prepare-ChangeLog:
488         (originalFile): Set merge base to origin/master by default.
489
490 2014-04-23  James Craig  <jcraig@apple.com>
491
492         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
493         https://bugs.webkit.org/show_bug.cgi?id=131115
494
495         Reviewed by Daniel Bates.
496
497         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
498
499         * Scripts/commit-log-editor: Added --no-style.
500         * Scripts/prepare-ChangeLog: Primary patch.
501         (main): Primary patch.
502         (createPatchCommand): Added --no-style.
503         * Scripts/svn-create-patch: Primary patch.
504         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
505         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
506         (SVN.create_patch): Added --no-style.
507
508 2014-04-23  Anders Carlsson  <andersca@apple.com>
509
510         Try to fix iOS build.
511
512         * DumpRenderTree/mac/DumpRenderTree.mm:
513
514 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
515
516         Eliminate internals.setMockScrollbarsEnabled()
517         https://bugs.webkit.org/show_bug.cgi?id=132085
518
519         Reviewed by Tim Horton.
520
521         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
522         No need to reset the preference, there is no way it can change.
523
524 2014-04-23  James Craig  <jcraig@apple.com>
525
526         Unreviewed. Moving myself from Contributors to Committers list.
527
528         * Scripts/webkitpy/common/config/contributors.json:
529
530 2014-04-23  Tim Horton  <timothy_horton@apple.com>
531
532         Mock scrollbars don't always work in DumpRenderTree
533         https://bugs.webkit.org/show_bug.cgi?id=132082
534
535         Reviewed by Alexey Proskuryakov.
536
537         * DumpRenderTree/mac/DumpRenderTree.mm:
538         (prepareConsistentTestingEnvironment):
539         Set the mock scrollbar setting before creating the WebView, as this setting
540         cannot be dynamically changed, so any scrollbars that are created during
541         WebView initialization and are not replaced before snapshotting will end
542         up being platform scrollbars instead of mock ones.
543         WebKitTestRunner already sets this preference before creating WKViews,
544         so we're just matching its behavior.
545
546 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
547
548         [GTK] ShadowRoot API was removed in r164131
549         https://bugs.webkit.org/show_bug.cgi?id=132059
550
551         Reviewed by Gustavo Noronha Silva.
552
553         Add WebKitDOMShadowRoot to the list of deleted classes to generate
554         the API docs.
555
556         * gtk/webkitdom.py:
557         (WebKitDOMDocGenerator):
558
559 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
560
561         [GTK] run-webkit-tests script is failing to invoke run-launcher
562         https://bugs.webkit.org/show_bug.cgi?id=132051
563
564         Reviewed by Philippe Normand.
565
566         After the WK1 support was dropped, if run-webkit-tests is executed
567         without --no-show-results parameter, the launcher is being called
568         using a -2 parameter that is it causing the run-launcher to break.
569
570         * Scripts/webkitpy/port/gtk.py:
571         (GtkPort.show_results_html_file):
572
573 2014-04-22  Tim Horton  <timothy_horton@apple.com>
574
575         DumpRenderTree generates black snapshots on some platforms
576         https://bugs.webkit.org/show_bug.cgi?id=132029
577         <rdar://problem/16679363>
578
579         Reviewed by Simon Fraser.
580
581         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
582         (createBitmapContextFromWebView):
583         DRT checks with the WebView to determine whether it can use the window's
584         backing store directly or (because of compositing) needs to take a WindowServer
585         snapshot. However, on some platforms and in some situations, the window can
586         be layer backed without the WebView necessarily currently being composited.
587         We should check with the window in addition to the WebView before going
588         ahead and using its backing store.
589
590 2014-04-22  Tim Horton  <timothy_horton@apple.com>
591
592         DumpRenderTree generates white snapshots on some platforms
593         https://bugs.webkit.org/show_bug.cgi?id=132026
594         <rdar://problem/16679363>
595
596         Reviewed by Simon Fraser.
597
598         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
599         Link DRT against QuartzCore.
600
601         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
602         (createBitmapContextFromWebView):
603         Force CoreAnimation to synchronously update layers in a more explicit
604         way that doesn't depend on AppKit behavior. This is very similar to what
605         WebKitTestRunner does (indirectly) during its force repaint.
606
607 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
608
609         [Win] Support Python 2.7 in Cygwin
610         https://bugs.webkit.org/show_bug.cgi?id=132023
611
612         Reviewed by Michael Saboff.
613
614         * Scripts/webkitdirs.pm:
615         (checkInstalledTools): Remove check for Python 2.7, since
616         it now works properly.
617
618 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
619
620         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
621         https://bugs.webkit.org/show_bug.cgi?id=130867
622         <rdar://problem/16432456> 
623
624         Reviewed by Mark Hahnenberg.
625
626         * Scripts/build-webkit:
627         * Scripts/copy-webkitlibraries-to-product-directory:
628
629 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
630
631         [GTK] Fails to build documentation when output is redirected
632         https://bugs.webkit.org/show_bug.cgi?id=131178
633
634         Reviewed by Martin Robinson.
635
636         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
637         explicitly to avoid encoding issues when they are redirected.
638
639 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
640
641         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
642         https://bugs.webkit.org/show_bug.cgi?id=131911
643
644         Reviewed by Martin Robinson.
645
646         common.get_build_path returns release path even though Debug configuration
647         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
648
649         * gtk/ycm_extra_conf.py:
650         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
651         (FlagsForFile):
652
653 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
654
655         Unreviewed build fix.
656
657         * DumpRenderTree/mac/EventSendingController.mm:
658         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
659         Correct a typo that prevented tests from working properly.
660
661 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
662
663         [GTK] Should have the ability to output composited contents during layout testing
664         https://bugs.webkit.org/show_bug.cgi?id=131864
665
666         Reviewed by Philippe Normand.
667
668         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
669         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
670         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
671         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
672         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
673
674 2014-04-21  Sam Weinig  <sam@webkit.org>
675
676         Attempt to fix the tests.
677
678         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
679         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
680         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
681
682 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
683
684         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
685         being the same as a "quick run", which is meant for genuinely slow tests).
686
687         * Scripts/run-jsc-stress-tests:
688
689 2014-04-21  Darin Adler  <darin@apple.com>
690
691         Add HashSet::takeAny
692         https://bugs.webkit.org/show_bug.cgi?id=131928
693
694         Reviewed by Benjamin Poulain.
695
696         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
697
698 2014-04-20  Dan Bernstein  <mitz@apple.com>
699
700         Fixed a test timing out after r167572.
701
702         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
703         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
704         -webView:didFinishLoadingNavigation:.
705
706 2014-04-20  Commit Queue  <commit-queue@webkit.org>
707
708         Unreviewed, rolling out r167510.
709         https://bugs.webkit.org/show_bug.cgi?id=131915
710
711         broke GTK Debug bot (Requested by philn on #webkit).
712
713         Reverted changeset:
714
715         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
716         it when running layout tests"
717         https://bugs.webkit.org/show_bug.cgi?id=131472
718         http://trac.webkit.org/changeset/167510
719
720 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
721
722         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
723         https://bugs.webkit.org/show_bug.cgi?id=131472
724
725         Reviewed by Philippe Normand.
726
727         * Scripts/webkitpy/port/gtk.py:
728         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
729         when running WebKitTestRunner with run-webkit-tests.
730         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
731         installed.
732         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
733         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
734         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
735         deal.
736
737 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
738
739         DownloadDecideDestinationCrash API test uses an incorrect value for path
740         https://bugs.webkit.org/show_bug.cgi?id=131845
741         <rdar://problem/15925560>
742
743         Reviewed by Enrica Casucci.
744
745         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
746         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
747
748 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
749
750         [Mac] AttributedStringTest API tests fail with async text input
751         https://bugs.webkit.org/show_bug.cgi?id=131833
752
753         Reviewed by Enrica Casucci.
754
755         Don't run sync NSTextInputClient tests where we don't implement these calls.
756
757         * TestWebKitAPI/Tests/mac/AttributedString.mm:
758         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
759         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
760         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
761         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
762         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
763         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
764
765 2014-04-18  Philippe Normand  <pnormand@igalia.com>
766
767         Remove NETWORK_INFO support
768         https://bugs.webkit.org/show_bug.cgi?id=131841
769
770         Reviewed by Gyuyoung Kim.
771
772         * Scripts/webkitperl/FeatureList.pm:
773
774 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
775
776         [GTK] YouCompleteMe doesn't work for cmake build system.
777         https://bugs.webkit.org/show_bug.cgi?id=131591
778
779         Reviewed by Martin Robinson.
780
781         Add cmake build system support for YouCompleteMe. It should work regardless of
782         using make or ninja. In addition, autotools related code is removed since it's
783         not used anymore in WebKit.
784
785         * Scripts/webkitdirs.pm:
786         (generateBuildSystemFromCMakeProject):
787         * gtk/ycm_extra_conf.py:
788         (transform_relative_paths_to_absolute_paths):
789         (FlagsForFile):
790
791 2014-04-17  Anders Carlsson  <andersca@apple.com>
792
793         Fix build.
794
795         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
796         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
797         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
798
799 2014-04-17  Anders Carlsson  <andersca@apple.com>
800
801         Remove unused API enums
802         https://bugs.webkit.org/show_bug.cgi?id=131836
803
804         Reviewed by Tim Horton.
805
806         * MiniBrowser/mac/WK2BrowserWindowController.m:
807         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
808
809 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
810
811         [Win] A few final cleanups to the DataObject classes.
812         https://bugs.webkit.org/show_bug.cgi?id=131784
813
814         Reviewed by Anders Carlsson.
815
816         * DumpRenderTree/win/DRTDataObject.cpp:
817         (DRTDataObject::clearData): Use 'last()' method.
818         * DumpRenderTree/win/UIDelegate.cpp:
819         (DRTUndoStack::pop): Use 'takeLast()' method.
820
821 2014-04-17  Andres Gomez  <agomez@igalia.com>
822
823         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
824         https://bugs.webkit.org/show_bug.cgi?id=131365
825
826         Reviewed by Brent Fulgham.
827
828         The cygwin installer is now downloading the wanted versions for
829         the local installation given to the setup wizard.
830
831         * CygwinDownloader/cygwin-downloader.py:
832         * CygwinDownloader/cygwin-downloader.zip:
833
834 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
835
836         [GTK] Make run-webkit-tests always use WKTR
837         https://bugs.webkit.org/show_bug.cgi?id=131737
838
839         Reviewed by Darin Adler.
840
841         Now that the GTK+ port only has support for WebKit2, instruct
842         run-webkit-tests to always use WKTR. This avoids needing to pass
843         flag "-2" every time.
844
845         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
846         (_set_up_derived_options): Always set webkit_test_runner when
847         the platform is GTK+.
848
849 2014-04-17  Brendan Long  <b.long@cablelabs.com>
850
851         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
852         https://bugs.webkit.org/show_bug.cgi?id=131760
853
854         Reviewed by Philippe Normand.
855
856         * gtk/install-dependencies: Install ninja-build when it's available.
857
858 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
859
860         [Win] run-javascriptcore-tests fails to run.
861         https://bugs.webkit.org/show_bug.cgi?id=131761
862
863         Reviewed by Brent Fulgham.
864
865         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
866
867 2014-04-16  Andres Gomez  <agomez@igalia.com>
868
869         [Win] Pass default parameters to cygwin setup wizard
870         https://bugs.webkit.org/show_bug.cgi?id=131361
871
872         Reviewed by Brent Fulgham.
873
874         Added some parameters to the cygwin setup wizard so the user
875         doesn't really have to do any interaction.
876
877         * CygwinDownloader/cygwin-downloader.py:
878         * CygwinDownloader/cygwin-downloader.zip:
879
880 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
881
882         [Win] Eliminate use of deleteAllValues in Windows Files
883         https://bugs.webkit.org/show_bug.cgi?id=131631
884
885         Reviewed by Darin Adler.
886
887         Switch to std::unique_ptr for memory lifetime. Get rid of
888         deleteAllValues now that it is no longer needed. Use ranged
889         for loops where possible.
890
891         * DumpRenderTree/win/DRTDataObject.cpp:
892         (WCEnumFormatEtc::WCEnumFormatEtc):
893         (DRTDataObject::~DRTDataObject):
894         (DRTDataObject::GetData):
895         (DRTDataObject::QueryGetData):
896         (DRTDataObject::SetData):
897         (DRTDataObject::clearData):
898         * DumpRenderTree/win/DRTDataObject.h:
899         * DumpRenderTree/win/UIDelegate.cpp:
900         (DRTUndoObject::DRTUndoObject):
901         (DRTUndoObject::~DRTUndoObject):
902         (DRTUndoStack::~DRTUndoStack):
903         (DRTUndoStack::clear):
904         (DRTUndoStack::pop):
905         (DRTUndoManager::DRTUndoManager):
906         (DRTUndoManager::redo):
907         (DRTUndoManager::undo):
908         (UIDelegate::UIDelegate):
909         (UIDelegate::resetUndoManager):
910         * DumpRenderTree/win/UIDelegate.h:
911
912 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
913
914         [GTK] Unreviewed GTK gardening.
915
916         Update list of skipped unit tests:
917
918           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
919
920           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
921           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
922
923         * Scripts/run-gtk-tests:
924         (TestRunner):
925
926 2014-04-16  Tim Horton  <timothy_horton@apple.com>
927
928         check-webkit-style doesn't check code style in .mm or .m files
929         https://bugs.webkit.org/show_bug.cgi?id=131708
930
931         Reviewed by Darin Adler.
932
933         * Scripts/webkitpy/style/checker.py:
934         * Scripts/webkitpy/style/checker_unittest.py:
935         (CheckerDispatcherDispatchTest.test_cpp_paths):
936         (CheckerDispatcherDispatchTest.test_text_paths):
937         Check .mm and .m files as C++.
938
939         * Scripts/webkitpy/style/checkers/cpp.py:
940         (check_spacing):
941         Add an override for our ordinary "missing spaces around =" for @synthesize,
942         which should look like "@synthesize propertyName=_varName;"
943
944         Add an override for "missing space before {" for blocks' "^{".
945
946         Don't follow the "extra space before [" rule for Objective-C, because
947         it breaks this rule in a multitude of ways because of method calls.
948
949         (check_braces):
950         Don't complain about { not being on the end of the previous line if
951         the previous line starts with "- (" or "+ (", which would indicate a
952         Objective-C method definition.
953
954 2014-04-16  Darin Adler  <darin@apple.com>
955
956         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
957         https://bugs.webkit.org/show_bug.cgi?id=131735
958
959         Reviewed by Alexey Proskuryakov.
960
961         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
962         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
963         is on the right. This can be confusing since our JavaScript test framework does it the opposite
964         way, but gtest works better this way.
965
966 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
967
968         [EFL] Fix problems with the pixel dump.
969         https://bugs.webkit.org/show_bug.cgi?id=131265
970
971         Reviewed by Gyuyoung Kim.
972
973         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
974         However pixel dump codes still call deprecated functions like ewk_view_paint(),
975         which causes that nothing is drawn.
976
977         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
978         One of new functions is AcceleratedCompositingContext::extractImageData(),
979         which replaces deprecated function calls. Besides the extractImageData() is invoked by
980         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
981
982         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
983         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
984
985 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
986
987         Update LLVM export scrpt to handle the build directory being different from the
988         source directory.
989
990         Rubber stamped by Geoffrey Garen.
991
992         * Scripts/export-llvm-build:
993
994 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
995
996         Update the hyperlink to waterfall views of perf bots on build.webkit.org
997         https://bugs.webkit.org/show_bug.cgi?id=131695
998
999         Reviewed by Antti Koivisto.
1000
1001         Updated.
1002
1003         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1004
1005 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1006
1007         [GTK] Reduce the binary size by compressing the text based web inspector resources
1008         https://bugs.webkit.org/show_bug.cgi?id=121545
1009
1010         Reviewed by Gustavo Noronha Silva.
1011
1012         Compress text based files when compiling inspector resources. It
1013         reduces the binary size in 3MB.
1014
1015         * gtk/generate-inspector-gresource-manifest.py:
1016         (find_all_files_in_directory):
1017         (is_compressible):
1018
1019 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1020
1021         Remove Gtk WebKit1 tester.
1022
1023         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
1024         results over and over as fast as it could.
1025
1026         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1027         (WebKitBuildbot):
1028
1029 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1030
1031         Wrong link for webkitpy tests results in dashboard popover
1032         https://bugs.webkit.org/show_bug.cgi?id=131664
1033
1034         Reviewed by Timothy Hatcher.
1035
1036         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1037         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
1038         Use a correct link.
1039
1040 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
1041
1042         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
1043
1044         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
1045
1046         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1047         (CommitMessageForThisCommitTest):
1048
1049 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1050
1051         Fix commit-log-editor bug revealed by r165447
1052         https://bugs.webkit.org/show_bug.cgi?id=130676
1053
1054         Reviewed by Csaba Osztrogonác.
1055
1056         * Scripts/commit-log-editor:
1057         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
1058         Add \n before the first block too, because the longest common prefix now ends with only one newline.
1059         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
1060         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
1061
1062 2014-04-13  Darin Adler  <darin@apple.com>
1063
1064         userVisibleString should not try to "encode" host names
1065         https://bugs.webkit.org/show_bug.cgi?id=131587
1066         rdar://problem/14686849
1067
1068         Reviewed by Alexey Proskuryakov.
1069
1070         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
1071
1072         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
1073         Coverage is tiny at this point; we could add a lot more cases!
1074
1075 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
1076
1077         Use #include instead of #import
1078         https://bugs.webkit.org/show_bug.cgi?id=131604
1079
1080         Reviewed by Darin Adler.
1081
1082         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
1083
1084         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1085
1086 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
1087
1088         Make slow-stress tests run faster by running fewer VM variants.
1089
1090         Rubber stamped by Geoffrey Garen.
1091
1092         * Scripts/run-javascriptcore-tests:
1093         * Scripts/run-jsc-stress-tests:
1094
1095 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
1096
1097         [CMake] Add missing WTF unit tests
1098         https://bugs.webkit.org/show_bug.cgi?id=131459
1099
1100         Reviewed by Martin Robinson.
1101
1102         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
1103         that should be compiled into the TestWTF binary.
1104
1105 2014-04-10  Brendan Long  <b.long@cablelabs.com>
1106
1107         [Gtk] run-launcher doesn't work by default
1108         https://bugs.webkit.org/show_bug.cgi?id=131494
1109
1110         Reviewed by Philippe Normand.
1111
1112         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
1113         * Scripts/webkitdirs.pm:
1114         (launcherName): Same.
1115         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
1116         * gtk/common.py:
1117         (get_build_path.is_valid_build_directory): Same.
1118         * gtk/manifest.txt: Same.
1119
1120 2014-04-09  Commit Queue  <commit-queue@webkit.org>
1121
1122         Unreviewed, rolling out r167046.
1123         https://bugs.webkit.org/show_bug.cgi?id=131479
1124
1125         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
1126         on #webkit).
1127
1128         Reverted changeset:
1129
1130         "Remove "System Font" from whitelisted DRT fonts and char
1131         width calculations"
1132         https://bugs.webkit.org/show_bug.cgi?id=131411
1133         http://trac.webkit.org/changeset/167046
1134
1135 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1136
1137         Remove "System Font" from whitelisted DRT fonts and char width calculations
1138         https://bugs.webkit.org/show_bug.cgi?id=131411
1139
1140         Reviewed by Tim Horton.
1141
1142         Covered by existing tests.
1143
1144         * DumpRenderTree/mac/DumpRenderTree.mm:
1145         (allowedFontFamilySet):
1146
1147 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1148
1149         systemHiddenFontFamilySet in DRT is unnecessary
1150         https://bugs.webkit.org/show_bug.cgi?id=131414
1151
1152         Reviewed by Tim Horton.
1153
1154         It doesn't seem to affect test results on my machine.
1155
1156         * DumpRenderTree/mac/DumpRenderTree.mm:
1157         (drt_NSFontManager_availableFonts):
1158         (systemHiddenFontFamilySet): Deleted.
1159
1160 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1161
1162         [Win] Unreviewed test fix: Don't double-release BSTR.
1163
1164         * DumpRenderTree/win/DumpRenderTree.cpp:
1165         (dump): Remove unneeded call to SysFreeString now that we are
1166         using _bstr_t for this variable.
1167
1168 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1169
1170         [Win] Various DumpRenderTree Fixes.
1171         https://bugs.webkit.org/show_bug.cgi?id=131446.
1172
1173         Reviewed by Tim Horton.
1174
1175         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1176         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1177         (AccessibilityUIElement::description): Ditto.
1178         (AccessibilityUIElement::helpText): Ditto.
1179         (AccessibilityUIElement::intValue): Ditto.
1180         (AccessibilityUIElement::isPressActionSupported): Ditto.
1181         (AccessibilityUIElement::accessibilityValue): Ditto.
1182         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1183         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1184         (DRTDesktopNotificationPresenter::AddRef): Ditto.
1185         (DRTDesktopNotificationPresenter::Release): Ditto.
1186         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1187         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
1188         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
1189         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
1190         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
1191         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1192         * DumpRenderTree/win/DumpRenderTree.cpp:
1193         (dumpFrameScrollPosition): Ditto.
1194         (dumpFramesAsText): Ditto.
1195         (compareHistoryItems): Ditto.
1196         (dumpHistoryItem): Ditto.
1197         (dump): Ditto.
1198         (resetDefaultsToConsistentValues): Ditto.
1199         (resetWebViewToConsistentStateBeforeTesting): Ditto.
1200         (runTest): Ditto.
1201         (createWebViewAndOffscreenWindow): Ditto.
1202         * DumpRenderTree/win/EditingDelegate.cpp:
1203         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1204         (EditingDelegate::AddRef): Ditto.
1205         (EditingDelegate::Release): Ditto.
1206         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
1207         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
1208         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1209         (EditingDelegate::shouldInsertNode): Ditto.
1210         (EditingDelegate::shouldInsertText): Ditto.
1211         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1212         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1213         (EditingDelegate::shouldApplyStyle): Ditto.
1214         (EditingDelegate::shouldChangeTypingStyle): Ditto.
1215         (EditingDelegate::doPlatformCommand): Ditto.
1216         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1217         (EditingDelegate::webViewDidChange): Ditto.
1218         (EditingDelegate::webViewDidEndEditing): Ditto.
1219         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
1220         (EditingDelegate::webViewDidChangeSelection): Ditto.
1221         (EditingDelegate::checkSpellingOfString): Ditto.
1222         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1223         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1224         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
1225         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1226         (FrameLoadDelegate::AddRef): Ditto.
1227         (FrameLoadDelegate::Release): Ditto.
1228         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1229         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
1230         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
1231         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
1232         (FrameLoadDelegate::didReceiveTitle): Ditto.
1233         (FrameLoadDelegate::didChangeIcons): Ditto.
1234         (delegatesWithDelayedWork): Ditto.
1235         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
1236         (FrameLoadDelegate::didFailLoadWithError): Ditto.
1237         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
1238         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
1239         (FrameLoadDelegate::willCloseFrame): Ditto.
1240         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
1241         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
1242         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1243         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
1244         (FrameLoadDelegate::didRunInsecureContent): Ditto.
1245         * DumpRenderTree/win/FrameLoadDelegate.h:
1246         * DumpRenderTree/win/HistoryDelegate.cpp:
1247         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1248         (HistoryDelegate::updateHistoryTitle): Ditto.
1249         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
1250         * DumpRenderTree/win/PolicyDelegate.cpp:
1251         (dumpPath):
1252         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1253         (PolicyDelegate::AddRef): Ditto.
1254         (PolicyDelegate::Release): Ditto.
1255         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1256         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
1257         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1258         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1259         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1260         (ResourceLoadDelegate::AddRef): Ditto.
1261         (ResourceLoadDelegate::Release): Ditto.
1262         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1263         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
1264         (ResourceLoadDelegate::willSendRequest): Ditto.
1265         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
1266         (ResourceLoadDelegate::didReceiveResponse): Ditto.
1267         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
1268         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
1269         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1270         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1271         (TestRunner::setUserStyleSheetLocation): Ditto.
1272         (TestRunner::execCommand): Ditto.
1273         (TestRunner::overridePreference): Ditto.
1274         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
1275         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
1276         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1277         (TextInputController::insertText): Ditto.
1278         * DumpRenderTree/win/UIDelegate.cpp:
1279         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1280         (UIDelegate::AddRef): Ditto.
1281         (UIDelegate::Release): Ditto.
1282         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1283         (UIDelegate::trackCustomPopupMenu): Ditto.
1284         (UIDelegate::registerUndoWithTarget): Ditto.
1285         (UIDelegate::removeAllActionsWithTarget): Ditto.
1286         (UIDelegate::setActionTitle): Ditto.
1287         (UIDelegate::undo): Ditto.
1288         (UIDelegate::redo): Ditto.
1289         (UIDelegate::canUndo): Ditto.
1290         (UIDelegate::canRedo): Ditto.
1291         (UIDelegate::printFrame): Ditto.
1292         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
1293         (UIDelegate::webViewHeaderHeight): Ditto.
1294         (UIDelegate::webViewFooterHeight): Ditto.
1295         (UIDelegate::drawHeaderInRect): Ditto.
1296         (UIDelegate::drawFooterInRect): Ditto.
1297         (UIDelegate::webViewPrintingMarginRect): Ditto.
1298         (UIDelegate::canRunModal): Ditto.
1299         (UIDelegate::createModalDialog): Ditto.
1300         (UIDelegate::runModal): Ditto.
1301         (UIDelegate::isMenuBarVisible): Ditto.
1302         (UIDelegate::setMenuBarVisible): Ditto.
1303         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
1304         (UIDelegate::paintCustomScrollbar): Ditto.
1305         (UIDelegate::paintCustomScrollCorner): Ditto.
1306         (UIDelegate::setFrame): Ditto.
1307         (UIDelegate::webViewFrame): Ditto.
1308         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
1309         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1310         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1311         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1312         (UIDelegate::webViewAddMessageToConsole): Ditto.
1313         (UIDelegate::doDragDrop): Ditto.
1314         (UIDelegate::webViewGetDlgCode): Ditto.
1315         (UIDelegate::createWebViewWithRequest): Ditto.
1316         (UIDelegate::webViewClose): Ditto.
1317         (UIDelegate::webViewFocus): Ditto.
1318         (UIDelegate::webViewUnfocus): Ditto.
1319         (UIDelegate::webViewPainted): Ditto.
1320         (UIDelegate::exceededDatabaseQuota): Ditto.
1321         (UIDelegate::embeddedViewWithArguments): Ditto.
1322         (UIDelegate::webViewClosing): Ditto.
1323         (UIDelegate::webViewSetCursor): Ditto.
1324         (UIDelegate::webViewDidInvalidate): Ditto.
1325         (UIDelegate::setStatusText): Ditto.
1326         (UIDelegate::desktopNotificationsDelegate): Ditto.
1327         (UIDelegate::drawBackground): Ditto.
1328         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
1329         (UIDelegate::didPressMissingPluginButton): Ditto.
1330         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
1331         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
1332         (LoadHTMLStringItem::invoke): Ditto.
1333         (ScriptItem::invoke): Ditto.
1334
1335 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1336
1337         Stylechecker: False positive on inline asm code.
1338         https://bugs.webkit.org/show_bug.cgi?id=130570
1339
1340         Reviewed by Csaba Osztrogonác.
1341
1342         Disable stylechecking in asm blocks.
1343
1344         * Scripts/webkitpy/style/checkers/cpp.py:
1345         (process_line):
1346         (_InlineASMState):
1347         (_InlineASMState.__init__):
1348         (_InlineASMState.process_line):
1349         (_InlineASMState.isInside):
1350         (_process_lines):
1351         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1352         (WebKitStyleTest.test_member_initialization_list):
1353
1354 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1355
1356         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
1357         https://bugs.webkit.org/show_bug.cgi?id=131029
1358
1359         Reviewed by Philippe Normand.
1360
1361         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
1362         tests and remove the getWebKit1TestResoucesDir() method.
1363
1364         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1365         (testDownloadLocalFile): Use Test::getResourcesDir().
1366         (testDownloadLocalFileError): Ditto.
1367         (serverCallback): Ditto.
1368         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1369         (serverCallback): Ditto.
1370         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1371         (httpServerCallback): Ditto.
1372         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1373         (serverCallback): Ditto.
1374         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
1375         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
1376         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1377         (Test::getWebKit1TestResoucesDir): Deleted.
1378
1379 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
1380
1381         [WK2] HTTP authentication regression tests fail
1382         https://bugs.webkit.org/show_bug.cgi?id=81627
1383         <rdar://problem/11079296>
1384
1385         Reviewed by Anders Carlsson.
1386
1387         * WebKitTestRunner/TestController.h:
1388         * WebKitTestRunner/TestController.cpp:
1389         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
1390         to pageLoaderClient structure.
1391         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
1392         for password based authentication (we do get server trust challenges on some tests,
1393         which WKTR can't handle).
1394         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
1395         calls won't be made, at least on CFNetwork based platforms.
1396         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
1397         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
1398         make sense to associate auth requests with individual resources - there can be
1399         multiple resources loading at once from the same protection space, so WebKit1 API
1400         that had a resource identifier was inherently racy.
1401
1402 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
1403
1404         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
1405         https://bugs.webkit.org/show_bug.cgi?id=131427
1406
1407         Reviewed by Gyuyoung Kim.
1408
1409         Since r166973, font path was changed.
1410
1411         * DumpRenderTree/PlatformEfl.cmake:
1412         * WebKitTestRunner/PlatformEfl.cmake:
1413
1414 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1415
1416         Fix the build-jsc build
1417         https://bugs.webkit.org/show_bug.cgi?id=131410
1418
1419         Reviewed by Michael Saboff.
1420
1421         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
1422         WTF depends on it.
1423
1424 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1425
1426         [GTK] Remove WebKit1 unit tests
1427         https://bugs.webkit.org/show_bug.cgi?id=131359
1428
1429         Reviewed by Anders Carlsson.
1430
1431         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
1432         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
1433         they were inadvertently left in http://trac.webkit.org/changeset/166504.
1434
1435         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
1436         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
1437         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
1438         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
1439         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
1440         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
1441         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
1442         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
1443         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
1444         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
1445         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
1446         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
1447         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
1448         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
1449         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
1450         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
1451         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
1452         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
1453         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
1454         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
1455         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
1456         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
1457         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
1458         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
1459         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
1460         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
1461         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
1462         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
1463         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
1464         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
1465         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
1466         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
1467         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
1468         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
1469         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
1470         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
1471         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
1472         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
1473
1474 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1475
1476         Unreviewed gardening (Take 2): Prevent users from attempting
1477         to build with known invalid cURL. 
1478
1479         * Scripts/webkitdirs.pm:
1480         (checkInstalledTools): Check for 7.34.0 (the broken version), not
1481         7.33.0 (the known good version).
1482
1483 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1484
1485         [GTK] Remove DumpRenderTree and GtkLauncher
1486         https://bugs.webkit.org/show_bug.cgi?id=131373
1487
1488         Reviewed by Andreas Kling.
1489
1490         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
1491         no longer necessary now that WebKit1 GTK+ will be removed.
1492
1493         * CMakeLists.txt:
1494         * DumpRenderTree/PlatformGTK.cmake: Removed.
1495         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
1496         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
1497         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
1498         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
1499         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
1500         * DumpRenderTree/gtk/EventSender.cpp: Removed.
1501         * DumpRenderTree/gtk/EventSender.h: Removed.
1502         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
1503         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
1504         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
1505         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
1506         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
1507         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
1508         * DumpRenderTree/gtk/TextInputController.h: Removed.
1509         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
1510         * GtkLauncher/CMakeLists.txt: Removed.
1511         * GtkLauncher/LauncherInspectorWindow.c: Removed.
1512         * GtkLauncher/LauncherInspectorWindow.h: Removed.
1513         * GtkLauncher/main.c: Removed.
1514         * GtkLauncher/simple.svg: Removed.
1515         * GtkLauncher/text.html: Removed.
1516         * WebKitTestRunner/PlatformGTK.cmake:
1517         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
1518         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
1519         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
1520
1521 2014-04-08  Mark Rowe  <mrowe@apple.com>
1522
1523         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
1524         <https://webkit.org/b/131388> / <rdar://problem/16291687>
1525
1526         Reviewed by Alexey Proskuryakov.
1527
1528         * Scripts/webkitdirs.pm:
1529         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
1530         (execMacWebKitAppForDebugging): Ditto.
1531
1532 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1533
1534         Build bmalloc on iOS too
1535         https://bugs.webkit.org/show_bug.cgi?id=131381
1536
1537         Reviewed by Andreas Kling.
1538
1539         * Scripts/build-webkit:
1540
1541 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1542
1543         Unreviewed gardening: Prevent users from attempting
1544         to build with known invalid cURL.
1545
1546         * Scripts/webkitdirs.pm:
1547         (checkInstalledTools): Block build attempts with bad
1548         Cygwin tool set.
1549
1550 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
1551
1552         Build bmalloc on Mac
1553         https://bugs.webkit.org/show_bug.cgi?id=131333
1554
1555         Reviewed by Mark Rowe.
1556
1557         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
1558         (Note: Just testing Mac is not good enough because in this
1559         script 'Mac' means 'Mac or iOS'.)
1560
1561 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
1562
1563         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
1564         https://bugs.webkit.org/show_bug.cgi?id=130951
1565
1566         Reviewed by Geoffrey Garen.
1567
1568         * Scripts/run-javascriptcore-tests:
1569
1570 2014-04-06  Darin Adler  <darin@apple.com>
1571
1572         Rework CSS calc logic, fixing some reference count mistakes in Length
1573         https://bugs.webkit.org/show_bug.cgi?id=131280
1574
1575         Reviewed by Andreas Kling.
1576
1577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
1578         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
1579
1580 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
1581
1582         Enable WEB_REPLAY for PLATFORM(MAC)
1583         https://bugs.webkit.org/show_bug.cgi?id=130700
1584
1585         Reviewed by Timothy Hatcher.
1586
1587         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
1588
1589 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1590
1591         [CMake] Include X11's include dirs in TestNetscapePlugin
1592         https://bugs.webkit.org/show_bug.cgi?id=131270
1593
1594         Reviewed by Martin Robinson.
1595
1596         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
1597         TestNetscapePlugin includes WebCore code that includes X headers.
1598
1599 2014-04-05  David Kilzer  <ddkilzer@apple.com>
1600
1601         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
1602         <http://webkit.org/b/130986>
1603
1604         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
1605         prefix to TileCache class names in exception list.
1606
1607 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1608
1609         [GTK] kill-old-processes should kill dbus-daemon processes
1610         https://bugs.webkit.org/show_bug.cgi?id=127352
1611
1612         Reviewed by Martin Robinson.
1613
1614         * BuildSlaveSupport/kill-old-processes:
1615         (main):
1616
1617 2014-04-04  Andres Gomez  <agomez@igalia.com>
1618
1619         [Win] Update obsolete packages in cygwin
1620         https://bugs.webkit.org/show_bug.cgi?id=126264
1621
1622         Reviewed by Brent Fulgham.
1623
1624         Removed "apache" and "minires" as the first has been replaced by
1625         "lighttpd" and the second is now integrated into
1626         "cygwin". Replaced the transitional and now obsolete "gcc" package
1627         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
1628         since the newer version available is "2.7.3" which breaks the
1629         build due to some funniness with environment variable handling.
1630
1631         * CygwinDownloader/cygwin-downloader.py:
1632         * CygwinDownloader/cygwin-downloader.zip:
1633
1634 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
1635
1636         check-webkit-style: Improve warnings on Objective-C @property syntax
1637         https://bugs.webkit.org/show_bug.cgi?id=131200
1638
1639         Reviewed by Dan Bernstein.
1640
1641         * Scripts/webkitpy/style/checkers/cpp.py:
1642         (check_spacing):
1643         (CppChecker):
1644         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1645         (CppStyleTest.test_spacing_in_objective_c_properties):
1646
1647 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1648
1649         Unreviewed. Moving my name to commiter section
1650
1651         * Scripts/webkitpy/common/config/contributors.json:
1652
1653 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1654
1655         Unreviewed. Add myself as a committer.
1656
1657         * Scripts/webkitpy/common/config/contributors.json:
1658
1659 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
1660
1661         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
1662         https://bugs.webkit.org/show_bug.cgi?id=130391
1663
1664         Reviewed by Gyuyoung Kim.
1665
1666         Change the implementation of the zoom functionality from ewk_view_scale_set
1667         to ewk_view_page_zoom_set.
1668
1669         * MiniBrowser/efl/main.c:
1670
1671 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1672
1673         [webkitpy] perf profiler does not understand --call-graph argument
1674         https://bugs.webkit.org/show_bug.cgi?id=131132
1675
1676         Reviewed by Ryosuke Niwa.
1677
1678         New versions of perf profiler have changed the argument from --call-graph to -g.
1679
1680         * Scripts/webkitpy/common/system/profiler.py:
1681         (Perf.wrapper_arguments): Use -g instead of --call-graph.
1682         * Scripts/webkitpy/port/driver_unittest.py:
1683         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
1684
1685 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1686
1687         Add EFL WK2 performance bot to build.webkit.org
1688         https://bugs.webkit.org/show_bug.cgi?id=131034
1689
1690         Fix after r166707, use "Perf" instead of "perf" for consistency.
1691
1692         Reviewed by Csaba Osztrogonác.
1693
1694         * BuildSlaveSupport/build.webkit.org-config/config.json:
1695
1696 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1697
1698         Add EFL WK2 performance bot to build.webkit.org
1699         https://bugs.webkit.org/show_bug.cgi?id=131034
1700
1701         Reviewed by Csaba Osztrogonác.
1702
1703         * BuildSlaveSupport/build.webkit.org-config/config.json:
1704
1705 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
1706
1707         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
1708         https://bugs.webkit.org/show_bug.cgi?id=131151
1709
1710         Reviewed by Gyuyoung Kim.
1711
1712         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
1713         (TouchEventInfo::TouchEventInfo):
1714         (sendTouchEvent):
1715         (addTouchPointCallback):
1716         (updateTouchPointCallback):
1717         (cancelTouchPointCallback):
1718         (releaseTouchPointCallback):
1719
1720 2014-04-02  David Kilzer  <ddkilzer@apple.com>
1721
1722         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
1723         <http://webkit.org/b/131045>
1724
1725         Reviewed by Daniel Bates.
1726
1727         * Scripts/filter-build-webkit:
1728         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
1729         of clang, plus debug data for all DVTAssertions.
1730
1731 2014-04-01  Dean Jackson  <dino@apple.com>
1732
1733         Load Media Controls js/css from bundle
1734         https://bugs.webkit.org/show_bug.cgi?id=131086
1735
1736         Reviewed by Eric Carlson.
1737
1738         We're now putting CSS files into the bundle, so remove the test for them.
1739
1740         * Scripts/check-for-inappropriate-files-in-framework:
1741
1742 2014-04-02  Martin Hock  <mhock@apple.com>
1743
1744         Unify private browsing with sessions.
1745         https://bugs.webkit.org/show_bug.cgi?id=130099
1746
1747         Reviewed by Alexey Proskuryakov.
1748
1749         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
1750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1751         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1752         (TestWebKitAPI::didNavigateWithNavigationData):
1753         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1754         (TestWebKitAPI::TEST):
1755
1756         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
1757         (TestWebKitAPI::didNavigateWithoutNavigationData):
1758         (TestWebKitAPI::didNavigateWithNavigationData):
1759         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1760         (TestWebKitAPI::TEST):
1761
1762 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
1763
1764         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
1765         https://bugs.webkit.org/show_bug.cgi?id=130343
1766
1767         Reviewed by Gustavo Noronha Silva.
1768
1769         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
1770         of directories on the command line and look for all appropriate files in those directories for the
1771         GResource archive. Also make archive paths relative to those directories.
1772         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
1773         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
1774
1775 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1776
1777         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
1778         https://bugs.webkit.org/show_bug.cgi?id=131106
1779
1780         Reviewed by Csaba Osztrogonác.
1781
1782         * Scripts/webkitpy/tool/commands/download.py:
1783         (AbstractRolloutPrepCommand._prepare_state):
1784         * Scripts/webkitpy/tool/commands/download_unittest.py:
1785         (test_prepare_rollout):
1786         (test_create_rollout):
1787         (test_create_rollout_resolved):
1788         (test_rollout):
1789
1790 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
1791
1792         [EFL] Add option to use separate web process for new window in MiniBrowser
1793         https://bugs.webkit.org/show_bug.cgi?id=130190
1794
1795         Reviewed by Gyuyoung Kim.
1796
1797         New created window (CTRL + n) will be open in separated web process.
1798         This option is enabled by adding a flag (S/separate-process) with launching
1799         MiniBrowser.
1800
1801         * MiniBrowser/efl/main.c:
1802         (elm_main):
1803
1804 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1805
1806         [GTK] Move NEWS file to a new location
1807         https://bugs.webkit.org/show_bug.cgi?id=130901
1808
1809         Reviewed by Brent Fulgham.
1810
1811         * gtk/manifest.txt: Update the NEWS file path.
1812
1813 2014-04-01  Anders Carlsson  <andersca@apple.com>
1814
1815         Fix build.
1816
1817         * MiniBrowser/mac/WK2BrowserWindowController.m:
1818         (-[WK2BrowserWindowController awakeFromNib]):
1819         (-[WK2BrowserWindowController dealloc]):
1820         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1821
1822 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
1823
1824         Unreviewed test gardening.
1825
1826         * Scripts/webkitpy/port/base_unittest.py:
1827         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
1828
1829 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
1830
1831         [CSS Exclusions] Remove exclusions parsing support
1832         https://bugs.webkit.org/show_bug.cgi?id=131046
1833
1834         Reviewed by David Hyatt.
1835
1836         * Scripts/webkitperl/FeatureList.pm:
1837
1838 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1839
1840         [GTK] Remove last reference to GTK+ WK1 EWS
1841         https://bugs.webkit.org/show_bug.cgi?id=131058
1842
1843         Reviewed by Martin Robinson.
1844
1845         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
1846
1847         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
1848
1849 2014-04-01  Lucas Forschler  <lforschler@apple.com>
1850
1851         Add a 32bit JSC builder/tester.
1852         https://bugs.webkit.org/show_bug.cgi?id=131054
1853         
1854         Reviewed by Michael Saboff.
1855
1856         * BuildSlaveSupport/build.webkit.org-config/config.json:
1857         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1858         (Compile32bitJSC):
1859         (Run32bitJSCTests):
1860         (Run32bitJSCTests.countFailures):
1861         (BuildAndTest32bitJSCFactory):
1862         (BuildAndTest32bitJSCFactory.__init__):
1863
1864 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
1865
1866         [GTK] No longer build WebKit1 gtkdoc
1867         https://bugs.webkit.org/show_bug.cgi?id=130970
1868
1869         Reviewed by Anders Carlsson.
1870
1871         * gtk/common.py:
1872         (gtk_version_of_pkg_config_file): Deleted.
1873         * gtk/generate-gtkdoc:
1874         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
1875         was only applicable for WebKit1.
1876         (get_generator_for_config): No longer look for the WebKit1 configuration file.
1877
1878 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
1879
1880         [GTK] Running minibrowser with url crashes in debug build
1881         https://bugs.webkit.org/show_bug.cgi?id=130492
1882
1883         Reviewed by Martin Robinson.
1884
1885         Update "uri-scheme" test not to use invalid URIs in it, so we
1886         don't get a mistmatch when comparing the original URI stored in
1887         the test class with the one returned by the WebKitWebView.
1888
1889         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1890         (testWebContextURIScheme): Update the test.
1891
1892 2014-04-01  Mihai Tica  <mitica@adobe.com>
1893
1894         Unreviewed: Add myself as a commiter to the contributors list.
1895
1896         * Scripts/webkitpy/common/config/contributors.json:
1897
1898 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
1899
1900         [EFL][WK2] Extract the control of page background out of color_set
1901         https://bugs.webkit.org/show_bug.cgi?id=127539
1902
1903         Reviewed by Gyuyoung Kim.
1904
1905         Added an option(C) to change background color.
1906
1907         * MiniBrowser/efl/main.c:
1908         (window_create):
1909         (elm_main):
1910
1911 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
1912
1913         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
1914
1915         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
1916
1917 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
1918
1919         Unreviewed test correction after r166530.
1920
1921         * DumpRenderTree/mac/DumpRenderTree.mm:
1922         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
1923         fine-grained setting for swipe tests. This prevents existing tests from breaking.
1924
1925 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1926
1927         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
1928         https://bugs.webkit.org/show_bug.cgi?id=130987
1929
1930         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
1931         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
1932
1933         Reviewed by Martin Robinson.
1934
1935         * BuildSlaveSupport/build.webkit.org-config/config.json:
1936
1937 2014-03-31  Dean Jackson  <dino@apple.com>
1938
1939         Remove WEB_ANIMATIONS
1940         https://bugs.webkit.org/show_bug.cgi?id=130989
1941
1942         Reviewed by Simon Fraser.
1943
1944         Remove this feature flag until we plan to implement.
1945
1946         * Scripts/webkitperl/FeatureList.pm:
1947
1948 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
1949
1950         Reduced Latched Scroll Test Flakiness
1951         https://bugs.webkit.org/show_bug.cgi?id=130983
1952
1953         Reviewed by Darin Adler.
1954
1955         * DumpRenderTree/mac/DumpRenderTree.mm:
1956         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
1957         * DumpRenderTree/mac/EventSendingController.mm:
1958         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
1959         with high resolution flags turned on.
1960         * WebKitTestRunner/mac/EventSenderProxy.mm:
1961         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
1962
1963 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1964
1965         run-webkit-tests should have a --no-timeout option
1966         https://bugs.webkit.org/show_bug.cgi?id=128286
1967
1968         Reviewed by Joseph Pecoraro.
1969
1970         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1971         (Worker._run_test): Renaming _run_test_with_timeout()
1972         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
1973         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
1974         (Worker._run_test_in_this_thread):
1975         (Worker._run_test_with_timeout): Deleted.
1976         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1977         (parse_args): Added the --no-timeout option
1978
1979 2014-03-31  Samuel White  <samuel_white@apple.com>
1980
1981         AX: Need ability to get line range for text marker.
1982         https://bugs.webkit.org/show_bug.cgi?id=130906
1983
1984         Reviewed by Chris Fleizach.
1985
1986         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
1987
1988         * DumpRenderTree/AccessibilityUIElement.cpp:
1989         (lineTextMarkerRangeForTextMarkerCallback):
1990         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1991         (AccessibilityUIElement::getJSClass):
1992         * DumpRenderTree/AccessibilityUIElement.h:
1993         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1994         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1995         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1996         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1997         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1998         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1999         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2000         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2001         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2002         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2003         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2004         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2005
2006 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
2007
2008         More validation for FTL inline caches
2009         https://bugs.webkit.org/show_bug.cgi?id=130948
2010
2011         Reviewed by Geoffrey Garen.
2012
2013         * Scripts/run-jsc-stress-tests:
2014
2015 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2016
2017         [GTK] Do not run WebKit1 unit tests by default
2018         https://bugs.webkit.org/show_bug.cgi?id=130968
2019
2020         Reviewed by Martin Robinson.
2021
2022         * Scripts/run-gtk-tests:
2023         (TestRunner):
2024
2025 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
2026
2027         [GTK] Remove scripts code only applicable to autotools
2028         https://bugs.webkit.org/show_bug.cgi?id=130841
2029
2030         Reviewed by Anders Carlsson.
2031
2032         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2033         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
2034         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
2035         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
2036         * gtk/find-make-dist-errors: Removed.
2037         * gtk/generate-feature-defines-files: Removed.
2038         * gtk/manifest.txt: No longer need to consider autotools files.
2039
2040 2014-03-30  Andy Estes  <aestes@apple.com>
2041
2042         Fix two failing layout tests on Mountain Lion after r166466.
2043
2044         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2045         (-[DownloadDelegate _downloadDidStart:]):
2046
2047 2014-03-30  Andy Estes  <aestes@apple.com>
2048
2049         [Cocoa] Add an originatingWebView property to _WKDownload
2050         https://bugs.webkit.org/show_bug.cgi?id=130945
2051
2052         Reviewed by Anders Carlsson.
2053
2054         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2055         (-[DownloadDelegate _downloadDidStart:]):
2056         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
2057         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
2058         (TEST):
2059
2060 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
2061
2062         Land the stackmap register liveness glue with the uses of the liveness disabled
2063         https://bugs.webkit.org/show_bug.cgi?id=130924
2064
2065         Reviewed by Oliver Hunt.
2066
2067         * Scripts/run-jsc-stress-tests:
2068
2069 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
2070
2071         Update WebKit1.StringTruncator for Mountain Lion.
2072
2073         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
2074         due to different font metrics on 10.8.
2075
2076 2014-03-28  Darin Adler  <darin@apple.com>
2077
2078         Fix recently-introduced off-by-one error in centerTruncateToBuffer
2079         https://bugs.webkit.org/show_bug.cgi?id=130889
2080
2081         Reviewed by Alexey Proskuryakov.
2082
2083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
2084         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
2085         WebStringTruncator methods; should be good for a start. These are dependent on the
2086         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
2087
2088 2014-03-28  Martin Hock  <mhock@apple.com>
2089
2090         Unreviewed. Add myself as a committer.
2091
2092         * Scripts/webkitpy/common/config/contributors.json:
2093
2094 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
2095
2096         Remove WebKit1 GTK+ bots
2097         https://bugs.webkit.org/show_bug.cgi?id=130904
2098
2099         Reviewed by Anders Carlsson.
2100
2101         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
2102         all bots are testing WebKit2 only.
2103         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
2104         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
2105         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
2106         * Scripts/webkitpy/port/builders.py: Ditto.
2107         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2108         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
2109
2110 2014-03-28  Timothy Hatcher  <timothy@apple.com>
2111
2112         Remove Brian Burg's apple.com email address.
2113
2114         * Scripts/webkitpy/common/config/contributors.json:
2115
2116 2014-03-28  David Kilzer  <ddkilzer@apple.com>
2117
2118         bisect-builds should print Trac 'changeset' URL if only one build is detected
2119         <http://webkit.org/b/130903>
2120
2121         Reviewed by Dan Bernstein.
2122
2123         * Scripts/bisect-builds:
2124         (printTracLink): Print a direct link to the Trac 'changeset'
2125         URL if there is only one revision in the range.
2126
2127 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2128
2129         [EFL] Bump glib version from 2.36 to 2.38 
2130         https://bugs.webkit.org/show_bug.cgi?id=130886
2131
2132         Reviewed by Csaba Osztrogonác.
2133
2134         There is a build break on EFL port when using glib 2.36 ver. To fix it,
2135         we need to bump glib version up to 2.38 as gtk port.
2136
2137         * efl/jhbuild.modules:
2138
2139 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2140
2141         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
2142
2143         Provide an implementation of WKContextHistoryClient that logs when called for tests in
2144         the globalhistory directory.
2145
2146         Reviewed by Sam Weinig.
2147
2148         * WebKitTestRunner/TestController.cpp:
2149         (WTR::TestController::TestController):
2150         (WTR::TestController::initialize): Set the history client.
2151         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
2152         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2153         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2154         and we don't yet have API to access the data in question.
2155         (WTR::TestController::didPerformClientRedirect):
2156         (WTR::TestController::didPerformServerRedirect):
2157         (WTR::TestController::didUpdateHistoryTitle):
2158         * WebKitTestRunner/TestController.h:
2159         (WTR::TestController::setShouldLogHistoryClientCallbacks):
2160         * WebKitTestRunner/TestInvocation.cpp:
2161         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2162         (WTR::TestInvocation::invoke):
2163
2164 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2165
2166         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2167
2168         * Scripts/build-webkit:
2169         * Scripts/copy-webkitlibraries-to-product-directory:
2170
2171 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2172
2173         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2174         https://bugs.webkit.org/show_bug.cgi?id=130867
2175         <rdar://problem/16432456> 
2176
2177         Reviewed by Mark Hahnenberg.
2178
2179         * Scripts/build-webkit:
2180         * Scripts/copy-webkitlibraries-to-product-directory:
2181
2182 2014-03-26  Andy Estes  <aestes@apple.com>
2183
2184         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
2185         https://bugs.webkit.org/show_bug.cgi?id=130805
2186
2187         Reviewed by Dan Bernstein.
2188
2189         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2190         (-[DownloadDelegate _download:didReceiveResponse:]):
2191         (-[DownloadDelegate _downloadDidFinish:]):
2192         (runTest):
2193         (TEST):
2194         (-[FailingDownloadDelegate _downloadDidFinish:]):
2195         (-[FailingDownloadDelegate _download:didFailWithError:]):
2196         (-[FailingDownloadDelegate _downloadDidCancel:]):
2197         (-[CancelledDownloadDelegate _downloadDidStart:]):
2198         (-[CancelledDownloadDelegate _downloadDidFinish:]):
2199         (-[CancelledDownloadDelegate _download:didFailWithError:]):
2200         (-[CancelledDownloadDelegate _downloadDidCancel:]):
2201         (-[DownloadDelegate initWithSourceURL:]): Deleted.
2202         (-[DownloadDelegate sourceURL]): Deleted.
2203         (runTestWithNavigationDelegate): Deleted.
2204
2205 2014-03-26  Anders Carlsson  <andersca@apple.com>
2206
2207         Change MiniBrowser to hold on to window controllers instead of windows
2208         https://bugs.webkit.org/show_bug.cgi?id=130797
2209
2210         Reviewed by Oliver Hunt.
2211
2212         * MiniBrowser/mac/AppDelegate.h:
2213         * MiniBrowser/mac/AppDelegate.m:
2214         (-[BrowserAppDelegate init]):
2215         (-[BrowserAppDelegate newWindow:]):
2216         (-[BrowserAppDelegate browserWindowWillClose:]):
2217         (-[BrowserAppDelegate applicationWillTerminate:]):
2218         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2219
2220 2014-03-26  Commit Queue  <commit-queue@webkit.org>
2221
2222         Unreviewed, rolling out r166264.
2223         https://bugs.webkit.org/show_bug.cgi?id=130785
2224
2225         Broke some window.opener tests for WK2 Mavericks (Requested by
2226         brrian__ on #webkit).
2227
2228         Reverted changeset:
2229
2230         "Web Replay: resource unique identifiers should be unique-per-
2231         frame, not globally"
2232         https://bugs.webkit.org/show_bug.cgi?id=130632
2233         http://trac.webkit.org/changeset/166264
2234
2235 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
2236
2237         [CSS Shapes] Remove shape-inside support
2238         https://bugs.webkit.org/show_bug.cgi?id=130698
2239
2240         Reviewed by David Hyatt.
2241
2242         * Scripts/webkitperl/FeatureList.pm:
2243
2244 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
2245
2246         Unreviewed. Add myself as a committer.
2247
2248         * Scripts/webkitpy/common/config/contributors.json:
2249
2250 2014-03-26  Tomas Popela  <tpopela@redhat.com>
2251
2252         run-launcher is Perl script so use elsif and not elif
2253         https://bugs.webkit.org/show_bug.cgi?id=130771
2254
2255         Reviewed by Carlos Garcia Campos.
2256
2257         * Scripts/run-launcher:
2258
2259 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
2260
2261         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
2262         https://bugs.webkit.org/show_bug.cgi?id=130575
2263
2264         Reviewed by Mario Sanchez Prada.
2265
2266         Change ATK version to 2.11.92. Adjust current implementation.
2267
2268         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2269         (AccessibilityUIElement::intValue):
2270         (AccessibilityUIElement::minValue):
2271         (AccessibilityUIElement::maxValue):
2272         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2273         (WTR::AccessibilityUIElement::intValue):
2274         (WTR::AccessibilityUIElement::minValue):
2275         (WTR::AccessibilityUIElement::maxValue):
2276         * efl/jhbuild.modules:
2277         * gtk/jhbuild.modules:
2278
2279 2014-03-12  Philippe Normand  <pnormand@igalia.com>
2280
2281         [GTK] The gnumake package is no longer needed in jhbuild
2282         https://bugs.webkit.org/show_bug.cgi?id=130121
2283
2284         Reviewed by Martin Robinson.
2285
2286         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
2287         for a debug build cmake/system-gnumake worked just fine for me.
2288
2289         * gtk/jhbuild.modules: Removed gnumake.
2290         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
2291         * gtk/patches/make-3.82-parallel-build.patch: Removed.
2292
2293 2014-03-25  Andy Estes  <aestes@apple.com>
2294
2295         Fix a failing API test on Mountain Lion and remove temporary debug logging.
2296
2297         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2298         (-[DownloadDelegate _download:didReceiveData:]):
2299         (-[DownloadDelegate _downloadDidFinish:]):
2300
2301 2014-03-25  Brian Burg  <bburg@apple.com>
2302
2303         Web Replay: resource unique identifiers should be unique-per-frame, not globally
2304         https://bugs.webkit.org/show_bug.cgi?id=130623
2305
2306         Reviewed by Timothy Hatcher.
2307
2308         The resource loader callback dumping routines assumed that resource identifiers
2309         were globally unique. Its map of resource identifiers to URLs must also track the
2310         frame associated with the resource.
2311
2312         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2313         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
2314         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
2315         stable as long as the frame is valid.
2316         (WTR::InjectedBundlePage::didInitiateLoadForResource):
2317         (WTR::InjectedBundlePage::willSendRequestForFrame):
2318         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2319         (WTR::InjectedBundlePage::didFinishLoadForResource):
2320         (WTR::InjectedBundlePage::didFailLoadForResource):
2321
2322 2014-03-25  Andy Estes  <aestes@apple.com>
2323
2324         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
2325
2326         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2327         (-[DownloadDelegate _download:didReceiveResponse:]):
2328         (-[DownloadDelegate _download:didReceiveData:]):
2329
2330 2014-03-25  Andy Estes  <aestes@apple.com>
2331
2332         Add some debug logging to an API test that's failing on Mountain Lion.
2333
2334         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2335         (-[DownloadDelegate _download:didReceiveResponse:]):
2336         (-[DownloadDelegate _downloadDidFinish:]):
2337
2338 2014-03-25  Anders Carlsson  <andersca@apple.com>
2339
2340         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
2341         https://bugs.webkit.org/show_bug.cgi?id=130732
2342
2343         Reviewed by Tim Horton.
2344
2345         * MiniBrowser/mac/WK2BrowserWindowController.m:
2346         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2347
2348 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
2349
2350         [GTK] Remove the autotools build
2351         https://bugs.webkit.org/show_bug.cgi?id=130717
2352
2353         Reviewed by Anders Carlsson.
2354
2355         * DumpRenderTree/config.h: Remove references to the autotools configure file.
2356         * GNUmakefile.am: Removed.
2357         * GtkLauncher/GNUmakefile.am: Removed.
2358         * GtkLauncher/main.c: Remove references to the autotools configure file.
2359         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
2360         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
2361         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
2362         * MiniBrowser/gtk/GNUmakefile.am: Removed.
2363         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
2364         * Scripts/build-webkit: No longer handle autotools.
2365         * Scripts/run-gtk-tests: Ditto.
2366         (TestRunner._setup_testing_environment):
2367         * Scripts/run-launcher: Ditto.
2368         * Scripts/webkitdirs.pm: Ditto.
2369         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
2370         * Scripts/webkitpy/common/config/contributors.json: Ditto.
2371         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
2372         * Scripts/webkitpy/style/checker.py:
2373         * TestWebKitAPI/GNUmakefile.am: Removed.
2374         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
2375         * WebKitTestRunner/GNUmakefile.am: Removed.
2376         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
2377         * gtk/GNUmakefile.am: Removed.
2378         * gtk/common.py: Remove checks for the autotools build.
2379         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
2380
2381 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
2382
2383         prepare-ChangeLog throws false positive warnings for modified files.
2384         https://bugs.webkit.org/show_bug.cgi?id=130687
2385
2386         Reviewed by Darin Adler.
2387
2388         * Scripts/prepare-ChangeLog:
2389         (originalFile): Ignore git commit paremeter.
2390         We don't need this to get the unmodified file.
2391         (extractLineRangeBeforeChange):
2392         Simplify the if statement. Follow-up after r166189.
2393
2394 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
2395
2396         [EFL] Add ARM64 build support
2397         https://bugs.webkit.org/show_bug.cgi?id=130506
2398
2399         Rubber stamped by Gyuyoung Kim.
2400
2401         * Scripts/webkitdirs.pm:
2402         (isARM): Detect aarch64 as ARM.
2403
2404 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2405
2406         [webkitpy] Improve _parse_bug_description to recognize more descriptions
2407         https://bugs.webkit.org/show_bug.cgi?id=130137
2408
2409         Reviewed by Csaba Osztrogonác.
2410
2411         * Scripts/webkitpy/common/checkout/changelog.py:
2412         (ChangeLogEntry._parse_bug_description):
2413         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2414         (test_parse_log_entries_from_changelog):
2415         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2416         (CheckoutTest.test_commit_info_for_revision):
2417
2418 2014-03-24  Andy Estes  <aestes@apple.com>
2419
2420         Fix the iOS build of TestWebKitAPI.
2421
2422         * TestWebKitAPI/Configurations/Base.xcconfig:
2423         * TestWebKitAPI/PlatformUtilities.h:
2424
2425 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2426
2427         Fix prepare-ChangeLog after r166156.
2428         https://bugs.webkit.org/show_bug.cgi?id=130674
2429
2430         Reviewed by Darin Adler.
2431
2432         * Scripts/prepare-ChangeLog:
2433         (generateFunctionLists):
2434         (extractLineRangeBeforeChange):
2435
2436 2014-03-24  Andy Estes  <aestes@apple.com>
2437
2438         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
2439         https://bugs.webkit.org/show_bug.cgi?id=129322
2440
2441         Reviewed by Anders Carlsson.
2442
2443         Add an API test suite for _WKDownload.
2444
2445         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2446         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
2447         (-[DownloadDelegate initWithSourceURL:]):
2448         (-[DownloadDelegate sourceURL]):
2449         (-[DownloadDelegate _downloadDidStart:]):
2450         (-[DownloadDelegate _download:didReceiveResponse:]):
2451         (-[DownloadDelegate _download:didReceiveData:]):
2452         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2453         (-[DownloadDelegate _downloadDidFinish:]):
2454         (TEST):
2455         (runTestWithNavigationDelegate):
2456         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2457         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2458
2459 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
2460
2461         filter-build-webkit: reduce unfiltered output
2462         https://bugs.webkit.org/show_bug.cgi?id=130485
2463
2464         Reviewed by Brent Fulgham.
2465
2466         * Scripts/filter-build-webkit:
2467         (shouldIgnoreLine):
2468
2469 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2470
2471         prepare-ChangeLog should list functions that have been removed too.
2472         https://bugs.webkit.org/show_bug.cgi?id=130508
2473
2474         Reviewed by Darin Adler.
2475
2476         The prepare-ChangeLog does not list the deleted functions in the Changelog.
2477         We have to read the functions and the line ranges of them from the source
2478         before the change, then search for overlaps between them and the changed
2479         line ranges from diff.
2480
2481         * Scripts/prepare-ChangeLog:
2482         (originalFile): Get original source command.
2483         (generateFunctionLists): Collect deleted functions too.
2484         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
2485         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
2486         deleted functions ranges too.
2487         (extractLineRange): Renamed to extractLineRangeAfterChange.
2488
2489 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
2490
2491         Move all EFL typedefs into EflTypedefs.h.
2492         https://bugs.webkit.org/show_bug.cgi?id=130511
2493
2494         Reviewed by Gyuyoung Kim.
2495
2496         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
2497         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2498         * WebKitTestRunner/PlatformWebView.h: Ditto.
2499
2500 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
2501
2502         Don't flush compositing layers within FrameView::willPaintContents()
2503         https://bugs.webkit.org/show_bug.cgi?id=130627
2504         <rdar://problem/16368869>
2505
2506         Reviewed by Sam Weinig.
2507         
2508         Fix DRT to correctly render tests with layers now that FrameView::paintContents
2509         does not flush.
2510         
2511         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
2512         into an explicit function called before dumping. 
2513         
2514         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
2515         are flushed to CA. They will be pushed to the window by snapshotting.
2516
2517         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2518         Fix weird path to IOKit.framework.
2519         * DumpRenderTree/mac/DumpRenderTree.mm:
2520         (updateDisplay):
2521         (dump):
2522         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2523         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
2524         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
2525
2526 2014-03-21  David Kilzer  <ddkilzer@apple.com>
2527
2528         fix-blink-patch: tool to fix up renamed directory paths in Blink
2529         <http://webkit.org/b/130609>
2530
2531         Reviewed by Ryosuke Niwa.
2532
2533         Usage: cat blink.patch | fix-blink-patch | svn-apply
2534
2535         * Scripts/fix-blink-patch: Added.
2536
2537 2014-03-21  Darin Adler  <darin@apple.com>
2538
2539         Remove use of deprecatedCharacters in WebKit API tests
2540         https://bugs.webkit.org/show_bug.cgi?id=130602
2541
2542         Reviewed by Antti Koivisto.
2543
2544         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2545         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
2546         (TestWebKitAPI::expectEmpty): Use characters8.
2547         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
2548
2549         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2550         Removed the test that is entirely about 16-bit conversion since that's basically a test of
2551         the deprecatedCharacters function itself, which we are about to delete.
2552
2553 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2554
2555         [webkitpy] Fix has_valid_reviewer()
2556         https://bugs.webkit.org/show_bug.cgi?id=130589
2557
2558         Reviewed by Csaba Osztrogonác.
2559
2560         * Scripts/webkitpy/common/checkout/changelog.py:
2561         (ChangeLogEntry.has_valid_reviewer):
2562         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2563         (test_has_valid_reviewer):
2564         * Scripts/webkitpy/common/config/committers.py:
2565         (CommitterList._reviewer_only):
2566         (CommitterList.committer_by_name):
2567         (CommitterList.reviewer_by_email):
2568         (CommitterList):
2569         (CommitterList.reviewer_by_name):
2570
2571 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2572
2573         Add cache support for jhbuild
2574         https://bugs.webkit.org/show_bug.cgi?id=130588
2575
2576         Reviewed by Csaba Osztrogonác.
2577
2578         * jhbuild/jhbuildrc_common.py:
2579         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
2580
2581 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2582
2583         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
2584         https://bugs.webkit.org/show_bug.cgi?id=130504
2585
2586         Reviewed by Martin Robinson.
2587
2588         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
2589         CMake if not specified.
2590         * Scripts/webkitdirs.pm:
2591         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
2592         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
2593
2594 2014-03-21  Andreas Kling  <akling@apple.com>
2595
2596         RetainPtr API test should use CFArray instead of CFString for testing.
2597         <rdar://problem/16384899>
2598
2599         Unreviewed bot fix.
2600
2601         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2602         (TestWebKitAPI::TEST):
2603         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2604         (TestWebKitAPI::TEST):
2605
2606 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
2607
2608         Move to using std::unique_ptr for EFL objects.
2609         https://bugs.webkit.org/show_bug.cgi?id=129853
2610
2611         Reviewed by Gyuyoung Kim.
2612
2613         EflUniquePtr is a template alias of std::unique_ptr
2614         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
2615         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
2616
2617         * DumpRenderTree/efl/DumpRenderTree.cpp:
2618         (main):
2619         * ImageDiff/efl/ImageDiff.cpp:
2620         (initEfl):
2621         (main):
2622
2623 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
2624
2625         Unreviewed buildfix after r165983 for non Cocoa platforms
2626
2627         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
2628
2629         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2630         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2631         * WebKitTestRunner/TestController.cpp:
2632
2633 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
2634
2635         [GTK][CMake] Add support for building with Clang
2636         https://bugs.webkit.org/show_bug.cgi?id=130260
2637
2638         Reviewed by Martin Robinson.
2639
2640         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
2641         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
2642         included GTest framework headers.
2643         * gtk/generate-gtkdoc:
2644         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
2645         in case of using Clang since that is now set by the CMake rule.
2646
2647 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
2648
2649         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
2650         https://bugs.webkit.org/show_bug.cgi?id=130476
2651
2652         Reviewed by Anders Carlsson.
2653         
2654         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
2655
2656         * MiniBrowser/mac/WK1BrowserWindowController.m:
2657         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2658         Remove log.
2659         * MiniBrowser/mac/WK2BrowserWindowController.m:
2660         (-[WK2BrowserWindowController awakeFromNib]):
2661         (-[WK2BrowserWindowController validateMenuItem:]):
2662         (-[WK2BrowserWindowController reload:]):
2663         Hook up reload.
2664         (-[WK2BrowserWindowController toggleZoomMode:]):
2665         (-[WK2BrowserWindowController resetZoom:]):
2666         (-[WK2BrowserWindowController canResetZoom]):
2667         (-[WK2BrowserWindowController currentZoomFactor]):
2668         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2669         (-[WK2BrowserWindowController canZoomIn]):
2670         (-[WK2BrowserWindowController canZoomOut]):
2671
2672 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
2673
2674         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2675         https://bugs.webkit.org/show_bug.cgi?id=130463
2676
2677         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
2678
2679 2014-03-18  Samuel White  <samuel_white@apple.com>
2680
2681         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
2682         https://bugs.webkit.org/show_bug.cgi?id=130250
2683
2684         Reviewed by Chris Fleizach.
2685
2686         Added ability to toggle enhanced accessibility on and off to support tests that require it.
2687
2688         * DumpRenderTree/AccessibilityController.cpp:
2689         (enableEnhancedAccessibilityCallback):
2690         (getEnhancedAccessibilityEnabledCallback):
2691         (AccessibilityController::getJSClass):
2692         * DumpRenderTree/AccessibilityController.h:
2693         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2694         (AccessibilityController::enableEnhancedAccessibility):
2695         (AccessibilityController::enhancedAccessibilityEnabled):
2696         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2697         (AccessibilityController::enableEnhancedAccessibility):
2698         (AccessibilityController::enhancedAccessibilityEnabled):
2699         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2700         (AccessibilityController::enableEnhancedAccessibility):
2701         (AccessibilityController::enhancedAccessibilityEnabled):
2702         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2703         (AccessibilityController::enableEnhancedAccessibility):
2704         (AccessibilityController::enhancedAccessibilityEnabled):
2705         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2706         (WTR::AccessibilityController::enableEnhancedAccessibility):
2707         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
2708         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2709         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2710
2711 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
2712
2713         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
2714         yet).
2715
2716         * Scripts/webkitpy/common/config/contributors.json:
2717
2718 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
2719
2720         Web Inspector: Remove stale ReportMemoryUsagePlugin
2721         https://bugs.webkit.org/show_bug.cgi?id=130405
2722
2723         Reviewed by Andreas Kling.
2724
2725         This clang plugin looks like it was used for the old Inspector memory
2726         instrumentation that was removed. So the tool can be removed.
2727
2728         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
2729         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
2730         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
2731         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
2732
2733 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2734
2735         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
2736         https://bugs.webkit.org/show_bug.cgi?id=130220
2737
2738         Reviewed by Csaba Osztrogonác.
2739
2740         * Scripts/webkitpy/common/checkout/changelog.py:
2741         (ChangeLog.set_reviewer):
2742         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2743         (test_set_reviewer):
2744
2745 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
2746
2747         More FTL enabling.
2748
2749         Rubber stamped by Dan Bernstein.
2750
2751         * Tools/Scripts/build-webkit:
2752
2753 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2754
2755         Renable pagination mode in WK2 MiniBrowser
2756         https://bugs.webkit.org/show_bug.cgi?id=130374
2757
2758         Reviewed by Anders Carlsson.
2759         
2760         Put the implementation of togglePaginationMode: back, and correctly
2761         enable the menu item.
2762
2763         * MiniBrowser/mac/WK2BrowserWindowController.m:
2764         (-[WK2BrowserWindowController validateMenuItem:]):
2765         (-[WK2BrowserWindowController isPaginated]):
2766         (-[WK2BrowserWindowController togglePaginationMode:]):
2767
2768 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2769
2770         Add --reset option to Tools/Scripts/set-webkit-configuration script
2771         https://bugs.webkit.org/show_bug.cgi?id=130401
2772
2773         Reviewed by Csaba Osztrogonác.
2774
2775         * Scripts/set-webkit-configuration:
2776
2777 2014-03-18  Alberto Garcia  <berto@igalia.com>
2778
2779         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
2780         https://bugs.webkit.org/show_bug.cgi?id=130388
2781
2782         Reviewed by Sergio Villar Senin.
2783
2784         * Scripts/webkitdirs.pm:
2785         (shouldRemoveCMakeCache): make sure that the build directory
2786         exists before attempting to create a file in it.
2787
2788 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
2789
2790         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
2791         https://bugs.webkit.org/show_bug.cgi?id=130336
2792
2793         Reviewed by Gyuyoung Kim.
2794
2795         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
2796         requires a space between literal and string macro [-Wliteral-suffix]'
2797         warning treated as error.
2798
2799         This patch applies a solution from r162448 to the EFL port.
2800
2801         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2802         * efl/jhbuild.modules: Added appropriate patch section.
2803
2804 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2805
2806         webkitpy test rebaseline.
2807
2808         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2809         (MainTest.test_default_args):
2810
2811 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2812
2813         --profile should imply --test-runner-count=1 in run-perf-tests
2814         https://bugs.webkit.org/show_bug.cgi?id=130375
2815
2816         Reviewed by Benjamin Poulain.
2817
2818         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
2819
2820         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2821         (PerfTestsRunner._parse_args): Use -1 as the default value.
2822         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
2823         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
2824         should be 1.
2825
2826 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2827
2828         Address some style nits.
2829
2830         * MiniBrowser/mac/WK2BrowserWindowController.m:
2831
2832 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2833
2834         Add transparent window support back into MiniBrowser
2835         https://bugs.webkit.org/show_bug.cgi?id=130363
2836
2837         Reviewed by Anders Carlsson.
2838         
2839         Re-enable transparent window support for WK2.
2840
2841         * MiniBrowser/mac/WK2BrowserWindowController.m:
2842         (-[WK2BrowserWindowController validateMenuItem:]):
2843         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2844
2845 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2846
2847         Fix the 32-bit build; make the open panel make a WK1 window.
2848
2849         * MiniBrowser/mac/AppDelegate.m:
2850         (-[BrowserAppDelegate openDocument:]):
2851
2852 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2853
2854         Convert MiniBrowser to use WKWebView API
2855         https://bugs.webkit.org/show_bug.cgi?id=130061
2856
2857         Reviewed by Anders Carlsson.
2858         
2859         Convert the MiniBrowser WK2 window to use WebKit2 API as much
2860         as possible.
2861         
2862         Some functionality was removed temporarily:
2863             - text zoom, page zoom
2864             - reload
2865             - pagination mode
2866             - transparent window
2867             - dumping source
2868             - window.open support
2869             - beforeUnload panel
2870             - find in page
2871
2872         * MiniBrowser/mac/AppDelegate.h:
2873         * MiniBrowser/mac/AppDelegate.m:
2874         (-[BrowserAppDelegate init]):
2875         (-[BrowserAppDelegate newWindow:]):
2876         (-[BrowserAppDelegate applicationWillTerminate:]):
2877         (-[BrowserAppDelegate openDocument:]):
2878         * MiniBrowser/mac/WK2BrowserWindowController.h:
2879         * MiniBrowser/mac/WK2BrowserWindowController.m:
2880         (-[WK2BrowserWindowController awakeFromNib]):
2881         (-[WK2BrowserWindowController dealloc]):
2882         (-[WK2BrowserWindowController fetch:]):
2883         (-[WK2BrowserWindowController validateMenuItem:]):
2884         (-[WK2BrowserWindowController reload:]):
2885         (-[WK2BrowserWindowController goBack:]):
2886         (-[WK2BrowserWindowController goForward:]):
2887         (-[WK2BrowserWindowController toggleZoomMode:]):
2888         (-[WK2BrowserWindowController resetZoom:]):
2889         (-[WK2BrowserWindowController canResetZoom]):
2890         (-[WK2BrowserWindowController dumpSourceToConsole:]):
2891         (-[WK2BrowserWindowController togglePaginationMode:]):
2892         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2893         (-[WK2BrowserWindowController windowShouldClose:]):
2894         (-[WK2BrowserWindowController applicationTerminating]):
2895         (-[WK2BrowserWindowController currentZoomFactor]):
2896         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2897         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2898         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2899         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2900         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2901         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2902         (-[WK2BrowserWindowController find:]):
2903         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2904         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
2905         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
2906         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
2907         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
2908         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
2909         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
2910         * WebKitTestRunner/PlatformWebView.h:
2911         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2912         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2913
2914 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
2915
2916         Use RunLoop objects through references instead of pointers
2917         https://bugs.webkit.org/show_bug.cgi?id=130313
2918
2919         Reviewed by Andreas Kling.
2920
2921         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
2922         return RunLoop reference instead of a pointer.
2923
2924         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
2925         (loadedCallback):
2926         (clickedCallback):
2927
2928 2014-03-17  Tim Horton  <timothy_horton@apple.com>
2929
2930         sort-export-file --help doesn't work (missing 'use')
2931         https://bugs.webkit.org/show_bug.cgi?id=130338
2932
2933         Reviewed by Anders Carlsson.
2934
2935         * Scripts/sort-export-file:
2936         Add a missing 'use', and fix a typo in an error message.
2937
2938 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
2939
2940         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
2941         https://bugs.webkit.org/show_bug.cgi?id=130155
2942
2943         Reviewed by Philippe Normand.
2944
2945         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
2946
2947 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2948
2949         [GTK] MiniBrowser fails to load injected bundle lib
2950         https://bugs.webkit.org/show_bug.cgi?id=130332
2951
2952         Reviewed by Anders Carlsson.
2953
2954         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
2955
2956         * MiniBrowser/gtk/main.c:
2957         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
2958         process is spawn.
2959
2960 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
2961
2962         [EFL] Enable TOUCH_SLIDER macro
2963         https://bugs.webkit.org/show_bug.cgi?id=130185
2964
2965         Reviewed by Gyuyoung Kim.
2966
2967         * Scripts/webkitperl/FeatureList.pm:
2968
2969 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
2970
2971         [GTK][CMake] Build with -fno-rtti
2972         https://bugs.webkit.org/show_bug.cgi?id=130261
2973
2974         Reviewed by Martin Robinson.
2975
2976         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
2977         defined to 0 to prevent typeid use in included GTest headers.
2978
2979 2014-03-16  Brian Burg  <bburg@apple.com>
2980
2981         Web Inspector: vended backend commands file should be generated as part of the build
2982         https://bugs.webkit.org/show_bug.cgi?id=130110
2983
2984         Reviewed by Timothy Hatcher.
2985
2986         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
2987
2988 2014-03-16  Diego Pino García  <dpino@igalia.com>
2989
2990         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
2991         https://bugs.webkit.org/show_bug.cgi?id=128999
2992
2993         Reviewed by Philippe Normand.
2994
2995         * MiniBrowser/gtk/BrowserWindow.c:
2996         (reloadPage):
2997         (reloadPageIgnoringCache):
2998         (browser_window_init):
2999
3000 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
3001
3002         [GTK] Improve ninja detection in webkitdirs.pm
3003         https://bugs.webkit.org/show_bug.cgi?id=129902
3004
3005         Reviewed by Daniel Bates.
3006
3007         * Scripts/webkitdirs.pm:
3008         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
3009         us to look for ninja-build as well.
3010
3011 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
3012
3013         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
3014         https://bugs.webkit.org/show_bug.cgi?id=130276
3015         <rdar://problem/16266927>
3016         
3017         Reviewed by Simon Fraser.
3018
3019         * BuildSlaveSupport/build-launcher-app:
3020         * BuildSlaveSupport/build-launcher-dmg:
3021         * DumpRenderTree/DumpRenderTree.h:
3022         * DumpRenderTree/DumpRenderTreePrefix.h:
3023         * DumpRenderTree/GCController.cpp:
3024         * DumpRenderTree/GCController.h:
3025         * DumpRenderTree/JavaScriptThreading.cpp:
3026         * DumpRenderTree/JavaScriptThreading.h:
3027         * DumpRenderTree/PixelDumpSupport.cpp:
3028         * DumpRenderTree/PixelDumpSupport.h:
3029         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
3030         * DumpRenderTree/TestRunner.cpp:
3031         * DumpRenderTree/TestRunner.h:
3032         * DumpRenderTree/WorkQueue.cpp:
3033         * DumpRenderTree/WorkQueue.h:
3034         * DumpRenderTree/WorkQueueItem.h:
3035         * DumpRenderTree/atk/AccessibilityCallbacks.h:
3036         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3037         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
3038         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
3039         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3040         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3041         * DumpRenderTree/efl/EditingCallbacks.cpp:
3042         * DumpRenderTree/efl/EditingCallbacks.h:
3043         * DumpRenderTree/efl/EventSender.cpp:
3044         * DumpRenderTree/efl/EventSender.h:
3045         * DumpRenderTree/efl/GCControllerEfl.cpp:
3046         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3047         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3048         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3049         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3050         * DumpRenderTree/gtk/EditingCallbacks.cpp:
3051         * DumpRenderTree/gtk/EditingCallbacks.h:
3052         * DumpRenderTree/gtk/EventSender.cpp:
3053         * DumpRenderTree/gtk/EventSender.h:
3054         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3055         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3056         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
3057         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
3058         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3059         * DumpRenderTree/gtk/TextInputController.cpp:
3060         * DumpRenderTree/gtk/TextInputController.h:
3061         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
3062         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
3063         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3064         * DumpRenderTree/mac/AppleScriptController.h:
3065         * DumpRenderTree/mac/AppleScriptController.m:
3066         * DumpRenderTree/mac/CheckedMalloc.cpp:
3067         * DumpRenderTree/mac/CheckedMalloc.h:
3068         * DumpRenderTree/mac/DumpRenderTree.mm:
3069         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3070         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3071         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3072         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3073         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3074         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3075         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3076         * DumpRenderTree/mac/EditingDelegate.h:
3077         * DumpRenderTree/mac/EditingDelegate.mm:
3078         * DumpRenderTree/mac/EventSendingController.h:
3079         * DumpRenderTree/mac/EventSendingController.mm:
3080         * DumpRenderTree/mac/FrameLoadDelegate.h:
3081         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3082         * DumpRenderTree/mac/GCControllerMac.mm:
3083         * DumpRenderTree/mac/MockWebNotificationProvider.h:
3084         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3085         * DumpRenderTree/mac/NavigationController.h:
3086         * DumpRenderTree/mac/NavigationController.m:
3087         * DumpRenderTree/mac/ObjCController.h:
3088         * DumpRenderTree/mac/ObjCController.m:
3089         * DumpRenderTree/mac/ObjCPlugin.h:
3090         * DumpRenderTree/mac/ObjCPlugin.m:
3091         * DumpRenderTree/mac/ObjCPluginFunction.h:
3092         * DumpRenderTree/mac/ObjCPluginFunction.m:
3093         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3094         * DumpRenderTree/mac/PolicyDelegate.h:
3095         * DumpRenderTree/mac/PolicyDelegate.mm:
3096         * DumpRenderTree/mac/ResourceLoadDelegate.h:
3097         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3098         * DumpRenderTree/mac/TestRunnerMac.mm:
3099         * DumpRenderTree/mac/TextInputController.h:
3100         * DumpRenderTree/mac/TextInputController.m:
3101         * DumpRenderTree/mac/UIDelegate.h:
3102         * DumpRenderTree/mac/UIDelegate.mm:
3103         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3104         * DumpRenderTree/win/DRTDataObject.cpp:
3105         * DumpRenderTree/win/DRTDataObject.h:
3106         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3107         * DumpRenderTree/win/DRTDropSource.cpp:
3108         * DumpRenderTree/win/DRTDropSource.h:
3109         * DumpRenderTree/win/DraggingInfo.h:
3110         * DumpRenderTree/win/DumpRenderTree.cpp:
3111         * DumpRenderTree/win/DumpRenderTreeWin.h:
3112         * DumpRenderTree/win/EditingDelegate.cpp:
3113         * DumpRenderTree/win/EditingDelegate.h:
3114         * DumpRenderTree/win/EventSender.cpp:
3115         * DumpRenderTree/win/EventSender.h:
3116         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3117         * DumpRenderTree/win/FrameLoadDelegate.h:
3118         * DumpRenderTree/win/GCControllerWin.cpp:
3119         * DumpRenderTree/win/HistoryDelegate.cpp:
3120         * DumpRenderTree/win/HistoryDelegate.h:
3121         * DumpRenderTree/win/MD5.cpp:
3122         * DumpRenderTree/win/MD5.h:
3123         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3124         * DumpRenderTree/win/PolicyDelegate.cpp:
3125         * DumpRenderTree/win/PolicyDelegate.h:
3126         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3127         * DumpRenderTree/win/ResourceLoadDelegate.h:
3128         * DumpRenderTree/win/TestRunnerWin.cpp:
3129         * DumpRenderTree/win/TextInputController.cpp:
3130         * DumpRenderTree/win/TextInputController.h:
3131         * DumpRenderTree/win/TextInputControllerWin.cpp:
3132         * DumpRenderTree/win/UIDelegate.cpp:
3133         * DumpRenderTree/win/UIDelegate.h:
3134         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3135         * EWebLauncher/main.c:
3136         * GtkLauncher/main.c:
3137         * ImageDiff/efl/ImageDiff.cpp:
3138         * ImageDiff/gtk/ImageDiff.cpp:
3139         * MiniBrowser/gtk/main.c:
3140         * Scripts/SpacingHeuristics.pm:
3141         * Scripts/VCSUtils.pm:
3142         * Scripts/bisect-builds:
3143         * Scripts/build-dumprendertree:
3144         * Scripts/build-jsc:
3145         * Scripts/build-webkit:
3146         * Scripts/check-dom-results:
3147         * Scripts/check-for-exit-time-destructors:
3148         * Scripts/check-for-global-initializers:
3149         * Scripts/commit-log-editor:
3150         * Scripts/compare-timing-files:
3151         * Scripts/debug-minibrowser:
3152         * Scripts/debug-safari:
3153         * Scripts/do-file-rename:
3154         * Scripts/find-extra-includes:
3155         * Scripts/generate-coverage-data:
3156         * Scripts/make-script-test-wrappers:
3157         * Scripts/malloc-tree:
3158         * Scripts/old-run-webkit-tests:
3159         * Scripts/parse-malloc-history:
3160         * Scripts/report-include-statistics:
3161         * Scripts/resolve-ChangeLogs:
3162         * Scripts/run-bindings-tests:
3163         * Scripts/run-iexploder-tests:
3164         * Scripts/run-javascriptcore-tests:
3165         * Scripts/run-jsc:
3166         * Scripts/run-launcher:
3167         * Scripts/run-leaks:
3168         * Scripts/run-mangleme-tests:
3169         * Scripts/run-minibrowser:
3170         * Scripts/run-pageloadtest:
3171         * Scripts/run-regexp-tests:
3172         * Scripts/run-safari:
3173         * Scripts/run-sunspider:
3174         * Scripts/run-webkit-app:
3175         * Scripts/sampstat:
3176         * Scripts/set-webkit-configuration:
3177         * Scripts/sort-Xcode-project-file:
3178         * Scripts/sort-export-file:
3179         * Scripts/split-file-by-class:
3180         * Scripts/sunspider-compare-results:
3181         * Scripts/svn-apply:
3182         * Scripts/svn-create-patch:
3183         * Scripts/svn-unapply:
3184         * Scripts/test-webkit-scripts:
3185         * Scripts/update-javascriptcore-test-results:
3186         * Scripts/update-webkit:
3187         * Scripts/update-webkit-auxiliary-libs:
3188         * Scripts/update-webkit-dependency:
3189         * Scripts/update-webkit-localizable-strings:
3190         * Scripts/update-webkit-support-libs:
3191         * Scripts/update-webkit-wincairo-libs:
3192         * Scripts/webkit-build-directory:
3193         * Scripts/webkitdirs.pm:
3194         (installedSafariPath):
3195         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3196         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3197         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3198         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3199         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3200         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3201         * Scripts/webkitperl/features.pm:
3202         * Scripts/webkitperl/httpd.pm:
3203         * Scripts/webkitpy/bindings/main.py:
3204         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3205         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3206         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3207         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3208         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3209         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3210         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3211         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3212         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3213         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
3214         * WebKitTestRunner/PixelDumpSupport.cpp:
3215         * WebKitTestRunner/PixelDumpSupport.h:
3216         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3217         * WinLauncher/WinLauncher.cpp:
3218         * WinLauncher/WinLauncher.h:
3219         * WinLauncher/stdafx.cpp:
3220         * WinLauncher/stdafx.h:
3221
3222 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
3223
3224         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
3225         https://bugs.webkit.org/show_bug.cgi?id=130265
3226
3227         Reviewed by Michael Saboff.
3228
3229         * Scripts/build-webkit:
3230         * Scripts/copy-webkitlibraries-to-product-directory:
3231
3232 2014-03-14  Landry Breuil  <landry@openbsd.org>
3233
3234         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
3235         Also allow to set MAKE in the environment.
3236         https://bugs.webkit.org/show_bug.cgi?id=129991
3237
3238         Reviewed by Andreas Kling.
3239
3240         * Scripts/webkitdirs.pm:
3241         (determineArchitecture):
3242         (determineNumberOfCPUs):
3243         (isBSD):
3244         (buildAutotoolsProject):
3245         * Scripts/webkitpy/common/system/platforminfo.py:
3246         (PlatformInfo.__init__):
3247         (PlatformInfo.is_openbsd):
3248         (PlatformInfo):
3249         (PlatformInfo.is_netbsd):
3250         (PlatformInfo._determine_os_name):
3251
3252 2014-03-14  Dean Jackson  <dino@apple.com>
3253
3254         Remove libWebKitSystemInterfaceLion.a
3255         https://bugs.webkit.org/show_bug.cgi?id=130254
3256
3257         Reviewed by Geoffrey Garen and Andreas Kling.
3258
3259         No need to copy the Lion libraries into the build.
3260
3261         * Scripts/copy-webkitlibraries-to-product-directory:
3262
3263 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3264
3265         [EFL][MiniBrowser] Revise help messages of command line parameters
3266         https://bugs.webkit.org/show_bug.cgi?id=130222
3267
3268         Reviewed by Csaba Osztrogonác.
3269
3270         Correct the default value description and make help messages to be consistent.
3271
3272         * MiniBrowser/efl/main.c:
3273
3274 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
3275
3276         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
3277         https://bugs.webkit.org/show_bug.cgi?id=129612
3278
3279         Reviewed by Darin Adler.
3280
3281         For new code use static NeverDestroyed<T> instead.
3282
3283         * DumpRenderTree/JavaScriptThreading.cpp:
3284         (javaScriptThreadsMutex):
3285         (javaScriptThreads):
3286         * DumpRenderTree/efl/EventSender.cpp:
3287         (touchPointList):
3288         (delayedEventQueue):
3289         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3290         (delegatesWithDelayedWork):
3291         * Scripts/check-for-exit-time-destructors:
3292         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
3293         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3294         (testsMap):
3295
3296 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
3297
3298         [EFL][WK2] Fix compilation warning in Minibrowser
3299         https://bugs.webkit.org/show_bug.cgi?id=130132
3300
3301         Reviewed by Csaba Osztrogonác.
3302
3303         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
3304
3305         * MiniBrowser/efl/main.c:
3306         (on_download_request):
3307
3308 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
3309
3310         FTL should support IsBlah
3311         https://bugs.webkit.org/show_bug.cgi?id=130202
3312
3313         Reviewed by Geoffrey Garen.
3314         
3315         Running existing JSRegress tests with noInline gives us coverage for these
3316         changes. Chances are, this will also give coverage for other interesting things
3317         as well.
3318
3319         * Scripts/run-jsc-stress-tests:
3320
3321 2014-03-12  Brian Burg  <bburg@apple.com>
3322
3323         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
3324         https://bugs.webkit.org/show_bug.cgi?id=129744
3325
3326         Reviewed by Timothy Hatcher.
3327
3328         * DumpRenderTree/TestRunner.cpp:
3329         (evaluateInWebInspectorCallback):
3330         * DumpRenderTree/TestRunner.h:
3331         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3332         (TestRunner::evaluateInWebInspector):
3333         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3334         (TestRunner::evaluateInWebInspector):
3335         * DumpRenderTree/mac/TestRunnerMac.mm:
3336         (TestRunner::evaluateInWebInspector):
3337         * DumpRenderTree/win/TestRunnerWin.cpp:
3338         (TestRunner::evaluateInWebInspector):
3339         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3340         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3341         (WTR::TestRunner::evaluateInWebInspector):
3342         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3343
3344 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3345
3346         [GTK] build-webkit shouldn't show error message when ninja isn't installed
3347         https://bugs.webkit.org/show_bug.cgi?id=130129
3348
3349         Reviewed by Csaba Osztrogonác.
3350
3351         * Scripts/webkitdirs.pm:
3352         (canUseNinja): Redirecting stderr to /dev/null
3353
3354 2014-03-13  Andres Gomez  <agomez@igalia.com>
3355
3356         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
3357         https://bugs.webkit.org/show_bug.cgi?id=130092
3358
3359         Reviewed by Csaba Osztrogonác.
3360
3361         Added "python-dev" as dependency for deb based distros. It is
3362         already present for rpm based distros. This dependency will allow
3363         libxml2 to generate its python bindings, needed by gtk-doc.
3364
3365         * gtk/install-dependencies:
3366
3367 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3368
3369         Unreviewed. Fix GTK+ cmake build after r165488.
3370
3371         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
3372
3373 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3374
3375         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
3376         https://bugs.webkit.org/show_bug.cgi?id=130014
3377
3378         Reviewed by Martin Robinson.
3379
3380         Include cmake or autotools config header.
3381
3382         * MiniBrowser/gtk/BrowserDownloadsBar.c:
3383         * MiniBrowser/gtk/BrowserSearchBar.c:
3384         * MiniBrowser/gtk/BrowserWindow.c:
3385         * MiniBrowser/gtk/main.c:
3386
3387 2014-03-12  Commit Queue  <commit-queue@webkit.org>
3388
3389         Unreviewed, rolling out r165471.
3390         https://bugs.webkit.org/show_bug.cgi?id=130139
3391
3392         Didn't really fix the issue and broke another bot (Requested
3393         by mrobinson on #webkit).
3394
3395         Reverted changeset:
3396
3397         "[CMake] Newer versions of CMake cannot find older versions of
3398         Freetype"
3399         https://bugs.webkit.org/show_bug.cgi?id=130107
3400         http://trac.webkit.org/changeset/165471
3401
3402 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
3403
3404         It should be possible to build WebKit with FTL on iOS
3405         https://bugs.webkit.org/show_bug.cgi?id=130116
3406
3407         Reviewed by Dan Bernstein.
3408
3409         * Scripts/build-webkit:
3410         * Scripts/copy-webkitlibraries-to-product-directory:
3411
3412 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
3413
3414         [Win] Remove use of QTSDK
3415         https://bugs.webkit.org/show_bug.cgi?id=130049
3416
3417         Reviewed by Darin Adler.
3418
3419         * DumpRenderTree/win/DumpRenderTree.cpp:
3420         (initialize): Remove QuickTime code.
3421         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
3422         building QTMovieWin.
3423
3424 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
3425
3426         [GTK][CMAKE] Too verbose build output
3427         https://bugs.webkit.org/show_bug.cgi?id=130076
3428
3429         Reviewed by Carlos Garcia Campos.
3430
3431         Instead of building with cmake --build which isn't smart about pretty printing and
3432         colors, we build with a script which calls the proper build command.
3433
3434         * Scripts/webkitdirs.pm:
3435         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
3436         the CMake configuration pass.
3437
3438 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3439
3440         [CMake] Newer versions of CMake cannot find older versions of Freetype
3441         https://bugs.webkit.org/show_bug.cgi?id=130107
3442
3443         Reviewed by Gustavo Noronha Silva.
3444
3445         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
3446         to CMake during jhbuild initialization.
3447
3448 2014-03-12  Zalan Bujtas  <zalan@apple.com>
3449
3450         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
3451         https://bugs.webkit.org/show_bug.cgi?id=129961
3452
3453         Reviewed by Simon Fraser.
3454
3455         Now scaled content can go through the window capturing mechanism too for compositing content.
3456         AppleMagnifiedMode is redundant.
3457
3458         * DumpRenderTree/mac/DumpRenderTree.mm:
3459         (setDefaultsToConsistentValuesForTesting):
3460         (runTest):
3461         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3462         (createBitmapContextFromWebView):
3463         * WebKitTestRunner/PlatformWebView.h:
3464         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3465         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3466         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3467         (WTR::PlatformWebView::didInitializeClients):
3468         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3469         (WTR::PlatformWebView::forceWindowFramesChanged):
3470         * WebKitTestRunner/mac/main.mm:
3471         (setDefaultsToConsistentValuesForTesting):
3472
3473 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
3474
3475         Unreviewed. Add myself as a committer.
3476
3477         * Scripts/webkitpy/common/config/contributors.json:
3478
3479 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
3480
3481         Unreviewed build fix on the EFL port when used lower version of ATK
3482
3483         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3484         (WTR::AccessibilityUIElement::y): Fixed typo.
3485
3486 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
3487
3488         Some images are blank in the rebaseline server UI
3489         https://bugs.webkit.org/show_bug.cgi?id=130104
3490
3491         Reviewed by Tim Horton.
3492
3493         Let the server check for images in the 'retries' directory
3494         if it can't find an image otherwise.
3495
3496         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3497         (RebaselineHTTPRequestHandler.test_result):
3498
3499 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3500
3501         [GTK][CMake] --update-gtk has no effect
3502         https://bugs.webkit.org/show_bug.cgi?id=130088
3503
3504         Reviewed by Philippe Normand.
3505
3506         * Scripts/webkitdirs.pm:
3507         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
3508         as an argument.
3509
3510 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3511
3512         Add "System Font" to the list of whitelisted DRT fonts
3513         https://bugs.webkit.org/show_bug.cgi?id=130046
3514
3515         Reviewed by Darin Adler.
3516
3517         * DumpRenderTree/mac/DumpRenderTree.mm:
3518         (allowedFontFamilySet):
3519         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3520
3521 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3522
3523         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
3524         https://bugs.webkit.org/show_bug.cgi?id=130064
3525
3526         Reviewed by Philippe Normand.
3527
3528         * efl/jhbuildrc: Remove duplicated code.
3529         * gtk/jhbuildrc: Remove duplicated code.
3530         * jhbuild/jhbuildrc_common.py:
3531         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
3532         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
3533         and is apparently necessary for GTK+.
3534
3535 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3536
3537         check-webkit-style failed to complain about missing braces
3538         https://bugs.webkit.org/show_bug.cgi?id=34189
3539
3540         Reviewed by Ryosuke Niwa.
3541
3542         * Scripts/webkitpy/style/checkers/cpp.py:
3543         (check_braces):
3544         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3545         (WebKitStyleTest.test_braces):
3546
3547 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3548
3549         Remove Qt cruft from style checker.
3550         https://bugs.webkit.org/show_bug.cgi?id=130085
3551
3552         Reviewed by Csaba Osztrogonác.
3553
3554         There is no 'foreach' keyword in c++. That was a Qt feature
3555         added in: http://trac.webkit.org/changeset/46113
3556         Qt was removed from WebKit, so we should remove the checks
3557         of this keyword from check-webkit-style scripts.
3558
3559         * Scripts/webkitpy/style/checkers/cpp.py:
3560         (check_spacing_for_function_call):
3561         (check_spacing):
3562         (check_braces):
3563         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3564         (CppStyleTest.test_mismatching_spaces_in_parens):
3565         (CppStyleTest.test_spacing_for_fncall):
3566         (WebKitStyleTest.test_braces):
3567
3568 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
3569
3570         [GTK] update-webkitgtk-libs needs itstool
3571         https://bugs.webkit.org/show_bug.cgi?id=130082
3572
3573         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
3574         itstool is a dependency of building gtk-doc from version 1.19, so it should
3575         be added to Tools/gtk/install-dependencies script, too.
3576
3577         Reviewed by Philippe Normand.
3578
3579         * gtk/install-dependencies:
3580
3581 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3582
3583         webkitbot rollout ChangeLogs should be nicer
3584         https://bugs.webkit.org/show_bug.cgi?id=122654
3585
3586         Reviewed by Csaba Osztrogonác.
3587
3588         Added bug urls and descriptions of rolled out patches to the rollout changelog
3589         if they are present in the original changelog. Additionally removed the list of
3590         changed files and functions.
3591
3592         * Scripts/webkitpy/common/checkout/changelog.py:
3593         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
3594         * Scripts/webkitpy/common/checkout/checkout.py:
3595         (Checkout._changelog_data_for_revision): Store bug description.
3596         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3597         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3598         (CheckoutTest.test_commit_info_for_revision):
3599         * Scripts/webkitpy/common/checkout/commitinfo.py:
3600         (CommitInfo.bug_description): Added.
3601         (CommitInfo.to_json):
3602         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3603         (CommitInfoTest.test_commit_info_creation):
3604         * Scripts/webkitpy/tool/commands/download.py:
3605         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
3606         out patches for creating rollout changelog.
3607         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
3608         caused the regression is stored in state["bug_blocked"] now.
3609         * Scripts/webkitpy/tool/commands/download_unittest.py:
3610         (test_prepare_rollout):
3611         (test_create_rollout_multiple_revision):
3612         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3613         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
3614         rolled out patches to the changelog.
3615         (PrepareChangeLogForRevert.run):
3616         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3617         (UpdateChangeLogsForRevertTest):
3618         (test_message_for_revert):
3619         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3620         (ReopenBugAfterRollout.run):
3621
3622 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
3623
3624         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
3625         https://bugs.webkit.org/show_bug.cgi?id=130021
3626
3627         Reviewed by Mario Sanchez Prada.
3628
3629         Replace deprecated functions to use new API from ATK 2.11.90.
3630
3631         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3632         (AccessibilityUIElement::x):
3633         (AccessibilityUIElement::y):
3634         (AccessibilityUIElement::width):
3635         (AccessibilityUIElement::height):
3636         (AccessibilityUIElement::clickPointX):
3637         (AccessibilityUIElement::clickPointY):
3638         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3639         (WTR::AccessibilityUIElement::x):
3640         (WTR::AccessibilityUIElement::y):
3641         (WTR::AccessibilityUIElement::width):
3642         (WTR::AccessibilityUIElement::height):
3643         (WTR::AccessibilityUIElement::clickPointX):
3644         (WTR::AccessibilityUIElement::clickPointY):
3645
3646 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
3647
3648         [ATK] Expose aria-posinset and aria-setsize through object attributes
3649         https://bugs.webkit.org/show_bug.cgi?id=130011
3650
3651         Reviewed by Chris Fleizach.
3652
3653         Added missing implementation of numberAttributeValue both to WKTR and DRT.
3654
3655         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3656         (AccessibilityUIElement::numberAttributeValue):
3657         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3658         (WTR::AccessibilityUIElement::numberAttributeValue):
3659
3660 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3661
3662         [Win] Unreviewed build fix.
3663
3664         Some bad Windows code was committed at some point that prevents the Apple Windows port
3665         from finding its runtime dependencies reliably.
3666
3667         * win/DLLLauncher/DLLLauncherMain.cpp:
3668         (appleApplicationSupportDirectory): Restored this function.
3669         (modifyPath): Update to use appleApplicationSupportDirectory function.
3670
3671 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
3672
3673         Let the user define the full address of the performance-site-server for uploading results
3674         https://bugs.webkit.org/show_bug.cgi?id=129819
3675
3676         Reviewed by Ryosuke Niwa.
3677
3678         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
3679         can be confusing. It's more straightforward, if you need to define explicitly the server's full
3680         address along with the protocol, when you're using this parameter. I added HTTPS as the default
3681         protocol for now, in order to avoid breaking the perf bots.
3682
3683         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3684         (_upload_json):
3685         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3686         (MainTest.test_upload_json):
3687
3688 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3689
3690         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
3691         https://bugs.webkit.org/show_bug.cgi?id=130023
3692
3693         Reviewed by Dean Jackson.
3694
3695         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
3696         /SAFESEH flag to DLL launcher process.
3697
3698 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3699
3700         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
3701         https://bugs.webkit.org/show_bug.cgi?id=129980
3702
3703         Reviewed by Carlos Garcia Campos.
3704
3705         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
3706
3707 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3708
3709         [GTK] Remove the WebView source-mode WebKit1 test
3710         https://bugs.webkit.org/show_bug.cgi?id=129976
3711
3712         Reviewed by Carlos Garcia Campos.
3713
3714         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
3715
3716 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
3717
3718         Unreviewed build fix for GTKbuild after the switch to CMake
3719
3720         * gtk/common.py:
3721         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
3722         test-only bot doesn't have any build files.
3723
3724 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3725
3726         [GTK] built-product-archive does not handle GTK+ CMake build
3727         https://bugs.webkit.org/show_bug.cgi?id=129941
3728
3729         * BuildSlaveSupport/built-product-archive:
3730         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
3731         the CMake build.
3732
3733 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
3734
3735         [GTK] Include CMake into install-dependencies script
3736         https://bugs.webkit.org/show_bug.cgi?id=129909
3737
3738         Reviewed by Martin Robinson.
3739
3740         As since r165267 buid-webkit uses CMake by default, the dependency
3741         with 'cmake' package should be introduced.
3742
3743         * gtk/install-dependencies: Ditto.
3744
3745 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3746
3747         REGRESSION(165267): Broke a webkitpy unit tests
3748         https://bugs.webkit.org/show_bug.cgi?id=129904
3749
3750         Reviewed by Jon Honeycutt.
3751
3752         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
3753         (GtkPort._is_cmake_build):
3754
3755 2014-03-07  Andres Gomez  <agomez@igalia.com>
3756
3757         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
3758         https://bugs.webkit.org/show_bug.cgi?id=129893
3759
3760         Reviewed by Martin Robinson.
3761
3762         Added "git-svn" as dependency for deb based distros and,
3763         additionally, "subversion" for rpm based distros.
3764
3765         * gtk/install-dependencies:
3766
3767 2014-03-07  Roger Fong  <roger_fong@apple.com>
3768
3769         Remove dummy setSystemWebGLLoadPolicy client method.
3770         https://bugs.webkit.org/show_bug.cgi?id=129873.
3771
3772         Reviewed by Dean Jackson.
3773
3774         * WebKitTestRunner/TestController.cpp:
3775         (WTR::TestController::createWebViewWithOptions):
3776
3777 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
3778
3779         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
3780         https://bugs.webkit.org/show_bug.cgi?id=129886
3781
3782         Reviewed by Mark Lam.
3783
3784         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
3785         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
3786         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
3787         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
3788         make it through when in non-verbose mode.
3789
3790 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3791
3792         [GTK] buid-webkit should use CMake by default
3793         https://bugs.webkit.org/show_bug.cgi?id=129855
3794
3795         Reviewed by Carlos Garcia Campos.
3796
3797         Make the CMake build the default GTK+ build when using build-webkit. This will
3798         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
3799         so that we have --gtk and --gtkautotools.
3800
3801         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
3802         * Scripts/webkitpy/port/gtk.py: Ditto.
3803
3804 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
3805
3806         [CMake] [GTK] Build with ninja when it is available
3807         https://bugs.webkit.org/show_bug.cgi?id=129805
3808
3809         Reviewed by Philippe Normand.
3810
3811         * Scripts/webkitdirs.pm:
3812         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
3813         if it's available on the system.
3814         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
3815         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
3816
3817 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
3818
3819         If the FTL is build-time enabled then it should be run-time enabled.
3820
3821         Rubber stamped by Geoffrey Garen.
3822
3823         * Scripts/run-jsc-stress-tests:
3824
3825 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
3826
3827         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
3828         https://bugs.webkit.org/show_bug.cgi?id=129837
3829
3830         Reviewed by Michael Saboff.
3831
3832         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
3833         The fix is to use find instead of ls like we do in shell-runner.sh.
3834
3835         * Scripts/run-jsc-stress-tests:
3836
3837 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
3838
3839         filter-build-webkit should not strip .o
3840         https://bugs.webkit.org/show_bug.cgi?id=129614
3841
3842         Reviewed by Dean Jackson.
3843
3844         This makes it much easier to jump from the failing output at
3845         the end back up to the compile errors earlier in the output.
3846
3847         * Scripts/filter-build-webkit:
3848
3849 2014-03-06  Anders Carlsson  <andersca@apple.com>
3850
3851         Build WebKit2 before building WebKit
3852         https://bugs.webkit.org/show_bug.cgi?id=129831
3853         <rdar://problem/15920020>
3854
3855         Reviewed by Dan Bernstein.
3856
3857         * Scripts/build-webkit:
3858         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
3859
3860 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
3861
3862         make-3.82 fails to build on ARM/Linux
3863         https://bugs.webkit.org/show_bug.cgi?id=107926
3864
3865         Reviewed by Martin Robinson.
3866
3867         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
3868         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
3869         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
3870         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
3871
3872         * gtk/patches/make-3.82-arg-list-length.patch:
3873
3874 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3875
3876         [GTK] Close the page when the view is disposed instead of when finalized
3877         https://bugs.webkit.org/show_bug.cgi?id=129783
3878
3879         Reviewed by Sergio Villar Senin.
3880
3881         Add test case but disabled for now because it's affetected by bug #129684.
3882
3883         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
3884         (testProcessPerWebView):
3885
3886 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3887
3888         [GTK] MiniBrowser crashes when opening several urls passed as command line options
3889         https://bugs.webkit.org/show_bug.cgi?id=129738
3890
3891         Reviewed by Sergio Villar Senin.
3892
3893         The problem is that we are calling g_object_unref() for the
3894         WebKitWebSettings everytime we set it to a WebKitWebView, but the
3895         view only increases the reference counter when the settings is not
3896         the same it currently has. We should release our reference once.
3897
3898         * MiniBrowser/gtk/main.c:
3899         (createBrowserWindow):
3900         (main):
3901
3902 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3903
3904         [GTK][CMake] Tarball is created with wrong tarball paths
3905         https://bugs.webkit.org/show_bug.cgi?id=129496
3906
3907         Reviewed by Daniel Bates.
3908
3909         * gtk/make-dist.py:
3910         (Manifest.__init__): I inadvertently inverted the logic of these checks when
3911         landing the original patch with some suggestions from the reviewer. With the
3912         checks corrected, the tarball path is constructed properly.
3913
3914 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
3915
3916         Unreviewed. Update my email in contributors.json
3917
3918         * Scripts/webkitpy/common/config/contributors.json:
3919
3920 2014-03-05  Dean Jackson  <dino@apple.com>
3921
3922         [WebGL] Use WKSI to see what the system policy for WebGL is
3923         https://bugs.webkit.org/show_bug.cgi?id=129722
3924         <rdar://problem/15790542>
3925
3926         Reviewed by Tim Horton.
3927
3928         Dummy entry for setSystemWebGLLoadPolicy.
3929
3930         * WebKitTestRunner/TestController.cpp:
3931         (WTR::TestController::createWebViewWithOptions):
3932
3933 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
3934
3935         [GTK][CMake] Generate documentation for the DOM bindings
3936         https://bugs.webkit.org/show_bug.cgi?id=126211
3937
3938         Reviewed by Carlos Garcia Campos.
3939
3940         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
3941         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
3942         * gtk/generate-webkitdom-doc-files: Removed.
3943         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
3944         that it can be called by generate-gtkdoc.
3945
3946 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3947
3948         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
3949         https://bugs.webkit.org/show_bug.cgi?id=129380
3950
3951         Reviewed by Philippe Normand.
3952
3953         * Scripts/webkitdirs.pm:
3954         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
3955         skipping CMake execution.
3956
3957 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3958
3959         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
3960         https://bugs.webkit.org/show_bug.cgi?id=129651
3961
3962         Reviewed by Philippe Normand.
3963
3964         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
3965
3966 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3967
3968         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
3969         https://bugs.webkit.org/show_bug.cgi?id=129637
3970
3971         Reviewed by Carlos Garcia Campos.
3972
3973         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3974         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
3975         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
3976         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
3977         New API typically just requires a rebaseline and isn't necessarily a faiulre.
3978         (TestFactory.__init__): Add the test for GTK+.
3979         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
3980
3981 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
3982
3983         [ATK] Expose missing functionalities of AtkTableCell to AT
3984         https://bugs.webkit.org/show_bug.cgi?id=129492
3985
3986         Reviewed by Mario Sanchez Prada.
3987
3988         Reducing some code by using new API of AtkTableCell.
3989
3990         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3991         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3992
3993 2014-03-04  Alex Christensen  <achristensen@webkit.org>
3994
3995         Preparing to run layout tests on Wincairo.
3996         https://bugs.webkit.org/show_bug.cgi?id=129709
3997
3998         Reviewed by Brent Fulgham.
3999
4000         * Scripts/webkitdirs.pm:
4001         (setPathForRunningWebKitApp):
4002         Add GStreamer directory for WinCairo running layout tests.
4003         * win/DLLLauncher/DLLLauncherMain.cpp:
4004         (modifyPath):
4005         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
4006
4007 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
4008
4009         [GTK] Simplify the GObject DOM bindings API break check into one step
4010         https://bugs.webkit.org/show_bug.cgi?id=129571
4011
4012         Reviewed by Carlos Garcia Campos.
4013
4014         * GNUmakefile.am: Add the API break check to 'make check.'
4015         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
4016         * gtk/check-gdom-symbols: Removed.
4017         * gtk/webkitdom.py: Added.
4018         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
4019         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
4020
4021 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
4022
4023         Add Jeremy Jones to the contributors list as a contributor.
4024
4025         * Scripts/webkitpy/common/config/contributors.json:
4026
4027 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
4028
4029         Unreviewed. Update contact email.
4030         https://bugs.webkit.org/show_bug.cgi?id=129610
4031
4032         * Scripts/webkitpy/common/config/contributors.json:
4033
4034 2014-03-02  Brian Burg  <bburg@apple.com>
4035
4036         Web Inspector model tests load wrong inspector page under WebKitTestRunner
4037         https://bugs.webkit.org/show_bug.cgi?id=129460
4038
4039         Reviewed by Dan Bernstein.
4040
4041         Don't unconditionally open the inspector before running an inspector test.
4042         Instead, the test should request that the inspector open when it's ready.
4043
4044         This change was lost during a rebase, but is the same change made to
4045         DumpRenderTree.
4046
4047         * WebKitTestRunner/TestInvocation.cpp:
4048         (WTR::TestInvocation::invoke): 
4049
4050 2014-03-02  Darin Adler  <darin@apple.com>
4051
4052         Split TextIteratorBehavior into a separate header
4053         https://bugs.webkit.org/show_bug.cgi?id=129578
4054
4055         Reviewed by Sam Weinig.
4056
4057         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
4058         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
4059         task easy, but the remove is still a bit of a pain.
4060
4061 2014-03-02  Darin Adler  <darin@apple.com>
4062
4063         Sort Mac platform export files so they merge better
4064         https://bugs.webkit.org/show_bug.cgi?id=129581
4065
4066         Reviewed by Sam Weinig.
4067
4068         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
4069         Mac export files in a "canonical" order for this project.
4070
4071 2014-02-28  Zalan Bujtas  <zalan@apple.com>
4072
4073         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
4074         https://bugs.webkit.org/show_bug.cgi?id=129438
4075
4076         Reviewed by Simon Fraser.
4077
4078         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
4079         offscreen window. It makes testing subpixel rendering and positioning possible.
4080
4081         Both the offscreen window's and WebKit's scaling are set accordingly.
4082
4083         * DumpRenderTree/mac/DumpRenderTree.mm:
4084         (createWebViewAndOffscreenWindow): cleanup
4085         (destroyWebViewAndOffscreenWindow): cleanup
4086         (dumpRenderTree):
4087         (changeWindowScaleIfNeeded):
4088         (runTest):
4089         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
4090         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
4091         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
4092         * WebKitTestRunner/PlatformWebView.h:
4093         * WebKitTestRunner/TestInvocation.cpp:
4094         (WTR::changeWindowScaleIfNeeded):
4095         (WTR::TestInvocation::invoke):
4096         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4097         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4098         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4099         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4100         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4101         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4102         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4103         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
4104
4105 2014-02-28  Anders Carlsson  <andersca@apple.com>
4106
4107         Remove logging.
4108
4109         Reviewed by Dan Bernstein.
4110
4111         * MiniBrowser/mac/WK2BrowserWindowController.m:
4112         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
4113
4114 2014-02-28  Daniel Bates  <dabates@apple.com>
4115
4116         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
4117         https://bugs.webkit.org/show_bug.cgi?id=129163
4118
4119         Reviewed by David Kilzer.
4120
4121         Fixes an issue where DumpRenderTree Perl Support may build with the specified
4122         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
4123         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
4124         bundle.
4125
4126         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
4127         which is specified either explicitly when building with MAKE(1) or implicitly by
4128         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
4129         the OS X SDK and toolchain since the built products are only applicable to OS X.
4130
4131         * DumpRenderTree/ios/PerlSupport/Makefile:
4132
4133 2014-02-28  Commit Queue  <commit-queue@webkit.org>
4134
4135         Unreviewed, rolling out r164859.
4136         http://trac.webkit.org/changeset/164859
4137         https://bugs.webkit.org/show_bug.cgi?id=129483
4138
4139         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
4140         #webkit).
4141
4142         * DumpRenderTree/mac/DumpRenderTree.mm:
4143         (createWebViewAndOffscreenWindow):
4144         (dumpRenderTree):
4145         (runTest):
4146         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
4147         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
4148         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
4149         * WebKitTestRunner/PlatformWebView.h:
4150         * WebKitTestRunner/TestInvocation.cpp:
4151         (WTR::TestInvocation::invoke):
4152         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
4153         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4154         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
4155         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4156         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
4157
4158 2014-02-28  Zalan Bujtas  <zalan@apple.com>
4159
4160         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
4161         https://bugs.webkit.org/show_bug.cgi?id=129438
4162
4163         Reviewed by Simon Fraser.
4164
4165         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
4166         offscreen window. It makes testing subpixel rendering and positioning possible.
4167
4168         Both the offscreen window's and WebKit's scaling are set accordingly.
4169
4170         * DumpRenderTree/mac/DumpRenderTree.mm:
4171         (createWebViewAndOffscreenWindow): unrelated cleanup.
4172         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
4173         (dumpRenderTree):
4174         (changeOffscreenWindowScaleIfNeeded):
4175         (runTest):
4176         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
4177         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
4178         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
4179         * WebKitTestRunner/PlatformWebView.h:
4180         * WebKitTestRunner/TestInvocation.cpp:
4181         (WTR::changeOffscreenWindowScaleIfNeeded):
4182         (WTR::TestInvocation::invoke):
4183         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4184         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
4185
4186 2014-02-27  Brian Burg  <bburg@apple.com>
4187
4188         Web Inspector: model tests should use a special Test.html inspector page
4189         https://bugs.webkit.org/show_bug.cgi?id=129190
4190
4191         Reviewed by Timothy Hatcher.
4192
4193         Remove code that immediately opens the Web Inspector based on the file path of the test.
4194         Instead, the test page should request that the inspector open inside its `test()` method.
4195
4196         This change is necessary because otherwise, the inspector would be opened too early for
4197         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
4198         will get loaded instead of the minimal test page.
4199
4200         * DumpRenderTree/efl/DumpRenderTree.cpp:
4201         (createTestRunner):
4202         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4203         (runTest):
4204         * DumpRenderTree/mac/DumpRenderTree.mm:
4205         (runTest):
4206         * DumpRenderTree/win/DumpRenderTree.cpp:
4207         (runTest):
4208
4209 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
4210
4211         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
4212         https://bugs.webkit.org/show_bug.cgi?id=127076
4213
4214         Reviewed by Anders Carlsson.
4215
4216         Avoid match for :: as start of a member initialization list. Modify expression to match
4217         after a colon either non-colon character or end of line.
4218
4219         * Scripts/webkitpy/style/checkers/cpp.py:
4220         (check_member_initialization_list):
4221         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4222         (WebKitStyleTest.test_member_initialization_list):
4223
4224 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
4225
4226         Unreviewed. Update my email addresses in contributors.json.
4227
4228         * Scripts/webkitpy/common/config/contributors.json:
4229
4230 2014-02-27  Alberto Garcia  <berto@igalia.com>
4231
4232         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
4233         https://bugs.webkit.org/show_bug.cgi?id=128927
4234
4235         Reviewed by Philippe Normand.
4236
4237         Encode manually the data for sys.{stdout,stderr}.write.
4238
4239         * gtk/gtkdoc.py:
4240         (GTKDoc._run_command):
4241
4242 2014-02-27  Andres Gomez  <agomez@igalia.com>
4243
4244         Unreviewed. Add myself to watchlists
4245
4246         * Scripts/webkitpy/common/config/watchlist: Add myself to
4247         watchlists.
4248
4249 2014-02-27  Andres Gomez  <agomez@igalia.com>
4250
4251         Unreviewed, rolling out r164790.
4252         http://trac.webkit.org/changeset/164790
4253
4254         Revert r164790 because of erroneous commit log
4255
4256         * Scripts/webkitpy/common/config/watchlist:
4257
4258 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
4259
4260         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
4261         https://bugs.webkit.org/show_bug.cgi?id=129250
4262
4263         Reviewed by Mario Sanchez Prada.
4264
4265         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
4266         Implementing methods so that we could test column/row headers represented as an array of cells.
4267
4268         * DumpRenderTree/AccessibilityUIElement.cpp:
4269         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4270         (AccessibilityUIElement::columnHeaders):
4271         (AccessibilityUIElement::rowHeaders):
4272         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
4273         (AccessibilityUIElement::columnHeaders):
4274         (AccessibilityUIElement::rowHeaders):
4275         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4276         (WTR::AccessibilityUIElement::rowHeaders):
4277         (WTR::AccessibilityUIElement::columnHeaders):
4278         * efl/jhbuild.modules:
4279         * gtk/jhbuild.modules:
4280
4281 2014-02-27  Andres Gomez  <agomez@igalia.com>
4282
4283         Unreviewed. Add myself to watchlists
4284
4285         * Scripts/webkitpy/common/config/watchlist: Add myself to
4286         watchlists.
4287
4288 2014-02-27  Andres Gomez  <agomez@igalia.com>
4289
4290         Unreviewed. Add myself as a committer.
4291
4292         * Scripts/webkitpy/common/config/contributors.json:
4293
4294 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
4295
4296         Unreviewed. Add Víctor Jáquez and myself to watchlists
4297
4298         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
4299         myself to watchlists.
4300
4301 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
4302
4303         Unreviewed. Add myself as a committer.
4304
4305         * Scripts/webkitpy/common/config/contributors.json:
4306
4307 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
4308
4309         Unreviewed. Moved myself to the list of committers.
4310
4311         * Scripts/webkitpy/common/config/contributors.json:
4312
4313 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
4314
4315         [GTK] Reduplicate common.top_level_path in scripts
4316         https://bugs.webkit.org/show_bug.cgi?id=129291
4317
4318         Reviewed by Philippe Normand.
4319
4320         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
4321         path manipulation and weird dependencies on the jhbuild infrastructure.
4322
4323         * Scripts/run-gtk-tests: Use common again.
4324         (TestRunner._setup_testing_environment): Ditto.
4325         * gtk/check-gdom-symbols: Ditto.
4326         * gtk/common.py:
4327         (top_level_path): Re-add top_level_path..
4328         (get_build_path): Use the builtin top_level_path again.
4329         * gtk/find-make-dist-errors: Use common again.
4330         (get_missing_headers): Ditto.
4331         * gtk/generate-inspector-gresource-manifest.py: Ditto.
4332
4333 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
4334
4335         runscript: line 42: /bin/ls: Argument list too long
4336         https://bugs.webkit.org/show_bug.cgi?id=129376
4337
4338         Reviewed by Michael Saboff.
4339
4340         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
4341         We should use find instead, which generates the list of files rather than expanding them all on 
4342         the command line and spitting them back out.
4343
4344         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
4345
4346 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
4347
4348         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
4349         https://bugs.webkit.org/show_bug.cgi?id=129377