8c48545efe17a1c8ca87d449e7db2df96d13806b
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
2
3         [soup] Prevent setting or editing httpOnly cookies from JavaScript
4         https://bugs.webkit.org/show_bug.cgi?id=88760
5
6         Reviewed by Gustavo Noronha Silva.
7
8         Update libsoup to v2.39.2, glib to v2.33.2 and glib-networking
9         to v2.33.2 for both GTK and EFL ports.
10
11         * efl/jhbuild.modules:
12         * gtk/jhbuild.modules:
13
14 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
15
16         [EFL] Enable SHADOW_DOM flag
17         https://bugs.webkit.org/show_bug.cgi?id=87732
18
19         Reviewed by Kentaro Hara.
20
21         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
22         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Enable
23         SHADOW_DOM by default in DRT.
24         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
25         (onFocusCanCycle): Enable focus cycling in EFL DRT to behave like
26         Chromium and Mac ports.
27         (drtViewAdd):
28         * Scripts/webkitperl/FeatureList.pm: Enable SHADOW_DOM flag by default
29         at compile time for EFL port.
30
31 2012-06-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
32
33         WinLauncher should show loading errors
34         https://bugs.webkit.org/show_bug.cgi?id=80760
35
36         Reviewed by Brent Fulgham.
37
38         * WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
39         (WinLauncherWebHost::didFailProvisionalLoadWithError):
40         * WinLauncher/WinLauncher.h:
41         (WinLauncherWebHost::didFailProvisionalLoadWithError):
42         (WinLauncherWebHost):
43
44 2012-06-12  Ryuan Choi  <ryuan.choi@samsung.com>
45
46         [EFL][WK2] Add MiniBrowserEfl.
47         https://bugs.webkit.org/show_bug.cgi?id=61850
48
49         Reviewed by Chang Shu.
50
51         Implement MiniBrowser for EFL.
52
53         * CMakeLists.txt:
54         * MiniBrowser/efl/CMakeLists.txt: Added.
55         * MiniBrowser/efl/main.c: Added.
56         (_MiniBrowser):
57         (main_signal_exit):
58         (on_ecore_evas_resize):
59         (browserCreate):
60         (main):
61
62 2012-06-12  Helder Correia  <helder.correia@nokia.com>
63
64         Unreviewed. Update my email address in committers.py.
65
66         * Scripts/webkitpy/common/config/committers.py:
67
68 2012-06-12  Dominik Röttsches  <dominik.rottsches@intel.com>
69
70         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
71         https://bugs.webkit.org/show_bug.cgi?id=84707
72
73         Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
74         use_lib64 variable is preconfigured to True by jhbuild.
75
76         Reviewed by Dirk Pranke.
77
78         * efl/jhbuildrc:
79
80 2012-06-12  Dana Jansens  <danakj@chromium.org>
81
82         Add zlieber@chromium.org to contributors list
83         https://bugs.webkit.org/show_bug.cgi?id=88904
84
85         Unreviewed.
86
87         * Scripts/webkitpy/common/config/committers.py:
88
89 2012-06-12  Lucas Forschler  <lforschler@apple.com>
90
91         Rename Apple bots to a standard convention.
92         https://bugs.webkit.org/show_bug.cgi?id=88893
93         
94         Note: This has the side effect of grouping all of the Apple bots together in the waterfall.
95
96         Reviewed by Simon Fraser.
97
98         * BuildSlaveSupport/build.webkit.org-config/config.json:
99
100 2012-06-12  Mike West  <mkwst@chromium.org>
101
102         Make document.documentURI readonly from JavaScript
103         https://bugs.webkit.org/show_bug.cgi?id=65187
104
105         Reviewed by Alexey Proskuryakov.
106
107         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
108         * TestWebKitAPI/Tests/mac/SetDocumentURI.html: Added.
109         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm: Added.
110         (-[SetDocumentURITest webView:didFinishLoadForFrame:]):
111         (TestWebKitAPI):
112         (TestWebKitAPI::TEST):
113
114 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
115
116         [EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag
117         https://bugs.webkit.org/show_bug.cgi?id=88715
118
119         Reviewed by Noam Rosenthal.
120
121         Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.
122
123         * Scripts/webkitperl/FeatureList.pm:
124
125 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
126
127         [Qt] Fix -Werror for the buildbots
128         https://bugs.webkit.org/show_bug.cgi?id=88223
129
130         Rubber-stamped by Tor Arne Vestbø.
131
132         Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
133
134         * qmake/mkspecs/features/unix/default_post.prf:
135
136 2012-06-12  Balazs Kelemen  <kbalazs@webkit.org>
137
138         [REGRESSION][WTR] Build fail with werror after r120054
139         https://bugs.webkit.org/show_bug.cgi?id=88862
140
141         Reviewed by Csaba Osztrogonác.
142
143         Some static helpers become unused after counterValueForElementById
144         has moved to Internals. Let's remove them.
145
146         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
147         (WTR):
148
149 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
150
151         [Qt] Slave losts cause build break on bots
152         https://bugs.webkit.org/show_bug.cgi?id=38980
153
154         Minor fix after r59261.
155
156         Reviewed by Tor Arne Vestbø.
157
158         * Scripts/build-webkit:
159         (unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.
160
161 2012-06-11  Kaustubh Atrawalkar  <kaustubh@motorola.com>
162
163         [DRT] LTC:: counterValueForElementById() could be moved to Internals.
164         https://bugs.webkit.org/show_bug.cgi?id=84406
165
166         Reviewed by Hajime Morita.
167
168         Move the counterValueForElementById from LayoutTestCotroller to Internals and
169         remove the old platform specific implementations as it exclusively tests WebCore functionality.
170
171         * DumpRenderTree/LayoutTestController.cpp:
172         (LayoutTestController::staticFunctions):
173         * DumpRenderTree/LayoutTestController.h:
174         (LayoutTestController):
175         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
176         * DumpRenderTree/chromium/LayoutTestController.cpp:
177         (LayoutTestController::LayoutTestController):
178         (LayoutTestController::setPOSIXLocale):
179         * DumpRenderTree/chromium/LayoutTestController.h:
180         (LayoutTestController):
181         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
182         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
183         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
184         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
185         * DumpRenderTree/qt/LayoutTestControllerQt.h:
186         (LayoutTestController):
187         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
188         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
189         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
190         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
191         (WTR):
192         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
193         (LayoutTestController):
194
195 2012-06-11  Hans Wennborg  <hans@chromium.org>
196
197         Speech JavaScript API: Make SpeechRecognitionError an Event
198         https://bugs.webkit.org/show_bug.cgi?id=88784
199
200         Reviewed by Adam Barth.
201
202         Make it possible to have MockWebSpeechRecognizer fire error events.
203
204         * DumpRenderTree/chromium/LayoutTestController.cpp:
205         (LayoutTestController::LayoutTestController):
206         (LayoutTestController::setMockSpeechRecognitionError):
207         * DumpRenderTree/chromium/LayoutTestController.h:
208         (LayoutTestController):
209         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
210         (WebKit):
211         (ErrorTask):
212         (WebKit::ErrorTask::ErrorTask):
213         (MockWebSpeechRecognizer::addMockResult):
214         (MockWebSpeechRecognizer::setError):
215         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
216         (MockWebSpeechRecognizer):
217
218 2012-06-11  Ojan Vafai  <ojan@chromium.org>
219
220         Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
221         https://bugs.webkit.org/show_bug.cgi?id=88836
222
223         Reviewed by Dirk Pranke.
224
225         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
226         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
227
228 2012-06-11  Christophe Dumez  <christophe.dumez@intel.com>
229
230         [EFL] Remove CMakeCache.txt before building
231         https://bugs.webkit.org/show_bug.cgi?id=88717
232
233         Reviewed by Antonio Gomes.
234
235         Remove CMake cache file before every build to avoid using outdated
236         build flags when new features get enabled. This will avoid unexpected
237         failures on the bots due to outdated build flags.
238
239         * Scripts/webkitdirs.pm:
240         (generateBuildSystemFromCMakeProject):
241
242 2012-06-11  Vincent Scheib  <scheib@chromium.org>
243
244         Add new Pointer Lock spec attribute webkitPointerLockElement.
245         https://bugs.webkit.org/show_bug.cgi?id=88799
246
247         Reviewed by Dimitri Glazkov.
248
249         Part of a series of refactoring changes to update pointer lock API to
250         the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
251
252         New attribute webkitPointerLockElement added. Follow up patches
253         will remove the previous isLocked attribute. Tests updated to use
254         the new attribute.
255
256         WebViewHost logic required modification to correctly repond to
257         a lock, unlock, pointerLockElement call series. Specifically,
258         unlocking must be queued after a lock command is issued always
259         as the lock state may not be set yet with a lock request in flight.
260
261         * DumpRenderTree/chromium/WebViewHost.cpp:
262         (WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
263         (WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
264
265 2012-06-11  Alexis Menard  <alexis.menard@openbossa.org>
266
267         [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
268         https://bugs.webkit.org/show_bug.cgi?id=88804
269
270         Reviewed by Tony Chang.
271
272         Protect box-decoration-break behind a feature flag enabled by default.
273
274         * Scripts/webkitperl/FeatureList.pm:
275         * qmake/mkspecs/features/features.pri:
276
277 2012-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
278
279         [CMAKE][EFL] Remove duplicated executable output path
280         https://bugs.webkit.org/show_bug.cgi?id=88765
281
282         Reviewed by Daniel Bates.
283
284         CMake files for EFL port have redefined executable output path. However, EFL port doesn't
285         need to define again because it is already defined in top-level CMake file.
286
287         * DumpRenderTree/efl/CMakeLists.txt:
288         * EWebLauncher/CMakeLists.txt:
289
290 2012-06-11  Ojan Vafai  <ojan@chromium.org>
291
292         Don't consider show warnings in the garden-o-matic UI for non-layout test failures
293         https://bugs.webkit.org/show_bug.cgi?id=88816
294
295         Reviewed by Dirk Pranke.
296
297         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
298         Expose a way to clear AsynchronousCaches.
299         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
300         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
301         Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.
302
303 2012-06-11  Dirk Pranke  <dpranke@chromium.org>
304
305         nrwt exits early too frequently
306         https://bugs.webkit.org/show_bug.cgi?id=73843
307
308         Reviewed by Ryosuke Niwa.
309
310         Change the defaults for new-run-webkit-tests for both
311         --exit-after-n-failures and --exit-after-n-crashes-or-timeouts
312         to zero (i.e., we will never exit early by default).
313
314         If people want their buildbots to exit early it is their
315         responsibility to update their buildbot configs appropriately.
316
317         Note that we have tests that ensure that these flags work for
318         non-zero numbers, but we don't have tests that either test the
319         default or ensure that zero means "run all of the tests". I
320         think that's okay but can add tests if others disagree.
321
322         Also note that it looks like no changes on the build.webkit.org
323         master.cfg are necessary; all of the bots seem to be using the
324         RunWebKitTests wrapper which is already setting the flags. There
325         is a NewRunWebKitTests wrapper, but that looks to be unused; I
326         will delete that in a separate patch.
327
328         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
329         (parse_args):
330
331 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
332
333         [EFL] [DRT] Reset CacheModel before running each test
334         https://bugs.webkit.org/show_bug.cgi?id=87534
335
336         Reviewed by Gustavo Noronha Silva.
337
338         Reset cache model to default before running each test to fix some
339         flaky tests on EFL build bots. Also fix case value in setCacheModel.
340
341         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
342         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
343         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
344         (LayoutTestController::setCacheModel):
345
346 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
347
348         [GTK] Memory leaks in DRT EventSender.cpp
349         https://bugs.webkit.org/show_bug.cgi?id=88774
350
351         Reviewed by Martin Robinson.
352
353         Fix a few possible memory leaks in EventSender code.
354
355         * DumpRenderTree/gtk/EventSender.cpp:
356         (contextClickCallback): Free the event returned by gdk_event_new().
357         (mouseDownCallback): Ditto.
358         (mouseUpCallback): Ditto.
359
360 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
361
362         [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
363         https://bugs.webkit.org/show_bug.cgi?id=88661
364
365         Reviewed by Dirk Pranke.
366
367         Pass string length explicitly when creating String object from
368         non-null-terminated UChar* returned by characters().
369
370         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
371         (LayoutTestController::pathToLocalResource):
372
373 2012-06-11  David Dorwin  <ddorwin@chromium.org>
374
375         [chromium] Provide access to the WebPlugin created by the helper plugin widget
376         https://bugs.webkit.org/show_bug.cgi?id=88028
377
378         Reviewed by Adam Barth.
379
380         Added isPlaceholder() to WebPlugin.
381
382         * DumpRenderTree/chromium/TestWebPlugin.h:
383         (TestWebPlugin::isPlaceholder):
384
385 2012-06-11  Tony Chang  <tony@chromium.org>
386
387         rebaseline from garden-o-matic leaves N processes each time it is run
388         https://bugs.webkit.org/show_bug.cgi?id=88586
389
390         Reviewed by Dirk Pranke.
391
392         This appears to only be a problem on python 2.7. Maybe a bug causing
393         pools to not be garbage collected?
394
395         * Scripts/webkitpy/common/system/executive.py:
396         (Executive.run_in_parallel): close() and join() the process pool.
397         * Scripts/webkitpy/common/system/executive_unittest.py:
398         (ExecutiveTest.test_run_in_parallel):
399
400 2012-06-11  Zoltan Horvath  <zoltan@webkit.org>
401
402         [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
403         https://bugs.webkit.org/show_bug.cgi?id=87841
404
405         Reviewed by Simon Hausmann.
406
407         * qmake/config.tests/libwebp/libwebp.cpp: Added.
408         (main):
409         * qmake/config.tests/libwebp/libwebp.pro: Added.
410         * qmake/sync.profile:
411
412 2012-06-10  Ryosuke Niwa  <rniwa@webkit.org>
413
414         Expose layoutTestController as testRunner
415         https://bugs.webkit.org/show_bug.cgi?id=88210
416
417         Reviewed by Darin Adler.
418
419         * DumpRenderTree/LayoutTestController.cpp:
420         (LayoutTestController::makeWindowObject):
421         * DumpRenderTree/chromium/TestShell.cpp:
422         (TestShell::bindJSObjectsToWindow):
423         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
424         (WebCore::DumpRenderTree::initJSObjects):
425         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
426         (WTR::LayoutTestController::makeWindowObject):
427
428 2012-06-09  Dominic Cooney  <dominicc@chromium.org>
429
430         [Chromium] Remove JavaScriptCore dependencies from gyp
431         https://bugs.webkit.org/show_bug.cgi?id=88510
432
433         Reviewed by Adam Barth.
434
435         Chromium doesn't support JSC any more and there doesn't seem to be
436         a strong interest in using GYP as the common build system in other
437         ports.
438
439         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
440         * Scripts/generate-project-files: Removed.
441
442 2012-06-09  Sukolsak Sakshuwong  <sukolsak@google.com>
443
444         Add UNDO_MANAGER flag
445         https://bugs.webkit.org/show_bug.cgi?id=87908
446
447         Reviewed by Tony Chang.
448
449         * Scripts/webkitperl/FeatureList.pm:
450         * qmake/mkspecs/features/features.pri:
451
452 2012-06-08  Ryosuke Niwa  <rniwa@webkit.org>
453
454         webkit-patch land-safely should set cq? if the patch author is not in committers.py
455         https://bugs.webkit.org/show_bug.cgi?id=88689
456
457         Reviewed by Dirk Pranke.
458
459         When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
460         in committers.py or the contributor cannot commit. If anything, the contributor can still
461         set cq+ on thier patches manually so I don't think this will be an issue for people who
462         don't list their Bugzille email on committers.py.
463
464         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
465         (Bugzilla._commit_queue_flag):
466         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
467         (test_commit_queue_flag):
468         (test_commit_queue_flag.assert_commit_queue_flag):
469
470 2012-06-08  Dirk Pranke  <dpranke@chromium.org>
471
472         remove obsolete NewRunWebKitTests buildbot master factory classes
473         https://bugs.webkit.org/show_bug.cgi?id=88693
474
475         Reviewed by Ryosuke Niwa.
476
477         I believe these aren't used any more ...
478
479         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
480         (RunWebKitTests.getText2):
481         (BuildAndTestLeaksFactory):
482
483 2012-06-08  Xianzhu Wang  <wangxianzhu@chromium.org>
484
485         [Chromium-Android] Build DumpRenderTree with Android SDK
486         https://bugs.webkit.org/show_bug.cgi?id=88598
487
488         Change WebKit side of DRT related code according to some recent changes at chromium side.
489
490         Reviewed by Adam Barth.
491
492         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
493         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
494         (ChromiumAndroidPort.__init__):
495         (ChromiumAndroidPort._path_to_driver):
496
497 2012-06-08  Wei James  <james.wei@intel.com>
498
499         Add app_abi option for DumpRenderTree_apk
500         https://bugs.webkit.org/show_bug.cgi?id=88626
501
502         Reviewed by Adam Barth.
503
504         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
505
506 2012-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
507
508         [GTK] Add API to get the library version to WebKit2 GTK+
509         https://bugs.webkit.org/show_bug.cgi?id=88426
510
511         Reviewed by Martin Robinson.
512
513         * gtk/generate-gtkdoc:
514         (get_webkit2_options): Add built sources to the list of files, but
515         ignore enum types and marshallers.
516
517 2012-06-07  Vincent Scheib  <scheib@chromium.org>
518
519         Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
520         https://bugs.webkit.org/show_bug.cgi?id=88604
521
522         Reviewed by Kent Tamura.
523
524         DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
525         Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
526
527         * DumpRenderTree/chromium/WebViewHost.cpp:
528         (WebViewHost::requestPointerUnlock):
529
530 2012-06-08  Hans Wennborg  <hans@chromium.org>
531
532         Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
533         https://bugs.webkit.org/show_bug.cgi?id=87976
534
535         Reviewed by Kent Tamura.
536
537         Provide a mock implementation of WebSpeechRecognizer for
538         DumpRenderTree. This will allow better testing of the API via layout
539         tests.
540
541         * DumpRenderTree/DumpRenderTree.gypi:
542         * DumpRenderTree/chromium/LayoutTestController.cpp:
543         (LayoutTestController::LayoutTestController):
544         (LayoutTestController::addMockSpeechRecognitionResult):
545         * DumpRenderTree/chromium/LayoutTestController.h:
546         (LayoutTestController):
547         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
548         (MockWebSpeechRecognizer::create):
549         (MockWebSpeechRecognizer::start):
550         (MockWebSpeechRecognizer::stop):
551         (MockWebSpeechRecognizer::abort):
552         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
553         (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
554         (MockWebSpeechRecognizer::ResultTask::runIfValid):
555         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
556         (WebKit):
557         (MockWebSpeechRecognizer):
558         (MockWebSpeechRecognizer::addMockResult):
559         (MockWebSpeechRecognizer::taskList):
560         (ClientCallTask):
561         (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
562         (ResultTask):
563         (MockWebSpeechRecognizer::ResultTask::ResultTask):
564         (NoMatchTask):
565         (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
566         * DumpRenderTree/chromium/WebViewHost.cpp:
567         (WebViewHost::speechRecognizer):
568         * DumpRenderTree/chromium/WebViewHost.h:
569         (WebViewHost):
570         (WebViewHost::mockSpeechRecognizer):
571
572 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
573
574         check-webkit-style needs to be taught about <public/Foo.h>
575         https://bugs.webkit.org/show_bug.cgi?id=88524
576
577         Reviewed by David Levin.
578
579         * Scripts/webkitpy/style/checkers/cpp.py:
580         (_classify_include):
581         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
582         (OrderOfIncludesTest.test_public_primary_header):
583         (OrderOfIncludesTest.test_classify_include):
584
585 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
586
587         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
588         https://bugs.webkit.org/show_bug.cgi?id=67255
589
590         Reviewed by Dirk Pranke.
591
592         Implement pathToLocalResource to redirect file:///tmp URL's to
593         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
594         LayoutTests sub-directory of the WebKit source tree.
595
596         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
597         (LayoutTestController::pathToLocalResource):
598
599 2012-06-07  Tony Payne  <tpayne@chromium.org>
600
601         [chromium] Allow LayoutTests under new git workflow
602         https://bugs.webkit.org/show_bug.cgi?id=88575
603
604         On Windows, chromium indirects through git.bat. Adds the same hack that
605         is currently used for discovering svn.bat to support the new git
606         workflow.
607
608         Reviewed by Dirk Pranke.
609
610         * Scripts/webkitpy/common/checkout/scm/git.py:
611         (Git): Replaces all hard-coded references to 'git' with the class
612         variable executable_name.
613         (Git._check_git_architecture):
614         (Git.in_working_directory):
615         (Git.find_checkout_root):
616         (Git.read_git_config):
617         (Git.discard_local_commits):
618         (Git.local_commits):
619         (Git.working_directory_is_clean):
620         (Git.clean_working_directory):
621         (Git.status_command):
622         (Git.add_list):
623         (Git.delete_list):
624         (Git.exists):
625         (Git._current_branch):
626         (Git.changed_files):
627         (Git._changes_files_for_commit):
628         (Git.revisions_changing_file):
629         (Git.conflicted_files):
630         (Git.svn_revision):
631         (Git.create_patch):
632         (Git._run_git_svn_find_rev):
633         (Git.contents_at_revision):
634         (Git.diff_for_file):
635         (Git.show_head):
636         (Git.committer_email_for_revision):
637         (Git.apply_reverse_diff):
638         (Git.revert_files):
639         (Git.commit_with_message):
640         (Git._commit_on_branch):
641         (Git.svn_commit_log):
642         (Git.last_svn_commit_log):
643         (Git.svn_blame):
644         (Git._branch_ref_exists):
645         (Git.delete_branch):
646         (Git.remote_merge_base):
647         (Git.commit_locally_with_message):
648         (Git.push_local_commits_to_server):
649         (Git.commit_ids_from_commitish_arguments):
650         (Git.commit_message_for_local_commit):
651         (Git.files_changed_summary_for_commit):
652         * Scripts/webkitpy/common/host.py:
653         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
654         that duplicates the logic in the existing 'svn.bat' hack.
655
656 2012-06-07  Ojan Vafai  <ojan@chromium.org>
657
658         Style build architectures like build versions for non-layout test failures
659         https://bugs.webkit.org/show_bug.cgi?id=88590
660
661         Reviewed by Tony Chang.
662
663         Since we show the list of failing tests after the architecture, we want the
664         buildtype and architecture to be grouped together visually.
665
666         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
667         (.effects a.failing-builder>span.architecture):
668
669 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
670
671         [Chromium] Remove header dependency of ImageDiff to WTF
672         https://bugs.webkit.org/show_bug.cgi?id=88422
673
674         Reviewed by Ryosuke Niwa.
675
676         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
677         * DumpRenderTree/chromium/ImageDiff.cpp:
678         (untestedCompareImages):
679
680 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
681
682         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
683         https://bugs.webkit.org/show_bug.cgi?id=88491
684
685         Reviewed by Dirk Pranke.
686
687         DRT should enable WebAudio when WebAudio feature is enabled,
688         so that the WebAudio feature could be tested by the Layouttest.
689
690         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
691         (LayoutTestController::overridePreference):
692
693 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
694
695         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
696         https://bugs.webkit.org/show_bug.cgi?id=88581
697
698         Reviewed by Ojan Vafai.
699
700         webkit-paptch rebaseline-expectations was ignoring what the
701         expected results for a test were and pulling down all the result
702         files from a bot. This could lead to us pulling down old,
703         incorrect .txt or .png files. With this patch we will now only
704         pull down expectations of the appropriate file types (so an
705         IMAGE failure will only pull the png and not the txt file).
706
707         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
708         (has_pixel_failures):
709         (suffixes_for_expectations):
710         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
711         (FunctionsTest.test_suffixes_for_expectations):
712         * Scripts/webkitpy/tool/commands/rebaseline.py:
713         (AbstractRebaseliningCommand.__init__):
714         (RebaselineExpectations._is_supported_port):
715         (RebaselineExpectations._update_expectations_file):
716         (RebaselineExpectations._tests_to_rebaseline):
717         (RebaselineExpectations._rebaseline_port):
718         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
719         (test_overrides_are_included_correctly):
720
721 2012-06-07  Ojan Vafai  <ojan@chromium.org>
722
723         Fix recent null pointer error regression in the flakiness dashboard
724         https://bugs.webkit.org/show_bug.cgi?id=88573
725
726         Reviewed by Dirk Pranke.
727
728         * TestResultServer/static-dashboards/builders.js:
729         (requestBuilderList):
730         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
731
732 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
733
734         Add Konrad Piascik to committers.py
735         https://bugs.webkit.org/show_bug.cgi?id=88560
736
737         Unreviewed.
738
739         * Scripts/webkitpy/common/config/committers.py:
740
741 2012-06-07  Tony Chang  <tony@chromium.org>
742
743         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
744         https://bugs.webkit.org/show_bug.cgi?id=77368
745
746         Reviewed by Ojan Vafai.
747
748         It doesn't look like we ever get a rect with width or height of 0.
749         I ran css1, css2.1, fast/forms, and tables without any crashes.
750
751         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
752         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
753
754 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
755
756         run-webkit-tests --lint-test-files gives an error when run on linux
757         https://bugs.webkit.org/show_bug.cgi?id=88551
758
759         Reviewed by Ojan Vafai.
760
761         We weren't mapping the expectations properly for the
762         google-chrome ports.
763
764         * Scripts/webkitpy/layout_tests/port/base.py:
765         (Port.path_to_test_expectations_file):
766         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
767         (TestGoogleChromePort.test_path_to_expectations):
768
769 2012-06-07  Daniel Erat  <derat@chromium.org>
770
771         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
772         https://bugs.webkit.org/show_bug.cgi?id=88263
773
774         Reviewed by Tony Chang.
775
776         * DumpRenderTree/chromium/LayoutTestController.cpp:
777         (LayoutTestController::LayoutTestController):
778         (LayoutTestController::reset):
779         (LayoutTestController::setTextSubpixelPositioning):
780         * DumpRenderTree/chromium/LayoutTestController.h:
781         (LayoutTestController):
782         * DumpRenderTree/chromium/fonts.conf:
783
784 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
785
786         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
787         https://bugs.webkit.org/show_bug.cgi?id=88060
788
789         Reviewed by Martin Robinson.
790
791         Spin the main loop before acquiring the pixel content. This ensures things
792         like late size allocations are finished before calling gtk_widget_draw,
793         avoiding assertions and subsequent empty pixel results.
794
795         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
796         (createBitmapContextFromWebView):
797
798 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
799
800         [Qt] Improve the visual of the viewport info box
801         https://bugs.webkit.org/show_bug.cgi?id=88410
802
803         Reviewed by Tor Arne Vestbø.
804
805         Improve the visual and make it possible to see the content more easy.
806
807         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
808
809 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
810
811         [EFL][WK2] Compile webkit1 and webkit2 by default.
812         https://bugs.webkit.org/show_bug.cgi?id=85041
813
814         Reviewed by Chang Shu.
815
816         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
817         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
818
819         * Scripts/build-webkit:
820
821 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
822
823         Unreviewed, rolling out r119662.
824         http://trac.webkit.org/changeset/119662
825         https://bugs.webkit.org/show_bug.cgi?id=88487
826
827         Broke builds (Requested by rniwa on #webkit).
828
829         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
830         * DumpRenderTree/chromium/ImageDiff.cpp:
831         (untestedCompareImages):
832
833 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
834
835         [Chromium] Remove header dependency of ImageDiff to WTF
836         https://bugs.webkit.org/show_bug.cgi?id=88422
837
838         Reviewed by Adam Barth.
839
840         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
841         * DumpRenderTree/chromium/ImageDiff.cpp:
842         (untestedCompareImages):
843
844 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
845
846         [WebKit] DeviceOrientation cleanup
847         https://bugs.webkit.org/show_bug.cgi?id=88406
848
849         Reviewed by Kent Tamura.
850
851         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
852
853         * DumpRenderTree/chromium/LayoutTestController.cpp:
854         (LayoutTestController::setMockDeviceOrientation):
855
856 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
857
858         webkitpy: add support for an ordered dict of test expectations
859         https://bugs.webkit.org/show_bug.cgi?id=87802
860
861         Reviewed by Ojan Vafai.
862
863         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
864         support a cascaded list of test expectations files. An easy way
865         to think of this is as an ordered dictionary of name -> contents
866         for files, where the name is usually a path on disk (I say
867         usually because we want to support other kinds of expectations
868         like the compile-time skips for unsupported features in
869         webkit.py, and we want to continue to support "in-memory" test
870         expectations that don't require a filesystem).
871
872         Conveniently there is an OrderedDict implementation in Python
873         2.7+ and it is available as a backport, so the first step in
874         adding this support is to use that implementation. Subsequent
875         patches will update the test_expectations.py module (and other
876         callers) to access the dict directly.
877
878         This patch just changes the base internal implementation and
879         provides wrappers for compatibility. The derived ports
880         (WebKitPort, TestPort, etc.) still need to be updated.
881
882         * Scripts/webkitpy/layout_tests/port/base.py:
883         (Port._expectations_dict):
884         (Port.test_expectations):
885         (Port):
886         (Port._expectations_overrides_dict):
887         (Port.test_expectations_overrides):
888         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
889         (PortTestCase.test_expectations_ordering):
890         (PortTestCase):
891         (PortTestCase.test_expectations_overrides_ordering):
892         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
893         (OrderedDict):
894         (OrderedDict.__init__):
895         (OrderedDict.clear):
896         (OrderedDict.__setitem__):
897         (OrderedDict.__delitem__):
898         (OrderedDict.__iter__):
899         (OrderedDict.__reversed__):
900         (OrderedDict.popitem):
901         (OrderedDict.__reduce__):
902         (OrderedDict.__repr__):
903         (OrderedDict.copy):
904         (OrderedDict.fromkeys):
905
906 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
907
908         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
909
910         * gtk/run-api-tests:
911         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
912
913 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
914
915         nrwt should look in 'out' for binaries on chromium win to support ninja
916         https://bugs.webkit.org/show_bug.cgi?id=88273
917
918         Reviewed by Tony Chang.
919
920         This patch standardizes the search algorithm the chromium ports
921         use to figure out which driver to run. We will look in a
922         chromium location before a webkit location (e.g., in
923         Source/WebKit/chromium/out before out/) and we will look in the
924         "legacy" directory (xcodebuild) before the directory ninja uses
925         (out).
926
927         Unfortunately due to the way the test code is set up testing the
928         properly requires some duplication of test code. I will fix that
929         in a followup patch.
930
931         * Scripts/webkitpy/layout_tests/port/chromium.py:
932         (ChromiumPort):
933         (ChromiumPort._static_build_path):
934         (ChromiumPort._build_path):
935         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
936         (ChromiumLinuxPort):
937         (ChromiumLinuxPort._determine_driver_path_statically):
938         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
939         (ChromiumLinuxPortTest.test_build_path):
940         (ChromiumLinuxPortTest):
941         (ChromiumLinuxPortTest.test_driver_name_option):
942         (ChromiumLinuxPortTest.path_to_image_diff):
943         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
944         (ChromiumMacPort):
945         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
946         (ChromiumMacPortTest.test_build_path):
947         (ChromiumMacPortTest):
948         (ChromiumMacPortTest.test_driver_name_option):
949         (ChromiumMacPortTest.path_to_image_diff):
950         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
951         (ChromiumPortTest.test_overrides_and_builder_names):
952         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
953         (ChromiumWinPort):
954         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
955         (ChromiumWinTest.test_build_path):
956         (ChromiumWinTest.test_operating_system):
957         (ChromiumWinTest):
958         (ChromiumWinTest.test_driver_name_option):
959         (ChromiumWinPortTest.path_to_image_diff):
960         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
961         (PortTestCase.assert_build_path):
962
963 2012-06-06  Jessie Berlin  <jberlin@apple.com>
964
965         Remove very red Windows WebKit2 testers
966         https://bugs.webkit.org/show_bug.cgi?id=88452
967
968         Reviewed by Steve Falkenburg.
969
970         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
971         need to focus on getting the WK1 testers green.
972
973         * BuildSlaveSupport/build.webkit.org-config/config.json:
974
975 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
976
977         get rebaselining tools to kinda work with the skia overrides file
978         https://bugs.webkit.org/show_bug.cgi?id=88456
979
980         Reviewed by Ryosuke Niwa.
981
982         Update rebaseline-expectations so that we read in the overrides
983         when looking for tests to rebaseline, but don't read in the
984         overrides when we are writing the expectations file back out.
985         This prevents the overrides from getting written into the main
986         file. This is kind of a hack but will have to do until we
987         support multiple expectations files properly.
988
989         * Scripts/webkitpy/tool/commands/rebaseline.py:
990         (RebaselineExpectations._expectations):
991         (RebaselineExpectations._update_expectations_file):
992         (RebaselineExpectations._tests_to_rebaseline):
993         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
994         (test_overrides_are_included_correctly):
995
996 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
997
998         webkitpy: two manager_worker_broker_unittest tests are broken
999         https://bugs.webkit.org/show_bug.cgi?id=88445
1000
1001         Reviewed by Ojan Vafai.
1002
1003         These tests were never updated when we removed the
1004         --worker-model argument, and we were passing 'inline' instead of
1005         1 (for the number of workers) :(. As a result we were creating
1006         multiprocessing queues unnecessarily and that was failing on cygwin.
1007
1008         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1009         (InterfaceTest.test_managerconnection_is_abstract):
1010         (InterfaceTest.test_workerconnection_is_abstract):
1011
1012 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
1013
1014         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
1015         https://bugs.webkit.org/show_bug.cgi?id=87406
1016
1017         Reviewed by Dirk Pranke.
1018
1019         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1020         (TestExpectations.__init__):
1021         * Scripts/webkitpy/tool/commands/rebaseline.py:
1022         (RebaselineTest._update_expectations_file):
1023         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1024         (test_rebaseline_does_not_include_overrides):
1025
1026 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
1027
1028         webkitpy: perf tests unit tests fail on chromium win
1029         https://bugs.webkit.org/show_bug.cgi?id=88279
1030
1031         Reviewed by Ryosuke Niwa.
1032
1033         I'm seeing weird failures running the unit tests in my win32
1034         checkout, and we don't really expect webpagereplay to work on
1035         win32 anyway, so I'm skipping the import of that module for now
1036         and adding a warning.
1037
1038         * Scripts/run-perf-tests:
1039         * Scripts/webkitpy/performance_tests/perftest.py:
1040
1041 2012-06-06  Yong Li <yoli@rim.com>
1042
1043         Unreviewed. Update my email address in committers.py.
1044
1045         * Scripts/webkitpy/common/config/committers.py:
1046
1047 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
1048
1049         Add Robert Kroeger  to commiters.py
1050         https://bugs.webkit.org/show_bug.cgi?id=88415
1051
1052         Unreviewed.
1053
1054         * Scripts/webkitpy/common/config/committers.py:
1055
1056 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1057
1058         [EFL][DRT] http/tests/globalhistory testcases do not pass
1059         https://bugs.webkit.org/show_bug.cgi?id=82579
1060
1061         Reviewed by Csaba Osztrogonác.
1062
1063         DRT has provided callbacks for ewk_view "global history delegate" signals.
1064
1065         * DumpRenderTree/efl/DumpRenderTree.cpp:
1066         (isGlobalHistoryTest): Aux function to ident global history testcase.
1067         (createLayoutTestController):
1068         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1069         (DumpRenderTreeChrome::createView):
1070         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
1071         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
1072         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
1073         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
1074         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
1075         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1076         (DumpRenderTreeChrome):
1077
1078 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
1079
1080         [Qt] run-qtwebkit-tests hangs with -j1
1081         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
1082         This could happen due to an uncancelled timer after results were returned. This timer was
1083         started only if --timeout was set.
1084         https://bugs.webkit.org/show_bug.cgi?id=85475
1085
1086         Reviewed by Csaba Osztrogonác.
1087
1088         * Scripts/run-qtwebkit-tests:
1089         (run_test):
1090
1091 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
1092
1093         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
1094         https://bugs.webkit.org/show_bug.cgi?id=88327
1095
1096         Reviewed by Kenneth Rohde Christiansen.
1097
1098         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
1099         * MiniBrowser/qt/icons/contents_width.png: Added.
1100         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
1101         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
1102
1103 2012-06-05  Jon Lee  <jonlee@apple.com>
1104
1105         Buildbot fix.
1106
1107         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
1108         in the function. Store in a local variable.
1109         (loadBuilderConfig):
1110
1111 2012-06-05  Jon Lee  <jonlee@apple.com>
1112
1113         Buildbot fix.
1114
1115         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1116         (loadBuilderConfig):
1117
1118 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1119
1120         webkitpy: clean up win-specific path handling and tests
1121         https://bugs.webkit.org/show_bug.cgi?id=88281
1122
1123         Reviewed by Adam Barth.
1124
1125         There was a bunch of inconsistent logic for handling path
1126         conversions for win32 and cygwin paths due to us sometimes
1127         looking at sys.platform and sometimes using mock hosts. This
1128         patch cleans everything up so that we are required to pass
1129         PlatformInfo objects to the path module and stop trying to do
1130         different things when running on cygwin or win32 hosts (except
1131         in the path_unittest module itself).
1132
1133         This may slightly reduce test coverage for the win32 code paths
1134         but will be a lot easier to follow and maintain.
1135
1136         * Scripts/webkitpy/common/system/path.py:
1137         (abspath_to_uri):
1138         (_convert_path):
1139         * Scripts/webkitpy/common/system/path_unittest.py:
1140         (AbspathTest.platforminfo):
1141         (AbspathTest.test_abspath_to_uri_cygwin):
1142         (AbspathTest.test_abspath_to_uri_unixy):
1143         (AbspathTest.test_abspath_to_uri_win):
1144         (AbspathTest.test_abspath_to_uri_escaping_unixy):
1145         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
1146         (AbspathTest.test_stop_cygpath_subprocess):
1147         * Scripts/webkitpy/common/system/platforminfo.py:
1148         (PlatformInfo.__init__):
1149         (PlatformInfo.is_cygwin):
1150         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1151         (MockPlatformInfo.is_cygwin):
1152         * Scripts/webkitpy/layout_tests/port/base.py:
1153         (Port.to.show_results_html_file):
1154         * Scripts/webkitpy/layout_tests/port/driver.py:
1155         (Driver.test_to_uri):
1156         (Driver.uri_to_test):
1157         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1158         (DriverTest.test_test_to_uri):
1159         (DriverTest.test_uri_to_test):
1160         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1161         (MockDRTPortTest.make_port):
1162         (MockDRTTest.input_line):
1163         (MockChromiumDRTTest.test_pixeltest__fails):
1164         * Scripts/webkitpy/layout_tests/port/test.py:
1165         * Scripts/webkitpy/layout_tests/port/win.py:
1166         (WinPort.show_results_html_file):
1167         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1168         (MainTest.test_unexpected_failures):
1169         (MainTest.test_results_directory_absolute):
1170         (MainTest.test_results_directory_default):
1171         (MainTest.test_results_directory_relative):
1172
1173 2012-06-05  Jon Lee  <jonlee@apple.com>
1174
1175         Workaround buildbot bug when merging build requests.
1176         https://bugs.webkit.org/show_bug.cgi?id=88158
1177
1178         Reviewed by Mark Rowe.
1179
1180         For expediency, we still want testers to pick the latest build to test, but to ensure
1181         that the builders are reporting the correct revision number, we should let the building bots
1182         run as they normally would. That is, the builder picks the oldest revision, and merges
1183         subsequent requests. Because merged requests get appended to the list of changes for a given
1184         build, the last change in that list is also the latest change. When we used pickLatestBuild
1185         for the builders, this was not the case (it would always report the penultimate change).
1186
1187         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
1188
1189         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
1190         for all Apple builders.
1191         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
1192         the latest build to run.
1193         (loadBuilderConfig):
1194
1195 2012-06-05  Jessie Berlin  <jberlin@apple.com>
1196
1197         [Win] DumpRenderTree should call resetInternalsObject
1198         https://bugs.webkit.org/show_bug.cgi?id=88346
1199
1200         Reviewed by Simon Fraser.
1201
1202         Invoke it on Windows in the same place it is invoked on Mac.
1203
1204         * DumpRenderTree/win/DumpRenderTree.cpp:
1205         (resetWebViewToConsistentStateBeforeTesting):
1206
1207 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1208
1209         [GTK] Fix two more memory leaks in DRT
1210         https://bugs.webkit.org/show_bug.cgi?id=88255
1211
1212         Reviewed by Martin Robinson.
1213
1214         Fixed memory leaks in GTK's DRT code.
1215
1216         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1217         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
1218         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
1219         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1220         (createBitmapContextFromWebView): Free the cairo surface.
1221
1222 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1223
1224         [Qt] Building when a top directory is named Source
1225         https://bugs.webkit.org/show_bug.cgi?id=77727
1226
1227         Reviewed by Tor Arne Vestbø.
1228
1229         Change regex to only replace the last instance of OUT_PWD.
1230
1231         * qmake/mkspecs/features/default_pre.prf:
1232
1233 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
1234
1235         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
1236         https://bugs.webkit.org/show_bug.cgi?id=73176
1237
1238         Reviewed by Adam Barth.
1239
1240         Two more APIs are added in Custom Scheme Handler specification.
1241         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
1242         One is 'isProtocolHandlerRegistered' to query whether the specific URL
1243         is registered or not.
1244         The other is 'unregisterProtocolHandler' to remove the registered URL.
1245
1246         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
1247
1248 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
1249
1250         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
1251         https://bugs.webkit.org/show_bug.cgi?id=83879
1252
1253         Reviewed by Carlos Garcia Campos.
1254
1255         Make minibrowser connect to the new 'permission requests' signal
1256         to allow users handle the Geolocation permission requests.
1257
1258         * MiniBrowser/gtk/BrowserWindow.c:
1259         (geolocationRequestDialogCallback): Callback for the dialog asking
1260         the user for allowing or not geolocation permission requests.
1261         (webViewDecidePermissionRequest): Launch a dialog to ask the user
1262         whether to allow or deny geolocation permission requests.
1263         (browserWindowConstructed): Connect to 'permission-request' signal.
1264
1265 2012-06-04  Chase Phillips  <cmp@google.com>
1266
1267         Make a builder group support+expect multiple loads.
1268         https://bugs.webkit.org/show_bug.cgi?id=88260
1269
1270         Change BuilderGroup to allow expecting multiple
1271         loads.  This allows merging results for a given set
1272         of builders into one group.
1273
1274         Add a test that verifies that the group count
1275         increments correctly based on successful and failed
1276         list loads.
1277
1278         Reviewed by Ojan Vafai.
1279
1280         * TestResultServer/static-dashboards/builders.js:
1281         (BuilderGroup):
1282         (BuilderGroup.prototype.setbuilder):
1283         (BuilderGroup.prototype.append):
1284         (BuilderGroup.prototype.loaded):
1285         (requestBuilderList.xhr.onload):
1286         (requestBuilderList.xhr.onerror):
1287         (onErrorLoadingBuilderList):
1288         (loadBuildersList):
1289         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1290         (test):
1291         * TestResultServer/static-dashboards/run-unittests.html:
1292
1293 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
1294
1295         Python test fix attempt for Chromium Windows.
1296
1297         * Scripts/webkitpy/layout_tests/port/driver.py:
1298         (Driver.uri_to_test):
1299
1300 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
1301
1302         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
1303         https://bugs.webkit.org/show_bug.cgi?id=88243
1304
1305         Reviewed by Adam Barth.
1306
1307         * qmake/mkspecs/features/features.prf:
1308
1309 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1310
1311         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
1312         https://bugs.webkit.org/show_bug.cgi?id=88280
1313
1314         Unreviewed, build fix.
1315
1316         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1317         (TestServerProcess.test_basic):
1318
1319 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1320
1321         test-webkitpy is hanging under cygwin
1322         https://bugs.webkit.org/show_bug.cgi?id=88269
1323
1324         Reviewed by Ryosuke Niwa.
1325
1326         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
1327         so we need to skip any tests that use it.
1328
1329         * Scripts/webkitpy/common/system/executive.py:
1330         (Executive.run_in_parallel):
1331         * Scripts/webkitpy/common/system/executive_unittest.py:
1332         (ExecutiveTest.test_run_in_parallel):
1333
1334 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1335
1336         test-webkitpy is failing on win32 after r115054
1337         https://bugs.webkit.org/show_bug.cgi?id=88264
1338
1339         Reviewed by Ryosuke Niwa.
1340
1341         The failing http_server test was improperly suppressed (the
1342         tuple was missing a comma, and so wasn't a tuple at all, just a
1343         string) and so we were skipping *all* tests on win32. The right
1344         way to skip a single test is to disable it inside the test
1345         itself.
1346
1347         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1348         (TestHttpServer.test_start_cmd):
1349         * Scripts/webkitpy/test/test_finder.py:
1350         (TestFinder._default_names):
1351         * Scripts/webkitpy/test/main.py:
1352         (Tester.run): Add error message if we don't find any tests to run.
1353         * Scripts/webkitpy/test/main_unittest.py:
1354             
1355
1356 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1357
1358         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
1359         https://bugs.webkit.org/show_bug.cgi?id=88215
1360
1361         Reviewed by Martin Robinson.
1362
1363         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
1364         for newly allocated strings.
1365
1366         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1367         (attributeSetToString):
1368         (AccessibilityUIElement::allAttributes):
1369
1370 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1371
1372         [GTK] Memory leaks in DumpRenderTree.cpp
1373         https://bugs.webkit.org/show_bug.cgi?id=88213
1374
1375         Reviewed by Martin Robinson.
1376
1377         Fixed memory leaks in DumpRenderTree.
1378
1379         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1380         (appendString): Accepts const gchar* as the second argument.
1381         (dumpFramesAsText): Free the string returned by g_strdup_printf().
1382         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
1383
1384 2012-06-04  David Dorwin  <ddorwin@chromium.org>
1385
1386         Enable Chromium media player to instantiate a plugin
1387         https://bugs.webkit.org/show_bug.cgi?id=87399
1388
1389         Reviewed by Kent Tamura.
1390
1391         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
1392
1393         * DumpRenderTree/chromium/WebViewHost.cpp:
1394         (WebViewHost::createPopupMenu):
1395
1396 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
1397
1398         [GTK][WK2] Implement geolocation provider for the GTK port
1399         https://bugs.webkit.org/show_bug.cgi?id=83877
1400
1401         Reviewed by Carlos Garcia Campos.
1402
1403         * gtk/generate-gtkdoc:
1404         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
1405
1406 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1407
1408         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
1409         https://bugs.webkit.org/show_bug.cgi?id=87668
1410
1411         Reviewed by Ryosuke Niwa.
1412
1413         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
1414         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
1415         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
1416
1417         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1418         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1419
1420 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
1421
1422         [EFL] Refactor ewk_view_context_paint code.
1423         https://bugs.webkit.org/show_bug.cgi?id=85588
1424
1425         Reviewed by Hajime Morita.
1426
1427         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
1428
1429 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
1430
1431         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
1432         https://bugs.webkit.org/show_bug.cgi?id=87869
1433
1434         Reviewed by Andreas Kling.
1435
1436         Replace %lld by PRId64 macro to print an int64_t value and silent a
1437         compilation warning on 64-Bit.
1438
1439         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1440         (onExceededApplicationCacheQuota):
1441
1442 2012-06-03  Varun Jain  <varunjain@google.com>
1443
1444         [chromium] Add new gesture type (two finger tap) that triggers context menu.
1445         https://bugs.webkit.org/show_bug.cgi?id=88173
1446
1447         Reviewed by Adam Barth.
1448
1449         * DumpRenderTree/chromium/EventSender.cpp:
1450         (EventSender::EventSender):
1451         (EventSender::gestureTwoFingerTap):
1452         (EventSender::gestureEvent):
1453         * DumpRenderTree/chromium/EventSender.h:
1454         (EventSender):
1455
1456 2012-06-02  Zeno Albisser  <zeno@webkit.org>
1457
1458         Fix and enable WebGL for WebKit2 on Qt.
1459         https://bugs.webkit.org/show_bug.cgi?id=86214
1460
1461         Enable WebGL by default for Qt MiniBrowser.
1462
1463         Reviewed by Noam Rosenthal.
1464
1465         * MiniBrowser/qt/qml/BrowserWindow.qml:
1466
1467 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
1468
1469         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
1470         https://bugs.webkit.org/show_bug.cgi?id=88164
1471
1472         Reviewed by Kentaro Hara.
1473
1474         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
1475         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
1476
1477         * Scripts/VCSUtils.pm:
1478         (adjustPathForRecentRenamings):
1479         (fixChangeLogPatch):
1480
1481 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
1482
1483         Rename test_expectations.txt to TestExpectations
1484         https://bugs.webkit.org/show_bug.cgi?id=86690
1485
1486         Reviewed by Dirk Pranke.
1487
1488         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
1489         We can the code to read test_expectations.txt once we've successfully transitioned.
1490
1491         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1492         (TestExpectationParser._check_path_does_not_exist):
1493         (TestExpectationParser._tokenize):
1494         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
1495         * Scripts/webkitpy/layout_tests/port/base.py:
1496         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
1497         test_expectations.txt if one exists and the path to TestExpectations otherwise.
1498         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1499         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
1500         virtual.
1501         * Scripts/webkitpy/layout_tests/port/chromium.py:
1502         (ChromiumPort.path_from_chromium_base):
1503         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1504         (ChromiumAndroidPort.test_expectations):
1505         * Scripts/webkitpy/layout_tests/port/test.py:
1506         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
1507         (TestPort.__init__):
1508         * Scripts/webkitpy/layout_tests/port/webkit.py:
1509         (WebKitPort.baseline_search_path):
1510         (WebKitPort.test_expectations):
1511         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
1512         tests to base as a follow up.
1513         (WebKitPortTest.test_path_to_test_expectations_file):
1514         (test_test_expectations):
1515         (test_legacy_test_expectations):
1516         * Scripts/webkitpy/style/checker.py:
1517         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
1518         with one for TestExpectations.
1519         * Scripts/webkitpy/style/checkers/test_expectations.py:
1520         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
1521         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1522         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
1523         test_expectations.txt.
1524         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1525         (TestExpectationsTestCase.assert_lines_lint):
1526         * Scripts/webkitpy/tool/commands/queries.py:
1527         (PrintExpectations.__init__):
1528         * Scripts/webkitpy/tool/commands/rebaseline.py:
1529         (RebaselineExpectations):
1530         * Scripts/webkitpy/tool/steps/commit.py:
1531         (Commit._check_test_expectations):
1532         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1533         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
1534         (CommitTest.test_check_test_expectations): For TestExpectations.
1535         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
1536         * TestResultServer/static-dashboards/dashboard_base.js:
1537         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
1538         Error only when neither exists.
1539         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1540         (processMissingAndExtraExpectations):
1541         (htmlForTestsWithExpectationsButNoFailures):
1542         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1543
1544 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
1545
1546         Remove dependency from ImageDiff to WTF
1547         https://bugs.webkit.org/show_bug.cgi?id=88147
1548
1549         Reviewed by Adam Barth.
1550
1551         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1552
1553 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
1554
1555         NRWT seems to leak (more?) temp dirs
1556         https://bugs.webkit.org/show_bug.cgi?id=88126
1557
1558         Re-land r119297 with chromium fix (weren't calling the
1559         super() method if not in --test-shell mode in start().
1560         Add unit tests to chromium_unittest as well to check.
1561
1562         * Scripts/webkitpy/layout_tests/port/chromium.py:
1563         (ChromiumDriver.start):
1564         * Scripts/webkitpy/layout_tests/port/webkit.py:
1565         (WebKitDriver.__del__):
1566         (WebKitDriver._start):
1567         (WebKitDriver.run_test):
1568         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1569         (WebKitDriverTest.test_check_for_driver_crash):
1570         (WebKitDriverTest.test_stop_cleans_up_properly):
1571         (WebKitDriverTest):
1572         (WebKitDriverTest.test_two_starts_cleans_up_properly):
1573         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1574         (ChromiumDriverTest.test_stop_cleans_up_properly):
1575         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
1576
1577 2012-06-01  Tim Horton  <timothy_horton@apple.com>
1578
1579         Lots of "failed download-built-product" on Apple bots
1580         https://bugs.webkit.org/show_bug.cgi?id=88158
1581
1582         Reviewed by Jessie Berlin.
1583         
1584         Disable mergeRequests on all Apple builders. This is a speculative fix.
1585
1586         * BuildSlaveSupport/build.webkit.org-config/config.json:
1587
1588 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1589
1590         Unreviewed, rolling out r119297.
1591         http://trac.webkit.org/changeset/119297
1592         https://bugs.webkit.org/show_bug.cgi?id=88156
1593
1594         May have broken Chromium bots (Requested by rniwa on #webkit).
1595
1596         * Scripts/webkitpy/layout_tests/port/webkit.py:
1597         (WebKitDriver.__del__):
1598         (WebKitDriver.run_test):
1599         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1600         (WebKitDriverTest.test_check_for_driver_crash):
1601         (WebKitDriverTest.test_stop_cleans_up_properly):
1602
1603 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
1604
1605         nrwt seems to leak tmpdirs
1606         https://bugs.webkit.org/show_bug.cgi?id=88126
1607
1608         Reviewed by Ojan Vafai.
1609
1610         Fix leak possibly introduced in r118979 - we now will
1611         make sure we clean up any stale temp directories during the
1612         start routine and attempt to clean up again in __del__. It
1613         turns out that asserting in __del__ logs a message but is
1614         caught by the runtime, so it's mostly useless.
1615
1616         * Scripts/webkitpy/layout_tests/port/webkit.py:
1617         (WebKitDriver.__del__):
1618         (WebKitDriver._start):
1619         (WebKitDriver.run_test):
1620         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1621         (WebKitDriverTest.test_check_for_driver_crash):
1622         (WebKitDriverTest.test_stop_cleans_up_properly):
1623         (WebKitDriverTest):
1624         (WebKitDriverTest.test_two_starts_cleans_up_properly):
1625
1626 2012-06-01  Michael Saboff  <msaboff@apple.com>
1627
1628         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
1629         https://bugs.webkit.org/show_bug.cgi?id=88109
1630
1631         Reviewed by Geoffrey Garen.
1632
1633         Additional test case.
1634
1635         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
1636         (TestWebKitAPI::TEST):
1637
1638 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
1639
1640         [Qt] Use -Werror only in developer builds
1641
1642         Rubber-stamped by Tor Arne Vestbø.
1643
1644         In production builds -Werror with custom toolchains and wierd system
1645         headers, -Werror is of no use and just creates confusion. So use it
1646         only if Qt is configured with -developer-build.
1647
1648         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
1649         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
1650         only if qt_developer_build is set.
1651
1652 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
1653
1654         [watchlist] Add myself to loader and v8 bindings changes
1655         https://bugs.webkit.org/show_bug.cgi?id=88112
1656
1657         Reviewed by Adam Barth.
1658
1659         * Scripts/webkitpy/common/config/watchlist:
1660
1661 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
1662
1663         Adding Jacky Jiang to committers.py
1664         https://bugs.webkit.org/show_bug.cgi?id=88122
1665
1666         Reviewed by Rob Buis.
1667
1668         Adding myself to committers.py as a Committer.
1669
1670         * Scripts/webkitpy/common/config/committers.py:
1671
1672 2012-06-01  Jessie Berlin  <jberlin@apple.com>
1673
1674         Fix Windows build.
1675
1676         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1677
1678 2012-06-01  Jessie Berlin  <jberlin@apple.com>
1679
1680         Windows WK2 MouseMoveAfterCrash API test failing
1681         https://bugs.webkit.org/show_bug.cgi?id=69982
1682
1683         Disable the test on Windows to get the bots greener.
1684
1685         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1686         (TestWebKitAPI::TEST):
1687
1688 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
1689
1690         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
1691         https://bugs.webkit.org/show_bug.cgi?id=86866
1692
1693         Reviewed by Adam Barth.
1694
1695         Catch new "intent,service,register" signal on the frame and print out
1696         information about the Web Intent service in EFL's DumpRenderTree.
1697
1698         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1699         (DumpRenderTreeChrome::createView):
1700         (DumpRenderTreeChrome::onFrameCreated):
1701         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
1702         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1703         (DumpRenderTreeChrome):
1704
1705 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
1706
1707         The ChangeLog parser cannot handle reviewers with initials in their name
1708         https://bugs.webkit.org/show_bug.cgi?id=87864
1709
1710         Reviewed by Ryosuke Niwa.
1711
1712         Add support in the ChangeLog parser for reviewer names that have
1713         initials in them.
1714
1715         * Scripts/webkitpy/common/checkout/changelog.py:
1716         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
1717         in the replacement string. This allows for matching the word characters before a
1718         period, without totally throwing them away.
1719         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
1720         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1721         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
1722
1723 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
1724
1725         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
1726         https://bugs.webkit.org/show_bug.cgi?id=86865
1727
1728         Reviewed by Adam Barth.
1729
1730         Add deliverWebIntent method to LayoutTestController and provide
1731         implementation for EFL port.
1732
1733         * DumpRenderTree/LayoutTestController.cpp:
1734         (deliverWebIntentCallback):
1735         (LayoutTestController::staticFunctions):
1736         * DumpRenderTree/LayoutTestController.h:
1737         (LayoutTestController):
1738         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1739         (LayoutTestController::deliverWebIntent):
1740         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1741         (LayoutTestController::deliverWebIntent):
1742         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1743         (LayoutTestController::deliverWebIntent):
1744         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1745         (LayoutTestController::deliverWebIntent):
1746         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1747         (LayoutTestController::deliverWebIntent):
1748         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1749         (LayoutTestController::deliverWebIntent):
1750
1751 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1752
1753         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
1754
1755         Reviewed by Simon Hausmann.
1756
1757         * Tools.pro:
1758
1759 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
1760
1761         Add public page loading performance tests using web-page-replay
1762         https://bugs.webkit.org/show_bug.cgi?id=84008
1763
1764         Reviewed by Dirk Pranke.
1765
1766         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
1767         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
1768         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
1769
1770         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
1771         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
1772         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
1773         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
1774
1775         * Scripts/webkitpy/layout_tests/port/driver.py:
1776         (Driver.is_external_http_test): Added.
1777         * Scripts/webkitpy/layout_tests/port/webkit.py:
1778         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
1779         * Scripts/webkitpy/performance_tests/perftest.py:
1780         (PerfTest.__init__): Takes port.
1781         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
1782         (PerfTest):
1783         (PerfTest.run): Calls run_single.
1784         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
1785         (ChromiumStylePerfTest.__init__):
1786         (PageLoadingPerfTest.__init__):
1787         (PageLoadingPerfTest.run):
1788         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
1789         (ReplayServer.__init__):
1790         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
1791         but it caused a dead lock on some web pages.
1792         (ReplayServer.stop):
1793         (ReplayServer.__del__):
1794         (ReplayPerfTest):
1795         (ReplayPerfTest.__init__):
1796         (ReplayPerfTest._start_replay_server):
1797         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
1798         The subsequent runs of the same test will just use test.wpr.
1799         (ReplayPerfTest.run_single):
1800         (PerfTestFactory):
1801         (PerfTestFactory.create_perf_test):
1802         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1803         (MainTest.test_parse_output):
1804         (MainTest.test_parse_output_with_failing_line):
1805         (TestPageLoadingPerfTest.test_run):
1806         (TestPageLoadingPerfTest.test_run_with_bad_output):
1807         (TestReplayPerfTest):
1808         (TestReplayPerfTest.ReplayTestPort):
1809         (TestReplayPerfTest.ReplayTestPort.__init__):
1810         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
1811         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
1812         (TestReplayPerfTest.ReplayTestPort._driver_class):
1813         (TestReplayPerfTest.MockReplayServer):
1814         (TestReplayPerfTest.MockReplayServer.__init__):
1815         (TestReplayPerfTest.MockReplayServer.stop):
1816         (TestReplayPerfTest._add_file):
1817         (TestReplayPerfTest._setup_test):
1818         (TestReplayPerfTest.test_run_single):
1819         (TestReplayPerfTest.test_run_single.run_test):
1820         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
1821         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
1822         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
1823         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
1824         (TestReplayPerfTest.test_prepare):
1825         (TestReplayPerfTest.test_prepare.run_test):
1826         (TestReplayPerfTest.test_prepare_calls_run_single):
1827         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
1828         (TestPerfTestFactory.test_regular_test):
1829         (TestPerfTestFactory.test_inspector_test):
1830         (TestPerfTestFactory.test_page_loading_test):
1831         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1832         (PerfTestsRunner):
1833         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
1834         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
1835         (PerfTestsRunner._collect_tests._is_test_file):
1836         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
1837         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1838         (create_runner):
1839         (run_test):
1840         (_tests_for_runner):
1841         (test_run_test_set):
1842         (test_run_test_set_kills_drt_per_run):
1843         (test_run_test_pause_before_testing):
1844         (test_run_test_set_for_parser_tests):
1845         (test_run_test_set_with_json_output):
1846         (test_run_test_set_with_json_source):
1847         (test_run_test_set_with_multiple_repositories):
1848         (test_run_with_upload_json):
1849         (test_upload_json):
1850         (test_upload_json.MockFileUploader.upload_single_text_file):
1851         (_add_file):
1852         (test_collect_tests):
1853         (test_collect_tests_with_multile_files):
1854         (test_collect_tests_with_multile_files.add_file):
1855         (test_collect_tests_with_skipped_list):
1856         (test_collect_tests_with_page_load_svg):
1857         (test_collect_tests_should_ignore_replay_tests_by_default):
1858         (test_collect_tests_with_replay_tests):
1859         (test_parse_args):
1860         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
1861         (AutoinstallImportHook.find_module):
1862         (AutoinstallImportHook._install_webpagereplay):
1863
1864 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
1865
1866         Support building the Android port of chromium with Ninja
1867         https://bugs.webkit.org/show_bug.cgi?id=87545
1868
1869         Reviewed by Adam Barth.
1870
1871         Ensures that shared libraries are looked up in a generator-agnostic
1872         way and that output is placed in the correct directory.
1873
1874         Depends on http://codereview.chromium.org/10386188/
1875
1876         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1877
1878 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
1879
1880         [Chromium] Chromium DRT should be able to load external resources
1881         https://bugs.webkit.org/show_bug.cgi?id=87893
1882
1883         Reviewed by Dirk Pranke.
1884
1885         Allow external resources to be loaded when the main frame's URL is also an external resource.
1886         This change is analogous to r118231 for Mac port.
1887
1888         * DumpRenderTree/chromium/WebViewHost.cpp:
1889         (blockRequest):
1890         (isLocalhost):
1891         (hostIsUsedBySomeTestsToGenerateError):
1892         (WebViewHost::willSendRequest):
1893
1894 2012-05-31  Anders Carlsson  <andersca@apple.com>
1895
1896         Build fixes.
1897
1898         Disable the C++11 extensions warning.
1899
1900         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1901         * TestWebKitAPI/Configurations/Base.xcconfig:
1902         * WebKitTestRunner/Configurations/Base.xcconfig:
1903
1904 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
1905
1906         [WK2] window.internals settings are not reset between tests
1907         https://bugs.webkit.org/show_bug.cgi?id=87783
1908
1909         Reviewed by Mihai Parparita.
1910
1911         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1912         (WTR::InjectedBundle::done): Call resetAfterTest().
1913
1914         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1915         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
1916         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
1917         This needs to be done after a tets, because the code assumes that there is an object
1918         with this name in global scope.
1919
1920         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1921
1922 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1923
1924         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
1925         https://bugs.webkit.org/show_bug.cgi?id=85006
1926
1927         Reviewed by Tor Arne Vestbø.
1928
1929         Added navigation_policy_decision implementation for DumpRenderTreeView.
1930         Added LayoutTestController::setCustomPolicyDelegate implementation.
1931         Modified LayoutTestController::waitForPolicyDelegate.
1932
1933         * DumpRenderTree/efl/DumpRenderTree.cpp:
1934         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1935         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1936         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
1937         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1938         (navigationTypeToString): aux function
1939         (onNavigationPolicyDecision): navigation_policy_decision implementation
1940         (drtViewAdd):
1941         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1942         (LayoutTestController::setCustomPolicyDelegate):
1943         (LayoutTestController::waitForPolicyDelegate):
1944
1945 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1946
1947         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
1948         https://bugs.webkit.org/show_bug.cgi?id=86195
1949
1950         Reviewed by Gustavo Noronha Silva.
1951
1952         Implement clearApplicationCacheForOrigin in EFL
1953         LayoutTestController.
1954
1955         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1956         (LayoutTestController::clearApplicationCacheForOrigin):
1957
1958 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1959
1960         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
1961         https://bugs.webkit.org/show_bug.cgi?id=87955
1962
1963         Reviewed by Simon Hausmann.
1964
1965         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1966         * DumpRenderTree/qt/EventSenderQt.cpp:
1967         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1968         * DumpRenderTree/qt/main.cpp:
1969         * QtTestBrowser/cookiejar.cpp:
1970         * QtTestBrowser/launcherwindow.cpp:
1971         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1972         * qmake/mkspecs/features/default_post.prf:
1973
1974 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
1975
1976         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
1977
1978         Rubber-stamped by Kenneth Rohde Christiansen.
1979
1980         * qmake/config.tests/libpng/libpng.pro:
1981
1982 2012-05-30  Peter Beverloo  <peter@chromium.org>
1983
1984         [Chromium] Automatically install 64-bit linker for Android
1985         https://bugs.webkit.org/show_bug.cgi?id=79780
1986
1987         Reviewed by Adam Barth.
1988
1989         Change the update-webkit-chromium script to check whether the 64-bit
1990         linker needs to be installed as part of the update process. The actual
1991         code for doing these checks and "installing" it has been added to the
1992         webkitdirs.pm script.
1993
1994         The linker itself is part of the third_party/aosp repository, which
1995         will be pulled in through the DEPS change.
1996
1997         * Scripts/update-webkit-chromium:
1998         * Scripts/webkitdirs.pm:
1999         (chromiumInstall64BitAndroidLinkerIfNeeded):
2000         (chromiumReplaceAndroidLinkerIfNeeded):
2001
2002 2012-05-30  Stephanie Lewis  <slewis@apple.com>
2003
2004         https://bugs.webkit.org/show_bug.cgi?id=87803
2005         Layout tests often fail trying to stat nonexistent logs 
2006
2007         Reviewed by Dirk Pranke.
2008
2009         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
2010         try/catch block around accessing the logs as a precaution.
2011
2012         * Scripts/webkitpy/common/system/crashlogs.py:
2013         (CrashLogs._find_newest_log_darwin):
2014
2015 2012-05-30  Gavin Peters  <gavinp@chromium.org>
2016
2017         Add a LayoutTest for prerender remove after stop.
2018         https://bugs.webkit.org/show_bug.cgi?id=87860
2019
2020         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
2021         can be tested by LayoutTests now.
2022
2023         Reviewed by Adam Barth.
2024
2025         * DumpRenderTree/DumpRenderTree.gypi:
2026         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
2027         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
2028         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
2029         (MockWebPrerenderingSupport::add):
2030         (MockWebPrerenderingSupport::cancel):
2031         (MockWebPrerenderingSupport::abandon):
2032         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
2033         (MockWebPrerenderingSupport):
2034         * DumpRenderTree/chromium/TestShell.cpp:
2035         (TestShell::initialize):
2036         * DumpRenderTree/chromium/TestShell.h:
2037         (TestShell):
2038         * DumpRenderTree/chromium/WebViewHost.cpp:
2039         (WebViewHost::willAddPrerender):
2040         (WebViewHost::setWebWidget):
2041         * DumpRenderTree/chromium/WebViewHost.h:
2042         (WebViewHost):
2043
2044 2012-05-30  Stephanie Lewis  <slewis@apple.com>
2045
2046         https://bugs.webkit.org/show_bug.cgi?id=87717
2047         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
2048
2049         Reviewed by Dirk Pranke.
2050
2051         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
2052         If there isn't a crash log found for the process add a message saying
2053         the process was unresponsive.
2054
2055         * Scripts/webkitpy/layout_tests/port/webkit.py:
2056         (WebKitDriver.__init__):
2057         (WebKitDriver._check_for_driver_crash):
2058         (WebKitDriver.run_test):
2059         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2060         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
2061         (WebKitDriverTest):
2062         (WebKitDriverTest.test_check_for_driver_crash):
2063         * WebKitTestRunner/TestController.cpp:
2064         (WTR):
2065         (WTR::TestController::runTest):
2066
2067 2012-05-30  Stephanie Lewis  <slewis@apple.com>
2068
2069         https://bugs.webkit.org/show_bug.cgi?id=87714
2070         Mac crash logs can take a really long time to be written out.
2071
2072         Reviewed by Dirk Pranke.
2073
2074         Make a second pass looking for crash logs after the tests have completed running.
2075
2076         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2077         (use_trac_links_in_results_html):
2078         (Manager.run):
2079         * Scripts/webkitpy/layout_tests/port/base.py:
2080         (Port.repository_paths):
2081         (Port.look_for_new_crash_logs):
2082         * Scripts/webkitpy/layout_tests/port/mac.py:
2083         (MacPort.look_for_new_crash_logs):
2084         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2085         (test_get_crash_log):
2086         (test_look_for_new_crash_logs):
2087         (test_look_for_new_crash_logs.fake_time_cb):
2088
2089 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
2090
2091         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
2092
2093         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2094         (LayoutWebViewEventHandler::OnAlertEvent):
2095         (LayoutWebViewEventHandler::OnConfirmEvent):
2096         (LayoutWebViewEventHandler):
2097         (LayoutWebViewEventHandler::OnPromptEvent):
2098         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
2099         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
2100
2101 2012-05-30  Ojan Vafai  <ojan@chromium.org>
2102
2103         Only give lint errors for -expected.png png files that lack a checksum
2104         https://bugs.webkit.org/show_bug.cgi?id=87875
2105
2106         Reviewed by Tony Chang.
2107
2108         We have other pngs in the tree, e.g. for the inspector, that legitimately
2109         lack a checksum.
2110
2111         * Scripts/webkitpy/style/checkers/png.py:
2112         (PNGChecker.check):
2113         * Scripts/webkitpy/style/checkers/png_unittest.py:
2114         (PNGCheckerTest.test_check):
2115
2116 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
2117
2118         nrwt: seems to leak temp dirs
2119         https://bugs.webkit.org/show_bug.cgi?id=87795
2120
2121         Reviewed by Ojan Vafai.
2122
2123         There appears to be a bug where the chromium bots are creating
2124         temporary directories and not cleaning them up that started
2125         after the switch to WebKitDriver. It's possible that __del__
2126         wasn't getting called in a timely manner (or at all), and it's
2127         generally bad style to rely on __del__ being called, so this
2128         code changes things so that we create a temp dir in
2129         driver.start() and remove it in driver.stop(). We could be
2130         paranoid and leave the __del__ code in, but there doesn't seem
2131         to be much advantage to it. If there are bugs that result in
2132         drivers being started but not stopped, we have other problems.
2133
2134         * Scripts/webkitpy/common/system/filesystem_mock.py:
2135         (MockFileSystem.__init__):
2136         (MockFileSystem._mktemp):
2137         (MockFileSystem.mkdtemp):
2138         * Scripts/webkitpy/layout_tests/port/webkit.py:
2139         (WebKitDriver.__init__):
2140         (WebKitDriver._start):
2141         (WebKitDriver.stop):
2142         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2143         (WebKitDriverTest.test_check_for_driver_crash):
2144         (WebKitDriverTest):
2145         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
2146         (WebKitDriverTest.test_stop_cleans_up_properly):
2147
2148 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
2149
2150         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
2151         https://bugs.webkit.org/show_bug.cgi?id=86841
2152
2153         Reviewed by Adam Barth.
2154
2155         Print the number of MessagePorts for each new intent in EFL's DRT.
2156         This output is expected by several Web Intents test cases.
2157
2158         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2159         (DumpRenderTreeChrome::onFrameIntentNew):
2160
2161 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
2162
2163         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
2164
2165         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2166
2167 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
2168
2169         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
2170         https://bugs.webkit.org/show_bug.cgi?id=87829
2171
2172         Reviewed by Adam Barth.
2173
2174         EFL's LayoutTestController now makes uses of the new helper method in
2175         DumpRenderTreeSupportEfl in order to send the intent response. This is
2176         now needed because the Ewk_Intent_Request postResult / postFailure
2177         methods were made private.
2178
2179         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2180         (LayoutTestController::sendWebIntentResponse):
2181
2182 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
2183
2184         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
2185         https://bugs.webkit.org/show_bug.cgi?id=86296
2186
2187         Reviewed by Tony Chang.
2188
2189         * DumpRenderTree/win/DRTDataObject.cpp: Added.
2190         (cfHDropFormat):
2191         (cfFileNameWFormat):
2192         (cfUrlWFormat):
2193         (WCEnumFormatEtc):
2194         (WCEnumFormatEtc::WCEnumFormatEtc):
2195         (WCEnumFormatEtc::QueryInterface):
2196         (WCEnumFormatEtc::AddRef):
2197         (WCEnumFormatEtc::Release):
2198         (WCEnumFormatEtc::Next):
2199         (WCEnumFormatEtc::Skip):
2200         (WCEnumFormatEtc::Reset):
2201         (WCEnumFormatEtc::Clone):
2202         (DRTDataObject::createInstance):
2203         (DRTDataObject::DRTDataObject):
2204         (DRTDataObject::~DRTDataObject):
2205         (DRTDataObject::QueryInterface):
2206         (DRTDataObject::AddRef):
2207         (DRTDataObject::Release):
2208         (DRTDataObject::GetData):
2209         (DRTDataObject::GetDataHere):
2210         (DRTDataObject::QueryGetData):
2211         (DRTDataObject::GetCanonicalFormatEtc):
2212         (DRTDataObject::SetData):
2213         (DRTDataObject::CopyMedium):
2214         (DRTDataObject::EnumFormatEtc):
2215         (DRTDataObject::DAdvise):
2216         (DRTDataObject::DUnadvise):
2217         (DRTDataObject::EnumDAdvise):
2218         (DRTDataObject::clearData):
2219         * DumpRenderTree/win/DRTDataObject.h: Added.
2220         (DRTDataObject):
2221         * DumpRenderTree/win/DRTDropSource.cpp: Added.
2222         (DRTDropSource::DRTDropSource):
2223         (DRTDropSource::~DRTDropSource):
2224         (DRTDropSource::QueryInterface):
2225         (DRTDropSource::AddRef):
2226         (DRTDropSource::Release):
2227         (DRTDropSource::createInstance):
2228         (DRTDropSource::QueryContinueDrag):
2229         (DRTDropSource::GiveFeedback):
2230         * DumpRenderTree/win/DRTDropSource.h: Added.
2231         (DRTDropSource):
2232         * DumpRenderTree/win/DumpRenderTree.vcproj:
2233         * DumpRenderTree/win/EventSender.cpp:
2234         (beginDragWithFilesCallback):
2235
2236 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
2237
2238         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
2239         https://bugs.webkit.org/show_bug.cgi?id=58593
2240
2241         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
2242         to WebKitTestRunner's LayoutTestController. The flag is modified via the
2243         public C API of the WebProcess.
2244
2245         Reviewed by Darin Adler.
2246
2247         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2248         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2249         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
2250         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
2251         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2252
2253 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2254
2255         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
2256         https://bugs.webkit.org/show_bug.cgi?id=87848
2257
2258         Reviewed by Csaba Osztrogonác.
2259
2260         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
2261         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
2262         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
2263
2264         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2265         (DumpRenderTreeChrome::extraViews):
2266         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2267         (DumpRenderTreeChrome):
2268
2269 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2270
2271         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
2272         https://bugs.webkit.org/show_bug.cgi?id=87833
2273
2274         Reviewed by Tor Arne Vestbø.
2275
2276         Print "postProgressFinishedNotification" message if frame load finished 
2277         to unskip http/tests/loading/progress-finished-callback.html.
2278
2279         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2280         (DumpRenderTreeChrome::onFrameLoadFinished):
2281
2282 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
2283
2284         [EFL][WK2] Fix WebKit2-EFL build
2285         https://bugs.webkit.org/show_bug.cgi?id=83693
2286
2287         Reviewed by Carlos Garcia Campos.
2288
2289         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
2290
2291 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
2292
2293         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
2294         (They only used to check for Skipped in platform/qt-5.0-wk1)
2295         https://bugs.webkit.org/show_bug.cgi?id=87376
2296
2297         Reviewed by Csaba Osztrogonác.
2298
2299         * Scripts/old-run-webkit-tests:
2300         (buildPlatformResultHierarchy):
2301         * Scripts/webkitpy/layout_tests/port/qt.py:
2302         (QtPort.baseline_search_path):
2303
2304 2012-05-29  Ojan Vafai  <ojan@chromium.org>
2305
2306         Add a linter error for pngs that lack an embedded checksum
2307         https://bugs.webkit.org/show_bug.cgi?id=87793
2308
2309         Reviewed by Dirk Pranke.
2310
2311         * Scripts/read-checksum-from-png:
2312         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
2313         (read_checksum):
2314         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
2315         (ReadChecksumFromPngTest):
2316         (ReadChecksumFromPngTest.test_read_checksum):
2317         * Scripts/webkitpy/layout_tests/port/base.py:
2318         * Scripts/webkitpy/style/checkers/png.py:
2319         (PNGChecker.check):
2320         * Scripts/webkitpy/style/checkers/png_unittest.py:
2321         (PNGCheckerTest.test_check):
2322
2323 2012-05-29  Stephanie Lewis  <slewis@apple.com>
2324
2325         https://bugs.webkit.org/show_bug.cgi?id=87720
2326         WebProcess is often killed due to being unresponsive on the bots
2327
2328         Reviewed by Alexey Proskuryakov.
2329
2330         Blind attempt to improve flakiness on the bots by reducing the number
2331         of crashes due to an unresponsive process.  This helped on my personal machine
2332         under stress conditions.  I don't have enough cores to hit the problem
2333         under normal conditions.
2334
2335         * WebKitTestRunner/TestController.cpp:
2336         (WTR):
2337
2338 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
2339
2340         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
2341         https://bugs.webkit.org/show_bug.cgi?id=87779
2342
2343         Reviewed by Eric Seidel.
2344
2345         Update output to match the names in scm.py as per
2346         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
2347
2348         * Scripts/webkitpy/tool/commands/rebaseline.py:
2349         (RebaselineTest.execute):
2350         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2351         (test_rebaseline_test_and_print_scm_changes):
2352         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2353         (GardeningServerTest.test_rebaselineall):
2354
2355 2012-05-29  Stephanie Lewis  <slewis@apple.com>
2356
2357         https://bugs.webkit.org/show_bug.cgi?id=87711
2358
2359         Reviewed by Jessie Berlin.
2360
2361         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
2362         are better maintained.
2363
2364         * BuildSlaveSupport/build.webkit.org-config/config.json:
2365
2366 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
2367
2368         webkit-patch optimize-baselines should add/delete files in batches from the vcs
2369         https://bugs.webkit.org/show_bug.cgi?id=87538
2370
2371         Reviewed by Ojan Vafai.
2372
2373         Invoking git and svn on one file at a time is kinda slow. We
2374         should batch the add and rm operations together.
2375
2376         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2377         (BaselineOptimizer._move_baselines):
2378
2379 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
2380
2381         garden-o-matic should rebaseline baselines in parallel
2382         https://bugs.webkit.org/show_bug.cgi?id=87451
2383
2384         Reviewed by Ojan Vafai.
2385                                                                                
2386         This modifies garden-o-matic so that we will fetch all                  
2387         of the baselines in parallel from the bots, and then                    
2388         optimize the baselines serially (since that should be fairly            
2389         quick and we get into trouble if we optimize in parallel due            
2390         to concurrent access to the source control system).                     
2391
2392         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
2393         so that the files that need to be modified in the SCM are returned to 
2394         garden-o-matic rather than actually added or removed. This is done so that
2395         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
2396         concurrently). In order to safely return the files (as a JSON dict) I
2397         needed to shift all of the logging in rebaseline-test to use the logging
2398         module (and hence log to stderr).
2399
2400         I also had to stub out a line in chromium.py that would get confused if
2401         the skia overrides file didn't exist in a mock checkout.
2402
2403         * Scripts/webkitpy/common/system/executive.py:
2404         (Executive.popen):
2405         (Executive):
2406         (Executive.run_in_parallel):
2407         (_run_command_thunk):
2408         * Scripts/webkitpy/common/system/executive_mock.py:
2409         (MockExecutive.run_in_parallel):
2410         * Scripts/webkitpy/common/system/executive_unittest.py:
2411         (ExecutiveTest.test_run_in_parallel):
2412         * Scripts/webkitpy/layout_tests/port/chromium.py:
2413         (ChromiumPort._expectations_file_contents):
2414         * Scripts/webkitpy/tool/commands/rebaseline.py:
2415         (AbstractRebaseliningCommand.__init__):
2416         (RebaselineTest.__init__):
2417         (RebaselineTest._copy_existing_baseline):
2418         (RebaselineTest._save_baseline):
2419         (RebaselineTest):
2420         (RebaselineTest._add_to_scm):
2421         (RebaselineTest._rebaseline_test):
2422         (RebaselineTest.execute):
2423         (RebaselineExpectations._rebaseline_port):
2424         (RebaselineExpectations.execute):
2425         (Rebaseline._builder_to_pull_from):
2426         (Rebaseline.execute):
2427         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2428         (test_rebaseline_updates_expectations_file):
2429         (test_rebaseline_test):
2430         (test_rebaseline_test_and_print_scm_changes):
2431         (test_rebaseline_and_copy_test):
2432         (test_rebaseline_and_copy_test_no_existing_result):
2433         (test_rebaseline_and_copy_test_with_lion_result):
2434         (test_rebaseline_and_copy_no_overwrite_test):
2435         (test_rebaseline_expectations):
2436         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2437         (GardeningHTTPRequestHandler._rebaseline_commands):
2438         (GardeningHTTPRequestHandler):
2439         (GardeningHTTPRequestHandler._files_to_add):
2440         (GardeningHTTPRequestHandler._optimize_baselines):
2441         (GardeningHTTPRequestHandler.rebaselineall):
2442         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2443         (GardeningServerTest._post_to_path):
2444         (GardeningServerTest.test_rebaselineall):
2445         (GardeningServerTest.test_rebaselineall.run_command):
2446
2447 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
2448
2449         Fix the type of dispatch_time() offset
2450
2451         Rubber-stamped by Joseph Pecoraro.
2452
2453         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
2454
2455         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2456         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2457
2458 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
2459
2460         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
2461
2462         [BlackBerry] OpenGL content is not rendered on simulator
2463         https://bugs.webkit.org/show_bug.cgi?id=87721
2464
2465         Reviewed by George Staikos.
2466
2467         Fixed by enabling GLES2 support in simulator builds.
2468
2469         To experiment with building without OpenGL support, you can set the
2470         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
2471
2472         PR #150695
2473
2474         * Scripts/webkitdirs.pm:
2475         (blackberryCMakeArguments):
2476
2477 2012-05-29  David Barr  <davidbarr@chromium.org>
2478
2479         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
2480         https://bugs.webkit.org/show_bug.cgi?id=87685
2481
2482         Reviewed by Eric Seidel.
2483
2484         Add a configuration option for CSS image-resolution support, disabling it by default.
2485
2486         * Scripts/webkitperl/FeatureList.pm:
2487         * qmake/mkspecs/features/features.pri:
2488
2489 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2490
2491         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
2492
2493         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
2494             valid for C++/ObjC++ but not for C [enabled by default]"
2495
2496         Reviewed by Simon Hausmann.
2497
2498         * qmake/mkspecs/features/unix/default_post.prf:
2499
2500 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2501
2502         [Qt] Sync up favicon-implementation with WebView url changes in r118158
2503
2504         https://bugs.webkit.org/show_bug.cgi?id=87133
2505
2506         We now base64-encode the page url in the image-provider url, so that any
2507         normalization done by QUrl will not mess up the page-url. The logic of
2508         creating and parsing the provider-url has been moved into the image
2509         provider, to keep it in one place.
2510
2511         We were also releasing icons (even ones we hadn't retained), which we can't
2512         do since we don't know when the icon url is no longer in use.
2513
2514         Reviewed-by Simon Hausmann.
2515
2516         * MiniBrowser/qt/icons/favicon.png:
2517         * MiniBrowser/qt/qml/BrowserWindow.qml:
2518
2519 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2520
2521         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
2522         https://bugs.webkit.org/show_bug.cgi?id=87654
2523
2524         Reviewed by Csaba Osztrogonác.
2525
2526         Event sender provides strings for all the key events.
2527         Also KeyEventInfo constructor parameters order was changed to simplify the case when
2528         a key event has empty string.
2529
2530         * DumpRenderTree/efl/EventSender.cpp:
2531         (KeyEventInfo::KeyEventInfo):
2532         (keyPadNameFromJSValue):
2533         (keyNameFromJSValue):
2534
2535 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2536
2537         [Qt] Cancel potential url-edit when going back/forward
2538
2539         Reviewed by Kenneth Rohde Christiansen.
2540
2541         * MiniBrowser/qt/qml/BrowserWindow.qml:
2542
2543 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
2544
2545         [EFL] Compilation warning in DumpRenderTreeView.cpp
2546         https://bugs.webkit.org/show_bug.cgi?id=87636
2547
2548         Reviewed by Filip Pizlo.
2549
2550         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
2551         specifier in printf. Also fix the return type for
2552         onExceededApplicationCacheQuota callback.
2553
2554         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2555         (onExceededApplicationCacheQuota):
2556
2557 2012-05-29  Hironori Bono  <hbono@chromium.org>
2558
2559         Adding Hironori Bono to committers.py.
2560         https://bugs.webkit.org/show_bug.cgi?id=87697
2561
2562         * Scripts/webkitpy/common/config/committers.py:
2563
2564 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
2565
2566         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
2567         https://bugs.webkit.org/show_bug.cgi?id=80135
2568
2569         Reviewed by Rob Buis.
2570
2571         Implemented interface function didReceiveAuthenticationChallenge in class
2572         DumpRenderTree.
2573
2574         Resubmit the patch reverted by r115104 after the digest infinite loop
2575         issue for BlackBerry porting get identified and fixed.
2576
2577         Internally reviewed by Joe Mason <jmason@rim.com>
2578
2579         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2580         (drtCredentialDescription):
2581         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
2582         (WebKit):
2583         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2584         (WebCore):
2585         (DumpRenderTree):
2586
2587 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2588
2589         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
2590         https://bugs.webkit.org/show_bug.cgi?id=42328
2591
2592         Reviewed by Eric Seidel.
2593
2594         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
2595         move to windows.internals.settings.
2596
2597         * DumpRenderTree/LayoutTestController.cpp:
2598         (LayoutTestController::staticFunctions):
2599         * DumpRenderTree/LayoutTestController.h:
2600         (LayoutTestController):
2601         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2602         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2603         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2604         (DRTDevToolsAgent):
2605         * DumpRenderTree/chromium/LayoutTestController.cpp:
2606         (LayoutTestController::LayoutTestController):
2607         * DumpRenderTree/chromium/LayoutTestController.h:
2608         (LayoutTestController):
2609         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2610         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2611         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2612         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2613         * DumpRenderTree/mac/DumpRenderTree.mm:
2614         (resetWebViewToConsistentStateBeforeTesting):
2615         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2616         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2617         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2618         (LayoutTestController):
2619         * DumpRenderTree/win/DumpRenderTree.cpp:
2620         (resetWebViewToConsistentStateBeforeTesting):
2621         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2622         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2623         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2624         (LayoutTestController):
2625
2626 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2627
2628         Move allowRoundingHacks to Internals interface
2629         https://bugs.webkit.org/show_bug.cgi?id=87328
2630
2631         Reviewed by Hajime Morita.
2632
2633         Remove allowRoundingHacks functions, because it is able to work in the
2634         cross-port way through the Internals interface.
2635
2636         * DumpRenderTree/LayoutTestController.cpp:
2637         (LayoutTestController::staticFunctions):
2638         * DumpRenderTree/LayoutTestController.h:
2639         (LayoutTestController):
2640         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2641         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2642         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2643         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2644         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2645         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2646
2647 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
2648
2649         Fix mac build with older XCode by defining NSEC_PER_MSEC.
2650         https://bugs.webkit.org/show_bug.cgi?id=87616
2651
2652         Reviewed by Hajime Morita.
2653
2654         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
2655         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
2656         Patch just adds a #ifndef / #define check.
2657
2658         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2659         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2660
2661 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2662
2663         [EFL] Enable blob support for the EFL port
2664         https://bugs.webkit.org/show_bug.cgi?id=85363
2665
2666         Reviewed by Hajime Morita.
2667
2668         Enable Blob support by default for the EFL port.
2669
2670         * Scripts/webkitperl/FeatureList.pm:
2671
2672 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
2673
2674         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
2675         https://bugs.webkit.org/show_bug.cgi?id=87582
2676
2677         Reviewed by Darin Adler.
2678
2679         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
2680         possible to test pages in a similar way as they are loaded in Browsers.
2681
2682         * DumpRenderTree/LayoutTestController.cpp:
2683         (LayoutTestController::LayoutTestController):
2684         (setUseDeferredFrameLoadingCallback):
2685         (LayoutTestController::staticFunctions):
2686         * DumpRenderTree/LayoutTestController.h:
2687         (LayoutTestController::useDeferredFrameLoading):
2688         (LayoutTestController::setUseDeferredFrameLoading):
2689         (LayoutTestController):
2690         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2691         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2692
2693 2012-05-27  David Barton  <dbarton@mathscribe.com>
2694
2695         [watchlist] Improve MathML rule
2696         https://bugs.webkit.org/show_bug.cgi?id=87592
2697
2698         Reviewed by Adam Barth.
2699
2700         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
2701         but if this changed the rule would be slow. We protect against this, clarify the rule,
2702         and make it more similar to existing rules.
2703
2704         * Scripts/webkitpy/common/config/watchlist:
2705
2706 2012-05-27  David Barton  <dbarton@mathscribe.com>
2707
2708         [watchlist] Add myself & a rule for MathML
2709         https://bugs.webkit.org/show_bug.cgi?id=87586
2710
2711         Reviewed by Adam Barth.
2712
2713         * Scripts/webkitpy/common/config/watchlist:
2714
2715 2012-05-26  David Kilzer  <ddkilzer@apple.com>
2716
2717         Use xcrun to find path to nm for Mac port
2718         <http://webkit.org/b/87588>
2719
2720         Reviewed by Dan Bernstein.
2721
2722         * Scripts/webkitpy/layout_tests/port/mac.py:
2723         (MacPort.nm_command): Add. Tries to find a path for the nm
2724         command using xcrun.  Falls back to returning 'nm'.
2725         * Scripts/webkitpy/layout_tests/port/webkit.py:
2726         (WebKitPort.nm_command): Add. Returns 'nm'.
2727         (WebKitPort._webcore_symbols_string): Call self.nm_command().
2728
2729 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
2730
2731         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
2732
2733         Reviewed by Eric Seidel.
2734
2735         * DumpRenderTree/win/DumpRenderTree.vcproj:
2736         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2737         (FrameLoadDelegate::FrameLoadDelegate):
2738         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2739         * DumpRenderTree/win/FrameLoadDelegate.h:
2740         (FrameLoadDelegate):
2741         * DumpRenderTree/win/TextInputController.cpp: Added.
2742         (setMarkedTextCallback):
2743         (hasMarkedTextCallback):
2744         (unmarkTextCallback):
2745         (markedRangeCallback):
2746         (insertTextCallback):
2747         (firstRectForCharacterRangeCallback):
2748         (selectedRangeCallback):
2749         (TextInputController::makeWindowObject):
2750         (TextInputController::getJSClass):
2751         (TextInputController::staticValues):
2752         (TextInputController::staticFunctions):
2753         * DumpRenderTree/win/TextInputController.h: Added.
2754         (TextInputController):
2755         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
2756         (TextInputController::setMarkedText):
2757         (TextInputController::hasMarkedText):
2758         (TextInputController::unmarkText):
2759         (TextInputController::markedRange):
2760         (TextInputController::insertText):
2761         (TextInputController::firstRectForCharacterRange):
2762         (TextInputController::selectedRange):
2763
2764 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
2765
2766         webkitpy: change scm.add(), scm.delete() to accept multiple paths
2767         https://bugs.webkit.org/show_bug.cgi?id=87528
2768
2769         Reviewed by Ojan Vafai.
2770
2771         launching git or svn for individual files can be slow; this
2772         change will hand multiple paths at once to git and svn so they
2773         can be added in a batch.
2774
2775         * Scripts/webkitpy/common/checkout/scm/git.py:
2776         (Git.add_list):
2777         (Git.delete_list):
2778         * Scripts/webkitpy/common/checkout/scm/scm.py:
2779         (SCM.add):
2780         (SCM):
2781         (SCM.add_list):
2782         (SCM.delete):
2783         (SCM.delete_list):
2784         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2785         (MockSCM.add):
2786         (MockSCM):
2787         (MockSCM.add_list):
2788         (MockSCM.delete):
2789         (MockSCM.delete_list):
2790         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2791         (_shared_test_exists):
2792         (_shared_test_added_files):
2793         (_test_delete_list):
2794         * Scripts/webkitpy/common/checkout/scm/svn.py:
2795         (SVN.add_list):
2796         (SVN.delete_list):
2797
2798 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2799
2800         [NRWT] Add unit testing for perf tests on locked shards
2801         https://bugs.webkit.org/show_bug.cgi?id=87489
2802
2803         Reviewed by Dirk Pranke.
2804
2805         Adding utests that makes sure that perf tests are running in locked
2806         shards and by passing --no-http won't break NRWT (r118421).
2807
2808         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2809         (ShardingTests):
2810         (ShardingTests.test_shard_by_dir):
2811         (ShardingTests.test_shard_every_file):
2812         (ShardingTests.test_shard_in_two):
2813         (ShardingTests.test_multiple_locked_shards):
2814         (LockCheckingManager):
2815         (LockCheckingManager.__init__):
2816         (LockCheckingManager.handle_finished_list):
2817         (ManagerTest.test_http_locking):
2818         (ManagerTest):
2819         (ManagerTest.test_perf_locking):
2820         * Scripts/webkitpy/layout_tests/port/test.py:
2821
2822 2012-05-25  Jessie Berlin  <jberlin@apple.com>
2823
2824         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
2825         https://bugs.webkit.org/show_bug.cgi?id=87511
2826
2827         Reviewed by Alexey Proskuryakov.
2828
2829         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
2830
2831         * DumpRenderTree/win/EventSender.cpp:
2832         (keyDownCallback):
2833
2834 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
2835
2836         Adding Ken Buchanan to committers.py
2837         https://bugs.webkit.org/show_bug.cgi?id=87443
2838
2839         Unreviewed.
2840
2841         Adding self to committers.py as a Committer.
2842
2843         * Scripts/webkitpy/common/config/committers.py:
2844
2845 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2846
2847         [Qt] Buildfix for newer Qt5
2848         https://bugs.webkit.org/show_bug.cgi?id=87257
2849
2850         Reviewed by Simon Hausmann.
2851
2852         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
2853
2854 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2855
2856         [Qt] Unreviewed fix after r118484.
2857
2858         Enable CSS_EXCLUSIONS and CSS_REGIONS.
2859         They were enabled uncoditinally before r118484.
2860
2861         * qmake/mkspecs/features/features.pri:
2862
2863 2012-05-24  Tim Horton  <timothy_horton@apple.com>
2864
2865         Add feature defines for web-facing parts of CSS Regions and Exclusions
2866         https://bugs.webkit.org/show_bug.cgi?id=87442
2867         <rdar://problem/10887709>
2868
2869         Reviewed by Dan Bernstein.
2870
2871         * Scripts/webkitperl/FeatureList.pm:
2872
2873 2012-05-24  Hironori Bono  <hbono@chromium.org>
2874
2875         Enable grammar checking on Chromium when we paste text (Take 2)
2876         https://bugs.webkit.org/show_bug.cgi?id=74393
2877
2878         Reviewed by Ryosuke Niwa.
2879
2880         This change enables grammar checking on Chromium and implements a mock grammar
2881         checker to fix a failing test.
2882
2883         * DumpRenderTree/DumpRenderTree.gypi:
2884         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2885         (MockGrammarCheck::checkGrammarOfString):
2886         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2887         (WebKit):
2888         (MockGrammarCheck):
2889         * DumpRenderTree/chromium/WebViewHost.cpp:
2890         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2891
2892 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2893
2894         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
2895         https://bugs.webkit.org/show_bug.cgi?id=86842
2896
2897         Reviewed by Antonio Gomes.
2898
2899         Add support for overriding the application cache support preference
2900         through EFL's LayoutTestController.
2901
2902         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2903         (LayoutTestController::overridePreference):
2904
2905 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2906
2907         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
2908         https://bugs.webkit.org/show_bug.cgi?id=85209
2909
2910         Reviewed by Antonio Gomes.
2911
2912         Set developer extras setting called twice on the test startup. Hence, removing
2913         an unnecessary extra call which set wrong value. 
2914
2915         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2916         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2917
2918 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2919
2920         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2921         https://bugs.webkit.org/show_bug.cgi?id=86916
2922
2923         Reviewed by Adam Barth.
2924
2925         Note that if release and debug are failing differently, debug
2926         will be ignored ...
2927
2928         Note: also change the use of a fake port name from
2929         "mock-port-name" to "test-mac-leopard" to make it more friendly
2930         to the port factory ("mock" actually is a real port).
2931
2932         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2933         (GardeningHTTPRequestHandler._builders_to_fetch_from):
2934         (GardeningHTTPRequestHandler.rebaselineall):
2935         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2936         (GardeningServerTest.test_rebaselineall):
2937         (GardeningServerTest.test_rebaseline_new_port):
2938
2939 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2940
2941         nrwt: fix baseline search path for official chrome builders
2942         https://bugs.webkit.org/show_bug.cgi?id=87432
2943
2944         Reviewed by Tony Chang.
2945
2946         The official chrome builders need to use the win7 and SL
2947         baseline paths, not the XP and Leopard paths. Linux is correct.
2948
2949         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2950         (GoogleChromeMacPort.determine_full_port_name):
2951         (GoogleChromeWinPort.determine_full_port_name):
2952         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2953         (TestGoogleChromePort._verify_baseline_search_path_startswith):
2954         (TestGoogleChromePort.test_get_google_chrome_port):
2955
2956 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2957
2958         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
2959         https://bugs.webkit.org/show_bug.cgi?id=86800
2960
2961         Reviewed by Dirk Pranke.
2962
2963         Don't launch a HTTP server with lock based only on the existence of
2964         locked shards since we now run perf on locked shards too.
2965
2966         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2967         (Manager._run_tests):
2968
2969 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
2970
2971         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2972         https://bugs.webkit.org/show_bug.cgi?id=87128
2973
2974         Reviewed by Dirk Pranke.
2975
2976         * Scripts/webkitpy/layout_tests/port/base.py:
2977         (Port.driver_name):
2978         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2979         (ChromiumLinuxPort._path_to_driver):
2980         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2981         (ChromiumPortTest.test_driver_name_option):
2982         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2983         (ChromiumWinPort._path_to_driver):
2984         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2985         (parse_args):
2986
2987 2012-05-24  John Mellor  <johnme@chromium.org>
2988
2989         Font Boosting: Add compile flag and runtime setting
2990         https://bugs.webkit.org/show_bug.cgi?id=87394
2991
2992         Reviewed by Adam Barth.
2993
2994         Add ENABLE_FONT_BOOSTING.
2995
2996         * Scripts/webkitperl/FeatureList.pm:
2997         * qmake/mkspecs/features/features.pri:
2998
2999 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3000
3001         [EFL] [DRT] keyboard-related tests do not pass
3002         https://bugs.webkit.org/show_bug.cgi?id=85369
3003
3004         Reviewed by Gustavo Noronha Silva.
3005
3006         Add SHIFT modifier for capital letters as VK_ 
3007         codes do not distinguish between lows and caps and also to be consistent
3008         with other ports which send caps as lowercase letters with the shift key down.
3009
3010         * DumpRenderTree/efl/EventSender.cpp:
3011         (keyNameFromJSValue): 
3012
3013 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
3014
3015         [WK2] Let the client give local files universal access on a case by case basis
3016         https://bugs.webkit.org/show_bug.cgi?id=87174
3017         <rdar://problem/11024330>
3018
3019         Reviewed by Maciej Stachowiak.
3020
3021         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
3022         Added initialization of a new structure member to prevent build failure.
3023
3024 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
3025
3026         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
3027         https://bugs.webkit.org/show_bug.cgi?id=87203
3028
3029         Reviewed by Andreas Kling.
3030
3031         Add the required changes to make
3032         fast/events/keydown-leftright-keys.html pass after r118001.
3033
3034         * DumpRenderTree/efl/EventSender.cpp:
3035         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
3036         into the proper X11 keysym definitions.
3037
3038 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3039
3040         Unreviewed, rolling out r118352.
3041         http://trac.webkit.org/changeset/118352
3042         https://bugs.webkit.org/show_bug.cgi?id=87390
3043
3044         Caused 6 editing/spelling tests crash/fail on chromium in
3045         debug. (Requested by vsevik on #webkit).
3046
3047         * DumpRenderTree/DumpRenderTree.gypi:
3048         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
3049         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
3050         * DumpRenderTree/chromium/WebViewHost.cpp:
3051         (WebViewHost::finishLastTextCheck):
3052
3053 2012-05-24  Peter Beverloo  <peter@chromium.org>
3054
3055         Add John Mellor as a contributor
3056         https://bugs.webkit.org/show_bug.cgi?id=87389
3057
3058         Reviewed by Kenneth Rohde Christiansen.
3059
3060         John will be working on Font Boosting and is very involved with various
3061         web-facing subjects of Chrome for Android, such as viewport.
3062
3063         * Scripts/webkitpy/common/config/committers.py:
3064
3065 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3066
3067         [EFL][DRT] LayoutTestController's setCacheModel() implementation
3068         https://bugs.webkit.org/show_bug.cgi?id=86840
3069
3070         Reviewed by Csaba Osztrogonác.
3071
3072         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3073         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
3074         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3075         (LayoutTestController::setCacheModel): Implementation added.
3076
3077 2012-05-24  Hironori Bono  <hbono@chromium.org>
3078
3079         Enable grammar checking on Chromium when we paste text.
3080         https://bugs.webkit.org/show_bug.cgi?id=74393
3081
3082         Reviewed by Hajime Morita.
3083
3084         This change enables grammar checking on Chromium and implements a mock grammar
3085         checker to fix a failing test.
3086
3087         * DumpRenderTree/DumpRenderTree.gypi:
3088         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
3089         (MockGrammarCheck::checkGrammarOfString):
3090         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
3091         (WebKit):
3092         (MockGrammarCheck):
3093         * DumpRenderTree/chromium/WebViewHost.cpp:
3094         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
3095
3096 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
3097
3098         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
3099
3100         * qmake/mkspecs/features/features.pri:
3101
3102 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
3103
3104         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
3105         https://bugs.webkit.org/show_bug.cgi?id=86867
3106
3107         Reviewed by Adam Barth.
3108
3109         Add implementation for sendWebIntentResponse() in EFL's
3110         LayoutTestController and add empty implementation for other ports.
3111
3112         * DumpRenderTree/LayoutTestController.cpp:
3113         (sendWebIntentResponseCallback):
3114         (LayoutTestController::staticFunctions):
3115         * DumpRenderTree/LayoutTestController.h:
3116         (LayoutTestController):
3117         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3118         (LayoutTestController::sendWebIntentResponse):
3119         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3120         (DumpRenderTreeChrome::currentIntentRequest):
3121         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3122         (DumpRenderTreeChrome::onFrameIntentNew):
3123         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3124         (DumpRenderTreeChrome):
3125         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3126         (LayoutTestController::sendWebIntentResponse):
3127         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3128         (LayoutTestController::sendWebIntentResponse):
3129         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3130         (LayoutTestController::sendWebIntentResponse):
3131         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3132         (LayoutTestController::sendWebIntentResponse):
3133         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3134         (LayoutTestController::sendWebIntentResponse):
3135
3136 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
3137
3138         [EFL] The EFL port has no support for title directionality
3139         https://bugs.webkit.org/show_bug.cgi?id=86462
3140
3141         Reviewed by Gustavo Noronha Silva.
3142
3143         Update "title,changed" signal handlers in DRT and EWebLauncher to
3144         reflect the change from const char* to Ewk_Text_With_Direction* type
3145         for the title.
3146
3147         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3148         (DumpRenderTreeChrome::onTitleChanged):
3149         * EWebLauncher/main.c:
3150         (title_set):
3151         (on_title_changed):
3152         (on_key_down):
3153
3154 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3155
3156         Change EFL debug build name with more detail one
3157         https://bugs.webkit.org/show_bug.cgi?id=87254
3158
3159         Reviewed by Ryosuke Niwa.
3160
3161         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
3162         In addition, remove efl-linux-debug triggerable since nobody uses it.
3163
3164         * BuildSlaveSupport/build.webkit.org-config/config.json:
3165
3166 2012-05-23  Kangil Han  <kangil.han@samsung.com>
3167
3168         [EFL][DRT] Fix WebCore library path and rebaseline result
3169         https://bugs.webkit.org/show_bug.cgi?id=86355
3170
3171         Reviewed by Dirk Pranke.
3172
3173         Currently EFL DRT uses wrong WebCore library path when running DRT.
3174         Therefore, this patch adjusted the path correctly.
3175
3176         * Scripts/webkitpy/layout_tests/port/efl.py:
3177         (EflPort._path_to_webcore_library):
3178
3179 2012-05-23  Ojan Vafai  <ojan@chromium.org>
3180
3181         add back the ability to disable flexbox
3182         https://bugs.webkit.org/show_bug.cgi?id=87147
3183
3184         Reviewed by Tony Chang.
3185
3186         * Scripts/webkitperl/FeatureList.pm:
3187
3188 2012-05-23  Tony Chang  <tony@chromium.org>
3189
3190         Remove the Chromium Grid Layout bot from the waterfall
3191         https://bugs.webkit.org/show_bug.cgi?id=87311
3192
3193         Reviewed by Ryosuke Niwa.
3194
3195         I removed the compiler define in r117613, so we don't need a separate
3196         bot to compile/test this code.
3197
3198         * BuildSlaveSupport/build.webkit.org-config/config.json:
3199
3200 2012-05-23  Ian Vollick  <vollick@chromium.org>
3201
3202         Add vollick to list of contributors.
3203         https://bugs.webkit.org/show_bug.cgi?id=87305
3204
3205         Reviewed by Adam Barth.
3206
3207         * Scripts/webkitpy/common/config/committers.py:
3208
3209 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
3210
3211         [Chromium-Android] Fix chromium_android_unittest
3212         https://bugs.webkit.org/show_bug.cgi?id=87196
3213
3214         Reviewed by Tony Chang.
3215
3216         Update unit tests after ChromiumAndroidPort supported apk based
3217         DumpRenderTree.
3218
3219         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3220         (ChromiumAndroidPortTest):
3221         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
3222         (ChromiumAndroidPortTest.test_get_last_stacktrace):
3223         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
3224         (ChromiumAndroidDriverTest):
3225         (ChromiumAndroidDriverTest.setUp):
3226         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
3227         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
3228
3229 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3230
3231         [watchlist] Add myself and create a watch rule to catch Attribute related patches
3232         https://bugs.webkit.org/show_bug.cgi?id=87303
3233
3234         Reviewed by Alexis Menard.
3235
3236         * Scripts/webkitpy/common/config/watchlist:
3237
3238 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
3239
3240         garden-o-matic should not fetch from debug bots if it also knows about the release bots
3241         https://bugs.webkit.org/show_bug.cgi?id=86916
3242
3243         Reviewed by Adam Barth.
3244
3245         This change pushes all of the logic for rebaselining a cluster
3246         of failures (a list of tests failing a list of suffixes on a
3247         list of bots) onto the server, so there is a single call from
3248         the web page; we will then be able to optimize the performance
3249         of the rebaselining better.
3250
3251         Also remove the 'optimizebaseline' entry point on garden-o-matic
3252         (and the client-side call) since we don't need it any more.
3253
3254         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3255         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
3256         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3257         (GardeningHTTPRequestHandler.rebaselineall):
3258         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3259
3260 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
3261
3262         Mac DRT should be able to load external URLs for replay performance tests
3263         https://bugs.webkit.org/show_bug.cgi?id=86191
3264
3265         Reviewed by Alexey Proskuryakov.
3266
3267         Let external URL requests go through if the test file is not a local file or hosted at localhost.
3268         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
3269         "DumpRenderTree http://localhost:8000/".
3270
3271         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3272         (isLocalhost):
3273         (hostIsUsedBySomeTestsToGenerateError):
3274         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3275
3276 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
3277
3278         [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
3279         debug symbols for easier debugging.
3280         https://bugs.webkit.org/show_bug.cgi?id=87151
3281
3282         Reviewed by Kevin Ollivier.
3283
3284         * waf/build/settings.py:
3285         (common_configure):
3286
3287 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3288
3289         Unreviewed. Move myself to reviewers.
3290
3291         * Scripts/webkitpy/common/config/committers.py:
3292
3293 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
3294
3295         [EFL] Implements the registerProtocolHandler method and option.
3296         https://bugs.webkit.org/show_bug.cgi?id=73638
3297
3298         Reviewed by Andreas Kling.
3299
3300         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
3301
3302 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
3303
3304         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
3305         https://bugs.webkit.org/show_bug.cgi?id=87221
3306
3307         Reviewed by Martin Robinson.
3308
3309         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
3310         rightShift key names into proper GDK key symbols.
3311
3312         * DumpRenderTree/gtk/EventSender.cpp:
3313         (createKeyPressEvent):
3314
3315 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3316
3317         [Qt] Make the web view's url property follow the active url
3318
3319         https://bugs.webkit.org/show_bug.cgi?id=77554
3320
3321         Update  the location bar in the minibrowser to behave
3322         a bit more like normal browsers in terms of when the url will change
3323         and how active focus is handled.
3324
3325         Reviewed by Simon Hausmann.
3326
3327         * MiniBrowser/qt/qml/BrowserWindow.qml:
3328
3329 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
3330
3331         [Qt] Remove references to $$QT_SOURCE_TREE
3332
3333         With a modularized Qt, it's ambigious. What we really want is qtbase,
3334         which qtcore is a proxy for (we assume it will always live in qtbase).
3335
3336         Reviewed by Tor Arne Vestbø.
3337
3338         * DumpRenderTree/qt/DumpRenderTree.pro:
3339
3340 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
3341
3342         [Qt] Fix qmake conditional for c++-11 compat warnings
3343
3344         Reviewed by Tor Arne Vestbø.
3345
3346         * qmake/mkspecs/features/unix/default_post.prf:
3347
3348 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
3349
3350         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
3351         https://bugs.webkit.org/show_bug.cgi?id=85956
3352
3353         Reviewed by Gustavo Noronha Silva.
3354
3355         Catch new "load,provisional,failed" signal and print
3356         didFailProvisionalLoadWithError messages when LayoutTestController's
3357         dumpFrameLoadCallbacks() returns true. Also make sure the
3358         didFailLoadWithError message is not printed in case of provisional
3359         load failure.
3360
3361         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3362         (DumpRenderTreeChrome::createView):
3363         (DumpRenderTreeChrome::onFrameCreated):
3364         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
3365         (DumpRenderTreeChrome::onFrameLoadError):
3366         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3367         (DumpRenderTreeChrome):
3368
3369 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
3370
3371         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
3372         https://bugs.webkit.org/show_bug.cgi?id=86366
3373
3374         Reviewed by Antonio Gomes.
3375
3376         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
3377
3378         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3379         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3380
3381 2012-05-22  Darin Adler  <darin@apple.com>
3382
3383         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
3384         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
3385
3386 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3387
3388         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
3389         https://bugs.webkit.org/show_bug.cgi?id=86922
3390
3391         Because we have new platformInit() in TestShellAndroid.cpp, and
3392         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
3393         is split into TestShellPosix.cpp and TestShellX11.cpp.
3394
3395         Reviewed by Kent Tamura.
3396
3397         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3398         * DumpRenderTree/DumpRenderTree.gypi:
3399         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
3400         (platformInit):
3401         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
3402         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
3403         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
3404         (AlarmHandler):
3405         (TestShell::waitTestFinished):
3406         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
3407         (openStartupDialog): from TestShellGtk.cpp
3408         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
3409         (setupFontconfig):
3410         (platformInit):
3411
3412 2012-05-22  Kangil Han  <kangil.han@samsung.com>
3413
3414         [EFL][DRT] Implement touch event
3415         https://bugs.webkit.org/show_bug.cgi?id=86720
3416
3417         Reviewed by Hajime Morita.
3418
3419         Currently EFL DRT doesn't support touch event.
3420         Therefore, this patch enabled it and implemented some eventSender function callbacks.
3421
3422         * DumpRenderTree/efl/EventSender.cpp:
3423         (TouchEventInfo::TouchEventInfo):
3424         (TouchEventInfo):
3425         (touchPointList):
3426         (sendTouchEvent):
3427         (addTouchPointCallback):
3428         (touchStartCallback):
3429         (updateTouchPointCallback):
3430         (touchMoveCallback):
3431         (cancelTouchPointCallback):
3432         (touchCancelCallback):
3433         (releaseTouchPointCallback):
3434         (touchEndCallback):
3435         (clearTouchPointsCallback):
3436         (setTouchModifierCallback):
3437         * Scripts/webkitperl/FeatureList.pm:
3438
3439 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3440
3441         [Chromium-Android] Fix chromium_android_unittest
3442         https://bugs.webkit.org/show_bug.cgi?id=87196
3443
3444         Not reviewed.
3445         Temporarily disable chromium_android_unittest.
3446
3447         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3448         (ChromiumAndroidPortTest):
3449         (ChromiumAndroidDriverTest):
3450
3451 2012-05-22  Jessie Berlin  <jberlin@apple.com>
3452
3453         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
3454         https://bugs.webkit.org/show_bug.cgi?id=64313
3455
3456         Reviewed by Jon Honeycutt.
3457
3458         Add it.
3459
3460         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3461         Make sure to generate the binding.
3462
3463         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3464         (WTR::LayoutTestController::setDefersLoading):
3465         Call WKBundlePageSetDefersLoading.
3466         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3467
3468 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3469
3470         [Chromium-Android] Run DumpRenderTree as an apk (python part)
3471         https://bugs.webkit.org/show_bug.cgi?id=86923
3472
3473         chromium_android.py is modified to support running DumpRenderTree as
3474         an apk, so that we can run the tests (e.g. video) requiring features
3475         implemented in Java on Android.
3476
3477         Reviewed by Adam Barth.
3478
3479         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3480         (ChromiumAndroidPort.__init__):
3481         (ChromiumAndroidPort.default_child_processes):
3482         (ChromiumAndroidPort.check_wdiff):
3483         (ChromiumAndroidPort.check_build):
3484         (ChromiumAndroidPort.start_helper):
3485         (ChromiumAndroidPort.skipped_layout_tests):
3486         (ChromiumAndroidPort):
3487         (ChromiumAndroidPort._path_to_driver):
3488         (ChromiumAndroidPort._get_crash_log):
3489         (ChromiumAndroidPort._push_executable):
3490         (ChromiumAndroidPort._run_adb_command):
3491         (ChromiumAndroidPort._get_last_stacktrace):
3492         (ChromiumAndroidPort._get_logcat):
3493         (ChromiumAndroidPort._setup_performance):
3494         (ChromiumAndroidDriver):
3495         (ChromiumAndroidDriver.__init__):
3496         (ChromiumAndroidDriver._command_wrapper):
3497         (ChromiumAndroidDriver.cmd_line):
3498         (ChromiumAndroidDriver._file_exists_on_device):
3499         (ChromiumAndroidDriver._deadlock_detector):
3500         (ChromiumAndroidDriver._start):
3501         (ChromiumAndroidDriver.run_test):
3502         (ChromiumAndroidDriver.stop):
3503         (ChromiumAndroidDriver._write_command_and_read_line):
3504         (ChromiumAndroidDriver._output_image):
3505         (ChromiumAndroidDriver._get_stderr):
3506
3507 2012-05-22  Joshua Bell  <jsbell@chromium.org>
3508
3509         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
3510
3511         Unreviewed gardening.
3512
3513         * Scripts/webkitpy/layout_tests/port/base.py:
3514         (Port.driver_name):
3515         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3516         (ChromiumLinuxPort._path_to_driver):
3517         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3518         (ChromiumPortTest.test_overrides_and_builder_names):
3519         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3520         (ChromiumWinPort._path_to_driver):
3521         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3522         (parse_args):
3523
3524 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3525
3526         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
3527         https://bugs.webkit.org/show_bug.cgi?id=87176
3528
3529         Reviewed by Tony Chang.
3530
3531         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3532         * DumpRenderTree/DumpRenderTree.gypi:
3533
3534 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
3535
3536         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
3537         https://bugs.webkit.org/show_bug.cgi?id=87128
3538
3539         Reviewed by Dirk Pranke.
3540
3541         * Scripts/webkitpy/layout_tests/port/base.py:
3542         (Port.driver_name):
3543         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3544         (ChromiumLinuxPort._path_to_driver):
3545         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3546         (ChromiumPortTest.test_driver_name_option):
3547         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3548         (ChromiumWinPort._path_to_driver):
3549         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3550         (parse_args):
3551
3552 2012-05-22  Jessie Berlin  <jberlin@apple.com>
3553
3554         WTR fix after r118001.
3555
3556         Rubber-stamped by Alexey Proskuryakov.
3557
3558         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
3559
3560         * WebKitTestRunner/mac/EventSenderProxy.mm:
3561         (WTR::EventSenderProxy::keyDown):
3562
3563 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
3564
3565         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
3566         https://bugs.webkit.org/show_bug.cgi?id=86684
3567
3568         Reviewed by Darin Fisher.
3569
3570         * DumpRenderTree/chromium/LayoutTestController.cpp:
3571         (LayoutTestController::numberOfPages):
3572         * DumpRenderTree/chromium/WebViewHost.cpp:
3573         (WebViewHost::printPage):
3574
3575 == Rolled over to ChangeLog-2012-05-22 ==