Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-08  Julie Parent  <jparent@chromium.org>
2
3         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
4         https://bugs.webkit.org/show_bug.cgi?id=106356
5
6         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
7         dashboard_base, assigned by Loader, and used only by dashboard_base to
8         create error messages.  Moved the variables to be privates on the Loader
9         object, moved error message creation to _getLoadingErrorMessages on the
10         Loader object, and now pass the errors back to dashboard base via the
11         resourceLoadingComplete callback.
12         
13         Also removed the now unused clearError function, it was only being used
14         by unit tests to clean up global state.
15         
16         Reviewed by Dirk Pranke.
17
18         * TestResultServer/static-dashboards/dashboard_base.js:
19         (resourceLoadingComplete):
20         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
21         * TestResultServer/static-dashboards/loader.js:
22         (.):
23         * TestResultServer/static-dashboards/loader_unittests.js:
24
25 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
26
27         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
28         https://bugs.webkit.org/show_bug.cgi?id=106354
29
30         Reviewed by Eric Seidel.
31
32         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
33         instead of those two inheriting from it. Also add a mock object of the
34         sanitizer that's used in unit tests.
35
36         * Scripts/webkitpy/layout_tests/port/efl.py:
37         (EflPort):
38         (EflPort.__init__):
39         (EflPort.setup_test_run):
40         (EflPort.clean_up_test_run):
41         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
42         importing order.
43         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
44         * Scripts/webkitpy/layout_tests/port/gtk.py:
45         (GtkPort):
46         (GtkPort.__init__):
47         (GtkPort.setup_test_run):
48         (GtkPort.clean_up_test_run):
49         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
50         importing order.
51         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
52         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
53         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
54         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
55         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
56         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
57         (PulseAudioSanitizerMock.unload_pulseaudio_module):
58         (PulseAudioSanitizerMock.restore_pulseaudio_module):
59
60 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
61
62         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
63         https://bugs.webkit.org/show_bug.cgi?id=106324
64
65         Reviewed by Adam Barth.
66
67         Since the frame load callbacks are part of the WebFrameClient, the
68         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
69         methods.
70
71         * DumpRenderTree/chromium/DRTTestRunner.cpp:
72         (DRTTestRunner::DRTTestRunner):
73         (DRTTestRunner::reset):
74         * DumpRenderTree/chromium/DRTTestRunner.h:
75         (DRTTestRunner):
76         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
77         (WebTestInterfaces):
78         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
79         (WebKit):
80         (WebTestProxyBase):
81         (WebTestRunner):
82         (WebTestRunner::WebTestProxy::WebTestProxy):
83         (WebTestProxy):
84         (WebTestRunner::WebTestProxy::didInvalidateRect):
85         (WebTestRunner::WebTestProxy::didScrollRect):
86         (WebTestRunner::WebTestProxy::scheduleComposite):
87         (WebTestRunner::WebTestProxy::scheduleAnimation):
88         (WebTestRunner::WebTestProxy::setWindowRect):
89         (WebTestRunner::WebTestProxy::show):
90         (WebTestRunner::WebTestProxy::didAutoResize):
91         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
92         (WebTestRunner::WebTestProxy::startDragging):
93         (WebTestRunner::WebTestProxy::shouldBeginEditing):
94         (WebTestRunner::WebTestProxy::shouldEndEditing):
95         (WebTestRunner::WebTestProxy::shouldInsertNode):
96         (WebTestRunner::WebTestProxy::shouldInsertText):
97         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
98         (WebTestRunner::WebTestProxy::shouldDeleteRange):
99         (WebTestRunner::WebTestProxy::shouldApplyStyle):
100         (WebTestRunner::WebTestProxy::didBeginEditing):
101         (WebTestRunner::WebTestProxy::didChangeSelection):
102         (WebTestRunner::WebTestProxy::didChangeContents):
103         (WebTestRunner::WebTestProxy::didEndEditing):
104         (WebTestRunner::WebTestProxy::registerIntentService):
105         (WebTestRunner::WebTestProxy::dispatchIntent):
106         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
107         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
108         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
109         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
110         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
111         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
112         (WebTestRunner::WebTestProxy::didReceiveTitle):
113         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
114         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
115         (WebTestRunner::WebTestProxy::didFailLoad):
116         (WebTestRunner::WebTestProxy::didFinishLoad):
117         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
118         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
119         (WebTestRunner::WebTestProxy::didRunInsecureContent):
120         (WebTestRunner::WebTestProxy::didDetectXSS):
121         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
122         (WebTestRunner::WebTestRunner::setTestIsRunning):
123         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
124         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
125         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
126         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
127         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
128         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
129         (WebTestRunner::TestRunner::TestRunner):
130         (WebTestRunner::TestRunner::reset):
131         (WebTestRunner::TestRunner::setTestIsRunning):
132         (WebTestRunner):
133         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
134         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
135         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
136         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
137         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
138         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
139         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
140         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
141         (WebTestRunner::TestRunner::dumpTitleChanges):
142         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
143         (TestRunner):
144         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
145         (WebTestInterfaces::Internal):
146         (WebTestRunner::WebTestInterfaces::Internal::webView):
147         (WebTestRunner::WebTestInterfaces::Internal::Internal):
148         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
149         (WebTestRunner):
150         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
151         (WebTestRunner::WebTestInterfaces::setWebView):
152         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
153         (WebTestRunner::WebTestInterfaces::webView):
154         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
155         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
156         (WebTestRunner):
157         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
158         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
159         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
160         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
161         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
162         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
163         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
164         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
165         (WebTestRunner::WebTestProxyBase::didFailLoad):
166         (WebTestRunner::WebTestProxyBase::didFinishLoad):
167         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
168         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
169         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
170         (WebTestRunner::WebTestProxyBase::didDetectXSS):
171         * DumpRenderTree/chromium/TestShell.cpp:
172         (TestShell::runFileTest):
173         (TestShell::testFinished):
174         * DumpRenderTree/chromium/TestShell.h:
175         (TestShell):
176         * DumpRenderTree/chromium/WebViewHost.cpp:
177         (WebViewHost::didStartProvisionalLoad):
178         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
179         (WebViewHost::didFailProvisionalLoad):
180         (WebViewHost::didCommitProvisionalLoad):
181         (WebViewHost::didReceiveTitle):
182         (WebViewHost::didFailLoad):
183         (WebViewHost::didFinishLoad):
184         * DumpRenderTree/chromium/WebViewHost.h:
185         (WebViewHost):
186
187 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
188
189         [GTK] Lower the default timeout value for WebKitTestRunner
190         https://bugs.webkit.org/show_bug.cgi?id=106353
191
192         Reviewed by Dirk Pranke.
193
194         The default timeout value for WebKitTestRunner should be lowered.
195         The current value (80 seconds) is irrational and just leads to producing
196         text failures for layout tests that genuinely time out. This just leads
197         to more deviation from the GTK WK1 port in terms of test expectations.
198
199         The value used is the same as when running the DumpRenderTree, that's
200         6 seconds in release builds and 12 seconds in debug builds.
201
202         * Scripts/webkitpy/layout_tests/port/gtk.py:
203         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
204         (GtkPortTest.test_default_timeout_ms):
205
206 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
207
208         test-webkitpy shows failure output on my linux box
209         https://bugs.webkit.org/show_bug.cgi?id=101261
210
211         Reviewed by Eric Seidel.
212
213         Mock out the PulseAudioSanitizer methods when creating testing instances
214         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
215         PulseAudio output when the sanitizer was trying to unload modules which
216         were already unloaded by another unit test that was being run in parallel.
217
218         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
219         (EflPortTest):
220         (EflPortTest.make_port):
221         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
222         (GtkPortTest):
223         (GtkPortTest.make_port):
224
225 2013-01-08  Julie Parent  <jparent@chromium.org>
226
227         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
228         https://bugs.webkit.org/show_bug.cgi?id=106254
229
230         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
231         only to figure out if we should call addBuilderLoadErrors during
232         handleLocationChange, which was called when the loader completed and on
233         any hash change, but we only ever wanted to call addBuilderLoadErrors
234         on the initial loader load.  Moved the call of addBuilderLoadErrors to
235         resourceLoadingComplete rather than handleLocationChange, so now we
236         only call it when we want to, and the check can go away completely.
237
238         Reviewed by Dirk Pranke.
239
240         * TestResultServer/static-dashboards/dashboard_base.js:
241         (addBuilderLoadErrors):
242         (resourceLoadingComplete):
243         (handleLocationChange):
244         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
245
246 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
247
248         Add aboxhall@chromium.org to accessibility watchlist.
249
250         Unreviewed.
251
252         * Scripts/webkitpy/common/config/watchlist:
253
254 2013-01-08  Dan Winship  <danw@gnome.org>
255
256         Add Apache 2.4 support for Fedora 18
257         https://bugs.webkit.org/show_bug.cgi?id=104478
258
259         Reviewed by Martin Robinson.
260
261         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
262         need a separate config.
263
264         * Scripts/webkitpy/layout_tests/port/base.py:
265         (Port._apache_version):
266         (Port._apache_config_file_name_for_platform):
267         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
268         * Scripts/run-webkit-httpd:
269         * Scripts/webkitperl/httpd.pm:
270         (getApacheVersion):
271         (getDefaultConfigForTestDirectory):
272         (getHTTPDConfigPathForTestDirectory):
273
274 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
275
276         Make the override-feature-defines script compatible with Python v3
277         https://bugs.webkit.org/show_bug.cgi?id=105742
278
279         Reviewed by Martin Robinson.
280
281         Instead of printing output through a statement, use the print function and format
282         the output using the str.format method. This makes the script runnable with Python v3.
283
284         * gtk/override-feature-defines:
285         (adjust_feature_defines_makefile):
286
287 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
288
289         [Qt] Fix libxml2 config test
290         https://bugs.webkit.org/show_bug.cgi?id=106317
291
292         Reviewed by Simon Hausmann.
293
294         Don't assume standard include/libxml2, libxml-2.0.pc should know
295         where it's headers are.
296
297         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
298
299 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
300
301         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
302         https://bugs.webkit.org/show_bug.cgi?id=106195
303
304         Reviewed by Philippe Normand.
305
306         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
307         to make the Python code compatible with Python 3. This includes modifying
308         print statements, exception handling, dictionary iteration and
309         byte-sequence-to-string conversion.
310
311         * gtk/common.py:
312         (get_build_path):
313         (pkg_config_file_variable):
314         (gtk_version_of_pkg_config_file):
315         * gtk/generate-gtkdoc:
316         (print_missing_api):
317         * gtk/gtkdoc.py:
318         (GTKDoc.__init__):
319         (GTKDoc._run_command):
320
321 2013-01-02  Steve Block  <steveblock@chromium.org>
322
323         Add chromium.org email address for Steve Block.
324
325         Unreviewed.
326
327         * Scripts/webkitpy/common/config/committers.py:
328
329 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
330
331         Rationalize closure call heuristics and profiling
332         https://bugs.webkit.org/show_bug.cgi?id=106270
333
334         Reviewed by Oliver Hunt.
335         
336         Add ability to use display-profiler-output via a pipe, and add the ability to dump
337         all generated code ('display *' or 'd *').
338
339         * Scripts/display-profiler-output:
340
341 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
342
343         Sorted more xcodeproj files.
344
345         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
347         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
348
349 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
350
351         Sorted xcodeproj files.
352
353         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
354         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
355
356 2013-01-07  Dan Bernstein  <mitz@apple.com>
357
358         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
359         https://bugs.webkit.org/show_bug.cgi?id=106261
360
361         Reviewed by Simon Fraser.
362
363         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
364
365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
366         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
367         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
368         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
369         (TestWebKitAPI):
370         (TestWebKitAPI::TEST):
371
372 2013-01-07  Ojan Vafai  <ojan@chromium.org>
373
374         Add the Apple MountainLion bots to garden-o-matic.
375         Eventually, we really should move away from hardcoding
376         the list of bots.
377
378         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
379
380 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
381
382         [chromium] move web audio related methods to testrunner library
383         https://bugs.webkit.org/show_bug.cgi?id=106211
384
385         Reviewed by Adam Barth.
386
387         * DumpRenderTree/chromium/DRTTestRunner.cpp:
388         (DRTTestRunner::DRTTestRunner):
389         (DRTTestRunner::reset):
390         * DumpRenderTree/chromium/DRTTestRunner.h:
391         (DRTTestRunner):
392         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
393         (WebKit):
394         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
395         (WebTestRunner::WebTestRunner::audioData):
396         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
397         (WebTestRunner::TestRunner::TestRunner):
398         (WebTestRunner::TestRunner::reset):
399         (WebTestRunner::TestRunner::shouldDumpAsAudio):
400         (WebTestRunner):
401         (WebTestRunner::TestRunner::audioData):
402         (WebTestRunner::TestRunner::setAudioData):
403         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
404         (TestRunner):
405         * DumpRenderTree/chromium/TestShell.cpp:
406         (TestShell::dump):
407
408 2013-01-07  Mike West  <mkwst@chromium.org>
409
410         Make the IFRAME_SEAMLESS flag runtime-enabled.
411         https://bugs.webkit.org/show_bug.cgi?id=106213
412
413         Reviewed by Ojan Vafai.
414
415         * DumpRenderTree/chromium/TestShell.cpp:
416         (TestShell::TestShell):
417         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
418         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
419         * DumpRenderTree/gtk/DumpRenderTree.cpp:
420         (resetDefaultsToConsistentValues):
421         * DumpRenderTree/mac/DumpRenderTree.mm:
422         (resetDefaultsToConsistentValues):
423         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
424         (WebCore::WebPage::resetSettings):
425         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
426         (WTR::InjectedBundle::beginTesting):
427             Ensure that seamless IFrames are enabled for layout tests in each of
428             the ports that support seamless IFrames.
429
430 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
431
432         [chromium] move dumpAsText and friends to the TestRunner library
433         https://bugs.webkit.org/show_bug.cgi?id=106222
434
435         Reviewed by Adam Barth.
436
437         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
438
439         * DumpRenderTree/chromium/DRTTestRunner.cpp:
440         (DRTTestRunner::DRTTestRunner):
441         (DRTTestRunner::reset):
442         * DumpRenderTree/chromium/DRTTestRunner.h:
443         (DRTTestRunner):
444         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
445         (WebTestRunner::WebTestRunner::shouldDumpAsText):
446         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
447         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
448         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
449         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
450         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
451         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
452         (WebTestRunner::TestRunner::TestRunner):
453         (WebTestRunner::TestRunner::reset):
454         (WebTestRunner::TestRunner::shouldDumpAsText):
455         (WebTestRunner):
456         (WebTestRunner::TestRunner::setShouldDumpAsText):
457         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
458         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
459         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
460         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
461         (WebTestRunner::TestRunner::dumpAsText):
462         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
463         (WebTestRunner::TestRunner::dumpChildFramesAsText):
464         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
465         (TestRunner):
466
467 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
468
469         Build fix attempt after r138810.
470
471         Apparently python 2.6 is really bad at floating point computation.
472
473         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
474         (MainTest.test_run_memory_test):
475
476 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
477
478         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
479         https://bugs.webkit.org/show_bug.cgi?id=106172
480
481         Reviewed by Tony Chang.
482
483         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
484         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
485         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
486         test on perf-o-matic and perf. test's results page.
487
488         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
489
490         * Scripts/webkitpy/performance_tests/perftest.py:
491         (PerfTestMetric): Added.
492         (PerfTestMetric.__init__): Added.
493         (PerfTestMetric.metric): Added.
494         (PerfTestMetric.has_values): Added.
495         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
496         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
497         conversions to be done on the client side (perf-o-matic and results page).
498         (PerfTestMetric.append): Added.
499         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
500         a result for this metric.
501         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
502         (PerfTestMetric.compute_statistics): Moved from PerfTest.
503
504         (PerfTest._create_driver): Extracted from PerfTest.run.
505         (PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
506         as needed.
507         (PerfTest._run_with_driver):
508         (PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
509         (PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
510         all keys except "values". We rely on PerfTestMetric to compute the statistics for us.
511
512         (ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
513         from other perf tests, there isn't much point in sharing the code here.
514
515         (PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
516         statistics for the measured values.
517
518         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
519         (TestPerfTestMetric): Added.
520         (TestPerfTestMetric.test_init_set_missing_unit): Added.
521         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
522         (TestPerfTestMetric.test_has_values): Added.
523         (TestPerfTestMetric.test_append): Added.
524         (TestPerfTestMetric.test_compute_statistics.compute_statistics):
525         (TestPerfTestMetric.test_compute_statistics): Added a trivial test case.
526
527         (TestPerfTest._assert_results_are_correct): Updated as needed.
528         (TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
529         in PerfTest.run now after generating the results dictionary.
530         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.
531
532 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
533
534         Support size_t multiplication and division operators on LayoutUnit
535         https://bugs.webkit.org/show_bug.cgi?id=83848
536
537         Reviewed by Emil A Eklund.
538
539         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
540         Added some simple tests for the new operators using size_t.
541
542 2013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
543
544         [Qt] run-webkit-tests cleanup for parallel NRWT
545         https://bugs.webkit.org/show_bug.cgi?id=106220
546
547         Reviewed by Dirk Pranke.
548
549         * Scripts/run-webkit-tests:
550         (useNewRunWebKitTests):
551         * Scripts/webkitpy/layout_tests/port/qt.py:
552         (QtPort):
553         (QtPort.default_child_processes):
554
555 2013-01-07  Philippe Normand  <pnormand@igalia.com>
556
557         Create a GStreamerAudio watchlist and add myself to it.
558
559         Unreviewed.
560
561         * Scripts/webkitpy/common/config/watchlist:
562
563 2013-01-05  Ryosuke Niwa  <rniwa@webkit.org>
564
565         Add svn:executable to a bunch of scripts in BuildSlaveSupport.
566         Also removed the empty mac directory.
567
568         * BuildSlaveSupport/built-product-archive: Added property svn:executable.
569         * BuildSlaveSupport/download-built-product: Added property svn:executable.
570         * BuildSlaveSupport/mac: Removed.
571         * BuildSlaveSupport/test-result-archive: Added property svn:executable.
572
573 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
574
575         Add a script to delete stale zero-byte build files
576         https://bugs.webkit.org/show_bug.cgi?id=106131
577
578         Reviewed by Tony Chang.
579
580         Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
581
582         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
583         (DeleteStaleBuildFiles): Added.
584         (Factory.__init__): Add DeleteStaleBuildFiles step.
585         * BuildSlaveSupport/delete-stale-build-files: Added.
586         (main): Delete zero-byte files except ones intentionally generated by our build process.
587         (webkitBuildDirectory): Copied from build-product-archive.
588
589 2013-01-04  Michael Pruett  <michael@68k.org>
590
591         [GTK] Fix build error on GTK due to r138836
592         https://bugs.webkit.org/show_bug.cgi?id=106154
593
594         Reviewed by Kentaro Hara.
595
596         * GNUmakefile.am:
597
598 2013-01-04  Dan Bernstein  <mitz@apple.com>
599
600         [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
601         https://bugs.webkit.org/show_bug.cgi?id=106121
602
603         Reviewed by Adele Peterson.
604
605         Added test for -[DOMTHMLTableCellElement _cellAbove].
606
607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
608         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
609         (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
610         (TestWebKitAPI):
611         (TestWebKitAPI::expectCellAboveCell):
612         (TestWebKitAPI::TEST):
613         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
614
615 2013-01-04  Eric Seidel  <eric@webkit.org>
616
617         FlakyTestReporter should be re-enabled and taught how to post patches
618         https://bugs.webkit.org/show_bug.cgi?id=103839
619
620         Reviewed by Adam Barth.
621
622         This moves LayoutTestResultsReader off of the DeprecatedPort object.
623         It also adds a real Port object to the EWS and CommitQueue objects
624         using a new PatchProcessingQueue superclass.
625         PatchProcessingQueue doesn't seem to be the cleanest insertion point
626         but works for this purpose.
627         I also moved _upload_results_archive_for_patch into PatchProcessingQueue
628         to resolve a FIXME.
629
630         This required some hacks/shiming between the non-specific "old"
631         port names which the EWS system is currently using, and the new
632         port objects.  This shimming is done in PatchProcessingQueue._new_port_name_from_old.
633
634         Hopefully this will fix the flaky test reporter and results uploading.
635         Certainly it's another small step towards getting rid of the old ports.py
636         infrastructure and making the NRWT Port class common webkitpy infrastructure.
637
638         Now that DeprecatedPort is no longer used for the results directory
639         I removed all the explicit results-dir code which webkit-patch was using
640         in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
641
642         * Scripts/webkitpy/common/config/ports.py:
643         (DeprecatedPort.run_perl_unittests_command):
644         * Scripts/webkitpy/common/config/ports_mock.py:
645         (MockPort.name):
646         * Scripts/webkitpy/common/system/outputcapture.py:
647         (OutputCapture.assert_outputs):
648         * Scripts/webkitpy/layout_tests/port/apple.py:
649         (ApplePort.determine_full_port_name):
650         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
651         (LayoutTestResultsReader.__init__):
652         (LayoutTestResultsReader):
653         (LayoutTestResultsReader._read_file_contents):
654         (LayoutTestResultsReader._create_layout_test_results):
655         (LayoutTestResultsReader._create_unit_test_results):
656         (LayoutTestResultsReader.results):
657         (LayoutTestResultsReader.archive):
658         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
659         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
660         (LayoutTestResultsReaderTest.test_create_unit_test_results):
661         (test_missing_unit_test_results_path):
662         (test_layout_test_results):
663         (test_archive_last_layout_test_results):
664         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
665         (AbstractEarlyWarningSystem):
666         (AbstractEarlyWarningSystem.__init__):
667         (AbstractEarlyWarningSystem.begin_work_queue):
668         (AbstractEarlyWarningSystem.run_command):
669         * Scripts/webkitpy/tool/commands/queues.py:
670         (AbstractPatchQueue.work_item_log_path):
671         (PatchProcessingQueue):
672         (PatchProcessingQueue._new_port_name_from_old):
673         (PatchProcessingQueue.begin_work_queue):
674         (PatchProcessingQueue._upload_results_archive_for_patch):
675         (CommitQueue):
676         (CommitQueue.begin_work_queue):
677         (CommitQueue.run_command):
678         (AbstractReviewQueue):
679         (AbstractReviewQueue.__init__):
680         (AbstractReviewQueue.begin_work_queue):
681         * Scripts/webkitpy/tool/commands/queues_unittest.py:
682         (AbstractPatchQueueTest.test_next_patch):
683         (PatchProcessingQueueTest):
684         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
685         * Scripts/webkitpy/tool/steps/runtests.py:
686         (RunTests.run):
687         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
688
689 2013-01-04  Dana Jansens  <danakj@chromium.org>
690
691         [chromium] Remove lost-compositor-context layout tests
692         https://bugs.webkit.org/show_bug.cgi?id=106089
693
694         Reviewed by James Robinson.
695
696         Remove the loseCompositorContext() test function.
697
698         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
699         (WebTestRunner::TestRunner::TestRunner):
700         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
701         (TestRunner):
702
703 2013-01-04  Adam Klein  <adamk@chromium.org>
704
705         Remove ENABLE_MUTATION_OBSERVERS #define
706         https://bugs.webkit.org/show_bug.cgi?id=105459
707
708         Reviewed by Ryosuke Niwa.
709
710         * Scripts/webkitperl/FeatureList.pm:
711         * qmake/mkspecs/features/features.pri:
712
713 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
714
715         Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
716         https://bugs.webkit.org/show_bug.cgi?id=106078
717
718         Reviewed by Tony Chang.
719
720         This patch updates values for individual iterations in dummy performance tests used in
721         perftest_unittest.py and perftest_integrationtest.py so that they match up with
722         statistics such as stdev and median reported in those tests. This change is required
723         to resolve the bug 97510.
724
725         This patch also refactors integration tests by extracting *TestData classes that
726         centralizes the definitions of each dummy performance test's text (DRT output),
727         runner output, and parsed results (JSON) so that we may share more data between
728         python tests.
729
730         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
731         (MainTest._assert_results_are_correct): Extracted from test_parse_output.
732         Use self.assertAlmostEqual when comparing the standard deviation.
733         (MainTest.test_parse_output):
734         (test_parse_output_with_failing_line):
735         (test_parse_output_with_description): Use _assert_results_are_correct.
736         (test_parse_output_with_subtests): Ditto.
737
738         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
739         (InspectorPassTestData): Extracted from tests below.
740         (EventTargetWrapperTestData): Ditto.
741         (SomeParserTestData): Ditto.
742         (MemoryTestData): Ditto.
743         (TestDriver.run_test): Moved test definitions out of the method.
744         (MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
745         (MainTest._load_output_json): Extracted from create_runner.
746         (MainTest.create_runner):
747         (MainTest.test_run_test_set_for_parser_tests):
748         (MainTest.test_run_memory_test):
749         (MainTest._test_run_with_json_output):
750         (MainTest.test_run_with_json_output):
751         (MainTest.test_run_with_description):
752         (MainTest.test_run_generates_json_by_default):
753         (MainTest.test_run_merges_output_by_default):
754         (MainTest.test_run_respects_reset_results):
755         (MainTest.test_run_generates_and_show_results_page):
756         (MainTest.test_run_with_slave_config_json):
757         (MainTest.test_run_with_multiple_repositories):
758
759 2013-01-04  Martin Robinson  <mrobinson@igalia.com>
760
761         [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
762         https://bugs.webkit.org/show_bug.cgi?id=106045
763
764         Reviewed by Carlos Garcia Campos.
765
766         Update test results to confirm that compositions without preedits do not trigger
767         a composition confirmation.
768
769         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
770         (TestWebKitAPI::verifyCanceledComposition):
771
772 2013-01-04  Sailesh Agrawal  <sail@chromium.org>
773
774         [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
775         https://bugs.webkit.org/show_bug.cgi?id=105958
776
777         Reviewed by Alexey Proskuryakov.
778
779         Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
780
781         * WebKitTestRunner/mac/EventSenderProxy.mm:
782         (KeyMappingEntry):
783         (WTR):
784         (WTR::EventSenderProxy::keyDown): Added all numpad keys.
785
786 2013-01-03  Chris Fleizach  <cfleizach@apple.com>
787
788         REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
789         https://bugs.webkit.org/show_bug.cgi?id=106073
790
791         Reviewed by Ryosuke Niwa.
792
793         Check that the element being compared to is not nil. 
794         This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
795         It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
796         controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it 
797         sometimes before on parallel WebKitTestRunner runs.
798
799         * DumpRenderTree/AccessibilityUIElement.cpp:
800         (AccessibilityUIElement::isEqual):
801         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
802         (WTR::AccessibilityUIElement::isEqual):
803
804 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
805
806         Downloads can be flaky, so try downloading multiple times.
807         https://bugs.webkit.org/show_bug.cgi?id=105976
808
809         Reviewed by Eric Seidel.
810
811         * Scripts/webkitpy/common/system/autoinstall.py:
812         (AutoInstaller._download_to_stream):
813
814 2013-01-03  Eric Seidel  <eric@webkit.org>
815
816         Rename Tool.port to deprecated_port in preparation for removing more callers
817         https://bugs.webkit.org/show_bug.cgi?id=106076
818
819         Reviewed by Ryosuke Niwa.
820
821         This resolves a long-standing FIXME to rename this method. :)
822
823         * Scripts/webkitpy/tool/bot/botinfo.py:
824         (BotInfo.summary_text):
825         * Scripts/webkitpy/tool/bot/irc_command.py:
826         (Rollout._update_working_copy):
827         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
828         (LayoutTestResultsReader._create_layout_test_results):
829         (LayoutTestResultsReader._create_unit_test_results):
830         (LayoutTestResultsReader._results_directory):
831         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
832         (test_missing_unit_test_results_path):
833         * Scripts/webkitpy/tool/main.py:
834         (WebKitPatch.deprecated_port):
835         * Scripts/webkitpy/tool/mocktool.py:
836         (MockTool.deprecated_port):
837         * Scripts/webkitpy/tool/steps/build.py:
838         (Build.build):
839         * Scripts/webkitpy/tool/steps/checkstyle.py:
840         (CheckStyle.run):
841         * Scripts/webkitpy/tool/steps/commit.py:
842         (Commit._check_test_expectations):
843         * Scripts/webkitpy/tool/steps/preparechangelog.py:
844         (PrepareChangeLog.run):
845         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
846         (PrepareChangeLogForDEPSRoll.run):
847         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
848         (PrepareChangeLogForRevert.run):
849         * Scripts/webkitpy/tool/steps/runtests.py:
850         (RunTests.run):
851         * Scripts/webkitpy/tool/steps/steps_unittest.py:
852         (StepsTest.test_runtests_args):
853         * Scripts/webkitpy/tool/steps/update.py:
854         (Update._update_command):
855
856 2013-01-03  Eric Seidel  <eric@webkit.org>
857
858         Add myself to the webkitpy watchlist.
859
860         Unreviewed.
861
862         * Scripts/webkitpy/common/config/watchlist:
863
864 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
865
866         Cleanup perftest* tests and add a test for computing statistics
867         https://bugs.webkit.org/show_bug.cgi?id=105685
868
869         Reviewed by Eric Seidel.
870
871         Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
872         extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
873
874         Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
875
876         * Scripts/webkitpy/performance_tests/perftest.py:
877         (PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
878         directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
879         accurate result for the mean.
880         (PageLoadingPerfTest.run_single):
881         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
882         (MainTest.test_compute_statistics):
883         (MainTest.test_compute_statistics.compute_statistics): Added.
884         (TestPageLoadingPerfTest.test_run): floatify values.
885         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
886         correctly recognizes them as integers.
887
888         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
889         Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
890         (TestDriver): Moved out of MainTest.
891         (MainTest): Got rid of assertWritten and all unit tests.
892         (MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
893         (MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
894         (MainTest.test_run_test_set_for_parser_tests):
895         (MainTest.test_run_memory_test):
896         (MainTest._test_run_with_json_output):
897         (MainTest.test_run_generates_json_by_default):
898         (MainTest.test_run_merges_output_by_default):
899         (MainTest.test_run_respects_reset_results):
900         (MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
901         parsing output JSON files. Just verify that the output path is correct instead.
902         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
903         (MainTest): Removed all integration tests.
904         (MainTest.create_runner): Simplified.
905
906 2013-01-03  Julie Parent  <jparent@chromium.org>
907
908         Dashboard cleanup: remove usage of global g_defaultBuilderName
909         https://bugs.webkit.org/show_bug.cgi?id=106043
910
911         Use now public defaultBuilder() from the BuilderGroup, rather
912         than global variable.
913
914         Also eliminates the setup() and initBuilders() functions since we
915         no longer need to track the global.
916
917         Reviewed by Adam Barth.
918
919         * TestResultServer/static-dashboards/builders.js:
920         (BuilderGroup.prototype.defaultBuilder):
921         (BuilderGroup.prototype.master):
922         * TestResultServer/static-dashboards/dashboard_base.js:
923         (parseParameters):
924         * TestResultServer/static-dashboards/flakiness_dashboard.js:
925         (updateDefaultBuilderState):
926         * TestResultServer/static-dashboards/loader.js:
927         (.):
928         * TestResultServer/static-dashboards/loader_unittests.js:
929
930 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
931
932         Disable an intermittently failing unit test for now.
933         The failure is tracked by the bug 106051.
934
935         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
936         (TestWebKitAPI::TEST):
937
938 2013-01-03  Dan Bernstein  <mitz@apple.com>
939
940         No way to obtain a DOMNode given a JS wrapper for a Node
941         https://bugs.webkit.org/show_bug.cgi?id=106033
942
943         Added a test for +[DOMNode _nodeFromJSWrapper:].
944
945         Reviewed by Sam Weinig.
946
947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
948         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
949         (TestWebKitAPI):
950         (TestWebKitAPI::TEST):
951
952 2013-01-03  Emil A Eklund  <eae@chromium.org>
953
954         Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
955         https://bugs.webkit.org/show_bug.cgi?id=105961
956
957         Reviewed by Levi Weintraub.
958         
959         Add tests for LayoutUnit::ceil and floor.
960
961         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
962         (TestWebKitAPI::TEST):
963         (TestWebKitAPI):
964
965 2013-01-03  Julie Parent  <jparent@chromium.org>
966
967         Add unit test for default builder for the dashboards.
968         https://bugs.webkit.org/show_bug.cgi?id=105972
969
970         Reviewed by Dirk Pranke.
971
972         * TestResultServer/static-dashboards/loader_unittests.js:
973
974 2013-01-03  Tony Chang  <tony@chromium.org>
975
976         Generate internal.settings from Settings.in
977         https://bugs.webkit.org/show_bug.cgi?id=104740
978
979         Reviewed by Adam Barth.
980
981         * GNUmakefile.am: Compile new generated files on GTK+.
982         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
983         with both extra_sources and add_output_to_sources=false will still
984         compile the files in extra_sources. This makes it possible to compile
985         InternalSettingsGenerated.cpp and not be confused by
986         InternalSettingsGenerated.idl.
987
988 2013-01-03  Zan Dobersek  <zandobersek@gmail.com>
989
990         [style] WebIDL-reflecting uppercase enums reported as style violation
991         https://bugs.webkit.org/show_bug.cgi?id=105832
992
993         Reviewed by Tony Chang.
994
995         Recognize the enum as WebIDL-reflecting one if there's a comment present that
996         indicates this. In enums spanning over multiple lines, the comment is expected
997         on the first line. In enums placed in one line, the comment is expected at the
998         end of that line.
999
1000         WebIDL-reflecting enum values are required to be written in uppercase and as such
1001         violate the common rule of these values being written in InterCaps. Annotating
1002         enums this way makes it possible to avoid false style violation reports.
1003
1004         The comment is of form '// Web(?:Kit)?IDL enum'.
1005
1006         * Scripts/webkitpy/style/checkers/cpp.py:
1007         (_EnumState.__init__):
1008         (_EnumState.process_clean_line):
1009         (check_enum_casing):
1010         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1011         (NoNonVirtualDestructorsTest.test_enum_casing):
1012
1013 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
1014
1015         Adding favicon.ico to the garden-o-matic.
1016         https://bugs.webkit.org/show_bug.cgi?id=105982
1017
1018         Reviewed by Adam Barth.
1019
1020         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1021         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
1022
1023 2013-01-03  Jonathan Liu  <net147@gmail.com>
1024
1025         [Qt] Fix library linking order
1026         https://bugs.webkit.org/show_bug.cgi?id=105818
1027
1028         Some Qt libraries are linked before the private static libraries
1029         that depend on them which results in QtWebKit failing to link.
1030
1031         Copy Qt module dependencies from QT to QT_PRIVATE when creating
1032         module to ensure the Qt libraries are linked after the private
1033         static libraries that depend on them.
1034
1035         Reviewed by Tor Arne Vestbø.
1036
1037         * qmake/mkspecs/features/default_post.prf:
1038
1039 2013-01-02  Byungwoo Lee  <bw80.lee@samsung.com>
1040
1041         [EFL][WK2] Fix tooltip bugs in MiniBrowser.
1042         https://bugs.webkit.org/show_bug.cgi?id=102209
1043
1044         Reviewed by Gyuyoung Kim.
1045
1046         Set tooltip on the elm_window instead of ewk_view, and add delay to
1047         show the tooltip window.
1048
1049         Setting tooltip on the ewk_view makes elementary error message because
1050         ewk_view is not an elementary widget. To remove the error message,
1051         tooltip should be set on the elm_window.
1052
1053         Most browsers show the tooltip after a mouse pointer stays on an
1054         element object that has tooltip text.
1055         But elm_tooltip widget itself doesn't have delay or handle mouse
1056         events to show/hide.
1057
1058         So additional codes are added to show/hide tooltip widget along with
1059         mouse events.
1060           1) When a mouse pointer stays for a second on an element which has
1061              tooltip text, then tooltip widget is displayed.
1062           2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
1063              widget.
1064
1065         * MiniBrowser/efl/main.c:
1066         (_Tooltip_Information):
1067         (_Browser_Window):
1068         (on_tooltip_show):
1069         (window_tooltip_hide):
1070         (window_tooltip_update):
1071         (on_mouse_in):
1072         (on_mouse_move):
1073         (on_mouse_out):
1074         (window_free):
1075         (on_tooltip_text_set):
1076         (on_tooltip_text_unset):
1077         (window_create):
1078
1079 2013-01-02  Tony Chang  <tony@chromium.org>
1080
1081         Unreviewed, rolling out r138661.
1082         http://trac.webkit.org/changeset/138661
1083         https://bugs.webkit.org/show_bug.cgi?id=104740
1084
1085         Compile problems on EFL
1086
1087         * GNUmakefile.am:
1088         * qmake/mkspecs/features/default_post.prf:
1089
1090 2013-01-02  Tony Chang  <tony@chromium.org>
1091
1092         Generate internal.settings from Settings.in
1093         https://bugs.webkit.org/show_bug.cgi?id=104740
1094
1095         Reviewed by Adam Barth.
1096
1097         * GNUmakefile.am: Compile new generated files on GTK+.
1098         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
1099         with both extra_sources and add_output_to_sources=false will still
1100         compile the files in extra_sources. This makes it possible to compile
1101         InternalSettingsGenerated.cpp and not be confused by
1102         InternalSettingsGenerated.idl.
1103
1104 2013-01-02  Adam Barth  <abarth@webkit.org>
1105
1106         Remove old-run-webkit-tests support from webkitpy
1107         https://bugs.webkit.org/show_bug.cgi?id=105619
1108
1109         Reviewed by Eric Seidel.
1110
1111         This patch removes support for webkitpy parsing the
1112         old-run-webkit-tests results format. There doesn't seem to be any
1113         reason to keep this code around anymore now that most bots have
1114         switched to new-run-webkit-tests.
1115
1116         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1117         (Builder.fetch_layout_test_results):
1118         * Scripts/webkitpy/common/net/layouttestresults.py:
1119         (path_for_layout_test):
1120         (LayoutTestResults.results_from_string):
1121         (LayoutTestResults):
1122         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1123         (LayoutTestResultsTest.test_results_from_string):
1124         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1125         (test_flaky_test_failure):
1126         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1127         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1128         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1129         (PatchAnalysisTask._test_patch):
1130         * Scripts/webkitpy/tool/commands/queuestest.py:
1131         (QueuesTest.assert_queue_outputs):
1132
1133 2013-01-02  Heikki Paajanen  <heikki.paajanen@palm.com>
1134
1135         [Qt][WK2] Add simple UI to find text from page
1136         https://bugs.webkit.org/show_bug.cgi?id=96481
1137
1138         Reviewed by Jocelyn Turcotte.
1139
1140         Find bar that slides between navigation bar and WebView.
1141
1142         * MiniBrowser/qt/BrowserWindow.cpp:
1143         (BrowserWindow::toggleFind):
1144         * MiniBrowser/qt/BrowserWindow.h:
1145         (BrowserWindow):
1146         * MiniBrowser/qt/MiniBrowser.qrc:
1147         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1148         (MiniBrowserApplication::notify):
1149         * MiniBrowser/qt/icons/find.png: Added.
1150         * MiniBrowser/qt/qml/BrowserWindow.qml:
1151
1152 2013-01-02  Christophe Dumez  <christophe.dumez@intel.com>
1153
1154         Regression(r138603): Caused 2 webkitpy tests to fail
1155         https://bugs.webkit.org/show_bug.cgi?id=105913
1156
1157         Reviewed by Kentaro Hara.
1158
1159         Fix 2 webkitpy tests that started to fail after
1160         r138603.
1161
1162         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1163         (IRCCommandTest._sheriff_test_data_url): Make sure the
1164         returned test file URL is valid no matter what the
1165         current working directory is.
1166         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1167         (IRCBotTest.test_help): Add "sheriffs" command to the
1168         list of available commands.
1169
1170 2013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
1171
1172         [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
1173         https://bugs.webkit.org/show_bug.cgi?id=105897
1174
1175         Reviewed by Alexey Proskuryakov.
1176
1177         Dump in WebKitTestRunner the message that is expected by layout tests
1178         when the missing plugin button is clicked.
1179
1180         * WebKitTestRunner/TestController.cpp:
1181         (WTR::TestController::createWebViewWithOptions):
1182         (WTR::TestController::unavailablePluginButtonClicked):
1183         (WTR):
1184         * WebKitTestRunner/TestController.h:
1185         (TestController):
1186
1187 2013-01-01  KwangYong Choi  <ky0.choi@samsung.com>
1188
1189         [EFL] Enable MHTML feature
1190         https://bugs.webkit.org/show_bug.cgi?id=105815
1191
1192         Reviewed by Laszlo Gombos.
1193
1194         Enable MHTML feature for EFL port by default.
1195
1196         * Scripts/webkitperl/FeatureList.pm:
1197
1198 2013-01-01  Alan Cutter  <alancutter@chromium.org>
1199
1200         sheriff-bot should know who the gardeners/sheriffs are
1201         https://bugs.webkit.org/show_bug.cgi?id=105698
1202
1203         Reviewed by Eric Seidel.
1204
1205         Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
1206
1207         * Scripts/webkitpy/tool/bot/irc_command.py:
1208         (Current):
1209         (Current._retrieve_webkit_sheriffs):
1210         (Current.execute):
1211         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1212         (IRCCommandTest.test_current):
1213         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
1214         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
1215         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
1216         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
1217         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
1218
1219 2012-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1220
1221         [GTK] Move ImageDiff to the Tools directory root
1222         https://bugs.webkit.org/show_bug.cgi?id=105421
1223
1224         Reviewed by Kenneth Rohde Christiansen.
1225
1226         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
1227         * GNUmakefile.am:
1228         * ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
1229
1230 2012-12-30  Mike West  <mkwst@chromium.org>
1231
1232         Add myself to watchlists for CSP and console logs.
1233         https://bugs.webkit.org/show_bug.cgi?id=105874
1234
1235         Reviewed by Dirk Pranke.
1236
1237         Because I really, really, really need more email.
1238
1239         * Scripts/webkitpy/common/config/committers.py:
1240             Add mkwst+watchlist@chromium.org as a contributor.
1241         * Scripts/webkitpy/common/config/watchlist:
1242             Create watchlist categories for 1) the various mechanisms used to
1243             generate console messages, and 2) CSP usage and files.
1244
1245 2012-12-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1246
1247         [EFL] Enable TEMPLATE_ELEMENT feature
1248         https://bugs.webkit.org/show_bug.cgi?id=105865
1249         
1250         Reviewed by Laszlo Gombos.
1251
1252         * Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
1253
1254 2012-12-30  Zan Dobersek  <zandobersek@gmail.com>
1255
1256         Unreviewed GTK gardening of the unit tests.
1257
1258         Skip the TestInspectorServer unit test that's timing out completely.
1259
1260         * Scripts/run-gtk-tests:
1261         (TestRunner):
1262
1263 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
1264
1265         Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
1266         https://bugs.webkit.org/show_bug.cgi?id=105855
1267
1268         Reviewed by Vsevolod Vlasov.
1269
1270         Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
1271         addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.
1272
1273         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
1274         (ReportMemoryUsageVisitor):
1275         (clang::AddMemberCallVisitor::VisitCallExpr):
1276         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
1277         (clang::ReportMemoryUsageVisitor::checkMembersCoverage):
1278
1279 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
1280
1281         Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
1282         https://bugs.webkit.org/show_bug.cgi?id=105852
1283
1284         Reviewed by Alexander Pavlov.
1285
1286         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
1287         (clang):
1288         (AddMemberCallVisitor):
1289         (ReportMemoryUsageVisitor):
1290         (clang::ReportMemoryUsageAction::ParseArgs):
1291         (clang::AddMemberCallVisitor::VisitCallExpr):
1292         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
1293         (clang::ReportMemoryUsageVisitor::emitWarning):
1294         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
1295         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
1296         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
1297
1298 2012-12-29  Zan Dobersek  <zandobersek@gmail.com>
1299
1300         [webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
1301         https://bugs.webkit.org/show_bug.cgi?id=105835
1302
1303         Reviewed by Dirk Pranke.
1304
1305         The BeautifulSoup module is a third-party import and as such we don't have much control
1306         over its testing. Because of that it should be omitted from code coverage checking.
1307
1308         * Scripts/webkitpy/test/main.py:
1309         (Tester._run_tests):
1310
1311 2012-12-28  Martin Robinson  <mrobinson@igalia.com>
1312
1313         [GTK][WK2] Add support for IME Composition
1314         https://bugs.webkit.org/show_bug.cgi?id=65093
1315
1316         Reviewed by Carlos Garcia Campos.
1317
1318         Update unit tests for GtkInputMethodFilter to note whether or not an event
1319         was a fake event synthesized for composition purposes. This is now used
1320         for WebKit2.
1321
1322         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
1323         (TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
1324         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
1325         (TestWebKitAPI::TEST):
1326         * gtk/generate-gtkdoc:
1327         (get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
1328         generation.
1329
1330 2012-12-27  Ilya Tikhonovsky  <loislo@chromium.org>
1331
1332         Web Inspector: Native Memory Instrumentation. Update clang plugin according to the current state of memory instrumentation code.
1333         https://bugs.webkit.org/show_bug.cgi?id=105800
1334
1335         Reviewed by Yury Semikhatsky.
1336
1337         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
1338         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
1339         (clang):
1340
1341 2012-12-27  Zan Dobersek  <zandobersek@gmail.com>
1342
1343         Create a GTK build system watchlist and add myself to it
1344         https://bugs.webkit.org/show_bug.cgi?id=105769
1345
1346         Reviewed by Dirk Pranke.
1347
1348         Add a GTK build system watchlist, watching the configure.ac, GNUmakefile.am files
1349         and the input GNUmakefile.features.am.in file. The GNUmakefile.list.am files are
1350         omitted on purpose due to relatively high change rate they are exposed to.
1351
1352         The new watchlist would be of use to me as the GTK build system recently went
1353         through a series of changes that included a changed policy on adding configuration
1354         flags to configure.ac and subsequent additions to GNUmakefile.am files. A PSA on the
1355         mailing list about this change will be published later, but I'd also like to be
1356         notified of any pending changes to these files just so I can check the changes are
1357         in compliance with the new policy.
1358
1359         * Scripts/webkitpy/common/config/watchlist:
1360
1361 2012-12-26  Ilya Tikhonovsky  <loislo@chromium.org>
1362
1363         Unreviewed. Replace find("Tools") with rfind("Tools") because base dir of WebKit may have Tools word.
1364         As example ..../DevTools/src/third_party/WebKit
1365
1366         * Scripts/webkitpy/common/webkit_finder.py:
1367         (WebKitFinder.webkit_base):
1368
1369 2012-12-25  Christophe Dumez  <christophe.dumez@intel.com>
1370
1371         [EFL][WK2] Refactor snapshot taking code
1372         https://bugs.webkit.org/show_bug.cgi?id=105687
1373
1374         Reviewed by Kenneth Rohde Christiansen.
1375
1376         Call WKViewCreateSnapshot() instead of WKViewGetSnapshot()
1377         since the function was renamed to follow naming style.
1378
1379         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1380         (WTR::PlatformWebView::windowSnapshotImage):
1381
1382 2012-12-24  Ilya Tikhonovsky  <loislo@chromium.org>
1383
1384         Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
1385         https://bugs.webkit.org/show_bug.cgi?id=105725
1386
1387         Reviewed by Yury Semikhatsky.
1388
1389         MemberType value names were adjusted according to Style Guide.
1390         Existing tests were extended with link type validation.
1391
1392         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
1393
1394 2012-12-24  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1395
1396         [BlackBerry] DRT - Crashed when running pixels tests
1397         https://bugs.webkit.org/show_bug.cgi?id=105711
1398
1399         RIM PR 270003
1400
1401         Reviewed by George Staikos.
1402
1403         Calling window->post() here will result in buffer swapping which is
1404         only allowed in UI thread now, and I found we don't need to call it
1405         for GL renderer.
1406
1407         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1408         (createBitmapContextFromWebView):
1409
1410 2012-12-22  Dan Winship  <danw@gnome.org>
1411
1412         Add a patch to fix libxml2 2.9.0 regression
1413         https://bugs.webkit.org/show_bug.cgi?id=104494
1414
1415         Reviewed by Martin Robinson.
1416
1417         * gtk/jhbuild.modules:
1418         * gtk/patches/libxml2-2.9.0-dtd.patch: patch from upstream
1419
1420 2012-12-23  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1421
1422         Unreviewed update of status to reviewer.
1423
1424         * Scripts/webkitpy/common/config/committers.py:
1425
1426 2012-12-23  Philippe Normand  <pnormand@igalia.com>
1427
1428         [GTK][jhbuild] Bump GStreamer to 1.0.4
1429         https://bugs.webkit.org/show_bug.cgi?id=105640
1430
1431         Reviewed by Martin Robinson.
1432
1433         * gtk/jhbuild.modules: Update GStreamer modules to 1.0.4.
1434
1435 2012-12-21  Nico Weber  <thakis@chromium.org>
1436
1437         chromium: webkit-build-directory doesn't handle ninja output dirs
1438         https://bugs.webkit.org/show_bug.cgi?id=105671
1439
1440         Reviewed by Daniel Bates.
1441
1442         Teach webkit-build-directory to detect the ninja build directory.
1443
1444         * Scripts/webkitdirs.pm:
1445         (determineBaseProductDir):
1446         (determineIsChromiumNinja):
1447
1448 2012-12-21  Ryosuke Niwa  <rniwa@webkit.org>
1449
1450         [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
1451         https://bugs.webkit.org/show_bug.cgi?id=95477
1452
1453         Reviewed by Sam Weinig.
1454
1455         Co-authored by Jia Pu.
1456
1457         Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
1458         we can have consistent autocorrection behavior when running tests.
1459
1460         * DumpRenderTree/mac/DumpRenderTree.mm:
1461         (resetDefaultsToConsistentValues):
1462         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1463         (WTR::InjectedBundle::platformInitialize):
1464
1465 2012-12-21  Zan Dobersek  <zandobersek@gmail.com>
1466
1467         [GTK] Add WebKit1-specific TestExpectations file
1468         https://bugs.webkit.org/show_bug.cgi?id=97562
1469
1470         Reviewed by Dirk Pranke.
1471
1472         Implement the expectations_files method inside the GtkPort class that
1473         returns the list of the TestExpectations files the current test configuration
1474         requires. The method is implemented in a similar way as on the EFL port.
1475         A unit test is also added.
1476
1477         * Scripts/webkitpy/layout_tests/port/gtk.py:
1478         (GtkPort._search_paths):
1479         (GtkPort):
1480         (GtkPort.expectations_files):
1481         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1482         (GtkPortTest.test_expectations_files):
1483
1484 2012-12-21  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1485
1486         [EFL] Enable feature option for the CSS sticky position
1487         https://bugs.webkit.org/show_bug.cgi?id=105630
1488
1489         Reviewed by Kenneth Rohde Christiansen.
1490
1491         Enable CSS sticky position feature by default for the
1492         EFL port. This feature option was added in r138252.
1493
1494         No new tests. Existing layout tests pass.
1495
1496         * Scripts/webkitperl/FeatureList.pm:
1497
1498 2012-12-21  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1499
1500         [WK2] REGRESSION(r138232): It made 4 tests timeout
1501         https://bugs.webkit.org/show_bug.cgi?id=105623
1502
1503         Reviewed by Kenneth Rohde Christiansen.
1504
1505         r138232 changed functionality so that empty text output
1506         no longer leads to a dump() call, which leads to a timeout.
1507         Instead do a text dump if there is text output or if there
1508         is no audio output.
1509
1510         * WebKitTestRunner/TestInvocation.cpp:
1511         (WTR::TestInvocation::dumpResults):
1512
1513 2012-12-21  Zeno Albisser  <zeno@webkit.org>
1514
1515         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
1516         https://bugs.webkit.org/show_bug.cgi?id=105309
1517
1518         On Windows the library name is Qt5WebKitWidgets as well.
1519         So r138136 should not have adjusted the library name for Windows.
1520
1521         Reviewed by Simon Hausmann.
1522
1523         * Scripts/webkitdirs.pm:
1524         (builtDylibPathForName):
1525
1526 2012-12-21  Zeno Albisser  <zeno@webkit.org>
1527
1528         [Qt] Add new TestExpectations for qt-5.0-mac-wk2.
1529         https://bugs.webkit.org/show_bug.cgi?id=105424
1530
1531         This change will allow us to run a very specific
1532         subset of the available LayoutTests on a mac buildbot.
1533         The new baseline search path for mac will look as follows:
1534         qt-5.0-mac-wk2 -> qt-5.0-wk2 -> qt-5.0 -> qt-mac -> qt
1535
1536         Reviewed by Dirk Pranke.
1537
1538         * Scripts/webkitpy/layout_tests/port/qt.py:
1539         (QtPort._search_paths):
1540         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1541         (QtPortTest):
1542
1543 2012-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
1544
1545         [EFL] Build break with latest EFL libraries.
1546         https://bugs.webkit.org/show_bug.cgi?id=104827
1547
1548         Reviewed by Laszlo Gombos.
1549
1550         The eo EFL package is introduced and evas and ecore use it since 1.8.
1551         While introducing Eo, EFL changed several structures of Evas and Ecore
1552         from own specific class to Eo.
1553
1554         So, this patch adds FindEo and changes declaration of Evas, Evas_Object,
1555         Ecore_Timer to build with latest EFL libraries.
1556
1557         * DumpRenderTree/efl/CMakeLists.txt: Includes eo EFL library.
1558         * EWebLauncher/CMakeLists.txt: Ditto.
1559         * MiniBrowser/efl/CMakeLists.txt: Ditto.
1560         * ImageDiff/PlatformEfl.cmake: Ditto.
1561         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
1562         * TestWebKitAPI/PlatformWebView.h: Modified declaration of Evas_Object.
1563         * WebKitTestRunner/InjectedBundle/TestRunner.h: Modified declaration of Ecore_Timer.
1564         * WebKitTestRunner/PlatformEfl.cmake: Includes eo EFL library.
1565         * WebKitTestRunner/PlatformWebView.h: Modified declaration of Evas_Object.
1566
1567 2012-12-20  Dirk Pranke  <dpranke@chromium.org>
1568
1569         TestExpectation fallback is broken
1570         https://bugs.webkit.org/show_bug.cgi?id=105583
1571
1572         Reviewed by Ryosuke Niwa.
1573
1574         When I added support for the -wk2 in port names, it looks
1575         like I broke the way we computed the list of TestExpectations
1576         files so that the implementation-version directory was left out :(.
1577         Fixed and cleaned up the tests.
1578
1579         * Scripts/webkitpy/layout_tests/port/base.py:
1580         (Port.expectations_files):
1581         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1582         (TestWebKitPort.__init__):
1583         (PortTestCase.test_skipped_directories_for_symbols):
1584         (test_skipped_directories_for_features):
1585         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
1586         (test_skipped_tests_for_unsupported_features_empty_test_list):
1587         (test_skipped_layout_tests):
1588         (test_expectations_files):
1589
1590 2012-12-20  Anders Carlsson  <andersca@apple.com>
1591
1592         Don't include WebKit2 headers when building TestWebKitAPI on windows
1593         https://bugs.webkit.org/show_bug.cgi?id=105582
1594
1595         Reviewed by Tim Horton.
1596
1597         * TestWebKitAPI/config.h:
1598         * TestWebKitAPI/win/main.cpp:
1599
1600 2012-12-20  Ryosuke Niwa  <rniwa@webkit.org>
1601
1602         REGRESSION(r133820?): SimplifyMarkupTest API test asserts
1603         https://bugs.webkit.org/show_bug.cgi?id=105370
1604
1605         Reviewed by Simon Fraser.
1606
1607         Re-enable the test.
1608
1609         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
1610         (TestWebKitAPI::TEST):
1611
1612 2012-12-20  Nico Weber  <thakis@chromium.org>
1613
1614         chromium nrwt: Pick the newest binary found in DEFAULT_BUILD_DIRECTORIES, not the first
1615         https://bugs.webkit.org/show_bug.cgi?id=105498
1616
1617         Reviewed by Dirk Pranke.
1618
1619         Use the newest binary available rather than an than always picking one
1620         build directory over another based on iteration order.
1621
1622         * Scripts/webkitpy/layout_tests/port/chromium.py:
1623         (ChromiumPort._static_build_path):
1624         Check for timestamps.
1625         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1626         (ChromiumMacPortTest.test_build_path_timestamps):
1627         Test that out / xcodebuild selection happens based on timestamps
1628         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1629         (ChromiumWinPortTest.test_build_path_timestamps):
1630         Test that out / build selection happens based on timestamps
1631
1632 2012-12-19  Simon Fraser  <simon.fraser@apple.com>
1633
1634         Lots of sticky tests failing in WK2
1635         https://bugs.webkit.org/show_bug.cgi?id=105464
1636
1637         Reviewed by Beth Dakin.
1638
1639         WebKitTestRunner had a race between snapshotting in the UI process,
1640         and resettting after the test in the web process. InjectedBundle::done()
1641         was a bad place to call page()->resetAfterTest(), because of this race;
1642         it could reset the scroll position before the UI snapshot had been obtained.
1643         
1644         Fix by moving the call to page()->resetAfterTest() into didReceiveMessage(),
1645         for the "Reset" message which will come in before the next test.
1646
1647         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1648         (WTR::InjectedBundle::didReceiveMessage):
1649         (WTR::InjectedBundle::done):
1650
1651 2012-12-19  Filip Pizlo  <fpizlo@apple.com>
1652
1653         DFG speculation checks that take JumpList should consolidate OSRExits
1654         https://bugs.webkit.org/show_bug.cgi?id=105401
1655
1656         Reviewed by Oliver Hunt.
1657
1658         Update the profiler to understand that an OSR exit may have multiple
1659         candidate exit sites.
1660
1661         * Scripts/display-profiler-output:
1662
1663 2012-12-20  Eric Seidel  <eric@webkit.org>
1664
1665         EWSes do not need to dump build/test logs when things pass
1666         https://bugs.webkit.org/show_bug.cgi?id=105402
1667
1668         Reviewed by Dirk Pranke.
1669
1670         When we were first writing the commit-queue and EWS system
1671         and running them locally, we thought it was important to see the
1672         build/test output as it happened.  Now these queues have been running
1673         for years, and we don't use this feature anymore.  So this patch
1674         makes us stop tee-ing the output directly to stdout, and instead
1675         only print any output from commands when they fail.
1676
1677         I also added some logging when we execute each command
1678         since we are no longer printing the command output itself.
1679         This should make it much easier to see errors with the EWS
1680         system itself, now that all the passing-build output is removed.
1681
1682         This required updating a zillion unittests, since we have a bunch of
1683         "integration" style testing of the queue-bots.  Many of the unittests for the bots were
1684         already approximating this behavior by using a "logging" Executive.
1685         I disabled logging in those cases to avoid redundant logging in those tests.
1686
1687         * Scripts/webkitpy/common/system/executive.py:
1688         (Executive.command_for_printing):
1689         (Executive.run_command):
1690         * Scripts/webkitpy/common/system/executive_mock.py:
1691         (MockExecutive.command_for_printing):
1692         (MockExecutive.run_command):
1693         * Scripts/webkitpy/common/system/executive_unittest.py:
1694         (ExecutiveTest.test_auto_stringify_args):
1695         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1696         (EarlyWarningSytemTest._default_expected_logs):
1697         (_test_ews):
1698         (_test_ewses):
1699         * Scripts/webkitpy/tool/commands/queues.py:
1700         (AbstractQueue.run_webkit_patch):
1701         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1702         (AbstractQueueTest._assert_run_webkit_patch):
1703         (CommitQueueTest.test_commit_queue):
1704         (test_rollout):
1705         (test_rollout_lands):
1706         (test_manual_reject_during_processing):
1707         (StyleQueueTest.test_style_queue_with_style_exception):
1708         (test_style_queue_with_watch_list_exception):
1709
1710 2012-12-20  Dominic Mazzoni  <dmazzoni@google.com>
1711
1712         AX: support clickPoint in DRT for chromium
1713         https://bugs.webkit.org/show_bug.cgi?id=97359
1714
1715         Reviewed by Chris Fleizach.
1716
1717         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
1718         several more tests can pass.
1719
1720         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1721         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
1722         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
1723         (WebTestRunner):
1724         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
1725         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
1726         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
1727         (AccessibilityUIElement):
1728
1729 2012-12-20  Dan Bernstein  <mitz@apple.com>
1730
1731         prepare-ChangeLog adds "Additional information of the change such as approach, rationale" where it doesn't make sense
1732         https://bugs.webkit.org/show_bug.cgi?id=99268
1733
1734         Reviewed by Alexey Proskuryakov.
1735
1736         * Scripts/prepare-ChangeLog:
1737         (generateNewChangeLogs): Removed the "Additional information of the change" line.
1738
1739 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1740
1741         Unreviewed. Skip unit test /webkit/atk/getTextInParagraphAndBodyModerate
1742
1743         * Scripts/run-gtk-tests:
1744         (TestRunner):
1745
1746 2012-12-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1747
1748         [Qt] Move ImageDiff to the Tools directory root
1749         https://bugs.webkit.org/show_bug.cgi?id=105420
1750
1751         Reviewed by Tor Arne Vestbø.
1752
1753         Moved ImageDiff from outside DumpRenderTree because it is also a
1754         dependency when running pixel tests for WebKit2.
1755
1756         * ImageDiff/ImageDiff.pro: Renamed from Tools/DumpRenderTree/qt/ImageDiff.pro.
1757         * ImageDiff/qt/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/qt/ImageDiff.cpp.
1758         * Tools.pro:
1759
1760 2012-12-20  Zan Dobersek  <zandobersek@gmail.com>
1761
1762         [GTK] Remove the --enable-unstable-features configuration option
1763         https://bugs.webkit.org/show_bug.cgi?id=105327
1764
1765         Reviewed by Martin Robinson.
1766
1767         Add a missing feature option for the CSS sticky position feature.
1768
1769         * Scripts/webkitperl/FeatureList.pm:
1770
1771 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1772
1773         Unreviewed. Skip unit test WebKit2.ForceRepaint that times out
1774
1775         * Scripts/run-gtk-tests:
1776         (TestRunner):
1777
1778 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
1779
1780         [EFL] MiniBrowser does not play Infinite Gangnam Style
1781         https://bugs.webkit.org/show_bug.cgi?id=103531
1782
1783         Reviewed by Kenneth Rohde Christiansen.
1784
1785         For EFL we would like this feature to be built by default.
1786
1787         * Scripts/webkitperl/FeatureList.pm:
1788
1789 2012-12-20  Csaba Osztrogonác  <ossy@webkit.org>
1790
1791         [Qt] EWS bots should call qmake always
1792         https://bugs.webkit.org/show_bug.cgi?id=90049
1793
1794         Reviewed by Simon Hausmann.
1795
1796         * Scripts/webkitdirs.pm:
1797         (buildQMakeProjects):
1798
1799 2012-12-20  Jochen Eisinger  <jochen@chromium.org>
1800
1801         [chromium] fix stray printf in TestRunner's WebTestProxy
1802         https://bugs.webkit.org/show_bug.cgi?id=105515
1803
1804         Reviewed by Ryosuke Niwa.
1805
1806         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1807         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
1808
1809 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
1810
1811         [WK2] WebAudio WKTR support
1812         https://bugs.webkit.org/show_bug.cgi?id=95084
1813
1814         Reviewed by Kenneth Rohde Christiansen.
1815
1816         Implementing audio data dump support for WebKitTestRunner,
1817         by adding the API to the IDL, enabling IPC for transferring
1818         the audio data as bytebuffer and dumping it according
1819         to run-webkit-tests script's expectations.
1820         This enables audio testing on WebKit2 ports.
1821         Based on initial wip-patch from Philippe Normand - thanks.
1822
1823         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding setAudioData API.
1824         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Assign audio buffer data to a local WKDataRef after extracting it from WK2 using WKBundleDataFromUint8Array bundle API.
1825         (WTR::TestRunner::setAudioData):
1826         (WTR):
1827         * WebKitTestRunner/InjectedBundle/TestRunner.h: Add a whatToDump state for dumping Audio.
1828         (TestRunner):
1829         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Add audio to the message that's transferred to the WKTR process.
1830         (WTR::InjectedBundle::done):
1831         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Allow setting and audio result handle to be transferred.
1832         (WTR::InjectedBundle::setAudioResult):
1833         (InjectedBundle):
1834         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1835         (WTR::InjectedBundlePage::dump): Dummy handling the Audio case in the switch, build fix for Mac.
1836         * WebKitTestRunner/TestInvocation.cpp: Audio dump support, dump audio if we haven't received a text dump from the web process.
1837         (WTR::TestInvocation::dumpResults):
1838         (WTR):
1839         (WTR::TestInvocation::dumpAudio):
1840         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Storing received audio data before dumping.
1841         * WebKitTestRunner/TestInvocation.h:
1842         (TestInvocation):
1843
1844 2012-12-20  Alberto Garcia  <agarcia@igalia.com>
1845
1846         [GTK] Count failed and timed out tests separately
1847         https://bugs.webkit.org/show_bug.cgi?id=105448
1848
1849         Reviewed by Carlos Garcia Campos.
1850
1851         Display the number of tests that fail, time out and are skipped
1852         separately in the buildbot page.
1853
1854         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1855         (RunGtkAPITests.commandComplete):
1856         (RunGtkAPITests.evaluateCommand):
1857         (RunGtkAPITests.getText2):
1858         * Scripts/run-gtk-tests:
1859         (TestRunner.run_tests):
1860
1861 2012-12-19  Ryosuke Niwa  <rniwa@webkit.org>
1862
1863         PerfTest.parse_output does too much
1864         https://bugs.webkit.org/show_bug.cgi?id=105391
1865
1866         Reviewed by Tony Chang.
1867
1868         Moved the code to filter lines into PerfTest._filter_output, which has been renamed from _filter_stderr.
1869         Also moved the code to output test results into PerfTest._run_with_driver.
1870
1871         * Scripts/webkitpy/performance_tests/perftest.py:
1872         (PerfTest.__init__): Added _description.
1873         (PerfTest.description): Added.
1874         (PerfTest._run_with_driver): Moved the code to output test description and test results.
1875         (PerfTest._filter_output): Moved and renamed from PerfTest._filter_stderr.
1876         (PerfTest.parse_output): Removed the code to output test results. Return test results and description
1877         respectively. Also removed the code that allowed some tests to omit values since all tests report each
1878         iteration now since r136492.
1879         (PerfTest.output_statistics): Removed the code to print test description, now done in _run_with_driver.
1880         (ChromiumStylePerfTest._run_with_driver): Added. Chromium style tests are sufficiently different from
1881         regular PerfTest that it doesn't make much sense to share _run_with_driver. But really, we should just
1882         get rid of this type of test altogether in favor of regular performance tests that uses runner.js.
1883         (ChromiumStylePerfTest.parse_and_log_output): Renamed from parse_output.
1884         (PageLoadingPerfTest._run_with_driver): Removed the explicit '' for the test description.
1885         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1886         (MainTest.test_parse_output): Removed the expected logs since parse_output no longer prints out results.
1887         Also added a call to _filter_output since parse_output doesn't filter the output text anymore.
1888         (MainTest.test_parse_output_with_failing_line): Added a call to _filter_output. Also added ',' after 'Time:'
1889         so that it's not string-concatenated with the next line.
1890         (MainTest.test_parse_output_with_description): Added; a test for PerfTest.description().
1891         (MainTest.test_parse_output_with_subtests): Removed the expected logs, and added a call to _filter_output.
1892
1893 2012-12-19  Alexis Menard  <alexis@webkit.org>
1894
1895         Implement CSS parsing for CSS transitions unprefixed.
1896         https://bugs.webkit.org/show_bug.cgi?id=104804
1897
1898         Reviewed by Dean Jackson.
1899
1900         Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
1901         to cover the work of unprefixing Transforms, Animations and 
1902         Transitions. It will let the possibility of each ports to turn it off 
1903         in their release branches until we're confident that these CSS 
1904         properties are ready to be unprefixed.
1905
1906         * Scripts/webkitperl/FeatureList.pm:
1907         * qmake/mkspecs/features/features.pri:
1908
1909 2012-12-19  Julien Chaffraix  <jchaffraix@webkit.org>
1910
1911         2 clampTo unit tests are failing
1912         https://bugs.webkit.org/show_bug.cgi?id=105253
1913
1914         Reviewed by Emil A Eklund.
1915
1916         Removed clampToUnsigned as it was actually testing exactly what
1917         clampToUnsignedLong was doing. Also made clampToIntFloat more robust
1918         to precision loss (fix suggested by Emil).
1919
1920         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1921
1922 2012-12-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1923
1924         [EFL] Move ImageDiff to the Tools directory root
1925         https://bugs.webkit.org/show_bug.cgi?id=105305
1926
1927         Reviewed by Laszlo Gombos.
1928
1929         We previously moved this directory from the DRT directory to
1930         efl/ImageDiff. The major reason for doing so was because ImageDiff does
1931         not depend on DumpRenderTree but for legacy reasons was living inside the
1932         DRT folder, even though it is needed when running pixel tests for WK2.
1933
1934         Now we are moving to Tool directory root as other ports agreed to do the same.
1935
1936         * CMakeLists.txt:
1937         * ImageDiff/CMakeLists.txt: Added.
1938         * ImageDiff/PlatformEfl.cmake: Added.
1939         * ImageDiff/efl/ImageDiff.cpp: Renamed from Tools/efl/ImageDiff/ImageDiff.cpp.
1940         * efl/ImageDiff/CMakeLists.txt: Removed.
1941
1942 2012-12-19  Zeno Albisser  <zeno@webkit.org>
1943
1944         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
1945         https://bugs.webkit.org/show_bug.cgi?id=105309
1946
1947         The version number is only used as a part
1948         of the library name on Linux.
1949
1950         Reviewed by Kenneth Rohde Christiansen.
1951
1952         * Scripts/webkitdirs.pm:
1953         (builtDylibPathForName):
1954
1955 2012-12-19  Alberto Garcia  <agarcia@igalia.com>
1956
1957         [GTK] Tests that time out are not considered as failures.
1958         https://bugs.webkit.org/show_bug.cgi?id=105318
1959
1960         Reviewed by Martin Robinson.
1961
1962         Fix parsing of the GTK API tests log files.
1963
1964         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1965         (RunGtkAPITests.commandComplete):
1966
1967 2012-12-18  Ilya Tikhonovsky  <loislo@chromium.org>
1968
1969         Unreviewed, rolling out r138061.
1970         https://bugs.webkit.org/show_bug.cgi?id=105396
1971
1972         Original patch:
1973         http://trac.webkit.org/changeset/138061
1974         https://bugs.webkit.org/show_bug.cgi?id=97359
1975
1976         It is crashing on Debug bots
1977
1978         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1979         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
1980         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
1981         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
1982         (AccessibilityUIElement):
1983
1984 2012-12-18  Alice Liu  <alice.liu@apple.com>
1985
1986         Test for https://bugs.webkit.org/show_bug.cgi?id=105106
1987         Add SPI to WebKit1 WebFrame for hit testing
1988
1989         Reviewed by Dan Bernstein.
1990
1991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/ElementAtPointInWebFrame.mm
1992         * TestWebKitAPI/Tests/mac/ElementAtPointInWebFrame.mm: Added.
1993         (TestWebKitAPI::TEST): Loads html with two divs positioned in the 2nd and 4th quadrants of the webview.
1994         Then hit-tests at three points, expecting to hit the two divs and body element. 
1995
1996 2012-12-18  Alice Liu  <alice.liu@apple.com>
1997
1998         Test for https://bugs.webkit.org/show_bug.cgi?id=105262
1999         Add SPI to WebKit1 WebFrame for node conversion to JSValueRef
2000
2001         Reviewed by Anders Carlsson.
2002
2003         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/JSWrapperForNodeInWebFrame.mm.mm
2004         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm.mm: Added.
2005         (TestWebKitAPI::TEST): Tests for the correct JS wrapper for a DOMNode, provided a WebScriptWorld.
2006         Loads html with a single div element. In an isolated world, creates a property on that node.
2007         Also, in the standard world, creates a different property on that node.  Then tests for 4 things:
2008             - Existence of the isolated property in the isolated world.
2009             - Existence of the standard property in the standard world.
2010             - Non-existence of the isolated property in the standard world.
2011             - Non-existence of the standard property in the isolated world.
2012
2013 2012-12-18  Simon Fraser  <simon.fraser@apple.com>
2014
2015         Disable the SimplifyMarkup API test, wich asserts in debug builds.
2016         Tracked by https://bugs.webkit.org/show_bug.cgi?id=105370.
2017         
2018         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2019         (TestWebKitAPI::TEST):
2020
2021 2012-12-18  Joseph Pecoraro  <pecoraro@apple.com>
2022
2023         [Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)
2024         https://bugs.webkit.org/show_bug.cgi?id=104279
2025
2026         Reviewed by David Kilzer.
2027
2028         Add a build phase script that checks a framework's header files for
2029         Platform.h and Compiler.h macros. Also add some tests for the script.
2030
2031         * Scripts/check-for-inappropriate-macros-in-external-headers: Added.
2032         Script to be used in build phases to check for inappropriate macros in headers.
2033
2034         * Scripts/test-webkitruby: Added.
2035         Script that can be used to run all webkitruby tests.
2036
2037         * Scripts/test-webkit-scripts:
2038         Also run the ruby tests.
2039
2040         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/fake-data-failing-expected.txt: Added.
2041         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/pass-expected.txt: Added.
2042         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Fail.h: Added.
2043         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Pass.h: Added.
2044         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/run-test.rb: Added.
2045         Tests for the new script.
2046
2047 2012-12-18  Dominic Mazzoni  <dmazzoni@google.com>
2048
2049         AX: support clickPoint in DRT for chromium
2050         https://bugs.webkit.org/show_bug.cgi?id=97359
2051
2052         Reviewed by Chris Fleizach.
2053
2054         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
2055         several more tests can pass.
2056
2057         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2058         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2059         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
2060         (WebTestRunner):
2061         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
2062         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2063         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2064         (AccessibilityUIElement):
2065
2066 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
2067
2068         Build fix after r138045.
2069
2070         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2071         (PerfTestsRunner._collect_tests): Use relative_path. We skip only when this path
2072         is not explicitly specified. The condition was backwards but never matched so we
2073         always ran the test regardless of whether it's listed in the skipped list or not.
2074         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2075         (test_collect_tests_with_ignored_skipped_list): Renamed so that it actually runs.
2076
2077 2012-12-18  Emil A Eklund  <eae@chromium.org>
2078
2079         TestWebKitAPI/Tests/WebCore/LayoutUnit fails on mac
2080         https://bugs.webkit.org/show_bug.cgi?id=105332
2081         
2082         Reviewed by Levi Weintraub.
2083         
2084         Create new test suite for LayoutUnit tests as the KURL tests are
2085         of the incompatible TEST_F type.
2086
2087         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2088         (TestWebKitAPI):
2089         (TestWebKitAPI::TEST_F):
2090
2091 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
2092
2093         Running a skipped test with run-perf-tests could alert the user
2094         https://bugs.webkit.org/show_bug.cgi?id=105219
2095
2096         Reviewed by Eric Seidel.
2097
2098         Force run skipped performance tests explicitly specified in the command line.
2099         Also warn the user when the specified paths don't exist.
2100
2101         * Scripts/webkitpy/layout_tests/port/base.py:
2102         (Port.relative_test_filename):
2103         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2104         (PerfTestsRunner._parse_args):
2105         (PerfTestsRunner._collect_tests):
2106         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2107         (test_collect_tests_with_skipped_list_and_files):
2108
2109 2012-12-18  Yaron Friedman  <yfriedman@chromium.org>
2110
2111         Chrome Android java output is too verbose
2112         https://bugs.webkit.org/show_bug.cgi?id=105247
2113
2114         Reviewed by Tony Chang.
2115
2116         Pass -quiet to ant to suppress extraneous output.
2117
2118         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2119         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2120
2121 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
2122
2123         Consider removing --pause-before-testing option
2124         https://bugs.webkit.org/show_bug.cgi?id=105248
2125
2126         Reviewed by Eric Seidel.
2127
2128         Remove --pause-before-testing option.
2129
2130         * Tools/Scripts/webkitpy/layout_tests/port/driver.py:
2131         (DriverProxy.start): Removed.
2132         * Scripts/webkitpy/performance_tests/perftest.py:
2133         (PerfTest.__init__):
2134         (PerfTest.test_path): Renamed from path_or_url.
2135         (PerfTest.run):
2136         (PerfTest): Removed "driver" argument.
2137         (PerfTest._run_with_driver):
2138         (PerfTest.run_single):
2139         (ChromiumStylePerfTest.__init__):
2140         (PageLoadingPerfTest.__init__):
2141         (PageLoadingPerfTest.run_single):
2142         (PageLoadingPerfTest._run_with_driver): Renamed from run so that PerfTest.run can create a driver for us.
2143         (ReplayPerfTest.__init__):
2144         (ReplayPerfTest.prepare):
2145         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2146         (TestPageLoadingPerfTest.test_run):
2147         (TestPageLoadingPerfTest.test_run_with_memory_output):
2148         (TestPageLoadingPerfTest.test_run_with_bad_output):
2149         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2150         (PerfTestsRunner._parse_args):
2151         (PerfTestsRunner._run_tests_set): Removed the code to create a driver and pause before running the test.
2152         (PerfTestsRunner._run_single_test): Removed "driver" argument.
2153         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2154         (run_test):
2155         (test_run_test_pause_before_testing): Removed.
2156
2157 2012-12-18  Alberto Garcia  <agarcia@igalia.com>
2158
2159         [GTK] Tests that time out are not considered as failures.
2160         https://bugs.webkit.org/show_bug.cgi?id=105318
2161
2162         Reviewed by Martin Robinson.
2163
2164         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2165         (RunGtkAPITests.commandComplete):
2166         Consider log lines that end with TIMEOUT as errors.
2167
2168         * Scripts/run-gtk-tests:
2169         (TestRunner.run_tests):
2170         Consider timeouts as failures when returning the number of failed
2171         tests.
2172
2173 2012-12-18  Pravin D  <pravin.d@samsung.com>
2174
2175         Unreviewed, adding secondary email.
2176
2177         * Scripts/webkitpy/common/config/committers.py:
2178
2179 2012-12-18  Pravin D  <pravin.d@samsung.com>
2180
2181         Unreviewed, promoting myself to committer's list.
2182
2183         * Scripts/webkitpy/common/config/committers.py:
2184
2185 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2186
2187         [EFL] ImageDiff does not build on WebKit2 only builds
2188         https://bugs.webkit.org/show_bug.cgi?id=105288
2189
2190         Reviewed by Kenneth Rohde Christiansen.
2191
2192         Moved ImageDiff to the efl/ folder inside Tools/ (so we don't pollute
2193         the folder with things which are EFL-specific.
2194
2195         ImageDiff will be built by default now regardless of WebKit API flavor
2196         you choose.
2197
2198         * CMakeLists.txt:
2199         * DumpRenderTree/efl/CMakeLists.txt:
2200         * efl/ImageDiff/CMakeLists.txt: Added.
2201         * efl/ImageDiff/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/efl/ImageDiff.cpp.
2202
2203 2012-12-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2204
2205         [EFL][WK2] When creating new windows, use the opener's context
2206         https://bugs.webkit.org/show_bug.cgi?id=105283
2207
2208         Reviewed by Laszlo Gombos.
2209
2210         Use the context of the opener if exists.
2211
2212         * MiniBrowser/efl/main.c:
2213         (on_key_down):
2214         (on_window_create):
2215         (window_create):
2216         (elm_main):
2217
2218 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2219
2220         [EFL][WK2] Gardening of TestWebKitAPI tests
2221         https://bugs.webkit.org/show_bug.cgi?id=105268
2222
2223         Reviewed by Kenneth Rohde Christiansen.
2224
2225         Some tests were marked as failing but are passing and the newly added
2226         LayoutUnit should have it's own binary because it conflicts with the
2227         fixture used by KURL and is failing on the bots because of that.
2228
2229         * TestWebKitAPI/CMakeLists.txt:
2230         * TestWebKitAPI/PlatformEfl.cmake:
2231
2232 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
2233
2234         [chromium] move webintent related methods to TestRunner library
2235         https://bugs.webkit.org/show_bug.cgi?id=105164
2236
2237         Reviewed by Darin Fisher.
2238
2239         Also deleted the unused deliveredIntentFailure and
2240         deliveredIntentResult methods.
2241
2242         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2243         (DRTTestRunner::DRTTestRunner):
2244         * DumpRenderTree/chromium/DRTTestRunner.h:
2245         (DRTTestRunner):
2246         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2247         (WebKit):
2248         (WebTestRunner::WebTestDelegate::setCurrentWebIntentRequest):
2249         (WebTestRunner::WebTestDelegate::currentWebIntentRequest):
2250         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2251         (WebKit):
2252         (WebTestProxyBase):
2253         (WebTestRunner::WebTestProxy::registerIntentService):
2254         (WebTestRunner::WebTestProxy::dispatchIntent):
2255         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2256         (WebTestRunner::TestRunner::TestRunner):
2257         (WebTestRunner::TestRunner::sendWebIntentResponse):
2258         (WebTestRunner):
2259         (WebTestRunner::TestRunner::deliverWebIntent):
2260         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2261         (TestRunner):
2262         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2263         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
2264         (WebTestRunner::WebTestProxyBase::registerIntentService):
2265         (WebTestRunner):
2266         (WebTestRunner::WebTestProxyBase::dispatchIntent):
2267         * DumpRenderTree/chromium/WebViewHost.cpp:
2268         (WebViewHost::setCurrentWebIntentRequest):
2269         (WebViewHost::currentWebIntentRequest):
2270         * DumpRenderTree/chromium/WebViewHost.h:
2271         (WebKit):
2272         (WebViewHost):
2273
2274 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
2275
2276         [chromium] move editing callback dumping to the WebTestProxy
2277         https://bugs.webkit.org/show_bug.cgi?id=105013
2278
2279         Reviewed by Darin Fisher.
2280
2281         To decide whether or not to dump the editing callbacks, the WebTestProxy
2282         needs to query the TestRunner. For this purpose, I introduce a
2283         WebTestRunner class that just exposes the shouldDumpEditingCallbacks
2284         method. In contrast to e.g. WebEventSender, the WebTestRunner is just
2285         an interface, and it is not owned by the WebTestInterfaces, but the
2286         embedder of the TestRunner library must provide it. This will change
2287         once all TestRunner methods are in the library.
2288
2289         * DumpRenderTree/DumpRenderTree.gypi:
2290         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2291         (DRTTestRunner::DRTTestRunner):
2292         (DRTTestRunner::reset):
2293         * DumpRenderTree/chromium/DRTTestRunner.h:
2294         (DRTTestRunner):
2295         (DRTTestRunner::taskList):
2296         (DRTTestRunner::WorkQueue::taskList):
2297         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2298         (WebTestRunner):
2299         (WebTestInterfaces):
2300         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2301         (WebKit):
2302         (WebTestRunner):
2303         (WebTestProxyBase):
2304         (WebTestRunner::WebTestProxy::shouldBeginEditing):
2305         (WebTestRunner::WebTestProxy::shouldEndEditing):
2306         (WebTestRunner::WebTestProxy::shouldInsertNode):
2307         (WebTestRunner::WebTestProxy::shouldInsertText):
2308         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
2309         (WebTestRunner::WebTestProxy::shouldDeleteRange):
2310         (WebTestRunner::WebTestProxy::shouldApplyStyle):
2311         (WebTestRunner::WebTestProxy::didBeginEditing):
2312         (WebTestRunner::WebTestProxy::didChangeSelection):
2313         (WebTestRunner::WebTestProxy::didChangeContents):
2314         (WebTestRunner::WebTestProxy::didEndEditing):
2315         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
2316         (WebTestRunner):
2317         (WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
2318         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2319         (WebTestRunner::TestRunner::TestRunner):
2320         (WebTestRunner::TestRunner::~TestRunner):
2321         (WebTestRunner):
2322         (WebTestRunner::TestRunner::reset):
2323         (WebTestRunner::TestRunner::shouldDumpEditingCallbacks):
2324         (WebTestRunner::TestRunner::dumpEditingCallbacks):
2325         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2326         (TestRunner):
2327         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2328         (WebTestRunner::WebTestInterfaces::Internal::testRunner):
2329         (WebTestRunner::WebTestInterfaces::Internal::setTestRunner):
2330         (WebTestInterfaces::Internal):
2331         (WebTestRunner::WebTestInterfaces::Internal::Internal):
2332         (WebTestRunner::WebTestInterfaces::testRunner):
2333         (WebTestRunner):
2334         (WebTestRunner::WebTestInterfaces::setTestRunner):
2335         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2336         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
2337         (WebTestRunner):
2338         (WebTestRunner::WebTestProxyBase::shouldBeginEditing):
2339         (WebTestRunner::WebTestProxyBase::shouldEndEditing):
2340         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
2341         (WebTestRunner::WebTestProxyBase::shouldInsertText):
2342         (WebTestRunner::WebTestProxyBase::shouldChangeSelectedRange):
2343         (WebTestRunner::WebTestProxyBase::shouldDeleteRange):
2344         (WebTestRunner::WebTestProxyBase::shouldApplyStyle):
2345         (WebTestRunner::WebTestProxyBase::didBeginEditing):
2346         (WebTestRunner::WebTestProxyBase::didChangeSelection):
2347         (WebTestRunner::WebTestProxyBase::didChangeContents):
2348         (WebTestRunner::WebTestProxyBase::didEndEditing):
2349         * DumpRenderTree/chromium/TestShell.cpp:
2350         (TestShell::initialize):
2351         (TestShell::createNewWindow):
2352         * DumpRenderTree/chromium/WebViewHost.cpp:
2353         (WebViewHost::shouldBeginEditing):
2354         (WebViewHost::shouldEndEditing):
2355         (WebViewHost::shouldInsertNode):
2356         (WebViewHost::shouldInsertText):
2357         (WebViewHost::shouldChangeSelectedRange):
2358         (WebViewHost::shouldDeleteRange):
2359         (WebViewHost::shouldApplyStyle):
2360         * DumpRenderTree/chromium/WebViewHost.h:
2361         (WebViewHost):
2362
2363 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
2364
2365         [chromium] Fix methods in TestRunner that directly modify the settings instead of going through WebPreferences
2366         https://bugs.webkit.org/show_bug.cgi?id=105154
2367
2368         Reviewed by Tony Chang.
2369
2370         If the settings are modified directly, the embedder can't keep track of
2371         them and might accidentially override the changed settings.
2372
2373         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2374         (WebPreferences):
2375         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2376         (WebTestRunner::TestRunner::TestRunner):
2377         (WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled):
2378         (WebTestRunner):
2379         (WebTestRunner::TestRunner::setMinimumTimerInterval):
2380         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
2381         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2382         (TestRunner):
2383         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2384         (WebTestRunner::WebPreferences::reset):
2385         (WebTestRunner::WebPreferences::applyTo):
2386
2387 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
2388
2389         Unreviewed unit test skipping.
2390
2391         Filed https://bugs.webkit.org/show_bug.cgi?id=105253 to re-enable them.
2392
2393         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2394         (TestWebKitAPI):
2395         (TestWebKitAPI::TEST):
2396
2397 2012-12-17  Dean Jackson  <dino@apple.com>
2398
2399         Unreviewed. Add Silvia Pfeiffer to contributor list.
2400
2401         * Scripts/webkitpy/common/config/committers.py:
2402
2403 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
2404
2405         build.webkit.org - add more google windows bots
2406         https://bugs.webkit.org/show_bug.cgi?id=105225
2407
2408         Reviewed by Eric Seidel.
2409
2410         Adds two more windows bots (google-windows-3, a builder, and
2411         google-windows-4, a tester) for the Chromium configs.
2412
2413         * BuildSlaveSupport/build.webkit.org-config/config.json:
2414
2415 2012-12-17  Eric Seidel  <eric@webkit.org>
2416
2417         Cleanup --profiler=perf code a little and allow up to 1000 report files (instead of 100)
2418         https://bugs.webkit.org/show_bug.cgi?id=105217
2419
2420         Reviewed by Dirk Pranke.
2421
2422         Previously --profile would fail strangely if find_unused_filename returned None
2423         (which would happen as soon as we had 100 report files).
2424         Now we'll search through 1000 filenames before giving up (and assert if we failed to find one).
2425         I also made some minor cleanups to the output of perf, and tried to make the
2426         commands more self-documenting by using long-names for args.
2427
2428         * Scripts/webkitpy/common/system/profiler.py:
2429         (SingleFileOutputProfiler.__init__):
2430         (Perf.attach_to_pid):
2431         (Perf.profile_after_exit):
2432
2433 2012-12-17  Sheriff Bot  <webkit.review.bot@gmail.com>
2434
2435         Unreviewed, rolling out r137198.
2436         http://trac.webkit.org/changeset/137198
2437         https://bugs.webkit.org/show_bug.cgi?id=105212
2438
2439         This patch is causing API behavior compatibility problems
2440         (Requested by zdobersek on #webkit).
2441
2442         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2443         (willSendRequestCallback):
2444
2445 2012-12-17  Elliott Sprehn  <esprehn@chromium.org>
2446
2447         Unreviewed. Adding myself to committers list.
2448
2449         * Scripts/webkitpy/common/config/committers.py:
2450
2451 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
2452
2453         nrwt: shuffle code around for cleanup in run_webkit_tests.py
2454         https://bugs.webkit.org/show_bug.cgi?id=105078
2455
2456         Reviewed by Ojan Vafai.
2457
2458         This patch reorders functions so that run_webkit_tests can be
2459         understood in a top-down matter better, and to make things slightly
2460         more sensible when I merge manager.py into it.
2461
2462         Also, this adds tests for the actual main() routine, which had several
2463         bugs get through testing a week or two ago.
2464
2465         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2466         (main):
2467         (parse_args):
2468         (_set_up_derived_options):
2469         (run):
2470         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2471         (RunTest):
2472         (RunTest.test_no_http_tests):
2473         (PortTest.disabled_test_mac_lion):
2474         (MainTest):
2475         (MainTest.test_exception_handling):
2476         (MainTest.test_exception_handling.interrupting_run):
2477         (MainTest.test_exception_handling.successful_run):
2478         (MainTest.test_exception_handling.successful_run.FakeRunDetails):
2479         (MainTest.test_exception_handling.exception_raising_run):
2480
2481 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
2482
2483         webkitpy: move --lint-test-files code into its own module
2484         https://bugs.webkit.org/show_bug.cgi?id=105077
2485
2486         Reviewed by Eric Seidel.
2487
2488         It really didn't need to be in run_webkit_tests.py anymore.
2489         This patch adds a new lint-test-expectations scripts to Tools/Scripts;
2490         rwt --lint-test-files is still supported for backwards compatibility
2491         for now.
2492
2493         * Scripts/lint-test-expectations: Added.
2494         * Scripts/webkitpy/layout_tests/lint_test_expectations.py: Added.
2495         (lint):
2496         (main):
2497         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py: Added.
2498         (FakePort):
2499         (FakePort.__init__):
2500         (FakePort.test_configuration):
2501         (FakePort.expectations_dict):
2502         (FakePort.skipped_layout_tests):
2503         (FakePort.all_test_configurations):
2504         (FakePort.configuration_specifier_macros):
2505         (FakePort.get_option):
2506         (FakeFactory):
2507         (FakeFactory.__init__):
2508         (FakeFactory.get):
2509         (FakeFactory.all_port_names):
2510         (LintTest):
2511         (LintTest.test_all_configurations):
2512         (LintTest.test_lint_test_files):
2513         (LintTest.test_lint_test_files__errors):
2514         (MainTest):
2515         (MainTest.test_success):
2516         (MainTest.test_success.interrupting_lint):
2517         (MainTest.test_success.successful_lint):
2518         (MainTest.test_success.exception_raising_lint):
2519         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2520         (main):
2521         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2522         (StreamTestingMixin.assertNotEmpty):
2523
2524 2012-12-17  Adam Klein  <adamk@chromium.org>
2525
2526         build-webkit: rename --template-tag to --template-element to match ENABLE #define name
2527         https://bugs.webkit.org/show_bug.cgi?id=105072
2528
2529         Reviewed by Laszlo Gombos.
2530
2531         * Scripts/webkitperl/FeatureList.pm:
2532
2533 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
2534
2535         Add some unit testing for WTF::clampTo* functions
2536         https://bugs.webkit.org/show_bug.cgi?id=105060
2537
2538         Reviewed by Emil A Eklund.
2539
2540         The new tests are targeted at clamping to int / unsigned and float as those are
2541         the one explicitely exposed through more dedicated functions (like clampToInteger,
2542         clampToPositiveInteger and clampToFloat).
2543
2544         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2545
2546 2012-12-17  Eric Seidel  <eric@webkit.org>
2547
2548         rpt --profile --chromium-android throws exception
2549         https://bugs.webkit.org/show_bug.cgi?id=105061
2550
2551         Reviewed by Daniel Bates.
2552
2553         Somehow popen(args) got turned into popen(*args) at some point,
2554         which caused my new stringify code to fail when args was passed by name.
2555         Fixed and tested.
2556
2557         * Scripts/webkitpy/common/system/executive.py:
2558         (Executive._stringify_args):
2559         (Executive):
2560         (Executive.popen):
2561         * Scripts/webkitpy/common/system/executive_unittest.py:
2562         (ExecutiveTest.test_popen_args):
2563
2564 2012-12-17  Mark Pilgrim  <pilgrim@chromium.org>
2565
2566         Use Platform::current() instead of webKitPlatformSupport() in DumpRenderTree
2567         https://bugs.webkit.org/show_bug.cgi?id=105054
2568
2569         Reviewed by Jochen Eisinger.
2570
2571         Part of a refactoring series; see tracking bug 82948.
2572
2573         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2574         (NotificationPresenter::show):
2575         * DumpRenderTree/chromium/Task.cpp:
2576         (postTask):
2577         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
2578
2579 2012-12-17  Emil A Eklund  <eae@chromium.org>
2580
2581         Clamp values in LayoutUnit::operator/ when SATURATED_LAYOUT_ARITHMETIC is enabled
2582         https://bugs.webkit.org/show_bug.cgi?id=104955
2583
2584         Reviewed by Julien Chaffraix.
2585
2586         Add tests for LayoutUnit.
2587
2588         * TestWebKitAPI/CMakeLists.txt:
2589         * TestWebKitAPI/ForwardingHeaders: Added.
2590         * TestWebKitAPI/ForwardingHeaders/WebCore: Added.
2591         * TestWebKitAPI/ForwardingHeaders/WebCore/LayoutUnit.h: Added.
2592         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2593         * TestWebKitAPI/TestWebKitAPI.gypi:
2594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2595         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Added.
2596         (TestWebKitAPI):
2597         (TestWebKitAPI::TEST):
2598         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2599
2600 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
2601
2602         [chromium] removed unused preferences from testRunner.overridePreference
2603         https://bugs.webkit.org/show_bug.cgi?id=105169
2604
2605         Reviewed by Tony Chang.
2606
2607         Most notably this removes the code related to font family maps which is
2608         now handled via window.internals.settings
2609
2610         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2611         (WebPreferences):
2612         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2613         (WebTestRunner::TestRunner::overridePreference):
2614         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2615         (TestRunner):
2616         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2617         (WebTestRunner::WebPreferences::applyTo):
2618
2619 2012-12-17  James Robinson  <jamesr@chromium.org>
2620
2621         [chromium] Move creation of WebLayerTreeView to WebWidgetClient
2622         https://bugs.webkit.org/show_bug.cgi?id=105071
2623
2624         Reviewed by Adrienne Walker.
2625
2626         Update WebViewHost for the new WebWidgetClient interface.
2627
2628         * DumpRenderTree/chromium/WebViewHost.cpp:
2629         (WebViewHost::initializeLayerTreeView):
2630         (WebViewHost::layerTreeView):
2631         (WebViewHost::~WebViewHost):
2632         * DumpRenderTree/chromium/WebViewHost.h:
2633         (WebViewHost):
2634
2635 2012-12-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2636
2637         [EFL][WK2] window_create doesn't receive the url
2638         https://bugs.webkit.org/show_bug.cgi?id=105184
2639
2640         Reviewed by Alexis Menard.
2641
2642         * MiniBrowser/efl/main.c: Use the url supplied to window_create
2643         (on_window_create):
2644
2645 2012-12-17  Ilya Tikhonovsky  <loislo@chromium.org>
2646
2647         Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
2648         https://bugs.webkit.org/show_bug.cgi?id=105026
2649
2650         Reviewed by Yury Semikhatsky.
2651
2652         Old SFINAE test was replaced with new one based on this article:
2653         http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
2654
2655         New test which covers this problem was added.
2656
2657         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2658
2659 2012-12-17  Anthony Scian  <ascian@rim.com>
2660
2661         [Blackberry] Static code analysis warning fixes
2662         https://bugs.webkit.org/show_bug.cgi?id=105129
2663
2664         Reviewed by Rob Buis.
2665
2666         Added null checks for fopen calls, no recovery attempted; access fault prevention only.
2667
2668         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2669         (BlackBerry::WebKit::createFile):
2670         (BlackBerry::WebKit::DumpRenderTree::runTest):
2671
2672 2012-12-17  John Mellor  <johnme@chromium.org>
2673
2674         Add Anton Vayvod and Tim Volodine as contributors in committers.py
2675         https://bugs.webkit.org/show_bug.cgi?id=105025
2676
2677         Unreviewed. Adds two contributors to committers.py.
2678         They are initially contributing to the Text Autosizing feature (master bug: 84186).
2679
2680         * Scripts/webkitpy/common/config/committers.py:
2681
2682 2012-12-17  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2683
2684         Unreviewed, add myself to committers.py.
2685
2686         * Scripts/webkitpy/common/config/committers.py:
2687
2688 2012-12-17  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
2689
2690         [Qt] remove some unnecessary CONFIG additions
2691
2692         Reviewed by Simon Hausmann.
2693
2694         qt is already added by spec_pre.prf, warn_on and depend_includepath by
2695         default_pre.prf.
2696
2697         * qmake/mkspecs/features/default_post.prf:
2698
2699 2012-12-17  Ilya Tikhonovsky  <loislo@chromium.org>
2700
2701         Unreviewed, rolling out r137892.
2702         http://trac.webkit.org/changeset/137892
2703         https://bugs.webkit.org/show_bug.cgi?id=105026
2704
2705         it broke compilation on windows
2706
2707         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2708
2709 2012-12-14  Ilya Tikhonovsky  <loislo@chromium.org>
2710
2711         Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
2712         https://bugs.webkit.org/show_bug.cgi?id=105026
2713
2714         Reviewed by Yury Semikhatsky.
2715
2716         Old SFINAE test was replaced with new one based on this article:
2717         http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
2718
2719         New test which covers this problem was added.
2720
2721         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2722
2723 2012-12-17  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
2724
2725         [Qt] rely on automatic output directory setup
2726
2727         Reviewed by Simon Hausmann.
2728
2729         Now being a proper qt module (by virtue of having load(qt_build_config)
2730         in .qmake.conf), webkit gets the path setup goodies for free.
2731
2732         This also fixes Makefile.api.Debug/Release trying to generate qrc_WebKit.cpp
2733         at the same time, instead of the debug and release version ending up in different
2734         directories as they should.
2735
2736         * qmake/mkspecs/features/default_pre.prf:
2737
2738 2012-12-17  Charles Wei  <charles.wei@torchmobile.com.cn>
2739
2740         [BlackBerry] Need to re-enable video track
2741         https://bugs.webkit.org/show_bug.cgi?id=105155
2742
2743         Reviewed by George Staikos.
2744
2745         Just enable Video Track for BlackBerry.
2746
2747         * Scripts/webkitperl/FeatureList.pm:
2748
2749 2012-12-17  János Badics  <jbadics@inf.u-szeged.hu>
2750
2751         Unreviewed. Added myself to committers.py
2752
2753         * Scripts/webkitpy/common/config/committers.py:
2754
2755 2012-12-17  Jonathan Liu  <net147@gmail.com>
2756
2757         Fix linking of libraries with -Wl,-whole-archive
2758         https://bugs.webkit.org/show_bug.cgi?id=104436
2759
2760         Reviewed by Simon Hausmann.
2761
2762         If there is more than one library in LIBS linked with
2763         -Wl,-whole-archive -l... -Wl,-no-whole-archive, qmake tries to
2764         merge the duplicate flags in LIBS which causes linking to fail.
2765
2766         Add no_smart_library_merge to CONFIG to prevent the duplicate
2767         flags from being removed when using -Wl,-whole-archive.
2768
2769         * qmake/mkspecs/features/functions.prf:
2770
2771 2012-12-16  Arvid Nilsson  <anilsson@rim.com>
2772
2773         [BlackBerry] Adapt to new BlackBerry::Platform::TouchPoint API
2774         https://bugs.webkit.org/show_bug.cgi?id=105143
2775         RIM PR 171941
2776
2777         Reviewed by Rob Buis.
2778         Internally reviewed by George Staikos.
2779
2780         Adapt to new method names and encapsulation of TouchPoint data members.
2781
2782         * DumpRenderTree/blackberry/EventSender.cpp:
2783         (addTouchPointCallback):
2784         (updateTouchPointCallback):
2785         (touchEndCallback):
2786         (releaseTouchPointCallback):
2787         (sendTouchEvent):
2788
2789 2012-12-16  Maciej Stachowiak  <mjs@apple.com>
2790
2791         Add a script to compute the mean and 95% confidence interval (using two-sided t-test) of a sample set
2792         https://bugs.webkit.org/show_bug.cgi?id=105148
2793
2794         Reviewed by Filip Pizlo.
2795
2796         Usage examples:
2797         
2798         $ sampstat --help
2799         Usage: sampstat [options] [FILES]
2800           Compute the mean and 95% confidence interval of a sample set.
2801           Standard input or files must contain two or more decimal numbers, one per line.
2802         
2803         Options:
2804           -h, --help            show this help message and exit
2805           -u UNIT, --unit=UNIT  assume values are in units of UNIT
2806           -v, --verbose         print all values (with units)
2807         
2808         $ sampstat -u MB memresults.txt
2809         2356.90 MB +/- 101.34 MB (4.3%)
2810         
2811         $ sampstat -v -u MB memresults.txt
2812               2318.21 MB
2813               2399.56 MB
2814               2352.93 MB
2815         ----------------
2816         Mean: 2356.90 MB +/- 101.34 MB (4.3%)
2817         
2818
2819         * Scripts/sampstat: Added.
2820         (sum): Helper function to compute the sum of a list.
2821         (arithmeticMean): Compute the meam of a list.
2822         (standardDeviation): Compute the sample standard deviation (unbiased estimator).
2823         (standardError): Compute the sample standard error.
2824         (tDist): Compute t(.025, n-1), the t-value for atwo-sided 95% confidence interval. 
2825         (twoSidedConfidenceInterval): Compute the two-sided confidence interval range about the mean.
2826
2827 2012-12-15  Nima Ghanavatian  <nghanavatian@rim.com>
2828
2829         [BlackBerry] Pass key modifiers with touch and mouse events
2830         https://bugs.webkit.org/show_bug.cgi?id=105108
2831
2832         Reviewed by Rob Buis.
2833
2834         Update DRT to new api.
2835
2836         Internally reviewed by Gen Mak.
2837
2838         * DumpRenderTree/blackberry/EventSender.cpp:
2839         (mouseDownCallback):
2840         (mouseUpCallback):
2841         (mouseMoveToCallback):
2842
2843 2012-12-15  Zan Dobersek  <zandobersek@gmail.com>
2844
2845         Stop the XvfbDriver before proceeding with its starting setup
2846         https://bugs.webkit.org/show_bug.cgi?id=105006
2847
2848         Reviewed by Philippe Normand.
2849
2850         Just as with the base Driver implementation, stop the XvfbDriver
2851         before proceeding with setting up lock files and a new Xvfb instance.
2852         This forces any driver or Xvfb instances that are currently under
2853         the driver's control to be closed/killed and cleaned up after.
2854
2855         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2856         (XvfbDriver._start):
2857
2858 2012-12-14  Dirk Pranke  <dpranke@chromium.org>
2859
2860         webkitpy: make port_name a required parameter to the non-test ports
2861         https://bugs.webkit.org/show_bug.cgi?id=105057
2862
2863         Reviewed by Eric Seidel.
2864
2865         This is just minor code cleanup along the path to making Port
2866         constructors simpler and pushing more logic into the port factory.
2867
2868         * Scripts/webkitpy/layout_tests/port/base.py:
2869         (Port.__init__):
2870         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2871         (PortTest.make_port):
2872         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2873         (TestWebKitPort.__init__):
2874         * Scripts/webkitpy/layout_tests/port/test.py:
2875         (TestPort):
2876         (TestPort.determine_full_port_name):
2877         (TestPort.__init__):
2878         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
2879         (XvfbDriverTest.make_driver):
2880         (XvfbDriverTest.test_stop):
2881
2882 2012-12-14  Dirk Pranke  <dpranke@chromium.org>
2883
2884         garden-o-matic doesn't know about reftests
2885         https://bugs.webkit.org/show_bug.cgi?id=101976
2886
2887         Reviewed by Eric Seidel.
2888
2889         Attempt to make garden-o-matic properly aware of reftests again.
2890
2891         This is re-landing r137407 with a change to
2892         rebaselineWithStatusUpdates() to actually pass the filtered
2893         failureInofLost to checkout.rebaseline().
2894
2895         Unfortunately, the testing coverage for this whole module is almost
2896         non-existent, and it's not obvious that there's a good way to
2897         stub out checkout.rebaseline() to test that the right thing
2898         happens. I verified the change manually.
2899
2900         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2901         (.):
2902         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2903         (.):
2904         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
2905
2906 2012-12-14  Ryosuke Niwa  <rniwa@webkit.org>
2907
2908         "Running 1 DumpRenderTree over X shards" is not a helpful output
2909         https://bugs.webkit.org/show_bug.cgi?id=104858
2910
2911         Reviewed by Dirk Pranke.
2912
2913         The word "shard" is not typically used in test frameworks. This word is confusing for many WebKit
2914         contributors who typically don't have much experience on distributed computations and databases.
2915         So only print this message out in the debug mode.
2916
2917         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2918         * Scripts/webkitpy/layout_tests/views/printing.py:
2919         (Printer.print_workers_and_shards):
2920
2921 2012-12-13  Eric Seidel  <eric@webkit.org>
2922
2923         Add --profiler=PROFILER option to run-perf-tests to allow specifying which profiler to use on platforms with many
2924         https://bugs.webkit.org/show_bug.cgi?id=104891
2925
2926         Reviewed by Ryosuke Niwa.
2927
2928         I also implemented a very simple "Sample" Profiler using
2929         Mac OS X's /usr/bin/sample command line tool.
2930
2931         The real reason for this abstraction is to make it easy
2932         to support both perf and pprof on linux which seem to
2933         be about equally popular among those I ask in the Chrome team.
2934
2935         * Scripts/webkitpy/common/system/profiler.py:
2936         (ProfilerFactory.create_profiler):
2937         (ProfilerFactory):
2938         (ProfilerFactory.available_profilers_by_name):
2939         (ProfilerFactory.default_profiler_name):
2940         (Sample):
2941         (Sample.__init__):
2942         (Sample.attach_to_pid):
2943         (Sample.profile_after_exit):
2944         (IProfiler.attach_to_pid):
2945         * Scripts/webkitpy/layout_tests/port/driver.py:
2946         (Driver.__init__):
2947         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2948         (PerfTestsRunner._parse_args):
2949
2950 2012-12-13  Eric Seidel  <eric@webkit.org>
2951
2952         Unreviewed, fixing typo in python unittest.
2953
2954         I changed the default profiler on linux from pprof to perf in
2955         bug 104971.  I failed to update the unittest results at that time.
2956
2957         * Scripts/webkitpy/common/system/profiler_unittest.py:
2958         (ProfilerFactoryTest.test_basic):
2959
2960 2012-12-13  Ian Vollick  <vollick@chromium.org>
2961
2962         [chromium] Add a virtual test suite for enabling opt-in to composited scrolling
2963         https://bugs.webkit.org/show_bug.cgi?id=104911
2964
2965         Reviewed by Dirk Pranke.
2966
2967         Adds two virtual tests suites to run the tests in
2968         compositing/overflow/ and scrollbars/ with the flag
2969         --enable-accelerated-overflow-scroll, which I've also plumbed through
2970         in the usual way.
2971
2972         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2973         (main):
2974         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2975         (WebPreferences):
2976         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2977         (WebTestRunner::WebPreferences::reset):
2978         (WebTestRunner::WebPreferences::applyTo):
2979         * DumpRenderTree/chromium/TestShell.cpp:
2980         (TestShell::TestShell):
2981         (TestShell::resetWebSettings):
2982         * DumpRenderTree/chromium/TestShell.h:
2983         (TestShell::setAcceleratedCompositingForOverflowScrollEnabled):
2984         (TestShell):
2985         * Scripts/webkitpy/layout_tests/port/chromium.py:
2986         (ChromiumPort.virtual_test_suites):
2987
2988 2012-12-13  Eric Seidel  <eric@webkit.org>
2989
2990         Use 'perf' to profile on linux instead of google-pprof by default
2991         https://bugs.webkit.org/show_bug.cgi?id=104971
2992
2993         Reviewed by Dirk Pranke.
2994
2995         This makes Chromium Linux match Chromium Android and use the perf
2996         tool by default.  Once https://bugs.webkit.org/show_bug.cgi?id=104891
2997         lands it will be possible to use pprof again on Linux.
2998
2999         This is slightly more advanced than the AndroidPerf profiler as
3000         instead of using a timeout on "perf record" I instead watch
3001         for the termination of the target process and then control-C
3002         the 'perf record' process.  This required me to add two new
3003         methods to Executive, one to have a limited-time wait() and
3004         the second to be able to send a control-C.  I chose to add
3005         these to Executive to make them easier to mock/fix-for-win32
3006         at a later time if needed.
3007
3008         * Scripts/webkitpy/common/system/executive.py:
3009         (Executive.wait_limited):
3010         (Executive.interrupt):
3011         * Scripts/webkitpy/common/system/profiler.py:
3012         (ProfilerFactory.create_profiler):
3013         (Perf):
3014         (Perf.__init__):
3015         (Perf._perf_path):
3016         (Perf.attach_to_pid):
3017         (Perf._first_ten_lines_of_profile):
3018         (Perf.profile_after_exit):
3019
3020 2012-12-13  Julie Parent  <jparent@chromium.org>
3021
3022         Dashboard cleanup: remove usage of global g_builders.
3023         https://bugs.webkit.org/show_bug.cgi?id=104941
3024
3025         Reviewed by Dirk Pranke.
3026
3027         The dashboards use a lot of global state, which makes hacking on them
3028         complicated. This change removes the use of one such global: g_builders.
3029         In most cases, we can just use currentBuilderGroup().builders instead,
3030         which is now currentBuilders().
3031         Surprisingly, the most changes were required to the unit tests, since
3032         they were even bigger offenders of bad hygiene, relying on global state
3033         set by other tests, randomly clobbering global variables in ways the
3034         real code doesn't, etc.
3035
3036         * TestResultServer/static-dashboards/builders.js:
3037         (BuilderGroup.prototype.setup):
3038         * TestResultServer/static-dashboards/dashboard_base.js:
3039         (.switch.return):
3040         (htmlForTestTypeSwitcher):
3041         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3042         (generatePage):
3043         (getAllTestsTrie):
3044         (processTestRunsForAllBuilders):
3045         (showPopupForBuild):
3046         (generatePageForExpectationsUpdate):
3047         (loadExpectationsLayoutTests):
3048         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3049         (resetGlobals):
3050         (stubResultsByBuilder):
3051         (test):
3052         * TestResultServer/static-dashboards/loader.js:
3053         (.):
3054         * TestResultServer/static-dashboards/loader_unittests.js:
3055
3056 2012-12-13  Eric Seidel  <eric@webkit.org>
3057
3058         Callers should not have to stringify args before calling Executive run_command/popen
3059         https://bugs.webkit.org/show_bug.cgi?id=104975
3060
3061         Reviewed by Dirk Pranke.
3062
3063         One could argue that we should match the python call syntax here,
3064         but I think it's a more friendly API if we automagically handle
3065         stringification of args in run_command, etc.
3066         This removes map(unicode, args) from several callsites.
3067
3068         When I first tried to land this change, I didn't realize that
3069         Executive._command_for_printing depended on this behavior
3070         having been applied to args in run_command.  The fix is to
3071         call _stringify_args in both run_command and popen.
3072         This is slightly redundant, but given how short args have to be
3073         (due to shell limits), I don't think the double-encode check
3074         matters in practice.
3075
3076         This is slightly complicated by the fact that apache_http_server.py
3077         is the one caller in our codebase which uses shell=True.
3078         shell=True is a well-documented trail-of-tears:
3079         http://stackoverflow.com/questions/3172470/actual-meaning-of-shell-true-in-subprocess
3080         but to support this legacy (windows-only) code (which I can't easily test)
3081         I've added an if-hack to avoid stringifying the the popen(shell=True) case.
3082
3083         * Scripts/webkitpy/common/system/executive.py:
3084         (Executive.run_command):
3085         (Executive._stringify_args):
3086         (Executive.popen):
3087         * Scripts/webkitpy/common/system/executive_unittest.py:
3088         (ExecutiveTest.test_auto_stringify_args):
3089         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3090         (attach_to_pid):
3091
3092 2012-12-13  Adrienne Walker  <enne@chromium.org>
3093
3094         Unreviewed, rolling out r137645, r137646, and r137667.
3095         http://trac.webkit.org/changeset/137645
3096         http://trac.webkit.org/changeset/137646
3097         http://trac.webkit.org/changeset/137667
3098         https://bugs.webkit.org/show_bug.cgi?id=104911
3099
3100         Breaks some overflow layout tests
3101
3102         * Scripts/webkitpy/layout_tests/port/chromium.py:
3103         (ChromiumPort.virtual_test_suites):
3104
3105 2012-12-13  Dirk Pranke  <dpranke@chromium.org>
3106
3107         Unreviewed, rolling out r137661.
3108         http://trac.webkit.org/changeset/137661
3109         https://bugs.webkit.org/show_bug.cgi?id=104891
3110
3111         broke unit tests, run-webkit-tests
3112
3113         * Scripts/webkitpy/common/system/executive.py:
3114         (Executive._run_command_with_teed_output):
3115         (Executive.run_command):
3116         (Executive.popen):
3117         * Scripts/webkitpy/common/system/profiler.py:
3118         (ProfilerFactory.create_profiler):
3119         (GooglePProf.profile_after_exit):
3120         (IProfiler.attach_to_pid):
3121         * Scripts/webkitpy/layout_tests/port/driver.py:
3122         (Driver.__init__):
3123         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3124         (PerfTestsRunner._parse_args):
3125
3126 2012-12-13  Dirk Pranke  <dpranke@chromium.org>
3127
3128         nrwt: move rundetails, summarize_results into test_run_results
3129         https://bugs.webkit.org/show_bug.cgi?id=104963
3130
3131         Reviewed by Eric Seidel.
3132
3133         More cleanup; this the plain-old-data functions out of manager.py
3134         and into test_run_results next to the other aggregate data structures.
3135
3136         Also this cleans up a bunch of test code and reduces duplication.
3137
3138         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3139         (Manager.run):
3140         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3141         (ManagerTest.test_look_for_new_crash_logs):
3142         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3143         (TestRunResults.__init__):
3144         (TestRunResults.add):
3145         (RunDetails):
3146         (RunDetails.__init__):
3147         (_interpret_test_failures):
3148         (summarize_results):
3149         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: Added.
3150         (get_result):
3151         (run_results):
3152         (summarized_results):
3153         (InterpretTestFailuresTest):
3154         (InterpretTestFailuresTest.setUp):
3155         (InterpretTestFailuresTest.test_interpret_test_failures):
3156         (SummarizedResultsTest):
3157         (SummarizedResultsTest.setUp):
3158         (SummarizedResultsTest.test_no_svn_revision):
3159         (SummarizedResultsTest.test_svn_revision):
3160         (SummarizedResultsTest.test_summarized_results_wontfix):
3161         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
3162         (BuildBotPrinterTests.get_printer):
3163         (BuildBotPrinterTests.test_print_unexpected_results):
3164         (BuildBotPrinterTests.test_print_results):
3165
3166 2012-12-13  Eric Seidel  <eric@webkit.org>
3167
3168         Make --profile output easier to understand for pprof on linux
3169         https://bugs.webkit.org/show_bug.cgi?id=104957
3170
3171         Reviewed by Dirk Pranke.
3172
3173         pprof is kinda mysterious, so we print some information
3174         on how to use it, and how to learn how to read the sample dump.
3175         This is similar to what we've done for perf output for Chromium Android.
3176
3177         * Scripts/webkitpy/common/system/profiler.py:
3178         (GooglePProf._pprof_path):
3179         (GooglePProf.profile_after_exit):
3180
3181 2012-12-13  Dirk Pranke  <dpranke@chromium.org>
3182
3183         Revert r137407 - it didn't actually work right.
3184         https://bugs.webkit.org/show_bug.cgi?id=101976
3185
3186         Unreviewed, build fix.
3187
3188         Turns out that rebaselining was completely broken with this change :(
3189         We're passing in a list of test names rather than the list of
3190         failureInfo objects.
3191
3192         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3193         (.):
3194         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3195         (.):
3196         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3197
3198 2012-12-13  Antoine Labour  <piman@chromium.org>
3199
3200         [chromium] Small fixes for WebPluginContainer::setWebLayer
3201         https://bugs.webkit.org/show_bug.cgi?id=104953
3202
3203         Reviewed by James Robinson.
3204
3205         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Clean up
3206         dangling pointers, force correct invalidation of the layer.
3207
3208 2012-12-13  Eric Seidel  <eric@webkit.org>
3209
3210         Add --profiler=PROFILER option to run-perf-tests to allow specifying which profiler to use on platforms with many
3211         https://bugs.webkit.org/show_bug.cgi?id=104891
3212
3213         Reviewed by Dirk Pranke.
3214
3215         I also implemented a very simple "Sample" Profiler using
3216         Mac OS X's /usr/bin/sample command line tool.
3217
3218         I also moved the map(unicode, args) call into Executive.popen
3219         so that all callers don't have to do it themselves.
3220
3221         The real reason for this abstraction is to make it easy
3222         to support both perf and pprof on linux which seem to
3223         be about equally popular among those I ask in the Chrome team.
3224
3225         * Scripts/webkitpy/common/system/executive.py:
3226         (Executive.popen):
3227         * Scripts/webkitpy/common/system/profiler.py:
3228         (ProfilerFactory.create_profiler):
3229         (ProfilerFactory):
3230         (ProfilerFactory.available_profilers_by_name):
3231         (ProfilerFactory.default_profiler_name):
3232         (Sample):
3233         (Sample.__init__):
3234         (Sample.attach_to_pid):
3235         (Sample.profile_after_exit):
3236         (IProfiler.attach_to_pid):
3237         * Scripts/webkitpy/layout_tests/port/driver.py:
3238         (Driver.__init__):
3239         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3240         (PerfTestsRunner._parse_args):
3241
3242 2012-12-13  Dirk Pranke  <dpranke@chromium.org>
3243
3244         support -wk2 port names properly in webkitpy.layout_tests.port
3245         https://bugs.webkit.org/show_bug.cgi?id=104761
3246
3247         Reviewed by Eric Seidel.
3248
3249         Our support for WK2 port names was inconsistent at best; this patch
3250         modifies the code so that <port_name>-wk2 is supported for all ports that
3251         have WK2 implementations and is equivalent to specifying <port_name>
3252         and -2/--webkit-test-runner. In addition, this modifies
3253         builders.all_port_names() to include the wk2 variants.
3254
3255         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3256         * Scripts/webkitpy/layout_tests/port/apple.py:
3257         (ApplePort.determine_full_port_name):
3258         * Scripts/webkitpy/layout_tests/port/base.py:
3259         (Port.determine_full_port_name):
3260         (Port.__init__):
3261         * Scripts/webkitpy/layout_tests/port/builders.py:
3262         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3263         (DriverTest.make_port):
3264         * Scripts/webkitpy/layout_tests/port/mac.py:
3265         (MacPort.default_baseline_search_path):
3266         * Scripts/webkitpy/layout_tests/port/win.py:
3267         (WinPort.default_baseline_search_path):
3268         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3269         (TestRebaselineExpectations.test_rebaseline_expectations):
3270
3271 2012-12-13  Ian Vollick  <vollick@chromium.org>
3272
3273         [chromium] Add a virtual test suite for enabling opt-in to composited scrolling
3274         https://bugs.webkit.org/show_bug.cgi?id=104911
3275
3276         Reviewed by Adrienne Walker.
3277
3278         Adds two virtual tests suites to run the tests in
3279         compositing/overflow/ and scrollbars/ with the flag
3280         --enable-accelerated-compositing-for-overflow-scroll
3281
3282         * Scripts/webkitpy/layout_tests/port/chromium.py:
3283         (ChromiumPort.virtual_test_suites):
3284
3285 2012-12-13  Dirk Pranke  <dpranke@chromium.org>
3286
3287         delete extraneous self.fail in mastercfg_unittest.py
3288         https://bugs.webkit.org/show_bug.cgi?id=104940
3289
3290         Reviewed by Eric Seidel.
3291
3292         This was accidentally introduced in r137404.
3293
3294         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3295
3296 2012-12-13  Dirk Pranke  <dpranke@chromium.org>
3297
3298         Fix a mis-named variable after r137621.
3299         https://bugs.webkit.org/show_bug.cgi?id=104871
3300
3301         Unreviewed, build fix.
3302
3303         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
3304         (BuildBotPrinter.print_results):
3305         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
3306
3307 2012-12-13  Dirk Pranke  <dpranke@chromium.org>
3308
3309         webkitpy: rename ResultSummary
3310         https://bugs.webkit.org/show_bug.cgi?id=104871
3311
3312         Reviewed by Eric Seidel.
3313
3314         This patch changes the names of ResultSummary and related modules,
3315         classes, and variables as a part of the larger clean up in bug 103824.
3316
3317         This change is basically a bunch of search and replaces:
3318         - result_summary.py -> test_run_results.py
3319         - class ResultSummary -> class TestRunResults
3320         - "result_summary" or "rs" as a generic variable name -> "run_results",
3321           when it doesn't matter (or we don't know) if this refers to the
3322           initial pass over the tests or the retry pass.
3323         - "result_summary" as a variable containing the results of the initial,
3324           complete test run -> "initial_results"
3325         - "retry_summary" as a variable containing the results of retried
3326           results -> "retry_results"
3327         - ResultSummary.results (the property) -> TestRunResults.results_by_name
3328         - ResultSummary.failures (the property) -> TestRunResults.failures_by_name
3329         - RunDetails.result_summary -> RunDetails.initial_results
3330         - RunDetails.retry_summary -> RunDetails.retry_results
3331
3332         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3333         (LayoutTestRunner.__init__):
3334         (LayoutTestRunner.run_tests):
3335         (LayoutTestRunner._mark_interrupted_tests_as_skipped):
3336         (LayoutTestRunner._interrupt_if_at_failure_limits):
3337         (LayoutTestRunner._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
3338         (LayoutTestRunner._update_summary_with_result):
3339         (LayoutTestRunner._handle_finished_test):
3340         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3341         (FakePrinter.print_expected):
3342         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
3343         (LayoutTestRunnerTests.test_update_summary_with_result):
3344         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3345         (RunDetails.__init__):
3346         (summarize_results):
3347         (Manager.run):
3348         (Manager._look_for_new_crash_logs):
3349         (Manager._tests_to_retry):
3350         (Manager._upload_json_files):
3351         (Manager._stats_trie):
3352         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3353         (ManagerTest.test_look_for_new_crash_logs):
3354         (SummarizeResultsTest):
3355         (SummarizeResultsTest.get_run_results):
3356         (SummarizeResultsTest.summarized_results):
3357         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3358         (JSONLayoutResultsGenerator.__init__):
3359         (JSONLayoutResultsGenerator._get_modifier_char):
3360         (JSONLayoutResultsGenerator._insert_failure_summaries):
3361         (JSONLayoutResultsGenerator._get_failure_summary_entry):
3362         * Scripts/webkitpy/layout_tests/models/test_run_results.py: Renamed from Tools/Scripts/webkitpy/layout_tests/models/result_summary.py.
3363         (TestRunResults):
3364         (TestRunResults.__init__):
3365         (TestRunResults.add):
3366         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3367         (get_test_results):
3368         (MainTest.test_basic):
3369         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
3370         (BuildBotPrinter.print_results):
3371         (BuildBotPrinter.print_run_results):
3372         (BuildBotPrinter._print_run_results_entry):
3373         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
3374         (BuildBotPrinterTests.get_run_results):
3375         (BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
3376         (BuildBotPrinterTests):
3377         * Scripts/webkitpy/layout_tests/views/printing.py:
3378         (Printer.print_expected):
3379         (Printer._print_expected_results_of_type):
3380         (Printer.print_results):
3381         (Printer._print_timing_statistics):
3382         (Printer._print_worker_statistics):
3383         (Printer._print_aggregate_test_statistics):
3384         (Printer._print_individual_test_times):
3385         (Printer._print_directory_timings):
3386         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3387
3388 2012-12-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3389
3390         [EFL] The WebKit2 bots are building and executing WebKit1 tests
3391         https://bugs.webkit.org/show_bug.cgi?id=104690
3392
3393         Reviewed by Csaba Osztrogonác.
3394
3395         Pass --no-webkit1 option to the EFL WK2 bots when building. This
3396         will disable WK1 API and thus, the WK1 API tests.
3397
3398         * BuildSlaveSupport/build.webkit.org-config/config.json:
3399         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3400         (CompileWebKit2Only):
3401         (BuildAndTestFactory):
3402         (BuildAndTestFactory.__init__):
3403         (BuildAndTestWebKit2OnlyFactory):
3404         Now bots using BuildAndTestWebKit2OnlyFactory (for instance only EFL) will
3405         get --no-webkit1 as a parameter on the build-webkit script.
3406         * Scripts/build-webkit:
3407         Added support for -no-webkit1 for the Qt and EFL port.
3408
3409 2012-12-13  Eric Seidel  <eric@webkit.org>
3410
3411         build-webkit --chromium-android forces Make even when update-webkit used --ninja
3412         https://bugs.webkit.org/show_bug.cgi?id=104839
3413
3414         Reviewed by Tony Chang.
3415
3416         This was recommended by Peter as part of:
3417         https://bugs.webkit.org/show_bug.cgi?id=104434#c4
3418         Fixing this makes build-webkit --chromium-android work for the common (ninja) case.
3419
3420         * Scripts/webkitdirs.pm:
3421         (buildChromium):
3422
3423 2012-12-13  Julie Parent  <jparent@chromium.org>
3424
3425         Loader_unittests should reset state between runs.
3426         https://bugs.webkit.org/show_bug.cgi?id=104862
3427
3428         Reviewed by Dirk Pranke.
3429
3430         The loader_unittests were not resetting state between runs, leaving
3431         a lot of data behind in global objects that the dashboard and tests
3432         rely on.  A handful were resetting just a few objects.  Use the common
3433         resetGlobals() method instead.
3434
3435         * TestResultServer/static-dashboards/loader_unittests.js:
3436
3437 2012-12-13  Andras Becsi  <andras.becsi@digia.com>
3438
3439         [Qt][WK2] Fix painting on Mac with retina display
3440         https://bugs.webkit.org/show_bug.cgi?id=104574
3441
3442         Reviewed by Kenneth Rohde Christiansen.
3443
3444         Remove setting the devicePixelRatio experimental property
3445         since the value is now automatically picked up from Qt.
3446
3447         * MiniBrowser/qt/qml/BrowserWindow.qml:
3448
3449 2012-12-13  Jussi Kukkonen  <jussi.kukkonen@intel.com>
3450
3451         [EFL][GTK] Don't call deprecated g_type_init when glib => 2.35
3452         https://bugs.webkit.org/show_bug.cgi?id=103209
3453
3454         Reviewed by Kenneth Rohde Christiansen.
3455
3456         g_type_init() is deprecated from 2.35.0 onwards. Don't call it
3457         in that case to avoid warnings and/or build failure.
3458
3459         * DumpRenderTree/gtk/ImageDiff.cpp:
3460         (main):
3461
3462 2012-12-13  Claudio Saavedra  <csaavedra@igalia.com>
3463
3464         [Tools] Add exception for gtk_style_context_get()
3465         https://bugs.webkit.org/show_bug.cgi?id=104896
3466
3467         Reviewed by Martin Robinson.
3468
3469         Add new exception for gtk_style_context_get().
3470
3471         * Scripts/webkitpy/style/checkers/cpp.py:
3472         (check_for_null): Add exception for gtk_style_context_get().
3473         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3474         (WebKitStyleTest.test_null_false_zero): Add a unit
3475         test for the new exception.
3476
3477 2012-12-13  Joaquim Rocha  <jrocha@igalia.com>
3478
3479         REGRESSION (r137432): The /webkit2/WebKitCookieManager/accept-policy unit test is failing
3480         https://bugs.webkit.org/show_bug.cgi?id=104790
3481
3482         Reviewed by Carlos Garcia Campos.
3483
3484         Unskip the GTK accept policy test.
3485
3486         * Scripts/run-gtk-tests:
3487         (TestRunner):
3488
3489 2012-12-13  Xingnan Wang  <xingnan.wang@intel.com>
3490
3491         Unreviewed. Adding myself to committers list.
3492
3493         * Scripts/webkitpy/common/config/committers.py:
3494
3495 2012-12-12  Roger Fong  <roger_fong@apple.com>
3496
3497         Unreviewed. Fix typo in NRWT.
3498
3499         * Scripts/webkitpy/layout_tests/port/base.py:
3500         (Port.is_reference_html_file):
3501
3502 2012-12-12  Roger Fong  <roger_fong@apple.com>
3503
3504         Fix detection of ref test files in old and new run webkit tests.
3505         https://bugs.webkit.org/show_bug.cgi?id=104850.
3506
3507         Reviewed by Timothy Horton.
3508
3509         * Scripts/old-run-webkit-tests:
3510         (isUsedInReftest): 
3511         Add notref and ref prefix and suffix cases to isUsedinReftest.
3512         * Scripts/webkitpy/layout_tests/port/base.py:
3513         (Port):
3514         (Port.is_reference_html_file): 
3515         Typo in NRWT.
3516
3517 2012-12-12  Dirk Pranke  <dpranke@chromium.org>
3518
3519         rework ChromiumAndroidDriver.start() et. al to avoid funky layering
3520         https://bugs.webkit.org/show_bug.cgi?id=104856
3521
3522         Reviewed by Eric Seidel.
3523
3524         r137523 / bug 10357 introduced some back-and-forth hopping during
3525         driver.start() in the chromium android port. This patch cleans it
3526         up a bit.
3527
3528         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3529         (ChromiumAndroidDriver.__init__):
3530         (ChromiumAndroidDriver._start_once):
3531         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3532         * Scripts/webkitpy/layout_tests/port/driver.py:
3533         (Driver.start):
3534         (Driver._start):
3535
3536 2012-12-12  Eric Seidel  <eric@webkit.org>
3537
3538         Add support for run-perf-tests --chromium-android --profile
3539         https://bugs.webkit.org/show_bug.cgi?id=103587
3540
3541         Reviewed by Dirk Pranke.
3542
3543         This makes it possible to profile PerformanceTests on an Android device
3544         using run-perf-tests --chromium-android --profile.
3545         CPU profiling on Android is sadly non-trivial, but this goes a long
3546         ways towards making it more accessible to non-Android developers.
3547
3548         Although this script requires your device to be flashed with a
3549         userdebug build (an annoyingly non-trivial endeavor for external contributors)
3550         it endeavors to detect and explain the common errors encountered
3551         while trying to setup a device for perf-based profiling.
3552
3553         * Scripts/webkitpy/common/system/profiler.py:
3554         (GooglePProf.profile_after_exit): Discovered that pprof will just hang if passed a missing file.
3555         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3556         (AndroidPerf):
3557         (AndroidPerf.__init__):
3558         (AndroidPerf.check_configuration):
3559         (AndroidPerf.print_setup_instructions):
3560         (_file_exists_on_device):
3561         (_run_adb_command):
3562         (attach_to_pid):
3563         (_perf_version_string):
3564         (_find_perfhost_binary):
3565         (_perfhost_path):
3566         (_first_ten_lines_of_profile):
3567         (profile_after_exit):
3568         (ChromiumAndroidDriver.__init__):
3569         (ChromiumAndroidDriver.__init__.methods):
3570         (ChromiumAndroidDriver._find_or_create_symfs):
3571         (ChromiumAndroidDriver._start_once):
3572         (ChromiumAndroidDriver):
3573         (ChromiumAndroidDriver._run_post_start_tasks):
3574         (ChromiumAndroidDriver._pid_from_android_ps_output):
3575         (ChromiumAndroidDriver._pid_on_target):
3576         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3577         (ChromiumAndroidDriverTest.test_pid_from_android_ps_output):
3578         (AndroidPerfTest):
3579         (AndroidPerfTest.test_perf_output_regexp):
3580         * Scripts/webkitpy/layout_tests/port/driver.py:
3581         (Driver._setup_environ_for_driver):
3582         (Driver):
3583         (Driver._start):
3584         (Driver._run_post_start_tasks):
3585         (Driver._pid_on_target):
3586
3587 2012-12-12  Dirk Pranke  <dpranke@chromium.org>
3588
3589         nrwt: remove deprecated ORWT compatibility command line flags
3590         https://bugs.webkit.org/show_bug.cgi?id=104301
3591
3592         Reviewed by Eric Seidel.
3593
3594         The command line flags for --noshow-results, --[no-]launch-safari,
3595         and --use-remote-links-to-tests were for compatibility with
3596         old-run-webkit-tests, but the compatibility is not needed any more
3597         since NRWT is basically default and the scripts that passed the
3598         old flags have been updated.
3599
3600         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3601         (_set_up_derived_options):
3602         (parse_args):
3603
3604 2012-12-12  John Griggs  <jgriggs@rim.com>
3605
3606         2012-12-12  John Griggs  <jgriggs@rim.com>
3607
3608         [BlackBerry] Update Media Controls
3609         https://bugs.webkit.org/show_bug.cgi?id=104443
3610         https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=204748
3611
3612         Update Media Controls for BlackBerry platform to allow audio, embedded video and fullscreen video controls to be positioned and styled differently.
3613
3614         Reviewed by Rob Buis.
3615
3616         BlackBerry-specific update to Media Controls - No new tests required.
3617
3618         * Scripts/webkitperl/FeatureList.pm:
3619
3620 2012-12-12  Justin Novosad  <junov@google.com>
3621
3622         Adding myself to SkiaGraphics watchlist
3623
3624         Unreviewed
3625
3626         * Scripts/webkitpy/common/config/watchlist:
3627
3628 2012-12-12  Martin Robinson  <mrobinson@igalia.com>
3629
3630         [GTK] Add authentication support to DRT and fix exposed issues in the libsoup backend
3631         https://bugs.webkit.org/show_bug.cgi?id=104285
3632
3633         Reviewed by Gustavo Noronha Silva.