8b142f261518f9ee708fd6c65eaedbd176e690be
[WebKit-https.git] / Tools / ChangeLog
1 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2
3         Reviewed by Kenneth Rohde Christiansen.
4
5         [EFL] Make 'single' the default backing store in EWebLauncher
6         https://bugs.webkit.org/show_bug.cgi?id=51534
7
8         'single' is the simplest backing store and the one intended to be the
9         default in the test browser. By mistake the tiled backing store was
10         left as default in r72617.
11
12         * EWebLauncher/main.c:
13         (browserCreate): ditto.
14
15 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
16
17         Reviewed by Kenneth Rohde Christiansen.
18
19         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
20         https://bugs.webkit.org/show_bug.cgi?id=51533
21
22         There's no point in concatenating env("HOME") with "blah", so remove
23         option from EWebLauncher.
24
25         * EWebLauncher/main.c:
26         (main): ditto.
27
28 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
29
30         Reviewed by Eric Seidel.
31
32         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
33
34         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
35         I just discovered that we have two additional GC runs per each WebViewHost.
36         Test_shell had no such calls.
37         These gc runs eat 15% of cpu time.
38
39         https://bugs.webkit.org/show_bug.cgi?id=51479
40
41         * DumpRenderTree/chromium/WebViewHost.cpp:
42         (WebViewHost::~WebViewHost):
43
44 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
45
46         Reviewed by Ojan Vafai.
47
48         This change splits out the TestRunner class into its own file.
49         When we fork the code for message passing, we will create a new
50         TestRunner, and this change will allow that to be more modular.
51
52         While we're at it, split out TestInput and ResultSummary into
53         their own files, to reduce the size of run_webkit_tests to
54         something more managable.
55
56         https://bugs.webkit.org/show_bug.cgi?id=51092
57
58         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
59         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
60         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
61         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
62         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
63         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
64         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
65
66  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
67
68         Reviewed by Ojan Vafai.
69
70         nrwt multiprocessing - start over, prepare to fork the code
71  
72         This code cleans up the signatures and implementation of the
73         TestRunner class so we can easily fork it to run either the
74         stable implementation or the new, unstable message-passing
75         implementation. The two variants will have different
76         implementations of the run_tests() method. We will switch
77         between the two based on the setting for the '--worker-model'
78         switch. We rename the two currently valid values to 'old-inline'
79         and 'old-threads'.
80
81         https://bugs.webkit.org/show_bug.cgi?id=51081
82
83         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
84         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
85
86 2010-12-22  Victor Wang  <victorw@chromium.org>
87
88         Reviewed by Darin Fisher.
89
90         [Chromium] Update chromium archive test result url in rebaseline script.
91
92         https://bugs.webkit.org/show_bug.cgi?id=51503
93
94         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
95
96 2010-12-22  Lucas Forschler  <lforschler@apple.com>
97
98         Reviewed by Alice Liu.
99
100         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
101         Verified on Chrome, Safari, and IE.
102         With this change, we will record memory from a parent browser window and all child processes.
103
104         * record-memory-win/main.cpp:
105         (ProcessArgs):
106         (PrintUsage):
107         (getMemoryInfo):
108         (printProcessInfo):
109         (evalProcesses):
110         (UseImage):
111         (QueryContinuously):
112         (ElapsedTime):
113
114 2010-12-22  Lucas Forschler  <lforschler@apple.com>
115
116         Unreviewed rollout r74489, because it was missing changelog.
117
118         * record-memory-win/main.cpp:
119         
120 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
121
122         Adding myself as a reviewer.
123
124         * Scripts/webkitpy/common/config/committers.py:
125
126 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
127
128         Unreviewed.  Adding myself to committers.py.
129
130         * Scripts/webkitpy/common/config/committers.py:
131
132 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
133
134         Reviewed by Kenneth Rohde Christiansen.
135
136         TestNetscapePlugIn should use #if defined
137         https://bugs.webkit.org/show_bug.cgi?id=51471
138
139         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
140         (NP_Initialize):
141         (NPP_New):
142
143 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
144
145         Reviewed by Yury Semikhatsky.
146
147         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
148
149         DevTools window should be closed explicitly because it has custom deinitialization code.
150
151         https://bugs.webkit.org/show_bug.cgi?id=50722
152
153         * DumpRenderTree/chromium/TestShell.cpp:
154         (TestShell::closeRemainingWindows):
155
156 2010-12-22  David Levin  <levin@chromium.org>
157
158         Reviewed by Shinichiro Hamaji.
159
160         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
161         https://bugs.webkit.org/show_bug.cgi?id=51452
162
163         * Scripts/webkitpy/style/checkers/cpp.py:
164         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
165         Using the file extension if possible but falling back to the file contents if we have a header file.
166         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
167         (_FileState.is_c_or_objective_c):
168         (check_using_std): Changed to using _FileState to determine the file type.
169         (check_max_min_macros): Ditto.
170         (check_for_null): Ditto.
171         (check_style): Changed the parameters to various calls since they now need _FileState
172         to determine the file type.
173         (check_language): Added the file_state parameter so it could be passed
174         to check_identifier_name_in_declaration.
175         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
176         this is an Objective C file.
177         (_process_lines): Added information for the _FileState constructor (and moved the
178         call to a place that had the information).
179         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
180         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
181         its functionality.
182         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
183
184 2010-12-21  Andy Estes  <aestes@apple.com>
185
186         Reviewed by Mark Rowe.
187
188         Do not build non-Intel architectures for WebKit2-related projects.
189         https://bugs.webkit.org/show_bug.cgi?id=51440
190
191         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
192         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
193         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
194
195 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
196
197         Reviewed by Darin Fisher.
198
199         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
200         https://bugs.webkit.org/show_bug.cgi?id=51406 
201         
202         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
203         to WebThemeEngineDRTWin and update references everywhere.
204
205         * DumpRenderTree/DumpRenderTree.gypi:
206         * DumpRenderTree/chromium/TestShellWin.cpp:
207         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
208         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
209         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
210         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
211
212 2010-12-21  Anders Carlsson  <andersca@apple.com>
213
214         Reviewed by John Sullivan.
215
216         Clicking missing plug-in text does not show a sheet
217         https://bugs.webkit.org/show_bug.cgi?id=51403
218
219         Update for changes to the WebPageUIClient.
220
221         * MiniBrowser/mac/BrowserWindowController.m:
222         (-[BrowserWindowController awakeFromNib]):
223         * WebKitTestRunner/TestController.cpp:
224         (WTR::createOtherPage):
225         (WTR::TestController::initialize):
226
227 2010-12-21  Eric Seidel  <eric@webkit.org>
228
229         Reviewed by Adam Barth.
230
231         commit-queue will report constant failures as flaky if other tests flake
232         https://bugs.webkit.org/show_bug.cgi?id=51272
233
234         This patch just removes functionality and adds testing.
235         Previously we attempted to report flaky tests when we had
236         two different tests fail in a row.  However, since we stop
237         running the tests at the first failure, our code was wrong in
238         trying to determine flakiness from the incomplete runs.
239
240         Originally I posted an alternate patch:
241         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
242         which fixed our flaky logic in this case, however it was decided
243         that that patch would be too difficult to maintain, so now
244         I'm just removing the broken logic.
245
246         This will dramatically cut-down on our flaky-test false positives
247         at the (small) cost of the queues being unable to report
248         any flakiness if the tree is very flaky.  (With at least one test
249         flaking on every run, we'll never report failures anymore.)  I think
250         this is a tradeoff worth making.
251
252         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
253         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
254
255 2010-12-20  Eric Seidel  <eric@webkit.org>
256
257         Reviewed by Adam Barth.
258
259         commit-queue wrongly rejects patches when it can't update itself
260         https://bugs.webkit.org/show_bug.cgi?id=46636
261
262         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
263         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
264         * Scripts/webkitpy/tool/commands/queues_unittest.py:
265
266 2010-12-20  Adam Barth  <abarth@webkit.org>
267
268         Move web sites to Websites directory
269         https://bugs.webkit.org/show_bug.cgi?id=51323
270
271         Update references to BugsSite to point to the new location.
272
273         This patch was never officially reviewed (because it was too large to
274         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
275         Rowe gave me the green light.
276
277         * Scripts/old-run-webkit-tests:
278         * Scripts/webkitpy/common/config/build.py:
279         * Scripts/webkitpy/common/config/build_unittest.py:
280         * Scripts/webkitpy/common/prettypatch.py:
281         * Scripts/webkitpy/layout_tests/port/base.py:
282         * Scripts/webkitpy/style/main.py:
283
284 2010-12-20  Adrienne Walker  <enne@google.com>
285
286         Unreviewed. Adding myself to the list of committers.
287
288         * webkitpy/common/config/committers.py:
289
290 2010-12-20  Mark Rowe  <mrowe@apple.com>
291
292         Reviewed by Dan Bernstein.
293
294         <rdar://problem/8757601> Don't install header files in to the Resources directory.
295
296         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
297         Resources directory.
298
299 2010-12-20  Eric Seidel  <eric@webkit.org>
300
301         Reviewed by Adam Barth.
302
303         commit-queue should include bot id when attaching failure diffs
304         https://bugs.webkit.org/show_bug.cgi?id=51280
305
306         This is a tiny change to include the bot id in the name of the attachment.
307         Most of this diff is just changing the unit test expectations
308         now that I hid the comment printing when the comment is None.
309
310         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
311         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
312         * Scripts/webkitpy/tool/commands/upload_unittest.py:
313         * Scripts/webkitpy/tool/mocktool.py:
314
315 2010-12-20  Jeff Miller  <jeffm@apple.com>
316
317         Reviewed by Dan Bernstein.
318
319         Tools/vcbin/midl.exe needs to be rebuilt
320         https://bugs.webkit.org/show_bug.cgi?id=51347
321
322         * vcbin/midl.exe: Rebuilt.
323
324 2010-12-20  David Levin  <levin@chromium.org>
325
326         Reviewed by Ariya Hidayat.
327
328         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
329         https://bugs.webkit.org/show_bug.cgi?id=51343
330
331         Follow up from the WebKitTools -> Tools rename.
332
333         * Scripts/webkit-tools-completion.sh:
334
335 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
336
337         Reviewed by James Robinson.
338
339         new-run-webkit-tests ignores trailing EOL differences in text tests
340         https://bugs.webkit.org/show_bug.cgi?id=36983
341
342         Changed the handling of new-line characters within new-run-webkit-tests
343         to match old-run-webkit-tests.  Differences in leading and trailing empty
344         lines in text expectation files are no longer ignored.
345
346         * Scripts/webkitpy/layout_tests/port/base.py:
347         * Scripts/webkitpy/layout_tests/port/test.py:
348         Added unit tests.  Removed old duplicate unit test entries.
349         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
350
351 2010-12-20  David Levin  <levin@chromium.org>
352
353         Reviewed by Shinichiro Hamaji.
354
355         check-webkit-style should detect function declarations (and trivial functions).
356         https://bugs.webkit.org/show_bug.cgi?id=51303
357
358         * Scripts/webkitpy/style/checkers/cpp.py:
359         (_FunctionState.begin): Add is_declaration and changed the line count
360         start to begin at -1 (which will keep the results consistent, since
361         the starting line number passed in is one less in this change).
362         (detect_functions): changed function detection to now catch trivial
363         functions and declarations.
364         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
365         of the function as this may look at return values (when processing
366         a declaration).
367         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
368         (FunctionDetectionTest.perform_function_detection): Basic mechanics
369         of testing the function detection.
370         (FunctionDetectionTest.test_basic_function_detection): Test a simple
371         function.
372         (FunctionDetectionTest.test_function_declaration_detection): Test a
373         declaration.
374         (FunctionDetectionTest.test_non_functions): A test case for a case
375         that caused the code to fail due to the { being in quotes.
376         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
377         cases to help catch false alarms for return values.
378         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
379         we don't get false alarms for member variables either.
380
381 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
382
383         Reviewed by Antonio Gomes.
384
385         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
386         https://bugs.webkit.org/show_bug.cgi?id=51319
387
388         * CMakeListsEfl.txt:
389
390 2010-12-18  Adam Barth  <abarth@webkit.org>
391
392         Reviewed by Sam Weinig.
393
394         Move WebKitExamplePlugins to Examples
395         https://bugs.webkit.org/show_bug.cgi?id=51291
396
397         * Scripts/webkitpy/common/config/build.py:
398
399 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
400
401         Unreviewed Qt buildfix after r74301.
402
403         Rename WebKitTools to Tools
404         https://bugs.webkit.org/show_bug.cgi?id=49861
405
406         * MiniBrowser/DerivedSources.pro:
407         * MiniBrowser/qt/MiniBrowser.pro:
408
409 2010-12-17  Dan Bernstein  <mitz@apple.com>
410
411         Reviewed by Simon Fraser.
412
413         Rename WebKitTools to Tools
414         https://bugs.webkit.org/show_bug.cgi?id=49861
415
416         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
417         * CodeCoverage/README:
418         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
419         (WebCore::DumpRenderTree::initializeFonts):
420         * EWSTools/start-commit-queue.sh:
421         * EWSTools/start-queue.sh:
422         * GNUmakefile.am:
423         * MIDLWrapper/MIDLWrapper.cpp:
424         (wmain):
425         * MiniBrowser/qt/MiniBrowser.pro:
426         * Scripts/build-api-tests:
427         * Scripts/build-dumprendertree:
428         * Scripts/build-webkit:
429         * Scripts/build-webkittestrunner:
430         * Scripts/generate-coverage-data:
431         * Scripts/old-run-webkit-tests:
432         * Scripts/run-api-tests:
433         * Scripts/run-iexploder-tests:
434         * Scripts/run-javascriptcore-tests:
435         * Scripts/run-mangleme-tests:
436         * Scripts/run-sunspider:
437         * Scripts/run-webkit-websocketserver:
438         * Scripts/sunspider-compare-results:
439         * Scripts/test-webkitperl:
440         * Scripts/test-webkitpy:
441         * Scripts/update-iexploder-cssproperties:
442         * Scripts/update-webkit:
443         * Scripts/update-webkit-localizable-strings:
444         * Scripts/webkitdirs.pm:
445         * Scripts/webkitpy/common/checkout/scm.py:
446         * Scripts/webkitpy/common/checkout/scm_unittest.py:
447         * Scripts/webkitpy/common/config/committervalidator.py:
448         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
449         * Scripts/webkitpy/common/config/ports.py:
450         * Scripts/webkitpy/common/config/ports_unittest.py:
451         * Scripts/webkitpy/common/system/logutils_unittest.py:
452         * Scripts/webkitpy/common/system/ospath_unittest.py:
453         * Scripts/webkitpy/layout_tests/port/chromium.py:
454         * Scripts/webkitpy/layout_tests/port/config.py:
455         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
456         * Scripts/webkitpy/layout_tests/port/http_server.py:
457         * Scripts/webkitpy/layout_tests/port/test.py:
458         * Scripts/webkitpy/style/checker.py:
459         * Scripts/webkitpy/style/checker_unittest.py:
460         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
461         * Scripts/webkitpy/tool/commands/queues_unittest.py:
462         * Scripts/webkitpy/tool/steps/steps_unittest.py:
463         * WebKitTestRunner/DerivedSources.pro:
464         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
465         (WTR::activateFonts):
466         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
467         * wx/build/build_utils.py:
468
469 2010-12-16  Antonio Gomes  <agomes@rim.com>
470
471         Reviewed by Martin Robinson.
472
473         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
474         https://bugs.webkit.org/show_bug.cgi?id=51163
475
476         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
477         GTK+'s DRT should also reset to UNIX after each test execution.
478
479         * DumpRenderTree/gtk/DumpRenderTree.cpp:
480         (resetDefaultsToConsistentValues):
481
482 2010-12-17  David Levin  <levin@chromium.org>
483
484         Reviewed by Eric Seidel.
485
486         check-webkit-style should understand WTF #include guards
487         https://bugs.webkit.org/show_bug.cgi?id=44911
488
489         * Scripts/webkitpy/style/checkers/cpp.py:
490         (get_header_guard_cpp_variable): modify to suggest the WTF style
491         of header guard when appropriate.
492         (check_for_header_guard): handle multiple return values from
493         get_header_guard_cpp_variable
494         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
495         (CppStyleTest.test_build_header_guard): Added tests for the WTF
496         header style.
497
498 2010-12-16  David Levin  <levin@chromium.org>
499
500         Reviewed by Eric Seidel.
501
502         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
503         https://bugs.webkit.org/show_bug.cgi?id=51210
504
505         The error only shows up when using python 2.6 or later.
506
507         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
508         the decprecated field error,message with something equivalent.
509
510 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
511
512         Reviewed by Eric Seidel.
513
514         Add --exit-after-n-failures/crashes to NRWT
515         https://bugs.webkit.org/show_bug.cgi?id=51160
516         
517         Abort test run (in a similar way to how control-C is handled) when
518         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
519         that number of unexpected failures/crashes/timeouts.
520
521         * Scripts/webkitpy/layout_tests/port/test.py:
522         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
523         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
524
525 2010-12-16  David Levin  <levin@chromium.org>
526
527         Reviewed by Shinichiro Hamaji.
528
529         check-webkit-style unit tests has some duplicate boilerplate code.
530         https://bugs.webkit.org/show_bug.cgi?id=49519
531
532         * Scripts/webkitpy/style/checkers/cpp.py:
533         (update_include_state): Replaced the "io" parameter with the global
534         configuration _unit_test_config. This allowed not calling into
535         functions at a low level and also not plumbing through the injection
536         information through many levels of code.
537         (check_for_include_what_you_use): Ditto.
538         (process_file_data): Added the ability to set up the unit test config
539         to allow for injection.
540         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
541         (ErrorCollector.__init__): Added support for having a filter for errors.
542         (ErrorCollector.__call__): Ditto.
543         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
544         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
545         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
546         functions in the cpp.py with generic processing and a filter that
547         indicates what errors should be kept.
548         (CppStyleTestBase.perform_multi_line_lint): Ditto.
549         (CppStyleTestBase.perform_language_rules_check): Ditto.
550         (CppStyleTestBase.perform_function_lengths_check): Ditto.
551         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
552         (CppStyleTestBase.perform_include_what_you_use): Ditto.
553         (CppStyleTest.test_multi_line_comments): Added another
554         error message which applies to the test case.
555         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
556         to not have config.h, since it is processed as a header file.
557         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
558         style and indentation in checked code.
559         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
560         Fixed line number.
561         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
562         Ditto.
563
564 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
565
566         Unreviewed, rolling out r74136.
567         http://trac.webkit.org/changeset/74136
568         https://bugs.webkit.org/show_bug.cgi?id=51135
569
570         r74136 breaks chromium canary bots because some tests are not
571         rebaselined correctly to resolve EOL differences (Requested by
572         jianli on #webkit).
573
574         * Scripts/webkitpy/layout_tests/port/base.py:
575         * Scripts/webkitpy/layout_tests/port/test.py:
576         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
577
578 2010-12-15  Adam Roben  <aroben@apple.com>
579
580         Teach check-webkit-style to check .vcproj and .vsprops files for XML
581         syntax errors
582
583         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
584         XML syntax errors in .vcproj/.vsprops files
585
586         Reviewed by Dave Levin.
587
588         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
589         that should be treated as XML and that should be allowed to contain
590         carriage returns. (These lists happen to be identical currently.)
591         (FileType): Added a new XML type.
592         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
593         Just does a simple file extension check.
594         (CheckerDispatcher._file_type): Added a case for XML files.
595         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
596         files (surprise!).
597         (StyleProcessor.process): Ask the dispatcher whether we should pass the
598         lines through the carriage checker.
599
600         * Scripts/webkitpy/style/checker_unittest.py:
601         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
602         Added. Checks a few file names to see if carriage returns are allowed
603         or not.
604         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
605         other assert_checker_* functions.
606         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
607         test_*_paths functions.
608         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
609         test_*_paths functions.
610         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
611         file from this test case, as vcproj files now have a type.
612         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
613         Added. Similar to the other should_* functions.
614         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
615         Added. Checks that carriage returns aren't checked for or stripped for
616         allowed files.
617
618         * Scripts/webkitpy/style/checkers/xml.py: Added.
619         (XMLChecker.__init__): Simple init method.
620         (XMLChecker.check): Pass each line through the expat parser, and record
621         a style error for any errors thrown by the parser.
622
623         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
624         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
625         produce a style error.
626         (XMLCheckerTest.assert_error): Checks that the given XML produces an
627         error of the given category on the given line.
628         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
629         checking that the XMLChecker constructor works properly.
630         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
631         cause a style error (see, e.g., r73887).
632         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
633         cause a style error (see, e.g., r73773).
634         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
635         properly.
636         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
637         tags cause a style error (see, e.g., r72795).
638         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
639         style error.
640
641 2010-12-15  Lucas Forschler  <lforschler@apple.com>
642
643         Reviewed by Stephanie Lewis.
644
645         https://bugs.webkit.org/show_bug.cgi?id=51117
646         Add a new leopard test bot
647         really really commit to trunk this time.
648
649         * BuildSlaveSupport/build.webkit.org-config/config.json:
650
651 2010-12-15  Sam Weinig  <sam@webkit.org>
652
653         Reviewed by Anders Carlsson.
654
655         WebKit2: Can't add files to an <input type=file>
656         https://bugs.webkit.org/show_bug.cgi?id=51087
657
658         * MiniBrowser/mac/BrowserWindowController.m:
659         (runOpenPanel):
660         (-[BrowserWindowController awakeFromNib]):
661         Add simple implementation of runOpenPanel callback.
662
663         * MiniBrowser/win/BrowserView.cpp:
664         (BrowserView::create):
665         * WebKitTestRunner/TestController.cpp:
666         (WTR::createOtherPage):
667         (WTR::TestController::initialize):
668         Stub out runOpenPanel callback. 
669
670 2010-12-14  Eric Seidel  <eric@webkit.org>
671
672         Reviewed by Adam Barth.
673
674         commit-queue should upload failure diffs when tests flake
675         https://bugs.webkit.org/show_bug.cgi?id=51051
676
677         To make this testable I needed to pipe FileSystem down onto tool.
678         We've wanted it there for a long time anyway.
679
680         This patch is kinda a big hack.  But we don't have a nice
681         way to read results.html files.  I think this will need further
682         revision before this code actually feels clean.
683
684         As part of testing this change, I had to make MockBugzilla.create_bug
685         actually return an id (like it should) which required updating
686         a few other unit test results (for the better).
687
688         The results_matching_keys change in layouttestresults/rebasline
689         was an alternate path which I decided not to use in the end, but
690         I left the change as it seemed an improvement.
691
692         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
693         * Scripts/webkitpy/common/net/layouttestresults.py:
694         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
695         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
696         * Scripts/webkitpy/tool/commands/queues.py:
697         * Scripts/webkitpy/tool/commands/rebaseline.py:
698         * Scripts/webkitpy/tool/main.py:
699         * Scripts/webkitpy/tool/mocktool.py:
700
701 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
702
703         Reviewed by James Robinson.
704
705         new-run-webkit-tests ignores trailing EOL differences in text tests
706         https://bugs.webkit.org/show_bug.cgi?id=36983
707
708         Changed the handling of new-line characters within new-run-webkit-tests
709         to match old-run-webkit-tests.  Differences in leading and trailing empty
710         lines in text expectation files are no longer ignored.
711
712         * Scripts/webkitpy/layout_tests/port/base.py:
713         * Scripts/webkitpy/layout_tests/port/test.py:
714         Added unit tests.  Removed old duplicate unit test entries.
715         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
716
717 2010-12-15  Ojan Vafai  <ojan@chromium.org>
718
719         Reviewed by Adam Barth.
720
721         make status-bubble white-space:nowrap so we can measure it's width without wrapping
722         https://bugs.webkit.org/show_bug.cgi?id=51149
723
724         * QueueStatusServer/templates/statusbubble.html:
725
726 2010-12-15  Ojan Vafai  <ojan@chromium.org>
727
728         Reviewed by Adam Barth.
729
730         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
731         https://bugs.webkit.org/show_bug.cgi?id=51125
732
733         * QueueStatusServer/templates/statusbubble.html:
734
735 2010-12-15  Darin Adler  <darin@apple.com>
736
737         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
738
739 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
740
741         Unreviewed, rolling out r74117.
742         http://trac.webkit.org/changeset/74117
743         https://bugs.webkit.org/show_bug.cgi?id=51113
744
745         This broke the GTK1 build. (Requested by mrobinson on
746         #webkit).
747
748         * Scripts/webkitdirs.pm:
749
750 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
751
752         Reviewed by Martin Robinson.
753
754         Change generate-forwarding-headers.pl for GTK port usage 
755         (https://bugs.webkit.org/show_bug.cgi?id=37369)
756
757         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
758
759 2010-12-14  Kent Tamura  <tkent@chromium.org>
760
761         Reviewed by Jian Li.
762
763         [DRT/Chromium] Remove another unnecessary error message
764         https://bugs.webkit.org/show_bug.cgi?id=51083
765
766         * DumpRenderTree/chromium/WebViewHost.cpp:
767         (WebViewHost::didInvalidateRect):
768
769 2010-12-14  Lucas Forschler  <lforschler@apple.com>
770
771         Reviewed by Stephanie Lewis.
772
773         Add a new Leopard Debug Test WK2 Bot
774
775         * BuildSlaveSupport/build.webkit.org-config/config.json:
776
777 2010-12-14  Ojan Vafai  <ojan@chromium.org>
778
779         Fix python unittests after http://trac.webkit.org/changeset/74070.
780
781         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
782
783 2010-12-14  Kent Tamura  <tkent@chromium.org>
784
785         Reviewed by Jian Li.
786
787         [DRT/Chromium] Remove a unnecessary error message
788         https://bugs.webkit.org/show_bug.cgi?id=51069
789
790         * DumpRenderTree/chromium/WebViewHost.cpp:
791         (WebViewHost::paintInvalidatedRegion):
792
793 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
794
795         Reviewed by Ojan Vafai.
796
797         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
798         https://bugs.webkit.org/show_bug.cgi?id=48926
799
800         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
801         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
802
803 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
804
805         Reviewed by Eric Seidel.
806
807         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
808         https://bugs.webkit.org/show_bug.cgi?id=50231
809
810         Guard CONFIG+=link_pkgconfig with !symbian.
811
812         * DumpRenderTree/qt/DumpRenderTree.pro:
813         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
814         * WebKitTestRunner/qt/WebKitTestRunner.pro:
815
816 2010-12-14  Philippe Normand  <pnormand@igalia.com>
817
818         Reviewed by Ojan Vafai.
819
820         [new-run-webkit-tests] expectations parsing is slow
821         https://bugs.webkit.org/show_bug.cgi?id=50635
822
823         Avoid expensive iteration of all the tests when checking if a test
824         file is to be skipped or not.
825
826         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
827         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
828         * Scripts/webkitpy/layout_tests/port/test.py:
829
830 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
831
832         Reviewed by Xan Lopez.
833
834         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
835         https://bugs.webkit.org/show_bug.cgi?id=27048
836
837         Add support in DRT for checking whether an accessibility UI
838         element is focusable and/or focused. Implemented for GTK.
839
840         * DumpRenderTree/AccessibilityUIElement.cpp:
841         (getIsFocusedCallback): New.
842         (getIsFocusableCallback): New.
843         (AccessibilityUIElement::getJSClass): Add the new available
844         callbacks for isFocused and isFocusable.
845         * DumpRenderTree/AccessibilityUIElement.h:
846         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
847         (AccessibilityUIElement::isFocused): New, implemented by checking
848         whether the related AtkState value is in the object's state set.
849         (AccessibilityUIElement::isFocusable): Ditto.
850         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
851         (AccessibilityUIElement::isFocused): New, dummy implementation.
852         (AccessibilityUIElement::isFocusable): Ditto.
853         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
854         (AccessibilityUIElement::isFocused): Ditto.
855         (AccessibilityUIElement::isFocusable): Ditto.
856
857 2010-12-14  Eric Seidel  <eric@webkit.org>
858
859         Reviewed by Ojan Vafai.
860
861         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
862         https://bugs.webkit.org/show_bug.cgi?id=50715
863
864         This patch makes webkit-patch print the following:
865
866         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
867         Install a 64-bit git for better performance, see:
868         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
869
870         I wrote this mostly because I have approximately 8 machines that I use
871         and making sure each one is using a good Git install seemed folly.
872         webkit-patch makes a lot of git calls, so using a fast git can shave
873         several seconds in every invocation.  See the webkit-dev thread for more info.
874
875         This message will print twice during 'webkit-patch upload',
876         once from webkit-patch and once from check-webkit-style.
877
878         Unfortunately there is no good way to test this due to how machine-dependent
879         the code is.  I considered writing a test for the log message, but it seemed not worth it.
880
881         * Scripts/webkitpy/common/checkout/scm.py:
882
883 2010-12-13  Eric Seidel  <eric@webkit.org>
884
885         Reviewed by Adam Barth.
886
887         FlakyTestReporter doesn't understand bots running from multiple email addresses
888         https://bugs.webkit.org/show_bug.cgi?id=50960
889
890         This explains at least one of the dupes of:
891         https://bugs.webkit.org/show_bug.cgi?id=50863
892         that we saw filed by the commit-queue this morning.
893         I think the other one was explained by my previous fix to result counting code.
894
895         Since this is really hard to test with a unit test, instead I
896         create a new (possibly useful in the future) command
897         which given a layout test path will return you
898         the one bug which our tools would assume it the flaky test bug.
899         If some other script wants to use bug-for-test we'll
900         need to extend it with some options like --create-if-missing or similar.
901
902         * Scripts/webkitpy/common/net/bugzilla/bug.py:
903         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
904         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
905         * Scripts/webkitpy/tool/commands/__init__.py:
906         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
907
908 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
909
910         Reviewed by James Robinson.
911
912         Add option to build-webkit to not build WebKit2
913         https://bugs.webkit.org/show_bug.cgi?id=50988
914         
915         Add support for a --no-webkit2 option to build-webkit. It seems to save
916         ~1 minute from clean builds and ~10 seconds from no-op builds.
917
918         * Scripts/build-webkit:
919
920 2010-12-13  Lucas Forschler  <lforschler@apple.com>
921
922         Reviewed by Dave Kilzer.
923
924         Update iexploder from 1.3.2 to 1.7.2
925         Move 1.3.2 into its own subdir
926         Add 1.7.2 into its own subdir
927         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
928
929         * Scripts/run-iexploder-tests:
930         * Scripts/update-iexploder-cssproperties:
931         * iExploder/CHANGELOG.txt: Removed.
932         * iExploder/LICENSE.txt: Removed.
933         * iExploder/README.txt: Removed.
934         * iExploder/htdocs: Removed.
935         * iExploder/iexploder-1.3.2: Added.
936         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
937         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
938         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
939         * iExploder/iexploder-1.3.2/htdocs: Added.
940         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
941         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
942         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
943         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
944         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
945         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
946         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
947         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
948         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
949         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
950         * iExploder/iexploder-1.3.2/tools: Added.
951         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
952         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
953         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
954         * iExploder/iexploder-1.7.2: Added.
955         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
956         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
957         * iExploder/iexploder-1.7.2/README.txt: Added.
958         * iExploder/iexploder-1.7.2/output: Added.
959         * iExploder/iexploder-1.7.2/src: Added.
960         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
961         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
962         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
963         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
964         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
965         * iExploder/iexploder-1.7.2/src/css-properties: Added.
966         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
967         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
968         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
969         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
970         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
971         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
972         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
973         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
974         * iExploder/iexploder-1.7.2/src/css-values: Added.
975         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
976         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
977         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
978         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
979         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
980         * iExploder/iexploder-1.7.2/src/headers: Added.
981         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
982         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
983         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
984         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
985         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
986         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
987         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
988         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
989         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
990         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
991         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
992         * iExploder/iexploder-1.7.2/src/html-tags: Added.
993         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
994         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
995         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
996         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
997         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
998         * iExploder/iexploder-1.7.2/src/html-values: Added.
999         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
1000         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
1001         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
1002         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
1003         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
1004         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
1005         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
1006         * iExploder/iexploder-1.7.2/src/index.html: Added.
1007         * iExploder/iexploder-1.7.2/src/media: Added.
1008         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
1009         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
1010         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
1011         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
1012         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
1013         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
1014         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
1015         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
1016         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
1017         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
1018         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
1019         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
1020         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
1021         * iExploder/iexploder-1.7.2/src/mime-types: Added.
1022         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
1023         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
1024         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
1025         * iExploder/iexploder-1.7.2/src/protocols: Added.
1026         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
1027         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
1028         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
1029         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
1030         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
1031         * iExploder/iexploder-1.7.2/src/version.rb: Added.
1032         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
1033         * iExploder/iexploder-1.7.2/testcases: Added.
1034         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
1035         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
1036         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
1037         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
1038         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
1039         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
1040         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
1041         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
1042         * iExploder/iexploder-1.7.2/tools: Added.
1043         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
1044         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
1045         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
1046         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
1047         * iExploder/tools: Removed.
1048
1049 2010-12-13  Sam Weinig  <sam@webkit.org>
1050
1051         Reviewed by Anders Carlsson.
1052
1053         Remove associated page concept from WKView constructor
1054         https://bugs.webkit.org/show_bug.cgi?id=50983
1055
1056         Step 1: Remove associate page constructors from WKView and make
1057         all views use the shared namespace for the context.
1058
1059         * TestWebKitAPI/PlatformWebView.h:
1060         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1061         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1062         * WebKitTestRunner/PlatformWebView.h:
1063         * WebKitTestRunner/TestController.cpp:
1064         (WTR::createOtherPage):
1065         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1066         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1067         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1068
1069 2010-12-13  Sam Weinig  <sam@webkit.org>
1070
1071         Reviewed by Anders Carlsson.
1072
1073         Change the WebKit2 public API so there is no explicit WKPageNamespace object
1074         https://bugs.webkit.org/show_bug.cgi?id=50898
1075
1076         * MiniBrowser/mac/AppDelegate.h:
1077         * MiniBrowser/mac/AppDelegate.m:
1078         * MiniBrowser/mac/BrowserWindowController.h:
1079         * MiniBrowser/mac/BrowserWindowController.m:
1080         * MiniBrowser/win/BrowserView.cpp:
1081         Convert MiniBrowser to not use PageNamespaces.
1082
1083         * TestWebKitAPI/PlatformWebView.h:
1084         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1085         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1086         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1087         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1088         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1089         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1090         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1091         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1092         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1093         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1094         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1095         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1096         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1097         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1098         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1099         Convert TestWebKitAPI to not use PageNamespaces.
1100
1101         * WebKitTestRunner/PlatformWebView.h:
1102         * WebKitTestRunner/TestController.cpp:
1103         * WebKitTestRunner/TestController.h:
1104         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1105         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1106         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1107         Convert WebKitTestRunner to not use PageNamespaces.
1108
1109 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1110
1111         Reviewed by Eric Seidel.
1112
1113         webkit-patch rollout should be able to do multi-revision rollouts
1114         https://bugs.webkit.org/show_bug.cgi?id=33336
1115
1116         Make it possible to pass more than one revision to webkit-patch.
1117
1118         * Scripts/webkitpy/common/checkout/api.py:
1119         * Scripts/webkitpy/common/checkout/changelog.py:
1120         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1121         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1122         * Scripts/webkitpy/tool/commands/download.py:
1123         * Scripts/webkitpy/tool/commands/download_unittest.py:
1124         * Scripts/webkitpy/tool/mocktool.py:
1125         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1126         * Scripts/webkitpy/tool/steps/revertrevision.py:
1127
1128 2010-12-13  Eric Seidel  <eric@webkit.org>
1129
1130         Unreviewed.
1131
1132         Teach webkit-patch how to search bugzilla
1133         https://bugs.webkit.org/show_bug.cgi?id=50500
1134
1135         webkit-patch bug-search fails when there is only one result.
1136         Turns out we needed a bit more logic in our result count parsing code.
1137
1138         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1139         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1140
1141 2010-12-13  Antti Koivisto  <antti@apple.com>
1142
1143         Reviewed by Alexey Proskuryakov.
1144
1145         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
1146         https://bugs.webkit.org/show_bug.cgi?id=50758
1147
1148         * DumpRenderTree/LayoutTestController.cpp:
1149         (setSerializeHTTPLoadsCallback):
1150         (LayoutTestController::staticFunctions):
1151         * DumpRenderTree/LayoutTestController.h:
1152         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1153         (LayoutTestController::setSerializeHTTPLoads):
1154         * DumpRenderTree/mac/DumpRenderTree.mm:
1155         (resetDefaultsToConsistentValues):
1156         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1157         (LayoutTestController::setSerializeHTTPLoads):
1158         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1159         (LayoutTestController::setSerializeHTTPLoads):
1160
1161 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
1162
1163         Reviewed by Ojan Vafai.
1164
1165         Remove "use-drt" option from test step command line, since the option was removed in r73748.
1166         https://bugs.webkit.org/show_bug.cgi?id=50936
1167
1168         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
1169
1170 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
1171
1172         Reviewed by Csaba Osztrogonác.
1173
1174         Add revlink to BuildBot status
1175         https://bugs.webkit.org/show_bug.cgi?id=50914
1176
1177         This adds a hyperlink to trac changeset on the revision numbers. 
1178
1179         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1180
1181 2010-12-13  Andras Becsi  <abecsi@webkit.org>
1182
1183         Reviewed by Csaba Osztrogonác.
1184
1185         [Qt][WK2] Fix build if WebKitTools are not available
1186         https://bugs.webkit.org/show_bug.cgi?id=50242
1187
1188         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
1189         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
1190         * MiniBrowser/DerivedSources.pro: Added.
1191
1192 2010-12-13  Eric Seidel  <eric@webkit.org>
1193
1194         Reviewed by Adam Barth.
1195
1196         EWS Queues should remove orpahned pyc files before starting
1197         https://bugs.webkit.org/show_bug.cgi?id=50904
1198
1199         A previous check added a platform.py which caused
1200         EWS bots on some platforms to hit an import exception.
1201         The platform.py file was removed in a subsequent commit, but
1202         the EWS bots in question stayed stuck.  This change will
1203         fix those bots once restarted (and prevent this in the future).
1204
1205         I also went ahead and unified start-queue and start-commit-queue
1206         since they were nearly identical.  I also added bot_id support
1207         to both force all EWSes to have bot ids as well as get rid of the one
1208         remaining reason why I had my own copies of these scripts.
1209         Hopefully this will be enough to get all the other bot admins
1210         (ahem, Adam, ahem) to move to using these checked in copies as well.
1211
1212         * EWSTools/start-commit-queue.sh: Removed.
1213         * EWSTools/start-queue.sh:
1214
1215 2010-10-28  MORITA Hajime  <morrita@google.com>
1216
1217         Reviewed by Ojan Vafai.
1218
1219         spellcheck does not check pasted text
1220         https://bugs.webkit.org/show_bug.cgi?id=40092
1221
1222         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
1223         to control the setting.
1224
1225         * DumpRenderTree/LayoutTestController.cpp:
1226         (setAsynchronousSpellCheckingEnabledCallback):
1227         (LayoutTestController::staticFunctions):
1228         * DumpRenderTree/LayoutTestController.h:
1229         * DumpRenderTree/chromium/LayoutTestController.h:
1230         * DumpRenderTree/chromium/LayoutTestController.cpp:
1231         (LayoutTestController::LayoutTestController):
1232         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1233         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1234         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1235         * DumpRenderTree/mac/DumpRenderTree.mm:
1236         (resetDefaultsToConsistentValues):
1237         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1238         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1239         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1240         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1241         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1242         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1243         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1244         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1245         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1246
1247 2010-12-12  Sam Weinig  <sam@webkit.org>
1248
1249         Reviewed by Anders Carlsson.
1250
1251         Fix failing API test. It turns out that a pop-state event
1252         is sent before every fragment navigation, so we have to test
1253         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
1254
1255         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1256         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1257
1258 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
1259
1260         Reviewed by Eric Seidel.
1261
1262         [GTK] Add new-run-webkit-tests support to gtk
1263         https://bugs.webkit.org/show_bug.cgi?id=50681
1264
1265         Adding the basic support to run the new-run-webkit-tests.
1266
1267         * Scripts/webkitpy/layout_tests/port/gtk.py:
1268
1269 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
1270
1271         Reviewed by Kenneth Rohde Christiansen.
1272
1273         [Qt] Mock DeviceOrientation client for DRT
1274         https://bugs.webkit.org/show_bug.cgi?id=47490
1275
1276         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1277         (WebCore::DumpRenderTree::DumpRenderTree):
1278         (WebCore::DumpRenderTree::~DumpRenderTree):
1279         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1280         (LayoutTestController::setMockDeviceOrientation):
1281
1282 2010-12-11  Philippe Normand  <pnormand@igalia.com>
1283
1284         Reviewed by Gustavo Noronha Silva.
1285
1286         [GTK] launcher: disable the Mozilla-style fullscreen API
1287         https://bugs.webkit.org/show_bug.cgi?id=50874
1288
1289         Disabling the fullscreen API until its implementation for GTK is
1290         mature enough. The webview setting for it is already FALSE by
1291         default.
1292
1293         * GtkLauncher/main.c:
1294         (createWindow):
1295
1296 2010-12-10  Eric Seidel  <eric@webkit.org>
1297
1298         Reviewed by Adam Barth.
1299
1300         commit-queue flaky test messages show cryptic version information for mac os x
1301         https://bugs.webkit.org/show_bug.cgi?id=50864
1302
1303         Turns out platform.platform() returns kernel version information
1304         which isn't helpful, and just plain confusing on Mac
1305         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
1306
1307         So I've updated PlatformInfo.display_name() to special case
1308         mac.  I also found a bad use of sys.platform in the process
1309         and fixed that.  (sys.platform always returns 'darwin' on mac).
1310
1311         * Scripts/webkitpy/common/system/platforminfo.py:
1312         * Scripts/webkitpy/common/system/user.py:
1313         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1314         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1315         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1316
1317 2010-12-10  Eric Seidel  <eric@webkit.org>
1318
1319         Unreviewed.
1320
1321         Exception seen while reporting flaky test with commit-queue.
1322         Just a missing include.
1323
1324         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1325         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1326
1327 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
1328
1329         Reviewed by Eric Seidel.
1330
1331         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
1332         https://bugs.webkit.org/show_bug.cgi?id=50796
1333
1334         Also updating the test code to use JSONResultsGeneratorBase and
1335         to improve test coverage for incremental cases.
1336
1337         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1338         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1339
1340 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
1341
1342         Reviewed by Darin Adler.
1343
1344         prepare-ChangeLog --help doesn't mention --bug shorthand -b
1345         https://bugs.webkit.org/show_bug.cgi?id=50835
1346
1347         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
1348
1349 2010-12-10  Eric Seidel  <eric@webkit.org>
1350
1351         Reviewed by Adam Barth.
1352
1353         Bugs created by the commit-queue should all block on a master bug
1354         https://bugs.webkit.org/show_bug.cgi?id=50857
1355
1356         This makes all bugs created by the commit-queue block on:
1357         https://bugs.webkit.org/show_bug.cgi?id=50856
1358
1359         In the process of testing this, I found that the existing
1360         create_bug code was wrong.  I also found that existing
1361         unit tests for create-rollout used invalid values
1362         for options.blocks.  I fixed both issues and tested.
1363
1364         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1365         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1366         * Scripts/webkitpy/tool/commands/commandtest.py:
1367         * Scripts/webkitpy/tool/commands/download_unittest.py:
1368         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1369         * Scripts/webkitpy/tool/mocktool.py:
1370         * Scripts/webkitpy/tool/steps/options.py:
1371
1372 2010-12-10  Eric Seidel  <eric@webkit.org>
1373
1374         Reviewed by Adam Barth.
1375
1376         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
1377         https://bugs.webkit.org/show_bug.cgi?id=50853
1378
1379         I also discovered when doing this that the code was posting
1380         the comment on the wrong bug, but that's fixed here too.
1381
1382         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1383         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1384         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1385         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1386         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1387         * Scripts/webkitpy/tool/mocktool.py:
1388
1389 2010-12-10  Anders Carlsson  <andersca@apple.com>
1390
1391         Reviewed by John Sullivan.
1392
1393         Make WKContextGetStatistics gather global statistics
1394         https://bugs.webkit.org/show_bug.cgi?id=50850
1395
1396         Remove the code that gets the statistics and fills in the per context
1397         statistics information for now.
1398
1399         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1400         (-[BrowserStatisticsWindowController refreshStatistics:]):
1401
1402 2010-12-10  Eric Seidel  <eric@webkit.org>
1403
1404         Unreviewed.
1405
1406         commit-queue should report port/platform information when commenting on flaky test bugs
1407         https://bugs.webkit.org/show_bug.cgi?id=50839
1408
1409         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
1410         which was only used by new run webkit tests (and clearly not unit tested).
1411
1412         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
1413         * Scripts/webkitpy/tool/main.py:
1414         * Scripts/webkitpy/tool/mocktool.py:
1415
1416 2010-12-10  Eric Seidel  <eric@webkit.org>
1417
1418         Reviewed by Tony Chang.
1419
1420         commit-queue should report port/platform information when commenting on flaky test bugs
1421         https://bugs.webkit.org/show_bug.cgi?id=50839
1422
1423         This was a suggestion from Tony Chang this morning.
1424         I added a platform.py class so I could easily mock the platform call,
1425         but that may not be the final solution for this mocking.
1426         We'll try it and see.
1427
1428         * Scripts/webkitpy/common/system/platform.py: Added.
1429         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1430         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1431         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1432         * Scripts/webkitpy/tool/main.py:
1433         * Scripts/webkitpy/tool/mocktool.py:
1434
1435 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
1436
1437         Reviewed by Joseph Pecoraro.
1438
1439         Bug 43455 - [Qt]: Implement Application Cache Quotas
1440         https://bugs.webkit.org/show_bug.cgi?id=43455
1441
1442         Introduce functions to allow new appcache layout test origin-quota.html
1443         to work correctly under Qt.
1444
1445         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1446         (WebCore::DumpRenderTree::DumpRenderTree):
1447         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
1448         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1449
1450         Introduce functions to allow new appcache layout test origin-quota.html
1451         to be successful under qt. Changes required because LayoutTestControllerQt
1452         does not inherit from LayoutController.
1453
1454         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1455         (LayoutTestController::reset):
1456         (LayoutTestController::clearAllApplicationCaches):
1457         (LayoutTestController::setApplicationCacheOriginQuota):
1458         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1459         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
1460         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
1461
1462 2010-12-10  Eric Seidel  <eric@webkit.org>
1463
1464         Reviewed by Adam Barth.
1465
1466         Move buildbot.py into its own module so we can split it out into one-file-per-class
1467         https://bugs.webkit.org/show_bug.cgi?id=50806
1468
1469         We're adding more buildbot logic these days, so it makes sense
1470         to give buildbot its own module.
1471
1472         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
1473         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
1474         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
1475         * Scripts/webkitpy/common/net/failuremap.py:
1476         * Scripts/webkitpy/common/net/regressionwindow.py:
1477         * Scripts/webkitpy/tool/commands/rebaseline.py:
1478
1479 2010-12-10  Tony Chang  <tony@chromium.org>
1480
1481         Reviewed by Eric Seidel.
1482
1483         Use FileSystem::remove when cleaning up http lock files
1484         https://bugs.webkit.org/show_bug.cgi?id=50830
1485
1486         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1487
1488 2010-12-10  Joone Hur  <joone@kldp.org>
1489
1490         Reviewed by Martin Robinson.
1491
1492         [GTK] DRT needs layoutTestController.setCacheModel
1493         https://bugs.webkit.org/show_bug.cgi?id=50705
1494         
1495         webkit_set_cache_mode() is called to set the cache model.
1496         
1497         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1498         (LayoutTestController::setCacheModel): Set the cache model. 
1499
1500 2010-12-10  Tony Chang  <tony@chromium.org>
1501
1502         Reviewed by Ojan Vafai.
1503
1504         [chromium] remove --use-drt and add --use-test-shell
1505         https://bugs.webkit.org/show_bug.cgi?id=50701
1506
1507         * Scripts/webkitpy/common/config/ports.py:
1508         * Scripts/webkitpy/common/config/ports_unittest.py:
1509         * Scripts/webkitpy/layout_tests/port/chromium.py:
1510         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1511         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1512         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1513         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1514         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1515         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1516         * Scripts/webkitpy/layout_tests/port/webkit.py:
1517         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1518         * Scripts/webkitpy/style/checkers/test_expectations.py:
1519         * Scripts/webkitpy/tool/commands/queries.py:
1520
1521 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
1522
1523         Reviewed by Steve Block.
1524
1525         [Chromium] Implement mocks for client-based geolocation
1526         https://bugs.webkit.org/show_bug.cgi?id=46895
1527
1528         * DumpRenderTree/chromium/LayoutTestController.cpp:
1529         (LayoutTestController::setGeolocationPermission):
1530         (LayoutTestController::setMockGeolocationPosition):
1531         (LayoutTestController::setMockGeolocationError):
1532         * DumpRenderTree/chromium/LayoutTestController.h:
1533         * DumpRenderTree/chromium/WebViewHost.cpp:
1534         (WebViewHost::geolocationClient):
1535         (WebViewHost::geolocationClientMock):
1536         (WebViewHost::reset):
1537         * DumpRenderTree/chromium/WebViewHost.h:
1538
1539 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
1540
1541         Reviewed by Martin Robinson.
1542
1543         [GTK] Add hasSpellingMarker support to the DRT
1544         https://bugs.webkit.org/show_bug.cgi?id=50739
1545
1546         Implemented the hasSpellingMarker to support spelling tests.
1547
1548         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1549         (LayoutTestController::hasSpellingMarker):
1550
1551 2010-12-10  Eric Seidel  <eric@webkit.org>
1552
1553         Reviewed by Ojan Vafai.
1554
1555         webkit-patch: not possible to use build-and-test with local commits
1556         https://bugs.webkit.org/show_bug.cgi?id=33378
1557
1558         Make --no-clean not even check if we have local commits.
1559         It's unclear to me why the code was originally written this way.
1560         I was unable to dig up a reason from svn history.
1561
1562         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1563         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1564
1565 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
1566
1567         Reviewed by Martin Robinson.
1568
1569         [GTK] AX: implement isEnabled in DRT
1570         https://bugs.webkit.org/show_bug.cgi?id=50814
1571
1572         Implement AccessibilityUIElement::isEnabled() for GTK.
1573
1574         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1575         (checkElementState): New function to refactor common code.
1576         (AccessibilityUIElement::isEnabled): Implement this by checking
1577         the current state of the AtkObject.
1578         (AccessibilityUIElement::isSelected): Use the new
1579         checkElementState function.
1580
1581 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1582
1583         Reviewed by Kenneth Rohde Christiansen.
1584
1585         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
1586         https://bugs.webkit.org/show_bug.cgi?id=50750
1587
1588         * MiniBrowser/qt/BrowserView.cpp:
1589         (BrowserView::BrowserView):
1590         * MiniBrowser/qt/BrowserView.h:
1591         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1592         (WTR::WebView::WebView):
1593
1594 2010-12-10  Joone Hur  <joone@kldp.org>
1595
1596         Reviewed by Xan Lopez.
1597
1598         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
1599         https://bugs.webkit.org/show_bug.cgi?id=50808
1600
1601         Unskipping the following test cases:
1602         userscripts/mixed-case-stylesheet.html
1603         userscripts/simple-stylesheet.html
1604         userscripts/user-style-all-frames.html
1605
1606         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1607         (LayoutTestController::addUserStyleSheet):
1608
1609 2010-12-10  Joone Hur  <joone@kldp.org>
1610
1611         Reviewed by Eric Seidel.
1612
1613         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
1614         https://bugs.webkit.org/show_bug.cgi?id=50783
1615
1616         This patch allows to unskip the following test cases:
1617         printing/page-rule-selection.html
1618         printing/page-format-data.html
1619
1620         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1621         (LayoutTestController::pageProperty): Added.
1622         (LayoutTestController::isPageBoxVisible): Ditto.
1623         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
1624         (LayoutTestController::addUserStyleSheet): Ditto.
1625
1626 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1627
1628         Reviewed by Kenneth Rohde Christiansen.
1629
1630         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
1631
1632         A menu allows to switch QNAM back to the same thread.
1633
1634         * QtTestBrowser/launcherwindow.cpp:
1635         (LauncherWindow::initializeView):
1636         (LauncherWindow::createChrome):
1637         (LauncherWindow::toggleThreadedQnam):
1638         * QtTestBrowser/launcherwindow.h:
1639         (WindowOptions::WindowOptions):
1640         * QtTestBrowser/webpage.cpp:
1641         (WebPage::WebPage):
1642         (WebPage::setQnamThreaded):
1643         * QtTestBrowser/webpage.h:
1644         (QnamThread::QnamThread):
1645         (QnamThread::~QnamThread):
1646         (QnamThread::networkAccessManager):
1647         (QnamThread::run):
1648
1649 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
1650
1651         Reviewed by Xan Lopez.
1652
1653         [Gtk] style="font-family: courier" makes text disappear
1654         https://bugs.webkit.org/show_bug.cgi?id=47452
1655
1656         Add a test that verifies that fonts without valid charmaps are
1657         never selected.
1658
1659         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1660         (initializeFonts): Initialize DRT with our font (derived from Ahem)
1661         that has no valid charmap.
1662         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
1663         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
1664         settings which may disable selection of bitmap fonts.
1665
1666 2010-12-10  Eric Seidel  <eric@webkit.org>
1667
1668         Unreviewed.
1669
1670         The commit-queue should file bugs about flaky tests it encounters
1671         https://bugs.webkit.org/show_bug.cgi?id=50803
1672
1673         create_bug_for_flaky_test was insufficiently tested, thus buggy.
1674         Now it's tested.
1675
1676         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1677         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1678
1679 2010-12-10  Eric Seidel  <eric@webkit.org>
1680
1681         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
1682
1683         The commit-queue should file bugs about flaky tests it encounters
1684         https://bugs.webkit.org/show_bug.cgi?id=50803
1685
1686         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1687
1688 2010-12-09  Eric Seidel  <eric@webkit.org>
1689
1690         Reviewed by Adam Barth.
1691
1692         The commit-queue should file bugs about flaky tests it encounters
1693         https://bugs.webkit.org/show_bug.cgi?id=50803
1694
1695         This change got a bit big.  I also added a new config.urls file
1696         because I needed to share the view_source_url code with committervalidator.py.
1697
1698         This adds a new class FlakyTestReporter which holds all the logic about
1699         reporting flaky tests to bugzilla.
1700
1701         Right now this code knows how to look up bugs for flaky tests.
1702         If it can't find a bug filed from the commit-queue, it will open a new
1703         one, ccing the relevant people and adding information about the failure.
1704
1705         It is not yet smart enough to chase down duplicate chains, or to include
1706         the actual failure diff.  But those can be added in later iterations.
1707
1708         * Scripts/webkitpy/common/checkout/api.py:
1709         * Scripts/webkitpy/common/checkout/changelog.py:
1710         * Scripts/webkitpy/common/checkout/commitinfo.py:
1711         * Scripts/webkitpy/common/config/committervalidator.py:
1712         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1713         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1714         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
1715         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1716         * Scripts/webkitpy/tool/bot/irc_command.py:
1717         * Scripts/webkitpy/tool/bot/sheriff.py:
1718         * Scripts/webkitpy/tool/commands/download.py:
1719         * Scripts/webkitpy/tool/commands/queues.py:
1720         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1721         * Scripts/webkitpy/tool/comments.py:
1722         * Scripts/webkitpy/tool/mocktool.py:
1723         * Scripts/webkitpy/tool/steps/commit.py:
1724
1725 2010-12-09  Eric Seidel  <eric@webkit.org>
1726
1727         Reviewed by Adam Barth.
1728
1729         Teach webkit-patch how to search bugzilla
1730         https://bugs.webkit.org/show_bug.cgi?id=50500
1731
1732         This is a step towards teaching webkitpy how to file
1733         new bugs for flaky tests and update them when new flakes occur.
1734
1735         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1736         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1737         * Scripts/webkitpy/tool/commands/__init__.py:
1738         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
1739
1740 2010-12-09  Adam Barth  <abarth@webkit.org>
1741
1742         Reviewed by Ojan Vafai.
1743
1744         commit-queue errors out due to local commits
1745         https://bugs.webkit.org/show_bug.cgi?id=50766
1746
1747         We seem to be tripping over having local commits in the working copy a
1748         lot recently.  I don't quite fully understand what the issue is, but
1749         this patch attempts to solve the problem by adding an explicit clean
1750         step before processing a patch.  Previously, we did the cleaning as
1751         part of the apply-attachment step, so this might not actually fix the
1752         problem.
1753
1754         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1755         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1756         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1757
1758 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
1759
1760         Reviewed by Ojan Vafai.
1761
1762         Make new-run-webkit-tests --lint-test-files log slightly better
1763         messages and return -1 if lint fails. Remove the
1764         'suppress_errors' keyword param to the TestExpectationsFile
1765         class, and clean up logging and exception raising for error
1766         handling. Also add more unit tests and clean up the unit test code a bit.
1767
1768         https://bugs.webkit.org/show_bug.cgi?id=50205
1769
1770         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1771         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1772         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
1773         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
1774         * Scripts/webkitpy/layout_tests/port/chromium.py:
1775         * Scripts/webkitpy/style/checkers/test_expectations.py:
1776         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1777
1778 2010-12-09  Tony Chang  <tony@chromium.org>
1779
1780         Unreviewed, fix for windows code.  We were catching the wrong
1781         exception in Windows.
1782
1783         * Scripts/webkitpy/common/system/filesystem.py:
1784
1785 2010-12-09  Antonio Gomes  <agomes@rim.com>
1786
1787         Reviewed by Martin Robinson.
1788
1789         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
1790         https://bugs.webkit.org/show_bug.cgi?id=48429
1791
1792         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
1793
1794         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1795         (LayoutTestController::workerThreadCount):
1796
1797 2010-12-06  Philippe Normand  <pnormand@igalia.com>
1798
1799         Reviewed by Martin Robinson.
1800
1801         [GTK] Support the Mozilla-style Fullscreen Javascript API
1802         https://bugs.webkit.org/show_bug.cgi?id=50572
1803
1804         Enable the Javascript Fullscreen support in the GtkLauncher. Also
1805         make DRT update the Chrome when the WebView settings have been
1806         reset to consistent values.
1807
1808         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1809         (resetDefaultsToConsistentValues):
1810         * GtkLauncher/main.c:
1811         (create_window):
1812         * Scripts/build-webkit:
1813
1814 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
1815
1816         Reviewed by Tor Arne Vestbø
1817
1818         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
1819         https://bugs.webkit.org/show_bug.cgi?id=50742
1820
1821         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
1822
1823         * Scripts/webkitdirs.pm:
1824
1825 2010-12-09  Joone Hur  <joone@kldp.org>
1826
1827          Reviewed by Martin Robinson.
1828
1829          [GTK] Support for viewport meta tag
1830          https://bugs.webkit.org/show_bug.cgi?id=45443
1831
1832          Add support for testing the viewport properties for WebKitGtk.
1833
1834          * DumpRenderTree/LayoutTestController.cpp:
1835          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
1836          (LayoutTestController::staticFunctions):
1837          * DumpRenderTree/LayoutTestController.h:
1838          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1839          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
1840          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1841          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1842          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1843          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1844          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1845          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1846          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1847          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1848
1849 2010-12-08  William Siegrist <wsiegrist@apple.com>
1850
1851         Reviewed by Eric Seidel.
1852
1853         Migrate buildbot.py from xmlrpc to json.
1854         https://bugs.webkit.org/show_bug.cgi?id=50647
1855
1856         * Scripts/webkitpy/common/net/buildbot.py:
1857
1858 2010-12-08  Tony Chang  <tony@chromium.org>
1859
1860         Reviewed by Eric Seidel.
1861
1862         make starting the websocket server more reliable on windows
1863         https://bugs.webkit.org/show_bug.cgi?id=50712
1864
1865         * Scripts/webkitpy/common/system/filesystem.py:
1866         (remove): Substitute method for os.remove to retry on error on Windows
1867         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1868         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
1869
1870 2010-12-08  Jessie Berlin  <jberlin@apple.com>
1871
1872         Reviewed by Adam Roben.
1873
1874         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
1875         https://bugs.webkit.org/show_bug.cgi?id=50656
1876
1877         * MiniBrowser/mac/BrowserWindowController.m:
1878         (-[BrowserWindowController awakeFromNib]):
1879         Indicate that exceededDatabaseQuota is not implemented.
1880         * MiniBrowser/win/BrowserView.cpp:
1881         (BrowserView::create):
1882         Ditto.
1883         * WebKitTestRunner/TestController.cpp:
1884         (WTR::createOtherPage):
1885         Ditto.
1886         (WTR::TestController::initialize):
1887         Ditto.
1888
1889 2010-12-08  Antonio Gomes  <agomes@rim.com>
1890
1891         Reviewed by Martin Robinson.
1892
1893         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
1894         https://bugs.webkit.org/show_bug.cgi?id=48429
1895
1896         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
1897         * webkit_gc_collect_javascript_objects;
1898         * webkit_gc_collect_javascript_objects_on_alternate_thread;
1899         * webkit_gc_count_javascript_objects;
1900         * webkit_web_frame_layout.
1901
1902         These were all only used by GTK+ DRT.
1903
1904         * DumpRenderTree/gtk/EventSender.cpp:
1905         (dispatchEvent):
1906         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1907         (GCController::collect):
1908         (GCController::collectOnAlternateThread):
1909         (GCController::getJSObjectCount):
1910
1911 2010-12-07  Tony Chang  <tony@chromium.org>
1912
1913         Reviewed by Ojan Vafai.
1914
1915         [chromium] force NRWT to use DRT
1916         https://bugs.webkit.org/show_bug.cgi?id=50359
1917
1918         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1919
1920 2010-12-06  Sam Weinig  <sam@webkit.org>
1921
1922         Reviewed by Anders Carlsson.
1923
1924         Generalize didChangeLocationWithinPageForFrame for all same document navigations
1925         https://bugs.webkit.org/show_bug.cgi?id=50584
1926
1927         * MiniBrowser/mac/BrowserWindowController.m:
1928         (didSameDocumentNavigationForFrame):
1929         (-[BrowserWindowController awakeFromNib]):
1930         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
1931         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1932         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1933         (TestWebKitAPI::TEST):
1934         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1935         (WTR::InjectedBundlePage::InjectedBundlePage):
1936         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
1937         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1938         * WebKitTestRunner/TestController.cpp:
1939         (WTR::TestController::initialize):
1940
1941 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
1942
1943         Reviewed by Ojan Vafai.
1944
1945         Make TestResultsServer return 404 for non-existing results files.
1946         https://bugs.webkit.org/show_bug.cgi?id=50581
1947
1948         * TestResultServer/handlers/testfilehandler.py:
1949
1950 2010-12-06  Tony Chang  <tony@chromium.org>
1951
1952         Reviewed by Ojan Vafai.
1953
1954         [chromium] fix an assert hit in DRT
1955         https://bugs.webkit.org/show_bug.cgi?id=50575
1956
1957         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
1958         semantics.
1959
1960         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
1961         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
1962         WTF::RefCountedBase::ref()).
1963
1964         * DumpRenderTree/chromium/TestWebWorker.h:
1965         (TestWebWorker::TestWebWorker):
1966
1967 2010-12-02  Ojan Vafai  <ojan@chromium.org>
1968
1969         Reviewed by Eric Seidel.
1970
1971         make webkit-patch command work when the git branch is not synced to the remote svn branch
1972         https://bugs.webkit.org/show_bug.cgi?id=50424
1973
1974         * Scripts/webkitpy/common/checkout/scm.py:
1975         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1976
1977 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
1978
1979         Reviewed by Andreas Kling.
1980
1981         [WINCE] Add build system
1982         https://bugs.webkit.org/show_bug.cgi?id=50522
1983
1984         * CMakeListsWinCE.txt: Added.
1985
1986 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1987
1988         Reviewed by Tony Chang.
1989
1990         Allow the Chromium port to have Leopard-specific baselines
1991         https://bugs.webkit.org/show_bug.cgi?id=50506
1992
1993         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1994
1995 2010-12-03  Tony Chang  <tony@chromium.org>
1996
1997         Reviewed by Kent Tamura.
1998
1999         [chromium] fix 2 bugs with inspector tests in DRT
2000         https://bugs.webkit.org/show_bug.cgi?id=50492
2001
2002         Tasks can outlive the tasklist (even when canceled) so this was
2003         causing a crash when ~WebTask() ran.  Avoid this by unregistering
2004         when a task is canceled.
2005
2006         Also fix an assert when closing devtool windows by copying some
2007         logic from test_shell.
2008
2009         * DumpRenderTree/chromium/Task.cpp:
2010         (WebTask::~WebTask):
2011         (TaskList::revokeAll):
2012         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
2013             the tasklist (since the task can outlive the tasklist).
2014         * DumpRenderTree/chromium/TestShell.h:
2015         (TestShell::devToolsWebView):
2016         * DumpRenderTree/chromium/WebViewHost.cpp:
2017         (WebViewHost::~WebViewHost): Don't load about:blank when closing
2018             a window if the window has devtools loaded.  This avoids an
2019             ASSERT and matches test_shell.
2020
2021 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
2022
2023         Reviewed by Martin Robinson.
2024
2025         [GTK] Fix GtkLauncher.c style, use webkit style
2026         https://bugs.webkit.org/show_bug.cgi?id=50542
2027
2028         * GtkLauncher/main.c:
2029         (activateUriEntryCb):
2030         (updateTitle):
2031         (linkHoverCb):
2032         (notifyTitleCb):
2033         (notifyLoadStatusCb):
2034         (notifyProgressCb):
2035         (destroyCb):
2036         (goBackCb):
2037         (goForwardCb):
2038         (create_webViewCb):
2039         (webViewReadyCb):
2040         (closeWebViewCb):
2041         (createBrowser):
2042         (createStatusbar):
2043         (createToolbar):
2044         (createWindow):
2045         (main):
2046
2047 2010-12-04  Antonio Gomes  <agomes@rim.com>
2048
2049         Reviewed by Martin Robinson.
2050
2051         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
2052         https://bugs.webkit.org/show_bug.cgi?id=48429
2053
2054         Moved more private method declared with WEBKIT_API to
2055         DumpRenderTreeSupportGtk, since they were only being used by DRT.
2056
2057         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2058         (resetDefaultsToConsistentValues):
2059         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2060         (LayoutTestController::addOriginAccessWhitelistEntry):
2061         (LayoutTestController::execCommand):
2062         (LayoutTestController::isCommandEnabled):
2063
2064 2010-12-04  Antonio Gomes  <agomes@rim.com>
2065
2066         Reviewed by Andreas Kling.
2067
2068         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
2069
2070         Method was removed by http://trac.webkit.org/changeset/71604
2071
2072         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2073
2074 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
2075
2076         Reviewed by Xan Lopez.
2077
2078         [GTK] Fix compilation warnings reported by clang
2079         https://bugs.webkit.org/show_bug.cgi?id=50252
2080
2081         * GtkLauncher/main.c:
2082         (create_window): The create_statusbar function does not have
2083         parameters.
2084
2085 2010-12-05  Robert Hogan  <robert@webkit.org>
2086
2087         Reviewed by Andreas Kling.
2088
2089         [Qt] Zero-sized font does not yet work
2090
2091         Fix fast/text/font-size-zero.html
2092
2093         Copy other ports by setting minimumFontSize to 0 for DRT runs.
2094
2095         https://bugs.webkit.org/show_bug.cgi?id=49759
2096
2097         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2098         (WebCore::WebPage::WebPage):
2099
2100 2010-12-04  Sam Weinig  <sam@webkit.org>
2101
2102         Reviewed by Jon Honeycutt.
2103
2104         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
2105         https://bugs.webkit.org/show_bug.cgi?id=50511
2106
2107         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
2108         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
2109
2110         * MiniBrowser/mac/BrowserWindowController.m:
2111         (didChangeLocationWithinPageForFrame):
2112         (-[BrowserWindowController awakeFromNib]):
2113         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
2114         * TestWebKitAPI/PlatformUtilities.cpp:
2115         (TestWebKitAPI::Util::toWK):
2116         * TestWebKitAPI/PlatformUtilities.h:
2117         (TestWebKitAPI::Util::adoptWK):
2118         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2119         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
2120         (TestWebKitAPI::nullJavaScriptCallback):
2121         (TestWebKitAPI::didFinishLoadForFrame):
2122         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
2123         (TestWebKitAPI::TEST):
2124         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
2125         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2126         * TestWebKitAPI/win/copy-resources.cmd:
2127         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2128         (WTR::InjectedBundlePage::InjectedBundlePage):
2129         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2130         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2131         * WebKitTestRunner/TestController.cpp:
2132         (WTR::TestController::initialize):
2133
2134 2010-11-08  Antonio Gomes  <agomes@rim.com>
2135
2136         Reviewed by Martin Robinson.
2137
2138         [Gtk] Populate DumpRenderTreeSupportGtk
2139         https://bugs.webkit.org/show_bug.cgi?id=48429
2140
2141         Made the previous calls to webkit_web_frame* functions defined as private
2142         APIs in webkitprivate.h go through DRTSupportGtk.
2143
2144         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2145         (AccessibilityController::focusedElement):
2146         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2147         (dumpFramesAsText):
2148         (resetDefaultsToConsistentValues):
2149         (dump):
2150         (webViewDocumentLoadFinished):
2151         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2152         (LayoutTestController::counterValueForElementById):
2153         (LayoutTestController::pageNumberForElementById):
2154         (LayoutTestController::numberOfPages):
2155         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2156         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2157         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2158         (LayoutTestController::numberOfActiveAnimations):
2159         (LayoutTestController::suspendAnimations):
2160         (LayoutTestController::resumeAnimations):
2161         (LayoutTestController::markerTextForListItem):
2162
2163 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2164
2165         Reviewed by Tony Chang.
2166
2167         Rebaseline server: use pretty text diff output
2168         https://bugs.webkit.org/show_bug.cgi?id=50484
2169         
2170         Serve *-pretty-diff.html for text diff output.
2171
2172         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2173         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2174         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2175         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2176
2177 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2178
2179         Unreviewed, rolling out r73302.
2180         http://trac.webkit.org/changeset/73302
2181         https://bugs.webkit.org/show_bug.cgi?id=50499
2182
2183         Causes crashes in debug LayoutTests (Requested by xan_ on
2184         #webkit).
2185
2186         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2187         (AccessibilityUIElement::AccessibilityUIElement):
2188         (AccessibilityUIElement::parentElementCallback):
2189         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2190         * DumpRenderTree/chromium/CppBoundClass.cpp:
2191         * DumpRenderTree/chromium/CppBoundClass.h:
2192
2193 2010-12-03  Sam Weinig  <sam@webkit.org>
2194
2195         Reviewed by Maciej Stachowiak.
2196
2197         Enable <a ping> for Mac/Windows/WebKit2 builds
2198         <rdar://problem/8504473>
2199         https://bugs.webkit.org/show_bug.cgi?id=50488
2200
2201         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2202         (TestWebKitAPI::TEST): Test that the default value of
2203         WKPreferencesGetHyperlinkAuditingEnabled is true.
2204
2205 2010-12-03  Chris Guillory  <chris.guillory@google.com>
2206
2207         Reviewed by Chris Fleizach.
2208
2209         Include the FrameView widget of a RenderWidget in the accessibility tree.
2210         https://bugs.webkit.org/show_bug.cgi?id=49106
2211
2212         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2213         (AccessibilityUIElement::AccessibilityUIElement):
2214         (AccessibilityUIElement::parentElementCallback):
2215         (AccessibilityUIElement::isEqualCallback):
2216         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2217         * DumpRenderTree/chromium/CppBoundClass.cpp:
2218         (CppBoundClass::getFromCppVariant):
2219         * DumpRenderTree/chromium/CppBoundClass.h:
2220
2221 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2222
2223         Reviewed by Tony Chang.
2224
2225         Rebaseline server: organize tests by state, add dry run mode
2226         https://bugs.webkit.org/show_bug.cgi?id=50473
2227         
2228         Group tests in the menu by state, so that it's easier to see after
2229         processing the queue which failed.
2230         
2231         Add support for the --dry-run flag so that it's easier to test changes
2232         such as this (stubs out filesystem and SCM operations).
2233
2234         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2235         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2236         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2237
2238 2010-12-03  Brady Eidson  <beidson@apple.com>
2239
2240         Reviewed by Anders Carlsson.
2241
2242         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
2243         WebKit2 Authentication Support
2244
2245         Keep these builds working:
2246         * MiniBrowser/mac/BrowserWindowController.m:
2247         (-[BrowserWindowController awakeFromNib]):
2248
2249         * WebKitTestRunner/TestController.cpp:
2250         (WTR::TestController::initialize):
2251
2252 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
2253
2254         Reviewed by Tony Chang.
2255
2256         Rebaseline server: move existing baselines
2257         https://bugs.webkit.org/show_bug.cgi?id=50421
2258         
2259         Implement moving of existing baselines: move all files that are about
2260         to be overwriten by update baselines.
2261         
2262         Also fix a typo in the UI JS.
2263
2264         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2265         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2266         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2267
2268 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2269
2270         Unreviewed, rolling out r73211.
2271         http://trac.webkit.org/changeset/73211
2272         https://bugs.webkit.org/show_bug.cgi?id=50450
2273
2274         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
2275         yutak on #webkit).
2276
2277         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2278
2279 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2280
2281         Unreviewed, rolling out r73222.
2282         http://trac.webkit.org/changeset/73222
2283         https://bugs.webkit.org/show_bug.cgi?id=50449
2284
2285         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2286         (Requested by yutak on #webkit).
2287
2288         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2289         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2290         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2291         * Scripts/webkitpy/layout_tests/port/base.py:
2292         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2293         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2294
2295 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2296
2297         Unreviewed, rolling out r73228.
2298         http://trac.webkit.org/changeset/73228
2299         https://bugs.webkit.org/show_bug.cgi?id=50448
2300
2301         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2302         (Requested by yutak on #webkit).
2303
2304         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2305         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2306         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2307         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2308         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2309
2310 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2311
2312         Unreviewed, rolling out r73231.
2313         http://trac.webkit.org/changeset/73231
2314         https://bugs.webkit.org/show_bug.cgi?id=50443
2315
2316         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
2317         (Requested by yutak on #webkit).
2318
2319         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2320         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2321         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2322         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2323
2324 2010-12-03  David Levin  <levin@chromium.org>
2325
2326         Reviewed by Shinichiro Hamaji.
2327
2328         check-webkit-style: false positive reported for #if macro
2329         https://bugs.webkit.org/show_bug.cgi?id=48242
2330
2331         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
2332           all preprocessor commands.
2333         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
2334
2335 2010-12-02  Eric Seidel  <eric@webkit.org>
2336
2337         Reviewed by Adam Barth.
2338
2339         Update the EWSTools scripts to use modern-style git repos
2340         https://bugs.webkit.org/show_bug.cgi?id=50402
2341
2342         * EWSTools/create-webkit-git:
2343         * EWSTools/start-commit-queue.sh:
2344         * EWSTools/start-queue.sh:
2345
2346 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2347
2348         Fix Chromium Linux plugin tests by not logging
2349         unconditionally from the event handling code.
2350
2351         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2352         (handleEventX11):
2353
2354 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2355
2356         Reviewed by Tony Chang.
2357
2358         nrwt multiprocessing - move logic back into run_webkit_tests
2359
2360         This change moves a bunch of logic that I had put into
2361         message_broker back into run_webkit_tests, in a slightly
2362         different format. WorkerMessageBroker needed to become less aware of
2363         the logic the TestRunner class uses, and more generic.
2364         Eventually the MessageBroker will only do generic messaging and
2365         thread/process-pooling, and (almost) all of the
2366         run-webkit-tests-specific logic will be moved to
2367         run_webkit_tests.py and dump_render_tree_thread.py.
2368         
2369         The biggest changes are that the Broker can now start a single
2370         worker, but the responsibility for starting all of them is pushed
2371         back to the TestRunner (Manager), and the logic for checking if
2372         the threads are done or wedged is moved back to TestRunner. We
2373         also remove WorkerMessageBroker.cleanup (not needed) and
2374         cancel_workers (they have to be cancelled individually).
2375         
2376         The  message_broker is now encapsulated inside
2377         TestRunner._run_tests(); it only needs to exist while actually
2378         running the tests.
2379
2380         Also, delete a bunch of tests in message_broker_unittest that no
2381         longer make much sense.
2382
2383         This patch depends on bug 50372.
2384
2385         https://bugs.webkit.org/show_bug.cgi?id=50374
2386
2387         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2388         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2389         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2390         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2391         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2392
2393 2010-12-02  Hayato Ito  <hayato@chromium.org>
2394
2395         Reviewed by Eric Seidel.
2396
2397         Refactor test_types's compare_output() method so that it takes a
2398         TestInput object.
2399
2400         compare_output() will need additional information included in a TestInput
2401         object to support reftests. This change is a pre-requirement of that.
2402
2403         https://bugs.webkit.org/show_bug.cgi?id=50362
2404
2405         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2406         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2407         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2408         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2409         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2410
2411 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2412
2413         Reviewed by Anders Carlsson.
2414
2415         Add the ability to run script on 'new' and 'paint' in the test plugin
2416         https://bugs.webkit.org/show_bug.cgi?id=50425
2417         
2418         Add "onnew" and "onpaintevent" attributes to the test plugin,
2419         so that tests can run JS at these times.
2420
2421         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2422         (pluginAllocate):
2423         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2424         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2425         (NPP_New):
2426         (NPP_Destroy):
2427         (handleEventCarbon):
2428         (handleEventCocoa):
2429         (NPP_HandleEvent):
2430
2431 2010-12-02  Sam Weinig  <sam@webkit.org>
2432
2433         Fix Qt build.
2434
2435         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2436         (WTR::PlatformWebView::PlatformWebView):
2437
2438 2010-12-02  Sam Weinig  <sam@webkit.org>
2439
2440         Reviewed by Anders Carlsson.
2441
2442         WebKit2 Preferences should be held off the PageGroup, not the Context
2443         https://bugs.webkit.org/show_bug.cgi?id=50414
2444
2445         Update for API changes.
2446
2447         * WebKitTestRunner/PlatformWebView.h:
2448         * WebKitTestRunner/TestController.cpp:
2449         (WTR::createOtherPage):
2450         (WTR::TestController::initialize):
2451         (WTR::TestController::resetStateToConsistentValues):
2452         * WebKitTestRunner/TestController.h:
2453         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2454         (WTR::PlatformWebView::PlatformWebView):
2455         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2456         (WTR::PlatformWebView::PlatformWebView):
2457
2458 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2459
2460         Reviewed by Tony Chang.
2461
2462         new-run-webkit-tests: minor cleanup for multiprocessing work
2463
2464         This change:
2465         * moves worker naming into TestShellThread, eliminating a
2466           parameter to the constructor and putting the responsibility in
2467           the correct place.
2468         * eliminates the _WorkerState() class in message_broker, because
2469           it turns out that state really needs to be in run_webkit_tests
2470         * renames the Broker classes to be module-private.
2471         * fixes a bunch of minor commenting and whitespace issues to
2472           make subsequent patches a bit clearer.
2473         * Adds a Port hook for default_worker_model() so that we can
2474           accomodate the potential for different worker models on
2475           different ports.
2476         * merge in the fix from 50420 for the brokenness introduced in
2477           bug 50367.
2478
2479         This patch depends on bug 50367.
2480
2481         https://bugs.webkit.org/show_bug.cgi?id=50372
2482
2483         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2484         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2485         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2486         * Scripts/webkitpy/layout_tests/port/base.py:
2487         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2488         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2489
2490 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2491
2492         Reviewed by Tony Chang.
2493
2494         This change is a bunch of cleanup / refactoring of the file
2495         below. It moves a bunch of free functions to methods on the
2496         TestShellThread class, and restructures other methods to be
2497         closer to the structure we'll need for the multiprocessing
2498         rewrite.
2499
2500         It also makes the logic of --run-singly a *lot* easier to follow
2501         by nestling all of the separate-thread logic into a single
2502         routine.
2503
2504         There should be no semantic changes in this patch, just cleanup.
2505
2506         https://bugs.webkit.org/show_bug.cgi?id=50367
2507
2508         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2509
2510 2010-12-02  Tony Chang  <tony@chromium.org>
2511
2512         Unreviewed, rolling out r73164.
2513         http://trac.webkit.org/changeset/73164
2514         https://bugs.webkit.org/show_bug.cgi?id=50359
2515
2516         broke debugger tests on win
2517
2518         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2519
2520 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2521
2522         Reviewed by Tony Chang.
2523
2524         Rebaseline server: add updating of baselines
2525         https://bugs.webkit.org/show_bug.cgi?id=50305
2526         
2527         Implements updating of baselines, where we copy -actual.* files over
2528         the current -expected.* files. To do this, we need a
2529         _get_actual_result_files method to get test results files and a
2530         _rebaseline_test method to actually do the file copy and SCM operation.
2531         _rebaseline_test logs output into a buffer, this is useful for both
2532         showing result in the UI and for unit tests.
2533         
2534         To make passing around of the various test environment properties
2535         (results directory, filesystem, SCM, etc) easier, add a TestConfig
2536         class for them.
2537         
2538         Moving of existing baselines is not implemented yet, this patch is big
2539         enough as it is.
2540
2541         * Scripts/webkitpy/common/system/filesystem.py:
2542         * Scripts/webkitpy/common/system/filesystem_mock.py:
2543         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2544         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2545         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2546         * Scripts/webkitpy/tool/mocktool.py:
2547
2548 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
2549
2550         Unreviewed build fix after vcproj updates.
2551
2552         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
2553         that WIN_CAIRO is defined for this build.
2554         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
2555         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
2556         (these were previously 'Debug_Cairo' and 'Release_Cairo'
2557
2558 2010-12-02  Sam Weinig  <sam@webkit.org>
2559
2560         Reviewed by Anders Carlsson.
2561
2562         WebKit2 needs API to turn on popup blocking
2563         https://bugs.webkit.org/show_bug.cgi?id=50407
2564
2565         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2566         (TestWebKitAPI::TEST):
2567         * WebKitTestRunner/TestController.cpp:
2568         (WTR::TestController::resetStateToConsistentValues):
2569
2570 2010-12-01  Tony Chang  <tony@chromium.org>
2571
2572         Reviewed by Ojan Vafai.
2573
2574         [chromium] force NRWT to use DRT
2575         https://bugs.webkit.org/show_bug.cgi?id=50359
2576
2577         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2578
2579 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
2580
2581         Reviewed by Xan Lopez.
2582
2583         [GTK] DumpRenderTree has two copies of JavaScriptCore
2584         https://bugs.webkit.org/show_bug.cgi?id=49877
2585
2586         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
2587         LDADD list for DumpRenderTree.
2588
2589 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
2590
2591         Unreviewed: Added myself to list of Committers.
2592
2593         * Scripts/webkitpy/common/config/committers.py:
2594
2595 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
2596
2597         Reviewed by Adam Barth.
2598
2599         build-webkit --chromium always updates DEPS and re-generates project files
2600         https://bugs.webkit.org/show_bug.cgi?id=50340
2601         
2602         Make build-webkit --chromium invoke update-webkit-chromium only when
2603         --update-chromium is passed in, so that we don't add 20 seconds to all
2604         builds.
2605         
2606         Making all invocations update was added with r61883, with the goal of
2607         making EWS bots always update. The bots will switch to using this flag
2608         (as will all other webkit-patch build steps) so nothing should change
2609         for them.
2610
2611         * Scripts/webkitdirs.pm:
2612         * Scripts/webkitpy/common/config/ports.py:
2613         * Scripts/webkitpy/common/config/ports_unittest.py:
2614
2615 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
2616
2617         Reviewed by Tony Chang.
2618
2619         new-run-webkit-tests: add a --dry-run / -n flag
2620         https://bugs.webkit.org/show_bug.cgi?id=50045
2621
2622         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2623         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2624
2625 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2626
2627         Reviewed by Adam Roben.
2628
2629         WinCairo build should not use link-time code generation (LTCG)
2630         https://bugs.webkit.org/show_bug.cgi?id=50353
2631
2632         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2633         * DumpRenderTree/win/DumpRenderTree.vcproj:
2634         * DumpRenderTree/win/ImageDiff.vcproj:
2635         * FindSafari/FindSafari.vcproj:
2636         * MiniBrowser/MiniBrowser.vcproj:
2637         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2638         * WebKitAPITest/WebKitAPITest.vcproj:
2639         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2640         * WebKitTestRunner/win/InjectedBundle.vcproj:
2641         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2642         * WinLauncher/WinLauncher.vcproj:
2643         * record-memory-win/record-memory-win.vcproj:
2644
2645 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2646
2647         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
2648         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
2649         adding the file to the sources list was not enough to force the rebuild.
2650
2651         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
2652         Remove an empty line at the end of this file to force a rebuild.
2653
2654 2010-12-01  Sam Weinig  <sam@webkit.org>
2655
2656         Fix windows build.
2657
2658         * MiniBrowser/win/BrowserView.cpp:
2659         (BrowserView::create):
2660
2661 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2662
2663         Add missing file to the TestNetscapePlugin sources list after r73057.
2664
2665         * GNUmakefile.am: Add missing file.
2666
2667 2010-12-01  Sam Weinig  <sam@webkit.org>
2668
2669         Reviewed by Anders Carlsson.
2670
2671         Add PageGrouping to WebKit2 API
2672         https://bugs.webkit.org/show_bug.cgi?id=50332
2673
2674         - Update testing harnesses to deal with new PageGroup API.
2675
2676         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2677         (WKBundleInitialize):
2678         * TestWebKitAPI/InjectedBundleController.cpp:
2679         (TestWebKitAPI::InjectedBundleController::initialize):
2680         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
2681         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
2682         * TestWebKitAPI/InjectedBundleController.h:
2683         * TestWebKitAPI/InjectedBundleTest.h:
2684         (TestWebKitAPI::InjectedBundleTest::initialize):
2685         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
2686         * TestWebKitAPI/PlatformUtilities.cpp:
2687         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2688         * TestWebKitAPI/PlatformUtilities.h:
2689         * TestWebKitAPI/PlatformWebView.h:
2690         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2691         (TestWebKitAPI::TEST):
2692         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2693         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2694         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2695         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2696         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2697         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2698         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2699         (WTR::InjectedBundle::didInitializePageGroup):
2700         (WTR::InjectedBundle::initialize):
2701         (WTR::InjectedBundle::beginTesting):
2702         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2703         (WTR::InjectedBundle::pageGroup):
2704         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2705         (WTR::LayoutTestController::addUserScript):
2706         (WTR::LayoutTestController::addUserStyleSheet):
2707         (WTR::LayoutTestController::setXSSAuditorEnabled):
2708         * WebKitTestRunner/TestController.cpp:
2709         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2710         (WTR::PlatformWebView::PlatformWebView):
2711
2712 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2713
2714         Reviewed by Adam Roben.
2715
2716         vcproj changes can't be applied cleanly by the Windows EWS bot
2717         https://bugs.webkit.org/show_bug.cgi?id=50328
2718
2719         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2720         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
2721         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2722         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
2723         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
2724         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
2725         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
2726         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
2727         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
2728         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
2729         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
2730         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
2731         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
2732         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2733         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
2734         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
2735         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
2736         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
2737         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
2738         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
2739         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
2740         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
2741         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
2742         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
2743         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
2744         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
2745         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
2746         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
2747         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
2748         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
2749         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
2750         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
2751         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
2752         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
2753         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
2754         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
2755         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
2756         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
2757         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
2758         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
2759         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
2760         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
2761         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
2762         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
2763         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
2764
2765 2010-12-01  Anders Carlsson  <andersca@apple.com>
2766
2767         Reviewed by Darin Adler.
2768
2769         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
2770         https://bugs.webkit.org/show_bug.cgi?id=50336
2771
2772         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2773         Add new test.
2774
2775         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2776         (PluginTest::NPP_New):
2777         Add default implementation/
2778
2779         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2780         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
2781         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
2782         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
2783         Get the user agent.
2784
2785         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2786         (NPP_New):
2787         Call PluginTest::NPP_New.
2788
2789         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2790         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2791         Add new files.
2792
2793         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2794         (webkit_test_plugin_new_instance):
2795         Call PluginTest::NPP_New.
2796
2797 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
2798
2799         [wx] Build fixes after recent trunk changes.
2800
2801         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2802         (LayoutTestController::findString):
2803         * wx/build/settings.py:
2804
2805 2010-12-01  Dan Bernstein  <mitz@apple.com>
2806
2807         Reviewed by Darin Adler.
2808
2809         WebKitTestRunner needs layoutTestController.findString
2810         https://bugs.webkit.org/show_bug.cgi?id=50238
2811
2812         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
2813         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2814         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
2815         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2816
2817 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2818
2819         Try using svn:eol-style native on a vcproj file.
2820
2821         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
2822
2823 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
2824
2825         Reviewed by Adam Roben.
2826
2827         [WINCE] Add WinCELauncher
2828         https://bugs.webkit.org/show_bug.cgi?id=50217
2829
2830         * WinCELauncher/main.cpp: Added.
2831
2832 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
2833
2834         Reviewed by Kenneth Rohde Christiansen.
2835
2836         [Qt] Implement layoutTestController.findString
2837         https://bugs.webkit.org/show_bug.cgi?id=50236
2838
2839         Add the missing function to the LayoutTestController.
2840
2841         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2842         (LayoutTestController::findString):
2843         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2844
2845 2010-11-30  Tony Chang  <tony@chromium.org>
2846
2847         Reviewed by Adam Barth.
2848
2849         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
2850         https://bugs.webkit.org/show_bug.cgi?id=49036
2851
2852         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
2853             for CppVariants.
2854         (LayoutTestController::cppVariantToBool):
2855         (LayoutTestController::cppVariantToInt32):
2856         (LayoutTestController::setDatabaseQuota):
2857         (LayoutTestController::evaluateInWebInspector):
2858         (LayoutTestController::setMockGeolocationError):
2859
2860 2010-11-30  Eric Seidel  <eric@webkit.org>
2861
2862         Reviewed by Tony Chang.
2863
2864         update-webkit should call git fetch before git svn rebase
2865         https://bugs.webkit.org/show_bug.cgi?id=50273
2866
2867         After discussion on webkit-dev, we've decided to move the "default"
2868         git setup to pulling updates from git.webkit.org in preference
2869         to rebuilding the local svn index using git svn fetch every time.
2870
2871         This change should have no effect on people using the "old" git setup
2872         and should dramatically increase the speed of updates for those using
2873         the "new" git setup along with update-webkit.  I'm about to move the
2874         EWS and other queues over to this setup once this lands.
2875
2876         * Scripts/update-webkit:
2877
2878 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
2879
2880         Reviewed by Xan Lopez.
2881
2882         GTK: AX: implement press in DRT
2883         https://bugs.webkit.org/show_bug.cgi?id=36146
2884
2885         Implement AccessibilityUIElement::press() for GTK.
2886
2887         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2888         (AccessibilityUIElement::press): Implemented.
2889
2890 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
2891
2892         Reviewed by Tony Chang.
2893
2894         config.webkit_base_dir returns a path with a trailing slash
2895         https://bugs.webkit.org/show_bug.cgi?id=50197
2896         
2897         config.webkit_base_dir() should return a path without a trailing slash,
2898         like all the other methods that return paths.
2899         
2900         Undoes MockFileSytem changes by r72640, since they're no longer
2901         necessary for GetBaselinesTest to pass.
2902
2903         * Scripts/webkitpy/common/system/filesystem_mock.py:
2904         * Scripts/webkitpy/layout_tests/port/base.py:
2905         * Scripts/webkitpy/layout_tests/port/config.py:
2906         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2907
2908 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2909
2910         Reviewed by Tony Chang.
2911
2912         Rebaseline server: baseline display tweaks
2913         https://bugs.webkit.org/show_bug.cgi?id=50207
2914         
2915         Determine which baselines were used when running the tests and highlight
2916         them in the UI. Sort platform names alphabetically.
2917         
2918         Also makes the server URL be launched in the user's browser
2919         automatically.
2920
2921         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2922         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2923         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2924         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2925         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2926
2927 2010-11-30  Dan Bernstein  <mitz@apple.com>
2928
2929         Reviewed by Anders Carlsson.
2930
2931         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
2932         https://bugs.webkit.org/show_bug.cgi?id=50238
2933
2934         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2935         (WTR::LayoutTestController::findString): Added.
2936         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2937
2938 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
2939
2940         Reviewed by Adam Roben.
2941
2942         All projects on Windows should use cmd files for build events
2943         https://bugs.webkit.org/show_bug.cgi?id=50213
2944
2945         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2946         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
2947         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
2948         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2949         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
2950         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
2951         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2952         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
2953         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
2954         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
2955         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2956         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
2957         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
2958         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
2959         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2960         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
2961         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
2962         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2963         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
2964         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
2965         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2966         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2967         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
2968         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
2969         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
2970         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
2971         * WinLauncher/WinLauncherCommon.vsprops:
2972         * WinLauncher/WinLauncherPostBuild.cmd: Added.
2973         * WinLauncher/WinLauncherPreBuild.cmd: Added.
2974
2975 2010-11-29  Dan Bernstein  <mitz@apple.com>
2976
2977         GTK DumpRenderTree build fix after r72887.
2978
2979         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2980         (LayoutTestController::findString):
2981
2982 2010-11-29  Dan Bernstein  <mitz@apple.com>
2983
2984         Windows DumpRenderTree build fix after r72887.
2985
2986         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2987         (LayoutTestController::findString): Added empty implementation.
2988
2989 2010-11-29  Dan Bernstein  <mitz@apple.com>
2990
2991         Reviewed by Darin Adler.
2992
2993         DumpRenderTree changes for testing the text search API.
2994         https://bugs.webkit.org/show_bug.cgi?id=50038
2995
2996         * DumpRenderTree/LayoutTestController.cpp:
2997         (findStringCallback):
2998         (LayoutTestController::staticFunctions):
2999         * DumpRenderTree/LayoutTestController.h:
3000         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3001         (LayoutTestController::findString):
3002         * MiniBrowser/mac/BrowserWindowController.m:
3003         (-[BrowserWindowController find:]):
3004
3005 2010-11-29  Johnny Ding  <jnd@chromium.org>
3006
3007         Unreviewed: Add myself to the list of Committers.
3008
3009         * Scripts/webkitpy/common/config/committers.py:
3010
3011 2010-11-29  Mark Rowe  <mrowe@apple.com>
3012
3013         Reviewed by Adele Peterson.
3014
3015         <rdar://problem/8694997> DumpRenderTree fails to build.
3016
3017         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
3018
3019 2010-11-29  Mark Rowe  <mrowe@apple.com>
3020
3021         Reviewed by Adele Peterson.
3022
3023         <rdar://problem/8694997> DumpRenderTree fails to build.
3024
3025         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
3026         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
3027         * DumpRenderTree/mac/PerlSupport/Makefile:
3028
3029 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
3030
3031         Reviewed by Martin Robinson.
3032
3033         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
3034         https://bugs.webkit.org/show_bug.cgi?id=50154
3035
3036         Added missing checks to allAttributes().
3037
3038         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3039         (AccessibilityUIElement::allAttributes): Added missing checks.
3040
3041 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3042
3043         Reviewed by Kenneth Rohde Christiansen.
3044
3045         [Qt] Allow pre-generation for package builds for WebKit2
3046         https://bugs.webkit.org/show_bug.cgi?id=50139
3047
3048         Use a build variable for the generated directory path and set the
3049         value based on CONFIG just like for WebKit1.
3050
3051         For non-package builds use a relative base path for the
3052         genrated directory just like for WebKit1.
3053
3054         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3055         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3056
3057 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3058
3059         Reviewed by Kenneth Rohde Christiansen.
3060
3061         [Qt] Move some build logic from Qt to platform independent code
3062         https://bugs.webkit.org/show_bug.cgi?id=50134
3063
3064         Create target directories inside generate-forwarding-headers.pl.
3065
3066         * Scripts/generate-forwarding-headers.pl:
3067
3068 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
3069
3070         Reviewed by Martin Robinson.
3071
3072         [GTK] Windowless plugins gets broken key input
3073         https://bugs.webkit.org/show_bug.cgi?id=49927
3074
3075         Convert the XEvent::keycode to ASCII before printing it. Not
3076         doing this was causing false positive in 
3077         plugins/keyboard-events.html.
3078
3079         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3080         (keycode_to_char):
3081         (webkit_test_plugin_handle_event):
3082
3083 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
3084
3085         Reviewed by Antonio Gomes.
3086
3087         [Qt] Html autofocus not working with QGraphicsWebView
3088         https://bugs.webkit.org/show_bug.cgi?id=43169
3089
3090         Tell the scene to set the webview item as the currently
3091         focused item. This makes the input field with autofocus get
3092         focus as it should.
3093
3094         * QtTestBrowser/webview.cpp:
3095         (WebViewGraphicsBased::WebViewGraphicsBased):
3096
3097 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3098
3099         Reviewed by Tony Chang.
3100
3101         nrwt - clean up create_driver interface and print out the
3102         command line used for DumpRenderTree/TestShell.
3103
3104         This patch adds a driver_cmd_line() call to the Port class in
3105         order to retrive the command line to print it out (as part of
3106         --print config).
3107
3108         In addition, this patch cleans up the Port.create_driver()
3109         signature and the Driver constructor interface to take a worker
3110         number and no longer require the image_path argument (Chromium's
3111         drivers now synthesize the image_path from the worker number
3112         internally).
3113
3114         https://bugs.webkit.org/show_bug.cgi?id=49934
3115
3116         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3117         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3118         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3119         * Scripts/webkitpy/layout_tests/port/base.py:
3120         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3121         * Scripts/webkitpy/layout_tests/port/chromium.py:
3122         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3123         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3124         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3125         * Scripts/webkitpy/layout_tests/port/test.py:
3126         * Scripts/webkitpy/layout_tests/port/webkit.py:
3127         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3128         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3129
3130 2010-11-24  Ojan Vafai  <ojan@chromium.org>
3131
3132         Reviewed by Tony Chang.
3133
3134         [chromium] improve memory usage for test results server and store fewer runs
3135         https://bugs.webkit.org/show_bug.cgi?id=50035
3136
3137         Store fewer runs and don't pass full files around when we only need bools.
3138         Greatly improves error rates on test-results.appspot.com.
3139
3140         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3141         * TestResultServer/handlers/testfilehandler.py:
3142         * TestResultServer/model/dashboardfile.py:
3143         * TestResultServer/model/jsonresults.py:
3144
3145 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3146
3147         Reviewed by Tony Chang.
3148
3149         This patch implements the first part of the manager side of the
3150         Broker objects - it handles creating threads, waiting for them
3151         to complete, and running a single-threaded loop as well.
3152
3153         https://bugs.webkit.org/show_bug.cgi?id=49779
3154
3155         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3156         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3157         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3158         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3159
3160 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
3161
3162         Reviewed by David Levin.
3163
3164         DRT should not generate pixel output for text/plain tests
3165         https://bugs.webkit.org/show_bug.cgi?id=50002
3166         
3167         Modify Mac, Windows and GTK DRT implementations to disable pixel output
3168         when encountering a text/plain response (the Chromium one already does
3169         this, and none of the other ports special-case text/plain output in
3170         the first place).
3171
3172         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3173         (dump):
3174         * DumpRenderTree/mac/DumpRenderTree.mm:
3175         (dump):
3176         * DumpRenderTree/win/DumpRenderTree.cpp:
3177         (dump):
3178
3179 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3180
3181         Unreviewed.
3182
3183         Add my other email address to committers.py.
3184
3185         * Scripts/webkitpy/common/config/committers.py:
3186
3187 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3188
3189         Reviewed by Csaba Osztrogonác.
3190
3191         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
3192         https://bugs.webkit.org/show_bug.cgi?id=49975
3193
3194         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
3195         to enable the script to define it 0 in case of a minimal build.
3196
3197 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
3198
3199         Reviewed by Xan Lopez.
3200
3201         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
3202         https://bugs.webkit.org/show_bug.cgi?id=49143
3203
3204         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3205         (createWebView): Call the new connectEditingCallbacks function.
3206         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
3207         (dumpNodePath):
3208         (dumpRange):
3209         (insertActionString):
3210         (selectionAffinityString):
3211         (shouldBeginEditing):
3212         (shouldEndEditing):
3213         (shouldInsertNode):
3214         (shouldInsertText):
3215         (shouldDeleteRange):
3216         (shouldShowDeleteInterfaceForElement):
3217         (shouldChangeSelectedRange):
3218         (shouldApplyStyle):
3219         (editingBegan):
3220         (userChangedContents):
3221         (editingEnded):
3222         (selectionChanged):
3223         (connectEditingCallbacks):
3224         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
3225         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
3226
3227 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
3228
3229         Reviewed by Andreas Kling.
3230
3231         [Qt] Make QtTestBrowser remember the selected user agent
3232         https://bugs.webkit.org/show_bug.cgi?id=50021
3233
3234         Set user agent for a new page by using the old page's
3235
3236         * QtTestBrowser/mainwindow.cpp:
3237         (MainWindow::setPage):
3238
3239 2010-11-24 Patrick Gansterer <paroga@webkit.org>
3240
3241         Reviewed by Csaba Osztrogonác.
3242
3243         Remove Bakefile build system files
3244         https://bugs.webkit.org/show_bug.cgi?id=49983
3245
3246         r53757 only removed the content, but not the files.
3247         This patch removes that empty files.
3248
3249         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
3250         * wx/browser/browser.bkl: Removed.
3251         * wx/build-wxwebkit: Removed.
3252
3253 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
3254
3255         Reviewed by Tony Chang.
3256
3257         This patch cleans up the logic used to shard tests into groups a
3258         bit and adds the --worker-model flag to NRWT. The flag is only
3259         used at the moment to control whether to run single-threaded or
3260         not, but eventually will also allow toggling between threads and
3261         processes.
3262
3263         Also add a minor cleanup with _test_is_slow(), which just
3264         eliminates some repetition and gives slightly better encapsulation.
3265
3266         https://bugs.webkit.org/show_bug.cgi?id=49773
3267
3268         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3269         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3270
3271 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
3272
3273         Reviewed by Tony Chang.
3274
3275         Rebaseline server: list current baselines and platforms
3276         https://bugs.webkit.org/show_bug.cgi?id=49991
3277         
3278         List existing baselines (with Trac links) for tests.
3279         
3280         Add dropdowns for choosing with platform baselines to target (and what
3281         to do with existing ones).
3282
3283         Also fix MockFileSystem.join to behave more like os.path.join (unit
3284         test was ending up with two consecutive slashes in a layout test
3285         path).        
3286
3287         * Scripts/webkitpy/common/system/filesystem_mock.py:
3288         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3289         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3290         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3291         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
3292         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3293         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3294         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
3295
3296 2010-11-23  Ojan Vafai  <ojan@chromium.org>
3297
3298         Reviewed by Tony Chang.
3299
3300         remove timeout argument to urlopen
3301         https://bugs.webkit.org/show_bug.cgi?id=49995
3302
3303         Apparently the version of python we have on the bots doesn't accept a timeout argument.
3304
3305         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3306
3307 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3308
3309         Unreviewed, rolling out r72628.
3310         http://trac.webkit.org/changeset/72628
3311         https://bugs.webkit.org/show_bug.cgi?id=49994
3312
3313         This patch is causing layout-test failtures on GTK Linux
3314         64-bit Debug (Requested by ctguil on #webkit).
3315
3316         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3317         (AccessibilityUIElement::AccessibilityUIElement):
3318         (AccessibilityUIElement::parentElementCallback):
3319         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3320         * DumpRenderTree/chromium/CppBoundClass.cpp:
3321         * DumpRenderTree/chromium/CppBoundClass.h:
3322
3323 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3324
3325         Reviewed by Tony Chang.
3326
3327         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
3328         https://bugs.webkit.org/show_bug.cgi?id=49944
3329
3330         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3331
3332 2010-11-23  Chris Guillory  <chris.guillory@google.com>
3333
3334         Reviewed by Dimitri Glazkov.
3335
3336         Include the FrameView widget of a RenderWidget in the accessibility tree.
3337         https://bugs.webkit.org/show_bug.cgi?id=49106
3338
3339         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3340         (AccessibilityUIElement::AccessibilityUIElement):
3341         (AccessibilityUIElement::parentElementCallback):
3342         (AccessibilityUIElement::isEqualCallback):
3343         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3344         * DumpRenderTree/chromium/CppBoundClass.cpp:
3345         (CppBoundClass::getFromCppVariant):
3346         * DumpRenderTree/chromium/CppBoundClass.h:
3347
3348 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
3349
3350         Reviewed by Kenneth Rohde Christiansen.
3351
3352         [EFL] Add tiled backing store to EWebLauncher
3353         https://bugs.webkit.org/show_bug.cgi?id=45777
3354
3355         Allow EWebLauncher to choose between single and tiled backing store
3356
3357         * EWebLauncher/main.c:
3358         (on_key_down):
3359         (browserCreate):
3360         (main):
3361
3362 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3363
3364         Reviewed by Tor Arne Vestbø.
3365
3366         [Qt] Review the setUserPermission & friends API
3367         https://bugs.webkit.org/show_bug.cgi?id=46810
3368
3369         Renamed requestPermissionFromUser to featurePermissionRequested
3370         and cancelRequestsForPermission to featurePermissionRequestCanceled.
3371
3372         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3373         (WebCore::WebPage::WebPage):
3374         * QtTestBrowser/webpage.cpp:
3375         (WebPage::WebPage):
3376         (WebPage::featurePermissionRequestCanceled):
3377         * QtTestBrowser/webpage.h:
3378
3379 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3380
3381         Reviewed by Tor Arne Vestbø.
3382
3383         [Qt] Review the setUserPermission & friends API
3384         https://bugs.webkit.org/show_bug.cgi?id=46810
3385
3386         Rename setUserPermission to setFeaturePermission
3387
3388         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3389         (WebCore::WebPage::requestPermission):
3390         (WebCore::WebPage::permissionSet):
3391         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3392         (LayoutTestController::grantDesktopNotificationPermission):
3393         * QtTestBrowser/webpage.cpp:
3394         (WebPage::requestPermission):
3395
3396 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3397
3398         Reviewed by Tor Arne Vestbø.
3399
3400         [Qt] Review the setUserPermission & friends API
3401         https://bugs.webkit.org/show_bug.cgi?id=46810
3402
3403         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
3404         and GeolocationPermissionDomain to Geolocation.
3405
3406         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3407         (WebCore::WebPage::WebPage):
3408         (WebCore::WebPage::requestPermission):
3409         (WebCore::WebPage::cancelPermission):
3410         (WebCore::WebPage::permissionSet):
3411         (WebCore::DumpRenderTree::geolocationPermissionSet):
3412         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3413         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3414         (LayoutTestController::grantDesktopNotificationPermission):
3415         * QtTestBrowser/webpage.cpp:
3416         (WebPage::WebPage):
3417         (WebPage::requestPermission):
3418         (WebPage::cancelRequestsForPermission):
3419         * QtTestBrowser/webpage.h:
3420
3421 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3422
3423         Reviewed by Tor Arne Vestbø.
3424
3425         [Qt] Review the setUserPermission & friends API
3426         https://bugs.webkit.org/show_bug.cgi?id=46810
3427
3428         Add a ByUser suffix to PermissionGranted/Denied. In the future
3429         we can add PermissionGrantedByDefault.
3430
3431
3432         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3433         (WebCore::WebPage::requestPermission):
3434         (WebCore::WebPage::permissionSet):
3435         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3436         (LayoutTestController::grantDesktopNotificationPermission):
3437         * QtTestBrowser/webpage.cpp:
3438         (WebPage::requestPermission):
3439
3440 2010-11-18  Satish Sampath  <satish@chromium.org>
3441
3442         Reviewed by Jeremy Orlow.
3443
3444         For speech input event, send an event object containing all the recognition results and metadata.
3445         https://bugs.webkit.org/show_bug.cgi?id=49736
3446
3447         Updated DRT by renaming the mock result method on all platforms to the new signature.
3448
3449         * DumpRenderTree/LayoutTestController.cpp:
3450         (addMockSpeechInputResultCallback):
3451         (LayoutTestController::staticFunctions):
3452         * DumpRenderTree/LayoutTestController.h:
3453         * DumpRenderTree/chromium/LayoutTestController.cpp:
3454         (LayoutTestController::LayoutTestController):
3455         (LayoutTestController::addMockSpeechInputResult):
3456         * DumpRenderTree/chromium/LayoutTestController.h:
3457         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3458         (LayoutTestController::addMockSpeechInputResult):
3459         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3460         (LayoutTestController::addMockSpeechInputResult):
3461         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3462         (LayoutTestController::addMockSpeechInputResult):
3463         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3464         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3465         (LayoutTestController::addMockSpeechInputResult):
3466         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3467         (LayoutTestController::addMockSpeechInputResult):
3468
3469 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
3470
3471         Reviewed by Tony Chang.
3472
3473         Fix some spacing issues with log messages with
3474         new-run-webkit-tests --verbose.
3475
3476         https://bugs.webkit.org/show_bug.cgi?id=49936
3477
3478         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3479
3480 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3481
3482         Reviewed by Adam Barth.
3483
3484         update scm to work with different remote branches
3485         https://bugs.webkit.org/show_bug.cgi?id=49949
3486
3487         This works if there are multiple svn tracking branches
3488         and/or if the tracking branch is refs/remots/origin/master
3489         instead of refs/remotes/trunk which is the direction we're trying
3490         to head since that makes fetches faster.
3491
3492         * Scripts/webkitpy/common/checkout/scm.py:
3493         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3494
3495 2010-11-22  Hayato Ito  <hayato@chromium.org>
3496
3497         Reviewed by Shinichiro Hamaji.
3498
3499         Ignore reference files which will be used by reftests when collecting
3500         test cases.
3501         https://bugs.webkit.org/show_bug.cgi?id=49835
3502
3503         * Scripts/webkitpy/layout_tests/port/test_files.py:
3504         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3505
3506 2010-11-22  Adam Roben  <aroben@apple.com>
3507
3508         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
3509
3510         Apple's Windows build allows placing header files and import libraries for WebKit's
3511         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
3512         $WebKitLibrariesDir environment variable. This is both required for production builds and
3513         convenient for Apple-internal developer builds. Apple's production builds also require that
3514         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
3515         builds, the files are copied into that directory tree by the
3516         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
3517         copying is done by
3518         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
3519
3520         This .vsprops copying is problematic in one very important case: when a developer updates
3521         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
3522         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
3523         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
3524         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
3525         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
3526         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
3527
3528         To fix this, we now use normal relative paths to access the .vsprops files in the source
3529         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
3530         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
3531         unset, so the normal relative paths are used to read the .vsprops files out of the source
3532         tree directly. In production builds, this environment variable is set to a fake directory
3533         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
3534         is resolved.
3535         
3536         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
3537
3538         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3539
3540         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
3541         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
3542         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
3543         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
3544         FeatureDefines.vsprops becomes:
3545
3546         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3547
3548         which resolves to:
3549
3550         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3551
3552         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
3553         actually exist since they are matched by an equal number of ".." path components.)
3554
3555         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
3556         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
3557
3558         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
3559         updated
3560
3561         Reviewed by Dave Hyatt.
3562
3563         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3564         * DumpRenderTree/win/DumpRenderTree.vcproj:
3565         * DumpRenderTree/win/ImageDiff.vcproj:
3566         * FindSafari/FindSafari.vcproj:
3567         * MiniBrowser/MiniBrowser.vcproj:
3568         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3569         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3570         * WebKitAPITest/WebKitAPITest.vcproj:
3571         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3572         * WebKitTestRunner/win/InjectedBundle.vcproj:
3573         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3574         * WinLauncher/WinLauncher.vcproj:
3575         * record-memory-win/record-memory-win.vcproj:
3576         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
3577         files.
3578
3579 2010-11-22  Adam Roben  <aroben@apple.com>
3580
3581         Make it possible to run tests on Windows without Visual Studio or VC++
3582         Express installed
3583
3584         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
3585         are not installed. But this function doesn't need to be called when we
3586         already have a build available and are just trying to run the tests.
3587
3588         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
3589         because Visual Studio/VC++ Express aren't installed
3590
3591         Reviewed by Dave Hyatt.
3592
3593         * Scripts/webkitdirs.pm:
3594         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
3595         it is not needed by this function. Also added a FIXME.
3596
3597         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
3598         relying on determineConfigurationForVisualStudio doing it.
3599
3600 2010-11-19  Hayato Ito  <hayato@chromium.org>
3601
3602         Reviewed by Shinichiro Hamaji.
3603
3604         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
3605
3606         https://bugs.webkit.org/show_bug.cgi?id=49812
3607
3608         * Scripts/webkitpy/layout_tests/driver_test.py:
3609         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3610         * Scripts/webkitpy/layout_tests/port/base.py:
3611         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3612         * Scripts/webkitpy/layout_tests/port/chromium.py:
3613         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3614         * Scripts/webkitpy/layout_tests/port/test.py:
3615         * Scripts/webkitpy/layout_tests/port/webkit.py:
3616         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3617         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3618
3619 2010-11-22  Hayato Ito  <hayato@chromium.org>
3620
3621         Reviewed by Tony Chang.
3622
3623         [NRWT] Retry a few times in reading a png image to avoid a race condition.
3624
3625         https://bugs.webkit.org/show_bug.cgi?id=49924
3626
3627         * Scripts/webkitpy/layout_tests/port/chromium.py:
3628
3629 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
3630
3631         Reviewed by Kenneth Rohde Christiansen.
3632
3633         Fix EWebLauncher zoom discretization
3634         https://bugs.webkit.org/show_bug.cgi?id=49810
3635
3636         * EWebLauncher/main.c:
3637         (nearest_zoom_level_get):
3638         (zoom_level_set):
3639         (on_load_finished):
3640         (on_key_down):
3641
3642 2010-11-21  Sam Weinig  <sam@webkit.org>
3643
3644         Rubber-stamped by Dan Bernstein.
3645
3646         Fix ~300 WebKit2 tests by enabling developer extras preference.
3647
3648         * WebKitTestRunner/TestController.cpp:
3649         (WTR::TestController::resetStateToConsistentValues):
3650
3651 2010-11-21  Sam Weinig  <sam@webkit.org>
3652
3653         Reviewed by Dan Bernstein.
3654
3655         Textareas should be resizable by default
3656         https://bugs.webkit.org/show_bug.cgi?id=49892
3657
3658         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3659         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
3660         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3661         Add preferences test.
3662
3663 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
3664
3665         Reviewed by Tony Chang.
3666
3667         Rebaseline server: checksum-only differences and prefetching
3668         https://bugs.webkit.org/show_bug.cgi?id=49841
3669         
3670         Add support for image test results where the only difference is in the
3671         checksum.
3672         
3673         Add prefetching of the image results from the next test.
3674         
3675         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3676         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3677         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3678
3679 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3680
3681         Reviewed by Tony Chang.
3682
3683         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
3684
3685         Add the 'worker number' and 'worker name' concepts to the 
3686         TestShellThread objects, and move test_types and test_args from
3687         the TestRunner to the TestShellThread.
3688
3689         https://bugs.webkit.org/show_bug.cgi?id=49768
3690
3691         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3692         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3693
3694 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3695
3696         Reviewed by Ojan Vafai.
3697
3698         Do some minor cleanup and bug fixing.
3699
3700         https://bugs.webkit.org/show_bug.cgi?id=49777
3701
3702         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3703         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3704
3705 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3706
3707         Reviewed by Ojan Vafai.
3708
3709         nrwt - config.build_directory() is busted
3710
3711         Fixes a typo that was causing us to usually return the top level
3712         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
3713         bug was hidden by test stubs that were too simplistic :(.
3714
3715         https://bugs.webkit.org/show_bug.cgi?id=49815
3716
3717         * Scripts/webkitpy/common/system/executive_mock.py:
3718         * Scripts/webkitpy/layout_tests/port/config.py:
3719         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3720
3721 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3722
3723         Reviewed by Adam Roben.
3724
3725         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
3726         https://bugs.webkit.org/show_bug.cgi?id=49819
3727
3728         * DumpRenderTree/DumpRenderTree.sln:
3729         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3730         * DumpRenderTree/win/DumpRenderTree.vcproj:
3731         * DumpRenderTree/win/ImageDiff.vcproj:
3732         * FindSafari/FindSafari.vcproj:
3733         * MiniBrowser/MiniBrowser.vcproj:
3734         * TestWebKitAPI/win/TestWebKitAPI.sln:
3735         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3736         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3737         * WebKitAPITest/WebKitAPITest.vcproj:
3738         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3739         * WebKitTestRunner/win/InjectedBundle.vcproj:
3740         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3741         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3742         * WinLauncher/WinLauncher.vcproj:
3743         * record-memory-win/record-memory-win.vcproj:
3744
3745 2010-11-19  Adam Roben  <aroben@apple.com>
3746
3747         Add some more Windows slaves
3748
3749         This is probably more than we will be using in the immediate future,
3750         but having some extra slave names makes experimenting with different
3751         configurations easier.
3752
3753         Reviewed by Jon Honeycutt.
3754
3755         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
3756         Windows slaves and distributed them among the three different Test
3757         builders.
3758
3759 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
3760
3761         Reviewed by Ojan Vafai.
3762
3763         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3764         https://bugs.webkit.org/show_bug.cgi?id=49702
3765
3766         Re-landing r72357 with a test fix.
3767
3768         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3769         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3770         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3771
3772 2010-11-19  Avi Drissman  <avi@google.com>
3773
3774         Reviewed by Antonio Gomes.
3775
3776         Complete support for Unix editing mode
3777         https://bugs.webkit.org/show_bug.cgi?id=49757
3778
3779         * DumpRenderTree/LayoutTestController.cpp:
3780         (setEditingBehaviorCallback):
3781         * DumpRenderTree/chromium/LayoutTestController.cpp:
3782         (LayoutTestController::setEditingBehavior):
3783
3784 2010-11-19  Adam Roben  <aroben@apple.com>
3785
3786         Fix run-javascriptcore-tests when there's a space in the path to
3787         testapi
3788
3789         Reviewed by Sam Weinig.
3790
3791         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
3792         system() to force it to interpret spaces in the path correctly.
3793
3794 2010-11-19  Adam Roben  <aroben@apple.com>
3795
3796         Update scripts for .exe name changes after r72327
3797
3798         As of r72327, the "_debug" suffix is only used in Debug_All builds.
3799
3800         Reviewed by Sam Weinig.
3801
3802         * Scripts/run-javascriptcore-tests:
3803         (testapiPath):
3804
3805         * Scripts/sunspider-compare-results:
3806         (pathToBuiltJSC):
3807
3808         * Scripts/webkitdirs.pm:
3809         (jscPath):
3810         (safariPath):
3811
3812 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3813
3814         Reviewed by Darin Adler.
3815
3816         Normalize Cairo/CFLite project/solution configuration names
3817         https://bugs.webkit.org/show_bug.cgi?id=49818
3818
3819         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3820         * DumpRenderTree/win/DumpRenderTree.vcproj:
3821         * DumpRenderTree/win/ImageDiff.vcproj:
3822         * MiniBrowser/MiniBrowser.vcproj:
3823         * TestWebKitAPI/win/TestWebKitAPI.sln:
3824         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3825         * WebKitAPITest/WebKitAPITest.vcproj:
3826         * WebKitTestRunner/win/InjectedBundle.vcproj:
3827         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3828         * WinLauncher/WinLauncher.vcproj:
3829         * Scripts/webkitdirs.pm: Updated cairo build configs.
3830
3831 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3832
3833         Reviewed by Adam Roben.
3834
3835         Windows vcproj configuration names should be normalized across projects
3836         https://bugs.webkit.org/show_bug.cgi?id=49776
3837
3838         * DumpRenderTree/DumpRenderTree.sln:
3839         * FindSafari/FindSafari.vcproj:
3840         * TestWebKitAPI/win/TestWebKitAPI.sln:
3841         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3842         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
3843         * WebKitAPITest/WebKitAPITest.vcproj:
3844         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3845         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3846         * WebKitTestRunner/WebKitTestRunner.sln:
3847         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3848         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
3849         * record-memory-win/record-memory-win.vcproj:
3850
3851 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3852
3853         Build fix - as per DRT-mac, always enabled developer extras,
3854         in win/qt/gtk DRT.
3855
3856         This is necessary to enable rich exception messages to be generated
3857         following https://bugs.webkit.org/show_bug.cgi?id=49708.
3858
3859         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3860         (shouldEnableDeveloperExtras):
3861         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3862         (WebCore::shouldEnableDeveloperExtras):
3863         * DumpRenderTree/win/DumpRenderTree.cpp:
3864         (shouldEnableDeveloperExtras):
3865
3866 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
3867
3868         Unreviewed, rolling out r72357.
3869         http://trac.webkit.org/changeset/72357
3870         https://bugs.webkit.org/show_bug.cgi?id=49784
3871
3872         It broke test-webkitpy tests since the patch didn't have the
3873         corresponding test update (Requested by kinuko on #webkit).
3874
3875         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3876         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3877
3878 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
3879
3880         Reviewed by Tony Chang.
3881
3882         Rebaseline server: add rebaseline queue
3883         https://bugs.webkit.org/show_bug.cgi?id=49763
3884         
3885         Add a UI queue (a multi-item <select>) where tests to be baselined
3886         can be enqueued (also supports basic removal). A queue is used instead
3887         of immediately doing rebaselines since SCM operations can take a while.
3888         It's better to go through lots of tests quickly to mark them as
3889         needing rebaselining and then batch the SCM operations.
3890         
3891         Also adds a simple log where results can be displayed.
3892
3893         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3894         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3895         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3896         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
3897         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3898         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3899
3900 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3901
3902         Reviewed by Oliver Hunt.
3903
3904         Bug 49708 - Stop recompiling functions to regenerate exception info.
3905
3906         Instead only hold info as necessary – keep divot info is the inspector
3907         is enabled, line number info is debugging or profiling, and handler
3908         info for functions with try/catch.
3909
3910         * DumpRenderTree/mac/DumpRenderTree.mm:
3911         (shouldEnableDeveloperExtras):
3912             - always enable the developer tools from DRT, to ensure we
3913               produce rich error messages on JavaScript exceptions.
3914
3915 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
3916
3917         Reviewed by Ojan Vafai.
3918
3919         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3920         https://bugs.webkit.org/show_bug.cgi?id=49702
3921
3922         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3923         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3924
3925 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
3926
3927         Reviewed by Tony Chang.
3928
3929         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
3930
3931         Create the first version of the 'message_broker' package. This
3932         class will encapsulate all of the threading/multiprocessing and
3933         message-sending details for the communication between the
3934         'manager' object and the 'worker' objects. For the moment, it
3935         just holds some routines and tests for logging thread stacks.
3936
3937         There should be no functional changes in this patch, just moving stuff
3938         around.
3939
3940         https://bugs.webkit.org/show_bug.cgi?id=49707
3941
3942         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3943         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
3944         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
3945         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
3946         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3947         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3948
3949 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3950
3951         Reviewed by Adam Roben.
3952
3953         Remove leftover Windows Debug_Internal configurations
3954         https://bugs.webkit.org/show_bug.cgi?id=49758
3955
3956         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3957         * DumpRenderTree/win/DumpRenderTree.vcproj:
3958         * DumpRenderTree/win/ImageDiff.vcproj:
3959         * MiniBrowser/MiniBrowser.vcproj:
3960         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3961         * WebKitAPITest/WebKitAPITest.vcproj:
3962         * WebKitTestRunner/win/InjectedBundle.vcproj:
3963         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3964         * WinLauncher/WinLauncher.vcproj:
3965
3966 2010-11-18  Adam Roben  <aroben@apple.com>
3967
3968         Add three new Windows XP build slaves
3969
3970         Reviewed by Steve Falkenburg.
3971
3972         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
3973         new slaves, and added them to the Windows XP Debug (Tests) builder.
3974
3975 2010-11-18  Daniel Bates  <dbates@rim.com>
3976
3977         Reviewed by Adam Roben.
3978
3979         update-webkit-support-libs should fall back to existing
3980         WebKitSupportLibrary version if there is no internet connectivity
3981         https://bugs.webkit.org/show_bug.cgi?id=49503
3982
3983         Fall back to existing support libraries (if present) when there is
3984         no internet connection.
3985
3986         Currently, update-webkit-support-libs dies with an "out-of-date"
3987         error when there is no internet connection because it cannot
3988         retrieve versioning information from developer.apple.com. Because
3989         update-webkit-support-libs fails, build-webkit fails. Instead,
3990         if there is no internet connection and the support libraries are
3991         present then we should warn the user and exit() with success so
3992         that build-webkit can work without an internet connection.
3993
3994         * Scripts/update-webkit-support-libs:
3995
3996 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3997
3998         Reviewed by Adam Roben.
3999
4000         Debug_Internal Windows configuration is unnecessary, should be removed
4001         https://bugs.webkit.org/show_bug.cgi?id=49753
4002
4003         * DumpRenderTree/win/DumpRenderTree.cpp:
4004         * MiniBrowser/win/stdafx.h:
4005         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
4006         * WebKitTestRunner/win/TestControllerWin.cpp:
4007
4008 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
4009
4010         Reviewed by Adam Roben.
4011
4012         Clean up vcproj errors
4013         https://bugs.webkit.org/show_bug.cgi?id=49741
4014
4015         * MiniBrowser/MiniBrowser.vcproj:
4016         * WebKitAPITest/WebKitAPITest.vcproj:
4017         * WebKitTestRunner/win/InjectedBundle.vcproj:
4018         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
4019
4020 2010-11-18  Hayato Ito  <hayato@chromium.org>
4021
4022         Reviewed by Shinichiro Hamaji.
4023
4024         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
4025         which is caused by r72249.
4026
4027         https://bugs.webkit.org/show_bug.cgi?id=49751
4028
4029         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
4030
4031 2010-11-18  Adam Roben  <aroben@apple.com>
4032
4033         Implement layoutTestController.waitForPolicyDelegate on Windows
4034
4035         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
4036
4037         Reviewed by Simon Fraser.
4038
4039         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4040         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
4041         code from LayoutTestControllerMac.mm.
4042
4043 2010-11-18  Hayato Ito  <hayato@chromium.org>
4044
4045         Reviewed by Shinichiro Hamaji.
4046
4047         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
4048
4049         https://bugs.webkit.org/show_bug.cgi?id=49740
4050
4051         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4052
4053 2010-11-18  Tony Chang  <tony@chromium.org>
4054
4055         Reviewed by Adam Barth.
4056
4057         run platform/chromium/plugins/refcount-leaks.html on all platforms
4058         https://bugs.webkit.org/show_bug.cgi?id=49485
4059
4060         Add PluginObject.testObjectCount which returns the number of allocated
4061         TestObjects. Add PluginObject.testCreateTestObject which allocates
4062         and returns a TestObject.
4063
4064         Add TestObject.refCount which returns the number of refs on the
4065         TestObject.
4066
4067         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
4068         (pluginGetProperty):
4069         (pluginInvoke):
4070         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
4071         (getTestObjectCount):
4072         (testAllocate):
4073         (testDeallocate):
4074         (testGetProperty):
4075         (testScriptObjectInvoke): Release a ref to a plugin object that was
4076             previously leaked.
4077         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
4078
4079 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
4080
4081         Reviewed by Adam Roben.
4082
4083         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
4084         https://bugs.webkit.org/show_bug.cgi?id=49711
4085
4086         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
4087         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
4088         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
4089         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
4090         * record-memory-win/record-memory-win-common.vsprops: Added.
4091         * record-memory-win/record-memory-win.vcproj:
4092
4093 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
4094
4095         Reviewed by Csaba Osztrogonác.
4096
4097         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
4098
4099         * MiniBrowser/qt/BrowserWindow.cpp:
4100         (BrowserWindow::updateUserAgentList):
4101
4102 2010-11-17  Adam Roben  <aroben@apple.com>
4103
4104         Don't trigger Windows builds when chromium-win test results change
4105
4106         Reviewed by Mark Rowe.
4107
4108         * Scripts/webkitpy/common/config/build.py:
4109         (_should_file_trigger_build): Changed the regular expression used to
4110         search for directory names to only consider full directory names,
4111         rather than matching directory names where the string we care about is
4112         a suffix of the name.
4113
4114         * Scripts/webkitpy/common/config/build_unittest.py:
4115         (ShouldBuildTest): Added a test.
4116
4117 2010-11-17  Hayato Ito  <hayato@chromium.org>
4118
4119         Reviewed by Shinichiro Hamaji.
4120
4121         Remove a uri member from TestInput class.
4122
4123         https://bugs.webkit.org/show_bug.cgi?id=49691
4124
4125         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4126         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4127
4128 2010-11-17  Adam Roben  <aroben@apple.com>
4129
4130         Move FindSafari's settings into a vsprops file
4131
4132         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
4133
4134         Reviewed by Steve Falkenburg.
4135
4136         * FindSafari/FindSafari.vcproj:
4137         * FindSafari/FindSafariCommon.vsprops: Added.
4138
4139 2010-11-17  Adam Roben  <aroben@apple.com>
4140
4141         Use a minimum font size of 0 in DRT on Windows
4142
4143         This is the Windows equivalent of r72164.
4144
4145         Rubber-stamped by Dave Hyatt.
4146
4147         * DumpRenderTree/win/DumpRenderTree.cpp:
4148         (resetDefaultsToConsistentValues):
4149
4150 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
4151
4152         Reviewed by Andreas Kling.
4153
4154         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
4155         https://bugs.webkit.org/show_bug.cgi?id=49639
4156
4157         * Scripts/webkitpy/common/checkout/scm.py:
4158
4159 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
4160
4161         Reviewed by Tony Chang.
4162
4163         Rebaseline server: add loupe for image diffs
4164         https://bugs.webkit.org/show_bug.cgi?id=49692
4165         
4166         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
4167         enlarged area of the expected, actual and diff images side by side.
4168
4169         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
4170         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
4171         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
4172         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
4173
4174 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
4175
4176         Reviewed by Adam Roben.
4177
4178         WebKitLauncherWin should use vsprops for shared build settings
4179         https://bugs.webkit.org/show_bug.cgi?id=49696
4180
4181         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
4182         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
4183
4184 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
4185
4186         Reviewed by Adam Roben.
4187
4188         WinLauncher should use vsprops for shared build settings
4189         https://bugs.webkit.org/show_bug.cgi?id=49695
4190
4191         * WinLauncher/WinLauncher.cpp:
4192         (_tWinMain):
4193         (PrintView):
4194         (WndProc):
4195         (MyEditProc):
4196         * WinLauncher/WinLauncher.vcproj:
4197         * WinLauncher/WinLauncherCommon.vsprops: Added.
4198
4199 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
4200
4201         Delete unused file unintentionally added in last change.
4202
4203         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
4204
4205 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
4206
4207         Reviewed by Adam Roben.
4208
4209         DumpRenderTree on Windows should use a vsprops file for shared project settings
4210         https://bugs.webkit.org/show_bug.cgi?id=49690
4211
4212         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
4213         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
4214         * DumpRenderTree/win/DumpRenderTree.vcproj:
4215         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
4216         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
4217         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
4218         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
4219         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
4220         * DumpRenderTree/win/ImageDiff.vcproj:
4221         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
4222
4223 2010-11-17  Hayato Ito  <hayato@chromium.org>
4224
4225         Refactor TestTypeBase.compare_output().
4226
4227         Introduce a TestOutput class and update compare_output() of each test
4228         types so that they can take both actual and expected TestOutput objects.
4229
4230         https://bugs.webkit.org/show_bug.cgi?id=49431
4231
4232         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4233         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
4234         * Scripts/webkitpy/layout_tests/port/base.py:
4235         * Scripts/webkitpy/layout_tests/port/chromium.py:
4236         * Scripts/webkitpy/layout_tests/port/dryrun.py:
4237         * Scripts/webkitpy/layout_tests/port/test.py:
4238         * Scripts/webkitpy/layout_tests/port/webkit.py:
4239         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4240         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
4241         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
4242         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4243
4244 2010-11-17  Adam Roben  <aroben@apple.com>
4245
4246         Make each Windows Test builder use the same OS for all its slaves
4247
4248         Currently each WebKit1 Windows Test builder has one Windows XP slave
4249         and one Windows 7 slave. Having different OSes in a single builder
4250         meant that the builders would alternate between red and green when
4251         there were OS-specific failures.
4252
4253         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
4254         between red and green because of multiple OS versions
4255
4256         Reviewed by Mark Rowe.
4257
4258         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
4259         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
4260         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
4261         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
4262         builders for the two WebKit1 builders so that they would all use the
4263         appropriate OS.
4264
4265 2010-11-17  James Robinson  <jamesr@chromium.org>
4266
4267         Reviewed by Dan Bernstein.
4268
4269         [chromium] Set minimum font size to 0 for DRT
4270         https://bugs.webkit.org/show_bug.cgi?id=49677
4271
4272         Followup for http://trac.webkit.org/changeset/72141.
4273
4274         Test: http/tests/misc/acid3.html
4275
4276         * DumpRenderTree/chromium/WebPreferences.cpp:
4277         (WebPreferences::reset):
4278
4279 2010-11-17  Andras Becsi  <abecsi@webkit.org>
4280
4281         Unreviewed build fix.
4282
4283         [Qt] Add missing file I forgot in r72220.
4284
4285         * MiniBrowser/MiniBrowser.qrc: Added.
4286
4287 2010-11-17  Andras Becsi  <abecsi@webkit.org>
4288
4289         Reviewed by Andreas Kling.
4290
4291         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
4292         https://bugs.webkit.org/show_bug.cgi?id=49627
4293
4294         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
4295
4296         * MiniBrowser/MiniBrowser.qrc: Added.
4297         Add it here to prevent qmake from detecting it
4298         since it needs to be copied to the build directory.
4299         * MiniBrowser/qt/BrowserWindow.cpp:
4300         (BrowserWindow::BrowserWindow):
4301         (BrowserWindow::updateUserAgentList):
4302         (BrowserWindow::showUserAgentDialog):
4303         * MiniBrowser/qt/BrowserWindow.h:
4304         * MiniBrowser/qt/MiniBrowser.pro:
4305
4306 2010-11-17  Adam Roben  <aroben@apple.com>
4307
4308         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
4309
4310         We use that file on Windows!
4311
4312         Fixes <http://webkit.org/b/49643> Changes to
4313         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
4314
4315         Reviewed by Steve Falkenbu