89fde4323f8213771893f717c30f43de28de8035
[WebKit-https.git] / Tools / ChangeLog
1 2016-11-09  Jonathan Bedard  <jbedard@apple.com>
2
3         test-webkitpy failing test_create_patch_is_full_patch unit test
4         https://bugs.webkit.org/show_bug.cgi?id=164385
5
6         Reviewed by Darin Adler.
7
8         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Fixed expected output to match output.
9
10 2016-11-09  Chris Dumez  <cdumez@apple.com>
11
12         [Mac] Stop using deprecated AppKit enumeration values
13         https://bugs.webkit.org/show_bug.cgi?id=164494
14
15         Reviewed by Darin Adler.
16
17         Stop using deprecated AppKit enumeration values.
18
19         * DumpRenderTree/mac/EventSendingController.mm:
20         (eventTypeForMouseButtonAndAction):
21         (modifierFlags):
22         (-[EventSendingController mouseMoveToX:Y:]):
23         (-[EventSendingController contextClick]):
24         (-[EventSendingController keyDown:withModifiers:withLocation:]):
25         * DumpRenderTree/mac/TextInputController.m:
26         (-[TextInputController interpretKeyEvents:withSender:]):
27         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
28         (simulateCommandArrow):
29         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
30         (TestWebKitAPI::TEST):
31         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm:
32         (TestWebKitAPI::TEST):
33         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
34         (TestWebKitAPI::TEST):
35         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
36         (TEST):
37         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm:
38         (UserInitiatedActionTest::SetUp):
39         (UserInitiatedActionTest::click):
40         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
41         (TestWebKitAPI::AcceptsFirstMouse::runTest):
42         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
43         (TestWebKitAPI::contextMenuCopyLink):
44         (TestWebKitAPI::TEST):
45         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm:
46         (TestWebKitAPI::TEST):
47         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
48         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
49         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
50         (TestWebKitAPI::TEST):
51         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
52         (TestWebKitAPI::Util::isKeyDown):
53         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
54         (TestWebKitAPI::PlatformWebView::initialize):
55         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
56         (TestWebKitAPI::PlatformWebView::simulateRightClick):
57         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
58         (TestWebKitAPI::eventTypeForButton):
59         (TestWebKitAPI::modifierFlagsForWKModifiers):
60         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
61         (__simulated_forceClickAssociatedEventsMask):
62         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
63         (-[TestWKWebView _setUpTestWindow:]):
64         (-[TestWKWebView typeCharacter:]):
65         * WebKitTestRunner/mac/EventSenderProxy.mm:
66         (WTR::eventTypeForMouseButtonAndAction):
67         (WTR::buildModifierFlags):
68         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
69         (WTR::EventSenderProxy::mouseForceClick):
70         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
71         (WTR::EventSenderProxy::mouseMoveTo):
72         (WTR::EventSenderProxy::keyDown):
73         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
74         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
75         (WTR::PlatformWebView::PlatformWebView):
76         * WebKitTestRunner/mac/TestControllerMac.mm:
77         (WTR::TestController::platformResetStateToConsistentValues):
78
79 2016-11-09  Beth Dakin  <bdakin@apple.com>
80
81         Support TouchBar in WebKit
82         https://bugs.webkit.org/show_bug.cgi?id=164437
83         -and corresponding-
84         rdar://problem/28876524
85
86         Reviewed by Darin Adler.
87
88         This makes MiniBrowser support TouchBar customization. 
89
90         * MiniBrowser/mac/AppDelegate.m:
91         (-[BrowserAppDelegate awakeFromNib]):
92
93 2016-11-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
94
95         [EFL] Use libgcrypt instead of GnuTLS for CryptoDigest
96         https://bugs.webkit.org/show_bug.cgi?id=164461
97
98         Reviewed by Michael Catanzaro.
99
100         As GTK port in r208297, EFL port starts to use libgcrypt instead of GnuTLS as well.
101
102         * efl/install-dependencies: Add libgcript package dependecy.
103
104 2016-11-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
105
106         [EFL] Remove unused function in MiniBrowser
107         https://bugs.webkit.org/show_bug.cgi?id=164398
108
109         Reviewed by Darin Adler.
110
111         * MiniBrowser/efl/main.c:
112         (window_find_with_elm_window): Deleted because it is not used anywhere.
113
114 2016-11-09  Chris Dumez  <cdumez@apple.com>
115
116         [WK2][NETWORK_SESSION] Add support for downloading file backed blobs
117         https://bugs.webkit.org/show_bug.cgi?id=164458
118         <rdar://problem/28905514>
119
120         Reviewed by Darin Adler.
121
122         Add testRunner.setShouldDownloadUndisplayableMIMETypes(bool) API so that layout
123         tests can request that such resources are downloaded instead of being ignored.
124
125         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
126         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
127         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
128         * WebKitTestRunner/InjectedBundle/TestRunner.h:
129         * WebKitTestRunner/TestController.cpp:
130         (WTR::TestController::decidePolicyForNavigationResponse):
131         * WebKitTestRunner/TestController.h:
132         (WTR::TestController::setShouldDownloadUndisplayableMIMETypes):
133         * WebKitTestRunner/TestInvocation.cpp:
134         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
135
136 2016-11-09  Jonathan Bedard  <jbedard@apple.com>
137
138         Make rpaths more robust for iOS Simulators
139         https://bugs.webkit.org/show_bug.cgi?id=164521
140
141         Reviewed by Simon Fraser.
142
143         * Scripts/webkitpy/port/ios.py:
144         (IOSSimulatorPort._createSimulatorApp): Added more robust path.
145
146 2016-11-09  Csaba Osztrogonác  <ossy@webkit.org>
147
148         Fix Tools build on case sensitive file systems
149         https://bugs.webkit.org/show_bug.cgi?id=164474
150
151         Unreviewed buildfix.
152
153         * DumpRenderTree/CMakeLists.txt:
154         * DumpRenderTree/PlatformMac.cmake:
155         * DumpRenderTree/PlatformWin.cmake:
156         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
157         * MiniBrowser/mac/CMakeLists.txt:
158
159 2016-11-04  Filip Pizlo  <fpizlo@apple.com>
160
161         WTF::ParkingLot should stop using std::chrono because std::chrono::duration casts are prone to overflows
162         https://bugs.webkit.org/show_bug.cgi?id=152045
163
164         Reviewed by Andy Estes.
165
166         * TestWebKitAPI/CMakeLists.txt:
167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
168         * TestWebKitAPI/Tests/WTF/Condition.cpp:
169         (TestWebKitAPI::TEST):
170         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
171         (TestWebKitAPI::ToUpperConverter::stopProducing):
172         (TestWebKitAPI::ToUpperConverter::stopConsuming):
173         * TestWebKitAPI/Tests/WTF/Time.cpp: Added.
174         (WTF::operator<<):
175         (TestWebKitAPI::TEST):
176
177 2016-11-04  Alex Christensen  <achristensen@webkit.org>
178
179         Unreviewed, rolling out r208293.
180
181         asserts in API tests.
182
183         Reverted changeset:
184
185         "NetworkSession: Network process crash when converting main
186         resource to download"
187         https://bugs.webkit.org/show_bug.cgi?id=164220
188         http://trac.webkit.org/changeset/208293
189
190 2016-11-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
191
192         Add a setting and preferences to enable/disable async image decoding
193         https://bugs.webkit.org/show_bug.cgi?id=164417
194
195         Reviewed by Simon Fraser.
196
197         Pref and a menu item to toggle asyncImageDecodingEnabled for WebKits 1 and 2.
198
199         * MiniBrowser/mac/SettingsController.h:
200         * MiniBrowser/mac/SettingsController.m:
201         (-[SettingsController _populateMenu]):
202         (-[SettingsController validateMenuItem:]):
203         (-[SettingsController toggleAsyncImageDecodingEnabled:]):
204         (-[SettingsController asyncImageDecodingEnabled]):
205         * MiniBrowser/mac/WK1BrowserWindowController.m:
206         (-[WK1BrowserWindowController didChangeSettings]):
207         * MiniBrowser/mac/WK2BrowserWindowController.m:
208         (-[WK2BrowserWindowController didChangeSettings]):
209
210 2016-11-04  Brady Eidson  <beidson@apple.com>
211
212         REGRESSION (r208349) StringHasher::hashMemory behavior changed, causing API tests to fail
213         https://bugs.webkit.org/show_bug.cgi?id=164390
214
215         Reviewed by Geoffrey Garen.
216
217         Operating under the assumption that the behavior change is okay/desirable, this updates the test.
218
219         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
220         (TestWebKitAPI::TEST):
221
222 2016-11-04  Joanmarie Diggs  <jdiggs@igalia.com>
223
224         AX: [ATK] Attempting to clear selection on ARIA listboxes results in crash
225         https://bugs.webkit.org/show_bug.cgi?id=164331
226
227         Reviewed by Chris Fleizach.
228
229         Add AccessibilityUIElement::clearSelectedChildren() to DRT and WKTR.
230         Implement it for ATK.
231
232         * DumpRenderTree/AccessibilityUIElement.h:
233         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
234         (AccessibilityUIElement::clearSelectedChildren):
235         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
236         (AccessibilityUIElement::clearSelectedChildren):
237         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
238         (AccessibilityUIElement::clearSelectedChildren):
239         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
240         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
241         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
242         (WTR::AccessibilityUIElement::clearSelectedChildren):
243         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
244         (WTR::AccessibilityUIElement::clearSelectedChildren):
245         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
246         (WTR::AccessibilityUIElement::clearSelectedChildren):
247
248 2016-11-04  Per Arne Vollan  <pvollan@apple.com>
249
250         [Win] Page visibility tests are timing out.
251         https://bugs.webkit.org/show_bug.cgi?id=164363
252
253         Reviewed by Brent Fulgham.
254
255         Implement methods to set page visibility.
256
257         * DumpRenderTree/win/TestRunnerWin.cpp:
258         (TestRunner::resetPageVisibility):
259         (TestRunner::setPageVisibility):
260
261 2016-11-03  Simon Fraser  <simon.fraser@apple.com>
262
263         Give all the geometry classes a single-argument scale() function for consistency
264         https://bugs.webkit.org/show_bug.cgi?id=164400
265
266         Reviewed by Zalan Bujtas.
267         
268         Test single-argument scale().
269
270         * TestWebKitAPI/Tests/WebCore/FloatPoint.cpp:
271         (TestWebKitAPI::TEST):
272
273 2016-11-03  Chris Dumez  <cdumez@apple.com>
274
275         [WK2][Cocoa] Implement user interface for HTML form validation
276         https://bugs.webkit.org/show_bug.cgi?id=164143
277         <rdar://problem/28944652>
278
279         Reviewed by Simon Fraser.
280
281         Add support for UIScriptController::contentsOfUserInterfaceItem("validationBubble")
282         on both Mac and iOS to retrieve the currently displayed validation message.
283
284         * DumpRenderTree/mac/UIScriptControllerMac.mm:
285         (WTR::UIScriptController::contentsOfUserInterfaceItem):
286         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
287         (WTR::UIScriptController::contentsOfUserInterfaceItem):
288         (WTR::UIScriptController::selectFormAccessoryPickerRow):
289         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
290         (WTR::UIScriptController::contentsOfUserInterfaceItem):
291
292 2016-11-03  Konstantin Tokarev  <annulen@yandex.ru>
293
294         Fixes to build JSCOnly on macOS
295         https://bugs.webkit.org/show_bug.cgi?id=164379
296
297         Reviewed by Michael Catanzaro.
298
299         * TestWebKitAPI/PlatformJSCOnly.cmake: Moved BUILDING_JSCONLY__
300         definition to OptionsJSCOnly.cmake
301
302 2016-11-03  Dan Bernstein  <mitz@apple.com>
303
304         WKWebView’s _observedRenderingProgressEvents not restored after web process crash
305         https://bugs.webkit.org/show_bug.cgi?id=164368
306         <rdar://problem/29091954>
307
308         Reviewed by Anders Carlsson.
309
310         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
311         * TestWebKitAPI/Tests/WebKit2Cocoa/ObservedRenderingProgressEventsAfterCrash.mm: Added.
312         (TEST):
313
314 2016-11-03  Alex Christensen  <achristensen@webkit.org>
315
316         Purge PassRefPtr from Tools
317         https://bugs.webkit.org/show_bug.cgi?id=164358
318
319         Reviewed by Michael Catanzaro.
320
321         * ImageDiff/efl/ImageDiff.cpp:
322         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
323         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
324         (WTR::AccessibilityController::create):
325         (WTR::AccessibilityController::rootElement):
326         (WTR::AccessibilityController::focusedElement):
327         (WTR::AccessibilityController::elementAtPoint):
328         (WTR::AccessibilityController::addNotificationListener): Deleted.
329         (WTR::AccessibilityController::removeNotificationListener): Deleted.
330         (WTR::AccessibilityController::accessibleElementById): Deleted.
331         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
332         (WTR::AccessibilityController::resetToConsistentState): Deleted.
333         (WTR::AccessibilityController::platformName): Deleted.
334         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
335         (WTR::AccessibilityController::logAccessibilityEvents):
336         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
337         (WTR::AccessibilityTextMarker::create):
338         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h:
339         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
340         (WTR::AccessibilityTextMarkerRange::create):
341         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h:
342         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
343         (WTR::AccessibilityUIElement::create):
344         (WTR::AccessibilityUIElement::linkedElement):
345         (WTR::AccessibilityUIElement::headerElementAtIndex):
346         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
347         (WTR::AccessibilityUIElement::characterAtOffset):
348         (WTR::AccessibilityUIElement::wordAtOffset):
349         (WTR::AccessibilityUIElement::lineAtOffset):
350         (WTR::AccessibilityUIElement::sentenceAtOffset):
351         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
352         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
353         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
354         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
355         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
356         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
357         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
358         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
359         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
360         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
361         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
362         (WTR::AccessibilityUIElement::AccessibilityUIElement): Deleted.
363         (WTR::AccessibilityUIElement::~AccessibilityUIElement): Deleted.
364         (WTR::AccessibilityUIElement::isEqual): Deleted.
365         (WTR::AccessibilityUIElement::elementAtPoint): Deleted.
366         (WTR::AccessibilityUIElement::childAtIndex): Deleted.
367         (WTR::AccessibilityUIElement::indexOfChild): Deleted.
368         (WTR::AccessibilityUIElement::childrenCount): Deleted.
369         (WTR::AccessibilityUIElement::titleUIElement): Deleted.
370         (WTR::AccessibilityUIElement::parentElement): Deleted.
371         (WTR::AccessibilityUIElement::takeFocus): Deleted.
372         (WTR::AccessibilityUIElement::takeSelection): Deleted.
373         (WTR::AccessibilityUIElement::addSelection): Deleted.
374         (WTR::AccessibilityUIElement::removeSelection): Deleted.
375         (WTR::AccessibilityUIElement::allAttributes): Deleted.
376         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements): Deleted.
377         (WTR::AccessibilityUIElement::linkedUIElementAtIndex): Deleted.
378         (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Deleted.
379         (WTR::AccessibilityUIElement::attributesOfChildren): Deleted.
380         (WTR::AccessibilityUIElement::parameterizedAttributeNames): Deleted.
381         (WTR::AccessibilityUIElement::increment): Deleted.
382         (WTR::AccessibilityUIElement::decrement): Deleted.
383         (WTR::AccessibilityUIElement::showMenu): Deleted.
384         (WTR::AccessibilityUIElement::press): Deleted.
385         (WTR::AccessibilityUIElement::stringAttributeValue): Deleted.
386         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue): Deleted.
387         (WTR::AccessibilityUIElement::uiElementAttributeValue): Deleted.
388         (WTR::AccessibilityUIElement::numberAttributeValue): Deleted.
389         (WTR::AccessibilityUIElement::boolAttributeValue): Deleted.
390         (WTR::AccessibilityUIElement::isAttributeSupported): Deleted.
391         (WTR::AccessibilityUIElement::isAttributeSettable): Deleted.
392         (WTR::AccessibilityUIElement::isPressActionSupported): Deleted.
393         (WTR::AccessibilityUIElement::isIncrementActionSupported): Deleted.
394         (WTR::AccessibilityUIElement::isDecrementActionSupported): Deleted.
395         (WTR::AccessibilityUIElement::role): Deleted.
396         (WTR::AccessibilityUIElement::subrole): Deleted.
397         (WTR::AccessibilityUIElement::roleDescription): Deleted.
398         (WTR::AccessibilityUIElement::computedRoleString): Deleted.
399         (WTR::AccessibilityUIElement::title): Deleted.
400         (WTR::AccessibilityUIElement::description): Deleted.
401         (WTR::AccessibilityUIElement::language): Deleted.
402         (WTR::AccessibilityUIElement::stringValue): Deleted.
403         (WTR::AccessibilityUIElement::accessibilityValue): Deleted.
404         (WTR::AccessibilityUIElement::helpText): Deleted.
405         (WTR::AccessibilityUIElement::orientation): Deleted.
406         (WTR::AccessibilityUIElement::x): Deleted.
407         (WTR::AccessibilityUIElement::y): Deleted.
408         (WTR::AccessibilityUIElement::width): Deleted.
409         (WTR::AccessibilityUIElement::height): Deleted.
410         (WTR::AccessibilityUIElement::intValue): Deleted.
411         (WTR::AccessibilityUIElement::minValue): Deleted.
412         (WTR::AccessibilityUIElement::maxValue): Deleted.
413         (WTR::AccessibilityUIElement::valueDescription): Deleted.
414         (WTR::AccessibilityUIElement::insertionPointLineNumber): Deleted.
415         (WTR::AccessibilityUIElement::selectedTextRange): Deleted.
416         (WTR::AccessibilityUIElement::isEnabled): Deleted.
417         (WTR::AccessibilityUIElement::isRequired): Deleted.
418         (WTR::AccessibilityUIElement::isFocused): Deleted.
419         (WTR::AccessibilityUIElement::isFocusable): Deleted.
420         (WTR::AccessibilityUIElement::isSelected): Deleted.
421         (WTR::AccessibilityUIElement::isSelectedOptionActive): Deleted.
422         (WTR::AccessibilityUIElement::isSelectable): Deleted.
423         (WTR::AccessibilityUIElement::isMultiSelectable): Deleted.
424         (WTR::AccessibilityUIElement::setSelectedChild): Deleted.
425         (WTR::AccessibilityUIElement::setSelectedChildAtIndex): Deleted.
426         (WTR::AccessibilityUIElement::removeSelectionAtIndex): Deleted.
427         (WTR::AccessibilityUIElement::selectedChildrenCount): Deleted.
428         (WTR::AccessibilityUIElement::selectedChildAtIndex): Deleted.
429         (WTR::AccessibilityUIElement::isExpanded): Deleted.
430         (WTR::AccessibilityUIElement::isChecked): Deleted.
431         (WTR::AccessibilityUIElement::isIndeterminate): Deleted.
432         (WTR::AccessibilityUIElement::isVisible): Deleted.
433         (WTR::AccessibilityUIElement::isOffScreen): Deleted.
434         (WTR::AccessibilityUIElement::isCollapsed): Deleted.
435         (WTR::AccessibilityUIElement::isIgnored): Deleted.
436         (WTR::AccessibilityUIElement::hasPopup): Deleted.
437         (WTR::AccessibilityUIElement::hierarchicalLevel): Deleted.
438         (WTR::AccessibilityUIElement::clickPointX): Deleted.
439         (WTR::AccessibilityUIElement::clickPointY): Deleted.
440         (WTR::AccessibilityUIElement::documentEncoding): Deleted.
441         (WTR::AccessibilityUIElement::documentURI): Deleted.
442         (WTR::AccessibilityUIElement::url): Deleted.
443         (WTR::AccessibilityUIElement::speak): Deleted.
444         (WTR::AccessibilityUIElement::attributesOfColumnHeaders): Deleted.
445         (WTR::AccessibilityUIElement::attributesOfRowHeaders): Deleted.
446         (WTR::AccessibilityUIElement::attributesOfColumns): Deleted.
447         (WTR::AccessibilityUIElement::attributesOfRows): Deleted.
448         (WTR::AccessibilityUIElement::attributesOfVisibleCells): Deleted.
449         (WTR::AccessibilityUIElement::attributesOfHeader): Deleted.
450         (WTR::AccessibilityUIElement::indexInTable): Deleted.
451         (WTR::AccessibilityUIElement::rowIndexRange): Deleted.
452         (WTR::AccessibilityUIElement::columnIndexRange): Deleted.
453         (WTR::AccessibilityUIElement::rowCount): Deleted.
454         (WTR::AccessibilityUIElement::columnCount): Deleted.
455         (WTR::AccessibilityUIElement::rowHeaders): Deleted.
456         (WTR::AccessibilityUIElement::columnHeaders): Deleted.
457         (WTR::AccessibilityUIElement::selectedRowAtIndex): Deleted.
458         (WTR::AccessibilityUIElement::disclosedByRow): Deleted.
459         (WTR::AccessibilityUIElement::disclosedRowAtIndex): Deleted.
460         (WTR::AccessibilityUIElement::rowAtIndex): Deleted.
461         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex): Deleted.
462         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex): Deleted.
463         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex): Deleted.
464         (WTR::AccessibilityUIElement::ariaIsGrabbed): Deleted.
465         (WTR::AccessibilityUIElement::ariaDropEffects): Deleted.
466         (WTR::AccessibilityUIElement::classList): Deleted.
467         (WTR::AccessibilityUIElement::lineForIndex): Deleted.
468         (WTR::AccessibilityUIElement::rangeForLine): Deleted.
469         (WTR::AccessibilityUIElement::rangeForPosition): Deleted.
470         (WTR::AccessibilityUIElement::boundsForRange): Deleted.
471         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
472         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Deleted.
473         (WTR::AccessibilityUIElement::stringForRange): Deleted.
474         (WTR::AccessibilityUIElement::attributedStringForRange): Deleted.
475         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled): Deleted.
476         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate): Deleted.
477         (WTR::AccessibilityUIElement::uiElementForSearchPredicate): Deleted.
478         (WTR::AccessibilityUIElement::selectTextWithCriteria): Deleted.
479         (WTR::AccessibilityUIElement::cellForColumnAndRow): Deleted.
480         (WTR::AccessibilityUIElement::horizontalScrollbar): Deleted.
481         (WTR::AccessibilityUIElement::verticalScrollbar): Deleted.
482         (WTR::AccessibilityUIElement::addNotificationListener): Deleted.
483         (WTR::AccessibilityUIElement::removeNotificationListener): Deleted.
484         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Deleted.
485         (WTR::AccessibilityUIElement::textMarkerRangeForElement): Deleted.
486         (WTR::AccessibilityUIElement::textMarkerRangeLength): Deleted.
487         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Deleted.
488         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Deleted.
489         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Deleted.
490         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Deleted.
491         (WTR::AccessibilityUIElement::endTextMarkerForBounds): Deleted.
492         (WTR::AccessibilityUIElement::startTextMarkerForBounds): Deleted.
493         (WTR::AccessibilityUIElement::textMarkerForPoint): Deleted.
494         (WTR::AccessibilityUIElement::previousTextMarker): Deleted.
495         (WTR::AccessibilityUIElement::nextTextMarker): Deleted.
496         (WTR::AccessibilityUIElement::startTextMarker): Deleted.
497         (WTR::AccessibilityUIElement::endTextMarker): Deleted.
498         (WTR::AccessibilityUIElement::stringForTextMarkerRange): Deleted.
499         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Deleted.
500         (WTR::AccessibilityUIElement::indexForTextMarker): Deleted.
501         (WTR::AccessibilityUIElement::isTextMarkerValid): Deleted.
502         (WTR::AccessibilityUIElement::textMarkerForIndex): Deleted.
503         (WTR::AccessibilityUIElement::scrollToMakeVisible): Deleted.
504         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Deleted.
505         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus): Deleted.
506         (WTR::AccessibilityUIElement::supportedActions): Deleted.
507         (WTR::AccessibilityUIElement::mathPostscriptsDescription): Deleted.
508         (WTR::AccessibilityUIElement::mathPrescriptsDescription): Deleted.
509         (WTR::AccessibilityUIElement::pathDescription): Deleted.
510         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
511         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
512         (WTR::EventSendingController::create):
513         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
514         * WebKitTestRunner/InjectedBundle/GCController.cpp:
515         (WTR::GCController::create):
516         * WebKitTestRunner/InjectedBundle/GCController.h:
517         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
518         (WTR::InjectedBundle::beginTesting):
519         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
520         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
521         (WTR::TestRunner::create):
522         * WebKitTestRunner/InjectedBundle/TestRunner.h:
523         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
524         (WTR::TextInputController::create):
525         * WebKitTestRunner/InjectedBundle/TextInputController.h:
526         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
527         (WTR::AccessibilityController::accessibleElementById):
528         (WTR::AccessibilityController::rootElement):
529         (WTR::AccessibilityController::focusedElement):
530         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
531         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
532         (WTR::AccessibilityNotificationHandler::create):
533         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
534         (WTR::AccessibilityUIElement::elementAtPoint):
535         (WTR::AccessibilityUIElement::childAtIndex):
536         (WTR::accessibilityElementAtIndex):
537         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
538         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
539         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
540         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
541         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
542         (WTR::AccessibilityUIElement::rowAtIndex):
543         (WTR::AccessibilityUIElement::selectedChildAtIndex):
544         (WTR::AccessibilityUIElement::selectedRowAtIndex):
545         (WTR::AccessibilityUIElement::titleUIElement):
546         (WTR::AccessibilityUIElement::parentElement):
547         (WTR::AccessibilityUIElement::disclosedByRow):
548         (WTR::AccessibilityUIElement::uiElementAttributeValue):
549         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
550         (WTR::AccessibilityUIElement::cellForColumnAndRow):
551         (WTR::AccessibilityUIElement::horizontalScrollbar):
552         (WTR::AccessibilityUIElement::verticalScrollbar):
553         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
554         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
555         (WTR::AccessibilityUIElement::previousTextMarker):
556         (WTR::AccessibilityUIElement::nextTextMarker):
557         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
558         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
559         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
560         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
561         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
562         (WTR::AccessibilityUIElement::textMarkerForPoint):
563         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
564         (WTR::AccessibilityUIElement::textMarkerForIndex):
565         (WTR::AccessibilityUIElement::startTextMarker):
566         (WTR::AccessibilityUIElement::endTextMarker):
567         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
568         (WTR::AccessibilityController::accessibleElementById):
569         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
570         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
571         (WTR::AccessibilityUIElement::headerElementAtIndex):
572         (WTR::AccessibilityUIElement::linkedElement):
573         (WTR::AccessibilityUIElement::elementAtPoint):
574         (WTR::AccessibilityUIElement::childAtIndex):
575         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
576         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
577         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
578         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
579         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
580         (WTR::AccessibilityUIElement::rowAtIndex):
581         (WTR::AccessibilityUIElement::selectedChildAtIndex):
582         (WTR::AccessibilityUIElement::selectedRowAtIndex):
583         (WTR::AccessibilityUIElement::titleUIElement):
584         (WTR::AccessibilityUIElement::parentElement):
585         (WTR::AccessibilityUIElement::disclosedByRow):
586         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
587         (WTR::AccessibilityUIElement::uiElementAttributeValue):
588         (WTR::AccessibilityUIElement::rangeForLine):
589         (WTR::AccessibilityUIElement::rangeForPosition):
590         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
591         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
592         (WTR::AccessibilityUIElement::cellForColumnAndRow):
593         (WTR::AccessibilityUIElement::horizontalScrollbar):
594         (WTR::AccessibilityUIElement::verticalScrollbar):
595         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
596         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
597         (WTR::AccessibilityUIElement::previousTextMarker):
598         (WTR::AccessibilityUIElement::nextTextMarker):
599         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
600         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
601         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
602         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
603         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
604         (WTR::AccessibilityUIElement::textMarkerForPoint):
605         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
606         (WTR::AccessibilityUIElement::textMarkerForIndex):
607         (WTR::AccessibilityUIElement::startTextMarker):
608         (WTR::AccessibilityUIElement::endTextMarker):
609         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
610         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
611         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
612         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
613         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
614         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
615         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
616         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
617         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
618         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
619         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
620         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
621         (WTR::AccessibilityUIElement::supportedActions):
622         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
623         (WTR::AccessibilityController::accessibleElementById):
624         (WTR::AccessibilityController::logAccessibilityEvents): Deleted.
625         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
626         (makeValueRefForValue):
627         (-[AccessibilityNotificationHandler _notificationReceived:]):
628         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
629         (WTR::AccessibilityUIElement::elementAtPoint):
630         (WTR::AccessibilityUIElement::childAtIndex):
631         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
632         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
633         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
634         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
635         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
636         (WTR::AccessibilityUIElement::rowAtIndex):
637         (WTR::AccessibilityUIElement::selectedChildAtIndex):
638         (WTR::AccessibilityUIElement::selectedRowAtIndex):
639         (WTR::AccessibilityUIElement::titleUIElement):
640         (WTR::AccessibilityUIElement::parentElement):
641         (WTR::AccessibilityUIElement::disclosedByRow):
642         (WTR::AccessibilityUIElement::uiElementAttributeValue):
643         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
644         (WTR::AccessibilityUIElement::cellForColumnAndRow):
645         (WTR::AccessibilityUIElement::horizontalScrollbar):
646         (WTR::AccessibilityUIElement::verticalScrollbar):
647         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
648         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
649         (WTR::AccessibilityUIElement::previousTextMarker):
650         (WTR::AccessibilityUIElement::nextTextMarker):
651         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
652         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
653         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
654         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
655         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
656         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
657         (WTR::AccessibilityUIElement::textMarkerForPoint):
658         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
659         (WTR::AccessibilityUIElement::textMarkerForIndex):
660         (WTR::AccessibilityUIElement::startTextMarker):
661         (WTR::AccessibilityUIElement::endTextMarker):
662         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
663         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
664         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
665         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
666         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
667         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
668         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
669         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
670         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
671         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
672         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
673         (WTR::keyPadName):
674         (WTR::keyName):
675
676 2016-11-02  Alex Christensen  <achristensen@webkit.org>
677
678         Remove Battery Status API from the tree
679         https://bugs.webkit.org/show_bug.cgi?id=164213
680
681         Reviewed by Sam Weinig.
682
683         * Scripts/webkitperl/FeatureList.pm:
684         * Scripts/webkitpy/common/config/watchlist:
685
686 2016-11-02  Olivier Blin  <olivier.blin@softathome.com>
687
688         [GTK] Use libgcrypt instead of GnuTLS for CryptoDigest and SubtleCrypto HMAC implementation
689         https://bugs.webkit.org/show_bug.cgi?id=163125
690
691         Reviewed by Michael Catanzaro.
692
693         * gtk/install-dependencies: List libgcrypt for WebKitGTK+ build, and gnutls for jhbuild only.
694         gnutls is useful for glib-networking in jhbuild.
695
696 2016-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
697
698         NetworkSession: Network process crash when converting main resource to download
699         https://bugs.webkit.org/show_bug.cgi?id=164220
700
701         Reviewed by Alex Christensen.
702
703         Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
704         converted to a download and another one to test the cancellation as the test was doing before. When doing the
705         full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
706         download.
707
708         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
709         (testPolicyResponseDownload):
710         (testPolicyResponseDownloadCancel):
711         (beforeAll):
712
713 2016-11-01  Alex Christensen  <achristensen@webkit.org>
714
715         Remove PassRefPtr from DumpRenderTree
716         https://bugs.webkit.org/show_bug.cgi?id=164307
717
718         Reviewed by Sam Weinig.
719
720         * DumpRenderTree/PixelDumpSupport.h:
721         * DumpRenderTree/TestRunner.cpp:
722         (TestRunner::create):
723         * DumpRenderTree/TestRunner.h:
724         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
725         (createBitmapContext):
726         * DumpRenderTree/cg/PixelDumpSupportCG.h:
727         (BitmapContext::createByAdoptingBitmapAndContext):
728         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
729         (createBitmapContextFromWebView):
730         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
731         (createBitmapContextFromWebView):
732         (createPagedBitmapContext):
733         * DumpRenderTree/mac/TestRunnerMac.mm:
734         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
735         (createBitmapContextFromWebView):
736         * DumpRenderTree/win/TextInputController.h:
737
738 2016-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
739
740         [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp
741         https://bugs.webkit.org/show_bug.cgi?id=161481
742
743         Reviewed by Michael Catanzaro.
744
745         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
746         (WebKitTestBus::WebKitTestBus):
747         (WebKitTestBus::~WebKitTestBus):
748         (WebKitTestBus::run):
749         (WebKitTestBus::getOrCreateConnection):
750         (WebKitTestBus::createProxy):
751         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
752
753 2016-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
754
755         Unreviewed. Fix /webkit2/WebKitWebContext/get-plugins in the bots after r208273.
756
757         The test fails now if WEBKIT_TEST_PLUGIN_DIR contains symlinks, which is the case of the GTK+ bots.
758
759         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
760         (testWebContextGetPlugins): Use realpath with WEBKIT_TEST_PLUGIN_DIR when building the expected plugins path.
761
762 2016-11-02  Romain Bellessort  <romain.bellessort@crf.canon.fr>
763
764         [Readable Streams API] Enable creation of ReadableByteStreamController
765         https://bugs.webkit.org/show_bug.cgi?id=164014
766
767         Reviewed by Youenn Fablet.
768
769         Enable the byte stream part of Readable Streams API by default.
770
771         * Scripts/webkitperl/FeatureList.pm:
772         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
773
774 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
775
776         Remove CUSTOM_ELEMENTS build flag
777         https://bugs.webkit.org/show_bug.cgi?id=164267
778
779         Reviewed by Antti Koivisto.
780
781         Removed the build flag.
782
783         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
784
785 2016-11-01  Alex Christensen  <achristensen@webkit.org>
786
787         Percent-encode non-ASCII code points in hosts of URLs with unrecognized schemes
788         https://bugs.webkit.org/show_bug.cgi?id=164290
789
790         Reviewed by Tim Horton.
791
792         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
793         (TestWebKitAPI::checkRelativeURL):
794         (TestWebKitAPI::checkURLDifferences):
795         (TestWebKitAPI::checkRelativeURLDifferences):
796         Move helper functions to the top so I can use them from any tests.
797         (TestWebKitAPI::shouldFail):
798         (TestWebKitAPI::checkURL):
799         (TestWebKitAPI::TEST_F):
800
801 2016-11-01  Hyowon Kim  <hw1008.kim@samsung.com>
802
803         [GTK] Failed to generate GeoClue2Interface files.
804         https://bugs.webkit.org/show_bug.cgi?id=164270
805
806         Reviewed by Michael Catanzaro.
807
808         To generate codes for D-Bus interfaces,
809         geoclue-2.0 package including D-Bus introspection XML files should be installed.
810
811         * gtk/install-dependencies: add geoclue-2.0 package.
812
813 2016-11-01  Fujii Hironori  <Hironori.Fujii@sony.com>
814
815         [CMake] generate-bindings-all.pl uses USES_TERMINAL which leaves a noisy line in interactive Ninja build
816         https://bugs.webkit.org/show_bug.cgi?id=163868
817
818         Reviewed by Michael Catanzaro.
819
820         It takes long time for generate-bindings-all.pl to generate all
821         bindings.  So, it shows the progress while running and
822         USES_TERMINAL option of add_custom_target have been used to invoke
823         the command.  However, USES_TERMINAL leaves a noisy line in
824         Ninja's neat build log of interactive build.
825
826         A new CMake option SHOW_BINDINGS_GENERATION_PROGRESS is added to
827         stop using USES_TERMINAL only in case of interactive Ninja build.
828
829         * Scripts/webkitdirs.pm:
830         (generateBuildSystemFromCMakeProject): Enable
831         SHOW_BINDINGS_GENERATION_PROGRESS not in case of interactive
832         Ninja build.
833
834 2016-10-31  Simon Fraser  <simon.fraser@apple.com>
835
836         Add basic visual/layout viewport support for fixed position layout
837         https://bugs.webkit.org/show_bug.cgi?id=164261
838
839         Reviewed by Dean Jackson.
840
841         Don't give tests in the "visual-viewport" directory a flexible viewport.
842
843         * DumpRenderTree/mac/DumpRenderTree.mm:
844         (shouldMakeViewportFlexible):
845         * WebKitTestRunner/TestOptions.cpp:
846         (WTR::shouldMakeViewportFlexible):
847
848 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
849
850         JSC should support SharedArrayBuffer
851         https://bugs.webkit.org/show_bug.cgi?id=163986
852
853         Reviewed by Keith Miller.
854         
855         Use the right kind of typed array API.
856
857         * DumpRenderTree/TestRunner.cpp:
858         (setAudioResultCallback):
859
860 2016-10-31  Simon Fraser  <simon.fraser@apple.com>
861
862         Make UIScriptController::zoomToScale() work on Mac WK1 and WK2
863         https://bugs.webkit.org/show_bug.cgi?id=164238
864
865         Reviewed by Dean Jackson.
866
867         Implement UIScriptController::zoomToScale() for WTR and DRT on Mac.
868
869         * DumpRenderTree/mac/UIScriptControllerMac.mm:
870         (WTR::UIScriptController::zoomToScale):
871         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
872         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
873         (WTR::UIScriptController::zoomToScale):
874
875 2016-10-31  Dewei Zhu  <dewei_zhu@apple.com>
876
877         Update twisted version in webkitpy.thirdparty.autoinstalled module.
878         https://bugs.webkit.org/show_bug.cgi?id=154667
879
880         Reviewed by Ryosuke Niwa.
881
882         Use twisted_15_5_0 for the twisted module used by run-benchmark because there is a bug in twisted 12.1.0 which sometimes stops the test.
883         Installing twisted was introduced in https://bugs.webkit.org/show_bug.cgi?id=147082 for run-benchmark script.
884         Since buildbot relies on twisted 12.1.0 and has not been verified the compatibility on twisted 15.5.0, it would be more secure to use an individual version for run-benchmark script.
885
886         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
887         * Scripts/webkitpy/thirdparty/__init__.py:
888         (AutoinstallImportHook.find_module):
889         (AutoinstallImportHook._install_twisted_15_5_0):
890         (AutoinstallImportHook._install_twisted): Deleted.
891
892 2016-10-31  Ryosuke Niwa  <rniwa@webkit.org>
893
894         Enable custom elements by default everywhere
895         https://bugs.webkit.org/show_bug.cgi?id=164242
896
897         Reviewed by Antti Koivisto.
898
899         Enable custom elements API on every port by default.
900
901         * Scripts/webkitperl/FeatureList.pm:
902
903 2016-10-31  Nan Wang  <n_wang@apple.com>
904
905         AX: aria-sort is not exposed on iOS
906         https://bugs.webkit.org/show_bug.cgi?id=164245
907
908         Reviewed by Chris Fleizach.
909
910         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
911         (AccessibilityUIElement::stringAttributeValue):
912         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
913         (WTR::AccessibilityUIElement::stringAttributeValue):
914
915 2016-10-31  Simon Fraser  <simon.fraser@apple.com>
916
917         Implement IntersectionObserver
918         https://bugs.webkit.org/show_bug.cgi?id=159475
919
920         Reviewed by Ryosuke Niwa.
921         
922         Add ENABLE_INTERSECTION_OBSERVER, enabled by default.
923
924         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
925
926 2016-10-31  Ryan Haddad  <ryanhaddad@apple.com>
927
928         Unreviewed, rolling out r208154.
929
930         This change caused an assertion failure during API tests on
931         macOS.
932
933         Reverted changeset:
934
935         "NetworkSession: Network process crash when converting main
936         resource to download"
937         https://bugs.webkit.org/show_bug.cgi?id=164220
938         http://trac.webkit.org/changeset/208154
939
940 2016-10-31  Said Abou-Hallawa  <sabouhallawa@apple.com>
941
942         Unreviewed, change my status to be a WebKit reviewer
943
944         * Scripts/webkitpy/common/config/contributors.json:
945
946 2016-10-31  Carlos Garcia Campos  <cgarcia@igalia.com>
947
948         NetworkSession: Network process crash when converting main resource to download
949         https://bugs.webkit.org/show_bug.cgi?id=164220
950
951         Reviewed by Alex Christensen.
952
953         Split /webkit2/Downloads/policy-decision-download in two, one to test the full load when main resource is
954         converted to a download and another one to test the cancellation as the test was doing before. When doing the
955         full load, delay a bit the decide destination to ensure the load is aborted before the data task has became a
956         download.
957
958         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
959         (testPolicyResponseDownload):
960         (testPolicyResponseDownloadCancel):
961         (beforeAll):
962
963 2016-10-31  Keith Miller  <keith_miller@apple.com>
964
965         Unreviewed, fix watchlist regexp for wasm.
966
967         * Scripts/webkitpy/common/config/watchlist:
968
969 2016-10-31  Keith Miller  <keith_miller@apple.com>
970
971         autogenerated files from wasm.json should be in derived sources.
972         https://bugs.webkit.org/show_bug.cgi?id=164152
973
974         Reviewed by Filip Pizlo.
975
976         Add message to make sure that people keep the wasm.jsons up to date.
977
978         * Scripts/webkitpy/common/config/watchlist:
979
980 2016-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
981
982         Holding down a key to choose an accented character should fire "insertReplacementText" input events
983         https://bugs.webkit.org/show_bug.cgi?id=164209
984         <rdar://problem/29019305>
985
986         Reviewed by Darin Adler.
987
988         Adds test support for inserting replacement text on Mac. This is equivalent to holding down a vowel key (e.g.
989         'a') to bring up the menu containing accented version of the character, then selecting an accented character to
990         insert in place of the typed character. This is exposed via UIScriptController.insertText, which takes a string
991         and an insertion range.
992
993         * DumpRenderTree/mac/UIScriptControllerMac.mm:
994         (WTR::UIScriptController::insertText):
995         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
996
997         Note that there is no callback argument to insertText, since UIScriptController::insertText is synchronous in
998         the UI process. The tests end when corresponding input events fired as a result of insertText have been received
999         in the web process. Please see the new layout tests for more detail.
1000
1001         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1002         (WTR::UIScriptController::insertText):
1003         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1004         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1005         (WTR::nsStringFromJSString):
1006         (WTR::UIScriptController::insertText):
1007
1008 2016-10-30  Sam Weinig  <sam@webkit.org>
1009
1010         [WebIDL] Restructure IDLParser structs to better match modern WebIDL concepts
1011         https://bugs.webkit.org/show_bug.cgi?id=164208
1012
1013         Reviewed by Darin Adler.
1014
1015         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1016         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1017         Update for new struct types.
1018
1019 2016-10-29  Darin Adler  <darin@apple.com>
1020
1021         Fix failing ExtendedColor tests.
1022
1023         * TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp:
1024         Changed the tests in two ways: First, use EXPECT_EQ instead of EXPECT_TRUE
1025         for the string equality comparisons. This required including WTFStringUtilities.h.
1026         Second, change expected results to match what the code is currently generating,
1027         so alpha channels are "0.25" rather than "0.25 / 1". I'll let Dean fix both these
1028         tests and the code if these results are incorrect.
1029
1030 2016-10-29  Wenson Hsieh  <wenson_hsieh@apple.com>
1031
1032         UIScriptControllerIOS.mm should not be soft-linking UIKit
1033         https://bugs.webkit.org/show_bug.cgi?id=164171
1034
1035         Reviewed by Darin Adler.
1036
1037         Follow-up to r208090. Instead of soft-linking, we can simply grab UIKeyboardPredictionView by name instead.
1038
1039         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1040         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
1041
1042 2016-10-28  Darin Adler  <darin@apple.com>
1043
1044         Move all classes in the HTML directory from ExceptionCode to Exception
1045         https://bugs.webkit.org/show_bug.cgi?id=163876
1046
1047         Reviewed by Sam Weinig.
1048
1049         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp:
1050         (TestWebKitAPI::ToString): Updated for changes to the TimeRanges class.
1051         (TestWebKitAPI::TEST): Ditto.
1052
1053 2016-10-28  Devin Rousso  <dcrousso+webkit@gmail.com>
1054
1055         Unreviewed, changed Devin Rousso's email and nick.
1056
1057         * Scripts/webkitpy/common/config/contributors.json:
1058
1059 2016-10-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1060
1061         Unreviewed, fix the iOS build after r208090.
1062
1063         Use soft-linking as needed in UIScriptControllerIOS.mm.
1064
1065         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1066         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
1067
1068 2016-10-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1069
1070         iOS autocorrection does not trigger an input event of inputType "insertReplacementText"
1071         https://bugs.webkit.org/show_bug.cgi?id=164077
1072         <rdar://problem/28987810>
1073
1074         Reviewed by Simon Fraser.
1075
1076         Adds test support for inserting text candidates on iOS in the form of
1077         UIScriptController.selectTextCandidateAtIndex(index, callback), which selects the text candidate at a given
1078         index (this needs to be a value between 0-2 on iOS) and fires the callback when done.
1079
1080         To implement this, we wait for the text prediction view to have predictions (we determine this by polling at a
1081         given interval) and then tap the center of the text prediction view at the given index.
1082
1083         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1084         (WTR::UIScriptController::selectTextCandidateAtIndex):
1085         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1086         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1087         (WTR::UIScriptController::selectTextCandidateAtIndex):
1088         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
1089         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1090         * WebKitTestRunner/ios/UIKitSPI.h:
1091         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1092         (WTR::UIScriptController::selectTextCandidateAtIndex):
1093         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):
1094
1095 2016-10-28  Commit Queue  <commit-queue@webkit.org>
1096
1097         Unreviewed, rolling out r207700.
1098         https://bugs.webkit.org/show_bug.cgi?id=164168
1099
1100         We are ready after r208086 (Requested by alexchristensen on
1101         #webkit).
1102
1103         Reverted changeset:
1104
1105         "Unreviewed, rolling out r207582."
1106         https://bugs.webkit.org/show_bug.cgi?id=163819
1107         http://trac.webkit.org/changeset/207700
1108
1109 2016-10-28  Alex Christensen  <achristensen@webkit.org>
1110
1111         Partially revert 207805 after resolution in URL spec issue 87
1112         https://bugs.webkit.org/show_bug.cgi?id=164142
1113
1114         Reviewed by Andy Estes.
1115
1116         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1117         (TestWebKitAPI::TEST_F):
1118
1119 2016-10-28  Alex Christensen  <achristensen@webkit.org>
1120
1121         URLParser should not try to interpret host of URLs with unrecognized schemes as IPv4 address
1122         https://bugs.webkit.org/show_bug.cgi?id=164154
1123
1124         Reviewed by Andy Estes.
1125
1126         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1127         (TestWebKitAPI::TEST_F):
1128
1129 2016-10-28  Sam Weinig  <sam@webkit.org>
1130
1131         [WebIDL] Update parser and code generators to only access type information through the type property
1132         https://bugs.webkit.org/show_bug.cgi?id=164141
1133
1134         Reviewed by Anders Carlsson.
1135
1136         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1137         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1138         Update to always access type information through type accessors. Remove use of removed
1139         properties.
1140
1141 2016-10-28  Frederic Wang  <fwang@igalia.com>
1142
1143         [GTK] Upgrade HarfBuzz to version 1.3.3
1144         https://bugs.webkit.org/show_bug.cgi?id=162719
1145
1146         Reviewed by Michael Catanzaro.
1147
1148         * gtk/jhbuild.modules:
1149
1150 2016-10-27  Chris Dumez  <cdumez@apple.com>
1151
1152         Regression(r203601): Caused crashes in iBooks
1153         https://bugs.webkit.org/show_bug.cgi?id=164093
1154         <rdar://problem/28745634>
1155
1156         Reviewed by Darin Adler.
1157
1158         Add API test coverage.
1159
1160         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1161         * TestWebKitAPI/Tests/mac/DOMNode.mm: Added.
1162         (-[DOMNodeTest webView:didFinishLoadForFrame:]):
1163         (TestWebKitAPI::TEST):
1164
1165 2016-10-27  Sam Weinig  <sam@webkit.org>
1166
1167         [WebIDL] Move code generators off of domSignature::type and onto domSignature::idlType
1168         https://bugs.webkit.org/show_bug.cgi?id=164089
1169
1170         Reviewed by Alex Christensen.
1171
1172         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1173         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1174         Update for the removal of domSignature::type, and new signatures of helper predicates.
1175
1176 2016-10-27  Commit Queue  <commit-queue@webkit.org>
1177
1178         Unreviewed, rolling out r207992.
1179         https://bugs.webkit.org/show_bug.cgi?id=164070
1180
1181         triggered aclocal version conflict (Requested by mcatanzaro on
1182         #webkit).
1183
1184         Reverted changeset:
1185
1186         "[GTK] Bump glib to 2.50.1 (or find alternative solution to
1187         Gtk+ CUPS build issue)"
1188         https://bugs.webkit.org/show_bug.cgi?id=163689
1189         http://trac.webkit.org/changeset/207992
1190
1191 2016-10-27  Joanmarie Diggs  <jdiggs@igalia.com>
1192
1193         [GTK] Bump glib to 2.50.1 (or find alternative solution to Gtk+ CUPS build issue)
1194         https://bugs.webkit.org/show_bug.cgi?id=163689
1195
1196         Reviewed by Michael Catanzaro.
1197
1198         In order to fix bug #163591, we need to apply an upstream patch to GTK+.
1199         But GTK+ won't build with that patch due to the following error:
1200
1201             m4_copy: won't overwrite defined macro: glib_DEFUN
1202
1203         There is an upstream GLib patch which solves that issue. We should apply
1204         that patch as well, until we bump GLib to 2.50.1 or later.
1205
1206         * gtk/jhbuild.modules: Apply upstream GLib patch.
1207         * gtk/patches/glib-deprecate-am-glib-gnu-gettext.patch: Added.
1208
1209 2016-10-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1210
1211         Unreviewed fix of GTK and EFL test bots.
1212
1213         * Scripts/webkitperl/FeatureList.pm: Deactivated media-source and
1214         legacy-encrypted-media by default for GTK and EFL.
1215
1216 2016-10-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1217
1218         [GTK] JSC test wasm.yaml/wasm/js-api/test_basic_api.js.default-wasm and wasm.yaml/wasm/js-api/test_Module.js.default-wasm fail with Exception: ReferenceError: Can't find variable: WebAssembly
1219         https://bugs.webkit.org/show_bug.cgi?id=163846
1220
1221         Reviewed by Michael Catanzaro.
1222
1223         WebAssembly is now developed for Darwin right now.
1224         Disable WASM tests in the other platforms.
1225
1226         * Scripts/run-jsc-stress-tests:
1227
1228 2016-10-26  Enrique Ocaña González  <eocanha@igalia.com>
1229
1230         [cmake][GStreamer][MSE][EME] Build MSE and EME code after refactoring
1231         https://bugs.webkit.org/show_bug.cgi?id=162928
1232
1233         Reviewed by Xabier Rodriguez-Calvar.
1234
1235         Explicitly enable MSE and EME on WebKitGTK+ buildbots.
1236
1237         This patch is co-authored with Philippe Normand <philn@igalia.com> (EME support).
1238
1239         * Scripts/webkitperl/FeatureList.pm:
1240
1241 2016-10-25  Antoine Quint  <graouts@apple.com>
1242
1243         [Modern Media Controls] Media Controller: skip back support
1244         https://bugs.webkit.org/show_bug.cgi?id=163725
1245         <rdar://problem/27989480>
1246
1247         Reviewed by Dean Jackson.
1248
1249         * Scripts/webkitpy/layout_tests/servers/aliases.json: Adding a new alias such that we may
1250         access the modern-media-controls source files through the web server.
1251
1252 2016-10-19  Jer Noble  <jer.noble@apple.com>
1253
1254         Add WKWebView fullscreen delegate SPI
1255         https://bugs.webkit.org/show_bug.cgi?id=163674
1256
1257         Reviewed by Anders Carlsson.
1258
1259         Add a new API test which verifies that the fullscreen delegate receives notifications.
1260
1261         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
1262         (-[FullscreenDelegateMessageHandler userContentController:didReceiveScriptMessage:]):
1263         (-[FullscreenDelegateMessageHandler _webViewWillEnterFullscreen:]):
1264         (-[FullscreenDelegateMessageHandler _webViewDidEnterFullscreen:]):
1265         (-[FullscreenDelegateMessageHandler _webViewWillExitFullscreen:]):
1266         (-[FullscreenDelegateMessageHandler _webViewDidExitFullscreen:]):
1267         (TestWebKitAPI::TEST):
1268
1269 2016-10-24  Alex Christensen  <achristensen@webkit.org>
1270
1271         URLParser should match old URL::parse with %2E in path
1272         https://bugs.webkit.org/show_bug.cgi?id=163929
1273
1274         Reviewed by Alexey Proskuryakov.
1275
1276         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1277         (TestWebKitAPI::TEST_F):
1278
1279 2016-10-24  Ryan Haddad  <ryanhaddad@apple.com>
1280
1281         Unreviewed, rolling out r207795.
1282
1283         Introduced API test failures on iOS and macOS.
1284
1285         Reverted changeset:
1286
1287         "URLParser should match old URL::parse with %2E in path"
1288         https://bugs.webkit.org/show_bug.cgi?id=163929
1289         http://trac.webkit.org/changeset/207795
1290
1291 2016-10-24  Alex Christensen  <achristensen@webkit.org>
1292
1293         URLParser should match old URL::parse with %2E in path
1294         https://bugs.webkit.org/show_bug.cgi?id=163929
1295
1296         Reviewed by Alexey Proskuryakov.
1297
1298         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1299         (TestWebKitAPI::TEST_F):
1300
1301 2016-10-21  Alex Christensen  <achristensen@webkit.org>
1302
1303         URL::port should return Optional<uint16_t>
1304         https://bugs.webkit.org/show_bug.cgi?id=163806
1305
1306         Reviewed by Darin Adler.
1307
1308         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1309         (TestWebKitAPI::TEST_F):
1310         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1311         (TestWebKitAPI::checkURL):
1312         (TestWebKitAPI::checkRelativeURL):
1313         (TestWebKitAPI::checkURLDifferences):
1314         (TestWebKitAPI::checkRelativeURLDifferences):
1315         (TestWebKitAPI::TEST_F):
1316
1317 2016-10-24  Youenn Fablet  <youenn@apple.com>
1318
1319         Activate WEB_RTC compilation flags for Mac bots
1320         https://bugs.webkit.org/show_bug.cgi?id=163886
1321
1322         Reviewed by Eric Carlson.
1323
1324         * Scripts/webkitperl/FeatureList.pm:
1325         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1326
1327 2016-10-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1328
1329         Unreviewed, add myself as a WebKit reviewer
1330
1331         * Scripts/webkitpy/common/config/contributors.json:
1332
1333 2016-10-22  Dan Bernstein  <mitz@apple.com>
1334
1335         Improve MiniBrowser window titles for URLs without paths and with no title
1336         <https://webkit.org/b/163843>
1337
1338         Reviewed by Darin Adler.
1339
1340         * MiniBrowser/mac/WK1BrowserWindowController.m:
1341         (-[WK1BrowserWindowController fetch:]): While we’re here, deploy
1342           +[NSURL _webkit_URLWithUserTypedString:] here to match the WK2BrowserWindowController
1343           version of this method.
1344         (-[WK1BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
1345           use the entire URL.
1346         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]): Also while we’re here,
1347           deploy +[NSURL _web_userVisibleString] here to match the WK2BrowserWindowController
1348           behavior.
1349
1350         * MiniBrowser/mac/WK2BrowserWindowController.m:
1351         (-[WK2BrowserWindowController updateTitle:]): If the URL doesn’t have a lastPathComponent,
1352           use the entire URL.
1353
1354 2016-10-21  David Kilzer  <ddkilzer@apple.com>
1355
1356         Bug 163762: IntSize::area() should used checked arithmetic
1357         <https://webkit.org/b/163762>
1358
1359         Reviewed by Darin Adler.
1360
1361         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
1362         (TestWebKitAPI::TEST): Call unsafeGet().
1363         * TestWebKitAPI/Tests/WebCore/IntSize.cpp:
1364         (TestWebKitAPI::TEST): Ditto.
1365
1366 2016-10-21  James Craig  <jcraig@apple.com>
1367
1368         Unreviewed: Added Aaron Chu <aaron_chu@apple.com> to contributors list.
1369
1370         * Scripts/webkitpy/common/config/contributors.json:
1371
1372 2016-10-21  Commit Queue  <commit-queue@webkit.org>
1373
1374         Unreviewed, rolling out r207582.
1375         https://bugs.webkit.org/show_bug.cgi?id=163819
1376
1377         Not quite ready rdar://problem/28897179 (Requested by
1378         alexchristensen on #webkit).
1379
1380         Reverted changeset:
1381
1382         "Re-enable URLParser for non-Safari Cocoa apps after r207321"
1383         https://bugs.webkit.org/show_bug.cgi?id=163690
1384         http://trac.webkit.org/changeset/207582
1385
1386 2016-10-21  Jonathan Bedard  <jbedard@apple.com>
1387
1388         WebKitTestRunnerApp packages .idl file
1389         https://bugs.webkit.org/show_bug.cgi?id=163788
1390
1391         Reviewed by Darin Adler.
1392
1393         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Removed .idl file from app package, removed bad reference to app icon.
1394
1395 2016-10-21  Csaba Osztrogonác  <ossy@webkit.org>
1396
1397         [EFL] REGRESSION(r207616): Build is broken due to missing libgeoclue-dev package
1398         https://bugs.webkit.org/show_bug.cgi?id=163733
1399
1400         Reviewed by Gyuyoung Kim.
1401
1402         * efl/install-dependencies: Added geoclue-2.0 package.
1403
1404 2016-10-21  Commit Queue  <commit-queue@webkit.org>
1405
1406         Unreviewed, rolling out r207609.
1407         https://bugs.webkit.org/show_bug.cgi?id=163776
1408
1409         As glib bump was rollout, we need to rollout this too
1410         (Requested by rego on #webkit).
1411
1412         Reverted changeset:
1413
1414         "[GTK] Cannot build GTK+ with CUPS 2.* versions"
1415         https://bugs.webkit.org/show_bug.cgi?id=163591
1416         http://trac.webkit.org/changeset/207609
1417
1418 2016-10-20  Chris Dumez  <cdumez@apple.com>
1419
1420         "Download Linked File" context menu action should use 'download' attribute as suggested filename
1421         https://bugs.webkit.org/show_bug.cgi?id=163742
1422         <rdar://problem/28840734>
1423
1424         Reviewed by Darin Adler.
1425
1426         Add API test coverage.
1427
1428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1429         * TestWebKitAPI/Tests/WebKit2/link-with-download-attribute.html: Added.
1430         * TestWebKitAPI/Tests/WebKit2/mac/ContextMenuDownload.mm: Added.
1431         (TestWebKitAPI::didFinishLoadForFrame):
1432         (TestWebKitAPI::getContextMenuFromProposedMenu):
1433         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
1434         (TestWebKitAPI::TEST):
1435
1436 2016-10-20  Commit Queue  <commit-queue@webkit.org>
1437
1438         Unreviewed, rolling out r207589.
1439         https://bugs.webkit.org/show_bug.cgi?id=163765
1440
1441         Introduced 17 new layout test failures (Requested by
1442         mcatanzaro on #webkit).
1443
1444         Reverted changeset:
1445
1446         "[GTK] Bump glib to 2.50.1"
1447         https://bugs.webkit.org/show_bug.cgi?id=163689
1448         http://trac.webkit.org/changeset/207589
1449
1450 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
1451
1452         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
1453         https://bugs.webkit.org/show_bug.cgi?id=163374
1454
1455         Reviewed by Darin Adler.
1456
1457         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1458
1459 2016-10-20  Sam Weinig  <sam@webkit.org>
1460
1461         Add convenience function that combines WTF::visit(...) with WTF::makeVisitor(...)
1462         https://bugs.webkit.org/show_bug.cgi?id=163713
1463
1464         Reviewed by Dan Bernstein.
1465
1466         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1467         Add test for WTF::switchOn()
1468
1469 2016-10-20  Fujii Hironori  <Hironori.Fujii@sony.com>
1470
1471         [CMake] CMake does not support the dep files for implicit dependency
1472         https://bugs.webkit.org/show_bug.cgi?id=161433
1473
1474         Reviewed by Brent Fulgham.
1475
1476         Created a Perl script to generate all IDL bindings for CMake.
1477         This script can regenerate outdated bindings by based on the
1478         supplemental dependency and dep files created by
1479         '--write-dependencies' switch of generate-bindings.pl.
1480
1481         add_custom_target is used to invoke the script instead of
1482         add_custom_command because Ninja deletes all output files before
1483         executing the command in case of add_custom_command.
1484
1485         USES_TERMINAL option of add_custom_target has two effects:
1486         1) Not buffering output of the command
1487         2) Invoking the command in the special Ninja pool which inhibits parallel build
1488         One needs to use CMake 3.2 or later to enable this feature.
1489
1490         * DumpRenderTree/CMakeLists.txt: Specified a target name for
1491         GENERATE_BINDINGS. Added dependency for the target.
1492         * WebKitTestRunner/CMakeLists.txt: Ditto.
1493
1494 2016-10-20  Manuel Rego Casasnovas  <rego@igalia.com>
1495
1496         [GTK] Cannot build GTK+ with CUPS 2.* versions
1497         https://bugs.webkit.org/show_bug.cgi?id=163591
1498
1499         Reviewed by Michael Catanzaro.
1500
1501         GTK+ is wrongly checking about the available CUPS version,
1502         so if you have CUPS 2.* the configure step fails.
1503
1504         This has been already fixed upstream and included in 2.30 series:
1505         https://git.gnome.org/browse/gtk+/commit/?id=631f6b536485829a0bd00532f5826ad302b4951b
1506
1507         Added patch on JHBuild so we can now build GTK+ with CUPS 2.*.
1508
1509         * gtk/jhbuild.modules: Applied patch and avoid using "configure" script directly
1510         as the patch modifies "configure.ac".
1511         * gtk/patches/configure-fix-detecting-CUPS-2.x.patch: Added.
1512
1513 2016-10-20  Manuel Rego Casasnovas  <rego@igalia.com>
1514
1515         [GTK] Bump glib to 2.50.1
1516         https://bugs.webkit.org/show_bug.cgi?id=163689
1517
1518         Reviewed by Michael Catanzaro.
1519
1520         This is need in order to fix GTK+ build with CUPS 2.* (bug #163591).
1521
1522         * gtk/jhbuild.modules: Bump glib version. Pass --disable-libmount to build properly.
1523         Also we don't need the patches anymore.
1524         * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Removed.
1525         * gtk/patches/glib-warning-fix.patch: Removed.
1526
1527 2016-10-19  Alex Christensen  <achristensen@webkit.org>
1528
1529         Re-enable URLParser for non-Safari Cocoa apps after r207321
1530         https://bugs.webkit.org/show_bug.cgi?id=163690
1531
1532         Reviewed by Darin Adler.
1533
1534         * DumpRenderTree/mac/DumpRenderTree.mm:
1535         (DumpRenderTreeMain):
1536         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
1537         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1538         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
1539         (TestWebKitAPI::TEST):
1540         * WebKitTestRunner/TestController.cpp:
1541         (WTR::TestController::TestController):
1542
1543 2016-10-19  Ryan Haddad  <ryanhaddad@apple.com>
1544
1545         Unreviewed, rolling out r207557.
1546
1547         This change caused animations/font-variations tests to time
1548         out on pre-Sierra Macs.
1549
1550         Reverted changeset:
1551
1552         "[macOS] [iOS] Disable variation fonts on macOS El Capitan and
1553         iOS 9"
1554         https://bugs.webkit.org/show_bug.cgi?id=163374
1555         http://trac.webkit.org/changeset/207557
1556
1557 2016-10-19  Andy Estes  <aestes@apple.com>
1558
1559         Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type
1560         https://bugs.webkit.org/show_bug.cgi?id=163476
1561         <rdar://problem/26941395>
1562
1563         Reviewed by Andreas Kling.
1564
1565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1566         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Added.
1567         (TEST): Added an API test that passes a nil MIMEType to
1568         -[WKWebView loadData:MIMEType:characterEncodingName:baseURL:].
1569
1570 2016-10-19  Jer Noble  <jer.noble@apple.com>
1571
1572         Modify testrunner to mute audio during tests
1573         https://bugs.webkit.org/show_bug.cgi?id=162582
1574
1575         Reviewed by Alexey Proskuryakov.
1576
1577         * DumpRenderTree/mac/DumpRenderTree.mm:
1578         (createWebViewAndOffscreenWindow):
1579         * WebKitTestRunner/TestController.cpp:
1580         (WTR::TestController::resetStateToConsistentValues):
1581
1582 2016-10-19  Joseph Pecoraro  <pecoraro@apple.com>
1583
1584         check-webkit-style: fix false-positive warnings about using #pragma once header guard
1585         https://bugs.webkit.org/show_bug.cgi?id=163575
1586
1587         Reviewed by Brady Eidson.
1588
1589         There were some false positive warnings about header guards
1590         for ObjC headers that don't need guards. This changes the
1591         style checker to no longer warn if there is no #pragma once.
1592         It only warns if there are #ifndef that should be #pragma once.
1593
1594         * Scripts/webkitpy/style/checkers/cpp.py:
1595         (check_for_header_guard):
1596         Change when we output an error.
1597
1598         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1599         (CppStyleTest.test_build_header_guard):
1600         Update tests.
1601
1602 2016-10-19  Myles C. Maxfield  <mmaxfield@apple.com>
1603
1604         [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9
1605         https://bugs.webkit.org/show_bug.cgi?id=163374
1606
1607         Reviewed by Darin Adler.
1608
1609         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1610
1611 2016-10-18  Philippe Normand  <pnormand@igalia.com>
1612
1613         WebRTC: [GTK] Update jhbuild environment for OpenWebRTC
1614         https://bugs.webkit.org/show_bug.cgi?id=163330
1615
1616         Reviewed by Michael Catanzaro.
1617
1618         Bring back the openwebrtc JHBuild moduleset in the time being. It
1619         should be removed after the bump to GStreamer 1.10 is complete and
1620         the libnice patches have been upstreamed. The GStreamer git
1621         snapshots used in this patch are the ones configured in Ericsson's
1622         GStreamer Cerbero fork.
1623
1624         * gtk/openwebrtc.modules: Added.
1625         * gtk/patches/libnice-0001-TURN-allow-REALM-to-be-empty.patch: Added.
1626         * gtk/patches/libnice-0001-agent-Remove-unnecessary-NULL-check.patch: Added.
1627         * gtk/patches/libnice-0001-nicesrc-spin-the-agent-mainloop-in-a-separate-thread.patch: Added.
1628         * gtk/patches/libnice-0002-Do-not-update-a-remote-candidate-s-type.patch: Added.
1629         * gtk/patches/libnice-0002-TURN-handle-437-Allocation-Mismatch-responses.patch: Added.
1630         * gtk/patches/libnice-0003-Do-not-compare-scope-for-IPv6-address-when-scope-is-.patch: Added.
1631         * gtk/patches/libnice-0004-Removing-no-op-assignment.patch: Added.
1632
1633 2016-10-18  Sam Weinig  <sam@webkit.org>
1634
1635         Replace std::experimental::variant with WTF::Variant (or similar)
1636         https://bugs.webkit.org/show_bug.cgi?id=163626
1637
1638         Reviewed by Chris Dumez.
1639
1640         Rename std::experimental::variant, Variant. Move helpers get/holds_alternative/etc.
1641         into the WTF namespace.
1642
1643         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1644         (TestWebKitAPI::TEST):
1645
1646 2016-10-18  Simon Fraser  <simon.fraser@apple.com>
1647
1648         Add a MiniBrowser menu item to apply page scale in WK1 and WK2
1649         https://bugs.webkit.org/show_bug.cgi?id=163627
1650
1651         Reviewed by Dean Jackson.
1652
1653         Rename setScale: to setViewScale: and add setPageScale:, hooking it up for WK1 (via exisiting SPI)
1654         and WK2 (via new SPI).
1655
1656         * MiniBrowser/mac/BrowserWindowController.h:
1657         * MiniBrowser/mac/BrowserWindowController.m:
1658         (-[BrowserWindowController pageScaleForMenuItemTag:]):
1659         (-[BrowserWindowController setPageScale:]):
1660         (-[BrowserWindowController setViewScale:]):
1661         (-[BrowserWindowController setScale:]): Deleted.
1662         * MiniBrowser/mac/MainMenu.xib:
1663         * MiniBrowser/mac/WK1BrowserWindowController.m:
1664         (-[WK1BrowserWindowController setPageScale:]):
1665         (-[WK1BrowserWindowController setViewScale:]):
1666         (areEssentiallyEqual):
1667         (-[WK1BrowserWindowController validateMenuItem:]):
1668         (-[WK1BrowserWindowController setScale:]): Deleted.
1669         * MiniBrowser/mac/WK2BrowserWindowController.m:
1670         (-[WK2BrowserWindowController setPageScale:]):
1671         (-[WK2BrowserWindowController viewScaleForMenuItemTag:]):
1672         (-[WK2BrowserWindowController setViewScale:]):
1673         (areEssentiallyEqual):
1674         (-[WK2BrowserWindowController validateMenuItem:]):
1675         (viewScaleForMenuItemTag): Deleted.
1676         (-[WK2BrowserWindowController setScale:]): Deleted.
1677
1678 2016-10-18  Anders Carlsson  <andersca@apple.com>
1679
1680         Add an beforeunload alert to the WebKitLegacy MiniBrowser
1681         https://bugs.webkit.org/show_bug.cgi?id=163634
1682
1683         Reviewed by Sam Weinig.
1684
1685         * MiniBrowser/mac/WK1BrowserWindowController.m:
1686         (-[WK1BrowserWindowController webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]):
1687
1688 2016-10-18  Commit Queue  <commit-queue@webkit.org>
1689
1690         Unreviewed, rolling out r207443.
1691         https://bugs.webkit.org/show_bug.cgi?id=163616
1692
1693         "Caused 5% PLT regression" (Requested by krollin on #webkit).
1694
1695         Reverted changeset:
1696
1697         "Crash in ASCIICaseInsensitiveHash::hash() when a response has
1698         a null MIME type"
1699         https://bugs.webkit.org/show_bug.cgi?id=163476
1700         http://trac.webkit.org/changeset/207443
1701
1702 2016-10-18  Eric Carlson  <eric.carlson@apple.com>
1703
1704         [MediaStream] Resolve constraints and enumerate devices in the UI process
1705         https://bugs.webkit.org/show_bug.cgi?id=162147
1706         <rdar://problem/28803569>
1707
1708         Reviewed by Darin Adler.
1709
1710         * WebKitTestRunner/TestController.cpp:
1711         (WTR::TestController::resetPreferencesToConsistentValues): Enable mock capture devices.
1712         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update for API changes.
1713
1714 2016-10-17  Megan Gardner  <megan_gardner@apple.com>
1715
1716         Add test and infrastructure for link popover
1717         https://bugs.webkit.org/show_bug.cgi?id=163406
1718
1719         Reviewed by Simon Fraser.
1720
1721         Added functionality test for link popovers.
1722         Can query for what URL is loaded, and that the popover has appeared or has
1723         been dismissed.
1724         Added a link popover test.
1725
1726         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1727         (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
1728         (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
1729         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
1730         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1731         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1732         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1733         (WTR::UIScriptController::setDidShowForcePressPreviewCallback):
1734         (WTR::UIScriptController::didShowForcePressPreviewCallback):
1735         (WTR::UIScriptController::setDidDismissForcePressPreviewCallback):
1736         (WTR::UIScriptController::didDismissForcePressPreviewCallback):
1737         (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
1738         (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
1739         (WTR::UIScriptController::didEndFormControlInteractionCallback): Deleted.
1740         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
1741         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1742         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1743         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1744         (-[TestRunnerWKWebView dealloc]):
1745         (-[TestRunnerWKWebView didShowForcePressPreview]):
1746         (-[TestRunnerWKWebView didDismissForcePressPreview]):
1747         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1748         (WTR::UIScriptController::platformSetDidShowForcePressPreviewCallback):
1749         (WTR::UIScriptController::platformSetDidDismissForcePressPreviewCallback):
1750         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback): Deleted.
1751
1752 2016-10-17  Tim Horton  <timothy_horton@apple.com>
1753
1754         REGRESSION (r169805): WKWebView canGoBack returning YES when nothing is in the back-forward list after restoring session state
1755         https://bugs.webkit.org/show_bug.cgi?id=163573
1756         <rdar://problem/28744549>
1757
1758         Reviewed by Dan Bernstein.
1759
1760         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:
1761         (TEST):
1762         Add a test ensuring that canGoBack returns NO after restoring session state without navigating.
1763
1764 2016-10-17  Andy Estes  <aestes@apple.com>
1765
1766         Crash in ASCIICaseInsensitiveHash::hash() when a response has a null MIME type
1767         https://bugs.webkit.org/show_bug.cgi?id=163476
1768         <rdar://problem/26941395>
1769
1770         Reviewed by Tim Horton.
1771
1772         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1773         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadDataWithNilMIMEType.mm: Added.
1774         (TEST): Added an API test that passes a nil MIMEType to
1775         -[WKWebView loadData:MIMEType:characterEncodingName:baseURL:].
1776
1777 2016-10-17  Dean Jackson  <dino@apple.com>
1778
1779         Allow creation of ExtendedColors and make Color immutable
1780         https://bugs.webkit.org/show_bug.cgi?id=163557
1781         <rdar://problem/28805360>
1782
1783         Reviewed by Darin Adler and Dave Hyatt.
1784
1785         API tests for ExtendedColor.
1786
1787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1788         * TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp: Added.
1789         (TestWebKitAPI::TEST):
1790         (TestWebKitAPI::makeColor):
1791
1792 2016-10-17  JF Bastien  <jfbastien@apple.com>
1793
1794         WebAssembly JS API: implement basic stub
1795
1796         Implement the global WebAssembly JavaScript object, and its constructor +
1797         function properties as described in:
1798           https://github.com/WebAssembly/design/blob/master/JS.md
1799
1800         These don't do anything at the moment, the parent bug will take care of adding
1801         more functionality and associated tests.
1802
1803         WebAssembly JS API: implement basic stub
1804         https://bugs.webkit.org/show_bug.cgi?id=163404
1805
1806         Reviewed by Keith Miller.
1807
1808         * Scripts/run-jsc-stress-tests: use the new JSC option which exposes the WebAssembly object.
1809
1810 2016-10-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1811
1812         resolve-ChangeLogs: Specify --no-page to git diff
1813         https://bugs.webkit.org/show_bug.cgi?id=163441
1814
1815         Reviewed by Darin Adler.
1816
1817         resolve-ChangeLogs shows the result after resolving by invoking
1818         'git diff'. It runs a pager for every ChangeLog if it is under
1819         TTY.
1820
1821         * Scripts/resolve-ChangeLogs:
1822         (showStatus): Specify '--no-page' to git diff.
1823
1824 2016-10-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1825
1826         Move user agent quirks to cross-platform location
1827         https://bugs.webkit.org/show_bug.cgi?id=163508
1828
1829         Reviewed by Carlos Garcia Campos.
1830
1831         Move the test to a cross-platform location and improve it to better check the full list of
1832         sites we have defined quirks for.
1833
1834         * TestWebKitAPI/PlatformGTK.cmake:
1835         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp.
1836         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
1837         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
1838         (TestWebKitAPI::TEST):
1839
1840 2016-10-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1841
1842         [SOUP] Downloads should always sniff contents
1843         https://bugs.webkit.org/show_bug.cgi?id=163538
1844
1845         Reviewed by Michael Catanzaro.
1846
1847         Add a test case to check that the MIME type is correctly guessed for downloads.
1848
1849         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1850         (writeNextChunk):
1851         (serverCallback):
1852         (testDownloadMIMEType):
1853         (beforeAll):
1854         (writeNextChunkIdle): Deleted.
1855
1856 2016-10-16  Daniel Bates  <dabates@apple.com>
1857
1858         Fix Perl warning about masked variable following <http://trac.webkit.org/changeset/207382>
1859         (https://bugs.webkit.org/show_bug.cgi?id=163456)
1860
1861         * Scripts/prepare-ChangeLog:
1862         (actuallyGenerateFunctionLists):
1863
1864 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1865
1866         Unreviewed. Fix GTK+ unit test /webkit2/WebKitWebContext/languages after r206949.
1867
1868         After r206949 navigator.language returns en-US instead of en-us. Language tags in Accept-Language header are
1869         actually case-insensitive, so we should actually do case-insensitive comparisons, but we only have
1870         g_assert_cmpstr for tests.
1871
1872         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1873         (testWebContextLanguages):
1874
1875 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1876
1877         [GTK] WebKitWebPage URI not updated after URI is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame
1878         https://bugs.webkit.org/show_bug.cgi?id=163389
1879
1880         Reviewed by Michael Catanzaro.
1881
1882         Update /webkit2/WebKitWebPage/get-uri test to check that web view and page uri always match even when request is
1883         modified by WebKitWebPage::send-request signal.
1884
1885         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1886         (testWebPageURI):
1887
1888 2016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1889
1890         Document request not updated after willSendRequest is called for a redirect
1891         https://bugs.webkit.org/show_bug.cgi?id=163436
1892
1893         Reviewed by Michael Catanzaro.
1894
1895         Update /webkit2/WebKitWebView/active-uri test to check the active URI also when modified by
1896         WebKitPage::send-request signal in a web extension.
1897
1898         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1899         (testWebViewActiveURI):
1900         (serverCallback):
1901         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1902         (sendRequestCallback):
1903         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1904         (loadChangedCallback):
1905
1906 2016-10-15  Dan Bernstein  <mitz@apple.com>
1907
1908         REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
1909         https://bugs.webkit.org/show_bug.cgi?id=163492
1910         <rdar://problem/28654799>
1911
1912         Reviewed by Darin Adler.
1913
1914         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1915         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm: Added.
1916         (-[ContextMenuDefaultItemsHaveTagsDelegate webView:didFinishLoadForFrame:]):
1917         (TestWebKitAPI::TEST):
1918
1919 2016-10-15  Daniel Bates  <dabates@apple.com>
1920
1921         prepare-ChangeLog erroneously said that a python __init__ method was deleted
1922         https://bugs.webkit.org/show_bug.cgi?id=163456
1923
1924         Reviewed by Simon Fraser.
1925
1926         Fixes an issue where prepare-ChangeLog may list as deleted functions that are
1927         immediately above added code.
1928
1929         Currently prepare-ChangeLog makes use of the same overlap detection algorithm
1930         to compute the list of deleted functions as it does to compute added and modified
1931         functions. We consider a function deleted if its entire function body and signature
1932         are removed. It is sufficient to compare the list of functions before the patch
1933         is applied and the list of functions are the patch is applied to identify
1934         these functions.
1935
1936         * Scripts/prepare-ChangeLog: Fix some style nits, including using Camel Case for
1937         variable names.
1938         (actuallyGenerateFunctionLists): Modified to call computeModifiedFunctions(). Always
1939         compute the list of functions in the file after the patch regardless of whether the
1940         patch only contains deletions. We will compare this list against the list of functions
1941         before the patch was applied to determine the deleted functions.
1942         (computeModifiedFunctions): Renamed; formerly named generateFunctionListsByRanges.
1943         Removed out argument for the seen functions as we no longer make use of when computing
1944         the list of deleted functions.
1945         (diffCommand): Update comment.
1946         (generateFunctionListsByRanges): Deleted.
1947         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added more unit tests.
1948
1949 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
1950
1951         REGRESSION (r206973): Running "webkit-patch suggest-reviewers" throws an AttributeError: 'NoneType' object has no attribute 'full_name'
1952         https://bugs.webkit.org/show_bug.cgi?id=163478
1953
1954         Reviewed by Daniel Bates.
1955         
1956         Handle a None other in Contributor.__eq__.
1957
1958         * Scripts/webkitpy/common/config/committers.py:
1959         (Contributor.__eq__):
1960
1961 2016-10-14  JF Bastien  <jfbastien@apple.com>
1962
1963         Basic WebAssembly testing
1964
1965         Create a small DSL in JavaScript which can build WebAssembly binary modules based on the JSON description of the format as described in:
1966         https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md
1967
1968         This DSL can then be used to write small text description of valid and invalid WebAssembly binaries, making testing the JSC implementation much easier.
1969
1970         Details and example in README.md.
1971
1972         Basic WebAssembly testing
1973         https://bugs.webkit.org/show_bug.cgi?id=163267
1974
1975         Reviewed by Keith Miller.
1976
1977         * Scripts/run-javascriptcore-tests:
1978         (runJSCStressTests): run wasm.yaml tests
1979         * Scripts/run-jsc-stress-tests: add a WebAssembly-specific runner
1980
1981 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
1982
1983         Annotate bots in contributors.json and don't show them on webkit.org/team
1984         https://bugs.webkit.org/show_bug.cgi?id=163317
1985
1986         Reviewed by Daniel Bates.
1987         
1988         Add "class" : "bot" for non-humans in contributors.json and round-trip it.
1989
1990         * Scripts/webkitpy/common/config/committers.py:
1991         (Contributor.__init__):
1992         (Contributor.as_dict):
1993         (Bot):
1994         (Bot.__init__):
1995         (CommitterList.load_json):
1996         * Scripts/webkitpy/common/config/contributors.json:
1997
1998 2016-10-14  Simon Fraser  <simon.fraser@apple.com>
1999
2000         Fix printing in WK2 MiniBrowser
2001         https://bugs.webkit.org/show_bug.cgi?id=163455
2002
2003         Reviewed by Tim Horton.
2004         
2005         Call the basic -_printOperationWithPrintInfo: which doens't require a frame argument.
2006
2007         * MiniBrowser/mac/WK2BrowserWindowController.m:
2008         (-[WK2BrowserWindowController printWebView:]):
2009
2010 2016-10-14  Commit Queue  <commit-queue@webkit.org>
2011
2012         Unreviewed, rolling out r207335.
2013         https://bugs.webkit.org/show_bug.cgi?id=163445
2014
2015         WebKit2.ProvisionalURLAfterWillSendRequestCallback is timing
2016         out on Mac bots (Requested by youenn on #webkit).
2017
2018         Reverted changeset:
2019
2020         "Add ProvisionalURLAfterWillSendRequestCallback.cpp and
2021         ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac
2022         builds"
2023         https://bugs.webkit.org/show_bug.cgi?id=163440
2024         http://trac.webkit.org/changeset/207335
2025
2026 2016-10-14  Youenn Fablet  <youenn@apple.com>
2027
2028         Add ProvisionalURLAfterWillSendRequestCallback.cpp and ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac builds
2029         https://bugs.webkit.org/show_bug.cgi?id=163440
2030
2031         Unreviewed.
2032
2033         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Adding new test files introduced in
2034         https://bugs.webkit.org/show_bug.cgi?id=146306 patch.
2035
2036 2016-10-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2037
2038         Unreviewed. Removed myself from BindingsScripts watch list.
2039
2040         * Scripts/webkitpy/common/config/watchlist:
2041
2042 2016-10-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2043
2044         WebView and WebPage URLs not updated after URL is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame
2045         https://bugs.webkit.org/show_bug.cgi?id=146306
2046
2047         Reviewed by Darin Adler.
2048
2049         Add unit test to check that the committed URL is updated when changed in willSendRequest callback.
2050
2051         * TestWebKitAPI/CMakeLists.txt:
2052         * TestWebKitAPI/PlatformEfl.cmake:
2053         * TestWebKitAPI/PlatformGTK.cmake:
2054         * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback.cpp: Added.
2055         (TestWebKitAPI::didCommitLoadForFrame):
2056         (TestWebKitAPI::TEST):
2057         * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp: Added.
2058         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::ProvisionalURLAfterWillSendRequestCallbackTest):
2059         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::willSendRequestForFrame):
2060         (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::didCommitLoadForFrame):
2061
2062 2016-10-13  Alex Christensen  <achristensen@webkit.org>
2063
2064         Hosts of URLs with non-special schemes should be case-sensitive, and non-ASCII characters in such hosts should be punycode-encoded
2065         https://bugs.webkit.org/show_bug.cgi?id=163413
2066
2067         Reviewed by Tim Horton.
2068
2069         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2070         (TestWebKitAPI::TEST_F):
2071         Update parsing results.  There are now fewer differences between the new URLParser and the old URL::parse.
2072
2073 2016-10-13  Alex Christensen  <achristensen@webkit.org>
2074
2075         Rebase API tests after r207305.
2076
2077         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2078         Actually build Tests/mac/LoadInvalidURLRequest.mm so we are running the WebKit1.LoadInvalidURLRequest API test.
2079         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
2080         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2081         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
2082         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2083         Change results back to what they were before r207162, r207167, and r207184.
2084
2085 2016-10-13  Alex Christensen  <achristensen@webkit.org>
2086
2087         Disable URLParser for non-Safari iOS and Mac apps for now
2088         https://bugs.webkit.org/show_bug.cgi?id=163397
2089
2090         Reviewed by Tim Horton.
2091
2092         * DumpRenderTree/mac/DumpRenderTree.mm:
2093         (DumpRenderTreeMain):
2094         * WebKitTestRunner/TestController.cpp:
2095         Enable the URLParser for testing.
2096         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2097         Link with WebCoreTestSupport so we can find setURLParserEnabled.
2098
2099 2016-10-13  Ryan Haddad  <ryanhaddad@apple.com>
2100
2101         Unreviewed, rolling out r207297.
2102
2103         This change broke the iOS build.
2104
2105         Reverted changeset:
2106
2107         "Disable URLParser for non-Safari iOS and Mac apps for now"
2108         https://bugs.webkit.org/show_bug.cgi?id=163397
2109         http://trac.webkit.org/changeset/207297
2110
2111 2016-10-13  Alex Christensen  <achristensen@webkit.org>
2112
2113         Disable URLParser for non-Safari iOS and Mac apps for now
2114         https://bugs.webkit.org/show_bug.cgi?id=163397
2115
2116         Reviewed by Tim Horton.
2117
2118         * DumpRenderTree/mac/DumpRenderTree.mm:
2119         (DumpRenderTreeMain):
2120         * WebKitTestRunner/ios/mainIOS.mm:
2121         (main):
2122         * WebKitTestRunner/mac/main.mm:
2123         (main):
2124
2125 2016-10-12  Alex Christensen  <achristensen@webkit.org>
2126
2127         Fix out-of-bounds reading in URLParser when parsing improperly percent-encoded values
2128         https://bugs.webkit.org/show_bug.cgi?id=163376
2129
2130         Reviewed by Saam Barati.
2131
2132         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2133         (TestWebKitAPI::TEST_F):
2134
2135 2016-10-11  Dean Jackson  <dino@apple.com>
2136
2137         Add preliminary support for extended colors to WebCore::Color
2138         https://bugs.webkit.org/show_bug.cgi?id=162878
2139         <rdar://problem/28596413>
2140
2141         Reviewed by Darin Adler.
2142
2143         A new API test for Colors.
2144
2145         * TestWebKitAPI/Tests/WebCore/Color.cpp:
2146         (TestWebKitAPI::TEST):
2147
2148 2016-10-12  Ryan Haddad  <ryanhaddad@apple.com>
2149
2150         Unreviewed, rolling out r207225.
2151
2152         This change causes debug tests to exit early with crashes.
2153
2154         Reverted changeset:
2155
2156         "Optional's move-constructor and move-assignment operator
2157         don't disengage the value being moved from"
2158         https://bugs.webkit.org/show_bug.cgi?id=163309
2159         http://trac.webkit.org/changeset/207225
2160
2161 2016-10-12  Alex Christensen  <achristensen@webkit.org>
2162
2163         Fix assertion after switching to URLParser
2164         https://bugs.webkit.org/show_bug.cgi?id=163350
2165         rdar://problem/28739938
2166
2167         Reviewed by Brady Eidson.
2168
2169         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2170         (TEST):
2171
2172 2016-10-11  Sam Weinig  <sam@webkit.org>
2173
2174         Optional's move-constructor and move-assignment operator don't disengage the value being moved from
2175         https://bugs.webkit.org/show_bug.cgi?id=163309
2176
2177         Reviewed by Anders Carlsson.
2178
2179         * TestWebKitAPI/Tests/WTF/Optional.cpp:
2180         (TestWebKitAPI::TEST):
2181         Add tests for Optional's move-constructor and move-assignment operator.
2182
2183 2016-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2184
2185         Now playing media sessions are always cleared for the active foreground tab
2186         https://bugs.webkit.org/show_bug.cgi?id=163310
2187         <rdar://problem/28573301>
2188
2189         Reviewed by Jer Noble.
2190
2191         Tweaks existing unit tests to verify that media session info persists when backgrounding and foregrounding, but
2192         that media session info is correctly cleared out if the media session itself is no longer eligible for Now
2193         Playing (not accounting for foreground/active state). Previously, these tests were verifying that we would
2194         always clear out the information, but this is incorrect, and is the source of the problem.
2195
2196         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
2197         (-[NowPlayingTestWebView waitForNowPlayingInfoToChange]):
2198         (TestWebKitAPI::TEST):
2199
2200 2016-10-12  Per Arne Vollan  <pvollan@apple.com>
2201
2202         [Win] Parallel DRTs are sharing preferences and cache.
2203         https://bugs.webkit.org/show_bug.cgi?id=163013
2204
2205         Reviewed by Brent Fulgham.
2206
2207         Use separate cache and preferences for each DRT instance.
2208
2209         * DumpRenderTree/win/DumpRenderTree.cpp:
2210         (applicationId):
2211         (setApplicationId):
2212         (setCacheFolder):
2213         (setDefaultsToConsistentValuesForTesting):
2214         * Scripts/webkitpy/port/win.py:
2215         (WinPort.setup_test_run):
2216
2217 2016-10-11  Alex Christensen  <achristensen@webkit.org>
2218
2219         Update API test expectation after r207162.
2220        ​https://bugs.webkit.org/show_bug.cgi?id=162660
2221
2222         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
2223         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2224         Like r207167 but with a WebKit2 test.
2225         "https://www.example.com<>/" was an invalid URL with the old URL parser, is now valid with URLParser but not with NSURL's parser.
2226
2227 2016-10-11  Alex Christensen  <achristensen@webkit.org>
2228
2229         Update API test expectation after r207162.
2230         https://bugs.webkit.org/show_bug.cgi?id=162660
2231
2232         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
2233         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2234         "https://www.example.com<>/" was an invalid URL with the old URL parser.
2235         It is now a valid URL, but NSURL still considers it invalid.
2236         This will be looked into more with https://bugs.webkit.org/show_bug.cgi?id=163127
2237
2238 2016-10-11  Edward O'Connor  <eoconnor@apple.com>
2239
2240         Update my name in contributors.json
2241         https://bugs.webkit.org/show_bug.cgi?id=163251
2242
2243         Reviewed by Simon Fraser.
2244
2245         * Scripts/webkitpy/common/config/contributors.json:
2246
2247 2016-10-11  Said Abou-Hallawa  <sabouhallawa@apple.com>
2248
2249         Add SynchronizedFixedQueue class
2250         https://bugs.webkit.org/show_bug.cgi?id=162478
2251
2252         Reviewed by Geoffrey Garen.
2253
2254         Add a new test for SynchronizedFixedQueue. The test defines a new class
2255         called ToUpperConverter which converts strings from lower case to upper
2256         case. It creates two threads : (1) produce thread and (2) consume thread.
2257         Here is what each thread does:
2258
2259         1. Main threads: Enqueues lower case strings into m_lowerQueue.
2260         2. Produce thread: Dequeues lower case strings from m_lowerQueue and 
2261            enqueue their upper case strings in the m_upperQueue.
2262         3. Consume thread: Dequeues upper case strings from m_upperQueue.
2263
2264         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2265         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp: Added.
2266         (TestWebKitAPI::textItem): A helper function which returns a lower case string given an index.
2267         (TestWebKitAPI::toUpper): A helper function which Returns the upper case of a string.
2268         (TestWebKitAPI::ToUpperConverter::ToUpperConverter):
2269         (TestWebKitAPI::ToUpperConverter::produceQueue): Returns a workQueue for the produce thread.
2270         (TestWebKitAPI::ToUpperConverter::consumeQueue): Returns a workQueue for the consume thread.
2271         (TestWebKitAPI::ToUpperConverter::startProducing): Creates a thread for the producer.
2272         (TestWebKitAPI::ToUpperConverter::startConsuming): Creates a thread for the consumer.
2273         (TestWebKitAPI::ToUpperConverter::start): Starts both the producer and the consumer threads.
2274         (TestWebKitAPI::ToUpperConverter::stopProducing): Terminates the producer thread.
2275         (TestWebKitAPI::ToUpperConverter::stopConsuming): Terminates the consumer thread.
2276         (TestWebKitAPI::ToUpperConverter::stop): Terminates both the producer and the consumer threads.
2277         (TestWebKitAPI::ToUpperConverter::enqueueLower): Adds a lower case string to the m_lowerQueue on the main thread.
2278         (TestWebKitAPI::ToUpperConverter::isProducing): Returns whether the producing thread is active.
2279         (TestWebKitAPI::ToUpperConverter::isConsuming): Returns whether the consuming thread is active.
2280         (TestWebKitAPI::ToUpperConverter::produceCount): Returns the number of produced elements.
2281         (TestWebKitAPI::ToUpperConverter::consumeCount): Returns the number of consumed elements.
2282         (TestWebKitAPI::TEST):
2283
2284 2016-10-11  Megan Gardner  <megan_gardner@apple.com>
2285
2286         Extend event stream to include interpolated events and add a force press test that uses that interpolation
2287         https://bugs.webkit.org/show_bug.cgi?id=163161
2288
2289         Reviewed by Simon Fraser.
2290
2291         Added functionality to the event stream to allow for interpolated events.
2292         Can now do long press, as well as a better way to do drag and other time-based
2293         events that require a large stream of descrete HID events.
2294         Added a basic force touch test to demostrate this interpolation.
2295         Also updated the script to allow for iPhone 7 specific tests, as force touch
2296         needs to be on a device that had force touch.
2297
2298         * Scripts/webkitpy/port/ios.py:
2299         (IOSSimulatorPort):
2300         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2301         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2302         (linearInterpolation):
2303         (simpleCurveInterpolation):
2304         (calculateNextCurveLocation):
2305         (phaseFromString):
2306         (interpolationFromString):
2307         (-[HIDEventGenerator eventMaskFromEventInfo:]):
2308         (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
2309         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
2310         (-[HIDEventGenerator interpolatedEvents:]):
2311         (-[HIDEventGenerator processEventsArray:withStartTime:]):
2312         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2313         (simpleDragCurve): Deleted.
2314         (calculateNextLocation): Deleted.
2315
2316 2016-10-11  Alex Christensen  <achristensen@webkit.org>
2317
2318         URLParser should percent-encode non-ASCII and non-printable characters in fragment
2319         https://bugs.webkit.org/show_bug.cgi?id=163287
2320
2321         Reviewed by Brady Eidson.
2322
2323         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2324         (TestWebKitAPI::TEST_F):
2325
2326 2016-10-11  Alex Christensen  <achristensen@webkit.org>
2327
2328         Remove dead networking code
2329         https://bugs.webkit.org/show_bug.cgi?id=163263
2330
2331         Reviewed by Daniel Bates.
2332
2333         * DumpRenderTree/DumpRenderTree.h:
2334         * DumpRenderTree/config.h:
2335         * DumpRenderTree/win/DumpRenderTree.cpp:
2336         (main):
2337
2338 2016-10-11  John Wilander  <wilander@apple.com>
2339
2340         Modify check-webkit-style to prohibit sensitive phrases
2341         https://bugs.webkit.org/show_bug.cgi?id=163048
2342         <rdar://problem/28289755>
2343
2344         Terms considered or found to be too general to flag:
2345         ASSERT_WITH_SECURITY_IMPLICATION, bad cast, bug, bypass, crash,
2346         denial of service, dereference, disclosure, error, exploit,
2347         failure, heap, integer overflow, leak, null dereference,
2348         null pointer dereference, out of bounds, overflow,
2349         race condition, sensitive information, stack, type confusion.
2350
2351         Reviewed by Brent Fulgham.
2352
2353         * Scripts/webkitpy/style/checkers/changelog.py:
2354         (ChangeLogChecker.check_entry):
2355             Now calls ChangeLogChecker.check_for_unwanted_security_terms().
2356         (ChangeLogChecker):
2357         (ChangeLogChecker.check_for_unwanted_security_terms):
2358             New function to check for sensitive terms.
2359         (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm):
2360         (ChangeLogChecker.check_for_unwanted_security_terms.FoundUnwantedSecurityTerm.__init__):
2361             Convenience class.
2362         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2363         (ChangeLogCheckerTest.test_unwanted_security_terms):
2364
2365 2016-10-11  Ryan Haddad  <ryanhaddad@apple.com>
2366
2367         Unreviewed, rolling out r207067.
2368
2369         This change caused webkitpy test failures.
2370
2371         Reverted changeset:
2372
2373         "[Win] Parallel DRTs are sharing preferences and cache."
2374         https://bugs.webkit.org/show_bug.cgi?id=163013
2375         http://trac.webkit.org/changeset/207067
2376
2377 2016-10-11  Per Arne Vollan  <pvollan@apple.com>
2378
2379         [Win] Parallel DRTs are sharing preferences and cache.
2380         https://bugs.webkit.org/show_bug.cgi?id=163013
2381
2382         Reviewed by Brent Fulgham.
2383
2384         Use separate cache and preferences for each DRT instance.
2385
2386         * DumpRenderTree/win/DumpRenderTree.cpp:
2387         (applicationId):
2388         (setApplicationId):
2389         (setCacheFolder):
2390         (setDefaultsToConsistentValuesForTesting):
2391         * Scripts/webkitpy/port/win.py:
2392         (WinPort.setup_test_run):
2393
2394 2016-10-10  Zan Dobersek  <zdobersek@igalia.com>
2395
2396         Add ENABLE_ENCRYPTED_MEDIA configuration option
2397         https://bugs.webkit.org/show_bug.cgi?id=163219
2398
2399         Reviewed by Darin Adler.
2400
2401         * Scripts/webkitperl/FeatureList.pm:
2402         Make the ENABLE_ENCRYPTED_MEDIA option overridable via build-webkit.
2403         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2404         Add the ENABLE_ENCRYPTED_MEDIA configuration option. It will be used
2405         to enable or disable the new EME implementation at build-time.
2406
2407 2016-10-10  Commit Queue  <commit-queue@webkit.org>
2408
2409         Unreviewed, rolling out r206972.
2410         https://bugs.webkit.org/show_bug.cgi?id=163227
2411
2412         Making EWS flaky (Requested by bfulgham_ on #webkit).
2413
2414         Reverted changeset:
2415
2416         "[CMake] CMake does not support the dep files for implicit
2417         dependency"
2418         https://bugs.webkit.org/show_bug.cgi?id=161433
2419         http://trac.webkit.org/changeset/206972
2420
2421 2016-10-10  Youenn Fablet  <youenn@apple.com>
2422
2423         W3C test downloader should be able to import specific files/sub-directories in a skipped directory
2424         https://bugs.webkit.org/show_bug.cgi?id=161789
2425
2426         Reviewed by Ryosuke Niwa.
2427
2428         Removed tests_directory option and corresponding test.
2429         This option was allowing to import a sub-directory from a test repository.
2430         We can readd it if necessary.
2431
2432         Adding support for finer-grained import rules.
2433         Previously skipped directories were fully removed.
2434         Now, directories may be skipped but sub directories of them may be imported.
2435         This currently happens in web-platform-tests repo.
2436
2437         * Scripts/webkitpy/w3c/test_downloader.py:
2438         (TestDownloader._add_test_suite_paths): Removing tests_directory option.
2439         (TestDownloader.copy_tests): Refactoring file copy by generating the list of all directories for which direct files should be imported.
2440         (TestDownloader.copy_tests.should_copy_dir):
2441         (TestDownloader.copy_tests.should_copy_file):
2442         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2443         (TestImporterTest.test_tests_directory): Deleted.
2444         (TestImporterTest.test_skip_test_import): Added.
2445
2446 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
2447
2448         Make validate-committer-lists show inactive reviewers
2449         https://bugs.webkit.org/show_bug.cgi?id=163193
2450
2451         Reviewed by Sam Weinig.
2452         
2453         In preparation for updating contributors.json with the WebKit policy of retiring
2454         inactive reviewers, make validate-committer-lists show the list of reviewers who
2455         have not reviewed in the past year.
2456         
2457         This list is computed by grepping the output of 'git log --since=1.year" for
2458         the reviewer line, and looking up reviewers via Contributor.mentioned_in_text(),
2459         which looks for full names, aliases, irc nicks and email addresses.
2460         
2461         Support for aliases is added to Contributor. Aliases are alternates
2462         or misspellings of the reviewer's name. Some common aliases were added to
2463         contributors.json by manual examination of "Reviewed by" lines.
2464
2465         * Scripts/validate-committer-lists:
2466         (CommitterListFromGit.possibly_expired_committers):
2467         (CommitterListFromGit):
2468         (CommitterListFromGit.possibly_inactive_reviewers):
2469         (CommitterListFromGit.print_possibly_expired_committers):
2470         (CommitterListFromGit.print_possibly_inactive_reviewers):
2471         * Scripts/webkitpy/common/config/committers.py:
2472         (Contributor.__init__):
2473         (Contributor.contains_string):
2474         (Contributor.mentioned_in_text):
2475         (Contributor.as_dict):
2476         (Committer.__init__):
2477         (Reviewer.__init__):
2478         (CommitterList.load_json):
2479         * Scripts/webkitpy/common/config/contributors.json:
2480
2481 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
2482
2483         Convert contributors.json to a flat list
2484         https://bugs.webkit.org/show_bug.cgi?id=163183
2485
2486         Reviewed by Darin Adler.
2487         
2488         Make contributors.json easier to maintain by eliminating the big groupings ("Committers", "Reviewers" etc)
2489         and moving that data to a "status" property on each contributor.
2490
2491         * Scripts/webkitpy/common/config/committers.py:
2492         (Contributor.__eq__): Implement this to fix unit tests, now that load_json() is not @memoized.
2493         (Contributor.as_dict): Include status in the dict.
2494         (CommitterList.__init__): Clean up to make the testing code path more explicit.
2495         (CommitterList.load_json):
2496         (CommitterList.load_test_data):
2497         (CommitterList.as_json):
2498         (Contributor.__unicode__): Deleted.
2499         * Scripts/webkitpy/common/config/contributors.json:
2500         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2501         (IRCCommandTest.test_whois): The ordering here is now alphabetical.
2502
2503 2016-10-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2504
2505         [CMake] CMake does not support the dep files for implicit dependency
2506         https://bugs.webkit.org/show_bug.cgi?id=161433
2507
2508         Reviewed by Brent Fulgham.
2509
2510         Created a Perl script to generate all IDL bindings for CMake.
2511         This script can regenerate outdated bindings by based on the
2512         supplemental dependency and dep files created by
2513         '--write-dependencies' switch of generate-bindings.pl.
2514
2515         add_custom_target is used to invoke the script instead of
2516         add_custom_command because Ninja deletes all output files before
2517         executing the command in case of add_custom_command.
2518
2519         USES_TERMINAL option of add_custom_target has two effects:
2520         1) Not buffering output of the command
2521         2) Invoking the command in the special Ninja pool which inhibits parallel build
2522         One needs to use CMake 3.2 or later to enable this feature.
2523
2524         * DumpRenderTree/CMakeLists.txt: Specified a target name for
2525         GENERATE_BINDINGS. Added dependency for the target.
2526         * WebKitTestRunner/CMakeLists.txt: Ditto.
2527
2528 2016-10-09  Simon Fraser  <simon.fraser@apple.com>
2529
2530         Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
2531         https://bugs.webkit.org/show_bug.cgi?id=163177
2532
2533         Follow-up fix.
2534         
2535         For unknown reasons, overriding Commiter.__dict__() caused mysterious test failures.
2536         Rename it to as_dict().
2537
2538         * Scripts/webkitpy/common/config/committers.py:
2539         (Contributor.as_dict):
2540         (CommitterList._contributor_list_to_dict):
2541         (Contributor.__dict__): Deleted.
2542
2543 2016-10-08  Simon Fraser  <simon.fraser@apple.com>
2544
2545         Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
2546         https://bugs.webkit.org/show_bug.cgi?id=163177
2547
2548         Reviewed by Ryosuke Niwa.
2549         
2550         Make it possible to round-trip contributors.json through CommitterList, so we can
2551         support writing out contributors.json in canonical format. This requires saving
2552         the case-preserved email and expertise in Contributor. CommitterList also needs
2553         to be able to generate the "exclusive" lists, since it currently uses lists
2554         that are the union of, say, committers and reviewers.
2555         
2556         If contributors.json is malformed (invalid JSON), catch the Exception, report it
2557         and exit rather than allowing the exception to propagate. With an invalid file,
2558         an exception would be thrown before the JSON style checker reached this file, so
2559         the error was not correctly reported.
2560         
2561         Add style/checker/committer.py for checking that committers.json has the canonical format.
2562         
2563         Add support to validate-committer-lists to dump out the canonical json (-d) or update
2564         the file in-place (-c).
2565
2566         * Scripts/validate-committer-lists:
2567         (CommitterListFromGit._print_three_column_row):
2568         (CommitterListFromGit.possibly_expired_committers):
2569         (CommitterListFromGit):
2570         (CommitterListFromGit.print_possibly_expired_committers):
2571         (main):
2572         * Scripts/webkitpy/common/config/committers.py:
2573         (Contributor.__init__):
2574         (Contributor.__dict__):
2575         (Committer.__init__):
2576         (Reviewer.__init__):
2577         (CommitterList.load_json):
2578         (CommitterList):
2579         (CommitterList._contributor_list_to_dict):
2580         (CommitterList.as_json):
2581         (CommitterList.reformat_in_place):
2582         (CommitterList._exclusive_contributors):
2583         (CommitterList._exclusive_committers):
2584         (Contributor.matches_glob): Deleted.
2585         (CommitterList.contributors): Deleted.
2586         * Scripts/webkitpy/common/config/contributors.json:
2587         * Scripts/webkitpy/style/checker.py:
2588         (CheckerDispatcher._create_checker):
2589         * Scripts/webkitpy/style/checkers/contributors.py: Added.
2590         (ContributorsChecker):
2591         (ContributorsChecker.__init__):
2592         (ContributorsChecker.check):
2593         (ContributorsChecker._unidiff_output):
2594
2595 2016-10-06  Darin Adler  <darin@apple.com>
2596
2597         Next step on moving to modern way to return DOM exceptions
2598         https://bugs.webkit.org/show_bug.cgi?id=163016
2599
2600         Reviewed by Ryosuke Niwa.
2601
2602         * Scripts/do-webcore-rename: Add proposed name change of setDOMException
2603         to propagateException, since this function is primarily used to take an
2604         exception already effectively "thrown" by setting an ExceptionCode out
2605         argument and propagate it into the JavaScript engine's exception machinery.
2606
2607 2016-10-07  Alex Christensen  <achristensen@webkit.org>
2608
2609         Non-special URL fragments should percent-encode non-ASCII characters
2610         https://bugs.webkit.org/show_bug.cgi?id=163153
2611
2612         Reviewed by Tim Horton.
2613
2614         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2615         (TestWebKitAPI::TEST_F):
2616
2617 2016-10-07  Jonathan Bedard  <jbedard@apple.com>
2618
2619         Build fix for “Move functionality common to Darwin ports into a base class”
2620         https://bugs.webkit.org/show_bug.cgi?id=160709
2621
2622         Unreviewed build fix.
2623
2624         * Scripts/webkitpy/port/ios.py:
2625         (IOSSimulatorPort._get_crash_log): Added iOS implementation.
2626         * Scripts/webkitpy/port/mac.py:
2627         (MacPort._get_crash_log): Added Mac implementation.
2628
2629 2016-10-07  Chelsea Pugh  <cpugh@apple.com>
2630
2631         Unreviewed. Added myself to the list of committers.
2632
2633         * Scripts/webkitpy/common/config/contributors.json:
2634
2635 2016-10-07  Jonathan Bedard  <jbedard@apple.com>
2636
2637         Move functionality common to Darwin ports into a base class
2638         https://bugs.webkit.org/show_bug.cgi?id=160709
2639
2640         Reviewed by Darin Adler.
2641
2642         * Scripts/webkitpy/port/apple.py:
2643         (ApplePort.determine_full_port_name): Specific iOS port check.
2644         (ApplePort.__init__): Move leak detector to DarwinPort.
2645         (ApplePort._make_leak_detector): Moved to DarwinPort.
2646         (ApplePort.supports_per_test_timeout): Moved to Port.
2647         (ApplePort.check_for_leaks): Moved to DarwinPort.
2648         (ApplePort.print_leaks_summary): Moved to DarwinPort.
2649         (ApplePort._path_to_webcore_library): Moved to DarwinPort.
2650         (ApplePort.show_results_html_file): Moved to DarwinPort.
2651         (ApplePort._merge_crash_logs): Moved to DarwinPort.
2652         (ApplePort._look_for_all_crash_logs_in_log_dir): Moved to DarwinPort.
2653         (ApplePort._get_crash_log): Moved to DarwinPort.
2654         (ApplePort.look_for_new_crash_logs): Moved to DarwinPort.
2655         (ApplePort.sample_process): Moved to DarwinPort.
2656         (ApplePort.sample_file_path): Moved to DarwinPort.
2657         (ApplePort.look_for_new_samples): Moved to DarwinPort.
2658         * Scripts/webkitpy/port/base.py:
2659         (Port.supports_per_test_timeout): Return true for all ports.
2660         * Scripts/webkitpy/port/darwin.py: Added.
2661         (DarwinPort): Shared iOS and Mac functions.
2662         * Scripts/webkitpy/port/darwin_testcase.py: Added.
2663         (DarwinTest): Shared iOS and Mac testing.
2664         * Scripts/webkitpy/port/efl.py:
2665         (EflPort):
2666         (EflPort.supports_per_test_timeout): Moved to Port.
2667         * Scripts/webkitpy/port/gtk.py:
2668         (GtkPort._driver_class):
2669         (GtkPort):
2670         (GtkPort.supports_per_test_timeout): Moved to Port.
2671         * Scripts/webkitpy/port/ios.py:
2672         (IOSPort):
2673         (IOSPort.operating_system):
2674         (IOSSimulatorPort):
2675         (IOSSimulatorPort.__init__): Inherits from DarwinPort.
2676         (IOSSimulatorPort._port_specific_expectations_files): Moved to DarwinPort.
2677         (IOSSimulatorPort._get_crash_log): Deleted.
2678         (IOSSimulatorPort.xcrun_find): Deleted.
2679         * Scripts/webkitpy/port/ios_unittest.py: Added.
2680         (iosTest): Unit tests for the iOS port.
2681         * Scripts/webkitpy/port/mac.py:
2682         (MacPort):
2683         (MacPort.__init__): Inherits from DarwinPort.
2684         (MacPort._port_specific_expectations_files): Moved to DarwinPort.
2685         (MacPort.make_command): Moved to DarwinPort.
2686         (MacPort._get_crash_log): Moved to DarwinPort.
2687         (MacPort.nm_command): Moved to DarwinPort.
2688         * Scripts/webkitpy/port/mac_unittest.py:
2689         (MacTest):
2690         (MacTest.test_sdk_name): Added test.
2691         (MacTest.test_xcrun): Added test.
2692         (MacTest.assert_skipped_file_search_paths): Moved to DarwinTest.
2693         (MacTest.test_default_timeout_ms): Moved to DarwinTest.
2694         (MacTest.assert_name): Moved to DarwinTest.
2695         (MacTest.test_helper_starts): Moved to DarwinTest.
2696         (MacTest.test_helper_fails_to_start): Moved to DarwinTest.
2697         (MacTest.test_helper_fails_to_stop): Moved to DarwinTest.
2698         (MacTest.test_spindump): Moved to DarwinTest.
2699         (MacTest.test_sample_process): Moved to DarwinTest.
2700         (MacTest.test_sample_process_exception): Moved to DarwinTest.
2701         * Scripts/webkitpy/port/port_testcase.py:
2702         (PortTestCase):
2703         (PortTestCase.test_diff_image): Added is_simulator flag.
2704         (PortTestCase.test_diff_image): Skip test if on a simulator.
2705         (PortTestCase.test_diff_image_crashed): Skip test if on a simulator.
2706         * Scripts/webkitpy/port/win.py:
2707         (WinPort):
2708         (WinPort.look_for_new_samples): Used default, ApplePort no longer implements.
2709         (WinPort.sample_process): Ditto.
2710         (WinPort._make_leak_detector): Ditto.
2711         (WinPort.check_for_leaks): Ditto.
2712         (WinPort.print_leaks_summary): Ditto.
2713         (WinPort._path_to_webcore_library): Ditto.
2714
2715 2016-10-07  Anders Carlsson  <andersca@apple.com>
2716
2717         Get rid of WKPageSetSession
2718         https://bugs.webkit.org/show_bug.cgi?id=163129
2719
2720         Reviewed by Tim Horton.
2721
2722         Rewrite this test to use WKPageConfigurationRef and WKWebsiteDataStoreRef.
2723
2724         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2725         (TestWebKitAPI::TEST):
2726
2727 2016-10-07  Andreas Kling  <akling@apple.com>
2728
2729         [WK2] didRemoveFrameFromHierarchy callback doesn't fire for subframes when evicting from PageCache.
2730         <https://webkit.org/b/163098>
2731         <rdar://problem/28663488>
2732
2733         Reviewed by Antti Koivisto.
2734
2735         Add an API test that puts a 10-subframe page into the page cache, then loads other pages
2736         until the first page gets kicked out. The test succeeds if we receive didRemoveFrameFromHierarchy
2737         callbacks for all the subframes.
2738
2739         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2740         * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache.cpp: Added.
2741         (TestWebKitAPI::didFinishLoadForFrame):
2742         (TestWebKitAPI::setPageLoaderClient):
2743         (TestWebKitAPI::didReceivePageMessageFromInjectedBundle):
2744         (TestWebKitAPI::setInjectedBundleClient):
2745         (TestWebKitAPI::TEST):
2746         * TestWebKitAPI/Tests/WebKit2/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp: Added.
2747         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2748         (TestWebKitAPI::DidRemoveFrameFromHiearchyInPageCacheTest::DidRemoveFrameFromHiearchyInPageCacheTest):
2749         (TestWebKitAPI::DidRemoveFrameFromHiearchyInPageCacheTest::didCreatePage):
2750         * TestWebKitAPI/Tests/WebKit2/many-iframes.html: Added.
2751
2752 2016-10-07  Emanuele Aina  <emanuele.aina@collabora.com>
2753
2754         Replace bug URL placeholders independently of the short desc one
2755         https://bugs.webkit.org/show_bug.cgi?id=161684
2756
2757         Reviewed by Darin Adler.
2758
2759         Instead of adding the bug URL when replacing the short description
2760         placeholder and then ignoring the bug URL placeholder, use the former
2761         to set the short description and the latter for the bug URL.
2762         This means that developers can fully prepare the changelog with short
2763         and long description before submission leaving the bug placeholder in
2764         place, and the changelog machinery will make sure to replace the
2765         latter with the URL of the newly created bug while submitting.
2766
2767         Note that this also means that the short description placeholder alone
2768         no longer causes the bug URL to be added.
2769
2770         * Scripts/webkitpy/common/checkout/changelog.py:
2771         (ChangeLog.set_short_description_and_bug_url):
2772         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2773         (test_set_short_description_and_bug_url):
2774
2775 2016-10-07  Jonathan Bedard  <jbedard@apple.com>
2776
2777         Style Checking Error when Objective C Blocks passed as Argument
2778         https://bugs.webkit.org/show_bug.cgi?id=162463
2779
2780         Reviewed by Darin Adler.
2781
2782         * Scripts/webkitpy/style/checkers/cpp.py:
2783         (regex_for_lambdas_and_blocks): Consider case where block is passed as a function argument.
2784         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2785         (CppStyleTest.test_objective_c_block_as_argument): Test case where block is passed as a function argument. 
2786
2787 2016-10-07  Philippe Normand  <pnormand@igalia.com>
2788
2789         [GTK] Docs build failure
2790         https://bugs.webkit.org/show_bug.cgi?id=163102
2791
2792         Reviewed by Carlos Garcia Campos.
2793
2794         * gtk/jhbuild.modules: Bump to gtk-doc 1.25 to fix build errors on Debian Testing.
2795
2796 2016-10-06  Joseph Pecoraro  <pecoraro@apple.com>
2797
2798         check-webkit-style: Enable the legal/copyright rule for cpp/h files
2799         https://bugs.webkit.org/show_bug.cgi?id=162707
2800
2801         Reviewed by Darin Adler.
2802
2803         * Scripts/webkitpy/style/checker.py:
2804         Enable this rule by default.
2805
2806 2016-10-06  Joseph Pecoraro  <pecoraro@apple.com>
2807
2808         Header guard style should be updated to be "#pragma once"
2809         https://bugs.webkit.org/show_bug.cgi?id=159785
2810
2811         Reviewed by Darin Adler.
2812
2813         * Scripts/webkitpy/style/checkers/cpp.py:
2814         (check_for_header_guard):
2815         (_process_lines):
2816         Simplify header_guard check to warn for a missing #pragma once
2817         in header files. For legacy files that contain an #ifndef only
2818         warn if the #ifndef line itself is changing.
2819
2820         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2821         (CppStyleTestBase.perform_header_guard_check):
2822         (CppStyleTestBase.assert_header_guard):
2823         Helpers for enabling just this warning.
2824
2825         (CppStyleTest.test_build_header_guard):
2826         Test different header guard cases.
2827
2828         * Scripts/webkitpy/style/error_handlers.py:
2829         (DefaultStyleErrorHandler.should_line_be_checked):
2830         Always allow warnings that output for "line 0" which won't be in
2831         the list of modified lines that are 1-based.
2832
2833 2016-10-06  Commit Queue  <commit-queue@webkit.org>
2834
2835         Unreviewed, rolling out r206713.
2836         https://bugs.webkit.org/show_bug.cgi?id=163097
2837
2838         triggers apparent codegen bug on ARM 32-bit (Requested by smfr
2839         on #webkit).
2840
2841         Reverted changeset:
2842
2843         "Support transitions/animations of background-position with
2844         right/bottom-relative values"
2845         https://bugs.webkit.org/show_bug.cgi?id=162048
2846         http://trac.webkit.org/changeset/206713
2847
2848 2016-10-06  Alex Christensen  <achristensen@webkit.org>
2849
2850         URLParser: Non-ASCII characters in Non-UTF-8 encoded queries of relative URLs with ws, wss, or nonspecial schemes should be UTF-8 encoded
2851         https://bugs.webkit.org/show_bug.cgi?id=163089
2852
2853         Reviewed by Tim Horton.
2854
2855         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2856         (TestWebKitAPI::checkURL):
2857         (TestWebKitAPI::TEST_F):
2858
2859 2016-10-06  Alex Christensen  <achristensen@webkit.org>
2860
2861         Skip tabs and newlines between end of query and beginning of fragment in non-UTF-8-encoded URLs
2862         https://bugs.webkit.org/show_bug.cgi?id=163071
2863
2864         Reviewed by Tim Horton.
2865
2866         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2867         (TestWebKitAPI::TEST_F):
2868
2869 2016-10-06  Alex Christensen  <achristensen@webkit.org>
2870
2871         URLParser should parse file URLs with ports consistently
2872         https://bugs.webkit.org/show_bug.cgi?id=163075
2873
2874         Reviewed by Brady Eidson.
2875
2876         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2877         (TestWebKitAPI::TEST_F):
2878
2879 2016-10-06  John Wilander  <wilander@apple.com>
2880
2881         Update Resource Load Statistics
2882         https://bugs.webkit.org/show_bug.cgi?id=162811
2883
2884         Reviewed by Alex Christensen.
2885
2886         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
2887             Change from USE(PUBLIC_SUFFIX_LIST) to ENABLE(PUBLIC_SUFFIX_LIST)
2888
2889 2016-10-05  Philippe Normand  <pnormand@igalia.com>
2890
2891         [GStreamer][OWR] GL rendering support
2892         https://bugs.webkit.org/show_bug.cgi?id=162972
2893
2894         Reviewed by Žan Doberšek.
2895
2896         When GStreamer-GL is enabled the GL context needs to be properly passed
2897         to the GStreamer pipeline running within the OpenWebRTC video renderer.
2898         This is now supported using a new OpenWebRTC API that allows the
2899         renderer to request the context from the application using a callback
2900         registered within the renderer.
2901
2902         * gtk/jhbuild.modules: Bump to latest OpenWebRTC for the new
2903         owr_video_renderer_set_request_context_callback API added
2904         recently.
2905
2906 2016-10-05  Youenn Fablet  <youenn@apple.com>
2907
2908         Reuse CodeGenerator::UpdateFile in Tools CodeGenerator
2909         https://bugs.webkit.org/show_bug.cgi?id=162960
2910
2911         Reviewed by Alex Christensen.
2912
2913         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
2914         (WriteData): Using CodeGenerator::UpdateFile to do lazy generated file update when it is made feasible.
2915         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2916         (WriteData): Ditto.
2917
2918 2016-10-05  Alex Christensen  <achristensen@webkit.org>
2919
2920         URLParser should parse IPv4 addresses as the last two pieces of an IPv6 address
2921         https://bugs.webkit.org/show_bug.cgi?id=162991
2922
2923         Reviewed by Saam Barati.
2924
2925         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2926         (TestWebKitAPI::TEST_F):
2927
2928 2016-10-05  Tim Horton  <timothy_horton@apple.com>
2929
2930         Avoid automatically re-taking snapshots for back-forward items that were never loaded into the view
2931         https://bugs.webkit.org/show_bug.cgi?id=162955
2932         <rdar://problem/27659173>
2933
2934         Reviewed by Simon Fraser.
2935
2936         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
2937         (-[SnapshotTestWKWebView init]):
2938         (forceRepaintCallback):
2939         (-[SnapshotTestWKWebView synchronouslyForceRepaint]):
2940         (-[SnapshotTestWKWebView synchronouslyLoadTestPageAndForceRepaint:]):
2941         (TEST):
2942         (makeRedSquareView):
2943         Add a test that restoring session state into a web view without navigating,
2944         then explicitly snapshotting and navigating away, leaves the original snapshot alone.
2945
2946         Adjust the existing test, as well, to ensure that it will reliably fail
2947         if the feature is broken. Use an explicitly added and removed red square
2948         instead of scrolling, because we can't scroll in the restore-without-navigating case.
2949
2950         Stop trying to override the window scale, because it's not working (we're getting partial snapshots)
2951         and isn't necessary; instead just multiply the expected value by the page scale.
2952
2953         (-[SnapshotTestWKWebView loadPageNamed:]): Deleted.
2954         * TestWebKitAPI/mac/TestWKWebViewMac.h:
2955         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
2956         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
2957         Reorganize to reduce duplication.
2958
2959 2016-10-05  Tim Horton  <timothy_horton@apple.com>
2960
2961         Make it possible to test ViewSnapshotStore behaviors
2962         https://bugs.webkit.org/show_bug.cgi?id=162983
2963
2964         Reviewed by Simon Fraser.
2965
2966         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2967         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm: Added.
2968         (-[SnapshotTestWKWebView init]):
2969         (-[SnapshotTestWKWebView loadPageNamed:]):
2970         (imagesAreEqual):
2971         Add tests for existing basic snapshotting behavior:
2972
2973         - a back-forward item shouldn't have a snapshot
2974           until it is navigated away from
2975
2976         - causing a back-forward item to fall out of the
2977           back-forward list should remove the snapshot
2978
2979         - calling the explicit snapshotting SPI, then navigating away from the page,
2980           should result in the snapshot being retaken
2981
2982 2016-10-05  Chris Dumez  <cdumez@apple.com>
2983
2984         KeyboardEvent.getModifierState() should support "CapsLock" modifier
2985         https://bugs.webkit.org/show_bug.cgi?id=162861
2986
2987         Reviewed by Darin Adler.
2988
2989         Add support for 'capsLockKey' modifier for EventSender.keyDown() so
2990         that we can test this new modifier support for layout tests.
2991
2992         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2993         (TestWebKitAPI::modifierFlagsForWKModifiers):
2994         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2995         (WTR::parseModifier):
2996         * WebKitTestRunner/mac/EventSenderProxy.mm:
2997         (WTR::buildModifierFlags):
2998
2999 2016-10-05  Jeremy Jones  <jeremyj@apple.com>
3000
3001         Add MobileMiniBrowser tests for control center and looping fullscreen.
3002         https://bugs.webkit.org/show_bug.cgi?id=162748
3003
3004         Reviewed by Jer Noble.
3005
3006         Refactor existing MobileMiniBrowserTests and add new tests for 
3007         - fullscreen rotation
3008         - fullscreen looping (failing)
3009         - control center interruption (failing)
3010
3011         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3012         * MobileMiniBrowser/MobileMiniBrowserFramework/Resources/looping2s.html: Added.
3013         * MobileMiniBrowser/MobileMiniBrowserFramework/test2s.mp4: Added.
3014         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
3015         (-[MobileMiniBrowserUITests setUp]):
3016         (-[MobileMiniBrowserUITests waitToTapButtonNamed:forApp:]):
3017         (-[MobileMiniBrowserUITests loadURL:]):
3018         (-[MobileMiniBrowserUITests requireMinFPS:sampleDurationSeconds:message:]):
3019         (-[MobileMiniBrowserUITests ensureFullscreenControls]):
3020         (-[MobileMiniBrowserUITests timeForTimeString:]):
3021         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
3022         (-[MobileMiniBrowserUITests testBasicVideoFullscreen]):
3023         (-[MobileMiniBrowserUITests testVideoFullscreenAndRotationAnimation]):
3024         (-[MobileMiniBrowserUITests testVideoFullscreenControlCenter]):
3025         (-[MobileMiniBrowserUITests testLoopingFullscreenLockup]):
3026
3027 2016-10-05  Alex Christensen  <achristensen@webkit.org>
3028
3029         URLParser should correctly strip unnecessary 0's in IPv6 addresses
3030         https://bugs.webkit.org/show_bug.cgi?id=162979
3031
3032         Reviewed by Brady Eidson.
3033
3034         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3035         (TestWebKitAPI::TEST_F):
3036
3037 2016-10-05  Alex Christensen  <achristensen@webkit.org>
3038
3039         UTF-8 encode queries of nonspecial and websocket schemes
3040         https://bugs.webkit.org/show_bug.cgi?id=162956
3041
3042         Reviewed by Geoffrey Garen and Brady Eidson.
3043
3044         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3045         (TestWebKitAPI::TEST_F):
3046
3047 2016-10-05  Alex Christensen  <achristensen@webkit.org>
3048
3049         Prepare to enable URLParser
3050         https://bugs.webkit.org/show_bug.cgi?id=162974
3051
3052         Reviewed by Brady Eidson.
3053
3054         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3055         (TestWebKitAPI::TEST_F):
3056         Added some tests that are unrelated to the code change, but these are
3057         reflected in changed LayoutTest results when enabling the URLParser,
3058         and they weren't in the URLParser tests yet.  They should be.
3059
3060 2016-10-05  Zan Dobersek  <zdobersek@igalia.com>
3061
3062         Rename ENABLE_ENCRYPTED_MEDIA_V2 to ENABLE_LEGACY_ENCRYPTED_MEDIA
3063         https://bugs.webkit.org/show_bug.cgi?id=162903
3064
3065         Reviewed by Alex Christensen.
3066
3067         Rename build guards for the remaining implementation of the legacy EME API
3068         to ENABLE_LEGACY_ENCRYPTED_MEDIA. This will allow for the future implementation
3069         of the near-finished API to be guarded with the simple ENABLE_ENCRYPTED_MEDIA guards.
3070
3071         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Also remove the
3072         ENABLE_IOS_TEXT_AUTOSIZING feature define that was renamed in r206395 and was
3073         throwing up style checker errors.
3074
3075 2016-10-04  Andy Estes  <aestes@apple.com>
3076
3077         [iOS] Crash in WebResourceLoaderQuickLookDelegate when the client cancels the navigation to a QuickLook resource
3078         https://bugs.webkit.org/show_bug.cgi?id=162950
3079         <rdar://problem/23759114>
3080
3081         Reviewed by Brady Eidson.
3082
3083         Added a new API test.
3084
3085         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Sorted imports and removed redundant
3086         initialization of static bools.
3087         (runTest): Factored out the common test logic between QuickLook.NavigationDelegate and
3088         QuickLook.CancelNavigationAfterResponse.
3089         (TEST): Added QuickLook.CancelNavigationAfterResponse.
3090         (-[QuickLookDecidePolicyDelegate
3091         webView:decidePolicyForNavigationResponse:decisionHandler:]): Canceled the navigation.
3092         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Set
3093         isDone to true.
3094
3095 2016-10-04  Ryosuke Niwa  <rniwa@webkit.org>
3096
3097         Add the support for running ES6SampleBench to run-benchmark
3098         https://bugs.webkit.org/show_bug.cgi?id=162890
3099
3100         Reviewed by Saam Barati.
3101
3102         Added the support for running ES6SampleBench as "es6bench".
3103         e.g. ./Tools/Scripts/run-benchmark --platform osx --plan es6bench --browser safari
3104
3105         Instead of the default 10 iterations, run the test 4 iterations using 5 instances of browser
3106         for the total of 20 iterations.
3107
3108         * Scripts/webkitpy/benchmark_runner/data/patches/ES6SampleBench.patch: Added.
3109         * Scripts/webkitpy/benchmark_runner/data/plans/es6bench.plan: Added.
3110         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3111         (start): Fixed the bug that the linter will complain about the presence of "debugOutput" by
3112         removing it if it's present.
3113
3114 2016-10-04  Simon Fraser  <simon.fraser@apple.com>
3115
3116         [iOS WK2] Make it possible for a test to describe a user gesture as a stream of events in JSON format
3117         https://bugs.webkit.org/show_bug.cgi?id=162934
3118
3119         Reviewed by Dean Jackson.
3120
3121         With this change, a test can describe a user gesture in an "event stream", which is
3122         some JSON describing an array of events with their underlying touches. The added
3123         test describes a single tap.
3124         
3125         The implementation fires up an NSThread, and sleeps the thread between events to dispatch
3126         them at close to real time.
3127         
3128         In future, HIDEventGenerator could use this internally for all of the "compound" interactions.
3129
3130         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3131         (WTR::UIScriptController::sendEventStream):
3132         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3133         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3134         (WTR::UIScriptController::sendEventStream):
3135         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3136         * WebKitTestRunner/ios/HIDEventGenerator.h:
3137         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3138         (transducerTypeFromString):
3139         (phaseFromString):
3140         (-[HIDEventGenerator eventMaskFromEventInfo:]):
3141         (-[HIDEventGenerator touchFromEventInfo:]):
3142         (-[HIDEventGenerator _createIOHIDEventWithInfo:]):
3143         (-[HIDEventGenerator dispatchEventWithInfo:]):
3144         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3145         (-[HIDEventGenerator sendEventStream:completionBlock:]):
3146         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3147         (WTR::UIScriptController::sendEventStream):
3148
3149 2016-10-04  Megan Gardner  <megan_gardner@apple.com>
3150
3151         Add Megan to contributor's list
3152         https://bugs.webkit.org/show_bug.cgi?id=162944
3153
3154         Reviewed by Tim Horton.
3155
3156         Add Megan to the contributor's lists so that her e-mail autocompletes for CC
3157
3158         * Scripts/webkitpy/common/config/contributors.json:
3159
3160 2016-10-04  Alex Christensen  <achristensen@webkit.org>
3161
3162         Add tests verifying non-special URL hosts are parsed according to spec
3163         https://bugs.webkit.org/show_bug.cgi?id=162885
3164
3165         Reviewed by Sam Weinig.
3166
3167         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3168         (TestWebKitAPI::TEST_F):
3169
3170 2016-10-04  Anders Carlsson  <andersca@apple.com>
3171
3172         Properly kill web processes in the launching state
3173         https://bugs.webkit.org/show_bug.cgi?id=162938
3174
3175         Reviewed by Tim Horton.
3176
3177         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
3178         Enable this test again.
3179
3180 2016-10-04  Alex Christensen  <achristensen@webkit.org>
3181
3182         URLParser: query-only URLs relative to file URLs should just add a query
3183         https://bugs.webkit.org/show_bug.cgi?id=162888
3184
3185         Reviewed by Tim Horton.
3186
3187         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3188         (TestWebKitAPI::TEST_F):
3189
3190 2016-10-04  Alex Christensen  <achristensen@webkit.org>
3191
3192         URLParser should match URL::parse and other browsers when parsing a URL containing only scheme://
3193         https://bugs.webkit.org/show_bug.cgi?id=162909
3194
3195         Reviewed by Tim Horton.
3196
3197         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3198         (TestWebKitAPI::TEST_F):
3199
3200 2016-10-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3201
3202         [DOMJIT] Introduce DOMJIT::GetterSetter to tell JIT information
3203         https://bugs.webkit.org/show_bug.cgi?id=162916
3204
3205         Reviewed by Filip Pizlo.
3206
3207         * DumpRenderTree/CMakeLists.txt:
3208
3209 2016-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3210
3211         Media controls are displayed in the incorrect state momentarily after switching between tabs playing media
3212         https://bugs.webkit.org/show_bug.cgi?id=162766
3213         <rdar://problem/28533523>
3214
3215         Reviewed by Jer Noble.
3216
3217         Adds new tests and tweaks existing tests to verify last updated Now Playing information.
3218
3219         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
3220         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]):
3221         (TestWebKitAPI::TEST):
3222         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:]): Deleted.
3223         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html:
3224
3225 2016-10-03  Alex Christensen  <achristensen@webkit.org>
3226
3227         URLParser should ignore tabs at all locations
3228         https://bugs.webkit.org/show_bug.cgi?id=162836
3229
3230         Reviewed by Geoffrey Garen.
3231
3232         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3233         (TestWebKitAPI::checkURL):
3234         (TestWebKitAPI::checkRelativeURL):
3235         (TestWebKitAPI::checkURLDifferences):
3236         (TestWebKitAPI::checkRelativeURLDifferences):
3237         (TestWebKitAPI::TEST_F):
3238
3239 2016-10-03  Alex Christensen  <achristensen@webkit.org>
3240
3241         URLParser: fragment-only URLs relative to file URLs should just add a fragment
3242         https://bugs.webkit.org/show_bug.cgi?id=162871
3243
3244         Reviewed by Geoffrey Garen.
3245
3246         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3247         (TestWebKitAPI::TEST_F):
3248
3249 2016-10-03  Per Arne Vollan  <pvollan@apple.com>
3250
3251         [Win] DRT temp folder is not used.
3252         https://bugs.webkit.org/show_bug.cgi?id=162863
3253
3254         Reviewed by Alex Christensen.
3255
3256         Convert DRT temp folder to DOS path, which DRT can use.
3257
3258         * Scripts/webkitpy/port/driver.py:
3259         (Driver._setup_environ_for_driver):
3260
3261 2016-10-03  Alex Christensen  <achristensen@webkit.org>
3262
3263         URLParser: empty relative URLs should not copy fragment from the base URL
3264         https://bugs.webkit.org/show_bug.cgi?id=162864
3265
3266         Reviewed by Chris Dumez.
3267
3268         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3269         (TestWebKitAPI::TEST_F):
3270
3271 2016-10-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3272
3273         [SOUP] Cleanup persistent credential storage code
3274         https://bugs.webkit.org/show_bug.cgi?id=162777
3275
3276         Reviewed by Alex Christensen.
3277
3278         Use USE(LIBSECRET) instead of ENABLE(CREDENTIAL_STORAGE).
3279
3280         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
3281         (testWebViewAuthenticationStorage):
3282
3283 2016-10-02  Darin Adler  <darin@apple.com>
3284
3285         Rename ExceptionCode-based exception handling to "legacy"
3286         https://bugs.webkit.org/show_bug.cgi?id=162859
3287
3288         Reviewed by Chris Dumez.
3289
3290         * Scripts/do-webcore-rename: Updated script to do this round of renames.
3291
3292 2016-10-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3293
3294         Media controls for Soundcloud easily falls out of sync with what's actually playing
3295         https://bugs.webkit.org/show_bug.cgi?id=162843
3296         <rdar://problem/28176874>
3297
3298         Reviewed by Beth Dakin.
3299
3300         Adds two new tests simulating audio playback behavior on soundcloud. Also tweaks some of the WKWebView test
3301         message handling logic to support having multiple message-handler mappings.
3302
3303         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3304         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3305         (TestWebKitAPI::TEST):
3306         * TestWebKitAPI/Tests/WebKit2Cocoa/play-audio-on-click.html: Added.
3307         * TestWebKitAPI/mac/TestWKWebViewMac.h:
3308         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
3309         (-[TestMessageHandler addMessage:withHandler:]):
3310         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
3311         (-[TestWKWebView performAfterReceivingMessage:action:]):
3312         (-[TestWKWebView performAfterLoading:]):
3313         (-[TestMessageHandler initWithMessage:handler:]): Deleted.
3314
3315 2016-09-30  Alex Christensen  <achristensen@webkit.org>
3316
3317         Fix off-by-one error in URLParser::parseIPv4Host
3318         https://bugs.webkit.org/show_bug.cgi?id=162789
3319
3320         Reviewed by Tim Horton.
3321
3322         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3323         (TestWebKitAPI::TEST_F):
3324
3325 2016-09-30  Alex Christensen  <achristensen@webkit.org>
3326
3327         URLParser: parsing a URL with an empty host and a colon should fail
3328         https://bugs.webkit.org/show_bug.cgi?id=162795
3329
3330         Reviewed by Tim Horton.
3331
3332         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3333         (TestWebKitAPI::TEST_F):
3334
3335 2016-09-30  Alex Christensen  <achristensen@webkit.org>
3336
3337         URLParser: handle syntax violations in non-UTF-8 encoded queries
3338         https://bugs.webkit.org/show_bug.cgi?id=162770
3339
3340         Reviewed by Tim Horton.
3341
3342         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3343         (TestWebKitAPI::checkURL):
3344         (TestWebKitAPI::TEST_F):
3345         Tests with emoji change behavior when we insert a tab between the surrogates, so don't do the
3346         insert-tab-at-each-location verification that syntax violations are handled correctly.
3347
3348 2016-09-30  Megan Gardner  <megan_gardner@apple.com>
3349
3350         Make it possible to test web-related user-interface features
3351         https://bugs.webkit.org/show_bug.cgi?id=162657
3352
3353         Reviewed by Simon Fraser.
3354
3355         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3356         (WTR::UIScriptController::contentsOfUserInterfaceItem):
3357         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
3358         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3359         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3360         (WTR::UIScriptController::contentsOfUserInterfaceItem):
3361         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
3362         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3363         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3364         (WTR::UIScriptController::contentsOfUserInterfaceItem):
3365         (WTR::UIScriptController::selectFormAccessoryPickerRow): Deleted.
3366
3367 2016-09-29  Jiewen Tan  <jiewen_tan@apple.com>
3368
3369         Expose CryptoKey to web workers
3370         https://bugs.webkit.org/show_bug.cgi?id=162640
3371         <rdar://problem/28182204>
3372
3373         Reviewed by Brent Fulgham.
3374
3375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3376         * TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm: Added.
3377         (TestWebKitAPI::TEST_F):
3378         Add API tests for SerializedCryptoKeyWrap APIs.
3379
3380 2016-09-29  Alex Christensen  <achristensen@webkit.org>
3381
3382         Fix syntax violation handling in IPv4 address parsing
3383         https://bugs.webkit.org/show_bug.cgi?id=162756
3384
3385         Reviewed by Tim Horton.
3386
3387         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3388         (TestWebKitAPI::TEST_F):
3389
3390 2016-09-29  Alex Christensen  <achristensen@webkit.org>
3391
3392         URLParser should correctly parse ports with leading 0's
3393         https://bugs.webkit.org/show_bug.cgi?id=162752
3394
3395         Reviewed by Tim Horton.
3396
3397         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3398         (TestWebKitAPI::TEST_F):
3399
3400 2016-09-29  Alex Christensen  <achristensen@webkit.org>
3401
3402         URLParser: make parsing invalid IPv4 addresses more robust and correct
3403         https://bugs.webkit.org/show_bug.cgi?id=162746
3404
3405         Reviewed by Tim Horton.
3406
3407         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3408         (TestWebKitAPI::TEST_F):
3409
3410 2016-09-29  Alex Christensen  <achristensen@webkit.org>
3411
3412         URLParser: IPv6 addresses followed by a colon are invalid
3413         https://bugs.webkit.org/show_bug.cgi?id=162747
3414
3415         Reviewed by Tim Horton.
3416
3417         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3418         (TestWebKitAPI::TEST_F):
3419
3420 2016-09-29  Alexey Proskuryakov  <ap@apple.com>
3421
3422         Make WKTR short timeout dynamic
3423         https://bugs.webkit.org/show_bug.cgi?id=162733
3424
3425         Reviewed by Alex Christensen.
3426
3427         WebKitTestRunner has a hardcoded value for how long to wait for IPC responses,
3428         which is 5 seconds, or 10 seconds under ASan. But some of the operations can be
3429         fairly time consuming - e.g. launching Networking process on demand.
3430         These may take longer under load, especially with GuardMalloc.
3431
3432         * WebKitTestRunner/TestController.cpp:
3433         (WTR::TestController::resetStateToConsistentValues):
3434         (WTR::TestController::reattachPageToWebProcess):
3435         * WebKitTestRunner/TestController.h:
3436         * WebKitTestRunner/TestInvocation.cpp:
3437         (WTR::TestInvocation::shortTimeout):
3438         (WTR::TestInvocation::invoke):
3439         (WTR::TestInvocation::dumpResults):
3440
3441         * WebKitTestRunner/TestInvocation.h:
3442         (WTR::TestInvocation::customTimeout): Deleted, this function was unused.
3443
3444 2016-09-29  Alex Christensen  <achristensen@webkit.org>
3445
3446         URLParser should fail to parse unclosed IPv6 addresses
3447         https://bugs.webkit.org/show_bug.cgi?id=162715
3448
3449         Reviewed by Tim Horton.
3450
3451         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3452         (TestWebKitAPI::TEST_F):
3453
3454 2016-09-29  Alex Christensen  <achristensen@webkit.org>
3455
3456         URLParser should ignore tabs at all possible locations
3457         https://bugs.webkit.org/show_bug.cgi?id=162711
3458
3459         Reviewed by Tim Horton.
3460
3461         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3462         (TestWebKitAPI::ExpectedParts::isInvalid):
3463         (TestWebKitAPI::checkURL):
3464         (TestWebKitAPI::TEST_F):
3465
3466 2016-09-29  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
3467
3468         [EFL] Add search button to url bar in MiniBrowser
3469         https://bugs.webkit.org/show_bug.cgi?id=162716
3470
3471         Reviewed by Michael Catanzaro.
3472
3473         As a bug title, it would be good to add a search button to URL bar.
3474         Additionally this patch changes color of button to recognize the buttons.
3475
3476         * MiniBrowser/efl/main.c:
3477         (_search_button_clicked_cb):
3478         (_create_toolbar_button):
3479         (window_create):
3480         (create_toolbar_button): Deleted.
3481
3482 2016-09-28  Tim Horton  <timothy_horton@apple.com>
3483
3484         API test WebKit2.AutoLayoutIntegration is a flaky timeout
3485         https://bugs.webkit.org/show_bug.cgi?id=160284
3486
3487         Reviewed by Dan Bernstein.
3488
3489         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3490         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
3491         (-[AutoLayoutWKWebView beginLayoutAtMinimumWidth:andExpectContentSizeChange:]):
3492         (-[AutoLayoutWKWebView waitForContentSizeChangeResettingWidth:]):
3493         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
3494         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
3495         (TEST):
3496         Make the autolayout tests a bit more flexible regarding the ordering of
3497         invalidateIntrinsicContentSize, to avoid a race between the load
3498         completing and the invalidation.
3499
3500         Also, move the newly added test to use its own WKWebView, since once in a
3501         while we get a first layout notification from the previous page, causing the test to fail.
3502
3503         Un-disable the tests, which now run without any flakes for me with quite a few iterations.
3504
3505 2016-09-28  Alex Christensen  <achristensen@webkit.org>
3506
3507         URLParser should properly handle unexpected periods and overflows in IPv4 addresses
3508         https://bugs.webkit.org/show_bug.cgi?id=162655
3509
3510         Reviewed by Geoffrey Garen.
3511
3512         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3513         (TestWebKitAPI::TEST_F):
3514
3515 2016-09-28  Ryan Haddad  <ryanhaddad@apple.com>
3516
3517         Disable flaky API test WebKit2.AutoLayoutIntegration.
3518         https://bugs.webkit.org/show_bug.cgi?id=160284
3519
3520         Unreviewed test gardening.
3521
3522         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3523         (TEST):
3524
3525 2016-09-28  Alex Christensen  <achristensen@webkit.org>
3526
3527         URLParser should ignore tabs in authority
3528         https://bugs.webkit.org/show_bug.cgi?id=162694
3529
3530         Reviewed by Geoffrey Garen.
3531
3532         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3533         (TestWebKitAPI::TEST_F):
3534
3535 2016-09-28  Alex Christensen  <achristensen@webkit.org>
3536
3537         URLParser should ignore extra slashes after scheme:// and handle a missing slash after the port
3538         https://bugs.webkit.org/show_bug.cgi?id=162690
3539
3540         Reviewed by Geoffrey Garen.
3541
3542         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3543         (TestWebKitAPI::TEST_F):
3544
3545 2016-09-28  Alex Christensen  <achristensen@webkit.org>
3546
3547         URLParser should correctly canonicalize uppercase IPv6 addresses
3548         https://bugs.webkit.org/show_bug.cgi?id=162680
3549
3550         Reviewed by Tim Horton.
3551
3552         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3553         (TestWebKitAPI::TEST_F):
3554
3555 2016-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3556
3557         Adopt MediaRemote SPI to achieve desired Now Playing behavior
3558         https://bugs.webkit.org/show_bug.cgi?id=162658
3559         <rdar://problem/28499358>
3560
3561         Reviewed by Jer Noble.
3562
3563         Introduces 2 unit tests in the new NowPlayingControlsTests test suite. Also provides some basic support for
3564         mocking key window status for TestWKWebViews.
3565
3566         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3567         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm: Added.
3568         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
3569         (-[NowPlayingTestWebView expectHasActiveNowPlayingSession:]):
3570         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:]):
3571         (TestWebKitAPI::TEST):
3572         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-test-now-playing.html: Added.
3573         * TestWebKitAPI/mac/TestWKWebViewMac.mm:
3574         (-[TestWKWebViewHostWindow isKeyWindow]):
3575         (-[TestWKWebViewHostWindow makeKeyWindow]):
3576         (-[TestWKWebViewHostWindow resignKeyWindow]):
3577
3578 2016-09-28  Per Arne Vollan  <pvollan@apple.com>
3579
3580         [Win] Compile fix.
3581         https://bugs.webkit.org/show_bug.cgi?id=162670
3582
3583         Reviewed by Brent Fulgham.
3584
3585         Make sure we include JavaScriptCore files from the forwarding headers folder.
3586         Otherwise we might get multiple definitions if a JSC file is included both
3587         from the forwarding headers folder and the JSC source folder, since
3588         #pragma once is used in the header files.
3589
3590         * DumpRenderTree/TestRunner.cpp:
3591
3592 2016-09-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3593
3594         [GTK] Add Chrome UA quirk
3595         https://bugs.webkit.org/show_bug.cgi?id=162617
3596
3597         Reviewed by Carlos Garcia Campos.
3598
3599         Update test. This portion of the commit was actually unreviewed.
3600
3601         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
3602         (TestWebKitAPI::TEST):
3603
3604 2016-09-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3605
3606         [GTK] Adjust OS X UA quirks list
3607         https://bugs.webkit.org/show_bug.cgi?id=162616
3608
3609         "Reviewed" by Carlos Garcia Campos.
3610
3611         Update test. This portion of the commit was actually unreviewed.
3612
3613         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
3614         (TestWebKitAPI::TEST):
3615
3616 2016-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3617
3618         [GTK] Switch to use GMenu internally in the context menu implementation
3619         https://bugs.webkit.org/show_bug.cgi?id=162603
3620
3621         Reviewed by Michael Catanzaro.
3622
3623         Remove smart separators test, since that's now done automatically by GTK+.
3624
3625         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3626         (beforeAll):
3627         (testContextMenuWebExtensionMenu): Deleted.
3628
3629 2016-09-27  Alex Christensen  <achristensen@webkit.org>
3630
3631         Correctly parse URLs with the first tab in the fragment
3632         https://bugs.webkit.org/show_bug.cgi?id=162650
3633
3634         Reviewed by Saam Barati.
3635
3636         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3637         (TestWebKitAPI::TEST_F):
3638
3639 2016-09-27  Alex Christensen  <achristensen@webkit.org>
3640
3641         URLParser: Handle windows drive letters after two slashes in relative URLs according to spec
3642         https://bugs.webkit.org/show_bug.cgi?id=162646
3643
3644         Reviewed by Saam Barati.
3645
3646         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3647         (TestWebKitAPI::TEST_F):
3648
3649 2016-09-27  Alex Christensen  <achristensen@webkit.org>
3650
3651         URLs with @ in the user should only search for the last @ until the end of the authority and host
3652         https://bugs.webkit.org/show_bug.cgi?id=162635
3653
3654         Reviewed by Geoffrey Garen.
3655
3656         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3657         (TestWebKitAPI::TEST_F):
3658
3659 2016-09-27  JF Bastien  <jfbastien@apple.com>
3660
3661         Speed up Heap::isMarkedConcurrently
3662         https://bugs.webkit.org/show_bug.cgi?id=162095
3663
3664         Reviewed by Filip Pizlo.
3665
3666         * TestWebKitAPI/CMakeLists.txt:
3667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3668         * TestWebKitAPI/Tests/WTF/Consume.cpp: Added.
3669         (testConsume):
3670         (TestWebKitAPI::TEST):
3671
3672 2016-09-26  Alex Christensen  <achristensen@webkit.org>
3673
3674         Implement URLParser::syntaxViolation
3675         https://bugs.webkit.org/show_bug.cgi?id=162593
3676
3677         Reviewed by Geoffrey Garen.
3678
3679         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3680         (TestWebKitAPI::TEST_F):
3681
3682 2016-09-27  Anders Carlsson  <andersca@apple.com>
3683
3684         Turns out OptionSet.cpp wasn't added to the right target. Add it and fix the build for real.
3685
3686         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3687         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
3688         (TestWebKitAPI::TEST):
3689
3690 2016-09-27  Anders Carlsson  <andersca@apple.com>
3691
3692         Try to fix the GTK+ build.
3693
3694         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
3695         (TestWebKitAPI::TEST):
3696
3697 2016-09-27  Dan Bernstein  <mitz@apple.com>
3698
3699         [iOS] REGRESSION (r182126): Selection highlight and handles aren’t visible with WKSelectionGranularityCharacter
3700         https://bugs.webkit.org/show_bug.cgi?id=162577
3701         <rdar://problem/28481984>
3702
3703         Reviewed by Simon Fraser.
3704
3705         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3706         (WTR::UIScriptController::selectionRangeViewRects): Returns null.
3707
3708         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Declared new
3709           selectionRangeViewRects attribute.
3710
3711         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3712         (WTR::UIScriptContext::jsContext): Added this public accessor.
3713
3714         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3715         (WTR::selectionRangeViewRects): Generic implementation that returns null.
3716         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3717
3718         * WebKitTestRunner/TestController.cpp:
3719         (WTR::updateTestOptionsFromTestHeader): Parse the new useCharacterSelectionGranularity
3720           option.
3721
3722         * WebKitTestRunner/TestOptions.h: Added new useCharacterSelectionGranularity option.
3723
3724         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3725         (WTR::TestController::platformCreateWebView): Set the configuration’s selectionGranularity
3726           property based on the new option.
3727
3728         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3729         (WTR::PlatformWebView::viewSupportsOptions): Compare selection granularity option values.
3730
3731         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3732         (WTR::UIScriptController::selectionRangeViewRects): iOS-specific implementation that calls
3733           the new -[WKWebView _uiTextSelectionRectViews] and returns an array of view frame
3734           dictionaries.
3735
3736 2016-09-27  Daniel Bates  <dabates@apple.com>
3737
3738         Cannot run dump-class-layout; dies with "global name 'lldb' is not defined"
3739         https://bugs.webkit.org/show_bug.cgi?id=162585
3740
3741         Reviewed by Simon Fraser.
3742
3743         Import the lldb module into the global namespace.
3744
3745         Currently dump-class-layout imports the lldb Python module using the import statement
3746         from the helper function import_lldb. The import statement imports the names of the
3747         specified module into the scope of import_lldb(); => the names imported from this
3748         module cannot be accessed outside the scope of import_lldb(). Other functions in
3749         this script assume that the lldb module was imported into the global scope. We should
3750         import the module lldb into the global scope, if it exists, so that these functions
3751         can find it. Otherwise, we should emit a human readable error message that explains
3752         that we failed to import the lldb module.
3753
3754         Also remove some unnecessary semicolon characters.
3755
3756         * Scripts/dump-class-layout:
3757         (import_lldb):
3758
3759 2016-09-27  Jer Noble  <jer.noble@apple.com>
3760
3761         Remove deprecated ENCRYPTED_MEDIA implementation.
3762         https://bugs.webkit.org/show_bug.cgi?id=161010
3763
3764         Reviewed by Eric Carlson.
3765
3766         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3767
3768 2016-09-27  Chris Dumez  <cdumez@apple.com>
3769
3770         [WK2] Navigating to a Blob URL does not trigger a download
3771         https://bugs.webkit.org/show_bug.cgi?id=162574
3772
3773         Reviewed by Darin Adler.
3774
3775         Add API that tests navigating to a Blob URL and checks that that the load
3776         properly gets converted into a download.
3777
3778         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3779         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3780         (-[BlobDownloadDelegate _downloadDidStart:]):
3781         (-[BlobDownloadDelegate _download:didReceiveResponse:]):
3782         (-[BlobDownloadDelegate _download:didReceiveData:]):
3783         (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3784         (-[BlobDownloadDelegate _downloadDidFinish:]):
3785         (-[DownloadBlobURLNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3786         (TEST):
3787         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestBlobURL.html: Added.
3788
3789 2016-09-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3790
3791         [GTK] Install binaries to pkglibexecdir rather than bindir
3792         https://bugs.webkit.org/show_bug.cgi?id=162602
3793
3794         Reviewed by Carlos Garcia Campos.
3795
3796         Install MiniBrowser to LIBEXEC_INSTALL_DIR rather than EXEC_INSTALL_DIR.
3797
3798         * MiniBrowser/gtk/CMakeLists.txt:
3799
3800 2016-09-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3801
3802         [EFL] Locate color picker popup to center of window
3803         https://bugs.webkit.org/show_bug.cgi?id=162540
3804
3805         Reviewed by Michael Catanzaro.
3806
3807         Color picker popup hasn't located in a center of main window, because
3808         elm_win_center() function doesn't work correctly. It looks a bug.
3809
3810         To fix the problem, this patch uses evas_object_geometry_set() instead.
3811
3812         * MiniBrowser/efl/main.c:
3813         (_color_picker_request_cb):
3814
3815 2016-09-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3816
3817         [GTK] Disable ACCELERATED_2D_CANVAS when using build-webkit
3818         https://bugs.webkit.org/show_bug.cgi?id=162600
3819
3820         Reviewed by Carlos Garcia Campos.
3821
3822         * Scripts/webkitperl/FeatureList.pm:
3823
3824 2016-09-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3825
3826         PyGIWarnings printed by webkit-patch
3827         https://bugs.webkit.org/show_bug.cgi?id=152470
3828
3829         Reviewed by Carlos Garcia Campos.
3830
3831         Update to a newer version of the keyring module, since this bug has been fixed upstream for
3832         a while. But be careful not to update to the latest version, since it has some compatibility
3833         breaks and requires the SecretService python module on Linux, but I couldn't figure out how
3834         to autoinstall it successfully.
3835
3836         * Scripts/webkitpy/thirdparty/__init__.py:
3837         (AutoinstallImportHook._install_keyring):
3838
3839 2016-09-26  Ryan Haddad  <ryanhaddad@apple.com>
3840
3841         Add Sierra to the flakiness dashboard.
3842         https://bugs.webkit.org/show_bug.cgi?id=162509
3843
3844         Reviewed by Alexey Proskuryakov.
3845
3846         * TestResultServer/static-dashboards/builders.jsonp:
3847
3848 2016-09-26  Daniel Bates  <dabates@apple.com>
3849
3850         Rename IOS_TEXT_AUTOSIZING to TEXT_AUTOSIZING
3851         https://bugs.webkit.org/show_bug.cgi?id=162365
3852
3853         Reviewed by Simon Fraser.
3854
3855         * DumpRenderTree/TestRunner.h:
3856         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3857
3858 2016-09-26  Tomas Popela  <tpopela@redhat.com>
3859
3860         [GTK] TestContextMenu is failing
3861         https://bugs.webkit.org/show_bug.cgi?id=162569
3862
3863         We cannot use the MP3 file in the TestContextMenu, as it will not work
3864         by default on most distributions (that don't have an MP3 codecs
3865         installed). Change the test to use OGG file instead.
3866
3867         Reviewed by Michael Catanzaro.
3868
3869         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3870         (testContextMenuDefaultMenu):
3871
3872 2016-09-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3873
3874         Using char16_t instead of wchar_t in TestWebKitAPI URLParser tests
3875         https://bugs.webkit.org/show_bug.cgi?id=162537
3876
3877         Reviewed by Alex Christensen.
3878
3879         Some build bot (Linux ARM GTK port) fails since we cannot select
3880         the specific StringBuilder::append method for wchar_t.
3881
3882         wchar_t implementation highly depends on platforms. sizeof(wchar_t) == 2
3883         in Windows, while sizeof(wchar_t) == 4 in Linux and OS X. So, ICU
3884         uses wchar_t for UChar (UTF-16) in Windows while it doesn't in other
3885         platforms.
3886
3887         StringBuilder::append is overloaded for UChar. In Windows, we can pass
3888         wchar_t since UChar is wchar_t. However, we cannot do that in other platforms.
3889
3890         Instead of using wchar_t, we use more platform portable UTF-16 literal for
3891         testing. Use char16_t and C++11 UTF-16 literal.
3892
3893         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3894         (TestWebKitAPI::utf16String):
3895         (TestWebKitAPI::TEST_F):
3896         (TestWebKitAPI::wideString): Deleted.
3897
3898 2016-09-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3899
3900         [EFL] Adjust EFL indentation to EFL MiniBrowser
3901         https://bugs.webkit.org/show_bug.cgi?id=162542
3902
3903         Unreviewed, EFL simple coding style fix.
3904
3905         Some functions wasn't applied EFL coding style in prefix fix.
3906
3907         * MiniBrowser/efl/main.c:
3908         (_key_down_cb):
3909         (view_focus_set):
3910         (_mouse_down_cb):
3911         (title_set):
3912         (_title_changed_cb):
3913         (_url_changed_cb):
3914         (_back_forward_list_changed_cb):
3915         (_progress_cb):
3916         (_error_cb):
3917         (_download_request_cb):
3918         (close_file_picker):
3919         (_filepicker_parent_deletion_cb):
3920         (_filepicker_deletion_cb):
3921         (_fileselector_done_cb):
3922         (_file_chooser_request_cb):
3923         (_download_finished_cb):
3924         (_download_failed_cb):
3925         (_color_changed_cb):
3926         (_color_item_selected_cb):
3927         (_color_picker_ok_clicked_cb):
3928         (_color_picker_cancel_clicked_cb):
3929         (_color_picker_dismiss_cb):
3930         (_color_picker_request_cb):
3931         (quit):
3932         (has_scheme):
3933         (url_from_user_input):
3934         (url_load_from_user_input):
3935         (_url_bar_activated_cb):
3936         (_url_bar_clicked_cb):
3937         (_search_field_aborted_cb):
3938         (_search_field_activated_cb):
3939         (_search_field_clicked_cb):
3940         (_back_button_clicked_cb):
3941         (_forward_button_clicked_cb):
3942         (_search_backward_button_clicked_cb):
3943         (_search_forward_button_clicked_cb):
3944         (_search_case_option_changed):
3945         (_search_word_start_option_changed_cb):
3946         (_search_close_button_clicked_cb):
3947         (_refresh_button_clicked_cb):
3948         (_stop_button_clicked_cb):
3949         (list_item_label_get):
3950         (_list_item_select_cb):
3951         (navigation_button_longpress_process):
3952         (_forward_button_longpress_cb):
3953         (_back_button_longpress_cb):
3954         (quit_event_loop):
3955         (_ok_clicked_cb):
3956         (_file_entry_dialog_show):
3957
3958 2016-09-24  Chris Dumez  <cdumez@apple.com>
3959
3960         [WK2] anchor.download attribute value is ignored by NETWORK_SESSION code path
3961         https://bugs.webkit.org/show_bug.cgi?id=162531
3962
3963         Reviewed by Darin Adler.
3964
3965         Update decideDestinationWithSuggestedFilename() to return a actual file path
3966         instead of nullptr. The NETWORK_SESSION code path cancels the download when
3967         decideDestinationWithSuggestedFilename() returns an empty file path, unlike
3968         the !NETWORK_SESSION code path that just continue downloading without
3969         explicitely setting a destination path. This lead to different test results
3970         for NETWORK_SESSION and !NETWORK_SESSION code paths. Returns a valid
3971         destination path makes more sense and leads to consistent results.
3972
3973         * WebKitTestRunner/TestController.cpp:
3974         (WTR::TestController::decideDestinationWithSuggestedFilename):
3975
3976 2016-09-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3977
3978         [mac-sierra] 2 WKWebViewCandidateTests API test failures
3979         https://bugs.webkit.org/show_bug.cgi?id=162470
3980
3981         Reviewed by Tim Horton.
3982
3983         VideoControlsManager, WKWebViewCandidateTests and CandidateTests should not be running on 10.12.0. Guard these
3984         tests with an SDK check to prevent 10.12.0 bots from building them.
3985
3986         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3987         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
3988         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
3989
3990 2016-09-23  Alex Christensen  <achristensen@webkit.org>
3991
3992         Refactor URLParser
3993         https://bugs.webkit.org/show_bug.cgi?id=162516
3994
3995         Reviewed by Brady Eidson.
3996
3997         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3998         (TestWebKitAPI::TEST_F):
3999
4000 2016-09-23  Caitlin Potter  <caitp@igalia.com>
4001
4002         [JSC] Implement parsing of Async Functions
4003         https://bugs.webkit.org/show_bug.cgi?id=161409
4004
4005         Reviewed by Yusuke Suzuki.
4006
4007         * Scripts/build-jsc:
4008         (cMakeArgsFromFeatures):
4009         * Scripts/webkitperl/FeatureList.pm:
4010         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4011
4012 2016-09-23  Alex Christensen  <achristensen@webkit.org>
4013
4014         Refactor URLParser
4015         https://bugs.webkit.org/show_bug.cgi?id=162511
4016
4017         Reviewed by Brady Eidson.
4018
4019         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4020         (TestWebKitAPI::TEST_F):
4021         (TestWebKitAPI::checkURL):
4022
4023 2016-09-23  Alexey Proskuryakov  <ap@apple.com>
4024
4025         iOS playback user action tests fail on some machines
4026         https://bugs.webkit.org/show_bug.cgi?id=162504
4027         rdar://problem/28013994
4028
4029         Reviewed by Jer Noble.
4030
4031         Avoid the need to have a timeout.
4032
4033         * TestWebKitAPI/Tests/WebKit/ios/audio-only.html:
4034         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
4035         * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
4036         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html:
4037
4038 2016-09-23  Carlos Garcia Campos  <cgarcia@igalia.com>
4039
4040         REGRESSION(r204163): [GTK] API test /webkit2/WebKitSecurityManager/file-xhr is failing
4041         https://bugs.webkit.org/show_bug.cgi?id=161607
4042
4043         Reviewed by Michael Catanzaro.
4044
4045         Since r204163, in case of cross origin error when loading the XHR, the load fails and an error message is shown
4046         in the console, but there isn't any js expcetion, which is what we were checking. Now, we check that there
4047         aren't exceptions, and that the error message is sent to the console.
4048
4049         * Scripts/run-gtk-tests:
4050         (TestRunner):
4051         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
4052         (consoleMessageReceivedCallback):
4053         (testWebContextSecurityFileXHR):
4054
4055 2016-09-23  Ryan Haddad  <ryanhaddad@apple.com>
4056
4057         Use correct hardware for Sierra Debug WK2 testers.
4058         https://bugs.webkit.org/show_bug.cgi?id=162474
4059
4060         Reviewed by Alexey Proskuryakov.
4061
4062         * BuildSlaveSupport/build.webkit.org-config/config.json:
4063
4064 2016-09-23  Carlos Garcia Campos  <cgarcia@igalia.com>
4065
4066         [GTK] Make all WebView tests have a WebKitUserContentManager
4067         https://bugs.webkit.org/show_bug.cgi?id=162487
4068
4069         Reviewed by Michael Catanzaro.
4070
4071         It simplifies tests using the user content manager, and allows to use it without having to subclass WebViewTest.
4072
4073         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
4074         (ConsoleMessageTest::ConsoleMessageTest):
4075         (ConsoleMessageTest::~ConsoleMessageTest):
4076         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
4077         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
4078         (testUserContentManagerInjectedStyleSheet):
4079         (testUserContentManagerInjectedScript):
4080         (UserScriptMessageTest::UserScriptMessageTest):
4081         (beforeAll):
4082         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
4083         (testWebViewIsPlayingAudio):
4084         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
4085         (WebViewTest::WebViewTest):
4086         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
4087
4088 2016-09-23  Antoine Quint  <graouts@apple.com>
4089
4090         Add a new runtime flag for work on modern media controls (off by default)
4091         https://bugs.webkit.org/show_bug.cgi?id=162420
4092         <rdar://problem/27989489>
4093
4094         Reviewed by Eric Carlson.
4095
4096         * DumpRenderTree/mac/DumpRenderTree.mm:
4097         (resetWebPreferencesToConsistentValues):
4098         * DumpRenderTree/win/DumpRenderTree.cpp:
4099         (resetWebPreferencesToConsistentValues):
4100         * Scripts/webkitperl/FeatureList.pm:
4101         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4102         (WTR::InjectedBundle::beginTesting):
4103         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4104         (WTR::TestRunner::setModernMediaControlsEnabled):
4105         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4106
4107 2016-09-23  Carlos Garcia Campos  <cgarcia@igalia.com>
4108
4109         REGRESSION(r194387): Crash on github.com in IntlDateTimeFormat::resolvedOptions in C locale
4110         https://bugs.webkit.org/show_bug.cgi?id=162139
4111
4112         Reviewed by Michael Catanzaro.
4113
4114         Add test cases to check the behavior when using the C locale and an invalid locale.
4115
4116         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
4117         (testWebContextLanguages):
4118
4119 2016-09-22  Hunseop Jeong  <hs85.jeong@samsung.com>
4120
4121         [EFL] alert box is not displayed 
4122         https://bugs.webkit.org/show_bug.cgi?id=156395
4123
4124         Reviewed by Gyuyoung Kim.
4125
4126         Some popup objects(alert, confirm, prompt, file entry dialog) used the ecore_main_loop_begin() to make
4127         the modal popup but ecore_main_loop_begin() was not executed inside an exisiting main loop. So we have
4128         to use the ecore_main_loop_iterate() instead of the ecore_main_loop_begin().
4129
4130         * MiniBrowser/efl/main.c:
4131         (_ok_clicked_cb):
4132         (_file_entry_dialog_show):
4133         (_javascript_alert_cb):
4134         (_javascript_confirm_cb):
4135         (_javascript_prompt_cb):
4136         (quit_event_loop): Deleted.
4137
4138 2016-09-22  Matthew Hanson  <matthew_hanson@apple.com>
4139
4140         Add an API for getting the branch identifier from a Git or SVN checkout.
4141         https://bugs.webkit.org/show_bug.cgi?id=151570
4142         rdar://problem/17959831
4143
4144         Reviewed by David Kilzer.
4145
4146         This patch adds a function called svnIdentifierForPath. This function returns either "trunk",
4147         the name of the tag, or the name of the branch, as appropriate. This function is necessary for
4148         a VCSUtils client that is not checked in to the WebKit project.
4149
4150         This patch also breaks up pathRelativeToSVNRepositoryRootForPath into four functions:
4151         - pathRelativeToSVNRepositoryRootForPath
4152         - svnInfoForPath
4153         - svnURLForPath
4154         - svnRepositoryRootForPath
4155
4156         This allows us to reuse logic from pathRelativeToSVNRepositoryRootForPath in svnIdentifierForPath and
4157         allows clients of VCSUtils to extract what arbitrary information from the `svn info` command regardless
4158         of SCM.
4159
4160         * Scripts/VCSUtils.pm:
4161         (svnInfoForPath):
4162         Copied logic that previously lived in pathRelativeToSVNRepositoryRootForPath.
4163         Make code safe to use for a path, and not just for the CWD.
4164
4165         (svnURLForPath):
4166         Calls svnInfoForPath and extracts the URL.
4167
4168         (svnRepositoryRootForPath):
4169         Calls svnInfoForPath and extracts the Repository Root.
4170
4171         (svnIdentifierForPath):
4172         Calls pathRelativeToSVNRepositoryRootForPath and extracts the repository identifier.
4173
4174         (pathRelativeToSVNRepositoryRootForPath):
4175         Now uses svnURLForPath and svnRepositoryRootForPath instead of being responsible for
4176         determining both values.
4177
4178 2016-09-22  Megan Gardner  <megan_gardner@apple.com>
4179
4180         Add long press selection test
4181         https://bugs.webkit.org/show_bug.cgi?id=162367
4182
4183         Reviewed by Simon Fraser.
4184
4185         Add support to UIScriptController to synthesize long press events on iOS.
4186         This required adding long-press functionality to HIDEventGenerator.
4187
4188         HIDEventGenerator sends the touchDown, but must then send the touchUp with
4189         a dispatch_after (rather than sleeping, as we do for other events) in order
4190         for the gesture recognizers to correctly detect a long press.
4191
4192         Use the long press synthesis in a test that detects whether a long press
4193         gesture triggers text selection.
4194
4195         Fixed incorrect constants. NSTimeInterval is in seconds, original numbers
4196         were nanoseconds and typedefed to long without regard to the type
4197         differences. Redid constants to be the right value, and converted upon use.
4198
4199         Cleaned up unused enum types.
4200
4201         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4202         (WTR::UIScriptController::longPressAtPoint):
4203         (WTR::UIScriptController::forcePressAtPoint):
4204         (WTR::UIScriptController::dragFromPointToPoint): Deleted.
4205         * Scripts/webkitpy/common/config/contributors.json:
4206         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4207         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4208         (WTR::UIScriptController::longPressAtPoint):
4209         (WTR::UIScriptController::forcePressAtPoint):
4210         (WTR::UIScriptController::dragFromPointToPoint): Deleted.
4211         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4212         * WebKitTestRunner/ios/HIDEventGenerator.h:
4213         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4214         (-[HIDEventGenerator _createIOHIDEventType:]):
4215         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
4216         (-[HIDEventGenerator clearTap:]):
4217         (-[HIDEventGenerator longPressTimerCall:]):
4218         (-[HIDEventGenerator longPressFinish:completionBlock:]):
4219         (-[HIDEventGenerator longPress:completionBlock:]):
4220         (-[HIDEventGenerator forcePress:completionBlock:]):
4221         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4222         (WTR::UIScriptController::longPressAtPoint):
4223         (WTR::UIScriptController::forcePressAtPoint):
4224         (WTR::UIScriptController::dragFromPointToPoint): Deleted.
4225
4226 2016-09-22  Jonathan Bedard  <jbedard@apple.com>
4227
4228         Automatic Text Replacement Testing in WebKit2
4229         https://bugs.webkit.org/show_bug.cgi?id=161919
4230
4231         Reviewed by Ryosuke Niwa.
4232
4233         Implemented test hooks for text replacement for WebKit2.
4234         Note that spell checking has not been implemented, so most tests which use text replacement still fail.
4235
4236         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Removed setAutomaticLinkDetectionEnabled from TestRunner, moved to Internals.
4237         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
4238         (WTR::InjectedBundle::beginTesting): Ditto.
4239         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
4240         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
4241         * WebKitTestRunner/TestController.cpp:
4242         (WTR::TestController::runTest): Place TextChecker into testing mode.
4243
4244 2016-09-21  Dan Bernstein  <mitz@apple.com>
4245
4246         [macOS] Upon layout, _webView:renderingProgressDidChange: fires before the intrinsic content size is updated
4247         https://bugs.webkit.org/show_bug.cgi?id=162359
4248         <rdar://problem/27776454>
4249
4250         Reviewed by Tim Horton.
4251
4252         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
4253         (TEST):
4254
4255 2016-09-21  Keith Miller  <keith_miller@apple.com>
4256
4257         Fix build for future versions of Clang.
4258         https://bugs.webkit.org/show_bug.cgi?id=162346
4259
4260         Reviewed by Filip Pizlo.
4261
4262         * TestWebKitAPI/Counters.cpp:
4263         * TestWebKitAPI/Counters.h:
4264         (DeleterCounter::deleterCount):
4265         (DeleterCounter::TestingScope::TestingScope):
4266         (DeleterCounter::operator()):
4267         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
4268         (TestWebKitAPI::TEST):
4269         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4270         (TestWebKitAPI::TEST):
4271
4272 2016-09-21  Commit Queue  <commit-queue@webkit.org>
4273
4274         Unreviewed, rolling out r206222 and r206227.
4275         https://bugs.webkit.org/show_bug.cgi?id=162361
4276
4277         "broke the windows build" (Requested by keith_mi_ on #webkit).
4278
4279         Reverted changesets:
4280
4281         "Fix build for future versions of Clang."
4282         https://bugs.webkit.org/show_bug.cgi?id=162346
4283         http://trac.webkit.org/changeset/206222
4284
4285         "Attempt to fix windows build after r206222."
4286         http://trac.webkit.org/changeset/206227
4287
4288 2016-09-21  Alex Christensen  <achristensen@webkit.org>
4289
4290         URLParser should match URL::parse when parsing data urls with slashes in them
4291         https://bugs.webkit.org/show_bug.cgi?id=162352
4292
4293         Reviewed by Darin Adler.
4294
4295         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4296         (TestWebKitAPI::TEST_F):
4297
4298 2016-09-21  Alex Christensen  <achristensen@webkit.org>
4299
4300         URLParser should fail when parsing invalid relative URLs with no schemes
4301         https://bugs.webkit.org/show_bug.cgi?id=162355
4302
4303         Reviewed by Tim Horton.
4304
4305         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
4306         (TestWebKitAPI::TEST_F):
4307
4308 2016-09-21  Keith Miller  <keith_miller@