BUILD FIX: Make AccessibilityUIElementIOS.mm build on iOS
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-12  David Kilzer  <ddkilzer@apple.com>
2
3         BUILD FIX: Make AccessibilityUIElementIOS.mm build on iOS
4
5         Reviewed by Chris Fleizach.
6
7         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Declare
8         -_accessibilityPath from the WebAccessibilityObjectWrapper
9         class.
10         (_CGPathEnumerationIteration): Remove unused CGPoint* variable.
11
12 2013-04-12  Jeffrey Pfau  <jpfau@apple.com>
13
14         Unreviewed, remove an old email address for myself.
15
16         * Scripts/webkitpy/common/config/committers.py:
17
18 2013-04-12  Adenilson Cavalcanti  <cavalcantii@gmail.com>
19
20         [WK2] WebPageProxy loadURL() won't work when called just after terminateProcess()
21         https://bugs.webkit.org/show_bug.cgi?id=110743
22
23         Reviewed by Benjamin Poulain.
24
25         Adding a new test file to check if loading a page just after WebProcess
26         has crashed (or was terminated) works. The test executes the
27         following steps (Load, Crash, Load), thus stressing WebProcess
28         reattach and process termination code path.
29
30         * TestWebKitAPI/GNUmakefile.am:
31         * TestWebKitAPI/PlatformEfl.cmake:
32         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
33         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
34         (TestWebKitAPI::setPageLoaderClient):
35         (TestWebKitAPI::TEST):
36         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Added.
37         (TestWebKitAPI):
38         (WebKit2CrashLoader):
39         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
40         (TestWebKitAPI::WebKit2CrashLoader::loadUrl):
41         (TestWebKitAPI::WebKit2CrashLoader::crashWebProcess):
42         (TestWebKitAPI::didFinishLoad):
43         (TestWebKitAPI::TEST):
44         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
45
46 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
47
48         [Mac] REGRESSION: Auto substitution strips new lines
49         https://bugs.webkit.org/show_bug.cgi?id=114537
50
51         Reviewed by Enrica Casucci.
52
53         Add a rule to replace "helloleworld" by "hello\nworld" for testing purpose.
54
55         * DumpRenderTree/mac/DumpRenderTree.mm:
56         (resetDefaultsToConsistentValues):
57
58 2013-04-09  Roger Fong  <roger_fong@apple.com>
59
60         Re-enable WinEWS tests.
61
62         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
63         (WinEWS):
64
65 2013-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
66
67         [GTK] Split GtkAuthenticationDialog in two widgets
68         https://bugs.webkit.org/show_bug.cgi?id=103644
69
70         Reviewed by Xan Lopez.
71
72         * gtk/generate-gtkdoc:
73         (get_webkit2_options): Do not generate api docs for
74         WebKitAuthenticationDialog which is private in WebKit2.
75         (get_webkit1_options): Do not generate api docs for
76         webkitauthenticationdialog which is private in WebKit1.
77
78 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
79
80         WebKit Queues should capitalize K in Wk2
81         https://bugs.webkit.org/show_bug.cgi?id=114524
82
83         Reviewed by Philippe Normand.
84
85         * QueueStatusServer/model/queues.py:
86         (Queue.display_name):
87
88 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
89
90         [Mac] Enable spellchecking tests added in r141471
91         https://bugs.webkit.org/show_bug.cgi?id=108525
92
93         Reviewed by Darin Adler.
94
95         * DumpRenderTree/mac/DumpRenderTree.mm:
96         (createWebViewAndOffscreenWindow):
97         (resetDefaultsToConsistentValues):
98         * WebKitTestRunner/TestController.cpp:
99         (WTR::TestController::resetStateToConsistentValues):
100
101 2013-04-12  Manuel Rego Casasnovas  <rego@igalia.com>
102
103         [GTK] Enable WebKit2 building on GTK EWSs
104         https://bugs.webkit.org/show_bug.cgi?id=114500
105
106         Reviewed by Philippe Normand.
107
108         Add configuration in order to be able to setup GTK EWSs building
109         WebKit2. A new queue gtk-wk2-ews is added.
110
111         * QueueStatusServer/config/queues.py:
112         * Scripts/webkitpy/common/config/ports.py:
113         (DeprecatedPort.port):
114         (GtkWK2Port):
115         (GtkWK2Port.build_webkit_command):
116         (GtkWK2Port.run_webkit_tests_command):
117         * Scripts/webkitpy/common/config/ports_unittest.py:
118         (DeprecatedPortTest.test_gtk_port):
119         (DeprecatedPortTest):
120         (DeprecatedPortTest.test_gtk_wk2_port):
121         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
122         (GtkWK2EWS):
123
124 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
125
126         Remove Chromium scripts
127         https://bugs.webkit.org/show_bug.cgi?id=114492
128
129         Reviewed by Benjamin Poulain.
130
131         * Scripts/run-chromium-webkit-unit-tests: Removed.
132         * Scripts/update-webkit-chromium: Removed.
133
134 2013-04-12  Commit Queue  <rniwa@webkit.org>
135
136         Unreviewed, rolling out r148262.
137         http://trac.webkit.org/changeset/148262
138         https://bugs.webkit.org/show_bug.cgi?id=114493
139
140         Cairo dep should now build, rolling r148247 back in (Requested
141         by zdobersek on #webkit).
142
143         * Scripts/webkitdirs.pm:
144         (buildAutotoolsProject):
145         * gtk/jhbuild.modules:
146
147 2013-04-11  Commit Queue  <rniwa@webkit.org>
148
149         Unreviewed, rolling out r148247.
150         http://trac.webkit.org/changeset/148247
151         https://bugs.webkit.org/show_bug.cgi?id=114490
152
153         Cairo dep fails to build on builders due to missing EGL
154         headers (Requested by zdobersek on #webkit).
155
156         * Scripts/webkitdirs.pm:
157         (buildAutotoolsProject):
158         * gtk/jhbuild.modules:
159
160 2013-04-11  Martin Robinson  <mrobinson@igalia.com>
161
162         [GTK] Add accelerated 2D canvas support using cairo-gl
163         https://bugs.webkit.org/show_bug.cgi?id=104672
164
165         Reviewed by Alejandro G. Castro.
166
167         Since the value of ACCELERATED_2D_CANVAS relies on some somewhat unusual
168         dependencies, don't override value of the setting determined by configure.
169         This will make it easier for people using build-webkit, but not the
170         WebKit JHBuild.
171
172         * Scripts/webkitdirs.pm:
173         (buildAutotoolsProject): Add a blacklist for settings to never override.
174         * gtk/jhbuild.modules: Build CairoGL.
175
176 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
177
178         build.webkit.org should link to webkit-queues instead of webkit-commit-queue
179         https://bugs.webkit.org/show_bug.cgi?id=114477
180
181         Reviewed by Benjamin Poulain.
182
183         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
184
185 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
186
187         Leaks builder should not be triggered upon new commits
188         https://bugs.webkit.org/show_bug.cgi?id=114475
189
190         Reviewed by Jessie Berlin.
191
192         Don't trigger them on new checkins. Wait for Mountain Lion (Build), which already triggers
193         the leak builder when builds are done.
194
195         * BuildSlaveSupport/build.webkit.org-config/config.json:
196
197 2013-04-11  Kalev Lember  <kalevlember@gmail.com>
198
199         [GTK] Windows build failure after r136056
200         https://bugs.webkit.org/show_bug.cgi?id=114121
201
202         Reviewed by Martin Robinson.
203
204         * TestWebKitAPI/config.h: Make sure defines are correct for other
205         Windows ports than apple-win.
206
207 2013-04-11  Ojan Vafai  <ojan@chromium.org>
208
209         Remove myself from watchlists.
210         * Scripts/webkitpy/common/config/watchlist:
211
212 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
213
214         Build fix. Don't hard-code queues.webkit.org at least during the transition.
215
216         * QueueStatusServer/templates/statusbubble.html:
217
218 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
219
220         Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
221         https://bugs.webkit.org/show_bug.cgi?id=114397
222
223         Reviewed by Benjamin Poulain.
224
225         Reland the patch since Alan appears to have finished the migration.
226
227         * Scripts/webkitpy/common/net/statusserver.py:
228         (StatusServer):
229
230 2013-04-11  Brian Holt  <brian.holt@samsung.com>
231
232         [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
233         https://bugs.webkit.org/show_bug.cgi?id=76796
234
235         Reviewed by Chris Fleizach.
236
237         Make the Gtk window for the DRT a toplevel so that it gets the
238         focus from the window manager when the test starts.
239
240         * DumpRenderTree/gtk/DumpRenderTree.cpp:
241         (main):
242
243 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
244
245         Use CSS4 image-rendering to determing image scaling quality
246         https://bugs.webkit.org/show_bug.cgi?id=113405
247
248         Reviewed by Simon Fraser.
249
250         Introduce new flag to enable experimental support for CSS4 Images.
251
252         * Scripts/webkitperl/FeatureList.pm:
253
254 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
255
256         Remove code for Chromium from wkbuild.py
257         https://bugs.webkit.org/show_bug.cgi?id=114423
258
259         Reviewed by Benjamin Poulain.
260
261         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
262         (_should_file_trigger_build):
263         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
264         (ShouldBuildTest):
265
266 2013-04-11  Philippe Normand  <pnormand@igalia.com>
267
268         Unreviewed, update my IRC nickname.
269
270         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
271
272 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
273
274         Remove the rest of Chromium code from webkitpy
275         https://bugs.webkit.org/show_bug.cgi?id=114420
276
277         Reviewed by Benjamin Poulain.
278
279         * Scripts/webkitpy/common/config/urls.py:
280         (view_revision_url):
281         * Scripts/webkitpy/common/host.py:
282         (Host._engage_awesome_locale_hacks):
283         (Host.initialize_scm):
284         (Host):
285         * Scripts/webkitpy/common/host_mock.py:
286         (MockHost.__init__):
287         (MockHost.checkout):
288         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
289         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
290         (JSONResultsGeneratorBase._insert_generic_metadata):
291         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
292         (TestExpectationParser._tokenize_line):
293         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
294         (ExpectationSyntaxTests.test_bare_name_and_bugs):
295         (ExpectationSyntaxTests.test_warnings):
296         * Scripts/webkitpy/layout_tests/port/base.py:
297         (Port.skips_perf_test):
298         (Port.path_to_test_expectations_file):
299         (Port._port_flag_for_scripts):
300         * Scripts/webkitpy/style/checkers/cpp.py:
301         (check_function_definition):
302         (check_include_line):
303         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
304         (OrderOfIncludesTest.test_check_wtf_includes):
305         (WebKitStyleTest.test_webkit_export_check):
306         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
307         (TestExpectationsTestCase.test_valid_expectations):
308         * Scripts/webkitpy/tool/bot/irc_command.py:
309         (Rollout.execute):
310         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
311         (IRCCommandTest.test_whois):
312         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
313         (IRCBotTest.test_help):
314         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
315         (SheriffBotTest.test_command_aliases):
316
317 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
318
319         roll-chromium-deps doesn't roll DEPS
320         https://bugs.webkit.org/show_bug.cgi?id=114421
321
322         Reviewed by Antti Koivisto.
323
324         Roll DEPS. Rolling DEPS. Rolled DEPS.
325
326         * Scripts/webkitpy/tool/bot/irc_command.py:
327         (RollChromiumDEPS.execute):
328
329 2013-04-11  Glenn Adams  <glenn@skynav.com>
330
331         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
332         https://bugs.webkit.org/show_bug.cgi?id=114418
333
334         Reviewed by Ryosuke Niwa.
335
336         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
337         (MockSCM.add): Remove optional remove_exit_code argument.
338         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
339         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
340         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
341         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
342
343 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
344
345         Fix roll-chromium-deps and hi.
346
347         * Scripts/webkitpy/tool/bot/irc_command.py:
348         (Hi.execute):
349         (RollChromiumDEPS.execute):
350
351 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
352
353         Remove webkitpy code to roll Chromium DEPS
354         https://bugs.webkit.org/show_bug.cgi?id=114415
355
356         Reviewed by Benjamin Poulain.
357
358         Removed the code to roll Chromium DEPS in WebKit.
359
360         * Scripts/webkitpy/common/checkout/checkout.py:
361         (Checkout.bug_id_for_this_commit):
362         * Scripts/webkitpy/common/checkout/checkout_mock.py:
363         (MockCheckout.commit_message_for_this_commit):
364         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
365         (CheckoutTest.test_suggested_reviewers):
366         * Scripts/webkitpy/common/checkout/deps.py: Removed.
367         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
368         * Scripts/webkitpy/tool/bot/irc_command.py:
369         (RollChromiumDEPS): Teach webkitbot a sense of humor.
370         (RollChromiumDEPS.execute):
371         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
372         (IRCCommandTest.test_create_bug):
373         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
374         (IRCBotTest.test_revert):
375         * Scripts/webkitpy/tool/bot/sheriff.py:
376         (Sheriff.post_rollout_patch):
377         * Scripts/webkitpy/tool/commands/__init__.py:
378         * Scripts/webkitpy/tool/commands/roll.py: Removed.
379         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
380         * Scripts/webkitpy/tool/steps/__init__.py:
381         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
382         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
383         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
384
385 2013-04-11  Glenn Adams  <glenn@skynav.com>
386
387         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
388         https://bugs.webkit.org/show_bug.cgi?id=114386
389
390         Reviewed by Benjamin Poulain.
391
392         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
393         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
394         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
395         by default and to return exit code 1 if a file/dir had already been added.
396
397         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
398         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
399         * Scripts/webkitpy/common/checkout/scm/svn.py:
400         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
401
402 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
403
404         Unreviewed.
405
406         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
407
408 2013-04-10  Glenn Adams  <glenn@skynav.com>
409
410         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
411         https://bugs.webkit.org/show_bug.cgi?id=114410
412
413         Reviewed by Ryosuke Niwa.
414
415         * Scripts/webkitpy/common/checkout/scm/git.py:
416         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
417         * Scripts/webkitpy/common/checkout/scm/scm.py:
418         (SCM.add): Remove optional return_exit_code argument.
419         (SCM.add_list): Remove optional return_exit_code argument.
420         * Scripts/webkitpy/common/checkout/scm/svn.py:
421         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
422
423 2013-04-10  Eric Seidel  <eric@webkit.org>
424
425         Remove myself from the watchlists, I'm getting too much bug mail. :)
426
427         * Scripts/webkitpy/common/config/watchlist:
428
429 2013-04-10  Commit Queue  <rniwa@webkit.org>
430
431         Unreviewed, rolling out r148158.
432         http://trac.webkit.org/changeset/148158
433         https://bugs.webkit.org/show_bug.cgi?id=114405
434
435         We need to migrate status data (Requested by rniwa on
436         #webkit).
437
438         * Scripts/webkitpy/common/net/statusserver.py:
439         (StatusServer):
440
441 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
442
443         Mass remove all the empty directories
444
445         Rubberstamped by Ryosuke Niwa.
446
447         * BuildSlaveSupport/gtk/crashmon/log: Removed.
448         * BuildSlaveSupport/gtk/xvfb/log: Removed.
449         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
450         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
451         * MiniBrowser/gtk/WebBundle: Removed.
452         * MiniBrowser/win: Removed.
453         * QtTestPlatformPlugin/mac: Removed.
454         * Scripts/webkitpy/tool/bot/testdata: Removed.
455         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
456         * efl/ImageDiff: Removed.
457         * iExploder/htdocs: Removed.
458         * iExploder/iexploder-1.7.2/output: Removed.
459         * iExploder/tools: Removed.
460         * qmake/config.tests/libexecdir: Removed.
461         * qmake/config.tests/libjpeg: Removed.
462         * qmake/config.tests/libpng: Removed.
463
464 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
465
466         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
467         https://bugs.webkit.org/show_bug.cgi?id=114397
468
469         Reviewed by Benjamin Poulain.
470
471         * Scripts/webkitpy/common/net/statusserver.py:
472         (StatusServer):
473
474 2013-04-10  Adam Barth  <abarth@webkit.org>
475
476         Remove abarth from watchlists
477         https://bugs.webkit.org/show_bug.cgi?id=114390
478
479         Reviewed by Ryosuke Niwa.
480
481         I'm trying to cut down on the amount of bugmail I get so that I'll have
482         more of a chance to notice a piece of bugmail directed at me.
483
484         * Scripts/webkitpy/common/config/watchlist:
485
486 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
487
488         webkit-test-results.appspot.com loads the dashboard for Chromium by default
489         https://bugs.webkit.org/show_bug.cgi?id=114381
490
491         Reviewed by Benjamin Poulain.
492
493         Changed the defaults.
494
495         * TestResultServer/static-dashboards/builders.js:
496         * TestResultServer/static-dashboards/dashboard_base.js:
497         (currentBuilderGroupCategory):
498
499 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
500
501         Remove Chromium EWS bots from the queue status server
502         https://bugs.webkit.org/show_bug.cgi?id=113988
503
504         Reviewed by Benjamin Poulain.
505
506         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
507
508         * QueueStatusServer/app.yaml:
509         * QueueStatusServer/config/queues.py:
510         * QueueStatusServer/model/queues.py:
511         (Queue.short_name):
512         (Queue.display_name):
513         * QueueStatusServer/model/queues_unittest.py:
514         (QueueTest.test_short_name):
515         (QueueTest.test_display_name):
516         (QueueTest.test_name_with_underscores):
517         * QueueStatusServer/templates/activebots.html:
518
519 2013-04-10  Ojan Vafai  <ojan@chromium.org>
520
521         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
522         https://bugs.webkit.org/show_bug.cgi?id=114370
523
524         Reviewed by Ryosuke Niwa.
525
526         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
527         Unfortunately, there's no way to test this until this is committed and there is
528         a master restart.
529
530         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
531         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
532         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
533         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
534         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
535         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
536         * TestResultServer/generate_builders_json.py:
537         * TestResultServer/static-dashboards/dashboard_base.js:
538         * TestResultServer/static-dashboards/loader.js:
539
540 2013-04-10  Glenn Adams  <glenn@skynav.com>
541
542         [Qt] Fix regression to test-webkitpy.
543         https://bugs.webkit.org/show_bug.cgi?id=114368
544
545         Reviewed by Ryosuke Niwa.
546
547         * Scripts/webkitpy/layout_tests/port/factory.py:
548         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
549         (PortFactory.get): Remove obsolete chromium port related code.
550         * Scripts/webkitpy/layout_tests/port/mac.py:
551         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
552
553 2013-04-10  Anders Carlsson  <andersca@apple.com>
554
555         Remove unneeded headers from FrameLoader.h
556         https://bugs.webkit.org/show_bug.cgi?id=114223
557
558         Reviewed by Geoffrey Garen.
559
560         Add back headers implicitly included by other headers.
561
562         * WebKitTestRunner/WorkQueueManager.cpp:
563
564 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
565
566         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
567         https://bugs.webkit.org/show_bug.cgi?id=114365
568
569         Reviewed by Martin Robinson.
570
571         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
572         The patch addresses crashes in the tally_event_reply method. It is already committed into the
573         at-spi2-atk source tree and will be available with the next stable release, after which the
574         patch should be removed and the dependency version bumped.
575
576         * gtk/jhbuild.modules:
577         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
578
579 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
580
581         [WinCairo] Unreviewed build fix. Correct DropBox download link.
582
583         * Scripts/update-webkit-wincairo-libs: Revise download URL to
584         match change in DropBox server behavior.
585
586 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
587
588         Removed an annoying message from svn-create-patch
589         https://bugs.webkit.org/show_bug.cgi?id=114332
590
591         Reviewed by Alexey Proskuryakov.
592
593         I see this message basically every time I write a patch, so it must not
594         be true.
595
596         * Scripts/svn-create-patch:
597         (generateDiff):
598
599 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
600
601         [GTK] Add support for Page Visibility
602         https://bugs.webkit.org/show_bug.cgi?id=97324
603
604         Reviewed by Sam Weinig.
605
606         Implemented test runner API for page visibility layout tests.
607
608         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
609         (TestRunner::resetPageVisibility):
610         (TestRunner::setPageVisibility):
611         * Scripts/webkitperl/FeatureList.pm:
612
613 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
614
615         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
616         https://bugs.webkit.org/show_bug.cgi?id=114342
617
618         Reviewed by Gyuyoung Kim.
619
620         Commit 148033 only added an implementation for the Mac port, which made
621         other ports fail most tests since loading the injected bundle failed
622         with a missing symbol.
623
624         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
625         (WTR::AccessibilityUIElement::pathDescription):
626
627 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
628
629         [EFL] Add spell checking option to MiniBrowser
630         https://bugs.webkit.org/show_bug.cgi?id=114282
631
632         Reviewed by Ryosuke Niwa.
633
634         Spell checking is enabled by adding a flag (t/text-checking)
635         with launching MiniBrowser.
636
637         * MiniBrowser/efl/main.c:
638         (window_create):
639         (elm_main):
640
641 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
642
643         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
644         https://bugs.webkit.org/show_bug.cgi?id=113281
645
646         Reviewed by Darin Adler.
647
648         * Scripts/run-gtk-tests:
649         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
650
651 2013-04-09  Glenn Adams  <glenn@skynav.com>
652
653         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
654
655         Unreviewed.
656
657         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
658         (RunTest.test_build_check):
659
660 2013-04-09  Glenn Adams  <glenn@skynav.com>
661
662         [webkitpy] Remove chromium ports.
663         https://bugs.webkit.org/show_bug.cgi?id=114326
664
665         Reviewed by Dirk Pranke.
666
667         As a side effect, also:
668
669         - remove chromium builders from webkitpy.layout_tests.port.builders
670         - remove chromium builders from rebaseline
671         - rewrite chromium dependent tests in rebaseline_unittest
672         - remove chromium platform from garden-o-matic
673         - select apple platform as default platform in garden-o-matic
674         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
675
676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
677         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
678         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
679         (BaselineOptimizerTest.test_move_baselines):
680         (BaselineOptimizerTest.test_efl):
681         (BaselineOptimizerTest.test_no_add_mac_future):
682         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
683         (BaselineOptimizerTest.test_common_directory_includes_root):
684         (BaselineOptimizerTest.test_complex_shadowing):
685         (BaselineOptimizerTest.test_virtual_ports_filtered):
686         * Scripts/webkitpy/layout_tests/port/builders.py:
687         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
688         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
689         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
690         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
691         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
692         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
693         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
694         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
695         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
696         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
697         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
698         * Scripts/webkitpy/layout_tests/port/factory.py:
699         (platform_options):
700         (PortFactory):
701         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
702         (FactoryTest.test_qt):
703         (FactoryTest.test_get_from_builder_name):
704         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
705         (RunTest.test_build_check):
706         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
707         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
708         * Scripts/webkitpy/tool/commands/rebaseline.py:
709         (Rebaseline._builders_to_pull_from):
710         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
711         (_BaseTestCase):
712         (_BaseTestCase.setUp):
713         (TestRebaselineTest.setUp):
714         (TestRebaselineTest.test_baseline_directory):
715         (test_rebaseline_updates_expectations_file):
716         (test_rebaseline_does_not_include_overrides):
717         (test_rebaseline_test):
718         (test_rebaseline_test_and_print_scm_changes):
719         (test_rebaseline_and_copy_test):
720         (test_rebaseline_and_copy_test_no_existing_result):
721         (test_rebaseline_and_copy_test_with_lion_result):
722         (test_rebaseline_and_copy_no_overwrite_test):
723         (TestRebaselineExpectations.test_rebaseline_expectations):
724
725 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
726
727         newcommitbot (WKR) requires a subversion checkout
728         https://bugs.webkit.org/show_bug.cgi?id=114309
729
730         Reviewed by Benjamin Poulain.
731
732         Directly talk to the subversion server instead of relying on a local checkout.
733         This allows us to run WKR off of a git clone.
734
735         * Scripts/webkitpy/tool/commands/newcommitbot.py:
736         (NewCommitBot.next_work_item):
737         (NewCommitBot.process_work_item):
738
739 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
740
741         webkitbot refers to sheriffbot in help
742         https://bugs.webkit.org/show_bug.cgi?id=114307
743
744         Reviewed by Benjamin Poulain.
745
746         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
747
748         * Scripts/webkitpy/tool/bot/irc_command.py:
749         (Help):
750         (Help.execute):
751         (RollChromiumDEPS.execute):
752         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
753         (IRCBotTest.test_help):
754         * Scripts/webkitpy/tool/bot/sheriff.py:
755         (Sheriff.name):
756
757 2013-04-06  Roger Fong  <roger_fong@apple.com>
758
759         Kill old processes between runs on WinEWS bots.
760         Temporarily disable tests to let bots catch up again.
761
762         * EWSTools/start-queue-win.sh:
763         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
764         (WinEWS):
765
766 2013-04-09  Glenn Adams  <glenn@skynav.com>
767
768         [webkitpy] Remove chromium deprecated port support.
769         https://bugs.webkit.org/show_bug.cgi?id=114228
770
771         Reviewed by Ryosuke Niwa.
772
773         * Scripts/webkitpy/common/config/ports.py:
774         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
775         (ChromiumPort): Removed.
776         (ChromiumAndroidPort): Removed.
777         (ChromiumXVFBPort): Removed.
778         * Scripts/webkitpy/common/config/ports_unittest.py:
779         (DeprecatedPortTest.test_chromium_port): Removed.
780         (DeprecatedPortTest.test_chromium_android_port): Removed.
781         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
782         * Scripts/webkitpy/tool/steps/update_unittest.py:
783         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
784         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
785
786 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
787
788         AX: The bounding paths should be made available through accessibility
789         https://bugs.webkit.org/show_bug.cgi?id=113817
790
791         Reviewed by David Kilzer.
792
793         Add a pathDescription property for testing so that it's possible
794         to verify that a path is being returned correctly.
795
796         * DumpRenderTree/AccessibilityUIElement.cpp:
797         (getPathDescriptionCallback):
798         (AccessibilityUIElement::pathDescription):
799         (AccessibilityUIElement::getJSClass):
800         * DumpRenderTree/AccessibilityUIElement.h:
801         (AccessibilityUIElement):
802         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
803         (_CGPathEnumerationIteration):
804         (AccessibilityUIElement::pathDescription):
805         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
806         (AccessibilityUIElement::pathDescription):
807         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
808         (WTR::AccessibilityUIElement::pathDescription):
809         (WTR):
810         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
811         (AccessibilityUIElement):
812         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
813         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
814         (WTR::AccessibilityUIElement::pathDescription):
815         (WTR):
816
817 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
818
819         [EFL] Declare TEST_THEME_DIR in a single place.
820         https://bugs.webkit.org/show_bug.cgi?id=114285
821
822         Reviewed by Anders Carlsson.
823
824         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
825
826         * DumpRenderTree/efl/CMakeLists.txt:
827         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
828         (DumpRenderTreeChrome::createView):
829         (DumpRenderTreeChrome::createInspectorView):
830         (DumpRenderTreeChrome::initialize):
831         (DumpRenderTreeChrome::onDownloadRequest):
832         * EWebLauncher/CMakeLists.txt:
833         * EWebLauncher/main.c:
834         (findThemePath):
835         * EWebLauncher/url_bar.c:
836         (url_bar_add):
837         * MiniBrowser/efl/CMakeLists.txt:
838         * MiniBrowser/efl/main.c:
839         (window_create):
840         * TestWebKitAPI/PlatformEfl.cmake:
841         * TestWebKitAPI/efl/PlatformWebView.cpp:
842         (TestWebKitAPI::PlatformWebView::PlatformWebView):
843         * WebKitTestRunner/PlatformEfl.cmake:
844         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
845         (WTR::PlatformWebView::PlatformWebView):
846
847 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
848
849         [GTK][AC] upversion of clutter and its dependecy
850         https://bugs.webkit.org/show_bug.cgi?id=114016
851
852         Reviewed by Gustavo Noronha Silva.
853
854         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
855
856         * gtk/jhbuild-optional.modules:
857
858 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
859
860         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
861         https://bugs.webkit.org/show_bug.cgi?id=89875
862
863         Reviewed by Maciej Stachowiak.
864
865         Add unit tests to verify if the handling of the open, openat, creat syscall
866         is being done right. We check if the Read/Write/ReadAndWrite permissions
867         are respected, if the canonical path is being resolved and if
868         the permissions are falling back to the topmost parent directory with a
869         policy set when the directory being opened has no policy.
870
871         We also test if any attempt of blocking SIGSYS is silently ignored.
872         SIGSYS cannot be blocked because in it's handler is where we hook
873         syscalls to the broker process.
874
875         Also added libseccomp to EFL's jhbuild to make the life of developers
876         willing to help easier.
877
878         * Scripts/webkitperl/FeatureList.pm:
879         * TestWebKitAPI/PlatformEfl.cmake:
880         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
881         (TestWebKitAPI):
882         (SeccompEnvironment):
883         (TestWebKitAPI::SeccompEnvironment::SetUp):
884         (TestWebKitAPI::SeccompEnvironment::TearDown):
885         (TestWebKitAPI::dummyHandler):
886         (TestWebKitAPI::TEST):
887         (TestWebKitAPI::stressTest):
888         * efl/jhbuild.modules:
889         * qmake/mkspecs/features/features.pri:
890
891 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
892
893         REGRESSION: Autocorrection doesn't work in DumpRenderTree
894         https://bugs.webkit.org/show_bug.cgi?id=113846
895
896         Reviewed by Alexey Proskuryakov.
897
898         The problem was that we were replacing NSSpellCheck's dictionary with our own
899         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
900
901         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
902         and "would" respectively in DumpRenderTree.
903
904         * DumpRenderTree/mac/DumpRenderTree.mm:
905         (resetDefaultsToConsistentValues):
906
907 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
908
909         Remove the gyp files for Tools
910         https://bugs.webkit.org/show_bug.cgi?id=114248
911
912         Reviewed by Ryosuke Niwa.
913
914         * DumpRenderTree/DumpRenderTree.gyp: Removed.
915         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
916         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
917         * DumpRenderTree/DumpRenderTree.gypi: Removed.
918         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
919         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
920         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
921         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
922
923 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
924
925         WKR (new-commit-bot) is too slow
926         https://bugs.webkit.org/show_bug.cgi?id=110087
927
928         Reviewed by Geoffrey Garen.
929
930         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
931         Just run "svn log -r <revision>" instead to cut down the delay.
932
933         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
934
935         * Scripts/webkitpy/tool/commands/newcommitbot.py:
936         (NewCommitBot):
937         (NewCommitBot.next_work_item):
938         (NewCommitBot._is_empty_log):
939         (NewCommitBot._update_checkout):
940
941 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
942
943         Build fix. Can't remove appendCustomBuildFlags.
944
945         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
946         (appendCustomBuildFlags):
947
948 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
949
950         Remove Chromium builders from build.webkit.org
951         https://bugs.webkit.org/show_bug.cgi?id=113990
952
953         Reviewed by Benjamin Poulain.
954
955         Removed.
956
957         * BuildSlaveSupport/build.webkit.org-config/config.json:
958         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
959         (InstallGtkDependencies):
960         (RunUnitTests.start):
961         (RunWebKit2Tests.start):
962         (Factory.__init__):
963         (unitTestsSupported):
964         (TestFactory.__init__):
965         (BuildAndTestFactory.__init__):
966         (BuildAndPerfTestFactory.__init__):
967         (BuildAndPerfTestWebKit2Factory.__init__):
968         (DownloadAndPerfTestFactory.__init__):
969         (loadBuilderConfig):
970         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
971
972 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
973
974         Remove HTML Notification
975         https://bugs.webkit.org/show_bug.cgi?id=114231
976
977         Reviewed by Ryosuke Niwa.
978
979         * qmake/mkspecs/features/features.pri:
980
981 2013-04-08  Glenn Adams  <glenn@skynav.com>
982
983         Remove chromium EWS support, and fix broken test.
984         https://bugs.webkit.org/show_bug.cgi?id=114221
985
986         Reviewed by Ryosuke Niwa.
987
988         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
989         (AbstractChromiumEWS): Removed.
990         (ChromiumLinuxEWS): Removed.
991         (ChromiumLinuxDebugEWS): Removed.
992         (ChromiumWindowsEWS): Removed.
993         (ChromiumAndroidEWS): Removed.
994         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
995         (EarlyWarningSystemTest): Fix misspelled class name.
996         (test_ewses): Fix entry point name to ensure test is run.
997
998 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
999
1000         [WIN] Remove WebKit2 source code
1001         https://bugs.webkit.org/show_bug.cgi?id=114096
1002
1003         Reviewed by Anders Carlsson.
1004
1005         Remove the windows specific parts of the MiniBrowser.
1006
1007         * MiniBrowser/MiniBrowser.vcproj: Removed.
1008         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
1009         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
1010         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
1011         * MiniBrowser/win/BrowserView.cpp: Removed.
1012         * MiniBrowser/win/BrowserView.h: Removed.
1013         * MiniBrowser/win/BrowserWindow.cpp: Removed.
1014         * MiniBrowser/win/BrowserWindow.h: Removed.
1015         * MiniBrowser/win/MiniBrowser.cpp: Removed.
1016         * MiniBrowser/win/MiniBrowser.h: Removed.
1017         * MiniBrowser/win/MiniBrowser.rc: Removed.
1018         * MiniBrowser/win/main.cpp: Removed.
1019         * MiniBrowser/win/resource.h: Removed.
1020         * MiniBrowser/win/stdafx.cpp: Removed.
1021         * MiniBrowser/win/stdafx.h: Removed.
1022
1023 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1024
1025         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
1026
1027         * Scripts/webkitpy/common/config/irc.py:
1028
1029 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
1030
1031         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
1032         https://bugs.webkit.org/show_bug.cgi?id=113139
1033
1034         Reviewed by Anders Carlsson.
1035
1036         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1037         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
1038         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1039         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
1040         (ToStringAndValueOfObject):
1041         (ToStringAndValueOfObject::ToStringAndValueOfObject):
1042         (ScriptableObject):
1043         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
1044         (ToStringAndValueOfObject::ScriptableObject::invoke):
1045         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
1046         (ToStringAndValueOfObject::NPP_GetValue):
1047         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1048         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1049         * GNUmakefile.am:
1050
1051 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
1052
1053         [GTK] Bump gnome-themes-standard to 3.6.0
1054         https://bugs.webkit.org/show_bug.cgi?id=114155
1055
1056         Reviewed by Martin Robinson.
1057
1058         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
1059         dependency of gnome-themes-standard accordingly.
1060
1061 2013-04-08  David Levin  <levin@chromium.org>
1062
1063         Remove my watchlist entries.
1064         https://bugs.webkit.org/show_bug.cgi?id=114180
1065
1066         Reviewed by Adam Barth.
1067
1068         * Scripts/webkitpy/common/config/committers.py:
1069         * Scripts/webkitpy/common/config/watchlist:
1070
1071 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1072
1073         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
1074         https://bugs.webkit.org/show_bug.cgi?id=114161
1075
1076         Reviewed by Gyuyoung Kim.
1077
1078         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
1079         as it is crashing due to Bug 111074.
1080
1081         * TestWebKitAPI/PlatformEfl.cmake:
1082
1083 2013-04-07  David Kilzer  <ddkilzer@apple.com>
1084
1085         Remove the rest of SVG_DOM_OBJC_BINDINGS
1086         <http://webkit.org/b/114112>
1087
1088         Reviewed by Geoffrey Garen.
1089
1090         * Scripts/webkitperl/FeatureList.pm:
1091         - Remove --svg-dom-objc-bindings switch.
1092         * qmake/mkspecs/features/features.pri:
1093         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
1094
1095 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
1096
1097         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
1098         https://bugs.webkit.org/show_bug.cgi?id=114089
1099
1100         Reviewed by Chris Fleizach.
1101
1102         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
1103         * DumpRenderTree/AccessibilityController.cpp:
1104         * DumpRenderTree/AccessibilityUIElement.cpp:
1105         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1106         (DumpRenderTreeChrome::DumpRenderTreeChrome):
1107         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1108         (DumpRenderTreeChrome):
1109
1110 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
1111
1112         Build fix after r147857, remove remaining USE(JSC) guards.
1113
1114         Unreviewed.
1115
1116         * DumpRenderTree/config.h:
1117         * TestWebKitAPI/config.h:
1118         * WebKitTestRunner/config.h:
1119
1120 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1121
1122         Rename sheriffbot to webkitbot
1123         https://bugs.webkit.org/show_bug.cgi?id=114109
1124
1125         Reviewed by Benjamin Poulain.
1126
1127         Renamed since sheriffbot will be used in Blink.
1128
1129         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1130         (SheriffBot):
1131         (SheriffBot.begin_work_queue):
1132
1133 2013-04-06  Oliver Hunt  <oliver@apple.com>
1134
1135         Unify the many and varied stack trace mechanisms, and make the result sane.
1136         https://bugs.webkit.org/show_bug.cgi?id=114072
1137
1138         Reviewed by Filip Pizlo.
1139
1140         The commandline jsc executable no longer requires arguments, so
1141         I've made run-jsc work without them.
1142
1143         * Scripts/run-jsc:
1144
1145 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
1146
1147         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
1148         https://bugs.webkit.org/show_bug.cgi?id=114086
1149
1150         Reviewed by Tim Horton.
1151
1152         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
1153
1154 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
1155
1156         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
1157         https://bugs.webkit.org/show_bug.cgi?id=114083
1158
1159         Reviewed by Ryosuke Niwa.
1160
1161         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
1162         in TestWebKitAPI and WebKitTestRunner.
1163
1164         * TestWebKitAPI/config.h:
1165         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1166         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1167         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1168         (WTR::InjectedBundle::platformInitialize):
1169
1170 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
1171
1172         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
1173         https://bugs.webkit.org/show_bug.cgi?id=114094
1174
1175         Reviewed by Anders Carlsson.
1176
1177         * Scripts/run-jsc:
1178
1179 2013-04-05  Ojan Vafai  <ojan@chromium.org>
1180
1181         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
1182         https://bugs.webkit.org/show_bug.cgi?id=114080
1183
1184         Reviewed by Ryosuke Niwa.
1185
1186         This way, the WebKit and Blink dashboard code can change as appropriate without
1187         needing to consider the other project's needs. This still doesn't update the
1188         buildbots to upload to the new location, or the dashboard code to pull the
1189         results.json files from the new location, but it at least allows for changing the
1190         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
1191
1192         * TestResultServer/app.yaml:
1193
1194 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1195
1196         Re-enable testing on the commit queue
1197         https://bugs.webkit.org/show_bug.cgi?id=114078
1198
1199         Reviewed by Darin Adler.
1200
1201         Re-enabled the feature and the associated tests.
1202
1203         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1204         (CommitQueueTask.run):
1205         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1206         (CommitQueueTaskTest._run_through_task):
1207         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1208         (CommitQueueTest._mock_test_result):
1209
1210 2013-04-05  Oliver Hunt  <oliver@apple.com>
1211
1212         Unify the many and varied stack trace mechanisms, and make the result sane.
1213         https://bugs.webkit.org/show_bug.cgi?id=114072
1214
1215         Reviewed by Filip Pizlo.
1216
1217         The commandline jsc executable no longer requires arguments, so
1218         I've made run-jsc work without them.
1219
1220         * Scripts/run-jsc:
1221
1222 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1223
1224         AX: Make SVG Group containers accessible elements
1225         https://bugs.webkit.org/show_bug.cgi?id=113939
1226
1227         Reviewed by Simon Fraser.
1228
1229         Implement axController.elementAtPoint for iOS.
1230         Implement a correct version of clickPoint for iOS.
1231
1232         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1233         (AccessibilityController::elementAtPoint):
1234         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1235         (AccessibilityUIElement::clickPointX):
1236         (AccessibilityUIElement::clickPointY):
1237
1238 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1239
1240         Unreviewed, rolling out r147773 and r147774.
1241         http://trac.webkit.org/changeset/147773
1242         http://trac.webkit.org/changeset/147774
1243         https://bugs.webkit.org/show_bug.cgi?id=114056
1244
1245         Causing some exceptions on AppEngine I don't understand
1246         (Requested by rniwa on #webkit).
1247
1248         * QueueStatusServer/config/queues.py:
1249         * QueueStatusServer/model/queues.py:
1250         (Queue.short_name):
1251         (Queue.display_name):
1252         * QueueStatusServer/model/queues_unittest.py:
1253         (QueueTest.test_short_name):
1254         (QueueTest.test_display_name):
1255         (QueueTest.test_name_with_underscores):
1256
1257 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
1258
1259         Fixed run-bindings-tests by removing V8
1260         https://bugs.webkit.org/show_bug.cgi?id=114053
1261
1262         Reviewed by Benjamin Poulain.
1263
1264         * Scripts/run-bindings-tests:
1265         (main):
1266
1267 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1268
1269         Build fix.
1270
1271         * QueueStatusServer/model/queues.py:
1272         (Queue.short_name):
1273         (Queue.display_name):
1274
1275 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1276
1277         Remove Chromium EWS bots from the queue status server
1278         https://bugs.webkit.org/show_bug.cgi?id=113988
1279
1280         Reviewed by Benjamin Poulain.
1281
1282         Removed Chromium EWS bots.
1283
1284         * QueueStatusServer/config/queues.py:
1285         * QueueStatusServer/model/queues.py:
1286         (Queue.short_name):
1287         (Queue.display_name):
1288         * QueueStatusServer/model/queues_unittest.py:
1289         (QueueTest.test_short_name):
1290         (QueueTest.test_display_name):
1291         (QueueTest.test_name_with_underscores):
1292
1293 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1294
1295         [EFL] Enable indexed database
1296         https://bugs.webkit.org/show_bug.cgi?id=107248
1297
1298         Reviewed by Alexis Menard.
1299
1300         * Scripts/webkitperl/FeatureList.pm:
1301
1302 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
1303
1304         Remove vestiges of Chromium bits from watchlists.
1305         https://bugs.webkit.org/show_bug.cgi?id=114047
1306
1307         Reviewed by Ryosuke Niwa.
1308
1309         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
1310
1311 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1312
1313         Add James Craig to the contributors list.
1314
1315         * Scripts/webkitpy/common/config/committers.py:
1316
1317 2013-04-04  Kent Tamura  <tkent@chromium.org>
1318
1319         Remove ChromiumPublicApi pattern, and cc/message rules for it.
1320
1321         * Scripts/webkitpy/common/config/watchlist:
1322
1323 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1324
1325         Temporarily disable the Python unittests broken by the commit queue not running layout tests
1326         https://bugs.webkit.org/show_bug.cgi?id=113997
1327
1328         Reviewed by Ryosuke Niwa.
1329
1330         Disable the tests until Ryosuke gets the time and hardware to have
1331         a testing commit-queue.
1332
1333         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1334         (CommitQueueTaskTest):
1335         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1336         (CommitQueueTest):
1337
1338 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1339
1340         Remove Chromium builders from build.webkit.org
1341         https://bugs.webkit.org/show_bug.cgi?id=113990
1342
1343         Reviewed by Benjamin Poulain.
1344
1345         Land the part to disable triggering of Chromium builders first so that we may start
1346         deleting more Chromium code that breaks the update step.
1347
1348         * BuildSlaveSupport/build.webkit.org-config/config.json:
1349
1350 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1351
1352         Remove Chromium's DumpRenderTree
1353         https://bugs.webkit.org/show_bug.cgi?id=113989
1354
1355         Reviewed by Kent Tamura.
1356
1357         On second thought, let's not go to Camelot. It is a silly place.
1358
1359         * DumpRenderTree/mac/DumpRenderTree.mm:
1360         (resetDefaultsToConsistentValues):
1361
1362 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
1363
1364         Nixed the defunct chromium folder from DumpRenderTree
1365         https://bugs.webkit.org/show_bug.cgi?id=113993
1366
1367         Reviewed by Ryosuke Niwa.
1368
1369         * DumpRenderTree/chromium: Removed.
1370         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
1371         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
1372         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
1373         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
1374         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
1375         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
1376         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
1377         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
1378         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
1379         * DumpRenderTree/chromium/MockPlatform.h: Removed.
1380         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
1381         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
1382         * DumpRenderTree/chromium/Task.cpp: Removed.
1383         * DumpRenderTree/chromium/Task.h: Removed.
1384         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
1385         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
1386         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
1387         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
1388         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
1389         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
1390         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
1391         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1392         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1393         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1394         * DumpRenderTree/chromium/TestRunner: Removed.
1395         * DumpRenderTree/chromium/TestRunner/public: Removed.
1396         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
1397         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
1398         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
1399         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
1400         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
1401         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
1402         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
1403         * DumpRenderTree/chromium/TestRunner/src: Removed.
1404         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
1405         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
1406         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
1407         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
1408         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
1409         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
1410         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
1411         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
1412         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
1413         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
1414         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
1415         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
1416         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
1417         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
1418         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
1419         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
1420         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
1421         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
1422         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
1423         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
1424         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
1425         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
1426         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
1427         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
1428         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
1429         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
1430         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
1431         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
1432         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
1433         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
1434         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
1435         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
1436         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
1437         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
1438         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
1439         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
1440         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
1441         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
1442         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
1443         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
1444         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
1445         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
1446         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
1447         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
1448         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
1449         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
1450         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
1451         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
1452         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
1453         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
1454         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
1455         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
1456         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
1457         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
1458         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
1459         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
1460         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1461         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
1462         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
1463         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1464         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
1465         * DumpRenderTree/chromium/TestShell.cpp: Removed.
1466         * DumpRenderTree/chromium/TestShell.h: Removed.
1467         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1468         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
1469         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
1470         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1471         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
1472         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
1473         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
1474         * DumpRenderTree/chromium/WebViewHost.h: Removed.
1475         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
1476         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
1477         * DumpRenderTree/chromium/config.h: Removed.
1478         * DumpRenderTree/chromium/fonts.conf: Removed.
1479
1480 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1481
1482         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
1483
1484         Rubber stamped by Benjamin Poulain.
1485
1486         * RebaselineQueueServer: Removed.
1487         * RebaselineQueueServer/app.yaml: Removed.
1488         * RebaselineQueueServer/handlers: Removed.
1489         * RebaselineQueueServer/handlers/__init__.py: Removed.
1490         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
1491         * RebaselineQueueServer/handlers/pages.py: Removed.
1492         * RebaselineQueueServer/index.yaml: Removed.
1493         * RebaselineQueueServer/main.py: Removed.
1494         * RebaselineQueueServer/model: Removed.
1495         * RebaselineQueueServer/model/__init__.py: Removed.
1496         * RebaselineQueueServer/model/queueentry.py: Removed.
1497         * RebaselineQueueServer/static: Removed.
1498         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
1499         * RebaselineQueueServer/static/styles.css: Removed.
1500         * RebaselineQueueServer/templates: Removed.
1501         * RebaselineQueueServer/templates/builder-picker.html: Removed.
1502         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
1503         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
1504         * RebaselineQueueServer/templates/home.html: Removed.
1505
1506 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1507
1508         Fix setup-commit-queue and temporarily disable testing on commit-queue
1509         https://bugs.webkit.org/show_bug.cgi?id=113979
1510
1511         Reviewed by Benjamin Poulain.
1512
1513         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
1514         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
1515
1516         * EWSTools/setup-commit-queue.sh:
1517         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1518         (CommitQueueTask.run):
1519
1520 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1521
1522         temporarily make flakiness dashboard work again webkit.org bots
1523         https://bugs.webkit.org/show_bug.cgi?id=113972
1524
1525         Reviewed by Ojan Vafai.
1526
1527         This patch disables the chromium.org layout test bots TestExpectations
1528         parsing temporarily until we can work out the right way to split into
1529         two instances for webkit.org and chromium.org and figure out which
1530         code to delete where :).
1531
1532         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1533
1534 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1535
1536         Fix webkitpy tests after r147678.
1537
1538         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1539         (CommitQueueTest.test_commit_queue):
1540         (test_manual_reject_during_processing):
1541
1542 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1543
1544         The commit queue should use Mac MountainLion port
1545         https://bugs.webkit.org/show_bug.cgi?id=113971
1546
1547         Reviewed by Lucas Forschler.
1548
1549         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1550         * Scripts/webkitpy/tool/commands/queues.py:
1551         (CommitQueue):
1552
1553 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1554
1555         turn off running tests on chromium linux EWS bots
1556         https://bugs.webkit.org/show_bug.cgi?id=113959
1557
1558         Reviewed by Geoffrey Garen.
1559
1560         Now that the Chromium port is no longer being maintained
1561         there's little point in running the tests. Soon we should
1562         just shut this bot off altogether.
1563
1564         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1565         (ChromiumLinuxEWS):
1566
1567 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1568
1569         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1570
1571         * Scripts/webkitpy/common/config/watchlist:
1572
1573 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1574
1575         Indentation fix to get webkit-patch working again after r147625
1576
1577         Unreviewed.
1578
1579         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1580         (MacEWS):
1581         (MacWK2EWS):
1582
1583 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1584
1585         Turn tests back on for Mac WK1/WK2 EWS.
1586         
1587         Unreviewed.
1588         
1589         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1590         (MacEWS):
1591         (MacWK2EWS):
1592
1593 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1594
1595         [GTK][WK2] MiniBrowser custom URI scheme support
1596         https://bugs.webkit.org/show_bug.cgi?id=112419
1597
1598         Reviewed by Carlos Garcia Campos.
1599
1600         Add support for about URIs in MiniBrowser. An example about page is show
1601         with URI "about:minibrowser", the rest of the cases it will show a
1602         proper message explaining that the about page didn't exist.
1603
1604         Internally it uses "minibrowser-about" prefix instead of "about", but
1605         from the user point of view it works with "about" prefix.
1606
1607         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1608         (getInternalURI): Method to convert URIs from "about" prefix to
1609         "minibrowser-about".
1610         (getExternalURI): Opposite method.
1611         (webViewURIChanged): Use "about" prefix to show the URI to users.
1612         (webViewEnterFullScreen): Ditto.
1613         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1614         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1615         (aboutURISchemeRequestCallback): Callback to manage about calls.
1616         (main): Register the URI scheme to manage about URIs.
1617
1618 2013-04-03  Roger Fong  <roger_fong@apple.com>
1619
1620         Re-enable WinEWS tests.
1621
1622         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1623         (WinEWS):
1624
1625 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1626
1627         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1628         https://bugs.webkit.org/show_bug.cgi?id=113883
1629
1630         Reviewed by Martin Robinson.
1631
1632         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1633         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1634         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1635
1636 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1637
1638         [GTK] Include Pango in jhbuild-optional.modules
1639         https://bugs.webkit.org/show_bug.cgi?id=113878
1640
1641         Reviewed by Martin Robinson.
1642
1643         Since r147547 Pango 1.32.0 is required. Including the module in the
1644         JHBuild optional moduleset.
1645
1646         * gtk/jhbuild-optional.modules: Add Pango module.
1647
1648 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1649
1650         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1651         https://bugs.webkit.org/show_bug.cgi?id=113864
1652
1653         Moving setDefersLoading from TestRunnerQt to TestRunner
1654         requires access to the non-Qt TestRunner.
1655         As long as we instantiate both TestRunner and TestRunnerQt,
1656         we need a separate getter for the non-Qt TestRunner instance.
1657
1658         Reviewed by Simon Hausmann.
1659
1660         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1661         (WebPage::resetSettings):
1662         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1663         (DumpRenderTree::jscTestRunner):
1664         * DumpRenderTree/qt/TestRunnerQt.cpp:
1665         (TestRunner::setDefersLoading):
1666             Moving setDefersLoading from TestRunnerQt
1667             to TestRunner.
1668         * DumpRenderTree/qt/TestRunnerQt.h:
1669         (TestRunnerQt):
1670
1671 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1672
1673         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1674         https://bugs.webkit.org/show_bug.cgi?id=104779
1675
1676         Reviewed by Carlos Garcia Campos.
1677
1678         * Scripts/run-gtk-tests:
1679         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1680         passing in current trunk.
1681
1682 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1683
1684         Fix HAVE(QTTESTSUPPORT) logic
1685
1686         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1687         resulting in HAVE(QTTESTSUPPORT) never being true.
1688         Move that logic down in sanitizeFeatures.
1689
1690         Rubber-stamped by Tor Arne Vestbø.
1691
1692         * qmake/mkspecs/features/features.prf:
1693
1694 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1695
1696         [GTK] Bump required versions of some dependencies
1697         https://bugs.webkit.org/show_bug.cgi?id=113282
1698
1699         Reviewed by Martin Robinson.
1700
1701         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1702
1703 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1704
1705         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1706         https://bugs.webkit.org/show_bug.cgi?id=113809
1707
1708         Reviewed by Philippe Normand.
1709
1710         Newer Linux kernels have removed some deprecated macros from v4l2
1711         headers, causing gst-plugins-good's build to break. We don't need it
1712         right now, so just disable it.
1713
1714         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1715
1716 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1717
1718         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1719         https://bugs.webkit.org/show_bug.cgi?id=113535
1720
1721         Reviewed by Simon Hausmann.
1722
1723         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1724
1725         * qmake/mkspecs/features/features.prf:
1726
1727 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1728
1729         [Qt] Move logic of simple forwarding functions to TestRunner.
1730         https://bugs.webkit.org/show_bug.cgi?id=113863
1731
1732         Reviewed by Simon Hausmann.
1733
1734         * DumpRenderTree/qt/TestRunnerQt.cpp:
1735         (TestRunner::setTextDirection):
1736         (TestRunner::goBack):
1737         (TestRunner::evaluateScriptInIsolatedWorld):
1738         (TestRunner::addUserStyleSheet):
1739         * DumpRenderTree/qt/TestRunnerQt.h:
1740         (TestRunnerQt):
1741
1742 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1743
1744         [Qt] Disable media support using QuickTime if deployment target != SDK
1745
1746         We link to a single libWebKitSystemInterface static lib, so unless the
1747         deployment target matches the SDK let's not pretend like we'll be able
1748         to run on anything lower than the SDK version.
1749
1750         Reviewed by Simon Hausmann.
1751
1752         * qmake/mkspecs/features/features.prf:
1753
1754 2013-04-02  James Craig  <james@cookiecrook.com>
1755
1756         AXRoleDescripton for DL is "list"; should be "description list"
1757         https://bugs.webkit.org/show_bug.cgi?id=111665
1758
1759         Reviewed by Chris Fleizach.
1760
1761         Defining the role and description strings.
1762
1763         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1764
1765 2013-04-02  Roger Fong  <roger_fong@apple.com>
1766
1767         Unreviewed. Disable running tests on Win EWS queue.
1768
1769         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1770         (WinEWS):
1771
1772 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1773
1774         Disable running tests on the MAC WK2 EWS queue.
1775         
1776         Unreviewed.
1777         
1778         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1779         (MacWK2EWS):
1780
1781 2013-04-02  Julie Parent  <jparent@chromium.org>
1782
1783         Dashboard refactor: Move dashboard specific history related features to History.
1784         https://bugs.webkit.org/show_bug.cgi?id=113717
1785
1786         Reviewed by Ojan Vafai.
1787         
1788         Each dashboard now creates its own History object, with a custom
1789         configuration. This changes from just overriding global functions
1790         to passing in callbacks for generatePage, handleValidHashParameter,
1791         and handleQueryParameterChange. Same with passing in defaultStateValues
1792         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1793         variables.
1794         
1795         All functions related to these features are now (mostly) private
1796         function on History. 
1797         
1798         Loader no longer needs a loadingComplete callback, since it can just
1799         initialize the history object itself.
1800
1801         * TestResultServer/static-dashboards/aggregate_results.js:
1802         (handleValidHashParameter):
1803         * TestResultServer/static-dashboards/dashboard_base.js:
1804         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1805         (generatePage):
1806         (.switch.return):
1807         (handleQueryParameterChange):
1808         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1809         (resetGlobals):
1810         * TestResultServer/static-dashboards/history.js:
1811         (.):
1812         * TestResultServer/static-dashboards/loader.js:
1813         (.):
1814         * TestResultServer/static-dashboards/loader_unittests.js:
1815         * TestResultServer/static-dashboards/timeline_explorer.js:
1816         (generatePage):
1817         (initCurrentBuilderTestResults):
1818         * TestResultServer/static-dashboards/treemap.js:
1819         (generatePage):
1820         (.switch.return):
1821         (handleQueryParameterChange):
1822
1823 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1824
1825         Unreviewed, rolling out r147401.
1826         http://trac.webkit.org/changeset/147401
1827         https://bugs.webkit.org/show_bug.cgi?id=113767
1828
1829         The patch makes it extremely hard to set up the dependencies
1830         properly on the GTK builders (Requested by zdobersek on
1831         #webkit).
1832
1833         * gtk/jhbuild.modules:
1834
1835 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1836
1837         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1838         https://bugs.webkit.org/show_bug.cgi?id=113382
1839
1840         Reviewed by Gyuyoung Kim.
1841
1842         Do not show the empty tooltip box if the text is null.
1843
1844         * MiniBrowser/efl/main.c:
1845         (popup_menu_populate):
1846
1847 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1848
1849         [GTK] Bump required versions of some dependencies
1850         https://bugs.webkit.org/show_bug.cgi?id=113282
1851
1852         Reviewed by Martin Robinson.
1853
1854         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1855
1856 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1857
1858         Unreviewed, rolling out r147319.
1859         http://trac.webkit.org/changeset/147319
1860         https://bugs.webkit.org/show_bug.cgi?id=113707
1861
1862         The unit test is still failing on the buildbot (Requested by
1863         zdobersek on #webkit).
1864
1865         * Scripts/run-gtk-tests:
1866         (TestRunner):
1867
1868 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1869
1870         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1871         https://bugs.webkit.org/show_bug.cgi?id=104779
1872
1873         Reviewed by Carlos Garcia Campos.
1874
1875         * Scripts/run-gtk-tests:
1876         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1877         passing in current trunk.
1878
1879 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1880
1881         Unreviewed, rolling out r147289.
1882         http://trac.webkit.org/changeset/147289
1883         https://bugs.webkit.org/show_bug.cgi?id=113678
1884
1885         broke Win7 (dbg) build (Requested by shinyak|gardener on
1886         #webkit).
1887
1888         * DumpRenderTree/DumpRenderTree.gypi:
1889         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1890         (WebTestRunner):
1891         (WebUserMediaClientMock):
1892         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1893         (WebTestRunner::WebUserMediaClientMock::taskList):
1894         * Scripts/webkitpy/style/checkers/cpp.py:
1895         (check_function_definition):
1896
1897 2013-03-31  Adam Barth  <abarth@webkit.org>
1898
1899         configure-svn-config.sh fails
1900         https://codereview.chromium.org/13392007/
1901
1902         Reviewed by Eric Seidel.
1903
1904         This script was trying to use "svn checkout" to dowload a file from
1905         svn.webkit.org, but "svn checkout" only works with directories.
1906         Instead, we should use "svn export".
1907
1908         * EWSTools/configure-svn-config.sh:
1909
1910 2013-03-31  Wei Jia  <wjia@chromium.org>
1911
1912         Allow WebUserMediaClientMock to be used by client
1913         https://bugs.webkit.org/show_bug.cgi?id=113633
1914
1915         Reviewed by Adam Barth.
1916
1917         Export WebUserMediaClientMock.
1918         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1919
1920         * DumpRenderTree/DumpRenderTree.gypi:
1921         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1922         (WebUserMediaClientMock):
1923         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1924         * Scripts/webkitpy/style/checkers/cpp.py:
1925         (check_function_definition):
1926
1927 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1928
1929         Expose FeatureObserver data to WebKit clients
1930         https://bugs.webkit.org/show_bug.cgi?id=113613
1931
1932         Reviewed by Sam Weinig.
1933
1934         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1935         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1936
1937 2013-03-29  Greg Hughes  <ghughes@apple.com>
1938
1939         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1940         https://bugs.webkit.org/show_bug.cgi?id=112276
1941
1942         Reviewed by Chris Fleizach.
1943
1944         Added support to test accessibility search predicates with multiple keys.  
1945
1946         * DumpRenderTree/AccessibilityUIElement.cpp:
1947         (uiElementForSearchPredicateCallback):
1948         * DumpRenderTree/AccessibilityUIElement.h:
1949         (AccessibilityUIElement):
1950         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1951         (AccessibilityUIElement::uiElementForSearchPredicate):
1952         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1953         (AccessibilityUIElement::uiElementForSearchPredicate):
1954         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1955         (AccessibilityUIElement::uiElementForSearchPredicate):
1956         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1957         (AccessibilityUIElement::uiElementForSearchPredicate):
1958         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1959         (AccessibilityUIElement::uiElementForSearchPredicate):
1960         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1961         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1962         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1963         (AccessibilityUIElement):
1964         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1965         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1966         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1967         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1968         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1969
1970 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1971
1972         Fix a typo in r147147 to fix Mac EWS.
1973
1974         * Scripts/webkitpy/tool/commands/queues.py:
1975         (PatchProcessingQueue._new_port_name_from_old):
1976
1977 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1978
1979         [EFL] Build break with latest EFL libraries after r146265
1980         https://bugs.webkit.org/show_bug.cgi?id=113558
1981
1982         Unreviewed build fix.
1983
1984         * TestWebKitAPI/PlatformWebView.h:
1985         * WebKitTestRunner/PlatformWebView.h:
1986
1987 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1988
1989         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1990
1991         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1992         in libgcrypt build.
1993
1994 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1995
1996         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1997
1998         Unreviewed.
1999
2000         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2001         (MacEWS):
2002
2003 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
2004
2005         Use the right OS name on Mac EWS instead of mac-future.
2006
2007         Rubber-stamped by Dirk Pranke.
2008
2009         * Scripts/webkitpy/tool/commands/queues.py:
2010         (PatchProcessingQueue._new_port_name_from_old):
2011         (PatchProcessingQueue.begin_work_queue):
2012         (PatchProcessingQueue._upload_results_archive_for_patch):
2013
2014 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
2015
2016         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
2017         https://bugs.webkit.org/show_bug.cgi?id=112546
2018
2019         Reviewed by Martin Robinson.
2020
2021         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
2022         moved back to Source/WebCore/platform. Fix an indentation issue as well.
2023
2024 2013-03-28  Ming Xie  <mxie@blackberry.com>
2025
2026         [BlackBerry] Committer Email Updates
2027         https://bugs.webkit.org/show_bug.cgi?id=113435
2028
2029         Reviewed by Rob Buis.
2030
2031         Add the @blackberry.com email address for all our BlackBerry
2032         WebKit committers. This is the first step for our email address
2033         migration.
2034
2035         * Scripts/webkitpy/common/config/committers.py:
2036
2037 2013-03-28  Philippe Normand  <pnormand@igalia.com>
2038
2039         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
2040         https://bugs.webkit.org/show_bug.cgi?id=113508
2041
2042         Reviewed by Martin Robinson.
2043
2044         Prevent the GStreamer plugin scanner to load system-wide
2045         plugins. Only the ones built in JHBuild should be loaded and used
2046         at runtime.
2047
2048         * efl/jhbuildrc:
2049         * gtk/jhbuildrc:
2050
2051 2013-03-27  Philippe Normand  <pnormand@igalia.com>
2052
2053         [GTK] run-launcher --gtk -2 fails on a WK2-only build
2054         https://bugs.webkit.org/show_bug.cgi?id=113386
2055
2056         Reviewed by Carlos Garcia Campos.
2057
2058         * Scripts/webkitdirs.pm:
2059         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
2060         version to 3.0. Reflect this change so the builtDylibPathForName
2061         function doesn't fail to report the library as found.
2062
2063 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
2064
2065         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
2066         https://bugs.webkit.org/show_bug.cgi?id=113484
2067
2068         Unreviewed build fix.
2069
2070         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
2071
2072         * TestWebKitAPI/CMakeLists.txt:
2073         * WebKitTestRunner/CMakeLists.txt:
2074
2075 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2076
2077         Revision for the internal jhbuild is too old
2078         https://bugs.webkit.org/show_bug.cgi?id=113324
2079
2080         Reviewed by Martin Robinson.
2081
2082         Update the minimum required version to a point where jhbuild won't
2083         fail installing packages when trying to remove a symlink to a directory.
2084
2085         * jhbuild/jhbuild-wrapper: Updated revision.
2086
2087 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
2088
2089         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
2090         https://bugs.webkit.org/show_bug.cgi?id=113203
2091
2092         Reviewed by Philippe Normand.
2093
2094         We build our libsoup without GNOME support. gst-plugins-good does separate
2095         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
2096         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
2097         build failures as the headers of those diverge. We do not use souphttpsrc, so
2098         disable it when building gst-plugins-good.
2099
2100         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
2101
2102 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
2103
2104         Build fix after r146852. Please another reference to the Lion leaks builder.
2105
2106         * BuildSlaveSupport/build.webkit.org-config/config.json:
2107
2108 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
2109
2110         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
2111         https://bugs.webkit.org/show_bug.cgi?id=113421
2112
2113         Reviewed by Dirk Pranke.
2114
2115         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
2116         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
2117         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
2118         in the GTK-specific TestExpectations files.
2119
2120         To avoid this only enable the warnings only when not using WKTR.
2121
2122         * Scripts/webkitpy/layout_tests/port/gtk.py:
2123         (GtkPort.warn_if_bug_missing_in_test_expectations):
2124
2125 2013-03-27  Antti Koivisto  <antti@apple.com>
2126
2127         Fix Zalan's email.
2128
2129         * Scripts/webkitpy/common/config/committers.py:
2130
2131 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
2132
2133         master.cfg cleanup
2134         https://bugs.webkit.org/show_bug.cgi?id=113195
2135
2136         Reviewed by Ryosuke Niwa.
2137
2138         * BuildSlaveSupport/build.webkit.org-config/config.json:
2139         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2140
2141 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
2142
2143         master.cfg fine-tuning for Qt Mountain Lion Release bot
2144         https://bugs.webkit.org/show_bug.cgi?id=113191
2145
2146         Reviewed by Ryosuke Niwa.
2147
2148         * BuildSlaveSupport/build.webkit.org-config/config.json:
2149           - Rename the slave due to its location change.
2150           - Update the platform of the slave.
2151         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2152         (RunQtAPITests): Enable running WK2 API tests on Qt.
2153         (RunQtAPITests.start):
2154         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
2155         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
2156
2157 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2158
2159         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
2160         https://bugs.webkit.org/show_bug.cgi?id=113403
2161
2162         Reviewed by Kenneth Rohde Christiansen.
2163
2164         As of Evas 1.7.5, when Wayland is detected on the system, support for
2165         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
2166         The code, however, seems to depend on a few other flags which must be
2167         explicitly enabled.
2168
2169         If those additional GL-related options are passed, we end up
2170         having issues on the WebKit side, so disable Wayland support for
2171         now.
2172
2173         * efl/jhbuild.modules:
2174
2175 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2176
2177         Unreviewed, rolling out r146864.
2178         http://trac.webkit.org/changeset/146864
2179         https://bugs.webkit.org/show_bug.cgi?id=113391
2180
2181         causes crashes on Wk2 EFL release bot (Requested by drott on
2182         #webkit).
2183
2184         * Scripts/webkitperl/FeatureList.pm:
2185
2186 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2187
2188         [jhbuild] Correctly specify an alternate number of make jobs.
2189         https://bugs.webkit.org/show_bug.cgi?id=113396
2190
2191         Reviewed by Philippe Normand.
2192
2193         So far, we were using the `MAKEFLAGS' environment variable to pass the
2194         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
2195         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
2196
2197         We now behave more closely to the rest of the WebKit tools by first
2198         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
2199         not set, just letting jhbuild itself figure out how many jobs to use.
2200
2201         * efl/jhbuildrc:
2202         * gtk/jhbuildrc:
2203
2204 2013-03-27  Zeno Albisser  <zeno@webkit.org>
2205
2206         [Qt] Remove Qt specific WorkQueueItem definitions.
2207         https://bugs.webkit.org/show_bug.cgi?id=112891
2208
2209         This patch is preparation work for removing
2210         WorkQueue related code from TestRunnerQt and
2211         replacing it with generic TestRunner code.
2212
2213         Reviewed by Benjamin Poulain.
2214
2215         * DumpRenderTree/qt/TestRunnerQt.cpp:
2216         (TestRunnerQt::queueBackNavigation):
2217         (TestRunnerQt::queueForwardNavigation):
2218         (TestRunnerQt::queueLoadHTMLString):
2219         (TestRunnerQt::queueReload):
2220         (TestRunnerQt::queueLoadingScript):
2221         (TestRunnerQt::queueNonLoadingScript):
2222         (TestRunner::queueLoad):
2223         * DumpRenderTree/qt/TestRunnerQt.h:
2224         (TestRunnerQt):
2225         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2226         (LoadItem::invoke):
2227         (LoadHTMLStringItem::invoke):
2228         (LoadAlternateHTMLStringItem::invoke):
2229         (ReloadItem::invoke):
2230         (ScriptItem::invoke):
2231         (BackForwardItem::invoke):
2232         * DumpRenderTree/qt/WorkQueueItemQt.h:
2233         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2234         (LoadAlternateHTMLStringItem):
2235
2236 2013-03-26  Julie Parent  <jparent@chromium.org>
2237
2238         Flakiness dashboard: simplify logic around which tests to show.
2239         https://bugs.webkit.org/show_bug.cgi?id=113250
2240
2241         Reviewed by Ojan Vafai.
2242         
2243         The different filters for showing results are only used for layout
2244         tests, otherwise, we show everything.
2245         
2246         Change the defaults to false (what layout tests used), and only
2247         look at the values when viewing layout tests.
2248
2249         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2250         (htmlForTestsWithExpectationsButNoFailures):
2251         (shouldHideTest):
2252
2253 2013-03-26  Isaac Levy  <ilevy@google.com>
2254
2255         Update bots on test-results.appspot
2256         https://bugs.webkit.org/show_bug.cgi?id=113333
2257
2258         Reviewed by Ojan Vafai.
2259
2260         * TestResultServer/static-dashboards/builders.jsonp:
2261
2262 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2263
2264         Unreviewed GTK gardening.
2265
2266         * Scripts/run-gtk-tests:
2267         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
2268
2269 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2270
2271         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
2272         https://bugs.webkit.org/show_bug.cgi?id=113287
2273
2274         Reviewed by Jocelyn Turcotte.
2275
2276         * Scripts/run-qtwebkit-tests:
2277         (Options.__init__):
2278
2279 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2280
2281         [EFL] Enable IndexedDB by default
2282         https://bugs.webkit.org/show_bug.cgi?id=107248
2283
2284         Reviewed by Laszlo Gombos.
2285
2286         * Scripts/webkitperl/FeatureList.pm:
2287         Enable IndexedDB by default on EFL.
2288
2289 2013-03-26  Alan Cutter  <alancutter@chromium.org>
2290
2291         Sheriffbot should explain rollout failures in a human readable form.
2292         https://bugs.webkit.org/show_bug.cgi?id=107092
2293
2294         Reviewed by Ryosuke Niwa.
2295
2296         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
2297
2298         * Scripts/webkitpy/tool/bot/irc_command.py:
2299         (Rollout._check_diff_failure):
2300         (Rollout.execute):
2301         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2302         (IRCCommandTest.test_rollout):
2303
2304 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2305
2306         Unreviewed GTK gardening.
2307
2308         * Scripts/run-gtk-tests:
2309         (TestRunner): Skipping a failing unit test after r146518.
2310
2311 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2312
2313         Remove Lion leaks builder
2314         https://bugs.webkit.org/show_bug.cgi?id=113252
2315
2316         Reviewed by Andreas Kling.
2317
2318         Removed.
2319
2320         * BuildSlaveSupport/build.webkit.org-config/config.json:
2321
2322 2013-03-25  Kent Tamura  <tkent@chromium.org>
2323
2324         Rename ENABLE_INPUT_TYPE_DATETIME
2325         https://bugs.webkit.org/show_bug.cgi?id=113254
2326
2327         Reviewed by Kentaro Hara.
2328
2329         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
2330         Actually I'd like to remove the code, but we shouldn't remove it yet
2331         because we shipped products with it on some platforms.
2332
2333         * Scripts/webkitperl/FeatureList.pm:
2334         * qmake/mkspecs/features/features.pri:
2335
2336 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2337
2338         Remove one more line that was intended to be removed in r146657.
2339
2340         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2341         (summarize_results):
2342
2343 2013-03-25  Roger Fong  <roger_fong@apple.com>
2344
2345         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
2346         Re-enable WinEWS tests.
2347
2348         * Scripts/webkitpy/common/config/ports.py:
2349         (WinPort.run_bindings_tests_command):
2350         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2351         (WinEWS):
2352
2353 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2354
2355         Unreviewed, rolling out r146793.
2356         http://trac.webkit.org/changeset/146793
2357         https://bugs.webkit.org/show_bug.cgi?id=113248
2358
2359         Fix did not work (Requested by rfong on #webkit).
2360
2361         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2362         (WinEWS):
2363
2364 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2365
2366         REGRESSION(r146657): Test failures reported incorrectly
2367         https://bugs.webkit.org/show_bug.cgi?id=113223
2368
2369         Reviewed by Dirk Pranke.
2370
2371         The bug was caused by BuildBotPrinter not taking the new behavior into account.
2372
2373         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
2374         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
2375
2376         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2377         (Manager.run):
2378
2379         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2380         (RunDetails.__init__):
2381         (summarize_results): Remove the line I intended to remove in r146657.
2382
2383         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2384         (logging_run): Return details instead of the exit code.
2385         (run_and_capture): Ditto.
2386
2387         (RunTest.test_full_results_html):
2388         (RunTest.test_hung_thread):
2389         (RunTest.test_no_tests_found):
2390         (RunTest.test_no_tests_found_2):
2391         (RunTest.test_repeat_each_iterations_num_tests):
2392         (RunTest.test_run_singly_actually_runs_tests):
2393         (RunTest.test_test_list):
2394         (RunTest.test_missing_and_unexpected_results):
2395         (RunTest.test_pixel_test_directories):
2396         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
2397         (RunTest.test_crash_with_stderr):
2398         (RunTest.test_no_image_failure_with_image_diff):
2399         (RunTest.test_crash_log):
2400         (RunTest.test_exit_after_n_failures_upload):
2401         (RunTest.test_results_directory_absolute):
2402         (RunTest.test_results_directory_relative):
2403         (RunTest.test_retrying_and_flaky_tests):
2404         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
2405         (RunTest.test_retrying_uses_retries_directory):
2406         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
2407         (RunTest.test_output_diffs):
2408         (EndToEndTest.test_reftest_with_two_notrefs):
2409         (RebaselineTest.test_reset_results):
2410         (RebaselineTest.test_missing_results):
2411         (RebaselineTest.test_new_baseline):
2412
2413         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2414         (BuildBotPrinter.print_results):
2415         (BuildBotPrinter.print_unexpected_results):
2416         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
2417         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
2418
2419 2013-03-25  Julie Parent  <jparent@chromium.org>
2420
2421         Dashboard refactor: Move cross dashboard history related code into history.js.
2422         https://bugs.webkit.org/show_bug.cgi?id=113104
2423
2424         Reviewed by Ojan Vafai.
2425
2426         All functions relating to cross dashboard behavior move from being
2427         globals to methods on the history.History object. Names stay the same,
2428         except many are made private, ones that should have been constants now
2429         are, and the long standing TODO to change "currentState" to 
2430         dashboardSpecificState is done.
2431         
2432         We now create a global history object in dashboard_base, as an 
2433         intermediate measure.  Once the dashboard specific code is
2434         added to history, each DB will need to create its own, and this
2435         global will be eliminated.
2436         
2437         * TestResultServer/static-dashboards/aggregate_results.js:
2438         (handleValidHashParameter):
2439         (htmlForBuilder):
2440         (rawValuesHTML):
2441         * TestResultServer/static-dashboards/dashboard_base.js:
2442         (parseDashboardSpecificParameters):
2443         (defaultValue):
2444         (currentBuilderGroupCategory):
2445         (currentBuilderGroupName):
2446         (handleLocationChange):
2447         (expectationsMap):
2448         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2449         (generatePage):
2450         (.switch.return):
2451         (platformAndBuildType):
2452         (individualTests):
2453         (substringList):
2454         (processMissingAndExtraExpectations):
2455         (pathToFailureLog):
2456         (showPopupForBuild):
2457         (htmlForTestsWithExpectationsButNoFailures):
2458         (shouldHideTest):
2459         (isCrossBuilderView):
2460         (tableHeaders):
2461         (htmlForSingleTestRow):
2462         (htmlForTableColumnHeader):
2463         (generatePageForExpectationsUpdate):
2464         (handleUpdate):
2465         (nextUpdate):
2466         (setUpdateIndex):
2467         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2468         (.appendExpectationsItem):
2469         (loadExpectations):
2470         (.dummyNode.onload):
2471         (loadExpectationsLayoutTests):
2472         (appendExpectations):
2473         (htmlForNavBar):
2474         (checkBoxToToggleState):
2475         (linkHTMLToToggleState):
2476         (generatePageForBuilder):
2477         (isInvalidKeyForCrossBuilderView):
2478         (handleQueryParameterChange):
2479         (showLegend):
2480         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2481         (resetGlobals):
2482         (test):
2483         * TestResultServer/static-dashboards/history.js:
2484         (.):
2485         * TestResultServer/static-dashboards/history_unittests.js:
2486         * TestResultServer/static-dashboards/loader.js:
2487         (.):
2488         * TestResultServer/static-dashboards/loader_unittests.js:
2489         * TestResultServer/static-dashboards/timeline_explorer.js:
2490         (generatePage):
2491         (initCurrentBuilderTestResults):
2492         (selectBuild):
2493         (showResultsDelta):
2494         * TestResultServer/static-dashboards/treemap.js:
2495         (generatePage):
2496         (.switch.return):
2497         (handleFocus):
2498         * TestResultServer/static-dashboards/ui.js:
2499
2500 2013-03-25  Roger Fong  <roger_fong@apple.com>
2501
2502         Unreviewed. Enable WinEWS tests again.
2503
2504         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2505         (WinEWS):
2506
2507 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2508
2509         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
2510         https://bugs.webkit.org/show_bug.cgi?id=112166
2511
2512         HarfBuzz 0.9.14 merged my patch for icu detection without
2513         pkg-config files, as needed by for example Ubuntu 12.04.
2514         This obsoletes our local workaround. Removed it for GTK and EFL.
2515
2516         Reviewed by Martin Robinson.
2517
2518         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2519         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
2520         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2521         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
2522
2523 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
2524
2525         Unreviewed.  Move self from contributor to committer list.
2526
2527         * Scripts/webkitpy/common/config/committers.py:
2528
2529 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2530
2531         EWS should use a human readable port name when uploading layout test archives
2532         https://bugs.webkit.org/show_bug.cgi?id=113099
2533
2534         Reviewed by Dirk Pranke.
2535
2536         Use new port's object's name() method to report human readable port names.
2537         This will also help us resolving the bug to apply layout test results posted by EWS.
2538
2539         * Scripts/webkitpy/tool/bot/botinfo.py:
2540         (BotInfo.__init__): Take port's name.
2541         (BotInfo.summary_text):
2542
2543         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2544         (BotInfoTest.test_summary_text):
2545
2546         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2547         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
2548
2549         * Scripts/webkitpy/tool/commands/queues.py:
2550         (PatchProcessingQueue.__init__): Initialize self._port.
2551         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
2552         and use that for the attachment filename and the comment posted.
2553
2554         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2555         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
2556         "mac-snowleopard" as expected for TestPort.
2557
2558 2013-03-22  Roger Fong  <roger_fong@apple.com>
2559
2560         Unreviewed. Turn off EWS test on Win again.
2561         The battle continues.
2562
2563         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2564         (WinEWS):
2565
2566 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2567
2568         NRWT: Enable pixel tests when retrying tests
2569         https://bugs.webkit.org/show_bug.cgi?id=112898
2570
2571         Reviewed by Dirk Pranke.
2572
2573         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2574         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2575         if we've forced pixel tests in the retry.
2576         (Manager._run_tests):
2577         (Manager._clean_up_run): Fixed the capitalizations.
2578         (Manager._force_pixel_tests_if_needed): Added.
2579
2580         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2581         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2582         'image_diff_percent' if it doesn't already exist.
2583
2584         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2585         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2586         treat this as a regular regression instead of a flakiness.
2587
2588         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2589         run had image diffs.
2590
2591         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2592         (summarized_results):
2593
2594         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2595         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2596         Also removed some dead code.
2597
2598         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2599         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2600         is set and pixel_tests_enabled is set to false.
2601         (EndToEndTest.test_reftest_with_two_notrefs):
2602
2603 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2604
2605         Make it possible to run layout tests on Retina MBP
2606         https://bugs.webkit.org/show_bug.cgi?id=93673
2607
2608         Reviewed by Ryosuke Niwa.
2609
2610         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2611         windows on 2x machines still run at 1x.
2612
2613         * DumpRenderTree/mac/DumpRenderTree.mm:
2614         (createWebViewAndOffscreenWindow):
2615         Reset the window resolution to 1x on creation.
2616         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2617         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2618         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2619         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2620         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2621         (WTR::PlatformWebView::PlatformWebView):
2622         Add NSWindow details, reset the window resolution to 1x on creation.
2623
2624 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2625
2626         Leak bots shouldn't build
2627         https://bugs.webkit.org/show_bug.cgi?id=112774
2628
2629         Reviewed by Simon Fraser.
2630
2631         Since leak bots use regular debug builds, there is no need to build on these bots.
2632         Simply downloading builds will dramatically improve the cycle time of these bots.
2633
2634         * BuildSlaveSupport/build.webkit.org-config/config.json:
2635         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2636         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2637         TestFactory instead of BuildAndTestFactory.
2638
2639 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2640
2641         [Qt] Fix the TestWebKitAPI build
2642         https://bugs.webkit.org/show_bug.cgi?id=113044
2643
2644         Reviewed by Tor Arne Vestbø.
2645
2646         The generate-forwarding-headers script would only be run
2647         after the targets in InjectedBundle.pri since the second
2648         addStrictSubdirOrderBetween call in
2649         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2650         the derived_sources -> injected_bundle order in SUBDIRS.
2651
2652         Fix it by only moving the dependent target at the end of
2653         SUBDIRS, don't touch its dependency.
2654
2655         * qmake/mkspecs/features/functions.prf:
2656
2657 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2658
2659         [EFL][WK2] View is not focused when fullscreen mode toggled
2660         https://bugs.webkit.org/show_bug.cgi?id=113009
2661
2662         Reviewed by Laszlo Gombos.
2663
2664         Set focus on view when fullscreen mode enabled/disabled
2665         by FullScreen API.
2666
2667         * MiniBrowser/efl/main.c:
2668         (on_fullscreen_accept):
2669         (on_fullscreen_deny):
2670
2671 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2672
2673         nrwt is no longer saving retry results in the retries/ subdirectory
2674         https://bugs.webkit.org/show_bug.cgi?id=112995
2675
2676         Reviewed by Ojan Vafai.
2677
2678         I think this has been broken a long time, unfortunately. This
2679         patch should fix that.
2680
2681         In order to do so, I had to pass the directory to use from
2682         the Worker object through the SingleTestWriter to the
2683         TestResultWriter. While I was plumbing that through, I rationalized
2684         the order of the parameter arguments a bit ...
2685
2686         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2687         (Worker._run_single_test):
2688         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2689         (run_single_test):
2690         (SingleTestRunner.__init__):
2691         (SingleTestRunner._run_compare_test):
2692         (SingleTestRunner._run_rebaseline):
2693         (SingleTestRunner._run_reftest):
2694         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2695         (write_test_result):
2696         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2697         (TestResultWriterTest.test_reftest_diff_image):
2698         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2699         (RunTest.test_retrying_uses_retries_directory):
2700
2701 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2702
2703         JSC profiler should have an at-a-glance report of the success of DFG optimization
2704         https://bugs.webkit.org/show_bug.cgi?id=112988
2705
2706         Reviewed by Geoffrey Garen.
2707
2708         * Scripts/display-profiler-output:
2709
2710 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2711
2712         [chromium] Linux ASAN WebKit canary is running out of memory
2713         https://bugs.webkit.org/show_bug.cgi?id=112978
2714
2715         Reviewed by Tony Chang.
2716
2717         Running the AddressSanitizer on a crash takes a lot of
2718         memory, so we should serialize access to it to avoid running
2719         out of memory on a machine.
2720
2721         * Scripts/webkitpy/layout_tests/port/chromium.py:
2722         (ChromiumPort._get_crash_log):
2723         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2724         (HttpLock.__init__):
2725         (HttpLock.wait_for_httpd_lock):
2726
2727 2013-03-21  Min Qin  <qinmin@chromium.org>
2728
2729         Cleanup android media layout test code
2730         https://bugs.webkit.org/show_bug.cgi?id=112944
2731
2732         Reviewed by Adam Barth.
2733
2734         Chromium change: https://codereview.chromium.org/12892010/
2735         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2736         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2737         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2738         Instead, we should switch to use content shell for layout tests.
2739
2740         * DumpRenderTree/chromium/TestShell.cpp:
2741         (TestShell::resetTestController):
2742
2743 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2744
2745         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2746         https://bugs.webkit.org/show_bug.cgi?id=112953
2747
2748         Reviewed by Tony Chang.
2749
2750         When I created the DumpRenderTree_resources target in r144863 I
2751         forgot to declare the needed dependencies on the other resource
2752         targets. Due to a quirk of ordering, this appears to have been fine
2753         w/ ninja but not w/ Xcode (which is still being used on the chromium
2754         mac valgrind bots). Declaring the dependencies fixes the build
2755         failures.
2756
2757         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2758
2759 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2760
2761         [WinCairo] Correct assert in Empty BitmapImage Test.
2762         https://bugs.webkit.org/show_bug.cgi?id=112934
2763
2764         Reviewed by Tim Horton.
2765
2766         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2767         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2768         to avoid ref counting assertion when leaving test scope.
2769
2770 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2771
2772         [GTK] generate-feature-defines-files is incompatible with Python3
2773         https://bugs.webkit.org/show_bug.cgi?id=112956
2774
2775         Reviewed by Martin Robinson.
2776
2777         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2778         method on the dictionary objects when iterating through said dictionaries.
2779
2780         * gtk/generate-feature-defines-files:
2781         (write_feature_defines_header):
2782         (write_flattened_feature_defines_file):
2783
2784 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2785
2786         kill-old-processes spits out error messages on Mac
2787         https://bugs.webkit.org/show_bug.cgi?id=112878
2788
2789         Reviewed by Jessie Berlin.
2790
2791         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2792         included in the list of options grep --help shows.
2793
2794         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2795
2796         * BuildSlaveSupport/kill-old-processes:
2797         (main):
2798
2799 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2800
2801         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2802         https://bugs.webkit.org/show_bug.cgi?id=112597
2803
2804         Reviewed by Xan Lopez.
2805
2806         These were introduced for the Chromium port in r105295. We need
2807         dummy implementations in order to compile the BlackBerry port.
2808
2809         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2810         (AccessibilityUIElement::scrollToMakeVisible):
2811         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2812         (AccessibilityUIElement::scrollToGlobalPoint):
2813
2814 2013-03-21  Roger Fong  <roger_fong@apple.com>
2815
2816         Re-enable WinEWS tests following r146376.
2817
2818         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2819         (WinEWS):
2820
2821 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2822
2823         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2824
2825         * Scripts/webkitpy/common/config/committers.py:
2826
2827 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2828
2829         [GTK] Missing atk in install-dependencies script
2830         https://bugs.webkit.org/show_bug.cgi?id=112272
2831
2832         Reviewed by Gustavo Noronha Silva.
2833
2834         * gtk/install-dependencies: Add missing atk dependency.
2835
2836 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2837
2838         [GTK] Missing backslash in install-dependencies script
2839         https://bugs.webkit.org/show_bug.cgi?id=112907
2840
2841         Reviewed by Philippe Normand.
2842
2843         * gtk/install-dependencies: Add missing backslash to dependencies
2844         list.
2845
2846 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2847
2848         EWS bots have stopped uploading results to bugzilla
2849         https://bugs.webkit.org/show_bug.cgi?id=101091
2850
2851         Reviewed by Adam Barth.
2852
2853         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2854         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2855         this relative file path resoled to a file inside a non-existent directory for "zip".
2856
2857         Fixed the bug by resolving both test results directory and zip archive paths in
2858         LayoutTestResultsReader.archive.
2859
2860         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2861         in the future.
2862
2863         * Scripts/webkitpy/common/system/filesystem_mock.py:
2864         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2865
2866         * Scripts/webkitpy/common/system/workspace.py:
2867         (Workspace.create_zip): Log the source path when "zip" failed.
2868
2869         * Scripts/webkitpy/common/system/workspace_mock.py:
2870         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2871
2872         * Scripts/webkitpy/common/system/workspace_unittest.py:
2873         (WorkspaceTest.test_create_zip_exception): Test that.
2874
2875         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2876         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2877         This is the actual bug fix.
2878
2879         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2880         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2881
2882 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2883
2884         [chromium] move WebThemeEngine implementations to TestRunner library
2885         https://bugs.webkit.org/show_bug.cgi?id=112751
2886
2887         Reviewed by Adam Barth.
2888
2889         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2890         * DumpRenderTree/DumpRenderTree.gypi:
2891         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2892         (WebKit):
2893         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2894         (WebTestRunner::TestInterfaces::themeEngine):
2895         (WebTestRunner):
2896         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2897         (WebKit):
2898         (TestInterfaces):
2899         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2900         (WebTestRunner::WebTestInterfaces::themeEngine):
2901         (WebTestRunner):
2902         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2903         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2904         (WebTestRunner):
2905         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2906         (WebTestRunner::WebTestThemeControlWin::box):
2907         (WebTestRunner::WebTestThemeControlWin::line):
2908         (WebTestRunner::WebTestThemeControlWin::triangle):
2909         (WebTestRunner::WebTestThemeControlWin::roundRect):
2910         (WebTestRunner::WebTestThemeControlWin::oval):
2911         (WebTestRunner::WebTestThemeControlWin::circle):
2912         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2913         (WebTestRunner::WebTestThemeControlWin::markState):
2914         (WebTestRunner::WebTestThemeControlWin::draw):
2915         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2916         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2917         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2918         (WebTestRunner):
2919         (WebTestThemeControlWin):
2920         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2921         (WebTestRunner):
2922         (WebTestThemeEngineMac):
2923         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2924         (+[FakeActiveWindow alwaysActiveWindow]):
2925         (+[FakeActiveWindow alwaysInactiveWindow]):
2926         (-[FakeActiveWindow initWithActiveControls:]):
2927         (-[FakeActiveWindow _hasActiveControls]):
2928         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2929         (WebTestRunner):
2930         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2931         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2932         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2933         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2934         (WebTestRunner):
2935         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2936         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2937         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2938         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2939         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2940         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2941         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2942         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2943         (WebTestRunner::WebTestThemeEngineWin::getSize):
2944         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2945         (WebTestRunner):
2946         (WebTestThemeEngineWin):
2947         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2948         * DumpRenderTree/chromium/TestShell.cpp:
2949         (TestShell::initialize):
2950         * DumpRenderTree/chromium/TestShell.h:
2951         (WebKit):
2952         * DumpRenderTree/chromium/TestShellMac.mm:
2953         (platformInit):
2954         * DumpRenderTree/chromium/TestShellWin.cpp:
2955         (platformInit):
2956         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2957
2958 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2959
2960         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2961
2962         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2963         New property sheet that does not link against CoreFoundation and
2964         CFNetwork.
2965         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2966         Use new TestWebKitAPICommonWinCairo property sheet.
2967         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2968         Ditto.
2969
2970 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2971
2972         [WinCairo] Unreviewed build fix for VS2010.
2973
2974         Had to add WinCairo-specific property sheets to deal with some
2975         library and path differences with the main Apple port.
2976
2977         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2978         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2979         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2980         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2981         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2982         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2983
2984 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2985
2986         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2987         https://bugs.webkit.org/show_bug.cgi?id=112849
2988
2989         Reviewed by Sam Weinig.
2990
2991         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2992         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2993         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2994
2995 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2996
2997         [WinCairo] Build WebKit Tools under VS2010
2998         https://bugs.webkit.org/show_bug.cgi?id=112821
2999
3000         Reviewed by Tim Horton.
3001
3002         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3003         Add WinCairo-specific build target.
3004         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
3005         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
3006         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
3007         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
3008         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3009         Add WinCairo-specific build target.
3010         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3011         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3012         Add WinCairo-specific build target.
3013         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
3014         WinCairo-specific build target.
3015         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
3016         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
3017         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
3018         specific build target.
3019         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
3020         WinCairo-specific build target.
3021         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
3022         * win/record-memory/record-memoryDebugWinCairo.props: Added.
3023         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
3024
3025 2013-03-20  Roger Fong  <roger_fong@apple.com>
3026
3027         API test gardening AppleWin port.
3028
3029         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
3030
3031         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3032         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3033
3034 2013-03-20  Roger Fong  <roger_fong@apple.com>
3035
3036         Test fix for Win EWS bots, catch various errors and restart script if necessary.
3037
3038         * EWSTools/start-queue-win.sh:
3039
3040 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
3041
3042         Unreviewed, add myself to committers.py.
3043
3044 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3045
3046         Unreviewed. Adding another email for me.
3047
3048         * Scripts/webkitpy/common/config/committers.py:
3049
3050 2013-03-20  Justin Novosad  <junov@google.com>
3051
3052         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
3053         https://bugs.webkit.org/show_bug.cgi?id=112605
3054
3055         Reviewed by James Robinson.
3056
3057         Deleting all the code that was used for propagating and supporting
3058         the Chromium setting for disabling deferred 2d canvas rendering.
3059
3060         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3061         (main):
3062         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3063         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3064         (WebTestRunner::WebPreferences::reset):
3065         (WebTestRunner::WebPreferences::applyTo):
3066         * DumpRenderTree/chromium/TestShell.cpp:
3067         (TestShell::TestShell):
3068         (TestShell::resetWebSettings):
3069         (TestShell::runFileTest):
3070         * DumpRenderTree/chromium/TestShell.h:
3071         (TestShell):
3072
3073 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
3074
3075         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
3076         https://bugs.webkit.org/show_bug.cgi?id=112699.
3077
3078         Reviewed by Adam Barth.
3079
3080         * Scripts/webkitpy/layout_tests/port/qt.py:
3081         (QtPort._search_paths):
3082         (QtPort._port_specific_expectations_files):
3083         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3084         (QtPortTest):
3085         (QtPortTest._assert_search_path):
3086         (QtPortTest._assert_expectations_files):
3087
3088 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3089
3090         [Qt] Enable kerning by default
3091         https://bugs.webkit.org/show_bug.cgi?id=112704
3092
3093         Reviewed by Jocelyn Turcotte.
3094
3095         Disable kerning by default, since some reference test expectations
3096         expect kerning to be default off.
3097
3098         * DumpRenderTree/qt/TestRunnerQt.cpp:
3099         (TestRunnerQt::reset):
3100         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3101         (WTR::activateFonts):
3102
3103 2013-03-20  Zeno Albisser  <zeno@webkit.org>
3104
3105         [Qt] Remove empty function stubs from TestRunnerQt.
3106         https://bugs.webkit.org/show_bug.cgi?id=112799
3107
3108         We are reducing the code in TestRunnerQt step by step,
3109         in order to finally replace all of it with the generic
3110         TestRunner implementation.
3111         This patch removes several simple function stubs that
3112         currently do not implement any actual functionality.
3113
3114         Reviewed by Kenneth Rohde Christiansen.
3115
3116         * DumpRenderTree/qt/TestRunnerQt.cpp:
3117         * DumpRenderTree/qt/TestRunnerQt.h:
3118         (TestRunnerQt):
3119
3120 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3121
3122         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
3123         https://bugs.webkit.org/show_bug.cgi?id=112687
3124
3125         Reviewed by Kenneth Rohde Christiansen.
3126
3127         Hide the SearchBar by default on window creation.
3128
3129         * MiniBrowser/efl/main.c:
3130         (window_create):
3131
3132 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
3133
3134         Unreviewed, rolling out r146304.
3135         http://trac.webkit.org/changeset/146304
3136         https://bugs.webkit.org/show_bug.cgi?id=112788
3137
3138         to many expectations to update (Requested by antonm on
3139         #webkit).
3140
3141         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3142         * DumpRenderTree/DumpRenderTree.gypi:
3143         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3144         (WebKit):
3145         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3146         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3147         (TestInterfaces):
3148         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3149         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3150         * DumpRenderTree/chromium/TestShell.cpp:
3151         (TestShell::initialize):
3152         * DumpRenderTree/chromium/TestShell.h:
3153         (WebKit):
3154         * DumpRenderTree/chromium/TestShellMac.mm:
3155         (platformInit):
3156         * DumpRenderTree/chromium/TestShellWin.cpp:
3157         (platformInit):
3158         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3159         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3160         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3161         (WebThemeControlDRTWin::box):
3162         (WebThemeControlDRTWin::line):
3163         (WebThemeControlDRTWin::triangle):
3164         (WebThemeControlDRTWin::roundRect):
3165         (WebThemeControlDRTWin::oval):
3166         (WebThemeControlDRTWin::circle):
3167         (WebThemeControlDRTWin::nestedBoxes):
3168         (WebThemeControlDRTWin::markState):
3169         (WebThemeControlDRTWin::draw):
3170         (WebThemeControlDRTWin::drawTextField):
3171         (WebThemeControlDRTWin::drawProgressBar):
3172         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3173         (WebThemeControlDRTWin):
3174         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3175         (WebThemeEngineDRTMac):
3176         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3177         (+[FakeActiveWindow alwaysActiveWindow]):
3178         (+[FakeActiveWindow alwaysInactiveWindow]):
3179         (-[FakeActiveWindow initWithActiveControls:]):
3180         (-[FakeActiveWindow _hasActiveControls]):
3181         (WebThemeEngineDRTMac::paintScrollbarThumb):
3182         (stateToHIEnableState):
3183         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3184         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3185         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3186         (webRectToSkIRect):
3187         (drawControl):
3188         (drawTextField):
3189         (drawProgressBar):
3190         (WebThemeEngineDRTWin::paintButton):
3191         (WebThemeEngineDRTWin::paintMenuList):
3192         (WebThemeEngineDRTWin::paintScrollbarArrow):
3193         (WebThemeEngineDRTWin::paintScrollbarThumb):
3194         (WebThemeEngineDRTWin::paintScrollbarTrack):
3195         (WebThemeEngineDRTWin::paintSpinButton):
3196         (WebThemeEngineDRTWin::paintTextField):
3197         (WebThemeEngineDRTWin::paintTrackbar):
3198         (WebThemeEngineDRTWin::paintProgressBar):
3199         (WebThemeEngineDRTWin::getSize):
3200         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3201         (WebThemeEngineDRTWin):
3202         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3203
3204 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3205
3206         [Qt] Support -webkit-font-smoothing
3207         https://bugs.webkit.org/show_bug.cgi?id=106009
3208
3209         Reviewed by Jocelyn Turcotte.
3210
3211         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
3212
3213         * DumpRenderTree/qt/TestRunnerQt.cpp:
3214         (TestRunnerQt::reset):
3215
3216 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
3217
3218         [GTK] accessibility/aria-scrollbar-role.html is failing
3219         https://bugs.webkit.org/show_bug.cgi?id=98358
3220
3221         Reviewed by Martin Robinson.
3222
3223         Adds support for checking accessibility object's orientation.
3224         Orientation is checked by retrieving proper state of accessibility object.
3225
3226         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3227         (checkElementState):
3228         (AccessibilityUIElement::orientation):
3229         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3230         (WTR::AccessibilityUIElement::orientation):
3231
3232 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3233
3234         [chromium] move WebThemeEngine implementations to TestRunner library
3235         https://bugs.webkit.org/show_bug.cgi?id=112751
3236
3237         Reviewed by Adam Barth.
3238
3239         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3240         * DumpRenderTree/DumpRenderTree.gypi:
3241         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3242         (WebKit):
3243         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3244         (WebTestRunner::TestInterfaces::themeEngine):
3245         (WebTestRunner):
3246         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3247         (WebKit):
3248         (TestInterfaces):
3249         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3250         (WebTestRunner::WebTestInterfaces::themeEngine):
3251         (WebTestRunner):
3252         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3253         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3254         (WebTestRunner):
3255         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3256         (WebTestRunner::WebTestThemeControlWin::box):
3257         (WebTestRunner::WebTestThemeControlWin::line):
3258         (WebTestRunner::WebTestThemeControlWin::triangle):
3259         (WebTestRunner::WebTestThemeControlWin::roundRect):
3260         (WebTestRunner::WebTestThemeControlWin::oval):
3261         (WebTestRunner::WebTestThemeControlWin::circle):
3262         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3263         (WebTestRunner::WebTestThemeControlWin::markState):
3264         (WebTestRunner::WebTestThemeControlWin::draw):
3265         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3266         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3267         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3268         (WebTestRunner):
3269         (WebTestThemeControlWin):
3270         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3271         (WebTestRunner):
3272         (WebTestThemeEngineMac):
3273         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3274         (+[FakeActiveWindow alwaysActiveWindow]):
3275         (+[FakeActiveWindow alwaysInactiveWindow]):
3276         (-[FakeActiveWindow initWithActiveControls:]):
3277         (-[FakeActiveWindow _hasActiveControls]):
3278         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3279         (WebTestRunner):
3280         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3281         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3282         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3283         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3284         (WebTestRunner):
3285         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3286         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3287         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3288         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3289         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3290         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3291         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3292         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3293         (WebTestRunner::WebTestThemeEngineWin::getSize):
3294         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3295         (WebTestRunner):
3296         (WebTestThemeEngineWin):
3297         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3298         * DumpRenderTree/chromium/TestShell.cpp:
3299         (TestShell::initialize):
3300         * DumpRenderTree/chromium/TestShell.h:
3301         (WebKit):
3302         * DumpRenderTree/chromium/TestShellMac.mm:
3303         (platformInit):
3304         * DumpRenderTree/chromium/TestShellWin.cpp:
3305         (platformInit):
3306         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3307
3308 2013-03-19  Tony Chang  <tony@chromium.org>
3309
3310         Move testRunner.setTouchDragDropEnabled to internals.settings
3311         https://bugs.webkit.org/show_bug.cgi?id=112739
3312
3313         Reviewed by Adam Barth.
3314
3315         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3316         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
3317         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3318         (TestRunner): Remove unnecessary code.
3319         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3320         (WebTestRunner::WebPreferences::reset):
3321         (WebTestRunner::WebPreferences::applyTo): Always set to false.
3322
3323 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
3324
3325         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3326         https://bugs.webkit.org/show_bug.cgi?id=112754
3327
3328         Reviewed by Darin Fisher.
3329
3330         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3331         now that it's always defined.
3332
3333         * DumpRenderTree/chromium/WebViewHost.cpp:
3334         * DumpRenderTree/chromium/WebViewHost.h:
3335         (WebViewHost):
3336
3337 2013-03-19  Kenneth Russell  <kbr@google.com>
3338
3339         Unreviewed, rolling out r146290.
3340         http://trac.webkit.org/changeset/146290
3341         https://bugs.webkit.org/show_bug.cgi?id=112751
3342
3343         Broke Chromium Mac build.
3344
3345         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3346         * DumpRenderTree/DumpRenderTree.gypi:
3347         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3348         (WebKit):
3349         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3350         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3351         (TestInterfaces):
3352         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3353         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3354         * DumpRenderTree/chromium/TestShell.cpp:
3355         (TestShell::initialize):
3356         * DumpRenderTree/chromium/TestShell.h:
3357         (WebKit):
3358         * DumpRenderTree/chromium/TestShellMac.mm:
3359         (platformInit):
3360         * DumpRenderTree/chromium/TestShellWin.cpp:
3361         (platformInit):
3362         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3363         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3364         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3365         (WebThemeControlDRTWin::box):
3366         (WebThemeControlDRTWin::line):
3367         (WebThemeControlDRTWin::triangle):
3368         (WebThemeControlDRTWin::roundRect):
3369         (WebThemeControlDRTWin::oval):
3370         (WebThemeControlDRTWin::circle):
3371         (WebThemeControlDRTWin::nestedBoxes):
3372         (WebThemeControlDRTWin::markState):
3373         (WebThemeControlDRTWin::draw):
3374         (WebThemeControlDRTWin::drawTextField):
3375         (WebThemeControlDRTWin::drawProgressBar):
3376         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3377         (WebThemeControlDRTWin):
3378         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3379         (WebThemeEngineDRTMac):
3380         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3381         (+[FakeActiveWindow alwaysActiveWindow]):
3382         (+[FakeActiveWindow alwaysInactiveWindow]):
3383         (-[FakeActiveWindow initWithActiveControls:]):
3384         (-[FakeActiveWindow _hasActiveControls]):
3385         (WebThemeEngineDRTMac::paintScrollbarThumb):
3386         (stateToHIEnableState):
3387         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3388         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3389         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3390         (webRectToSkIRect):
3391         (drawControl):
3392         (drawTextField):
3393         (drawProgressBar):
3394         (WebThemeEngineDRTWin::paintButton):
3395         (WebThemeEngineDRTWin::paintMenuList):
3396         (WebThemeEngineDRTWin::paintScrollbarArrow):
3397         (WebThemeEngineDRTWin::paintScrollbarThumb):
3398         (WebThemeEngineDRTWin::paintScrollbarTrack):
3399         (WebThemeEngineDRTWin::paintSpinButton):
3400         (WebThemeEngineDRTWin::paintTextField):
3401         (WebThemeEngineDRTWin::paintTrackbar):
3402         (WebThemeEngineDRTWin::paintProgressBar):
3403         (WebThemeEngineDRTWin::getSize):
3404         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3405         (WebThemeEngineDRTWin):
3406         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3407
3408 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
3409
3410         [EFL] canvas-fallback-content.html is failing
3411         https://bugs.webkit.org/show_bug.cgi?id=111998
3412
3413         Reviewed by Chris Fleizach.
3414
3415         Adds support for getting platform name.
3416
3417         * DumpRenderTree/TestRunner.cpp:
3418         (TestRunner::staticValues):
3419         * DumpRenderTree/TestRunner.h:
3420         (TestRunner):
3421         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3422         (TestRunner::platformName):
3423
3424 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3425
3426         [chromium] move WebThemeEngine implementations to TestRunner library
3427         https://bugs.webkit.org/show_bug.cgi?id=112751
3428
3429         Reviewed by Adam Barth.
3430
3431         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3432         * DumpRenderTree/DumpRenderTree.gypi:
3433         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3434         (WebKit):
3435         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3436         (WebTestRunner::TestInterfaces::themeEngine):
3437         (WebTestRunner):
3438         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3439         (WebKit):
3440         (TestInterfaces):
3441         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3442         (WebTestRunner::WebTestInterfaces::themeEngine):
3443         (WebTestRunner):
3444         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3445         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3446         (WebTestRunner):
3447         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3448         (WebTestRunner::WebTestThemeControlWin::box):
3449         (WebTestRunner::WebTestThemeControlWin::line):
3450         (WebTestRunner::WebTestThemeControlWin::triangle):
3451         (WebTestRunner::WebTestThemeControlWin::roundRect):
3452         (WebTestRunner::WebTestThemeControlWin::oval):
3453         (WebTestRunner::WebTestThemeControlWin::circle):
3454         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3455         (WebTestRunner::WebTestThemeControlWin::markState):
3456         (WebTestRunner::WebTestThemeControlWin::draw):
3457         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3458         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3459         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3460         (WebTestRunner):
3461         (WebTestThemeControlWin):
3462         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3463         (WebTestRunner):
3464         (WebTestThemeEngineMac):
3465         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3466         (+[FakeActiveWindow alwaysActiveWindow]):
3467         (+[FakeActiveWindow alwaysInactiveWindow]):
3468         (-[FakeActiveWindow initWithActiveControls:]):
3469         (-[FakeActiveWindow _hasActiveControls]):
3470         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3471         (WebTestRunner):
3472         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3473         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3474         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3475         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3476         (WebTestRunner):
3477         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3478         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3479         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3480         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3481         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3482         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3483         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3484         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3485         (WebTestRunner::WebTestThemeEngineWin::getSize):
3486         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3487         (WebTestRunner):
3488         (WebTestThemeEngineWin):
3489         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3490         * DumpRenderTree/chromium/TestShell.cpp:
3491         (TestShell::initialize):
3492         * DumpRenderTree/chromium/TestShell.h:
3493         (WebKit):
3494         * DumpRenderTree/chromium/TestShellMac.mm:
3495         (platformInit):
3496         * DumpRenderTree/chromium/TestShellWin.cpp:
3497         (platformInit):
3498         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3499
3500 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3501
3502         [EFL][WK2] Separate WebView further from EwkView
3503         https://bugs.webkit.org/show_bug.cgi?id=111591
3504
3505         Reviewed by Caio Marcelo de Oliveira Filho.
3506
3507         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
3508         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
3509         since we can afford it having EWKViewGetWKView() private API to access WKView.
3510
3511         * TestWebKitAPI/PlatformWebView.h:
3512         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3513         (TestWebKitAPI::TEST):
3514         * TestWebKitAPI/efl/PlatformWebView.cpp:
3515         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3516         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3517         (TestWebKitAPI::PlatformWebView::resizeTo):
3518         (TestWebKitAPI::PlatformWebView::page):
3519         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3520         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3521         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3522         * WebKitTestRunner/PlatformWebView.h:
3523         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3524         (WTR::EventSenderProxy::dispatchEvent):
3525         (WTR::EventSenderProxy::keyDown):
3526         (WTR::EventSenderProxy::sendTouchEvent):
3527         (WTR::EventSenderProxy::setTouchModifier):
3528         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3529         (WTR::PlatformWebView::PlatformWebView):
3530         (WTR::PlatformWebView::~PlatformWebView):
3531         (WTR::PlatformWebView::resizeTo):
3532         (WTR::PlatformWebView::page):
3533         (WTR::PlatformWebView::focus):
3534         (WTR::PlatformWebView::windowSnapshotImage):
3535
3536 2013-03-19  Roger Fong  <roger_fong@apple.com>
3537
3538         Changes to VS2010 project files should only trigger builds on Windows bots.
3539         https://bugs.webkit.org/show_bug.cgi?id=112731
3540
3541         Reviewed by Timothy Horton.
3542
3543         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3544         (_should_file_trigger_build):
3545
3546 2013-03-19  Roger Fong  <roger_fong@apple.com>
3547
3548         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
3549
3550         * Scripts/webkitpy/tool/steps/runtests.py:
3551         (RunTests.run):
3552         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3553         (RunTestsTest.test_webkit_run_unit_tests):
3554
3555 2013-03-19  Julie Parent  <jparent@chromium.org>
3556
3557         Dashboards: Introduce history namespace and unit tests.
3558         https://bugs.webkit.org/show_bug.cgi?id=112645
3559
3560         Reviewed by Ojan Vafai.
3561         
3562         Laying the framework for introducing the new history object and
3563         namespace.  This moves only static functions into the history
3564         namespace, and moves corresponding unit tests into seperate
3565         unit test file.
3566
3567         * TestResultServer/static-dashboards/aggregate_results.html:
3568         * TestResultServer/static-dashboards/dashboard_base.js:
3569         (parseCrossDashboardParameters):
3570         (parseDashboardSpecificParameters):
3571         (parseParameters):
3572         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3573         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3574         (.switch.return):
3575         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3576         * TestResultServer/static-dashboards/history.js: Added.
3577         * TestResultServer/static-dashboards/history_unittests.js: Added.
3578         * TestResultServer/static-dashboards/loader.js:
3579         (.):
3580         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3581         * TestResultServer/static-dashboards/run-unittests.html:
3582         * TestResultServer/static-dashboards/timeline_explorer.html:
3583         * TestResultServer/static-dashboards/timeline_explorer.js:
3584         * TestResultServer/static-dashboards/treemap.html:
3585         * TestResultServer/static-dashboards/treemap.js:
3586         (.switch.return):
3587         * TestResultServer/static-dashboards/ui.js:
3588
3589 2013-03-19  Daniel Bates  <dbates@webkit.org>
3590
3591         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3592         https://bugs.webkit.org/show_bug.cgi?id=112732
3593
3594         Reviewed by Eric Seidel.
3595
3596         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3597         of an existing file cannot be applied.
3598
3599         In particular, svn-{apply, unapply} compensate for differences in line endings
3600         by converting the line endings in a diff to match the line endings in the target
3601         file. The diff(1) command precedes the last line of a diff that adds a newline
3602         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3603         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3604         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3605         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3606         the newline characters in this special character sequence to match the line endings
3607         in the target file.
3608
3609         * Scripts/VCSUtils.pm:
3610         (parseDiff):
3611         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3612         Added tests:
3613             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3614             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3615             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3616             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3617         (escapeNewLineCharacters): Added.
3618         (toMacLineEndings): Added.
3619
3620 2013-03-19  James Robinson  <jamesr@chromium.org>
3621
3622         [chromium] Remove compositor settings that don't go through WebKit
3623         https://bugs.webkit.org/show_bug.cgi?id=112718
3624
3625         Reviewed by Adam Barth.
3626
3627         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3628         (main):
3629         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3630         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3631         (WebTestRunner::WebPreferences::reset):
3632         (WebTestRunner::WebPreferences::applyTo):
3633         * DumpRenderTree/chromium/TestShell.cpp:
3634         (TestShell::TestShell):
3635         (TestShell::resetWebSettings):
3636         * DumpRenderTree/chromium/TestShell.h:
3637         (TestShell):
3638
3639 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3640
3641         Unreviewed, rolling out r146101.
3642         https://bugs.webkit.org/show_bug.cgi?id=111884
3643
3644         re-enable custom freetype on asan; this needs to be on
3645         now that the bot is running lucid.
3646
3647         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3648
3649 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3650
3651         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3652         https://bugs.webkit.org/show_bug.cgi?id=112365
3653
3654         Reviewed by Benjamin Poulain.
3655
3656         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3657         harcoding it in wtf/Platform.h
3658
3659         * Scripts/webkitperl/FeatureList.pm:
3660
3661 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3662