89349e94e0c55aa29cf09a8217243768e73aaad0
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
2
3         [PAL] Move spi/cf directory into PAL
4         https://bugs.webkit.org/show_bug.cgi?id=175057
5
6         Reviewed by Antti Koivisto.
7
8         * Scripts/webkitpy/style/checker.py:
9         * Scripts/webkitpy/style/checker_unittest.py:
10         (GlobalVariablesTest.test_path_rules_specifier):
11
12         Ignore "readability/naming/underscores" style errors for sources
13         under the WebCore/PAL/pal/spi directory.
14
15         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
16
17 2017-08-03  Youenn Fablet  <youenn@apple.com>
18
19         Remove FETCH_API compilation guard
20         https://bugs.webkit.org/show_bug.cgi?id=175154
21
22         Reviewed by Chris Dumez.
23
24         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
25
26 2017-08-03  Lucas Forschler  <lforschler@apple.com>
27
28         Enable archive minification on iOS builds
29         https://bugs.webkit.org/show_bug.cgi?id=174718
30         
31         Reviewed by Aakash Jain.
32
33         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
34         (BuildFactory.__init__):
35
36 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
37
38         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
39         https://bugs.webkit.org/show_bug.cgi?id=175140
40
41         Reviewed by Alexey Proskuryakov.
42
43         We are having lately issues with JSC tests causing problems on
44         the GTK+ and WPE bots due to the high amount of memory some tests
45         need to run.
46
47         The best thing we can do now is to workaround this by disabling
48         all the tests marked as memoryLimited on the GTK and WPE bots.
49         We may revise this on the future.
50
51         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
52         (RunJavaScriptCoreTests.start):
53
54 2017-08-03  Brady Eidson  <beidson@apple.com>
55
56         Add SW IDLs and stub out basic functionality.
57         https://bugs.webkit.org/show_bug.cgi?id=175115
58
59         Reviewed by Chris Dumez.
60
61         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
62
63         * Scripts/webkitpy/bindings/main.py:
64
65 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
66
67         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
68         https://bugs.webkit.org/show_bug.cgi?id=159510
69
70         Reviewed by Daniel Bates.
71
72         Allow any https certificate when running tests.
73
74         * DumpRenderTree/win/DumpRenderTree.cpp:
75         (runTest):
76
77 2017-08-02  Youenn Fablet  <youenn@apple.com>
78
79         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
80         https://bugs.webkit.org/show_bug.cgi?id=175089
81
82         Reviewed by Chris Dumez.
83
84         * DumpRenderTree/TestOptions.mm:
85         (TestOptions::TestOptions): Using absolutePath if available.
86         * DumpRenderTree/mac/DumpRenderTree.mm:
87         (computeTestURL): Removing http/tests/ specific URL computation.
88         * Scripts/webkitpy/port/driver.py:
89         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
90
91 2017-08-02  Lucas Forschler  <lforschler@apple.com>
92
93         download-built-product should allow for a proxy option
94         https://bugs.webkit.org/show_bug.cgi?id=174875
95
96         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
97
98         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
99         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
100         
101
102 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
103
104         check-webkit-style: deleting lines in a file runs the linter on the whole file
105         https://bugs.webkit.org/show_bug.cgi?id=175078
106
107         Reviewed by David Kilzer.
108
109         Deleting lines in a file should not cause linter errors to be blamed on the patch.
110         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
111
112         * Scripts/webkitpy/style/checkers/test_expectations.py:
113         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
114         * Scripts/webkitpy/style/main_unittest.py:
115         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
116         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
117         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
118
119 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
120
121         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
122         https://bugs.webkit.org/show_bug.cgi?id=175075
123
124         Reviewed by David Kilzer.
125
126         We have no way of handling text files with illegal unicode characters. Allow the callers of
127         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
128         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
129
130         * Scripts/webkitpy/common/system/filesystem.py:
131         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
132         (FileSystem.write_text_file): Ditto.
133         * Scripts/webkitpy/common/system/filesystem_mock.py:
134         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
135         (MockFileSystem.write_text_file): Ditto.
136         * Scripts/webkitpy/common/system/filesystem_unittest.py:
137         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
138         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
139
140 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
141
142         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
143         https://bugs.webkit.org/show_bug.cgi?id=175072
144
145         Reviewed by Alexey Proskuryakov.
146
147         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
148         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
149
150 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
151
152         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
153         https://bugs.webkit.org/show_bug.cgi?id=175019
154
155         Reviewed by Darin Adler.
156
157         * TestWebKitAPI/CMakeLists.txt:
158
159 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
160
161         Enabling uploading archives to S3
162         https://bugs.webkit.org/show_bug.cgi?id=174198
163
164         Unreviewed unit test fix after r219235.
165
166         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
167
168 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
169
170         Fix JSCOnly ARM buildbots after r220047
171         https://bugs.webkit.org/show_bug.cgi?id=174993
172
173         Unreviewed fix after r220087.
174
175         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
176         (BuildAndRemoteJSCTestsFactory.__init__):
177
178 2017-08-01  Chris Dumez  <cdumez@apple.com>
179
180         Add initial support for navigator.sendBeacon
181         https://bugs.webkit.org/show_bug.cgi?id=175007
182         <rdar://problem/33547728>
183
184         Reviewed by Sam Weinig.
185
186         Enable the Beacon API at runtime in the context of layout tests since the
187         feature is currently disabled by default.
188
189         * DumpRenderTree/mac/DumpRenderTree.mm:
190         (enableExperimentalFeatures):
191         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
192         (WTR::InjectedBundle::beginTesting):
193         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
194         (WTR::TestRunner::setModernMediaControlsEnabled):
195         (WTR::TestRunner::setBeaconAPIEnabled):
196         * WebKitTestRunner/InjectedBundle/TestRunner.h:
197
198 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
199
200         Update Bot Watcher's Dashboard for Buildbot 0.9
201         https://bugs.webkit.org/show_bug.cgi?id=174777
202
203         Reviewed by Daniel Bates.
204
205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
206         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
207         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
208         in a dictionary.
209         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
210         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
212         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
213         (parseRevisionProperty): Ditto.
214         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
215         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
216         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
217         have changed in Buildbot 0.9.
218         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
219         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
220         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
221         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
222         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
223         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
224         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
225         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
226         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
227         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
229         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
230         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
231         (BuildbotQueue.prototype.get overviewURL): Ditto.
232         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
233         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
234         Buildbot 0.8 or 0.9.
235         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
236         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
237         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
238         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
239         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
240         Therefore we are fetching information for fixed number of build. 
241         Also iterating the loop incrementally since the build data is already reverse sorted.
242         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
243         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
244         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
245         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
246         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
247
248 2017-08-01  Devin Rousso  <drousso@apple.com>
249
250         Web Inspector: simplify WebInspector with WI
251         https://bugs.webkit.org/show_bug.cgi?id=175058
252
253         Reviewed by Joseph Pecoraro.
254
255         * Scripts/check-inspector-strings:
256         (extract_ui_strings):
257         * Scripts/extract-localizable-js-strings:
258
259 2017-08-01  Youenn Fablet  <youenn@apple.com>
260
261         Layout tests with 'https' suffix should be run over HTTPS
262         https://bugs.webkit.org/show_bug.cgi?id=174992
263
264         Reviewed by Chris Dumez.
265
266         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
267         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
268         Covered by corresponding unit tests.
269
270         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
271         (run_server):
272         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
273         (base_http_url):
274         (base_https_url):
275         (base_url): Deleted.
276         * Scripts/webkitpy/port/base.py:
277         (Port.to.web_platform_test_server_base_http_url):
278         (Port.to):
279         (Port.to.web_platform_test_server_base_https_url):
280         (Port.to.web_platform_test_server_base_url): Deleted.
281         * Scripts/webkitpy/port/driver.py:
282         (Driver.__init__):
283         (Driver.wpt_test_path_to_uri):
284         (Driver):
285         (Driver.http_test_path_to_uri):
286         (Driver.test_to_uri):
287         (Driver.uri_to_test):
288         * Scripts/webkitpy/port/driver_unittest.py:
289         (DriverTest.test_test_to_uri):
290         (DriverTest.test_uri_to_test):
291
292 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
293
294         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
295         https://bugs.webkit.org/show_bug.cgi?id=173998
296
297         Reviewed by Darin Adler.
298
299         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
300         detect mistakes in backward compatibility in the future when we change it.
301
302         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
303         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
304         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
305         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
306         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
307         internal key data slot.
308
309         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
310         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
311         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
312         (getNextMessage):
313         (TEST):
314         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
315         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
316         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
317         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
318         These are the pre-baked databases.
319         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
320         This is the actual test that do all the reads and comparisons.
321         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
322         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
323         IndexedDB new stuffs. Then it can be used to bake the database again.
324
325 2017-08-01  Brady Eidson  <beidson@apple.com>
326
327         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
328         https://bugs.webkit.org/show_bug.cgi?id=175030
329
330         Reviewed by Andy Estes.
331
332         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
333         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
334
335 2017-08-01  Brady Eidson  <beidson@apple.com>
336
337         Part 2 of: Rename DatabaseProcess to StorageProcess.
338         https://bugs.webkit.org/show_bug.cgi?id=174880
339
340         Reviewed by Andy Estes.
341
342         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
343         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
344         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
345         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
346         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
347         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
348         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
349         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
350
351 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
352
353         Fix JSCOnly ARM buildbots after r220047
354         https://bugs.webkit.org/show_bug.cgi?id=174993
355
356         Reviewed by Saam Barati.
357
358         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
359         (BuildAndRemoteJSCTestsFactory.__init__):
360
361 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
362
363         [WTF] Introduce Private Symbols
364         https://bugs.webkit.org/show_bug.cgi?id=174935
365
366         Reviewed by Darin Adler.
367
368         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
369         (TestWebKitAPI::TEST):
370
371 2017-07-30  Darin Adler  <darin@apple.com>
372
373         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
374         https://bugs.webkit.org/show_bug.cgi?id=130653
375
376         Reviewed by Antti Koivisto.
377
378         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
379         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
380         when calling frameDidChangeLocation.
381         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
382         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
383         thus causing mysterious failures of a couple of tests. There are two remaining issues:
384         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
385         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
386         same logic flaw that causes "top loading frame" to get set to one of the subframes in
387         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
388         loading, subframe starts loading. It would be good to clean that up some day, but for now
389         this patch makes the two work identically rather than changing both.
390         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
391
392 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
393
394         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
395         https://bugs.webkit.org/show_bug.cgi?id=174963
396
397         Reviewed by Darin Adler.
398
399         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
400         RetainPtr<>. This patch changes them to all use auto.
401
402         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
403         (TestWebKitAPI::TEST):
404
405 2017-07-30  Brady Eidson  <beidson@apple.com>
406
407         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
408         https://bugs.webkit.org/show_bug.cgi?id=174958
409
410         Reviewed by Darin Adler.
411
412         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
413         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
414         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
415         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
416         (runUntilTasksInFlight):
417         (TEST):
418
419 2017-07-28  Commit Queue  <commit-queue@webkit.org>
420
421         Unreviewed, rolling out r219990.
422         https://bugs.webkit.org/show_bug.cgi?id=174961
423
424         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
425         estes on #webkit).
426
427         Reverted changeset:
428
429         "Part 2 of: Rename DatabaseProcess to StorageProcess."
430         https://bugs.webkit.org/show_bug.cgi?id=174880
431         http://trac.webkit.org/changeset/219990
432
433 2017-07-28  Brady Eidson  <beidson@apple.com>
434
435         API tests that use URLSchemeHandler are failing.
436         https://bugs.webkit.org/show_bug.cgi?id=174950
437
438         Reviewed by Alex Christensen.
439
440         Fix the NoMIMEType test to be correct.
441
442         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
443         (-[SchemeHandler initWithData:mimeType:]):
444         (-[SchemeHandler webView:startURLSchemeTask:]):
445         (TEST):
446
447 2017-07-28  Daniel Bates  <dabates@apple.com>
448
449         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
450         https://bugs.webkit.org/show_bug.cgi?id=174876
451
452         Reviewed by Alex Christensen.
453
454         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
455         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
456         they provide a more direct way to test the platform abstraction.
457
458         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
459
460         * Scripts/prepare-ChangeLog:
461         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
462         of the current working directory.
463
464 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
465
466         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
467         https://bugs.webkit.org/show_bug.cgi?id=174930
468
469         Unreviewed test fix.
470
471         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
472
473         * Scripts/prepare-ChangeLog:
474         (get_function_line_ranges_for_cpp):
475
476 2017-07-28  JF Bastien  <jfbastien@apple.com>
477
478         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
479         https://bugs.webkit.org/show_bug.cgi?id=174930
480
481         Reviewed by Daniel Bates.
482
483         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
484         here also teach it about const and volatile overloads. I didn't do
485         reference and rvalue reference overloads because we don't really
486         use them, and the current parser throws away those characters and
487         it doesn't seem worth making it more complex.
488
489         * Scripts/prepare-ChangeLog:
490         (get_function_line_ranges_for_cpp):
491         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
492         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
493         (Foo::Arrow::arrow):
494         (Foo::Arrow::otherArrow):
495         (Foo::Arrow::otherArrow const):
496         (Foo::Arrow::otherArrow volatile):
497         (Foo::Arrow::otherArrow const volatile):
498
499 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
500
501         [GTK] Building with ENABLE_VIDEO=OFF fails
502         https://bugs.webkit.org/show_bug.cgi?id=174940
503
504         Reviewed by Alex Christensen.
505
506         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
507         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
508
509         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
510         (methodCallCallback): Add missing USE(GSTREAMER) guard.
511
512 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
513
514         [WPE] Implement EventSenderProxy in WTR
515         https://bugs.webkit.org/show_bug.cgi?id=173419
516
517         Reviewed by Žan Doberšek.
518
519         Add the implementation of EventSenderProxy to the WTR. This
520         allows us to extend the coverage of the test suite in WKWPE.
521
522         * WebKitTestRunner/EventSenderProxy.h:
523         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
524         libxkbcommon needed to deal with key events.
525         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
526         (WTR::EventSenderProxy::EventSenderProxy):
527         (WTR::senderButtonToWPEButton):
528         (WTR::EventSenderProxy::mouseDown):
529         (WTR::EventSenderProxy::mouseUp):
530         (WTR::EventSenderProxy::mouseMoveTo):
531         (WTR::EventSenderProxy::mouseScrollBy):
532         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
533         (WTR::EventSenderProxy::leapForward):
534         (WTR::wkEventModifiersToWPE):
535         (WTR::getXKBKeySymForKeyRef):
536         (WTR::EventSenderProxy::keyDown):
537         (WTR::EventSenderProxy::addTouchPoint):
538         (WTR::EventSenderProxy::updateTouchPoint):
539         (WTR::EventSenderProxy::setTouchModifier):
540         (WTR::EventSenderProxy::setTouchPointRadius):
541         (WTR::EventSenderProxy::getUpdatedTouchEvents):
542         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
543         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
544         (WTR::EventSenderProxy::touchStart):
545         (WTR::EventSenderProxy::touchMove):
546         (WTR::EventSenderProxy::touchEnd):
547         (WTR::EventSenderProxy::touchCancel):
548         (WTR::EventSenderProxy::clearTouchPoints):
549         (WTR::EventSenderProxy::releaseTouchPoint):
550         (WTR::EventSenderProxy::cancelTouchPoint):
551
552 2017-07-27  Brady Eidson  <beidson@apple.com>
553
554         Part 2 of: Rename DatabaseProcess to StorageProcess.
555         https://bugs.webkit.org/show_bug.cgi?id=174880
556
557         Reviewed by Andy Estes.
558
559         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
560         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
561         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
562         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
563         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
564         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
565         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
566         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
567
568 2017-07-26  Mark Lam  <mark.lam@apple.com>
569
570         Add ability to only run specific tests in run-javascriptcore-tests.
571         https://bugs.webkit.org/show_bug.cgi?id=174884
572
573         Reviewed by Saam Barati.
574
575         For example, if we only want to run testapi, we can do so as follows:
576             $ run-javascriptcore-tests --testapi
577
578         Previously, specifying --testapi effectively does nothing because we run all tests
579         by default.  Only --no-testapi had the effect of disabling the test set.  This
580         old behavior for --testapi is not very useful or meaningful.  We're now changing
581         it to mean that we will only run that test.
582
583         With this change, we can also run more than one set of tests.  For example, if we
584         only want to run testmasm and testair, we can do so as follows:
585             $ run-javascriptcore-tests --testmasm --testair
586
587         By default, if no specific test option is specified, run-javascriptcore-tests will
588         run all tests.
589
590         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
591         the mozilla tests (--mozilla-tests) even though both are run via the lower level
592         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
593         the other set will not run.  For example, the following only runs the mozilla tests:
594             $ run-javascriptcore-tests --mozilla-tests
595
596         Note also that --jit-stress-tests is not for choosing a different set of tests.
597         Instead, it is used for determining whether we run JIT'ed test configurations
598         on the jsc stress tests and mozilla tests.  As a result, specifying
599         --jit-stress-tests will not omit other tests.  For example, the following still
600         runs all tests:
601             $ run-javascriptcore-tests --jit-stress-tests
602
603         * Scripts/run-javascriptcore-tests:
604         (defaultStringForTestState):
605         (enableTestOrNot):
606         (runJSCStressTests):
607
608 2017-07-26  Mark Lam  <mark.lam@apple.com>
609
610         Make run-javascriptcore-test run testair, testb3, and testmasm.
611         https://bugs.webkit.org/show_bug.cgi?id=174837
612         <rdar://problem/33522927>
613
614         Reviewed by Saam Barati and Filip Pizlo.
615
616         1. Refactors code for running testapi so that we can use it to run other tests.
617         2. Added running of testmasm, testair, testb3.
618
619         Note: the existing testapi invocation code does not support remote invocation of
620         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
621         and testb3 also do not support remote invocation.  If we wish to add remote
622         invocation support, we should do that in a separate patch.
623
624         * Scripts/run-javascriptcore-tests:
625         (testPath):
626         (runTest):
627         (testapiPath): Deleted.
628
629 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
630
631         Remove duplicate code from Buildbot.js in dashboard
632         https://bugs.webkit.org/show_bug.cgi?id=174870
633
634         Reviewed by Daniel Bates.
635
636         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
637         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
638         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
639         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
640         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
641
642 2017-07-26  Brady Eidson  <beidson@apple.com>
643
644         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
645         https://bugs.webkit.org/show_bug.cgi?id=174851
646
647         Reviewed by Chris Dumez.
648
649         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
650         (TEST):
651
652 2017-07-26  Brian Burg  <bburg@apple.com>
653
654         Remove WEB_TIMING feature flag
655         https://bugs.webkit.org/show_bug.cgi?id=174795
656
657         Reviewed by Alex Christensen.
658
659         * Scripts/webkitperl/FeatureList.pm:
660         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
661
662 2017-07-26  Chris Dumez  <cdumez@apple.com>
663
664         Pressing the Escape key should not be a valid user gesture to enter fullscreen
665         https://bugs.webkit.org/show_bug.cgi?id=174864
666         <rdar://problem/33009088>
667
668         Reviewed by Geoffrey Garen.
669
670         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
671         WKTR.
672
673         * DumpRenderTree/mac/EventSendingController.mm:
674         (-[EventSendingController keyDown:withModifiers:withLocation:]):
675
676 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
677
678         Unreviewed, added Romain Bellessort to contributors.json.
679
680         * Scripts/webkitpy/common/config/contributors.json:
681
682 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
683
684         [WPE] WebGL2 support
685         https://bugs.webkit.org/show_bug.cgi?id=174249
686
687         Reviewed by Alex Christensen.
688
689         * Scripts/webkitperl/FeatureList.pm:
690         Enable WebGL2 for WPE when building through build-webkit.
691
692 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
693
694         Unreviewed. Fix GTK distcheck.
695
696         * gtk/make-dist.py:
697         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
698
699 2017-07-25  Brady Eidson  <beidson@apple.com>
700
701         ResourceLoadStatistics grandfathering happens much too often.
702         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
703
704         Reviewed by Chris Dumez.
705
706         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
707         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
708         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
709         (TEST):
710
711 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
712
713         Fix autoinstaller failing on autoinstall_everything
714         https://bugs.webkit.org/show_bug.cgi?id=174830
715
716         Reviewed by Joseph Pecoraro.
717
718         * Scripts/webkitpy/thirdparty/__init__.py:
719         (AutoinstallImportHook.find_module):
720         (AutoinstallImportHook.install_chromedriver):
721         (AutoinstallImportHook.install_geckodriver):
722         (AutoinstallImportHook._install_chromedriver): Deleted.
723         (AutoinstallImportHook._install_geckodriver): Deleted.
724
725 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
726
727         Replace --runtime with something for both ios-simulator and ios-device
728         https://bugs.webkit.org/show_bug.cgi?id=173775
729         <rdar://problem/32952164>
730
731         Reviewed by Aakash Jain.
732
733         Add --version flag for both iOS simulator and iOS device.
734
735         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
736         (parse_args): Add --version flag and move --no-install.
737         * Scripts/webkitpy/port/factory.py:
738         (platform_options): Move --no-intall to run_webkit_tests.py.
739         * Scripts/webkitpy/port/ios.py:
740         (IOSPort):
741         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
742         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
743         * Scripts/webkitpy/port/ios_device.py:
744         (IOSDevicePort.ios_version): Consult --version flag before checking connected
745         devices for iOS version.
746         * Scripts/webkitpy/port/ios_device_unittest.py:
747         (IOSDeviceTest.make_port): Set --version option so that we can generate test
748         expectation paths without devices connected.
749         (IOSDeviceTest.test_additional_platform_directory): Deleted.
750         (IOSDeviceTest.test_baseline_searchpath): Deleted.
751         (IOSDeviceTest.test_expectations_ordering): Deleted.
752         * Scripts/webkitpy/port/ios_simulator.py:
753         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
754         flag to specify a runtime.
755         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
756         flag and then use the default runtime.
757
758 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
759
760         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
761         https://bugs.webkit.org/show_bug.cgi?id=174815
762
763         Reviewed by Carlos Alberto Lopez Perez.
764
765         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
766         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
767         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
768         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
769         think), probably because of a newer CMake version.
770
771         * CMakeLists.txt:
772         * TestWebKitAPI/CMakeLists.txt:
773         * TestWebKitAPI/PlatformGTK.cmake:
774
775 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
776
777         Fix BenchmarkRunner to only import selenium when needed
778         https://bugs.webkit.org/show_bug.cgi?id=174808
779
780         Reviewed by Stephanie Lewis.
781
782         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
783         (LinuxChromeDriver.launch_driver):
784         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
785         (LinuxFirefoxDriver.launch_driver):
786         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
787         (OSXChromeDriver.launch_driver):
788         (OSXChromeCanaryDriver.launch_driver):
789         (create_chrome_options):
790         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
791         (OSXFirefoxDriver.launch_driver):
792         (OSXFirefoxNightlyDriver.launch_driver):
793         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
794         (OSXSafariDriver.launch_driver):
795         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
796         (WebDriverBenchmarkRunner._run_one_test):
797
798 2017-07-23  Darin Adler  <darin@apple.com>
799
800         More NeverDestroyed and related cleanup
801         https://bugs.webkit.org/show_bug.cgi?id=174745
802
803         Reviewed by Alex Christensen.
804
805         * DumpRenderTree/JavaScriptThreading.cpp:
806         (javaScriptThreadsMutex): Use NeverDestroyed instead of
807         DEPRECATED_DEFINE_STATIC_LOCAL.
808         (javaScriptThreads): Ditto.
809
810 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
811
812         Subclass Benchmark Runner script for WebDriver support
813         https://bugs.webkit.org/show_bug.cgi?id=174390
814
815         Reviewed by Dewei Zhu, Stephanie Lewis.
816
817         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
818
819         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
820         (BenchmarkBuilder.__init__):
821         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
822         (BenchmarkRunner.__init__):
823         (BenchmarkRunner._find_plan_file):
824         (BenchmarkRunner._run_one_test.and):
825         (BenchmarkRunner.execute):
826         (BenchmarkRunner._get_result): Deleted.
827         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
828         (parse_args):
829         (start):
830         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
831         (WebDriverBenchmarkRunner):
832         (WebDriverBenchmarkRunner._get_result):
833         (WebDriverBenchmarkRunner._run_one_test):
834         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
835         (WebServerBenchmarkRunner):
836         (WebServerBenchmarkRunner.__init__):
837         (WebServerBenchmarkRunner._get_result):
838         (WebServerBenchmarkRunner._run_one_test):
839
840 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
841
842         Add BenchmarkRunner patches with WebDriver support for each testing plan
843         https://bugs.webkit.org/show_bug.cgi?id=174443
844
845         Reviewed by Dewei Zhu, Stephanie Lewis.
846
847         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
848         (BenchmarkBuilder.__enter__):
849         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
850         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
851         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
852         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
853         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
854         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
855         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
856         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
857         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
858         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
859         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
860         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
861         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
862         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
863         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
864         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
865         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
866         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
867         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
868         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
869         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
870         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
871         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
872         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
873         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
874         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
875         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
876         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
877         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
878         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
879         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
880         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
881         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
882
883 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
884
885         Add functions to autoinstaller needed for Benchmark Runner script
886         https://bugs.webkit.org/show_bug.cgi?id=174331
887
888         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
889
890         Adds autoinstaller functions to install selenium and webdriver binaries
891         which will be used by the browser driver part of Benchmark Runner.
892
893         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
894         (BrowserDriver.restore_env):
895         (BrowserDriver):
896         (BrowserDriver.get_webdriver_binary_path):
897         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
898         (LinuxChromeDriver.launch_driver):
899         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
900         (LinuxFirefoxDriver.launch_driver):
901         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
902         (OSXChromeDriver.launch_driver):
903         (OSXChromeCanaryDriver.launch_driver):
904         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
905         (OSXFirefoxDriver.launch_driver):
906         (OSXFirefoxNightlyDriver.launch_driver):
907         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
908         * Scripts/webkitpy/benchmark_runner/utils.py:
909         (get_driver_binary_path):
910         * Scripts/webkitpy/common/system/autoinstall.py:
911         (AutoInstaller._unzip):
912         * Scripts/webkitpy/thirdparty/__init__.py:
913         (AutoinstallImportHook.find_module):
914         (AutoinstallImportHook._install_selenium):
915         (AutoinstallImportHook):
916         (AutoinstallImportHook._install_chromedriver):
917         (AutoinstallImportHook._install_geckodriver):
918         (AutoinstallImportHook.get_latest_pypi_url):
919         (AutoinstallImportHook.install_binary):
920         (autoinstall_everything):
921         (get_driver_filename):
922         (get_os_info):
923
924 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
925
926         Add WebDriver support in browser driver part of BenchmarkRunner
927         https://bugs.webkit.org/show_bug.cgi?id=174445
928
929         Reviewed by Stephanie Lewis.
930
931         Adds a launch_driver function to each BrowserDriver subclass. This
932         function sets up the arguments for the webdriver and launches the
933         webdriver specific to that browser.
934
935         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
936         (BrowserDriver.launch_webdriver):
937         (BrowserDriver):
938         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
939         (LinuxBrowserDriver.launch_webdriver):
940         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
941         (LinuxChromeDriver.launch_url):
942         (LinuxChromeDriver):
943         (LinuxChromeDriver.launch_driver):
944         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
945         (EpiphanyBrowserDriver.launch_url):
946         (EpiphanyBrowserDriver):
947         (EpiphanyBrowserDriver.launch_driver):
948         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
949         (LinuxFirefoxDriver):
950         (LinuxFirefoxDriver.launch_url):
951         (LinuxFirefoxDriver.launch_driver):
952         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
953         (GTKMiniBrowserDriver.launch_url):
954         (GTKMiniBrowserDriver):
955         (GTKMiniBrowserDriver.launch_driver):
956         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
957         (OSXBrowserDriver._launch_webdriver):
958         (OSXBrowserDriver):
959         (OSXBrowserDriver._screen_size):
960         (OSXBrowserDriver._insert_url):
961         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
962         (OSXChromeDriver):
963         (OSXChromeDriver.launch_url):
964         (OSXChromeDriver.launch_driver):
965         (OSXChromeCanaryDriver):
966         (OSXChromeCanaryDriver.launch_url):
967         (OSXChromeCanaryDriver.launch_driver):
968         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
969         (OSXFirefoxDriver):
970         (OSXFirefoxDriver.launch_url):
971         (OSXFirefoxDriver.launch_driver):
972         (OSXFirefoxNightlyDriver):
973         (OSXFirefoxNightlyDriver.launch_url):
974         (OSXFirefoxNightlyDriver.launch_driver):
975         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
976         (OSXSafariDriver.launch_driver):
977
978 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
979
980         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
981         https://bugs.webkit.org/show_bug.cgi?id=174793
982
983         Reviewed by Tim Horton.
984
985         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
986         down. Without r219765, this test will dereference null and crash.
987
988         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
989         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
990         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
991         (TEST):
992
993 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
994
995         [Win] Implement Authentication dialog in MiniBrowser
996         https://bugs.webkit.org/show_bug.cgi?id=174662
997
998         Reviewed by Alex Christensen.
999
1000         * MiniBrowser/win/Common.cpp:
1001         (CustomUserAgent):
1002         (DisplayAuthDialog):
1003         (AuthDialogProc):
1004         * MiniBrowser/win/MiniBrowserLib.rc:
1005         * MiniBrowser/win/MiniBrowserLibResource.h:
1006         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1007         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1008
1009 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
1010
1011         Handle case where line_numbers is None instead of an array of line numbers
1012         https://bugs.webkit.org/show_bug.cgi?id=174775
1013
1014         Reviewed by Aakash Jain.
1015
1016         Added files set line_numbers to None in process_file.
1017
1018         * Scripts/webkitpy/style/filereader.py:
1019         (TextFileReader.process_file): Handle case where line_number is set to None.
1020         * Scripts/webkitpy/style/main_unittest.py:
1021         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
1022
1023 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1024
1025         [WPE] Add libepoxy to the Jhbuild moduleset
1026         https://bugs.webkit.org/show_bug.cgi?id=174711
1027
1028         Reviewed by Carlos Alberto Lopez Perez.
1029
1030         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
1031
1032 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
1033
1034         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
1035         https://bugs.webkit.org/show_bug.cgi?id=174780
1036
1037         Reviewed by Carlos Garcia Campos.
1038
1039         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1040         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
1041         in case the eglplatform.h header doesn't provide that macro. This replicates
1042         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
1043
1044 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1045
1046         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
1047         https://bugs.webkit.org/show_bug.cgi?id=174758
1048
1049         Reviewed by Dan Bernstein.
1050
1051         Migrate position-information-related unit tests from the PositionInformationTests suite to
1052         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
1053
1054         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1055         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
1056         (TestWebKitAPI::checkElementTypeAndBoundingRect):
1057         (TestWebKitAPI::TEST):
1058         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
1059         * TestWebKitAPI/cocoa/TestWKWebView.h:
1060         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1061         (-[TestWKWebView activatedElementAtPosition:]):
1062
1063 2017-07-22  Chris Dumez  <cdumez@apple.com>
1064
1065         REGRESSION(r204565): WKObject is broken
1066         https://bugs.webkit.org/show_bug.cgi?id=174736
1067         <rdar://problem/33246169>
1068
1069         Reviewed by Dan Bernstein.
1070
1071         Add API test that used to crash.
1072
1073         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1074         (TestWebKitAPI::TEST):
1075
1076 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1077
1078         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
1079         https://bugs.webkit.org/show_bug.cgi?id=174705
1080
1081         Reviewed by Mark Lam.
1082
1083         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
1084         (TestWebKitAPI::testThreadGroup):
1085         (TestWebKitAPI::TEST):
1086
1087 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
1088
1089         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
1090         https://bugs.webkit.org/show_bug.cgi?id=174724
1091
1092         Reviewed by Aakash Jain.
1093
1094         * Scripts/webkitpy/port/ios_simulator.py:
1095         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
1096         simulator. Errors here should be treated the same as no simulators found.
1097
1098 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
1099
1100         [CMake] Add an option to stop build after generating project files
1101         https://bugs.webkit.org/show_bug.cgi?id=174664
1102
1103         Reviewed by Konstantin Tokarev.
1104
1105         Add "--generate-project-only" to stop build after generating project files.
1106
1107         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
1108         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
1109         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
1110         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
1111         (isGenerateProjectOnly): ditto
1112
1113 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
1114
1115         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1116         https://bugs.webkit.org/show_bug.cgi?id=174501
1117
1118         Reviewed by Darin Adler.
1119
1120         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1121         (TestWebKitAPI::TEST):
1122
1123 2017-07-20  David Quesada  <david_quesada@apple.com>
1124
1125         Add SPI to notify WKNavigationDelegate about client redirects
1126         https://bugs.webkit.org/show_bug.cgi?id=174680
1127         rdar://problem/33184886
1128
1129         Reviewed by Brady Eidson.
1130
1131         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1132         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
1133         (TEST):
1134         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
1135
1136 2017-07-20  Brady Eidson  <beidson@apple.com>
1137
1138         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
1139         https://bugs.webkit.org/show_bug.cgi?id=174685
1140
1141         Reviewed by Andy Estes.
1142
1143         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1144         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
1145
1146 2017-07-20  Brady Eidson  <beidson@apple.com>
1147
1148         Deprecate WebIconDatabase in WebKitLegacy/mac.
1149         https://bugs.webkit.org/show_bug.cgi?id=174607
1150
1151         Reviewed by Alex Christensen.
1152
1153         * DumpRenderTree/mac/TestRunnerMac.mm:
1154
1155 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
1156
1157         lint-test-expectations should be run during style checking
1158         https://bugs.webkit.org/show_bug.cgi?id=173559
1159         <rdar://problem/32854941>
1160
1161         Reviewed by Aakash Jain.
1162
1163         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1164         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
1165         prevents identifying errors on specific lines in a file.
1166         * Scripts/webkitpy/style/main_unittest.py:
1167         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
1168         case where a linter error is in the file modified, but the line modified is not related to
1169         the linter error.
1170
1171 2017-07-20  Brady Eidson  <beidson@apple.com>
1172
1173         Remove WebIconDatabase from WebKitLegacy/win.
1174         https://bugs.webkit.org/show_bug.cgi?id=174608
1175
1176         Reviewed by Alex Christensen.
1177
1178         * DumpRenderTree/win/DumpRenderTree.cpp:
1179         (main):
1180         * DumpRenderTree/win/TestRunnerWin.cpp:
1181         (TestRunner::setIconDatabaseEnabled):
1182
1183 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
1184
1185         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
1186         https://bugs.webkit.org/show_bug.cgi?id=174671
1187
1188         Reviewed by Carlos Garcia Campos.
1189
1190         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1191         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
1192         priority for this source in order to have it dispatched on the same
1193         priority as the other WebKit-controlled GSource objects.
1194
1195 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1196
1197         lint-test-expectations should be run during style checking
1198         https://bugs.webkit.org/show_bug.cgi?id=173559
1199         <rdar://problem/32854941>
1200
1201         Reviewed by Daniel Bates.
1202
1203         Follow up fix addressing style and a few minor bugs.
1204
1205         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1206         (TestExpectationParser.__init__): Use lambda x: x instead of str
1207         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
1208         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
1209         reduce the calls of _shorten_filename, fix minor bug in appending the current
1210         expectation's line number instead of the previous ones, clarify treatment of None
1211         in file-to-line-number mapping.
1212         (TestExpectations._report_warnings): Collapse call.
1213         * Scripts/webkitpy/style/checkers/test_expectations.py:
1214         (TestExpectationsChecker.lint_test_expectations):
1215         * Scripts/webkitpy/style/filereader.py: Re-write comment.
1216         (TextFileReader.process_file): Add comment explaining treatment of None in
1217         file-to-line-number mapping.
1218         (TextFileReader.delete_file): Collapse call.
1219
1220 2017-07-19  Chris Dumez  <cdumez@apple.com>
1221
1222         Unreviewed attempt to fix API test failure after r219663.
1223
1224         The test was hard-coding an exception string and the string has changed slightly
1225         in r219663.
1226
1227         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1228         (TEST):
1229
1230 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
1231
1232         Don't write file URLs to iOS Pasteboard
1233         https://bugs.webkit.org/show_bug.cgi?id=174647
1234         <rdar://problem/33199730>
1235
1236         Reviewed by Wenson Hsieh.
1237
1238         Updating tests to reflect the lack of file URLs for images.
1239
1240         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1241         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
1242         (checkEstimatedSize):
1243         (TestWebKitAPI::TEST):
1244
1245 2017-07-19  Brady Eidson  <beidson@apple.com>
1246
1247         iBooks sometimes crashes when closing a book.
1248         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
1249
1250         Reviewed by Oliver Hunt.
1251
1252         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1253         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
1254         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
1255         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
1256         (TestWebKitAPI::TEST):
1257
1258         Add a "spin the runloop X number of times" utility:
1259         * TestWebKitAPI/Utilities.h:
1260         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1261         (TestWebKitAPI::Util::spinRunLoop):
1262
1263 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
1264
1265         lint-test-expectations should be run during style checking
1266         https://bugs.webkit.org/show_bug.cgi?id=173559
1267         <rdar://problem/32854941>
1268
1269         Reviewed by David Kilzer.
1270
1271         Running the test expectation linter requires reading both files and lines not in the
1272         patch because, for example, deletion of a test can cause a lint failure even though
1273         no test expectations where modified. This means that the linter will occasionally warn
1274         about lines which were not changed in a given patch but whose error is related to a
1275         change made in that patch.
1276
1277         * Scripts/webkitpy/common/system/filesystem_mock.py:
1278         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
1279         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1280         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
1281         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
1282         content, description of the error and the name of the associated test.
1283         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
1284         (TestExpectationParser.__init__): Pass shorten_filename function to
1285         TestExpectationsParser to add a deleted file to the related_files dictionary.
1286         (TestExpectationParser._check_test_exists): If the test does not exist, add the
1287         missing path to the related_files dictionary.
1288         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
1289         files and line numbers related to this test expectation line. This will allow
1290         tracking linter errors in the style checker occurring across multiple files.
1291         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
1292         lines to related_files dictionary.
1293         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
1294         (TestExpectations._report_warnings): Construct warning object instead of string
1295         when adding to warnings list.
1296         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
1297         clean-up log.
1298         * Scripts/webkitpy/style/checker.py:
1299         (ProcessorBase.do_association_check): Add required function for processor classes.
1300         (StyleProcessor):
1301         (StyleProcessor.do_association_check): Run the TestExpectations linter when
1302         checking for errors between associated files.
1303         * Scripts/webkitpy/style/checkers/test_expectations.py:
1304         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
1305         (TestExpectationsChecker):
1306         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
1307         of modified files, the current working directory and the host, determine if the linter
1308         warning is associated with the changes.
1309         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
1310         style checker.
1311         * Scripts/webkitpy/style/filereader.py:
1312         (TextFileReader):
1313         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
1314         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
1315         (TextFileReader.process_file): Track both the number of files changed and which lines
1316         in those files were changed.
1317         (TextFileReader.do_association_check): Run the processor's association check on all
1318         modified or deleted files processed by TextFileReader.
1319         (TextFileReader.delete_file): Track deleted files in _files dictionary.
1320         (TextFileReader.count_delete_only_file): Deleted.
1321         * Scripts/webkitpy/style/filereader_unittest.py:
1322         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
1323         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
1324         * Scripts/webkitpy/style/main.py:
1325         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
1326         explicitly run the association check on the file reader.
1327         * Scripts/webkitpy/style/main_unittest.py:
1328         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
1329         embedded in the style checker.
1330         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
1331         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
1332         construct the TextFileReader object with a StyleProcessor used to run style checks on
1333         specific files.
1334         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
1335         testing the test expectation linter inside the style checker. This host must contain a
1336         mock file system with the basic structure of test expectations.
1337         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
1338         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
1339         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
1340         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
1341         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
1342         * Scripts/webkitpy/style/patchreader.py:
1343         (PatchReader.check): Specify which file was deleted, run the association check.
1344         * Scripts/webkitpy/style/patchreader_unittest.py:
1345         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
1346         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
1347         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
1348
1349 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1350
1351         [WTF] Implement WTF::ThreadGroup
1352         https://bugs.webkit.org/show_bug.cgi?id=174081
1353
1354         Reviewed by Mark Lam.
1355
1356         Add WTF::ThreadGroup tests.
1357
1358         * TestWebKitAPI/CMakeLists.txt:
1359         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1360         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
1361         (TestWebKitAPI::testThreadGroup):
1362         (TestWebKitAPI::TEST):
1363
1364 2017-07-18  Andy Estes  <aestes@apple.com>
1365
1366         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
1367         https://bugs.webkit.org/show_bug.cgi?id=174631
1368
1369         Reviewed by Tim Horton.
1370
1371         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1372         * MiniBrowser/Configurations/Base.xcconfig:
1373         * MobileMiniBrowser/Configurations/Base.xcconfig:
1374         * TestWebKitAPI/Configurations/Base.xcconfig:
1375         * WebKitTestRunner/Configurations/Base.xcconfig:
1376
1377 2017-07-18  Andy Estes  <aestes@apple.com>
1378
1379         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
1380         https://bugs.webkit.org/show_bug.cgi?id=174631
1381
1382         Reviewed by Sam Weinig.
1383
1384         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1385         * MiniBrowser/Configurations/Base.xcconfig:
1386         * MobileMiniBrowser/Configurations/Base.xcconfig:
1387         * TestWebKitAPI/Configurations/Base.xcconfig:
1388         * WebKitTestRunner/Configurations/Base.xcconfig:
1389
1390 2017-07-18  Daniel Bates  <dabates@apple.com>
1391
1392         lldb: Add type summary for StringView
1393         https://bugs.webkit.org/show_bug.cgi?id=174637
1394
1395         Reviewed by Sam Weinig.
1396
1397         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
1398         StringView object will print output that has the form:
1399
1400             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
1401               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
1402               m_length = 2
1403               m_is8Bit = true
1404               m_underlyingString = 0x0000614000000a90
1405             }
1406
1407         * lldb/lldb_webkit.py:
1408         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
1409         (WTFStringView_SummaryProvider):
1410         (WTFStringViewProvider):
1411         (WTFStringViewProvider.__init__):
1412         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
1413         (WTFStringViewProvider.get_length): Access field StringView.m_length.
1414         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
1415         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
1416
1417 2017-07-18  Andy Estes  <aestes@apple.com>
1418
1419         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
1420         https://bugs.webkit.org/show_bug.cgi?id=174631
1421
1422         Reviewed by Dan Bernstein.
1423
1424         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1425         * MiniBrowser/Configurations/Base.xcconfig:
1426         * MobileMiniBrowser/Configurations/Base.xcconfig:
1427         * TestWebKitAPI/Configurations/Base.xcconfig:
1428         * WebKitTestRunner/Configurations/Base.xcconfig:
1429
1430 2017-07-18  Devin Rousso  <drousso@apple.com>
1431
1432         Web Inspector: Add memoryCost to Inspector Protocol objects
1433         https://bugs.webkit.org/show_bug.cgi?id=174478
1434
1435         Reviewed by Joseph Pecoraro.
1436
1437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1438         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
1439         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
1440         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
1441         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
1442         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
1443         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
1444         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
1445         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
1446         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
1447         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
1448         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
1449         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
1450         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
1451         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
1452         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
1453         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
1454
1455 2017-07-18  Andy Estes  <aestes@apple.com>
1456
1457         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
1458         https://bugs.webkit.org/show_bug.cgi?id=174631
1459
1460         Reviewed by Darin Adler.
1461
1462         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1463         * MiniBrowser/Configurations/Base.xcconfig:
1464         * MobileMiniBrowser/Configurations/Base.xcconfig:
1465         * TestWebKitAPI/Configurations/Base.xcconfig:
1466         * WebKitTestRunner/Configurations/Base.xcconfig:
1467
1468 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1469
1470         Unreviewed, fix the iOS build.
1471
1472         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
1473
1474         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1475         (TestWebKitAPI::TEST):
1476
1477 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1478
1479         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
1480         https://bugs.webkit.org/show_bug.cgi?id=174585
1481         <rdar://problem/33302541>
1482
1483         Reviewed by Tim Horton.
1484
1485         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
1486         being dragged when initiating a drag.
1487
1488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1489         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
1490         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1491         (TestWebKitAPI::TEST):
1492         * TestWebKitAPI/cocoa/TestWKWebView.h:
1493
1494         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
1495
1496         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1497         (-[TestWKWebView synchronouslyLoadHTMLString:]):
1498
1499 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1500
1501         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
1502         https://bugs.webkit.org/show_bug.cgi?id=174547
1503
1504         Reviewed by Alex Christensen.
1505
1506         * DumpRenderTree/PlatformWin.cmake:
1507         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1508
1509 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1510
1511         Update style checker to deal with "final"
1512         https://bugs.webkit.org/show_bug.cgi?id=174528
1513
1514         Reviewed by Alex Christensen.
1515         
1516         check-webkit-style shouldn't complain about an open brace to start a
1517         line after a function definition with "final" or "const final".
1518
1519         * Scripts/webkitpy/style/checkers/cpp.py:
1520         (check_braces):
1521         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1522         (CppStyleTest.test_brace_at_begin_of_line):
1523
1524 2017-07-17  Alex Christensen  <achristensen@webkit.org>
1525
1526         Modernize content extension code
1527         https://bugs.webkit.org/show_bug.cgi?id=174588
1528
1529         Reviewed by Sam Weinig.
1530
1531         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1532         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1533         (TestWebKitAPI::testRequest):
1534         (TestWebKitAPI::makeBackend):
1535         (TestWebKitAPI::TEST_F):
1536
1537 2017-07-17  Brady Eidson  <beidson@apple.com>
1538
1539         WKHTTPCookieStore observing only works on the default cookie store.
1540         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
1541
1542         Reviewed by Sam Weinig.
1543
1544         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1545         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
1546           called for the default store, a non-persistent store, and a custom store.
1547         (TEST):
1548
1549 2017-07-16  Sam Weinig  <sam@webkit.org>
1550
1551         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
1552         https://bugs.webkit.org/show_bug.cgi?id=174575
1553
1554         Reviewed by Brady Eidson.
1555
1556         * Scripts/svn-create-patch:
1557         (findModificationType):
1558         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
1559         default value of "unknown".
1560
1561         (generateFileList):
1562         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
1563         for untracked, which matches our old behavior.
1564
1565 2017-07-17  Charlie Turner  <cturner@igalia.com>
1566
1567         Add some missing build dependencies on Fedora
1568         https://bugs.webkit.org/show_bug.cgi?id=174578
1569
1570         Unreviewed dependency update.
1571
1572         * gtk/install-dependencies:
1573
1574 2017-07-16  Brady Eidson  <beidson@apple.com>
1575
1576         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
1577         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
1578
1579         Reviewed by Tim Horton.
1580
1581         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1582         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
1583         (TEST):
1584
1585 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
1586
1587         [GTK] Sort inspector GResource manifest to ensure reproducible builds
1588         https://bugs.webkit.org/show_bug.cgi?id=174540
1589
1590         Reviewed by Michael Catanzaro.
1591
1592         * gtk/generate-inspector-gresource-manifest.py:
1593         (get_filenames): sort list of input files
1594
1595 2017-07-15  Brady Eidson  <beidson@apple.com>
1596
1597         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
1598         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
1599
1600         Reviewed by Tim Horton.
1601
1602         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1603         (TEST): Make this test more reliable by clearing everything beforehand.
1604
1605 2017-07-15  David Kilzer  <ddkilzer@apple.com>
1606
1607         Make it possible to extend check-webkit-style with Apple-internal checkers
1608         <https://webkit.org/b/174464>
1609         <rdar://problem/25564402>
1610
1611         Reviewed by Darin Adler.
1612
1613         * Scripts/webkitpy/style/checker.py: Import apple_additions.
1614         (_all_categories): Add categories from apple_additions() if it
1615         exists.
1616         (CheckerDispatcher._create_checker): Create python checker
1617         from apple_additions() if it exists.
1618
1619 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1620
1621         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
1622         https://bugs.webkit.org/show_bug.cgi?id=174539
1623         <rdar://problem/33307395>
1624
1625         Reviewed by Darin Adler.
1626
1627         Adds a new unit test suite to cover action sheet popover presentation.
1628
1629         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1630         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
1631         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
1632         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
1633
1634         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
1635
1636         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
1637         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1638
1639         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
1640
1641         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1642         (TestWebKitAPI::TEST):
1643
1644 2017-07-15  Sam Weinig  <sam@webkit.org>
1645
1646         [Scripts] Make svn-create-patch work better when called in sub directories
1647         https://bugs.webkit.org/show_bug.cgi?id=174551
1648
1649         Reviewed by Darin Adler.
1650
1651         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
1652           by ensuring that the prefix is applied as is done in generateDiff.
1653         - Silence output of explanatory lines from svn stat (" > move to ...")
1654           that show up in STDERR when running svn-create-patch.
1655         - Add verbose logging that I found useful while debugging this issue.
1656
1657         * Scripts/svn-create-patch:
1658         (findBaseUrl):
1659         (findMimeType):
1660         (findSourceFileAndRevision):
1661         (generateDiff):
1662         (generateFileList):
1663         (manufacturePatchForAdditionWithHistory):
1664
1665 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
1666
1667         Unreviewed build fix after r219537.
1668
1669         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1670
1671 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1672
1673         Add iOS 11 SPI
1674         https://bugs.webkit.org/show_bug.cgi?id=174430
1675         <rdar://problem/33269288>
1676
1677         Reviewed by Tim Horton.
1678
1679         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
1680         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
1681         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
1682
1683 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1684
1685         Failing to install on iPad simulators
1686         https://bugs.webkit.org/show_bug.cgi?id=174532
1687         <rdar://problem/33328347>
1688
1689         Reviewed by Stephanie Lewis.
1690
1691         * Scripts/webkitpy/xcode/simulated_device.py:
1692         (SimulatedDevice.install_app): Place install command in retry try-except block.
1693
1694 2017-07-14  Jeff Miller  <jeffm@apple.com>
1695
1696         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1697         https://bugs.webkit.org/show_bug.cgi?id=174524
1698
1699         Reviewed by Sam Weinig.
1700
1701         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
1702         (TEST):
1703         Renamed TestParameter to TestParameter1.
1704         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
1705
1706         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
1707         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1708         Observe changes for two bundle parameters.
1709
1710         (-[BundleParametersPlugIn dealloc]):
1711         Remove observers for two bundle parameters.
1712
1713 2017-07-14  Commit Queue  <commit-queue@webkit.org>
1714
1715         Unreviewed, rolling out r219510.
1716         https://bugs.webkit.org/show_bug.cgi?id=174525
1717
1718         Need to revert length() == 0 check for null string (Requested
1719         by yusukesuzuki on #webkit).
1720
1721         Reverted changeset:
1722
1723         "[WTF] Newly added AtomicStringImpl should use BufferInternal
1724         static string if StringImpl is static"
1725         https://bugs.webkit.org/show_bug.cgi?id=174501
1726         http://trac.webkit.org/changeset/219510
1727
1728 2017-07-14  Jer Noble  <jer.noble@apple.com>
1729
1730         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
1731         https://bugs.webkit.org/show_bug.cgi?id=174514
1732
1733         Reviewed by Sam Weinig.
1734
1735         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
1736         (TestWebKitAPI::TEST_F):
1737
1738 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1739
1740         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
1741         https://bugs.webkit.org/show_bug.cgi?id=174501
1742
1743         Reviewed by Darin Adler.
1744
1745         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1746         (TestWebKitAPI::TEST):
1747
1748 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
1749
1750         Bring mac expectations in-line with other platforms
1751         https://bugs.webkit.org/show_bug.cgi?id=174472
1752         <rdar://problem/33297388>
1753
1754         Reviewed by David Kilzer.
1755
1756         The override order for Mac test expectations does not conform to the pattern used by iOS,
1757         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
1758
1759             platform/mac-wk2
1760             platform/wk2
1761             platform/mac-elcapitan
1762             platform/mac-sierra
1763             generic
1764
1765         After this change, El Capitan's baseline search path looks like this:
1766
1767             platform/mac-sierra-wk2
1768             platform/mac-sierra
1769             platform/mac-wk2
1770             platform/wk2
1771             generic
1772
1773         * Scripts/webkitpy/port/mac.py:
1774         (MacPort.__init__): If a specific version is specified in the port name, use that
1775         as the os version.
1776         (MacPort.default_baseline_search_path): Expectation search paths should work the
1777         same way they do on other ports. Port + version overrides port, port overrides generic
1778         and wk1/wk2 should override expectations for the two combined.
1779         * Scripts/webkitpy/port/mac_unittest.py:
1780         (MacTest.test_tests_for_other_platforms): Deleted.
1781         (MacTest._assert_search_path): Deleted.
1782         (MacTest.test_baseline_search_path): Deleted.
1783         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1784         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
1785         (test_rebaseline_test_and_print_scm_changes): Ditto.
1786         (test_rebaseline_and_copy_test): Ditto.
1787         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
1788         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
1789         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
1790
1791 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1792
1793         Fix style checker unit test
1794
1795         Unreviewed WebKit2 => WebKit fixup.
1796
1797         * Scripts/webkitpy/style/checker_unittest.py:
1798         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
1799
1800 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1801
1802         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
1803
1804         Unreviewed build fix.
1805
1806         r219492 missed one hunk from its partial revert of r219489.
1807         This patch reverts that hunk.
1808
1809         * TestWebKitAPI/CMakeLists.txt:
1810
1811 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1812
1813         Use the old WebKit/WebKit2 targets for CMake builds.
1814
1815         Unreviewed build fix.
1816
1817         We can update the target names to match the Framework names in a future patch.
1818         This is a partial revert of r219489.
1819
1820         * TestWebKitAPI/CMakeLists.txt:
1821         WebKitLegacy => WebKit
1822         WebKit => WebKit2
1823
1824 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1825
1826         Fix TestWebKit API.
1827         https://bugs.webkit.org/show_bug.cgi?id=174164
1828         rdar://problem/33137595
1829
1830         Reviewed by Dan Bernstein.
1831
1832         * TestWebKitAPI/CMakeLists.txt:
1833         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1834         * TestWebKitAPI/PlatformGTK.cmake:
1835
1836 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
1837
1838         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
1839         https://bugs.webkit.org/show_bug.cgi?id=174164
1840         rdar://problem/33137595
1841
1842         Reviewed by Dan Bernstein.
1843
1844         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1845         (ShouldBuildTest):
1846         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1847         * Scripts/build-webkit:
1848         * Scripts/do-file-rename:
1849         * Scripts/do-webcore-rename:
1850         * Scripts/update-webkit-localizable-strings:
1851         * Scripts/webkitpy/common/config/watchlist:
1852         * Scripts/webkitpy/style/checker.py:
1853         * Scripts/webkitpy/style/checkers/featuredefines.py:
1854         * gtk/make-dist.py:
1855         (ensure_version_if_possible):
1856         * gtk/manifest.txt.in:
1857
1858 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
1859
1860         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
1861         https://bugs.webkit.org/show_bug.cgi?id=174162
1862         rdar://problem/33137594
1863
1864         Reviewed by Dan Bernstein.
1865
1866         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
1867
1868         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1869         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1870         * EWSTools/configure-clang-linux.sh:
1871         * Scripts/build-webkit:
1872         * Scripts/do-file-rename:
1873         * Scripts/do-webcore-rename:
1874         * Scripts/update-webkit-localizable-strings:
1875         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1876         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1877         * Scripts/webkitpy/style/checkers/featuredefines.py:
1878         * gtk/manifest.txt.in:
1879
1880 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
1881
1882         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
1883         https://bugs.webkit.org/show_bug.cgi?id=174438
1884         <rdar://problem/33277112>
1885
1886         Reviewed by Aakash Jain.
1887
1888         Given a patch, this will convert the changes from the path to the new directory structure.
1889
1890         * Scripts/rebase-patch-after-webkit-move: Added.
1891         (append_source): Append 'Source' to the provided path.
1892         (is_editable_line): Return true if a line the script expects to modify.
1893         (needs_rebase): Return if a line needs to be rebased based on it's content.
1894         (rebase_line): Rebase the provided line.
1895         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
1896         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
1897         were provided.
1898
1899 2017-07-12  Nan Wang  <n_wang@apple.com>
1900
1901         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1902         https://bugs.webkit.org/show_bug.cgi?id=174393
1903         <rdar://problem/33248006>
1904
1905         Reviewed by Chris Fleizach.
1906
1907         * DumpRenderTree/AccessibilityUIElement.cpp:
1908         (textMarkerRangeMatchesTextNearMarkersCallback):
1909         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1910         (AccessibilityUIElement::getJSClass):
1911         * DumpRenderTree/AccessibilityUIElement.h:
1912         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1913         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1914         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1915         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1916         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1917         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1918         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1919         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1920
1921 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1922
1923         Unreviewed, rolling out r219409.
1924
1925         The revision caused the Windows builds to fail.
1926
1927         Reverted changeset:
1928
1929         "AX: [iOS] Implement a way to retrieve a text marker range
1930         with desired text that is closest to a position"
1931         https://bugs.webkit.org/show_bug.cgi?id=174393
1932         http://trac.webkit.org/changeset/219409
1933
1934 2017-07-12  Nan Wang  <n_wang@apple.com>
1935
1936         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
1937         https://bugs.webkit.org/show_bug.cgi?id=174393
1938         <rdar://problem/33248006>
1939
1940         Reviewed by Chris Fleizach.
1941
1942         * DumpRenderTree/AccessibilityUIElement.cpp:
1943         (textMarkerRangeMatchesTextNearMarkersCallback):
1944         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1945         (AccessibilityUIElement::getJSClass):
1946         * DumpRenderTree/AccessibilityUIElement.h:
1947         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1948         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1949         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1950         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1951         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1952         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1953         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1954         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
1955
1956 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
1957
1958         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
1959         https://bugs.webkit.org/show_bug.cgi?id=174197
1960
1961         Reviewed by Darin Adler.
1962
1963         This bit me the first time I tried to submit a patch to WebKit, and still I have
1964         to manually edit the ChangeLog every time I use the script.
1965
1966         This generates a more convenient and standard ChangeLog entry.
1967
1968         * Scripts/prepare-ChangeLog:
1969         (generateNewChangeLogs):
1970
1971 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1972
1973         Unreviewed, rolling out r219401.
1974
1975         This revision rolled out the previous patch, but after talking
1976         with reviewer, a rebaseline is what was needed.Rolling back in
1977         before rebaseline.
1978
1979         Reverted changeset:
1980
1981         "Unreviewed, rolling out r219379."
1982         https://bugs.webkit.org/show_bug.cgi?id=174400
1983         http://trac.webkit.org/changeset/219401
1984
1985 2017-07-12  Matt Lewis  <jlewis3@apple.com>
1986
1987         Unreviewed, rolling out r219379.
1988
1989         This revision caused a consistent failure in the test
1990         fast/dom/Window/property-access-on-cached-window-after-frame-
1991         removed.html.
1992
1993         Reverted changeset:
1994
1995         "Remove NAVIGATOR_HWCONCURRENCY"
1996         https://bugs.webkit.org/show_bug.cgi?id=174400
1997         http://trac.webkit.org/changeset/219379
1998
1999 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2000
2001         [WPE] Use libepoxy
2002         https://bugs.webkit.org/show_bug.cgi?id=172104
2003
2004         Reviewed by Michael Catanzaro.
2005
2006         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
2007         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
2008
2009 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
2010
2011         [GTK][WPE] Align Jhbuild patches for GStreamer packages
2012         https://bugs.webkit.org/show_bug.cgi?id=174363
2013
2014         Reviewed by Michael Catanzaro.
2015
2016         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
2017         between the GTK+ and WPE port. There's no reason for the two ports to apply
2018         different patches over same versions of GStreamer releases.
2019
2020         This aligns the two ports on this specific issue. Next we'll look into
2021         creating a single GStreamer-specific Jhbuild moduleset that will allow us
2022         to keep these patches in a single place, avoiding duplicate files.
2023
2024         * gtk/jhbuild.modules:
2025         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2026         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
2027         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2028         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
2029
2030 2017-07-11  Dean Jackson  <dino@apple.com>
2031
2032         Remove NAVIGATOR_HWCONCURRENCY
2033         https://bugs.webkit.org/show_bug.cgi?id=174400
2034
2035         Reviewed by Sam Weinig.
2036
2037         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2038
2039 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
2040
2041         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
2042         https://bugs.webkit.org/show_bug.cgi?id=174239
2043
2044         Reviewed by Brady Eidson.
2045
2046         Create windows with specific features set and make sure those are properly reflected in the
2047         WKWindowFeatures object.
2048
2049         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
2050         (resetToConsistentState):
2051         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2052         (TEST):
2053
2054 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
2055
2056         Do not duplicate files when deleting directories with svn 1.9
2057         https://bugs.webkit.org/show_bug.cgi?id=174339
2058         <rdar://problem/33226781>
2059
2060         Reviewed by David Kilzer.
2061
2062         * Scripts/svn-create-patch:
2063         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
2064         (generateFileList): Determine which files are deleted because they are part of a
2065         directory being deleted.
2066
2067 2017-07-11  Dean Jackson  <dino@apple.com>
2068
2069         Rolling out r219372.
2070
2071         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2072
2073 2017-07-11  Dean Jackson  <dino@apple.com>
2074
2075         Remove NAVIGATOR_HWCONCURRENCY
2076         https://bugs.webkit.org/show_bug.cgi?id=174400
2077
2078         Reviewed by Sam Weinig.
2079
2080         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2081
2082 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2083
2084         Teach build workers to fetch archives from S3.
2085         https://bugs.webkit.org/show_bug.cgi?id=174384
2086
2087         Reviewed by Aakash Jain.
2088
2089         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2090         (DownloadBuiltProduct):
2091
2092 2017-07-11  Lucas Forschler  <lforschler@apple.com>
2093
2094         Configure buildbot to transfer all archives to S3.
2095         Previously this was Mac only, but it's time to expand!
2096         https://bugs.webkit.org/show_bug.cgi?id=174378
2097         
2098         Reviewed by Aakash Jain.
2099
2100         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2101         (BuildFactory.__init__):
2102
2103 2017-07-11  Zan Dobersek  <zdobersek@igalia.com>
2104
2105         [WPE] Bump GStreamer packages in jhbuild.modules to 1.10.5
2106         https://bugs.webkit.org/show_bug.cgi?id=174350
2107
2108         Reviewed by Xabier Rodriguez-Calvar.
2109
2110         Bump the various GStreamer dependencies listed in WPE's Jhbuild modules file
2111         to the 1.10.5 version. One gstreamer patch is added. The two gst-plugins-bad
2112         patches are removed. The patches for gst-plugins-good are updated, removing
2113         the stale ones and adding the additional changes to qtdemux, souphttpsrc and
2114         rtpbin elements that will help with the EMEv3 development.
2115
2116         * wpe/jhbuild.modules:
2117         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
2118         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
2119         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Added.
2120         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
2121         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Added.
2122         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
2123         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2124         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2125         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
2126
2127 2017-07-10  John Wilander  <wilander@apple.com>
2128
2129         Resource Load Statistics: Prune statistics in orders of importance
2130         https://bugs.webkit.org/show_bug.cgi?id=174215
2131         <rdar://problem/33164403>
2132
2133         Reviewed by Chris Dumez.
2134
2135         Nest infrastructure. Adds these functions:
2136         1. testRunner.setStatisticsLastSeen()
2137         2. setStatisticsMaxStatisticsEntries()
2138         3. setStatisticsPruneEntriesDownTo()
2139
2140         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2141         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2142         (WTR::TestRunner::setStatisticsLastSeen):
2143         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
2144         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
2145         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2146         * WebKitTestRunner/TestController.cpp:
2147         (WTR::TestController::setStatisticsLastSeen):
2148         (WTR::TestController::setMaxStatisticsEntries):
2149         (WTR::TestController::setPruneEntriesDownTo):
2150         * WebKitTestRunner/TestController.h:
2151         * WebKitTestRunner/TestInvocation.cpp:
2152         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2153         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2154         (WTR::TestController::setStatisticsLastSeen):
2155         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2156         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2157
2158 2017-07-03  Brian Burg  <bburg@apple.com>
2159
2160         Web Replay: remove some unused code
2161         https://bugs.webkit.org/show_bug.cgi?id=173903
2162
2163         Rubber-stamped by Joseph Pecoraro.
2164
2165         * Scripts/run-input-generator-tests: Removed.
2166         * Scripts/webkitpy/replay/__init__.py: Removed.
2167         * Scripts/webkitpy/replay/main.py: Removed.
2168
2169 2017-07-10  Zan Dobersek  <zdobersek@igalia.com>
2170
2171         [WPE] Fix layout test baseline and TestExpectations hierarchy
2172         https://bugs.webkit.org/show_bug.cgi?id=174092
2173
2174         Reviewed by Michael Catanzaro.
2175
2176         Like for the GTK+ port, override the default_baseline_search_path() and
2177         _port_specific_expectations_files() methods in the webkitpy.port.WPEPort class.
2178         Both methods operate on a short list of search paths that defaults to 'wpe' and
2179         'wk2', along with any other user-specified platform directory.
2180
2181         The test_expectations_file_position() method is overridden for testing purposes,
2182         and relevant unit tests are added.
2183
2184         * Scripts/webkitpy/port/wpe.py:
2185         (WPEPort._search_paths):
2186         (WPEPort):
2187         (WPEPort.default_baseline_search_path):
2188         (WPEPort._port_specific_expectations_files):
2189         (WPEPort.test_expectations_file_position):
2190         * Scripts/webkitpy/port/wpe_unittest.py:
2191         (WPEPortTest.test_default_baseline_search_path):
2192         (WPEPortTest):
2193         (WPEPortTest.test_port_specific_expectations_files):
2194
2195 2017-07-10  Chris Dumez  <cdumez@apple.com>
2196
2197         Further WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore clean up
2198         https://bugs.webkit.org/show_bug.cgi?id=174301
2199
2200         Reviewed by Brent Fulgham.
2201
2202         Rename some of the testRunner API for clarity and to better match what it calls
2203         internally.
2204
2205         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2206         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2207         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
2208         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
2209         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2210         * WebKitTestRunner/TestController.cpp:
2211         (WTR::TestController::statisticsUpdateCookiePartitioning):
2212         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2213         * WebKitTestRunner/TestController.h:
2214         * WebKitTestRunner/TestInvocation.cpp:
2215         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2216         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2217         (WTR::TestController::statisticsUpdateCookiePartitioning):
2218         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
2219
2220 2017-07-10  Charlie Turner  <cturner@igalia.com>
2221
2222         [GStreamer] Live twitch.tv videos do not play
2223         https://bugs.webkit.org/show_bug.cgi?id=174222
2224
2225         Reviewed by Michael Catanzaro.
2226
2227         Upgrade GStreamer to 1.10.5. It contains a change to typefind that
2228         fixes videos not playing on twitch.tv.
2229
2230         * gtk/jhbuild.modules:
2231
2232 2017-07-09  Zan Dobersek  <zdobersek@igalia.com>
2233
2234         Add WebGL2 configuration option to build-webkit
2235         https://bugs.webkit.org/show_bug.cgi?id=174251
2236
2237         Reviewed by Michael Catanzaro.
2238
2239         * Scripts/webkitperl/FeatureList.pm: Add the 'webgl2' option, making it possible
2240         to enable the ENABLE_WEBGL2 flag through the build-webkit script. The feature
2241         is marked as enabled for the Apple Cocoa ports.
2242
2243 2017-07-08  Chris Dumez  <cdumez@apple.com>
2244
2245         Simplify WebResourceLoadStatisticsStore / ResourceLoadStatisticsStore
2246         https://bugs.webkit.org/show_bug.cgi?id=174290
2247
2248         Reviewed by Brent Fulgham.
2249
2250         Rename testRunner API to match the new internal API names.
2251
2252         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2253         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2254         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
2255         (WTR::TestRunner::statisticsSubmitTelemetry):
2256         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2257         * WebKitTestRunner/TestController.cpp:
2258         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2259         (WTR::TestController::statisticsSubmitTelemetry):
2260         * WebKitTestRunner/TestController.h:
2261         * WebKitTestRunner/TestInvocation.cpp:
2262         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2263         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2264         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2265         (WTR::TestController::statisticsSubmitTelemetry):
2266
2267 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2268
2269         Drop NOSNIFF compile flag
2270         https://bugs.webkit.org/show_bug.cgi?id=174289
2271
2272         Reviewed by Michael Catanzaro.
2273
2274         * Scripts/webkitperl/FeatureList.pm:
2275         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2276
2277 2017-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2278
2279         [iOS DnD] For cross-app drags, 'drop' event handlers are never invoked if dataTransfer.dropEffect is not set while dragging
2280         https://bugs.webkit.org/show_bug.cgi?id=174219
2281         <rdar://problem/32083177>
2282
2283         Reviewed by Ryosuke Niwa.
2284
2285         Add plumbing and support to mock the value of -allowsMoveOperation on the simulated UIDragDropSession objects.
2286         Setting the DataInteractionSimulator's shouldAllowMoveOperation property to NO simulates a drag operation coming
2287         in from another app out-of-process, for which move operations won't cause a drop to be performed in the first
2288         place.
2289
2290         Also tweaks 2 existing unit tests regarding file uploads via JavaScript to simulate items coming in from a
2291         different application, and adds a new test to check that if a drop area specifically requests a MOVE operation,
2292         no action is taken when dropping.
2293
2294         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html:
2295         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2296         (TestWebKitAPI::TEST):
2297         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2298         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2299         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
2300         (-[MockDragDropSession allowsMoveOperation]):
2301         (-[MockDataOperationSession initWithProviders:location:window:allowMove:]):
2302         (-[MockDataInteractionSession initWithWindow:allowMove:]):
2303         (-[DataInteractionSimulator initWithWebView:]):
2304         (-[DataInteractionSimulator runFrom:to:]):
2305         (-[DataInteractionSimulator _advanceProgress]):
2306         (-[MockDragDropSession initWithItems:location:window:]): Deleted.
2307         (-[MockDataOperationSession initWithProviders:location:window:]): Deleted.
2308         (-[MockDataInteractionSession initWithWindow:]): Deleted.
2309
2310 2017-07-07  Commit Queue  <commit-queue@webkit.org>
2311
2312         Unreviewed, rolling out r219238, r219239, and r219241.
2313         https://bugs.webkit.org/show_bug.cgi?id=174265
2314
2315         "fast/workers/dedicated-worker-lifecycle.html is flaky"
2316         (Requested by yusukesuzuki on #webkit).
2317
2318         Reverted changesets:
2319
2320         "[WTF] Implement WTF::ThreadGroup"
2321         https://bugs.webkit.org/show_bug.cgi?id=174081
2322         http://trac.webkit.org/changeset/219238
2323
2324         "Unreviewed, build fix after r219238"
2325         https://bugs.webkit.org/show_bug.cgi?id=174081
2326         http://trac.webkit.org/changeset/219239
2327
2328         "Unreviewed, CLoop build fix after r219238"
2329         https://bugs.webkit.org/show_bug.cgi?id=174081
2330         http://trac.webkit.org/changeset/219241
2331
2332 2017-07-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2333
2334         [GTK][WPE] Enable X-Content-Type-Options: nosniff
2335         https://bugs.webkit.org/show_bug.cgi?id=174250
2336
2337         Reviewed by Carlos Alberto Lopez Perez.
2338
2339         * Scripts/webkitperl/FeatureList.pm:
2340
2341 2017-07-07  Charlie Turner  <cturner@igalia.com>
2342         [GStreamer] vid.me videos do not play
2343         https://bugs.webkit.org/show_bug.cgi?id=172240
2344
2345         Reviewed by Xabier Rodriguez-Calvar.
2346
2347         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2348         have the existing libsoup build against GNOME to avoid header drift
2349         against GStreamer's linked Soup library.
2350
2351         * gtk/jhbuild.modules:
2352
2353 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2354
2355         Write a support script to enable buildbot to upload to S3
2356         https://bugs.webkit.org/show_bug.cgi?id=174196
2357         
2358         Reviewed by Stephanie Lewis.
2359
2360         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Added.
2361         (uploadToS3):
2362         (archiveExists):
2363
2364 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2365
2366         Enabling uploading archives to S3.
2367         https://bugs.webkit.org/show_bug.cgi?id=174198
2368         
2369         Reviewed by Stephanie Lewis.
2370
2371         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2372         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2373         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2374         (TransferToS3): Transfer full and minified archives to S3
2375
2376 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2377
2378         [WTF] Implement WTF::ThreadGroup
2379         https://bugs.webkit.org/show_bug.cgi?id=174081
2380
2381         Reviewed by Mark Lam.
2382
2383         Add WTF::ThreadGroup tests.
2384
2385         * TestWebKitAPI/CMakeLists.txt:
2386         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2387         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2388         (TestWebKitAPI::TEST):
2389
2390 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2391
2392         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2393         https://bugs.webkit.org/show_bug.cgi?id=174150
2394
2395         Reviewed by Mark Lam.
2396
2397         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2398         (TestWebKitAPI::TEST):
2399         * TestWebKitAPI/TestsController.cpp:
2400         (TestWebKitAPI::TestsController::TestsController):
2401
2402 2017-07-06  Lucas Forschler  <lforschler@apple.com>
2403
2404         Enabling uploading archives to S3.
2405         https://bugs.webkit.org/show_bug.cgi?id=174198
2406         
2407         Reviewed by Lucas Forschler.
2408
2409         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2410         (ArchiveMinifiedBuiltProduct): Create a minified archive from a full archive
2411         (UploadMinifiedBuiltProduct): Upload minified archive to build master
2412         (TransferToS3): Transfer full and minified archives to S3
2413
2414 2017-07-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2415
2416         [GTK][WPE] kill-old-process should kill more webkit related process
2417         https://bugs.webkit.org/show_bug.cgi?id=174220
2418
2419         Reviewed by Michael Catanzaro.
2420
2421         Generate list of possible webkit-related process names and add
2422         them to the list of process to kill.
2423         Also update the possible system related process for GTK+/WPE.
2424
2425         * BuildSlaveSupport/kill-old-processes:
2426         (listAllWebKitPrograms):
2427         (main):
2428
2429 2017-07-06  Chris Dumez  <cdumez@apple.com>
2430
2431         FileMonitor should not be ref counted
2432         https://bugs.webkit.org/show_bug.cgi?id=174166
2433
2434         Reviewed by Brent Fulgham.
2435
2436         Update the API tests to reflect the API change.
2437
2438         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2439         (TestWebKitAPI::TEST_F):
2440
2441 2017-07-06  Commit Queue  <commit-queue@webkit.org>
2442
2443         Unreviewed, rolling out r219194.
2444         https://bugs.webkit.org/show_bug.cgi?id=174207
2445
2446         it broke some layout tests (Requested by clopez on #webkit).
2447
2448         Reverted changeset:
2449
2450         "[GStreamer] vid.me videos do not play"
2451         https://bugs.webkit.org/show_bug.cgi?id=172240
2452         http://trac.webkit.org/changeset/219194
2453
2454 2017-07-06  Matt Lewis  <jlewis3@apple.com>
2455
2456         Unreviewed, rolling out r219178.
2457
2458         This caused a consistent failure with the API test
2459         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
2460
2461         Reverted changeset:
2462
2463         "[WTF] Clean up StringStatics.cpp by using
2464         LazyNeverDestroyed<> for Atoms"
2465         https://bugs.webkit.org/show_bug.cgi?id=174150
2466         http://trac.webkit.org/changeset/219178
2467
2468 2017-07-06  Alicia Boya García  <aboya@igalia.com>
2469
2470         Add CWD to Perl library path (no longer the default since 5.26.0)
2471         https://bugs.webkit.org/show_bug.cgi?id=174200
2472
2473         Reviewed by Michael Catanzaro.
2474
2475         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2476         (SetupGitClone._get_username_and_email):
2477
2478 2017-07-06  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2479
2480         Unreviewed, update my email address.
2481
2482         * Scripts/webkitpy/common/config/contributors.json:
2483
2484 2017-07-06  Charlie Turner  <cturner@igalia.com>
2485         [GStreamer] vid.me videos do not play
2486         https://bugs.webkit.org/show_bug.cgi?id=172240
2487
2488         Reviewed by Xabier Rodriguez-Calvar.
2489
2490         Build httpsoupsrc again for use in adaptive streaming pipelines, and
2491         have the existing libsoup build against GNOME to avoid header drift
2492         against GStreamer's linked Soup library.
2493
2494         * gtk/jhbuild.modules:
2495
2496 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2497
2498         [WTF] Move SoftLinking.h into WTF
2499         https://bugs.webkit.org/show_bug.cgi?id=174000
2500
2501         Reviewed by Alex Christensen.
2502
2503         * DumpRenderTree/mac/TestRunnerMac.mm:
2504         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2505         (test_primary_header):
2506         (ErrorCollector.__init__): Deleted.
2507         (ErrorCollector.__call__): Deleted.
2508         (ErrorCollector.results): Deleted.
2509         (ErrorCollector.result_list): Deleted.
2510         (ErrorCollector.verify_all_categories_are_seen): Deleted.
2511         (MockIo.open): Deleted.
2512         (CppFunctionsTest.test_convert_to_lower_with_underscores): Deleted.
2513         (CppFunctionsTest.test_create_acronym): Deleted.
2514         (CppFunctionsTest.test_is_c_or_objective_c): Deleted.
2515         (CppFunctionsTest.test_parameter): Deleted.
2516         (CppFunctionsTest.test_single_line_view): Deleted.
2517         (CppFunctionsTest.test_create_skeleton_parameters): Deleted.
2518         (CppFunctionsTest.test_find_parameter_name_index): Deleted.
2519         (CppFunctionsTest.test_parameter_list): Deleted.
2520         (CppFunctionsTest.test_check_parameter_against_text): Deleted.
2521         (CppStyleTestBase.process_file_data): Deleted.
2522         (CppStyleTestBase.perform_lint): Deleted.
2523         (CppStyleTestBase.perform_single_line_lint): Deleted.
2524         (CppStyleTestBase.perform_multi_line_lint): Deleted.
2525         (CppStyleTestBase.perform_language_rules_check): Deleted.
2526         (CppStyleTestBase.perform_function_lengths_check): Deleted.
2527         (CppStyleTestBase.perform_pass_ptr_check): Deleted.
2528         (CppStyleTestBase.perform_leaky_pattern_check): Deleted.
2529         (CppStyleTestBase.perform_include_what_you_use): Deleted.
2530         (CppStyleTestBase.perform_header_guard_check): Deleted.
2531         (CppStyleTestBase.assert_lint): Deleted.
2532         (CppStyleTestBase.assert_lint_one_of_many_errors_re): Deleted.
2533         (CppStyleTestBase.assert_multi_line_lint): Deleted.
2534         (CppStyleTestBase.assert_multi_line_lint_re): Deleted.
2535         (CppStyleTestBase.assert_language_rules_check): Deleted.
2536         (CppStyleTestBase.assert_include_what_you_use): Deleted.
2537         (CppStyleTestBase.assert_header_guard): Deleted.
2538         (CppStyleTestBase.assert_blank_lines_check): Deleted.
2539         (CppStyleTestBase.assert_positions_equal): Deleted.
2540         (FunctionDetectionTest.test_basic_function_detection): Deleted.
2541         (FunctionDetectionTest.test_function_declaration_detection): Deleted.
2542         (FunctionDetectionTest.test_pure_function_detection): Deleted.
2543         (FunctionDetectionTest.test_override_and_final_function_detection): Deleted.
2544         (FunctionDetectionTest.test_ignore_macros): Deleted.
2545         (FunctionDetectionTest.test_non_functions): Deleted.
2546         (FunctionDetectionTest.test_non_functions.Stuff): Deleted.
2547         (FunctionDetectionTest.test_parameter_list): Deleted.
2548         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack): Deleted.
2549         (CppStyleTest.test_asm_lines_ignored): Deleted.
2550         (CppStyleTest.test_get_line_width): Deleted.
2551         (CppStyleTest.test_find_next_multi_line_comment_start): Deleted.
2552         (CppStyleTest.test_find_next_multi_line_comment_end): Deleted.
2553         (CppStyleTest.test_remove_multi_line_comments_from_range): Deleted.
2554         (CppStyleTest.test_position): Deleted.
2555         (CppStyleTest.test_rfind_in_lines): Deleted.
2556         (CppStyleTest.test_close_expression): Deleted.
2557         (CppStyleTest.test_spaces_at_end_of_line): Deleted.
2558         (CppStyleTest.test_cstyle_cast): Deleted.
2559         (CppStyleTest.test_runtime_casting): Deleted.
2560         (CppStyleTest.test_runtime_selfinit): Deleted.
2561         (CppStyleTest.test_runtime_rtti): Deleted.
2562         (CppStyleTest.test_static_cast_readability): Deleted.
2563         (CppStyleTest.test_check_for_unnamed_params): Deleted.
2564         (CppStyleTest.void): Deleted.
2565         (CppStyleTest.test_deprecated_cast): Deleted.
2566         (CppStyleTest.test_mock_method): Deleted.
2567         (CppStyleTest.test_sizeof_type): Deleted.
2568         (CppStyleTest.cases): Deleted.
2569         (CppStyleTest.for): Deleted.
2570         (CppStyleTest.test_typedef_for_pointer_to_function): Deleted.
2571         (CppStyleTest.test_typedef_for_pointer_to_function.void): Deleted.
2572         (CppStyleTest.test_include_what_you_use_no_implementation_files): Deleted.
2573         (CppStyleTest.test_include_what_you_use): Deleted.
2574         (CppStyleTest.test_files_belong_to_same_module): Deleted.
2575         (CppStyleTest.test_cleanse_line): Deleted.
2576         (CppStyleTest.test_multi_line_comments): Deleted.
2577         (CppStyleTest.test_multi_line_comments.Foo): Deleted.
2578         (CppStyleTest.test_multiline_strings): Deleted.
2579         (CppStyleTest.test_platformh_comments): Deleted.
2580         (CppStyleTest.test_explicit_single_argument_constructors): Deleted.
2581         (CppStyleTest.test_explicit_single_argument_constructors.Foo): Deleted.
2582         (CppStyleTest.test_explicit_single_argument_constructors.Qualifier): Deleted.
2583         (CppStyleTest.test_explicit_single_argument_constructors.definition): Deleted.
2584         (CppStyleTest.test_slash_star_comment_on_single_line): Deleted.
2585         (CppStyleTest.test_suspicious_usage_of_if): Deleted.
2586         (CppStyleTest.test_suspicious_usage_of_memset): Deleted.
2587         (CppStyleTest.test_check_posix_threading): Deleted.
2588         (CppStyleTest.test_insecure_string_operations): Deleted.
2589         (CppStyleTest.test_format_strings): Deleted.
2590         (CppStyleTest.test_insecure_temp_file): Deleted.
2591         (CppStyleTest.test_variable_length_array_detection): Deleted.
2592         (CppStyleTest.test_braces): Deleted.
2593         (CppStyleTest.test_check_check): Deleted.
2594         (CppStyleTest.test_brace_at_begin_of_line): Deleted.
2595         (CppStyleTest.test_mismatching_spaces_in_parens): Deleted.
2596         (CppStyleTest.test_spacing_for_fncall): Deleted.
2597         (CppStyleTest.test_spacing_for_fncall.foo): Deleted.
2598         (CppStyleTest.test_spacing_before_braces): Deleted.
2599         (CppStyleTest.test_spacing_between_braces): Deleted.
2600         (CppStyleTest.test_spacing_before_brackets): Deleted.
2601         (CppStyleTest.test_cpp_lambda_functions): Deleted.
2602         (CppStyleTest.test_objective_c_block): Deleted.
2603         (CppStyleTest.test_objective_c_block_as_argument): Deleted.
2604         (CppStyleTest.test_spacing_around_else): Deleted.
2605         (CppStyleTest.test_spacing_for_binary_ops): Deleted.
2606         (CppStyleTest.test_spacing_for_binary_ops.hash_map): Deleted.
2607         (CppStyleTest.test_operator_methods): Deleted.
2608         (CppStyleTest.test_spacing_in_objective_c_properties): Deleted.
2609         (CppStyleTest.test_spacing_before_last_semicolon): Deleted.
2610         (CppStyleTest.test_static_or_global_stlstrings): Deleted.
2611         (CppStyleTest.test_no_spaces_in_function_calls): Deleted.
2612         (CppStyleTest.test_one_spaces_between_code_and_comments): Deleted.
2613         (CppStyleTest.test_one_spaces_after_punctuation_in_comments): Deleted.
2614         (CppStyleTest.test_space_after_comment_marker): Deleted.
2615         (CppStyleTest.test_newline_at_eof): Deleted.
2616         (CppStyleTest.test_newline_at_eof.do_test): Deleted.
2617         (CppStyleTest.test_extra_newlines_at_eof): Deleted.
2618         (CppStyleTest.test_extra_newlines_at_eof.do_test): Deleted.
2619         (CppStyleTest.test_invalid_utf8): Deleted.
2620         (CppStyleTest.test_invalid_utf8.do_test): Deleted.
2621         (CppStyleTest.test_is_blank_line): Deleted.
2622         (CppStyleTest.test_blank_lines_check): Deleted.
2623         (CppStyleTest.test_allow_blank_line_before_closing_namespace): Deleted.
2624         (CppStyleTest.test_allow_blank_line_before_if_else_chain): Deleted.
2625         (CppStyleTest.test_else_on_same_line_as_closing_braces): Deleted.
2626         (CppStyleTest.test_else_clause_not_on_same_line_as_else): Deleted.
2627         (CppStyleTest.test_comma): Deleted.
2628         (CppStyleTest.test_declaration): Deleted.
2629         (CppStyleTest.test_pointer_reference_marker_location): Deleted.
2630         (CppStyleTest.test_indent): Deleted.
2631         (CppStyleTest.test_indent.Foo): Deleted.
2632         (CppStyleTest.test_not_alabel): Deleted.
2633         (CppStyleTest.test_tab): Deleted.
2634         (CppStyleTest.test_unnamed_namespaces_in_headers): Deleted.
2635         (CppStyleTest.test_build_class): Deleted.
2636         (CppStyleTest.test_build_class.definitions): Deleted.
2637         (CppStyleTest.test_build_class.Foo): Deleted.
2638         (CppStyleTest.test_build_class.DERIVE_FROM_GOO): Deleted.
2639         (CppStyleTest.test_build_end_comment): Deleted.
2640         (CppStyleTest.test_build_forward_decl): Deleted.
2641         (CppStyleTest.test_build_forward_decl.Foo): Deleted.
2642         (CppStyleTest.test_build_header_guard): Deleted.
2643         (CppStyleTest.test_build_header_guard.Foo_h): Deleted.
2644         (CppStyleTest.test_build_header_guard.Foo_h.for): Deleted.
2645         (CppStyleTest.test_build_printf_format): Deleted.
2646         (CppStyleTest.test_runtime_printf_format): Deleted.
2647         (CppStyleTest.assert_lintLogCodeOnError): Deleted.
2648         (CppStyleTest.test_build_storage_class): Deleted.
2649         (CppStyleTest.test_build_storage_class.unsignedLongLong): Deleted.
2650         (CppStyleTest.test_build_storage_class.declaration): Deleted.
2651         (CppStyleTest.test_build_storage_class.after): Deleted.
2652         (CppStyleTest.test_build_storage_class.is): Deleted.
2653         (CppStyleTest.test_legal_copyright): Deleted.
2654         (CppStyleTest.test_invalid_increment): Deleted.
2655         (CppStyleTest.test_enum_bitfields): Deleted.
2656         (CppStyleTest.test_plain_integral_bitfields): Deleted.
2657         (CleansedLinesTest.test_init_empty): Deleted.
2658         (CleansedLinesTest.test_collapse_strings): Deleted.
2659         (OrderOfIncludesTest.tearDown): Deleted.
2660         (OrderOfIncludesTest.test_check_next_include_order__no_config): Deleted.
2661         (OrderOfIncludesTest.test_check_next_include_order__no_self): Deleted.
2662         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config): Deleted.
2663         (OrderOfIncludesTest.test_check_next_include_order__other_then_config): Deleted.
2664         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely): Deleted.
2665         (OrderOfIncludesTest.test_check_alphabetical_include_order): Deleted.
2666         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines): Deleted.
2667         (OrderOfIncludesTest.test_check_line_break_after_own_header): Deleted.
2668         (OrderOfIncludesTest.test_check_line_break_before_own_header): Deleted.
2669         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Deleted.
2670         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.BAZ): Deleted.
2671         (OrderOfIncludesTest.test_check_preprocessor_in_include_section.FOOBAR): Deleted.
2672         (OrderOfIncludesTest.test_primary_header): Deleted.
2673         (OrderOfIncludesTest.test_public_primary_header): Deleted.
2674         (OrderOfIncludesTest.test_check_wtf_includes): Deleted.
2675         (OrderOfIncludesTest.test_classify_include): Deleted.
2676         (OrderOfIncludesTest.test_try_drop_common_suffixes): Deleted.
2677         (CheckForFunctionLengthsTest.tearDown): Deleted.
2678         (CheckForFunctionLengthsTest.set_min_confidence): Deleted.
2679         (CheckForFunctionLengthsTest.assert_function_lengths_check): Deleted.
2680         (CheckForFunctionLengthsTest.trigger_lines): Deleted.
2681         (CheckForFunctionLengthsTest.trigger_test_lines): Deleted.
2682         (CheckForFunctionLengthsTest.assert_function_length_check_definition): Deleted.
2683         (CheckForFunctionLengthsTest.assert_function_length_check_definition_ok): Deleted.
2684         (CheckForFunctionLengthsTest.assert_function_length_check_at_error_level): Deleted.
2685         (CheckForFunctionLengthsTest.assert_function_length_check_below_error_level): Deleted.
2686         (CheckForFunctionLengthsTest.assert_function_length_check_above_error_level): Deleted.
2687         (CheckForFunctionLengthsTest.function_body): Deleted.
2688         (CheckForFunctionLengthsTest.function_body_with_blank_lines): Deleted.
2689         (CheckForFunctionLengthsTest.function_body_with_no_lints): Deleted.
2690         (CheckForFunctionLengthsTest.test_function_length_check_declaration): Deleted.
2691         (CheckForFunctionLengthsTest.test_function_length_check_declaration_with_block_following): Deleted.
2692         (CheckForFunctionLengthsTest.test_function_length_check_class_definition): Deleted.
2693         (CheckForFunctionLengthsTest.test_function_length_check_class_definition.Test): Deleted.
2694         (CheckForFunctionLengthsTest.test_function_length_check_trivial): Deleted.
2695         (CheckForFunctionLengthsTest.test_function_length_check_empty): Deleted.
2696         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity0): Deleted.
2697         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity0): Deleted.
2698         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity0): Deleted.
2699         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1v0): Deleted.
2700         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1v0): Deleted.
2701         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity1): Deleted.
2702         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity1): Deleted.
2703         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity1): Deleted.
2704         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_indented): Deleted.
2705         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_plus_blanks): Deleted.
2706         (CheckForFunctionLengthsTest.test_function_length_check_complex_definition_severity1): Deleted.
2707         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_test): Deleted.
2708         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_split_line_test): Deleted.
2709         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Deleted.
2710         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_embedded_no_lints): Deleted.
2711         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_with_no_lint): Deleted.
2712         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity2): Deleted.
2713         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity2): Deleted.
2714         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity2): Deleted.
2715         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity3): Deleted.
2716         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity3): Deleted.
2717         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity3): Deleted.
2718         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity4): Deleted.
2719         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity4): Deleted.
2720         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity4): Deleted.
2721         (CheckForFunctionLengthsTest.test_function_length_check_definition_below_severity5): Deleted.
2722         (CheckForFunctionLengthsTest.test_function_length_check_definition_at_severity5): Deleted.
2723         (CheckForFunctionLengthsTest.test_function_length_check_definition_above_severity5): Deleted.
2724         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines): Deleted.
2725         (CheckForFunctionLengthsTest.test_function_length_not_determinable): Deleted.
2726         (NoNonVirtualDestructorsTest.test_no_error): Deleted.
2727         (NoNonVirtualDestructorsTest.test_no_error.Foo): Deleted.
2728         (NoNonVirtualDestructorsTest.test_no_error.MyClass): Deleted.
2729         (NoNonVirtualDestructorsTest.test_no_error.Qualified): Deleted.
2730         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed): Deleted.
2731         (NoNonVirtualDestructorsTest.test_no_destructor_when_virtual_needed.Foo): Deleted.
2732         (NoNonVirtualDestructorsTest.test_enum_casing): Deleted.
2733         (NoNonVirtualDestructorsTest.test_enum_casing.Foo): Deleted.
2734         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123): Deleted.
2735         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon): Deleted.
2736         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass): Deleted.
2737         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum): Deleted.
2738         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed): Deleted.
2739         (NoNonVirtualDestructorsTest.test_destructor_non_virtual_when_virtual_needed.Foo): Deleted.
2740         (NoNonVirtualDestructorsTest.test_no_warn_when_derived): Deleted.
2741         (NoNonVirtualDestructorsTest.test_no_warn_when_derived.Foo): Deleted.
2742         (NoNonVirtualDestructorsTest.test_internal_braces): Deleted.
2743         (NoNonVirtualDestructorsTest.test_internal_braces.Foo): Deleted.
2744         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor): Deleted.
2745         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo): Deleted.
2746         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Foo.Goo): Deleted.
2747         (NoNonVirtualDestructorsTest.test_inner_class_needs_virtual_destructor.Goo): Deleted.
2748         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor): Deleted.
2749         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo): Deleted.
2750         (NoNonVirtualDestructorsTest.test_outer_class_needs_virtual_destructor.Foo.Goo): Deleted.
2751         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor): Deleted.
2752         (NoNonVirtualDestructorsTest.test_qualified_class_needs_virtual_destructor.Qualified): Deleted.
2753         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error): Deleted.
2754         (NoNonVirtualDestructorsTest.test_multi_line_declaration_no_error.Foo): Deleted.
2755         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error): Deleted.
2756         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error.Foo): Deleted.
2757         (LeakyPatternTest.assert_leaky_pattern_check): Deleted.
2758         (LeakyPatternTest.test_get_dc): Deleted.
2759         (LeakyPatternTest.test_get_dc.HWndDC): Deleted.
2760         (LeakyPatternTest.test_own_get_dc): Deleted.
2761         (LeakyPatternTest.test_create_dc): Deleted.
2762         (LeakyPatternTest.test_create_compatible_dc): Deleted.
2763         (WebKitStyleTest.test_indentation): Deleted.
2764         (WebKitStyleTest.test_indentation.Foo): Deleted.
2765         (WebKitStyleTest.test_indentation.Document): Deleted.
2766         (WebKitStyleTest.test_spacing): Deleted.
2767         (WebKitStyleTest.test_line_breaking): Deleted.
2768         (WebKitStyleTest.test_braces): Deleted.
2769         (WebKitStyleTest.test_braces.MyClass): Deleted.
2770         (WebKitStyleTest.test_braces.NS_ENUM): Deleted.
2771         (WebKitStyleTest.test_braces.CPP11EnumClass): Deleted.
2772         (WebKitStyleTest.test_braces.SOMETHING): Deleted.
2773         (WebKitStyleTest.test_null_false_zero): Deleted.
2774         (WebKitStyleTest.test_directive_indentation): Deleted.
2775         (WebKitStyleTest.test_using_std): Deleted.
2776         (WebKitStyleTest.test_using_namespace): Deleted.
2777         (WebKitStyleTest.test_max_macro): Deleted.
2778         (WebKitStyleTest.test_min_macro): Deleted.
2779         (WebKitStyleTest.test_wtf_move): Deleted.
2780         (WebKitStyleTest.test_ctype_fucntion): Deleted.
2781         (WebKitStyleTest.test_names): Deleted.
2782         (WebKitStyleTest.test_names.HTMLDocument): Deleted.
2783         (WebKitStyleTest.test_names.WebWindowFadeAnimation): Deleted.
2784         (WebKitStyleTest.test_names.declarations): Deleted.
2785         (WebKitStyleTest.test_names.struct): Deleted.
2786         (WebKitStyleTest.test_names.VectorType): Deleted.
2787         (WebKitStyleTest.test_parameter_names): Deleted.
2788         (WebKitStyleTest.test_comments): Deleted.
2789         (WebKitStyleTest.test_webkit_export_check): Deleted.
2790         (WebKitStyleTest.test_member_initialization_list): Deleted.
2791         (WebKitStyleTest.test_member_initialization_list.MyClass): Deleted.
2792         (WebKitStyleTest.test_other): Deleted.
2793         (CppCheckerTest.mock_handle_style_error): Deleted.
2794         (CppCheckerTest._checker): Deleted.
2795         (CppCheckerTest.test_init): Deleted.
2796         (CppCheckerTest.test_eq): Deleted.
2797         (CppCheckerTest.test_eq.mock_handle_style_error2): Deleted.
2798         (CppCheckerTest.test_ne): Deleted.
2799         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2800         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2801         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2802         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2803         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2804         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2805
2806 2017-07-05  Saam Barati  <sbarati@apple.com>
2807
2808         NewArray in FTLLowerDFGToB3 does not handle speculating on doubles when having a bad time
2809         https://bugs.webkit.org/show_bug.cgi?id=174188
2810         <rdar://problem/30581423>
2811
2812         Reviewed by Mark Lam.
2813
2814         * Scripts/run-jsc-stress-tests:
2815
2816 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2817
2818         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2819         https://bugs.webkit.org/show_bug.cgi?id=174150
2820
2821         Reviewed by Mark Lam.
2822
2823         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2824         (TestWebKitAPI::TEST):
2825
2826 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2827
2828         Remove copy of ICU headers from WebKit
2829         https://bugs.webkit.org/show_bug.cgi?id=116407
2830
2831         Reviewed by Alex Christensen.
2832
2833         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2834         * TestWebKitAPI/Configurations/Base.xcconfig:
2835         * WebKitTestRunner/Configurations/Base.xcconfig:
2836
2837 2017-07-05  Chris Dumez  <cdumez@apple.com>
2838
2839         Regression(r218821): Bad cast to WebKit::DiagnosticLoggingClient in WKWebView's _setDiagnosticLoggingDelegate
2840         https://bugs.webkit.org/show_bug.cgi?id=174163
2841         <rdar://problem/33067518>
2842
2843         Reviewed by Alex Christensen.
2844
2845         Add API test coverage.
2846
2847         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2848         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDiagnosticLogging.mm: Added.
2849         (TEST):
2850
2851 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2852
2853         When dragging a selection, clearing the selection in dragstart should not crash the web process
2854         https://bugs.webkit.org/show_bug.cgi?id=174142
2855         <rdar://problem/33067501>
2856
2857         Reviewed by Tim Horton.
2858
2859         Adds a unit test checking that the web process does not crash when the selection is cleared while a selection
2860         drag is starting up.
2861
2862         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2863         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-clear-selection.html: Added.
2864         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2865         (TestWebKitAPI::TEST):
2866
2867 2017-07-05  Daniel Bates  <dabates@apple.com>
2868
2869         Do not pass API::FrameInfo for source frame or clear out page of target frame on
2870         API navigation
2871         https://bugs.webkit.org/show_bug.cgi?id=174170
2872         <rdar://problem/33140328>
2873
2874         Reviewed by Brady Eidson.
2875
2876         Update tests as needed for the behavior change.
2877
2878         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
2879         (TEST):
2880
2881 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
2882
2883         Add WebKitPrivateFrameworkStubs for iOS 11
2884         https://bugs.webkit.org/show_bug.cgi?id=173988
2885
2886         Reviewed by David Kilzer.
2887
2888         * DumpRenderTree/mac/Configurations/Base.xcconfig: iphoneos and iphonesimulator
2889         should use the same directory for private framework stubs.
2890         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2891
2892 2017-07-05  Eric Carlson  <eric.carlson@apple.com>
2893
2894         [MediaStream] Protect request and web view during gUM client callback
2895         https://bugs.webkit.org/show_bug.cgi?id=174096
2896         <rdar://problem/32833102>
2897
2898         Reviewed by Youenn Fablet.
2899
2900         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2901         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
2902
2903 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2904
2905         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
2906
2907         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2908
2909 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2910
2911         Unreviewed, rolling out r219128.
2912
2913         Spoke with engineer who originally submitted, Patch for APi
2914         test to follow.
2915
2916         Reverted changeset:
2917
2918         "Unreviewed, rolling out r219070."
2919         https://bugs.webkit.org/show_bug.cgi?id=174082
2920         http://trac.webkit.org/changeset/219128
2921
2922 2017-07-05  Matt Lewis  <jlewis3@apple.com>
2923
2924         Unreviewed, rolling out r219070.
2925
2926         This revision caused consistent failures of the API test
2927         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
2928
2929         Reverted changeset:
2930
2931         "Pasting single words copied to UIPasteboard inserts URLs in
2932         editable areas"
2933         https://bugs.webkit.org/show_bug.cgi?id=174082
2934         http://trac.webkit.org/changeset/219070
2935
2936 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2937
2938         Remove unused EFL logo from bot watcher dashboard
2939         https://bugs.webkit.org/show_bug.cgi?id=174136
2940
2941         Reviewed by Alexey Proskuryakov.
2942
2943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
2944         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
2945
2946 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2947
2948         [GTK] Add more GTK bots to dashboard
2949         https://bugs.webkit.org/show_bug.cgi?id=174129
2950
2951         Reviewed by Carlos Alberto Lopez Perez.
2952
2953         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
2954         them.
2955
2956         This also changes the sort order to put WPE above GTK so that it's not buried under all the
2957         less-essential GTK bots.
2958
2959         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2960         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2961         (WebKitBuildbot):
2962
2963 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2964
2965         [WPE] Add WPE to bot watcher dashboard
2966         https://bugs.webkit.org/show_bug.cgi?id=174119
2967
2968         Reviewed by Alexey Proskuryakov.
2969
2970         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
2971         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
2972         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
2973         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2974         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2975         (WebKitBuildbot):
2976         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2977         (table.queue-grid tr.platform.linux-wpe img.logo):
2978
2979 2017-07-03  Lucas Forschler  <lforschler@apple.com>
2980
2981         https://bugs.webkit.org/show_bug.cgi?id=174105
2982         
2983         Reviewed by Stephanie Lewis.
2984
2985         * BuildSlaveSupport/built-product-archive:
2986         (main): Add a -minify parser option
2987         (createZip): Pass along the optional Minify argument if requested
2988         (minifySource): This will trim down archives, logic limited to Mac platform.
2989
2990 2017-07-03  Matt Rajca  <mrajca@apple.com>
2991
2992         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
2993         https://bugs.webkit.org/show_bug.cgi?id=174103
2994
2995         Reviewed by Alex Christensen.
2996
2997         Added an API test.
2998
2999         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
3000         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3001         (TEST): Added test.
3002         * TestWebKitAPI/cocoa/TestWKWebView.h:
3003         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3004         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
3005
3006 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3007
3008         Unreviewed, rolling out r219103.
3009
3010         Caused multiple build failures.
3011
3012         Reverted changeset:
3013
3014         "Remove copy of ICU headers from WebKit"
3015         https://bugs.webkit.org/show_bug.cgi?id=116407
3016         http://trac.webkit.org/changeset/219103
3017
3018 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3019
3020         Remove copy of ICU headers from WebKit
3021         https://bugs.webkit.org/show_bug.cgi?id=116407
3022
3023         Reviewed by Alex Christensen.
3024
3025         Use WTF's copy of ICU headers.
3026
3027         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3028         * TestWebKitAPI/Configurations/Base.xcconfig:
3029         * WebKitTestRunner/Configurations/Base.xcconfig:
3030
3031 2017-07-03  Brady Eidson  <beidson@apple.com>
3032
3033         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3034         https://bugs.webkit.org/show_bug.cgi?id=174073
3035
3036         Reviewed by Andy Estes.
3037
3038         * DumpRenderTree/mac/TestRunnerMac.mm:
3039         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
3040
3041         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
3042         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3043
3044 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3045
3046         Unreviewed, rolling out r219083.
3047
3048         The revision caused an API failure on all testing platforms.
3049
3050         Reverted changeset:
3051
3052         "[MediaStream] Protect request and web view during gUM client
3053         callback"
3054         https://bugs.webkit.org/show_bug.cgi?id=174096
3055         http://trac.webkit.org/changeset/219083
3056
3057 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
3058
3059         webkitpy: Properly number duplicated crashlogs
3060         https://bugs.webkit.org/show_bug.cgi?id=172002
3061
3062         Reviewed by Aakash Jain.
3063
3064         * Scripts/webkitpy/common/system/crashlogs.py:
3065         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
3066         an increasing integer.
3067         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3068         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
3069         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
3070         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
3071
3072 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
3073
3074         WebContent processes crash when the network process crashes with pending connection requests
3075         https://bugs.webkit.org/show_bug.cgi?id=174065
3076         <rdar://problem/30359835>
3077
3078         Reviewed by Tim Horton.
3079
3080         Add a API to ensure UI process tries to relaunch a new network process when the network process
3081         crashes with pending network connection requests.
3082
3083         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3084         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
3085         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3086         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3087         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
3088
3089 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
3090
3091         [MediaStream] Protect request and web view during gUM client callback
3092         https://bugs.webkit.org/show_bug.cgi?id=174096
3093         <rdar://problem/32833102>
3094
3095         Reviewed by Youenn Fablet.
3096
3097         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3098         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
3099
3100 2017-07-03  Andy Estes  <aestes@apple.com>
3101
3102         [Xcode] Add an experimental setting to build with ccache
3103         https://bugs.webkit.org/show_bug.cgi?id=173875
3104
3105         Reviewed by Tim Horton.
3106
3107         On systems that already have ccache(1) installed, this patch adds experimental support for
3108         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
3109
3110         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
3111         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
3112         find the toolchain from which to run clang, and then invokes ccache with the required
3113         arguments.
3114
3115         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
3116         precompiled headers to work properly [1].
3117
3118         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
3119         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
3120         during linking.
3121         
3122         [1] https://ccache.samba.org/manual.html#_precompiled_headers
3123
3124         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
3125         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3126         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
3127         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
3128         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
3129         * ccache/README.md: Added.
3130         * ccache/ccache-clang: Added.
3131         * ccache/ccache-clang++: Added.
3132         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
3133
3134 2017-07-03  Alex Christensen  <achristensen@webkit.org>
3135
3136         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3137         https://bugs.webkit.org/show_bug.cgi?id=174051
3138
3139         Reviewed by Tim Horton.
3140
3141         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3142         (TestWebKitAPI::TEST_F):
3143
3144 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3145
3146         Unreviewed, rolling out r219024.
3147
3148         This patch cause 3 didferent test to fail.
3149
3150         Reverted changeset:
3151
3152         "REGRESSION(r215096) Queries of URLs with non-special schemes
3153         should not percent-encode single quotes"
3154         https://bugs.webkit.org/show_bug.cgi?id=174051
3155         http://trac.webkit.org/changeset/219024
3156
3157 2017-07-03  Chris Dumez  <cdumez@apple.com>
3158
3159         Drop ResourceLoadStatisticsStore's statisticsLock
3160         https://bugs.webkit.org/show_bug.cgi?id=174080
3161
3162         Reviewed by Brent Fulgham.
3163
3164         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
3165
3166         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3167         (WTR::TestController::isStatisticsPrevalentResource):
3168         (WTR::TestController::isStatisticsHasHadUserInteraction):
3169         (WTR::TestController::isStatisticsGrandfathered):
3170
3171 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3172
3173         Pasting single words copied to UIPasteboard inserts URLs in editable areas
3174         https://bugs.webkit.org/show_bug.cgi?id=174082
3175         <rdar://problem/33046992>
3176
3177         Reviewed by Tim Horton.
3178
3179         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
3180
3181         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3182         (TestWebKitAPI::setUpWebViewForPasteboardTests):
3183         (TestWebKitAPI::TEST):
3184
3185 2017-07-02  Brady Eidson  <beidson@apple.com>
3186
3187         Add API test for all parts of WebKit1 API related to favicons.
3188         https://bugs.webkit.org/show_bug.cgi?id=174069
3189
3190         Reviewed by Andy Estes.
3191
3192         These two API tests cover all WebKit1 API related to icons.
3193         
3194         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3195         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
3196         (mainResourceData):
3197         (defaultFaviconData):
3198         (customFaviconData):
3199         (imageFromData):
3200         (+[IconLoadingProtocol canInitWithRequest:]):
3201         (+[IconLoadingProtocol canonicalRequestForRequest:]):
3202         (-[IconLoadingProtocol startLoading]):
3203         (-[IconLoadingProtocol stopLoading]):
3204         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3205         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
3206         (TestWebKitAPI::TEST):
3207
3208 2017-07-01  Dan Bernstein  <mitz@apple.com>
3209
3210         [iOS] Remove code only needed when building for iOS 9.x
3211         https://bugs.webkit.org/show_bug.cgi?id=174068
3212
3213         Reviewed by Tim Horton.
3214
3215         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3216         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3217         (WTR::initializeWebViewConfiguration):
3218         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3219         (-[HIDEventGenerator _createIOHIDEventType:]):
3220
3221 2017-07-01  Brady Eidson  <beidson@apple.com>
3222
3223         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
3224         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
3225
3226         Reviewed by Alex Christensen.
3227
3228         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
3229
3230 2017-07-01  Dan Bernstein  <mitz@apple.com>
3231
3232         [macOS] Remove code only needed when building for OS X Yosemite
3233         https://bugs.webkit.org/show_bug.cgi?id=174067
3234
3235         Reviewed by Tim Horton.
3236
3237         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3238         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3239         * DumpRenderTree/mac/DumpRenderTree.mm:
3240         (setDefaultsToConsistentValuesForTesting):
3241         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3242         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
3243         * MiniBrowser/Configurations/Base.xcconfig:
3244         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3245         * TestWebKitAPI/Configurations/Base.xcconfig:
3246         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3247         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3248         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
3249         (TestWebKitAPI::TEST_F):
3250         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
3251         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
3252         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
3253         (TestWebKitAPI::TEST_F):
3254         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3255         (TestWebKitAPI::TEST):
3256         * WebKitTestRunner/Configurations/Base.xcconfig:
3257         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3258         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3259         (WTR::InjectedBundle::platformInitialize):
3260         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3261         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
3262
3263 2017-07-01  Chris Dumez  <cdumez@apple.com>
3264
3265         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
3266         https://bugs.webkit.org/show_bug.cgi?id=174060
3267
3268         Reviewed by Brent Fulgham.
3269
3270         Port WebKitTestRunner over to the new Cocoa SPI.
3271
3272         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3273         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3274         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
3275         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
3276         no-ops since this code runs in the WebContent process, not the
3277         UIProcess.
3278
3279         * WebKitTestRunner/TestController.cpp:
3280         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3281
3282 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3283
3284         Unreviewed mac build fix.
3285
3286         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
3287         (TestWebKitAPI::TEST):
3288
3289 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
3290
3291         Add API to get WKActivatedElementInfo
3292         https://bugs.webkit.org/show_bug.cgi?id=174001
3293         <rdar://problem/29165518>
3294         
3295         Tests for now SPI to get activatedElementInfo.
3296
3297         Reviewed by Tim Horton.
3298
3299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3300         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
3301         (TestWebKitAPI::TEST):
3302
3303 2017-06-30  Chris Dumez  <cdumez@apple.com>
3304
3305         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
3306         https://bugs.webkit.org/show_bug.cgi?id=174038
3307
3308         Reviewed by Brent Fulgham.
3309
3310         Fix typo in API name.
3311
3312         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3313         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3314         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3315         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3316         * WebKitTestRunner/TestController.cpp:
3317         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
3318         * WebKitTestRunner/TestController.h:
3319         * WebKitTestRunner/TestInvocation.cpp:
3320         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3321
3322 2017-06-30  Alex Christensen  <achristensen@webkit.org>
3323
3324         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
3325         https://bugs.webkit.org/show_bug.cgi?id=174051
3326         <rdar://problem/33002846>
3327
3328         Reviewed by Tim Horton.
3329
3330         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3331         (TestWebKitAPI::TEST_F):
3332
3333 2017-06-30  Daniel Bates  <dabates@apple.com>
3334
3335         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3336         https://bugs.webkit.org/show_bug.cgi?id=165160
3337         <rdar://problem/29451999>
3338
3339         Reviewed by Brady Eidson.
3340
3341         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
3342         for navigations and window creation.
3343
3344         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3345         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
3346         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3347         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
3348         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3349         (TEST):
3350
3351 2017-06-29  Jer Noble  <jer.noble@apple.com>
3352
3353         Make Legacy EME API controlled by RuntimeEnabled setting.
3354         https://bugs.webkit.org/show_bug.cgi?id=173994
3355
3356         Reviewed by Sam Weinig.
3357
3358         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3359
3360 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3361
3362         Follow-up fix for r218996
3363
3364         Unreviewed infrastructure fix.
3365
3366         Repeated calls to 'ios_version' make the log noisy, memoize the function.
3367
3368         * Scripts/webkitpy/port/ios_simulator.py:
3369         (IOSSimulatorPort): Memoize ios_version().
3370
3371 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3372
3373         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3374         https://bugs.webkit.org/show_bug.cgi?id=174017
3375         <rdar://problem/32959782>
3376
3377         Reviewed by Simon Fraser.
3378
3379         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
3380         changes, the caret would appear outside of the iframe.
3381
3382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3383         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
3384         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3385         (checkDragCaretRectIsContainedInRect):
3386         (TestWebKitAPI::TEST):
3387         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3388         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3389         (-[DataInteractionSimulator _resetSimulatedState]):
3390         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
3391         (-[DataInteractionSimulator _advanceProgress]):
3392         (-[DataInteractionSimulator lastKnownDragCaretRect]):
3393
3394 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
3395
3396         Add support for different versions of iOS when loading test expectations
3397         https://bugs.webkit.org/show_bug.cgi?id=173774
3398         <rdar://problem/32951132>
3399
3400         Rubber-stamped by Aakash Jain.
3401
3402         When running layout tests, we should support multiple version of iOS the same way we do Mac.
3403
3404         * Scripts/webkitpy/port/ios.py:
3405         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
3406         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
3407         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
3408         * Scripts/webkitpy/port/ios_device.py:
3409         (IOSDevicePort.ios_version): Ask connected devices for implementation.
3410         * Scripts/webkitpy/port/ios_device_unittest.py:
3411         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
3412         (IOSDeviceTest.test_baseline_searchpath): Ditto.
3413         (IOSDeviceTest.test_expectations_ordering): Ditto.
3414         * Scripts/webkitpy/port/ios_simulator.py:
3415         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
3416         ask the platform.
3417
3418 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
3419
3420         Fontconfig build breaks with glibc 2.15+
3421         https://bugs.webkit.org/show_bug.cgi?id=174019
3422
3423         Reviewed by Carlos Alberto Lopez Perez.
3424
3425         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
3426
3427         * wpe/jhbuild.modules:
3428         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
3429
3430 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
3431
3432         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
3433         https://bugs.webkit.org/show_bug.cgi?id=174010
3434         <rdar://problem/32597802>
3435
3436         Reviewed by Tim Horton.
3437
3438         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
3439         snapshot fails for any reason.
3440
3441         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3442         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
3443         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3444         (TestWebKitAPI::TEST):
3445
3446 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
3447
3448         AX: Cannot call setValue() on contenteditable or ARIA text controls
3449         https://bugs.webkit.org/show_bug.cgi?id=173520
3450
3451         Reviewed by Ryosuke Niwa.
3452
3453         Add setValue() method to WKTR (already existed in DRT).
3454
3455         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3456         (WTR::AccessibilityUIElement::setValue):
3457         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3458         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3459         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3460         (WTR::AccessibilityUIElement::setValue):
3461
3462 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
3463
3464         getBoundingClientRect returns wrong value for combination of page zoom and scroll
3465         https://bugs.webkit.org/show_bug.cgi?id=173841
3466         rdar://problem/32983841
3467
3468         Reviewed by Dean Jackson.
3469
3470         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
3471         always did text zooming.
3472
3473         * MiniBrowser/mac/WK1BrowserWindowController.m:
3474         (-[WK1BrowserWindowController zoomIn:]):
3475         (-[WK1BrowserWindowController zoomOut:]):
3476         (-[WK1BrowserWindowController canResetZoom]):
3477         (-[WK1BrowserWindowController resetZoom:]):
3478
3479 2017-06-29  John Wilander  <wilander@apple.com>
3480
3481         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
3482         https://bugs.webkit.org/show_bug.cgi?id=173940
3483         <rdar://problem/33018125>
3484
3485         Reviewed by Brent Fulgham.
3486
3487         This change allows the TestController to turn off
3488         regular resource load statistics telemetry submission
3489         and to manually control when telemetry is calculated
3490         and submitted.
3491
3492         * WebKitTestRunner/TestController.cpp:
3493         (WTR::TestController::initialize):
3494             Turns off automatic resource load statistics telemetry submission.
3495
3496 2017-06-29  Commit Queue  <commit-queue@webkit.org>
3497
3498         Unreviewed, rolling out r218512.
3499         https://bugs.webkit.org/show_bug.cgi?id=173981
3500
3501         "It changes the behavior of the JS API's JSEvaluateScript
3502         which breaks TurboTax" (Requested by saamyjoon on #webkit).
3503
3504         Reverted changeset:
3505
3506         "test262: Completion values for control flow do not match the
3507         spec"
3508         https://bugs.webkit.org/show_bug.cgi?id=171265
3509         http://trac.webkit.org/changeset/218512
3510
3511 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
3512
3513         Add WebKitSystemInterface for iOS 11
3514         https://bugs.webkit.org/show_bug.cgi?id=173936
3515
3516         Reviewed by Lucas Forschler.
3517
3518         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
3519
3520 2017-06-28  Keith Miller  <keith_miller@apple.com>
3521
3522         VMTraps has some races
3523         https://bugs.webkit.org/show_bug.cgi?id=173941
3524
3525         Reviewed by Michael Saboff.
3526
3527         Add new testing mode for testing the Watchdog with our stress
3528         tests.
3529
3530         * Scripts/run-jsc-stress-tests:
3531
3532 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3533
3534         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
3535         https://bugs.webkit.org/show_bug.cgi?id=173877
3536
3537         Reviewed by Brady Eidson.
3538
3539         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
3540         the next tests.
3541
3542         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3543         (testGetFavicon):
3544
3545 2017-06-28  Tim Horton  <timothy_horton@apple.com>
3546
3547         MobileSafari was constantly using 10-15% CPU viewing a PDF
3548         https://bugs.webkit.org/show_bug.cgi?id=173944
3549         <rdar://problem/33039910>
3550
3551         Reviewed by Simon Fraser.
3552
3553         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3554         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
3555         Add a test that we ever call the stable presentation update callback
3556         when we have a WKPDFView up, instead of infinitely looping.
3557
3558 2017-06-28  Alex Christensen  <achristensen@webkit.org>
3559
3560         Prevent displaying URLs with small capital letters
3561         https://bugs.webkit.org/show_bug.cgi?id=173949
3562         <rdar://problem/32952058>
3563
3564         Reviewed by Brent Fulgham.
3565
3566         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
3567         (TestWebKitAPI::TEST):
3568
3569 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
3570
3571         Unreviewed test fix.
3572
3573         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
3574
3575         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
3576
3577 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
3578
3579         Teach ResourceLoadStatistics to recognize changes in the file system
3580         https://bugs.webkit.org/show_bug.cgi?id=173800
3581         <rdar://problem/32937842>
3582
3583         Reviewed by Chris Dumez.
3584
3585         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3586         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
3587         (TestWebKitAPI::FileMonitorTest::tempFilePath):
3588         (TestWebKitAPI::handleFileModification):
3589         (TestWebKitAPI::handleFileDeletion):
3590         (TestWebKitAPI::resetTestState):
3591         (TestWebKitAPI::TEST_F):
3592
3593 2017-06-28  Brady Eidson  <beidson@apple.com>
3594
3595         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
3596         https://bugs.webkit.org/show_bug.cgi?id=173874
3597
3598         Reviewed by Alex Christensen.
35