Update the LLINT CLoop bot infrastructure.
[WebKit-https.git] / Tools / ChangeLog
1 2014-01-09  Lucas Forschler  <lforschler@apple.com>
2
3         Update the LLINT CLoop bot infrastructure.  
4         This will require a build master restart.
5         
6         Unreviewed. 
7         
8         * BuildSlaveSupport/build.webkit.org-config/config.json:
9         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
10         (CompileLLINTCLoop):
11         (RunLLINTCloopTests):
12         (BuildAndTestLLINTCLoopFactory):
13         (BuildAndTestLLINTCLoopFactory.__init__):
14
15 2014-01-09  Dan Bernstein  <mitz@apple.com>
16
17         [Cocoa] Promote WKBackForwardList{,Item}.h to public
18         https://bugs.webkit.org/show_bug.cgi?id=126707
19
20         Reviewed by Sam Weinig.
21
22         * Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
23         left behind in the build products directory after a private header is made public.
24
25 2014-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
26
27         [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
28         https://bugs.webkit.org/show_bug.cgi?id=126686
29
30         Reviewed by Martin Robinson.
31
32         Test that partial files are not left on disk after a download has
33         been cancelled after the destination has been decided. To make
34         sure the download is cancelled after the destination has been
35         decided and before the operation finishes, we cancel the download
36         in the destination decided callback, and we use an infinite
37         resource that writes chunks to the response body and never
38         completes the body.
39
40         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
41         (addContentDispositionHTTPHeaderToResponse): Helper function to
42         add the Content-Disposition to the response headers.
43         (writeNextChunkIdle): Write next chunk to response body.
44         (writeNextChunk): Write next chunk in an idle to avoid flooding
45         the network with the inifnite resource.
46         (serverCallback): Add an inifinite resource.
47         (testDownloadRemoteFileError): Check that partial file is not
48         present after the download has been cancelled.
49
50 2014-01-09  Roland Takacs  <rtakacs@inf.u-szeged.hu>
51
52         Move myself to the committers list.
53
54         Unreviewed.
55
56         * Scripts/webkitpy/common/config/contributors.json:
57
58 2014-01-08  Seokju Kwon  <seokju@webkit.org>
59
60         [GTK] Unreviewed build fix after r161522.
61
62         * TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp.
63
64 2014-01-08  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
65
66         Missleading style error when mixing system and non-system header include lines.
67         https://bugs.webkit.org/show_bug.cgi?id=126564
68
69         Reviewed by Ryosuke Niwa.
70
71         * Scripts/webkitpy/style/checkers/cpp.py:
72         (check_include_line):
73         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
74         (OrderOfIncludesTest.test_check_alphabetical_include_order):
75         (OrderOfIncludesTest.test_public_primary_header):
76
77 2014-01-08  Seokju Kwon  <seokju@webkit.org>
78
79         [EFL] Unreviewed build fix after r161522.
80
81         * TestWebKitAPI/CMakeLists.txt:
82         * TestWebKitAPI/PlatformEfl.cmake:
83
84 2014-01-08  Anders Carlsson  <andersca@apple.com>
85
86         Remove WKConnectionRef tests
87         https://bugs.webkit.org/show_bug.cgi?id=126666
88
89         Reviewed by Dan Bernstein.
90
91         The WKConnectionRef is poorly designed but thankfully not used anywhere. 
92         Remove the API tests as a first step towards killing the entire thing.
93
94         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
95         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed.
96         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed.
97
98 2014-01-08  Commit Queue  <commit-queue@webkit.org>
99
100         Unreviewed, rolling out r161512.
101         http://trac.webkit.org/changeset/161512
102         https://bugs.webkit.org/show_bug.cgi?id=126655
103
104         Broke webkitpy tests (Requested by ap on #webkit).
105
106         * Scripts/webkitpy/port/gtk.py:
107         (GtkPort.__init__):
108         (GtkPort.setup_test_run):
109         (GtkPort._port_specific_expectations_files):
110         * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
111         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
112
113 2014-01-08  Commit Queue  <commit-queue@webkit.org>
114
115         Unreviewed, rolling out r161517.
116         http://trac.webkit.org/changeset/161517
117         https://bugs.webkit.org/show_bug.cgi?id=126659
118
119         The fix didn't completely remove the problem and is now
120         standing in the way of the rollout of the offending patch
121         (Requested by zdobersek on #webkit).
122
123         * Scripts/webkitpy/port/gtk.py:
124         (GtkPort.__init__):
125
126 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
127
128         Unreviewed. Attempting to fix webkitpy tests after r161512.
129
130         * Scripts/webkitpy/port/gtk.py:
131         (GtkPort.__init__): Construct LeakDetectorValgrin only if leak detection is enabled.
132
133 2014-01-08  Brian Holt  <brian.holt@samsung.com>
134
135         [GTK] Parse Valgrind xml leak files
136         https://bugs.webkit.org/show_bug.cgi?id=119446
137
138         Reviewed by Alejandro G. Castro.
139
140         Parse the xml files generated by Valgrind to yield useful
141         information about the memory leaks.
142
143         * Scripts/webkitpy/port/gtk.py:
144         (GtkPort.__init__):
145         (GtkPort.setup_test_run): Clear the previous output files before new
146         run.
147         (GtkPort.print_leaks_summary):
148
149         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
150         Parse the xml files generated by Valgrind and summarise leaks
151         into an easily understandable list.
152         (get_text_of):
153         (get_CDATA_of):
154         (gather_frames):
155         (ValgrindError):
156         (ValgrindError.__init__):
157         (ValgrindError.__str__):
158         (ValgrindError.unique_string):
159         (ValgrindError.error_hash):
160         (ValgrindError.__hash__):
161         (ValgrindError.__eq__):
162         (LeakDetectorValgrind):
163         (LeakDetectorValgrind.__init__):
164         (LeakDetectorValgrind._parse_leaks_output):
165         (LeakDetectorValgrind.leaks_files_in_results_directory):
166         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
167         (LeakDetectorValgrind.parse_and_print_leaks_detail):
168
169         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
170         (make_mock_valgrind_output):
171         (make_mock_incomplete_valgrind_output):
172         (make_mock_valgrind_results):
173         (make_mock_valgrind_results_incomplete):
174         (make_mock_valgrind_results_empty):
175         (make_mock_valgrind_results_misformatted):
176         (LeakDetectorValgrindTest):
177         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
178         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
179         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
180         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
181         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
182         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
183         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
184         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
185
186 2014-01-08  Commit Queue  <commit-queue@webkit.org>
187
188         Unreviewed, rolling out r161427.
189         http://trac.webkit.org/changeset/161427
190         https://bugs.webkit.org/show_bug.cgi?id=126645
191
192         Emits a stye error on any newly added files (Requested by ap
193         on #webkit).
194
195         * Scripts/webkitpy/style/checkers/cpp.py:
196         (check_style):
197         (CppChecker):
198         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
199         (WebKitStyleTest.test_other):
200
201 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
202
203         Remove run-webkit-tests wrapper script as all platform are using NRWT now.
204         https://bugs.webkit.org/show_bug.cgi?id=126580
205
206         Reviewed by Csaba Osztrogonác.
207
208         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
209         (RunWebKitTests): Passing --debug-rwt-logging here instead of the
210         run-webkit-tests script.
211         * Scripts/new-run-webkit-tests: Renamed to run-webkit-tests.
212         * Scripts/run-webkit-tests: Removed, as it was just a temporary hack.
213
214 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
215
216         Update the list of non-committer u-szeged contributors
217         https://bugs.webkit.org/show_bug.cgi?id=126640
218
219         Reviewed by Csaba Osztrogonác.
220
221         * Scripts/webkitpy/common/config/contributors.json:
222
223 2014-01-08  Alberto Garcia  <berto@igalia.com>
224
225         Fix some compilation warnings
226         https://bugs.webkit.org/show_bug.cgi?id=126635
227
228         Reviewed by Csaba Osztrogonác.
229
230         * GtkLauncher/main.c:
231         (createWindow): This function is not supposed to receive any
232         parameter, yet we are passing one.
233
234 2014-01-08  Brian Holt  <brian.holt@samsung.com>
235
236         [GTK][WK2] unskip passing unit tests
237         https://bugs.webkit.org/show_bug.cgi?id=126637
238
239         Reviewed by Carlos Garcia Campos.
240
241         Unskip TestResources and TestAuthentication unit tests since they
242         are passing both under Xvfb and X.
243
244         * Scripts/run-gtk-tests:
245         (TestRunner):
246
247 2014-01-08  Alberto Garcia  <berto@igalia.com>
248
249         REGRESSION(r160304): [GTK] Disable libtool fast install
250         https://bugs.webkit.org/show_bug.cgi?id=126381
251
252         Reviewed by Gustavo Noronha Silva.
253
254         Disable the libtool fast-install mode in developer/test builds.
255
256         In this mode binaries are generated ready to be used directly from
257         the build tree. Otherwise they would need to be relinked when they
258         are executed, which can take a lot of resources, particularly in
259         debug builds.
260
261         * Scripts/webkitdirs.pm:
262         (runAutogenForAutotoolsProjectIfNecessary):
263
264 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
265
266         Unreviewed GTK gardening.
267
268         * Scripts/run-gtk-tests:
269         (TestRunner): Skipping the snapshot test case from the TestWebKitWebView test suite.
270         The test is failing due to issues with Xvfb, with the problem being handled in bug #120404.
271
272 2014-01-07  Lucas Forschler  <lforschler@apple.com>
273
274         Add buildbot infrasctructure for building and testing JSC cloop
275         https://bugs.webkit.org/show_bug.cgi?id=126604
276
277         Reviewed by Geoffrey Garen.
278
279         * BuildSlaveSupport/build.webkit.org-config/config.json:
280         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
281         (CompileCLOOP):
282         (RunCLOOPTests):
283         (RunCLOOPTests.countFailures):
284         (BuildAndTestCLOOP):
285
286 2014-01-07  Brian Burg  <bburg@apple.com>
287
288         Unreviewed. Add myself as a committer.
289
290         * Scripts/webkitpy/common/config/contributors.json:
291
292 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
293
294         Popovers at build.webkit.org/dashboard could have titles
295         https://bugs.webkit.org/show_bug.cgi?id=126495
296
297         Reviewed by Timothy Hatcher.
298
299         Added titles to all popovers except for pending revisions one, which I would like
300         to improve more (probably add an ETA).
301
302         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
303         (BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for 
304         adding a title to base class.
305
306         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
307         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
308         a divider to a separate function.
309         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
310         (BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
311         title from above function.
312         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
313         variable to "content" to match all other code.
314         (BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
315         (BuildbotQueueView.prototype._addDividerToPopover): Added.
316
317         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
318         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
319         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
320         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
321
322         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
323
324 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
325
326         There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
327         https://bugs.webkit.org/show_bug.cgi?id=126472
328
329         Reviewed by Timothy Hatcher.
330
331         Added a delay when quickly switching to a different popover, making it easier to
332         move mouse pointer from active element to its popover without accidentally opening
333         a different popover.
334
335         Used this code to add a delay before creating a popover. This doesn't change UI
336         behavior, as there was alerady a delay before it became visible, but it avoids
337         flooding buildbot server with http requests when quickly moving the mouse over
338         dashboard page.
339
340         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
341         Fixed a case where popover could get stuck. If content was updated while fade-out
342         transition was already in place, the transition was removed for no good reason.
343
344         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
345         (PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
346
347         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
348         (.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
349         popover delay from 1s to 800ms.
350
351 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
352
353         Improve display of failed builds at build.webkit.org/dashboard
354         https://bugs.webkit.org/show_bug.cgi?id=126542
355         <rdar://problem/15753550>
356
357         Reviewed by Timothy Hatcher.
358
359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
360         Instead of hardcoding step name, look for the first step that failed.
361         While at it, added a popover with more links. There are multiple, and it's good
362         to have a choice of which one to look at in each situation.
363
364         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
365         (BuildbotIteration.prototype.get successful): Being successful is not the opposite
366         of having failed. Many iterations are interrupted for whatever reason internal to
367         Buildbot, and these are suppoed to be orange, not red.
368         (BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
369         not only WillRetry ones.
370         (BuildbotIteration.prototype.get failed): Changed to only include iterations that
371         actually failed, more likely indicating a problem with code base.
372         (BuildbotIteration.prototype.get firstFailedStepName):
373         (BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
374         (BuildbotIteration.prototype.get failureLogs): Ditto.
375         (BuildbotIteration.prototype.update): Store complete results for the failed step.
376         Not every failure stops the iteration, so we could have multiple failed steps,
377         but let's see if seeing just the first one will be enough.
378
379         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
380         (BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
381         terms of successful iterations.
382         (BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
383
384         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
385         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
386         terms of successful iterations.
387
388         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
389         Removed code to create a path to build output, we now take it from results JSON.
390
391         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
392         Added styles for the new popover.
393
394 2014-01-07  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
395
396         defined constants should use all uppercase names with words separated by underscores.
397         https://bugs.webkit.org/show_bug.cgi?id=126055
398
399         Reviewed by Alexey Proskuryakov.
400
401         * Scripts/webkitpy/style/checkers/cpp.py:
402         (check_style):
403         (CppChecker):
404         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
405         (WebKitStyleTest.test_define_constants):
406
407 2014-01-07  Brian Holt  <brian.holt@samsung.com>
408
409         Unreviewed. Add myself as a committer.
410
411         * Scripts/webkitpy/common/config/contributors.json:
412
413 2014-01-07  Csaba Osztrogonác  <ossy@webkit.org>
414
415         Remove the WinCE buildbot from build.webkit.org
416         https://bugs.webkit.org/show_bug.cgi?id=126517
417
418         Reviewed by Alexey Proskuryakov.
419
420         * BuildSlaveSupport/build.webkit.org-config/config.json:
421         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
422         (appendCustomBuildFlags):
423
424 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
425
426         [EFL] Change ATK version to 2.11.4
427         https://bugs.webkit.org/show_bug.cgi?id=126573
428
429         Reviewed by Gyuyoung Kim.
430
431         ATK 2.11.4 introduces some new roles, that are already being used by WebKit.
432
433         * efl/jhbuild.modules:
434
435 2014-01-07  Alberto Garcia  <berto@igalia.com>
436
437         [GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher
438         https://bugs.webkit.org/show_bug.cgi?id=117275
439
440         Reviewed by Carlos Garcia Campos.
441
442         If we are not using the internal jhbuild we must not use the
443         jhbuild-wrapper script, else it will try to download and install
444         it.
445
446         * Scripts/run-launcher:
447
448 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
449
450         [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE
451         https://bugs.webkit.org/show_bug.cgi?id=125855
452
453         Reviewed by Mario Sanchez Prada.
454
455         Added new function isIndeterminate for testing aria-checked mixed state.
456         I provided respective, but empty function in mac port. Mac testing it differently.
457
458         * DumpRenderTree/AccessibilityUIElement.cpp:
459         (getIsIndeterminate):
460         (AccessibilityUIElement::getJSClass):
461         * DumpRenderTree/AccessibilityUIElement.h:
462         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
463         (AccessibilityUIElement::isIndeterminate):
464         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added empty function.
465         (AccessibilityUIElement::isIndeterminate):
466         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added empty function.
467         (AccessibilityUIElement::isIndeterminate):
468         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added empty function.
469         (AccessibilityUIElement::isIndeterminate):
470         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
471         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
472         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
473         (WTR::AccessibilityUIElement::isIndeterminate):
474         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
475         (WTR::AccessibilityUIElement::isIndeterminate):
476
477 2014-01-06  Mark Rowe  <mrowe@apple.com>
478
479         <https://webkit.org/b/126560> Fix incorrectness in use of some AppKit enums
480
481         Reviewed by Ryosuke Niwa.
482
483         * DumpRenderTree/mac/DumpRenderTree.mm:
484         (-[DRTMockScroller rectForPart:]): Move to using an if with early return instead of a switch
485         with a single case. This avoids the potential for warnings about unhandled cases.
486         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
487         (WTR::PlatformWebView::PlatformWebView): Cast the argument to NSBackingStoreType.
488
489 2014-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
490
491         [GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
492         https://bugs.webkit.org/show_bug.cgi?id=126342
493
494         Reviewed by Gustavo Noronha Silva.
495
496         * CMakeLists.txt: Include the new unit tests subdirectories.
497         * Scripts/run-gtk-tests: Update to refer to the new build locations.
498         * Scripts/webkitpy/style/checker.py: Update the style checker.
499         * Scripts/webkitpy/style/checker_unittest.py:
500         * TestWebKitAPI/GNUmakefile.am:
501         * TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
502         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
503         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
504         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
505         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
506         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
507         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
508         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
509         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
510         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
511         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
512         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
513         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
514         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
515         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
516         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
517         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
518         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
519         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
520         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
521         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
522         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
523         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
524         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
525         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
526         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
527         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
528         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
529         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
530         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
531         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
532         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
533         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
534         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
535         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
536         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
537         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
538         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
539         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
540         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
541         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
542         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
543         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
544         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
545         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
546         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
547         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
548         * TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
549         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
550         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
551         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
552         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
553         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
554         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
555         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
556         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
557         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
558         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
559         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
560         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
561         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
562         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
563         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
564         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
565         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
566         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
567         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
568         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
569         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
570         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
571         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
572         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
573         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
574         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
575         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
576         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
577         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
578         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
579         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
580         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
581         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
582         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
583         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
584         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
585         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
586         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
587         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.
588
589 2014-01-06  Alexey Proskuryakov  <ap@apple.com>
590
591         Gtk and Efl API test results confuse the dashboard
592         https://bugs.webkit.org/show_bug.cgi?id=126535
593
594         Reviewed by Tim Horton.
595
596         Added "API tests" step as "platform api tests".
597
598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
599         (Buildbot.prototype.platformAPITestResultsURLForIteration):
600         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
601         (BuildbotIteration):
602         (BuildbotIteration.prototype.update):
603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
604         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
605         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
606
607 2014-01-06  Tim Horton  <timothy_horton@apple.com>
608
609         build.webkit.org/dashboard should still function if localStorage is disabled
610         https://bugs.webkit.org/show_bug.cgi?id=126511
611
612         Reviewed by Alexey Proskuryakov.
613
614         If localStorage is disabled, we should carry on with a warning.
615
616         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
617         Don't show the gear if localStorage isn't working.
618
619         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
620         (QueueView.prototype._updateHiddenState):
621         Bail if localStorage isn't working.
622
623         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
624         (Settings.prototype.available):
625
626 2014-01-02  Roger Fong  <roger_fong@apple.com>
627
628         Set VSINSTALLDIR in win ews start script.
629         https://bugs.webkit.org/show_bug.cgi?id=126407
630
631         Reviewed by Brent Fulgham.
632
633         * EWSTools/start-queue-win.sh:
634
635 2014-01-06  Bem Jones-Bey  <bjonesbe@adobe.com>
636
637         Adding myself as a reviewer.
638
639         Unreviewed.
640
641         * Scripts/webkitpy/common/config/contributors.json:
642
643 2014-01-06  Zan Dobersek  <zdobersek@igalia.com>
644
645         Unreviewed. Unbreaking JSC tests after r161328.
646
647         * Scripts/webkitdirs.pm:
648         (cmakeBasedPortName): Only recognize the GTK port as CMake-based if actually building
649         through the CMake build system (i.e. passing --gtkcmake to build-webkit).
650
651 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
652
653         [GTK][CMake] Add support for building the GTK+ port with cmake to build-webkit
654         https://bugs.webkit.org/show_bug.cgi?id=126212
655
656         Reviewed by Daniel Bates.
657
658         Allow building the GTK+ cmake port with --gtkcmake.
659
660         * Scripts/build-webkit: Use the new isGtkCMake function to head down the CMake path
661         when appropriate. Skip the autotoos path when isGtkAutotools is false.
662         * Scripts/webkitdirs.pm: Add an isGtkCMake path in addition to the newly renamed isGtkAutotools.
663         Add isGtk which checks isGtkCMake || isGtkAutotools
664         (determineArchitecture): Use the CMake path for GTK+ when appropriate.
665         (argumentsForConfiguration): use --gtkcmake when appropriate.
666         (jscProductDir): Look in the CMake directory when appropriate.
667         (builtDylibPathForName): CMake builds the library into a different directory, so handle that.
668         (determineIsGtkCMake): Added.
669         (isGtkCMake): Added.
670         (isGtkAutotools): Renamed from isGtk.
671         (isGtk): New function which returns isGtkAutotools || isGtkCMake.
672         (determineIsGtkAutotools): Renamed from determineIsGtk.
673         (cmakeBasedPortName): Added a GTK+ path.
674
675 2014-01-04  Martin Robinson  <mrobinson@igalia.com>
676
677         [GTK] [CMake] Fix the video and audio build
678         https://bugs.webkit.org/show_bug.cgi?id=126464
679
680         Reviewed by Philippe Normand.
681
682         * GtkLauncher/CMakeLists.txt: Add GStreamer includes and libraries, since GtkLauncher uses it.
683
684 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
685
686         It's confusing to have two elements link to the same URL at build.webkit.org/dashboard
687         https://bugs.webkit.org/show_bug.cgi?id=126467
688
689         Reviewed by Geoffrey Garen.
690
691         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
692         (StatusLineView): Don't linkify the label text, the bubble is easier to target with mouse
693         pointer, or to tap.
694
695 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
696
697         build.webkit.org/dashboard says "failed build" even if it's another step that failed
698         https://bugs.webkit.org/show_bug.cgi?id=126461
699
700         Reviewed by Geoffrey Garen.
701
702         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
703         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
704         build page if it's not the compilation that failed. Use text from buildbot for description.
705         Show a yellow icon if it's a different kind of failure.
706
707         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
708         (BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
709
710 2014-01-03  Bem Jones-Bey  <bjonesbe@adobe.com>
711
712         setup-git-clone fails to get email address from git
713         https://bugs.webkit.org/show_bug.cgi?id=126446
714
715         Reviewed by Ryosuke Niwa.
716
717         The setup-git-clone command fails to get an email address from git
718         because of a bug in VCSUtils. This patch fixes that bug, and also
719         makes it so that when VCSUtils fails for real because of a local
720         misconfiguration, the error message is actually presented to the user
721         of setup-git-clone.
722
723         * Scripts/VCSUtils.pm:
724         (gitConfig): Call isGit() instead of accessing $isGit directly to make
725             sure that $isGit is properly initialized.
726         * Scripts/webkitpy/tool/commands/setupgitclone.py:
727         (SetupGitClone.execute): Pull out username and email acquistion to
728             it's own method.
729         (SetupGitClone._get_username_and_email): Catch the exception thrown
730             when VCSUtils fails and print out the error message so that the
731             user actually knows why the command failed.
732
733 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
734
735         It feels too hard to get rid of a popover at build.webkit.org/dashboard
736         https://bugs.webkit.org/show_bug.cgi?id=126451
737
738         Reviewed by Simon Fraser.
739
740         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
741         (.popover.fade-out): Reduced the timeout - 200 ms is enough to not have flicker
742         when moving the mouse from an element to its popover.
743
744 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
745
746         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
747         https://bugs.webkit.org/show_bug.cgi?id=122181
748
749         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
750         (BuildbotQueueView.prototype._presentNoChangePopover): Update one more place for
751         popover.present signature change.
752
753 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
754
755         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
756         https://bugs.webkit.org/show_bug.cgi?id=122181
757
758         Reviewed by Timothy Hatcher and Timothy Horton.
759
760         Detailed results are saved by run-webkit-tests to full_results.json (which is actually
761         JSONP). Dashboard will load them on demand.
762
763         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
764         (Buildbot.prototype.layoutTestResultsURLForIteration): Moved from WebKitBuildbot.js
765         and made it use a function from WebKitBuildbot that builds results directory path.
766         (Buildbot.prototype.layoutTestFullResultsURLForIteration): Added a function that builds
767         a URL for full_results.json.
768         (Buildbot.prototype.layoutTestCrashLogForIteration): Added a function that builds
769         a URL for a crash log.
770
771         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
772         (BuildbotIteration.prototype.loadLayoutTestResults): Load and cache layout test results for
773         the iteration.
774
775         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:        
776         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Updated for changed
777         popover API (see below).
778         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Ditto.
779
780         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
781         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Added a check
782         for iterations that were interrupted (previously, they were displayed incorrectly,
783         often as passes). Install popover trackers for failure bubbles for which we can currently
784         display something useful.
785         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Build
786         a popover for layout test regressions when we have the data loaded on demand.
787         We have test paths, special indicators for crashes/timeouts, and links to test history
788         at flakiness dashboard.
789         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Show
790         the popover for layout test regressions. Just shows "Loading..." until the data is
791         loaded.
792         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): List
793         types of failures if there are multiple. There is a lot of similarity with
794         appendBuilderQueueStatus(), but I couldn't find a good way to share the code.
795
796         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
797         Create a global test history object, which is used for links in layout test popover.
798
799         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
800         Changed the API to be more like WebInspector again, allowing for changing content
801         of an existing popover. As the size of a popover can change, making the mouse pointer
802         enter it without a mousenter event, install a handler for mousewheel instead, and block
803         document scrolling from this event handler when needed.
804
805         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
806         (StatusLineView.prototype.get statusBubbleElement): Added an accessor for status
807         bubble element, making it possible to install a popover on it.
808
809         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
810         (JSON.load): Added the ability to load JSONP by providing an optional callback name.
811
812         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
813         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Switched from
814         building a complete results URL to only building one for root results path. This is
815         the part that depends on specific buildbot installation, everything relative to it
816         is the same.
817
818         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js: Added.
819         Build a path to test history page. In the future, we may consider adding code to
820         load the data and display it inline.
821
822         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
823         Added styles for this new popover.
824
825         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added
826         a new file, WebKitTestHistory.js.
827
828 2014-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
829
830         REGRESSION(r161214): [GTK] WebKit2 C API tests fail to run after r161214
831         https://bugs.webkit.org/show_bug.cgi?id=126430
832
833         Reviewed by Martin Robinson.
834
835         * Scripts/run-gtk-tests:
836         (TestRunner._setup_testing_environment):
837         * gtk/common.py: Use common.tests_library_build_path() instead.
838         (tests_library_build_path): Helper funtion that returns the path
839         where the tests libraries are built.
840
841 2014-01-03  Martin Robinson  <mrobinson@igalia.com>
842
843         [CMake] Build TestWebKitAPI tests into a directory structure
844         https://bugs.webkit.org/show_bug.cgi?id=126358
845
846         Reviewed by Gyuyoung Kim.
847
848         WebKitGTK+ builds the TestWebKitAPI tests into a "TestWebKitAPI" directory. This
849         is useful for keeping the "bin" directory tidy during building and will make it easier
850         to integrate the CMake build into the existing WebKitGTK+ scripts.
851
852         * TestWebKitAPI/CMakeLists.txt: Set the output directory of all TestWebKitAPI binaries
853         and make the names simpler now that the directory identifies what category the test is in.
854
855 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
856
857         Provide a visual clue when element has a popover at build.webkit.org/dashboard
858         https://bugs.webkit.org/show_bug.cgi?id=126281
859
860         Reviewed by Timothy Hatcher.
861
862         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
863         (PopoverTracker): Add a class name to elements with popovers.
864
865         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
866         (*): We have -webkit-user-select:none, so let's also not show text selection cursor.
867         I might have broke that recently.
868         (*:link): Show hand cursor over links.
869         (.popover-tracking:hover): Put a shadow on hover over element with popovers.
870
871         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
872         (.status-line .message .revision-number): Show text selection cursor on our only
873         selectable text element.
874         (.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
875         a white shadow than with a dark one on hover.
876
877 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
878
879         [GTK] Add API to WebKitResponsePolicyDecision to check if the MIME type can be shown
880         https://bugs.webkit.org/show_bug.cgi?id=124652
881
882         Reviewed by Martin Robinson.
883
884         * MiniBrowser/gtk/BrowserWindow.c:
885         (webViewDecidePolicy): Use the new API instead of
886         webkit_web_view_can_show_mime_type().
887
888 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
889
890         REGRESSION(r160304): [GTK] Disable libtool fast install
891         https://bugs.webkit.org/show_bug.cgi?id=126381
892
893         Reviewed by Martin Robinson.
894
895         Remove -no-fast-install ld flag since fast install is now disabled
896         globally.
897
898         * GNUmakefile.am:
899         * GtkLauncher/GNUmakefile.am:
900         * MiniBrowser/gtk/GNUmakefile.am:
901         * TestWebKitAPI/GNUmakefile.am:
902         * WebKitTestRunner/GNUmakefile.am:
903
904 2014-01-02  Ryuan Choi  <ryuan.choi@samsung.com>
905
906         Unreviewed. Add myself to EFL and related watch lists.
907
908         * Scripts/webkitpy/common/config/watchlist:
909
910 2014-01-02  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
911
912         [GTK] fixing ycm_extra_conf.py file
913         https://bugs.webkit.org/show_bug.cgi?id=126371
914
915         It's an attempt to fix three problems with the current ycm_extra_conf file.
916         The current implementation assumes that it's a symlink, which is not true.
917         Usually python creates a pyc file, and this is what you get in __file__.
918         the .pyc is not a symlink, and the current implementation doesn't work
919         if that's the case.
920
921         It also assumes that the user is in the root folder.
922         If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work.
923
924         Last but not least, "elif flag in FLAGS_PRECEDING_PATHS" emits an
925         exception since "flag" doesn't exists.
926
927         All those things were fixed.
928
929         Reviewed by Martin Robinson.
930
931         * gtk/ycm_extra_conf.py:
932         (transform_relative_paths_to_absolute_paths):
933
934 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
935
936         Bindings tests results links are broken at build.webkit.org/dashboard
937         https://bugs.webkit.org/show_bug.cgi?id=126402
938
939         Reviewed by Tim Horton.
940
941         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
942         (Buildbot.prototype.bindingsTestResultsURLForIteration): Fixed a typo that was there
943         since the beginning.
944
945 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
946
947         "+" is very confusing at http://build.webkit.org/dashboard
948         https://bugs.webkit.org/show_bug.cgi?id=126400
949
950         Reviewed by Tim Horton.
951
952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
953         (BuildbotQueueView.prototype._appendPendingRevisionCount): Instead of listing open
954         source and internal counts separately, simply add them. One can always open a popover
955         for more detail.
956
957 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
958
959         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
960         https://bugs.webkit.org/show_bug.cgi?id=126391
961
962         Reviewed by Dan Bernstein.
963
964         Make it conditional, as trac.webkit.org doesn't work when withCredentials is enabled.
965         One can request credentials use via Initialization.js.
966
967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
968         (Trac):
969         (Trac.prototype.update):
970         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
971         (loadXML):
972
973 2014-01-02  Commit Queue  <commit-queue@webkit.org>
974
975         Unreviewed, rolling out r160846.
976         http://trac.webkit.org/changeset/160846
977         https://bugs.webkit.org/show_bug.cgi?id=126395
978
979         Breaks build scripts for Windows when Visual Studio is not
980         installed in Program Files (Requested by rfong on #webkit).
981
982         * Scripts/webkitdirs.pm:
983         (visualStudioInstallDir):
984
985 2014-01-02  Martin Robinson  <mrobinson@igalia.com>
986
987         [GTK] [CMake] run-gtk-tests should run with the cmake build
988         https://bugs.webkit.org/show_bug.cgi?id=126341
989
990         Reviewed by Carlos Garcia Campos.
991
992         * Scripts/run-gtk-tests:
993         (TestRunner.__init__): Use the new calling conventions for the common script.
994         (TestRunner._setup_testing_environment): Ditto.
995         * gtk/common.py:
996         (set_build_types): Added set_build_types, to avoid having build_type arguments
997         for all functions in common.
998         (binary_build_path): Added this function which gets the path to the built binaries.
999         (get_build_path): Removed the build_types argument.
1000         (build_path): Removed the build_types argument and call get_build_path directly now.
1001
1002 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
1003
1004         https://bugs.webkit.org/show_bug.cgi?id=126391
1005         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
1006
1007         Rubber-stamped by Dan Bernstein.
1008
1009         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1010         (loadXML): Quick and dirty fix, with a FIXME.
1011
1012 2014-01-01  Martin Robinson  <mrobinson@igalia.com>
1013
1014         [GTK] Rename libtestnetscapeplugin to libTestNetscapePlugin
1015         https://bugs.webkit.org/show_bug.cgi?id=126349
1016
1017         Reviewed by Carlos Garcia Campos.
1018
1019         All CMake ports use "libTestNetscapePlugin," so choosing the same
1020         name in the autotools port will make the transition easier.
1021
1022         * GNUmakefile.am: Rename the plugin library.
1023
1024 2014-01-01  ChangSeok Oh  <changseok.oh@collabora.com>
1025
1026         [GTK][WK2] Back items are shown in reverse order in MiniBrowser
1027         https://bugs.webkit.org/show_bug.cgi?id=126354
1028
1029         Reviewed by Carlos Garcia Campos.
1030
1031         The latest visited site for backward history should be placed on the top of a history stack
1032         as a common behavior. However currently its order is reverse.
1033
1034         * MiniBrowser/gtk/BrowserWindow.c:
1035         (browserWindowUpdateNavigationActions):
1036
1037 2013-12-30  Martin Robinson  <mrobinson@igalia.com>
1038
1039         [GTK] Make the output directory of GObject unit tests binaries consistent with the CMake build
1040         https://bugs.webkit.org/show_bug.cgi?id=126297
1041
1042         Reviewed by Philippe Normand.
1043
1044         * Scripts/run-gtk-tests: Looks for the tests in the new directories.
1045         (TestRunner): Ditto.
1046         (TestRunner._run_test): Ditto.
1047
1048 2013-12-30  Alexey Proskuryakov  <ap@apple.com>
1049
1050         full_results.json should distinguish unexpected failures from expected ones
1051         https://bugs.webkit.org/show_bug.cgi?id=126300
1052
1053         Reviewed by Timothy Hatcher.
1054
1055         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1056         (summarize_results): Add "report" element to JSON, which tells the consumer how
1057         this result was counted for summary.
1058
1059         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1060         Updated results to include the new element.
1061
1062         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1063         (print_unexpected_results): Added a comment pointing to another place that
1064         summarizes results, and should stay in sync.
1065
1066 2013-12-30  Ryuan Choi  <ryuan.choi@samsung.com>
1067
1068         Replace remaning CoreIPC namespace to IPC
1069         https://bugs.webkit.org/show_bug.cgi?id=126305
1070
1071         Reviewed by Anders Carlsson.
1072
1073         * TestWebKitAPI/CMakeLists.txt: Replaced CoreIPC includes to IPC.
1074         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed temporal define for IPC.
1075         * WebKitTestRunner/CMakeLists.txt: Replaced CoreIPC includes to IPC.
1076         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed temporal define for IPC.
1077
1078 2013-12-30  Brendan Long  <self@brendanlong.com>
1079
1080         Add myself to the committers list.
1081
1082         Unreviewed.
1083
1084         * Scripts/webkitpy/common/config/contributors.json:
1085
1086 2013-12-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1087
1088         [GTK] Split WebKit2APITests/TestWebKitWebView
1089         https://bugs.webkit.org/show_bug.cgi?id=126284
1090
1091         Reviewed by Philippe Normand.
1092
1093         Skip only WebKitWebView/mouse-target and all TestAuthentication
1094         tests that are timing out when running under xvfb.
1095
1096         * Scripts/run-gtk-tests:
1097         (TestRunner):
1098
1099 2013-12-29  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1100
1101         [EFL][WK2] Disable geolocation API test
1102         https://bugs.webkit.org/show_bug.cgi?id=125851
1103
1104         Reviewed by Gyuyoung Kim.
1105
1106         Geolocation is turned off by default in EFL port, so it shouldn't be tested.
1107
1108         * TestWebKitAPI/PlatformEfl.cmake: Move Geolocation to test_webkit2_api_fail_BINARIES.
1109
1110 2013-12-29  Ryuan Choi  <ryuan.choi@samsung.com>
1111
1112         [EFL] Remove ewk_view_tiled
1113         https://bugs.webkit.org/show_bug.cgi?id=125961
1114
1115         Reviewed by Gyuyoung Kim.
1116
1117         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1118         (shouldUseTiledBackingStore):
1119         Moved from DumpRenderTreeChrome to enable WebCore's TiledBackingStore
1120         instead of switching ewk_view_tiled.
1121         (DumpRenderTreeChrome::createView):
1122         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1123         (drtViewAdd):
1124         * EWebLauncher/main.c: Removed ewk_view_tiled option.
1125         (windowCreate):
1126         (parseUserArguments):
1127
1128 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
1129
1130         Pending revision popover is slightly misplaced at build.webkit.org/dashboard
1131         https://bugs.webkit.org/show_bug.cgi?id=126278
1132
1133         Reviewed by Timothy Hatcher.
1134
1135         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1136         (BuildbotQueueView.prototype._appendPendingRevisionCount): Create a span for the text,
1137         as StatusLineView message element has extra padding, and doesn't fit the text snugly.
1138         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Added bug number to a FIXME.
1139
1140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
1141         (StatusLineView.prototype.set messageElement): Removed the getter, as we no longer need it.
1142
1143         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1144         Removed display:inline-block hack for messageElement div, as we no longer use it for measuring text bounds.
1145
1146 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
1147
1148         Interrupted test runs should not count at build.webkit.org/dashboard
1149         https://bugs.webkit.org/show_bug.cgi?id=126279
1150
1151         Reviewed by Timothy Hatcher.
1152
1153         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1154         (BuildbotIteration.prototype.get productive):
1155         (BuildbotIteration.prototype.get previousProductiveIteration): Replaced previous with
1156         this accessor to skips iterations that don't have relevant data. We still want to
1157         display them, but revision ranges should not be affected.
1158         (BuildbotIteration.prototype.update): Record whether the iteration was up for retry.
1159
1160         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1161         Use latest productive iteration instead of latest iteration for pending revision
1162         count and popovers.
1163
1164 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
1165
1166         Please display (and link to) revision ranges at build.webkit.org/dashboard
1167         https://bugs.webkit.org/show_bug.cgi?id=122187
1168
1169         Reviewed by Timothy Hatcher.
1170
1171         Added popovers for revision numbers. Removed direct links, because they were misleading -
1172         a test run covers a revision range, not just the latest revision. This also makes
1173         selecting a revision for copy easier.
1174
1175         All revision numbers have the popovers for consistency, although they are most useful
1176         for iterations that are not the last ones in a view, because the content is a delta
1177         from previous iteration.
1178
1179         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1180         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
1181         revisionLinksForIteration() is now named revisionContentForIteration().
1182
1183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1184         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1185         Ditto.
1186
1187         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1188         (BuildbotIteration.prototype.get previous): Added a function to go back in iteration history.
1189
1190         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1191         Refactored to support the new popover variation. Replaced revisionLinksForIteration()
1192         with a function that builds an element with popover.
1193
1194         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
1195         Changed to take a function for popover presentation instead of delegate object.
1196         We only need one delegate function, and it's easier to have multiple popovers per view class
1197         this way.
1198
1199         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1200         Removed a rule for selectable class. It's replaced with a semantic rule in StatusLineView.css.
1201
1202         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1203         Renamed pending-commits-popover class to commit-history-popover.
1204
1205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1206         (.status-line .message .revision-number): Added a rule for revision numbers.
1207
1208 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
1209
1210         Please display information about pending runs in build.webkit.org/dashboard
1211         https://bugs.webkit.org/show_bug.cgi?id=122180
1212
1213         Reviewed by Timothy Hatcher.
1214
1215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1216         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Added a semicolon at the end of a line.
1217
1218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1219         (BuildbotQueueView.prototype._latestFinishedIteration): Factored out of _appendPendingRevisionCount.
1220         (BuildbotQueueView.prototype._appendPendingRevisionCount): Install a popover tracker over the element.
1221         (BuildbotQueueView.prototype.lineForCommit): Build an element for a particular commit ot be shown in popover.
1222         (BuildbotQueueView.prototype.presentPopoverForElement): Build and show popover content when PopoverTracker
1223         asks us to.
1224
1225         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Geometry.js: Added.
1226         Taken from WebInspector with minimal changes:
1227         - Changed root name from WebInspector to Dashboard.
1228         - Removed some unused functionality.
1229         - Added Rect.containsPoint.
1230
1231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js: Added.
1232         Popover has extensive changes compared to WebInspector version, only drawing code is the same:
1233         - Fixed to work in scrollable pages - WebInspector version assumes that window
1234         and document coordinates are the same, and also erroneously dismisses a scrollable
1235         popover if scrolling cascades out of it after reaching a bound.
1236         - Simplified API and implementation to Dashboard needs, it is no longer possible to
1237         change content of an existing popover.
1238         - Rewrote visibility tracking to be more complete, and not rely on external tracker
1239         object so much.
1240         - Added code to flash scroll bars when showing a scrollable popover.
1241
1242         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js: Added.
1243         Objects of this class show and hide popovers as appropriate for registered active elements.
1244
1245         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
1246         (StatusLineView.prototype.get messageElement): Added an accessor, so that we could
1247         install a popover on message element. It's the only visible element in pending commit
1248         line, but the line has different bounds, so we can't install a popover on it (it
1249         would be incorrectly positioned if we did).
1250
1251         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1252         (Trac.prototype._convertCommitInfoElementToObject):
1253         - Some trac installations report author in a different element, updated to support that.
1254         - Changed to parse title out of description, because trac titles are ugly. Also,
1255         we get a nice HTML with links from the description.
1256
1257         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1258         (Node.prototype.isAncestor): Copied from Web Inspector, only changing the form for
1259         consistency with the rest of this file (add a property on prototype with assignment
1260         instead of using Object.defineProperty).
1261         (Node.prototype.isDescendant): Ditto.
1262         (Node.prototype.isSelfOrAncestor): Ditto.
1263         (Node.prototype.isSelfOrDescendant): Ditto.
1264         (DOMTokenList.prototype.contains): Ditto.
1265
1266         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css: Added.
1267         Like JS counterpart, mostly lifted from Web Inspector.
1268
1269         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1270         Added style rules for pending commits popover.
1271
1272         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1273         (.status-line.no-bubble .message): Changed to display:inline-block, so that it fits
1274         to content, and we can show the popover in a correct place.
1275
1276         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added new files.
1277
1278 2013-12-27  Gavin Barraclough  <barraclough@apple.com>
1279
1280         Merge PageVisibilityState & ViewState::IsVisible in WebKit2
1281         https://bugs.webkit.org/show_bug.cgi?id=126214
1282
1283         Reviewed by Alexey Proskuryakov.
1284
1285         WebKit2 redundantly tracks the visibility of the view through two mechanisms - the visibility
1286         state, and the view state. Remove visibility state from the WebKit2 layer. The visibility
1287         state also tracks the prerender state - so split this out and handle it separately (a change
1288         we should make in WebCore, too).
1289
1290         Tools - WebKit2 no longer (poorly) supports a fake visibility state, so to test the page
1291         visibility mechanisms we should actually be changing characteristics of the view that will
1292         be detected by WebKit2 as a visibility change. This affects three things:
1293             1) On setVisibilityState WebKitTestRunner must actually change visibility of the view.
1294             2) The 'PageVisibilityState' test in the API tests is useless (as evidenced by the fact
1295                that page visibility has been broken in WebKit2 for a couple of months, and didn't
1296                catch this fact). Removed in favour of:
1297             3) 'PageVisibilityStateWithWindowChanges' - this is the good stuff. This actually tests
1298                the visibility mechanism. Beef this test up by adding coverage for: a) the prerender
1299             state, b) document.hidden, and c) too many state change notifications (it already looks
1300             for too few).
1301
1302         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1303         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Removed.
1304             - Removed PageVisibilityState - this test was ineffective, API no longer supports this
1305               test, and behaviour is covered by PageVisibilityStateWithWindowChanges.
1306         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1307         (-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1308         (runJavaScriptAlert):
1309             - Add checking for too many calls to the alert.
1310         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::setPrerender):
1311             - Added methods to set visibility to prerender.
1312         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1313             - Added checking of 'document.hidden'.
1314         * WebKitTestRunner/TestController.cpp:
1315         (WTR::TestController::setVisibilityState):
1316         * WebKitTestRunner/TestController.h:
1317         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1318         (WTR::TestController::setHidden):
1319         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1320         (WTR::TestController::setHidden):
1321         * WebKitTestRunner/mac/TestControllerMac.mm:
1322         (WTR::TestController::setHidden):
1323             - Add setHidden method; call this from setVisibilityState.
1324
1325 2013-12-27  Alexey Proskuryakov  <ap@apple.com>
1326
1327         Display EWS status on bot watcher's dashboard
1328         https://bugs.webkit.org/show_bug.cgi?id=126224
1329
1330         Silence spurious exceptions, no visible behavior change.
1331
1332         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1333         (EWSQueue.prototype.update): Removed code that was only needed for an experimental
1334         feature that wasn't landed.
1335
1336 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
1337
1338         Display EWS status on bot watcher's dashboard
1339         https://bugs.webkit.org/show_bug.cgi?id=126224
1340
1341         Reviewed by Timothy Hatcher.
1342
1343         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1344         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Added.
1345         Moved platform definitions out of Buildbot.js, as they are also needed for EWS.
1346
1347         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js: Added.
1349         (QueueView):
1350         (QueueView.prototype.updateSoon):
1351         (QueueView.prototype.update):
1352         (QueueView.prototype._updateHiddenState):
1353         Moved auto-update and hide logic to a base class, as it equally applies to EWS.
1354
1355         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Added.
1356         This is a peer to Buildbot.js and WebKitBuildbot.js.
1357
1358         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Added.
1359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Added.
1360         Quite simple for now, only keeping track of queue size.
1361         
1362         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1363         Initialize EWS.
1364
1365         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1366         Create EWS views.
1367
1368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1369         Updated for Buildbot.Platform rename, it's now Dashboard.Platform.
1370
1371         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Removed.
1372         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Removed.
1373         These were empty, no reason to waste the time loading them.
1374
1375         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Removed.
1376         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css.
1377         Renamed, as these styles apply to all queues, not just buildbot ones (and they have to, as columns should look alike).
1378
1379         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1380             - Changed page title, as it no longer displays just buildbot status.
1381             - Updated subresource lists for the new, renamed and removed files.
1382
1383 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
1384
1385         EWS status JSON should include Access-Control-Allow-Origin
1386         https://bugs.webkit.org/show_bug.cgi?id=126246
1387
1388         Reviewed by Ryosuke Niwa.
1389
1390         * QueueStatusServer/app.yaml: Update version.
1391         * QueueStatusServer/handlers/queuestatusjson.py:
1392         (QueueStatusJSON.get): Add the header field.
1393
1394 2013-12-26  Alexey Proskuryakov  <ap@apple.com>
1395
1396         Some links at build.webkit.org/dashboard don't show status messages, and aren't keyboard accessible
1397         https://bugs.webkit.org/show_bug.cgi?id=126234
1398
1399         Reviewed by Timothy Hatcher.
1400
1401         Changed elements that are semantically links from <div> to <a>.
1402
1403         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
1404         (StatusLineView): Create <a> or <div> elements conditionally on whether we have a URL.
1405         Don't try simulate a link with CSS/JS, it's not needed any more.
1406         (StatusLineView.prototype._clicked): Removed.
1407
1408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
1409         Removed text-decoration rules, default ones in Main.css now work for queue elements.
1410
1411         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1412         Simplified cursor rules.
1413         Added a universal rule for links to only show underline on hover, as this is what
1414         we want almost everywhere.
1415
1416         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1417         (.status-line .bubble): Added text-decoration: none, as this is the one place where
1418         we don't want it even on hover.
1419         (.status-line .label): Force display: block for consistent layout between <a>
1420         and <div>.
1421
1422 2013-12-25  Alexey Proskuryakov  <ap@apple.com>
1423
1424         Please clarify "pending" reporting at build.webkit.org/dashboard
1425         https://bugs.webkit.org/show_bug.cgi?id=122191
1426
1427         Reviewed by Timothy Hatcher.
1428
1429         Reporting the count of pending runs didn't make a lot of sense - first, runs are
1430         coalesced and sometimes even out of order, and second, buildbot's notion of pending
1431         run was confusingly different from dashboard's.
1432
1433         Let's display how many SVN revisions are pending. This can be somewhat misleading
1434         too, because some revisions (like those for other platforms) don't trigger builds,
1435         but it's better than what we had.
1436
1437         This patch also lays the groundwork for displaying detailed information about
1438         pending revisions.
1439
1440         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1441         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
1442         building pending status line directly, call newly added base class method.
1443
1444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1445         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Ditto.
1446
1447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1448         (BuildbotQueueView): Listen for events when new SVN revisions are landed, and update the view.
1449         (BuildbotQueueView.prototype._appendPendingRevisionCount): Add a line for pending
1450         SVN revisions. It uses a new style, StatusLineView.Status.NoBubble, because this
1451         information is secondary, and doesn't need as much attention.
1452         (BuildbotQueueView.prototype.revisionLinksForIteration): Build revisionURL through
1453         Trac, not through Buildbot.
1454         (BuildbotQueueView.prototype._newCommitsRecorded): Schedule an update, just like when
1455         iterations are updated.
1456
1457         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1458         Initialize a global webkitTrac object.
1459
1460         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
1461         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1462         Added a new style for messages without a bubble.
1463
1464         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1465         Added a model class for Trac, which keeps track of SVN timeline, and notifies
1466         listeners of changes. It uses an RSS interface to Trac, because there is no JSON one.
1467
1468         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
1469         (loadXML): Added a function to load XML asynchronously, just like existing JSON.load.
1470
1471         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1472         Removed tracRevisionURL() function. Now that we have a Trac object, it just makes
1473         more sense to build trac URLs through it.
1474
1475         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1476         Load Trac.js.
1477
1478 2013-12-25  Jongwoo Choi  <jw0330.choi@samsung.com>
1479
1480         [EFL] Activate keyboard homepage shortcut on efl minibrowser.
1481         https://bugs.webkit.org/show_bug.cgi?id=124636
1482
1483         Reviewed by Gyuyoung Kim.
1484
1485         * MiniBrowser/efl/main.c: Added.
1486         (on_key_down): Add a homepage shortcut using Alt + Home key. 
1487
1488 2013-12-25  Alexey Proskuryakov  <ap@apple.com>
1489
1490         Revision selection behavior at build.webkit.org/dashboard is annoying
1491         https://bugs.webkit.org/show_bug.cgi?id=126235
1492
1493         Reviewed by Tim Horton.
1494
1495         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1496         (BuildbotQueueView.prototype.revisionLinksForIteration): Make the whole message
1497         selectable, not just the numbers in it.
1498         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1499         (.selectable): Make selectable enable default behavior, not user-select:all.
1500
1501 2013-12-25  Martin Robinson  <mrobinson@igalia.com>
1502
1503         [GTK] [CMake] Clean up generated sources directories
1504         https://bugs.webkit.org/show_bug.cgi?id=126216
1505
1506         Reviewed by Gustavo Noronha Silva.
1507
1508         * DumpRenderTree/PlatformGTK.cmake: Use the new derived sources variables.
1509         * GtkLauncher/CMakeLists.txt: Ditto.
1510         * MiniBrowser/gtk/CMakeLists.txt: Ditto.
1511         * TestWebKitAPI/CMakeLists.txt: Now that the EFL and GTK+ forwarding header locations differ,
1512         move the platform-specific includes to the EFL and GTK platform files. Also clean up forwarding
1513         header generation into on target.
1514         * TestWebKitAPI/PlatformEfl.cmake: Added EFL-specific locations to the include list.
1515         * TestWebKitAPI/PlatformGTK.cmake: Added GTK-specific locations to the include list.
1516         * WebKitTestRunner/CMakeLists.txt: Same as for TestWebKitAPI.
1517         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
1518         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
1519         * gtk/generate-gtkdoc: Update to select the appropriate derived sources locations for
1520         the cmake build.
1521
1522 2013-12-23  Alexey Proskuryakov  <ap@apple.com>
1523
1524         Add a JSON interface for getting EWS queue status
1525         https://bugs.webkit.org/show_bug.cgi?id=126182
1526
1527         Reviewed by Ryosuke Niwa.
1528
1529         The current goal is to add an indicator of how many patches are in the queue, and
1530         the JSON also includes some other information that was easy to add.
1531
1532         * QueueStatusServer/app.yaml: Updated version for deployment.
1533
1534         * QueueStatusServer/handlers/queuestatusjson.py: Added. Returns a JSON with some
1535         bot and patch queue information.
1536
1537         * QueueStatusServer/index.yaml: Added an index for a new query that only returns
1538         bot ids.
1539
1540         * QueueStatusServer/main.py: Map /queue-status-json/ directory to QueueStatusJSON
1541         handler.
1542
1543         * QueueStatusServer/config: Added property svn:ignore.
1544         * QueueStatusServer/filters: Added property svn:ignore.
1545         * QueueStatusServer/loggers: Added property svn:ignore.
1546         * QueueStatusServer/handlers: Added property svn:ignore.
1547         * QueueStatusServer/model: Added property svn:ignore.
1548         Ignore compiled *.pyc files in all directories they appear in when running locally.
1549
1550 2013-12-23  Martin Robinson  <mrobinson@igalia.com>
1551
1552         Try to fix the build after r161017
1553
1554         * gtk/common.py:
1555         (is_cmake_build): Instead of checking whether the return value of build_path
1556         of the CMakeCache.txt file is None, check if a file actually exists at that path.
1557
1558 2013-12-23  Gustavo Noronha Silva  <gns@gnome.org>
1559
1560         [GTK] [CMake] Add support for generating gtkdoc
1561         https://bugs.webkit.org/show_bug.cgi?id=116376
1562
1563         Reviewed by Martin Robinson.
1564
1565         * gtk/common.py: look for files in the directories used by the cmake build as well.
1566
1567 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1568
1569         [GTK] Build with network process unconditionally
1570         https://bugs.webkit.org/show_bug.cgi?id=126128
1571
1572         Reviewed by Martin Robinson.
1573
1574         * Scripts/webkitperl/FeatureList.pm: Remove network-process
1575         feature command line option.
1576
1577 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1578
1579         [GTK] run-gtk-tests should always run glib tests with -k option
1580         https://bugs.webkit.org/show_bug.cgi?id=126132
1581
1582         Reviewed by Philippe Normand.
1583
1584         With -k command line option, gtester continues running all other
1585         test cases after a failure.
1586
1587         * Scripts/run-gtk-tests:
1588         (TestRunner._run_test_glib): Use -k option when runing glib tests
1589         to not stop on failure.
1590
1591 2013-12-22  Martin Robinson  <mrobinson@igalia.com>
1592
1593         [GTK][CMake] Integrate GResource for inspector files (and others?)
1594         https://bugs.webkit.org/show_bug.cgi?id=125569
1595
1596         Reviewed by Gustavo Noronha Silva.
1597
1598         * gtk/generate-inspector-gresource-manifest.py: Added.
1599
1600 2013-12-22  Csaba Osztrogonác  <ossy@webkit.org>
1601
1602         Last URTBF after r160971 to make EFL build happy.
1603
1604         * TestWebKitAPI/efl/PlatformWebView.cpp:
1605         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1606
1607 2013-12-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1608
1609         Unreviewed. Add myself to some more watch lists.
1610
1611         * Scripts/webkitpy/common/config/watchlist: Watch also soup, gst
1612         and binding scripts patches.
1613
1614 2013-12-20  Commit Queue  <commit-queue@webkit.org>
1615
1616         Unreviewed, rolling out r160941.
1617         http://trac.webkit.org/changeset/160941
1618         https://bugs.webkit.org/show_bug.cgi?id=126095
1619
1620         Doesn't handle subpixel layout being disabled (Requested by
1621         smfr on #webkit).
1622
1623         * gdb/webkit.py:
1624         (JSCJSStringPrinter.to_string):
1625         (add_pretty_printers):
1626         * lldb/lldb_webkit.py:
1627         (WTFMediaTime_SummaryProvider):
1628         (WTFStringProvider.to_string):
1629
1630 2013-12-20  Bem Jones-Bey  <bjonesbe@adobe.com>
1631
1632         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in gdb and lldb
1633         https://bugs.webkit.org/show_bug.cgi?id=126080
1634
1635         Reviewed by Anders Carlsson.
1636
1637         This changes the output of printing LayoutUnits to be in px, removing
1638         the need to divide by 64 manually.
1639
1640         This will lead to gdb output like:
1641
1642         m_frameRect = {
1643             m_location = LayoutPoint(0px, 0px),
1644             m_size = LayoutSize(800px, 585px)
1645         }
1646
1647         And lldb output like:
1648
1649         (const WebCore::LayoutRect) $0 = {
1650           m_location = { x = 744px, y = 1px }
1651           m_size = { width = 236px, height = 40px }
1652         }
1653
1654         This patch is based on patch for Blink by cbiesinger@chromium.org.
1655
1656         * gdb/webkit.py:
1657         (WebCoreLayoutUnitPrinter):
1658         (WebCoreLayoutUnitPrinter.__init__):
1659         (WebCoreLayoutUnitPrinter.to_string):
1660         (WebCoreLayoutSizePrinter):
1661         (WebCoreLayoutSizePrinter.__init__):
1662         (WebCoreLayoutSizePrinter.to_string):
1663         (WebCoreLayoutPointPrinter):
1664         (WebCoreLayoutPointPrinter.__init__):
1665         (WebCoreLayoutPointPrinter.to_string):
1666         (add_pretty_printers):
1667         * lldb/lldb_webkit.py:
1668         (__lldb_init_module):
1669         (WebCoreLayoutUnit_SummaryProvider):
1670         (WebCoreLayoutSize_SummaryProvider):
1671         (WebCoreLayoutPoint_SummaryProvider):
1672         (WebCoreLayoutUnitProvider):
1673         (WebCoreLayoutUnitProvider.__init__):
1674         (WebCoreLayoutUnitProvider.to_string):
1675         (WebCoreLayoutSizeProvider):
1676         (WebCoreLayoutSizeProvider.__init__):
1677         (WebCoreLayoutSizeProvider.get_width):
1678         (WebCoreLayoutSizeProvider.get_height):
1679         (WebCoreLayoutPointProvider):
1680         (WebCoreLayoutPointProvider.__init__):
1681         (WebCoreLayoutPointProvider.get_x):
1682         (WebCoreLayoutPointProvider.get_y):
1683
1684 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
1685
1686         [GTK] [CMake] Add support for building ImageDiff
1687         https://bugs.webkit.org/show_bug.cgi?id=125960
1688
1689         Reviewed by Gustavo Noronha Silva.
1690
1691         * CMakeLists.txt: Build ImageDiff for GTK+.
1692         * ImageDiff/PlatformGTK.cmake: Added.
1693
1694 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
1695
1696         [GTK] [CMake] Add support for building DumpRenderTree
1697         https://bugs.webkit.org/show_bug.cgi?id=125767
1698
1699         Reviewed by Gustavo Noronha Silva.
1700
1701         * CMakeLists.txt: Load the DumpRenderTree cmake file for GTK+ when WebKit1 is enabled.
1702         * DumpRenderTree/PlatformGTK.cmake: Added.
1703
1704 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
1705
1706         [GTK] [CMake] Add support for building WebKitTestRunner
1707         https://bugs.webkit.org/show_bug.cgi?id=125768
1708
1709         Reviewed by Gustavo Noronha Silva.
1710
1711         * CMakeLists.txt: Compile WebKitTestRunner for GTK+ when WebKit2 is enabled.
1712         * WebKitTestRunner/CMakeLists.txt: Remove some EFL specific flags from the common
1713         build file.
1714         * WebKitTestRunner/PlatformEfl.cmake: Move the flags here.
1715         * WebKitTestRunner/PlatformGTK.cmake: Added.
1716
1717 2013-12-20  Myles C. Maxfield  <mmaxfield@apple.com>
1718
1719         Myles C. Maxfield is a committer now
1720
1721         Unreviewed.
1722
1723         * Scripts/webkitpy/common/config/contributors.json:
1724
1725 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
1726
1727         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
1728         https://bugs.webkit.org/show_bug.cgi?id=125854
1729
1730         Reviewed by Chris Fleizach.
1731
1732         Ensure we don't ever create instances of AccessibilityUIElement
1733         wrapping invalid platform-specific accessibility objects in DRT,
1734         both for consistency with what WKTR does (so we avoid situations
1735         where some tests fail in WK2 and not in WK1) and also to avoid
1736         overlooking tests that might not be checking the right thing.
1737
1738         * DumpRenderTree/AccessibilityUIElement.cpp:
1739         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
1740         nullPtr if the platformUIElement() is not a valid one.
1741         * DumpRenderTree/AccessibilityUIElement.h:
1742         (AccessibilityUIElement::platformUIElement): Added const modifier.
1743
1744 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
1745
1746         Programmatically-inserted children lack accessibility events
1747         https://bugs.webkit.org/show_bug.cgi?id=100275
1748
1749         Reviewed by Chris Fleizach.
1750
1751         Update DRT and WebKitTestRunner to handle the children-changed
1752         signal properly, considering the detail and optional parameters.
1753
1754         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
1755         (axObjectEventListener):
1756         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
1757
1758 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1759
1760         Removed unused BUILDER_BASE_URL.
1761         https://bugs.webkit.org/show_bug.cgi?id=125442
1762
1763         Reviewed by Csaba Osztrogonác.
1764
1765         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1766         (JSONGeneratorTest._test_json_generation): Trivial test fix after r160900.
1767
1768 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1769
1770         Removed unused BUILDER_BASE_URL.
1771         https://bugs.webkit.org/show_bug.cgi?id=125442
1772
1773         Reviewed by Csaba Osztrogonác.
1774
1775         The string constant BUILDER_BASE_URL is passed around several times,
1776         but we don't use it anywhere. It is a leftover from Chromium, cleaned it up.
1777
1778         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1779         (Manager._upload_json_files):
1780         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1781         (JSONLayoutResultsGenerator.__init__):
1782         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1783         (JSONResultsGenerator.__init__):
1784
1785 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
1786
1787         check-webkit-style mistakenly flags assigning to a dereferenced pointer
1788         https://bugs.webkit.org/show_bug.cgi?id=126041
1789
1790         Reviewed by Ryosuke Niwa.
1791
1792         When checking for lines like "Foo *bar;", check-webkit-style doesn't make
1793         sure that there is a declaration. This patch makes sure that there is a
1794         declaration in order to flag spacing around asterisks.
1795
1796         * Scripts/webkitpy/style/checkers/cpp.py:
1797         (check_spacing):
1798         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1799         (CppStyleTest.test_pointer_reference_marker_location):
1800
1801 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
1802
1803         check-webkit-style marks rvalue references as violations
1804         https://bugs.webkit.org/show_bug.cgi?id=126000
1805
1806         Reviewed by Ryosuke Niwa.
1807
1808         Previously, check-webkit-style was making sure that any line with "&&" had
1809         spaces around it. However, we can now legitimately use "&&" without a previous
1810         space when declaring an rvalue reference. This patch relaxes this check.
1811
1812         * Scripts/webkitpy/style/checkers/cpp.py:
1813         (check_spacing):
1814         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1815         (CppStyleTest.test_spacing_for_binary_ops):
1816
1817 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
1818
1819         check-webkit-style marks auto return types for functions as violations
1820         https://bugs.webkit.org/show_bug.cgi?id=125999
1821
1822         Reviewed by Ryosuke Niwa.
1823
1824         If a function declaration ends with a "->" followed by a non whitespace
1825         string, don't mark as an invalid "{" on its own line
1826
1827         * Scripts/webkitpy/style/checkers/cpp.py:
1828         (check_braces):
1829         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1830         (CppStyleTest.test_brace_at_begin_of_line):
1831
1832 2013-12-19  Alex Christensen  <achristensen@webkit.org>
1833
1834         [WinCairo] More GStreamer preparations.
1835
1836         Unreviewed.
1837
1838         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props:
1839         Include FeatureDefinesCairo and WinCairo to compile the GLib part of WinLauncher.
1840
1841 2013-12-19  Lucas Forschler  <lforschler@apple.com>
1842
1843         Add Apple Mavericks perf bot.
1844         
1845         Unreviewed.
1846
1847         * BuildSlaveSupport/build.webkit.org-config/config.json:
1848
1849 2013-12-19  Commit Queue  <commit-queue@webkit.org>
1850
1851         Unreviewed, rolling out r160842.
1852         http://trac.webkit.org/changeset/160842
1853         https://bugs.webkit.org/show_bug.cgi?id=126003
1854
1855         broke accessibility/loading-iframe-updates-axtree.html
1856         (Requested by ap on #webkit).
1857
1858         * DumpRenderTree/AccessibilityUIElement.cpp:
1859         (AccessibilityUIElement::makeJSAccessibilityUIElement):
1860         * DumpRenderTree/AccessibilityUIElement.h:
1861         (AccessibilityUIElement::platformUIElement):
1862
1863 2013-12-19  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1864
1865         get_test_baseline should get Host from test_config
1866         https://bugs.webkit.org/show_bug.cgi?id=125989
1867
1868         Reviewed by Ryosuke Niwa.
1869
1870         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1871         (TestConfig.__init__):
1872         (RebaselineServer._prepare_config):
1873         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1874         (get_test_baselines):
1875         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1876         (get_test_config):
1877
1878 2013-12-19  Roger Fong  <roger_fong@apple.com>
1879
1880         Don't check VSINSTALLDIR when looking for Visual Studio install directory.
1881         https://bugs.webkit.org/show_bug.cgi?id=125998.
1882
1883         Reviewed by Alexey Proskuryakov.
1884
1885         * Scripts/webkitdirs.pm:
1886         (visualStudioInstallDir):
1887         Get rid of the VSINSTALLDIR check. We can't build on anything besides VS2013 now anyways.
1888
1889 2013-12-19  Mario Sanchez Prada  <mario.prada@samsung.com>
1890
1891         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
1892         https://bugs.webkit.org/show_bug.cgi?id=125854
1893
1894         Reviewed by Chris Fleizach.
1895
1896         Ensure we don't ever create instances of AccessibilityUIElement
1897         wrapping invalid platform-specific accessibility objects in DRT,
1898         both for consistency with what WKTR does (so we avoid situations
1899         where some tests fail in WK2 and not in WK1) and also to avoid
1900         overlooking tests that might not be checking the right thing.
1901
1902         * DumpRenderTree/AccessibilityUIElement.cpp:
1903         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
1904         nullPtr if the platformUIElement() is not a valid one.
1905         * DumpRenderTree/AccessibilityUIElement.h:
1906         (AccessibilityUIElement::platformUIElement): Added const modifier.
1907
1908 2013-12-18  Anders Carlsson  <andersca@apple.com>
1909
1910         Deprecate some WKMutableDictionary functions
1911         https://bugs.webkit.org/show_bug.cgi?id=125962
1912
1913         Reviewed by Tim Horton.
1914
1915         * TestWebKitAPI/PlatformUtilities.cpp:
1916         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1917         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1918         (TestWebKitAPI::didAssociateFormControls):
1919         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1920         (TestWebKitAPI::WillLoadTest::willLoadURLRequest):
1921         (TestWebKitAPI::WillLoadTest::willLoadDataRequest):
1922         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1923         (WTR::createMouseMessageBody):
1924         (WTR::EventSendingController::mouseMoveTo):
1925         (WTR::EventSendingController::leapForward):
1926         (WTR::createKeyDownMessageBody):
1927         (WTR::EventSendingController::mouseScrollBy):
1928         (WTR::EventSendingController::continuousMouseScrollBy):
1929         (WTR::EventSendingController::addTouchPoint):
1930         (WTR::EventSendingController::updateTouchPoint):
1931         (WTR::EventSendingController::setTouchModifier):
1932         (WTR::EventSendingController::setTouchPointRadius):
1933         (WTR::EventSendingController::touchStart):
1934         (WTR::EventSendingController::touchMove):
1935         (WTR::EventSendingController::touchEnd):
1936         (WTR::EventSendingController::touchCancel):
1937         (WTR::EventSendingController::clearTouchPoints):
1938         (WTR::EventSendingController::releaseTouchPoint):
1939         (WTR::EventSendingController::cancelTouchPoint):
1940         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1941         (WTR::InjectedBundle::done):
1942         (WTR::InjectedBundle::setMockGeolocationPosition):
1943         (WTR::InjectedBundle::setCustomPolicyDelegate):
1944         (WTR::InjectedBundle::setVisibilityState):
1945         (WTR::InjectedBundle::queueLoad):
1946         (WTR::InjectedBundle::queueLoadHTMLString):
1947         * WebKitTestRunner/TestController.cpp:
1948         (WTR::TestController::initialize):
1949         (WTR::TestController::resetStateToConsistentValues):
1950         * WebKitTestRunner/TestInvocation.cpp:
1951         (WTR::updateThreadedScrollingForCurrentTest):
1952         (WTR::updateLayoutType):
1953         (WTR::TestInvocation::invoke):
1954
1955 2013-12-18  Martin Robinson  <mrobinson@igalia.com>
1956
1957         [GTK] [CMake] Add support for building GtkLauncher
1958         https://bugs.webkit.org/show_bug.cgi?id=125766
1959
1960         Reviewed by Gustavo Noronha Silva.
1961
1962         * CMakeLists.txt: Add the GtkLauncher subdirectory for the GTK port.
1963         * GtkLauncher/CMakeLists.txt: Added.
1964         * GtkLauncher/main.c: Support including the CMake config file.
1965
1966 2013-12-18  Alex Christensen  <achristensen@webkit.org>
1967
1968         [WinCairo] Preparation for GStreamer on Windows.
1969         https://bugs.webkit.org/show_bug.cgi?id=125946
1970
1971         Reviewed by Brent Fulgham.
1972
1973         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1974         Use new GStreamer property sheets for WinCairo.
1975         * win/DLLLauncher/DLLLauncherMain.cpp:
1976         (modifyPath):
1977         (wWinMain):
1978         Prepend GStreamer bin directory to path if it exists.
1979
1980 2013-12-18  Anders Carlsson  <andersca@apple.com>
1981
1982         Remove now useless test.
1983
1984         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1985         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Removed.
1986         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Removed.
1987         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Removed.
1988
1989 2013-12-18  Gavin Barraclough  <barraclough@apple.com>
1990
1991         Fix page visibility api test, initialization in WebKit2
1992         https://bugs.webkit.org/show_bug.cgi?id=125933
1993
1994         Reviewed by Anders Carlsson.
1995
1996         The API test for page visibility is broken, fix this. This revealed a recent regression in WebKit2
1997         (introduced in https://bugs.webkit.org/show_bug.cgi?id=123379), caused by a typo removing a '!'.
1998
1999         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2000         (TestWebKitAPI::TEST_F):
2001             - Running a test on WebKit1 twice is not the same as running it on WebKit2!
2002
2003 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2004
2005         Should not have identifiers with underscores in them, especially not leading underscores.
2006         https://bugs.webkit.org/show_bug.cgi?id=125847
2007
2008         Reviewed by Darin Adler.
2009
2010         * Scripts/webkitpy/style/checkers/cpp.py:
2011         (check_identifier_name_in_declaration):
2012         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2013         (CppStyleTest.test_runtime_selfinit):
2014         (WebKitStyleTest.test_names):
2015
2016 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2017
2018         False webkit-check-style warnings on *.
2019         https://bugs.webkit.org/show_bug.cgi?id=125915
2020
2021         Reviewed by Darin Adler.
2022
2023         * Scripts/webkitpy/style/checkers/cpp.py:
2024         (check_spacing):
2025         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2026         (CppStyleTest.test_pointer_reference_marker_location):
2027
2028 2013-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2029
2030         prepare-ChangeLog doesn't handle templates properly
2031         https://bugs.webkit.org/show_bug.cgi?id=125853
2032
2033         Reviewed by Daniel Bates.
2034
2035         * Scripts/prepare-ChangeLog:
2036         (get_function_line_ranges_for_cpp):
2037         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2038         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
2039         (Class110<TemplateClass>::func36):
2040
2041 2013-12-18  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2042
2043         Move expectation parsing out of the constructor of TestExpectations
2044         https://bugs.webkit.org/show_bug.cgi?id=125439
2045
2046         Reviewed by Csaba Osztrogonác.
2047
2048         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2049         (LayoutTestRunnerTests._run_tests):
2050         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
2051         (LayoutTestRunnerTests.test_update_summary_with_result):
2052         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2053         (Manager.run):
2054         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2055         (ManagerTest.test_look_for_new_crash_logs):
2056         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
2057         (lint):
2058         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2059         (TestExpectations.suffixes_for_expectations):
2060         (TestExpectations.__init__):
2061         (TestExpectations):
2062         (TestExpectations.parse_generic_expectations):
2063         (TestExpectations.parse_default_port_expectations):
2064         (TestExpectations.parse_override_expectations):
2065         (TestExpectations.parse_all_expectations):
2066         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2067         (parse_exp):
2068         (SkippedTests.check):
2069         (SkippedTests.test_skipped_entry_dont_exist):
2070         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2071         (run_results):
2072         * Scripts/webkitpy/tool/commands/queries.py:
2073         (PrintExpectations._model):
2074         * Scripts/webkitpy/tool/commands/rebaseline.py:
2075         (RebaselineTest._update_expectations_file):
2076         (RebaselineExpectations._update_expectations_files):
2077         (RebaselineExpectations._tests_to_rebaseline):
2078
2079 2013-12-17  Jer Noble  <jer.noble@apple.com>
2080
2081         Fix TimeRanges::intersectWith
2082         https://bugs.webkit.org/show_bug.cgi?id=118802
2083
2084         Reviewed by Eric Carlson.
2085
2086         Add unit tests for WebCore/TimeRanges.
2087
2088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2089         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: Added.
2090         (TestWebKitAPI::ToString):
2091         (TestWebKitAPI::TEST):
2092
2093 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
2094
2095         Botwatcher's dashboard ceases to update itself after a while
2096         https://bugs.webkit.org/show_bug.cgi?id=125885
2097
2098         Reviewed by Timothy Hatcher.
2099
2100         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2101         Removed code that checked for the view being hidden. It's none of model's business.
2102
2103         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2104         (BuildbotQueueView): Find out what platform the view is for. Initlialize update timer.
2105         (BuildbotQueueView.prototype._updateHiddenState): Start or stop update timer as appropriate.
2106         We now stop the timer for hidden views.
2107         (BuildbotQueueView.prototype._updateQueues): Removed the logic for ignoring some updates.
2108
2109 2013-12-17  Anders Carlsson  <andersca@apple.com>
2110
2111         Fix the 32-bit build.
2112
2113         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
2114         * MiniBrowser/MiniBrowserWebProcessPlugIn.m:
2115
2116 2013-12-17  Anders Carlsson  <andersca@apple.com>
2117
2118         Give the MiniBrowser a bundle
2119         https://bugs.webkit.org/show_bug.cgi?id=125882
2120
2121         Reviewed by Sam Weinig.
2122
2123         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Added.
2124         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2125         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Added.
2126         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Added.
2127         (-[MiniBrowserWebProcessPlugIn webProcessPlugIn:initializeWithObject:]):
2128         * MiniBrowser/mac/AppDelegate.m:
2129         (-[BrowserAppDelegate init]):
2130         * MiniBrowser/mac/Bundle/Info.plist: Added.
2131         * MiniBrowser/mac/Bundle/MiniBrowserBundle_Prefix.pch: Added.
2132
2133 2013-12-17  Gavin Barraclough  <barraclough@apple.com>
2134
2135         Remove PageVisibilityStateUnloaded
2136         https://bugs.webkit.org/show_bug.cgi?id=125869
2137
2138         Reviewed by Anders Carlsson.
2139
2140         This is not currently supported by WebKit, remove this enum value.
2141         We can always add this back later if/when we add support for this state.
2142
2143         * DumpRenderTree/mac/TestRunnerMac.mm:
2144         (TestRunner::setPageVisibility):
2145         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
2146         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
2147         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2148         (WTR::TestRunner::setPageVisibility):
2149             - remove test for visibility state "unloaded"; this is no longer supported (it never really was).
2150
2151 2013-12-12  Martin Robinson  <mrobinson@igalia.com>
2152
2153         [GTK] [CMake] Build the plugin process against GTK+ 2
2154         https://bugs.webkit.org/show_bug.cgi?id=116374
2155
2156         Reviewed by Gustavo Noronha Silva.
2157
2158         * TestWebKitAPI/PlatformGTK.cmake: Add WebCorePlatformGTK to the list of
2159         libraries required for WebCore unit tests.
2160
2161 2013-12-17  Brent Fulgham  <bfulgham@apple.com>
2162
2163         [Win] Revise filter-build-webkit to deal with Windows build logs
2164         https://bugs.webkit.org/show_bug.cgi?id=125866
2165
2166         Reviewed by David Kilzer.
2167
2168         Enhance the script to accept a 'platform' argument. When platform
2169         'win' is provided, use processing for the Windows build file format.
2170         Otherwise, process the files as normal.
2171
2172         * Scripts/filter-build-webkit:
2173         (usageAndExit): Add a 'platform' argument
2174         (shouldIgnoreLine): When platform == 'win' use the new Windows
2175         rules for processing the build file.
2176
2177 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
2178
2179         Update style checker now that ENUM_CLASS is gone
2180         https://bugs.webkit.org/show_bug.cgi?id=125864
2181
2182         Reviewed by Anders Carlsson.
2183
2184         * Scripts/webkitpy/style/checkers/cpp.py:
2185         (_EnumState.process_clean_line):
2186         (check_braces):
2187         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2188         (NoNonVirtualDestructorsTest.test_enum_casing.Foo):
2189         (NoNonVirtualDestructorsTest.test_enum_casing):
2190         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123):
2191         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass):
2192         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum):
2193         (WebKitStyleTest.test_braces.CPP11EnumClass):
2194
2195 2013-12-17  Mario Sanchez Prada  <mario.prada@samsung.com>
2196
2197         [ATK] Expose accessibility objects for <dl>, <dt> and <dd>
2198         https://bugs.webkit.org/show_bug.cgi?id=125857
2199
2200         Reviewed by Chris Fleizach.
2201
2202         Add mappings to DRT & WKTR for the newly exposed roles, and
2203         increase the version of ATK used by the internal jhbuild.
2204
2205         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2206         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2207         * gtk/jhbuild.modules: Raise version of ATK up to 2.11.4.
2208
2209 2013-12-17  Alex Christensen  <achristensen@webkit.org>
2210
2211         [WinCairo] Adding support for GStreamer and GLib.
2212         https://bugs.webkit.org/show_bug.cgi?id=124867
2213
2214         Reviewed by Philippe Normand.
2215
2216         * WinLauncher/WinLauncher.cpp:
2217         (wWinMain):
2218         Added g_main_context_iteration in main event loop.
2219
2220 2013-12-17  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2221
2222         Fix for C++ should have the & or * beside the type not the variable name check.
2223         https://bugs.webkit.org/show_bug.cgi?id=125846
2224
2225         Reviewed by Darin Adler.
2226
2227         * Scripts/webkitpy/style/checkers/cpp.py:
2228         (check_spacing):
2229         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2230         (CppStyleTest.test_pointer_reference_marker_location):
2231
2232 2013-12-16  Rob Buis  <rob.buis@samsung.com>
2233
2234         Add my Samsung email address.
2235
2236         Unreviewed.
2237
2238         * Scripts/webkitpy/common/config/contributors.json:
2239
2240 2013-12-16  Oliver Hunt  <oliver@apple.com>
2241
2242         Cache getters and custom accessors on the prototype chain
2243         https://bugs.webkit.org/show_bug.cgi?id=125602
2244
2245         Reviewed by Michael Saboff.
2246
2247         Make sure bencher scripts also make noInline exist
2248
2249         * Scripts/bencher:
2250
2251 2013-12-16  Anders Carlsson  <andersca@apple.com>
2252
2253         Fix crash when trying to load a null HTML string
2254         https://bugs.webkit.org/show_bug.cgi?id=125801
2255
2256         Reviewed by Dan Bernstein.
2257
2258         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
2259         (TestWebKitAPI::TEST_F):
2260         Update test results.
2261
2262 2013-12-16  Alex Christensen  <achristensen@webkit.org>
2263
2264         Fixed Win64 build on VS2013.
2265         https://bugs.webkit.org/show_bug.cgi?id=125753
2266
2267         Reviewed by Brent Fulgham.
2268
2269         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2270         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2271         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2272         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2273         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2274         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2275         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2276         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2277         * win/record-memory/record-memory.vcxproj:
2278         Added correct PlatformToolset for 64-bit builds.
2279
2280 2013-12-16  Simon Fraser  <simon.fraser@apple.com>
2281
2282         Add a menu option to MiniBrowser to enable UI-side compositing
2283         https://bugs.webkit.org/show_bug.cgi?id=125793
2284
2285         Reviewed by Anders Carlsson.
2286         
2287         Make it possible to test UI-side compositing in MiniBrowser WK2 windows.
2288
2289         * MiniBrowser/mac/BrowserWindowController.h: Add optional protocol method
2290         to toggle UI-side compositing.
2291         * MiniBrowser/mac/MainMenu.xib: Add menu item to Debug menu.
2292         * MiniBrowser/mac/WK2BrowserWindowController.m:
2293         (-[WK2BrowserWindowController validateMenuItem:]):
2294         (-[WK2BrowserWindowController isUISideCompositingEnabled]):
2295         (-[WK2BrowserWindowController toggleUISideCompositing:]):
2296         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2297         Adjust the window title to indicate whether the window is using UI-side compositing.
2298
2299 2013-12-16  Commit Queue  <commit-queue@webkit.org>
2300
2301         Unreviewed, rolling out r160645.
2302         http://trac.webkit.org/changeset/160645
2303         https://bugs.webkit.org/show_bug.cgi?id=125787
2304
2305         Change breaks test-webkitpy (Requested by bfulgham on
2306         #webkit).
2307
2308         * Scripts/prepare-ChangeLog:
2309         (get_selector_line_ranges_for_css):
2310
2311 2013-12-16  David Farler  <dfarler@apple.com>
2312
2313         [ASAN] WebKitLauncher: Include libasancrashreporter.dylib in DYLD_INSERT_LIBRARIES if it exists
2314         https://bugs.webkit.org/show_bug.cgi?id=124610
2315
2316         Reviewed by Mark Rowe.
2317
2318         * WebKitLauncher/WebKitNightlyEnabler.m:
2319         (enableWebKitNightlyBehaviour):
2320         Add libasancrashreporter.dylib to DYLD_INSERT_LIBRARIES.
2321         * WebKitLauncher/main.m:
2322         (main):
2323         Include both libasancrashreporter and the nightly enabler to
2324         the list of libraries to insert.
2325
2326 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2327
2328         Resolve inconsistant style warning caused by r160319.
2329         https://bugs.webkit.org/show_bug.cgi?id=125772
2330
2331         Reviewed by Darin Adler.
2332
2333         * Scripts/webkitpy/style/checkers/cpp.py:
2334         (check_for_extra_new_line_at_eof):
2335         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2336         (CppStyleTest.test_newline_at_eof):
2337         (CppStyleTest.test_extra_newlines_at_eof):
2338
2339 2013-12-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
2340
2341         Remove mock_drt.py: parse_options() - --test-shell and --pixel-tests=<path>
2342         https://bugs.webkit.org/show_bug.cgi?id=125780
2343
2344         Reviewed by Darin Adler.
2345
2346         * Scripts/webkitpy/port/mock_drt.py:
2347         (main):
2348         (parse_options):
2349         (MockDRT.write_test_output):
2350         * Scripts/webkitpy/port/mock_drt_unittest.py:
2351         (MockDRTTest.assertTest):
2352         (MockDRTTest.test_reftest_mismatch):
2353
2354 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2355
2356         prepare-Changelog treats CSS keyframes as mismatched parentheses.
2357         https://bugs.webkit.org/show_bug.cgi?id=125435
2358
2359         Reviewed by Darin Adler.
2360
2361         * Scripts/prepare-ChangeLog:
2362         (get_selector_line_ranges_for_css):
2363
2364 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
2365
2366         [ATK] Expose accessibility objects for more WAI-ARIA roles
2367         https://bugs.webkit.org/show_bug.cgi?id=125596
2368
2369         Reviewed by Chris Fleizach.
2370
2371         Add mappings to DRT & WKTR for the newly exposed roles.
2372
2373         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2374         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2375
2376 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
2377
2378         [ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM
2379         https://bugs.webkit.org/show_bug.cgi?id=125594
2380
2381         Reviewed by Chris Fleizach.
2382
2383         Add mappings to DRT & WKTR for checkmenuitem role.
2384
2385         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2386         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2387
2388 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
2389
2390         [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
2391         https://bugs.webkit.org/show_bug.cgi?id=125587
2392
2393         Reviewed by Chris Fleizach.
2394
2395         Add mappings to DRT & WKTR for article roles.
2396
2397         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2398         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2399
2400 2013-12-16  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2401
2402         [FTL] Allow EFL to build FTL with the build-jsc script.
2403         https://bugs.webkit.org/show_bug.cgi?id=125774
2404
2405         Reviewed by Zoltan Herczeg.
2406
2407         * Scripts/build-jsc:
2408
2409 2013-12-16  Krzysztof Czech  <k.czech@samsung.com>
2410
2411         Add myself as a committer
2412
2413         Unreviewed.
2414
2415         * Scripts/webkitpy/common/config/contributors.json:
2416
2417 2013-12-15  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2418
2419         Refactor option handling in WebKitTestRunner.
2420         https://bugs.webkit.org/show_bug.cgi?id=123185
2421
2422         Reviewed by Darin Adler.
2423
2424         Option handling is refactored (according to the FIXME) that allows
2425         to automatically generate the help message.
2426
2427         * WebKitTestRunner/CMakeLists.txt:
2428         * WebKitTestRunner/GNUmakefile.am:
2429         * WebKitTestRunner/Options.cpp: Added.
2430         (WTR::Options::Options):
2431         (WTR::handleOptionTimeout):
2432         (WTR::handleOptionNoTimeout):
2433         (WTR::handleOptionNoTimeoutAtAll):
2434         (WTR::handleOptionVerbose):
2435         (WTR::handleOptionGcBetweenTests):
2436         (WTR::handleOptionPixelTests):
2437         (WTR::handleOptionPrintSupportedFeatures):
2438         (WTR::handleOptionComplexText):
2439         (WTR::handleOptionAcceleratedDrawing):
2440         (WTR::handleOptionRemoteLayerTree):
2441         (WTR::handleOptionUnmatched):
2442         (WTR::OptionsHandler::OptionsHandler):
2443         (WTR::Option::Option):
2444         (WTR::Option::matches):
2445         (WTR::OptionsHandler::parse):
2446         (WTR::OptionsHandler::printHelp):
2447         * WebKitTestRunner/Options.h: Added.
2448         * WebKitTestRunner/TestController.cpp:
2449         (WTR::TestController::initialize):
2450         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2451
2452 2013-12-15  Dan Bernstein  <mitz@apple.com>
2453
2454         32-bit build fix.
2455
2456         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2457         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
2458
2459 2013-12-14  Tim Horton  <timothy_horton@apple.com>
2460
2461         stylebot should warn when FeatureDefines differ
2462         https://bugs.webkit.org/show_bug.cgi?id=125748
2463
2464         Reviewed by Dan Bernstein.
2465
2466         Add a stylebot checker that ensures that FeatureDefines.xcconfig files
2467         are always exactly equal (and warns people adding new FeatureDefines.xcconfig files,
2468         an unlikely occurrance, to add them to the list).
2469
2470         It's a bit nontraditional for stylebot because it will warn on existing errors in the tree,
2471         but that is the most straightforward way to implement it (and we're at zero diffs right now).
2472
2473         * Scripts/webkitpy/style/checker.py:
2474         (_all_categories):
2475         (FileType):
2476         (CheckerDispatcher._file_type):
2477         (CheckerDispatcher._create_checker):
2478         * Scripts/webkitpy/style/checkers/featuredefines.py: Added.
2479         (FeatureDefinesChecker):
2480         (FeatureDefinesChecker.__init__):
2481         (FeatureDefinesChecker.check):
2482
2483 2013-12-13  Sam Weinig  <sam@webkit.org>
2484
2485         Fix API tests.
2486
2487         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
2488         (TestWebKitAPI::TEST_F):
2489
2490 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
2491
2492         [Win] Remove Pre-VS2013 support code.
2493         https://bugs.webkit.org/show_bug.cgi?id=125693
2494
2495         Reviewed by Darin Adler.
2496
2497         * DumpRenderTree/cg/ImageDiffCG.cpp: Remove strtof stub now supplied by
2498         the math library.
2499         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
2500
2501 2013-12-13  Lucas Forschler  <lforschler@apple.com>
2502
2503         Update Webkit bots.
2504         
2505         Unreviewed.
2506         
2507         * BuildSlaveSupport/build.webkit.org-config/config.json:
2508
2509 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
2510
2511         [Win] Unreviewed build fix after r160548
2512
2513         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Specify
2514         we are using vs12_xp target for Makefile-based projects.
2515
2516 2013-12-13  Lucas Forschler  <lforschler@apple.com>
2517
2518         Update Apple Webkit Bots
2519         
2520         Unreviewed.
2521
2522         * BuildSlaveSupport/build.webkit.org-config/config.json:
2523
2524 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
2525
2526         Unreviewed build fix after r160548.
2527
2528         * Scripts/webkitdirs.pm:
2529         (setupCygwinEnv): VCExpress.exe is now called WDExpress.exe.
2530
2531 2013-12-13  Lucas Forschler  <lforschler@apple.com>
2532
2533         Update Apple bots.
2534         
2535         Unreviewed.
2536
2537         * BuildSlaveSupport/build.webkit.org-config/config.json:
2538
2539 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
2540
2541         [Win] Switch WebKit solution to Visual Studio 2013
2542         https://bugs.webkit.org/show_bug.cgi?id=125192
2543
2544         Reviewed by Anders Carlsson.
2545
2546         Project files must reference vs12_xp for 32-bit builds. 
2547
2548         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2549         Update for VS2013
2550         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2551         Ditto
2552         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2553         Ditto
2554         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2555         Ditto
2556         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2557         Ditto
2558         * Scripts/webkitdirs.pm:
2559         (visualStudioInstallDir): Specify VS2013
2560         (visualStudioVersion): Ditto.
2561         (setupAppleWinEnv): Use VS2013 in messages
2562         (setupCygwinEnv): Ditto
2563         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2564         Update for VS2013
2565         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2566         Ditto
2567         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2568         Ditto
2569         * win/record-memory/record-memory.vcxproj:
2570         Ditto
2571
2572 2013-12-11  Martin Robinson  <mrobinson@igalia.com> and Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
2573
2574         Adding a .ycm_extra_conf file for webkitGtk
2575         https://bugs.webkit.org/show_bug.cgi?id=119618
2576
2577         Reviewed by Gustavo Noronha Silva.
2578
2579         Added a YouCompleteMe flag discovery script for Vim and the GTK+ port. The script
2580         read the GTK+ build files to determine dynamically what flags to compile a source
2581         file with. This allows Vim to provide auto-complete for C++/C language. See
2582         https://github.com/Valloric/YouCompleteMe for how to use this file.
2583
2584         * gtk/common.py:
2585         (get_build_path): Added a fatal argument to build_path to avoid crashing YCM on failure.
2586         * gtk/ycm_extra_conf.py: Added.
2587
2588 2013-12-12  Tim Horton  <timothy_horton@apple.com>
2589
2590         [wk2] Handle pinch-to-zoom gesture
2591         https://bugs.webkit.org/show_bug.cgi?id=125604
2592
2593         Reviewed by Simon Fraser.
2594
2595         * MiniBrowser/mac/WK2BrowserWindowController.m:
2596         (-[WK2BrowserWindowController awakeFromNib]):
2597         Enable handling of the magnification gesture in Minibrowser WebKit2 windows.
2598
2599 2013-12-12  Eunmi Lee  <eunmi15.lee@samsung.com>
2600
2601         Unreviewed. Add myself as a committer.
2602
2603         * Scripts/webkitpy/common/config/contributors.json:
2604
2605 2013-12-12  Lucas Forschler  <lforschler@apple.com>
2606
2607         Update hardware for Apple bots.
2608         
2609         Unreviewed.
2610
2611         * BuildSlaveSupport/build.webkit.org-config/config.json:
2612
2613 2013-12-12  Lucas Forschler  <lforschler@apple.com>
2614
2615         Remove unused Apple Bots.
2616         
2617         Unreviewed.
2618
2619         * BuildSlaveSupport/build.webkit.org-config/config.json:
2620
2621 2013-12-12  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
2622
2623         Unreviewed. Add myself as a committer.
2624
2625         * Scripts/webkitpy/common/config/contributors.json:
2626
2627 2013-12-12  Joseph Pecoraro  <pecoraro@apple.com>
2628
2629         Test new JSContext name APIs
2630         https://bugs.webkit.org/show_bug.cgi?id=125607
2631
2632         Reviewed by Darin Adler.
2633
2634         * Scripts/run-javascriptcore-tests:
2635         Remove trailing whitespace.
2636
2637 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
2638
2639         [Autotools] Prepend the WebCore layer archives' names with 'lib'
2640         https://bugs.webkit.org/show_bug.cgi?id=125627
2641
2642         Reviewed by Martin Robinson.
2643
2644         * TestWebKitAPI/GNUmakefile.am: Libtool can complain about the WebCore layer archives not being prepended
2645         with 'lib' when they are used during linking, so the prefix is now added to avoid such issues.
2646
2647 2013-12-12  Commit Queue  <commit-queue@webkit.org>
2648
2649         Unreviewed, rolling out r160446.
2650         http://trac.webkit.org/changeset/160446
2651         https://bugs.webkit.org/show_bug.cgi?id=125630
2652
2653         The upower-glib-based implementation is using API that was
2654         recently removed (Requested by zdobersek1 on #webkit).
2655
2656         * Scripts/webkitperl/FeatureList.pm:
2657
2658 2013-12-12  Commit Queue  <commit-queue@webkit.org>
2659
2660         Unreviewed, rolling out r160417.
2661         http://trac.webkit.org/changeset/160417
2662         https://bugs.webkit.org/show_bug.cgi?id=125629
2663
2664         The patch is causing crashes (Requested by zdobersek1 on
2665         #webkit).
2666
2667         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2668         (axObjectEventListener):
2669         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2670
2671 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
2672
2673         Use of ar T option not supported by older binutils
2674         https://bugs.webkit.org/show_bug.cgi?id=118732
2675
2676         Reviewed by Gustavo Noronha Silva.
2677
2678         * TestWebKitAPI/GNUmakefile.am: To support non-thin archives when generating the WebCoreLayer archive,
2679         switch to using the AR_FLAGS variable (which can be overridden) for providing the ar flags for the
2680         new archive. Non-thin archives also pose the problem as their members are only noted by the basename
2681         of the member's object file, and not the full path to it. To work around that, all the object files
2682         under the build directory are listed by their relative paths. The members of various archives then have
2683         the basenames of their paths grepped against that list, with the found path correlating to the member
2684         finally added as the new member of the WebCoreLayer archive.
2685
2686 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
2687
2688         check-webkit-style shouldn't check spacing in #if preprocessor lines
2689         https://bugs.webkit.org/show_bug.cgi?id=125534
2690
2691         Reviewed by Ryosuke Niwa.
2692
2693         Preprocessor lines that start with #if shouldn't have to adhere to
2694         the same spacing requirements that regular code does
2695
2696         * Scripts/webkitpy/style/checkers/cpp.py:
2697         (check_spacing):
2698         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2699         (CppStyleTest.test_spacing_for_binary_ops):
2700         (WebKitStyleTest.test_line_breaking):
2701
2702 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
2703
2704         check-webkit-style can't determine if a comma is part of an initialization list
2705         https://bugs.webkit.org/show_bug.cgi?id=125537
2706
2707         Reviewed by Darin Adler.
2708
2709         The original check to make sure that initialization list lines start with
2710         a comma didn't distinguish between commas that belong to the initialization
2711         list and commas that are part of function calls. Because we don't want to
2712         match parentheses with regular expressions, we should weaken this check to
2713         only check for commas at the end of initialization list lines.
2714
2715         * Scripts/webkitpy/style/checkers/cpp.py:
2716         (check_member_initialization_list):
2717         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2718         (WebKitStyleTest.test_member_initialization_list):
2719
2720 2013-12-11  Tim Horton  <timothy_horton@apple.com>
2721
2722         Make it possible to compare layout test results between various configurations of WebKit
2723         https://bugs.webkit.org/show_bug.cgi?id=125212
2724         <rdar://problem/15199108>
2725
2726         Reviewed by Darin Adler.
2727
2728         * Scripts/compare-webkit-configurations: Added.
2729         Add a script that allows comparison between the "normal" WebKit configuration
2730         used for testing and a different configuration (e.g. with accelerated drawing
2731         turned on, with the remote layer tree enabled, or WebKit1 vs WebKit2), like so:
2732
2733         compare-webkit-configurations -2 --comparison=accelerated-drawing compositing/background-color
2734
2735         This script runs the tests once in the default configuration, ignoring
2736         all test expectations, writing the results out to a temporary directory.
2737
2738         It then runs the tests again in the modified configuration, against the
2739         just-written temporary results.
2740
2741         Ref tests are treated as pixel tests, with their pixel output dumped to disk.
2742
2743         * DumpRenderTree/mac/DumpRenderTree.mm:
2744         (resetWebPreferencesToConsistentValues):
2745         (initializeGlobalsFromCommandLineOptions):
2746         Enable accelerated drawing if requested.
2747
2748         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2749         (parse_args):
2750         Add --accelerated-drawing and --remote-layer-tree feature switches, which
2751         are forwarded on to the test drivers.
2752         Move those two and --complex-text into their own "feature switches" section.
2753         Drive-by change "Mac OS X" to "OS X".
2754         Add --treat-ref-tests-as-pixel-tests option, which treats ref tests
2755         as traditional pixel tests (with PNGs dumped on disk), and
2756         ignores e.g. -expected.html files.
2757
2758         * Scripts/webkitpy/port/base.py:
2759         (Port.reference_files):
2760         Pretend that there are no ref tests.
2761         Since is_reference_html_file is intact, our mechanism to ignore
2762         the expected files will continue working in this case.
2763
2764         * Scripts/webkitpy/port/driver.py:
2765         (Driver.cmd_line):
2766         Forward --accelerated-drawing and --remote-layer-tree to DRT/WKTR.
2767
2768         * WebKitTestRunner/TestController.cpp:
2769         (WTR::TestController::TestController):
2770         (WTR::TestController::initialize):
2771         (WTR::TestController::resetPreferencesToConsistentValues):
2772         * WebKitTestRunner/TestController.h:
2773         (WTR::TestController::shouldUseRemoteLayerTree):
2774         * WebKitTestRunner/TestInvocation.cpp:
2775         (WTR::updateThreadedScrollingForCurrentTest):
2776         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2777         (WTR::PlatformWebView::PlatformWebView):
2778         Parse and implement the three feature switches.
2779
2780 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
2781
2782         [ATK] Expose accessibility objects WAI-ARIA landmark roles
2783         https://bugs.webkit.org/show_bug.cgi?id=125584
2784
2785         Reviewed by Chris Fleizach.
2786
2787         Add mappings to DRT & WKTR for landmark roles.
2788
2789         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2790         (AccessibilityUIElement::role):
2791         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2792         (WTR::AccessibilityUIElement::role):
2793         * gtk/jhbuild.modules:
2794
2795 2013-12-11  Alejandro G. Castro  <alex@igalia.com>
2796
2797         [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py
2798         https://bugs.webkit.org/show_bug.cgi?id=125441
2799
2800         Reviewed by Martin Robinson.
2801
2802         Just avoid the double quotations when building the parameter
2803         because some versions of valgrind are not handling it correctly.
2804
2805         * Scripts/webkitpy/port/gtk.py:
2806         (GtkPort.setup_environ_for_server):
2807
2808 2013-12-11  Zan Dobersek  <zdobersek@igalia.com>
2809
2810         [GTK] Enable Battery Status API
2811         https://bugs.webkit.org/show_bug.cgi?id=125453
2812
2813         Reviewed by Martin Robinson.
2814
2815         * Scripts/webkitperl/FeatureList.pm: Enable the Battery Status API feature for the GTK port.
2816
2817 2013-12-11  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
2818
2819         [GTK][WK2] Add the WebKitBatteryProvider class
2820         https://bugs.webkit.org/show_bug.cgi?id=115720
2821
2822         Reviewed by Martin Robinson.
2823
2824         * gtk/generate-gtkdoc:
2825         (get_webkit2_options): Ignore the WebKitBatteryProvider source files when generating the documentation.
2826
2827 2013-12-11  Mark Rowe  <mrowe@apple.com>
2828
2829         <https://webkit.org/b/125563> Remove the DumpRenderTree Perl Support module
2830
2831         Now that old-run-webkit-tests is not used on OS X it's not worth the time and effort
2832         to build and maintain this custom Perl module.
2833
2834         Reviewed by Anders Carlsson.
2835
2836         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
2837         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Removed.
2838         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
2839         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
2840         * DumpRenderTree/mac/PerlSupport/Makefile: Removed.
2841         * Scripts/old-run-webkit-tests: Update a comment that referred to DumpRenderTreeSupport as a reason to
2842         build DumpRenderTree.
2843         (dumpToolDidCrash): Stop importing and using the module.
2844         * Scripts/webkitpy/port/base.py:
2845         (Port._build_driver): Update a comment in the same manner as in old-run-webkit-tests.
2846
2847 2013-12-11  Brendan Long  <b.long@cablelabs.com>
2848
2849         [GTK] Add "enable-mediasource" property to WebKitWebSettings
2850         https://bugs.webkit.org/show_bug.cgi?id=125566
2851
2852         Reviewed by Philippe Normand.
2853
2854         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2855         (resetDefaultsToConsistentValues): Turn MediaSource on by default for easier testing.
2856         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2857         (TestRunner::overridePreference): Allow overriding WebKitMediaSourceEnabled.
2858
2859 2013-12-11  Dan Bernstein  <mitz@apple.com>
2860
2861         [Mac] Observe the activeURL property to keep the MiniBrowser URL field up to date
2862         https://bugs.webkit.org/show_bug.cgi?id=125579
2863
2864         Reviewed by Anders Carlsson.
2865
2866         * MiniBrowser/mac/WK2BrowserWindowController.m:
2867         (-[WK2BrowserWindowController dealloc]): Stop observing the activeURL property.
2868         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): When the
2869         activeURL property changes, update the URL field with its value.
2870         (-[WK2BrowserWindowController awakeFromNib]): Start observing the activeURL property.
2871         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]): Just log.
2872         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
2873         Ditto.
2874         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]):
2875         Ditto.
2876         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
2877         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
2878
2879 2013-12-11  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2880
2881         Fixed test-wepkitpy logging for buildslaves
2882         https://bugs.webkit.org/show_bug.cgi?id=125445
2883
2884         Reviewed by Csaba Osztrogonác.
2885
2886         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2887         (RunPythonTests):
2888
2889 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
2890
2891         Programmatically-inserted children lack accessibility events
2892         https://bugs.webkit.org/show_bug.cgi?id=100275
2893
2894         Reviewed by Chris Fleizach.
2895
2896         Update DRT and WebKitTestRunner to handle the children-changed
2897         signal properly, considering the detail and optional parameters.
2898
2899         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
2900         (axObjectEventListener):
2901         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
2902
2903 2013-12-03  Mark Rowe  <mrowe@apple.com>
2904
2905         <https://webkit.org/b/125139> Modernize the WebKit API headers
2906         <rdar://problem/15540175>
2907
2908         Reviewed by Anders Carlsson.
2909
2910         * DumpRenderTree/mac/TestRunnerMac.mm:
2911         (TestRunner::setCacheModel): Cast to the enum type.
2912
2913 2013-12-10  Filip Pizlo  <fpizlo@apple.com>
2914
2915         Get rid of forward exit on DoubleAsInt32
2916         https://bugs.webkit.org/show_bug.cgi?id=125552
2917
2918         Reviewed by Oliver Hunt.
2919         
2920         Add some support for testing the generic (non-X86) paths on X86 by disabling
2921         architecture-specific optimizations (ASO's).
2922
2923         * Scripts/run-javascriptcore-tests:
2924         * Scripts/run-jsc-stress-tests:
2925
2926 2013-12-10  Ryuan Choi  <ryuan.choi@samsung.com>
2927
2928         Unreviewed EFL build fix attempt
2929
2930         * TestWebKitAPI/CMakeLists.txt: Added ${WEBKIT2_DIR}/Platform/CoreIPC to include lists.
2931         * WebKitTestRunner/CMakeLists.txt: Ditto.
2932
2933 2013-12-10  Anders Carlsson  <andersca@apple.com>
2934
2935         Add a HashMap constructor that takes an initializer list
2936         https://bugs.webkit.org/show_bug.cgi?id=125551
2937
2938         Reviewed by Dan Bernstein.
2939
2940         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2941         (TestWebKitAPI::TEST):
2942
2943 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
2944
2945         Use std::array when computing MD5 checksum
2946         https://bugs.webkit.org/show_bug.cgi?id=125509
2947
2948         Reviewed by Anders Carlsson.
2949
2950         Use MD5::Digest type and MD5::hashSize when computing MD5 checksum.
2951
2952         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2953         (computeMD5HashStringForBitmapContext):
2954         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
2955         (computeMD5HashStringForBitmapContext):
2956         * TestWebKitAPI/Tests/WTF/MD5.cpp:
2957         (TestWebKitAPI::expectMD5):
2958         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2959         (WTR::computeMD5HashStringForCairoSurface):
2960         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2961         (WTR::computeMD5HashStringForContext):
2962
2963 2013-12-10  Mario Sanchez Prada  <mario.prada@samsung.com>
2964
2965         [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
2966         https://bugs.webkit.org/show_bug.cgi?id=125522
2967
2968         Reviewed by Chris Fleizach.
2969
2970         Update strings representing ATK_ROLE_SEPARATOR for layout tests.
2971
2972         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2973         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2974
2975 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
2976
2977         Add --makeargs option to build-jsc
2978         https://bugs.webkit.org/show_bug.cgi?id=125344
2979
2980         Reviewed by Filip Pizlo.
2981
2982         * Scripts/build-jsc: Handle and pass makefile arguments in jsc build.
2983
2984 2013-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
2985
2986         AX: [ATK] Convert the get_text atktest.c unit tests to layout tests
2987         https://bugs.webkit.org/show_bug.cgi?id=125497
2988
2989         Reviewed by Mario Sanchez Prada.
2990
2991         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2992         (AccessibilityUIElement::stringForRange): Implemented.
2993         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2994         (WTR::AccessibilityUIElement::stringForRange): Implemented.
2995
2996 2013-12-10  Martin Robinson  <mrobinson@igalia.com>
2997
2998         Various fixes for the CMake GTK+ build
2999
3000         Reviewed by Gustavo Noronha.
3001
3002         * MiniBrowser/gtk/CMakeLists.txt: Update source list and correct the name of BrowserMarshal.h.
3003         * TestWebKitAPI/PlatformGTK.cmake: Add GTK+ libraries to the test program. They're required.
3004
3005 2013-12-10  László Langó  <lango@inf.u-szeged.hu>
3006
3007         --cloop option does not work in Tools/Scripts/build-jsc.
3008         https://bugs.webkit.org/show_bug.cgi?id=125214
3009
3010         Reviewed by Csaba Osztrogonác.
3011
3012         * Scripts/build-jsc:
3013
3014 2013-12-10  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3015
3016         Merge mark_for_landing and mark_for_commit_queue into one argument
3017         https://bugs.webkit.org/show_bug.cgi?id=125448
3018
3019         Reviewed by Ryosuke Niwa.
3020
3021         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3022         (CommitQueueFlag):
3023         (Bugzilla._commit_queue_flag):
3024         (Bugzilla._fill_attachment_form):
3025         (Bugzilla.add_patch_to_bug):
3026         (Bugzilla.create_bug):
3027         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3028         (test_commit_queue_flag.assert_commit_queue_flag):
3029         (test_commit_queue_flag):
3030
3031 2013-12-09  Tim Horton  <timothy_horton@apple.com>
3032
3033         Remove dead extract_reference_link.py (and the reftests module)
3034         https://bugs.webkit.org/show_bug.cgi?id=125116
3035
3036         Reviewed by Ryosuke Niwa.
3037
3038         This code doesn't seem to have ever been used.
3039
3040         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Removed.
3041         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Removed.
3042         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Removed.
3043
3044 2013-12-09  Mario Sanchez Prada  <mario.prada@samsung.com>
3045
3046         [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
3047         https://bugs.webkit.org/show_bug.cgi?id=125456
3048
3049         Reviewed by Chris Fleizach.
3050
3051         Return 'AXSection' for section roles instead of 'AXDiv'.
3052
3053         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3054         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3055
3056 2013-12-09  Brian J. Burg  <burg@cs.washington.edu>
3057
3058         check-webkit-style should check for extra newlines at EOF
3059         https://bugs.webkit.org/show_bug.cgi?id=125424
3060
3061         Reviewed by Darin Adler.
3062
3063         Report a style violation if extraneous newlines are added
3064         to the end of a C++ file. There should only be one newline at EOF.
3065
3066         * Scripts/webkitpy/style/checkers/cpp.py:
3067         (check_for_missing_new_line_at_eof): Renamed from check_for_new_line_at_eof.
3068         (check_for_extra_new_line_at_eof): Added.
3069         (_process_lines): Added new check and renamed existing EOF check.
3070         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3071         (CppStyleTest.test_extra_newlines_at_eof): Added.
3072         (CppStyleTest.test_extra_newlines_at_eof.do_test): Added.
3073
3074 2013-12-09  Laszlo Vidacs  <lac@inf.u-szeged.hu>
3075
3076         check-webkit-style: ternary operator in macro call identified as initialization list
3077         https://bugs.webkit.org/show_bug.cgi?id=125443
3078
3079         Reviewed by Ryosuke Niwa.
3080
3081         Do not match initialization list when questionmark is placed before :
3082
3083         * Scripts/webkitpy/style/checkers/cpp.py:
3084         (check_member_initialization_list):
3085
3086 2013-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
3087
3088         AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests
3089         https://bugs.webkit.org/show_bug.cgi?id=125451
3090
3091         Reviewed by Mario Sanchez Prada.
3092
3093         Create the needed callbacks for DRT and WKTR.
3094
3095         * DumpRenderTree/AccessibilityUIElement.cpp:
3096         (characterAtOffsetCallback): added
3097         (wordAtOffsetCallback): added
3098         (lineAtOffsetCallback): added
3099         (sentenceAtOffsetCallback): added
3100         (AccessibilityUIElement::getJSClass):
3101         * DumpRenderTree/AccessibilityUIElement.h:
3102         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3103         (stringAtOffset): added
3104         (AccessibilityUIElement::characterAtOffset): added
3105         (AccessibilityUIElement::wordAtOffset): added
3106         (AccessibilityUIElement::lineAtOffset): added
3107         (AccessibilityUIElement::sentenceAtOffset): added
3108         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3109         (WTR::AccessibilityUIElement::characterAtOffset): added
3110         (WTR::AccessibilityUIElement::wordAtOffset): added
3111         (WTR::AccessibilityUIElement::lineAtOffset): added
3112         (WTR::AccessibilityUIElement::sentenceAtOffset): added
3113         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3114         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3115         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3116         (WTR::stringAtOffset): added
3117         (WTR::AccessibilityUIElement::characterAtOffset): added
3118         (WTR::AccessibilityUIElement::wordAtOffset): added
3119         (WTR::AccessibilityUIElement::lineAtOffset): added
3120         (WTR::AccessibilityUIElement::sentenceAtOffset): added
3121
3122 2013-12-08  Sam Weinig  <sam@webkit.org>
3123
3124         32-bit MiniBrowser doesn't build
3125         https://bugs.webkit.org/show_bug.cgi?id=125420
3126
3127         Reviewed by Dan Bernstein.
3128
3129         * MiniBrowser/mac/AppDelegate.h:
3130         * MiniBrowser/mac/AppDelegate.m:
3131         (-[BrowserAppDelegate init]):
3132         (-[BrowserAppDelegate applicationWillTerminate:]):
3133
3134 2013-12-08  Brian Holt  <brian.holt@samsung.com>
3135
3136         [WK2] Add ENABLE_NETWORK_PROCESS flag
3137         https://bugs.webkit.org/show_bug.cgi?id=125421
3138
3139         Add support to build with the Network Process enabled.
3140
3141         Reviewed by Martin Robinson.
3142
3143         * Scripts/webkitperl/FeatureList.pm:
3144
3145 2013-12-07  Filip Pizlo  <fpizlo@apple.com>
3146
3147         Fold typedArray.length if typedArray is constant
3148         https://bugs.webkit.org/show_bug.cgi?id=125252
3149
3150         Reviewed by Sam Weinig.
3151         
3152         Add Source/JavaScriptCore/tests/stress to the set of JS tests. This is where you
3153         should put tests that run just like JSRegress but don't run as part of LayoutTests.
3154         Currently I'm using it for tests that require some surgical support from jsc.cpp.
3155
3156         * Scripts/run-javascriptcore-tests:
3157
3158 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
3159
3160         [gdb] Update printers for WTF::CString, JSC::JSString
3161         https://bugs.webkit.org/show_bug.cgi?id=124600
3162
3163         Reviewed by Gustavo Noronha Silva.
3164
3165         Update the two printers after they fell behind the changes in implementation.
3166
3167         * gdb/webkit.py:
3168         (WTFCStringPrinter.to_string):
3169         (JSCJSStringPrinter.to_string):
3170
3171 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
3172
3173         [webkitpy] Add a WestonDriver unit test
3174         https://bugs.webkit.org/show_bug.cgi?id=125408
3175
3176         Reviewed by Gustavo Noronha Silva.
3177
3178         Add a webkitpy unit test for the Weston driver.
3179
3180         * Scripts/webkitpy/port/westondriver_unittest.py: Added.
3181         (WestonDriverTest):
3182         (WestonDriverTest.make_driver): Sets up a new WestonDriver instance for testing purposes.
3183         (WestonDriverTest.test_start): Check that the Weston compositor is launched properly and that
3184         the server environment contains proper WAYLAND and GDK_BACKEND entries.
3185         (WestonDriverTest.test_stop): Check that the Weston compositor is terminated properly and that
3186         the driver cleans up the temporary directory.
3187         (WestonDriverTest.test_stop.FakeWestonProcess): A helper class that logs the expected termination.
3188         (WestonDriverTest.test_stop.FakeWestonProcess.terminate):
3189
3190 2013-12-08  Brendan Long  <b.long@cablelabs.com>
3191
3192         [Gtk] install-dependencies doesn't install libgtk-3-dev
3193         https://bugs.webkit.org/show_bug.cgi?id=125320
3194
3195         Reviewed by Gustavo Noronha Silva.
3196
3197         * gtk/install-dependencies: Add libgtk-3-dev, libsoup2.4 and subversion
3198
3199 2013-12-07  Sam Weinig  <sam@webkit.org>
3200
3201         [Cocoa] Convert a few more parts of MiniBrowser over to the Objective-C API
3202         https://bugs.webkit.org/show_bug.cgi?id=125401
3203
3204         Reviewed by Dan Bernstein.
3205
3206         * MiniBrowser/mac/WK2BrowserWindowController.m:
3207         (-[WK2BrowserWindowController fetch:]):
3208         (-[WK2BrowserWindowController reload:]):
3209         (-[WK2BrowserWindowController goBack:]):
3210         (-[WK2BrowserWindowController goForward:]):
3211         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
3212         (-[WK2BrowserWindowController currentZoomFactor]):
3213         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
3214         (-[WK2BrowserWindowController zoomIn:]):
3215         (-[WK2BrowserWindowController zoomOut:]):
3216         (-[WK2BrowserWindowController canResetZoom]):
3217         (-[WK2BrowserWindowController resetZoom:]):
3218         (-[WK2BrowserWindowController toggleZoomMode:]):
3219         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
3220
3221 2013-12-07  Sam Weinig  <sam@webkit.org>
3222
3223         Convert MiniBrowser to use WKProcessGroup and WKBrowsingContextGroup
3224         https://bugs.webkit.org/show_bug.cgi?id=125400
3225
3226         Reviewed by Dan Bernstein.
3227
3228         * MiniBrowser/mac/AppDelegate.h:
3229         * MiniBrowser/mac/AppDelegate.m:
3230         * MiniBrowser/mac/WK2BrowserWindowController.h:
3231         * MiniBrowser/mac/WK2BrowserWindowController.m:
3232         (-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
3233         (-[WK2BrowserWindowController dealloc]):
3234         (createNewPage):
3235         (-[WK2BrowserWindowController awakeFromNib]):
3236         (-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
3237         (-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
3238         (-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
3239         (-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):
3240         Replace global WKContextRef and WKPageGroupRef with WKProcessGroup and WKBrowsingContextGroup. Also
3241         replace context based WKContextHistoryClient with WKBrowsingContextController based WKBrowsingContextHistoryDelegate
3242
3243 2013-12-07  Gustavo Noronha Silva  <gns@gnome.org>
3244
3245         [GTK] Run each gtest subtest separately instead of in one go
3246         https://bugs.webkit.org/show_bug.cgi?id=125386
3247
3248         Reviewed by Martin Robinson.
3249
3250         This is what other ports are doing (except they build each test as a separate binary)
3251         and will help with the timeouts we sometimes hit because it applies to the full test
3252         run.
3253
3254         * Scripts/run-gtk-tests:
3255         (TestRunner._get_tests_from_google_test_suite): get a list of available sub-tests.
3256         (TestRunner._run_google_test): run a single subtest from a gtest binary.
3257         (TestRunner._run_google_test_suite): call the binary once per subtest.
3258
3259 2013-12-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3260
3261         Move PrettyPatch related code to prettypatch.py
3262         https://bugs.webkit.org/show_bug.cgi?id=124937
3263
3264         Reviewed by Ryosuke Niwa.
3265
3266         This code seems to have a better place here than in Port, since PrettyPatch already knows
3267         pretty_patch_path, and this also unifies the usage of PrettyPatch
3268
3269         * Scripts/webkitpy/common/prettypatch.py:
3270         (PrettyPatch.__init__):
3271         (PrettyPatch.pretty_diff):
3272         (PrettyPatch):
3273         (PrettyPatch.pretty_patch_available):
3274         (PrettyPatch.check_pretty_patch):
3275         (PrettyPatch.pretty_patch_text):
3276         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3277         (TestResultWriter.create_text_diff_and_write_result):
3278         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3279         (summarize_results):
3280         * Scripts/webkitpy/port/base.py:
3281         (Port.__init__):
3282         (Port.wdiff_available):
3283         (Port.check_image_diff):
3284         (Port.wdiff_text):
3285         * Scripts/webkitpy/port/base_unittest.py:
3286         (PortTest.test_pretty_patch_os_error):
3287         (PortTest.test_pretty_patch_script_error):
3288
3289 2013-12-06  Dan Bernstein  <mitz@apple.com>
3290
3291         [Mac] MiniBrowser Debug builds are compiled with -Os
3292         https://bugs.webkit.org/show_bug.cgi?id=125376
3293
3294         Reviewed by Tim Horton.
3295
3296         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Set GCC_OPTIMIZATION_LEVEL to 0 for
3297         the Debug configuration at the project level.
3298
3299 2013-12-06  Jer Noble  <jer.noble@apple.com>
3300
3301         [MSE] Add a runtime-setting for the MediaSource constructor.
3302         https://bugs.webkit.org/show_bug.cgi?id=125336
3303
3304         Reviewed by Eric Carlson.
3305
3306         Enable MediaSource in DRT and WKTR.
3307
3308         * DumpRenderTree/mac/DumpRenderTree.mm:
3309         (resetWebPreferencesToConsistentValues):
3310         * WebKitTestRunner/TestController.cpp:
3311         (WTR::TestController::resetPreferencesToConsistentValues):
3312
3313 2013-12-06  Jer Noble  <jer.noble@apple.com>
3314
3315         Strip out extraneous logging from AppleGVA in media tests.
3316         https://bugs.webkit.org/show_bug.cgi?id=125357
3317
3318         Reviewed by Simon Fraser.
3319
3320         Add a mechanism for stripping out abritrary regular expressions from test input and output.
3321
3322         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3323         (SingleTestRunner._run_compare_test): Strip out logging
3324         * Scripts/webkitpy/port/base.py:
3325         (Port.logging_patterns_to_strip): Return an empty list by default.
3326         * Scripts/webkitpy/port/driver.py:
3327         (DriverOutput.strip_patterns): Apply the port specific patterns to the text.
3328         * Scripts/webkitpy/port/mac.py:
3329         (MacPort.logging_patterns_to_strip): Return a complete list.
3330
3331 2013-12-06  Dean Jackson  <dino@apple.com>
3332
3333         Updating ANGLE should point to instructions
3334         https://bugs.webkit.org/show_bug.cgi?id=125361
3335
3336         Reviewed by Eric Carlson.
3337
3338         Point to https://trac.webkit.org/wiki/UpdatingANGLE when
3339         someone wants to patch ANGLE.
3340
3341         * Scripts/webkitpy/common/config/watchlist:
3342
3343 2013-12-06  Dan Bernstein  <mitz@apple.com>
3344
3345         [Mac] Transition MiniBrowser to the Cocoa API: load delegate
3346         https://bugs.webkit.org/show_bug.cgi?id=125334
3347
3348         Reviewed by Darin Adler.
3349
3350         * MiniBrowser/mac/WK2BrowserWindowController.m:
3351         (-[WK2BrowserWindowController dealloc]): Nil out the load delegate and stop observing the
3352         title property.
3353         (-[WK2BrowserWindowController isPaginated]): Changed to use Cocoa SPI.
3354         (-[WK2BrowserWindowController togglePaginationMode:]): Ditto.
3355         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): Update the
3356         window title with the title property changes.
3357         (-[WK2BrowserWindowController awakeFromNib]): Start observing the title property. Changed to
3358         set the load delegate instead of the load client.
3359         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Changed to use Cocoa types.
3360         (-[WK2BrowserWindowController updateProvisionalURL]): Removed frame parameter.
3361         (-[WK2BrowserWindowController updateCommittedURL]): Ditto.
3362         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
3363         Implemented this load delegate method.
3364         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
3365         Ditto.
3366         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]): Ditto.
3367         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
3368         (-[WK2BrowserWindowController browsingContextControllerDidFinishLoad:]): Ditto.
3369         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
3370         (-[WK2BrowserWindowController browsingContextControllerDidChangeBackForwardList:addedItem:removedItems:]):
3371         Ditto.
3372         (-[WK2BrowserWindowController browsingContextController:canAuthenticateAgainstProtectionSpace:]):
3373         Ditto.
3374         (-[WK2BrowserWindowController browsingContextController:didReceiveAuthenticationChallenge:]): Ditto.
3375
3376 2013-12-06  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
3377
3378         Remove function from style/checkers/cpp.py.
3379         https://bugs.webkit.org/show_bug.cgi?id=125341
3380
3381         Reviewed by Darin Adler.
3382
3383         Corrects a FIXME: by removing a function from cpp.py.
3384
3385         * Scripts/webkitpy/style/checkers/cpp.py:
3386         (CppChecker.__init__):
3387         (CppChecker.check):
3388         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3389         (CppStyleTestBase.process_file_data):
3390
3391 2013-12-06  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
3392
3393         check-webkit-style: false positive warning for indentation of #ifdef code.
3394         https://bugs.webkit.org/show_bug.cgi?id=125254
3395
3396         Reviewed by Darin Adler.
3397
3398         * Scripts/webkitpy/style/checkers/cpp.py:
3399         (check_member_initialization_list):
3400         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3401         (WebKitStyleTest.test_member_initialization_list):
3402
3403 2013-12-06  Chris Fleizach  <cfleizach@apple.com>
3404
3405         Fix spelling error in style checker: beggining
3406         https://bugs.webkit.org/show_bug.cgi?id=125347
3407
3408         Reviewed by Anders Carlsson.
3409
3410         * Scripts/webkitpy/style/checkers/cpp.py:
3411         (check_member_initialization_list):
3412         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3413         (WebKitStyleTest.test_member_initialization_list):
3414
3415 2013-12-06  Lukasz Gajowy  <l.gajowy@samsung.com>
3416
3417         [ATK] Missing aria roles mappings
3418         https://bugs.webkit.org/show_bug.cgi?id=117729
3419
3420         Reviewed by Mario Sanchez Prada.
3421
3422         Added new mappings to AccessibilityUIElementAtk.cpp.
3423
3424         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3425         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3426
3427 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
3428
3429         Typo fix after r160218.
3430
3431         * Scripts/webkitpy/test/main.py:
3432         (main):
3433
3434 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
3435
3436         Unreviewed fix after r160206.
3437
3438         * Scripts/webkitpy/test/main.py:
3439         (main): sys.platform can be win32 or cygwin too on Windows.
3440
3441 2013-12-05  Csaba Osztrogonác  <ossy@webkit.org>
3442
3443         Disable WebKit2 webkitpy unittests on Windows
3444         https://bugs.webkit.org/show_bug.cgi?id=125318
3445
3446         Reviewed by Ryosuke Niwa.
3447
3448         * Scripts/webkitpy/test/main.py:
3449         (main):
3450
3451 2013-12-05  Anders Carlsson  <andersca@apple.com>
3452
3453         Tweak WeakObjCPtr
3454         https://bugs.webkit.org/show_bug.cgi?id=125311
3455
3456         Reviewed by Darin Adler.
3457
3458         Split up tests into more logical groups. Add new tests for new functionality.
3459
3460         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
3461
3462 2013-12-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3463
3464         [GTK] Fix gtk-doc warnings when generating DOM bindings API docs
3465         https://bugs.webkit.org/show_bug.cgi?id=125302
3466
3467         Reviewed by Philippe Normand.
3468
3469         * gtk/generate-webkitdom-doc-files:
3470         (WebKitDOMDocGeneratorSections.write_footer): Add a new section
3471         containing a private subsection for WEBKIT_API, WEBKIT_DEPRECATED
3472         and WEBKIT_DEPRECATED_FOR macros.
3473
3474 2013-12-05  Laszlo Vidacs  <lac@inf.u-szeged.hu>
3475
3476         Fix cross compilation on x86
3477         https://bugs.webkit.org/show_bug.cgi?id=125295
3478
3479         Reviewed by Zoltan Herczeg.
3480
3481         Certain compiler flags should not be added when cross compilation is enabled.
3482
3483         * Scripts/webkitdirs.pm:
3484         (runAutogenForAutotoolsProjectIfNecessary):
3485         (generateBuildSystemFromCMakeProject):
3486
3487 2013-12-05  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
3488
3489         Remove duplicated/dead code from cpp style checker unit tests.
3490         https://bugs.webkit.org/show_bug.cgi?id=125226
3491
3492         Reviewed by Ryosuke Niwa.
3493
3494         Remove the first definition of OrderOfIncludesTest class as it is
3495         overwritten by the second. Remove a duplicated assert statement
3496         from the second class.
3497
3498         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3499         (OrderOfIncludesTest.setUp):
3500         (OrderOfIncludesTest.test_try_drop_common_suffixes):
3501           The last assert was duplicated.
3502
3503 2013-12-05  László Langó  <lango@inf.u-szeged.hu>
3504
3505         Remove Scripts/generate-qt-inspector-resource.
3506         https://bugs.webkit.org/show_bug.cgi?id=125288
3507
3508         Reviewed by Andreas Kling.
3509
3510         * Scripts/generate-qt-inspector-resource: Removed. There is no QT anymore.
3511         We don't need this file.
3512
3513 2013-12-05  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3514
3515         Remove certain methods from TestExpectations and use TestExpectationsModel instead of them
3516         https://bugs.webkit.org/show_bug.cgi?id=125218
3517
3518         Reviewed by Ryosuke Niwa.
3519
3520         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3521         (LayoutTestFinder.skip_tests):
3522         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3523         (LayoutTestRunner.run_tests):
3524         (LayoutTestRunner._update_summary_with_result):
3525         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3526         (Manager._test_is_slow):
3527         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3528         (JSONLayoutResultsGenerator._insert_failure_summaries):
3529         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3530         (TestExpectations.get_rebaselining_failures):
3531         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3532         (assert_exp):
3533         (MiscTests.test_multiple_results):
3534         (MiscTests.test_category_expectations):
3535         (MiscTests.test_get_modifiers):
3536         (MiscTests.test_get_expectations_string):
3537         (MiscTests.test_expectation_to_string):
3538         (MiscTests.test_get_test_set):
3539         (MiscTests.test_more_specific_override_resets_skip):
3540         (SkippedTests.check):
3541         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3542         (TestRunResults.__init__):
3543         (summarize_results):
3544         * Scripts/webkitpy/tool/commands/rebaseline.py:
3545         (RebaselineExpectations._tests_to_rebaseline):
3546
3547 2013-12-04  Ryosuke Niwa  <rniwa@webkit.org>
3548
3549         Enable HTMLTemplateElement by default
3550         https://bugs.webkit.org/show_bug.cgi?id=123851
3551
3552         Reviewed by Antti Koivisto.
3553
3554         * Scripts/webkitperl/FeatureList.pm:
3555
3556 2013-12-04  Jozsef Berta  <jberta@inf.u-szeged.hu>
3557
3558         [EFL] Bumping GStreamer version to 1.2.1
3559         https://bugs.webkit.org/show_bug.cgi?id=125155
3560
3561         Reviewed by Gyuyoung Kim.
3562
3563         * efl/jhbuild.modules: Set the GStreamer version to 1.2.1
3564
3565
3566 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
3567
3568         Update jhbuild revision.
3569         https://bugs.webkit.org/show_bug.cgi?id=124966
3570         
3571         Reviewed by Gyuyoung Kim.
3572
3573         Used version of Jhbuild failed to create directories and caused
3574         update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.
3575
3576         * jhbuild/jhbuild-wrapper:
3577
3578 2013-12-04  Anders Carlsson  <andersca@apple.com>
3579
3580         Add a WeakObjCPtr class
3581         https://bugs.webkit.org/show_bug.cgi?id=125267
3582
3583         Reviewed by Geoffrey Garen.
3584
3585         Add API tests for WeakObjCPtr.
3586
3587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3588         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
3589         (TEST):
3590
3591 2013-12-04  Anders Carlsson  <andersca@apple.com>
3592
3593         Make the estimatedProgress property observable using KVO
3594         https://bugs.webkit.org/show_bug.cgi?id=125259
3595
3596         Reviewed by Dan Bernstein.
3597
3598         Bind the progress indicator value to the "estimatedProgress" property.
3599
3600         * MiniBrowser/mac/WK2BrowserWindowController.m:
3601         (-[WK2BrowserWindowController dealloc]):
3602         (-[WK2BrowserWindowController awakeFromNib]):
3603