Make LegacyCustomProtocolManager optional for network process
[WebKit-https.git] / Tools / ChangeLog
1 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
2
3         Make LegacyCustomProtocolManager optional for network process
4         https://bugs.webkit.org/show_bug.cgi?id=176230
5
6         Reviewed by Alex Christensen.
7
8         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
9
10 2017-11-30  Dewei Zhu  <dewei_zhu@apple.com>
11
12         HTTP server driver is responsible for ensuring the dependencies of HTTP server.
13         https://bugs.webkit.org/show_bug.cgi?id=180231
14
15         Reviewed by Stephanie Lewis.
16
17         Added the logic to ensure system environment meet the requirments of launching the http server.
18
19         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
20         (SimpleHTTPServerDriver.serve):
21         (SimpleHTTPServerDriver.set_device_id):
22         (SimpleHTTPServerDriver):
23         (SimpleHTTPServerDriver._ensure_http_server_dependencies):
24
25 2017-11-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
26
27         [WinCairo] Cannot build without Internet connection
28         https://bugs.webkit.org/show_bug.cgi?id=180068
29
30         Reviewed by Alex Christensen
31
32         With no Internet connection, if libraries has been downloaded
33         before, trust that version and keep building.
34
35         * Scripts/download-latest-github-release.py:
36         (Status):
37         (current_release):
38         (has_latest_release):
39         (main):
40
41 2017-11-30  Alex Christensen  <achristensen@webkit.org>
42
43         WKURLSchemeHandler.request should include HTTPBody
44         https://bugs.webkit.org/show_bug.cgi?id=180220
45
46         Reviewed by Brady Eidson.
47
48         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
49         (-[FormSubmissionDelegate webView:startURLSchemeTask:]):
50
51 2017-11-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
52
53         Add a script for automatically running the buildbot configurations on a test environment.
54         https://bugs.webkit.org/show_bug.cgi?id=169084
55
56         Reviewed by Michael Catanzaro.
57
58         This new script does the following:
59         - Creates a temporal workingdir.
60         - Installs buildbot and its dependencies there (very same version used by the webkit.org buildbot master https://build.webkit.org/about ).
61           This is important as there are problems that that may not be detected if you don't test with the same version that will be used on production.
62         - Copies the buildmaster config files to the temporal workingdir.
63         - Performs the required steps to start a buildmaster.
64         - Creates the required config for each slave and starts all of them.
65
66         The test buildmaster should be accessible at http://localhost:8710/ allowing to trigger manual builds.
67         This allows to test any configuration changes on this test environment that is pretty much identical to the production one.
68
69         * BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py: Added.
70         (check_tcp_port_open):
71         (upgrade_db_needed):
72         (create_tempdir):
73         (print_if_error_stdout_stderr):
74         (setup_master_workdir):
75         (wait_for_master_ready):
76         (start_master):
77         (get_list_workers):
78         (start_worker):
79         (clean):
80         (cmd_exists):
81         (check_buildbot_installed):
82         (setup_virtualenv):
83         (configdir_is_valid):
84         (main):
85
86 2017-11-30  Aakash Jain  <aakash_jain@apple.com>
87
88         [build.webkit.org] Move python code from master.cfg in separate files
89         https://bugs.webkit.org/show_bug.cgi?id=180180
90
91         Reviewed by Alexey Proskuryakov.
92
93         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved code to steps.py and master.cfg appropriately.
94         * BuildSlaveSupport/build.webkit.org-config/factories.py: Moved all factory related code from master.cfg.
95         * BuildSlaveSupport/build.webkit.org-config/steps.py: Moved all steps related code from master.cfg
96
97 2017-11-30  Wenson Hsieh  <wenson_hsieh@apple.com>
98
99         WKAttachmentTests.InPlaceImageAttachmentToggleDisplayMode times out on macOS bots
100         https://bugs.webkit.org/show_bug.cgi?id=180200
101
102         Reviewed by Alexey Proskuryakov.
103
104         Rewrites an API test to avoid checking against the hard-coded platform-dependent size of an attachment element.
105         Instead, first insert the attachment element as an icon and compute its size, and then check that the size of
106         the element is restored to this original value after toggling the display mode to in-place mode and back.
107
108         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
109         (-[TestWKWebView attachmentElementSize]):
110         (-[TestWKWebView waitForAttachmentElementSizeToBecome:]):
111         (TestWebKitAPI::TEST):
112         (platformAttachmentIconElementSize): Deleted.
113
114 2017-11-30  Michael Catanzaro  <mcatanzaro@igalia.com>
115
116         [WPE] Stop building Wayland in JHBuild moduleset
117         https://bugs.webkit.org/show_bug.cgi?id=179951
118
119         Reviewed by Žan Doberšek.
120
121         Since Wayland is not used for running tests, and since it does not seem to depend on
122         anything in the JHBuild moduleset, I think we can remove it safely without having to worry
123         that the system version of Wayland might use libraries in the JHBuild environment (which
124         would be unsafe).
125
126         * wpe/install-dependencies: Install Wayland.
127         * wpe/jhbuild.modules: Stop building Wayland.
128
129 2017-11-30  Alexey Proskuryakov  <ap@apple.com>
130
131         Silence the BitVector leak for
132         https://bugs.webkit.org/show_bug.cgi?id=121662
133
134         The out of line data pointer isn't stored directly, so the leaks tool cannot see it.
135
136         * Scripts/webkitpy/port/leakdetector.py:
137         (LeakDetector._callstacks_to_exclude_from_leaks):
138
139 2017-11-29  Aakash Jain  <aakash_jain@apple.com>
140
141         Fix build.webkit.org broken unit-test after r225080
142         https://bugs.webkit.org/show_bug.cgi?id=180176
143
144         Reviewed by Carlos Garcia Campos.
145
146         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated expected_build_steps.
147
148 2017-11-29  Wenson Hsieh  <wenson_hsieh@apple.com>
149
150         [Attachment Support] Implement SPI for clients to make an attachment element display in-place
151         https://bugs.webkit.org/show_bug.cgi?id=180153
152         <rdar://problem/35735252>
153
154         Reviewed by Tim Horton.
155
156         Adds new API tests to cover inserting in-place attachments and updating the display mode of existing attachments,
157         as well as performing a few editing operations (paragraph insertion, cut/paste, list insertion) on attachment
158         elements.
159
160         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
161         (platformAttachmentIconElementSize):
162         (testVideoData):
163         (testPDFData):
164         (displayOptionsWithMode):
165         (-[TestWKWebView waitForAttachmentElementSizeToBecome:]):
166         (-[_WKAttachment synchronouslySetDisplayOptions:error:]):
167         (TestWebKitAPI::TEST):
168
169 2017-11-29  Simon Fraser  <simon.fraser@apple.com>
170
171         API test fix after r225288.
172
173         Make the test work on iOS.
174
175         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
176         (-[DidScrollToFragmentScrollViewDelegate scrollViewDidScroll:]):
177         (TestWebKitAPI::TEST):
178
179 2017-11-29  Simon Fraser  <simon.fraser@apple.com>
180
181         REGRESSION (r213590): Scrolling to anchors broken in web views when content loaded via HTML string
182         https://bugs.webkit.org/show_bug.cgi?id=180155
183         rdar://problem/34220827
184
185         Reviewed by Zalan Bujtas.
186
187         API test that loads a page with a relative anchor, and simulates a click to scroll to it.
188
189         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
190         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
191         (TestWebKitAPI::TEST):
192         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm: Added.
193         (-[DidScrollToFragmentDelegate _webViewDidScroll:]):
194         (TestWebKitAPI::TEST):
195         * TestWebKitAPI/Tests/WebKit/scroll-to-anchor.html: Added.
196
197 2017-11-29  Ryan Haddad  <ryanhaddad@apple.com>
198
199         webkitpy EWS should be present on the dashboard.
200         https://bugs.webkit.org/show_bug.cgi?id=179801
201
202         Reviewed by Aakash Jain.
203
204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
205         (BubbleQueueServer): Add Webkitpy EWS.
206
207 2017-11-29  Simon Fraser  <simon.fraser@apple.com>
208
209         Viewport unit values affected by Comand-+ zoom
210         https://bugs.webkit.org/show_bug.cgi?id=145614
211
212         Reviewed by Zalan Bujtas.
213         
214         Fix Command+ and Command- in MiniBrowser to do zooming, rather than being tied
215         to editing commands.
216
217         * MiniBrowser/mac/MainMenu.xib:
218
219 2017-11-29  Alex Christensen  <achristensen@webkit.org>
220
221         Add test for _WKVisitedLinkStore.addVisitedLinkWithString
222         https://bugs.webkit.org/show_bug.cgi?id=180152
223
224         Reviewed by Chris Dumez.
225
226         * TestWebKitAPI/Tests/WebKitCocoa/VisitedLinkStore.mm:
227         (TestWebKitAPI::TEST):
228
229 2017-11-29  Jonathan Bedard  <jbedard@apple.com>
230
231         webkitpy: Trying to use iOS versions from machines without iOS SDKs doesn't make sense
232         https://bugs.webkit.org/show_bug.cgi?id=179534
233         <rdar://problem/35469509>
234
235         Reviewed by Brent Fulgham.
236
237         Provide more specific information in builders.py so that machines do not try and calculate
238         an iOS SDK version while running tests.
239
240         * Scripts/webkitpy/port/builders.py: Explicitly specify a version for iOS Simulator.
241         * Scripts/webkitpy/port/ios_simulator.py:
242         (IOSSimulatorPort._version_from_name): Attempt to extract the iOS version from the name
243         of the port.
244         (IOSSimulatorPort.ios_version): Use specified iOS version if a version is detected in
245         in the provided name string (just like Mac).
246
247 2017-11-29  Robin Morisset  <rmorisset@apple.com>
248
249         The recursive tail call optimisation is wrong on closures
250         https://bugs.webkit.org/show_bug.cgi?id=179835
251
252         Reviewed by Saam Barati.
253
254         This just includes merge-sort-cps.js to the list of benchmarks ran by run-jsc-benchmarks --tail-bench
255
256         * Scripts/run-jsc-benchmarks:
257
258 2017-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
259
260         WebDriver: add an option to dump test results to a json file
261         https://bugs.webkit.org/show_bug.cgi?id=180082
262
263         Reviewed by Brian Burg.
264
265         Add --json-output command line option to run-webdriver-tests to dump test results to a json file in a format
266         compatible with the W3C report. WebDriverTestResult now represents a test file and contains a list of
267         subtests, instead of having one WebDriverTestResult per subtest. This way we can store also the harness result
268         and dump the results to different formats.
269
270         * Scripts/run-webdriver-tests:
271         * Scripts/webkitpy/webdriver_tests/webdriver_test_result.py:
272         (WebDriverTestResult.__init__):
273         (WebDriverTestResult):
274         (WebDriverTestResult.add_subtest_results):
275         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
276         (WebDriverTestRunner.print_results):
277         (WebDriverTestRunner):
278         (WebDriverTestRunner.dump_results_to_json_file):
279         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
280         (WebDriverTestRunnerW3C.run):
281
282 2017-11-28  Alexey Proskuryakov  <ap@apple.com>
283
284         Stop silencing leaks in TextCodecICU::registerCodecs, as the problem was fixed a while ago.
285         https://bugs.webkit.org/show_bug.cgi?id=118505
286
287         Reviewed by Joseph Pecoraro.
288
289         * Scripts/valgrind/suppressions.txt:
290         * Scripts/webkitpy/port/leakdetector.py:
291         (LeakDetector._callstacks_to_exclude_from_leaks):
292
293 2017-11-28  Ms2ger  <Ms2ger@igalia.com>
294
295         Stop modifying self.expectations in TestExpectationLine.expected_behavior.
296         https://bugs.webkit.org/show_bug.cgi?id=180074
297
298         Reviewed by Simon Fraser.
299
300         In particular, getting the property multiple times on a skipped test
301         expectation line (which happens when using
302         `Tools/Scripts/run-webkit-tests --print-expectations` if a directory
303         containing multiple tests is skipped) would yield [pass, skip], then
304         [pass, skip, skip], then [pass, skip, skip, skip], and so on.
305
306         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
307         (TestExpectationLine.expected_behavior): copy self.expectations before modifying it.
308
309 2017-11-14  Carlos Garcia Campos  <cgarcia@igalia.com>
310
311         Move JSONValues to WTF and convert uses of InspectorValues.h to JSONValues.h
312         https://bugs.webkit.org/show_bug.cgi?id=173793
313
314         Reviewed by Joseph Pecoraro.
315
316         * TestWebKitAPI/CMakeLists.txt:
317         * TestWebKitAPI/PlatformGTK.cmake:
318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
319         * TestWebKitAPI/Tests/WTF/JSONValue.cpp: Renamed from Tools/TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp.
320         (TestWebKitAPI::TEST):
321
322 2017-11-28  Ryan Haddad  <ryanhaddad@apple.com>
323
324         Bugs filed from the flakiness dashboard should include a link to the dashboard
325         https://bugs.webkit.org/show_bug.cgi?id=180090
326
327         Reviewed by Aakash Jain.
328
329         * TestResultServer/static-dashboards/flakiness_dashboard.js:
330         (createBugHTML):
331         Open the bug compose page in a new tab and include a link
332         to the flakiness dashboard results for the selected test.
333
334 2017-11-28  Jonathan Bedard  <jbedard@apple.com>
335
336         webkitpy: Standardize Version representation
337         https://bugs.webkit.org/show_bug.cgi?id=179677
338         <rdar://problem/35711277>
339
340         Reviewed by Alex Christensen.
341
342         Standardize a single method of representing versions in the Version object
343         constructor. Provide static methods for converting string and lists/tuples
344         to Version objects.
345
346         * Scripts/webkitpy/common/system/platforminfo.py:
347         (PlatformInfo.__init__): Parse Version object from string instead of using
348         the constructor.
349         (PlatformInfo.xcode_sdk_version): Ditto.
350         (PlatformInfo.xcode_version): Ditto.
351         (PlatformInfo._win_version): Construct Version object from list.
352         * Scripts/webkitpy/common/system/platforminfo_mock.py:
353         (MockPlatformInfo.xcode_sdk_version):
354         (MockPlatformInfo.xcode_version):
355         * Scripts/webkitpy/common/version.py:
356         (Version):
357         (Version.from_string): Parse string of the form 'x.x.x'.
358         (Version.from_iterable): Construct a version object from a list, tuple or
359         other indexable object.
360         (Version.__init__): Construct a Version object from integers.
361         * Scripts/webkitpy/common/version_name_map.py:
362         (VersionNameMap.__init__): Use integer Version constructor.
363         (VersionNameMap._automap_to_major_version): Ditto.
364         (VersionNameMap.to_name):
365         (VersionNameMap.strip_name_formatting): Construct Version from string.
366         * Scripts/webkitpy/common/version_name_map_unittest.py:
367         (VersionMapTestCase.test_mac_version_by_name): Use integer Version constructor.
368         (VersionMapTestCase.test_mac_name_by_version): Ditto.
369         (VersionMapTestCase.test_ios_name_by_version): Ditto.
370         * Scripts/webkitpy/common/version_unittest.py:
371         (VersionTestCase.test_string_constructor):
372         (VersionTestCase.test_from_list):
373         (VersionTestCase.test_from_tuple):
374         (VersionTestCase.test_int_constructor):
375         (VersionTestCase.test_len):
376         (VersionTestCase.test_set_by_int):
377         (VersionTestCase.test_set_by_string):
378         (VersionTestCase.test_get_by_int):
379         (VersionTestCase.test_get_by_string):
380         (VersionTestCase.test_string):
381         (VersionTestCase.test_contained_in):
382         (VersionTestCase.test_compare_versions):
383         (VersionTestCase.test_list_constructor): Deleted.
384         (VersionTestCase.test_tuple_constructor): Deleted.
385         (VersionTestCase.test_copy_constructor): Deleted.
386         (VersionTestCase.test_none_constructor): Deleted.
387         * Scripts/webkitpy/port/ios.py:
388         (IOSPort.default_baseline_search_path): Handle case where ios_version is None.
389         * Scripts/webkitpy/port/ios_device.py:
390         (IOSDevicePort.ios_version): Return None rather than an empty version.
391         * Scripts/webkitpy/port/ios_simulator.py:
392         (IOSSimulatorPort.simulator_runtime): Parse Version object from string instead
393         of using the constructor.
394         (IOSSimulatorPort.ios_version): Return None rather than an empty version.
395         * Scripts/webkitpy/xcode/simulator.py:
396         (Simulator._parse_runtimes): Parse Version object from string instead of using
397         the constructor.
398         (Simulator._parse_devices): Ditto.
399         * Scripts/webkitpy/xcode/simulator_unittest.py:
400
401 2017-11-28  Daniel Bates  <dabates@apple.com>
402
403         [Cocoa] First pass at implementing alternative presentation button element
404         https://bugs.webkit.org/show_bug.cgi?id=179785
405         Part of <rdar://problem/34917108>
406
407         Reviewed by Brent Fulgham.
408
409         Add a test that substitutes the alternative presentation button for an element in
410         the page and clicks it.
411
412         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add test.
413         * TestWebKitAPI/Tests/WebKitCocoa/ClickAlternativePresentationButton.mm: Added.
414         (didClickAlternativePresentationButton):
415         (-[ClickAlternativePresentationButton webProcessPlugIn:didCreateBrowserContextController:]):
416         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
417         (TEST):
418         (-[AlternativePresentationButtonDelegate _webView:didClickAlternativePresentationButtonWithUserInfo:]):
419         (-[AlternativePresentationButtonDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
420
421 2017-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
422
423         REGRESSION(r225166): [GTK] Skipped unit tests are considered failures after glib upgrade
424         https://bugs.webkit.org/show_bug.cgi?id=180072
425
426         Reviewed by Michael Catanzaro.
427
428         This is a bug in GLib that has already been fixed. Backport the patch to fix it until there's a new GLib release
429         we can depend on.
430
431         * gtk/jhbuild.modules:
432         * gtk/patches/glib-gtester-do-not-consider-skipped-tests-as-failures.patch: Added.
433
434 2017-11-28  Fujii Hironori  <Hironori.Fujii@sony.com>
435
436         webkitpy: PlatformInfo raises AssertionError "assert self.os_version is not None" in Cygwin since Bug 179621
437         https://bugs.webkit.org/show_bug.cgi?id=180069
438
439         Reviewed by Daniel Bates.
440
441         "Version 10.0.16299" was interpreted as 0.0.16299. Fix the wrong
442         regexp for 'ver' command.
443
444         * Scripts/webkitpy/common/system/platforminfo.py:
445         (PlatformInfo._win_version_from_cmd): Replace \d with \d+.
446
447 2017-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
448
449         [GTK] WebDriver: disable XSS auditor when running WebDriver tests
450         https://bugs.webkit.org/show_bug.cgi?id=180075
451
452         Reviewed by Carlos Alberto Lopez Perez.
453
454         Some tests are now doing inline('<script>window.alert()</script>') which is rejected by the XSS auditor because
455         the script source is part of the request URL.
456
457         * Scripts/webkitpy/webdriver_tests/webdriver_driver_gtk.py:
458         (WebDriverGtk.capabilities): Disable XSS auditor.
459
460 2017-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
461
462         WebDriver: add timeout option to run-webdriver-tests script
463         https://bugs.webkit.org/show_bug.cgi?id=179940
464
465         Reviewed by Carlos Alberto Lopez Perez.
466
467         We need to handle timeouts to be able to run the tests in the bots. pytest doesn't support timeouts, but there's
468         a plugin pytest_timeout that can be used for that.
469
470         * Scripts/run-webdriver-tests: Add --timeout command line option.
471         * Scripts/webkitpy/thirdparty/__init__.py:
472         (AutoinstallImportHook.find_module): Check if pytest_timeout is imported to install it.
473         (AutoinstallImportHook._install_pytest_timeout): Install pytest_timeout from pypi.
474         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
475         (WebDriverTestRunnerW3C.__init__): Set PYTEST_TIMEOUT env var with the timeout given.
476         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
477         (WebDriverW3CExecutor.run): Clarify that the timeout received by do_wdspec() is ignored, and pass 0 instead of 25.
478
479 2017-11-27  Aakash Jain  <aakash_jain@apple.com>
480
481         Do not run webkitpy tests on multiple EWSes
482         https://bugs.webkit.org/show_bug.cgi?id=179834
483
484         Reviewed by Alexey Proskuryakov.
485
486         Do not run webkitpy tests in every EWS. We now have
487         a dedicated webkitpy test EWS.
488
489         * Scripts/webkitpy/tool/steps/runtests.py:
490         (RunTests.run): Do not run webkitpy tests in EWSes. These tests will still run
491         when --non-interactive option is not passed. 
492
493 2017-11-27  Jonathan Bedard  <jbedard@apple.com>
494
495         webkitpy: Better name-version mapping (Part 1)
496         https://bugs.webkit.org/show_bug.cgi?id=179621
497         <rdar://problem/35589585>
498
499         Reviewed by David Kilzer.
500
501         Mapping version numbers to version names should occur in a central location.
502         This has a few advantages. First, it makes iterating through versions easier.
503         Second, it allows for apple_additions to define an additional set of name
504         mappings. Lastly, it will allow, in a future patch, for us to track version
505         instead of version name, only mapping version to version name when required.
506
507         * Scripts/webkitpy/common/system/platforminfo.py:
508         (PlatformInfo.__init__):
509         (PlatformInfo._determine_os_name): Use VersionNameMap instead of custom functions
510         mapping version to name.
511         (PlatformInfo._determine_linux_version): Deleted.
512         (PlatformInfo._determine_mac_version): Deleted.
513         (PlatformInfo._determine_win_version): Deleted.
514         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
515         (TestPlatformInfo.test_os_name_and_wrappers):
516         (TestPlatformInfo.test_os_version):
517         (TestPlatformInfo.test_display_name):
518         (TestPlatformInfo.test_total_bytes_memory):
519         * Scripts/webkitpy/common/version.py:
520         (Version.contained_in): Add partial version mapping.
521         * Scripts/webkitpy/common/version_name_map.py: Added.
522         (VersionNameMap): Holds a mapping of version name to version object.
523         (VersionNameMap.map): Don't re-create VersionNameMap every time.
524         (VersionNameMap.__init__): Initialize mapping, use platform to
525         define the default system platform.
526         (VersionNameMap._automap_to_major_version): Some operating systems, such
527         as iOS, have a naming scheme based on their major version and os name.
528         Automatically generate such mappings.
529         (VersionNameMap.to_name): Given a version object, platform name and
530         table, find the closest matching version name.
531         (VersionNameMap.strip_name_formatting): Remove spaces and extract the major version,
532         if a version string is included in the name.
533         (VersionNameMap.from_name): Return an os name and version given a version name.
534         * Scripts/webkitpy/common/version_name_map_unittest.py: Added.
535         (VersionMapTestCase):
536         (VersionMapTestCase.test_default_system_platform):
537         (VersionMapTestCase.test_mac_version_by_name):
538         (VersionMapTestCase.test_ios_version_by_name):
539         (VersionMapTestCase.test_mac_name_by_version):
540         (VersionMapTestCase.test_ios_name_by_version):
541         * Scripts/webkitpy/common/version_unittest.py:
542         (VersionTestCase.test_contained_in):
543         * Scripts/webkitpy/port/ios_device.py:
544         (IOSDevicePort.ios_version): Map os_version name to version number.
545
546 2017-11-27  Don Olmstead  <don.olmstead@sony.com>
547
548         [CMake][Win] Conditionally select DLL CRT or static CRT
549         https://bugs.webkit.org/show_bug.cgi?id=170594
550
551         Reviewed by Alex Christensen.
552
553         * DumpRenderTree/PlatformWin.cmake:
554         * MiniBrowser/win/CMakeLists.txt:
555
556 2017-11-27  Yacine Bandou  <yacine.bandou_ext@softathome.com>
557
558         [GTK][WPE] Add "enable-encrypted-media" property to WebKitWebSettings
559         https://bugs.webkit.org/show_bug.cgi?id=18005
560
561         Reviewed by Michael Catanzaro.
562
563         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
564         (testWebKitSettings):
565
566 2017-11-27  Tim Horton  <timothy_horton@apple.com>
567
568         One too many zeroes in macOS version number in FeatureDefines
569         https://bugs.webkit.org/show_bug.cgi?id=180011
570
571         Reviewed by Dan Bernstein.
572
573         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
574
575 2017-11-27  Per Arne Vollan  <pvollan@apple.com>
576
577         [Win] The number of webkit-patch iterations on EWS should be configurable.
578         https://bugs.webkit.org/show_bug.cgi?id=178517
579
580         Reviewed by Darin Adler.
581
582         Add a new RESET_AFTER_ITERATION argument to the EWS shell script.
583
584         * EWSTools/start-queue-win.sh:
585
586 2017-11-27  Per Arne Vollan  <pvollan@apple.com>
587
588         [Win] Switch to VS2017 on EWS bots.
589         https://bugs.webkit.org/show_bug.cgi?id=178516
590
591         Reviewed by Darin Adler.
592
593         * EWSTools/start-queue-win.sh:
594
595 2017-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
596
597         [SOUP] Layout test media/track/track-text-track-cue-list.html crash with g_source_set_ready_time: assertion 'source->ref_count > 0' failed
598         https://bugs.webkit.org/show_bug.cgi?id=176806
599
600         Reviewed by Carlos Alberto Lopez Perez.
601
602         This was caused by a GLib bug that has already been fixed. Upgrade glib to 2.54.2.
603
604         * gtk/jhbuild.modules:
605         * gtk/patches/gdate-suppress-string-format-literal-warning.patch: Removed.
606
607 2017-11-24  Darin Adler  <darin@apple.com>
608
609         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
610         (TestWebKitAPI::TEST): Added a test for OptionSet operator|.
611
612 2017-11-24  Mark Lam  <mark.lam@apple.com>
613
614         Move unsafe jsc shell test functions to the $vm object.
615         https://bugs.webkit.org/show_bug.cgi?id=179980
616
617         Reviewed by Yusuke Suzuki.
618
619         Always set --useDollarVM=true for jsc runs of benchmarks.  This is needed because
620         some microbenchmarks relies on createBuiltin().
621
622         Also set --useDollarVM=true for runExceptionFuzz and runExecutableAllocationFuzz.
623
624         * Scripts/run-jsc-benchmarks:
625         * Scripts/run-jsc-stress-tests:
626
627 2017-11-23  Darin Adler  <darin@apple.com>
628
629         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
630         https://bugs.webkit.org/show_bug.cgi?id=179907
631
632         Reviewed by Sam Weinig.
633
634         * DumpRenderTree/mac/DumpRenderTree.mm:
635         (changeWindowScaleIfNeeded): Use containsIgnoringASCIICase.
636         * WebKitTestRunner/TestInvocation.cpp:
637         (WTR::TestInvocation::urlContains const): Ditto.
638
639 2017-11-22  Ali Juma  <ajuma@chromium.org>
640
641         Implement VisualViewport API attributes
642         https://bugs.webkit.org/show_bug.cgi?id=179385
643
644         Reviewed by Frédéric Wang.
645
646         Enable the VisualViewportAPI in layout tests.
647
648         * DumpRenderTree/mac/DumpRenderTree.mm:
649         (enableExperimentalFeatures):
650         * DumpRenderTree/win/DumpRenderTree.cpp:
651         (enableExperimentalFeatures):
652
653 2017-11-22  Tim Horton <timothy_horton@apple.com> and Michael Catanzaro <mcatanzaro@igalia.com>
654
655         Remove build-webkit's notion of feature flags having a default value
656         https://bugs.webkit.org/show_bug.cgi?id=177338
657
658         Reviewed by Carlos Alberto Lopez Perez.
659
660         Delegate feature flag default values to the build system.
661         (FeatureDefines.xcconfig for Xcode, WebKitFeatures.cmake and Options*.cmake for CMake, and FeatureDefines.h for everyone)
662
663         * BuildSlaveSupport/build.webkit.org-config/config.json:
664         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
665         (Factory.__init__):
666         Update GTK and WPE buildbot configuration to use --no-experimental-features on old stable
667         bots instead of --default-cmake-features.
668  
669         * Scripts/build-webkit:
670         (cMakeArgsFromFeatures): Deleted.
671         Default feature values to 'undef'.
672         Remove the --default-cmake-features argument; it is now the default.
673         Add --no-experimental-features to replace it.
674         Stop printing the default feature flag value in the help.
675         Avoid propagating undefined values to the build system;
676         only mention flags that are overridden on the command line.
677
678         This has the nice side effect of using the default CMake features
679         for CMake builds, but still allowing toggling of them using the
680         prettier --FEATURE and --no-FEATURE arguments.
681
682         * Scripts/webkitdirs.pm:
683         (generateBuildSystemFromCMakeProject):
684         No longer need to suppress CMake warnings about unused arguments.
685
686         * Scripts/webkitperl/FeatureList.pm:
687         Remove the default values from the feature list.
688
689 2017-11-22  Mark Lam  <mark.lam@apple.com>
690
691         [Re-landing] Pass --useDollarVM=true to all JSC tests.
692         https://bugs.webkit.org/show_bug.cgi?id=179647
693
694         Reviewed by Saam Barati.
695
696         * Scripts/run-jsc-stress-tests:
697
698 2017-11-22  Commit Queue  <commit-queue@webkit.org>
699
700         Unreviewed, rolling out r225093.
701         https://bugs.webkit.org/show_bug.cgi?id=179938
702
703         Compilation failed on WinCairo 64-bit Release (Requested by
704         fredw on #webkit).
705
706         Reverted changeset:
707
708         "Implement VisualViewport API attributes"
709         https://bugs.webkit.org/show_bug.cgi?id=179385
710         https://trac.webkit.org/changeset/225093
711
712 2017-11-21  Ali Juma  <ajuma@chromium.org>
713
714         Implement VisualViewport API attributes
715         https://bugs.webkit.org/show_bug.cgi?id=179385
716
717         Reviewed by Frédéric Wang.
718
719         Enable the VisualViewportAPI in layout tests.
720
721         * DumpRenderTree/mac/DumpRenderTree.mm:
722         (enableExperimentalFeatures):
723         * DumpRenderTree/win/DumpRenderTree.cpp:
724         (enableExperimentalFeatures):
725
726 2017-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
727
728         [WPE] Run unit tests in the bots
729         https://bugs.webkit.org/show_bug.cgi?id=179910
730
731         Reviewed by Michael Catanzaro.
732
733         Add a step to run unit tests in WPE test bots.
734
735         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
736         (RunGLibAPITests):
737         (RunGtkAPITests):
738         (RunWPEAPITests):
739         (TestFactory.__init__):
740         (RunGtkAPITests.start): Deleted.
741         (RunGtkAPITests.commandComplete): Deleted.
742         (RunGtkAPITests.evaluateCommand): Deleted.
743         (RunGtkAPITests.getText): Deleted.
744         (RunGtkAPITests.getText2): Deleted.
745         * wpe/jhbuild.modules: Upgrade WPEBackend-mesa to fix crashes when running unit tests.
746
747 2017-11-21  Tomas Popela  <tpopela@redhat.com>
748
749         Fix WebKitGTK+ compilation
750
751         Reviewed by Carlos Garcia Campos.
752
753         File "/builddir/build/BUILD/webkitgtk-2.19.2/Tools/gtk/generate-gtkdoc", line 31, in <module>
754         import common
755         ImportError: No module named common
756
757         * gtk/manifest.txt.in:
758         Add Tools/glib/common.py to the tarball.
759
760 2017-11-21  Ms2ger  <Ms2ger@igalia.com>
761
762         [GTK] Avoid warning in jhbuildrc.
763         https://bugs.webkit.org/show_bug.cgi?id=179913
764
765         Reviewed by Carlos Garcia Campos.
766
767         Apparently this is not quite a real python file; this declaration causes
768         warnings like
769           I: unknown keys defined in configuration file: top_level_directory
770         which break run-webkit-tests.
771
772         * gtk/jhbuildrc:
773
774 2017-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
775
776         Unreviewed. Fix WPE make distcheck.
777
778         * wpe/manifest.txt.in: Add generate-inspector-gresource-manifest.py to the tarball.
779
780 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
781
782         Unreviewed. Fix GTK+ make distcheck.
783
784         * gtk/manifest.txt.in: Add generate-inspector-gresource-manifest.py to the tarball.
785
786 2017-11-20  Michael Catanzaro  <mcatanzaro@igalia.com>
787
788         [WPE] Disable ACCELERATED_2D_CANVAS in FeatureList.pm
789         https://bugs.webkit.org/show_bug.cgi?id=179889
790
791         Reviewed by Darin Adler.
792
793         * Scripts/webkitperl/FeatureList.pm:
794
795 2017-11-20  Michael Catanzaro  <mcatanzaro@igalia.com>
796
797         Unreviewed, speculative attempt to fix run-gtk-tests after r225047
798         https://bugs.webkit.org/show_bug.cgi?id=173772
799
800         * jhbuild/jhbuildutils.py:
801         (enter_jhbuild_environment_if_available):
802
803 2017-11-20  Mario Sanchez Prada  <mario@endlessm.com>
804
805         [GTK] New API to add, retrieve and delete cookies via WebKitCookieManager
806         https://bugs.webkit.org/show_bug.cgi?id=177932
807
808         Reviewed by Carlos Garcia Campos.
809
810         Added new test cases to cover the newly added API for WebKitCookieManager:
811         webkit_cookie_manager_add_cookie, webkit_cookie_manager_get_cookies and
812         webkit_cookie_manager_delete_cookie.
813
814         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
815         (testCookieManagerAddCookie): Added.
816         (testCookieManagerGetCookies): Added.
817         (testCookieManagerDeleteCookie): Added.
818         (serverCallback): Small update to avoid hardcoding strings we reuse.
819         (beforeAll): Added the new test cases to the test suite.
820
821 2017-11-20  Stephan Szabo  <stephan.szabo@sony.com>
822
823         [Win] Update ruby JSC test writer for gigacage changes
824         https://bugs.webkit.org/show_bug.cgi?id=178757
825
826         Reviewed by Keith Miller.
827
828         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
829         Add additionalEnv to ruby test writer Plan
830
831 2017-11-20  Michael Catanzaro  <mcatanzaro@igalia.com>
832
833         Remove ENABLE_ALLINONE_BUILD option
834         https://bugs.webkit.org/show_bug.cgi?id=179823
835
836         Reviewed by Darin Adler.
837
838         * Scripts/webkitperl/FeatureList.pm:
839
840 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
841
842         Unreviewed. Fix WPE build after r225047.
843
844         Remove changes from an old patch committed by mistake in r225047.
845
846         * WebKitTestRunner/PlatformWebView.h:
847         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
848         (WTR::PlatformWebView::windowSnapshotImage):
849
850 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
851
852         [WPE] Add run-wpe-tests script to run WPE glib API tests
853         https://bugs.webkit.org/show_bug.cgi?id=173772
854
855         Reviewed by Michael Catanzaro.
856
857         Move common code from run-gtk-tests to api_test_runner.py, to be shared by both run-gtk-tests and un-wpe-tests.
858
859         * Scripts/run-gtk-tests:
860         (GtkTestRunner):
861         (GtkTestRunner.__init__):
862         (GtkTestRunner._start_accessibility_daemons):
863         (GtkTestRunner._setup_testing_environment):
864         (GtkTestRunner._tear_down_testing_environment):
865         (GtkTestRunner.is_glib_test):
866         (GtkTestRunner.is_google_test):
867         * Scripts/run-wpe-tests: Added.
868         (WPETestRunner):
869         (WPETestRunner.__init__):
870         (WPETestRunner.is_glib_test):
871         (WPETestRunner.is_google_test):
872         * Scripts/webkitpy/port/headlessdriver.py: Added.
873         (HeadlessDriver):
874         (HeadlessDriver._setup_environ_for_test):
875         (HeadlessDriver._start):
876         * Scripts/webkitpy/port/headlessdriver_unittest.py: Added.
877         (HeadlessDriverTest):
878         (HeadlessDriverTest.make_driver):
879         (HeadlessDriverTest.make_environment):
880         (HeadlessDriverTest.test_environment_needed_variables):
881         (HeadlessDriverTest.test_environment_forbidden_variables):
882         * Scripts/webkitpy/port/wpe.py:
883         (WPEPort._driver_class):
884         * WebKitTestRunner/PlatformWebView.h:
885         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
886         (WTR::PlatformWebView::windowSnapshotImage):
887         * glib/api_test_runner.py: Copied from Tools/Scripts/run-gtk-tests.
888         (SkippedTest):
889         (SkippedTest.__init__):
890         (SkippedTest.__str__):
891         (SkippedTest.skip_entire_suite):
892         (SkippedTest.skip_for_build_type):
893         (TestTimeout):
894         (TestRunner):
895         (TestRunner.__init__):
896         (TestRunner._test_programs_base_dir):
897         (TestRunner._get_tests_from_dir):
898         (TestRunner._get_tests):
899         (TestRunner._create_driver):
900         (TestRunner._setup_testing_environment):
901         (TestRunner._tear_down_testing_environment):
902         (TestRunner._test_cases_to_skip):
903         (TestRunner._should_run_test_program):
904         (TestRunner._kill_process):
905         (TestRunner._start_timeout):
906         (TestRunner._start_timeout._alarm_handler):
907         (TestRunner._stop_timeout):
908         (TestRunner._waitpid):
909         (TestRunner._run_test_glib):
910         (TestRunner._run_test_glib.parse_line):
911         (TestRunner._run_test_glib.parse_line.set_test_result):
912         (TestRunner._get_tests_from_google_test_suite):
913         (TestRunner._run_google_test):
914         (TestRunner._run_google_test_suite):
915         (TestRunner.is_glib_test):
916         (TestRunner.is_google_test):
917         (TestRunner._run_test):
918         (TestRunner.run_tests):
919         (add_options):
920         * glib/common.py: Renamed from Tools/gtk/common.py.
921         (get_build_path.is_valid_build_directory):
922         * gtk/generate-gtkdoc:
923         * gtk/jhbuildrc:
924         * gtk/ycm_extra_conf.py:
925
926 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
927
928         [WPE] Build C API tests
929         https://bugs.webkit.org/show_bug.cgi?id=179817
930
931         Reviewed by Michael Catanzaro.
932
933         * TestWebKitAPI/CMakeLists.txt:
934         * TestWebKitAPI/PlatformGTK.cmake:
935         * TestWebKitAPI/PlatformWPE.cmake:
936         * TestWebKitAPI/PlatformWebView.h:
937         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp:
938         (TestWebKitAPI::Util::URLForNonExistentResource):
939         (TestWebKitAPI::Util::isKeyDown):
940         * TestWebKitAPI/wpe/PlatformWebViewWPE.cpp: Added.
941         (TestWebKitAPI::PlatformWebView::PlatformWebView):
942         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
943         (TestWebKitAPI::PlatformWebView::initialize):
944         (TestWebKitAPI::PlatformWebView::page const):
945         (TestWebKitAPI::PlatformWebView::resizeTo):
946         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
947         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
948         (TestWebKitAPI::PlatformWebView::simulateRightClick):
949         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
950
951 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
952
953         [WPE] Add env var WPE_USE_HEADLESS_VIEW_BACKEND
954         https://bugs.webkit.org/show_bug.cgi?id=173770
955
956         Reviewed by Michael Catanzaro.
957
958         Move HeadlessViewBackend implementation to a common place and build it as a private static library to be used by
959         WTR, GLib API tests and eventually C API tests too. WTR uses the HeadlessViewBackend unconditionally, but GLib
960         API tests use it only when WPE_USE_HEADLESS_VIEW_BACKEND environment variable is present and not "0".
961
962         * CMakeLists.txt: Include wpe/HeadlessViewBackend directory for developer builds.
963         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
964         (testAutomationSessionRequestSession):
965         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
966         (testCookieManagerEphemeral):
967         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
968         (testPrivateBrowsing):
969         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
970         (testWebContextProxySettings):
971         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
972         (testWebViewWebContext):
973         (testWebViewEphemeral):
974         * TestWebKitAPI/glib/PlatformWPE.cmake:
975         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
976         (Test::createWebViewBackend):
977         (Test::createWebView):
978         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
979         (WebViewTest::initializeWebView):
980         * WebKitTestRunner/PlatformWPE.cmake:
981         * wpe/HeadlessViewBackend/CMakeLists.txt: Added.
982         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp: Renamed from Tools/WebKitTestRunner/wpe/HeadlessViewBackend.cpp.
983         (HeadlessViewBackend::HeadlessViewBackend):
984         * wpe/HeadlessViewBackend/HeadlessViewBackend.h: Renamed from Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h.
985
986 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
987
988         [WPE] webkit_web_view_new() should enable specifying wpe_view_backend object
989         https://bugs.webkit.org/show_bug.cgi?id=178655
990
991         Reviewed by Michael Catanzaro.
992
993         Update unit tests to create web views using helper methods that have a different implementation for GTK and
994         WPE. Also add a new test case to check the new API to create a WebKitWebView with a WPE backend. Use
995         WKViewCreate in WTR and fix a memory leak in HeadlessViewBackend.
996
997         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
998         (testAutomationSessionRequestSession):
999         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
1000         (testWebKitWebViewSessionState):
1001         (testWebKitWebViewSessionStateWithFormData):
1002         (testWebKitWebViewNavigationAfterSessionRestore):
1003         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1004         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1005         (testWebResourceGetDataError):
1006         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1007         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1008         (testWebViewNewWithUserContentManager):
1009         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1010         (testWebContextEphemeral):
1011         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1012         (testWebViewWebContext):
1013         (testWebViewWebContextLifetime):
1014         (testWebViewWebBackend):
1015         (testWebViewSettings):
1016         (beforeAll):
1017         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1018         (testWebsiteDataEphemeral):
1019         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1020         (Test::createWebView):
1021         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
1022         (HeadlessViewBackend::~HeadlessViewBackend):
1023         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
1024         (WTR::PlatformWebView::PlatformWebView):
1025
1026 2017-11-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1027
1028         [GTK][WPE] webkit_cookie_manager_delete_all_cookies doesn't delete the cookies if called before a web process is running
1029         https://bugs.webkit.org/show_bug.cgi?id=175265
1030
1031         Reviewed by Michael Catanzaro.
1032
1033         Add test case.
1034
1035         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1036         (testCookieManagerPersistentStorageDeleteAll):
1037         (serverCallback):
1038         (beforeAll):
1039
1040 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1041
1042         Remove unused TOUCH_ICON_LOADING feature flag
1043         https://bugs.webkit.org/show_bug.cgi?id=179873
1044
1045         Reviewed by Simon Fraser.
1046
1047         * Scripts/webkitperl/FeatureList.pm:
1048         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1049
1050 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1051
1052         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1053         https://bugs.webkit.org/show_bug.cgi?id=179872
1054
1055         Reviewed by Darin Adler.
1056
1057         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1058
1059 2017-11-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1060
1061         Unreviewed, rolling out r225016.
1062
1063         Break webkit-patch on Ubuntu and Debian Linux
1064
1065         Reverted changeset:
1066
1067         "webkitpy: Better name-version mapping (Part 1)"
1068         https://bugs.webkit.org/show_bug.cgi?id=179621
1069         https://trac.webkit.org/changeset/225016
1070
1071 2017-11-18  Jonathan Bedard  <jbedard@apple.com>
1072
1073         webkitpy: Better name-version mapping (Part 1)
1074         https://bugs.webkit.org/show_bug.cgi?id=179621
1075         <rdar://problem/35589585>
1076
1077         Reviewed by David Kilzer.
1078
1079         Mapping version numbers to version names should occur in a central location.
1080         This has a few advantages. First, it makes iterating through versions easier.
1081         Second, it allows for apple_additions to define an additional set of name
1082         mappings. Lastly, it will allow, in a future patch, for us to track version
1083         instead of version name, only mapping version to version name when required.
1084
1085         * Scripts/webkitpy/common/system/platforminfo.py:
1086         (PlatformInfo.__init__):
1087         (PlatformInfo._determine_os_name): Use VersionNameMap instead of custom functions
1088         mapping version to name.
1089         (PlatformInfo._determine_linux_version): Deleted.
1090         (PlatformInfo._determine_mac_version): Deleted.
1091         (PlatformInfo._determine_win_version): Deleted.
1092         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1093         (TestPlatformInfo.test_os_name_and_wrappers):
1094         (TestPlatformInfo.test_os_version):
1095         (TestPlatformInfo.test_display_name):
1096         (TestPlatformInfo.test_total_bytes_memory):
1097         * Scripts/webkitpy/common/version.py:
1098         (Version.contained_in): Add partial version mapping.
1099         * Scripts/webkitpy/common/version_name_map.py: Added.
1100         (VersionNameMap): Holds a mapping of version name to version object.
1101         (VersionNameMap.map): Don't re-create VersionNameMap every time.
1102         (VersionNameMap.__init__): Initialize mapping, use platform to
1103         define the default system platform.
1104         (VersionNameMap._automap_to_major_version): Some operating systems, such
1105         as iOS, have a naming scheme based on their major version and os name.
1106         Automatically generate such mappings.
1107         (VersionNameMap.to_name): Given a version object, platform name and
1108         table, find the closest matching version name.
1109         (VersionNameMap.strip_name_formatting): Remove spaces and extract the major version,
1110         if a version string is included in the name.
1111         (VersionNameMap.from_name): Return an os name and version given a version name.
1112         * Scripts/webkitpy/common/version_name_map_unittest.py: Added.
1113         (VersionMapTestCase):
1114         (VersionMapTestCase.test_default_system_platform):
1115         (VersionMapTestCase.test_mac_version_by_name):
1116         (VersionMapTestCase.test_ios_version_by_name):
1117         (VersionMapTestCase.test_mac_name_by_version):
1118         (VersionMapTestCase.test_ios_name_by_version):
1119         * Scripts/webkitpy/common/version_unittest.py:
1120         (VersionTestCase.test_contained_in):
1121
1122 2017-11-17  John Wilander  <wilander@apple.com>
1123
1124         Storage Access API: UI process should update network process about granted access
1125         https://bugs.webkit.org/show_bug.cgi?id=176943
1126         <rdar://problem/34440612>
1127
1128         Reviewed by Alex Christensen.
1129
1130         This adds the TestRunner function setStatisticsHasHadNonRecentUserInteraction()
1131         which enables testing of prevalent resources with user interaction outside the
1132         24 hour window.
1133
1134         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1135         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1136         (WTR::TestRunner::setStorageAccessAPIEnabled):
1137         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction):
1138         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1139         * WebKitTestRunner/TestController.cpp:
1140         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
1141         * WebKitTestRunner/TestController.h:
1142         * WebKitTestRunner/TestInvocation.cpp:
1143         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1144         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1145         (WTR::initializeWebViewConfiguration):
1146         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
1147
1148 2017-11-17  Ryan Haddad  <ryanhaddad@apple.com>
1149
1150         Disable failing API tests for rdar://problem/35344202.
1151
1152         Unreviewed test gardening.
1153
1154         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1155
1156 2017-11-17  Joanmarie Diggs  <jdiggs@igalia.com>
1157
1158         AX: [ATK] Fix WKTR's methods for testing row header and column header presence and count
1159         https://bugs.webkit.org/show_bug.cgi?id=179837
1160
1161         Reviewed by Chris Fleizach.
1162
1163         Add support to rowHeaders() for tables. Return an empty array in rowHeaders()
1164         and columnHeaders() upon failure. Rename getRowHeaders() and getColumnHeaders()
1165         to getTableRowHeaders() and getTableColumnHeaders() respectively.
1166
1167         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1168         (WTR::AccessibilityUIElement::rowHeaders const):
1169         (WTR::AccessibilityUIElement::columnHeaders const):
1170         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1171         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1172
1173 2017-11-16  Don Olmstead  <don.olmstead@sony.com>
1174
1175         [WinCairo] Update WinCairoRequirements
1176         https://bugs.webkit.org/show_bug.cgi?id=179790
1177
1178         Reviewed by Alex Christensen.
1179
1180         * TestWebKitAPI/PlatformWin.cmake:
1181
1182 2017-11-16  Daniel Bates  <dabates@apple.com>
1183
1184         Add feature define for alternative presentation button element
1185         https://bugs.webkit.org/show_bug.cgi?id=179692
1186         Part of <rdar://problem/34917108>
1187
1188         Reviewed by Andy Estes.
1189
1190         Only enabled on Cocoa platforms by default.
1191
1192         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1193
1194 2017-11-16  Per Arne Vollan  <pvollan@apple.com>
1195
1196         Win EWS bots should reboot after N webkit-patch iterations.
1197         https://bugs.webkit.org/show_bug.cgi?id=177970
1198
1199         Reviewed by Brent Fulgham.
1200
1201         * EWSTools/start-queue-win.sh:
1202
1203 2017-11-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1204
1205         [WPE] Add initial support for WebDriver
1206         https://bugs.webkit.org/show_bug.cgi?id=179727
1207
1208         Reviewed by Michael Catanzaro.
1209
1210         Make it possible to run WebDriver tests with WPE.
1211
1212         * Scripts/run-webdriver-tests: Add --wpe alias for --platform=wpe.
1213         * Scripts/webkitpy/port/wpe.py:
1214         (WPEPort.__init__): Initialize _display_server from options.
1215         (WPEPort._driver_class): Use WaylandDriver when wayland is passed as display server option.
1216         * Scripts/webkitpy/webdriver_tests/webdriver_driver.py:
1217         (WebDriver.browser_env): Add virtual method to get the environment that should be used.
1218         * Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py: Copied from Tools/Scripts/webkitpy/webdriver_tests/webdriver_driver.py.
1219         (WebDriverWPE):
1220         (WebDriverWPE.__init__):
1221         (WebDriverWPE.binary_path):
1222         (WebDriverWPE.browser_name):
1223         (WebDriverWPE.capabilities):
1224         (WebDriverWPE.browser_env):
1225         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1226         (WebDriverW3CExecutor.__init__): Update the environment with the one provided by the driver.
1227         * wpe/jhbuild.modules: Upgrade dyz to newer version that supports automation.
1228
1229 2017-11-15  Alex Christensen  <achristensen@webkit.org>
1230
1231         WebViews scheduled in custom run loop modes should be able to do more than 50ms of work at a time
1232         https://bugs.webkit.org/show_bug.cgi?id=179742
1233         <rdar://problem/35519421>
1234
1235         Reviewed by Jer Noble.
1236
1237         * TestWebKitAPI/Tests/mac/WebViewScheduleInRunLoop.mm:
1238         (-[ScheduleInRunLoopDelegate webView:didFinishLoadForFrame:]):
1239         (TestWebKitAPI::TEST):
1240         Load more than one scheduled WebView to test work that typically takes more than 50 ms.
1241
1242 2017-11-15  Ryan Haddad  <ryanhaddad@apple.com>
1243
1244         Unreviewed, rolling out r223781.
1245
1246         The test is now returning false, so the FIXME is not needed
1247         anymore.
1248
1249         Reverted changeset:
1250
1251         "WebsiteDataStoreCustomPaths.mm is failing after r223718"
1252         https://bugs.webkit.org/show_bug.cgi?id=178596
1253         https://trac.webkit.org/changeset/223781
1254
1255 2017-11-15  Ryan Haddad  <ryanhaddad@apple.com>
1256
1257         Unreviewed, rolling out r224863.
1258
1259         Introduced LayoutTest crashes on iOS Simulator.
1260
1261         Reverted changeset:
1262
1263         "Move JSONValues to WTF and convert uses of InspectorValues.h
1264         to JSONValues.h"
1265         https://bugs.webkit.org/show_bug.cgi?id=173793
1266         https://trac.webkit.org/changeset/224863
1267
1268 2017-11-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1269
1270         Remove GTK web inspector images
1271         https://bugs.webkit.org/show_bug.cgi?id=179716
1272
1273         Reviewed by Carlos Garcia Campos.
1274
1275         * Scripts/webkitdirs.pm:
1276         (shouldRemoveCMakeCache):
1277         * glib/generate-inspector-gresource-manifest.py:
1278         (get_filenames.should_ignore_resource):
1279         * gtk/manifest.txt.in:
1280         * wpe/manifest.txt.in:
1281
1282 2017-11-15  Jonathan Bedard  <jbedard@apple.com>
1283
1284         REGRESSION(r221877): 'future' handled incorrectly for mac
1285         https://bugs.webkit.org/show_bug.cgi?id=179711
1286         <rdar://problem/35546604>
1287
1288         Reviewed by Alex Christensen.
1289
1290         * Scripts/webkitpy/port/mac.py:
1291         (MacPort.default_baseline_search_path): Use platform/mac-<version> instead of
1292         platform/<version> as the baseline search path.
1293
1294 2017-11-14  Nan Wang  <n_wang@apple.com>
1295
1296         AX: AOM: Implement AccessibleNode class and support label and role attributes
1297         https://bugs.webkit.org/show_bug.cgi?id=179494
1298
1299         Reviewed by Ryosuke Niwa.
1300
1301         * DumpRenderTree/mac/DumpRenderTree.mm:
1302         (enableExperimentalFeatures):
1303         * WebKitTestRunner/TestController.cpp:
1304         (WTR::TestController::resetPreferencesToConsistentValues):
1305
1306 2017-11-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1307
1308         [Windows] Fix error while launching subprocess on Windows Python
1309         https://bugs.webkit.org/show_bug.cgi?id=179637
1310
1311         Reviewed by Alex Christensen.
1312
1313         To pass environment variables to subprocess.popen on Windows Python 2,
1314         the dict values must be str not unicode.
1315         Also is_native_win() method is added to port.
1316
1317         * Scripts/webkitpy/common/system/platforminfo.py:
1318         (PlatformInfo.is_native_win):
1319         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1320         (MockPlatformInfo.is_native_win):
1321         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1322         (TestPlatformInfo.test_os_name_and_wrappers):
1323         * Scripts/webkitpy/port/server_process.py:
1324         (ServerProcess.__init__):
1325
1326 2017-11-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1327
1328         Move JSONValues to WTF and convert uses of InspectorValues.h to JSONValues.h
1329         https://bugs.webkit.org/show_bug.cgi?id=173793
1330
1331         Reviewed by Brian Burg.
1332
1333         * TestWebKitAPI/CMakeLists.txt:
1334         * TestWebKitAPI/PlatformGTK.cmake:
1335         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1336         * TestWebKitAPI/Tests/WTF/JSONValue.cpp: Renamed from Tools/TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp.
1337         (TestWebKitAPI::TEST):
1338
1339 2017-11-14  Jonathan Bedard  <jbedard@apple.com>
1340
1341         webkitpy: Use more verbose version info from simctl
1342         https://bugs.webkit.org/show_bug.cgi?id=179687
1343         <rdar://problem/35539392>
1344
1345         Reviewed by Tim Horton.
1346
1347         * Scripts/webkitpy/xcode/simulator.py:
1348         (Simulator): Address FIXME, use more verbose version.
1349         (Simulator._parse_runtimes): 'Internal' no longer stands along, check os for this
1350         string instead.
1351         * Scripts/webkitpy/xcode/simulator_unittest.py: Mock simctl output specifies iOS
1352         8.4.1, not iOS 8.4.
1353
1354 2017-11-14  Daniel Bates  <dabates@apple.com>
1355
1356         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1357         for feature defines
1358
1359         Following r195498 and r201917 the Visual Studio property files for feature defines have
1360         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1361         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1362         files.
1363
1364         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1365
1366 2017-11-14  Jer Noble  <jer.noble@apple.com>
1367
1368         Enable Modern EME tests in DumpRenderTree
1369         https://bugs.webkit.org/show_bug.cgi?id=179544
1370
1371         Reviewed by Alex Christensen.
1372
1373         * DumpRenderTree/mac/DumpRenderTree.mm:
1374         (enableExperimentalFeatures):
1375
1376 2017-11-14  Commit Queue  <commit-queue@webkit.org>
1377
1378         Unreviewed, rolling out r224800.
1379         https://bugs.webkit.org/show_bug.cgi?id=179684
1380
1381         "Broke CLoop test mozilla/js1_6/Array/regress-304828.js"
1382         (Requested by mlam on #webkit).
1383
1384         Reverted changeset:
1385
1386         "Pass --useDollarVM=true to all JSC tests."
1387         https://bugs.webkit.org/show_bug.cgi?id=179647
1388         https://trac.webkit.org/changeset/224800
1389
1390 2017-11-14  Antti Koivisto  <antti@apple.com>
1391
1392         Enable display:contents by default
1393         https://bugs.webkit.org/show_bug.cgi?id=179655
1394
1395         Reviewed by Sam Weinig.
1396
1397         No need to enable this specifically for tests anymore.
1398
1399         * DumpRenderTree/mac/DumpRenderTree.mm:
1400         (enableExperimentalFeatures):
1401         * WebKitTestRunner/TestController.cpp:
1402         (WTR::TestController::resetPreferencesToConsistentValues):
1403
1404 2017-11-14  Tim Horton  <timothy_horton@apple.com>
1405
1406         Long pressing a phone number with spaces in it results in a link sheet instead of a data detectors sheet
1407         https://bugs.webkit.org/show_bug.cgi?id=179646
1408         <rdar://problem/35337288>
1409
1410         Reviewed by Simon Fraser.
1411
1412         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1413         (-[ActionSheetObserver _dataDetectionContextForWebView:]):
1414         (TestWebKitAPI::TEST):
1415         Add a test that ensures that a phone number with spaces in it
1416         invokes a data detectors sheet, not a normal link sheet.
1417
1418 2017-11-14  Emilio Cobos Álvarez  <emilio@crisal.io>
1419
1420         Add committer status for Emilio Cobos Álvarez.
1421         https://bugs.webkit.org/show_bug.cgi?id=179667
1422
1423         Unreviewed.
1424
1425         * Scripts/webkitpy/common/config/contributors.json:
1426
1427 2017-11-13  Mark Lam  <mark.lam@apple.com>
1428
1429         Pass --useDollarVM=true to all JSC tests.
1430         https://bugs.webkit.org/show_bug.cgi?id=179647
1431
1432         Reviewed by Saam Barati.
1433
1434         * Scripts/run-jsc-stress-tests:
1435
1436 2017-11-13  Simon Fraser  <simon.fraser@apple.com>
1437
1438         When navigating back to a page, compositing layers may not use accelerated drawing
1439         https://bugs.webkit.org/show_bug.cgi?id=178749
1440         rdar://problem/35158946
1441
1442         Reviewed by Dean Jackson.
1443
1444         Fix WTR and DRT to parse "useAcceleratedDrawing" out of "webkit-test-runner" options
1445         and use it to set the state of the web view.
1446
1447         * DumpRenderTree/TestOptions.h:
1448         * DumpRenderTree/TestOptions.mm:
1449         (TestOptions::TestOptions):
1450         * DumpRenderTree/mac/DumpRenderTree.mm:
1451         (setWebPreferencesForTestOptions):
1452         * WebKitTestRunner/TestController.cpp:
1453         (WTR::TestController::resetPreferencesToConsistentValues):
1454         (WTR::updateTestOptionsFromTestHeader):
1455         * WebKitTestRunner/TestOptions.h:
1456         (WTR::TestOptions::hasSameInitializationOptions const):
1457
1458 2017-11-13  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1459
1460         [Windows] Fix Python error for subprocess.popen with close_fds
1461         https://bugs.webkit.org/show_bug.cgi?id=179553
1462
1463         Reviewed by Per Arne Vollan.
1464
1465         * Scripts/webkitpy/port/server_process.py:
1466         (ServerProcess._start):
1467         (ServerProcess._should_close_fds):
1468
1469 2017-11-13  Michael Catanzaro  <mcatanzaro@igalia.com>
1470
1471         [GTK] Require woff2 1.0.2 and drop direct brotli dependency
1472         https://bugs.webkit.org/show_bug.cgi?id=179630
1473
1474         Reviewed by Frédéric Wang.
1475
1476         * gtk/jhbuild.modules:
1477
1478 2017-11-08  Keith Miller  <keith_miller@apple.com>
1479
1480         Async iteration should only fetch the next method once and add feature flag
1481         https://bugs.webkit.org/show_bug.cgi?id=179451
1482
1483         Reviewed by Geoffrey Garen.
1484
1485         Add feature flag for Async iteration.
1486
1487         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1488
1489 2017-11-13  Gabriel Ivascu  <givascu@igalia.com>
1490
1491         [GTK] Automatically adjust font size when gtk-xft-dpi changes
1492         https://bugs.webkit.org/show_bug.cgi?id=142673
1493
1494         Reviewed by Michael Catanzaro.
1495
1496         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1497         (testWebKitSettings):
1498
1499 2017-11-13  Jonathan Bedard  <jbedard@apple.com>
1500
1501         check-webkit-style cannot construct valid iOS version without an iOS SDK
1502         https://bugs.webkit.org/show_bug.cgi?id=179616
1503         <rdar://problem/35507018>
1504
1505         Reviewed by David Kilzer.
1506
1507         Instead of throwing an exception when we ask for an unavailable SDK on Mac,
1508         we should return None.
1509
1510         * Scripts/webkitpy/common/system/platforminfo.py:
1511         (PlatformInfo.xcode_sdk_version): Return 'None' version if the machine does not
1512         have the requested SDK.
1513
1514 2017-11-13  Keith Miller  <keith_miller@apple.com>
1515
1516         Uninitialized variable in sort-Xcode-project-file
1517         https://bugs.webkit.org/show_bug.cgi?id=179581
1518
1519         Reviewed by Simon Fraser.
1520
1521         Previously all the unified source files were named
1522         UnifiedSource<some-number>.mm. This was changed to
1523         UnifiedSource<some-number>-mm.mm to stop Xcode from creating
1524         hashes for mm and cpp unified source files with the same
1525         number. This broke the expectations in sort-Xcode-project-file.
1526
1527         * Scripts/sort-Xcode-project-file:
1528         (sortChildrenByFileName):
1529         (sortFilesByFileName):
1530
1531 2017-11-13  JF Bastien  <jfbastien@apple.com>
1532
1533         std::expected: fix and test move
1534         https://bugs.webkit.org/show_bug.cgi?id=179617
1535
1536         Reviewed by Alex Christensen.
1537
1538         Test that unique_ptr can be moved around properly, both has a
1539         value and an error (and in a <void, unique> specialization).
1540
1541         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1542         (TestWebKitAPI::snowflake::reset):
1543         (TestWebKitAPI::snowflake::snowflake):
1544         (TestWebKitAPI::snowflake::~snowflake):
1545         (TestWebKitAPI::TEST):
1546
1547 2017-11-13  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1548
1549         [Windows] Make the port's normalize_test_name() method platform independent.
1550         https://bugs.webkit.org/show_bug.cgi?id=179572
1551
1552         Reviewed by Alexey Proskuryakov.
1553
1554         * Scripts/webkitpy/port/base.py:
1555         (Port.normalize_test_name):
1556
1557 2017-11-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1558
1559         [Attachment Support] Implement SPI for clients to request data for a given attachment
1560         https://bugs.webkit.org/show_bug.cgi?id=179586
1561         <rdar://problem/35355720>
1562
1563         Reviewed by Darin Adler.
1564
1565         Augments existing API tests in WKAttachmentTests to additionally check that -requestData: yields the correct
1566         result when performing various editing operations. Also adds a new API test that cuts and pastes an attachment
1567         inserted using WKWebView attachment SPI, and expects that the data of the attachment can still be fetched using
1568         the _WKAttachment SPI, as well as another test that inserts an empty NSData and expects that requestData: also
1569         yields an empty NSData result.
1570
1571         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1572         (-[NSData shortDescription]):
1573         (-[_WKAttachment synchronouslyRequestData:]):
1574         (-[_WKAttachment expectRequestedDataToBe:]):
1575         (TestWebKitAPI::TEST):
1576
1577 2017-11-12  Gabriel Ivascu  <givascu@igalia.com>
1578
1579         [GTK] Add functionality to handle font sizes in points
1580         https://bugs.webkit.org/show_bug.cgi?id=179285
1581
1582         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
1583
1584         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1585         (testWebKitSettings):
1586
1587 2017-11-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1588
1589         check-webkit-style: AttributeError: 'NoneType' object has no attribute 'major'
1590         https://bugs.webkit.org/show_bug.cgi?id=179522
1591
1592         Reviewed by Aakash Jain.
1593
1594         IOSSimulatorPort.ios_version should return a Version object.
1595
1596         * Scripts/webkitpy/port/ios_simulator.py:
1597         (IOSSimulatorPort.ios_version): Return a Version object.
1598
1599 2017-11-10  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1600
1601         [Win] The way to detect Windows 10 is wrong
1602         https://bugs.webkit.org/show_bug.cgi?id=179344
1603
1604         Reviewed by Alex Christensen.
1605
1606         * Scripts/webkitpy/common/system/platforminfo.py:
1607         (PlatformInfo._determine_win_version):
1608
1609 2017-11-10  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1610
1611         [WinCairo] LayoutTests doesn't read TextExpectations files correctly
1612         https://bugs.webkit.org/show_bug.cgi?id=179219
1613
1614         Reviewed by Alex Christensen.
1615
1616         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1617         (TestExpectationParser._parse_line):
1618         * Scripts/webkitpy/port/apple.py:
1619         (ApplePort.__init__):
1620         (ApplePort._allowed_port_names):
1621         (ApplePort):
1622         (ApplePort._future_port_name):
1623         (ApplePort._generate_all_test_configurations):
1624         * Scripts/webkitpy/port/win.py:
1625         (WinCairoPort.default_baseline_search_path):
1626         (WinCairoPort):
1627         (WinCairoPort._future_port_name):
1628
1629 2017-11-10  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1630
1631         [WinCairo] Treat 'future' version correctly
1632         https://bugs.webkit.org/show_bug.cgi?id=179345
1633
1634         Reviewed by Alex Christensen.
1635
1636         * Scripts/webkitpy/port/win.py:
1637         (WinCairoPort.default_baseline_search_path):
1638
1639 2017-11-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1640
1641         Finish rolling out r224544
1642
1643         Rubber-stamped by Tim Horton.
1644
1645         Now that https://bugs.webkit.org/show_bug.cgi?id=179431 has been fixed, we can once again allow one of the API
1646         tests added in r224512 (WKAttachmentTests.AttachmentUpdatesWhenChangingFontStyles) to test toggling underline
1647         style with a selected attachment element.
1648
1649         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1650         (TestWebKitAPI::TEST):
1651
1652 2017-11-10  Alex Christensen  <achristensen@webkit.org>
1653
1654         _WKThumbnailView initialization with WKWebView needs to call correct initWithFrame
1655         https://bugs.webkit.org/show_bug.cgi?id=179537
1656         <rdar://problem/35275219>
1657
1658         Reviewed by Darin Adler.
1659
1660         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1661         (-[WKThumbnailViewDelegate webView:didFinishNavigation:]):
1662         (TestWebKitAPI::TEST):
1663
1664 2017-11-10  Jonathan Bedard  <jbedard@apple.com>
1665
1666         webkitpy: Remove find_system_pid from port classes
1667         https://bugs.webkit.org/show_bug.cgi?id=179514
1668         <rdar://problem/35456900>
1669
1670         Reviewed by David Kilzer.
1671
1672         Removing dead code.
1673
1674         * Scripts/webkitpy/port/base.py:
1675         (Port.find_system_pid): Deleted.
1676         * Scripts/webkitpy/port/server_process.py:
1677         (ServerProcess._start):
1678         * Scripts/webkitpy/port/win.py:
1679         (WinPort.find_system_pid): Deleted.
1680
1681 2017-11-10  Aakash Jain  <aakash_jain@apple.com>
1682
1683         fix style failures in webkitpy: multiple statements on one line (semicolon)
1684         https://bugs.webkit.org/show_bug.cgi?id=179530
1685
1686         Reviewed by Alex Christensen.
1687
1688         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Removed semicolon.
1689         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Ditto.
1690         * Scripts/webkitpy/tool/steps/runtests.py: Ditto.
1691
1692 2017-11-10  Aakash Jain  <aakash_jain@apple.com>
1693
1694         fix style failures in webkitpy: expected 2 blank lines found 1
1695         https://bugs.webkit.org/show_bug.cgi?id=179529
1696
1697         Reviewed by Alex Christensen.
1698
1699         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added a blank line to follow style guidelines.
1700         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Ditto.
1701         * Scripts/webkitpy/common/system/platforminfo_mock.py: Ditto.
1702         * Scripts/webkitpy/common/version.py: Ditto.
1703         * Scripts/webkitpy/layout_tests/models/test_failures.py: Ditto.
1704         * Scripts/webkitpy/port/mac_unittest.py: Ditto.
1705         * Scripts/webkitpy/port/simulator_process.py: Ditto.
1706
1707 2017-11-10  Alex Christensen  <achristensen@webkit.org>
1708
1709         REGRESSION(r224267): WebViews scheduled with custom run loop modes don't load
1710         https://bugs.webkit.org/show_bug.cgi?id=179515
1711
1712         Reviewed by Andy Estes.
1713
1714         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1715         * TestWebKitAPI/Tests/mac/WebViewScheduleInRunLoop.mm: Added.
1716         (-[ScheduleInRunLoopDelegate webView:didFinishLoadForFrame:]):
1717         (TestWebKitAPI::TEST):
1718
1719 2017-11-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1720
1721         [webkitpy] Fix PlatformInfo._win_version since r224657
1722         https://bugs.webkit.org/show_bug.cgi?id=179520
1723
1724         Reviewed by Aakash Jain.
1725
1726         There are two problems.
1727
1728         The return value of sys.getwindowsversion() doesn't match with
1729         Version.__init__ expects. Truncate the 4th and 5th of it.
1730
1731         _win_version_tuple_from_cmd was deleted in r224657. But, it is
1732         still needed for Cygwin Python.
1733
1734         * Scripts/webkitpy/common/system/platforminfo.py:
1735         (PlatformInfo._win_version): Return [0:3] of getwindowsversion().
1736         Call _win_version_from_cmd for Cygwin Python.
1737         (PlatformInfo._win_version_from_cmd): Restored.
1738
1739 2017-11-10  Guillaume Emont  <guijemont@igalia.com>
1740
1741         build-jsc: build testmasm for all platforms using cmake
1742         https://bugs.webkit.org/show_bug.cgi?id=179512
1743
1744         Reviewed by Michael Catanzaro.
1745
1746         * Scripts/build-jsc:
1747
1748 2017-11-09  Jonathan Bedard  <jbedard@apple.com>
1749
1750         webkitpy: Unify version parsing code
1751         https://bugs.webkit.org/show_bug.cgi?id=179426
1752         <rdar://problem/35415191>
1753
1754         Unreviewed fix to r224657.
1755
1756         * Scripts/webkitpy/common/version.py:
1757         (Version.__init__): Check if an object is iterable.
1758
1759 2017-11-09  Jonathan Bedard  <jbedard@apple.com>
1760
1761         webkitpy: Unify version parsing code
1762         https://bugs.webkit.org/show_bug.cgi?id=179426
1763         <rdar://problem/35415191>
1764
1765         Reviewed by David Kilzer.
1766
1767         webkitpy needs to parse version strings or version lists frequently. Rather than
1768         duplicate this code each time it's needed, unify it in a Version class.
1769
1770         * Scripts/webkitpy/common/system/platforminfo.py:
1771         (PlatformInfo.__init__): Convert mac version string to version object and
1772         use _win_version instead of _win_version_tuple.
1773         (PlatformInfo.xcode_sdk_version): Convert SDK version string to Version object
1774         before returning it.
1775         (PlatformInfo.xcode_version): Return Version object instead of version string.
1776         (PlatformInfo._determine_mac_version): Accept Version object instead of string,
1777         eliminate parsing.
1778         (PlatformInfo._determine_win_version): Accept Version object instead of tuple.
1779         (PlatformInfo._win_version): Return Version object instead of tuple, have Version
1780         object own version string parsing.
1781         (PlatformInfo._win_version_tuple): Renamed to _win_version().
1782         (PlatformInfo._win_version_tuple_from_cmd): Deleted.
1783         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1784         (MockPlatformInfo.xcode_sdk_version): Return Version object instead of string.
1785         (MockPlatformInfo.xcode_version): Dittio.
1786         * Scripts/webkitpy/common/version.py: Added.
1787         (Version): Version object.
1788         (Version.__init__): Initialize the Version object with a string, integer,
1789         tuple of integers, list of integers or another Version object.
1790         (Version.__len__): Return 5 so that the Version object can be treated as
1791         a list or tuple.
1792         (Version.__getitem__): Get item in Version object by index or string.
1793         (Version.__setitem__): Set item in Version object by index or string.
1794         (Version.__str__): Convert version to printable string, omitting trailing 0's.
1795         (Version.__cmp__): Compare two version strings, major taking precedence over
1796         minor, minor taking precedence over build.
1797         * Scripts/webkitpy/common/version_unittest.py: Added.
1798         (VersionTestCase): Test behavior of Version object.
1799         * Scripts/webkitpy/port/ios.py:
1800         (IOSPort.default_baseline_search_path): ios_version now returns a Version object.
1801         (IOSPort._is_valid_ios_version): Deleted.
1802         (IOSPort.get_option): Deleted.
1803         * Scripts/webkitpy/port/ios_device.py:
1804         (IOSDevicePort.determine_full_port_name): Use Version object instead of owning parsing.
1805         (IOSDevicePort.ios_version): Return Version object instead of string.
1806         * Scripts/webkitpy/port/ios_simulator.py:
1807         (IOSSimulatorPort.simulator_runtime): Use from_version instead of from_version_string.
1808         (IOSSimulatorPort.ios_version): Return Version object instead of string.
1809         (IOSSimulatorPort.use_multiple_simulator_apps): Use Version object instead of string.
1810         * Scripts/webkitpy/xcode/simulator.py:
1811         (Runtime.from_version): Accept Version object instead of string.
1812         (Runtime.from_version_string): Replaced by from_version.
1813         (Runtime.__repr__): When printing, a runtime's version will be a Version object instead
1814         of a tuple.
1815         (Simulator._parse_runtimes): Use Version object instead of tuple.
1816         (Simulator._parse_devices): Ditto.
1817         * Scripts/webkitpy/xcode/simulator_unittest.py: Use Version object instead of tuples.
1818
1819 2017-11-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1820
1821         [WinCairo] Cannot find ImageDiff executable
1822         https://bugs.webkit.org/show_bug.cgi?id=179508
1823
1824         Reviewed by Per Arne Vollan.
1825
1826         * Scripts/webkitpy/port/win.py:
1827         (WinPort.is_cygwin):
1828         (WinPort._path_to_image_diff):
1829         (WinPort.find_system_pid):
1830
1831 2017-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1832
1833         [WinCairo EWS] svn-apply: 'cp' is not recognized as an internal or external command
1834         https://bugs.webkit.org/show_bug.cgi?id=179469
1835
1836         Reviewed by Per Arne Vollan.
1837
1838         WinCairo EWS bots haven't installed Cygwin.
1839
1840         * Scripts/svn-apply:
1841         (scmCopy): Use 'copy' function instead of 'cp' command.
1842
1843 2017-11-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1844
1845         [WPE] Update dyz (WPE MiniBrowser)
1846         https://bugs.webkit.org/show_bug.cgi?id=179492
1847
1848         Reviewed by Michael Catanzaro.
1849
1850         Update it to the last version as of today.
1851         This version not longer uses the C API.
1852
1853         * wpe/jhbuild.modules:
1854
1855 2017-11-09  Christopher Reid  <chris.reid@sony.com>
1856
1857         Use enum classes within FileSystem
1858         https://bugs.webkit.org/show_bug.cgi?id=175172
1859
1860         Reviewed by Darin Adler.
1861
1862         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1863         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1864
1865 2017-11-09  Brent Fulgham  <bfulgham@apple.com>
1866
1867         Test fix after r224609
1868         https://bugs.webkit.org/show_bug.cgi?id=178565
1869         <rdar://problem/11115901>
1870
1871         Unreviewed test fix after r224609.
1872
1873         Correct two test cases that attempt to push local file URLs in violation of our
1874         same origin policies. The fix is to grant universal file access, as we do for similar
1875         LayoutTests.
1876
1877         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1878         (TestWebKitAPI::TEST):
1879         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1880         (TestWebKitAPI::TEST):
1881
1882 2017-11-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1883
1884         Unreviewed, remove Dan from the soup network watchlist
1885
1886         Per his request. It's not Hotel California; we should probably let him leave.
1887
1888         * Scripts/webkitpy/common/config/watchlist:
1889
1890 2017-11-08  Don Olmstead  <don.olmstead@sony.com>
1891
1892         Add Windows powershell EWS script
1893         https://bugs.webkit.org/show_bug.cgi?id=179453
1894
1895         Reviewed by Brent Fulgham.
1896
1897         * EWSTools/Start-Queue.ps1: Added.
1898
1899 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1900
1901         HTMLMediaElement should not use element fullscreen on iOS
1902         https://bugs.webkit.org/show_bug.cgi?id=179418
1903         rdar://problem/35409277
1904
1905         Reviewed by Eric Carlson.
1906
1907         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1908
1909         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1910
1911 2017-11-08  Tim Horton  <timothy_horton@apple.com>
1912
1913         [ios-simulator] API test WebKit.BundleParameters is a flaky failure
1914         https://bugs.webkit.org/show_bug.cgi?id=178363
1915         <rdar://problem/35043144>
1916
1917         Reviewed by Brent Fulgham.
1918
1919         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1920         (TestWebKitAPI::TEST):
1921         Add a test.
1922
1923 2017-11-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1924
1925         [Attachment Support] Implement delegate hooks for attachment element insertion and removal
1926         https://bugs.webkit.org/show_bug.cgi?id=179016
1927         <rdar://problem/35250890>
1928
1929         Reviewed by Tim Horton.
1930
1931         See WebCore/ChangeLog for more details.
1932
1933         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1934         (-[AttachmentUpdateObserver init]):
1935         (-[AttachmentUpdateObserver inserted]):
1936         (-[AttachmentUpdateObserver removed]):
1937         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]):
1938         (-[AttachmentUpdateObserver _webView:didRemoveAttachment:]):
1939         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::ObserveAttachmentUpdatesForScope):
1940         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::~ObserveAttachmentUpdatesForScope):
1941         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::observer const):
1942         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectAttachmentUpdates):
1943         (-[TestWKWebView _synchronouslyExecuteEditCommand:argument:]):
1944         (-[TestWKWebView expectUpdatesAfterCommand:withArgument:expectedRemovals:expectedInsertions:]):
1945         (TestWebKitAPI::TEST):
1946
1947 2017-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1948
1949         Web Inspector: use JSON::{Array,Object,Value} instead of Inspector{Array,Object,Value}
1950         https://bugs.webkit.org/show_bug.cgi?id=173619
1951
1952         Reviewed by Brian Burg.
1953
1954         Update InspectorValue unit tests to use JSON namespace and add more basic tests to cover all the API.
1955
1956         * TestWebKitAPI/PlatformGTK.cmake:
1957         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp:
1958         (TestWebKitAPI::TEST):
1959
1960 2017-11-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1961
1962         REGRESSION(r224179): [GTK] Several WebViewEditor tests are failing since r224179
1963         https://bugs.webkit.org/show_bug.cgi?id=179366
1964
1965         Reviewed by Michael Catanzaro.
1966
1967         Use always a toplevel window for WebViewEditor tests instead of creating and destroying one only to flush editor
1968         state.
1969
1970         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
1971
1972 2017-11-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1973
1974         [GTK][WPE] Build inspector resources using copy-user-interface-resources.pl script
1975         https://bugs.webkit.org/show_bug.cgi?id=179317
1976
1977         Reviewed by Michael Catanzaro.
1978
1979         Move generate-inspector-gresource-manifest.py to glib dir to be shared by GTK+ and WPE ports and update it to
1980         receive an input directory instead of a list of patterns.
1981         File::Copy::Recursive is required by copy-user-interface-resources.pl, so make sure it's installed.
1982
1983         * glib/generate-inspector-gresource-manifest.py: Renamed from Tools/gtk/generate-inspector-gresource-manifest.py.
1984         (get_filenames):
1985         (get_filenames.should_ignore_resource):
1986         * gtk/install-dependencies:
1987         * wpe/generate-inspector-gresource-manifest.py: Removed.
1988         * wpe/install-dependencies:
1989
1990 2017-11-07  Don Olmstead  <don.olmstead@sony.com>
1991
1992         Fix webkitpy tests after rev 224549.
1993
1994         Unreviewed build fix.
1995
1996         * Scripts/webkitpy/common/config/ports.py:
1997         (WinCairoPort.run_webkit_tests_command):
1998         * Scripts/webkitpy/common/config/ports_unittest.py:
1999         (DeprecatedPortTest.test_wincairo_port):
2000
2001 2017-11-07  Aakash Jain  <aakash_jain@apple.com>
2002
2003         Enable webkitpy EWS bubbles
2004         https://bugs.webkit.org/show_bug.cgi?id=178539
2005
2006         Reviewed by Alexey Proskuryakov.
2007
2008         * QueueStatusServer/config/queues.py: Added webkitpy EWS.
2009
2010 2017-11-07  Don Olmstead  <don.olmstead@sony.com>
2011
2012         Add a WinCairo EWS queue
2013         https://bugs.webkit.org/show_bug.cgi?id=179390
2014
2015         Reviewed by Lucas Forschler.
2016
2017         * QueueStatusServer/config/queues.py:
2018         * QueueStatusServer/model/queues.py:
2019         * Scripts/webkitpy/common/config/ews.json:
2020         * Scripts/webkitpy/common/config/ports.py:
2021         * Scripts/webkitpy/common/config/ports_unittest.py:
2022         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2023
2024 2017-11-07  Aakash Jain  <aakash_jain@apple.com>
2025
2026         fix check-webkit-style errors in webkitpy about not having two spaces before inline comment
2027         https://bugs.webkit.org/show_bug.cgi?id=171506
2028
2029         Reviewed by Alexey Proskuryakov.
2030
2031         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2032         (SCMTest._shared_test_reverse_diff): Added two spaces before inline comment.
2033         (test_create_patch_is_full_patch): Ditto.
2034         * Scripts/webkitpy/common/thread/messagepump.py:
2035         (MessagePump): Ditto.
2036         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2037         (Lighttpd._prepare_config): Ditto.
2038         * Scripts/webkitpy/style/checker.py: Ditto.
2039         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2040         (OrderOfIncludesTest.test_check_preprocessor_in_include_section): Ditto.
2041
2042 2017-11-07  Aakash Jain  <aakash_jain@apple.com>
2043
2044         Add support for webkitpy tests EWS
2045         https://bugs.webkit.org/show_bug.cgi?id=178480
2046
2047         Reviewed by Alexey Proskuryakov.
2048
2049         * Scripts/webkitpy/common/config/ews.json: Added webkitpy EWS.
2050         * Scripts/webkitpy/common/net/generictestresults.py: Renamed from Scripts/webkitpy/common/net/bindingstestresults.py.
2051         * Scripts/webkitpy/common/net/generictestresults_unittest.py: Renamed from Scripts/webkitpy/common/net/bindingstestresults_unittest.py.
2052         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2053         (PatchAnalysisTask._test_patch): Do not retry webkitpy test since they are not flaky.
2054         * Scripts/webkitpy/tool/bot/bindingstestresultsreader.py: Updated import for BindingsTestResult.
2055         * Scripts/webkitpy/tool/bot/retrylogic_unittest.py: Ditto.
2056         * Scripts/webkitpy/tool/bot/webkitpytestresultsreader.py: Copied from Scripts/webkitpy/tool/bot/bindingstestresultsreader.py.
2057         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2058         (AbstractEarlyWarningSystem.begin_work_queue): Added webkitpy test result reader.
2059         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Updated unit-tests.
2060         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py: Run webkitpy EWS only for relevant changes.
2061         * Scripts/webkitpy/tool/steps/runtests.py:
2062         (RunTests.run): Run webkitpy tests when --group=webkitpy is passed.
2063         (RunTests._run_webkitpy_tests): Method to invoke webkitpy tests.
2064         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2065         (test_runtests_webkitpy): Added unit-test.
2066
2067 2017-11-07  Commit Queue  <commit-queue@webkit.org>
2068
2069         Unreviewed, rolling out r224512 and r224521.
2070         https://bugs.webkit.org/show_bug.cgi?id=179388
2071
2072         An API test added with this change is failing an assertion on
2073         the bots. (Requested by ryanhaddad on #webkit).
2074
2075         Reverted changesets:
2076
2077         "[Attachment Support] Implement delegate hooks for attachment
2078         element insertion and removal"
2079         https://bugs.webkit.org/show_bug.cgi?id=179016
2080         https://trac.webkit.org/changeset/224512
2081
2082         "Remove stray logging from a newly added API test"
2083         https://trac.webkit.org/changeset/224521
2084
2085 2017-11-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2086
2087         Remove stray logging from a newly added API test
2088
2089         This was only for debugging purposes, and should have been removed before landing.
2090
2091         Rubber-stamped by Tim Horton.
2092
2093         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2094         (TestWebKitAPI::TEST):
2095
2096 2017-11-06  Jonathan Bedard  <jbedard@apple.com>
2097
2098         Only build ImageDiff for mac
2099         https://bugs.webkit.org/show_bug.cgi?id=179349
2100         <rdar://problem/35376237>
2101
2102         Reviewed by Tim Horton.
2103
2104         * ImageDiff/Makefile:
2105
2106 2017-11-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2107
2108         Unreviewed, fix the internal build after updating to a newer SDK
2109
2110         There shouldn't be any need to include and implement these method stubs anymore,
2111         even when building against the shipping iOS 11 SDK.
2112
2113         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2114         (-[MockDropSession session]): Deleted.
2115
2116 2017-11-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2117
2118         [Attachment Support] Implement delegate hooks for attachment element insertion and removal
2119         https://bugs.webkit.org/show_bug.cgi?id=179016
2120         <rdar://problem/35250890>
2121
2122         Reviewed by Tim Horton.
2123
2124         Introduces new API tests to check that various editing operations will or won't result in the new attachment
2125         insertion and removal delegate hooks being fired. Additionally refactors an existing test to verify that
2126         attachments insertion and removal is observable by the UI delegate.
2127
2128         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2129         (-[AttachmentUpdateObserver init]):
2130         (-[AttachmentUpdateObserver inserted]):
2131         (-[AttachmentUpdateObserver removed]):
2132         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]):
2133         (-[AttachmentUpdateObserver _webView:didRemoveAttachment:]):
2134         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::ObserveAttachmentUpdatesForScope):
2135         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::~ObserveAttachmentUpdatesForScope):
2136         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectAttachmentUpdates):
2137
2138         Implement a testing mechanism to temporarily bind a UI delegate to a given WKWebView and listen for inserted or
2139         removed attachments over the course of a particular scope. The API tests use this mechanism to check that the UI
2140         delegate hooks added in this patch are invoked with the right attachments when performing edit commands.
2141
2142         (-[TestWKWebView _synchronouslyExecuteEditCommand:argument:]):
2143         (-[TestWKWebView expectUpdatesAfterCommand:withArgument:expectedRemovals:expectedInsertions:]):
2144         (TestWebKitAPI::TEST):
2145
2146 2017-11-06  Christopher Reid  <chris.reid@sony.com>
2147
2148         Use enum classes within FileSystem
2149         https://bugs.webkit.org/show_bug.cgi?id=175172
2150
2151         Reviewed by Myles C. Maxfield.
2152
2153         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2154         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2155
2156 2017-11-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2157
2158         [WPE] -Wsign-compare warning in EventSenderProxyWPE.cpp
2159         https://bugs.webkit.org/show_bug.cgi?id=179039
2160
2161         Reviewed by Žan Doberšek.
2162
2163         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2164         (WTR::EventSenderProxy::updateTouchPoint):
2165         (WTR::EventSenderProxy::releaseTouchPoint):
2166
2167 2017-11-06  Robin Morisset  <rmorisset@apple.com>
2168
2169         Add a third benchmark to TailBench
2170         https://bugs.webkit.org/show_bug.cgi?id=178815
2171
2172         Reviewed by Saam Barati.
2173
2174         Add a new benchmark to TailBench: a BF interpreter written in a weird kinda functional style
2175
2176         * Scripts/run-jsc-benchmarks:
2177
2178 2017-11-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2179
2180         [GTK] Fix gtk-doc generation with gtk-doc master
2181         https://bugs.webkit.org/show_bug.cgi?id=179252
2182
2183         Reviewed by Carlos Garcia Campos.
2184
2185         gtkdoc-scangobj has changed to no longer use a shell when executing its subcommands. In
2186         particular, this means we can no longer rely on shell stuff in our run command that we use
2187         to run the scanner. We currently use the RUN envvar to set LD_LIBRARY_PATH, and the end
2188         result is gtkdoc-scangobj now attempts to execute our environment variable instead of the
2189         scanner itself. We can just set LD_LIBRARY_PATH directly, instead of using RUN, in order to
2190         make documentation generation work again.
2191
2192         * gtk/gtkdoc.py:
2193         (GTKDoc._run_gtkdoc_scangobj):
2194
2195 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2196
2197         [Touch Bar Web API] Add support for menuitem tag
2198         https://bugs.webkit.org/show_bug.cgi?id=179020
2199
2200         Reviewed by Ryosuke Niwa.
2201
2202         Defines flags for the menu item test so that the element is recognized
2203         only while its test is being run.
2204
2205         * DumpRenderTree/TestOptions.h:
2206         * DumpRenderTree/TestOptions.mm:
2207         (TestOptions::TestOptions):
2208         * DumpRenderTree/mac/DumpRenderTree.mm:
2209         (setWebPreferencesForTestOptions):
2210         * WebKitTestRunner/TestController.cpp:
2211         (WTR::TestController::resetPreferencesToConsistentValues):
2212         (WTR::updateTestOptionsFromTestHeader):
2213         * WebKitTestRunner/TestOptions.h:
2214         (WTR::TestOptions::hasSameInitializationOptions const):
2215
2216 2017-11-03  Andy Estes  <aestes@apple.com>
2217
2218         [iOS] Append the platform name to the product directory on all embedded platforms
2219         https://bugs.webkit.org/show_bug.cgi?id=179271
2220
2221         Reviewed by Joseph Pecoraro.
2222
2223         * Scripts/webkitdirs.pm:
2224         (determineConfigurationProductDir):
2225
2226 2017-11-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2227
2228         [WinCairo] Add --wincairo option to run-webkit-tests
2229         https://bugs.webkit.org/show_bug.cgi?id=179217
2230
2231         Reviewed by Alex Christensen.
2232
2233         * Scripts/webkitpy/port/factory.py:
2234         (platform_options):
2235
2236 2017-11-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2237
2238         [WPE][GTK] Avoid duplicating code for dist and distcheck targets
2239         https://bugs.webkit.org/show_bug.cgi?id=179154
2240
2241         Reviewed by Carlos Garcia Campos.
2242
2243         Move the script out of Tools/gtk because it is already used by WPE. Also, drop the .py
2244         prefix because it is executable.
2245
2246         * Scripts/make-dist: Renamed from Tools/gtk/make-dist.py.
2247
2248 2017-11-03  Jonathan Bedard  <jbedard@apple.com>
2249
2250         TestController platformAdjustContext should use provided WKContext for Mac
2251         https://bugs.webkit.org/show_bug.cgi?id=179124
2252         <rdar://problem/35295176>
2253
2254         Reviewed by Darin Adler.
2255
2256         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2257         (WTR::initializeWebViewConfiguration): Use the provided WKContext, since that is
2258         a WebProcessPool, instead of creating a second one.
2259
2260 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2261
2262         Add a FileSystem namespace to FileSystem.cpp
2263         https://bugs.webkit.org/show_bug.cgi?id=179063
2264
2265         Reviewed by Darin Adler.
2266
2267         * DumpRenderTree/win/DumpRenderTree.cpp:
2268         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2269         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
2270         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2271         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2272         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2273         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2274
2275 2017-11-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2276
2277         [WPE][JHBuild] Update WPEBackend and WPEBackend-mesa
2278         https://bugs.webkit.org/show_bug.cgi?id=179169
2279
2280         Reviewed by Michael Catanzaro.
2281
2282         Update WPEBackend and WPEBackend-mesa to last master as of today.
2283
2284         * wpe/jhbuild.modules:
2285
2286 2017-11-02  Frederic Wang  <fwang@igalia.com>
2287
2288         Add references to bug 179167 in FIXME comments
2289         https://bugs.webkit.org/show_bug.cgi?id=179168
2290
2291         Reviewed by Daniel Bates.
2292
2293         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2294
2295 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2296
2297         Implement WKFullscreenWindowController for iOS.
2298         https://bugs.webkit.org/show_bug.cgi?id=178924
2299         rdar://problem/34697120
2300
2301         Reviewed by Simon Fraser.
2302
2303         Enable ENABLE_FULLSCREEN_API for iOS.
2304
2305         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2306
2307 2017-11-01  Simon Fraser  <simon.fraser@apple.com>
2308
2309         Misc display list and other cleanup
2310         https://bugs.webkit.org/show_bug.cgi?id=179150
2311
2312         Reviewed by Tim Horton.
2313
2314         Add system trace points for display list recording.
2315
2316         * Tracing/SystemTracePoints.plist:
2317
2318 2017-11-01  Stephan Szabo  <stephan.szabo@sony.com>
2319
2320         [Win] Detect Visual Studio 2017 location
2321         https://bugs.webkit.org/show_bug.cgi?id=175275
2322
2323         Reviewed by Yusuke Suzuki.
2324
2325         * Scripts/build-jsc:
2326         * Scripts/build-webkit:
2327         * Scripts/update-vswhere.py: Added.
2328         * Scripts/webkitdirs.pm:
2329         (requireModulesForVSWhere):
2330         (pickCurrentVisualStudioInstallation):
2331         (pickLegacyVisualStudioInstallation):
2332         (visualStudioInstallDir):
2333         (visualStudioInstallDirVSWhere):
2334         (visualStudioInstallDirLegacy):
2335         (visualStudioInstallDirFallback):
2336         (msBuildInstallDir):
2337         (visualStudioVersion):
2338         (visualStudioVersionFromInstallDir):
2339         (generateBuildSystemFromCMakeProject):
2340
2341 2017-11-01  Tim Horton  <timothy_horton@apple.com>
2342
2343         Fix the !USE(QUICKLOOK) build
2344         https://bugs.webkit.org/show_bug.cgi?id=179128
2345
2346         Reviewed by Wenson Hsieh.
2347
2348         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:
2349
2350 2017-11-01  Frederic Wang  <fwang@igalia.com>
2351
2352         Make iOS Find UI reveal matches in scrollable elements
2353         https://bugs.webkit.org/show_bug.cgi?id=178789
2354
2355         Reviewed by Tim Horton.
2356
2357         This patch exposes WKWebView's findString function in order to test the fix for bug 178789.
2358
2359         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2360         (WTR::UIScriptController::findString): Dummy implementation of findString.
2361         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2362         (WTR::UIScriptController::findString): Ditto.
2363         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Declare findString.
2364         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2365         (WTR::UIScriptController::findString): Dummy implementation of findString.
2366         * TestRunnerShared/UIScriptContext/UIScriptController.h: Declare findString.
2367         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2368         (WTR::UIScriptController::findString): Implement findString by forwarding the call to the
2369         web view.
2370         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2371         (WTR::UIScriptController::findString): Dummy implementation of findString.
2372
2373 2017-11-01  Alex Christensen  <achristensen@webkit.org>
2374
2375         Add a test for _WKInputDelegate.willSubmitFormValues
2376         https://bugs.webkit.org/show_bug.cgi?id=179086
2377
2378         Reviewed by Darin Adler.
2379
2380         Hidden input types are not included in this submission because FormSubmission::create ignores them
2381         because input.isTextField() returns false.  This is existing behavior that wasn't shown by a test.
2382         HTTPBodies are also not sent to WKURLSchemeHandlers.  This is existing behavior that wasn't shown by a test.
2383
2384         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2385         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm: Added.
2386         (-[FormSubmissionDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
2387         (TEST):
2388
2389 2017-10-31  Ross Kirsling  <ross.kirsling@sony.com>
2390
2391         Web Inspector: Add Inspector menu items to Mac MiniBrowser
2392         https://bugs.webkit.org/show_bug.cgi?id=65218
2393
2394         Reviewed by Joseph Pecoraro.
2395
2396         Add Option-Command-I shortcut and corresponding Show/Close Web Inspector menu item to Mac MiniBrowser.
2397         Only works when browser window is focused, but at least WI can be opened without having to Inspect Element.
2398
2399         * MiniBrowser/mac/BrowserWindowController.h:
2400         * MiniBrowser/mac/BrowserWindowController.m:
2401         (-[BrowserWindowController showHideWebInspector:]):
2402         * MiniBrowser/mac/MainMenu.xib:
2403         * MiniBrowser/mac/WK1BrowserWindowController.m:
2404         (-[WK1BrowserWindowController validateMenuItem:]):
2405         (-[WK1BrowserWindowController showHideWebInspector:]):
2406         * MiniBrowser/mac/WK2BrowserWindowController.m:
2407         (-[WK2BrowserWindowController validateMenuItem:]):
2408         (-[WK2BrowserWindowController showHideWebInspector:]):
2409
2410 2017-10-31  Alex Christensen  <achristensen@webkit.org>
2411
2412         Use asynchronous ResourceHandleClient calls for WebKit1
2413         https://bugs.webkit.org/show_bug.cgi?id=160677
2414
2415         Reviewed by Brady Eidson.
2416
2417         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2418         (TestWebKitAPI::TEST):
2419         The HTML being loaded contains an iframe, so testing if the main resource has loaded doesn't necessarily mean all subresources are loaded.
2420         Wait until they are loaded before continuing the test.  This is a test of editing commands once the page has loaded, not a test of loading.
2421
2422 2017-10-31  Commit Queue  <commit-queue@webkit.org>
2423
2424         Unreviewed, rolling out r224143.
2425         https://bugs.webkit.org/show_bug.cgi?id=179091
2426
2427         The patch requires non-standard perl modules in macOS and
2428         breaks AWFY (Requested by yusukesuzuki on #webkit).
2429
2430         Reverted changeset:
2431
2432         "[Win] Detect Visual Studio 2017 location"
2433         https://bugs.webkit.org/show_bug.cgi?id=175275
2434         https://trac.webkit.org/changeset/224143
2435
2436 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2437
2438         Clean up some drag and drop feature flags
2439         https://bugs.webkit.org/show_bug.cgi?id=179082
2440
2441         Reviewed by Simon Fraser.
2442
2443         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2444         * TestWebKitAPI/ios/UIKitSPI.h:
2445
2446 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2447
2448         Fix up some content filtering feature flags
2449         https://bugs.webkit.org/show_bug.cgi?id=179079
2450
2451         Reviewed by Simon Fraser.
2452
2453         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2454         * TestWebKitAPI/Tests/WebKitCocoa/ContentFilteringPlugIn.mm:
2455         (-[MockContentFilterEnabler initWithCoder:]):
2456         (-[MockContentFilterEnabler dealloc]):
2457
2458 2017-10-31  Youenn Fablet  <youenn@apple.com>
2459
2460         rwt should allow service worker to load localhost HTTPS resources with any certificate
2461         https://bugs.webkit.org/show_bug.cgi?id=179018
2462
2463         Reviewed by Chris Dumez.
2464
2465         * WebKitTestRunner/TestController.cpp:
2466         (WTR::TestController::resetStateToConsistentValues): allowing any SSL certificate for service workers.
2467
2468 2017-10-31  Wenson Hsieh  <wenson_hsieh@apple.com>
2469
2470         [Attachment Support] Implement WKWebView SPI for inserting attachment elements
2471         https://bugs.webkit.org/show_bug.cgi?id=179013
2472         <rdar://problem/35249668>
2473
2474         Reviewed by Tim Horton.
2475
2476         Adds a new API test suite to exercise attachment element insertion and manipulation.
2477
2478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2479         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm: Added.
2480         (webViewForTestingAttachments):
2481         (testHTMLData):
2482         (testImageData):
2483         (-[TestWKWebView synchronouslyInsertAttachmentWithFilename:contentType:data:options:]):
2484         (-[TestWKWebView valueOfAttribute:forQuerySelector:]):
2485         (TestWebKitAPI::TEST):
2486
2487 2017-10-31  Alex Christensen  <achristensen@webkit.org>
2488
2489         Fix custom header field setting with reloads and asynchronous navigation action policy decisions
2490         https://bugs.webkit.org/show_bug.cgi?id=179064
2491
2492         Reviewed by Tim Horton.
2493
2494         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2495         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2496         (TEST):
2497
2498 2017-10-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2499
2500         WKBundlePageWillSendSubmitEventCallback is called with incorrect frame parameter
2501         https://bugs.webkit.org/show_bug.cgi?id=176719
2502
2503         Reviewed by Chris Dumez.
2504
2505         Test that WKBundlePageWillSendSubmitEventCallback is called with separate frame and
2506         sourceFrame parameters when the target frame of the form submission is not the source frame.
2507
2508         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
2509         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2510         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent_Bundle.cpp:
2511         (TestWebKitAPI::willSendSubmitEvent):
2512         * TestWebKitAPI/Tests/WebKit/auto-submitting-form.html:
2513
2514 2017-10-30  Alex Christensen  <achristensen@webkit.org>
2515
2516         ASSERTION FAILED: internalValuesConsistent(m_url) in WebCore::URLParser::URLParser
2517         https://bugs.webkit.org/show_bug.cgi?id=178861
2518
2519         Reviewed by Tim Horton.
2520
2521         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2522         (TestWebKitAPI::TEST_F):
2523
2524 2017-10-30  Commit Queue  <commit-queue@webkit.org>
2525
2526         Unreviewed, rolling out r224078.
2527         https://bugs.webkit.org/show_bug.cgi?id=179026
2528
2529         MotionMark regression (Requested by shallawa on #webkit).
2530
2531         Reverted changeset:
2532
2533         "When navigating back to a page, compositing layers may not
2534         use accelerated drawing"
2535         https://bugs.webkit.org/show_bug.cgi?id=178749
2536         https://trac.webkit.org/changeset/224078
2537
2538 2017-10-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2539
2540         [WPE] Fix build warnings
2541         https://bugs.webkit.org/show_bug.cgi?id=178899
2542
2543         Reviewed by Carlos Alberto Lopez Perez.
2544
2545         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2546         (testContextMenuDownloadActions):
2547         (testBlobDownload):
2548         (beforeAll):
2549         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
2550         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2551         (testWebViewJavaScriptDialogs):
2552         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
2553         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2554         * WebKitTestRunner/PlatformWPE.cmake:
2555         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2556         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
2557         (WTR::threadDefaultContext): Deleted.
2558
2559 2017-10-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2560
2561         [WPE] Upstream or stop using cairo-egl-device-create-for-egl-surface.patch
2562         https://bugs.webkit.org/show_bug.cgi?id=178898
2563
2564         Reviewed by Žan Doberšek.
2565
2566         This patch seems to be unused.
2567
2568         * wpe/jhbuild.modules:
2569         * wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Removed.
2570
2571 2017-10-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2572
2573         [WPE] Build more files under WebCore as unified sources and get rid of WebCorePlatformWPE build target
2574         https://bugs.webkit.org/show_bug.cgi?id=178964
2575
2576         Reviewed by Carlos Alberto Lopez Perez.
2577
2578         * TestWebKitAPI/PlatformWPE.cmake:
2579
2580 2017-10-12  Frederic Wang  <fwang@igalia.com>
2581
2582         Remove support for running safari on the iOS simulator with Xcode < 9.0
2583         https://bugs.webkit.org/show_bug.cgi?id=178203
2584
2585         Reviewed by Alexey Proskuryakov.
2586
2587         This is a follow-up of r223234. We no longer support iOS WebKit development for Xcode < 9.0
2588         and do not have any iOS simulator builders in our infrastructure. Hence we can remove the
2589         special case to calculate the iOS simulator applications path for these old versions.
2590
2591         * Scripts/webkitdirs.pm:
2592         (iosSimulatorApplicationsPath): Remove special case for XCode < 9.0
2593
2594 2017-10-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2595
2596         [WPE][GTK] Expose availability of certain editing commands in WebKitEditorState
2597         https://bugs.webkit.org/show_bug.cgi?id=168219
2598
2599         Reviewed by Ryosuke Niwa.
2600
2601         Test it.
2602
2603         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
2604         (testWebViewEditorCutCopyPasteNonEditable):
2605         (testWebViewEditorCutCopyPasteEditable):
2606         (testWebViewEditorSelectAllNonEditable):
2607         (testWebViewEditorSelectAllEditable):
2608         (loadContentsAndTryToCutSelection):
2609         (testWebViewEditorNonEditable):
2610         (testWebViewEditorEditorStateTypingAttributes):
2611         (testWebViewEditorInsertImage):
2612         (testWebViewEditorCreateLink):
2613
2614 2017-10-28  Michael Catanzaro  <mcatanzaro@igalia.com>
2615
2616         [WPE] Build gst-plugins-base without pango support
2617         https://bugs.webkit.org/show_bug.cgi?id=178918
2618
2619         Reviewed by Carlos Garcia Campos.
2620
2621         We need to build gst-plugins-base without pango support for WPE. Let's use JHBuild
2622         conditions so we can make platform-specific changes in the shared GStreamer moduleset.
2623
2624         * gstreamer/jhbuild.modules:
2625         * gtk/jhbuildrc:
2626         * wpe/jhbuildrc:
2627
2628 2017-10-27  Stephan Szabo  <stephan.szabo@sony.com>
2629
2630         [Win] Detect Visual Studio 2017 location
2631         https://bugs.webkit.org/show_bug.cgi?id=175275
2632
2633         Reviewed by Per Arne Vollan.
2634
2635         * Scripts/build-jsc:
2636         * Scripts/build-webkit:
2637         * Scripts/update-vswhere.py: Added.
2638         * Scripts/webkitdirs.pm:
2639         (pickCurrentVisualStudioInstallation):
2640         (pickLegacyVisualStudioInstallation):
2641         (visualStudioInstallDir):
2642         (visualStudioInstallDirVSWhere):
2643         (visualStudioInstallDirLegacy):
2644         (visualStudioInstallDirFallback):
2645         (msBuildInstallDir):
2646         (visualStudioVersion):
2647         (visualStudioVersionFromInstallDir):
2648         (generateBuildSystemFromCMakeProject):
2649
2650 2017-10-27  Devin Rousso  <webkit@devinrousso.com>
2651
2652         Create watchlist for files related WebInspector Recording
2653         https://bugs.webkit.org/show_bug.cgi?id=178965
2654
2655         Reviewed by Joseph Pecoraro.
2656
2657         * Scripts/webkitpy/common/config/watchlist:
2658
2659 2017-10-27  Jonathan Bedard  <jbedard@apple.com>
2660
2661         Windows and WebViews are retained after re-configure
2662         https://bugs.webkit.org/show_bug.cgi?id=178902
2663         <rdar://problem/35211518>
2664
2665         Reviewed by Alexey Proskuryakov.
2666
2667         The test runner effectively leaks windows every time a test changes configuration.
2668         We give each test it's own AutoreleasePool to fix this problem.
2669
2670         * WebKitTestRunner/TestController.cpp:
2671         (WTR::TestController::runTest): Add an AutoRelease pool scoping a test run
2672         so that when a configuration changes, the old window and WebView are released.
2673
2674 2017-10-27  Eric Carlson  <eric.carlson@apple.com>
2675
2676         NowPlayingInfo should contain a unique identifier
2677         https://bugs.webkit.org/show_bug.cgi?id=178872
2678         <rdar://problem/34924012>
2679
2680         Unreviewed, fix a flakey test.
2681
2682         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2683         (-[NowPlayingTestWebView hasActiveNowPlayingSession]): Update _lastUpdatedElapsedTime.
2684         (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]): Deleted.
2685
2686 2017-10-27  Fujii Hironori  <Hironori.Fujii@sony.com>
2687
2688         autoinstall can't download from http://pypi.python.org
2689         https://bugs.webkit.org/show_bug.cgi?id=178925
2690
2691         Reviewed by Ryosuke Niwa.
2692
2693         The web server pypi.python.org rejects non secure http.
2694
2695         * Scripts/webkitpy/thirdparty/__init__.py:
2696         (AutoinstallImportHook._install_mechanize): Use https instead of http.
2697         (AutoinstallImportHook._install_pep8): Ditto.
2698         (AutoinstallImportHook._install_pylint): Ditto.
2699         (AutoinstallImportHook._install_buildbot): Ditto.
2700         (AutoinstallImportHook._install_coverage): Ditto.
2701
2702 2017-10-26  Fujii Hironori  <Hironori.Fujii@sony.com>
2703
2704         [GTK][WPE] install-dependencies can't find libapache2-mod-php7.0 on Ubuntu 17.10
2705         https://bugs.webkit.org/show_bug.cgi?id=178854
2706
2707         Reviewed by Michael Catanzaro.
2708
2709         * Scripts/webkitpy/port/base.py:
2710         (Port._debian_php_version): Return "-php7.1" if libphp7.1.so found.
2711         (Port._is_debian_php_version_7): Deleted.
2712         * gtk/install-dependencies: Install libapache2-mod-php instead of libapache2-mod-php7.0.
2713         * wpe/install-dependencies: Ditto.
2714
2715 2017-10-25  Simon Fraser  <simon.fraser@apple.com>
2716
2717         When navigating back to a page, compositing layers may not use accelerated drawing
2718         https://bugs.webkit.org/show_bug.cgi?id=178749
2719         rdar://problem/35158946
2720
2721         Reviewed by Dean Jackson.
2722
2723         Fix WTR and DRT to parse "useAcceleratedDrawing" out of "webkit-test-runner" options
2724         and use it to set the state of the web view.
2725
2726         * DumpRenderTree/TestOptions.h:
2727         * DumpRenderTree/TestOptions.mm:
2728         (TestOptions::TestOptions):
2729         * DumpRenderTree/mac/DumpRenderTree.mm:
2730         (setWebPreferencesForTestOptions):
2731         * WebKitTestRunner/TestController.cpp:
2732         (WTR::TestController::resetPreferencesToConsistentValues):
2733         (WTR::updateTestOptionsFromTestHeader):
2734         * WebKitTestRunner/TestOptions.h:
2735         (WTR::TestOptions::hasSameInitializationOptions const):
2736
2737 2017-10-26  Alex Christensen  <achristensen@webkit.org>
2738
2739         Move WKWebViewConfiguration validation to WKWebView construction
2740         https://bugs.webkit.org/show_bug.cgi?id=178840
2741
2742         Reviewed by Tim Horton.
2743
2744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2745         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm: Added.
2746         (TEST):
2747
2748 2017-10-26  Myles C. Maxfield  <mmaxfield@apple.com>
2749
2750         Demonstrate a possible structure of the WebGPU API
2751         https://bugs.webkit.org/show_bug.cgi?id=178874
2752
2753         Reviewed by Dean Jackson.
2754
2755         Over the past few weeks, we've been putting together an example showing that a WebGPU API
2756         which has implicit barriers can work on all three low-level graphics APIs. We've implemented
2757         it on top of Vulkan first, because this is the API which has the strictest requirements and
2758         is most difficult to use.
2759
2760         With this API, this is a valid WebGPU snippet:
2761
2762         auto device = WebGPU::Device::create(hInstance, hWnd);
2763         auto& commandQueue = device->getCommandQueue();
2764         auto& renderState = device->getRenderState(vertexShader, "main", fragmentShader, "main", { }, { }, { }, nullptr);
2765         
2766         … later, in the draw() function …
2767         
2768         auto renderPass = commandQueue->createRenderPass(nullptr);
2769         renderPass->setRenderState(renderState);
2770         renderPass->setViewport(0, 0, width, height);
2771         renderPass->setScissorRect(0, 0, width, height);
2772         renderPass->draw(3);
2773         commandQueue->commitRenderPass(std::move(renderPass));
2774         commandQueue->present();
2775
2776         This snippet doesn’t hook up any vertex attributes or resources, which means the vertex
2777         shader has to say something like ({vec4(…), vec4(…), vec4(…)})[gl_VertexIndex]. It also
2778         passes in “nullptr” when creating the render pass, which means “render to the screen, rather
2779         than to a frame buffer.” You can also see that it doesn’t attach any resources to the draw
2780         call.
2781
2782         In Direct3D 12 and Vulkan, resources are bound in sets, rather than individually. For
2783         example, a set might contain two uniform buffers, a texture, and another uniform buffer. At
2784         draw time, you swap in whole sets of resources with a single call. A shader invocation can
2785         access a collection of sets. Because all shader resource accesses are indirected through
2786         these sets, the shape of these sets needs to be supplied at the time you compile the render
2787         state. Here is a snippet which bounds a single set which contains a uniform buffer and a
2788         texture:
2789
2790         auto buffer = device->getBuffer(bufferInitialContents);
2791         auto texture = device->getTexture(buffer width, height, WebGPU::PixelFormat::RGBA8, textureInitialContents);
2792         // One resource set, which holds a single uniform buffer object and a single texture
2793         auto& renderState = device->getRenderState(vertexShader, "main", fragmentShader, "main", { }, { }, { { WebGPU::ResourceType::UniformBufferObject, WebGPU::ResourceType::Texture } }, nullptr);
2794         
2795         … later, in the draw() function …
2796         
2797         auto renderPass = commandQueue->createRenderPass(nullptr);
2798         renderPass->setRenderState(renderState);
2799         renderPass->setResources(0, { WebGPU::UniformBufferObjectReference(buffer.get()), WebGPU::TextureReference(texture.get()) });
2800         …
2801         renderPass->draw(3);
2802         commandQueue->commitRenderPass(std::move(renderPass));
2803         commandQueue->present();
2804         
2805         The first argument to the setResources() call identifies which set to populate with the supplied resources.
2806
2807         One tenant of the low-level graphics APIs is that, if you’ve enabled double buffering (or
2808         triple buffering), the GPU is executing one frame at the same time you are recording the
2809         next frame. This often means that you need duplicate resources so the CPU and GPU don’t step
2810         on each other’s toes. However, platforms have platform-specific requirements about whether
2811         or not they can be double / triple buffered, and we don’t want to expose this to the Web for
2812         fear of badly-authored programs.
2813
2814         To solve this, resources are reference counted, and the return type of getBuffer() is an
2815         RAII type called BufferHolder which increments and decrements the reference count
2816         automatically. The reference count is also incremented and decremented when the GPU is using
2817         the resource in a Pass. When the reference count reaches 0, the resource isn’t destroyed;
2818         instead, it’s simply moved to a “free list” which getBuffer() may pull from. Therefore,
2819         applications don’t need to know whether the frame buffer is double buffered or triple
2820         buffered; they can just getBuffer() each frame, and the correct number of buffers will be
2821         created and recycled.
2822         
2823         {
2824             auto buffer = device->getBuffer(bufferSize); // These get recycled
2825             … populate the buffer …
2826             auto renderPass = commandQueue->createRenderPass(nullptr);
2827             renderPass->setRenderState(renderState);
2828             renderPass->setResources(0, { WebGPU::UniformBufferObjectReference(buffer.get()) });
2829             …
2830             renderPass->draw(…);
2831             commandQueue->commitRenderPass(std::move(renderPass));
2832         }
2833         commandQueue->present();
2834
2835         In Direct3D and Vulkan, vertex buffers and index buffers are not part of the resource sets
2836         mentioned above. Instead, you tell the render state about the shape of the vertex and index
2837         buffers, and you swap them out independently in the draw loop. Metal and Vulkan have almost
2838         identical API to specify this shape of the vertex buffers, so I’ve mostly copied it. In this
2839         example, we have two vertex attributes, a vec2 and a vec3, which both come from the same
2840         buffer:
2841         
2842         // { Attribute format, offset within stride, buffer to pull from }
2843         std::vector<WebGPU::RenderState::VertexAttribute> vertexAttributes = { {WebGPU::RenderState::VertexFormat::Float2, 0, 0}, {WebGPU::RenderState::VertexFormat::Float3, sizeof(float) * 2, 0} };
2844         // A single vertex buffer, with a stride of 5 floats
2845         auto& renderState = device->getRenderState(vertexShader, "main", fragmentShader, "main", { sizeof(float) * 5 }, vertexAttributes, resourceTypes, nullptr);
2846         
2847         … later, in the draw() function …
2848         
2849         auto renderPass = commandQueue->createRenderPass(nullptr);
2850         renderPass->setRenderState(renderState);
2851         renderPass->setVertexAttributeBuffers({ vertexBuffer.get() }); // The one vertex buffer which both attributes pull from
2852         renderPass->setResources(…);
2853         …
2854         renderPass->draw(…);
2855         commandQueue->commitRenderPass(std::move(renderPass));
2856         commandQueue->present();
2857
2858         You can also tell the RenderState about how many render targets you have and their formats,
2859         and then when you create the RenderPass, you specify the specific textures you want to
2860         render into.
2861
2862         std::vector<WebGPU::PixelFormat> colorPixelFormats = { WebGPU::PixelFormat::RGBA8, WebGPU::PixelFormat::RGBA8 }; // Two render targets, with these formats
2863         auto& renderState = device->getRenderState(vertexShader, "main", fragmentShader, "main", vertexBufferStrides, vertexAttributes, resourceTypes, &colorPixelFormats);
2864         
2865         … later, in the draw() function …
2866         
2867         std::vector<std::reference_wrapper<WebGPU::Texture>> destinationTextures = { texture1->get(), texture2->get() };
2868         auto renderPass = commandQueue->createRenderPass(&destinationTextures);
2869         renderPass->setRenderState(renderState);
2870         …
2871         renderPass->draw(…);
2872         commandQueue->commitRenderPass(std::move(renderPass));
2873         
2874         // Now, draw one of the textures to the screen. Note that no synchronization is necessary here!
2875         auto renderPass = commandQueue->createRenderPass(nullptr);
2876         renderPass->setRenderState(renderState2);
2877         renderPass->setResources(0, { WebGPU:: TextureReference(texture1.get()) });
2878         …
2879         renderPass->draw(…);
2880         commandQueue->commitRenderPass(std::move(renderPass));
2881         commandQueue->present();
2882
2883         Just like how in Metal has Render Encoders and Compute Encoders, WebGPU has RenderPasses
2884         and ComputePasses.
2885
2886         auto& computeState = device->getComputeState(computeShader, "main", resourceTypes);
2887         …
2888         auto computePass = commandQueue->createComputePass();
2889         computePass->setComputeState(computeState);
2890         computePass->setResources(0, resources);
2891         computePass->dispatch(width, height, depth);
2892         commandQueue->commitComputePass(std::move(computePass));
2893         
2894         // Now, draw the resources we just computed. Note that no synchronization is necessary here!
2895         auto renderPass = commandQueue->createRenderPass(nullptr);
2896         renderPass->setRenderState(renderState);
2897         renderPass->setResources(0, resources });
2898         …
2899         renderPass->draw(…);
2900         commandQueue->commitRenderPass(std::move(renderPass));
2901         commandQueue->present();
2902
2903         There are also two other types of passes: one that corresponds to a Metal blit encoder, and
2904         one that allows the CPU to change the contents of GPU buffers and textures. This last kind
2905         of pass is a little interesting: you can’t just change the contents of a buffer at any time
2906         you feel like it, because that resource might be in use by the GPU. Therefore, we need to do
2907         the same kind of synchronization that we already do at render pass boundaries.
2908
2909         In addition, both Vulkan and Direct3D have a concept of a memory heap. A resource might
2910         exist inside a heap which is fast, but invisible from the CPU, or in a heap which is slow,
2911         but visible by the CPU. Certain operations are not possible from some types of images (e.g.
2912         non-tiled textures may not be able to be sampled from). The usual way to get around this
2913         problem is to have two resources: a slow staging resource which the CPU can see, and a fast
2914         resource which the CPU can’t see. Uploading data is a two-pass algorithm, where the CPU
2915         memcpy()s into the slow staging resource, and then a blit command is enqueued on the GPU to
2916         copy the contents of the staging resource to the real resource. This requires that the
2917         upload have access to the commandQueue so it can possibly enqueue a blit between the staging
2918         and real resources. Therefore, a pass is the right level of abstraction for these facilities.
2919
2920         std::queue<boost::unique_future<std::vector<uint8_t>>> futureQueue; // Promises for data downloads from the GPU
2921         
2922         … later, in the draw() function …
2923         
2924         // See if any of the previously-enqueued downloads are finished
2925         while (!futureQueue.empty() && futureQueue.front(). has_value()) {
2926             std::vector<uint8_t>& data = futureQueue.front().get();
2927             // Use the downloaded data
2928             futureQueue.pop();
2929         }
2930         …
2931         auto hostAccessPass = commandQueue->createHostAccessPass();
2932         hostAccessPass->overwriteBuffer(buffer->get(), bufferContents); // Upload data to a resource
2933         
2934         futureQueue.emplace(hostAccessPass->getBufferContents(buffer->get()));
2935         commandQueue->commitHostAccessPass(std::move(hostAccessPass));
2936         
2937         You can also issue copy commands between resources entirely on the GPU:
2938         
2939         auto blitPass = commandQueue->createBlitPass();
2940         blitPass->copyTexture(source->get(), destination->get(), sourceX, sourceY, destinationX, destinationY, width, height);
2941         commandQueue->commitBlitPass(std::move(blitPass));
2942
2943         * Scripts/webkitpy/style/checker.py:
2944         * WebGPUAPIStructure/Example/Example.cpp: Added.
2945         (readFile):
2946         (drawWebGPU):
2947         (wWinMain):
2948         (MyRegisterClass):
2949         (InitInstance):
2950         (WndProc):
2951         * WebGPUAPIStructure/Example/Example.h: Added.
2952         * WebGPUAPIStructure/Example/Example.ico: Added.
2953         * WebGPUAPIStructure/Example/Example.rc: Added.
2954         * WebGPUAPIStructure/Example/Example.vcxproj: Added.
2955         * WebGPUAPIStructure/Example/Example.vcxproj.filters: Added.
2956         * WebGPUAPIStructure/Example/Example.vcxproj.user: Added.
2957         * WebGPUAPIStructure/Example/resource.h: Added.
2958         * WebGPUAPIStructure/Example/small.ico: Added.
2959         * WebGPUAPIStructure/Example/stdafx.cpp: Added.
2960         * WebGPUAPIStructure/Example/stdafx.h: Added.
2961         * WebGPUAPIStructure/Example/targetver.h: Added.
2962         * WebGPUAPIStructure/WebGPU-Common/WebGPU-Common.vcxproj: Added.
2963         * WebGPUAPIStructure/WebGPU-Common/WebGPU-Common.vcxproj.filters: Added.
2964         * WebGPUAPIStructure/WebGPU-Common/WebGPU.cpp: Added.
2965         (WebGPU::BufferHolder::BufferHolder):
2966         (WebGPU::BufferHolder::~BufferHolder):
2967         (WebGPU::TextureHolder::TextureHolder):
2968         (WebGPU::TextureHolder::~TextureHolder):
2969         (WebGPU::SamplerHolder::SamplerHolder):
2970         (WebGPU::SamplerHolder::~SamplerHolder):
2971         * WebGPUAPIStructure/WebGPU-Common/WebGPU.h: Added.
2972         (WebGPU::Queue::~Queue):
2973         (WebGPU::RenderState::~RenderState):
2974         (WebGPU::ComputeState::~ComputeState):
2975         (WebGPU::Buffer::~Buffer):
2976         (WebGPU::Texture::~Texture):
2977         (WebGPU::Sampler::~Sampler):
2978         (WebGPU::TextureReference::TextureReference):
2979         (WebGPU::TextureReference::get const):
2980         (WebGPU::SamplerReference::SamplerReference):
2981         (WebGPU::SamplerReference::get const):
2982         (WebGPU::UniformBufferObjectReference::UniformBufferObjectReference):
2983         (WebGPU::UniformBufferObjectReference::get const):
2984         (WebGPU::ShaderStorageBufferObjectReference::ShaderStorageBufferObjectReference):
2985         (WebGPU::ShaderStorageBufferObjectReference::get const):
2986         (WebGPU::RenderPass::~RenderPass):
2987         (WebGPU::ComputePass::~ComputePass):
2988         (WebGPU::BlitPass::~BlitPass):
2989         (WebGPU::HostAccessPass::~HostAccessPass):
2990         (WebGPU::BufferHolder::get):
2991         (WebGPU::TextureHolder::get):
2992         (WebGPU::SamplerHolder::get):
2993         (WebGPU::Device::~Device):
2994         * WebGPUAPIStructure/WebGPU-Vulkan/BlitPassImpl.cpp: Added.
2995         (WebGPU::BlitPassImpl::BlitPassImpl):
2996         (WebGPU::BlitPassImpl::copyTexture):
2997         * WebGPUAPIStructure/WebGPU-Vulkan/BlitPassImpl.h: Added.
2998         * WebGPUAPIStructure/WebGPU-Vulkan/BufferImpl.cpp: Added.
2999         (WebGPU::BufferImpl::BufferImpl):
3000         (WebGPU::BufferImpl::decrementReferenceCount):
3001         * WebGPUAPIStructure/WebGPU-Vulkan/BufferImpl.h: Added.
3002         (WebGPU::BufferImpl::getBuffer const):
3003         (WebGPU::BufferImpl::getDeviceMemory const):
3004         (WebGPU::BufferImpl::incrementReferenceCount):
3005         (WebGPU::BufferImpl::getLength const):
3006         * WebGPUAPIStructure/WebGPU-Vulkan/ComputePassImpl.cpp: Added.
3007         (WebGPU::ComputePassImpl::ComputePassImpl):
3008         (WebGPU::ComputePassImpl::setComputeState):
3009         (WebGPU::ComputePassImpl::setResources):
3010         (WebGPU::ComputePassImpl::dispatch):
3011         * WebGPUAPIStructure/WebGPU-Vulkan/ComputePassImpl.h: Added.
3012         * WebGPUAPIStructure/WebGPU-Vulkan/ComputeStateImpl.cpp: Added.
3013         (WebGPU::ComputeStateImpl::ComputeStateImpl):
3014         * WebGPUAPIStructure/WebGPU-Vulkan/ComputeStateImpl.h: Added.
3015         (WebGPU::ComputeStateImpl::getPipeline const):
3016         (WebGPU::ComputeStateImpl::getPipelineLayout const):
3017         (WebGPU::ComputeStateImpl::getDescriptorSetLayouts const):
3018         * WebGPUAPIStructure/WebGPU-Vulkan/DeviceImpl.cpp: Added.
3019         (WebGPU::Device::create):
3020         (WebGPU::convertPixelFormat):
3021         (WebGPU::convertFormat):
3022         (WebGPU::debugReport):
3023         (WebGPU::DeviceImpl::DeviceImpl):
3024         (WebGPU::DeviceImpl::getCommandQueue):
3025         (WebGPU::DeviceImpl::prepareShader):
3026         (WebGPU::DeviceImpl::createPipelineLayout):
3027         (WebGPU::DeviceImpl::createCompatibleRenderPass):
3028         (WebGPU::convertVertexFormat):
3029         (WebGPU::DeviceImpl::getRenderState):
3030         (WebGPU::DeviceImpl::getComputeState):
3031         (WebGPU::DeviceImpl::getBuffer):
3032         (WebGPU::DeviceImpl::returnBuffer):
3033         (WebGPU::DeviceImpl::getTexture):
3034         (WebGPU::DeviceImpl::returnTexture):
3035         (WebGPU::DeviceImpl::getSampler):
3036         (WebGPU::DeviceImpl::returnSampler):
3037         (WebGPU::DeviceImpl::~DeviceImpl):
3038         * WebGPUAPIStructure/WebGPU-Vulkan/DeviceImpl.h: Added.
3039         (WebGPU::DeviceImpl::UniqueDebugReportCallbackEXT::UniqueDebugReportCallbackEXT):
3040         (WebGPU::DeviceImpl::UniqueDebugReportCallbackEXT::operator=):
3041         (WebGPU::DeviceImpl::UniqueDebugReportCallbackEXT::~UniqueDebugReportCallbackEXT):
3042         (WebGPU::DeviceImpl::UniqueDebugReportCallbackEXT::destroy):
3043         (WebGPU::DeviceImpl::TextureParameters::operator== const):
3044         (WebGPU::DeviceImpl::TextureParametersHash::operator() const):
3045         * WebGPUAPIStructure/WebGPU-Vulkan/HostAccessPassImpl.cpp: Added.
3046         (WebGPU::HostAccessPassImpl::HostAccessPassImpl):
3047         (WebGPU::HostAccessPassImpl::overwriteBuffer):
3048         (WebGPU::HostAccessPassImpl::getBufferContents):
3049         (WebGPU::HostAccessPassImpl::execute):
3050         * WebGPUAPIStructure/WebGPU-Vulkan/HostAccessPassImpl.h: Added.
3051         (WebGPU::HostAccessPassImpl::getFinishedEvent const):
3052         * WebGPUAPIStructure/WebGPU-Vulkan/PassImpl.cpp: Added.
3053         (WebGPU::PassImpl::PassImpl):
3054         (WebGPU::ResourceVisitor::operator()):
3055         (WebGPU::ResourceVisitor::getBindings const):
3056         (WebGPU::ResourceVisitor::releaseWriteDescriptorSets):
3057         (WebGPU::ResourceVisitor::getDescriptorImageInfos const):
3058         (WebGPU::ResourceVisitor::getDescriptorBufferInfos const):
3059         (WebGPU::ResourceVisitor::getBuffers const):
3060         (WebGPU::ResourceVisitor::getTextures const):
3061         (WebGPU::ResourceVisitor::getSamplers const):
3062         (WebGPU::ResourceVisitor::getImageCount const):
3063         (WebGPU::ResourceVisitor::getSamplerCount const):
3064         (WebGPU::ResourceVisitor::getUniformBufferCount const):
3065         (WebGPU::ResourceVisitor::getStorageBufferCount const):
3066         (WebGPU::PassImpl::setResources):
3067         (WebGPU::PassImpl::insertBuffer):
3068         (WebGPU::PassImpl::insertTexture):
3069         (WebGPU::PassImpl::insertSampler):
3070         * WebGPUAPIStructure/WebGPU-Vulkan/PassImpl.h: Added.
3071         (WebGPU::PassImpl::getCommandBuffer const):
3072         (WebGPU::PassImpl::iterateBuffers):
3073         (WebGPU::PassImpl::iterateTextures):
3074         (WebGPU::PassImpl::ResourceReference::ResourceReference):
3075         (WebGPU::PassImpl::ResourceReference::~ResourceReference):
3076         (WebGPU::PassImpl::ResourceReference::operator=):
3077         (WebGPU::PassImpl::ResourceReference::operator== const):
3078         (WebGPU::PassImpl::ResourceReference::get const):
3079         (WebGPU::PassImpl::ResourceReference::release):
3080         (WebGPU::PassImpl::ResourceReferenceHash::operator() const):
3081         * WebGPUAPIStructure/WebGPU-Vulkan/QueueImpl.cpp: Added.
3082         (WebGPU::QueueImpl::QueueImpl):
3083         (WebGPU::QueueImpl::prepareCurrentFrame):
3084         (WebGPU::QueueImpl::createSpecificRenderPass):
3085         (WebGPU::QueueImpl::createFramebuffer):
3086         (WebGPU::QueueImpl::createRenderPass):
3087         (WebGPU::QueueImpl::commitRenderPass):
3088         (WebGPU::QueueImpl::createComputePass):
3089         (WebGPU::QueueImpl::commitComputePass):
3090         (WebGPU::QueueImpl::createBlitPass):
3091         (WebGPU::QueueImpl::commitBlitPass):
3092         (WebGPU::QueueImpl::createHostAccessPass):
3093         (WebGPU::QueueImpl::commitHostAccessPass):
3094         (WebGPU::QueueImpl::present):
3095         (WebGPU::QueueImpl::commitPass):
3096         (WebGPU::QueueImpl::synchronizeResources):
3097         (WebGPU::QueueImpl::~QueueImpl):
3098         * WebGPUAPIStructure/WebGPU-Vulkan/QueueImpl.h: Added.
3099         * WebGPUAPIStructure/WebGPU-Vulkan/RenderPassImpl.cpp: Added.
3100         (WebGPU::RenderPassImpl::RenderPassImpl):
3101         (WebGPU::RenderPassImpl::setRenderState):
3102         (WebGPU::RenderPassImpl::setVertexAttributeBuffers):
3103         (WebGPU::RenderPassImpl::setResources):
3104         (WebGPU::RenderPassImpl::setViewport):
3105         (WebGPU::RenderPassImpl::setScissorRect):
3106         (WebGPU::RenderPassImpl::draw):
3107         * WebGPUAPIStructure/WebGPU-Vulkan/RenderPassImpl.h: Added.
3108         * WebGPUAPIStructure/WebGPU-Vulkan/RenderStateImpl.cpp: Added.
3109         (WebGPU::RenderStateImpl::RenderStateImpl):
3110         * WebGPUAPIStructure/WebGPU-Vulkan/RenderStateImpl.h: Added.
3111         (WebGPU::RenderStateImpl::getPipeline const):
3112         (WebGPU::RenderStateImpl::getPipelineLayout const):
3113         (WebGPU::RenderStateImpl::getDescriptorSetLayouts const):
3114         * WebGPUAPIStructure/WebGPU-Vulkan/SamplerImpl.cpp: Added.
3115         (WebGPU::SamplerImpl::SamplerImpl):
3116         (WebGPU::SamplerImpl::decrementReferenceCount):
3117         * WebGPUAPIStructure/WebGPU-Vulkan/SamplerImpl.h: Added.
3118         (WebGPU::SamplerImpl::getSampler):
3119         (WebGPU::SamplerImpl::incrementReferenceCount):
3120         (WebGPU::SamplerImpl::getFilter):
3121         (WebGPU::SamplerImpl::getMipmapMode):
3122         (WebGPU::SamplerImpl::getAddressMode):
3123         * WebGPUAPIStructure/WebGPU-Vulkan/TextureImpl.cpp: Added.
3124         (WebGPU::TextureImpl::TextureImpl):
3125         (WebGPU::TextureImpl::decrementReferenceCount):
3126         * WebGPUAPIStructure/WebGPU-Vulkan/TextureImpl.h: Added.
3127         (WebGPU::TextureImpl::getImage const):
3128         (WebGPU::TextureImpl::getImageView const):
3129         (WebGPU::TextureImpl::getFormat const):
3130         (WebGPU::TextureImpl::incrementReferenceCount):
3131         (WebGPU::TextureImpl::getWidth const):
3132         (WebGPU::TextureImpl::getHeight const):
3133         (WebGPU::TextureImpl::getTransferredToGPU const):
3134         (WebGPU::TextureImpl::setTransferredToGPU):
3135         * WebGPUAPIStructure/WebGPU-Vulkan/WebGPU-Vulkan.vcxproj: Added.
3136         * WebGPUAPIStructure/WebGPU-Vulkan/WebGPU-Vulkan.vcxproj.filters: Added.
3137         * WebGPUAPIStructure/WebGPU.sln: Added.
3138
3139 2017-10-26  Eric Carlson  <eric.carlson@apple.com>
3140
3141         NowPlayingInfo should contain a unique identifier
3142         https://bugs.webkit.org/show_bug.cgi?id=178872
3143
3144         Reviewed by Jer Noble.
3145
3146         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
3147         (-[NowPlayingTestWebView hasActiveNowPlayingSession]): Use completion handler.
3148         (TestWebKitAPI::TEST): Cleanup tests. Use new API.
3149         (-[NowPlayingTestWebView waitForNowPlayingInfoToChange]): Deleted.
3150
3151 2017-10-26  Eric Carlson  <eric.carlson@apple.com>
3152
3153         [MediaStream] Clear cached gUM prompt state
3154         https://bugs.webkit.org/show_bug.cgi?id=178754
3155         <rdar://problem/32742356>
3156
3157         Unreviewed, fix a flakey test.
3158
3159         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
3160         (-[GetUserMediaRepromptTestView haveStream:]): New, check several times for expected state.
3161         (TestWebKitAPI::TEST): Don't assume stream state changes in the page immediately.
3162
3163 2017-10-26  Andy Estes  <aestes@apple.com>
3164
3165         [Payment Request] Enable Payment Request whenever Apple Pay is enabled
3166         https://bugs.webkit.org/show_bug.cgi?id=178880
3167
3168         Reviewed by Tim Horton.
3169
3170         * WebKitTestRunner/TestController.cpp:
3171         (WTR::TestController::resetPreferencesToConsistentValues):
3172
3173 2017-10-26  Joseph Pecoraro  <pecoraro@apple.com>
3174
3175         Add and update some watchlists
3176         https://bugs.webkit.org/show_bug.cgi?id=178304
3177
3178         Reviewed by Simon Fraser.
3179
3180         * Scripts/webkitpy/common/config/watchlist:
3181
3182 2017-10-26  Ryan Haddad  <ryanhaddad@apple.com>
3183
3184         Unreviewed, rolling out r223984.
3185
3186         Caused LayoutTest assertion failures.
3187
3188         Reverted changeset:
3189
3190         "When navigating back to a page, compositing layers may not
3191         use accelerated drawing"
3192         https://bugs.webkit.org/show_bug.cgi?id=178749
3193         https://trac.webkit.org/changeset/223984
3194
3195 2017-10-26  Christopher Reid  <chris.reid@sony.com>
3196
3197         Remove scopeguard from platform
3198         https://bugs.webkit.org/show_bug.cgi?id=178681
3199
3200         Reviewed by Brady Eidson.
3201
3202         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3203
3204 2017-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3205
3206         WebDriver: Add support to import and run W3C tests
3207         https://bugs.webkit.org/show_bug.cgi?id=177304
3208
3209         Reviewed by Brian Burg.
3210
3211         WPT has now several WebDriver tests, and new ones are going to be added to cover the whole spec. This patch
3212         adds the initial support for running W3C tests. The script import-w3c-webdriver-tests reuses parts of the W3C
3213         test downloader to download the tests and required tools from WPT repository into WebDriverTests
3214         directory. Tests can be run with run-webdriver-tests, a new script that works similar to other test runner
3215         scripts. For now it shows a summary at the end of the execution, there aren't expectations yet, since we are not
3216         ready to run those tests in the bots. Once we are ready to properly run the tests, we can add the expectations
3217         support and run the tests in the bots.
3218
3219         * Scripts/import-w3c-webdriver-tests: Added.
3220         * Scripts/run-webdriver-tests: Added.
3221         * Scripts/webkitpy/style/checker.py: Skip WebDriverTests directory since it only contains third-party python
3222         code.
3223         * Scripts/webkitpy/thirdparty/__init__.py: Add support to autodownload mozlog and mozprocess since they are
3224         required by the WebDriver tests.
3225         * Scripts/webkitpy/webdriver_tests/__init__.py: Added.
3226         * Scripts/webkitpy/webdriver_tests/webdriver_driver.py: Added.
3227         * Scripts/webkitpy/webdriver_tests/webdriver_driver_gtk.py: Added.
3228         * Scripts/webkitpy/webdriver_tests/webdriver_test_result.py: Added.
3229         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py: Added.
3230         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py: Added.
3231         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py: Added.
3232         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py: Added.
3233
3234 2017-10-25  Eric Carlson  <eric.carlson@apple.com>
3235
3236         [MediaStream] Clear cached gUM prompt state
3237         https://bugs.webkit.org/show_bug.cgi?id=178754
3238         <rdar://problem/32742356>
3239
3240         Reviewed by Youenn Fablet.
3241
3242         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test
3243
3244         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm: Added.
3245         (-[GetUserMediaRepromptUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3246         (-[GetUserMediaRepromptUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3247         (TestWebKitAPI::TEST):
3248
3249         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3250
3251 2017-10-25  Ross Kirsling  <ross.kirsling@sony.com>
3252
3253         Add committer status for Ross Kirsling
3254         https://bugs.webkit.org/show_bug.cgi?id=178832
3255
3256         Unreviewed.
3257
3258         * Scripts/webkitpy/common/config/contributors.json:
3259
3260 2017-10-25  Simon Fraser  <simon.fraser@apple.com>
3261
3262         When navigating back to a page, compositing layers may not use accelerated drawing
3263         https://bugs.webkit.org/show_bug.cgi?id=178749
3264         rdar://problem/35158946
3265
3266         Reviewed by Dean Jackson.
3267
3268         Fix WTR and DRT to parse "useAcceleratedDrawing" out of "webkit-test-runner" options
3269         and use it to set the state of the web view.
3270
3271         * DumpRenderTree/TestOptions.h:
3272         * DumpRenderTree/TestOptions.mm:
3273         (TestOptions::TestOptions):
3274         * DumpRenderTree/mac/DumpRenderTree.mm:
3275         (setWebPreferencesForTestOptions):
3276         * WebKitTestRunner/TestController.cpp:
3277         (WTR::TestController::resetPreferencesToConsistentValues):
3278         (WTR::updateTestOptionsFromTestHeader):
3279         * WebKitTestRunner/TestOptions.h:
3280         (WTR::TestOptions::hasSameInitializationOptions const):
3281
3282 2017-10-25  Robin Morisset  <rmorisset@apple.com>
3283
3284         Support the TailBench9000 benchmark in run-jsc-benchmarks
3285         https://bugs.webkit.org/show_bug.cgi?id=178451
3286
3287         Reviewed by Saam Barati.
3288
3289         * Scripts/run-jsc-benchmarks:
3290
3291 2017-10-25  Adrian Perez de Castro  <aperez@igalia.com>
3292
3293         [WPE] Remove GLib API functions which use Cairo
3294         https://bugs.webkit.org/show_bug.cgi?id=178205
3295
3296         Reviewed by Michael Catanzaro.
3297
3298         Add PLATFORM(GTK) guards for the API tests (or parts of them) which use cairo_surface_t (web
3299         page snapshots and favicons) which are not available in the WPE version of the GLib API.
3300
3301         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3302         (testNotInitialized):
3303         (testPrivateBrowsing):
3304         (testFaviconDatabase):
3305         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3306         (testFindControllerHide):
3307         (beforeAll):
3308         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3309         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
3310
3311 2017-10-25  Zan Dobersek  <zdobersek@igalia.com>
3312
3313         Make SERVICE_WORKER feature buildable on GTK, WPE
3314         https://bugs.webkit.org/show_bug.cgi?id=178574
3315
3316         Reviewed by Carlos Garcia Campos.
3317
3318         * Scripts/webkitperl/FeatureList.pm: Add the --service-worker option
3319         that enables the SERVICE_WORKER feature flag. For now it's enabled
3320         on Apple's Cocoa ports (even when build-webkit isn't used for those
3321         builds, the flag is enabled here for consistency).
3322
3323 2017-10-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3324
3325         Unreviewed, fix name of Perl LibXML package on Fedora
3326         https://bugs.webkit.org/show_bug.cgi?id=178206
3327         <rdar://problem/35028586>
3328
3329         * gtk/install-dependencies:
3330         * wpe/install-dependencies:
3331
3332 2017-10-24  Alex Christensen  <achristensen@webkit.org>
3333
3334         Selecting and right-clicking URL-like strings with IDNA-disallowed characters in host or authority causes rendering engine crash
3335         https://bugs.webkit.org/show_bug.cgi?id=174267
3336
3337         Reviewed by Tim Horton.
3338
3339         * TestWebKitAPI/Tests/WebKit/CanHandleRequest_Bundle.cpp:
3340         (TestWebKitAPI::runTest):
3341
3342 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
3343
3344         Web Inspector: Enable WebKit logging configuration and display
3345         https://bugs.webkit.org/show_bug.cgi?id=177027
3346         <rdar://problem/33964767>
3347
3348         Reviewed by Joseph Pecoraro.
3349
3350         Allow new 'dumpJSConsoleLogInStdErr' test header to redirect log console output to stderr.
3351
3352         * DumpRenderTree/TestOptions.h:
3353         * DumpRenderTree/TestOptions.mm:
3354         (TestOptions::TestOptions):
3355         * DumpRenderTree/mac/DumpRenderTree.mm:
3356         (runTest):
3357         * WebKitTestRunner/TestController.cpp:
3358         (WTR::updateTestOptionsFromTestHeader):
3359         (WTR::TestController::runTest):
3360         * WebKitTestRunner/TestOptions.h:
3361         (WTR::TestOptions::hasSameInitializationOptions const):
3362
3363 2017-10-24  Alex Christensen  <achristensen@webkit.org>
3364
3365         Apply custom header fields from WebsitePolicies to same-domain requests
3366         https://bugs.webkit.org/show_bug.cgi?id=178356
3367
3368         Reviewed by Brady Eidson.
3369
3370         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3371         (expectHeaders):
3372
3373 2017-10-24  Stephan Szabo  <stephan.szabo@sony.com>
3374
3375         [Win][JSCOnly] Make jsconly build testapi and dlls and copy dlls when running tests
3376         https://bugs.webkit.org/show_bug.cgi?id=177279
3377
3378         Reviewed by Yusuke Suzuki.
3379
3380         * Scripts/build-jsc:
3381         * Scripts/run-jsc-stress-tests:
3382
3383 2017-10-23  Lucas Forschler  <lforschler@apple.com>
3384
3385         <rdar://problem/35045445>
3386         Update README to reference WebKit build archives, instead of 'nightly'
3387
3388         Reviewed by Aakash Jain.
3389
3390         * WebKitArchiveSupport/README:
3391
3392 2017-10-21  Tim Horton  <timothy_horton@apple.com>
3393
3394         Turn on ccache for Mac cmake builds by default
3395         https://bugs.webkit.org/show_bug.cgi?id=177059
3396
3397         Reviewed by Sam Weinig.
3398
3399         * ccache/ccache-clang:
3400         * ccache/ccache-wrapper: Added.
3401         Add a pass-through ccache wrapper to be used with CMake, in addition
3402         to the existing faux-clang wrappers.
3403
3404         * Scripts/build-webkit:
3405         Add --use-ccache and --no-use-ccache option, which will define
3406         WK_USE_CCACHE to YES or NO, respectively, which the underlying
3407         build systems respect. We do not define WK_USE_CCACHE if the option
3408         is not specified, because the underlying build systems have different
3409         default values.
3410
3411 2017-10-20  Aakash Jain  <aakash_jain@apple.com>
3412
3413         Do not run binding tests on multiple EWSes
3414         https://bugs.webkit.org/show_bug.cgi?id=178599
3415
3416         Reviewed by Alexey Proskuryakov. 
3417
3418         Remove old code which runs bindings tests and ignore it's result. We now have
3419         a dedicated bindings test EWS.
3420
3421         * Scripts/webkitpy/tool/steps/runtests.py:
3422         (RunTests.run): Removed bindings tests code.
3423         * Scripts/webkitpy/tool/steps/runtests_unittest.py: Updated unit-tests.
3424         (RunTestsTest.test_webkit_run_unit_tests): Ditto.
3425         * Scripts/webkitpy/tool/steps/steps_unittest.py: Ditto.
3426         * Scripts/webkitpy/tool/commands/download_unittest.py: Ditto.
3427
3428 2017-10-20  Youenn Fablet  <youenn@apple.com>
3429
3430         WebsiteDataStoreCustomPaths.mm is failing after r223718
3431         https://bugs.webkit.org/show_bug.cgi?id=178596
3432
3433         Unreviewed.
3434
3435         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3436         (TEST): Making default web site data store creation expected at the end of the test.
3437         We should probably not need need to create it.
3438         This should be fixed as a follow-up.
3439
3440 2017-10-20  Antoine Quint  <graouts@apple.com>
3441
3442         [Web Animations] Provide basic timeline and animation interfaces
3443         https://bugs.webkit.org/show_bug.cgi?id=178526
3444
3445         Reviewed by Dean Jackson.
3446
3447         Remove the WEB_ANIMATIONS compile-time flag.
3448
3449         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3450
3451 2017-10-20  Tomas Popela  <tpopela@redhat.com>
3452
3453         Missing some perl packages in install-dependencies
3454         https://bugs.webkit.org/show_bug.cgi?id=178571
3455
3456         Reviewed by Žan Doberšek.
3457
3458         Install per-version and perl-Time-HiRes so we can use build-webkit
3459         script. Also add missing backlashes.
3460
3461         * wpe/install-dependencies:
3462
3463 2017-10-20  Commit Queue  <commit-queue@webkit.org>
3464
3465         Unreviewed, rolling out r222709 and r223572.
3466         https://bugs.webkit.org/show_bug.cgi?id=178587
3467
3468         Still getting mac-wk2 EWS bots stuck (Requested by ap on
3469         #webkit).
3470
3471         Reverted changesets:
3472
3473         "Log stack-trace for run-webkit-tests when interrupted"
3474         https://bugs.webkit.org/show_bug.cgi?id=176393
3475         https://trac.webkit.org/changeset/222709
3476
3477         "webkitpy: Hang when workers write to the same stack trace
3478         file"
3479         https://bugs.webkit.org/show_bug.cgi?id=178402
3480         https://trac.webkit.org/changeset/223572
3481
3482 2017-10-19  Nan Wang  <n_wang@apple.com>
3483
3484         AX: Provide a way for Accessibility to cache the selection while retrieving rects for speak selection
3485         https://bugs.webkit.org/show_bug.cgi?id=176247
3486         <rdar://problem/34217143>
3487
3488         Reviewed by Ryosuke Niwa.
3489
3490         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
3491         (TestWebKitAPI::TEST):
3492
3493 2017-10-19  Sam Weinig  <sam@webkit.org>
3494
3495         [Settings] Move global settings into their own file
3496         https://bugs.webkit.org/show_bug.cgi?id=178512
3497
3498         Reviewed by Darin Adler.
3499
3500         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3501         (TestWebKitAPI::TEST):
3502
3503 2017-10-19  Andy Estes  <aestes@apple.com>
3504
3505         [iOS] Conditionally rename DatabaseProcess to StorageProcess when building for iOS devices
3506         https://bugs.webkit.org/show_bug.cgi?id=178181
3507         <rdar://problem/33660282>
3508
3509         Reviewed by Dan Bernstein.
3510
3511         * WebKitTestRunner/TestController.cpp:
3512         (WTR::TestController::databaseProcessName):
3513
3514 2017-10-19  Saam Barati  <sbarati@apple.com>
3515
3516         Turn poly proto back on by default and remove the option
3517         https://bugs.webkit.org/show_bug.cgi?id=178525
3518
3519         Reviewed by Mark Lam.
3520
3521         * Scripts/run-jsc-stress-tests:
3522
3523 2017-10-18  Ryosuke Niwa  <rniwa@webkit.org>
3524
3525         Don't expose raw HTML in pasteboard to the web content
3526         https://bugs.webkit.org/show_bug.cgi?id=178422
3527
3528         Reviewed by Wenson Hsieh.
3529
3530         Added a test case for sanitizing web archive in the system pasteboard to strip privacy sensitive information
3531         such as local file paths and potentially harmful scripts like event handlers serialized by WebKit prior to r223462.
3532
3533         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:
3534         (PasteWebArchive.SanitizesHTML):
3535
3536 2017-10-18  Youenn Fablet  <youenn@apple.com>
3537
3538         TestController should clear all fetch caches when resetting its state
3539         https://bugs.webkit.org/show_bug.cgi?id=178486
3540
3541         Reviewed by Chris Dumez.
3542
3543         Adding clearDOMCaches test runner method.
3544         Using that method when resetting state.
3545
3546         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3547         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3548         (WTR::TestRunner::clearDOMCaches):
3549         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3550         * WebKitTestRunner/TestInvocation.cpp:
3551         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3552
3553 2017-10-18  Chelsea Pugh  <cpugh@apple.com>
3554
3555         [iOS] Use new class name from UIKit when checking UITextSuggestion type
3556         https://bugs.webkit.org/show_bug.cgi?id=178416
3557
3558         Reviewed by Tim Horton.
3559
3560         This updates our test using/mocking out UITextAutofillSuggestion instead of UIKeyboardLoginCredentialsSuggestion.
3561
3562         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3563         (-[UITextAutofillSuggestion initWithUsername:password:]): Copied from UIKit's implementation. This will serve as
3564         a mock of this method for builds not containingit.
3565         (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Ditto.
3566         (TestWebKitAPI::TEST): Use +[UITextAutofillSuggestion autofillSuggestionWithUsername:password:] inline instead of
3567         helper function for creating a new suggestion.
3568         (newUIKeyboardLoginCredentialsSuggestion): Deleted.
3569
3570         * TestWebKitAPI/ios/UIKitSPI.h:
3571
3572 2017-10-18  Fujii Hironori  <Hironori.Fujii@sony.com>
3573
3574         update-webkit-auxiliary-libs can't download WebKitAuxiliaryLibrary.zip due to 403 Forbidden
3575         https://bugs.webkit.org/show_bug.cgi?id=178381
3576
3577         Reviewed by Alexey Proskuryakov.
3578
3579         The web server developer.apple.com seems to reject HTTP requests
3580         without Accept header field.
3581
3582         * Scripts/update-webkit-dependency: Add 'Accept' header field to requests.
3583
3584 2017-10-18  Aakash Jain  <aakash_jain@apple.com>
3585
3586         webkitpy tests should have --json-output option
3587         https://bugs.webkit.org/show_bug.cgi?id=178481
3588
3589         Reviewed by Alexey Proskuryakov.
3590
3591         * Scripts/webkitpy/test/main.py:
3592         (Tester._parse_args): Added json-output argument.
3593         (Tester._run_tests): Write output to json file.
3594
3595 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3596
3597         Unreviewed, rolling out r223291.
3598
3599         See WebCore ChangeLog for more detail.
3600
3601         Reverted changeset:
3602
3603         "Remove Editor::simplifyMarkup"
3604         https://bugs.webkit.org/show_bug.cgi?id=178271
3605         https://trac.webkit.org/changeset/223291
3606
3607 2017-10-18  Chris Dumez  <cdumez@apple.com>
3608
3609         Add an efficient data structure for WebCore to query if there is a Service Worker registered for a given origin
3610         https://bugs.webkit.org/show_bug.cgi?id=177876
3611         <rdar://problem/34813129>
3612
3613         Reviewed by Ryosuke Niwa.
3614
3615         Clear service worker registrations between test runs to avoid flakiness.
3616
3617         * WebKitTestRunner/TestController.cpp:
3618         (WTR::TestController::resetStateToConsistentValues):
3619
3620 2017-10-18  Zan Dobersek  <zdobersek@igalia.com>
3621
3622         Remove remnants of OpenWebRTC
3623         https://bugs.webkit.org/show_bug.cgi?id=178437
3624
3625         Reviewed by Alejandro G. Castro.
3626
3627         Drop OpenWebRTC packages from the GTK's Jhbuild modules file. Relevant
3628         patches are also removed.
3629
3630         * gtk/jhbuild.modules:
3631         * gtk/patches/libnice-0001-TURN-allow-REALM-to-be-empty.patch: Removed.
3632         * gtk/patches/libnice-0001-nicesrc-spin-the-agent-mainloop-in-a-separate-thread.patch: Removed.
3633         * gtk/patches/rtspsrc-timeout-on-udpsrc-is-in-nanoseconds.patch: Removed.
3634         * gtk/patches/udpsrc-improve-timeouts.patch: Removed.
3635
3636 2017-10-17  Jonathan Bedard  <jbedard@apple.com>