Add simple line layout toggle to MiniBrowser
[WebKit-https.git] / Tools / ChangeLog
1 2017-01-24  Zalan Bujtas  <zalan@apple.com>
2
3         Add simple line layout toggle to MiniBrowser
4         https://bugs.webkit.org/show_bug.cgi?id=167405
5
6         Reviewed by Andreas Kling.
7
8         * MiniBrowser/mac/SettingsController.h:
9         * MiniBrowser/mac/SettingsController.m:
10         (-[SettingsController _populateMenu]):
11         (-[SettingsController validateMenuItem:]):
12         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
13         (-[SettingsController simpleLineLayoutEnabled]):
14         * MiniBrowser/mac/WK1BrowserWindowController.m:
15         (-[WK1BrowserWindowController didChangeSettings]):
16         * MiniBrowser/mac/WK2BrowserWindowController.m:
17         (-[WK2BrowserWindowController didChangeSettings]):
18
19 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
20
21         WKR does not include my nick when commit-queue lands my patch
22         https://bugs.webkit.org/show_bug.cgi?id=167388
23
24         Reviewed by Ryosuke Niwa.
25
26         * Scripts/webkitpy/tool/commands/newcommitbot.py:
27         (NewCommitBot._summarize_commit_log):
28         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
29         Perform nickname insertion before grabbing "Patch by" details.
30         This way we can include the nickname with the full name.
31
32 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
33
34         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
35         https://bugs.webkit.org/show_bug.cgi?id=167394
36
37         Reviewed by Ryosuke Niwa.
38
39         * Scripts/webkitperl/FeatureList.pm:
40         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
41
42 2017-01-24  Youenn Fablet  <youenn@apple.com>
43
44         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
45         https://bugs.webkit.org/show_bug.cgi?id=167353
46
47         Reviewed by Alex Christensen.
48
49         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
50         (CMakeGenerator.initialize_targets):
51
52 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
53
54         WKR should not confuse Miguel Gomez with Andres Gomez
55         https://bugs.webkit.org/show_bug.cgi?id=167389
56
57         Reviewed by Lucas Forschler.
58
59         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
60         "mAndres Gomez". Fix this.
61
62         * Scripts/webkitpy/tool/commands/newcommitbot.py:
63         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
64         space on each side of the email address, so expect both spaces to be there before
65         considering the email for replacement.
66         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
67
68 2017-01-24  Matt Rajca  <mrajca@apple.com>
69
70         Pass down website autoplay policies to media elements
71         https://bugs.webkit.org/show_bug.cgi?id=167355
72
73         Reviewed by Alex Christensen.
74
75         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
76         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
77         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
78         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
79         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
80         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
81         (TEST):
82
83 2017-01-24  Nan Wang  <n_wang@apple.com>
84
85         AX: Speak Selection does not work in an iframe
86         https://bugs.webkit.org/show_bug.cgi?id=166794
87         <rdar://problem/29913013>
88
89         Reviewed by Chris Fleizach.
90
91         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
92         (WTR::UIScriptController::retrieveSpeakSelectionContent):
93         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
94         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
95         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
96         (WTR::UIScriptController::retrieveSpeakSelectionContent):
97         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
98         * TestRunnerShared/UIScriptContext/UIScriptController.h:
99         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
100         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
101         (-[TestRunnerWKWebView dealloc]):
102         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
103         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
104         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
105         (WTR::UIScriptController::retrieveSpeakSelectionContent):
106         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
107
108 2017-01-24  Daniel Bates  <dabates@apple.com>
109
110         StringView.split() should use an iterator design pattern instead of allocating a Vector
111         https://bugs.webkit.org/show_bug.cgi?id=163225
112
113         Reviewed by Darin Adler.
114
115         Add unit tests for StringView.split().
116
117         * TestWebKitAPI/Tests/WTF/StringView.cpp:
118         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
119         used in the StringView.split() unit tests.
120         (TestWebKitAPI::stringViewFromUTF8): Ditto.
121         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
122         object to a Vector of String objects.
123         (TestWebKitAPI::TEST): Added the following tests:
124             - WTF.StringViewSplitEmptyAndNullStrings
125             - WTF.StringViewSplitBasic
126             - WTF.StringViewSplitWithConsecutiveSeparators
127
128 2017-01-23  Anders Carlsson  <andersca@apple.com>
129
130         The Score Esports crashes on launch
131         https://bugs.webkit.org/show_bug.cgi?id=167338
132         rdar://problem/29948645
133
134         Reviewed by Dan Bernstein.
135
136         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
137         (TestWebKitAPI::TEST):
138         Add a test.
139
140 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
141
142         [GTK] Add API to WebKitWebsiteDataManager to handle website data
143         https://bugs.webkit.org/show_bug.cgi?id=146589
144
145         Reviewed by Michael Catanzaro.
146
147         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
148         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
149
150         * MiniBrowser/gtk/BrowserWindow.c:
151         (webViewDecidePolicy):
152         (newTabCallback):
153         * MiniBrowser/gtk/main.c:
154         (createBrowserTab):
155         (aboutDataRequestFree):
156         (aboutDataRequestNew):
157         (aboutDataRequestForView):
158         (websiteDataRemovedCallback):
159         (websiteDataClearedCallback):
160         (aboutDataScriptMessageReceivedCallback):
161         (domainListFree):
162         (aboutDataFillTable):
163         (gotWebsiteDataCallback):
164         (aboutDataHandleRequest):
165         (aboutURISchemeRequestCallback):
166         (main):
167         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
168         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
169         (serverCallback):
170         (beforeAll):
171         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
172         (serverCallback):
173         (WebsiteDataTest::WebsiteDataTest):
174         (WebsiteDataTest::~WebsiteDataTest):
175         (WebsiteDataTest::fetch):
176         (WebsiteDataTest::remove):
177         (WebsiteDataTest::clear):
178         (testWebsiteDataConfiguration):
179         (testWebsiteDataCache):
180         (testWebsiteDataStorage):
181         (testWebsiteDataDatabases):
182         (testWebsiteDataAppcache):
183         (beforeAll):
184         (afterAll):
185
186 2017-01-23  Commit Queue  <commit-queue@webkit.org>
187
188         Unreviewed, rolling out r211062.
189         https://bugs.webkit.org/show_bug.cgi?id=167354
190
191         broke API tests (Requested by alexchristensen on #webkit).
192
193         Reverted changeset:
194
195         "Pass down website autoplay policies to media elements"
196         https://bugs.webkit.org/show_bug.cgi?id=167132
197         http://trac.webkit.org/changeset/211062
198
199 2017-01-23  Alex Christensen  <achristensen@webkit.org>
200
201         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
202         https://bugs.webkit.org/show_bug.cgi?id=167330
203
204         Reviewed by Tim Horton.
205
206         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
207         (TestWebKitAPI::TEST_F):
208
209 2017-01-23  Alex Christensen  <achristensen@webkit.org>
210
211         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
212         https://bugs.webkit.org/show_bug.cgi?id=167317
213
214         Reviewed by Sam Weinig.
215
216         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
217         (TestWebKitAPI::TEST_F):
218
219 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
220
221         svn-create-patch should emit properties when files are moved or copied
222         https://bugs.webkit.org/show_bug.cgi?id=167264
223
224         Reviewed by Daniel Bates.
225
226         * Scripts/svn-create-patch:
227         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
228
229 2017-01-23  Youenn Fablet  <youenn@apple.com>
230
231         [WebRTC] Filter libwebrtc link flags
232         https://bugs.webkit.org/show_bug.cgi?id=167287
233
234         Reviewed by Alex Christensen.
235
236         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
237         (CMakeGenerator._compute_link_flags):
238         (CMakeGenerator._compute_link_flags.keep_flag):
239         (CMakeGenerator._generate_compile_target_options):
240
241 2017-01-23  Youenn Fablet  <youennf@gmail.com>
242
243         [WebRTC] Make VP8 optional in libwebrtc
244         https://bugs.webkit.org/show_bug.cgi?id=167257
245
246         Reviewed by Darin Adler.
247
248         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
249         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
250
251 2017-01-23  Jer Noble  <jer.noble@apple.com>
252
253         Video details does not apear and missing scrubber in Control Center
254         https://bugs.webkit.org/show_bug.cgi?id=167233
255
256         Reviewed by Alex Christensen.
257
258         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
259         NowPlayingControlTests for iOS.
260
261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
262         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
263         (-[NowPlayingTestWebView setWindowVisible:]):
264         (TestWebKitAPI::TEST):
265         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
266         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
267         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
268         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
269         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
270         (SOFT_LINK_CLASS):
271         (-[TestMessageHandler addMessage:withHandler:]):
272         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
273         (__simulated_forceClickAssociatedEventsMask):
274         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
275         (-[TestWKWebViewHostWindow isKeyWindow]):
276         (-[TestWKWebViewHostWindow makeKeyWindow]):
277         (-[TestWKWebViewHostWindow resignKeyWindow]):
278         (-[TestWKWebView initWithFrame:]):
279         (-[TestWKWebView initWithFrame:configuration:]):
280         (-[TestWKWebView _setUpTestWindow:]):
281         (-[TestWKWebView performAfterReceivingMessage:action:]):
282         (-[TestWKWebView loadTestPageNamed:]):
283         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
284         (-[TestWKWebView stringByEvaluatingJavaScript:]):
285         (-[TestWKWebView waitForMessage:]):
286         (-[TestWKWebView performAfterLoading:]):
287         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
288         (-[TestWKWebView typeCharacter:]):
289
290 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
291
292         Unreviewed. Bring back gtk-doc error messages after r209981.
293
294         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
295         impossible to know what's wrong.
296
297         * gtk/gtkdoc.py:
298         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
299
300 2017-01-20  Youenn Fablet  <youennf@gmail.com>
301
302         [WebRTC] Update build system to make G711 optional in libwebrtc
303         https://bugs.webkit.org/show_bug.cgi?id=167256
304
305         Reviewed by Alex Christensen.
306
307         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
308         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
309
310 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
311
312         Cleanup RuntimeEnabledFeatures
313         https://bugs.webkit.org/show_bug.cgi?id=167228
314
315         Reviewed by Simon Fraser.
316
317         * DumpRenderTree/mac/DumpRenderTree.mm:
318         (enableExperimentalFeatures):
319         (resetWebPreferencesToConsistentValues):
320         (setWebPreferencesForTestOptions):
321         (resetWebViewToConsistentStateBeforeTesting):
322         * DumpRenderTree/win/DumpRenderTree.cpp:
323         (enableExperimentalFeatures):
324         (resetWebPreferencesToConsistentValues):
325         More closely match WebKitTestRunner initialization of preferences
326         for experimental features.
327
328 2017-01-20  Alex Christensen  <achristensen@webkit.org>
329
330         Build Fix for Windows DumpRenderTree after r210976
331         https://bugs.webkit.org/show_bug.cgi?id=167115
332
333         * DumpRenderTree/win/DumpRenderTree.cpp:
334         (resetWebPreferencesToConsistentValues):
335
336 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
337
338         Remove outdated ENABLE(CSP_NEXT) build flag
339         https://bugs.webkit.org/show_bug.cgi?id=167252
340
341         Reviewed by Brent Fulgham.
342
343         * Scripts/webkitperl/FeatureList.pm:
344         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
345
346 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
347
348         Build Fix for Windows DumpRenderTree after r210976
349
350         * DumpRenderTree/win/DumpRenderTree.cpp:
351         (resetWebPreferencesToConsistentValues):
352
353 2017-01-20  Antoine Quint  <graouts@apple.com>
354
355         Web Animations should be off by default and enabled as an experimental feature
356         https://bugs.webkit.org/show_bug.cgi?id=167115
357         <rdar://problem/30048963>
358
359         Reviewed by Joseph Pecoraro.
360
361         Turn Web Animations on in DRT.
362
363         * DumpRenderTree/mac/DumpRenderTree.mm:
364         (resetWebPreferencesToConsistentValues):
365         * DumpRenderTree/win/DumpRenderTree.cpp:
366         (resetWebPreferencesToConsistentValues):
367
368 2017-01-20  Youenn Fablet  <youenn@apple.com>
369
370         [WebRTC] Add libwebrtc build infrastructure
371         https://bugs.webkit.org/show_bug.cgi?id=167207
372
373         Reviewed by Alex Christensen.
374
375         Adding a script doing the libwebrtc project json to CMake file conversion.
376
377         * Scripts/generate-libwebrtc-cmake: Added.
378         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
379         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
380
381 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
382
383         Mini Browser: Show tooltip for Experimental Features
384         https://bugs.webkit.org/show_bug.cgi?id=167225
385
386         Reviewed by Alex Christensen.
387
388         * MiniBrowser/mac/SettingsController.m:
389         (-[SettingsController _populateMenu]):
390         Include the full details string as a tooltip.
391
392 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
393
394         [Win] Test output results should not be written twice.
395         https://bugs.webkit.org/show_bug.cgi?id=167197
396
397         Reviewed by Brent Fulgham.
398
399         Prevent test output from being written twice by returning early from
400         the dump() function, if it already has been called.
401         This patch also adds a missing newline to a test output line. 
402         
403         * DumpRenderTree/win/DumpRenderTree.cpp:
404         (dump):
405
406 2017-01-20  Antoine Quint  <graouts@apple.com>
407
408         [Modern Media Controls] Turn modern media controls on by default
409         https://bugs.webkit.org/show_bug.cgi?id=165668
410
411         Reviewed by Dean Jackson.
412
413         Enabled modern media controls by default in test runners.
414
415         * DumpRenderTree/TestOptions.h:
416         * WebKitTestRunner/TestOptions.h:
417
418 2017-01-19  Chris Dumez  <cdumez@apple.com>
419
420         iterable<> should be enabled on WK1
421         https://bugs.webkit.org/show_bug.cgi?id=167221
422         <rdar://problem/30108531>
423
424         Reviewed by Youenn Fablet.
425
426         * DumpRenderTree/mac/DumpRenderTree.mm:
427         (resetWebPreferencesToConsistentValues):
428         * DumpRenderTree/win/DumpRenderTree.cpp:
429         (resetWebPreferencesToConsistentValues):
430         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
431         (WTR::InjectedBundle::beginTesting):
432         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
433         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
434         * WebKitTestRunner/InjectedBundle/TestRunner.h:
435
436 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
437
438         Ensure status server logs go to log file
439         https://bugs.webkit.org/show_bug.cgi?id=167210
440
441         Reviewed by Alexey Proskuryakov.
442
443         * Scripts/webkitpy/common/net/statusserver.py:
444         (StatusServer.next_work_item): Change log level from debug to info in
445         order to facilitate deubgging issues.
446         (StatusServer.update_work_items): Same.
447
448 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
449
450         Additional selection tests and interpolation fix
451         https://bugs.webkit.org/show_bug.cgi?id=167171
452
453         Reviewed by Simon Fraser.
454
455         We weren't adding the final event when interpolating event streams.
456
457         * WebKitTestRunner/ios/HIDEventGenerator.mm:
458         (-[HIDEventGenerator interpolatedEvents:]):
459
460 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
461
462         [Cocoa] Variation fonts are erroneously disabled on iOS
463         https://bugs.webkit.org/show_bug.cgi?id=167172
464
465         Reviewed by Simon Fraser.
466
467         OpenSource builders don't seem to understand sdk=embedded*.
468
469         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
470
471 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
472
473         Unreviewed. Fix GTK+ unit tests failing since r210531.
474
475         Avoid using paths to files that don't actually exist.
476
477         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
478         (testWebKitConsoleMessageNetworkError):
479         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
480         (testContextMenuDefaultMenu):
481         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
482         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
483         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
484
485 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
486
487         [GTK] Provide API to set proxy settings
488         https://bugs.webkit.org/show_bug.cgi?id=128674
489
490         Reviewed by Michael Catanzaro.
491
492         Add tests for new proxy settings API.
493
494         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
495         (serverCallback):
496         (ProxyTest::ProxyTest):
497         (ProxyTest::~ProxyTest):
498         (ProxyTest::loadURIAndGetMainResourceData):
499         (ProxyTest::proxyServerPortAsString):
500         (testWebContextProxySettings):
501         (beforeAll):
502
503 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
504
505         Add back my old email address so old commits will still match it.
506
507         * Scripts/webkitpy/common/config/contributors.json:
508
509 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
510
511         Remove my old email address from contributors.json and watchlist.
512
513         * Scripts/validate-committer-lists:
514         (CommitterListFromGit): Change the mapping to the correct email.
515         * Scripts/webkitpy/common/config/contributors.json:
516         * Scripts/webkitpy/common/config/watchlist:
517
518 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
519
520         Unreviewed, rolling out r210848.
521
522         This change introduced media-related LayoutTest failures and
523         crashes on macOS.
524
525         Reverted changeset:
526
527         "[Modern Media Controls] Turn modern media controls on by
528         default"
529         https://bugs.webkit.org/show_bug.cgi?id=165668
530         http://trac.webkit.org/changeset/210848
531
532 2017-01-18  Andreas Kling  <akling@apple.com>
533
534         Document::securityOrigin() should return a reference.
535         <https://webkit.org/b/167124>
536
537         Reviewed by Sam Weinig.
538
539         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
540         (TestWebKitAPI::TEST_F):
541
542 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
543
544         [Win] Clipboard tests are flaky.
545         https://bugs.webkit.org/show_bug.cgi?id=167088
546
547         Reviewed by Brent Fulgham.
548
549         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
550         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
551
552         * DumpRenderTree/win/DumpRenderTree.cpp:
553         (main):
554
555 2017-01-18  Antoine Quint  <graouts@apple.com>
556
557         [Modern Media Controls] Turn modern media controls on by default
558         https://bugs.webkit.org/show_bug.cgi?id=165668
559
560         Reviewed by Dean Jackson.
561
562         Enabled modern media controls by default in test runners. 
563
564         * DumpRenderTree/TestOptions.h:
565         * WebKitTestRunner/TestOptions.h:
566
567 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
568
569         Unreviewed, rolling out r210834
570         https://bugs.webkit.org/show_bug.cgi?id=165668
571
572         It introduced dozens of test timeouts.
573
574         Reverted changeset:
575         "[Modern Media Controls] Turn modern media controls on by default"
576         https://bugs.webkit.org/show_bug.cgi?id=165668
577         http://trac.webkit.org/changeset/210834
578
579 2017-01-17  Antoine Quint  <graouts@apple.com>
580
581         [Modern Media Controls] Turn modern media controls on by default
582         https://bugs.webkit.org/show_bug.cgi?id=165668
583
584         Reviewed by Dean Jackson.
585
586         Enabled modern media controls by default in test runners. 
587
588         * DumpRenderTree/TestOptions.h:
589         * WebKitTestRunner/TestOptions.h:
590
591 2017-01-17  Chris Dumez  <cdumez@apple.com>
592
593         Document title changed twice when setting document.title
594         https://bugs.webkit.org/show_bug.cgi?id=167065
595
596         Reviewed by Darin Adler.
597
598         Add WebKit2GTK API test that was written by Michael Catanzaro.
599
600         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
601         (testWebViewTitleChange):
602         (beforeAll):
603
604 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
605
606         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
607         https://bugs.webkit.org/show_bug.cgi?id=116551
608         <rdar://problem/13949830>
609
610         Reviewed by Alex Christensen.
611
612         * Scripts/webkitperl/FeatureList.pm:
613         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
614         that is part of the existing WEB_TIMING feature.
615
616         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
617
618 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
619
620         'webkit-patch post' no longer works with moved/copied files
621         https://bugs.webkit.org/show_bug.cgi?id=166914
622         <rdar://problem/29979707>
623
624         Reviewed by Daniel Bates.
625
626         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
627         file outputs only the "Index:" line with an empty body.  This workaround
628         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
629         public email list tracking this bug is below.
630         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
631         
632
633         * Scripts/svn-create-patch:
634         (generateDiff): Ignore an "Index:" line with an empty body.
635
636 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
637
638         Remove the REQUEST_ANIMATION_FRAME flag
639         https://bugs.webkit.org/show_bug.cgi?id=156980
640         <rdar://problem/25906849>
641
642         Reviewed by Simon Fraser.
643
644         * Scripts/webkitperl/FeatureList.pm:
645         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
646
647 2017-01-15  Sam Weinig  <sam@webkit.org>
648
649         Add the ability to use numbers in makeString()
650         https://bugs.webkit.org/show_bug.cgi?id=167087
651
652         Reviewed by Darin Adler.
653
654         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
655         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
656         Add tests for StringConcatenate, focusing on new numeric additions.
657
658 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
659
660         Unreviewed, remove stale comment.
661
662         This test was fixed by r163173.
663
664         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
665
666 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
667
668         Annotate large string tests with largeHeap
669         https://bugs.webkit.org/show_bug.cgi?id=167054
670
671         Reviewed by Filip Pizlo.
672
673         * Scripts/run-javascriptcore-tests:
674         * Scripts/run-jsc-stress-tests:
675
676 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
677
678         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
679         https://bugs.webkit.org/show_bug.cgi?id=167043
680
681         Reviewed by Darin Adler.
682
683         * Scripts/webkitperl/FeatureList.pm:
684
685 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
686
687         Remove ENABLE(DETAILS_ELEMENT) guards
688         https://bugs.webkit.org/show_bug.cgi?id=167042
689
690         Reviewed by Alex Christensen.
691
692         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
693
694 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
695
696         26 MotionMark performance tests failing
697         https://bugs.webkit.org/show_bug.cgi?id=166854
698
699         Reviewed by Ryosuke Niwa.
700
701         Unrelated change. This is the last place that we need to rename Animometer
702         to MotionMark.
703
704         * Scripts/webkitpy/common/config/watchlist:
705
706 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
707
708         run-jsc-benchmarks' echo should have -e option
709         https://bugs.webkit.org/show_bug.cgi?id=167009
710
711         Reviewed by Sam Weinig.
712
713         echo requires `-e` option to use escape sequence.
714         Without it, in some environment (in my Fedora 25), the escape sequence is not
715         recognized and just dumped as `\c` etc.
716
717         * Scripts/run-jsc-benchmarks:
718
719 2017-01-12  Chris Dumez  <cdumez@apple.com>
720
721         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
722         https://bugs.webkit.org/show_bug.cgi?id=166995
723
724         Reviewed by Jer Noble.
725
726         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
727         as some people are having trouble building without it.
728
729         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
730
731 2017-01-12  Sam Weinig  <sam@webkit.org>
732
733         Add the ability to filter the set of bindings tests you want to run
734         https://bugs.webkit.org/show_bug.cgi?id=166977
735
736         Reviewed by Tim Horton.
737
738         Allows doing things like:
739             run-bindings-tests TestObj* TestCEReactions*
740         
741         to run only those tests that match the patterns.
742
743         * Scripts/run-bindings-tests:
744         (main):
745         Switch to using optparse and pass the remaining args as the filters.
746
747         * Scripts/webkitpy/bindings/main.py:
748         (BindingsTests.__init__):
749         Store the pattens.
750
751         (BindingsTests.test_matches_patterns):
752         Add helper predicate to determine if a test should be run. When no
753         patterns are present, all tests should run.
754
755         (BindingsTests.run_tests):
756         Filter tests using the passed in patterns.
757
758 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
759
760         Followup fix after r210503.
761         https://bugs.webkit.org/show_bug.cgi?id=166887
762
763         Reviewed by Alex Christensen.
764
765         After <http://trac.webkit.org/changeset/210503>, test results are written to a
766         duplicated file handle on Windows. This patch fixes the remaining call sites.
767
768         * DumpRenderTree/PixelDumpSupport.cpp:
769         * DumpRenderTree/TestRunner.cpp:
770         (TestRunner::waitToDumpWatchdogTimerFired):
771         * DumpRenderTree/TestRunner.h:
772         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
773         * DumpRenderTree/win/DumpRenderTree.cpp:
774         * DumpRenderTree/win/DumpRenderTreeWin.h:
775         * DumpRenderTree/win/TestRunnerWin.cpp:
776         (TestRunner::setSpellCheckerLoggingEnabled):
777
778 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
779
780         Add committer status for Megan
781         https://bugs.webkit.org/show_bug.cgi?id=166954
782
783         Reviewed by Tim Horton.
784
785         Add committer status for Megan Gardner
786
787         * Scripts/webkitpy/common/config/contributors.json:
788
789 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
790
791         Unreviewed test fix after r210599.
792
793         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
794         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
795
796 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
797
798         Unreviewed build fix after r210599.
799
800         Add missing files.
801
802         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
803         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
804
805 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
806
807         File scheme should not allow access of a resource on a different volume.
808         https://bugs.webkit.org/show_bug.cgi?id=158552
809         <rdar://problem/15307582>
810
811         Reviewed by Alex Christensen.
812
813         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
814         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
815         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
816
817 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
818
819         Unreviewed, rolling out r210571.
820
821         This change broke the 32-bit macOS build and caused LayoutTest
822         failures.
823
824         Reverted changeset:
825
826         "File scheme should not allow access of a resource on a
827         different volume."
828         https://bugs.webkit.org/show_bug.cgi?id=158552
829         http://trac.webkit.org/changeset/210571
830
831 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
832
833         [GTK] install-dependencies script misses gdb
834         https://bugs.webkit.org/show_bug.cgi?id=166917
835
836         Reviewed by Michael Catanzaro.
837
838         gdb is needed for generating the crash logs.
839
840         * gtk/install-dependencies:
841
842 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
843
844         [GTK] No way for applications to set notification permissions without waiting for permission request
845         https://bugs.webkit.org/show_bug.cgi?id=163366
846
847         Reviewed by Carlos Garcia Campos.
848
849         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
850         (testWebViewNotification):
851         (setInitialNotificationPermissionsAllowedCallback):
852         (setInitialNotificationPermissionsDisallowedCallback):
853         (testWebViewNotificationInitialPermissionAllowed):
854         (testWebViewNotificationInitialPermissionDisallowed):
855         (beforeAll):
856         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
857         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
858         (WebViewTest::WebViewTest):
859         (WebViewTest::initializeWebView):
860         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
861
862 2017-01-10  Tim Horton  <timothy_horton@apple.com>
863
864         MobileMiniBrowser tests don't work by default
865         https://bugs.webkit.org/show_bug.cgi?id=166910
866
867         Reviewed by Alex Christensen.
868
869         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
870         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
871
872 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
873
874         File scheme should not allow access of a resource on a different volume.
875         https://bugs.webkit.org/show_bug.cgi?id=158552
876         <rdar://problem/15307582>
877
878         Reviewed by Alex Christensen.
879
880         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
881         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
882         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
883
884 2017-01-10  Mark Lam  <mark.lam@apple.com>
885
886         Reverting run-jsc-stress-tests' $buildType to use string values.
887         https://bugs.webkit.org/show_bug.cgi?id=166912
888
889         Rubber stamped by Filip Pizlo.
890
891         This is so that we can test for it in the tests e.g.
892         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
893
894         * Scripts/run-jsc-stress-tests:
895
896 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
897
898         Temporarily add back the file removed in r210463 to unbreak internal bots.
899
900         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
901
902 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
903
904         svn-apply failed to apply a patch (deleting file with svn property)
905         https://bugs.webkit.org/show_bug.cgi?id=165953
906
907         Reviewed by Daniel Bates.
908
909         * Scripts/VCSUtils.pm:
910         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
911         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
912
913 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
914
915         Update flakiness dashboard configuration.
916         https://bugs.webkit.org/show_bug.cgi?id=166869
917
918         Reviewed by Alexey Proskuryakov.
919
920         * TestResultServer/static-dashboards/builders.jsonp:
921         * TestResultServer/static-dashboards/flakiness_dashboard.js:
922
923 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
924
925         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
926         https://bugs.webkit.org/show_bug.cgi?id=165232
927
928         Unreviewed follow-up patch after r210539 and r210523.
929
930         Instead of using that environment variable, the argument
931         --display-server=xorg should be passed now.
932
933         The GTK+ performance bot was the only bot using this, and is
934         already passing --display-server=xorg after r210539.
935
936         * Scripts/webkitpy/port/gtk.py:
937         (GtkPort._driver_class):
938
939 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
940
941         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
942         https://bugs.webkit.org/show_bug.cgi?id=166872
943
944         Reviewed by Michael Catanzaro.
945
946         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
947         Define the required "--display-server=driver" in the bot additionalArguments config entry.
948         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
949         The step RunWebKitTests already has support for it.
950
951         * BuildSlaveSupport/build.webkit.org-config/config.json:
952         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
953         (RunGtkAPITests.start):
954         (RunAndUploadPerfTests.start):
955         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
956
957 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
958
959         Unreviewed, rolling out r210531.
960
961         This change broke the 32-bit macOS build and caused LayoutTest
962         failures.
963
964         Reverted changeset:
965
966         "File scheme should not allow access of a resource on a
967         different volume."
968         https://bugs.webkit.org/show_bug.cgi?id=158552
969         http://trac.webkit.org/changeset/210531
970
971 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
972
973         File scheme should not allow access of a resource on a different volume.
974         https://bugs.webkit.org/show_bug.cgi?id=158552
975         <rdar://problem/15307582>
976
977         Reviewed by Alex Christensen.
978
979         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
980         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
981         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
982
983 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
984
985         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
986         https://bugs.webkit.org/show_bug.cgi?id=165232
987
988         Reviewed by Michael Catanzaro.
989
990         Add a new WaylandDriver to run the tests in the user current wayland session.
991
992         Also merge all the configuration options for selecting the display server inside one
993         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
994
995         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
996
997         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
998         (TestRunner._create_driver):
999         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1000         (parse_args):
1001         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1002         (PerfTestsRunner._parse_args):
1003         * Scripts/webkitpy/port/gtk.py:
1004         (GtkPort.__init__):
1005         (GtkPort._driver_class):
1006         (GtkPort._search_paths):
1007         * Scripts/webkitpy/port/waylanddriver.py: Added.
1008         (WaylandDriver):
1009         (WaylandDriver.check_driver):
1010         (WaylandDriver._setup_environ_for_test):
1011         (WaylandDriver._start):
1012
1013 2017-01-09  Andy Estes  <aestes@apple.com>
1014
1015         [QuickLook] Add a layout test for webkit.org/b/135651
1016         https://bugs.webkit.org/show_bug.cgi?id=166855
1017
1018         Reviewed by Andreas Kling.
1019
1020         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1021         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
1022         errors with code WebKitErrorCannotShowURL.
1023         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1024         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
1025         not specific to WebKit2 error codes.
1026
1027 2017-01-09  Antoine Quint  <graouts@apple.com>
1028
1029         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
1030         https://bugs.webkit.org/show_bug.cgi?id=166837
1031
1032         Reviewed by Alex Christensen.
1033
1034         We now correctly handle the --absolutePath argument in DumpRenderTree and use
1035         the provided value when trying to determine the path to the test file. Failing
1036         that, we use the computed URL or the raw path provided to cover all cases.
1037         
1038         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
1039         by applying this patch and seeing the number test failures dramatically reduced
1040         with WK1 due to the option to turn modern media controls off for older media controls
1041         tests.
1042
1043         * DumpRenderTree/DumpRenderTree.h:
1044         * DumpRenderTree/DumpRenderTreeCommon.cpp:
1045         (parseInputLine):
1046         * DumpRenderTree/TestOptions.h:
1047         * DumpRenderTree/TestOptions.mm:
1048         (TestOptions::TestOptions):
1049         * DumpRenderTree/mac/DumpRenderTree.mm:
1050         (runTest):
1051
1052 2017-01-09  Milan Crha  <mcrha@redhat.com>
1053
1054         prepare-ChangeLog: Correct help string for --style option
1055         https://bugs.webkit.org/show_bug.cgi?id=166725
1056
1057         Reviewed by Alexey Proskuryakov.
1058
1059         * Scripts/prepare-ChangeLog:
1060         (main):
1061
1062 2017-01-09  Lucas Forschler  <lforschler@apple.com>
1063
1064         https://bugs.webkit.org/show_bug.cgi?id=166839
1065         Add php7 support for macOS.
1066         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
1067
1068         Reviewed by Alexey Proskuryakov.
1069
1070         * Scripts/webkitpy/port/base.py:
1071         (Port._is_darwin_php_version_7):
1072         (Port._debian_php_version):
1073         (Port):
1074         (Port._darwin_php_version):
1075         (Port._apache_config_file_name_for_platform):
1076
1077 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1078
1079         [GTK] Should support key and code properties on keyboard events
1080         https://bugs.webkit.org/show_bug.cgi?id=166759
1081
1082         Reviewed by Carlos Garcia Campos.
1083
1084         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1085         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
1086         on tests.
1087
1088 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
1089
1090         [Win] Some tests are flaky because certain DLLs are writing to stdout.
1091         https://bugs.webkit.org/show_bug.cgi?id=166760
1092
1093         Reviewed by Darin Adler.
1094
1095         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
1096         We can work around that by duplicating and redirecting stdout.
1097
1098         * DumpRenderTree/PixelDumpSupport.cpp:
1099         (dumpWebViewAsPixelsAndCompareWithExpected):
1100         (printPNG):
1101         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1102         (logEventProc):
1103         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1104         (DRTDesktopNotificationPresenter::showDesktopNotification):
1105         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
1106         (DRTDesktopNotificationPresenter::requestNotificationPermission):
1107         * DumpRenderTree/win/DumpRenderTree.cpp:
1108         (dumpFrameScrollPosition):
1109         (dumpHistoryItem):
1110         (dumpBackForwardList):
1111         (dump):
1112         (runTest):
1113         (main):
1114         * DumpRenderTree/win/DumpRenderTreeWin.h:
1115         * DumpRenderTree/win/EditingDelegate.cpp:
1116         (EditingDelegate::shouldBeginEditingInDOMRange):
1117         (EditingDelegate::shouldEndEditingInDOMRange):
1118         (EditingDelegate::shouldInsertNode):
1119         (EditingDelegate::shouldInsertText):
1120         (EditingDelegate::shouldDeleteDOMRange):
1121         (EditingDelegate::shouldChangeSelectedDOMRange):
1122         (EditingDelegate::shouldApplyStyle):
1123         (EditingDelegate::shouldChangeTypingStyle):
1124         (EditingDelegate::doPlatformCommand):
1125         (EditingDelegate::webViewDidBeginEditing):
1126         (EditingDelegate::webViewDidChange):
1127         (EditingDelegate::webViewDidEndEditing):
1128         (EditingDelegate::webViewDidChangeTypingStyle):
1129         (EditingDelegate::webViewDidChangeSelection):
1130         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1131         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1132         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
1133         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
1134         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1135         (FrameLoadDelegate::didCommitLoadForFrame):
1136         (FrameLoadDelegate::didReceiveTitle):
1137         (FrameLoadDelegate::didFinishLoadForFrame):
1138         (FrameLoadDelegate::didFailLoadWithError):
1139         (FrameLoadDelegate::willPerformClientRedirectToURL):
1140         (FrameLoadDelegate::didCancelClientRedirectForFrame):
1141         (FrameLoadDelegate::windowScriptObjectAvailable):
1142         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1143         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1144         (FrameLoadDelegate::didDisplayInsecureContent):
1145         (FrameLoadDelegate::didRunInsecureContent):
1146         (FrameLoadDelegate::webViewProgressFinishedNotification):
1147         * DumpRenderTree/win/HistoryDelegate.cpp:
1148         (HistoryDelegate::didNavigateWithNavigationData):
1149         (HistoryDelegate::didPerformClientRedirectFromURL):
1150         (HistoryDelegate::didPerformServerRedirectFromURL):
1151         (HistoryDelegate::updateHistoryTitle):
1152         (HistoryDelegate::populateVisitedLinksForWebView):
1153         * DumpRenderTree/win/PolicyDelegate.cpp:
1154         (PolicyDelegate::decidePolicyForNavigationAction):
1155         (PolicyDelegate::unableToImplementPolicyWithError):
1156         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1157         (ResourceLoadDelegate::willSendRequest):
1158         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1159         (ResourceLoadDelegate::didReceiveResponse):
1160         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
1161         (ResourceLoadDelegate::didFailLoadingWithError):
1162         * DumpRenderTree/win/TestRunnerWin.cpp:
1163         (TestRunner::addDisallowedURL):
1164         (TestRunner::originsWithApplicationCache):
1165         (TestRunner::setStorageDatabaseIdleInterval):
1166         (TestRunner::closeIdleLocalStorageDatabases):
1167         (TestRunner::copyDecodedHostName):
1168         (TestRunner::copyEncodedHostName):
1169         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1170         (TestRunner::isGeolocationProviderActive):
1171         (TestRunner::pathToLocalResource):
1172         (TestRunner::setMockDeviceOrientation):
1173         (TestRunner::setMockGeolocationPosition):
1174         (TestRunner::setMockGeolocationPositionUnavailableError):
1175         (TestRunner::setSpatialNavigationEnabled):
1176         (TestRunner::setAutomaticLinkDetectionEnabled):
1177         (TestRunner::isCommandEnabled):
1178         (TestRunner::authenticateSession):
1179         (TestRunner::addChromeInputField):
1180         (TestRunner::removeChromeInputField):
1181         (TestRunner::focusWebView):
1182         (TestRunner::grantWebNotificationPermission):
1183         (TestRunner::denyWebNotificationPermission):
1184         (TestRunner::removeAllWebNotificationPermissions):
1185         (TestRunner::simulateWebNotificationClick):
1186         (TestRunner::imageCountInGeneralPasteboard):
1187         * DumpRenderTree/win/UIDelegate.cpp:
1188         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1189         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1190         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1191         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
1192         (UIDelegate::webViewAddMessageToConsole):
1193         (UIDelegate::exceededDatabaseQuota):
1194         (UIDelegate::setStatusText):
1195         (UIDelegate::didPressMissingPluginButton):
1196
1197 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1198
1199         Add a setting to create editable MiniBrowser windows by default
1200         https://bugs.webkit.org/show_bug.cgi?id=166806
1201
1202         Reviewed by Beth Dakin.
1203
1204         * MiniBrowser/mac/AppDelegate.m:
1205         (-[BrowserAppDelegate createBrowserWindowController:]):
1206         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1207         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1208         * MiniBrowser/mac/SettingsController.h:
1209         * MiniBrowser/mac/SettingsController.m:
1210         (-[SettingsController _populateMenu]):
1211         (-[SettingsController validateMenuItem:]):
1212         (-[SettingsController toggleCreateEditorByDefault:]):
1213         (-[SettingsController createEditorByDefault]):
1214         Add a setting and update the key equivalents accordingly.
1215         Also make sure to make the right kind of window on launch.
1216
1217 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1218
1219         Fix the 32-bit build.
1220
1221         * MiniBrowser/mac/BrowserWindowController.h:
1222         * MiniBrowser/mac/BrowserWindowController.m:
1223
1224 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1225
1226         Fix the 32-bit build.
1227
1228         * MiniBrowser/mac/BrowserWindowController.m:
1229
1230 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1231
1232         Make it possible to drop HTML files on the MiniBrowser icon
1233         https://bugs.webkit.org/show_bug.cgi?id=166802
1234
1235         Reviewed by Simon Fraser.
1236
1237         * MiniBrowser/mac/AppDelegate.m:
1238         (-[BrowserAppDelegate application:openFile:]):
1239         * MiniBrowser/mac/Info.plist:
1240         If you're using an editable window, the usual trick of dropping on the
1241         window doesn't work anymore (it makes an <attachment> instead).
1242
1243 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1244
1245         MiniBrowser window gets smaller each time it is instantiated
1246         https://bugs.webkit.org/show_bug.cgi?id=166807
1247
1248         Reviewed by Andy Estes.
1249
1250         * MiniBrowser/mac/BrowserWindowController.m:
1251         (-[BrowserWindowController windowDidLoad]):
1252         * MiniBrowser/mac/BrowserWindow.xib:
1253         Turn on full-window content view support with IB, instead of waiting
1254         until after the views have been loaded. This seems to resolve the
1255         longstanding ever-shrinking-window problem.
1256
1257 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1258
1259         Add indent/outdent items to MiniBrowser's new format menu
1260         https://bugs.webkit.org/show_bug.cgi?id=166805
1261
1262         Reviewed by Dan Bernstein.
1263
1264         * MiniBrowser/mac/MainMenu.xib:
1265
1266 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1267
1268         Add a stock Format menu to MiniBrowser
1269         https://bugs.webkit.org/show_bug.cgi?id=166804
1270
1271         Reviewed by Andy Estes.
1272
1273         * MiniBrowser/mac/MainMenu.xib:
1274         Many of the features automatically work with editable web views.
1275         However, this seems to expose a bug where none of the font-related features
1276         (Cmd-B, for example) work until the first time the font panel is shown,
1277         per process, which will need to be investigated separately.
1278
1279 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1280
1281         Remove unused applicationWillTerminate methods from MiniBrowser
1282         https://bugs.webkit.org/show_bug.cgi?id=166803
1283
1284         Reviewed by Andy Estes.
1285
1286         * MiniBrowser/mac/AppDelegate.m:
1287         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
1288         * MiniBrowser/mac/BrowserWindowController.h:
1289         * MiniBrowser/mac/BrowserWindowController.m:
1290         (-[BrowserWindowController applicationTerminating]): Deleted.
1291         * MiniBrowser/mac/WK1BrowserWindowController.m:
1292         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
1293         * MiniBrowser/mac/WK2BrowserWindowController.m:
1294         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
1295
1296 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1297
1298         Add the ability to create empty contentEditable windows in MiniBrowser
1299         https://bugs.webkit.org/show_bug.cgi?id=166801
1300
1301         Reviewed by Wenson Hsieh.
1302
1303         * MiniBrowser/mac/AppDelegate.h:
1304         * MiniBrowser/mac/AppDelegate.m:
1305         (-[BrowserAppDelegate createBrowserWindowController:]):
1306         (-[BrowserAppDelegate newWindow:]):
1307         (-[BrowserAppDelegate newEditorWindow:]):
1308         (-[BrowserAppDelegate openDocument:]):
1309         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1310         * MiniBrowser/mac/BrowserWindowController.h:
1311         * MiniBrowser/mac/BrowserWindowController.m:
1312         (-[BrowserWindowController loadHTMLString:]):
1313         (-[BrowserWindowController toggleEditable:]):
1314         * MiniBrowser/mac/MainMenu.xib:
1315         * MiniBrowser/mac/WK1BrowserWindowController.m:
1316         (-[WK1BrowserWindowController awakeFromNib]):
1317         (-[WK1BrowserWindowController loadHTMLString:]):
1318         (-[WK1BrowserWindowController validateMenuItem:]):
1319         (-[WK1BrowserWindowController setEditable:]):
1320         (-[WK1BrowserWindowController updateTitle:]):
1321         * MiniBrowser/mac/WK2BrowserWindowController.m:
1322         (-[WK2BrowserWindowController awakeFromNib]):
1323         (-[WK2BrowserWindowController validateMenuItem:]):
1324         (-[WK2BrowserWindowController setEditable:]):
1325         (-[WK2BrowserWindowController updateTitle:]):
1326         (-[WK2BrowserWindowController loadHTMLString:]):
1327         Merge more functionality from WebEditingTester.
1328         Add two menu items for creating empty editable WebKit1/2 windows.
1329         Add a menu item to the Edit menu to toggle editability on any window.
1330
1331 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1332
1333         Implement find-in-page in MiniBrowser
1334         https://bugs.webkit.org/show_bug.cgi?id=166799
1335
1336         Reviewed by Andy Estes.
1337
1338         * MiniBrowser/mac/BrowserWindow.xib:
1339         * MiniBrowser/mac/BrowserWindowController.h:
1340         * MiniBrowser/mac/BrowserWindowController.m:
1341         (-[BrowserWindowController find:]): Deleted.
1342         * MiniBrowser/mac/MainMenu.xib:
1343         * MiniBrowser/mac/WK1BrowserWindowController.m:
1344         (-[WK1BrowserWindowController toggleShrinkToFit:]):
1345         (-[WK1BrowserWindowController find:]): Deleted.
1346         * MiniBrowser/mac/WK2BrowserWindowController.m:
1347         (-[WK2BrowserWindowController awakeFromNib]):
1348         (-[WK2BrowserWindowController dealloc]):
1349         (-[WK2BrowserWindowController validateMenuItem:]):
1350         (-[WK2BrowserWindowController performTextFinderAction:]):
1351         (-[WK2BrowserWindowController findBarView]):
1352         (-[WK2BrowserWindowController setFindBarView:]):
1353         (-[WK2BrowserWindowController isFindBarVisible]):
1354         (-[WK2BrowserWindowController setFindBarVisible:]):
1355         (-[WK2BrowserWindowController contentView]):
1356         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
1357         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
1358         (-[WK2BrowserWindowController find:]): Deleted.
1359         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
1360         protocol. At first glance, it's pretty broken, but vaguely works.
1361
1362 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1363
1364         Share the implementation of MiniBrowser view hiding functionality
1365         https://bugs.webkit.org/show_bug.cgi?id=166800
1366
1367         Reviewed by Andy Estes.
1368
1369         * MiniBrowser/mac/BrowserWindowController.m:
1370         (-[BrowserWindowController showHideWebView:]):
1371         (-[BrowserWindowController removeReinsertWebView:]):
1372         * MiniBrowser/mac/WK1BrowserWindowController.m:
1373         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
1374         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
1375         * MiniBrowser/mac/WK2BrowserWindowController.m:
1376         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
1377         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
1378         Move the implementation of these two things to the shared superclass,
1379         since they don't depend on WebKit-specific things.
1380         Also, there was no reason to retain the (WK)WebView while it was unparented,
1381         as the BrowserWindowController maintains a reference the entire time.
1382
1383 2017-01-06  Andy Estes  <aestes@apple.com>
1384
1385         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
1386         https://bugs.webkit.org/show_bug.cgi?id=166789
1387
1388         Reviewed by Alex Christensen.
1389
1390         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1391         * DumpRenderTree/PlatformMac.cmake:
1392         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
1393         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
1394         * DumpRenderTree/mac/DumpRenderTree.mm:
1395         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
1396         createXMLStringFromWebArchiveData().
1397         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
1398         * WebKitTestRunner/Configurations/Base.xcconfig:
1399         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
1400         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1401         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1402         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
1403         createXMLStringFromWebArchiveData().
1404         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
1405         * WebKitTestRunner/PlatformMac.cmake:
1406         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1407         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
1408
1409 2017-01-06  Tim Horton  <timothy_horton@apple.com>
1410
1411         Minor cleanups to IndentOutdentCommand and related code
1412         https://bugs.webkit.org/show_bug.cgi?id=166791
1413
1414         Reviewed by Simon Fraser.
1415
1416         * WebEditingTester/EditingOperations.m:
1417         (editingOperations):
1418         Add the outdent operation to WebEditingTester.
1419
1420 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
1421
1422         Create a plan and a patch files for MotionMark and delete the Animometer's ones
1423         https://bugs.webkit.org/show_bug.cgi?id=166785
1424
1425         Reviewed by Ryosuke Niwa.
1426
1427         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
1428         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
1429
1430 2017-01-06  Antoine Quint  <graouts@apple.com>
1431
1432         Support webkit-test-runner key-value pairs in http tests
1433         https://bugs.webkit.org/show_bug.cgi?id=149812
1434
1435         Reviewed by Alex Christensen.
1436
1437         We pass the absolute path for a test through to WKTR so that we can parse
1438         tests that are running as URLs for webkit-test-runner options.
1439
1440         * DumpRenderTree/DumpRenderTreeCommon.cpp:
1441         (parseInputLine):
1442
1443         Explicitly skip the --absolute-path option in DRT or else we'd crash.
1444
1445         * Scripts/webkitpy/port/driver.py:
1446         (Driver._command_from_driver_input):
1447
1448         Pass the absolute path to the file through the CLI.
1449
1450         * WebKitTestRunner/TestController.cpp:
1451         (WTR::updateTestOptionsFromTestHeader):
1452         (WTR::TestController::testOptionsForTest):
1453         (WTR::parseInputLine):
1454         (WTR::TestController::runTest):
1455         * WebKitTestRunner/TestController.h:
1456
1457 2017-01-06  Tim Horton  <timothy_horton@apple.com>
1458
1459         Warning about unconnectable outlets when opening a MiniBrowser window
1460         https://bugs.webkit.org/show_bug.cgi?id=166756
1461
1462         Reviewed by Dan Bernstein.
1463
1464         * MiniBrowser/mac/BrowserWindow.xib:
1465         When launching MiniBrowser, it says:
1466         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
1467             (MBToolbarItem): missing setter or instance variable
1468         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
1469             (NSButtonCell): missing setter or instance variable.
1470
1471         It looks like someone added the connection from the share button
1472         to the BrowserWindowController three times; only one of the connections
1473         is valid. Remove the other two.
1474
1475 2017-01-05  Keith Rollin  <krollin@apple.com>
1476
1477         Add WebCore::URL::protocolHostAndPort
1478         https://bugs.webkit.org/show_bug.cgi?id=166426
1479
1480         Reviewed by Alex Christensen.
1481
1482         Add test for protocolHostAndPort.
1483
1484         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1485         (TestWebKitAPI::TEST_F):
1486
1487 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
1488
1489         [Win] Archive test result is failing.
1490         https://bugs.webkit.org/show_bug.cgi?id=166720
1491
1492         Reviewed by Alex Christensen.
1493
1494         Deleting the layout test result folder is sometimes failing
1495         on Windows. This is not a critical error.
1496
1497         * BuildSlaveSupport/test-result-archive:
1498         (archiveTestResults):
1499
1500 2017-01-04  Tomas Popela  <tpopela@redhat.com>
1501
1502         [GTK] Minibrowser: Add printing support
1503         https://bugs.webkit.org/show_bug.cgi?id=165298
1504
1505         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
1506         an error during the print, it's printed on the console.
1507
1508         Reviewed by Michael Catanzaro.
1509
1510         * MiniBrowser/gtk/BrowserWindow.c:
1511         (webKitPrintOperationFailedCallback):
1512         (printPage):
1513         (browser_window_init):
1514
1515 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
1516
1517         [css-grid] Fix crash clamping grid lines
1518         https://bugs.webkit.org/show_bug.cgi?id=166637
1519
1520         Reviewed by Darin Adler.
1521
1522         Creates new unit test to verify that the maximum tracks limit
1523         is used in GridPosition too.
1524
1525         * TestWebKitAPI/PlatformEfl.cmake:
1526         * TestWebKitAPI/PlatformGTK.cmake:
1527         * TestWebKitAPI/PlatformWin.cmake:
1528         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1529         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
1530         (TestWebKitAPI::TEST):
1531
1532 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1533
1534         Move editing history scripts to WebCore PrivateHeaders
1535         https://bugs.webkit.org/show_bug.cgi?id=166709
1536         <rdar://problem/29876612>
1537
1538         Reviewed by Dan Bernstein.
1539
1540         Update references to editing script files in WebCore that were moved.
1541
1542         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
1543
1544 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1545
1546         Unreviewed, build fix after r210313 part 2
1547         https://bugs.webkit.org/show_bug.cgi?id=166676
1548
1549         Add 'U' suffix.
1550
1551         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1552         (TestWebKitAPI::TEST):
1553         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1554         (TestWebKitAPI::TEST):
1555
1556 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1557
1558         Limit thread name appropriately
1559         https://bugs.webkit.org/show_bug.cgi?id=166676
1560
1561         Reviewed by Sam Weinig.
1562
1563         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1564         (TestWebKitAPI::TEST):
1565         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1566         (TestWebKitAPI::TEST):
1567
1568 2017-01-04  Andy Estes  <aestes@apple.com>
1569
1570         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
1571         https://bugs.webkit.org/show_bug.cgi?id=166696
1572
1573         Reviewed by Tim Horton.
1574
1575         * TestWebKitAPI/PlatformGTK.cmake:
1576         * TestWebKitAPI/PlatformWin.cmake:
1577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1578         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
1579         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
1580         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
1581         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
1582         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
1583         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
1584
1585 2017-01-03  Brian Burg  <bburg@apple.com>
1586
1587         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
1588         https://bugs.webkit.org/show_bug.cgi?id=166003
1589         <rdar://problem/28718990>
1590
1591         Reviewed by Joseph Pecoraro.
1592
1593         Teach run-inspector-generator-tests to generate test output using the platform name
1594         derived from the directory that the test is in. For example, tests in the /generic/
1595         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
1596
1597         * Scripts/webkitpy/inspector/main.py:
1598         (InspectorGeneratorTests.generate_from_json):
1599         (InspectorGeneratorTests.run_tests):
1600         (InspectorGeneratorTests.main):
1601
1602 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
1603
1604         Unreviewed cmake buildfix after r210266.
1605
1606         * DumpRenderTree/PlatformMac.cmake:
1607
1608 2017-01-04  Tim Horton  <timothy_horton@apple.com>
1609
1610         Provide a setting for clients to always prefer low-power WebGL
1611         https://bugs.webkit.org/show_bug.cgi?id=166675
1612         <rdar://problem/29834093>
1613
1614         Reviewed by Dan Bernstein.
1615
1616         * MiniBrowser/mac/Info.plist:
1617         Have MiniBrowser claim to be a modern app that supports
1618         automatic graphics switching. WebKit needs to support automatic
1619         graphics switching, so our test app might as well. Without this
1620         Info.plist parameter, this change has no effect, and bringing up
1621         a WebGL context still brings up the discrete GPU (also true of the
1622         existing web-exposed preferLowPowerToHighPerformance API).
1623
1624 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
1625
1626         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
1627         https://bugs.webkit.org/show_bug.cgi?id=166645
1628
1629         Reviewed by Carlos Garcia Campos.
1630
1631         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1632         (TestWebKitAPI::TEST):
1633
1634 2017-01-03  Andy Estes  <aestes@apple.com>
1635
1636         Place all the Cocoa WebCore API tests in the same directory
1637         https://bugs.webkit.org/show_bug.cgi?id=166673
1638
1639         Reviewed by Michael Catanzaro.
1640
1641         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1642         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
1643         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
1644         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
1645
1646 2017-01-03  Tim Horton  <timothy_horton@apple.com>
1647
1648         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
1649         https://bugs.webkit.org/show_bug.cgi?id=166450
1650         <rdar://problem/29447824>
1651
1652         Reviewed by Darin Adler.
1653
1654         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1655         * DumpRenderTree/TestRunner.cpp:
1656         (TestRunner::staticFunctions):
1657         * DumpRenderTree/mac/TestRunnerMac.mm:
1658         (setSpellCheckerLoggingEnabledCallback):
1659         * DumpRenderTree/win/TestRunnerWin.cpp:
1660         (setSpellCheckerLoggingEnabledCallback):
1661         * DumpRenderTree/mac/DumpRenderTree.mm:
1662         (resetWebViewToConsistentStateBeforeTesting):
1663         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
1664         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
1665         (stringForCorrectionResponse):
1666         (drt_NSSpellChecker_recordResponseToCorrection):
1667         (swizzleNSSpellCheckerMethodsIfNeeded):
1668         (setSpellCheckerLoggingEnabled):
1669         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
1670         set to true, logs to stdout (which ends up in the test result) whenever
1671         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
1672         is called, and then calls the original method. It is reset to false between tests.
1673
1674 2017-01-03  Sam Weinig  <sam@webkit.org>
1675
1676         Make WTF::Expected support Ref template parameters
1677         https://bugs.webkit.org/show_bug.cgi?id=166662
1678
1679         Reviewed by Alex Christensen.
1680
1681         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1682         (TestWebKitAPI::TEST):
1683         Add tests for using Ref with Expected.
1684
1685 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1686
1687         [GTK] Expose WebKitSecurityOrigin API
1688         https://bugs.webkit.org/show_bug.cgi?id=166632
1689
1690         Reviewed by Carlos Garcia Campos.
1691
1692         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1693         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
1694         (testSecurityOriginBasicConstructor):
1695         (testSecurityOriginURIConstructor):
1696         (testSecurityOriginDefaultPort):
1697         (testSecurityOriginFileURI):
1698         (testSecurityOriginDataURI):
1699         (beforeAll):
1700         (afterAll):
1701
1702 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1703
1704         [GTK] HTTP auth layout tests are flaky
1705         https://bugs.webkit.org/show_bug.cgi?id=158919
1706
1707         Reviewed by Michael Catanzaro.
1708
1709         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
1710         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
1711         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
1712         missing valac in the bots.
1713
1714 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1715
1716         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
1717         https://bugs.webkit.org/show_bug.cgi?id=165797
1718
1719         Reviewed by Michael Catanzaro.
1720
1721         Move directory ruleset after all exclude rules of Source rulset.
1722
1723         * gtk/manifest.txt.in:
1724
1725 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1726
1727         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
1728         https://bugs.webkit.org/show_bug.cgi?id=166636
1729
1730         Reviewed by Darin Adler.
1731
1732         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1733         (TestWebKitAPI::TEST):
1734
1735 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
1736
1737         [GTK] WebCore/CSSParser unit test is not being built
1738         https://bugs.webkit.org/show_bug.cgi?id=166492
1739
1740         Reviewed by Michael Catanzaro.
1741
1742         This test was introduced in r175930, but we were not building
1743         it on GTK+ port since r176015.
1744         This patch marks the test to be built again on GTK+.
1745         JFTR, the test is passing right now.
1746
1747         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
1748         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
1749
1750 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
1751
1752         AX: Expose block quote level to iOS API
1753         https://bugs.webkit.org/show_bug.cgi?id=166629
1754         <rdar://problem/29834793>
1755
1756         Reviewed by Darin Adler.
1757
1758         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1759         (AccessibilityUIElement::numberAttributeValue):
1760         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1761         (WTR::AccessibilityUIElement::numberAttributeValue):
1762
1763 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
1764
1765         SecurityOrigin::create triplet constructor does not canonicalize port
1766         https://bugs.webkit.org/show_bug.cgi?id=166624
1767
1768         Reviewed by Daniel Bates.
1769
1770         * TestWebKitAPI/PlatformGTK.cmake:
1771         * TestWebKitAPI/PlatformWin.cmake:
1772         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1773         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
1774         (TestWebKitAPI::SecurityOriginTest::SetUp):
1775         (TestWebKitAPI::TEST_F):
1776
1777 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
1778
1779         [GTK] Improve user agent construction
1780         https://bugs.webkit.org/show_bug.cgi?id=142074
1781
1782         Reviewed by Carlos Garcia Campos.
1783
1784         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1785         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
1786         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
1787         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
1788         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
1789         (TestWebKitAPI::TEST):
1790
1791 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
1792
1793         [GTK] Improve user agent construction
1794         https://bugs.webkit.org/show_bug.cgi?id=142074
1795
1796         Reviewed by Carlos Garcia Campos.
1797
1798         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1799         (TestWebKitAPI::TEST):
1800
1801 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
1802
1803         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
1804         https://bugs.webkit.org/show_bug.cgi?id=166472
1805         rdar://problem/29675551
1806
1807         Reviewed by Tim Horton.
1808
1809         These changes are necessary to allow the mouse to leave the WTR window while
1810         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
1811         (which DRT does); we'd always go through mouseMoved, which hits an early return
1812         in WebViewImpl::mouseMoved() when the point is outside the view.
1813
1814         * WebKitTestRunner/mac/EventSenderProxy.mm:
1815         (WTR::EventSenderProxy::mouseMoveTo):
1816
1817 2016-12-23  Andy Estes  <aestes@apple.com>
1818
1819         [iOS] Fix some crashing webarchive tests
1820         https://bugs.webkit.org/show_bug.cgi?id=166470
1821
1822         Reviewed by Andreas Kling.
1823
1824         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
1825         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
1826         so this change uses that on both platforms.
1827
1828         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
1829         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
1830         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
1831         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
1832         * WebKitTestRunner/PlatformMac.cmake:
1833         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1834         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
1835
1836 2016-12-22  Saam Barati  <sbarati@apple.com>
1837
1838         WebAssembly: Silence the output of the spec-tests
1839         https://bugs.webkit.org/show_bug.cgi?id=166417
1840
1841         Reviewed by Mark Lam.
1842
1843         * Scripts/run-jsc-stress-tests:
1844
1845 2016-12-22  Zhuo Li  <zachli@apple.com>
1846
1847         [Cocoa] SPI for setloadsImagesAutomatically.
1848         https://bugs.webkit.org/show_bug.cgi?id=166401.
1849
1850         Reviewed by Darin Adler.
1851
1852         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
1853         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
1854         _loadsImagesAutomatically returns YES.
1855
1856 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1857
1858         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
1859         https://bugs.webkit.org/show_bug.cgi?id=161328
1860         <rdar://problem/28475977>
1861
1862         Reviewed by Darin Adler.
1863
1864         Running a test that scales the viewport and listens to a didEndZooming callback (such as
1865         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
1866         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
1867         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
1868         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
1869         load, should prevent this from happening, but from reading documentation and code inspection, this is not
1870         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
1871         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
1872         we finish running a test and before we load the next test.
1873
1874         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
1875         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
1876         previous test started zooming and then finished before zooming completed. Since this happens before the next
1877         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
1878
1879         * WebKitTestRunner/ios/TestControllerIOS.mm:
1880         (WTR::TestController::platformResetStateToConsistentValues):
1881
1882 2016-12-22  Jer Noble  <jer.noble@apple.com>
1883
1884         Muted media element playback should not interrupt other audio playback
1885         https://bugs.webkit.org/show_bug.cgi?id=166347
1886
1887         Reviewed by Eric Carlson.
1888
1889         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1890         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1891         (TestWebKitAPI::TEST):
1892         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
1893
1894 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
1895
1896         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
1897         https://bugs.webkit.org/show_bug.cgi?id=166346
1898
1899         Reviewed by Carlos Garcia Campos.
1900
1901         Enable WebRTC by default to simplify testing.
1902
1903         * MiniBrowser/gtk/main.c:
1904         (main):
1905
1906 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
1907
1908         REGRESSION: API test failure: WKWebView.LocalStorageClear
1909         https://bugs.webkit.org/show_bug.cgi?id=166032
1910         <rdar://problem/29758423>
1911
1912         Reviewed by Simon Fraser.
1913
1914         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
1915         to ensure that the view is destroyed before the callback fires.
1916
1917         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
1918         (TEST):
1919
1920 2016-12-21  Saam Barati  <sbarati@apple.com>
1921
1922         WebAssembly: Import spec tests
1923         https://bugs.webkit.org/show_bug.cgi?id=166395
1924
1925         Rubber stamped by Keith Miller.
1926
1927         * Scripts/run-jsc-stress-tests:
1928
1929 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
1930
1931         REGRESSION: API test failure: _WKDownload.OriginatingWebView
1932         https://bugs.webkit.org/show_bug.cgi?id=166033
1933         <rdar://problem/29758428>
1934
1935         Reviewed by Simon Fraser.
1936
1937         Add an @autoreleasepool around the code that allocates the WKWebView, 
1938         so that it can be destroyed by removing the last reference in _downloadDidStart.
1939
1940         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1941         (TEST):
1942
1943 2016-12-21  Daniel Bates  <dabates@apple.com>
1944
1945         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
1946         https://bugs.webkit.org/show_bug.cgi?id=166356
1947
1948         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
1949         as a means to allow a test to explicit allow an embedding client to open a new windows
1950         such that the default behavior is for the embedding client to forbid such an action.
1951         The test plugins/get-url-with-blank-target.html assumes this default behavior though
1952         it is currently skipped on WebKit2 because questions were raised in the patch for
1953         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
1954         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
1955         this test.
1956
1957         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1958         (WTR::TestRunner::setCanOpenWindows):
1959
1960 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
1961
1962         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
1963         https://bugs.webkit.org/show_bug.cgi?id=166031
1964
1965         Reviewed by Tim Horton.
1966         
1967         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
1968         to ensure that the view is destroyed before the callback fires.
1969
1970         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
1971
1972 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
1973
1974         Throw Exception when test doesn't clean up HID Events properly
1975         https://bugs.webkit.org/show_bug.cgi?id=166271
1976
1977         Reviewed by Simon Fraser.
1978
1979         Add in a check when UIScriptController is deleted to make sure that the HID event
1980         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
1981         the program to crash without any good information. Crashes are race-y, and will still
1982         happen with malformed test, but the information will be much more helpful. 
1983
1984         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1985         (WTR::UIScriptController::checkForClean):
1986         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1987         (UIScriptContext::~UIScriptContext):
1988         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1989         (WTR::UIScriptController::checkForClean):
1990         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1991         * WebKitTestRunner/ios/HIDEventGenerator.h:
1992         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1993         (-[HIDEventGenerator checkHIDCallbacksClear]):
1994         * WebKitTestRunner/ios/TestControllerIOS.mm:
1995         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1996         (WTR::UIScriptController::checkForClean):
1997
1998 2016-12-20  Andy Estes  <aestes@apple.com>
1999
2000         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
2001         https://bugs.webkit.org/show_bug.cgi?id=165992
2002
2003         Reviewed by Brady Eidson.
2004
2005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2006         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
2007         (expectException):
2008         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2009         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2010         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2011         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2012         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2013         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
2014         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
2015         (TEST):
2016         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
2017
2018 2016-12-20  Dean Jackson  <dino@apple.com>
2019
2020         Remove INDIE_UI
2021         https://bugs.webkit.org/show_bug.cgi?id=165881
2022         <rdar://problem/29672532>
2023
2024         Reviewed by Simon Fraser.
2025
2026         The Indie UI work has been discontinued.
2027
2028         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2029
2030 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2031
2032         [ES6] Enable ES6 Modules
2033         https://bugs.webkit.org/show_bug.cgi?id=165849
2034
2035         Reviewed by Geoffrey Garen.
2036
2037         * DumpRenderTree/mac/DumpRenderTree.mm:
2038         (resetWebPreferencesToConsistentValues):
2039         * DumpRenderTree/win/DumpRenderTree.cpp:
2040         (resetWebPreferencesToConsistentValues):
2041         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2042         (WTR::InjectedBundle::beginTesting):
2043         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2044         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
2045         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2046
2047 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
2048
2049         Repurpose bots and clean up dashboard.
2050         https://bugs.webkit.org/show_bug.cgi?id=166045
2051
2052         Reviewed by Lucas Forschler.
2053
2054         * BuildSlaveSupport/build.webkit.org-config/config.json:
2055         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2056         (BubbleQueueServer):
2057         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2058         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2059         (WebKitBuildbot):
2060         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2061         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
2062
2063 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2064
2065         [CMake] TestWebKitAPIBase links to itself
2066         https://bugs.webkit.org/show_bug.cgi?id=165985
2067
2068         Reviewed by Alex Christensen.
2069
2070         Fix CMake warning about a target linking to itself, which makes no sense.
2071
2072         * TestWebKitAPI/CMakeLists.txt:
2073
2074 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2075
2076         [GTK] GtkDoc build should be quieter
2077         https://bugs.webkit.org/show_bug.cgi?id=165994
2078
2079         Reviewed by Carlos Garcia Campos.
2080
2081         Make it not print by default.
2082
2083         * gtk/generate-gtkdoc:
2084         (get_generator_for_config):
2085         (generate_doc):
2086         * gtk/gtkdoc.py:
2087         (GTKDoc._run_command):
2088         (GTKDoc._copy_doc_files_to_output_dir):
2089
2090 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
2091
2092         Expose a way for MiniBrowser to simulate header and footer banners
2093         https://bugs.webkit.org/show_bug.cgi?id=166005
2094
2095         Reviewed by Wenson Hsieh.
2096         
2097         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
2098         banners. This only works in WebKit2.
2099         
2100         We need to reset these on each navigation, since newly created FrameViews
2101         don't re-fetch the header and footer height stored on Page.
2102         
2103         Also fix the signature of webView:didFinishNavigation: to follow API changes,
2104         as well as fixing webViewWebContentProcessDidTerminate:
2105
2106         * MiniBrowser/mac/SettingsController.h:
2107         * MiniBrowser/mac/SettingsController.m:
2108         (-[SettingsController _populateMenu]):
2109         (-[SettingsController validateMenuItem:]):
2110         (-[SettingsController toggleReserveSpaceForBanners:]):
2111         (-[SettingsController isSpaceReservedForBanners]):
2112         * MiniBrowser/mac/WK2BrowserWindowController.m:
2113         (-[WK2BrowserWindowController didChangeSettings]):
2114         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2115         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
2116         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
2117         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
2118
2119 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
2120
2121         Fix iOS test results after r209967.
2122         
2123         Subtracting out the status bar height was erroneously happening for all tests,
2124         not just for flexible viewport tests.
2125         
2126         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
2127
2128         * WebKitTestRunner/PlatformWebView.h:
2129         * WebKitTestRunner/TestController.cpp:
2130         (WTR::TestController::resetStateToConsistentValues):
2131         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2132         (WTR::PlatformWebView::resizeTo):
2133         (WTR::PlatformWebView::setWindowFrame):
2134         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2135         (WTR::PlatformWebView::resizeTo):
2136         (WTR::PlatformWebView::setWindowFrame):
2137         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2138         (WTR::PlatformWebView::resizeTo):
2139         (WTR::PlatformWebView::setWindowFrame):
2140         * WebKitTestRunner/ios/TestControllerIOS.mm:
2141         (WTR::TestController::platformConfigureViewForTest):
2142         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2143         (WTR::PlatformWebView::resizeTo):
2144         (WTR::PlatformWebView::setWindowFrame):
2145
2146 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
2147
2148         [EFL] bump EFL version to 1.18.4
2149         https://bugs.webkit.org/show_bug.cgi?id=166004
2150
2151         Reviewed by Gyuyoung Kim.
2152
2153         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
2154
2155 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2156
2157         Visual viewports: bottom fixed elements disappear behind the keyboard
2158         https://bugs.webkit.org/show_bug.cgi?id=165983
2159         <rdar://problem/29409852>
2160
2161         Reviewed by Simon Fraser.
2162
2163         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
2164         the keyboard when it is up.
2165
2166         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2167         (WTR::UIScriptController::inputViewBounds):
2168         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2169         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2170         (WTR::UIScriptController::inputViewBounds):
2171         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2172         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2173         (WTR::viewRectForWindowRect):
2174
2175         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
2176         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
2177         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
2178
2179         (WTR::PlatformWebView::PlatformWebView):
2180         (WTR::PlatformWebView::setWindowFrame):
2181         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2182         (WTR::UIScriptController::inputViewBounds):
2183
2184 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
2185
2186         Deleting a character converted from pinyin after an image causes a Safari crash
2187         https://bugs.webkit.org/show_bug.cgi?id=165839
2188         <rdar://problem/27951933>
2189
2190         Reviewed by Wenson Hsieh.
2191
2192         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
2193         while the proposed range contains an image. This should not cause a WebProcess to crash
2194         or send an invalid message to the UIProcess.
2195
2196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2197         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
2198         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
2199         (TestWebKitAPI::didFinishLoadForFrame):
2200         (TestWebKitAPI::processDidCrash):
2201         (TestWebKitAPI::invalidMessageFunction):
2202         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
2203
2204 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2205
2206         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
2207         https://bugs.webkit.org/show_bug.cgi?id=165767
2208         <rdar://problem/29602382>
2209
2210         Reviewed by Simon Fraser.
2211
2212         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
2213         WebKit2 ChangeLog for more details.
2214
2215         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2216         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2217         (WTR::UIScriptController::textSelectionCaretRect):
2218         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2219         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2220         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2221         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2222         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2223         (WTR::UIScriptController::textSelectionCaretRect):
2224         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2225         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2226         (-[TestRunnerWKWebView _setStableStateOverride:]):
2227
2228         Force the WKWebView to update its visible content rects when changing the stable state override.
2229
2230         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2231         (WTR::toNSDictionary):
2232         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2233         (WTR::UIScriptController::selectionRangeViewRects):
2234         (WTR::UIScriptController::textSelectionCaretRect):
2235         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2236         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2237
2238 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
2239
2240         Arguments called in wrong order
2241         https://bugs.webkit.org/show_bug.cgi?id=165923
2242
2243         Reviewed by Simon Fraser.
2244
2245         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
2246         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
2247
2248         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2249         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
2250         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
2251
2252 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
2253
2254         [EFL] Disable non-srcdir builds for failing libraries
2255         https://bugs.webkit.org/show_bug.cgi?id=165896
2256
2257         Reviewed by Gyuyoung Kim.
2258
2259         * efl/jhbuild.modules: Set non srcdir builds to no
2260
2261 2016-12-15  Daniel Bates  <dabates@apple.com>
2262
2263         check-style should not complain about code in icu directories
2264         https://bugs.webkit.org/show_bug.cgi?id=53929
2265
2266         Reviewed by Darin Adler.
2267
2268         Skip style checking of imported ICU headers to avoid a deluge of style issues
2269         as they do not conform to the WebKit Code Style guideline. We want to preserve
2270         the formatting of these headers so as to make it straightforward to merge
2271         changes to them, if necessary.
2272
2273         * Scripts/webkitpy/style/checker.py:
2274
2275 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
2276
2277         Move JSC testers from Yosemite to Sierra
2278         https://bugs.webkit.org/show_bug.cgi?id=165925
2279
2280         Reviewed by Lucas Forschler.
2281
2282         * BuildSlaveSupport/build.webkit.org-config/config.json:
2283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2284         (WebKitBuildbot):
2285
2286 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
2287
2288         Add coordinate space to event streams and streamline tests
2289         https://bugs.webkit.org/show_bug.cgi?id=165119
2290
2291         Reviewed by Simon Fraser.
2292
2293         Update event streams to allow for both content and global coordinate space.
2294         Update example script to more accurately show all the available options.
2295
2296         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2297         * WebKitTestRunner/ios/HIDEventGenerator.h:
2298         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2299         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2300         (WTR::convertCoordinates):
2301         (WTR::UIScriptController::sendEventStream):
2302
2303 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
2304
2305         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
2306         https://bugs.webkit.org/show_bug.cgi?id=165855
2307
2308         Reviewed by Philippe Normand.
2309
2310         GStreamer's autogen.sh enables gtk-doc always so we end up building
2311         docs even if we disable them. Use the configure script instead, since
2312         we build from packages and these include it already.
2313
2314         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
2315         upstream gstreamer packages.
2316
2317 2016-12-15  Alex Christensen  <achristensen@webkit.org>
2318
2319         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
2320         https://bugs.webkit.org/show_bug.cgi?id=165885
2321         <rdar://problem/29476917>
2322
2323         Reviewed by Darin Adler.
2324
2325         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2326         (TestWebKitAPI::utf16String): Deleted.
2327         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
2328         (TestWebKitAPI::TEST_F):
2329         * TestWebKitAPI/WTFStringUtilities.h:
2330         (utf16String):
2331         Moved from URLParser to share with other tests.
2332
2333 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
2334
2335         iOS: An element with tabindex is not focusable unless there is no mouse event handler
2336         https://bugs.webkit.org/show_bug.cgi?id=165843
2337
2338         Reviewed by Antti Koivisto.
2339
2340         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
2341         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
2342         and DumpRenderTree's runUIScript would hit an assertion :(
2343
2344         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2345         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2346         (WTR::TestRunner::isWebKit2):
2347
2348 2016-12-14  Brady Eidson  <beidson@apple.com>
2349
2350         IndexedDB 2.0: Massively speedup IDBIndex.get().
2351         https://bugs.webkit.org/show_bug.cgi?id=165802
2352
2353         Reviewed by Alex Christensen.
2354
2355         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2356         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
2357         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
2358         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
2359         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
2360
2361 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2362
2363         [GTK][EFL] Update the JHBuild version.
2364         https://bugs.webkit.org/show_bug.cgi?id=165838
2365
2366         Reviewed by Michael Catanzaro.
2367
2368         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
2369         usage of the JHBUILD_MIRROR feature with git repositories.
2370
2371 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2372
2373         [GTK] Yasm is needed for building the JHBuild after r208940
2374         https://bugs.webkit.org/show_bug.cgi?id=165837
2375
2376         Reviewed by Alejandro G. Castro.
2377
2378         * gtk/install-dependencies: Yasm is needed for building libvpx.
2379
2380 2016-12-14  Youenn Fablet  <youenn@apple.com>
2381
2382         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
2383         https://bugs.webkit.org/show_bug.cgi?id=161310
2384
2385         Reviewed by Ryosuke Niwa.
2386
2387         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
2388         When set, WTR and DRT output JS console log in the stderr and not the test output.
2389         This allows removing potentially flaky information while still being able to read it for investigation.
2390
2391         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
2392
2393         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
2394         This test should have this option when fetch API will start logging resource loader errors.
2395
2396         * DumpRenderTree/DumpRenderTree.h:
2397         (TestCommand::TestCommand): Deleted.
2398         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2399         (parseInputLine):
2400         * DumpRenderTree/TestRunner.h:
2401         (TestRunner::setDumpJSConsoleLogInStdErr):
2402         (TestRunner::dumpJSConsoleLogInStdErr):
2403         * DumpRenderTree/mac/DumpRenderTree.mm:
2404         (runTest):
2405         * DumpRenderTree/mac/UIDelegate.mm:
2406         (-[UIDelegate webView:addMessageToConsole:withSource:]):
2407         * DumpRenderTree/win/DumpRenderTree.cpp:
2408         (runTest):
2409         * DumpRenderTree/win/UIDelegate.cpp:
2410         (UIDelegate::webViewAddMessageToConsole):
2411         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2412         (TestExpectationParser._tokenize_line):
2413         * Scripts/webkitpy/port/driver.py:
2414         (Driver._command_from_driver_input):
2415         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2416         (WTR::InjectedBundle::didReceiveMessageToPage):
2417         (WTR::InjectedBundle::dumpToStdErr):
2418         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2419         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
2420         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2421         (WTR::InjectedBundlePage::willAddMessageToConsole):
2422         * WebKitTestRunner/TestController.cpp:
2423         (WTR::parseInputLine):
2424         (WTR::TestController::runTest):
2425         (WTR::TestCommand::TestCommand): Deleted.
2426         * WebKitTestRunner/TestInvocation.cpp:
2427         (WTR::TestInvocation::invoke):
2428         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2429         * WebKitTestRunner/TestInvocation.h:
2430         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
2431
2432
2433 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
2434
2435         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
2436         https://bugs.webkit.org/show_bug.cgi?id=164022
2437
2438         Reviewed by Xabier Rodriguez-Calvar.
2439
2440         * Scripts/webkitperl/FeatureList.pm:
2441           Re-enable MEDIA_SOURCE for the GTK+ port.
2442
2443 2016-12-13  Alex Christensen  <achristensen@webkit.org>
2444
2445         Fix CMake build.
2446
2447         * DumpRenderTree/PlatformMac.cmake:
2448         Define NS_RETURNS_RETAINED as nothing for now.
2449
2450 2016-12-13  Jer Noble  <jer.noble@apple.com>
2451
2452         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
2453         https://bugs.webkit.org/show_bug.cgi?id=165697
2454
2455         Reviewed by Tim Horton.
2456
2457         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
2458         (TestWebKitAPI::TEST):
2459
2460 2016-12-13  Andy Estes  <aestes@apple.com>
2461
2462         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
2463         https://bugs.webkit.org/show_bug.cgi?id=165785
2464         <rdar://problem/26929398>
2465
2466         Reviewed by Darin Adler.
2467
2468         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
2469         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
2470         expectations for the text, range, and action.
2471         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
2472         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
2473         plain-text string to the pasteboard, executed a paste action, and verified that the selected
2474         text in the web view did not change.
2475         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
2476         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
2477         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
2478         parameter.
2479         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
2480         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
2481         and returned the value of _editingDelegateShouldInsertText.
2482         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
2483         -shouldInsertText:replacingRange:givenAction:.
2484
2485 2016-12-13  Chris Dumez  <cdumez@apple.com>
2486
2487         Unreviewed, rolling out r209544.
2488
2489         Looks like r209489 did not cause the performance regression
2490         after all
2491
2492         Reverted changeset:
2493
2494         "Unreviewed, rolling out r209489."
2495         https://bugs.webkit.org/show_bug.cgi?id=165550
2496         http://trac.webkit.org/changeset/209544
2497
2498 2016-12-12  Sam Weinig  <sam@webkit.org>
2499
2500         [WebIDL] Remove use of Dictionary in ApplePaySession
2501         https://bugs.webkit.org/show_bug.cgi?id=165787
2502
2503         Reviewed by Anders Carlsson.
2504
2505         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2506         (WTR::initializeWebViewConfiguration):
2507         (WTR::TestController::platformCreateWebView):
2508         Enable ApplePay for the tests (where supported).
2509
2510 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
2511
2512         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
2513         https://bugs.webkit.org/show_bug.cgi?id=165251
2514
2515         Reviewed by Youenn Fablet.
2516
2517         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
2518         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
2519         the preferences have been set.
2520
2521 2016-12-08  Antti Koivisto  <antti@apple.com>
2522
2523         Enable network cache speculative revalidation in MiniBrowser
2524         https://bugs.webkit.org/show_bug.cgi?id=165616
2525
2526         Reviewed by Darin Adler.
2527
2528         Match Safari. Also add a menu item to disable it.
2529
2530         * MiniBrowser/mac/AppDelegate.m:
2531         (defaultConfiguration):
2532         * MiniBrowser/mac/SettingsController.h:
2533         * MiniBrowser/mac/SettingsController.m:
2534         (-[SettingsController _populateMenu]):
2535         (-[SettingsController validateMenuItem:]):
2536         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
2537         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
2538
2539 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
2540
2541         ChangeLogs become readonly after resolving a conflict
2542         https://bugs.webkit.org/show_bug.cgi?id=165440
2543         rdar://problem/29491002
2544
2545         Reviewed by Darin Adler.
2546
2547         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
2548         moving the file.
2549
2550 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
2551
2552         Re-enable collectContinuously since it doesn't crash anymore
2553
2554         Rubber stamped by Michael Saboff.
2555
2556         * Scripts/run-jsc-stress-tests:
2557
2558 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
2559
2560         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
2561         https://bugs.webkit.org/show_bug.cgi?id=165686
2562
2563         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
2564         so that right config.h comes first in include path.
2565
2566 2016-12-11  Dave Hyatt  <hyatt@apple.com>
2567
2568         [CSS Parser] Make sure content extensions initialize AtomicString
2569         https://bugs.webkit.org/show_bug.cgi?id=165737
2570
2571         Reviewed by Darin Adler.
2572
2573         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2574         (TestWebKitAPI::makeBackend):
2575
2576 2016-12-08  Dave Hyatt  <hyatt@apple.com>
2577
2578         [CSS Parser] Remove the old CSS Parser
2579         https://bugs.webkit.org/show_bug.cgi?id=165645
2580
2581         Reviewed by Daniel Bates.
2582
2583         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
2584         (TestWebKitAPI::TEST):
2585
2586 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
2587
2588         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
2589         https://bugs.webkit.org/show_bug.cgi?id=165686
2590
2591         Reviewed by Michael Catanzaro.
2592
2593         This change reduces duplication of include path lists between modules,
2594         and reduces future need for fixes like r209605 (broken build because of
2595         WebCore header suddenly becoming used in WebKit2).
2596
2597         * DumpRenderTree/CMakeLists.txt:
2598         * DumpRenderTree/PlatformMac.cmake:
2599         * ImageDiff/CMakeLists.txt:
2600         * MiniBrowser/gtk/CMakeLists.txt:
2601         * MiniBrowser/mac/CMakeLists.txt:
2602         * MiniBrowser/win/CMakeLists.txt:
2603         * TestWebKitAPI/CMakeLists.txt:
2604         * TestWebKitAPI/PlatformEfl.cmake:
2605         * TestWebKitAPI/PlatformJSCOnly.cmake:
2606         * TestWebKitAPI/PlatformMac.cmake:
2607         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2608         * WebKitTestRunner/CMakeLists.txt:
2609         * WebKitTestRunner/PlatformGTK.cmake:
2610         * WebKitTestRunner/PlatformMac.cmake:
2611
2612 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
2613
2614         Unreviewed buildfix after r209630.
2615
2616         * Scripts/build-jsc: Remove building the non-existing testWASM.
2617
2618 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
2619
2620         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
2621         https://bugs.webkit.org/show_bug.cgi?id=165251
2622
2623         Reviewed by Dean Jackson.
2624
2625         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
2626
2627         * DumpRenderTree/mac/DumpRenderTree.mm:
2628         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
2629
2630         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2631         (WTR::InjectedBundle::beginTesting): Ditto.
2632
2633         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2634         (WTR::TestRunner::setMediaStreamEnabled): New.
2635         (WTR::TestRunner::setPeerConnectionEnabled): New.
2636         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2637
2638 2016-12-09  Brady Eidson  <beidson@apple.com> 
2639  
2640         Re-landing:
2641         Add _WKIconLoadingDelegate SPI. 
2642         https://bugs.webkit.org/show_bug.cgi?id=164894 
2643  
2644         Reviewed by Alex Christensen. 
2645         
2646         Add MiniBrowser support for this new SPI, configurable with a setting. 
2647  
2648         * MiniBrowser/mac/SettingsController.h: 
2649         * MiniBrowser/mac/SettingsController.m: 
2650         (-[SettingsController _populateMenu]): 
2651         (-[SettingsController validateMenuItem:]): 
2652         (-[SettingsController loadsAllSiteIcons]): 
2653         (-[SettingsController toggleLoadsAllSiteIcons:]): 
2654         * MiniBrowser/mac/WK2BrowserWindowController.m: 
2655         (-[WK2BrowserWindowController awakeFromNib]): 
2656         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
2657
2658 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
2659
2660         Fix the 32-bit build.
2661
2662         Unreviewed build fix.
2663
2664         * MiniBrowser/mac/SettingsController.h:
2665
2666 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2667
2668         Fedora also needs a PHP7 config file alternative
2669         https://bugs.webkit.org/show_bug.cgi?id=165606
2670
2671         Reviewed by Michael Catanzaro.
2672
2673         * Scripts/webkitpy/port/base.py:
2674         (Port._is_fedora_php_version_7): check for the php7 library.
2675         (Port._fedora_php_version): get the appropriate filename for Fedora.
2676         (Port._apache_config_file_name_for_platform):
2677
2678 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
2679
2680         Complete the revert of r208865.
2681         https://bugs.webkit.org/show_bug.cgi?id=164894
2682
2683         Unreviewed build fix.
2684
2685         * MiniBrowser/mac/SettingsController.h:
2686         * MiniBrowser/mac/SettingsController.m:
2687         (-[SettingsController _populateMenu]):
2688         (-[SettingsController validateMenuItem:]):
2689         (-[SettingsController loadsAllSiteIcons]): Deleted.
2690         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
2691         * MiniBrowser/mac/WK2BrowserWindowController.m:
2692         (-[WK2BrowserWindowController awakeFromNib]):
2693         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
2694
2695 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2696
2697         [GTK] Force GDK backend to x11 when running with XvfbDriver
2698         https://bugs.webkit.org/show_bug.cgi?id=165612
2699
2700         Reviewed by Michael Catanzaro.
2701
2702         When the developer is running a Wayland session, GDK may get confused
2703         and try to use its Wayland backend (which is higher priority) instead.
2704         This ensures it will use the appropriate backend when running under
2705         Xvfb.
2706
2707         * Scripts/webkitpy/port/gtk.py:
2708         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
2709         force GDK_BACKEND to x11.
2710
2711 2016-12-08  Keith Miller  <keith_miller@apple.com>
2712
2713         Add 64-bit signed LEB decode method
2714         https://bugs.webkit.org/show_bug.cgi?id=165630
2715
2716         Reviewed by Ryosuke Niwa.
2717
2718         Add tests for LEB int64 and uint64 decode since I guess
2719         I forgot to add tests before.
2720
2721         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
2722         (TestWebKitAPI::testUInt32LEBDecode):
2723         (TestWebKitAPI::TEST):
2724         (TestWebKitAPI::testUInt64LEBDecode):
2725         (TestWebKitAPI::testInt32LEBDecode):
2726         (TestWebKitAPI::testInt64LEBDecode):
2727         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
2728
2729 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
2730
2731         Make it easy to enable --force-collectContinuously
2732         https://bugs.webkit.org/show_bug.cgi?id=165638
2733
2734         Reviewed by Keith Miller.
2735
2736         * Scripts/run-javascriptcore-tests:
2737         (runJSCStressTests):
2738
2739 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
2740
2741         Disable the collectContinuously mode until I investigate failures.
2742
2743         Rubber stamped by Keith Miller.
2744         
2745         I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
2746         while I investigate.
2747
2748         * Scripts/run-jsc-stress-tests:
2749
2750 2016-12-08  Alex Christensen  <achristensen@webkit.org>
2751
2752         REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
2753         https://bugs.webkit.org/show_bug.cgi?id=165621
2754
2755         Reviewed by Dan Bernstein.
2756
2757         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2758         (TestWebKitAPI::TEST_F):
2759
2760 2016-12-06  Filip Pizlo  <fpizlo@apple.com>
2761
2762         Concurrent GC should be stable enough to land enabled
2763         https://bugs.webkit.org/show_bug.cgi?id=164990
2764
2765         Reviewed by Geoffrey Garen.
2766         
2767         Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
2768         
2769         It's clear that this works just fine in release, but I'm still trying to figure out if it's
2770         safe for debug. It might be too slow for debug.
2771
2772         * Scripts/run-jsc-stress-tests:
2773
2774 2016-12-08  Alex Christensen  <achristensen@webkit.org>
2775
2776         Add SPI for sending WebsiteSettings to WebProcess during navigation
2777         https://bugs.webkit.org/show_bug.cgi?id=165517
2778         <rdar://29341068>
2779
2780         Reviewed by Anders Carlsson.
2781
2782         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2783         * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added.
2784         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added.
2785         (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2786         (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2787         (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2788         (TEST):
2789
2790 2016-12-08  Chris Dumez  <cdumez@apple.com>
2791
2792         Unreviewed, rolling out r209489.
2793
2794         Likely caused large regressions on JetStream, Sunspider and
2795         Speedometer
2796
2797         Reverted changeset:
2798
2799         "Add system trace points for JavaScript VM entry/exit"
2800         https://bugs.webkit.org/show_bug.cgi?id=165550
2801         http://trac.webkit.org/changeset/209489
2802
2803 2016-12-08  Keith Miller  <keith_miller@apple.com>
2804
2805         Move LEB tests to API tests
2806         https://bugs.webkit.org/show_bug.cgi?id=165586
2807
2808         Reviewed by Saam Barati.
2809
2810         Move the tests from testWasm.cpp and make them functions
2811         rather than macros.
2812
2813         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2814         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added.
2815         (TestWebKitAPI::testUnsignedLEBDecode):
2816         (TestWebKitAPI::TEST):
2817         (TestWebKitAPI::testInt32LEBDecode):
2818
2819 2016-12-08  Chris Dumez  <cdumez@apple.com>
2820
2821         Support running the layout tests offline
2822         https://bugs.webkit.org/show_bug.cgi?id=165534
2823
2824         Reviewed by Ryosuke Niwa.
2825
2826         * Scripts/webkitpy/common/system/autoinstall.py:
2827         (AutoInstaller._download_to_stream):
2828         getcode() returns None for file URLs so handle this.
2829
2830         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2831         (WebPlatformTestServer._install_modules):
2832         Deal with local path in the json file and resolve them into file URLs
2833         before using AutoInstall.
2834
2835 2016-12-08  Alex Christensen  <achristensen@webkit.org>
2836
2837         Fix CMake build.
2838
2839         * DumpRenderTree/PlatformMac.cmake:
2840         Remove CheckedMalloc.cpp after r209516.
2841
2842 2016-12-07  Mark Lam  <mark.lam@apple.com>
2843
2844         DumpRenderTree should stop using CheckedMalloc.
2845         https://bugs.webkit.org/show_bug.cgi?id=165563
2846         <rdar://problem/28945820>
2847
2848         Reviewed by Geoffrey Garen.
2849
2850         1. WebKitTestRunner does not have equivalent behavior to that which is implemented
2851            in CheckedMalloc.
2852         2. bmalloc does not honor the settings of CheckedMalloc.
2853
2854         The only time CheckedMalloc comes into play is when DRT uses gmalloc or system
2855         malloc.  As a result, DRT exhibits different behavior from the normal way we run
2856         our tests.  We should obsolete CheckedMalloc and make DRT behave consistently
2857         with WKTR.
2858
2859         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2860         * DumpRenderTree/mac/CheckedMalloc.cpp: Removed.
2861         * DumpRenderTree/mac/CheckedMalloc.h: Removed.
2862         * DumpRenderTree/mac/DumpRenderTree.mm:
2863         (prepareConsistentTestingEnvironment):
2864
2865 2016-12-07  Dean Jackson  <dino@apple.com>
2866
2867         Remove runtime toggle for pointer-lock
2868         https://bugs.webkit.org/show_bug.cgi?id=165577
2869         <rdar://problems/29566996>
2870
2871         Reviewed by Jon Lee.
2872
2873         Remove any runtime calls to check if pointer-lock is enabled. It's
2874         either compiled in or out.
2875
2876         * DumpRenderTree/mac/DumpRenderTree.mm:
2877         (resetWebPreferencesToConsistentValues):
2878         * WebKitTestRunner/TestController.cpp:
2879         (WTR::TestController::resetPreferencesToConsistentValues):
2880
2881 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
2882
2883         [MediaStream][Mac] Revoke sandbox extensions when capture ends
2884         https://bugs.webkit.org/show_bug.cgi?id=165476
2885
2886         Reviewed by Brady Eidson.
2887         
2888         Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the
2889         page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy
2890         is reset and recreated when a web page exits and is reloaded.
2891
2892         * TestWebKitAPI/PlatformGTK.cmake:
2893         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2894         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Added.
2895         (TestWebKitAPI::checkUserMediaPermissionCallback):
2896         (TestWebKitAPI::TEST):
2897         * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Added.
2898
2899 2016-12-07  Jeremy Jones  <jeremyj@apple.com>
2900
2901         One esc to exit fullscreen and pointer lock
2902         https://bugs.webkit.org/show_bug.cgi?id=165416
2903         rdar://problem/29430711
2904
2905         Reviewed by Jer Noble.
2906
2907         Implement WKPageUIClientV8 for pointer lock support.
2908         Add "escape" key support in EventSenderProxy.
2909
2910         * WebKitTestRunner/TestController.cpp:
2911         (WTR::requestPointerLock):
2912         (WTR::TestController::createOtherPage):
2913         (WTR::TestController::createWebViewWithOptions):
2914         * WebKitTestRunner/mac/EventSenderProxy.mm:
2915         (WTR::EventSenderProxy::keyDown):
2916
2917 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
2918
2919         Add system trace points for JavaScript VM entry/exit
2920         https://bugs.webkit.org/show_bug.cgi?id=165550
2921
2922         Reviewed by Tim Horton.
2923
2924         Add trace points for entry/exit into/out of the JS VM.
2925
2926         * Tracing/SystemTracePoints.plist:
2927
2928 2016-12-07  ChangSeok Oh  <changseok@webkit.org>
2929
2930         [GTK] Cannot build GTK+ with CUPS 2.* versions
2931         https://bugs.webkit.org/show_bug.cgi?id=163591
2932
2933         Reviewed by Michael Catanzaro.
2934
2935         GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4
2936         does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration.
2937         GTK+ upstream fixed this issue but it is not easy to apply the original patch to our
2938         old gtk+ since it requires not only bumping up glib accordingly and its consequence
2939         causes many printing test failures. So, I propose to fix the configuration issue by
2940         applying the change to the configure file directly. By doing this, we don't need to
2941         upgrade glib and worry about any test failures as a consequence of the upgraded glib.
2942
2943         * gtk/jhbuild.modules:
2944         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added.
2945
2946 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
2947
2948         Fix use of enum in a WK2 C SPI header.
2949         rdar://problem/28725583
2950
2951         Followup to correctly prefix the enum values.
2952
2953         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2954         (WTR::InjectedBundlePage::prepare):
2955
2956 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
2957
2958         Fix use of enum in a WK2 C SPI header.
2959         rdar://problem/28725583
2960
2961         Reviewed by Dan Bernstein.
2962
2963         Use correct enum style for a C SPI header and fix the callers.
2964
2965         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2966         (WTR::InjectedBundlePage::prepare):
2967
2968 2016-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2969
2970         Add a new project for recording and playing back editing commands in editable web content
2971         https://bugs.webkit.org/show_bug.cgi?id=165114
2972         <rdar://problem/29408135>
2973
2974         Reviewed by Beth Dakin.
2975
2976         Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is
2977         wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the
2978         capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may
2979         then be dragged into the playback test harness.
2980
2981         Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following
2982         steps:
2983
2984         1. Load the capture harness and perform test-specific editing on the web view.
2985         2. Let originalState be a dump of the DOM at this point in time.
2986         3. Extract the JSON-serialized editing history data and load the playback harness with this data.
2987         4. Rewind all editing to the beginning.
2988         5. Playback all editing to the end.
2989         6. Dump the state of the DOM. This should be identical to originalState.
2990
2991         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added.
2992         * EditingHistory/EditingHistory/Info.plist: Added.
2993         * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added.
2994         * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added.
2995         * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added.
2996         * EditingHistory/EditingHistory/TestRunner.h: Added.
2997         * EditingHistory/EditingHistory/TestRunner.m: Added.
2998         (injectedMessageEventHandlerScript):
2999         (-[TestRunner init]):
3000         (-[TestRunner deleteBackwards:]):
3001         (-[TestRunner typeString:]):
3002         (-[TestRunner bodyElementSubtree]):
3003         (-[TestRunner bodyTextContent]):
3004         (-[TestRunner editingHistoryJSON]):
3005         (-[TestRunner loadPlaybackTestHarnessWithJSON:]):
3006         (-[TestRunner numberOfUpdates]):
3007         (-[TestRunner jumpToUpdateIndex:]):
3008         (-[TestRunner expectEvents:afterPerforming:]):
3009         (-[TestRunner loadCaptureTestHarness]):
3010         (-[TestRunner setTextObfuscationEnabled:]):
3011         (-[TestRunner isDoneWaitingForPendingEvents]):
3012         (-[TestRunner userContentController:didReceiveScriptMessage:]):
3013
3014         The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses)
3015         or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness).
3016
3017         * EditingHistory/EditingHistory/TestUtil.h: Added.
3018         * EditingHistory/EditingHistory/TestUtil.m: Added.
3019         (waitUntilWithTimeout):
3020         (waitUntil):
3021
3022         Provides utilities for running tests. For now, this is just spinning the runloop on a given condition.
3023
3024         * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added.
3025         * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added.
3026         (-[WKWebView loadPageFromBundleNamed:]):
3027         (-[WKWebView typeCharacter:]):
3028         (-[WKWebView keyPressWithCharacters:keyCode:]):
3029         (-[WKWebView stringByEvaluatingJavaScriptFromString:]):
3030
3031         Provides utilities for simulating interaction in a web view.
3032
3033         * EditingHistory/EditingHistory/main.m: Added.
3034         (main):
3035         * EditingHistory/EditingHistoryTests/Info.plist: Added.
3036         * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added.
3037         (-[RewindAndPlaybackTests setUp]):
3038         (-[RewindAndPlaybackTests tearDown]):
3039         (-[RewindAndPlaybackTests testTypingSingleLineOfText]):
3040         (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]):
3041         (-[RewindAndPlaybackTests testTypingAndDeletingText]):
3042         (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]):
3043         (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]):
3044
3045 2016-12-07  Philippe Normand  <pnormand@igalia.com>
3046
3047         [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good
3048         https://bugs.webkit.org/show_bug.cgi?id=165525
3049
3050         Reviewed by Carlos Garcia Campos.
3051
3052         * gtk/jhbuild.modules: gst-plugins-good should depend on the
3053         libvpx package built within jhbuild.
3054
3055 2016-12-07  Philippe Normand  <pnormand@igalia.com>
3056
3057         [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0
3058         https://bugs.webkit.org/show_bug.cgi?id=165520
3059
3060         Reviewed by Carlos Garcia Campos.
3061
3062         * gtk/jhbuild.modules: Added missing dependency on openh264 in
3063         gst-plugins-bad, along with 2 upstream patches fixing the build
3064         against OpenSSL 1.1.0.
3065         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
3066         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
3067
3068 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
3069
3070         Correct SDKROOT values in xcconfig files
3071         https://bugs.webkit.org/show_bug.cgi?id=165487
3072         rdar://problem/29539209
3073
3074         Reviewed by Dan Bernstein.
3075
3076         Fix suggested by Dan Bernstein.
3077
3078         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3079         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3080         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3081         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3082         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3083         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3084
3085 2016-12-06  Daniel Bates  <dabates@apple.com>
3086
3087         WebKitTestRunner: Plugins are disabled in new windows
3088         https://bugs.webkit.org/show_bug.cgi?id=165410
3089
3090         Reviewed by Alex Christensen.
3091
3092         Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens
3093         a new window and loads a plugin will fail. We should enable plugins in all windows by
3094         default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows.
3095
3096         Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html
3097         in WebKitTestRunner (we still need to fix <https://bugs.webkit.org/show_bug.cgi?id=46714>) and
3098         will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.
3099
3100         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3101         (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of
3102         WKBundleSetPluginsEnabled().
3103         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3104         (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled()
3105         and make use of WKBundleOverrideBoolPreferenceForTestRunner().
3106
3107 2016-12-05  Dean Jackson  <dino@apple.com>
3108
3109         pointer lock needs to be feature detectable
3110         https://bugs.webkit.org/show_bug.cgi?id=165426
3111         <rdar://problem/29486715>
3112
3113         Reviewed by Antoine Quint.
3114
3115         Expose the comment line to turn on/off pointer lock.
3116
3117         * DumpRenderTree/TestOptions.h:
3118         * DumpRenderTree/TestOptions.mm:
3119         (TestOptions::TestOptions):
3120         * DumpRenderTree/mac/DumpRenderTree.mm:
3121         (resetWebPreferencesToConsistentValues):
3122         * WebKitTestRunner/TestController.cpp:
3123         (WTR::TestController::resetPreferencesToConsistentValues):
3124         (WTR::updateTestOptionsFromTestHeader):
3125         * WebKitTestRunner/TestOptions.h:
3126         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3127         (WTR::PlatformWebView::viewSupportsOptions):
3128         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3129         (WTR::PlatformWebView::viewSupportsOptions):
3130
3131 2016-12-05  Jonathan Bedard  <jbedard@apple.com>
3132
3133         Make it possible to use an existing simulator instance for one-off testing
3134         https://bugs.webkit.org/show_bug.cgi?id=164568
3135         <rdar://problem/29189133>
3136
3137         Reviewed by Daniel Bates.
3138
3139         With this patch, if a simulator is currently running on the machine and
3140         '--dedicated-simulators' is not passed into the application, only one simulator
3141         instance will be used, and this instance will be the existing instance.
3142         If no simulator is running or '--dedicated-simulators' is passed to the script,
3143         previous behavior will be used.
3144
3145         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3146         (parse_args):
3147         * Scripts/webkitpy/port/ios.py:
3148         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
3149         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
3150         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
3151         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
3152         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
3153         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
3154         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
3155         * Scripts/webkitpy/xcode/simulator.py:
3156         (Simulator.refresh): Check if xcode_simctl_list returned None instead of a generator.
3157         (Simulator.current_device): Get currently running device.
3158
3159 2016-12-05  Dan Bernstein  <mitz@apple.com>
3160
3161         Disable a crashing test on iOS.
3162
3163         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3164
3165 2016-12-04  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3166
3167         Fix a build break on EFL since r209303.
3168
3169         Unreviewed build fix.
3170
3171         * Scripts/webkitperl/FeatureList.pm: Disable SS Device Adaptation temporarily.
3172
3173 2016-12-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3174
3175         Refactor SymbolImpl layout
3176         https://bugs.webkit.org/show_bug.cgi?id=165247
3177
3178         Reviewed by Darin Adler.
3179
3180         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3181         (TestWebKitAPI::TEST):
3182
3183 2016-12-03  Dan Bernstein  <mitz@apple.com>
3184
3185         Fixed the build after r209307.
3186
3187         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3188         (TEST):
3189
3190 2016-12-03  Dan Bernstein  <mitz@apple.com>
3191
3192         [Cocoa] Expose InjectedBundlePageEditorClient via the Objective-C bundle SPI
3193         https://bugs.webkit.org/show_bug.cgi?id=165276
3194         <rdar://problem/29467040>
3195
3196         Reviewed by Darin Adler.
3197
3198         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3199         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Added.
3200         (-[BundleEditingDelegateRemoteObject willWriteToPasteboard:]):
3201         (-[BundleEditingDelegateRemoteObject didWriteToPasteboard]):
3202         (TEST):
3203         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Added.
3204         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3205         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:willWriteRangeToPasteboard:]):
3206         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
3207         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextControllerDidWriteToPasteboard:]):
3208         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Added.
3209
3210 2016-12-02  Andy Estes  <aestes@apple.com>
3211
3212         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
3213         https://bugs.webkit.org/show_bug.cgi?id=164492
3214
3215         Reviewed by Dan Bernstein.
3216
3217         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Changed CFBundleIdentifier's value from
3218         com.apple.testnetscapeplugin to ${PRODUCT_BUNDLE_IDENTIFIER}.
3219         * DumpRenderTree/ios/Info.plist: Changed CFBundleIdentifier's value from
3220         org.webkit.DumpRenderTree to ${PRODUCT_BUNDLE_IDENTIFIER}.
3221         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Set
3222         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.DumpRenderTree.
3223         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Set
3224         PRODUCT_BUNDLE_IDENTIFIER to com.apple.testnetscapeplugin.
3225         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
3226         org.webkit.$(PRODUCT_NAME:rfc1034identifier).
3227         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
3228         com.apple.$(PRODUCT_NAME:rfc1034identifier).
3229         * MiniBrowser/mac/Bundle/Info.plist: Changed CFBundleIdentifier's value from
3230         com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
3231         * MiniBrowser/mac/Info.plist: Changed CFBundleIdentifier's value from
3232         org.webkit.${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
3233         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
3234         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
3235         com.apple.$(PRODUCT_NAME:rfc1034identifier).
3236         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
3237         com.apple.$(PRODUCT_NAME:rfc1034identifier).
3238         * TestWebKitAPI/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
3239         com.yourcompany.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
3240         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added a CFBundleIdentifier key with the
3241         value ${PRODUCT_BUNDLE_IDENTIFIER}.
3242         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
3243         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
3244         com.apple.WebKitTestRunner.InjectedBundle.
3245         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Set
3246         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier).
3247         * WebKitTestRunner/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
3248         com.apple.WebKitTestRunner.InjectedBundle to ${PRODUCT_BUNDLE_IDENTIFIER}.
3249         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Changed
3250         CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME:rfc1034identifier} to
3251         ${PRODUCT_BUNDLE_IDENTIFIER}.
3252
3253 2016-12-02  Brady Eidson  <beidson@apple.com>
3254
3255         Make IndexedDB.WebProcessKillIDBCleanup even more reliable.
3256         https://bugs.webkit.org/show_bug.cgi?id=165330
3257
3258         Reviewed by Alex Christensen.
3259
3260         The test currently nulls out a RetainPtr<WKWebView> to try to destroy the view and kill the process.
3261
3262         Problem is that doesn't reliably destroy the view.
3263         We should explicitly kill the process instead.
3264
3265         Also, by relocating when we kill the process, we can better test behavior of the IndexedDB mechanism.
3266         e.g. We explicitly confirm that a second WebProcess can simultaneously attach to the same unique database as the first.
3267
3268         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
3269         (TEST):
3270
3271 2016-12-02  Commit Queue  <commit-queue@webkit.org>
3272
3273         Unreviewed, rolling out r209136.
3274         https://bugs.webkit.org/show_bug.cgi?id=165337
3275
3276         broke 36 webkitpy tests (Requested by mcatanzaro on #webkit).
3277
3278         Reverted changeset:
3279
3280         "Make it possible to use an existing simulator instance for
3281         one-off testing"
3282         https://bugs.webkit.org/show_bug.cgi?id=164568
3283         http://trac.webkit.org/changeset/209136
3284
3285 2016-12-02  Chris Dumez  <cdumez@apple.com>
3286
3287         [Mac][WK1] Implement new HTML interactive form validation user interface
3288         https://bugs.webkit.org/show_bug.cgi?id=164483
3289
3290         Reviewed by Simon Fraser.
3291
3292         Add support for UIScriptController's contentsOfUserInterfaceItem("validationBubble")
3293         on Mac DRT as this is needed by the HTML form validation layout tests.
3294
3295         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3296         (WTR::UIScriptController::contentsOfUserInterfaceItem):
3297
3298 2016-12-02  Brady Eidson  <beidson@apple.com>
3299
3300         IndexedDB.IndexedDBMultiProcess and IndexedDB.WebProcessKillIDBCleanup sometimes timeout.
3301         https://bugs.webkit.org/show_bug.cgi?id=160780 and https://bugs.webkit.org/show_bug.cgi?id=161001
3302
3303         Reviewed by Alexey Proskuryakov.
3304
3305         These tests had "run-loop races."
3306         
3307         The test spins the runloop waiting for one message.
3308         Two messages might come in from the WebProcess in short succession, and both be delivered to the
3309         UIProcess in the same spin of the runloop.
3310
3311         Therefore by the time the test stops spinning the runloop, notified that a message was received,
3312         the first message has been overwritten by the second.
3313
3314         These tests are fixed by queueing the incoming messages instead of just storing one.
3315
3316         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3317         (-[IndexedDBMPMessageHandler userContentController:didReceiveScriptMessage:]):
3318         (getNextMessage):
3319         (TEST):
3320
3321         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
3322         (-[IndexedDBWebProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
3323         (getNextMessage):
3324         (TEST):
3325
3326 2016-12-01  Jiewen Tan  <jiewen_tan@apple.com>
3327
3328         Add a runtime flag for SubtleCrypto
3329         https://bugs.webkit.org/show_bug.cgi?id=164982
3330
3331         Reviewed by Brent Fulgham.
3332
3333         * DumpRenderTree/mac/DumpRenderTree.mm:
3334         (resetWebPreferencesToConsistentValues):
3335         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3336         (WTR::InjectedBundle::beginTesting):
3337         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3338         (WTR::TestRunner::setSubtleCryptoEnabled):
3339         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3340
3341 2016-12-01  Alexey Proskuryakov  <ap@apple.com>
3342
3343         Remove webkitpy dependency on Eliza
3344         https://bugs.webkit.org/show_bug.cgi?id=164979
3345
3346         Reviewed by Daniel Bates.
3347
3348         This module is not on pypi, so installing it is a challenge. The jokes feel pretty old too!
3349
3350         * Scripts/webkitpy/thirdparty/__init__.py:
3351         * Scripts/webkitpy/thirdparty/__init___unittest.py: Changed mock import hook to
3352         test buildbot instead of eliza.
3353         * Scripts/webkitpy/tool/bot/ircbot.py:
3354         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3355
3356 2016-12-01  Beth Dakin  <bdakin@apple.com>
3357
3358         Force clicking tests fail on some machines
3359         https://bugs.webkit.org/show_bug.cgi?id=165263
3360
3361         Reviewed by Tim Horton.
3362
3363         Initialize com.apple.trackpad.forceClick to 1 so that we don’t have to depend on 
3364         the user account having this feature enabled. 
3365         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3366         (WTR::InjectedBundle::platformInitialize):
3367         * WebKitTestRunner/mac/main.mm:
3368         (setDefaultsToConsistentValuesForTesting):
3369
3370 2016-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
3371
3372         Introduce StringImpl::StaticStringImpl with constexpr constructor
3373         https://bugs.webkit.org/show_bug.cgi?id=165093
3374
3375         Reviewed by Darin Adler.
3376
3377         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3378         (TestWebKitAPI::TEST):
3379
3380 2016-11-30  Antoine Quint  <graouts@apple.com>
3381
3382         [Modern Media Controls] Add an HTML comment flag to turn the feature on
3383         https://bugs.webkit.org/show_bug.cgi?id=165226
3384
3385         Reviewed by Dean Jackson.
3386
3387         Add a new flag to turn Modern Media Controls on in the test runners.
3388
3389         * DumpRenderTree/TestOptions.h:
3390         * DumpRenderTree/TestOptions.mm:
3391         (TestOptions::TestOptions):
3392         * DumpRenderTree/mac/DumpRenderTree.mm:
3393         (resetWebPreferencesToConsistentValues):
3394         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3395         (WTR::InjectedBundle::beginTesting):
3396         * WebKitTestRunner/TestController.cpp:
3397         (WTR::TestController::resetPreferencesToConsistentValues):
3398         (WTR::updateTestOptionsFromTestHeader):
3399         * WebKitTestRunner/TestOptions.h:
3400         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3401         (WTR::PlatformWebView::viewSupportsOptions):
3402         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3403         (WTR::PlatformWebView::viewSupportsOptions):
3404
3405 2016-11-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
3406
3407         Add separate settings and preferences to enable/disable async decoding for large images and animated images
3408         https://bugs.webkit.org/show_bug.cgi?id=165177
3409
3410         Reviewed by Simon Fraser.
3411         
3412         Pref and a menu item to toggle async image decoding settings for WebKits 1 and 2.
3413
3414         * MiniBrowser/mac/SettingsController.h:
3415         * MiniBrowser/mac/SettingsController.m:
3416         (-[SettingsController _populateMenu]):
3417         (-[SettingsController validateMenuItem:]):
3418         (-[SettingsController toggleLargeImageAsyncDecodingEnabled:]):
3419         (-[SettingsController largeImageAsyncDecodingEnabled]):
3420         (-[SettingsController toggleAnimatedImageAsyncDecodingEnabled:]):
3421         (-[SettingsController animatedImageAsyncDecodingEnabled]):
3422         (-[SettingsController toggleAsyncImageDecodingEnabled:]): Deleted.
3423         (-[SettingsController asyncImageDecodingEnabled]): Deleted.
3424         * MiniBrowser/mac/WK1BrowserWindowController.m:
3425         (-[WK1BrowserWindowController didChangeSettings]):
3426         * MiniBrowser/mac/WK2BrowserWindowController.m:
3427         (-[WK2BrowserWindowController didChangeSettings]):
3428
3429 2016-11-30  Jonathan Bedard  <jbedard@apple.com>
3430
3431         Make it possible to use an existing simulator instance for one-off testing
3432         https://bugs.webkit.org/show_bug.cgi?id=164568
3433         <rdar://problem/29189133>
3434
3435         Reviewed by Daniel Bates.
3436
3437         With this patch, if a simulator is currently running on the machine and
3438         '--dedicated-simulators' is not passed into the application, only one simulator
3439         instance will be used, and this instance will be the existing instance.
3440         If no simulator is running or '--dedicated-simulators' is passed to the script,
3441         previous behavior will be used.
3442
3443         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3444         (parse_args):
3445         * Scripts/webkitpy/port/ios.py:
3446         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
3447         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
3448         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
3449         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
3450         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
3451         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
3452         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
3453         * Scripts/webkitpy/xcode/simulator.py:
3454         (Simulator.current_device): Get currently running device.
3455
3456 2016-11-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3457
3458         [Linux] run-benchmark should be able to execute the benchmarks with more browsers.
3459         https://bugs.webkit.org/show_bug.cgi?id=164792
3460
3461         Reviewed by Michael Catanzaro.
3462
3463         This removes the GTKBrowserDriver (and the platform 'gtk') from the run-benchmark script,
3464         and adds a new LinuxBrowserDriver with a platform 'linux'.
3465
3466         It add also drivers for Chrome (Chromium), Firefox, Epiphany and MiniBrowser-GTK (previously MiniBrowser).
3467
3468         The detection of the platform is now done automatically, so it is not longer needed to pass a "--platform" parameter.
3469
3470         The tracking of the browser process is now more robust, we track the pid of the browser process and we only try to
3471         kill the ones that were executed by this script, instead of doing a 'killall $browser' (like before).
3472         We also check for browser process childs and we kill them if they are still alive after the main browser process has been killed.
3473         This depends on psutil, so this will only be done if psutil is installed.
3474
3475         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3476         (RunBenchmarkTests.start): The platform is now autodetected and the MiniBrowser driver is renamed to MiniBrowser-GTK.
3477         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3478         (BenchmarkRunner._run_benchmark): Fix a bug that caused close_browsers to be called twice. Its already called inside BenchmarkRunner._run_one_test.
3479         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py: Added.
3480         (LinuxBrowserDriver): Implement base class that has all the needed functionality for driving the browsers.
3481         (LinuxBrowserDriver.__init__):
3482         (LinuxBrowserDriver.prepare_env):
3483         (LinuxBrowserDriver.restore_env):
3484         (LinuxBrowserDriver.close_browsers): Made the dependency on psutil optional (because it was listed as such on the README file <Tools/Scripts/webkitpy/benchmark_runner/README.md>)
3485         (LinuxBrowserDriver.launch_url):
3486         (LinuxBrowserDriver._get_first_executable_path_from_list):
3487         (LinuxBrowserDriver._screen_size):
3488         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
3489         (LinuxChromeDriver):
3490         (LinuxChromeDriver.launch_url):
3491         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_browser_driver.py.
3492         (EpiphanyBrowserDriver):
3493         (EpiphanyBrowserDriver.launch_url):
3494         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py: Copied from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
3495         (LinuxFirefoxDriver):
3496         (LinuxFirefoxDriver.launch_url):
3497         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py: Renamed from Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py.
3498         (GTKMiniBrowserDriver):
3499         (GTKMiniBrowserDriver.launch_url):
3500         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3501         (SimpleHTTPServerDriver):
3502         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3503         (getplatform):
3504         (getdefaultbrowser):
3505         (parse_args):
3506         * Scripts/webkitpy/benchmark_runner/utils.py:
3507         (load_subclasses): The loading of subclasses was still (even after r196979) sensitive to the order in which the modules are loaded.
3508         We have to ensure that the files containing subclasses of the base_class_file are loaded after the base_class_file,
3509         we can do that by matching against the base_class_file pattern when the list is created.
3510
3511 2016-11-29  Andy Estes  <aestes@apple.com>
3512
3513         [Cocoa] Enable two clang warnings recommended by Xcode
3514         https://bugs.webkit.org/show_bug.cgi?id=164498
3515
3516         Reviewed by Mark Lam.
3517
3518         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE.
3519         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
3520         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3521         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3522
3523 2016-11-29  Eric Carlson  <eric.carlson@apple.com>
3524
3525         [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
3526         https://bugs.webkit.org/show_bug.cgi?id=164760
3527         <rdar://problem/29261266>
3528
3529         Reviewed by Youenn Fablet.
3530         
3531         Allow scripts to determine the number of times the user has been prompted for capture device access.
3532
3533         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3534         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3535         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
3536         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin):
3537         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
3538         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): Deleted.
3539         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3540         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3541         (WTR::TestRunner::setUserMediaPersistentPermissionForOrigin):
3542         (WTR::TestRunner::userMediaPermissionRequestCountForOrigin):
3543         (WTR::TestRunner::resetUserMediaPermissionRequestCountForOrigin):
3544         (WTR::TestRunner::setUserMediaPermissionForOrigin): Deleted.
3545         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3546         * WebKitTestRunner/TestController.cpp:
3547         (WTR::TestController::resetStateToConsistentValues):
3548         (WTR::OriginSettings::incrementRequestCount):
3549         (WTR::OriginSettings::resetRequestCount):
3550         (WTR::OriginSettings::requestCount):
3551         (WTR::TestController::saltForOrigin):
3552         (WTR::TestController::setUserMediaPersistentPermissionForOrigin):
3553         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
3554         (WTR::TestController::settingsForOrigin):
3555         (WTR::TestController::userMediaPermissionRequestCountForOrigin):
3556         (WTR::TestController::resetUserMediaPermissionRequestCountForOrigin):
3557         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
3558         (WTR::TestController::setUserMediaPermissionForOrigin): Deleted.
3559         * WebKitTestRunner/TestController.h:
3560         * WebKitTestRunner/TestInvocation.cpp:
3561         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3562         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3563
3564 2016-11-29  Simon Fraser  <simon.fraser@apple.com>
3565
3566         intersection-observer-entry-interface.html test fails on the bots
3567         https://bugs.webkit.org/show_bug.cgi?id=165133
3568
3569         Reviewed by Darin Adler.
3570         
3571         Tests that enabled Intersection Observer via <!-- webkit-test-runner [ enableIntersectionObserver=true ] -->
3572         would fail sometimes, because TestController::ensureViewSupportsOptionsForTest() failed to check
3573         to see if this option required creating a new web view, so would just use the old view without
3574         even resetting preferences.
3575         
3576         In general, TestController doesn't distinguish properly between options that require the creation
3577         of a new view (like mock scrollbars), and those that can be simply reset as resetPreferencesToConsistentValues()
3578         does.
3579         
3580         Do the easy fix of having viewSupportsOptions() check options.enableIntersectionObserver. We should probably
3581         just call resetPreferencesToConsistentValues() even when re-use the same view.
3582         
3583         * WebKitTestRunner/TestController.cpp:
3584         (WTR::TestController::resetPreferencesToConsistentValues):
3585         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3586         (WTR::PlatformWebView::viewSupportsOptions):
3587         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3588         (WTR::PlatformWebView::viewSupportsOptions):
3589
3590 2016-11-28  Ryan Haddad  <ryanhaddad@apple.com>
3591
3592         Unreviewed, rolling out r209008.
3593
3594         This change appears to have caused two fast/mediastrem
3595         LayoutTests to fail.
3596
3597         Reverted changeset:
3598
3599         "[MediaStream] Don't request user permission for a device if
3600         it has already been granted in the current browsing context"
3601         https://bugs.webkit.org/show_bug.cgi?id=164760
3602         http://trac.webkit.org/changeset/209008
3603
3604 2016-11-28  Daniel Bates  <dabates@apple.com>
3605
3606         Teach webkitpy how to read CSSProperties.json r209001
3607         https://bugs.webkit.org/show_bug.cgi?id=165108
3608
3609         Reviewed by Simon Fraser.
3610
3611         Fix webkitpy logic so that it can read CSS property names from CSSProperties.json following r209001.
3612
3613         Following r209001 CSSPropertyNames.in no longer exists as it was replaced with CSSProperties.json.
3614         We need to modify the webkitpy machinery that processed CSSPropertyNames.in to process CSSProperties.json.
3615
3616         * Scripts/webkitpy/w3c/test_converter.py:
3617         (_W3CTestConverter.__init__): Make self._css_property_file and self._css_property_value_file local
3618         variables as it is unnecessary for them to be instance variables. Call read_webkit_prefixed_css_property_list()
3619         to read the property names from file CSSProperties.json. Call legacy_read_webkit_prefixed_css_property_list() to
3620         read CSS keyword values from CSSValueKeywords.in.
3621         (_W3CTestConverter.read_webkit_prefixed_css_property_list): Added.
3622         (_W3CTestConverter):
3623         (_W3CTestConverter.legacy_read_webkit_prefixed_css_property_list): Renamed from read_webkit_prefixed_css_property_list.
3624         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3625         (TestImporterTest.test_harnesslinks_conversion): Substitute CSSProperties.json for CSSPropertyNames.in.
3626
3627 2016-11-28  Eric Carlson  <eric.carlson@apple.com>
3628
3629         [MediaStream] Don't request user permission for a device if it has already been granted in the current browsing context
3630         https://bugs.webkit.org/show_bug.cgi?id=164760
3631         <rdar://problem/29261266>
3632
3633         Reviewed by Youenn Fablet.
3634         
3635         Allow scripts to determine the number of times the user has been prompted for capture device access.
3636
3637         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3638         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3639         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
3640         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin):