Isolate Early Warning System definitions into a JSON
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Isolate Early Warning System definitions into a JSON
4         https://bugs.webkit.org/show_bug.cgi?id=114558
5
6         Reviewed by Benjamin Poulain.
7
8         Added ews.json to common/config, and made tool/commands/__init__.py call
9         AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
10
11         Reland the patch since the EWS failure was a false positive.
12
13         * Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
14         * Scripts/webkitpy/tool/commands/__init__.py:
15         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
16         (AbstractEarlyWarningSystem):
17         (AbstractEarlyWarningSystem.__init__):
18         (AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
19         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
20         (EarlyWarningSystemTest._default_expected_logs):
21         (_test_ews):
22         (test_ewses):
23
24 2013-04-16  Sam Weinig  <sam@webkit.org>
25
26         Fix fallout after r148545.
27
28         * WebKitTestRunner/TestController.cpp:
29         (WTR::TestController::resetStateToConsistentValues):
30         Remove calls to non-existent API functions.
31
32 2013-04-13  Roger Fong  <roger_fong@apple.com>
33
34         Unreviewed. Disable WinEWS tests, simply not enough bots.
35
36         All bots are running consistently now but the queue still keeps growing.
37         Until we get more bots or make the tests faster, it doesn't seem wise to keep running tests.
38
39         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
40         (WinEWS):
41
42 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
43
44         The list of contributors in committers.py should be a separate JSON
45         https://bugs.webkit.org/show_bug.cgi?id=114673
46
47         Reviewed by Anders Carlsson.
48
49         Added webkitpy/common/config/contributors.json, made CommitterList load it.
50
51         * EWSTools/start-queue-mac.sh:
52         * EWSTools/start-queue.sh:
53         * Scripts/webkitpy/common/checkout/commitinfo.py:
54         (CommitInfo.committer):
55         * Scripts/webkitpy/common/config/contributors.json: Added.
56         * Scripts/webkitpy/common/config/committers.py:
57         (Reviewer.__init__):
58         (CommitterList.__init__):
59         (CommitterList.load_json): Added.
60         (CommitterList.load_json.emails):
61         (CommitterList.load_json.nicks):
62         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
63         (MockCommitInfo.author):
64
65 2013-04-16  Manuel Rego Casasnovas  <rego@igalia.com>
66
67         [EFL] Bump libsoup dependency to 2.42.0
68         https://bugs.webkit.org/show_bug.cgi?id=113927
69
70         Reviewed by Gyuyoung Kim.
71
72         Update libsoup required version to v2.42.0 and GLib to v2.36.0 as
73         required by libsoup for EFL port.
74
75         * efl/jhbuild.modules:
76         * efl/patches/libsoup-2.40-auth-fix.patch: Removed as it's already
77         included in v2.42.0.
78
79 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
80
81         Remove Account class from committers.py
82         https://bugs.webkit.org/show_bug.cgi?id=114671
83
84         Reviewed by Csaba Osztrogonác.
85
86         Account class was added to support watch list email addresses that are not associated with
87         a particular contributor but nobody uses these email address since Chromium port forked.
88
89         Remove it.
90
91         Also removed account_by_login from CommitterList since it was never called except its unittests.
92
93         * Scripts/webkitpy/common/checkout/changelog.py:
94         * Scripts/webkitpy/common/config/committers.py:
95         (Contributor):
96         (Contributor.matches_glob):
97         (Reviewer.__init__):
98         (CommitterList.__init__):
99         (CommitterList._email_to_account_map):
100         (CommitterList._login_to_account_map):
101         (CommitterList.contributors_by_fuzzy_match):
102         (CommitterList.contributor_by_email):
103         (CommitterList.contributor_by_name):
104         (CommitterList.committer_by_email):
105         (CommitterList.reviewer_by_email):
106         * Scripts/webkitpy/common/config/committers_unittest.py:
107         (CommittersTest.test_committer_lookup):
108         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
109         (Bugzilla._commit_queue_flag):
110         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
111         (test_commit_queue_flag):
112         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
113         (WatchListParser._validate):
114
115 2013-04-16  Mike West  <mkwst@chromium.org>
116
117         Unreviewed update to the watchlist.
118
119         Removing 'mkwst+watchlist@chromium.org' from committers.py and the
120         watchist file; moving to 'mkwst@chromium.org' instead.
121
122         * Scripts/webkitpy/common/config/committers.py:
123         * Scripts/webkitpy/common/config/watchlist:
124
125 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
126
127         Move webkitpy.layout_tests.port to webkitpy.port
128         https://bugs.webkit.org/show_bug.cgi?id=114668
129
130         Reviewed by Maciej Stachowiak.
131
132         Moved. Port objects knows a lot more than just layout_tests. They doesn't belong down in layout_tests.
133
134         * Scripts/webkitpy/common/host.py:
135         * Scripts/webkitpy/common/host_mock.py:
136         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
137         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
138         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
139         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
140         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
141         * Scripts/webkitpy/layout_tests/port: Removed.
142         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
143         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
144         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
145         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
146         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
147         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
148         * Scripts/webkitpy/performance_tests/perftest.py:
149         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
150         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
151         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
152         * Scripts/webkitpy/port: Copied from Tools/Scripts/webkitpy/layout_tests/port.
153         * Scripts/webkitpy/port/apple.py:
154         * Scripts/webkitpy/port/base.py:
155         * Scripts/webkitpy/port/base_unittest.py:
156         * Scripts/webkitpy/port/config_unittest.py:
157         (ConfigTest.test_default_configuration__standalone):
158         * Scripts/webkitpy/port/driver_unittest.py:
159         * Scripts/webkitpy/port/efl.py:
160         * Scripts/webkitpy/port/efl_unittest.py:
161         * Scripts/webkitpy/port/factory.py:
162         * Scripts/webkitpy/port/factory_unittest.py:
163         * Scripts/webkitpy/port/gtk.py:
164         * Scripts/webkitpy/port/gtk_unittest.py:
165         * Scripts/webkitpy/port/image_diff.py:
166         * Scripts/webkitpy/port/image_diff_unittest.py:
167         * Scripts/webkitpy/port/leakdetector_unittest.py:
168         * Scripts/webkitpy/port/mac.py:
169         * Scripts/webkitpy/port/mac_unittest.py:
170         * Scripts/webkitpy/port/mock_drt.py:
171         * Scripts/webkitpy/port/mock_drt_unittest.py:
172         * Scripts/webkitpy/port/port_testcase.py:
173         * Scripts/webkitpy/port/qt.py:
174         * Scripts/webkitpy/port/qt_unittest.py:
175         * Scripts/webkitpy/port/server_process_unittest.py:
176         * Scripts/webkitpy/port/test.py:
177         * Scripts/webkitpy/port/win.py:
178         * Scripts/webkitpy/port/win_unittest.py:
179         * Scripts/webkitpy/port/xvfbdriver.py:
180         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
181         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
182         * Scripts/webkitpy/tool/commands/gardenomatic.py:
183         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
184         * Scripts/webkitpy/tool/commands/queries.py:
185         * Scripts/webkitpy/tool/commands/queries_unittest.py:
186         * Scripts/webkitpy/tool/commands/rebaseline.py:
187         * Scripts/webkitpy/tool/servers/gardeningserver.py:
188         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
189         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
190         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
191
192 2013-04-16  Commit Queue  <rniwa@webkit.org>
193
194         Unreviewed, rolling out r148498.
195         http://trac.webkit.org/changeset/148498
196         https://bugs.webkit.org/show_bug.cgi?id=114669
197
198         Appears to have broken EWS (Requested by rniwa on #webkit).
199
200         * Scripts/webkitpy/common/config/ews.json: Removed.
201         * Scripts/webkitpy/tool/commands/__init__.py:
202         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
203         (AbstractEarlyWarningSystem):
204         (AbstractEarlyWarningSystem.__init__):
205         (AbstractEarlyWarningSystem.handle_script_error.does):
206         (GtkEWS):
207         (GtkWK2EWS):
208         (EflEWS):
209         (QtEWS):
210         (QtWK2EWS):
211         (WinEWS):
212         (MacEWS):
213         (MacWK2EWS):
214         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
215         (EarlyWarningSystemTest._default_expected_logs):
216         (_test_ews):
217         (test_ewses):
218
219 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
220
221         Isolate Early Warning System definitions into a JSON
222         https://bugs.webkit.org/show_bug.cgi?id=114558
223
224         Reviewed by Benjamin Poulain.
225
226         Added ews.json to common/config, and made tool/commands/__init__.py call
227         AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
228
229         * Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
230         * Scripts/webkitpy/tool/commands/__init__.py:
231         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
232         (AbstractEarlyWarningSystem):
233         (AbstractEarlyWarningSystem.__init__):
234         (AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
235         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
236         (EarlyWarningSystemTest._default_expected_logs):
237         (_test_ews):
238         (test_ewses):
239
240 2013-04-15  Ryosuke Niwa  <rniwa@webkit.org>
241
242         WKR gets stuck when there are many merges
243         https://bugs.webkit.org/show_bug.cgi?id=114632
244
245         Reviewed by Andreas Kling.
246
247         Move the last revision forward when it exists in a branch.
248         Otherwise, we'll be stuck looping over revisions made to merge patches.
249
250         * Scripts/webkitpy/tool/commands/newcommitbot.py:
251         (NewCommitBot.next_work_item):
252
253 2013-04-15  Gustavo Noronha Silva  <gns@gnome.org>
254
255         [GTK] Missing a few packages for building on stock Fedora
256         https://bugs.webkit.org/show_bug.cgi?id=113916
257
258         Reviewed by Philippe Normand.
259
260         * gtk/install-dependencies: add packages that are missing.
261
262 2013-04-15  Zan Dobersek  <zdobersek@igalia.com>
263
264         REGRESSION (r148360): Failure in webkitpy.tool.multicommandtool_unittest.MultiCommandToolTest.test_command_help
265         https://bugs.webkit.org/show_bug.cgi?id=114602
266
267         Reviewed by Ryosuke Niwa.
268
269         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
270         (CommandTest.test_required_arguments): Reset the static argument_names variable on the TrivialCommand
271         interface so its value doesn't leak into the following tests.
272
273 2013-04-15  Zan Dobersek  <zandobersek@gmail.com>
274
275         Deprecate land-cowboy in favor of land-cowhand
276         https://bugs.webkit.org/show_bug.cgi?id=104470
277
278         Reviewed by Darin Adler.
279
280         Move the LandCowboy command implementation under the LandCowhand command and deprecate the former.
281
282         * Scripts/webkitpy/tool/commands/download.py:
283         (LandCowhand):
284         (LandCowboy):
285         (LandCowboy._prepare_state):
286         * Scripts/webkitpy/tool/commands/download_unittest.py:
287         (test_land_cowhand): Adjust the unit tests by testing both LandCowhand and LandCowboy,
288         also checking the deprecation message in the output of the latter.
289
290 2013-04-15  Jonathan Liu  <net147@gmail.com>
291
292         Improve Windows cmd.exe detection
293         https://bugs.webkit.org/show_bug.cgi?id=114620
294
295         Reviewed by Jocelyn Turcotte.
296
297         The current detection code handles Windows cmd.exe and Cygwin shell
298         but not does not handle MSYS shell correctly. Simplify and improve the
299         detection by checking MINGW_IN_SHELL instead as used in other places
300         (e.g. qt_functions.prf).
301
302         * qmake/mkspecs/features/default_pre.prf:
303
304 2013-04-15  Manuel Rego Casasnovas  <rego@igalia.com>
305
306         [webkitpy] Use $NUMBER_OF_PROCESSORS in Executive.cpu_count()
307         https://bugs.webkit.org/show_bug.cgi?id=114506
308
309         Reviewed by Philippe Normand.
310
311         * Scripts/webkitpy/common/system/executive.py:
312         (Executive.cpu_count): Modify function in order to use the environment
313         variable $NUMBER_OF_PROCESSORS if it is defined and it is an integer
314         greater than 0.
315
316 2013-04-15  Xan Lopez  <xlopez@igalia.com>
317
318         [BlackBerry] ASSERT in StyleResolver::ensureScopeResolver()
319         https://bugs.webkit.org/show_bug.cgi?id=114615
320
321         Reviewed by Carlos Garcia Campos.
322
323         Enable the style scoped feature if we have support for it.
324
325         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
326         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
327
328 2013-04-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
329
330         [Qt] QtMultimedia not used when GStreamer is not found
331         https://bugs.webkit.org/show_bug.cgi?id=111842
332
333         Reviewed by Philippe Normand.
334
335         Fallback to using QtMultimedia when native libraries are not found.
336
337         * qmake/mkspecs/features/features.prf:
338
339 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
340
341         Build fix attempt for webkitbot. Unicodify everything.
342
343         * Scripts/webkitpy/tool/bot/irc_command.py:
344         (Whois.execute):
345
346 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
347
348         webkitbot should provide full name, email address, and IRC nicknames on whois
349         https://bugs.webkit.org/show_bug.cgi?id=114494
350
351         Reviewed by Benjamin Poulain.
352
353         A response like the one below is useless. Improve it:
354         webkitbot: rniwa: zdobersek is zdobersek (zandobersek@gmail.com). Why do you ask?
355
356         We now report full name, email address, committer/reviewer status, and IRC nickname.
357
358         Also teach webkitbot how to respond to ping.
359
360         * Scripts/webkitpy/tool/bot/irc_command.py:
361         (PingPong): Moved 
362         (PingPong.execute):
363         (Whois._full_record_and_nick): Renamed and rewritten.
364         (Whois.execute):
365
366         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
367         (IRCCommandTest.test_whois): Updated test cases as needed.
368
369         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
370         (IRCBotTest.test_help): Added ping.
371
372         * Scripts/webkitpy/tool/commands/newcommitbot.py:
373         (NewCommitBot): Teached WKR how to respond to hi.
374
375 2013-04-13  Anders Carlsson  <andersca@apple.com>
376
377         Add form delegate method that's invoked right before sending a submit event to a form element
378         https://bugs.webkit.org/show_bug.cgi?id=114575
379
380         Reviewed by Dan Bernstein.
381
382         Add a test.
383
384         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
385         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm: Added.
386         (-[FormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
387         (TestWebKitAPI):
388         (TestWebKitAPI::TEST):
389         
390         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
391         (TestWebKitAPI::Util::toSTD):
392         Don't crash when a null NSString is passed to toSTD.
393
394 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
395
396         Python test fix attempt after r148360.
397
398         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
399         (test_command_help):
400
401 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
402
403         Merge AbstractDeclarativeCommand into Command as a comment suggests
404         https://bugs.webkit.org/show_bug.cgi?id=114559
405
406         Reviewed by Antti Koivisto.
407
408         Merged two classes as the comment right above AbstractDeclarativeCommand suggested.
409         We need to merge a lot more classes to make webkitpy hackable.
410
411         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
412         (AbstractLocalServerCommand):
413         (AbstractLocalServerCommand.__init__):
414         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
415         (AbstractSequencedCommand):
416         (AbstractSequencedCommand.__init__):
417         * Scripts/webkitpy/tool/commands/adduserstogroups.py:
418         (AddUsersToGroups):
419         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
420         (AnalyzeChangeLog):
421         (AnalyzeChangeLog.__init__):
422         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
423         * Scripts/webkitpy/tool/commands/bugfortest.py:
424         (BugForTest):
425         * Scripts/webkitpy/tool/commands/bugsearch.py:
426         (BugSearch):
427         * Scripts/webkitpy/tool/commands/chromechannels.py:
428         (ChromeChannels):
429         (__init__):
430         * Scripts/webkitpy/tool/commands/download.py:
431         (AbstractPatchProcessingCommand):
432         * Scripts/webkitpy/tool/commands/findusers.py:
433         (FindUsers):
434         * Scripts/webkitpy/tool/commands/openbugs.py:
435         (OpenBugs):
436         * Scripts/webkitpy/tool/commands/queries.py:
437         (BugsToCommit):
438         (PatchesInCommitQueue):
439         (PatchesToCommitQueue):
440         (PatchesToCommitQueue.__init__):
441         (PatchesToReview):
442         (PatchesToReview.__init__):
443         (PatchesToReview.execute):
444         (WhatBroke):
445         (ResultsFor):
446         (FailureReason):
447         (FindFlakyTests):
448         (TreeStatus):
449         (CrashLog):
450         (PrintExpectations):
451         (PrintExpectations.__init__):
452         (PrintBaselines):
453         (PrintBaselines.__init__):
454         * Scripts/webkitpy/tool/commands/queues.py:
455         (AbstractQueue.__init__):
456         * Scripts/webkitpy/tool/commands/rebaseline.py:
457         (AbstractRebaseliningCommand):
458         * Scripts/webkitpy/tool/commands/suggestnominations.py:
459         (SuggestNominations):
460         (SuggestNominations.__init__):
461         * Scripts/webkitpy/tool/commands/upload.py:
462         (CommitMessageForCurrentDiff):
463         (CommitMessageForCurrentDiff.__init__):
464         (CleanPendingCommit):
465         (CleanReviewQueue):
466         (AssignToCommitter):
467         (PostCommits):
468         (PostCommits.__init__):
469         (MarkBugFixed):
470         (MarkBugFixed.__init__):
471         (CreateBug):
472         (CreateBug.__init__):
473         * Scripts/webkitpy/tool/multicommandtool.py:
474         (Command):
475         (Command.__init__):
476         (Command.main):
477         (HelpCommand):
478         (HelpCommand.__init__):
479         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
480         (TrivialCommand):
481         (TrivialCommand.__init__):
482         (LikesToRetry):
483         (LikesToRetry.__init__):
484         (CommandTest.test_name_with_arguments):
485         (CommandTest.test_required_arguments):
486         (test_command_help):
487
488 2013-04-13  Ed Bartosh  <bartosh@gmail.com>
489
490         [EFL] --minimal build fails with error: 'ViewModeInvalid' is not a member of 'WebCore::Page'
491         https://bugs.webkit.org/show_bug.cgi?id=114048
492
493         Reviewed by Gyuyoung Kim.
494
495         Wrapped view media related code in #if ENABLE(VIEW_MODE_CSS_MEDIA)
496
497         * DumpRenderTree/efl/TestRunnerEfl.cpp:
498         (TestRunner::setViewModeMediaFeature):
499
500 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
501
502         Merge watchlistloader into host since it's an unnecessary indirection
503         https://bugs.webkit.org/show_bug.cgi?id=114555
504
505         Reviewed by Antti Koivisto.
506
507         We don't need a class to load a file.
508
509         * Scripts/webkitpy/common/host.py:
510         (Host.watch_list):
511         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Removed.
512         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Removed.
513
514 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
515
516         Rename JSONResultsGeneratorBase to JSONResultsGenerator
517         https://bugs.webkit.org/show_bug.cgi?id=114553
518
519         Reviewed by Philippe Normand.
520
521         Renamed now that we've got rid of the old JSONResultsGenerator in r148352.
522
523         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
524         (JSONLayoutResultsGenerator):
525         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
526         (JSONResultsGenerator):
527         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
528         (JSONGeneratorTest._test_json_generation):
529         (JSONGeneratorTest._verify_json_results):
530
531 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
532
533         Remove more Chromium specific code from webkitpy
534         https://bugs.webkit.org/show_bug.cgi?id=114552
535
536         Reviewed by Philippe Normand.
537
538         * Scripts/webkitpy/common/host.py:
539         (Host.checkout):
540         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
541         (JSONResultsGeneratorBase):
542         (JSONResultsGeneratorBase.__init__):
543         (JSONResultsGeneratorBase._is_results_all_of_type):
544         * Scripts/webkitpy/layout_tests/port/base.py:
545         (Port):
546         (Port.expected_filename):
547         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
548         (PerfTestsRunner._parse_args):
549         * Scripts/webkitpy/tool/commands/queues.py:
550         (PatchProcessingQueue._new_port_name_from_old):
551         (CommitQueue.did_pass_testing_ews):
552         * Scripts/webkitpy/tool/commands/rebaseline.py:
553         (RebaselineTest._results_url):
554         (Rebaseline._builder_with_name):
555         * Scripts/webkitpy/tool/mocktool.py:
556         (MockTool.irc):
557
558 2013-04-13  Zan Dobersek  <zdobersek@igalia.com>
559
560         Fix flakiness dashboard unit test failures
561         https://bugs.webkit.org/show_bug.cgi?id=114518
562
563         Reviewed by Ryosuke Niwa.
564
565         Fix the current failures in unit tests for the flakiness dashboard by adjusting failing
566         test cases to simulate loading the builders list from the webkit.org build master, replacing
567         the Chromium builders and platforms that are used in tests with builders and platforms for the
568         Apple Mac Lion WebKit2 port, and removing two test cases that were testing Chromium-specific
569         functionality of the dashboard.
570
571         This is sort of an interlude to the flakiness dashboard cleanup, with the removal of Chromium-specific
572         code and hopefully general simplification of the dashboard codebase coming in near future.
573
574         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
575         (resetGlobals):
576         (test):
577         * TestResultServer/static-dashboards/loader_unittests.js:
578
579 2013-04-12  David Kilzer  <ddkilzer@apple.com>
580
581         BUILD FIX: Make AccessibilityUIElementIOS.mm build on iOS
582
583         Reviewed by Chris Fleizach.
584
585         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Declare
586         -_accessibilityPath from the WebAccessibilityObjectWrapper
587         class.
588         (_CGPathEnumerationIteration): Remove unused CGPoint* variable.
589
590 2013-04-12  Jeffrey Pfau  <jpfau@apple.com>
591
592         Unreviewed, remove an old email address for myself.
593
594         * Scripts/webkitpy/common/config/committers.py:
595
596 2013-04-12  Adenilson Cavalcanti  <cavalcantii@gmail.com>
597
598         [WK2] WebPageProxy loadURL() won't work when called just after terminateProcess()
599         https://bugs.webkit.org/show_bug.cgi?id=110743
600
601         Reviewed by Benjamin Poulain.
602
603         Adding a new test file to check if loading a page just after WebProcess
604         has crashed (or was terminated) works. The test executes the
605         following steps (Load, Crash, Load), thus stressing WebProcess
606         reattach and process termination code path.
607
608         * TestWebKitAPI/GNUmakefile.am:
609         * TestWebKitAPI/PlatformEfl.cmake:
610         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
611         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
612         (TestWebKitAPI::setPageLoaderClient):
613         (TestWebKitAPI::TEST):
614         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Added.
615         (TestWebKitAPI):
616         (WebKit2CrashLoader):
617         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
618         (TestWebKitAPI::WebKit2CrashLoader::loadUrl):
619         (TestWebKitAPI::WebKit2CrashLoader::crashWebProcess):
620         (TestWebKitAPI::didFinishLoad):
621         (TestWebKitAPI::TEST):
622         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
623
624 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
625
626         [Mac] REGRESSION: Auto substitution strips new lines
627         https://bugs.webkit.org/show_bug.cgi?id=114537
628
629         Reviewed by Enrica Casucci.
630
631         Add a rule to replace "helloleworld" by "hello\nworld" for testing purpose.
632
633         * DumpRenderTree/mac/DumpRenderTree.mm:
634         (resetDefaultsToConsistentValues):
635
636 2013-04-09  Roger Fong  <roger_fong@apple.com>
637
638         Re-enable WinEWS tests.
639
640         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
641         (WinEWS):
642
643 2013-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
644
645         [GTK] Split GtkAuthenticationDialog in two widgets
646         https://bugs.webkit.org/show_bug.cgi?id=103644
647
648         Reviewed by Xan Lopez.
649
650         * gtk/generate-gtkdoc:
651         (get_webkit2_options): Do not generate api docs for
652         WebKitAuthenticationDialog which is private in WebKit2.
653         (get_webkit1_options): Do not generate api docs for
654         webkitauthenticationdialog which is private in WebKit1.
655
656 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
657
658         WebKit Queues should capitalize K in Wk2
659         https://bugs.webkit.org/show_bug.cgi?id=114524
660
661         Reviewed by Philippe Normand.
662
663         * QueueStatusServer/model/queues.py:
664         (Queue.display_name):
665
666 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
667
668         [Mac] Enable spellchecking tests added in r141471
669         https://bugs.webkit.org/show_bug.cgi?id=108525
670
671         Reviewed by Darin Adler.
672
673         * DumpRenderTree/mac/DumpRenderTree.mm:
674         (createWebViewAndOffscreenWindow):
675         (resetDefaultsToConsistentValues):
676         * WebKitTestRunner/TestController.cpp:
677         (WTR::TestController::resetStateToConsistentValues):
678
679 2013-04-12  Manuel Rego Casasnovas  <rego@igalia.com>
680
681         [GTK] Enable WebKit2 building on GTK EWSs
682         https://bugs.webkit.org/show_bug.cgi?id=114500
683
684         Reviewed by Philippe Normand.
685
686         Add configuration in order to be able to setup GTK EWSs building
687         WebKit2. A new queue gtk-wk2-ews is added.
688
689         * QueueStatusServer/config/queues.py:
690         * Scripts/webkitpy/common/config/ports.py:
691         (DeprecatedPort.port):
692         (GtkWK2Port):
693         (GtkWK2Port.build_webkit_command):
694         (GtkWK2Port.run_webkit_tests_command):
695         * Scripts/webkitpy/common/config/ports_unittest.py:
696         (DeprecatedPortTest.test_gtk_port):
697         (DeprecatedPortTest):
698         (DeprecatedPortTest.test_gtk_wk2_port):
699         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
700         (GtkWK2EWS):
701
702 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
703
704         Remove Chromium scripts
705         https://bugs.webkit.org/show_bug.cgi?id=114492
706
707         Reviewed by Benjamin Poulain.
708
709         * Scripts/run-chromium-webkit-unit-tests: Removed.
710         * Scripts/update-webkit-chromium: Removed.
711
712 2013-04-12  Commit Queue  <rniwa@webkit.org>
713
714         Unreviewed, rolling out r148262.
715         http://trac.webkit.org/changeset/148262
716         https://bugs.webkit.org/show_bug.cgi?id=114493
717
718         Cairo dep should now build, rolling r148247 back in (Requested
719         by zdobersek on #webkit).
720
721         * Scripts/webkitdirs.pm:
722         (buildAutotoolsProject):
723         * gtk/jhbuild.modules:
724
725 2013-04-11  Commit Queue  <rniwa@webkit.org>
726
727         Unreviewed, rolling out r148247.
728         http://trac.webkit.org/changeset/148247
729         https://bugs.webkit.org/show_bug.cgi?id=114490
730
731         Cairo dep fails to build on builders due to missing EGL
732         headers (Requested by zdobersek on #webkit).
733
734         * Scripts/webkitdirs.pm:
735         (buildAutotoolsProject):
736         * gtk/jhbuild.modules:
737
738 2013-04-11  Martin Robinson  <mrobinson@igalia.com>
739
740         [GTK] Add accelerated 2D canvas support using cairo-gl
741         https://bugs.webkit.org/show_bug.cgi?id=104672
742
743         Reviewed by Alejandro G. Castro.
744
745         Since the value of ACCELERATED_2D_CANVAS relies on some somewhat unusual
746         dependencies, don't override value of the setting determined by configure.
747         This will make it easier for people using build-webkit, but not the
748         WebKit JHBuild.
749
750         * Scripts/webkitdirs.pm:
751         (buildAutotoolsProject): Add a blacklist for settings to never override.
752         * gtk/jhbuild.modules: Build CairoGL.
753
754 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
755
756         build.webkit.org should link to webkit-queues instead of webkit-commit-queue
757         https://bugs.webkit.org/show_bug.cgi?id=114477
758
759         Reviewed by Benjamin Poulain.
760
761         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
762
763 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
764
765         Leaks builder should not be triggered upon new commits
766         https://bugs.webkit.org/show_bug.cgi?id=114475
767
768         Reviewed by Jessie Berlin.
769
770         Don't trigger them on new checkins. Wait for Mountain Lion (Build), which already triggers
771         the leak builder when builds are done.
772
773         * BuildSlaveSupport/build.webkit.org-config/config.json:
774
775 2013-04-11  Kalev Lember  <kalevlember@gmail.com>
776
777         [GTK] Windows build failure after r136056
778         https://bugs.webkit.org/show_bug.cgi?id=114121
779
780         Reviewed by Martin Robinson.
781
782         * TestWebKitAPI/config.h: Make sure defines are correct for other
783         Windows ports than apple-win.
784
785 2013-04-11  Ojan Vafai  <ojan@chromium.org>
786
787         Remove myself from watchlists.
788         * Scripts/webkitpy/common/config/watchlist:
789
790 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
791
792         Build fix. Don't hard-code queues.webkit.org at least during the transition.
793
794         * QueueStatusServer/templates/statusbubble.html:
795
796 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
797
798         Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
799         https://bugs.webkit.org/show_bug.cgi?id=114397
800
801         Reviewed by Benjamin Poulain.
802
803         Reland the patch since Alan appears to have finished the migration.
804
805         * Scripts/webkitpy/common/net/statusserver.py:
806         (StatusServer):
807
808 2013-04-11  Brian Holt  <brian.holt@samsung.com>
809
810         [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
811         https://bugs.webkit.org/show_bug.cgi?id=76796
812
813         Reviewed by Chris Fleizach.
814
815         Make the Gtk window for the DRT a toplevel so that it gets the
816         focus from the window manager when the test starts.
817
818         * DumpRenderTree/gtk/DumpRenderTree.cpp:
819         (main):
820
821 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
822
823         Use CSS4 image-rendering to determing image scaling quality
824         https://bugs.webkit.org/show_bug.cgi?id=113405
825
826         Reviewed by Simon Fraser.
827
828         Introduce new flag to enable experimental support for CSS4 Images.
829
830         * Scripts/webkitperl/FeatureList.pm:
831
832 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
833
834         Remove code for Chromium from wkbuild.py
835         https://bugs.webkit.org/show_bug.cgi?id=114423
836
837         Reviewed by Benjamin Poulain.
838
839         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
840         (_should_file_trigger_build):
841         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
842         (ShouldBuildTest):
843
844 2013-04-11  Philippe Normand  <pnormand@igalia.com>
845
846         Unreviewed, update my IRC nickname.
847
848         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
849
850 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
851
852         Remove the rest of Chromium code from webkitpy
853         https://bugs.webkit.org/show_bug.cgi?id=114420
854
855         Reviewed by Benjamin Poulain.
856
857         * Scripts/webkitpy/common/config/urls.py:
858         (view_revision_url):
859         * Scripts/webkitpy/common/host.py:
860         (Host._engage_awesome_locale_hacks):
861         (Host.initialize_scm):
862         (Host):
863         * Scripts/webkitpy/common/host_mock.py:
864         (MockHost.__init__):
865         (MockHost.checkout):
866         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
867         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
868         (JSONResultsGeneratorBase._insert_generic_metadata):
869         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
870         (TestExpectationParser._tokenize_line):
871         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
872         (ExpectationSyntaxTests.test_bare_name_and_bugs):
873         (ExpectationSyntaxTests.test_warnings):
874         * Scripts/webkitpy/layout_tests/port/base.py:
875         (Port.skips_perf_test):
876         (Port.path_to_test_expectations_file):
877         (Port._port_flag_for_scripts):
878         * Scripts/webkitpy/style/checkers/cpp.py:
879         (check_function_definition):
880         (check_include_line):
881         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
882         (OrderOfIncludesTest.test_check_wtf_includes):
883         (WebKitStyleTest.test_webkit_export_check):
884         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
885         (TestExpectationsTestCase.test_valid_expectations):
886         * Scripts/webkitpy/tool/bot/irc_command.py:
887         (Rollout.execute):
888         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
889         (IRCCommandTest.test_whois):
890         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
891         (IRCBotTest.test_help):
892         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
893         (SheriffBotTest.test_command_aliases):
894
895 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
896
897         roll-chromium-deps doesn't roll DEPS
898         https://bugs.webkit.org/show_bug.cgi?id=114421
899
900         Reviewed by Antti Koivisto.
901
902         Roll DEPS. Rolling DEPS. Rolled DEPS.
903
904         * Scripts/webkitpy/tool/bot/irc_command.py:
905         (RollChromiumDEPS.execute):
906
907 2013-04-11  Glenn Adams  <glenn@skynav.com>
908
909         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
910         https://bugs.webkit.org/show_bug.cgi?id=114418
911
912         Reviewed by Ryosuke Niwa.
913
914         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
915         (MockSCM.add): Remove optional remove_exit_code argument.
916         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
917         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
918         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
919         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
920
921 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
922
923         Fix roll-chromium-deps and hi.
924
925         * Scripts/webkitpy/tool/bot/irc_command.py:
926         (Hi.execute):
927         (RollChromiumDEPS.execute):
928
929 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
930
931         Remove webkitpy code to roll Chromium DEPS
932         https://bugs.webkit.org/show_bug.cgi?id=114415
933
934         Reviewed by Benjamin Poulain.
935
936         Removed the code to roll Chromium DEPS in WebKit.
937
938         * Scripts/webkitpy/common/checkout/checkout.py:
939         (Checkout.bug_id_for_this_commit):
940         * Scripts/webkitpy/common/checkout/checkout_mock.py:
941         (MockCheckout.commit_message_for_this_commit):
942         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
943         (CheckoutTest.test_suggested_reviewers):
944         * Scripts/webkitpy/common/checkout/deps.py: Removed.
945         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
946         * Scripts/webkitpy/tool/bot/irc_command.py:
947         (RollChromiumDEPS): Teach webkitbot a sense of humor.
948         (RollChromiumDEPS.execute):
949         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
950         (IRCCommandTest.test_create_bug):
951         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
952         (IRCBotTest.test_revert):
953         * Scripts/webkitpy/tool/bot/sheriff.py:
954         (Sheriff.post_rollout_patch):
955         * Scripts/webkitpy/tool/commands/__init__.py:
956         * Scripts/webkitpy/tool/commands/roll.py: Removed.
957         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
958         * Scripts/webkitpy/tool/steps/__init__.py:
959         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
960         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
961         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
962
963 2013-04-11  Glenn Adams  <glenn@skynav.com>
964
965         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
966         https://bugs.webkit.org/show_bug.cgi?id=114386
967
968         Reviewed by Benjamin Poulain.
969
970         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
971         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
972         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
973         by default and to return exit code 1 if a file/dir had already been added.
974
975         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
976         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
977         * Scripts/webkitpy/common/checkout/scm/svn.py:
978         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
979
980 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
981
982         Unreviewed.
983
984         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
985
986 2013-04-10  Glenn Adams  <glenn@skynav.com>
987
988         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
989         https://bugs.webkit.org/show_bug.cgi?id=114410
990
991         Reviewed by Ryosuke Niwa.
992
993         * Scripts/webkitpy/common/checkout/scm/git.py:
994         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
995         * Scripts/webkitpy/common/checkout/scm/scm.py:
996         (SCM.add): Remove optional return_exit_code argument.
997         (SCM.add_list): Remove optional return_exit_code argument.
998         * Scripts/webkitpy/common/checkout/scm/svn.py:
999         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
1000
1001 2013-04-10  Eric Seidel  <eric@webkit.org>
1002
1003         Remove myself from the watchlists, I'm getting too much bug mail. :)
1004
1005         * Scripts/webkitpy/common/config/watchlist:
1006
1007 2013-04-10  Commit Queue  <rniwa@webkit.org>
1008
1009         Unreviewed, rolling out r148158.
1010         http://trac.webkit.org/changeset/148158
1011         https://bugs.webkit.org/show_bug.cgi?id=114405
1012
1013         We need to migrate status data (Requested by rniwa on
1014         #webkit).
1015
1016         * Scripts/webkitpy/common/net/statusserver.py:
1017         (StatusServer):
1018
1019 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
1020
1021         Mass remove all the empty directories
1022
1023         Rubberstamped by Ryosuke Niwa.
1024
1025         * BuildSlaveSupport/gtk/crashmon/log: Removed.
1026         * BuildSlaveSupport/gtk/xvfb/log: Removed.
1027         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
1028         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
1029         * MiniBrowser/gtk/WebBundle: Removed.
1030         * MiniBrowser/win: Removed.
1031         * QtTestPlatformPlugin/mac: Removed.
1032         * Scripts/webkitpy/tool/bot/testdata: Removed.
1033         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
1034         * efl/ImageDiff: Removed.
1035         * iExploder/htdocs: Removed.
1036         * iExploder/iexploder-1.7.2/output: Removed.
1037         * iExploder/tools: Removed.
1038         * qmake/config.tests/libexecdir: Removed.
1039         * qmake/config.tests/libjpeg: Removed.
1040         * qmake/config.tests/libpng: Removed.
1041
1042 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1043
1044         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
1045         https://bugs.webkit.org/show_bug.cgi?id=114397
1046
1047         Reviewed by Benjamin Poulain.
1048
1049         * Scripts/webkitpy/common/net/statusserver.py:
1050         (StatusServer):
1051
1052 2013-04-10  Adam Barth  <abarth@webkit.org>
1053
1054         Remove abarth from watchlists
1055         https://bugs.webkit.org/show_bug.cgi?id=114390
1056
1057         Reviewed by Ryosuke Niwa.
1058
1059         I'm trying to cut down on the amount of bugmail I get so that I'll have
1060         more of a chance to notice a piece of bugmail directed at me.
1061
1062         * Scripts/webkitpy/common/config/watchlist:
1063
1064 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1065
1066         webkit-test-results.appspot.com loads the dashboard for Chromium by default
1067         https://bugs.webkit.org/show_bug.cgi?id=114381
1068
1069         Reviewed by Benjamin Poulain.
1070
1071         Changed the defaults.
1072
1073         * TestResultServer/static-dashboards/builders.js:
1074         * TestResultServer/static-dashboards/dashboard_base.js:
1075         (currentBuilderGroupCategory):
1076
1077 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1078
1079         Remove Chromium EWS bots from the queue status server
1080         https://bugs.webkit.org/show_bug.cgi?id=113988
1081
1082         Reviewed by Benjamin Poulain.
1083
1084         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
1085
1086         * QueueStatusServer/app.yaml:
1087         * QueueStatusServer/config/queues.py:
1088         * QueueStatusServer/model/queues.py:
1089         (Queue.short_name):
1090         (Queue.display_name):
1091         * QueueStatusServer/model/queues_unittest.py:
1092         (QueueTest.test_short_name):
1093         (QueueTest.test_display_name):
1094         (QueueTest.test_name_with_underscores):
1095         * QueueStatusServer/templates/activebots.html:
1096
1097 2013-04-10  Ojan Vafai  <ojan@chromium.org>
1098
1099         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
1100         https://bugs.webkit.org/show_bug.cgi?id=114370
1101
1102         Reviewed by Ryosuke Niwa.
1103
1104         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
1105         Unfortunately, there's no way to test this until this is committed and there is
1106         a master restart.
1107
1108         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1109         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1110         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1111         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1112         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1113         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1114         * TestResultServer/generate_builders_json.py:
1115         * TestResultServer/static-dashboards/dashboard_base.js:
1116         * TestResultServer/static-dashboards/loader.js:
1117
1118 2013-04-10  Glenn Adams  <glenn@skynav.com>
1119
1120         [Qt] Fix regression to test-webkitpy.
1121         https://bugs.webkit.org/show_bug.cgi?id=114368
1122
1123         Reviewed by Ryosuke Niwa.
1124
1125         * Scripts/webkitpy/layout_tests/port/factory.py:
1126         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
1127         (PortFactory.get): Remove obsolete chromium port related code.
1128         * Scripts/webkitpy/layout_tests/port/mac.py:
1129         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
1130
1131 2013-04-10  Anders Carlsson  <andersca@apple.com>
1132
1133         Remove unneeded headers from FrameLoader.h
1134         https://bugs.webkit.org/show_bug.cgi?id=114223
1135
1136         Reviewed by Geoffrey Garen.
1137
1138         Add back headers implicitly included by other headers.
1139
1140         * WebKitTestRunner/WorkQueueManager.cpp:
1141
1142 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1143
1144         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
1145         https://bugs.webkit.org/show_bug.cgi?id=114365
1146
1147         Reviewed by Martin Robinson.
1148
1149         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
1150         The patch addresses crashes in the tally_event_reply method. It is already committed into the
1151         at-spi2-atk source tree and will be available with the next stable release, after which the
1152         patch should be removed and the dependency version bumped.
1153
1154         * gtk/jhbuild.modules:
1155         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
1156
1157 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
1158
1159         [WinCairo] Unreviewed build fix. Correct DropBox download link.
1160
1161         * Scripts/update-webkit-wincairo-libs: Revise download URL to
1162         match change in DropBox server behavior.
1163
1164 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
1165
1166         Removed an annoying message from svn-create-patch
1167         https://bugs.webkit.org/show_bug.cgi?id=114332
1168
1169         Reviewed by Alexey Proskuryakov.
1170
1171         I see this message basically every time I write a patch, so it must not
1172         be true.
1173
1174         * Scripts/svn-create-patch:
1175         (generateDiff):
1176
1177 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
1178
1179         [GTK] Add support for Page Visibility
1180         https://bugs.webkit.org/show_bug.cgi?id=97324
1181
1182         Reviewed by Sam Weinig.
1183
1184         Implemented test runner API for page visibility layout tests.
1185
1186         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1187         (TestRunner::resetPageVisibility):
1188         (TestRunner::setPageVisibility):
1189         * Scripts/webkitperl/FeatureList.pm:
1190
1191 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1192
1193         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
1194         https://bugs.webkit.org/show_bug.cgi?id=114342
1195
1196         Reviewed by Gyuyoung Kim.
1197
1198         Commit 148033 only added an implementation for the Mac port, which made
1199         other ports fail most tests since loading the injected bundle failed
1200         with a missing symbol.
1201
1202         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1203         (WTR::AccessibilityUIElement::pathDescription):
1204
1205 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
1206
1207         [EFL] Add spell checking option to MiniBrowser
1208         https://bugs.webkit.org/show_bug.cgi?id=114282
1209
1210         Reviewed by Ryosuke Niwa.
1211
1212         Spell checking is enabled by adding a flag (t/text-checking)
1213         with launching MiniBrowser.
1214
1215         * MiniBrowser/efl/main.c:
1216         (window_create):
1217         (elm_main):
1218
1219 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1220
1221         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
1222         https://bugs.webkit.org/show_bug.cgi?id=113281
1223
1224         Reviewed by Darin Adler.
1225
1226         * Scripts/run-gtk-tests:
1227         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
1228
1229 2013-04-09  Glenn Adams  <glenn@skynav.com>
1230
1231         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
1232
1233         Unreviewed.
1234
1235         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1236         (RunTest.test_build_check):
1237
1238 2013-04-09  Glenn Adams  <glenn@skynav.com>
1239
1240         [webkitpy] Remove chromium ports.
1241         https://bugs.webkit.org/show_bug.cgi?id=114326
1242
1243         Reviewed by Dirk Pranke.
1244
1245         As a side effect, also:
1246
1247         - remove chromium builders from webkitpy.layout_tests.port.builders
1248         - remove chromium builders from rebaseline
1249         - rewrite chromium dependent tests in rebaseline_unittest
1250         - remove chromium platform from garden-o-matic
1251         - select apple platform as default platform in garden-o-matic
1252         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
1253
1254         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1255         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1256         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1257         (BaselineOptimizerTest.test_move_baselines):
1258         (BaselineOptimizerTest.test_efl):
1259         (BaselineOptimizerTest.test_no_add_mac_future):
1260         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1261         (BaselineOptimizerTest.test_common_directory_includes_root):
1262         (BaselineOptimizerTest.test_complex_shadowing):
1263         (BaselineOptimizerTest.test_virtual_ports_filtered):
1264         * Scripts/webkitpy/layout_tests/port/builders.py:
1265         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
1266         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
1267         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
1268         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
1269         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
1270         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
1271         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
1272         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
1273         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
1274         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
1275         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
1276         * Scripts/webkitpy/layout_tests/port/factory.py:
1277         (platform_options):
1278         (PortFactory):
1279         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1280         (FactoryTest.test_qt):
1281         (FactoryTest.test_get_from_builder_name):
1282         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1283         (RunTest.test_build_check):
1284         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1285         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1286         * Scripts/webkitpy/tool/commands/rebaseline.py:
1287         (Rebaseline._builders_to_pull_from):
1288         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1289         (_BaseTestCase):
1290         (_BaseTestCase.setUp):
1291         (TestRebaselineTest.setUp):
1292         (TestRebaselineTest.test_baseline_directory):
1293         (test_rebaseline_updates_expectations_file):
1294         (test_rebaseline_does_not_include_overrides):
1295         (test_rebaseline_test):
1296         (test_rebaseline_test_and_print_scm_changes):
1297         (test_rebaseline_and_copy_test):
1298         (test_rebaseline_and_copy_test_no_existing_result):
1299         (test_rebaseline_and_copy_test_with_lion_result):
1300         (test_rebaseline_and_copy_no_overwrite_test):
1301         (TestRebaselineExpectations.test_rebaseline_expectations):
1302
1303 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1304
1305         newcommitbot (WKR) requires a subversion checkout
1306         https://bugs.webkit.org/show_bug.cgi?id=114309
1307
1308         Reviewed by Benjamin Poulain.
1309
1310         Directly talk to the subversion server instead of relying on a local checkout.
1311         This allows us to run WKR off of a git clone.
1312
1313         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1314         (NewCommitBot.next_work_item):
1315         (NewCommitBot.process_work_item):
1316
1317 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1318
1319         webkitbot refers to sheriffbot in help
1320         https://bugs.webkit.org/show_bug.cgi?id=114307
1321
1322         Reviewed by Benjamin Poulain.
1323
1324         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
1325
1326         * Scripts/webkitpy/tool/bot/irc_command.py:
1327         (Help):
1328         (Help.execute):
1329         (RollChromiumDEPS.execute):
1330         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1331         (IRCBotTest.test_help):
1332         * Scripts/webkitpy/tool/bot/sheriff.py:
1333         (Sheriff.name):
1334
1335 2013-04-06  Roger Fong  <roger_fong@apple.com>
1336
1337         Kill old processes between runs on WinEWS bots.
1338         Temporarily disable tests to let bots catch up again.
1339
1340         * EWSTools/start-queue-win.sh:
1341         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1342         (WinEWS):
1343
1344 2013-04-09  Glenn Adams  <glenn@skynav.com>
1345
1346         [webkitpy] Remove chromium deprecated port support.
1347         https://bugs.webkit.org/show_bug.cgi?id=114228
1348
1349         Reviewed by Ryosuke Niwa.
1350
1351         * Scripts/webkitpy/common/config/ports.py:
1352         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
1353         (ChromiumPort): Removed.
1354         (ChromiumAndroidPort): Removed.
1355         (ChromiumXVFBPort): Removed.
1356         * Scripts/webkitpy/common/config/ports_unittest.py:
1357         (DeprecatedPortTest.test_chromium_port): Removed.
1358         (DeprecatedPortTest.test_chromium_android_port): Removed.
1359         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
1360         * Scripts/webkitpy/tool/steps/update_unittest.py:
1361         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
1362         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
1363
1364 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
1365
1366         AX: The bounding paths should be made available through accessibility
1367         https://bugs.webkit.org/show_bug.cgi?id=113817
1368
1369         Reviewed by David Kilzer.
1370
1371         Add a pathDescription property for testing so that it's possible
1372         to verify that a path is being returned correctly.
1373
1374         * DumpRenderTree/AccessibilityUIElement.cpp:
1375         (getPathDescriptionCallback):
1376         (AccessibilityUIElement::pathDescription):
1377         (AccessibilityUIElement::getJSClass):
1378         * DumpRenderTree/AccessibilityUIElement.h:
1379         (AccessibilityUIElement):
1380         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1381         (_CGPathEnumerationIteration):
1382         (AccessibilityUIElement::pathDescription):
1383         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1384         (AccessibilityUIElement::pathDescription):
1385         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1386         (WTR::AccessibilityUIElement::pathDescription):
1387         (WTR):
1388         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1389         (AccessibilityUIElement):
1390         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1391         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1392         (WTR::AccessibilityUIElement::pathDescription):
1393         (WTR):
1394
1395 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1396
1397         [EFL] Declare TEST_THEME_DIR in a single place.
1398         https://bugs.webkit.org/show_bug.cgi?id=114285
1399
1400         Reviewed by Anders Carlsson.
1401
1402         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
1403
1404         * DumpRenderTree/efl/CMakeLists.txt:
1405         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1406         (DumpRenderTreeChrome::createView):
1407         (DumpRenderTreeChrome::createInspectorView):
1408         (DumpRenderTreeChrome::initialize):
1409         (DumpRenderTreeChrome::onDownloadRequest):
1410         * EWebLauncher/CMakeLists.txt:
1411         * EWebLauncher/main.c:
1412         (findThemePath):
1413         * EWebLauncher/url_bar.c:
1414         (url_bar_add):
1415         * MiniBrowser/efl/CMakeLists.txt:
1416         * MiniBrowser/efl/main.c:
1417         (window_create):
1418         * TestWebKitAPI/PlatformEfl.cmake:
1419         * TestWebKitAPI/efl/PlatformWebView.cpp:
1420         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1421         * WebKitTestRunner/PlatformEfl.cmake:
1422         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1423         (WTR::PlatformWebView::PlatformWebView):
1424
1425 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
1426
1427         [GTK][AC] upversion of clutter and its dependecy
1428         https://bugs.webkit.org/show_bug.cgi?id=114016
1429
1430         Reviewed by Gustavo Noronha Silva.
1431
1432         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
1433
1434         * gtk/jhbuild-optional.modules:
1435
1436 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1437
1438         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
1439         https://bugs.webkit.org/show_bug.cgi?id=89875
1440
1441         Reviewed by Maciej Stachowiak.
1442
1443         Add unit tests to verify if the handling of the open, openat, creat syscall
1444         is being done right. We check if the Read/Write/ReadAndWrite permissions
1445         are respected, if the canonical path is being resolved and if
1446         the permissions are falling back to the topmost parent directory with a
1447         policy set when the directory being opened has no policy.
1448
1449         We also test if any attempt of blocking SIGSYS is silently ignored.
1450         SIGSYS cannot be blocked because in it's handler is where we hook
1451         syscalls to the broker process.
1452
1453         Also added libseccomp to EFL's jhbuild to make the life of developers
1454         willing to help easier.
1455
1456         * Scripts/webkitperl/FeatureList.pm:
1457         * TestWebKitAPI/PlatformEfl.cmake:
1458         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
1459         (TestWebKitAPI):
1460         (SeccompEnvironment):
1461         (TestWebKitAPI::SeccompEnvironment::SetUp):
1462         (TestWebKitAPI::SeccompEnvironment::TearDown):
1463         (TestWebKitAPI::dummyHandler):
1464         (TestWebKitAPI::TEST):
1465         (TestWebKitAPI::stressTest):
1466         * efl/jhbuild.modules:
1467         * qmake/mkspecs/features/features.pri:
1468
1469 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1470
1471         REGRESSION: Autocorrection doesn't work in DumpRenderTree
1472         https://bugs.webkit.org/show_bug.cgi?id=113846
1473
1474         Reviewed by Alexey Proskuryakov.
1475
1476         The problem was that we were replacing NSSpellCheck's dictionary with our own
1477         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
1478
1479         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
1480         and "would" respectively in DumpRenderTree.
1481
1482         * DumpRenderTree/mac/DumpRenderTree.mm:
1483         (resetDefaultsToConsistentValues):
1484
1485 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
1486
1487         Remove the gyp files for Tools
1488         https://bugs.webkit.org/show_bug.cgi?id=114248
1489
1490         Reviewed by Ryosuke Niwa.
1491
1492         * DumpRenderTree/DumpRenderTree.gyp: Removed.
1493         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
1494         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
1495         * DumpRenderTree/DumpRenderTree.gypi: Removed.
1496         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
1497         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
1498         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
1499         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
1500
1501 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1502
1503         WKR (new-commit-bot) is too slow
1504         https://bugs.webkit.org/show_bug.cgi?id=110087
1505
1506         Reviewed by Geoffrey Garen.
1507
1508         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
1509         Just run "svn log -r <revision>" instead to cut down the delay.
1510
1511         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
1512
1513         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1514         (NewCommitBot):
1515         (NewCommitBot.next_work_item):
1516         (NewCommitBot._is_empty_log):
1517         (NewCommitBot._update_checkout):
1518
1519 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1520
1521         Build fix. Can't remove appendCustomBuildFlags.
1522
1523         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1524         (appendCustomBuildFlags):
1525
1526 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1527
1528         Remove Chromium builders from build.webkit.org
1529         https://bugs.webkit.org/show_bug.cgi?id=113990
1530
1531         Reviewed by Benjamin Poulain.
1532
1533         Removed.
1534
1535         * BuildSlaveSupport/build.webkit.org-config/config.json:
1536         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1537         (InstallGtkDependencies):
1538         (RunUnitTests.start):
1539         (RunWebKit2Tests.start):
1540         (Factory.__init__):
1541         (unitTestsSupported):
1542         (TestFactory.__init__):
1543         (BuildAndTestFactory.__init__):
1544         (BuildAndPerfTestFactory.__init__):
1545         (BuildAndPerfTestWebKit2Factory.__init__):
1546         (DownloadAndPerfTestFactory.__init__):
1547         (loadBuilderConfig):
1548         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1549
1550 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
1551
1552         Remove HTML Notification
1553         https://bugs.webkit.org/show_bug.cgi?id=114231
1554
1555         Reviewed by Ryosuke Niwa.
1556
1557         * qmake/mkspecs/features/features.pri:
1558
1559 2013-04-08  Glenn Adams  <glenn@skynav.com>
1560
1561         Remove chromium EWS support, and fix broken test.
1562         https://bugs.webkit.org/show_bug.cgi?id=114221
1563
1564         Reviewed by Ryosuke Niwa.
1565
1566         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1567         (AbstractChromiumEWS): Removed.
1568         (ChromiumLinuxEWS): Removed.
1569         (ChromiumLinuxDebugEWS): Removed.
1570         (ChromiumWindowsEWS): Removed.
1571         (ChromiumAndroidEWS): Removed.
1572         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1573         (EarlyWarningSystemTest): Fix misspelled class name.
1574         (test_ewses): Fix entry point name to ensure test is run.
1575
1576 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
1577
1578         [WIN] Remove WebKit2 source code
1579         https://bugs.webkit.org/show_bug.cgi?id=114096
1580
1581         Reviewed by Anders Carlsson.
1582
1583         Remove the windows specific parts of the MiniBrowser.
1584
1585         * MiniBrowser/MiniBrowser.vcproj: Removed.
1586         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
1587         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
1588         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
1589         * MiniBrowser/win/BrowserView.cpp: Removed.
1590         * MiniBrowser/win/BrowserView.h: Removed.
1591         * MiniBrowser/win/BrowserWindow.cpp: Removed.
1592         * MiniBrowser/win/BrowserWindow.h: Removed.
1593         * MiniBrowser/win/MiniBrowser.cpp: Removed.
1594         * MiniBrowser/win/MiniBrowser.h: Removed.
1595         * MiniBrowser/win/MiniBrowser.rc: Removed.
1596         * MiniBrowser/win/main.cpp: Removed.
1597         * MiniBrowser/win/resource.h: Removed.
1598         * MiniBrowser/win/stdafx.cpp: Removed.
1599         * MiniBrowser/win/stdafx.h: Removed.
1600
1601 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1602
1603         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
1604
1605         * Scripts/webkitpy/common/config/irc.py:
1606
1607 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
1608
1609         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
1610         https://bugs.webkit.org/show_bug.cgi?id=113139
1611
1612         Reviewed by Anders Carlsson.
1613
1614         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1615         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
1616         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1617         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
1618         (ToStringAndValueOfObject):
1619         (ToStringAndValueOfObject::ToStringAndValueOfObject):
1620         (ScriptableObject):
1621         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
1622         (ToStringAndValueOfObject::ScriptableObject::invoke):
1623         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
1624         (ToStringAndValueOfObject::NPP_GetValue):
1625         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1626         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1627         * GNUmakefile.am:
1628
1629 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
1630
1631         [GTK] Bump gnome-themes-standard to 3.6.0
1632         https://bugs.webkit.org/show_bug.cgi?id=114155
1633
1634         Reviewed by Martin Robinson.
1635
1636         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
1637         dependency of gnome-themes-standard accordingly.
1638
1639 2013-04-08  David Levin  <levin@chromium.org>
1640
1641         Remove my watchlist entries.
1642         https://bugs.webkit.org/show_bug.cgi?id=114180
1643
1644         Reviewed by Adam Barth.
1645
1646         * Scripts/webkitpy/common/config/committers.py:
1647         * Scripts/webkitpy/common/config/watchlist:
1648
1649 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1650
1651         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
1652         https://bugs.webkit.org/show_bug.cgi?id=114161
1653
1654         Reviewed by Gyuyoung Kim.
1655
1656         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
1657         as it is crashing due to Bug 111074.
1658
1659         * TestWebKitAPI/PlatformEfl.cmake:
1660
1661 2013-04-07  David Kilzer  <ddkilzer@apple.com>
1662
1663         Remove the rest of SVG_DOM_OBJC_BINDINGS
1664         <http://webkit.org/b/114112>
1665
1666         Reviewed by Geoffrey Garen.
1667
1668         * Scripts/webkitperl/FeatureList.pm:
1669         - Remove --svg-dom-objc-bindings switch.
1670         * qmake/mkspecs/features/features.pri:
1671         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
1672
1673 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
1674
1675         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
1676         https://bugs.webkit.org/show_bug.cgi?id=114089
1677
1678         Reviewed by Chris Fleizach.
1679
1680         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
1681         * DumpRenderTree/AccessibilityController.cpp:
1682         * DumpRenderTree/AccessibilityUIElement.cpp:
1683         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1684         (DumpRenderTreeChrome::DumpRenderTreeChrome):
1685         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1686         (DumpRenderTreeChrome):
1687
1688 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
1689
1690         Build fix after r147857, remove remaining USE(JSC) guards.
1691
1692         Unreviewed.
1693
1694         * DumpRenderTree/config.h:
1695         * TestWebKitAPI/config.h:
1696         * WebKitTestRunner/config.h:
1697
1698 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
1699
1700         Rename sheriffbot to webkitbot
1701         https://bugs.webkit.org/show_bug.cgi?id=114109
1702
1703         Reviewed by Benjamin Poulain.
1704
1705         Renamed since sheriffbot will be used in Blink.
1706
1707         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1708         (SheriffBot):
1709         (SheriffBot.begin_work_queue):
1710
1711 2013-04-06  Oliver Hunt  <oliver@apple.com>
1712
1713         Unify the many and varied stack trace mechanisms, and make the result sane.
1714         https://bugs.webkit.org/show_bug.cgi?id=114072
1715
1716         Reviewed by Filip Pizlo.
1717
1718         The commandline jsc executable no longer requires arguments, so
1719         I've made run-jsc work without them.
1720
1721         * Scripts/run-jsc:
1722
1723 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
1724
1725         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
1726         https://bugs.webkit.org/show_bug.cgi?id=114086
1727
1728         Reviewed by Tim Horton.
1729
1730         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
1731
1732 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
1733
1734         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
1735         https://bugs.webkit.org/show_bug.cgi?id=114083
1736
1737         Reviewed by Ryosuke Niwa.
1738
1739         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
1740         in TestWebKitAPI and WebKitTestRunner.
1741
1742         * TestWebKitAPI/config.h:
1743         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1744         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1745         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1746         (WTR::InjectedBundle::platformInitialize):
1747
1748 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
1749
1750         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
1751         https://bugs.webkit.org/show_bug.cgi?id=114094
1752
1753         Reviewed by Anders Carlsson.
1754
1755         * Scripts/run-jsc:
1756
1757 2013-04-05  Ojan Vafai  <ojan@chromium.org>
1758
1759         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
1760         https://bugs.webkit.org/show_bug.cgi?id=114080
1761
1762         Reviewed by Ryosuke Niwa.
1763
1764         This way, the WebKit and Blink dashboard code can change as appropriate without
1765         needing to consider the other project's needs. This still doesn't update the
1766         buildbots to upload to the new location, or the dashboard code to pull the
1767         results.json files from the new location, but it at least allows for changing the
1768         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
1769
1770         * TestResultServer/app.yaml:
1771
1772 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1773
1774         Re-enable testing on the commit queue
1775         https://bugs.webkit.org/show_bug.cgi?id=114078
1776
1777         Reviewed by Darin Adler.
1778
1779         Re-enabled the feature and the associated tests.
1780
1781         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1782         (CommitQueueTask.run):
1783         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1784         (CommitQueueTaskTest._run_through_task):
1785         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1786         (CommitQueueTest._mock_test_result):
1787
1788 2013-04-05  Oliver Hunt  <oliver@apple.com>
1789
1790         Unify the many and varied stack trace mechanisms, and make the result sane.
1791         https://bugs.webkit.org/show_bug.cgi?id=114072
1792
1793         Reviewed by Filip Pizlo.
1794
1795         The commandline jsc executable no longer requires arguments, so
1796         I've made run-jsc work without them.
1797
1798         * Scripts/run-jsc:
1799
1800 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1801
1802         AX: Make SVG Group containers accessible elements
1803         https://bugs.webkit.org/show_bug.cgi?id=113939
1804
1805         Reviewed by Simon Fraser.
1806
1807         Implement axController.elementAtPoint for iOS.
1808         Implement a correct version of clickPoint for iOS.
1809
1810         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1811         (AccessibilityController::elementAtPoint):
1812         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1813         (AccessibilityUIElement::clickPointX):
1814         (AccessibilityUIElement::clickPointY):
1815
1816 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
1817
1818         Unreviewed, rolling out r147773 and r147774.
1819         http://trac.webkit.org/changeset/147773
1820         http://trac.webkit.org/changeset/147774
1821         https://bugs.webkit.org/show_bug.cgi?id=114056
1822
1823         Causing some exceptions on AppEngine I don't understand
1824         (Requested by rniwa on #webkit).
1825
1826         * QueueStatusServer/config/queues.py:
1827         * QueueStatusServer/model/queues.py:
1828         (Queue.short_name):
1829         (Queue.display_name):
1830         * QueueStatusServer/model/queues_unittest.py:
1831         (QueueTest.test_short_name):
1832         (QueueTest.test_display_name):
1833         (QueueTest.test_name_with_underscores):
1834
1835 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
1836
1837         Fixed run-bindings-tests by removing V8
1838         https://bugs.webkit.org/show_bug.cgi?id=114053
1839
1840         Reviewed by Benjamin Poulain.
1841
1842         * Scripts/run-bindings-tests:
1843         (main):
1844
1845 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1846
1847         Build fix.
1848
1849         * QueueStatusServer/model/queues.py:
1850         (Queue.short_name):
1851         (Queue.display_name):
1852
1853 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
1854
1855         Remove Chromium EWS bots from the queue status server
1856         https://bugs.webkit.org/show_bug.cgi?id=113988
1857
1858         Reviewed by Benjamin Poulain.
1859
1860         Removed Chromium EWS bots.
1861
1862         * QueueStatusServer/config/queues.py:
1863         * QueueStatusServer/model/queues.py:
1864         (Queue.short_name):
1865         (Queue.display_name):
1866         * QueueStatusServer/model/queues_unittest.py:
1867         (QueueTest.test_short_name):
1868         (QueueTest.test_display_name):
1869         (QueueTest.test_name_with_underscores):
1870
1871 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1872
1873         [EFL] Enable indexed database
1874         https://bugs.webkit.org/show_bug.cgi?id=107248
1875
1876         Reviewed by Alexis Menard.
1877
1878         * Scripts/webkitperl/FeatureList.pm:
1879
1880 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
1881
1882         Remove vestiges of Chromium bits from watchlists.
1883         https://bugs.webkit.org/show_bug.cgi?id=114047
1884
1885         Reviewed by Ryosuke Niwa.
1886
1887         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
1888
1889 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
1890
1891         Add James Craig to the contributors list.
1892
1893         * Scripts/webkitpy/common/config/committers.py:
1894
1895 2013-04-04  Kent Tamura  <tkent@chromium.org>
1896
1897         Remove ChromiumPublicApi pattern, and cc/message rules for it.
1898
1899         * Scripts/webkitpy/common/config/watchlist:
1900
1901 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1902
1903         Temporarily disable the Python unittests broken by the commit queue not running layout tests
1904         https://bugs.webkit.org/show_bug.cgi?id=113997
1905
1906         Reviewed by Ryosuke Niwa.
1907
1908         Disable the tests until Ryosuke gets the time and hardware to have
1909         a testing commit-queue.
1910
1911         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1912         (CommitQueueTaskTest):
1913         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1914         (CommitQueueTest):
1915
1916 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1917
1918         Remove Chromium builders from build.webkit.org
1919         https://bugs.webkit.org/show_bug.cgi?id=113990
1920
1921         Reviewed by Benjamin Poulain.
1922
1923         Land the part to disable triggering of Chromium builders first so that we may start
1924         deleting more Chromium code that breaks the update step.
1925
1926         * BuildSlaveSupport/build.webkit.org-config/config.json:
1927
1928 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1929
1930         Remove Chromium's DumpRenderTree
1931         https://bugs.webkit.org/show_bug.cgi?id=113989
1932
1933         Reviewed by Kent Tamura.
1934
1935         On second thought, let's not go to Camelot. It is a silly place.
1936
1937         * DumpRenderTree/mac/DumpRenderTree.mm:
1938         (resetDefaultsToConsistentValues):
1939
1940 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
1941
1942         Nixed the defunct chromium folder from DumpRenderTree
1943         https://bugs.webkit.org/show_bug.cgi?id=113993
1944
1945         Reviewed by Ryosuke Niwa.
1946
1947         * DumpRenderTree/chromium: Removed.
1948         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
1949         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
1950         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
1951         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
1952         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
1953         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
1954         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
1955         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
1956         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
1957         * DumpRenderTree/chromium/MockPlatform.h: Removed.
1958         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
1959         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
1960         * DumpRenderTree/chromium/Task.cpp: Removed.
1961         * DumpRenderTree/chromium/Task.h: Removed.
1962         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
1963         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
1964         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
1965         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
1966         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
1967         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
1968         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
1969         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1970         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1971         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1972         * DumpRenderTree/chromium/TestRunner: Removed.
1973         * DumpRenderTree/chromium/TestRunner/public: Removed.
1974         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
1975         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
1976         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
1977         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
1978         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
1979         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
1980         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
1981         * DumpRenderTree/chromium/TestRunner/src: Removed.
1982         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
1983         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
1984         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
1985         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
1986         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
1987         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
1988         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
1989         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
1990         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
1991         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
1992         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
1993         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
1994         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
1995         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
1996         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
1997         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
1998         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
1999         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
2000         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
2001         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
2002         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
2003         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
2004         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
2005         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
2006         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
2007         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
2008         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
2009         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
2010         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
2011         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
2012         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
2013         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
2014         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
2015         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
2016         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
2017         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
2018         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
2019         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
2020         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
2021         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
2022         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
2023         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
2024         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
2025         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
2026         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
2027         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
2028         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
2029         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
2030         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
2031         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
2032         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
2033         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
2034         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
2035         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
2036         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
2037         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
2038         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2039         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
2040         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
2041         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
2042         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
2043         * DumpRenderTree/chromium/TestShell.cpp: Removed.
2044         * DumpRenderTree/chromium/TestShell.h: Removed.
2045         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
2046         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
2047         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
2048         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
2049         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
2050         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
2051         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
2052         * DumpRenderTree/chromium/WebViewHost.h: Removed.
2053         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
2054         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
2055         * DumpRenderTree/chromium/config.h: Removed.
2056         * DumpRenderTree/chromium/fonts.conf: Removed.
2057
2058 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2059
2060         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
2061
2062         Rubber stamped by Benjamin Poulain.
2063
2064         * RebaselineQueueServer: Removed.
2065         * RebaselineQueueServer/app.yaml: Removed.
2066         * RebaselineQueueServer/handlers: Removed.
2067         * RebaselineQueueServer/handlers/__init__.py: Removed.
2068         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
2069         * RebaselineQueueServer/handlers/pages.py: Removed.
2070         * RebaselineQueueServer/index.yaml: Removed.
2071         * RebaselineQueueServer/main.py: Removed.
2072         * RebaselineQueueServer/model: Removed.
2073         * RebaselineQueueServer/model/__init__.py: Removed.
2074         * RebaselineQueueServer/model/queueentry.py: Removed.
2075         * RebaselineQueueServer/static: Removed.
2076         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
2077         * RebaselineQueueServer/static/styles.css: Removed.
2078         * RebaselineQueueServer/templates: Removed.
2079         * RebaselineQueueServer/templates/builder-picker.html: Removed.
2080         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
2081         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
2082         * RebaselineQueueServer/templates/home.html: Removed.
2083
2084 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2085
2086         Fix setup-commit-queue and temporarily disable testing on commit-queue
2087         https://bugs.webkit.org/show_bug.cgi?id=113979
2088
2089         Reviewed by Benjamin Poulain.
2090
2091         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
2092         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
2093
2094         * EWSTools/setup-commit-queue.sh:
2095         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2096         (CommitQueueTask.run):
2097
2098 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
2099
2100         temporarily make flakiness dashboard work again webkit.org bots
2101         https://bugs.webkit.org/show_bug.cgi?id=113972
2102
2103         Reviewed by Ojan Vafai.
2104
2105         This patch disables the chromium.org layout test bots TestExpectations
2106         parsing temporarily until we can work out the right way to split into
2107         two instances for webkit.org and chromium.org and figure out which
2108         code to delete where :).
2109
2110         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2111
2112 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2113
2114         Fix webkitpy tests after r147678.
2115
2116         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2117         (CommitQueueTest.test_commit_queue):
2118         (test_manual_reject_during_processing):
2119
2120 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2121
2122         The commit queue should use Mac MountainLion port
2123         https://bugs.webkit.org/show_bug.cgi?id=113971
2124
2125         Reviewed by Lucas Forschler.
2126
2127         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
2128         * Scripts/webkitpy/tool/commands/queues.py:
2129         (CommitQueue):
2130
2131 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
2132
2133         turn off running tests on chromium linux EWS bots
2134         https://bugs.webkit.org/show_bug.cgi?id=113959
2135
2136         Reviewed by Geoffrey Garen.
2137
2138         Now that the Chromium port is no longer being maintained
2139         there's little point in running the tests. Soon we should
2140         just shut this bot off altogether.
2141
2142         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2143         (ChromiumLinuxEWS):
2144
2145 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
2146
2147         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
2148
2149         * Scripts/webkitpy/common/config/watchlist:
2150
2151 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
2152
2153         Indentation fix to get webkit-patch working again after r147625
2154
2155         Unreviewed.
2156
2157         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2158         (MacEWS):
2159         (MacWK2EWS):
2160
2161 2013-04-04  Lucas Forschler  <lforschler@apple.com>
2162
2163         Turn tests back on for Mac WK1/WK2 EWS.
2164         
2165         Unreviewed.
2166         
2167         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2168         (MacEWS):
2169         (MacWK2EWS):
2170
2171 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
2172
2173         [GTK][WK2] MiniBrowser custom URI scheme support
2174         https://bugs.webkit.org/show_bug.cgi?id=112419
2175
2176         Reviewed by Carlos Garcia Campos.
2177
2178         Add support for about URIs in MiniBrowser. An example about page is show
2179         with URI "about:minibrowser", the rest of the cases it will show a
2180         proper message explaining that the about page didn't exist.
2181
2182         Internally it uses "minibrowser-about" prefix instead of "about", but
2183         from the user point of view it works with "about" prefix.
2184
2185         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
2186         (getInternalURI): Method to convert URIs from "about" prefix to
2187         "minibrowser-about".
2188         (getExternalURI): Opposite method.
2189         (webViewURIChanged): Use "about" prefix to show the URI to users.
2190         (webViewEnterFullScreen): Ditto.
2191         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
2192         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
2193         (aboutURISchemeRequestCallback): Callback to manage about calls.
2194         (main): Register the URI scheme to manage about URIs.
2195
2196 2013-04-03  Roger Fong  <roger_fong@apple.com>
2197
2198         Re-enable WinEWS tests.
2199
2200         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2201         (WinEWS):
2202
2203 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
2204
2205         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
2206         https://bugs.webkit.org/show_bug.cgi?id=113883
2207
2208         Reviewed by Martin Robinson.
2209
2210         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
2211         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
2212         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
2213
2214 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2215
2216         [GTK] Include Pango in jhbuild-optional.modules
2217         https://bugs.webkit.org/show_bug.cgi?id=113878
2218
2219         Reviewed by Martin Robinson.
2220
2221         Since r147547 Pango 1.32.0 is required. Including the module in the
2222         JHBuild optional moduleset.
2223
2224         * gtk/jhbuild-optional.modules: Add Pango module.
2225
2226 2013-04-03  Zeno Albisser  <zeno@webkit.org>
2227
2228         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
2229         https://bugs.webkit.org/show_bug.cgi?id=113864
2230
2231         Moving setDefersLoading from TestRunnerQt to TestRunner
2232         requires access to the non-Qt TestRunner.
2233         As long as we instantiate both TestRunner and TestRunnerQt,
2234         we need a separate getter for the non-Qt TestRunner instance.
2235
2236         Reviewed by Simon Hausmann.
2237
2238         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2239         (WebPage::resetSettings):
2240         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2241         (DumpRenderTree::jscTestRunner):
2242         * DumpRenderTree/qt/TestRunnerQt.cpp:
2243         (TestRunner::setDefersLoading):
2244             Moving setDefersLoading from TestRunnerQt
2245             to TestRunner.
2246         * DumpRenderTree/qt/TestRunnerQt.h:
2247         (TestRunnerQt):
2248
2249 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2250
2251         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
2252         https://bugs.webkit.org/show_bug.cgi?id=104779
2253
2254         Reviewed by Carlos Garcia Campos.
2255
2256         * Scripts/run-gtk-tests:
2257         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
2258         passing in current trunk.
2259
2260 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
2261
2262         Fix HAVE(QTTESTSUPPORT) logic
2263
2264         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
2265         resulting in HAVE(QTTESTSUPPORT) never being true.
2266         Move that logic down in sanitizeFeatures.
2267
2268         Rubber-stamped by Tor Arne Vestbø.
2269
2270         * qmake/mkspecs/features/features.prf:
2271
2272 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2273
2274         [GTK] Bump required versions of some dependencies
2275         https://bugs.webkit.org/show_bug.cgi?id=113282
2276
2277         Reviewed by Martin Robinson.
2278
2279         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
2280
2281 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2282
2283         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
2284         https://bugs.webkit.org/show_bug.cgi?id=113809
2285
2286         Reviewed by Philippe Normand.
2287
2288         Newer Linux kernels have removed some deprecated macros from v4l2
2289         headers, causing gst-plugins-good's build to break. We don't need it
2290         right now, so just disable it.
2291
2292         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
2293
2294 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2295
2296         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
2297         https://bugs.webkit.org/show_bug.cgi?id=113535
2298
2299         Reviewed by Simon Hausmann.
2300
2301         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
2302
2303         * qmake/mkspecs/features/features.prf:
2304
2305 2013-04-03  Zeno Albisser  <zeno@webkit.org>
2306
2307         [Qt] Move logic of simple forwarding functions to TestRunner.
2308         https://bugs.webkit.org/show_bug.cgi?id=113863
2309
2310         Reviewed by Simon Hausmann.
2311
2312         * DumpRenderTree/qt/TestRunnerQt.cpp:
2313         (TestRunner::setTextDirection):
2314         (TestRunner::goBack):
2315         (TestRunner::evaluateScriptInIsolatedWorld):
2316         (TestRunner::addUserStyleSheet):
2317         * DumpRenderTree/qt/TestRunnerQt.h:
2318         (TestRunnerQt):
2319
2320 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2321
2322         [Qt] Disable media support using QuickTime if deployment target != SDK
2323
2324         We link to a single libWebKitSystemInterface static lib, so unless the
2325         deployment target matches the SDK let's not pretend like we'll be able
2326         to run on anything lower than the SDK version.
2327
2328         Reviewed by Simon Hausmann.
2329
2330         * qmake/mkspecs/features/features.prf:
2331
2332 2013-04-02  James Craig  <james@cookiecrook.com>
2333
2334         AXRoleDescripton for DL is "list"; should be "description list"
2335         https://bugs.webkit.org/show_bug.cgi?id=111665
2336
2337         Reviewed by Chris Fleizach.
2338
2339         Defining the role and description strings.
2340
2341         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2342
2343 2013-04-02  Roger Fong  <roger_fong@apple.com>
2344
2345         Unreviewed. Disable running tests on Win EWS queue.
2346
2347         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2348         (WinEWS):
2349
2350 2013-04-02  Lucas Forschler  <lforschler@apple.com>
2351
2352         Disable running tests on the MAC WK2 EWS queue.
2353         
2354         Unreviewed.
2355         
2356         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2357         (MacWK2EWS):
2358
2359 2013-04-02  Julie Parent  <jparent@chromium.org>
2360
2361         Dashboard refactor: Move dashboard specific history related features to History.
2362         https://bugs.webkit.org/show_bug.cgi?id=113717
2363
2364         Reviewed by Ojan Vafai.
2365         
2366         Each dashboard now creates its own History object, with a custom
2367         configuration. This changes from just overriding global functions
2368         to passing in callbacks for generatePage, handleValidHashParameter,
2369         and handleQueryParameterChange. Same with passing in defaultStateValues
2370         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
2371         variables.
2372         
2373         All functions related to these features are now (mostly) private
2374         function on History. 
2375         
2376         Loader no longer needs a loadingComplete callback, since it can just
2377         initialize the history object itself.
2378
2379         * TestResultServer/static-dashboards/aggregate_results.js:
2380         (handleValidHashParameter):
2381         * TestResultServer/static-dashboards/dashboard_base.js:
2382         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2383         (generatePage):
2384         (.switch.return):
2385         (handleQueryParameterChange):
2386         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2387         (resetGlobals):
2388         * TestResultServer/static-dashboards/history.js:
2389         (.):
2390         * TestResultServer/static-dashboards/loader.js:
2391         (.):
2392         * TestResultServer/static-dashboards/loader_unittests.js:
2393         * TestResultServer/static-dashboards/timeline_explorer.js:
2394         (generatePage):
2395         (initCurrentBuilderTestResults):
2396         * TestResultServer/static-dashboards/treemap.js:
2397         (generatePage):
2398         (.switch.return):
2399         (handleQueryParameterChange):
2400
2401 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2402
2403         Unreviewed, rolling out r147401.
2404         http://trac.webkit.org/changeset/147401
2405         https://bugs.webkit.org/show_bug.cgi?id=113767
2406
2407         The patch makes it extremely hard to set up the dependencies
2408         properly on the GTK builders (Requested by zdobersek on
2409         #webkit).
2410
2411         * gtk/jhbuild.modules:
2412
2413 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2414
2415         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
2416         https://bugs.webkit.org/show_bug.cgi?id=113382
2417
2418         Reviewed by Gyuyoung Kim.
2419
2420         Do not show the empty tooltip box if the text is null.
2421
2422         * MiniBrowser/efl/main.c:
2423         (popup_menu_populate):
2424
2425 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2426
2427         [GTK] Bump required versions of some dependencies
2428         https://bugs.webkit.org/show_bug.cgi?id=113282
2429
2430         Reviewed by Martin Robinson.
2431
2432         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
2433
2434 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2435
2436         Unreviewed, rolling out r147319.
2437         http://trac.webkit.org/changeset/147319
2438         https://bugs.webkit.org/show_bug.cgi?id=113707
2439
2440         The unit test is still failing on the buildbot (Requested by
2441         zdobersek on #webkit).
2442
2443         * Scripts/run-gtk-tests:
2444         (TestRunner):
2445
2446 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
2447
2448         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
2449         https://bugs.webkit.org/show_bug.cgi?id=104779
2450
2451         Reviewed by Carlos Garcia Campos.
2452
2453         * Scripts/run-gtk-tests:
2454         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
2455         passing in current trunk.
2456
2457 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
2458
2459         Unreviewed, rolling out r147289.
2460         http://trac.webkit.org/changeset/147289
2461         https://bugs.webkit.org/show_bug.cgi?id=113678
2462
2463         broke Win7 (dbg) build (Requested by shinyak|gardener on
2464         #webkit).
2465
2466         * DumpRenderTree/DumpRenderTree.gypi:
2467         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
2468         (WebTestRunner):
2469         (WebUserMediaClientMock):
2470         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
2471         (WebTestRunner::WebUserMediaClientMock::taskList):
2472         * Scripts/webkitpy/style/checkers/cpp.py:
2473         (check_function_definition):
2474
2475 2013-03-31  Adam Barth  <abarth@webkit.org>
2476
2477         configure-svn-config.sh fails
2478         https://codereview.chromium.org/13392007/
2479
2480         Reviewed by Eric Seidel.
2481
2482         This script was trying to use "svn checkout" to dowload a file from
2483         svn.webkit.org, but "svn checkout" only works with directories.
2484         Instead, we should use "svn export".
2485
2486         * EWSTools/configure-svn-config.sh:
2487
2488 2013-03-31  Wei Jia  <wjia@chromium.org>
2489
2490         Allow WebUserMediaClientMock to be used by client
2491         https://bugs.webkit.org/show_bug.cgi?id=113633
2492
2493         Reviewed by Adam Barth.
2494
2495         Export WebUserMediaClientMock.
2496         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
2497
2498         * DumpRenderTree/DumpRenderTree.gypi:
2499         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
2500         (WebUserMediaClientMock):
2501         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
2502         * Scripts/webkitpy/style/checkers/cpp.py:
2503         (check_function_definition):
2504
2505 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
2506
2507         Expose FeatureObserver data to WebKit clients
2508         https://bugs.webkit.org/show_bug.cgi?id=113613
2509
2510         Reviewed by Sam Weinig.
2511
2512         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2513         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
2514
2515 2013-03-29  Greg Hughes  <ghughes@apple.com>
2516
2517         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
2518         https://bugs.webkit.org/show_bug.cgi?id=112276
2519
2520         Reviewed by Chris Fleizach.
2521
2522         Added support to test accessibility search predicates with multiple keys.  
2523
2524         * DumpRenderTree/AccessibilityUIElement.cpp:
2525         (uiElementForSearchPredicateCallback):
2526         * DumpRenderTree/AccessibilityUIElement.h:
2527         (AccessibilityUIElement):
2528         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2529         (AccessibilityUIElement::uiElementForSearchPredicate):
2530         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2531         (AccessibilityUIElement::uiElementForSearchPredicate):
2532         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2533         (AccessibilityUIElement::uiElementForSearchPredicate):
2534         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2535         (AccessibilityUIElement::uiElementForSearchPredicate):
2536         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2537         (AccessibilityUIElement::uiElementForSearchPredicate):
2538         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2539         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2540         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2541         (AccessibilityUIElement):
2542         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2543         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2544         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2545         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2546         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2547
2548 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
2549
2550         Fix a typo in r147147 to fix Mac EWS.
2551
2552         * Scripts/webkitpy/tool/commands/queues.py:
2553         (PatchProcessingQueue._new_port_name_from_old):
2554
2555 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
2556
2557         [EFL] Build break with latest EFL libraries after r146265
2558         https://bugs.webkit.org/show_bug.cgi?id=113558
2559
2560         Unreviewed build fix.
2561
2562         * TestWebKitAPI/PlatformWebView.h:
2563         * WebKitTestRunner/PlatformWebView.h:
2564
2565 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2566
2567         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
2568
2569         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
2570         in libgcrypt build.
2571
2572 2013-03-28  Lucas Forschler  <lforschler@apple.com>
2573
2574         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
2575
2576         Unreviewed.
2577
2578         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2579         (MacEWS):
2580
2581 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
2582
2583         Use the right OS name on Mac EWS instead of mac-future.
2584
2585         Rubber-stamped by Dirk Pranke.
2586
2587         * Scripts/webkitpy/tool/commands/queues.py:
2588         (PatchProcessingQueue._new_port_name_from_old):
2589         (PatchProcessingQueue.begin_work_queue):
2590         (PatchProcessingQueue._upload_results_archive_for_patch):
2591
2592 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
2593
2594         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
2595         https://bugs.webkit.org/show_bug.cgi?id=112546
2596
2597         Reviewed by Martin Robinson.
2598
2599         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
2600         moved back to Source/WebCore/platform. Fix an indentation issue as well.
2601
2602 2013-03-28  Ming Xie  <mxie@blackberry.com>
2603
2604         [BlackBerry] Committer Email Updates
2605         https://bugs.webkit.org/show_bug.cgi?id=113435
2606
2607         Reviewed by Rob Buis.
2608
2609         Add the @blackberry.com email address for all our BlackBerry
2610         WebKit committers. This is the first step for our email address
2611         migration.
2612
2613         * Scripts/webkitpy/common/config/committers.py:
2614
2615 2013-03-28  Philippe Normand  <pnormand@igalia.com>
2616
2617         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
2618         https://bugs.webkit.org/show_bug.cgi?id=113508
2619
2620         Reviewed by Martin Robinson.
2621
2622         Prevent the GStreamer plugin scanner to load system-wide
2623         plugins. Only the ones built in JHBuild should be loaded and used
2624         at runtime.
2625
2626         * efl/jhbuildrc:
2627         * gtk/jhbuildrc:
2628
2629 2013-03-27  Philippe Normand  <pnormand@igalia.com>
2630
2631         [GTK] run-launcher --gtk -2 fails on a WK2-only build
2632         https://bugs.webkit.org/show_bug.cgi?id=113386
2633
2634         Reviewed by Carlos Garcia Campos.
2635
2636         * Scripts/webkitdirs.pm:
2637         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
2638         version to 3.0. Reflect this change so the builtDylibPathForName
2639         function doesn't fail to report the library as found.
2640
2641 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
2642
2643         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
2644         https://bugs.webkit.org/show_bug.cgi?id=113484
2645
2646         Unreviewed build fix.
2647
2648         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
2649
2650         * TestWebKitAPI/CMakeLists.txt:
2651         * WebKitTestRunner/CMakeLists.txt:
2652
2653 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2654
2655         Revision for the internal jhbuild is too old
2656         https://bugs.webkit.org/show_bug.cgi?id=113324
2657
2658         Reviewed by Martin Robinson.
2659
2660         Update the minimum required version to a point where jhbuild won't
2661         fail installing packages when trying to remove a symlink to a directory.
2662
2663         * jhbuild/jhbuild-wrapper: Updated revision.
2664
2665 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
2666
2667         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
2668         https://bugs.webkit.org/show_bug.cgi?id=113203
2669
2670         Reviewed by Philippe Normand.
2671
2672         We build our libsoup without GNOME support. gst-plugins-good does separate
2673         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
2674         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
2675         build failures as the headers of those diverge. We do not use souphttpsrc, so
2676         disable it when building gst-plugins-good.
2677
2678         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
2679
2680 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
2681
2682         Build fix after r146852. Please another reference to the Lion leaks builder.
2683
2684         * BuildSlaveSupport/build.webkit.org-config/config.json:
2685
2686 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
2687
2688         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
2689         https://bugs.webkit.org/show_bug.cgi?id=113421
2690
2691         Reviewed by Dirk Pranke.
2692
2693         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
2694         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
2695         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
2696         in the GTK-specific TestExpectations files.
2697
2698         To avoid this only enable the warnings only when not using WKTR.
2699
2700         * Scripts/webkitpy/layout_tests/port/gtk.py:
2701         (GtkPort.warn_if_bug_missing_in_test_expectations):
2702
2703 2013-03-27  Antti Koivisto  <antti@apple.com>
2704
2705         Fix Zalan's email.
2706
2707         * Scripts/webkitpy/common/config/committers.py:
2708
2709 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
2710
2711         master.cfg cleanup
2712         https://bugs.webkit.org/show_bug.cgi?id=113195
2713
2714         Reviewed by Ryosuke Niwa.
2715
2716         * BuildSlaveSupport/build.webkit.org-config/config.json:
2717         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2718
2719 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
2720
2721         master.cfg fine-tuning for Qt Mountain Lion Release bot
2722         https://bugs.webkit.org/show_bug.cgi?id=113191
2723
2724         Reviewed by Ryosuke Niwa.
2725
2726         * BuildSlaveSupport/build.webkit.org-config/config.json:
2727           - Rename the slave due to its location change.
2728           - Update the platform of the slave.
2729         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2730         (RunQtAPITests): Enable running WK2 API tests on Qt.
2731         (RunQtAPITests.start):
2732         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
2733         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
2734
2735 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2736
2737         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
2738         https://bugs.webkit.org/show_bug.cgi?id=113403
2739
2740         Reviewed by Kenneth Rohde Christiansen.
2741
2742         As of Evas 1.7.5, when Wayland is detected on the system, support for
2743         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
2744         The code, however, seems to depend on a few other flags which must be
2745         explicitly enabled.
2746
2747         If those additional GL-related options are passed, we end up
2748         having issues on the WebKit side, so disable Wayland support for
2749         now.
2750
2751         * efl/jhbuild.modules:
2752
2753 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2754
2755         Unreviewed, rolling out r146864.
2756         http://trac.webkit.org/changeset/146864
2757         https://bugs.webkit.org/show_bug.cgi?id=113391
2758
2759         causes crashes on Wk2 EFL release bot (Requested by drott on
2760         #webkit).
2761
2762         * Scripts/webkitperl/FeatureList.pm:
2763
2764 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2765
2766         [jhbuild] Correctly specify an alternate number of make jobs.
2767         https://bugs.webkit.org/show_bug.cgi?id=113396
2768
2769         Reviewed by Philippe Normand.
2770
2771         So far, we were using the `MAKEFLAGS' environment variable to pass the
2772         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
2773         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
2774
2775         We now behave more closely to the rest of the WebKit tools by first
2776         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
2777         not set, just letting jhbuild itself figure out how many jobs to use.
2778
2779         * efl/jhbuildrc:
2780         * gtk/jhbuildrc:
2781
2782 2013-03-27  Zeno Albisser  <zeno@webkit.org>
2783
2784         [Qt] Remove Qt specific WorkQueueItem definitions.
2785         https://bugs.webkit.org/show_bug.cgi?id=112891
2786
2787         This patch is preparation work for removing
2788         WorkQueue related code from TestRunnerQt and
2789         replacing it with generic TestRunner code.
2790
2791         Reviewed by Benjamin Poulain.
2792
2793         * DumpRenderTree/qt/TestRunnerQt.cpp:
2794         (TestRunnerQt::queueBackNavigation):
2795         (TestRunnerQt::queueForwardNavigation):
2796         (TestRunnerQt::queueLoadHTMLString):
2797         (TestRunnerQt::queueReload):
2798         (TestRunnerQt::queueLoadingScript):
2799         (TestRunnerQt::queueNonLoadingScript):
2800         (TestRunner::queueLoad):
2801         * DumpRenderTree/qt/TestRunnerQt.h:
2802         (TestRunnerQt):
2803         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2804         (LoadItem::invoke):
2805         (LoadHTMLStringItem::invoke):
2806         (LoadAlternateHTMLStringItem::invoke):
2807         (ReloadItem::invoke):
2808         (ScriptItem::invoke):
2809         (BackForwardItem::invoke):
2810         * DumpRenderTree/qt/WorkQueueItemQt.h:
2811         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
2812         (LoadAlternateHTMLStringItem):
2813
2814 2013-03-26  Julie Parent  <jparent@chromium.org>
2815
2816         Flakiness dashboard: simplify logic around which tests to show.
2817         https://bugs.webkit.org/show_bug.cgi?id=113250
2818
2819         Reviewed by Ojan Vafai.
2820         
2821         The different filters for showing results are only used for layout
2822         tests, otherwise, we show everything.
2823         
2824         Change the defaults to false (what layout tests used), and only
2825         look at the values when viewing layout tests.
2826
2827         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2828         (htmlForTestsWithExpectationsButNoFailures):
2829         (shouldHideTest):
2830
2831 2013-03-26  Isaac Levy  <ilevy@google.com>
2832
2833         Update bots on test-results.appspot
2834         https://bugs.webkit.org/show_bug.cgi?id=113333
2835
2836         Reviewed by Ojan Vafai.
2837
2838         * TestResultServer/static-dashboards/builders.jsonp:
2839
2840 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2841
2842         Unreviewed GTK gardening.
2843
2844         * Scripts/run-gtk-tests:
2845         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
2846
2847 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2848
2849         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
2850         https://bugs.webkit.org/show_bug.cgi?id=113287
2851
2852         Reviewed by Jocelyn Turcotte.
2853
2854         * Scripts/run-qtwebkit-tests:
2855         (Options.__init__):
2856
2857 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2858
2859         [EFL] Enable IndexedDB by default
2860         https://bugs.webkit.org/show_bug.cgi?id=107248
2861
2862         Reviewed by Laszlo Gombos.
2863
2864         * Scripts/webkitperl/FeatureList.pm:
2865         Enable IndexedDB by default on EFL.
2866
2867 2013-03-26  Alan Cutter  <alancutter@chromium.org>
2868
2869         Sheriffbot should explain rollout failures in a human readable form.
2870         https://bugs.webkit.org/show_bug.cgi?id=107092
2871
2872         Reviewed by Ryosuke Niwa.
2873
2874         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
2875
2876         * Scripts/webkitpy/tool/bot/irc_command.py:
2877         (Rollout._check_diff_failure):
2878         (Rollout.execute):
2879         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2880         (IRCCommandTest.test_rollout):
2881
2882 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
2883
2884         Unreviewed GTK gardening.
2885
2886         * Scripts/run-gtk-tests:
2887         (TestRunner): Skipping a failing unit test after r146518.
2888
2889 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2890
2891         Remove Lion leaks builder
2892         https://bugs.webkit.org/show_bug.cgi?id=113252
2893
2894         Reviewed by Andreas Kling.
2895
2896         Removed.
2897
2898         * BuildSlaveSupport/build.webkit.org-config/config.json:
2899
2900 2013-03-25  Kent Tamura  <tkent@chromium.org>
2901
2902         Rename ENABLE_INPUT_TYPE_DATETIME
2903         https://bugs.webkit.org/show_bug.cgi?id=113254
2904
2905         Reviewed by Kentaro Hara.
2906
2907         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
2908         Actually I'd like to remove the code, but we shouldn't remove it yet
2909         because we shipped products with it on some platforms.
2910
2911         * Scripts/webkitperl/FeatureList.pm:
2912         * qmake/mkspecs/features/features.pri:
2913
2914 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2915
2916         Remove one more line that was intended to be removed in r146657.
2917
2918         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2919         (summarize_results):
2920
2921 2013-03-25  Roger Fong  <roger_fong@apple.com>
2922
2923         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
2924         Re-enable WinEWS tests.
2925
2926         * Scripts/webkitpy/common/config/ports.py:
2927         (WinPort.run_bindings_tests_command):
2928         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2929         (WinEWS):
2930
2931 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2932
2933         Unreviewed, rolling out r146793.
2934         http://trac.webkit.org/changeset/146793
2935         https://bugs.webkit.org/show_bug.cgi?id=113248
2936
2937         Fix did not work (Requested by rfong on #webkit).
2938
2939         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2940         (WinEWS):
2941
2942 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2943
2944         REGRESSION(r146657): Test failures reported incorrectly
2945         https://bugs.webkit.org/show_bug.cgi?id=113223
2946
2947         Reviewed by Dirk Pranke.
2948
2949         The bug was caused by BuildBotPrinter not taking the new behavior into account.
2950
2951         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
2952         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
2953
2954         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2955         (Manager.run):
2956
2957         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2958         (RunDetails.__init__):
2959         (summarize_results): Remove the line I intended to remove in r146657.
2960
2961         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2962         (logging_run): Return details instead of the exit code.
2963         (run_and_capture): Ditto.
2964
2965         (RunTest.test_full_results_html):
2966         (RunTest.test_hung_thread):
2967         (RunTest.test_no_tests_found):
2968         (RunTest.test_no_tests_found_2):
2969         (RunTest.test_repeat_each_iterations_num_tests):
2970         (RunTest.test_run_singly_actually_runs_tests):
2971         (RunTest.test_test_list):
2972         (RunTest.test_missing_and_unexpected_results):
2973         (RunTest.test_pixel_test_directories):
2974         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
2975         (RunTest.test_crash_with_stderr):
2976         (RunTest.test_no_image_failure_with_image_diff):
2977         (RunTest.test_crash_log):
2978         (RunTest.test_exit_after_n_failures_upload):
2979         (RunTest.test_results_directory_absolute):
2980         (RunTest.test_results_directory_relative):
2981         (RunTest.test_retrying_and_flaky_tests):
2982         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
2983         (RunTest.test_retrying_uses_retries_directory):
2984         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
2985         (RunTest.test_output_diffs):
2986         (EndToEndTest.test_reftest_with_two_notrefs):
2987         (RebaselineTest.test_reset_results):
2988         (RebaselineTest.test_missing_results):
2989         (RebaselineTest.test_new_baseline):
2990
2991         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2992         (BuildBotPrinter.print_results):
2993         (BuildBotPrinter.print_unexpected_results):
2994         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
2995         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
2996
2997 2013-03-25  Julie Parent  <jparent@chromium.org>
2998
2999         Dashboard refactor: Move cross dashboard history related code into history.js.
3000         https://bugs.webkit.org/show_bug.cgi?id=113104
3001
3002         Reviewed by Ojan Vafai.
3003
3004         All functions relating to cross dashboard behavior move from being
3005         globals to methods on the history.History object. Names stay the same,
3006         except many are made private, ones that should have been constants now
3007         are, and the long standing TODO to change "currentState" to 
3008         dashboardSpecificState is done.
3009         
3010         We now create a global history object in dashboard_base, as an 
3011         intermediate measure.  Once the dashboard specific code is
3012         added to history, each DB will need to create its own, and this
3013         global will be eliminated.
3014         
3015         * TestResultServer/static-dashboards/aggregate_results.js:
3016         (handleValidHashParameter):
3017         (htmlForBuilder):
3018         (rawValuesHTML):
3019         * TestResultServer/static-dashboards/dashboard_base.js:
3020         (parseDashboardSpecificParameters):
3021         (defaultValue):
3022         (currentBuilderGroupCategory):
3023         (currentBuilderGroupName):
3024         (handleLocationChange):
3025         (expectationsMap):
3026         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3027         (generatePage):
3028         (.switch.return):
3029         (platformAndBuildType):
3030         (individualTests):
3031         (substringList):
3032         (processMissingAndExtraExpectations):
3033         (pathToFailureLog):
3034         (showPopupForBuild):
3035         (htmlForTestsWithExpectationsButNoFailures):
3036         (shouldHideTest):
3037         (isCrossBuilderView):
3038         (tableHeaders):
3039         (htmlForSingleTestRow):
3040         (htmlForTableColumnHeader):
3041         (generatePageForExpectationsUpdate):
3042         (handleUpdate):
3043         (nextUpdate):
3044         (setUpdateIndex):
3045         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
3046         (.appendExpectationsItem):
3047         (loadExpectations):
3048         (.dummyNode.onload):
3049         (loadExpectationsLayoutTests):
3050         (appendExpectations):
3051         (htmlForNavBar):
3052         (checkBoxToToggleState):
3053         (linkHTMLToToggleState):
3054         (generatePageForBuilder):
3055         (isInvalidKeyForCrossBuilderView):
3056         (handleQueryParameterChange):
3057         (showLegend):
3058         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3059         (resetGlobals):
3060         (test):
3061         * TestResultServer/static-dashboards/history.js:
3062         (.):
3063         * TestResultServer/static-dashboards/history_unittests.js:
3064         * TestResultServer/static-dashboards/loader.js:
3065         (.):
3066         * TestResultServer/static-dashboards/loader_unittests.js:
3067         * TestResultServer/static-dashboards/timeline_explorer.js:
3068         (generatePage):
3069         (initCurrentBuilderTestResults):
3070         (selectBuild):
3071         (showResultsDelta):
3072         * TestResultServer/static-dashboards/treemap.js:
3073         (generatePage):
3074         (.switch.return):
3075         (handleFocus):
3076         * TestResultServer/static-dashboards/ui.js:
3077
3078 2013-03-25  Roger Fong  <roger_fong@apple.com>
3079
3080         Unreviewed. Enable WinEWS tests again.
3081
3082         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3083         (WinEWS):
3084
3085 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
3086
3087         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
3088         https://bugs.webkit.org/show_bug.cgi?id=112166
3089
3090         HarfBuzz 0.9.14 merged my patch for icu detection without
3091         pkg-config files, as needed by for example Ubuntu 12.04.
3092         This obsoletes our local workaround. Removed it for GTK and EFL.
3093
3094         Reviewed by Martin Robinson.
3095
3096         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
3097         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
3098         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
3099         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
3100
3101 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
3102
3103         Unreviewed.  Move self from contributor to committer list.
3104
3105         * Scripts/webkitpy/common/config/committers.py:
3106
3107 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
3108
3109         EWS should use a human readable port name when uploading layout test archives
3110         https://bugs.webkit.org/show_bug.cgi?id=113099
3111
3112         Reviewed by Dirk Pranke.
3113
3114         Use new port's object's name() method to report human readable port names.
3115         This will also help us resolving the bug to apply layout test results posted by EWS.
3116
3117         * Scripts/webkitpy/tool/bot/botinfo.py:
3118         (BotInfo.__init__): Take port's name.
3119         (BotInfo.summary_text):
3120
3121         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
3122         (BotInfoTest.test_summary_text):
3123
3124         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3125         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
3126
3127         * Scripts/webkitpy/tool/commands/queues.py:
3128         (PatchProcessingQueue.__init__): Initialize self._port.
3129         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
3130         and use that for the attachment filename and the comment posted.
3131
3132         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3133         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
3134         "mac-snowleopard" as expected for TestPort.
3135
3136 2013-03-22  Roger Fong  <roger_fong@apple.com>
3137
3138         Unreviewed. Turn off EWS test on Win again.
3139         The battle continues.
3140
3141         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3142         (WinEWS):
3143
3144 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
3145
3146         NRWT: Enable pixel tests when retrying tests
3147         https://bugs.webkit.org/show_bug.cgi?id=112898
3148
3149         Reviewed by Dirk Pranke.
3150
3151         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3152         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
3153         if we've forced pixel tests in the retry.
3154         (Manager._run_tests):
3155         (Manager._clean_up_run): Fixed the capitalizations.
3156         (Manager._force_pixel_tests_if_needed): Added.
3157
3158         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3159         (_interpret_test_failures): Now that this function maybe called multiple times, only set
3160         'image_diff_percent' if it doesn't already exist.
3161
3162         (summarize_results): When the first attempt resulted in a text failure and the second attempt
3163         resulted in image and text failures and we've forced to run pixel tests in the retry run,
3164         treat this as a regular regression instead of a flakiness.
3165
3166         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
3167         run had image diffs.
3168
3169         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3170         (summarized_results):
3171
3172         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3173         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
3174         Also removed some dead code.
3175
3176         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
3177         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
3178         is set and pixel_tests_enabled is set to false.
3179         (EndToEndTest.test_reftest_with_two_notrefs):
3180
3181 2013-03-22  Tim Horton  <timothy_horton@apple.com>
3182
3183         Make it possible to run layout tests on Retina MBP
3184         https://bugs.webkit.org/show_bug.cgi?id=93673
3185
3186         Reviewed by Ryosuke Niwa.
3187
3188         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
3189         windows on 2x machines still run at 1x.
3190
3191         * DumpRenderTree/mac/DumpRenderTree.mm:
3192         (createWebViewAndOffscreenWindow):
3193         Reset the window resolution to 1x on creation.
3194         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
3195         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3196         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
3197         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3198         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
3199         (WTR::PlatformWebView::PlatformWebView):
3200         Add NSWindow details, reset the window resolution to 1x on creation.
3201
3202 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3203
3204         Leak bots shouldn't build
3205         https://bugs.webkit.org/show_bug.cgi?id=112774
3206
3207         Reviewed by Simon Fraser.
3208
3209         Since leak bots use regular debug builds, there is no need to build on these bots.
3210         Simply downloading builds will dramatically improve the cycle time of these bots.
3211
3212         * BuildSlaveSupport/build.webkit.org-config/config.json:
3213         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3214         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
3215         TestFactory instead of BuildAndTestFactory.
3216
3217 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
3218
3219         [Qt] Fix the TestWebKitAPI build
3220         https://bugs.webkit.org/show_bug.cgi?id=113044
3221
3222         Reviewed by Tor Arne Vestbø.
3223
3224         The generate-forwarding-headers script would only be run
3225         after the targets in InjectedBundle.pri since the second
3226         addStrictSubdirOrderBetween call in
3227         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
3228         the derived_sources -> injected_bundle order in SUBDIRS.
3229
3230         Fix it by only moving the dependent target at the end of
3231         SUBDIRS, don't touch its dependency.
3232
3233         * qmake/mkspecs/features/functions.prf:
3234
3235 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3236
3237         [EFL][WK2] View is not focused when fullscreen mode toggled
3238         https://bugs.webkit.org/show_bug.cgi?id=113009
3239
3240         Reviewed by Laszlo Gombos.
3241
3242         Set focus on view when fullscreen mode enabled/disabled
3243         by FullScreen API.
3244
3245         * MiniBrowser/efl/main.c:
3246         (on_fullscreen_accept):
3247         (on_fullscreen_deny):
3248
3249 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
3250
3251         nrwt is no longer saving retry results in the retries/ subdirectory
3252         https://bugs.webkit.org/show_bug.cgi?id=112995
3253
3254         Reviewed by Ojan Vafai.
3255
3256         I think this has been broken a long time, unfortunately. This
3257         patch should fix that.
3258
3259         In order to do so, I had to pass the directory to use from
3260         the Worker object through the SingleTestWriter to the
3261         TestResultWriter. While I was plumbing that through, I rationalized
3262         the order of the parameter arguments a bit ...
3263
3264         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3265         (Worker._run_single_test):
3266         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3267         (run_single_test):
3268         (SingleTestRunner.__init__):
3269         (SingleTestRunner._run_compare_test):
3270         (SingleTestRunner._run_rebaseline):
3271         (SingleTestRunner._run_reftest):
3272         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3273         (write_test_result):
3274         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3275         (TestResultWriterTest.test_reftest_diff_image):
3276         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3277         (RunTest.test_retrying_uses_retries_directory):
3278
3279 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
3280
3281         JSC profiler should have an at-a-glance report of the success of DFG optimization
3282         https://bugs.webkit.org/show_bug.cgi?id=112988
3283
3284         Reviewed by Geoffrey Garen.
3285
3286         * Scripts/display-profiler-output:
3287
3288 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
3289
3290         [chromium] Linux ASAN WebKit canary is running out of memory
3291         https://bugs.webkit.org/show_bug.cgi?id=112978
3292
3293         Reviewed by Tony Chang.
3294
3295         Running the AddressSanitizer on a crash takes a lot of
3296         memory, so we should serialize access to it to avoid running
3297         out of memory on a machine.
3298
3299         * Scripts/webkitpy/layout_tests/port/chromium.py:
3300         (ChromiumPort._get_crash_log):
3301         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3302         (HttpLock.__init__):
3303         (HttpLock.wait_for_httpd_lock):
3304
3305 2013-03-21  Min Qin  <qinmin@chromium.org>
3306
3307         Cleanup android media layout test code
3308         https://bugs.webkit.org/show_bug.cgi?id=112944
3309
3310         Reviewed by Adam Barth.
3311
3312         Chromium change: https://codereview.chromium.org/12892010/
3313         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
3314         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
3315         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
3316         Instead, we should switch to use content shell for layout tests.
3317
3318         * DumpRenderTree/chromium/TestShell.cpp:
3319         (TestShell::resetTestController):
3320
3321 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
3322
3323         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
3324         https://bugs.webkit.org/show_bug.cgi?id=112953
3325
3326         Reviewed by Tony Chang.
3327
3328         When I created the DumpRenderTree_resources target in r144863 I
3329         forgot to declare the needed dependencies on the other resource
3330         targets. Due to a quirk of ordering, this appears to have been fine
3331         w/ ninja but not w/ Xcode (which is still being used on the chromium
3332         mac valgrind bots). Declaring the dependencies fixes the build
3333         failures.
3334
3335         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3336
3337 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
3338
3339         [WinCairo] Correct assert in Empty BitmapImage Test.
3340         https://bugs.webkit.org/show_bug.cgi?id=112934
3341
3342         Reviewed by Tim Horton.
3343
3344         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3345         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
3346         to avoid ref counting assertion when leaving test scope.
3347
3348 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
3349
3350         [GTK] generate-feature-defines-files is incompatible with Python3
3351         https://bugs.webkit.org/show_bug.cgi?id=112956
3352
3353         Reviewed by Martin Robinson.
3354
3355         Make the generate-feature-defines-files compatible with Python3 by calling the items()
3356         method on the dictionary objects when iterating through said dictionaries.
3357
3358         * gtk/generate-feature-defines-files:
3359         (write_feature_defines_header):
3360         (write_flattened_feature_defines_file):
3361
3362 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
3363
3364         kill-old-processes spits out error messages on Mac
3365         https://bugs.webkit.org/show_bug.cgi?id=112878
3366
3367         Reviewed by Jessie Berlin.
3368
3369         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
3370         included in the list of options grep --help shows.
3371
3372         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
3373
3374         * BuildSlaveSupport/kill-old-processes:
3375         (main):
3376
3377 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
3378
3379         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
3380         https://bugs.webkit.org/show_bug.cgi?id=112597
3381
3382         Reviewed by Xan Lopez.
3383
3384         These were introduced for the Chromium port in r105295. We need
3385         dummy implementations in order to compile the BlackBerry port.
3386
3387         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
3388         (AccessibilityUIElement::scrollToMakeVisible):
3389         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3390         (AccessibilityUIElement::scrollToGlobalPoint):
3391
3392 2013-03-21  Roger Fong  <roger_fong@apple.com>
3393
3394         Re-enable WinEWS tests following r146376.
3395
3396         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3397         (WinEWS):
3398
3399 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
3400
3401         Unreviewed. Add Bem Jones-Bey to the list of contributors.
3402
3403         * Scripts/webkitpy/common/config/committers.py:
3404
3405 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
3406
3407         [GTK] Missing atk in install-dependencies script
3408         https://bugs.webkit.org/show_bug.cgi?id=112272
3409
3410         Reviewed by Gustavo Noronha Silva.
3411
3412         * gtk/install-dependencies: Add missing atk dependency.
3413
3414 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
3415
3416         [GTK] Missing backslash in install-dependencies script
3417         https://bugs.webkit.org/show_bug.cgi?id=112907
3418
3419         Reviewed by Philippe Normand.
3420
3421         * gtk/install-dependencies: Add missing backslash to dependencies
3422         list.
3423
3424 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
3425
3426         EWS bots have stopped uploading results to bugzilla
3427         https://bugs.webkit.org/show_bug.cgi?id=101091
3428
3429         Reviewed by Adam Barth.
3430
3431         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
3432         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
3433         this relative file path resoled to a file inside a non-existent directory for "zip".
3434
3435         Fixed the bug by resolving both test results directory and zip archive paths in
3436         LayoutTestResultsReader.archive.
3437
3438         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
3439         in the future.
3440
3441         * Scripts/webkitpy/common/system/filesystem_mock.py:
3442         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
3443
3444         * Scripts/webkitpy/common/system/workspace.py:
3445         (Workspace.create_zip): Log the source path when "zip" failed.
3446
3447         * Scripts/webkitpy/common/system/workspace_mock.py:
3448         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
3449
3450         * Scripts/webkitpy/common/system/workspace_unittest.py:
3451         (WorkspaceTest.test_create_zip_exception): Test that.
3452
3453         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3454         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
3455         This is the actual bug fix.
3456
3457         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3458         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
3459
3460 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
3461
3462         [chromium] move WebThemeEngine implementations to TestRunner library
3463         https://bugs.webkit.org/show_bug.cgi?id=112751
3464
3465         Reviewed by Adam Barth.
3466
3467         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3468         * DumpRenderTree/DumpRenderTree.gypi:
3469         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3470         (WebKit):
3471         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3472         (WebTestRunner::TestInterfaces::themeEngine):
3473         (WebTestRunner):
3474         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3475         (WebKit):
3476         (TestInterfaces):
3477         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3478         (WebTestRunner::WebTestInterfaces::themeEngine):
3479         (WebTestRunner):
3480         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3481         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3482         (WebTestRunner):
3483         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3484         (WebTestRunner::WebTestThemeControlWin::box):
3485         (WebTestRunner::WebTestThemeControlWin::line):
3486         (WebTestRunner::WebTestThemeControlWin::triangle):
3487         (WebTestRunner::WebTestThemeControlWin::roundRect):
3488         (WebTestRunner::WebTestThemeControlWin::oval):
3489         (WebTestRunner::WebTestThemeControlWin::circle):
3490         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3491         (WebTestRunner::WebTestThemeControlWin::markState):
3492         (WebTestRunner::WebTestThemeControlWin::draw):
3493         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3494         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3495         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3496         (WebTestRunner):
3497         (WebTestThemeControlWin):
3498         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3499         (WebTestRunner):
3500         (WebTestThemeEngineMac):
3501         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3502         (+[FakeActiveWindow alwaysActiveWindow]):
3503         (+[FakeActiveWindow alwaysInactiveWindow]):
3504         (-[FakeActiveWindow initWithActiveControls:]):
3505         (-[FakeActiveWindow _hasActiveControls]):
3506         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3507         (WebTestRunner):
3508         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3509         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3510         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3511         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3512         (WebTestRunner):
3513         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3514         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3515         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3516         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3517         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3518         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3519         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3520         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3521         (WebTestRunner::WebTestThemeEngineWin::getSize):
3522         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3523         (WebTestRunner):
3524         (WebTestThemeEngineWin):
3525         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3526         * DumpRenderTree/chromium/TestShell.cpp:
3527         (TestShell::initialize):
3528         * DumpRenderTree/chromium/TestShell.h:
3529         (WebKit):
3530         * DumpRenderTree/chromium/TestShellMac.mm:
3531         (platformInit):
3532         * DumpRenderTree/chromium/TestShellWin.cpp:
3533         (platformInit):
3534         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3535
3536 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
3537
3538         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
3539
3540         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
3541         New property sheet that does not link against CoreFoundation and
3542         CFNetwork.
3543         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
3544         Use new TestWebKitAPICommonWinCairo property sheet.
3545         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
3546         Ditto.
3547
3548 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
3549
3550         [WinCairo] Unreviewed build fix for VS2010.
3551
3552         Had to add WinCairo-specific property sheets to deal with some
3553         library and path differences with the main Apple port.
3554
3555         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3556         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
3557         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
3558         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
3559         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
3560         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
3561
3562 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
3563
3564         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
3565         https://bugs.webkit.org/show_bug.cgi?id=112849
3566
3567         Reviewed by Sam Weinig.
3568
3569         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3570         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3571         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3572
3573 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
3574
3575         [WinCairo] Build WebKit Tools under VS2010
3576         https://bugs.webkit.org/show_bug.cgi?id=112821
3577
3578         Reviewed by Tim Horton.
3579
3580         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3581         Add WinCairo-specific build target.
3582         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
3583         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
3584         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
3585         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
3586         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3587         Add WinCairo-specific build target.
3588         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3589         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3590         Add WinCairo-specific build target.
3591         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
3592         WinCairo-specific build target.
3593         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
3594         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
3595         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
3596         specific build target.
3597         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
3598         WinCairo-specific build target.
3599         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
3600         * win/record-memory/record-memoryDebugWinCairo.props: Added.
3601         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
3602
3603 2013-03-20  Roger Fong  <roger_fong@apple.com>
3604
3605         API test gardening AppleWin port.
3606
3607         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
3608
3609         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3610         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3611
3612 2013-03-20  Roger Fong  <roger_fong@apple.com>
3613
3614         Test fix for Win EWS bots, catch various errors and restart script if necessary.
3615
3616         * EWSTools/start-queue-win.sh:
3617
3618 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
3619
3620         Unreviewed, add myself to committers.py.
3621
3622 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3623
3624         Unreviewed. Adding another email for me.
3625
3626         * Scripts/webkitpy/common/config/committers.py:
3627
3628 2013-03-20  Justin Novosad  <junov@google.com>
3629
3630         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
3631         https://bugs.webkit.org/show_bug.cgi?id=112605
3632
3633         Reviewed by James Robinson.
3634
3635         Deleting all the code that was used for propagating and supporting
3636         the Chromium setting for disabling deferred 2d canvas rendering.
3637
3638         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3639         (main):
3640         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3641         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3642         (WebTestRunner::WebPreferences::reset):
3643         (WebTestRunner::WebPreferences::applyTo):
3644         * DumpRenderTree/chromium/TestShell.cpp:
3645         (TestShell::TestShell):
3646         (TestShell::resetWebSettings):
3647         (TestShell::runFileTest):
3648         * DumpRenderTree/chromium/TestShell.h:
3649         (TestShell):
3650
3651 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
3652
3653         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
3654         https://bugs.webkit.org/show_bug.cgi?id=112699.
3655
3656         Reviewed by Adam Barth.
3657
3658         * Scripts/webkitpy/layout_tests/port/qt.py:
3659         (QtPort._search_paths):
3660         (QtPort._port_specific_expectations_files):
3661         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3662         (QtPortTest):
3663         (QtPortTest._assert_search_path):
3664         (QtPortTest._assert_expectations_files):
3665
3666 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3667
3668         [Qt] Enable kerning by default
3669         https://bugs.webkit.org/show_bug.cgi?id=112704
3670
3671         Reviewed by Jocelyn Turcotte.
3672
3673         Disable kerning by default, since some reference test expectations
3674         expect kerning to be default off.
3675
3676         * DumpRenderTree/qt/TestRunnerQt.cpp:
3677         (TestRunnerQt::reset):
3678         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3679         (WTR::activateFonts):
3680
3681 2013-03-20  Zeno Albisser&nbs