Add a JSCOnly MIPS buildbot
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2
3         Add a JSCOnly MIPS buildbot
4         https://bugs.webkit.org/show_bug.cgi?id=181487
5
6         Reviewed by Michael Catanzaro.
7
8         Add the new bot configs definitions for the master and update the unit tests.
9
10         * BuildSlaveSupport/build.webkit.org-config/config.json:
11         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
12
13 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
14
15         REGRESSION (r226715): don't re-check number of simulators in child processes
16         https://bugs.webkit.org/show_bug.cgi?id=181484
17         <rdar://problem/36407151>
18
19         Reviewed by Aakash Jain.
20
21         * Scripts/webkitpy/port/ios_simulator.py:
22         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
23         are already initialized.
24
25 2018-01-10  Commit Queue  <commit-queue@webkit.org>
26
27         Unreviewed, rolling out r226667 and r226673.
28         https://bugs.webkit.org/show_bug.cgi?id=181488
29
30         This caused a flaky crash. (Requested by mlewis13 on #webkit).
31
32         Reverted changesets:
33
34         "CodeBlocks should be in IsoSubspaces"
35         https://bugs.webkit.org/show_bug.cgi?id=180884
36         https://trac.webkit.org/changeset/226667
37
38         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
39         https://bugs.webkit.org/show_bug.cgi?id=180884
40         https://trac.webkit.org/changeset/226673
41
42 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
43
44         Follow-up fix to r226715
45         https://bugs.webkit.org/show_bug.cgi?id=180555
46         <rdar://problem/36131381>
47
48         Unreviewed infrastructure fix.
49
50         * Scripts/webkitpy/xcode/new_simulated_device.py:
51         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
52         of delete.
53
54 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
55
56         webkitpy: Refactor simulator code (Part 2)
57         https://bugs.webkit.org/show_bug.cgi?id=180555
58         <rdar://problem/36131381>
59
60         Reviewed by Aakash Jain.
61
62         The patch leverages the SimulatedDeviceManager when running layout tests.
63         This patch is primarily code removal, since much of the IOSSimulatorPort
64         was dedicated to managing simulators. The removed code is either now owned by the
65         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
66         boot multiple simulators which was made obsolete in Xcode 9.
67
68         * Scripts/webkitpy/layout_tests/controllers/manager.py:
69         (Manager._custom_device_for_test.in): Device names now have spaces in them,
70         strip those spaces.
71         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
72         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
73         * Scripts/webkitpy/port/ios.py:
74         (IOSPort.__init__): The _current_device idiom is no longer required since the
75         SimulatedDeviceManager keeps track of any previously booted devices.
76         (IOSPort.target_host): Even when only a single device is used, it will be accessed
77         through the array of managed devices.
78         (IOSPort.using_multiple_devices): Deleted.
79         * Scripts/webkitpy/port/ios_device.py:
80         (IOSDevicePort.using_multiple_devices): Deleted.
81         * Scripts/webkitpy/port/ios_simulator.py:
82         (IOSSimulatorPort): Remove constants required to manage simulators, change device
83         class strings so they can be parsed by the DeviceType class.
84         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
85         the number of simulators currently booted, the number of child processes specified
86         and the maximum number of simulators supported by this system.
87         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
88         devices owned by the SimulatedDeviceManager.
89         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
90         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
91         the maximum number of supported simulators on this system.
92         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
93         request for each child process and send this list to the SimulatedDeviceManager to
94         initialize the devices.
95         (IOSSimulatorPort.clean_up_test_run):
96         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
97         specified version of iOS.
98         (IOSSimulatorPort.reset_preferences):
99         (IOSSimulatorPort.simulator_runtime): Deleted.
100         (IOSSimulatorPort.simulator_device_type): Deleted.
101         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
102         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
103         (IOSSimulatorPort._create_simulators): Deleted.
104         (IOSSimulatorPort._quit_ios_simulator): Deleted.
105         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
106         (IOSSimulatorPort.using_multiple_devices): Deleted.
107         (IOSSimulatorPort._create_device): Deleted.
108         (IOSSimulatorPort.get_simulator_path): Deleted.
109         (IOSSimulatorPort._createSimulatorApps): Deleted.
110         (IOSSimulatorPort._createSimulatorApp): Deleted.
111         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
112         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
113         maximum number of simulators run on this system.
114         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
115         * Scripts/webkitpy/xcode/new_simulated_device.py:
116         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
117
118 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
119
120         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
121         https://bugs.webkit.org/show_bug.cgi?id=181474
122
123         Reviewed by Carlos Alberto Lopez Perez.
124
125         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
126         name as the name.
127
128         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
129         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
130         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
131
132 2018-01-09  Andy Estes  <aestes@apple.com>
133
134         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
135         https://bugs.webkit.org/show_bug.cgi?id=181459
136
137         Reviewed by Dan Bernstein.
138
139         * ImageDiff/cg/Configurations/Base.xcconfig:
140
141 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
142
143         font-display:fallback can cause a visual flash (which is supposed to be impossible)
144         https://bugs.webkit.org/show_bug.cgi?id=181374
145
146         Reviewed by Simon Fraser.
147
148         The test requires Palatino.
149
150         * DumpRenderTree/mac/DumpRenderTree.mm:
151         (allowedFontFamilySet):
152         * WebKitTestRunner/mac/TestControllerMac.mm:
153         (WTR::allowedFontFamilySet):
154
155 2018-01-09  Saam Barati  <sbarati@apple.com>
156
157         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
158         https://bugs.webkit.org/show_bug.cgi?id=181449
159
160         Reviewed by JF Bastien.
161
162         This allows me to Cmd+f in my terminal to search for things without
163         having the results become misaligned.
164
165         * Scripts/display-profiler-output:
166
167 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
168
169         [webkitpy] PlatformInfo should have default argument for casual use
170         https://bugs.webkit.org/show_bug.cgi?id=180827
171
172         Reviewed by David Kilzer.
173
174         PlatformInfo should be the only way to check platform specific thing instead
175         of sys.platform or other various checks. If there is something you want to check,
176         it should be placed in PlatformInfo.
177
178         Currently to instantiate PlatformInfo, it requires arguments, which is usually
179         sys, platform and Executive(). They are straight forward and should be handled
180         by default arguments. Then we can instantiate PlatformInfo more casual.
181
182         * Scripts/webkitpy/common/system/platforminfo.py:
183         (PlatformInfo): Use relative module path import
184         (PlatformInfo.__init__):
185         (PlatformInfo.executive): Lazy instantiation of Executive()
186         (PlatformInfo.total_bytes_memory): Accessing via above property
187         (PlatformInfo.xcode_sdk_version): Ditto
188         (PlatformInfo.xcode_simctl_list): Ditto
189         (PlatformInfo.xcode_version): Ditto
190         (PlatformInfo._win_version_str): Ditto
191         * Scripts/webkitpy/common/system/systemhost.py:
192         (SystemHost.__init__):
193         * Scripts/webkitpy/common/system/user.py:
194         (User.__init__):
195
196 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
197
198         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
199         https://bugs.webkit.org/show_bug.cgi?id=176443
200
201         Reviewed by Darin Adler.
202
203         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
204         (TEST):
205
206 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
207
208         check-webkit-style: Verify syntax for WK_API_AVAILABLE
209         https://bugs.webkit.org/show_bug.cgi?id=181394
210
211         Reviewed by Darin Adler.
212
213         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
214         as the second parameter instead of ios(WK_IOS_TBA). This generally
215         builds for iOS on EWS but not when using the public SDK. See r224057,
216         r223207 and r226211 for example. This patch adds a basic style check
217         for that macro to prevent this kind of mistake.
218
219         * Scripts/webkitpy/style/checkers/cpp.py:
220         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
221         (check_style): Run new style check.
222         (CppChecker): Add build type for the new style check.
223         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
224         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
225
226 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
227
228         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
229         https://bugs.webkit.org/show_bug.cgi?id=181420
230         <rdar://problem/36365827>
231
232         Reviewed by Alex Christensen.
233
234         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
235         of corresponding _WKAttachments.
236
237         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
238         (TestWebKitAPI::TEST):
239
240 2018-01-08  Alex Christensen  <achristensen@webkit.org>
241
242         Add WKNavigationDelegate SPI exposing WebProcess crash reason
243         https://bugs.webkit.org/show_bug.cgi?id=181410
244         <rdar://problem/36167199>
245
246         Reviewed by Wenson Hsieh.
247
248         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
249         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
250         (TEST):
251
252 2018-01-08  Alex Christensen  <achristensen@webkit.org>
253
254         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
255         https://bugs.webkit.org/show_bug.cgi?id=181408
256         <rdar://problem/35884960>
257
258         Reviewed by Tim Horton.
259
260         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
261         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
262
263 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
264
265         [Attachment Support] Expose file name and content type of WKAttachment
266         https://bugs.webkit.org/show_bug.cgi?id=181390
267         <rdar://problem/36336837>
268
269         Reviewed by Tim Horton.
270
271         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
272
273         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
274         (-[_WKAttachment synchronouslyRequestInfo:]):
275         (-[_WKAttachment synchronouslyRequestData:]):
276
277         Reimplement this in terms of -synchronouslyRequestInfo:.
278
279         (-[_WKAttachment expectRequestedDataToBe:]):
280         (TestWebKitAPI::TEST):
281
282 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
283
284         Copying, pasting, and then deleting an attachment element breaks attachment data requests
285         https://bugs.webkit.org/show_bug.cgi?id=181365
286         <rdar://problem/36340647>
287
288         Reviewed by Tim Horton.
289
290         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
291         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
292         detail.
293
294         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
295         (TestWebKitAPI::TEST):
296
297 2018-01-08  Youenn Fablet  <youenn@apple.com>
298
299         navigator.onLine does not work inside service workers
300         https://bugs.webkit.org/show_bug.cgi?id=181079
301         <rdar://problem/36178606>
302
303         Reviewed by Darin Adler.
304
305         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
306         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
307
308 2018-01-07  Saam Barati  <sbarati@apple.com>
309
310         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
311         https://bugs.webkit.org/show_bug.cgi?id=181372
312
313         Reviewed by Filip Pizlo.
314
315         Adding these sorting modes makes it easier to analyze functions
316         that recompile a lot and exit a lot.
317
318         * Scripts/display-profiler-output:
319
320 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
321
322         Unreviewed, remove my Cisco email from contributors.json
323
324         * Scripts/webkitpy/common/config/contributors.json:
325
326 2018-01-05  JF Bastien  <jfbastien@apple.com>
327
328         WebAssembly: poison JS object's secrets
329         https://bugs.webkit.org/show_bug.cgi?id=181339
330         <rdar://problem/36325001>
331
332         Reviewed by Mark Lam.
333
334         Update tests for swap(Poisoned<k, T>, T*)
335
336         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
337         (TestWebKitAPI::TEST):
338         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
339         (TestWebKitAPI::TEST):
340         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
341         (TestWebKitAPI::TEST):
342
343 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
344
345         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
346         https://bugs.webkit.org/show_bug.cgi?id=181359
347
348         Reviewed by Tim Horton.
349
350         Ensure that these tests still pass using older SDKs.
351
352         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
353         (TestWebKitAPI::TEST):
354
355 2018-01-05  Alex Christensen  <achristensen@webkit.org>
356
357         Rebase API test after r226469
358         https://bugs.webkit.org/show_bug.cgi?id=181308
359
360         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
361         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
362         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
363
364 2018-01-05  Alex Christensen  <achristensen@webkit.org>
365
366         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
367         https://bugs.webkit.org/show_bug.cgi?id=181217
368
369         Reviewed by Tim Horton.
370
371         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
372         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
373         (TEST):
374
375 2018-01-05  Alex Christensen  <achristensen@webkit.org>
376
377         Add WKBundleFrameCreateFrameHandle
378         https://bugs.webkit.org/show_bug.cgi?id=181232
379         <rdar://problem/35926696>
380
381         Reviewed by Tim Horton.
382
383         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
384         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
385         (mouseDidMoveOverElement):
386         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
387         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
388         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
389         (TEST):
390
391 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
392
393         iOS: Build fix after r226432.
394         
395         Unreviewed. Stop duplicating speakAs symbols for iOS.
396
397         * DumpRenderTree/AccessibilityUIElement.cpp:
398         (AccessibilityUIElement::speakAs):
399
400 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
401
402         Unreviewed, added myself as WebKit reviewer
403
404         * Scripts/webkitpy/common/config/contributors.json:
405
406 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
407
408         WPE: Build fix after r226432.
409
410         Unreviewed. Rename ::speak() to ::speakAs().
411         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
412         (WTR::AccessibilityUIElement::speakAs):
413         (WTR::AccessibilityUIElement::speak): Deleted.
414
415 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
416
417         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
418         https://bugs.webkit.org/show_bug.cgi?id=180361
419
420         Reviewed by Zalan Bujtas.
421
422         * DumpRenderTree/AccessibilityUIElement.cpp:
423         (speakAsCallback):
424         (AccessibilityUIElement::speakAs):
425         (AccessibilityUIElement::getJSClass):
426         (speakCallback): Deleted.
427         (AccessibilityUIElement::speak): Deleted.
428         * DumpRenderTree/AccessibilityUIElement.h:
429         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
430         (AccessibilityUIElement::speakAs):
431         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
432         (AccessibilityUIElement::speakAs):
433         (AccessibilityUIElement::speak): Deleted.
434         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
435         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
436         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
437         (WTR::AccessibilityUIElement::speakAs):
438         (WTR::AccessibilityUIElement::speak): Deleted.
439         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
440         (WTR::AccessibilityUIElement::speakAs):
441         (WTR::AccessibilityUIElement::speak): Deleted.
442
443 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
444
445         REGRESSION (r226395): test-webkitperl test expectations incorrect
446         https://bugs.webkit.org/show_bug.cgi?id=181307
447         <rdar://problem/36306558>
448
449         Rubber-stamped by Aakash Jain.
450
451         r226395 added two lines towards the beginning of
452         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
453         numbers in the test expectations need to update.
454
455         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
456
457 2018-01-04  Tim Horton  <timothy_horton@apple.com>
458
459         WKWebView loses minimum layout size overrides that happen while the process is terminated
460         https://bugs.webkit.org/show_bug.cgi?id=181306
461         <rdar://problem/34398288>
462
463         Reviewed by Dan Bernstein.
464
465         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
466         (TEST):
467         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
468         while the process is terminated results in the page getting the correct
469         minimum layout size.
470
471 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
472
473         [MediaStream] Add Mock screen capture source
474         https://bugs.webkit.org/show_bug.cgi?id=181291
475         <rdar://problem/36298164>
476
477         Reviewed by Dean Jackson.
478
479         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
480         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
481         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
482
483 2018-01-04  Lucas Forschler  <lforschler@apple.com>
484
485         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
486
487         Reviewed by Ling Ho.
488
489         * BuildSlaveSupport/build.webkit.org-config/steps.py:
490
491 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
492
493         [Attachment Support] Create attachment elements when dropping files on iOS
494         https://bugs.webkit.org/show_bug.cgi?id=181192
495         <rdar://problem/36280945>
496
497         Reviewed by Tim Horton.
498
499         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
500         switch is enabled. See below for more details.
501
502         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
503         (-[NSItemProvider registerData:type:]):
504         (platformCopyPNG):
505         (TestWebKitAPI::TEST):
506         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
507
508         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
509         source item provider when dragging rich text *without* attachments, so this should have been a check for just
510         kUTTypeRTF instead.
511
512         (TestWebKitAPI::TEST):
513
514         Tests a few cases of inserting attachment elements via drop:
515         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
516             Instead of inserting the contents as inline web content, this should generate attachment elements.
517         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
518             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
519             back to inserting the content as an attachment.
520         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
521             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
522             or at the end).
523
524         * TestWebKitAPI/cocoa/TestWKWebView.h:
525         * TestWebKitAPI/cocoa/TestWKWebView.mm:
526         (-[TestWKWebView objectByEvaluatingJavaScript:]):
527
528         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
529         -stringByEvaluatingJavaScript to just turn around and call this.
530
531         (-[TestWKWebView stringByEvaluatingJavaScript:]):
532
533 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
534
535         Replace hard-coded paths in shebangs with #!/usr/bin/env
536         https://bugs.webkit.org/show_bug.cgi?id=181040
537
538         Reviewed by Alex Christensen.
539
540         * BuildSlaveSupport/build-launcher-app:
541         * BuildSlaveSupport/build-launcher-dmg:
542         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
543         * BuildSlaveSupport/built-product-archive:
544         * BuildSlaveSupport/clean-build:
545         * BuildSlaveSupport/delete-stale-build-files:
546         * BuildSlaveSupport/download-built-product:
547         * BuildSlaveSupport/gtk/buildbot/log/run:
548         * BuildSlaveSupport/gtk/buildbot/run:
549         * BuildSlaveSupport/gtk/pulseaudio/run:
550         * BuildSlaveSupport/kill-old-processes:
551         * BuildSlaveSupport/test-result-archive:
552         * BuildSlaveSupport/win/kill-old-processes:
553         * Scripts/SpacingHeuristics.pm:
554         * Scripts/add-include:
555         * Scripts/build-api-tests:
556         * Scripts/build-dumprendertree:
557         * Scripts/build-imagediff:
558         * Scripts/build-jsc:
559         * Scripts/build-webkit:
560         * Scripts/build-webkittestrunner:
561         * Scripts/check-Xcode-source-file-types:
562         * Scripts/check-dom-results:
563         * Scripts/check-for-exit-time-destructors:
564         * Scripts/check-for-global-initializers:
565         * Scripts/check-for-inappropriate-objc-class-names:
566         * Scripts/check-for-weak-vtables-and-externals:
567         * Scripts/clean-header-guards:
568         * Scripts/compare-timing-files:
569         * Scripts/configure-xcode-for-ios-development:
570         * Scripts/copy-webkitlibraries-to-product-directory:
571         * Scripts/create-exports:
572         * Scripts/debug-minibrowser:
573         * Scripts/debug-safari:
574         * Scripts/debug-test-runner:
575         * Scripts/do-file-rename:
576         * Scripts/do-webcore-rename:
577         * Scripts/dump-webkit-tests-run:
578         * Scripts/ensure-valid-python:
579         * Scripts/execAppWithEnv:
580         * Scripts/extract-localizable-js-strings:
581         * Scripts/filter-build-webkit:
582         * Scripts/find-extra-includes:
583         * Scripts/fix-blink-patch:
584         * Scripts/generate-coverage-data:
585         * Scripts/git-add-reviewer:
586         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
587         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
588         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
589         * Scripts/make-new-script-test:
590         * Scripts/make-script-test-wrappers:
591         * Scripts/package-root:
592         * Scripts/parse-malloc-history:
593         * Scripts/report-include-statistics:
594         * Scripts/resolve-ChangeLogs:
595         * Scripts/run-api-tests:
596         * Scripts/run-bindings-tests:
597         * Scripts/run-content-extension-tester:
598         * Scripts/run-iexploder-tests:
599         * Scripts/run-javascriptcore-tests:
600         * Scripts/run-jsc:
601         * Scripts/run-leaks:
602         * Scripts/run-mangleme-tests:
603         * Scripts/run-minibrowser:
604         * Scripts/run-pageloadtest:
605         * Scripts/run-regexp-tests:
606         * Scripts/run-safari:
607         * Scripts/run-sunspider:
608         * Scripts/run-test-runner:
609         * Scripts/run-webkit-app:
610         * Scripts/run-webkit-httpd:
611         * Scripts/run-webkit-websocketserver:
612         * Scripts/set-webkit-configuration:
613         * Scripts/show-pretty-diff:
614         * Scripts/sort-Xcode-project-file:
615         * Scripts/split-file-by-class:
616         * Scripts/sunspider-compare-results:
617         * Scripts/svn-apply:
618         * Scripts/svn-unapply:
619         * Scripts/test-webkit-scripts:
620         * Scripts/test-webkitperl:
621         * Scripts/update-iexploder-cssproperties:
622         * Scripts/update-javascriptcore-test-results:
623         * Scripts/update-webkit:
624         * Scripts/update-webkit-auxiliary-libs:
625         * Scripts/update-webkit-dependency:
626         * Scripts/update-webkit-libs-jhbuild:
627         * Scripts/update-webkit-localizable-strings:
628         * Scripts/update-webkit-support-libs:
629         * Scripts/update-webkitgtk-libs:
630         * Scripts/update-webkitwpe-libs:
631         * Scripts/webkit-build-directory:
632         * Scripts/webkitperl/LoadAsModule.pm:
633         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
634         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
635         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
636         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
637         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
638         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
639         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
640         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
641         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
642         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
643         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
644         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
645         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
646         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
647         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
648         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
649         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
650         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
651         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
652         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
653         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
654         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
655         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
656         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
657         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
658         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
659         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
660         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
661         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
662         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
663         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
664         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
665         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
666         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
667         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
668         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
669         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
670         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
671         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
672         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
673         * ccache/ccache-clang:
674         * ccache/ccache-clang++:
675         * ccache/ccache-wrapper:
676         * gtk/install-dependencies:
677         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
678         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
679         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
680         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
681         * iExploder/iexploder-1.3.2/tools/showtest.rb:
682         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
683         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
684         * iExploder/iexploder-1.7.2/src/webserver.rb:
685         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
686         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
687         * wpe/install-dependencies:
688
689 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
690
691         filter-build-webkit filters out useful compiler error lines
692         https://bugs.webkit.org/show_bug.cgi?id=179864
693
694         Reviewed by Tim Horton.
695
696         Don't filter out lines that contain information about build errors by always showing lines
697         after a line that contains "note:" or "error:".
698
699         * Scripts/filter-build-webkit:
700         (shouldShowSubsequentLine):
701         (shouldIgnoreLine):
702
703 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
704
705         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
706         https://bugs.webkit.org/show_bug.cgi?id=173915
707
708         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
709         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
710         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
711         empty string in this case.
712
713         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
714         (emitFormSubmissionEvent):
715
716 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
717
718         [GTK] Add web process API to detect when form is submitted via JavaScript
719         https://bugs.webkit.org/show_bug.cgi?id=173915
720
721         Reviewed by Carlos Garcia Campos.
722
723         Test it.
724
725         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
726         (FormSubmissionTest::FormSubmissionTest):
727         (FormSubmissionTest::~FormSubmissionTest):
728         (FormSubmissionTest::testFormSubmissionResult):
729         (FormSubmissionTest::willSendDOMEventCallback):
730         (FormSubmissionTest::willCompleteCallback):
731         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
732         (testWebExtensionFormSubmissionSteps):
733         (beforeAll):
734         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
735         (DelayedSignal::DelayedSignal):
736         (emitFormSubmissionEvent):
737         (handleFormSubmissionCallback):
738         (willSubmitFormCallback):
739         (pageCreatedCallback):
740
741 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
742
743         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
744         https://bugs.webkit.org/show_bug.cgi?id=181251
745
746         * Scripts/run-gtk-tests:
747         (GtkTestRunner):
748
749 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
750
751         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
752         https://bugs.webkit.org/show_bug.cgi?id=181136
753
754         * Scripts/run-gtk-tests:
755         (GtkTestRunner):
756
757 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
758
759         [macOS, iOS] Adopt new secure coding APIs in WebKit
760         https://bugs.webkit.org/show_bug.cgi?id=181085
761         <rdar://problem/34837397>
762
763         Reviewed by Tim Horton.
764
765         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
766         capable of supporting NSSecureCoding, so pass through the current coding routines.
767
768         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
769         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
770         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
771         routines if necessary.
772         (TEST): Updated for NSSecureCoding.
773         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
774         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
775
776 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
777
778         Remove std::chrono completely
779         https://bugs.webkit.org/show_bug.cgi?id=181186
780
781         Reviewed by Alex Christensen.
782
783         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
784         (WTR::TestController::platformRunUntil):
785
786 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
787
788         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
789         https://bugs.webkit.org/show_bug.cgi?id=181231
790
791         Reviewed by Alex Christensen.
792
793         Implement TestController APIs needed by ResourceLoadStatistics tests.
794
795         * WebKitTestRunner/TestController.cpp:
796         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
797         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
798
799 2018-01-02  Tim Horton  <timothy_horton@apple.com>
800
801         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
802         https://bugs.webkit.org/show_bug.cgi?id=181219
803
804         Reviewed by Wenson Hsieh.
805
806         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
807
808 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
809
810         Add a WebAuthentication runtime feature flag
811         https://bugs.webkit.org/show_bug.cgi?id=181220
812         <rdar://problem/36055305>
813
814         Reviewed by Brent Fulgham.
815
816         Renames the CredentialManagement runtime feature flag into WebAuthentication.
817
818         * DumpRenderTree/TestOptions.h:
819         * DumpRenderTree/TestOptions.mm:
820         (TestOptions::TestOptions):
821         * DumpRenderTree/mac/DumpRenderTree.mm:
822         (enableExperimentalFeatures):
823         (setWebPreferencesForTestOptions):
824         * WebKitTestRunner/TestController.cpp:
825         (WTR::TestController::resetPreferencesToConsistentValues):
826         (WTR::updateTestOptionsFromTestHeader):
827         * WebKitTestRunner/TestOptions.h:
828         (WTR::TestOptions::hasSameInitializationOptions const):
829
830 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
831
832         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
833         https://bugs.webkit.org/show_bug.cgi?id=181143
834         <rdar://problem/36200381>
835
836         Reviewed by Tim Horton.
837
838         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
839         attachment elements are enabled.
840
841         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
842         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
843         (TestWebKitAPI::TEST):
844
845 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
846
847         Update Credential Management API for WebAuthentication
848         https://bugs.webkit.org/show_bug.cgi?id=181082
849         <rdar://problem/36055239>
850
851         Reviewed by Brent Fulgham.
852
853         Enable Credential Management API for testing.
854
855         * DumpRenderTree/TestOptions.h:
856         * WebKitTestRunner/TestOptions.h:
857
858 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
859
860         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
861         https://bugs.webkit.org/show_bug.cgi?id=168194
862
863         Reviewed by Carlos Garcia Campos.
864
865         Fix an assertion and unskip the test. The order that form controls are associated is not
866         guaranteed.
867
868         * Scripts/run-gtk-tests:
869         (GtkTestRunner):
870         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
871         (didAssociateFormControlsCallback):
872
873 2018-01-02  Alex Christensen  <achristensen@webkit.org>
874
875         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
876         https://bugs.webkit.org/show_bug.cgi?id=180897
877         <rdar://problem/35535328>
878
879         Reviewed by Brent Fulgham.
880
881         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
882
883         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
884         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
885         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
886         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
887         (websiteDataStoreTestWebView):
888         (TEST):
889
890 == Rolled over to ChangeLog-2018-01-01 ==