roll-chromium-deps doesn't roll DEPS
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
2
3         roll-chromium-deps doesn't roll DEPS
4         https://bugs.webkit.org/show_bug.cgi?id=114421
5
6         Reviewed by Antti Koivisto.
7
8         Roll DEPS. Rolling DEPS. Rolled DEPS.
9
10         * Scripts/webkitpy/tool/bot/irc_command.py:
11         (RollChromiumDEPS.execute):
12
13 2013-04-11  Glenn Adams  <glenn@skynav.com>
14
15         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
16         https://bugs.webkit.org/show_bug.cgi?id=114418
17
18         Reviewed by Ryosuke Niwa.
19
20         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
21         (MockSCM.add): Remove optional remove_exit_code argument.
22         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
23         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
24         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
25         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
26
27 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
28
29         Fix roll-chromium-deps and hi.
30
31         * Scripts/webkitpy/tool/bot/irc_command.py:
32         (Hi.execute):
33         (RollChromiumDEPS.execute):
34
35 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
36
37         Remove webkitpy code to roll Chromium DEPS
38         https://bugs.webkit.org/show_bug.cgi?id=114415
39
40         Reviewed by Benjamin Poulain.
41
42         Removed the code to roll Chromium DEPS in WebKit.
43
44         * Scripts/webkitpy/common/checkout/checkout.py:
45         (Checkout.bug_id_for_this_commit):
46         * Scripts/webkitpy/common/checkout/checkout_mock.py:
47         (MockCheckout.commit_message_for_this_commit):
48         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
49         (CheckoutTest.test_suggested_reviewers):
50         * Scripts/webkitpy/common/checkout/deps.py: Removed.
51         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
52         * Scripts/webkitpy/tool/bot/irc_command.py:
53         (RollChromiumDEPS): Teach webkitbot a sense of humor.
54         (RollChromiumDEPS.execute):
55         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
56         (IRCCommandTest.test_create_bug):
57         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
58         (IRCBotTest.test_revert):
59         * Scripts/webkitpy/tool/bot/sheriff.py:
60         (Sheriff.post_rollout_patch):
61         * Scripts/webkitpy/tool/commands/__init__.py:
62         * Scripts/webkitpy/tool/commands/roll.py: Removed.
63         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
64         * Scripts/webkitpy/tool/steps/__init__.py:
65         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
66         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
67         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
68
69 2013-04-11  Glenn Adams  <glenn@skynav.com>
70
71         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
72         https://bugs.webkit.org/show_bug.cgi?id=114386
73
74         Reviewed by Benjamin Poulain.
75
76         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
77         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
78         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
79         by default and to return exit code 1 if a file/dir had already been added.
80
81         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
82         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
83         * Scripts/webkitpy/common/checkout/scm/svn.py:
84         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
85
86 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
87
88         Unreviewed.
89
90         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
91
92 2013-04-10  Glenn Adams  <glenn@skynav.com>
93
94         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
95         https://bugs.webkit.org/show_bug.cgi?id=114410
96
97         Reviewed by Ryosuke Niwa.
98
99         * Scripts/webkitpy/common/checkout/scm/git.py:
100         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
101         * Scripts/webkitpy/common/checkout/scm/scm.py:
102         (SCM.add): Remove optional return_exit_code argument.
103         (SCM.add_list): Remove optional return_exit_code argument.
104         * Scripts/webkitpy/common/checkout/scm/svn.py:
105         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
106
107 2013-04-10  Eric Seidel  <eric@webkit.org>
108
109         Remove myself from the watchlists, I'm getting too much bug mail. :)
110
111         * Scripts/webkitpy/common/config/watchlist:
112
113 2013-04-10  Commit Queue  <rniwa@webkit.org>
114
115         Unreviewed, rolling out r148158.
116         http://trac.webkit.org/changeset/148158
117         https://bugs.webkit.org/show_bug.cgi?id=114405
118
119         We need to migrate status data (Requested by rniwa on
120         #webkit).
121
122         * Scripts/webkitpy/common/net/statusserver.py:
123         (StatusServer):
124
125 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
126
127         Mass remove all the empty directories
128
129         Rubberstamped by Ryosuke Niwa.
130
131         * BuildSlaveSupport/gtk/crashmon/log: Removed.
132         * BuildSlaveSupport/gtk/xvfb/log: Removed.
133         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
134         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
135         * MiniBrowser/gtk/WebBundle: Removed.
136         * MiniBrowser/win: Removed.
137         * QtTestPlatformPlugin/mac: Removed.
138         * Scripts/webkitpy/tool/bot/testdata: Removed.
139         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
140         * efl/ImageDiff: Removed.
141         * iExploder/htdocs: Removed.
142         * iExploder/iexploder-1.7.2/output: Removed.
143         * iExploder/tools: Removed.
144         * qmake/config.tests/libexecdir: Removed.
145         * qmake/config.tests/libjpeg: Removed.
146         * qmake/config.tests/libpng: Removed.
147
148 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
149
150         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
151         https://bugs.webkit.org/show_bug.cgi?id=114397
152
153         Reviewed by Benjamin Poulain.
154
155         * Scripts/webkitpy/common/net/statusserver.py:
156         (StatusServer):
157
158 2013-04-10  Adam Barth  <abarth@webkit.org>
159
160         Remove abarth from watchlists
161         https://bugs.webkit.org/show_bug.cgi?id=114390
162
163         Reviewed by Ryosuke Niwa.
164
165         I'm trying to cut down on the amount of bugmail I get so that I'll have
166         more of a chance to notice a piece of bugmail directed at me.
167
168         * Scripts/webkitpy/common/config/watchlist:
169
170 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
171
172         webkit-test-results.appspot.com loads the dashboard for Chromium by default
173         https://bugs.webkit.org/show_bug.cgi?id=114381
174
175         Reviewed by Benjamin Poulain.
176
177         Changed the defaults.
178
179         * TestResultServer/static-dashboards/builders.js:
180         * TestResultServer/static-dashboards/dashboard_base.js:
181         (currentBuilderGroupCategory):
182
183 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
184
185         Remove Chromium EWS bots from the queue status server
186         https://bugs.webkit.org/show_bug.cgi?id=113988
187
188         Reviewed by Benjamin Poulain.
189
190         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
191
192         * QueueStatusServer/app.yaml:
193         * QueueStatusServer/config/queues.py:
194         * QueueStatusServer/model/queues.py:
195         (Queue.short_name):
196         (Queue.display_name):
197         * QueueStatusServer/model/queues_unittest.py:
198         (QueueTest.test_short_name):
199         (QueueTest.test_display_name):
200         (QueueTest.test_name_with_underscores):
201         * QueueStatusServer/templates/activebots.html:
202
203 2013-04-10  Ojan Vafai  <ojan@chromium.org>
204
205         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
206         https://bugs.webkit.org/show_bug.cgi?id=114370
207
208         Reviewed by Ryosuke Niwa.
209
210         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
211         Unfortunately, there's no way to test this until this is committed and there is
212         a master restart.
213
214         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
215         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
218         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
219         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
220         * TestResultServer/generate_builders_json.py:
221         * TestResultServer/static-dashboards/dashboard_base.js:
222         * TestResultServer/static-dashboards/loader.js:
223
224 2013-04-10  Glenn Adams  <glenn@skynav.com>
225
226         [Qt] Fix regression to test-webkitpy.
227         https://bugs.webkit.org/show_bug.cgi?id=114368
228
229         Reviewed by Ryosuke Niwa.
230
231         * Scripts/webkitpy/layout_tests/port/factory.py:
232         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
233         (PortFactory.get): Remove obsolete chromium port related code.
234         * Scripts/webkitpy/layout_tests/port/mac.py:
235         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
236
237 2013-04-10  Anders Carlsson  <andersca@apple.com>
238
239         Remove unneeded headers from FrameLoader.h
240         https://bugs.webkit.org/show_bug.cgi?id=114223
241
242         Reviewed by Geoffrey Garen.
243
244         Add back headers implicitly included by other headers.
245
246         * WebKitTestRunner/WorkQueueManager.cpp:
247
248 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
249
250         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
251         https://bugs.webkit.org/show_bug.cgi?id=114365
252
253         Reviewed by Martin Robinson.
254
255         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
256         The patch addresses crashes in the tally_event_reply method. It is already committed into the
257         at-spi2-atk source tree and will be available with the next stable release, after which the
258         patch should be removed and the dependency version bumped.
259
260         * gtk/jhbuild.modules:
261         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
262
263 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
264
265         [WinCairo] Unreviewed build fix. Correct DropBox download link.
266
267         * Scripts/update-webkit-wincairo-libs: Revise download URL to
268         match change in DropBox server behavior.
269
270 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
271
272         Removed an annoying message from svn-create-patch
273         https://bugs.webkit.org/show_bug.cgi?id=114332
274
275         Reviewed by Alexey Proskuryakov.
276
277         I see this message basically every time I write a patch, so it must not
278         be true.
279
280         * Scripts/svn-create-patch:
281         (generateDiff):
282
283 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
284
285         [GTK] Add support for Page Visibility
286         https://bugs.webkit.org/show_bug.cgi?id=97324
287
288         Reviewed by Sam Weinig.
289
290         Implemented test runner API for page visibility layout tests.
291
292         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
293         (TestRunner::resetPageVisibility):
294         (TestRunner::setPageVisibility):
295         * Scripts/webkitperl/FeatureList.pm:
296
297 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
298
299         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
300         https://bugs.webkit.org/show_bug.cgi?id=114342
301
302         Reviewed by Gyuyoung Kim.
303
304         Commit 148033 only added an implementation for the Mac port, which made
305         other ports fail most tests since loading the injected bundle failed
306         with a missing symbol.
307
308         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
309         (WTR::AccessibilityUIElement::pathDescription):
310
311 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
312
313         [EFL] Add spell checking option to MiniBrowser
314         https://bugs.webkit.org/show_bug.cgi?id=114282
315
316         Reviewed by Ryosuke Niwa.
317
318         Spell checking is enabled by adding a flag (t/text-checking)
319         with launching MiniBrowser.
320
321         * MiniBrowser/efl/main.c:
322         (window_create):
323         (elm_main):
324
325 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
326
327         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
328         https://bugs.webkit.org/show_bug.cgi?id=113281
329
330         Reviewed by Darin Adler.
331
332         * Scripts/run-gtk-tests:
333         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
334
335 2013-04-09  Glenn Adams  <glenn@skynav.com>
336
337         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
338
339         Unreviewed.
340
341         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
342         (RunTest.test_build_check):
343
344 2013-04-09  Glenn Adams  <glenn@skynav.com>
345
346         [webkitpy] Remove chromium ports.
347         https://bugs.webkit.org/show_bug.cgi?id=114326
348
349         Reviewed by Dirk Pranke.
350
351         As a side effect, also:
352
353         - remove chromium builders from webkitpy.layout_tests.port.builders
354         - remove chromium builders from rebaseline
355         - rewrite chromium dependent tests in rebaseline_unittest
356         - remove chromium platform from garden-o-matic
357         - select apple platform as default platform in garden-o-matic
358         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
359
360         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
361         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
362         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
363         (BaselineOptimizerTest.test_move_baselines):
364         (BaselineOptimizerTest.test_efl):
365         (BaselineOptimizerTest.test_no_add_mac_future):
366         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
367         (BaselineOptimizerTest.test_common_directory_includes_root):
368         (BaselineOptimizerTest.test_complex_shadowing):
369         (BaselineOptimizerTest.test_virtual_ports_filtered):
370         * Scripts/webkitpy/layout_tests/port/builders.py:
371         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
372         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
373         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
374         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
375         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
376         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
377         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
378         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
379         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
380         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
381         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
382         * Scripts/webkitpy/layout_tests/port/factory.py:
383         (platform_options):
384         (PortFactory):
385         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
386         (FactoryTest.test_qt):
387         (FactoryTest.test_get_from_builder_name):
388         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
389         (RunTest.test_build_check):
390         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
391         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
392         * Scripts/webkitpy/tool/commands/rebaseline.py:
393         (Rebaseline._builders_to_pull_from):
394         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
395         (_BaseTestCase):
396         (_BaseTestCase.setUp):
397         (TestRebaselineTest.setUp):
398         (TestRebaselineTest.test_baseline_directory):
399         (test_rebaseline_updates_expectations_file):
400         (test_rebaseline_does_not_include_overrides):
401         (test_rebaseline_test):
402         (test_rebaseline_test_and_print_scm_changes):
403         (test_rebaseline_and_copy_test):
404         (test_rebaseline_and_copy_test_no_existing_result):
405         (test_rebaseline_and_copy_test_with_lion_result):
406         (test_rebaseline_and_copy_no_overwrite_test):
407         (TestRebaselineExpectations.test_rebaseline_expectations):
408
409 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
410
411         newcommitbot (WKR) requires a subversion checkout
412         https://bugs.webkit.org/show_bug.cgi?id=114309
413
414         Reviewed by Benjamin Poulain.
415
416         Directly talk to the subversion server instead of relying on a local checkout.
417         This allows us to run WKR off of a git clone.
418
419         * Scripts/webkitpy/tool/commands/newcommitbot.py:
420         (NewCommitBot.next_work_item):
421         (NewCommitBot.process_work_item):
422
423 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
424
425         webkitbot refers to sheriffbot in help
426         https://bugs.webkit.org/show_bug.cgi?id=114307
427
428         Reviewed by Benjamin Poulain.
429
430         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
431
432         * Scripts/webkitpy/tool/bot/irc_command.py:
433         (Help):
434         (Help.execute):
435         (RollChromiumDEPS.execute):
436         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
437         (IRCBotTest.test_help):
438         * Scripts/webkitpy/tool/bot/sheriff.py:
439         (Sheriff.name):
440
441 2013-04-06  Roger Fong  <roger_fong@apple.com>
442
443         Kill old processes between runs on WinEWS bots.
444         Temporarily disable tests to let bots catch up again.
445
446         * EWSTools/start-queue-win.sh:
447         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
448         (WinEWS):
449
450 2013-04-09  Glenn Adams  <glenn@skynav.com>
451
452         [webkitpy] Remove chromium deprecated port support.
453         https://bugs.webkit.org/show_bug.cgi?id=114228
454
455         Reviewed by Ryosuke Niwa.
456
457         * Scripts/webkitpy/common/config/ports.py:
458         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
459         (ChromiumPort): Removed.
460         (ChromiumAndroidPort): Removed.
461         (ChromiumXVFBPort): Removed.
462         * Scripts/webkitpy/common/config/ports_unittest.py:
463         (DeprecatedPortTest.test_chromium_port): Removed.
464         (DeprecatedPortTest.test_chromium_android_port): Removed.
465         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
466         * Scripts/webkitpy/tool/steps/update_unittest.py:
467         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
468         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
469
470 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
471
472         AX: The bounding paths should be made available through accessibility
473         https://bugs.webkit.org/show_bug.cgi?id=113817
474
475         Reviewed by David Kilzer.
476
477         Add a pathDescription property for testing so that it's possible
478         to verify that a path is being returned correctly.
479
480         * DumpRenderTree/AccessibilityUIElement.cpp:
481         (getPathDescriptionCallback):
482         (AccessibilityUIElement::pathDescription):
483         (AccessibilityUIElement::getJSClass):
484         * DumpRenderTree/AccessibilityUIElement.h:
485         (AccessibilityUIElement):
486         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
487         (_CGPathEnumerationIteration):
488         (AccessibilityUIElement::pathDescription):
489         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
490         (AccessibilityUIElement::pathDescription):
491         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
492         (WTR::AccessibilityUIElement::pathDescription):
493         (WTR):
494         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
495         (AccessibilityUIElement):
496         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
497         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
498         (WTR::AccessibilityUIElement::pathDescription):
499         (WTR):
500
501 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
502
503         [EFL] Declare TEST_THEME_DIR in a single place.
504         https://bugs.webkit.org/show_bug.cgi?id=114285
505
506         Reviewed by Anders Carlsson.
507
508         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
509
510         * DumpRenderTree/efl/CMakeLists.txt:
511         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
512         (DumpRenderTreeChrome::createView):
513         (DumpRenderTreeChrome::createInspectorView):
514         (DumpRenderTreeChrome::initialize):
515         (DumpRenderTreeChrome::onDownloadRequest):
516         * EWebLauncher/CMakeLists.txt:
517         * EWebLauncher/main.c:
518         (findThemePath):
519         * EWebLauncher/url_bar.c:
520         (url_bar_add):
521         * MiniBrowser/efl/CMakeLists.txt:
522         * MiniBrowser/efl/main.c:
523         (window_create):
524         * TestWebKitAPI/PlatformEfl.cmake:
525         * TestWebKitAPI/efl/PlatformWebView.cpp:
526         (TestWebKitAPI::PlatformWebView::PlatformWebView):
527         * WebKitTestRunner/PlatformEfl.cmake:
528         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
529         (WTR::PlatformWebView::PlatformWebView):
530
531 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
532
533         [GTK][AC] upversion of clutter and its dependecy
534         https://bugs.webkit.org/show_bug.cgi?id=114016
535
536         Reviewed by Gustavo Noronha Silva.
537
538         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
539
540         * gtk/jhbuild-optional.modules:
541
542 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
543
544         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
545         https://bugs.webkit.org/show_bug.cgi?id=89875
546
547         Reviewed by Maciej Stachowiak.
548
549         Add unit tests to verify if the handling of the open, openat, creat syscall
550         is being done right. We check if the Read/Write/ReadAndWrite permissions
551         are respected, if the canonical path is being resolved and if
552         the permissions are falling back to the topmost parent directory with a
553         policy set when the directory being opened has no policy.
554
555         We also test if any attempt of blocking SIGSYS is silently ignored.
556         SIGSYS cannot be blocked because in it's handler is where we hook
557         syscalls to the broker process.
558
559         Also added libseccomp to EFL's jhbuild to make the life of developers
560         willing to help easier.
561
562         * Scripts/webkitperl/FeatureList.pm:
563         * TestWebKitAPI/PlatformEfl.cmake:
564         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
565         (TestWebKitAPI):
566         (SeccompEnvironment):
567         (TestWebKitAPI::SeccompEnvironment::SetUp):
568         (TestWebKitAPI::SeccompEnvironment::TearDown):
569         (TestWebKitAPI::dummyHandler):
570         (TestWebKitAPI::TEST):
571         (TestWebKitAPI::stressTest):
572         * efl/jhbuild.modules:
573         * qmake/mkspecs/features/features.pri:
574
575 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
576
577         REGRESSION: Autocorrection doesn't work in DumpRenderTree
578         https://bugs.webkit.org/show_bug.cgi?id=113846
579
580         Reviewed by Alexey Proskuryakov.
581
582         The problem was that we were replacing NSSpellCheck's dictionary with our own
583         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
584
585         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
586         and "would" respectively in DumpRenderTree.
587
588         * DumpRenderTree/mac/DumpRenderTree.mm:
589         (resetDefaultsToConsistentValues):
590
591 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
592
593         Remove the gyp files for Tools
594         https://bugs.webkit.org/show_bug.cgi?id=114248
595
596         Reviewed by Ryosuke Niwa.
597
598         * DumpRenderTree/DumpRenderTree.gyp: Removed.
599         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
600         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
601         * DumpRenderTree/DumpRenderTree.gypi: Removed.
602         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
603         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
604         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
605         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
606
607 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
608
609         WKR (new-commit-bot) is too slow
610         https://bugs.webkit.org/show_bug.cgi?id=110087
611
612         Reviewed by Geoffrey Garen.
613
614         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
615         Just run "svn log -r <revision>" instead to cut down the delay.
616
617         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
618
619         * Scripts/webkitpy/tool/commands/newcommitbot.py:
620         (NewCommitBot):
621         (NewCommitBot.next_work_item):
622         (NewCommitBot._is_empty_log):
623         (NewCommitBot._update_checkout):
624
625 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
626
627         Build fix. Can't remove appendCustomBuildFlags.
628
629         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
630         (appendCustomBuildFlags):
631
632 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
633
634         Remove Chromium builders from build.webkit.org
635         https://bugs.webkit.org/show_bug.cgi?id=113990
636
637         Reviewed by Benjamin Poulain.
638
639         Removed.
640
641         * BuildSlaveSupport/build.webkit.org-config/config.json:
642         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
643         (InstallGtkDependencies):
644         (RunUnitTests.start):
645         (RunWebKit2Tests.start):
646         (Factory.__init__):
647         (unitTestsSupported):
648         (TestFactory.__init__):
649         (BuildAndTestFactory.__init__):
650         (BuildAndPerfTestFactory.__init__):
651         (BuildAndPerfTestWebKit2Factory.__init__):
652         (DownloadAndPerfTestFactory.__init__):
653         (loadBuilderConfig):
654         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
655
656 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
657
658         Remove HTML Notification
659         https://bugs.webkit.org/show_bug.cgi?id=114231
660
661         Reviewed by Ryosuke Niwa.
662
663         * qmake/mkspecs/features/features.pri:
664
665 2013-04-08  Glenn Adams  <glenn@skynav.com>
666
667         Remove chromium EWS support, and fix broken test.
668         https://bugs.webkit.org/show_bug.cgi?id=114221
669
670         Reviewed by Ryosuke Niwa.
671
672         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
673         (AbstractChromiumEWS): Removed.
674         (ChromiumLinuxEWS): Removed.
675         (ChromiumLinuxDebugEWS): Removed.
676         (ChromiumWindowsEWS): Removed.
677         (ChromiumAndroidEWS): Removed.
678         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
679         (EarlyWarningSystemTest): Fix misspelled class name.
680         (test_ewses): Fix entry point name to ensure test is run.
681
682 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
683
684         [WIN] Remove WebKit2 source code
685         https://bugs.webkit.org/show_bug.cgi?id=114096
686
687         Reviewed by Anders Carlsson.
688
689         Remove the windows specific parts of the MiniBrowser.
690
691         * MiniBrowser/MiniBrowser.vcproj: Removed.
692         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
693         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
694         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
695         * MiniBrowser/win/BrowserView.cpp: Removed.
696         * MiniBrowser/win/BrowserView.h: Removed.
697         * MiniBrowser/win/BrowserWindow.cpp: Removed.
698         * MiniBrowser/win/BrowserWindow.h: Removed.
699         * MiniBrowser/win/MiniBrowser.cpp: Removed.
700         * MiniBrowser/win/MiniBrowser.h: Removed.
701         * MiniBrowser/win/MiniBrowser.rc: Removed.
702         * MiniBrowser/win/main.cpp: Removed.
703         * MiniBrowser/win/resource.h: Removed.
704         * MiniBrowser/win/stdafx.cpp: Removed.
705         * MiniBrowser/win/stdafx.h: Removed.
706
707 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
708
709         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
710
711         * Scripts/webkitpy/common/config/irc.py:
712
713 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
714
715         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
716         https://bugs.webkit.org/show_bug.cgi?id=113139
717
718         Reviewed by Anders Carlsson.
719
720         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
721         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
722         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
723         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
724         (ToStringAndValueOfObject):
725         (ToStringAndValueOfObject::ToStringAndValueOfObject):
726         (ScriptableObject):
727         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
728         (ToStringAndValueOfObject::ScriptableObject::invoke):
729         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
730         (ToStringAndValueOfObject::NPP_GetValue):
731         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
732         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
733         * GNUmakefile.am:
734
735 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
736
737         [GTK] Bump gnome-themes-standard to 3.6.0
738         https://bugs.webkit.org/show_bug.cgi?id=114155
739
740         Reviewed by Martin Robinson.
741
742         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
743         dependency of gnome-themes-standard accordingly.
744
745 2013-04-08  David Levin  <levin@chromium.org>
746
747         Remove my watchlist entries.
748         https://bugs.webkit.org/show_bug.cgi?id=114180
749
750         Reviewed by Adam Barth.
751
752         * Scripts/webkitpy/common/config/committers.py:
753         * Scripts/webkitpy/common/config/watchlist:
754
755 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
756
757         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
758         https://bugs.webkit.org/show_bug.cgi?id=114161
759
760         Reviewed by Gyuyoung Kim.
761
762         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
763         as it is crashing due to Bug 111074.
764
765         * TestWebKitAPI/PlatformEfl.cmake:
766
767 2013-04-07  David Kilzer  <ddkilzer@apple.com>
768
769         Remove the rest of SVG_DOM_OBJC_BINDINGS
770         <http://webkit.org/b/114112>
771
772         Reviewed by Geoffrey Garen.
773
774         * Scripts/webkitperl/FeatureList.pm:
775         - Remove --svg-dom-objc-bindings switch.
776         * qmake/mkspecs/features/features.pri:
777         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
778
779 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
780
781         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
782         https://bugs.webkit.org/show_bug.cgi?id=114089
783
784         Reviewed by Chris Fleizach.
785
786         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
787         * DumpRenderTree/AccessibilityController.cpp:
788         * DumpRenderTree/AccessibilityUIElement.cpp:
789         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
790         (DumpRenderTreeChrome::DumpRenderTreeChrome):
791         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
792         (DumpRenderTreeChrome):
793
794 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
795
796         Build fix after r147857, remove remaining USE(JSC) guards.
797
798         Unreviewed.
799
800         * DumpRenderTree/config.h:
801         * TestWebKitAPI/config.h:
802         * WebKitTestRunner/config.h:
803
804 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
805
806         Rename sheriffbot to webkitbot
807         https://bugs.webkit.org/show_bug.cgi?id=114109
808
809         Reviewed by Benjamin Poulain.
810
811         Renamed since sheriffbot will be used in Blink.
812
813         * Scripts/webkitpy/tool/commands/sheriffbot.py:
814         (SheriffBot):
815         (SheriffBot.begin_work_queue):
816
817 2013-04-06  Oliver Hunt  <oliver@apple.com>
818
819         Unify the many and varied stack trace mechanisms, and make the result sane.
820         https://bugs.webkit.org/show_bug.cgi?id=114072
821
822         Reviewed by Filip Pizlo.
823
824         The commandline jsc executable no longer requires arguments, so
825         I've made run-jsc work without them.
826
827         * Scripts/run-jsc:
828
829 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
830
831         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
832         https://bugs.webkit.org/show_bug.cgi?id=114086
833
834         Reviewed by Tim Horton.
835
836         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
837
838 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
839
840         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
841         https://bugs.webkit.org/show_bug.cgi?id=114083
842
843         Reviewed by Ryosuke Niwa.
844
845         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
846         in TestWebKitAPI and WebKitTestRunner.
847
848         * TestWebKitAPI/config.h:
849         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
850         (TestWebKitAPI::InjectedBundleController::platformInitialize):
851         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
852         (WTR::InjectedBundle::platformInitialize):
853
854 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
855
856         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
857         https://bugs.webkit.org/show_bug.cgi?id=114094
858
859         Reviewed by Anders Carlsson.
860
861         * Scripts/run-jsc:
862
863 2013-04-05  Ojan Vafai  <ojan@chromium.org>
864
865         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
866         https://bugs.webkit.org/show_bug.cgi?id=114080
867
868         Reviewed by Ryosuke Niwa.
869
870         This way, the WebKit and Blink dashboard code can change as appropriate without
871         needing to consider the other project's needs. This still doesn't update the
872         buildbots to upload to the new location, or the dashboard code to pull the
873         results.json files from the new location, but it at least allows for changing the
874         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
875
876         * TestResultServer/app.yaml:
877
878 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
879
880         Re-enable testing on the commit queue
881         https://bugs.webkit.org/show_bug.cgi?id=114078
882
883         Reviewed by Darin Adler.
884
885         Re-enabled the feature and the associated tests.
886
887         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
888         (CommitQueueTask.run):
889         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
890         (CommitQueueTaskTest._run_through_task):
891         * Scripts/webkitpy/tool/commands/queues_unittest.py:
892         (CommitQueueTest._mock_test_result):
893
894 2013-04-05  Oliver Hunt  <oliver@apple.com>
895
896         Unify the many and varied stack trace mechanisms, and make the result sane.
897         https://bugs.webkit.org/show_bug.cgi?id=114072
898
899         Reviewed by Filip Pizlo.
900
901         The commandline jsc executable no longer requires arguments, so
902         I've made run-jsc work without them.
903
904         * Scripts/run-jsc:
905
906 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
907
908         AX: Make SVG Group containers accessible elements
909         https://bugs.webkit.org/show_bug.cgi?id=113939
910
911         Reviewed by Simon Fraser.
912
913         Implement axController.elementAtPoint for iOS.
914         Implement a correct version of clickPoint for iOS.
915
916         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
917         (AccessibilityController::elementAtPoint):
918         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
919         (AccessibilityUIElement::clickPointX):
920         (AccessibilityUIElement::clickPointY):
921
922 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
923
924         Unreviewed, rolling out r147773 and r147774.
925         http://trac.webkit.org/changeset/147773
926         http://trac.webkit.org/changeset/147774
927         https://bugs.webkit.org/show_bug.cgi?id=114056
928
929         Causing some exceptions on AppEngine I don't understand
930         (Requested by rniwa on #webkit).
931
932         * QueueStatusServer/config/queues.py:
933         * QueueStatusServer/model/queues.py:
934         (Queue.short_name):
935         (Queue.display_name):
936         * QueueStatusServer/model/queues_unittest.py:
937         (QueueTest.test_short_name):
938         (QueueTest.test_display_name):
939         (QueueTest.test_name_with_underscores):
940
941 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
942
943         Fixed run-bindings-tests by removing V8
944         https://bugs.webkit.org/show_bug.cgi?id=114053
945
946         Reviewed by Benjamin Poulain.
947
948         * Scripts/run-bindings-tests:
949         (main):
950
951 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
952
953         Build fix.
954
955         * QueueStatusServer/model/queues.py:
956         (Queue.short_name):
957         (Queue.display_name):
958
959 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
960
961         Remove Chromium EWS bots from the queue status server
962         https://bugs.webkit.org/show_bug.cgi?id=113988
963
964         Reviewed by Benjamin Poulain.
965
966         Removed Chromium EWS bots.
967
968         * QueueStatusServer/config/queues.py:
969         * QueueStatusServer/model/queues.py:
970         (Queue.short_name):
971         (Queue.display_name):
972         * QueueStatusServer/model/queues_unittest.py:
973         (QueueTest.test_short_name):
974         (QueueTest.test_display_name):
975         (QueueTest.test_name_with_underscores):
976
977 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
978
979         [EFL] Enable indexed database
980         https://bugs.webkit.org/show_bug.cgi?id=107248
981
982         Reviewed by Alexis Menard.
983
984         * Scripts/webkitperl/FeatureList.pm:
985
986 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
987
988         Remove vestiges of Chromium bits from watchlists.
989         https://bugs.webkit.org/show_bug.cgi?id=114047
990
991         Reviewed by Ryosuke Niwa.
992
993         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
994
995 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
996
997         Add James Craig to the contributors list.
998
999         * Scripts/webkitpy/common/config/committers.py:
1000
1001 2013-04-04  Kent Tamura  <tkent@chromium.org>
1002
1003         Remove ChromiumPublicApi pattern, and cc/message rules for it.
1004
1005         * Scripts/webkitpy/common/config/watchlist:
1006
1007 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1008
1009         Temporarily disable the Python unittests broken by the commit queue not running layout tests
1010         https://bugs.webkit.org/show_bug.cgi?id=113997
1011
1012         Reviewed by Ryosuke Niwa.
1013
1014         Disable the tests until Ryosuke gets the time and hardware to have
1015         a testing commit-queue.
1016
1017         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1018         (CommitQueueTaskTest):
1019         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1020         (CommitQueueTest):
1021
1022 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1023
1024         Remove Chromium builders from build.webkit.org
1025         https://bugs.webkit.org/show_bug.cgi?id=113990
1026
1027         Reviewed by Benjamin Poulain.
1028
1029         Land the part to disable triggering of Chromium builders first so that we may start
1030         deleting more Chromium code that breaks the update step.
1031
1032         * BuildSlaveSupport/build.webkit.org-config/config.json:
1033
1034 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
1035
1036         Remove Chromium's DumpRenderTree
1037         https://bugs.webkit.org/show_bug.cgi?id=113989
1038
1039         Reviewed by Kent Tamura.
1040
1041         On second thought, let's not go to Camelot. It is a silly place.
1042
1043         * DumpRenderTree/mac/DumpRenderTree.mm:
1044         (resetDefaultsToConsistentValues):
1045
1046 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
1047
1048         Nixed the defunct chromium folder from DumpRenderTree
1049         https://bugs.webkit.org/show_bug.cgi?id=113993
1050
1051         Reviewed by Ryosuke Niwa.
1052
1053         * DumpRenderTree/chromium: Removed.
1054         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
1055         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
1056         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
1057         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
1058         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
1059         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
1060         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
1061         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
1062         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
1063         * DumpRenderTree/chromium/MockPlatform.h: Removed.
1064         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
1065         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
1066         * DumpRenderTree/chromium/Task.cpp: Removed.
1067         * DumpRenderTree/chromium/Task.h: Removed.
1068         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
1069         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
1070         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
1071         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
1072         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
1073         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
1074         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
1075         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1076         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1077         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1078         * DumpRenderTree/chromium/TestRunner: Removed.
1079         * DumpRenderTree/chromium/TestRunner/public: Removed.
1080         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
1081         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
1082         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
1083         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
1084         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
1085         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
1086         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
1087         * DumpRenderTree/chromium/TestRunner/src: Removed.
1088         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
1089         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
1090         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
1091         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
1092         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
1093         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
1094         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
1095         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
1096         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
1097         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
1098         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
1099         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
1100         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
1101         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
1102         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
1103         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
1104         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
1105         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
1106         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
1107         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
1108         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
1109         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
1110         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
1111         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
1112         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
1113         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
1114         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
1115         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
1116         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
1117         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
1118         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
1119         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
1120         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
1121         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
1122         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
1123         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
1124         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
1125         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
1126         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
1127         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
1128         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
1129         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
1130         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
1131         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
1132         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
1133         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
1134         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
1135         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
1136         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
1137         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
1138         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
1139         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
1140         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
1141         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
1142         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
1143         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
1144         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1145         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
1146         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
1147         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1148         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
1149         * DumpRenderTree/chromium/TestShell.cpp: Removed.
1150         * DumpRenderTree/chromium/TestShell.h: Removed.
1151         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1152         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
1153         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
1154         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1155         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
1156         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
1157         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
1158         * DumpRenderTree/chromium/WebViewHost.h: Removed.
1159         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
1160         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
1161         * DumpRenderTree/chromium/config.h: Removed.
1162         * DumpRenderTree/chromium/fonts.conf: Removed.
1163
1164 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1165
1166         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
1167
1168         Rubber stamped by Benjamin Poulain.
1169
1170         * RebaselineQueueServer: Removed.
1171         * RebaselineQueueServer/app.yaml: Removed.
1172         * RebaselineQueueServer/handlers: Removed.
1173         * RebaselineQueueServer/handlers/__init__.py: Removed.
1174         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
1175         * RebaselineQueueServer/handlers/pages.py: Removed.
1176         * RebaselineQueueServer/index.yaml: Removed.
1177         * RebaselineQueueServer/main.py: Removed.
1178         * RebaselineQueueServer/model: Removed.
1179         * RebaselineQueueServer/model/__init__.py: Removed.
1180         * RebaselineQueueServer/model/queueentry.py: Removed.
1181         * RebaselineQueueServer/static: Removed.
1182         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
1183         * RebaselineQueueServer/static/styles.css: Removed.
1184         * RebaselineQueueServer/templates: Removed.
1185         * RebaselineQueueServer/templates/builder-picker.html: Removed.
1186         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
1187         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
1188         * RebaselineQueueServer/templates/home.html: Removed.
1189
1190 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1191
1192         Fix setup-commit-queue and temporarily disable testing on commit-queue
1193         https://bugs.webkit.org/show_bug.cgi?id=113979
1194
1195         Reviewed by Benjamin Poulain.
1196
1197         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
1198         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
1199
1200         * EWSTools/setup-commit-queue.sh:
1201         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1202         (CommitQueueTask.run):
1203
1204 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1205
1206         temporarily make flakiness dashboard work again webkit.org bots
1207         https://bugs.webkit.org/show_bug.cgi?id=113972
1208
1209         Reviewed by Ojan Vafai.
1210
1211         This patch disables the chromium.org layout test bots TestExpectations
1212         parsing temporarily until we can work out the right way to split into
1213         two instances for webkit.org and chromium.org and figure out which
1214         code to delete where :).
1215
1216         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1217
1218 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1219
1220         Fix webkitpy tests after r147678.
1221
1222         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1223         (CommitQueueTest.test_commit_queue):
1224         (test_manual_reject_during_processing):
1225
1226 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1227
1228         The commit queue should use Mac MountainLion port
1229         https://bugs.webkit.org/show_bug.cgi?id=113971
1230
1231         Reviewed by Lucas Forschler.
1232
1233         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1234         * Scripts/webkitpy/tool/commands/queues.py:
1235         (CommitQueue):
1236
1237 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1238
1239         turn off running tests on chromium linux EWS bots
1240         https://bugs.webkit.org/show_bug.cgi?id=113959
1241
1242         Reviewed by Geoffrey Garen.
1243
1244         Now that the Chromium port is no longer being maintained
1245         there's little point in running the tests. Soon we should
1246         just shut this bot off altogether.
1247
1248         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1249         (ChromiumLinuxEWS):
1250
1251 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1252
1253         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1254
1255         * Scripts/webkitpy/common/config/watchlist:
1256
1257 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1258
1259         Indentation fix to get webkit-patch working again after r147625
1260
1261         Unreviewed.
1262
1263         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1264         (MacEWS):
1265         (MacWK2EWS):
1266
1267 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1268
1269         Turn tests back on for Mac WK1/WK2 EWS.
1270         
1271         Unreviewed.
1272         
1273         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1274         (MacEWS):
1275         (MacWK2EWS):
1276
1277 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1278
1279         [GTK][WK2] MiniBrowser custom URI scheme support
1280         https://bugs.webkit.org/show_bug.cgi?id=112419
1281
1282         Reviewed by Carlos Garcia Campos.
1283
1284         Add support for about URIs in MiniBrowser. An example about page is show
1285         with URI "about:minibrowser", the rest of the cases it will show a
1286         proper message explaining that the about page didn't exist.
1287
1288         Internally it uses "minibrowser-about" prefix instead of "about", but
1289         from the user point of view it works with "about" prefix.
1290
1291         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1292         (getInternalURI): Method to convert URIs from "about" prefix to
1293         "minibrowser-about".
1294         (getExternalURI): Opposite method.
1295         (webViewURIChanged): Use "about" prefix to show the URI to users.
1296         (webViewEnterFullScreen): Ditto.
1297         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1298         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1299         (aboutURISchemeRequestCallback): Callback to manage about calls.
1300         (main): Register the URI scheme to manage about URIs.
1301
1302 2013-04-03  Roger Fong  <roger_fong@apple.com>
1303
1304         Re-enable WinEWS tests.
1305
1306         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1307         (WinEWS):
1308
1309 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1310
1311         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1312         https://bugs.webkit.org/show_bug.cgi?id=113883
1313
1314         Reviewed by Martin Robinson.
1315
1316         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1317         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1318         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1319
1320 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1321
1322         [GTK] Include Pango in jhbuild-optional.modules
1323         https://bugs.webkit.org/show_bug.cgi?id=113878
1324
1325         Reviewed by Martin Robinson.
1326
1327         Since r147547 Pango 1.32.0 is required. Including the module in the
1328         JHBuild optional moduleset.
1329
1330         * gtk/jhbuild-optional.modules: Add Pango module.
1331
1332 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1333
1334         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1335         https://bugs.webkit.org/show_bug.cgi?id=113864
1336
1337         Moving setDefersLoading from TestRunnerQt to TestRunner
1338         requires access to the non-Qt TestRunner.
1339         As long as we instantiate both TestRunner and TestRunnerQt,
1340         we need a separate getter for the non-Qt TestRunner instance.
1341
1342         Reviewed by Simon Hausmann.
1343
1344         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1345         (WebPage::resetSettings):
1346         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1347         (DumpRenderTree::jscTestRunner):
1348         * DumpRenderTree/qt/TestRunnerQt.cpp:
1349         (TestRunner::setDefersLoading):
1350             Moving setDefersLoading from TestRunnerQt
1351             to TestRunner.
1352         * DumpRenderTree/qt/TestRunnerQt.h:
1353         (TestRunnerQt):
1354
1355 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1356
1357         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1358         https://bugs.webkit.org/show_bug.cgi?id=104779
1359
1360         Reviewed by Carlos Garcia Campos.
1361
1362         * Scripts/run-gtk-tests:
1363         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1364         passing in current trunk.
1365
1366 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1367
1368         Fix HAVE(QTTESTSUPPORT) logic
1369
1370         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1371         resulting in HAVE(QTTESTSUPPORT) never being true.
1372         Move that logic down in sanitizeFeatures.
1373
1374         Rubber-stamped by Tor Arne Vestbø.
1375
1376         * qmake/mkspecs/features/features.prf:
1377
1378 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1379
1380         [GTK] Bump required versions of some dependencies
1381         https://bugs.webkit.org/show_bug.cgi?id=113282
1382
1383         Reviewed by Martin Robinson.
1384
1385         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1386
1387 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1388
1389         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1390         https://bugs.webkit.org/show_bug.cgi?id=113809
1391
1392         Reviewed by Philippe Normand.
1393
1394         Newer Linux kernels have removed some deprecated macros from v4l2
1395         headers, causing gst-plugins-good's build to break. We don't need it
1396         right now, so just disable it.
1397
1398         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1399
1400 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1401
1402         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1403         https://bugs.webkit.org/show_bug.cgi?id=113535
1404
1405         Reviewed by Simon Hausmann.
1406
1407         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1408
1409         * qmake/mkspecs/features/features.prf:
1410
1411 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1412
1413         [Qt] Move logic of simple forwarding functions to TestRunner.
1414         https://bugs.webkit.org/show_bug.cgi?id=113863
1415
1416         Reviewed by Simon Hausmann.
1417
1418         * DumpRenderTree/qt/TestRunnerQt.cpp:
1419         (TestRunner::setTextDirection):
1420         (TestRunner::goBack):
1421         (TestRunner::evaluateScriptInIsolatedWorld):
1422         (TestRunner::addUserStyleSheet):
1423         * DumpRenderTree/qt/TestRunnerQt.h:
1424         (TestRunnerQt):
1425
1426 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1427
1428         [Qt] Disable media support using QuickTime if deployment target != SDK
1429
1430         We link to a single libWebKitSystemInterface static lib, so unless the
1431         deployment target matches the SDK let's not pretend like we'll be able
1432         to run on anything lower than the SDK version.
1433
1434         Reviewed by Simon Hausmann.
1435
1436         * qmake/mkspecs/features/features.prf:
1437
1438 2013-04-02  James Craig  <james@cookiecrook.com>
1439
1440         AXRoleDescripton for DL is "list"; should be "description list"
1441         https://bugs.webkit.org/show_bug.cgi?id=111665
1442
1443         Reviewed by Chris Fleizach.
1444
1445         Defining the role and description strings.
1446
1447         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1448
1449 2013-04-02  Roger Fong  <roger_fong@apple.com>
1450
1451         Unreviewed. Disable running tests on Win EWS queue.
1452
1453         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1454         (WinEWS):
1455
1456 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1457
1458         Disable running tests on the MAC WK2 EWS queue.
1459         
1460         Unreviewed.
1461         
1462         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1463         (MacWK2EWS):
1464
1465 2013-04-02  Julie Parent  <jparent@chromium.org>
1466
1467         Dashboard refactor: Move dashboard specific history related features to History.
1468         https://bugs.webkit.org/show_bug.cgi?id=113717
1469
1470         Reviewed by Ojan Vafai.
1471         
1472         Each dashboard now creates its own History object, with a custom
1473         configuration. This changes from just overriding global functions
1474         to passing in callbacks for generatePage, handleValidHashParameter,
1475         and handleQueryParameterChange. Same with passing in defaultStateValues
1476         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1477         variables.
1478         
1479         All functions related to these features are now (mostly) private
1480         function on History. 
1481         
1482         Loader no longer needs a loadingComplete callback, since it can just
1483         initialize the history object itself.
1484
1485         * TestResultServer/static-dashboards/aggregate_results.js:
1486         (handleValidHashParameter):
1487         * TestResultServer/static-dashboards/dashboard_base.js:
1488         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1489         (generatePage):
1490         (.switch.return):
1491         (handleQueryParameterChange):
1492         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1493         (resetGlobals):
1494         * TestResultServer/static-dashboards/history.js:
1495         (.):
1496         * TestResultServer/static-dashboards/loader.js:
1497         (.):
1498         * TestResultServer/static-dashboards/loader_unittests.js:
1499         * TestResultServer/static-dashboards/timeline_explorer.js:
1500         (generatePage):
1501         (initCurrentBuilderTestResults):
1502         * TestResultServer/static-dashboards/treemap.js:
1503         (generatePage):
1504         (.switch.return):
1505         (handleQueryParameterChange):
1506
1507 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1508
1509         Unreviewed, rolling out r147401.
1510         http://trac.webkit.org/changeset/147401
1511         https://bugs.webkit.org/show_bug.cgi?id=113767
1512
1513         The patch makes it extremely hard to set up the dependencies
1514         properly on the GTK builders (Requested by zdobersek on
1515         #webkit).
1516
1517         * gtk/jhbuild.modules:
1518
1519 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1520
1521         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1522         https://bugs.webkit.org/show_bug.cgi?id=113382
1523
1524         Reviewed by Gyuyoung Kim.
1525
1526         Do not show the empty tooltip box if the text is null.
1527
1528         * MiniBrowser/efl/main.c:
1529         (popup_menu_populate):
1530
1531 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1532
1533         [GTK] Bump required versions of some dependencies
1534         https://bugs.webkit.org/show_bug.cgi?id=113282
1535
1536         Reviewed by Martin Robinson.
1537
1538         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1539
1540 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1541
1542         Unreviewed, rolling out r147319.
1543         http://trac.webkit.org/changeset/147319
1544         https://bugs.webkit.org/show_bug.cgi?id=113707
1545
1546         The unit test is still failing on the buildbot (Requested by
1547         zdobersek on #webkit).
1548
1549         * Scripts/run-gtk-tests:
1550         (TestRunner):
1551
1552 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1553
1554         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1555         https://bugs.webkit.org/show_bug.cgi?id=104779
1556
1557         Reviewed by Carlos Garcia Campos.
1558
1559         * Scripts/run-gtk-tests:
1560         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1561         passing in current trunk.
1562
1563 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1564
1565         Unreviewed, rolling out r147289.
1566         http://trac.webkit.org/changeset/147289
1567         https://bugs.webkit.org/show_bug.cgi?id=113678
1568
1569         broke Win7 (dbg) build (Requested by shinyak|gardener on
1570         #webkit).
1571
1572         * DumpRenderTree/DumpRenderTree.gypi:
1573         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1574         (WebTestRunner):
1575         (WebUserMediaClientMock):
1576         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1577         (WebTestRunner::WebUserMediaClientMock::taskList):
1578         * Scripts/webkitpy/style/checkers/cpp.py:
1579         (check_function_definition):
1580
1581 2013-03-31  Adam Barth  <abarth@webkit.org>
1582
1583         configure-svn-config.sh fails
1584         https://codereview.chromium.org/13392007/
1585
1586         Reviewed by Eric Seidel.
1587
1588         This script was trying to use "svn checkout" to dowload a file from
1589         svn.webkit.org, but "svn checkout" only works with directories.
1590         Instead, we should use "svn export".
1591
1592         * EWSTools/configure-svn-config.sh:
1593
1594 2013-03-31  Wei Jia  <wjia@chromium.org>
1595
1596         Allow WebUserMediaClientMock to be used by client
1597         https://bugs.webkit.org/show_bug.cgi?id=113633
1598
1599         Reviewed by Adam Barth.
1600
1601         Export WebUserMediaClientMock.
1602         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1603
1604         * DumpRenderTree/DumpRenderTree.gypi:
1605         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1606         (WebUserMediaClientMock):
1607         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1608         * Scripts/webkitpy/style/checkers/cpp.py:
1609         (check_function_definition):
1610
1611 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1612
1613         Expose FeatureObserver data to WebKit clients
1614         https://bugs.webkit.org/show_bug.cgi?id=113613
1615
1616         Reviewed by Sam Weinig.
1617
1618         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1619         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1620
1621 2013-03-29  Greg Hughes  <ghughes@apple.com>
1622
1623         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1624         https://bugs.webkit.org/show_bug.cgi?id=112276
1625
1626         Reviewed by Chris Fleizach.
1627
1628         Added support to test accessibility search predicates with multiple keys.  
1629
1630         * DumpRenderTree/AccessibilityUIElement.cpp:
1631         (uiElementForSearchPredicateCallback):
1632         * DumpRenderTree/AccessibilityUIElement.h:
1633         (AccessibilityUIElement):
1634         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1635         (AccessibilityUIElement::uiElementForSearchPredicate):
1636         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1637         (AccessibilityUIElement::uiElementForSearchPredicate):
1638         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1639         (AccessibilityUIElement::uiElementForSearchPredicate):
1640         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1641         (AccessibilityUIElement::uiElementForSearchPredicate):
1642         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1643         (AccessibilityUIElement::uiElementForSearchPredicate):
1644         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1645         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1646         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1647         (AccessibilityUIElement):
1648         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1649         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1650         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1651         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1652         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1653
1654 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1655
1656         Fix a typo in r147147 to fix Mac EWS.
1657
1658         * Scripts/webkitpy/tool/commands/queues.py:
1659         (PatchProcessingQueue._new_port_name_from_old):
1660
1661 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1662
1663         [EFL] Build break with latest EFL libraries after r146265
1664         https://bugs.webkit.org/show_bug.cgi?id=113558
1665
1666         Unreviewed build fix.
1667
1668         * TestWebKitAPI/PlatformWebView.h:
1669         * WebKitTestRunner/PlatformWebView.h:
1670
1671 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1672
1673         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1674
1675         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1676         in libgcrypt build.
1677
1678 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1679
1680         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1681
1682         Unreviewed.
1683
1684         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1685         (MacEWS):
1686
1687 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1688
1689         Use the right OS name on Mac EWS instead of mac-future.
1690
1691         Rubber-stamped by Dirk Pranke.
1692
1693         * Scripts/webkitpy/tool/commands/queues.py:
1694         (PatchProcessingQueue._new_port_name_from_old):
1695         (PatchProcessingQueue.begin_work_queue):
1696         (PatchProcessingQueue._upload_results_archive_for_patch):
1697
1698 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1699
1700         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1701         https://bugs.webkit.org/show_bug.cgi?id=112546
1702
1703         Reviewed by Martin Robinson.
1704
1705         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1706         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1707
1708 2013-03-28  Ming Xie  <mxie@blackberry.com>
1709
1710         [BlackBerry] Committer Email Updates
1711         https://bugs.webkit.org/show_bug.cgi?id=113435
1712
1713         Reviewed by Rob Buis.
1714
1715         Add the @blackberry.com email address for all our BlackBerry
1716         WebKit committers. This is the first step for our email address
1717         migration.
1718
1719         * Scripts/webkitpy/common/config/committers.py:
1720
1721 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1722
1723         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1724         https://bugs.webkit.org/show_bug.cgi?id=113508
1725
1726         Reviewed by Martin Robinson.
1727
1728         Prevent the GStreamer plugin scanner to load system-wide
1729         plugins. Only the ones built in JHBuild should be loaded and used
1730         at runtime.
1731
1732         * efl/jhbuildrc:
1733         * gtk/jhbuildrc:
1734
1735 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1736
1737         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1738         https://bugs.webkit.org/show_bug.cgi?id=113386
1739
1740         Reviewed by Carlos Garcia Campos.
1741
1742         * Scripts/webkitdirs.pm:
1743         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1744         version to 3.0. Reflect this change so the builtDylibPathForName
1745         function doesn't fail to report the library as found.
1746
1747 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1748
1749         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1750         https://bugs.webkit.org/show_bug.cgi?id=113484
1751
1752         Unreviewed build fix.
1753
1754         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1755
1756         * TestWebKitAPI/CMakeLists.txt:
1757         * WebKitTestRunner/CMakeLists.txt:
1758
1759 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1760
1761         Revision for the internal jhbuild is too old
1762         https://bugs.webkit.org/show_bug.cgi?id=113324
1763
1764         Reviewed by Martin Robinson.
1765
1766         Update the minimum required version to a point where jhbuild won't
1767         fail installing packages when trying to remove a symlink to a directory.
1768
1769         * jhbuild/jhbuild-wrapper: Updated revision.
1770
1771 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1772
1773         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1774         https://bugs.webkit.org/show_bug.cgi?id=113203
1775
1776         Reviewed by Philippe Normand.
1777
1778         We build our libsoup without GNOME support. gst-plugins-good does separate
1779         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1780         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1781         build failures as the headers of those diverge. We do not use souphttpsrc, so
1782         disable it when building gst-plugins-good.
1783
1784         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1785
1786 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1787
1788         Build fix after r146852. Please another reference to the Lion leaks builder.
1789
1790         * BuildSlaveSupport/build.webkit.org-config/config.json:
1791
1792 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1793
1794         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1795         https://bugs.webkit.org/show_bug.cgi?id=113421
1796
1797         Reviewed by Dirk Pranke.
1798
1799         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1800         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1801         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1802         in the GTK-specific TestExpectations files.
1803
1804         To avoid this only enable the warnings only when not using WKTR.
1805
1806         * Scripts/webkitpy/layout_tests/port/gtk.py:
1807         (GtkPort.warn_if_bug_missing_in_test_expectations):
1808
1809 2013-03-27  Antti Koivisto  <antti@apple.com>
1810
1811         Fix Zalan's email.
1812
1813         * Scripts/webkitpy/common/config/committers.py:
1814
1815 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1816
1817         master.cfg cleanup
1818         https://bugs.webkit.org/show_bug.cgi?id=113195
1819
1820         Reviewed by Ryosuke Niwa.
1821
1822         * BuildSlaveSupport/build.webkit.org-config/config.json:
1823         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1824
1825 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1826
1827         master.cfg fine-tuning for Qt Mountain Lion Release bot
1828         https://bugs.webkit.org/show_bug.cgi?id=113191
1829
1830         Reviewed by Ryosuke Niwa.
1831
1832         * BuildSlaveSupport/build.webkit.org-config/config.json:
1833           - Rename the slave due to its location change.
1834           - Update the platform of the slave.
1835         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1836         (RunQtAPITests): Enable running WK2 API tests on Qt.
1837         (RunQtAPITests.start):
1838         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1839         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1840
1841 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1842
1843         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1844         https://bugs.webkit.org/show_bug.cgi?id=113403
1845
1846         Reviewed by Kenneth Rohde Christiansen.
1847
1848         As of Evas 1.7.5, when Wayland is detected on the system, support for
1849         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1850         The code, however, seems to depend on a few other flags which must be
1851         explicitly enabled.
1852
1853         If those additional GL-related options are passed, we end up
1854         having issues on the WebKit side, so disable Wayland support for
1855         now.
1856
1857         * efl/jhbuild.modules:
1858
1859 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1860
1861         Unreviewed, rolling out r146864.
1862         http://trac.webkit.org/changeset/146864
1863         https://bugs.webkit.org/show_bug.cgi?id=113391
1864
1865         causes crashes on Wk2 EFL release bot (Requested by drott on
1866         #webkit).
1867
1868         * Scripts/webkitperl/FeatureList.pm:
1869
1870 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1871
1872         [jhbuild] Correctly specify an alternate number of make jobs.
1873         https://bugs.webkit.org/show_bug.cgi?id=113396
1874
1875         Reviewed by Philippe Normand.
1876
1877         So far, we were using the `MAKEFLAGS' environment variable to pass the
1878         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1879         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1880
1881         We now behave more closely to the rest of the WebKit tools by first
1882         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1883         not set, just letting jhbuild itself figure out how many jobs to use.
1884
1885         * efl/jhbuildrc:
1886         * gtk/jhbuildrc:
1887
1888 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1889
1890         [Qt] Remove Qt specific WorkQueueItem definitions.
1891         https://bugs.webkit.org/show_bug.cgi?id=112891
1892
1893         This patch is preparation work for removing
1894         WorkQueue related code from TestRunnerQt and
1895         replacing it with generic TestRunner code.
1896
1897         Reviewed by Benjamin Poulain.
1898
1899         * DumpRenderTree/qt/TestRunnerQt.cpp:
1900         (TestRunnerQt::queueBackNavigation):
1901         (TestRunnerQt::queueForwardNavigation):
1902         (TestRunnerQt::queueLoadHTMLString):
1903         (TestRunnerQt::queueReload):
1904         (TestRunnerQt::queueLoadingScript):
1905         (TestRunnerQt::queueNonLoadingScript):
1906         (TestRunner::queueLoad):
1907         * DumpRenderTree/qt/TestRunnerQt.h:
1908         (TestRunnerQt):
1909         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1910         (LoadItem::invoke):
1911         (LoadHTMLStringItem::invoke):
1912         (LoadAlternateHTMLStringItem::invoke):
1913         (ReloadItem::invoke):
1914         (ScriptItem::invoke):
1915         (BackForwardItem::invoke):
1916         * DumpRenderTree/qt/WorkQueueItemQt.h:
1917         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1918         (LoadAlternateHTMLStringItem):
1919
1920 2013-03-26  Julie Parent  <jparent@chromium.org>
1921
1922         Flakiness dashboard: simplify logic around which tests to show.
1923         https://bugs.webkit.org/show_bug.cgi?id=113250
1924
1925         Reviewed by Ojan Vafai.
1926         
1927         The different filters for showing results are only used for layout
1928         tests, otherwise, we show everything.
1929         
1930         Change the defaults to false (what layout tests used), and only
1931         look at the values when viewing layout tests.
1932
1933         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1934         (htmlForTestsWithExpectationsButNoFailures):
1935         (shouldHideTest):
1936
1937 2013-03-26  Isaac Levy  <ilevy@google.com>
1938
1939         Update bots on test-results.appspot
1940         https://bugs.webkit.org/show_bug.cgi?id=113333
1941
1942         Reviewed by Ojan Vafai.
1943
1944         * TestResultServer/static-dashboards/builders.jsonp:
1945
1946 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1947
1948         Unreviewed GTK gardening.
1949
1950         * Scripts/run-gtk-tests:
1951         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1952
1953 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1954
1955         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1956         https://bugs.webkit.org/show_bug.cgi?id=113287
1957
1958         Reviewed by Jocelyn Turcotte.
1959
1960         * Scripts/run-qtwebkit-tests:
1961         (Options.__init__):
1962
1963 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1964
1965         [EFL] Enable IndexedDB by default
1966         https://bugs.webkit.org/show_bug.cgi?id=107248
1967
1968         Reviewed by Laszlo Gombos.
1969
1970         * Scripts/webkitperl/FeatureList.pm:
1971         Enable IndexedDB by default on EFL.
1972
1973 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1974
1975         Sheriffbot should explain rollout failures in a human readable form.
1976         https://bugs.webkit.org/show_bug.cgi?id=107092
1977
1978         Reviewed by Ryosuke Niwa.
1979
1980         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1981
1982         * Scripts/webkitpy/tool/bot/irc_command.py:
1983         (Rollout._check_diff_failure):
1984         (Rollout.execute):
1985         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1986         (IRCCommandTest.test_rollout):
1987
1988 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1989
1990         Unreviewed GTK gardening.
1991
1992         * Scripts/run-gtk-tests:
1993         (TestRunner): Skipping a failing unit test after r146518.
1994
1995 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1996
1997         Remove Lion leaks builder
1998         https://bugs.webkit.org/show_bug.cgi?id=113252
1999
2000         Reviewed by Andreas Kling.
2001
2002         Removed.
2003
2004         * BuildSlaveSupport/build.webkit.org-config/config.json:
2005
2006 2013-03-25  Kent Tamura  <tkent@chromium.org>
2007
2008         Rename ENABLE_INPUT_TYPE_DATETIME
2009         https://bugs.webkit.org/show_bug.cgi?id=113254
2010
2011         Reviewed by Kentaro Hara.
2012
2013         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
2014         Actually I'd like to remove the code, but we shouldn't remove it yet
2015         because we shipped products with it on some platforms.
2016
2017         * Scripts/webkitperl/FeatureList.pm:
2018         * qmake/mkspecs/features/features.pri:
2019
2020 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2021
2022         Remove one more line that was intended to be removed in r146657.
2023
2024         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2025         (summarize_results):
2026
2027 2013-03-25  Roger Fong  <roger_fong@apple.com>
2028
2029         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
2030         Re-enable WinEWS tests.
2031
2032         * Scripts/webkitpy/common/config/ports.py:
2033         (WinPort.run_bindings_tests_command):
2034         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2035         (WinEWS):
2036
2037 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2038
2039         Unreviewed, rolling out r146793.
2040         http://trac.webkit.org/changeset/146793
2041         https://bugs.webkit.org/show_bug.cgi?id=113248
2042
2043         Fix did not work (Requested by rfong on #webkit).
2044
2045         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2046         (WinEWS):
2047
2048 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
2049
2050         REGRESSION(r146657): Test failures reported incorrectly
2051         https://bugs.webkit.org/show_bug.cgi?id=113223
2052
2053         Reviewed by Dirk Pranke.
2054
2055         The bug was caused by BuildBotPrinter not taking the new behavior into account.
2056
2057         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
2058         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
2059
2060         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2061         (Manager.run):
2062
2063         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2064         (RunDetails.__init__):
2065         (summarize_results): Remove the line I intended to remove in r146657.
2066
2067         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2068         (logging_run): Return details instead of the exit code.
2069         (run_and_capture): Ditto.
2070
2071         (RunTest.test_full_results_html):
2072         (RunTest.test_hung_thread):
2073         (RunTest.test_no_tests_found):
2074         (RunTest.test_no_tests_found_2):
2075         (RunTest.test_repeat_each_iterations_num_tests):
2076         (RunTest.test_run_singly_actually_runs_tests):
2077         (RunTest.test_test_list):
2078         (RunTest.test_missing_and_unexpected_results):
2079         (RunTest.test_pixel_test_directories):
2080         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
2081         (RunTest.test_crash_with_stderr):
2082         (RunTest.test_no_image_failure_with_image_diff):
2083         (RunTest.test_crash_log):
2084         (RunTest.test_exit_after_n_failures_upload):
2085         (RunTest.test_results_directory_absolute):
2086         (RunTest.test_results_directory_relative):
2087         (RunTest.test_retrying_and_flaky_tests):
2088         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
2089         (RunTest.test_retrying_uses_retries_directory):
2090         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
2091         (RunTest.test_output_diffs):
2092         (EndToEndTest.test_reftest_with_two_notrefs):
2093         (RebaselineTest.test_reset_results):
2094         (RebaselineTest.test_missing_results):
2095         (RebaselineTest.test_new_baseline):
2096
2097         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2098         (BuildBotPrinter.print_results):
2099         (BuildBotPrinter.print_unexpected_results):
2100         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
2101         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
2102
2103 2013-03-25  Julie Parent  <jparent@chromium.org>
2104
2105         Dashboard refactor: Move cross dashboard history related code into history.js.
2106         https://bugs.webkit.org/show_bug.cgi?id=113104
2107
2108         Reviewed by Ojan Vafai.
2109
2110         All functions relating to cross dashboard behavior move from being
2111         globals to methods on the history.History object. Names stay the same,
2112         except many are made private, ones that should have been constants now
2113         are, and the long standing TODO to change "currentState" to 
2114         dashboardSpecificState is done.
2115         
2116         We now create a global history object in dashboard_base, as an 
2117         intermediate measure.  Once the dashboard specific code is
2118         added to history, each DB will need to create its own, and this
2119         global will be eliminated.
2120         
2121         * TestResultServer/static-dashboards/aggregate_results.js:
2122         (handleValidHashParameter):
2123         (htmlForBuilder):
2124         (rawValuesHTML):
2125         * TestResultServer/static-dashboards/dashboard_base.js:
2126         (parseDashboardSpecificParameters):
2127         (defaultValue):
2128         (currentBuilderGroupCategory):
2129         (currentBuilderGroupName):
2130         (handleLocationChange):
2131         (expectationsMap):
2132         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2133         (generatePage):
2134         (.switch.return):
2135         (platformAndBuildType):
2136         (individualTests):
2137         (substringList):
2138         (processMissingAndExtraExpectations):
2139         (pathToFailureLog):
2140         (showPopupForBuild):
2141         (htmlForTestsWithExpectationsButNoFailures):
2142         (shouldHideTest):
2143         (isCrossBuilderView):
2144         (tableHeaders):
2145         (htmlForSingleTestRow):
2146         (htmlForTableColumnHeader):
2147         (generatePageForExpectationsUpdate):
2148         (handleUpdate):
2149         (nextUpdate):
2150         (setUpdateIndex):
2151         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2152         (.appendExpectationsItem):
2153         (loadExpectations):
2154         (.dummyNode.onload):
2155         (loadExpectationsLayoutTests):
2156         (appendExpectations):
2157         (htmlForNavBar):
2158         (checkBoxToToggleState):
2159         (linkHTMLToToggleState):
2160         (generatePageForBuilder):
2161         (isInvalidKeyForCrossBuilderView):
2162         (handleQueryParameterChange):
2163         (showLegend):
2164         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2165         (resetGlobals):
2166         (test):
2167         * TestResultServer/static-dashboards/history.js:
2168         (.):
2169         * TestResultServer/static-dashboards/history_unittests.js:
2170         * TestResultServer/static-dashboards/loader.js:
2171         (.):
2172         * TestResultServer/static-dashboards/loader_unittests.js:
2173         * TestResultServer/static-dashboards/timeline_explorer.js:
2174         (generatePage):
2175         (initCurrentBuilderTestResults):
2176         (selectBuild):
2177         (showResultsDelta):
2178         * TestResultServer/static-dashboards/treemap.js:
2179         (generatePage):
2180         (.switch.return):
2181         (handleFocus):
2182         * TestResultServer/static-dashboards/ui.js:
2183
2184 2013-03-25  Roger Fong  <roger_fong@apple.com>
2185
2186         Unreviewed. Enable WinEWS tests again.
2187
2188         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2189         (WinEWS):
2190
2191 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2192
2193         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
2194         https://bugs.webkit.org/show_bug.cgi?id=112166
2195
2196         HarfBuzz 0.9.14 merged my patch for icu detection without
2197         pkg-config files, as needed by for example Ubuntu 12.04.
2198         This obsoletes our local workaround. Removed it for GTK and EFL.
2199
2200         Reviewed by Martin Robinson.
2201
2202         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2203         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
2204         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2205         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
2206
2207 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
2208
2209         Unreviewed.  Move self from contributor to committer list.
2210
2211         * Scripts/webkitpy/common/config/committers.py:
2212
2213 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2214
2215         EWS should use a human readable port name when uploading layout test archives
2216         https://bugs.webkit.org/show_bug.cgi?id=113099
2217
2218         Reviewed by Dirk Pranke.
2219
2220         Use new port's object's name() method to report human readable port names.
2221         This will also help us resolving the bug to apply layout test results posted by EWS.
2222
2223         * Scripts/webkitpy/tool/bot/botinfo.py:
2224         (BotInfo.__init__): Take port's name.
2225         (BotInfo.summary_text):
2226
2227         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2228         (BotInfoTest.test_summary_text):
2229
2230         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2231         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
2232
2233         * Scripts/webkitpy/tool/commands/queues.py:
2234         (PatchProcessingQueue.__init__): Initialize self._port.
2235         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
2236         and use that for the attachment filename and the comment posted.
2237
2238         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2239         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
2240         "mac-snowleopard" as expected for TestPort.
2241
2242 2013-03-22  Roger Fong  <roger_fong@apple.com>
2243
2244         Unreviewed. Turn off EWS test on Win again.
2245         The battle continues.
2246
2247         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2248         (WinEWS):
2249
2250 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2251
2252         NRWT: Enable pixel tests when retrying tests
2253         https://bugs.webkit.org/show_bug.cgi?id=112898
2254
2255         Reviewed by Dirk Pranke.
2256
2257         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2258         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2259         if we've forced pixel tests in the retry.
2260         (Manager._run_tests):
2261         (Manager._clean_up_run): Fixed the capitalizations.
2262         (Manager._force_pixel_tests_if_needed): Added.
2263
2264         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2265         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2266         'image_diff_percent' if it doesn't already exist.
2267
2268         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2269         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2270         treat this as a regular regression instead of a flakiness.
2271
2272         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2273         run had image diffs.
2274
2275         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2276         (summarized_results):
2277
2278         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2279         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2280         Also removed some dead code.
2281
2282         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2283         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2284         is set and pixel_tests_enabled is set to false.
2285         (EndToEndTest.test_reftest_with_two_notrefs):
2286
2287 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2288
2289         Make it possible to run layout tests on Retina MBP
2290         https://bugs.webkit.org/show_bug.cgi?id=93673
2291
2292         Reviewed by Ryosuke Niwa.
2293
2294         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2295         windows on 2x machines still run at 1x.
2296
2297         * DumpRenderTree/mac/DumpRenderTree.mm:
2298         (createWebViewAndOffscreenWindow):
2299         Reset the window resolution to 1x on creation.
2300         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2301         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2302         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2303         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2304         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2305         (WTR::PlatformWebView::PlatformWebView):
2306         Add NSWindow details, reset the window resolution to 1x on creation.
2307
2308 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2309
2310         Leak bots shouldn't build
2311         https://bugs.webkit.org/show_bug.cgi?id=112774
2312
2313         Reviewed by Simon Fraser.
2314
2315         Since leak bots use regular debug builds, there is no need to build on these bots.
2316         Simply downloading builds will dramatically improve the cycle time of these bots.
2317
2318         * BuildSlaveSupport/build.webkit.org-config/config.json:
2319         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2320         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2321         TestFactory instead of BuildAndTestFactory.
2322
2323 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2324
2325         [Qt] Fix the TestWebKitAPI build
2326         https://bugs.webkit.org/show_bug.cgi?id=113044
2327
2328         Reviewed by Tor Arne Vestbø.
2329
2330         The generate-forwarding-headers script would only be run
2331         after the targets in InjectedBundle.pri since the second
2332         addStrictSubdirOrderBetween call in
2333         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2334         the derived_sources -> injected_bundle order in SUBDIRS.
2335
2336         Fix it by only moving the dependent target at the end of
2337         SUBDIRS, don't touch its dependency.
2338
2339         * qmake/mkspecs/features/functions.prf:
2340
2341 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2342
2343         [EFL][WK2] View is not focused when fullscreen mode toggled
2344         https://bugs.webkit.org/show_bug.cgi?id=113009
2345
2346         Reviewed by Laszlo Gombos.
2347
2348         Set focus on view when fullscreen mode enabled/disabled
2349         by FullScreen API.
2350
2351         * MiniBrowser/efl/main.c:
2352         (on_fullscreen_accept):
2353         (on_fullscreen_deny):
2354
2355 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2356
2357         nrwt is no longer saving retry results in the retries/ subdirectory
2358         https://bugs.webkit.org/show_bug.cgi?id=112995
2359
2360         Reviewed by Ojan Vafai.
2361
2362         I think this has been broken a long time, unfortunately. This
2363         patch should fix that.
2364
2365         In order to do so, I had to pass the directory to use from
2366         the Worker object through the SingleTestWriter to the
2367         TestResultWriter. While I was plumbing that through, I rationalized
2368         the order of the parameter arguments a bit ...
2369
2370         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2371         (Worker._run_single_test):
2372         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2373         (run_single_test):
2374         (SingleTestRunner.__init__):
2375         (SingleTestRunner._run_compare_test):
2376         (SingleTestRunner._run_rebaseline):
2377         (SingleTestRunner._run_reftest):
2378         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2379         (write_test_result):
2380         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2381         (TestResultWriterTest.test_reftest_diff_image):
2382         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2383         (RunTest.test_retrying_uses_retries_directory):
2384
2385 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2386
2387         JSC profiler should have an at-a-glance report of the success of DFG optimization
2388         https://bugs.webkit.org/show_bug.cgi?id=112988
2389
2390         Reviewed by Geoffrey Garen.
2391
2392         * Scripts/display-profiler-output:
2393
2394 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2395
2396         [chromium] Linux ASAN WebKit canary is running out of memory
2397         https://bugs.webkit.org/show_bug.cgi?id=112978
2398
2399         Reviewed by Tony Chang.
2400
2401         Running the AddressSanitizer on a crash takes a lot of
2402         memory, so we should serialize access to it to avoid running
2403         out of memory on a machine.
2404
2405         * Scripts/webkitpy/layout_tests/port/chromium.py:
2406         (ChromiumPort._get_crash_log):
2407         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2408         (HttpLock.__init__):
2409         (HttpLock.wait_for_httpd_lock):
2410
2411 2013-03-21  Min Qin  <qinmin@chromium.org>
2412
2413         Cleanup android media layout test code
2414         https://bugs.webkit.org/show_bug.cgi?id=112944
2415
2416         Reviewed by Adam Barth.
2417
2418         Chromium change: https://codereview.chromium.org/12892010/
2419         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2420         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2421         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2422         Instead, we should switch to use content shell for layout tests.
2423
2424         * DumpRenderTree/chromium/TestShell.cpp:
2425         (TestShell::resetTestController):
2426
2427 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2428
2429         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2430         https://bugs.webkit.org/show_bug.cgi?id=112953
2431
2432         Reviewed by Tony Chang.
2433
2434         When I created the DumpRenderTree_resources target in r144863 I
2435         forgot to declare the needed dependencies on the other resource
2436         targets. Due to a quirk of ordering, this appears to have been fine
2437         w/ ninja but not w/ Xcode (which is still being used on the chromium
2438         mac valgrind bots). Declaring the dependencies fixes the build
2439         failures.
2440
2441         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2442
2443 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2444
2445         [WinCairo] Correct assert in Empty BitmapImage Test.
2446         https://bugs.webkit.org/show_bug.cgi?id=112934
2447
2448         Reviewed by Tim Horton.
2449
2450         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2451         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2452         to avoid ref counting assertion when leaving test scope.
2453
2454 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2455
2456         [GTK] generate-feature-defines-files is incompatible with Python3
2457         https://bugs.webkit.org/show_bug.cgi?id=112956
2458
2459         Reviewed by Martin Robinson.
2460
2461         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2462         method on the dictionary objects when iterating through said dictionaries.
2463
2464         * gtk/generate-feature-defines-files:
2465         (write_feature_defines_header):
2466         (write_flattened_feature_defines_file):
2467
2468 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2469
2470         kill-old-processes spits out error messages on Mac
2471         https://bugs.webkit.org/show_bug.cgi?id=112878
2472
2473         Reviewed by Jessie Berlin.
2474
2475         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2476         included in the list of options grep --help shows.
2477
2478         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2479
2480         * BuildSlaveSupport/kill-old-processes:
2481         (main):
2482
2483 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2484
2485         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2486         https://bugs.webkit.org/show_bug.cgi?id=112597
2487
2488         Reviewed by Xan Lopez.
2489
2490         These were introduced for the Chromium port in r105295. We need
2491         dummy implementations in order to compile the BlackBerry port.
2492
2493         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2494         (AccessibilityUIElement::scrollToMakeVisible):
2495         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2496         (AccessibilityUIElement::scrollToGlobalPoint):
2497
2498 2013-03-21  Roger Fong  <roger_fong@apple.com>
2499
2500         Re-enable WinEWS tests following r146376.
2501
2502         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2503         (WinEWS):
2504
2505 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2506
2507         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2508
2509         * Scripts/webkitpy/common/config/committers.py:
2510
2511 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2512
2513         [GTK] Missing atk in install-dependencies script
2514         https://bugs.webkit.org/show_bug.cgi?id=112272
2515
2516         Reviewed by Gustavo Noronha Silva.
2517
2518         * gtk/install-dependencies: Add missing atk dependency.
2519
2520 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2521
2522         [GTK] Missing backslash in install-dependencies script
2523         https://bugs.webkit.org/show_bug.cgi?id=112907
2524
2525         Reviewed by Philippe Normand.
2526
2527         * gtk/install-dependencies: Add missing backslash to dependencies
2528         list.
2529
2530 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2531
2532         EWS bots have stopped uploading results to bugzilla
2533         https://bugs.webkit.org/show_bug.cgi?id=101091
2534
2535         Reviewed by Adam Barth.
2536
2537         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2538         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2539         this relative file path resoled to a file inside a non-existent directory for "zip".
2540
2541         Fixed the bug by resolving both test results directory and zip archive paths in
2542         LayoutTestResultsReader.archive.
2543
2544         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2545         in the future.
2546
2547         * Scripts/webkitpy/common/system/filesystem_mock.py:
2548         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2549
2550         * Scripts/webkitpy/common/system/workspace.py:
2551         (Workspace.create_zip): Log the source path when "zip" failed.
2552
2553         * Scripts/webkitpy/common/system/workspace_mock.py:
2554         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2555
2556         * Scripts/webkitpy/common/system/workspace_unittest.py:
2557         (WorkspaceTest.test_create_zip_exception): Test that.
2558
2559         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2560         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2561         This is the actual bug fix.
2562
2563         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2564         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2565
2566 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2567
2568         [chromium] move WebThemeEngine implementations to TestRunner library
2569         https://bugs.webkit.org/show_bug.cgi?id=112751
2570
2571         Reviewed by Adam Barth.
2572
2573         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2574         * DumpRenderTree/DumpRenderTree.gypi:
2575         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2576         (WebKit):
2577         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2578         (WebTestRunner::TestInterfaces::themeEngine):
2579         (WebTestRunner):
2580         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2581         (WebKit):
2582         (TestInterfaces):
2583         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2584         (WebTestRunner::WebTestInterfaces::themeEngine):
2585         (WebTestRunner):
2586         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2587         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2588         (WebTestRunner):
2589         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2590         (WebTestRunner::WebTestThemeControlWin::box):
2591         (WebTestRunner::WebTestThemeControlWin::line):
2592         (WebTestRunner::WebTestThemeControlWin::triangle):
2593         (WebTestRunner::WebTestThemeControlWin::roundRect):
2594         (WebTestRunner::WebTestThemeControlWin::oval):
2595         (WebTestRunner::WebTestThemeControlWin::circle):
2596         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2597         (WebTestRunner::WebTestThemeControlWin::markState):
2598         (WebTestRunner::WebTestThemeControlWin::draw):
2599         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2600         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2601         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2602         (WebTestRunner):
2603         (WebTestThemeControlWin):
2604         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2605         (WebTestRunner):
2606         (WebTestThemeEngineMac):
2607         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2608         (+[FakeActiveWindow alwaysActiveWindow]):
2609         (+[FakeActiveWindow alwaysInactiveWindow]):
2610         (-[FakeActiveWindow initWithActiveControls:]):
2611         (-[FakeActiveWindow _hasActiveControls]):
2612         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2613         (WebTestRunner):
2614         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2615         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2616         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2617         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2618         (WebTestRunner):
2619         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2620         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2621         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2622         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2623         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2624         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2625         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2626         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2627         (WebTestRunner::WebTestThemeEngineWin::getSize):
2628         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2629         (WebTestRunner):
2630         (WebTestThemeEngineWin):
2631         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2632         * DumpRenderTree/chromium/TestShell.cpp:
2633         (TestShell::initialize):
2634         * DumpRenderTree/chromium/TestShell.h:
2635         (WebKit):
2636         * DumpRenderTree/chromium/TestShellMac.mm:
2637         (platformInit):
2638         * DumpRenderTree/chromium/TestShellWin.cpp:
2639         (platformInit):
2640         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2641
2642 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2643
2644         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2645
2646         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2647         New property sheet that does not link against CoreFoundation and
2648         CFNetwork.
2649         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2650         Use new TestWebKitAPICommonWinCairo property sheet.
2651         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2652         Ditto.
2653
2654 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2655
2656         [WinCairo] Unreviewed build fix for VS2010.
2657
2658         Had to add WinCairo-specific property sheets to deal with some
2659         library and path differences with the main Apple port.
2660
2661         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2662         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2663         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2664         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2665         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2666         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2667
2668 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2669
2670         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2671         https://bugs.webkit.org/show_bug.cgi?id=112849
2672
2673         Reviewed by Sam Weinig.
2674
2675         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2676         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2677         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2678
2679 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2680
2681         [WinCairo] Build WebKit Tools under VS2010
2682         https://bugs.webkit.org/show_bug.cgi?id=112821
2683
2684         Reviewed by Tim Horton.
2685
2686         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2687         Add WinCairo-specific build target.
2688         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2689         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2690         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2691         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2692         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2693         Add WinCairo-specific build target.
2694         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2695         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2696         Add WinCairo-specific build target.
2697         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2698         WinCairo-specific build target.
2699         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2700         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2701         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2702         specific build target.
2703         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2704         WinCairo-specific build target.
2705         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2706         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2707         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2708
2709 2013-03-20  Roger Fong  <roger_fong@apple.com>
2710
2711         API test gardening AppleWin port.
2712
2713         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2714
2715         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2716         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2717
2718 2013-03-20  Roger Fong  <roger_fong@apple.com>
2719
2720         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2721
2722         * EWSTools/start-queue-win.sh:
2723
2724 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2725
2726         Unreviewed, add myself to committers.py.
2727
2728 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2729
2730         Unreviewed. Adding another email for me.
2731
2732         * Scripts/webkitpy/common/config/committers.py:
2733
2734 2013-03-20  Justin Novosad  <junov@google.com>
2735
2736         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2737         https://bugs.webkit.org/show_bug.cgi?id=112605
2738
2739         Reviewed by James Robinson.
2740
2741         Deleting all the code that was used for propagating and supporting
2742         the Chromium setting for disabling deferred 2d canvas rendering.
2743
2744         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2745         (main):
2746         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2747         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2748         (WebTestRunner::WebPreferences::reset):
2749         (WebTestRunner::WebPreferences::applyTo):
2750         * DumpRenderTree/chromium/TestShell.cpp:
2751         (TestShell::TestShell):
2752         (TestShell::resetWebSettings):
2753         (TestShell::runFileTest):
2754         * DumpRenderTree/chromium/TestShell.h:
2755         (TestShell):
2756
2757 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2758
2759         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2760         https://bugs.webkit.org/show_bug.cgi?id=112699.
2761
2762         Reviewed by Adam Barth.
2763
2764         * Scripts/webkitpy/layout_tests/port/qt.py:
2765         (QtPort._search_paths):
2766         (QtPort._port_specific_expectations_files):
2767         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2768         (QtPortTest):
2769         (QtPortTest._assert_search_path):
2770         (QtPortTest._assert_expectations_files):
2771
2772 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2773
2774         [Qt] Enable kerning by default
2775         https://bugs.webkit.org/show_bug.cgi?id=112704
2776
2777         Reviewed by Jocelyn Turcotte.
2778
2779         Disable kerning by default, since some reference test expectations
2780         expect kerning to be default off.
2781
2782         * DumpRenderTree/qt/TestRunnerQt.cpp:
2783         (TestRunnerQt::reset):
2784         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2785         (WTR::activateFonts):
2786
2787 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2788
2789         [Qt] Remove empty function stubs from TestRunnerQt.
2790         https://bugs.webkit.org/show_bug.cgi?id=112799
2791
2792         We are reducing the code in TestRunnerQt step by step,
2793         in order to finally replace all of it with the generic
2794         TestRunner implementation.
2795         This patch removes several simple function stubs that
2796         currently do not implement any actual functionality.
2797
2798         Reviewed by Kenneth Rohde Christiansen.
2799
2800         * DumpRenderTree/qt/TestRunnerQt.cpp:
2801         * DumpRenderTree/qt/TestRunnerQt.h:
2802         (TestRunnerQt):
2803
2804 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2805
2806         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2807         https://bugs.webkit.org/show_bug.cgi?id=112687
2808
2809         Reviewed by Kenneth Rohde Christiansen.
2810
2811         Hide the SearchBar by default on window creation.
2812
2813         * MiniBrowser/efl/main.c:
2814         (window_create):
2815
2816 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2817
2818         Unreviewed, rolling out r146304.
2819         http://trac.webkit.org/changeset/146304
2820         https://bugs.webkit.org/show_bug.cgi?id=112788
2821
2822         to many expectations to update (Requested by antonm on
2823         #webkit).
2824
2825         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2826         * DumpRenderTree/DumpRenderTree.gypi:
2827         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2828         (WebKit):
2829         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2830         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2831         (TestInterfaces):
2832         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2833         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2834         * DumpRenderTree/chromium/TestShell.cpp:
2835         (TestShell::initialize):
2836         * DumpRenderTree/chromium/TestShell.h:
2837         (WebKit):
2838         * DumpRenderTree/chromium/TestShellMac.mm:
2839         (platformInit):
2840         * DumpRenderTree/chromium/TestShellWin.cpp:
2841         (platformInit):
2842         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2843         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2844         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2845         (WebThemeControlDRTWin::box):
2846         (WebThemeControlDRTWin::line):
2847         (WebThemeControlDRTWin::triangle):
2848         (WebThemeControlDRTWin::roundRect):
2849         (WebThemeControlDRTWin::oval):
2850         (WebThemeControlDRTWin::circle):
2851         (WebThemeControlDRTWin::nestedBoxes):
2852         (WebThemeControlDRTWin::markState):
2853         (WebThemeControlDRTWin::draw):
2854         (WebThemeControlDRTWin::drawTextField):
2855         (WebThemeControlDRTWin::drawProgressBar):
2856         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2857         (WebThemeControlDRTWin):
2858         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2859         (WebThemeEngineDRTMac):
2860         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2861         (+[FakeActiveWindow alwaysActiveWindow]):
2862         (+[FakeActiveWindow alwaysInactiveWindow]):
2863         (-[FakeActiveWindow initWithActiveControls:]):
2864         (-[FakeActiveWindow _hasActiveControls]):
2865         (WebThemeEngineDRTMac::paintScrollbarThumb):
2866         (stateToHIEnableState):
2867         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2868         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2869         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2870         (webRectToSkIRect):
2871         (drawControl):
2872         (drawTextField):
2873         (drawProgressBar):
2874         (WebThemeEngineDRTWin::paintButton):
2875         (WebThemeEngineDRTWin::paintMenuList):
2876         (WebThemeEngineDRTWin::paintScrollbarArrow):
2877         (WebThemeEngineDRTWin::paintScrollbarThumb):
2878         (WebThemeEngineDRTWin::paintScrollbarTrack):
2879         (WebThemeEngineDRTWin::paintSpinButton):
2880         (WebThemeEngineDRTWin::paintTextField):
2881         (WebThemeEngineDRTWin::paintTrackbar):
2882         (WebThemeEngineDRTWin::paintProgressBar):
2883         (WebThemeEngineDRTWin::getSize):
2884         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2885         (WebThemeEngineDRTWin):
2886         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2887
2888 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2889
2890         [Qt] Support -webkit-font-smoothing
2891         https://bugs.webkit.org/show_bug.cgi?id=106009
2892
2893         Reviewed by Jocelyn Turcotte.
2894
2895         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2896
2897         * DumpRenderTree/qt/TestRunnerQt.cpp:
2898         (TestRunnerQt::reset):
2899
2900 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2901
2902         [GTK] accessibility/aria-scrollbar-role.html is failing
2903         https://bugs.webkit.org/show_bug.cgi?id=98358
2904
2905         Reviewed by Martin Robinson.
2906
2907         Adds support for checking accessibility object's orientation.
2908         Orientation is checked by retrieving proper state of accessibility object.
2909
2910         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2911         (checkElementState):
2912         (AccessibilityUIElement::orientation):
2913         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2914         (WTR::AccessibilityUIElement::orientation):
2915
2916 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2917
2918         [chromium] move WebThemeEngine implementations to TestRunner library
2919         https://bugs.webkit.org/show_bug.cgi?id=112751
2920
2921         Reviewed by Adam Barth.
2922
2923         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2924         * DumpRenderTree/DumpRenderTree.gypi:
2925         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2926         (WebKit):
2927         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2928         (WebTestRunner::TestInterfaces::themeEngine):
2929         (WebTestRunner):
2930         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2931         (WebKit):
2932         (TestInterfaces):
2933         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2934         (WebTestRunner::WebTestInterfaces::themeEngine):
2935         (WebTestRunner):
2936         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2937         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2938         (WebTestRunner):
2939         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2940         (WebTestRunner::WebTestThemeControlWin::box):
2941         (WebTestRunner::WebTestThemeControlWin::line):
2942         (WebTestRunner::WebTestThemeControlWin::triangle):
2943         (WebTestRunner::WebTestThemeControlWin::roundRect):
2944         (WebTestRunner::WebTestThemeControlWin::oval):
2945         (WebTestRunner::WebTestThemeControlWin::circle):
2946         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2947         (WebTestRunner::WebTestThemeControlWin::markState):
2948         (WebTestRunner::WebTestThemeControlWin::draw):
2949         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2950         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2951         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2952         (WebTestRunner):
2953         (WebTestThemeControlWin):
2954         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2955         (WebTestRunner):
2956         (WebTestThemeEngineMac):
2957         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2958         (+[FakeActiveWindow alwaysActiveWindow]):
2959         (+[FakeActiveWindow alwaysInactiveWindow]):
2960         (-[FakeActiveWindow initWithActiveControls:]):
2961         (-[FakeActiveWindow _hasActiveControls]):
2962         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2963         (WebTestRunner):
2964         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2965         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2966         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2967         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2968         (WebTestRunner):
2969         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2970         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2971         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2972         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2973         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2974         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2975         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2976         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2977         (WebTestRunner::WebTestThemeEngineWin::getSize):
2978         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2979         (WebTestRunner):
2980         (WebTestThemeEngineWin):
2981         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2982         * DumpRenderTree/chromium/TestShell.cpp:
2983         (TestShell::initialize):
2984         * DumpRenderTree/chromium/TestShell.h:
2985         (WebKit):
2986         * DumpRenderTree/chromium/TestShellMac.mm:
2987         (platformInit):
2988         * DumpRenderTree/chromium/TestShellWin.cpp:
2989         (platformInit):
2990         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2991
2992 2013-03-19  Tony Chang  <tony@chromium.org>
2993
2994         Move testRunner.setTouchDragDropEnabled to internals.settings
2995         https://bugs.webkit.org/show_bug.cgi?id=112739
2996
2997         Reviewed by Adam Barth.
2998
2999         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3000         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
3001         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3002         (TestRunner): Remove unnecessary code.
3003         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3004         (WebTestRunner::WebPreferences::reset):
3005         (WebTestRunner::WebPreferences::applyTo): Always set to false.
3006
3007 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
3008
3009         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3010         https://bugs.webkit.org/show_bug.cgi?id=112754
3011
3012         Reviewed by Darin Fisher.
3013
3014         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
3015         now that it's always defined.
3016
3017         * DumpRenderTree/chromium/WebViewHost.cpp:
3018         * DumpRenderTree/chromium/WebViewHost.h:
3019         (WebViewHost):
3020
3021 2013-03-19  Kenneth Russell  <kbr@google.com>
3022
3023         Unreviewed, rolling out r146290.
3024         http://trac.webkit.org/changeset/146290
3025         https://bugs.webkit.org/show_bug.cgi?id=112751
3026
3027         Broke Chromium Mac build.
3028
3029         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3030         * DumpRenderTree/DumpRenderTree.gypi:
3031         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3032         (WebKit):
3033         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3034         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3035         (TestInterfaces):
3036         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3037         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
3038         * DumpRenderTree/chromium/TestShell.cpp:
3039         (TestShell::initialize):
3040         * DumpRenderTree/chromium/TestShell.h:
3041         (WebKit):
3042         * DumpRenderTree/chromium/TestShellMac.mm:
3043         (platformInit):
3044         * DumpRenderTree/chromium/TestShellWin.cpp:
3045         (platformInit):
3046         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
3047         (WebThemeControlDRTWin::WebThemeControlDRTWin):
3048         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
3049         (WebThemeControlDRTWin::box):
3050         (WebThemeControlDRTWin::line):
3051         (WebThemeControlDRTWin::triangle):
3052         (WebThemeControlDRTWin::roundRect):
3053         (WebThemeControlDRTWin::oval):
3054         (WebThemeControlDRTWin::circle):
3055         (WebThemeControlDRTWin::nestedBoxes):
3056         (WebThemeControlDRTWin::markState):
3057         (WebThemeControlDRTWin::draw):
3058         (WebThemeControlDRTWin::drawTextField):
3059         (WebThemeControlDRTWin::drawProgressBar):
3060         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
3061         (WebThemeControlDRTWin):
3062         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
3063         (WebThemeEngineDRTMac):
3064         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
3065         (+[FakeActiveWindow alwaysActiveWindow]):
3066         (+[FakeActiveWindow alwaysInactiveWindow]):
3067         (-[FakeActiveWindow initWithActiveControls:]):
3068         (-[FakeActiveWindow _hasActiveControls]):
3069         (WebThemeEngineDRTMac::paintScrollbarThumb):
3070         (stateToHIEnableState):
3071         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3072         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3073         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
3074         (webRectToSkIRect):
3075         (drawControl):
3076         (drawTextField):
3077         (drawProgressBar):
3078         (WebThemeEngineDRTWin::paintButton):
3079         (WebThemeEngineDRTWin::paintMenuList):
3080         (WebThemeEngineDRTWin::paintScrollbarArrow):
3081         (WebThemeEngineDRTWin::paintScrollbarThumb):
3082         (WebThemeEngineDRTWin::paintScrollbarTrack):
3083         (WebThemeEngineDRTWin::paintSpinButton):
3084         (WebThemeEngineDRTWin::paintTextField):
3085         (WebThemeEngineDRTWin::paintTrackbar):
3086         (WebThemeEngineDRTWin::paintProgressBar):
3087         (WebThemeEngineDRTWin::getSize):
3088         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
3089         (WebThemeEngineDRTWin):
3090         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
3091
3092 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
3093
3094         [EFL] canvas-fallback-content.html is failing
3095         https://bugs.webkit.org/show_bug.cgi?id=111998
3096
3097         Reviewed by Chris Fleizach.
3098
3099         Adds support for getting platform name.
3100
3101         * DumpRenderTree/TestRunner.cpp:
3102         (TestRunner::staticValues):
3103         * DumpRenderTree/TestRunner.h:
3104         (TestRunner):
3105         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3106         (TestRunner::platformName):
3107
3108 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
3109
3110         [chromium] move WebThemeEngine implementations to TestRunner library
3111         https://bugs.webkit.org/show_bug.cgi?id=112751
3112
3113         Reviewed by Adam Barth.
3114
3115         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3116         * DumpRenderTree/DumpRenderTree.gypi:
3117         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3118         (WebKit):
3119         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3120         (WebTestRunner::TestInterfaces::themeEngine):
3121         (WebTestRunner):
3122         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3123         (WebKit):
3124         (TestInterfaces):
3125         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3126         (WebTestRunner::WebTestInterfaces::themeEngine):
3127         (WebTestRunner):
3128         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3129         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3130         (WebTestRunner):
3131         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3132         (WebTestRunner::WebTestThemeControlWin::box):
3133         (WebTestRunner::WebTestThemeControlWin::line):
3134         (WebTestRunner::WebTestThemeControlWin::triangle):
3135         (WebTestRunner::WebTestThemeControlWin::roundRect):
3136         (WebTestRunner::WebTestThemeControlWin::oval):
3137         (WebTestRunner::WebTestThemeControlWin::circle):
3138         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3139         (WebTestRunner::WebTestThemeControlWin::markState):
3140         (WebTestRunner::WebTestThemeControlWin::draw):
3141         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3142         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3143         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3144         (WebTestRunner):
3145         (WebTestThemeControlWin):
3146         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3147         (WebTestRunner):
3148         (WebTestThemeEngineMac):
3149         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3150         (+[FakeActiveWindow alwaysActiveWindow]):
3151         (+[FakeActiveWindow alwaysInactiveWindow]):
3152         (-[FakeActiveWindow initWithActiveControls:]):
3153         (-[FakeActiveWindow _hasActiveControls]):
3154         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3155         (WebTestRunner):
3156         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3157         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3158         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3159         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3160         (WebTestRunner):
3161         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3162         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3163         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3164         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3165         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3166         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3167         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3168         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3169         (WebTestRunner::WebTestThemeEngineWin::getSize):
3170         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3171         (WebTestRunner):
3172         (WebTestThemeEngineWin):
3173         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3174         * DumpRenderTree/chromium/TestShell.cpp:
3175         (TestShell::initialize):
3176         * DumpRenderTree/chromium/TestShell.h:
3177         (WebKit):
3178         * DumpRenderTree/chromium/TestShellMac.mm:
3179         (platformInit):
3180         * DumpRenderTree/chromium/TestShellWin.cpp:
3181         (platformInit):
3182         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3183
3184 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3185
3186         [EFL][WK2] Separate WebView further from EwkView
3187         https://bugs.webkit.org/show_bug.cgi?id=111591
3188
3189         Reviewed by Caio Marcelo de Oliveira Filho.
3190
3191         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
3192         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
3193         since we can afford it having EWKViewGetWKView() private API to access WKView.
3194
3195         * TestWebKitAPI/PlatformWebView.h:
3196         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3197         (TestWebKitAPI::TEST):
3198         * TestWebKitAPI/efl/PlatformWebView.cpp:
3199         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3200         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3201         (TestWebKitAPI::PlatformWebView::resizeTo):
3202         (TestWebKitAPI::PlatformWebView::page):
3203         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3204         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3205         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3206         * WebKitTestRunner/PlatformWebView.h:
3207         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3208         (WTR::EventSenderProxy::dispatchEvent):
3209         (WTR::EventSenderProxy::keyDown):
3210         (WTR::EventSenderProxy::sendTouchEvent):
3211         (WTR::EventSenderProxy::setTouchModifier):
3212         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3213         (WTR::PlatformWebView::PlatformWebView):
3214         (WTR::PlatformWebView::~PlatformWebView):
3215         (WTR::PlatformWebView::resizeTo):
3216         (WTR::PlatformWebView::page):
3217         (WTR::PlatformWebView::focus):
3218         (WTR::PlatformWebView::windowSnapshotImage):
3219
3220 2013-03-19  Roger Fong  <roger_fong@apple.com>
3221
3222         Changes to VS2010 project files should only trigger builds on Windows bots.
3223         https://bugs.webkit.org/show_bug.cgi?id=112731
3224
3225         Reviewed by Timothy Horton.
3226
3227         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3228         (_should_file_trigger_build):
3229
3230 2013-03-19  Roger Fong  <roger_fong@apple.com>
3231
3232         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
3233
3234         * Scripts/webkitpy/tool/steps/runtests.py:
3235         (RunTests.run):
3236         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3237         (RunTestsTest.test_webkit_run_unit_tests):
3238
3239 2013-03-19  Julie Parent  <jparent@chromium.org>
3240
3241         Dashboards: Introduce history namespace and unit tests.
3242         https://bugs.webkit.org/show_bug.cgi?id=112645
3243
3244         Reviewed by Ojan Vafai.
3245         
3246         Laying the framework for introducing the new history object and
3247         namespace.  This moves only static functions into the history
3248         namespace, and moves corresponding unit tests into seperate
3249         unit test file.
3250
3251         * TestResultServer/static-dashboards/aggregate_results.html:
3252         * TestResultServer/static-dashboards/dashboard_base.js:
3253         (parseCrossDashboardParameters):
3254         (parseDashboardSpecificParameters):
3255         (parseParameters):
3256         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3257         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3258         (.switch.return):
3259         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3260         * TestResultServer/static-dashboards/history.js: Added.
3261         * TestResultServer/static-dashboards/history_unittests.js: Added.
3262         * TestResultServer/static-dashboards/loader.js:
3263         (.):
3264         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3265         * TestResultServer/static-dashboards/run-unittests.html:
3266         * TestResultServer/static-dashboards/timeline_explorer.html:
3267         * TestResultServer/static-dashboards/timeline_explorer.js:
3268         * TestResultServer/static-dashboards/treemap.html:
3269         * TestResultServer/static-dashboards/treemap.js:
3270         (.switch.return):
3271         * TestResultServer/static-dashboards/ui.js:
3272
3273 2013-03-19  Daniel Bates  <dbates@webkit.org>
3274
3275         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3276         https://bugs.webkit.org/show_bug.cgi?id=112732
3277
3278         Reviewed by Eric Seidel.
3279
3280         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3281         of an existing file cannot be applied.
3282
3283         In particular, svn-{apply, unapply} compensate for differences in line endings
3284         by converting the line endings in a diff to match the line endings in the target
3285         file. The diff(1) command precedes the last line of a diff that adds a newline
3286         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3287         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3288         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3289         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3290         the newline characters in this special character sequence to match the line endings
3291         in the target file.
3292
3293         * Scripts/VCSUtils.pm:
3294         (parseDiff):
3295         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3296         Added tests:
3297             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3298             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3299             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3300             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3301         (escapeNewLineCharacters): Added.
3302         (toMacLineEndings): Added.
3303
3304 2013-03-19  James Robinson  <jamesr@chromium.org>
3305
3306         [chromium] Remove compositor settings that don't go through WebKit
3307         https://bugs.webkit.org/show_bug.cgi?id=112718
3308
3309         Reviewed by Adam Barth.
3310
3311         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3312         (main):
3313         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3314         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3315         (WebTestRunner::WebPreferences::reset):
3316         (WebTestRunner::WebPreferences::applyTo):
3317         * DumpRenderTree/chromium/TestShell.cpp:
3318         (TestShell::TestShell):
3319         (TestShell::resetWebSettings):
3320         * DumpRenderTree/chromium/TestShell.h:
3321         (TestShell):
3322
3323 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3324
3325         Unreviewed, rolling out r146101.
3326         https://bugs.webkit.org/show_bug.cgi?id=111884
3327
3328         re-enable custom freetype on asan; this needs to be on
3329         now that the bot is running lucid.
3330
3331         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3332
3333 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3334
3335         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3336         https://bugs.webkit.org/show_bug.cgi?id=112365
3337
3338         Reviewed by Benjamin Poulain.
3339
3340         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3341         harcoding it in wtf/Platform.h
3342
3343         * Scripts/webkitperl/FeatureList.pm:
3344
3345 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3346
3347         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3348         https://bugs.webkit.org/show_bug.cgi?id=94782
3349
3350         Based on patch by Csaba Osztrogonác.
3351         Reviewed by Jocelyn Turcotte.
3352
3353         The diff image is generated with bright red indicating errors, but letting the base image
3354         shine through so the context of the error-pixel can be identified.
3355
3356         * DumpRenderTree/qt/ImageDiff.cpp:
3357         (main):
3358
3359 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3360
3361         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3362
3363         Rubber-stamped by Csaba Osztrogonác.
3364
3365         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3366         since the latter might not cover the former.
3367
3368         * QtTestBrowser/launcherwindow.cpp:
3369         (LauncherWindow::print):
3370
3371 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3372
3373         Style tweeks to default.css.
3374         
3375         Rubber-stamped by David Kilzer.
3376         
3377         Give visited links a different color to other links, so you can
3378         see which builds you've viewed.
3379         
3380         Make the <small> text less tiny.
3381
3382         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3383         (small):
3384         (a:link,a:visited,a:active):
3385         (a:visited):
3386
3387 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3388
3389         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3390         https://bugs.webkit.org/show_bug.cgi?id=112494
3391
3392         Reviewed by Dirk Pranke.
3393
3394         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3395         Also merged two pairs of methods to cleanup the code.
3396
3397         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3398         (PerfTestsRunner.run): Merged _upload_and_show_results.
3399         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3400
3401 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3402
3403         [chromium] build xdisplaycheck when building DRT
3404         https://bugs.webkit.org/show_bug.cgi?id=112636
3405
3406         Reviewed by Tony Chang.
3407
3408         It appears that we need xdisplaycheck to be built in order for
3409         Xvfb to be started correctly on the bots, and DRT was missing
3410         a dependency on it. This may be the cause of the ASAN bot not
3411         starting up properly (it only builds DRT).
3412
3413         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3414
3415 2013-03-18  David Levin  <levin@chromium.org>
3416
3417         Implement icon change notification dump for Chromium's test shell.
3418         https://bugs.webkit.org/show_bug.cgi?id=112614
3419
3420         This was previously implemented for some other platforms in r58111
3421         and r116547.
3422
3423         In r122806, fast/dom/icon-url-property.html stopped using it, but
3424         it is useful for tests, so I plan to re-add it to that test again.
3425
3426         Reviewed by Jochen Eisinger.
3427
3428         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3429         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3430          icon change notifications from WebKit may be logged in test output.
3431         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3432         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3433         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3434         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3435         (WebTestRunner):
3436         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3437         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3438         (TestRunner):
3439         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3440         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3441         (WebTestRunner):
3442         * DumpRenderTree/chromium/WebViewHost.cpp:
3443         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3444         * DumpRenderTree/chromium/WebViewHost.h:
3445         (WebViewHost):
3446
3447 2013-03-18  Julie Parent  <jparent@chromium.org>
3448
3449         Cleanup: Move js for treemap and aggregate_results into own js files.
3450         https://bugs.webkit.org/show_bug.cgi?id=112618
3451
3452         Reviewed by Dirk Pranke.
3453         
3454         No functional changes, just moving the code into separate js file
3455         rather than inlined in the html, so we can test it, make it more
3456         modular, etc.  Other dashboard types are already done this way.
3457
3458         * TestResultServer/static-dashboards/aggregate_results.html:
3459         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3460         (generatePage):
3461         (handleValidHashParameter):
3462         (htmlForBuilder):
3463         (rawValuesHTML):
3464         (chartHTML):
3465         (filteredValues):
3466         (chart):
3467         (htmlForRevisionRows):
3468         (wrapHTMLInTable):
3469         (htmlForSummaryTable):
3470         (valuesPerExpectation):
3471         (htmlForTestType):
3472         (htmlForTableRow):
3473         (extendedEncode):
3474         * TestResultServer/static-dashboards/treemap.html:
3475         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3476         (humanReadableTime):
3477         (convertToWebTreemapFormat):
3478         (reverseSortByAverage):
3479         (generatePage):
3480         (focusPath):
3481         (.switch.return):
3482         (handleQueryParameterChange):
3483         (extractName):
3484         (fullName):
3485         (handleFocus.):
3486         (handleFocus):
3487
3488 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3489
3490         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3491         https://bugs.webkit.org/show_bug.cgi?id=112622
3492
3493         Reviewed by Dirk Pranke.
3494
3495         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3496         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3497
3498 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3499
3500         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3501         https://bugs.webkit.org/show_bug.cgi?id=112619
3502
3503         Reviewed by Dirk Pranke.
3504
3505         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3506         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3507
3508         * Scripts/webkitpy/layout_tests/port/gtk.py:
3509         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3510         Port._webkit_baseline_path method.
3511         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3512         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3513         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3514         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3515         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3516         that are expected based on the builder name.
3517
3518 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3519
3520         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3521         https://bugs.webkit.org/show_bug.cgi?id=112571
3522
3523         Reviewed by Adam Barth.
3524
3525         Update function declarations for new WebFileSystemType enum. (All
3526         changes are behind an #ifdef so we can sync required changes in embedders.)
3527
3528         * DumpRenderTree/chromium/WebViewHost.cpp:
3529         (WebViewHost::openFileSystem):
3530         (WebViewHost::deleteFileSystem):
3531         * DumpRenderTree/chromium/WebViewHost.h:
3532         (WebViewHost):
3533
3534 2013-03-18  Julie Parent  <jparent@chromium.org>
3535
3536         Cleanup: Move timeline_exporer js out of html file into js.
3537         https://bugs.webkit.org/show_bug.cgi?id=112188
3538
3539         Reviewed by Dirk Pranke.
3540         
3541         Moves the javascript out of the html file and into a new js file.
3542         This follows the format of flakiness_dashboard.{html|js}.
3543         
3544         Also moves code from dashboard_base that is used only by this one
3545         dashboard, and makes it private to the dashboard.
3546
3547         * TestResultServer/static-dashboards/dashboard_base.js:
3548         * TestResultServer/static-dashboards/timeline_explorer.html:
3549         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3550         (generatePage):
3551         (initCurrentBuilderTestResults):
3552         (shouldShowWebKitRevisionsOnly):
3553         (updateTimelineForBuilder.):
3554         (updateTimelineForBuilder):
3555         (selectBuild):
3556         (updateBuildIndicator):
3557         (.addRow):
3558         (.addNumberRow):
3559         (.inspectorNode.getElementsByTagName.0.onclick):
3560         (.inspectorNode.getElementsByTagName.1.onclick):
3561         (.inspectorNode.getElementsByTagName.2.onclick):
3562         (updateBuildInspector):
3563         (showResultsDelta):
3564         (decompressResults.addFlakyDelta):
3565         (decompressResults):
3566
3567 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3568
3569         Unreviewed, rolling out r145272.
3570         http://trac.webkit.org/changeset/145272
3571         https://bugs.webkit.org/show_bug.cgi?id=111884
3572
3573         Turns out the ASAN build is still broken; possibly there's
3574         something still setting LD_LIBRARY_PATH, or possibly there's
3575         something else wrong. In the meantime, we need it to work again.
3576
3577         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3578
3579 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3580
3581         delete-stale-build-files is too aggressive
3582         https://bugs.webkit.org/show_bug.cgi?id=112595
3583
3584         Reviewed by Tim Horton.
3585
3586         It appears that whitelisting file extensions to keep is not a good idea.
3587         Blacklist files to delete instead, and only delete .o files for now.
3588         We can add more file extensions as needed.
3589
3590         * BuildSlaveSupport/delete-stale-build-files:
3591
3592 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3593
3594         Disable accessibility notifications after each test
3595         https://bugs.webkit.org/show_bug.cgi?id=112579
3596
3597         Reviewed by Tim Horton.
3598         
3599         In WebKitTestRunner, if any tests triggered accessibility notifications,
3600         the global notification handler would thereafter be active, and fire
3601         notifications for all subsequent tests.
3602         
3603         Fix by implementing AccessibilityController::resetToConsistentState() for
3604         Mac, and using it to clear the global notification handler.
3605
3606         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3607         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3608         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3609         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3610         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3611         (e.g. because of -autorelease).
3612         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3613         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3614         if there is one.
3615         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3616         Add -stopObserving
3617         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3618         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3619         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3620         center.
3621
3622 2013-03-18  Dana Jansens  <danakj@chromium.org>
3623
3624         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3625         https://bugs.webkit.org/show_bug.cgi?id=112392
3626
3627         Reviewed by James Robinson.
3628
3629         Removes the command line flag option from DRT.
3630
3631         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3632         (main):
3633
3634 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3635
3636         [GTK] plugins/plugin-clip-subframe.html is failing
3637         https://bugs.webkit.org/show_bug.cgi?id=112570
3638
3639         Reviewed by Martin Robinson.
3640
3641         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3642
3643 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3644
3645         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3646         https://bugs.webkit.org/show_bug.cgi?id=112442
3647
3648         Reviewed by Gustavo Noronha Silva.