Disable running tests on the MAC WK2 EWS queue.
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-02  Lucas Forschler  <lforschler@apple.com>
2
3         Disable running tests on the MAC WK2 EWS queue.
4         
5         Unreviewed.
6         
7         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
8         (MacWK2EWS):
9
10 2013-04-02  Julie Parent  <jparent@chromium.org>
11
12         Dashboard refactor: Move dashboard specific history related features to History.
13         https://bugs.webkit.org/show_bug.cgi?id=113717
14
15         Reviewed by Ojan Vafai.
16         
17         Each dashboard now creates its own History object, with a custom
18         configuration. This changes from just overriding global functions
19         to passing in callbacks for generatePage, handleValidHashParameter,
20         and handleQueryParameterChange. Same with passing in defaultStateValues
21         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
22         variables.
23         
24         All functions related to these features are now (mostly) private
25         function on History. 
26         
27         Loader no longer needs a loadingComplete callback, since it can just
28         initialize the history object itself.
29
30         * TestResultServer/static-dashboards/aggregate_results.js:
31         (handleValidHashParameter):
32         * TestResultServer/static-dashboards/dashboard_base.js:
33         * TestResultServer/static-dashboards/flakiness_dashboard.js:
34         (generatePage):
35         (.switch.return):
36         (handleQueryParameterChange):
37         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
38         (resetGlobals):
39         * TestResultServer/static-dashboards/history.js:
40         (.):
41         * TestResultServer/static-dashboards/loader.js:
42         (.):
43         * TestResultServer/static-dashboards/loader_unittests.js:
44         * TestResultServer/static-dashboards/timeline_explorer.js:
45         (generatePage):
46         (initCurrentBuilderTestResults):
47         * TestResultServer/static-dashboards/treemap.js:
48         (generatePage):
49         (.switch.return):
50         (handleQueryParameterChange):
51
52 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
53
54         Unreviewed, rolling out r147401.
55         http://trac.webkit.org/changeset/147401
56         https://bugs.webkit.org/show_bug.cgi?id=113767
57
58         The patch makes it extremely hard to set up the dependencies
59         properly on the GTK builders (Requested by zdobersek on
60         #webkit).
61
62         * gtk/jhbuild.modules:
63
64 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
65
66         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
67         https://bugs.webkit.org/show_bug.cgi?id=113382
68
69         Reviewed by Gyuyoung Kim.
70
71         Do not show the empty tooltip box if the text is null.
72
73         * MiniBrowser/efl/main.c:
74         (popup_menu_populate):
75
76 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
77
78         [GTK] Bump required versions of some dependencies
79         https://bugs.webkit.org/show_bug.cgi?id=113282
80
81         Reviewed by Martin Robinson.
82
83         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
84
85 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
86
87         Unreviewed, rolling out r147319.
88         http://trac.webkit.org/changeset/147319
89         https://bugs.webkit.org/show_bug.cgi?id=113707
90
91         The unit test is still failing on the buildbot (Requested by
92         zdobersek on #webkit).
93
94         * Scripts/run-gtk-tests:
95         (TestRunner):
96
97 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
98
99         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
100         https://bugs.webkit.org/show_bug.cgi?id=104779
101
102         Reviewed by Carlos Garcia Campos.
103
104         * Scripts/run-gtk-tests:
105         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
106         passing in current trunk.
107
108 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
109
110         Unreviewed, rolling out r147289.
111         http://trac.webkit.org/changeset/147289
112         https://bugs.webkit.org/show_bug.cgi?id=113678
113
114         broke Win7 (dbg) build (Requested by shinyak|gardener on
115         #webkit).
116
117         * DumpRenderTree/DumpRenderTree.gypi:
118         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
119         (WebTestRunner):
120         (WebUserMediaClientMock):
121         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
122         (WebTestRunner::WebUserMediaClientMock::taskList):
123         * Scripts/webkitpy/style/checkers/cpp.py:
124         (check_function_definition):
125
126 2013-03-31  Adam Barth  <abarth@webkit.org>
127
128         configure-svn-config.sh fails
129         https://codereview.chromium.org/13392007/
130
131         Reviewed by Eric Seidel.
132
133         This script was trying to use "svn checkout" to dowload a file from
134         svn.webkit.org, but "svn checkout" only works with directories.
135         Instead, we should use "svn export".
136
137         * EWSTools/configure-svn-config.sh:
138
139 2013-03-31  Wei Jia  <wjia@chromium.org>
140
141         Allow WebUserMediaClientMock to be used by client
142         https://bugs.webkit.org/show_bug.cgi?id=113633
143
144         Reviewed by Adam Barth.
145
146         Export WebUserMediaClientMock.
147         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
148
149         * DumpRenderTree/DumpRenderTree.gypi:
150         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
151         (WebUserMediaClientMock):
152         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
153         * Scripts/webkitpy/style/checkers/cpp.py:
154         (check_function_definition):
155
156 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
157
158         Expose FeatureObserver data to WebKit clients
159         https://bugs.webkit.org/show_bug.cgi?id=113613
160
161         Reviewed by Sam Weinig.
162
163         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
164         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
165
166 2013-03-29  Greg Hughes  <ghughes@apple.com>
167
168         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
169         https://bugs.webkit.org/show_bug.cgi?id=112276
170
171         Reviewed by Chris Fleizach.
172
173         Added support to test accessibility search predicates with multiple keys.  
174
175         * DumpRenderTree/AccessibilityUIElement.cpp:
176         (uiElementForSearchPredicateCallback):
177         * DumpRenderTree/AccessibilityUIElement.h:
178         (AccessibilityUIElement):
179         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
180         (AccessibilityUIElement::uiElementForSearchPredicate):
181         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
182         (AccessibilityUIElement::uiElementForSearchPredicate):
183         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
184         (AccessibilityUIElement::uiElementForSearchPredicate):
185         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
186         (AccessibilityUIElement::uiElementForSearchPredicate):
187         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
188         (AccessibilityUIElement::uiElementForSearchPredicate):
189         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
190         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
191         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
192         (AccessibilityUIElement):
193         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
194         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
195         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
196         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
197         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
198
199 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
200
201         Fix a typo in r147147 to fix Mac EWS.
202
203         * Scripts/webkitpy/tool/commands/queues.py:
204         (PatchProcessingQueue._new_port_name_from_old):
205
206 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
207
208         [EFL] Build break with latest EFL libraries after r146265
209         https://bugs.webkit.org/show_bug.cgi?id=113558
210
211         Unreviewed build fix.
212
213         * TestWebKitAPI/PlatformWebView.h:
214         * WebKitTestRunner/PlatformWebView.h:
215
216 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
217
218         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
219
220         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
221         in libgcrypt build.
222
223 2013-03-28  Lucas Forschler  <lforschler@apple.com>
224
225         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
226
227         Unreviewed.
228
229         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
230         (MacEWS):
231
232 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
233
234         Use the right OS name on Mac EWS instead of mac-future.
235
236         Rubber-stamped by Dirk Pranke.
237
238         * Scripts/webkitpy/tool/commands/queues.py:
239         (PatchProcessingQueue._new_port_name_from_old):
240         (PatchProcessingQueue.begin_work_queue):
241         (PatchProcessingQueue._upload_results_archive_for_patch):
242
243 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
244
245         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
246         https://bugs.webkit.org/show_bug.cgi?id=112546
247
248         Reviewed by Martin Robinson.
249
250         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
251         moved back to Source/WebCore/platform. Fix an indentation issue as well.
252
253 2013-03-28  Ming Xie  <mxie@blackberry.com>
254
255         [BlackBerry] Committer Email Updates
256         https://bugs.webkit.org/show_bug.cgi?id=113435
257
258         Reviewed by Rob Buis.
259
260         Add the @blackberry.com email address for all our BlackBerry
261         WebKit committers. This is the first step for our email address
262         migration.
263
264         * Scripts/webkitpy/common/config/committers.py:
265
266 2013-03-28  Philippe Normand  <pnormand@igalia.com>
267
268         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
269         https://bugs.webkit.org/show_bug.cgi?id=113508
270
271         Reviewed by Martin Robinson.
272
273         Prevent the GStreamer plugin scanner to load system-wide
274         plugins. Only the ones built in JHBuild should be loaded and used
275         at runtime.
276
277         * efl/jhbuildrc:
278         * gtk/jhbuildrc:
279
280 2013-03-27  Philippe Normand  <pnormand@igalia.com>
281
282         [GTK] run-launcher --gtk -2 fails on a WK2-only build
283         https://bugs.webkit.org/show_bug.cgi?id=113386
284
285         Reviewed by Carlos Garcia Campos.
286
287         * Scripts/webkitdirs.pm:
288         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
289         version to 3.0. Reflect this change so the builtDylibPathForName
290         function doesn't fail to report the library as found.
291
292 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
293
294         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
295         https://bugs.webkit.org/show_bug.cgi?id=113484
296
297         Unreviewed build fix.
298
299         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
300
301         * TestWebKitAPI/CMakeLists.txt:
302         * WebKitTestRunner/CMakeLists.txt:
303
304 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
305
306         Revision for the internal jhbuild is too old
307         https://bugs.webkit.org/show_bug.cgi?id=113324
308
309         Reviewed by Martin Robinson.
310
311         Update the minimum required version to a point where jhbuild won't
312         fail installing packages when trying to remove a symlink to a directory.
313
314         * jhbuild/jhbuild-wrapper: Updated revision.
315
316 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
317
318         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
319         https://bugs.webkit.org/show_bug.cgi?id=113203
320
321         Reviewed by Philippe Normand.
322
323         We build our libsoup without GNOME support. gst-plugins-good does separate
324         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
325         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
326         build failures as the headers of those diverge. We do not use souphttpsrc, so
327         disable it when building gst-plugins-good.
328
329         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
330
331 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
332
333         Build fix after r146852. Please another reference to the Lion leaks builder.
334
335         * BuildSlaveSupport/build.webkit.org-config/config.json:
336
337 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
338
339         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
340         https://bugs.webkit.org/show_bug.cgi?id=113421
341
342         Reviewed by Dirk Pranke.
343
344         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
345         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
346         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
347         in the GTK-specific TestExpectations files.
348
349         To avoid this only enable the warnings only when not using WKTR.
350
351         * Scripts/webkitpy/layout_tests/port/gtk.py:
352         (GtkPort.warn_if_bug_missing_in_test_expectations):
353
354 2013-03-27  Antti Koivisto  <antti@apple.com>
355
356         Fix Zalan's email.
357
358         * Scripts/webkitpy/common/config/committers.py:
359
360 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
361
362         master.cfg cleanup
363         https://bugs.webkit.org/show_bug.cgi?id=113195
364
365         Reviewed by Ryosuke Niwa.
366
367         * BuildSlaveSupport/build.webkit.org-config/config.json:
368         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
369
370 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
371
372         master.cfg fine-tuning for Qt Mountain Lion Release bot
373         https://bugs.webkit.org/show_bug.cgi?id=113191
374
375         Reviewed by Ryosuke Niwa.
376
377         * BuildSlaveSupport/build.webkit.org-config/config.json:
378           - Rename the slave due to its location change.
379           - Update the platform of the slave.
380         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
381         (RunQtAPITests): Enable running WK2 API tests on Qt.
382         (RunQtAPITests.start):
383         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
384         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
385
386 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
387
388         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
389         https://bugs.webkit.org/show_bug.cgi?id=113403
390
391         Reviewed by Kenneth Rohde Christiansen.
392
393         As of Evas 1.7.5, when Wayland is detected on the system, support for
394         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
395         The code, however, seems to depend on a few other flags which must be
396         explicitly enabled.
397
398         If those additional GL-related options are passed, we end up
399         having issues on the WebKit side, so disable Wayland support for
400         now.
401
402         * efl/jhbuild.modules:
403
404 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
405
406         Unreviewed, rolling out r146864.
407         http://trac.webkit.org/changeset/146864
408         https://bugs.webkit.org/show_bug.cgi?id=113391
409
410         causes crashes on Wk2 EFL release bot (Requested by drott on
411         #webkit).
412
413         * Scripts/webkitperl/FeatureList.pm:
414
415 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
416
417         [jhbuild] Correctly specify an alternate number of make jobs.
418         https://bugs.webkit.org/show_bug.cgi?id=113396
419
420         Reviewed by Philippe Normand.
421
422         So far, we were using the `MAKEFLAGS' environment variable to pass the
423         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
424         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
425
426         We now behave more closely to the rest of the WebKit tools by first
427         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
428         not set, just letting jhbuild itself figure out how many jobs to use.
429
430         * efl/jhbuildrc:
431         * gtk/jhbuildrc:
432
433 2013-03-27  Zeno Albisser  <zeno@webkit.org>
434
435         [Qt] Remove Qt specific WorkQueueItem definitions.
436         https://bugs.webkit.org/show_bug.cgi?id=112891
437
438         This patch is preparation work for removing
439         WorkQueue related code from TestRunnerQt and
440         replacing it with generic TestRunner code.
441
442         Reviewed by Benjamin Poulain.
443
444         * DumpRenderTree/qt/TestRunnerQt.cpp:
445         (TestRunnerQt::queueBackNavigation):
446         (TestRunnerQt::queueForwardNavigation):
447         (TestRunnerQt::queueLoadHTMLString):
448         (TestRunnerQt::queueReload):
449         (TestRunnerQt::queueLoadingScript):
450         (TestRunnerQt::queueNonLoadingScript):
451         (TestRunner::queueLoad):
452         * DumpRenderTree/qt/TestRunnerQt.h:
453         (TestRunnerQt):
454         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
455         (LoadItem::invoke):
456         (LoadHTMLStringItem::invoke):
457         (LoadAlternateHTMLStringItem::invoke):
458         (ReloadItem::invoke):
459         (ScriptItem::invoke):
460         (BackForwardItem::invoke):
461         * DumpRenderTree/qt/WorkQueueItemQt.h:
462         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
463         (LoadAlternateHTMLStringItem):
464
465 2013-03-26  Julie Parent  <jparent@chromium.org>
466
467         Flakiness dashboard: simplify logic around which tests to show.
468         https://bugs.webkit.org/show_bug.cgi?id=113250
469
470         Reviewed by Ojan Vafai.
471         
472         The different filters for showing results are only used for layout
473         tests, otherwise, we show everything.
474         
475         Change the defaults to false (what layout tests used), and only
476         look at the values when viewing layout tests.
477
478         * TestResultServer/static-dashboards/flakiness_dashboard.js:
479         (htmlForTestsWithExpectationsButNoFailures):
480         (shouldHideTest):
481
482 2013-03-26  Isaac Levy  <ilevy@google.com>
483
484         Update bots on test-results.appspot
485         https://bugs.webkit.org/show_bug.cgi?id=113333
486
487         Reviewed by Ojan Vafai.
488
489         * TestResultServer/static-dashboards/builders.jsonp:
490
491 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
492
493         Unreviewed GTK gardening.
494
495         * Scripts/run-gtk-tests:
496         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
497
498 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
499
500         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
501         https://bugs.webkit.org/show_bug.cgi?id=113287
502
503         Reviewed by Jocelyn Turcotte.
504
505         * Scripts/run-qtwebkit-tests:
506         (Options.__init__):
507
508 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
509
510         [EFL] Enable IndexedDB by default
511         https://bugs.webkit.org/show_bug.cgi?id=107248
512
513         Reviewed by Laszlo Gombos.
514
515         * Scripts/webkitperl/FeatureList.pm:
516         Enable IndexedDB by default on EFL.
517
518 2013-03-26  Alan Cutter  <alancutter@chromium.org>
519
520         Sheriffbot should explain rollout failures in a human readable form.
521         https://bugs.webkit.org/show_bug.cgi?id=107092
522
523         Reviewed by Ryosuke Niwa.
524
525         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
526
527         * Scripts/webkitpy/tool/bot/irc_command.py:
528         (Rollout._check_diff_failure):
529         (Rollout.execute):
530         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
531         (IRCCommandTest.test_rollout):
532
533 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
534
535         Unreviewed GTK gardening.
536
537         * Scripts/run-gtk-tests:
538         (TestRunner): Skipping a failing unit test after r146518.
539
540 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
541
542         Remove Lion leaks builder
543         https://bugs.webkit.org/show_bug.cgi?id=113252
544
545         Reviewed by Andreas Kling.
546
547         Removed.
548
549         * BuildSlaveSupport/build.webkit.org-config/config.json:
550
551 2013-03-25  Kent Tamura  <tkent@chromium.org>
552
553         Rename ENABLE_INPUT_TYPE_DATETIME
554         https://bugs.webkit.org/show_bug.cgi?id=113254
555
556         Reviewed by Kentaro Hara.
557
558         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
559         Actually I'd like to remove the code, but we shouldn't remove it yet
560         because we shipped products with it on some platforms.
561
562         * Scripts/webkitperl/FeatureList.pm:
563         * qmake/mkspecs/features/features.pri:
564
565 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
566
567         Remove one more line that was intended to be removed in r146657.
568
569         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
570         (summarize_results):
571
572 2013-03-25  Roger Fong  <roger_fong@apple.com>
573
574         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
575         Re-enable WinEWS tests.
576
577         * Scripts/webkitpy/common/config/ports.py:
578         (WinPort.run_bindings_tests_command):
579         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
580         (WinEWS):
581
582 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
583
584         Unreviewed, rolling out r146793.
585         http://trac.webkit.org/changeset/146793
586         https://bugs.webkit.org/show_bug.cgi?id=113248
587
588         Fix did not work (Requested by rfong on #webkit).
589
590         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
591         (WinEWS):
592
593 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
594
595         REGRESSION(r146657): Test failures reported incorrectly
596         https://bugs.webkit.org/show_bug.cgi?id=113223
597
598         Reviewed by Dirk Pranke.
599
600         The bug was caused by BuildBotPrinter not taking the new behavior into account.
601
602         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
603         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
604
605         * Scripts/webkitpy/layout_tests/controllers/manager.py:
606         (Manager.run):
607
608         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
609         (RunDetails.__init__):
610         (summarize_results): Remove the line I intended to remove in r146657.
611
612         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
613         (logging_run): Return details instead of the exit code.
614         (run_and_capture): Ditto.
615
616         (RunTest.test_full_results_html):
617         (RunTest.test_hung_thread):
618         (RunTest.test_no_tests_found):
619         (RunTest.test_no_tests_found_2):
620         (RunTest.test_repeat_each_iterations_num_tests):
621         (RunTest.test_run_singly_actually_runs_tests):
622         (RunTest.test_test_list):
623         (RunTest.test_missing_and_unexpected_results):
624         (RunTest.test_pixel_test_directories):
625         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
626         (RunTest.test_crash_with_stderr):
627         (RunTest.test_no_image_failure_with_image_diff):
628         (RunTest.test_crash_log):
629         (RunTest.test_exit_after_n_failures_upload):
630         (RunTest.test_results_directory_absolute):
631         (RunTest.test_results_directory_relative):
632         (RunTest.test_retrying_and_flaky_tests):
633         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
634         (RunTest.test_retrying_uses_retries_directory):
635         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
636         (RunTest.test_output_diffs):
637         (EndToEndTest.test_reftest_with_two_notrefs):
638         (RebaselineTest.test_reset_results):
639         (RebaselineTest.test_missing_results):
640         (RebaselineTest.test_new_baseline):
641
642         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
643         (BuildBotPrinter.print_results):
644         (BuildBotPrinter.print_unexpected_results):
645         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
646         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
647
648 2013-03-25  Julie Parent  <jparent@chromium.org>
649
650         Dashboard refactor: Move cross dashboard history related code into history.js.
651         https://bugs.webkit.org/show_bug.cgi?id=113104
652
653         Reviewed by Ojan Vafai.
654
655         All functions relating to cross dashboard behavior move from being
656         globals to methods on the history.History object. Names stay the same,
657         except many are made private, ones that should have been constants now
658         are, and the long standing TODO to change "currentState" to 
659         dashboardSpecificState is done.
660         
661         We now create a global history object in dashboard_base, as an 
662         intermediate measure.  Once the dashboard specific code is
663         added to history, each DB will need to create its own, and this
664         global will be eliminated.
665         
666         * TestResultServer/static-dashboards/aggregate_results.js:
667         (handleValidHashParameter):
668         (htmlForBuilder):
669         (rawValuesHTML):
670         * TestResultServer/static-dashboards/dashboard_base.js:
671         (parseDashboardSpecificParameters):
672         (defaultValue):
673         (currentBuilderGroupCategory):
674         (currentBuilderGroupName):
675         (handleLocationChange):
676         (expectationsMap):
677         * TestResultServer/static-dashboards/flakiness_dashboard.js:
678         (generatePage):
679         (.switch.return):
680         (platformAndBuildType):
681         (individualTests):
682         (substringList):
683         (processMissingAndExtraExpectations):
684         (pathToFailureLog):
685         (showPopupForBuild):
686         (htmlForTestsWithExpectationsButNoFailures):
687         (shouldHideTest):
688         (isCrossBuilderView):
689         (tableHeaders):
690         (htmlForSingleTestRow):
691         (htmlForTableColumnHeader):
692         (generatePageForExpectationsUpdate):
693         (handleUpdate):
694         (nextUpdate):
695         (setUpdateIndex):
696         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
697         (.appendExpectationsItem):
698         (loadExpectations):
699         (.dummyNode.onload):
700         (loadExpectationsLayoutTests):
701         (appendExpectations):
702         (htmlForNavBar):
703         (checkBoxToToggleState):
704         (linkHTMLToToggleState):
705         (generatePageForBuilder):
706         (isInvalidKeyForCrossBuilderView):
707         (handleQueryParameterChange):
708         (showLegend):
709         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
710         (resetGlobals):
711         (test):
712         * TestResultServer/static-dashboards/history.js:
713         (.):
714         * TestResultServer/static-dashboards/history_unittests.js:
715         * TestResultServer/static-dashboards/loader.js:
716         (.):
717         * TestResultServer/static-dashboards/loader_unittests.js:
718         * TestResultServer/static-dashboards/timeline_explorer.js:
719         (generatePage):
720         (initCurrentBuilderTestResults):
721         (selectBuild):
722         (showResultsDelta):
723         * TestResultServer/static-dashboards/treemap.js:
724         (generatePage):
725         (.switch.return):
726         (handleFocus):
727         * TestResultServer/static-dashboards/ui.js:
728
729 2013-03-25  Roger Fong  <roger_fong@apple.com>
730
731         Unreviewed. Enable WinEWS tests again.
732
733         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
734         (WinEWS):
735
736 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
737
738         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
739         https://bugs.webkit.org/show_bug.cgi?id=112166
740
741         HarfBuzz 0.9.14 merged my patch for icu detection without
742         pkg-config files, as needed by for example Ubuntu 12.04.
743         This obsoletes our local workaround. Removed it for GTK and EFL.
744
745         Reviewed by Martin Robinson.
746
747         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
748         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
749         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
750         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
751
752 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
753
754         Unreviewed.  Move self from contributor to committer list.
755
756         * Scripts/webkitpy/common/config/committers.py:
757
758 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
759
760         EWS should use a human readable port name when uploading layout test archives
761         https://bugs.webkit.org/show_bug.cgi?id=113099
762
763         Reviewed by Dirk Pranke.
764
765         Use new port's object's name() method to report human readable port names.
766         This will also help us resolving the bug to apply layout test results posted by EWS.
767
768         * Scripts/webkitpy/tool/bot/botinfo.py:
769         (BotInfo.__init__): Take port's name.
770         (BotInfo.summary_text):
771
772         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
773         (BotInfoTest.test_summary_text):
774
775         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
776         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
777
778         * Scripts/webkitpy/tool/commands/queues.py:
779         (PatchProcessingQueue.__init__): Initialize self._port.
780         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
781         and use that for the attachment filename and the comment posted.
782
783         * Scripts/webkitpy/tool/commands/queues_unittest.py:
784         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
785         "mac-snowleopard" as expected for TestPort.
786
787 2013-03-22  Roger Fong  <roger_fong@apple.com>
788
789         Unreviewed. Turn off EWS test on Win again.
790         The battle continues.
791
792         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
793         (WinEWS):
794
795 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
796
797         NRWT: Enable pixel tests when retrying tests
798         https://bugs.webkit.org/show_bug.cgi?id=112898
799
800         Reviewed by Dirk Pranke.
801
802         * Scripts/webkitpy/layout_tests/controllers/manager.py:
803         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
804         if we've forced pixel tests in the retry.
805         (Manager._run_tests):
806         (Manager._clean_up_run): Fixed the capitalizations.
807         (Manager._force_pixel_tests_if_needed): Added.
808
809         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
810         (_interpret_test_failures): Now that this function maybe called multiple times, only set
811         'image_diff_percent' if it doesn't already exist.
812
813         (summarize_results): When the first attempt resulted in a text failure and the second attempt
814         resulted in image and text failures and we've forced to run pixel tests in the retry run,
815         treat this as a regular regression instead of a flakiness.
816
817         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
818         run had image diffs.
819
820         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
821         (summarized_results):
822
823         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
824         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
825         Also removed some dead code.
826
827         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
828         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
829         is set and pixel_tests_enabled is set to false.
830         (EndToEndTest.test_reftest_with_two_notrefs):
831
832 2013-03-22  Tim Horton  <timothy_horton@apple.com>
833
834         Make it possible to run layout tests on Retina MBP
835         https://bugs.webkit.org/show_bug.cgi?id=93673
836
837         Reviewed by Ryosuke Niwa.
838
839         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
840         windows on 2x machines still run at 1x.
841
842         * DumpRenderTree/mac/DumpRenderTree.mm:
843         (createWebViewAndOffscreenWindow):
844         Reset the window resolution to 1x on creation.
845         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
846         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
847         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
848         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
849         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
850         (WTR::PlatformWebView::PlatformWebView):
851         Add NSWindow details, reset the window resolution to 1x on creation.
852
853 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
854
855         Leak bots shouldn't build
856         https://bugs.webkit.org/show_bug.cgi?id=112774
857
858         Reviewed by Simon Fraser.
859
860         Since leak bots use regular debug builds, there is no need to build on these bots.
861         Simply downloading builds will dramatically improve the cycle time of these bots.
862
863         * BuildSlaveSupport/build.webkit.org-config/config.json:
864         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
865         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
866         TestFactory instead of BuildAndTestFactory.
867
868 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
869
870         [Qt] Fix the TestWebKitAPI build
871         https://bugs.webkit.org/show_bug.cgi?id=113044
872
873         Reviewed by Tor Arne Vestbø.
874
875         The generate-forwarding-headers script would only be run
876         after the targets in InjectedBundle.pri since the second
877         addStrictSubdirOrderBetween call in
878         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
879         the derived_sources -> injected_bundle order in SUBDIRS.
880
881         Fix it by only moving the dependent target at the end of
882         SUBDIRS, don't touch its dependency.
883
884         * qmake/mkspecs/features/functions.prf:
885
886 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
887
888         [EFL][WK2] View is not focused when fullscreen mode toggled
889         https://bugs.webkit.org/show_bug.cgi?id=113009
890
891         Reviewed by Laszlo Gombos.
892
893         Set focus on view when fullscreen mode enabled/disabled
894         by FullScreen API.
895
896         * MiniBrowser/efl/main.c:
897         (on_fullscreen_accept):
898         (on_fullscreen_deny):
899
900 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
901
902         nrwt is no longer saving retry results in the retries/ subdirectory
903         https://bugs.webkit.org/show_bug.cgi?id=112995
904
905         Reviewed by Ojan Vafai.
906
907         I think this has been broken a long time, unfortunately. This
908         patch should fix that.
909
910         In order to do so, I had to pass the directory to use from
911         the Worker object through the SingleTestWriter to the
912         TestResultWriter. While I was plumbing that through, I rationalized
913         the order of the parameter arguments a bit ...
914
915         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
916         (Worker._run_single_test):
917         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
918         (run_single_test):
919         (SingleTestRunner.__init__):
920         (SingleTestRunner._run_compare_test):
921         (SingleTestRunner._run_rebaseline):
922         (SingleTestRunner._run_reftest):
923         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
924         (write_test_result):
925         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
926         (TestResultWriterTest.test_reftest_diff_image):
927         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
928         (RunTest.test_retrying_uses_retries_directory):
929
930 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
931
932         JSC profiler should have an at-a-glance report of the success of DFG optimization
933         https://bugs.webkit.org/show_bug.cgi?id=112988
934
935         Reviewed by Geoffrey Garen.
936
937         * Scripts/display-profiler-output:
938
939 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
940
941         [chromium] Linux ASAN WebKit canary is running out of memory
942         https://bugs.webkit.org/show_bug.cgi?id=112978
943
944         Reviewed by Tony Chang.
945
946         Running the AddressSanitizer on a crash takes a lot of
947         memory, so we should serialize access to it to avoid running
948         out of memory on a machine.
949
950         * Scripts/webkitpy/layout_tests/port/chromium.py:
951         (ChromiumPort._get_crash_log):
952         * Scripts/webkitpy/layout_tests/port/http_lock.py:
953         (HttpLock.__init__):
954         (HttpLock.wait_for_httpd_lock):
955
956 2013-03-21  Min Qin  <qinmin@chromium.org>
957
958         Cleanup android media layout test code
959         https://bugs.webkit.org/show_bug.cgi?id=112944
960
961         Reviewed by Adam Barth.
962
963         Chromium change: https://codereview.chromium.org/12892010/
964         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
965         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
966         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
967         Instead, we should switch to use content shell for layout tests.
968
969         * DumpRenderTree/chromium/TestShell.cpp:
970         (TestShell::resetTestController):
971
972 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
973
974         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
975         https://bugs.webkit.org/show_bug.cgi?id=112953
976
977         Reviewed by Tony Chang.
978
979         When I created the DumpRenderTree_resources target in r144863 I
980         forgot to declare the needed dependencies on the other resource
981         targets. Due to a quirk of ordering, this appears to have been fine
982         w/ ninja but not w/ Xcode (which is still being used on the chromium
983         mac valgrind bots). Declaring the dependencies fixes the build
984         failures.
985
986         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
987
988 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
989
990         [WinCairo] Correct assert in Empty BitmapImage Test.
991         https://bugs.webkit.org/show_bug.cgi?id=112934
992
993         Reviewed by Tim Horton.
994
995         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
996         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
997         to avoid ref counting assertion when leaving test scope.
998
999 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
1000
1001         [GTK] generate-feature-defines-files is incompatible with Python3
1002         https://bugs.webkit.org/show_bug.cgi?id=112956
1003
1004         Reviewed by Martin Robinson.
1005
1006         Make the generate-feature-defines-files compatible with Python3 by calling the items()
1007         method on the dictionary objects when iterating through said dictionaries.
1008
1009         * gtk/generate-feature-defines-files:
1010         (write_feature_defines_header):
1011         (write_flattened_feature_defines_file):
1012
1013 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1014
1015         kill-old-processes spits out error messages on Mac
1016         https://bugs.webkit.org/show_bug.cgi?id=112878
1017
1018         Reviewed by Jessie Berlin.
1019
1020         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
1021         included in the list of options grep --help shows.
1022
1023         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
1024
1025         * BuildSlaveSupport/kill-old-processes:
1026         (main):
1027
1028 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
1029
1030         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
1031         https://bugs.webkit.org/show_bug.cgi?id=112597
1032
1033         Reviewed by Xan Lopez.
1034
1035         These were introduced for the Chromium port in r105295. We need
1036         dummy implementations in order to compile the BlackBerry port.
1037
1038         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1039         (AccessibilityUIElement::scrollToMakeVisible):
1040         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
1041         (AccessibilityUIElement::scrollToGlobalPoint):
1042
1043 2013-03-21  Roger Fong  <roger_fong@apple.com>
1044
1045         Re-enable WinEWS tests following r146376.
1046
1047         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1048         (WinEWS):
1049
1050 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
1051
1052         Unreviewed. Add Bem Jones-Bey to the list of contributors.
1053
1054         * Scripts/webkitpy/common/config/committers.py:
1055
1056 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1057
1058         [GTK] Missing atk in install-dependencies script
1059         https://bugs.webkit.org/show_bug.cgi?id=112272
1060
1061         Reviewed by Gustavo Noronha Silva.
1062
1063         * gtk/install-dependencies: Add missing atk dependency.
1064
1065 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
1066
1067         [GTK] Missing backslash in install-dependencies script
1068         https://bugs.webkit.org/show_bug.cgi?id=112907
1069
1070         Reviewed by Philippe Normand.
1071
1072         * gtk/install-dependencies: Add missing backslash to dependencies
1073         list.
1074
1075 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
1076
1077         EWS bots have stopped uploading results to bugzilla
1078         https://bugs.webkit.org/show_bug.cgi?id=101091
1079
1080         Reviewed by Adam Barth.
1081
1082         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
1083         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
1084         this relative file path resoled to a file inside a non-existent directory for "zip".
1085
1086         Fixed the bug by resolving both test results directory and zip archive paths in
1087         LayoutTestResultsReader.archive.
1088
1089         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
1090         in the future.
1091
1092         * Scripts/webkitpy/common/system/filesystem_mock.py:
1093         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
1094
1095         * Scripts/webkitpy/common/system/workspace.py:
1096         (Workspace.create_zip): Log the source path when "zip" failed.
1097
1098         * Scripts/webkitpy/common/system/workspace_mock.py:
1099         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
1100
1101         * Scripts/webkitpy/common/system/workspace_unittest.py:
1102         (WorkspaceTest.test_create_zip_exception): Test that.
1103
1104         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1105         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
1106         This is the actual bug fix.
1107
1108         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1109         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
1110
1111 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
1112
1113         [chromium] move WebThemeEngine implementations to TestRunner library
1114         https://bugs.webkit.org/show_bug.cgi?id=112751
1115
1116         Reviewed by Adam Barth.
1117
1118         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1119         * DumpRenderTree/DumpRenderTree.gypi:
1120         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1121         (WebKit):
1122         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1123         (WebTestRunner::TestInterfaces::themeEngine):
1124         (WebTestRunner):
1125         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1126         (WebKit):
1127         (TestInterfaces):
1128         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1129         (WebTestRunner::WebTestInterfaces::themeEngine):
1130         (WebTestRunner):
1131         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1132         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1133         (WebTestRunner):
1134         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1135         (WebTestRunner::WebTestThemeControlWin::box):
1136         (WebTestRunner::WebTestThemeControlWin::line):
1137         (WebTestRunner::WebTestThemeControlWin::triangle):
1138         (WebTestRunner::WebTestThemeControlWin::roundRect):
1139         (WebTestRunner::WebTestThemeControlWin::oval):
1140         (WebTestRunner::WebTestThemeControlWin::circle):
1141         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1142         (WebTestRunner::WebTestThemeControlWin::markState):
1143         (WebTestRunner::WebTestThemeControlWin::draw):
1144         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1145         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1146         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1147         (WebTestRunner):
1148         (WebTestThemeControlWin):
1149         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1150         (WebTestRunner):
1151         (WebTestThemeEngineMac):
1152         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1153         (+[FakeActiveWindow alwaysActiveWindow]):
1154         (+[FakeActiveWindow alwaysInactiveWindow]):
1155         (-[FakeActiveWindow initWithActiveControls:]):
1156         (-[FakeActiveWindow _hasActiveControls]):
1157         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1158         (WebTestRunner):
1159         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1160         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1161         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1162         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1163         (WebTestRunner):
1164         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1165         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1166         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1167         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1168         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1169         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1170         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1171         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1172         (WebTestRunner::WebTestThemeEngineWin::getSize):
1173         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1174         (WebTestRunner):
1175         (WebTestThemeEngineWin):
1176         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1177         * DumpRenderTree/chromium/TestShell.cpp:
1178         (TestShell::initialize):
1179         * DumpRenderTree/chromium/TestShell.h:
1180         (WebKit):
1181         * DumpRenderTree/chromium/TestShellMac.mm:
1182         (platformInit):
1183         * DumpRenderTree/chromium/TestShellWin.cpp:
1184         (platformInit):
1185         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1186
1187 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1188
1189         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
1190
1191         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
1192         New property sheet that does not link against CoreFoundation and
1193         CFNetwork.
1194         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
1195         Use new TestWebKitAPICommonWinCairo property sheet.
1196         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
1197         Ditto.
1198
1199 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1200
1201         [WinCairo] Unreviewed build fix for VS2010.
1202
1203         Had to add WinCairo-specific property sheets to deal with some
1204         library and path differences with the main Apple port.
1205
1206         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1207         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
1208         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
1209         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
1210         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
1211         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
1212
1213 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
1214
1215         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
1216         https://bugs.webkit.org/show_bug.cgi?id=112849
1217
1218         Reviewed by Sam Weinig.
1219
1220         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1221         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1222         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1223
1224 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
1225
1226         [WinCairo] Build WebKit Tools under VS2010
1227         https://bugs.webkit.org/show_bug.cgi?id=112821
1228
1229         Reviewed by Tim Horton.
1230
1231         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1232         Add WinCairo-specific build target.
1233         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
1234         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
1235         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
1236         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
1237         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1238         Add WinCairo-specific build target.
1239         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1240         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1241         Add WinCairo-specific build target.
1242         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
1243         WinCairo-specific build target.
1244         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
1245         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
1246         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
1247         specific build target.
1248         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
1249         WinCairo-specific build target.
1250         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
1251         * win/record-memory/record-memoryDebugWinCairo.props: Added.
1252         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
1253
1254 2013-03-20  Roger Fong  <roger_fong@apple.com>
1255
1256         API test gardening AppleWin port.
1257
1258         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
1259
1260         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1261         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1262
1263 2013-03-20  Roger Fong  <roger_fong@apple.com>
1264
1265         Test fix for Win EWS bots, catch various errors and restart script if necessary.
1266
1267         * EWSTools/start-queue-win.sh:
1268
1269 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
1270
1271         Unreviewed, add myself to committers.py.
1272
1273 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1274
1275         Unreviewed. Adding another email for me.
1276
1277         * Scripts/webkitpy/common/config/committers.py:
1278
1279 2013-03-20  Justin Novosad  <junov@google.com>
1280
1281         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
1282         https://bugs.webkit.org/show_bug.cgi?id=112605
1283
1284         Reviewed by James Robinson.
1285
1286         Deleting all the code that was used for propagating and supporting
1287         the Chromium setting for disabling deferred 2d canvas rendering.
1288
1289         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1290         (main):
1291         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
1292         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1293         (WebTestRunner::WebPreferences::reset):
1294         (WebTestRunner::WebPreferences::applyTo):
1295         * DumpRenderTree/chromium/TestShell.cpp:
1296         (TestShell::TestShell):
1297         (TestShell::resetWebSettings):
1298         (TestShell::runFileTest):
1299         * DumpRenderTree/chromium/TestShell.h:
1300         (TestShell):
1301
1302 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
1303
1304         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
1305         https://bugs.webkit.org/show_bug.cgi?id=112699.
1306
1307         Reviewed by Adam Barth.
1308
1309         * Scripts/webkitpy/layout_tests/port/qt.py:
1310         (QtPort._search_paths):
1311         (QtPort._port_specific_expectations_files):
1312         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1313         (QtPortTest):
1314         (QtPortTest._assert_search_path):
1315         (QtPortTest._assert_expectations_files):
1316
1317 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1318
1319         [Qt] Enable kerning by default
1320         https://bugs.webkit.org/show_bug.cgi?id=112704
1321
1322         Reviewed by Jocelyn Turcotte.
1323
1324         Disable kerning by default, since some reference test expectations
1325         expect kerning to be default off.
1326
1327         * DumpRenderTree/qt/TestRunnerQt.cpp:
1328         (TestRunnerQt::reset):
1329         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1330         (WTR::activateFonts):
1331
1332 2013-03-20  Zeno Albisser  <zeno@webkit.org>
1333
1334         [Qt] Remove empty function stubs from TestRunnerQt.
1335         https://bugs.webkit.org/show_bug.cgi?id=112799
1336
1337         We are reducing the code in TestRunnerQt step by step,
1338         in order to finally replace all of it with the generic
1339         TestRunner implementation.
1340         This patch removes several simple function stubs that
1341         currently do not implement any actual functionality.
1342
1343         Reviewed by Kenneth Rohde Christiansen.
1344
1345         * DumpRenderTree/qt/TestRunnerQt.cpp:
1346         * DumpRenderTree/qt/TestRunnerQt.h:
1347         (TestRunnerQt):
1348
1349 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1350
1351         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
1352         https://bugs.webkit.org/show_bug.cgi?id=112687
1353
1354         Reviewed by Kenneth Rohde Christiansen.
1355
1356         Hide the SearchBar by default on window creation.
1357
1358         * MiniBrowser/efl/main.c:
1359         (window_create):
1360
1361 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1362
1363         Unreviewed, rolling out r146304.
1364         http://trac.webkit.org/changeset/146304
1365         https://bugs.webkit.org/show_bug.cgi?id=112788
1366
1367         to many expectations to update (Requested by antonm on
1368         #webkit).
1369
1370         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1371         * DumpRenderTree/DumpRenderTree.gypi:
1372         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1373         (WebKit):
1374         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1375         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1376         (TestInterfaces):
1377         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1378         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1379         * DumpRenderTree/chromium/TestShell.cpp:
1380         (TestShell::initialize):
1381         * DumpRenderTree/chromium/TestShell.h:
1382         (WebKit):
1383         * DumpRenderTree/chromium/TestShellMac.mm:
1384         (platformInit):
1385         * DumpRenderTree/chromium/TestShellWin.cpp:
1386         (platformInit):
1387         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
1388         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1389         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
1390         (WebThemeControlDRTWin::box):
1391         (WebThemeControlDRTWin::line):
1392         (WebThemeControlDRTWin::triangle):
1393         (WebThemeControlDRTWin::roundRect):
1394         (WebThemeControlDRTWin::oval):
1395         (WebThemeControlDRTWin::circle):
1396         (WebThemeControlDRTWin::nestedBoxes):
1397         (WebThemeControlDRTWin::markState):
1398         (WebThemeControlDRTWin::draw):
1399         (WebThemeControlDRTWin::drawTextField):
1400         (WebThemeControlDRTWin::drawProgressBar):
1401         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
1402         (WebThemeControlDRTWin):
1403         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
1404         (WebThemeEngineDRTMac):
1405         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
1406         (+[FakeActiveWindow alwaysActiveWindow]):
1407         (+[FakeActiveWindow alwaysInactiveWindow]):
1408         (-[FakeActiveWindow initWithActiveControls:]):
1409         (-[FakeActiveWindow _hasActiveControls]):
1410         (WebThemeEngineDRTMac::paintScrollbarThumb):
1411         (stateToHIEnableState):
1412         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1413         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1414         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
1415         (webRectToSkIRect):
1416         (drawControl):
1417         (drawTextField):
1418         (drawProgressBar):
1419         (WebThemeEngineDRTWin::paintButton):
1420         (WebThemeEngineDRTWin::paintMenuList):
1421         (WebThemeEngineDRTWin::paintScrollbarArrow):
1422         (WebThemeEngineDRTWin::paintScrollbarThumb):
1423         (WebThemeEngineDRTWin::paintScrollbarTrack):
1424         (WebThemeEngineDRTWin::paintSpinButton):
1425         (WebThemeEngineDRTWin::paintTextField):
1426         (WebThemeEngineDRTWin::paintTrackbar):
1427         (WebThemeEngineDRTWin::paintProgressBar):
1428         (WebThemeEngineDRTWin::getSize):
1429         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
1430         (WebThemeEngineDRTWin):
1431         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1432
1433 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1434
1435         [Qt] Support -webkit-font-smoothing
1436         https://bugs.webkit.org/show_bug.cgi?id=106009
1437
1438         Reviewed by Jocelyn Turcotte.
1439
1440         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
1441
1442         * DumpRenderTree/qt/TestRunnerQt.cpp:
1443         (TestRunnerQt::reset):
1444
1445 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
1446
1447         [GTK] accessibility/aria-scrollbar-role.html is failing
1448         https://bugs.webkit.org/show_bug.cgi?id=98358
1449
1450         Reviewed by Martin Robinson.
1451
1452         Adds support for checking accessibility object's orientation.
1453         Orientation is checked by retrieving proper state of accessibility object.
1454
1455         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1456         (checkElementState):
1457         (AccessibilityUIElement::orientation):
1458         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1459         (WTR::AccessibilityUIElement::orientation):
1460
1461 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
1462
1463         [chromium] move WebThemeEngine implementations to TestRunner library
1464         https://bugs.webkit.org/show_bug.cgi?id=112751
1465
1466         Reviewed by Adam Barth.
1467
1468         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1469         * DumpRenderTree/DumpRenderTree.gypi:
1470         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1471         (WebKit):
1472         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1473         (WebTestRunner::TestInterfaces::themeEngine):
1474         (WebTestRunner):
1475         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1476         (WebKit):
1477         (TestInterfaces):
1478         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1479         (WebTestRunner::WebTestInterfaces::themeEngine):
1480         (WebTestRunner):
1481         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1482         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1483         (WebTestRunner):
1484         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1485         (WebTestRunner::WebTestThemeControlWin::box):
1486         (WebTestRunner::WebTestThemeControlWin::line):
1487         (WebTestRunner::WebTestThemeControlWin::triangle):
1488         (WebTestRunner::WebTestThemeControlWin::roundRect):
1489         (WebTestRunner::WebTestThemeControlWin::oval):
1490         (WebTestRunner::WebTestThemeControlWin::circle):
1491         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1492         (WebTestRunner::WebTestThemeControlWin::markState):
1493         (WebTestRunner::WebTestThemeControlWin::draw):
1494         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1495         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1496         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1497         (WebTestRunner):
1498         (WebTestThemeControlWin):
1499         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1500         (WebTestRunner):
1501         (WebTestThemeEngineMac):
1502         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1503         (+[FakeActiveWindow alwaysActiveWindow]):
1504         (+[FakeActiveWindow alwaysInactiveWindow]):
1505         (-[FakeActiveWindow initWithActiveControls:]):
1506         (-[FakeActiveWindow _hasActiveControls]):
1507         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1508         (WebTestRunner):
1509         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1510         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1511         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1512         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1513         (WebTestRunner):
1514         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1515         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1516         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1517         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1518         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1519         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1520         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1521         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1522         (WebTestRunner::WebTestThemeEngineWin::getSize):
1523         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1524         (WebTestRunner):
1525         (WebTestThemeEngineWin):
1526         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1527         * DumpRenderTree/chromium/TestShell.cpp:
1528         (TestShell::initialize):
1529         * DumpRenderTree/chromium/TestShell.h:
1530         (WebKit):
1531         * DumpRenderTree/chromium/TestShellMac.mm:
1532         (platformInit):
1533         * DumpRenderTree/chromium/TestShellWin.cpp:
1534         (platformInit):
1535         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1536
1537 2013-03-19  Tony Chang  <tony@chromium.org>
1538
1539         Move testRunner.setTouchDragDropEnabled to internals.settings
1540         https://bugs.webkit.org/show_bug.cgi?id=112739
1541
1542         Reviewed by Adam Barth.
1543
1544         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1545         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
1546         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1547         (TestRunner): Remove unnecessary code.
1548         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1549         (WebTestRunner::WebPreferences::reset):
1550         (WebTestRunner::WebPreferences::applyTo): Always set to false.
1551
1552 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
1553
1554         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
1555         https://bugs.webkit.org/show_bug.cgi?id=112754
1556
1557         Reviewed by Darin Fisher.
1558
1559         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
1560         now that it's always defined.
1561
1562         * DumpRenderTree/chromium/WebViewHost.cpp:
1563         * DumpRenderTree/chromium/WebViewHost.h:
1564         (WebViewHost):
1565
1566 2013-03-19  Kenneth Russell  <kbr@google.com>
1567
1568         Unreviewed, rolling out r146290.
1569         http://trac.webkit.org/changeset/146290
1570         https://bugs.webkit.org/show_bug.cgi?id=112751
1571
1572         Broke Chromium Mac build.
1573
1574         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1575         * DumpRenderTree/DumpRenderTree.gypi:
1576         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1577         (WebKit):
1578         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1579         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1580         (TestInterfaces):
1581         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1582         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1583         * DumpRenderTree/chromium/TestShell.cpp:
1584         (TestShell::initialize):
1585         * DumpRenderTree/chromium/TestShell.h:
1586         (WebKit):
1587         * DumpRenderTree/chromium/TestShellMac.mm:
1588         (platformInit):
1589         * DumpRenderTree/chromium/TestShellWin.cpp:
1590         (platformInit):
1591         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
1592         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1593         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
1594         (WebThemeControlDRTWin::box):
1595         (WebThemeControlDRTWin::line):
1596         (WebThemeControlDRTWin::triangle):
1597         (WebThemeControlDRTWin::roundRect):
1598         (WebThemeControlDRTWin::oval):
1599         (WebThemeControlDRTWin::circle):
1600         (WebThemeControlDRTWin::nestedBoxes):
1601         (WebThemeControlDRTWin::markState):
1602         (WebThemeControlDRTWin::draw):
1603         (WebThemeControlDRTWin::drawTextField):
1604         (WebThemeControlDRTWin::drawProgressBar):
1605         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
1606         (WebThemeControlDRTWin):
1607         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
1608         (WebThemeEngineDRTMac):
1609         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
1610         (+[FakeActiveWindow alwaysActiveWindow]):
1611         (+[FakeActiveWindow alwaysInactiveWindow]):
1612         (-[FakeActiveWindow initWithActiveControls:]):
1613         (-[FakeActiveWindow _hasActiveControls]):
1614         (WebThemeEngineDRTMac::paintScrollbarThumb):
1615         (stateToHIEnableState):
1616         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1617         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1618         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
1619         (webRectToSkIRect):
1620         (drawControl):
1621         (drawTextField):
1622         (drawProgressBar):
1623         (WebThemeEngineDRTWin::paintButton):
1624         (WebThemeEngineDRTWin::paintMenuList):
1625         (WebThemeEngineDRTWin::paintScrollbarArrow):
1626         (WebThemeEngineDRTWin::paintScrollbarThumb):
1627         (WebThemeEngineDRTWin::paintScrollbarTrack):
1628         (WebThemeEngineDRTWin::paintSpinButton):
1629         (WebThemeEngineDRTWin::paintTextField):
1630         (WebThemeEngineDRTWin::paintTrackbar):
1631         (WebThemeEngineDRTWin::paintProgressBar):
1632         (WebThemeEngineDRTWin::getSize):
1633         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
1634         (WebThemeEngineDRTWin):
1635         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
1636
1637 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
1638
1639         [EFL] canvas-fallback-content.html is failing
1640         https://bugs.webkit.org/show_bug.cgi?id=111998
1641
1642         Reviewed by Chris Fleizach.
1643
1644         Adds support for getting platform name.
1645
1646         * DumpRenderTree/TestRunner.cpp:
1647         (TestRunner::staticValues):
1648         * DumpRenderTree/TestRunner.h:
1649         (TestRunner):
1650         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1651         (TestRunner::platformName):
1652
1653 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
1654
1655         [chromium] move WebThemeEngine implementations to TestRunner library
1656         https://bugs.webkit.org/show_bug.cgi?id=112751
1657
1658         Reviewed by Adam Barth.
1659
1660         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1661         * DumpRenderTree/DumpRenderTree.gypi:
1662         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
1663         (WebKit):
1664         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1665         (WebTestRunner::TestInterfaces::themeEngine):
1666         (WebTestRunner):
1667         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
1668         (WebKit):
1669         (TestInterfaces):
1670         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1671         (WebTestRunner::WebTestInterfaces::themeEngine):
1672         (WebTestRunner):
1673         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
1674         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
1675         (WebTestRunner):
1676         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
1677         (WebTestRunner::WebTestThemeControlWin::box):
1678         (WebTestRunner::WebTestThemeControlWin::line):
1679         (WebTestRunner::WebTestThemeControlWin::triangle):
1680         (WebTestRunner::WebTestThemeControlWin::roundRect):
1681         (WebTestRunner::WebTestThemeControlWin::oval):
1682         (WebTestRunner::WebTestThemeControlWin::circle):
1683         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
1684         (WebTestRunner::WebTestThemeControlWin::markState):
1685         (WebTestRunner::WebTestThemeControlWin::draw):
1686         (WebTestRunner::WebTestThemeControlWin::drawTextField):
1687         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
1688         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
1689         (WebTestRunner):
1690         (WebTestThemeControlWin):
1691         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
1692         (WebTestRunner):
1693         (WebTestThemeEngineMac):
1694         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
1695         (+[FakeActiveWindow alwaysActiveWindow]):
1696         (+[FakeActiveWindow alwaysInactiveWindow]):
1697         (-[FakeActiveWindow initWithActiveControls:]):
1698         (-[FakeActiveWindow _hasActiveControls]):
1699         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
1700         (WebTestRunner):
1701         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
1702         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
1703         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
1704         (WebTestRunner::WebTestThemeEngineWin::paintButton):
1705         (WebTestRunner):
1706         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
1707         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
1708         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
1709         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
1710         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
1711         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
1712         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
1713         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
1714         (WebTestRunner::WebTestThemeEngineWin::getSize):
1715         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
1716         (WebTestRunner):
1717         (WebTestThemeEngineWin):
1718         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
1719         * DumpRenderTree/chromium/TestShell.cpp:
1720         (TestShell::initialize):
1721         * DumpRenderTree/chromium/TestShell.h:
1722         (WebKit):
1723         * DumpRenderTree/chromium/TestShellMac.mm:
1724         (platformInit):
1725         * DumpRenderTree/chromium/TestShellWin.cpp:
1726         (platformInit):
1727         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
1728
1729 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1730
1731         [EFL][WK2] Separate WebView further from EwkView
1732         https://bugs.webkit.org/show_bug.cgi?id=111591
1733
1734         Reviewed by Caio Marcelo de Oliveira Filho.
1735
1736         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
1737         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
1738         since we can afford it having EWKViewGetWKView() private API to access WKView.
1739
1740         * TestWebKitAPI/PlatformWebView.h:
1741         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1742         (TestWebKitAPI::TEST):
1743         * TestWebKitAPI/efl/PlatformWebView.cpp:
1744         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1745         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
1746         (TestWebKitAPI::PlatformWebView::resizeTo):
1747         (TestWebKitAPI::PlatformWebView::page):
1748         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
1749         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
1750         (TestWebKitAPI::PlatformWebView::simulateRightClick):
1751         * WebKitTestRunner/PlatformWebView.h:
1752         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
1753         (WTR::EventSenderProxy::dispatchEvent):
1754         (WTR::EventSenderProxy::keyDown):
1755         (WTR::EventSenderProxy::sendTouchEvent):
1756         (WTR::EventSenderProxy::setTouchModifier):
1757         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1758         (WTR::PlatformWebView::PlatformWebView):
1759         (WTR::PlatformWebView::~PlatformWebView):
1760         (WTR::PlatformWebView::resizeTo):
1761         (WTR::PlatformWebView::page):
1762         (WTR::PlatformWebView::focus):
1763         (WTR::PlatformWebView::windowSnapshotImage):
1764
1765 2013-03-19  Roger Fong  <roger_fong@apple.com>
1766
1767         Changes to VS2010 project files should only trigger builds on Windows bots.
1768         https://bugs.webkit.org/show_bug.cgi?id=112731
1769
1770         Reviewed by Timothy Horton.
1771
1772         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1773         (_should_file_trigger_build):
1774
1775 2013-03-19  Roger Fong  <roger_fong@apple.com>
1776
1777         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
1778
1779         * Scripts/webkitpy/tool/steps/runtests.py:
1780         (RunTests.run):
1781         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1782         (RunTestsTest.test_webkit_run_unit_tests):
1783
1784 2013-03-19  Julie Parent  <jparent@chromium.org>
1785
1786         Dashboards: Introduce history namespace and unit tests.
1787         https://bugs.webkit.org/show_bug.cgi?id=112645
1788
1789         Reviewed by Ojan Vafai.
1790         
1791         Laying the framework for introducing the new history object and
1792         namespace.  This moves only static functions into the history
1793         namespace, and moves corresponding unit tests into seperate
1794         unit test file.
1795
1796         * TestResultServer/static-dashboards/aggregate_results.html:
1797         * TestResultServer/static-dashboards/dashboard_base.js:
1798         (parseCrossDashboardParameters):
1799         (parseDashboardSpecificParameters):
1800         (parseParameters):
1801         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1802         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1803         (.switch.return):
1804         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1805         * TestResultServer/static-dashboards/history.js: Added.
1806         * TestResultServer/static-dashboards/history_unittests.js: Added.
1807         * TestResultServer/static-dashboards/loader.js:
1808         (.):
1809         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1810         * TestResultServer/static-dashboards/run-unittests.html:
1811         * TestResultServer/static-dashboards/timeline_explorer.html:
1812         * TestResultServer/static-dashboards/timeline_explorer.js:
1813         * TestResultServer/static-dashboards/treemap.html:
1814         * TestResultServer/static-dashboards/treemap.js:
1815         (.switch.return):
1816         * TestResultServer/static-dashboards/ui.js:
1817
1818 2013-03-19  Daniel Bates  <dbates@webkit.org>
1819
1820         svn-apply has trouble applying a patch that adds a Windows newline to EOF
1821         https://bugs.webkit.org/show_bug.cgi?id=112732
1822
1823         Reviewed by Eric Seidel.
1824
1825         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
1826         of an existing file cannot be applied.
1827
1828         In particular, svn-{apply, unapply} compensate for differences in line endings
1829         by converting the line endings in a diff to match the line endings in the target
1830         file. The diff(1) command precedes the last line of a diff that adds a newline
1831         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
1832         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
1833         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
1834         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
1835         the newline characters in this special character sequence to match the line endings
1836         in the target file.
1837
1838         * Scripts/VCSUtils.pm:
1839         (parseDiff):
1840         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1841         Added tests:
1842             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
1843             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
1844             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
1845             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
1846         (escapeNewLineCharacters): Added.
1847         (toMacLineEndings): Added.
1848
1849 2013-03-19  James Robinson  <jamesr@chromium.org>
1850
1851         [chromium] Remove compositor settings that don't go through WebKit
1852         https://bugs.webkit.org/show_bug.cgi?id=112718
1853
1854         Reviewed by Adam Barth.
1855
1856         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1857         (main):
1858         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
1859         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1860         (WebTestRunner::WebPreferences::reset):
1861         (WebTestRunner::WebPreferences::applyTo):
1862         * DumpRenderTree/chromium/TestShell.cpp:
1863         (TestShell::TestShell):
1864         (TestShell::resetWebSettings):
1865         * DumpRenderTree/chromium/TestShell.h:
1866         (TestShell):
1867
1868 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
1869
1870         Unreviewed, rolling out r146101.
1871         https://bugs.webkit.org/show_bug.cgi?id=111884
1872
1873         re-enable custom freetype on asan; this needs to be on
1874         now that the bot is running lucid.
1875
1876         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1877
1878 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
1879
1880         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
1881         https://bugs.webkit.org/show_bug.cgi?id=112365
1882
1883         Reviewed by Benjamin Poulain.
1884
1885         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
1886         harcoding it in wtf/Platform.h
1887
1888         * Scripts/webkitperl/FeatureList.pm:
1889
1890 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1891
1892         [Qt] Make ImageDiff similar to Chromium's ImageDiff
1893         https://bugs.webkit.org/show_bug.cgi?id=94782
1894
1895         Based on patch by Csaba Osztrogonác.
1896         Reviewed by Jocelyn Turcotte.
1897
1898         The diff image is generated with bright red indicating errors, but letting the base image
1899         shine through so the context of the error-pixel can be identified.
1900
1901         * DumpRenderTree/qt/ImageDiff.cpp:
1902         (main):
1903
1904 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
1905
1906         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
1907
1908         Rubber-stamped by Csaba Osztrogonác.
1909
1910         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
1911         since the latter might not cover the former.
1912
1913         * QtTestBrowser/launcherwindow.cpp:
1914         (LauncherWindow::print):
1915
1916 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
1917
1918         Style tweeks to default.css.
1919         
1920         Rubber-stamped by David Kilzer.
1921         
1922         Give visited links a different color to other links, so you can
1923         see which builds you've viewed.
1924         
1925         Make the <small> text less tiny.
1926
1927         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
1928         (small):
1929         (a:link,a:visited,a:active):
1930         (a:visited):
1931
1932 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
1933
1934         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
1935         https://bugs.webkit.org/show_bug.cgi?id=112494
1936
1937         Reviewed by Dirk Pranke.
1938
1939         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
1940         Also merged two pairs of methods to cleanup the code.
1941
1942         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1943         (PerfTestsRunner.run): Merged _upload_and_show_results.
1944         (PerfTestsRunner._generate_results): Merged _generate_output_files.
1945
1946 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
1947
1948         [chromium] build xdisplaycheck when building DRT
1949         https://bugs.webkit.org/show_bug.cgi?id=112636
1950
1951         Reviewed by Tony Chang.
1952
1953         It appears that we need xdisplaycheck to be built in order for
1954         Xvfb to be started correctly on the bots, and DRT was missing
1955         a dependency on it. This may be the cause of the ASAN bot not
1956         starting up properly (it only builds DRT).
1957
1958         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1959
1960 2013-03-18  David Levin  <levin@chromium.org>
1961
1962         Implement icon change notification dump for Chromium's test shell.
1963         https://bugs.webkit.org/show_bug.cgi?id=112614
1964
1965         This was previously implemented for some other platforms in r58111
1966         and r116547.
1967
1968         In r122806, fast/dom/icon-url-property.html stopped using it, but
1969         it is useful for tests, so I plan to re-add it to that test again.
1970
1971         Reviewed by Jochen Eisinger.
1972
1973         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1974         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
1975          icon change notifications from WebKit may be logged in test output.
1976         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1977         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
1978         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
1979         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
1980         (WebTestRunner):
1981         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
1982         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1983         (TestRunner):
1984         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1985         (WebTestRunner::WebTestProxyBase::didChangeIcon):
1986         (WebTestRunner):
1987         * DumpRenderTree/chromium/WebViewHost.cpp:
1988         (WebViewHost::didChangeIcon): Add the output about changing the icon.
1989         * DumpRenderTree/chromium/WebViewHost.h:
1990         (WebViewHost):
1991
1992 2013-03-18  Julie Parent  <jparent@chromium.org>
1993
1994         Cleanup: Move js for treemap and aggregate_results into own js files.
1995         https://bugs.webkit.org/show_bug.cgi?id=112618
1996
1997         Reviewed by Dirk Pranke.
1998         
1999         No functional changes, just moving the code into separate js file
2000         rather than inlined in the html, so we can test it, make it more
2001         modular, etc.  Other dashboard types are already done this way.
2002
2003         * TestResultServer/static-dashboards/aggregate_results.html:
2004         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
2005         (generatePage):
2006         (handleValidHashParameter):
2007         (htmlForBuilder):
2008         (rawValuesHTML):
2009         (chartHTML):
2010         (filteredValues):
2011         (chart):
2012         (htmlForRevisionRows):
2013         (wrapHTMLInTable):
2014         (htmlForSummaryTable):
2015         (valuesPerExpectation):
2016         (htmlForTestType):
2017         (htmlForTableRow):
2018         (extendedEncode):
2019         * TestResultServer/static-dashboards/treemap.html:
2020         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
2021         (humanReadableTime):
2022         (convertToWebTreemapFormat):
2023         (reverseSortByAverage):
2024         (generatePage):
2025         (focusPath):
2026         (.switch.return):
2027         (handleQueryParameterChange):
2028         (extractName):
2029         (fullName):
2030         (handleFocus.):
2031         (handleFocus):
2032
2033 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2034
2035         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
2036         https://bugs.webkit.org/show_bug.cgi?id=112622
2037
2038         Reviewed by Dirk Pranke.
2039
2040         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2041         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
2042
2043 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2044
2045         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
2046         https://bugs.webkit.org/show_bug.cgi?id=112619
2047
2048         Reviewed by Dirk Pranke.
2049
2050         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
2051         directory and then fall back to the generic LayoutTests/platform/gtk directory.
2052
2053         * Scripts/webkitpy/layout_tests/port/gtk.py:
2054         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
2055         Port._webkit_baseline_path method.
2056         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2057         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
2058         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
2059         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2060         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
2061         that are expected based on the builder name.
2062
2063 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
2064
2065         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
2066         https://bugs.webkit.org/show_bug.cgi?id=112571
2067
2068         Reviewed by Adam Barth.
2069
2070         Update function declarations for new WebFileSystemType enum. (All
2071         changes are behind an #ifdef so we can sync required changes in embedders.)
2072
2073         * DumpRenderTree/chromium/WebViewHost.cpp:
2074         (WebViewHost::openFileSystem):
2075         (WebViewHost::deleteFileSystem):
2076         * DumpRenderTree/chromium/WebViewHost.h:
2077         (WebViewHost):
2078
2079 2013-03-18  Julie Parent  <jparent@chromium.org>
2080
2081         Cleanup: Move timeline_exporer js out of html file into js.
2082         https://bugs.webkit.org/show_bug.cgi?id=112188
2083
2084         Reviewed by Dirk Pranke.
2085         
2086         Moves the javascript out of the html file and into a new js file.
2087         This follows the format of flakiness_dashboard.{html|js}.
2088         
2089         Also moves code from dashboard_base that is used only by this one
2090         dashboard, and makes it private to the dashboard.
2091
2092         * TestResultServer/static-dashboards/dashboard_base.js:
2093         * TestResultServer/static-dashboards/timeline_explorer.html:
2094         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
2095         (generatePage):
2096         (initCurrentBuilderTestResults):
2097         (shouldShowWebKitRevisionsOnly):
2098         (updateTimelineForBuilder.):
2099         (updateTimelineForBuilder):
2100         (selectBuild):
2101         (updateBuildIndicator):
2102         (.addRow):
2103         (.addNumberRow):
2104         (.inspectorNode.getElementsByTagName.0.onclick):
2105         (.inspectorNode.getElementsByTagName.1.onclick):
2106         (.inspectorNode.getElementsByTagName.2.onclick):
2107         (updateBuildInspector):
2108         (showResultsDelta):
2109         (decompressResults.addFlakyDelta):
2110         (decompressResults):
2111
2112 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
2113
2114         Unreviewed, rolling out r145272.
2115         http://trac.webkit.org/changeset/145272
2116         https://bugs.webkit.org/show_bug.cgi?id=111884
2117
2118         Turns out the ASAN build is still broken; possibly there's
2119         something still setting LD_LIBRARY_PATH, or possibly there's
2120         something else wrong. In the meantime, we need it to work again.
2121
2122         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2123
2124 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
2125
2126         delete-stale-build-files is too aggressive
2127         https://bugs.webkit.org/show_bug.cgi?id=112595
2128
2129         Reviewed by Tim Horton.
2130
2131         It appears that whitelisting file extensions to keep is not a good idea.
2132         Blacklist files to delete instead, and only delete .o files for now.
2133         We can add more file extensions as needed.
2134
2135         * BuildSlaveSupport/delete-stale-build-files:
2136
2137 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
2138
2139         Disable accessibility notifications after each test
2140         https://bugs.webkit.org/show_bug.cgi?id=112579
2141
2142         Reviewed by Tim Horton.
2143         
2144         In WebKitTestRunner, if any tests triggered accessibility notifications,
2145         the global notification handler would thereafter be active, and fire
2146         notifications for all subsequent tests.
2147         
2148         Fix by implementing AccessibilityController::resetToConsistentState() for
2149         Mac, and using it to clear the global notification handler.
2150
2151         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2152         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2153         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
2154         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
2155         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
2156         (e.g. because of -autorelease).
2157         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
2158         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
2159         if there is one.
2160         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
2161         Add -stopObserving
2162         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2163         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
2164         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
2165         center.
2166
2167 2013-03-18  Dana Jansens  <danakj@chromium.org>
2168
2169         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
2170         https://bugs.webkit.org/show_bug.cgi?id=112392
2171
2172         Reviewed by James Robinson.
2173
2174         Removes the command line flag option from DRT.
2175
2176         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2177         (main):
2178
2179 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
2180
2181         [GTK] plugins/plugin-clip-subframe.html is failing
2182         https://bugs.webkit.org/show_bug.cgi?id=112570
2183
2184         Reviewed by Martin Robinson.
2185
2186         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
2187
2188 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
2189
2190         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
2191         https://bugs.webkit.org/show_bug.cgi?id=112442
2192
2193         Reviewed by Gustavo Noronha Silva.
2194
2195         * GtkLauncher/main.c:
2196         (reloadCb):
2197         (createToolbar):
2198         (createWindow):
2199
2200 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2201
2202         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
2203         https://bugs.webkit.org/show_bug.cgi?id=112205
2204
2205         Disable this API test until Geoff can fix it.
2206
2207         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2208         (TestWebKitAPI::TEST):
2209
2210 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
2211
2212         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
2213         https://bugs.webkit.org/show_bug.cgi?id=112478
2214
2215         Reviewed by Tony Chang.
2216
2217         There is nothing that ensures that the log messages from the plugin
2218         come in before the layout test finished loading.
2219
2220         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2221         (PassDifferentNPPStruct::NPP_SetWindow):
2222         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2223         (NPP_SetWindow):
2224
2225 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2226
2227         Have the mac port support per_test_timeout in webkitpy
2228         https://bugs.webkit.org/show_bug.cgi?id=112466
2229
2230         Reviewed by Dirk Pranke.
2231         
2232         Both WTR and DRT handle --timeout arguments, so we can
2233         have the scripts pass the timeout values down to the tools.
2234
2235         * Scripts/webkitpy/layout_tests/port/mac.py:
2236         (MacPort.supports_per_test_timeout):
2237
2238 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
2239
2240         Remove setAsynchronousSpellCheckingEnabled from test runners
2241         https://bugs.webkit.org/show_bug.cgi?id=112362
2242
2243         Reviewed by Tony Chang.
2244
2245         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
2246         in internals.settings, so all ports can share it.
2247
2248         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2249         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2250         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2251         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2252         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
2253         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2254         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2255         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
2256         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2257         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
2258         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2259         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
2260
2261 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
2262
2263         Fix the stupid unit tests.
2264
2265         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2266         (test_sample_process):
2267
2268 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
2269
2270         Collect samples for unresponsive web processes
2271         https://bugs.webkit.org/show_bug.cgi?id=112409
2272
2273         Reviewed by Tim Horton.
2274         
2275         When we detect that a subprocess was unresponsive, run the 'sample'
2276         tool on that process, for the Mac port.
2277         
2278         The sample will be linked to from the results.html page, next
2279         to the crash log link.
2280
2281         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2282         (Manager._look_for_new_crash_logs): Before looking for crash logs,
2283         look for samples on disk.
2284         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2285         (TestResultWriter):
2286         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
2287         -sample.txt files, and have it copy their contents to a new file
2288         next to the test that spawned them (as we do for crash logs).
2289         * Scripts/webkitpy/layout_tests/port/base.py:
2290         (Port.look_for_new_samples): Base class does nothing for sampling.
2291         * Scripts/webkitpy/layout_tests/port/driver.py:
2292         (Driver._check_for_driver_crash): Kick off a sample if we detected
2293         that the subprocess was unresponsive.
2294         * Scripts/webkitpy/layout_tests/port/mac.py:
2295         (MacPort.sample_file_path): Utility to generate the file path
2296         to the generated sample files at the top level of layout-test-results.
2297         (MacPort.look_for_new_crash_logs): Fix typo
2298         (MacPort.look_for_new_samples): New function to find sample files.
2299         (MacPort.sample_process): Use the utility function to get the file path.
2300
2301 2013-03-15  Zeno Albisser  <zeno@webkit.org>
2302
2303         [Qt] Remove simple getters and setters from TestRunnerQt
2304         https://bugs.webkit.org/show_bug.cgi?id=112343
2305
2306         Reviewed by Benjamin Poulain.
2307
2308         The removed functions and boolean members
2309         are being replaced by the implementations in the
2310         generic TestRunner.h.
2311
2312         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2313         (DumpRenderTree::dumpFrameScrollPosition):
2314         (DumpRenderTree::dumpFramesAsText):
2315         (DumpRenderTree::dump):
2316         (DumpRenderTree::titleChanged):
2317         (DumpRenderTree::dumpDatabaseQuota):
2318         (DumpRenderTree::dumpApplicationCacheQuota):
2319         (DumpRenderTree::statusBarMessage):
2320         (DumpRenderTree::createWindow):
2321         * DumpRenderTree/qt/TestRunnerQt.cpp:
2322         (TestRunnerQt::reset):
2323         * DumpRenderTree/qt/TestRunnerQt.h:
2324         (TestRunnerQt):
2325
2326 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
2327
2328         Update the link on build.webkit.org to refer to perf.webkit.org
2329         https://bugs.webkit.org/show_bug.cgi?id=112416
2330
2331         Reviewed by Philip Rogers.
2332
2333         Updated the link. Also updated the template to use HTML5 DOCTYPE.
2334
2335         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2336
2337 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
2338
2339         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
2340         https://bugs.webkit.org/show_bug.cgi?id=112394
2341
2342         Reviewed by Philippe Normand.
2343
2344         * GtkLauncher/main.c:
2345         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
2346
2347 2013-03-14  Andreas Kling  <akling@apple.com>
2348
2349         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
2350         <http://webkit.org/b/111815>
2351         <rdar://problem/13380145>
2352
2353         Reviewed by Anders Carlsson.
2354
2355         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
2356         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
2357         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
2358
2359         * WebKitTestRunner/PlatformWebView.h:
2360         (PlatformWebView):
2361         * WebKitTestRunner/TestController.cpp:
2362         (WTR::TestController::createOtherPage):
2363         (WTR::TestController::createWebViewWithOptions):
2364         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2365         (WTR::PlatformWebView::didInitializeClients):
2366
2367 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2368
2369         [EFL][MiniBrowser] Add a search field to the MiniBrowser
2370         https://bugs.webkit.org/show_bug.cgi?id=112122
2371
2372         Reviewed by Kenneth Rohde Christiansen.
2373
2374         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
2375
2376         * MiniBrowser/efl/main.c:
2377         (_Browser_Window):
2378         (search_box_show):
2379         (search_box_hide):
2380         (on_key_down):
2381         (on_url_changed):
2382         (on_search_field_aborted):
2383         (on_search_field_activated):
2384         (on_search_field_clicked):
2385         (on_search_backward_button_clicked):
2386         (on_search_forward_button_clicked):
2387         (window_create):
2388
2389 2013-03-14  Julie Parent  <jparent@chromium.org>
2390
2391         Cleanup: Remove g_resourceLoader.
2392         https://bugs.webkit.org/show_bug.cgi?id=112305
2393
2394         Reviewed by Dirk Pranke.
2395         
2396         Removing another global.
2397         
2398         Now, each dashboard creates its own loader, rather than having
2399         a general global one.
2400         
2401         Remove usage of g_resourceLoader.isLoadingComplete from 
2402         handleLocationChange by ensuring that handleLocationChange is
2403         never called before the loader is done.  It was called in two
2404         places before: 1 was from the callback when the loader is done,
2405         so that was obviously true, and the other was from onhashchange,
2406         where it would just return rather than running.  Instead, lets
2407         only register the onhashchange handler once the loader is
2408         setup, so the check is no longer necessary.
2409         
2410         Remove isLoadingComplete since it is now unused.
2411         
2412         Callback for loader is now initializeHistory, rather than just
2413         handleLocationChange which will set up the hashchange handler now.
2414         This will all eventually be moving to a new History object.
2415
2416         * TestResultServer/static-dashboards/aggregate_results.html:
2417         * TestResultServer/static-dashboards/dashboard_base.js:
2418         (handleLocationChange):
2419         (intializeHistory):
2420         (decompressResults):
2421         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2422         (generatePage):
2423         * TestResultServer/static-dashboards/loader.js:
2424         (.):
2425         * TestResultServer/static-dashboards/loader_unittests.js:
2426         * TestResultServer/static-dashboards/timeline_explorer.html:
2427         * TestResultServer/static-dashboards/treemap.html:
2428
2429 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
2430
2431         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
2432         https://bugs.webkit.org/show_bug.cgi?id=109404
2433
2434         Reviewed by Tony Chang.
2435
2436         Removes all the code related to smartInsertDeleteEnabled and
2437         selectTrailingWhitespaceEnabled settings as they will be managed from
2438         internals from now on.
2439
2440         * DumpRenderTree/TestRunner.cpp:
2441         (TestRunner::staticFunctions):
2442         * DumpRenderTree/TestRunner.h:
2443         (TestRunner):
2444         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2445         (WebKit):
2446         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2447         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2448         (DumpRenderTree):
2449         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2450         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2451         (WebTestRunner::WebTestProxy::didStopLoading):
2452         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2453         (WebTestRunner::TestRunner::TestRunner):
2454         (WebTestRunner::TestRunner::reset):
2455         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2456         (TestRunner):
2457         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2458         (WebTestRunner::WebPreferences::applyTo): Set default values for
2459         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
2460         Chromium DRT default values are different from Chromium browser.
2461         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2462         * DumpRenderTree/chromium/WebViewHost.cpp:
2463         * DumpRenderTree/chromium/WebViewHost.h:
2464         (WebViewHost):
2465         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2466         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2467         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2468         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2469         (resetDefaultsToConsistentValues):
2470         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2471         * DumpRenderTree/mac/DumpRenderTree.mm:
2472         (resetWebViewToConsistentStateBeforeTesting):
2473         * DumpRenderTree/mac/TestRunnerMac.mm:
2474         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2475         (WebCore::WebPage::resetSettings):
2476         * DumpRenderTree/qt/TestRunnerQt.cpp:
2477         * DumpRenderTree/qt/TestRunnerQt.h:
2478         (TestRunnerQt):
2479         * DumpRenderTree/win/DumpRenderTree.cpp:
2480         (resetWebViewToConsistentStateBeforeTesting):
2481         * DumpRenderTree/win/TestRunnerWin.cpp:
2482         * DumpRenderTree/wx/TestRunnerWx.cpp:
2483
2484 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
2485
2486         [Qt] Disable DRT on Windows
2487
2488         Reviewed by Jocelyn Turcotte.
2489
2490         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
2491
2492         * qmake/mkspecs/features/configure.prf:
2493
2494 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2495
2496         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
2497         https://bugs.webkit.org/show_bug.cgi?id=110728
2498
2499         Reviewed by Gyuyoung Kim.
2500
2501         Use the page group to create the view object.
2502
2503         * MiniBrowser/efl/main.c:
2504         (window_create):
2505
2506 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
2507
2508         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
2509
2510         Reviewed by Tor Arne Vestbø.
2511
2512         The mock versions of these web facing features should be instantiated when
2513         running in DumpRenderTree only. In order for them to work, no extra Qt modules
2514         such as QtLocation are actually needed.
2515
2516         This patch decouples enabling device orientation/motion and geolocation from
2517         the underlying Qt modules and makes them available in developer builds
2518         (!production_build) and backed by mock backends when running in drt.
2519
2520         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
2521         developers the web facing features are always enabled (although requests will
2522         time out) and the mock backends are enabled inside DRT, allowing for the layout
2523         tests to run with less dependencies.
2524
2525         In addition this also enables the mock device motion client, which was
2526         previously never instantiated.
2527
2528         * qmake/mkspecs/features/features.prf:
2529
2530 2013-03-14  Zeno Albisser  <zeno@webkit.org>
2531
2532         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
2533         https://bugs.webkit.org/show_bug.cgi?id=112340
2534
2535         Reviewed by Simon Hausmann.
2536
2537         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2538         (DumpRenderTree::dump):
2539             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
2540         (DumpRenderTree::dumpApplicationCacheQuota):
2541         * DumpRenderTree/qt/TestRunnerQt.cpp:
2542         (TestRunnerQt::reset):
2543         * DumpRenderTree/qt/TestRunnerQt.h:
2544         (TestRunnerQt):
2545
2546 2013-03-14  Zeno Albisser  <zeno@webkit.org>
2547
2548         [Qt] Port DRT to use TestRunner::dumpAsText()
2549         https://bugs.webkit.org/show_bug.cgi?id=112260
2550
2551         Reviewed by Benjamin Poulain.
2552
2553         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2554         (WebCore::DumpRenderTree::open):
2555         (WebCore::methodNameStringForFailedTest):
2556             Change parameter from type TestRunnerQt* to TestRunner*.
2557         (WebCore::DumpRenderTree::dump):
2558             TestRunnerQt::shouldDumpPixels() always returned true in our case.
2559             Instead we should rely on TestRunner::generatePixelResults().
2560         * DumpRenderTree/qt/TestRunnerQt.cpp:
2561         (TestRunnerQt::reset):
2562         * DumpRenderTree/qt/TestRunnerQt.h:
2563         (TestRunnerQt):
2564
2565 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
2566
2567         Implement FontLoader interface
2568         https://bugs.webkit.org/show_bug.cgi?id=98395
2569
2570         Reviewed by Eric Seidel.
2571
2572         Enable FontLoadEvents runtime flag for TestShell.
2573
2574         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2575         (WebTestRunner::TestInterfaces::TestInterfaces):
2576
2577 2013-03-13  Julie Parent  <jparent@chromium.org>
2578
2579         CLeanup: remove unnecessary call to parseParameters.
2580         https://bugs.webkit.org/show_bug.cgi?id=112309
2581
2582         Reviewed by Ojan Vafai.
2583         
2584         We call parseCrossDashboardParameters when the dashboard initially
2585         loads to set the state required for loadBuildersList, and then we
2586         call it again once we are fully done with loading, so there is no
2587         reason to call it in the middle of the loading process here.
2588
2589         * TestResultServer/static-dashboards/loader.js:
2590         (.):
2591
2592 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
2593
2594         Unreviewed. Now I'm a reviewer :)
2595
2596         * Scripts/webkitpy/common/config/committers.py:
2597
2598 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
2599
2600         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
2601         https://bugs.webkit.org/show_bug.cgi?id=112277
2602
2603         Reviewed by Adam Barth.
2604
2605         * Scripts/webkitperl/FeatureList.pm:
2606         * qmake/mkspecs/features/features.pri:
2607
2608 2013-03-13  Adam Barth  <abarth@webkit.org>
2609
2610         run-perf-tests should support content_shell
2611         https://bugs.webkit.org/show_bug.cgi?id=112291
2612
2613         Reviewed by Eric Seidel.
2614
2615         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2616         (PerfTestsRunner._parse_args):
2617
2618 2013-03-13  Oliver Hunt  <oliver@apple.com>
2619
2620         Simplify Checked<> multiplication
2621         https://bugs.webkit.org/show_bug.cgi?id=112286
2622
2623         Reviewed by James Robinson.
2624
2625         Add tests for multiplication by zero and max to ensure we don't
2626         mess them up should we ever make changes to Checked<> in future.
2627
2628         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2629         (TestWebKitAPI):
2630
2631 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2632
2633         [Qt] Unreviewed prospective Windows build fix
2634
2635         Do the usual thing, include the moc generated code in the .cpp file instead
2636         of compiling it standalone, to ensure that config.h is included, too, and
2637         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
2638
2639         * DumpRenderTree/qt/EventSenderQt.cpp:
2640
2641 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2642
2643         [Qt] Port TestRunner::findString to shared interface
2644         https://bugs.webkit.org/show_bug.cgi?id=112147
2645
2646         Reviewed by Jocelyn Turcotte.
2647
2648         This patch also removes DumpRenderTree and some other helper classes from
2649         the WebCore namespace, to which they do not really belong.
2650
2651         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2652         (main):
2653         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2654         (DumpRenderTree::DumpRenderTree):
2655         (DumpRenderTree::~DumpRenderTree):
2656         (DumpRenderTree::instance):
2657         (DumpRenderTree::setShouldTimeout):
2658         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2659         (DumpRenderTree):
2660         * DumpRenderTree/qt/EventSenderQt.cpp:
2661         (EventSender::contextClick):
2662         (EventSender::sendEvent):
2663         (EventSender::postEvent):
2664         * DumpRenderTree/qt/EventSenderQt.h:
2665         (EventSender::isGraphicsBased):
2666         * DumpRenderTree/qt/TestRunnerQt.cpp:
2667         (TestRunnerQt::TestRunnerQt):
2668         (TestRunner::findString):
2669         (TestRunnerQt::setMockDeviceOrientation):
2670         (TestRunnerQt::setGeolocationPermission):
2671         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
2672         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
2673         (TestRunnerQt::setMockGeolocationPosition):
2674         * DumpRenderTree/qt/TestRunnerQt.h:
2675         (TestRunnerQt):
2676
2677 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
2678
2679         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
2680         https://bugs.webkit.org/show_bug.cgi?id=112129
2681
2682         Reviewed by Adam Barth.
2683
2684         Following Chromium
2685         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
2686         this is being renamed to better explain what it does.
2687
2688         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2689
2690 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
2691
2692         [Qt] Unreviewed trivial typo fix
2693
2694         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
2695         TextRunner.h. Thanks Zeno :)
2696
2697 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
2698
2699         [Qt] Prepare DRT for transition to shared TestRunner interface
2700         https://bugs.webkit.org/show_bug.cgi?id=112144
2701
2702         Reviewed by Benjamin Poulain.
2703
2704         Prepare Qt's DRT for a transition from the QObject based TestRunner to
2705         the JSC C API based one.
2706
2707         This is impplemented by instantiating the QObject based testRunner in
2708         the global object, then instantiating the JSC C based TestRunner
2709         separately and placing it "behind" the QObject based testRunner through
2710         injection of the individual functions through proxies. (prototype
2711         chaining doesn't work due to the this object and Function.prototype.bind
2712         doesn't work due to the native function)
2713
2714         This allows for porting over method by method by removing the method
2715         from the QObject TestRunnerQt and implementing it in the JSC C based
2716         TestRunner.
2717
2718         In order for this to link and run dummy implementations of all the
2719         necessary TestRunner functions are provided.
2720
2721         * DumpRenderTree/qt/DumpRenderTree.pro:
2722         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2723         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2724         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2725         (WebCore::DumpRenderTree::initJSObjects):
2726         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2727         (DumpRenderTree):
2728         * DumpRenderTree/qt/TestRunnerQt.cpp:
2729         (TestRunner::~TestRunner):
2730         (TestRunner::addDisallowedURL):
2731         (TestRunner::queueLoad):
2732         (TestRunner::removeAllVisitedLinks):
2733         (TestRunner::setAcceptsEditing):
2734         (TestRunner::simulateLegacyWebNotificationClick):
2735         (TestRunner::setWindowIsKey):
2736         (TestRunner::setAlwaysAcceptCookies):
2737         (TestRunner::addOriginAccessWhitelistEntry):
2738         (TestRunner::setWebViewEditable):
2739         (TestRunner::clearAllApplicationCaches):
2740         (TestRunner::setTextDirection):
2741         (TestRunner::notifyDone):
2742         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2743         (TestRunner::overridePreference):
2744         (TestRunner::pathToLocalResource):
2745         (TestRunner::removeAllWebNotificationPermissions):
2746         (TestRunner::simulateWebNotificationClick):
2747         (TestRunner::closeIdleLocalStorageDatabases):
2748         (TestRunner::focusWebView):
2749         (TestRunner::setBackingScaleFactor):
2750         (TestRunner::removeChromeInputField):
2751         (TestRunner::addChromeInputField):
2752         (TestRunner::originsWithLocalStorage):
2753         (TestRunner::deleteAllLocalStorage):
2754         (TestRunner::deleteLocalStorageForOrigin):
2755         (TestRunner::observeStorageTrackerNotifications):
2756         (TestRunner::syncLocalStorage):
2757         (TestRunner::windowCount):
2758         (TestRunner::setWaitToDump):
2759         (TestRunner::waitForPolicyDelegate):
2760         (TestRunner::webHistoryItemCount):
2761         (TestRunner::showWebInspector):
2762         (TestRunner::closeWebInspector):
2763         (TestRunner::evaluateInWebInspector):
2764         (TestRunner::setSerializeHTTPLoads):
2765         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2766         (TestRunner::setCustomPolicyDelegate):
2767         (TestRunner::setDatabaseQuota):
2768         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2769         (TestRunner::resetPageVisibility):
2770         (TestRunner::keepWebHistory):
2771         (TestRunner::goBack):
2772         (TestRunner::originsWithApplicationCache):
2773         (TestRunner::applicationCacheDiskUsageForOrigin):
2774         (TestRunner::display):
2775         (TestRunner::dispatchPendingLoadRequests):
2776         (TestRunner::clearPersistentUserStyleSheet):
2777         (TestRunner::callShouldCloseOnWebView):
2778         (TestRunner::copyDecodedHostName):
2779         (TestRunner::clearBackForwardList):
2780         (TestRunner::clearAllDatabases):
2781         (TestRunner::clearApplicationCacheForOrigin):
2782         (TestRunner::apiTestGoToCurrentBackForwardItem):
2783         (TestRunner::authenticateSession):
2784         (TestRunner::abortModal):
2785         (TestRunner::setStorageDatabaseIdleInterval):
2786         (TestRunner::setAsynchronousSpellCheckingEnabled):
2787         (TestRunner::setXSSAuditorEnabled):
2788         (TestRunner::setSpatialNavigationEnabled):
2789         (TestRunner::setScrollbarPolicy):
2790         (TestRunner::setJavaScriptCanAccessClipboard):
2791         (TestRunner::setAutomaticLinkDetectionEnabled):
2792         (TestRunner::setUserStyleSheetEnabled):
2793         (TestRunner::setUserStyleSheetLocation):
2794         (TestRunner::setUseDashboardCompatibilityMode):
2795         (TestRunner::setTabKeyCyclesThroughElements):
2796         (TestRunner::setSmartInsertDeleteEnabled):
2797         (TestRunner::setSelectTrailingWhitespaceEnabled):
2798         (TestRunner::setPrivateBrowsingEnabled):
2799         (TestRunner::setPluginsEnabled):
2800         (TestRunner::setPopupBlockingEnabled):
2801         (TestRunner::setMockSpeechInputDumpRect):
2802         (TestRunner::setPersistentUserStyleSheetLocation):
2803         (TestRunner::setMockGeolocationPosition):
2804         (TestRunner::setMockGeolocationPositionUnavailableError):
2805         (TestRunner::setMockDeviceOrientation):
2806         (TestRunner::setMainFrameIsFirstResponder):
2807         (TestRunner::setIconDatabaseEnabled):
2808         (TestRunner::setGeolocationPermission):
2809         (TestRunner::setDefersLoading):
2810         (TestRunner::setCacheModel):
2811         (TestRunner::setAuthorAndUserStylesEnabled):
2812         (TestRunner::setAllowFileAccessFromFileURLs):
2813         (TestRunner::setAppCacheMaximumSize):
2814         (TestRunner::setAllowUniversalAccessFromFileURLs):
2815         (TestRunner::setApplicationCacheOriginQuota):
2816         (TestRunner::denyWebNotificationPermission):
2817         (TestRunner::grantWebNotificationPermission):
2818         (TestRunner::setValueForUser):
2819         (TestRunner::setViewModeMediaFeature):
2820         (TestRunner::setPageVisibility):
2821         (TestRunner::addMockSpeechInputResult):
2822         (TestRunner::removeOriginAccessWhitelistEntry):
2823         (TestRunner::addUserScript):
2824         (TestRunner::isCommandEnabled):
2825         (TestRunner::evaluateScriptInIsolatedWorld):
2826         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
2827         (TestRunner::copyEncodedHostName):
2828         (TestRunner::addUserStyleSheet):
2829         (TestRunner::findString):
2830         (TestRunner::execCommand):
2831         (TestRunner::localStorageDiskUsageForOrigin):
2832
2833 2013-03-12  Julie Parent  <jparent@chromium.org>
2834
2835         Cleanup: Move flatten-trie to loader.
2836         https://bugs.webkit.org/show_bug.cgi?id=112196
2837
2838         Reviewed by Dirk Pranke.
2839
2840         flatten-trie is used only by the loader, so move it there and make it
2841         private, rather than global in dashbaord_base. Moved the corresponding
2842         unit test from flakiness_dashboard_unittests to loader_unittests.
2843         
2844         * TestResultServer/static-dashboards/dashboard_base.js:
2845         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2846         * TestResultServer/static-dashboards/loader.js:
2847         (.):
2848         * TestResultServer/static-dashboards/loader_unittests.js:
2849
2850 2013-03-12  Oliver Hunt  <oliver@apple.com>
2851
2852         Unbreak api tests
2853
2854         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2855         (TestWebKitAPI):
2856
2857 2013-03-12  Tim Horton  <timothy_horton@apple.com>
2858
2859         Unreviewed, disabling tests for Win EWS.
2860
2861         win-ews obviously cannot keep up with running tests, it's >300 behind.
2862         Probably doesn't help that its (likely) running tests serially.
2863
2864         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2865         (WinEWS):
2866
2867 2013-03-12  Tim Horton  <timothy_horton@apple.com>
2868
2869         Add a --build-directory argument to delete-stale-build-files
2870         https://bugs.webkit.org/show_bug.cgi?id=112198
2871
2872         Reviewed by Ryosuke Niwa.
2873
2874         * BuildSlaveSupport/delete-stale-build-files:
2875         (main): Add --build-directory argument.
2876
2877 2013-03-12  Oliver Hunt  <oliver@apple.com>
2878
2879         Appease MSVC
2880
2881         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2882         (TestWebKitAPI):
2883
2884 2013-03-12  Oliver Hunt  <oliver@apple.com>
2885
2886         Add more Checked<> tests
2887         https://bugs.webkit.org/show_bug.cgi?id=112190
2888
2889         Reviewed by Geoffrey Garen.
2890
2891         Tests!
2892
2893         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2894         (TestWebKitAPI):
2895
2896 2013-03-12  Julie Parent  <jparent@chromium.org>
2897
2898         Cleanup: Move loading complete function into callback, rather than global.
2899         https://bugs.webkit.org/show_bug.cgi?id=112167
2900
2901         Reviewed by Dirk Pranke.
2902         
2903         Stop calling global functions, pass in proper handler to Loader
2904         constructor. Note that the callback is optional, as tests, and
2905         some potential dashboards, do not need one.
2906
2907         * TestResultServer/static-dashboards/dashboard_base.js:
2908         * TestResultServer/static-dashboards/loader.js:
2909         (.):
2910         * TestResultServer/static-dashboards/loader_unittests.js:
2911
2912 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2913
2914         [EFL][WK2] Add popup menu support to MiniBrowser
2915         https://bugs.webkit.org/show_bug.cgi?id=108934
2916
2917         Reviewed by Kenneth Rohde Christiansen.
2918
2919         Implement popup menu support in MiniBrowser by handling popup_menu_show
2920         and popup_menu_hide smart functions on the view and using the Ewk popup
2921         menu API.
2922
2923         * MiniBrowser/efl/main.c:
2924         (_Browser_Window):
2925         (on_popup_menu_discarded):
2926         (on_popup_menu_item_clicked):
2927         (popup_menu_populate):
2928         (on_popup_menu_show):
2929         (on_popup_menu_hide):
2930         (window_create): Use calloc() instead of malloc() to allocate memory for
2931         Browser_Window. This makes sure all the structs members are initialized
2932         to 0 (such as the new elm_popup_menu pointer).
2933
2934 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
2935
2936         [GTK] Set up the libPlatformGtk.la library
2937         https://bugs.webkit.org/show_bug.cgi?id=111738
2938
2939         Reviewed by Martin Robinson.
2940
2941         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
2942         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
2943         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
2944
2945 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
2946
2947         [GTK] Enable Web Audio in development builds
2948         https://bugs.webkit.org/show_bug.cgi?id=111831
2949
2950         Reviewed by Philippe Normand.
2951
2952         Web Audio is already quite well supported on the GTK port but still has a few issues
2953         that must be addressed before it is enabled by default. Despite that it should be enabled
2954         in development builds just so we are up-to-date with future feature infrastructure changes.
2955         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
2956         that's an obvious goal before enabling the feature in release builds.
2957
2958         * Scripts/webkitperl/FeatureList.pm:
2959
2960 2013-03-11  Andreas Kling  <akling@apple.com>
2961
2962         [Mac][WK1] Add support for alert() in MiniBrowser.
2963         <http://webkit.org/b/112090>
2964
2965         Reviewed by Anders Carlsson.
2966
2967         * MiniBrowser/mac/WK1BrowserWindowController.m:
2968         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2969
2970 2013-03-11  Julie Parent  <jparent@chromium.org>
2971
2972         Dashboard cleanup: Create ui.Errors
2973         https://bugs.webkit.org/show_bug.cgi?id=111785
2974
2975         Reviewed by Ojan Vafai.
2976         
2977         Create ui.Errors for handling errors the dashboards
2978         encounter. Loader now has a Error object that it can add to,
2979         and individual dashboards can show errors when desired.
2980         Currently, only flakiness_db shows errors, but this is 
2981         generic and there is no reason why other dbs wouldn't want to
2982         show errors.
2983
2984         * TestResultServer/static-dashboards/dashboard_base.js:
2985         (resourceLoadingComplete):
2986         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2987         (generatePage):
2988         * TestResultServer/static-dashboards/loader.js:
2989         (.):
2990         * TestResultServer/static-dashboards/ui.js:
2991         (.):
2992
2993 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
2994
2995         Some StringHasher tests are broken because of missing null termination
2996         https://bugs.webkit.org/show_bug.cgi?id=111284
2997
2998         Reviewed by Darin Adler.
2999
3000         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
3001         (TestWebKitAPI): Added null termination since C strings are null-terminated.
3002         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
3003         the bug caught by it is now fixed.
3004
3005 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3006
3007         Unreviewed, rolling out r145200.
3008         http://trac.webkit.org/changeset/145200
3009         https://bugs.webkit.org/show_bug.cgi?id=112063
3010
3011         Broke a couple of unit tests (Requested by zdobersek on
3012         #webkit).
3013
3014         * Scripts/webkitperl/FeatureList.pm:
3015
3016 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
3017
3018         [GTK] WebKit2-only build fails
3019         https://bugs.webkit.org/show_bug.cgi?id=112033
3020
3021         Reviewed by Gustavo Noronha Silva.
3022
3023         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
3024         generic part, WebKit1-specific part and WebKit2-specific part.
3025         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
3026         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
3027         directly.
3028
3029 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
3030
3031         Adding myself to the committers list.
3032
3033         Unreviewed.
3034
3035         * Scripts/webkitpy/common/config/committers.py:
3036
3037 2013-03-11  Jeff Rogers  <jrogers@rim.com>
3038
3039         [BlackBerry] Disable MathML support
3040         https://bugs.webkit.org/show_bug.cgi?id=111929
3041
3042         Reviewed by Rob Buis.
3043
3044         * Scripts/webkitperl/FeatureList.pm:
3045
3046 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3047
3048         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
3049         https://bugs.webkit.org/show_bug.cgi?id=111970
3050
3051         Reviewed by Chris Fleizach.
3052
3053         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
3054         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
3055         undefined symbol.
3056
3057         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3058         (WTR::AccessibilityUIElement::supportedActions):
3059         (WTR):
3060
3061 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
3062
3063         [chromium] Android apk targets should depend directly on Java library targets
3064         https://bugs.webkit.org/show_bug.cgi?id=111746
3065
3066         Reviewed by Eric Seidel.
3067
3068         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3069         Make DumpRenderTree_apk depend directly on base_java and net_java.
3070         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3071         Make TestWebKitAPI_apk depend directly on base_java.
3072
3073 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
3074
3075         [chromium] remove obsolete user gesture methods from WebFrame
3076         https://bugs.webkit.org/show_bug.cgi?id=111696
3077
3078         Reviewed by Adam Barth.
3079
3080         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3081         (WebTestRunner::TestPlugin::handleInputEvent):
3082         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3083
3084 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
3085
3086         Unreviewed, add myself to commiters.py.
3087
3088         * Scripts/webkitpy/common/config/committers.py:
3089
3090 2013-03-08  Julie Parent  <jparent@chromium.org>
3091
3092         Cleanup: Remove dead code.
3093         https://bugs.webkit.org/show_bug.cgi?id=111900
3094
3095         Reviewed by Dirk Pranke.
3096         
3097         Treemap overrides a global function that used to be in 
3098         dashboard_base, but was removed months ago in
3099         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
3100         no caller. 
3101
3102         * TestResultServer/static-dashboards/treemap.html:
3103
3104 2013-03-08  Harald Alvestrand  <hta@chromium.org>
3105
3106         Implemented new API for RTCStatsReport object.
3107         https://bugs.webkit.org/show_bug.cgi?id=110333
3108
3109         Reviewed by Adam Barth.
3110
3111         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
3112         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
3113
3114 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
3115
3116         [chromium] use custom freetype on linux asan builds again
3117         https://bugs.webkit.org/show_bug.cgi?id=111884
3118
3119         Reviewed by Tony Chang.
3120
3121         We no longer need the workaround after chromium r186540.
3122
3123         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3124
3125 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
3126
3127         Warning about the user not having edit rights on Bugzilla is confusing new contributors
3128         https://bugs.webkit.org/show_bug.cgi?id=111798
3129
3130         Reviewed by Dirk Pranke.
3131
3132         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
3133
3134         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3135
3136 2013-03-08  James Robinson  <jamesr@chromium.org>
3137
3138         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
3139         https://bugs.webkit.org/show_bug.cgi?id=111632
3140
3141         Reviewed by Adrienne Walker.
3142
3143         * DumpRenderTree/chromium/WebViewHost.cpp:
3144         (WebViewHost::initializeLayerTreeView):
3145         * DumpRenderTree/chromium/WebViewHost.h:
3146         (WebViewHost):
3147
3148 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
3149
3150         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
3151         https://bugs.webkit.org/show_bug.cgi?id=111297
3152
3153         Reviewed by Kenneth Rohde Christiansen.
3154
3155         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3156         (WTR::TestRunner::setViewModeMediaFeature):
3157
3158 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
3159
3160         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
3161         https://bugs.webkit.org/show_bug.cgi?id=111814
3162
3163         Reviewed by Ryosuke Niwa.
3164
3165         Add the needed supportedActions() attribute to WKTestRunner.
3166
3167         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3168         (WTR::AccessibilityUIElement::supportedActions):
3169         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3170         (AccessibilityUIElement):
3171         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3172         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3173         (WTR::AccessibilityUIElement::supportedActions):
3174
3175 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3176
3177         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
3178         https://bugs.webkit.org/show_bug.cgi?id=111851
3179
3180         Reviewed by Kenneth Rohde Christiansen.
3181
3182         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3183         (TestWebKitAPI::TEST):
3184
3185             Fixed WKURLRef instance leaking.
3186
3187 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3188
3189         [EFL] [WK2] Some authentication tests fail in WebKit2
3190         https://bugs.webkit.org/show_bug.cgi?id=106407
3191
3192         Reviewed by Kenneth Rohde Christiansen.
3193
3194         Add patch from upstream for libsoup 2.40 to fix several authentication
3195         test cases.
3196
3197         * efl/jhbuild.modules:
3198         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
3199
3200 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
3201
3202         [GTK] Enable Web Audio in development builds
3203         https://bugs.webkit.org/show_bug.cgi?id=111831
3204
3205         Reviewed by Philippe Normand.
3206
3207         Web Audio is already quite well supported on the GTK port but still has a few issues
3208         that must be addressed before it is enabled by default. Despite that it should be enabled
3209         in development builds just so we are up-to-date with future feature infrastructure changes.
3210         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
3211         that's an obvious goal before enabling the feature in release builds.
3212
3213         * Scripts/webkitperl/FeatureList.pm:
3214
3215 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3216
3217         [chromium] delay clearing the TestRunners until the main view was deleted
3218         https://bugs.webkit.org/show_bug.cgi?id=111823
3219
3220         Reviewed by Eric Seidel.
3221
3222         During WebViewHost::shutdown, we navigate the WebView to about:blank.
3223         This may call into the test runners which assume that the delegate is
3224         always non-NULL.
3225
3226         * DumpRenderTree/chromium/TestShell.cpp:
3227         (TestShell::~TestShell):
3228
3229 2013-03-07  Alan Cutter  <alancutter@chromium.org>
3230
3231         Sheriffbot whois command can't search by full name
3232         https://bugs.webkit.org/show_bug.cgi?id=111825
3233
3234         Reviewed by Eric Seidel.
3235
3236         Allowed multiple arguments to Sheriffbot's whois command.
3237         Updated test expectations.
3238
3239         * Scripts/webkitpy/tool/bot/irc_command.py:
3240         (Whois.execute):
3241         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3242         (IRCCommandTest.test_whois):
3243
3244 2013-03-07  Nils Barth  <nbarth@chromium.org>
3245
3246         Add Nils Barth and Koji Hara to committers.py
3247         https://bugs.webkit.org/show_bug.cgi?id=111806
3248
3249         Reviewed by Eric Seidel.
3250
3251         * Scripts/webkitpy/common/config/committers.py:
3252
3253 2013-03-07  Glenn Adams  <glenn@skynav.com>
3254
3255         run-pert-tests should have a --test-runner-count option
3256         https://bugs.webkit.org/show_bug.cgi?id=111726
3257
3258         Reviewed by Ryosuke Niwa.
3259
3260         Add --test-runner-count option to run-perf-tests, with default value of 4.
3261         This option allows command line configuration of the number of times to invoke
3262         the test runner (serially, not in parallel) when running a specific test in
3263         a test set.
3264
3265         * Scripts/webkitpy/performance_tests/perftest.py:
3266         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
3267         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
3268         (PerfTest.run): Rename process_run_count to test_runner_count.
3269         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
3270         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
3271         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
3272         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
3273         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3274         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
3275         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
3276         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3277         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
3278         (MainTest.test_run_with_repeat):
3279         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
3280         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3281         (MainTest.test_default_args): Add test for default option argument values.
3282         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
3283
3284 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
3285
3286         Add myself to reviewers.py
3287         https://bugs.webkit.org/show_bug.cgi?id=111757
3288
3289         Reviewed by Eric Seidel.
3290
3291         * Scripts/webkitpy/common/config/committers.py:
3292
3293 2013-03-07  Glenn Adams  <glenn@skynav.com>
3294
3295         run-perf-tests should have a --repeat option
3296         https://bugs.webkit.org/show_bug.cgi?id=100030
3297
3298         Reviewed by Ryosuke Niwa.
3299
3300         Add --repeat option to run-perf-tests, with default value of 1. When greater
3301         than 1, runs test set specified number of times. Note that multiple runs are
3302         not aggregated for statistical purposes.
3303
3304         Incidentally fixed typo: s/suceeds/succeeds/.
3305
3306         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3307         (PerfTestsRunner._parse_args): Add repeat option.
3308         (PerfTestsRunner.run): Add outer repeat loop.
3309         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
3310         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
3311         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3312         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
3313         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
3314         (MainTest.test_run_with_json_output): Fix typo.
3315         (MainTest.test_run_with_description): Fix typo.
3316         (MainTest.test_run_respects_no_results): Fix typo.
3317         (MainTest.test_run_with_slave_config_json): Fix typo.
3318         (MainTest.test_run_with_multiple_repositories): Fix typo.
3319         (MainTest.test_run_with_upload_json): Fix typo.
3320         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
3321         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
3322         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3323         (MainTest.test_parse_args): Add test for repeat option parsing.
3324
3325 2013-03-07  Julie Parent  <jparent@chromium.org>
3326
3327         showAllRuns checkbox no longer works on the stats dashboard
3328         https://bugs.webkit.org/show_bug.cgi?id=111673
3329
3330         Reviewed by Ojan Vafai.
3331
3332         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
3333         so we were trying to index into an undefined object.
3334         
3335         * TestResultServer/static-dashboards/dashboard_base.js:
3336         (invalidateQueryParameters):
3337
3338 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
3339
3340         [Chromium] Update #include for WebStorageNamespace.h
3341         https://bugs.webkit.org/show_bug.cgi?id=111748
3342
3343         Reviewed by Adam Barth.
3344
3345         In anticipation of removing
3346         WK/chromium/public/WebStorageNamespace.h (once downstream
3347         references have been updated)
3348
3349         * DumpRenderTree/chromium/WebViewHost.cpp:
3350
3351 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3352
3353         run-perf-tests fails due to svn_revision not working on a pure git clone
3354         https://bugs.webkit.org/show_bug.cgi?id=110839
3355
3356         Reviewed by Ryosuke Niwa.
3357
3358         Previously we would call git svn find-rev to look up the commit for
3359         a given revision, and that'll hang in a pure git checkout.
3360
3361         This patch changes the way we look up svn revisions in a git
3362         repository to use git log --grep 'git-svn-id', which is much faster
3363         than grepping ourselves. It also renames timestamp_of_latest_commit()
3364         to timestamp_of_revision() in order to accurately reflect what
3365         the method is doing. Note that this patch only changes the logic
3366         inside latest_revision() and svn_revision(). I'll file a separate
3367         bug to change git_commit_from_svn_revision().
3368
3369         This patch also contains some fixes to unit tests that had bit-rotted
3370         or were otherwise fragile, so that test-webkitpy --all would pass
3371         cleanly, and a fix to outputcapture so that
3372         test-webkitpy -p would work correctly again.
3373
3374         * Scripts/webkitpy/common/checkout/scm/git.py:
3375         (Git.svn_revision):
3376         (Git.timestamp_of_revision):
3377         * Scripts/webkitpy/common/checkout/scm/scm.py:
3378         (SCM.svn_revision):
3379         (SCM.timestamp_of_revision):
3380         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3381         (MockSCM.timestamp_of_revision):
3382         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3383         (_shared_test_commit_with_message):
3384         (test_commit_without_authorization):
3385         (test_timestamp_of_revision):
3386         * Scripts/webkitpy/common/checkout/scm/svn.py:
3387         (SVN.timestamp_of_revision):
3388         * Scripts/webkitpy/common/system/outputcapture.py:
3389           Importing unittest2 directly may not be safe if this module is
3390           imported before the autoinstaller gets a chance to set things up
3391           properly. We don't actually need unittest2 here.
3392         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3393         (PerfTestsRunner._generate_results_dict):
3394
3395 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3396
3397         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
3398         https://bugs.webkit.org/show_bug.cgi?id=111756
3399
3400         Reviewed by Kenneth Rohde Christiansen.
3401
3402         Bump libsoup to v2.40.3 to fix the regressions introduced by
3403         previous v2.40.0 bump.
3404
3405         * efl/jhbuild.modules:
3406
3407 2013-03-07  Roger Fong  <roger_fong@apple.com>
3408
3409         Re-enable Win EWS tests.
3410
3411         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3412         (WinEWS):
3413
3414 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
3415
3416         [nrwt] handle corrupt http server pid files cleanly
3417         https://bugs.webkit.org/show_bug.cgi?id=111628
3418
3419         Reviewed by Eric Seidel.
3420
3421         If the pid file from a previous http server is corrupt for some
3422         reason, NRWT will just raise errors and not clean it up or recover.
3423         This patch fixes that to at least delete the pid file and
3424         not throw; not that we may still have stale http servers left on
3425         the system, since there's no way to know which pid to kill if
3426         the file was corrupted.
3427
3428         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3429         (HttpServerBase.start):
3430         (HttpServerBase.stop):
3431         (HttpServerBase._remove_pid_file):
3432         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
3433         (TestHttpServerBase):
3434         (TestHttpServerBase.test_corrupt_pid_file):
3435
3436 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
3437
3438         AX: Can't activate links with VoiceOver in Safari
3439         https://bugs.webkit.org/show_bug.cgi?id=111755
3440
3441         Reviewed by Tim Horton.
3442
3443         * DumpRenderTree/AccessibilityUIElement.cpp:
3444         (supportedActionsCallback):
3445         (AccessibilityUIElement::getJSClass):
3446         * DumpRenderTree/AccessibilityUIElement.h:
3447         (AccessibilityUIElement):
3448         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3449         (AccessibilityUIElement::supportedActions):
3450
3451 2013-03-07  Roger Fong  <roger_fong@apple.com>
3452
3453         Windows debug layout tests are crashing like crazy again.
3454         Disable tests on Win EWS bots temporarily.
3455
3456         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3457         (WinEWS):
3458
3459 2013-03-07  Roger Fong  <roger_fong@apple.com>
3460
3461         Make EWS bots build and test in release.
3462
3463         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3464         (WinEWS):
3465         * Scripts/webkitpy/tool/steps/runtests.py:
3466         (RunTests.run):
3467
3468 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
3469
3470         [chromium] don't track the top loading frame if no layout test is currently running
3471         https://bugs.webkit.org/show_bug.cgi?id=111716
3472
3473         Reviewed by Kentaro Hara.
3474
3475         In DRT, we synchronously stop the test and start loading the next test
3476         URL. However, in content_shell, this happens asynchronously. It's
3477         important that the top loading frame is not changed due to stray
3478         navigation events before the next test starts.
3479
3480         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3481         (WebTestRunner::TestRunner::setTopLoadingFrame):
3482
3483 2013-03-06  Julie Parent  <jparent@chromium.org>
3484
3485         Dashboard cleanup: Move all dashboard ui related code into ui.js.
3486         https://bugs.webkit.org/show_bug.cgi?id=111621
3487
3488         Reviewed by Ojan Vafai.
3489         
3490         Creates ui.js, a package for the common UI code the various
3491         dashboards use. HTML generation is now in the ui.html namespace
3492         and popup handling is in ui.popup.
3493         Also moves the event listening for popups to ui.popup.show and
3494         removes it on ui.popup.hid rather than having listener always
3495         around.
3496
3497         * TestResultServer/static-dashboards/aggregate_results.html:
3498         * TestResultServer/static-dashboards/dashboard_base.js:
3499         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3500         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3501         (showPopupForBuild):
3502         (htmlForNavBar):
3503         (generatePageForIndividualTests.if):
3504         (generatePageForIndividualTests):
3505         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
3506         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3507         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3508         * TestResultServer/static-dashboards/run-unittests.html:
3509         * TestResultServer/static-dashboards/timeline_explorer.html:
3510         * TestResultServer/static-dashboards/treemap.html:
3511         * TestResultServer/static-dashboards/ui.js: Added.
3512         (.):
3513
3514 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
3515
3516         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
3517         https://bugs.webkit.org/show_bug.cgi?id=110584
3518
3519         Reviewed by Gyuyoung Kim.
3520
3521         Adds missing implementation of AccessibilityControllerEfl
3522         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
3523         so that it can make accessibilityController as a js object.
3524
3525         * DumpRenderTree/AccessibilityController.h:
3526         (AccessibilityController):
3527         * DumpRenderTree/AccessibilityUIElement.h:
3528         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3529         (AccessibilityController::childElementById): Moved declaration to base class.
3530         Implementation can be shared among other ports.
3531         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
3532         (AccessibilityController::focusedElement):
3533         (AccessibilityController::rootElement):
3534         (AccessibilityController::accessibleElementById):
3535         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
3536         (AccessibilityUIElement::helpText):
3537         * DumpRenderTree/efl/CMakeLists.txt:
3538         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3539         (DumpRenderTreeChrome::DumpRenderTreeChrome):
3540         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3541         (DumpRenderTreeChrome::onWindowObjectCleared):
3542         (DumpRenderTreeChrome::accessibilityController):
3543         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3544         (DumpRenderTreeChrome):
3545         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3546
3547 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
3548
3549         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
3550         https://bugs.webkit.org/show_bug.cgi?id=42696
3551
3552         Reviewed by Andreas Kling.
3553
3554         * DumpRenderTree/TestRunner.cpp:
3555         (TestRunner::staticFunctions):
3556         * DumpRenderTree/TestRunner.h:
3557         (TestRunner):
3558         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3559         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3560         (WebTestRunner::TestRunner::TestRunner):
3561         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3562         (TestRunner):
3563         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3564         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3565         * DumpRenderTree/mac/TestRunnerMac.mm:
3566         * DumpRenderTree/qt/TestRunnerQt.cpp:
3567         * DumpRenderTree/qt/TestRunnerQt.h:
3568         (TestRunnerQt):
3569         * DumpRenderTree/win/TestRunnerWin.cpp:
3570         * DumpRenderTree/wx/TestRunnerWx.cpp:
3571
3572 2013-03-06  Roger Fong  <roger_fong@apple.com>
3573
3574         Re-enable WinEWS test and decrease iterations before clean build back to 10.
3575
3576         * EWSTools/start-queue-win.sh:
3577         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3578         (WinEWS):
3579
3580 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
3581
3582         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
3583         https://bugs.webkit.org/show_bug.cgi?id=82866
3584
3585         Reviewed by Martin Robinson.
3586
3587         * Scripts/run-gtk-tests:
3588         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
3589         it is passing now.
3590
3591 2013-03-06  Julie Parent  <jparent@chromium.org>
3592
3593         Dashboard cleanup: remove dashboard time logging.
3594         https://bugs.webkit.org/show_bug.cgi?id=111608
3595
3596         Reviewed by Dirk Pranke.
3597
3598         Remove logTime.  It was never accurate, and the dev tools
3599         have better ways to measure this if anyone cares to look
3600         into dashboard perf.
3601         
3602         * TestResultServer/static-dashboards/dashboard_base.js:
3603         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3604         (processTestRunsForBuilder):
3605         (appendHTML):
3606
3607 2013-03-06  Tony Chang  <tony@chromium.org>
3608
3609         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
3610         https://bugs.webkit.org/show_bug.cgi?id=111509
3611
3612         Reviewed by Dirk Pranke.
3613
3614         Add DumpRenderTree.pak to DumpRenderTree.app again.
3615
3616         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3617
3618 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
3619
3620         [chromium] introduce WebUserGestureIndicator
3621         https://bugs.webkit.org/show_bug.cgi?id=111531
3622
3623         Reviewed by Adam Barth.
3624
3625         * DumpRenderTree/chromium/WebViewHost.cpp:
3626         (WebViewHost::createView):
3627
3628 2013-03-06  Alan Cutter  <alancutter@chromium.org>
3629
3630         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
3631         https://bugs.webkit.org/show_bug.cgi?id=73482
3632
3633         Reviewed by Ryosuke Niwa.
3634
3635         Added input checking to the UpdateChromiumDEPS step.
3636         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
3637
3638         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
3639         (RollChromiumDEPS):
3640         (RollChromiumDEPS._parse_args):
3641         (R