Unreviewed, add unittest after r191827.
[WebKit-https.git] / Tools / ChangeLog
1 2015-11-03  Csaba Osztrogonác  <ossy@webkit.org>
2
3         Unreviewed, add unittest after r191827.
4
5         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
6
7 2015-11-02  Andy Estes  <aestes@apple.com>
8
9         [Cocoa] Add tvOS and watchOS to SUPPORTED_PLATFORMS
10         https://bugs.webkit.org/show_bug.cgi?id=150819
11
12         Reviewed by Dan Bernstein.
13
14         This tells Xcode to include these platforms in its Devices dropdown, making it possible to build in the IDE.
15
16         * DumpRenderTree/mac/Configurations/Base.xcconfig:
17         * MiniBrowser/Configurations/Base.xcconfig:
18         * TestWebKitAPI/Configurations/Base.xcconfig:
19         * WebKitTestRunner/Configurations/Base.xcconfig:
20
21 2015-11-02  Anders Carlsson  <andersca@apple.com>
22
23         Begin work on supporting reply blocks in _WKRemoteObjectRegistry
24         https://bugs.webkit.org/show_bug.cgi?id=150739
25
26         Reviewed by Tim Horton.
27
28         Add a test. We only test the encoding right now.
29
30         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
31         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
32         (TEST):
33         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
34         (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
35
36 2015-11-02  Tim Horton  <timothy_horton@apple.com>
37
38         Get rid of WKWebView's inner WKView (WKView being inside WKWebView leads to weird API issues)
39         https://bugs.webkit.org/show_bug.cgi?id=150174
40
41         Reviewed by Anders Carlsson.
42
43         * WebKitTestRunner/mac/EventSenderProxy.mm:
44         (WTR::EventSenderProxy::mouseUp):
45         (WTR::EventSenderProxy::mouseMoveTo):
46         Revert some parts of r188828 which no longer apply.
47
48 2015-10-30  Dana Burkart  <dburkart@apple.com>
49
50         svn-apply should handle unified diffs
51         https://bugs.webkit.org/show_bug.cgi?id=150650
52
53         Reviewed by Darin Adler.
54
55         * Scripts/VCSUtils.pm:
56         (parseUnifiedDiffHeader):
57         This method parses a unified diff header, and returns a information in the
58         style of parseGitDiffHeader and parseSvnDiffHeader.
59
60         (parseDiffHeader):
61         Teach parseDiffHeader to recognize unified diff headers.
62
63         (parseDiff):
64         Teach parseDiff to recognize unified diffs.
65
66         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
67         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl: Added.
68
69 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
70
71         Fix the FTL JIT build with system LLVM on Linux
72         https://bugs.webkit.org/show_bug.cgi?id=150795
73
74         Reviewed by Filip Pizlo.
75
76         * efl/install-dependencies:
77         * gtk/install-dependencies:
78
79 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
80
81         [EFL] Bump harfbuzz versions to 0.9.35
82         https://bugs.webkit.org/show_bug.cgi?id=150448
83
84         Reviewed by Gyuyoung Kim.
85
86         * efl/jhbuild.modules:
87
88 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
89
90         [EFL] gnutls-3.3.0 jhbuild module build fails on Ubuntu 15.10
91         https://bugs.webkit.org/show_bug.cgi?id=150622
92
93         Reviewed by Gyuyoung Kim.
94
95         * efl/install-dependencies:
96         * efl/jhbuild.modules:
97
98 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
99
100         Fix EFL jhbuild module build on Ubuntu 15.10
101         https://bugs.webkit.org/show_bug.cgi?id=150621
102
103         Reviewed by Gyuyoung Kim.
104
105         * efl/jhbuild.modules:
106         * efl/patches/efl-remove-XPrint.patch: Added.
107
108 2015-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
109
110         [GLIB] Remove delete on destroy GMainLoopSources
111         https://bugs.webkit.org/show_bug.cgi?id=150771
112
113         Reviewed by Žan Doberšek.
114
115         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:
116         (TestWebKitAPI::TEST): Remove DeleteOnDestroy unit tests.
117         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
118         (WebViewTest::wait): Use g_timeout_add instead of GMainLoopSource.
119
120 2015-11-01  Yusuke Suzuki  <utatane.tea@gmail.com>
121
122         [ES6] Support Generator Syntax
123         https://bugs.webkit.org/show_bug.cgi?id=150769
124
125         Reviewed by Geoffrey Garen.
126
127         Added ENABLE_ES6_GENERATORS flag.
128
129         * Scripts/webkitperl/FeatureList.pm:
130
131 2015-11-01  Alexey Proskuryakov  <ap@apple.com>
132
133         Sort EWS bots in popovers
134         https://bugs.webkit.org/show_bug.cgi?id=150782
135
136         Reviewed by Darin Adler.
137
138         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
139         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
140
141 2015-10-31  Filip Pizlo  <fpizlo@apple.com>
142
143         B3::reduceStrength's DCE should be more agro and less wrong
144         https://bugs.webkit.org/show_bug.cgi?id=150748
145
146         Reviewed by Geoffrey Garen.
147
148         Add an LLVM version of testb3's "testComplex".
149
150         * ReducedFTL/ComplexTest.cpp: Added.
151
152 2015-11-01  Commit Queue  <commit-queue@webkit.org>
153
154         Unreviewed, rolling out r191831.
155         https://bugs.webkit.org/show_bug.cgi?id=150774
156
157         The new test fails (Requested by ap on #webkit).
158
159         Reverted changeset:
160
161         "Begin work on supporting reply blocks in
162         _WKRemoteObjectRegistry"
163         https://bugs.webkit.org/show_bug.cgi?id=150739
164         http://trac.webkit.org/changeset/191831
165
166 2015-10-31  Andreas Kling  <akling@apple.com>
167
168         Add a debug overlay with information about web process resource usage.
169         <https://webkit.org/b/150599>
170
171         Reviewed by Darin Adler.
172
173         Add a menu item to the MiniBrowser so we can toggle the resource usage overlay on/off.
174
175         * MiniBrowser/mac/SettingsController.h:
176         * MiniBrowser/mac/SettingsController.m:
177         (-[SettingsController _populateMenu]):
178         (-[SettingsController validateMenuItem:]):
179         (-[SettingsController toggleShowResourceUsageOverlay:]):
180         (-[SettingsController resourceUsageOverlayVisible]):
181         * MiniBrowser/mac/WK2BrowserWindowController.m:
182         (-[WK2BrowserWindowController didChangeSettings]):
183
184 2015-10-31  Lucas Forschler  <lforschler@apple.com>
185
186         Teach the CompileWebKit step to look for additional arguments.
187         
188         Unreviewed config change.
189
190         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
191         (CompileWebKit.start):
192
193 2015-10-30  Anders Carlsson  <andersca@apple.com>
194
195         Begin work on supporting reply blocks in _WKRemoteObjectRegistry
196         https://bugs.webkit.org/show_bug.cgi?id=150739
197
198         Reviewed by Tim Horton.
199
200         Add a test. We only test the encoding right now.
201
202         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
203         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
204         (TEST):
205         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
206         (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
207
208 2015-10-30  Lucas Forschler  <lforschler@apple.com>
209
210         Add CMAke builder to build.webkit.org
211         https://bugs.webkit.org/show_bug.cgi?id=150738
212         
213         Reviewed by Alex Christensen.
214
215         * BuildSlaveSupport/build.webkit.org-config/config.json:
216
217 2015-10-30  Brent Fulgham  <bfulgham@apple.com>
218
219         [Win] build-jsc and run-javascriptcore-tests do not work
220         https://bugs.webkit.org/show_bug.cgi?id=150700
221
222         Reviewed by Mark Lam.
223         
224         Correct our build system so that it expects Windows to be using CMake,
225         and to build the correct sub-projects for our JSC helper scripts.
226
227         * Scripts/build-jsc: Make sure to build the testapi harness when
228           building for Windows.
229         * Scripts/build-webkit:
230           (1) Use the existing 'cmakeBasedPortName()'
231           (2) Use File::Spec rather than hard-coding path delimeters.
232           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
233         method rather than hard-coding the name based on conditional.
234         * Scripts/copy-webkitlibraries-to-product-directory: Don't try to grab
235           LLVM libraries on Apple Windows build.
236         * Scripts/run-javascriptcore-tests:
237         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
238         * Scripts/run-jsc: Ditto.
239         * Scripts/webkitdirs.pm:
240         (cmakeBasedPortName): Update to return the right value for the Apple
241         Windows port and the WinCairo port.
242         (isCMakeBuild): Expect CMake build for all Windows ports.
243
244 2015-10-30  Carlos Garcia Campos  <cgarcia@igalia.com>
245
246         [JHBuild] Do not try to update the dependencies if jhbuild configuration hasn't changed
247         https://bugs.webkit.org/show_bug.cgi?id=150665
248
249         Reviewed by Csaba Osztrogonác.
250
251         We check it only to wipe the directory or not, but we are still
252         tryihng to update every module even when the configuration hasn't
253         changed. This is problematic because it makes the whole build fail
254         when any repository fails to checkout an already checked out
255         revision, because the server is down for example. This is even
256         more problematic for the bots that skip perfectly valid revisions.
257         It's still possible to force an update passing --force command
258         line argument.
259
260         * Scripts/update-webkit-libs-jhbuild:
261         (deleteJhbuildMd5): Delete the md5sum files if exist.
262         (runJhbuild): Return early if the md5sum files haven't
263         changed. Only write them after a successful build and delete them
264         if the build fails to ensure we don't skip next run.
265
266 2015-10-30  Philippe Normand  <pnormand@igalia.com>
267
268         [GTK] Fix MacCLang build errors in Tools
269         https://bugs.webkit.org/show_bug.cgi?id=150031
270
271         Reviewed by Carlos Garcia Campos.
272
273         * TestWebKitAPI/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
274         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
275         * WebKitTestRunner/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
276         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
277
278 2015-10-29  Hunseop Jeong  <hs85.jeong@samsung.com>
279
280         [EFL] MiniBrowser didn't work after r191749.
281         https://bugs.webkit.org/show_bug.cgi?id=150706
282
283         Reviewed by Alex Christensen.
284
285         Renamed jhbuildWrapperPrefixIfNeeded to wrapperPrefixIfNeeded in r191749.
286
287         * Scripts/run-minibrowser:
288
289 2015-10-29  Commit Queue  <commit-queue@webkit.org>
290
291         Unreviewed, rolling out r191766.
292         https://bugs.webkit.org/show_bug.cgi?id=150707
293
294         Problem with Cygwin build (Requested by bfulgham_ on #webkit).
295
296         Reverted changeset:
297
298         "[Win] build-jsc and run-javascriptcore-tests do not work"
299         https://bugs.webkit.org/show_bug.cgi?id=150700
300         http://trac.webkit.org/changeset/191766
301
302 2015-10-29  Brent Fulgham  <bfulgham@apple.com>
303
304         [Win] build-jsc and run-javascriptcore-tests do not work
305         https://bugs.webkit.org/show_bug.cgi?id=150700
306
307         Reviewed by Mark Lam.
308         
309         Correct our build system so that it expects Windows to be using CMake,
310         and to build the correct sub-projects for our JSC helper scripts.
311
312         * Scripts/build-jsc: Make sure to build the testapi harness when
313           building for Windows.
314         * Scripts/build-webkit:
315           (1) Use the existing 'cmakeBasedPortName()'
316           (2) Use File::Spec rather than hard-coding path delimeters.
317           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
318         method rather than hard-coding the name based on conditional.
319         * Scripts/run-javascriptcore-tests:
320         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
321         * Scripts/run-jsc: Ditto.
322         * Scripts/webkitdirs.pm:
323         (cmakeBasedPortName): Update to return the right value for the Apple
324         Windows port and the WinCairo port.
325         (isCMakeBuild): Expect CMake build for all Windows ports.
326
327 2015-10-29  Alex Christensen  <achristensen@webkit.org>
328
329         Fix build-jsc on Mac after r191749.
330
331         * Scripts/build-jsc:
332         Use isCMakeBuild to determine if we are building with CMake instead of cmakeBasedPortName.
333
334 2015-10-29  Alex Christensen  <achristensen@webkit.org>
335
336         Fix Mac CMake build
337         https://bugs.webkit.org/show_bug.cgi?id=150686
338
339         Reviewed by Filip Pizlo.
340
341         * Scripts/build-webkit:
342         * Scripts/webkitdirs.pm:
343         (isCachedArgumentfileOutOfDate):
344         (wrapperPrefixIfNeeded):
345         (generateBuildSystemFromCMakeProject):
346         (buildCMakeGeneratedProject):
347         (cmakeBasedPortName):
348         (determineIsCMakeBuild):
349         (isCMakeBuild):
350         (promptUser):
351         (jhbuildWrapperPrefixIfNeeded): Deleted.
352
353 2015-10-29  Lucas Forschler  <lforschler@apple.com>
354
355         Teach JSC bots to build 32bit instead of x86_64
356         
357         Reviewed by Mark Lam.
358
359         * BuildSlaveSupport/build.webkit.org-config/config.json:
360
361 2015-10-29  Per Arne Vollan  <peavo@outlook.com>
362
363         [WinCairo] Fall back to AppleWin results in layout tests.
364         https://bugs.webkit.org/show_bug.cgi?id=150672
365
366         Reviewed by Alex Christensen.
367
368         * Scripts/webkitpy/port/win.py:
369         (WinCairoPort):
370         (WinCairoPort.default_baseline_search_path):
371
372 2015-10-28  Keith Rollin  <krollin@apple.com>
373
374         Do not sanitize user input for input[type=url]
375         https://bugs.webkit.org/show_bug.cgi?id=150346
376         <rdar://problem/23243240>
377
378         Reviewed by Brent Fulgham.
379
380         The Windows version of DumpRenderTree's eventSender.keyDown handler
381         simulates user-entry by decomposing the given character into a virtual
382         key code and a set of modifier keys. The code that determines if the
383         shift key should be simulated only worked if the character was an
384         upper case character. Extend this support to also include symbols that
385         (on the U.S. keyboard) require holding down the shift key.
386
387         This change allows fast/forms/input-user-input-sanitization.html
388         to succeed, which requires us to simulate the entering of '@' and ':'.
389
390         * DumpRenderTree/win/EventSender.cpp:
391         (keyDownCallback):
392
393 2015-10-28  Alex Christensen  <achristensen@webkit.org>
394
395         Compile and link with CMake on Mac
396         https://bugs.webkit.org/show_bug.cgi?id=150632
397
398         Reviewed by Tim Horton.
399
400         * TestWebKitAPI/PlatformMac.cmake:
401
402 2015-10-28  Xabier Rodriguez Calvar  <calvaris@igalia.com>
403
404         Unreviewed.
405
406         * Scripts/webkitpy/common/config/watchlist: Removed dead files from Streams API watchlist.
407
408 2015-10-28  Per Arne Vollan  <peavo@outlook.com>
409
410         Add WinCairo to list of ports in run-webkit-tests.
411         https://bugs.webkit.org/show_bug.cgi?id=150625
412
413         Reviewed by Brent Fulgham.
414
415         * Scripts/webkitpy/common/config/ports.py:
416         (DeprecatedPort.port):
417         (WinPort.run_webkit_tests_command):
418         (WinCairoPort):
419         (GtkWK2Port):
420         * Scripts/webkitpy/port/factory.py:
421         (PortFactory):
422         * Scripts/webkitpy/port/win.py:
423         (WinPort.find_system_pid):
424         (WinCairoPort):
425
426 2015-10-27  Alexey Proskuryakov  <ap@apple.com>
427
428         WebKitTestRunner leaks in generateWhitelist()
429         https://bugs.webkit.org/show_bug.cgi?id=150563
430
431         Reviewed by Andreas Kling.
432
433         * WebKitTestRunner/mac/TestControllerMac.mm:
434         (WTR::generateWhitelist):
435
436 2015-10-27  Anders Carlsson  <andersca@apple.com>
437
438         Add an API test for _WKRemoteObjectRegistry
439         https://bugs.webkit.org/show_bug.cgi?id=150597
440
441         Reviewed by Andreas Kling.
442
443         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
444         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Added.
445         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Added.
446         (TEST):
447         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Added.
448         (-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
449         (-[RemoteObjectRegistryPlugIn sayHello:]):
450
451 2015-10-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
452
453         Add myself to the reviewers list
454         https://bugs.webkit.org/show_bug.cgi?id=150581
455
456         Unreviewed.
457
458         * Scripts/webkitpy/common/config/contributors.json:
459
460 2015-10-26  Ryan Haddad  <ryanhaddad@apple.com>
461
462         Adding myself to contributors.json
463
464         * Scripts/webkitpy/common/config/contributors.json:
465
466 2015-10-26  Tim Horton  <timothy_horton@apple.com>
467
468         Don't expose the whitelist/blacklist in _WKUserStyleSheet
469         https://bugs.webkit.org/show_bug.cgi?id=150566
470
471         Reviewed by Anders Carlsson.
472
473         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
474         (TEST):
475
476 2015-10-26  Philippe Normand  <pnormand@igalia.com>
477
478         Unreviewed, rolling out r191576.
479
480         broke
481
482         Reverted changeset:
483
484         "[GStreamer] Bump internal jhbuild versions to 1.6.0"
485         https://bugs.webkit.org/show_bug.cgi?id=149594
486         http://trac.webkit.org/changeset/191576
487
488 2015-10-26  ChangSeok Oh  <changseok.oh@collabora.com>
489
490         [GStreamer] Bump internal jhbuild versions to 1.6.0
491         https://bugs.webkit.org/show_bug.cgi?id=149594
492
493         Reviewed by Philippe Normand.
494
495         Bump up whole gstreamer libraries to 1.6.0. Relevant patches are no more
496         useful so they are removed accordingly.
497
498         * gtk/jhbuild.modules:
499         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
500         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
501         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
502
503 2015-10-25  Alexey Proskuryakov  <ap@apple.com>
504
505         API tests fail on El Capitan after r191543
506         https://bugs.webkit.org/show_bug.cgi?id=150547
507
508         Reviewed by Dan Bernstein.
509
510         * Scripts/run-api-tests: (listAllTests): Add appropriate arch arguments in one more place.
511
512 2015-10-24  Tim Horton  <timothy_horton@apple.com>
513
514         Add a way to add user style sheets to WKUserContentController
515         https://bugs.webkit.org/show_bug.cgi?id=150531
516         <rdar://problem/23191691>
517
518         Reviewed by Darin Adler.
519
520         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
521         (TEST):
522
523 2015-10-24  Tim Horton  <timothy_horton@apple.com>
524
525         Expose more information about the exception in WKErrorJavaScriptExceptionOccurred errors
526         https://bugs.webkit.org/show_bug.cgi?id=150525
527
528         Reviewed by Darin Adler.
529
530         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
531         (TEST):
532         Test the various new keys.
533
534 2015-10-24  Frederic Wang  <fred.wang@free.fr>
535
536         check-webkit-style complains about missing operator whitespace inside character literal
537         https://bugs.webkit.org/show_bug.cgi?id=150396
538
539         Reviewed by Darin Adler.
540
541         * Scripts/webkitpy/style/checkers/cpp.py: Improve matching of C++ character literal.
542         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
543         (WebKitStyleTest.test_spacing): Add a test to verify that the spacing for the character literal 'OS/2' is not tested.
544
545 2015-10-23  Michael Saboff  <msaboff@apple.com>
546
547         REGRESSION (r179357-r179359): WebContent Crash using AOL Mail @ com.apple.JavascriptCore JSC::linkPolymorphicCall(JSC::ExecState*, JSC::CallLinkInfo&, JSC::CallVariant, JSC::RegisterPreservationMode) + 1584
548         https://bugs.webkit.org/show_bug.cgi?id=150513
549
550         Reviewed by Saam Barati.
551
552         Added a new test function, failNextNewCodeBlock() to simplify the writing of a regression test.
553
554         * DumpRenderTree/TestRunner.cpp:
555         (simulateWebNotificationClickCallback):
556         (failNextCodeBlock):
557         (numberOfDFGCompiles):
558         (TestRunner::staticFunctions):
559         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
560         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
561         (WTR::TestRunner::setBlockAllPlugins):
562         (WTR::TestRunner::failNextCodeBlock):
563         (WTR::TestRunner::numberOfDFGCompiles):
564         * WebKitTestRunner/InjectedBundle/TestRunner.h:
565
566 2015-10-23  Anders Carlsson  <andersca@apple.com>
567
568         Simplify the WebKitLegacy menu conversion code
569         https://bugs.webkit.org/show_bug.cgi?id=150509
570
571         Reviewed by Andreas Kling.
572
573         Implement the context menu delegate method so we'll test that code path.
574
575         * MiniBrowser/mac/WK1BrowserWindowController.m:
576         (-[WK1BrowserWindowController webView:contextMenuItemsForElement:defaultMenuItems:]):
577
578 2015-10-23  Per Arne Vollan  <peavo@outlook.com>
579
580         [WinCairo] Improve test results for fast layouttests.
581         https://bugs.webkit.org/show_bug.cgi?id=150464
582
583         Reviewed by Alex Christensen.
584
585         Set custom device scale factor to 1.0.
586
587         * DumpRenderTree/win/DumpRenderTree.cpp:
588         (createWebViewAndOffscreenWindow):
589
590 2015-10-23  Mark Salisbury  <mark.salisbury@hp.com>
591
592         [GTK] update-webkitgtk-libs should use mesa tarball
593
594         https://bugs.webkit.org/show_bug.cgi?id=150470
595
596         update-webkitgtk-libs downloads all build dependencies; in fixing
597         bug 148941 mesa was switched from ftp to git access.  Now an http
598         tarball is available, which is preferred over accessing via git.
599
600         Reviewed by Philippe Normand
601
602         * gtk/jhbuild.modules:
603         Mesa access changed to http tarball.
604
605 2015-10-22  Sam Weinig  <sam@webkit.org>
606
607         Navigations on the same host (but with different schemes and ports) should not trigger universal links
608         <rdar://problem/22811325>
609         https://bugs.webkit.org/show_bug.cgi?id=150481
610
611         Reviewed by Dan Bernstein.
612
613         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
614         Update test to test that navigations on the same host but with different schemes does not
615         trigger universal links, but that changes in the host do.
616
617 2015-10-22  Ryosuke Niwa  <rniwa@webkit.org>
618
619         REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
620         https://bugs.webkit.org/show_bug.cgi?id=150428
621
622         Reviewed by Antti Koivisto.
623
624         Added a regression test using WebKit API test.
625
626         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
627         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
628         (TestWebKitAPI::didFinishLoadForFrame):
629         (TestWebKitAPI::TEST):
630
631 2015-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
632
633         Unreviewed. Fix GTK+ build after r191423.
634
635         Add WebKitDOMHTMLBaseFontElement to the list of deleted classes.
636
637         * gtk/webkitdom.py:
638         (WebKitDOMDocGenerator):
639
640 2015-10-22  Aakash Jain  <aakash_jain@apple.com>
641
642         [Win][EFL][GTK] webkitpy test failed after r191374.
643         https://bugs.webkit.org/show_bug.cgi?id=150433
644
645         Reviewed by Alexey Proskuryakov.
646
647         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
648         (CrashLogsTest.test_find_all_log_darwin): Check platform before running test.
649         (CrashLogsTest.test_find_log_darwin): Same.
650
651 2015-10-21  Brian Burg  <bburg@apple.com>
652
653         Unreviewed, update watchlist for JS builtins.
654
655         Add a category for JS builtins code generator, similar to other generators.
656
657         Add a nag message to rebaseline builtins generator tests when touching
658         code generator files in Source/JavaScriptCore/Scripts/builtins/.
659
660         * Scripts/webkitpy/common/config/watchlist:
661
662 2015-10-21  Brian Burg  <bburg@apple.com>
663
664         Restructure generate-js-bindings script to be modular and testable
665         https://bugs.webkit.org/show_bug.cgi?id=149929
666
667         Reviewed by Alex Christensen.
668
669         Add a stub shell script and basic webkitpy support for running builtins
670         generator tests.
671
672         * Scripts/run-builtins-generator-tests: Added.
673         (main):
674         * Scripts/webkitpy/codegen/__init__.py: Added.
675         * Scripts/webkitpy/codegen/main.py: Added.
676
677             The only interesting difference here from the inspector protocol
678             generator equivalent is that this implementation decodes the target
679             framework and output mode (combined or separate) from the test's file name.
680
681         (BuiltinsGeneratorTests):
682         (BuiltinsGeneratorTests.__init__):
683         (BuiltinsGeneratorTests.generate_from_js_builtins):
684         (BuiltinsGeneratorTests.write_error_file):
685         (BuiltinsGeneratorTests.detect_changes):
686         (BuiltinsGeneratorTests.run_tests):
687         (BuiltinsGeneratorTests.main):
688
689 2015-10-21  Aakash Jain  <aakash_jain@apple.com>
690
691         run-webkit-tests does not copy all crash logs for layout test failures on Mac
692         https://bugs.webkit.org/show_bug.cgi?id=150407
693         <rdar://problem/22239750>
694
695         Reviewed by Alexey Proskuryakov.
696
697         * Scripts/webkitpy/port/mac.py:
698         (MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
699         (MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
700         the log directory.
701         (MacPort.look_for_new_crash_logs): Uses above method to get crash logs
702         from log directory and merge them with the list of already crashed tests.
703
704 2015-10-21  Filip Pizlo  <fpizlo@apple.com>
705
706         Failures in PutStackSinkingPhase should be less severe
707         https://bugs.webkit.org/show_bug.cgi?id=150400
708
709         Reviewed by Geoffrey Garen.
710
711         Add a test mode for no PutStackSinkingPhase.
712
713         * Scripts/run-jsc-stress-tests:
714
715 2015-10-21  Nan Wang  <n_wang@apple.com>
716
717         AX: Expose table size and cell indexes on iOS
718         https://bugs.webkit.org/show_bug.cgi?id=150366
719
720         Reviewed by Chris Fleizach.
721
722         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
723         (AccessibilityUIElement::rowCount):
724         (AccessibilityUIElement::columnCount):
725         (AccessibilityUIElement::indexInTable):
726         (AccessibilityUIElement::numberAttributeValue):
727         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
728         (WTR::AccessibilityUIElement::numberAttributeValue):
729         (WTR::AccessibilityUIElement::rowCount):
730         (WTR::AccessibilityUIElement::columnCount):
731         (WTR::AccessibilityUIElement::indexInTable):
732
733 2015-10-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
734
735         W3C test importer should not import reference files as regular tests
736         https://bugs.webkit.org/show_bug.cgi?id=150331
737
738         Reviewed by Darin Adler.
739
740         Updated test_parser to return information that a file can be a referencefile or a manual test.
741         Updated test importer to skip those files.
742         Updated/Added test parser unit tests accordingly.
743
744         Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
745         Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
746         to mark these files as Skip, since they are not direct tests. 
747
748         * Scripts/webkitpy/w3c/test_importer.py:
749         (TestImporter.__init__):
750         (TestImporter.find_importable_tests):
751         (TestImporter.import_tests):
752         * Scripts/webkitpy/w3c/test_parser.py:
753         (TestParser.analyze_test):
754         * Scripts/webkitpy/w3c/test_parser_unittest.py:
755         (test_analyze_non_html_file):
756         (test_reference_test):
757
758 2015-10-20  Aakash Jain  <aakash_jain@apple.com>
759
760         run-webkit-tests does not copy all crash logs for layout test failures on iOS
761         https://bugs.webkit.org/show_bug.cgi?id=150056
762         <rdar://problem/9280656>
763
764         Reviewed by Alexey Proskuryakov.
765
766         * Scripts/webkitpy/common/system/crashlogs.py:
767         (CrashLogs.find_all_logs): Generic method to find all crash logs.
768         (CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
769         It iterates through log directory and returns all the logs based on timestamp.
770         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
771         (CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
772         (CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
773         (CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
774         * Scripts/webkitpy/layout_tests/controllers/manager.py:
775         (Manager.run): Modified start_time to start counting before simulator launch
776         so that we can capture crashes during simualator launch.
777         (Manager._look_for_new_crash_logs): Browse through list of crashes and append
778         any test which is not already marked as CRASH to the run_results.
779         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
780         (TestExpectationsModel.get_expectations_string): return PASS in case there
781         are no expectations defined for this test.
782         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
783         (summarize_results): Add other_crashes in a separte category in full_results.json.
784         * Scripts/webkitpy/port/ios.py:
785         (IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
786         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
787         from the log directory.
788         (IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
789         logs from log directory and merge them with the list of already crashed tests.
790
791 2015-10-20  Dana Burkart  <dburkart@apple.com>
792
793         Fix the build
794
795         Unreviewed.
796
797         My previous patch was missing a necessary space character.
798
799         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
800
801 2015-10-20  Dana Burkart  <dburkart@apple.com>
802
803         svn-apply fails to apply binary diffs in some cases
804         https://bugs.webkit.org/show_bug.cgi?id=64647
805
806         Reviewed by Daniel Bates.
807
808         * Scripts/VCSUtils.pm:
809         (decodeGitBinaryPatchDeltaSize): Modified.
810         We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
811         * Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
812
813 2015-10-20  Alexey Proskuryakov  <ap@apple.com>
814
815         Mac Debug EWS never finishes when there are failures
816         https://bugs.webkit.org/show_bug.cgi?id=150334
817
818         Reviewed by Daniel Bates.
819
820         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
821         * Scripts/webkitpy/tool/commands/queues.py:
822
823 2015-10-20  Philippe Normand  <pnormand@igalia.com>
824
825         [GTK] Enable OpenWebRTC test video/audio sources in tests
826
827         This is needed because we can't expect the buildbots to have
828         webcam/mic devices plugged in.
829
830         Rubber-stamped by Carlos Garcia Campos.
831
832         * Scripts/run-gtk-tests:
833         (TestRunner._setup_testing_environment):
834         * Scripts/webkitpy/port/gtk.py:
835         (GtkPort.setup_environ_for_server):
836
837 2015-10-20  Yoav Weiss  <yoav@yoav.ws>
838
839         Rename the PICTURE_SIZES flag to CURRENTSRC
840         https://bugs.webkit.org/show_bug.cgi?id=150275
841
842         Reviewed by Dean Jackson.
843
844         * Scripts/webkitperl/FeatureList.pm:
845
846 2015-10-19  Hunseop Jeong  <hs85.jeong@samsung.com>
847
848         Unreviewed, add myself to the committers list.
849
850         * Scripts/webkitpy/common/config/contributors.json:
851
852 2015-10-19  Alexey Proskuryakov  <ap@apple.com>
853
854         Add new EWS queues to bot watcher's dashboard
855         https://bugs.webkit.org/show_bug.cgi?id=150297
856
857         Reviewed by Darin Adler.
858
859         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
860         (BubbleQueueServer):
861
862 2015-10-19  ChangSeok Oh  <changseok.oh@collabora.com>
863
864         REGRESSION(r190262): User media unit test failures after r190262
865         https://bugs.webkit.org/show_bug.cgi?id=149580
866
867         Reviewed by Carlos Garcia Campos.
868
869         The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
870         So we do not need to skip them anymore.
871
872         * Scripts/run-gtk-tests:
873         (TestRunner): Deleted.
874
875 2015-10-19  Csaba Osztrogonác  <ossy@webkit.org>
876
877         Add historical addresses to contributors.json
878         https://bugs.webkit.org/show_bug.cgi?id=150227
879
880         Reviewed by Darin Adler.
881
882         * Scripts/webkitpy/common/config/contributors.json:
883
884 2015-10-18  Sungmann Cho  <sungmann.cho@navercorp.com>
885
886         [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
887         https://bugs.webkit.org/show_bug.cgi?id=150307
888
889         Reviewed by Brent Fulgham.
890
891         The DLL build rules have been changed to generate "{Name}Lib.DLL",
892         but these changes have not yet been applied to the Visual Studio builds.
893
894         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
895
896 2015-10-16  Andreas Kling  <akling@apple.com>
897
898         [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
899         <https://webkit.org/b/150153>
900
901         Unreviewed.
902
903         Just use simple arrays of LChar and UChar for this test instead of creating String
904         objects and then getting the characters8()/characters16() from them, since that
905         doesn't guarantee null-termination (the bug.)
906
907         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
908         (TestWebKitAPI::TEST):
909         (TestWebKitAPI::build): Deleted.
910
911 2015-10-16  Tim Horton  <timothy_horton@apple.com>
912
913         WebKit2.AutoLayoutIntegration API test is failing on some of the bots
914         https://bugs.webkit.org/show_bug.cgi?id=150255
915
916         Reviewed by Simon Fraser.
917
918         * Scripts/run-api-tests:
919         (runTest):
920         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
921         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
922         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
923         (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
924         (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
925         Don't set the layout size until after the load finishes and we're waiting
926         for the reply, so that there is no race between the new size coming in
927         and us waiting for it.
928
929 2015-10-16  Anders Carlsson  <andersca@apple.com>
930
931         WebEditingDelegate should be a formal protocol
932         https://bugs.webkit.org/show_bug.cgi?id=150254
933         <rdar://problem/23149847>
934
935         Reviewed by Dan Bernstein.
936
937         * DumpRenderTree/mac/EditingDelegate.h:
938         Conform to the WebEditingDelegate protocol.
939
940 2015-10-16  Tim Horton  <timothy_horton@apple.com>
941
942         Hook up autolayout intrinsic sizing for WKWebView
943         https://bugs.webkit.org/show_bug.cgi?id=150219
944         <rdar://problem/20016905>
945
946         Reviewed by Simon Fraser.
947
948         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
949         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
950         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
951         (-[AutoLayoutWKWebView load:expectingContentSize:]):
952         (-[AutoLayoutWKWebView expectContentSizeChange:]):
953         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
954         (TEST):
955         Add a variety of tests, including one which catches the bug that
956         the WebCore part of this patch fixes.
957
958 2015-10-15  Csaba Osztrogonác  <ossy@webkit.org>
959
960         Update the help message of --system-malloc
961         https://bugs.webkit.org/show_bug.cgi?id=150169
962
963         Reviewed by Geoffrey Garen.
964
965         * Scripts/webkitperl/FeatureList.pm:
966
967 2015-10-15  Youenn Fablet  <youenn.fablet@crf.canon.fr>
968
969         Update ImportExpectations according currently imported wpt tests
970         https://bugs.webkit.org/show_bug.cgi?id=150158
971
972         Reviewed by Chris Dumez.
973
974         * Scripts/webkitpy/w3c/test_downloader.py:
975         (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
976
977 2015-10-15  Eunmi Lee  <eunmi15.lee@samsung.com>
978
979         Unreviewed, Update my email address.
980
981         * Scripts/webkitpy/common/config/contributors.json:
982
983 2015-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
984
985         [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
986         https://bugs.webkit.org/show_bug.cgi?id=84960
987
988         Reviewed by Žan Doberšek.
989
990         * Scripts/run-gtk-tests:
991         (TestRunner): Unskip tests using SessionState.
992         * TestWebKitAPI/PlatformGTK.cmake: Add
993         WKPageCopySessionStateWithFiltering test.
994
995 2015-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
996
997         [GTK] Missing return value on TestWebExtensions.cpp:193
998         https://bugs.webkit.org/show_bug.cgi?id=149755
999
1000         Unreviewed. Add missing return value.
1001
1002         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1003         (permissionRequestCallback):
1004
1005 2015-10-14  Andy Estes  <aestes@apple.com>
1006
1007         [iOS] build-dumprendertree does not build ImageDiff
1008         https://bugs.webkit.org/show_bug.cgi?id=150152
1009
1010         Reviewed by Tim Horton.
1011
1012         run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
1013         On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
1014         as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
1015         WebKit.xcworkspace), tests that rely on image diffing won't work properly.
1016
1017         There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
1018         fine on that platform, and results in ImageDiff being built.
1019
1020         * Scripts/build-dumprendertree:
1021
1022 2015-10-14  Brent Fulgham  <bfulgham@apple.com>
1023
1024         [Win] Enforce launcher/library naming scheme
1025         https://bugs.webkit.org/show_bug.cgi?id=150124
1026
1027         Reviewed by Alex Christensen.
1028
1029         * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
1030         * MiniBrowser/win/CMakeLists.txt: Ditto.
1031         * TestWebKitAPI/PlatformWin.cmake: Ditto.
1032         * win/DLLLauncher/DLLLauncherMain.cpp:
1033         (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
1034         original {name}.dll.
1035
1036 2015-10-14  Andreas Kling  <akling@apple.com>
1037
1038         REGRESSION(r190882): Concatenating a character array and an empty string is broken.
1039         <https://webkit.org/b/150135>
1040
1041         Reviewed by Geoffrey Garen.
1042
1043         Add a new WTF API test that covers this issue.
1044
1045         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1046         (TestWebKitAPI::build):
1047         (TestWebKitAPI::TEST):
1048
1049 2015-10-14  Alex Christensen  <achristensen@webkit.org>
1050
1051         Add SPI for reloading without content blockers
1052         https://bugs.webkit.org/show_bug.cgi?id=150058
1053         rdar://problem/22742222
1054
1055         Reviewed by Sam Weinig.
1056
1057         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1058         (WTR::TestController::cocoaResetStateToConsistentValues):
1059         * WebKitTestRunner/mac/TestControllerMac.mm:
1060         (WTR::TestController::platformConfigureViewForTest):
1061
1062 2015-10-14  Mark Lam  <mark.lam@apple.com>
1063
1064         Rename some JSC option names to be more uniform.
1065         https://bugs.webkit.org/show_bug.cgi?id=150127
1066
1067         Reviewed by Geoffrey Garen.
1068
1069         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
1070         * Scripts/run-jsc-stress-tests:
1071
1072 2015-10-14  Anders Carlsson  <andersca@apple.com>
1073
1074         Change the bundle app cache APIs to take a page
1075         https://bugs.webkit.org/show_bug.cgi?id=150123
1076
1077         Reviewed by Sam Weinig.
1078
1079         Update APIs.
1080
1081         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1082         (WTR::InjectedBundle::beginTesting):
1083         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1084         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1085         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1086         (WTR::TestRunner::clearAllApplicationCaches):
1087         (WTR::TestRunner::clearApplicationCacheForOrigin):
1088         (WTR::TestRunner::setAppCacheMaximumSize):
1089         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
1090         (WTR::TestRunner::originsWithApplicationCache):
1091
1092 2015-10-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1093
1094         Update web-platform-tests tools to the latest revision
1095         https://bugs.webkit.org/show_bug.cgi?id=149645
1096
1097         Reviewed by Darin Adler.
1098
1099         Disabling git submodules information conversion to json install file for web-platform-tests.
1100         Disabling related python unit tests.
1101         The tools submodules contain submodules and the conversion tool does not support that yet.
1102
1103         Updating wpt launcher script to aling it with web-platform-test main script.
1104
1105         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1106         (main):
1107         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1108         (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
1109         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1110         (TestImporterTest.test_submodules_generation):
1111
1112 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1113
1114         More debug queue build fixing.
1115
1116         Preserve the build style in one more place. Changed mock build_style from "both"
1117         to "release", as we don't support testing both debug and release.
1118
1119         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1120         (MockCommitQueue.archive_last_test_results):
1121         (MockCommitQueue):
1122         (MockCommitQueue.build_style):
1123         (MockCommitQueue.did_pass_testing_ews):
1124         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1125         (PatchAnalysisTask._test):
1126         (PatchAnalysisTask._build_and_test_without_patch):
1127         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1128         (EarlyWarningSystemTest._default_expected_logs):
1129         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1130
1131 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1132
1133         More debug queue build fixing.
1134
1135         Add build_style argument to derived classes as well.
1136
1137         * Scripts/webkitpy/common/config/ports.py:
1138         (MacPort):
1139         (MacPort.run_webkit_tests_command):
1140         (WinPort.run_bindings_tests_command):
1141         (WinPort):
1142         (WinPort.run_webkit_tests_command):
1143         (GtkWK2Port.build_webkit_command):
1144         (GtkWK2Port):
1145         (GtkWK2Port.run_webkit_tests_command):
1146
1147 2015-10-13  Myles C. Maxfield  <mmaxfield@apple.com>
1148
1149         [iOS] Build fix
1150
1151         Unreviewed.
1152
1153         Mach-O section names are limited to 16 characters.
1154
1155         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1156         * DumpRenderTree/mac/DumpRenderTree.mm:
1157         (activateFontsIOS):
1158
1159 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1160
1161         Build fix for mac-debug EWS queue.
1162
1163         Unreviewed.
1164
1165         Pass --debug to run-webkit-tests.
1166
1167         While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
1168         will need to be substantially modified to work in EWS, so the dummy implementation
1169         was not helpful.
1170
1171         * Scripts/webkitpy/common/config/ports.py:
1172         (DeprecatedPort.run_javascriptcore_tests_command):
1173         (DeprecatedPort):
1174         (DeprecatedPort.run_webkit_tests_command):
1175         (DeprecatedPort.run_python_unittests_command):
1176         (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
1177         * Scripts/webkitpy/common/config/ports_mock.py:
1178         (MockPort.run_javascriptcore_tests_command):
1179         (MockPort):
1180         (MockPort.run_webkit_tests_command):
1181         (MockPort.run_bindings_tests_command):
1182         (MockPort.run_webkit_unit_tests_command): Deleted.
1183         * Scripts/webkitpy/tool/commands/download_unittest.py:
1184         * Scripts/webkitpy/tool/steps/runtests.py:
1185         (RunTests.run):
1186         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1187         (RunTestsTest.test_webkit_run_unit_tests):
1188         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1189         (StepsTest.test_runtests_args):
1190
1191 2015-10-13  Brent Fulgham  <bfulgham@apple.com>
1192
1193         [Win] Generate Crash Traces
1194         https://bugs.webkit.org/show_bug.cgi?id=150103
1195
1196         Reviewed by Daniel Bates.
1197
1198         We were using an exception filter to try to emit "#CRASHED" to stderr
1199         when a test program crashed. However, the modern Python implementation
1200         seems capable of recognizing crashes on its own. Furthermore, registering
1201         the exception handler was preventing the JIT debugger (NTSD) from
1202         automatically attaching to the crashing program, so we were not getting
1203         crash traces.
1204         
1205         * DumpRenderTree/win/DumpRenderTree.cpp:
1206         (main): Don't register an exception filter.
1207         (exceptionFilter): Deleted.
1208         * Scripts/webkitpy/common/system/crashlogs.py:
1209         (CrashLogs): Add another regular expression to handle a second crash trace
1210         syntax I encountered during testing.
1211         (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
1212         try the new one. The PID found by the new expression is in hexadecimal, so
1213         convert it to an integer before returning it.
1214         * Scripts/webkitpy/port/driver.py:
1215         (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
1216         the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
1217         check for "#CRASHED" after stripping off the EOL characters.
1218         * Scripts/webkitpy/port/win.py:
1219         (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
1220         invocation. This is apparently used to signal an event when the debugger is finished.
1221
1222 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1223
1224         Mac Debug and 32-bit queues should be separate
1225         https://bugs.webkit.org/show_bug.cgi?id=150092
1226
1227         Reviewed by Lucas Forschler.
1228
1229         * QueueStatusServer/config/queues.py:
1230         * QueueStatusServer/model/queues.py:
1231         (Queue._capitalize_after_dash):
1232         (Queue._caplitalize_after_dash): Deleted.
1233         * Scripts/webkitpy/common/config/ews.json:
1234
1235 2015-10-13  Sergio Villar Senin  <svillar@igalia.com>
1236
1237         [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
1238         https://bugs.webkit.org/show_bug.cgi?id=150085
1239
1240         Reviewed by Carlos Garcia Campos.
1241
1242         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1243
1244 2015-10-13  Sebastian Dröge  <sebastian@centricular.com>
1245
1246         Unreviewed, add myself to the committers list.
1247
1248         * Scripts/webkitpy/common/config/contributors.json:
1249
1250 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1251
1252         Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
1253         https://bugs.webkit.org/show_bug.cgi?id=149983
1254
1255         Reviewed by Dan Bates.
1256
1257         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1258         (BubbleQueueServer):
1259         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1260
1261 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1262
1263         Fix webkitpy tests after r190922.
1264
1265         * Scripts/webkitpy/common/config/ews.json:
1266         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1267         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1268
1269 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1270
1271         Add a Mac debug EWS queue
1272         https://bugs.webkit.org/show_bug.cgi?id=150069
1273
1274         Reviewed by Geoffrey Garen.
1275
1276         * QueueStatusServer/config/queues.py:
1277         * Scripts/webkitpy/common/config/ews.json:
1278         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1279         (AbstractEarlyWarningSystem):
1280         (AbstractEarlyWarningSystem.archive_last_test_results):
1281         (AbstractEarlyWarningSystem.build_style):
1282         (AbstractEarlyWarningSystem.refetch_patch):
1283         (AbstractEarlyWarningSystem.load_ews_classes):
1284
1285 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
1286
1287         [GTK] Update jhbuild's version of harfbuzz
1288         https://bugs.webkit.org/show_bug.cgi?id=149749
1289
1290         Reviewed by Martin Robinson.
1291
1292         Update harfbuzz to 0.9.35, following the lead of Debian Stable.
1293
1294         * gtk/jhbuild.modules: Updated details for harfbuzz.
1295
1296 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
1297
1298         [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
1299         https://bugs.webkit.org/show_bug.cgi?id=150026
1300
1301         Reviewed by Philippe Normand.
1302
1303         Backport upstream patch from gst-plugins-bad so that the right version
1304         of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
1305         gets compiled properly, avoiding crashes on runtime while running tests.
1306
1307         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
1308         * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
1309
1310 2015-10-11  Myles C. Maxfield  <mmaxfield@apple.com>
1311
1312         Test font-variant-* and font-feature-settings with mocked preinstalled fonts
1313         https://bugs.webkit.org/show_bug.cgi?id=149777
1314
1315         Reviewed by Simon Fraser.
1316
1317         Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
1318         to the list of tests to preinstall at startup time.
1319
1320         Also, update the generation of the 'name' table in the FontWithFeatures font.
1321
1322         * DumpRenderTree/mac/DumpRenderTree.mm:
1323         (allowedFontFamilySet):
1324         (activateTestingFonts):
1325         (activateFontsIOS):
1326         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1327         (Generator::generate):
1328         (Generator::appendCFFTable):
1329         (Generator::appendNameSubtable):
1330         (Generator::appendNAMETable):
1331         * FontWithFeatures/FontWithFeatures/main.cpp:
1332         (main):
1333         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1334         (WTR::allowedFontFamilySet):
1335         (WTR::activateFonts):
1336         * WebKitTestRunner/mac/TestControllerMac.mm:
1337         (WTR::allowedFontFamilySet):
1338
1339 2015-10-11  Jinyoung Hur  <hur.ims@navercorp.com>
1340
1341         Unreviewed. Add Jinyoung Hur as a committer. 
1342
1343         * Scripts/webkitpy/common/config/contributors.json:
1344
1345 2015-10-10  Dan Bernstein  <mitz@apple.com>
1346
1347         [iOS] Remove unnecessary iOS version checks
1348         https://bugs.webkit.org/show_bug.cgi?id=150002
1349
1350         Reviewed by Alexey Proskuryakov.
1351
1352         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1353         (-[HIDEventGenerator _createIOHIDEventType:]):
1354         (-[HIDEventGenerator _sendHIDEvent:]):
1355         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1356         * WebKitTestRunner/ios/UIKitSPI.h:
1357
1358 2015-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
1359
1360         Unreviewed, rolling out r190689
1361         https://bugs.webkit.org/show_bug.cgi?id=149992
1362
1363         Fixed in other repository.
1364
1365         Reverted changesets:
1366
1367         "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
1368         https://bugs.webkit.org/show_bug.cgi?id=149897
1369
1370 2015-10-09  Brian Burg  <bburg@apple.com>
1371
1372         Teach webkitperl how to figure out IOS versions from the SDK
1373         https://bugs.webkit.org/show_bug.cgi?id=149963
1374
1375         Reviewed by Daniel Bates.
1376
1377         It should be easier to check the major and minor version of IOS SDKs.
1378
1379         * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
1380         * Scripts/webkitdirs.pm:
1381         (splitVersionString): Added.
1382         (determineOSXVersion): Use splitVersionString.
1383         (determineIOSVersion): Added. Look at the SDK version and make a tuple.
1384         (iosVersion): Added.
1385
1386 2015-10-09  Simon Fraser  <simon.fraser@apple.com>
1387
1388         [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
1389         https://bugs.webkit.org/show_bug.cgi?id=149960
1390
1391         Reviewed by Tim Horton.
1392         
1393         Use adoptWK(), and null out some members (file is not using ARC).
1394
1395         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1396         (UIScriptContext::uiScriptComplete):
1397         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1398         (-[TestRunnerWKWebView dealloc]):
1399
1400 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1401
1402         Remove ENABLE_SUID_SANDBOX_LINUX cruft
1403         https://bugs.webkit.org/show_bug.cgi?id=149954
1404
1405         Reviewed by Darin Adler.
1406
1407         * Scripts/webkitperl/FeatureList.pm:
1408
1409 2015-10-09  Daniel Bates  <dabates@apple.com>
1410
1411         Make iOS builders generate debug information in a separate dSYM file
1412         https://bugs.webkit.org/show_bug.cgi?id=149696
1413
1414         Reviewed by Darin Adler.
1415
1416         Similar to the Mac builders, the iOS builders should write debug information
1417         into a separate dSYM file instead of including such information in the binary
1418         itself (default Xcode behavior)
1419
1420         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1421         (CompileWebKit.start):
1422
1423 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1424
1425         Fix webkitpy tests after r190779
1426         https://bugs.webkit.org/show_bug.cgi?id=149949
1427
1428         Reviewed by Ryosuke Niwa.
1429
1430         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1431         (BenchmarkResults.format):
1432         (BenchmarkResults._format_values):
1433
1434 2015-10-08  Dewei Zhu  <dewei_zhu@apple.com>
1435
1436         Extend run-benchmark script to support human-readable results conversion.
1437         https://bugs.webkit.org/show_bug.cgi?id=149944
1438
1439         Reviewed by Ryosuke Niwa.
1440
1441         Add '--read-results-json' and '--no-adjust-unit' options.
1442         '--read-results-json' option converts result file to human readable format.
1443         '--no-adjust-unit' option skips scientific notation convertion.
1444         '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
1445
1446         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1447         (BenchmarkResults.format):
1448         (BenchmarkResults._format_tests):
1449         (BenchmarkResults._format_values):
1450         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1451         (BenchmarkRunner.__init__):
1452         (BenchmarkRunner._run_benchmark):
1453         (BenchmarkRunner._dump):
1454         (BenchmarkRunner.show_results):
1455         (BenchmarkRunner._show_results): Deleted.
1456         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1457         (parse_args):
1458         (start):
1459
1460 2015-10-08  Daniel Bates  <dabates@apple.com>
1461
1462         Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
1463         https://bugs.webkit.org/show_bug.cgi?id=149945
1464
1465         Reviewed by Dan Bernstein.
1466
1467         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
1468         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
1469         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1470         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1471         (WebKitBuildbot):
1472         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1473         (table.queue-grid tr.platform.ios-9 img.logo):
1474
1475 2015-10-08  Daniel Bates  <dabates@apple.com>
1476
1477         Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
1478         https://bugs.webkit.org/show_bug.cgi?id=149943
1479
1480         Reviewed by Dan Bernstein.
1481
1482         Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
1483         teach build-webkit to install them when building for iOS device using the public iOS SDK. 
1484
1485         * Scripts/build-webkit:
1486
1487 2015-10-08  Daniel Bates  <dabates@apple.com>
1488
1489         Add LLVM binaries for iOS 9 device
1490         https://bugs.webkit.org/show_bug.cgi?id=149913
1491
1492         Reviewed by Filip Pizlo.
1493
1494         Implement support for building LLVM for ARM64-based iOS devices.
1495
1496         * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
1497         * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
1498         an existing build earlier in the file such that remove previously built
1499         libraries before building/copying new ones (if applicable).
1500         (fileContains): Moved function outside of if-block.
1501         (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
1502         (buildLLVM): Added. Extracted machinery to build LLVM into this function and
1503         added logic to build LLVM for ARM64-based iOS devices.
1504         (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
1505         LLVM into the WebKitBuild directory.
1506
1507 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
1508
1509         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
1510         https://bugs.webkit.org/show_bug.cgi?id=149848
1511
1512         Reviewed by Darin Adler.
1513
1514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1515
1516 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
1517
1518         [Win] Support 64-bit Build and Testing
1519         https://bugs.webkit.org/show_bug.cgi?id=149904
1520
1521         Reviewed by Daniel Bates.
1522
1523         Extend our existing scripts to support 64-bit build and test operations on
1524         Windows.
1525
1526         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
1527         Windows always builds the whole stack.
1528         * Scripts/webkit-build-directory: Add an option to return the location of
1529         the executable files produced by a specific configuration. This change is
1530         actually useful for Gtk and EFL, too.
1531         * Scripts/webkitdirs.pm:
1532         (executableProductDir): Added. This function appends the proper binary
1533         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
1534         (jscProductDir): Use the new 'executableProductDir' method.
1535         (setPathForRunningWebKitApp): Ditto.
1536         (runSafari): Ditto.
1537         (runMiniBrowser): Ditto.
1538         * Scripts/webkitpy/port/factory.py:
1539         (configuration_options): Add a 64-bit option, used on Windows to specify
1540         which binary target should be used for testing.
1541         * Scripts/webkitpy/port/win.py:
1542         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
1543         processes when needed.
1544         (WinPort._build_path): Add the correct binary target path to _build_path.
1545         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
1546         64-bit paths for 64-bit tests.
1547         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
1548         NTSD debugger does not understand this argument.
1549
1550 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
1551
1552         Test font-variant-* and font-feature-settings with TrueType fonts
1553         https://bugs.webkit.org/show_bug.cgi?id=149776
1554
1555         Reviewed by Simon Fraser.
1556
1557         This test extends our existing FontWithFeatures project to be able to generate a
1558         TrueType font. This font is conceptually similar as the existing OpenType font,
1559         except the feature -> character mapping is different.
1560
1561         The font itself only supports the following characters:
1562         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1563         However, the shape of these letters are either an X or a check mark.
1564         The letter "A" always is a check mark.
1565         The letter "B" always is an X.
1566         Each font feature has an letter associated with it. When the font feature is enabled,
1567         that letter is shown as a check mark. For example, when
1568         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
1569         mark.
1570
1571         Here are the mappings of font features to letters:
1572         kLigaturesType / kCommonLigaturesOnSelector: C
1573         kLigaturesType / kContextualLigaturesOnSelector: D
1574         kLigaturesType / kRareLigaturesOnSelector: G
1575         kLigaturesType / kHistoricalLigaturesOnSelector: I
1576         kContextualAlternatesType / kContextualAlternatesOnSelector: L
1577         kVerticalPositionType / kInferiorsSelector: O
1578         kVerticalPositionType / kSuperiorsSelector: P
1579         kLowerCaseType / kLowerCaseSmallCapsSelector: S
1580         kUpperCaseType / kUpperCaseSmallCapsSelector: V
1581         kLowerCaseType / kLowerCasePetiteCapsSelector: T
1582         kUpperCaseType / kUpperCasePetiteCapsSelector: W
1583         kLetterCaseType / 14: Y
1584         kStyleOptionsType / kTitlingCapsSelector: a
1585         kNumberCaseType / kUpperCaseNumbersSelector: c
1586         kNumberCaseType / kLowerCaseNumbersSelector: d
1587         kNumberSpacingType / kProportionalNumbersSelector: f
1588         kNumberSpacingType / kMonospacedNumbersSelector: g
1589         kFractionsType / kDiagonalFractionsSelector: i
1590         kFractionsType / kVerticalFractionsSelector: j
1591         kVerticalPositionType / kOrdinalsSelector: Q
1592         kTypographicExtrasType / kSlashedZeroOnSelector: k
1593         kLigaturesType / kHistoricalLigaturesOnSelector: K
1594         kCharacterShapeType / kJIS1978CharactersSelector: m
1595         kCharacterShapeType / kJIS1983CharactersSelector: n
1596         kCharacterShapeType / kJIS1990CharactersSelector: o
1597         kCharacterShapeType / kJIS2004CharactersSelector: p
1598         kCharacterShapeType / kSimplifiedCharactersSelector: q
1599         kCharacterShapeType / kTraditionalCharactersSelector: r
1600         kTextSpacingType / kMonospacedTextSelector: t
1601         kTextSpacingType / kProportionalTextSelector: u
1602         kRubyKanaType / kRubyKanaOnSelector: v
1603
1604         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
1605         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1606         (CFFBuilder::moveTo):
1607         (CFFBuilder::lineTo):
1608         (GLYFBuilder::GLYFBuilder):
1609         (GLYFBuilder::takeResult):
1610         (GLYFBuilder::moveTo):
1611         (GLYFBuilder::lineTo):
1612         (GLYFBuilder::closePath):
1613         (GLYFBuilder::writePoint):
1614         (GLYFBuilder::append16):
1615         (generateBoxCharString):
1616         (generateCheckCharString):
1617         (generateXCharString):
1618         (itemForGlyph):
1619         (Generator::generate):
1620         (Generator::insertSelector):
1621         (Generator::insertFeature):
1622         (Generator::generateFeatureDescription):
1623         (Generator::appendCFFTable):
1624         (Generator::appendGLYFTable):
1625         (Generator::appendLOCATable):
1626         (Generator::appendFEATTable):
1627         (Generator::appendMetamorphosisChain):
1628         (Generator::appendMORXTable):
1629         (Generator::appendHEADTable):
1630         (Generator::appendHMTXTable):
1631         (Generator::appendNameSubtable):
1632         (Generator::append2ByteASCIIString):
1633         (Generator::appendNAMETable):
1634         (generateFont):
1635         (CFFBuilder::curveToCubic): Deleted.
1636         (charStringForGlyph): Deleted.
1637         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1638         * FontWithFeatures/FontWithFeatures/main.cpp:
1639         (constructFontWithTrueTypeFeature):
1640         (constructFontWithOpenTypeFeature):
1641         (drawText):
1642         (main):
1643         (drawTextWithFeature): Deleted.
1644
1645 2015-10-07  Commit Queue  <commit-queue@webkit.org>
1646
1647         Unreviewed, rolling out r190572, r190593, r190594, and
1648         r190639.
1649         https://bugs.webkit.org/show_bug.cgi?id=149897
1650
1651         Breaks Mavericks build (Requested by litherum on #webkit).
1652
1653         Reverted changesets:
1654
1655         "Allow WKRetainPtrs to be used as keys in hashing data
1656         structures"
1657         https://bugs.webkit.org/show_bug.cgi?id=149762
1658         http://trac.webkit.org/changeset/190572
1659
1660         "REGRESSION(189668?): http/tests/notifications/events.html
1661         flakily asserts or times out"
1662         https://bugs.webkit.org/show_bug.cgi?id=149218
1663         http://trac.webkit.org/changeset/190593
1664
1665         "Prospective Mavericks build fix."
1666         http://trac.webkit.org/changeset/190594
1667
1668         "Post-review cleanup after r190572."
1669         http://trac.webkit.org/changeset/190639
1670
1671 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1672
1673         [GTK] Add autocleanups
1674         https://bugs.webkit.org/show_bug.cgi?id=149588
1675
1676         Reviewed by Darin Adler.
1677
1678         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
1679         (AutocleanupsTest::create):
1680         (AutocleanupsTest::testWebProcessAutocleanups):
1681         (registerTests):
1682         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1683         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
1684         (testUIProcessAutocleanups):
1685         (testWebProcessAutocleanups):
1686         (beforeAll):
1687         (afterAll):
1688
1689 2015-10-06  Brian Burg  <bburg@apple.com>
1690
1691         Unreviewed, try to fix the iOS 8 build after r190368.
1692
1693         On older versions, IOHIDEventCreateForceEvent is not available.
1694
1695         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1696         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
1697
1698 2015-10-06  Keith Miller  <keith_miller@apple.com>
1699
1700         Add gmalloc option to run-javascriptcore-tests.
1701         https://bugs.webkit.org/show_bug.cgi?id=149858
1702
1703         Reviewed by Geoffrey Garen.
1704
1705         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
1706         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
1707
1708         * Scripts/run-javascriptcore-tests:
1709
1710 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
1711
1712         Post-review cleanup after r190572.
1713
1714         Unreviewed.
1715
1716         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
1717
1718 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
1719
1720         [Win] Unreviewed build correction.
1721
1722         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
1723         are soft-linked at runtime.
1724
1725 2015-10-06  Keith Miller  <keith_miller@apple.com>
1726
1727         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
1728         https://bugs.webkit.org/show_bug.cgi?id=149815
1729
1730         Reviewed by Filip Pizlo.
1731
1732         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
1733         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
1734         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
1735         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
1736         so should just use one test runner.
1737
1738         * Scripts/run-javascriptcore-tests:
1739         (runJSCStressTests):
1740         (runMozillaTests): Deleted.
1741         (defaultJsDriverArgsForMozillaTests): Deleted.
1742         * Scripts/run-jsc-stress-tests:
1743
1744 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
1745
1746         [GTK] Make update-webkitgtk-libs work behind firewall
1747
1748         update-webkitgtk-libs can work behind a firewall with changes to
1749         a few packages.  Where outbound git and active FTP connections
1750         fail, using http protocol succeeds.  Most packages are
1751         already accessed using http.
1752
1753         https://bugs.webkit.org/show_bug.cgi?id=148941
1754
1755         Reviewed by Martin Robinson.
1756
1757         Tools
1758         * gtk/jhbuild.modules:
1759             Replace git URLs with http.  Remove no longer used ftp repositories.
1760             Update argument for libxml2's autogen.sh script (--without-python
1761             is ignored; --with-python=no is correct).
1762         * jhbuild/jhbuild-wrapper:
1763             Instead of connecting to git://git.gnome.org/jhbuild, connect to
1764             http://git.gnome.org/browse/jhbuild.
1765
1766 2015-10-06  Daniel Bates  <dbates@webkit.org>
1767
1768         Enable XSLT when building WebKit for iOS using the public iOS SDK
1769         https://bugs.webkit.org/show_bug.cgi?id=149827
1770
1771         Reviewed by Alexey Proskuryakov.
1772
1773         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
1774         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
1775         run this script before building WebKit for iOS or the build will fail because one or more XSLT
1776         headers cannot be found.
1777
1778         * Scripts/configure-xcode-for-ios-development:
1779         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
1780
1781 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1782
1783         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
1784         https://bugs.webkit.org/show_bug.cgi?id=149218
1785
1786         Reviewed by Alexey Proskuryakov.
1787
1788         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
1789         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
1790         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
1791         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
1792         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
1793         WebNotificationProvider must be updated to appropriately handle multiple
1794         WKNotificationManagerRefs in flight at the same time.
1795
1796         * WebKitTestRunner/WebNotificationProvider.cpp:
1797         (WTR::WebNotificationProvider::~WebNotificationProvider):
1798         (WTR::WebNotificationProvider::showWebNotification):
1799         (WTR::WebNotificationProvider::closeWebNotification):
1800         (WTR::WebNotificationProvider::addNotificationManager):
1801         (WTR::WebNotificationProvider::removeNotificationManager):
1802         (WTR::WebNotificationProvider::simulateWebNotificationClick):
1803         (WTR::WebNotificationProvider::reset):
1804         * WebKitTestRunner/WebNotificationProvider.h:
1805
1806 2015-10-05  Daniel Bates  <dabates@apple.com>
1807
1808         Disable Bitcode when building for iOS device
1809         https://bugs.webkit.org/show_bug.cgi?id=149818
1810
1811         Reviewed by Alexey Proskuryakov.
1812
1813         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
1814         when building for iOS device.
1815
1816         * Scripts/webkitdirs.pm:
1817         (XcodeOptions):
1818
1819 2015-10-05  Daniel Bates  <dabates@apple.com>
1820
1821         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
1822         https://bugs.webkit.org/show_bug.cgi?id=140828
1823         <rdar://problem/19520599>
1824
1825         Reviewed by Alexey Proskuryakov.
1826
1827         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
1828         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
1829         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
1830         to build-webkit.
1831
1832         * Scripts/webkitdirs.pm:
1833         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
1834         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
1835         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
1836         (hasIOSDevelopmentCertificate): Added.
1837
1838 2015-10-05  Daniel Bates  <dabates@apple.com>
1839
1840         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1841         https://bugs.webkit.org/show_bug.cgi?id=149766
1842
1843         Reviewed by Alexey Proskuryakov.
1844
1845         Create network storage testing session on iOS.
1846
1847         Currently we do not create a network storage testing session on iOS. A network storage testing session always
1848         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
1849         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
1850         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
1851         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
1852         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
1853         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
1854         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
1855         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
1856
1857         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1858         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
1859         returns a non-null pointer to a cookie store.
1860
1861         * DumpRenderTree/mac/DumpRenderTree.mm:
1862         (prepareConsistentTestingEnvironment):
1863
1864 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1865
1866         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
1867         available.
1868
1869         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1870         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1871
1872 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1873
1874         Allow WKRetainPtrs to be used as keys in hashing data structures
1875         https://bugs.webkit.org/show_bug.cgi?id=149762
1876
1877         Reviewed by Anders Carlsson.
1878
1879         * TestWebKitAPI/PlatformGTK.cmake:
1880         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1881         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
1882         (TestWebKitAPI::TEST):
1883
1884 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1885
1886         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
1887         available, and tidy up the #ifdefs in the UIKitSPI header.
1888
1889         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1890         (-[HIDEventGenerator _sendHIDEvent:]):
1891         * WebKitTestRunner/ios/UIKitSPI.h:
1892
1893 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
1894
1895         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
1896         https://bugs.webkit.org/show_bug.cgi?id=149792
1897
1898         Reviewed by Martin Robinson.
1899
1900         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
1901         for WebKitTestRunner multiple times.
1902
1903 2015-10-04  Daniel Bates  <dabates@apple.com>
1904
1905         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
1906         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1907
1908         For now, support calling build-layouttestrelay without --ios-simulator so long
1909         as we are building on a Mac.
1910
1911         * Scripts/build-layouttestrelay:
1912
1913 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1914
1915         Support Trac 1.0.x XML timeline link format
1916         https://bugs.webkit.org/show_bug.cgi?id=149786
1917
1918         Reviewed by Lucas Forschler.
1919
1920         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1921         (Trac.prototype._convertCommitInfoElementToObject):
1922
1923 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1924
1925         Fix some errors on bot watcher's dashboard
1926         https://bugs.webkit.org/show_bug.cgi?id=149789
1927
1928         Reviewed by Lucas Forschler.
1929
1930         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1931         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
1932         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
1933
1934 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
1935
1936         Bot watcher's dashboard builders should turn yellow when svn fails
1937         https://bugs.webkit.org/show_bug.cgi?id=149791
1938
1939         Reviewed by Lucas Forschler.
1940
1941         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1942         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
1943         (BuildbotBuilderQueueView.prototype.update):
1944
1945 2015-10-02  Daniel Bates  <dabates@apple.com>
1946
1947         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
1948         https://bugs.webkit.org/show_bug.cgi?id=149769
1949
1950         Reviewed by Alexey Proskuryakov.
1951
1952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
1953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
1954         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1955         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1956         (WebKitBuildbot):
1957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1958         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
1959
1960 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1961
1962         REGRESSION(r190370): Speedometer spits out an extra console message
1963         https://bugs.webkit.org/show_bug.cgi?id=149720
1964
1965         Unreviewed. Temporarily ignore the console error message.
1966
1967         * Scripts/webkitpy/performance_tests/perftest.py:
1968         (PerfTest._filter_output):
1969
1970 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
1971
1972         Provide "--no-ninja" option to avoid using Ninja
1973         https://bugs.webkit.org/show_bug.cgi?id=149757
1974
1975         Reviewed by Alex Christensen.
1976
1977         Add a new command line argument understood by webkitdirs.pm so
1978         that we can conditionally avoid using Ninja. This is an
1979         'opt-out' argument, so no existing Ninja users should be affected.
1980         
1981         * Scripts/webkitdirs.pm:
1982         (canUseNinja): Check for option and block ninja if present.
1983
1984 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
1985
1986         Flakiness dashboard should support OS X El Capitan
1987         https://bugs.webkit.org/show_bug.cgi?id=149648
1988
1989         Reviewed by Alexey Proskuryakov.
1990
1991         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
1992
1993 2015-10-02  Daniel Bates  <dabates@apple.com>
1994
1995         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
1996         (https://bugs.webkit.org/show_bug.cgi?id=149753)
1997
1998         For now, pass --ios-simulator.
1999
2000         * Scripts/webkitpy/port/ios.py:
2001         (IOSSimulatorPort._build_relay):
2002
2003 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
2004
2005         Remove a "nullable" that breaks the iOS 8 build.
2006
2007         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2008         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
2009
2010 2015-10-02  Daniel Bates  <dabates@apple.com>
2011
2012         LayoutTestRelay is not built and archived when building for iOS Simulator
2013         https://bugs.webkit.org/show_bug.cgi?id=149753
2014
2015         Reviewed by Alexey Proskuryakov and Andy Estes.
2016
2017         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
2018         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
2019         product archive when building for iOS Simulator, respectively.
2020
2021         * BuildSlaveSupport/built-product-archive:
2022         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
2023         differentiate between iOS device and iOS Simulator platforms.
2024         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
2025         from determineWebKitBuildDirectories() into this function so that it can be used by both
2026         determineWebKitBuildDirectories() and archiveBuiltProduct().
2027         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
2028         webkitBuildDirectoryForConfigurationAndPlatform().
2029         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
2030         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
2031         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
2032         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
2033         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
2034         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
2035         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
2036         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
2037         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
2038         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
2039         * Scripts/build-layouttestrelay:
2040             - Remove unnecessary include of Perl module POSIX.
2041             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
2042         * Scripts/build-webkit:
2043             - Invoke script build-layouttestrelay when building for iOS Simulator.
2044
2045 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
2046
2047         [Win] Unreviewed test fix.
2048
2049         You cannot run 'run-webkit-tests' from the command line because it does not know
2050         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
2051         because they explicitly set use the 'root' argument to provide the full path to
2052         the test binaries.
2053
2054         * Scripts/webkitpy/port/win.py:
2055         (WinPort._build_path): Added.
2056
2057 2015-10-02  Alex Christensen  <achristensen@webkit.org>
2058
2059         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
2060         https://bugs.webkit.org/show_bug.cgi?id=149430
2061         rdar://problem/22742222
2062
2063         Reviewed by Geoffrey Garen.
2064
2065         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2066         (WTR::TestController::cocoaResetStateToConsistentValues):
2067         * WebKitTestRunner/mac/TestControllerMac.mm:
2068         (WTR::TestController::platformConfigureViewForTest):
2069         Test what happens when you disable content blockers from the SPI.
2070
2071 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2072
2073         [Win] Unreviewed build fix for run-api-tests
2074
2075         * Scripts/run-api-tests:
2076         (testToolPaths): Windows run needs to specify the binary path.
2077
2078 2015-10-01  Daniel Bates  <dabates@apple.com>
2079
2080         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
2081         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2082
2083         Following r190424 we can now rely on webkit-build-directory to return the path to
2084         the correct configuration-specific build directory on Windows.
2085
2086         * BuildSlaveSupport/built-product-archive:
2087         (archiveBuiltProduct):
2088
2089 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2090
2091         [Win] Unreviewed build fix.
2092
2093         * Scripts/webkitdirs.pm:
2094         (setupAppleWinEnv): Use 64-bit build tools if available
2095
2096 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2097
2098         [Win] Fix TestWebKitAPI build under CMake.
2099
2100         Reviewed by Alex Christensen.
2101
2102         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
2103         for Psapi.lib.
2104
2105 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2106
2107         [Win] Fix behavior of webkit-build-directory script
2108         https://bugs.webkit.org/show_bug.cgi?id=149718
2109
2110         Reviewed by Alex Christensen.
2111
2112         * Scripts/webkitdirs.pm:
2113         (determineConfigurationProductDir): Do not include the binary
2114         sub-directory in the configuration product directory output.
2115         (jscProductDir): Append correct binary path for Windows build.
2116         (setPathForRunningWebKitApp): Include properly binary subdirectories.
2117         (runSafari): Update for revised productDir behavior.
2118         (runMiniBrowser): Ditto.
2119
2120 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
2121
2122         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
2123         use iOS SDK, like with all the others.
2124
2125         * Scripts/build-webkit:
2126
2127 2015-10-01  Daniel Bates  <dabates@apple.com>
2128
2129         Attempt to fix the iOS 9 Simulator testers
2130
2131         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
2132         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
2133         LayoutTestRelay when building for iOS Simulator.
2134
2135         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2136         * Scripts/build-webkit:
2137
2138 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2139
2140         [GTK] Websites with invalid auth header keep loading forever
2141         https://bugs.webkit.org/show_bug.cgi?id=149710
2142
2143         Reviewed by Martin Robinson.
2144
2145         Add test case to check that we can authenticate sites with an
2146         empty realm.
2147
2148         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2149         (testWebViewAuthenticationEmptyRealm):
2150         (serverCallback):
2151         (beforeAll):
2152
2153 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
2154
2155         [Mac] Make run-api-tests work with System Integrity Protection
2156         https://bugs.webkit.org/show_bug.cgi?id=149711
2157         rdar://problem/22928202
2158
2159         Reviewed by Dan Bernstein.
2160
2161         * Scripts/run-api-tests:
2162         (runTest):
2163         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
2164
2165 2015-10-01  Daniel Bates  <dabates@apple.com>
2166
2167         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
2168         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2169
2170         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
2171         For now, use the path to the top-level WebKit build directory instead of using the configuration-
2172         specific build directory.
2173
2174         * BuildSlaveSupport/built-product-archive:
2175         (archiveBuiltProduct):
2176
2177 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
2178
2179         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
2180         https://bugs.webkit.org/show_bug.cgi?id=145837
2181
2182         Reviewed by Philippe Normand.
2183
2184         * efl/jhbuild.modules:
2185         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
2186         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
2187
2188 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2189
2190         Unreviewed. Fix the iOS build after r190407.
2191
2192         * WebKitTestRunner/ios/IOKitSPI.h:
2193
2194 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2195
2196         Implement keyboard event sending for iOS in WebKitTestRunner
2197         https://bugs.webkit.org/show_bug.cgi?id=149676
2198
2199         Reviewed by Simon Fraser.
2200
2201         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
2202         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
2203         allows us to run code when the keyboard is shown or hidden.
2204
2205         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
2206         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2207         (WTR::UIScriptController::setDidShowKeyboardCallback):
2208         (WTR::UIScriptController::didShowKeyboardCallback):
2209         (WTR::UIScriptController::setDidHideKeyboardCallback):
2210         (WTR::UIScriptController::didHideKeyboardCallback):
2211         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
2212         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
2213         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
2214         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2215         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2216         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2217         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
2218                 the notifications that the keyboard has been raised or lowered.
2219         (-[TestRunnerWKWebView _keyboardDidShow:]):
2220         (-[TestRunnerWKWebView _keyboardDidHide:]):
2221         * WebKitTestRunner/ios/HIDEventGenerator.h:
2222         * WebKitTestRunner/ios/HIDEventGenerator.m:
2223         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
2224         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
2225         (hidUsageCodeForCharacter): Ditto.
2226         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
2227                 a keyDown event in WebKit.
2228         * WebKitTestRunner/ios/IOKitSPI.h:
2229         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2230
2231 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2232
2233         Unreviewed, rolling out r190399.
2234
2235         Tests are still failing even after r190362
2236
2237         Reverted changeset:
2238
2239         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
2240         http://trac.webkit.org/changeset/190399
2241
2242 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
2243
2244         [jhbuild] switch to new upstream usrsctp library
2245         https://bugs.webkit.org/show_bug.cgi?id=149494
2246
2247         Reviewed by Philippe Normand.
2248
2249         * efl/jhbuild.modules:
2250         * gtk/jhbuild.modules:
2251
2252 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2253
2254         Unreviewed. Unskip GTK+ user media unit tests after r190362.
2255
2256         They should pass now.
2257
2258         * Scripts/run-gtk-tests:
2259         (TestRunner):
2260
2261 2015-09-30  Daniel Bates  <dabates@apple.com>
2262
2263         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2264         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2265
2266         * BuildSlaveSupport/built-product-archive:
2267         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
2268         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
2269
2270 2015-09-30  Daniel Bates  <dabates@apple.com>
2271
2272         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2273         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2274
2275         Actually, we need to pass --configuration to script webkit-build-directory to have
2276         it return the path to the configuration-specific build directory.
2277
2278         * BuildSlaveSupport/built-product-archive:
2279         (determineWebKitBuildDirectories):
2280
2281 2015-09-30  Daniel Bates  <dabates@apple.com>
2282
2283         built-product-archive archives incorrect build directory for iOS port
2284         https://bugs.webkit.org/show_bug.cgi?id=149695
2285
2286         Reviewed by Darin Adler.
2287
2288         Fixes an issue where the script built-product-archive archives a non-existent
2289         build directory for the iOS port. Without loss of generality, the script assumes
2290         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
2291         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
2292
2293         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
2294         to determine the top-level build directory and computes the configuration-specific
2295         build directory to be the concatenation of the the top-level build directory and
2296         the configuration (e.g. Release). This is incorrect. Instead we should call
2297         webkit-build-directory omitting the flag --top-level to compute the path to the
2298         configuration-specific build directory.
2299
2300         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
2301         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
2302         its purpose and added global variable _configurationBuildDirectory to store the path
2303         to the configuration-specific build directory. Ensure that we have a non-empty string
2304         for both the top-level and configuration-specific build directories.
2305         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
2306         Compute the configuration-specific build directory and store it in the global variable
2307         _configurationBuildDirectory.
2308         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
2309         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
2310         as needed.
2311         (determineWebKitBuildDirectory): Deleted.
2312
2313 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
2314
2315         [EFL] css3/device-adapt/* tests failed after r190335.
2316         https://bugs.webkit.org/show_bug.cgi?id=149655
2317
2318         Reviewed by Simon Fraser.
2319
2320         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2321         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
2322
2323         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2324         (WTR::shouldUseFixedLayout):
2325
2326 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
2327
2328         Extend JetStream timeout for slow devices.
2329
2330         Reviewed by Chris Dumez.
2331
2332         Extend JetStream timeout to 20 minutes.
2333
2334         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2335
2336 2015-09-30  Daniel Bates  <dabates@apple.com>
2337
2338         Rename iOS builders/testers to include version
2339         https://bugs.webkit.org/show_bug.cgi?id=149685
2340
2341         Reviewed by Simon Fraser.
2342
2343         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
2344         make it clear to a reader the version of iOS these builders/testers are using.
2345
2346         * BuildSlaveSupport/build.webkit.org-config/config.json:
2347         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2348
2349 2015-09-30  Daniel Bates  <dabates@apple.com>
2350
2351         Add iOS criterion for triggering a build
2352         https://bugs.webkit.org/show_bug.cgi?id=149679
2353
2354         Rubber-stamped by Alexey Proskuryakov.
2355
2356         First pass at defining criterion for triggering an iOS build.
2357
2358         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2359         (_should_file_trigger_build):
2360         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2361         (ShouldBuildTest):
2362         (ShouldBuildTest.test_should_build):
2363
2364 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2365
2366         [iOS] Allow tests to generate user gestures for UI testing
2367         https://bugs.webkit.org/show_bug.cgi?id=149653
2368
2369         Reviewed by Tim Horton.
2370
2371         Expose functionality in UIScriptController to allow for testing single- and double-tap,
2372         and to listen for completion of scrolling and zooming in the WKWebView.
2373         
2374         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
2375         which hides the complexity of creating these events. Event dispatch is asynchronous.
2376         We detect when the last event has been handled by dispatching a vendor-specific event,
2377         which is detected via -_handleHIDEvent: in our UIApplication subclass.
2378         
2379         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
2380         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
2381         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
2382         single and double taps.
2383         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
2384         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
2385         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
2386         (UIScriptContext::unregisterCallback):
2387         (UIScriptContext::callbackWithID):
2388         (UIScriptContext::fireCallback):
2389         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
2390         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2391         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
2392         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
2393         (WTR::UIScriptController::setDidEndZoomingCallback):
2394         (WTR::UIScriptController::didEndZoomingCallback):
2395         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
2396         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
2397         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2398         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2399         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2400         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2401         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
2402         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2403         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
2404         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
2405         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
2406         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
2407         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2408         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
2409         (simpleDragCurve):
2410         (calculateNextLocation):
2411         (delayBetweenMove):
2412         (+[HIDEventGenerator sharedHIDEventGenerator]):
2413         (+[HIDEventGenerator nextEventCallbackID]):
2414         (-[HIDEventGenerator init]):
2415         (-[HIDEventGenerator _createIOHIDEventType:]):
2416         (-[HIDEventGenerator _sendHIDEvent:]):
2417         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
2418         (-[HIDEventGenerator _updateTouchPoints:count:]):
2419         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
2420         (-[HIDEventGenerator touchDown:touchCount:]):
2421         (-[HIDEventGenerator touchDown:]):
2422         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
2423         (-[HIDEventGenerator liftUp:touchCount:]):
2424         (-[HIDEventGenerator liftUp:]):
2425         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
2426         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2427         (-[HIDEventGenerator tap:completionBlock:]):
2428         (-[HIDEventGenerator doubleTap:completionBlock:]):
2429         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
2430         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2431         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
2432         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
2433         (-[HIDEventGenerator markerEventReceived:]):
2434         * WebKitTestRunner/ios/IOKitSPI.h: Added.
2435         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2436         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2437         (WTR::globalToContentCoordinates):
2438         (WTR::UIScriptController::singleTapAtPoint):
2439         (WTR::UIScriptController::doubleTapAtPoint):
2440         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2441         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2442         * WebKitTestRunner/ios/mainIOS.mm:
2443         (-[WebKitTestRunnerApp _handleHIDEvent:]):
2444
2445 2015-09-30  Dana Burkart  <dburkart@apple.com>
2446
2447         git-add-reviewer should trim trailing spaces/newlines
2448         https://bugs.webkit.org/show_bug.cgi?id=149513
2449
2450         Reviewed by Darin Adler.
2451
2452         * Scripts/git-add-reviewer:
2453         (nonInteractive):
2454
2455 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
2456
2457         REGRESSION(r190262): User media unit test failures after r190262
2458         https://bugs.webkit.org/show_bug.cgi?id=149580
2459
2460         Reviewed by Darin Adler.
2461
2462         * WebKitTestRunner/TestController.cpp:
2463         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
2464           order to WKUserMediaPermissionRequestAllow.
2465
2466 2015-09-30  Daniel Bates  <dabates@apple.com>
2467
2468         Add iOS builders and testers
2469         https://bugs.webkit.org/show_bug.cgi?id=149549
2470
2471         Reviewed by Alexey Proskuryakov.
2472
2473         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
2474         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
2475
2476         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
2477         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
2478
2479 2015-09-30  Timothy Hatcher  <timothy@apple.com>
2480
2481         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
2482         https://bugs.webkit.org/show_bug.cgi?id=149674
2483
2484         Reviewed by Lucas Forschler.
2485
2486         * WebKitLauncher/WebKitLauncher.entitlements: Added.
2487         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2488
2489 2015-09-30  Jason Marcell  <jmarcell@apple.com>
2490
2491         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
2492         have an associated trac instance.
2493         https://bugs.webkit.org/show_bug.cgi?id=149673
2494
2495         Reviewed by Alexey Proskuryakov.
2496
2497         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2498         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
2499         have an associated trac instance.
2500
2501 2015-09-30  Daniel Bates  <dabates@apple.com>
2502
2503         Prioritize testing latest build request on iOS test bots
2504         https://bugs.webkit.org/show_bug.cgi?id=149669
2505
2506         Reviewed by Darin Adler.
2507
2508         We should prioritize testing of the latest build request on the iOS test bots
2509         as we do for Mac and Windows test bots.
2510
2511         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2512         (loadBuilderConfig):
2513
2514 2015-09-30  Daniel Bates  <dabates@apple.com>
2515
2516         Add buildbot category for iOS builders and testers
2517         https://bugs.webkit.org/show_bug.cgi?id=149667
2518
2519         Reviewed by Darin Adler.
2520
2521         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
2522         for iOS to the build.webkit.org home page.
2523
2524         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2525         (loadBuilderConfig):
2526         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2527
2528 2015-09-30  Daniel Bates  <dabates@apple.com>
2529
2530         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2531         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2532
2533         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
2534         in <http://trac.webkit.org/changeset/190351>.
2535
2536         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2537         (CompileWebKit.start):
2538
2539 2015-09-30  Daniel Bates  <dabates@apple.com>
2540
2541         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2542         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2543
2544         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
2545         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
2546
2547         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2548         (CompileWebKit.start):
2549
2550 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2551
2552         bot210 was configured for a queue instead of bot126.
2553         
2554         Unreviewed config.json fix.
2555         
2556         * BuildSlaveSupport/build.webkit.org-config/config.json:
2557
2558 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2559
2560         Bring El Capitan buildbot infrastructure online.
2561         https://bugs.webkit.org/show_bug.cgi?id=149605
2562         
2563         Reviewed by Darin Adler.
2564
2565         * BuildSlaveSupport/build.webkit.org-config/config.json:
2566
2567 2015-09-30  Tomas Popela  <tpopela@redhat.com>
2568
2569         [GTK] Deprecation warnings in DOMNodeTest
2570         https://bugs.webkit.org/show_bug.cgi?id=149663
2571
2572         After the webkit_dom_document_get_elements_by_tag_name deprecation we
2573         need to update the tests to use webkit_dom_document_query_selector_all
2574         to avoid compilation warnings.
2575
2576         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
2577         (the suggested replacement for the deprecated function).
2578
2579         Reviewed by Carlos Garcia Campos.
2580
2581         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2582         (WebKitDOMNodeTest::testTagNamesNodeList):
2583         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2584         (registerTests):
2585         (WebKitDOMNodeTest::testTagNames): Deleted.
2586         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2587         (prepareDOMForTagNamesTests):
2588         (testWebKitDOMNodeTagNamesNodeList):
2589         (testWebKitDOMNodeTagNamesHTMLCollection):
2590         (beforeAll):
2591         (testWebKitDOMNodeTagNames): Deleted.
2592
2593 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2594
2595         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
2596         https://bugs.webkit.org/show_bug.cgi?id=149650
2597
2598         Reviewed by Tim Horton.
2599         
2600         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
2601         looks at the file path, and not the custom options that come from file comments.
2602         
2603         Fix by computing TestOptions before making the TestInvocation, and setting them
2604         as const TestInvocation data. This meant changing various call sites to take
2605         the std::string pathOrURL, rather than the TestInvocation itself.
2606         
2607         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
2608
2609         * WebKitTestRunner/CMakeLists.txt:
2610         * WebKitTestRunner/TestController.cpp:
2611         (WTR::TestController::ensureViewSupportsOptionsForTest):
2612         (WTR::testPath):
2613         (WTR::createTestURL):
2614         (WTR::updateTestOptionsFromTestHeader):
2615         (WTR::TestController::testOptionsForTest):
2616         (WTR::TestController::updateWebViewSizeForTest):
2617         (WTR::TestController::updateWindowScaleForTest):
2618         (WTR::TestController::runTest):
2619         * WebKitTestRunner/TestController.h:
2620         * WebKitTestRunner/TestInvocation.cpp:
2621         (WTR::TestInvocation::TestInvocation):
2622         (WTR::TestInvocation::invoke):
2623         (WTR::createWKURL): Deleted.
2624         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
2625         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
2626         * WebKitTestRunner/TestInvocation.h:
2627         (WTR::TestInvocation::options):
2628         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2629         (WTR::pathContains):
2630         (WTR::shouldMakeViewportFlexible):
2631         (WTR::shouldUseFixedLayout):
2632         (WTR::isSVGTestPath):
2633         (WTR::isHiDPITestPath):
2634         (WTR::TestOptions::TestOptions):
2635         * WebKitTestRunner/TestOptions.h:
2636         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2637         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2638         (WTR::pathContains):
2639         (WTR::shouldUseFixedLayout):
2640         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2641         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2642         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2643         * WebKitTestRunner/ios/TestControllerIOS.mm:
2644         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2645         * WebKitTestRunner/mac/TestControllerMac.mm:
2646         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2647
2648 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
2649
2650         Flakiness dashboard should support OS X El Capitan
2651         https://bugs.webkit.org/show_bug.cgi?id=149648
2652
2653         Reviewed by Alexey Proskuryakov.
2654
2655         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of 
2656         difference between new appscale and old Google App Engine implementation.
2657         * TestResultServer/app.yaml: Same.
2658         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
2659
2660 2015-09-29  Daniel Bates  <dabates@apple.com>
2661
2662         configure-xcode-for-ios-development does not work with Xcode 7
2663         https://bugs.webkit.org/show_bug.cgi?id=149640
2664
2665         Reviewed by Alexey Proskuryakov.
2666
2667         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
2668         because it cannot find the Xcode specification files for iOS simulator and device. These
2669         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
2670         relevant definitions to the Xcode 7 specification files directly as opposed to creating
2671         new specification files with the added definitions (as we did in older versions of Xcode)
2672         in order for Xcode 7 to honor these definitions.
2673
2674         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
2675         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
2676         (updateXcode7SpecificationFile): Added.
2677         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
2678         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
2679         appropriate success message.
2680         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
2681         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
2682         (createXcodeSpecificationFromSpecificationAndId): Deleted.
2683
2684 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2685
2686         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
2687         https://bugs.webkit.org/show_bug.cgi?id=149639
2688
2689         Reviewed by Alex Christensen.
2690
2691         * Scripts/VCSUtils.pm:
2692         (exitStatus): Use 'isWindows()' method.
2693         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
2694         an error. This method could probably just go away.
2695         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
2696         always changing to Unix style. 
2697         (unixPath): Added. Needed so Windows can always show a Unix path in the
2698         ChangeLog file.
2699         (changeLogName): Work around the fact that 'getpwuid' is not available on
2700         a pure Windows build of Perl.
2701         * Scripts/prepare-ChangeLog:
2702         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
2703         path on Windows.
2704         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
2705         support using arrays for 'open' arguments.
2706         (resolveChangeLogsPath): Ditto.
2707         (resolveConflictedChangeLogs): Use new helper functions.
2708         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
2709         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
2710         quotes. Unix systems are happy either way.
2711         (statusCommand): Ditto.
2712         * Scripts/webkitdirs.pm:
2713         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
2714
2715 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2716
2717         [Win] Unreviewed 64-bit build fix after switch to CMake.
2718
2719         * Scripts/webkitdirs.pm:
2720         (determineIsWin64FromArchitecture): Added.
2721
2722 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2723
2724         printing does not use minimum page zoom factor
2725         https://bugs.webkit.org/show_bug.cgi?id=108507
2726
2727         Reviewed by Darin Adler.
2728
2729         WebKitTestRunner always takes the snapshots from the UI process
2730         (expect for IOS), so in the case of printing, the layout in the
2731         web view is not the expected one. When printing, we need to take
2732         the snapshot in the web process and ensure it's rendered with a
2733         PrintContext.
2734
2735         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2736         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2737         kWKSnapshotOptionsPrinting option to
2738         WKBundlePageCreateSnapshotWithOptions() when printing.
2739
2740 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2741
2742         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
2743         https://bugs.webkit.org/show_bug.cgi?id=149595
2744
2745         Reviewed by Tim Horton.
2746
2747         All ports except IOS implement
2748         PlatformWebView::windowSnapshotImage() to generate the snapshot
2749         for the pixel tests in the UI process. But we are still generating
2750         a snapshot for pixel tests in the Web process too, that is passed
2751         to the UI process but ignored.
2752         Whether a pixel result is needed or not, is only known by the web
2753         process depending on whether the test called dumpAsText with
2754         dumpPixels == true or not. Since the pixels are now dump in the UI
2755         process, we need to pass that information to the UI process when
2756         the test is done. For that we set a PixelResultIsPending bool
2757         parameter to the Done message, and we only add the PixelResult
2758         when UI process doesn't need to generate the pixels dump.
2759
2760         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2761         (WTR::InjectedBundle::didReceiveMessageToPage): Set
2762         m_pixelResultIsPending to false on reset.
2763         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
2764         Done message, and set the PixelResult if m_pixelResultIsPending is false.
2765         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2766         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
2767         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
2768         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2769         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
2770         port.
2771         * WebKitTestRunner/TestInvocation.cpp:
2772         (WTR::TestInvocation::dumpResults): Use either the pixel result
2773         from the web process or generate a pixel result from the web view
2774         if need it.
2775         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2776         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2777         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2778         is created by the caller now, but the CG implementation needs to
2779         know if it's a Web or UI process snapshot.
2780         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2781         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2782         cairo surface for the given image.
2783         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2784         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2785         CGContext for the given image.
2786
2787 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
2788
2789         Fix JS errors on dashboard metrics page
2790         https://bugs.webkit.org/show_bug.cgi?id=149608
2791
2792         Reviewed by Alexey Proskuryakov.
2793
2794         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
2795         (initPlatformsByFamily): 
2796         (updateHiddenPlatforms):
2797         (parsePlatformFamily): Deleted.
2798         (updateToggleButtons): Deleted.
2799         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2800         (updateHiddenPlatforms): Added to remove errors.
2801         (initPlatformsByFamily): Added to remove errors.
2802         (unhiddenQueues): Updated to use Settings.
2803         (documentReady): Added logic to add toggle buttons to the settings menu.
2804         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2805         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
2806         MetricsMain.js to Settings.
2807         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
2808         MetricsMain.js to Settings.
2809         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2810         (QueueView.prototype._updateHiddenState): Updated to use Settings.
2811
2812 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
2813
2814         Appscale query fails because of missing index
2815         https://bugs.webkit.org/show_bug.cgi?id=149609
2816
2817         Reviewed by Darin Adler.
2818
2819         * QueueStatusServer/index.yaml: Added the required index.
2820
2821 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2822
2823         [Win] Fix the 64-bit build after switch to cmake.
2824
2825         Reviewed by Alex Christensen.
2826
2827         * Scripts/webkitdirs.pm:
2828         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
2829         run a 64-bit build.
2830
2831 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2832
2833         [Win] Allow Windows to run test-webkitpy without Cygwin
2834         https://bugs.webkit.org/show_bug.cgi?id=149602
2835
2836         Reviewed by Alex Christensen.
2837
2838         These changes mostly shift from hard-coded paths using UNIX-style
2839         separators to Python's "os.path.join" syntax that uses the correct
2840         path separator for each platform.
2841         
2842         * Scripts/webkitpy/common/system/path.py:
2843         (cygpath): Don't pass paths through Cygpath on native Windows.
2844         * Scripts/webkitpy/port/win.py:
2845         (WinPort._path_to_apache): Use os.path.join.
2846         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
2847         in 64-bit environments).
2848         * Scripts/webkitpy/style/checker.py: Use os.path.join.
2849         * Scripts/webkitpy/style/checker_unittest.py:
2850         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
2851         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
2852         (GlobalVariablesTest): Ditto.
2853         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
2854         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
2855         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
2856         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
2857         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
2858         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
2859         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
2860         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
2861         (StyleProcessor_CodeCoverageTest): Ditto.
2862         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
2863         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
2864         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
2865         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
2866         manual string concatenation of paths.
2867
2868 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2869
2870         Add bugzilla addresses of committers to contributors.json
2871         https://bugs.webkit.org/show_bug.cgi?id=149520
2872
2873         Reviewed by Darin Adler.
2874
2875         * Scripts/webkitpy/common/config/contributors.json:
2876
2877 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2878
2879         validate-committer-lists -b shouldn't need edituser privileges
2880         https://bugs.webkit.org/show_bug.cgi?id=149519
2881
2882         Reviewed by Darin Adler.
2883
2884         * Scripts/validate-committer-lists:
2885         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
2886         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2887         (BugzillaQueries.is_invalid_bugzilla_email):
2888         (BugzillaQueries): Deleted.
2889         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
2890
2891 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2892
2893         Unreviewed. Gardening: skip media stream tests failing after r190262.
2894
2895         * Scripts/run-gtk-tests:
2896         (TestRunner):
2897
2898 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2899
2900         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
2901         https://bugs.webkit.org/show_bug.cgi?id=149571
2902
2903         Reviewed by Dan Bernstein.
2904
2905         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig). 
2906
2907         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2908         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2909         * LayoutTestRelay/Configurations/Base.xcconfig:
2910         * MiniBrowser/Configurations/Base.xcconfig:
2911         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2912         * TestWebKitAPI/Configurations/Base.xcconfig:
2913         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2914         * WebEditingTester/Configurations/Base.xcconfig:
2915         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2916         * WebKitTestRunner/Configurations/Base.xcconfig:
2917         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2918         * WebKitTestRunner/iOS.xcconfig: Removed.
2919
2920 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
2921
2922         Clean up user media request internal API
2923         https://bugs.webkit.org/show_bug.cgi?id=149527
2924
2925         Reviewed by Tim Horton.
2926
2927         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2928         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
2929
2930         * WebKitTestRunner/TestController.cpp:
2931         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
2932
2933 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
2934
2935         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
2936         https://bugs.webkit.org/show_bug.cgi?id=149577
2937
2938         Reviewed by Tim Horton.
2939         
2940         When calling testRunner.runUIScript() from a page load event, the script could run
2941         in the UI process before the current remote layer tree transaction had been handled
2942         there. This meant that runUIScript() could query state which was about to change.
2943         
2944         Fix by delaying the execution of the UI script until a layer tree transaction has
2945         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
2946
2947         * WebKitTestRunner/TestInvocation.cpp:
2948         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2949         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
2950         * WebKitTestRunner/TestInvocation.h:
2951
2952 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2953
2954         [Mac] Media tests start to time out after a few days of bot uptime
2955         https://bugs.webkit.org/show_bug.cgi?id=149468
2956
2957         Reviewed by Darin Adler.
2958
2959         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
2960         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
2961         all temporary and cache files go to a custom location.
2962
2963         * Scripts/webkitpy/port/base.py:
2964         * Scripts/webkitpy/port/driver.py:
2965         * Scripts/webkitpy/port/mac.py:
2966         * Scripts/webkitpy/port/win.py:
2967         (WinPort._driver_tempdir_for_environment): Deleted unused function.
2968
2969 2015-09-25  Dan Bernstein  <mitz@apple.com>
2970
2971         Removed MiniBrowser.entitlements.
2972
2973         Rubber-stamped by Anders Carlsson.
2974
2975         The entitlements weren’t used anyway.
2976
2977         * MiniBrowser/MiniBrowser.entitlements: Removed.
2978         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2979
2980 2015-09-24  Daniel Bates  <dabates@apple.com>
2981
2982         Add WebKitSystemInterface for iOS 9.0
2983         https://bugs.webkit.org/show_bug.cgi?id=149550
2984
2985         Rubber-stamped by Alexey Proskuryakov.
2986
2987         * Scripts/copy-webkitlibraries-to-product-directory:
2988
2989 2015-09-24  Daniel Bates  <dabates@apple.com>
2990
2991         Support building for arbitrary architectures
2992         https://bugs.webkit.org/show_bug.cgi?id=149539
2993
2994         Reviewed by Alexey Proskuryakov.
2995
2996         Teach buildbot to pass the architectures associated with the builder to build-webkit
2997         when building on OS X and iOS. As a side effect of this change we now support building
2998         universal binaries when multiples architectures are specified.
2999
3000         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3001         (CompileWebKit.start):
3002
3003 2015-09-24  Daniel Bates  <dabates@apple.com>
3004
3005         Fix the build after <http://trac.webkit.org/changeset/190212>
3006         (http://trac.webkit.org/changeset/190212)
3007
3008         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
3009
3010         * BuildSlaveSupport/built-product-archive:
3011         (main):
3012
3013 2015-09-24  Daniel Bates  <dabates@apple.com>
3014
3015         Support running unit tests on iOS Simulator test bot
3016         https://bugs.webkit.org/show_bug.cgi?id=149536
3017
3018         Reviewed by Alexey Proskuryakov.
3019
3020         Implements support for running unit tests on a iOS test bot. At the time of writing,
3021         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
3022
3023         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3024         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
3025         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
3026
3027 2015-09-24  Daniel Bates  <dabates@apple.com>
3028
3029         Add support infrastructure for OpenSource iOS builders and testers
3030         https://bugs.webkit.org/show_bug.cgi?id=149534
3031
3032         Reviewed by Darin Adler.
3033
3034         Towards setting up OpenSource iOS build bots, teach buildbot and its support
3035         scripts about iOS.
3036
3037         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3038         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
3039         --ios-simulator or --device for a builder/tester whose full platform name begins with
3040         "ios-simulator" or "ios", respectively.
3041         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
3042         * BuildSlaveSupport/built-product-archive:
3043         (main): Pass the full platform name to determineWebKitBuildDirectory().
3044         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
3045         command line flag when building for iOS.
3046         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
3047         parameter fullPlatform. This parameter was originally added in r125066 to support the
3048         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
3049         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
3050         * BuildSlaveSupport/clean-build:
3051         (main): Call script webkit-build-directory with the appropriate command line flag when
3052         building for iOS.
3053         * BuildSlaveSupport/delete-stale-build-files:
3054         (main): Use the same logic for iOS as we do for Mac.
3055         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
3056         flag when building for iOS.
3057         * BuildSlaveSupport/test-result-archive:
3058         (archiveTestResults): Use the same logic for iOS as we do for Mac.
3059
3060 2015-09-24  Daniel Bates  <dabates@apple.com>
3061
3062         Remove Chromium-specific changes to script built-product-archive
3063         https://bugs.webkit.org/show_bug.cgi?id=149530
3064
3065         Rubber-stamped by Csaba Osztrogonác.
3066
3067         Reverts changes made in r113074 and r113067 to support Chromium testers. The
3068         Chromium code has long since been removed from the OpenSource WebKit Project.
3069
3070         * BuildSlaveSupport/built-product-archive:
3071         (createZipManually):
3072         (createZip):
3073         (archiveBuiltProduct):
3074
3075 2015-09-24  Dan Bernstein  <mitz@apple.com>
3076
3077         Build fix.
3078
3079         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3080
3081 2015-09-24  Mark Lam  <mark.lam@apple.com>
3082
3083         Unreviewed. Make Lucas Forschler a WebKit reviewer.
3084
3085         * Scripts/webkitpy/common/config/contributors.json:
3086
3087 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3088
3089         Unreviewed. Fix GObject DOM API breaks after r190120.
3090
3091         Bring back code removed in r169931 to handle documentation of
3092         deleted classes.
3093
3094         * gtk/webkitdom.py:
3095         (WebKitDOMDocGenerator):
3096         (WebKitDOMDocGenerator.write_deleted_classes):
3097         (WebKitDOMDocGenerator.generate):
3098         (write_deleted_classes):
3099         (WebKitDOMDocGeneratorSections._deleted_class):
3100         (WebKitDOMDocGeneratorSections._deleted_class.in):
3101         (WebKitDOMDocGeneratorSections.write_deleted_classes):
3102         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
3103
3104 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
3105
3106         [Cocoa] [Font Features] Implement font-variant-*
3107         https://bugs.webkit.org/show_bug.cgi?id=148413
3108
3109         Reviewed by Darin Adler.
3110
3111         Update test font to use "lnum" feature.
3112
3113         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
3114         (Generator::appendGSUBTable):
3115
3116 2015-09-22  Andy Estes  <aestes@apple.com>
3117
3118         ContentFiltering.AllowDownloadAfterAddData is very flaky
3119         https://bugs.webkit.org/show_bug.cgi?id=148885
3120         <rdar://problem/22729563>
3121
3122         Reviewed by Alexey Proskuryakov.
3123
3124         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
3125         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
3126         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
3127
3128         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3129         (downloadTest):
3130
3131 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
3132
3133         Mavericks: Media tests start to time out after a few days of bot uptime
3134         https://bugs.webkit.org/show_bug.cgi?id=149468
3135
3136         Reviewed by Chris Dumez.
3137
3138         * Scripts/webkitpy/port/base.py:
3139         * Scripts/webkitpy/port/driver.py:
3140         * Scripts/webkitpy/port/mac.py:
3141
3142 2015-09-22  Nan Wang  <n_wang@apple.com>
3143
3144         Unreviewed, add myself to the committers list.
3145
3146         * Scripts/webkitpy/common/config/contributors.json:
3147
3148 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
3149
3150         Remove 'nullable' to fix older iOS builds.
3151
3152         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3153         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
3154
3155 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
3156
3157         [Win] Show tiled drawing debug overlay on Windows
3158         https://bugs.webkit.org/show_bug.cgi?id=149426
3159
3160         Reviewed by Dean Jackson.
3161
3162         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
3163         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
3164         * MiniBrowser/win/Common.cpp:
3165         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
3166         flag if needed.
3167         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
3168
3169 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
3170
3171         [Win] Use command-line argument to launch in regular or High DPI mode.
3172         https://bugs.webkit.org/show_bug.cgi?id=149417
3173
3174         Reviewed by Dean Jackson.
3175
3176         * MiniBrowser/win/Common.cpp:
3177         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
3178         very start of execution, before the MiniBrowser.dll is loaded.
3179         * win/DLLLauncher/DLLLauncherMain.cpp:
3180         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
3181         present. On WinCairo, always use High DPI.
3182
3183 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
3184
3185         32-bit Mac build fix attempt after r190065.
3186
3187         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3188
3189 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
3190
3191         [OS X] Update for Xcode 7.0 on Yosemite
3192         https://bugs.webkit.org/show_bug.cgi?id=149389
3193
3194         Reviewed by Dan Bernstein.
3195
3196         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3197         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3198         Removed unneeded declarations - conforming to a protocol is sufficient.
3199
3200         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3201         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3202         Changed the definitions to be compiled whenever the SDK requires it (so we will have
3203         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
3204
3205 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
3206
3207         Add the ability for tests to run script in the UI process in WebKitTestRunner
3208         https://bugs.webkit.org/show_bug.cgi?id=149356
3209
3210         Reviewed by Tim Horton.
3211
3212         This change adds testRunner.runUIScript(script, callback), which allows a test
3213         to execute script in a JSContext which runs in the UI process. That context
3214         has bindings exposed through the UIScriptController interface; currently one test
3215         function, and some iOS-specific functions are included. UIScriptController can be
3216         async with a callback, and runUIScript() itself is asynchronous. When the UI 
3217         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
3218         is a string passed back to the web process, and given to the runUIScript()
3219         callback function.
3220         
3221         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
3222
3223         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
3224         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
3225         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3226         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
3227         complete, call back into TestRunner.
3228         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3229         (WTR::nextUIScriptCallbackID):
3230         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
3231         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
3232         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3233         * WebKitTestRunner/PlatformWebView.h:
3234         * WebKitTestRunner/TestController.cpp:
3235         (WTR::updateTestOptionsFromTestHeader):
3236         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
3237         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
3238         * WebKitTestRunner/TestInvocation.cpp:
3239         (WTR::TestInvocation::shouldUseFixedLayout):
3240         (WTR::TestInvocation::shouldUseThreadedScrolling):
3241         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3242         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3243         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
3244         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
3245         * WebKitTestRunner/TestInvocation.h:
3246         * WebKitTestRunner/TestOptions.h:
3247         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3248         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3249         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3250         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
3251         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3252         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
3253         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
3254         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
3255         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3256         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
3257         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
3258         (WTR::UIScriptController::doAsyncTask):
3259         (WTR::UIScriptController::zoomToScale):
3260         (WTR::UIScriptController::zoomScale):
3261         (WTR::UIScriptController::minimumZoomScale):
3262         (WTR::UIScriptController::maximumZoomScale):
3263         (WTR::UIScriptController::contentVisibleRect):
3264         * WebKitTestRunner/mac/EventSenderProxy.mm:
3265         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3266         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
3267         * WebKitTestRunner/mac/TestControllerMac.mm:
3268         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3269         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
3270         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3271         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
3272         (UIScriptContext::UIScriptContext):
3273         (UIScriptContext::~UIScriptContext):
3274         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
3275         asynchronous, call the callback.
3276         (UIScriptContext::nextTaskCallbackID):
3277         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
3278         that has a callback). Has to store the callbackID of the script, so code called from the completion
3279         callback knows which UI script invoked it.
3280         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
3281         (UIScriptContext::uiScriptComplete):
3282         (UIScriptContext::objectFromRect): Make a JS object from a rect.
3283         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3284         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
3285         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
3286         (WTR::UIScriptController::UIScriptController):
3287         (WTR::UIScriptController::makeWindowObject):
3288         (WTR::UIScriptController::wrapperClass):
3289         (WTR::UIScriptController::doAsyncTask):
3290         (WTR::UIScriptController::zoomToScale):
3291         (WTR::UIScriptController::zoomScale):
3292         (WTR::UIScriptController::minimumZoomScale):
3293         (WTR::UIScriptController::maximumZoomScale):
3294         (WTR::UIScriptController::contentVisibleRect):
3295         (WTR::UIScriptController::uiScriptComplete):
3296         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3297         (WTR::UIScriptController::create):
3298         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
3299
3300 2015-09-21  Tim Horton  <timothy_horton@apple.com>
3301
3302         Turn on threaded scrolling by default in the tests
3303         https://bugs.webkit.org/show_bug.cgi?id=149377
3304
3305         Reviewed by Simon Fraser.
3306
3307         * WebKitTestRunner/mac/TestControllerMac.mm:
3308         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3309         (WTR::shouldUseThreadedScrolling): Deleted.
3310         Turn on threaded scrolling by default.
3311
3312 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3313
3314         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
3315         https://bugs.webkit.org/show_bug.cgi?id=149252
3316
3317         Reviewed by Darin Adler.
3318
3319         In case of glib tests the test runner notifies about tests
3320         crashing, but for google tests we don't get any feedback, which
3321         means that in case of a test crashing we get a list of **PASS**
3322         messages and at the summary we are notified that the test suite
3323         has failed, but it's impossible to know which test cases have failed.
3324
3325         * Scripts/run-gtk-tests:
3326         (TestRunner._run_google_test): Add a **CRASH** message if test
3327         case crashed.
3328
3329 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
3330
3331         WebKitTestRunner can leak user content script results between tests
3332         https://bugs.webkit.org/show_bug.cgi?id=149391
3333
3334         Reviewed by Sam Weinig.
3335
3336         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
3337         about:blank, and thus about:blank doesn't have unintended side effects.
3338
3339         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3340         (WTR::InjectedBundle::beginTesting):
3341         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3342         (WTR::InjectedBundlePage::resetAfterTest):
3343
3344 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
3345
3346         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
3347         https://bugs.webkit.org/show_bug.cgi?id=149384
3348
3349         Reviewed by Chris Fleizach.
3350
3351         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3352         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
3353         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
3354         regardless of whether someone else holds a reference (we also call -stopListening in
3355         -dealloc).
3356
3357         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3358         (AccessibilityController::platformResetToConsistentState):
3359         (AccessibilityController::addNotificationListener):
3360         Ditto.
3361
3362 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3363
3364         Remove XHR_TIMEOUT compilation guard
3365         https://bugs.webkit.org/show_bug.cgi?id=149260
3366
3367         Reviewed by Benjamin Poulain.
3368
3369         * Scripts/webkitperl/FeatureList.pm:
3370
3371 2015-09-19  Dan Bernstein  <mitz@apple.com>
3372
3373         Attempted build fix.
3374
3375         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3376
3377 2015-09-18  Commit Queue  <commit-queue@webkit.org>
3378
3379         Unreviewed, rolling out r189908.
3380         https://bugs.webkit.org/show_bug.cgi?id=149368
3381
3382         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
3383
3384         Reverted changeset:
3385
3386         "printing does not use minimum page zoom factor"
3387         https://bugs.webkit.org/show_bug.cgi?id=108507
3388         http://trac.webkit.org/changeset/189908
3389
3390 2015-09-18  Andy Estes  <aestes@apple.com>
3391
3392         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
3393         https://bugs.webkit.org/show_bug.cgi?id=149360
3394
3395         Reviewed by Tim Horton.
3396
3397         Added an API test.
3398
3399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3400         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
3401         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3402         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3403         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
3404         (TEST):
3405         * TestWebKitAPI/ios/pages.pages: Added.
3406
3407 2015-09-18  Nan Wang  <n_wang@apple.com>
3408
3409         AX: Implement ARIA 1.1 @aria-current on iOS
3410         https://bugs.webkit.org/show_bug.cgi?id=149297
3411
3412         Reviewed by Chris Fleizach.
3413
3414         Added support to test aria-current on iOS.
3415
3416         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3417         (AccessibilityUIElement::stringAttributeValue):
3418         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3419         (WTR::AccessibilityUIElement::stringAttributeValue):
3420
3421 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
3422
3423         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
3424         https://bugs.webkit.org/show_bug.cgi?id=149352
3425
3426         Reviewed by Simon Fraser.
3427
3428         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
3429         m_context can be null. This may indicate a bug in webkitpy too, but
3430         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
3431         wrong with opening and immediately closing it.
3432
3433 2015-09-18  Daniel Bates  <dabates@apple.com>
3434
3435         isGitSVNDirectory() returns true when Git is not installed
3436         https://bugs.webkit.org/show_bug.cgi?id=149351
3437
3438         Reviewed by Alexey Proskuryakov.
3439
3440         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
3441         Git is not installed on the machine.
3442
3443         * Scripts/VCSUtils.pm:
3444         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
3445         status code 0 (success).
3446
3447 2015-09-18  Alex Christensen  <achristensen@webkit.org>
3448
3449         Prevent build-webkit from building four times on Windows 
3450         https://bugs.webkit.org/show_bug.cgi?id=149336
3451
3452         Reviewed by Brent Fulgham.
3453
3454         * Scripts/build-webkit:
3455         Move the Windows code out of the for loop iterating over each subdirectory to be build.
3456         They're built all at once.
3457         * Scripts/webkitdirs.pm:
3458         (buildVisualStudioProject):
3459         (cmakeGeneratedBuildfile):
3460         Don't generate the Visual Studio solution if it already exists.
3461         It will run CMake again if necessary.
3462
3463 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3464
3465         [iOS WK2] WTR fails to set the key window in the UIKit sense
3466         https://bugs.webkit.org/show_bug.cgi?id=149325
3467
3468         Reviewed by Tim Horton.
3469
3470         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
3471         This causes UIKit to bypass code that actually sets the key window, resulting in
3472         [UIAppliation sharedApplication].keyWindow always being nil.
3473
3474         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
3475         -[WebKitTestRunnerWindow isKeyWindow] call super.
3476
3477         * WebKitTestRunner/PlatformWebView.h:
3478         (WTR::PlatformWebView::setWindowIsKey): Deleted.
3479         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3480         (WTR::PlatformWebView::setWindowIsKey):
3481         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3482         (WTR::PlatformWebView::setWindowIsKey):
3483         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3484         (-[WebKitTestRunnerWindow isKeyWindow]):
3485         (WTR::PlatformWebView::PlatformWebView):
3486         (WTR::PlatformWebView::~PlatformWebView):
3487         (WTR::PlatformWebView::setWindowIsKey):
3488         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3489         (WTR::PlatformWebView::setWindowIsKey):
3490
3491 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3492
3493         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
3494         https://bugs.webkit.org/show_bug.cgi?id=149321
3495
3496         Reviewed by Tim Horton.
3497         
3498         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally 
3499         enabled the "testing" viewport configuration, which disables page scaling.
3500         
3501         If we're running viewport tests, we want the normal web page configuration.
3502         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
3503         based on whether the test is in a "viewport" directory.
3504
3505         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3506         (WTR::InjectedBundle::beginTesting):
3507         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3508         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
3509         * WebKitTestRunner/TestInvocation.cpp:
3510         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
3511         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
3512         (WTR::TestInvocation::shouldMakeViewportFlexible):
3513         (WTR::TestInvocation::invoke):
3514         * WebKitTestRunner/TestInvocation.h:
3515         * WebKitTestRunner/ios/TestControllerIOS.mm:
3516         (WTR::TestController::platformConfigureViewForTest):
3517         (WTR::shouldMakeViewportFlexible): Deleted.
3518
3519 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3520
3521         Give iOS WebKitTestRunner a launch storyboard
3522         https://bugs.webkit.org/show_bug.cgi?id=149314
3523
3524         Reviewed by Dan Bates.
3525         
3526         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
3527         that it's been built for specific device configurations, and puts the window
3528         at the top of the screen. This simplifies coordinate conversions in a future patch.
3529
3530         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3531         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
3532         * WebKitTestRunner/ios/Launch.storyboard: Added.
3533
3534 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
3535
3536         Update licence in r189890
3537         https://bugs.webkit.org/show_bug.cgi?id=149306
3538
3539         Reviewed by Dean Jackson.
3540
3541         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
3542         * FontWithFeatures/FontWithFeatures/FontCreator.h:
3543         * FontWithFeatures/FontWithFeatures/main.cpp:
3544
3545 2015-09-17  Mark Lam  <mark.lam@apple.com>
3546
3547         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
3548         https://bugs.webkit.org/show_bug.cgi?id=149285
3549
3550         Reviewed by Saam Barati.
3551
3552         Just need to add an option to pass --no-jit to run-jsc-stress-test.
3553
3554         * Scripts/run-javascriptcore-tests:
3555         (runJSCStressTests):
3556
3557 2015-09-17  Alex Christensen  <achristensen@webkit.org>
3558
3559         Switch AppleWin build to use CMake
3560         https://bugs.webkit.org/show_bug.cgi?id=149163
3561
3562         Reviewed by Brent Fulgham.
3563
3564         * Scripts/build-webkit:
3565         * Scripts/run-api-tests:
3566         (runTest):
3567         (listAllTests):
3568         (prepareEnvironmentForRunningTestTool):
3569         (testToolPaths):
3570         (testToolPath): Deleted.
3571         Run the API tests as separate executables on Windows.
3572         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
3573         * Scripts/webkitdirs.pm:
3574         (checkRequiredSystemConfig):
3575         (jhbuildWrapperPrefixIfNeeded):
3576         (generateBuildSystemFromCMakeProject):
3577         Fix configuration quirks.
3578
3579 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
3580
3581         Added toggle options for hiding and showing certain platform families on the dashboard.
3582         https://bugs.webkit.org/show_bug.cgi?id=148403
3583
3584         Reviewed by David Kilzer.
3585
3586         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
3587         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
3588         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
3589         in lieu of an "all" button in the toggle menu.
3590
3591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3592         (parsePlatformFamily): Helper function to parse out a platform family.
3593         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
3594         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
3595         (updateToggleButtons): Updates the status of the toggle buttons.
3596         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
3597         (documentReady): Added creation of toggle buttons.
3598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3599         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
3600         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
3601         (updateHiddenPlatforms): Deleted. After removing the individual hide button code, 
3602         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
3603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
3604         (QueueView): Updated to use hiddenPlatformFamilies.
3605         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
3606         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3607         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
3608         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
3609         (Settings.prototype.toggleHiddenPlatform): Deleted.
3610         (Settings.prototype.clearHiddenPlatforms): Deleted.
3611         (Settings.prototype.toggleShowPlatformFamily): Deleted.
3612         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3613         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
3614         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
3615         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
3616         (table.queue-grid tr.headers th):
3617         (div.settingsWrapper.hide):
3618         (