Remove Windows WebKit2 code from TestWebKitAPI
[WebKit-https.git] / Tools / ChangeLog
1 2014-08-29  Tim Horton  <timothy_horton@apple.com>
2
3         Remove Windows WebKit2 code from TestWebKitAPI
4         https://bugs.webkit.org/show_bug.cgi?id=136385
5
6         Reviewed by Alexey Proskuryakov.
7
8         * TestWebKitAPI/PlatformUtilities.h:
9         * TestWebKitAPI/PlatformWebView.h:
10         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver): Deleted.
11         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
12         (TestWebKitAPI::TEST): Deleted.
13         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
14         (TestWebKitAPI::TEST):
15         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
16         (TestWebKitAPI::TEST):
17         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Removed.
18         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Removed.
19         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Removed.
20         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp: Removed.
21         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Removed.
22         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Removed.
23         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp: Removed.
24
25 2014-08-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
26
27         [JSC] Some JSC tests are dependent on the machine time zone.
28         https://bugs.webkit.org/show_bug.cgi?id=136363
29
30         Reviewed by Filip Pizlo.
31
32         * Scripts/run-javascriptcore-tests: Export TZ environment variable to US/Pacific.
33         Unskip the tests that were skipped on r99580.
34
35 2014-08-29  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
36
37         [EFL] Remove non Coordinated Graphics code path from cmake build system after r142169
38         https://bugs.webkit.org/show_bug.cgi?id=135560
39
40         Reviewed by Gyuyoung Kim.
41
42         * Scripts/webkitperl/FeatureList.pm: Removed TILED_BACKING_STORE guard.
43
44 2014-08-28  Daniel Bates  <dabates@apple.com>
45
46         [Win] update-webkit should update auxiliary libs by default
47
48         Reviewed by Dan Bernstein.
49
50         The change set <http://trac.webkit.org/changeset/172795> inadvertently prevented update-webkit
51         from updating the Windows auxiliary libs by default. We should make update-webkit update the
52         Windows auxiliary libs by default. This will make its behavior match its usage text.
53
54         * Scripts/update-webkit:
55
56 2014-08-28  Brian J. Burg  <burg@cs.washington.edu>
57
58         build-webkit --inspector-frontend tries to copy files from old inspector path
59         https://bugs.webkit.org/show_bug.cgi?id=136346
60
61         Reviewed by Timothy Hatcher.
62
63         Remove the old code path for copying inspector resources. It doesn't work.
64         Complain if this option is passed to CMake-based builds.
65
66         * Scripts/build-webkit:
67         * Scripts/webkitdirs.pm:
68         (copyInspectorFrontendFiles): Deleted.
69
70 2014-08-28  Alexey Proskuryakov  <ap@apple.com>
71
72         Dashboard metrics page could show longest stretch of red
73         https://bugs.webkit.org/show_bug.cgi?id=136334
74
75         Reviewed by Sam Weinig.
76
77         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
78         (Analyzer.prototype._updateStretchOfRedCounters):
79         (Analyzer.prototype._countPercentageOfGreen):
80         When counting percentage of green, also keep track of how long the page was red.
81
82         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
83         (MetricsView.prototype._update.addDivider):
84         (MetricsView.prototype._update.appendQueueResults):
85         Show it in aggregate queues (can't think of a reason to have it in individual ones).
86
87         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
88         Changed to use an explicit divider element between green time and performance groups,
89         as there are too many combinations to easily express in CSS.
90
91 2014-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
92
93         [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API
94         https://bugs.webkit.org/show_bug.cgi?id=136248
95
96         Reviewed by Gustavo Noronha Silva.
97
98         Add new test case for webkit_uri_response_get_http_headers().
99
100         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
101         (testURIResponseHTTPHeaders):
102         (serverCallback):
103         (beforeAll):
104
105 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
106
107         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
108         https://bugs.webkit.org/show_bug.cgi?id=131668
109
110         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
111         (EWSQueue.prototype.loadDetailedStatus): Fixed a typo in assertion.
112
113 2014-08-27  Zalan Bujtas  <zalan@apple.com>
114
115         Subpixel layout: Cleanup snapSizeToPixel/snapSizeToDevicePixel.
116         https://bugs.webkit.org/show_bug.cgi?id=136264
117
118         Reviewed by Simon Fraser.
119         
120         1. Align snapSizeToPixel()/snapSizeToDevicePixel() function names with the rest of snapping
121         functions. ->snappedIntSize()/snapSizeToDevicePixel().
122         2. Operate on LayoutSize/LayoutPoint instead of LayoutUnit/LayoutUnit to reflect functionality.
123
124         Covered by existing tests.
125
126         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
127         (TestWebKitAPI::TEST): Deleted.
128
129 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
130
131         EWS status link at build.webkit.org/dashboard is incorrect until EWS pop-up is opened
132         https://bugs.webkit.org/show_bug.cgi?id=131668
133
134         Reviewed by Daniel Bates.
135
136         We used to fetch the URL from EWS detailed status JSON, but there isn't much reason
137         to not just hardcode.
138
139         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
140         (EWS.prototype.queueStatusURL): Added.
141
142         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
143         (EWSQueue.prototype.get statusPageURL): Use the above function.
144         (EWSQueue.prototype.loadDetailedStatus): Changed assignment to an assertion.
145
146         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
147         (EWSQueueView.prototype.update): While at it, made a popover show up even if there
148         are no patches in the queue. The popover has other useful information, such as charts
149         link and bot status.
150
151 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
152
153         https://bugs.webkit.org/show_bug.cgi?id=136317
154         Dashboard metrics page sometimes shows 0 for best time
155
156         Reviewed by Tim Horton.
157
158         This also affects regular dashboard display in a good way - iterations that failed
159         due to infrastructure misbehavior will more reliably show up as yellow and not red.
160
161         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
162         (BuildbotIteration): Added a list of steps that we actually care about. It will need to be
163         updated if we rename steps.
164         (BuildbotIteration.prototype.get productive): Now that computation is more involved,
165         do it once.
166         (BuildbotIteration.prototype._parseData): Tweak computation of "productive" - builds
167         that failed e.g. at downloading built archive step are not productive.
168
169 2014-08-27  Brent Fulgham  <bfulgham@apple.com>
170
171         [Win] Unreviewed gardening.
172
173         * win/AssembleBuildLogs/AssembleLogs.cmd: Add some missing build logs to the set
174         of logs assembled into the final build output.
175
176 2014-08-27  Alexey Proskuryakov  <ap@apple.com>
177
178         build.webkit.org/dashboard: Add a metrics page with overall bot performance results
179         https://bugs.webkit.org/show_bug.cgi?id=136196
180
181         Reviewed by Timothy Hatcher.
182
183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External: Added.
184         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Added.
185         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery-1.11.1.min.js: Added.
186         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Added.
187         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Added.
188         A date range picker control with dependencies.
189         There are a few modifications from upstream at <https://github.com/longbill/jquery-date-range-picker>:
190         - Fixed a bug where selected dates were not at midnight the first time a range was chosen
191         (it didn't happen again upon re-opening the picker).
192         - Made made style tweaks to match Dashboard UI.
193
194         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
195         Don't create objects that are not needed by the given app, and thus are not loaded at all.
196
197         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js: Added.
198         Math to count all the things. Only supports open source tree and trunk at the moment,
199         but written with internal tree and branches in mind.
200
201         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js: Added.
202         Like dashboard Main.js, draws the UI and creates all necessary objects.
203
204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js: Added.
205         A view for table cells.
206
207         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
208         (Settings.prototype.toggleSettingsDisplay): Added an event for entering settings.
209         Metrics page has individual platforms initially scrolled away form the view, so 
210         it needs to scroll down to reveal what's being configured.
211
212         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
213         Added Array.prototype.average and Array.prototype.median.
214
215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
216         Made gear icon fixed instead of absolute, so that it's visible on metrics page when
217         in settings mode.
218
219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Metrics.css:
220         Additional style rules.
221
222         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
223         The metrics page.
224
225 2014-08-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
226
227         Remove networkinfo watch category in watchlist
228         https://bugs.webkit.org/show_bug.cgi?id=136279
229
230         Reviewed by Alexey Proskuryakov.
231
232         Network info was removed. So, it is not needed anymore.
233
234         * Scripts/webkitpy/common/config/watchlist:
235
236 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
237
238         build.webkit.org/dashboard: Poor performance when there are broken builds at initial load time
239         https://bugs.webkit.org/show_bug.cgi?id=136281
240
241         Reviewed by Tim Horton.
242
243         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
244         Track and expose whether the itertion is being loaded. Made update() a no-op if
245         the iteration is already being loaded.
246
247         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
248         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Instead of
249         loading everything at once, ask the queue to load a little more. We can always repeat
250         if we still don't have enough data.
251
252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
253         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Added a function that loads
254         10 more iterations intelligently.
255
256 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
257
258         build.webkit.org/dashboard raises an exception when Trac RSS fails to load
259         https://bugs.webkit.org/show_bug.cgi?id=136283
260
261         Reviewed by Tim Horton.
262
263         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
264         Don't.
265
266 2014-08-26  Alexey Proskuryakov  <ap@apple.com>
267
268         build.webkit.org/dashboard raises an exception after a hidden platform is removed
269         https://bugs.webkit.org/show_bug.cgi?id=136282
270
271         Reviewed by Tim Horton.
272
273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
274         (updateHiddenPlatforms): Check that the platform is still valid.
275
276 2014-08-26  Matt Lilek  <mrl@apple.com>
277
278         Add WebKit SPI to control the navigator.standalone property
279         https://bugs.webkit.org/show_bug.cgi?id=136189
280
281         Reviewed by Andy Estes.
282
283         Add API test for WKPreferences
284
285         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
286         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
287         (TEST):
288
289 2014-08-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
290
291         Remove ENABLE_DRT environment variable to enable SHARED_CORE
292         https://bugs.webkit.org/show_bug.cgi?id=136205
293
294         Reviewed by Andrei Bucur.
295
296         EFL port doesn't need to enable SHARED_CORE since r172894. Thus, we don't need to
297         use ENABLE_DRT enviroment variable, which enables SHARED_CORE.
298
299         * Scripts/webkitdirs.pm:
300         (generateBuildSystemFromCMakeProject):
301
302 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
303
304         [Win] Version stamp should include package-level version
305         https://bugs.webkit.org/show_bug.cgi?id=136266
306         <rdar://problem/18134138>
307
308         Reviewed by David Kilzer.
309
310         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add
311         tests for the full 3+ digit version.
312         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
313         Confirm that the final output DLL uses the 3+ digit version.
314
315 2014-08-26  Brent Fulgham  <bfulgham@apple.com>
316
317         [Win] WebKit IDL incorrectly passes HWND as OLE_HANDLE
318         https://bugs.webkit.org/show_bug.cgi?id=136258
319         <rdar://problem/18134138>
320
321         Reviewed by Tim Horton.
322
323         Avoid 32/64-bit truncation by preventing 64-bit HWND (and other)
324         values from passing through the 32-bit OLE_HANDLE data type.
325
326         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
327         (AccessibilityController::rootElement):
328         * DumpRenderTree/win/DumpRenderTree.cpp:
329         (resetWebViewToConsistentStateBeforeTesting):
330         (runTest):
331         (createWebViewAndOffscreenWindow):
332         * DumpRenderTree/win/FrameLoadDelegate.h:
333         (FrameLoadDelegate::didReceiveIcon):
334         * DumpRenderTree/win/TestRunnerWin.cpp:
335         (TestRunner::setWindowIsKey):
336         * DumpRenderTree/win/UIDelegate.cpp:
337         (UIDelegate::trackCustomPopupMenu):
338         (UIDelegate::drawHeaderInRect):
339         (UIDelegate::drawFooterInRect):
340         (UIDelegate::webViewClose):
341         (UIDelegate::webViewFocus):
342         (UIDelegate::webViewSetCursor):
343         (UIDelegate::drawBackground):
344         * DumpRenderTree/win/UIDelegate.h:
345         (UIDelegate::webViewFirstResponder):
346         (UIDelegate::makeFirstResponder):
347         (UIDelegate::contextMenuItemsForElement):
348         (UIDelegate::addCustomMenuDrawingData):
349         (UIDelegate::cleanUpCustomMenuDrawingData):
350         (UIDelegate::webViewLostFocus):
351         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
352         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
353         * WinLauncher/PrintWebUIDelegate.cpp:
354         (PrintWebUIDelegate::drawHeaderInRect):
355         (PrintWebUIDelegate::drawFooterInRect):
356         * WinLauncher/PrintWebUIDelegate.h:
357         (PrintWebUIDelegate::webViewFirstResponder):
358         (PrintWebUIDelegate::makeFirstResponder):
359         (PrintWebUIDelegate::contextMenuItemsForElement):
360         (PrintWebUIDelegate::trackCustomPopupMenu):
361         (PrintWebUIDelegate::addCustomMenuDrawingData):
362         (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
363         * WinLauncher/WinLauncher.cpp:
364         (WinLauncher::prepareViews):
365         * WinLauncher/WinLauncherWebHost.h:
366         (WinLauncherWebHost::didReceiveIcon):
367
368 2014-08-26  Daniel Bates  <dabates@apple.com>
369
370         Only define WEBCORE_EXPORT when building DumpRenderTree for Windows and iOS
371
372         Rubber-stamped by Tim Horton.
373
374         The Windows and iOS ports are the only ports that make use of WebCore headers
375         in DumpRenderTree.
376
377         * DumpRenderTree/config.h:
378
379 2014-08-26  Dan Bernstein  <mitz@apple.com>
380
381         runSvnUpdateAndResolveChangeLogs() doesn’t work when invoked from a script outside Tools/Scripts
382         https://bugs.webkit.org/show_bug.cgi?id=136254
383
384         Reviewed by Tim Horton.
385
386         * Scripts/webkitdirs.pm:
387         (runSvnUpdateAndResolveChangeLogs): Locate resolve-ChangeLogs relative to the source tree,
388         not the invoking script.
389
390 2014-08-26  Krzysztof Czech  <k.czech@samsung.com>
391
392         [EFL] Utilize espeak as a synthesizer back-end for WebSpeech
393         https://bugs.webkit.org/show_bug.cgi?id=136127
394
395         Reviewed by Gyuyoung Kim.
396
397         Add espeak dependency.
398
399         * efl/install-dependencies:
400
401 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
402
403         Remove a little more accidentally landed code from r172891.
404
405         iteration.branch also wasn't meant to be landed.
406
407         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
408         (BuildbotIteration.prototype._parseData):
409
410 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
411
412         REGRESSION (r172891): Internal dashboard is broken.
413
414         Removing some accidentally landed code - I needed "changes" for another patch, but
415         not here, and then I decided to not use it anyway.
416
417         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
418         (BuildbotIteration.prototype._parseData):
419
420 2014-08-25  Daniel Bates  <dabates@apple.com>
421
422         Fix the iOS DumpRenderTree build after <http://trac.webkit.org/changeset/172814/>
423         (https://bugs.webkit.org/show_bug.cgi?id=136108)
424
425         Use a similar approach as in TestWebKitAPI/config.h and define a stub for the macro define WEBCORE_EXPORT
426         so that we can compile DumpRenderTree for iOS.
427
428         * DumpRenderTree/config.h:
429
430 2014-08-25  Alexey Proskuryakov  <ap@apple.com>
431
432         Make build.webkit.org/dashboard work with changeset_show_files=location
433         https://bugs.webkit.org/show_bug.cgi?id=136237
434
435         Reviewed by Tim Horton.
436
437         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
438         (Trac.prototype._convertCommitInfoElementToObject): Remove location information
439         from description before getting title, and also actually parse the location into
440         result object when available.
441
442         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
443         (String.prototype.startsWith): Added.
444
445 2014-08-25  Tanay C  <tanay.c@samsung.com>
446
447         [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation
448         https://bugs.webkit.org/show_bug.cgi?id=135795
449
450         Reviewed by Gyuyoung Kim.
451
452         * MiniBrowser/efl/main.c: Adding functionality for long press history list navigation
453         (history_list_hide): Hiding and dereferencing the history list and items
454         (on_key_down):
455         (on_mouse_down):
456         (on_back_button_clicked): Early return for longpress 
457         (on_forward_button_clicked): Early return for longpress 
458         (list_item_label_get): Populate item labels
459         (on_list_item_select): Navigates on selection from history list
460         (navigation_button_longpress_process): Populates the history list and displays it
461         (on_forward_button_longpress):
462         (on_back_button_longpress):
463         (window_create): Add the widget for history list
464
465 2014-08-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
466
467         [GTK] JHBuild module gst-plugins-base fails to build on x86 with GCC 4.9
468         https://bugs.webkit.org/show_bug.cgi?id=136152
469
470         Reviewed by Philippe Normand.
471
472         * gtk/jhbuild.modules: Apply gst-plugins-base-fix-build-gcc-4.9-x86.patch.
473         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Added.
474         Cherry pick upstream patches daa194 and 4e3d101.
475
476 2014-08-24  Zan Dobersek  <zdobersek@igalia.com>
477
478         GenericHashTraits::peek() is producing copies of passed-in temporary values
479         https://bugs.webkit.org/show_bug.cgi?id=131461
480
481         Reviewed by Darin Adler.
482
483         Add a test case that checks the number of copies and moves of the mapped objects
484         when calling HashMap::get(). Exactly one copy of the mapped value should be
485         performed when there exists a value that is mapped to the specified key, and
486         exactly one move and no copies of the empty value should be performed when there
487         isn't any mapped value for the specified key.
488
489         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Added.
490         (CopyMoveCounter::TestingScope::TestingScope):
491         (CopyMoveCounter::CopyMoveCounter):
492         (CopyMoveCounter::operator=):
493         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
494         (TestWebKitAPI::TEST):
495
496 2014-08-24  Ryuan Choi  <ryuan.choi@samsung.com>
497
498         [EFL] Introduce DEVELOPER_MODE
499         https://bugs.webkit.org/show_bug.cgi?id=135884
500
501         Reviewed by Gyuyoung Kim.
502
503         * Scripts/webkitdirs.pm: Turn on DEVELOPER_MODE for the EFL port.
504         (generateBuildSystemFromCMakeProject):
505
506 2014-08-24  Alexey Proskuryakov  <ap@apple.com>
507
508         build.webkit.org/dashboard unnecessarily loads results of hidden queues
509         https://bugs.webkit.org/show_bug.cgi?id=136195
510
511         Reviewed by Tim Horton.
512
513         This patch also makes it possible to avoid any automatic loading, as needed for metrics view.
514
515         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
516         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
517         Don't start an update just because a queue object was created. Periodic updates
518         are triggered by views, so it only makes sense to do the same for the initial update.
519
520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
521         Now that Trac object doesn't auto-load, start loading here.
522
523         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
524         (QueueView): Calling _updateHiddenState right away was wrong, because it accesses
525         a data member added by subclasses later. With this.platform being undefined, it
526         always looked like this queue was not hidden.
527         (QueueView.prototype._updateHiddenState): Start an immediate update, too.
528
529         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
530         (Trac): Don't load anything here, the client may choose to load a custom date range.
531         (Trac.prototype.startPeriodicUpdates): Added a function to start automatic loading.
532
533 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
534
535         build.webkit.org/dashboard: Further improve Trac loading
536         https://bugs.webkit.org/show_bug.cgi?id=136174
537
538         Reviewed by Timothy Hatcher.
539
540         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
541         (Trac.prototype._xmlTimelineURL): Passing -1 as "max" resulted in an off by one
542         error, the oldest commit within the range wasn't returned. The correct argument for
543         "no limit" is 0.
544         (Trac.prototype.load): Added a function to load a specific time range.
545         (Trac.prototype._loaded): Updated to support loading revisions that are arbitrarily
546         positioned with regards to ones that were already known.
547
548 2014-08-23  Alexey Proskuryakov  <ap@apple.com>
549
550         build.webkit.org/dashboard: Make it possible to pull historic data from Buildbot
551         https://bugs.webkit.org/show_bug.cgi?id=136182
552
553         Reviewed by Timothy Hatcher.
554
555         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
556         Make it possible to create a complete BuildbotIteration object with JSON, not only by
557         loading data from the network.
558
559         An iteration has three states:
560         1. Just created, it only knows the revision, and whether it's already finished.
561         BuildbotIteration constructor used to create these.
562         2. A complete JSON report loaded from buildbot. The new constructor form creates these.
563         3. Data about tests is fetched.
564
565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
566         Make it possible to pull all data from a buildbot queue. This needs to be better
567         optimized eventually, as it's somewhat slow.
568
569 2014-08-22  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
570
571         Remove LevelDB.
572         https://bugs.webkit.org/show_bug.cgi?id=136170
573
574         Reviewed by Gyuyoung Kim.
575
576         * Scripts/webkitpy/common/config/watchlist:
577         * Scripts/webkitpy/style/checker.py:
578
579 2014-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
580
581         [GTK] install-dependencies don't installs Xvfb that is needed for the tests.
582         https://bugs.webkit.org/show_bug.cgi?id=136153
583
584         Reviewed by Martin Robinson.
585
586         * gtk/install-dependencies: Add Xvfb package to the list of dependencies necessary for running tests.
587
588 2014-08-21  Alex Christensen  <achristensen@webkit.org>
589
590         [Win] Another unreviewed build fix.
591
592         * DumpRenderTree/config.h:
593         Defined WEBCORE_EXPORT on Windows.
594
595 2014-08-21  Rohit Kumar  <kumar.rohit@samsung.com>
596
597         [EFL][WK2] Minibrowser : Add stop button to abort page load
598         https://bugs.webkit.org/show_bug.cgi?id=136122
599
600         Reviewed by Gyuyoung Kim.
601
602         * MiniBrowser/efl/main.c:
603         (on_key_down):
604         (on_stop_button_clicked): Callback for stop button press.
605         (window_create):
606
607 2014-08-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
608
609         [GTK] Load the llvmpipe (Mesa) libraries when running the tests with Xvfb.
610         https://bugs.webkit.org/show_bug.cgi?id=134070
611
612         Reviewed by Martin Robinson.
613
614         * Scripts/webkitpy/port/base.py:
615         (Port.__init__): Set default _jhbuild_wrapper variable.
616         (Port._should_use_jhbuild): Implement generic check.
617         * Scripts/webkitpy/port/efl.py: Rename to jhbuild_wrapper variable
618         to make it consistent with the other ports.
619         * Scripts/webkitpy/port/gtk.py:
620         (GtkPort.__init__): Use the new _should_use_jhbuild() method.
621         (GtkPort.setup_environ_for_server): Get the path for llvmpipe_libgl_path by
622         querying the jhbuild with printenv. Also check that the path contains
623         the libraries we expect. Preload this path only for XvfbDriver.
624         * Scripts/webkitpy/port/xvfbdriver.py:
625         (XvfbDriver.check_driver): Check for the jhbuild wrapper and use it.
626         (XvfbDriver._start): The environment for llvmpipe_libgl_path is now
627         configured at setup_environ_for_server()
628         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
629         (XvfbDriverTest.make_driver): Get the port default environment.
630         (XvfbDriverTest.test_start_no_pixel_tests): The expected log now
631         should include the environment that is passed when running Xvfb.
632         (XvfbDriverTest.test_start_pixel_tests): Ditto.
633         (XvfbDriverTest.test_start_arbitrary_worker_number): Ditto.
634         (XvfbDriverTest.test_start_next_worker): Ditto.
635         * gtk/jhbuild.modules: Rename checkoutdir to generic "Mesa" to
636         prevent future problems when the version is raised. Add also a
637         comment with a warning.
638         * gtk/jhbuildrc: The path LLVMPIPE_LIBGL_PATH should be the one
639         that has the llvm optimized Gallium libGL libraries.
640
641 2014-08-21  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
642
643         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests.
644         https://bugs.webkit.org/show_bug.cgi?id=136125
645
646         Reviewed by Csaba Osztrogonác.
647
648         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
649         (RunLLINTCLoopTests.countFailures):
650         (Run32bitJSCTests.countFailures):
651         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
652         (RunLLINTCLoopTestsTest):
653         (RunLLINTCLoopTestsTest.assertResults):
654         (RunLLINTCLoopTestsTest.test_failures):
655         (RunLLINTCLoopTestsTest.test_failure):
656         (RunLLINTCLoopTestsTest.test_no_failure):
657         (Run32bitJSCTestsTest):
658         (Run32bitJSCTestsTest.assertResults):
659         (Run32bitJSCTestsTest.test_failures):
660         (Run32bitJSCTestsTest.test_failure):
661         (Run32bitJSCTestsTest.test_no_failure):
662
663 2014-08-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
664
665         Unreviewed, EFL build fix since r172814.
666
667         * WebKitTestRunner/config.h: Define WEBCORE_EXPORT.
668
669 2014-08-20  Alex Christensen  <achristensen@webkit.org>
670
671         Introducing WEBCORE_EXPORT macro.
672         https://bugs.webkit.org/show_bug.cgi?id=136108
673
674         Reviewed by Antti Koivisto.
675
676         * TestWebKitAPI/config.h:
677         Added stub definition of WEBCORE_EXPORT defined to nothing to be able to compile with WebCore headers.
678
679 2014-08-20  Rebecca Hauck  <rhauck@adobe.com>
680
681         import-w3c-tests doesn't import .svg support files
682         https://bugs.webkit.org/show_bug.cgi?id=135928
683
684         Reviewed by Bem Jones-Bey.
685
686         This patch fixes the W3C import script to not treat all
687         files with an xml mimetype as convertible tests, which
688         was causing SVG support files to not be imported.
689
690         * Scripts/webkitpy/w3c/test_importer.py:
691         (TestImporter.find_importable_tests):
692
693 2014-08-19  Dan Bernstein  <mitz@apple.com>
694
695         update-webkit should not check for the presence of Apple’s Internal directory
696         Last part of https://bugs.webkit.org/show_bug.cgi?id=135815
697
698         Reviewed by Tim Horton.
699
700         * Scripts/update-webkit:
701
702 2014-08-19  Zalan Bujtas  <zalan@apple.com>
703
704         Remove ENABLE(SUBPIXEL_LAYOUT).
705         https://bugs.webkit.org/show_bug.cgi?id=136077
706
707         Reviewed by Simon Fraser.
708
709         Remove compile time flag SUBPIXEL_LAYOUT. All ports have it enabled for a while now.
710
711         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
712
713 2014-08-19  Akos Kiss  <akiss@inf.u-szeged.hu>
714
715         Let the caller define JSC_timeout for run-javascriptcore-tests
716         https://bugs.webkit.org/show_bug.cgi?id=136068
717
718         Reviewed by Csaba Osztrogonác.
719
720         Keep the 60 second timeout for jsc tests as the default setting but
721         don't override the value of JSC_timeout if already set.
722
723         * Scripts/run-javascriptcore-tests:
724
725 2014-08-19  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
726
727         Remove obsolete run-javascriptcore-tests result parsing from master.cfg
728         https://bugs.webkit.org/show_bug.cgi?id=136039
729
730         Reviewed by Csaba Osztrogonác.
731
732         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
733         (RunJavaScriptCoreTests.commandComplete):
734         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
735         (RunJavaScriptCoreTestsTest.test_no_failure_new_output):
736         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
737         (RunJavaScriptCoreTestsTest):
738         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
739         (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output): Deleted.
740         (test_layout_failure_new_output): Deleted.
741         (test_layout_crash_new_output): Deleted.
742         (test_mozilla_and_layout_failure_new_output): Deleted.
743         (test_jsc_stress_failure_new_output): Deleted.
744         (test_js_crashes_and_jsc_stress_failures_new_output): Deleted.
745
746 2014-08-19  Alexey Proskuryakov  <ap@apple.com>
747
748         build.webkit.org/dashboard should not request 50 revisions from trac each time
749         https://bugs.webkit.org/show_bug.cgi?id=127130
750
751         build.webkit.org/dashboard sometimes fetches a Trac revision in an intermediate state, and never updates later
752         https://bugs.webkit.org/show_bug.cgi?id=127131
753
754         Reviewed by Timothy Hatcher.
755
756         Turns out that requesting 50 builds is much slower than requesting by date - even
757         if the request ends up returning more than 50 results. There is no way to only
758         request updates, but this change brings request time from 6-8 seconds down to
759         less than a second.
760
761         This patch generalizes date handling for later use in metrics code. As part of the
762         rewrite, I made newly fetched data update author e-mail in previously fetched
763         revisions, as it changes after commit queue first lands.
764
765         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
766         Updated for event rename. I changed the trac event to not contain the list of new
767         commits, as we now sometimes update old commits, and that couldn't be expressed
768         in event data. We never used the list anywhere in the first place.
769
770         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
771         (Trac.prototype._xmlTimelineURL): Made this function take arbitrary dates. When called
772         without arguments, return commits for today and yesterday.
773         (Trac.prototype._loaded):
774         (Trac.prototype.update): Moved the function for processing loaded results out of
775         here for clarity, and also because I'm going to have a separate loading code path
776         for metrics.
777
778 2014-08-18  Dan Bernstein  <mitz@apple.com>
779
780         Added an update-webkit option to override the ../Internal check.
781         Part of https://bugs.webkit.org/show_bug.cgi?id=135815
782
783         Reviewed by Tim Horton.
784
785         * Scripts/update-webkit:
786         Added an explicit --internal option to control updating ../Internal, defaulting to whether
787         ../Internal exists.
788         (runSvnUpdate): Moved to webkitdirs.pm.
789         (runGitUpdate): Ditto.
790         * Scripts/webkitdirs.pm:
791         (runSvnUpdateAndResolveChangeLogs): Moved runSvnUpdate from update-webkit and renamed to this.
792         (runGitUpdate): Moved from update-webkit.
793
794 2014-08-18  Pratik Solanki  <psolanki@apple.com>
795
796         Make update-webkit more lenient for pure git svn repositories
797         https://bugs.webkit.org/show_bug.cgi?id=135805
798
799         Reviewed by Oliver Hunt.
800
801         Make the call to git fetch be non fatal. If you have a pure git svn repository, then the
802         call to git fetch will fail and update-webkit will abort. The purpose of r72966 was to
803         provide an optimization when you have a git repository setup. We should not fail if the
804         git setup does not have svn-remote.svn.fetch set.
805
806         * Scripts/update-webkit:
807         (runGitUpdate):
808
809 2014-08-18  Simon Fraser  <simon.fraser@apple.com>
810
811         Enable Web Inspector in MiniBrowser WK2 windows
812         https://bugs.webkit.org/show_bug.cgi?id=136045
813
814         Reviewed by Tim Horton.
815         
816         Set the pref to enable developer extras for all WK2 windows.
817
818         * MiniBrowser/mac/WK2BrowserWindowController.m:
819         (-[WK2BrowserWindowController awakeFromNib]):
820
821 2014-08-18  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
822
823         master.cfg should handle special return codes of run-perf-tests
824         https://bugs.webkit.org/show_bug.cgi?id=135974
825
826         Reviewed by Ryosuke Niwa.
827
828         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
829         (RunAndUploadPerfTests.getText2):
830         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
831         (RunAndUploadPerfTestsTest):
832         (RunAndUploadPerfTestsTest.assertResults):
833         (RunAndUploadPerfTestsTest.test_tests_failed):
834         (RunAndUploadPerfTestsTest.test_build_bad_build):
835         (RunAndUploadPerfTestsTest.test_build_bad_source_json):
836         (RunAndUploadPerfTestsTest.test_build_bad_marge):
837         (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading):
838         (RunAndUploadPerfTestsTest.test_build_bad_preparation):
839
840 2014-08-17  Brent Fulgham  <bfulgham@apple.com>
841
842         [Win] Unreviewed change to force rebuild
843         (plus drive-by add an accessor I wanted for
844         some future tooling).
845
846         * WinLauncher/WinLauncher.h:
847         (WinLauncher::webView): Added.
848
849 2014-08-16  Mark Hahnenberg  <mhahnenb@gmail.com>
850
851         Update contributors.json for my new email
852         https://bugs.webkit.org/show_bug.cgi?id=136021
853
854         Reviewed by Filip Pizlo.
855
856         * Scripts/webkitpy/common/config/contributors.json:
857
858 2014-08-15  Alexey Proskuryakov  <ap@apple.com>
859
860         REGRESSION (r172660): WebKit2.TerminateTwice asserts
861         https://bugs.webkit.org/show_bug.cgi?id=136012
862
863         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Skipped the test in debug mode.
864
865 2014-08-15  Ryuan Choi  <ryuan.choi@samsung.com>
866
867         Unreviewed build fix attempt on the CMake based pots since r172665
868
869         * TestWebKitAPI/CMakeLists.txt: Added JavaScriptCore/interpreter to the include list.
870
871 2014-08-15  Brian J. Burg  <burg@cs.washington.edu>
872
873         Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
874         https://bugs.webkit.org/show_bug.cgi?id=131596
875
876         Reviewed by Joseph Pecoraro.
877
878         * Scripts/run-inspector-generator-tests: Added.
879         (main):
880         * Scripts/webkitpy/inspector/__init__.py: Added.
881         * Scripts/webkitpy/inspector/main.py: Added.
882         (InspectorGeneratorTests):
883         (InspectorGeneratorTests.__init__):
884         (InspectorGeneratorTests.generate_from_json):
885         (InspectorGeneratorTests.write_error_file):
886         (InspectorGeneratorTests.detect_changes):
887         (InspectorGeneratorTests.run_tests):
888         (InspectorGeneratorTests.main):
889
890 2014-08-15  Rebecca Hauck  <rhauck@adobe.com>
891
892         run-webkit-tests should skip 'support' directories
893         https://bugs.webkit.org/show_bug.cgi?id=135910
894
895         Reviewed by Bem Jones-Bey.
896         
897         This patch adds the 'support' directory to the list
898         of dirs to skip when looking for runnable tests.
899         the W3C uses this name for support files, so tests
900         imported from the W3C will not work without this change
901         or without many edits.
902
903         * Scripts/webkitpy/port/base.py:
904         (Port._real_tests):
905
906 2014-08-14  Brent Fulgham  <bfulgham@apple.com>
907
908         [Win] Extend auto-version and version-stamp for RC_ProjectBuildVersion
909         https://bugs.webkit.org/show_bug.cgi?id=135948
910         <rdar://problem/18022221>
911
912         Reviewed by David Kilzer.
913
914         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add tests
915         for RC_ProjectBuildVersion.
916
917 2014-08-05  David Farler  <dfarler@apple.com>
918
919         [iOS] run-webkit-tests runs webkit-build-directory on every test
920         https://bugs.webkit.org/show_bug.cgi?id=135409
921
922         Reviewed by Daniel Bates.
923
924         * Scripts/webkitpy/port/ios.py:
925         (IOSSimulatorPort.__init__): Cache Mac build directory.
926         (IOSSimulatorPort.relay_path): Use cached build directory.
927         (IOSSimulatorPort._path_to_image_diff): Use cached build directory.
928
929 2014-08-14  Zan Dobersek  <zdobersek@igalia.com>
930
931         Initialize a separate variable (TestWTF_SOURCES) with the list of files
932         that are built into the TestWTF executable and move it above the platform-specific
933         config file inclusion. This makes it possible to add platform-specific files to that
934         list (e.g. GUniquePtr.cpp for the GTK port).
935
936         Rubber-stamped by Carlos Garcia Campos.
937
938         * TestWebKitAPI/CMakeLists.txt:
939         * TestWebKitAPI/PlatformGTK.cmake:
940
941 2014-08-13  Akos Kiss  <akiss@inf.u-szeged.hu>
942
943         [EFL] Bump up and patch dependencies to allow building for aarch64
944         https://bugs.webkit.org/show_bug.cgi?id=135885
945
946         Reviewed by Gyuyoung Kim.
947
948         The currently used versions of pixman, libffi, glib, glib-networking,
949         and fontconfig fail to configure for aarch64, so they are bumped up to
950         the latest stable version.
951
952         Gstreamer-plugins-base configures for aarch64 but incorrectly recogizes
953         ARM NEON assembly support, so it is patched with a change that has been
954         accepted by upstream.
955
956         * efl/jhbuild.modules:
957         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Added.
958
959 2014-08-13  Mark Rowe  <mrowe@apple.com>
960
961         <https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.
962
963         Reviewed by Darin Adler.
964
965         * DumpRenderTree/mac/TextInputController.m: Don't use extern "C" in a non-C++ file.
966
967 2014-08-13  Alex Christensen  <achristensen@webkit.org>
968
969         Progress towards CMake on Mac.
970         https://bugs.webkit.org/show_bug.cgi?id=135819
971
972         Reviewed by Laszlo Gombos.
973
974         * WebKitTestRunner/CMakeLists.txt:
975         Added new cpp parameter for the extension of the generated files.
976
977 2014-08-13  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
978
979         Make check-webkit-style run sort-export-file
980         https://bugs.webkit.org/show_bug.cgi?id=135877
981
982         Reviewed by Csaba Osztrogonác.
983
984         * Scripts/webkitpy/style/checker.py:
985         (_all_categories):
986         (FileType):
987         (CheckerDispatcher._file_type):
988         (CheckerDispatcher._create_checker):
989         * Scripts/webkitpy/style/checkers/exportfile.py: Added.
990         (ExportFileChecker):
991         (ExportFileChecker.__init__):
992         (ExportFileChecker.check):
993         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Added.
994         (handle_style_error):
995         (MockErrorHandler):
996         (MockErrorHandler.__init__):
997         (MockErrorHandler.turn_off_line_filtering):
998         (MockErrorHandler.__call__):
999         (ExportFileTest):
1000         (ExportFileTest.setUp):
1001         (ExportFileTest.tearDown):
1002         (ExportFileTest.test_sorted):
1003         (ExportFileTest.test_non_sorted):
1004         (ExportFileTest.test_parse_error):
1005
1006 2014-08-13  Jinwoo Song  <jinwoo7.song@samsung.com>
1007
1008         [EFL] Sets the persistent storage for cookies in MiniBrowser
1009         https://bugs.webkit.org/show_bug.cgi?id=135875
1010
1011         Reviewed by Gyuyoung Kim.
1012
1013         In case of EWK_COOKIE_ACCEPT_POLICY_ALWAYS, sets the persistent storage
1014         for non-session cookies can be stored persistently.
1015
1016         * MiniBrowser/efl/main.c:
1017         (elm_main):
1018
1019 2014-08-12  Daniel Bates  <dabates@apple.com>
1020
1021         [iOS] build-webkit should not build WebKitSystemInterface and WebKitAdditions
1022         https://bugs.webkit.org/show_bug.cgi?id=135845
1023
1024         Reviewed by Andy Estes.
1025
1026         Towards building the iOS WebKit port using the public SDK, remove the logic
1027         added to build-webkit to build projects WebKitSystemInterface and
1028         WebKitAdditions when building the iOS WebKit port.
1029
1030         * Scripts/build-webkit:
1031
1032 2014-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
1033
1034         [GTK] Adds dependency for GnuTLS 3.0+ explicitly in gtk/install-dependencies
1035         https://bugs.webkit.org/show_bug.cgi?id=135850
1036
1037         Reviewed by Philippe Normand.
1038
1039         After r172433, GTK port requires GnuTLS 3.0+. In this time, libgnutls-dev is 2.x in
1040         Ubuntu(trusty) and Debian(sid). So added libgnutls28-dev explicitly.
1041
1042         * gtk/install-dependencies:
1043
1044 2014-08-12  Eduardo Lima Mitev  <elima@igalia.com>
1045
1046         [GTK] Subtle-crypto feature off by default and add a new configure flag to enable it
1047         https://bugs.webkit.org/show_bug.cgi?id=135798
1048
1049         Reviewed by Philippe Normand.
1050
1051         * Scripts/webkitperl/FeatureList.pm: Adds new flag --subtle-crypto to
1052             toggle SUBTLE_CRYPTO feature.
1053
1054 2014-08-12  Ryuan Choi  <ryuan.choi@samsung.com>
1055
1056         [EFL] Disable ecore logs about bad fd
1057         https://bugs.webkit.org/show_bug.cgi?id=135831
1058
1059         Reviewed by Gyuyoung Kim.
1060
1061         ecore checks EBADF and prints the warnings.
1062         But, it looks noise in layout test because it's not webkit issue.
1063         This patch disables it until we found right solution.
1064
1065         * efl/jhbuild.modules:
1066         * efl/patches/ecore_remove_warnings.patch: Added.
1067
1068 2014-08-12  Shivakumar JM  <shiva.jm@samsung.com>
1069
1070         [EFL][WK2] Minibrowser: Enhance the application to use download directory selector.
1071         https://bugs.webkit.org/show_bug.cgi?id=135791
1072
1073         Reviewed by Gyuyoung Kim.
1074
1075         Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the
1076         user.
1077
1078         * MiniBrowser/efl/main.c:
1079         (on_download_request):
1080
1081 2014-08-11  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1082
1083         [EFL] Prevent the client from creating ewk_view when EWebkit is not initialized
1084         https://bugs.webkit.org/show_bug.cgi?id=135606
1085
1086         Reviewed by Gyuyoung Kim.
1087
1088         TestWebKitAPI does not initialize EWebkit using ewk_init()
1089         which is not recommended.
1090
1091         * TestWebKitAPI/efl/PlatformWebView.cpp:
1092         (TestWebKitAPI::createEcoreEvas):
1093         Renamed from initEcoreEvas() since it doesn't not initialize
1094         ecore evas.
1095
1096         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1097         Call ewk_init() that initalizes all EFL modules needed by EWebKit
1098         instead of ecore_evas_init() only.
1099
1100         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
1101         Call ewk_shutdown() to finalize EWebkit.
1102         (TestWebKitAPI::initEcoreEvas): Deleted.
1103
1104 2014-08-11  Dan Bernstein  <mitz@apple.com>
1105
1106         Added an update-webkit option to update the auxiliary libraries or not.
1107         Part of https://bugs.webkit.org/show_bug.cgi?id=135815
1108
1109         Reviewed by Tim Horton.
1110
1111         * Scripts/update-webkit: Added --[no-]auxiliary-libs option, which defaults to yes unless
1112         an Internal directory exists alongside the WebKit root directory.
1113
1114 2014-08-11  Bem Jones-Bey  <bjonesbe@adobe.com>
1115
1116         Remove hg changeset from w3c-import.log
1117         https://bugs.webkit.org/show_bug.cgi?id=135735
1118
1119         Reviewed by Ryosuke Niwa.
1120
1121         Since the csswg's test suite is now accessible via github and it is
1122         possible to push changes by creating github pull requests, the hg
1123         changeset makes less sense, as many people will just use a clone of
1124         the git repo. There isn't an obvious thing to replace it with, so
1125         might as well remove it for now instead of having it just be set to
1126         UNKNOWN in imports.
1127
1128         This also adds a pointer to the github repo in the generated comments
1129         in the w3c-import.log.
1130
1131         * Scripts/webkitpy/w3c/test_importer.py:
1132         (TestImporter.__init__): Remove changeset handling.
1133         (TestImporter.do_import): Ditto.
1134         (TestImporter.write_import_log): Ditto.
1135         (TestImporter.load_changeset): Deleted.
1136
1137 2014-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1138
1139         Unreviewed. Fix GTK+ make distcheck.
1140
1141         * gtk/manifest.txt: Remove Source/WebCore/Resources/inputSpeech.png.
1142
1143 2014-08-08  Simon Fraser  <simon.fraser@apple.com>
1144
1145         Unbreak webkitpy unit tests by checking for the existence of the image diff template
1146         file before trying to open it (as the tests do for results.html).
1147
1148         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1149         (TestResultWriter.write_image_diff_files):
1150
1151 2014-08-08  Simon Fraser  <simon.fraser@apple.com>
1152
1153         Load the layout test result image diff HTML from a file, rather than having it inline in webkitpy
1154         https://bugs.webkit.org/show_bug.cgi?id=135780
1155
1156         Reviewed by Dan Bates.
1157         
1158         Pull the HTML for the image diff file into a separate file, for easier hackability.
1159
1160         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1161         (TestResultWriter.write_image_diff_files):
1162
1163 2014-08-08  Mark Lam  <mark.lam@apple.com>
1164
1165         Gardening: fix Windows build after r172259.
1166
1167         Not reviewed.
1168
1169         * DumpRenderTree/win/TestRunnerWin.cpp:
1170         (TestRunner::addMockSpeechInputResult): Deleted.
1171         (TestRunner::setMockSpeechInputDumpRect): Deleted.
1172         (TestRunner::startSpeechInput): Deleted.
1173
1174 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
1175
1176         make clean does not work in OpenSource, fails in WebKitLibraries
1177         https://bugs.webkit.org/show_bug.cgi?id=135734
1178
1179         Reviewed by David Kilzer.
1180
1181         * Scripts/copy-webkitlibraries-to-product-directory:
1182         Add a --clean switch that removes possible WebKitSystemInterface
1183         and LLVM libraries and headers that may have been copied to the
1184         product directory.
1185
1186 2014-08-08  Joseph Pecoraro  <pecoraro@apple.com>
1187
1188         commit-log-message has extra blank line at the top of pre-populated message
1189         https://bugs.webkit.org/show_bug.cgi?id=135744
1190
1191         Reviewed by Csaba Osztrogonác.
1192
1193         Do not add a blank leading line in single ChangeLog commit messages.
1194
1195         * Scripts/commit-log-editor:
1196         (createCommitMessage):
1197         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1198         (test_commit_message_for_one_reviewed_changelog):
1199         (test_commit_message_for_one_rollout_changelog):
1200
1201 2014-08-07  Brent Fulgham  <bfulgham@apple.com>
1202
1203         [Win] Unreviewed gardening.
1204
1205         Have 'Assemble Build Logs' step work properly for DebugSuffix target
1206         (both 32-bit and 64-bit).
1207
1208         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1209
1210 2014-08-07  Benjamin Poulain  <bpoulain@apple.com>
1211
1212         Get rid of INPUT_SPEECH
1213         https://bugs.webkit.org/show_bug.cgi?id=135672
1214
1215         Reviewed by Andreas Kling.
1216
1217         * DumpRenderTree/TestRunner.cpp:
1218         (TestRunner::staticFunctions):
1219         (addMockSpeechInputResultCallback): Deleted.
1220         (setMockSpeechInputDumpRectCallback): Deleted.
1221         * DumpRenderTree/TestRunner.h:
1222         * DumpRenderTree/mac/TestRunnerMac.mm:
1223         (TestRunner::addMockSpeechInputResult): Deleted.
1224         (TestRunner::setMockSpeechInputDumpRect): Deleted.
1225         (TestRunner::startSpeechInput): Deleted.
1226
1227 2014-08-07  Bem Jones-Bey  <bjonesbe@adobe.com>
1228
1229         The support directory shouldn't be skipped unconditionally in test import
1230         https://bugs.webkit.org/show_bug.cgi?id=135660
1231
1232         Reviewed by Ryosuke Niwa.
1233
1234         The 'DIRS_TO_SKIP' should only be skipped when in the root directory
1235         of the test repo, as that's the only time they are special. In
1236         addition, instead of hardcoding .hg and .git as special, skip all
1237         directories that begin with '.', just like with files that begin with '.'.
1238         
1239         In order to make this work, the root directory must always be
1240         passed in, so the interface to the script has been changed to take the
1241         root directory, and if one wants to only import a subset of the tests,
1242         a new -t option can be used to limit the tests imported.
1243
1244         * Scripts/webkitpy/w3c/test_importer.py:
1245         (main): Remove repo_dir command line argument.
1246         (parse_args): Add -t option and set expected non-option args to 1.
1247         (TestImporter.__init__): Remove repo_dir.
1248         (TestImporter.do_import): Handle the varying number of import
1249             directories.
1250         (TestImporter.should_keep_subdir): Helper for find_importable_tests to
1251             determine if a subdirectory should be skipped.
1252         (TestImporter.find_importable_tests): Filter directories using new
1253             helper.
1254         (TestImporter.import_tests): Remove use of repo_dir.
1255         (TestImporter.setup_destination_directory): Unused, Deleted. 
1256         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1257         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Update for
1258             new API.
1259         (TestImporterTest.test_import_dir_with_no_tests): Ditto.
1260
1261 2014-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1262
1263         [GTK] Use WebKitNavigationAction also for WebKitNavigationPolicyDecision
1264         https://bugs.webkit.org/show_bug.cgi?id=135695
1265
1266         Reviewed by Gustavo Noronha Silva.
1267
1268         Use WebKitNavigationAction API.
1269
1270         * MiniBrowser/gtk/BrowserWindow.c:
1271         (webViewDecidePolicy):
1272         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
1273         (testNavigationPolicy):
1274
1275 2014-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1276
1277         [GTK] Test /webkit2/WebKitUserContentManager/injected-script fails
1278         https://bugs.webkit.org/show_bug.cgi?id=135696
1279
1280         Reviewed by Sergio Villar Senin.
1281
1282         Don't assume the JavaScript result is always a valid pointer. In case of JavaScript
1283         exception (that happens when testing the script hasn't been injected) the JavaScript
1284         result is NULL.
1285
1286         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1287         (isScriptInjectedForURLAtPath):
1288
1289 2014-08-07  Csaba Osztrogonác  <ossy@webkit.org>
1290
1291         [GTK] Disable IndexedDB
1292         https://bugs.webkit.org/show_bug.cgi?id=135692
1293
1294         Reviewed by Carlos Garcia Campos.
1295
1296         * Scripts/webkitperl/FeatureList.pm:
1297
1298 2014-08-06  Dean Jackson  <dino@apple.com>
1299
1300         ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
1301         https://bugs.webkit.org/show_bug.cgi?id=135675
1302
1303         Reviewed by Sam Weinig.
1304
1305         * Scripts/webkitperl/FeatureList.pm:
1306
1307 2014-08-06  David Farler  <dfarler@apple.com>
1308
1309         Set DSYMUTIL_NUM_THREADS to the number of logical cores
1310         https://bugs.webkit.org/show_bug.cgi?id=135655
1311
1312         Reviewed by Mark Rowe.
1313
1314         * Scripts/webkitdirs.pm:
1315         (buildXCodeProject): Set before calling xcodebuild.
1316
1317 2014-08-06  Adrian Perez de Castro  <aperez@igalia.com>
1318
1319         [GTK] Add support for user scripts to WebKitUserContentManager
1320         https://bugs.webkit.org/show_bug.cgi?id=134738
1321
1322         Reviewed by Carlos Garcia Campos.
1323
1324         Add support for user scripts, to complement the user style sheet
1325         support already present in WebKitUserContentManager. Most of the
1326         moving parts are already present, so this just adds a boxed type
1327         for user scripts (WebKitUserScript) and the corresponding methods
1328         to add and remove scripts from the WebKitUserContentManager.
1329
1330         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1331         Add test case for injected user scripts.
1332         (isScriptInjectedForURLAtPath):
1333         (removeOldInjectedContentAndResetLists):
1334         (testUserContentManagerInjectedStyleSheet):
1335         (testUserContentManagerInjectedScript):
1336         (beforeAll):
1337         (removeOldInjectedStyleSheetsAndResetLists): Deleted.
1338
1339 2014-08-06  Philippe Normand  <pnormand@igalia.com>
1340
1341         [GTK] run-launcher --gtk still fails
1342         https://bugs.webkit.org/show_bug.cgi?id=135642
1343
1344         Reviewed by Carlos Garcia Campos.
1345
1346         The perl interpreter is confused by the combination of string
1347         concatenation and a ternary in the same line. Using a separate
1348         variable to determine the library file extension fixes this issue.
1349
1350         * Scripts/webkitdirs.pm:
1351         (builtDylibPathForName): Use an intermediate variable, it's more
1352         readable and unambiguous.
1353
1354 2014-07-29  Filip Pizlo  <fpizlo@apple.com>
1355
1356         Merge r170564, r170571, r170604, r170628, r170672, r170680, r170724, r170728, r170729, r170819, r170821, r170836, r170855, r170860, r170890, r170907, r170929, r171052, r171106, r171152, r171153, r171214 from ftlopt.
1357
1358     2014-06-25  Filip Pizlo  <fpizlo@apple.com>
1359     
1360             [ftlopt] If a CodeBlock is jettisoned due to a watchpoint then it should be possible to figure out something about that watchpoint
1361             https://bugs.webkit.org/show_bug.cgi?id=134333
1362     
1363             Reviewed by Geoffrey Garen.
1364     
1365             * Scripts/display-profiler-output:
1366     
1367 2014-08-05  David Farler  <dfarler@apple.com>
1368
1369         [iOS] Run ImageDiff in the sim bootstrap
1370         https://bugs.webkit.org/show_bug.cgi?id=135624
1371
1372         Reviewed by David Kilzer.
1373
1374         * Scripts/webkitpy/port/image_diff.py:
1375         (ImageDiffer.stop):
1376         (IOSSimulatorImageDiffer):
1377         (IOSSimulatorImageDiffer._start):
1378         * Scripts/webkitpy/port/ios.py:
1379         (IOSSimulatorPort.diff_image):
1380
1381 2014-08-05  David Farler  <dfarler@apple.com>
1382
1383         [iOS] run-webkit-tests: defaults for --runtime and --device-type flags
1384         https://bugs.webkit.org/show_bug.cgi?id=135441
1385
1386         Reviewed by Tim Horton.
1387
1388         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1389         (parse_args):
1390         (_set_up_derived_options):
1391         If using the ios-simulator platform and runtime or device-type
1392         aren't defined, get the latest runtime from the active Xcode.app
1393         and pick a default device type based on the desired architecture:
1394         iPhone 5 for i386 and iPhone 5s for x86_64.
1395         * Scripts/webkitpy/xcode/__init__.py: Added.
1396         * Scripts/webkitpy/xcode/simulator.py: Added.
1397
1398 2014-08-05  David Farler  <dfarler@apple.com>
1399
1400         [iOS] simctl can hang if run quickly after shutting down CoreSimulator services
1401         https://bugs.webkit.org/show_bug.cgi?id=135626
1402
1403         Reviewed by Dan Bernstein.
1404
1405         * Scripts/webkitpy/port/ios.py:
1406         (IOSSimulatorPort.setup_test_run):
1407         Remove call to simctl shutdown <device> - telling the simulator app to quit
1408         will shut down all booted devices.
1409
1410 2014-08-05  Alexey Proskuryakov  <ap@apple.com>
1411
1412         Remove an unused argument from BuildbotQueue.update()
1413         https://bugs.webkit.org/show_bug.cgi?id=135623
1414
1415         Reviewed by Timothy Hatcher.
1416
1417         Also remaned a constant to better match what it means.
1418
1419         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1420
1421 2014-08-05  Vivek Galatage  <vivek.vg@samsung.com>
1422
1423         [gtk] Include llvm-dev(el) package to satisfy mesa build configuration
1424         https://bugs.webkit.org/show_bug.cgi?id=135555
1425
1426         Reviewed by Philippe Normand.
1427
1428         Initial setup of gtk on linux requires this package to be installed.
1429         This is required during the build configuration of mesa through jhbuild.
1430
1431         * gtk/install-dependencies:
1432
1433 2014-08-05  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1434
1435         Fix the commit-log-editor after r167243 and add more unit tests
1436         https://bugs.webkit.org/show_bug.cgi?id=131727
1437
1438         Reviewed by Csaba Osztrogonác.
1439
1440         * Scripts/commit-log-editor:
1441         (createCommitMessage):
1442         (removeLongestCommonPrefixEndingInNewline):
1443         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1444         (CommitMessageForThisCommitTest):
1445         (CommitMessageForThisCommitTest.mock_changelog):
1446         (CommitMessageForThisCommitTest.mock_checkout_for_test):
1447         (CommitMessageForThisCommitTest.test_commit_message_for_unreviewed_changelogs_with_different_messages):
1448         (test_commit_message_for_one_reviewed_changelog):
1449         (test_commit_message_for_changelogs_with_same_messages):
1450         (test_commit_message_for_changelogs_with_different_messages):
1451         (test_commit_message_for_one_rollout_changelog):
1452         (test_commit_message_for_rollout_changelogs_with_different_directories):
1453         (setUp): Deleted.
1454         (test_commit_message_for_this_commit): Deleted.
1455
1456 2014-08-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1457
1458         [GTK] run-launcher --gtk is broken
1459         https://bugs.webkit.org/show_bug.cgi?id=135571
1460
1461         Reviewed by Martin Robinson.
1462
1463         * Scripts/webkitdirs.pm:
1464         (builtDylibPathForName): Search for libwebkit2gtk-4.0
1465
1466 2014-08-04  Matt Baker  <mattbaker@apple.com>
1467
1468         lldb_webkit.py throws exception when generating summary of null StringImpl
1469         https://bugs.webkit.org/show_bug.cgi?id=129448
1470
1471         Reviewed by Jer Noble.
1472
1473         Added checks for null StringImpl and 0 byte ReadMemory calls.
1474
1475         * lldb/lldb_webkit.py:
1476         (WTFStringImpl_SummaryProvider):
1477         (ustring_to_string):
1478         (lstring_to_string):
1479         (WTFStringImplProvider.to_string):
1480         (WTFStringImplProvider.is_initialized):
1481
1482 2014-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1483
1484         [GTK] Do not include JavaScriptCore stress tests in release tarballs
1485         https://bugs.webkit.org/show_bug.cgi?id=135503
1486
1487         Reviewed by Martin Robinson.
1488
1489         * gtk/manifest.txt: Exclude Source/JavaScriptCore/tests dir.
1490
1491 2014-07-30  David Farler  <dfarler@apple.com>
1492
1493         build-webkittestrunner doesn't build the app target for iOS SDKs
1494         https://bugs.webkit.org/show_bug.cgi?id=135433
1495
1496         Reviewed by Dan Bernstein.
1497
1498         * Scripts/build-dumprendertree: Build the app target on iOS.
1499         * Scripts/build-webkittestrunner: Build the app target on iOS.
1500         * Scripts/webkitdirs.pm: Add -sdk flags when building for iOS.
1501         (buildXCodeProject):
1502         * Scripts/webkitpy/port/ios.py: Use --sdk flags instead of SDKROOT.
1503         (IOSSimulatorPort._build_driver_flags):
1504
1505 2014-07-30  David Farler  <dfarler@apple.com>
1506
1507         Remove iOS Perl DumpRenderTree support target
1508         https://bugs.webkit.org/show_bug.cgi?id=135271
1509
1510         Reviewed by Dan Bernstein.
1511
1512         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
1513         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Removed.
1514         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
1515         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
1516         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Removed.
1517         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Removed.
1518         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Removed.
1519         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Removed.
1520         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Removed.
1521         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Removed.
1522         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Removed.
1523         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Removed.
1524         * DumpRenderTree/ios/PerlSupport/Makefile: Removed.
1525
1526 2014-07-30  David Farler  <dfarler@apple.com>
1527
1528         Remove old-run-webkit-tests
1529         https://bugs.webkit.org/show_bug.cgi?id=135374
1530
1531         Reviewed by Csaba Osztrogonác.
1532
1533         * Scripts/old-run-webkit-tests: Removed.
1534
1535 2014-08-02  Dan Bernstein  <mitz@apple.com>
1536
1537         prepare-ChangeLog --no-write shouldn’t require ChangeLog to exist
1538         https://bugs.webkit.org/show_bug.cgi?id=135542
1539
1540         Reviewed by Tim Horton.
1541
1542         * Scripts/prepare-ChangeLog:
1543         (main): Pass $writeChangeLogs for the new requireChangeLogToExist parameter of
1544         findChangeLogs.
1545         (findChangeLogs): Don’t require a ChangeLog file to exist if unless the
1546         requireChangeLogToExist argument is true.
1547
1548 2014-08-01  Dan Bernstein  <mitz@apple.com>
1549
1550         commit-log-editor uses a non-standard message format when git index contains no ChangeLog changes
1551         https://bugs.webkit.org/show_bug.cgi?id=135527
1552
1553         Reviewed by Tim Horton.
1554
1555         * Scripts/commit-log-editor:
1556         In the case of a git repository when there are no changed ChangeLog files, changed to pass
1557         the --delimiters option to prepare-ChangeLog, then process each entry in the output using
1558         commitMessageFromChangeLogEntry.
1559         (commitMessageFromChangeLogEntry): Factored out from createCommitMessage.
1560         (sortKey): Factored out from createCommitMessage.
1561         (createCommitMessage): Changed to use new sortKey and commitMessageFromChangeLogEntry
1562         subroutines.
1563
1564         * Scripts/prepare-ChangeLog:
1565         (main): Parse new --delimiters option.
1566         (generateNewChangeLogs): When --no-write and --delimiters are both specified, always print
1567         the label before each change log entry, and a "~" delimiter on a new line after each entry.
1568
1569 2014-08-01  Bear Travis  <betravis@adobe.com>
1570
1571         [Feature Queries] Enable Feature Queries on EFL/GTK
1572         https://bugs.webkit.org/show_bug.cgi?id=134902
1573
1574         Reviewed by Benjamin Poulain.
1575
1576         Turn the feature on by default for the build script.
1577
1578         * Scripts/webkitperl/FeatureList.pm:
1579
1580 2014-08-01  Timothy Horton  <timothy_horton@apple.com>
1581
1582         Build fix for 32-bit after r171926.
1583
1584         * MiniBrowser/mac/SettingsController.h:
1585         * MiniBrowser/mac/SettingsController.m:
1586
1587 2014-08-01  Tim Horton  <timothy_horton@apple.com>
1588
1589         Confusing build fix after r171926.
1590
1591         * MiniBrowser/mac/AppDelegate.h:
1592         * MiniBrowser/mac/AppDelegate.m:
1593         * MiniBrowser/mac/SettingsController.m:
1594
1595 2014-08-01  Tim Horton  <timothy_horton@apple.com>
1596
1597         Make it easer to add switches to MiniBrowser
1598         https://bugs.webkit.org/show_bug.cgi?id=135499
1599
1600         Reviewed by Simon Fraser.
1601
1602         Add a single class to manage a set of persistent, global settings for MiniBrowser.
1603         Add a new menu that contains items to toggle the aforementioned settings (moving them out of the Debug menu).
1604
1605         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1606         Add SettingsController.{m, h}.
1607
1608         * MiniBrowser/mac/AppDelegate.h:
1609         Move _browserWindowControllers to the implementation.
1610         Get rid of toggleUseWebKit2ByDefault, because SettingsController now takes care
1611         of that; instead, we'll receive didChangeSettings.
1612
1613         * MiniBrowser/mac/AppDelegate.m:
1614         Move the default URL, default URL preference key, and use-WebKit2-by-default
1615         preference key into SettingsController.
1616
1617         (-[BrowserAppDelegate awakeFromNib]):
1618         Add the dynamically-generated SettingsController menu just to the left of the Debug menu.
1619
1620         (-[BrowserAppDelegate newWindow:]):
1621         Ask SettingsController if we should use WebKit2 by default, and what the initial URL to load is.
1622
1623         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1624         SettingsController now takes care of reading the default URL preference.
1625         WK1BrowserWindowController now takes care of enabling the developer extras, via WebPreferences.
1626
1627         (-[BrowserAppDelegate didChangeSettings]):
1628         When settings change, update the key equivalents for the new-window menu items, as they
1629         might have changed (as use-WebKit2-by-default is one of the settings).
1630
1631         Dispatch settings change notifications to all live BrowserControllers.
1632
1633         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1634         (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]): Deleted.
1635         (-[BrowserAppDelegate _useWebKit2ByDefault]): Deleted.
1636         (-[BrowserAppDelegate validateMenuItem:]): Deleted.
1637         All menu item validation for settings is moved into SettingsController.
1638
1639         * MiniBrowser/mac/BrowserWindowController.h:
1640         Simplify the BrowserWindowController interface; "toggling" settings will happen inside SettingsController,
1641         the BrowserWindowController subclasses will be able to a) know when any setting changes, b) query the current setting state.
1642
1643         * MiniBrowser/mac/MainMenu.xib:
1644         Remove the settings menu items from the "Debug" menu.
1645
1646         * MiniBrowser/mac/SettingsController.h: Added.
1647         * MiniBrowser/mac/SettingsController.m: Added.
1648         (+[SettingsController shared]):
1649         (-[SettingsController menu]):
1650
1651         (-[SettingsController _addItemWithTitle:action:indented:]):
1652         (-[SettingsController _addHeaderWithTitle:]):
1653         NSMenuItem-creating helpers.
1654
1655         (-[SettingsController _populateMenu]):
1656         Build the menu. Ideally this and the validation step would eventually be made more dynamic.
1657
1658         (-[SettingsController validateMenuItem:]):
1659         Validate menu items; since they can be used to toggle the default state of a setting,
1660         we'll always return YES. However, we will use this opportunity to set the 'checked' state
1661         of each item.
1662
1663
1664         (-[SettingsController _toggleBooleanDefault:]):
1665         Toggle the given boolean default, and notify BrowserAppDelegate that something changed.
1666
1667         (-[SettingsController toggleUseWebKit2ByDefault:]):
1668         (-[SettingsController useWebKit2ByDefault]):
1669         (-[SettingsController toggleUseTransparentWindows:]):
1670         (-[SettingsController useTransparentWindows]):
1671         (-[SettingsController toggleUsePaginatedMode:]):
1672         (-[SettingsController usePaginatedMode]):
1673         (-[SettingsController toggleUseUISideCompositing:]):
1674         (-[SettingsController useUISideCompositing]):
1675         (-[SettingsController toggleShowLayerBorders:]):
1676         (-[SettingsController layerBordersVisible]):
1677         (-[SettingsController toggleShowTiledScrollingIndicator:]):
1678         (-[SettingsController tiledScrollingIndicatorVisible]):
1679         (-[SettingsController toggleEnableSubPixelCSSOMMetrics:]):
1680         (-[SettingsController subPixelCSSOMMetricsEnabled]):
1681         (-[SettingsController defaultURL]):
1682         Toggle or return the current state of each preference.
1683
1684         * MiniBrowser/mac/WK1BrowserWindowController.m:
1685         (-[WK1BrowserWindowController awakeFromNib]):
1686         (-[WK1BrowserWindowController validateMenuItem:]):
1687         (-[WK1BrowserWindowController windowWillClose:]):
1688         (-[WK1BrowserWindowController find:]):
1689         (-[WK1BrowserWindowController dumpSourceToConsole:]):
1690         (-[WK1BrowserWindowController didChangeSettings]):
1691         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
1692         (-[WK1BrowserWindowController isPaginated]): Deleted.
1693         (-[WK1BrowserWindowController togglePaginationMode:]): Deleted.
1694         (-[WK1BrowserWindowController toggleTransparentWindow:]): Deleted.
1695         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
1696         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
1697         (-[WK1BrowserWindowController layerBordersVisible]): Deleted.
1698         (-[WK1BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
1699         * MiniBrowser/mac/WK2BrowserWindowController.m:
1700         (-[WK2BrowserWindowController awakeFromNib]):
1701         (-[WK2BrowserWindowController validateMenuItem:]):
1702         (-[WK2BrowserWindowController forceRepaint:]):
1703         (-[WK2BrowserWindowController windowWillClose:]):
1704         (-[WK2BrowserWindowController didChangeSettings]):
1705         (-[WK2BrowserWindowController isPaginated]): Deleted.
1706         (-[WK2BrowserWindowController togglePaginationMode:]): Deleted.
1707         (-[WK2BrowserWindowController toggleTransparentWindow:]): Deleted.
1708         (-[WK2BrowserWindowController isUISideCompositingEnabled]): Deleted.
1709         (-[WK2BrowserWindowController toggleUISideCompositing:]): Deleted.
1710         (-[WK2BrowserWindowController layerBordersVisible]): Deleted.
1711         (-[WK2BrowserWindowController toggleLayerBordersVisibility:]): Deleted.
1712         (-[WK2BrowserWindowController tiledScrollingIndicatorVisible]): Deleted.
1713         (-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]): Deleted.
1714
1715 2014-08-01  Tim Horton  <timothy_horton@apple.com>
1716
1717         MiniBrowser doesn't support data URLs
1718         https://bugs.webkit.org/show_bug.cgi?id=135492
1719
1720         Reviewed by Simon Fraser.
1721
1722         * MiniBrowser/mac/BrowserWindowController.m:
1723         (-[BrowserWindowController addProtocolIfNecessary:]):
1724         Don't add http:// to data: URLs.
1725
1726         * MiniBrowser/mac/WK2BrowserWindowController.m:
1727         (-[WK2BrowserWindowController fetch:]):
1728         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
1729         Percent-escape the contents of the address field before trying to make a URL.
1730         Percent-unescape the URL when displaying it in the address field.
1731         This is not great, but trivial and good-enough-for-Minibrowser.
1732
1733 2014-07-31  Ryuan Choi  <ryuan.choi@samsung.com>
1734
1735         [EFL][WK2] MiniBrower comes to crash when combo box is pressed
1736         https://bugs.webkit.org/show_bug.cgi?id=135378
1737
1738         Reviewed by Gyuyoung Kim.
1739
1740         "clicked" signal of elm_menu is emitted after EwkView calls popup_menu_hide
1741         and removes Ewk_Popup_Menu instance.
1742
1743         * MiniBrowser/efl/main.c:
1744         (on_popup_menu_show):
1745         (on_popup_menu_discarded): Deleted.
1746
1747 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
1748
1749         [Win] Use RC_PROJECTBUILDVERSION as build portion of version
1750         https://bugs.webkit.org/show_bug.cgi?id=135478
1751
1752         Reviewed by David Kilzer.
1753
1754         Add new test suite for the version-stamp program.
1755
1756         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Added.
1757
1758 2014-07-31  Dan Bernstein  <mitz@apple.com>
1759
1760         Reverted r171893, because it broke http/tests/appcache/different-https-origin-resource-main.html,
1761         which loads HTTPS content without calling the delegate.
1762
1763         Rubber-stamped by Alexey Proskuryakov.
1764
1765         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1766         (WTR::InjectedBundle::platformInitialize):
1767         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1768         (WTR::InjectedBundle::platformInitialize):
1769
1770 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
1771
1772         Unreviewed typo correction (and build fix).
1773
1774         * MiniBrowser/mac/WK2BrowserWindowController.m:
1775         (-[WK2BrowserWindowController awakeFromNib]): Use correct
1776         property name (_fullScreenIsEnabled -> _fullScreenEnabled)
1777
1778 2014-07-31  Brent Fulgham  <bfulgham@apple.com>
1779
1780         MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
1781         https://bugs.webkit.org/show_bug.cgi?id=135482
1782
1783         Reviewed by Simon Fraser.
1784
1785         * MiniBrowser/mac/WK2BrowserWindowController.m:
1786         (-[WK2BrowserWindowController awakeFromNib]): Activate the Fullscreen
1787         feature.
1788
1789 2014-07-31  Alexey Proskuryakov  <ap@apple.com>
1790
1791         [Mac, iOS] Remove -setAllowsAnyHTTPSCertificate calls
1792         https://bugs.webkit.org/show_bug.cgi?id=135472
1793
1794         Reviewed by Dan Bernstein.
1795
1796         We now handle server trust challenges, and don't need such hacks.
1797
1798         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
1799         (WTR::InjectedBundle::platformInitialize):
1800         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1801         (WTR::InjectedBundle::platformInitialize):
1802
1803 2014-07-31  Alexey Proskuryakov  <ap@apple.com>
1804
1805         media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky
1806         on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions
1807         https://bugs.webkit.org/show_bug.cgi?id=135418
1808
1809         Reviewed by Anders Carlsson.
1810
1811         This was only happening in shared web process mode, because WKBundlePostMessage
1812         has different behavior then. When there is no process, the message is dropped on
1813         the floor in multiple process mode, but it's stored to be delivered after launch
1814         in shared process mode.
1815
1816         So, calling resetStateToConsistentValues() resulted in storing a Reset bundle message
1817         that was delivered immediately after launch, when there was nothing to reset.
1818
1819         We don't actually need to reset anything at this point, as the previous call has
1820         already reset everything UI process side, and web process is brand new. All we need
1821         is to reattach the page to a process, as invoke() expects one to exist.
1822
1823         * WebKitTestRunner/TestController.cpp: (WTR::TestController::reattachPageToWebProcess):
1824         * WebKitTestRunner/TestController.h:
1825         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
1826
1827 2014-07-31  Dan Bernstein  <mitz@apple.com>
1828
1829         [WK2] Regression tests can't load HTTPS pages with NetworkProcess due to self-signed certificate
1830         https://bugs.webkit.org/show_bug.cgi?id=115282
1831
1832         Reviewed by Sam Weinig.
1833
1834         * WebKitTestRunner/TestController.cpp:
1835         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true for any
1836         local host server trust protection space.
1837         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Respond with a non-empty
1838         credential to server trust challenges.
1839
1840 2014-07-31  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1841
1842         [webkitpy] Make diff_text generate correct diff if there is no newline at the end of file
1843         https://bugs.webkit.org/show_bug.cgi?id=135381
1844
1845         Reviewed by Csaba Osztrogonác.
1846
1847         * Scripts/webkitpy/port/base.py:
1848         (Port.diff_text):
1849         * Scripts/webkitpy/port/base_unittest.py:
1850         (PortTest.test_diff_text):
1851
1852 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1853
1854         Unreviewed. Fix GTK+ make distcheck.
1855
1856         * gtk/make-dist.py:
1857         (ensure_version_if_possible): Use 4.0 instead of 3.0 as binary
1858         version to find the pkg-config file.
1859         * gtk/manifest.txt: Add missing resource to the tarball.
1860
1861 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1862
1863         [GTK] make distcheck is building from sources dir instead of dist dir
1864         https://bugs.webkit.org/show_bug.cgi?id=135457
1865
1866         Reviewed by Philippe Normand.
1867
1868         * gtk/make-dist.py:
1869         (Distcheck.configure): Use dist_dir as source dir.
1870         (Distcheck.check): Pass dist_dir to configure().
1871
1872 2014-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1873
1874         [GTK] Do not include files that are not in git in the tarball
1875         https://bugs.webkit.org/show_bug.cgi?id=134804
1876
1877         Reviewed by Philippe Normand.
1878
1879         Skip all files in the source tree that are not under version control
1880         except for files added from the build dir like the documentation.
1881
1882         * gtk/make-dist.py:
1883         (Directory.__init__): Initialize the list of files under control version.
1884         (Directory.list_cms_files): Helper function to list all files
1885         under the control version for the current source root.
1886         (Directory.should_skip_file): Return True for files that are not
1887         under control version only when the source root is also under
1888         control version.
1889         (Directory.get_files): Filter the files also using should_skip_file().
1890
1891 2014-07-29  David Farler  <dfarler@apple.com>
1892
1893         iOS Simulator LayoutTestRelay
1894         https://bugs.webkit.org/show_bug.cgi?id=135269
1895
1896         Reviewed by David Kilzer.
1897
1898         * LayoutTestRelay/Configurations/Base.xcconfig: Added.
1899         * LayoutTestRelay/Configurations/DebugRelease.xcconfig: Added.
1900         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj: Added.
1901         * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.h: Added.
1902         * LayoutTestRelay/LayoutTestRelay/LTPipeRelay.m: Added.
1903         (-[LTPipeRelay inPipePath]):
1904         (-[LTPipeRelay outPipePath]):
1905         (-[LTPipeRelay errorPipePath]):
1906         (-[LTPipeRelay outputStream]):
1907         (-[LTPipeRelay initWithPrefix:]):
1908         (-[LTPipeRelay setup]):
1909         (-[LTPipeRelay tearDown]):
1910         (-[LTPipeRelay connect]):
1911         (-[LTPipeRelay disconnect]):
1912         (-[LTPipeRelay createFIFOs]):
1913         (-[LTPipeRelay destroyFIFOs]):
1914         (-[LTPipeRelay relayStream:]):
1915         (-[LTPipeRelay stream:handleEvent:]):
1916         * LayoutTestRelay/LayoutTestRelay/LTRelay.h: Added.
1917         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h: Added.
1918         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: Added.
1919         (-[LTRelayController uniqueAppPath]):
1920         (-[LTRelayController uniqueAppURL]):
1921         (-[LTRelayController uniqueAppIdentifier]):
1922         (-[LTRelayController processName]):
1923         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
1924         (-[LTRelayController readFileHandle:]):
1925         (-[LTRelayController receivedStandardOutputData:]):
1926         (-[LTRelayController receivedStandardErrorData:]):
1927         (-[LTRelayController disconnected]):
1928         (-[LTRelayController connected]):
1929         (-[LTRelayController crashWithMessage:]):
1930         (-[LTRelayController launchSimulator]):
1931         (-[LTRelayController bootDevice]):
1932         (-[LTRelayController createUniqueApp]):
1933         (-[LTRelayController killApp]):
1934         (-[LTRelayController launchApp]):
1935         (-[LTRelayController start]):
1936         * LayoutTestRelay/LayoutTestRelay/main.m: Added.
1937         (usage):
1938         (getTestingSimDevice):
1939         (getRequiredStringArgument):
1940         (getRemainderArguments):
1941         (main):
1942         * LayoutTestRelay/Makefile: Added.
1943         * Tools/Scripts/build-layouttestrelay: Added.
1944
1945 2014-07-29  Brent Fulgham  <bfulgham@apple.com>
1946
1947         [Win] Modify version numbering scheme to support 5-tuple versions
1948         https://bugs.webkit.org/show_bug.cgi?id=135400
1949         <rdar://problem/17849033>
1950
1951         Reviewed by David Kilzer.
1952
1953         Update test cases to recognize that we can only support Major
1954         values from 0-65535, Minor values from 0-64, Tiny values from 0-999,
1955         Micro values from 0-64, and Nano values from 0-999.
1956
1957         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Update
1958         test expectations for physical limits.
1959
1960 2014-07-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1961
1962         [GTK] GLib tests fail with recent GTK+ due to runtime warning about deprecated properties
1963         https://bugs.webkit.org/show_bug.cgi?id=135411
1964
1965         Reviewed by Sergio Villar Senin.
1966
1967         Recent versions of GTK+ now warn at runtime when a deprecated
1968         property or signal is used. A diagnostic mode was added that is
1969         enabled by default, but that can be disabled by setting
1970         G_ENABLE_DIAGNOSTIC=0. Runtime warnings are considered test
1971         failures by gtester, so we need to run the tests with the
1972         diganostic mode disabled.
1973
1974         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
1975         (main):
1976
1977 2014-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1978
1979         [GTK] Remove WebKitCertificateInfo from WebKit2GTK+ API
1980         https://bugs.webkit.org/show_bug.cgi?id=134830
1981
1982         Reviewed by Gustavo Noronha Silva.
1983
1984         Update the SSL test for the API changes.
1985
1986         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1987         (testLoadFailedWithTLSErrors):
1988
1989 2014-07-24  David Farler  <dfarler@apple.com>
1990
1991         Add knowledge of the iOS Simulator to webkitpy
1992         http://bugs.webkit.org/show_bug.cgi?id=133963
1993
1994         Reviewed by Simon Fraser.
1995
1996         * Scripts/webkitdirs.pm:
1997         (argumentsForConfiguration): Add --ios-sim*
1998         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1999         --runtime and --device-type args added.
2000         * Scripts/webkitpy/port/base.py:
2001         * Scripts/webkitpy/port/driver.py: Add simulator driver.
2002         (IOSSimulatorDriver): Added.
2003         * Scripts/webkitpy/port/factory.py: Add simulator platform.
2004         * Scripts/webkitpy/port/ios.py: Added.
2005
2006 2014-07-29  Alexey Proskuryakov  <ap@apple.com>
2007
2008         fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
2009         https://bugs.webkit.org/show_bug.cgi?id=135398
2010
2011         Reviewed by Zalan Bujtas.
2012
2013         * WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):
2014         "hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.
2015
2016         * DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.
2017         For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
2018         sure why.
2019
2020 2014-07-29  Alexey Proskuryakov  <ap@apple.com>
2021
2022         PPT: run-webkit-tests doesn't upload crash logs to bots
2023         https://bugs.webkit.org/show_bug.cgi?id=135391
2024
2025         Reviewed by Joseph Pecoraro.
2026
2027         * WebKitTestRunner/TestController.cpp: (WTR::TestController::processDidCrash):
2028         Not a fix to be proud of, but better than not having it work at all.
2029
2030 2014-07-29  Adrian Perez de Castro  <aperez@igalia.com>
2031
2032         [GTK] Remove WebKitWebViewGroup from WebKit2 GTK+ API
2033         https://bugs.webkit.org/show_bug.cgi?id=133729
2034
2035         Reviewed by Carlos Garcia Campos.
2036
2037         Removes WebKitWebViewGroup, effectively reverting the changes
2038         introduced by r149117. The motivation for WebKitWebViewGroup
2039         was using the user style sheet injection API, which has been
2040         moved into WebKitUserContentManager, rendering it unneeded.
2041
2042         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Remove tests
2043         for WebKitWebViewGroup.
2044         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2045         (testWebViewSettings):
2046         Restore the assertions that check that settings objects are
2047         released. Add test for webkit_web_view_new_with_settings().
2048         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Removed.
2049
2050 2014-07-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2051
2052         Implement webkit_web_view_load_string() in WebKit2
2053         https://bugs.webkit.org/show_bug.cgi?id=134735
2054
2055         Reviewed by Sergio Villar Senin.
2056
2057         Add /webkit2/WebKitWebView/load-bytes test case and simplify
2058         TestDOMXPathNSResolver by using webkit_web_view_load_bytes()
2059         instead of a soup server just to sent the Content-type header.
2060
2061         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
2062         (testWebKitDOMXPathNSResolverNative):
2063         (testWebKitDOMXPathNSResolverCustom):
2064         (beforeAll):
2065         (afterAll):
2066         (serverCallback): Deleted.
2067         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2068         (testLoadBytes):
2069         (beforeAll):
2070         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2071         (LoadTrackingTest::loadBytes):
2072         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
2073         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2074         (WebViewTest::loadBytes):
2075         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2076
2077 2014-07-28  Daniel Bates  <dabates@apple.com>
2078
2079         Add support for running the Clang static analyzer when building WebKit and JSC
2080         https://bugs.webkit.org/show_bug.cgi?id=134955
2081
2082         Reviewed by Brent Fulgham.
2083
2084         * Scripts/build-jsc: Added command line options -[no]-analyze (disabled by default).
2085         * Scripts/build-webkit: Add --analyze command line option to build-webkit to enable
2086         running the Clang static analyzer.
2087         * Scripts/webkitdirs.pm:
2088         (XcodeStaticAnalyzerOption): Added.
2089
2090 2014-07-24  David Farler  <dfarler@apple.com>
2091
2092         Allow for multiple DumpRenderTree and WebKitTestRunner instances in the iOS Simulator
2093         https://bugs.webkit.org/show_bug.cgi?id=135272
2094
2095         Reviewed by Simon Fraser.
2096
2097         * DumpRenderTree/mac/DumpRenderTree.mm:
2098         (dumpRenderTree): Remove hard-coding of FIFO paths.
2099         (-[DumpRenderTree applicationDidEnterBackground:]): Create background task.
2100         (DumpRenderTreeMain): Set DumpRenderTree as UIApplication delegate.
2101         * DumpRenderTree/mac/DumpRenderTreeMac.h: bgTask ivar.
2102         * Scripts/old-run-webkit-tests: Update FIFO paths for ORWT.
2103         * WebKitTestRunner/TestController.cpp: Remove hard-coding of FIFO paths.
2104         * WebKitTestRunner/ios/TestControllerIOS.mm: Move dup2 calls to platformInitialize
2105         * WebKitTestRunner/ios/mainIOS.mm: bgTask ivar.
2106         (-[WebKitTestRunnerApp applicationDidEnterBackground:]): Create background task.
2107         (main): Set WebKitTestRunnerApp as UIApplication delegate.
2108
2109 2014-07-24  David Farler  <dfarler@apple.com>
2110
2111         ImageDiff builds for the simulator when running iOS layout tests
2112         https://bugs.webkit.org/show_bug.cgi?id=135270
2113
2114         Reviewed by Simon Fraser.
2115
2116         * Scripts/build-imagediff: Added.
2117
2118 2014-07-28  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
2119
2120         Followup fix after r171594
2121         https://bugs.webkit.org/show_bug.cgi?id=135048
2122
2123         Reviewed by Csaba Osztrogonác.
2124
2125         * Scripts/sort-export-file: Removed extra newlines from help.
2126
2127 2014-07-25  Anders Carlsson  <andersca@apple.com>
2128
2129         WKNavigation's properties are either always nil or don't behave as documented
2130         https://bugs.webkit.org/show_bug.cgi?id=135267
2131         <rdar://problem/17730536>
2132
2133         Reviewed by Andreas Kling.
2134
2135         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2136         (-[NavigationDelegate webView:didStartProvisionalNavigation:]):
2137         (TEST):
2138         (-[DidFailProvisionalNavigationDelegate webView:didStartProvisionalNavigation:]):
2139         (-[DidFailProvisionalNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2140
2141 2014-07-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2142
2143         [GTK] install-dependencies needs to install perl-CGI on Fedora
2144         https://bugs.webkit.org/show_bug.cgi?id=135302
2145
2146         Reviewed by Martin Robinson.
2147
2148         * gtk/install-dependencies:
2149         Add perl-CGI to yum dependencies needed for tests
2150
2151 2014-07-25  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
2152
2153         Add --dry-run option to sort-export-file
2154         https://bugs.webkit.org/show_bug.cgi?id=135048
2155
2156         Reviewed by Csaba Osztrogonác.
2157
2158         Added --dry-run option to sort-export-file. Running the script with --dry-run
2159         option does not sort the export files but creates a list of the files that
2160         need to be sorted.
2161
2162         * Scripts/sort-export-file:
2163         (sawError):
2164
2165 2014-07-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2166
2167         GTK jhbuild modules needs to build xserver with --disable-local-transport
2168         https://bugs.webkit.org/show_bug.cgi?id=135262
2169
2170         Reviewed by Martin Robinson.
2171
2172         * gtk/jhbuild.modules:
2173         Build X server with --disable-local-transport, since local transport
2174         is only supported on Solaris, SCO, and System V. Fixes build on
2175         Fedora.
2176
2177 2014-07-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2178
2179         [GTK] build-webkit script fails under jhbuild if ACLOCAL_FLAGS is unset
2180         https://bugs.webkit.org/show_bug.cgi?id=135065
2181
2182         Reviewed by Martin Robinson.
2183
2184         * jhbuild/jhbuild-wrapper:
2185         (ensure_jhbuild): do not assume jhbuild sets ACLOCAL_FLAGS
2186
2187 2014-07-23  Joseph Pecoraro  <pecoraro@apple.com>
2188
2189         Unreviewed iOS build fix after r171355.
2190
2191         * TestWebKitAPI/Configurations/Base.xcconfig:
2192         Since all the Tests/WebKit2Cocoa tests are already explicitly skipped on iOS,
2193         simplify to skipping all the tests in the directory. PlatformUtilities are not
2194         building on iOS, which means we are missing necessary Util functions.
2195
2196 2014-07-23  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2197
2198         [EFL] Fix build after r171454
2199         https://bugs.webkit.org/show_bug.cgi?id=135191
2200
2201         Reviewed by Csaba Osztrogonác.
2202
2203         * MiniBrowser/efl/CMakeLists.txt: Add path to new EWebKit2.h location .
2204
2205 2014-07-23  Ryuan Choi  <ryuan.choi@samsung.com>
2206
2207         [EFL] Do not generate forwarding header for ewk headers
2208         https://bugs.webkit.org/show_bug.cgi?id=135147
2209
2210         Reviewed by Gyuyoung Kim.
2211
2212         * WebKitTestRunner/EventSenderProxy.h:
2213
2214 2014-07-21  Sam Weinig  <sam@webkit.org>
2215
2216         [Cocoa] WKScriptMessageHandlers don't seem to function properly after navigating
2217         https://bugs.webkit.org/show_bug.cgi?id=135148
2218
2219         Reviewed by Geoffrey Garen.
2220
2221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2222         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm: Added.
2223         (-[SimpleNavigationDelegate webView:didFinishNavigation:]):
2224         (-[ScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2225
2226 2014-07-22  Brent Fulgham  <bfulgham@apple.com>
2227
2228         Correct handling of __VERSION_TEXT__ for 4+-tuple versions
2229         https://bugs.webkit.org/show_bug.cgi?id=135161
2230         <rdar://problem/17763546>
2231
2232         Reviewed by David Kilzer.
2233
2234         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
2235         Add additional test cases to catch errors in multiple-tuple
2236         version string handling.
2237
2238 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2239
2240         Extend exception fuzzing to the LLInt
2241         https://bugs.webkit.org/show_bug.cgi?id=135076
2242
2243         Reviewed by Oliver Hunt.
2244
2245         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2246
2247 2014-07-22  Jochen Eisinger  <jochen@chromium.org>
2248
2249         Fix my email address in contributors.json
2250         https://bugs.webkit.org/show_bug.cgi?id=135156
2251
2252         Reviewed by Gyuyoung Kim.
2253
2254         * Scripts/webkitpy/common/config/contributors.json:
2255
2256 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
2257
2258         Unreviewed test fix.
2259
2260         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Revert
2261         to older Perl 5.8 syntax for iterating over hashes to allow tests to
2262         run on Mountain Lion bots.
2263
2264 2014-07-21  Alexey Proskuryakov  <ap@apple.com>
2265
2266         https://bugs.webkit.org/show_bug.cgi?id=135137
2267         build.webkit.org/dashboard: webkitperl failures show up as yellow, not red
2268
2269         Reviewed by Darin Adler.
2270
2271         webkitperl results are binary, handle them the same way we handle bindings test results.
2272
2273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2274         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2275         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
2276
2277 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
2278
2279         [Win] Follow-up for r171324.
2280
2281         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Cygwin
2282         perl reports itself as 'cygwin'; native Windows Perl reports as
2283         'MSWin32'. We need to handle both cases.
2284
2285 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
2286
2287         Unreviewed build fix after r171319.
2288
2289         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: This test should
2290         only execute on Windows. It will fail on other platforms, so give it a way to
2291         successfully exit.
2292
2293 2014-07-21  Brent Fulgham  <bfulgham@apple.com>
2294
2295         [Win] Extend auto-version.pl to support 5-tuple versions
2296         https://bugs.webkit.org/show_bug.cgi?id=135124
2297         <rdar://problem/17750334>
2298
2299         Reviewed by David Kilzer.
2300
2301         Add test cases for auto-version.pl.
2302
2303         * Scripts/webkitperl/auto-version_unittest: Added.
2304         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Added.
2305
2306 2014-07-21  Dean Jackson  <dino@apple.com>
2307
2308         Allow MiniBrowser WK1 to do element fullscreen
2309         https://bugs.webkit.org/show_bug.cgi?id=135125
2310
2311         Reviewed by Simon Fraser.
2312
2313         Allow WK1 windows to go fullscreen using the DOM API.
2314
2315         * MiniBrowser/mac/WK1BrowserWindowController.m:
2316         (-[WK1BrowserWindowController awakeFromNib]): Enable the preference for
2317         fullscreen.
2318
2319 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2320
2321         [GTK] Documentation files are added twice to the tarball
2322         https://bugs.webkit.org/show_bug.cgi?id=135115
2323
2324         Reviewed by Sergio Villar Senin.
2325
2326         * gtk/manifest.txt: Remove duplicated rules.
2327
2328 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2329
2330         [GTK] Simplify make-dist command line arguments
2331         https://bugs.webkit.org/show_bug.cgi?id=134832
2332
2333         Reviewed by Martin Robinson.
2334
2335         Remove --tarball-root and -o command line options and add
2336         --version, since the version can be used to build both, the
2337         tarball root and the output filename. When the version it's not
2338         provided, the pkg-config file is used to get the version. Also
2339         change the default value of build-dir to the current directory,
2340         since it's very common to call make-dist.py from the build dir.
2341
2342         * gtk/make-dist.py:
2343         (get_tarball_root_and_output_filename_from_arguments):
2344
2345 2014-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2346
2347         [GTK] Reduce the size of the tarball generated by distcheck
2348         https://bugs.webkit.org/show_bug.cgi?id=134802
2349
2350         Reviewed by Martin Robinson.
2351
2352         Add more rules to the manifest to decide what files to add:
2353
2354           - Do not include platform specific directories of other ports.
2355           - Do not include port specific cmake files.
2356           - Do not include Objective-C sources.
2357           - Do not include .orig and .rej files.
2358           - Do not include mac specific sandbox files.
2359           - Only include the resources we actually build.
2360
2361         * gtk/manifest.txt:
2362
2363 2014-07-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
2364
2365         [EFL] Enable mpg123 feature for gst-plugin-bad.
2366         https://bugs.webkit.org/show_bug.cgi?id=135016
2367
2368         Reviewed by Laszlo Gombos.
2369
2370         enable-mpg123 feature is added to jhbuild in order to support playback of mp3 format.
2371
2372         * efl/install-dependencies:
2373         * efl/jhbuild.modules:
2374
2375 2014-07-20  Dan Bernstein  <mitz@apple.com>
2376
2377         Test for <rdar://problems/17742611> -[_WKActivatedElementInfo image] is often empty
2378         https://bugs.webkit.org/show_bug.cgi?id=135107
2379
2380         Reviewed by Sam Weinig.
2381
2382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2383         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMNode.mm: Added.
2384         (-[RenderedImageFromDOMNodeFrameLoadDelegate webView:didFinishLoadForFrame:]):
2385         (TestWebKitAPI::TEST):
2386
2387 2014-07-20  David Kilzer  <ddkilzer@apple.com>
2388
2389         Checker: Value stored to 'kernResult' is never read (LayoutTestHelper.m:164)
2390         <http://webkit.org/b/135096>
2391
2392         Reviewed by Alexey Proskuryakov.
2393
2394         * DumpRenderTree/mac/LayoutTestHelper.m:
2395         (lockDownDiscreteGraphics): Check the return values of
2396         IOServiceOpen() and IOObjectRelease(), and log if not
2397         KERN_SUCCESS.
2398
2399 2014-07-19  Anders Carlsson  <andersca@apple.com>
2400
2401         Update.
2402
2403         * Scripts/webkitpy/common/config/watchlist:
2404
2405 2014-07-18  Sam Weinig  <sam@webkit.org>
2406
2407         Revert accidental commit to MiniBrowser to make everything layer backed.
2408
2409         * MiniBrowser/mac/BrowserWindowController.m:
2410         (-[BrowserWindowController windowDidLoad]):
2411
2412 2014-07-18  Dana Burkart  <dburkart@apple.com>
2413
2414         Add a new 'analyze' target to the makefile. This will make use of a new
2415         'PATH_TO_SCAN_BUILD' which, if set will wrap xcodebuild in the clang
2416         static analyzer.
2417         https://bugs.webkit.org/show_bug.cgi?id=135057
2418         <rdar://problem/10193187>
2419
2420         Reviewed by David Kilzer.
2421
2422         * Makefile:
2423
2424 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2425
2426         Fix EFL+GTK.
2427
2428         * Scripts/run-jsc-stress-tests:
2429
2430 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2431
2432         Exception fuzzing should work on iOS
2433         https://bugs.webkit.org/show_bug.cgi?id=135070
2434
2435         Reviewed by Mark Hahnenberg.
2436
2437         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2438         (fail):
2439         * Scripts/run-jsc-stress-tests:
2440
2441 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2442
2443         run-jsc-stress-tests should be able to run helper-based tests in remote mode
2444         https://bugs.webkit.org/show_bug.cgi?id=135064
2445
2446         Reviewed by Mark Hahnenberg.
2447
2448         * Scripts/run-jsc-stress-tests:
2449
2450 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2451
2452         run-jsc-stress-tests: rename $copy to $doNotMessWithVMPath
2453         https://bugs.webkit.org/show_bug.cgi?id=135061
2454
2455         Rubber stamped by Mark Hahnenberg.
2456
2457         * Scripts/run-jsc-stress-tests:
2458
2459 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2460
2461         Refactor run-jsc-stress-tests VM copying code to remove some abstractions
2462         https://bugs.webkit.org/show_bug.cgi?id=135059
2463
2464         Reviewed by Mark Lam.
2465         
2466         This is meant to make it easier for me to extend the copying functionality to copy things other than
2467         the framework.
2468
2469         * Scripts/run-jsc-stress-tests:
2470
2471 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2472
2473         Fix cloop build.
2474
2475         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2476
2477 2014-07-18  Renato Nagy  <nagy.renato@stud.u-szeged.hu>
2478
2479         Fix -v|--verbose option in sort-export-file script.
2480         https://bugs.webkit.org/show_bug.cgi?id=135043
2481
2482         Reviewed by Tim Horton.
2483
2484         -v|--verbose option does not work. Option added to getOptionsResult.
2485
2486         * Scripts/sort-export-file:
2487
2488 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2489
2490         Really remove dependency on ShellQuote.
2491
2492         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2493
2494 2014-07-18  Filip Pizlo  <fpizlo@apple.com>
2495
2496         Unreviewed, fix build for platforms that don't have ShellQuote.
2497         
2498         * Scripts/jsc-stress-test-helpers/js-exception-fuzz: Take a single argument that has the whole command string.
2499         * Scripts/run-jsc-stress-tests: Do the escaping in Ruby.
2500
2501 2014-07-15  Filip Pizlo  <fpizlo@apple.com>
2502
2503         Need ability to fuzz exception throwing
2504         https://bugs.webkit.org/show_bug.cgi?id=134945
2505         <rdar://problem/17722027>
2506
2507         Reviewed by Sam Weinig.
2508         
2509         Adds a new script, js-exception-fuzz, which will run some jsc command-line using
2510         exception fuzzing. This means that we will force exceptions to be thrown in random
2511         places to see how the engine reacts. This is now integrated with the various test
2512         drivers, so run-javascriptcore-tests will run some exception fuzzing tests by
2513         default.
2514
2515         * Scripts/jsc-stress-test-helpers/js-exception-fuzz: Added.
2516         (fail):
2517         * Scripts/run-javascriptcore-tests:
2518         * Scripts/run-jsc-stress-tests:
2519
2520 2014-07-17  Sam Weinig  <sam@webkit.org>
2521
2522         Fix failing API tests.
2523
2524         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2525         (-[ActiveOffscreenWindow isVisible]):
2526         Override isVisible to make the NSWindows pretend they are visible.
2527
2528 2014-07-17  Alexey Proskuryakov  <ap@apple.com>
2529
2530         Disable button animations in regression tests
2531         https://bugs.webkit.org/show_bug.cgi?id=133647
2532         <rdar://problem/16677530>
2533
2534         Reviewed by Dean Jackson.
2535
2536         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2537         We already did this for WebKit2, let's do it for WebKit1 too.
2538
2539 2014-07-16  Alexey Proskuryakov  <ap@apple.com>
2540
2541         A test that hangs at cleanup stage confuses webkitpy hugely
2542         https://bugs.webkit.org/show_bug.cgi?id=122475
2543         <rdar://problem/17184354>
2544
2545         Reviewed by Anders Carlsson.
2546
2547         Terminate WebContent process if it freezes between tests. Ideally, we should report
2548         this somehow, but this is better than blaming the wrong test.
2549
2550         * WebKitTestRunner/TestController.cpp:
2551         (WTR::TestController::terminateWebContentProcess):
2552         * WebKitTestRunner/TestController.h:
2553         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
2554
2555 2014-07-16  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2556
2557         Change style check path with EFL WK2's path in checker_unittest.py
2558         https://bugs.webkit.org/show_bug.cgi?id=134967
2559
2560         Reviewed by Csaba Osztrogonác.
2561
2562         * Scripts/webkitpy/style/checker_unittest.py: Change ewk_view.h path.
2563         (GlobalVariablesTest.test_path_rules_specifier):
2564
2565 2014-07-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2566
2567         Unreviewed. Added myself to the list of committers.
2568
2569         * Scripts/webkitpy/common/config/contributors.json:
2570
2571 2014-07-15  Ryuan Choi  <ryuan.choi@samsung.com>
2572
2573         [EFL] Remove EFL WK1 directory from the checker.py
2574         https://bugs.webkit.org/show_bug.cgi?id=134954
2575
2576         Reviewed by Gyuyoung Kim.
2577
2578         * Scripts/webkitpy/style/checker.py:
2579
2580 2014-07-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2581
2582         Adding myself to contributors.json breaks a webkitpy test
2583         https://bugs.webkit.org/show_bug.cgi?id=134958
2584
2585         Reviewed by Ryosuke Niwa.
2586
2587         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2588         (IRCCommandTest.test_whois): Be more specific and include also the
2589         first name when asking for the whois of Xan in the unit test.
2590
2591 2014-07-14  Daniel Bates  <dabates@apple.com>
2592
2593         check-webkit-style should apply C++ rules to Objective-C++ files
2594         https://bugs.webkit.org/show_bug.cgi?id=134884
2595
2596         Reviewed by Joseph Pecoraro.
2597
2598         Fixes an issue where check-webkit-style doesn't apply applicable C++ rules to
2599         Objective-C++ files.
2600
2601         Currently check-webkit-style doesn't apply the following rules to Objective-C++
2602         files: build/using_std, runtime/max_min_macros, runtime/wtf_move, readability/null.
2603         Instead, we should teach check-webkit-style to apply these rules because, as
2604         its name implies, an Objective-C++ file may contain C++ code.
2605
2606         * Scripts/webkitpy/style/checkers/cpp.py:
2607         (_FileState.__init__): Add instance variable _is_objective_cpp to track whether a file has
2608         extension mm (i.e. an Objective-C++ file).
2609         (_FileState.is_objective_c_or_objective_cpp): Added; returns true if the file
2610         has extension m or mm or if the file has extension h and contains Objective-C directives.
2611         (check_for_null): No change in behavior; don't apply rule to Objective-C++ file.
2612         (check_identifier_name_in_declaration): Substitute _FileState.is_objective_c_or_objective_cpp() for
2613         _FileState.is_c_or_objective_c()
2614         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2615         (WebKitStyleTest.test_null_false_zero): Added test case for Objective-C++ file.
2616         (WebKitStyleTest.test_max_macro): Add test case for Objective-C and Objective-C++ file.
2617         (WebKitStyleTest.test_min_macro): Ditto.
2618         (WebKitStyleTest.test_wtf_move): Add test case for Objective-C++ file.
2619
2620 2014-07-14  Anders Carlsson  <andersca@apple.com>
2621
2622         Make shouldKeepCurrentBackForwardListItemInList part of WKPageLoaderClientV5 to avoid breaking ABI
2623         https://bugs.webkit.org/show_bug.cgi?id=134889
2624
2625         Reviewed by Beth Dakin.
2626
2627         Bump loader version number to 5.
2628
2629         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
2630         (TestWebKitAPI::setPageLoaderClient):
2631         * WebKitTestRunner/TestController.cpp:
2632         (WTR::TestController::createWebViewWithOptions):
2633
2634 2014-07-14  Daniel Bates  <dabates@apple.com>
2635
2636         Teach check-webkit-style to suggest WTF::move() when it sees std::move()
2637         https://bugs.webkit.org/show_bug.cgi?id=134620
2638
2639         Reviewed by Joseph Pecoraro.
2640
2641         * Scripts/webkitpy/style/checkers/cpp.py:
2642         (check_max_min_macros): Fix up comment so that it reads well.
2643         (check_wtf_move): Added.
2644         (check_style): Modified to call check_wtf_move().
2645         (CppChecker): Add category "runtime/wtf_move".
2646         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2647         (WebKitStyleTest.test_wtf_move): Added.
2648
2649 2014-07-12  Peter Szanka  <h868064@stud.u-szeged.hu>
2650
2651         Style checker complains about namespace indentation when there is no namespace
2652         https://bugs.webkit.org/show_bug.cgi?id=105427
2653
2654         Reviewed by Darin Adler.
2655
2656         * Scripts/webkitpy/style/checkers/cpp.py:
2657         (check_namespace_indentation):
2658         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2659         (WebKitStyleTest.test_indentation):
2660
2661         The indentation level depends on the parantheses too, to avoid false warning in case of several statements inside macros.
2662
2663 2014-07-12  Daker Fernandes Pinheiro  <daker.pinheiro@openbossa.org>
2664
2665         Remove excessive nesting from _EnumState.process_clean_line at cpp style checker
2666         https://bugs.webkit.org/show_bug.cgi?id=125317
2667
2668         Reviewed by Darin Adler.
2669
2670         * Scripts/webkitpy/style/checkers/cpp.py:
2671         (_EnumState.process_clean_line):
2672
2673 2014-07-12  Brian Holt  <brian.holt@samsung.com>
2674
2675         Style Checker should prevent enums in bitfields
2676         https://bugs.webkit.org/show_bug.cgi?id=57352
2677
2678         Reviewed by Darin Adler.
2679
2680         Added check that enums are not used as types for bitfields
2681         and a unit test.
2682
2683         * Scripts/webkitpy/style/checkers/cpp.py:
2684         (check_language):
2685         (CppChecker):
2686         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2687         (CppStyleTest):
2688         (CppStyleTest.test_enum_bitfields):
2689         (CppStyleTest.test_plain_integral_bitfields):
2690
2691 2014-07-10  Myles C. Maxfield  <mmaxfield@apple.com>
2692
2693         [iOS] Pasting rich content does not perform a two-step paste
2694         https://bugs.webkit.org/show_bug.cgi?id=134795
2695
2696         Reviewed by Benjamin Poulain.
2697
2698         Two-step paste requires setting InputViewObeysDOMFocus on the UIWebBrowserView.
2699
2700         * DumpRenderTree/mac/DumpRenderTree.mm:
2701         (createWebViewAndOffscreenWindow):
2702
2703 2014-07-10  Carlos Garcia Campos  <cgarcia@igalia.com> and Martin Robinson  <mrobinson@igalia.com>
2704
2705         [GTK][CMake] Add a 'distcheck' target
2706         https://bugs.webkit.org/show_bug.cgi?id=130675
2707
2708         Reviewed by Gustavo Noronha Silva.
2709
2710         Add --check option to make-dist script that builds and installs the tarball.
2711
2712         * gtk/make-dist.py:
2713         (Distcheck.__init__):
2714         (Distcheck.extract_tarball): Extratc the tarball.
2715         (Distcheck.configure): Run cmake.
2716         (Distcheck.configure.create_dir): Helper function to create a directory.
2717         (Distcheck.build): Run make.
2718         (Distcheck.install): Run make install.
2719         (Distcheck.clean): Clean up the extracted tarball.
2720         (Distcheck.check): Run all previous methods in order.
2721         * gtk/manifest.txt: Add missing file.
2722
2723 2014-07-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2724
2725         [GTK] Use the same default options for production builds that previous stable releases
2726         https://bugs.webkit.org/show_bug.cgi?id=134589
2727
2728         Reviewed by Martin Robinson.
2729
2730         Make sure all features enabled in production builds are also
2731         enabled in developer mode.
2732
2733         * Scripts/webkitperl/FeatureList.pm: Enable ACCELERATED_2D_CANVAS
2734         and CSS_FILTERS for the GTK port.
2735
2736 2014-07-09  Brent Fulgham  <bfulgham@apple.com>
2737
2738         [Win] Remove uses of 'bash' in build system
2739         https://bugs.webkit.org/show_bug.cgi?id=134782
2740         <rdar://problem/17615533>
2741
2742         Reviewed by Dean Jackson.
2743
2744         Remove uses of 'bash' by replacing Windows-specific bash scripts
2745         with Perl equivalents.
2746
2747         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
2748         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
2749         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
2750         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
2751         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
2752         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
2753
2754 2014-07-09  Brent Fulgham  <bfulgham@apple.com>
2755
2756         [Win] Remove use of 'grep' in build steps
2757         https://bugs.webkit.org/show_bug.cgi?id=134770
2758         <rdar://problem/17608783>
2759
2760         Reviewed by Tim Horton.
2761
2762         Replace uses of the grep command in Windows builds with the equivalent
2763         Perl program.
2764
2765         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd:
2766         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd:
2767         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd:
2768         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd:
2769         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd:
2770         * WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd:
2771
2772 2014-07-09  Commit Queue  <commit-queue@webkit.org>
2773
2774         Unreviewed, rolling out r170889.
2775         https://bugs.webkit.org/show_bug.cgi?id=134754
2776
2777         This patch is wrong (Requested by philn on #webkit).
2778
2779         Reverted changeset:
2780
2781         "[GTK] Gstreamer missing from the install-dependencies script"
2782         https://bugs.webkit.org/show_bug.cgi?id=134727
2783         http://trac.webkit.org/changeset/170889
2784
2785 2014-07-08  Brian J. Burg  <burg@cs.washington.edu>
2786
2787         resolve-ChangeLogs fails when WebKit repository is a git submodule
2788         https://bugs.webkit.org/show_bug.cgi?id=134734
2789
2790         Reviewed by David Kilzer.
2791
2792         When using resolve-ChangeLogs in a WebKit git repository with a
2793         non-default arrangement of GIT_DIR and GIT_WORK_TREE, incorrect
2794         paths are computed and the script fails mysteriously.
2795
2796         We were naively computing GIT_WORK_TREE as being one level above
2797         GIT_DIR, but this is not the case for submodules or a manually
2798         configured GIT_WORK_TREE or GIT_DIR location.
2799
2800         * Scripts/VCSUtils.pm:
2801         (gitTreeDirectory): Added. Find the equivalent of GIT_WORK_TREE.
2802         (determineVCSRoot): Calculate the working tree root directly.
2803
2804 2014-07-08  Tim Horton  <timothy_horton@apple.com>
2805
2806         [WK2] Expose a few drawing/compositing settings on WKPreferences(Private)
2807         https://bugs.webkit.org/show_bug.cgi?id=134645
2808
2809         Reviewed by Dan Bernstein.
2810
2811         * MiniBrowser/mac/BrowserWindowController.h:
2812         * MiniBrowser/mac/MainMenu.xib:
2813         Add menu items for layer borders and the tiled scrolling indicator.
2814
2815         * MiniBrowser/mac/WK1BrowserWindowController.m:
2816         (-[WK1BrowserWindowController validateMenuItem:]):
2817         (-[WK1BrowserWindowController layerBordersAreVisible]):
2818         (-[WK1BrowserWindowController toggleLayerBordersVisibility:]):
2819         Add getters/setters/validators for layer borders.
2820
2821         * MiniBrowser/mac/WK2BrowserWindowController.m:
2822         (-[WK2BrowserWindowController awakeFromNib]):
2823         (-[WK2BrowserWindowController validateMenuItem:]):
2824         (-[WK2BrowserWindowController layerBordersAreVisible]):
2825         (-[WK2BrowserWindowController toggleLayerBordersVisibility:]):
2826         (-[WK2BrowserWindowController tiledScrollingIndicatorIsVisible]):
2827         (-[WK2BrowserWindowController toggleTiledScrollingIndicatorVisibility:]):
2828         Add getters/setters/validators for layer borders and the tiled scrolling indicator.
2829
2830         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]): Deleted.
2831         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]): Deleted.
2832         Remove the WebKit2 version of the subpixel metrics pref, because it doesn't work, because
2833         nothing in WebKit2 reads this default, and there is no WebKit2 API for adjusting this preference.
2834
2835 2014-07-08  Adrian Perez de Castro  <aperez@igalia.com>
2836
2837         [GTK] Move user style sheet API out of WebKitWebViewGroup
2838         https://bugs.webkit.org/show_bug.cgi?id=134551
2839
2840         Reviewed by Carlos Garcia Campos.
2841
2842         Removes testing user style sheet injection from
2843         TestWebKitWebViewGroup and moves that into a new
2844         TestWebKitUserContentManager, adapting the existing tests to the new
2845         API. Also, it contains a new test case for
2846         webkit_web_view_new_with_user_content_manager().
2847
2848         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2849         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp: Added.
2850         (UserContentManagerTest::UserContentManagerTest):
2851         (testWebViewNewWithUserContentManager):
2852         (isStyleSheetInjectedForURLAtPath):
2853         (fillURLListFromPaths):
2854         (removeOldInjectedStyleSheetsAndResetLists):
2855         (testUserContentManagerInjectedStyleSheet):
2856         (serverCallback):
2857         (beforeAll):
2858         (afterAll):
2859         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
2860         (beforeAll):
2861         (afterAll):
2862         (isStyleSheetInjectedForURLAtPath): Deleted.
2863         (fillURLListFromPaths): Deleted.
2864         (removeOldInjectedStyleSheetsAndResetLists): Deleted.
2865         (testWebViewGroupInjectedStyleSheet): Deleted.
2866         (serverCallback): Deleted.
2867         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2868         (WebViewTest::WebViewTest):
2869         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2870
2871 2014-07-08  Ziran Sun  <ziran.sun@samsung.com>
2872
2873         [GTK] Gstreamer missing from the install-dependencies script
2874         https://bugs.webkit.org/show_bug.cgi?id=134727
2875
2876         Reviewed by Mario Sanchez Prada.
2877
2878         Added missing gstreamer dependencies for debian based systems.
2879
2880         * gtk/install-dependencies: Added 2 dependencies for apt-get.
2881
2882 2014-07-08  Myles C. Maxfield  <mmaxfield@apple.com>
2883
2884         Add myself to the watchlist for text-related files
2885         https://bugs.webkit.org/show_bug.cgi?id=134707
2886
2887         Reviewed by Timothy Horton.
2888
2889         * Scripts/webkitpy/common/config/watchlist:
2890
2891 2014-07-08  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
2892
2893         Add option to specify output file location in sunspider.
2894         https://bugs.webkit.org/show_bug.cgi?id=134339
2895
2896         Reviewed by Darin Adler.
2897
2898         * Scripts/run-sunspider:
2899
2900 2014-07-07  Alex Christensen  <achristensen@webkit.org>
2901
2902         Unreviewed build fix.
2903
2904         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2905         Make Common.cpp excluded from both 32-bit and 64-bit builds.
2906
2907 2014-07-07  Simon Fraser  <simon.fraser@apple.com>
2908
2909         Have MiniBrowser log and reload if the Web Content Process crashes
2910         https://bugs.webkit.org/show_bug.cgi?id=134691
2911
2912         Reviewed by Tim Horton.
2913         
2914         Implement _webViewWebProcessDidCrash, log and reload when the web process
2915         crashes.
2916
2917         * MiniBrowser/mac/WK2BrowserWindowController.m:
2918         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]):
2919
2920 2014-07-07  Alberto Garcia  <berto@igalia.com>
2921
2922         update-webkitgtk-libs script fails by unsatisfied dependencies
2923         https://bugs.webkit.org/show_bug.cgi?id=134547
2924
2925         Reviewed by Martin Robinson.
2926
2927         Install libxcb-xfixes0-dev, needed to build Mesa.
2928
2929         * gtk/install-dependencies:
2930
2931 2014-07-06  Yoav Weiss  <yoav@yoav.ws>
2932
2933         Turn on img@sizes compile flag
2934         https://bugs.webkit.org/show_bug.cgi?id=134634
2935
2936         Reviewed by Benjamin Poulain.
2937
2938         * Scripts/webkitperl/FeatureList.pm: Turn on the img@sizes feature.
2939
2940 2014-07-06  Hyowon Kim  <hw1008.kim@samsung.com>
2941
2942         Unreviewed. Adding myself to committers.
2943
2944         * Scripts/webkitpy/common/config/contributors.json:
2945
2946 2014-07-05  KwangHyuk Kim  <hyuki.kim@samsung.com>
2947
2948         [EFL] Add libgeoclue-dev to Tools/efl/install-dependencies.
2949         https://bugs.webkit.org/show_bug.cgi?id=134648
2950
2951         Reviewed by Gyuyoung Kim.
2952
2953         As Geoclue is enabled for EFL, libgeoclue-dev is also added to Tools/efl/install-dependencies.
2954
2955         * efl/install-dependencies:
2956
2957 2014-07-04  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2958
2959         [EFL] Support Geolocation
2960         https://bugs.webkit.org/show_bug.cgi?id=134439
2961
2962         Reviewed by Antonio Gomes.
2963
2964         * Scripts/webkitperl/FeatureList.pm: Enable geolocation for EFL port.
2965
2966 2014-07-04  Shivakumar JM  <shiva.jm@samsung.com>
2967
2968         [EFL][WK2] Enhance the Minibrowser to show selected/highlighted text in search bar, if any.
2969         https://bugs.webkit.org/show_bug.cgi?id=134485
2970
2971         Reviewed by Gyuyoung Kim.
2972
2973         Use script_execute_callback to get selected/highlighted text and show in search bar.
2974
2975         * MiniBrowser/efl/main.c:
2976         (script_execute_callback):
2977         (on_key_down):
2978
2979 2014-07-04  Dan Bernstein  <mitz@apple.com>
2980
2981         Build fix after r170811.
2982
2983         * MiniBrowser/mac/WK2BrowserWindowController.m:
2984         (-[WK2BrowserWindowController reload:]):
2985
2986 2014-07-04  Timothy Horton  <timothy_horton@apple.com>
2987
2988         Typo in watchlist config means four specific people get Cc'd on everything
2989         https://bugs.webkit.org/show_bug.cgi?id=134626
2990
2991         Reviewed by Gyuyoung Kim.
2992
2993         * Scripts/webkitpy/common/config/watchlist:
2994         Remove leading pipe, which meant that this rule matched everything!
2995
2996 2014-07-03  Shivakumar JM  <shiva.jm@samsung.com>
2997
2998         [EFL][WK2] Enhance the Minibrowser to show text search count and close search bar.
2999         https://bugs.webkit.org/show_bug.cgi?id=134486
3000
3001         Reviewed by Gyuyoung Kim.
3002
3003         Use on_search_close_button_clicked() callback to close search bar and on_search_text_found() callback to show search count.
3004
3005         * MiniBrowser/efl/main.c:
3006         (search_box_show):
3007         (search_box_hide):
3008         (on_search_close_button_clicked):
3009         (on_search_text_found):
3010         (window_create):
3011
3012 2014-07-03  Daniel Bates  <dabates@apple.com>
3013
3014         Add WTF::move()
3015         https://bugs.webkit.org/show_bug.cgi?id=134500
3016
3017         Rubber-stamped by Anders Carlsson.
3018
3019         Substitute WTF::move() for std::move().
3020
3021         * DumpRenderTree/win/DRTDataObject.cpp:
3022         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3023         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3024         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3025         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3026         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3027         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added FIXME comments that explain that some of the sub-tests
3028         aren't actually testing move semantics in tests: MoveAssignmentFromSameType, MoveAssignmentFromSimilarType,
3029         ConstructionFromSameType, and ConstructionFromSimilarType.
3030         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
3031
3032 2014-07-03  László Langó  <llango.u-szeged@partner.samsung.com>
3033
3034         [JavaScriptCore] Add --cmakeargs option to build-jsc.
3035         https://bugs.webkit.org/show_bug.cgi?id=134590
3036
3037         Reviewed by Ryosuke Niwa.
3038
3039         * Scripts/build-jsc:
3040
3041 2014-07-03  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
3042
3043         Add option to specify jsc args in run-sunspider.
3044         https://bugs.webkit.org/show_bug.cgi?id=134341
3045
3046         Reviewed by Csaba Osztrogonác.
3047
3048         * Scripts/run-sunspider:
3049
3050 2014-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3051
3052         [GTK] Unreviewed gardening.
3053
3054         * Scripts/run-gtk-tests:
3055         (TestRunner): Report and mark flaky test WebKit2Gtk/TestCookieManager:persistent-storage
3056
3057 2014-07-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3058
3059         Clean up unused EFL buildbot information in BuildSlaveSupport and TestResultServer
3060         https://bugs.webkit.org/show_bug.cgi?id=134581
3061
3062         Reviewed by Tim Horton.
3063
3064         Should be removed unused EFL bot info.
3065
3066         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3067         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
3068         (EWS):
3069         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3070         (WebKitBuildbot):
3071         * TestResultServer/static-dashboards/builders.jsonp:
3072         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3073         (test):
3074
3075 2014-07-02  Alex Christensen  <achristensen@webkit.org>
3076
3077         Unreviewed.  Moved self to reviewers list.
3078
3079         * Scripts/webkitpy/common/config/contributors.json:
3080         Moved self to reviewers list, added WebGL to expertise.
3081
3082 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3083
3084         [GTK] Make dist only works when run from the source directory
3085         https://bugs.webkit.org/show_bug.cgi?id=134543
3086
3087         Reviewed by Martin Robinson.
3088
3089         Since the paths in the manifest are relative to the source dir,
3090         and the script expects the current working directory to be the
3091         source directory, resolve all passed in relative paths while
3092         parsing the arguments and then change the current working
3093         directory.
3094
3095         * gtk/make-dist.py:
3096
3097 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3098
3099         [GTK] make dist is broken
3100         https://bugs.webkit.org/show_bug.cgi?id=134542
3101
3102         Reviewed by Martin Robinson.
3103
3104         * gtk/make-dist.py: Rename command line options to match what cmake uses.
3105         * gtk/manifest.txt: Remove WebKit1 references and add WebKitDOM documentation.
3106
3107 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3108
3109         [GTK] WebKitWebView::create should receive information about the navigation action
3110         https://bugs.webkit.org/show_bug.cgi?id=133680
3111
3112         Reviewed by Martin Robinson.
3113
3114         Add unit test to check the WebKitNavigationAction passed to
3115         WebKitWebView::create callback.
3116
3117         * MiniBrowser/gtk/BrowserWindow.c:
3118         (webViewCreate): Add WebKitNavigationAction parameter.
3119         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
3120         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
3121         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3122         (testWebViewCreateNavigationData):
3123         (beforeAll):
3124         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
3125         (createCallback):
3126
3127 2014-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3128
3129         [GTK] Do not add forward declaration of class struct for interfaces
3130         https://bugs.webkit.org/show_bug.cgi?id=134297
3131
3132         Reviewed by Martin Robinson.
3133
3134         Add Iface symbol to documentation instead of Class for interfaces.
3135
3136         * gtk/webkitdom.py:
3137         (WebKitDOMDocGeneratorSections.write_section):
3138
3139 2014-07-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3140
3141         [GTK] XPathNSResolver should be exposed as an interface instead of as a class
3142         https://bugs.webkit.org/show_bug.cgi?id=134028
3143
3144         Reviewed by Gustavo Noronha Silva.
3145
3146         Add unit tests to check WebKitDOMXPathNSResolver API when using the
3147         native one and a user provided one.
3148
3149         * Scripts/webkitpy/style/checker.py: Add WebKitDOMXPathNSResolver
3150         to the list of GTK+ public API exceptions.
3151         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
3152         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp: Added.
3153         (webkitXPathNSResolverLookupNamespaceURI):
3154         (webkitXPathNSResolverDOMXPathNSResolverIfaceInit):
3155         (webkit_xpath_ns_resolver_init):
3156         (webkit_xpath_ns_resolver_class_init):
3157         (WebKitDOMXPathNSResolverTest::create):
3158         (WebKitDOMXPathNSResolverTest::webPageFromArgs):
3159         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3160         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3161         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3162         (WebKitDOMXPathNSResolverTest::runTest):
3163         (registerTests):
3164         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp: Added.
3165         (runTest):
3166         (testWebKitDOMXPathNSResolverNative):
3167         (testWebKitDOMXPathNSResolverCustom):
3168         (serverCallback):
3169         (beforeAll):
3170         (afterAll):
3171         * gtk/webkitdom.py:
3172         (WebKitDOMDocGeneratorSections.write_section): Add
3173         WebKitDOMXPathNSResolver to the list of interfaces.
3174
3175 2014-07-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3176
3177         Fix build break on EFL and GTK ports since r170683
3178         https://bugs.webkit.org/show_bug.cgi?id=134536
3179
3180         Unreviewed, build fix.
3181
3182         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3183
3184 2014-07-01  Sam Weinig  <sam@webkit.org>
3185
3186         [Cocoa][Mac] WKWebView should automatically set topContentInset when beneath a toolbar
3187         <rdar://problem/17523159>
3188         https://bugs.webkit.org/show_bug.cgi?id=134496
3189
3190         Reviewed by Beth Dakin.
3191
3192         * MiniBrowser/mac/BrowserWindowController.m:
3193         (-[BrowserWindowController windowDidLoad]):
3194         Use the NSFullSizeContentViewWindowMask bit on Yosemite and later to enable toolbar blurring.
3195
3196 2014-07-01  Zan Dobersek  <zdobersek@igalia.com>
3197
3198         [CMake] Add necessary support for building for the Wayland target
3199         https://bugs.webkit.org/show_bug.cgi?id=134160
3200
3201         Reviewed by Darin Adler.
3202
3203         * CMakeLists.txt: Only build the TestNetscapePlugIn target in case
3204         the X11 windowing target is enabled.
3205
3206 2014-07-01  Chris Fleizach  <cfleizach@apple.com>
3207
3208         AX: HTML indeterminate IDL attribute not mapped to checkbox value=2
3209         https://bugs.webkit.org/show_bug.cgi?id=134492
3210
3211         Reviewed by Andreas Kling.
3212
3213         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3214         (AccessibilityUIElement::isIndeterminate):
3215         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3216         (WTR::AccessibilityUIElement::isIndeterminate):
3217
3218 2014-07-01  Daniel Bates  <dabates@apple.com>
3219
3220         Remove unnecessary calls to std::move()
3221         https://bugs.webkit.org/show_bug.cgi?id=134493
3222
3223         Reviewed by Anders Carlsson.
3224
3225         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3226         (TestWebKitAPI::TEST):
3227         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3228         (TestWebKitAPI::TEST):
3229
3230 2014-07-01  Pratik Solanki  <psolanki@apple.com>
3231
3232         Unreviewed. Adding myself to the reviewers list to make commit bot happy.
3233
3234         * Scripts/webkitpy/common/config/contributors.json:
3235
3236 2014-07-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3237
3238         webkit-patch apply-from-bug / apply-attachment should not ask for credentials if none are required
3239         https://bugs.webkit.org/show_bug.cgi?id=40095
3240
3241         Reviewed by Csaba Osztrogonác.
3242
3243         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3244         (Bugzilla.fetch_attachment_contents): make a first fetch on bugzilla without authentication. If failing, use authentication (similar to fetch_bug_dictionary).
3245         (Bugzilla):
3246         (Bugzilla.bug_id_for_attachment_id): ditto.
3247
3248 2014-07-01  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3249
3250         [webkitpy] Refactor pluralizer in grammar.py
3251         https://bugs.webkit.org/show_bug.cgi?id=133067
3252
3253         Reviewed by Csaba Osztrogonác.
3254
3255         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3256         (LayoutTestRunner.run_tests):
3257         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3258         (Manager.run):
3259         * Scripts/webkitpy/layout_tests/views/printing.py:
3260         (Printer.print_found):
3261         (Printer.print_workers_and_shards):
3262         (Printer._print_one_line_summary):
3263         * Scripts/webkitpy/test/printer.py:
3264         (Printer.print_result):
3265         * Scripts/webkitpy/tool/bot/feeders.py:
3266         (EWSFeeder.feed):
3267         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3268         (FlakyTestReporter._lookup_bug_for_flaky_test):
3269         * Scripts/webkitpy/tool/bot/irc_command.py:
3270         (Rollout._check_diff_failure):
3271         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3272         (IRCCommandTest.test_rollout):
3273         * Scripts/webkitpy/tool/commands/download.py:
3274         (AbstractPatchProcessingCommand._process_patch.execute):
3275         (ProcessBugsMixin._fetch_list_of_patches_to_process):
3276         (ProcessURLsMixin._fetch_list_of_patches_to_process):
3277         * Scripts/webkitpy/tool/commands/queries.py:
3278         (WhatBroke.execute):
3279         * Scripts/webkitpy/tool/commands/suggestnominations.py:
3280         (SuggestNominations._print_nominations):
3281         (SuggestNominations._print_counts):
3282         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3283         (_make_options):
3284         (test_basic):
3285         (test_with_verbose):
3286         * Scripts/webkitpy/tool/commands/upload.py:
3287         (PostCommits.execute):
3288         * Scripts/webkitpy/tool/grammar.py:
3289         (pluralize):
3290         * Scripts/webkitpy/tool/grammar_unittest.py:
3291         (GrammarTest.test_join_with_separators):
3292         (GrammarTest):
3293         (GrammarTest.test_plural):
3294         (GrammarTest.test_pluralize):
3295         * Scripts/webkitpy/tool/multicommandtool.py:
3296         (Command.check_arguments_and_execute):
3297         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
3298         (ObsoletePatches.run):
3299         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3300         (PrepareChangeLogForRevert._message_for_revert):
3301
3302 2014-06-30  Myles C. Maxfield  <mmaxfield@apple.com>
3303
3304         [iOS] GSFontAddCGFont is deprecated and we use it in DumpRenderTree
3305         https://bugs.webkit.org/show_bug.cgi?id=134133
3306
3307         Reviewed by Simon Fraser.
3308
3309         Replace it with CTFontManagerRegisterGraphicsFont
3310
3311         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3312         * DumpRenderTree/mac/DumpRenderTree.mm:
3313         (activateFontIOS):
3314
3315 2014-06-30  Michael Saboff  <msaboff@apple.com>
3316
3317         Add option to run-jsc-stress-testes to filter out tests that use large heaps
3318         https://bugs.webkit.org/show_bug.cgi?id=134458
3319
3320         Reviewed by Filip Pizlo.
3321
3322         Added new --memory-limited to filter out tests that have large heap usage.
3323         Such tests are either tagged with //@largeHeap or logic is added to their .yaml file.
3324
3325         * Scripts/run-jsc-stress-tests:
3326
3327 2014-06-30  Myles C. Maxfield  <mmaxfield@apple.com>
3328
3329         DRT in iOS sim crashes while loading fonts
3330         https://bugs.webkit.org/show_bug.cgi?id=134451
3331
3332         Reviewed by Geoffrey Garen.
3333
3334         The magic linker symbols had the same name, and were therefore being unified
3335         to a single font file. Then, adding the same file twice was failing.
3336
3337         * DumpRenderTree/mac/DumpRenderTree.mm:
3338         (activateFontsIOS):
3339
3340 2014-06-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3341
3342         Remove Qt cruft from webkitpy
3343         https://bugs.webkit.org/show_bug.cgi?id=134445
3344
3345         Reviewed by Csaba Osztrogonác.
3346
3347         * Scripts/webkitpy/common/config/ports.py:
3348         (DeprecatedPort.port):
3349         (QtPort): Deleted.
3350         (QtPort.build_webkit_command): Deleted.
3351         (QtPort.run_webkit_tests_command): Deleted.
3352         (QtWK2Port): Deleted.
3353         (QtWK2Port.build_webkit_command): Deleted.
3354         (QtWK2Port.run_webkit_tests_command): Deleted.
3355         * Scripts/webkitpy/common/config/ports_unittest.py:
3356         (DeprecatedPortTest): Deleted.
3357         (DeprecatedPortTest.test_qt_port): Deleted.
3358         (DeprecatedPortTest.test_qt_wk2_port): Deleted.
3359
3360 2014-06-29  Yoav Weiss  <yoav@yoav.ws>
3361
3362         Add support for HTMLImageElement's sizes attribute
3363         https://bugs.webkit.org/show_bug.cgi?id=133620
3364
3365         Reviewed by Dean Jackson.
3366
3367         Added an ENABLE_PICTURE_SIZES compile flag.
3368
3369         * Scripts/webkitperl/FeatureList.pm:
3370
3371 2014-06-27  Tim Horton  <timothy_horton@apple.com>
3372
3373         check-webkit-style should check the order of #imports as well as #includes
3374         https://bugs.webkit.org/show_bug.cgi?id=134428
3375
3376         Reviewed by Dan Bernstein.
3377
3378         * Scripts/webkitpy/style/checkers/cpp.py:
3379         Allow "import" in addition to "include", so that the sort order of headers in ObjC files is checked.
3380
3381 2014-06-27  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3382
3383         [EFL] Remove efl-wk2 from baseline search path
3384         https://bugs.webkit.org/show_bug.cgi?id=134391
3385
3386         Reviewed by Gyuyoung Kim.
3387
3388         As WebKit1 EFL is removed and platform/efl and platform/efl-wk2 baselines and test expectations files
3389         are merged efl-wk2 search path should be removed.
3390
3391         * Scripts/webkitpy/port/base.py:
3392         (Port.test_expectations_file_postion): Added method to determine port test expectations file position in expectations_dict.
3393         * Scripts/webkitpy/port/efl.py:
3394         (EflPort._search_paths): Changed baseline search paths from efl-wk2 -> wk2 -> efl -> generic is changed to: efl -> wk2 -> generic.
3395         (EflPort.test_expectations_file_postion): Added method to determine EFL port specific test expectation file position.
3396         * Scripts/webkitpy/port/port_testcase.py:
3397         (PortTestCase.test_expectations_ordering): Changed constant value to one returned from test_expectations_file_postion().
3398         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3399         (TestExpectationsTestCase.test_determine_port_from_expectations_path): Removed efl-wk2 test case.
3400         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3401         (TestRebaselineTest.test_baseline_directory): Changed directory name in assertion from platform/efl-wk2 to platform/efl.
3402
3403 2014-06-26  Dan Bernstein  <mitz@apple.com>
3404
3405         prepare-ChangeLog outputs (NS_ENUM): entries for Cocoa enums
3406         https://bugs.webkit.org/show_bug.cgi?id=134387
3407
3408         Reviewed by Tim Horton.
3409
3410         * Scripts/prepare-ChangeLog:
3411         (get_function_line_ranges_for_cpp): Don’t consider {CF,NS}_{ENUM,OPTIONS} as function names.
3412
3413 2014-06-26  Dan Bernstein  <mitz@apple.com>
3414
3415         prepare-ChangeLog mangles Objective-C selectors for methods with parameter types that contain colons
3416         https://bugs.webkit.org/show_bug.cgi?id=134383
3417
3418         Reviewed by Tim Horton.
3419
3420         * Scripts/prepare-ChangeLog:
3421         (method_decl_to_selector): Strip out the return type and parameter types before splitting at
3422         colons.
3423
3424 2014-06-26  Brady Eidson  <beidson@apple.com>
3425
3426         MiniBrowser should support a preference to override the default URL
3427         https://bugs.webkit.org/show_bug.cgi?id=134373
3428
3429         Reviewed by Darin Adler.
3430
3431         * MiniBrowser/mac/AppDelegate.m:
3432         (-[BrowserAppDelegate applicationDidFinishLaunching:]): See if there’s a pref
3433           overriding the default URL, and use it if there is.
3434
3435 2014-06-26  Brent Fulgham  <bfulgham@apple.com>
3436
3437         [Win] Fix potential buffer overrun in DLLLauncher
3438         https://bugs.webkit.org/show_bug.cgi?id=134351
3439         <rdar://problem/17469185>
3440
3441         Reviewed by Darin Adler.
3442
3443         * win/DLLLauncher/DLLLauncherMain.cpp: Correct error
3444         in end-of-buffer calculation.
3445
3446 2014-06-26  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
3447
3448         [EFL] Missing dependency between freetype6 and fontconfig libs.
3449         https://bugs.webkit.org/show_bug.cgi?id=134190
3450
3451         Reviewed by Gyuyoung Kim.
3452
3453         The external dependencies contain the freetype6 and the fontconfig libs.
3454         The fontconfig lib requires freetype, but the dependency is not set in
3455         the efl/jhbuild.modules file. So, during building the external libs,
3456         fontconfig uses the freetype package of the system, while WebKit
3457         binaries will use freetype from the WebKitBuild/Dependency directory.
3458         There are more similar dependencies that were not indicated in the
3459         jhbuild.modules file.
3460
3461         * efl/jhbuild.modules:
3462           Added dependencies between libs.
3463
3464 2014-06-25  Brent Fulgham  <bfulgham@apple.com>
3465
3466         [Win] Expose Cache Information to WinLauncher
3467         https://bugs.webkit.org/show_bug.cgi?id=134318
3468
3469         Reviewed by Dean Jackson.
3470
3471         * WinLauncher/Common.cpp: Update for new dialog.
3472         * WinLauncher/WinLauncher.cpp: Add support for WebCache
3473         and WebCoreStatistics.
3474         * WinLauncher/WinLauncher.h:
3475         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
3476         Update for new Cache Dialog.
3477         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to
3478         WTF.lib
3479         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
3480         for new Dialog.
3481
3482 2014-06-26  Brent Fulgham  <bfulgham@apple.com>
3483
3484         [Win] Unreviewed gardening. Use consistent line-endings in file.
3485
3486         * WinLauncher/WinLauncher.h: Use '\n' EOL marker, not DOS-style
3487         '\r\n' EOL.
3488
3489 2014-06-25  László Langó  <llango.u-szeged@partner.samsung.com>
3490
3491         [JavaScriptCore] Make build-jsc output format better.
3492         https://bugs.webkit.org/show_bug.cgi?id=133547
3493
3494         Reviewed by Ryosuke Niwa.
3495
3496         * Scripts/build-jsc: Emit built time information on successful builds.
3497         (writeCongrats):
3498         * Scripts/build-webkit: Move formatBuildTime function into webkitdirs.pm.
3499         (cMakeArgsFromFeatures):
3500         (formatBuildTime): Deleted.
3501         * Scripts/webkitdirs.pm:
3502         (formatBuildTime):
3503
3504 2014-06-25  Chris Fleizach  <cfleizach@apple.com>
3505
3506         Add an undo group for each dictated utterance in WebKit
3507         https://bugs.webkit.org/show_bug.cgi?id=134086
3508
3509         Reviewed by Enrica Casucci.
3510
3511         Create a method for creating attributed strings with the undo insertion marker.
3512
3513         * DumpRenderTree/mac/TextInputController.m:
3514         (+[TextInputController isSelectorExcludedFromWebScript:]):
3515         (+[TextInputController webScriptNameForSelector:]):
3516         (-[TextInputController stringWithUndoGroupingInsertion:]):
3517
3518 2014-06-25  Michael Saboff  <msaboff@apple.com>
3519
3520         Provide javascript aware backtrace script for lldb
3521         https://bugs.webkit.org/show_bug.cgi?id=134276
3522
3523         Reviewed by Jer Noble.
3524
3525         * lldb/lldb_webkit.py:
3526         (__lldb_init_module):
3527         (btjs): New scripted command to display a backtrace that shows JavaScript frames with details.
3528
3529 2014-06-25  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3530
3531         REGRESSION (r170426) Broke two python tests
3532         https://bugs.webkit.org/show_bug.cgi?id=134299
3533
3534         Reviewed by Csaba Osztrogonác.
3535
3536         * Scripts/webkitpy/port/efl.py:
3537         (EflPort._search_paths): Added search path for efl-wk2.
3538
3539 2014-06-25  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3540
3541         [EFL] Remove WebKit1 related code from scripts
3542         https://bugs.webkit.org/show_bug.cgi?id=134195
3543
3544         Reviewed by Laszlo Gombos.
3545
3546         After removing WebKit1 from EFL port, still there is some code left related to DumpRenderTree, 
3547         EWebLauncher. Also running layout tests does not require adding -2/--webkit-test-runner switch.
3548
3549         * Scripts/run-launcher: MiniBrowser now runs as default without -2 switch.
3550         * Scripts/webkitdirs.pm:
3551         (builtDylibPathForName): Remove reference to libewebkit.so
3552         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3553         (_set_up_derived_options): Script runs WKTR by default.
3554         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3555         (PerfTestsRunner.__init__): Ditto.
3556         * Scripts/webkitpy/port/efl.py:
3557         (EflPort._search_paths): Remove efl-wk2 from baseline search path.
3558         (EflPort.show_results_html_file): Run MiniBrowser as result viewer.
3559
3560 2014-06-25  Laszlo Gombos  <l.gombos@samsung.com>
3561
3562         Remove build guard for progress element
3563         https://bugs.webkit.org/show_bug.cgi?id=134292
3564
3565         Reviewed by Benjamin Poulain.
3566
3567         * Scripts/webkitperl/FeatureList.pm:
3568
3569 2014-06-24  Tomas Popela  <tpopela@redhat.com>
3570
3571         [GTK] Some of DOM bindings macros are misnamed
3572         https://bugs.webkit.org/show_bug.cgi?id=121543
3573
3574         Reviewed by Carlos Garcia Campos.
3575
3576         As we are using WebKitDOM as a namespace we should unify all type macros
3577         to have WEBKIT_DOM_TYPE prefix instead of WEBKIT_TYPE_DOM. Also add
3578         more exceptions to decamelize function in GObject bindings generator
3579         to fix the names of bindings for BR, HR, UL, OL, DL and LI elements.
3580
3581         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
3582         * gtk/webkitdom.py:
3583         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
3584         (WebKitDOMDocGeneratorSections.write_section):
3585
3586 2014-06-24  Frédéric Wang  <fred.wang@free.fr>
3587
3588         [EFL] Install Latin Modern Math on the bots
3589         https://bugs.webkit.org/show_bug.cgi?id=134153
3590
3591         Reviewed by Gyuyoung Kim.
3592
3593         * efl/jhbuild.modules: Switch back to https://github.com/ for the webkitgtk-test-fonts.
3594
3595 2014-06-24  Frédéric Wang  <fred.wang@free.fr>
3596
3597         [EFL] [GTK] Use Latin Modern Math in the jhbuild environments.
3598         https://bugs.webkit.org/show_bug.cgi?id=134153
3599
3600         Reviewed by Martin Robinson.
3601
3602         * efl/jhbuild.modules: Use webkitgtk-test-fonts.git instead of the zip archive and upgrade to 0.0.5.
3603         * gtk/jhbuild.modules: Upgrade webkitgtk-test-fonts to 0.0.5.
3604
3605 2014-06-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3606
3607         Unreviewed, update my speciality.
3608
3609         * Scripts/webkitpy/common/config/contributors.json:
3610
3611 2014-06-24  Brent Fulgham  <bfulgham@apple.com>
3612
3613         [Win] Clean up and refactor WinLauncher
3614         https://bugs.webkit.org/show_bug.cgi?id=134209
3615
3616         Reviewed by Tim Thorton.
3617
3618         Relanding r170339 and r170340 with correct WinLauncher.h file.
3619
3620         * WinLauncher/Common.cpp: Copied from WinLauncher/WinLauncher.cpp.
3621         (PrintView):
3622         (ToggleMenuItem):
3623         (WndProc):
3624         (BackButtonProc):
3625         (ForwardButtonProc):
3626         (loadURL):
3627         (shouldUseFullDesktop): Deleted.
3628         (SimpleEventListener::SimpleEventListener): Deleted.
3629         (SimpleEventListener::handleEvent): Deleted.
3630         (WinLauncherWebHost::updateAddressBar): Deleted.
3631         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
3632         (WinLauncherWebHost::QueryInterface): Deleted.
3633         (WinLauncherWebHost::AddRef): Deleted.
3634         (WinLauncherWebHost::Release): Deleted.
3635         (updateMenuItemForHistoryItem): Deleted.
3636         (showLastVisitedSites): Deleted.
3637         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
3638         (resizeSubViews): Deleted.
3639         (setToDefaultPreferences): Deleted.
3640         (wWinMain): Deleted.
3641         (MyRegisterClass): Deleted.
3642         (LaunchInspector): Deleted.
3643         (NavigateForwardOrBackward): Deleted.
3644         (NavigateToHistory): Deleted.
3645         * WinLauncher/DOMDefaultImpl.cpp: Copied from WinLauncher/DOMDefaultImpl.h.
3646         (DOMEventListener::Release):
3647         (WebScriptObject::WebScriptObject): Deleted.
3648         (WebScriptObject::~WebScriptObject): Deleted.
3649         (WebScriptObject::throwException): Deleted.
3650         (WebScriptObject::callWebScriptMethod): Deleted.
3651         (WebScriptObject::evaluateWebScript): Deleted.
3652         (WebScriptObject::removeWebScriptKey): Deleted.
3653         (WebScriptObject::stringRepresentation): Deleted.
3654         (WebScriptObject::webScriptValueAtIndex): Deleted.
3655         (WebScriptObject::setWebScriptValueAtIndex): Deleted.
3656         (WebScriptObject::setException): Deleted.
3657         (DOMEventListener::throwException): Deleted.
3658         (DOMEventListener::callWebScriptMethod): Deleted.
3659         (DOMEventListener::evaluateWebScript): Deleted.
3660         (DOMEventListener::removeWebScriptKey): Deleted.
3661         (DOMEventListener::stringRepresentation): Deleted.
3662         (DOMEventListener::webScriptValueAtIndex): Deleted.
3663         (DOMEventListener::setWebScriptValueAtIndex): Deleted.
3664         (DOMEventListener::setException): Deleted.
3665         (DOMEventListener::handleEvent): Deleted.
3666         * WinLauncher/DOMDefaultImpl.h:
3667         (WebScriptObject::QueryInterface): Deleted.
3668         (WebScriptObject::AddRef): Deleted.
3669         (WebScriptObject::Release): Deleted.