Add myself to watchlist
[WebKit-https.git] / Tools / ChangeLog
1 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         Add myself to watchlist
4         https://bugs.webkit.org/show_bug.cgi?id=144041
5
6         Reviewed by Alex Christensen.
7
8         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
9
10         * Scripts/webkitpy/common/config/watchlist:
11
12 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
13
14         [GTK] MiniBrowser should use NetworkProcess by default
15         https://bugs.webkit.org/show_bug.cgi?id=143948
16
17         Reviewed by Sergio Villar Senin.
18
19         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
20         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
21
22         * MiniBrowser/gtk/main.c:
23         (main):
24
25 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
26
27         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
28
29         Unreviewed build fix.
30
31         * Scripts/prepare-ChangeLog:
32         (get_function_line_ranges_for_cpp):
33         Use grep instead of any to determine if a string is an element of an array.
34
35 2015-04-21  Anders Carlsson  <andersca@apple.com>
36
37         Fix block signatures
38         https://bugs.webkit.org/show_bug.cgi?id=144002
39
40         Reviewed by Andreas Kling.
41
42         * MiniBrowser/mac/WK2BrowserWindowController.m:
43         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
44
45 2015-04-21  Philippe Normand  <pnormand@igalia.com>
46
47         [GTK] jhbuild should not use a branch for openwebrtc
48         https://bugs.webkit.org/show_bug.cgi?id=143981
49
50         Reviewed by Carlos Garcia Campos.
51
52         * gtk/jhbuild.modules:
53
54 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
55
56         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
57
58         Unreviewed build fix.
59
60         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
61         However, it has been exposed by List::MoreUtils since its inception. This patch uses
62         the any function exposed by List::MoreUtils for greater compatibility.
63
64         * Scripts/prepare-ChangeLog:
65         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
66         the any function in all of versions of Perl used by our infrastructure.
67
68 2015-04-20  Alex Christensen  <achristensen@webkit.org>
69
70         Remove unnecessary logs when resetting tests.
71
72         * WebKitTestRunner/mac/TestControllerMac.mm:
73         (WTR::TestController::platformResetPreferencesToConsistentValues):
74         In r183020 I added some logs when compiling or removing content extensions fails.
75         We often try to remove a content extension that does not exist, and that is not a problem.
76
77 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
78
79         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
80         https://bugs.webkit.org/show_bug.cgi?id=143897
81
82         Reviewed by David Kilzer.
83
84         This is a speculative fix that addresses two issues:
85
86         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
87         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
88
89         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
90         Before: (723, 729)
91         After: (721, 720)
92
93         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
94         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
95
96         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
97         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
98
99         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
100
101         2. Creating git diffs from HEAD and not origin/master by default.
102
103         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
104         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
105
106         * Scripts/prepare-ChangeLog:
107         (originalFile):
108         Use HEAD instead of origin/master in default Git case.
109
110         (generateFunctionLists):
111         Ensure that the end line is not less than the start line.
112
113         (extractLineRangeAfterChange):
114         Set the end line to the start line if the end line is less than the start line.
115
116         (extractLineRangeBeforeChange):
117         Ditto.
118
119 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
120
121         Suppress warning in prepare-ChangeLog.
122         https://bugs.webkit.org/show_bug.cgi?id=143882
123
124         Reviewed by David Kilzer.
125
126         Prune noisy prepare-ChangeLog output by using the List::Util::any function
127         instead of the deprecated smartmatch operator.
128
129         * Scripts/prepare-ChangeLog:
130         Import the List::Util::any function.
131
132         (get_function_line_ranges_for_cpp):
133         Use the any function instead of smartmatch.
134
135 2015-04-20  Anders Carlsson  <andersca@apple.com>
136
137         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
138         https://bugs.webkit.org/show_bug.cgi?id=143966
139
140         Reviewed by Dan Bernstein.
141
142         * MiniBrowser/mac/WK2BrowserWindowController.m:
143         (dataTypes):
144         (-[WK2BrowserWindowController fetchWebsiteData:]):
145         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
146         (-[WK2BrowserWindowController clearWebsiteData:]):
147
148 2015-04-20  Alex Christensen  <achristensen@webkit.org>
149
150         Fix content extension test flakiness.
151         https://bugs.webkit.org/show_bug.cgi?id=143950
152
153         Reviewed by Brady Eidson.
154
155         * WebKitTestRunner/mac/TestControllerMac.mm:
156         (WTR::TestController::platformResetPreferencesToConsistentValues):
157         Remove the TestContentExtensions if it exists.
158         (WTR::TestController::platformConfigureViewForTest):
159         Log errors in case there are any.
160
161 2015-04-20  Alex Christensen  <achristensen@webkit.org>
162
163         Properly report errors from _WKUserContentExtensionStore.
164         https://bugs.webkit.org/show_bug.cgi?id=143808
165
166         Reviewed by Darin Adler.
167
168         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
169         (TEST_F):
170
171 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
172
173         Add a rule for NetworkCache to watchlist file
174         https://bugs.webkit.org/show_bug.cgi?id=143945
175
176         Reviewed by Sergio Villar Senin.
177
178         And add myself to the list of watchers.
179
180         * Scripts/webkitpy/common/config/watchlist:
181
182 2015-04-19  Darin Adler  <darin@apple.com>
183
184         Update RefPtr documentation and deprecation
185         https://bugs.webkit.org/show_bug.cgi?id=143936
186
187         Reviewed by Andreas Kling.
188
189         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
190
191 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
192
193         Introduce bytecode intrinsics
194         https://bugs.webkit.org/show_bug.cgi?id=143926
195
196         Reviewed by Filip Pizlo.
197
198         Change cpplint to accept emit_intrinsic_XXX.
199
200         * Scripts/webkitpy/style/checkers/cpp.py:
201         (check_identifier_name_in_declaration):
202
203 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
204
205         Fix lldb_webkit.py to show StringImpls correctly
206         https://bugs.webkit.org/show_bug.cgi?id=143920
207
208         Reviewed by Andreas Kling.
209         
210         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
211
212         * lldb/lldb_webkit.py:
213         (WTFStringImplProvider.is_8bit):
214
215 2015-04-17  Daniel Bates  <dabates@apple.com>
216
217         Not able to build WebKit against iOS Simulator 8.3 SDK
218         https://bugs.webkit.org/show_bug.cgi?id=143883
219
220         Reviewed by David Kilzer.
221
222         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
223         so that Xcode uses them.
224
225         * Scripts/copy-webkitlibraries-to-product-directory:
226
227 2015-04-17  Beth Dakin  <bdakin@apple.com>
228
229         Force mouse events should go through normal mouse event handling code paths
230         https://bugs.webkit.org/show_bug.cgi?id=143749
231         -and corresponding-
232         rdar://problem/20472895
233
234         Reviewed by Dean Jackson.
235
236         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
237         Since there is not a way to create an NSEventTypePressure from scratch, we 
238         subclass NSEvent and override all of the critical methods.
239
240         * WebKitTestRunner/EventSenderProxy.h:
241         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
242         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
243         (WTR::EventSendingController::mouseForceDown):
244         (WTR::EventSendingController::mouseForceUp):
245         (WTR::EventSendingController::mouseForceChanged):
246         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
247         * WebKitTestRunner/TestController.cpp:
248         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
249         * WebKitTestRunner/mac/EventSenderProxy.mm:
250         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
251         (-[EventSenderPressureEvent timestamp]):
252         (-[EventSenderPressureEvent type]):
253         (-[EventSenderPressureEvent locationInWindow]):
254         (-[EventSenderPressureEvent location]):
255         (-[EventSenderPressureEvent stage]):
256         (-[EventSenderPressureEvent pressure]):
257         (-[EventSenderPressureEvent phase]):
258         (-[EventSenderPressureEvent eventNumber]):
259         (WTR::EventSenderProxy::mouseForceDown):
260         (WTR::EventSenderProxy::mouseForceUp):
261         (WTR::EventSenderProxy::mouseForceChanged):
262
263 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
264
265         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
266         https://bugs.webkit.org/show_bug.cgi?id=143885
267
268         Reviewed by Tim Horton.
269
270         Fixed a case where we have two builds with the same revision(s). An in order build
271         is one for which the revision is strictly higher.
272
273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
274         (BuildbotQueue.prototype._checkForInOrderResult):
275         (BuildbotQueue.prototype.compareIterationsByRevisions):
276
277 2015-04-17  Commit Queue  <commit-queue@webkit.org>
278
279         Unreviewed, rolling out r182912 and r182920.
280         https://bugs.webkit.org/show_bug.cgi?id=143881
281
282         Build breakage in some configurations (Requested by ap on
283         #webkit).
284
285         Reverted changesets:
286
287         "Force mouse events should go through normal mouse event
288         handling code paths"
289         https://bugs.webkit.org/show_bug.cgi?id=143749
290         http://trac.webkit.org/changeset/182912
291
292         http://trac.webkit.org/changeset/182920
293
294 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
295
296         [GTK] One more unreviewed fix after r182882.
297
298         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
299
300 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
301
302         [GTK] Unreviewed speculative clean build fix after r182882.
303
304         TestWebKitAPI's forwarding header generator depended on WeKit2's
305         which generated SOUP related forwarding headers too.
306
307         This dependency isn't necessary and was removed by r182882 to make
308         forwarding header generators parallelizable. But in this case
309         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
310         should generate SOUP related forwarding headers too similar to EFL.
311
312         * TestWebKitAPI/PlatformGTK.cmake:
313         * WebKitTestRunner/PlatformGTK.cmake:
314
315 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
316
317         [SOUP] Redirect to non HTTP destination is broken
318         https://bugs.webkit.org/show_bug.cgi?id=143866
319
320         Reviewed by Sergio Villar Senin.
321
322         Add a unit test to check that redirect to a data URI works.
323
324         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
325         (testRedirectToDataURI):
326         (serverCallback):
327         (beforeAll):
328
329 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
330
331         Changes method of quitting iOS Simulator to be more correct.
332         https://bugs.webkit.org/show_bug.cgi?id=143847
333         <rdar://problem/20530344>
334
335         Reviewed by Darin Adler.
336
337         Fixes by addressing the app by ID rather than by name.
338
339         * Scripts/webkitdirs.pm:
340         (quitIOSSimulator):
341         * Scripts/webkitpy/port/ios.py:
342         (IOSSimulatorPort.check_sys_deps):
343
344 2015-04-16  Anders Carlsson  <andersca@apple.com>
345
346         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
347         https://bugs.webkit.org/show_bug.cgi?id=143844
348
349         Reviewed by Dan Bernstein.
350
351         * MiniBrowser/mac/AppDelegate.m:
352         (-[BrowserAppDelegate newPrivateWindow:]):
353         * MiniBrowser/mac/WK2BrowserWindowController.m:
354         (-[WK2BrowserWindowController initWithConfiguration:]):
355         (-[WK2BrowserWindowController fetchWebsiteData:]):
356         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
357         (-[WK2BrowserWindowController clearWebsiteData:]):
358
359 2015-04-16  Alex Christensen  <achristensen@webkit.org>
360
361         32-bit build fix.
362
363         * WebKitTestRunner/mac/TestControllerMac.mm:
364         (WTR::TestController::platformResetPreferencesToConsistentValues):
365         (WTR::TestController::platformConfigureViewForTest):
366         Added WK_API_ENABLED.
367
368 2015-04-16  Alex Christensen  <achristensen@webkit.org>
369
370         Removed unused WKUserContentFilterRef.
371         https://bugs.webkit.org/show_bug.cgi?id=143852
372
373         Reviewed by Sam Weinig.
374
375         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
376         * WebKitTestRunner/mac/TestControllerMac.mm:
377         (WTR::TestController::platformResetPreferencesToConsistentValues):
378         (WTR::TestController::platformConfigureViewForTest):
379
380 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
381
382         Unreviewed. Adding myself as a commiter in contributers.json.
383
384         * Scripts/webkitpy/common/config/contributors.json:
385
386 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
387
388         It is very hard to attach a debugger to WebProcess to debug tests
389         https://bugs.webkit.org/show_bug.cgi?id=143837
390
391         Reviewed by Chris Dumez.
392
393         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
394         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
395
396         Now it disables all timeouts in tools, as is best for debugging tests.
397
398         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
399         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
400
401         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
402         now has the same functionality.
403
404 2015-04-16  Beth Dakin  <bdakin@apple.com>
405
406         Force mouse events should go through normal mouse event handling code paths
407         https://bugs.webkit.org/show_bug.cgi?id=143749
408         -and corresponding-
409         rdar://problem/20472895
410
411         Reviewed by Dean Jackson.
412
413         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
414         Since there is not a way to create an NSEventTypePressure from scratch, we 
415         subclass NSEvent and override all of the critical methods.
416
417         * WebKitTestRunner/EventSenderProxy.h:
418         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
419         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
420         (WTR::EventSendingController::mouseForceDown):
421         (WTR::EventSendingController::mouseForceUp):
422         (WTR::EventSendingController::mouseForceChanged):
423         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
424         * WebKitTestRunner/TestController.cpp:
425         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
426         * WebKitTestRunner/mac/EventSenderProxy.mm:
427         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
428         (-[EventSenderPressureEvent timestamp]):
429         (-[EventSenderPressureEvent type]):
430         (-[EventSenderPressureEvent locationInWindow]):
431         (-[EventSenderPressureEvent location]):
432         (-[EventSenderPressureEvent stage]):
433         (-[EventSenderPressureEvent pressure]):
434         (-[EventSenderPressureEvent phase]):
435         (-[EventSenderPressureEvent eventNumber]):
436         (WTR::EventSenderProxy::mouseForceDown):
437         (WTR::EventSenderProxy::mouseForceUp):
438         (WTR::EventSenderProxy::mouseForceChanged):
439
440 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
441
442         [EFL] Bump LLVM to version 3.6.0 on X86_64
443         https://bugs.webkit.org/show_bug.cgi?id=143604
444
445         Reviewed by Gyuyoung Kim.
446
447         * efl/jhbuild.modules:
448         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
449         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
450         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
451         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
452
453 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
454
455         [EFL] Remove an unnecessary workaround from jhbuildrc
456         https://bugs.webkit.org/show_bug.cgi?id=143823
457
458         Reviewed by Gyuyoung Kim.
459
460         * efl/jhbuildrc:
461
462 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
463
464         [GTK] Run forwarding headers generator unconditionally
465         https://bugs.webkit.org/show_bug.cgi?id=143819
466
467         Reviewed by Carlos Garcia Campos.
468
469         * TestWebKitAPI/PlatformGTK.cmake:
470         * WebKitTestRunner/PlatformGTK.cmake:
471
472 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
473
474         [EFL] Add gnutls to jhbuild.module
475         https://bugs.webkit.org/show_bug.cgi?id=143777
476
477         Reviewed by Csaba Osztrogonác.
478
479         EFL port has required at least 3.0.0 version of gnutls since r176712.
480         However some old linux distributions don't support 3.0.0 version. Besides
481         other projects sometimes need to use lower version of gnutls.
482
483         This patch supports to download gnutls through jhbuild, and use it.
484
485         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
486         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
487
488 2015-04-15  Mark Lam  <mark.lam@apple.com>
489
490         Remove obsolete VMInspector debugging tool.
491         https://bugs.webkit.org/show_bug.cgi?id=143798
492
493         Reviewed by Michael Saboff.
494
495         * TestWebKitAPI/CMakeLists.txt:
496         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
497         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
499         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
500
501 2015-04-15  Jer Noble  <jer.noble@apple.com>
502
503         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
504
505         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
506
507 2015-04-15  Jer Noble  <jer.noble@apple.com>
508
509         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
510
511         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
512         (TestWebKitAPI::TEST_F):
513
514 2015-04-15  Chris Dumez  <cdumez@apple.com>
515
516         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
517         https://bugs.webkit.org/show_bug.cgi?id=143779
518
519         Reviewed by Brent Fulgham.
520
521         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
522         similarly to what is done on Mac / WK1. Without this, PageCache could
523         stay enabled after page cache tests and cause weird behaviors.
524
525         * DumpRenderTree/win/DumpRenderTree.cpp:
526         (resetWebPreferencesToConsistentValues):
527
528 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
529
530         Re-enable custom dilation for antialiased fonts
531         https://bugs.webkit.org/show_bug.cgi?id=143738
532
533         Reviewed by Tim Horton.
534         
535         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
536         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
537         a private WebKit pref. This pref defaults to YES, enabling the feature by default
538         in WK1 as we do for WK2.
539
540         * DumpRenderTree/mac/DumpRenderTree.mm:
541         (resetWebPreferencesToConsistentValues):
542         * WebKitTestRunner/TestController.cpp:
543         (WTR::TestController::resetPreferencesToConsistentValues):
544
545 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
546
547         Correct layering violation in DumpRenderTree Build
548         https://bugs.webkit.org/show_bug.cgi?id=143732
549
550         Reviewed by Simon Fraser.
551
552         Correct a layering violation in DumpRenderTree by calling functions on the
553         WebCoreTestSupport library, rather than attempting to work with WebCore
554         types directly.
555
556         * DumpRenderTree/mac/EventSendingController.mm:
557         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
558         than WebCore itself.,
559         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
560
561 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
562
563         Add a conservative DFA minimizer for the content extension matcher
564         https://bugs.webkit.org/show_bug.cgi?id=143501
565
566         Reviewed by Alex Christensen.
567
568         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
569         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
570
571 2015-04-14  Daniel Bates  <dabates@apple.com>
572
573         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
574         https://bugs.webkit.org/show_bug.cgi?id=143693
575         <rdar://problem/20530316>
576
577         Reviewed by Tim Horton.
578
579         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
580         to use the fixed layout code on iOS at this time.
581
582         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
583
584 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
585
586         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
587         https://bugs.webkit.org/show_bug.cgi?id=143705
588
589         Unreviewed change to watchlist file.
590
591         * Scripts/webkitpy/common/config/watchlist:
592
593 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
594
595         [EFL] favicon wasn't updated for google.com sometimes.
596         https://bugs.webkit.org/show_bug.cgi?id=141940
597
598         Reviewed by Gyuyoung Kim.
599
600         As elm_entry_utf8_to_markup can include additional characters, parameter for the
601         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
602
603         * MiniBrowser/efl/main.c:
604         (on_url_changed):
605
606 2015-04-13  Tim Horton  <timothy_horton@apple.com>
607
608         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
609         https://bugs.webkit.org/show_bug.cgi?id=143560
610         <rdar://problem/16302047>
611
612         Reviewed by Darin Adler.
613
614         * MiniBrowser/mac/BrowserWindowController.h:
615         * MiniBrowser/mac/MainMenu.xib:
616         * MiniBrowser/mac/WK1BrowserWindowController.m:
617         (-[WK1BrowserWindowController setScale:]):
618         * MiniBrowser/mac/WK2BrowserWindowController.m:
619         (viewScaleForMenuItemTag):
620         (-[WK2BrowserWindowController setScale:]):
621         (-[WK2BrowserWindowController validateMenuItem:]):
622         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
623         When in use, we resize the window so that the view fits correctly, and
624         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
625         layout size will not change when scaling down (but will update appropriately
626         when the view is resized).
627
628 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
629
630         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
631         https://bugs.webkit.org/show_bug.cgi?id=138630
632
633         Reviewed by Tim Horton.
634
635         Make sure that we always load at least one in order productive iteration.
636
637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
638         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
639         is done loading at least one iteration that wasn't an out of order build.
640         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
641         when that's needed to check for out of order builds.
642         (BuildbotQueue.prototype.update): Ditto.
643         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
644         result, and if it does not, load more iterations.
645         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
646         an in order iteration loaded too.
647         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
648         corrected to always sort loaded iterations before unloaded ones.
649
650 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
651
652         Expand test infrastructure to support scrolling tests
653         https://bugs.webkit.org/show_bug.cgi?id=143286
654         <rdar://problem/20375516>
655
656         Reviewed by Simon Fraser.
657
658         Extend the WK1 and WK2 test programs to support two new EventSender commands:
659         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
660         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
661         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
662         relevant rubberband, scroll, and scroll-snap animations are finished.
663
664         * DumpRenderTree/mac/EventSendingController.mm:
665         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
666         and 'monitorWheelEvents'.
667         (+[EventSendingController webScriptNameForSelector:]): Ditto.
668         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
669         debugging test failures.
670         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
671         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
672         function, then passes it to WebCore to be called once the test deferrals have been cleared.
673         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
674         'callAfterScrollingCompletes' method.
675         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
676         and 'monitorWheelEvents'.
677         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
678         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
679         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
680         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
681         'callAfterScrollingComplates' method.
682         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
683
684 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
685
686         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
687         https://bugs.webkit.org/show_bug.cgi?id=143656
688
689         Reviewed by Darin Adler.
690
691         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
692         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
693
694 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
695
696         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
697         https://bugs.webkit.org/show_bug.cgi?id=142387
698
699         Reviewed by Carlos Garcia Campos.
700
701         Running mixed content is blocked by default since r181134. Updated
702         the test case to reflect the new default settings.
703
704         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
705         (testInsecureContent):
706
707 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
708
709         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
710         https://bugs.webkit.org/show_bug.cgi?id=143667
711
712         Reviewed by Csaba Osztrogonác.
713
714         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
715         since r169017. Added $hardwareConcurrencySupport for it.
716
717         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
718
719         * Scripts/webkitperl/FeatureList.pm:
720
721 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
722
723         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
724         https://bugs.webkit.org/show_bug.cgi?id=143664
725
726         Reviewed by Gyuyoung Kim.
727
728         * Scripts/webkitperl/FeatureList.pm:
729
730 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
731
732         [EFL] Enable Media Source
733         https://bugs.webkit.org/show_bug.cgi?id=143635
734
735         Reviewed by Csaba Osztrogonác.
736
737         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
738
739 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
740
741         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
742         https://bugs.webkit.org/show_bug.cgi?id=143646
743
744         Reviewed by David Kilzer.
745
746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
747         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
748
749 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
750
751         Use en_US spell checker for tests on Mac instead of Multilingual
752         https://bugs.webkit.org/show_bug.cgi?id=143641
753
754         Reviewed by Dan Bernstein.
755
756         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
757         While at it, override NSUserDictionaryReplacementItems, so that user replacements
758         cannot affect tests.
759
760         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
761         Made this more like WebKit1 version.
762
763 2015-04-10  Tim Horton  <timothy_horton@apple.com>
764
765         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
766         https://bugs.webkit.org/show_bug.cgi?id=143576
767
768         Reviewed by Simon Fraser.
769
770         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
771         (TEST):
772         Adopt.
773
774 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
775
776         Update my email address and expertise.
777         https://bugs.webkit.org/show_bug.cgi?id=143586
778
779         Unreviewed, just update my info.
780
781         * Scripts/webkitpy/common/config/contributors.json:
782
783 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
784
785         Flakiness Dashboard not loading insecure content if loaded with https URL
786         https://bugs.webkit.org/show_bug.cgi?id=143570
787
788         Reviewed by Alexey Proskuryakov.
789
790         * TestResultServer/app.yaml:
791         * TestResultServer/static-dashboards/loader.js:
792         Switch to https scheme.
793
794 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
795
796         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
797         https://bugs.webkit.org/show_bug.cgi?id=142907
798
799         Reviewed by Carlos Garcia Campos.
800
801         * TestWebKitAPI/PlatformEfl.cmake:
802         * TestWebKitAPI/PlatformGTK.cmake:
803         * WebKitTestRunner/PlatformEfl.cmake:
804         * WebKitTestRunner/PlatformGTK.cmake:
805
806 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
807
808         [Mac] Unreviewed test fix after r182584
809         https://bugs.webkit.org/show_bug.cgi?id=143452
810
811         Put both of these tests back to their original state now that the underlying
812         problem is fixed.
813
814         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
815         (TestWebKitAPI::TEST):
816         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
817         (TestWebKitAPI::TEST):
818
819 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
820
821         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
822         https://bugs.webkit.org/show_bug.cgi?id=143553
823
824         Reviewed by Ryosuke Niwa.
825         
826         Remove the spurious printVMs left over from an earlier change.
827
828         * Scripts/run-jsc-benchmarks:
829
830 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
831
832         [Mac] Unreviewed test fix after r182581
833
834         The behavior of control-left-click is controlled by a system preference.
835         Our test bots have this turned off.
836
837         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
838         (TestWebKitAPI::TEST):
839         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
840         (TestWebKitAPI::TEST):
841
842 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
843
844         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
845         https://bugs.webkit.org/show_bug.cgi?id=143452
846         <rdar://problem/20437483>
847
848         Reviewed by Tim Horton.
849
850         Add a new API test to confirm that Cocoa mouse button press events are properly
851         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
852
853         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
854         some registered event handlers that the expected button press and context menu
855         events are received.
856
857         The WK1 unit test creates an NSEvent with the desired button press state, and then
858         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
859         We check the resulting PlatformMouseEvent for proper state.
860
861         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
862         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
863         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
864         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
865         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
866         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
867         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
868         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
869         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
870         mouse down events.
871         * TestWebKitAPI/mac/PlatformWebViewMac.h:
872
873 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
874
875         [GTK] Add pango to jhbuild-optional.modules
876         https://bugs.webkit.org/show_bug.cgi?id=143537
877
878         Reviewed by Martin Robinson.
879
880         * gtk/jhbuild-optional.modules: Add pango.
881
882 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
883
884         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
885         https://bugs.webkit.org/show_bug.cgi?id=143530
886
887         Reviewed by Žan Doberšek.
888
889         Assume that the default value for display (:0) is reserved and start checking on :1
890         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
891         and for X server named Xorg.bin (previous bug 1376599)
892
893         * Scripts/webkitpy/port/xvfbdriver.py:
894         (XvfbDriver._next_free_display)
895         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
896         (XvfbDriverTest.test_start_no_pixel_tests):
897         (XvfbDriverTest.test_start_pixel_tests):
898         (XvfbDriverTest.test_start_arbitrary_worker_number):
899         (XvfbDriverTest.test_next_free_display):
900         (XvfbDriverTest.test_start_next_worker):
901 2015-04-08  Alex Christensen  <achristensen@webkit.org>
902
903         Block popups from content extensions.
904         https://bugs.webkit.org/show_bug.cgi?id=143497
905
906         Reviewed by Brady Eidson.
907
908         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
909         (TestWebKitAPI::TEST_F):
910         Added popup test.
911
912 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
913
914         Add CMake build system for WinCairo port.
915         https://bugs.webkit.org/show_bug.cgi?id=115944
916
917         Reviewed by Chris Dumez.
918
919         * CMakeLists.txt:
920         * WinLauncher/CMakeLists.txt: Added.
921
922 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
923
924         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
925         https://bugs.webkit.org/show_bug.cgi?id=143521
926
927         Reviewed by Martin Robinson.
928
929         Add a way to detect unexpected web process crashes to WebViewTest,
930         and a test case to testDOMCache to trigger the crash.
931
932         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
933         (WebKitDOMNodeTest::testDOMCache):
934         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
935         (testWebKitWebViewProcessCrashed):
936         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
937         (WebViewTest::WebViewTest):
938         (WebViewTest::webProcessCrashed):
939         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
940
941 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
942
943         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
944         rdar://problem/20461342
945
946         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
947
948 2015-04-07  Commit Queue  <commit-queue@webkit.org>
949
950         Unreviewed, rolling out r182511.
951         https://bugs.webkit.org/show_bug.cgi?id=143507
952
953         caused debug test failures (Requested by alexchristensen on
954         #webkit).
955
956         Reverted changeset:
957
958         "Block popups from content extensions."
959         https://bugs.webkit.org/show_bug.cgi?id=143497
960         http://trac.webkit.org/changeset/182511
961
962 2015-04-07  Alex Christensen  <achristensen@webkit.org>
963
964         Block popups from content extensions.
965         https://bugs.webkit.org/show_bug.cgi?id=143497
966
967         Reviewed by Brady Eidson.
968
969         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
970         (TestWebKitAPI::TEST_F):
971         Added popup test.
972
973 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
974
975         Get the features.json files ready for open contributions
976         https://bugs.webkit.org/show_bug.cgi?id=143436
977
978         Reviewed by Darin Adler.
979
980         * Scripts/webkitpy/style/checkers/jsonchecker.py:
981         (JSONFeaturesChecker.check):
982         Extend the syntax checking a bit, but leave everything non-mandatory
983         very loose until we figure what fields are important.
984
985 2015-04-07  Tim Horton  <timothy_horton@apple.com>
986
987         Expose and test fixedLayoutSize via modern WebKit SPI
988         https://bugs.webkit.org/show_bug.cgi?id=143500
989
990         Reviewed by Simon Fraser.
991
992         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
993         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
994         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
995         (TEST):
996         Add a test that verifies that fixedLayoutSize works at all, that
997         it persists through a navigation, and that turning it back off reverts to
998         laying out at the size of the view.
999
1000 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1001
1002         Unreviewed. Add myself as a committer.
1003
1004         * Scripts/webkitpy/common/config/contributors.json:
1005
1006 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
1007
1008         [Win] Bots complain about missing /etc/catalog
1009         https://bugs.webkit.org/show_bug.cgi?id=143484
1010
1011         Reviewed by Chris Dumez.
1012
1013         The libxml2 build on Mac, iOS, and Windows does not provide the set
1014         of default catalog files. We do not actually need these for our
1015         purposes, but we get warnings and some bot flakiness because they
1016         are not present.
1017
1018         We can avoid both problems the same way the Mac and iOS ports do,
1019         by setting the XML_CATALOG_FILES environment variable to 'empty string',
1020         which avoid the warnings and bot problems.
1021
1022         * Scripts/webkitpy/port/win.py:
1023         (WinPort.setup_environ_for_server): Added.
1024
1025 2015-04-06  Sam Weinig  <sam@webkit.org>
1026
1027         Use content extensions in MiniBrowser.
1028         https://bugs.webkit.org/show_bug.cgi?id=143446
1029
1030         Reviewed by Alex Christensen.
1031
1032         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1033         * MiniBrowser/mac/AppDelegate.h:
1034         * MiniBrowser/mac/AppDelegate.m:
1035         (-[BrowserAppDelegate init]):
1036         (-[BrowserAppDelegate showExtensionsManager:]):
1037         (-[BrowserAppDelegate userContentContoller]):
1038         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
1039         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
1040         (-[ExtensionManagerWindowController init]):
1041         (-[ExtensionManagerWindowController windowDidLoad]):
1042         (-[ExtensionManagerWindowController add:]):
1043         (-[ExtensionManagerWindowController remove:]):
1044         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
1045         * MiniBrowser/mac/MainMenu.xib:
1046
1047 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1048
1049         web-platform-tests server should retrieve the modules file relatively to its docroot path
1050         https://bugs.webkit.org/show_bug.cgi?id=142742
1051
1052         Reviewed by Darin Adler.
1053
1054         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1055         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
1056
1057 2015-04-06  Commit Queue  <commit-queue@webkit.org>
1058
1059         Unreviewed, rolling out r182445.
1060         https://bugs.webkit.org/show_bug.cgi?id=143459
1061
1062         broke 32 bit build (Requested by alexchristensen on #webkit).
1063
1064         Reverted changeset:
1065
1066         "Use content extensions in MiniBrowser."
1067         https://bugs.webkit.org/show_bug.cgi?id=143446
1068         http://trac.webkit.org/changeset/182445
1069
1070 2015-04-06  Sam Weinig  <sam@webkit.org>
1071
1072         Use content extensions in MiniBrowser.
1073         https://bugs.webkit.org/show_bug.cgi?id=143446
1074
1075         Reviewed by Alex Christensen.
1076
1077         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1078         * MiniBrowser/mac/AppDelegate.h:
1079         * MiniBrowser/mac/AppDelegate.m:
1080         (-[BrowserAppDelegate init]):
1081         (-[BrowserAppDelegate showExtensionsManager:]):
1082         (-[BrowserAppDelegate userContentContoller]):
1083         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
1084         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
1085         (-[ExtensionManagerWindowController init]):
1086         (-[ExtensionManagerWindowController windowDidLoad]):
1087         (-[ExtensionManagerWindowController add:]):
1088         (-[ExtensionManagerWindowController remove:]):
1089         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
1090         * MiniBrowser/mac/MainMenu.xib:
1091
1092 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
1093
1094         [GTK] install-dependencies should prefer dnf to yum
1095         https://bugs.webkit.org/show_bug.cgi?id=143441
1096
1097         Reviewed by Martin Robinson.
1098
1099         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
1100
1101         * gtk/install-dependencies:
1102
1103 2015-04-06  Andy Estes  <aestes@apple.com>
1104
1105         [iOS] 'make clean' fails in Tools/WebKitTestRunner
1106         https://bugs.webkit.org/show_bug.cgi?id=143455
1107
1108         Reviewed by Dan Bernstein.
1109
1110         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
1111         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
1112
1113         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
1114
1115 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
1116
1117         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
1118         https://bugs.webkit.org/show_bug.cgi?id=143450
1119
1120         Reviewed by Anders Carlsson.
1121
1122         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
1123         Make sure that the view is actually closed, regardless of anything else that happens beneath.
1124         Also, removed unnecessary get() calls.
1125
1126 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
1127
1128         Reduce the dependency on Flash in regression tests
1129         https://bugs.webkit.org/show_bug.cgi?id=143391
1130
1131         Reviewed by Anders Carlsson.
1132
1133         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
1134         Only allow QuickTime and the test plug-in.
1135
1136 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1137
1138         W3C test importer should generate the modules installed dynamically to run wpt tests
1139         https://bugs.webkit.org/show_bug.cgi?id=142738
1140
1141         Reviewed by Ryosuke Niwa.
1142
1143         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
1144         The implementation is done within TestDownloader and it is activated for the WPT repository.
1145         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
1146
1147         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1148         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
1149         * Scripts/webkitpy/w3c/test_downloader.py:
1150         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
1151         (TestDownloader):
1152         (TestDownloader._git_submodules_description): Computes submodule description.
1153         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
1154         * Scripts/webkitpy/w3c/test_importer.py:
1155         (TestImporter.do_import): Added the possibility to post process the tests.
1156         (TestImporter):
1157         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
1158         (TestImporter.should_convert_test_harness_links): Updated according new options format.
1159         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1160         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
1161         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
1162         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
1163         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
1164         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
1165
1166 2015-04-05  Antti Koivisto  <antti@apple.com>
1167
1168         Bloom filter should support longer hashes
1169         https://bugs.webkit.org/show_bug.cgi?id=143419
1170
1171         Reviewed by Dan Bernstein.
1172
1173         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
1174         (TestWebKitAPI::generateRandomDigests):
1175         (TestWebKitAPI::TEST):
1176
1177 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
1178
1179         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
1180         https://bugs.webkit.org/show_bug.cgi?id=143372
1181
1182         Reviewed by Darin Adler.
1183
1184         * Scripts/run-jsc-stress-tests:
1185
1186 2015-04-03  Antti Koivisto  <antti@apple.com>
1187
1188         Add non-counting bloom filter class
1189         https://bugs.webkit.org/show_bug.cgi?id=143366
1190
1191         Reviewed by Sam Weinig.
1192
1193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1194         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
1195         (TestWebKitAPI::generateRandomHashes):
1196         (TestWebKitAPI::TEST):
1197
1198 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
1199
1200         FTL JIT tests should fail if LLVM library isn't available
1201         https://bugs.webkit.org/show_bug.cgi?id=143374
1202
1203         Reviewed by Mark Lam.
1204
1205         * Scripts/run-jsc-stress-tests:
1206
1207 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
1208
1209         [EFL] Speedup jhbuild with disable running autogen.sh
1210         https://bugs.webkit.org/show_bug.cgi?id=143369
1211
1212         Reviewed by Gyuyoung Kim.
1213
1214         * efl/jhbuild.modules:
1215
1216 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
1217
1218         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
1219         https://bugs.webkit.org/show_bug.cgi?id=143282
1220
1221         Reviewed by Daniel Bates.
1222
1223         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
1224
1225 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
1226
1227         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
1228         https://bugs.webkit.org/show_bug.cgi?id=143240
1229         rdar://problem/19990425
1230
1231         Reviewed by Tim Horton.
1232
1233         * DumpRenderTree/mac/LayoutTestHelper.m:
1234         (colorProfileURLForDisplay):
1235         (saveDisplayColorProfiles):
1236         Gracefully handle it when the current profile cannot be retrieved, fixing at
1237         least one case when LayoutTestHelper couldn't start.
1238
1239         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1240         (Manager._set_up_run):
1241         (Manager._force_pixel_tests_if_needed):
1242         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
1243         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
1244         Return and check an error from start_helper().
1245
1246 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
1247
1248         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
1249         https://bugs.webkit.org/show_bug.cgi?id=143321
1250
1251         Reviewed by Alexey Proskuryakov.
1252
1253         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
1254
1255 2015-04-01  Enrica Casucci  <enrica@apple.com>
1256
1257         Injected bundle messages should be at the page level.
1258         https://bugs.webkit.org/show_bug.cgi?id=143283
1259
1260         Reviewed by Alexey Proskuryakov.
1261
1262         Updating WebKitTestRunner to use the new page level messaging.
1263         The author of this patch is Tim Horton, I just finished it.
1264
1265         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1266         (WTR::EventSendingController::mouseDown):
1267         (WTR::EventSendingController::mouseUp):
1268         (WTR::EventSendingController::mouseMoveTo):
1269         (WTR::EventSendingController::leapForward):
1270         (WTR::EventSendingController::scheduleAsynchronousClick):
1271         (WTR::EventSendingController::keyDown):
1272         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1273         (WTR::EventSendingController::mouseScrollBy):
1274         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1275         (WTR::EventSendingController::continuousMouseScrollBy):
1276         (WTR::EventSendingController::addTouchPoint):
1277         (WTR::EventSendingController::updateTouchPoint):
1278         (WTR::EventSendingController::setTouchModifier):
1279         (WTR::EventSendingController::setTouchPointRadius):
1280         (WTR::EventSendingController::touchStart):
1281         (WTR::EventSendingController::touchMove):
1282         (WTR::EventSendingController::touchEnd):
1283         (WTR::EventSendingController::touchCancel):
1284         (WTR::EventSendingController::clearTouchPoints):
1285         (WTR::EventSendingController::releaseTouchPoint):
1286         (WTR::EventSendingController::cancelTouchPoint):
1287         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1288         (WTR::InjectedBundle::didReceiveMessage):
1289         (WTR::InjectedBundle::didReceiveMessageToPage):
1290         (WTR::InjectedBundle::done):
1291         (WTR::InjectedBundle::outputText):
1292         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1293         (WTR::InjectedBundle::postAddChromeInputField):
1294         (WTR::InjectedBundle::postRemoveChromeInputField):
1295         (WTR::InjectedBundle::postFocusWebView):
1296         (WTR::InjectedBundle::postSetBackingScaleFactor):
1297         (WTR::InjectedBundle::postSetWindowIsKey):
1298         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1299         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1300         (WTR::InjectedBundle::setGeolocationPermission):
1301         (WTR::InjectedBundle::setMockGeolocationPosition):
1302         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1303         (WTR::InjectedBundle::setUserMediaPermission):
1304         (WTR::InjectedBundle::setCustomPolicyDelegate):
1305         (WTR::InjectedBundle::setHidden):
1306         (WTR::InjectedBundle::setCacheModel):
1307         (WTR::InjectedBundle::shouldProcessWorkQueue):
1308         (WTR::InjectedBundle::processWorkQueue):
1309         (WTR::InjectedBundle::queueBackNavigation):
1310         (WTR::InjectedBundle::queueForwardNavigation):
1311         (WTR::InjectedBundle::queueLoad):
1312         (WTR::InjectedBundle::queueLoadHTMLString):
1313         (WTR::InjectedBundle::queueReload):
1314         (WTR::InjectedBundle::queueLoadingScript):
1315         (WTR::InjectedBundle::queueNonLoadingScript):
1316         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1317         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1318         (WTR::TestRunner::setAuthenticationUsername):
1319         (WTR::TestRunner::setAuthenticationPassword):
1320         (WTR::TestRunner::secureEventInputIsEnabled):
1321         (WTR::TestRunner::setBlockAllPlugins):
1322         * WebKitTestRunner/TestController.cpp:
1323         (WTR::TestController::createWebViewWithOptions):
1324         (WTR::TestController::resetStateToConsistentValues):
1325         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
1326         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
1327         * WebKitTestRunner/TestController.h:
1328         * WebKitTestRunner/TestInvocation.cpp:
1329         (WTR::TestInvocation::invoke):
1330         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1331
1332 2015-04-01  Commit Queue  <commit-queue@webkit.org>
1333
1334         Unreviewed, rolling out r182174 and r182177.
1335         https://bugs.webkit.org/show_bug.cgi?id=143314
1336
1337         Try to correct EWS failures (Requested by bfulgham on
1338         #webkit).
1339
1340         Reverted changesets:
1341
1342         "Python SCM should be able to retrieve untracked files"
1343         https://bugs.webkit.org/show_bug.cgi?id=143135
1344         http://trac.webkit.org/changeset/182174
1345
1346         "[buildbot] clean-build script should remove untracked files
1347         and revert local changes too"
1348         https://bugs.webkit.org/show_bug.cgi?id=142400
1349         http://trac.webkit.org/changeset/182177
1350
1351 2015-04-01  Alex Christensen  <achristensen@webkit.org>
1352
1353         [Content Extensions] Properly handle regexes that match everything.
1354         https://bugs.webkit.org/show_bug.cgi?id=143281
1355
1356         Reviewed by Benjamin Poulain.
1357
1358         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1359         (TestWebKitAPI::testRequest):
1360         (TestWebKitAPI::makeBackend):
1361         (TestWebKitAPI::TEST_F):
1362         Removed duplicate code and added test.
1363
1364 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
1365
1366         Content Extensions: split the state machines to minimize prefix states
1367         https://bugs.webkit.org/show_bug.cgi?id=143253
1368
1369         Reviewed by Alex Christensen.
1370
1371         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1372         (TestWebKitAPI::TEST_F):
1373         (TestWebKitAPI::testPatternStatus):
1374
1375 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
1376
1377         Clean up Identifier factories to clarify the meaning of StringImpl*
1378         https://bugs.webkit.org/show_bug.cgi?id=143146
1379
1380         Reviewed by Filip Pizlo.
1381
1382         Simple API tests for StringImpl are added.
1383
1384         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1385         (TestWebKitAPI::TEST):
1386
1387 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
1388
1389         [EFL] Add AArch64 builder and tester bot to build.webkit.org
1390         https://bugs.webkit.org/show_bug.cgi?id=143092
1391
1392         Reviewed by Gyuyoung Kim.
1393
1394         * BuildSlaveSupport/build.webkit.org-config/config.json:
1395         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1396         (Factory.__init__):
1397         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1398
1399 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1400
1401         [buildbot] clean-build script should remove untracked files and revert local changes too
1402         https://bugs.webkit.org/show_bug.cgi?id=142400
1403
1404         Reviewed by Ryosuke Niwa.
1405
1406         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
1407         A helper routine SCM.discard_untracked_files is added for that purpose.
1408
1409         * BuildSlaveSupport/clean-build:
1410         (main): Making call to Scripts/clean-webkit
1411         * Scripts/clean-webkit: Added.
1412         (main): Revert changes and delete untracked files.
1413         * Scripts/webkitpy/common/checkout/scm/scm.py:
1414         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
1415         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1416         (SCMTest._shared_test_discard_untracked_files):
1417         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
1418
1419 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1420
1421         Python SCM should be able to retrieve untracked files
1422         https://bugs.webkit.org/show_bug.cgi?id=143135
1423
1424         Reviewed by Ryosuke Niwa.
1425
1426         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
1427         Ignored files may be included or not in this list according boolean passed to the function.
1428
1429         * Scripts/webkitpy/common/checkout/scm/git.py:
1430         (Git.untracked_files):
1431         * Scripts/webkitpy/common/checkout/scm/scm.py:
1432         (SCM.untracked_files):
1433         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1434         (SCMTest._shared_test_untracked_files):
1435         (test_untracked_files):
1436         (GitSVNTest.test_untracked_files):
1437         * Scripts/webkitpy/common/checkout/scm/svn.py:
1438         (SVN.untracked_files):
1439
1440 2015-03-30  Alex Christensen  <achristensen@webkit.org>
1441
1442         [Content Extensions] Correctly handle regular expressions matching everything
1443         https://bugs.webkit.org/show_bug.cgi?id=143235
1444
1445         Reviewed by Benjamin Poulain.
1446
1447         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1448         (TestWebKitAPI::checkCompilerError):
1449         (TestWebKitAPI::TEST_F):
1450         Test ContentExtensionErrors.
1451
1452 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
1453
1454         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
1455         https://bugs.webkit.org/show_bug.cgi?id=143241
1456         rdar://problem/20351297
1457
1458         Reviewed by Mark Lam.
1459
1460         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1461
1462 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1463
1464         [CMake][EFL] Remove redundant library link and include path
1465         https://bugs.webkit.org/show_bug.cgi?id=143221
1466
1467         Reviewed by Csaba Osztrogonác.
1468
1469         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
1470
1471 2015-03-30  Sam Weinig  <sam@webkit.org>
1472
1473         [Content Extensions] Flesh out the UserContentExtensionStore
1474         https://bugs.webkit.org/show_bug.cgi?id=143123
1475
1476         Reviewed by Benjamin Poulain.
1477
1478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1479         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
1480         Add tests for _WKUserContentExtensionStore.
1481
1482 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
1483
1484         Update install-dependencies Fedora packages after r181624
1485         https://bugs.webkit.org/show_bug.cgi?id=143215
1486
1487         Add json-glib, libv4l, openssl and pulseaudio development packages to
1488         the Fedora list providing we need them to build WebKit dependencies
1489         for this distribution.
1490
1491         Reviewed by Philippe Normand.
1492
1493         * gtk/install-dependencies:
1494
1495 2015-03-30  Commit Queue  <commit-queue@webkit.org>
1496
1497         Unreviewed, rolling out r182119.
1498         https://bugs.webkit.org/show_bug.cgi?id=143196
1499
1500         problem with syntax (Requested by youenn on #webkit).
1501
1502         Reverted changeset:
1503
1504         "[buildbot] clean-build script should remove untracked files
1505         and revert local changes too"
1506         https://bugs.webkit.org/show_bug.cgi?id=142400
1507         http://trac.webkit.org/changeset/182119
1508
1509 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
1510
1511         Start the features.json files
1512         https://bugs.webkit.org/show_bug.cgi?id=143207
1513
1514         Reviewed by Darin Adler.
1515
1516         I kept the style checking light. We'll have to figure
1517         what is the best format for each field.
1518
1519         * Scripts/webkitpy/style/checker.py:
1520         (CheckerDispatcher._create_checker):
1521         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1522         (JSONContributorsChecker.check):
1523         (JSONFeaturesChecker):
1524         (JSONFeaturesChecker.check):
1525
1526 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1527
1528         [buildbot] clean-build script should remove untracked files and revert local changes too
1529         https://bugs.webkit.org/show_bug.cgi?id=142400
1530
1531         Reviewed by Ryosuke Niwa.
1532
1533         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
1534
1535         * BuildSlaveSupport/clean-build:
1536         (main): Adding call to Tools/Scripts/clean-webkit.
1537         * Scripts/clean-webkit: Added.
1538         (main): Removes untracked and changed files.
1539         * Scripts/webkitpy/common/checkout/scm/git.py:
1540         (Git.untracked_files): Retrieves GIT untracked files.
1541         * Scripts/webkitpy/common/checkout/scm/scm.py:
1542         (SCM.untracked_files): Retrieves SVN untracked files.
1543         (SCM):
1544         (SCM.discard_untracked_files): Deletes untracked files/folders.
1545         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1546         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
1547         (test_untracked_files):
1548         (GitSVNTest.test_untracked_files):
1549         * Scripts/webkitpy/common/checkout/scm/svn.py:
1550         (SVN.untracked_files):
1551
1552 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1553
1554         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
1555         https://bugs.webkit.org/show_bug.cgi?id=143138
1556
1557         Reviewed by Csaba Osztrogonác.
1558
1559         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
1560         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
1561
1562         * ImageDiff/CMakeLists.txt:
1563         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
1564         * WebKitTestRunner/CMakeLists.txt: ditto.
1565
1566 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
1567
1568         Support building WTF on Windows without Cygwin
1569         https://bugs.webkit.org/show_bug.cgi?id=143084
1570
1571         Reviewed by Brent Fulgham.
1572
1573         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
1574         This patch also migrates to using File::Spec->catfile() for directory separators.
1575
1576         * Scripts/update-webkit-dependency:
1577         (wanted):
1578         * Scripts/update-webkit-support-libs:
1579         (wanted):
1580         (downloadExpectedVersionNumber):
1581         (zipFileVersion):
1582         (toUnixPath): Deleted.
1583         * Scripts/webkitdirs.pm:
1584         (determineSourceDir):
1585         (windowsSourceSourceDir):
1586         (windowsLibrariesDir):
1587         (windowsOutputDir):
1588         (checkInstalledTools):
1589         (buildVisualStudioProject):
1590
1591 2015-03-27  Alex Christensen  <achristensen@webkit.org>
1592
1593         Fix WinCairo bot.
1594         https://bugs.webkit.org/show_bug.cgi?id=143086
1595
1596         Reviewed by Brent Fulgham.
1597
1598         * Scripts/webkitdirs.pm:
1599         (buildVisualStudioProject):
1600         (runSvnUpdateAndResolveChangeLogs):
1601         Use ActivePerl-friendly perl.
1602
1603 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1604
1605         URTBF after r182059 to fix the EFL build.
1606
1607         * TestWebKitAPI/CMakeLists.txt:
1608
1609 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
1610
1611         Layout test results URL loads in WK1 but not WK2 minibrowser
1612         https://bugs.webkit.org/show_bug.cgi?id=143117
1613
1614         Reviewed by Tim Horton.
1615
1616         * MiniBrowser/mac/WK2BrowserWindowController.m:
1617         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
1618         everything.
1619         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
1620
1621 2015-03-26  Jer Noble  <jer.noble@apple.com>
1622
1623         Add --allowed-host support to run-webkit-tests
1624         https://bugs.webkit.org/show_bug.cgi?id=142938
1625
1626         Reviewed by Brent Fulgham.
1627
1628         Accept --allowed-host arguments from run-webkit-tests and pass them through to
1629         DumpRenderTree and WebKitTestRunner.
1630
1631         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
1632         are placed in the wrong location. The argument is compared with each tests's path, and if a
1633         relative path or a path with '..' was used, results are placed alongside the test. Take the
1634         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
1635
1636         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1637         (parse_args):
1638         * Scripts/webkitpy/port/base.py:
1639         (Port.__init__):
1640         (Port.allowed_hosts):
1641         * Scripts/webkitpy/port/driver.py:
1642         (Driver.cmd_line):
1643
1644 2015-03-26  Jer Noble  <jer.noble@apple.com>
1645
1646         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
1647         https://bugs.webkit.org/show_bug.cgi?id=142931
1648
1649         Reviewed by Brent Fulgham.
1650
1651         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
1652         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
1653         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
1654         runtime.
1655
1656         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
1657         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
1658
1659         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
1660         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
1661         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
1662         the top loading frame from the page, as we do elsewhere in this class.
1663
1664         * DumpRenderTree/TestRunner.h:
1665         (TestRunner::allowedHosts):
1666         (TestRunner::setAllowedHosts):
1667         * DumpRenderTree/mac/DumpRenderTree.mm:
1668         (initializeGlobalsFromCommandLineOptions):
1669         (runTest):
1670         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1671         (isAllowedHost):
1672         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1673         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1674         (WTR::InjectedBundle::didReceiveMessage):
1675         (WTR::InjectedBundle::isAllowedHost):
1676         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1677         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1678         (WTR::isAllowedHost):
1679         (WTR::InjectedBundlePage::willSendRequestForFrame):
1680         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1681         * WebKitTestRunner/Options.cpp:
1682         (WTR::handleOptionAllowedHost):
1683         (WTR::OptionsHandler::OptionsHandler):
1684         * WebKitTestRunner/Options.h:
1685         * WebKitTestRunner/TestController.cpp:
1686         (WTR::TestController::initialize):
1687         (WTR::TestController::resetStateToConsistentValues):
1688         * WebKitTestRunner/TestController.h:
1689
1690 2015-03-26  Brady Eidson  <beidson@apple.com>
1691
1692         Apply ContentExtension actions after redirects.
1693         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
1694
1695         Reviewed by Alex Christensen.
1696
1697         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1698         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
1699           which is specifically interesting to a new test.
1700
1701 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1702
1703         [EFL] Disable building libseccomp on AArch64
1704         https://bugs.webkit.org/show_bug.cgi?id=143094
1705
1706         Reviewed by Gyuyoung Kim.
1707
1708         * efl/jhbuildrc:
1709
1710 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1711
1712         [jhbuild] git should use only 1 thread for cloning jhbuild
1713         https://bugs.webkit.org/show_bug.cgi?id=143095
1714
1715         Reviewed by Gyuyoung Kim.
1716
1717         * jhbuild/jhbuild-wrapper:
1718         (clone_jhbuild):
1719
1720 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
1721
1722         Update prepare-ChangeLog to work with ES6 Class syntax
1723         https://bugs.webkit.org/show_bug.cgi?id=143069
1724
1725         Reviewed by Timothy Hatcher.
1726
1727         * Scripts/prepare-ChangeLog:
1728         (get_function_line_ranges_for_javascript):
1729         Better handle ES6 Class syntax.
1730
1731         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
1732         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
1733         (BaseClass):
1734         (DerivedClass):
1735         (DerivedClass.staticMethod):
1736         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
1737         (DerivedClass.prototype.method):
1738         (DerivedClass.prototype.get getter):
1739         (namespace.MyClass):
1740         (namespace.MyClass.staticMethod):
1741         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
1742         (namespace.MyClass.prototype.method):
1743         (namespace.MyClass.prototype.get getter):
1744         Proof!
1745
1746 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
1747
1748         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
1749         https://bugs.webkit.org/show_bug.cgi?id=142993
1750
1751         Reviewed by Mark Lam.
1752         
1753         Bunch of support for testing executable allocation failure.
1754
1755         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
1756         (fail):
1757         * Scripts/run-javascriptcore-tests:
1758         (runJSCStressTests):
1759         * Scripts/run-jsc-stress-tests:
1760
1761 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
1762
1763         Fix Windows build from r181977.
1764
1765         Unreviewed.
1766
1767         * Scripts/update-webkit-dependency:
1768
1769 2015-03-25  Sam Weinig  <sam@webkit.org>
1770
1771         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
1772
1773         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1774         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1775
1776 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
1777
1778         Migrate update-webkit for Windows to not require Cygwin
1779         https://bugs.webkit.org/show_bug.cgi?id=143040
1780
1781         Reviewed by Brent Fulgham.
1782
1783         * Scripts/update-webkit-dependency:
1784         (wanted):
1785         (toUnixPath): Deleted.
1786         * Scripts/webkitdirs.pm:
1787         (fontExists):
1788         (checkInstalledTools):
1789         (setupAppleWinEnv):
1790
1791 2015-03-25  Sam Weinig  <sam@webkit.org>
1792
1793         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
1794         https://bugs.webkit.org/show_bug.cgi?id=143059
1795
1796         Reviewed by Alex Christensen.
1797
1798         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1799         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1800         Update for new interface of compileRuleList().
1801
1802 2015-03-25  Alex Christensen  <achristensen@webkit.org>
1803
1804         [Content Extensions] Add multi-DFA compiling and interpreting.
1805         https://bugs.webkit.org/show_bug.cgi?id=143010
1806
1807         Reviewed by Benjamin Poulain.
1808
1809         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1810         (TestWebKitAPI::testRequest):
1811         (TestWebKitAPI::TEST_F):
1812         Add some tests for ignore-previous-rules and large rulesets.
1813
1814 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
1815
1816         Mavericks WK1 still runs JSC tests
1817         https://bugs.webkit.org/show_bug.cgi?id=143035
1818
1819         Reviewed by Csaba Osztrogonác.
1820
1821         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
1822         with other bots.
1823
1824         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
1825         accordingly.
1826
1827 2015-03-25  Commit Queue  <commit-queue@webkit.org>
1828
1829         Unreviewed, rolling out r181932.
1830         https://bugs.webkit.org/show_bug.cgi?id=143041
1831
1832         The test fails most of the time on bots (Requested by ap on
1833         #webkit).
1834
1835         Reverted changeset:
1836
1837         "[Content Extensions] Add multi-DFA compiling and
1838         interpreting."
1839         https://bugs.webkit.org/show_bug.cgi?id=143010
1840         http://trac.webkit.org/changeset/181932
1841
1842 2015-03-24  Alex Christensen  <achristensen@webkit.org>
1843
1844         [Content Extensions] Add multi-DFA compiling and interpreting.
1845         https://bugs.webkit.org/show_bug.cgi?id=143010
1846
1847         Reviewed by Benjamin Poulain.
1848
1849         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1850         (TestWebKitAPI::testRequest):
1851         (TestWebKitAPI::TEST_F):
1852         Add some tests for ignore-previous-rules and large rulesets.
1853
1854 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
1855
1856         Make URL filter patterns matching consistent and add a simple canonicalization step
1857         https://bugs.webkit.org/show_bug.cgi?id=142998
1858
1859         Reviewed by Alex Christensen.
1860
1861         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1862
1863 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
1864
1865         [EFL] Add OpenWebRTC in jhbuild
1866         https://bugs.webkit.org/show_bug.cgi?id=142778
1867
1868         Reviewed by Gyuyoung Kim.
1869
1870         Original patch by Philippe Normand <pnormand@igalia.com>
1871
1872         * efl/install-dependencies: Dependencies for OpenWebRTC.
1873         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
1874         the openwebrtc gst plugins.
1875
1876 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
1877
1878         Regression(r181257): WTF_WorkQueue.Simple is flaky
1879         https://bugs.webkit.org/show_bug.cgi?id=142560
1880
1881         Remove the check that the refCount has returned to one after the
1882         individual tasks have completed. It's too nondeterministic when
1883         the reference count will be reduced.
1884
1885         Reviewed by Alexey Proskuryakov
1886
1887         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
1888         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
1889
1890 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1891
1892         [CMake][EFL] Put failure API test excutables into failure directory
1893         https://bugs.webkit.org/show_bug.cgi?id=142965
1894
1895         Reviewed by Csaba Osztrogonác.
1896
1897         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
1898
1899         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
1900         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
1901
1902 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
1903
1904         CSS Selectors: fix attribute case-insensitive matching of Contain and List
1905         https://bugs.webkit.org/show_bug.cgi?id=142932
1906
1907         Reviewed by Darin Adler.
1908
1909         Add tests for the new features and fix some existing tests using the 
1910         stringFromUTF8() utility recently added by Dhi.
1911
1912         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1913         (TestWebKitAPI::stringFromUTF8):
1914         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1915
1916 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1917
1918         [GTK] install-dependencies should install orc
1919         https://bugs.webkit.org/show_bug.cgi?id=142955
1920
1921         Reviewed by Martin Robinson.
1922
1923         Install orc, needed by openwebrtc
1924
1925         * gtk/install-dependencies:
1926
1927 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
1928
1929         Detect when url filter pattern with groups match the empty string
1930         https://bugs.webkit.org/show_bug.cgi?id=142930
1931
1932         Reviewed by Sam Weinig.
1933
1934         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1935
1936 2015-03-22  Anders Carlsson  <andersca@apple.com>
1937
1938         _WKWebsiteDataStore should clear WebSQL databases
1939         https://bugs.webkit.org/show_bug.cgi?id=142947
1940
1941         Reviewed by Sam Weinig.
1942
1943         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
1944
1945         * MiniBrowser/mac/WK2BrowserWindowController.m:
1946         (-[WK2BrowserWindowController fetchWebsiteData:]):
1947         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1948         (-[WK2BrowserWindowController clearWebsiteData:]):
1949
1950 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
1951
1952         GCTimer should know keep track of nested GC phases
1953         https://bugs.webkit.org/show_bug.cgi?id=142675
1954
1955         Reviewed by Darin Adler.
1956
1957         Adds a tool to aid in parsing the GC phase timing output into a
1958         tree-like structure based on the parent-child relationships
1959         of nested GC phases.
1960
1961         * Scripts/parse-gc-phase-timings: Added.
1962         (Timing):
1963         (Timing.__init__):
1964         (Timing.__unicode__):
1965         (Timing.__str__):
1966         (Timing.__repr__):
1967         (parse_input):
1968         (print_timing_node):
1969         (print_timing_tree):
1970         (link_parents):
1971         (main):
1972
1973 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
1974
1975         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
1976
1977         * Scripts/webkitpy/common/config/ews.json:
1978
1979 2015-03-20  Philippe Normand  <pnormand@igalia.com>
1980
1981         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
1982         https://bugs.webkit.org/show_bug.cgi?id=142867
1983
1984         Rubber-stamped by Csaba Osztrogon.
1985
1986         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
1987         a fixed revision for the openwebrtc-gst-plugins.
1988
1989 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1990
1991         Unreviewed build fix. Don't try to report stats for all benchmarks.
1992         Just report the geometric mean of preferred means.
1993
1994         * Scripts/run-jsc-benchmarks:
1995
1996 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
1997
1998         run-jsc-benchmarks should only report preferred mean
1999         https://bugs.webkit.org/show_bug.cgi?id=142874
2000
2001         Reviewed by Geoffrey Garen.
2002
2003         Just collect statistics for the preferred mean.
2004
2005         * Scripts/run-jsc-benchmarks:
2006
2007 2015-03-19  Alex Christensen  <achristensen@webkit.org>
2008
2009         [Content Extensions] Test regular expression parse failures.
2010         https://bugs.webkit.org/show_bug.cgi?id=142872
2011
2012         Reviewed by Benjamin Poulain.
2013
2014         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2015         (TestWebKitAPI::testPatternStatus):
2016         (TestWebKitAPI::TEST_F):
2017         Added tests for each parsing status.
2018
2019 2015-03-19  Alex Christensen  <achristensen@webkit.org>
2020
2021         Fix API tests after r181754.
2022
2023         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2024         (TestWebKitAPI::testRequest):
2025
2026 2015-03-19  Brady Eidson  <beidson@apple.com>
2027
2028         Part of content extensions should apply css selectors
2029         https://bugs.webkit.org/show_bug.cgi?id=142604
2030
2031         Reviewed by Alex Christensen.
2032
2033         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2034         (WebCore::ContentExtensions::operator<<):
2035
2036 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
2037
2038         [Win] Activate tests on EWS
2039         https://bugs.webkit.org/show_bug.cgi?id=142850
2040
2041         Reviewed by Alexey Proskuryakov.
2042
2043         * Scripts/webkitpy/common/config/ews.json: Add me as
2044         the EWS bot watcher, and activate tests.
2045
2046 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
2047
2048         [GTK] Fix inspector userinterface related incremental build issue
2049         https://bugs.webkit.org/show_bug.cgi?id=142849
2050
2051         Reviewed by Carlos Garcia Campos.
2052
2053         * Scripts/webkitdirs.pm:
2054         (shouldRemoveCMakeCache):
2055
2056 2015-03-18  Alex Christensen  <achristensen@webkit.org>
2057
2058         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
2059         https://bugs.webkit.org/show_bug.cgi?id=142799
2060
2061         Reviewed by Brady Eidson.
2062
2063         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2064         (TestWebKitAPI::testPattern):
2065         (TestWebKitAPI::TEST_F):
2066         Start testing regex failures.
2067
2068 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
2069
2070         Fix StringView typos after r181525 and r181558
2071         https://bugs.webkit.org/show_bug.cgi?id=142772
2072
2073         Reviewed by Darin Adler.
2074
2075         Add some tests in [1] to cover the StringView::startsWith, 
2076         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
2077         StringView::endsWithIgnoringASCIICase implementations.
2078
2079         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2080         (TestWebKitAPI::TEST):
2081
2082 2015-03-18  Dana Burkart  <dburkart@apple.com>
2083
2084         Remove extraneous import to fix the build.
2085
2086         Unreviewed.
2087
2088         * Scripts/webkitpy/port/driver.py:
2089
2090 2015-03-18  Dana Burkart  <dburkart@apple.com>
2091
2092         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
2093         https://bugs.webkit.org/show_bug.cgi?id=142547
2094
2095         Reviewed by Alexey Proskuryakov.
2096
2097         * Scripts/webkitpy/port/driver.py:
2098         (Driver._setup_environ_for_driver):
2099
2100 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
2101
2102         Tweak how AppleSystemFontOSSubversion default is added
2103         https://bugs.webkit.org/show_bug.cgi?id=142835
2104
2105         Reviewed by Dan Bernstein.
2106
2107         * DumpRenderTree/mac/DumpRenderTree.mm:
2108         (setDefaultsToConsistentValuesForTesting):
2109
2110 2015-03-18  Dan Bernstein  <mitz@apple.com>
2111
2112         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
2113         https://bugs.webkit.org/show_bug.cgi?id=142815
2114
2115         Reviewed by Darin Adler.
2116
2117         * Scripts/prepare-ChangeLog:
2118         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
2119         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
2120         keep consuming the quoted text until the matching quotation mark is reached. Emit the
2121         warning only if a line ends without a backslash before the matching quotation mark was found.
2122
2123 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
2124
2125         Remove unused "preprocessor" parameter to sub-CodeGenerators
2126         https://bugs.webkit.org/show_bug.cgi?id=142793
2127
2128         Reviewed by Darin Adler.
2129
2130         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2131         (new):
2132
2133 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
2134
2135         [EFL] Bump gstreamer version to 1.4.4
2136         https://bugs.webkit.org/show_bug.cgi?id=142782
2137
2138         Reviewed by Philippe Normand.
2139
2140         * efl/jhbuild.modules:
2141         * efl/patches/gst-libav.patch:
2142         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
2143         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
2144
2145 2015-03-17  Tim Horton  <timothy_horton@apple.com>
2146
2147         Fix the iOS build.
2148
2149         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2150         (WTR::InjectedBundle::platformInitialize):
2151
2152 2015-03-17  Dean Jackson  <dino@apple.com>
2153
2154         check-webkit-style should allow "bool a : 1"
2155         https://bugs.webkit.org/show_bug.cgi?id=142794
2156
2157         Reviewed by Brent Fulgham.
2158
2159         We should allow member bitfields of the form:
2160
2161         bool m_var : 1;
2162
2163         It seems that Visual Studio 8 was the last compiler that
2164         wasn't happy about not using unsigned here. We already have
2165         about 500 cases (in WebCore) where people were ignoring this rule.
2166
2167         * Scripts/webkitpy/style/checkers/cpp.py:
2168         (check_language): Allow "bool".
2169         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
2170         (CppStyleTest.test_enum_bitfields):
2171         (CppStyleTest.test_plain_integral_bitfields):
2172
2173 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
2174
2175         Compile character ranges targeting the same state as range check in the bytecode
2176         https://bugs.webkit.org/show_bug.cgi?id=142759
2177
2178         Reviewed by Alex Christensen.
2179
2180         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2181         (TestWebKitAPI::TEST_F):
2182
2183 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2184
2185         W3C test parser and converter should use test importer host
2186         https://bugs.webkit.org/show_bug.cgi?id=142729
2187
2188         Reviewed by Bem Jones-Bey.
2189
2190         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
2191         This enables adding more TestImporter unit testing.
2192         This patch also ensures that the git object instantiated by TestDownloader is using the
2193         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
2194
2195         * Scripts/webkitpy/common/system/filesystem_mock.py:
2196         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
2197         * Scripts/webkitpy/w3c/test_downloader.py:
2198         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
2199         (TestDownloader.checkout_test_repository): Making use of the new git function.
2200         * Scripts/webkitpy/w3c/test_importer.py:
2201         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
2202         (TestImporter.import_tests): Adding host as parameter to the converter.
2203         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2204         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
2205         (TestImporterTest):
2206         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
2207         * Scripts/webkitpy/w3c/test_parser.py:
2208         (TestParser.__init__): Adding host as parameter constructor.
2209
2210 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2211
2212         [GTK] WebKitDOM objects leaking
2213         https://bugs.webkit.org/show_bug.cgi?id=118788
2214
2215         Reviewed by Darin Adler and Sergio Villar Senin.
2216
2217         Update DOMObjectCache unit test to check that DOM objects are also
2218         released when new contents are loaded in the web view, and the old
2219         document is detached from the frame.
2220
2221         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2222         (testWebKitDOMObjectCache):
2223         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2224         (runTest):
2225
2226 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2227
2228         W3C test importer default import folder should be LayoutTests/imported/w3c
2229         https://bugs.webkit.org/show_bug.cgi?id=142728
2230
2231         Reviewed by Bem Jones-Bey.
2232
2233         * Scripts/webkitpy/w3c/test_importer.py:
2234         (parse_args): Updating the default destination option value to 'imported/w3c'.
2235
2236 2015-03-17  Philippe Normand  <pnormand@igalia.com>
2237
2238         [GTK] basic OpenWebRTC build support
2239         https://bugs.webkit.org/show_bug.cgi?id=142393
2240
2241         Reviewed by Carlos Garcia Campos.
2242
2243         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
2244         is not the upstream OpenWebRTC repository. This temporary fork
2245         contains a few patches needed by WebKit for audio/video rendering.
2246
2247 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2248
2249         [CMake][EFL] Build test tools only for developer mode
2250         https://bugs.webkit.org/show_bug.cgi?id=142761
2251
2252         Reviewed by Csaba Osztrogonác.
2253
2254         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
2255
2256         * CMakeLists.txt:
2257
2258 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
2259
2260         Remove never used "useLayerOnTop" bindings generator argument
2261         https://bugs.webkit.org/show_bug.cgi?id=142773
2262
2263         Reviewed by Darin Adler.
2264
2265         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2266         (new):
2267
2268 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
2269
2270         Enable ES6 classes by default
2271         https://bugs.webkit.org/show_bug.cgi?id=142774
2272
2273         Reviewed by Gavin Barraclough.
2274
2275         * Scripts/webkitperl/FeatureList.pm:
2276
2277 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
2278
2279         Fix webkitpy tests after r181585.
2280
2281         Looks like "me" cannot be anyone's email, it's a special case.
2282
2283         * Scripts/webkitpy/common/config/contributors.json:
2284
2285 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
2286
2287         Add tolerance to WebAudio tests
2288         https://bugs.webkit.org/show_bug.cgi?id=142676
2289
2290         Reviewed by Tim Horton.
2291
2292         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
2293
2294         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2295         (TestResultWriter.create_audio_diff_and_write_result):
2296         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2297         (FailureAudio.write_failure):
2298         * Scripts/webkitpy/port/base.py:
2299         (Port.do_audio_results_differ):
2300         Diff audio failures.
2301
2302         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
2303         tests to use real parseable WAV data, and got rid of base64, which there didn't
2304         seem to have been any reason for.
2305
2306 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
2307
2308         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
2309         https://bugs.webkit.org/show_bug.cgi?id=142720
2310
2311         Reviewed by Myles C. Maxfield.
2312
2313         Activate system copies of Microsoft fonts for the current process, thus overriding
2314         any other ones that could be preferred by the system otherwise.
2315
2316         * DumpRenderTree/mac/DumpRenderTree.mm:
2317         (activateSystemCoreWebFonts):
2318         (adjustFonts):
2319         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2320         (WTR::activateSystemCoreWebFonts):
2321         (WTR::activateFonts):
2322
2323 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2324
2325         Created Streams API watchlist
2326         https://bugs.webkit.org/show_bug.cgi?id=142684
2327
2328         Reviewed by Benjamin Poulain.
2329
2330         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
2331         watchlist and added Benjamin, Youenn and me to it.
2332
2333 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
2334
2335         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
2336         https://bugs.webkit.org/show_bug.cgi?id=142715
2337
2338         Reviewed by Brent Fulgham.
2339
2340         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2341         (TestWebKitAPI::TEST):
2342
2343 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
2344
2345         Change the exact attribute matching to be ASCII case-insensitive
2346         https://bugs.webkit.org/show_bug.cgi?id=142609
2347
2348         Reviewed by Darin Adler.
2349
2350         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2351         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2352
2353 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2354
2355         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
2356         https://bugs.webkit.org/show_bug.cgi?id=134764
2357
2358         Reviewed by Ryosuke Niwa.
2359
2360         TestDownloader is introduced to download W3C tests from the official
2361         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
2362         and https://github.com/w3c/csswg-test.git).
2363         TestDownloader clones the repositories and checkouts revisions of the tests
2364         defined in LayoutTests/imported/w3c/resources/TestRepositories.
2365
2366         Similarly to https://codereview.chromium.org/148173016,
2367         TestDownloader copies part of the files based on the rules
2368         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
2369
2370         TestDownloader is used by TestImporter when no source directory is provided.
2371
2372         * Scripts/webkitpy/w3c/test_downloader.py: Added.
2373         (TestDownloader):
2374         (TestDownloader.default_options):
2375         (TestDownloader.load_test_repositories):
2376         (TestDownloader.__init__):
2377         (TestDownloader.checkout_test_repository):
2378         (TestDownloader._init_paths_from_expectations):
2379         (TestDownloader._add_test_suite_paths):
2380         (TestDownloader._empty_directory):
2381         (TestDownloader.copy_tests):
2382         (TestDownloader.download_tests):
2383         * Scripts/webkitpy/w3c/test_importer.py:
2384         (main):
2385         (parse_args):
2386         (TestImporter.__init__):
2387         (TestImporter.do_import):
2388         (TestImporter.test_downloader):
2389         (TestImporter.find_importable_tests.should_keep_subdir):
2390         (TestImporter.should_convert_test_harness_links):
2391         (TestImporter.import_tests):
2392         (TestImporter.write_import_log):
2393
2394 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
2395
2396         [Mavericks] Test snapshots are 1600x1200 on Retina devices
2397         https://bugs.webkit.org/show_bug.cgi?id=142630
2398
2399         Reviewed by Tim Horton.
2400
2401         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
2402         Removed an ifdef that disabled the fix on Mavericks.
2403
2404 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
2405
2406         Remove isWK2 cruft from webkitdirs.pm after r170426
2407         https://bugs.webkit.org/show_bug.cgi?id=142618
2408
2409         Reviewed by Daniel Bates.
2410
2411         * Scripts/webkitdirs.pm:
2412         (isWK2): Deleted.
2413
2414 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
2415
2416         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
2417         https://bugs.webkit.org/show_bug.cgi?id=138687
2418
2419         Reviewed by Carlos Garcia Campos.
2420
2421         Always change cookie policy from UI process, as changing it from WebProcess doesn't
2422         affect other processes.
2423
2424         The implementation is imperfect, because the change happens asynchronously, but I
2425         don't expect it to be a problem in practice.
2426
2427         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2428         (WTR::InjectedBundle::beginTesting):
2429         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2430         (WTR::TestRunner::setAlwaysAcceptCookies):
2431         * WebKitTestRunner/TestInvocation.cpp:
2432         (WTR::TestInvocation::invoke):
2433         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2434
2435 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
2436
2437         [EFL] Enable building EFL 1.13 with NEON support
2438         https://bugs.webkit.org/show_bug.cgi?id=142619
2439
2440         Reviewed by Gyuyoung Kim.
2441
2442         * efl/jhbuild.modules:
2443
2444 2015-03-11  Alex Christensen  <achristensen@webkit.org>
2445
2446         [Content Extensions] Add resource type and load type triggers.
2447         https://bugs.webkit.org/show_bug.cgi?id=142422
2448
2449         Reviewed by Benjamin Poulain.
2450
2451         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2452         (TestWebKitAPI::testRequest):
2453         (TestWebKitAPI::mainDocumentRequest):
2454         (TestWebKitAPI::TEST_F):
2455         (TestWebKitAPI::testURL): Deleted.
2456
2457 2015-03-10  Sam Weinig  <sam@webkit.org>
2458
2459         Allow adding a button in input elements for auto fill related functionality
2460         <rdar://problem/19782066>
2461         https://bugs.webkit.org/show_bug.cgi?id=142564
2462
2463         Reviewed by Anders Carlsson.
2464
2465         * WebKitTestRunner/TestController.cpp:
2466         (WTR::TestController::createOtherPage):
2467         (WTR::TestController::createWebViewWithOptions):
2468         Update for new callback.
2469
2470 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
2471
2472         Add basic support for BOL and EOL assertions to the URL Filter parser
2473         https://bugs.webkit.org/show_bug.cgi?id=142568
2474
2475         Reviewed by Alex Christensen.
2476
2477         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2478         (TestWebKitAPI::TEST_F):
2479
2480 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2481
2482         [GTK] Add support for handling TLS errors to MiniBrowser
2483         https://bugs.webkit.org/show_bug.cgi?id=142576
2484
2485         Reviewed by Sergio Villar Senin.
2486
2487         It's useful for testing TLS errors handling itself, but also to
2488         allow ignoring TLS errors when testing.
2489
2490         * MiniBrowser/gtk/BrowserWindow.c:
2491         (webViewLoadFailedWithTLSerrors):
2492         (browserWindowConstructed):
2493
2494 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
2495
2496         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
2497         https://bugs.webkit.org/show_bug.cgi?id=142569
2498
2499         Reviewed by David Hyatt.
2500
2501         Test Optional::valueOrCompute().
2502
2503         * TestWebKitAPI/Tests/WTF/Optional.cpp:
2504         (TestWebKitAPI::TEST):
2505
2506 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2507
2508         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
2509         https://bugs.webkit.org/show_bug.cgi?id=126688
2510
2511         Reviewed by Gustavo Noronha Silva.
2512
2513         * CMakeLists.txt: Build testing tools only for developer builds,
2514         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
2515         * MiniBrowser/gtk/CMakeLists.txt: Only add
2516         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
2517         and add a rule to install the MiniBrowser.
2518         * MiniBrowser/gtk/main.c:
2519         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
2520         builds.
2521
2522 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
2523
2524         Add some DateMath tests to TestWebKitAPI
2525         https://bugs.webkit.org/show_bug.cgi?id=142565
2526
2527         Reviewed by Alexey Proskuryakov.
2528
2529         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
2530         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
2531         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
2532         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
2533         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
2534
2535 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
2536
2537         Regression(r181257): WTF_WorkQueue.Simple is flaky
2538         https://bugs.webkit.org/show_bug.cgi?id=142560
2539
2540         Unreviewed attempt to improve test stability.
2541
2542         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
2543         the WorkQueue a little later to redue flakiness.
2544
2545 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
2546
2547         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
2548         https://bugs.webkit.org/show_bug.cgi?id=142555
2549
2550         Reviewed by Simon Fraser.
2551
2552         * DumpRenderTree/mac/DumpRenderTree.mm:
2553         (setDefaultsToConsistentValuesForTesting):
2554         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2555         (WTR::InjectedBundle::platformInitialize):
2556
2557 2015-03-10  Alex Christensen  <achristensen@webkit.org>
2558
2559         Use unsigned for HashSet size.
2560         https://bugs.webkit.org/show_bug.cgi?id=142518
2561
2562         Reviewed by Benjamin Poulain.
2563
2564         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2565         (TestWebKitAPI::TEST):
2566         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2567         (TestWebKitAPI::testInitialCapacity):
2568         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2569         (TestWebKitAPI::TEST):
2570
2571 2015-03-10  Daniel Bates  <dabates@apple.com>
2572
2573         [iOS] Add WebKitSystemInterface for iOS 8.2
2574         https://bugs.webkit.org/show_bug.cgi?id=142505
2575
2576         Rubber-stamped by Anders Carlsson.
2577
2578         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
2579         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
2580         copy-webkitlibraries-to-product-directory in r181286.
2581
2582         * Scripts/copy-webkitlibraries-to-product-directory:
2583
2584 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
2585
2586         Extend URL filter's Term definition to support groups/subpatterns
2587         https://bugs.webkit.org/show_bug.cgi?id=142519
2588
2589         Reviewed by Alex Christensen.
2590
2591         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2592         (TestWebKitAPI::testURL):
2593
2594 2015-03-06  Jer Noble  <jer.noble@apple.com>
2595
2596         Add an option to run-webkit-tests to override the LayoutTests/ directory
2597         https://bugs.webkit.org/show_bug.cgi?id=142418
2598
2599         Reviewed by David Kilzer.
2600
2601         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
2602         directory. The base port will parse the options during initialization and store the override
2603         location if present. layout_tests_dir() will return this overridden location if set.
2604
2605         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2606         (parse_args):
2607         * Scripts/webkitpy/port/base.py:
2608         (Port.__init__):
2609         (Port.layout_tests_dir):
2610
2611 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
2612
2613         [CMake] Enable WorkQueue tests for CMake ports
2614         https://bugs.webkit.org/show_bug.cgi?id=142473
2615
2616         Reviewed by Darin Adler.
2617
2618         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
2619         the list of source files.
2620         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
2621         to the list of include directories for EFL.
2622
2623 2015-03-09  David Kilzer  <ddkilzer@apple.com>
2624
2625         Attempt to fix timeouts on iOS Simulator layout tests
2626
2627         * Scripts/webkitpy/port/ios.py:
2628         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
2629         Simulator end after the first 50 tests time out.  Some analysis
2630         this past weekend shows that the 'Booted' status in the output
2631         of `xcrun simctl list` is not sufficient (and watching the test
2632         run shows that SpringBoard hasn't fully started to the point
2633         where it's displaying icons on the home screen).  The workaround
2634         until we have a better fix is to add an arbitrary timeout to let
2635         SpringBoard finish launching.  In practice, 15 seconds is
2636         probably enough, but 30 seconds should nearly always work.
2637
2638 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
2639
2640         Unreviewed. Add myself as a committer.
2641
2642         * Scripts/webkitpy/common/config/contributors.json:
2643
2644 2015-03-09  David Kilzer  <ddkilzer@apple.com>
2645
2646         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
2647
2648         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2649         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
2650         an expectation that will fail if we hit the race condition.
2651         This test is inherently racy and will deadlock if the first job
2652         for queue2 takes the mutex lock before the second job for
2653         queue1.
2654
2655 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
2656
2657         [Win] WTF::WorkQueue does not balance ref/deref properly
2658         https://bugs.webkit.org/show_bug.cgi?id=142471
2659
2660         Reviewed by Antti Koivisto.
2661
2662         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2663         (TestWebKitAPI::TEST): Check that the refcount is correct.
2664
2665 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2666
2667         Do not show passing test result on output of EFL layout test
2668         https://bugs.webkit.org/show_bug.cgi?id=142380
2669
2670         Reviewed by Darin Adler.
2671
2672         To show passing tests has caused inconvenience when we detect problem tests
2673         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
2674         in order not to show passing tests in the output of EFL layout test.
2675
2676         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2677         (RunWebKitTests.start):
2678
2679 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
2680
2681         Unreviewed build fix.
2682
2683         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2684         (TestWebKitAPI::TEST): Remove two unused variables.
2685
2686 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
2687
2688         Add some WorkQueue tests to TestWebKitAPI
2689         https://bugs.webkit.org/show_bug.cgi?id=142447
2690
2691         Reviewed by Sam Weinig.
2692
2693         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2694         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2695         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2696         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
2697         (TestWebKitAPI::simpleTest):
2698         (TestWebKitAPI::longTest):
2699         (TestWebKitAPI::thirdTest):
2700         (TestWebKitAPI::finishedTests):
2701         (TestWebKitAPI::TEST):
2702         (TestWebKitAPI::longTest2):
2703
2704 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2705
2706         Remove willDestroyFrame in WKBundlePageLoaderClient
2707         https://bugs.webkit.org/show_bug.cgi?id=142389
2708
2709         Reviewed by Anders Carlsson.
2710
2711         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2712         (WTR::InjectedBundlePage::InjectedBundlePage):
2713
2714 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
2715
2716         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
2717         https://bugs.webkit.org/show_bug.cgi?id=142433
2718
2719         Reviewed by Darin Adler.
2720
2721         Include more TestWebKitAPI tests when building for Windows. Also
2722         fix a build error in MetaAllocator.cpp caused by one of the
2723         Microsoft headers #defining 'small'.
2724
2725         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2726         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2727         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2728
2729 2015-03-06  Sam Weinig  <sam@webkit.org>
2730
2731         [Content Extensions] Move compiling of content extensions to the UIProcess
2732         https://bugs.webkit.org/show_bug.cgi?id=142402
2733
2734         Reviewed by Benjamin Poulain.
2735
2736         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2737         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
2738         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2739         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
2740         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2741         (TestWebKitAPI::TEST_F):
2742         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
2743         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
2744         is now abstract).
2745
2746 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
2747
2748         [Win] Correct Windows build.
2749
2750         Rubberstamped by Michael Saboff
2751
2752         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
2753         in the GOTO labels.
2754
2755 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2756
2757         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
2758         https://bugs.webkit.org/show_bug.cgi?id=142385
2759
2760         Reviewed by Sergio Villar Senin.
2761
2762         Use stack allocated GMainLoopSources to make sure they are
2763         cancelled automatically if the test finishes before they have
2764         been processed.
2765
2766         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2767         (testWebViewSyncRequestOnMaxConns):
2768
2769 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2770
2771         Remove Mountain Lion libraries since ML isn't supported
2772         https://bugs.webkit.org/show_bug.cgi?id=142332
2773
2774         Reviewed by Darin Adler.
2775
2776         * Scripts/copy-webkitlibraries-to-product-directory:
2777
2778 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
2779
2780         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
2781         https://bugs.webkit.org/show_bug.cgi?id=142083
2782
2783         Reviewed by Simon Fraser.
2784
2785         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
2786
2787         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2788         (WebPlatformTestServer._copy_webkit_test_files):
2789
2790 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2791
2792         setup-git-clone fails due to the failure to download python-irclib-0.4.8
2793         https://bugs.webkit.org/show_bug.cgi?id=141946
2794
2795         Reviewed by Ryosuke Niwa.
2796
2797         Check in ircbot.py and irclib.py to avoid network problems in the future.
2798
2799         * Scripts/webkitpy/common/net/irc/ircbot.py:
2800         * Scripts/webkitpy/thirdparty/__init__.py:
2801         (AutoinstallImportHook.find_module):
2802         (AutoinstallImportHook._install_irc): Deleted.
2803         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2804         (ThirdpartyTest.test_imports):
2805         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
2806         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
2807         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
2808
2809 2015-03-06  David Kilzer  <ddkilzer@apple.com>
2810
2811         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
2812
2813         See also fix to config.json in r181097.
2814
2815         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2816         (WebKitBuildbot): Add missing "WK2" to the names of the perf
2817         bots.
2818
2819 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
2820
2821         run-jsc-stress-tests should determine the architecture from ELF binaries
2822         https://bugs.webkit.org/show_bug.cgi?id=142335
2823
2824         Reviewed by Darin Adler.
2825
2826         * Scripts/run-jsc-stress-tests:
2827
2828 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2829
2830         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
2831         <http://webkit.org/b/142226>
2832
2833         Reviewed by Darin Adler.
2834
2835         * Scripts/webkitpy/port/ios.py:
2836         (IOSSimulatorPort.default_baseline_search_path): Switch the
2837         TestExpectations order of ios-simulator-wk2 from this:
2838           ios-simulator-wk2, wk2, ios-simulator
2839         To this:
2840           ios-simulator-wk2, ios-simualtor, wk2
2841
2842 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2843
2844         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
2845         https://bugs.webkit.org/show_bug.cgi?id=142370
2846
2847         Reviewed by Dean Jackson.
2848
2849         * Scripts/webkitdirs.pm:
2850         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
2851         logs, one for warnings, the other for errors.
2852         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
2853         into the standard BuildOutput.htm document.
2854
2855 2015-03-05  David Kilzer  <ddkilzer@apple.com>
2856
2857         Dashboard has trouble parsing iOS test output
2858         <http://webkit.org/b/142364>
2859
2860         Reviewed by Alex Christensen.
2861
2862         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2863         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
2864         Add fallback path to build a regex using 'matchString' so that
2865         it matches anywhere in the line.  In practice, 'matchString' is
2866         a prefix for the label following the number.
2867
2868 2015-03-05  Alex Christensen  <achristensen@webkit.org>
2869
2870         Fix linker warnings in TestWebKitAPI.
2871         https://bugs.webkit.org/show_bug.cgi?id=141912
2872
2873         Reviewed by David Kilzer.
2874
2875         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2876         Do not export TearDownTestCase or SetUpTestCase symbols.
2877
2878 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2879
2880         [Win] Unreviewed EWS fix.
2881
2882         * Scripts/webkitdirs.pm:
2883         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
2884         the EWS output more usable.
2885
2886 2015-03-05  Chris Dumez  <cdumez@apple.com>
2887
2888         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
2889         https://bugs.webkit.org/show_bug.cgi?id=142350
2890
2891         Reviewed by Michael Saboff and Benjamin Poulain.
2892
2893         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
2894         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
2895
2896         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2897         (TestWebKitAPI::TEST):
2898
2899 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2900
2901         [Win] Ensure build target directory exists when launching MSBuild
2902         https://bugs.webkit.org/show_bug.cgi?id=142360
2903
2904         Reviewed by Dean Jackson.
2905
2906         Create the build output directory (if it doesn't exist) before
2907         launching MSBuild so that it can immediately begin writing logs.
2908
2909         * Scripts/webkitdirs.pm:
2910         (buildVisualStudioProject):
2911
2912 2015-03-05  Chris Dumez  <cdumez@apple.com>
2913
2914         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
2915         https://bugs.webkit.org/show_bug.cgi?id=142325
2916
2917         Reviewed by Csaba Osztrogonác.
2918
2919         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
2920         As a result, "--webkit-test-runner / -2" parameters are replaced by
2921         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
2922         than WebKitTestRunner.
2923
2924         * BuildSlaveSupport/build.webkit.org-config/config.json:
2925         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2926         (RunWebKit1Tests):
2927         (RunWebKit1Tests.start):
2928         (RunWebKit1LeakTests):
2929         (RunWebKit1LeakTests.start):
2930         (RunAndUploadPerfTestsWebKit1):
2931         (RunAndUploadPerfTestsWebKit1.start):
2932         (TestFactory):
2933         (TestWebKit1LeaksFactory):
2934         (TestWebKit1LeaksFactory.__init__):
2935         (TestWebKit1Factory):
2936         (TestWebKit1AllButJSCFactory):
2937         (TestAllButJSCFactory):
2938         (BuildAndPerfTestWebKit1Factory):
2939         (BuildAndPerfTestWebKit1Factory.__init__):
2940         (BuildAndPerfTestFactory):
2941         (BuildAndPerfTestFactory.__init__):
2942         (DownloadAndPerfTestWebKit1Factory):
2943         (DownloadAndPerfTestWebKit1Factory.__init__):
2944         (DownloadAndPerfTestFactory):
2945         (DownloadAndPerfTestFactory.__init__):
2946         (RunWebKitLeakTests): Deleted.
2947         (RunWebKitLeakTests.start): Deleted.
2948         (RunWebKit2Tests): Deleted.
2949         (RunWebKit2Tests.start): Deleted.
2950         (RunAndUploadPerfTestsWebKit2): Deleted.
2951         (RunAndUploadPerfTestsWebKit2.start): Deleted.
2952         (TestLeaksFactory): Deleted.
2953         (TestLeaksFactory.__init__): Deleted.
2954         (TestWebKit2Factory): Deleted.
2955         (TestWebKit2AndJSCFactory): Deleted.
2956         (BuildAndPerfTestWebKit2Factory): Deleted.
2957         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
2958         (DownloadAndPerfTestWebKit2Factory): Deleted.
2959         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
2960         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2961         (parse_args):
2962         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2963         (PerfTestsRunner._parse_args):
2964         * Scripts/webkitpy/port/port_testcase.py:
2965         (PortTestCase.test_build_driver):
2966
2967 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
2968
2969         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
2970         https://bugs.webkit.org/show_bug.cgi?id=140845
2971
2972         Reviewed by David Kilzer.
2973
2974         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
2975         and generate suitable build commands to drive a full build from our
2976         existing solution files.
2977
2978         * Scripts/webkitdirs.pm:
2979         (msBuildInstallDir): Added.
2980         (determineConfigurationForVisualStudio): Revise to use MSBuild command
2981         line arguments to drive the build.
2982         (setupCygwinEnv): Warn user if MSBuild cannot be located.
2983         (buildVisualStudioProject): Revise to use MSBuild command line arguments
2984         to specify build architecture.
2985         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
2986         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
2987         bother looking for CoreUI or SafariTheme build logs.
2988
2989 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
2990
2991         [buildbot] mastercfg_unittest.py should be runnable easily
2992         https://bugs.webkit.org/show_bug.cgi?id=142219
2993
2994         Reviewed by Chris Dumez.
2995
2996         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
2997         the last Twisted version works together with this buildbot version.
2998
2999         * Scripts/webkitpy/common/system/autoinstall.py:
3000         (AutoInstaller): Added prepend_to_search_path argument to be able
3001         to prefer autoinstalled package to system package.
3002         (AutoInstaller.__init__):
3003         (AutoInstaller._set_up_target_dir):
3004         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
3005         (AutoInstaller._prepare_package):
3006         (AutoInstaller._extract_targz): Renamed to _extract_tar.
3007         * Scripts/webkitpy/thirdparty/__init__.py:
3008         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
3009
3010 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
3011
3012         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
3013         https://bugs.webkit.org/show_bug.cgi?id=131162
3014
3015         Reviewed by Gyuyoung Kim.
3016
3017         * MiniBrowser/efl/main.c:
3018         (on_download_request):
3019         (on_download_finished):
3020         (on_download_failed):
3021         (window_create):
3022         Adapt download callbacks to new callback mechanism
3023
3024 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3025
3026         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
3027
3028         In r180927 we updated the libsoup version used by the jhbuild. In
3029         this new version the sniffer uses image/x-icon instead of
3030         image/vnd.microsoft.icon for blank.ico resource.
3031
3032         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3033         (testWebResourceMimeType):
3034
3035 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3036
3037         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
3038         https://bugs.webkit.org/show_bug.cgi?id=142244
3039
3040         Reviewed by Sergio Villar Senin.
3041
3042         Check that the SSL server doesn't process any request in case of
3043         TLS errors when the policy is set to FAIL.
3044
3045         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3046         (testTLSErrorsPolicy):
3047         (testTLSErrorsRedirect):
3048         (testTLSErrorsHTTPAuth):
3049         (testLoadFailedWithTLSErrors):
3050         (testSubresourceLoadFailedWithTLSErrors):
3051         (httpsServerCallback):
3052
3053 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
3054
3055         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
3056         https://bugs.webkit.org/show_bug.cgi?id=141154
3057
3058         Reviewed by Jer Noble.
3059
3060         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
3061
3062         For the sake of completeness WebKitTestRunner should specify temporary
3063         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
3064
3065         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
3066         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
3067         to get data storage paths. Only Mac port has an actual implementation of it.
3068         However, WebKitTestRunner overrides them in favour of unique temporary dir
3069         which is taken from libraryPathForTesting().
3070
3071         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
3072         is not implemented for EFL and GTK ports it returns an empty string.
3073         All default data folders besides MediaKeys are overridden in TestRunner
3074         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
3075         env variable.
3076
3077         GTK port does not enable encrypted keys by default so
3078         WebMediaKeyStorageManager::initialize() code path is never triggered.
3079
3080         * WebKitTestRunner/TestController.cpp:
3081         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
3082         WebKit ports.
3083
3084 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
3085
3086         [buildbot] Add regression test to check which builder runs which tests
3087         https://bugs.webkit.org/show_bug.cgi?id=142166
3088
3089         Reviewed by Alexey Proskuryakov.
3090
3091         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3092         (BuildStepsConstructorTest.createTest):
3093         (BuildStepsTest):
3094         (BuildStepsTest.generateTests):
3095         (BuildStepsTest.createTest):
3096         (BuildStepsTest.createTest.doTest):
3097         (BuildStepsTest.test_unnecessary_expected_results):
3098
3099 2015-03-04  Commit Queue  <commit-queue@webkit.org>
3100
3101         Unreviewed, rolling out r181054.
3102         https://bugs.webkit.org/show_bug.cgi?id=142320
3103
3104         Broke the api tests (Requested by sundiamonde on #webkit).
3105
3106         Reverted changeset:
3107
3108         "Fix linker warnings in TestWebKitAPI."
3109         https://bugs.webkit.org/show_bug.cgi?id=141912
3110         http://trac.webkit.org/changeset/181054
3111
3112 2015-03-04  Alex Christensen  <achristensen@webkit.org>
3113
3114         Fix linker warnings in TestWebKitAPI.
3115         https://bugs.webkit.org/show_bug.cgi?id=141912
3116
3117         Reviewed by David Kilzer.
3118
3119         * TestWebKitAPI/Configurations/Base.xcconfig:
3120         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
3121
3122 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
3123
3124         [Mac] Set SystemUIFontSelect in DRT and WKTR
3125         https://bugs.webkit.org/show_bug.cgi?id=142303
3126
3127         Reviewed by Myles C. Maxfield.
3128
3129         * DumpRenderTree/mac/DumpRenderTree.mm:
3130         (setDefaultsToConsistentValuesForTesting):
3131         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3132         (WTR::InjectedBundle::platformInitialize):
3133
3134 2015-03-04  Chris Dumez  <cdumez@apple.com>
3135
3136         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
3137         https://bugs.webkit.org/show_bug.cgi?id=142314
3138         <rdar://problem/20046835>
3139
3140         Reviewed by Ryosuke Niwa.
3141
3142         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
3143         to get WK2 code coverage.
3144
3145         * BuildSlaveSupport/build.webkit.org-config/config.json:
3146
3147 2015-03-04  Alex Christensen  <achristensen@webkit.org>
3148
3149         Move content extensions test to properly named directory.
3150         https://bugs.webkit.org/show_bug.cgi?id=142299
3151
3152         Reviewed by Tim Horton.
3153
3154         * WebKitTestRunner/mac/TestControllerMac.mm:
3155         (WTR::TestController::platformConfigureViewForTest):
3156
3157 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3158
3159         W3C test importer should use filesystem instead of os.walk
3160         https://bugs.webkit.org/show_bug.cgi?id=142085
3161
3162         Reviewed by Bem Jones-Bey.
3163
3164         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
3165         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
3166         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
3167
3168         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
3169         Added a unit test to check that test importer is now black-box testable using a Mock system.
3170
3171         * Scripts/webkitpy/common/system/filesystem.py:
3172         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
3173         (FileSystem.dirs_under.filter_all):
3174         * Scripts/webkitpy/common/system/filesystem_mock.py:
3175         (MockFileSystem.dirs_under):
3176         (MockFileSystem.dirs_under.filter_all):
3177         (MockFileSystem.getsize):
3178         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
3179         (MockFileSystemTest.test_dirs_under):
3180         (MockFileSystemTest.test_dirs_under.filter_dir):
3181         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3182         (RealFileSystemTest.test_sep):
3183         (RealFileSystemTest):
3184         (RealFileSystemTest.test_dirs_under):
3185         (RealFileSystemTest.test_dirs_under.filter_this_dir):
3186         * Scripts/webkitpy/w3c/test_importer.py:
3187         (TestImporter.do_import):
3188         (TestImporter.find_importable_tests.should_keep_subdir):
3189         (TestImporter.find_importable_tests):
3190         (TestImporter.should_keep_subdir): Deleted.
3191         (TestImporter.should_skip_file): Deleted.
3192         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3193         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
3194
3195 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
3196
3197         [WebEditingTester] Add support for the find and replace bar
3198         https://bugs.webkit.org/show_bug.cgi?id=142247
3199
3200         Reviewed by Enrica Casucci.
3201
3202         While it's not hooked up yet in WKWebView, adding support for the
3203         find bar to WebEditingTester will help us implement that functionality.
3204
3205         * WebEditingTester/AppDelegate.h:
3206         * WebEditingTester/AppDelegate.m:
3207         (-[WebEditingAppDelegate performTextFinderAction:]):
3208         * WebEditingTester/MainMenu.xib:
3209         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
3210
3211         * WebEditingTester/WK2WebDocumentController.m:
3212         (-[WK2WebDocumentController awakeFromNib]):
3213         (-[WK2WebDocumentController performTextFinderAction:]):
3214         (-[WK2WebDocumentController findBarView]):
3215         (-[WK2WebDocumentController setFindBarView:]):
3216         (-[WK2WebDocumentController isFindBarVisible]):
3217         (-[WK2WebDocumentController setFindBarVisible:]):
3218         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
3219         (-[WK2WebDocumentController layout]):
3220         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
3221         pointing at the WKWebView (currently nothing will work, but the bar will
3222         show up). Install and uninstall the bar as needed.
3223
3224         * WebEditingTester/WebDocument.xib:
3225         Don't use a full-size content view. There's no need, and it makes find
3226         bar layout harder.
3227
3228         * WebEditingTester/WebDocumentController.h:
3229         * WebEditingTester/WebDocumentController.m:
3230         (-[WebDocumentController performTextFinderAction:]):
3231
3232 2015-03-03  Sam Weinig  <sam@webkit.org>
3233
3234         [Content Extensions] Split parsing and compiling of content extensions into their own files
3235         https://bugs.webkit.org/show_bug.cgi?id=142259
3236
3237         Reviewed by Anders Carlsson.
3238
3239         Add basic unit test for the content filter compiler.
3240
3241         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3242         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
3243         (WebCore::ContentExtensions::operator<<):
3244         (TestWebKitAPI::ContentFilterTest::SetUp):
3245         (TestWebKitAPI::TEST_F):
3246
3247 2015-03-04  Matthew Mirman  <mmirman@apple.com>
3248
3249         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
3250         https://bugs.webkit.org/show_bug.cgi?id=142230
3251
3252         Reviewed by Csaba Osztrogonác.
3253
3254         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3255         (TestFactory):
3256         (TestFactory.getProduct): Added
3257         (TestFactory.__init__): moved downloader to getProduct
3258         (BuildAndTestFactory):        
3259         (BuildAndTestFactory.getProduct): Added
3260         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
3261         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
3262
3263 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
3264
3265         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
3266         https://bugs.webkit.org/show_bug.cgi?id=142225
3267
3268         Reviewed by Carlos Garcia Campos.
3269
3270         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3271         (testWebViewWebContextLifetime):
3272         (beforeAll):
3273
3274 2015-03-03  David Kilzer  <ddkilzer@apple.com>
3275
3276         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
3277         <http://webkit.org/b/142243>
3278
3279         Reviewed by Alexey Proskuryakov.
3280
3281         * WebKitTestRunner/TestController.cpp:
3282         (WTR::TestController::webProcessName):
3283         (WTR::TestController::networkProcessName):
3284         - Return the same process name on iOS and Mac because they both
3285           use the same process name for local engineering builds.
3286
3287 2015-03-03  David Kilzer  <ddkilzer@apple.com>
3288
3289         check-webkit-style: Add exception for FrameworkSoftLink.h header order
3290         <http://webkit.org/b/141872>
3291
3292         Reviewed by Alex Christensen.
3293
3294         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
3295         semi-colons in various places and fix whitespace.
3296         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
3297         constants.
3298         (_IncludeState.__init__): Add self._visited_soft_link_section
3299         boolean state variable.
3300         (_IncludeState.visited_soft_link_section): Getter for
3301         self._visited_soft_link_section.
3302         (_IncludeState.check_next_include_order): Update state machine
3303         for soft-link headers.  Add check that soft-link headers always
3304         appear last.
3305         (_classify_include): Add check for soft-link header type.
3306         (check_include_line): Return early if there is a soft-link
3307         header error.
3308
3309         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3310         (OrderOfIncludesTest.test_public_primary_header): Add tests for
3311         including soft-link headers.
3312         (OrderOfIncludesTest.test_classify_include): Add test for
3313         _SOFT_LINK_HEADER type.
3314
3315 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
3316
3317         build.webkit.org/dashboard: Don't repeatedly handle each test type
3318         https://bugs.webkit.org/show_bug.cgi?id=142211
3319
3320         Reviewed by Tim Horton and Matt Hanson.
3321
3322         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3323         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
3324         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
3325         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
3326         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
3327         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
3328         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
3329         Removed functions that build a link to test step results. The buildbot provides
3330         these links in JSON.
3331
3332         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3333         (BuildbotIteration): Put failing tests into an array, instead of named variables.
3334         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
3335         We can easily add them to the map as needed.
3336         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
3337         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
3338         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
3339         and then build a BuildbotTestResults object, which was strange.
3340         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
3341
3342         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3343         Corrected an unrelated assertion that was buggy, and kept firing.
3344
3345         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3346         (BuildbotTestResults):
3347         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
3348         (BuildbotTestResults.prototype._parseResults):
3349         (BuildbotTestResults.prototype.addFullLayoutTestResults):
3350         Moved the code for parsing JSON results for a single step here.
3351
3352         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3353         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
3354         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
3355         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
3356         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
3357         (BuildbotTesterQueueView.prototype.update): Deleted.
3358         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
3359         Updated for the new data structures. One behavior change is that we now display individual
3360         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
3361         test failures, 3 platform api test failures".
3362
3363 2015-03-03  Matthew Mirman  <mmirman@apple.com>
3364
3365         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
3366         https://bugs.webkit.org/show_bug.cgi?id=142094
3367
3368         Reviewed by Csaba Osztrogonác.
3369
3370         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
3371         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3372         (TestFactory):
3373         (TestFactory.__init__): Made running of JSC tests conditional.
3374         (TestAllButJSCFactory):
3375         (TestJSCFactory): Added.
3376         (TestJSCFactory.__init__):
3377         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
3378
3379 2015-03-03  David Kilzer  <ddkilzer@apple.com>
3380
3381         `build-webkit --help` is wrong about how to build for the iOS simulator
3382         <http://webkit.org/b/142223>
3383
3384         Reviewed by Csaba Osztrogonác.
3385
3386         * Scripts/build-webkit: Fix help.
3387
3388 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3389
3390         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
3391
3392         * gtk/jhbuild.modules:
3393
3394 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3395
3396         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
3397         https://bugs.webkit.org/show_bug.cgi?id=141508
3398
3399         Reviewed by Sergio Villar Senin.
3400
3401         Add a unit test to check that synchronous XHRs load even if the
3402         maximum connection limits are reached.
3403
3404         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3405         (testWebViewSyncRequestOnMaxConns):
3406         (serverCallback):
3407         (beforeAll):
3408         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
3409
3410 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
3411
3412         Update the name of ASan build step.
3413
3414         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3415
3416 2015-03-02  Jer Noble  <jer.noble@apple.com>
3417
3418         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
3419         https://bugs.webkit.org/show_bug.cgi?id=142121
3420
3421         Reviewed by Simon Fraser.
3422
3423         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
3424         that the initial and final screen rects for the web content are as expected.
3425
3426         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3427         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
3428         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
3429         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3430         (runJavaScriptAlert):
3431         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
3432         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
3433         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
3434         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
3435         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
3436         (TestWebKitAPI::TEST_F):
3437
3438 2015-03-01  David Kilzer  <ddkilzer@apple.com>
3439
3440         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
3441
3442         Follow-up fix for:
3443
3444         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
3445         <http://webkit.org/b/142145>
3446
3447         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3448         (-[LTRelayController _environmentVariables]): Fix think-o.
3449
3450 2015-03-01  David Kilzer  <ddkilzer@apple.com>
3451
3452         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
3453         <http://webkit.org/b/142145>
3454
3455         Reviewed by Simon Fraser.
3456
3457         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3458         (-[LTRelayController _environmentVariables]): Add.
3459         (-[LTRelayController launchApp]): Use -_environmentVariables.
3460
3461 2015-02-28  David Kilzer  <ddkilzer@apple.com>
3462
3463         [iOS] Stop running webkit-build-directory on every layout test
3464
3465         This was originally fixed by David Farler for Bug 135409 in
3466         r172602.
3467
3468         * Scripts/webkitpy/port/ios.py:
3469         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
3470         run webkit-build-directory every time it's called.
3471
3472 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3473
3474         W3C importer should use filesystem instead of shutil/host
3475         https://bugs.webkit.org/show_bug.cgi?id=142012
3476
3477         Reviewed by Bem Jones-Bey.
3478
3479         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
3480
3481         * Scripts/webkitpy/w3c/test_importer.py:
3482         (main):
3483         (TestImporter.do_import):
3484         (TestImporter.find_importable_tests):
3485         (TestImporter.import_tests):
3486         (TestImporter.remove_deleted_files):
3487         (TestImporter.write_import_log):
3488
3489 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3490
3491         W3C test importer should use filesystem to read and write files
3492         https://bugs.webkit.org/show_bug.cgi?id=142084
3493
3494         Reviewed by Bem Jones-Bey.
3495
3496         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
3497
3498         * Scripts/webkitpy/w3c/test_importer.py:
3499         (TestImporter.import_tests):
3500         (TestImporter.remove_deleted_files):
3501         (TestImporter.write_import_log):
3502
3503 2015-02-27  Sam Weinig  <sam@webkit.org>
3504
3505         Add WebKit2 SPI to create a DOM File object
3506         https://bugs.webkit.org/show_bug.cgi?id=142109
3507
3508         Reviewed by Tim Horton.
3509
3510         Add a test for WKBundleFileHandleRef.
3511
3512         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3513         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
3514         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3515         (TestWebKitAPI::didFinishLoadForFrame):
3516         (TestWebKitAPI::TEST):
3517         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
3518         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
3519         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
3520
3521 2015-02-27  Michael Saboff  <msaboff@apple.com>
3522
3523         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
3524         https://bugs.webkit.org/show_bug.cgi?id=142112
3525
3526         Reviewed by Filip Pizlo.
3527
3528         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
3529         <someDir> as the library path.
3530
3531         * Scripts/run-jsc-benchmarks:
3532
3533 2015-02-27  Alex Christensen  <achristensen@webkit.org>
3534
3535         [WinCairo] Unreviewed build fix.
3536
3537         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
3538         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
3539
3540 2015-02-27  Anders Carlsson  <andersca@apple.com>
3541
3542         Add infrastructure for handling website data in the network process
3543         https://bugs.webkit.org/show_bug.cgi?id=142092
3544
3545         Reviewed by Andreas Kling.
3546
3547         Add a menu item that will fetch all website data, delete the returned data records, and
3548         fetch all website data again so we can confirm that it's all empty.
3549
3550         * MiniBrowser/mac/WK2BrowserWindowController.m:
3551         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3552
3553 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
3554
3555         [Win] Remove remaining SafariTheme cruft
3556         https://bugs.webkit.org/show_bug.cgi?id=142075
3557
3558         Reviewed by Anders Carlsson.
3559
3560         Remove reference to SafariTheme-switching preference.
3561
3562         * DumpRenderTree/win/DumpRenderTree.cpp:
3563         (resetWebPreferencesToConsistentValues):
3564         (prepareConsistentTestingEnvironment):
3565
3566 2015-02-26  Doug Russell  <d_russell@apple.com>
3567
3568         AX: Expose caret browsing preference to accessibility API
3569         https://bugs.webkit.org/show_bug.cgi?id=141862
3570
3571         Reviewed by Chris Fleizach.
3572
3573         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
3574         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
3575
3576         * DumpRenderTree/AccessibilityUIElement.cpp:
3577         (setBoolAttributeValueCallback):
3578         (selectedTextMarkerRangeCallback):
3579         (resetSelectedTextMarkerRangeCallback):
3580         (AccessibilityUIElement::setBoolAttributeValue):
3581         (AccessibilityUIElement::selectedTextMarkerRange):
3582         (AccessibilityUIElement::resetSelectedTextMarkerRange):
3583         (AccessibilityUIElement::getJSClass):
3584         * DumpRenderTree/AccessibilityUIElement.h:
3585         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3586         (AccessibilityUIElement::setBoolAttributeValue):
3587         (AccessibilityUIElement::selectedTextMarkerRange):
3588         (AccessibilityUIElement::resetSelectedTextMarkerRange):
3589         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3590         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
3591         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
3592         (WTR::AccessibilityUIElement::setBoolAttributeValue):
3593         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3594         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3595         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3596         (WTR::AccessibilityUIElement::setBoolAttributeValue):
3597         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
3598         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
3599
3600 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
3601
3602         [Win] Remove WebKitExportGenerator project (and related)
3603         https://bugs.webkit.org/show_bug.cgi?id=142035
3604
3605         Reviewed by Dean Jackson.
3606
3607         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
3608         build log from WebKitExportGenerator.
3609
3610 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
3611
3612         [EFL] Bump EFL version to 1.13.0
3613         https://bugs.webkit.org/show_bug.cgi?id=141708
3614
3615         Reviewed by Gyuyoung Kim.
3616
3617         * efl/jhbuild.modules:
3618
3619 2015-02-26  Sam Weinig  <sam@webkit.org>
3620
3621         Check in missing WebEditingTester.xcconfig file.
3622
3623         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
3624
3625 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
3626
3627         [webkitpy] Remove skipped file related crufts
3628         https://bugs.webkit.org/show_bug.cgi?id=142046
3629
3630         Reviewed by Ryosuke Niwa.
3631
3632         * Scripts/webkitpy/port/base.py:
3633         (Port.skipped_layout_tests):
3634         (Port._tests_from_skipped_file_contents): Deleted.
3635         (Port): Deleted.
3636         (Port._expectations_from_skipped_files): Deleted.
3637         * Scripts/webkitpy/port/mac_unittest.py:
3638         (MacTest.test_default_timeout_ms):
3639         (MacTest): Deleted.
3640         (test_tests_from_skipped_file_contents): Deleted.
3641
3642 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
3643
3644         [Win] Unreviewed WinCairo build fix after r180653.
3645
3646         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
3647
3648         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3649         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3650         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
3651         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
3652         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
3653
3654 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
3655
3656         [Win] Use WEBCORE_EXPORT instead of Definition file
3657         https://bugs.webkit.org/show_bug.cgi?id=141734
3658
3659         Reviewed by Alex Christensen.
3660
3661         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3662         Use a precompiled header so we can define our export macros properly.
3663         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
3664         Visual studio automatic update stuff.
3665         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
3666         Set up Precompiled Header use for project..
3667         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
3668         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
3669         declarations for building DumpRenderTree as a client of
3670         WebCore/WebKit.
3671
3672 2015-02-25  Mark Lam  <mark.lam@apple.com>
3673
3674         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
3675         <https://webkit.org/b/141672>
3676
3677         Reviewed by Alexey Proskuryakov.
3678
3679         ASan does not like the fact that we memcpy the stack for GC scans.  So,
3680         we're working around this by using our own memcpy (asanUnsafeMemcpy)
3681         implementation that we can tell ASan to ignore.
3682
3683         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
3684         which isn't effective for working around this issue. 
3685
3686         * asan/webkit-asan-ignore.txt:
3687