Add my Samsung email address.
[WebKit-https.git] / Tools / ChangeLog
1 2013-12-16  Rob Buis  <rob.buis@samsung.com>
2
3         Add my Samsung email address.
4
5         Unreviewed.
6
7         * Scripts/webkitpy/common/config/contributors.json:
8
9 2013-12-16  Oliver Hunt  <oliver@apple.com>
10
11         Cache getters and custom accessors on the prototype chain
12         https://bugs.webkit.org/show_bug.cgi?id=125602
13
14         Reviewed by Michael Saboff.
15
16         Make sure bencher scripts also make noInline exist
17
18         * Scripts/bencher:
19
20 2013-12-16  Anders Carlsson  <andersca@apple.com>
21
22         Fix crash when trying to load a null HTML string
23         https://bugs.webkit.org/show_bug.cgi?id=125801
24
25         Reviewed by Dan Bernstein.
26
27         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
28         (TestWebKitAPI::TEST_F):
29         Update test results.
30
31 2013-12-16  Alex Christensen  <achristensen@webkit.org>
32
33         Fixed Win64 build on VS2013.
34         https://bugs.webkit.org/show_bug.cgi?id=125753
35
36         Reviewed by Brent Fulgham.
37
38         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
39         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
40         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
41         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
42         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
43         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
44         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
45         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
46         * win/record-memory/record-memory.vcxproj:
47         Added correct PlatformToolset for 64-bit builds.
48
49 2013-12-16  Simon Fraser  <simon.fraser@apple.com>
50
51         Add a menu option to MiniBrowser to enable UI-side compositing
52         https://bugs.webkit.org/show_bug.cgi?id=125793
53
54         Reviewed by Anders Carlsson.
55         
56         Make it possible to test UI-side compositing in MiniBrowser WK2 windows.
57
58         * MiniBrowser/mac/BrowserWindowController.h: Add optional protocol method
59         to toggle UI-side compositing.
60         * MiniBrowser/mac/MainMenu.xib: Add menu item to Debug menu.
61         * MiniBrowser/mac/WK2BrowserWindowController.m:
62         (-[WK2BrowserWindowController validateMenuItem:]):
63         (-[WK2BrowserWindowController isUISideCompositingEnabled]):
64         (-[WK2BrowserWindowController toggleUISideCompositing:]):
65         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
66         Adjust the window title to indicate whether the window is using UI-side compositing.
67
68 2013-12-16  Commit Queue  <commit-queue@webkit.org>
69
70         Unreviewed, rolling out r160645.
71         http://trac.webkit.org/changeset/160645
72         https://bugs.webkit.org/show_bug.cgi?id=125787
73
74         Change breaks test-webkitpy (Requested by bfulgham on
75         #webkit).
76
77         * Scripts/prepare-ChangeLog:
78         (get_selector_line_ranges_for_css):
79
80 2013-12-16  David Farler  <dfarler@apple.com>
81
82         [ASAN] WebKitLauncher: Include libasancrashreporter.dylib in DYLD_INSERT_LIBRARIES if it exists
83         https://bugs.webkit.org/show_bug.cgi?id=124610
84
85         Reviewed by Mark Rowe.
86
87         * WebKitLauncher/WebKitNightlyEnabler.m:
88         (enableWebKitNightlyBehaviour):
89         Add libasancrashreporter.dylib to DYLD_INSERT_LIBRARIES.
90         * WebKitLauncher/main.m:
91         (main):
92         Include both libasancrashreporter and the nightly enabler to
93         the list of libraries to insert.
94
95 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
96
97         Resolve inconsistant style warning caused by r160319.
98         https://bugs.webkit.org/show_bug.cgi?id=125772
99
100         Reviewed by Darin Adler.
101
102         * Scripts/webkitpy/style/checkers/cpp.py:
103         (check_for_extra_new_line_at_eof):
104         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
105         (CppStyleTest.test_newline_at_eof):
106         (CppStyleTest.test_extra_newlines_at_eof):
107
108 2013-12-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
109
110         Remove mock_drt.py: parse_options() - --test-shell and --pixel-tests=<path>
111         https://bugs.webkit.org/show_bug.cgi?id=125780
112
113         Reviewed by Darin Adler.
114
115         * Scripts/webkitpy/port/mock_drt.py:
116         (main):
117         (parse_options):
118         (MockDRT.write_test_output):
119         * Scripts/webkitpy/port/mock_drt_unittest.py:
120         (MockDRTTest.assertTest):
121         (MockDRTTest.test_reftest_mismatch):
122
123 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
124
125         prepare-Changelog treats CSS keyframes as mismatched parentheses.
126         https://bugs.webkit.org/show_bug.cgi?id=125435
127
128         Reviewed by Darin Adler.
129
130         * Scripts/prepare-ChangeLog:
131         (get_selector_line_ranges_for_css):
132
133 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
134
135         [ATK] Expose accessibility objects for more WAI-ARIA roles
136         https://bugs.webkit.org/show_bug.cgi?id=125596
137
138         Reviewed by Chris Fleizach.
139
140         Add mappings to DRT & WKTR for the newly exposed roles.
141
142         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
143         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
144
145 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
146
147         [ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM
148         https://bugs.webkit.org/show_bug.cgi?id=125594
149
150         Reviewed by Chris Fleizach.
151
152         Add mappings to DRT & WKTR for checkmenuitem role.
153
154         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
155         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
156
157 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
158
159         [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
160         https://bugs.webkit.org/show_bug.cgi?id=125587
161
162         Reviewed by Chris Fleizach.
163
164         Add mappings to DRT & WKTR for article roles.
165
166         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
167         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
168
169 2013-12-16  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
170
171         [FTL] Allow EFL to build FTL with the build-jsc script.
172         https://bugs.webkit.org/show_bug.cgi?id=125774
173
174         Reviewed by Zoltan Herczeg.
175
176         * Scripts/build-jsc:
177
178 2013-12-16  Krzysztof Czech  <k.czech@samsung.com>
179
180         Add myself as a committer
181
182         Unreviewed.
183
184         * Scripts/webkitpy/common/config/contributors.json:
185
186 2013-12-15  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
187
188         Refactor option handling in WebKitTestRunner.
189         https://bugs.webkit.org/show_bug.cgi?id=123185
190
191         Reviewed by Darin Adler.
192
193         Option handling is refactored (according to the FIXME) that allows
194         to automatically generate the help message.
195
196         * WebKitTestRunner/CMakeLists.txt:
197         * WebKitTestRunner/GNUmakefile.am:
198         * WebKitTestRunner/Options.cpp: Added.
199         (WTR::Options::Options):
200         (WTR::handleOptionTimeout):
201         (WTR::handleOptionNoTimeout):
202         (WTR::handleOptionNoTimeoutAtAll):
203         (WTR::handleOptionVerbose):
204         (WTR::handleOptionGcBetweenTests):
205         (WTR::handleOptionPixelTests):
206         (WTR::handleOptionPrintSupportedFeatures):
207         (WTR::handleOptionComplexText):
208         (WTR::handleOptionAcceleratedDrawing):
209         (WTR::handleOptionRemoteLayerTree):
210         (WTR::handleOptionUnmatched):
211         (WTR::OptionsHandler::OptionsHandler):
212         (WTR::Option::Option):
213         (WTR::Option::matches):
214         (WTR::OptionsHandler::parse):
215         (WTR::OptionsHandler::printHelp):
216         * WebKitTestRunner/Options.h: Added.
217         * WebKitTestRunner/TestController.cpp:
218         (WTR::TestController::initialize):
219         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
220
221 2013-12-15  Dan Bernstein  <mitz@apple.com>
222
223         32-bit build fix.
224
225         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
226         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
227
228 2013-12-14  Tim Horton  <timothy_horton@apple.com>
229
230         stylebot should warn when FeatureDefines differ
231         https://bugs.webkit.org/show_bug.cgi?id=125748
232
233         Reviewed by Dan Bernstein.
234
235         Add a stylebot checker that ensures that FeatureDefines.xcconfig files
236         are always exactly equal (and warns people adding new FeatureDefines.xcconfig files,
237         an unlikely occurrance, to add them to the list).
238
239         It's a bit nontraditional for stylebot because it will warn on existing errors in the tree,
240         but that is the most straightforward way to implement it (and we're at zero diffs right now).
241
242         * Scripts/webkitpy/style/checker.py:
243         (_all_categories):
244         (FileType):
245         (CheckerDispatcher._file_type):
246         (CheckerDispatcher._create_checker):
247         * Scripts/webkitpy/style/checkers/featuredefines.py: Added.
248         (FeatureDefinesChecker):
249         (FeatureDefinesChecker.__init__):
250         (FeatureDefinesChecker.check):
251
252 2013-12-13  Sam Weinig  <sam@webkit.org>
253
254         Fix API tests.
255
256         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
257         (TestWebKitAPI::TEST_F):
258
259 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
260
261         [Win] Remove Pre-VS2013 support code.
262         https://bugs.webkit.org/show_bug.cgi?id=125693
263
264         Reviewed by Darin Adler.
265
266         * DumpRenderTree/cg/ImageDiffCG.cpp: Remove strtof stub now supplied by
267         the math library.
268         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
269
270 2013-12-13  Lucas Forschler  <lforschler@apple.com>
271
272         Update Webkit bots.
273         
274         Unreviewed.
275         
276         * BuildSlaveSupport/build.webkit.org-config/config.json:
277
278 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
279
280         [Win] Unreviewed build fix after r160548
281
282         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Specify
283         we are using vs12_xp target for Makefile-based projects.
284
285 2013-12-13  Lucas Forschler  <lforschler@apple.com>
286
287         Update Apple Webkit Bots
288         
289         Unreviewed.
290
291         * BuildSlaveSupport/build.webkit.org-config/config.json:
292
293 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
294
295         Unreviewed build fix after r160548.
296
297         * Scripts/webkitdirs.pm:
298         (setupCygwinEnv): VCExpress.exe is now called WDExpress.exe.
299
300 2013-12-13  Lucas Forschler  <lforschler@apple.com>
301
302         Update Apple bots.
303         
304         Unreviewed.
305
306         * BuildSlaveSupport/build.webkit.org-config/config.json:
307
308 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
309
310         [Win] Switch WebKit solution to Visual Studio 2013
311         https://bugs.webkit.org/show_bug.cgi?id=125192
312
313         Reviewed by Anders Carlsson.
314
315         Project files must reference vs12_xp for 32-bit builds. 
316
317         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
318         Update for VS2013
319         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
320         Ditto
321         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
322         Ditto
323         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
324         Ditto
325         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
326         Ditto
327         * Scripts/webkitdirs.pm:
328         (visualStudioInstallDir): Specify VS2013
329         (visualStudioVersion): Ditto.
330         (setupAppleWinEnv): Use VS2013 in messages
331         (setupCygwinEnv): Ditto
332         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
333         Update for VS2013
334         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
335         Ditto
336         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
337         Ditto
338         * win/record-memory/record-memory.vcxproj:
339         Ditto
340
341 2013-12-11  Martin Robinson  <mrobinson@igalia.com> and Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
342
343         Adding a .ycm_extra_conf file for webkitGtk
344         https://bugs.webkit.org/show_bug.cgi?id=119618
345
346         Reviewed by Gustavo Noronha Silva.
347
348         Added a YouCompleteMe flag discovery script for Vim and the GTK+ port. The script
349         read the GTK+ build files to determine dynamically what flags to compile a source
350         file with. This allows Vim to provide auto-complete for C++/C language. See
351         https://github.com/Valloric/YouCompleteMe for how to use this file.
352
353         * gtk/common.py:
354         (get_build_path): Added a fatal argument to build_path to avoid crashing YCM on failure.
355         * gtk/ycm_extra_conf.py: Added.
356
357 2013-12-12  Tim Horton  <timothy_horton@apple.com>
358
359         [wk2] Handle pinch-to-zoom gesture
360         https://bugs.webkit.org/show_bug.cgi?id=125604
361
362         Reviewed by Simon Fraser.
363
364         * MiniBrowser/mac/WK2BrowserWindowController.m:
365         (-[WK2BrowserWindowController awakeFromNib]):
366         Enable handling of the magnification gesture in Minibrowser WebKit2 windows.
367
368 2013-12-12  Eunmi Lee  <eunmi15.lee@samsung.com>
369
370         Unreviewed. Add myself as a committer.
371
372         * Scripts/webkitpy/common/config/contributors.json:
373
374 2013-12-12  Lucas Forschler  <lforschler@apple.com>
375
376         Update hardware for Apple bots.
377         
378         Unreviewed.
379
380         * BuildSlaveSupport/build.webkit.org-config/config.json:
381
382 2013-12-12  Lucas Forschler  <lforschler@apple.com>
383
384         Remove unused Apple Bots.
385         
386         Unreviewed.
387
388         * BuildSlaveSupport/build.webkit.org-config/config.json:
389
390 2013-12-12  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
391
392         Unreviewed. Add myself as a committer.
393
394         * Scripts/webkitpy/common/config/contributors.json:
395
396 2013-12-12  Joseph Pecoraro  <pecoraro@apple.com>
397
398         Test new JSContext name APIs
399         https://bugs.webkit.org/show_bug.cgi?id=125607
400
401         Reviewed by Darin Adler.
402
403         * Scripts/run-javascriptcore-tests:
404         Remove trailing whitespace.
405
406 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
407
408         [Autotools] Prepend the WebCore layer archives' names with 'lib'
409         https://bugs.webkit.org/show_bug.cgi?id=125627
410
411         Reviewed by Martin Robinson.
412
413         * TestWebKitAPI/GNUmakefile.am: Libtool can complain about the WebCore layer archives not being prepended
414         with 'lib' when they are used during linking, so the prefix is now added to avoid such issues.
415
416 2013-12-12  Commit Queue  <commit-queue@webkit.org>
417
418         Unreviewed, rolling out r160446.
419         http://trac.webkit.org/changeset/160446
420         https://bugs.webkit.org/show_bug.cgi?id=125630
421
422         The upower-glib-based implementation is using API that was
423         recently removed (Requested by zdobersek1 on #webkit).
424
425         * Scripts/webkitperl/FeatureList.pm:
426
427 2013-12-12  Commit Queue  <commit-queue@webkit.org>
428
429         Unreviewed, rolling out r160417.
430         http://trac.webkit.org/changeset/160417
431         https://bugs.webkit.org/show_bug.cgi?id=125629
432
433         The patch is causing crashes (Requested by zdobersek1 on
434         #webkit).
435
436         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
437         (axObjectEventListener):
438         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
439
440 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
441
442         Use of ar T option not supported by older binutils
443         https://bugs.webkit.org/show_bug.cgi?id=118732
444
445         Reviewed by Gustavo Noronha Silva.
446
447         * TestWebKitAPI/GNUmakefile.am: To support non-thin archives when generating the WebCoreLayer archive,
448         switch to using the AR_FLAGS variable (which can be overridden) for providing the ar flags for the
449         new archive. Non-thin archives also pose the problem as their members are only noted by the basename
450         of the member's object file, and not the full path to it. To work around that, all the object files
451         under the build directory are listed by their relative paths. The members of various archives then have
452         the basenames of their paths grepped against that list, with the found path correlating to the member
453         finally added as the new member of the WebCoreLayer archive.
454
455 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
456
457         check-webkit-style shouldn't check spacing in #if preprocessor lines
458         https://bugs.webkit.org/show_bug.cgi?id=125534
459
460         Reviewed by Ryosuke Niwa.
461
462         Preprocessor lines that start with #if shouldn't have to adhere to
463         the same spacing requirements that regular code does
464
465         * Scripts/webkitpy/style/checkers/cpp.py:
466         (check_spacing):
467         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
468         (CppStyleTest.test_spacing_for_binary_ops):
469         (WebKitStyleTest.test_line_breaking):
470
471 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
472
473         check-webkit-style can't determine if a comma is part of an initialization list
474         https://bugs.webkit.org/show_bug.cgi?id=125537
475
476         Reviewed by Darin Adler.
477
478         The original check to make sure that initialization list lines start with
479         a comma didn't distinguish between commas that belong to the initialization
480         list and commas that are part of function calls. Because we don't want to
481         match parentheses with regular expressions, we should weaken this check to
482         only check for commas at the end of initialization list lines.
483
484         * Scripts/webkitpy/style/checkers/cpp.py:
485         (check_member_initialization_list):
486         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
487         (WebKitStyleTest.test_member_initialization_list):
488
489 2013-12-11  Tim Horton  <timothy_horton@apple.com>
490
491         Make it possible to compare layout test results between various configurations of WebKit
492         https://bugs.webkit.org/show_bug.cgi?id=125212
493         <rdar://problem/15199108>
494
495         Reviewed by Darin Adler.
496
497         * Scripts/compare-webkit-configurations: Added.
498         Add a script that allows comparison between the "normal" WebKit configuration
499         used for testing and a different configuration (e.g. with accelerated drawing
500         turned on, with the remote layer tree enabled, or WebKit1 vs WebKit2), like so:
501
502         compare-webkit-configurations -2 --comparison=accelerated-drawing compositing/background-color
503
504         This script runs the tests once in the default configuration, ignoring
505         all test expectations, writing the results out to a temporary directory.
506
507         It then runs the tests again in the modified configuration, against the
508         just-written temporary results.
509
510         Ref tests are treated as pixel tests, with their pixel output dumped to disk.
511
512         * DumpRenderTree/mac/DumpRenderTree.mm:
513         (resetWebPreferencesToConsistentValues):
514         (initializeGlobalsFromCommandLineOptions):
515         Enable accelerated drawing if requested.
516
517         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
518         (parse_args):
519         Add --accelerated-drawing and --remote-layer-tree feature switches, which
520         are forwarded on to the test drivers.
521         Move those two and --complex-text into their own "feature switches" section.
522         Drive-by change "Mac OS X" to "OS X".
523         Add --treat-ref-tests-as-pixel-tests option, which treats ref tests
524         as traditional pixel tests (with PNGs dumped on disk), and
525         ignores e.g. -expected.html files.
526
527         * Scripts/webkitpy/port/base.py:
528         (Port.reference_files):
529         Pretend that there are no ref tests.
530         Since is_reference_html_file is intact, our mechanism to ignore
531         the expected files will continue working in this case.
532
533         * Scripts/webkitpy/port/driver.py:
534         (Driver.cmd_line):
535         Forward --accelerated-drawing and --remote-layer-tree to DRT/WKTR.
536
537         * WebKitTestRunner/TestController.cpp:
538         (WTR::TestController::TestController):
539         (WTR::TestController::initialize):
540         (WTR::TestController::resetPreferencesToConsistentValues):
541         * WebKitTestRunner/TestController.h:
542         (WTR::TestController::shouldUseRemoteLayerTree):
543         * WebKitTestRunner/TestInvocation.cpp:
544         (WTR::updateThreadedScrollingForCurrentTest):
545         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
546         (WTR::PlatformWebView::PlatformWebView):
547         Parse and implement the three feature switches.
548
549 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
550
551         [ATK] Expose accessibility objects WAI-ARIA landmark roles
552         https://bugs.webkit.org/show_bug.cgi?id=125584
553
554         Reviewed by Chris Fleizach.
555
556         Add mappings to DRT & WKTR for landmark roles.
557
558         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
559         (AccessibilityUIElement::role):
560         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
561         (WTR::AccessibilityUIElement::role):
562         * gtk/jhbuild.modules:
563
564 2013-12-11  Alejandro G. Castro  <alex@igalia.com>
565
566         [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py
567         https://bugs.webkit.org/show_bug.cgi?id=125441
568
569         Reviewed by Martin Robinson.
570
571         Just avoid the double quotations when building the parameter
572         because some versions of valgrind are not handling it correctly.
573
574         * Scripts/webkitpy/port/gtk.py:
575         (GtkPort.setup_environ_for_server):
576
577 2013-12-11  Zan Dobersek  <zdobersek@igalia.com>
578
579         [GTK] Enable Battery Status API
580         https://bugs.webkit.org/show_bug.cgi?id=125453
581
582         Reviewed by Martin Robinson.
583
584         * Scripts/webkitperl/FeatureList.pm: Enable the Battery Status API feature for the GTK port.
585
586 2013-12-11  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
587
588         [GTK][WK2] Add the WebKitBatteryProvider class
589         https://bugs.webkit.org/show_bug.cgi?id=115720
590
591         Reviewed by Martin Robinson.
592
593         * gtk/generate-gtkdoc:
594         (get_webkit2_options): Ignore the WebKitBatteryProvider source files when generating the documentation.
595
596 2013-12-11  Mark Rowe  <mrowe@apple.com>
597
598         <https://webkit.org/b/125563> Remove the DumpRenderTree Perl Support module
599
600         Now that old-run-webkit-tests is not used on OS X it's not worth the time and effort
601         to build and maintain this custom Perl module.
602
603         Reviewed by Anders Carlsson.
604
605         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
606         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Removed.
607         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
608         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
609         * DumpRenderTree/mac/PerlSupport/Makefile: Removed.
610         * Scripts/old-run-webkit-tests: Update a comment that referred to DumpRenderTreeSupport as a reason to
611         build DumpRenderTree.
612         (dumpToolDidCrash): Stop importing and using the module.
613         * Scripts/webkitpy/port/base.py:
614         (Port._build_driver): Update a comment in the same manner as in old-run-webkit-tests.
615
616 2013-12-11  Brendan Long  <b.long@cablelabs.com>
617
618         [GTK] Add "enable-mediasource" property to WebKitWebSettings
619         https://bugs.webkit.org/show_bug.cgi?id=125566
620
621         Reviewed by Philippe Normand.
622
623         * DumpRenderTree/gtk/DumpRenderTree.cpp:
624         (resetDefaultsToConsistentValues): Turn MediaSource on by default for easier testing.
625         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
626         (TestRunner::overridePreference): Allow overriding WebKitMediaSourceEnabled.
627
628 2013-12-11  Dan Bernstein  <mitz@apple.com>
629
630         [Mac] Observe the activeURL property to keep the MiniBrowser URL field up to date
631         https://bugs.webkit.org/show_bug.cgi?id=125579
632
633         Reviewed by Anders Carlsson.
634
635         * MiniBrowser/mac/WK2BrowserWindowController.m:
636         (-[WK2BrowserWindowController dealloc]): Stop observing the activeURL property.
637         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): When the
638         activeURL property changes, update the URL field with its value.
639         (-[WK2BrowserWindowController awakeFromNib]): Start observing the activeURL property.
640         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]): Just log.
641         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
642         Ditto.
643         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]):
644         Ditto.
645         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
646         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
647
648 2013-12-11  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
649
650         Fixed test-wepkitpy logging for buildslaves
651         https://bugs.webkit.org/show_bug.cgi?id=125445
652
653         Reviewed by Csaba Osztrogonác.
654
655         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
656         (RunPythonTests):
657
658 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
659
660         Programmatically-inserted children lack accessibility events
661         https://bugs.webkit.org/show_bug.cgi?id=100275
662
663         Reviewed by Chris Fleizach.
664
665         Update DRT and WebKitTestRunner to handle the children-changed
666         signal properly, considering the detail and optional parameters.
667
668         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
669         (axObjectEventListener):
670         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
671
672 2013-12-03  Mark Rowe  <mrowe@apple.com>
673
674         <https://webkit.org/b/125139> Modernize the WebKit API headers
675         <rdar://problem/15540175>
676
677         Reviewed by Anders Carlsson.
678
679         * DumpRenderTree/mac/TestRunnerMac.mm:
680         (TestRunner::setCacheModel): Cast to the enum type.
681
682 2013-12-10  Filip Pizlo  <fpizlo@apple.com>
683
684         Get rid of forward exit on DoubleAsInt32
685         https://bugs.webkit.org/show_bug.cgi?id=125552
686
687         Reviewed by Oliver Hunt.
688         
689         Add some support for testing the generic (non-X86) paths on X86 by disabling
690         architecture-specific optimizations (ASO's).
691
692         * Scripts/run-javascriptcore-tests:
693         * Scripts/run-jsc-stress-tests:
694
695 2013-12-10  Ryuan Choi  <ryuan.choi@samsung.com>
696
697         Unreviewed EFL build fix attempt
698
699         * TestWebKitAPI/CMakeLists.txt: Added ${WEBKIT2_DIR}/Platform/CoreIPC to include lists.
700         * WebKitTestRunner/CMakeLists.txt: Ditto.
701
702 2013-12-10  Anders Carlsson  <andersca@apple.com>
703
704         Add a HashMap constructor that takes an initializer list
705         https://bugs.webkit.org/show_bug.cgi?id=125551
706
707         Reviewed by Dan Bernstein.
708
709         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
710         (TestWebKitAPI::TEST):
711
712 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
713
714         Use std::array when computing MD5 checksum
715         https://bugs.webkit.org/show_bug.cgi?id=125509
716
717         Reviewed by Anders Carlsson.
718
719         Use MD5::Digest type and MD5::hashSize when computing MD5 checksum.
720
721         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
722         (computeMD5HashStringForBitmapContext):
723         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
724         (computeMD5HashStringForBitmapContext):
725         * TestWebKitAPI/Tests/WTF/MD5.cpp:
726         (TestWebKitAPI::expectMD5):
727         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
728         (WTR::computeMD5HashStringForCairoSurface):
729         * WebKitTestRunner/cg/TestInvocationCG.cpp:
730         (WTR::computeMD5HashStringForContext):
731
732 2013-12-10  Mario Sanchez Prada  <mario.prada@samsung.com>
733
734         [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
735         https://bugs.webkit.org/show_bug.cgi?id=125522
736
737         Reviewed by Chris Fleizach.
738
739         Update strings representing ATK_ROLE_SEPARATOR for layout tests.
740
741         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
742         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
743
744 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
745
746         Add --makeargs option to build-jsc
747         https://bugs.webkit.org/show_bug.cgi?id=125344
748
749         Reviewed by Filip Pizlo.
750
751         * Scripts/build-jsc: Handle and pass makefile arguments in jsc build.
752
753 2013-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
754
755         AX: [ATK] Convert the get_text atktest.c unit tests to layout tests
756         https://bugs.webkit.org/show_bug.cgi?id=125497
757
758         Reviewed by Mario Sanchez Prada.
759
760         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
761         (AccessibilityUIElement::stringForRange): Implemented.
762         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
763         (WTR::AccessibilityUIElement::stringForRange): Implemented.
764
765 2013-12-10  Martin Robinson  <mrobinson@igalia.com>
766
767         Various fixes for the CMake GTK+ build
768
769         Reviewed by Gustavo Noronha.
770
771         * MiniBrowser/gtk/CMakeLists.txt: Update source list and correct the name of BrowserMarshal.h.
772         * TestWebKitAPI/PlatformGTK.cmake: Add GTK+ libraries to the test program. They're required.
773
774 2013-12-10  László Langó  <lango@inf.u-szeged.hu>
775
776         --cloop option does not work in Tools/Scripts/build-jsc.
777         https://bugs.webkit.org/show_bug.cgi?id=125214
778
779         Reviewed by Csaba Osztrogonác.
780
781         * Scripts/build-jsc:
782
783 2013-12-10  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
784
785         Merge mark_for_landing and mark_for_commit_queue into one argument
786         https://bugs.webkit.org/show_bug.cgi?id=125448
787
788         Reviewed by Ryosuke Niwa.
789
790         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
791         (CommitQueueFlag):
792         (Bugzilla._commit_queue_flag):
793         (Bugzilla._fill_attachment_form):
794         (Bugzilla.add_patch_to_bug):
795         (Bugzilla.create_bug):
796         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
797         (test_commit_queue_flag.assert_commit_queue_flag):
798         (test_commit_queue_flag):
799
800 2013-12-09  Tim Horton  <timothy_horton@apple.com>
801
802         Remove dead extract_reference_link.py (and the reftests module)
803         https://bugs.webkit.org/show_bug.cgi?id=125116
804
805         Reviewed by Ryosuke Niwa.
806
807         This code doesn't seem to have ever been used.
808
809         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Removed.
810         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Removed.
811         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Removed.
812
813 2013-12-09  Mario Sanchez Prada  <mario.prada@samsung.com>
814
815         [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
816         https://bugs.webkit.org/show_bug.cgi?id=125456
817
818         Reviewed by Chris Fleizach.
819
820         Return 'AXSection' for section roles instead of 'AXDiv'.
821
822         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
823         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
824
825 2013-12-09  Brian J. Burg  <burg@cs.washington.edu>
826
827         check-webkit-style should check for extra newlines at EOF
828         https://bugs.webkit.org/show_bug.cgi?id=125424
829
830         Reviewed by Darin Adler.
831
832         Report a style violation if extraneous newlines are added
833         to the end of a C++ file. There should only be one newline at EOF.
834
835         * Scripts/webkitpy/style/checkers/cpp.py:
836         (check_for_missing_new_line_at_eof): Renamed from check_for_new_line_at_eof.
837         (check_for_extra_new_line_at_eof): Added.
838         (_process_lines): Added new check and renamed existing EOF check.
839         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
840         (CppStyleTest.test_extra_newlines_at_eof): Added.
841         (CppStyleTest.test_extra_newlines_at_eof.do_test): Added.
842
843 2013-12-09  Laszlo Vidacs  <lac@inf.u-szeged.hu>
844
845         check-webkit-style: ternary operator in macro call identified as initialization list
846         https://bugs.webkit.org/show_bug.cgi?id=125443
847
848         Reviewed by Ryosuke Niwa.
849
850         Do not match initialization list when questionmark is placed before :
851
852         * Scripts/webkitpy/style/checkers/cpp.py:
853         (check_member_initialization_list):
854
855 2013-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
856
857         AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests
858         https://bugs.webkit.org/show_bug.cgi?id=125451
859
860         Reviewed by Mario Sanchez Prada.
861
862         Create the needed callbacks for DRT and WKTR.
863
864         * DumpRenderTree/AccessibilityUIElement.cpp:
865         (characterAtOffsetCallback): added
866         (wordAtOffsetCallback): added
867         (lineAtOffsetCallback): added
868         (sentenceAtOffsetCallback): added
869         (AccessibilityUIElement::getJSClass):
870         * DumpRenderTree/AccessibilityUIElement.h:
871         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
872         (stringAtOffset): added
873         (AccessibilityUIElement::characterAtOffset): added
874         (AccessibilityUIElement::wordAtOffset): added
875         (AccessibilityUIElement::lineAtOffset): added
876         (AccessibilityUIElement::sentenceAtOffset): added
877         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
878         (WTR::AccessibilityUIElement::characterAtOffset): added
879         (WTR::AccessibilityUIElement::wordAtOffset): added
880         (WTR::AccessibilityUIElement::lineAtOffset): added
881         (WTR::AccessibilityUIElement::sentenceAtOffset): added
882         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
883         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
884         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
885         (WTR::stringAtOffset): added
886         (WTR::AccessibilityUIElement::characterAtOffset): added
887         (WTR::AccessibilityUIElement::wordAtOffset): added
888         (WTR::AccessibilityUIElement::lineAtOffset): added
889         (WTR::AccessibilityUIElement::sentenceAtOffset): added
890
891 2013-12-08  Sam Weinig  <sam@webkit.org>
892
893         32-bit MiniBrowser doesn't build
894         https://bugs.webkit.org/show_bug.cgi?id=125420
895
896         Reviewed by Dan Bernstein.
897
898         * MiniBrowser/mac/AppDelegate.h:
899         * MiniBrowser/mac/AppDelegate.m:
900         (-[BrowserAppDelegate init]):
901         (-[BrowserAppDelegate applicationWillTerminate:]):
902
903 2013-12-08  Brian Holt  <brian.holt@samsung.com>
904
905         [WK2] Add ENABLE_NETWORK_PROCESS flag
906         https://bugs.webkit.org/show_bug.cgi?id=125421
907
908         Add support to build with the Network Process enabled.
909
910         Reviewed by Martin Robinson.
911
912         * Scripts/webkitperl/FeatureList.pm:
913
914 2013-12-07  Filip Pizlo  <fpizlo@apple.com>
915
916         Fold typedArray.length if typedArray is constant
917         https://bugs.webkit.org/show_bug.cgi?id=125252
918
919         Reviewed by Sam Weinig.
920         
921         Add Source/JavaScriptCore/tests/stress to the set of JS tests. This is where you
922         should put tests that run just like JSRegress but don't run as part of LayoutTests.
923         Currently I'm using it for tests that require some surgical support from jsc.cpp.
924
925         * Scripts/run-javascriptcore-tests:
926
927 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
928
929         [gdb] Update printers for WTF::CString, JSC::JSString
930         https://bugs.webkit.org/show_bug.cgi?id=124600
931
932         Reviewed by Gustavo Noronha Silva.
933
934         Update the two printers after they fell behind the changes in implementation.
935
936         * gdb/webkit.py:
937         (WTFCStringPrinter.to_string):
938         (JSCJSStringPrinter.to_string):
939
940 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
941
942         [webkitpy] Add a WestonDriver unit test
943         https://bugs.webkit.org/show_bug.cgi?id=125408
944
945         Reviewed by Gustavo Noronha Silva.
946
947         Add a webkitpy unit test for the Weston driver.
948
949         * Scripts/webkitpy/port/westondriver_unittest.py: Added.
950         (WestonDriverTest):
951         (WestonDriverTest.make_driver): Sets up a new WestonDriver instance for testing purposes.
952         (WestonDriverTest.test_start): Check that the Weston compositor is launched properly and that
953         the server environment contains proper WAYLAND and GDK_BACKEND entries.
954         (WestonDriverTest.test_stop): Check that the Weston compositor is terminated properly and that
955         the driver cleans up the temporary directory.
956         (WestonDriverTest.test_stop.FakeWestonProcess): A helper class that logs the expected termination.
957         (WestonDriverTest.test_stop.FakeWestonProcess.terminate):
958
959 2013-12-08  Brendan Long  <b.long@cablelabs.com>
960
961         [Gtk] install-dependencies doesn't install libgtk-3-dev
962         https://bugs.webkit.org/show_bug.cgi?id=125320
963
964         Reviewed by Gustavo Noronha Silva.
965
966         * gtk/install-dependencies: Add libgtk-3-dev, libsoup2.4 and subversion
967
968 2013-12-07  Sam Weinig  <sam@webkit.org>
969
970         [Cocoa] Convert a few more parts of MiniBrowser over to the Objective-C API
971         https://bugs.webkit.org/show_bug.cgi?id=125401
972
973         Reviewed by Dan Bernstein.
974
975         * MiniBrowser/mac/WK2BrowserWindowController.m:
976         (-[WK2BrowserWindowController fetch:]):
977         (-[WK2BrowserWindowController reload:]):
978         (-[WK2BrowserWindowController goBack:]):
979         (-[WK2BrowserWindowController goForward:]):
980         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
981         (-[WK2BrowserWindowController currentZoomFactor]):
982         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
983         (-[WK2BrowserWindowController zoomIn:]):
984         (-[WK2BrowserWindowController zoomOut:]):
985         (-[WK2BrowserWindowController canResetZoom]):
986         (-[WK2BrowserWindowController resetZoom:]):
987         (-[WK2BrowserWindowController toggleZoomMode:]):
988         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
989
990 2013-12-07  Sam Weinig  <sam@webkit.org>
991
992         Convert MiniBrowser to use WKProcessGroup and WKBrowsingContextGroup
993         https://bugs.webkit.org/show_bug.cgi?id=125400
994
995         Reviewed by Dan Bernstein.
996
997         * MiniBrowser/mac/AppDelegate.h:
998         * MiniBrowser/mac/AppDelegate.m:
999         * MiniBrowser/mac/WK2BrowserWindowController.h:
1000         * MiniBrowser/mac/WK2BrowserWindowController.m:
1001         (-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
1002         (-[WK2BrowserWindowController dealloc]):
1003         (createNewPage):
1004         (-[WK2BrowserWindowController awakeFromNib]):
1005         (-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
1006         (-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
1007         (-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
1008         (-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):
1009         Replace global WKContextRef and WKPageGroupRef with WKProcessGroup and WKBrowsingContextGroup. Also
1010         replace context based WKContextHistoryClient with WKBrowsingContextController based WKBrowsingContextHistoryDelegate
1011
1012 2013-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1013
1014         [GTK] Run each gtest subtest separately instead of in one go
1015         https://bugs.webkit.org/show_bug.cgi?id=125386
1016
1017         Reviewed by Martin Robinson.
1018
1019         This is what other ports are doing (except they build each test as a separate binary)
1020         and will help with the timeouts we sometimes hit because it applies to the full test
1021         run.
1022
1023         * Scripts/run-gtk-tests:
1024         (TestRunner._get_tests_from_google_test_suite): get a list of available sub-tests.
1025         (TestRunner._run_google_test): run a single subtest from a gtest binary.
1026         (TestRunner._run_google_test_suite): call the binary once per subtest.
1027
1028 2013-12-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1029
1030         Move PrettyPatch related code to prettypatch.py
1031         https://bugs.webkit.org/show_bug.cgi?id=124937
1032
1033         Reviewed by Ryosuke Niwa.
1034
1035         This code seems to have a better place here than in Port, since PrettyPatch already knows
1036         pretty_patch_path, and this also unifies the usage of PrettyPatch
1037
1038         * Scripts/webkitpy/common/prettypatch.py:
1039         (PrettyPatch.__init__):
1040         (PrettyPatch.pretty_diff):
1041         (PrettyPatch):
1042         (PrettyPatch.pretty_patch_available):
1043         (PrettyPatch.check_pretty_patch):
1044         (PrettyPatch.pretty_patch_text):
1045         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1046         (TestResultWriter.create_text_diff_and_write_result):
1047         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1048         (summarize_results):
1049         * Scripts/webkitpy/port/base.py:
1050         (Port.__init__):
1051         (Port.wdiff_available):
1052         (Port.check_image_diff):
1053         (Port.wdiff_text):
1054         * Scripts/webkitpy/port/base_unittest.py:
1055         (PortTest.test_pretty_patch_os_error):
1056         (PortTest.test_pretty_patch_script_error):
1057
1058 2013-12-06  Dan Bernstein  <mitz@apple.com>
1059
1060         [Mac] MiniBrowser Debug builds are compiled with -Os
1061         https://bugs.webkit.org/show_bug.cgi?id=125376
1062
1063         Reviewed by Tim Horton.
1064
1065         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Set GCC_OPTIMIZATION_LEVEL to 0 for
1066         the Debug configuration at the project level.
1067
1068 2013-12-06  Jer Noble  <jer.noble@apple.com>
1069
1070         [MSE] Add a runtime-setting for the MediaSource constructor.
1071         https://bugs.webkit.org/show_bug.cgi?id=125336
1072
1073         Reviewed by Eric Carlson.
1074
1075         Enable MediaSource in DRT and WKTR.
1076
1077         * DumpRenderTree/mac/DumpRenderTree.mm:
1078         (resetWebPreferencesToConsistentValues):
1079         * WebKitTestRunner/TestController.cpp:
1080         (WTR::TestController::resetPreferencesToConsistentValues):
1081
1082 2013-12-06  Jer Noble  <jer.noble@apple.com>
1083
1084         Strip out extraneous logging from AppleGVA in media tests.
1085         https://bugs.webkit.org/show_bug.cgi?id=125357
1086
1087         Reviewed by Simon Fraser.
1088
1089         Add a mechanism for stripping out abritrary regular expressions from test input and output.
1090
1091         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1092         (SingleTestRunner._run_compare_test): Strip out logging
1093         * Scripts/webkitpy/port/base.py:
1094         (Port.logging_patterns_to_strip): Return an empty list by default.
1095         * Scripts/webkitpy/port/driver.py:
1096         (DriverOutput.strip_patterns): Apply the port specific patterns to the text.
1097         * Scripts/webkitpy/port/mac.py:
1098         (MacPort.logging_patterns_to_strip): Return a complete list.
1099
1100 2013-12-06  Dean Jackson  <dino@apple.com>
1101
1102         Updating ANGLE should point to instructions
1103         https://bugs.webkit.org/show_bug.cgi?id=125361
1104
1105         Reviewed by Eric Carlson.
1106
1107         Point to https://trac.webkit.org/wiki/UpdatingANGLE when
1108         someone wants to patch ANGLE.
1109
1110         * Scripts/webkitpy/common/config/watchlist:
1111
1112 2013-12-06  Dan Bernstein  <mitz@apple.com>
1113
1114         [Mac] Transition MiniBrowser to the Cocoa API: load delegate
1115         https://bugs.webkit.org/show_bug.cgi?id=125334
1116
1117         Reviewed by Darin Adler.
1118
1119         * MiniBrowser/mac/WK2BrowserWindowController.m:
1120         (-[WK2BrowserWindowController dealloc]): Nil out the load delegate and stop observing the
1121         title property.
1122         (-[WK2BrowserWindowController isPaginated]): Changed to use Cocoa SPI.
1123         (-[WK2BrowserWindowController togglePaginationMode:]): Ditto.
1124         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): Update the
1125         window title with the title property changes.
1126         (-[WK2BrowserWindowController awakeFromNib]): Start observing the title property. Changed to
1127         set the load delegate instead of the load client.
1128         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Changed to use Cocoa types.
1129         (-[WK2BrowserWindowController updateProvisionalURL]): Removed frame parameter.
1130         (-[WK2BrowserWindowController updateCommittedURL]): Ditto.
1131         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
1132         Implemented this load delegate method.
1133         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
1134         Ditto.
1135         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]): Ditto.
1136         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
1137         (-[WK2BrowserWindowController browsingContextControllerDidFinishLoad:]): Ditto.
1138         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
1139         (-[WK2BrowserWindowController browsingContextControllerDidChangeBackForwardList:addedItem:removedItems:]):
1140         Ditto.
1141         (-[WK2BrowserWindowController browsingContextController:canAuthenticateAgainstProtectionSpace:]):
1142         Ditto.
1143         (-[WK2BrowserWindowController browsingContextController:didReceiveAuthenticationChallenge:]): Ditto.
1144
1145 2013-12-06  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1146
1147         Remove function from style/checkers/cpp.py.
1148         https://bugs.webkit.org/show_bug.cgi?id=125341
1149
1150         Reviewed by Darin Adler.
1151
1152         Corrects a FIXME: by removing a function from cpp.py.
1153
1154         * Scripts/webkitpy/style/checkers/cpp.py:
1155         (CppChecker.__init__):
1156         (CppChecker.check):
1157         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1158         (CppStyleTestBase.process_file_data):
1159
1160 2013-12-06  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1161
1162         check-webkit-style: false positive warning for indentation of #ifdef code.
1163         https://bugs.webkit.org/show_bug.cgi?id=125254
1164
1165         Reviewed by Darin Adler.
1166
1167         * Scripts/webkitpy/style/checkers/cpp.py:
1168         (check_member_initialization_list):
1169         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1170         (WebKitStyleTest.test_member_initialization_list):
1171
1172 2013-12-06  Chris Fleizach  <cfleizach@apple.com>
1173
1174         Fix spelling error in style checker: beggining
1175         https://bugs.webkit.org/show_bug.cgi?id=125347
1176
1177         Reviewed by Anders Carlsson.
1178
1179         * Scripts/webkitpy/style/checkers/cpp.py:
1180         (check_member_initialization_list):
1181         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1182         (WebKitStyleTest.test_member_initialization_list):
1183
1184 2013-12-06  Lukasz Gajowy  <l.gajowy@samsung.com>
1185
1186         [ATK] Missing aria roles mappings
1187         https://bugs.webkit.org/show_bug.cgi?id=117729
1188
1189         Reviewed by Mario Sanchez Prada.
1190
1191         Added new mappings to AccessibilityUIElementAtk.cpp.
1192
1193         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1194         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1195
1196 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1197
1198         Typo fix after r160218.
1199
1200         * Scripts/webkitpy/test/main.py:
1201         (main):
1202
1203 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1204
1205         Unreviewed fix after r160206.
1206
1207         * Scripts/webkitpy/test/main.py:
1208         (main): sys.platform can be win32 or cygwin too on Windows.
1209
1210 2013-12-05  Csaba Osztrogonác  <ossy@webkit.org>
1211
1212         Disable WebKit2 webkitpy unittests on Windows
1213         https://bugs.webkit.org/show_bug.cgi?id=125318
1214
1215         Reviewed by Ryosuke Niwa.
1216
1217         * Scripts/webkitpy/test/main.py:
1218         (main):
1219
1220 2013-12-05  Anders Carlsson  <andersca@apple.com>
1221
1222         Tweak WeakObjCPtr
1223         https://bugs.webkit.org/show_bug.cgi?id=125311
1224
1225         Reviewed by Darin Adler.
1226
1227         Split up tests into more logical groups. Add new tests for new functionality.
1228
1229         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1230
1231 2013-12-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1232
1233         [GTK] Fix gtk-doc warnings when generating DOM bindings API docs
1234         https://bugs.webkit.org/show_bug.cgi?id=125302
1235
1236         Reviewed by Philippe Normand.
1237
1238         * gtk/generate-webkitdom-doc-files:
1239         (WebKitDOMDocGeneratorSections.write_footer): Add a new section
1240         containing a private subsection for WEBKIT_API, WEBKIT_DEPRECATED
1241         and WEBKIT_DEPRECATED_FOR macros.
1242
1243 2013-12-05  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1244
1245         Fix cross compilation on x86
1246         https://bugs.webkit.org/show_bug.cgi?id=125295
1247
1248         Reviewed by Zoltan Herczeg.
1249
1250         Certain compiler flags should not be added when cross compilation is enabled.
1251
1252         * Scripts/webkitdirs.pm:
1253         (runAutogenForAutotoolsProjectIfNecessary):
1254         (generateBuildSystemFromCMakeProject):
1255
1256 2013-12-05  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1257
1258         Remove duplicated/dead code from cpp style checker unit tests.
1259         https://bugs.webkit.org/show_bug.cgi?id=125226
1260
1261         Reviewed by Ryosuke Niwa.
1262
1263         Remove the first definition of OrderOfIncludesTest class as it is
1264         overwritten by the second. Remove a duplicated assert statement
1265         from the second class.
1266
1267         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1268         (OrderOfIncludesTest.setUp):
1269         (OrderOfIncludesTest.test_try_drop_common_suffixes):
1270           The last assert was duplicated.
1271
1272 2013-12-05  László Langó  <lango@inf.u-szeged.hu>
1273
1274         Remove Scripts/generate-qt-inspector-resource.
1275         https://bugs.webkit.org/show_bug.cgi?id=125288
1276
1277         Reviewed by Andreas Kling.
1278
1279         * Scripts/generate-qt-inspector-resource: Removed. There is no QT anymore.
1280         We don't need this file.
1281
1282 2013-12-05  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1283
1284         Remove certain methods from TestExpectations and use TestExpectationsModel instead of them
1285         https://bugs.webkit.org/show_bug.cgi?id=125218
1286
1287         Reviewed by Ryosuke Niwa.
1288
1289         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1290         (LayoutTestFinder.skip_tests):
1291         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1292         (LayoutTestRunner.run_tests):
1293         (LayoutTestRunner._update_summary_with_result):
1294         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1295         (Manager._test_is_slow):
1296         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1297         (JSONLayoutResultsGenerator._insert_failure_summaries):
1298         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1299         (TestExpectations.get_rebaselining_failures):
1300         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1301         (assert_exp):
1302         (MiscTests.test_multiple_results):
1303         (MiscTests.test_category_expectations):
1304         (MiscTests.test_get_modifiers):
1305         (MiscTests.test_get_expectations_string):
1306         (MiscTests.test_expectation_to_string):
1307         (MiscTests.test_get_test_set):
1308         (MiscTests.test_more_specific_override_resets_skip):
1309         (SkippedTests.check):
1310         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1311         (TestRunResults.__init__):
1312         (summarize_results):
1313         * Scripts/webkitpy/tool/commands/rebaseline.py:
1314         (RebaselineExpectations._tests_to_rebaseline):
1315
1316 2013-12-04  Ryosuke Niwa  <rniwa@webkit.org>
1317
1318         Enable HTMLTemplateElement by default
1319         https://bugs.webkit.org/show_bug.cgi?id=123851
1320
1321         Reviewed by Antti Koivisto.
1322
1323         * Scripts/webkitperl/FeatureList.pm:
1324
1325 2013-12-04  Jozsef Berta  <jberta@inf.u-szeged.hu>
1326
1327         [EFL] Bumping GStreamer version to 1.2.1
1328         https://bugs.webkit.org/show_bug.cgi?id=125155
1329
1330         Reviewed by Gyuyoung Kim.
1331
1332         * efl/jhbuild.modules: Set the GStreamer version to 1.2.1
1333
1334
1335 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1336
1337         Update jhbuild revision.
1338         https://bugs.webkit.org/show_bug.cgi?id=124966
1339         
1340         Reviewed by Gyuyoung Kim.
1341
1342         Used version of Jhbuild failed to create directories and caused
1343         update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.
1344
1345         * jhbuild/jhbuild-wrapper:
1346
1347 2013-12-04  Anders Carlsson  <andersca@apple.com>
1348
1349         Add a WeakObjCPtr class
1350         https://bugs.webkit.org/show_bug.cgi?id=125267
1351
1352         Reviewed by Geoffrey Garen.
1353
1354         Add API tests for WeakObjCPtr.
1355
1356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1357         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
1358         (TEST):
1359
1360 2013-12-04  Anders Carlsson  <andersca@apple.com>
1361
1362         Make the estimatedProgress property observable using KVO
1363         https://bugs.webkit.org/show_bug.cgi?id=125259
1364
1365         Reviewed by Dan Bernstein.
1366
1367         Bind the progress indicator value to the "estimatedProgress" property.
1368
1369         * MiniBrowser/mac/WK2BrowserWindowController.m:
1370         (-[WK2BrowserWindowController dealloc]):
1371         (-[WK2BrowserWindowController awakeFromNib]):
1372
1373 2013-12-04  Anders Carlsson  <andersca@apple.com>
1374
1375         Add a loading property to WKBrowsingContextController
1376         https://bugs.webkit.org/show_bug.cgi?id=125256
1377
1378         Reviewed by Dan Bernstein.
1379
1380         Bind the progress indicator visibility to the "loading" property.
1381
1382         * MiniBrowser/mac/WK2BrowserWindowController.m:
1383         (-[WK2BrowserWindowController dealloc]):
1384         (-[WK2BrowserWindowController awakeFromNib]):
1385         (-[WK2BrowserWindowController didStartProgress]):
1386         (-[WK2BrowserWindowController didFinishProgress]):
1387
1388 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
1389
1390         [EFL][WK2] Buildfix after r160104
1391         https://bugs.webkit.org/show_bug.cgi?id=125231
1392
1393         Reviewed by Anders Carlsson.
1394
1395         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1396         (TestWebKitAPI::TEST): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base
1397         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1398         (TestWebKitAPI::setViewClient): Ditto.
1399
1400 2013-12-04  Myles C. Maxfield  <mmaxfield@apple.com>
1401
1402         check-webkit-style detected some ternary statements as initialization lists
1403         https://bugs.webkit.org/show_bug.cgi?id=125246
1404
1405         Reviewed by Dean Jackson.
1406
1407         The regular expression that check-webkit-tests uses to detect initialization
1408         lists was too broad, resulting in false positives. This patch makes the
1409         regex more specific
1410
1411         * Scripts/webkitpy/style/checkers/cpp.py:
1412         (check_member_initialization_list):
1413         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1414         (WebKitStyleTest.test_member_initialization_list):
1415
1416 2013-12-04  Mark Hahnenberg  <mhahnenberg@apple.com>
1417
1418         run-jsc-stress-tests can only run locally
1419         https://bugs.webkit.org/show_bug.cgi?id=124551
1420
1421         Reviewed by Filip Pizlo.
1422
1423         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Fixed a couple issues. One was if the script was
1424         killed before the lock directory was removed, future executions wouldn't make any progress. Also 
1425         added a couple more signals to handle gracefully at shutdown. 
1426         * Scripts/run-javascriptcore-tests: Pass through the --remote argument to run-jsc-stress-tests.
1427         * Scripts/run-jsc-stress-tests: Added support for the --remote flag. It accepts a hostname, user, and port.
1428         The script then generates the test bundle, tars it up, and copies it to the remote host via ssh where
1429         it then untars the bundle and executes the shell-based test runner. Also refactored some of the logic
1430         toward the end of the script to make it easier to tell which of the various modes do what.
1431
1432 2013-12-04  Csaba Osztrogonác  <ossy@webkit.org>
1433
1434         [EFL][WK2] Buildfix after r160104
1435         https://bugs.webkit.org/show_bug.cgi?id=125233
1436
1437         Reviewed by Anders Carlsson.
1438
1439         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1440         (TestWebKitAPI::TEST):
1441         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1442         (TestWebKitAPI::setPageLoaderClient):
1443
1444 2013-12-03  Anders Carlsson  <andersca@apple.com>
1445
1446         Deprecate all unversioned client structs in favor of having explicit versioned structs
1447         https://bugs.webkit.org/show_bug.cgi?id=125203
1448
1449         Reviewed by Dan Bernstein.
1450
1451         Update for WebKit2 API changes.
1452
1453         * MiniBrowser/mac/AppDelegate.m:
1454         (-[BrowserAppDelegate init]):
1455         * MiniBrowser/mac/WK2BrowserWindowController.m:
1456         (-[WK2BrowserWindowController awakeFromNib]):
1457         * TestWebKitAPI/InjectedBundleController.cpp:
1458         (TestWebKitAPI::InjectedBundleController::initialize):
1459         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1460         (TestWebKitAPI::TEST):
1461         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1462         (TestWebKitAPI::setInjectedBundleClient):
1463         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
1464         (TestWebKitAPI::TEST):
1465         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1466         (TestWebKitAPI::TEST):
1467         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1468         (TestWebKitAPI::TEST):
1469         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1470         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
1471         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
1472         (TestWebKitAPI::TEST):
1473         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1474         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
1475         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
1476         (TestWebKitAPI::setInjectedBundleClient):
1477         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1478         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1479         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
1480         (TestWebKitAPI::TEST):
1481         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1482         (TestWebKitAPI::TEST):
1483         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1484         (TestWebKitAPI::setContextDownloadClient):
1485         (TestWebKitAPI::setPagePolicyClient):
1486         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1487         (TestWebKitAPI::TEST):
1488         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1489         (TestWebKitAPI::TEST):
1490         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1491         (TestWebKitAPI::TEST):
1492         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1493         (TestWebKitAPI::TEST):
1494         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1495         (TestWebKitAPI::TEST):
1496         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1497         (TestWebKitAPI::TEST):
1498         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1499         (TestWebKitAPI::setupGeolocationProvider):
1500         (TestWebKitAPI::setupView):
1501         (TestWebKitAPI::TEST):
1502         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
1503         (TestWebKitAPI::TEST):
1504         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1505         (TestWebKitAPI::setPageLoaderClient):
1506         (TestWebKitAPI::setInjectedBundleClient):
1507         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1508         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
1509         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1510         (TestWebKitAPI::TEST):
1511         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
1512         (TestWebKitAPI::setInjectedBundleClient):
1513         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1514         (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
1515         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
1516         (TestWebKitAPI::TEST):
1517         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
1518         (TestWebKitAPI::TEST):
1519         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1520         (TestWebKitAPI::TEST):
1521         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1522         (TestWebKitAPI::TEST):
1523         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1524         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage):
1525         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
1526         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1527         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1528         (TestWebKitAPI::setPageLoaderClient):
1529         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
1530         (TestWebKitAPI::setPageLoaderClient):
1531         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1532         (TestWebKitAPI::setPageLoaderClient):
1533         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1534         (TestWebKitAPI::setPageLoaderClient):
1535         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1536         (TestWebKitAPI::setPageLoaderClient):
1537         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1538         (TestWebKitAPI::TEST):
1539         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1540         (TestWebKitAPI::TEST):
1541         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
1542         (TestWebKitAPI::setInjectedBundleClient):
1543         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
1544         (TestWebKitAPI::ParentFrameTest::didCreatePage):
1545         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
1546         (TestWebKitAPI::setInjectedBundleClient):
1547         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
1548         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
1549         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1550         (TestWebKitAPI::TEST):
1551         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
1552         (TestWebKitAPI::TEST):
1553         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1554         (TestWebKitAPI::TEST):
1555         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
1556         (TestWebKitAPI::TEST):
1557         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1558         (TestWebKitAPI::setInjectedBundleClient):
1559         (TestWebKitAPI::setPageLoaderClient):
1560         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1561         (TestWebKitAPI::setPageLoaderClient):
1562         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1563         (TestWebKitAPI::TEST):
1564         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
1565         (TestWebKitAPI::setPageLoaderClient):
1566         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
1567         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
1568         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1569         (TestWebKitAPI::TEST):
1570         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
1571         (TestWebKitAPI::TEST):
1572         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
1573         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
1574         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
1575         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp:
1576         (TestWebKitAPI::TEST):
1577         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp:
1578         (TestWebKitAPI::WKConnectionTest::initialize):
1579         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
1580         (TestWebKitAPI::setPageLoaderClient):
1581         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1582         (TestWebKitAPI::setInjectedBundleClient):
1583         (TestWebKitAPI::TEST):
1584         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
1585         (TestWebKitAPI::WebKit2WillLoadTest::setInjectedBundleClient):
1586         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1587         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
1588         (TestWebKitAPI::setInjectedBundleClient):
1589         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
1590         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
1591         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1592         (TestWebKitAPI::TEST):
1593         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
1594         (TestWebKitAPI::setInjectedBundleClient):
1595         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1596         (TestWebKitAPI::TEST):
1597         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1598         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
1599         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
1600         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
1601         (TestWebKitAPI::didCreateConnection):
1602         (TestWebKitAPI::TEST):
1603         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1604         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
1605         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
1606         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1607         (TestWebKitAPI::setPageLoaderClient):
1608         * WebKitTestRunner/GeolocationProviderMock.cpp:
1609         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1610         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1611         (WTR::InjectedBundle::initialize):
1612         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1613         (WTR::InjectedBundlePage::InjectedBundlePage):
1614         * WebKitTestRunner/TestController.cpp:
1615         (WTR::TestController::createOtherPage):
1616         (WTR::TestController::initialize):
1617         (WTR::TestController::createWebViewWithOptions):
1618
1619 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1620
1621         Style checker for .messages.in files (WTF:: prefix)
1622         https://bugs.webkit.org/show_bug.cgi?id=125142
1623
1624         Reviewed by Anders Carlsson.
1625
1626         A new style checker for .messages.in files, that checks for the use of WTF::
1627         prefix in these files. (Also checks for tabs as these files were previously
1628         handled as text files.)
1629
1630         * Scripts/webkitpy/style/checker.py:
1631         (CheckerDispatcher._create_checker):
1632           New checker is returned for .messages.in files.
1633         * Scripts/webkitpy/style/checkers/messagesin.py: Added.
1634           The new style checker class.
1635         (MessagesInChecker):
1636         (MessagesInChecker.__init__):
1637         (MessagesInChecker.check):
1638         (MessagesInChecker.check_WTF_prefix):
1639         * Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added.
1640           Unit test for the new style  checker class.
1641         (MessagesInCheckerStyleTestCase):
1642         (test_checker):
1643         (test_checker.error_handler_for_test):
1644         (MessagesInCheckerTestCase):
1645         (MessagesInCheckerTestCase.test_init):
1646         (MessagesInCheckerTestCase.test_init.error_handler_for_test):
1647
1648 2013-12-04  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1649
1650         Style checker requires alphabetical ordering in cmake lists even it contains variable.
1651         https://bugs.webkit.org/show_bug.cgi?id=124918
1652
1653         Reviewed by Csaba Osztrogonác.
1654
1655         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
1656         (CMakeCheckerTest.test_check):
1657         * Scripts/webkitpy/style/checkers/cmake.py:
1658         (CMakeChecker._check_list_order):
1659         This will ignore lines with variable substitution.
1660
1661 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
1662
1663         check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
1664         https://bugs.webkit.org/show_bug.cgi?id=124731
1665
1666         Reviewed by Zoltan Herczeg.
1667
1668         * Scripts/webkitpy/style/checkers/cpp.py:
1669         (check_spacing):
1670         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1671         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
1672
1673 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
1674
1675         Remove codecs and os dependencies from filereader.py in webkitpy/style.
1676         https://bugs.webkit.org/show_bug.cgi?id=124719
1677
1678         Although TextFileReader requires a FileSystem it circumvents it in two places!
1679         We should use the FileSystem only and remove codecs and os imports.
1680
1681         Reviewed by Zoltan Herczeg.
1682
1683         * Scripts/webkitpy/common/system/filesystem.py:
1684         (FileSystem.open_stdin): Moved from TextFileReader
1685         * Scripts/webkitpy/style/filereader.py:
1686         (TextFileReader._read_lines): use FileSystem instead of calling codecs.open directly
1687         (TextFileReader._process_directory): use FileSystem instead of calling os.walk directly
1688
1689 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
1690
1691         check-webkit-style should check member initialization indentation.
1692         https://bugs.webkit.org/show_bug.cgi?id=124820
1693
1694         Reviewed by Zoltan Herczeg.
1695
1696         check-webkit-style should check member initialization indentation
1697         belongs to webkit coding style:
1698         http://www.webkit.org/coding/coding-style.html#punctuation-member-init
1699
1700         * Scripts/webkitpy/style/checkers/cpp.py:
1701         (check_member_initialization_list): Add new method to check member
1702         initialization list.
1703         (check_style): Add the call of the new method.
1704         (check_language): Move self initialization checking into the new method.
1705         (CppChecker): Add a new category for initialization list.
1706         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1707         (CppStyleTest.test_runtime_selfinit):
1708         (CppStyleTest.test_deprecated_cast):
1709         (WebKitStyleTest.test_member_initialization_list): Add new testcases for
1710         the new feature.
1711
1712 2013-12-04  Tamas Gergely  <gertom@inf.u-szeged.hu>
1713
1714         style-bot should reject Committer additions to committers.py
1715         https://bugs.webkit.org/show_bug.cgi?id=107574
1716
1717         Reviewed by Zoltan Herczeg.
1718
1719         The style check when executed in non-interactive mode (probably by a
1720         bot) will raise an additional error if the contributors.json file is
1721         modified. Non-interactive mode information is propagated to the
1722         Dispatcher, which creates a special JSON checker for the
1723         contributors.json file.
1724
1725         * Scripts/webkitpy/style/checker.py:
1726         (check_webkit_style_configuration):
1727         (CheckerDispatcher._create_checker):
1728         (CheckerDispatcher.dispatch):
1729         (StyleProcessorConfiguration.__init__):
1730         (StyleProcessor.process):
1731         * Scripts/webkitpy/style/checker_unittest.py:
1732         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
1733         (CheckerDispatcherDispatchTest.dispatch):
1734         (StyleProcessorConfigurationTest._style_checker_configuration):
1735         (StyleProcessor_EndToEndTest.test_init):
1736         (StyleProcessor_EndToEndTest.test_process):
1737         (StyleProcessor_CodeCoverageTest.MockDispatcher.dispatch):
1738         (StyleProcessor_CodeCoverageTest.setUp):
1739         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1740         (JSONChecker.line_number_from_json_exception):
1741         (JSONContributorsChecker):
1742         (JSONContributorsChecker.check):
1743         * Scripts/webkitpy/style/error_handlers_unittest.py:
1744         (DefaultStyleErrorHandlerTest._style_checker_configuration):
1745         * Scripts/webkitpy/style/optparser.py:
1746         (CommandOptionValues.__init__):
1747         (ArgumentParser._create_option_parser):
1748         (ArgumentParser.parse):
1749         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1750         (test_post):
1751         (test_upload):
1752         * Scripts/webkitpy/tool/steps/checkstyle.py:
1753         (CheckStyle.run):
1754
1755 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
1756
1757         [EFL][WK2] Fix build after API::Client changes
1758         https://bugs.webkit.org/show_bug.cgi?id=125206
1759
1760         Reviewed by Csaba Osztrogonác.
1761
1762         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
1763         (TestWebKitAPI::TEST):
1764         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1765         (TestWebKitAPI::setViewClient):
1766
1767 2013-12-03  Dan Bernstein  <mitz@apple.com>
1768
1769         Fixed a test timing out after r160040.
1770
1771         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1772         (-[SimpleLoadFailDelegate browsingContextController:didFailProvisionalLoadWithError:]):
1773         Updated for the delegate method rename.
1774
1775 2013-12-03  Filip Pizlo  <fpizlo@apple.com>
1776
1777         REGRESSION: repro scripts disappear when you rerun tests
1778         https://bugs.webkit.org/show_bug.cgi?id=125184
1779
1780         Reviewed by Mark Hahnenberg.
1781         
1782         This bug made it difficult to quickly see if a test that recently failed is still
1783         failing while also running a new batch of tests.
1784
1785         Repro scripts are supposed to stay around until you delete them explicitly. This
1786         patch accomplishes that.
1787
1788         * Scripts/run-jsc-stress-tests:
1789
1790 2013-12-03  peavo@outlook.com  <peavo@outlook.com>
1791
1792         [Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
1793         https://bugs.webkit.org/show_bug.cgi?id=125111
1794
1795         Reviewed by Filip Pizlo.
1796
1797         Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.
1798
1799         * Scripts/run-javascriptcore-tests: Enable api test and stress test for WinCairo.
1800         * Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.
1801
1802 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
1803
1804         Add a script to automatically configure a git clone
1805         https://bugs.webkit.org/show_bug.cgi?id=110073
1806
1807         Revert the change to use https for now since git.webkit.org is setup with http.
1808
1809         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1810         (SetupGitClone.execute):
1811
1812 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
1813
1814         Add a script to automatically configure a git clone
1815         https://bugs.webkit.org/show_bug.cgi?id=110073
1816
1817         Reviewed by Benjamin Poulain.
1818
1819         Added "webkit-patch setup-git-clone" to setup a brand new Git clone.
1820
1821         This command runs various commands listed on http://trac.webkit.org/wiki/UsingGitWithWebKit
1822
1823         * Scripts/webkitpy/tool/commands/__init__.py:
1824         * Scripts/webkitpy/tool/commands/setupgitclone.py: Added.
1825         (SetupGitClone):
1826         (SetupGitClone.execute):
1827
1828 2013-12-03  Anders Carlsson  <andersca@apple.com>
1829
1830         Deprecate WKNotificationProvider
1831         https://bugs.webkit.org/show_bug.cgi?id=125178
1832
1833         Reviewed by Sam Weinig.
1834
1835         Update for WebKit2 changes.
1836
1837         * WebKitTestRunner/TestController.cpp:
1838         (WTR::TestController::initialize):
1839         * WebKitTestRunner/WebNotificationProvider.cpp:
1840         (WTR::WebNotificationProvider::provider):
1841         * WebKitTestRunner/WebNotificationProvider.h:
1842
1843 2013-12-03  Brent Fulgham  <bfulgham@apple.com>
1844
1845         [Win] Support 64-bit Application Support Libraries Location 
1846         https://bugs.webkit.org/show_bug.cgi?id=125179
1847
1848         Reviewed by Tim Horton.
1849
1850         Enable the user to specify a location for 64-bit support libraries (such as libxml2, ICU, etc.)
1851         on Windows until an official distribution is available that properly creates registry settings
1852         to specify these locations.
1853
1854         * Scripts/webkitdirs.pm:
1855         (setupAppleWinEnv): Notify user to set WEBKIT_64_SUPPORT environment variable if needed.
1856         (setupCygwinEnv): Report WEWBKIT_64_SUPPORT path when running 64-bit builds.
1857         (appleApplicationSupportPath): Add WEBKIT_64_SUPPORT location to runtime environment when
1858         running 64-bit builds.
1859
1860 2013-12-03  Mark Hahnenberg  <mhahnenberg@apple.com>
1861
1862         run-jsc-stress-tests only supports host environments that have make installed
1863         https://bugs.webkit.org/show_bug.cgi?id=124550
1864
1865         Reviewed by Darin Adler.
1866
1867         This might not be the case for all hosts, so this patch implements an alternate "backend" 
1868         for run-jsc-stress-tests to use normal shell commands rather than Makefiles. To remain at 
1869         least somewhat competitive with the make-based test runner, the shell backend uses subshells
1870         run in the background to allow tests to run in parallel. Since the concurrency primitives 
1871         in shell scripting are rather coarse, the overhead of this parallelism is higher than that 
1872         of the make-based runner.
1873
1874         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added. This is the runner that is copied into
1875         the bundle and controls all of the parallel aspects of the shell-based test runner.
1876         * Scripts/run-jsc-stress-tests:
1877
1878 2013-12-03  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1879
1880         Remove function from TextChecker
1881         https://bugs.webkit.org/show_bug.cgi?id=125148
1882
1883         Reviewed by Darin Adler.
1884
1885         The process_file_data is used only from the unit tests, so it is simply moved there.
1886
1887         * Scripts/webkitpy/style/checkers/text.py:
1888         (TextChecker.check):
1889         * Scripts/webkitpy/style/checkers/text_unittest.py:
1890         (TextStyleTestCase.process_file_data):
1891         (TextStyleTestCase.assertNoError):
1892         (TextStyleTestCase.assertError):
1893
1894 2013-12-03  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1895
1896         Remove get_test() and reference test names directly instead.
1897         https://bugs.webkit.org/show_bug.cgi?id=124962
1898
1899         Reviewed by Csaba Osztrogonác.
1900
1901         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1902         (Base.__init__):
1903         (Base.get_basic_tests):
1904         (assert_exp):
1905         (MiscTests.test_multiple_results):
1906         (MiscTests.test_category_expectations):
1907         (MiscTests.test_get_modifiers):
1908         (MiscTests.test_get_expectations_string):
1909         (MiscTests.test_get_test_set):
1910         (MiscTests.test_parse_warning):
1911         (MiscTests.test_pixel_tests_flag.match):
1912
1913 2013-12-03  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1914
1915         Style Checker false pass.
1916         https://bugs.webkit.org/show_bug.cgi?id=112456
1917
1918         Reviewed by Csaba Osztrogonác.
1919
1920         * Scripts/webkitpy/style/checkers/changelog.py:
1921         (ChangeLogChecker.check_entry):
1922         simple regex fix to check "No new tests (...)."
1923         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1924         (ChangeLogCheckerTest.test_no_new_tests):
1925
1926 2013-12-02  Filip Pizlo  <fpizlo@apple.com>
1927
1928         run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
1929         https://bugs.webkit.org/show_bug.cgi?id=125130
1930
1931         Reviewed by Geoffrey Garen.
1932
1933         * Scripts/run-jsc-stress-tests:
1934
1935 2013-12-02  Samuel White  <samuel_white@apple.com>
1936
1937         AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
1938         https://bugs.webkit.org/show_bug.cgi?id=124561
1939
1940         Reviewed by Chris Fleizach.
1941
1942         Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should.
1943
1944         * DumpRenderTree/AccessibilityUIElement.cpp:
1945         (uiElementCountForSearchPredicateCallback):
1946         (uiElementForSearchPredicateCallback):
1947         (AccessibilityUIElement::getJSClass):
1948         * DumpRenderTree/AccessibilityUIElement.h:
1949         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1950         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1951         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1952         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1953         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1954         (searchPredicateParameterizedAttributeForSearchCriteria):
1955         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1956         (AccessibilityUIElement::uiElementForSearchPredicate):
1957         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1958         (AccessibilityUIElement::uiElementCountForSearchPredicate):
1959         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1960         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1961         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1962         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1963         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1964         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1965         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1966         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
1967         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
1968         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1969
1970 2013-12-02  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1971
1972         Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py
1973         https://bugs.webkit.org/show_bug.cgi?id=124714
1974
1975         Reviewed by Ryosuke Niwa.
1976
1977         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1978         (write_test_result):
1979         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1980         (TestFailure.write_failure):
1981         (FailureText):
1982         (FailureText.write_failure):
1983         (FailureAudio):
1984         (FailureAudio.write_failure):
1985         (FailureCrash.write_failure):
1986         (FailureMissingResult):
1987         (FailureTextMismatch):
1988         (FailureMissingImageHash.write_failure):
1989         (FailureMissingImage.write_failure):
1990         (FailureImageHashMismatch.write_failure):
1991         (FailureReftestMismatch.write_failure):
1992         (FailureReftestMismatchDidNotOccur.write_failure):
1993         (FailureMissingAudio):
1994         (FailureAudioMismatch):
1995
1996 2013-12-02  László Langó  <lango@inf.u-szeged.hu>
1997
1998         Remove the stderr_write attribute from StyleProcessorConfiguration
1999         https://bugs.webkit.org/show_bug.cgi?id=124703
2000
2001         Reviewed by Ryosuke Niwa.
2002
2003         Remove the stderr_write attribute from this class in checker and
2004         replace its use with calls to a logging module logger. We Should 
2005         use logging module instead of writing to stderr directly.
2006
2007         * Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger.
2008         (check_webkit_style_configuration):
2009         (CheckerDispatcher.dispatch): Remove FIXME comment.
2010         (StyleProcessorConfiguration):
2011         (StyleProcessorConfiguration.__init__):
2012         (StyleProcessorConfiguration.write_style_error):
2013         * Scripts/webkitpy/style/checker_unittest.py: Update test to the modification.
2014         There is an "ERROR" prefix in log messiges from now.
2015         (StyleProcessorConfigurationTest):
2016         (StyleProcessorConfigurationTest._style_checker_configuration):
2017         (StyleProcessorConfigurationTest.test_init):
2018         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
2019         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
2020         (StyleProcessor_EndToEndTest.with):
2021         (StyleProcessor_EndToEndTest.test_init):
2022         (StyleProcessor_EndToEndTest.test_process):
2023         (StyleProcessor_CodeCoverageTest.setUp):
2024         * Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger.
2025         (DefaultStyleErrorHandler.__call__):
2026         * Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification.
2027         There is an "ERROR" prefix in log messiges from now.
2028         (DefaultStyleErrorHandlerTest):
2029         (DefaultStyleErrorHandlerTest.setUp):
2030         (DefaultStyleErrorHandlerTest._mock_increment_error_count):
2031         (DefaultStyleErrorHandlerTest._style_checker_configuration):
2032         (DefaultStyleErrorHandlerTest._check_initialized):
2033         (DefaultStyleErrorHandlerTest.test_non_reportable_error):
2034         (DefaultStyleErrorHandlerTest.test_max_reports_per_category):
2035         (DefaultStyleErrorHandlerTest.test_line_numbers):
2036
2037 2013-12-02  Brian J. Burg  <burg@cs.washington.edu>
2038
2039         Add JavaScript style checker and teach checker.py about .js files
2040         https://bugs.webkit.org/show_bug.cgi?id=125049
2041
2042         Reviewed by Joseph Pecoraro.
2043
2044         Add a JavaScript file type, extension, and checker (JSChecker).
2045         Use TextChecker for JavaScript tests, libraries, website resources,
2046         etc. and use JSChecker for files within WebInspectorUI/UserInterface.
2047
2048         Amended tests for TextChecker to reflect the rule above.
2049
2050         * Scripts/webkitpy/style/checker.py:
2051         (_all_categories): Add categories defined by JSChecker.
2052         (FileType): Add file type for JS and re-number the enum.
2053         (CheckerDispatcher._file_type): Detect .js files as JavaScript.
2054         (CheckerDispatcher._create_checker):
2055         Create a JSChecker or TextChecker depending on the file's path.
2056
2057         * Scripts/webkitpy/style/checker_unittest.py:
2058         (CheckerDispatcherDispatchTest.assert_checker_js): Added.
2059         (CheckerDispatcherDispatchTest.test_js_paths): Added.
2060         (CheckerDispatcherDispatchTest.test_text_paths): Add new test paths
2061         that end in .js but should be checked with TextChecker.
2062         * Scripts/webkitpy/style/checkers/js.py: Added.
2063         (JSChecker):
2064         (JSChecker.__init__):
2065         (JSChecker.check):
2066         * Scripts/webkitpy/style/checkers/js_unittest.py: Added.
2067         (JSTestCase):
2068         (JSTestCase.assertNoError):
2069         (JSTestCase.assertNoError.error_for_test):
2070         (JSTestCase.assertError):
2071         (JSTestCase.assertError.error_for_test):
2072         (JSTestCase.test_no_error):
2073         (JSTestCase.test_error):
2074
2075 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2076
2077         run-jsc-stress-tests always copies the VM
2078         https://bugs.webkit.org/show_bug.cgi?id=125092
2079
2080         Reviewed by Filip Pizlo.
2081
2082         This can be slow, especially with full debug builds. It should just symlink the VM into the 
2083         bundle by default and do a full copy only when asked.
2084
2085         * Scripts/run-jsc-stress-tests:
2086
2087 2013-12-02  Brent Fulgham  <bfulgham@apple.com>
2088
2089         [Win] Port run-jsc-stress-tests
2090         https://bugs.webkit.org/show_bug.cgi?id=124801
2091
2092         Reviewed by Filip Pizlo.
2093
2094         * Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl
2095         command on Windows so that stress tests can run.
2096
2097 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2098
2099         Build fix after r159955
2100
2101         * Scripts/run-jsc-stress-tests:
2102
2103 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2104
2105         run-jsc-stress-tests should be able to package its tests and move them places
2106         https://bugs.webkit.org/show_bug.cgi?id=124549
2107
2108         Reviewed by Filip Pizlo.
2109
2110         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
2111         of grep -i -q
2112         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
2113         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
2114         We now also copy whatever VM was specified, along with its associated framework, into this directory.
2115         All of the generated scripts now are completely relative within the results directory. This allows
2116         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
2117         tarball of the generated results directory. Also refactored several portions of the script into
2118         separate functions to make it easier to run them conditionally depending on which mode we're running in. 
2119
2120 2013-12-02  Andrzej Badowski  <a.badowski@samsung.com>
2121
2122         [ATK] Support active state for listbox elements.
2123         https://bugs.webkit.org/show_bug.cgi?id=125009
2124
2125         Reviewed by Chris Fleizach.
2126
2127         Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.
2128
2129         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2130         (AccessibilityUIElement::isSelectedOptionActive):
2131         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2132         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2133         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2134         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2135         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2136         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2137         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2138         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2139
2140 2013-12-02  Zan Dobersek  <zdobersek@igalia.com>
2141
2142         Unreviewed GTK gardening.
2143
2144         * Scripts/run-gtk-tests:
2145         (TestRunner): Skip two unit tests that are causing the subsequent test to crash.
2146
2147 2013-12-01  Dan Bernstein  <mitz@apple.com>
2148
2149         [Mac] Transition MiniBrowser to the Cocoa API: policy delegate   
2150         https://bugs.webkit.org/show_bug.cgi?id=125046
2151
2152         Reviewed by Sam Weinig.
2153
2154         * MiniBrowser/mac/AppDelegate.m:
2155         (-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
2156         (-[BrowserAppDelegate openDocument:]): Ditto.
2157         * MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the
2158         interface to the implementation.
2159         * MiniBrowser/mac/WK2BrowserWindowController.m:
2160         (-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
2161         the policy client.
2162         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
2163         Moved policy client implementation into this delegate method.
2164         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
2165         Ditto.
2166         (-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
2167         Ditto.
2168
2169 2013-12-01  Dan Bernstein  <mitz@apple.com>
2170
2171         [Mac] Remove the MiniBrowser injected bundle
2172         https://bugs.webkit.org/show_bug.cgi?id=125041
2173
2174         Reviewed by Anders Carlsson.
2175
2176         It had no ops!
2177
2178         * MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
2179         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2180         * MiniBrowser/mac/AppDelegate.m:
2181         (-[BrowserAppDelegate init]):
2182         * MiniBrowser/mac/WebBundle/Info.plist: Removed.
2183         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2184
2185 2013-11-29  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2186
2187         check-webkit-style should check for extraneous newline between config.h and primary header.
2188         https://bugs.webkit.org/show_bug.cgi?id=124821
2189
2190         Reviewed by Csaba Osztrogonác.
2191
2192         * Scripts/webkitpy/style/checkers/cpp.py:
2193         (check_include_line):
2194         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2195         (OrderOfIncludesTest.test_check_line_break_after_own_header):
2196         (OrderOfIncludesTest):
2197         (OrderOfIncludesTest.test_check_line_break_before_own_header):
2198
2199 2013-11-29  Jozsef Berta  <jberta@inf.u-szeged.hu>
2200
2201         test-webkit-scripts should show the failing tests and use an appropriate exit code
2202         https://bugs.webkit.org/show_bug.cgi?id=124840
2203
2204         Reviewed by Ryosuke Niwa.
2205
2206         A fixme in test-webkit-scripts asked that the script should display success or failiure
2207         and exit with a 0 or 1 value accordingly after all of the tests have completed.
2208
2209         * Scripts/test-webkit-scripts:
2210         (ScriptsTester.run_test_script):
2211         The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
2212         because at this point we don't need to pass on more information other than success or failiure.
2213         (ScriptsTester.main):
2214         The return values are now stored for each script and when all tests have completed successfully,
2215         the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.
2216
2217 2013-11-29  Krzysztof Czech  <k.czech@samsung.com>
2218
2219         [ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
2220         https://bugs.webkit.org/show_bug.cgi?id=124923
2221
2222         Reviewed by Mario Sanchez Prada.
2223
2224         Added missing implementation of isAttributeSettable. Using
2225         ATK_STATE_EDITABLE for checking whether attribute is settable.
2226
2227         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2228         (AccessibilityUIElement::isAttributeSettable):
2229         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2230         (WTR::AccessibilityUIElement::isAttributeSettable):
2231
2232 2013-11-28  Commit Queue  <commit-queue@webkit.org>
2233
2234         Unreviewed, rolling out r159839.
2235         http://trac.webkit.org/changeset/159839
2236         https://bugs.webkit.org/show_bug.cgi?id=124974
2237
2238         run-webkit-tests doesn't generate pretty diff (Requested by
2239         Ossy on #webkit).
2240
2241         * Scripts/webkitpy/common/prettypatch.py:
2242         (PrettyPatch.__init__):
2243         (PrettyPatch.pretty_diff):
2244         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2245         (TestResultWriter.create_text_diff_and_write_result):
2246         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2247         (summarize_results):
2248         * Scripts/webkitpy/port/base.py:
2249         (Port.__init__):
2250         (Port.pretty_patch_available):
2251         (Port.check_pretty_patch):
2252         (Port.variable):
2253         (Port.variable.pretty_patch_text):
2254         * Scripts/webkitpy/port/base_unittest.py:
2255         (PortTest.test_pretty_patch_os_error):
2256         (PortTest.test_pretty_patch_script_error):
2257
2258 2013-11-28  Antti Koivisto  <antti@apple.com>
2259
2260         Remove feature: CSS variables
2261         https://bugs.webkit.org/show_bug.cgi?id=114119
2262
2263         Reviewed by Andreas Kling.
2264
2265         * Scripts/webkitperl/FeatureList.pm:
2266
2267 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2268
2269         Move PrettyPatch related code to prettypatch.py
2270         https://bugs.webkit.org/show_bug.cgi?id=124937
2271
2272         Reviewed by Ryosuke Niwa.
2273
2274         This code seems to have a better place here than in Port, since PrettyPatch already knows
2275         pretty_patch_path, and this also unifies the usage of PrettyPatch
2276
2277         * Scripts/webkitpy/common/prettypatch.py:
2278         (PrettyPatch.__init__):
2279         (PrettyPatch.pretty_diff):
2280         (PrettyPatch):
2281         (PrettyPatch.pretty_patch_available):
2282         (PrettyPatch.check_pretty_patch):
2283         (PrettyPatch.pretty_patch_text):
2284         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2285         (TestResultWriter.create_text_diff_and_write_result):
2286         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2287         (summarize_results):
2288         * Scripts/webkitpy/port/base.py:
2289         (Port.__init__):
2290         (Port.wdiff_available):
2291         (Port.check_image_diff):
2292         (Port.wdiff_text):
2293         * Scripts/webkitpy/port/base_unittest.py:
2294         (PortTest.test_pretty_patch_os_error):
2295         (PortTest.test_pretty_patch_script_error):
2296
2297 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2298
2299         Checkout should own the scm object in Host
2300         https://bugs.webkit.org/show_bug.cgi?id=124943
2301
2302         Reviewed by Ryosuke Niwa.
2303
2304         * Scripts/webkitpy/common/host.py:
2305         (Host.__init__):
2306         (Host.initialize_scm):
2307         (Host.scm):
2308
2309 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
2310
2311         Do bytecode validation as part of testing
2312         https://bugs.webkit.org/show_bug.cgi?id=124913
2313
2314         Reviewed by Oliver Hunt.
2315
2316         * Scripts/run-jsc-stress-tests:
2317
2318 2013-11-27  Andres Gomez  <agomez@igalia.com>
2319
2320         [GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
2321         https://bugs.webkit.org/show_bug.cgi?id=124940
2322
2323         Reviewed by Martin Robinson.
2324
2325         xserver-font-utils is needed for building gtk port dependencies
2326         with jhbuild.
2327
2328         * gtk/install-dependencies: Added xserver-font-utils to jhbuild
2329         dependecies.
2330
2331 2013-11-27  Andres Gomez  <agomez@igalia.com>
2332
2333         [GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
2334         https://bugs.webkit.org/show_bug.cgi?id=124938
2335
2336         Reviewed by Philippe Normand.
2337
2338         Added needed git dependency for building the gtk port with
2339         jhbuild. Also, the dependencies needed for building the gtk port
2340         are now sorted alphabetically.
2341
2342         * gtk/install-dependencies: Added git as jhbuild dependency and
2343         sorted dependencies alphabetically.
2344
2345 2013-11-27  Jozsef Berta  <jberta@inf.u-szeged.hu>
2346
2347         run_webkit_tests.py: error: no such option: --wincairo
2348         https://bugs.webkit.org/show_bug.cgi?id=124927
2349
2350         Reviewed by Ryosuke Niwa.
2351
2352         * BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports
2353         the layout testing on wincairo, so it is turned off.
2354
2355 2013-11-26  Marcelo Lira  <marcelo.lira@openbossa.org>
2356
2357         Nix upstreaming - Adding build files and supporting scripts
2358         https://bugs.webkit.org/show_bug.cgi?id=118367
2359
2360         Reviewed by Ryosuke Niwa.
2361
2362         * Scripts/build-webkit:
2363         * Scripts/run-nix-tests: Added.
2364         * Scripts/run-webkit-tests:
2365         * Scripts/update-webkit-libs-jhbuild:
2366         * Scripts/update-webkitnix-libs: Added.
2367         * Scripts/webkitdirs.pm:
2368         (determineArchitecture):
2369         (argumentsForConfiguration):
2370         (jscProductDir):
2371         (builtDylibPathForName):
2372         (determineIsNix):
2373         (isNix):
2374         (isAppleWebKit):
2375         (launcherPath):
2376         (launcherName):
2377         (checkRequiredSystemConfig):
2378         (copyInspectorFrontendFiles):
2379         (jhbuildWrapperPrefixIfNeeded):
2380         (buildCMakeProjectOrExit):
2381         (cmakeBasedPortName):
2382         * Scripts/webkitpy/common/config/ports.py:
2383         (DeprecatedPort.port):
2384         (EflWK2Port.build_webkit_command):
2385         (NixPort):
2386         (NixPort.build_webkit_command):
2387         * Scripts/webkitpy/port/factory.py:
2388         (platform_options):
2389         (PortFactory):
2390         * Scripts/webkitpy/port/nix.py: Added.
2391         (NixPort):
2392         (NixPort._wk2_port_name):
2393         (NixPort.determine_full_port_name):
2394         (NixPort.__init__):
2395         (NixPort._port_flag_for_scripts):
2396         (NixPort.setup_test_run):
2397         (NixPort.setup_environ_for_server):
2398         (NixPort.default_timeout_ms):
2399         (NixPort.clean_up_test_run):
2400         (NixPort._generate_all_test_configurations):
2401         (NixPort._path_to_driver):
2402         (NixPort._path_to_image_diff):
2403         (NixPort._image_diff_command):
2404         (NixPort._search_paths):
2405         (NixPort.show_results_html_file):
2406         (NixPort._port_specific_expectations_files):
2407         (NixPort.default_baseline_search_path):
2408         * Scripts/webkitpy/port/nix_unittest.py: Added.
2409         (NixPortTest):
2410         (NixPortTest._assert_search_path):
2411         (NixPortTest._assert_expectations_files):
2412         (NixPortTest.test_baseline_search_path):
2413         (NixPortTest.test_expectations_files):
2414         (NixPortTest.test_default_timeout_ms):
2415         * jhbuild/jhbuild-wrapper:
2416         (determine_platform):
2417         * nix/common.py: Added.
2418         (script_path):
2419         (top_level_path):
2420         * nix/jhbuild.modules: Added.
2421         * nix/jhbuildrc: Added.
2422
2423 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2424
2425         Record subtest values in Dromaeo tests
2426         https://bugs.webkit.org/show_bug.cgi?id=124498
2427
2428         Reviewed by Andreas Kling.
2429
2430         Supported parsing subtest results.
2431
2432         * Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of
2433         which contains a dictionary with its name and an ordered list of subtest's metrics.
2434         (PerfTest.__init__): Initialize _metrics as a list.
2435         (PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
2436         (PerfTest._run_with_driver):
2437         (PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.
2438
2439         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2440         (TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
2441         (TestPerfTest.test_parse_output): Ditto.
2442         (TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
2443         assertions to ensure subtest results are parsed properly.
2444         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
2445         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.
2446
2447         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2448         (_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
2449         incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
2450         adding new results.
2451
2452         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2453         (TestWithSubtestsData): Added.
2454         (TestDriver.run_test):
2455         (MainTest.test_run_test_with_subtests): Added.
2456
2457 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2458
2459         Enable HTML template element on Windows ports
2460         https://bugs.webkit.org/show_bug.cgi?id=124758
2461
2462         Reviewed by Andreas Kling.
2463
2464         * Scripts/webkitperl/FeatureList.pm:
2465
2466 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
2467
2468         Remove replay performance tests as it's not actively maintained
2469         https://bugs.webkit.org/show_bug.cgi?id=124764
2470
2471         Reviewed by Andreas Kling.
2472
2473         Removed the feature.
2474
2475         * Scripts/webkitpy/performance_tests/perftest.py:
2476         (SingleProcessPerfTest.__init__):
2477         (PerfTestFactory):
2478         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2479         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2480         (PerfTestsRunner._parse_args):
2481         (PerfTestsRunner._collect_tests):
2482         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2483         (MainTest.test_collect_tests_with_ignored_skipped_list):
2484         (MainTest.test_default_args):
2485         * Scripts/webkitpy/thirdparty/__init__.py:
2486         (AutoinstallImportHook.find_module):
2487         (AutoinstallImportHook._install_unittest2):
2488         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2489         (ThirdpartyTest.test_imports):
2490
2491 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
2492
2493         Enable aggressive DFG validation in testing
2494         https://bugs.webkit.org/show_bug.cgi?id=124911
2495
2496         Rubber stamped by Ryosuke Niwa.
2497         
2498         This enables validation testing in non-concurrent-JIT runs.
2499
2500         * Scripts/run-jsc-stress-tests:
2501
2502 2013-11-26  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2503
2504         Moved methods which belong to Checkout into checkout.py
2505         https://bugs.webkit.org/show_bug.cgi?id=124889
2506
2507         Reviewed by Ryosuke Niwa.
2508
2509         * Scripts/webkitpy/common/checkout/checkout.py:
2510         (Checkout.scripts_directory):
2511         (Checkout):
2512         (Checkout.script_path):
2513         (Checkout.commit_message_for_this_commit):
2514         (Checkout.apply_patch):
2515         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2516         (test_commit_message_for_this_commit):
2517         (CheckoutTest.test_apply_patch):
2518         * Scripts/webkitpy/common/checkout/scm/scm.py:
2519         (SCM.absolute_path):
2520         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2521         (SCMTest._setup_webkittools_scripts_symlink):
2522         * Scripts/webkitpy/common/checkout/scm/svn.py:
2523         (SVN.create_patch):
2524
2525 2013-11-25  Ryuan Choi  <ryuan.choi@samsung.com>
2526
2527         [EFL] Use Config mode of find_package for EFL 1.8
2528         https://bugs.webkit.org/show_bug.cgi?id=124555
2529
2530         Reviewed by Gyuyoung Kim.
2531
2532         * MiniBrowser/efl/CMakeLists.txt:
2533         Added optional config mode and made version requirement optional.
2534
2535 2013-11-25  Andres Gomez  <agomez@igalia.com>
2536
2537         [GTK] Search functionality in MiniBrowser provides feedback on search fail
2538         https://bugs.webkit.org/show_bug.cgi?id=122681
2539
2540         Reviewed by Mario Sanchez Prada.
2541
2542         When using the search functionality in MiniBrowser, if the search
2543         fails, the entry background color gets red to report the user
2544         about the failing condition. When the entry is cleaned or the
2545         search is again succesful the background turns back to its
2546         original color.
2547
2548         * MiniBrowser/gtk/BrowserSearchBar.c:
2549         (setFailedStyleForEntry): Added.
2550         (doSearch): Sets the entry's background to its original style if
2551         there is no text to search.
2552         (findControllerFailedToFindTextCallback): Added.
2553         (findControllerFoundTextCallback): Added.
2554         (browser_search_bar_init): Creates and adds a new CSS provider to
2555         the text entry so we can change its style based on the success
2556         condition of the search.
2557         (browserSearchBarFinalize): Frees the new CSS provider.
2558         (browser_search_bar_new): Connects the two new handlers to the
2559         "failed-to-find-text" and "found-text" signals emitted by the
2560         WebKitFindController.
2561
2562 2013-11-25  Dan Bernstein  <mitz@apple.com>
2563
2564         [Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
2565         https://bugs.webkit.org/show_bug.cgi?id=124850
2566
2567         Reviewed by Brady Eidson.
2568
2569         Added #if WK_API_ENABLED guards around tests that use the Objective-C API.
2570
2571         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2572         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2573         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2574         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2575         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2576         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
2577         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2578
2579 2013-11-25  Commit Queue  <commit-queue@webkit.org>
2580
2581         Unreviewed, rolling out r159752 and r159754.
2582         http://trac.webkit.org/changeset/159752
2583         http://trac.webkit.org/changeset/159754
2584         https://bugs.webkit.org/show_bug.cgi?id=124847
2585
2586         Broke linux test bots. (Requested by mhahnenberg on #webkit).
2587
2588         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
2589         * Scripts/run-javascriptcore-tests:
2590         * Scripts/run-jsc-stress-tests:
2591
2592 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
2593
2594         Followup fix after r159752
2595
2596         * Scripts/run-jsc-stress-tests: We need to handle Release builds too.
2597
2598 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
2599
2600         run-jsc-stress-tests should be able to package its tests and move them places
2601         https://bugs.webkit.org/show_bug.cgi?id=124549
2602
2603         Reviewed by Filip Pizlo.
2604
2605         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation 
2606         of grep -i -q
2607         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
2608         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory. 
2609         We now also copy whatever VM was specified, along with its associated framework, into this directory. 
2610         All of the generated scripts now are completely relative within the results directory. This allows 
2611         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a 
2612         tarball of the generated results directory. Also refactored several portions of the script into 
2613         separate functions to make it easier to run them conditionally depending on which mode we're running in.
2614
2615 2013-11-25  László Langó  <lango@inf.u-szeged.hu>
2616
2617         EWS creates 0 byte sized log files
2618         https://bugs.webkit.org/show_bug.cgi?id=107606
2619
2620         Reviewed by Ryosuke Niwa.
2621
2622         There was a modification in r138264, that tried to make less log,
2623         because some of the messeges were duplicated. After this the EWS
2624         created the log file (with the same name as the bugID) but doesn't
2625         write anything into it, even if there were errors during the build.
2626         From now only creates the log file only if there is some error.
2627
2628         * Scripts/webkitpy/tool/bot/queueengine.py:
2629         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
2630         there is nothing to log. Open the log file only if a ScriptError was raised to
2631         avoid to make empty log files for bugs.
2632         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
2633         because of changes in r138264. Teeing is used for locally testing purposes and
2634         this feature is not used anymore.
2635         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
2636         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
2637         change.
2638         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2639         (LoggingDelegate): The order of the callbacks was changed by this patch.
2640         (QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
2641         so we have to update this test.
2642         (QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
2643         this patch.
2644         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2645         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
2646         to be able to handle it in QueueEngine.run. Without this change, the existing
2647         exception handler never run (the process_work_item method never raise ScriptError)
2648         We can get the error message only from the ScriptError at this point.
2649
2650 2013-11-22  Dean Jackson  <dino@apple.com>
2651
2652         Speculative Mountain Lion build fix.
2653
2654         * MiniBrowser/mac/AppDelegate.m:
2655         (-[BrowserAppDelegate openDocument:]):
2656
2657 2013-11-22  Anders Carlsson  <andersca@apple.com>
2658
2659         Fix Mountain Lion bug.
2660
2661         * MiniBrowser/mac/AppDelegate.m:
2662         (-[BrowserAppDelegate openDocument:]):
2663
2664 2013-11-22  Anders Carlsson  <andersca@apple.com>
2665
2666         MiniBrowser should use the blocks-based NSOpenPanel API
2667         https://bugs.webkit.org/show_bug.cgi?id=124786
2668
2669         Reviewed by Simon Fraser.
2670
2671         * MiniBrowser/mac/AppDelegate.m:
2672         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2673         Account for windows that don't have a BrowserWindowController.
2674
2675         (-[BrowserAppDelegate openDocument:]):
2676
2677 2013-11-22  Commit Queue  <commit-queue@webkit.org>
2678
2679         Unreviewed, rolling out r159690.
2680         http://trac.webkit.org/changeset/159690
2681         https://bugs.webkit.org/show_bug.cgi?id=124782
2682
2683         Broke webkitpy tests (Requested by ap on #webkit).
2684
2685         * Scripts/webkitpy/tool/bot/queueengine.py:
2686         (QueueEngine.run):
2687         (QueueEngine._open_work_log):
2688         (QueueEngine._ensure_work_log_closed):
2689         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2690         (AbstractEarlyWarningSystem.review_patch):
2691
2692 2013-11-22  László Langó  <lango@inf.u-szeged.hu>
2693
2694         EWS creates 0 byte sized log files
2695         https://bugs.webkit.org/show_bug.cgi?id=107606
2696
2697         Reviewed by Ryosuke Niwa.
2698
2699         There was a modification in r138264, that tried to make less log, 
2700         because some of the messeges were duplicated. After this the EWS 
2701         created the log file (with the same name as the bugID) but doesn't 
2702         write anything into it, even if there were errors during the build. 
2703         From now only creates the log file only if there is some error.
2704
2705         * Scripts/webkitpy/tool/bot/queueengine.py:
2706         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
2707         there is nothing to log. Open the log file only if a ScriptError was raised to
2708         avoid to make empty log files for bugs.
2709         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
2710         because of changes in r138264. Teeing is used for locally testing purposes and
2711         this feature is not used anymore.
2712         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output 
2713         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
2714         change.
2715         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2716         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
2717         to be able to handle it in QueueEngine.run. Without this change, the existing
2718         exception handler never run (the process_work_item method never raise ScriptError)
2719         We can get the error message only from the ScriptError at this point.
2720
2721 2013-11-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2722
2723         Remove ENABLE_WORKERS
2724         https://bugs.webkit.org/show_bug.cgi?id=105784
2725
2726         Reviewed by Darin Adler.
2727
2728         * Scripts/webkitperl/FeatureList.pm:
2729
2730 2013-11-21  Darin Adler  <darin@apple.com>
2731
2732         Try to fix buildbot Dashboard for people who have not hidden anything.
2733
2734         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2735         Add a null check for hidden platforms.
2736
2737 2013-11-21  Peter Szanka  <h868064@stud.u-szeged.hu>
2738
2739         Remove chrome/chromium related things from webkitpy.
2740         https://bugs.webkit.org/show_bug.cgi?id=124493
2741
2742         Reviewed by Darin Adler.
2743
2744         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2745         (PortTest.assert_mock_port_works):
2746         * Scripts/webkitpy/port/base.py:
2747         (Port.to.setup_environ_for_server):
2748         * Scripts/webkitpy/port/mac_unittest.py:
2749         (test_tests_for_other_platforms):
2750         * Scripts/webkitpy/port/mock_drt.py:
2751         (MockTestShell.output_for_test):
2752         * Scripts/webkitpy/tool/bot/irc_command.py:
2753         (Restart.execute):
2754         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2755         (IRCBotTest.test_help):
2756
2757 2013-11-21  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2758
2759         In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
2760         https://bugs.webkit.org/show_bug.cgi?id=124717
2761
2762         Reviewed by Ryosuke Niwa.
2763
2764         * Scripts/webkitpy/style/filereader.py:
2765         (TextFileReader.process_file):
2766         * Scripts/webkitpy/style/filereader_unittest.py:
2767         (TextFileReaderTest.test_process_file__does_not_exist):
2768
2769 2013-11-21  Mark Rowe  <mrowe@apple.com>
2770
2771         <https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
2772
2773         All modern versions of Xcode set it appropriately for our needs.
2774
2775         Reviewed by Alexey Proskuryakov.
2776
2777         * MiniBrowser/Configurations/Base.xcconfig:
2778         * WebKitTestRunner/Configurations/Base.xcconfig:
2779
2780 2013-11-21  Nick Diego Yamane  <nick.yamane@openbossa.org>
2781
2782         webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
2783         https://bugs.webkit.org/show_bug.cgi?id=124676
2784
2785         Reviewed by Daniel Bates.
2786
2787         checkForArgumentAndRemoveFromArrayRef functions was removing wrong
2788         elements when there were more then one occurrence of that argument.
2789         E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
2790         {b, a}, when it should be {b, c}.
2791
2792         * Scripts/webkitdirs.pm:
2793         (checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
2794         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
2795         Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
2796
2797 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
2798
2799         Update build-webkit after r159550.
2800
2801         * Scripts/webkitperl/FeatureList.pm:
2802
2803 2013-11-21  Lucas Forschler  <lforschler@apple.com>
2804
2805         Bring a new bot online, replacing the previous ones.
2806         
2807         Unreviewed.
2808
2809         * BuildSlaveSupport/build.webkit.org-config/config.json:
2810
2811 2013-11-21  Dean Jackson  <dino@apple.com>
2812
2813         Don't fetch hidden platforms on build.webkit.org/dashboard
2814         https://bugs.webkit.org/show_bug.cgi?id=124750
2815
2816         Reviewed by Tim Horton.
2817
2818         If a platform is hidden, don't fetch its data. If it
2819         becomes unhidden, try to fetch immediately (unless
2820         you've recently fetched).
2821
2822         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2823         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2824
2825 2013-11-21  Commit Queue  <commit-queue@webkit.org>
2826
2827         Unreviewed, rolling out r159633.
2828         http://trac.webkit.org/changeset/159633
2829         https://bugs.webkit.org/show_bug.cgi?id=124726
2830
2831         it broke 10 webkitpy tests (Requested by dino_ on #webkit).
2832
2833         * Scripts/webkitpy/style/checker.py:
2834         (check_webkit_style_configuration):
2835         (CheckerDispatcher.dispatch):
2836         (StyleProcessorConfiguration):
2837         (StyleProcessorConfiguration.__init__):
2838         (StyleProcessorConfiguration.write_style_error):
2839
2840 2013-11-21  László Langó  <lango@inf.u-szeged.hu>
2841
2842         Remove the stderr_write attribute from StyleProcessorConfiguration.
2843         https://bugs.webkit.org/show_bug.cgi?id=124703
2844
2845         Reviewed by Brent Fulgham.
2846
2847         * Scripts/webkitpy/style/checker.py:
2848         (check_webkit_style_configuration):
2849         (CheckerDispatcher.dispatch):
2850         (StyleProcessorConfiguration):
2851         (StyleProcessorConfiguration.__init__):
2852         (StyleProcessorConfiguration.write_style_error):
2853
2854 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
2855
2856         PerfTestRunner._generate_results_dict shouldn't depend on test objects
2857         https://bugs.webkit.org/show_bug.cgi?id=124623
2858
2859         Removed the dependency on test objects from results JSON generation.
2860         This allows single test.run to return metrics for multiple tests
2861
2862         Reviewed by Antti Koivisto.
2863
2864         * Scripts/webkitpy/performance_tests/perftest.py:
2865         (PerfTestMetric.__init__): Takes the test path and test name.
2866         (PerfTestMetric.path): Added.
2867         (PerfTestMetric.test_file_name): Added.
2868         (PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
2869         (PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
2870         The path is going to have the names of subtests at the end once we support them.
2871
2872         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2873         (TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
2874         (TestPerfTestMetric.test_init_set_time_metric): Ditto.
2875         (TestPerfTestMetric.test_has_values): Ditto.
2876         (TestPerfTestMetric.test_append): Ditto.
2877
2878         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2879         (_generate_results_dict): Only use metrics.
2880         (_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.
2881
2882 2013-11-21  Manuel Rego Casasnovas  <rego@igalia.com>
2883
2884         REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
2885         https://bugs.webkit.org/show_bug.cgi?id=124697
2886
2887         Reviewed by Ryosuke Niwa.
2888
2889         * Scripts/webkitdirs.pm:
2890         (checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
2891         before trying to access to the first element.
2892
2893 2013-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2894
2895         [GTK] Mark all deprecated symbols in GObject DOM bindings
2896         https://bugs.webkit.org/show_bug.cgi?id=124406
2897
2898         Reviewed by Gustavo Noronha Silva.
2899
2900         * Scripts/webkitpy/style/checker.py: Add special case for
2901         WebKitDOMDeprecated.
2902         * gtk/generate-gtkdoc:
2903         (get_webkit2_options): Use the prefix of the methods as namespace,
2904         since this is what gtkdoc expects to sort the index.
2905         (get_webkit1_options): Ditto.
2906         (get_webkitdom_options): Ditto.
2907         * gtk/generate-webkitdom-doc-files:
2908         (WebKitDOMDocGenerator): Add a global list of deleted objects.
2909         (WebKitDOMDocGenerator.write_deleted_classes): New method to write
2910         the documentation for classes that are deprecated because they
2911         have been removed.
2912         (WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
2913         for deleted classes too.
2914         (WebKitDOMDocGeneratorSections.__init__): Build a list of
2915         deprecated symbols using the given symbols file.
2916         (WebKitDOMDocGeneratorSections._deleted_class): Returns the
2917         deleted class corresponding to the given function.
2918         (WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
2919         dictionary of deprecated symbols for every class.
2920         (WebKitDOMDocGeneratorSections.write_section): Add also the
2921         deprecated symbols in every section.
2922         (WebKitDOMDocGeneratorSections.write_deleted_classes): Add
2923         sections for deleted classes too.
2924
2925 2013-11-20  László Langó  <lango@inf.u-szeged.hu>
2926
2927         check-webkit-style should support C++11 rvalue references.
2928         https://bugs.webkit.org/show_bug.cgi?id=123406
2929
2930         Reviewed by Brent Fulgham.
2931
2932         * Scripts/webkitpy/style/checkers/cpp.py:
2933         (check_style):
2934         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2935         (Cpp11StyleTest):
2936         (Cpp11StyleTest.test_rvaule_reference_at_end_of_line):
2937
2938 2013-11-20  Dean Jackson  <dino@apple.com>
2939
2940         Allow settings to be shown/hidden on build.webkit.org/dashboard
2941         https://bugs.webkit.org/show_bug.cgi?id=124694
2942
2943         Reviewed by Tim Horton.
2944
2945         In preparation for more options/buttons, allow the page to
2946         show or hide all the interactive things using a little gear icon
2947         in the top left corner.
2948
2949         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2950         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2951         (Settings.prototype.toggleSettingsDisplay):
2952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2953         (div.cellButton.hide):
2954         (div.cellButton.unhide):
2955         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
2956         (.settings):
2957         (.settings:hover):
2958         (.settings-visible .settings):
2959
2960 2013-11-20  Dean Jackson  <dino@apple.com>
2961
2962         No need to base64 SVG on build.webkit.org/dashboard
2963         https://bugs.webkit.org/show_bug.cgi?id=124687
2964
2965         Reviewed by Tim Horton.
2966
2967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2968         (.status-line.good .bubble.pictogram):
2969
2970 2013-11-20  Dean Jackson  <dino@apple.com>
2971
2972         Make links look more like links on build.webkit.org/dashboard
2973         https://bugs.webkit.org/show_bug.cgi?id=124686
2974
2975         Reviewed by Tim Horton.
2976
2977         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
2978         (.queue-view .queueLabel:hover):
2979         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2980         (.status-line.linked .label:hover):
2981
2982 2013-11-20  Nick Diego Yamane  <nick.yamane@openbossa.org>
2983
2984         Modify webkitdirs to reuse checkForArgumentAndRemoveFromARGV
2985         https://bugs.webkit.org/show_bug.cgi?id=124581
2986
2987         Reviewed by Daniel Bates.
2988
2989         Some subroutines are replicating code from checkForArgument**
2990         functions instead of reusing them as is being done by all other functions.
2991
2992         * Scripts/webkitdirs.pm:
2993         (determineXcodeSDK): Added.
2994         (determinePassedConfiguration): Added.
2995         (determinePassedArchitecture): Added.
2996         (checkForArgumentAndRemoveFromARGV): Added.
2997         (checkForArgumentAndRemoveFromARGVGettingValue): Added.
2998
2999 2013-11-20  Jozsef Berta  <jberta@inf.u-szeged.hu>
3000
3001         Delete baseline optimizer
3002         https://bugs.webkit.org/show_bug.cgi?id=122333
3003
3004         Reviewed by Ryosuke Niwa.
3005
3006         * Scripts/webkitpy/common/checkout/baselineoptimizer.py: Removed.
3007         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: Removed.
3008         * Scripts/webkitpy/tool/commands/rebaseline.py:
3009         (RebaselineTest.execute):
3010         (AbstractParallelRebaselineCommand._files_to_add):
3011         (AbstractParallelRebaselineCommand._rebaseline):
3012         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3013         (TestRebaselineJson.test_rebaseline_all):
3014         (TestRebaselineJson.test_rebaseline_debug):
3015         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
3016
3017 2013-11-20  Anders Carlsson  <andersca@apple.com>
3018
3019         Enable PageLoadTest assertions again
3020         https://bugs.webkit.org/show_bug.cgi?id=124681
3021
3022         Reviewed by Tim Horton.
3023
3024         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3025         Actually install all-content-in-one-iframe.html, noticed while debugging this assertion.
3026
3027 2013-11-20  Mark Rowe  <mrowe@apple.com>
3028
3029         Remove some obsolete logic from WebKit.app.
3030
3031         Reviewed by Alexey Proskuryakov.
3032
3033         * WebKitLauncher/WebKitNightlyEnabler.m:
3034         (poseAsWebKitApp): Remove a pre-10.6 codepath.
3035         (enableWebKitNightlyBehaviour): Remove a 10.4-specific codepath.
3036
3037 2013-11-20  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3038
3039         Moved stray urls from svn.py and statusserver.py into common.config.urls
3040         https://bugs.webkit.org/show_bug.cgi?id=124650
3041
3042         Reviewed by Ryosuke Niwa.
3043
3044         * Scripts/webkitpy/common/checkout/scm/svn.py:
3045         (SVNRepository):
3046         * Scripts/webkitpy/common/config/urls.py:
3047         * Scripts/webkitpy/common/net/statusserver.py:
3048         (StatusServer.__init__):
3049         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3050         (_generate_results_dict):
3051
3052 2013-11-20  Commit Queue  <commit-queue@webkit.org>
3053
3054         Unreviewed, rolling out r159496.
3055         http://trac.webkit.org/changeset/159496
3056         https://bugs.webkit.org/show_bug.cgi?id=124641
3057
3058         It caused warning and build break with cmake lower than 2.8.8
3059         (Requested by ryuan on #webkit).
3060
3061         * MiniBrowser/efl/CMakeLists.txt:
3062
3063 2013-11-20  Gabor Rapcsanyi  <rgabor@webkit.org>
3064
3065         [EFL] libseccomp-2.0.0 doesn't support ARM architecture
3066         https://bugs.webkit.org/show_bug.cgi?id=124412
3067
3068         Reviewed by Gyuyoung Kim.
3069
3070         Update libseccomp to a newer 2.1.0 version.
3071
3072         * efl/jhbuild.modules:
3073
3074 2013-11-19  Mark Rowe  <mrowe@apple.com>
3075
3076         <rdar://problem/15487072> Modernize WebKit.app's OS X version checking logic.
3077
3078         Gestalt is deprecated on recent OS X versions so we should switch off it.
3079
3080         Reviewed by Sam Weinig.
3081
3082         * WebKitLauncher/main.m:
3083         (currentMacOSXVersion): Retrieve the version string from SystemVersion.plist.
3084         (currentMacOSXMajorVersion): Split the version string at the periods, retrieve the first
3085         two components, then join them back up.
3086         (main): Switch to using currentMacOSXMajorVersion to make it clearer which part of
3087         the version we care about.
3088
3089 2013-11-19  Commit Queue  <commit-queue@webkit.org>
3090
3091         Unreviewed, rolling out r159538.
3092         http://trac.webkit.org/changeset/159538
3093         https://bugs.webkit.org/show_bug.cgi?id=124627
3094
3095         it broke run-jsc-stress-tests (Requested by mhahnenberg on
3096         #webkit).
3097
3098         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
3099         * Scripts/run-javascriptcore-tests:
3100         * Scripts/run-jsc-stress-tests:
3101
3102 2013-11-19  Mark Hahnenberg  <mhahnenberg@apple.com>
3103
3104         run-jsc-stress-tests should be able to package its tests and move them places
3105         https://bugs.webkit.org/show_bug.cgi?id=124549
3106
3107         Reviewed by Geoff Garen and Filip Pizlo.
3108
3109         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. This script was just a ruby reimplementation 
3110         of grep -i -q 
3111         * Scripts/run-javascriptcore-tests: Pass through the --make-bundle flag.
3112         * Scripts/run-jsc-stress-tests: Added the new concept of a "bundle", which is a collection of all tests and any
3113         other files that those tests require to run in any environment along with a fixed root directory into which these
3114         files and their expected directory structure are cloned. The default Bundle class is basically 
3115         a no-op so that it functions like run-jsc-stress-tests prior to this patch. MovableBundle is a Bundle that knows 
3116         how to translate local paths to bundle paths and does all the work of moving each test file into the right place 
3117         inside the .tests directory. After all the test files have been created in jsc-stress-results MovableBundle 
3118         creates a tarball of the entire directory for easy relocation. The --make-bundle flag causes run-jsc-stress-tests 
3119         to use MovableBundle instead of just Bundle. 
3120
3121 2013-11-19  Dan Bernstein  <mitz@apple.com>
3122
3123         <rdar://problem/15139479> Reenable the JSC Objective-C API tests on Mountain Lion once the bots are running Xcode 5
3124
3125         Rubber-stamped by Mark Rowe.
3126
3127         Reverted r156840.
3128
3129         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
3130
3131 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
3132
3133         Yet another build fix. Just allow any character.
3134         There are just too many special characters to be listed here.
3135
3136         * Scripts/webkitpy/performance_tests/perftest.py:
3137         (PerfTest._lines_to_ignore_in_parser_result):
3138         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3139         (TestPerfTest.test_parse_output_with_subtests)
3140
3141 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
3142
3143         Another build fix. Allow ':' in subtest names.
3144
3145         * Scripts/webkitpy/performance_tests/perftest.py:
3146         (PerfTest._lines_to_ignore_in_parser_result):
3147         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3148         (TestPerfTest.test_parse_output_with_subtests)
3149
3150 2013-11-19  Ryuan Choi  <ryuan.choi@samsung.com>
3151
3152         [EFL] Use Config mode of find_package for EFL 1.8
3153         https://bugs.webkit.org/show_bug.cgi?id=124555
3154
3155         Reviewed by Gyuyoung Kim.
3156
3157         * MiniBrowser/efl/CMakeLists.txt: Introduced a config mode to find elementary.
3158
3159 2013-11-19  Ryosuke Niwa  <rniwa@webkit.org>
3160
3161         Build fix. Subtest names need to be more permissive.
3162
3163         * Scripts/webkitpy/performance_tests/perftest.py:
3164         (PerfTest._lines_to_ignore_in_parser_result):
3165         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3166         (TestPerfTest.test_parse_output_with_subtests)
3167
3168 2013-11-18  Mark Rowe  <mrowe@apple.com>
3169
3170         Use hw.activecpu for determining how many processes to spawn.
3171
3172         It's documented as the preferred way to determine the number of threads
3173         or processes to create in a SMP aware application.
3174
3175         Rubber-stamped by Tim Horton.
3176
3177         * Scripts/copy-webkitlibraries-to-product-directory:
3178         * Scripts/run-jsc-stress-tests:
3179         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3180
3181 2013-11-18  Tim Horton  <timothy_horton@apple.com>
3182
3183         build.webkit.org/dashboard builder headers should link to the builder page
3184         https://bugs.webkit.org/show_bug.cgi?id=124553
3185
3186         Reviewed by Timothy Hatcher.
3187
3188         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3189         (BuildbotQueue.prototype.get overviewURL):
3190         Add overviewURL(), which returns the URL to the builder overview page, with the last 50 builds shown.
3191
3192         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3193         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture):
3194         (BuildbotBuilderQueueView.prototype.update):
3195         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3196         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3197         (BuildbotTesterQueueView.prototype.update.appendBuild):
3198         (BuildbotTesterQueueView.prototype.update):
3199         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
3200         (.queue-view .queueLabel):
3201         (.queue-view .queueLabel:not(:first-child)):
3202         Make the header a link instead of a label, and wire it up to overviewURL.
3203
3204 2013-11-18  Samuel White  <samuel_white@apple.com>
3205
3206         AX: Add ability to fetch only visible table rows.
3207         https://bugs.webkit.org/show_bug.cgi?id=124430
3208
3209         Reviewed by Chris Fleizach.
3210
3211         Adding method to fetch array of AccessibilityUIElements to help with test brevity and test breakage. Specifically, we
3212         have a good deal of churn any time we add or update an element attribute. This happens because the number of tests
3213         that rely on a simple element description text dump to verify a single attribute is non trivial. So any time you
3214         change add an attribute, you have to update all the tests that are now implicitly verifying this new attribute. But
3215         as the test guidelines state, our tests should be more focused and specific about what they test.
3216
3217         * DumpRenderTree/AccessibilityUIElement.cpp:
3218         (uiElementArrayAttributeValueCallback):
3219         (AccessibilityUIElement::uiElementArrayAttributeValue):
3220         (AccessibilityUIElement::getJSClass):
3221         * DumpRenderTree/AccessibilityUIElement.h:
3222         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3223         (AccessibilityUIElement::uiElementArrayAttributeValue):
3224         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3225         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
3226         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3227         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3228         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3229         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
3230         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3231         (WTR::AccessibilityUIElement::getUIElementsWithAttribute):
3232         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
3233
3234 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
3235
3236         Simplify and reformat the output of performance tests inside test runners
3237         https://bugs.webkit.org/show_bug.cgi?id=124496
3238
3239         Reviewed by Antti Koivisto.
3240
3241         As a preparation to support subtests for Dromaeo and DoYouEvenBench, simplify the output
3242         performance tests generate. Instead of spitting out noise in PerfTestRunner (runner.js)
3243         and ignoring it in PerfTest._filter_output (perftest.py), simply avoid generating it in
3244         the first place.
3245
3246         Also modernize the output to adopt "metric" concept better and make it forward compatible
3247         with subtests.
3248
3249         With this patch, performance tests written using runner.js only produces empty lines or
3250         lines of the following format inside test runners (DumpRenderTree and WebKitTestRunner):
3251         <subtest name> -> [<value 1>, <value 2>, ...]
3252         :<metric name> -> [<value 1>, <value 2>, ...]
3253
3254         This greatly simplifies the parsing logic inside PerfTest._run_with_driver.
3255
3256         * Scripts/webkitpy/performance_tests/perftest.py:
3257         (PerfTest): Removed a bunch of regular expressions that are no longer used.
3258         (PerfTest._run_with_driver): Just parse the values and description and treat everything
3259         else as errors.
3260
3261         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3262         (TestPerfTest.test_parse_output): Removed the junk.
3263         (TestPerfTest._assert_failed_on_line): Extracted from test_parse_output_with_failing_line,
3264         which was removed in favor of the tests below.
3265         (TestPerfTest.test_parse_output_with_running_five_times): Added.
3266         (TestPerfTest.test_parse_output_with_detailed_info): Added.
3267         (TestPerfTest.test_parse_output_with_statistics): Added.
3268         (TestPerfTest.test_parse_output_with_description): Removed the junk.
3269         (TestPerfTest.test_parse_output_with_subtests): Ditto.
3270         (TestSingleProcessPerfTest.test_use_only_one_process): Ditto.
3271
3272         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3273         (EventTargetWrapperTestData): Ditto.
3274         (SomeParserTestData): Ditto.
3275         (MemoryTestData): Ditto.
3276
3277 2013-11-18  Tim Horton  <timothy_horton@apple.com>
3278
3279         Occasionally, hundreds of tests fail with small text diffs on Mavericks
3280         https://bugs.webkit.org/show_bug.cgi?id=124312
3281
3282         Reviewed by Simon Fraser.
3283
3284         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3285         (Manager._set_up_run):
3286         * Scripts/webkitpy/port/base.py:
3287         (Port.to.reset_preferences):
3288         * Scripts/webkitpy/port/mac.py:
3289         (MacPort.reset_preferences):
3290         Delete DumpRenderTree and WebKitTestRunner defaults domains before running tests,
3291         returning some of the functionality of 158652 after 159364 removed it.
3292
3293 2013-11-18  Tim Horton  <timothy_horton@apple.com>
3294
3295         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
3296         https://bugs.webkit.org/show_bug.cgi?id=122909
3297
3298         Reviewed by Alexey Proskuryakov.
3299
3300         Put the checkmark SVG in the CSS file as a data URI so it loads immediately.
3301
3302         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3303         (.status-line .bubble):
3304         (.status-line.good .bubble.pictogram):
3305
3306 2013-11-18  Ryosuke Niwa  <rniwa@webkit.org>
3307
3308         Remove _lines_to_ignore_in_stderr, which was only used in Chromium port
3309         https://bugs.webkit.org/show_bug.cgi?id=124499
3310
3311         Reviewed by Csaba Osztrogonác.
3312
3313         Removed the code. I didn't like this hack back when it was added, and I don't like it today.
3314
3315         * Scripts/webkitpy/performance_tests/perftest.py:
3316         (PerfTest._should_ignore_line):
3317         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3318         (TestPerfTest): Removed the unit test.
3319
3320 2013-11-17  Filip Pizlo  <fpizlo@apple.com>
3321
3322         Unreviewed, fix this script for older Rubies where Pathname doesn't coerce to String
3323         quite as easily.
3324         
3325         With help from Andy Trick.
3326
3327         * Scripts/export-llvm-build:
3328
3329 2013-11-15  Filip Pizlo  <fpizlo@apple.com>
3330
3331         FTL should have an explicit notion of bytecode liveness
3332         https://bugs.webkit.org/show_bug.cgi?id=124181
3333
3334         Reviewed by Mark Hahnenberg.
3335
3336         * Scripts/run-jsc-stress-tests:
3337
3338 2013-11-16  Dan Bernstein  <mitz@apple.com>
3339
3340         No way for policy client to determine if a the response’s MIME type can be shown
3341         https://bugs.webkit.org/show_bug.cgi?id=124445
3342
3343         Reviewed by Sam Weinig.
3344
3345         * MiniBrowser/mac/WK2BrowserWindowController.m:
3346         (decidePolicyForResponse): Added canShowMIMEType parameter.
3347         (-[WK2BrowserWindowController awakeFromNib]): Updated for changes in the policy client.
3348
3349         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3350         (TestWebKitAPI::decidePolicyForResponse): Added canShowMIMEType parameter.
3351
3352         * WebKitTestRunner/TestController.cpp:
3353         (WTR::TestController::createWebViewWithOptions): Updated for changes in the policy client.
3354         (WTR::TestController::decidePolicyForResponse): Added canShowMIMEType parameter.
3355         * WebKitTestRunner/TestController.h:
3356
3357 2013-11-16  Tim Horton  <timothy_horton@apple.com>
3358
3359         Checkmarks are shifted down on iPhone at build.webkit.org/dashboard
3360         https://bugs.webkit.org/show_bug.cgi?id=122909
3361
3362         Reviewed by Timothy Hatcher.
3363
3364         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/checkmark.svg: Added.
3365         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3366         (StatusLineView.prototype.set repeatCount):
3367         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3368         (.status-line.good .bubble.pictogram):
3369         Use an SVG image instead of an obscure font for the checkboxes so they
3370         render identically on all platforms.
3371
3372 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3373
3374         Occasionally, hundreds of tests fail with small text diffs on Mavericks
3375         https://bugs.webkit.org/show_bug.cgi?id=124312
3376
3377         Reviewed by Alexey Proskuryakov.
3378
3379         Try reverting the part of r158652 that deleted all of the persistent
3380         defaults, in the thought that there might be some sort of race between
3381         processes causing some settings to be left in the wrong state.
3382
3383         * DumpRenderTree/mac/DumpRenderTree.mm:
3384         (setDefaultsToConsistentValuesForTesting):
3385         * WebKitTestRunner/mac/main.mm:
3386         (setDefaultsToConsistentValuesForTesting):
3387
3388 2013-11-15  Dan Bernstein  <mitz@apple.com>
3389
3390         Give the policy client the originating frame of a navigation action
3391         https://bugs.webkit.org/show_bug.cgi?id=124431
3392
3393         Reviewed by Anders Carlsson.
3394
3395         * MiniBrowser/mac/WK2BrowserWindowController.m:
3396         (decidePolicyForNavigationAction): Added originatingFrame parameter.
3397         (-[WK2BrowserWindowController awakeFromNib]): Updated for the new version of the policy
3398         client.
3399
3400         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
3401         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
3402         (TestWebKitAPI::setPagePolicyClient): Updated for the new version of the policy client.
3403
3404         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3405         (TestWebKitAPI::decidePolicyForNavigationAction): Added originatingFrame parameter.
3406         (TestWebKitAPI::TEST): Updated for the new version of the policy client.
3407
3408         * WebKitTestRunner/TestController.cpp:
3409         (WTR::TestController::createWebViewWithOptions): Updated for the new version of the policy
3410         client.
3411         (WTR::TestController::decidePolicyForNavigationAction): Added originatingFrame parameter.
3412         * WebKitTestRunner/TestController.h:
3413
3414 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3415
3416         build.webkit.org/dashboard should provide a way to focus on a subset of bots
3417         https://bugs.webkit.org/show_bug.cgi?id=122676
3418
3419         Reviewed by Timothy Hatcher.
3420
3421         Add a small 'hide' button next to every platform logo, and a 'show all'
3422         button which only appears when at least one platform is hidden. Hidden
3423         platforms persist using localStorage.
3424
3425         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3426         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3427         (updateHiddenPlatforms):
3428         (documentReady.unhideButton):
3429         (documentReady.hideButton):
3430         (documentReady):
3431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js: Added.
3432         (Settings.prototype.setObject):
3433         (Settings.prototype.getObject):
3434         (Settings.prototype.addSettingListener):
3435         (Settings.prototype.fireSettingListener):
3436         (Settings.prototype.toggleHiddenPlatform):
3437         (Settings.prototype.clearHiddenPlatforms):
3438         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3439         (div.cellButton):
3440         (div.cellButton.hide):
3441         (.hidden):
3442         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3443
3444 2013-11-15  Jer Noble  <jer.noble@apple.com>
3445
3446         MediaTime addition and subtraction operators have errors when the rhs is infinite.
3447         https://bugs.webkit.org/show_bug.cgi?id=124413
3448
3449         Reviewed by Eric Carlson.
3450
3451         Add a test for operator+ and operator- where an infinite value appears
3452         on the right-hand side:
3453         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3454         (TestWebKitAPI::TEST):
3455
3456         Add a LLDB summary provider for MediaTime which displays the rational
3457         time as well as the value in seconds:
3458         * lldb/lldb_webkit.py:
3459         (__lldb_init_module):
3460         (WTFMediaTime_SummaryProvider):
3461         (WTFHashTableProvider.has_children):
3462         (WTFMediaTimeProvider):
3463         (WTFMediaTimeProvider.__init__):
3464         (WTFMediaTimeProvider.timeValue):
3465         (WTFMediaTimeProvider.timeScale):
3466         (WTFMediaTimeProvider.isInvalid):
3467         (WTFMediaTimeProvider.isPositiveInfinity):
3468         (WTFMediaTimeProvider.isNegativeInfinity):
3469         (WTFMediaTimeProvider.isIndefinite):
3470
3471 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3472
3473         Make it possible to select revision numbers on build.webkit.org/dashboard
3474         https://bugs.webkit.org/show_bug.cgi?id=124400
3475
3476         Reviewed by Timothy Hatcher.
3477
3478         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3479         (BuildbotQueueView.prototype.revisionLinksForIteration):
3480         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3481         (.selectable):
3482         Add a child span to the trac link, which has '-webkit-user-select: all' on it.
3483         This way, a Dashboard user can highlight revision numbers for easy copying,
3484         and doesn't even have to be precise about the selection.
3485
3486 2013-11-15  Tim Horton  <timothy_horton@apple.com>
3487
3488         Adjust and add retina versions of EFL and GTK build.webkit.org/dashboard icons
3489         https://bugs.webkit.org/show_bug.cgi?id=124399
3490
3491         Reviewed by Gustavo Noronha Silva.
3492
3493         Add new EFL and GTK icons (derived from Wikipedia's SVGs) to make new 1x and 2x icons,
3494         with the icons adjusted to have solid backgrounds, to not be squished, and to not
3495         intersect the ring, similar to the Mac icons.
3496
3497         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png:
3498         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Added.
3499         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png:
3500         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK@2x.png: Added.
3501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3502         (documentReady.hideButton):
3503         (documentReady):
3504         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3505         (table.queue-grid tr.platform.linux-gtk img.logo):
3506         (table.queue-grid tr.platform.linux-efl img.logo):
3507
3508 2013-11-15  Stephane Jadaud  <sjadaud@sii.fr>
3509
3510         [GStreamer] Add support for Media Source API
3511         https://bugs.webkit.org/show_bug.cgi?id=99065
3512
3513         Reviewed by Philippe Normand.
3514
3515         * Scripts/webkitperl/FeatureList.pm:
3516
3517 2013-11-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3518
3519         [GTK] Bumping GStreamer version to 1.2.1 for the dependencies
3520         https://bugs.webkit.org/show_bug.cgi?id=124360
3521
3522         Reviewed by Philippe Normand.
3523
3524         * gtk/jhbuild.modules: Bumped GStreamer version up to 1.2.1
3525
3526 2013-11-14  Brent Fulgham  <bfulgham@apple.com>
3527
3528         [Win] Improve support for command line builds of 64-bit JSC
3529         https://bugs.webkit.org/show_bug.cgi?id=124380
3530
3531         Reviewed by David Kilzer.
3532
3533         * Scripts/webkitdirs.pm:
3534         (argumentsForConfiguration): Recognize all flavors of Debug and Release (i.e., 'Debug',
3535         'Debug|Win32', 'Debug|x64') when passing arguments to child processes.
3536         (determinePassedConfiguration): Don't suffix configuration with "|Win32" or "|x64". That's
3537         what the "$configurationForVisualStudio" value is for.
3538
3539 2013-11-14  Oliver Hunt  <oliver@apple.com>
3540
3541         Make CLoop easier to build, and make it work
3542         https://bugs.webkit.org/show_bug.cgi?id=124359
3543
3544         Reviewed by Geoffrey Garen.
3545
3546         Add --cloop support to forcibly enable to CLoop build
3547
3548         * Scripts/build-jsc:
3549         * Scripts/build-webkit:
3550
3551 2013-11-14  Lucas Forschler  <lforschler@apple.com>
3552
3553         Add webkit slave.
3554
3555         Unreviewed.
3556
3557         * BuildSlaveSupport/build.webkit.org-config/config.json:
3558
3559 2013-11-14  Tim Horton  <timothy_horton@apple.com>
3560
3561         build.webkit.org/dashboard can’t open different results in two new tabs
3562         https://bugs.webkit.org/show_bug.cgi?id=124383
3563
3564         Reviewed by Alexey Proskuryakov.
3565
3566         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3567         (BuildbotQueueView.prototype.revisionLinksForIteration):
3568         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3569         (StatusLineView.prototype._clicked):
3570         Use _blank (which is effectively open-in-new-tab, in Safari) instead of _new (which isn't a
3571         real pseudo-target and instead acts as a named target and will end up causing all link clicks
3572         to open in the same secondary tab).
3573
3574 2013-11-14  Anders Carlsson  <andersca@apple.com>
3575
3576         Remove duplicate entry.
3577
3578         * Scripts/webkitpy/common/config/contributors.json:
3579
3580 2013-11-14  Krzysztof Czech  <k.czech@samsung.com>
3581
3582         [ATK] Change WKTR/DRT AX methods to use nullptr 
3583         https://bugs.webkit.org/show_bug.cgi?id=124352
3584
3585         Reviewed by Anders Carlsson.
3586
3587         Change WKTR/DRT accessibility related methods to use nullptr.
3588
3589         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3590         (AccessibilityController::AccessibilityController):
3591         (AccessibilityController::elementAtPoint):
3592         (AccessibilityController::removeNotificationListener):
3593         (AccessibilityController::childElementById):
3594         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:
3595         (AccessibilityNotificationHandler::AccessibilityNotificationHandler):
3596         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3597         (AccessibilityUIElement::elementAtPoint):
3598         (AccessibilityUIElement::linkedUIElementAtIndex):
3599         (AccessibilityUIElement::getChildAtIndex):
3600         (AccessibilityUIElement::titleUIElement):
3601         (AccessibilityUIElement::parentElement):
3602         (AccessibilityUIElement::subrole):
3603         (AccessibilityUIElement::roleDescription):
3604         (AccessibilityUIElement::orientation):
3605         (AccessibilityUIElement::ariaDropEffects):
3606         (AccessibilityUIElement::uiElementForSearchPredicate):
3607         (AccessibilityUIElement::cellForColumnAndRow):
3608         (AccessibilityUIElement::disclosedRowAtIndex):
3609         (AccessibilityUIElement::ariaOwnsElementAtIndex):
3610         (AccessibilityUIElement::ariaFlowToElementAtIndex):
3611         (AccessibilityUIElement::selectedRowAtIndex):
3612         (AccessibilityUIElement::rowAtIndex):
3613         (AccessibilityUIElement::disclosedByRow):
3614         (AccessibilityUIElement::removeNotificationListener):
3615         (AccessibilityUIElement::classList):
3616         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3617         (WTR::AccessibilityController::logAccessibilityEvents):
3618         (WTR::AccessibilityController::resetToConsistentState):
3619         (WTR::childElementById):
3620         (WTR::AccessibilityController::accessibleElementById):
3621         (WTR::AccessibilityController::removeNotificationListener):
3622         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3623         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3624         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3625         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3626         (WTR::AccessibilityUIElement::elementAtPoint):
3627         (WTR::AccessibilityUIElement::childAtIndex):
3628         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
3629         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
3630         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
3631         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
3632         (WTR::AccessibilityUIElement::rowAtIndex):
3633         (WTR::AccessibilityUIElement::selectedChildAtIndex):
3634         (WTR::AccessibilityUIElement::selectedRowAtIndex):
3635         (WTR::AccessibilityUIElement::titleUIElement):
3636         (WTR::AccessibilityUIElement::parentElement):
3637         (WTR::AccessibilityUIElement::disclosedByRow):
3638         (WTR::AccessibilityUIElement::uiElementAttributeValue):
3639         (WTR::AccessibilityUIElement::orientation):
3640         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3641       &nbs