Adding myself to the watchlist to CachedFont
[WebKit-https.git] / Tools / ChangeLog
1 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         Adding myself to the watchlist to CachedFont
4
5         Unreviewed.
6
7         * Scripts/webkitpy/common/config/watchlist:
8
9 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
10
11         [EFL][GTK] Make it possible to get verbose output with ninja
12         https://bugs.webkit.org/show_bug.cgi?id=137606
13
14         Reviewed by Csaba Osztrogonác.
15
16         * Scripts/webkitdirs.pm:
17         (buildCMakeGeneratedProject):
18
19 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
20
21         [EFL] Make it possible to use ninja for EFL build too
22         https://bugs.webkit.org/show_bug.cgi?id=137605
23
24         Reviewed by Csaba Osztrogonác.
25
26         * Scripts/webkitdirs.pm:
27         (generateBuildSystemFromCMakeProject):
28         * efl/install-dependencies:
29
30 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
31
32         [GTK] Minibrowser : Add home buton and keyboard support for home page load
33         https://bugs.webkit.org/show_bug.cgi?id=137486
34
35         Reviewed by Philippe Normand.
36
37         * MiniBrowser/gtk/BrowserWindow.c:
38         (loadHomePage): Callback for home page load.
39         (browser_window_init):
40         * MiniBrowser/gtk/BrowserWindow.h:
41         * MiniBrowser/gtk/main.c:
42         (main):
43
44 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
45
46         import-w3c-tests doesn't prefix property values
47         https://bugs.webkit.org/show_bug.cgi?id=137600
48
49         Reviewed by Bem Jones-Bey.
50
51         Some property values are prefixed in WebKit. Modified the W3C import
52         script in order to prefix property values and not only properties.
53         The patch re-uses most of the already existent logic to prefix
54         properties.
55
56         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
57         from CSSValueKeywords.in and adapt converter to modify both properties
58         and property values.
59         (convert_for_webkit):
60         (_W3CTestConverter.__init__):
61         (_W3CTestConverter.output):
62         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
63         (_W3CTestConverter):
64         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
65         (_W3CTestConverter.add_webkit_prefix_following_regex):
66         (_W3CTestConverter.convert_reference_relpaths):
67         (_W3CTestConverter.convert_style_data):
68         (_W3CTestConverter.convert_attributes_if_needed):
69         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
70         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
71         include checks for property values too.
72         (W3CTestConverterTest.test_read_prefixed_property_list):
73         (verify_no_conversion_happened):
74         (verify_prefixed_properties):
75         (verify_prefixed_property_values):
76         (generate_test_content_properties_and_values):
77         (generate_test_content):
78         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
79         prefixed property values and inform about them.
80         (TestImporter.import_tests):
81         (TestImporter.write_import_log):
82
83 2014-10-13  Jer Noble  <jer.noble@apple.com>
84
85         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
86         https://bugs.webkit.org/show_bug.cgi?id=137533
87
88         Reviewed by Andy Estes.
89
90         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
91
92         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
93         (TestWebKitAPI::isMSEEnabledCallback):
94         (TestWebKitAPI::TEST):
95
96 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
97
98         [Win] Implement a page load profiling tool
99         https://bugs.webkit.org/show_bug.cgi?id=137673
100
101         Reviewed by Dean Jackson.
102
103         Add a tool to capture and summarize page load statistics.
104
105         * WinLauncher/Common.cpp:
106         (parseCommandLine): Move from WinMain.cpp so that it can
107         be shared with internal tools.
108         * WinLauncher/PageLoadTestClient.cpp: Added.
109         (PageLoadTestClient::PageLoadTestClient):
110         (PageLoadTestClient::pageLoadStartedAtTime):
111         (PageLoadTestClient::didStartProvisionalLoad):
112         (PageLoadTestClient::didCommitLoad):
113         (PageLoadTestClient::didFirstLayoutForMainFrame):
114         (PageLoadTestClient::didHandleOnLoadEvents):
115         (PageLoadTestClient::didFinishLoad):
116         (PageLoadTestClient::didFailLoad):
117         (PageLoadTestClient::didInitiateResourceLoad):
118         (PageLoadTestClient::didEndResourceLoad):
119         (PageLoadTestClient::pageLoadEndedAtTime):
120         (PageLoadTestClient::endPageLoad):
121         (PageLoadTestClient::clearPageLoadState):
122         (PageLoadTestClient::shouldConsiderPageLoadEnded):
123         (PageLoadTestClient::maybeEndPageLoadSoon):
124         (PageLoadTestClient::setPageURL):
125         (PageLoadTestClient::dumpRunStatistics):
126         * WinLauncher/PrintWebUIDelegate.cpp:
127         (PrintWebUIDelegate::createWebViewWithRequest): Handle
128         nullptr URL properly.
129         * WinLauncher/ResourceLoadDelegate.cpp: Added.
130         (ResourceLoadDelegate::QueryInterface):
131         (ResourceLoadDelegate::AddRef):
132         (ResourceLoadDelegate::Release):
133         (ResourceLoadDelegate::identifierForInitialRequest):
134         (ResourceLoadDelegate::willSendRequest):
135         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
136         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
137         (ResourceLoadDelegate::didReceiveResponse):
138         (ResourceLoadDelegate::didReceiveContentLength):
139         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
140         (ResourceLoadDelegate::didFailLoadingWithError):
141         (ResourceLoadDelegate::plugInFailedWithError):
142         * WinLauncher/ResourceLoadDelegate.h: Added.
143         (ResourceLoadDelegate::ResourceLoadDelegate):
144         * WinLauncher/WinLauncher.cpp:
145         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
146         page loading statistics.
147         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
148         and set private load delegate state.
149         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
150         that sets the view's resource load delegate.
151         (WinLauncher::loadURL): If no URL is passed, load the test document.
152         * WinLauncher/WinLauncher.h:
153         (WinLauncher::pageLoadTestClient):
154         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
155         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
156         * WinLauncher/WinLauncherWebHost.cpp:
157         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
158         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
159         it could be used from other source files.
160         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
161         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
162         (WinLauncherWebHost::didFailLoadWithError): Ditto.
163         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
164         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
165         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
166         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
167         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
168         * WinLauncher/WinLauncherWebHost.h:
169         * WinLauncher/WinMain.cpp:
170         (wWinMain): Create and use new delegates for gathering page load data.
171         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
172
173 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
174
175         Improve the test image diffs page
176         https://bugs.webkit.org/show_bug.cgi?id=137674
177
178         Reviewed by Alexey Proskuryakov.
179         
180         Don't treat the input file as a format string, otherwise we have to escape special
181         characters. Just do a couple of replaces.
182
183         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
184         (TestResultWriter.write_image_diff_files):
185
186 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
187
188         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
189         https://bugs.webkit.org/show_bug.cgi?id=137659
190
191         Reviewed by Martin Robinson.
192
193         * Scripts/webkitpy/port/xvfbdriver.py:
194         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
195
196 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
197
198         Add more detailed wait time information to EWS metrics
199         https://bugs.webkit.org/show_bug.cgi?id=137649
200
201         Reviewed by Daniel Bates.
202
203         Added average and worst time (we used to only have median), and also a percentage
204         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
205
206         There is always some wait due to the polling nature of the queues, which is well understood
207         and doesn't need to be measured. What needs to be measured is whether there is enough
208         bot machines to process patches as soon as they are submitted.
209
210         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
211         (Analyzer.prototype._analyzeBubblePerformance):
212         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
213         (MetricsBubbleView.prototype._update):
214
215 2014-10-11  Jer Noble  <jer.noble@apple.com>
216
217         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
218         https://bugs.webkit.org/show_bug.cgi?id=137533
219
220         Reviewed by Darin Adler.
221
222         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
223         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
224         (TestWebKitAPI::TEST):
225         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
226         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
227
228 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
229
230         iOS DRT snapshots are limited to the page visible area
231         https://bugs.webkit.org/show_bug.cgi?id=137650
232
233         Reviewed by Daniel Bates.
234         
235         LegacyTileCache drawing was limited to the window's visible area, found by
236         crawling up the layer hierarchy to the root layer. This caused test snapshots to
237         be missing non-composited content outside the iPhone visible area, which hinders
238         testing.
239         
240         Fix by adding a test-only mode where the window visible area is the entire window.
241         
242         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
243         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
244         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
245         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
246         for the DRT window.
247         
248
249 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
250
251         Page not fully rendered in iOS DRT snapshots
252         https://bugs.webkit.org/show_bug.cgi?id=137638
253
254         Reviewed by Tim Horton.
255         
256         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
257         to ensure that the page has laid out and is rendered by the time we take
258         the snapshot.
259
260         * DumpRenderTree/mac/DumpRenderTree.mm:
261         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
262         (-[DumpRenderTree _webThreadInvoked]): Moved.
263         (-[DumpRenderTree _waitForWebThreadThenDump]):
264         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
265         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
266         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
267         relies on dispatch_async too, and the inner block won't complete until the outer block
268         has completed.
269         (dumpTestResults): Move the guts of dump() here.
270         (runTest): Whitespace.
271
272 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
273
274         Adding svn:ignore so that .pyc files don't show up as new.
275
276         * Scripts/webkitpy/xcode: Added property svn:ignore.
277
278 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
279
280         [EFL] Introduce EWebKit_Extension
281         https://bugs.webkit.org/show_bug.cgi?id=134921
282
283         Reviewed by Gyuyoung Kim.
284
285         * MiniBrowser/efl/main.c: Added x option to test extension path.
286         (window_create):
287         (elm_main):
288         * Scripts/webkitpy/common/config/watchlist:
289         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
290         * Scripts/webkitpy/style/checker.py:
291         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
292
293 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
294
295         After r174628 we send the test process a SIGTERM before the SIGKILL.
296
297         * Scripts/webkitpy/common/system/executive_unittest.py:
298         (ExecutiveTest.serial_test_kill_process):
299
300 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
301
302         [EFL] Enable WebP support.
303         https://bugs.webkit.org/show_bug.cgi?id=136156
304
305         Reviewed by Gyuyoung Kim.
306
307         Include libwebp-dev package to support WebP for WK2 Efl.
308
309         * efl/install-dependencies:
310
311 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
312
313         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
314         https://bugs.webkit.org/show_bug.cgi?id=137485
315
316         Reviewed by Sergio Villar Senin.
317
318         Update GMainLoopSource tests. Most of the tests are now run twice,
319         first with a GMainLoopSource and then with a
320         GThreadSafeMainLoopSource, since both should have the same
321         behaviour. The threading test uses GThreadSafeMainLoopSource and
322         the delete on destroy test uses GMainLoopSource. The tests
323         themselves haven't changed, since there's no change in behaviour.
324
325         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
326         (TestWebKitAPI::GMainLoopSourceTest::source):
327         (TestWebKitAPI::basicRescheduling):
328         (TestWebKitAPI::TEST):
329         (TestWebKitAPI::reentrantRescheduling):
330         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
331         (TestWebKitAPI::basicDestroyCallbacks):
332         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
333         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
334
335 2014-10-10  Dana Burkart  <dburkart@apple.com>
336
337         Fix fat-fingered function name in git-add-reviewer.
338
339         Unreviewed.
340
341         * Scripts/git-add-reviewer:
342         (getConfigValue):
343
344 2014-10-10  David Farler  <dfarler@apple.com>
345
346         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
347         https://bugs.webkit.org/show_bug.cgi?id=137528
348
349         Reviewed by Simon Fraser.
350
351         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
352         and SIGKILL the paired simulator app before exiting cleanly.
353
354         webkitpy only uses SIGKILL to kill processes which you cannot
355         catch. Send SIGTERM to the process and give it chance to do
356         its thing before sending SIGKILL. Sending a SIGKILL to an already
357         dead PID is safe.
358
359         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
360         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
361         (-[LTRelayController finish]):
362         * LayoutTestRelay/LayoutTestRelay/main.m:
363         (receivedSignal):
364         (main):
365
366 2014-10-10  David Farler  <dfarler@apple.com>
367
368         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
369         https://bugs.webkit.org/show_bug.cgi?id=137527
370
371         Reviewed by Simon Fraser.
372
373         NSFileHandle doesn't notify of EOF in its readability handler.
374         Use a dispatch_source_t and an event handler that is called when reading is possible.
375         In the handler block, do a run-of-the-mill read(2) from standard input and
376         detect EOF in the usual way by checking that zero bytes were read.
377
378         Once an EOF is received, the FIFOs are disconnected, the simulator app
379         is killed, and the relay exits with status 0.
380
381         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
382         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
383         (-[LTRelayController didDisconnect]):
384         (-[LTRelayController didConnect]):
385         (-[LTRelayController launchApp]):
386         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
387         confusion with this new dispatch source, called "standardInputDispatchSource".
388         (-[LTRelayController finish]): Added.
389         (-[LTRelayController readFileHandle:]): Deleted.
390
391 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
392
393         [EFL] Crash on facebook.com
394         https://bugs.webkit.org/show_bug.cgi?id=137562
395
396         Reviewed by Chris Dumez.
397
398         Crash occurs on the facebook.com when the webview is resized
399         after the <select> item is clicked but no item is chosen.
400         This crash is just caused by the reference of invalidated variable.
401         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
402         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
403         on MiniBrowser is called.
404         As a result, just set ewk_menu to NULL in order to prevent crash condition.
405
406         * MiniBrowser/efl/main.c:
407         (on_popup_menu_hide):
408
409 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
410
411         A small wording change for clarity.
412
413         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
414         (MetricsBubbleView.prototype._update):
415
416 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
417
418         Dashboard metrics page should have EWS statistics
419         https://bugs.webkit.org/show_bug.cgi?id=137626
420
421         Reviewed by Ryosuke Niwa.
422
423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
424         (BubbleQueue): Put shortName in the object, so that it's actually useful.
425
426         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
427         (BubbleQueueServer): Re-ordered queues to match bubble order.
428         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
429         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
430
431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
432         Added analysis for bubble queues.
433
434         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
435
436         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
437         (buildBubbleQueuesTable): Build the UI.
438
439         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
440         Added JS sources to load.
441
442         * QueueStatusServer/app.yaml: To update app version.
443
444         * QueueStatusServer/handlers/processingtimesjson.py: Added.
445
446         * QueueStatusServer/main.py: Added a handler for processing-times-json.
447
448 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
449
450         REGRESSION: Commit queue doesn't process rollouts
451         https://bugs.webkit.org/show_bug.cgi?id=137623
452
453         Reviewed by Tim Horton.
454
455         * QueueStatusServer/app.yaml:
456         * QueueStatusServer/handlers/updateworkitems.py:
457         (UpdateWorkItems._work_items_from_request):
458
459 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
460
461         Fix syntax error after r174601.
462
463         * Scripts/run-javascriptcore-tests:
464
465 2014-10-10  Michael Saboff  <msaboff@apple.com>
466
467         Add ability to select tarfile name in run-jsc-stress-tests
468         https://bugs.webkit.org/show_bug.cgi?id=137614
469
470         Reviewed by Mark Hahnenberg.
471
472         Added optional file name argument to the --tarball option.  
473
474         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
475         extra test given after the options wont be used for the optional tarball file name.
476         * Scripts/run-jsc-stress-tests:
477
478 2014-10-10  Chris Dumez  <cdumez@apple.com>
479
480         Unreviewed, update my information in contributors.json
481
482         Use my preferred first name and update my expertise areas.
483
484         * Scripts/webkitpy/common/config/contributors.json:
485
486 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
487
488         Fix perl scripts to run with env on Linux
489         https://bugs.webkit.org/show_bug.cgi?id=137601
490
491         Reviewed by Csaba Osztrogonác.
492
493         Use of arguments in #! is nonstandard and does not behave the same on
494         different systems. Linux would look for an executable named "perl -w" 
495         "use warnings;" does the same things in a more portable way.
496
497         * Scripts/commit-log-editor:
498         * Scripts/num-cpus:
499         * Scripts/prepare-ChangeLog:
500         * Scripts/run-launcher:
501         * Scripts/svn-create-patch:
502
503 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
504
505         [jhbuild] We should be able to disable wiping on configuration change
506         https://bugs.webkit.org/show_bug.cgi?id=137446
507
508         Reviewed by Csaba Osztrogonác.
509
510         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
511         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
512         or passing --no-wipe-on-change command line option.
513
514         * Scripts/update-webkit-libs-jhbuild:
515
516 2014-10-09  Andy Estes  <aestes@apple.com>
517
518         Teach webkitpy about OS X Yosemite
519         https://bugs.webkit.org/show_bug.cgi?id=137585
520
521         Reviewed by Simon Fraser.
522
523         * Scripts/webkitpy/common/system/platforminfo.py:
524         (PlatformInfo._determine_mac_version):
525         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
526         (TestPlatformInfo.test_os_version):
527         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
528         (TestExpectationParser):
529         * Scripts/webkitpy/port/builders.py:
530         * Scripts/webkitpy/port/mac.py:
531         (MacPort):
532         * Scripts/webkitpy/port/mac_unittest.py:
533         (test_versions):
534         (test_baseline_search_path):
535         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
536         (TestRebaselineTest.test_baseline_directory):
537         (TestRebaselineExpectations.test_rebaseline_expectations):
538
539 2014-10-09  Dana Burkart  <dburkart@apple.com>
540
541         Add Mac OS Yosemite dashboard support.
542
543         Rubber-stamped by Lucas Forschler.
544
545         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
548         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
549         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
550
551 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
552
553         Add Babak to contributors.json and add historical email addresses for some contributors
554         https://bugs.webkit.org/show_bug.cgi?id=137546
555
556         Reviewed by Christophe Dumez.
557
558         contributors.json is used to analyze historical commit data and change logs.
559
560         Add back historical email addresses for some contributors and also add Babak (Shafiei).
561
562         * Scripts/webkitpy/common/config/contributors.json:
563
564 2014-10-09  Lucas Forschler  <lforschler@apple.com>
565
566         Add Mac OS Yosemite webkit build infrastructure.
567         
568         This patch adds 15 bots to our build.webkit.org configuration.
569         We are matching the current Mavericks machines 1:1.
570         
571         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
572         
573         Reviewed by Matt Hanson.
574
575         * BuildSlaveSupport/build.webkit.org-config/config.json:
576
577 2014-10-09  Dana Burkart  <dburkart@apple.com>
578
579         Don't use backticks when running commands, as we run into sh-related
580         interpolation issues. Also, fix our usage of system() to properly
581         retrieve the status code.
582         https://bugs.webkit.org/show_bug.cgi?id=137541
583
584         Reviewed by Darin Adler.
585
586         * Scripts/git-add-reviewer:
587         (interactive):
588         (nonInteractive):
589         (requireCleanWorkTree):
590         (cherryPick):
591         (commit):
592         (addReviewerToFile):
593         (head):
594         (isAncestor):
595         (toCommit):
596         (changeLogsForCommit):
597         (resetToCommit):
598         (getConfigValue):
599         (runCommandWithOutput):
600
601 2014-10-09  Tim Horton  <timothy_horton@apple.com>
602
603         Add a WebKit1 preference for selection services
604         https://bugs.webkit.org/show_bug.cgi?id=137498
605         <rdar://problem/18572699>
606
607         Reviewed by Simon Fraser.
608
609         * MiniBrowser/mac/WK1BrowserWindowController.m:
610         (-[WK1BrowserWindowController awakeFromNib]):
611         Turn on image and selection services in the Legacy WebKit MiniBrowser.
612
613 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
614
615         Get the patch scripts running on Haiku
616         https://bugs.webkit.org/show_bug.cgi?id=137559
617
618         Reviewed by Benjamin Poulain.
619
620         Use /usr/bin/env instead of hardcoding path to perl.
621         Declare haiku platform in platforminfo.py to avoid check-webkit-style
622         failure.
623
624         * Scripts/commit-log-editor:
625         * Scripts/num-cpus:
626         * Scripts/prepare-ChangeLog:
627         * Scripts/run-launcher:
628         * Scripts/svn-create-patch:
629         * Scripts/webkitpy/common/system/platforminfo.py:
630         (PlatformInfo._determine_os_name):
631
632 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
633
634         StyleQueue should throw a PatchIsNotValid exception to achieve
635         consistency with CommitQueue and EWS
636         https://bugs.webkit.org/show_bug.cgi?id=137500
637
638         Reviewed by Alexey Proskuryakov.
639
640         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
641         Adds a call to validate() in run().
642         (StyleQueueTask.run):
643         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
644         Adds a return False in the patch is not valid exception statement.
645         (AbstractEarlyWarningSystem.review_patch):
646         * Scripts/webkitpy/tool/commands/queues.py:
647         Adds a return False in the patch is not valid exception statement in
648         commit queue, and adds an except statement to catch PatchIsNotValid
649         exceptions in style queue.
650         (CommitQueue.process_work_item):
651         (StyleQueue.review_patch):
652
653 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
654
655         Race condition with WebKitWebView:is-loading after starting page load
656         https://bugs.webkit.org/show_bug.cgi?id=136692
657
658         Reviewed by Gustavo Noronha Silva.
659
660         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
661         (loadChangedCallback): Only check is-loading is false when load
662         has finished if the load didn't fail due to a cancellation.
663         (loadFailedCallback): Only check is-loading is false if the load
664         didn't fail due to a cancellation.
665         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
666         (WebViewTest::loadURI): Check is-loading is true and active URI is
667         the requested one rigth after requesting the load.
668         (WebViewTest::loadHtml): Ditto.
669         (WebViewTest::loadPlainText): Ditto.
670         (WebViewTest::loadBytes): Ditto.
671         (WebViewTest::loadRequest): Ditto.
672         (WebViewTest::loadAlternateHTML): Ditto.
673         (WebViewTest::goBack): Ditto.
674         (WebViewTest::goForward): Ditto.
675         (WebViewTest::goToBackForwardListItem): Ditto.
676
677 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
678
679         [Win] Resolve various static analyzer warnings in Tools.
680         https://bugs.webkit.org/show_bug.cgi?id=137534
681
682         Reviewed by Dean Jackson.
683
684         * DumpRenderTree/cg/ImageDiffCG.cpp:
685         (main): User proper printf specifiers.
686         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
687         (AccessibilityUIElement::childrenCount): Handle possibility that
688         gcc_accChildCount returns with an error.
689         (accessibilityState): Ditto for gcc_accState.
690         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
691         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
692         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
693         be treated as such.
694         * DumpRenderTree/win/DumpRenderTree.cpp:
695         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
696         by comparing an unsigned value as being greater-than zero.
697         * DumpRenderTree/win/EditingDelegate.cpp:
698         (dump): Pass proper character pointer type to printf.
699         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
700         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
701         (EditingDelegate::shouldInsertNode): Ditto.
702         (EditingDelegate::shouldInsertText): Ditto.
703         (EditingDelegate::shouldDeleteDOMRange): Ditto.
704         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
705         (EditingDelegate::shouldApplyStyle): Ditto.
706         * DumpRenderTree/win/EventSender.cpp:
707         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
708         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
709         system headers.
710         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
711         from CreateDIBSection.
712         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
713         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
714         older versions of MSVC we no longer support.
715         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
716         for 64-bit builds.
717         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
718         * TestWebKitAPI/TestsController.h: Ditto.
719         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
720         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
721         performing bitwise | before the comparison is done.
722
723 2014-10-08  Ada Chan  <adachan@apple.com>
724
725         Add a test for WKPageIsPlayingAudio().
726         https://bugs.webkit.org/show_bug.cgi?id=137048
727
728         Reviewed by Darin Adler.
729
730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
731         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
732         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
733         (TestWebKitAPI::nullJavaScriptCallback):
734         (TestWebKitAPI::didFinishLoadForFrame):
735         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
736         (TestWebKitAPI::setUpClients):
737         (TestWebKitAPI::TEST):
738         This test loads a page with a video in it. When the page is loaded, we first check that
739         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
740         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
741         now returns true for the page.
742         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
743         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
744         This is a video copied from LayoutTests/media/content.
745
746 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
747
748         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
749         https://bugs.webkit.org/show_bug.cgi?id=137516
750
751         Reviewed by Alexey Proskuryakov.
752
753         * Scripts/webkitpy/thirdparty/__init__.py:
754         (AutoinstallImportHook._install_irc):
755
756 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
757
758         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
759         https://bugs.webkit.org/show_bug.cgi?id=137520
760
761         Reviewed by Philippe Normand.
762
763         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
764         For other distributions, we are already installing libjpeg-turbo.
765         So, do the same for Debian and derivatives.
766
767         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
768
769 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
770
771         [webkitpy] Add back the workaround to replace ZipFile.extractall()
772         https://bugs.webkit.org/show_bug.cgi?id=137519
773
774         Reviewed by Csaba Osztrogonác.
775
776         It was removed by <http://trac.webkit.org/changeset/174266>,
777         because the comment stated it is a workaround for buggy python
778         2.6.1 which shipped on Snow Leopard. But it turned out the bug
779         is still valid with python 2.7 shipped on the latest Ubuntu
780         (12.04 and 14.04) and OS X 10.9.
781
782         * Scripts/webkitpy/common/system/autoinstall.py:
783         (AutoInstaller):
784         (AutoInstaller._extract_all):
785         (AutoInstaller._unzip):
786
787 2014-10-08  Commit Queue  <commit-queue@webkit.org>
788
789         Unreviewed, rolling out r174335.
790         https://bugs.webkit.org/show_bug.cgi?id=137515
791
792         It broke EFL layout test totally (Requested by gyuyoung on
793         #webkit).
794
795         Reverted changeset:
796
797         "[EFL] Introduce EWebKit_Extension"
798         https://bugs.webkit.org/show_bug.cgi?id=134921
799         http://trac.webkit.org/changeset/174335
800
801 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
802
803         [GTK] Make forwarding headers generation depend on source code
804         https://bugs.webkit.org/show_bug.cgi?id=137394
805
806         Reviewed by Philippe Normand.
807
808         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
809         * TestWebKitAPI/PlatformGTK.cmake: Only run
810         generate-forwarding-headers.pl when source code changes.
811         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
812
813 2014-10-07  Tanay C  <tanay.c@samsung.com>
814
815         Remove build warnings in Hashmap API tests
816         https://bugs.webkit.org/show_bug.cgi?id=137484
817
818         Reviewed by Darin Adler.
819
820         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
821         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
822
823 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
824
825         Commit queue doesn't drop obsolete patches sometimes
826         https://bugs.webkit.org/show_bug.cgi?id=137460
827
828         Reviewed by Alexey Proskuryakov.
829
830         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
831         Adds another test patch for use in queues_unittest.py.
832         courtesy of Csaba Osztrogonác <ossy@webkit.org>
833         (MockBugzilla):
834         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
835         Raises a PatchIsNotValid exception in the case of validate() returning
836         false.
837         (CommitQueueTask.run):
838         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
839         Raises a PatchIsNotValid exception in the case of validate() returning
840         false.
841         (EarlyWarningSystemTask.run):
842         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
843         Defines PatchIsNotValid exception. 
844         (PatchIsNotValid):
845         (PatchIsNotValid.__init__):
846         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
847         Remove call to validate() and instead catches the PatchIsNotValid
848         exception.
849         (AbstractEarlyWarningSystem.review_patch):
850         * Scripts/webkitpy/tool/commands/queues.py:
851         Adds logic to catch the PatchIsNotValid exception.
852         (CommitQueue.process_work_item):
853         * Scripts/webkitpy/tool/commands/queues_unittest.py:
854         Adds the test_non_valid_patch test to ensure that invalid patches are
855         handled properly, and don't just result in indefinite spinning.
856         courtesy of Csaba Osztrogonác <ossy@webkit.org>
857         (test_non_valid_patch):
858
859 2014-10-07  Daniel Bates  <dabates@apple.com>
860
861         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
862         https://bugs.webkit.org/show_bug.cgi?id=137499
863
864         Reviewed by Simon Fraser.
865
866         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
867         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
868         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
869         bit simulator builds of iOS WebKit.
870
871         * Scripts/webkitpy/port/ios.py:
872         (IOSSimulatorPort._generate_all_test_configurations):
873
874 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
875
876         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
877         https://bugs.webkit.org/show_bug.cgi?id=137482
878
879         Reviewed by Martin Robinson.
880
881         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
882
883 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
884
885         [SOUP] TLS errors should take precedence over HTTP authentication
886         https://bugs.webkit.org/show_bug.cgi?id=137300
887
888         Reviewed by Sergio Villar Senin.
889
890         Add a test case to check that authenticate signal is not emitted
891         in case of TLS errors, and the load fails instead.
892
893         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
894         (webViewAuthenticationCallback):
895         (testTLSErrorsHTTPAuth):
896         (httpsServerCallback):
897         (beforeAll):
898
899 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
900
901         Make webkit-patch find-users useful
902         https://bugs.webkit.org/show_bug.cgi?id=137475
903
904         Reviewed by Alexey Proskuryakov.
905
906         Make find-users use the CommitterList instead of accessing Bugzilla.
907
908         This essentially exposes the same functionality as webkitbot's whois command.
909
910         * Scripts/webkitpy/tool/commands/findusers.py:
911         (FindUsers.execute):
912
913 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
914
915         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
916         https://bugs.webkit.org/show_bug.cgi?id=137289
917
918         Unreviewed build fix.
919
920         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
921         (AccessibilityUIElement::getChildrenWithRange):
922
923 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
924
925         build.webkit.org/dashboard: Add commit queue
926         https://bugs.webkit.org/show_bug.cgi?id=137462
927
928         Reviewed by Tim Horton.
929
930         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
931         Style queue is still invisible, as it doesn't have an associated platform, and also
932         we never have problems with it anyway, so it's not worth watching.
933
934         The UI now allows for adding more bots to the Other column (such as leaks bot).
935         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
936         sources of data in a cell.
937
938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
939         (BubbleQueue):
940         (BubbleQueue.prototype.get statusPageURL):
941         (BubbleQueue.prototype.update):
942         (BubbleQueue.prototype.loadDetailedStatus):
943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
944         (BubbleQueueServer):
945         (BubbleQueueServer.prototype.jsonQueueLengthURL):
946         (BubbleQueueServer.prototype.jsonQueueStatusURL):
947         (BubbleQueueServer.prototype.queueStatusURL):
948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
949         (BubbleQueueView):
950         (BubbleQueueView.prototype.update.appendQueue):
951         (BubbleQueueView.prototype.update):
952         (BubbleQueueView.prototype._addQueueHeadingToPopover):
953         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
954         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
955         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
956         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
958         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
959         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
960         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
961         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
962         (.bubble-server-popover .latest-status-no-link):
963         (.bubble-server-popover .bot-status-description):
964         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
965
966         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
967         (buildAggregateTable):
968         (buildQueuesTable):
969         Removed dysfunctional support for EWS for now. It will be different.
970
971 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
972
973         One more case of incorrect comparison in recordpatchevent.py
974         https://bugs.webkit.org/show_bug.cgi?id=137459
975
976         Reviewed by Tim Horton.
977
978         * QueueStatusServer/app.yaml:
979         * QueueStatusServer/loggers/recordpatchevent.py:
980         (RecordPatchEvent.started):
981
982 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
983
984         webkit-queues PatchLog is incorrect for patches that took less than a second
985         https://bugs.webkit.org/show_bug.cgi?id=137453
986
987         Reviewed by Tim Horton.
988
989         * QueueStatusServer/app.yaml: Updated app version.
990
991         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
992         Don't bail out for patches that took 0 seconds to process (as frequently happens
993         when a patch is obsolete).
994
995 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
996
997         EWS bubble hover shows wrong timestamps
998         https://bugs.webkit.org/show_bug.cgi?id=137252
999
1000         Reviewed by Alexey Proskuryakov.
1001
1002         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
1003
1004         * QueueStatusServer/handlers/queuestatusjson.py:
1005         (QueueStatusJSON.get):
1006         * QueueStatusServer/handlers/statusbubble.py:
1007         (StatusBubble._iso_time):
1008
1009 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
1010
1011         Unreviewed, updated list of email addresses in contributors.json
1012
1013         * Scripts/webkitpy/common/config/contributors.json: Added my former
1014         email address in Igalia, for the sake of completeness.
1015
1016 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1017
1018         Unreviewed, moved myself to the list of committers.
1019
1020         * Scripts/webkitpy/common/config/contributors.json:
1021
1022 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
1023
1024         [EFL] Introduce EWebKit_Extension
1025         https://bugs.webkit.org/show_bug.cgi?id=134921
1026
1027         Reviewed by Gyuyoung Kim.
1028
1029         * MiniBrowser/efl/main.c: Added x option to test extension path.
1030         (window_create):
1031         (elm_main):
1032         * Scripts/webkitpy/common/config/watchlist:
1033         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
1034         * Scripts/webkitpy/style/checker.py:
1035         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
1036
1037 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
1038
1039         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
1040         https://bugs.webkit.org/show_bug.cgi?id=137390
1041
1042         Reviewed by Carlos Garcia Campos.
1043
1044         * Scripts/update-webkit-libs-jhbuild:
1045
1046 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1047
1048         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
1049         https://bugs.webkit.org/show_bug.cgi?id=137391
1050
1051         Reviewed by Martin Robinson.
1052
1053         Add a custom command to only re-generate
1054         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
1055
1056         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1057
1058 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1059
1060         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
1061         https://bugs.webkit.org/show_bug.cgi?id=135502
1062
1063         Reviewed by Martin Robinson.
1064
1065         When writing to stdout/stderr fails due to a UnicodeDecodeError
1066         exception, try again without encoding the output.
1067
1068         * gtk/gtkdoc.py:
1069         (GTKDoc._run_command):
1070
1071 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1072
1073         Bugzilla status bubble displays an exception showing attachment 175738
1074         https://bugs.webkit.org/show_bug.cgi?id=137410
1075
1076         Reviewed by Tim Horton.
1077
1078         * QueueStatusServer/app.yaml: Update version.
1079
1080         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
1081         Don't fail even if expected status message is missing.
1082
1083         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
1084         the field in the same way it's defined in QueueStatus table.
1085
1086 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1087
1088         Record latest message in PatchLog for quick access
1089         https://bugs.webkit.org/show_bug.cgi?id=137405
1090
1091         Fixing a typo.
1092
1093         * QueueStatusServer/app.yaml:
1094         * QueueStatusServer/handlers/releasepatch.py:
1095
1096 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1097
1098         Record latest message in PatchLog for quick access
1099         https://bugs.webkit.org/show_bug.cgi?id=137405
1100
1101         Reviewed by Ryosuke Niwa.
1102
1103         It's no SQL...
1104
1105         * QueueStatusServer/handlers/releasepatch.py:
1106         * QueueStatusServer/handlers/updatestatus.py:
1107         * QueueStatusServer/loggers/recordpatchevent.py:
1108         * QueueStatusServer/model/patchlog.py:
1109
1110 2014-10-02  David Farler  <dfarler@apple.com>
1111
1112         -asan-blacklist option also renamed to generic -fsanitize-blacklist
1113         https://bugs.webkit.org/show_bug.cgi?id=137377
1114
1115         Reviewed by Daniel Bates.
1116
1117         * asan/asan.xcconfig:
1118         -asan-blacklist -> -fsanitize-blacklist
1119
1120         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
1121
1122 2014-10-03  Roger Fong  <roger_fong@apple.com>
1123
1124         [Windows] Include batch size argument to layout tests on Windows.
1125
1126         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1127         (RunWebKitTests.start): 
1128         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
1129         These crashes seem to happen on random tests though generally in a spread out fashion.
1130         It seems possible that the DRT instance is being clobbered somehow after running too many
1131         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
1132
1133 2014-10-03  Roger Fong  <roger_fong@apple.com>
1134
1135         [Windows] Settle for 2 chid processes running NRWT on Windows.
1136
1137         * Scripts/webkitpy/port/win.py:
1138         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
1139
1140 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
1141
1142         [GTK] Bump up and patch dependencies to allow building for aarch64
1143         https://bugs.webkit.org/show_bug.cgi?id=137147
1144
1145         Reviewed by Martin Robinson.
1146
1147         The currently used versions of pixman, libffi, librsvg, glib,
1148         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
1149         and/or build for aarch64, so they are bumped up and patched where
1150         necessary. Wherever possible, the same versions and patches were used as
1151         for the EFL port bump-up
1152         (https://bugs.webkit.org/show_bug.cgi?id=135885).
1153
1154         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
1155         regression by crashing http/tests/media/video-redirect.html . A patch
1156         already in upstream fixes that bug.
1157
1158         This change does not touch xserver, which also needs bumping up, but 
1159         will be dealt with later.
1160
1161         * gtk/jhbuild.modules:
1162         Specified versions and patches necessary to correctly build for aarch64.
1163         * gtk/patches/gst-events-arent-gstobjects.patch:
1164         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
1165         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
1166         Added. Patches gst-plugins-base to configure correctly for aarch64.
1167         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
1168         Added. Bumps up config.guess and config.sub in librsvg to recognize
1169         aarch64.
1170         * gtk/patches/libxml2-2.9.0-dtd.patch:
1171         Removed. Not necessary for libxml2 v2.9.1 anymore.
1172
1173 2014-09-28  Sam Weinig  <sam@webkit.org>
1174
1175         Remove RefPtrHashMap
1176         https://bugs.webkit.org/show_bug.cgi?id=137200
1177
1178         Reviewed by Darin Adler.
1179
1180         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1181         (TestWebKitAPI::TEST):
1182         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
1183         a minimum of refcount churn occurs.
1184
1185 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1186
1187         Remove workarounds for versions of Python before 2.7
1188         https://bugs.webkit.org/show_bug.cgi?id=137338
1189
1190         Reviewed by Csaba Osztrogonác.
1191
1192         * Scripts/webkitpy/common/system/autoinstall.py:
1193         (AutoInstaller._extract_targz):
1194         (AutoInstaller._unzip):
1195         (AutoInstaller): Deleted.
1196         (AutoInstaller._extract_all): Deleted.
1197         * Scripts/webkitpy/common/webkitunittest.py:
1198         (TestCase.setUp): Deleted.
1199         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1200         (TestConfigurationConverter.collapse_macros):
1201         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1202         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1203         (TestConfigurationConverter):
1204         (TestConfigurationConverter.combinations): Deleted.
1205         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1206         * Scripts/webkitpy/port/base.py:
1207
1208 2014-10-03  Commit Queue  <commit-queue@webkit.org>
1209
1210         Unreviewed, rolling out r174264.
1211         https://bugs.webkit.org/show_bug.cgi?id=137392
1212
1213         It broke run-webkit-tests (Requested by ebalazsfalvi on
1214         #webkit).
1215
1216         Reverted changeset:
1217
1218         "Remove workarounds for versions of Python before 2.7"
1219         https://bugs.webkit.org/show_bug.cgi?id=137338
1220         http://trac.webkit.org/changeset/174264
1221
1222 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1223
1224         Remove workarounds for versions of Python before 2.7
1225         https://bugs.webkit.org/show_bug.cgi?id=137338
1226
1227         Reviewed by Csaba Osztrogonác.
1228
1229         * Scripts/webkitpy/common/system/autoinstall.py:
1230         (AutoInstaller._extract_targz):
1231         (AutoInstaller._unzip):
1232         (AutoInstaller): Deleted.
1233         (AutoInstaller._extract_all): Deleted.
1234         * Scripts/webkitpy/common/webkitunittest.py:
1235         (TestCase.setUp): Deleted.
1236         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1237         (TestConfigurationConverter.collapse_macros):
1238         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1239         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1240         (TestConfigurationConverter):
1241         (TestConfigurationConverter.combinations): Deleted.
1242         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1243         * Scripts/webkitpy/port/base.py:
1244         * Scripts/webkitpy/port/driver.py:
1245         (ContentBlock.__init__):
1246         * Scripts/webkitpy/port/server_process.py:
1247         (ServerProcess._reset):
1248
1249 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1250
1251         Remove autoinstaller workaround for python 2.6
1252         https://bugs.webkit.org/show_bug.cgi?id=137343
1253
1254         Reviewed by Daniel Bates.
1255
1256         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
1257         2.6, nor Snow Leopard is supported anymore, so the workaround is not
1258         needed anymore.
1259
1260         * Scripts/webkitpy/common/system/autoinstall.py:
1261         (AutoInstaller.install):
1262         * Scripts/webkitpy/test/main.py:
1263         (Tester._run_tests):
1264         * Scripts/webkitpy/thirdparty/__init__.py:
1265         (AutoinstallImportHook._install_mechanize):
1266         (AutoinstallImportHook._install_pep8):
1267         (AutoinstallImportHook._install_pylint):
1268         (AutoinstallImportHook._install_buildbot):
1269         (AutoinstallImportHook._install_coverage):
1270         (AutoinstallImportHook._install_eliza):
1271         (AutoinstallImportHook._install_irc):
1272         (AutoinstallImportHook._install):
1273         (autoinstall_everything):
1274
1275 2014-10-02  Daniel Bates  <dabates@apple.com>
1276
1277         Use version number 101000 instead of 10100 for OS X Yosemite
1278         https://bugs.webkit.org/show_bug.cgi?id=137372
1279
1280         Reviewed by Mark Rowe.
1281
1282         The version number for OS X Yosemite is 101000.
1283
1284         * DumpRenderTree/mac/TextInputController.m:
1285
1286 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
1287
1288         update-work-items should never delete items
1289         https://bugs.webkit.org/show_bug.cgi?id=137366
1290
1291         Reviewed by Ryosuke Niwa.
1292
1293         As we don't just replace the whole list any more, indicate which items are high
1294         priority, and which are not. Hight priority ones will be prepended to the queue,
1295         others will be appended.
1296
1297         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
1298         But hopefully we will never have many rollouts competing like that.
1299
1300         * QueueStatusServer/app.yaml: Update version.
1301
1302         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
1303         priority and regular items separately. Removed some error handling that used to
1304         end up in returning status 500 - an uncaught exception does that automatically.
1305
1306         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
1307
1308         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
1309
1310         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
1311         priority items.
1312
1313         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1314         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
1315         line that complicated testing.
1316
1317         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
1318
1319         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
1320         priority items into separate lists.
1321
1322         * Scripts/webkitpy/common/net/statusserver_mock.py:
1323         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1324         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1325         Updated tests.
1326
1327 2014-10-02  Brendan Long  <b.long@cablelabs.com>
1328
1329         Annoying build warnings in WTFString API tests
1330         https://bugs.webkit.org/show_bug.cgi?id=137360
1331
1332         Reviewed by Darin Adler.
1333
1334         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1335         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
1336
1337 2014-10-02  Roger Fong  <roger_fong@apple.com>
1338
1339         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
1340
1341         * Scripts/webkitpy/port/win.py:
1342         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
1343
1344 2014-10-02  David Farler  <dfarler@apple.com>
1345
1346         Move ASan arguments from LLVM (-mllvm) to the frontend
1347         https://bugs.webkit.org/show_bug.cgi?id=137365
1348
1349         Reviewed by David Kilzer.
1350
1351         * asan/asan.xcconfig:
1352         Remove the -mllvm prefix to the asan-blacklist argument, moving it
1353         to the clang frontend.
1354
1355         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
1356
1357 2014-10-02  Commit Queue  <commit-queue@webkit.org>
1358
1359         Unreviewed, rolling out r174120.
1360         https://bugs.webkit.org/show_bug.cgi?id=137350
1361
1362         While number of failures is reasonable with 2 processes, test
1363         results seem to be inconsistent between runs (Requested by
1364         rfong on #webkit).
1365
1366         Reverted changeset:
1367
1368         "[Windows] Back to 2 child processes for NRWT on Windows."
1369         http://trac.webkit.org/changeset/174120
1370
1371 2014-10-02  Jeff Miller  <jeffm@apple.com>
1372
1373         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
1374         https://bugs.webkit.org/show_bug.cgi?id=137347
1375
1376         Reviewed by Dan Bernstein.
1377
1378         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1379         Use WebKitSystemInterfaceYosemite on OS X 10.10.
1380
1381         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1382         Ditto.
1383
1384 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1385
1386         [GTK] [JHBuild] Switch sourceware.org mirror to http.
1387
1388         Unreviewed.
1389
1390         The ftp access is recently failing to work as expected, and the
1391         bots fail to download the file.
1392         The same mirror is available via http and seems to work better.
1393
1394         * gtk/jhbuild.modules:
1395
1396 2014-10-01  Commit Queue  <commit-queue@webkit.org>
1397
1398         Unreviewed, rolling out r174185.
1399         https://bugs.webkit.org/show_bug.cgi?id=137334
1400
1401         Patch that adds logging causes webkitpy failures (Requested by
1402         rfong on #webkit).
1403
1404         Reverted changeset:
1405
1406         "commitqueuetasks_unittest references a non-existent member
1407         variable"
1408         https://bugs.webkit.org/show_bug.cgi?id=137303
1409         http://trac.webkit.org/changeset/174185
1410
1411 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1412
1413         EWS and Commit Queue should know better than to spew 500 failed
1414         results in the case of extremely red patches.
1415         https://bugs.webkit.org/show_bug.cgi?id=137324
1416
1417         Reviewed by Alexey Proskuryakov.
1418
1419         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1420         Adds a check for did_exceed_test_failure_limit.
1421         (AbstractEarlyWarningSystem._failing_tests_message):
1422         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1423         Alters the task mock to respond properly to
1424         results_from_patch_test_run(patch)
1425         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1426         * Scripts/webkitpy/tool/commands/queues.py:
1427         Adds a check for did_exceed_test_failure_limit.
1428         (CommitQueue._failing_tests_message):
1429
1430 2014-10-01  Daniel Bates  <dabates@apple.com>
1431
1432         Unreviewed, rolling out r174192.
1433
1434         Revert the unit test fix in r174192 since we reverted r174187
1435         in r174194 due to correctness issues. See
1436         <http://webkit.org/b/137329> for more details.
1437
1438         Reverted changeset:
1439
1440         "Test fix after r174187"
1441         http://trac.webkit.org/changeset/174192
1442
1443 2014-10-01  Mark Rowe  <mrowe@apple.com>
1444
1445         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
1446
1447         Reviewed by Dan Bernstein.
1448
1449         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
1450         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
1451         for the LLVM components when on Yosemite.
1452
1453 2014-10-01  Commit Queue  <commit-queue@webkit.org>
1454
1455         Unreviewed, rolling out r174187.
1456         https://bugs.webkit.org/show_bug.cgi?id=137329
1457
1458         webkitpy failures, and thorton says the patch is wrong
1459         (Requested by dethbakin on #webkit).
1460
1461         Reverted changeset:
1462
1463         "[Windows] Increase layout test timeout for Windows following
1464         r174162."
1465         http://trac.webkit.org/changeset/174187
1466
1467 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
1468
1469         Test fix after r174187
1470
1471         * Scripts/webkitpy/port/win_unittest.py:
1472         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
1473
1474 2014-10-01  Roger Fong  <roger_fong@apple.com>
1475
1476         [Windows] Increase layout test timeout for Windows following r174162.
1477
1478         * Scripts/webkitpy/port/win.py:
1479         (WinPort.default_timeout_ms):
1480
1481 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1482
1483         commitqueuetasks_unittest references a non-existent member variable
1484         when mock-reporting flaky tests.
1485         https://bugs.webkit.org/show_bug.cgi?id=137303
1486
1487         Reviewed by Daniel Bates.
1488
1489         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1490         (MockCommitQueue.report_flaky_tests):
1491         Makes the appropriate name change.
1492         (test_simple_flaky_test_failure):
1493         Adds a unit test to make sure that the code is excercised.
1494
1495 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1496
1497         EWS is inconclusively spinning forever on a patch that breaks 500+
1498         tests
1499         https://bugs.webkit.org/show_bug.cgi?id=137223
1500
1501         Reviewed by Tim Horton.
1502
1503         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1504         Checks to see whether the tests have exceeded the failure limit, and
1505         only spins off another test if they have not exceeded the limit.
1506         (PatchAnalysisTask._test_patch):
1507
1508 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
1509
1510         Unreviewed, add Katie Madonna as a contributor.
1511
1512         * Scripts/webkitpy/common/config/contributors.json:
1513
1514 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1515
1516         commitqueuetasks_unittest does not construct FailingTestCommitQueue
1517         objects properly in its test cases.
1518         https://bugs.webkit.org/show_bug.cgi?id=137281
1519
1520         Reviewed by Daniel Bates.
1521
1522         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1523         (FailingTestCommitQueue.test_results):
1524         Adds an assert to make FailingTestCommitQueue harder to mis-use.
1525         (test_double_flaky_test_failure):
1526         Nests the intended test failure strings into one-length lists.
1527         (test_red_test_failure):
1528         Nests the intended test failure strings into one-length lists.
1529
1530 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
1531
1532         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
1533         https://bugs.webkit.org/show_bug.cgi?id=136987
1534
1535         Reviewed by Daniel Bates.
1536
1537         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
1538         Specify the default encoding for all WebKit developers to get consistent results.
1539
1540 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
1541
1542         EWS is too eager to say that a patch does not apply to trunk of repository
1543         https://bugs.webkit.org/show_bug.cgi?id=137290
1544
1545         Reviewed by Ryosuke Niwa.
1546
1547         * QueueStatusServer/app.yaml: Updated app version.
1548
1549         * QueueStatusServer/handlers/statusbubble.py:
1550         (StatusBubble._build_bubble):
1551         (StatusBubble._build_bubbles_for_attachment):
1552         Rewrote to make more sense.
1553
1554 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1555
1556         Remove thirdparty/unittest2 from webkitpy
1557         https://bugs.webkit.org/show_bug.cgi?id=137251
1558
1559         Reviewed by Brent Fulgham.
1560
1561         Additionally ordered imports in related webkitpy files and
1562         removed unnecessary shebangs from unittest files.
1563
1564         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
1565         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1566         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1567         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
1568         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1569         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1570         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1571         * Scripts/webkitpy/common/config/committers_unittest.py:
1572         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1573         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
1574         * Scripts/webkitpy/common/config/ports_unittest.py:
1575         * Scripts/webkitpy/common/config/urls_unittest.py:
1576         * Scripts/webkitpy/common/editdistance_unittest.py:
1577         * Scripts/webkitpy/common/find_files_unittest.py:
1578         * Scripts/webkitpy/common/lru_cache_unittest.py:
1579         * Scripts/webkitpy/common/memoized_unittest.py:
1580         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
1581         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1582         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1583         * Scripts/webkitpy/common/net/credentials_unittest.py:
1584         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1585         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
1586         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1587         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1588         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
1589         * Scripts/webkitpy/common/net/statusserver_unittest.py:
1590         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
1591         * Scripts/webkitpy/common/newstringio_unittest.py:
1592         * Scripts/webkitpy/common/prettypatch_unittest.py:
1593         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
1594         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1595         * Scripts/webkitpy/common/system/environment_unittest.py:
1596         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
1597         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
1598         * Scripts/webkitpy/common/system/executive_unittest.py:
1599         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
1600         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1601         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1602         * Scripts/webkitpy/common/system/logtesting.py:
1603         * Scripts/webkitpy/common/system/logutils_unittest.py:
1604         * Scripts/webkitpy/common/system/outputcapture.py:
1605         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
1606         * Scripts/webkitpy/common/system/outputtee_unittest.py:
1607         * Scripts/webkitpy/common/system/path_unittest.py:
1608         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1609         * Scripts/webkitpy/common/system/profiler_unittest.py:
1610         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
1611         * Scripts/webkitpy/common/system/user_unittest.py:
1612         * Scripts/webkitpy/common/system/workspace_unittest.py:
1613         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1614         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
1615         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
1616         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
1617         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
1618         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
1619         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
1620         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
1621         * Scripts/webkitpy/common/webkitunittest.py:
1622         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1623         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1624         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1625         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1626         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1627         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
1628         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1629         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
1630         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
1631         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1632         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1633         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1634         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
1635         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1636         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1637         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
1638         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1639         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1640         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1641         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1642         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1643         * Scripts/webkitpy/port/base_unittest.py:
1644         * Scripts/webkitpy/port/builders_unittest.py:
1645         * Scripts/webkitpy/port/config_unittest.py:
1646         * Scripts/webkitpy/port/driver_unittest.py:
1647         * Scripts/webkitpy/port/efl_unittest.py:
1648         * Scripts/webkitpy/port/factory_unittest.py:
1649         * Scripts/webkitpy/port/gtk_unittest.py:
1650         * Scripts/webkitpy/port/http_lock_unittest.py:
1651         * Scripts/webkitpy/port/image_diff_unittest.py:
1652         * Scripts/webkitpy/port/leakdetector_unittest.py:
1653         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
1654         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1655         * Scripts/webkitpy/port/mock_drt_unittest.py:
1656         * Scripts/webkitpy/port/port_testcase.py:
1657         * Scripts/webkitpy/port/server_process_unittest.py:
1658         * Scripts/webkitpy/port/westondriver_unittest.py:
1659         * Scripts/webkitpy/port/win_unittest.py:
1660         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1661         * Scripts/webkitpy/style/checker_unittest.py:
1662         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
1663         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
1664         * Scripts/webkitpy/style/checkers/common_unittest.py:
1665         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1666         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
1667         * Scripts/webkitpy/style/checkers/js_unittest.py:
1668         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
1669         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
1670         * Scripts/webkitpy/style/checkers/png_unittest.py:
1671         * Scripts/webkitpy/style/checkers/python_unittest.py:
1672         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1673         * Scripts/webkitpy/style/checkers/text_unittest.py:
1674         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
1675         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
1676         * Scripts/webkitpy/style/checkers/xml_unittest.py:
1677         * Scripts/webkitpy/style/error_handlers_unittest.py:
1678         * Scripts/webkitpy/style/filereader_unittest.py:
1679         * Scripts/webkitpy/style/filter_unittest.py:
1680         * Scripts/webkitpy/style/main_unittest.py:
1681         * Scripts/webkitpy/style/optparser_unittest.py:
1682         * Scripts/webkitpy/style/patchreader_unittest.py:
1683         * Scripts/webkitpy/test/finder_unittest.py:
1684         * Scripts/webkitpy/test/main.py: Ordered imports.
1685         * Scripts/webkitpy/test/main_unittest.py:
1686         * Scripts/webkitpy/test/printer.py: Ordered imports.
1687         (Printer.configure):
1688         * Scripts/webkitpy/test/runner_unittest.py:
1689         * Scripts/webkitpy/test/skip_unittest.py:
1690         * Scripts/webkitpy/thirdparty/__init__.py:
1691         (AutoinstallImportHook._install_irc):
1692         (AutoinstallImportHook._install_unittest2): Deleted.
1693         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1694         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
1695         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
1696         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1697         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1698         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
1699         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1700         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1701         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1702         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1703         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1704         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1705         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1706         * Scripts/webkitpy/tool/commands/download_unittest.py:
1707         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1708         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
1709         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1710         * Scripts/webkitpy/tool/commands/queuestest.py:
1711         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1712         * Scripts/webkitpy/tool/grammar_unittest.py:
1713         * Scripts/webkitpy/tool/mocktool_unittest.py:
1714         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1715         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1716         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1717         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
1718         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
1719         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
1720         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
1721         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
1722         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1723         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
1724         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
1725         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1726         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1727         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1728         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1729         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1730         * Scripts/webkitpy/tool/steps/update_unittest.py:
1731         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1732         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1733         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1734         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1735         * Scripts/webkitpy/w3c/test_parser_unittest.py:
1736
1737 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
1738
1739         LayoutTestResults and ExpectedFailures should know about the
1740         interrupted flag from the json results file
1741         https://bugs.webkit.org/show_bug.cgi?id=137229
1742
1743         Reviewed by Daniel Bates.
1744
1745         Changes LayoutTestResults to use the interrupted flag instead of
1746         counting failures.
1747
1748         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1749         (BuilderTest._install_fetch_build._mock_fetch_build):
1750         (BuilderTest.test_latest_layout_test_results):
1751         * Scripts/webkitpy/common/net/layouttestresults.py:
1752         Removes notion of failure_limit_count, and adds
1753         did_exceed_test_failure_limit.
1754
1755         (LayoutTestResults.results_from_string):
1756         (LayoutTestResults.__init__):
1757         (LayoutTestResults.did_exceed_test_failure_limit):
1758         (LayoutTestResults): Deleted.
1759         (LayoutTestResults.set_failure_limit_count): Deleted.
1760         (LayoutTestResults.failure_limit_count): Deleted.
1761         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1762         Removes unit test for failure_limit_count logic.
1763
1764         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
1765         * Scripts/webkitpy/common/net/resultsjsonparser.py:
1766         Instead of providing a class method that returns a list of
1767         TestResults objects, resultsjsonparser now provides a class
1768         ParsedJSONResults that serves as an interface between the results.json
1769         file and the rest of webkitpy.
1770
1771         (ParsedJSONResults):
1772         (ParsedJSONResults.__init__):
1773         (ParsedJSONResults.did_exceed_test_failure_limit):
1774         (ParsedJSONResults.test_results):
1775         (ResultsJSONParser): Deleted.
1776         (ResultsJSONParser.parse_results_json): Deleted.
1777         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
1778         Updates the unit test so that it can test the new ResultsJSONParser
1779         class.
1780
1781         (ParsedJSONResultsTest):
1782         (test_basic):
1783         (ResultsJSONParserTest): Deleted.
1784         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1785         Updates the unit test to instantiate ResultsJSONParser objects rather
1786         than simple lists of TestResult objects.
1787
1788         (MockCommitQueue.test_results):
1789         (FailingTestCommitQueue.test_results):
1790         (test_flaky_test_failure):
1791         (test_failed_archive):
1792         * Scripts/webkitpy/tool/bot/expectedfailures.py:
1793         Updates ExpectedFailures to use the did_exceed_test_failure_limit
1794         method rather than counting the number of failed tests.
1795
1796         (ExpectedFailures._should_trust):
1797         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
1798         Updates MockResults to more closely resemble the updated
1799         LayoutTestResults class.
1800
1801         (MockResults.__init__):
1802         (MockResults.did_exceed_test_failure_limit):
1803         (ExpectedFailuresTest.test_can_trust_results):
1804         (ExpectedFailuresTest.test_unexpected_failures_observed):
1805         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
1806         (MockResults.failure_limit_count): Deleted.
1807         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1808         Removes a FIXME regarding the use of the
1809         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
1810
1811         (LayoutTestResultsReader.results):
1812         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1813         Updates test to not check the now-nonexistant failure_count_limit
1814         method.
1815
1816         (test_missing_unit_test_results_path):
1817         (test_layout_test_results):
1818         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1819         Accounts for name change: ResultsJSONParserTest ->
1820         ParsedJSONParserTest.
1821
1822         (RebaselineTestTest.test_gather_baselines):
1823
1824 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1825
1826         [EFL] Rename TEST_THEME_DIR macro
1827         https://bugs.webkit.org/show_bug.cgi?id=137244
1828
1829         Reviewed by Csaba Osztrogonác.
1830
1831         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
1832         DEFAULT_THEME_DIR is better than it.
1833
1834         * MiniBrowser/efl/main.c:
1835         (window_create):
1836         * TestWebKitAPI/efl/PlatformWebView.cpp:
1837         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1838         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1839         (WTR::PlatformWebView::PlatformWebView):
1840
1841 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
1842
1843         Windows EWS went purple when it failed to build
1844         https://bugs.webkit.org/show_bug.cgi?id=137267
1845
1846         Reviewed by Ryosuke Niwa.
1847
1848         * QueueStatusServer/app.yaml: Update the version.
1849
1850         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
1851         Make it work for style and win-ews queues.
1852
1853 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
1854
1855         It should be fun and easy to run every possible JavaScript benchmark from the command line
1856         https://bugs.webkit.org/show_bug.cgi?id=137245
1857
1858         Reviewed by Oliver Hunt.
1859         
1860         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
1861         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
1862         having their own private scripts for doing benchmark runs, and didn't share them in the open
1863         source community, because of fears about the shady licensing of the benchmarks suites that
1864         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
1865         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
1866         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
1867         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
1868         but some of them are. The non-public tests are exclusively those that were not made by any
1869         WebKit contributor, but which JSC/WebKit devs found useful for testing.
1870
1871         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
1872         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
1873         checked into WebKit svn at all) can be run by passing the path to them via a configuration
1874         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
1875         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
1876         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
1877         probably never be checked in because there is no license text anywhere in that benchmark.
1878         A valid ~/.run-jsc-benchmarks file will just be something like:
1879         
1880             {
1881                 "OctanePath": "/path/to/Octane2",
1882                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
1883             }
1884         
1885         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
1886         run-jsc-benchmarks will just gracefully avoid running that test suite.
1887         
1888         Finally, a word about policy: it is understood that different organizations that do
1889         development on JSC may find themselves having internal benchmarks that they cannot share
1890         because of weird licensing. It happens - usually because the organization doing JSC
1891         development found some test in the wild that is owned by someone else and therefore cannot
1892         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
1893         that add support for some new kind of benchmark suite even if the suite is not made public
1894         as part of the same patch - so long as the patch isn't too invasive. An example of
1895         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
1896         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
1897         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
1898         completely open-sourced and committed to the WebKit repo - but the reality is that this
1899         can't always be done safely.
1900
1901         * Scripts/bencher: Removed.
1902         * Scripts/run-jsc-benchmarks: Added.
1903
1904 2014-09-30  Roger Fong  <roger_fong@apple.com>
1905
1906         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
1907
1908         * Scripts/webkitpy/port/drdiver.py:
1909         (Driver.stop):
1910         * Scripts/webkitpy/port/server_process.py:
1911         (ServerProcess.stop):
1912
1913 2014-09-30  Roger Fong  <roger_fong@apple.com>
1914
1915         [Windows] Back to 2 child processes for NRWT on Windows.
1916
1917         * Scripts/webkitpy/port/win.py:
1918         (WinPort.default_child_processes):
1919         Changing the number of processes to 1 did not have an effect on the layout test results. 
1920         It does introduce an issue with one of the workers hanging indefinitely and causing the 
1921         layout tests to timeout as a whole occasionally, but we should just fix that.
1922
1923 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
1924
1925         Remove an accidentally committed line..
1926
1927         * QueueStatusServer/handlers/statusbubble.py:
1928         (StatusBubble._build_bubble):
1929
1930 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
1931
1932         build.webkit.org/dashboard: Switch EWS view to using actual retry count
1933         https://bugs.webkit.org/show_bug.cgi?id=137240
1934
1935         Reviewed by Ryosuke Niwa.
1936
1937         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1938         (EWSQueue.prototype.loadDetailedStatus):
1939         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
1940         (EWSQueueView.prototype._popoverContentForEWSQueue):
1941         Use the new retry_count data member from JSON.
1942
1943         * QueueStatusServer/app.yaml: Updating the version.
1944
1945         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
1946         Instead of message_count, produce retry_count.
1947
1948 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
1949
1950         EWS doesn't need to show all the bubbles when a patch fails to apply
1951         https://bugs.webkit.org/show_bug.cgi?id=137256
1952
1953         Reviewed by Ryosuke Niwa.
1954
1955         * QueueStatusServer/app.yaml: Updated app version.
1956
1957         * QueueStatusServer/handlers/statusbubble.py:
1958         (StatusBubble._build_bubble):
1959         (StatusBubble._build_bubbles_for_attachment):
1960         (StatusBubble.get):
1961         * QueueStatusServer/templates/statusbubble.html:
1962         When some queues fail to apply, and no queues had meaningful output (meaning that
1963         they will almost certainly fail to apply later), we can show a single bubble
1964         telling the user just that.
1965
1966 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1967
1968         [EFL] Bump EFL version to 1.11.2
1969         https://bugs.webkit.org/show_bug.cgi?id=137118
1970
1971         Reviewed by Gyuyoung Kim.
1972
1973         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
1974         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
1975
1976         * efl/jhbuild.modules:
1977         * efl/patches/ecore.patch: Removed.
1978
1979 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1980
1981         REGRESSION(r173929): [GTK] TestInspector fails after r173929
1982         https://bugs.webkit.org/show_bug.cgi?id=137247
1983
1984         Reviewed by Philippe Normand.
1985
1986         Wait until can-attach property changes before trying to attach the
1987         inspector after resizing the view.
1988
1989         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
1990         (testInspectorDefault):
1991
1992 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1993
1994         Require Python 2.7 version
1995         https://bugs.webkit.org/show_bug.cgi?id=137112
1996
1997         Reviewed by Csaba Osztrogonác.
1998
1999         * Scripts/ensure-valid-python:
2000         (checkPythonVersion):
2001         * Scripts/webkitpy/common/version_check.py:
2002
2003 2014-09-30  Martin Hock  <mhock@apple.com>
2004
2005         Skip a JSC test after r174036.
2006         https://bugs.webkit.org/show_bug.cgi?id=137236
2007
2008         Reviewed by Csaba Osztrogonác.
2009
2010         * Scripts/run-javascriptcore-tests:
2011
2012 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2013
2014         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
2015         https://bugs.webkit.org/show_bug.cgi?id=137212
2016
2017         This moves TestNetscapePlugin to a new folder (lib/plugins).
2018         We should not use the same directory for TestNetscapePlugin and
2019         the other libraries, because we end up scanning all the .so in the
2020         lib dir for every test.
2021
2022         Reviewed by Carlos Garcia Campos.
2023
2024         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
2025         * Scripts/webkitpy/port/efl.py:
2026         (EflPort.setup_environ_for_server): Update plugin path.
2027         * Scripts/webkitpy/port/gtk.py:
2028         (GtkPort.setup_environ_for_server): Update plugin path.
2029         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
2030
2031 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2032
2033         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
2034
2035         Rubber-stamped by Tim Horton.
2036
2037         * QueueStatusServer/app.yaml:
2038         * QueueStatusServer/handlers/statusbubble.py:
2039         (StatusBubble._build_bubble):
2040
2041 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2042
2043         Typo fix, suggested by Tim Horton.
2044
2045         * QueueStatusServer/handlers/statusbubble.py:
2046         (StatusBubble._build_message_for_provisional_failure):
2047
2048 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2049
2050         Improve Bugzilla status bubbles
2051         https://bugs.webkit.org/show_bug.cgi?id=137232
2052
2053         Reviewed by Ryosuke Niwa.
2054
2055         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
2056
2057         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
2058         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
2059         that are stuck, as it was only confusing that they disappeared after 99.
2060
2061         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
2062         by old bubbles. We need a lot more information to determine color, so the implementation
2063         can not be here.
2064
2065         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
2066         always have a link for consistency. Added code to convert timestamps in tooltips
2067         to local time zone.
2068
2069 2014-09-29  Commit Queue  <commit-queue@webkit.org>
2070
2071         Unreviewed, rolling out r174045.
2072         https://bugs.webkit.org/show_bug.cgi?id=137231
2073
2074         Introduced a crash during page loading tests on Mac (Requested
2075         by rniwa on #webkit).
2076
2077         Reverted changeset:
2078
2079         "Replace OSObjectPtr with RetainPtr/adoptOS"
2080         https://bugs.webkit.org/show_bug.cgi?id=137158
2081         http://trac.webkit.org/changeset/174045
2082
2083 2014-09-29  Tim Horton  <timothy_horton@apple.com>
2084
2085         Add Jake as a contributor.
2086
2087         * Scripts/webkitpy/common/config/contributors.json:
2088
2089 2014-09-29  Roger Fong  <roger_fong@apple.com>
2090
2091         [Windows] Skip a javascriptcore test following r174036.
2092
2093         * Scripts/run-javascriptcore-tests:
2094
2095 2014-09-29  Roger Fong  <roger_fong@apple.com>
2096
2097         [Windows] Reduce number of processes used by NRWT on Windows to 1.
2098
2099         * Scripts/webkitpy/port/win.py:
2100         (WinPort.default_child_processes):
2101         Reduce number of processes to 1 so we can get a good baseline for what failures
2102         we should be expecting to see from the Windows bots.
2103
2104 2014-09-29  Darin Adler  <darin@apple.com>
2105
2106         Tweak and tighten SVG font converter
2107         https://bugs.webkit.org/show_bug.cgi?id=136956
2108
2109         Reviewed by Myles Maxfield.
2110
2111         I was investigating behavior of String::toInt, String::toDouble, and
2112         String::toFloat for various failure cases, and decided to start some
2113         unit tests for those functions here.
2114
2115         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2116         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
2117         StringToDouble testing.
2118
2119 2014-09-29  Philippe Normand  <pnormand@igalia.com>
2120
2121         [GTK][CMake] TestWebCore target build sometimes fail
2122         https://bugs.webkit.org/show_bug.cgi?id=137207
2123
2124         Reviewed by Csaba Osztrogon.
2125
2126         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
2127         headers are generated before the TestWebCore target is built.
2128
2129 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2130
2131         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
2132         https://bugs.webkit.org/show_bug.cgi?id=137209
2133
2134         Reviewed by Philippe Normand.
2135
2136         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
2137         from the WebCore test sources.
2138
2139 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
2140
2141         Allow webkit-patch upload to respect the --directory argument with git checkouts
2142         https://bugs.webkit.org/show_bug.cgi?id=137166
2143
2144         Reviewed by Darin Adler.
2145
2146         We simply hadn't plumbed it through.
2147
2148         * Scripts/webkitpy/common/checkout/scm/detection.py:
2149         (SCMDetector.detect_scm_system):
2150         * Scripts/webkitpy/common/checkout/scm/git.py:
2151         (Git.__init__):
2152         (Git.changed_files):
2153
2154 2014-09-26  Sam Weinig  <sam@webkit.org>
2155
2156         Replace OSObjectPtr with RetainPtr/adoptOS
2157         https://bugs.webkit.org/show_bug.cgi?id=137158
2158
2159         Reviewed by Dan Bernstein.
2160
2161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2162         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
2163         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
2164         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
2165
2166 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
2167
2168         Disable function.arguments
2169         https://bugs.webkit.org/show_bug.cgi?id=137167
2170
2171         Rubber stamped by Geoffrey Garen
2172         
2173         Enable the feature by default during tests.
2174
2175         * Scripts/run-jsc-stress-tests:
2176
2177 2014-09-26  Beth Dakin  <bdakin@apple.com>
2178
2179         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
2180         https://bugs.webkit.org/show_bug.cgi?id=137089
2181
2182         Reviewed by Tim Horton.
2183
2184         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
2185         tests run at 1x, but that code does not seem to execute at the right time for 
2186         these tests, so if we just ensure we start out at 1x, that appears to fix these 
2187         tests and does not break the HiDPI tests either.
2188         * WebKitTestRunner/TestController.cpp:
2189         (WTR::TestController::createWebViewWithOptions):
2190
2191 2014-09-26  Roger Fong  <roger_fong@apple.com>
2192
2193         [Windows] Decrease default number of child processes used by Windows.
2194
2195         * Scripts/webkitpy/port/win.py:
2196         (WinPort.default_child_processes):
2197         Having too many seems to cause many tests to crash or timeout. 
2198         We may even need to make it have only 1 child process if we’re still seeing problems after this.
2199
2200 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2201
2202         Mac EWS bots do not keep logs as promised
2203         https://bugs.webkit.org/show_bug.cgi?id=137151
2204
2205         Reviewed by Ryosuke Niwa.
2206
2207         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
2208
2209 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2210
2211         Get rid of webkit-queues dashboard
2212         https://bugs.webkit.org/show_bug.cgi?id=137141
2213
2214         Reviewed by Ryosuke Niwa.
2215
2216         * QueueStatusServer/app.yaml: Updated version.
2217
2218         * QueueStatusServer/templates/dashboard.html: Removed.
2219         * QueueStatusServer/handlers/dashboard.py: Removed.
2220         * QueueStatusServer/main.py:
2221         Kill it!
2222
2223         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
2224         (.status-cell): Deleted.
2225         (.status-cell:hover): Deleted.
2226         (.status-cell.pass): Deleted.
2227         (.status-cell.fail): Deleted.
2228         (.status-cell.pending): Deleted.
2229         (.status-cell.error): Deleted.
2230         * QueueStatusServer/stylesheets/dashboard.css: Removed.
2231         * QueueStatusServer/templates/activebots.html:
2232         * QueueStatusServer/templates/patch.html:
2233         * QueueStatusServer/templates/queuestatus.html:
2234         * QueueStatusServer/templates/recentstatus.html:
2235         Renamed dashboard.css to common.css, and removed dashboard-only rules.
2236
2237 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2238
2239         Get rid of Retry status in webkit-queues
2240         https://bugs.webkit.org/show_bug.cgi?id=137135
2241
2242         Reviewed by Ryosuke Niwa.
2243
2244         * QueueStatusServer/config/messages.py: Removed Retry.
2245
2246         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
2247         no longer needs to check the latest status. It just always both unlocks the patch
2248         and removes it from WorkItems.
2249
2250         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
2251         I don't understand why we even needed to check for retries here, but now that there
2252         are no retries, that code can go to /dev/null.
2253
2254         * QueueStatusServer/loggers/recordpatchevent.py:
2255         (RecordPatchEvent.started):
2256         (RecordPatchEvent.retrying): Deleted.
2257         Fixed retry counting, it should work for all queues now.
2258
2259         * QueueStatusServer/model/queuestatus.py:
2260         (QueueStatus.is_retry_request): Deleted. These are no more.
2261
2262         * Scripts/webkitpy/common/net/statusserver_mock.py:
2263         (MockStatusServer.release_lock):
2264         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2265         Did whatever it took to keep passing the tests. The particular test doesn't seem
2266         quite right, but whatever.
2267
2268         * Scripts/webkitpy/tool/commands/queues.py:
2269         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
2270         and let others pick up. Also, added explicit returns for clarity.
2271         (AbstractPatchQueue._did_retry): Deleted.
2272
2273 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
2274
2275         [EFL] Fix the gst-libav build on ARM Thumb2
2276         https://bugs.webkit.org/show_bug.cgi?id=137022
2277
2278         Reviewed by Zoltan Herczeg.
2279
2280         * efl/jhbuild.modules:
2281         * efl/patches/gst-libav.patch: Added.
2282
2283 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
2284
2285         [EFL] Bump up dependencies not to conflict with the GTK port.
2286         https://bugs.webkit.org/show_bug.cgi?id=137143
2287
2288         Reviewed by Gyuyoung Kim.
2289
2290         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
2291         installing and removing different versions of libgnutls-dev, thus
2292         hindering the development for both ports on the same machine. GTK is
2293         using the newer version of the package, now bumping up EFL to use the 
2294         same.
2295
2296         * efl/install-dependencies:
2297
2298 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
2299
2300         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
2301         https://bugs.webkit.org/show_bug.cgi?id=136854
2302
2303         Reviewed by Gyuyoung Kim.
2304
2305         'Escape' key should exit fullscreen first and then should be used to stop page load.
2306
2307         * MiniBrowser/efl/main.c:
2308         (on_key_down):
2309
2310 2014-09-25  Dean Jackson  <dino@apple.com>
2311
2312         Add Said to the contributors list so his name completes in bugzilla.
2313
2314         * Scripts/webkitpy/common/config/contributors.json:
2315
2316 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
2317
2318         EWS only repeats its cycle every two hours
2319         https://bugs.webkit.org/show_bug.cgi?id=137129
2320
2321         Reviewed by Ryosuke Niwa.
2322
2323         * QueueStatusServer/app.yaml: Updated version.
2324
2325         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
2326
2327         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
2328         the patch from work items.
2329
2330         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
2331
2332         * QueueStatusServer/main.py: Added release-lock.
2333
2334         * QueueStatusServer/model/activeworkitems.py:
2335         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
2336
2337         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
2338         we don't want it to be immediately picked up again, it's better to give other patches
2339         a chance.
2340
2341         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
2342         these interactive versions, but OK.
2343
2344         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
2345         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
2346         or svn is down).
2347
2348         * Scripts/webkitpy/tool/commands/queues.py:
2349         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
2350         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
2351         meaning that these handlers could never do the right thing. We'd either get a duplicate
2352         _did_fail, or try to unlock an already unlocked patch.
2353         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
2354         making it eligible for retry immediately.
2355
2356         * Scripts/webkitpy/common/net/statusserver.py:
2357         (StatusServer._post_release_lock):
2358         (StatusServer.release_lock):
2359         Added a call to release-lock.
2360
2361 2014-09-25  Roger Fong  <roger_fong@apple.com>
2362
2363         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
2364
2365         * Scripts/webkitpy/common/system/path.py:
2366         (_CygPath.convert):
2367
2368 2014-09-25  Roger Fong  <roger_fong@apple.com>
2369
2370         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
2371
2372         * Scripts/webkitpy/common/system/path.py:
2373         (_CygPath.convert):
2374
2375 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2376
2377         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
2378         https://bugs.webkit.org/show_bug.cgi?id=136377
2379
2380         Reviewed by Philippe Normand.
2381
2382         * Scripts/webkitdirs.pm:
2383         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
2384
2385 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
2386
2387         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
2388         https://bugs.webkit.org/show_bug.cgi?id=137117
2389
2390         Tools/efl/install-dependencies relies on apt-get to install packages.
2391         Unfortunately, if a package does not exist (e.g., for a given
2392         architecture) then apt-get install is not able to ignore the missing
2393         package and install the rest but fails to run entirely (and there
2394         seems to be no intent to change this behaviour).
2395
2396         On ARM64, the luajit package is missing and currently it needs manual
2397         editing of install-dependencies to get the script install as much as it
2398         can.
2399
2400         This patch separates the installation of the universally available
2401         packages from those which might not be available for all architectures.
2402
2403         Reviewed by Gyuyoung Kim.
2404
2405         * efl/install-dependencies:
2406
2407 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
2408
2409         Remove WinCE port from trunk
2410         https://bugs.webkit.org/show_bug.cgi?id=136951
2411
2412         Reviewed by Alex Christensen.
2413
2414         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2415         (_should_file_trigger_build):
2416         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2417         (ShouldBuildTest):
2418         * CMakeLists.txt:
2419         * DumpRenderTree/win/DRTDataObject.cpp:
2420         (DRTDataObject::CopyMedium):
2421         * Scripts/build-webkit:
2422         * Scripts/webkit-build-directory:
2423         * Scripts/webkitdirs.pm:
2424         (argumentsForConfiguration):
2425         (builtDylibPathForName):
2426         (isAppleWinWebKit):
2427         (launcherPath):
2428         (launcherName):
2429         (shouldRemoveCMakeCache):
2430         (cmakeBasedPortArguments):
2431         (cmakeBasedPortName):
2432         (isCMakeBuild):
2433         (isWinCE): Deleted.
2434         (determineIsWinCE): Deleted.
2435         * Scripts/webkitperl/FeatureList.pm:
2436         * Scripts/webkitpy/port/port_testcase.py:
2437         (test_apache_config_file_name_for_platform):
2438         * TestWebKitAPI/config.h:
2439         * WinCELauncher/CMakeLists.txt: Removed.
2440         * WinCELauncher/main.cpp: Removed.
2441         * gtk/manifest.txt:
2442
2443 2014-09-23  David Farler  <dfarler@apple.com>
2444
2445         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
2446         https://bugs.webkit.org/show_bug.cgi?id=136895
2447
2448         Reviewed by David Kilzer.
2449
2450         Create Device, DeviceType, and Runtime data classes.
2451         Create Simulator class represent simctl output.
2452
2453         Wherever possible, use structured data classes anywhere a raw
2454         identifier or UDID string was used for a cleaner implementation
2455         and to encapsulate the inherent fragility of scraping simctl output.
2456
2457         Create a suitably named testing device if one doesn't exist.
2458
2459         Finally, accurately handle having multiple simulator runtimes (SDKs)
2460         installed in the active Xcode.app bundle.
2461
2462         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2463         (_set_up_derived_options):
2464         * Scripts/webkitpy/port/driver.py:
2465         (IOSSimulatorDriver.cmd_line):
2466         Construct DeviceType and Runtime objects from identifiers passed at the
2467         command line, still providing sensible defaults for 32- and 64-bit testing.
2468         * Scripts/webkitpy/port/ios.py:
2469         (IOSSimulatorPort.__init__):
2470         (IOSSimulatorPort.setup_test_run):
2471         (IOSSimulatorPort):
2472         (IOSSimulatorPort.testing_device):
2473         Cache the testing device once it is created or found.
2474         (IOSSimulatorPort.reset_preferences):
2475         Get the device path from the Device object instead of consructing it
2476         in the port class.
2477         (IOSSimulatorPort.simulator_udid): Deleted.
2478         Get the UDID from the testing_device :: Device object itself.
2479         * Scripts/webkitpy/xcode/simulator.py:
2480         Created Device, DeviceType, Runtime, and Simulator classes.
2481         (get_runtimes): Deleted.
2482         (get_devices): Deleted.
2483         (get_device_types): Deleted.
2484         (get_latest_runtime): Deleted.
2485
2486 2014-09-24  Roger Fong  <roger_fong@apple.com>
2487
2488         [Windows] Tentative fix for Windows test bots.
2489
2490         * Scripts/webkitpy/common/system/path.py:
2491         (_CygPath.convert):
2492
2493 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
2494
2495         Change more build.webkit.org links to https
2496         https://bugs.webkit.org/show_bug.cgi?id=137049
2497
2498         Reviewed by Csaba Osztrogonác.
2499
2500         Fix appspot, svn.webkit.org and Trac links.
2501
2502         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2503         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
2504         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2505         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
2506         (ViewController.prototype._domForBuildName):
2507         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2508         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2509         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2510         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2511         (.):
2512         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
2513         (EWS):
2514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2515         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
2516         (TestHistory):
2517         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2518
2519 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
2520
2521         Update the list of u-szeged contributors.
2522
2523         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
2524
2525         * Scripts/webkitpy/common/config/contributors.json:
2526
2527 2014-09-23  Roger Fong  <roger_fong@apple.com>
2528
2529         [Windows] More debugging for the Windows bots.
2530
2531         * Scripts/webkitpy/common/system/path.py:
2532         (_CygPath):
2533
2534 2014-09-23  Roger Fong  <roger_fong@apple.com>
2535
2536         Unreviewed. Fix for r173899, those tabs should be spaces.
2537
2538         * Scripts/webkitpy/port/driver.py:
2539         (Driver._command_from_driver_input):
2540         (Driver): Deleted.
2541
2542 2014-09-23  Roger Fong  <roger_fong@apple.com>
2543
2544         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
2545
2546         * Scripts/webkitpy/port/driver.py:
2547         (Driver):
2548
2549 2014-09-23  Jer Noble  <jer.noble@apple.com>
2550
2551         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
2552         https://bugs.webkit.org/show_bug.cgi?id=137031
2553
2554         Reviewed by Joseph Pecoraro.
2555
2556         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
2557         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
2558         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
2559         ChangeLog locations before passing them to createCommitMessage().
2560
2561         * Scripts/commit-log-editor:
2562
2563 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2564
2565         W3C test importer should detect manual and reference tests according their filenames
2566         https://bugs.webkit.org/show_bug.cgi?id=133852
2567
2568         Reviewed by Bem Jones-Bey.
2569
2570         * Scripts/webkitpy/w3c/test_parser.py:
2571         (TestParser.analyze_test): Adding checks based on WPT filename rules.
2572         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
2573         (TestParser):
2574         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
2575         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
2576         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2577         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
2578
2579 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
2580
2581         Unreviewed, add Rebecca Hauck as a contributor.
2582
2583         * Scripts/webkitpy/common/config/contributors.json:
2584
2585 2014-09-23  David Kilzer  <ddkilzer@apple.com>
2586
2587         Switch build.webkit.org URLs to https
2588
2589         Reviewed by Lucas Forschler and Alexey Proskuryakov.
2590
2591         * TestResultServer/app.yaml: Update version to this commit
2592         revision.
2593
2594         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2595         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2597         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
2598         (WebKitBuildbot):
2599         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2600         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2601         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2602         (.):
2603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2604         (WebKitBuildbot):
2605         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2606         * Scripts/webkitpy/common/config/urls.py:
2607         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2608         (test_builder_with_name):
2609         * Scripts/webkitpy/tool/commands/queries.py:
2610         (TreeStatus):
2611         * TestResultServer/generate_builders_json.py:
2612         (main):
2613         * TestResultServer/generate_builders_json_unittest.py:
2614         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
2615         (GenerateBuildersJsonTest):
2616         (GenerateBuildersJsonTest.test_generate_json_data):
2617         * TestResultServer/static-dashboards/builders.jsonp:
2618         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2619         (loadExpectationsLayoutTests):
2620         * TestResultServer/static-dashboards/timeline_explorer.js:
2621
2622 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2623
2624         W3C test importer should copy .htaccess files
2625         https://bugs.webkit.org/show_bug.cgi?id=136850
2626
2627         Reviewed by Bem Jones-Bey.
2628
2629         * Scripts/webkitpy/w3c/test_importer.py:
2630         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
2631         (TestImporter):
2632         (TestImporter.find_importable_tests): Making use of new helper function.
2633
2634 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
2635
2636         Trying to revive bot watcher's dashboard after HSTS.
2637
2638         Unreviewed.
2639
2640         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2641         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
2642
2643 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2644
2645         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
2646         https://bugs.webkit.org/show_bug.cgi?id=137026
2647
2648         Reviewed by Csaba Osztrogonác.
2649
2650         * BuildSlaveSupport/wait-for-SVN-server.py:
2651         (getLatestSVNRevision):
2652         (waitForSVNRevision):
2653
2654 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2655
2656         Remove unlinkZeroFiles from build-webkit
2657         https://bugs.webkit.org/show_bug.cgi?id=137018
2658
2659         Reviewed by Csaba Osztrogonác.
2660
2661         * Scripts/build-webkit:
2662         (unlinkZeroFiles): Deleted.
2663
2664 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
2665
2666         [GTK] Minibrowser : Add keyboard support for stop page load
2667         https://bugs.webkit.org/show_bug.cgi?id=136857
2668
2669         Reviewed by Philippe Normand.
2670
2671         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
2672
2673         * MiniBrowser/gtk/BrowserWindow.c:
2674         (stopPageLoad): Callback to stop page load.
2675         (browser_window_init):
2676
2677 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
2678
2679         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
2680         https://bugs.webkit.org/show_bug.cgi?id=136813
2681
2682         Reviewed by Gyuyoung Kim.
2683
2684         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
2685
2686         * MiniBrowser/efl/main.c:
2687         (on_key_down):
2688
2689 2014-09-22  Daniel Bates  <dabates@apple.com>
2690
2691         [Cocoa] Add UI delegate callback when window.close() is called
2692         https://bugs.webkit.org/show_bug.cgi?id=137008
2693         <rdar://problem/17801001>
2694
2695         Reviewed by Anders Carlsson.
2696
2697         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
2698         for window opened via JavaScript (i.e. window.open()).
2699
2700         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2701         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
2702         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
2703
2704 2014-09-22  Youenn Fablet  <youennf@gmail.com>
2705
2706         W3C importer should import html files within resources folders
2707         https://bugs.webkit.org/show_bug.cgi?id=127548
2708
2709         Reviewed by Ryosuke Niwa.
2710         
2711         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
2712
2713         * Scripts/webkitpy/w3c/test_importer.py:
2714         (TestImporter.find_importable_tests):
2715
2716 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2717
2718         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
2719         https://bugs.webkit.org/show_bug.cgi?id=136998
2720
2721         Reviewed by Philippe Normand.
2722
2723         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2724         (testWebViewCanShowMIMEType): Remove the check of PDF as
2725         unsupported MIME type.
2726
2727 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2728
2729         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
2730
2731         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
2732         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
2733
2734         * Scripts/webkitpy/common/config/watchlist: Use
2735         Source/WebCore/platform/gtk/po/ as directory to watch for
2736         WebKitGTKTranslations rule and add berto and myself to the list of
2737         watchers.
2738
2739 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
2740
2741         Fix syntaxError in watchlist since r173594
2742         https://bugs.webkit.org/show_bug.cgi?id=136996
2743
2744         Reviewed by Philippe Normand.
2745
2746         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
2747
2748 2014-09-20  Sam Weinig  <sam@webkit.org>
2749
2750         Make possible HashSet<std::unique_ptr<>>
2751         https://bugs.webkit.org/show_bug.cgi?id=136166
2752
2753         Reviewed by Darin Adler.
2754
2755         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
2756         * TestWebKitAPI/Counters.cpp: Added.
2757         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
2758         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
2759         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
2760         translation unit.
2761     
2762         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2763         Add new files.
2764
2765         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2766         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
2767
2768         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2769         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
2770
2771 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2772
2773         run-webkit-tests should count tests submitted as absolute paths once
2774         https://bugs.webkit.org/show_bug.cgi?id=136848
2775
2776         Reviewed by Darin Adler.
2777
2778         * Scripts/webkitpy/port/base.py:
2779         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
2780
2781 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
2782
2783         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
2784         https://bugs.webkit.org/show_bug.cgi?id=136974
2785
2786         Reviewed by Chris Fleizach.
2787
2788         * DumpRenderTree/AccessibilityUIElement.cpp:
2789         (selectTextWithCriteriaCallback):
2790         Be sure to release the string if it was allocated.
2791
2792 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
2793
2794         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
2795         https://bugs.webkit.org/show_bug.cgi?id=136966
2796
2797         Reviewed by Daniel Bates.
2798
2799         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2800         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
2801
2802 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2803
2804         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
2805         https://bugs.webkit.org/show_bug.cgi?id=136917
2806
2807         Reviewed by Darin Adler.
2808
2809         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
2810
2811         * TestWebKitAPI/PlatformEfl.cmake:
2812         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
2813         (TestWebKitAPI::didFinishLoadForFrame):
2814         (TestWebKitAPI::TEST):
2815         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
2816
2817 2014-09-19  Daniel Bates  <dabates@apple.com>
2818
2819         Always assume internal SDK when building configuration Production
2820         https://bugs.webkit.org/show_bug.cgi?id=136925
2821         <rdar://problem/18362399>
2822
2823         Reviewed by Dan Bernstein.
2824
2825         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2826         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2827         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2828         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2829
2830 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2831
2832         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
2833         https://bugs.webkit.org/show_bug.cgi?id=136847
2834
2835         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
2836
2837         Reviewed by Alexey Proskuryakov.
2838
2839         * WebKitTestRunner/TestController.cpp:
2840         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
2841
2842 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2843
2844         [GTK] Missing inspector files in the tarball
2845         https://bugs.webkit.org/show_bug.cgi?id=136952
2846
2847         Reviewed by Gustavo Noronha Silva.
2848
2849         * gtk/manifest.txt: Add
2850         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
2851         to the tarball.
2852
2853 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2854
2855         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
2856         https://bugs.webkit.org/show_bug.cgi?id=136632
2857
2858         Reviewed by Gustavo Noronha Silva.
2859
2860         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
2861         the gtk icons.
2862         * gtk/manifest.txt: Only include the free icons in the tarball.
2863
2864 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2865
2866         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
2867         https://bugs.webkit.org/show_bug.cgi?id=136943
2868
2869         Reviewed by Philippe Normand.
2870
2871         Update the script to receive the list of files from the command
2872         line instead of scanning the given directories.
2873
2874         * gtk/generate-inspector-gresource-manifest.py:
2875         (get_filenames): Convert filenames to use relative paths.
2876         (find_all_files_in_directory): Deleted.
2877         (find_all_files_in_directory.select_file): Deleted.
2878
2879 2014-09-18  Tanay C  <tanay.c@samsung.com>
2880
2881         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
2882         https://bugs.webkit.org/show_bug.cgi?id=136739
2883
2884         Reviewed by Gyuyoung Kim.
2885
2886         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
2887         (on_mouse_wheel): Modified.
2888
2889 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2890
2891         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
2892         https://bugs.webkit.org/show_bug.cgi?id=136923
2893
2894         Reviewed by Gustavo Noronha Silva.
2895
2896         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
2897         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
2898         the source.
2899
2900 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
2901
2902         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
2903         https://bugs.webkit.org/show_bug.cgi?id=136856
2904
2905         Reviewed by Darin Adler.
2906
2907         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2908         (RunLLINTCLoopTests.countFailures):
2909         (Run32bitJSCTests.countFailures):
2910         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2911         (RunLLINTCLoopTestsTest.test_failures):
2912         (RunLLINTCLoopTestsTest.test_failure):
2913         (RunLLINTCLoopTestsTest.test_no_failure):
2914         (Run32bitJSCTestsTest.test_failures):
2915         (Run32bitJSCTestsTest.test_failure):
2916         (Run32bitJSCTestsTest.test_no_failure):
2917
2918 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
2919
2920         GMainLoopSource is exposed to race conditions
2921         https://bugs.webkit.org/show_bug.cgi?id=135800
2922
2923         Reviewed by Carlos Garcia Campos.
2924
2925         Add unit tests for GMainLoopSource.
2926
2927         The tests check correct behavior of GMainLoopSource in various conditions --
2928         from the most simple rescheduling to rescheduling during dispatch, cancelling
2929         or destroying the GMainLoopSource during dispatch, proper destroy callback
2930         dispatching etc.
2931
2932         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
2933         State of the GMainLoopSource object (either ready, sheduled or active) is
2934         thoroughly tested throughout the lifetime of that object.
2935
2936         Still missing are tests for socket callbacks, which are a bit trickier because
2937         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
2938         are also not tested thoroughly, simply because it is at the moment impossible
2939         to test that the objects are actually destroyed when the corresponding source
2940         is finally deleted.
2941
2942         * TestWebKitAPI/PlatformGTK.cmake:
2943         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
2944         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
2945         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
2946         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
2947         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
2948         (TestWebKitAPI::GMainLoopSourceTest::finish):
2949         (TestWebKitAPI::GMainLoopSourceTest::source):
2950         (TestWebKitAPI::TEST):
2951
2952 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
2953
2954         Unreviewed, Update my email in contributors.json
2955
2956         * Scripts/webkitpy/common/config/contributors.json:
2957
2958 2014-09-17  Daniel Bates  <dabates@apple.com>
2959
2960         Unreviewed, rolling out r173695.
2961
2962         Broke building third-party Legacy WebKit apps; will
2963         investigate offline
2964
2965         Reverted changeset:
2966
2967         "[iOS] Make WebCore build with public iOS SDK"
2968         https://bugs.webkit.org/show_bug.cgi?id=136487
2969         http://trac.webkit.org/changeset/173695
2970
2971 2014-09-17  Daniel Bates  <dabates@apple.com>
2972
2973         [iOS] Make WebCore build with public iOS SDK
2974         https://bugs.webkit.org/show_bug.cgi?id=136487
2975
2976         Reviewed by David Kilzer.
2977
2978         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
2979
2980         * DumpRenderTree/mac/CheckedMalloc.cpp:
2981
2982 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2983
2984         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
2985         https://bugs.webkit.org/show_bug.cgi?id=136889
2986
2987         Reviewed by Gustavo Noronha Silva.
2988
2989         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2990         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
2991         event was added to the events vector.
2992         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2993         (loadFailedCallback): Do not assume the web view URI is the
2994         failing URI when the load fails before the committed state.
2995         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
2996         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
2997         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
2998         (LoadTrackingTest::loadFailedWithTLSErrors): Add
2999         LoadFailedWithTLSErrors event to the events vector.
3000         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
3001
3002 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
3003
3004         [EFL][GTK] Remove WebKit1 related codes
3005         https://bugs.webkit.org/show_bug.cgi?id=136853
3006
3007         Reviewed by Csaba Osztrogonác.
3008
3009         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
3010         from scripts.
3011
3012         * BuildSlaveSupport/build.webkit.org-config/config.json:
3013         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3014         (Compile32bitJSC):
3015         (BuildAndTestWebKit2Factory):
3016         (CompileWebKit1Only): Deleted.
3017         (CompileWebKit2Only): Deleted.
3018         (BuildAndTestWebKit1OnlyFactory): Deleted.
3019         (BuildAndTestWebKit2OnlyFactory): Deleted.
3020         * Scripts/build-webkit:
3021         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
3022         * Scripts/webkitpy/common/config/ports.py:
3023         (GtkWK2Port.build_webkit_command):
3024         (EflWK2Port.build_webkit_command):
3025         * Scripts/webkitpy/common/config/ports_unittest.py:
3026         (DeprecatedPortTest.test_gtk_wk2_port):
3027         * Scripts/webkitpy/port/efl.py:
3028         (EflPort.build_webkit_command):
3029         * Scripts/webkitpy/port/gtk.py:
3030         (GtkPort._built_libraries_path):
3031         (GtkPort._search_paths):
3032         (GtkPort.test_expectations_file_position):
3033         (GtkPort.build_webkit_command):
3034         (GtkPort.run_webkit_tests_command):
3035         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
3036
3037 2014-09-16  Daniel Bates  <dabates@apple.com>
3038
3039         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
3040         https://bugs.webkit.org/show_bug.cgi?id=136862
3041
3042         Reviewed by David Kilzer.
3043
3044         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3045         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3046         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
3047         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
3048
3049 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3050
3051         Mac queue slaves should reboot every so often
3052         https://bugs.webkit.org/show_bug.cgi?id=136791
3053
3054         Reviewed by Alexey Proskuryakov.
3055
3056         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
3057
3058         * EWSTools/start-queue-mac.sh:
3059
3060 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3061
3062         Unreviewed gardening, skip one more tests on Windows.
3063
3064         * Scripts/run-javascriptcore-tests:
3065
3066 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3067
3068         JSC test gardening
3069         https://bugs.webkit.org/show_bug.cgi?id=136823
3070
3071         Reviewed by Geoffrey Garen.
3072
3073         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
3074
3075 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3076
3077         Remove shouldAbortEarly cruft from master.cfg
3078         https://bugs.webkit.org/show_bug.cgi?id=136779
3079
3080         Reviewed by Csaba Osztrogonác.
3081
3082         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3083         (ConfigureBuild.start):
3084         (RunWebKitTests.start):
3085         (RunWebKit2Tests.start): Deleted.
3086
3087 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3088
3089         Remove ORWT related crufts from webkitdirs.pm
3090         https://bugs.webkit.org/show_bug.cgi?id=136821
3091
3092         Reviewed by Alexey Proskuryakov.
3093
3094         * Scripts/webkitdirs.pm:
3095         (isPerianInstalled): Deleted.
3096         (determineIPhoneSimulatorVersion): Deleted.
3097         (iPhoneSimulatorVersion): Deleted.
3098         (isSnowLeopard): Deleted.
3099         (isLion): Deleted.
3100         (quitIOSSimulator): Deleted.
3101
3102 2014-09-15  Roger Fong  <roger_fong@apple.com>
3103
3104         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
3105         https://bugs.webkit.org/show_bug.cgi?id=25160
3106
3107         * Scripts/run-javascriptcore-tests:
3108
3109 2014-09-15  Lucas Forschler  <lforschler@apple.com>
3110
3111         Add another Apple build slave to the Mountain Lion Debug WK1 queue
3112         
3113         Rubber stamped by Matt Hanson.
3114         
3115         * BuildSlaveSupport/build.webkit.org-config/config.json:
3116
3117 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3118
3119         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
3120         https://bugs.webkit.org/show_bug.cgi?id=136822
3121
3122         Reviewed by Gyuyoung Kim.
3123
3124         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
3125         initialized as we already does it in PlatformWebView::PlatformWebView
3126         calling ewk_init(). The reason for that was to ensure testing for example,
3127         WTF where creating the view is not mandatory.
3128
3129         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
3130         in order to properly initalize and release EWebKit.
3131
3132         * TestWebKitAPI/PlatformEfl.cmake:
3133         * TestWebKitAPI/efl/PlatformWebView.cpp:
3134         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3135         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3136         * TestWebKitAPI/efl/main.cpp:
3137         (main):
3138
3139 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
3140
3141         [WinCairo] Make it easier to enable/disable GStreamer.
3142         https://bugs.webkit.org/show_bug.cgi?id=135766
3143
3144         Reviewed by Brent Fulgham.
3145
3146         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
3147
3148         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
3149
3150 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
3151
3152         Web Inspector: remind about rebaselining generator test results
3153         https://bugs.webkit.org/show_bug.cgi?id=136759
3154
3155         Reviewed by Joseph Pecoraro.
3156
3157         For now, we can implement this as a watchlist message. Add watchlist
3158         groups and messages for the inspector and web replay generators.
3159
3160         * Scripts/webkitpy/common/config/watchlist:
3161
3162 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
3163
3164         build.webkit.org/dashboard: Overlapping text when status is long
3165         https://bugs.webkit.org/show_bug.cgi?id=136794
3166
3167         Reviewed by Timothy Hatcher.
3168
3169         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3170         (.status-line): Replaces height with min-height.
3171
3172 2014-09-12  Timothy Hatcher  <timothy@apple.com>
3173
3174         Make Brian Burg a WebKit reviewer.
3175
3176         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
3177
3178 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
3179
3180         Multiple EWS or commit bots can pick up processing of the same patch
3181         https://bugs.webkit.org/show_bug.cgi?id=136793
3182
3183         Reviewed by Ryosuke Niwa.
3184
3185         Change timeout from one hour to two hours. This will let bots finish, and in the
3186         unlikely event of a bot being frozen, will only delay patch processing restart by
3187         one hour.
3188
3189         * QueueStatusServer/app.yaml:
3190         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
3191
3192 2014-09-11  Andy Estes  <aestes@apple.com>
3193
3194         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
3195         https://bugs.webkit.org/show_bug.cgi?id=136768
3196
3197         Reviewed by Tim Horton.
3198
3199         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3200         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
3201         (TestWebKitAPI::TEST):
3202
3203 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3204
3205         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
3206         https://bugs.webkit.org/show_bug.cgi?id=136669
3207
3208         Reviewed by Antti Koivisto.
3209
3210         * Scripts/run-gtk-tests:
3211         (TestRunner): Unskip SSL test.
3212
3213 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
3214
3215         Strip extraneous AVFoundation and CoreMedia logging
3216         https://bugs.webkit.org/show_bug.cgi?id=136747
3217
3218         Reviewed by Jer Noble.
3219
3220         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3221         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
3222
3223         * Scripts/webkitpy/port/base.py:
3224         (Port.stderr_patterns_to_strip): Base class, empty list
3225
3226         * Scripts/webkitpy/port/driver.py:
3227         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
3228
3229         * Scripts/webkitpy/port/ios.py:
3230         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
3231
3232         * Scripts/webkitpy/port/mac.py:
3233         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
3234
3235
3236 2014-09-11  Michael Saboff  <msaboff@apple.com>
3237
3238         lldb_webkit.py:btjs doesn't work with release builds
3239         https://bugs.webkit.org/show_bug.cgi?id=136760
3240
3241         Reviewed by Jer Noble.
3242
3243         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
3244         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
3245         we can't get a valid result from trying either call.  In that case, we fallback to
3246         just showing the PC.  Also added check for both entry points.  If neither is found,
3247         we issue a warning and output the stack trace without JavaScript annotations.
3248
3249         * lldb/lldb_webkit.py:
3250         (btjs):
3251
3252 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
3253
3254         webkitpy test failures from import-w3c-tests
3255         https://bugs.webkit.org/show_bug.cgi?id=136752
3256
3257         Reviewed by Bem Jones-Bey.
3258
3259         This patch fixes a bug in import-w3c-tests where we were appending
3260         the wrong set of files to the copy_list. This also updates the tests
3261         to clear the failures introduced in the patch for bug 135929.
3262
3263         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3264         (W3CTestConverterTest.test_read_prefixed_property_list):
3265         * Scripts/webkitpy/w3c/test_parser.py:
3266         (TestParser.analyze_test):
3267         (TestParser.support_files):
3268         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3269
3270 2014-09-10  Brent Fulgham  <bfulgham@apple.com>
3271
3272         Blink merge: Speculative fix for windows run-webkit-tests hangs
3273         https://bugs.webkit.org/show_bug.cgi?id=136727
3274
3275         Reviewed by Csaba Osztrogonác.
3276
3277         Merged from Blink (patch by Dirk Pranke):
3278         <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
3279
3280         * Scripts/webkitpy/common/system/executive.py:
3281         (Executive.kill_process):
3282
3283 2014-09-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3284
3285         Added myself as a committer.
3286
3287         Unreviewed.
3288
3289         * Scripts/webkitpy/common/config/contributors.json:
3290
3291 2014-09-11  László Langó  <llango.u-szeged@partner.samsung.com>
3292
3293         [JavaScriptCore] Fix FTL on platform EFL.
3294         https://bugs.webkit.org/show_bug.cgi?id=133571
3295
3296         Reviewed by Filip Pizlo.
3297
3298         * efl/install-dependencies: Revert r169181.
3299         * efl/jhbuild.modules: Clone and build a custom branch.
3300         This branch contains some fix for FTL of platform EFL.
3301         The branch is a fork of llvm r206311.
3302
3303 2014-09-10  Tanay C  <tanay.c@samsung.com>
3304
3305         [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
3306         https://bugs.webkit.org/show_bug.cgi?id=136698
3307
3308         Reviewed by Gyuyoung Kim.
3309
3310         * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
3311         (on_mouse_wheel): Added.
3312         (window_free):
3313         (window_create):
3314
3315 2014-09-10  Rohit Kumar  <kumar.rohit@samsung.com>
3316
3317         [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
3318         https://bugs.webkit.org/show_bug.cgi?id=136284
3319
3320         Reviewed by Gyuyoung Kim.
3321
3322         * MiniBrowser/efl/main.c:
3323         (window_create):
3324
3325 2014-09-10  Rebecca Hauck  <rhauck@adobe.com>
3326
3327         import-w3c-tests doesn't handle relative paths to support files in ref files correctly
3328         https://bugs.webkit.org/show_bug.cgi?id=135929
3329
3330         Reviewed by Bem Jones-Bey.
3331
3332         The recent refactor of the W3C test repo falsified a bunch of assmumptions that
3333         were made when this script was originally written with respect to relative paths
3334         in ref files. This patch updates import-w3c-tests to update paths in ref files if
3335         they move relative to the test file.
3336
3337
3338         * Scripts/webkitpy/w3c/test_converter.py:
3339         (convert_for_webkit):
3340         (_W3CTestConverter.__init__):
3341         (_W3CTestConverter.convert_reference_relpaths):
3342         (_W3CTestConverter.convert_style_data):
3343         (_W3CTestConverter.convert_attributes_if_needed):
3344         * Scripts/webkitpy/w3c/test_importer.py:
3345         (TestImporter.find_importable_tests):
3346         (TestImporter.import_tests):
3347         * Scripts/webkitpy/w3c/test_parser.py:
3348         (TestParser.load_file):
3349         (TestParser.analyze_test):
3350         (TestParser.support_files):
3351
3352 2014-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3353
3354         [GTK] allow overwriting destination of download
3355         https://bugs.webkit.org/show_bug.cgi?id=136372
3356
3357         Reviewed by Carlos Garcia Campos.
3358
3359         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3360         (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
3361         (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
3362         (createFileAtDestination): Added
3363         (testDownloadOverwriteDestinationAllowed): Added
3364         (testDownloadOverwriteDestinationDisallowed): Added
3365         (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
3366         (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
3367         (beforeAll): New tests
3368
3369 2014-08-05  David Farler  <dfarler@apple.com>
3370
3371         iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
3372         https://bugs.webkit.org/show_bug.cgi?id=135551
3373
3374         Reviewed by Daniel Bates.
3375
3376         Prevent printing invalid Unicode strings going to stderr.
3377         Also, make filesystem.py more tolerant about receiving
3378         Unicode (encoded as UTF-8) when writing to files, in the
3379         rare case that an NSError description will make it to
3380         stderr, such as -[LTRelayController createUniqueApp].
3381
3382         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3383         (-[LTRelayController launchSimulator]): Removed.
3384         (-[LTRelayController createUniqueApp]):
3385         Don't explicitly try to uninstall the app. It is automatically handled
3386         when installing an app with the same bundle identifier.
3387         (-[LTRelayController start]):
3388         (-[LTRelayController bootDevice]): Removed.
3389         The device already boots as a part of starting the simulator. Attempting
3390         to boot a second time may cause spurious stderr output.
3391         * Scripts/webkitpy/port/driver.py:
3392         (IOSSimulatorDriver._setup_environ_for_driver):
3393         Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
3394         Open the iOS Simulator once instead of the LayoutTestRelay trying
3395         to do it.
3396         * Scripts/webkitpy/port/ios.py:
3397         (IOSSimulatorPort._get_crash_log):
3398         Make sure stderr is at least an empty string.
3399         (IOSSimulatorPort):
3400         (IOSSimulatorPort.developer_dir):
3401         New property for setting up DEVELOPER_DIR in the driver environment.
3402
3403 2014-09-09  Dan Bernstein  <mitz@apple.com>
3404
3405         Clean up the MiniBrowser Xcode project
3406         https://bugs.webkit.org/show_bug.cgi?id=136684
3407
3408         Reviewed by Tim Horton.
3409
3410         * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
3411         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
3412         WebKit2.framework. Upgraded project file version.
3413
3414 2014-09-09  Daniel Bates  <dbates@webkit.org>
3415
3416         svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
3417         https://bugs.webkit.org/show_bug.cgi?id=136379
3418
3419         Reviewed by David Kilzer.
3420
3421         Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
3422         a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
3423         and sets a property on F (say, the executable bit).
3424
3425         * Scripts/svn-apply:
3426         (patch): Only add file if the diff has text chunks.
3427         * Scripts/svn-unapply:
3428         (patch): Only delete added file if the diff has text chunks.
3429
3430 2014-09-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3431
3432         [GTK] Unreviewed GTK gardening.
3433
3434         * Scripts/run-gtk-tests:
3435         (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
3436
3437 2014-09-09  Christophe Dumez  <cdumez@apple.com>
3438
3439         Update my email in contributors.json
3440         https://bugs.webkit.org/show_bug.cgi?id=136671
3441
3442         Reviewed by Andreas Kling.
3443
3444         * Scripts/webkitpy/common/config/contributors.json:
3445
3446 2014-09-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3447
3448         [EFL] Enable fixed layout by default
3449         https://bugs.webkit.org/show_bug.cgi?id=136607
3450
3451         Reviewed by Csaba Osztrogonác.
3452
3453         Fixed layout is being used by Tizen platform by default. However, the feature
3454         has still many defects now. So, we need to enable it by default, then should fix
3455         those bugs. 
3456
3457         * MiniBrowser/efl/main.c:
3458
3459 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3460
3461         Remove FILTERS flag
3462         https://bugs.webkit.org/show_bug.cgi?id=136571
3463
3464         Reviewed by Darin Adler.
3465
3466         * Scripts/webkitperl/FeatureList.pm:
3467
3468 2014-09-08  Alexey Proskuryakov  <ap@apple.com>
3469
3470         Dashboard metrics should ignore commits that didn't trigger builds
3471         https://bugs.webkit.org/show_bug.cgi?id=136618
3472
3473         Reviewed by Darin Adler.
3474
3475         Commits that didn't trigger builds are ones like ChangeLog updates, patches for
3476         other platforms etc. It does not make sense to count wait time for these, as it
3477         can be arbitrarily long.
3478
3479         The new algorithm is much slower asymptotically, but it's OK, computers are fast.
3480
3481         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3482         (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
3483
3484         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3485         We used to walk the timeline to see which revisions are fully tested, but that's not
3486         correct. A revision that's only tested by a subset of queues finishes independently
3487         of another that's tested by another subset. Now, we just search for the answer for
3488         each revision individually.
3489
3490         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
3491         (MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
3492         the analyzer now reports. Removed best time, which is more confusing than meaningful.
3493
3494 2014-09-08  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3495
3496         Remove EWebLauncher from webkitdirs.pm
3497         https://bugs.webkit.org/show_bug.cgi?id=136622
3498
3499         Reviewed by Gyuyoung Kim.
3500
3501         * Scripts/webkitdirs.pm:
3502         (launcherName):
3503
3504 2014-09-06  Sam Weinig  <sam@webkit.org>
3505
3506         XPCPtr should be converted into an all purpose smart pointer for os_objects
3507         https://bugs.webkit.org/show_bug.cgi?id=136602
3508
3509         Reviewed by Darin Adler.
3510
3511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3512         * TestWebKitAPI/Tests/WTF/darwin: Added.
3513         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
3514         Add basic unit tests for OSObjectPtr.
3515
3516 2014-09-06  Saam Barati  <saambarati1@gmail.com>
3517
3518         Unreviewed. Add myself as a committer.
3519
3520         * Scripts/webkitpy/common/config/contributors.json:
3521
3522 2014-09-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3523
3524         Unreviewed, EFL build fix when SHARED_CORE is on.
3525
3526         * TestWebKitAPI/PlatformEfl.cmake:
3527
3528 2014-09-05  Lucas Forschler  <lforschler@apple.com>
3529
3530         <https://webkit.org/b/136586> Add bots to Apple build/test queues
3531         
3532         Reviewed by Daniel Bates.
3533
3534         * BuildSlaveSupport/build.webkit.org-config/config.json:
3535
3536 2014-09-05  Alexey Proskuryakov  <ap@apple.com>
3537
3538         Buildbot metrics page gives wrong results after a new bot gets added
3539         https://bugs.webkit.org/show_bug.cgi?id=136516
3540
3541         Reviewed by Tim Horton.
3542
3543         Part 2: Fix elapsed times.
3544
3545         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3546         (Analyzer.prototype._countTimes): Made lastTestedRevisionByQueue contain undefined values
3547         until the first build in a queue. This happens to work as needed with _fullyTestedRevisionNumber().
3548
3549 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3550
3551         [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
3552         https://bugs.webkit.org/show_bug.cgi?id=136562
3553
3554         Reviewed by Martin Robinson.
3555
3556         * Scripts/run-gtk-tests:
3557         (TestRunner): Remove failure expectations for tests that now pass.
3558
3559 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
3560
3561         Dashboard metrics page wastes a lot of time sorting iterations
3562         https://bugs.webkit.org/show_bug.cgi?id=136559
3563
3564         Reviewed by Tim Horton.
3565
3566         Also fixes comments here and there, and adds a missing "var".
3567
3568         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3569         (BuildbotIteration.prototype._parseData):
3570         (BuildbotIteration.prototype._updateWithData):
3571         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3572         (BuildbotQueue.prototype.loadAll):
3573         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3574         (Analyzer.prototype._countTimes):
3575
3576 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3577
3578         [GTK] Unreviewed GTK gardening.
3579
3580         * Scripts/run-gtk-tests:
3581         (TestRunner): Skip tests failing since r173272.
3582
3583 2014-09-04  Simon Fraser  <simon.fraser@apple.com>
3584
3585         Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
3586         https://bugs.webkit.org/show_bug.cgi?id=136561
3587
3588         Reviewed by Tim Horton.
3589         
3590         Log for calloc() and CGBitmapContextCreate() failures.
3591
3592         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3593         (createBitmapContext):
3594         (createBitmapContextFromWebView):
3595
3596 2014-09-04  Andy Estes  <aestes@apple.com>
3597
3598         Fix the Mac Production build after r173283.
3599
3600         * WebKitTestRunner/config.h: Reverted to defining WEBCORE_EXPORT for now.
3601
3602 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
3603
3604         [Win] webkitpy test suite frequently fails to complete
3605         https://bugs.webkit.org/show_bug.cgi?id=136546
3606
3607         Reviewed by Daniel Bates.
3608
3609         Properly convert the ASCII crash log produced by ntsd into
3610         a unicode string as early as possible so that we handle it
3611         properly when generating our logs and other test support output.
3612
3613         We were mixing ASCII/unicode strings under Windows, which was
3614         causing test system failures when we processed some crash logs.
3615
3616         Also do a better job of handling garbage pid entries in the
3617         Cygwin lock files.
3618
3619         * Scripts/webkitpy/common/system/crashlogs.py:
3620         (CrashLogs._find_newest_log_win): The ntsd '.logopen' command
3621         creates an ASCII file. Decode it as ASCII, not 'utf-8', and
3622         handle the strings as unicode from that point on.
3623         * Scripts/webkitpy/port/http_lock.py:
3624         (HttpLock._current_lock_pid): Add logging and handle case of
3625         the current_pid failing to cleanly convert to 'int'.
3626         * Scripts/webkitpy/port/win.py:
3627         (WinPort): Add 64-bit architecture as a known target for the
3628         Windows build.
3629
3630 2014-09-04  Andy Estes  <aestes@apple.com>
3631
3632         Address additional review feedback after landing r173283.
3633
3634         Reviewed by