1 2012-01-27 Roland Takacs <takacs.roland@stud.u-szeged.hu>
3 Update committers.py with new contributors.
4 https://bugs.webkit.org/show_bug.cgi?id=77207
6 I added six new contributors into committers.py:
13 - Szilard Ledan-Muntean
15 * Scripts/webkitpy/common/config/committers.py:
17 2012-01-27 Vsevolod Vlasov <vsevik@chromium.org>
19 Add Vsevolod Vlasov to reviewers list.
21 Reviewed by Pavel Feldman.
23 * Scripts/webkitpy/common/config/committers.py:
25 2012-01-26 No'am Rosenthal <noam.rosenthal@nokia.com> and Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
27 [Qt] WKTR: Use a software rendering pipiline when running tests.
28 https://bugs.webkit.org/show_bug.cgi?id=76708
30 Reviewed by Kenneth Rohde Christiansen.
32 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
33 (WTR::WrapperWindow::WrapperWindow):
34 (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
36 2012-01-26 Kevin Ollivier <kevino@theolliviers.com>
38 [wx] Unreviewed. Build fix, add WebCore/testing/js
39 to the list of source directories we build.
41 * waf/build/settings.py:
43 2012-01-26 Filip Pizlo <fpizlo@apple.com>
45 Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
46 https://bugs.webkit.org/show_bug.cgi?id=77177
48 Reviewed by Jon Honeycutt.
50 * Scripts/commit-log-editor:
52 2012-01-26 Ojan Vafai <ojan@chromium.org>
54 Decrease sleep time when killing server_process on Mac.
55 https://bugs.webkit.org/show_bug.cgi?id=77169
57 Reviewed by Eric Seidel.
59 This shaves another ~70ms off single test runtime.
61 * Scripts/webkitpy/layout_tests/port/server_process.py:
64 2012-01-26 Ojan Vafai <ojan@chromium.org>
66 Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
67 https://bugs.webkit.org/show_bug.cgi?id=77164
69 Reviewed by Dirk Pranke.
71 http://trac.webkit.org/changeset/106035 depends on builder_name being
72 falsey by default. There's other code that requires it to be iterable
73 by default. So, make it be the empty string.
75 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
78 2012-01-26 Ryosuke Niwa <rniwa@webkit.org>
80 run-perf-test should include relative file paths in test names
81 https://bugs.webkit.org/show_bug.cgi?id=77144
83 Reviewed by Adam Birth.
85 Include all directory names in the test name separated by "/".
86 e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
88 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
90 (PerfTestsRunner._process_parser_test_result):
91 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
92 (test_run_test_set_with_json_output):
93 (test_run_test_set_with_json_source):
95 2012-01-26 Dirk Pranke <dpranke@chromium.org>
97 webkitpy: re-land cleanup of test scaffolding
98 https://bugs.webkit.org/show_bug.cgi?id=77153
100 Reviewed by Eric Seidel.
102 This is an attempt to reland the change in bug 76973 /
103 r105935. My earlier attempt to manipulate PYTHONPATH
104 seems to only work some of the time, for reasons that
105 elude me. Directly adding Tools/Scripts to sys.path from
106 inside the test script appears to work (more?) reliably.
108 Also, it seemed like the files didn't actually get deleted
109 the last time; I don't know why.
111 * Scripts/test-webkitpy:
112 * Scripts/webkitpy/common/system/executive_unittest.py:
115 (ExecutiveTest.test_run_command_args_type):
116 (ExecutiveTest.test_run_command_with_unicode):
117 (ExecutiveTest.test_running_pids):
119 * Scripts/webkitpy/common/system/fileutils.py: Removed.
120 * Scripts/webkitpy/test/cat.py: Removed.
121 * Scripts/webkitpy/test/cat_unittest.py: Removed.
122 * Scripts/webkitpy/test/echo.py: Removed.
123 * Scripts/webkitpy/test/echo_unittest.py: Removed.
125 2012-01-26 Ojan Vafai <ojan@chromium.org>
127 run-webkit-tests calls "nm" when it doesn't need to
128 https://bugs.webkit.org/show_bug.cgi?id=77143
130 Reviewed by Dirk Pranke.
132 If we are not running any test that can be skipped by checking
133 the DRT feature list or looking at the list of symbols, avoid calling
134 out to DRT or calling "nm".
136 This saves ~700ms on my Mac Pro. In cases where you still have to call out
137 to "nm" it's only a couple ms slower.
139 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
140 (TestExpectations.__init__):
141 * Scripts/webkitpy/layout_tests/port/base.py:
142 (Port.skipped_tests):
143 * Scripts/webkitpy/layout_tests/port/webkit.py:
144 (WebKitPort._should_check_for_missing_features):
146 (WebKitPort._should_check_for_missing_symbols):
147 (WebKitPort._skipped_tests_for_unsupported_features):
148 (WebKitPort.skipped_layout_tests):
149 (WebKitPort.skipped_tests):
150 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
151 (WebKitPortTest.test_skipped_directories_for_symbols):
152 (test_skipped_directories_for_features):
153 (test_skipped_directories_for_features_no_matching_tests_in_test_list):
154 (test_skipped_layout_tests):
156 2012-01-26 Benjamin Poulain <bpoulain@apple.com>
158 Support a suffix on ChangeLog filenames based on a configuration file
159 https://bugs.webkit.org/show_bug.cgi?id=76956
161 Reviewed by Kentaro Hara.
163 Modify the tools used to generate, edit and resolve ChangeLogs to support
164 the addition of a suffix to the ChangeLog filename.
166 This patch makes it easier to support alternate ChangeLog files in branches.
168 * Scripts/VCSUtils.pm:
171 * Scripts/commit-log-editor:
172 * Scripts/prepare-ChangeLog:
173 (getLatestChangeLogs):
174 (generateNewChangeLogs):
176 * Scripts/resolve-ChangeLogs:
179 2012-01-26 Sheriff Bot <webkit.review.bot@gmail.com>
181 Unreviewed, rolling out r106038.
182 http://trac.webkit.org/changeset/106038
183 https://bugs.webkit.org/show_bug.cgi?id=77142
185 Caused a bunch of skipped tests to not be skipped. (Requested
188 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
189 (TestExpectationParser):
190 (TestExpectationParser.parse):
191 (TestExpectationParser._parse_line):
192 (TestExpectationParser._collect_matching_tests):
193 (TestExpectations.__init__):
194 (TestExpectations._add_skipped_tests):
195 * Scripts/webkitpy/layout_tests/port/base.py:
197 (Port.normalize_test_name):
198 (Port.update_baseline):
199 (Port.layout_tests_dir):
200 (Port.relative_perf_test_filename):
201 (Port.abspath_for_test):
203 2012-01-25 Ojan Vafai <ojan@chromium.org>
205 Parsing test_expecations.txt + Skipped lists takes too long
206 https://bugs.webkit.org/show_bug.cgi?id=77059
208 Reviewed by Dirk Pranke.
210 This saves ~100ms on the Apple Mac port.
211 -memoize a bunch of path methods.
212 -Avoid doing multiple disk accesses per line.
213 -Parse the skipped list directly instead of turning it into a test_expecations.txt
214 formatting string and parsing that.
216 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
217 (TestExpectationParser):
218 (TestExpectationParser.parse_skipped_tests):
219 (TestExpectationParser._parse_line):
220 (TestExpectationParser._collect_matching_tests):
221 (TestExpectations.__init__):
222 (TestExpectations._add_skipped_tests):
223 * Scripts/webkitpy/layout_tests/port/base.py:
226 (Port.normalize_test_name):
227 (Port.layout_tests_dir):
228 (Port.abspath_for_test):
230 2012-01-25 Ojan Vafai <ojan@chromium.org>
232 Only store the SVN revision in the summarized results if we're on a builder
233 https://bugs.webkit.org/show_bug.cgi?id=76976
235 Reviewed by Dirk Pranke.
237 This shaves another ~130ms off the single test run-webkit-tests runtime.
239 * Scripts/webkitpy/layout_tests/controllers/manager.py:
241 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
242 (ResultSummaryTest.get_result):
244 (ResultSummaryTest.get_result_summary):
245 (ResultSummaryTest.get_unexpected_results):
246 (ResultSummaryTest.test_no_svn_revision):
247 (ResultSummaryTest.test_svn_revision):
248 * Scripts/webkitpy/layout_tests/port/base.py:
249 (Port.use_trac_links_in_results_html):
251 2012-01-26 Luciano Wolf <luciano.wolf@openbossa.org>
253 [Qt][WK2] fast/loader tests failed after r94178
254 https://bugs.webkit.org/show_bug.cgi?id=67388
256 Reviewed by Simon Hausmann.
258 Applying the same fix used for Qt-WebKit1 from bug #67254 -
259 [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
260 https://bugs.webkit.org/show_bug.cgi?id=67254
261 Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
262 derived from the running location of DumpRenderTree binary.
264 * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
265 (WTR::LayoutTestController::pathToLocalResource):
267 2012-01-26 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
269 Implement overridePreference for boolean preferences in WebKitTestRunner
270 https://bugs.webkit.org/show_bug.cgi?id=77033
272 Reviewed by Alexey Proskuryakov.
274 For now overridePreference supports boolean values.
276 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
277 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
278 (WTR::LayoutTestController::setXSSAuditorEnabled):
279 (WTR::LayoutTestController::overridePreference):
280 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
281 * WebKitTestRunner/TestController.cpp:
282 (WTR::TestController::resetStateToConsistentValues): Reset the overrides
283 explicitly and properly disable the use of PageCache when resetting the
284 state. Tests that use PageCache can now enable it via overridePreference.
286 2012-01-26 Alexander Færøy <alexander.faeroy@nokia.com>
288 [Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
289 https://bugs.webkit.org/show_bug.cgi?id=77100
291 Reviewed by Simon Hausmann.
293 This patch makes the MiniBrowser read multiple URL's from the command
294 line such that there will be one browser window opened for each URL.
296 * MiniBrowser/qt/MiniBrowserApplication.cpp:
297 (MiniBrowserApplication::handleUserOptions):
299 2012-01-26 Alexander Færøy <alexander.faeroy@nokia.com>
301 [Qt] The Qt MiniBrowser crashes when given multiple URL's
302 https://bugs.webkit.org/show_bug.cgi?id=77009
304 Reviewed by Simon Hausmann.
306 This patch fixes a crash in BrowserWindow::newWindow() where a
307 BrowserWindow-object is constructed with a 0 pointer as the
308 WindowOptions parameter which leads to a crash.
310 * MiniBrowser/qt/BrowserWindow.cpp:
311 (BrowserWindow::BrowserWindow):
312 (BrowserWindow::newWindow):
313 * MiniBrowser/qt/BrowserWindow.h:
315 2012-01-26 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
317 [Qt] Use ICU if available
318 https://bugs.webkit.org/show_bug.cgi?id=76821
320 Reviewed by Simon Hausmann.
322 Adding unicode defines for a Qt 5 based build.
324 * qmake/mkspecs/features/features.prf:
326 2012-01-26 Nándor Huszka <huszka.nandor@stud.u-szeged.hu>
328 [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
329 https://bugs.webkit.org/show_bug.cgi?id=42545
331 Reviewed by Zoltan Herczeg.
333 Implement the setGeolocationPermission method.
335 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
336 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
337 (WTR::LayoutTestController::setGeolocationPermission):
339 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
340 (LayoutTestController):
342 2012-01-26 Balazs Kelemen <kbalazs@webkit.org>
344 [NRWT] Support --ignore-metrics
345 https://bugs.webkit.org/show_bug.cgi?id=76278
347 Reviewed by Tony Chang.
349 Port the feature from ORWT.
351 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
352 (SingleTestRunner._run_compare_test):
353 * Scripts/webkitpy/layout_tests/port/driver.py:
355 (DriverOutput.strip_metrics):
356 * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
358 (DriverOutputTest.test_strip_metrics):
359 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
360 (_set_up_derived_options):
363 2012-01-26 Sheriff Bot <webkit.review.bot@gmail.com>
365 Unreviewed, rolling out r105935 and r105954.
366 http://trac.webkit.org/changeset/105935
367 http://trac.webkit.org/changeset/105954
368 https://bugs.webkit.org/show_bug.cgi?id=77080
370 test-webkitpy is still broken (Requested by abarth on
373 * Scripts/test-webkitpy:
374 * Scripts/webkitpy/common/system/executive_unittest.py:
375 (never_ending_command):
376 (ExecutiveTest.test_run_command_args_type):
377 (ExecutiveTest.test_run_command_with_unicode):
378 (ExecutiveTest.test_running_pids):
379 * Scripts/webkitpy/common/system/fileutils.py:
380 (make_stdout_binary):
381 * Scripts/webkitpy/test/cat.py:
384 * Scripts/webkitpy/test/cat_unittest.py:
386 (CatTest.assert_cat):
387 (CatTest.test_basic):
388 (CatTest.test_no_newline):
389 (CatTest.test_unicode):
390 (CatTest.test_as_command):
391 * Scripts/webkitpy/test/echo.py:
394 * Scripts/webkitpy/test/echo_unittest.py:
396 (EchoTest.test_basic):
397 (EchoTest.test_no_newline):
398 (EchoTest.test_unicode):
399 (EchoTest.test_argument_order):
400 (EchoTest.test_empty_arguments):
401 (EchoTest.test_no_arguments):
402 (EchoTest.test_as_command):
404 2012-01-26 Gabor Rapcsanyi <rgabor@webkit.org>
406 [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
407 https://bugs.webkit.org/show_bug.cgi?id=76138
409 Reviewed by Martin Robinson.
411 * Scripts/webkitdirs.pm:
412 (isCrossCompilation):
413 (buildAutotoolsProject):
415 2012-01-25 Adam Barth <abarth@webkit.org>
417 Kentaro is a reviewer now. Yay!
419 * Scripts/webkitpy/common/config/committers.py:
421 2012-01-25 Dirk Pranke <dpranke@chromium.org>
423 nrwt: running w/ no arguments fails
424 https://bugs.webkit.org/show_bug.cgi?id=77064
426 Unreviewed, build fix.
428 This change fixes a regression introduced in r105944
429 where running without --platform <foo> or one of the other
430 platform switches would cause a null deref :(.
432 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
435 2012-01-25 Eric Seidel <eric@webkit.org>
437 Automatically CC someone from Apple on any changes to Obj-C public API
438 https://bugs.webkit.org/show_bug.cgi?id=77053
440 Reviewed by Timothy Hatcher.
442 This has long been de-facto practice, seems now that we have
443 fancy watchlist support, we should just make the tools
444 do this automatically.
446 * Scripts/webkitpy/common/config/watchlist:
448 2012-01-25 Antoine Labour <piman@chromium.org>
450 Updating status in committers.py.
454 * Scripts/webkitpy/common/config/committers.py:
456 2012-01-25 Dirk Pranke <dpranke@chromium.org>
458 test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
459 https://bugs.webkit.org/show_bug.cgi?id=77058
461 Reviewed by Eric Seidel.
463 r105935 broke executive_unittest by changing which script we
464 were running and not ensuring that the PYTHONPATH was set up
467 This change also fixes a regression introduced recently where
468 test-webkitpy wasn't figuring out the path to Tools/Scripts
469 right, either (so running ./test-webkitpy would fail).
471 * Scripts/test-webkitpy:
472 * Scripts/webkitpy/common/system/executive_unittest.py:
474 (ExecutiveTest.setUp):
476 (ExecutiveTest.tearDown):
478 2012-01-25 Adam Barth <abarth@webkit.org>
480 Disable tests on the mac-ews while we sort out hte stability issues.
482 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
485 2012-01-23 Dirk Pranke <dpranke@chromium.org>
487 investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
488 https://bugs.webkit.org/show_bug.cgi?id=76475
490 Reviewed by Eric Seidel.
492 This patch cleans up the internal usage of port names for the
493 Apple mac and Apple win ports so that 'mac' and 'win are never
494 considered "fully specified" port names: they are still legal
495 input to the PortFactory.get() routine, but only if run on the given
496 platform (i.e. trying to PortFactory.get('mac') on windows or
497 linux will return an error, since we don't know which version of
500 This also cleans up handling of the webkit2 variants, so that
501 the full port names consistently follow the
502 <operating_system>-<version>[-<wk2>] convention.
504 Lastly this patch adds some assertions and removes some
505 try/catch logic to catch more programming and usage errors;
506 previously mac-tiger might've been allowed -- and it would've
507 translated into using just the baselines in platform/mac -- but
510 * Scripts/webkitpy/layout_tests/port/apple.py:
511 (ApplePort.determine_full_port_name):
512 (ApplePort.__init__):
514 (ApplePort._port_name_with_version):
515 * Scripts/webkitpy/layout_tests/port/builders.py:
516 * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
517 (FactoryTest.test_mac):
518 (FactoryTest.test_win):
519 * Scripts/webkitpy/layout_tests/port/mac.py:
520 (MacPort.baseline_search_path):
521 * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
522 (MacTest.test_versions):
523 * Scripts/webkitpy/layout_tests/port/win.py:
524 (WinPort.baseline_search_path):
525 * Scripts/webkitpy/layout_tests/port/win_unittest.py:
526 (WinTest.test_versions):
528 2012-01-25 Dirk Pranke <dpranke@chromium.org>
530 webkitpy: print nicer errors while linting expectations files, remove redundant tests
531 https://bugs.webkit.org/show_bug.cgi?id=76955
533 Reviewed by Adam Barth.
535 This change cleans up the errors that are printed so that the
536 are more "quickfix" compatible (path:lineno).
538 Also, there were a bunch of redundant tests between
539 layout_tests.models.test_expectations_unittest and
540 style.checkers.test_expectations_unittest. The latter should
541 just expect the former to do most of the testing.
543 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
544 (TestExpectationParser._parse_modifiers):
545 (TestExpectations._report_errors):
546 (TestExpectations._add_skipped_tests):
547 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
548 (test_parse_error_nonfatal):
549 (SemanticTests.test_bad_bugid):
550 * Scripts/webkitpy/style/checkers/test_expectations.py:
551 (TestExpectationsChecker.__init__):
552 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
553 (TestExpectationsTestCase.assert_lines_lint):
554 (TestExpectationsTestCase.test_valid_expectations):
555 (TestExpectationsTestCase.test_invalid_expectations):
556 (TestExpectationsTestCase.test_tab):
558 2012-01-25 Eric Seidel <eric@webkit.org>
560 webkit-patch apply-* should always continue after failures
561 https://bugs.webkit.org/show_bug.cgi?id=77057
563 Reviewed by Adam Barth.
565 As far as I can tell there is only one potential drawback to always
566 forcing: that if you're somehow in the wrong directory it will create new
567 directories for new files. Since webkit-patch always cd's to the root
568 it seems that's not a drawback. The drawback of not using --force for
569 svn-apply, is that it will stop after the first failure, which is rarely
570 (if ever) the desired behavior. This just removes the force option
571 (which was strangely hidden behind --non-interactive). This should
572 make for a better user experiance.
574 * Scripts/webkitpy/common/checkout/checkout.py:
575 (Checkout.apply_patch):
576 * Scripts/webkitpy/common/checkout/checkout_mock.py:
577 (MockCheckout.apply_patch):
578 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
579 (CheckoutTest.test_chromium_deps):
581 (CheckoutTest.test_apply_patch):
582 * Scripts/webkitpy/tool/commands/download_unittest.py:
583 (DownloadCommandsTest._default_options):
584 * Scripts/webkitpy/tool/steps/applypatch.py:
585 (ApplyPatch.options):
587 * Scripts/webkitpy/tool/steps/options.py:
590 2012-01-25 Dirk Pranke <dpranke@chromium.org>
592 nrwt: should be able to run --platform test interactively
593 https://bugs.webkit.org/show_bug.cgi?id=76959
595 Reviewed by Adam Barth.
597 As part of refactoring the Port interfaces, in r103254 I made
598 passing a Host object to the Port mandatory; previously TestPort
599 objects would create their own (mock) hosts. However,
600 new-run-webkit-tests always passed a real Host, not a MockHost,
601 and so you couldn't run new-run-webkit-tests --platform test
602 interactively to debug test failures.
604 This change fixes that by creating a MockHost instead of a real
605 host if you say --platform test*.
607 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
610 2012-01-25 Dirk Pranke <dpranke@chromium.org>
612 run-webkit-tests --lint-test-files should lint all the ports by default
613 https://bugs.webkit.org/show_bug.cgi?id=76749
615 Reviewed by Ojan Vafai.
617 Currently run-webkit-tests --lint-test-files will only lint the
618 test_expectations for the single port determined by the command
619 line options. This is not obvious and can produce unintended results
620 if you want to lint the chromium port (probably the normal case
621 for using --lint-test-files) but don't specify a port name or
624 I think we should probably lint *all* of the ports if no port
625 name is supplied. This change implements that, and also moves
626 the linting logic out of the Manager class, since this really
627 has nothing to do with Managers. It has little to do with
628 run-webkit-tests, but splitting it into a different script would
629 introduce compatibility issues. It might make sense to do that
630 anyway, in a separate patch and combining that with cleaning up
631 the style checker to share more code.
633 * Scripts/webkitpy/layout_tests/controllers/manager.py:
634 (Manager._strip_test_dir_prefix):
635 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
638 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
639 (LintTest.test_all_configurations): added.
640 (LintTest.test_lint_test_files): added.
641 (LintTest.test_lint_test_files__errors): added.
642 (MainTest.test_lint_test_files): removed.
643 (MainTest.test_lint_test_files__errors): removed.
645 2012-01-25 Dirk Pranke <dpranke@chromium.org>
647 webkitpy: clean up a bunch of test scaffolding
648 https://bugs.webkit.org/show_bug.cgi?id=76973
650 Reviewed by Eric Seidel.
652 There were several helper modules in the webkitpy.test package
653 that appear to only be used by executive_unittest.py. I am
654 rolling them all into that file to make that clearer.
656 * Scripts/webkitpy/common/system/executive_unittest.py:
657 (ExecutiveTest.test_run_command_args_type):
658 (ExecutiveTest.test_run_command_with_unicode):
659 (ExecutiveTest.test_running_pids):
662 * Scripts/webkitpy/common/system/fileutils.py: Removed.
663 * Scripts/webkitpy/test/cat.py: Removed.
664 * Scripts/webkitpy/test/cat_unittest.py: Removed.
665 * Scripts/webkitpy/test/echo.py: Removed.
666 * Scripts/webkitpy/test/echo_unittest.py: Removed.
668 2012-01-25 Dirk Pranke <dpranke@chromium.org>
670 webkitpy: clean up a bunch of test scaffolding
671 https://bugs.webkit.org/show_bug.cgi?id=76973
673 Reviewed by Eric Seidel.
675 There were several helper modules in the webkitpy.test package
676 that appear to only be used by executive_unittest.py. I am
677 rolling them all into that file to make that clearer.
679 * Scripts/webkitpy/common/system/executive_unittest.py:
680 (ExecutiveTest.test_run_command_args_type):
681 (ExecutiveTest.test_run_command_with_unicode):
682 (ExecutiveTest.test_running_pids):
685 * Scripts/webkitpy/common/system/fileutils.py: Removed.
686 * Scripts/webkitpy/test/cat.py: Removed.
687 * Scripts/webkitpy/test/cat_unittest.py: Removed.
688 * Scripts/webkitpy/test/echo.py: Removed.
689 * Scripts/webkitpy/test/echo_unittest.py: Removed.
691 2012-01-25 Eric Seidel <eric@webkit.org>
693 Remove Python 2.5 support from WebKit
694 https://bugs.webkit.org/show_bug.cgi?id=71593
696 Reviewed by Adam Barth.
698 Just removing support from this one core file.
699 I'll commit the rest of the (large) change once we've
700 gone 24 hours and seen that no bots have exploded.
701 We can roll out this one change if we break bots
702 and then roll in the rest once those bots are fixed.
704 * Scripts/webkitpy/common/system/executive.py:
705 (Executive.cpu_count):
707 2012-01-25 Hajime Morita <morrita@google.com>
709 ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
710 https://bugs.webkit.org/show_bug.cgi?id=76863
712 Reviewed by Dimitri Glazkov.
714 Added a feature flag.
716 * Scripts/build-webkit:
717 * qmake/mkspecs/features/features.prf:
719 2012-01-25 Martin Robinson <mrobinson@igalia.com>
721 [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
722 https://bugs.webkit.org/show_bug.cgi?id=76344
724 Reviewed by Sam Weinig.
726 Add a test verifying that the mouse button during policy decisions for
727 events not triggered by mouse events is NoButton.
729 * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
730 (TestWebKitAPI::decidePolicyForNavigationAction): Added test.
731 (TestWebKitAPI::decidePolicyForNewWindowAction): Added test.
733 2012-01-25 Ryosuke Niwa <rniwa@webkit.org>
735 run-perf-tests should timeout sooner
736 https://bugs.webkit.org/show_bug.cgi?id=77026
738 Reviewed by Adam Barth.
740 Bump off the timeout from 10 minutes to 4 minutes.
742 Also use float instead of str in test result values to compress the size of json files bots upload.
744 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
745 (PerfTestsRunner._parse_args):
746 (PerfTestsRunner._process_chromium_style_test_result):
747 (PerfTestsRunner._process_parser_test_result):
748 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
749 (test_run_test_set_for_parser_tests):
750 (test_run_test_set_with_json_output):
751 (test_run_test_set_with_json_source):
753 2012-01-25 Enrica Casucci <enrica@apple.com>
755 WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
756 https://bugs.webkit.org/show_bug.cgi?id=76951
757 <rdar://problem/9325158>
759 Reviewed by Alexey Proskuryakov.
761 * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
763 (TestWebKitAPI::TEST):
765 2012-01-23 MORITA Hajime <morrita@google.com>
767 [Refactoring][Internals] Should have InternalSettings
768 https://bugs.webkit.org/show_bug.cgi?id=76424
770 Reviewed by Kent Tamura.
772 * GNUmakefile.am: Added so new files.
774 2012-01-25 Takashi Toyoshima <toyoshim@chromium.org>
776 webkitpy: new-run-webkit-websocket is broken
777 https://bugs.webkit.org/show_bug.cgi?id=76999
779 Reviewed by Dirk Pranke.
781 r105674 broke new-run-webkit-websocket, since options.chromium
782 doesn't exist any more. new-run-webkit-httpd was also broken
783 and already fixed at r105835.
784 * Scripts/new-run-webkit-websocketserver:
787 2012-01-25 Nándor Huszka <huszka.nandor@stud.u-szeged.hu>
789 [WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
790 https://bugs.webkit.org/show_bug.cgi?id=63458
792 Reviewed by Adam Roben.
794 Implement the setPopupBlockingEnabled method.
796 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
797 * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
798 (WTR::LayoutTestController::setPopupBlockingEnabled):
799 * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
801 2012-01-24 Balazs Kelemen <kbalazs@webkit.org>
803 [Qt] Cleanup testfonts handling
804 https://bugs.webkit.org/show_bug.cgi?id=76068
806 Reviewed by Simon Hausmann.
808 Factor test font initialization into it's own file so test
809 font users can share the implementation by adding the file
811 Use fonts.conf from the test font directory to not require the
812 current directory to be the WebKit root.
813 Fix the -use-test-fonts option of QtTestBrowser by initializing
814 the fonts earlier, before it is too late (namely before calling
815 show on the main window).
817 * DumpRenderTree/qt/DumpRenderTree.pro:
818 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
819 (WebCore::DumpRenderTree::open):
820 * DumpRenderTree/qt/DumpRenderTreeQt.h:
821 * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
822 (WebKit::initializeTestFonts):
823 * DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
824 * DumpRenderTree/qt/fonts.conf: Removed. No need for this since
825 we will use the one from the test fonts directory.
826 * DumpRenderTree/qt/main.cpp:
827 (main): Fix the ifdefs to make it clear that the code to
828 set up the Dpi has not been ported to Qt5 yet.
829 * QtTestBrowser/QtTestBrowser.pro:
830 * QtTestBrowser/launcherwindow.h:
831 (WindowOptions::WindowOptions):
832 * QtTestBrowser/main.cpp:
834 (LauncherApplication::handleUserOptions):
835 * WebKitTestRunner/InjectedBundle/Target.pri:
836 * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
837 (WTR::activateFonts): Remove the code to set up the Dpi
838 because it does not work with Qt5.
840 2012-01-25 Simon Hausmann <simon.hausmann@nokia.com>
842 [Qt] build-webkit --qt requires a git-svn or SVN checkout.
844 Reviewed by Tor Arne Vestø.
846 Don't require it by making svnRevisionForDirectory return "unknown"
847 instead of bailing out with an error.
849 * Scripts/VCSUtils.pm:
850 (svnRevisionForDirectory):
852 2012-01-25 Adam Barth <abarth@webkit.org>
854 Temporarily disable running the unit tests on the Chromium EWS. These
855 tests don't work properly (see
856 https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
859 * Scripts/webkitpy/common/config/ports.py:
862 2012-01-25 Adam Barth <abarth@webkit.org>
864 Update results.html version of PixelZoomer
865 https://bugs.webkit.org/show_bug.cgi?id=76965
867 Reviewed by Ojan Vafai.
869 Improve readability as suggested by Ojan.
871 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
873 2012-01-25 Carlos Garcia Campos <cgarcia@igalia.com>
875 [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
876 https://bugs.webkit.org/show_bug.cgi?id=76899
878 Reviewed by Martin Robinson.
880 * gtk/generate-gtkdoc:
881 (get_webkit2_options): WebKitWebLoaderClient has been renamed to
884 2012-01-24 Ryosuke Niwa <rniwa@webkit.org>
886 Build fix. Trigger Chromium Mac Release (Perf) on new commits.
888 * BuildSlaveSupport/build.webkit.org-config/config.json:
890 2012-01-23 Ryosuke Niwa <rniwa@webkit.org>
892 WebKit needs public performance tests running on public bots
893 https://bugs.webkit.org/show_bug.cgi?id=10266
895 Reviewed by Adam Barth.
897 Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
898 and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.
900 * BuildSlaveSupport/build.webkit.org-config/config.json:
901 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
902 (RunAndUploadPerfTests):
903 (RunAndUploadPerfTests.start):
904 (UploadPerfTestResults):
905 (BuildAndPerfTestFactory):
906 (BuildAndPerfTestFactory.__init__):
908 2012-01-24 Ojan Vafai <ojan@chromium.org>
910 Initializing the browser property of the Bugzilla class takes too long
911 https://bugs.webkit.org/show_bug.cgi?id=76960
913 Reviewed by Adam Barth.
915 Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
918 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
920 (Bugzilla._get_browser):
922 (Bugzilla._set_browser):
924 2012-01-24 Mark Rowe <mrowe@apple.com>
926 Death to JavaScriptGlue.
928 Rubber-stamped by Geoffrey Garen.
930 * BuildSlaveSupport/build-launcher-app:
931 (copyNightlyLauncher):
932 * Scripts/build-webkit:
933 * Scripts/do-file-rename:
934 * Scripts/do-webcore-rename:
935 * Scripts/webkitpy/common/config/build.py:
936 (_should_file_trigger_build):
937 * Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
938 path in conjunction with a cross-platform path.
941 2012-01-24 Kentaro Hara <haraken@chromium.org>
943 webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
944 https://bugs.webkit.org/show_bug.cgi?id=75836
946 Reviewed by David Kilzer.
948 Previously parser_unittests.pl can just test the returned value of
949 get_function_line_ranges() in prepare-ChangeLog. This patch fixes
950 parser_unittests.pl so that it also tests the stdout and stderr of
951 get_function_line_ranges().
953 This patch adds css_unittests_warning.css, which contains test cases
954 for warning messages of the CSS parser of prepare-ChangeLog.
956 * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
957 (captureOutput): Captures the stdout and stderr of a given method.
958 (convertAbsolutepathToWebKitPath): Converts absolute paths in a given
959 string to relative paths.
961 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
962 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
971 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
972 Just updated the test results, i.e. added stdout and stderr results.
973 No essential changes in the test results.
974 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
975 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
976 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
977 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
978 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.
980 2012-01-24 Dirk Pranke <dpranke@chromium.org>
982 webkitpy: new-run-webkit-httpd is broken
983 https://bugs.webkit.org/show_bug.cgi?id=76963
985 Reviewed by Adam Barth.
987 r105674 broke new-run-webkit-httpd, since options.chromium
988 doesn't exist any more. We didn't catch this because we don't
989 run the integration tests by default anywhere :(.
991 * Scripts/new-run-webkit-httpd:
995 2012-01-24 Adam Barth <abarth@webkit.org>
997 garden-o-matic pixel zoomer should let you look at every pixel of the image
998 https://bugs.webkit.org/show_bug.cgi?id=76962
1000 Reviewed by Ojan Vafai.
1002 Previously, you couldn't get up to the right and bottom pixels.
1004 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
1006 2012-01-24 Enrica Casucci <enrica@apple.com>
1008 WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
1009 https://bugs.webkit.org/show_bug.cgi?id=76951
1010 <rdar://problem/9325158>
1012 Added test to verify that WebHTMLView supports the typingAttributes method and that it
1015 Reviewed by Alexey Proskuryakov.
1017 * TestWebKitAPI/Tests/mac/InspectorBar.mm:
1018 (TestWebKitAPI::TEST):
1020 2012-01-24 James Robinson <jamesr@chromium.org>
1022 Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
1023 https://bugs.webkit.org/show_bug.cgi?id=76884
1025 Reviewed by Adam Barth.
1027 * Scripts/webkitpy/tool/bot/irc_command.py:
1029 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1030 (SheriffIRCBotTest.test_rollout):
1031 (SheriffIRCBotTest.test_revert):
1032 (SheriffIRCBotTest.test_multi_rollout):
1033 (SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
1034 (SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
1035 (SheriffIRCBotTest.test_rollout_invalidate_reason):
1036 (test_multi_rollout_invalidate_reason):
1038 2012-01-24 Kentaro Hara <haraken@chromium.org>
1040 The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
1041 https://bugs.webkit.org/show_bug.cgi?id=75531
1043 Reviewed by David Kilzer.
1045 Previously, the cpp parser of prepare-ChangeLog could not detect a change
1046 outside methods. Consider the following cpp file.
1049 int a; // this change does not appear on ChangeLog.
1051 int b; // this change does not appear on ChangeLog.
1054 int c; // this change appears on ChangeLog.
1056 int d; // this change does not appear on ChangeLog.
1058 int e; // this change does not appear on ChangeLog.
1061 The previous prepare-ChangeLog outputs just methods in which a change is found:
1064 This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
1065 and methods in which a change is found:
1070 * Scripts/prepare-ChangeLog:
1071 (get_function_line_ranges_for_cpp): Modified as described above.
1073 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
1084 (NameSpace5::NameSpace6::Class107::func34):
1085 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1087 2012-01-24 Kentaro Hara <haraken@chromium.org>
1089 prepare-ChangeLog outputs warnings for top-level { ... } blocks
1090 https://bugs.webkit.org/show_bug.cgi?id=75943
1092 Reviewed by David Kilzer.
1094 Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
1095 because it does not distinguish '}' at the end of a subroutine
1096 with '}' at the end of a if or for statement.
1105 nested functions found at top-level at foo.pl:2
1106 nested functions found at top-level at foo.pl:4
1108 This patch fixes the bug.
1110 * Scripts/prepare-ChangeLog:
1111 (get_function_line_ranges_for_perl):
1112 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1113 Added test cases. No change in the test results.
1115 2012-01-24 Dirk Pranke <dpranke@chromium.org>
1117 r105674 broke check-webkit-style for chromium's test_expectations.
1119 Unreviewed, build fix.
1121 We now need to pass in a platform name of 'chromium' if we want
1122 the chromium port; options.chromium is no longer recognized. I
1123 will follow this patch up with a separate patch that has a test,
1124 but this at least fixes the build.
1126 * Scripts/webkitpy/style/checkers/test_expectations.py:
1127 (TestExpectationsChecker._determine_port_from_exepectations_path):
1129 2012-01-20 Ojan Vafai <ojan@chromium.org>
1131 check-webkit-style of the chromium test_expectations.txt file takes too long
1132 https://bugs.webkit.org/show_bug.cgi?id=76745
1134 Reviewed by Dimitri Glazkov.
1136 When in lint mode, have TestExpectations test all configurations instead
1137 of looping over each configuration. This also has the benefit of making
1138 the error output considerably more concise.
1140 Also, got rid of the double-printing of errors when linting through check-webkit-style.
1142 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1144 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1145 (TestExpectations._report_errors):
1146 (TestExpectations._add_expectations):
1147 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1148 (test_parse_error_nonfatal):
1149 (test_error_on_different_platform):
1150 * Scripts/webkitpy/style/checkers/test_expectations.py:
1151 (TestExpectationsChecker.check_test_expectations):
1152 (TestExpectationsChecker.check):
1153 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1154 (TestExpectationsTestCase.test_determine_port_from_exepectations_path):
1155 (TestExpectationsTestCase.assert_lines_lint):
1157 2012-01-24 Ryosuke Niwa <rniwa@webkit.org>
1159 Another build fix attempt after r105543.
1161 * Scripts/webkitpy/common/net/file_uploader.py:
1162 (FileUploader.upload_as_multipart_form_data):
1164 2012-01-24 Ryosuke Niwa <rniwa@webkit.org>
1166 Build fix attempt after r105543.
1168 * Scripts/webkitpy/common/net/file_uploader.py:
1169 (FileUploader.upload_as_multipart_form_data):
1171 2012-01-24 Vincent Scheib <scheib@chromium.org>
1173 [Chromium] Add Pointer Lock test hooks and mock implementation to DumpRenderTree
1174 https://bugs.webkit.org/show_bug.cgi?id=76411
1176 Reviewed by Adam Barth.
1178 Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762
1179 into a series of patches, this change adds a trivial
1180 pointer lock implementation to the Chromium port's DumpRenderTree
1181 and exposes LayoutTestController hooks to force failure conditions.
1183 * DumpRenderTree/chromium/LayoutTestController.cpp:
1184 (LayoutTestController::LayoutTestController):
1185 (LayoutTestController::didLosePointerLock):
1186 (LayoutTestController::setPointerLockWillFailAsynchronously):
1187 (LayoutTestController::setPointerLockWillFailSynchronously):
1188 * DumpRenderTree/chromium/LayoutTestController.h:
1189 * DumpRenderTree/chromium/WebViewHost.cpp:
1190 (WebViewHost::requestPointerLock):
1191 (WebViewHost::requestPointerUnlock):
1192 (WebViewHost::isPointerLocked):
1193 (WebViewHost::didCompletePointerLock):
1194 (WebViewHost::didNotCompletePointerLock):
1195 (WebViewHost::didLosePointerLock):
1196 (WebViewHost::reset):
1197 * DumpRenderTree/chromium/WebViewHost.h:
1198 (WebViewHost::setPointerLockWillFailAsynchronously):
1199 (WebViewHost::setPointerLockWillFailSynchronously):
1201 2012-01-24 Mario Sanchez Prada <msanchez@igalia.com>
1203 Unreviewed, skip WK2 API test timing out on some GTK bots.
1205 WebKit2APITests/TestDownloads is consistently timing out on the
1206 32bit release and 64bit debug bots.
1208 * Scripts/run-gtk-tests:
1209 (TestRunner): Skip WebKit2APITests/TestDownloads.
1211 2012-01-24 Andras Becsi <andras.becsi@nokia.com>
1213 [Qt] Fix the build with the newes Qt5 hashes
1214 https://bugs.webkit.org/show_bug.cgi?id=76657
1216 Reviewed by Simon Hausmann.
1218 * MiniBrowser/qt/MiniBrowserApplication.cpp:
1219 (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
1220 for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
1222 2012-01-24 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1224 [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
1226 We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
1227 building with MinGW inside cmd.exe will require the same construct. Instead
1228 we assume that when the first character in PWD is a '/' we're running under
1229 Cygwin, and use the normal unix way of setting environment variables.
1231 Reviewed by Simon Hausmann.
1233 * qmake/mkspecs/features/default_pre.prf:
1235 2012-01-24 Simon Hausmann <simon.hausmann@nokia.com>
1237 Some qmake build files must include Qt5's "quick" module.
1238 https://bugs.webkit.org/show_bug.cgi?id=76671
1240 Unreviewed build fix.
1242 * MiniBrowser/qt/MiniBrowser.pro:
1243 * WebKitTestRunner/Target.pri:
1245 2012-01-24 Andras Becsi <andras.becsi@nokia.com>
1247 [Qt] Fix the event timestamps for touch mocking
1249 Reviewed by Simon Hausmann.
1251 * MiniBrowser/qt/MiniBrowserApplication.cpp:
1252 (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
1253 timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
1255 2012-01-24 Carlos Garcia Campos <cgarcia@igalia.com>
1257 [GTK] Implement DownloadClient in WebKit2 GTK+ API
1258 https://bugs.webkit.org/show_bug.cgi?id=72952
1260 Reviewed by Martin Robinson.
1262 * gtk/generate-gtkdoc:
1263 (get_webkit2_options): Ignore WebKitDownloadClient.
1265 2012-01-23 Zan Dobersek <zandobersek@gmail.com>
1267 [GTK] editing/deleting/5408255.html results are incorrect
1268 https://bugs.webkit.org/show_bug.cgi?id=53644
1270 Reviewed by Martin Robinson.
1272 WEBKIT_TOP_LEVEL environment variable is now set directly in either
1273 WebKitTestRunner or DumpRenderTree through usage of a compilation-time
1274 macro. This way both tools can be run outside the test harness without
1275 the need to manually set the environment variable.
1277 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1280 * Scripts/webkitpy/layout_tests/port/gtk.py:
1281 (GtkPort.setup_environ_for_server):
1282 * WebKitTestRunner/GNUmakefile.am:
1283 * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1284 (WTR::InjectedBundle::platformInitialize):
1286 2012-01-23 Dmitry Lomov <dslomov@google.com>
1288 [Chromium] Implement layoutTestController.workerThreadCount in DRT
1289 https://bugs.webkit.org/show_bug.cgi?id=74653.
1291 Reviewed by Darin Fisher.
1293 * DumpRenderTree/chromium/LayoutTestController.cpp:
1294 (LayoutTestController::LayoutTestController):
1295 (LayoutTestController::workerThreadCount):
1296 * DumpRenderTree/chromium/LayoutTestController.h:
1298 2012-01-23 Dirk Pranke <dpranke@chromium.org>
1300 nrwt: make --chromium work like --qt
1301 https://bugs.webkit.org/show_bug.cgi?id=76875
1303 Reviewed by Adam Barth.
1305 --chromium used to have to be handled differently from --qt
1306 due to the way the PortFactory was implemented; there's not
1307 really a good reason for that any more so this patch makes
1308 things slightly more consistent and eliminates the
1309 options.chromium flag (--chromium is now truly a synonym for
1310 --platform chromium).
1312 * Scripts/webkitpy/layout_tests/port/factory.py:
1313 (PortFactory._default_port):
1315 * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1316 (FactoryTest.setUp):
1317 (FactoryTest.test_chromium_mac):
1318 (FactoryTest.test_chromium_linux):
1319 (FactoryTest.test_chromium_win):
1320 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1323 2012-01-23 Dirk Pranke <dpranke@chromium.org>
1325 run-webkit-tests needs to propagate --chromium
1326 https://bugs.webkit.org/show_bug.cgi?id=76870
1328 Reviewed by Eric Seidel.
1330 run-webkit-tests removes '--chromium' argument from @ARGV when
1331 determining which port to run, which means that that doesn't
1332 propagate to new-run-webkit-tests. That's bad (and is handled
1333 for the other ports by re-adding the flag, but apparently we're
1334 just now noticing for Chromium).
1336 * Scripts/run-webkit-tests:
1338 2012-01-23 Brian Weinstein <bweinstein@apple.com>
1340 More build fixing after r105646.
1342 * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1343 (TestWebKitAPI::TestNode::key):
1345 2012-01-23 Gavin Barraclough <barraclough@apple.com>
1347 Unreviewed build fix - r105646 broke this.
1349 * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1350 (TestWebKitAPI::TestNode::TestNode):
1351 (TestWebKitAPI::TestNode::key):
1352 (TestWebKitAPI::RedBlackTreeTest::assertEqual):
1353 (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
1354 (TestWebKitAPI::RedBlackTreeTest::testDriver):
1356 2012-01-23 Sheriff Bot <webkit.review.bot@gmail.com>
1358 Unreviewed, rolling out r105658.
1359 http://trac.webkit.org/changeset/105658
1360 https://bugs.webkit.org/show_bug.cgi?id=76883
1362 We want this eventually, but not right at this moment
1363 (Requested by abarth on #webkit).
1365 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1367 2012-01-23 Adam Barth <abarth@webkit.org>
1369 garden-o-matic should support Chromium Mac Lion
1370 https://bugs.webkit.org/show_bug.cgi?id=76880
1372 Reviewed by Eric Seidel.
1374 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1376 2012-01-23 Emil A Eklund <eae@chromium.org>
1378 check-webkit-style whitespace/operators triggers on overloaded division operator
1379 https://bugs.webkit.org/show_bug.cgi?id=76650
1381 Reviewed by Darin Adler.
1383 * Scripts/webkitpy/style/checkers/cpp.py:
1385 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1386 (CppStyleTest.test_operator_methods):
1388 2012-01-23 Ryosuke Niwa <rniwa@webkit.org>
1390 run-perf-tests should report server-side errors
1391 https://bugs.webkit.org/show_bug.cgi?id=76802
1393 Reviewed by Tony Chang.
1395 Report errors whenever server's response doesn't match "OK".
1397 * Scripts/webkitpy/common/net/file_uploader.py:
1398 (FileUploader.upload_single_text_file):
1399 (FileUploader.upload_as_multipart_form_data):
1400 (FileUploader._upload_data.callback):
1402 (FileUploader._upload_data):
1403 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1404 (PerfTestsRunner._upload_json):
1405 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1407 (test_upload_json.MockFileUploader.upload_single_text_file):
1409 2012-01-22 Ryosuke Niwa <rniwa@webkit.org>
1411 run-perf-tests ignore Skipped list on chromium
1412 https://bugs.webkit.org/show_bug.cgi?id=76764
1414 Reviewed by Dirk Pranke.
1416 Move skipped_perf_tests from WebKit port to Base port so that Chromium port
1417 can also find skipped list. Chromium port only uses test_expectations.txt for
1418 layout tests but performacne tests don't use test_expectations.txt so Chromium port
1419 also needs to use Skipped list.
1421 * Scripts/webkitpy/layout_tests/port/base.py:
1422 (Port._tests_from_skipped_file_contents):
1424 (Port._expectations_from_skipped_files):
1425 (Port.skipped_perf_tests):
1426 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1427 (PortTest.test_skipped_perf_tests):
1428 (PortTest.test_skipped_perf_tests.add_text_file):
1429 * Scripts/webkitpy/layout_tests/port/webkit.py:
1430 (WebKitPort._skipped_tests_for_unsupported_features):
1431 (WebKitPort._skipped_file_search_paths):
1432 (WebKitPort.skipped_layout_tests):
1434 2012-01-23 Andy Estes <aestes@apple.com>
1436 Fix the build after r105635.
1438 * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1439 (TestWebKitAPI::TEST):
1441 2012-01-23 Xianzhu Wang <wangxianzhu@chromium.org>
1443 Basic enhancements to StringBuilder
1444 https://bugs.webkit.org/show_bug.cgi?id=67081
1446 Reviewed by Darin Adler.
1448 * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1449 (TestWebKitAPI::TEST):
1451 2012-01-23 Mario Sanchez Prada <msanchez@igalia.com>
1453 [GTK] run-gtk-tests randomly fails while running the xprop comand
1454 https://bugs.webkit.org/show_bug.cgi?id=76817
1456 Reviewed by Gustavo Noronha Silva.
1458 No need to use xprop to remove the AT_SPI_BUS property since
1459 run-gtk-tests will always run new instances of Xvfb.
1461 * Scripts/run-gtk-tests:
1462 (TestRunner): Unskip TestWebKitAccessibility.
1463 (TestRunner.run): Uncomment lines for launching the accessibility
1464 bus and registry daemon, and remove lines for running xprop.
1466 2012-01-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1468 [Qt] Don't warn about override and final being C++11 extensions
1470 Clang will emit a warning when these extensions are used without passing
1471 --std=c++11, but we use feature checking to decide if we have the right
1472 extensions, so we can safely ignore these warnings. The XCode and Windows
1473 project files have the same workaround.
1475 The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
1476 we only have one extra compiler for Objective-C, which is also used for
1477 Objective-C++ sources, so we have to pass the flag, even if it doesn't
1478 make sense for Objective-C.
1480 Reviewed by Simon Hausmann.
1482 * qmake/mkspecs/features/unix/default_post.prf:
1484 2012-01-20 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1486 [Qt] Change how build-webkit decides when to do full incremental builds
1488 Instead of relying on update-webkit (which isn't run on the bots) to
1489 decide when to do a full incremental build (make qmake), we let the
1490 build-webkit script itself check the current SVN revision against the
1491 previous build (by storing it in .webkit.config).
1493 If the two differ we assume a full incremental build is needed, since
1494 the new revisions might have introduced problematic things like new
1495 Q_OBJECT macros. If not, we assume the developer is doing changes
1496 locally, and revert to doing a plain 'make'.
1498 In addition, when the build fails in the latter case, we inform the
1499 developer of possible pitfalls and how to manually run 'make qmake'.
1503 * Scripts/update-webkit:
1504 * Scripts/webkitdirs.pm:
1505 (buildQMakeProjects):
1507 2012-01-23 Mario Sanchez Prada <msanchez@igalia.com>
1509 [GTK] run-gtk-tests randomly fails while running the xprop comand
1510 https://bugs.webkit.org/show_bug.cgi?id=76817
1512 Reviewed by Philippe Normand.
1514 Temporarily comment the lines related to launching the ATSPI bus
1515 and registry daemon, which are making the bots to fail randomly.
1517 * Scripts/run-gtk-tests:
1518 (TestRunner): Skip TestWebKitAccessibility, as it won't run
1519 properly if the ATSPI infrastructure is not properly initialized.
1520 (TestRunner.run): Comment lines related to initialization of ATSPI.
1522 2012-01-22 Ryosuke Niwa <rniwa@webkit.org>
1524 Windows python test build fix.
1526 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1527 (PerfTestsRunner.__init__):
1529 2012-01-22 Sergio Villar Senin <svillar@igalia.com>
1531 [GTK] DumpRenderTree converts "file:///" to a path differently
1532 https://bugs.webkit.org/show_bug.cgi?id=76631
1534 Reviewed by Martin Robinson.
1536 DumpRenderTree should print "/" as the last path component if the
1537 path is a lone slash instead of empty output.
1539 * DumpRenderTree/gtk/DumpRenderTree.cpp:
1540 (webViewConsoleMessage):
1542 2012-01-20 David Levin <levin@chromium.org>
1544 The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
1545 https://bugs.webkit.org/show_bug.cgi?id=76752
1547 Reviewed by Eric Seidel.
1549 * Scripts/webkitpy/style/checkers/cpp.py:
1550 (check_for_leaky_patterns):
1551 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1552 (LeakyPatternTest.test_create_dc):
1553 (LeakyPatternTest.test_create_compatible_dc):
1555 2012-01-20 Shawn Singh <shawnsingh@chromium.org>
1557 Changed my status in commiters.py
1561 * Scripts/webkitpy/common/config/committers.py:
1563 2012-01-20 Ojan Vafai <ojan@chromium.org>
1565 run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
1566 https://bugs.webkit.org/show_bug.cgi?id=76748
1568 Reviewed by Ryosuke Niwa.
1570 It crawls the whole subtree and then doesn't use the data. Cutting this out
1571 saves 4 seconds warm and 17 seconds cold on my Mac Pro.
1573 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1576 2012-01-20 Adam Barth <abarth@webkit.org>
1578 Another tiny tweak to the garden-o-matic CSS. This makes things line
1579 up slightly nicer when there aren't any failures.
1581 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
1584 2012-01-19 Ryosuke Niwa <rniwa@webkit.org>
1586 run-perf-tests should support --test-results-server option
1587 https://bugs.webkit.org/show_bug.cgi?id=76680
1589 Reviewed by Adam Barth.
1591 Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
1592 to be used by perf bots. Also refactor file_uploader as needed.
1594 * Scripts/webkitpy/common/net/file_uploader.py:
1595 (FileUploader.__init__):
1596 (FileUploader.upload_single_file):
1597 (FileUploader.upload_as_multipart_form_data):
1599 (FileUploader._upload_data):
1600 (FileUploader._upload_data.callback):
1601 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1602 (JSONResultsGeneratorBase.upload_json_files):
1603 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1605 (PerfTestsRunner._parse_args):
1606 (PerfTestsRunner.run):
1607 (PerfTestsRunner._generate_json):
1608 (PerfTestsRunner._upload_json):
1609 (PerfTestsRunner._run_tests_set):
1610 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1612 (test_run_with_upload_json):
1613 (test_run_with_upload_json.mock_upload_json):
1615 (test_upload_json.MockFileUploader):
1616 (test_upload_json.MockFileUploader.__init__):
1617 (test_upload_json.MockFileUploader.upload_single_file):
1620 2012-01-20 Adam Barth <abarth@webkit.org>
1622 The party time image overlaps real content! This patch makes the
1623 image centered vertically.
1625 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
1626 (#onebar.partytime #summary):
1628 2012-01-19 Ojan Vafai <ojan@chromium.org>
1630 Refactor TestExpectationsParser in preparation for caching the results
1631 https://bugs.webkit.org/show_bug.cgi?id=76669
1633 Reviewed by Dimitri Glazkov.
1635 Make everything private expect for the parse method.
1636 Eventually, we'll need the expectations lines to not be modified
1637 outside of TestExpectationsParser so we can cache the results.
1638 This makes check-webkit-style of the chromium test_expectations.txt file
1639 go from ~17 seconds to ~12 seconds on my Mac Pro.
1641 This patch is just a refactor in preparation, so no new tests.
1643 * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
1644 (TestExpectationEditorTests.make_parsed_expectation_lines):
1645 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1646 (TestExpectationParser.parse):
1647 (TestExpectationParser):
1648 (TestExpectationParser._parse_line):
1649 (TestExpectationParser._tokenize):
1650 (TestExpectationParser._tokenize_list):
1651 (TestExpectationsModel._clear_expectations_for_test):
1652 (TestExpectations.__init__):
1653 (TestExpectations._add_expectations):
1654 (TestExpectations._add_skipped_tests):
1655 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1656 (TestExpectationParserTests.test_tokenize_blank):
1657 (TestExpectationParserTests.test_tokenize_missing_colon):
1658 (TestExpectationParserTests.test_tokenize_extra_colon):
1659 (TestExpectationParserTests.test_tokenize_empty_comment):
1660 (TestExpectationParserTests.test_tokenize_comment):
1661 (TestExpectationParserTests.test_tokenize_missing_equal):
1662 (TestExpectationParserTests.test_tokenize_extra_equal):
1663 (TestExpectationParserTests.test_tokenize_valid):
1664 (TestExpectationParserTests.test_tokenize_valid_with_comment):
1665 (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
1666 (TestExpectationParserTests.test_parse_empty_string):
1667 (TestExpectationSerializerTests.assert_round_trip):
1668 (TestExpectationSerializerTests.assert_list_round_trip):
1669 * Scripts/webkitpy/tool/commands/expectations.py:
1670 (OptimizeExpectations.execute):
1671 * Scripts/webkitpy/tool/servers/gardeningserver.py:
1672 (GardeningExpectationsUpdater.update_expectations):
1674 2012-01-20 Adam Barth <abarth@webkit.org>
1676 Follow-up to previous patch: don't produce NaN when the revision number
1679 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1680 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
1682 2012-01-20 Adam Barth <abarth@webkit.org>
1684 Garden-o-matic should tell me which revisions have been checked by all the bots
1685 https://bugs.webkit.org/show_bug.cgi?id=76722
1687 Reviewed by Dimitri Glazkov.
1689 This information helps me know when it's safe for me to roll a
1692 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1693 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1694 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
1696 2012-01-20 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1698 build-webkit: Don't spit out congratulations message on Ctrl+C
1700 Reviewed by Andreas Kling.
1702 * Scripts/build-webkit:
1704 2012-01-20 Philippe Normand <pnormand@igalia.com>
1706 [GTK] Allow extra jhbuild modulesets
1707 https://bugs.webkit.org/show_bug.cgi?id=76691
1709 Reviewed by Gustavo Noronha Silva.
1711 * gtk/jhbuildrc: Extra modulesets and modules can be added in
1712 JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
1713 env variables respectively. Use comma-separated values. Example:
1714 WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
1716 2012-01-20 Mario Sanchez Prada <msanchez@igalia.com>
1718 [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
1719 https://bugs.webkit.org/show_bug.cgi?id=72589
1721 Reviewed by Martin Robinson.
1723 Ensure the accessibility infrastructure is available when running
1724 the unit tests, otherwise WK2's accessibility tests won't work.
1726 * Scripts/run-gtk-tests:
1728 (TestRunner._lookup_atspi2_binary): New. Looks for the directory
1729 where at-spi2's stuff is located (like at-spi-bus-launcher and
1731 (TestRunner.run): Initialize the accessibility infrastructure.
1733 * gtk/generate-gtkdoc:
1734 (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
1736 * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
1738 2012-01-20 Hayato Ito <hayato@chromium.org>
1740 Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
1741 https://bugs.webkit.org/show_bug.cgi?id=76353
1743 Reviewed by Hajime Morita.
1745 Add ShadowRoot.idl, which is enabled only on chromium port since this is
1746 under development feature.
1747 ShadowRoot.idl contains minimum API so that we can test it.
1748 Other APIs should be added on other changes so that we can isolate issues.
1750 * DumpRenderTree/chromium/TestShell.cpp:
1751 (TestShell::TestShell):
1753 2012-01-20 Mario Sanchez Prada <msanchez@igalia.com>
1755 [GTK] GTK's DRT not to log events for already defunct objects
1756 https://bugs.webkit.org/show_bug.cgi?id=76620
1758 Reviewed by Martin Robinson.
1760 Do not log 'state-change:defunct' events.
1762 * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
1763 (printAccessibilityEvent): Early return if a
1764 'state-change:defunct' signal is passed.
1765 (axObjectEventListener): Pass the signal name and value in
1766 separate parameters to printAccessibilityEvent.
1768 2012-01-19 Gustavo Noronha Silva <gns@gnome.org>
1770 Unreviewed build fix. Wrong variable being used as the cwd for git
1771 remote update command.
1773 * gtk/run-with-jhbuild:
1776 2012-01-19 Gustavo Noronha Silva <gns@gnome.org>
1778 [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
1779 https://bugs.webkit.org/show_bug.cgi?id=76585
1781 Reviewed by Martin Robinson.
1783 This allows us to specify a minimum version of jhbuild required,
1784 while also providing stability against changes done to the master
1785 branch, by letting us choose what is the exact version that will
1788 * gtk/run-with-jhbuild: refactored for more hackability and easier
1790 (jhbuild_installed): checks whether jhbuild is installed
1791 (jhbuild_cloned): checks whether jhbuild has been cloned
1792 (jhbuild_at_expected_revision): checks whether jhbuild is at the
1794 (update_jhbuild): brings jhbuild to the expected revision
1795 (clone_jhbuild): clones jhbuild
1796 (install_jhbuild): build and installs jhbuild
1797 (update_webkitgtk_libs): runs update-webkitgtk-libs
1798 (ensure_jhbuild): high-level logic to decide whether and which of
1799 the steps above are executed
1801 2012-01-19 Alexey Proskuryakov <ap@apple.com>
1803 [WK2] DumpRenderTree converts "file:///" to a path differently
1804 https://bugs.webkit.org/show_bug.cgi?id=76653
1806 Reviewed by John Sullivan.
1808 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
1809 Do print a slash if there are no path components.
1811 2012-01-19 Eric Seidel <eric@webkit.org>
1813 webkit-patch cannot rollout patches without changelog/bug number
1814 https://bugs.webkit.org/show_bug.cgi?id=75962
1816 Reviewed by Adam Barth.
1818 * Scripts/webkitpy/tool/commands/download.py:
1819 (AbstractRolloutPrepCommand._prepare_state):
1820 * Scripts/webkitpy/tool/commands/download_unittest.py:
1821 (AbstractRolloutPrepCommandTest.test_prepare_state):
1823 2012-01-19 Alexey Proskuryakov <ap@apple.com>
1825 [WK2] fast/url/degenerate-file-base.html fails
1826 https://bugs.webkit.org/show_bug.cgi?id=76619
1828 Reviewed by Adam Roben.
1830 A URL generated form local path for loading had an extra slash, making document.URL
1831 incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
1833 * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
1835 2012-01-18 Ojan Vafai <ojan@chromium.org>
1837 check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
1838 https://bugs.webkit.org/show_bug.cgi?id=76510
1840 Reviewed by Adam Barth.
1842 Unlike other style rules, if you get the syntax of the test_expectations.txt
1843 file wrong, the layout tests won't run. Also, this check is simple and only
1844 slows down committing if you actually modify one of the test_expectations.txt files.
1846 * Scripts/webkitpy/style/checkers/test_expectations.py:
1847 (TestExpectationsChecker.check_test_expectations):
1848 (TestExpectationsChecker.check):
1849 * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1850 (TestExpectationsTestCase.test_check_covers_all_configurations):
1851 (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
1852 (TestExpectationsTestCase):
1853 (assert_lines_lint):
1855 2012-01-19 Ryosuke Niwa <rniwa@webkit.org>
1857 Build fix. Revert an unintentional change to WebKitDriver in r105443.
1859 * Scripts/webkitpy/layout_tests/port/driver.py:
1860 (DriverProxy.__init__):
1862 2012-01-19 Dirk Pranke <dpranke@chromium.org>
1864 remove the duplicated build rules from WebKit.gyp, Tools.gyp
1865 https://bugs.webkit.org/show_bug.cgi?id=73384
1867 Reviewed by Tony Chang.
1869 This patch removes the no-longer-necessary conditional logic for
1870 build_webkit_exes_from_webkit_gyp; we now always build the exes
1871 from their own dedicated gyp files.
1873 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1875 2012-01-19 Alexey Proskuryakov <ap@apple.com>
1877 make-new-script-test should work with HTTP tests
1878 https://bugs.webkit.org/show_bug.cgi?id=76603
1880 Reviewed by Adam Roben.
1882 * Scripts/make-new-script-test:
1883 (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
1884 now also creates absolute paths for HTTP.
1886 2012-01-19 Ryosuke Niwa <rniwa@webkit.org>
1888 Some perf tests time out when ran by run-perf-tests
1889 https://bugs.webkit.org/show_bug.cgi?id=76612
1891 Reviewed by Dirk Pranke and Eric Seidel.
1893 Always pass --no-timeout to DumpRenderTree from run-perf-tests.
1894 Otherwise some tests such as Parser/xml-parser.html will timeout.
1896 --no-timeout option is currently supported by Chromium and Mac ports.
1898 * Scripts/webkitpy/layout_tests/port/base.py:
1899 (Port.to.create_driver):
1900 * Scripts/webkitpy/layout_tests/port/chromium.py:
1901 (ChromiumDriver.__init__):
1902 (ChromiumDriver._wrapper_options):
1903 * Scripts/webkitpy/layout_tests/port/driver.py:
1905 (DriverProxy.__init__):
1906 * Scripts/webkitpy/layout_tests/port/webkit.py:
1907 (WebKitDriver.__init__):
1908 (WebKitDriver.cmd_line):
1909 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1910 (WebKitDriverTest.test_read_binary_block):
1912 (WebKitDriverTest.test_no_timeout):
1913 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1914 (get_tests_run.RecordingTestDriver.__init__):
1915 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1916 (PerfTestsRunner._parse_args):
1917 (PerfTestsRunner._run_tests_set):
1918 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1921 2012-01-19 Ben Wells <benwells@chromium.org>
1923 Add support for window.print to chromium DRT
1924 https://bugs.webkit.org/show_bug.cgi?id=76479
1926 When used in a test window.print goes into print mode and then
1927 straight out again. This will allow the afterprint event to be
1928 tested by having the afterprint event happen before the dump
1931 Reviewed by Mihai Parparita.
1933 * DumpRenderTree/chromium/WebViewHost.cpp:
1934 (WebViewHost::printPage):
1935 * DumpRenderTree/chromium/WebViewHost.h:
1937 2012-01-18 Enrica Casucci <enrica@apple.com>
1939 editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
1940 https://bugs.webkit.org/show_bug.cgi?id=76588
1941 <rdar://problem/9325183>
1945 Reviewed by Dan Bernstein.
1947 * TestWebKitAPI/Tests/mac/InspectorBar.mm:
1948 (TestWebKitAPI::TEST):
1950 2012-01-19 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1952 [Qt] Do full incremental builds until bots use update-webkit
1954 Rubber-stamped by Simon Hausmann.
1956 * Scripts/webkitdirs.pm:
1957 (buildQMakeProjects):
1959 2012-01-19 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1963 Unreviewed build fix.
1965 * Scripts/webkitdirs.pm:
1966 (buildQMakeProjects):
1968 2012-01-19 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
1970 [Qt] Make build-webkit always do safe incremental builds after update-webkit
1972 When building against Qt5 with GCC we would just run 'make' in the build dir,
1973 and rely on the dependency files output by GCC (-MD) to handle dependency
1974 tracking, but that fails for special-cases like adding a Q_OBJECT macro
1977 To guarantee that an incrmental build will work, we have to run 'make qmake',
1978 which we now do on every build-webkit that's followed by a successful run
1979 of update-webkit. The reasoning is that update-webkit can result in such
1980 potential corner-cases being applied, and since we can't know for sure
1981 unless we inspect the diff and account for all the corner cases we assume
1982 the worst and always run 'make qmake'.
1984 After a succesful run of build-webkit we proceed to do just 'make' for any
1985 subsequent runs, since we assume that the developer knows what kind of
1986 changes he/she is doing, and when a 'make qmake' is needed.
1988 Reviewed by Simon Hausmann.
1990 * Scripts/update-webkit:
1991 * Scripts/webkitdirs.pm:
1992 (determineCurrentSVNRevision):
1993 (currentSVNRevision):
1994 (buildQMakeProjects):
1995 * qmake/mkspecs/features/default_post.prf:
1997 2012-01-18 Ryosuke Niwa <rniwa@webkit.org>
1999 run-perf-tests should support Skipped list
2000 https://bugs.webkit.org/show_bug.cgi?id=76594
2002 Reviewed by Adam Barth.
2004 Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
2006 * Scripts/webkitpy/layout_tests/port/base.py:
2007 (Port.perf_tests_dir):
2008 (Port.skipped_perf_tests):
2009 (Port.skips_perf_test):
2010 (Port.relative_perf_test_filename):
2011 * Scripts/webkitpy/layout_tests/port/test.py:
2012 (TestPort.perf_tests_dir):
2013 * Scripts/webkitpy/layout_tests/port/webkit.py:
2014 (WebKitPort._expectations_from_skipped_files):
2016 (WebKitPort.skipped_layout_tests):
2017 (WebKitPort.skipped_perf_tests):
2018 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2019 (PerfTestsRunner._collect_tests):
2020 (PerfTestsRunner.run):
2021 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2022 (test_run_test_set_with_json_output):
2023 (test_run_test_set_with_json_source):
2024 (test_collect_tests_with_skipped_list):
2025 (test_collect_tests_with_skipped_list.add_file):
2027 2012-01-18 Dirk Pranke <dpranke@chromium.org>
2029 Fix path to chromium_src_dir introduced in previous change.
2031 Unreviewed, build fix.
2033 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2035 2012-01-18 Alexey Proskuryakov <ap@apple.com>
2037 Need infrastructure to test Content-Disposition filename encoding support
2038 https://bugs.webkit.org/show_bug.cgi?id=76572
2039 <rdar://problem/6421825>
2041 Reviewed by Sam Weinig.
2043 Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
2045 WebKitTestRunner does not have a policy delegate yet, bug 42546.
2047 * DumpRenderTree/mac/PolicyDelegate.mm:
2048 (dispositionTypeFromContentDispositionHeader):
2049 (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
2051 2012-01-18 Ojan Vafai <ojan@chromium.org>
2053 Fix tests from http://trac.webkit.org/changeset/105332.
2055 The code assumed that if you passed an options object with a configuration
2056 attribute that it would have a valid value. A bunch of the testing mocks
2057 do things like having a configuration value of None.
2059 * Scripts/webkitpy/layout_tests/port/base.py:
2062 2012-01-18 Ojan Vafai <ojan@chromium.org>
2064 Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
2065 https://bugs.webkit.org/show_bug.cgi?id=76576
2067 Reviewed by Adam Barth.
2069 Avoid calling default_configuration in base.py. We don't need it for
2070 checking test_expectations.txt style. It takes ~0.5 seconds to run on my
2071 Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
2072 from common.executive.
2074 At some point someone should probably look into why that call is so slow
2075 since it's on the critical path for run-webkit-tests and build-webkit startup.
2077 * Scripts/webkitpy/layout_tests/port/base.py:
2079 * Scripts/webkitpy/style/checkers/test_expectations.py:
2080 (TestExpectationsChecker._determine_port_from_exepectations_path):
2082 2012-01-18 Dirk Pranke <dpranke@chromium.org>
2084 [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
2085 https://bugs.webkit.org/show_bug.cgi?id=76505
2087 Reviewed by Tony Chang.
2089 Update chromium build script to use All.gyp instead of WebKit.gyp
2091 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
2092 * Scripts/webkitdirs.pm:
2094 2012-01-18 Sam Weinig <sam@webkit.org>
2096 Don’t hardcode the path to ‘make‘.
2098 Reviewed by Dan Bernstein.
2100 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2102 2012-01-18 Joshua Bell <jsbell@chromium.org>
2104 Adding myself to committers.py
2105 https://bugs.webkit.org/show_bug.cgi?id=76569
2109 * Scripts/webkitpy/common/config/committers.py:
2111 2012-01-18 Adam Barth <abarth@webkit.org>
2113 Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
2114 https://bugs.webkit.org/show_bug.cgi?id=76567
2116 Reviewed by Eric Seidel.
2118 Current the AppleMac port has slightly more failures than we allow on
2119 the EWS, causing the mac-ews to spin. This patch ups the limit a bit,
2120 which should hopefully let the mac-ews run to completion. Once
2121 AppleMac has fewer failures, we can lower the cap again.
2123 * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2124 (LayoutTestResultsReaderTest.test_layout_test_results):
2125 * Scripts/webkitpy/tool/steps/runtests.py:
2127 * Scripts/webkitpy/tool/steps/steps_unittest.py:
2129 2012-01-18 Eric Carlson <eric.carlson@apple.com>
2131 Provide access to user's list of preferred languages
2132 https://bugs.webkit.org/show_bug.cgi?id=76138
2134 Reviewed by Alexey Proskuryakov.
2136 * GNUmakefile.am: Add JSInternalsCustom.cpp.
2138 2012-01-18 Adam Barth <abarth@webkit.org>
2140 Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
2143 * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2144 (ChromiumLinuxPort.__init__):
2146 2012-01-18 Dominic Mazzoni <dmazzoni@google.com>
2148 Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
2149 https://bugs.webkit.org/show_bug.cgi?id=73460
2151 Reviewed by Chris Fleizach.
2153 * DumpRenderTree/AccessibilityUIElement.h:
2154 * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2155 (AccessibilityUIElement::AccessibilityUIElement):
2156 (AccessibilityUIElement::scrollToMakeVisibleCallback):
2157 (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
2158 (AccessibilityUIElement::scrollToGlobalPointCallback):
2159 * DumpRenderTree/chromium/AccessibilityUIElement.h:
2160 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2161 (AccessibilityUIElement::scrollToMakeVisible):
2162 (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2163 (AccessibilityUIElement::scrollToGlobalPoint):
2164 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2165 (AccessibilityUIElement::scrollToMakeVisible):
2166 (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2167 (AccessibilityUIElement::scrollToGlobalPoint):
2168 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2169 (AccessibilityUIElement::scrollToMakeVisible):
2170 (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2171 (AccessibilityUIElement::scrollToGlobalPoint):
2173 2012-01-17 Enrica Casucci <enrica@apple.com>
2175 Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
2176 https://bugs.webkit.org/show_bug.cgi?id=76490
2177 <rdar://problem/9460733>
2179 Added TestWebKitAPI test.
2181 Reviewed by Dan Bernstein.
2183 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
2184 * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
2185 changeAttributes to the WebView.
2187 2012-01-18 Balazs Kelemen <kbalazs@webkit.org>
2189 [Qt] Consolidate layout test crash logging
2190 https://bugs.webkit.org/show_bug.cgi?id=75088
2192 Reviewed by Simon Hausmann.
2194 Move backtrace generating logic into WTFReportBacktrace
2195 and add a way to deinstall signal handlers if we know
2196 that we have already printed the backtrace.
2198 * DumpRenderTree/qt/main.cpp:
2200 (setupSignalHandlers):
2203 * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2204 (WTR::crashHandler):
2205 (WTR::setupSignalHandlers):
2207 (WTR::InjectedBundle::platformInitialize):
2209 2012-01-18 Ilya Tikhonovsky <loislo@chromium.org>
2211 Unreviewed build fix after r105256.
2213 There was a cyclic dependency between self._port and self._host assigments.
2215 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2216 (PerfTestsRunner.__init__):
2218 2012-01-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
2220 Add new watchlist rule for the Qt build system
2222 Reviewed by Simon Hausmann.
2224 * Scripts/webkitpy/common/config/watchlist:
2226 2012-01-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
2228 [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
2230 Reviewed by Simon Hausmann.
2234 2012-01-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
2236 [Qt] Allow building only a subset of the WebKit sub-projects
2238 Fixes build-jsc, broken in r104825.
2240 We no longer need the intermediate buildQMakeQtProject(), as we're the
2241 only port using qmake, and buildQMakeProject is now highly Qt specific.
2243 <http://webkit.org/b/76179>
2245 Reviewed by Simon Hausmann.
2247 * Scripts/build-jsc:
2248 * Scripts/build-webkit:
2249 * Scripts/webkitdirs.pm:
2250 (buildQMakeProjects):
2252 2012-01-18 Ryosuke Niwa <rniwa@webkit.org>
2254 run-perf-tests should generate a json file that summaries the result
2255 https://bugs.webkit.org/show_bug.cgi?id=76504
2257 Reviewed by Adam Barth.
2259 Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
2260 New option --outout-json-path specifies the json file's path, and --source-json-path specifies
2261 another json file to be merged into the generated json file.
2263 Also fixed a bug that --build wasn't set by default.
2265 * Scripts/webkitpy/layout_tests/port/test.py:
2266 (TestPort.webkit_base):
2267 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2268 (PerfTestsRunner.__init__):
2270 (PerfTestsRunner._parse_args):
2271 (PerfTestsRunner.run):
2272 (PerfTestsRunner._generate_json_if_specified):
2273 (PerfTestsRunner._process_chromium_style_test_result):
2274 (PerfTestsRunner._process_parser_test_result):
2275 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2278 (test_run_test_set):
2279 (test_run_test_set_for_parser_tests):
2280 (test_run_test_set_with_summary_json):
2281 (test_collect_tests):
2284 2012-01-17 Sheriff Bot <webkit.review.bot@gmail.com>
2286 Unreviewed, rolling out r105244.
2287 http://trac.webkit.org/changeset/105244
2288 https://bugs.webkit.org/show_bug.cgi?id=76518
2290 broke Chromium Mac (Requested by rolandsteiner on #webkit).
2292 * DumpRenderTree/AccessibilityUIElement.h:
2293 * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2294 (AccessibilityUIElement::AccessibilityUIElement):
2295 * DumpRenderTree/chromium/AccessibilityUIElement.h:
2296 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2297 (AccessibilityUIElement::removeSelection):
2298 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2299 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2300 (AccessibilityUIElement::removeSelection):
2302 2012-01-17 Dominic Mazzoni <dmazzoni@google.com>
2304 Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
2305 https://bugs.webkit.org/show_bug.cgi?id=73460
2307 Reviewed by Chris Fleizach.
2309 * DumpRenderTree/AccessibilityUIElement.h:
2310 * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2311 (AccessibilityUIElement::AccessibilityUIElement):
2312 (AccessibilityUIElement::scrollToMakeVisibleCallback):
2313 (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
2314 (AccessibilityUIElement::scrollToGlobalPointCallback):
2315 * DumpRenderTree/chromium/AccessibilityUIElement.h:
2316 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2317 (AccessibilityUIElement::scrollToMakeVisible):
2318 (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2319 (AccessibilityUIElement::scrollToGlobalPoint):
2320 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2321 (AccessibilityUIElement::scrollToMakeVisible):
2322 (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2323 (AccessibilityUIElement::scrollToGlobalPoint):
2324 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2325 (AccessibilityUIElement::scrollToMakeVisible):
2326 (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2327 (AccessibilityUIElement::scrollToGlobalPoint):
2329 2012-01-17 Adam Barth <abarth@webkit.org>
2331 Enable tests on the mac-ews
2332 https://bugs.webkit.org/show_bug.cgi?id=76502
2334 Reviewed by Simon Fraser.
2336 Apple now has five machines running the mac-ews. Lucas Forschler has
2337 asked that we try enabling tests to see if we have enough bandwidth.
2339 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2342 2012-01-17 Sanjoy Das <sanjoy@playingwithpointers.com>
2344 Add a check-webkit-style exception for GDBInterface.cpp
2345 https://bugs.webkit.org/show_bug.cgi?id=76187
2347 Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
2348 that it does not fail the style check.
2350 Reviewed by Martin Robinson.
2352 * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
2353 readability/naming tests on
2354 Source/JavaScriptCore/jit/GDBInterface.cpp.
2355 * Scripts/webkitpy/style/checker_unittest.py:
2356 (GlobalVariablesTest.test_path_rules_specifier): Add a test for
2357 the above exception.
2359 2012-01-17 Hajime Morrita <morrita@chromium.org>
2361 https://bugs.webkit.org/show_bug.cgi?id=76245
2362 [Mac][DRT] should allow query string for the file URL.
2364 Reviewed by Tony Chang.
2366 Taught DRT about file:// as a url instead of a file path.
2367 We are now able to use a path file:///foo/bar.html?baz as a url
2368 with which DRT opens "/foo/bar.html" with "baz" as a query string.
2370 * DumpRenderTree/mac/DumpRenderTree.mm:
2373 2012-01-17 Ojan Vafai <ojan@chromium.org>
2375 Check style on test_expectations.txt files before commit
2376 https://bugs.webkit.org/show_bug.cgi?id=76484
2378 Reviewed by Adam Barth.
2380 Unlike other style rules, if you get the syntax of the test_expectations.txt
2381 file wrong, the layout tests won't run. Also, this check is simple and only
2382 slows down committing if you actually modify one of the test_expectations.txt files.
2384 * Scripts/webkitpy/tool/steps/commit.py:
2385 (Commit._check_test_expectations):
2387 * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
2389 (CommitTest.test_check_test_expectations):
2391 2012-01-17 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
2393 [Qt] Debug build fails with debug qt5
2394 https://bugs.webkit.org/show_bug.cgi?id=76463
2396 Reviewed by Simon Hausmann.
2398 Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
2400 * QtTestBrowser/cookiejar.h:
2402 2012-01-17 Dirk Pranke <dpranke@chromium.org>
2404 webkitpy: fix json import on linux
2405 https://bugs.webkit.org/show_bug.cgi?id=76481
2407 Reviewed by Adam Barth.
2409 For some reason, the version of simplejson autoinstalled on my linux
2410 box seems to be broken. We should really only be using
2411 simplejson if json isn't available anyway, so this change looks
2414 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2415 (JSONGeneratorTest.test_test_timings_trie):
2417 2012-01-17 Dirk Pranke <dpranke@chromium.org>
2419 Fix failures in test-webkitpy caused by r105177.
2421 Unreviewed, build fix.
2423 * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2424 (ChromiumLinuxPort._determine_driver_path_statically):
2425 (ChromiumLinuxPort._static_build_path):
2427 2012-01-17 Dirk Pranke <dpranke@chromium.org>
2429 webkitpy: make PortFactory.get() be fully data-driven
2430 https://bugs.webkit.org/show_bug.cgi?id=76360
2432 Reviewed by Eric Seidel.
2434 Refactor PortFactory.get() to be fully data-driven.
2436 * Scripts/webkitpy/layout_tests/port/factory.py:
2438 (PortFactory._default_port):
2440 (PortFactory.get.in):
2441 * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2442 (FactoryTest.assert_port):
2444 2012-01-17 Dirk Pranke <dpranke@chromium.org>
2446 webkitpy: add determine_full_port_name(), clean up port.__init__()
2447 https://bugs.webkit.org/show_bug.cgi?id=76357
2449 Reviewed by Adam Barth.
2451 Each Port class is now required to implement a 'port_name' field
2452 that will match the start of all ports constructed by this class and
2453 a 'determine_full_port_name' field that will make the port
2456 * Scripts/webkitpy/layout_tests/port/apple.py:
2457 (ApplePort.__init__):
2458 * Scripts/webkitpy/layout_tests/port/base.py:
2460 (Port.determine_port_name):
2462 * Scripts/webkitpy/layout_tests/port/chromium.py:
2464 (ChromiumPort.__init__):
2466 (ChromiumPort._chromium_base_dir):
2467 (ChromiumPort.path_from_chromium_base):
2468 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2469 (ChromiumGpuLinuxPort):
2470 (ChromiumGpuLinuxPort.__init__):
2471 (ChromiumGpuMacPort):
2472 (ChromiumGpuMacPort.__init__):
2473 (ChromiumGpuWinPort):
2474 (ChromiumGpuWinPort.__init__):
2475 * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2476 (ChromiumLinuxPort):
2477 (ChromiumLinuxPort.determine_port_name):
2478 (ChromiumLinuxPort.__init__):
2479 * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2481 (ChromiumMacPort.determine_port_name):
2482 (ChromiumMacPort.__init__):
2483 * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2485 (ChromiumWinPort.determine_port_name):
2486 (ChromiumWinPort.__init__):
2487 * Scripts/webkitpy/layout_tests/port/dryrun.py:
2489 (DryRunPort.determine_port_name):
2490 (DryRunPort.__init__):
2491 * Scripts/webkitpy/layout_tests/port/efl.py:
2493 * Scripts/webkitpy/layout_tests/port/factory.py:
2495 (PortFactory._default_port):
2497 (PortFactory.get.in):
2498 * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2499 (FactoryTest.assert_port):
2500 * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2501 (GoogleChromeLinux32Port):
2502 (GoogleChromeLinux32Port.determine_port_name):
2503 (GoogleChromeLinux64Port):
2504 (GoogleChromeLinux64Port.determine_port_name):
2505 (GoogleChromeMacPort):
2506 (GoogleChromeMacPort.determine_port_name):
2507 (GoogleChromeWinPort):
2508 (GoogleChromeWinPort.determine_port_name):
2509 * Scripts/webkitpy/layout_tests/port/gtk.py:
2511 * Scripts/webkitpy/layout_tests/port/mac.py:
2513 (MacPort.determine_port_name):
2515 * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2517 * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2519 (MockDRTPort.determine_port_name):
2520 (MockDRTPort.__init__):
2522 (MockDRT.determine_port_name):
2523 * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2524 (PortTestCase.make_port):
2525 * Scripts/webkitpy/layout_tests/port/qt.py:
2527 (QtPort.determine_port_name):
2529 * Scripts/webkitpy/layout_tests/port/test.py:
2531 (TestPort.determine_port_name):
2532 (TestPort.__init__):
2533 * Scripts/webkitpy/layout_tests/port/webkit.py:
2534 (WebKitPort.__init__):
2535 * Scripts/webkitpy/layout_tests/port/win.py:
2537 (WinPort.determine_port_name):
2538 * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2539 (get_test_baselines.AllPlatformsPort.__init__):
2540 * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2541 (get_test_config.TestMacPort):
2544 2012-01-17 Dirk Pranke <dpranke@chromium.org>
2546 webkitpy: clean up port code in preparation for static port names
2547 https://bugs.webkit.org/show_bug.cgi?id=76356
2549 Reviewed by Adam Barth.
2551 To fix bug 76215 and be able to determine appropriate port names
2552 in webkitpy without actually constructing Port objects, we need
2553 to shuffle some logic in the chromium ports to be able to figure
2554 out whether we built DRT in 32 or 64-bit mode.
2556 * Scripts/webkitpy/layout_tests/port/chromium.py:
2558 (ChromiumPort._chromium_base_dir):
2559 (ChromiumPort.__init__):
2560 (ChromiumPort.path_from_chromium_base):
2561 * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2562 (ChromiumLinuxPort):
2563 (ChromiumLinuxPort._determine_driver_path_statically):
2564 (ChromiumLinuxPort._static_build_path):
2565 (ChromiumLinuxPort._determine_architecture):
2566 (ChromiumLinuxPort.__init__):
2567 (ChromiumLinuxPort._build_path):
2569 2012-01-17 Hao Zheng <zhenghao@chromium.org>
2571 Do not remove pixel failures for ref tests.
2572 https://bugs.webkit.org/show_bug.cgi?id=76243
2574 Reviewed by Tony Chang.
2576 'NRWT --no-pixel-tests' complains when reftests are expected to
2579 * Scripts/webkitpy/layout_tests/controllers/manager.py:
2580 (Manager._update_summary_with_result):
2581 * Scripts/webkitpy/layout_tests/models/test_failures.py:
2582 (is_reftest_failure):
2583 (determine_result_type):
2585 2012-01-17 Balazs Ankes <Ankes.Balazs@stud.u-szeged.hu>
2587 REGRESSION(r81225): ORWT should ignore reftests
2588 https://bugs.webkit.org/show_bug.cgi?id=67936
2590 Reviewed by Csaba Osztrogonác.
2592 * Scripts/old-run-webkit-tests:
2593 (isUsedInReftest): $filename should be the first parameter
2594 (findTestsToRun): run test if it isn't reftest
2596 2012-01-17 Gustavo Noronha Silva <gns@gnome.org>
2598 Unreviewed. Fix python unit test I broke with r105142
2600 * Scripts/webkitpy/common/config/ports_unittest.py:
2601 (WebKitPortTest.test_gtk_port):
2603 2012-01-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
2605 [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
2607 Qt 5 no longer has that flag.
2609 Reviewed by Simon Hausmann.
2611 * MiniBrowser/qt/MiniBrowserApplication.cpp:
2612 (MiniBrowserApplication::notify):
2614 2012-01-16 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
2616 GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
2617 https://bugs.webkit.org/show_bug.cgi?id=75857
2619 Reviewed by Adam Barth.
2621 * Scripts/webkitdirs.pm:
2622 (buildAutotoolsProject): move cleaning the build to happen early,
2623 and handle --update-gtk right after that
2624 * Scripts/webkitpy/common/config/ports.py:
2625 (GtkPort.build_webkit_command): pass --update-gtk as an option to
2626 build-webkit, so that it is used in the EWS
2628 2012-01-16 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
2630 [Qt] Don't add _debug postfix to targets when building debug only
2632 Reviewed by Simon Hausmann.
2634 * qmake/mkspecs/features/default_post.prf:
2635 * qmake/mkspecs/features/functions.prf:
2637 2012-01-16 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
2639 [Qt] Add more files to project-files for easier navigation in Qt Creator
2641 Reviewed by Simon Hausmann.
2644 * qmake/config.tests/README: Added.
2646 2012-01-17 Philippe Normand <pnormand@igalia.com>
2648 [GTK] fast/dom/constructed-objects-prototypes.html fails
2649 https://bugs.webkit.org/show_bug.cgi?id=75432
2651 Reviewed by Martin Robinson.
2653 * Scripts/build-webkit: Enable video-track in GTK.
2655 2012-01-16 Takashi Toyoshima <toyoshim@chromium.org>
2657 Add toyoshim as a committer.
2658 https://bugs.webkit.org/show_bug.cgi?id=76390
2660 Reviewed by Hajime Morita.
2662 * Scripts/webkitpy/common/config/committers.py:
2664 2012-01-16 Brent Fulgham <bfulgham@webkit.org>
2666 [WinCairo] Build fix after r104155. Several debug targets were not
2667 properly including the '*Common' property sheets.
2669 * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
2670 * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
2671 * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
2672 * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
2673 * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
2675 2012-01-16 Csaba Osztrogonác <ossy@webkit.org>
2677 REGRESSION(r105072): It broke committers_unittest.py
2678 https://bugs.webkit.org/show_bug.cgi?id=76396
2680 Reviewed by Adam Barth.
2682 * Scripts/webkitpy/common/config/committers_unittest.py:
2683 (CommittersTest._assert_fuzz_match): It should handle more names.
2684 (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
2686 2012-01-16 Mario Sanchez Prada <msanchez@igalia.com>
2688 [GTK] Include gtk+3 in the jhbuild modules
2689 https://bugs.webkit.org/show_bug.cgi?id=76284
2691 Reviewed by Philippe Normand.
2693 * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
2695 2012-01-16 Dan Winship <danw@gnome.org>
2697 Add myself as a committer
2701 * Scripts/webkitpy/common/config/committers.py:
2703 2012-01-16 Raphael Kubo da Costa <kubo@profusion.mobi>
2705 Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
2707 Some recent versions of a few Linux distributions have started passing
2708 --as-needed and --no-copy-dt-needed-entries by default to the linker,
2709 which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
2710 needed a few symbols from libjavascriptcore_efl.so.
2712 * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
2713 before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
2714 libraries are searched in the right order by the linker.
2716 2012-01-16 Philippe Normand <pnormand@igalia.com>
2718 [GTK] set audio resources path in NRTW
2719 https://bugs.webkit.org/show_bug.cgi?id=76380
2721 Reviewed by Martin Robinson.
2723 * Scripts/webkitpy/layout_tests/port/gtk.py:
2724 (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
2725 the uninstalled audio resources are used during webaudio tests.
2727 2012-01-16 Carlos Garcia Campos <cgarcia@igalia.com>
2729 [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
2730 https://bugs.webkit.org/show_bug.cgi?id=76369
2732 Reviewed by Xan Lopez.
2734 If there's an installed version of webkit and there are new
2735 symbols in the build tree, gtkdoc-scanobj fails due to undefined
2736 references, because the env ldflags are given before the local
2740 (GTKDoc._run_gtkdoc_scangobj):
2742 2012-01-15 Pablo Flouret <pablof@motorola.com>
2744 Fix compilation errors on build-webkit --debug --no-video on mac.
2745 https://bugs.webkit.org/show_bug.cgi?id=75867
2747 Reviewed by Philippe Normand.
2749 Add --[no-]video-track to build-webkit, since video track feature
2752 * Scripts/build-webkit:
2754 2012-01-14 James Robinson <jamesr@chromium.org>
2756 [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
2757 https://bugs.webkit.org/show_bug.cgi?id=76313
2759 Reviewed by Adam Barth.
2761 The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
2763 * Scripts/run-chromium-webkit-unit-tests:
2765 2012-01-14 Sheriff Bot <webkit.review.bot@gmail.com>
2767 Unreviewed, rolling out r105017.
2768 http://trac.webkit.org/changeset/105017
2769 https://bugs.webkit.org/show_bug.cgi?id=76333
2771 broke the build (Requested by philn-tp on #webkit).
2773 * gtk/jhbuild.modules:
2775 2012-01-14 Mario Sanchez Prada <msanchez@igalia.com>
2777 [GTK] Include gtk+3 in the jhbuild modules
2778 https://bugs.webkit.org/show_bug.cgi?id=76284
2780 Reviewed by Philippe Normand.
2782 * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
2784 2012-01-13 Adam Barth <abarth@webkit.org>
2786 Remove --dry-run support from webkit-patch
2787 https://bugs.webkit.org/show_bug.cgi?id=76300
2789 Reviewed by Dirk Pranke.
2791 This is the rest of the patch from Bug 76300. I landed it separtely
2792 because main.py had some stray conflict markers that I needed to clean
2795 * Scripts/webkitpy/test/main.py:
2796 (Tester.parse_args):
2797 (Tester._run_tests):
2799 2012-01-13 Adam Barth <abarth@webkit.org>
2801 test-webkitpy does not run
2802 https://bugs.webkit.org/show_bug.cgi?id=76318
2806 Looks like some conflict markers got left in the file.
2808 * Scripts/webkitpy/test/main.py:
2811 2012-01-13 Adam Barth <abarth@webkit.org>
2813 Remove --dry-run support from webkit-patch
2814 https://bugs.webkit.org/show_bug.cgi?id=76300
2816 Reviewed by Dirk Pranke.
2818 We don't use this functionality for anything, and it doesn't really
2819 work. Someone in #webkit tried using it and and got sad/confused. We
2820 should just remove it.
2822 * Scripts/webkitpy/common/checkout/scm/git.py:
2823 (Git.push_local_commits_to_server):
2824 * Scripts/webkitpy/common/checkout/scm/scm.py:
2826 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2827 (_shared_test_commit_with_message):
2828 (GitSVNTest.test_commit_text_parsing):
2829 * Scripts/webkitpy/common/checkout/scm/svn.py:
2830 (SVN.commit_with_message):
2831 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2832 (Bugzilla.__init__):
2834 (Bugzilla.authenticate):
2835 (Bugzilla.add_attachment_to_bug):
2836 (Bugzilla.add_patch_to_bug):
2837 (Bugzilla.create_bug):
2838 (Bugzilla.clear_attachment_flags):
2839 (Bugzilla.set_flag_on_attachment):
2840 (Bugzilla.obsolete_attachment):
2841 (Bugzilla.add_cc_to_bug):
2842 (Bugzilla.post_comment_to_bug):
2843 (Bugzilla.close_bug_as_fixed):
2844 (Bugzilla.reassign_bug):
2846 * Scripts/webkitpy/test/main.py:
2847 (Tester.parse_args):
2850 2012-01-13 David Levin <levin@chromium.org>
2852 check-webkit-style: should encourage the use of Own* classes for Windows DC.
2853 https://bugs.webkit.org/show_bug.cgi?id=76227
2855 Reviewed by Dirk Pranke.
2857 * Scripts/webkitpy/style/checkers/cpp.py:
2858 (check_for_leaky_patterns): The new check.
2859 (process_line): Added a call to the new check.
2860 (CppChecker): Added the new error type.
2861 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2863 (CppStyleTestBase.perform_leaky_pattern_check):
2864 The check for only leaky pattern errors.
2865 (LeakyPatternTest): Test cases.
2867 2012-01-13 Dirk Pranke <dpranke@chromium.org>
2869 test-webkitpy: clean up handling of test directories, QueueStatusServer
2870 https://bugs.webkit.org/show_bug.cgi?id=76238
2872 Reviewed by Adam Barth.
2874 This patch cleans up a bunch of hacks related to how we find all
2875 of the python unit tests and set up the sys.path variable in
2878 This patch changes how test-webkitpy works slightly in that we
2879 will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
2880 rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
2881 This greatly simplifies the mapping of paths to module names and
2882 appears to have no significant performance impact or other drawbacks.
2884 There are other ways that we could remove all of the hacks and
2885 still have a more flexible mapping of paths to module names, but
2886 the ones I've thought of so far add a decent amount of complexity to
2887 the implementation and don't seem to buy us much.
2889 * QueueStatusServer/__init__.py:
2890 * Scripts/test-webkitpy:
2891 * Scripts/webkitpy/test/main.py:
2892 (Tester._modules_from_paths):
2893 (Tester._is_module):
2895 2012-01-13 Dirk Pranke <dpranke@chromium.org>
2897 test-webkitpy: should support classes and individual test names as well as modules
2898 https://bugs.webkit.org/show_bug.cgi?id=76233
2900 Reviewed by Adam Barth.
2902 The default unittest.main() supports a list of individual
2903 TestCase classes or individual tests as well as modules. This
2904 change adds support for the same to test-webkitpy, so now you
2907 % test-wekbitpy webkitpy.test.cat_unittest.CatTest
2911 % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
2915 % test-wekbitpy webkitpy.test.cat_unittest
2917 * Scripts/test-webkitpy:
2918 * Scripts/webkitpy/test/cat_unittest.py:
2919 * Scripts/webkitpy/test/main.py:
2920 (Tester.parse_args):
2923 (Tester._find_modules):
2925 (Tester._run_tests):
2926 (Tester._is_module):
2927 (Tester._log_exception):
2929 2012-01-13 Dirk Pranke <dpranke@chromium.org>
2931 test-webkitpy: add basic code coverage support
2932 https://bugs.webkit.org/show_bug.cgi?id=76201
2934 Reviewed by Adam Barth.
2936 This test adds basic code coverage support to test-webkitpy; if
2937 you pass the -c flag, we will generate a new coverage file. We
2938 can start simply with this and add more features as necessary.
2940 This patch requires coverage to be already installed on the
2941 machine. I am not auto-installing this for now.
2943 * Scripts/webkitpy/test/main.py:
2944 (Tester.parse_args):
2947 2012-01-13 Dirk Pranke <dpranke@chromium.org>
2949 StatusBubbleTest.test_build_bubble is failing
2950 https://bugs.webkit.org/show_bug.cgi?id=76222
2952 Reviewed by Adam Barth.
2954 * QueueStatusServer/handlers/statusbubble_unittest.py:
2955 (StatusBubbleTest.test_build_bubble):
2957 2012-01-13 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
2959 nrwt should use multiple http shards
2960 https://bugs.webkit.org/show_bug.cgi?id=75958
2962 Add --max-locked-shards option to the nrwt for manual set
2963 the maximum number of the locked shards
2965 Reviewed by Dirk Pranke.
2967 * Scripts/webkitpy/layout_tests/controllers/manager.py:
2968 (Manager._max_locked_shards):
2969 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2970 (ShardingTests.get_shards):
2971 (ShardingTests.test_multiple_locked_shards):
2972 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2975 2012-01-13 Raphael Kubo da Costa <kubo@profusion.mobi>
2977 prepare-ChangeLog: Look for a text editor in a few more variables.
2978 https://bugs.webkit.org/show_bug.cgi?id=76289
2980 Reviewed by Ryosuke Niwa.
2982 A text editor was looked for only in the CHANGE_LOG_EDITOR and
2983 CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
2984 to the OS X-specific open(1) command.
2986 As there does not seem to be a common way of looking for a text editor
2987 among the scripts in Tools/Scripts right now, just look at $VISUAL and
2988 $EDITOR (set much more often than the other variables in Unix systems)
2989 before falling back to open(1).
2991 * Scripts/prepare-ChangeLog:
2994 2012-01-13 Gabor Rapcsanyi <rgabor@webkit.org>
2996 [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
2997 https://bugs.webkit.org/show_bug.cgi?id=76269
2999 Reviewed by Martin Robinson.
3002 (GTKDoc._run_gtkdoc_scangobj):
3004 2012-01-13 Csaba Osztrogonác <ossy@webkit.org>
3006 [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
3007 https://bugs.webkit.org/show_bug.cgi?id=76247
3009 Reviewed by Kenneth Rohde Christiansen.
3011 * WebKitTestRunner/TestController.cpp:
3012 (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
3014 2012-01-13 Hajime Morrita <morrita@chromium.org>
3016 [Mac][DRT] Should support --no-timeout
3017 https://bugs.webkit.org/show_bug.cgi?id=76242
3019 Reviewed by Darin Adler.
3021 * DumpRenderTree/mac/DumpRenderTree.mm:
3022 (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
3023 (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
3024 (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
3025 * DumpRenderTree/mac/DumpRenderTreeMac.h:
3026 * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3027 (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
3029 2012-01-12 Simon Fraser <simon.fraser@apple.com>
3031 Mitigate scrollbar differences when running pixel tests
3032 https://bugs.webkit.org/show_bug.cgi?id=67217
3034 Reviewed by Dan Bernstein.
3036 Enable mock scrollbars by default for tests.
3038 * DumpRenderTree/mac/DumpRenderTree.mm:
3039 (resetDefaultsToConsistentValues):
3040 * WebKitTestRunner/TestController.cpp:
3041 (WTR::TestController::resetStateToConsistentValues):
3043 2012-01-12 Ryosuke Niwa <rniwa@webkit.org>
3045 Need a script to run tests in PerformanceTests
3046 https://bugs.webkit.org/show_bug.cgi?id=76132
3048 Reviewed by Adam Barth.
3050 Add run-perf-tests to run performance tests using parser/resources/runner.js.
3051 Unfortunately, there isn't an easy way of telling which test uses which format
3052 so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
3054 All test outputs are re-formatted to match Chromium perf-bot style.
3056 * Scripts/run-inspector-perf-tests.py:
3057 * Scripts/run-perf-tests: Added.
3058 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3060 (PerfTestsRunner.__init__):
3061 (PerfTestsRunner._collect_tests):
3062 (PerfTestsRunner.run):
3063 (PerfTestsRunner._print_status):
3064 (PerfTestsRunner._run_tests_set):
3065 (PerfTestsRunner._process_chromium_style_test_result):
3066 (PerfTestsRunner._should_ignore_line_in_parser_test_result):
3067 (PerfTestsRunner._process_parser_test_result):
3068 (PerfTestsRunner._run_single_test):
3069 * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3070 (MainTest.TestDriver.run_test):
3073 (test_run_test_set):
3074 (test_run_test_set_for_parser_tests):
3075 (test_collect_tests):
3077 2012-01-12 Dirk Pranke <dpranke@chromium.org>
3079 webkitpy: clean up port unit tests in preparation for making port_name mandatory
3080 https://bugs.webkit.org/show_bug.cgi?id=76123
3082 Reviewed by Adam Barth.
3084 This change updates the unit tests to be more consistent in how
3085 ports are created, in preparation for making port_name a
3086 mandatory parameter to the constructor and removing any version
3087 interpretation from it.
3089 There should be no functional changes in this patch, but some
3090 tests that are no longer relevant have been removed or reworked.
3092 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3093 (PortTest.test_get_option__default):
3094 * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3095 (ChromiumLinuxPortTest):
3096 (ChromiumLinuxPortTest.assert_architecture):
3097 (ChromiumLinuxPortTest.test_determine_architecture_fails):
3098 * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3099 (ChromiumMacPortTest):
3100 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3102 (ChromiumPortTest.test_all_test_configurations):
3103 (ChromiumPortTest.TestMacPort.__init__):
3104 (ChromiumPortTest.TestLinuxPort.__init__):
3105 (ChromiumPortTest.TestWinPort.__init__):
3106 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3108 * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3110 * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3112 * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3114 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3116 (MockDRTPortTest.make_port):
3117 * Scripts/webkitpy/layout_tests/port/qt.py:
3118 (QtPort._port_flag_for_scripts):
3120 * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3122 (QtPortTest._assert_search_path):
3123 (QtPortTest.test_baseline_search_path):
3124 (QtPortTest.test_operating_system):
3125 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3127 * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3129 (WinPortTest._assert_search_path):
3130 (WinPortTest.test_baseline_search_path):
3131 * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3132 (get_test_config.TestMacPort.__init__):
3134 2012-01-12 Dirk Pranke <dpranke@chromium.org>
3136 test-webkitpy: clean up logging and provide a real --help message
3137 https://bugs.webkit.org/show_bug.cgi?id=76142
3139 Reviewed by Adam Barth.
3141 This test is mostly more refactoring - it calls objects in
3142 unittest directly instead of routing through unittest.main() --
3143 in order to gain more control over the logging and to provide a
3144 correct --help message. This will also give us a better
3145 foundation for adding more feautures down the road.
3147 This patch adds different levels of logging controlled by the
3148 '-s', '-q', and '-v' options (see --help for details), and
3149 removes the --verbose-logging option.
3151 * Scripts/test-webkitpy:
3152 * Scripts/webkitpy/test/main.py:
3154 (Tester.clean_packages):
3156 (Tester.parse_args):
3158 (Tester._configure_logging):
3159 (Tester.find_modules):
3161 (Tester._modules_from_paths):
3164 2012-01-12 Simon Hausmann <simon.hausmann@nokia.com>
3166 Make the new WTF module build on Qt
3167 https://bugs.webkit.org/show_bug.cgi?id=76163
3169 Reviewed by Tor Arne Vestbø.
3171 * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
3173 2012-01-12 Vsevolod Vlasov <vsevik@chromium.org>
3175 Unreviewed, mac DumpRenderTree fix.
3177 * DumpRenderTree/mac/UIDelegate.mm:
3178 (-[UIDelegate webView:addMessageToConsole:withSource:]):
3180 2012-01-12 Vsevolod Vlasov <vsevik@chromium.org>
3182 WebKitTestRunner should not print console message line number when it is equal to zero.
3183 https://bugs.webkit.org/show_bug.cgi?id=76167
3185 Reviewed by Csaba Osztrogonác.
3187 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3188 (WTR::InjectedBundlePage::willAddMessageToConsole):
3190 2012-01-11 Vsevolod Vlasov <vsevik@chromium.org>
3192 Make default console messages line numbers consistent.
3193 https://bugs.webkit.org/show_bug.cgi?id=74075
3195 Reviewed by Pavel Feldman.
3197 Unset line numbers are not printed to console now.
3198 Added Source/WebCore/inspector to efl DumpRenderTree include path.
3200 * DumpRenderTree/chromium/WebViewHost.cpp:
3201 (WebViewHost::didAddMessageToConsole):
3202 * DumpRenderTree/efl/CMakeLists.txt:
3203 * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3205 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3206 (webViewConsoleMessage):
3207 * DumpRenderTree/mac/UIDelegate.mm:
3208 (-[UIDelegate webView:addMessageToConsole:withSource:]):
3209 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3210 (WebCore::WebPage::javaScriptConsoleMessage):
3211 * DumpRenderTree/win/UIDelegate.cpp:
3212 (UIDelegate::webViewAddMessageToConsole):
3213 * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3214 (LayoutWebViewEventHandler::OnConsoleMessageEvent):
3216 2012-01-10 Dirk Pranke <dpranke@chromium.org>
3218 test-webkitpy: push more logic into webkitpy.test.main, clean up code
3219 https://bugs.webkit.org/show_bug.cgi?id=76021
3221 Reviewed by Eric Seidel.
3223 I plan to add more functionality to test-webkitpy, but it is
3224 difficult to hack on now; this patch is the first of two that
3225 brings test-webkitpy more inline with current coding style by
3226 pushing more logic into the webkitpy.test.main.Tester class (so
3227 that it will be testable itself).
3229 There should be no functional changes in this patch.
3231 * Scripts/test-webkitpy:
3232 (_path_from_webkit_root):
3233 * Scripts/webkitpy/test/main.py:
3236 (Tester.configure_logging):
3237 (Tester.configure_logging.filter):
3238 (Tester.clean_packages):
3241 2012-01-11 Wei Jia <wjia@chromium.org>
3243 implement layout tests for <video> with media stream
3244 https://bugs.webkit.org/show_bug.cgi?id=74882
3246 Reviewed by Kent Tamura.
3248 * DumpRenderTree/DumpRenderTree.gypi:
3249 * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
3250 (WebKit::WebUserMediaClientMock::create):
3251 (WebKit::WebUserMediaClientMock::IsMockStream):
3252 (WebKit::WebUserMediaClientMock::requestUserMedia):
3253 (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
3254 * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
3255 (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
3256 (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
3257 * DumpRenderTree/chromium/WebViewHost.cpp:
3258 (WebViewHost::userMediaClient):
3259 (WebViewHost::userMediaClientMock):
3260 (WebViewHost::createMediaPlayer):
3261 (WebViewHost::mediaStreamUtil):
3262 (WebViewHost::testMediaStreamClient):
3263 * DumpRenderTree/chromium/WebViewHost.h:
3265 2012-01-11 Dirk Pranke <dpranke@chromium.org>
3267 Unreviewed, build fix.
3269 Fix chromium-win's version remapping to work correctly on Win 7 SP1.
3271 * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3272 (ChromiumWinPort.__init__):
3274 2012-01-11 Ryosuke Niwa <rniwa@webkit.org>
3276 Sheriffbot build fix. Don't emit empty lines on IRC.
3278 * Scripts/webkitpy/tool/bot/irc_command.py:
3279 (LastGreenRevision.execute):
3281 2012-01-11 Ryosuke Niwa <rniwa@webkit.org>
3283 last-green-revision should report the revision that succeeded on all bots
3284 https://bugs.webkit.org/show_bug.cgi?id=76109
3286 Reviewed by Adam Barth.
3288 Add an algorithm to find the last known good revision among the specified bots. For a revision to be
3289 considered green by this algorithm, all matching builders must have a successful run at the revision
3290 or two consecutive successful runs before and after the revision.
3292 Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
3293 that resulted in an exception when the user didn't pass BUILDER_NAME argument.
3295 * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3296 (BuildBot._revisions_for_builder):
3298 (BuildBot._find_green_revision):
3299 (BuildBot.last_green_revision):
3300 * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3301 (MockBuildBot.last_green_revision):
3302 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3303 (test_revisions_for_builder):
3304 (test_find_green_revision):
3305 (test_last_green_revision):
3306 * Scripts/webkitpy/tool/bot/irc_command.py:
3307 (LastGreenRevision.execute):
3308 * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3309 (SheriffIRCBotTest.test_lgr):
3310 * Scripts/webkitpy/tool/commands/queries.py:
3311 (LastGreenRevision):
3313 2012-01-11 Dirk Pranke <dpranke@chromium.org>
3315 Unreviewed, fix build bustage on win32 introduced by r104725.
3317 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3318 (MockDRTPortTest.make_port):
3319 (MockChromiumDRTTest.test_pixeltest__fails):
3321 2012-01-11 Jochen Eisinger <jochen@chromium.org>
3323 [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
3324 https://bugs.webkit.org/show_bug.cgi?id=75618
3326 Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
3328 Reviewed by Tony Chang.
3330 * DumpRenderTree/chromium/LayoutTestHelper.mm:
3331 (installLayoutTestColorProfile):
3332 (restoreUserColorProfile):
3335 2012-01-11 Dirk Pranke <dpranke@chromium.org>
3337 test-webkitpy: fix -v and eliminate some spurious warnings
3338 https://bugs.webkit.org/show_bug.cgi?id=76099
3340 Reviewed by Adam Barth.
3342 when we added support for --xml output, we broke the -v flag.
3344 Also, fix the code to swallow a harmless warning from
3345 VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
3347 test-webkitpy is now silent again except for the one known
3350 * Scripts/webkitpy/common/checkout/checkout.py:
3351 (Checkout.commit_message_for_this_commit):
3352 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3353 (test_commit_message_for_this_commit):
3354 * Scripts/webkitpy/style/checkers/jsonchecker.py:
3355 (JSONChecker.check):
3356 (JSONChecker.line_number_from_json_exception):
3357 * Scripts/webkitpy/test/main.py:
3360 2012-01-11 Dirk Pranke <dpranke@chromium.org>
3362 webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
3363 https://bugs.webkit.org/show_bug.cgi?id=76084
3365 Reviewed by Adam Barth.
3367 This will help make it easier to catch layering violations. This
3368 change just refactors test code; there are no changes to
3371 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3372 (PortTest.make_port):
3373 (PortTest.test_find_no_paths_specified):
3374 (PortTest.test_find_one_test):
3375 (PortTest.test_find_glob):
3376 (PortTest.test_find_with_skipped_directories):
3377 (PortTest.test_find_with_skipped_directories_2):
3378 (PortTest.test_parse_reftest_list):
3379 (PortTest.test_httpd_returns_error_code):
3380 (PortTest.test_virtual_methods):
3381 * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3382 (ChromiumGpuTest.assert_port_works):
3383 (ChromiumGpuTest._assert_baseline_path):
3384 (ChromiumGpuTest.test_graphics_type):
3385 (ChromiumGpuTest.test_default_tests_paths.test_paths):
3386 (ChromiumGpuTest.test_test_files):
3387 (ChromiumGpuTest.test_test_files.test_paths):
3389 * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3390 (ChromiumLinuxPortTest.assert_architecture):
3391 (ChromiumLinuxPortTest.test_check_illegal_port_names):
3392 (ChromiumLinuxPortTest.test_determine_architecture_fails):
3393 * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3394 (DriverTest.make_port):
3396 (DriverTest.assertVirtual):
3397 (DriverTest._assert_wrapper):
3398 (DriverTest.test_virtual_driver_methods):
3399 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3400 (MockDRTPortTest.make_port):
3401 (MockDRTPortTest.test_port_name_in_constructor):
3402 (MockDRTTest.assertTest):
3403 (MockDRTTest.test_main):
3404 (MockChromiumDRTTest.test_pixeltest__fails):
3405 * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3406 (QtPortTest._assert_search_path):
3407 * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3408 (TestWebKitPort.__init__):
3409 (WebKitPortUnitTests.test_default_options):
3410 (test_runtime_feature_list):
3411 (test_test_expectations):
3413 2012-01-11 Ojan Vafai <ojan@chromium.org>
3415 Style skipped tests in the flakiness dashboard
3416 https://bugs.webkit.org/show_bug.cgi?id=76091
3418 Reviewed by Tony Chang.
3420 * TestResultServer/static-dashboards/dashboard_base.js:
3421 Removed "FLAKY" from this list since we don't ever mark individual runs
3422 as flaky. Also deleted an outdated line.
3423 * TestResultServer/static-dashboards/flakiness_dashboard.html:
3425 2012-01-11 Ojan Vafai <ojan@chromium.org>
3427 Remove gtest normalization code from the test results server
3428 https://bugs.webkit.org/show_bug.cgi?id=76089
3430 Reviewed by Tony Chang.
3432 The normalization now happens on the gtest side.
3434 * TestResultServer/model/jsonresults.py:
3435 (JsonResults.merge):
3436 * TestResultServer/model/jsonresults_unittest.py:
3437 (JsonResultsTest.test_gtest):
3439 2012-01-11 Ojan Vafai <ojan@chromium.org>
3441 Be more aggressive about deleting unnecessary results from the test-results-server json files
3442 https://bugs.webkit.org/show_bug.cgi?id=76086
3444 Reviewed by Tony Chang.
3446 Remove any tests that only contain skip/pass/nodata values whose runtime
3447 is less than 5 seconds.
3449 * TestResultServer/model/jsonresults.py:
3450 (JsonResults._normalize_results_json):
3451 * TestResultServer/model/jsonresults_unittest.py:
3452 (JsonResultsTest.test_merge_remove_test):
3453 (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
3455 2012-01-11 Ryosuke Niwa <rniwa@webkit.org>
3457 last-green-revision should give us per-bot information
3458 https://bugs.webkit.org/show_bug.cgi?id=76011
3460 Reviewed by Adam Barth.
3462 Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
3463 we report the latest green run on each bot from the last 100 runs.
3465 * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3466 (BuildBot._fetch_builder_page):
3468 (BuildBot._green_revision_for_builder):
3469 (BuildBot.last_green_revision):
3470 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3471 (test_green_revision_for_builder):
3472 (test_last_green_revision):
3473 * Scripts/webkitpy/tool/bot/irc_command.py:
3474 (LastGreenRevision.execute):
3475 * Scripts/webkitpy/tool/commands/queries.py:
3476 (LastGreenRevision.execute):
3478 2012-01-11 Dirk Pranke <dpranke@chromium.org>
3480 webkitpy: clean up version detection in webkitpy.layout_tests.port
3481 https://bugs.webkit.org/show_bug.cgi?id=76016
3483 Reviewed by Adam Barth.
3485 This change updates the code in webkitpy.layout_tests.port to
3486 use the new os_name and os_version fields on host.platform. This
3487 gets layout_tests.port out of the version parsing business. Most
3488 of the diffs are just cleaning up test code to accomodate the
3491 * Scripts/webkitpy/common/system/executive_mock.py:
3493 (MockExecutive.ignore_error):
3495 (MockExecutive2.ignore_error):
3496 * Scripts/webkitpy/common/system/platforminfo_mock.py:
3497 (MockPlatformInfo.is_mac):
3498 (MockPlatformInfo.is_linux):
3499 (MockPlatformInfo.is_win):
3500 * Scripts/webkitpy/common/system/systemhost_mock.py:
3501 (MockSystemHost.__init__):
3502 * Scripts/webkitpy/layout_tests/port/apple.py:
3503 (ApplePort.__init__):
3504 * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3505 (ChromiumMacPort.__init__):
3506 (ChromiumMacPort.check_wdiff):
3507 * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3508 (ChromiumMacPortTest):
3509 (ChromiumMacPortTest.assert_name):
3510 (ChromiumMacPortTest.test_versions):
3511 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3512 (ChromiumPortTest.test_all_test_configurations):
3513 (ChromiumPortTest.TestMacPort.__init__):
3514 (ChromiumPortTest.TestLinuxPort.__init__):
3515 (ChromiumPortTest.TestWinPort.__init__):
3516 * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3517 (ChromiumWinPort.__init__):
3518 * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3520 (ChromiumWinTest.assert_name):
3521 (ChromiumWinTest.test_versions):
3522 (ChromiumWinTest.test_baseline_path):
3523 (ChromiumWinTest.test_build_path):
3524 * Scripts/webkitpy/layout_tests/port/factory.py:
3525 (PortFactory._port_name_from_arguments_and_options):
3527 * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3529 (FactoryTest.setUp):
3530 (FactoryTest.assert_port):
3531 (FactoryTest.test_mac):
3532 (FactoryTest.test_win):
3533 (FactoryTest.test_google_chrome):
3534 (FactoryTest.test_gtk):
3535 (FactoryTest.test_qt):
3536 (FactoryTest.test_chromium_gpu):
3537 (FactoryTest.test_chromium_gpu_linux):
3538 (FactoryTest.test_chromium_gpu_mac):
3539 (FactoryTest.test_chromium_gpu_win):
3540 (FactoryTest.test_chromium_mac):
3541 (FactoryTest.test_chromium_linux):
3542 (FactoryTest.test_chromium_win):
3543 (FactoryTest.test_unknown_specified):
3544 (FactoryTest.test_unknown_default):
3545 * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3546 (TestGoogleChromePort):
3547 (TestGoogleChromePort._verify_baseline_path):
3548 (TestGoogleChromePort._verify_expectations_overrides):
3549 (TestGoogleChromePort.test_get_google_chrome_port):
3550 * Scripts/webkitpy/layout_tests/port/mac.py:
3552 * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3555 (test_tests_for_other_platforms):
3558 (test_is_version_methods):
3559 (test_setup_environ_for_server):
3560 (_assert_search_path):
3561 (test_show_results_html_file):
3562 * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3564 (PortTestCase.make_port):
3565 * Scripts/webkitpy/layout_tests/port/win.py:
3567 * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3569 (WinPortTest.test_show_results_html_file):
3570 (WinPortTest._assert_search_path):
3571 (WinPortTest._assert_version):
3573 2012-01-11 Hugo Parente Lima <hugo.lima@openbossa.org>
3575 [Qt][WK2] Remove workaround introduced into bug 75470
3576 https://bugs.webkit.org/show_bug.cgi?id=75889
3578 Reviewed by Tor Arne Vestbø.
3580 * MiniBrowser/qt/qml/BrowserWindow.qml:
3582 2012-01-10 Dmitry Lomov <dslomov@google.com>
3584 [Chromium] Remove obsolete references to WebWorker class.
3585 https://bugs.webkit.org/show_bug.cgi?id=76020
3587 Reviewed by David Levin.
3589 * DumpRenderTree/chromium/TestWebWorker.h: Removed.
3590 * DumpRenderTree/chromium/WebViewHost.cpp:
3591 * DumpRenderTree/chromium/WebViewHost.h:
3593 2012-01-11 Csaba Osztrogonác <ossy@webkit.org>
3595 [Qt] Some css3 filter tests are failing after r104698
3596 https://bugs.webkit.org/show_bug.cgi?id=76055
3598 Reviewed by Simon Hausmann.
3600 * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3601 (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
3603 2012-01-11 Tony Chang <tony@chromium.org>
3605 Don't remove 0 byte files when running build-webkit --chromium
3606 https://bugs.webkit.org/show_bug.cgi?id=75997
3608 Reviewed by Csaba Osztrogonác.
3610 If QTDIR is set, isQt() is true even when running build-webkit --chromium.
3612 * Scripts/webkitdirs.pm:
3615 2012-01-10 David Kilzer <ddkilzer@apple.com>
3617 Add TestWebKitAPI tests for KURL
3618 <http://webkit.org/b/75774>
3620 Reviewed by Adam Barth.
3622 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
3623 WebCore folder and KURL.cpp source file to the project.
3624 * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
3625 (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
3626 during setup since this test doesn't go through WebKit or
3628 (TestWebKitAPI::TEST_F): Add two basic tests.
3630 2012-01-10 David Kilzer <ddkilzer@apple.com>
3632 Extract common code for comparing WTF::String objects into WTFStringUtilities.h
3634 Reviewed by Adam Barth.
3636 Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
3638 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
3639 WTFStringUtilities.h to the project.
3640 * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
3641 WTFStringUtilities.h.
3642 * TestWebKitAPI/WTFStringUtilities.h: Added.
3645 2012-01-10 Vincent Scheib <scheib@chromium.org>
3647 Clarify run-webkit-tests options reset-results and new-baseline
3648 https://bugs.webkit.org/show_bug.cgi?id=75993
3650 Reviewed by Dirk Pranke.
3652 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3655 2012-01-10 Simon Fraser <simon.fraser@apple.com>
3657 Disabled mock scrollbars should draw differently
3658 https://bugs.webkit.org/show_bug.cgi?id=75995
3660 Reviewed by James Robinson.
3662 When the scrollbar is disabled, paint the entire track of
3663 mock scrollbars with a lighter gray, and hide the thumb.
3665 * DumpRenderTree/mac/DumpRenderTree.mm:
3666 (-[DRTMockScroller drawKnob]):
3667 (-[DRTMockScroller drawRect:]):
3669 2012-01-10 James Robinson <jamesr@chromium.org>
3671 [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
3672 https://bugs.webkit.org/show_bug.cgi?id=75988
3674 Reviewed by Adam Barth.
3676 * Scripts/webkitpy/common/config/ports.py:
3677 (WebKitPort.run_webkit_unit_tests_command):
3679 (ChromiumPort.run_webkit_unit_tests_command):
3681 * Scripts/webkitpy/common/config/ports_mock.py:
3682 (MockPort.run_webkit_unit_tests_command):
3683 * Scripts/webkitpy/tool/commands/download_unittest.py:
3684 (DownloadCommandsTest.test_build_and_test):
3686 (test_land_red_builders):
3687 * Scripts/webkitpy/tool/steps/runtests.py:
3689 * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3691 2012-01-09 Dirk Pranke <dpranke@chromium.org>
3693 webkitpy: add os_name, os_version to platforminfo
3694 https://bugs.webkit.org/show_bug.cgi?id=75931
3696 Reviewed by Eric Siedel.
3698 As a first step in cleaning up the version parsing logic in
3699 webkitpy.layout_tests.port, this adds common routines for
3700 getting the os_name and os_version fields to the PlatformInfo
3701 class. Nothing uses them yet but I've added FIXME's to some of
3702 the code that needs to be deleted in the port files.
3704 * Scripts/webkitpy/common/system/platforminfo.py:
3705 (PlatformInfo.__init__):
3707 (PlatformInfo._determine_os_name):
3708 (PlatformInfo._determine_mac_version):
3709 (PlatformInfo._determine_linux_version):
3710 (PlatformInfo._determine_win_version):
3711 (PlatformInfo.display_name):
3712 (PlatformInfo.total_bytes_memory):
3713 (PlatformInfo._compute_bytes_from_vm_stat_output):
3714 (PlatformInfo.free_bytes_memory):
3715 * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
3717 (TestPlatformInfo.make_info):
3718 (TestPlatformInfo.make_info.mock_run_command):
3719 (TestPlatformInfo.setUp):
3720 (TestPlatformInfo.tearDown):
3721 (TestPlatformInfo.test_basic):
3722 (TestPlatformInfo.integration_test_basic):
3723 (TestPlatformInfo.test_display_name_mac):
3724 (TestPlatformInfo.test_display_name_win32):
3725 (TestPlatformInfo.test_memory_mac):
3726 (TestPlatformInfo.test_memory_win32):
3727 (TestPlatformInfo.test_determine_os_name):
3728 (TestPlatformInfo.test_determine_mac_version):
3729 (TestPlatformInfo.test_determine_linux_version):
3730 (TestPlatformInfo.test_determine_win_version_from_tuple):
3731 (TestPlatformInfo.test_determine_win_version_from_cmd):
3732 * Scripts/webkitpy/layout_tests/port/apple.py:
3733 (ApplePort.__init__):
3734 * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3735 (ChromiumMacPort.__init__):
3736 * Scripts/webkitpy/layout_tests/port/mac.py:
3738 * Scripts/webkitpy/layout_tests/port/win.py:
3741 2012-01-10 Adam Roben <aroben@apple.com>
3743 Make it possible to type data: URLs into MiniBrowser on Windows
3745 Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
3746 MiniBrowser on Windows
3748 Reviewed by Darin Adler.
3750 * MiniBrowser/win/BrowserWindow.cpp:
3751 (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
3752 whether to prepend "http://", just look for whether the typed URL contains a colon. If it
3753 does, we assume it already has a scheme and don't modify it.
3755 2012-01-10 Adam Roben <aroben@apple.com>
3757 Make MiniBrowser automatically escape invalid URL characters typed in its URL field
3759 Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
3760 MiniBrowser on Windows
3762 Reviewed by Darin Adler.
3764 * MiniBrowser/win/BrowserView.cpp:
3765 (BrowserView::goToURL): Pass the typed string through
3766 CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
3768 2012-01-10 Ben Wells <benwells@chromium.org>
3770 Adding myself (benwells) to committers.py
3771 https://bugs.webkit.org/show_bug.cgi?id=75971
3773 Reviewed by Ojan Vafai.
3775 * Scripts/webkitpy/common/config/committers.py:
3777 2012-01-10 Mario Sanchez Prada <msanchez@igalia.com>
3779 AX: support helpText() in DumpRenderTree
3780 https://bugs.webkit.org/show_bug.cgi?id=40193
3782 Reviewed by Chris Fleizach.
3784 * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3785 (AccessibilityUIElement::helpText): Implemented.
3787 2012-01-10 Sheriff Bot <webkit.review.bot@gmail.com>
3789 Unreviewed, rolling out r104572.
3790 http://trac.webkit.org/changeset/104572
3791 https://bugs.webkit.org/show_bug.cgi?id=75967
3793 It broke zillion tests (Requested by Ossy on #webkit).
3795 * DumpRenderTree/qt/EventSenderQt.cpp:
3796 (EventSender::EventSender):
3797 (EventSender::sendOrQueueEvent):
3798 (EventSender::replaySavedEvents):
3799 (EventSender::eventFilter):
3800 * DumpRenderTree/qt/EventSenderQt.h:
3802 2012-01-10 Hugo Parente Lima <hugo.lima@openbossa.org>
3804 [Qt] fast/events/dont-loose-last-event test fails on WK1
3805 https://bugs.webkit.org/show_bug.cgi?id=73894
3807 Reviewed by Simon Hausmann.
3809 Empty the entire event queue when requested besides using
3810 sendEvent instead of postEvent to make sure all events were
3812 This commit also removes not working DRT code to handle drag and drop,
3813 for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
3815 * DumpRenderTree/qt/EventSenderQt.cpp:
3816 (EventSender::EventSender):
3817 (EventSender::sendOrQueueEvent):
3818 (EventSender::replaySavedEvents):
3819 * DumpRenderTree/qt/EventSenderQt.h:
3821 2012-01-10 No'am Rosenthal <noam.rosenthal@nokia.com>
3823 [Qt] Enable CSS_FILTERS in Qt build
3824 https://bugs.webkit.org/show_bug.cgi?id=75777
3826 Add the CSS_FILTERS feature flag to Qt.
3828 Reviewed by Kenneth Rohde Christiansen.
3830 * qmake/mkspecs/features/features.prf:
3832 2012-01-10 Simon Hausmann <simon.hausmann@nokia.com>
3834 [Qt] Unreviewed -Werror build fix.
3836 * MiniBrowser/qt/MiniBrowserApplication.cpp:
3837 (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
3840 2012-01-10 Simon Hausmann <simon.hausmann@nokia.com>
3842 [Qt] Remove dependency to uitools
3843 https://bugs.webkit.org/show_bug.cgi?id=75952
3845 Reviewed by Tor Arne Vestbø.
3847 QUiLoader is used for creating QLabel/QProgressBar widgets for
3848 a layout test, to verify some widget embedding feature. Unfortunately
3849 in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
3850 depends on qttools. Since we don't really _need_ QUiLoader for our tests,
3851 let's break the circular dependency.
3853 * DumpRenderTree/qt/DumpRenderTree.pro:
3854 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3855 (WebCore::WebPage::createPlugin):
3856 * QtTestBrowser/QtTestBrowser.pro:
3857 * QtTestBrowser/launcherwindow.h:
3858 * QtTestBrowser/webpage.cpp:
3859 (WebPage::createPlugin):
3860 * qmake/mkspecs/features/minimal_qt.prf:
3861 * qmake/mkspecs/features/uitools.prf: Removed.
3863 2012-01-10 Alexander Færøy <alexander.faeroy@nokia.com>
3865 [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
3866 https://bugs.webkit.org/show_bug.cgi?id=75894
3868 Reviewed by Tor Arne Vestbø.
3870 * MiniBrowser/qt/MiniBrowserApplication.h:
3871 (MiniBrowserApplication::windowOptions):
3872 * MiniBrowser/qt/main.cpp:
3875 2012-01-10 Simon Hausmann <simon.hausmann@nokia.com>
3877 [Qt] DRT crashes with Qt 5
3878 https://bugs.webkit.org/show_bug.cgi?id=75951
3882 * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
3883 Qt relies on font-config to define the default font family.
3885 2012-01-10 Csaba Osztrogonác <ossy@webkit.org>
3887 [Qt] REGRESSION(r100130): Clean build feature is broken.
3888 https://bugs.webkit.org/show_bug.cgi?id=75863
3890 Reviewed by Tor Arne Vestbø.
3892 * Scripts/webkitdirs.pm:
3893 (buildQMakeProject):
3895 2012-01-10 Zeno Albisser <zeno@webkit.org>
3897 [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
3898 https://bugs.webkit.org/show_bug.cgi?id=75885
3900 In QML events are propagated through parents. But since the
3901 WebView may consume key events, a shortcut might never reach
3902 the top QtQuickItem.
3903 Therefore an application wide event handling function in C++
3904 needs to take care of shortcuts for MiniBrowser.
3906 Reviewed by Kenneth Rohde Christiansen.
3908 * MiniBrowser/qt/BrowserWindow.cpp:
3909 (BrowserWindow::reload):
3910 (BrowserWindow::focusAddressBar):
3911 * MiniBrowser/qt/BrowserWindow.h:
3912 * MiniBrowser/qt/MiniBrowserApplication.cpp:
3913 (MiniBrowserApplication::notify):
3914 * MiniBrowser/qt/qml/BrowserWindow.qml:
3916 2012-01-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3918 Add --efl alias for --platform=efl to run-webkit-test
3919 https://bugs.webkit.org/show_bug.cgi?id=75937
3921 Reviewed by Andreas Kling.
3923 * Scripts/run-webkit-tests: Add --efl alias.
3924 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
3927 2012-01-09 Dan Bernstein <mitz@apple.com>
3929 -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
3930 https://bugs.webkit.org/show_bug.cgi?id=75920
3932 Reviewed by Darin Adler.
3934 * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
3935 (TestWebKitAPI::TEST): Added a test for a range in a
3936 -webkit-user-select: none; block.
3938 2012-01-09 Dirk Pranke <dpranke@chromium.org>
3940 webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
3941 https://bugs.webkit.org/show_bug.cgi?id=75884
3943 Reviewed by Ryosuke Niwa.
3945 Fix regression introduced (revealed?) in r104340. Chromium file
3946 url syntax is different on win32 and the test results weren't
3949 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3950 (TestExpectations._report_errors):
3951 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3952 (test_parse_error_nonfatal):
3953 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3954 (MockDRTTest.input_line):
3955 (MockChromiumDRTTest.test_pixeltest__fails):
3956 * Scripts/webkitpy/layout_tests/port/test.py:
3957 * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3958 (TestRebaseliner.make_rebaseliner):
3959 (TestRebaseliner.test_one_platform):
3960 (TestRebaseliner.test_all_platforms):
3961 (TestRebaseliner.test_png_file_with_comment):
3962 (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
3963 (TestRebaseliner.test_png_file_with_comment_as_duplicate):
3964 (TestRealMain.test_all_platforms):
3966 2012-01-09 Dirk Pranke <dpranke@chromium.org>
3968 Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
3970 Unreviewed, build fix.
3972 test-webkitpy had a built-in self-test routine to verify that
3973 deleting the .pyc files worked correctly. When I removed the
3974 python24 directory in r104482, I broke the self-test.
3976 I have deleted the self-test for now. Since I am reworking
3977 test-webkitpy I will make sure the new version is adequately
3980 * Scripts/test-webkitpy:
3981 (configure_logging):
3986 2012-01-09 Justin Novosad <junov@chromium.org>
3988 [Chromium] remove all references to the legacy accelerated 2d Canvas
3990 https://bugs.webkit.org/show_bug.cgi?id=75108
3992 Purging an old settings flag that is no longer referenced
3994 Reviewed by Darin Fisher.
3996 * DumpRenderTree/chromium/DumpRenderTree.cpp:
3998 * DumpRenderTree/chromium/TestShell.cpp:
3999 (TestShell::TestShell):
4000 (TestShell::resetWebSettings):
4001 * DumpRenderTree/chromium/TestShell.h:
4002 (TestShell::setAccelerated2dCanvasEnabled):
4003 * DumpRenderTree/chromium/WebPreferences.cpp:
4004 (WebPreferences::reset):
4005 (WebPreferences::applyTo):
4006 * DumpRenderTree/chromium/WebPreferences.h:
4008 2012-01-09 Adam Roben <aroben@apple.com>
4010 Convert Cygwin paths to Windows paths before passing them to DRT
4012 Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
4015 I couldn't find a way to test this because I couldn't figure out how to override the
4016 cygpath function as it is used by WebKitDriver.
4018 Reviewed by Dirk Pranke.
4020 * Scripts/webkitpy/layout_tests/port/webkit.py:
4021 (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
4022 Windows-style path before passing it to DRT.
4024 2012-01-06 Dirk Pranke <dpranke@chromium.org>
4026 webkitpy: revamp version checking
4027 https://bugs.webkit.org/show_bug.cgi?id=75765
4029 Reviewed by Adam Barth.
4031 The version-checking code in webkitpy/python24/versioning seems really
4032 awkward and overdesigned, especially since we don't support python 2.4
4035 In addition, I am tired of getting warnings about Python 2.6 being "a
4036 newer release than what is supported" :).
4038 I'm taking a page from the depot_tools python code and just creating a
4039 new webkitpy.common.version_check module that will print a message on
4040 stderr and call sys.exit() if we're running an unsupported version.
4042 * Scripts/check-webkit-style:
4043 * Scripts/new-run-webkit-httpd:
4044 * Scripts/new-run-webkit-tests:
4045 * Scripts/rebaseline-chromium-webkit-tests:
4046 * Scripts/test-webkitpy:
4047 (configure_logging):
4049 * Scripts/webkit-patch:
4051 * Scripts/webkitpy/common/system/executive.py:
4052 (Executive._child_process_encoding):
4053 (Executive._should_encode_child_process_arguments):
4054 * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
4055 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4056 * Scripts/webkitpy/python24/__init__.py: Removed.
4057 * Scripts/webkitpy/python24/versioning.py: Removed.
4058 * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
4060 2012-01-09 Adam Barth <abarth@webkit.org>
4062 Remove Chromium Mac CG from the flakiness dashboard
4063 https://bugs.webkit.org/show_bug.cgi?id=75873
4065 Reviewed by Ojan Vafai.
4067 This configuration no longer exists.
4069 * TestResultServer/static-dashboards/builders.js:
4070 * TestResultServer/static-dashboards/flakiness_dashboard.html:
4071 * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
4072 (testOverrideJustBuildType):
4073 (testPlatformAndBuildType):
4075 2012-01-06 Adam Roben <aroben@apple.com>
4077 Print an error message when NRWT can't run Apache
4079 Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
4081 Reviewed by Dirk Pranke.
4083 * Scripts/webkitpy/layout_tests/port/base.py:
4084 (Port.check_httpd): Print an error message when Apache returns an error code instead of
4087 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4088 (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
4090 (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
4093 2012-01-09 Gabor Rapcsanyi <rgabor@webkit.org>
4095 [Gtk][ARM] Cross compiler buildbot is failing after r103040
4096 https://bugs.webkit.org/show_bug.cgi?id=75846
4098 Reviewed by Philippe Normand.
4100 * Scripts/webkitdirs.pm:
4101 (runAutogenForAutotoolsProjectIfNecessary):
4103 2012-01-09 Alexander Færøy <ahf@0x90.dk>
4105 [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
4106 https://bugs.webkit.org/show_bug.cgi?id=75807
4108 This patch adds a new icon to navigationbar of the Qt MiniBrowser
4109 which allows you to dynamically toggle whether touch mocking is
4110 enabled or disabled.
4112 Reviewed by Tor Arne Vestbø.
4114 * MiniBrowser/qt/MiniBrowser.qrc:
4115 * MiniBrowser/qt/MiniBrowserApplication.cpp:
4116 (MiniBrowserApplication::notify):
4117 * MiniBrowser/qt/MiniBrowserApplication.h:
4118 (WindowOptions::WindowOptions):
4119 (WindowOptions::touchMockingEnabled):
4120 (WindowOptions::setTouchMockingEnabled):
4121 * MiniBrowser/qt/icons/touch.png: Added.
4122 * MiniBrowser/qt/qml/BrowserWindow.qml:
4124 2012-01-09 Carlos Garcia Campos <cgarcia@igalia.com>
4126 Unreviewed. Fix make distcheck issues.
4128 * MiniBrowser/gtk/GNUmakefile.am:
4130 2012-01-08 Sheriff Bot <webkit.review.bot@gmail.com>
4132 Unreviewed, rolling out r104421.
4133 http://trac.webkit.org/changeset/104421
4134 https://bugs.webkit.org/show_bug.cgi?id=75816
4136 Need to rebaseline some tests on Linux (Requested by noamr on
4139 * qmake/mkspecs/features/features.prf:
4141 2012-01-08 Adam Barth <abarth@webkit.org>
4143 Remove support for Chromium Mac CG from garden-o-matic
4144 https://bugs.webkit.org/show_bug.cgi?id=75814
4146 Reviewed by Eric Seidel.
4148 This configuration no longer exists. This patch is mostly a matter of
4149 updating config.js and removing the examples from the unit tests.
4151 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
4152 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
4153 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
4154 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
4155 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
4157 2012-01-08 No'am Rosenthal <noam.rosenthal@nokia.com>
4159 [Qt] Enable CSS_FILTERS in Qt build
4160 https://bugs.webkit.org/show_bug.cgi?id=75777
4162 Add the CSS_FILTERS feature flag to Qt.
4164 Reviewed by Kenneth Rohde Christiansen.
4166 * qmake/mkspecs/features/features.prf:
4168 2012-01-08 Ryosuke Niwa <rniwa@webkit.org>
4170 Categorize bots by ports instead of core/non-core separation
4171 https://bugs.webkit.org/show_bug.cgi?id=75766
4173 Reviewed by Eric Seidel.
4175 Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
4176 (Chromium still comes before GTK and Qt).
4178 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4179 (loadBuilderConfig):
4180 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
4182 2012-01-08 Ryosuke Niwa <rniwa@webkit.org>
4184 Remove the concept of core builders from webkitpy
4185 https://bugs.webkit.org/show_bug.cgi?id=75809
4187 Reviewed by Ryosuke Niwa.
4189 Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
4190 and remove the relevant code.
4192 * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4193 (BuildBot.__init__):
4194 (BuildBot._matches_regexps):
4195 (BuildBot._builder_statuses_with_names_matching_regexps):
4196 (BuildBot.builder_statuses):
4197 (BuildBot.failure_map):
4198 (BuildBot._latest_builds_from_builders):
4199 (BuildBot.last_green_revision):
4200 * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
4201 (MockBuildBot.builder_statuses):
4202 * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4203 (test_status_parsing):
4204 (test_last_green_revision):
4205 (test_last_green_revision.mock_builds_from_builders):
4207 2012-01-08 Adam Barth <abarth@webkit.org>
4209 Remove Chromium Mac CG concept from webkitpy
4210 https://bugs.webkit.org/show_bug.cgi?id=75810
4212 Reviewed by Ryosuke Niwa.
4214 This configuration no longer exists. We can remove all the supporting
4217 * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
4218 (BaselineOptimizerTest.test_move_baselines):
4219 (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
4220 (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
4221 (BaselineOptimizerTest.test_common_directory_includes_root):
4222 (BaselineOptimizerTest.test_complex_shadowing):
4223 * Scripts/webkitpy/common/config/build.py:
4224 (_should_file_trigger_build):
4225 * Scripts/webkitpy/common/config/build_unittest.py:
4227 * Scripts/webkitpy/layout_tests/port/builders.py:
4228 * Scripts/webkitpy/layout_tests/port/chromium.py:
4230 (ChromiumPort._generate_all_test_configurations):
4231 * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4232 (_default_tests_paths):
4233 (ChromiumGpuLinuxPort.tests):
4234 * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
4235 (ChromiumGpuTest.integration_test_chromium_gpu_mac):
4236 (ChromiumGpuTest.assert_port_works):
4237 (ChromiumGpuTest.test_baseline_paths):
4238 (ChromiumGpuTest.test_graphics_type):
4239 (ChromiumGpuTest.test_default_tests_paths):
4240 (ChromiumGpuTest.test_test_files):
4241 * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4243 (ChromiumMacPort.__init__):
4244 (ChromiumMacPort.baseline_search_path):
4245 * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4246 (ChromiumMacPortTest.test_graphics_type):
4247 * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4248 (ChromiumPortTest.test_all_test_configurations):
4249 * Scripts/webkitpy/layout_tests/port/dryrun.py:
4250 * Scripts/webkitpy/layout_tests/port/factory.py:
4251 (PortFactory._port_name_from_arguments_and_options):
4253 * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
4254 (FactoryTest.test_chromium_gpu_mac):
4255 (FactoryTest.test_chromium_mac):
4256 * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
4257 (GetGoogleChromePortTest._verify_expectations_overrides):
4258 * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
4259 (MockChromiumDRTTest.test_chromium_parse_options):
4260 * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
4261 * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
4265 * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4266 (TestRebaseline.test_rebaseline_expectations):
4268 2012-01-08 Ryosuke Niwa <rniwa@webkit.org>
4270 Categorize bots by ports instead of core/non-core separation
4271 https://bugs.webkit.org/show_bug.cgi?id=75766
4273 Reviewed by Adam Barth.
4275 Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
4277 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4278 (loadBuilderConfig):
4279 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
4281 2012-01-08 Sheriff Bot <webkit.review.bot@gmail.com>
4283 Unreviewed, rolling out r104403.
4284 http://trac.webkit.org/changeset/104403
4285 https://bugs.webkit.org/show_bug.cgi?id=75803
4287 It broke all tests on Qt5 (Requested by Ossy_weekend on
4290 * qmake/mkspecs/features/features.prf:
4292 2012-01-08 No'am Rosenthal <noam.rosenthal@nokia.com>
4294 [Qt] Enable CSS_FILTERS in Qt build
4295 https://bugs.webkit.org/show_bug.cgi?id=75777
4297 Add the CSS_FILTERS feature flag to Qt.
4299 Reviewed by Kenneth Rohde Christiansen.
4301 * qmake/mkspecs/features/features.prf:
4303 2012-01-04 Kentaro Hara <haraken@chromium.org>
4305 Rewrite the CSS parser of prepare-ChangeLog with unittests.
4306 https://bugs.webkit.org/show_bug.cgi?id=75202
4308 Reviewed by David Kilzer.
4310 The current CSS parser can just parse simple CSSes like
4317 , and cannot parse comments nor a CSS in which a selector and {
4318 appears in different lines. This patch rewrites the CSS parser
4319 (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
4320 shown in css_unittests.css.
4322 Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
4324 * Scripts/prepare-ChangeLog:
4325 (get_selector_line_ranges_for_css):
4326 * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
4327 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
4328 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
4335 (element7 element8):
4336 (element9.p element10.q):
4337 (element11#p element12#q):
4338 (element13, element14):
4341 (.p element15 #q element16.r element17#s):
4348 2012-01-04 Kentaro Hara <haraken@chromium.org>
4350 The Perl parser of prepare-ChangeLog can parse here-documents
4351 https://bugs.webkit.org/show_bug.cgi?id=73208
4353 Reviewed by David Kilzer.
4355 Currently prepare-ChangeLog cannot recognize here-documents in Perl,
4356 which results in wrong subroutine names in ChangeLogs.
4357 With this patch, prepare-ChangeLog can judge whether the line of "}"
4358 is the end of a subroutine or a line inside a here-document.
4360 Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
4362 * Scripts/prepare-ChangeLog:
4363 (get_function_line_ranges_for_perl):
4364 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
4365 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
4366 Added test cases for here-documents.